s390: Implement 'type_align' gdbarch method
[external/binutils.git] / gdb / ChangeLog
1 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2
3         * s390-tdep.c (s390_type_align): New function.
4         (s390_gdbarch_init): Set it as type_align gdbarch method.
5
6 2019-08-09  Tom de Vries  <tdevries@suse.de>
7
8         PR gdb/24591
9         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
10         pc_low with relocation offset.
11
12 2019-08-07  Tom Tromey  <tromey@adacore.com>
13
14         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
15         (print_frame_args): Update.
16         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
17         Update.
18         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
19         * frame.h (struct frame_arg): Add initializers.
20         <error>: Now a unique_xmalloc_ptr.
21
22 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
23
24         * NEWS: Expand the Pointer Authentication entry.
25         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
26         (aarch64_frame_unmask_lr): ... to this.
27         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
28         Call aarch64_frame_unmask_lr.
29         * frame.c (struct frame_info): Add "masked" variable.
30         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
31         (fprint_frame): Check for masked pc.
32         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
33         declarations.
34         * python/py-framefilter.c (py_print_frame): Check for masked pc.
35         * stack.c (print_frame): Check for masked pc.
36
37 2019-08-06  Tom Tromey  <tom@tromey.com>
38
39         * stabsread.c (patch_block_stabs, read_one_struct_field)
40         (read_enum_type): Use obstack_strndup.
41         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
42         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
43         * dwarf2read.c (guess_full_die_structure_name)
44         (anonymous_struct_prefix): Use obstack_strndup.
45         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
46         * c-exp.y (yylex): Use obstack_strndup.
47         * ada-exp.y (write_object_renaming, write_ambiguous_var)
48         (write_var_or_type): Use obstack_strndup.
49
50 2019-08-06  Tom Tromey  <tom@tromey.com>
51
52         * symfile.c (reread_symbols): Use obstack_strdup.
53         * stabsread.c (read_type): Use obstack_strdup.
54         * gdb_obstack.h (obstack_strdup): New overload.
55         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
56         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
57         (dwarf2_canonicalize_name): Use obstack_strdup.
58         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
59         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
60         Use obstack_strdup.
61
62 2019-08-06  Tom Tromey  <tom@tromey.com>
63
64         * gdb_obstack.h (obstack_strdup): Define.
65         * gdb_obstack.c (obstack_strdup): Don't define.
66
67 2019-08-06  Tom Tromey  <tom@tromey.com>
68
69         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
70         obstack_strdup.
71         * typeprint.c (typedef_hash_table::find_global_typedef): Use
72         obstack_strdup.
73         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
74         * stabsread.c (common_block_start): Use obstack_strdup.
75         * objfiles.c (set_objfile_main_name, objfile): Use
76         obstack_strdup.
77         * namespace.c (add_using_directive): Use obstack_strdup.
78         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
79         * jit.c (finalize_symtab): Use obstack_strdup.
80         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
81         (guess_partial_die_structure_name, partial_die_info::fixup)
82         (dwarf2_name): Use obstack_strdup.
83         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
84         obstack_strdup.
85         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
86         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
87         obstack_strdup.
88         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
89
90 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
91
92         * unittests/help-doc-selftests.c: New file.
93         * Makefile.in: Add the new file.
94
95 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
96
97         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
98         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
99         the full first line, except when FOR_VALUE_PREFIX.  In this case,
100         the trailing '.' is not output, and the first character is uppercased.
101         (print_help_for_command): Update call to print_doc_line.
102         (print_doc_of_command): Likewise.
103         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
104         * cli/cli-option.c (append_indented_doc): Do not append newline.
105         (build_help_option): Append newline after first appended_indented_doc
106         only if a second call is done.
107         (build_help): Append 2 new lines before each option, except the first
108         one.
109         * compile/compile.c (_initialize_compile): Add new lines after
110         %OPTIONS%, when not at the end of the help.
111         Change help doc or code
112         producing the help doc to respect the invariants.
113         * maint-test-options.c (_initialize_maint_test_options): Likewise.
114         Also removed the new line after 'Options:', as all other commands
115         do not put an empty line between 'Options:' and the first option.
116         * printcmd.c (_initialize_printcmd): Likewise.
117         * stack.c (_initialize_stack): Likewise.
118         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
119         incorrectly telling COMMAND is optional.
120         * ada-lang.c (_initialize_ada_language): Change help doc or code
121         producing the help doc to respect the invariants.
122         * ada-tasks.c (_initialize_ada_tasks): Likewise.
123         * breakpoint.c (_initialize_breakpoint): Likewise.
124         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
125         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
126         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
127         * cli/cli-style.c (cli_style_option::add_setshow_commands,
128         _initialize_cli_style): Likewise.
129         * corelow.c (core_target_info): Likewise.
130         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
131         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
132         * filesystem.c (_initialize_filesystem): Likewise.
133         * frame.c (_initialize_frame): Likewise.
134         * gnu-nat.c (add_task_commands): Likewise.
135         * infcall.c (_initialize_infcall): Likewise.
136         * infcmd.c (_initialize_infcmd): Likewise.
137         * interps.c (_initialize_interpreter): Likewise.
138         * language.c (_initialize_language): Likewise.
139         * linux-fork.c (_initialize_linux_fork): Likewise.
140         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
141         * maint.c (_initialize_maint_cmds): Likewise.
142         * memattr.c (_initialize_mem): Likewise.
143         * printcmd.c (_initialize_printcmd): Likewise.
144         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
145         _RegEx): Likewise.
146         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
147         * record-btrace.c (_initialize_record_btrace): Likewise.
148         * record-full.c (_initialize_record_full): Likewise.
149         * record.c (_initialize_record): Likewise.
150         * regcache-dump.c (_initialize_regcache_dump): Likewise.
151         * regcache.c (_initialize_regcache): Likewise.
152         * remote.c (add_packet_config_cmd, init_remote_threadtests,
153         _initialize_remote): Likewise.
154         * ser-tcp.c (_initialize_ser_tcp): Likewise.
155         * serial.c (_initialize_serial): Likewise.
156         * skip.c (_initialize_step_skip): Likewise.
157         * source.c (_initialize_source): Likewise.
158         * stack.c (_initialize_stack): Likewise.
159         * symfile.c (_initialize_symfile): Likewise.
160         * symtab.c (_initialize_symtab): Likewise.
161         * target-descriptions.c (_initialize_target_descriptions): Likewise.
162         * top.c (init_main): Likewise.
163         * tracefile-tfile.c (tfile_target_info): Likewise.
164         * tracepoint.c (_initialize_tracepoint): Likewise.
165         * tui/tui-win.c (_initialize_tui_win): Likewise.
166         * utils.c (add_internal_problem_command): Likewise.
167         * valprint.c (value_print_option_defs): Likewise.
168
169 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
170
171         PR build/24886
172         * configure.ac: Drop enable-libmcheck support.
173         * configure, config.in: Rebuild.
174         * libmcheck.m4: Remove.
175         * acinclude.m4: Don't include it.
176         * Makefile.in: Don't distribute it.
177         * top.c (print_gdb_configuration): Don't mention it.
178
179 2019-08-06  Tom Tromey  <tom@tromey.com>
180
181         * utils.c (set_output_style): Sometimes pass stream to
182         emit_style_escape.
183         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
184         * record-btrace.c (btrace_insn_history): Update.
185         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
186         method.
187         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
188         Update initializers.
189         <m_uiout>: New field.
190         <m_di>: Move lower.
191         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
192         Remove "uiout" parameter.
193         (dump_insns): Update.
194         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
195         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
196
197 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
198
199         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
200         (error_in_psymtab_expansion): Likewise.
201         (lookup_symbol_via_quick_fns): Likewise.
202         (basic_lookup_transparent_type_quick): Likewise.
203         (basic_lookup_transparent_type_1): Likewise.
204
205 2019-08-06  Tom Tromey  <tromey@adacore.com>
206
207         * source.c (last_source_error): Now bool.
208         (print_source_lines_base): Make "noprint" bool.  Only open
209         source file when last_source_visited changes.
210
211 2019-08-06  Tom Tromey  <tromey@adacore.com>
212
213         * annotate.c (annotate_source_line): Use g_source_cache.
214         * source-cache.c (source_cache::get_plain_source_lines): Change
215         parameters.  Populate m_offset_cache.
216         (source_cache::ensure): New method.
217         (source_cache::get_line_charpos): New method.
218         (extract_lines): Move lower.  Change parameters.
219         (source_cache::get_source_lines): Move lower.
220         * source-cache.h (class source_cache): Update comment.
221         <get_line_charpos>: New method.
222         <get_source_lines>: Update comment.
223         <clear>: Clear m_offset_cache.
224         <get_plain_source_lines>: Change parameters.
225         <ensure>: New method
226         <m_offset_cache>: New member.
227         * source.c (forget_cached_source_info_for_objfile): Update.
228         (info_source_command): Use g_source_cache.
229         (find_source_lines, open_source_file_with_line_charpos): Remove.
230         (print_source_lines_base, search_command_helper): Use g_source_cache.
231         * source.h (open_source_file_with_line_charpos): Don't declare.
232         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
233         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
234         Use g_source_cache.
235
236 2019-08-06  Tom Tromey  <tromey@adacore.com>
237
238         * source-cache.c (source_cache::get_plain_source_lines):
239         Remove "first_line" and "last_line" parameters.
240         (source_cache::get_source_lines): Cache plain text.
241         * source-cache.h (class source_cache)
242         <get_plain_source_lines>: Update.
243
244 2019-08-06  Tom Tromey  <tromey@adacore.com>
245
246         * source-cache.c (extract_lines): No longer a method.
247         Changed type of parameter.  Include final newline.
248         (selftests::extract_lines_test): New function.
249         (_initialize_source_cache): Likewise.
250         * source-cache.h (class source_cache)
251         <extract_lines>: Don't declare.
252
253 2019-08-06  Tom Tromey  <tromey@adacore.com>
254
255         * breakpoint.c (init_breakpoint_sal): Update.
256         (breakpoint): Update.
257         * breakpoint.h (struct breakpoint) <filter>: Now a
258         unique_xmalloc_ptr.
259
260 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
261
262         * NEWS: Mention dictionary access on blocks.
263         * python/py-block.c (blpy_getitem): New function.
264         (block_object_as_mapping): New struct.
265         (block_object_type): Use new struct for tp_as_mapping field.
266
267 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
268
269         * objfiles.h (objfile): Add a comment describing partial symbols.
270
271 2019-08-05  Tom Tromey  <tromey@adacore.com>
272
273         * compile/compile.c (_initialize_compile): Use _(), not N_().
274         * thread.c (_initialize_thread): Use _(), not N_().
275         * stack.c (_initialize_stack): Use _(), not N_().
276         * printcmd.c (_initialize_printcmd): Use _(), not N_().
277
278 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
279
280         * dwarf2read.c (struct dw2_symtab_iterator):
281         <want_specific_block>: Remove.
282         <block_index>: Change type to gdb::optional.
283         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
284         change type of BLOCK_INDEX parameter to gdb::optional.
285         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
286         (dw2_lookup_symbol): Don't pass argument for
287         WANT_SPECIFIC_BLOCK.
288         (dw2_expand_symtabs_for_function): Don't pass argument for
289         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
290         (class dw2_debug_names_iterator)
291         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
292         parameter, change BLOCK_INDEX type to gdb::optional.
293         <m_want_specific_block>: Remove.
294         <m_block_index>: Change type to gdb::optional.
295         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
296         gdb::optional.  Re-write in function of gdb::optional.
297         (dw2_debug_names_lookup_symbol): Don't pass argument for
298         WANT_SPECIFIC_BLOCK.
299         (dw2_debug_names_expand_symtabs_for_function): Don't pass
300         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
301         BLOCK_INDEX.
302
303 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
304
305         * NEWS: Mention changes to "info sources" command.
306
307 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
308
309         * symtab.c (filename_partial_match_opts): New struct type.
310         (struct output_source_filename_data): New members
311         regexp, c_regexp, partial_match.
312         (output_source_filename): Use new members to decide to print file.
313         (info_sources_option_defs): New variable.
314         (make_info_sources_options_def_group, print_info_sources_header,
315         info_sources_command_completer):
316         New functions.
317         (info_sources_command): Read new optional arguments.
318         (_initialize_symtab): Update info sources help.
319
320 2019-08-02  Alexandre Oliva <oliva@adacore.com>
321
322         * ada-lang.c (exception_support_info_v0): Renamed from...
323         (default_exception_support_info): ... this.  Create new
324         definition for v1.
325         (ada_has_this_exception_support): Look up catch_handlers_sym.
326         (ada_exception_support_info_sniffer): Try v0 after default.
327
328 2019-08-01  Tom Tromey  <tromey@adacore.com>
329
330         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
331         gdbarch.h.
332
333 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
334
335         * s12z-tdep.c: Fix include path for s12z-opc.h.
336
337 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
338
339         * NEWS: Require GNU make 3.82.
340
341 2019-07-16  Tom Tromey  <tom@tromey.com>
342
343         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
344         declare.
345
346 2019-07-30  Tom Tromey  <tromey@adacore.com>
347
348         * block.c (contained_in): Remove BLOCK_FUNCTION check.
349
350 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
351
352         * printcmd.c (print_address_symbolic): Print negative offsets.
353         (build_address_symbolic): Force signed arithmetic when computing
354         offset.
355
356 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
357
358         PR/24474: Add a function to lookup static variables.
359         * NEWS: Mention this new function.
360         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
361         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
362         * python/python.c (python_GdbMethods): Add new function.
363
364 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
365
366         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
367         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
368         (objfpy_lookup_static_symbol): New function.
369         (objfile_object_methods): Add new functions.
370
371 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
372
373         * NEWS: Mention 'set|show print frame-info'.  Mention new
374         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
375         backtrace argument.  Mention that python frame filtering code
376         is now consistent with what 'backtrace' command prints.
377
378 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
379
380         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
381         comments.
382         (print_frame_info_auto, print_frame_info_source_line,
383         print_frame_info_location, print_frame_info_source_and_location,
384         print_frame_info_location_and_address, print_frame_info_short_location):
385         New declarations.
386         (struct frame_print_options): New member print_frame_info.
387         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
388         * stack.h (get_user_print_what_frame_info): New declaration.
389         (frame_show_address): New declaration.
390         * stack.c (print_frame_arguments_choices): New value 'presence'.
391         (print_frame_info_auto, print_frame_info_source_line,
392         print_frame_info_location, print_frame_info_source_and_location,
393         print_frame_info_location_and_address, print_frame_info_short_location,
394         print_frame_info_choices, print_frame_info_print_what): New definitions.
395         (print_frame_args): Only print dots for args if print frame-arguments
396         is 'presence'.
397         (frame_print_option_defs): New element for "frame-info".
398         (get_user_print_what_frame_info): New function.
399         (frame_show_address): Make non static.  Move comment to stack.h.
400         (print_frame_info_to_print_what): New function.
401         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
402         to decide what to print.
403         (backtrace_command_1): Handle the new print_frame_arguments_presence
404         value.
405         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
406         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
407         (py_print_frame): In non-mi mode, use LOCATION as default for
408         print_what, similarly to frame information printed directly by
409         backtrace command. Handle frame-info user option in non MI mode.
410
411 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
412
413         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
414         Add case for debugging 32-bit target on 64-bit host.  Revise
415         comment.
416
417 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
418
419         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
420         instead of find_function_entry_range_from_pc.
421
422 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
423
424         * stack.c (find_frame_funname): Remove code which preferred
425         minsym over symtab sym in "certain pathological cases".
426
427         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
428         parameter.  Change type of "do_demangle" to bool.
429         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
430         Pass suitable "prefer_sym_over_minsym" flag to
431         build_address_symbolic().  Don't output "+" for negative offsets.
432         * printcmd.c (print_address_symbolic): Update invocation of
433         build_address_symbolic to include a "prefer_sym_over_minsym"
434         flag.
435         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
436         Restrict cases in which use of minimal symbol is preferred to that
437         of a found symbol.  Update comments.
438
439         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
440         for entry pc when entry pc is out of range for that FDE.
441
442 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
443
444         PR gdb/24839:
445         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
446         type.
447
448 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
449
450         * python/py-objfile.c (add_separate_debug_file): Fix comment about
451         this function's Python signature.
452
453
454 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
455
456         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
457         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
458         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
459         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
460         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
461
462
463 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
464
465         * h8300-tdep.c (h8300_register_name_common): New.
466         h8300_register_name): Use h8300_register_name_common.
467         (h8300s_register_name): Likewise.
468         (h8300sx_register_name): Likewise.
469         (h8300h_register_nam): New.
470         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
471
472
473 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
474
475         * arm-tdep.c (arm_skip_cmse_entry): New function.
476         (arm_is_sgstubs_section): New function.
477         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
478
479 2019-07-22  Tom Tromey  <tom@tromey.com>
480
481         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
482         Don't self-assign.
483
484 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
485
486         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
487         type_print.
488
489 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
490
491         * symtab.c (search_symbols): Adjust msymbol matching type arrays
492         so that GDB doesn't match any msymbols when searching in the
493         TYPES_DOMAIN.
494         (print_symbol_info): Print using typedef_print or type_print based
495         on the type of the symbol.  Add updated FIXME comment moved from...
496         (_initialize_symtab): ... move and update FIXME comment to above.
497
498 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
499
500         * NEWS: Mention adding -q option to "info types".
501         * symtab.c (struct info_types_options): New struct.
502         (info_types_options_defs): New variable.
503         (make_info_types_options_def_group): New function.
504         (info_types_command): Use gdb::option framework to parse options.
505         (info_types_command_completer): New function.
506         (_initialize_symtab): Extend the help text on "info types" and
507         register command completer.
508
509 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
510
511         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
512         (lookup_symbol_in_objfile): Change int to block_enum and add a
513         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
514
515 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
516
517         * MAINTAINERS (Write After Approval): Add self.
518
519 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
520
521         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
522         instruction to the dummy code region.
523
524 2019-07-19  Tom Tromey  <tromey@adacore.com>
525
526         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
527         (ARGSUSED, PARAMS, __func__): Remove rules.
528
529 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
530
531         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
532         * features/arm/arm-with-iwmmxt.c: Remove.
533         * features/arm/arm-with-iwmmxt.xml: Remove.
534         * features/arm/arm-with-m-fpa-layout.c: Remove.
535         * features/arm/arm-with-m-fpa-layout.xml: Remove.
536         * features/arm/arm-with-m-vfp-d16.c: Remove.
537         * features/arm/arm-with-m-vfp-d16.xml: Remove.
538         * features/arm/arm-with-m.c: Remove.
539         * features/arm/arm-with-m.xml: Remove.
540         * features/arm/arm-with-neon.c: Remove.
541         * features/arm/arm-with-neon.xml: Remove.
542         * features/arm/arm-with-vfpv2.c: Remove.
543         * features/arm/arm-with-vfpv2.xml: Remove.
544         * features/arm/arm-with-vfpv3.c: Remove.
545         * features/arm/arm-with-vfpv3.xml: Remove.
546
547 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
548
549         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
550
551 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
552
553         * arch/aarch32.c (aarch32_create_target_description): Create
554         target descriptions using features.
555         * arch/arm.c (arm_create_target_description)
556         (arm_create_mprofile_target_description): Likewise.
557         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
558
559 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
560
561         * Makefile.in: Add new files.
562         * aarch32-tdep.c: New file.
563         * aarch32-tdep.h: New file.
564         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
565         Call aarch32_read_description.
566         * arch/aarch32.c: New file.
567         * arch/aarch32.h: New file.
568         * arch/arm.c (arm_create_target_description)
569         (arm_create_mprofile_target_description): New function.
570         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
571         (arm_create_target_description)
572         (arm_create_mprofile_target_description): New declaration.
573         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
574         read_description functions.
575         * arm-linux-nat.c (arm_linux_nat_target::read_description):
576         Likewise.
577         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
578         * arm-tdep.c (tdesc_arm_list): New variable.
579         (arm_register_g_packet_guesses): Call create description functions.
580         (arm_read_description) (arm_read_mprofile_description): New
581         function.
582         * arm-tdep.h (arm_read_description)
583         (arm_read_mprofile_description): Add declaration.
584         * configure.tgt: Add new files.
585
586 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
587
588         * top.c (new_ui_command): Open specified terminal just once.
589
590 2019-07-18  Tom Tromey  <tromey@adacore.com>
591
592         * symtab.c (main_name): Constify return type.
593         * symfile.c (set_initial_language): Update.
594         * symtab.h (main_name): Constify return type.
595
596 2019-07-17  Tom Tromey  <tom@tromey.com>
597
598         * tui/tui-winsource.c (tui_update_source_window)
599         (tui_update_source_window_as_is)
600         (tui_update_source_windows_with_line): Remove return.
601         * tui/tui-disasm.c (tui_show_disassem)
602         (tui_show_disassem_and_update_source): Remove return.
603         * tui/tui.c (tui_reset): Remove return.
604         * tui/tui-wingeneral.c
605         (tui_check_and_display_highlight_if_needed): Remove return.
606
607 2019-07-17  Tom Tromey  <tom@tromey.com>
608
609         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
610
611 2019-07-17  Tom Tromey  <tom@tromey.com>
612
613         * tui/tui-winsource.h (struct tui_exec_info_window)
614         (struct tui_source_window_base): Move from tui-data.h.
615         * tui/tui-winsource.c: Move many method definitions from
616         elsewhere.  Remove "structuring" comments.
617         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
618         (tui_source_window_base::refresh_window): Move to
619         tui-winsource.c.
620         * tui/tui-win.c (tui_source_window_base::refresh_all)
621         (tui_source_window_base::update_tab_width)
622         (tui_source_window_base::set_new_height)
623         (tui_source_window_base::do_make_visible_with_new_height): Move to
624         tui-winsource.c.
625         * tui/tui-source.h: Update.
626         * tui/tui-source.c (tui_source_window_base::reset): Move to
627         tui-winsource.c.
628         * tui/tui-disasm.h: Update.
629         * tui/tui-data.h (struct tui_exec_info_window): Move to
630         tui-winsource.h.
631         (struct tui_source_window_base): Likewise.
632         * tui/tui-data.c (tui_source_window_base::clear_detail)
633         (tui_source_window_base, ~tui_source_window_base): Move to
634         tui-winsource.c.
635
636 2019-07-17  Tom Tromey  <tom@tromey.com>
637
638         * tui/tui-win.c (tui_resize_all)
639         (tui_source_window_base::update_tab_width)
640         (tui_adjust_win_heights): Update.
641         (tui_win_info::make_invisible_and_set_new_height): Rename from
642         make_invisible_and_set_new_height.
643         * tui/tui-data.h (struct tui_win_info)
644         <make_invisible_and_set_new_height>: New method.
645
646 2019-07-17  Tom Tromey  <tom@tromey.com>
647
648         * tui/tui.c: Update.
649         * tui/tui-source.h (struct tui_source_window): Move from
650         tui-data.h.
651         * tui/tui-layout.c: Update.
652         * tui/tui-disasm.c: Update.
653         * tui/tui-data.h (struct tui_source_window): Move to
654         tui-source.h.
655
656 2019-07-17  Tom Tromey  <tom@tromey.com>
657
658         * tui/tui-disasm.h (struct tui_disasm_window): Move from
659         tui-data.h.
660         * tui/tui-data.h (struct tui_disasm_window): Move to
661         tui-disasm.h.
662
663 2019-07-17  Tom Tromey  <tom@tromey.com>
664
665         * tui/tui-regs.h (struct tui_data_item_window): Move from
666         tui-data.h.
667         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
668         * tui/tui-data.h (struct tui_data_item_window): Move to
669         tui-regs.h.
670         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
671
672 2019-07-17  Tom Tromey  <tom@tromey.com>
673
674         * tui/tui.c: Update.
675         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
676         (tui_cmd_window::max_height): Move to tui-command.c.
677         * tui/tui-layout.c: Update.
678         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
679         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
680         tui-command.c.
681         * tui/tui-command.h (struct tui_cmd_window): Move from
682         tui-data.h.
683         * tui/tui-command.c: Remove "structuring" comments.
684         (tui_cmd_window::clear_detail)
685         (tui_cmd_window::do_make_visible_with_new_height)
686         (tui_cmd_window::max_height): Move from elsewhere.
687
688 2019-07-17  Tom Tromey  <tom@tromey.com>
689
690         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
691         Now static.
692         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
693         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
694
695 2019-07-17  Tom Tromey  <tom@tromey.com>
696
697         * tui/tui.c: Update.
698         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
699         tui-regs.c.
700         * tui/tui-windata.h: Remove file.
701         * tui/tui-windata.c: Remove file.
702         * tui/tui-win.c (tui_data_window::set_new_height)
703         (tui_data_window::do_make_visible_with_new_height): Move to
704         tui-regs.c.
705         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
706         * tui/tui-regs.c: Remove "structuring" comments.
707         (tui_data_window::first_data_item_displayed)
708         (tui_data_window::delete_data_content_windows)
709         (tui_data_window::erase_data_content)
710         (tui_data_window::display_all_data)
711         (tui_data_window::refresh_all)
712         (tui_data_window::do_scroll_vertical)
713         (tui_data_window::clear_detail, tui_data_window::set_new_height)
714         (tui_data_window::do_make_visible_with_new_height)
715         (tui_data_window::refresh_window): Move from elsewhere.
716         (_initialize_tui_regs): Move to end of file.
717         * tui/tui-layout.c: Update.
718         * tui/tui-hooks.c: Update.
719         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
720         * tui/tui-data.c (tui_data_window::clear_detail): Move to
721         tui-regs.c.
722         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
723
724 2019-07-17  Tom Tromey  <tom@tromey.com>
725
726         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
727         seen.
728
729 2019-07-17  Tom Tromey  <tom@tromey.com>
730
731         * tui/tui-win.c (tui_source_window_base::set_new_height)
732         (tui_source_window_base::do_make_visible_with_new_height): Use
733         m_has_locator field directly.
734         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
735         method.
736         (struct tui_source_window_base) <has_locator>: Likewise.
737
738 2019-07-17  Tom Tromey  <tom@tromey.com>
739
740         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
741         Don't declare.
742         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
743         Remove.
744         * tui/tui-win.c (tui_source_window_base::set_new_height)
745         (tui_source_window_base::set_new_height)
746         (make_invisible_and_set_new_height)
747         (tui_source_window_base::do_make_visible_with_new_height)
748         (tui_source_window_base::do_make_visible_with_new_height):
749         Update.
750         * tui/tui-layout.c (show_source_disasm_command, show_data)
751         (show_source_or_disasm_and_command): Update.
752         * tui/tui-layout.c (show_layout): Update.
753
754 2019-07-17  Tom Tromey  <tom@tromey.com>
755
756         * tui/tui-layout.c (make_data_window): Remove.
757         (show_data): Unify creation and re-initialization cases.
758
759 2019-07-17  Tom Tromey  <tom@tromey.com>
760
761         * tui/tui-layout.c (make_source_window, make_disasm_window):
762         Remove.
763         (show_data): Unify creation and re-initialization cases.
764
765 2019-07-17  Tom Tromey  <tom@tromey.com>
766
767         * tui/tui-layout.c (make_command_window): Remove.
768         (show_source_disasm_command, show_source_or_disasm_and_command):
769         Unify creation and re-initialization cases.
770
771 2019-07-17  Tom Tromey  <tom@tromey.com>
772
773         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
774         creation and re-initialization cases.
775
776 2019-07-17  Tom Tromey  <tom@tromey.com>
777
778         * tui/tui-regs.c (tui_get_register): Return void.
779
780 2019-07-17  Tom Tromey  <tom@tromey.com>
781
782         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
783         Simplify.
784
785 2019-07-17  Tom Tromey  <tom@tromey.com>
786
787         * tui/tui-layout.c (show_source_disasm_command): Simplify window
788         resetting.
789
790 2019-07-17  Tom Tromey  <tom@tromey.com>
791
792         * tui/tui.h (tui_set_layout_by_name): Don't declare.
793         * tui/tui-regs.c (tui_reg_layout): New function.
794         (tui_show_registers, tui_reg_command): Use it.
795         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
796         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
797         parameters.
798         (tui_layout_command): Remove.
799
800 2019-07-17  Tom Tromey  <tom@tromey.com>
801
802         * tui/tui-layout.h (tui/tui-layout): Return void.
803         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
804
805 2019-07-17  Tom Tromey  <tom@tromey.com>
806
807         * tui/tui-layout.c (show_source_disasm_command, show_data):
808         Update.
809         (reset_locator): Remove.
810         (show_source_or_disasm_and_command): Update.
811
812 2019-07-17  Tom Tromey  <tom@tromey.com>
813
814         * tui/tui-source.c (tui_source_window_base::reset): Remove
815         win_type parameter.
816         * tui/tui-layout.c (make_command_window, make_source_window)
817         (make_disasm_window, make_data_window)
818         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
819         (reset_locator, show_source_or_disasm_and_command): Update.
820         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
821         win_type parameter.
822         (struct tui_source_window_base) <reset>: Likewise.
823
824 2019-07-17  Tom Tromey  <tom@tromey.com>
825
826         * tui/tui-layout.c (show_source_disasm_command): Use
827         reset_locator.
828         (reset_locator): New function.
829         (init_and_make_win): Remove.
830         (show_source_or_disasm_and_command): Use reset_locator.
831
832 2019-07-17  Tom Tromey  <tom@tromey.com>
833
834         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
835         condition.
836         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
837         Remove condition.
838         * tui/tui-source.c (tui_source_window_base::reset): New method.
839         * tui/tui-layout.c (make_command_window): Don't call
840         init_and_make_win.
841         (make_source_window, make_disasm_window): Don't call
842         make_source_or_disasm_window.
843         (make_data_window): Don't call init_and_make_win.  Change calling
844         convention.
845         (show_source_disasm_command, show_data): Simplify.
846         (make_source_or_disasm_window): Remove.
847         (show_source_or_disasm_and_command): Simplify.
848         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
849         (struct tui_source_window_base) <reset>: Likewise.
850         <execution_info>: Remove initializer.
851         * tui/tui-data.c (tui_source_window_base): Initialize
852         execution_info.
853
854 2019-07-17  Tom Tromey  <tom@tromey.com>
855
856         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
857         variable.
858
859 2019-07-17  Tom Tromey  <tom@tromey.com>
860
861         * tui/tui.c (tui_rl_other_window): Update.
862         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
863         superclass method first.  Always iterate over regs_content.
864         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
865         method.
866         * tui/tui-win.c (tui_set_focus_command): Update.
867
868 2019-07-17  Tom Tromey  <tom@tromey.com>
869
870         * tui/tui-win.c (tui_set_focus_command): Rename from
871         tui_set_focus.  Call tui_enable.
872         (tui_set_focus_command): Remove.
873
874 2019-07-17  Tom Tromey  <tom@tromey.com>
875
876         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
877         refresh_window.
878         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
879         touchwin.
880         (tui_data_window::refresh_window): Call refresh_window on data
881         items.  Always call superclass refresh_window.
882         (tui_win_info::refresh): Remove.
883         (tui_source_window_base::refresh_window): Update.
884         (tui_refresh_all): Update.
885         * tui/tui-layout.c (show_source_disasm_command): Remove call to
886         refresh_window.
887         (show_source_or_disasm_and_command): Likewise.
888         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
889         (struct tui_source_window_base) <refresh>: Likewise.
890
891 2019-07-17  Tom Tromey  <tom@tromey.com>
892
893         * tui/tui-winsource.c (tui_clear_source_content)
894         (tui_show_source_content): Update.
895         * tui/tui-source.c (tui_source_window::showing_source_p): Check
896         whether content is empty.
897         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
898         Remove.
899
900 2019-07-17  Tom Tromey  <tom@tromey.com>
901
902         * tui/tui-winsource.c (tui_erase_source_content): Clear the
903         window's contents.
904         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
905         * tui/tui-source.c (tui_set_source_content_nil): Remove.
906
907 2019-07-17  Tom Tromey  <tom@tromey.com>
908
909         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
910         (struct tui_data_item_window): Update.
911
912 2019-07-17  Tom Tromey  <tom@tromey.com>
913
914         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
915         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
916         defines.
917
918 2019-07-17  Tom Tromey  <tom@tromey.com>
919
920         * tui/tui-winsource.h (tui_erase_source_content)
921         (tui_clear_source_content): Remove "display_prompt" parameter.
922         * tui/tui-winsource.c (tui_update_source_window_as_is)
923         (tui_update_source_windows_with_addr): Update.
924         (tui_clear_source_content): Remove "display_prompt" parameter.
925         (tui_erase_source_content): Likewise.  Simplify.
926         (tui_show_source_content): Update.
927         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
928         * tui/tui-stack.c (tui_show_frame_info): Update.
929         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
930         Remove defines.
931
932 2019-07-17  Tom Tromey  <tom@tromey.com>
933
934         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
935         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
936         parameter.
937         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
938         parameter.
939
940 2019-07-17  Tom Tromey  <tom@tromey.com>
941
942         * tui/tui-winsource.c (tui_clear_source_content)
943         (tui_show_source_content, tui_show_exec_info_content)
944         (tui_clear_exec_info_content): Update.
945         * tui/tui-stack.c (tui_show_locator_content): Update.
946         (tui_show_frame_info): Update.
947         * tui/tui-source.h (tui_source_window): Don't declare.
948         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
949         from tui_source_is_displayed.
950         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
951         Remove field.
952         (struct tui_source_window_base) <content_in_use>: New field.  Now
953         bool.
954         (struct tui_source_window) <showing_source_p>: New method.
955         (TUI_SRC_WIN): Change cast.
956         * tui/tui-data.c (tui_initialize_static_data): Update.
957
958 2019-07-17  Tom Tromey  <tom@tromey.com>
959
960         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
961         location_matches_p.
962         * tui/tui-source.c (tui_source_window::location_matches_p): New
963         method.
964         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
965         method.
966         * tui/tui-data.h (struct tui_source_window_base)
967         <location_matches_p>: New method.
968         (struct tui_source_window, struct tui_disasm_window)
969         <location_matches_p>: Likewise.
970
971 2019-07-17  Tom Tromey  <tom@tromey.com>
972
973         * tui/tui-win.c (tui_set_win_height_command): Rename from
974         tui_set_win_height.
975         (tui_set_win_height_command): Remove.
976
977 2019-07-17  Tom Tromey  <tom@tromey.com>
978
979         * tui/tui-source.c (tui_source_window): New constructor.  Add
980         observer.
981         (~tui_source_window): New destructor.
982         (tui_source_window::style_changed): New method.
983         * tui/tui-hooks.c (tui_redisplay_source): Remove.
984         (tui_attach_detach_observers): Update.
985         * tui/tui-data.h (struct tui_source_window): Make constructor not
986         inline.  Add destructor.
987         (struct tui_source_window) <style_changed>: New method.
988         <m_observable>: New member.
989
990 2019-07-17  Tom Tromey  <tom@tromey.com>
991
992         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
993         * tui/tui-win.c (tui_resize_all): Fix typo.
994
995 2019-07-17  Tom Tromey  <tom@tromey.com>
996
997         * tui/tui-wingeneral.h (tui_refresh_all): Update.
998         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
999         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1000         * tui/tui-win.c (window_name_completer): Use foreach.
1001         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1002         (update_tab_width): Likewise.
1003         * tui/tui-layout.c (show_layout): Update.
1004         * tui/tui-data.h (class tui_window_iterator): New.
1005         (struct all_tui_windows): New.
1006         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1007
1008 2019-07-17  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1011         parameter.  Don't reference globals.
1012         (tui_reg_command): Update.
1013
1014 2019-07-17  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-regs.c (tui_show_registers): Simplify.
1017
1018 2019-07-17  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-regs.c (tui_show_registers): Update.
1021         (tui_show_register_group): Add win_info parameter.
1022
1023 2019-07-17  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1026         Rename from tui_display_reg_element_at_line.
1027         (tui_data_window::display_registers_from_line): Update.
1028         * tui/tui-data.h (struct tui_data_window)
1029         <display_reg_element_at_line>: New method.
1030
1031 2019-07-17  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-regs.h (tui_display_registers_from)
1034         (tui_display_registers_from_line): Don't declare.
1035         * tui/tui-windata.c (tui_data_window::display_all_data)
1036         (tui_data_window::refresh_all)
1037         (tui_data_window::do_scroll_vertical): Update.
1038         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1039         from tui_display_registers_from.
1040         (tui_display_reg_element_at_line): Update.
1041         (tui_data_window::display_registers_from_line): Rename from
1042         tui_display_registers_from_line.
1043         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1044         display_registers_from_line>: New methods.
1045
1046 2019-07-17  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1049         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1050         from tui_erase_data_content.
1051         (tui_data_window::display_all_data)
1052         (tui_data_window::refresh_all)
1053         (tui_data_window::do_scroll_vertical): Update.
1054         * tui/tui-regs.c (tui_show_registers): Update.
1055         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1056         New method.
1057
1058 2019-07-17  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1061         declare.
1062         * tui/tui-windata.c
1063         (tui_data_window::delete_data_content_windows): Rename from
1064         tui_delete_data_content_windows.
1065         (tui_data_window::display_all_data)
1066         (tui_data_window::do_scroll_vertical): Update.
1067         * tui/tui-data.h (struct tui_data_window)
1068         <delete_data_content_windows>: New method.
1069
1070 2019-07-17  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1073         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1074
1075 2019-07-17  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1078         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1079         from tui_display_all_data.
1080         * tui/tui-win.c
1081         (tui_data_window::do_make_visible_with_new_height): Update.
1082         * tui/tui-regs.c (tui_show_registers): Update.
1083         * tui/tui-layout.c (tui_set_layout): Update.
1084         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1085         method.
1086
1087 2019-07-17  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1090         * tui/tui-windata.c (tui_display_data_from): Remove.
1091         (tui_data_window::refresh_all): Update.
1092
1093 2019-07-17  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1096         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1097         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1098         tui_display_registers_from_line.
1099         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1100         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1101         "force_display" parameter.
1102
1103 2019-07-17  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1106         declare.
1107         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1108         Rename from tui_first_reg_element_no_inline.
1109         (tui_display_reg_element_at_line)
1110         (tui_display_registers_from_line): Update.
1111         * tui/tui-data.h (struct tui_data_window)
1112         <first_reg_element_no_inline>: New method.
1113
1114 2019-07-17  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-windata.c (tui_display_data_from)
1117         (tui_data_window::do_scroll_vertical): Update.
1118         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1119         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1120         Rename from tui_line_from_reg_element_no.
1121         (tui_display_registers_from_line): Update.
1122         * tui/tui-data.h (struct tui_data_window)
1123         <line_from_reg_element_no>: New method.
1124
1125 2019-07-17  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1128         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1129         tui_last_regs_line_no.
1130         (tui_display_reg_element_at_line)
1131         (tui_display_registers_from_line): Update.
1132         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1133         method.
1134
1135 2019-07-17  Tom Tromey  <tom@tromey.com>
1136
1137         PR tui/24722:
1138         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1139         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1140         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1141         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1142         (tui_update_breakpoint_info): Likewise.
1143         * tui/tui-hooks.c (tui_event_create_breakpoint)
1144         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1145         Update.
1146
1147 2019-07-17  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1150
1151 2019-07-17  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-winsource.c (tui_update_source_window_as_is)
1154         (tui_update_source_windows_with_addr): Update.
1155         * tui/tui-source.h (tui_set_source_content)
1156         (tui_show_symtab_source): Add "win_info" parameter.
1157         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1158         parameter.
1159         (tui_show_symtab_source): Likewise.
1160
1161 2019-07-17  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-wingeneral.c
1164         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1165
1166 2019-07-17  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1169         (struct tui_cmd_window) <can_scroll>: New method.
1170         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1171         method.
1172
1173 2019-07-17  Tom Tromey  <tromey@adacore.com>
1174
1175         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1176         do_field_signed>: Rename.  Change type of "value".
1177         * ui-out.c (ui_out::field_signed): Rename from field_int.
1178         Change type of "value".
1179         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1180         type of "value".
1181         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1182         do_field_int.  Change type of "value".
1183         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1184         do_field_int.  Change type of "value".
1185         * tracepoint.c (trace_status_mi, tfind_1)
1186         (print_one_static_tracepoint_marker): Update.
1187         * thread.c (print_thread_info_1, print_selected_thread_frame):
1188         Update.
1189         * stack.c (print_frame, print_frame_info): Update.
1190         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1191         Update.
1192         * source.c (print_source_lines_base): Update.
1193         * skip.c (info_skip_command): Update.
1194         * record-btrace.c (btrace_ui_out_decode_error)
1195         (btrace_call_history_src_line): Update.
1196         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1197         Update.
1198         * progspace.c (print_program_space): Update.
1199         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1200         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1201         do_field_int.  Change type of "value".
1202         * mi/mi-out.c (mi_ui_out::do_table_begin)
1203         (mi_ui_out::do_table_header): Update.
1204         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1205         type of "value".
1206         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1207         (mi_cmd_data_list_changed_registers, output_register)
1208         (mi_cmd_data_read_memory, mi_load_progress)
1209         (mi_cmd_trace_frame_collected): Update.
1210         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1211         Update.
1212         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1213         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1214         (mi_cmd_var_list_children, varobj_update_one): Update.
1215         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1216         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1217         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1218         * inferior.c (print_inferior): Update.
1219         * gdb_bfd.c (print_one_bfd): Update.
1220         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1221         Update.
1222         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1223         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1224         do_field_int.  Change type of "value".
1225         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1226         do_field_int.  Change type of "value".
1227         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1228         (print_one_breakpoint_location, print_it_catch_fork)
1229         (print_one_catch_fork, print_it_catch_vfork)
1230         (print_one_catch_vfork, print_it_catch_solib)
1231         (print_it_catch_exec, print_it_ranged_breakpoint)
1232         (print_mention_watchpoint, print_mention_masked_watchpoint)
1233         (bkpt_print_it, update_static_tracepoint): Update.
1234         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1235         * break-catch-syscall.c (print_it_catch_syscall): Update.
1236         * ada-tasks.c (print_ada_task_info): Update.
1237         * ada-lang.c (print_it_exception, print_mention_exception):
1238         Update.
1239
1240 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         PR breakpoints/24541
1243         * gdbarch.c: Regenerate.
1244         * gdbarch.h: Regenerate.
1245         * gdbarch.sh: Adjust return type and parameter types for
1246         'stap_adjust_register'.
1247         (i386_stap_adjust_register): Adjust signature and return new
1248         register name.
1249         * stap-probe.c (stap_parse_register_operand): Adjust use of
1250         'gdbarch_stap_adjust_register'.
1251
1252 2019-07-17  Tom Tromey  <tromey@adacore.com>
1253
1254         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1255         declare VEC.
1256         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1257         std::vector.
1258         (struct s390_process_info): Add initializers.
1259         (s390_add_process): Use new.
1260         (s390_linux_nat_target::low_forget_process): Use delete.
1261         (s390_linux_nat_target::low_new_fork)
1262         (s390_linux_nat_target::stopped_by_watchpoint)
1263         (s390_linux_nat_target::low_prepare_to_resume)
1264         (s390_linux_nat_target::insert_watchpoint)
1265         (s390_linux_nat_target::insert_hw_breakpoint)
1266         (s390_linux_nat_target::remove_watchpoint)
1267         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1268
1269 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1270
1271         * aarch64-fbsd-nat.c: Include regcache.h.
1272         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1273         argument.
1274         (aarch64_fbsd_nat_target::fetch_registers)
1275         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1276         variable.
1277         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1278
1279 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1280
1281         * fbsd-nat.c: Include gdbarch.h.
1282
1283 2019-07-15  Tom Tromey  <tromey@adacore.com>
1284
1285         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1286
1287 2019-07-15  Tom Tromey  <tromey@adacore.com>
1288
1289         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1290         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1291         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1292         * cli-out.c (cli_ui_out::do_field_int): New method.
1293         * ui-out.c (ui_out::field_unsigned): New method.
1294         * symfile.c (generic_load): Use field_unsigned.
1295         (print_transfer_performance): Likewise.
1296         * record-btrace.c (ui_out_field_uint): Remove.
1297         (btrace_call_history_insn_range, btrace_call_history): Use
1298         field_unsigned.
1299         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1300         field_unsigned.
1301         * ui-out.h (class ui_out) <field_unsigned>: New method.
1302         <do_field_unsigned>: Likewise.
1303
1304 2019-07-15  Tom Tromey  <tromey@adacore.com>
1305
1306         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1307         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1308         * target.c (flash_erase_command): Use field_string.
1309         * infrun.c (print_signal_received_reason): Use field_string.
1310         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1311         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1312         field_string.
1313         * ada-tasks.c (print_ada_task_info): Use field_string.
1314
1315 2019-07-15  Tom Tromey  <tromey@adacore.com>
1316
1317         * target.c (flash_erase_command): Use field_core_addr.
1318         * symfile.c (generic_load): Use field_core_addr.
1319         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1320         Use field_core_addr.
1321         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1322         field_core_addr.
1323
1324 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1327         value if its desired type is smaller than a CORE_ADDR and signed.
1328
1329 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1332         of changes to field names, and use new is_reference field to
1333         decide if a property is a reference or not.
1334         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1335         field.
1336         (struct dwarf2_property_baton): Update header comment, rename
1337         'referenced_type' to 'property_type' and update comments.
1338         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1339         default property type, store in property baton, update to take
1340         accound of renamed field.
1341         (read_func_scope): Update call to attr_to_dynamic_prop.
1342         (read_array_type): Likewise.
1343         (dwarf2_per_cu_addr_sized_int_type): New function.
1344         (read_subrange_index_type): Move type finding code to
1345         dwarf2_per_cu_addr_sized_int_type.
1346         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1347         (dwarf2_per_cu_addr_type): New function.
1348         (set_die_type): Update calls to attr_to_dynamic_prop.
1349
1350 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * dwarf2read.c (read_subrange_index_type): New function.
1353         (read_subrange_type): Move code into new function and call it.
1354         * gdbtypes.c (create_range_type): Add some asserts.
1355
1356 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1357
1358         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1359         update return statements.
1360         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1361         declaration, and update comment to match.
1362         * gdbtypes.c (resolve_dynamic_array): Update call to
1363         dwarf2_evaluate_property to match new return type.
1364
1365 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * valarith.c (value_subscripted_rvalue): Change lowerbound
1368         parameter type from int to LONGEST.
1369         * value.h (value_subscripted_rvalue): Likewise in declaration.
1370
1371 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * cli/cli-utils.c (info_print_command_completer): New function.
1374         * cli/cli-utils.h: Add 'completer.h' include, and forward
1375         declaration for 'struct cmd_list_element'.
1376         (info_print_command_completer): Declare.
1377         * stack.c (_initialize_stack): Add completer for 'info locals' and
1378         'info args'.
1379         * symtab.c (_initialize_symtab): Add completer for 'info
1380         variables' and 'info functions'.
1381         * NEWS: Mention completion for additional info commands.
1382
1383 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * cli/cli-utils.c (extract_info_print_args): Delete.
1386         (extract_arg_maybe_quoted): Delete.
1387         (info_print_options_defs): New variable.
1388         (make_info_print_options_def_group): New function.
1389         (extract_info_print_options): Define new function.
1390         * cli/cli-utils.h (extract_info_print_args): Delete.
1391         (struct info_print_options): New structure.
1392         (extract_info_print_options): Declare new function.
1393         * stack.c (info_locals_command): Update to use new
1394         extract_info_print_options, also add a header comment.
1395         (info_args_command): Likewise.
1396         * symtab.c (info_variables_command): Likewise.
1397         (info_functions_command): Likewise.
1398
1399 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1402         to extract string arguments.
1403         * common/common-utils.c (extract_string_maybe_quoted): New function.
1404         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1405
1406 2019-07-11  Tom Tromey  <tromey@adacore.com>
1407
1408         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1409         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1410         * top.h (gdbinit): Don't declare.
1411         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1412         into...
1413         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1414         * top.c (gdb_init): Don't call init_cli_cmds.
1415         (gdbinit): Remove.
1416         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1417
1418 2019-07-11  Tom Tromey  <tromey@adacore.com>
1419
1420         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1421         after it has been moved.
1422
1423 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1424
1425         * valops.c (value_must_coerce_to_target): Change return type to
1426         bool.
1427         * value.h (value_must_coerce_to_target): Likewise.
1428
1429 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1430
1431         * breakpoint.c (is_hardware_watchpoint): Remove
1432         forward-declaration.
1433         (is_masked_watchpoint): Change return type to bool.
1434         (is_tracepoint): Likewise.
1435         (is_breakpoint): Likewise.
1436         (is_hardware_watchpoint): Likewise.
1437         (is_watchpoint): Likewise.
1438         (is_no_memory_software_watchpoint): Likewise.
1439         (is_catchpoint): Likewise.
1440         (breakpoint_1): Make FILTER parameter's return type bool.
1441         is_masked_watchpoint): Change return type to bool.
1442         (save_breakpoints): Make FILTER parameter's return type bool.
1443         * breakpoint.h (is_breakpoint): Change return type to bool.
1444         (is_watchpoint): Likewise.
1445         (is_catchpoint): Likewise.
1446         (is_tracepoint): Likewise.
1447
1448 2019-07-10  Tom Tromey  <tom@tromey.com>
1449
1450         * defs.h: Don't include gdbarch.h.
1451         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1452         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1453         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1454         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1455         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1456         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1457         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1458         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1459         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1460         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1461         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1462         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1463         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1464         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1465         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1466         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1467         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1468         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1469         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1470         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1471         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1472         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1473         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1474         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1475         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1476         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1477         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1478
1479 2019-07-10  Tom Tromey  <tromey@adacore.com>
1480
1481         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1482         * breakpoint.c (init_ada_exception_breakpoint): Register as
1483         bp_catchpoint.
1484         (print_one_breakpoint_location, print_one_breakpoint): Use
1485         is_ada_exception_catchpoint.
1486         * ada-lang.c (class ada_catchpoint_location): Pass
1487         bp_loc_software_breakpoint to bp_location constructor.
1488         (is_ada_exception_catchpoint): New function.
1489
1490 2019-07-10  Tom Tromey  <tromey@adacore.com>
1491
1492         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1493         VEC.
1494         (struct arm_exidx_entry): New method operator<.
1495         (struct arm_exidx_data) <section_maps>: Change type.
1496         (arm_exidx_data_free): Remove.
1497         (arm_exidx_data_key): Change type.  Move lower.
1498         (arm_exidx_new_objfile): Update.
1499         (arm_compare_exidx_entries): Remove.
1500         (arm_find_exidx_entry, _initialize_arm_tdep)
1501
1502 2019-07-10  Tom Tromey  <tromey@adacore.com>
1503
1504         * solib-spu.c (ocl_program_data_key): Change type.
1505         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1506         Update.
1507
1508 2019-07-10  Tom Tromey  <tromey@adacore.com>
1509
1510         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1511         (struct solib_aix_inferior_data) <library_list>: Change type.
1512         (solib_aix_inferior_data_handle): Change type.
1513         (get_solib_aix_inferior_data): Update.
1514         (solib_aix_free_library_list): Remove.
1515         (library_list_start_library): Update.
1516         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1517         return type.
1518         (solib_aix_get_library_list)
1519         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1520         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1521
1522 2019-07-10  Tom Tromey  <tromey@adacore.com>
1523
1524         * solib-dsbt.c (struct dsbt_info): Add initializers.
1525         (solib_dsbt_pspace_data): Change type.
1526         (dsbt_pspace_data_cleanup): Remove.
1527         (get_dsbt_info, _initialize_dsbt_solib): Update.
1528
1529 2019-07-10  Tom Tromey  <tromey@adacore.com>
1530
1531         * spu-tdep.c (spu_overlay_data): Change type.
1532         (spu_get_overlay_table, spu_overlay_new_objfile)
1533         (_initialize_spu_tdep): Update.
1534
1535 2019-07-10  Tom Tromey  <tromey@adacore.com>
1536
1537         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1538         destructor.
1539         (dbx_objfile_data_key): Change type and declare later.
1540         (DBX_SYMFILE_INFO): Rewrite.
1541         * dbxread.c (dbx_objfile_data_key): Change type.
1542         (dbx_symfile_init): Update.
1543         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1544         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1545         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1546
1547 2019-07-10  Tom Tromey  <tromey@adacore.com>
1548
1549         * jit.c (jit_program_space_key): Change type.  Move lower.
1550         (get_jit_program_space_data): Update.
1551         (jit_program_space_data_cleanup): Remove.
1552         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1553         Update.
1554         (struct jit_program_space_data): Add initializers.
1555
1556 2019-07-10  Tom Tromey  <tromey@adacore.com>
1557
1558         * solib-darwin.c (struct darwin_info): Add initializers.
1559         (solib_darwin_pspace_data): Change type.
1560         (darwin_pspace_data_cleanup): Remove.
1561         (get_darwin_info, _initialize_darwin_solib): Update.
1562
1563 2019-07-10  Tom Tromey  <tromey@adacore.com>
1564
1565         * remote-sim.c (struct sim_inferior_data): Add initializers,
1566         constructor, and destructor.
1567         (sim_inferior_data_key): Change type.  Move lower.
1568         (check_for_duplicate_sim_descriptor): Update.
1569         (get_sim_inferior_data): Use new.  Update.
1570         (~sim_inferior_data_cleanup): Rename from
1571         sim_inferior_data_cleanup.  Simplify.
1572         (gdbsim_close_inferior, simulator_command)
1573         (sim_command_completer, _initialize_remote_sim): Update.
1574         (next_pid, INITIAL_PID): Move earlier.
1575
1576 2019-07-10  Tom Tromey  <tromey@adacore.com>
1577
1578         * python/python-internal.h (create_thread_object): Return
1579         gdbpy_ref.
1580         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1581         * python/py-inferior.c (struct threadlist_entry): Add
1582         constructor.
1583         <thread_obj>: Now a gdbpy_ref.
1584         (thread_to_thread_object): Update.
1585         (add_thread_object): Use new.
1586         (delete_thread_object): Use delete.
1587         (infpy_threads): Update.
1588         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1589         GIL.
1590
1591 2019-07-10  Tom Tromey  <tromey@adacore.com>
1592
1593         * valops.c (value_cast): Specialize error message for Ada.
1594
1595 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1596
1597         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1598
1599 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1600
1601         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1602         bpstat_should_step): Return bool, adjust comments.
1603         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1604         bpstat_should_step): Likewise.
1605
1606 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1607
1608         * features/Makefile: Use feature target descriptions for Arm.
1609         * features/arm/arm-core.c: Generate new file.
1610         * features/arm/arm-fpa.c: Likewise.
1611         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1612         * features/arm/arm-m-profile.c: Likewise.
1613         * features/arm/arm-vfpv2.c: Likewise.
1614         * features/arm/arm-vfpv3.c: Likewise.
1615         * features/arm/xscale-iwmmxt.c: Likewise.
1616         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1617
1618 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1619
1620         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1621         ptrace earlier.
1622
1623 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1624
1625         * features/aarch64-pauth.c: Regenerate.
1626
1627 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1628
1629         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1630         bool.
1631         (bpstat_what): Use false instead of 0.
1632
1633 2019-07-09  Pedro Alves  <palves@redhat.com>
1634
1635         * break-catch-throw.c (is_exception_catchpoint): New.
1636         * breakpoint.c (print_one_breakpoint_location): New parameter
1637         'raw_loc'.  Handle it.  Use
1638         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1639         looking at the breakpoint's type.
1640         (print_one_breakpoint): If handling "maint info breakpoints", also
1641         print locations of exception catchpoints.
1642         * breakpoint.h (is_exception_catchpoint): Declare.
1643
1644 2019-07-09  Pedro Alves  <palves@redhat.com>
1645
1646         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1647         "addr" field.
1648         (allocate_location_exception_catchpoint): New.
1649         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1650         (initialize_throw_catchpoint_ops): Install
1651         allocate_location_exception_catchpoint as allocate_location
1652         method.
1653         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1654         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1655         bp_loc_other.
1656         (breakpoint_address_is_meaningful): Delete.
1657         (bl_address_is_meaningful): New.
1658         (breakpoint_locations_match): Adjust comment.
1659         (bp_location_from_bp_type): New, factored out of...
1660         (bp_location::bp_location(breakpoint *)): ... this.
1661         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1662         factored out of...
1663         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1664         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1665         breakpoint_address_is_meaningful.
1666         (bp_locations_compare): Adjust comment.
1667         (update_global_location_list): Use bl_address_is_meaningful
1668         instead of breakpoint_address_is_meaningful.
1669         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1670         explicit.
1671         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1672         * python/py-breakpoint.c (bppy_get_location): No longer check
1673         whether location is null.
1674
1675 2019-07-09  Pedro Alves  <palves@redhat.com>
1676
1677         PR c++/15468
1678         * breakpoint.c (print_one_breakpoint_location): Remove
1679         single-location assert.
1680
1681 2019-07-09  Tom Tromey  <tom@tromey.com>
1682
1683         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1684         * configure: Rebuild.
1685         * configure.ac: Change common to gdbsupport.
1686         * gdbsupport: Rename from common.
1687         * acinclude.m4: Change common to gdbsupport.
1688         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1689         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1690         gdbsupport.
1691         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1692         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1693         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1694         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1695         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1696         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1697         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1698         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1699         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1700         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1701         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1702         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1703         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1704         coff-pe-read.c, command.h, compile/compile-c-support.c,
1705         compile/compile-c.h, compile/compile-cplus-symbols.c,
1706         compile/compile-cplus-types.c, compile/compile-cplus.h,
1707         compile/compile-loc2c.c, compile/compile.c, completer.c,
1708         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1709         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1710         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1711         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1712         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1713         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1714         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1715         features/aarch64-core.c, features/aarch64-fpu.c,
1716         features/aarch64-pauth.c, features/aarch64-sve.c,
1717         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1718         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1719         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1720         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1721         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1722         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1723         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1724         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1725         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1726         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1727         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1728         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1729         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1730         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1731         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1732         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1733         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1734         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1735         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1736         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1737         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1738         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1739         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1740         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1741         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1742         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1743         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1744         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1745         minsyms.c, mips-linux-tdep.c, namespace.h,
1746         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1747         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1748         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1749         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1750         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1751         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1752         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1753         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1754         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1755         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1756         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1757         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1758         procfs.c, producer.c, progspace.h, psymtab.h,
1759         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1760         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1761         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1762         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1763         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1764         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1765         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1766         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1767         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1768         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1769         target-memory.c, target.c, target.h, target/waitstatus.c,
1770         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1771         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1772         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1773         unittests/array-view-selftests.c,
1774         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1775         unittests/common-utils-selftests.c,
1776         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1777         unittests/format_pieces-selftests.c,
1778         unittests/function-view-selftests.c,
1779         unittests/lookup_name_info-selftests.c,
1780         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1781         unittests/mkdir-recursive-selftests.c,
1782         unittests/observable-selftests.c,
1783         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1784         unittests/parse-connection-spec-selftests.c,
1785         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1786         unittests/scoped_fd-selftests.c,
1787         unittests/scoped_mmap-selftests.c,
1788         unittests/scoped_restore-selftests.c,
1789         unittests/string_view-selftests.c, unittests/style-selftests.c,
1790         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1791         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1792         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1793         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1794         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1795         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1796
1797 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1798
1799         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1800         bool value.
1801         (decode_digits_ordinary): Set explicit_line field in sal.
1802         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1803         symtab_and_line that was set on an explicit line number in
1804         assembler code.  Do always update the recorded symtab and line if
1805         we do skip the prologue.
1806
1807 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * breakpoint.c (set_breakpoint_location_function): Remove
1810         explicit_loc parameter.
1811         (momentary_breakpoint_from_master): Update call to
1812         set_breakpoint_location_function.
1813         (add_location_to_breakpoint): Likewise.
1814
1815 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1816
1817         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1818         required features based on default bfd type when no specific bfd
1819         is present.
1820
1821 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1822
1823         * NEWS: Mention that GDB printf and eval commands can now print
1824         C-style and Ada-style convenience var strings without
1825         calling the inferior.
1826         * printcmd.c (printf_c_string): Locally print GDB internal var
1827         instead of transiting via the inferior.
1828         (printf_wide_c_string): Likewise.
1829
1830 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1831
1832         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1833
1834 2019-07-04  Tom Tromey  <tom@tromey.com>
1835
1836         PR tui/24724:
1837         * tui/tui-winsource.c (tui_clear_source_content): Update.
1838         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1839         (tui_update_breakpoint_info): Update.
1840         (tui_set_exec_info_content): Update.
1841         * tui/tui-source.c (tui_set_source_content_nil): Update.
1842         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1843         has_break.
1844         * tui/tui-data.h (enum tui_bp_flag): New.
1845         (tui_bp_flags): New enum flags type.
1846         (struct tui_source_element) <break_mode>: Change type.  Rename
1847         from has_break.
1848         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1849         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1850         constants.
1851         * tui/tui-winsource.h: Fix comment.
1852
1853 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1854
1855         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1856         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1857         (store_fpregs_to_thread)
1858         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1859         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1860         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1861         (IWMMXT_REGS_SIZE): Add define.
1862         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1863         (fetch_vfp_regs, store_vfp_regs)
1864         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1865         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1866
1867 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1868
1869         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1870         defines.
1871         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1872         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1873         (ARM_INT_REGISTER_SIZE): ...to this.
1874         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1875         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1876         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1877         (arm_linux_collect_gregset, supply_nwfpe_register)
1878         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1879         defines.
1880         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1881         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1882         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1883         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1884         (arm_return_in_memory, arm_store_return_value)
1885         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1886         (arm_record_ld_st_multiple): Likewise.
1887         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1888         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1889
1890 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1891
1892         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1893         AARCH64_DISPLACED_MODIFIED_INSNS.
1894         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1895         (aarch64_displaced_step_copy_insn): Likewise.
1896         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1897         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1898         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1899         ARM_DISPLACED_MODIFIED_INSNS.
1900         * arm-tdep.c (arm_gdbarch_init): Likewise.
1901         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1902         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1903         (struct arm_displaced_step_closure): Use
1904         ARM_DISPLACED_MODIFIED_INSNS.
1905
1906 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1907
1908         * features/Makefile: Remove unused xml files.
1909         * features/aarch64.xml: Remove.
1910         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1911         * features/i386/amd64-avx-avx512.xml: Remove.
1912         * features/i386/amd64-avx-linux.xml: Remove.
1913         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1914         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1915         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1916         * features/i386/amd64-avx-mpx.xml: Remove.
1917         * features/i386/amd64-avx.xml: Remove.
1918         * features/i386/amd64-linux.xml: Remove.
1919         * features/i386/amd64-mpx-linux.xml: Remove.
1920         * features/i386/amd64-mpx.xml: Remove.
1921         * features/i386/amd64.xml: Remove.
1922         * features/i386/i386-avx-avx512-linux.xml: Remove.
1923         * features/i386/i386-avx-avx512.xml: Remove.
1924         * features/i386/i386-avx-linux.xml: Remove.
1925         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1926         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1927         * features/i386/i386-avx-mpx-linux.xml: Remove.
1928         * features/i386/i386-avx-mpx.xml: Remove.
1929         * features/i386/i386-avx.xml: Remove.
1930         * features/i386/i386-linux.xml: Remove.
1931         * features/i386/i386-mmx-linux.xml: Remove.
1932         * features/i386/i386-mmx.xml: Remove.
1933         * features/i386/i386-mpx-linux.xml: Remove.
1934         * features/i386/i386-mpx.xml: Remove.
1935         * features/i386/i386.xml: Remove.
1936         * features/i386/x32-avx-avx512-linux.xml: Remove.
1937         * features/i386/x32-avx-linux.xml: Remove.
1938         * features/i386/x32-linux.xml: Remove.
1939
1940 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1941
1942         * regformats/aarch64.dat: Remove.
1943         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1944         * regformats/i386/amd64-avx-linux.dat: Remove.
1945         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1946         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1947         * regformats/i386/amd64-linux.dat: Remove.
1948         * regformats/i386/amd64-mpx-linux.dat: Remove.
1949         * regformats/i386/amd64.dat: Remove.
1950         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1951         * regformats/i386/i386-avx-linux.dat: Remove.
1952         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1953         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1954         * regformats/i386/i386-linux.dat: Remove.
1955         * regformats/i386/i386-mmx-linux.dat: Remove.
1956         * regformats/i386/i386-mpx-linux.dat: Remove.
1957         * regformats/i386/i386.dat: Remove.
1958         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1959         * regformats/i386/x32-avx-linux.dat: Remove.
1960         * regformats/i386/x32-linux.dat: Remove.
1961
1962 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1963
1964         * aarch64-tdep.c: Remove xml self tests.
1965         * amd64-linux-tdep.c: Likewise.
1966         * amd64-tdep.c: Likewise.
1967         * i386-linux-tdep.c: Likewise.
1968         * i386-tdep.c: Likewise.
1969
1970 2019-07-03  Pedro Alves  <palves@redhat.com>
1971
1972         PR cli/24732
1973         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1974         (pipe_cmd_option_defs): New.
1975         (make_pipe_cmd_options_def_group): New.
1976         (pipe_command): Use gdb::option::process_options.
1977         (pipe_command_completer): New function.
1978         (_initialize_cli_cmds): Install completer for "pipe" command.
1979
1980 2019-07-03  Pedro Alves  <palves@redhat.com>
1981
1982         * cli/cli-option.c (union option_value) <string>: New field.
1983         (struct option_def_and_value): Add ctor, move ctor, dtor and
1984         use DISABLE_COPY_AND_ASSIGN.
1985         (option_def_and_value::clear_value): New.
1986         (parse_option, save_option_value_in_ctx, get_val_type_str)
1987         (add_setshow_cmds_for_options): Handle var_string.
1988         * cli-option.h (union option_def::var_address) <string>: New
1989         field.
1990         (struct string_option_def): New.
1991         * maint-test-options.c (struct test_options_opts): Add default
1992         ctor and use DISABLE_COPY_AND_ASSIGN.
1993         <string_opt>: New field.
1994         (test_options_opts::~test_options_opts): New.
1995         (test_options_opts::dump): Also dump "-string".
1996         (test_options_option_defs): Install "string.
1997
1998 2019-07-03  Pedro Alves  <palves@redhat.com>
1999
2000         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2001         option_value with a null enumeration.
2002         (complete_options): Save the option values in the context.
2003         (save_option_value_in_ctx): New, factored out from ...
2004         (process_options): ... here.
2005         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2006         of the function.
2007         * maint-test-options.c (test_options_opts::dump): New, factored
2008         out from ...
2009         (maintenance_test_options_command_mode): ... here.
2010         (maintenance_test_options_command_completion_result): Delete.
2011         (maintenance_test_options_command_completion_text): Update
2012         comment.
2013         (maintenance_show_test_options_completion_result): Change
2014         prototype.  Just print
2015         maintenance_test_options_command_completion_text.
2016         (save_completion_result): New.
2017         (maintenance_test_options_completer_mode): Pass options context to
2018         complete_options, and then save a dump.
2019         (_initialize_maint_test_options): Use add_cmd to install "maint
2020         show test-options-completion-result".
2021
2022 2019-07-03  Pedro Alves  <palves@redhat.com>
2023
2024         * NEWS (New commands): Mention "with" and "maint with".
2025         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2026         (with_command, with_command_completer): New.
2027         (pipe_command): Adjust to new repeat_previous
2028         interface.
2029         (_initialize_cli_cmds): Install the "with" command and its "w"
2030         alias.
2031         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2032         declarations.
2033         * cli/cli-setshow.c (parse_cli_var_uinteger)
2034         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2035         argument strings for all var_types.
2036         (get_setshow_command_value_string): New, factored out from ...
2037         (do_show_command): ... this.
2038         * cli/cli-setshow.h: Include <string>.
2039         (get_setshow_command_value_string): Declare.
2040         * command.h (repeat_previous): Now returns const char *.  Adjust
2041         comment.
2042         * maint.c: Include "cli/cli-cmds.h".
2043         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2044         (_initialize_maint_cmds): Register the "maintenance with" command.
2045         * top.c (repeat_previous): Move bits from pipe_command here:
2046         Return the saved command line, if any; error out if there's no
2047         command to relaunch.
2048
2049 2019-07-03  Pedro Alves  <palves@redhat.com>
2050
2051         * NEWS (New commands): Mention "maint set/show test-settings"
2052         instead of "maint test-settings".
2053         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2054         (maintenance_test_settings_set_list): Rename to ...
2055         (maintenance_set_test_settings_list): ... this.
2056         (maintenance_test_settings_show_list): Rename to  ...
2057         (maintenance_show_test_settings_list): ... this.
2058         (maintenance_test_settings_cmd): Delete.
2059         (maintenance_test_settings_set_cmd): ...
2060         (maintenance_set_test_settings_cmd): ... this.
2061         (maintenance_test_settings_show_cmd): ...
2062         (maintenance_show_test_settings_cmd): ... this.
2063         (maintenance_test_settings_show_value_cmd):
2064         (maintenance_show_test_settings_value_cmd): ... this.
2065         (_initialize_maint_test_settings): No longer install the "maint
2066         test-settings" prefix command.  Rename "maint test-settings set"
2067         to "maint set test-settings", and "maint test-settings show" to
2068         "maint show test-settings".  Adjust all subcommands.
2069
2070 2019-07-03  Pedro Alves  <palves@redhat.com>
2071
2072         * maint-test-settings.c: Fix file's intro comment.  Replace all
2073         references to "test-options" with references to "test-settings",
2074         in comments.
2075
2076 2019-07-03  Pedro Alves  <palves@redhat.com>
2077
2078         * maint-test-settings.c (maintenance_test_settings_xxx)
2079         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2080         New.
2081         (maintenance_test_settings_enums): Use them.
2082         (maintenance_test_settings_enum): Default to
2083         maintenance_test_settings_xxx.
2084         (_initialize_maint_test_settings): Initialize
2085         MAINTENANCE_TEST_SETTINGS_FILENAME.
2086
2087 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2088
2089         * breakpoint.h (remove_breakpoints_inf): Change return type to
2090         void, move function documentation here.
2091         * breakpoint.c (remove_breakpoints_inf): Change return type to
2092         void, move function documentation to header.
2093
2094 2019-07-02  Pedro Alves  <palves@redhat.com>
2095
2096         * NEWS (Completion improvements): Mention "info threads".
2097         * thread.c (struct info_threads_opts, info_threads_option_defs)
2098         (make_info_threads_options_def_group): New.
2099         (info_threads_command): Use gdb::option::process_options.
2100         (info_threads_command_completer): New.
2101         (_initialize_thread): Use gdb::option::build_help to build the
2102         help text for "info threads".
2103
2104 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2105
2106         * defs.h (generic_load): Move from here...
2107         * symfile.h (generic_load): ... to here.  Rename name parameter
2108         to args.
2109         * symfile.c (generic_load): Add comment.
2110
2111 2019-07-01  Tom Tromey  <tromey@adacore.com>
2112
2113         * dwarf2read.c
2114         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2115         declaration of without_params.  Fix formatting.
2116
2117 2019-07-01  Tom Tromey  <tromey@adacore.com>
2118
2119         * ada-exp.y (find_primitive_type): Update.
2120         * ada-lang.h (ada_lookup_symbol): Update.
2121         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2122         parameter.
2123         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2124
2125 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2126
2127         PR breakpoints/24541
2128         * gdbarch.c: Regenerate.
2129         * gdbarch.h: Regenerate.
2130         * gdbarch.sh: Add 'stap_adjust_register'.
2131         * i386-tdep.c: Include '<unordered_set>'.
2132         (i386_stap_adjust_register): New function.
2133         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2134         * stap-probe.c (stap_parse_register_operand): Call
2135         'gdbarch_stap_adjust_register'.
2136
2137 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2138
2139         PR python/24742
2140         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2141         * python/python.c (do_start_initialization): Use 'xmalloc'
2142         instead of 'PyMem_Malloc'.
2143
2144 2019-06-28  Tom Tromey  <tromey@adacore.com>
2145
2146         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2147         for Ada.
2148
2149 2019-06-27  Tom Tromey  <tromey@adacore.com>
2150
2151         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2152         objfile_key.
2153         (arm_find_mapping_symbol, arm_record_special_symbol)
2154         (_initialize_arm_tdep): Update.
2155         (arm_objfile_data_free): Remove.
2156
2157 2019-06-27  Tom Tromey  <tromey@adacore.com>
2158
2159         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2160         to cp_print_static_field.
2161
2162 2019-06-26  Tom Tromey  <tromey@adacore.com>
2163
2164         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2165         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2166         declare.
2167
2168 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2169
2170         * features/aarch64-core.c (create_feature_aarch64_core):
2171         Regenerate.
2172         * features/aarch64-core.xml: Add cpsr flags.
2173
2174 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2175
2176         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2177         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2178
2179 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2180
2181         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2182         field.
2183         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2184         use.
2185         (arm_record_special_symbol): Don't insert new symbol in sorted
2186         position, push it at the end.
2187
2188 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2189
2190         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2191         (arm_mapping_symbol_s): Remove.
2192         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2193         (arm_mapping_symbol_vec): New typedef.
2194         (struct arm_per_objfile): Add constructor.
2195         <section_maps>: Change type to
2196         std::unique_ptr<arm_mapping_symbol_vec[]>.
2197         (arm_compare_mapping_symbols): Remove.
2198         (arm_find_mapping_symbol): Adjust to section_maps type change.
2199         (arm_objfile_data_free): Call delete on arm_per_objfile.
2200         (arm_record_special_symbol): Adjust to section_maps type change.
2201         Allocate arm_per_objfile with new.
2202
2203 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2204
2205         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2206         with the command prefix.
2207
2208 2019-06-25  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2211         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2216         type.
2217         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2218         protected.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-winsource.c
2223         (tui_source_window_base::set_is_exec_point_at): Add check against
2224         LOA_ADDRESS.
2225
2226 2019-06-25  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-source.c (tui_set_source_content): Don't check before
2229         xfree.
2230         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-winsource.h (tui_update_source_window_as_is)
2235         (tui_alloc_source_buffer, tui_line_is_displayed)
2236         (tui_addr_is_displayed): Change type of win_info.
2237         * tui/tui-winsource.c (tui_update_source_window_as_is)
2238         (tui_clear_source_content, tui_show_source_line)
2239         (tui_show_source_content, tui_source_window_base::refill)
2240         (tui_source_window_base::set_is_exec_point_at)
2241         (tui_source_window_base::set_is_exec_point_at)
2242         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2243         (tui_alloc_source_buffer, tui_line_is_displayed)
2244         (tui_addr_is_displayed): Change type of win_info.  Update.
2245         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2246         (tui_source_window_base::do_make_visible_with_new_height):
2247         Update.
2248         * tui/tui-source.c (tui_set_source_content)
2249         (tui_set_source_content_nil)
2250         (tui_source_window::do_scroll_vertical): Update.
2251         * tui/tui-layout.c (show_layout): Update.
2252         * tui/tui-disasm.c (tui_set_disassem_content)
2253         (tui_disasm_window::do_scroll_vertical): Update.
2254         * tui/tui-data.h (tui_win_content): Remove.
2255         (struct tui_gen_win_info) <content, content_size>: Remove.
2256         (struct tui_source_element): Add initializers and destructor.
2257         (union tui_which_element, struct tui_win_element): Remove.
2258         (struct tui_source_window_base) <content>: New field.
2259         (struct tui_data_window): Remove destructor.
2260         (tui_alloc_content, tui_free_win_content)
2261         (tui_free_all_source_wins_content): Don't declare.
2262         * tui/tui-data.c (tui_initialize_static_data): Update.
2263         (init_content_element, tui_alloc_content): Remove.
2264         (~tui_gen_win_info): Update.
2265         (~tui_data_window, tui_free_all_source_wins_content)
2266         (tui_free_win_content, free_content, free_content_elements):
2267         Remove.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-winsource.h (tui_clear_source_content)
2272         (tui_erase_source_content, tui_show_source_content): Change type
2273         of win_info.
2274         * tui/tui-winsource.c (tui_clear_source_content)
2275         (tui_erase_source_content, tui_show_source_content): Change type
2276         of win_info.
2277         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2278         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2279         win_info.
2280         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2281         win_info.
2282         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-winsource.c (tui_clear_source_content)
2287         (tui_source_window_base::set_is_exec_point_at): Update.
2288         * tui/tui-source.c (tui_set_source_content_nil): Update.
2289         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2290         a bool.
2291         * tui/tui-data.c (init_content_element): Update.
2292
2293 2019-06-25  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2296         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2297         * tui/tui-layout.c (init_and_make_win): Update.
2298         * tui/tui.h (enum tui_win_type): Update.
2299         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2300         tui_win_is_auxillary.
2301         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2302         tui_win_is_auxillary.
2303
2304 2019-06-25  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2307         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2308         (tui_delete_data_content_windows, tui_display_all_data)
2309         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2310         Update.
2311         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2312         * tui/tui-regs.c (tui_last_regs_line_no)
2313         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2314         (tui_show_registers): Update.
2315         (tui_show_register_group): Return void.  Update.
2316         (tui_display_registers_from, tui_display_reg_element_at_line)
2317         (tui_display_registers_from_line, tui_check_register_values):
2318         Update.
2319         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2320         member.
2321         (struct tui_data_window) <regs_content>: Now a std::vector.
2322         <regs_content_count>: Remove.
2323         (tui_add_content_elements, tui_free_data_content): Don't declare.
2324         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2325         (init_content_element): Remove DATA_WIN case.  Add assert.
2326         (tui_add_content_elements): Remove.
2327         (tui_data_window): Update.
2328         (tui_free_data_content): Remove.
2329         (free_content_elements): Remove DATA_WIN case.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-data.c (tui_data_item_window): Update.
2334         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2335         * tui/tui-windata.c (tui_display_all_data)
2336         (tui_display_data_from_line): Update.
2337         (tui_check_data_values): Remove.
2338         * tui/tui-regs.c (tui_show_register_group)
2339         (tui_display_reg_element_at_line): Update.
2340         * tui/tui-hooks.c (tui_register_changed)
2341         (tui_refresh_frame_and_register_information): Call
2342         tui_check_register_values.
2343         * tui/tui-data.h (struct tui_data_window) <data_content,
2344         data_content_count, data_type>: Remove.
2345         (enum tui_data_type): Remove.
2346
2347         * tui/tui-data.c (tui_data_window::clear_detail)
2348         (~tui_data_window): Update.
2349
2350 2019-06-25  Tom Tromey  <tom@tromey.com>
2351
2352         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2353         declare.
2354         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2355         Rename from tui_first_data_item_displayed.  Update.
2356         (tui_data_window::refresh_all)
2357         (tui_data_window::do_scroll_vertical): Update.
2358         * tui/tui-data.h (struct tui_data_window)
2359         <first_data_item_displayed>: Declare new method.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2364         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2365         contents...
2366         (tui_initialize_static_data): ...here.
2367
2368 2019-06-25  Tom Tromey  <tom@tromey.com>
2369
2370         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2371         (tui_display_registers_from, tui_check_register_values): Update.
2372         (tui_display_register): Remove win_info parameter; update.
2373         (tui_get_register): Change type of parameters.
2374         * tui/tui-data.h (struct tui_data_element): Remove.
2375         (union tui_which_element) <data>: Remove.
2376         <data_window>: Change type.
2377         (struct tui_data_item_window): New.
2378         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2379         case.  Add assert.
2380         (~tui_data_item_window): New destructor.
2381         (free_content_elements): Remove DATA_ITEM_WIN case.
2382
2383 2019-06-25  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2386         Remove.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-data.h (struct tui_command_element): Remove.
2391         (union tui_which_element) <command>: Remove.
2392         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2393         assert.
2394         (free_content_elements): Remove CMD_WIN case.
2395
2396 2019-06-25  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-layout.c (tui_set_layout): Update.
2399         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2400         * tui/tui-data.c (layout_def): Update.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2405         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2406         (tui_source_window_base::set_new_height): Update.
2407         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2408         Update.
2409         (tui_set_locator_fullname, tui_set_locator_info)
2410         (tui_show_frame_info): Update.
2411         * tui/tui-source.c (tui_set_source_content)
2412         (tui_source_is_displayed): Update.
2413         * tui/tui-layout.c (show_source_disasm_command, show_data)
2414         (show_source_or_disasm_and_command): Update.
2415         * tui/tui-disasm.c (tui_set_disassem_content)
2416         (tui_get_begin_asm_address): Update.
2417         * tui/tui-data.h (struct tui_locator_element): Remove.
2418         (union tui_which_element) <locator>: Remove.
2419         (struct tui_locator_window): New.
2420         (tui_locator_win_info_ptr): Change return type.
2421         * tui/tui-data.c (_locator): Change type.
2422         (tui_locator_win_info_ptr): Change return type.
2423         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2424         (tui_alloc_content): Add assert.
2425
2426 2019-06-25  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-winsource.c
2429         (tui_exec_info_window::maybe_allocate_content): New method.
2430         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2431         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2432         (make_source_or_disasm_window): Add cast.
2433         * tui/tui-data.h (union tui_which_element) <simple_string>:
2434         Remove.
2435         (struct tui_source_info): New.
2436         (struct tui_source_window_base) <execution_info>: Change type.
2437         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2438         case, and add assert.
2439         (tui_alloc_content): Add assert.
2440
2441 2019-06-25  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2444         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2445         * tui/tui-data.c (tui_alloc_win_info): Remove.
2446
2447 2019-06-25  Tom Tromey  <tom@tromey.com>
2448
2449         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2450         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2451         can_highlight.
2452
2453 2019-06-25  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2456         make_visible_with_new_height method.
2457         (tui_win_info::make_visible_with_new_height): New method.
2458         (tui_source_window_base::do_make_visible_with_new_height)
2459         (tui_data_window::do_make_visible_with_new_height)
2460         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2461         (make_visible_with_new_height): Remove.
2462         (tui_resize_all, tui_adjust_win_heights): Use
2463         make_visible_with_new_height method.
2464         * tui/tui-data.h (struct tui_win_info)
2465         <do_make_visible_with_new_height, make_visible_with_new_height>:
2466         New methods.
2467         (struct tui_source_window_base, struct tui_data_window)
2468         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2469         methods.
2470
2471 2019-06-25  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2474         method.
2475         (update_tab_width): Call update_tab_width method.
2476         * tui/tui-data.h (struct tui_win_info)
2477         (struct tui_source_window_base) <update_tab_width>: New methods.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2482         parameter.
2483         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2484         parameter.
2485         (tui_gen_win_info::make_visible): Update.
2486         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2487         parameter.
2488         * tui/tui-data.h (enum tui_box): New enum.
2489         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2490
2491 2019-06-25  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2494         init_and_make_win for EXEC_INFO_WIN.
2495         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2496         longer inline.
2497         (struct tui_win_info) <~tui_win_info>: Inline.
2498         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2499         Don't declare.
2500         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2501         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2502         Remove.
2503         (tui_initialize_static_data): Update.
2504         (~tui_gen_win_info): Handle more cleanup here.
2505         (~tui_source_window_base): Delete "execution_info".
2506         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2507
2508 2019-06-25  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-layout.c (make_command_window): Don't set
2511         can_highlight.
2512         (show_source_disasm_command): Call the reset method.
2513         (show_data): Don't set can_highlight.  Call the reset method.
2514         (tui_gen_win_info::reset): Rename from init_gen_win_info
2515         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2516         (show_source_or_disasm_and_command): Call the reset method.
2517         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2518         (struct tui_cmd_window): Set can_highlight.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2523         from make_visible.
2524         (tui_make_visible, tui_make_invisible): Rewrite.
2525         (tui_win_info::make_visible): Remove.
2526         (tui_source_window_base::make_visible): Update.
2527         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2528         method.  Moved from...
2529         (struct tui_win_info) <make_visible>: ...here.
2530
2531 2019-06-25  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-winsource.c
2534         (tui_source_window_base::do_scroll_horizontal): Remove direction
2535         parameter.
2536         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2537         direction parameter.
2538         * tui/tui-win.c (tui_win_info::forward_scroll)
2539         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2540         (tui_win_info::right_scroll): Update.
2541         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2542         direction parameter.
2543         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2544         direction parameter.
2545         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2546         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2547         Remove direction parameter.
2548         (struct tui_source_window_base, struct tui_source_window)
2549         (struct tui_disasm_window, struct tui_data_window)
2550         (struct tui_cmd_window): Update.
2551
2552 2019-06-25  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-winsource.h (tui_set_exec_info_content)
2555         (tui_show_exec_info_content, tui_erase_exec_info_content)
2556         (tui_clear_exec_info_content, tui_update_exec_info): Change
2557         argument to tui_source_window_base.
2558         * tui/tui-winsource.c (tui_set_exec_info_content)
2559         (tui_show_exec_info_content, tui_erase_exec_info_content)
2560         (tui_clear_exec_info_content, tui_update_exec_info): Change
2561         argument to tui_source_window_base.
2562
2563 2019-06-25  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2566         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2567
2568 2019-06-25  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2571         check.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2576         type to void.
2577         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2578         type to void.
2579         * tui/tui-source.c (tui_set_source_content): Update.
2580         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2581
2582 2019-06-25  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-win.c (window_name_completer, tui_set_focus)
2585         (tui_all_windows_info): Use name method.
2586         * tui/tui-data.h (struct tui_gen_win_info)
2587         (struct tui_source_window, struct tui_disasm_window)
2588         (struct tui_data_window, struct tui_cmd_window) <name>: New
2589         method.
2590         (tui_win_name): Don't declare.
2591         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2592         (tui_win_name): Remove.
2593
2594 2019-06-25  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-winsource.h (tui_update_source_window)
2597         (tui_update_source_window_as_is): Change parameter type.
2598         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2599         to be a tui_source_window_base.
2600         (tui_update_source_window_as_is): Likewise.
2601         * tui/tui-win.c (make_visible_with_new_height): Update.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-winsource.c (tui_erase_source_content)
2606         (tui_show_source_content, tui_show_exec_info_content)
2607         (tui_erase_exec_info_content): Use refresh_window method.
2608         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2609         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2610         from tui_refresh_win.
2611         (tui_data_window::refresh_window): New method.
2612         (tui_win_info::refresh, tui_source_window_base::refresh)
2613         (tui_refresh_all): Use refresh_window method.
2614         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2615         method.
2616         * tui/tui-regs.c (tui_display_register): Call refresh_window
2617         method.
2618         * tui/tui-layout.c (show_source_disasm_command)
2619         (show_source_or_disasm_and_command): Call refresh_window method.
2620         * tui/tui-data.h (struct tui_gen_win_info)
2621         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2622         New method.
2623
2624 2019-06-25  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui.c (tui_rl_other_window, tui_enable)
2627         (tui_is_window_visible, tui_get_command_dimension): Update.
2628         * tui/tui-winsource.c (tui_update_source_window_as_is)
2629         (tui_clear_source_content, tui_erase_source_content)
2630         (tui_show_source_line, tui_source_window_base::refill)
2631         (tui_source_window_base::do_scroll_horizontal)
2632         (tui_source_window_base::set_is_exec_point_at)
2633         (tui_update_breakpoint_info, tui_set_exec_info_content)
2634         (tui_alloc_source_buffer, tui_line_is_displayed)
2635         (tui_addr_is_displayed): Update.
2636         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2637         (tui_check_and_display_highlight_if_needed)
2638         (tui_win_info::make_visible, tui_win_info::refresh)
2639         (tui_refresh_all): Update.
2640         * tui/tui-windata.c (tui_first_data_item_displayed)
2641         (tui_delete_data_content_windows, tui_erase_data_content)
2642         (tui_display_all_data, tui_data_window::refresh_all)
2643         (tui_check_data_values): Update.
2644         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2645         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2646         (tui_win_info::backward_scroll, tui_refresh_all_win)
2647         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2648         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2649         (tui_source_window_base::set_new_height)
2650         (tui_data_window::set_new_height)
2651         (make_invisible_and_set_new_height)
2652         (make_visible_with_new_height, new_height_ok)
2653         (parse_scrolling_args): Update.
2654         * tui/tui-stack.c (tui_show_frame_info): Update.
2655         * tui/tui-source.c (tui_set_source_content)
2656         (tui_set_source_content_nil, tui_source_is_displayed)
2657         (tui_source_window::do_scroll_vertical): Update.
2658         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2659         (tui_display_registers_from, tui_display_reg_element_at_line)
2660         (tui_check_register_values, tui_reg_command): Update.
2661         * tui/tui-layout.c (tui_default_win_height)
2662         (show_source_disasm_command, show_data, init_and_make_win)
2663         (show_source_or_disasm_and_command): Update.
2664         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2665         (tui_redisplay_readline, tui_mld_flush)
2666         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2667         (tui_getc): Update.
2668         * tui/tui-disasm.c (tui_set_disassem_content)
2669         (tui_disasm_window::do_scroll_vertical): Update.
2670         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2671         Now virtual.
2672         (struct tui_win_info): Derive from tui_gen_win_info.
2673         <~tui_win_info>: Mark as override.
2674         <generic>: Remove member.
2675         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2676         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2677         (~tui_data_window, ~tui_win_info)
2678         (tui_free_all_source_wins_content): Update.
2679         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2680
2681 2019-06-25  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-layout.c (init_and_make_win): Use new.
2684         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2685         destructor, initializers.
2686         (tui_alloc_generic_win_info): Don't declare.
2687         * tui/tui-data.c (_locator): Add argument to constructor.
2688         (source_win, disasm_win): New globals.
2689         (exec_info): Remove.
2690         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2691         Update.
2692         (tui_alloc_generic_win_info): Remove.
2693         (init_content_element): Use new.
2694         (tui_win_info::tui_win_info): Update.
2695         (free_content_elements) <case DATA_WIN>: Use delete.
2696
2697 2019-06-25  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2700         * tui/tui-windata.c (tui_first_data_item_displayed)
2701         (tui_delete_data_content_windows): Update.
2702         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2703         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2704         (tui_display_registers_from, tui_check_register_values): Update.
2705         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2706         pointer.
2707         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2708         window.
2709         (tui_free_data_content): Update.
2710         (free_content_elements) <case DATA_WIN>: Free the window.
2711
2712 2019-06-25  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2715         Update.
2716         * tui/tui-layout.c (make_command_window)
2717         (show_source_disasm_command, show_data, init_and_make_win)
2718         (show_source_or_disasm_and_command): Update.
2719         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2720         method.
2721         <can_highight, is_highlighted>: Now bool.
2722         (tui_set_win_highlight): Don't declare.
2723         * tui/tui-data.c (tui_set_win_highlight): Remove.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-wingeneral.c (make_visible): Remove check of window
2728         type.
2729
2730 2019-06-25  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-win.c (tui_win_info::max_height)
2733         (tui_cmd_window::max_height): New methods.
2734         (new_height_ok): Call max_height.
2735         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2736         <max_height>: New method.
2737
2738 2019-06-25  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-win.c (tui_source_window_base::set_new_height)
2741         (tui_data_window::set_new_height): New methods.
2742         (make_invisible_and_set_new_height): Call set_new_height method.
2743         * tui/tui-data.h (struct tui_win_info)
2744         (struct tui_source_window_base, struct tui_data_window)
2745         <set_new_height>: New method.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2750         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2751         tui_refresh_data_win.
2752         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2753         method.
2754         (tui_refresh_all_win): Call the refresh_all method.
2755         (tui_set_focus): Likewise.
2756         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2757         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2758         Likewise.
2759
2760 2019-06-25  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-winsource.h (tui_refill_source_window)
2763         (tui_set_is_exec_point_at): Don't declare.
2764         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2765         (tui_source_window_base::refill): Rename from
2766         tui_refill_source_window.
2767         (tui_source_window_base::do_scroll_horizontal): Update.
2768         (tui_source_window_base::set_is_exec_point_at): Rename from
2769         tui_set_is_exec_point_at.
2770         (tui_update_all_breakpoint_info): Update.
2771         * tui/tui-stack.c (tui_show_frame_info): Update.
2772         * tui/tui-layout.c (show_data): Add cast.
2773         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2774         * tui/tui-data.h (struct tui_source_window_base) <refill,
2775         set_is_exec_point_at>: New methods.
2776         (tui_source_windows, tui_add_to_source_windows): Update types.
2777         (tui_add_to_source_windows): Remove redundant declaration.
2778         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2779         (tui_source_windows): Change return type.
2780         (tui_clear_source_windows_detail): Update.
2781         (tui_add_to_source_windows): Change type of parameter.
2782         (tui_free_all_source_wins_content): Update.
2783
2784 2019-06-25  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-wingeneral.c (tui_win_info::refresh)
2787         (tui_source_window_base::refresh): New methods.
2788         (tui_refresh_all): Call the refresh method.
2789         * tui/tui-data.h (struct tui_win_info)
2790         (struct tui_source_window_base) <refresh>: New method.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui.h (tui_is_window_visible): Return bool.
2795         * tui/tui.c (tui_is_window_visible): Return bool.
2796         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2797         (tui_make_visible, tui_make_invisible)
2798         (tui_win_info::make_visible)
2799         (tui_source_window_base::make_visible, make_all_visible)
2800         (tui_make_all_visible, tui_make_all_invisible): Update.
2801         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2802         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2803         bool.
2804         (struct tui_win_info, struct tui_source_window_base)
2805         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2806         * tui/tui-data.c (tui_init_generic_part): Update.
2807
2808 2019-06-25  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2811         (tui_source_window_base::make_visible): New methods.
2812         (make_all_visible): Make method call.
2813         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2814         (struct tui_source_window_base, struct tui_cmd_window): Override
2815         make_visible.
2816         (tui_win_is_source_type): Don't declare.
2817         * tui/tui-data.c (tui_win_is_source_type): Remove.
2818
2819 2019-06-25  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2822         NULL check.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2827         Inline constructor.  Add initializers for members.
2828         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2829         constructors; now inline in class.
2830
2831 2019-06-25  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-regs.c (tui_show_registers): Update.
2834         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2835         bool.
2836         * tui/tui-data.c (tui_data_window::clear_detail)
2837         (tui_data_window): Update.
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-windata.c (tui_display_all_data)
2842         (tui_display_data_from_line, tui_display_data_from)
2843         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2844         Update.
2845         * tui/tui-regs.c (tui_last_regs_line_no)
2846         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2847         (tui_show_registers, tui_show_register_group)
2848         (tui_display_registers_from, tui_display_reg_element_at_line)
2849         (tui_display_registers_from_line, tui_check_register_values)
2850         (tui_reg_next, tui_reg_prev): Update.
2851         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2852         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2853         tui_data_window.
2854         (struct tui_win_info) <detail>: Remove.  Add new fields from
2855         tui_data_info.
2856         (TUI_DATA_WIN): Add cast.
2857         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2858         (~tui_data_window): Simplify.
2859
2860 2019-06-25  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-layout.c (show_source_disasm_command)
2863         (show_source_or_disasm_and_command): Update.
2864         * tui/tui-io.c (update_cmdwin_start_line)
2865         (tui_redisplay_readline): Update.
2866         * tui/tui-data.h (struct tui_command_info): Remove.
2867         (struct tui_win_info) <detail>: Remove command_info member.
2868         (struct tui_data_window) <start_line>: New member, from
2869         tui_command_info.
2870         (TUI_CMD_WIN): Add casts.
2871
2872 2019-06-25  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-winsource.c (tui_update_source_window)
2875         (tui_refill_source_window)
2876         (tui_source_window_base::do_scroll_horizontal)
2877         (tui_update_breakpoint_info, tui_set_exec_info_content)
2878         (tui_show_exec_info_content, tui_erase_exec_info_content)
2879         (tui_clear_exec_info_content): Update.
2880         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2881         Update.
2882         * tui/tui-win.c (make_invisible_and_set_new_height)
2883         (make_visible_with_new_height): Update.
2884         * tui/tui-source.c (tui_set_source_content)
2885         (tui_show_symtab_source): Update.
2886         * tui/tui-layout.c (extract_display_start_addr)
2887         (show_source_disasm_command, show_data)
2888         (make_source_or_disasm_window)
2889         (show_source_or_disasm_and_command): Update.
2890         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2891         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2892         "gdbarch".
2893         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2894         to tui_source_window_base.
2895         (struct tui_win_info) <detail>: Remove source_info member.
2896         (struct tui_source_window_base) <has_locator>: Inline.
2897         Move contents from tui_source_info; rename has_locator member to
2898         m_has_locator.
2899         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2900         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2901         header file.
2902         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2903         Simplify.
2904         (tui_free_all_source_wins_content): Cast to
2905         tui_source_window_base.
2906
2907 2019-06-25  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-win.c (make_invisible_and_set_new_height)
2910         (make_visible_with_new_height): Call has_locator method.
2911         * tui/tui-layout.c (show_source_disasm_command, show_data)
2912         (show_source_or_disasm_and_command): Update for bool change.
2913         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2914         (tui_win_info) <has_locator>: New method.
2915         (struct tui_source_window_base) <has_locator>: New method.
2916         (tui_win_has_locator): Don't declare.
2917         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2918         from tui_win_has_locator.
2919         (tui_source_window_base): Use false, not FALSE.
2920
2921 2019-06-25  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2924         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2925         clear_detail method directly.
2926         (tui_clear_win_detail): Remove.
2927
2928 2019-06-25  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2931         "this", not TUI_DISASM_WIN.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2936         declare.
2937         * tui/tui-winsource.c
2938         (tui_source_window_base::do_scroll_horizontal): Rename from
2939         tui_horizontal_source_scroll.
2940         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2941         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2942         from tui_vertical_data_scroll.
2943         * tui/tui-win.h (tui_scroll): Don't declare.
2944         * tui/tui-win.c (tui_win_info::forward_scroll)
2945         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2946         (tui_win_info::right_scroll): Rename and update.
2947         (tui_scroll_forward_command, tui_scroll_backward_command)
2948         (tui_scroll_left_command, tui_scroll_right_command): Update.
2949         (tui_scroll): Remove.
2950         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2951         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2952         from tui_vertical_source_scroll.
2953         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2954         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2955         from tui_vertical_disassem_scroll.
2956         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2957         do_scroll_horizontal>: New methods.
2958         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2959         Likewise.
2960         (struct tui_source_window_base): Add do_scroll_horizontal.
2961         (struct tui_source_window, struct tui_disasm_window): Add
2962         do_scroll_vertical.
2963         (struct tui_data_window, struct tui_cmd_window): Add
2964         do_scroll_horizontal and do_scroll_vertical.
2965         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2966
2967 2019-06-25  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-data.h (struct tui_source_window_base): New struct.
2970         (struct tui_source_window): Derive from tui_source_window_base.
2971         (struct tui_disasm_window): New struct.
2972         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2973         from tui_source_window::clear_detail.
2974         (tui_source_window_base): Rename from tui_source_window.
2975         (~tui_source_window_base): Rename from ~tui_source_window.
2976         (tui_alloc_win_info): Create a tui_disasm_window.
2977
2978 2019-06-25  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-data.h (struct tui_source_window)
2981         (struct tui_data_window): Declare destructors.
2982         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2983         destructors.
2984         (tui_win_info): Simplify.
2985
2986 2019-06-25  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-winsource.c (tui_display_main)
2989         (tui_update_source_windows_with_addr)
2990         (tui_update_all_breakpoint_info): Update.
2991         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2992         (new_height_ok, parse_scrolling_args): Update.
2993         * tui/tui-stack.c (tui_show_frame_info): Update.
2994         * tui/tui-data.h (struct tui_list): Remove.
2995         (tui_source_windows): Return a reference to a std::vector.
2996         * tui/tui-data.c (source_windows): Now a std::vector.
2997         (tui_source_windows): Change return type.
2998         (tui_clear_source_windows): Rewrite.
2999         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3000         (tui_free_all_source_wins_content): Rewrite.
3001
3002 2019-06-25  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3005         (struct tui_data_window, struct tui_cmd_window): Declare
3006         clear_detail method.
3007         * tui/tui-data.c (tui_source_window::clear_detail)
3008         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3009         methods.
3010         (tui_clear_win_detail): Simplify.
3011
3012 2019-06-25  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-layout.c (make_source_window, make_disasm_window)
3015         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3016         Return the new window.
3017         (show_source_disasm_command, show_data)
3018         (show_source_or_disasm_and_command): Update.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3023         parameter.  Return the new window.
3024         (show_source_disasm_command): Update and remove NULL check.
3025         (show_source_or_disasm_and_command): Update.
3026
3027 2019-06-25  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-data.h (struct tui_win_info): Make constructor
3034         protected.  Make destructor virtual.  Add initializers.
3035         (tui_source_window, tui_data_window, tui_cmd_window): New
3036         classes.
3037         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3038         constructor.  Add "type" parameter.
3039         (tui_source_window, tui_data_window, tui_cmd_window): New
3040         constructors.
3041         (tui_alloc_win_info): Instantiate the appropriate subclass.
3042
3043 2019-06-25  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-win.c (tui_resize_all): Use delete.
3046         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3047         destructor.
3048         (tui_free_window): Don't declare.
3049         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3050         Update.
3051
3052 2019-06-25  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-data.h (struct tui_win_info): Add constructor.
3055         * tui/tui-data.c (tui_alloc_win_info): Use new.
3056         (tui_free_window): Use delete.
3057
3058 2019-06-22  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3061         declare.
3062         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3063
3064 2019-06-22  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3067         declare.
3068         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3069
3070 2019-06-22  Tom de Vries  <tdevries@suse.de>
3071
3072         * dwarf2read.c (create_addrmap_from_aranges)
3073         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3074         instead of '%zu'.
3075
3076 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3077
3078         * dwarf2read.h (dwarf2_section_info_def): Remove.
3079         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3080         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3081         std::vector<dwarf2_section_info>.
3082         (struct dwo_file) <~dwo_file>: Remove.
3083         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3084         types field.
3085         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3086         (dwarf2_read_debug_names): Likewise.
3087         (create_debug_types_hash_table): Change parameter type to
3088         array_view, adjust code accordingly.
3089         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3090         (partial_die_info::fixup): Likewise.
3091         (determine_prefix): Likewise.
3092         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3093
3094 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3095
3096         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3097         gdb_bfd_ref_ptr.
3098         <~dwo_file>: Remove call to gdb_bfd_unref.
3099         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3100         gdb_bfd_ref_ptr::get.
3101
3102 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3103
3104         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3105         type to htab_up.
3106         * dwarf2read.c (struct dwo_file): Initialize fields.
3107         <~dwo_file>: New.
3108         (free_dwo_file): Remove, move content to ~dwo_file.
3109         (struct dwo_file_deleter): Remove.
3110         (dwo_file_up>: Remove custom deleter.
3111         (free_dwo_files): Remove.
3112         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3113         dwo_files.
3114         (process_skeletonless_type_units): Call unique_ptr::get.
3115         (allocate_dwo_file_hash_table): Add deleter to created hash
3116         table.  Change return type to htab_up.
3117         (lookup_dwo_file_slot): Don't memset dwo_file, call
3118         unique_ptr::get.
3119         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3120         (create_dwo_unit_in_dwp_v2): Likewise.
3121         (open_and_init_dwo_file): Likewise.
3122         (free_dwo_file_from_slot): Remove.
3123
3124 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3125
3126         * dwarf2read.h (struct dwarf2_section_info) <readin,
3127         is_virtual>: Change type to bool.
3128         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3129         true instead of 1.
3130
3131 2019-06-19  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-data.h (tui_init_content_element): Don't declare.
3134
3135 2019-06-19  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-data.h (tui_init_win_info): Don't declare.
3138
3139 2019-06-19  Tom de Vries  <tdevries@suse.de>
3140
3141         * dwarf2read.h (abstract_to_concrete): Change type to
3142         std::unordered_map<sect_offset, std::vector<sect_offset>,
3143         gdb::hash_enum<sect_offset>>.
3144
3145 2019-06-19  Tom Tromey  <tromey@adacore.com>
3146
3147         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3148         EVAL_AVOID_SIDE_EFFECTS specially.
3149
3150 2019-06-19  Tom Tromey  <tromey@adacore.com>
3151
3152         * source-cache.c (highlighter): New global.
3153         (source_cache::get_source_lines): Create a highlighter on demand.
3154
3155 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * defs.h (deprecated_interactive_hook): Delete declaration.
3158         * interps.c (clear_interpreter_hooks): Remove use of
3159         deprecated_interactive_hook.
3160         * top.c (deprecated_interactive_hook): Delete definition.
3161         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3162
3163 2019-06-18  Tom de Vries  <tdevries@suse.de>
3164
3165         PR gdb/24515
3166         * dwarf2read.h (abstract_to_concrete): Change type from
3167         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3168         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3169         * dwarf2read.c (read_variable): Update.
3170         (dwarf2_fetch_die_loc_sect_off): Update.
3171
3172 2019-06-17  Tom de Vries  <tdevries@suse.de>
3173
3174         PR gdb/24617
3175         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3176         accessing parent[parent_len - 1].
3177
3178 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3179
3180         PR gdb/24364
3181         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3182         call dtrace_process_dof with NULL dof.
3183
3184 2019-06-16  Tom de Vries  <tdevries@suse.de>
3185
3186         PR gdb/24445
3187         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3188
3189 2019-06-16  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3192         (make_all_visible): Use address of member.
3193
3194 2019-06-16  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3197         (tui_free_window, free_content, free_content_elements): Remove
3198         unnecessary cast.
3199         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3200         cast.
3201         * tui/tui-regs.c (tui_show_register_group)
3202         (tui_display_registers_from, tui_display_reg_element_at_line):
3203         Remove unnecessary cast.
3204
3205 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * linux-nat.c (normal_mask): Delete.
3208         (_initialize_linux_nat): Don't initialise normal_mask.
3209
3210 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3211
3212         PR gdb/24445
3213         * dwarf-index-write.h (write_psymtabs_to_index): Add
3214         dwz_basename parameter.
3215         * dwarf-index-write.c (write_gdbindex): Move file writing to
3216         write_gdbindex_1.  Change return type void.
3217         (assert_file_size): Move up, remove filename parameter.
3218         (write_gdbindex_1): New function.
3219         (write_debug_names): Change return type to void, call
3220         assert_file_size.
3221         (struct index_wip_file): New struct.
3222         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3223         file logic to index_wip_file.  Write index for dwz file if
3224         needed.
3225         (save_gdb_index_command): Pass basename of dwz file, if present.
3226         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3227         build-id of dwz file, if present.
3228         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3229         (dwarf2_get_dwz_file): Likewise.
3230         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3231         (dwarf2_get_dwz_file): Likewise.
3232
3233 2019-06-16  Tom Tromey  <tom@tromey.com>
3234
3235         * coffread.c (process_coff_symbol): Use xstrdup.
3236         * value.c (create_internalvar): Use xstrdup.
3237
3238 2019-06-16  Tom Tromey  <tom@tromey.com>
3239
3240         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3241         * breakpoint.c (stopin_command, stopat_command)
3242         (until_break_command, decode_location_default): Remove unnecessary
3243         cast.
3244         * utils.c (subset_compare): Remove unnecessary cast.
3245         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3246         cast.
3247         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3248         cast.
3249         * infcmd.c (path_command): Remove unnecessary cast.
3250         * coffread.c (decode_type): Remove unnecessary cast.
3251         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3252         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3253         * tui/tui-stack.c (tui_show_locator_content)
3254         (tui_show_frame_info): Remove unnecessary cast.
3255         * tui/tui-win.c (tui_scroll_forward_command)
3256         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3257         (parse_scrolling_args): Remove unnecessary cast.
3258         * tui/tui-data.c (init_win_info, tui_del_window)
3259         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3260         (free_content_elements): Remove unnecessary cast.
3261         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3262         unnecessary cast.
3263         * tui/tui-source.c (tui_set_source_content)
3264         (tui_vertical_source_scroll): Remove unnecessary cast.
3265         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3266         cast.
3267         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3268         * tui/tui-regs.c (tui_display_registers_from)
3269         (tui_display_register): Remove unnecessary cast.
3270         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3271         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3272         (make_visible): Remove unnecessary cast.
3273         * tui/tui-winsource.c (tui_erase_source_content)
3274         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3275         unnecessary cast.
3276         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3277         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3278         * stabsread.c (read_type, read_array_type, read_range_type):
3279         Remove unnecessary cast.
3280         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3281         (parse_symbol, parse_type, upgrade_type, parse_external)
3282         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3283         unnecessary cast.
3284         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3285
3286 2019-06-16  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-data.c (tui_alloc_generic_win_info)
3289         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3290         checks.
3291
3292 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3293             Andrew Burgess  <andrew.burgess@embecosm.com>
3294
3295         * f-typeprint.c (f_print_type): Don't return early for not
3296         associated or not allocated types.
3297         (f_type_print_varspec_suffix): Add print_rank parameter and print
3298         ranks of array types in case they dangling.
3299         (f_type_print_base): Add print_rank parameter.
3300
3301 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3302
3303         * NEWS: Mention new MI commands.
3304         * break-catch-throw.c (enum exception_event_kind): Move to
3305         breakpoint.h.
3306         (print_mention_exception_catchpoint): Output text as a single
3307         message.
3308         (catch_exception_command_1): Rename to...
3309         (catch_exception_event): ...this, make non-static, update header
3310         command, and change some parameter types.
3311         (catch_catch_command): Update for changes to
3312         catch_exception_command_1.
3313         (catch_throw_command): Likewise.
3314         (catch_rethrow_command): Likewise.
3315         * breakpoint.c (enum exception_event_kind): Delete.
3316         * breakpoint.h (enum exception_event_kind): Moved here from
3317         break-catch-throw.c.
3318         (catch_exception_event): Declare.
3319         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3320         (mi_cmd_catch_throw): New function.
3321         (mi_cmd_catch_rethrow): New function.
3322         (mi_cmd_catch_catch): New function.
3323         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3324         'catch-catch' entries.
3325         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3326         (mi_cmd_catch_rethrow): Declare.
3327         (mi_cmd_catch_catch): Declare.
3328
3329 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * annotate.c (annotate_source_line): Change return type to void,
3332         update implementation to match.
3333         * annotate.h (annotate_source_line): Change return type to void,
3334         update header comment.
3335         * stack.c (print_frame_info): Don't change what frame information
3336         is printed based on whether annotations are on or not.
3337
3338 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3341         (annotate_source): Make static.
3342         (annotate_source_line): Moved from source.c and renamed from
3343         identify_source_line.  Update the return type.
3344         * annotate.h (annotate_source): Delete declaration.
3345         (annotate_source_line): Declaration moved from source.h, and
3346         renamed from identify_source_line.  Return type updated.
3347         * source.c (identify_source_line): Moved to annotate.c and renamed
3348         to annotate_source_line.
3349         (info_line_command): Remove check of annotation_level.
3350         * source.h (identify_source_line): Move declaration to annotate.h
3351         and rename to annotate_source_line.
3352         * stack.c: Add 'annotate.h' include.
3353         (print_frame_info): Remove check of annotation_level before
3354         calling annotate_source_line.
3355
3356 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * source-cache.c (source_cache::get_plain_source_lines): Use
3359         open_source_file_with_line_charpos instead of just
3360         open_source_file, remove call to find_source_lines.
3361         (source_cache::get_source_lines): Likewise.
3362         * source.c (find_source_lines): Make static.
3363         (get_filename_and_charpos): Renamed into...
3364         (open_source_file_with_line_charpos): ..this along with changes to
3365         return a scoped_fd, and some other minor clean ups.
3366         (identify_source_line): Use open_source_file_with_line_charpos.
3367         (search_command_helper): Use open_source_file_with_line_charpos
3368         instead of just open_source_file, remove call to
3369         find_source_lines.
3370         * source.h (open_source_file_with_line_charpos): Declare new
3371         function.
3372         (find_source_lines): Delete declaration.
3373
3374 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3375
3376         * source.c (get_filename_and_charpos): Remove fullname
3377         parameter.
3378         (identify_source_line): Update call to get_filename_and_charpos.
3379
3380 2019-06-14  Tom Tromey  <tromey@adacore.com>
3381
3382         PR gdb/24502:
3383         * ui-style.h (skip_ansi_escape): Update comment.
3384         * ui-file.h (class no_terminal_escape_file): New class.
3385         * ui-file.c (no_terminal_escape_file::write)
3386         (no_terminal_escape_file::puts): New methods.
3387         * cli/cli-logging.c (handle_redirections): Use
3388         no_terminal_escape_file.
3389
3390 2019-06-14  Tom Tromey  <tromey@adacore.com>
3391
3392         * NEWS: Move convenience variable news above Python news.
3393
3394 2019-06-14  Tom Tromey  <tom@tromey.com>
3395
3396         * gnulib: Move directory to top-level.
3397         * configure.ac: Don't configure gnulib.
3398         * configure: Rebuild.
3399         * common/common-defs.h: Use new path to gnulib.
3400         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3401         (GNULIB_H): Remove.
3402         (INCGNU): Look in new gnulib location.
3403         (HFILES_NO_SRCDIR): Remove gnulib files.
3404         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3405         (generated_files): Remove GNULIB_H.
3406         ($(LIBGNU), all-lib): Remove targets.
3407         (distclean): Don't mention GNULIB_BUILDDIR.
3408         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3409
3410 2019-06-14  Tom Tromey  <tromey@adacore.com>
3411
3412         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3413         Warn if symbol file does not provide any symbols.
3414
3415 2019-06-14  Tom Tromey  <tromey@adacore.com>
3416
3417         * source.c (find_and_open_source): Respect basenames_may_differ.
3418
3419 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * annotate.c (annotate_breakpoints_invalid): Make use of
3422         scoped_restore_terminal_state.
3423         (annotate_frames_invalid): Likewise.
3424
3425 2019-06-14  Tom Tromey  <tromey@adacore.com>
3426
3427         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3428         allow assignment to an internalvar.
3429
3430 2019-06-14  Tom Tromey  <tromey@adacore.com>
3431
3432         * ada-lex.l: Allow "_" in attribute names.
3433
3434 2019-06-14  Tom Tromey  <tromey@adacore.com>
3435
3436         PR gdb/24653:
3437         * regcache.c (registers_changed): Don't call alloca.
3438         * top.c (execute_command): Don't call alloca.
3439
3440 2019-06-13  Pedro Alves  <palves@redhat.com>
3441
3442         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3443         'expression'.  When parsing an expression, error out if there's
3444         junk after "unlimited".
3445         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3446         (do_set_command): Adjust calls to is_unlimited_literal.
3447
3448 2019-06-13  Pedro Alves  <palves@redhat.com>
3449
3450         * compile/compile.c (make_compile_options_def_group): Add braces
3451         around array_view initializer.
3452         * thread.c (make_thread_apply_all_options_def_group)
3453         (make_thread_apply_all_options_def_group): Likewise.
3454
3455 2019-06-13  Pedro Alves  <palves@redhat.com>
3456
3457         * NEWS (New commands): Mention "maint test-options
3458         require-delimiter", "maint test-options unknown-is-error", "maint
3459         test-options unknown-is-operand" and "maint show
3460         test-options-completion-result".
3461         (New command options, command completion): New section.
3462         (Completion improvements): New section.
3463         Mention that you can abbreviate "unlimited".
3464
3465 2019-06-13  Pedro Alves  <palves@redhat.com>
3466
3467         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3468         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3469         * unittests/cli-utils-selftests.c (test_parse_flags)
3470         (test_parse_flags_qcs): Delete.
3471         (test_cli_utils): Don't call deleted functions.
3472
3473 2019-06-13  Pedro Alves  <palves@redhat.com>
3474
3475         * thread.c: Include "cli/cli-option.h".
3476         (tp_array_compar_ascending): Global.
3477         (tp_array_compar): Delete function.
3478         (tp_array_compar_ascending, tp_array_compar_descending): New
3479         functions.
3480         (ascending_option_def, qcs_flag_option_def)
3481         (thr_qcs_flags_option_defs)
3482         (make_thread_apply_all_options_def_group)
3483         (make_thread_apply_options_def_group): New.
3484         (thread_apply_all_command): Use gdb::option::process_options.
3485         (thread_apply_command_completer)
3486         (thread_apply_all_command_completer): New.
3487         (thread_apply_command): Use gdb::option::process_options.
3488         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3489         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3490         to generate help text of "thread apply".  Adjust "taas"'s help.
3491         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3492         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3493
3494 2019-06-13  Pedro Alves  <palves@redhat.com>
3495
3496         * thread.c (thread_apply_command): Check for invalid TID with
3497         isdigit instead of !isalpha.
3498
3499 2019-06-13  Pedro Alves  <palves@redhat.com>
3500
3501         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3502         (validate_flags_qcs): New.
3503         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3504         (validate_flags_qcs): Declare.
3505         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3506         (make_frame_apply_options_def_group): New.
3507         (frame_apply_command_count): Process options with
3508         gdb::option::process_options.
3509         (frame_apply_completer): New.
3510         (frame_apply_level_completer, frame_apply_all_completer)
3511         (frame_apply_completer): New.
3512         (_initialize_stack): Update help of "frame apply", "frame apply
3513         level", "frame apply all" and "faas" to mention supported options
3514         and install command completers.
3515         * stack.h (frame_apply_all_completer): Declare.
3516         * thread.c: Include "stack.h".
3517         (tfaas_command): Add "--".
3518         (_initialize_thread): Update help "tfaas" to mention supported
3519         options and install command completer.
3520
3521 2019-06-13  Pedro Alves  <palves@redhat.com>
3522
3523         * completer.c (complete_nested_command_line): New.
3524         (gdb_completion_word_break_characters_throw): Add assertion.
3525         * completer.h (complete_nested_command_line): Declare.
3526
3527 2019-06-13  Pedro Alves  <palves@redhat.com>
3528
3529         * stack.c (parse_backtrace_qualifiers): New.
3530         (backtrace_command): Use it.
3531         (backtrace_command_completer): Complete on qualifiers.
3532
3533 2019-06-13  Pedro Alves  <palves@redhat.com>
3534
3535         * frame.c: Include "cli/cli-option.h.
3536         (user_set_backtrace_options): New.
3537         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3538         Delete.
3539         (get_prev_frame): Adjust.
3540         (boolean_option_def, uinteger_option_def)
3541         (set_backtrace_option_defs): New.
3542         (_initialize_frame): Adjust and use
3543         gdb::option::add_setshow_cmds_for_options to install "set
3544         backtrace past-main" and "set backtrace past-entry".
3545         * frame.h: Include "cli/cli-option.h".
3546         (struct frame_print_options): Forward declare.
3547         (print_frame_arguments_all, print_frame_arguments_scalars)
3548         (print_frame_arguments_none): Declare.
3549         (print_entry_values): Delete declaration.
3550         (struct frame_print_options, user_frame_print_options): New.
3551         (struct set_backtrace_options): New.
3552         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3553         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3554         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3555         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3556         (list_args_or_locals): Add frame_print_options parameter.
3557         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3558         * python/py-framefilter.c (enumerate_args): Pass down
3559         USER_FRAME_PRINT_OPTIONS.
3560         * stack.c: Include "cli/cli-option.h".
3561         (print_frame_arguments_all, print_frame_arguments_scalars)
3562         (print_frame_arguments_none): Declare.
3563         (print_raw_frame_arguments, print_entry_values): Delete.
3564         (user_frame_print_options): New.
3565         (boolean_option_def, enum_option_def, frame_print_option_defs):
3566         New.
3567         (struct backtrace_cmd_options): New.
3568         (bt_flag_option_def): New.
3569         (backtrace_command_option_defs): New.
3570         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3571         (print_frame_arg, read_frame_arg, print_frame_args)
3572         (print_frame_info, print_frame): Add frame_print_options parameter
3573         and use it.
3574         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3575         (backtrace_command_1): Add frame_print_options and
3576         backtrace_cmd_options parameters and use them.
3577         (make_backtrace_options_def_group): New.
3578         (backtrace_command): Process command options with
3579         gdb::option::process_options.
3580         (backtrace_command_completer): New.
3581         (_initialize_stack): Extend "backtrace"'s help to mention
3582         supported options.  Install completer for "backtrace".
3583         Install some settings commands with add_setshow_cmds_for_options.
3584
3585 2019-06-13  Pedro Alves  <palves@redhat.com>
3586
3587         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3588         and that "set/show print raw frame-arguments" are now deprecated.
3589
3590         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3591         command.
3592         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3593         * stack.c (_initialize_stack): Install "set/show print
3594         raw-frame-arguments", and deprecate "set/show print raw
3595         frame-arguments".
3596         * valprint.c (_initialize_valprint): Deprecate "set/show print
3597         raw".
3598
3599 2019-06-13  Pedro Alves  <palves@redhat.com>
3600
3601         * compile/compile.c (struct compile_options): New.
3602         (compile_flag_option_def, compile_command_option_defs)
3603         (make_compile_options_def_group): New.
3604         (compile_file_command): Handle options with
3605         gdb::option::process_options.
3606         (compile_file_command_completer): New function.
3607         (compile_code_command): Handle options with
3608         gdb::option::process_options.
3609         (compile_code_command_completer): New function.
3610         (_initialize_compiler): Install completers for "compile code" and
3611         "compile file".  Mention available options in "compile code" and
3612         "compile code"'s help.
3613         * completer.c (advance_to_completion_word): New, factored out from
3614         ...
3615         (advance_to_expression_complete_word_point): ... this.
3616         (advance_to_filename_complete_word_point): New.
3617         * completer.h (advance_to_filename_complete_word_point): New
3618         declaration.
3619
3620 2019-06-13  Pedro Alves  <palves@redhat.com>
3621
3622         * compile/compile.c: Include "cli/cli-option.h".
3623         (compile_print_value): Scope data pointer is now a
3624         value_print_options pointer; adjust.
3625         (compile_print_command): Process options.  Scope data pointer is
3626         now a value_print_options pointer; adjust.
3627         (_initialize_compile): Update "compile print"'s help to include
3628         supported options.  Install a completer for "compile print".
3629         * cp-valprint.c (show_vtblprint, show_objectprint)
3630         (show_static_field_print): Delete.
3631         (_initialize_cp_valprint): Don't install "set print
3632         static-members", "set print vtbl", "set print object" here.
3633         * printcmd.c: Include "cli/cli-option.h" and
3634         "common/gdb_optional.h".
3635         (print_command_parse_format): Rework to fill in a
3636         value_print_options instead of a format_data.
3637         (print_value): Change parameter type from format_data pointer to
3638         value_print_options reference.  Adjust.
3639         (print_command_1): Process options.  Adjust to pass down a
3640         value_print_options.
3641         (print_command_completer): New.
3642         (_initialize_printcmd): Install print_command_completer as
3643         handle_brkchars completer for the "print" command.  Update
3644         "print"'s help to include supported options.
3645         * valprint.c: Include "cli/cli-option.h".
3646         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3647         here from cp-valprint.c.
3648         (boolean_option_def, uinteger_option_def)
3649         (value_print_option_defs, make_value_print_options_def_group):
3650         New.  Use gdb::option::add_setshow_cmds_for_options to install
3651         "set print elements", "set print null-stop", "set print repeats",
3652         "set print pretty", "set print union", "set print array", "set
3653         print address", "set print symbol", "set print array-indexes".
3654         * valprint.h: Include <string> and "cli/cli-option.h".
3655         (make_value_print_options_def_group): Declare.
3656         (print_value): Change parameter type from format_data pointer to
3657         value_print_options reference.
3658         (print_command_completer): Declare.
3659
3660 2019-06-13  Pedro Alves  <palves@redhat.com>
3661
3662         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3663         (COMMON_SFILES): Add maint-test-settings.c.
3664         * cli/cli-decode.c (boolean_enums): New global, factored out from
3665         ...
3666         (add_setshow_boolean_cmd): ... here.
3667         * cli/cli-decode.h (boolean_enums): Declare.
3668         * cli/cli-option.c: New file.
3669         * cli/cli-option.h: New file.
3670         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3671         factored out from ...
3672         (parse_cli_boolean_value(const char *)): ... this.
3673         (is_unlimited_literal): Change parameter type to pointer to
3674         pointer.  Adjust and advance ARG pointer.
3675         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3676         (parse_cli_var_enum): New, factored out from ...
3677         (do_set_command): ... this.  Adjust.
3678         * cli/cli-setshow.h (parse_cli_boolean_value)
3679         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3680         (parse_cli_var_enum): Declare.
3681         * cli/cli-utils.c: Include "cli/cli-option.h".
3682         (get_ulongest): New.
3683         * cli/cli-utils.h (get_ulongest): Declare.
3684         (check_for_argument): New overloads.
3685         * maint-test-options.c: New file.
3686
3687 2019-06-13  Pedro Alves  <palves@redhat.com>
3688
3689         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3690         parse a range if "-" is at the end of the string.
3691
3692 2019-06-13  Pedro Alves  <palves@redhat.com>
3693
3694         * cli/cli-setshow.c (parse_auto_binary_operation)
3695         (parse_cli_boolean_value): Don't allow "o".
3696
3697 2019-06-13  Pedro Alves  <palves@redhat.com>
3698
3699         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3700         * NEWS: Mention maint test-settings KIND.
3701         * maint-test-settings.c: New file.
3702
3703 2019-06-13  Pedro Alves  <palves@redhat.com>
3704
3705         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3706         completer.
3707         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3708         "set" completers.
3709
3710 2019-06-13  Pedro Alves  <palves@redhat.com>
3711
3712         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3713         after item.
3714
3715 2019-06-13  Pedro Alves  <palves@redhat.com>
3716
3717         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3718
3719 2019-06-13  Pedro Alves <palves@redhat.com>
3720
3721         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3722         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3723         call.
3724         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3725         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3726         calls.
3727         (check_for_argument): Skip spaces after argument.
3728
3729 2019-06-13  Pedro Alves  <palves@redhat.com>
3730
3731         * thread.c (thread_apply_command): Adjust TID parsing.
3732         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3733         detected before end of string.
3734         (tid_is_in_list): Error out if LIST is invalid.
3735
3736 2019-06-13  Pedro Alves  <palves@redhat.com>
3737
3738         * completer.c (complete_line_internal_1): Rewind completion word
3739         point.
3740         (completion_tracker::advance_custom_word_point_by): Change
3741         parameter type to int.
3742         * completer.h (completion_tracker::advance_custom_word_point_by):
3743         Likewise.
3744
3745 2019-06-13  Pedro Alves  <palves@redhat.com>
3746
3747         * completer.c (advance_to_completion_word): Handle delimiters.
3748
3749 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3750
3751         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3752
3753 2019-06-11  Tom Tromey  <tom@tromey.com>
3754
3755         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3756         (xmalloc_failed): Move to alloc.c.
3757         * alloc.c: New file.
3758         * Makefile.in (COMMON_SFILES): Add alloc.c.
3759
3760 2019-06-11  Tom Tromey  <tom@tromey.com>
3761
3762         * nat/linux-waitpid.c: Don't include server.h.
3763         (linux_debug): Remove.
3764         (my_waitpid): Update.
3765
3766 2019-06-11  Tom Tromey  <tromey@adacore.com>
3767
3768         * infcall.c (_initialize_infcall): Remove trailing newline from
3769         help.
3770         * user-regs.c (_initialize_user_regs): Remove trailing newline
3771         from help.
3772         * typeprint.c (_initialize_typeprint): Remove trailing newline
3773         from help.
3774         * reverse.c (_initialize_reverse): Remove trailing newlines from
3775         help.
3776         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3777         from help.
3778         * language.c (add_set_language_command): Remove trailing newline
3779         from help.
3780         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3781         help.
3782         * disasm.c (_initialize_disasm): Remove trailing newline from
3783         help.
3784         * top.c (init_main): Remove trailing newline from help.
3785         * interps.c (_initialize_interpreter): Remove trailing newline
3786         from help.
3787         * btrace.c (_initialize_btrace): Remove trailing newlines from
3788         help.
3789         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3790         from help.
3791         * python/python.c (_initialize_python): Remove trailing newline
3792         from help.
3793         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3794         help.
3795         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3796         from help.  Reformat some text.
3797         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3798         from help.
3799         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3800         newline from help.
3801
3802 2019-06-11  Tom Tromey  <tromey@adacore.com>
3803
3804         * darwin-nat.c (darwin_decode_exception_message)
3805         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3806
3807 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * valops.c (value_slice): Check for not allocated or not
3810         associated values.
3811
3812 2019-06-10  Tom de Vries  <tdevries@suse.de>
3813
3814         PR gdb/24618
3815         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3816         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3817         invalid.
3818
3819 2019-06-10  Tom de Vries  <tdevries@suse.de>
3820
3821         PR gdb/24611
3822         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3823         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3824
3825 2019-06-10  Tom de Vries  <tdevries@suse.de>
3826
3827         PR symtab/24545
3828         * symtab.c (struct demangled_name_entry): Add language field.
3829         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3830         static minimal symbol".  Set and use language field.
3831
3832 2019-06-10  Tom Tromey  <tromey@adacore.com>
3833
3834         * ada-lang.c (_initialize_ada_language): Update help text.
3835
3836 2019-06-10  Tom Tromey  <tromey@adacore.com>
3837
3838         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3839         with a newline.
3840         * guile/guile.c (handle_boot_error): Don't end warning with a
3841         newline.
3842         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3843         warning with a newline.
3844         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3845         newline.
3846         (s12z_frame_cache): Likewise.
3847         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3848         a newline.
3849         * solib-svr4.c (disable_probes_interface): Don't end warning with
3850         a newline.
3851         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3852         newline.
3853         * python/python.c (do_finish_initialization): Don't end warning
3854         with a newline.
3855
3856 2019-06-10  Tom Tromey  <tom@tromey.com>
3857
3858         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3859         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3860         gdbpy_enter.
3861
3862 2019-06-10  Tom Tromey  <tromey@adacore.com>
3863
3864         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3865         data.
3866         (elf_new_init): Don't call stabsread_new_init.
3867         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3868         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3869         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3870
3871 2019-06-10  Tom de Vries  <tdevries@suse.de>
3872
3873         PR symtab/16264
3874         PR symtab/24517
3875         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3876
3877 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3878
3879         * source.c (find_and_open_source): Also rewrite relative file
3880         names.
3881
3882 2019-04-26  Amos Bird  <amosbird@gmail.com>
3883
3884         * annotate.c (annotate_thread_exited): Add "thread-exited"
3885         annotation.
3886
3887 2019-06-06  Tom Tromey  <tromey@adacore.com>
3888
3889         * maint.h (class scoped_command_stats): Use
3890         DISABLE_COPY_AND_ASSIGN.
3891         <print_time>: New method.
3892         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3893         print_time.
3894         (scoped_command_stats::print_time): New method.
3895
3896 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3899         instructions of lengths 6 or 8 bytes.
3900
3901 2019-06-04  Pedro Alves  <palves@redhat.com>
3902
3903         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3904
3905         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3906         * breakpoint.c (condition_completer): Likewise.
3907         * cli/cli-dump.c (scan_expression): Likewise.
3908         * common/filestuff.c (mkdir_recursive): Likewise.
3909         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3910         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3911         (gdb_abspath): Likewise.
3912         * compile/compile-cplus-types.c
3913         (compile_cplus_instance::decl_name): Likewise.
3914         * completer.c (complete_explicit_location):
3915         (signal_completer, reg_or_group_completer_1): Likewise.
3916         * cp-support.c (cp_remove_params_if_any): Likewise.
3917         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3918         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3919         * infcmd.c (strip_bg_char): Likewise.
3920         * linespec.c (copy_token_string): Likewise.
3921         * mi/mi-main.c (output_cores): Likewise.
3922         * psymtab.c (psymtab_search_name):
3923         * symfile.c (test_set_ext_lang_command): Likewise.
3924         * target.c (target_fileio_read_stralloc): Likewise.
3925         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3926         * value.c (complete_internalvar): Likewise.
3927
3928 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3929
3930         Add objfile property to gdb.Type.
3931         * NEWS: Mention Python API addition.
3932         * python/py-type.c (typy_get_objfile): New method.
3933
3934 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3935
3936         * NEWS: Mention the new set|show style [title|highlight].
3937         Mention changes to "show style", "help" and "apropos".
3938
3939 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3940
3941         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3942         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3943         instead of print_help_for_command.
3944         (print_doc_of_command): New function.
3945         (help_list): Add 'apropos -v word' suggestion.
3946         (print_help_for_command): Style the command name using title style.
3947         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3948         (_initialize_cli_cmds): Describe -v in apropos_command help.
3949
3950 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3951
3952         * cli/cli-style.h (cli_style_option): Add name in constructor,
3953         add m_name class member, add constructor with intensity,
3954         add name class function.
3955         (cli_style_option::add_setshow_commands): Remove name argument.
3956         (highlight_style, title_style): New styles.
3957         * cli/cli-style.c (do_show): New function that shows a style
3958         characteristic styling the style name with itself.
3959         (set_style_name): New function.
3960         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3961         Update all callers according to the changes in cli/cli-style.h.
3962         * utils.h (fputs_highlighted): New function.
3963         * utils.c (fputs_highlighted): Likewise.
3964
3965 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3966
3967         * NEWS: Mention new pipe command and new convenience variables.
3968
3969 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3970
3971         * cli/cli-cmds.c (pipe_command): New function.
3972         (_initialize_cli_cmds): Call add_com for pipe_command.
3973         Define | as an alias for pipe.
3974         (exit_status_set_internal_vars): New function.
3975         (shell_escape): Call exit_status_set_internal_vars.
3976         cli/cli-decode.c (find_command_name_length): Recognize | as
3977         a single character command.
3978
3979 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3982         top.c (execute_command_to_ui_file): New function, mostly a copy
3983         of execute_command_to_string.
3984         (execute_command_to_string): Implement by calling
3985         execute_command_to_ui_file.
3986
3987 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3988
3989         * top.h (saved_command_line): Remove declaration.
3990         * top.c (previous_saved_command_line, previous_repeat_arguments):
3991         New variables.
3992         (saved_command_line): Make static, define together with other
3993         'repeat variables'.
3994         (dont_repeat): Clear repeat_arguments.
3995         (repeat_previous, get_saved_command_line, save_command_line):
3996         New functions.
3997         (gdb_init): Initialize saved_command_line
3998         and previous_saved_command_line.
3999         * main.c (captured_main_1): Remove saved_command_line initialization.
4000         * event-top.c (handle_line_of_input): Update to use
4001         the new 'repeat' related functions instead of direct access to
4002         saved_command_line.
4003         * command.h (repeat_previous, get_saved_command_line,
4004         save_command_line): New declarations.
4005         (dont_repeat): Add comment.
4006
4007 2019-05-30  Tom Tromey  <tromey@adacore.com>
4008
4009         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4010         Fix comment.
4011         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4012
4013 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4014
4015         PR cli/24587
4016         * completer.c (complete): Initialize variable word.
4017
4018 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4019
4020         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4021         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4022         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4023         'body' is NULL to the outter 'if', protecting the '!is_define'
4024         situation as well.
4025
4026 2019-05-29  Tom Tromey  <tromey@adacore.com>
4027
4028         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4029         (dwarf_unknown): New function.
4030         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4031         (dwarf_type_encoding_name): Use dwarf_unknown.
4032
4033 2019-05-29  Tom Tromey  <tromey@adacore.com>
4034
4035         PR c++/20020:
4036         * cp-valprint.c (cp_print_value_fields): Call
4037         cp_print_static_field inside "try".
4038
4039 2019-05-29  Tom Tromey  <tromey@adacore.com>
4040
4041         * inflow.c (struct terminal_info): Add default operator=.
4042         * configure: Rebuild.
4043         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4044         -Wdeprecated-copy-dtor, -Wredundant-move.
4045
4046 2019-05-29  Tom Tromey  <tromey@adacore.com>
4047
4048         * NEWS: Add entry.
4049         * infcmd.c (print_return_value_1): Handle finish_print
4050         option.
4051         (show_print_finish): New function.
4052         (_initialize_infcmd): Add "set/show print finish" commands.
4053         * valprint.c (user_print_options): Initialize new member.
4054         * valprint.h (struct value_print_options) <finish_print>: New
4055         member.
4056
4057 2019-05-28  Tom Tromey  <tromey@adacore.com>
4058
4059         * ada-lang.c (ada_remove_Xbn_suffix)
4060         (find_old_style_renaming_symbol)
4061         (parse_old_style_renaming): Remove.
4062         (ada_find_renaming_symbol): Don't call
4063         find_old_style_renaming_symbol.
4064         (ada_is_renaming_symbol): Rename from
4065         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4066         bool.  Now static.
4067         (ada_read_var_value): Update and simplify.
4068         * ada-exp.y (write_var_or_type): Remove old code.
4069
4070 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4071
4072         * event-top.c: Remove include comment.
4073         * inflow.c (class scoped_ignore_sigttou): Move from here...
4074         * inflow.h (class scoped_ignore_sigttou): ...to here.
4075         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4076         * top.c:  Remove include comment.
4077
4078 2019-05-27  Tom Tromey  <tom@tromey.com>
4079
4080         * NEWS: Fix typo.
4081
4082 2019-05-22  Tom Tromey  <tromey@adacore.com>
4083
4084         * target.c (target_follow_exec): Constify parameter.
4085         * target-delegates.c: Rebuild.
4086         * remote.c (remote_target::follow_exec): Constify parameter.
4087         * infrun.c (follow_exec): Constify parameter.
4088         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4089         (target_follow_exec): Likewise.
4090
4091 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4092
4093         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4094         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4095
4096 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * NEWS: Add debugredirect and testsuite sections.
4099
4100 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4101
4102         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4103         target descriptions using exclusively floating point register name
4104         aliases.
4105
4106 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         PR gdb/18644:
4109         * f-lang.c (build_fortran_types): Handle the case where
4110         gdbarch_floatformat_for_type returns a nullptr.
4111
4112 2019-05-21  Tom de Vries  <tdevries@suse.de>
4113
4114         PR cli/24587
4115         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4116
4117 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4118
4119         PR gdb/18644:
4120         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4121         16-byte floats.
4122         * i386-tdep.c (i386_floatformat_for_type): Use
4123         floatformats_ia64_quad for the 16-byte floating point component
4124         within a fortran 32-byte complex number.
4125
4126 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4129         delete default constructor.
4130         (find_partial_die): Update to return const struct.
4131         (partial_die_parent_scope): Move variable declaration into scope
4132         of its use and change its type to auto.
4133         (guess_partial_die_structure_name): Likewise.
4134         (partial_die_info::fixup): Likewise.
4135
4136 2019-05-17  Tom Tromey  <tromey@adacore.com>
4137
4138         * source.c (find_and_open_source): Remove cast.
4139
4140 2019-05-17  Tom Tromey  <tromey@adacore.com>
4141
4142         * annotate.c (annotate_source): Make "filename" const.
4143         * annotate.h (annotate_source): Use const.
4144
4145 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4146
4147         * disasm.c (set_disassembler_options): Send errors to stderr.
4148
4149 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4150
4151         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4152         (cli_interp_base::set_logging): Check debug_redirect.
4153         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4154         * cli/cli-logging.c (debug_redirect): Add static variable.
4155         (pop_output_files): Add default param.
4156         (handle_redirections): Print debug setting.
4157         (show_logging_command): Likewise.
4158         (_initialize_cli_logging): Add debugredirect command.
4159         * interps.c (current_interp_set_logging): Add debug_redirect
4160         parameter.
4161         * interps.h (set_logging): Add debug_redirect parameter.
4162         (current_interp_set_logging): Likewise.
4163         * mi/mi-common.h: Likewise.
4164         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4165
4166 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4167             Tom Tromey  <tromey@adacore.com>
4168
4169         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4170         directly.
4171         * cli/cli-interp.h (make_logging_output): Remove declaration.
4172         * cli/cli-logging.c (make_logging_output): Remove function.
4173         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4174         directly.
4175         * ui-file.c (tee_file::tee_file): Remove bools.
4176         (tee_file::~tee_file): Remove deletes.
4177         * ui-file.h (tee_file): Remove bools.
4178
4179 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4180
4181         * mi/mi-cmds.h (mi_cmd_complete): New function.
4182         * mi/mi-main.c (mi_cmd_complete): Likewise.
4183         * mi/mi-cmds.c: Define new MI command -complete.
4184         * NEWS: Mention new -complete command.
4185
4186 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4187
4188         * completer.h (complete): New function.
4189         * completer.c (complete): Likewise.
4190         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4191         function defined in completer.h.
4192
4193 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4194
4195         * MAINTAINERS (Write After Approval): Add myself.
4196
4197 2019-05-17  Tom de Vries  <tdevries@suse.de>
4198
4199         PR gdb/24094
4200         * dwarf2read.c (struct cu_partial_die_info): New struct.
4201         (find_partial_die): Return cu_partial_die_info.
4202         (partial_die_parent_scope, guess_partial_die_structure_name)
4203         (partial_die_info::fixup): Handle new return type of find_partial_die.
4204
4205 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4206
4207         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4208         "std::string", simplifying the algorithm.
4209
4210 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4211
4212         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4213         (stap_static_probe_ops::get_probes): Likewise.
4214
4215 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4216
4217         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4218         '-')" and "else if".
4219         (stap_parse_single_operand): Join checks for
4220         "gdbarch_stap_parse_special_token_p" and
4221         "gdbarch_stap_parse_special_token" in the same "if" statement.
4222         Invert check when verifying for operation on register
4223         displacement.
4224
4225 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4226
4227         * stap-probe.c (stap_get_opcode): Update comment.
4228         (stap_get_expected_argument_type): Likewise.
4229         (handle_stap_probe): Likewise.
4230
4231 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4232
4233         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4234         return type to 'bool'.  Adjust comment.  Use 'bool' when
4235         appropriate.
4236         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4237         * stap-probe.c (stap_parse_argument_1): Likewise.
4238         (stap_is_operator): Likewise.
4239         (stap_is_generic_prefix): Likewise.
4240         (stap_is_register_prefix): Likewise.
4241         (stap_is_register_indirection_prefix): Likewise.
4242         (stap_is_integer_prefix): Likewise.
4243         (stap_generic_check_suffix): Likewise.
4244         (stap_check_integer_suffix): Likewise.
4245         (stap_check_register_suffix): Likewise.
4246         (stap_check_register_indirection_suffix): Likewise.
4247         (stap_parse_register_operand): Likewise.
4248         (stap_parse_single_operand): Likewise.
4249         (stap_parse_argument_1): Likewise.
4250         (stap_probe::get_argument_count): Likewise.
4251         (stap_is_operator): Likewise.
4252
4253 2019-05-16  Tom Tromey  <tromey@adacore.com>
4254
4255         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4256         keyword to foreach.
4257
4258 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4259
4260         * linux-thread-db.c (try_thread_db_load_1): Change return type
4261         to bool.
4262         (try_thread_db_load): Likewise.
4263         (try_thread_db_load_from_pdir_1): Likewise.
4264         (try_thread_db_load_from_pdir): Likewise.
4265         (try_thread_db_load_from_sdir): Likewise.
4266         (try_thread_db_load_from_dir): Likewise.
4267         (thread_db_load_search): Likewise.
4268         (has_libpthread): Likewise.
4269         (thread_db_load): Likewise.
4270
4271 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4272
4273         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4274         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4275         NULL, and complain/return if that's the case.
4276
4277 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4278
4279         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4280         (advance, posn, abstract_read_memory): New functions.
4281         [struct mem_read_abstraction]: New struct.
4282         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4283
4284 2019-05-14  Tom Tromey  <tromey@adacore.com>
4285
4286         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4287         value is not lval_memory.
4288
4289 2019-05-14  Tom Tromey  <tromey@adacore.com>
4290
4291         * solib.c (info_sharedlibrary_command): Style the file name.
4292
4293 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4294
4295         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4296         (aarch64_vnv_type): Likewise.
4297         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4298         * common/tdesc.c: Likewise.
4299         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4300         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4301         * features/aarch64-fpu.xml: Add ieee half view.
4302         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4303         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4304         * gdbtypes.h (struct builtin_type): Likewise.
4305         (struct objfile_type): Likewise.
4306
4307 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4308
4309         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4310         typo.
4311         * location.h (string_to_event_location): Likewise.
4312
4313 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4314
4315         GDB 8.3 released.
4316
4317 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4318
4319         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4320         New variable declaration.
4321         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4322         New variable.
4323         (print_one_breakpoint): Use ui_out::test_flags and new global
4324         variable to compute use_fixed_output.
4325         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4326         Remove.
4327         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4328         (mi_multi_location_breakpoint_output_fixed): Remove.
4329         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4330         new variable.
4331         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4332         fix_multi_location_breakpoint_output flag if version >= 3.
4333         * ui-out.h (enum ui_out_flag)
4334         <fix_multi_location_breakpoint_output>: New enumerator.
4335
4336 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4337
4338         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4339
4340 2019-05-10  Tom Tromey  <tromey@adacore.com>
4341
4342         * ada-lang.c (catch_ada_completer): New function.
4343         (_initialize_ada_language): Use it.
4344
4345 2019-05-10  Tom Tromey  <tromey@adacore.com>
4346
4347         * thread.c (print_thread_info): Make "requested_threads" const.
4348         * gdbthread.h (print_thread_info): Make "requested_threads"
4349         const.
4350         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4351         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4352
4353 2019-05-08  Tom Tromey  <tom@tromey.com>
4354
4355         * gdbtypes.c (objfile_type_data): Change type.
4356         (objfile_type, _initialize_gdbtypes): Update.
4357
4358 2019-05-08  Tom Tromey  <tom@tromey.com>
4359
4360         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4361         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4362         (_initialize_dwarf2_frame): Update.
4363
4364 2019-05-08  Tom Tromey  <tom@tromey.com>
4365
4366         * objc-lang.c (objc_objfile_data): Change type.
4367         (find_methods): Update.
4368         (_initialize_objc_lang): Remove.
4369
4370 2019-05-08  Tom Tromey  <tom@tromey.com>
4371
4372         * stabsread.c (rs6000_builtin_type_data): Change type.
4373         (rs6000_builtin_type, _initialize_stabsread): Update.
4374
4375 2019-05-08  Tom Tromey  <tom@tromey.com>
4376
4377         * mips-tdep.c (mips_pdr_data): Remove.
4378         (_initialize_mips_tdep): Update.
4379
4380 2019-05-08  Tom Tromey  <tom@tromey.com>
4381
4382         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4383         (hppa_init_objfile_priv_data, read_unwind_info)
4384         (find_unwind_entry, _initialize_hppa_tdep): Update.
4385
4386 2019-05-08  Tom Tromey  <tom@tromey.com>
4387
4388         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4389         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4390         on obstack.
4391         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4392
4393 2019-05-08  Tom Tromey  <tom@tromey.com>
4394
4395         * mdebugread.c (basic_type_data): Change type.
4396         (basic_type, _initialize_mdebugread): Update.
4397
4398 2019-05-08  Tom Tromey  <tom@tromey.com>
4399
4400         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4401
4402 2019-05-08  Tom Tromey  <tom@tromey.com>
4403
4404         * nto-tdep.c (nto_inferior_data_reg): Change type.
4405         (nto_inferior_data): Update.
4406         (nto_inferior_data_cleanup, nto_new_inferior_data)
4407         (_initialize_nto_tdep): Remove.
4408         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4409
4410 2019-05-08  Tom Tromey  <tom@tromey.com>
4411
4412         * ada-lang.c (struct ada_inferior_data): Add initializers.
4413         (ada_inferior_data): Change type.
4414         (ada_inferior_data_cleanup): Remove.
4415         (get_ada_inferior_data, ada_inferior_exit)
4416         (struct ada_pspace_data): Add initializers, destructor.
4417         (ada_pspace_data_handle): Change type.
4418         (get_ada_pspace_data): Update.
4419         (ada_pspace_data_cleanup): Remove.
4420
4421 2019-05-08  Tom Tromey  <tom@tromey.com>
4422
4423         * coffread.c (struct coff_symfile_info): Add initializers.
4424         (coff_objfile_data_key): Move lower.  Change type.
4425         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4426         Update.
4427         (coff_free_info): Remove.
4428
4429 2019-05-08  Tom Tromey  <tom@tromey.com>
4430
4431         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4432         (fbsd_pspace_data_handle): Move lower.  Change type.
4433         (get_fbsd_pspace_data): Update.
4434         (fbsd_pspace_data_cleanup): Remove.
4435         (_initialize_fbsd_tdep): Update.
4436
4437 2019-05-08  Tom Tromey  <tom@tromey.com>
4438
4439         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4440         (get_ada_tasks_pspace_data): Update.
4441         (ada_tasks_pspace_data_cleanup): Remove.
4442         (_initialize_tasks): Update.
4443         (ada_tasks_inferior_data_handle): Change type.
4444         (get_ada_tasks_inferior_data): Update.
4445         (ada_tasks_inferior_data_cleanup): Remove.
4446         (struct ada_tasks_pspace_data): Add initializers.
4447
4448 2019-05-08  Tom Tromey  <tom@tromey.com>
4449
4450         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4451         * symfile-debug.c (debug_sym_get_probes): Change type.
4452         * stap-probe.c (handle_stap_probe):
4453         (stap_static_probe_ops::get_probes): Change type.
4454         * probe.h (class static_probe_ops) <get_probes>: Change type.
4455         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4456         (parse_probes_in_pspace): Update.
4457         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4458         Update.
4459         (any_static_probe_ops::get_probes): Change type.
4460         * elfread.c (elfread_data): New typedef.
4461         (probe_key): Change type.
4462         (elf_get_probes): Likewise.  Update.
4463         (probe_key_free): Remove.
4464         (_initialize_elfread): Update.
4465         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4466         Change type.
4467         (dtrace_process_dof_probe, dtrace_process_dof)
4468         (dtrace_static_probe_ops::get_probe): Change type.
4469
4470 2019-05-08  Tom Tromey  <tom@tromey.com>
4471
4472         * xcoffread.c (struct xcoff_symfile_info): Rename from
4473         coff_symfile_info.  Add initializers.
4474         (xcoff_objfile_data_key): Move lower.  Change type.
4475         (XCOFF_DATA): Rewrite.
4476         (xcoff_free_info): Remove.
4477         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4478         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4479         (xcoff_initial_scan): Update.
4480
4481 2019-05-08  Tom Tromey  <tom@tromey.com>
4482
4483         * solib-svr4.c (struct svr4_info): Add initializers and
4484         destructor.
4485         <probes_table>: Now an htab_up.
4486         (solib_svr4_pspace_data): Change type.
4487         (free_probes_table): Simplify.
4488         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4489         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4490         (probes_table_remove_objfile_probes, register_solib_event_probe)
4491         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4492         (_initialize_svr4_solib): Update.
4493
4494 2019-05-08  Tom Tromey  <tom@tromey.com>
4495
4496         * remote.c (remote_pspace_data): Change type.
4497         (remote_pspace_data_cleanup): Remove.
4498         (get_remote_exec_file, set_pspace_remote_exec_file)
4499         (_initialize_remote): Update.
4500
4501 2019-05-08  Tom Tromey  <tom@tromey.com>
4502
4503         * breakpoint.c (breakpoint_objfile_key): Change type.
4504         (get_breakpoint_objfile_data): Update.
4505         (free_breakpoint_objfile_data): Remove.
4506         (_initialize_breakpoint): Update.
4507
4508 2019-05-08  Tom Tromey  <tom@tromey.com>
4509
4510         * linux-tdep.c (struct linux_info): Add initializers.
4511         (linux_inferior_data): Move.  Change type.
4512         (invalidate_linux_cache_inf): Update.
4513         (linux_inferior_data_cleanup): Remove.
4514         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4515
4516 2019-05-08  Tom Tromey  <tom@tromey.com>
4517
4518         * auxv.c (auxv_inferior_data): Move.  Change type.
4519         (auxv_inferior_data_cleanup): Remove.
4520         (invalidate_auxv_cache_inf): Rewrite.
4521         (get_auxv_inferior_data, _initialize_auxv): Update.
4522
4523 2019-05-08  Tom Tromey  <tom@tromey.com>
4524
4525         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4526         (symfile_debug_objfile_data_key): Change type.
4527         (symfile_debug_installed, debug_qf_has_symbols)
4528         (debug_qf_find_last_source_symtab)
4529         (debug_qf_forget_cached_source_info)
4530         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4531         (debug_qf_print_stats, debug_qf_dump)
4532         (debug_qf_expand_symtabs_for_function)
4533         (debug_qf_expand_all_symtabs)
4534         (debug_qf_expand_symtabs_with_fullname)
4535         (debug_qf_map_matching_symbols)
4536         (debug_qf_expand_symtabs_matching)
4537         (debug_qf_find_pc_sect_compunit_symtab)
4538         (debug_qf_map_symbol_filenames)
4539         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4540         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4541         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4542         (debug_sym_read_linetable, debug_sym_relocate): Update.
4543         (symfile_debug_free_objfile): Remove.
4544         (install_symfile_debug_logging, _initialize_symfile_debug):
4545         Update.
4546
4547 2019-05-08  Tom Tromey  <tom@tromey.com>
4548
4549         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4550         allocate_on_obstack.
4551         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4552         (get_dwarf2_per_objfile): Update.
4553         (set_dwarf2_per_objfile): Remove.
4554         (dwarf2_has_info, dwarf2_get_section_info): Update.
4555         (dwarf2_free_objfile): Remove.
4556         (_initialize_dwarf2_read): Update.
4557
4558 2019-05-08  Tom Tromey  <tom@tromey.com>
4559
4560         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4561         initializers.
4562         <unsupported_script_warning_printed,
4563         script_not_found_warning_printed>: Now bool.
4564         (auto_load_pspace_data): Change type.
4565         (~auto_load_pspace_info): Rename from
4566         auto_load_pspace_data_cleanup.
4567         (get_auto_load_pspace_data, init_loaded_scripts_info)
4568         (clear_section_scripts, maybe_print_unsupported_script_warning)
4569         (maybe_print_script_not_found_warning, _initialize_auto_load):
4570         Update.
4571
4572 2019-05-08  Tom Tromey  <tom@tromey.com>
4573
4574         * objfiles.c (objfile_pspace_info): Add destructor and
4575         initializers.
4576         (objfiles_pspace_data): Change type.
4577         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4578         (get_objfile_pspace_data): Update.
4579         (objfiles_bfd_data): Change type.
4580         (get_objfile_bfd_data): Update.
4581         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4582
4583 2019-05-08  Tom Tromey  <tom@tromey.com>
4584
4585         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4586         Change type.
4587         (get_catch_syscall_inferior_data): Update.
4588         (catch_syscall_inferior_data_cleanup): Remove.
4589         (_initialize_break_catch_syscall): Update.
4590
4591 2019-05-08  Tom Tromey  <tom@tromey.com>
4592
4593         * inflow.c (struct terminal_info): Add destructor and
4594         initializers.
4595         (inflow_inferior_data): Change type.
4596         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4597         (get_inflow_inferior_data, inflow_inferior_exit)
4598         (swap_terminal_info, _initialize_inflow): Update.
4599
4600 2019-05-08  Tom Tromey  <tom@tromey.com>
4601
4602         * target-dcache.c (target_dcache_cleanup): Remove.
4603         (target_dcache_aspace_key): Change type.
4604         (target_dcache_init_p, target_dcache_invalidate)
4605         (target_dcache_get, target_dcache_get_or_init)
4606         (_initialize_target_dcache): Update.
4607         * dcache.h (struct dcache_deleter): New.
4608
4609 2019-05-08  Tom Tromey  <tom@tromey.com>
4610
4611         * symtab.c (struct symbol_cache): Add destructor and
4612         initializers.
4613         (symbol_cache_key): Move.  Change type.
4614         (make_symbol_cache, free_symbol_cache): Remove.
4615         (get_symbol_cache): Update.
4616         (symbol_cache_cleanup): Remove.
4617         (ALL_PSPACES, symbol_cache_flush)
4618         (maintenance_print_symbol_cache)
4619         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4620         Update.
4621
4622 2019-05-08  Tom Tromey  <tom@tromey.com>
4623
4624         * symtab.c (struct main_info): Add destructor and initializers.
4625         (main_progspace_key): Move.  Change type.
4626         (get_main_info): Update.
4627         (main_info_cleanup): Remove.
4628         (_initialize_symtab): Update.
4629
4630 2019-05-08  Tom Tromey  <tom@tromey.com>
4631
4632         * registry.h (DECLARE_REGISTRY): Define the _key class.
4633
4634 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * NEWS: Merge two 'New commands' sections.
4637
4638 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4639
4640         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4641         parameter and use Ada language definition instead.
4642         (ada_val_print_ptr): Remove unused language parameter.
4643         (ada_val_print_num): Remove language parameter and use Ada language
4644         definition instead.
4645         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4646         parameter.
4647         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4648         parameter and use Ada language definition instead.
4649         (ada_val_print_1): Update all ada_val_print_xxx calls.
4650         Remove language parameter.
4651         (ada_val_print): Update ada_val_print_1 call.
4652
4653 2019-05-08  Tom Tromey  <tromey@adacore.com>
4654
4655         * remote.c (remote_hw_watchpoint_limit)
4656         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4657         Now static.
4658
4659 2019-05-08  Tom Tromey  <tromey@adacore.com>
4660
4661         * maint.c (_initialize_maint_cmds): Move initialization code to
4662         remote.c.
4663         (watchdog, show_watchdog): Move to remote.c.
4664         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4665         "watchdog" static.
4666         (_initialize_remote): Move initialization code from maint.c.
4667         * defs.h (watchdog): Don't declare.
4668
4669 2019-05-08  Tom Tromey  <tromey@adacore.com>
4670
4671         * tui/tui-interp.c: Include main.h.
4672         * interps.c: Include main.h.
4673         * main.h (interpreter_p): Declare.
4674         * defs.h (interpreter_p): Don't declare.
4675
4676 2019-05-08  Tom Tromey  <tromey@adacore.com>
4677
4678         * dwarf2loc.c: Include dwarf2read.h.
4679         * defs.h (read_unsigned_leb128): Don't declare.
4680         * dwarf2read.h (read_unsigned_leb128): Declare.
4681
4682 2019-05-08  Tom Tromey  <tromey@adacore.com>
4683
4684         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4685         method.
4686
4687 2019-05-08  Tom Tromey  <tromey@adacore.com>
4688
4689         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4690         when no wrap column is set.
4691
4692 2019-05-08  Tom Tromey  <tromey@adacore.com>
4693
4694         * c-lang.c (c_get_string): Handle non-C-style arrays.
4695
4696 2019-05-08  Tom Tromey  <tromey@adacore.com>
4697
4698         * typeprint.c (print_offset_data::update): Print the bit offset,
4699         not the number of bits remaining.
4700
4701 2019-05-08  Tom Tromey  <tromey@adacore.com>
4702
4703         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4704         padding at end of comment.
4705
4706 2019-05-08  Tom Tromey  <tromey@adacore.com>
4707
4708         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4709         Compare main types.
4710
4711 2019-05-06  Tom Tromey  <tom@tromey.com>
4712
4713         * common/scoped_mmap.c: Include common-defs.h.
4714         * common/scoped_mmap.h: Don't include config.h.
4715
4716 2019-05-04  Tom Tromey  <tom@tromey.com>
4717
4718         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4719         (struct aarch64_call_info): Add initializers.
4720         <si>: Now a std::vector.
4721         (pass_on_stack, aarch64_push_dummy_call): Update.
4722
4723 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4724             Tom Tromey  <tom@tromey.com>
4725
4726         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4727         (ppc_threads): Now a std::vector.  Now static.
4728         (hwdebug_find_thread_points_by_tid)
4729         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4730         Update.
4731
4732 2019-05-04  Tom Tromey  <tom@tromey.com>
4733
4734         * arc-tdep.c (arc_tdesc_init): Return bool.
4735
4736 2019-05-04  Tom Tromey  <tom@tromey.com>
4737
4738         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4739         Use gdb_assert_not_reached.
4740
4741 2019-05-04  Tom Tromey  <tom@tromey.com>
4742
4743         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4744         "false".
4745
4746 2019-05-04  Tom Tromey  <tom@tromey.com>
4747
4748         * arc-tdep.c (arc_tdesc_init): Use bool.
4749
4750 2019-05-04  Tom Tromey  <tom@tromey.com>
4751
4752         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4753
4754 2019-05-04  Tom Tromey  <tom@tromey.com>
4755
4756         * cli/cli-cmds.c (valid_command_p): Return bool.
4757
4758 2019-05-04  Tom Tromey  <tom@tromey.com>
4759
4760         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4761         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4762
4763 2019-05-04  Raul Tambre  <raul@tambre.ee>
4764
4765         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4766         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4767         operator for comparison.
4768
4769 2019-05-04  Tom Tromey  <tom@tromey.com>
4770
4771         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4772         (lookup_partial_symbol, print_partial_symbols)
4773         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4774         (psymbol_compare): Update.
4775         (add_psymbol_to_bcache): Clear the entire psymbol.
4776         (maintenance_check_psymtabs): Update.
4777         * psympriv.h (struct partial_symbol): Don't derive from
4778         general_symbol_info.
4779         <obj_section, unrelocated_address, address,
4780         set_unrelocated_address>: Update.
4781         <ginfo>: New member.
4782         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4783         (debug_names::write_psymbols): Update.
4784
4785 2019-05-04  Tom de Vries  <tdevries@suse.de>
4786
4787         * contrib/cc-with-tweaks.sh: Support -n arg.
4788
4789 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4790
4791         * corelow.c (core_target::detach): Ensure frame cache and
4792         register caches are cleared.
4793         inferior.c (exit_inferior_1): Likewise.
4794
4795 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4796             Tom Tromey  <tom@tromey.com>
4797
4798         * dictionary.c (collate_pending_symbols_by_language): Remove
4799         "struct" from foreach.
4800         * symtab.c (lookup_global_symbol_from_objfile)
4801         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4802         foreach.
4803         * ser-tcp.c (net_open): Remove "struct" from foreach.
4804         * objfiles.c (objfile_relocate, objfile_rebase)
4805         (objfile_has_symbols): Remove "struct" from foreach.
4806         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4807         from foreach.
4808         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4809         foreach.
4810         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4811         "struct" from foreach.
4812         * ada-lang.c (create_excep_cond_exprs)
4813         (ada_exception_catchpoint_cond_string): Remove "struct" from
4814         foreach.
4815
4816 2019-05-03  Tom Tromey  <tromey@adacore.com>
4817
4818         * ada-exp.y (convert_char_literal): Check suffix of each
4819         enumerator.
4820
4821 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4822
4823         PR ada/21406:
4824         * ada-exp.y (yywrap): Don't define.
4825         * ada-lex.l (%option): Add noyywrap
4826         (yywrap): Remove.
4827
4828 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4829
4830         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4831         _WIN32_WINNT to the XP level, unless already defined to a higher
4832         level.
4833
4834         * unittests/parse-connection-spec-selftests.c:
4835         * ser-tcp.c:
4836         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4837         override.
4838
4839         * symfile.c (find_separate_debug_file): Remove colon from the
4840         drive spec of DOS/Windows file names of the target, so that the
4841         file name produced from DEBUGDIR and the target's directory will
4842         be valid on DOS/Windows systems.
4843
4844 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * rust-lang.c (val_print_struct): Handle printing structures
4847         containing strings.
4848
4849 2019-05-02  Tom Tromey  <tromey@adacore.com>
4850
4851         * valarith.c (_initialize_valarith): Remove.
4852
4853 2019-05-01  Tom Tromey  <tromey@adacore.com>
4854
4855         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4856         bitfields.
4857
4858 2019-05-01  Tom Tromey  <tromey@adacore.com>
4859
4860         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4861         for big-endian copies.
4862
4863 2019-04-30  Ali Tamur  <tamur@google.com>
4864         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4865         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4866         (read_3_bytes): New function.
4867
4868 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4869
4870         * windows-nat.c (main_thread_id): Delete.
4871         (handle_output_debug_string): Replace main_thread_id by
4872         current_event.dwThreadId.
4873         (fake_create_process): Likewise.
4874         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4875         Do not set main_thread_id.
4876         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4877         current_event.dwThreadId.
4878         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4879
4880 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4881
4882         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4883         Use current_event.dwThreadId instead of main_thread_id.
4884
4885 2019-04-30  Tom Tromey  <tromey@adacore.com>
4886
4887         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4888         (create_excep_cond_exprs): Iterate over program spaces.
4889         (ada_exception_catchpoint_cond_string): Examine all minimal
4890         symbols for exception types.
4891
4892 2019-04-30  Tom Tromey  <tromey@adacore.com>
4893
4894         PR c++/24470:
4895         * dwarf2read.c (process_structure_scope): Handle case where type
4896         has template parameters but no symbol was created.
4897
4898 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4899             Chris January  <chris.january@arm.com>
4900
4901         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4902         qualifier.
4903         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4904
4905 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4906
4907         * f-typeprint.c (f_print_type): Update rules for printing
4908         whitespace.
4909         (f_type_print_varspec_suffix): Likewise.
4910
4911 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4912             Chris January  <chris.january@arm.com>
4913
4914         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4915         function arguments.
4916
4917 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * f-lang.c (build_fortran_types): Change name of void type to
4920         lower case.
4921         * f-typeprint.c (f_type_print_base): Print the name of the void
4922         type, rather than a fixed string.
4923         * f-valprint.c (f_decorations): Use lower case void string.
4924
4925 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4926             Chris January  <chris.january@arm.com>
4927
4928         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4929         types for Fortran.
4930
4931 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4932             Chris January  <chris.january@arm.com>
4933             David Lecomber  <david.lecomber@arm.com>
4934
4935         * f-exp.y (BINOP_INTRINSIC): New token.
4936         (exp): New parser rule handling BINOP_INTRINSIC.
4937         (f77_keywords): Add new builtin procedures.
4938         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4939         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4940         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4941         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4942         (print_unop_subexp_f): New function.
4943         (print_binop_subexp_f): New function.
4944         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4945         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4946         (dump_subexp_body_f): Likewise.
4947         (operator_check_f): Likewise.
4948         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4949         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4950
4951 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4954         UNOP_KIND.
4955         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4956         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4957         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4958         (operator_length_f): New fuction.
4959         (print_subexp_f): New function.
4960         (op_name_f): New function.
4961         (dump_subexp_body_f): New function.
4962         (operator_check_f): New function.
4963         (exp_descriptor_f): Replace standard expression handling functions
4964         with new functions.
4965         * gdb/fortran-operator.def: New file.
4966         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4967         * gdb/std-operator.def: Remove UNOP_KIND.
4968
4969 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4970
4971         * std-operator.def: Remove unbalanced, stray double quote
4972         character.
4973
4974 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4975             Chris January  <chris.january@arm.com>
4976             Daniel Everett  <daniel.everett@arm.com>
4977             Nick Forrington  <nick.forrington@arm.com>
4978             Richard Bunt  <richard.bunt@arm.com>
4979
4980         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4981         of depth when printing anonymous structs or unions.
4982         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4983         Don't print either the top-level value, or the children if the
4984         max-depth is exceeded.
4985         (ppscm_print_children): When printing the key of a map, allow one
4986         extra level of depth.
4987         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4988         print either the top-level value, or the children if the max-depth
4989         is exceeded.
4990         (print_children): When printing the key of a map, allow one extra
4991         level of depth.
4992         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4993         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4994         (user_print_options): Initialise max_depth field.
4995         (val_print_scalar_or_string_type_p): New function.
4996         (val_print): Check to see if the max depth has been reached.
4997         (val_print_check_max_depth): Define new function.
4998         (show_print_max_depth): New function.
4999         (_initialize_valprint): Add 'print max-depth' option.
5000         * valprint.h (struct value_print_options) <max_depth>: New field.
5001         (val_print_check_max_depth): Declare new function.
5002         * NEWS: Document new feature.
5003
5004 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * ada-lang.c (ada_language_defn): Initialise new field.
5007         * c-lang.c (c_is_string_type_p): New function.
5008         (c_language_defn): Initialise new field.
5009         (cplus_language_defn): Initialise new field.
5010         (asm_language_defn): Initialise new field.
5011         (minimal_language_defn): Initialise new field.
5012         * c-lang.h (c_is_string_type_p): Declare new function.
5013         * d-lang.c (d_language_defn): Initialise new field.
5014         * f-lang.c (f_is_string_type_p): New function.
5015         (f_language_defn): Initialise new field.
5016         * go-lang.c (go_is_string_type_p): New function.
5017         (go_language_defn): Initialise new field.
5018         * language.c (default_is_string_type_p): New function.
5019         (unknown_language_defn): Initialise new field.
5020         (auto_language_defn): Initialise new field.
5021         * language.h (struct language_defn) <la_is_string_type_p>: New
5022         member variable.
5023         (default_is_string_type_p): Declare new function.
5024         * m2-lang.c (m2_language_defn): Initialise new field.
5025         * objc-lang.c (objc_language_defn): Initialise new field.
5026         * opencl-lang.c (opencl_language_defn): Initialise new field.
5027         * p-lang.c (pascal_is_string_type_p): New function.
5028         (pascal_language_defn): Initialise new field.
5029         * rust-lang.c (rust_is_string_type_p): New function.
5030         (rust_language_defn): Initialise new field.
5031
5032 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5033
5034         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5035         New field.
5036         * ada-lang.c (ada_language_defn): Initialise new field.
5037         * c-lang.c (c_language_defn): Likewise.
5038         (cplus_language_defn): Likewise.
5039         (asm_language_defn): Likewise.
5040         (minimal_language_defn): Likewise.
5041         * d-lang.c (d_language_defn): Likewise.
5042         * f-lang.c (f_language_defn): Likewise.
5043         * go-lang.c (go_language_defn): Likewise.
5044         * language.c (unknown_language_defn): Likewise.
5045         (auto_language_defn): Likewise.
5046         * m2-lang.c (m2_language_defn): Likewise.
5047         * objc-lang.c (objc_language_defn): Likewise.
5048         * opencl-lang.c (opencl_language_defn): Likewise.
5049         * p-lang.c (pascal_language_defn): Likewise.
5050         * rust-lang.c (rust_language_defn): Likewise.
5051
5052 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5053
5054         * ada-lang.c (ada_is_character_type): Change return type to bool.
5055         (ada_is_string_type): Likewise.
5056         * ada-lang.h (ada_is_character_type): Update declaration
5057         (ada_is_string_type): Likewise.
5058
5059 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5060
5061         Support style in 'frame|thread apply'
5062
5063         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5064         * record.c (record_start, record_stop): Update callers of
5065         execute_command_to_string with false.
5066         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5067         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5068         methods.
5069         (class string_file): New constructor with term_out parameter.
5070         Override methods term_out and can_emit_style_escape.  New member
5071         term_out.
5072         (class stdio_file): Override can_emit_style_escape.
5073         (class tee_file): Override term_out and can_emit_style_escape.
5074         * utils.h (can_emit_style_escape): Remove.
5075         * utils.c (can_emit_style_escape): Likewise.
5076         Update all callers of can_emit_style_escape (SOMESTREAM) to
5077         SOMESTREAM->can_emit_style_escape.
5078         * source-cache.c (source_cache::get_source_lines): Likewise.
5079         * stack.c (frame_apply_command_count): Call execute_command_to_string
5080         passing the term_out characteristic of the current gdb_stdout.
5081         * thread.c (thr_try_catch_cmd): Likewise.
5082         * top.c (execute_command_to_string): pass term_out parameter
5083         to construct the string_file for the command output.
5084         * ui-file.c (term_cli_styling): New function (most code moved
5085         from utils.c can_emit_style_escape).
5086         (string_file::string_file, string_file::can_emit_style_escape,
5087         stdio_file::can_emit_style_escape, tee_file::term_out,
5088         tee_file::can_emit_style_escape): New functions.
5089
5090 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5091
5092         * NEWS: Mention the new set|show may-call-functions.
5093         * infcall.c (may_call_functions_p): New variable.
5094         (show_may_call_functions_p): New function.
5095         (call_function_by_hand_dummy): Throws an error if not
5096         may-call-functions.
5097         (_initialize_infcall): Call add_setshow_boolean_cmd for
5098         may-call-functions.
5099
5100 2019-04-25  Keith Seitz  <keiths@redhat.com>
5101
5102         PR c++/24367
5103         * cp-support.c (inspect_type): Don't attempt substitutions
5104         of symbol with the same name.
5105
5106 2019-04-25  Tom Tromey  <tromey@adacore.com>
5107
5108         PR gdb/24475:
5109         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5110         static.
5111
5112 2019-04-25  Tom Tromey  <tromey@adacore.com>
5113
5114         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5115         rvalue reference.
5116         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5117         (gdb_xml_parser::parse): Use std::move.
5118         * python/python-internal.h (gdbpy_convert_exception): Take a const
5119         reference.
5120         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5121         std::move.
5122         * python/py-utils.c (gdbpy_convert_exception): Take a const
5123         reference.
5124         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5125         Use std::move.
5126         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5127         Use std::move.
5128         * mi/mi-main.c (mi_print_exception): Take a const reference.
5129         * main.c (handle_command_errors): Take a const reference.
5130         * linespec.c (parse_linespec): Use std::move.
5131         * infcall.c (run_inferior_call): Use std::move.
5132         (call_function_by_hand_dummy): Use std::move.
5133         * exec.c (try_open_exec_file): Use std::move.
5134         * exceptions.h (exception_print, exception_fprintf)
5135         (exception_print_same): Update.
5136         * exceptions.c (print_exception, exception_print)
5137         (exception_fprintf, exception_print_same): Change parameters to
5138         const reference.
5139         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5140         * common/new-op.c: Use std::move.
5141         * common/common-exceptions.h (struct gdb_exception): Add move
5142         constructor.
5143         (struct gdb_exception_error, struct gdb_exception_quit, struct
5144         gdb_quit_bad_alloc): Change constructor to move constructor.
5145         (throw_exception): Change parameter to rvalue reference.
5146         * common/common-exceptions.c (throw_exception): Take rvalue
5147         reference.
5148         * cli/cli-interp.c (safe_execute_command): Use std::move.
5149         * breakpoint.c (insert_bp_location, location_to_sals): Use
5150         std::move.
5151
5152 2019-04-25  Tom Tromey  <tromey@adacore.com>
5153
5154         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5155         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5156         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5157         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5158         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5159         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5160         guile/scm-value.c: Use unpack.
5161         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5162         gdbscm_gdb_exception.
5163         (gdbscm_throw_gdb_exception): Likewise.
5164         (struct gdbscm_gdb_exception): New.
5165         (unpack): New function.
5166         (gdbscm_wrap): Use unpack.
5167
5168 2019-04-25  Tom Tromey  <tromey@adacore.com>
5169
5170         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5171         (gdb_rl_callback_handler): Use std::move.
5172         * common/common-exceptions.h (struct gdb_exception): Add move
5173         assignment operator.
5174         (throw_exception_sjlj): Change "exception" to const reference.
5175         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5176         (throw_exception_sjlj): Change "exception" to const reference.
5177
5178 2019-04-25  Tom Tromey  <tromey@adacore.com>
5179
5180         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5181         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5182         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5183         Update.
5184         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5185         Update.
5186         * mi/mi-interp.c (mi_interp::exec): Update.
5187         * linespec.c (parse_linespec): Update.
5188         * infcall.c (run_inferior_call): Update.
5189         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5190         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5191         (gdbscm_lookup_global_symbol): Update.
5192         * guile/scm-param.c (gdbscm_parameter_value): Update.
5193         * guile/scm-frame.c (gdbscm_frame_read_register)
5194         (gdbscm_frame_read_var): Update.
5195         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5196         * exec.c (try_open_exec_file): Update.
5197         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5198         (gdb_rl_callback_handler): Update.
5199         * common/common-exceptions.h (exception_none): Don't declare.
5200         * common/common-exceptions.c (exception_none): Don't define.
5201         (struct catcher) <exception>: Update.
5202         * cli/cli-interp.c (safe_execute_command): Update.
5203         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5204
5205 2019-04-25  Ali Tamur  <tamur@google.com>
5206
5207         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5208         (read_attribute_value): Likewise.
5209         (dwarf2_read_addr_index): Update comment.
5210         (read_str_index): Add DW_FORM_strx.
5211         (dwarf2_string_attr): Likewise.
5212         (dwarf2_const_value_attr): Likewise.
5213         (dump_die_shallow): Likewise.
5214         (dwarf2_fetch_constant_bytes): Likewise.
5215         (skip_form_bytes): Likewise.
5216         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5217
5218 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5219
5220         PR corefiles/11608
5221         PR corefiles/18187
5222         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5223         OFFSET.  Verify if current mapping contains an ELF header.
5224         (linux_find_memory_regions_full): Adjust call to
5225         dump_mapping_p.
5226
5227 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5228             Kang Li <kanglictf@gmail.com>
5229
5230         PR gdb/21600
5231
5232         * dwarf2-frame.c (read_initial_length): Be consistent about using
5233         unsigned representation of length.
5234         (decode_frame_entry_1): Likewise.  Check for wraparound of
5235         end pointer as well as buffer overflow.
5236
5237 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5238
5239         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5240         "vq".
5241
5242 2019-04-24  Tom Tromey  <tromey@adacore.com>
5243
5244         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5245
5246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5247
5248         * s12z-tdep.c (s12z_unwind_pc): Delete.
5249         (s12z_unwind_sp): Delete.
5250         (s12z_gdbarch_init): Don't register deleted functions with
5251         gdbarch.
5252
5253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5254
5255         * rl78-tdep.c (rl78_unwind_sp): Delete.
5256         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5257
5258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5261         (xstormy16_unwind_pc): Delete.
5262         (xstormy16_dummy_id): Delete.
5263         (xstormy16_gdbarch_init): Don't register deleted functions with
5264         gdbarch.
5265
5266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * vax-tdep.c (vax_unwind_pc): Delete.
5269         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5270
5271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5272
5273         * v850-tdep.c (v850_unwind_sp): Delete.
5274         (v850_unwind_pc): Delete.
5275         (v850_dummy_id): Delete.
5276         (v850_gdbarch_init): Don't register deleted functions with
5277         gdbarch.
5278
5279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5282         (tilegx_unwind_pc): Delete.
5283         (tilegx_unwind_dummy_id): Delete.
5284         (tilegx_gdbarch_init): Don't register deleted functions with
5285         gdbarch.
5286
5287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5290         (tic6x_dummy_id): Delete.
5291         (tic6x_gdbarch_init): Don't register deleted functions with
5292         gdbarch.
5293
5294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * sparc-tdep.c (sparc_unwind_pc): Delete.
5297         (sparc32_gdbarch_init): Don't register deleted function with
5298         gdbarch.
5299
5300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * sh-tdep.c (sh_unwind_sp): Delete.
5303         (sh_unwind_pc): Delete.
5304         (sh_dummy_id): Delete.
5305         (sh_gdbarch_init): Don't register deleted functions with
5306         gdbarch.
5307
5308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5309
5310         * score-tdep.c (score_unwind_sp): Delete.
5311         (score_unwind_pc): Delete.
5312         (score_dummy_id): Delete.
5313         (score_gdbarch_init): Don't register deleted functions with
5314         gdbarch.
5315
5316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         * rx-tdep.c (rx_unwind_pc): Delete.
5319         (rx_unwind_sp): Delete.
5320         (rx_dummy_id): Delete.
5321         (rx_gdbarch_init): Don't register deleted functions with
5322         gdbarch.  Update comment.
5323
5324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5325
5326         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5327         (rs6000_dummy_id): Delete.
5328         (rs6000_gdbarch_init): Don't register deleted functions with
5329         gdbarch.
5330
5331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * or1k-tdep.c (or1k_dummy_id): Delete.
5334         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5335
5336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * nios2-tdep.c (nios2_dummy_id): Delete.
5339         (nios2_unwind_sp): Delete.
5340         (nios2_gdbarch_init): Don't register deleted functions with
5341         gdbarch.
5342
5343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * nds32-tdep.c (nds32_dummy_id): Delete.
5346         (nds32_unwind_pc): Delete.
5347         (nds32_unwind_sp): Delete.
5348         (nds32_gdbarch_init): Don't register deleted functions with
5349         gdbarch.
5350
5351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5352
5353         * msp430-tdep.c (msp430_unwind_pc): Delete.
5354         (msp430_unwind_sp): Delete.
5355         (msp430_dummy_id): Delete.
5356         (msp430_gdbarch_init): Don't register deleted functions with
5357         gdbarch.
5358
5359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * moxie-tdep.c (moxie_unwind_sp): Delete.
5362         (moxie_unwind_pc): Delete.
5363         (moxie_dummy_id): Delete.
5364         (moxie_gdbarch_init): Don't register deleted functions with
5365         gdbarch.
5366
5367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5370         (mn10300_unwind_pc): Delete.
5371         (mn10300_unwind_sp): Delete.
5372         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5373         mn10300_unwind_sp.
5374         (mn10300_frame_unwind_init): Don't register deleted functions with
5375         gdbarch.
5376
5377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5378
5379         * mep-tdep.c (mep_unwind_pc): Delete.
5380         (mep_unwind_sp): Delete.
5381         (mep_dummy_id): Delete.
5382         (mep_gdbarch_init): Don't register deleted functions with
5383         gdbarch.
5384
5385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5386
5387         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5388         (m68hc11_unwind_sp): Delete.
5389         (m68hc11_gdbarch_init): Don't register deleted functions with
5390         gdbarch.
5391
5392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5393
5394         * m32r-tdep.c (m32r_unwind_sp): Delete.
5395         (m32r_unwind_pc): Delete.
5396         (m32r_dummy_id): Delete.
5397         (m32r_gdbarch_init): Don't register deleted functions with
5398         gdbarch.
5399
5400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5401
5402         * m32c-tdep.c (m32c_unwind_pc): Delete.
5403         (m32c_unwind_sp): Delete.
5404         (m32c_dummy_id): Delete.
5405         (m32c_gdbarch_init): Don't register deleted functions with
5406         gdbarch.
5407
5408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5411         (lm32_unwind_pc): Delete.
5412         (lm32_dummy_id): Delete.
5413         (lm32_gdbarch_init): Don't register deleted functions with
5414         gdbarch.
5415
5416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5419         (iq2000_unwind_pc): Delete.
5420         (iq2000_dummy_id): Delete.
5421         (iq2000_gdbarch_init): Don't register deleted functions with
5422         gdbarch.
5423
5424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5425
5426         * nds32-tdep.c (nds32_type_align): Delete.
5427         (nds32_push_dummy_call): Use type_align instead.
5428
5429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5430
5431         * arm-tdep.c (arm_type_align): Only handle vector override case.
5432         (arm_push_dummy_call): Use type_align.
5433         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5434
5435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5436
5437         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5438         case.
5439         (pass_on_stack): Use type_align.
5440         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5441         function.
5442
5443 2019-04-23  Tom Tromey  <tromey@adacore.com>
5444
5445         * dwarf2read.c (line_header::file_name_at): Remove unused
5446         overload.
5447
5448 2019-04-23  Tom de Vries  <tdevries@suse.de>
5449
5450         PR gdb/24438
5451         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5452         invocation.
5453
5454
5455 2019-03-27  Ali Tamur  <tamur@google.com>
5456
5457         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5458         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5459         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5460         (dwarf_expr_context::get_addr_index): Likewise
5461         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5462         (symbol_needs_eval_context::get_addr_index): Likewise
5463         (disassemble_dwarf_expression): Add DW_OP_addrx
5464         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5465         (read_cutu_die_from_dwo): Update comment
5466         (skip_one_die): Add DW_FORM_addrx
5467         (read_attribute_value): Likewise
5468         (var_decode_location): Add DW_OP_addrx
5469         (dwarf2_const_value_attr): Add DW_FORM_addrx
5470         (dump_die_shallow): Likewise
5471         (dwarf2_fetch_constant_bytes): Likewise
5472         (decode_locdesc): Add DW_OP_addrx
5473         (skip_form_bytes): Add DW_FORM_addrx
5474
5475 2019-04-22  Ali Tamur  <tamur@google.com>
5476
5477         * MAINTAINERS (Write After Approval): Add self.
5478
5479 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5480
5481         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5482         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5483         (open_symbol_file_object): Likewise.
5484         (svr4_default_sos): Add info parameter.
5485         (svr4_read_so_list): Likewise.
5486         (svr4_current_sos_direct): Adjust functions calls to pass down
5487         info.
5488         (svr4_current_sos_1): Add info parameter.
5489         (svr4_current_sos): Call get_svr4_info, pass info down to
5490         svr4_current_sos_1.
5491         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5492         get_svr4_info.
5493         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5494         get_svr4_info.
5495         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5496         to get_svr4_info.
5497         (probes_table_remove_objfile_probes): Likewise.
5498         (register_solib_event_probe): Add info parameter.
5499         (solist_update_incremental): Pass info parameter down to
5500         svr4_read_so_list.
5501         (disable_probes_interface): Add info parameter.
5502         (svr4_handle_solib_event): Pass current_program_space to
5503         get_svr4_info.  Adjust disable_probes_interface cleanup.
5504         (svr4_create_probe_breakpoints): Add info parameter, pass it
5505         down to register_solib_event_probe.
5506         (svr4_create_solib_event_breakpoints): Add info parameter,
5507         pass it down to svr4_create_probe_breakpoints.
5508         (enable_break): Pass info down to
5509         svr4_create_solib_event_breakpoints.
5510         (svr4_solib_create_inferior_hook): Pass current_program_space to
5511         get_svr4_info.
5512         (svr4_clear_solib): Likewise.
5513
5514 2019-04-22  Pedro Alves  <palves@redhat.com>
5515
5516         * solib-svr4.c (svr4_free_objfile_observer): New.
5517         (probe_and_action::objfile): New field.
5518         (probes_table_htab_remove_objfile_probes)
5519         (probes_table_remove_objfile_probes): New functions.
5520         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5521         in the new probe_and_action.  Don't store the probe in 'lookup'.
5522         (svr4_create_probe_breakpoints): Pass objfile to
5523         register_solib_event_probe.
5524         (_initialize_svr4_solib): Register a free_objfile observer.
5525
5526 2019-04-19  Tom Tromey  <tom@tromey.com>
5527
5528         * common/queue.h: Remove.
5529
5530 2019-04-19  Tom Tromey  <tom@tromey.com>
5531
5532         * event-loop.c: Don't include "common/queue.h".
5533
5534 2019-04-19  Tom Tromey  <tom@tromey.com>
5535
5536         * remote.c (remote_target): Use delete.
5537         * remote-notif.h: Include <list>, not "common/queue.h".
5538         (notif_client_p): Remove typedef.
5539         (remote_notif_state): Add constructor, destructor, initializer.
5540         <notif_queue>: Now a std::list.
5541         (remote_notif_state_xfree): Don't declare.
5542         * remote-notif.c (remote_notif_process, handle_notification)
5543         (remote_notif_state_allocate): Update.
5544         (~remote_notif_state): Rename from remote_notif_state_xfree.
5545
5546 2019-04-19  Tom Tromey  <tom@tromey.com>
5547
5548         * symfile.c (reread_symbols): Update.
5549         * objfiles.c (objfile_register_static_link)
5550         (objfile_lookup_static_link): Update
5551         (~objfile) Don't delete static_links.
5552         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5553
5554 2019-04-19  Tom Tromey  <tom@tromey.com>
5555
5556         * type-stack.h (struct type_stack) <insert>: Constify string.
5557         * type-stack.c (type_stack::insert): Constify string.
5558         * gdbtypes.h (lookup_template_type): Update.
5559         (address_space_name_to_int): Update.
5560         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5561         const.
5562         (lookup_template_type): Make name const.
5563         * c-exp.y: Update rules.
5564         (lex_one_token, classify_name, classify_inner_name)
5565         (c_print_token): Update.
5566         * p-exp.y: Update rules.
5567         (yylex): Update.
5568         * f-exp.y: Update rules.
5569         (yylex): Update.
5570         * d-exp.y: Update rules.
5571         (lex_one_token, classify_name, classify_inner_name): Update.
5572         * parse.c (write_dollar_variable, copy_name): Return std::string.
5573         * parser-defs.h (copy_name): Change return type.
5574         * m2-exp.y: Update rules.
5575         (yylex): Update.
5576         * go-exp.y (lex_one_token): Update.
5577         Update rules.
5578         (classify_unsafe_function, classify_packaged_name)
5579         (classify_name, yylex): Update.
5580
5581 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5582
5583         * configure.ac: add --enable-source-highlight switch.
5584         * configure: Regenerate.
5585         * top.c (print_gdb_version): plumb --enable-source-highlight
5586         status to "show configuration".
5587
5588 2019-04-19  Tom Tromey  <tromey@adacore.com>
5589
5590         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5591         Check ADA_TYPE_P.
5592         (empty_record, ada_template_to_fixed_record_type_1)
5593         (template_to_static_fixed_type)
5594         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5595         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5596         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5597         macros.
5598
5599 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5600
5601         PR symtab/24423:
5602         * source.c (print_source_lines_base): Advance "iter" when a
5603         control character is seen.
5604
5605 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5606
5607         * inferior.h (struct infcall_suspend_state_deleter):
5608         Catch exception in destructor to avoid crash.
5609
5610 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5611
5612         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5613         close to the add_com "shell".
5614
5615 2019-04-18  Tom Tromey  <tromey@adacore.com>
5616
5617         * process-stratum-target.h (class process_stratum_target)
5618         <stratum>: Add "final".
5619
5620 2019-04-17  Tom Tromey  <tromey@adacore.com>
5621
5622         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5623         against nullptr before use.
5624
5625 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5626
5627         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5628
5629 2019-04-17  Jim Wilson  <jimw@sifive.com>
5630             Andrew Burgess  <andrew.burgess@embecosm.com>
5631
5632         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5633         code read might fail, assume 4-byte breakpoint in that case.
5634
5635 2019-04-15  Leszek Swirski  <leszeks@google.com>
5636
5637         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5638         rather than a hand-rolled POD check when checking for forced MEMORY
5639         classification.
5640
5641 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5642
5643         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5644         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5645         function.
5646         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5647         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5648         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5649         declaration.
5650
5651 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5652
5653         * aarch64-linux-nat.c
5654         (aarch64_linux_nat_target::thread_architecture): Add override.
5655         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5656         each VQ.
5657
5658 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5659
5660         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5661
5662 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5663
5664         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5665         target types of size 96-bits, add some additional comments, and
5666         check that the builtin type we found was the correct size.
5667
5668 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5669
5670         * utils.c (prompt_for_continue): Don't restore the styling at the
5671         end, as applied_style has the wrong value.  This fixes styling in
5672         long lists of file names that are interrupted by the "Continue?"
5673         prompt.
5674
5675 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5678         * c-lang.c (c_language_defn): Likewise.
5679         (cplus_language_defn): Likewise.
5680         (asm_language_defn): Likewise.
5681         (minimal_language_defn): Likewise.
5682         * d-lang.c (d_language_defn): Likewise.
5683         * f-lang.c (f_language_defn): Likewise.
5684         * go-lang.c (go_language_defn): Likewise.
5685         * language.c (unknown_language_defn): Likewise.
5686         (auto_language_defn): Likewise.
5687         * language.h (struct language_defn): Remove la_magic field.
5688         (LANG_MAGIC): Delete.
5689         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5690         * objc-lang.c (objc_language_defn): Likewise.
5691         * opencl-lang.c (opencl_language_defn): Likewise.
5692         * p-lang.c (pascal_language_defn): Likewise.
5693         * rust-lang.c (rust_language_defn): Likewise.
5694
5695 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * riscv-tdep.c (riscv_type_align): New function.
5698         (riscv_type_alignment): Delete.
5699         (riscv_arg_location): Use 'type_align'.
5700         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5701
5702 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5703
5704         * gdbtypes.c (type_align): A struct with no non-static fields also
5705         has alignment of 1.
5706
5707 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5710         component to 0.
5711         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5712         member.
5713         (riscv_struct_info::analyse): New implementation using new
5714         analyse_inner member function.
5715         (riscv_struct_info::field_offset): New member function.
5716         (riscv_struct_info::m_offsets): New member variable.
5717         (riscv_struct_info::analyse_inner): New private member function,
5718         takes the old implementation of riscv_struct_info::analyse but
5719         extended to track field offsets.
5720         (riscv_call_arg_struct): Update the struct folding special cases
5721         to handle cases where empty C++ structs, which are non-zero
5722         length, are found.
5723         (riscv_arg_location): Initialise the length of each location, a
5724         non-zero length now indicates the location is in use.
5725         (riscv_push_dummy_call): Allow for the first location having a
5726         non-zero offset when setting up arguments.
5727         (riscv_return_value): Likewise, but for return values.
5728
5729 2019-04-11  Tom Tromey  <tromey@adacore.com>
5730
5731         * utils.c (internal_vproblem): Make "msg" const.
5732
5733 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5734
5735         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5736         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5737         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5738         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5739
5740 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5741
5742         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5743         function.
5744         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5745         of amd64_collect_native_gregset.
5746         (amd64_linux_nat_target::store_registers): Likewise.
5747
5748 2019-04-10  Tom Tromey  <tom@tromey.com>
5749
5750         * symtab.c (lookup_global_symbol_from_objfile)
5751         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5752         * objfiles.h (class separate_debug_iterator): New.
5753         (class separate_debug_range): New.
5754         (struct objfile) <separate_debug_objfiles>: New method.
5755         (objfile_separate_debug_iterate): Don't declare.
5756         * objfiles.c (separate_debug_iterator::operator++): Rename from
5757         objfile_separate_debug_iterate.
5758         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5759         iterator.
5760         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5761         iterator.
5762
5763 2019-04-10  Tom Tromey  <tom@tromey.com>
5764
5765         * symfile.c (reread_symbols): Remove old comment.
5766         * objfiles.c (free_all_objfiles): Fix a typo.
5767
5768 2019-04-10  Tom Tromey  <tom@tromey.com>
5769
5770         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5771         * minsyms.c (lookup_minimal_symbol): Use foreach.
5772         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5773         (lookup_minimal_symbol_solib_trampoline): Likewise.
5774         * symfile.c (reread_symbols): Use foreach.
5775
5776 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5777             Tom Tromey  <tromey@adacore.com>
5778
5779         PR rust/24414:
5780         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5781         (rust_lex_int_test): Change "value" to be LONGEST.
5782         (rust_lex_tests): Add test for long integer literal.
5783
5784 2019-04-09  Tom Tromey  <tromey@adacore.com>
5785
5786         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5787         to bool.
5788         (extended_remote_target::attach): Update.
5789         (remote_target::remote_notice_new_inferior): Update.
5790         (remote_target::add_current_inferior_and_thread): Update.
5791         * inferior.c (exit_inferior_1): Use "false".
5792         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5793
5794 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5795
5796         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5797         the "start" command.
5798
5799 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5800
5801         * python/py-inferior.c (infpy_thread_from_thread_handle):
5802         Adjust comments to reflect renaming of thread_from_thread_handle
5803         to thread_from_handle.  Adjust keywords.  Fix type error message.
5804         (inferior_object_methods): Add thread_from_handle.  Retain
5805         thread_from_thread_handle, but mark it as deprecated.
5806
5807 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5808
5809         * gdbthread.h (find_thread_by_handle): Revise declaration.
5810         * thread.c (find_thread_by_handle): Likewise.  Adjust
5811         implementation too.
5812         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5813         support for buffer objects as handles.
5814
5815 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5816
5817         * python/py-infthread.c (thpy_thread_handle): New function.
5818         (thread_object_methods): Register thpy_thread_handle.
5819
5820 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5821
5822         * gdbthread.h (thread_to_thread_handle): Declare.
5823         * thread.c (gdbtypes.h): Include.
5824         (thread_to_thread_handle): New function.
5825
5826         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5827         (target_thread_info_to_thread_handle): Declare.
5828         * target.c (target_thread_info_to_thread_handle): New function.
5829         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5830         * target-delegates.c: Regenerate.
5831
5832         * linux-thread-db.c (class thread_db_target): Add method
5833         thread_info_to_thread_handle.
5834         (thread_db_target::thread_info_to_thread_handle): Define.
5835         * remote.c (class remote_target): Add new method
5836         thread_info_to_thread_handle.
5837         (remote_target::thread_info_to_thread_handle): Define.
5838
5839 2019-04-08  Pedro Alves  <palves@redhat.com>
5840
5841         * common/common-exceptions.c (throw_exception): Don't create
5842         named object to throw; throw directly.
5843         (throw_it): Likewise.  Don't initialize gdb_exception::message
5844         here, with new; pass FMT and AP to the ctor instead.
5845         * common/common-exceptions.h: Include <string>.
5846         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5847         const char *, va_list)): New ctor.  Use std::make_shared.
5848         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5849         errors)): Delete.
5850         (gdb_exception_error::gdb_exception_error(enum errors, const char
5851         *, va_list)): New.
5852         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5853         Add assertion.
5854         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5855         errors)): Delete.
5856         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5857         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5858         Add assertion.
5859
5860 2019-04-08  Tom Tromey  <tom@tromey.com>
5861
5862         * valops.c (value_rtti_indirect_type): Replace throw_exception
5863         with throw.
5864         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5865         with throw.
5866         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5867         throw.
5868         * target.c (target_translate_tls_address): Replace throw_exception
5869         with throw.
5870         * stack.c (frame_apply_command_count): Replace throw_exception
5871         with throw.
5872         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5873         throw.
5874         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5875         with throw.
5876         * rs6000-tdep.c (rs6000_frame_cache)
5877         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5878         * remote.c: Replace throw_exception with throw.
5879         * record-full.c (record_full_message, record_full_wait_1)
5880         (record_full_restore): Replace throw_exception with throw.
5881         * record-btrace.c:
5882         (get_thread_current_frame_id, record_btrace_start_replaying)
5883         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5884         (cmd_record_btrace_start): Replace throw_exception with throw.
5885         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5886         throw.
5887         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5888         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5889         * linespec.c:
5890         (find_linespec_symbols): Replace throw_exception with throw.
5891         * infrun.c (displaced_step_prepare, resume): Replace
5892         throw_exception with throw.
5893         * infcmd.c (post_create_inferior): Replace throw_exception with
5894         throw.
5895         * inf-loop.c (inferior_event_handler): Replace throw_exception
5896         with throw.
5897         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5898         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5899         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5900         (get_prev_frame_always, get_frame_pc_if_available)
5901         (get_frame_address_in_block_if_available, get_frame_language):
5902         Replace throw_exception with throw.
5903         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5904         throw_exception with throw.
5905         * eval.c (fetch_subexp_value, evaluate_var_value)
5906         (evaluate_funcall, evaluate_subexp_standard): Replace
5907         throw_exception with throw.
5908         * dwarf2loc.c (call_site_find_chain)
5909         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5910         Replace throw_exception with throw.
5911         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5912         with throw.
5913         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5914         throw.
5915         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5916         * completer.c (complete_line_internal): Replace throw_exception
5917         with throw.
5918         * compile/compile-object-run.c (compile_object_run): Replace
5919         throw_exception with throw.
5920         * cli/cli-script.c (process_next_line): Replace throw_exception
5921         with throw.
5922         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5923         (btrace_enable, btrace_maint_update_pt_packets): Replace
5924         throw_exception with throw.
5925         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5926         throw_exception with throw.
5927         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5928         throw_exception with throw.
5929         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5930         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5931         * aarch64-tdep.c (aarch64_make_prologue_cache)
5932         (aarch64_make_stub_cache): Replace throw_exception with throw.
5933
5934 2019-04-08  Tom Tromey  <tom@tromey.com>
5935
5936         * common/common-exceptions.c (throw_exception): Rename from
5937         throw_exception_cxx.  Remove old copy.  Make argument const.
5938         (throw_it): Create and throw exception objects directly.
5939         * common/common-exceptions.h (throw_exception): Make argument
5940         const.
5941         (struct gdb_exception_error): Add constructor.
5942         (struct gdb_exception_quit): Add constructor.
5943
5944 2019-04-08  Tom Tromey  <tom@tromey.com>
5945
5946         * common/common-exceptions.h (exception_rethrow): Don't declare.
5947         (TRY_SJLJ): Update comment.
5948         (TRY, CATCH, END_CATCH): Remove.
5949         * common/common-exceptions.c (exception_rethrow): Remove.
5950
5951 2019-04-08  Tom Tromey  <tom@tromey.com>
5952
5953         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5954         Remove.
5955         (gdb_exception_error): Rename from
5956         gdb_exception_RETURN_MASK_ERROR.
5957         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5958         (gdb_quit_bad_alloc): Update.
5959         * aarch64-tdep.c: Update.
5960         * ada-lang.c: Update.
5961         * ada-typeprint.c: Update.
5962         * ada-valprint.c: Update.
5963         * amd64-tdep.c: Update.
5964         * arch-utils.c: Update.
5965         * break-catch-throw.c: Update.
5966         * breakpoint.c: Update.
5967         * btrace.c: Update.
5968         * c-varobj.c: Update.
5969         * cli/cli-cmds.c: Update.
5970         * cli/cli-interp.c: Update.
5971         * cli/cli-script.c: Update.
5972         * common/common-exceptions.c: Update.
5973         * common/new-op.c: Update.
5974         * common/selftest.c: Update.
5975         * compile/compile-c-symbols.c: Update.
5976         * compile/compile-cplus-symbols.c: Update.
5977         * compile/compile-object-load.c: Update.
5978         * compile/compile-object-run.c: Update.
5979         * completer.c: Update.
5980         * corelow.c: Update.
5981         * cp-abi.c: Update.
5982         * cp-support.c: Update.
5983         * cp-valprint.c: Update.
5984         * darwin-nat.c: Update.
5985         * disasm-selftests.c: Update.
5986         * dtrace-probe.c: Update.
5987         * dwarf-index-cache.c: Update.
5988         * dwarf-index-write.c: Update.
5989         * dwarf2-frame-tailcall.c: Update.
5990         * dwarf2-frame.c: Update.
5991         * dwarf2loc.c: Update.
5992         * dwarf2read.c: Update.
5993         * eval.c: Update.
5994         * event-loop.c: Update.
5995         * event-top.c: Update.
5996         * exec.c: Update.
5997         * f-valprint.c: Update.
5998         * fbsd-tdep.c: Update.
5999         * frame-unwind.c: Update.
6000         * frame.c: Update.
6001         * gdbtypes.c: Update.
6002         * gnu-v3-abi.c: Update.
6003         * guile/guile-internal.h: Update.
6004         * guile/scm-block.c: Update.
6005         * guile/scm-breakpoint.c: Update.
6006         * guile/scm-cmd.c: Update.
6007         * guile/scm-disasm.c: Update.
6008         * guile/scm-frame.c: Update.
6009         * guile/scm-lazy-string.c: Update.
6010         * guile/scm-math.c: Update.
6011         * guile/scm-param.c: Update.
6012         * guile/scm-ports.c: Update.
6013         * guile/scm-pretty-print.c: Update.
6014         * guile/scm-symbol.c: Update.
6015         * guile/scm-symtab.c: Update.
6016         * guile/scm-type.c: Update.
6017         * guile/scm-value.c: Update.
6018         * i386-linux-tdep.c: Update.
6019         * i386-tdep.c: Update.
6020         * inf-loop.c: Update.
6021         * infcall.c: Update.
6022         * infcmd.c: Update.
6023         * infrun.c: Update.
6024         * jit.c: Update.
6025         * language.c: Update.
6026         * linespec.c: Update.
6027         * linux-fork.c: Update.
6028         * linux-nat.c: Update.
6029         * linux-tdep.c: Update.
6030         * linux-thread-db.c: Update.
6031         * main.c: Update.
6032         * mi/mi-cmd-break.c: Update.
6033         * mi/mi-cmd-stack.c: Update.
6034         * mi/mi-interp.c: Update.
6035         * mi/mi-main.c: Update.
6036         * objc-lang.c: Update.
6037         * p-valprint.c: Update.
6038         * parse.c: Update.
6039         * ppc-linux-tdep.c: Update.
6040         * printcmd.c: Update.
6041         * python/py-arch.c: Update.
6042         * python/py-breakpoint.c: Update.
6043         * python/py-cmd.c: Update.
6044         * python/py-finishbreakpoint.c: Update.
6045         * python/py-frame.c: Update.
6046         * python/py-framefilter.c: Update.
6047         * python/py-gdb-readline.c: Update.
6048         * python/py-inferior.c: Update.
6049         * python/py-infthread.c: Update.
6050         * python/py-lazy-string.c: Update.
6051         * python/py-linetable.c: Update.
6052         * python/py-objfile.c: Update.
6053         * python/py-param.c: Update.
6054         * python/py-prettyprint.c: Update.
6055         * python/py-progspace.c: Update.
6056         * python/py-record-btrace.c: Update.
6057         * python/py-record.c: Update.
6058         * python/py-symbol.c: Update.
6059         * python/py-type.c: Update.
6060         * python/py-unwind.c: Update.
6061         * python/py-utils.c: Update.
6062         * python/py-value.c: Update.
6063         * python/python.c: Update.
6064         * record-btrace.c: Update.
6065         * record-full.c: Update.
6066         * remote-fileio.c: Update.
6067         * remote.c: Update.
6068         * riscv-tdep.c: Update.
6069         * rs6000-aix-tdep.c: Update.
6070         * rs6000-tdep.c: Update.
6071         * rust-exp.y: Update.
6072         * rust-lang.c: Update.
6073         * s390-tdep.c: Update.
6074         * selftest-arch.c: Update.
6075         * solib-dsbt.c: Update.
6076         * solib-frv.c: Update.
6077         * solib-spu.c: Update.
6078         * solib-svr4.c: Update.
6079         * solib.c: Update.
6080         * sparc64-linux-tdep.c: Update.
6081         * stack.c: Update.
6082         * symfile-mem.c: Update.
6083         * symmisc.c: Update.
6084         * target.c: Update.
6085         * thread.c: Update.
6086         * top.c: Update.
6087         * tracefile-tfile.c: Update.
6088         * tui/tui.c: Update.
6089         * typeprint.c: Update.
6090         * unittests/cli-utils-selftests.c: Update.
6091         * unittests/parse-connection-spec-selftests.c: Update.
6092         * valops.c: Update.
6093         * valprint.c: Update.
6094         * value.c: Update.
6095         * varobj.c: Update.
6096         * windows-nat.c: Update.
6097         * x86-linux-nat.c: Update.
6098         * xml-support.c: Update.
6099
6100 2019-04-08  Tom Tromey  <tom@tromey.com>
6101
6102         * xml-support.c: Use C++ exception handling.
6103         * x86-linux-nat.c: Use C++ exception handling.
6104         * windows-nat.c: Use C++ exception handling.
6105         * varobj.c: Use C++ exception handling.
6106         * value.c: Use C++ exception handling.
6107         * valprint.c: Use C++ exception handling.
6108         * valops.c: Use C++ exception handling.
6109         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6110         handling.
6111         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6112         * typeprint.c: Use C++ exception handling.
6113         * tui/tui.c: Use C++ exception handling.
6114         * tracefile-tfile.c: Use C++ exception handling.
6115         * top.c: Use C++ exception handling.
6116         * thread.c: Use C++ exception handling.
6117         * target.c: Use C++ exception handling.
6118         * symmisc.c: Use C++ exception handling.
6119         * symfile-mem.c: Use C++ exception handling.
6120         * stack.c: Use C++ exception handling.
6121         * sparc64-linux-tdep.c: Use C++ exception handling.
6122         * solib.c: Use C++ exception handling.
6123         * solib-svr4.c: Use C++ exception handling.
6124         * solib-spu.c: Use C++ exception handling.
6125         * solib-frv.c: Use C++ exception handling.
6126         * solib-dsbt.c: Use C++ exception handling.
6127         * selftest-arch.c: Use C++ exception handling.
6128         * s390-tdep.c: Use C++ exception handling.
6129         * rust-lang.c: Use C++ exception handling.
6130         * rust-exp.y: Use C++ exception handling.
6131         * rs6000-tdep.c: Use C++ exception handling.
6132         * rs6000-aix-tdep.c: Use C++ exception handling.
6133         * riscv-tdep.c: Use C++ exception handling.
6134         * remote.c: Use C++ exception handling.
6135         * remote-fileio.c: Use C++ exception handling.
6136         * record-full.c: Use C++ exception handling.
6137         * record-btrace.c: Use C++ exception handling.
6138         * python/python.c: Use C++ exception handling.
6139         * python/py-value.c: Use C++ exception handling.
6140         * python/py-utils.c: Use C++ exception handling.
6141         * python/py-unwind.c: Use C++ exception handling.
6142         * python/py-type.c: Use C++ exception handling.
6143         * python/py-symbol.c: Use C++ exception handling.
6144         * python/py-record.c: Use C++ exception handling.
6145         * python/py-record-btrace.c: Use C++ exception handling.
6146         * python/py-progspace.c: Use C++ exception handling.
6147         * python/py-prettyprint.c: Use C++ exception handling.
6148         * python/py-param.c: Use C++ exception handling.
6149         * python/py-objfile.c: Use C++ exception handling.
6150         * python/py-linetable.c: Use C++ exception handling.
6151         * python/py-lazy-string.c: Use C++ exception handling.
6152         * python/py-infthread.c: Use C++ exception handling.
6153         * python/py-inferior.c: Use C++ exception handling.
6154         * python/py-gdb-readline.c: Use C++ exception handling.
6155         * python/py-framefilter.c: Use C++ exception handling.
6156         * python/py-frame.c: Use C++ exception handling.
6157         * python/py-finishbreakpoint.c: Use C++ exception handling.
6158         * python/py-cmd.c: Use C++ exception handling.
6159         * python/py-breakpoint.c: Use C++ exception handling.
6160         * python/py-arch.c: Use C++ exception handling.
6161         * printcmd.c: Use C++ exception handling.
6162         * ppc-linux-tdep.c: Use C++ exception handling.
6163         * parse.c: Use C++ exception handling.
6164         * p-valprint.c: Use C++ exception handling.
6165         * objc-lang.c: Use C++ exception handling.
6166         * mi/mi-main.c: Use C++ exception handling.
6167         * mi/mi-interp.c: Use C++ exception handling.
6168         * mi/mi-cmd-stack.c: Use C++ exception handling.
6169         * mi/mi-cmd-break.c: Use C++ exception handling.
6170         * main.c: Use C++ exception handling.
6171         * linux-thread-db.c: Use C++ exception handling.
6172         * linux-tdep.c: Use C++ exception handling.
6173         * linux-nat.c: Use C++ exception handling.
6174         * linux-fork.c: Use C++ exception handling.
6175         * linespec.c: Use C++ exception handling.
6176         * language.c: Use C++ exception handling.
6177         * jit.c: Use C++ exception handling.
6178         * infrun.c: Use C++ exception handling.
6179         * infcmd.c: Use C++ exception handling.
6180         * infcall.c: Use C++ exception handling.
6181         * inf-loop.c: Use C++ exception handling.
6182         * i386-tdep.c: Use C++ exception handling.
6183         * i386-linux-tdep.c: Use C++ exception handling.
6184         * guile/scm-value.c: Use C++ exception handling.
6185         * guile/scm-type.c: Use C++ exception handling.
6186         * guile/scm-symtab.c: Use C++ exception handling.
6187         * guile/scm-symbol.c: Use C++ exception handling.
6188         * guile/scm-pretty-print.c: Use C++ exception handling.
6189         * guile/scm-ports.c: Use C++ exception handling.
6190         * guile/scm-param.c: Use C++ exception handling.
6191         * guile/scm-math.c: Use C++ exception handling.
6192         * guile/scm-lazy-string.c: Use C++ exception handling.
6193         * guile/scm-frame.c: Use C++ exception handling.
6194         * guile/scm-disasm.c: Use C++ exception handling.
6195         * guile/scm-cmd.c: Use C++ exception handling.
6196         * guile/scm-breakpoint.c: Use C++ exception handling.
6197         * guile/scm-block.c: Use C++ exception handling.
6198         * guile/guile-internal.h: Use C++ exception handling.
6199         * gnu-v3-abi.c: Use C++ exception handling.
6200         * gdbtypes.c: Use C++ exception handling.
6201         * frame.c: Use C++ exception handling.
6202         * frame-unwind.c: Use C++ exception handling.
6203         * fbsd-tdep.c: Use C++ exception handling.
6204         * f-valprint.c: Use C++ exception handling.
6205         * exec.c: Use C++ exception handling.
6206         * event-top.c: Use C++ exception handling.
6207         * event-loop.c: Use C++ exception handling.
6208         * eval.c: Use C++ exception handling.
6209         * dwarf2read.c: Use C++ exception handling.
6210         * dwarf2loc.c: Use C++ exception handling.
6211         * dwarf2-frame.c: Use C++ exception handling.
6212         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6213         * dwarf-index-write.c: Use C++ exception handling.
6214         * dwarf-index-cache.c: Use C++ exception handling.
6215         * dtrace-probe.c: Use C++ exception handling.
6216         * disasm-selftests.c: Use C++ exception handling.
6217         * darwin-nat.c: Use C++ exception handling.
6218         * cp-valprint.c: Use C++ exception handling.
6219         * cp-support.c: Use C++ exception handling.
6220         * cp-abi.c: Use C++ exception handling.
6221         * corelow.c: Use C++ exception handling.
6222         * completer.c: Use C++ exception handling.
6223         * compile/compile-object-run.c: Use C++ exception handling.
6224         * compile/compile-object-load.c: Use C++ exception handling.
6225         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6226         * compile/compile-c-symbols.c: Use C++ exception handling.
6227         * common/selftest.c: Use C++ exception handling.
6228         * common/new-op.c: Use C++ exception handling.
6229         * cli/cli-script.c: Use C++ exception handling.
6230         * cli/cli-interp.c: Use C++ exception handling.
6231         * cli/cli-cmds.c: Use C++ exception handling.
6232         * c-varobj.c: Use C++ exception handling.
6233         * btrace.c: Use C++ exception handling.
6234         * breakpoint.c: Use C++ exception handling.
6235         * break-catch-throw.c: Use C++ exception handling.
6236         * arch-utils.c: Use C++ exception handling.
6237         * amd64-tdep.c: Use C++ exception handling.
6238         * ada-valprint.c: Use C++ exception handling.
6239         * ada-typeprint.c: Use C++ exception handling.
6240         * ada-lang.c: Use C++ exception handling.
6241         * aarch64-tdep.c: Use C++ exception handling.
6242
6243 2019-04-08  Tom Tromey  <tom@tromey.com>
6244
6245         * xml-support.c (gdb_xml_parser::parse): Update.
6246         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6247         * value.c (show_convenience): Update.
6248         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6249         (test_parse_flags_qcs): Update.
6250         * thread.c (thr_try_catch_cmd): Update.
6251         * target.c (target_translate_tls_address): Update.
6252         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6253         (info_frame_command_core, frame_apply_command_count): Update.
6254         * rust-exp.y (rust_lex_exception_test): Update.
6255         * riscv-tdep.c (riscv_print_one_register_info): Update.
6256         * remote.c (remote_target::enable_btrace): Update.
6257         * record-btrace.c (record_btrace_enable_warn): Update.
6258         * python/py-utils.c (gdbpy_convert_exception): Update.
6259         * printcmd.c (do_one_display, print_variable_and_value): Update.
6260         * mi/mi-main.c (mi_print_exception): Update.
6261         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6262         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6263         * linux-nat.c (linux_nat_target::attach): Update.
6264         * linux-fork.c (class scoped_switch_fork_info): Update.
6265         * infrun.c (displaced_step_prepare): Update.
6266         * infcall.c (call_function_by_hand_dummy): Update.
6267         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6268         * gnu-v3-abi.c (print_one_vtable): Update.
6269         * frame.c (get_prev_frame_always): Update.
6270         * f-valprint.c (info_common_command_for_block): Update.
6271         * exec.c (try_open_exec_file): Update.
6272         * exceptions.c (print_exception, exception_print)
6273         (exception_fprintf, exception_print_same): Update.
6274         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6275         * dwarf-index-cache.c (index_cache::store)
6276         (index_cache::lookup_gdb_index): Update.
6277         * darwin-nat.c (maybe_cache_shell): Update.
6278         * cp-valprint.c (cp_print_value_fields): Update.
6279         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6280         (gcc_cplus_symbol_address): Update.
6281         * compile/compile-c-symbols.c (gcc_convert_symbol)
6282         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6283         * common/selftest.c: Update.
6284         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6285         a std::string.
6286         (exception_try_scope_entry, exception_try_scope_exit): Don't
6287         declare.
6288         (struct exception_try_scope): Remove.
6289         (TRY): Don't use exception_try_scope.
6290         (struct gdb_exception): Add constructor, operator=.
6291         <what>: New method.
6292         (struct gdb_exception_RETURN_MASK_ALL)
6293         (struct gdb_exception_RETURN_MASK_ERROR)
6294         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6295         (struct gdb_quit_bad_alloc): Update.
6296         * common/common-exceptions.c (exception_none): Change
6297         initializer.
6298         (struct catcher) <state, exception>: Initialize inline.
6299         <prev>: Remove member.
6300         (current_catcher): Remove.
6301         (catchers): New global.
6302         (exceptions_state_mc_init): Simplify.
6303         (catcher_pop): Remove.
6304         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6305         (try_scope_depth, exception_try_scope_entry)
6306         (exception_try_scope_exit): Remove.
6307         (throw_exception_sjlj): Update.
6308         (exception_messages, exception_messages_size): Remove.
6309         (throw_it): Simplify.
6310         (gdb_exception_sliced_copy): Remove.
6311         (throw_exception_cxx): Update.
6312         * cli/cli-script.c (script_from_file): Update.
6313         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6314         Update.
6315         * ada-valprint.c (ada_val_print): Update.
6316         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6317         (create_excep_cond_exprs): Update.
6318
6319 2019-04-08  Tom Tromey  <tom@tromey.com>
6320
6321         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6322         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6323         (TRY, CATCH, END_CATCH): Remove some definitions.
6324         * common/common-exceptions.c: Don't use GDB_XCPT.
6325         (catcher_list_size): Remove.
6326         (throw_exception, throw_it): Simplify.
6327
6328 2019-04-05  Tom Tromey  <tom@tromey.com>
6329
6330         Revert the header-sorting patch.
6331         * ft32-tdep.c: Revert.
6332         * frv-tdep.c: Revert.
6333         * frv-linux-tdep.c: Revert.
6334         * frame.c: Revert.
6335         * frame-unwind.c: Revert.
6336         * frame-base.c: Revert.
6337         * fork-child.c: Revert.
6338         * findvar.c: Revert.
6339         * findcmd.c: Revert.
6340         * filesystem.c: Revert.
6341         * filename-seen-cache.h: Revert.
6342         * filename-seen-cache.c: Revert.
6343         * fbsd-tdep.c: Revert.
6344         * fbsd-nat.h: Revert.
6345         * fbsd-nat.c: Revert.
6346         * f-valprint.c: Revert.
6347         * f-typeprint.c: Revert.
6348         * f-lang.c: Revert.
6349         * extension.h: Revert.
6350         * extension.c: Revert.
6351         * extension-priv.h: Revert.
6352         * expprint.c: Revert.
6353         * exec.h: Revert.
6354         * exec.c: Revert.
6355         * exceptions.c: Revert.
6356         * event-top.c: Revert.
6357         * event-loop.c: Revert.
6358         * eval.c: Revert.
6359         * elfread.c: Revert.
6360         * dwarf2read.h: Revert.
6361         * dwarf2read.c: Revert.
6362         * dwarf2loc.c: Revert.
6363         * dwarf2expr.h: Revert.
6364         * dwarf2expr.c: Revert.
6365         * dwarf2-frame.c: Revert.
6366         * dwarf2-frame-tailcall.c: Revert.
6367         * dwarf-index-write.h: Revert.
6368         * dwarf-index-write.c: Revert.
6369         * dwarf-index-common.c: Revert.
6370         * dwarf-index-cache.h: Revert.
6371         * dwarf-index-cache.c: Revert.
6372         * dummy-frame.c: Revert.
6373         * dtrace-probe.c: Revert.
6374         * disasm.h: Revert.
6375         * disasm.c: Revert.
6376         * disasm-selftests.c: Revert.
6377         * dictionary.c: Revert.
6378         * dicos-tdep.c: Revert.
6379         * demangle.c: Revert.
6380         * dcache.h: Revert.
6381         * dcache.c: Revert.
6382         * darwin-nat.h: Revert.
6383         * darwin-nat.c: Revert.
6384         * darwin-nat-info.c: Revert.
6385         * d-valprint.c: Revert.
6386         * d-namespace.c: Revert.
6387         * d-lang.c: Revert.
6388         * ctf.c: Revert.
6389         * csky-tdep.c: Revert.
6390         * csky-linux-tdep.c: Revert.
6391         * cris-tdep.c: Revert.
6392         * cris-linux-tdep.c: Revert.
6393         * cp-valprint.c: Revert.
6394         * cp-support.c: Revert.
6395         * cp-namespace.c: Revert.
6396         * cp-abi.c: Revert.
6397         * corelow.c: Revert.
6398         * corefile.c: Revert.
6399         * continuations.c: Revert.
6400         * completer.h: Revert.
6401         * completer.c: Revert.
6402         * complaints.c: Revert.
6403         * coffread.c: Revert.
6404         * coff-pe-read.c: Revert.
6405         * cli-out.h: Revert.
6406         * cli-out.c: Revert.
6407         * charset.c: Revert.
6408         * c-varobj.c: Revert.
6409         * c-valprint.c: Revert.
6410         * c-typeprint.c: Revert.
6411         * c-lang.c: Revert.
6412         * buildsym.c: Revert.
6413         * buildsym-legacy.c: Revert.
6414         * build-id.h: Revert.
6415         * build-id.c: Revert.
6416         * btrace.c: Revert.
6417         * bsd-uthread.c: Revert.
6418         * breakpoint.h: Revert.
6419         * breakpoint.c: Revert.
6420         * break-catch-throw.c: Revert.
6421         * break-catch-syscall.c: Revert.
6422         * break-catch-sig.c: Revert.
6423         * blockframe.c: Revert.
6424         * block.c: Revert.
6425         * bfin-tdep.c: Revert.
6426         * bfin-linux-tdep.c: Revert.
6427         * bfd-target.c: Revert.
6428         * bcache.c: Revert.
6429         * ax-general.c: Revert.
6430         * ax-gdb.h: Revert.
6431         * ax-gdb.c: Revert.
6432         * avr-tdep.c: Revert.
6433         * auxv.c: Revert.
6434         * auto-load.c: Revert.
6435         * arm-wince-tdep.c: Revert.
6436         * arm-tdep.c: Revert.
6437         * arm-symbian-tdep.c: Revert.
6438         * arm-pikeos-tdep.c: Revert.
6439         * arm-obsd-tdep.c: Revert.
6440         * arm-nbsd-tdep.c: Revert.
6441         * arm-nbsd-nat.c: Revert.
6442         * arm-linux-tdep.c: Revert.
6443         * arm-linux-nat.c: Revert.
6444         * arm-fbsd-tdep.c: Revert.
6445         * arm-fbsd-nat.c: Revert.
6446         * arm-bsd-tdep.c: Revert.
6447         * arch-utils.c: Revert.
6448         * arc-tdep.c: Revert.
6449         * arc-newlib-tdep.c: Revert.
6450         * annotate.h: Revert.
6451         * annotate.c: Revert.
6452         * amd64-windows-tdep.c: Revert.
6453         * amd64-windows-nat.c: Revert.
6454         * amd64-tdep.c: Revert.
6455         * amd64-sol2-tdep.c: Revert.
6456         * amd64-obsd-tdep.c: Revert.
6457         * amd64-obsd-nat.c: Revert.
6458         * amd64-nbsd-tdep.c: Revert.
6459         * amd64-nbsd-nat.c: Revert.
6460         * amd64-nat.c: Revert.
6461         * amd64-linux-tdep.c: Revert.
6462         * amd64-linux-nat.c: Revert.
6463         * amd64-fbsd-tdep.c: Revert.
6464         * amd64-fbsd-nat.c: Revert.
6465         * amd64-dicos-tdep.c: Revert.
6466         * amd64-darwin-tdep.c: Revert.
6467         * amd64-bsd-nat.c: Revert.
6468         * alpha-tdep.c: Revert.
6469         * alpha-obsd-tdep.c: Revert.
6470         * alpha-nbsd-tdep.c: Revert.
6471         * alpha-mdebug-tdep.c: Revert.
6472         * alpha-linux-tdep.c: Revert.
6473         * alpha-linux-nat.c: Revert.
6474         * alpha-bsd-tdep.c: Revert.
6475         * alpha-bsd-nat.c: Revert.
6476         * aix-thread.c: Revert.
6477         * agent.c: Revert.
6478         * addrmap.c: Revert.
6479         * ada-varobj.c: Revert.
6480         * ada-valprint.c: Revert.
6481         * ada-typeprint.c: Revert.
6482         * ada-tasks.c: Revert.
6483         * ada-lang.c: Revert.
6484         * aarch64-tdep.c: Revert.
6485         * aarch64-ravenscar-thread.c: Revert.
6486         * aarch64-newlib-tdep.c: Revert.
6487         * aarch64-linux-tdep.c: Revert.
6488         * aarch64-linux-nat.c: Revert.
6489         * aarch64-fbsd-tdep.c: Revert.
6490         * aarch64-fbsd-nat.c: Revert.
6491         * aarch32-linux-nat.c: Revert.
6492
6493 2019-04-05  Tom Tromey  <tom@tromey.com>
6494
6495         * ft32-tdep.c: Sort headers.
6496         * frv-tdep.c: Sort headers.
6497         * frv-linux-tdep.c: Sort headers.
6498         * frame.c: Sort headers.
6499         * frame-unwind.c: Sort headers.
6500         * frame-base.c: Sort headers.
6501         * fork-child.c: Sort headers.
6502         * findvar.c: Sort headers.
6503         * findcmd.c: Sort headers.
6504         * filesystem.c: Sort headers.
6505         * filename-seen-cache.h: Sort headers.
6506         * filename-seen-cache.c: Sort headers.
6507         * fbsd-tdep.c: Sort headers.
6508         * fbsd-nat.h: Sort headers.
6509         * fbsd-nat.c: Sort headers.
6510         * f-valprint.c: Sort headers.
6511         * f-typeprint.c: Sort headers.
6512         * f-lang.c: Sort headers.
6513         * extension.h: Sort headers.
6514         * extension.c: Sort headers.
6515         * extension-priv.h: Sort headers.
6516         * expprint.c: Sort headers.
6517         * exec.h: Sort headers.
6518         * exec.c: Sort headers.
6519         * exceptions.c: Sort headers.
6520         * event-top.c: Sort headers.
6521         * event-loop.c: Sort headers.
6522         * eval.c: Sort headers.
6523         * elfread.c: Sort headers.
6524         * dwarf2read.h: Sort headers.
6525         * dwarf2read.c: Sort headers.
6526         * dwarf2loc.c: Sort headers.
6527         * dwarf2expr.h: Sort headers.
6528         * dwarf2expr.c: Sort headers.
6529         * dwarf2-frame.c: Sort headers.
6530         * dwarf2-frame-tailcall.c: Sort headers.
6531         * dwarf-index-write.h: Sort headers.
6532         * dwarf-index-write.c: Sort headers.
6533         * dwarf-index-common.c: Sort headers.
6534         * dwarf-index-cache.h: Sort headers.
6535         * dwarf-index-cache.c: Sort headers.
6536         * dummy-frame.c: Sort headers.
6537         * dtrace-probe.c: Sort headers.
6538         * disasm.h: Sort headers.
6539         * disasm.c: Sort headers.
6540         * disasm-selftests.c: Sort headers.
6541         * dictionary.c: Sort headers.
6542         * dicos-tdep.c: Sort headers.
6543         * demangle.c: Sort headers.
6544         * dcache.h: Sort headers.
6545         * dcache.c: Sort headers.
6546         * darwin-nat.h: Sort headers.
6547         * darwin-nat.c: Sort headers.
6548         * darwin-nat-info.c: Sort headers.
6549         * d-valprint.c: Sort headers.
6550         * d-namespace.c: Sort headers.
6551         * d-lang.c: Sort headers.
6552         * ctf.c: Sort headers.
6553         * csky-tdep.c: Sort headers.
6554         * csky-linux-tdep.c: Sort headers.
6555         * cris-tdep.c: Sort headers.
6556         * cris-linux-tdep.c: Sort headers.
6557         * cp-valprint.c: Sort headers.
6558         * cp-support.c: Sort headers.
6559         * cp-namespace.c: Sort headers.
6560         * cp-abi.c: Sort headers.
6561         * corelow.c: Sort headers.
6562         * corefile.c: Sort headers.
6563         * continuations.c: Sort headers.
6564         * completer.h: Sort headers.
6565         * completer.c: Sort headers.
6566         * complaints.c: Sort headers.
6567         * coffread.c: Sort headers.
6568         * coff-pe-read.c: Sort headers.
6569         * cli-out.h: Sort headers.
6570         * cli-out.c: Sort headers.
6571         * charset.c: Sort headers.
6572         * c-varobj.c: Sort headers.
6573         * c-valprint.c: Sort headers.
6574         * c-typeprint.c: Sort headers.
6575         * c-lang.c: Sort headers.
6576         * buildsym.c: Sort headers.
6577         * buildsym-legacy.c: Sort headers.
6578         * build-id.h: Sort headers.
6579         * build-id.c: Sort headers.
6580         * btrace.c: Sort headers.
6581         * bsd-uthread.c: Sort headers.
6582         * breakpoint.h: Sort headers.
6583         * breakpoint.c: Sort headers.
6584         * break-catch-throw.c: Sort headers.
6585         * break-catch-syscall.c: Sort headers.
6586         * break-catch-sig.c: Sort headers.
6587         * blockframe.c: Sort headers.
6588         * block.c: Sort headers.
6589         * bfin-tdep.c: Sort headers.
6590         * bfin-linux-tdep.c: Sort headers.
6591         * bfd-target.c: Sort headers.
6592         * bcache.c: Sort headers.
6593         * ax-general.c: Sort headers.
6594         * ax-gdb.h: Sort headers.
6595         * ax-gdb.c: Sort headers.
6596         * avr-tdep.c: Sort headers.
6597         * auxv.c: Sort headers.
6598         * auto-load.c: Sort headers.
6599         * arm-wince-tdep.c: Sort headers.
6600         * arm-tdep.c: Sort headers.
6601         * arm-symbian-tdep.c: Sort headers.
6602         * arm-pikeos-tdep.c: Sort headers.
6603         * arm-obsd-tdep.c: Sort headers.
6604         * arm-nbsd-tdep.c: Sort headers.
6605         * arm-nbsd-nat.c: Sort headers.
6606         * arm-linux-tdep.c: Sort headers.
6607         * arm-linux-nat.c: Sort headers.
6608         * arm-fbsd-tdep.c: Sort headers.
6609         * arm-fbsd-nat.c: Sort headers.
6610         * arm-bsd-tdep.c: Sort headers.
6611         * arch-utils.c: Sort headers.
6612         * arc-tdep.c: Sort headers.
6613         * arc-newlib-tdep.c: Sort headers.
6614         * annotate.h: Sort headers.
6615         * annotate.c: Sort headers.
6616         * amd64-windows-tdep.c: Sort headers.
6617         * amd64-windows-nat.c: Sort headers.
6618         * amd64-tdep.c: Sort headers.
6619         * amd64-sol2-tdep.c: Sort headers.
6620         * amd64-obsd-tdep.c: Sort headers.
6621         * amd64-obsd-nat.c: Sort headers.
6622         * amd64-nbsd-tdep.c: Sort headers.
6623         * amd64-nbsd-nat.c: Sort headers.
6624         * amd64-nat.c: Sort headers.
6625         * amd64-linux-tdep.c: Sort headers.
6626         * amd64-linux-nat.c: Sort headers.
6627         * amd64-fbsd-tdep.c: Sort headers.
6628         * amd64-fbsd-nat.c: Sort headers.
6629         * amd64-dicos-tdep.c: Sort headers.
6630         * amd64-darwin-tdep.c: Sort headers.
6631         * amd64-bsd-nat.c: Sort headers.
6632         * alpha-tdep.c: Sort headers.
6633         * alpha-obsd-tdep.c: Sort headers.
6634         * alpha-nbsd-tdep.c: Sort headers.
6635         * alpha-mdebug-tdep.c: Sort headers.
6636         * alpha-linux-tdep.c: Sort headers.
6637         * alpha-linux-nat.c: Sort headers.
6638         * alpha-bsd-tdep.c: Sort headers.
6639         * alpha-bsd-nat.c: Sort headers.
6640         * aix-thread.c: Sort headers.
6641         * agent.c: Sort headers.
6642         * addrmap.c: Sort headers.
6643         * ada-varobj.c: Sort headers.
6644         * ada-valprint.c: Sort headers.
6645         * ada-typeprint.c: Sort headers.
6646         * ada-tasks.c: Sort headers.
6647         * ada-lang.c: Sort headers.
6648         * aarch64-tdep.c: Sort headers.
6649         * aarch64-ravenscar-thread.c: Sort headers.
6650         * aarch64-newlib-tdep.c: Sort headers.
6651         * aarch64-linux-tdep.c: Sort headers.
6652         * aarch64-linux-nat.c: Sort headers.
6653         * aarch64-fbsd-tdep.c: Sort headers.
6654         * aarch64-fbsd-nat.c: Sort headers.
6655         * aarch32-linux-nat.c: Sort headers.
6656
6657 2019-04-04  Tom Tromey  <tom@tromey.com>
6658
6659         * varobj.c (varobj_create): Update.
6660         * rust-exp.y (struct rust_parser) <update_innermost_block,
6661         lookup_symbol>: New methods.
6662         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6663         Rename.
6664         (rust_parser::rust_lookup_type)
6665         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6666         * printcmd.c (display_command, do_one_display): Update.
6667         * parser-defs.h (struct parser_state) <parser_state>: Add
6668         "tracker" parameter.
6669         (block_tracker): New member.
6670         (class innermost_block_tracker) <innermost_block_tracker>: Add
6671         "types" parameter.
6672         <reset>: Remove method.
6673         (innermost_block): Don't declare.
6674         (null_post_parser): Update.
6675         * parse.c (innermost_block): Remove global.
6676         (write_dollar_variable): Update.
6677         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6678         Remove "tracker_types" parameter.
6679         (parse_expression): Add "tracker" parameter.
6680         (parse_expression_for_completion): Update.
6681         (null_post_parser): Add "tracker" parameter.
6682         * p-exp.y: Update rules.
6683         * m2-exp.y: Update rules.
6684         * language.h (struct language_defn) <la_post_parser>: Add
6685         "tracker" parameter.
6686         * go-exp.y: Update rules.
6687         * f-exp.y: Update rules.
6688         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6689         parameter.
6690         * d-exp.y: Update rules.
6691         * c-exp.y: Update rules.
6692         * breakpoint.c (set_breakpoint_condition): Create an
6693         innermost_block_tracker.
6694         (watch_command_1): Likewise.
6695         * ada-lang.c (resolve): Add "tracker" parameter.
6696         (resolve_subexp): Likewise.
6697         * ada-exp.y (write_var_from_sym): Update.
6698
6699 2019-04-04  Tom Tromey  <tom@tromey.com>
6700
6701         * type-stack.h: New file.
6702         * type-stack.c: New file.
6703         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6704         type-stack.h.
6705         (insert_into_type_stack, insert_type, push_type, push_type_int)
6706         (insert_type_address_space, pop_type, pop_type_int)
6707         (pop_typelist, pop_type_stack, append_type_stack)
6708         (push_type_stack, get_type_stack, push_typelist)
6709         (follow_type_instance_flags, follow_types): Don't declare.
6710         * parse.c (type_stack): Remove global.
6711         (parse_exp_in_context): Update.
6712         (insert_into_type_stack, insert_type, push_type, push_type_int)
6713         (insert_type_address_space, pop_type, pop_type_int)
6714         (pop_typelist, pop_type_stack, append_type_stack)
6715         (push_type_stack, get_type_stack, push_typelist)
6716         (follow_type_instance_flags, follow_types): Remove (moved to
6717         type-stack.c).
6718         * f-exp.y (type_stack): New global.
6719         Update rules.
6720         (push_kind_type, f_parse): Update.
6721         * d-exp.y (type_stack): New global.
6722         Update rules.
6723         (d_parse): Update.
6724         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6725         Update rules.
6726         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6727         (HFILES_NO_SRCDIR): Add type-stack.h.
6728
6729 2019-04-04  Tom Tromey  <tom@tromey.com>
6730
6731         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6732         (rust_parser::convert_ast_to_expression, rust_parse)
6733         (rust_lex_test_completion, rust_lex_tests): Update.
6734         * parser-defs.h (struct expr_completion_state): New.
6735         (struct parser_state) <parser_state>: Add completion parameter.
6736         <mark_struct_expression, mark_completion_tag>: New methods.
6737         <parse_completion, m_completion_state>: New members.
6738         (prefixify_expression, null_post_parser): Update.
6739         (mark_struct_expression, mark_completion_tag): Don't declare.
6740         * parse.c (parse_completion, expout_last_struct)
6741         (expout_tag_completion_type, expout_completion_name): Remove
6742         globals.
6743         (parser_state::mark_struct_expression)
6744         (parser_state::mark_completion_tag): Now methods.
6745         (prefixify_expression): Add last_struct parameter.
6746         (prefixify_subexp): Likewise.
6747         (parse_exp_1): Update.
6748         (parse_exp_in_context): Add cstate parameter.  Update.
6749         (parse_expression_for_completion): Create an
6750         expr_completion_state.
6751         (null_post_parser): Add "completion" parameter.
6752         * p-exp.y: Update rules.
6753         (yylex): Update.
6754         * language.h (struct language_defn) <la_post_parser>: Add
6755         "completing" parameter.
6756         * go-exp.y: Update rules.
6757         (lex_one_token): Update.
6758         * expression.h (parse_completion): Don't declare.
6759         * d-exp.y: Update rules.
6760         (lex_one_token): Update rules.
6761         * c-exp.y: Update rules.
6762         (lex_one_token): Update.
6763         * ada-lang.c (resolve): Add "parse_completion" parameter.
6764         (resolve_subexp): Likewise.
6765         (ada_resolve_function): Likewise.
6766
6767 2019-04-04  Tom Tromey  <tom@tromey.com>
6768
6769         * parser-defs.h (struct parser_state) <start_arglist,
6770         end_arglist>: New methods.
6771         <arglist_len, m_funcall_chain>: New members.
6772         (arglist_len, start_arglist, end_arglist): Don't declare.
6773         * parse.c (arglist_len, funcall_chain): Remove global.
6774         (start_arglist, end_arglist): Remove functions.
6775         (parse_exp_in_context): Update.
6776         * p-exp.y: Update rules.
6777         * m2-exp.y: Update rules.
6778         * go-exp.y: Update rules.
6779         * f-exp.y: Update rules.
6780         * d-exp.y: Update rules.
6781         * c-exp.y: Update rules.
6782
6783 2019-04-04  Tom Tromey  <tom@tromey.com>
6784
6785         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6786         lex_operator, push_back>: New methods.
6787         Update all rules.
6788         (rust_parser::lex_hex, lex_escape): Rename and update.
6789         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6790         (rust_parser::lex_operator): Rename and update.
6791         (rust_parser::lex_number, rustyylex, rustyyerror)
6792         (rust_lex_test_init, rust_lex_test_sequence)
6793         (rust_lex_test_push_back, rust_lex_tests): Update.
6794         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6795         parameter.
6796         <lexptr, prev_lexptr>: New members.
6797         (lexptr, prev_lexptr): Don't declare.
6798         * parse.c (lexptr, prev_lexptr): Remove globals.
6799         (parse_exp_in_context): Update.
6800         * p-exp.y (yylex, yyerror): Update.
6801         * m2-exp.y (parse_number, yylex, yyerror): Update.
6802         * go-exp.y (lex_one_token, yyerror): Update.
6803         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6804         * d-exp.y (lex_one_token, yyerror): Update.
6805         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6806         (lex_one_token, yyerror): Update.
6807         * ada-lex.l (YY_INPUT): Update.
6808         (rewind_to_char): Update.
6809         * ada-exp.y (yyerror): Update.
6810
6811 2019-04-04  Tom Tromey  <tom@tromey.com>
6812
6813         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6814         * parser-defs.h (struct parser_state) <parser_state>: Add new
6815         parameter.
6816         <comma_terminates>: New member.
6817         (comma_terminates): Don't declare global.
6818         * parse.c (comma_terminates): Remove global.
6819         (parse_exp_in_context): Update.
6820         * p-exp.y (yylex): Update.
6821         * m2-exp.y (yylex): Update.
6822         * go-exp.y (lex_one_token): Update.
6823         * f-exp.y (yylex): Update.
6824         * d-exp.y (lex_one_token): Update.
6825         * c-exp.y (lex_one_token): Update.
6826         * ada-lex.l: Update.
6827
6828 2019-04-04  Tom Tromey  <tom@tromey.com>
6829
6830         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6831         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6832         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6833         * parser-defs.h (paren_depth): Don't declare.
6834         * parse.c (paren_depth): Remove global.
6835         (parse_exp_in_context): Update.
6836         * p-exp.y (paren_depth): New global.
6837         (pascal_parse): Initialize it.
6838         * m2-exp.y (paren_depth): New global.
6839         (m2_parse): Initialize it.
6840         * go-exp.y (paren_depth): New global.
6841         (go_parse): Initialize it.
6842         * f-exp.y (paren_depth): New global.
6843         (f_parse): Initialize it.
6844         * d-exp.y (paren_depth): New global.
6845         (d_parse): Initialize it.
6846         * c-exp.y (paren_depth): New global.
6847         (c_parse): Initialize it.
6848         * ada-lex.l (paren_depth): New global.
6849         (lexer_init): Initialize it.
6850
6851 2019-04-04  Tom Tromey  <tom@tromey.com>
6852
6853         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6854         (rust_parser::convert_ast_to_type)
6855         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6856         * parser-defs.h (struct parser_state) <parser_state>: Add
6857         parameters.  Initialize new members.
6858         <expression_context_block, expression_context_pc>: New members.
6859         * parse.c (expression_context_block, expression_context_pc):
6860         Remove globals.
6861         (parse_exp_in_context): Update.
6862         * p-exp.y: Update all rules.
6863         (yylex): Update.
6864         * m2-exp.y: Update all rules.
6865         (yylex): Update.
6866         * go-exp.y (yylex): Update.
6867         * f-exp.y (yylex): Update.
6868         * d-exp.y: Update all rules.
6869         (yylex): Update.
6870         * c-exp.y: Update all rules.
6871         (lex_one_token, classify_name, yylex, c_parse): Update.
6872         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6873
6874 2019-04-04  Tom Tromey  <tom@tromey.com>
6875
6876         * gdbarch.h, gdbarch.c: Rebuild.
6877         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6878         * stap-probe.h: 
6879         (struct stap_parse_info): Replace "parser_state" with
6880         "expr_builder".
6881         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6882         (parser_state): New class.
6883         * parse.c (expr_builder): Rename.
6884         (expr_builder::release): Rename.
6885         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6886         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6887         (write_exp_elt_longcst, write_exp_elt_floatcst)
6888         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6889         (write_exp_string_vector, write_exp_bitstring)
6890         (write_exp_msymbol, mark_struct_expression)
6891         (write_dollar_variable)
6892         (insert_type_address_space, increase_expout_size): Replace
6893         "parser_state" with "expr_builder".
6894         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6895         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6896         "parser_state" with "expr_builder".
6897
6898 2019-04-04  Tom Tromey  <tom@tromey.com>
6899
6900         * rust-exp.y: Replace "parse_language" with method call.
6901         * p-exp.y: 
6902         (yylex): Replace "parse_language" with method call.
6903         * m2-exp.y: 
6904         (yylex): Replace "parse_language" with method call.
6905         * go-exp.y (classify_name): Replace "parse_language" with method
6906         call.
6907         * f-exp.y (yylex): Replace "parse_language" with method call.
6908         * d-exp.y (lex_one_token): Replace "parse_language" with method
6909         call.
6910         * c-exp.y: 
6911         (lex_one_token, classify_name, yylex): Replace "parse_language"
6912         with method call.
6913         * ada-exp.y (find_primitive_type, type_char)
6914         (type_system_address): Replace "parse_language" with method call.
6915
6916 2019-04-04  Tom Tromey  <tom@tromey.com>
6917
6918         * rust-exp.y: Replace "parse_gdbarch" with method call.
6919         * parse.c (write_dollar_variable, insert_type_address_space):
6920         Replace "parse_gdbarch" with method call.
6921         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6922         call.
6923         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6924         call.
6925         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6926         "parse_gdbarch" with method call.
6927         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6928         with method call.
6929         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6930         "parse_gdbarch" with method call.
6931         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6932         "parse_gdbarch" with method call.
6933         * c-exp.y (parse_type, parse_number, classify_name): Replace
6934         "parse_gdbarch" with method call.
6935         * ada-lex.l: Replace "parse_gdbarch" with method call.
6936         * ada-exp.y (parse_type, find_primitive_type, type_char)
6937         (type_system_address): Replace "parse_gdbarch" with method call.
6938
6939 2019-04-04  Tom Tromey  <tom@tromey.com>
6940
6941         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6942         * stap-probe.c (stap_parse_argument): Update.
6943         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6944         initial_size parameter.
6945         * rust-exp.y (rust_lex_tests): Update.
6946         * parse.c (parser_state): Update.
6947         (parse_exp_in_context): Update.
6948         * parser-defs.h (struct parser_state) <parser_state>: Remove
6949         "initial_size" parameter.
6950
6951 2019-04-04  Tom Tromey  <tom@tromey.com>
6952
6953         * parser-defs.h (increase_expout_size): Don't declare.
6954         * parse.c (increase_expout_size): Now static.
6955
6956 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6957
6958         * gnu-nat.c (gnu_nat_target::wait): Fix
6959         target_waitstatus_to_string call.
6960
6961 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6962
6963         * eval.c (evaluate_subexp_standard): Handle internal functions
6964         during Fortran function call handling.
6965
6966 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * NEWS: Mention new internal functions.
6969         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6970         (read_base_type): Use dwarf2_init_complex_target_type.
6971         * value.c (creal_internal_fn): New function.
6972         (cimag_internal_fn): New function.
6973         (_initialize_values): Register new internal functions.
6974
6975 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6976
6977         * infrun.c (stop_all_threads): If debug_infrun, always
6978         trace the wait status after wait_one, using
6979         target_waitstatus_to_string and target_pid_to_str.
6980         (handle_inferior_event): Replace various trace of
6981         wait status kind by a single trace.
6982         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6983         wait status kind image by target_waitstatus_to_string.
6984         * target/waitstatus.c (target_waitstatus_to_string): Fix
6985         obsolete comment.
6986
6987 2019-04-01  Tom Tromey  <tromey@adacore.com>
6988
6989         PR symtab/23331:
6990         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6991
6992 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6993             Pedro Alves  <palves@redhat.com>
6994
6995         * top.c (quit_force): Call 'finalize_values'.
6996         * value.c (finalize_values): New function.
6997         * value.h (finalize_values): Declare.
6998
6999 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7000
7001         * NEWS: Announce $_gdb_major and $_gdb_minor.
7002
7003         * top.c (init_gdb_version_vars): New function.
7004         (gdb_init): Call init_gdb_version_vars.
7005
7006 2019-03-29  Tom Tromey  <tromey@adacore.com>
7007
7008         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7009         help text.  Remove dead code.
7010
7011 2019-03-29  Keith Seitz  <keiths@redhat.com>
7012
7013         From Siddhesh Poyarekar:
7014         * f-lang.h (f77_get_upperbound): Return LONGEST.
7015         (f77_get_lowerbound): Likewise.
7016         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7017         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7018         print them.
7019         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7020         plongest to format print it.
7021         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7022         (f77_get_upperbound): Likewise.
7023         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7024         LOWER_BOUND to LONGEST.
7025         (f77_create_arrayprint_offset_tbl): Likewise.
7026
7027 2019-03-29  Keith Seitz  <keiths@redhat.com>
7028
7029         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7030         %s/pulongest for TYPE_LENGTH instead of %d in format
7031         strings.
7032         * ada-typerint.c (ada_print_type): Likewise.
7033         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7034         * compile/compile-c-support.c (generate_register_struct): Likewise.
7035         * gdbtypes.c (recursive_dump_type): Likewise.
7036         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7037         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7038         instead of %d in format strings.
7039         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7040         to std::min to ULONGEST.
7041         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7042         instead of %d in format strings.
7043         * tracepoint.c (info_scope_command): Likewise.
7044         * typeprint.c (print_offset_data::update)
7045         (print_offset_data::finish): Likewise.
7046         * xtensa-tdep.c (xtensa_store_return_value)
7047         (xtensa_push_dummy_call): Likewise.
7048
7049 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7050
7051         * windows-nat.c (display_selector): Fixed format specifications
7052         for 64-bit Cygwin.
7053
7054 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7055
7056         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7057
7058 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7059
7060         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7061         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7062         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7063         (nios2_linux_init_abi): Install it.
7064
7065 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7066
7067         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7068
7069 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7070
7071         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7072
7073 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7074             Tom Tromey  <tromey@adacore.com>
7075
7076         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7077
7078 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7079
7080         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7081         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7082         method to compute the bounds of range types. Also print "[evaluated]"
7083         if the bounds' values come from a dynamic evaluation.
7084
7085 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7088         whitespace when pretty printing is on.
7089
7090 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7091
7092         * ppc-linux-nat.c: Add include.
7093
7094 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7095
7096         * NEWS: Mention AArch64 Pointer Authentication.
7097
7098 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7099
7100         * arm-linux-nat.c: Add include.
7101
7102 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7103
7104         * source-cache.c (source_cache::get_source_lines): Re-read
7105         fullname after calling open_source_file.
7106
7107 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7108
7109         * NEWS: Mention TLS support for FreeBSD.
7110
7111 2019-03-25  Tom Tromey  <tromey@adacore.com>
7112
7113         * minsyms.c (BUNCH_SIZE): Update comment.
7114         (~minimal_symbol_reader): Remove old comment.
7115         (compact_minimal_symbols): Update comment.
7116         (minimal_symbol_reader::install): Remove old comment.  Update
7117         other comments.
7118
7119 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7120
7121         * s390-linux-nat.c: Add include.
7122
7123 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7124
7125         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7126         Call linux_get_hwcap.
7127         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7128         Likewise.
7129         (aarch64_linux_get_hwcap): Remove function.
7130         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7131         declaration.
7132         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7133         linux_get_hwcap.
7134         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7135         * linux-tdep.c (linux_get_hwcap): Add function.
7136         (linux_get_hwcap2): Likewise.
7137         * linux-tdep.h (linux_get_hwcap): Add declaration.
7138         (linux_get_hwcap2): Likewise.
7139         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7140         (ppc_linux_get_hwcap2): Likewise.
7141         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7142         linux_get_hwcap.
7143         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7144         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7145         (ppc_linux_nat_target::read_description): Likewise.
7146         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7147         * s390-linux-nat.c: Likewise.
7148         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7149
7150 2019-03-24  Tom Tromey  <tom@tromey.com>
7151
7152         * ada-lang.c (standard_lookup): Simplify initialization.
7153         (ada_lookup_symbol_nonlocal): Simplify return.
7154         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7155         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7156         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7157         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7158         initialization.
7159         * solib.c (solib_global_lookup): Simplify.
7160         * symtab.c (null_block_symbol): Remove.
7161         (symbol_cache_lookup): Simplify returns.
7162         (lookup_language_this): Simplify returns.
7163         (lookup_symbol_aux): Simplify return.
7164         (lookup_local_symbol): Simplify returns.
7165         (lookup_global_symbol_from_objfile): Simplify return.
7166         (lookup_symbol_in_objfile_symtabs)
7167         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7168         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7169         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7170         * cp-namespace.c (cp_lookup_bare_symbol)
7171         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7172         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7173         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7174         (cp_lookup_symbol_via_imports): Simplify initialization.
7175         (find_symbol_in_baseclass): Likewise.
7176         * symtab.h (null_block_symbol): Remove.
7177         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7178         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7179         (d_lookup_symbol_module): Likewise.
7180         (find_symbol_in_baseclass): Simplify initialization.
7181
7182 2019-03-24  Tom Tromey  <tom@tromey.com>
7183
7184         * expression.h: Don't include symtab.h.
7185         (struct block): Forward declare.
7186
7187 2019-03-24  Tom Tromey  <tom@tromey.com>
7188
7189         * c-exp.y (typebase): Remove casts.
7190         * gdbtypes.c (lookup_unsigned_typename, )
7191         (lookup_signed_typename): Remove cast.
7192         * eval.c (parse_to_comma_and_eval): Remove cast.
7193         * parse.c (write_dollar_variable): Remove cast.
7194         * block.h (struct block) <superblock>: Now const.
7195         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7196         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7197         (map_block): Make "block" const.
7198         * symfile.h (struct quick_symbol_functions)
7199         <map_matching_symbols>: Constify block argument to "callback".
7200         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7201         const.
7202         (find_pc_sect_compunit_symtab): Make "b" const.
7203         (find_symbol_at_address): Likewise.
7204         (search_symbols): Likewise.
7205         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7206         (dw2_debug_names_lookup_symbol): Likewise.
7207         (dw2_map_matching_symbols): Update.
7208         * p-valprint.c (pascal_val_print): Remove "block".
7209         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7210         (aux_add_nonlocal_symbols): Make "block" const.
7211         (resolve_subexp): Remove cast.
7212         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7213         const.
7214         (iterate_over_file_blocks): Likewise.
7215         * f-exp.y (%union) <bval>: Remove.
7216         * coffread.c (patch_opaque_types): Make "b" const.
7217         * spu-tdep.c (spu_catch_start): Make "block" const.
7218         * c-valprint.c (print_unpacked_pointer): Remove "block".
7219         * symmisc.c (dump_symtab_1): Make "b" const.
7220         (block_depth): Make "block" const.
7221         * d-exp.y (%union) <bval>: Remove.
7222         * cp-support.h (cp_lookup_rtti_type): Update.
7223         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7224         * psymtab.c (psym_lookup_symbol): Make "block" const.
7225         (maintenance_check_psymtabs): Make "b" const.
7226         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7227         (enumerate_locals, enumerate_args): Update.
7228         * python/py-symtab.c (stpy_global_block): Make "block" const.
7229         (stpy_static_block): Likewise.
7230         * inline-frame.c (block_starting_point_at): Make "new_block"
7231         const.
7232         * block.c (find_block_in_blockvector): Make return type const.
7233         (blockvector_for_pc_sect): Make "b" const.
7234         (find_block_in_blockvector): Make "b" const.
7235
7236 2019-03-23  Tom Tromey  <tom@tromey.com>
7237
7238         * varobj.c (varobj_create): Update.
7239         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7240         * printcmd.c (display_command, do_one_display): Don't reset
7241         innermost_block.
7242         * parser-defs.h (enum innermost_block_tracker_type): Move to
7243         expression.h.
7244         (innermost_block): Update comment.
7245         * parse.c (parse_exp_1): Add tracker_types parameter.
7246         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7247         tracker_types parameter.  Reset innermost_block.
7248         (parse_exp_in_context): Remove.
7249         (parse_expression_for_completion): Update.
7250         * objfiles.c (~objfile): Don't reset expression_context_block or
7251         innermost_block.
7252         * expression.h (enum innermost_block_tracker_type): Move from
7253         parser-defs.h.
7254         (parse_exp_1): Add tracker_types parameter.
7255         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7256         reset innermost_block.
7257
7258 2019-03-23  Tom Tromey  <tom@tromey.com>
7259
7260         * objfiles.h: Include bcache.h.
7261
7262 2019-03-23  Tom Tromey  <tom@tromey.com>
7263
7264         * linespec.c (get_current_search_block): Use
7265         scoped_restore_current_language.
7266         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7267
7268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7269             Jiong Wang  <jiong.wang@arm.com>
7270
7271         * aarch64-linux-tdep.c
7272         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7273         section.
7274         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7275
7276 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7277             Jiong Wang  <jiong.wang@arm.com>
7278
7279         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7280         instructions.
7281         (aarch64_analyze_prologue_test): Add PACIASP test.
7282         (aarch64_prologue_prev_register): Unmask PC value.
7283
7284 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7285             Jiong Wang  <jiong.wang@arm.com>
7286
7287         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7288         (aarch64_dwarf2_prev_register): Unmask PC value.
7289         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7290         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7291         DW_CFA_AARCH64_negate_ra_state.
7292         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7293
7294 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7295             Jiong Wang  <jiong.wang@arm.com>
7296
7297         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7298         registers.
7299         (aarch64_pseudo_register_name): Likewise.
7300         (aarch64_pseudo_register_type): Likewise.
7301         (aarch64_pseudo_register_reggroup_p): Likewise.
7302         (aarch64_gdbarch_init): Add pauth registers.
7303         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7304         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7305         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7306         (struct gdbarch_tdep): Add regnum for ra_state.
7307
7308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7309             Jiong Wang  <jiong.wang@arm.com>
7310
7311         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7312
7313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7314             Jiong Wang  <jiong.wang@arm.com>
7315
7316         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7317         function.
7318         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7319         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7320         (aarch64_gdbarch_init): Add puth registers.
7321         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7322         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7323         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7324
7325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7326             Jiong Wang  <jiong.wang@arm.com>
7327
7328         * aarch64-linux-nat.c
7329         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7330         * aarch64-linux-tdep.c
7331         (aarch64_linux_core_read_description): Likewise.
7332         (aarch64_linux_get_hwcap): New function.
7333         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7334         (aarch64_linux_get_hwcap): New declaration.
7335
7336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7337             Jiong Wang  <jiong.wang@arm.com>
7338
7339         * aarch64-linux-nat.c
7340         (aarch64_linux_nat_target::read_description): Add pauth param.
7341         * aarch64-linux-tdep.c
7342         (aarch64_linux_core_read_description): Likewise.
7343         * aarch64-tdep.c (struct target_desc): Add in pauth.
7344         (aarch64_read_description): Add pauth param.
7345         (aarch64_gdbarch_init): Likewise.
7346         * aarch64-tdep.h (aarch64_read_description): Likewise.
7347         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7348         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7349         * features/Makefile: Add new files.
7350         * features/aarch64-pauth.c: New file.
7351         * features/aarch64-pauth.xml: New file.
7352
7353 2019-03-20  Tom Tromey  <tromey@adacore.com>
7354
7355         * infrun.c (handle_inferior_event): Rename from
7356         handle_inferior_event_1.  Create a scoped_value_mark.
7357         (handle_inferior_event): Remove.
7358
7359 2019-03-19  Tom Tromey  <tromey@adacore.com>
7360
7361         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7362         * infrun.h (print_stop_event): Add "displays" parameter.
7363         * infrun.c (print_stop_event): Add "displays" parameter.
7364
7365 2019-03-19  Pedro Alves  <palves@redhat.com>
7366
7367         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7368         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7369         to -1.  Fix TABs vs spaces.
7370         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7371         * tui/tui-out.h (tui_ui_out) Add intro comments.
7372         <m_line, m_start_of_line>: In-class initialize, and add describing
7373         comment.
7374
7375 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7376
7377         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7378         variable names.
7379         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7380
7381 2019-03-18  Pedro Alves  <palves@redhat.com>
7382             Eli Zaretskii <eliz@gnu.org>
7383
7384         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7385         m_line and m_start_of_line.
7386
7387 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7388
7389         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7390         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7391         it returns a newline.  This fixes a regression in TU mode, whereby
7392         the next line is output on the same screen line as the user input.
7393
7394 2019-03-18  Tom Tromey  <tromey@adacore.com>
7395
7396         * minsyms.c (minimal_symbol_reader::install): Remove call to
7397         obstack_blank.
7398
7399 2019-03-18  Pedro Alves  <palves@redhat.com>
7400
7401         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7402         New globals.
7403         (apply_style): New, factored out from ...
7404         (apply_ansi_escape): ... this.  Handle reverse video mode.
7405         (tui_set_reverse_mode): New function.
7406         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7407         * tui/tui-winsource.c (tui_show_source_line): Use
7408         tui_set_reverse_mode instead of setting A_STANDOUT.
7409         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7410         New setter methods.
7411
7412 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7413
7414         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7415         Handle tabs.
7416
7417 2019-03-18  Tom Tromey  <tromey@adacore.com>
7418
7419         * ada-lang.c (empty_array): Add "high" parameter.
7420         (ada_evaluate_subexp): Update.
7421
7422 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7423
7424         * unittests/string_view-selftests.c: Define
7425         _initialize_string_view_selftests unconditionally.
7426
7427 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7428
7429         PR gdb/24350
7430         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7431
7432 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7433
7434         PR gdb/24351
7435         * windows-nat.c (display_selector): Fix format specifiers.
7436
7437 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7438
7439         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7440         tui_refill_source_window instead of tui_refresh_win, to update the
7441         current execution line.  This fixes redisplay of the current line
7442         when stepping through the code with "next" or "step".
7443
7444 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7445
7446         * source-cache.c (source_cache::get_source_lines): Call
7447         find_source_lines to initialize s->nlines.  This fixes vertical
7448         scrolling of TUI source window when the DOWN arrow is pressed.
7449
7450 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7451
7452         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7453         linux-thread-db.c (_initialize_thread_db): Likewise.
7454
7455 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7456
7457         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7458         wclrtoeol in tui_show_source_line".  This reverts changes made in
7459         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7460
7461 2019-03-15  Tom Tromey  <tom@tromey.com>
7462
7463         * symtab.h (struct minimal_symbol): Derive from
7464         general_symbol_info.
7465         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7466         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7467         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7468         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7469         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7470         (MSYMBOL_SEARCH_NAME): Update.
7471         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7472         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7473         * minsyms.c (minimal_symbol_reader::record_full): Update.
7474
7475 2019-03-15  Tom Tromey  <tom@tromey.com>
7476
7477         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7478
7479 2019-03-15  Tom Tromey  <tom@tromey.com>
7480
7481         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7482         unique_xmalloc_ptr.
7483         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7484         Update.
7485         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7486         (build_minimal_symbol_hash_tables)
7487         (minimal_symbol_reader::install): Update.
7488
7489 2019-03-15  Tom Tromey  <tom@tromey.com>
7490
7491         * symtab.c (create_demangled_names_hash): Update.
7492         (symbol_set_names): Update.
7493         * objfiles.h (struct objfile_per_bfd_storage)
7494         <demangled_names_hash>: Now an htab_up.
7495         * objfiles.c (objfile_per_bfd_storage): Simplify.
7496
7497 2019-03-15  Tom Tromey  <tom@tromey.com>
7498
7499         * objfiles.h (struct objfile_per_bfd_storage): Declare
7500         destructor.
7501         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7502         New.
7503         (get_objfile_bfd_data): Use new.  Don't initialize
7504         language_of_main.
7505         (free_objfile_per_bfd_storage): Remove.
7506         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7507
7508 2019-03-15  Tom Tromey  <tom@tromey.com>
7509
7510         * symfile.c (reread_symbols): Update.
7511         * objfiles.c (objfile::objfile): Update.
7512         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7513         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7514         comment.
7515         (minimal_symbol_reader::install): Update.
7516         (terminate_minimal_symbol_table): Remove.
7517         * jit.c (jit_object_close_impl): Update.
7518
7519 2019-03-15  Tom Tromey  <tom@tromey.com>
7520
7521         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7522         initializations.
7523
7524 2019-03-15  Tom Tromey  <tom@tromey.com>
7525
7526         * objfiles.h (struct objfile_per_bfd_storage)
7527         <demangled_hash_languages>: Now a bitset.
7528         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7529         (lookup_minimal_symbol): Update.
7530
7531 2019-03-15  Tom Tromey  <tom@tromey.com>
7532
7533         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7534         Don't return the symbol.
7535         * coffread.c (record_minimal_symbol): Use record_full.
7536
7537 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7538
7539         The MS-Windows port of ncurses fails to switch to a color pair if
7540         one or both of the colors are the implicit default colors.  This
7541         change records the default colors when TUI is initialized, and
7542         then specifies them explicitly when a color pair uses the default
7543         colors.  This allows color styling in TUI mode on MS-Windows.
7544
7545         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7546         ncurses_norm_attr.
7547         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7548         colors in ncurses_norm_attr.
7549         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7550         "none", replace it with the default color recorded in
7551         ncurses_norm_attr.
7552
7553 2019-03-14  Tom Tromey  <tromey@adacore.com>
7554
7555         * source-cache.h (class source_cache) <get_source_lines>: Return
7556         std::string.
7557         * source-cache.c (source_cache::extract_lines): Handle case where
7558         first_pos==npos.  Return std::string.
7559         (source_cache::get_source_lines): Update.
7560
7561 2019-03-14  Tom Tromey  <tromey@adacore.com>
7562
7563         * NEWS: Add item for "style sources" commands.
7564         * source-cache.c (source_cache::get_source_lines): Check
7565         source_styling.
7566         * cli/cli-style.c (source_styling): New global.
7567         (_initialize_cli_style): Add "style sources" commands.
7568         (show_style_sources): New function.
7569         * cli/cli-style.h (source_styling): Declare.
7570
7571 2019-03-14  Pedro Alves  <palves@redhat.com>
7572             Tom Tromey  <tromey@adacore.com>
7573
7574         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7575         * tui/tui-winsource.c (tui_refill_source_window): New function,
7576         from...
7577         (tui_horizontal_source_scroll): ... here.  Move some logic.
7578         * cli/cli-style.c (set_style_enabled): Notify new observable.
7579         * tui/tui-hooks.c (tui_redisplay_source): New function.
7580         (tui_attach_detach_observers): Attach or detach
7581         tui_redisplay_source.
7582         * observable.h (source_styling_changed): New observable.
7583         * observable.c: Define source_styling_changed observable.
7584
7585 2019-03-13  Tom Tromey  <tromey@adacore.com>
7586
7587         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7588         (i386_gnu_nat_target::store_registers): Update.
7589         * target-debug.h (target_debug_print_std_string): New macro.
7590         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7591         * windows-tdep.c (display_one_tib): Update.
7592         * tui/tui-stack.c (tui_make_status_line): Update.
7593         * top.c (print_inferior_quit_action): Update.
7594         * thread.c (thr_try_catch_cmd): Update.
7595         (add_thread_with_info): Update.
7596         (thread_target_id_str): Update.
7597         (thr_try_catch_cmd): Update.
7598         (thread_command): Update.
7599         (thread_find_command): Update.
7600         * record-btrace.c (record_btrace_target::info_record)
7601         (record_btrace_resume_thread, record_btrace_target::resume)
7602         (record_btrace_cancel_resume, record_btrace_step_thread)
7603         (record_btrace_target::wait, record_btrace_target::wait)
7604         (record_btrace_target::wait, record_btrace_target::stop): Update.
7605         * progspace.c (print_program_space): Update.
7606         * process-stratum-target.c
7607         (process_stratum_target::thread_address_space): Update.
7608         * linux-fork.c (linux_fork_mourn_inferior)
7609         (detach_checkpoint_command, info_checkpoints_command)
7610         (linux_fork_context): Update.
7611         (linux_fork_detach): Update.
7612         (class scoped_switch_fork_info): Update.
7613         (delete_checkpoint_command): Update.
7614         * infrun.c (follow_fork_inferior): Update.
7615         (follow_fork_inferior): Update.
7616         (proceed_after_vfork_done): Update.
7617         (handle_vfork_child_exec_or_exit): Update.
7618         (follow_exec): Update.
7619         (displaced_step_prepare_throw): Update.
7620         (displaced_step_restore): Update.
7621         (start_step_over): Update.
7622         (resume_1): Update.
7623         (clear_proceed_status_thread): Update.
7624         (proceed): Update.
7625         (print_target_wait_results): Update.
7626         (do_target_wait): Update.
7627         (context_switch): Update.
7628         (stop_all_threads): Update.
7629         (restart_threads): Update.
7630         (finish_step_over): Update.
7631         (handle_signal_stop): Update.
7632         (switch_back_to_stepped_thread): Update.
7633         (keep_going_pass_signal): Update.
7634         (print_exited_reason): Update.
7635         (normal_stop): Update.
7636         * inferior.c (inferior_pid_to_str): Change return type.
7637         (print_selected_inferior): Update.
7638         (add_inferior): Update.
7639         (detach_inferior): Update.
7640         * dummy-frame.c (fprint_dummy_frames): Update.
7641         * dcache.c (dcache_info_1): Update.
7642         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7643         (btrace_fetch, btrace_clear): Update.
7644         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7645         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7646         type.
7647         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7648         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7649         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7650         * gdbarch.c, gdbarch.h: Rebuild.
7651         * gdbarch.sh (core_pid_to_str): Change return type.
7652         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7653         return type.
7654         (windows_nat_target::pid_to_str): Change return type.
7655         (windows_delete_thread): Update.
7656         (windows_nat_target::attach): Update.
7657         (windows_nat_target::files_info): Update.
7658         * target-delegates.c: Rebuild.
7659         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7660         return type.
7661         (sol_thread_target::pid_to_str): Change return type.
7662         * remote.c (class remote_target) <pid_to_str>: Change return
7663         type.
7664         (remote_target::pid_to_str): Change return type.
7665         (extended_remote_target::attach, remote_target::remote_stop_ns)
7666         (remote_target::remote_notif_remove_queued_reply)
7667         (remote_target::push_stop_reply, remote_target::disable_btrace):
7668         Update.
7669         (extended_remote_target::attach): Update.
7670         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7671         type.
7672         (gdbsim_target::pid_to_str): Change return type.
7673         * ravenscar-thread.c (struct ravenscar_thread_target)
7674         <pid_to_str>: Change return type.
7675         (ravenscar_thread_target::pid_to_str): Change return type.
7676         * procfs.c (class procfs_target) <pid_to_str>: Change return
7677         type.
7678         (procfs_target::pid_to_str): Change return type.
7679         (procfs_target::attach): Update.
7680         (procfs_target::detach): Update.
7681         (procfs_target::fetch_registers): Update.
7682         (procfs_target::store_registers): Update.
7683         (procfs_target::wait): Update.
7684         (procfs_target::files_info): Update.
7685         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7686         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7687         return type.
7688         (nto_procfs_target::pid_to_str): Change return type.
7689         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7690         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7691         return type.
7692         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7693         (exit_lwp): Update.
7694         (attach_proc_task_lwp_callback, get_detach_signal)
7695         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7696         (linux_nat_target::resume, wait_lwp, stop_callback)
7697         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7698         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7699         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7700         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7701         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7702         type.
7703         (inf_ptrace_target::attach): Update.
7704         (inf_ptrace_target::files_info): Update.
7705         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7706         type.
7707         (go32_nat_target::pid_to_str): Change return type.
7708         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7709         (gnu_nat_target::wait): Update.
7710         (gnu_nat_target::wait): Update.
7711         (gnu_nat_target::resume): Update.
7712         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7713         (fbsd_nat_target::wait): Update.
7714         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7715         type.
7716         (darwin_nat_target::attach): Update.
7717         * corelow.c (class core_target) <pid_to_str>: Change return type.
7718         (core_target::pid_to_str): Change return type.
7719         * target.c (normal_pid_to_str): Change return type.
7720         (default_pid_to_str): Likewise.
7721         (target_pid_to_str): Change return type.
7722         (target_translate_tls_address): Update.
7723         (target_announce_detach): Update.
7724         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7725         return type.
7726         (bsd_uthread_target::pid_to_str): Change return type.
7727         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7728         type.
7729         (bsd_kvm_target::pid_to_str): Change return type.
7730         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7731         return type.
7732         (aix_thread_target::pid_to_str): Change return type.
7733         * target.h (struct target_ops) <pid_to_str>: Change return type.
7734         (target_pid_to_str, normal_pid_to_str): Likewise.
7735         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7736         type.
7737         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7738         type.
7739         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7740         return type.
7741         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7742         type.
7743         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7744         type.
7745         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7746         return type.
7747
7748 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7749
7750         * NEWS: Mention that the new default MI version is 3.  Mention
7751         changes to the output of commands and events that deal with
7752         multi-location breakpoints.
7753         * breakpoint.c: Include "mi/mi-out.h".
7754         (print_one_breakpoint): Change output syntax if using MI version
7755         >= 3.
7756         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7757         New.
7758         (mi_multi_location_breakpoint_output_fixed): New.
7759         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7760         (mi_cmd_fix_multi_location_breakpoint_output): New.
7761         (mi_multi_location_breakpoint_output_fixed): New.
7762         * mi/mi-cmds.c (mi_cmds): Register command
7763         -fix-multi-location-breakpoint-output.
7764         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7765         interpreter "mi".
7766
7767 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7768
7769         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7770         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7771         instantiate mi_ui_out based on interpreter name.
7772         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7773         * mi/mi-main.c (mi_load_progress): Likewise.
7774
7775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7776
7777         * NEWS: Combine separate "New targets" sections for 8.3.
7778
7779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7780
7781         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7782         (ppcfbsd_init_abi): Install gdbarch
7783         "fetch_tls_load_module_address" and "get_thread_local_address"
7784         methods.
7785
7786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7787
7788         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7789         (riscv_fbsd_init_abi): Install gdbarch
7790         "fetch_tls_load_module_address" and "get_thread_local_address"
7791         methods.
7792
7793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7794
7795         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7796         (i386fbsd_init_abi): Install gdbarch
7797         "fetch_tls_load_module_address" and "get_thread_local_address"
7798         methods.
7799
7800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7801
7802         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7803         (amd64fbsd_init_abi): Install gdbarch
7804         "fetch_tls_load_module_address" and "get_thread_local_address"
7805         methods.
7806
7807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7808
7809         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7810         (struct fbsd_pspace_data): New type.
7811         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7812         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7813         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7814         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7815         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7816
7817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7818
7819         * gdbtypes.c (lookup_struct_elt): New function.
7820         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7821         * gdbtypes.h (struct struct_elt): New type.
7822         (lookup_struct_elt): New prototype.
7823
7824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7825
7826         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7827         remove disabled code block.
7828
7829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7830
7831         * gdbarch.sh (get_thread_local_address): New method.
7832         * gdbarch.h, gdbarch.c: Regenerate.
7833         * target.c (target_translate_tls_address): Use
7834         gdbarch_get_thread_local_address if present instead of
7835         target::get_thread_local_address.
7836
7837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7838
7839         * target.h (target::get_thread_local_address): Update comment.
7840
7841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7842
7843         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7844         objfile->separate_debug_objfile_backlink if not NULL.
7845
7846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7847
7848         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7849         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7850         (amd64bsd_store_inferior_registers): Likewise.
7851         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7852         Enable segment base registers.
7853         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7854         PT_GETFSBASE and PT_GETGSBASE.
7855         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7856         PT_SETGSBASE.
7857         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7858         segment base registers.
7859         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7860
7861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7862
7863         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7864         Update calls to i386_target_description to add 'segments'
7865         parameter.
7866         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7867         add segment base registers.
7868         * arch/i386.c (i386_create_target_description): Add 'segments'
7869         parameter to enable segment base registers.
7870         * arch/i386.h (i386_create_target_description): Likewise.
7871         * features/i386/32bit-segments.xml: New file.
7872         * features/i386/32bit-segments.c: Generate.
7873         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7874         call to i386_target_description to add 'segments' parameter.
7875         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7876         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7877         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7878         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7879         if feature is present.
7880         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7881         Add 'segments' parameter to call to i386_target_description.
7882         (i386_target_description): Add 'segments' parameter to enable
7883         segment base registers.
7884         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7885         to call to i386_target_description.
7886         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7887         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7888         Define I386_NUM_REGS.
7889         (i386_target_description): Add 'segments' parameter to enable
7890         segment base registers.
7891
7892 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7893
7894         PR/24325
7895         * source-cache.c: #undef open and close, to avoid unresolved
7896         externals during linking.
7897
7898 2019-03-12  Tom Tromey  <tromey@adacore.com>
7899
7900         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7901         const.  Add initializers.
7902         (_initialize_remote): Don't initialize ptid globals.
7903
7904 2019-03-12  Pedro Alves  <palves@redhat.com>
7905
7906         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7907
7908 2019-03-12  Pedro Alves  <palves@redhat.com>
7909
7910         * cp-name-parser.y (main): Remove unused 'len' variable.
7911
7912 2019-03-12  Tom Tromey  <tromey@adacore.com>
7913
7914         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7915         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7916
7917 2019-03-12  Tom Tromey  <tromey@adacore.com>
7918
7919         * linux-nat.c (iterate_over_lwps): Update.
7920         (stop_callback): Remove parameter.
7921         (stop_wait_callback, detach_callback, resume_set_callback)
7922         (select_singlestep_lwp_callback, set_ignore_sigint)
7923         (status_callback, resumed_callback, resume_clear_callback)
7924         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7925         data parameter.
7926         (linux_nat_target::detach, linux_nat_target::resume)
7927         (linux_stop_and_wait_all_lwps, select_event_lwp)
7928         (linux_nat_filter_event, linux_nat_wait_1)
7929         (linux_nat_target::kill, linux_nat_target::stop)
7930         (linux_nat_target::stop): Update.
7931         (linux_nat_resume_callback): Change type.
7932         (resume_stopped_resumed_lwps, count_events_callback)
7933         (select_event_lwp_callback): Likewise.
7934         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7935         * arm-linux-nat.c (struct update_registers_data): Remove.
7936         (update_registers_callback): Change type.
7937         (arm_linux_insert_hw_breakpoint1): Update.
7938         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7939         parameter.
7940         (x86_linux_dr_set_addr): Update.
7941         (x86_linux_dr_set_control): Update.
7942         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7943         (iterate_over_lwps): Use gdb::function_view.
7944         * nat/aarch64-linux-hw-point.c (struct
7945         aarch64_dr_update_callback_param): Remove.
7946         (debug_reg_change_callback): Change type.
7947         (aarch64_notify_debug_reg_change): Update.
7948         * s390-linux-nat.c (s390_refresh_per_info): Update.
7949
7950 2019-03-11  Tom Tromey  <tromey@adacore.com>
7951
7952         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7953         redundant assignment to "this_cu".
7954
7955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7956
7957         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7958
7959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7960
7961         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7962         from...
7963         (rank_one_type): ... this.
7964
7965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7966
7967         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7968         from...
7969         (rank_one_type): ... this.
7970
7971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7972
7973         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7974         from...
7975         (rank_one_type): ... this.
7976
7977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7978
7979         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7980         from...
7981         (rank_one_type): ... this.
7982
7983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7984
7985         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7986         from...
7987         (rank_one_type): ... this.
7988
7989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7990
7991         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7992         from...
7993         (rank_one_type): ... this.
7994
7995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7996
7997         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7998         from...
7999         (rank_one_type): ... this.
8000
8001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8002
8003         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8004         from...
8005         (rank_one_type): ... this.
8006
8007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8008
8009         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8010         from...
8011         (rank_one_type): ... this.
8012
8013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8014
8015         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8016         from...
8017         (rank_one_type): ... this.
8018
8019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8020
8021         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8022         from...
8023         (rank_one_type): ... this.
8024
8025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8026
8027         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8028         from...
8029         (rank_one_type): ... this.
8030
8031 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8032
8033         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8034         inferior-events' shows the example events.
8035
8036 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8037
8038         Support styling on native MS-Windows console
8039
8040         PR/24315
8041         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8042         on MS-Windows if $TERM is not defined.
8043
8044         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8045
8046         * posix-hdep.c (gdb_console_fputs):
8047         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8048         functions.
8049         * ui-file.h (gdb_console_fputs): Add prototype.
8050
8051         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8052         back to fputs only if the former returns zero.
8053
8054 2019-03-07  Tom Tromey  <tom@tromey.com>
8055
8056         * symmisc.c (print_symbol_bcache_statistics): Update.
8057         (print_objfile_statistics): Update.
8058         * symfile.c (allocate_symtab): Update.
8059         * stabsread.c: Don't include bcache.h.
8060         * psymtab.h (struct psymbol_bcache): Don't declare.
8061         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8062         (psymbol_bcache_init, psymbol_bcache_free)
8063         (psymbol_bcache_get_bcache): Don't declare.
8064         * psymtab.c (struct psymbol_bcache): Remove.
8065         (psymtab_storage::psymtab_storage): Update.
8066         (psymtab_storage::~psymtab_storage): Update.
8067         (psymbol_bcache_init, psymbol_bcache_free)
8068         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8069         (add_psymbol_to_bcache): Update.
8070         (allocate_psymtab): Update.
8071         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8072         macro_cache>: No longer pointers.
8073         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8074         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8075         * macrotab.c (macro_bcache): Update.
8076         * macroexp.c: Don't include bcache.h.
8077         * gdbtypes.c (check_types_worklist): Update.
8078         (types_deeply_equal): Remove TRY/CATCH.  Update.
8079         * elfread.c (elf_symtab_read): Update.
8080         * dwarf2read.c: Don't include bcache.h.
8081         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8082         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8083         (print_bcache_statistics, bcache_memory_used): Don't declare.
8084         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8085         methods.  Rename all data members.
8086         * bcache.c (struct bcache): Move to bcache.h.
8087         (bcache::expand_hash_table): Rename from expand_hash_table.
8088         (bcache): Remove.
8089         (bcache::insert): Rename from bcache_full.
8090         (bcache::compare): Rename from bcache_compare.
8091         (bcache_xmalloc): Remove.
8092         (bcache::~bcache): Rename from bcache_xfree.
8093         (bcache::print_statistics): Rename from print_bcache_statistics.
8094         (bcache::memory_used): Rename from bcache_memory_used.
8095
8096 2019-03-07  Pedro Alves  <palves@redhat.com>
8097
8098         * infrun.c (normal_stop): Also check for
8099         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8100
8101 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * f-lang.c (value_from_host_double): Moved to...
8104         * value.c (value_from_host_double): ...here.
8105         * value.h (value_from_host_double): Declare.
8106         * guile/scm-math.c (vlscm_convert_typed_number): Use
8107         value_from_host_double.
8108         (vlscm_convert_number): Likewise.
8109         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8110         * python/py-value.c (convert_value_from_python): Likewise.
8111
8112 2019-03-06  Tom Tromey  <tom@tromey.com>
8113
8114         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8115
8116 2019-03-06  Tom Tromey  <tom@tromey.com>
8117
8118         * utils.h (free_current_contents): Don't declare.
8119         * utils.c (free_current_contents): Remove.
8120
8121 2019-03-06  Tom Tromey  <tom@tromey.com>
8122
8123         * top.c (quit_force): Update.
8124         * main.c (captured_command_loop): Update.
8125         * common/new-op.c (operator new): Update.
8126         * common/common-exceptions.c (struct catcher)
8127         <save_cleanup_chain>: Remove member.
8128         (exceptions_state_mc_init): Update.
8129         (exception_try_scope_entry): Return nullptr.
8130         (exception_try_scope_exit, exception_rethrow)
8131         (throw_exception_sjlj, throw_exception_cxx): Update.
8132         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8133         (all_cleanups, do_cleanups, discard_cleanups)
8134         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8135         (restore_cleanups, restore_final_cleanups): Don't declare.
8136         (do_final_cleanups): Remove parameter.
8137         * common/cleanups.c (cleanup_chain, make_cleanup)
8138         (make_cleanup_dtor, all_cleanups, do_cleanups)
8139         (discard_my_cleanups, discard_cleanups)
8140         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8141         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8142         (null_cleanup): Remove.
8143         (do_final_cleanups): Remove parameter.
8144
8145 2019-03-06  Tom Tromey  <tom@tromey.com>
8146
8147         * remote.c (remote_target::remote_parse_stop_reply): Use
8148         unique_xmalloc_ptr.
8149
8150 2019-03-06  Tom Tromey  <tom@tromey.com>
8151
8152         * stabsread.c (struct stabs_field_info): Rename from field_info.
8153         <list, fnlist>: Add initializers.
8154         <obstack>: New member.
8155         (read_member_functions, read_struct_fields, read_baseclasses):
8156         Allocate on obstack.  Don't use cleanups.
8157         (read_one_struct_field, read_member_functions, read_struct_fields)
8158         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8159         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8160         (read_struct_type): Update.
8161
8162 2019-03-06  Tom Tromey  <tom@tromey.com>
8163
8164         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8165         * common/filestuff.h (make_cleanup_close): Don't declare.
8166         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8167         Remove.
8168
8169 2019-03-06  Tom Tromey  <tom@tromey.com>
8170
8171         * solib-aix.c: Use make_scope_exit.
8172
8173 2019-03-06  Tom Tromey  <tom@tromey.com>
8174
8175         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8176         Use make_scope_exit.
8177
8178 2019-03-06  Tom Tromey  <tom@tromey.com>
8179
8180         * solib-svr4.c (disable_probes_interface): Remove parameter.
8181         (svr4_handle_solib_event): Use make_scope_exit.
8182
8183 2019-03-06  Tom Tromey  <tom@tromey.com>
8184
8185         * remote.c (struct stop_reply_deleter): Remove.
8186         (stop_reply_up): Update.
8187         (struct stop_reply): Derive from notif_event.  Don't typedef.
8188         <regcache>: Now a std::vector.
8189         (stop_reply_xfree): Remove.
8190         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8191         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8192         (remote_target::discard_pending_stop_replies): Use delete.
8193         (remote_target::remote_parse_stop_reply): Update.
8194         (remote_target::process_stop_reply): Update.
8195         * remote-notif.h (struct notif_event): Add virtual destructor.
8196         Remove "dtr" member.
8197         (struct notif_client) <alloc_event>: Return a unique_ptr.
8198         (notif_event_xfree): Don't declare.
8199         (notif_event_up): New typedef.
8200         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8201         (notif_event_xfree, do_notif_event_xfree): Remove.
8202         (remote_notif_state_xfree): Update.
8203
8204 2019-03-06  Tom Tromey  <tom@tromey.com>
8205
8206         * infrun.c (displaced_step_clear_cleanup): Now a
8207         forward_scope_exit type.
8208         (displaced_step_prepare_throw): Update.
8209         (displaced_step_fixup): Update.
8210
8211 2019-03-06  Tom Tromey  <tom@tromey.com>
8212
8213         * inferior.h (class inferior): Update comment.
8214         * gdbthread.h (class thread_info): Update comment.
8215
8216 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8217             Tom Tromey  <tom@tromey.com>
8218
8219         * stabsread.h (struct stab_section_list): Remove.
8220         (coffstab_build_psymtabs): Update.
8221         * dbxread.c (symbuf_sections): Now a std::vector.
8222         (sect_idx): New global.
8223         (fill_symbuf): Update.
8224         (coffstab_build_psymtabs): Change type of stabsects parameter.
8225         Update.
8226         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8227         std::vector.
8228         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8229         (coff_locate_sections): Update.
8230         (coff_symfile_read): Remove cleanups.  Update.
8231         (init_stringtab): Add storage parameter.
8232         (free_stringtab, free_stringtab_cleanup): Remove.
8233         (init_lineno): Add storage parameter.
8234         (free_linetab, free_linetab_cleanup): Remove.
8235
8236 2019-03-06  Pedro Alves  <palves@redhat.com>
8237
8238         * linux-fork.c (fork_info::clobber_regs): Delete.
8239         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8240         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8241         comment.  Adjust.
8242         (scoped_switch_fork_info::scoped_switch_fork_info)
8243         (checkpoint_command, linux_fork_context): Adjust
8244         fork_save_infrun_state calls.
8245
8246 2019-03-06  Pedro Alves  <palves@redhat.com>
8247
8248         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8249         (inf_has_multiple_threads): Return 'bool' and rewrite using
8250         inferior_info::threads().
8251
8252 2019-03-06  Pedro Alves  <palves@redhat.com>
8253
8254         * linux-fork.c: Include <list>.
8255         (fork_list): Now a std::list instance.
8256         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8257         (forks_exist_p, find_last_fork): Adjust.
8258         (new_fork): Delete.
8259         (one_fork_p): New.
8260         (add_fork): Adjust.
8261         (free_fork): Delete, folded into fork_info::~fork_info().
8262         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8263         Adjust.
8264         (init_fork_list): Delete.
8265         (linux_fork_killall, linux_fork_mourn_inferior)
8266         (linux_fork_detach, info_checkpoints_command): Adjust.
8267         (_initialize_linux_fork): No longer call init_fork_list.
8268
8269 2019-03-06  Pedro Alves  <palves@redhat.com>
8270
8271         * linux-fork.c (new_fork): New, split out of ...
8272         (add_fork): ... this.  Return void.  Move "first fork" special
8273         case from here, to ...
8274         (checkpoint_command): ... here.
8275         * linux-linux.h (add_fork): Return void.
8276
8277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8278
8279         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8280
8281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8282             Chris January  <chris.january@arm.com>
8283             David Lecomber  <david.lecomber@arm.com>
8284
8285         * f-exp.y: New token, UNOP_INTRINSIC.
8286         (exp): New pattern using UNOP_INTRINSIC token.
8287         (f77_keywords): Add 'abs' keyword.
8288         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8289         (value_from_host_double): New function.
8290         (evaluate_subexp_f): Support UNOP_ABS.
8291
8292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8295         types.
8296
8297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8300         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8301         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8302
8303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8304
8305         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8306
8307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8308             Chris January  <chris.january@arm.com>
8309
8310         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8311         * f-exp.y: Define 'KIND' token.
8312         (exp): New pattern for KIND expressions.
8313         (ptype): Handle types with a kind extension.
8314         (direct_abs_decl): Extend to spot kind extensions.
8315         (f77_keywords): Add 'kind' to the list.
8316         (push_kind_type): New function.
8317         (convert_to_kind_type): New function.
8318         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8319         * parse.c (operator_length_standard): Likewise.
8320         * parser-defs.h (enum type_pieces): Add tp_kind.
8321         * std-operator.def: Add UNOP_KIND.
8322
8323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * f-exp.y (f_parse): Set yydebug.
8326
8327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8328
8329         * f-lang.c (evaluate_subexp_f): New function.
8330         (exp_descriptor_f): New global.
8331         (f_language_defn): Use exp_descriptor_f instead of
8332         exp_descriptor_standard.
8333
8334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8335
8336         * f-exp.y (struct token): Add comments.
8337         (dot_ops): Remove uppercase versions and the end marker.
8338         (f77_keywords): Likewise.
8339         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8340         entries in the dot_ops array are case insensitive, and use
8341         strncasecmp to compare strings.  Also some whitespace cleanup in
8342         this area.  Similar for the f77_keywords array, except entries in
8343         this list might be case sensitive.
8344
8345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8346
8347         * f-exp.y (struct f77_boolean_val): Add comments.
8348         (boolean_values): Remove uppercase versions, and end marker.
8349         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8350         and use strncasecmp to achieve case insensitivity.  Additionally,
8351         perform whitespace cleanup around this code.
8352
8353 2019-03-06  Tom Tromey  <tromey@adacore.com>
8354
8355         * remote-sim.c (gdbsim_target_open): Use result of
8356         gdb_argv::release.
8357
8358 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8359         Dirk Schubert  <dirk.schubert@arm.com>
8360         Chris January  <chris.january@arm.com>
8361
8362         * eval.c (evaluate_subexp_standard): Call Fortran argument
8363         wrapping logic.
8364         * f-lang.c (struct value): A value which can be passed into a
8365         Fortran function call.
8366         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8367         where appropriate.
8368         (struct type): Value ready for a Fortran function call.
8369         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8370         is needed.
8371         * f-lang.h (fortran_argument_convert): Declaration.
8372         (fortran_preserve_arg_pointer): Declaration.
8373         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8374
8375 2019-03-05  Tom Tromey  <tromey@adacore.com>
8376
8377         * python/py-prettyprint.c (print_string_repr): Remove #if.
8378         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8379
8380 2019-03-05  Tom Tromey  <tromey@adacore.com>
8381
8382         * target.c (the_dummy_target): Move later.  Change type to
8383         "dummy_target".
8384         (initialize_targets): Don't initialize the_dummy_target.
8385
8386 2019-03-05  Tom Tromey  <tromey@adacore.com>
8387
8388         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8389         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8390
8391 2019-03-05  Tom Tromey  <tromey@adacore.com>
8392
8393         * windows-nat.c (windows_nat_target::attach)
8394         (windows_nat_target::detach): Don't call gdb_flush.
8395         * valprint.c (generic_val_print, val_print, val_print_string):
8396         Don't call gdb_flush.
8397         * utils.c (defaulted_query): Don't call gdb_flush.
8398         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8399         * target.c (target_announce_detach): Don't call gdb_flush.
8400         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8401         * remote.c (extended_remote_target::attach): Don't call
8402         gdb_flush.
8403         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8404         * printcmd.c (do_examine): Don't call gdb_flush.
8405         (info_display_command): Don't call gdb_flush.
8406         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8407         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8408         * memattr.c (info_mem_command): Don't call gdb_flush.
8409         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8410         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8411         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8412         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8413         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8414         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8415         (gnu_nat_target::detach): Don't call gdb_flush.
8416         * f-valprint.c (f_val_print): Don't call gdb_flush.
8417         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8418         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8419         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8420         gdb_flush.
8421         * c-valprint.c (c_val_print): Don't call gdb_flush.
8422         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8423
8424 2019-03-05  Tom Tromey  <tromey@adacore.com>
8425
8426         * varobj.c (update_dynamic_varobj_children): Update.
8427         (install_default_visualizer): Use reset, not release.
8428         * value.c (set_internalvar): Update.
8429         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8430         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8431         ATTRIBUTE_UNUSED_RESULT.
8432
8433 2019-03-05  Tom Tromey  <tromey@adacore.com>
8434
8435         * remote.c (class scoped_remote_fd) <release>: Add
8436         ATTRIBUTE_UNUSED_RESULT.
8437
8438 2019-03-05  Tom Tromey  <tromey@adacore.com>
8439
8440         * macroexp.c (struct macro_buffer) <release>: Add
8441         ATTRIBUTE_UNUSED_RESULT.
8442
8443 2019-03-05  Tom Tromey  <tromey@adacore.com>
8444
8445         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8446         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8447         ATTRIBUTE_UNUSED_RESULT.
8448
8449 2019-03-05  Tom Tromey  <tromey@adacore.com>
8450
8451         * common/scoped_fd.h (class scoped_fd) <release>: Add
8452         ATTRIBUTE_UNUSED_RESULT.
8453
8454 2019-03-05  Tom Tromey  <tromey@adacore.com>
8455
8456         * parser-defs.h (struct parser_state) <release>: Add
8457         ATTRIBUTE_UNUSED_RESULT.
8458
8459 2019-03-05  Tom Tromey  <tromey@adacore.com>
8460
8461         * utils.h (class gdb_argv) <release>: Add
8462         ATTRIBUTE_UNUSED_RESULT.
8463         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8464
8465 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8466
8467         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8468         for-loop range, to avoid compiler warnings.
8469
8470         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8471         avoid compiler warnings about unused variables.
8472
8473         * NEWS: Mention end of support for native debugging on MS-Windows
8474         before XP.
8475
8476         PR gdb/24292
8477         * common/netstuff.c:
8478         * gdbserver/gdbreplay.c
8479         * gdbserver/remote-utils.c:
8480         * ser-tcp.c:
8481         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8482         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8483         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8484         'getaddrinfo' and 'freeaddrinfo' were not available before
8485         Windows XP, and mingw.org's MinGW headers by default define
8486         _WIN32_WINNT to 0x500.
8487
8488 2019-03-01  Gary Benson <gbenson@redhat.com>
8489
8490         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8491
8492 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8493             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8494
8495         PR gdb/8527
8496         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8497         set_sigint_trap, clear_sigint_trap.
8498
8499 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8500
8501         * target.c (target_detach): Clear the regcache and the
8502         frame cache.
8503
8504 2019-02-27  Pedro Alves  <palves@redhat.com>
8505
8506         * utils.c (set_screen_size): When we cap the height/width sizes,
8507         tweak the corresponding command variable to show "unlimited":
8508
8509 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8510             Pedro Alves  <palves@redhat.com>
8511
8512         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8513         before calling rl_set_screen_size.
8514
8515 2019-02-27  Tom Tromey  <tromey@adacore.com>
8516
8517         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8518         define.
8519         * python/py-value.c: Remove Python 2.4 workaround.
8520         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8521         workaround.
8522         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8523         Python 2.4 workaround.
8524         * python/python-internal.h: Remove Python 2.4 comment.
8525         (Py_ssize_t): Don't define.
8526         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8527         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8528         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8529         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8530         * python/python.c (do_start_initialization): Remove Python 2.4
8531         workaround.
8532         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8533         (print_children): Remove Python 2.4 workaround.
8534         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8535         workaround.
8536         (CHARBUFFERPROC_NAME): Remove.
8537         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8538         Python 2.4 workaround.
8539
8540 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8541
8542         * NEWS: Note minimum Python version.
8543
8544 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8545
8546         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8547         code from these functions.  Remove corresponding ifdefs.  Use
8548         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8549         Remove gotos and target of gotos.
8550         (infpy_search_memory): Likewise.
8551
8552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8555         (hppa_gdbarch_init): Don't register deleted functions with
8556         gdbarch.
8557
8558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8559
8560         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8561         (h8300_unwind_sp): Delete.
8562         (h8300_dummy_id): Delete.
8563         (h8300_gdbarch_init): Don't register deleted functions with
8564         gdbarch.
8565
8566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8567
8568         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8569         (ft32_unwind_pc): Delete.
8570         (ft32_unwind_sp): Delete.
8571         (ft32_gdbarch_init): Don't register deleted functions with
8572         gdbarch.
8573
8574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8577         (frv_unwind_pc): Delete.
8578         (frv_unwind_sp): Delete.
8579         (frv_gdbarch_init): Don't register deleted functions with
8580         gdbarch.
8581
8582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8583
8584         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8585         (riscv_unwind_pc): Delete.
8586         (riscv_unwind_sp): Delete.
8587         (riscv_gdbarch_init): Don't register deleted functions with
8588         gdbarch.
8589
8590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8591
8592         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8593         (csky_unwind_pc): Delete.
8594         (csky_unwind_sp): Delete.
8595         (csky_gdbarch_init): Don't register deleted functions with
8596         gdbarch.
8597
8598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8599
8600         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8601         (cris_unwind_pc): Delete.
8602         (cris_unwind_sp): Delete.
8603         (cris_gdbarch_init): Don't register deleted functions with
8604         gdbarch.
8605
8606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8607
8608         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8609         (bfin_unwind_pc): Delete.
8610         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8611
8612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8613
8614         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8615         (arm_unwind_pc): Delete.
8616         (arm_unwind_sp): Delete.
8617         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8618
8619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8620
8621         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8622         (arc_unwind_pc): Delete.
8623         (arc_unwind_sp): Delete.
8624         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8625
8626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8627
8628         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8629         (alpha_unwind_pc): Delete.
8630         (alpha_gdbarch_init): Don't register deleted functions with
8631         gdbarch.
8632
8633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8634
8635         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8636         (aarch64_unwind_pc): Delete.
8637         (aarch64_unwind_sp): Delete.
8638         (aarch64_gdbarch_init): Don't register deleted functions with
8639         gdbarch.
8640
8641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8642
8643         * gdbtypes.c (type_align): Don't consider static members when
8644         computing structure alignment.
8645
8646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8649         return 0 for other types.
8650         * arch-utils.c (default_type_align): Always return 0.
8651         * gdbarch.h: Regenerate.
8652         * gdbarch.sh (type_align): Extend comment.
8653         * gdbtypes.c (type_align): Add additional comments, always call
8654         gdbarch_type_align before applying the default rules.
8655         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8656         generic code will then apply a suitable default.
8657         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8658         types, return 0 for other types.
8659
8660 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8661
8662         * NEWS: Create a new section for the next release branch.
8663         Rename the section of the current branch, now that it has
8664         been cut.
8665
8666 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8667
8668         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8669         * version.in: Bump version to 8.3.50.DATE-git.
8670
8671 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8672
8673         * aix-thread.c (ptid_cmp): Remove unused variable.
8674         (get_signaled_thread): Likewise.
8675         (store_regs_user_thread): Likewise.
8676         (store_regs_kernel_thread): Likewise.
8677         (fetch_regs_kernel_thread): Remove shadowed variable.
8678
8679 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8680
8681         * features/riscv/32bit-cpu.xml: Add register numbers.
8682         * features/riscv/32bit-fpu.c: Regenerate.
8683         * features/riscv/32bit-fpu.xml: Add register numbers.
8684         * features/riscv/64bit-cpu.xml: Add register numbers.
8685         * features/riscv/64bit-fpu.c: Regenerate.
8686         * features/riscv/64bit-fpu.xml: Add register numbers.
8687
8688 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8689
8690         * NEWS: Mention two argument form of gdb.Value constructor.
8691         * python/py-value.c (convert_buffer_and_type_to_value): New
8692         function.
8693         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8694         Add support for handling an optional second argument.  Call
8695         convert_buffer_and_type_to_value as appropriate.
8696         * python/python-internal.h (Py_buffer_deleter): New struct.
8697         (Py_buffer_up): New typedef.
8698
8699 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8700
8701         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8702         instead of releasing ownership.
8703
8704 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8705
8706         * dwarf2read.c (open_and_init_dwp_file): Call
8707         elf_numsections instead of bfd_count_sections to initialize
8708         dwp_file->num_sections.
8709
8710 2019-02-25  Tom Tromey  <tromey@adacore.com>
8711
8712         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8713
8714 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8715
8716         * gcore.in: Add '--readnever' option when invoking GDB.
8717
8718 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8719
8720         * MAINTAINERS: Update my email address.
8721
8722 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8723
8724         * build-id.c (build_id_to_debug_bfd_1): New function.
8725         (build_id_to_debug_bfd): Look for separate debug file in
8726         sysroot.
8727
8728 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * gdbarch.sh: Update the copyright year range that is placed into
8731         generated files.
8732
8733 2019-02-22  Keith Seitz  <keiths@redhat.com>
8734
8735         PR symtab/23853
8736         * linespec.c (create_sals_line_offset): Search for the default
8737         symtab's filename instead of its fullname.
8738
8739 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8740
8741         * NEWS: Update style defaults.
8742
8743 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8744
8745         * main.c (captured_main_1): Disable styling in batch mode.
8746
8747 2019-02-20  Tom Tromey  <tom@tromey.com>
8748
8749         * symtab.c (symtab_symbol_info): Fix typos.
8750
8751 2019-02-20  Tom Tromey  <tromey@adacore.com>
8752
8753         * findcmd.c (_initialize_mem_search): Use upper case for
8754         metasyntactic variables.
8755
8756 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8757
8758         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8759         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8760
8761 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8762
8763         * top.h (source_file_name): Change to std::string.
8764         * top.c (source_file_name): Likewise.
8765         (command_line_input): Adjust.
8766         * cli/cli-script.c (script_from_file): Adjust.
8767
8768 2019-02-19  Tom Tromey  <tromey@adacore.com>
8769
8770         * ravenscar-thread.c
8771         (ravenscar_thread_target::update_thread_list): Don't call
8772         ada_build_task_list.
8773         * ada-lang.h (ada_build_task_list): Don't declare.
8774         * ada-tasks.c (struct ada_tasks_inferior_data)
8775         <task_list_valid_p>: Now bool.
8776         (read_known_tasks, ada_task_list_changed)
8777         (ada_tasks_invalidate_inferior_data): Update.
8778         (read_known_tasks_array): Return bool.
8779         (read_known_tasks_list): Likewise.
8780         (read_known_tasks): Return void.
8781         (ada_build_task_list): Now static.
8782
8783 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8784
8785         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8786         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8787
8788 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8789
8790         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8791         variant for ada_tasks_pspace_data_handle and
8792         ada_tasks_inferior_data_handle.
8793         (ada_tasks_pspace_data_cleanup): New function.
8794         (ada_tasks_inferior_data_cleanup): New function.
8795
8796 2019-02-17  Tom Tromey  <tom@tromey.com>
8797
8798         * macrotab.h (macro_source_fullname): Return a std::string.
8799         * macrotab.c (macro_include, check_for_redefinition)
8800         (macro_undef, macro_lookup_definition, foreach_macro)
8801         (foreach_macro_in_scope): Update.
8802         (macro_source_fullname): Return a std::string.
8803         * macrocmd.c (show_pp_source_pos): Update.
8804
8805 2019-02-17  Tom Tromey  <tom@tromey.com>
8806
8807         * macrocmd.c (show_pp_source_pos): Style the file names.
8808
8809 2019-02-17  Tom Tromey  <tom@tromey.com>
8810
8811         PR tui/24197:
8812         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8813
8814 2019-02-17  Tom Tromey  <tom@tromey.com>
8815
8816         * ada-lang.c (user_select_syms): Use filtered printing.
8817         * utils.c (wrap_style): New global.
8818         (desired_style): Remove.
8819         (emit_style_escape): Add stream parameter.
8820         (set_output_style, reset_terminal_style, prompt_for_continue):
8821         Update.
8822         (flush_wrap_buffer): Only flush gdb_stdout.
8823         (wrap_here): Set wrap_style.
8824         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8825         treat escape sequences as a character.  Change when wrap buffer is
8826         flushed.
8827         (fputs_styled): Do not set the output style when the default is
8828         requested.
8829         * ui-style.h (struct ui_file_style) <is_default>: New method.
8830         * source.c (print_source_lines_base): Emit escape sequences in one
8831         piece.
8832
8833 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8834
8835         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8836         integers and enumeration types.
8837
8838 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8839
8840         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8841         instead of lookup_symbol_in_language
8842         (do_exact_match): New function.
8843         (ada_get_symbol_name_matcher): Return do_exact_match when
8844         doing a verbatim match.
8845
8846 2019-02-15  Tom Tromey  <tromey@adacore.com>
8847
8848         * ravenscar-thread.c (ravenscar_thread_target::resume)
8849         (ravenscar_thread_target::wait): Special case wildcard requests.
8850
8851 2019-02-15  Tom Tromey  <tromey@adacore.com>
8852
8853         * ravenscar-thread.c (base_ptid): Remove.
8854         (struct ravenscar_thread_target) <close>: New method.
8855         <m_base_ptid>: New member.
8856         <update_inferior_ptid, active_task, task_is_currently_active,
8857         runtime_initialized>: Declare methods.
8858         <ravenscar_thread_target>: Add constructor.
8859         (ravenscar_thread_target::task_is_currently_active)
8860         (ravenscar_thread_target::update_inferior_ptid)
8861         (ravenscar_runtime_initialized): Rename.  Now methods.
8862         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8863         (ravenscar_thread_target::update_thread_list): Update.
8864         (ravenscar_thread_target::active_task): Now method.
8865         (ravenscar_thread_target::store_registers)
8866         (ravenscar_thread_target::prepare_to_store)
8867         (ravenscar_thread_target::prepare_to_store)
8868         (ravenscar_thread_target::mourn_inferior): Update.
8869         (ravenscar_inferior_created): Use "new" to create target.
8870         (ravenscar_thread_target::get_ada_task_ptid): Update.
8871         (_initialize_ravenscar): Don't initialize base_ptid.
8872         (ravenscar_ops): Remove global.
8873
8874 2019-02-15  Tom Tromey  <tromey@adacore.com>
8875
8876         * target.h (push_target): Declare new overload.
8877         * target.c (push_target): New overload, taking an rvalue reference.
8878         * remote.c (remote_target::open_1): Use push_target overload.
8879         * corelow.c (core_target_open): Use push_target overload.
8880
8881 2019-02-15  Tom Tromey  <tromey@adacore.com>
8882
8883         * ravenscar-thread.c (is_ravenscar_task)
8884         (ravenscar_task_is_currently_active): Return bool.
8885         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8886         (_initialize_ravenscar): Remove "(void)".
8887         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8888         Return bool.
8889
8890 2019-02-15  Tom Tromey  <tromey@adacore.com>
8891
8892         * ravenscar-thread.c (ravenscar_runtime_initializer)
8893         (has_ravenscar_runtime, get_running_thread_id)
8894         (ravenscar_thread_target::resume): Fix indentation.
8895
8896 2019-02-15  Tom Tromey  <tromey@adacore.com>
8897
8898         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8899         from ravenscar_arch_ops.
8900         (sparc_ravenscar_ops::fetch_registers)
8901         (sparc_ravenscar_ops::store_registers): Now methods.
8902         (sparc_ravenscar_prepare_to_store): Remove.
8903         (sparc_ravenscar_ops): Redefine.
8904         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8905         methods and destructor.  Remove members.
8906         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8907         (ravenscar_thread_target::store_registers)
8908         (ravenscar_thread_target::prepare_to_store): Update.
8909         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8910         Remove.
8911         (struct ppc_ravenscar_powerpc_ops): Derive from
8912         ravenscar_arch_ops.
8913         (ppc_ravenscar_powerpc_ops::fetch_registers)
8914         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8915         (ppc_ravenscar_powerpc_ops): Redefine.
8916         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8917         (ppc_ravenscar_e500_ops::fetch_registers)
8918         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8919         (ppc_ravenscar_e500_ops): Redefine.
8920         * aarch64-ravenscar-thread.c
8921         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8922         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8923         (aarch64_ravenscar_fetch_registers)
8924         (aarch64_ravenscar_store_registers): Now methods.
8925         (aarch64_ravenscar_ops): Redefine.
8926
8927 2019-02-15  Tom Tromey  <tromey@adacore.com>
8928
8929         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8930         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8931         (ravenscar_thread_target::stopped_by_watchpoint)
8932         (ravenscar_thread_target::stopped_data_address)
8933         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8934
8935 2019-02-15  Tom Tromey  <tromey@adacore.com>
8936
8937         * ravenscar-thread.c: Fix some typos.
8938
8939 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8940             Tom Tromey  <tromey@adacore.com>
8941
8942         * ada-lang.c (ada_exception_sal): Change addr_string to a
8943         std::string.
8944         (create_ada_exception_catchpoint): Update.
8945
8946 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8947             Tom Tromey  <tromey@adacore.com>
8948
8949         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8950         (bp_location_ops): Remove.
8951         (base_breakpoint_allocate_location): Update.
8952         (free_bp_location): Update.
8953         * ada-lang.c (class ada_catchpoint_location)
8954         <ada_catchpoint_location>: Remove ops parameter.
8955         (ada_catchpoint_location_dtor): Remove.
8956         (ada_catchpoint_location_ops): Remove.
8957         (allocate_location_exception): Update.
8958         * breakpoint.h (struct bp_location_ops): Remove.
8959         (class bp_location) <bp_location>: Remove bp_location_ops
8960         parameter.
8961         <~bp_location>: Add destructor.
8962         <ops>: Remove.
8963
8964 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8965             Pedro Alves  <palves@redhat.com>
8966
8967         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8968         'PATH_MAX'.
8969
8970 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8971             Samuel Thibault  <samuel.thibault@gnu.org>
8972             Thomas Schwinge  <thomas@codesourcery.com>
8973
8974         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8975         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8976
8977 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8978
8979         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8980         (check_empty): Use "const char *".
8981
8982         * gnu-nat.c (gnu_nat_target::detach): Instead of
8983         'detach_inferior (pid)' call
8984         'detach_inferior (find_inferior_pid (pid))'.
8985
8986         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8987         'nat/fork-inferior.o'.
8988         * gnu-nat.c: #include "nat/fork-inferior.h".
8989
8990         * gnu-nat.c (gnu_nat_target::detach): Instead of
8991         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8992         * gnu-nat.h: #include "inf-child.h".
8993         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8994         'i386_gnu_nat_target::fetch_registers'.
8995         (gnu_store_registers): Rename/move to
8996         'i386_gnu_nat_target::store_registers'.
8997
8998         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8999         * gnu-nat.h (mach_thread_info): New function.
9000         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9001
9002         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9003
9004 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9005
9006         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9007
9008 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9009
9010         * windows-nat.c (windows_add_thread): Add new parameter
9011         "main_thread_p" with default value set to false.  Update
9012         function documentation as well as all callers.
9013         (windows_delete_thread): Likewise.
9014         (fake_create_process): Update call to windows_add_thread.
9015         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9016         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9017         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9018         call to windows_delete_thread.
9019
9020 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9021
9022         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9023
9024 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9025
9026         * symfile.c (find_separate_debug_file): Use canonical path of
9027         sysroot with child_path instead of gdb_sysroot if it is valid.
9028
9029 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9030
9031         * symfile.c (find_separate_debug_file): Use child_path to
9032         determine if an object file is under a sysroot.
9033
9034 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9035
9036         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9037         unittests/child-path-selftests.c.
9038         * common/pathstuff.c (child_path): New function.
9039         * common/pathstuff.h (child_path): New prototype.
9040         * unittests/child-path-selftests.c: New file.
9041
9042 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9043
9044         * symfile.c (find_separate_debug_file): Look for separate debug
9045         files in debug directories under the sysroot.
9046
9047 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9048
9049         * symtab.h (struct minimal_symbol data_p): New const method.
9050         (struct minimal_symbol text_p): Likewise.
9051         * symtab.c (output_source_filename): Use file name style
9052         to print file name.
9053         (print_symbol_info): Likewise.
9054         (print_msymbol_info): Use address style to print addresses.
9055         Use function name style to print executable text symbols.
9056         (expand_symtab_containing_pc): Use data_p.
9057         (find_pc_sect_compunit_symtab): Likewise.
9058
9059 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9060
9061         * breakpoint.c (describe_other_breakpoints): Use address style
9062         to print addresses.
9063         (say_where): Likewise.
9064
9065 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9066
9067         * ada-typeprint.c (print_func_type): Print function name
9068         style to print function name.
9069         * c-typeprint.c (c_print_type_1): Likewise.
9070
9071 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9072
9073         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9074         for execve.
9075
9076 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9077
9078         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9079         type_stack.
9080
9081 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9082
9083         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9084         TYPE_CODE_REF types.
9085
9086 2019-02-08  Jim Wilson  <jimw@sifive.com>
9087
9088         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9089         (riscv_linux_fregset): New.
9090         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9091
9092 2019-02-07  Tom Tromey  <tom@tromey.com>
9093
9094         * thread.c (thread_cancel_execution_command): Update.
9095         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9096         methods.
9097         (struct thread_fsm_ops): Remove.
9098         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9099         (thread_fsm_should_stop, thread_fsm_return_value)
9100         (thread_fsm_set_finished, thread_fsm_finished_p)
9101         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9102         Don't declare.
9103         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9104         * infrun.c (clear_proceed_status_thread)
9105         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9106         (print_stop_event): Update.
9107         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9108         Add constructor.
9109         (step_command_fsm_ops): Remove.
9110         (new_step_command_fsm): Remove.
9111         (step_1): Update.
9112         (step_command_fsm::should_stop): Rename from
9113         step_command_fsm_should_stop.
9114         (step_command_fsm::clean_up): Rename from
9115         step_command_fsm_clean_up.
9116         (step_command_fsm::do_async_reply_reason): Rename from
9117         step_command_fsm_async_reply_reason.
9118         (struct until_next_fsm): Inherit from thread_fsm.  Add
9119         constructor.
9120         (until_next_fsm_ops): Remove.
9121         (new_until_next_fsm): Remove.
9122         (until_next_fsm::should_stop): Rename from
9123         until_next_fsm_should_stop.
9124         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9125         (until_next_fsm::do_async_reply_reason): Rename from
9126         until_next_fsm_async_reply_reason.
9127         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9128         constructor.  Change type of breakpoint.
9129         (finish_command_fsm_ops): Remove.
9130         (new_finish_command_fsm): Remove.
9131         (finish_command_fsm::should_stop): Rename from
9132         finish_command_fsm_should_stop.
9133         (finish_command_fsm::clean_up): Rename from
9134         finish_command_fsm_clean_up.
9135         (finish_command_fsm::return_value): Rename from
9136         finish_command_fsm_return_value.
9137         (finish_command_fsm::do_async_reply_reason): Rename from
9138         finish_command_fsm_async_reply_reason.
9139         (finish_command): Update.
9140         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9141         Add constructor.
9142         (call_thread_fsm_ops): Remove.
9143         (call_thread_fsm::call_thread_fsm): Rename from
9144         new_call_thread_fsm.
9145         (call_thread_fsm::should_stop): Rename from
9146         call_thread_fsm_should_stop.
9147         (call_thread_fsm::should_notify_stop): Rename from
9148         call_thread_fsm_should_notify_stop.
9149         (run_inferior_call, call_function_by_hand_dummy): Update.
9150         * cli/cli-interp.c (should_print_stop_to_console): Update.
9151         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9152         Add constructor.  Change type of location_breakpoint,
9153         caller_breakpoint.
9154         (until_break_fsm_ops): Remove.
9155         (new_until_break_fsm): Remove.
9156         (until_break_fsm::should_stop): Rename from
9157         until_break_fsm_should_stop.
9158         (until_break_fsm::clean_up): Rename from
9159         until_break_fsm_clean_up.
9160         (until_break_fsm::do_async_reply_reason): Rename from
9161         until_break_fsm_async_reply_reason.
9162         (until_break_command): Update.
9163         * thread-fsm.c: Remove.
9164         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9165
9166 2019-02-07  Tom Tromey  <tom@tromey.com>
9167
9168         * yy-remap.h: Add include guard.
9169         * xtensa-tdep.h: Add include guard.
9170         * xcoffread.h: Rename include guard.
9171         * varobj-iter.h: Add include guard.
9172         * tui/tui.h: Rename include guard.
9173         * tui/tui-winsource.h: Rename include guard.
9174         * tui/tui-wingeneral.h: Rename include guard.
9175         * tui/tui-windata.h: Rename include guard.
9176         * tui/tui-win.h: Rename include guard.
9177         * tui/tui-stack.h: Rename include guard.
9178         * tui/tui-source.h: Rename include guard.
9179         * tui/tui-regs.h: Rename include guard.
9180         * tui/tui-out.h: Rename include guard.
9181         * tui/tui-layout.h: Rename include guard.
9182         * tui/tui-io.h: Rename include guard.
9183         * tui/tui-hooks.h: Rename include guard.
9184         * tui/tui-file.h: Rename include guard.
9185         * tui/tui-disasm.h: Rename include guard.
9186         * tui/tui-data.h: Rename include guard.
9187         * tui/tui-command.h: Rename include guard.
9188         * tic6x-tdep.h: Add include guard.
9189         * target/waitstatus.h: Rename include guard.
9190         * target/wait.h: Rename include guard.
9191         * target/target.h: Rename include guard.
9192         * target/resume.h: Rename include guard.
9193         * target-float.h: Rename include guard.
9194         * stabsread.h: Add include guard.
9195         * rs6000-tdep.h: Add include guard.
9196         * riscv-fbsd-tdep.h: Add include guard.
9197         * regformats/regdef.h: Rename include guard.
9198         * record.h: Rename include guard.
9199         * python/python.h: Rename include guard.
9200         * python/python-internal.h: Rename include guard.
9201         * python/py-stopevent.h: Rename include guard.
9202         * python/py-ref.h: Rename include guard.
9203         * python/py-record.h: Rename include guard.
9204         * python/py-record-full.h: Rename include guard.
9205         * python/py-record-btrace.h: Rename include guard.
9206         * python/py-instruction.h: Rename include guard.
9207         * python/py-events.h: Rename include guard.
9208         * python/py-event.h: Rename include guard.
9209         * procfs.h: Add include guard.
9210         * proc-utils.h: Add include guard.
9211         * p-lang.h: Add include guard.
9212         * or1k-tdep.h: Rename include guard.
9213         * observable.h: Rename include guard.
9214         * nto-tdep.h: Rename include guard.
9215         * nat/x86-linux.h: Rename include guard.
9216         * nat/x86-linux-dregs.h: Rename include guard.
9217         * nat/x86-gcc-cpuid.h: Add include guard.
9218         * nat/x86-dregs.h: Rename include guard.
9219         * nat/x86-cpuid.h: Rename include guard.
9220         * nat/ppc-linux.h: Rename include guard.
9221         * nat/mips-linux-watch.h: Rename include guard.
9222         * nat/linux-waitpid.h: Rename include guard.
9223         * nat/linux-ptrace.h: Rename include guard.
9224         * nat/linux-procfs.h: Rename include guard.
9225         * nat/linux-osdata.h: Rename include guard.
9226         * nat/linux-nat.h: Rename include guard.
9227         * nat/linux-namespaces.h: Rename include guard.
9228         * nat/linux-btrace.h: Rename include guard.
9229         * nat/glibc_thread_db.h: Rename include guard.
9230         * nat/gdb_thread_db.h: Rename include guard.
9231         * nat/gdb_ptrace.h: Rename include guard.
9232         * nat/fork-inferior.h: Rename include guard.
9233         * nat/amd64-linux-siginfo.h: Rename include guard.
9234         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9235         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9236         * nat/aarch64-linux.h: Rename include guard.
9237         * nat/aarch64-linux-hw-point.h: Rename include guard.
9238         * mn10300-tdep.h: Add include guard.
9239         * mips-linux-tdep.h: Add include guard.
9240         * mi/mi-parse.h: Rename include guard.
9241         * mi/mi-out.h: Rename include guard.
9242         * mi/mi-main.h: Rename include guard.
9243         * mi/mi-interp.h: Rename include guard.
9244         * mi/mi-getopt.h: Rename include guard.
9245         * mi/mi-console.h: Rename include guard.
9246         * mi/mi-common.h: Rename include guard.
9247         * mi/mi-cmds.h: Rename include guard.
9248         * mi/mi-cmd-break.h: Rename include guard.
9249         * m2-lang.h: Add include guard.
9250         * location.h: Rename include guard.
9251         * linux-record.h: Rename include guard.
9252         * linux-nat.h: Add include guard.
9253         * linux-fork.h: Add include guard.
9254         * i386-darwin-tdep.h: Rename include guard.
9255         * hppa-linux-offsets.h: Add include guard.
9256         * guile/guile.h: Rename include guard.
9257         * guile/guile-internal.h: Rename include guard.
9258         * gnu-nat.h: Rename include guard.
9259         * gdb-stabs.h: Rename include guard.
9260         * frv-tdep.h: Add include guard.
9261         * f-lang.h: Add include guard.
9262         * event-loop.h: Add include guard.
9263         * darwin-nat.h: Rename include guard.
9264         * cp-abi.h: Rename include guard.
9265         * config/sparc/nm-sol2.h: Rename include guard.
9266         * config/nm-nto.h: Rename include guard.
9267         * config/nm-linux.h: Add include guard.
9268         * config/i386/nm-i386gnu.h: Rename include guard.
9269         * config/djgpp/nl_types.h: Rename include guard.
9270         * config/djgpp/langinfo.h: Rename include guard.
9271         * compile/gcc-cp-plugin.h: Add include guard.
9272         * compile/gcc-c-plugin.h: Add include guard.
9273         * compile/compile.h: Rename include guard.
9274         * compile/compile-object-run.h: Rename include guard.
9275         * compile/compile-object-load.h: Rename include guard.
9276         * compile/compile-internal.h: Rename include guard.
9277         * compile/compile-cplus.h: Rename include guard.
9278         * compile/compile-c.h: Rename include guard.
9279         * common/xml-utils.h: Rename include guard.
9280         * common/x86-xstate.h: Rename include guard.
9281         * common/version.h: Rename include guard.
9282         * common/vec.h: Rename include guard.
9283         * common/tdesc.h: Rename include guard.
9284         * common/selftest.h: Rename include guard.
9285         * common/scoped_restore.h: Rename include guard.
9286         * common/scoped_mmap.h: Rename include guard.
9287         * common/scoped_fd.h: Rename include guard.
9288         * common/safe-iterator.h: Rename include guard.
9289         * common/run-time-clock.h: Rename include guard.
9290         * common/refcounted-object.h: Rename include guard.
9291         * common/queue.h: Rename include guard.
9292         * common/ptid.h: Rename include guard.
9293         * common/print-utils.h: Rename include guard.
9294         * common/preprocessor.h: Rename include guard.
9295         * common/pathstuff.h: Rename include guard.
9296         * common/observable.h: Rename include guard.
9297         * common/netstuff.h: Rename include guard.
9298         * common/job-control.h: Rename include guard.
9299         * common/host-defs.h: Rename include guard.
9300         * common/gdb_wait.h: Rename include guard.
9301         * common/gdb_vecs.h: Rename include guard.
9302         * common/gdb_unlinker.h: Rename include guard.
9303         * common/gdb_unique_ptr.h: Rename include guard.
9304         * common/gdb_tilde_expand.h: Rename include guard.
9305         * common/gdb_sys_time.h: Rename include guard.
9306         * common/gdb_string_view.h: Rename include guard.
9307         * common/gdb_splay_tree.h: Rename include guard.
9308         * common/gdb_setjmp.h: Rename include guard.
9309         * common/gdb_ref_ptr.h: Rename include guard.
9310         * common/gdb_optional.h: Rename include guard.
9311         * common/gdb_locale.h: Rename include guard.
9312         * common/gdb_assert.h: Rename include guard.
9313         * common/filtered-iterator.h: Rename include guard.
9314         * common/filestuff.h: Rename include guard.
9315         * common/fileio.h: Rename include guard.
9316         * common/environ.h: Rename include guard.
9317         * common/common-utils.h: Rename include guard.
9318         * common/common-types.h: Rename include guard.
9319         * common/common-regcache.h: Rename include guard.
9320         * common/common-inferior.h: Rename include guard.
9321         * common/common-gdbthread.h: Rename include guard.
9322         * common/common-exceptions.h: Rename include guard.
9323         * common/common-defs.h: Rename include guard.
9324         * common/common-debug.h: Rename include guard.
9325         * common/cleanups.h: Rename include guard.
9326         * common/buffer.h: Rename include guard.
9327         * common/btrace-common.h: Rename include guard.
9328         * common/break-common.h: Rename include guard.
9329         * cli/cli-utils.h: Rename include guard.
9330         * cli/cli-style.h: Rename include guard.
9331         * cli/cli-setshow.h: Rename include guard.
9332         * cli/cli-script.h: Rename include guard.
9333         * cli/cli-interp.h: Rename include guard.
9334         * cli/cli-decode.h: Rename include guard.
9335         * cli/cli-cmds.h: Rename include guard.
9336         * charset-list.h: Add include guard.
9337         * buildsym-legacy.h: Rename include guard.
9338         * bfin-tdep.h: Add include guard.
9339         * ax.h: Rename include guard.
9340         * arm-linux-tdep.h: Add include guard.
9341         * arm-fbsd-tdep.h: Add include guard.
9342         * arch/xtensa.h: Rename include guard.
9343         * arch/tic6x.h: Add include guard.
9344         * arch/i386.h: Add include guard.
9345         * arch/arm.h: Rename include guard.
9346         * arch/arm-linux.h: Rename include guard.
9347         * arch/arm-get-next-pcs.h: Rename include guard.
9348         * arch/amd64.h: Add include guard.
9349         * arch/aarch64-insn.h: Rename include guard.
9350         * arch-utils.h: Rename include guard.
9351         * annotate.h: Add include guard.
9352         * amd64-darwin-tdep.h: Rename include guard.
9353         * aarch64-linux-tdep.h: Add include guard.
9354         * aarch64-fbsd-tdep.h: Add include guard.
9355         * aarch32-linux-nat.h: Add include guard.
9356
9357 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9358
9359         * macrotab.c (macro_define_internal): New function that
9360         factorizes macro_define_object_internal and macro_define_function
9361         code.
9362         (macro_define_object_internal): Use macro_define_internal.
9363         (macro_define_function): Likewise.
9364
9365 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9366
9367         * macrocmd.c (extract_identifier): Return
9368         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9369         callers.
9370
9371 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9372
9373         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9374
9375 2019-02-05  Tom Tromey  <tom@tromey.com>
9376
9377         * target.c (target_stack::unpush): Move assertion earlier.
9378
9379 2019-01-30  Tom Tromey  <tom@tromey.com>
9380
9381         PR python/23615:
9382         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9383         (gdbpy_parse_and_eval): Likewise.
9384         * python/python-internal.h (gdbpy_allow_threads): New class.
9385
9386 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9387
9388         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9389         (aarch64_fbsd_fpregmap): Move earlier.
9390         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9391         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9392         instead of individual calls to trad_frame_set_reg_addr.
9393         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9394         earlier.
9395         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9396         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9397         instead of individual calls to trad_frame_set_reg_addr.
9398
9399 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9400
9401         * CONTRIBUTE: Replace contribution list with wiki link.
9402
9403 2019-01-25  Tom Tromey  <tom@tromey.com>
9404
9405         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9406
9407 2019-01-25  Tom Tromey  <tom@tromey.com>
9408
9409         * xtensa-linux-nat.c: Fix common/ includes.
9410         * xml-support.h: Fix common/ includes.
9411         * xml-support.c: Fix common/ includes.
9412         * x86-linux-nat.c: Fix common/ includes.
9413         * windows-nat.c: Fix common/ includes.
9414         * varobj.h: Fix common/ includes.
9415         * varobj.c: Fix common/ includes.
9416         * value.c: Fix common/ includes.
9417         * valops.c: Fix common/ includes.
9418         * utils.c: Fix common/ includes.
9419         * unittests/xml-utils-selftests.c: Fix common/ includes.
9420         * unittests/utils-selftests.c: Fix common/ includes.
9421         * unittests/unpack-selftests.c: Fix common/ includes.
9422         * unittests/tracepoint-selftests.c: Fix common/ includes.
9423         * unittests/style-selftests.c: Fix common/ includes.
9424         * unittests/string_view-selftests.c: Fix common/ includes.
9425         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9426         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9427         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9428         * unittests/rsp-low-selftests.c: Fix common/ includes.
9429         * unittests/parse-connection-spec-selftests.c: Fix common/
9430         includes.
9431         * unittests/optional-selftests.c: Fix common/ includes.
9432         * unittests/offset-type-selftests.c: Fix common/ includes.
9433         * unittests/observable-selftests.c: Fix common/ includes.
9434         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9435         * unittests/memrange-selftests.c: Fix common/ includes.
9436         * unittests/memory-map-selftests.c: Fix common/ includes.
9437         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9438         * unittests/function-view-selftests.c: Fix common/ includes.
9439         * unittests/environ-selftests.c: Fix common/ includes.
9440         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9441         * unittests/common-utils-selftests.c: Fix common/ includes.
9442         * unittests/cli-utils-selftests.c: Fix common/ includes.
9443         * unittests/array-view-selftests.c: Fix common/ includes.
9444         * ui-file.c: Fix common/ includes.
9445         * tui/tui-io.c: Fix common/ includes.
9446         * tracepoint.h: Fix common/ includes.
9447         * tracepoint.c: Fix common/ includes.
9448         * tracefile-tfile.c: Fix common/ includes.
9449         * top.h: Fix common/ includes.
9450         * top.c: Fix common/ includes.
9451         * thread.c: Fix common/ includes.
9452         * target/waitstatus.h: Fix common/ includes.
9453         * target/waitstatus.c: Fix common/ includes.
9454         * target.h: Fix common/ includes.
9455         * target.c: Fix common/ includes.
9456         * target-memory.c: Fix common/ includes.
9457         * target-descriptions.c: Fix common/ includes.
9458         * symtab.h: Fix common/ includes.
9459         * symfile.c: Fix common/ includes.
9460         * stap-probe.c: Fix common/ includes.
9461         * spu-linux-nat.c: Fix common/ includes.
9462         * sparc-nat.c: Fix common/ includes.
9463         * source.c: Fix common/ includes.
9464         * solib.c: Fix common/ includes.
9465         * solib-target.c: Fix common/ includes.
9466         * ser-unix.c: Fix common/ includes.
9467         * ser-tcp.c: Fix common/ includes.
9468         * ser-pipe.c: Fix common/ includes.
9469         * ser-base.c: Fix common/ includes.
9470         * selftest-arch.c: Fix common/ includes.
9471         * s12z-tdep.c: Fix common/ includes.
9472         * rust-exp.y: Fix common/ includes.
9473         * rs6000-aix-tdep.c: Fix common/ includes.
9474         * riscv-tdep.c: Fix common/ includes.
9475         * remote.c: Fix common/ includes.
9476         * remote-notif.h: Fix common/ includes.
9477         * remote-fileio.h: Fix common/ includes.
9478         * remote-fileio.c: Fix common/ includes.
9479         * regcache.h: Fix common/ includes.
9480         * regcache.c: Fix common/ includes.
9481         * record-btrace.c: Fix common/ includes.
9482         * python/python.c: Fix common/ includes.
9483         * python/py-type.c: Fix common/ includes.
9484         * python/py-inferior.c: Fix common/ includes.
9485         * progspace.h: Fix common/ includes.
9486         * producer.c: Fix common/ includes.
9487         * procfs.c: Fix common/ includes.
9488         * proc-api.c: Fix common/ includes.
9489         * printcmd.c: Fix common/ includes.
9490         * ppc-linux-nat.c: Fix common/ includes.
9491         * parser-defs.h: Fix common/ includes.
9492         * osdata.c: Fix common/ includes.
9493         * obsd-nat.c: Fix common/ includes.
9494         * nat/x86-linux.c: Fix common/ includes.
9495         * nat/x86-linux-dregs.c: Fix common/ includes.
9496         * nat/x86-dregs.h: Fix common/ includes.
9497         * nat/x86-dregs.c: Fix common/ includes.
9498         * nat/ppc-linux.c: Fix common/ includes.
9499         * nat/mips-linux-watch.h: Fix common/ includes.
9500         * nat/mips-linux-watch.c: Fix common/ includes.
9501         * nat/linux-waitpid.c: Fix common/ includes.
9502         * nat/linux-ptrace.h: Fix common/ includes.
9503         * nat/linux-ptrace.c: Fix common/ includes.
9504         * nat/linux-procfs.c: Fix common/ includes.
9505         * nat/linux-personality.c: Fix common/ includes.
9506         * nat/linux-osdata.c: Fix common/ includes.
9507         * nat/linux-namespaces.c: Fix common/ includes.
9508         * nat/linux-btrace.h: Fix common/ includes.
9509         * nat/linux-btrace.c: Fix common/ includes.
9510         * nat/fork-inferior.c: Fix common/ includes.
9511         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9512         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9513         * nat/aarch64-linux.c: Fix common/ includes.
9514         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9515         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9516         * namespace.h: Fix common/ includes.
9517         * mips-linux-tdep.c: Fix common/ includes.
9518         * minsyms.c: Fix common/ includes.
9519         * mi/mi-parse.h: Fix common/ includes.
9520         * mi/mi-main.c: Fix common/ includes.
9521         * mi/mi-cmd-env.c: Fix common/ includes.
9522         * memrange.h: Fix common/ includes.
9523         * memattr.c: Fix common/ includes.
9524         * maint.h: Fix common/ includes.
9525         * maint.c: Fix common/ includes.
9526         * main.c: Fix common/ includes.
9527         * machoread.c: Fix common/ includes.
9528         * location.c: Fix common/ includes.
9529         * linux-thread-db.c: Fix common/ includes.
9530         * linux-nat.c: Fix common/ includes.
9531         * linux-fork.c: Fix common/ includes.
9532         * inline-frame.c: Fix common/ includes.
9533         * infrun.c: Fix common/ includes.
9534         * inflow.c: Fix common/ includes.
9535         * inferior.h: Fix common/ includes.
9536         * inferior.c: Fix common/ includes.
9537         * infcmd.c: Fix common/ includes.
9538         * inf-ptrace.c: Fix common/ includes.
9539         * inf-child.c: Fix common/ includes.
9540         * ia64-linux-nat.c: Fix common/ includes.
9541         * i387-tdep.c: Fix common/ includes.
9542         * i386-tdep.c: Fix common/ includes.
9543         * i386-linux-tdep.c: Fix common/ includes.
9544         * i386-linux-nat.c: Fix common/ includes.
9545         * i386-go32-tdep.c: Fix common/ includes.
9546         * i386-fbsd-tdep.c: Fix common/ includes.
9547         * i386-fbsd-nat.c: Fix common/ includes.
9548         * guile/scm-type.c: Fix common/ includes.
9549         * guile/guile.c: Fix common/ includes.
9550         * go32-nat.c: Fix common/ includes.
9551         * gnu-nat.c: Fix common/ includes.
9552         * gdbthread.h: Fix common/ includes.
9553         * gdbarch-selftests.c: Fix common/ includes.
9554         * gdb_usleep.c: Fix common/ includes.
9555         * gdb_select.h: Fix common/ includes.
9556         * gdb_bfd.c: Fix common/ includes.
9557         * gcore.c: Fix common/ includes.
9558         * fork-child.c: Fix common/ includes.
9559         * findvar.c: Fix common/ includes.
9560         * fbsd-nat.c: Fix common/ includes.
9561         * event-top.c: Fix common/ includes.
9562         * event-loop.c: Fix common/ includes.
9563         * dwarf2read.c: Fix common/ includes.
9564         * dwarf2loc.c: Fix common/ includes.
9565         * dwarf2-frame.c: Fix common/ includes.
9566         * dwarf-index-cache.c: Fix common/ includes.
9567         * dtrace-probe.c: Fix common/ includes.
9568         * disasm-selftests.c: Fix common/ includes.
9569         * defs.h: Fix common/ includes.
9570         * csky-tdep.c: Fix common/ includes.
9571         * cp-valprint.c: Fix common/ includes.
9572         * cp-support.h: Fix common/ includes.
9573         * cp-support.c: Fix common/ includes.
9574         * corelow.c: Fix common/ includes.
9575         * completer.h: Fix common/ includes.
9576         * completer.c: Fix common/ includes.
9577         * compile/compile.c: Fix common/ includes.
9578         * compile/compile-loc2c.c: Fix common/ includes.
9579         * compile/compile-cplus-types.c: Fix common/ includes.
9580         * compile/compile-cplus-symbols.c: Fix common/ includes.
9581         * command.h: Fix common/ includes.
9582         * cli/cli-dump.c: Fix common/ includes.
9583         * cli/cli-cmds.c: Fix common/ includes.
9584         * charset.c: Fix common/ includes.
9585         * build-id.c: Fix common/ includes.
9586         * btrace.h: Fix common/ includes.
9587         * btrace.c: Fix common/ includes.
9588         * breakpoint.h: Fix common/ includes.
9589         * breakpoint.c: Fix common/ includes.
9590         * ax.h: 
9591         (enum agent_op): Fix common/ includes.
9592         * ax-general.c (struct aop_map): Fix common/ includes.
9593         * ax-gdb.c: Fix common/ includes.
9594         * auxv.c: Fix common/ includes.
9595         * auto-load.c: Fix common/ includes.
9596         * arm-tdep.c: Fix common/ includes.
9597         * arch/riscv.c: Fix common/ includes.
9598         * arch/ppc-linux-common.c: Fix common/ includes.
9599         * arch/i386.c: Fix common/ includes.
9600         * arch/arm.c: Fix common/ includes.
9601         * arch/arm-linux.c: Fix common/ includes.
9602         * arch/arm-get-next-pcs.c: Fix common/ includes.
9603         * arch/amd64.c: Fix common/ includes.
9604         * arch/aarch64.c: Fix common/ includes.
9605         * arch/aarch64-insn.c: Fix common/ includes.
9606         * arch-utils.c: Fix common/ includes.
9607         * amd64-windows-tdep.c: Fix common/ includes.
9608         * amd64-tdep.c: Fix common/ includes.
9609         * amd64-sol2-tdep.c: Fix common/ includes.
9610         * amd64-obsd-tdep.c: Fix common/ includes.
9611         * amd64-nbsd-tdep.c: Fix common/ includes.
9612         * amd64-linux-tdep.c: Fix common/ includes.
9613         * amd64-linux-nat.c: Fix common/ includes.
9614         * amd64-fbsd-tdep.c: Fix common/ includes.
9615         * amd64-fbsd-nat.c: Fix common/ includes.
9616         * amd64-dicos-tdep.c: Fix common/ includes.
9617         * amd64-darwin-tdep.c: Fix common/ includes.
9618         * agent.c: Fix common/ includes.
9619         * ada-lang.h: Fix common/ includes.
9620         * ada-lang.c: Fix common/ includes.
9621         * aarch64-tdep.c: Fix common/ includes.
9622
9623 2019-01-25  Tom Tromey  <tom@tromey.com>
9624
9625         * common/create-version.sh: Use common/version.h.
9626
9627 2019-01-24  Pedro Alves  <palves@redhat.com>
9628
9629         * infrun.c (signal_stop, signal_print, signal_program)
9630         (signal_catch, signal_pass): Now arrays instead of pointers.
9631         (update_signals_program_target, do_target_resume)
9632         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9633         * linux-nat.c (linux_nat_target::pass_signals)
9634         (linux_nat_target::create_inferior, linux_nat_target::attach):
9635         Adjust.
9636         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9637         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9638         * procfs.c (procfs_target::pass_signals): Adjust.
9639         * record-full.c (record_full_target::resume): Adjust.
9640         * remote.c (remote_target::pass_signals)
9641         (remote_target::program_signals): Adjust.
9642         * target-debug.h (target_debug_print_signals): Now takes a
9643         gdb::array_view as parameter.  Adjust.
9644         * target.h (target_ops) <pass_signals, program_signals>: Replace
9645         pointer and length parameters with gdb::array_view.
9646         (target_pass_signals, target_program_signals): Likewise.
9647         * target-delegates.c: Regenerate.
9648
9649 2019-01-24  Pedro Alves  <palves@redhat.com>
9650
9651         * common/forward-scope-exit.h
9652         (forward_scope_exit::forward_scope_exit): Pass arguments to
9653         m_bind_function directly, instead of creating a std::bind and
9654         copying that.
9655
9656 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9657
9658         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9659         for static members.
9660         (pass_in_v_vfp_candidate): Likewise.
9661
9662 2019-01-23  Tom Tromey  <tom@tromey.com>
9663             Pedro Alves  <palves@redhat.com>
9664
9665         * regcache.c (class regcache_invalidator): Remove.
9666         (regcache::raw_write): Use make_scope_exit.
9667
9668 2019-01-23  Tom Tromey  <tom@tromey.com>
9669
9670         * ui-out.h (class ui_out_emit_type): Update comment.
9671
9672 2019-01-23  Tom Tromey  <tom@tromey.com>
9673
9674         * infrun.c (fetch_inferior_event): Update comment.
9675
9676 2019-01-23  Tom Tromey  <tom@tromey.com>
9677             Pedro Alves  <palves@redhat.com>
9678
9679         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9680         parameter.
9681         (fetch_inferior_event): Use SCOPE_EXIT.
9682
9683
9684 2019-01-23  Tom Tromey  <tom@tromey.com>
9685             Pedro Alves  <palves@redhat.com>
9686
9687         * infrun.c (disable_thread_events): Delete.
9688         (stop_all_threads): Use SCOPE_EXIT.
9689
9690 2019-01-23  Tom Tromey  <tom@tromey.com>
9691             Pedro Alves  <palves@redhat.com>
9692
9693         * symfile.c: Include forward-scope-exit.h.
9694         (clear_symtab_users_cleanup): Replace forward declaration with
9695         a FORWARD_SCOPE_EXIT.
9696         (syms_from_objfile_1): Use the forward_scope_exit and
9697         gdb::optional instead of cleanup_function.
9698         (reread_symbols): Use the forward_scope_exit instead of
9699         cleanup_function.
9700         (clear_symtab_users_cleanup): Remove function.
9701
9702 2019-01-23  Tom Tromey  <tom@tromey.com>
9703             Pedro Alves  <palves@redhat.com>
9704
9705         * linux-nat.c: Include scope-exit.h.
9706         (cleanup_target_stop): Remove.
9707         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9708         SCOPE_EXIT.
9709
9710 2019-01-23  Tom Tromey  <tom@tromey.com>
9711             Pedro Alves  <palves@redhat.com>
9712
9713         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9714         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9715
9716 2019-01-23  Tom Tromey  <tom@tromey.com>
9717             Andrew Burgess  <andrew.burgess@embecosm.com>
9718             Pedro Alves  <palves@redhat.com>
9719
9720         * infrun.c (fetch_inferior_event): Use scope_exit.
9721         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9722         * top.c (execute_command): Use scope_exit.
9723         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9724         * utils.c (do_bpstat_clear_actions_cleanup)
9725         (make_bpstat_clear_actions_cleanup): Remove.
9726
9727 2019-01-23  Tom Tromey  <tom@tromey.com>
9728             Pedro Alves  <palves@redhat.com>
9729
9730         * infrun.c: Include "common/scope-exit.h"
9731         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9732         (wait_for_inferior): Use SCOPE_EXIT.
9733         (fetch_inferior_event): Use scope_exit.
9734
9735 2019-01-23  Tom Tromey  <tom@tromey.com>
9736             Pedro Alves  <palves@redhat.com>
9737
9738         * breakpoint.c (create_breakpoint): Remove cleanup.
9739
9740 2019-01-23  Tom Tromey  <tom@tromey.com>
9741             Andrew Burgess  <andrew.burgess@embecosm.com>
9742             Pedro Alves  <palves@redhat.com>
9743
9744 2019-01-23  Pedro Alves  <palves@redhat.com>
9745
9746         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9747
9748 2019-01-23  Pedro Alves  <palves@redhat.com>
9749             Andrew Burgess  <andrew.burgess@embecosm.com>
9750
9751         * gdbthread.h: Include "common/forward-scope-exit.h".
9752         (scoped_finish_thread_state): Redefine custom class in terms of
9753         forward_scope_exit.
9754
9755 2019-01-23  Pedro Alves  <palves@redhat.com>
9756             Andrew Burgess  <andrew.burgess@embecosm.com>
9757
9758         * common/forward-scope-exit.h: New file.
9759
9760 2019-01-23  Pedro Alves  <palves@redhat.com>
9761             Andrew Burgess  <andrew.burgess@embecosm.com>
9762             Tom Tromey  <tom@tromey.com>
9763
9764         * common/scope-exit.h: New file.
9765
9766 2019-01-23  Pedro Alves  <palves@redhat.com>
9767
9768         * common/preprocessor.h (ESC): Rename to ...
9769         (ESC_PARENS): ... this.
9770         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9771         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9772
9773 2019-01-23  Tom Tromey  <tom@tromey.com>
9774
9775         * language.h (class scoped_switch_to_sym_language_if_auto):
9776         Initialize m_lang in both cases.
9777
9778 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9779
9780         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9781         with XCNEW.
9782
9783 2019-01-22  Tom Tromey  <tom@tromey.com>
9784
9785         * corelow.c: Do not include sys/file.h.
9786
9787 2019-01-22  Tom Tromey  <tom@tromey.com>
9788
9789         * tui/tui-wingeneral.h: Include gdb_curses.h.
9790
9791 2019-01-22  Tom Tromey  <tom@tromey.com>
9792
9793         * source-cache.h (class source_cache) <get_source_lines,
9794         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9795
9796 2019-01-22  Tom Tromey  <tom@tromey.com>
9797
9798         * remote-fileio.h (struct remote_target): Declare.
9799
9800 2019-01-22  Tom Tromey  <tom@tromey.com>
9801
9802         * python/py-arch.c: Do not include py-ref.h.
9803         * python/py-bpevent.c: Do not include py-ref.h.
9804         * python/py-cmd.c: Do not include py-ref.h.
9805         * python/py-continueevent.c: Do not include py-ref.h.
9806         * python/py-event.h: Do not include py-ref.h.
9807         * python/py-evtregistry.c: Do not include py-ref.h.
9808         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9809         * python/py-frame.c: Do not include py-ref.h.
9810         * python/py-framefilter.c: Do not include py-ref.h.
9811         * python/py-function.c: Do not include py-ref.h.
9812         * python/py-infevents.c: Do not include py-ref.h.
9813         * python/py-linetable.c: Do not include py-ref.h.
9814         * python/py-objfile.c: Do not include py-ref.h.
9815         * python/py-param.c: Do not include py-ref.h.
9816         * python/py-prettyprint.c: Do not include py-ref.h.
9817         * python/py-progspace.c: Do not include py-ref.h.
9818         * python/py-symbol.c: Do not include py-ref.h.
9819         * python/py-symtab.c: Do not include py-ref.h.
9820         * python/py-type.c: Do not include py-ref.h.
9821         * python/py-unwind.c: Do not include py-ref.h.
9822         * python/py-utils.c: Do not include py-ref.h.
9823         * python/py-value.c: Do not include py-ref.h.
9824         * python/py-varobj.c: Do not include py-ref.h.
9825         * python/py-xmethods.c: Do not include py-ref.h.
9826         * python/python.c: Do not include py-ref.h.
9827         * varobj.c: Do not include py-ref.h.
9828
9829 2019-01-22  Tom Tromey  <tom@tromey.com>
9830
9831         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9832         keyword for bcache.
9833
9834 2019-01-22  Tom Tromey  <tom@tromey.com>
9835
9836         * compile/compile-cplus-types.c: Remove a comment by #include.
9837
9838 2019-01-22  Tom Tromey  <tom@tromey.com>
9839
9840         * compile/gcc-c-plugin.h: Include compile-internal.h.
9841
9842 2019-01-22  Tom Tromey  <tom@tromey.com>
9843
9844         * stabsread.c (EXTERN): Do not define.
9845         (symnum, next_symbol_text_func, processing_gcc_compilation)
9846         (within_function, global_sym_chain, global_stabs)
9847         (previous_stab_code, this_object_header_files)
9848         (n_this_object_header_files)
9849         (n_allocated_this_object_header_files): Define.
9850         * stabsread.h (EXTERN): Never define.  Use "extern".
9851
9852 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9853
9854         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9855         history_value.
9856
9857 2019-01-21  Tom Tromey  <tom@tromey.com>
9858
9859         * ui-out.c: Fix includes.
9860         * tui/tui-source.c: Fix includes.
9861         * target.c: Fix includes.
9862         * remote.c: Fix includes.
9863         * regcache.c: Fix includes.
9864         * python/py-block.c: Fix includes.
9865         * printcmd.c: Fix includes.
9866         * or1k-tdep.c: Fix includes.
9867         * mi/mi-main.c: Fix includes.
9868         * m32r-tdep.c: Fix includes.
9869         * csky-tdep.c: Fix includes.
9870         * compile/compile-cplus-types.c: Fix includes.
9871         * cli/cli-interp.c: Fix includes.
9872
9873 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9874
9875         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9876         for padding.
9877
9878 2019-01-16  Tom Tromey  <tom@tromey.com>
9879
9880         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9881         earlier.
9882         (struct objfile) <msymbols_range>: Move from top level.
9883         <msymbols>: New method.
9884         (class objfile_msymbols): Remove.
9885         * symtab.c (default_collect_symbol_completion_matches_break_on):
9886         Update.
9887         * symmisc.c (dump_msymbols): Update.
9888         * stabsread.c (scan_file_globals): Update.
9889         * objc-lang.c (info_selectors_command, info_classes_command)
9890         (find_methods): Update.
9891         * minsyms.c (find_solib_trampoline_target): Update.
9892         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9893         * coffread.c (coff_symfile_read): Update.
9894         * ada-lang.c (ada_lookup_simple_minsym)
9895         (ada_collect_symbol_completion_matches): Update.
9896
9897 2019-01-16  Tom Tromey  <tom@tromey.com>
9898
9899         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9900         type.  Remove no-argument constructor.
9901         <iterator::operator++>: Simplify.
9902         <begin>: Update.
9903         <end>: Use minimal_symbol_count.
9904
9905 2019-01-16  Tom Tromey  <tom@tromey.com>
9906
9907         * objfiles.h (struct objfile) <psymtabs>: New method.
9908         (class objfile_psymtabs): Remove.
9909         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9910         typedef.
9911         <range>: New method.
9912         (require_partial_symbols): Change return type.
9913         * psymtab.c (require_partial_symbols)
9914         (psym_expand_symtabs_matching): Update.
9915         * mdebugread.c (parse_partial_symbols): Update.
9916         * dbxread.c (dbx_end_psymtab): Update.
9917
9918 2019-01-15  Tom Tromey  <tom@tromey.com>
9919
9920         * symtab.c (lookup_objfile_from_block)
9921         (lookup_symbol_in_objfile_symtabs)
9922         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9923         (find_line_symtab, info_sources_command)
9924         (default_collect_symbol_completion_matches_break_on)
9925         (make_source_files_completion_list): Update.
9926         * symmisc.c (print_objfile_statistics, dump_objfile)
9927         (maintenance_print_symbols, maintenance_info_symtabs)
9928         (maintenance_check_symtabs, maintenance_info_line_tables):
9929         Update.
9930         * source.c (select_source_symtab)
9931         (forget_cached_source_info_for_objfile): Update.
9932         * objfiles.h (class objfile_compunits): Remove.
9933         (struct objfile) <compunits_range>: New typedef.
9934         (compunits): New method.
9935         * objfiles.c (objfile_relocate1): Update.
9936         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9937         * maint.c (count_symtabs_and_blocks): Update.
9938         * linespec.c (iterate_over_all_matching_symtabs): Update.
9939         * cp-support.c (add_symbol_overload_list_qualified): Update.
9940         * coffread.c (coff_symtab_read): Update.
9941         * ada-lang.c (add_nonlocal_symbols)
9942         (ada_collect_symbol_completion_matches)
9943         (ada_add_global_exceptions): Update.
9944
9945 2019-01-15  Tom Tromey  <tom@tromey.com>
9946
9947         * progspace.h (program_space) <objfiles_safe_range>: New
9948         typedef.
9949         <objfiles_safe>: New method.
9950         * objfiles.h (class all_objfiles_safe): Remove.
9951         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9952         * jit.c (jit_inferior_exit_hook): Update.
9953
9954 2019-01-17  Tom Tromey  <tom@tromey.com>
9955
9956         * progspace.h (program_space) <objfiles_range>: New typedef.
9957         <objfiles>: New method.
9958         <objfiles_head>: Rename from objfiles.
9959         (object_files): Update.
9960         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9961         * guile/scm-pretty-print.c
9962         (ppscm_find_pretty_printer_from_objfiles): Update.
9963         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9964         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9965         Update.
9966         * python/py-progspace.c (pspy_get_objfiles): Update.
9967         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9968         Update.
9969         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9970         (objfpy_lookup_objfile_by_build_id): Update.
9971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9972         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9973         Update.
9974         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9975         (expand_symtab_containing_pc, lookup_objfile_from_block)
9976         (lookup_static_symbol, basic_lookup_transparent_type)
9977         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9978         (find_line_symtab, info_sources_command)
9979         (default_collect_symbol_completion_matches_break_on)
9980         (make_source_files_completion_list, find_main_name): Update.
9981         * symmisc.c (print_symbol_bcache_statistics)
9982         (print_objfile_statistics, maintenance_print_symbols)
9983         (maintenance_print_msymbols, maintenance_print_objfiles)
9984         (maintenance_info_symtabs, maintenance_check_symtabs)
9985         (maintenance_expand_symtabs, maintenance_info_line_tables):
9986         Update.
9987         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9988         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9989         (map_overlay_command, unmap_overlay_command)
9990         (simple_overlay_update, expand_symtabs_matching)
9991         (map_symbol_filenames): Update.
9992         * symfile-debug.c (set_debug_symfile): Update.
9993         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9994         Update.
9995         * source.c (select_source_symtab, forget_cached_source_info):
9996         Update.
9997         * solib.c (solib_read_symbols): Update.
9998         * solib-spu.c (append_ocl_sos): Update.
9999         * psymtab.c (maintenance_print_psymbols)
10000         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10001         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10002         * printcmd.c (info_symbol_command): Update.
10003         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10004         Update.
10005         * objfiles.h (class all_objfiles): Remove.
10006         * objfiles.c (have_partial_symbols, have_full_symbols)
10007         (have_minimal_symbols, qsort_cmp, update_section_map)
10008         (shared_objfile_contains_address_p)
10009         (default_iterate_over_objfiles_in_search_order): Update.
10010         * objc-lang.c (info_selectors_command, info_classes_command)
10011         (find_methods): Update.
10012         * minsyms.c (find_solib_trampoline_target): Update.
10013         * maint.c (maintenance_info_sections)
10014         (maintenance_translate_address, count_symtabs_and_blocks):
10015         Update.
10016         * main.c (captured_main_1): Update.
10017         * linux-thread-db.c (try_thread_db_load_from_pdir)
10018         (has_libpthread): Update.
10019         * linespec.c (iterate_over_all_matching_symtabs)
10020         (search_minsyms_for_name): Update.
10021         * jit.c (jit_find_objf_with_entry_addr): Update.
10022         * hppa-tdep.c (find_unwind_entry)
10023         (hppa_lookup_stub_minimal_symbol): Update.
10024         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10025         Update.
10026         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10027         (elf_gnu_ifunc_resolve_by_got): Update.
10028         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10029         * dwarf-index-write.c (save_gdb_index_command): Update.
10030         * cp-support.c (add_symbol_overload_list_qualified): Update.
10031         * breakpoint.c (create_overlay_event_breakpoint)
10032         (create_longjmp_master_breakpoint)
10033         (create_std_terminate_master_breakpoint)
10034         (create_exception_master_breakpoint): Update.
10035         * blockframe.c (find_pc_partial_function): Update.
10036         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10037         (ada_collect_symbol_completion_matches)
10038         (ada_add_global_exceptions): Update.
10039
10040 2019-01-17  Tom Tromey  <tom@tromey.com>
10041
10042         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10043         declare VEC.
10044         (solib_target_parse_libraries): Change return type.
10045         (library_list_start_segment, library_list_start_section)
10046         (library_list_end_library, library_list_start_library); Update.
10047         (solib_target_free_library_list): Remove.
10048         (solib_target_parse_libraries): Remove cleanup.  Change return
10049         type.
10050         (solib_target_current_sos): Update.
10051
10052 2019-01-17  Tom Tromey  <tromey@bapiya>
10053
10054         * valprint.c: Replace "the the" with "the".
10055         * symtab.c: Replace "the the" with "the".
10056         * solib.c: Replace "the the" with "the".
10057         * solib-dsbt.c: Replace "the the" with "the".
10058         * linespec.c: Replace "the the" with "the".
10059         * dwarf2loc.h: Replace "the the" with "the".
10060         * amd64-windows-tdep.c: Replace "the the" with "the".
10061         * aarch64-tdep.c: Replace "the the" with "the".
10062
10063 2019-01-16  Keith Seitz  <keiths@redhat.com>
10064
10065         PR gdb/23773
10066         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10067         <builder>: Rename to ..
10068         <m_builder>: ... this and make private.
10069         (dwarf2_cu::get_builder): New method.  Change all users of
10070         `builder' to use this method.
10071         (dwarf2_start_symtab): Move to ...
10072         (dwarf2_cu::start_symtab): ... here.  Update all callers
10073         (setup_type_unit_groups): Move to ...
10074         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10075         callers.
10076         (dwarf2_cu::reset_builder): New method.
10077         (process_full_compunit, process_full_type_unit): Use
10078         dwarf2_cu::reset_builder.
10079         (follow_die_offset): Record the ancestor CU if it is different
10080         from the followed DIE's CU.
10081         (follow_die_sig_1): Likewise.
10082
10083 2019-01-15  Tom Tromey  <tom@tromey.com>
10084
10085         * remote.c (class remote_state) <buf>: Now a char_vector.
10086         <buf_size>: Remove.
10087         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10088         parameter.
10089         (remote_target::getpkt_or_notif_sane_1)
10090         (remote_target::getpkt_sane)
10091         (remote_target::getpkt_or_notif_sane): Likewise.
10092         (class remote_target) <putpkt>: New overload.
10093         (remote_target::read_frame): Change type of "buf_p".  Remove
10094         sizeof_p parameter.
10095         (packet_ok): New overload.
10096         (packet_check_result): New overload.
10097         Update all uses.
10098
10099 2019-01-14  Tom Tromey  <tom@tromey.com>
10100
10101         * remote-notif.c (handle_notification, remote_notif_ack)
10102         (remote_notif_parse): Make "buf" const.
10103         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10104         const.
10105         (remote_notif_parse, remote_notif_ack, handle_notification):
10106         Likewise.
10107         * remote.c (remote_notif_stop_parse): Make "buf" const.
10108         (remote_target::remote_parse_stop_reply): Make "buf" const.
10109         (remote_notif_stop_ack): Make "buf" const.
10110
10111 2019-01-14  Tom Tromey  <tom@tromey.com>
10112
10113         * remote.c (remote_console_output): Make parameter const.
10114
10115 2019-01-14  Tom Tromey  <tom@tromey.com>
10116
10117         * target-debug.h (target_debug_print_signals): Constify.
10118         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10119         * procfs.c (procfs_target::pass_signals): Update.
10120         * linux-nat.c (linux_nat_target::pass_signals): Update.
10121         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10122         * target-delegates.c: Rebuild.
10123         * remote.c (remote_target::program_signals): Update.
10124         (remote_target::pass_signals): Update.
10125         * target.c (target_pass_signals): Constify argument.
10126         (target_program_signals): Likewise.
10127         * target.h (struct target_ops) <pass_signals, program_signals>:
10128         Constify argument.
10129         (target_pass_signals, target_program_signals): Constify argument.
10130
10131 2019-01-14  Tom Tromey  <tom@tromey.com>
10132
10133         PR tui/28819:
10134         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10135
10136 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10137
10138         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10139         field.
10140         * rs6000-tdep.c: Include reggroups.h.
10141         (IS_V_ALIAS_PSEUDOREG): Define.
10142         (rs6000_register_name): Return names for the "vX" aliases.
10143         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10144         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10145         aliases.  Call default_register_reggroup_p for all other
10146         pseudo-registers.
10147         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10148         New functions.
10149         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10150         Handle "vX" aliases.
10151         (v_alias_pseudo_register_collect): New function.
10152         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10153         (rs6000_gdbarch_init): Initialize "vX" aliases as
10154         pseudo-registers.  Restore registration of
10155         rs6000_pseudo_register_reggroup_p with
10156         set_tdesc_pseudo_register_reggroup_p.
10157
10158 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10159
10160         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10161         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10162         set_gdbarch_num_pseudo_regs.
10163
10164 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10165
10166         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10167         Remove arg prefixname, add do_set and do_show.
10168         Add member functions set_list and show_list.
10169         * cli/cli-style.c (class cli_style_option): Update accordingly.
10170         (style_set_list): Move to file scope.
10171         (style_show_list): Likewise.
10172         (set_style): Call help_list.
10173         (show_style): Call cmd_show_list.
10174         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10175         Update to use the new macro.
10176
10177 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10178
10179         * ada-lang.c (_initialize_ada_language): Expand the help text
10180         for the "catch exception" command.
10181
10182 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10183
10184         * symtab.c (matching_obj_sections): Initialize obj,
10185         declare it closer to its usage.
10186
10187 2019-01-10  Tom Tromey  <tom@tromey.com>
10188
10189         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10190         (basic_inf_threads_range): Remove.
10191         (inf_threads_range, inf_non_exited_threads_range)
10192         (safe_inf_threads_range): Use next_adapter.
10193
10194 2019-01-10  Keith Seitz  <keiths@redhat.com>
10195
10196         PR gdb/23712
10197         PR symtab/23010
10198         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10199         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10200
10201 2019-01-10  Keith Seitz  <keiths@redhat.com>
10202
10203         PR gdb/23712
10204         PR symtab/23010
10205         * dictionary.c (pending_to_vector): Remove.
10206         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10207         Remove _1 suffix, replacing functions of the same name.  Update
10208         all callers.
10209         (dict_create_hashed, dict_create_hashed_expandable)
10210         (dict_create_linear, dict_create_linear_expandable, dict_free)
10211         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10212         Make functions static.
10213
10214 2019-01-10  Keith Seitz  <keiths@redhat.com>
10215
10216         PR gdb/23712
10217         PR symtab/23010
10218         * dictionary.h (struct dictionary): Replace declaration with
10219         multidictionary.
10220         (dict_create_hashed, dict_create_hashed_expandable)
10221         (dict_create_linear, dict_create_linear_expandable)
10222         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10223         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10224         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10225         taking multidictionary argument.
10226         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10227         * block.h (struct block) <dict>: Change to multidictionary
10228         and rename `multidict'.
10229         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10230         symmisc.c: Update all dictionary references to multidictionary.
10231
10232 2019-01-10  Keith Seitz  <keiths@redhat.com>
10233
10234         PR gdb/23712
10235         PR symtab/23010
10236         * dictionary.c: Include unordered_map.
10237         (pending_to_vector): New function.
10238         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10239         Rewrite the non-"_1" functions to take vector instead
10240         of linked list.
10241         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10242         "new" _1 versions of the same name.
10243         (multidictionary): Define.
10244         (std::hash<enum language): New definition.
10245         (collate_pending_symbols_by_language, mdict_create_hashed)
10246         (mdict_create_hashed_expandable, mdict_create_linear)
10247         (mdict_create_linear_expandable, mdict_free)
10248         (find_language_dictionary, create_new_language_dictionary)
10249         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10250         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10251         (mdict_size, mdict_empty): New functions.
10252         * dictionary.h (mdict_iterator): Define.
10253
10254 2019-01-10  Pedro Alves  <palves@redhat.com>
10255
10256         * breakpoint.c (read_uploaded_action)
10257         (create_tracepoint_from_upload): Adjust to use
10258         gdb::unique_xmalloc_ptr.
10259         * ctf.c (ctf_write_uploaded_tp):
10260         (SET_ARRAY_FIELD): Use emplace_back.
10261         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10262         * tracefile-tfile.c (tfile_write_uploaded_tp):
10263         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10264         gdb::unique_xmalloc_ptr.
10265         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10266         at_string, cond_string, cmd_strings>: Replace char pointers
10267         with gdb::unique_xmalloc_ptr.
10268
10269 2019-01-10  Pedro Alves  <palves@redhat.com>
10270
10271         * solib-target.c (library_list_start_library): Don't xstrdup name.
10272
10273 2019-01-10  Pedro Alves  <palves@redhat.com>
10274
10275         * mdebugread.c (parse_partial_symbols): Use
10276         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10277
10278 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10279
10280         * linux-fork.c (scoped_switch_fork_info)
10281         <~scoped_switch_fork_info>: Fix incorrect variable name.
10282
10283 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10284
10285         * linux-fork.c (scoped_switch_fork_info)
10286         <scoped_switch_fork_info>: Make explicit.
10287         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10288
10289 2019-01-10  Tom Tromey  <tom@tromey.com>
10290
10291         * objfiles.h (objfile::reset_psymtabs): Update.
10292         * objfiles.c (objfile::objfile): Update.
10293         * psymtab.h (psymtab_storage::obstack): Update.
10294         (psymtab_storage::m_obstack): Use gdb::optional.
10295         (class psymtab_storage): Update comment.  Remove objfile
10296         parameter.
10297         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10298
10299 2019-01-10  Tom Tromey  <tom@tromey.com>
10300
10301         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10302         <free_psymtabs>: Now private.
10303         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10304         (allocate_psymtab): Use new method.
10305
10306 2019-01-10  Tom Tromey  <tom@tromey.com>
10307
10308         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10309         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10310         * mdebugread.c (parse_partial_symbols): Use
10311         allocate_dependencies.
10312         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10313         allocate_dependencies.
10314         (process_psymtab_comp_unit_reader)
10315         (build_type_psymtab_dependencies): Likewise.
10316         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10317
10318 2019-01-10  Tom Tromey  <tom@tromey.com>
10319
10320         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10321         PSYMBOL_SET_LANGUAGE.
10322         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10323
10324 2019-01-10  Tom Tromey  <tom@tromey.com>
10325
10326         * psymtab.h (psymtab_storage::obstack): New method.
10327         <m_obstack>: Rename from obstack; now private.
10328         * psymtab.c (psymtab_storage): Update.
10329         * dwarf2read.c (create_addrmap_from_index)
10330         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10331         Update.
10332
10333 2019-01-10  Tom Tromey  <tom@tromey.com>
10334
10335         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10336         * objfiles.h (objfile::reset_psymtabs): New method.
10337
10338 2019-01-10  Tom Tromey  <tom@tromey.com>
10339
10340         * symmisc.c (print_symbol_bcache_statistics): Update.
10341         (print_objfile_statistics): Update.
10342         * symfile.c (reread_symbols): Update.
10343         * psymtab.h (class psymtab_storage): New.
10344         * psymtab.c (psymtab_storage): New constructor.
10345         (~psymtab_storage): New destructor.
10346         (require_partial_symbols): Update.
10347         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10348         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10349         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10350         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10351         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10352         (start_psymtab_common, end_psymtab_common)
10353         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10354         (allocate_psymtab): Update.
10355         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10356         Update.
10357         (dump_psymtab_addrmap, maintenance_print_psymbols)
10358         (maintenance_check_psymtabs): Update.
10359         (class objfile_psymtabs): Move to objfiles.h.
10360         * psympriv.h (discard_psymtab): Now inline.
10361         (psymtab_discarder::psymtab_discarder): Update.
10362         (psymtab_discarder::~psymtab_discarder): Update.
10363         (ALL_OBJFILE_PSYMTABS): Rewrite.
10364         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10365         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10366         Remove fields.
10367         <partial_symtabs>: New field.
10368         (class objfile_psymtabs): Move from psymtab.h.  Update.
10369         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10370         psymbol_cache.
10371         (objfile::~objfile): Don't destroy psymbol_cache.
10372         * mdebugread.c (parse_partial_symbols): Update.
10373         * dwarf2read.c (create_addrmap_from_index)
10374         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10375         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10376         (add_partial_subprogram, dwarf2_ranges_read): Update.
10377         * dwarf-index-write.c (write_address_map)
10378         (write_one_signatured_type, recursively_write_psymbols)
10379         (class debug_names, class debug_names, write_psymtabs_to_index):
10380         Update.
10381
10382 2019-01-10  Tom Tromey  <tom@tromey.com>
10383
10384         * symtab.h (SYMBOL_SET_NAMES): Update.
10385         (symbol_set_names): Update.
10386         (MSYMBOL_SET_NAMES): Update.
10387         * symtab.c (symbol_set_names): Change argument to be an
10388         objfile_per_bfd_storage.
10389         * psymtab.c (add_psymbol_to_bcache): Update.
10390         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10391
10392 2019-01-10  Tom Tromey  <tom@tromey.com>
10393
10394         * symtab.c (create_demangled_names_hash): Change argument to be an
10395         objfile_per_bfd_storage.
10396         (symbol_set_names): Update.
10397
10398 2019-01-10  Tom Tromey  <tom@tromey.com>
10399
10400         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10401         init_psymbol_list.
10402         * psymtab.c (init_psymbol_list): Do nothing if already called.
10403         * psympriv.h (init_psymbol_list): Add comment.
10404         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10405         init_psymbol_list.
10406         * dbxread.c (dbx_symfile_read): Unconditionally call
10407         init_psymbol_list.
10408
10409 2019-01-10  Tom Tromey  <tom@tromey.com>
10410
10411         * xcoffread.c (scan_xcoff_symtab): Update.
10412         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10413         "where".
10414         * mdebugread.c (parse_partial_symbols)
10415         (handle_psymbol_enumerators): Update.
10416         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10417         * dbxread.c (read_dbx_symtab): Update.
10418         * psympriv.h (psymbol_placement): New enum.
10419         (add_psymbol_to_list): Update.
10420
10421 2019-01-10  Tom Tromey  <tom@tromey.com>
10422
10423         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10424         static_psymbols parameters.
10425         (scan_xcoff_symtab): Update.
10426         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10427         static_psymbols parameters.
10428         * psympriv.h (start_psymtab_common): Update.
10429         * mdebugread.c (parse_partial_symbols): Update.
10430         * dwarf2read.c (create_partial_symtab): Update.
10431         * dbxread.c (read_dbx_symtab): Update.
10432         (start_psymtab): Remove global_psymbols and static_psymbols
10433         parameters.
10434
10435 2019-01-10  Tom Tromey  <tom@tromey.com>
10436
10437         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10438         * psymtab.c (allocate_psymtab): Add comment.
10439         * psympriv.h (allocate_psymtab): Add comment.
10440         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10441         initializations.
10442         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10443
10444 2019-01-10  Tom Tromey  <tom@tromey.com>
10445
10446         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10447         Don't declare.
10448         * mipsread.c: Include mdebugread.h.
10449         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10450         Declare.
10451         * elfread.c: Include mdebugread.h.
10452
10453 2019-01-09  Tom Tromey  <tom@tromey.com>
10454
10455         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10456         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10457         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10458         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10459         (psym_lookup_symbol, psym_find_last_source_symtab)
10460         (psym_forget_cached_source_info, psym_print_stats)
10461         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10462         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10463         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10464         (psym_find_compunit_symtab_by_address)
10465         (maintenance_print_psymbols, maintenance_info_psymtabs)
10466         (maintenance_check_psymtabs): Use ranged for.
10467         * psymtab.h (class objfile_psymtabs): New.
10468         (require_partial_symbols): Return objfile_psymtabs.
10469         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10470
10471 2019-01-09  Tom Tromey  <tom@tromey.com>
10472
10473         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10474         (find_pc_mapped_section, list_overlays_command)
10475         (map_overlay_command, unmap_overlay_command)
10476         (simple_overlay_update): Use all_objfiles.
10477         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10478         * printcmd.c (info_symbol_command): Use all_objfiles.
10479         * objfiles.h (ALL_OBJSECTIONS): Remove.
10480         * maint.c (maintenance_translate_address): Use all_objfiles.
10481         * gcore.c (gcore_create_callback): Use all_objfiles.
10482         (objfile_find_memory_regions): Likewise.
10483
10484 2019-01-09  Tom Tromey  <tom@tromey.com>
10485
10486         * symtab.c (find_line_symtab, info_sources_command)
10487         (make_source_files_completion_list): Use objfile_compunits.
10488         * source.c (select_source_symtab): Use objfile_compunits.
10489         * objfiles.h (struct objfile): Update comment.
10490         (ALL_OBJFILES): Remove.
10491         (ALL_FILETABS): Remove.
10492         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10493         objfile_compunits.
10494
10495 2019-01-09  Tom Tromey  <tom@tromey.com>
10496
10497         * symmisc.c (print_objfile_statistics, dump_objfile)
10498         (maintenance_print_symbols): Use compunit_filetabs.
10499         * source.c (forget_cached_source_info_for_objfile): Use
10500         compunit_filetabs.
10501         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10502         (ALL_FILETABS): Use compunit_filetabs.
10503         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10504         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10505
10506 2019-01-09  Tom Tromey  <tom@tromey.com>
10507
10508         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10509         (compunit_filetabs): New.
10510         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10511         compunit_filetabs.
10512         (info_sources_command, make_source_files_completion_list): Remove
10513         declaration.
10514         * symmisc.c (print_objfile_statistics, dump_objfile)
10515         (maintenance_print_symbols): Remove declaration.
10516         (maintenance_info_symtabs): Use compunit_filetabs.
10517         (maintenance_info_line_tables): Likewise.
10518         * source.c (select_source_symtab): Change local variable name.
10519         (forget_cached_source_info_for_objfile): Remove declaration.
10520         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10521         * objfiles.c (objfile_relocate1): Remove declaration.
10522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10523         declaration.
10524         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10525         * coffread.c (coff_symtab_read): Remove declaration.
10526         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10527         compunit_filetabs.
10528
10529 2019-01-09  Tom Tromey  <tom@tromey.com>
10530
10531         * symtab.c (lookup_objfile_from_block)
10532         (find_pc_sect_compunit_symtab, search_symbols)
10533         (default_collect_symbol_completion_matches_break_on): Use
10534         objfile_compunits.
10535         * objfiles.h (ALL_COMPUNITS): Remove.
10536         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10537         * cp-support.c (add_symbol_overload_list_qualified): Use
10538         objfile_compunits.
10539         * ada-lang.c (ada_collect_symbol_completion_matches)
10540         (ada_add_global_exceptions): Use objfile_compunits.
10541
10542 2019-01-09  Tom Tromey  <tom@tromey.com>
10543
10544         * source.c (select_source_symtab)
10545         (forget_cached_source_info_for_objfile): Remove declaration.
10546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10547         declaration.
10548         * maint.c (count_symtabs_and_blocks): Remove declaration.
10549         * cp-support.c (add_symbol_overload_list_qualified): Remove
10550         declaration.
10551         * coffread.c (coff_symtab_read): Remove declaration.
10552         * symtab.c (lookup_symbol_in_objfile_symtabs)
10553         (basic_lookup_transparent_type_1): Use objfile_compunits.
10554         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10555         (info_sources_command, search_symbols)
10556         (default_collect_symbol_completion_matches_break_on)
10557         (make_source_files_completion_list): Remove declaration.
10558         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10559         (ada_collect_symbol_completion_matches)
10560         (ada_add_global_exceptions): Remove declaration.
10561         * linespec.c (iterate_over_all_matching_symtabs): Use
10562         objfile_compunits.
10563         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10564         (class objfile_compunits): New.
10565         (ALL_COMPUNITS): Use objfile_compunits.
10566         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10567         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10568         objfile_compunits.
10569         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10570
10571 2019-01-09  Tom Tromey  <tom@tromey.com>
10572
10573         * symtab.c (search_symbols)
10574         (default_collect_symbol_completion_matches_break_on): Use
10575         objfile_msymbols.
10576         * ada-lang.c (ada_lookup_simple_minsym)
10577         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10578         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10579         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10580         objfile_msymbols.
10581         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10582         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10583         * objc-lang.c (find_methods): Use objfile_msymbols.
10584         (info_selectors_command, info_classes_command): Likewise.
10585         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10586         * objfiles.h (class objfile_msymbols): New.
10587         (ALL_OBJFILE_MSYMBOLS): Remove.
10588         (ALL_MSYMBOLS): Remove.
10589
10590 2019-01-09  Tom Tromey  <tom@tromey.com>
10591
10592         * common/next-iterator.h (next_adapter): Add Iterator template
10593         parameter.
10594         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10595         (class all_objfiles_safe): New.
10596         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10597         * objfiles.c (put_objfile_before): Update comment.
10598         (add_separate_debug_objfile): Likewise.
10599         (free_all_objfiles): Use all_objfiles_safe.
10600         (objfile_purge_solibs): Likewise.
10601
10602 2019-01-09  Tom Tromey  <tom@tromey.com>
10603
10604         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10605         (expand_symtab_containing_pc, lookup_static_symbol)
10606         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10607         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10608         all_objfiles.
10609         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10610         * breakpoint.c (create_overlay_event_breakpoint)
10611         (create_longjmp_master_breakpoint)
10612         (create_std_terminate_master_breakpoint)
10613         (create_exception_master_breakpoint): Use all_objfiles.
10614         * linux-thread-db.c (try_thread_db_load_from_pdir)
10615         (has_libpthread): Use all_objfiles.
10616         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10617         * linespec.c (iterate_over_all_matching_symtabs)
10618         (search_minsyms_for_name): Use all_objfiles.
10619         * maint.c (maintenance_info_sections): Use all_objfiles.
10620         * main.c (captured_main_1): Use all_objfiles.
10621         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10622         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10623         * guile/scm-pretty-print.c
10624         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10625         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10626         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10627         (maintenance_print_msymbols): Use all_objfiles.
10628         * source.c (select_source_symtab): Use all_objfiles.
10629         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10630         * symfile.c (remove_symbol_file_command)
10631         (expand_symtabs_matching, map_symbol_filenames): Use
10632         all_objfiles.
10633         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10634         all_objfiles.
10635         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10636         * objc-lang.c (find_methods): Use all_objfiles.
10637         * objfiles.c (have_partial_symbols, have_full_symbols)
10638         (have_minimal_symbols, qsort_cmp)
10639         (default_iterate_over_objfiles_in_search_order): Use
10640         all_objfiles.
10641         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10642         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10643         (maintenance_check_psymtabs): Use all_objfiles.
10644         (ALL_PSYMTABS): Remove.
10645         * compile/compile-object-run.c (do_module_cleanup): Use
10646         all_objfiles.
10647         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10648         * cp-support.c (add_symbol_overload_list_qualified): Use
10649         all_objfiles.
10650         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10651         Use all_objfiles.
10652         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10653         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10654         all_objfiles.
10655         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10656         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10657         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10658         Uses all_objfiles.
10659         * solib.c (solib_read_symbols): Use all_objfiles
10660
10661 2019-01-09  Tom Tromey  <tom@tromey.com>
10662
10663         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10664         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10665         all_objfiles.
10666         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10667         * symmisc.c (print_symbol_bcache_statistics)
10668         (print_objfile_statistics, maintenance_print_objfiles)
10669         (maintenance_info_symtabs, maintenance_check_symtabs)
10670         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10671         all_objfiles.
10672         * source.c (forget_cached_source_info): Use all_objfiles.
10673         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10674         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10675         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10676         * objfiles.c (update_section_map): Use all_objfiles.
10677         (shared_objfile_contains_address_p): Likewise.
10678         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10679         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10680
10681 2019-01-09  Tom Tromey  <tom@tromey.com>
10682
10683         * common/next-iterator.h: New file.
10684         * objfiles.h (class all_objfiles): New.
10685         (struct objfile_iterator): New.
10686
10687 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10688
10689         * NEWS: Move the description of the changed "frame", "select-frame",
10690          and "info frame" commands to the Changed commands section.
10691
10692 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10693
10694         * gdbtypes.c (check_stub_method_group): Remove handling of old
10695         mangling schemes.
10696         * linespec.c (find_methods): Likewise.
10697         * stabsread.c (read_member_functions): Likewise.
10698         * valops.c (search_struct_method): Likewise.
10699         (value_struct_elt_for_reference): Likewise.
10700         * NEWS: Mention this change.
10701
10702 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10703
10704         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10705         print_source_lines.
10706         * source.c (print_source_lines_base): Update line number check.
10707         (print_source_lines): New function.
10708         (source_lines_range::source_lines_range): New function.
10709         * source.h (class source_lines_range): New class.
10710         (print_source_lines): New declaration.
10711
10712 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10713
10714         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10715
10716 2019-01-08  Tom Tromey  <tom@tromey.com>
10717             Simon Marchi  <simon.marchi@ericsson.com>
10718
10719         PR gdb/24060
10720         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10721         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10722         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10723         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10724         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10725         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10726
10727 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10728
10729         * source.c (select_source_symtab): Move header comment to
10730         declaration in source.h.
10731         (forget_cached_source_info_for_objfile): Likewise.
10732         (forget_cached_source_info): Likewise.
10733         (identify_source_line): Likewise.
10734         * source.h (identify_source_line): Move declaration from symtab.h
10735         and add comment from source.c
10736         (print_source_lines): Likewise.
10737         (forget_cached_source_info_for_objfile): Likewise.
10738         (forget_cached_source_info): Likewise.
10739         (select_source_symtab): Likewise.
10740         (enum print_source_lines_flag): Move definition from symtab.h.
10741         * symtab.h (identify_source_line): Move declaration to source.h.
10742         (print_source_lines): Likewise.
10743         (forget_cached_source_info_for_objfile): Likewise.
10744         (forget_cached_source_info): Likewise.
10745         (select_source_symtab): Likewise.
10746         (enum print_source_lines_flag): Move definition to source.h.
10747         * tui/tui-hooks.c: Add 'source.h' include.
10748
10749 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10750
10751         * source.c (print_source_lines_base): Handle requests to print
10752         reverse line number sequences, and guard against empty lines
10753         string.
10754
10755 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10756
10757         * source.c (print_source_lines_base): Fix skip of '\r' if next
10758         character is '\n'.
10759
10760 2019-01-06  Tom Tromey  <tom@tromey.com>
10761
10762         * c-exp.y (struct c_parse_state) <macro_original_text,
10763         expansion_obstack>: New member.
10764         (macro_original_text, expansion_obstack): Remove globals.
10765         (scan_macro_expansion, scanning_macro_expansion)
10766         (finished_macro_expansion): Update.
10767         (scan_macro_cleanup): Remove.
10768         (yylex, c_parse): Update.
10769
10770 2019-01-06  Tom Tromey  <tom@tromey.com>
10771
10772         * c-exp.y (struct c_parse_state) <strings>: New member.
10773         (operator_stoken): Update.
10774
10775 2019-01-06  Tom Tromey  <tom@tromey.com>
10776
10777         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10778         (union type_stack_elt) <typelist_val>: Now a pointer to
10779         std::vector.
10780         (type_stack_cleanup): Don't declare.
10781         (push_typelist): Update.
10782         * parse.c (pop_typelist): Return a std::vector.
10783         (push_typelist): Take a std::vector.
10784         (follow_types): Update.  Do not free args.
10785         (type_stack_cleanup): Remove.
10786         * c-exp.y (struct c_parse_state): New.
10787         (cpstate): New global.
10788         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10789         (nonempty_typelist): Update.
10790         (func_mod): Create a new vector.
10791         (c_parse): Create a c_parse_state.
10792         (check_parameter_typelist): Do not delete params.
10793         (function_method): Update.  Do not delete type_list.
10794
10795 2019-01-06  Tom Tromey  <tom@tromey.com>
10796
10797         PR gdb/28155:
10798         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10799         check_typedef.
10800         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10801         (print_return_value): Likewise.
10802
10803 2019-01-05  Tom Tromey  <tom@tromey.com>
10804
10805         * contrib/cleanup_check.py: Remove.
10806         * contrib/gcc-with-excheck: Remove.
10807         * contrib/exsummary.py: Remove.
10808         * contrib/excheck.py: Remove.
10809
10810 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10811
10812         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10813         NULL. Initialize tpprev to NULL instead of assigning it
10814         to NULL on the next statement.
10815         * windows-nat.c (windows_delete_thread): Remove check for
10816         main_thread_id before printing thread exit notifications.
10817         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10818         Remove thread ID check against main_thread_id.
10819         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10820         windows_delete_thread.
10821         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10822
10823 2019-01-04  Tom Tromey  <tom@tromey.com>
10824
10825         * compile/compile.c (_initialize_compile): Use upper case for
10826         metasyntactic variables.
10827         * symmisc.c (_initialize_symmisc): Use upper case for
10828         metasyntactic variables.
10829         * psymtab.c (_initialize_psymtab): Use upper case for
10830         metasyntactic variables.
10831         * demangle.c (demangle_command): Use upper case for metasyntactic
10832         variables.
10833         (_initialize_demangler): Likewise.
10834         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10835         variables.
10836
10837 2019-01-03  Tom Tromey  <tom@tromey.com>
10838
10839         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10840
10841 2019-01-03  Tom Tromey  <tom@tromey.com>
10842
10843         * python/py-symtab.c (salpy_str): Update.
10844         (struct salpy_sal_object) <symtab>: Now a PyObject.
10845         (salpy_dealloc): Update.
10846         (del_objfile_sal): Use gdbpy_ref.
10847
10848 2019-01-03  Tom Tromey  <tom@tromey.com>
10849
10850         * python/py-type.c (convert_field): Use new_reference.  Return
10851         gdbpy_ref.
10852         (make_fielditem): Return gdbpy_ref.
10853         (typy_fields): Update.
10854         (typy_getitem): Update.
10855         (field_name): Return gdbpy_ref.  Use new_reference.
10856         (typy_iterator_iternext): Update.
10857
10858 2019-01-03  Tom Tromey  <tom@tromey.com>
10859
10860         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10861
10862 2019-01-03  Tom Tromey  <tom@tromey.com>
10863
10864         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10865         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10866         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10867         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10868         (pspy_set_type_printers): Likewise.
10869         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10870         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10871         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10872         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10873         (objfpy_set_type_printers): Likewise.
10874
10875 2019-01-03  Tom Tromey  <tom@tromey.com>
10876
10877         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10878         (gdbpy_print_stack): Use gdbpy_err_fetch.
10879         * python/python-internal.h (class gdbpy_err_fetch): New class.
10880         (class gdbpy_enter) <m_error_type, m_error_value,
10881         m_error_traceback>: Remove.
10882         <m_error>: New member.
10883         (gdbpy_exception_to_string): Don't declare.
10884         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10885         * python/py-value.c (convert_value_from_python): Use
10886         gdbpy_err_fetch.
10887         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10888         gdbpy_exception_to_string.
10889         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10890         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10891         gdbpy_err_fetch.
10892
10893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10894
10895         * linux-nat.c (delete_lwp_cleanup): Delete.
10896         (struct lwp_deleter): New struct.
10897         (lwp_info_up): New typedef.
10898         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10899         lwp_info_up.
10900
10901 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10902
10903         * linux-fork.c (class scoped_switch_fork_info): New class.
10904         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10905
10906 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10907
10908         * valops.c (find_overload_match): Remove use of null_cleanup, and
10909         calls to do_cleanups.
10910
10911 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10912
10913         * compile/compile-cplus-types.c
10914         (compile_cplus_instance::decl_name): Handle changes to
10915         cp_func_name.
10916         * cp-support.c (cp_func_name): Update header comment, update
10917         return type.
10918         * cp-support.h (cp_func_name): Update return type in declaration.
10919         * valops.c (find_overload_match): Move temp_func local to top
10920         level of function and change its type.  Use temp_func to hold and
10921         delete temporary string obtained from cp_func_name.
10922
10923 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10924
10925         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10926         gdb::char_vector, remove cleanup, and update uses of `msg`.
10927
10928 2019-01-03  Jim Wilson  <jimw@sifive.com>
10929
10930         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10931
10932 2019-01-02  Tom Tromey  <tom@tromey.com>
10933
10934         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10935         (tdesc_parse_xml): Remove cleanups.
10936         * target-descriptions.h (make_cleanup_free_target_description):
10937         Don't declare.
10938         (target_desc_deleter): New struct.
10939         (target_desc_up): New typedef.
10940         * target-descriptions.c (target_desc_deleter::operator()): Rename
10941         from free_target_description.
10942         (make_cleanup_free_target_description): Remove.
10943
10944 2019-01-02  Tom Tromey  <tom@tromey.com>
10945
10946         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10947         constructor, destructor.
10948         (linespec_parser): Remove typedef.
10949         (~linespec_parser): Rename from linespec_parser_delete.
10950         (linespec_lex_to_end, linespec_complete_label)
10951         (linespec_complete): Update.
10952         (decode_line_full): Remove cleanups.
10953         (decode_line_1): Update.
10954
10955 2019-01-02  Tom Tromey  <tom@tromey.com>
10956
10957         * python/python-internal.h (inferior_to_inferior_object): Change
10958         return type.
10959         * python/py-exitedevent.c (create_exited_event_object): Update.
10960         * python/py-inferior.c (inferior_to_inferior_object): Return
10961         gdbpy_ref.
10962         (python_new_inferior, python_inferior_deleted)
10963         (thread_to_thread_object, delete_thread_object)
10964         (build_inferior_list, gdbpy_selected_inferior): Update.
10965         * python/py-infthread.c (create_thread_object): Update.  Also fail
10966         if inferior_to_inferior_object fails.
10967
10968 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10969
10970         * inferior.h (class inferior) <displaced_step_state>: New field.
10971         * infrun.h (struct displaced_step_state): Move here from
10972         infrun.c.  Initialize fields, add constructor.
10973         <inf>: Remove field.
10974         <reset>: New method.
10975         * infrun.c (struct displaced_step_inferior_state): Move to
10976         infrun.h.
10977         (displaced_step_inferior_states): Remove.
10978         (get_displaced_stepping_state): Adust.
10979         (displaced_step_in_progress_any_inferior): Adjust.
10980         (displaced_step_in_progress_thread): Adjust.
10981         (displaced_step_in_progress): Adjust.
10982         (add_displaced_stepping_state): Remove.
10983         (get_displaced_step_closure_by_addr): Adjust.
10984         (remove_displaced_stepping_state): Remove.
10985         (infrun_inferior_exit): Call displaced_step_state.reset.
10986         (use_displaced_stepping): Don't check for NULL.
10987         (displaced_step_prepare_throw): Call
10988         get_displaced_stepping_state.
10989         (displaced_step_fixup): Don't check for NULL.
10990         (prepare_for_detach): Don't check for NULL.
10991
10992 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10993
10994         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10995          in case of call that did not complete.
10996
10997 2019-01-02  Andrey Utkin  <autkin@undo.io>
10998
10999         * symfile.c (find_separate_debug_file): Fix search of debug files for
11000         remote debuggee.
11001
11002 2019-01-02  Tom Tromey  <tom@tromey.com>
11003
11004         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11005         indentation.
11006         * python/py-frame.c (frapy_older): Remove cast.
11007         (frapy_newer): Likewise.
11008         * python/py-breakpoint.c (local_setattro): Remove cast.
11009         * python/py-arch.c (archpy_name): Remove local variable.
11010         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11011
11012 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11013
11014         * unittests/basic_string_view/element_access/char/empty.cc:
11015         Fix year range in copyright header.
11016
11017 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11018
11019         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11020         Delete.
11021         <operator==>: Update with for removed field.
11022         <hash>: Likewise.
11023         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11024         <isa_features>: ...this.
11025         <abi_features>: New field.
11026         (riscv_isa_flen): Update comment.
11027         (riscv_abi_xlen): New declaration.
11028         (riscv_abi_flen): New declaration.
11029         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11030         isa_features.
11031         (riscv_abi_xlen): New function.
11032         (riscv_isa_flen): Update to get answer from isa_features.
11033         (riscv_abi_flen): New function.
11034         (riscv_has_fp_abi): Update to get answer from abi_features.
11035         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11036         xlen and flen.
11037         (riscv_call_info) <xlen, flen>: Update comment.
11038         (riscv_call_arg_struct): Remove invalid assertions
11039         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11040         is removed.
11041         (riscv_gdbarch_init): Gather isa features and abi features
11042         separately, ensure both match on the gdbarch when reusing an old
11043         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11044         a target with 64-bit float hardware.
11045
11046 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11047
11048         * source.c (search_command_helper): Stop reverse search
11049         when line 1 has been searched.
11050
11051 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11052
11053         * record-full.c (record_full_base_target::close): Rewrite
11054         record_full_core_buf_list free logic.
11055
11056 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11057
11058         * break-catch-syscall.c (print_one_catch_syscall): xfree
11059         the last text.
11060
11061 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11062
11063         * top.c (print_gdb_version): Update Copyright year in version
11064         message.
11065
11066 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11067
11068         Update copyright year range in all GDB files.
11069
11070 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11071
11072         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11073
11074 For older changes see ChangeLog-2018.
11075 \f
11076 Local Variables:
11077 mode: change-log
11078 left-margin: 8
11079 fill-column: 74
11080 version-control: never
11081 coding: utf-8
11082 End:
11083