gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_source_window_base::set_new_height)
   4         (tui_source_window_base::do_make_visible_with_new_height): Use
   5         m_has_locator field directly.
   6         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
   7         method.
   8         (struct tui_source_window_base) <has_locator>: Likewise.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  13         Don't declare.
  14         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  15         Remove.
  16         * tui/tui-win.c (tui_source_window_base::set_new_height)
  17         (tui_source_window_base::set_new_height)
  18         (make_invisible_and_set_new_height)
  19         (tui_source_window_base::do_make_visible_with_new_height)
  20         (tui_source_window_base::do_make_visible_with_new_height):
  21         Update.
  22         * tui/tui-layout.c (show_source_disasm_command, show_data)
  23         (show_source_or_disasm_and_command): Update.
  24         * tui/tui-layout.c (show_layout): Update.
  25
  26 2019-07-17  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-layout.c (make_data_window): Remove.
  29         (show_data): Unify creation and re-initialization cases.
  30
  31 2019-07-17  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-layout.c (make_source_window, make_disasm_window):
  34         Remove.
  35         (show_data): Unify creation and re-initialization cases.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-layout.c (make_command_window): Remove.
  40         (show_source_disasm_command, show_source_or_disasm_and_command):
  41         Unify creation and re-initialization cases.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  46         creation and re-initialization cases.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-regs.c (tui_get_register): Return void.
  51
  52 2019-07-17  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  55         Simplify.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  60         resetting.
  61
  62 2019-07-17  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  65         * tui/tui-regs.c (tui_reg_layout): New function.
  66         (tui_show_registers, tui_reg_command): Use it.
  67         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  68         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  69         parameters.
  70         (tui_layout_command): Remove.
  71
  72 2019-07-17  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-layout.h (tui/tui-layout): Return void.
  75         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  76
  77 2019-07-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-layout.c (show_source_disasm_command, show_data):
  80         Update.
  81         (reset_locator): Remove.
  82         (show_source_or_disasm_and_command): Update.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-source.c (tui_source_window_base::reset): Remove
  87         win_type parameter.
  88         * tui/tui-layout.c (make_command_window, make_source_window)
  89         (make_disasm_window, make_data_window)
  90         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  91         (reset_locator, show_source_or_disasm_and_command): Update.
  92         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  93         win_type parameter.
  94         (struct tui_source_window_base) <reset>: Likewise.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-layout.c (show_source_disasm_command): Use
  99         reset_locator.
 100         (reset_locator): New function.
 101         (init_and_make_win): Remove.
 102         (show_source_or_disasm_and_command): Use reset_locator.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 107         condition.
 108         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 109         Remove condition.
 110         * tui/tui-source.c (tui_source_window_base::reset): New method.
 111         * tui/tui-layout.c (make_command_window): Don't call
 112         init_and_make_win.
 113         (make_source_window, make_disasm_window): Don't call
 114         make_source_or_disasm_window.
 115         (make_data_window): Don't call init_and_make_win.  Change calling
 116         convention.
 117         (show_source_disasm_command, show_data): Simplify.
 118         (make_source_or_disasm_window): Remove.
 119         (show_source_or_disasm_and_command): Simplify.
 120         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 121         (struct tui_source_window_base) <reset>: Likewise.
 122         <execution_info>: Remove initializer.
 123         * tui/tui-data.c (tui_source_window_base): Initialize
 124         execution_info.
 125
 126 2019-07-17  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 129         variable.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui.c (tui_rl_other_window): Update.
 134         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 135         superclass method first.  Always iterate over regs_content.
 136         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 137         method.
 138         * tui/tui-win.c (tui_set_focus_command): Update.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-win.c (tui_set_focus_command): Rename from
 143         tui_set_focus.  Call tui_enable.
 144         (tui_set_focus_command): Remove.
 145
 146 2019-07-17  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 149         refresh_window.
 150         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 151         touchwin.
 152         (tui_data_window::refresh_window): Call refresh_window on data
 153         items.  Always call superclass refresh_window.
 154         (tui_win_info::refresh): Remove.
 155         (tui_source_window_base::refresh_window): Update.
 156         (tui_refresh_all): Update.
 157         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 158         refresh_window.
 159         (show_source_or_disasm_and_command): Likewise.
 160         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 161         (struct tui_source_window_base) <refresh>: Likewise.
 162
 163 2019-07-17  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-winsource.c (tui_clear_source_content)
 166         (tui_show_source_content): Update.
 167         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 168         whether content is empty.
 169         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 170         Remove.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 175         window's contents.
 176         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 177         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 182         (struct tui_data_item_window): Update.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 187         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 188         defines.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-winsource.h (tui_erase_source_content)
 193         (tui_clear_source_content): Remove "display_prompt" parameter.
 194         * tui/tui-winsource.c (tui_update_source_window_as_is)
 195         (tui_update_source_windows_with_addr): Update.
 196         (tui_clear_source_content): Remove "display_prompt" parameter.
 197         (tui_erase_source_content): Likewise.  Simplify.
 198         (tui_show_source_content): Update.
 199         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 200         * tui/tui-stack.c (tui_show_frame_info): Update.
 201         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 202         Remove defines.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 207         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 208         parameter.
 209         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 210         parameter.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-winsource.c (tui_clear_source_content)
 215         (tui_show_source_content, tui_show_exec_info_content)
 216         (tui_clear_exec_info_content): Update.
 217         * tui/tui-stack.c (tui_show_locator_content): Update.
 218         (tui_show_frame_info): Update.
 219         * tui/tui-source.h (tui_source_window): Don't declare.
 220         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 221         from tui_source_is_displayed.
 222         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 223         Remove field.
 224         (struct tui_source_window_base) <content_in_use>: New field.  Now
 225         bool.
 226         (struct tui_source_window) <showing_source_p>: New method.
 227         (TUI_SRC_WIN): Change cast.
 228         * tui/tui-data.c (tui_initialize_static_data): Update.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 233         location_matches_p.
 234         * tui/tui-source.c (tui_source_window::location_matches_p): New
 235         method.
 236         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 237         method.
 238         * tui/tui-data.h (struct tui_source_window_base)
 239         <location_matches_p>: New method.
 240         (struct tui_source_window, struct tui_disasm_window)
 241         <location_matches_p>: Likewise.
 242
 243 2019-07-17  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-win.c (tui_set_win_height_command): Rename from
 246         tui_set_win_height.
 247         (tui_set_win_height_command): Remove.
 248
 249 2019-07-17  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-source.c (tui_source_window): New constructor.  Add
 252         observer.
 253         (~tui_source_window): New destructor.
 254         (tui_source_window::style_changed): New method.
 255         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 256         (tui_attach_detach_observers): Update.
 257         * tui/tui-data.h (struct tui_source_window): Make constructor not
 258         inline.  Add destructor.
 259         (struct tui_source_window) <style_changed>: New method.
 260         <m_observable>: New member.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 265         * tui/tui-win.c (tui_resize_all): Fix typo.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 270         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 271         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 272         * tui/tui-win.c (window_name_completer): Use foreach.
 273         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 274         (update_tab_width): Likewise.
 275         * tui/tui-layout.c (show_layout): Update.
 276         * tui/tui-data.h (class tui_window_iterator): New.
 277         (struct all_tui_windows): New.
 278         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 279
 280 2019-07-17  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 283         parameter.  Don't reference globals.
 284         (tui_reg_command): Update.
 285
 286 2019-07-17  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-regs.c (tui_show_registers): Simplify.
 289
 290 2019-07-17  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-regs.c (tui_show_registers): Update.
 293         (tui_show_register_group): Add win_info parameter.
 294
 295 2019-07-17  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 298         Rename from tui_display_reg_element_at_line.
 299         (tui_data_window::display_registers_from_line): Update.
 300         * tui/tui-data.h (struct tui_data_window)
 301         <display_reg_element_at_line>: New method.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-regs.h (tui_display_registers_from)
 306         (tui_display_registers_from_line): Don't declare.
 307         * tui/tui-windata.c (tui_data_window::display_all_data)
 308         (tui_data_window::refresh_all)
 309         (tui_data_window::do_scroll_vertical): Update.
 310         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 311         from tui_display_registers_from.
 312         (tui_display_reg_element_at_line): Update.
 313         (tui_data_window::display_registers_from_line): Rename from
 314         tui_display_registers_from_line.
 315         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 316         display_registers_from_line>: New methods.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 321         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 322         from tui_erase_data_content.
 323         (tui_data_window::display_all_data)
 324         (tui_data_window::refresh_all)
 325         (tui_data_window::do_scroll_vertical): Update.
 326         * tui/tui-regs.c (tui_show_registers): Update.
 327         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 328         New method.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 333         declare.
 334         * tui/tui-windata.c
 335         (tui_data_window::delete_data_content_windows): Rename from
 336         tui_delete_data_content_windows.
 337         (tui_data_window::display_all_data)
 338         (tui_data_window::do_scroll_vertical): Update.
 339         * tui/tui-data.h (struct tui_data_window)
 340         <delete_data_content_windows>: New method.
 341
 342 2019-07-17  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 345         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 346
 347 2019-07-17  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 350         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 351         from tui_display_all_data.
 352         * tui/tui-win.c
 353         (tui_data_window::do_make_visible_with_new_height): Update.
 354         * tui/tui-regs.c (tui_show_registers): Update.
 355         * tui/tui-layout.c (tui_set_layout): Update.
 356         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 357         method.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 362         * tui/tui-windata.c (tui_display_data_from): Remove.
 363         (tui_data_window::refresh_all): Update.
 364
 365 2019-07-17  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 368         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 369         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 370         tui_display_registers_from_line.
 371         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 372         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 373         "force_display" parameter.
 374
 375 2019-07-17  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 378         declare.
 379         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 380         Rename from tui_first_reg_element_no_inline.
 381         (tui_display_reg_element_at_line)
 382         (tui_display_registers_from_line): Update.
 383         * tui/tui-data.h (struct tui_data_window)
 384         <first_reg_element_no_inline>: New method.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-windata.c (tui_display_data_from)
 389         (tui_data_window::do_scroll_vertical): Update.
 390         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 391         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 392         Rename from tui_line_from_reg_element_no.
 393         (tui_display_registers_from_line): Update.
 394         * tui/tui-data.h (struct tui_data_window)
 395         <line_from_reg_element_no>: New method.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 400         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 401         tui_last_regs_line_no.
 402         (tui_display_reg_element_at_line)
 403         (tui_display_registers_from_line): Update.
 404         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 405         method.
 406
 407 2019-07-17  Tom Tromey  <tom@tromey.com>
 408
 409         PR tui/24722:
 410         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 411         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 412         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 413         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 414         (tui_update_breakpoint_info): Likewise.
 415         * tui/tui-hooks.c (tui_event_create_breakpoint)
 416         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 417         Update.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-winsource.c (tui_update_source_window_as_is)
 426         (tui_update_source_windows_with_addr): Update.
 427         * tui/tui-source.h (tui_set_source_content)
 428         (tui_show_symtab_source): Add "win_info" parameter.
 429         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 430         parameter.
 431         (tui_show_symtab_source): Likewise.
 432
 433 2019-07-17  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-wingeneral.c
 436         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 441         (struct tui_cmd_window) <can_scroll>: New method.
 442         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 443         method.
 444
 445 2019-07-17  Tom Tromey  <tromey@adacore.com>
 446
 447         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 448         do_field_signed>: Rename.  Change type of "value".
 449         * ui-out.c (ui_out::field_signed): Rename from field_int.
 450         Change type of "value".
 451         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 452         type of "value".
 453         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 454         do_field_int.  Change type of "value".
 455         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 456         do_field_int.  Change type of "value".
 457         * tracepoint.c (trace_status_mi, tfind_1)
 458         (print_one_static_tracepoint_marker): Update.
 459         * thread.c (print_thread_info_1, print_selected_thread_frame):
 460         Update.
 461         * stack.c (print_frame, print_frame_info): Update.
 462         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 463         Update.
 464         * source.c (print_source_lines_base): Update.
 465         * skip.c (info_skip_command): Update.
 466         * record-btrace.c (btrace_ui_out_decode_error)
 467         (btrace_call_history_src_line): Update.
 468         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 469         Update.
 470         * progspace.c (print_program_space): Update.
 471         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 472         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 473         do_field_int.  Change type of "value".
 474         * mi/mi-out.c (mi_ui_out::do_table_begin)
 475         (mi_ui_out::do_table_header): Update.
 476         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 477         type of "value".
 478         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 479         (mi_cmd_data_list_changed_registers, output_register)
 480         (mi_cmd_data_read_memory, mi_load_progress)
 481         (mi_cmd_trace_frame_collected): Update.
 482         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 483         Update.
 484         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 485         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 486         (mi_cmd_var_list_children, varobj_update_one): Update.
 487         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 488         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 490         * inferior.c (print_inferior): Update.
 491         * gdb_bfd.c (print_one_bfd): Update.
 492         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 493         Update.
 494         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 495         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 496         do_field_int.  Change type of "value".
 497         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 498         do_field_int.  Change type of "value".
 499         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 500         (print_one_breakpoint_location, print_it_catch_fork)
 501         (print_one_catch_fork, print_it_catch_vfork)
 502         (print_one_catch_vfork, print_it_catch_solib)
 503         (print_it_catch_exec, print_it_ranged_breakpoint)
 504         (print_mention_watchpoint, print_mention_masked_watchpoint)
 505         (bkpt_print_it, update_static_tracepoint): Update.
 506         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 507         * break-catch-syscall.c (print_it_catch_syscall): Update.
 508         * ada-tasks.c (print_ada_task_info): Update.
 509         * ada-lang.c (print_it_exception, print_mention_exception):
 510         Update.
 511
 512 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 513
 514         PR breakpoints/24541
 515         * gdbarch.c: Regenerate.
 516         * gdbarch.h: Regenerate.
 517         * gdbarch.sh: Adjust return type and parameter types for
 518         'stap_adjust_register'.
 519         (i386_stap_adjust_register): Adjust signature and return new
 520         register name.
 521         * stap-probe.c (stap_parse_register_operand): Adjust use of
 522         'gdbarch_stap_adjust_register'.
 523
 524 2019-07-17  Tom Tromey  <tromey@adacore.com>
 525
 526         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 527         declare VEC.
 528         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 529         std::vector.
 530         (struct s390_process_info): Add initializers.
 531         (s390_add_process): Use new.
 532         (s390_linux_nat_target::low_forget_process): Use delete.
 533         (s390_linux_nat_target::low_new_fork)
 534         (s390_linux_nat_target::stopped_by_watchpoint)
 535         (s390_linux_nat_target::low_prepare_to_resume)
 536         (s390_linux_nat_target::insert_watchpoint)
 537         (s390_linux_nat_target::insert_hw_breakpoint)
 538         (s390_linux_nat_target::remove_watchpoint)
 539         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 540
 541 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 542
 543         * aarch64-fbsd-nat.c: Include regcache.h.
 544         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 545         argument.
 546         (aarch64_fbsd_nat_target::fetch_registers)
 547         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 548         variable.
 549         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 550
 551 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 552
 553         * fbsd-nat.c: Include gdbarch.h.
 554
 555 2019-07-15  Tom Tromey  <tromey@adacore.com>
 556
 557         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 558
 559 2019-07-15  Tom Tromey  <tromey@adacore.com>
 560
 561         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 562         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 563         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 564         * cli-out.c (cli_ui_out::do_field_int): New method.
 565         * ui-out.c (ui_out::field_unsigned): New method.
 566         * symfile.c (generic_load): Use field_unsigned.
 567         (print_transfer_performance): Likewise.
 568         * record-btrace.c (ui_out_field_uint): Remove.
 569         (btrace_call_history_insn_range, btrace_call_history): Use
 570         field_unsigned.
 571         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 572         field_unsigned.
 573         * ui-out.h (class ui_out) <field_unsigned>: New method.
 574         <do_field_unsigned>: Likewise.
 575
 576 2019-07-15  Tom Tromey  <tromey@adacore.com>
 577
 578         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 579         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 580         * target.c (flash_erase_command): Use field_string.
 581         * infrun.c (print_signal_received_reason): Use field_string.
 582         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 583         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 584         field_string.
 585         * ada-tasks.c (print_ada_task_info): Use field_string.
 586
 587 2019-07-15  Tom Tromey  <tromey@adacore.com>
 588
 589         * target.c (flash_erase_command): Use field_core_addr.
 590         * symfile.c (generic_load): Use field_core_addr.
 591         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 592         Use field_core_addr.
 593         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 594         field_core_addr.
 595
 596 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 599         value if its desired type is smaller than a CORE_ADDR and signed.
 600
 601 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 604         of changes to field names, and use new is_reference field to
 605         decide if a property is a reference or not.
 606         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 607         field.
 608         (struct dwarf2_property_baton): Update header comment, rename
 609         'referenced_type' to 'property_type' and update comments.
 610         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 611         default property type, store in property baton, update to take
 612         accound of renamed field.
 613         (read_func_scope): Update call to attr_to_dynamic_prop.
 614         (read_array_type): Likewise.
 615         (dwarf2_per_cu_addr_sized_int_type): New function.
 616         (read_subrange_index_type): Move type finding code to
 617         dwarf2_per_cu_addr_sized_int_type.
 618         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 619         (dwarf2_per_cu_addr_type): New function.
 620         (set_die_type): Update calls to attr_to_dynamic_prop.
 621
 622 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 623
 624         * dwarf2read.c (read_subrange_index_type): New function.
 625         (read_subrange_type): Move code into new function and call it.
 626         * gdbtypes.c (create_range_type): Add some asserts.
 627
 628 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 631         update return statements.
 632         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 633         declaration, and update comment to match.
 634         * gdbtypes.c (resolve_dynamic_array): Update call to
 635         dwarf2_evaluate_property to match new return type.
 636
 637 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * valarith.c (value_subscripted_rvalue): Change lowerbound
 640         parameter type from int to LONGEST.
 641         * value.h (value_subscripted_rvalue): Likewise in declaration.
 642
 643 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * cli/cli-utils.c (info_print_command_completer): New function.
 646         * cli/cli-utils.h: Add 'completer.h' include, and forward
 647         declaration for 'struct cmd_list_element'.
 648         (info_print_command_completer): Declare.
 649         * stack.c (_initialize_stack): Add completer for 'info locals' and
 650         'info args'.
 651         * symtab.c (_initialize_symtab): Add completer for 'info
 652         variables' and 'info functions'.
 653         * NEWS: Mention completion for additional info commands.
 654
 655 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * cli/cli-utils.c (extract_info_print_args): Delete.
 658         (extract_arg_maybe_quoted): Delete.
 659         (info_print_options_defs): New variable.
 660         (make_info_print_options_def_group): New function.
 661         (extract_info_print_options): Define new function.
 662         * cli/cli-utils.h (extract_info_print_args): Delete.
 663         (struct info_print_options): New structure.
 664         (extract_info_print_options): Declare new function.
 665         * stack.c (info_locals_command): Update to use new
 666         extract_info_print_options, also add a header comment.
 667         (info_args_command): Likewise.
 668         * symtab.c (info_variables_command): Likewise.
 669         (info_functions_command): Likewise.
 670
 671 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 672
 673         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 674         to extract string arguments.
 675         * common/common-utils.c (extract_string_maybe_quoted): New function.
 676         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 677
 678 2019-07-11  Tom Tromey  <tromey@adacore.com>
 679
 680         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 681         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 682         * top.h (gdbinit): Don't declare.
 683         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 684         into...
 685         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 686         * top.c (gdb_init): Don't call init_cli_cmds.
 687         (gdbinit): Remove.
 688         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 689
 690 2019-07-11  Tom Tromey  <tromey@adacore.com>
 691
 692         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 693         after it has been moved.
 694
 695 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 696
 697         * valops.c (value_must_coerce_to_target): Change return type to
 698         bool.
 699         * value.h (value_must_coerce_to_target): Likewise.
 700
 701 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 702
 703         * breakpoint.c (is_hardware_watchpoint): Remove
 704         forward-declaration.
 705         (is_masked_watchpoint): Change return type to bool.
 706         (is_tracepoint): Likewise.
 707         (is_breakpoint): Likewise.
 708         (is_hardware_watchpoint): Likewise.
 709         (is_watchpoint): Likewise.
 710         (is_no_memory_software_watchpoint): Likewise.
 711         (is_catchpoint): Likewise.
 712         (breakpoint_1): Make FILTER parameter's return type bool.
 713         is_masked_watchpoint): Change return type to bool.
 714         (save_breakpoints): Make FILTER parameter's return type bool.
 715         * breakpoint.h (is_breakpoint): Change return type to bool.
 716         (is_watchpoint): Likewise.
 717         (is_catchpoint): Likewise.
 718         (is_tracepoint): Likewise.
 719
 720 2019-07-10  Tom Tromey  <tom@tromey.com>
 721
 722         * defs.h: Don't include gdbarch.h.
 723         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 724         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 725         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 726         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 727         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 728         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 729         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 730         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 731         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 732         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 733         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 734         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 735         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 736         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 737         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 738         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 739         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 740         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 741         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 742         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 743         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 744         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 745         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 746         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 747         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 748         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 749         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 750
 751 2019-07-10  Tom Tromey  <tromey@adacore.com>
 752
 753         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 754         * breakpoint.c (init_ada_exception_breakpoint): Register as
 755         bp_catchpoint.
 756         (print_one_breakpoint_location, print_one_breakpoint): Use
 757         is_ada_exception_catchpoint.
 758         * ada-lang.c (class ada_catchpoint_location): Pass
 759         bp_loc_software_breakpoint to bp_location constructor.
 760         (is_ada_exception_catchpoint): New function.
 761
 762 2019-07-10  Tom Tromey  <tromey@adacore.com>
 763
 764         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 765         VEC.
 766         (struct arm_exidx_entry): New method operator<.
 767         (struct arm_exidx_data) <section_maps>: Change type.
 768         (arm_exidx_data_free): Remove.
 769         (arm_exidx_data_key): Change type.  Move lower.
 770         (arm_exidx_new_objfile): Update.
 771         (arm_compare_exidx_entries): Remove.
 772         (arm_find_exidx_entry, _initialize_arm_tdep)
 773
 774 2019-07-10  Tom Tromey  <tromey@adacore.com>
 775
 776         * solib-spu.c (ocl_program_data_key): Change type.
 777         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 778         Update.
 779
 780 2019-07-10  Tom Tromey  <tromey@adacore.com>
 781
 782         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 783         (struct solib_aix_inferior_data) <library_list>: Change type.
 784         (solib_aix_inferior_data_handle): Change type.
 785         (get_solib_aix_inferior_data): Update.
 786         (solib_aix_free_library_list): Remove.
 787         (library_list_start_library): Update.
 788         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 789         return type.
 790         (solib_aix_get_library_list)
 791         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 792         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 793
 794 2019-07-10  Tom Tromey  <tromey@adacore.com>
 795
 796         * solib-dsbt.c (struct dsbt_info): Add initializers.
 797         (solib_dsbt_pspace_data): Change type.
 798         (dsbt_pspace_data_cleanup): Remove.
 799         (get_dsbt_info, _initialize_dsbt_solib): Update.
 800
 801 2019-07-10  Tom Tromey  <tromey@adacore.com>
 802
 803         * spu-tdep.c (spu_overlay_data): Change type.
 804         (spu_get_overlay_table, spu_overlay_new_objfile)
 805         (_initialize_spu_tdep): Update.
 806
 807 2019-07-10  Tom Tromey  <tromey@adacore.com>
 808
 809         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 810         destructor.
 811         (dbx_objfile_data_key): Change type and declare later.
 812         (DBX_SYMFILE_INFO): Rewrite.
 813         * dbxread.c (dbx_objfile_data_key): Change type.
 814         (dbx_symfile_init): Update.
 815         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 816         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 817         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 818
 819 2019-07-10  Tom Tromey  <tromey@adacore.com>
 820
 821         * jit.c (jit_program_space_key): Change type.  Move lower.
 822         (get_jit_program_space_data): Update.
 823         (jit_program_space_data_cleanup): Remove.
 824         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 825         Update.
 826         (struct jit_program_space_data): Add initializers.
 827
 828 2019-07-10  Tom Tromey  <tromey@adacore.com>
 829
 830         * solib-darwin.c (struct darwin_info): Add initializers.
 831         (solib_darwin_pspace_data): Change type.
 832         (darwin_pspace_data_cleanup): Remove.
 833         (get_darwin_info, _initialize_darwin_solib): Update.
 834
 835 2019-07-10  Tom Tromey  <tromey@adacore.com>
 836
 837         * remote-sim.c (struct sim_inferior_data): Add initializers,
 838         constructor, and destructor.
 839         (sim_inferior_data_key): Change type.  Move lower.
 840         (check_for_duplicate_sim_descriptor): Update.
 841         (get_sim_inferior_data): Use new.  Update.
 842         (~sim_inferior_data_cleanup): Rename from
 843         sim_inferior_data_cleanup.  Simplify.
 844         (gdbsim_close_inferior, simulator_command)
 845         (sim_command_completer, _initialize_remote_sim): Update.
 846         (next_pid, INITIAL_PID): Move earlier.
 847
 848 2019-07-10  Tom Tromey  <tromey@adacore.com>
 849
 850         * python/python-internal.h (create_thread_object): Return
 851         gdbpy_ref.
 852         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 853         * python/py-inferior.c (struct threadlist_entry): Add
 854         constructor.
 855         <thread_obj>: Now a gdbpy_ref.
 856         (thread_to_thread_object): Update.
 857         (add_thread_object): Use new.
 858         (delete_thread_object): Use delete.
 859         (infpy_threads): Update.
 860         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 861         GIL.
 862
 863 2019-07-10  Tom Tromey  <tromey@adacore.com>
 864
 865         * valops.c (value_cast): Specialize error message for Ada.
 866
 867 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 868
 869         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 870
 871 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 872
 873         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 874         bpstat_should_step): Return bool, adjust comments.
 875         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 876         bpstat_should_step): Likewise.
 877
 878 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 879
 880         * features/Makefile: Use feature target descriptions for Arm.
 881         * features/arm/arm-core.c: Generate new file.
 882         * features/arm/arm-fpa.c: Likewise.
 883         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 884         * features/arm/arm-m-profile.c: Likewise.
 885         * features/arm/arm-vfpv2.c: Likewise.
 886         * features/arm/arm-vfpv3.c: Likewise.
 887         * features/arm/xscale-iwmmxt.c: Likewise.
 888         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 889
 890 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 893         ptrace earlier.
 894
 895 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 896
 897         * features/aarch64-pauth.c: Regenerate.
 898
 899 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 900
 901         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 902         bool.
 903         (bpstat_what): Use false instead of 0.
 904
 905 2019-07-09  Pedro Alves  <palves@redhat.com>
 906
 907         * break-catch-throw.c (is_exception_catchpoint): New.
 908         * breakpoint.c (print_one_breakpoint_location): New parameter
 909         'raw_loc'.  Handle it.  Use
 910         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 911         looking at the breakpoint's type.
 912         (print_one_breakpoint): If handling "maint info breakpoints", also
 913         print locations of exception catchpoints.
 914         * breakpoint.h (is_exception_catchpoint): Declare.
 915
 916 2019-07-09  Pedro Alves  <palves@redhat.com>
 917
 918         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 919         "addr" field.
 920         (allocate_location_exception_catchpoint): New.
 921         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 922         (initialize_throw_catchpoint_ops): Install
 923         allocate_location_exception_catchpoint as allocate_location
 924         method.
 925         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 926         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 927         bp_loc_other.
 928         (breakpoint_address_is_meaningful): Delete.
 929         (bl_address_is_meaningful): New.
 930         (breakpoint_locations_match): Adjust comment.
 931         (bp_location_from_bp_type): New, factored out of...
 932         (bp_location::bp_location(breakpoint *)): ... this.
 933         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 934         factored out of...
 935         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 936         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 937         breakpoint_address_is_meaningful.
 938         (bp_locations_compare): Adjust comment.
 939         (update_global_location_list): Use bl_address_is_meaningful
 940         instead of breakpoint_address_is_meaningful.
 941         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 942         explicit.
 943         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 944         * python/py-breakpoint.c (bppy_get_location): No longer check
 945         whether location is null.
 946
 947 2019-07-09  Pedro Alves  <palves@redhat.com>
 948
 949         PR c++/15468
 950         * breakpoint.c (print_one_breakpoint_location): Remove
 951         single-location assert.
 952
 953 2019-07-09  Tom Tromey  <tom@tromey.com>
 954
 955         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 956         * configure: Rebuild.
 957         * configure.ac: Change common to gdbsupport.
 958         * gdbsupport: Rename from common.
 959         * acinclude.m4: Change common to gdbsupport.
 960         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 961         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 962         gdbsupport.
 963         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 964         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 965         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 966         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 967         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 968         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 969         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 970         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 971         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 972         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 973         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 974         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 975         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 976         coff-pe-read.c, command.h, compile/compile-c-support.c,
 977         compile/compile-c.h, compile/compile-cplus-symbols.c,
 978         compile/compile-cplus-types.c, compile/compile-cplus.h,
 979         compile/compile-loc2c.c, compile/compile.c, completer.c,
 980         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 981         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 982         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 983         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 984         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 985         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 986         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 987         features/aarch64-core.c, features/aarch64-fpu.c,
 988         features/aarch64-pauth.c, features/aarch64-sve.c,
 989         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 990         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 991         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 992         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 993         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 994         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 995         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 996         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 997         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 998         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 999         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1000         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1001         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1002         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1003         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1004         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1005         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1006         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1007         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1008         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1009         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1010         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1011         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1012         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1013         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1014         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1015         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1016         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1017         minsyms.c, mips-linux-tdep.c, namespace.h,
1018         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1019         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1020         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1021         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1022         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1023         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1024         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1025         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1026         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1027         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1028         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1029         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1030         procfs.c, producer.c, progspace.h, psymtab.h,
1031         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1032         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1033         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1034         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1035         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1036         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1037         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1038         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1039         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1040         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1041         target-memory.c, target.c, target.h, target/waitstatus.c,
1042         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1043         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1044         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1045         unittests/array-view-selftests.c,
1046         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1047         unittests/common-utils-selftests.c,
1048         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1049         unittests/format_pieces-selftests.c,
1050         unittests/function-view-selftests.c,
1051         unittests/lookup_name_info-selftests.c,
1052         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1053         unittests/mkdir-recursive-selftests.c,
1054         unittests/observable-selftests.c,
1055         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1056         unittests/parse-connection-spec-selftests.c,
1057         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1058         unittests/scoped_fd-selftests.c,
1059         unittests/scoped_mmap-selftests.c,
1060         unittests/scoped_restore-selftests.c,
1061         unittests/string_view-selftests.c, unittests/style-selftests.c,
1062         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1063         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1064         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1065         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1066         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1067         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1068
1069 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1070
1071         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1072         bool value.
1073         (decode_digits_ordinary): Set explicit_line field in sal.
1074         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1075         symtab_and_line that was set on an explicit line number in
1076         assembler code.  Do always update the recorded symtab and line if
1077         we do skip the prologue.
1078
1079 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * breakpoint.c (set_breakpoint_location_function): Remove
1082         explicit_loc parameter.
1083         (momentary_breakpoint_from_master): Update call to
1084         set_breakpoint_location_function.
1085         (add_location_to_breakpoint): Likewise.
1086
1087 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1088
1089         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1090         required features based on default bfd type when no specific bfd
1091         is present.
1092
1093 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1094
1095         * NEWS: Mention that GDB printf and eval commands can now print
1096         C-style and Ada-style convenience var strings without
1097         calling the inferior.
1098         * printcmd.c (printf_c_string): Locally print GDB internal var
1099         instead of transiting via the inferior.
1100         (printf_wide_c_string): Likewise.
1101
1102 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1103
1104         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1105
1106 2019-07-04  Tom Tromey  <tom@tromey.com>
1107
1108         PR tui/24724:
1109         * tui/tui-winsource.c (tui_clear_source_content): Update.
1110         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1111         (tui_update_breakpoint_info): Update.
1112         (tui_set_exec_info_content): Update.
1113         * tui/tui-source.c (tui_set_source_content_nil): Update.
1114         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1115         has_break.
1116         * tui/tui-data.h (enum tui_bp_flag): New.
1117         (tui_bp_flags): New enum flags type.
1118         (struct tui_source_element) <break_mode>: Change type.  Rename
1119         from has_break.
1120         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1121         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1122         constants.
1123         * tui/tui-winsource.h: Fix comment.
1124
1125 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1126
1127         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1128         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1129         (store_fpregs_to_thread)
1130         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1131         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1132         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1133         (IWMMXT_REGS_SIZE): Add define.
1134         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1135         (fetch_vfp_regs, store_vfp_regs)
1136         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1137         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1138
1139 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1140
1141         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1142         defines.
1143         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1144         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1145         (ARM_INT_REGISTER_SIZE): ...to this.
1146         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1147         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1148         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1149         (arm_linux_collect_gregset, supply_nwfpe_register)
1150         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1151         defines.
1152         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1153         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1154         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1155         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1156         (arm_return_in_memory, arm_store_return_value)
1157         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1158         (arm_record_ld_st_multiple): Likewise.
1159         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1160         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1161
1162 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1163
1164         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1165         AARCH64_DISPLACED_MODIFIED_INSNS.
1166         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1167         (aarch64_displaced_step_copy_insn): Likewise.
1168         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1169         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1170         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1171         ARM_DISPLACED_MODIFIED_INSNS.
1172         * arm-tdep.c (arm_gdbarch_init): Likewise.
1173         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1174         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1175         (struct arm_displaced_step_closure): Use
1176         ARM_DISPLACED_MODIFIED_INSNS.
1177
1178 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1179
1180         * features/Makefile: Remove unused xml files.
1181         * features/aarch64.xml: Remove.
1182         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1183         * features/i386/amd64-avx-avx512.xml: Remove.
1184         * features/i386/amd64-avx-linux.xml: Remove.
1185         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1186         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1187         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1188         * features/i386/amd64-avx-mpx.xml: Remove.
1189         * features/i386/amd64-avx.xml: Remove.
1190         * features/i386/amd64-linux.xml: Remove.
1191         * features/i386/amd64-mpx-linux.xml: Remove.
1192         * features/i386/amd64-mpx.xml: Remove.
1193         * features/i386/amd64.xml: Remove.
1194         * features/i386/i386-avx-avx512-linux.xml: Remove.
1195         * features/i386/i386-avx-avx512.xml: Remove.
1196         * features/i386/i386-avx-linux.xml: Remove.
1197         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1198         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1199         * features/i386/i386-avx-mpx-linux.xml: Remove.
1200         * features/i386/i386-avx-mpx.xml: Remove.
1201         * features/i386/i386-avx.xml: Remove.
1202         * features/i386/i386-linux.xml: Remove.
1203         * features/i386/i386-mmx-linux.xml: Remove.
1204         * features/i386/i386-mmx.xml: Remove.
1205         * features/i386/i386-mpx-linux.xml: Remove.
1206         * features/i386/i386-mpx.xml: Remove.
1207         * features/i386/i386.xml: Remove.
1208         * features/i386/x32-avx-avx512-linux.xml: Remove.
1209         * features/i386/x32-avx-linux.xml: Remove.
1210         * features/i386/x32-linux.xml: Remove.
1211
1212 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1213
1214         * regformats/aarch64.dat: Remove.
1215         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1216         * regformats/i386/amd64-avx-linux.dat: Remove.
1217         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1218         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1219         * regformats/i386/amd64-linux.dat: Remove.
1220         * regformats/i386/amd64-mpx-linux.dat: Remove.
1221         * regformats/i386/amd64.dat: Remove.
1222         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1223         * regformats/i386/i386-avx-linux.dat: Remove.
1224         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1225         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1226         * regformats/i386/i386-linux.dat: Remove.
1227         * regformats/i386/i386-mmx-linux.dat: Remove.
1228         * regformats/i386/i386-mpx-linux.dat: Remove.
1229         * regformats/i386/i386.dat: Remove.
1230         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1231         * regformats/i386/x32-avx-linux.dat: Remove.
1232         * regformats/i386/x32-linux.dat: Remove.
1233
1234 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1235
1236         * aarch64-tdep.c: Remove xml self tests.
1237         * amd64-linux-tdep.c: Likewise.
1238         * amd64-tdep.c: Likewise.
1239         * i386-linux-tdep.c: Likewise.
1240         * i386-tdep.c: Likewise.
1241
1242 2019-07-03  Pedro Alves  <palves@redhat.com>
1243
1244         PR cli/24732
1245         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1246         (pipe_cmd_option_defs): New.
1247         (make_pipe_cmd_options_def_group): New.
1248         (pipe_command): Use gdb::option::process_options.
1249         (pipe_command_completer): New function.
1250         (_initialize_cli_cmds): Install completer for "pipe" command.
1251
1252 2019-07-03  Pedro Alves  <palves@redhat.com>
1253
1254         * cli/cli-option.c (union option_value) <string>: New field.
1255         (struct option_def_and_value): Add ctor, move ctor, dtor and
1256         use DISABLE_COPY_AND_ASSIGN.
1257         (option_def_and_value::clear_value): New.
1258         (parse_option, save_option_value_in_ctx, get_val_type_str)
1259         (add_setshow_cmds_for_options): Handle var_string.
1260         * cli-option.h (union option_def::var_address) <string>: New
1261         field.
1262         (struct string_option_def): New.
1263         * maint-test-options.c (struct test_options_opts): Add default
1264         ctor and use DISABLE_COPY_AND_ASSIGN.
1265         <string_opt>: New field.
1266         (test_options_opts::~test_options_opts): New.
1267         (test_options_opts::dump): Also dump "-string".
1268         (test_options_option_defs): Install "string.
1269
1270 2019-07-03  Pedro Alves  <palves@redhat.com>
1271
1272         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1273         option_value with a null enumeration.
1274         (complete_options): Save the option values in the context.
1275         (save_option_value_in_ctx): New, factored out from ...
1276         (process_options): ... here.
1277         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1278         of the function.
1279         * maint-test-options.c (test_options_opts::dump): New, factored
1280         out from ...
1281         (maintenance_test_options_command_mode): ... here.
1282         (maintenance_test_options_command_completion_result): Delete.
1283         (maintenance_test_options_command_completion_text): Update
1284         comment.
1285         (maintenance_show_test_options_completion_result): Change
1286         prototype.  Just print
1287         maintenance_test_options_command_completion_text.
1288         (save_completion_result): New.
1289         (maintenance_test_options_completer_mode): Pass options context to
1290         complete_options, and then save a dump.
1291         (_initialize_maint_test_options): Use add_cmd to install "maint
1292         show test-options-completion-result".
1293
1294 2019-07-03  Pedro Alves  <palves@redhat.com>
1295
1296         * NEWS (New commands): Mention "with" and "maint with".
1297         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1298         (with_command, with_command_completer): New.
1299         (pipe_command): Adjust to new repeat_previous
1300         interface.
1301         (_initialize_cli_cmds): Install the "with" command and its "w"
1302         alias.
1303         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1304         declarations.
1305         * cli/cli-setshow.c (parse_cli_var_uinteger)
1306         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1307         argument strings for all var_types.
1308         (get_setshow_command_value_string): New, factored out from ...
1309         (do_show_command): ... this.
1310         * cli/cli-setshow.h: Include <string>.
1311         (get_setshow_command_value_string): Declare.
1312         * command.h (repeat_previous): Now returns const char *.  Adjust
1313         comment.
1314         * maint.c: Include "cli/cli-cmds.h".
1315         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1316         (_initialize_maint_cmds): Register the "maintenance with" command.
1317         * top.c (repeat_previous): Move bits from pipe_command here:
1318         Return the saved command line, if any; error out if there's no
1319         command to relaunch.
1320
1321 2019-07-03  Pedro Alves  <palves@redhat.com>
1322
1323         * NEWS (New commands): Mention "maint set/show test-settings"
1324         instead of "maint test-settings".
1325         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1326         (maintenance_test_settings_set_list): Rename to ...
1327         (maintenance_set_test_settings_list): ... this.
1328         (maintenance_test_settings_show_list): Rename to  ...
1329         (maintenance_show_test_settings_list): ... this.
1330         (maintenance_test_settings_cmd): Delete.
1331         (maintenance_test_settings_set_cmd): ...
1332         (maintenance_set_test_settings_cmd): ... this.
1333         (maintenance_test_settings_show_cmd): ...
1334         (maintenance_show_test_settings_cmd): ... this.
1335         (maintenance_test_settings_show_value_cmd):
1336         (maintenance_show_test_settings_value_cmd): ... this.
1337         (_initialize_maint_test_settings): No longer install the "maint
1338         test-settings" prefix command.  Rename "maint test-settings set"
1339         to "maint set test-settings", and "maint test-settings show" to
1340         "maint show test-settings".  Adjust all subcommands.
1341
1342 2019-07-03  Pedro Alves  <palves@redhat.com>
1343
1344         * maint-test-settings.c: Fix file's intro comment.  Replace all
1345         references to "test-options" with references to "test-settings",
1346         in comments.
1347
1348 2019-07-03  Pedro Alves  <palves@redhat.com>
1349
1350         * maint-test-settings.c (maintenance_test_settings_xxx)
1351         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1352         New.
1353         (maintenance_test_settings_enums): Use them.
1354         (maintenance_test_settings_enum): Default to
1355         maintenance_test_settings_xxx.
1356         (_initialize_maint_test_settings): Initialize
1357         MAINTENANCE_TEST_SETTINGS_FILENAME.
1358
1359 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1360
1361         * breakpoint.h (remove_breakpoints_inf): Change return type to
1362         void, move function documentation here.
1363         * breakpoint.c (remove_breakpoints_inf): Change return type to
1364         void, move function documentation to header.
1365
1366 2019-07-02  Pedro Alves  <palves@redhat.com>
1367
1368         * NEWS (Completion improvements): Mention "info threads".
1369         * thread.c (struct info_threads_opts, info_threads_option_defs)
1370         (make_info_threads_options_def_group): New.
1371         (info_threads_command): Use gdb::option::process_options.
1372         (info_threads_command_completer): New.
1373         (_initialize_thread): Use gdb::option::build_help to build the
1374         help text for "info threads".
1375
1376 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1377
1378         * defs.h (generic_load): Move from here...
1379         * symfile.h (generic_load): ... to here.  Rename name parameter
1380         to args.
1381         * symfile.c (generic_load): Add comment.
1382
1383 2019-07-01  Tom Tromey  <tromey@adacore.com>
1384
1385         * dwarf2read.c
1386         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1387         declaration of without_params.  Fix formatting.
1388
1389 2019-07-01  Tom Tromey  <tromey@adacore.com>
1390
1391         * ada-exp.y (find_primitive_type): Update.
1392         * ada-lang.h (ada_lookup_symbol): Update.
1393         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1394         parameter.
1395         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1396
1397 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1398
1399         PR breakpoints/24541
1400         * gdbarch.c: Regenerate.
1401         * gdbarch.h: Regenerate.
1402         * gdbarch.sh: Add 'stap_adjust_register'.
1403         * i386-tdep.c: Include '<unordered_set>'.
1404         (i386_stap_adjust_register): New function.
1405         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1406         * stap-probe.c (stap_parse_register_operand): Call
1407         'gdbarch_stap_adjust_register'.
1408
1409 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1410
1411         PR python/24742
1412         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1413         * python/python.c (do_start_initialization): Use 'xmalloc'
1414         instead of 'PyMem_Malloc'.
1415
1416 2019-06-28  Tom Tromey  <tromey@adacore.com>
1417
1418         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1419         for Ada.
1420
1421 2019-06-27  Tom Tromey  <tromey@adacore.com>
1422
1423         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1424         objfile_key.
1425         (arm_find_mapping_symbol, arm_record_special_symbol)
1426         (_initialize_arm_tdep): Update.
1427         (arm_objfile_data_free): Remove.
1428
1429 2019-06-27  Tom Tromey  <tromey@adacore.com>
1430
1431         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1432         to cp_print_static_field.
1433
1434 2019-06-26  Tom Tromey  <tromey@adacore.com>
1435
1436         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1437         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1438         declare.
1439
1440 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1441
1442         * features/aarch64-core.c (create_feature_aarch64_core):
1443         Regenerate.
1444         * features/aarch64-core.xml: Add cpsr flags.
1445
1446 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1447
1448         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1449         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1450
1451 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1452
1453         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1454         field.
1455         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1456         use.
1457         (arm_record_special_symbol): Don't insert new symbol in sorted
1458         position, push it at the end.
1459
1460 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1461
1462         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1463         (arm_mapping_symbol_s): Remove.
1464         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1465         (arm_mapping_symbol_vec): New typedef.
1466         (struct arm_per_objfile): Add constructor.
1467         <section_maps>: Change type to
1468         std::unique_ptr<arm_mapping_symbol_vec[]>.
1469         (arm_compare_mapping_symbols): Remove.
1470         (arm_find_mapping_symbol): Adjust to section_maps type change.
1471         (arm_objfile_data_free): Call delete on arm_per_objfile.
1472         (arm_record_special_symbol): Adjust to section_maps type change.
1473         Allocate arm_per_objfile with new.
1474
1475 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1478         with the command prefix.
1479
1480 2019-06-25  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1483         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1488         type.
1489         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1490         protected.
1491
1492 2019-06-25  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-winsource.c
1495         (tui_source_window_base::set_is_exec_point_at): Add check against
1496         LOA_ADDRESS.
1497
1498 2019-06-25  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-source.c (tui_set_source_content): Don't check before
1501         xfree.
1502         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1503
1504 2019-06-25  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-winsource.h (tui_update_source_window_as_is)
1507         (tui_alloc_source_buffer, tui_line_is_displayed)
1508         (tui_addr_is_displayed): Change type of win_info.
1509         * tui/tui-winsource.c (tui_update_source_window_as_is)
1510         (tui_clear_source_content, tui_show_source_line)
1511         (tui_show_source_content, tui_source_window_base::refill)
1512         (tui_source_window_base::set_is_exec_point_at)
1513         (tui_source_window_base::set_is_exec_point_at)
1514         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1515         (tui_alloc_source_buffer, tui_line_is_displayed)
1516         (tui_addr_is_displayed): Change type of win_info.  Update.
1517         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1518         (tui_source_window_base::do_make_visible_with_new_height):
1519         Update.
1520         * tui/tui-source.c (tui_set_source_content)
1521         (tui_set_source_content_nil)
1522         (tui_source_window::do_scroll_vertical): Update.
1523         * tui/tui-layout.c (show_layout): Update.
1524         * tui/tui-disasm.c (tui_set_disassem_content)
1525         (tui_disasm_window::do_scroll_vertical): Update.
1526         * tui/tui-data.h (tui_win_content): Remove.
1527         (struct tui_gen_win_info) <content, content_size>: Remove.
1528         (struct tui_source_element): Add initializers and destructor.
1529         (union tui_which_element, struct tui_win_element): Remove.
1530         (struct tui_source_window_base) <content>: New field.
1531         (struct tui_data_window): Remove destructor.
1532         (tui_alloc_content, tui_free_win_content)
1533         (tui_free_all_source_wins_content): Don't declare.
1534         * tui/tui-data.c (tui_initialize_static_data): Update.
1535         (init_content_element, tui_alloc_content): Remove.
1536         (~tui_gen_win_info): Update.
1537         (~tui_data_window, tui_free_all_source_wins_content)
1538         (tui_free_win_content, free_content, free_content_elements):
1539         Remove.
1540
1541 2019-06-25  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-winsource.h (tui_clear_source_content)
1544         (tui_erase_source_content, tui_show_source_content): Change type
1545         of win_info.
1546         * tui/tui-winsource.c (tui_clear_source_content)
1547         (tui_erase_source_content, tui_show_source_content): Change type
1548         of win_info.
1549         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1550         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1551         win_info.
1552         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1553         win_info.
1554         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1555
1556 2019-06-25  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-winsource.c (tui_clear_source_content)
1559         (tui_source_window_base::set_is_exec_point_at): Update.
1560         * tui/tui-source.c (tui_set_source_content_nil): Update.
1561         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1562         a bool.
1563         * tui/tui-data.c (init_content_element): Update.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1568         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1569         * tui/tui-layout.c (init_and_make_win): Update.
1570         * tui/tui.h (enum tui_win_type): Update.
1571         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1572         tui_win_is_auxillary.
1573         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1574         tui_win_is_auxillary.
1575
1576 2019-06-25  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1579         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1580         (tui_delete_data_content_windows, tui_display_all_data)
1581         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1582         Update.
1583         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1584         * tui/tui-regs.c (tui_last_regs_line_no)
1585         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1586         (tui_show_registers): Update.
1587         (tui_show_register_group): Return void.  Update.
1588         (tui_display_registers_from, tui_display_reg_element_at_line)
1589         (tui_display_registers_from_line, tui_check_register_values):
1590         Update.
1591         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1592         member.
1593         (struct tui_data_window) <regs_content>: Now a std::vector.
1594         <regs_content_count>: Remove.
1595         (tui_add_content_elements, tui_free_data_content): Don't declare.
1596         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1597         (init_content_element): Remove DATA_WIN case.  Add assert.
1598         (tui_add_content_elements): Remove.
1599         (tui_data_window): Update.
1600         (tui_free_data_content): Remove.
1601         (free_content_elements): Remove DATA_WIN case.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-data.c (tui_data_item_window): Update.
1606         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1607         * tui/tui-windata.c (tui_display_all_data)
1608         (tui_display_data_from_line): Update.
1609         (tui_check_data_values): Remove.
1610         * tui/tui-regs.c (tui_show_register_group)
1611         (tui_display_reg_element_at_line): Update.
1612         * tui/tui-hooks.c (tui_register_changed)
1613         (tui_refresh_frame_and_register_information): Call
1614         tui_check_register_values.
1615         * tui/tui-data.h (struct tui_data_window) <data_content,
1616         data_content_count, data_type>: Remove.
1617         (enum tui_data_type): Remove.
1618
1619         * tui/tui-data.c (tui_data_window::clear_detail)
1620         (~tui_data_window): Update.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1625         declare.
1626         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1627         Rename from tui_first_data_item_displayed.  Update.
1628         (tui_data_window::refresh_all)
1629         (tui_data_window::do_scroll_vertical): Update.
1630         * tui/tui-data.h (struct tui_data_window)
1631         <first_data_item_displayed>: Declare new method.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1636         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1637         contents...
1638         (tui_initialize_static_data): ...here.
1639
1640 2019-06-25  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1643         (tui_display_registers_from, tui_check_register_values): Update.
1644         (tui_display_register): Remove win_info parameter; update.
1645         (tui_get_register): Change type of parameters.
1646         * tui/tui-data.h (struct tui_data_element): Remove.
1647         (union tui_which_element) <data>: Remove.
1648         <data_window>: Change type.
1649         (struct tui_data_item_window): New.
1650         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1651         case.  Add assert.
1652         (~tui_data_item_window): New destructor.
1653         (free_content_elements): Remove DATA_ITEM_WIN case.
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1658         Remove.
1659
1660 2019-06-25  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-data.h (struct tui_command_element): Remove.
1663         (union tui_which_element) <command>: Remove.
1664         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1665         assert.
1666         (free_content_elements): Remove CMD_WIN case.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-layout.c (tui_set_layout): Update.
1671         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1672         * tui/tui-data.c (layout_def): Update.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1677         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1678         (tui_source_window_base::set_new_height): Update.
1679         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1680         Update.
1681         (tui_set_locator_fullname, tui_set_locator_info)
1682         (tui_show_frame_info): Update.
1683         * tui/tui-source.c (tui_set_source_content)
1684         (tui_source_is_displayed): Update.
1685         * tui/tui-layout.c (show_source_disasm_command, show_data)
1686         (show_source_or_disasm_and_command): Update.
1687         * tui/tui-disasm.c (tui_set_disassem_content)
1688         (tui_get_begin_asm_address): Update.
1689         * tui/tui-data.h (struct tui_locator_element): Remove.
1690         (union tui_which_element) <locator>: Remove.
1691         (struct tui_locator_window): New.
1692         (tui_locator_win_info_ptr): Change return type.
1693         * tui/tui-data.c (_locator): Change type.
1694         (tui_locator_win_info_ptr): Change return type.
1695         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1696         (tui_alloc_content): Add assert.
1697
1698 2019-06-25  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-winsource.c
1701         (tui_exec_info_window::maybe_allocate_content): New method.
1702         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1703         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1704         (make_source_or_disasm_window): Add cast.
1705         * tui/tui-data.h (union tui_which_element) <simple_string>:
1706         Remove.
1707         (struct tui_source_info): New.
1708         (struct tui_source_window_base) <execution_info>: Change type.
1709         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1710         case, and add assert.
1711         (tui_alloc_content): Add assert.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1716         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1717         * tui/tui-data.c (tui_alloc_win_info): Remove.
1718
1719 2019-06-25  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1722         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1723         can_highlight.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1728         make_visible_with_new_height method.
1729         (tui_win_info::make_visible_with_new_height): New method.
1730         (tui_source_window_base::do_make_visible_with_new_height)
1731         (tui_data_window::do_make_visible_with_new_height)
1732         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1733         (make_visible_with_new_height): Remove.
1734         (tui_resize_all, tui_adjust_win_heights): Use
1735         make_visible_with_new_height method.
1736         * tui/tui-data.h (struct tui_win_info)
1737         <do_make_visible_with_new_height, make_visible_with_new_height>:
1738         New methods.
1739         (struct tui_source_window_base, struct tui_data_window)
1740         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1741         methods.
1742
1743 2019-06-25  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1746         method.
1747         (update_tab_width): Call update_tab_width method.
1748         * tui/tui-data.h (struct tui_win_info)
1749         (struct tui_source_window_base) <update_tab_width>: New methods.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1754         parameter.
1755         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1756         parameter.
1757         (tui_gen_win_info::make_visible): Update.
1758         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1759         parameter.
1760         * tui/tui-data.h (enum tui_box): New enum.
1761         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1766         init_and_make_win for EXEC_INFO_WIN.
1767         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1768         longer inline.
1769         (struct tui_win_info) <~tui_win_info>: Inline.
1770         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1771         Don't declare.
1772         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1773         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1774         Remove.
1775         (tui_initialize_static_data): Update.
1776         (~tui_gen_win_info): Handle more cleanup here.
1777         (~tui_source_window_base): Delete "execution_info".
1778         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1779
1780 2019-06-25  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-layout.c (make_command_window): Don't set
1783         can_highlight.
1784         (show_source_disasm_command): Call the reset method.
1785         (show_data): Don't set can_highlight.  Call the reset method.
1786         (tui_gen_win_info::reset): Rename from init_gen_win_info
1787         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1788         (show_source_or_disasm_and_command): Call the reset method.
1789         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1790         (struct tui_cmd_window): Set can_highlight.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1795         from make_visible.
1796         (tui_make_visible, tui_make_invisible): Rewrite.
1797         (tui_win_info::make_visible): Remove.
1798         (tui_source_window_base::make_visible): Update.
1799         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1800         method.  Moved from...
1801         (struct tui_win_info) <make_visible>: ...here.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-winsource.c
1806         (tui_source_window_base::do_scroll_horizontal): Remove direction
1807         parameter.
1808         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1809         direction parameter.
1810         * tui/tui-win.c (tui_win_info::forward_scroll)
1811         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1812         (tui_win_info::right_scroll): Update.
1813         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1814         direction parameter.
1815         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1816         direction parameter.
1817         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1818         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1819         Remove direction parameter.
1820         (struct tui_source_window_base, struct tui_source_window)
1821         (struct tui_disasm_window, struct tui_data_window)
1822         (struct tui_cmd_window): Update.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-winsource.h (tui_set_exec_info_content)
1827         (tui_show_exec_info_content, tui_erase_exec_info_content)
1828         (tui_clear_exec_info_content, tui_update_exec_info): Change
1829         argument to tui_source_window_base.
1830         * tui/tui-winsource.c (tui_set_exec_info_content)
1831         (tui_show_exec_info_content, tui_erase_exec_info_content)
1832         (tui_clear_exec_info_content, tui_update_exec_info): Change
1833         argument to tui_source_window_base.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1838         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1843         check.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1848         type to void.
1849         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1850         type to void.
1851         * tui/tui-source.c (tui_set_source_content): Update.
1852         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-win.c (window_name_completer, tui_set_focus)
1857         (tui_all_windows_info): Use name method.
1858         * tui/tui-data.h (struct tui_gen_win_info)
1859         (struct tui_source_window, struct tui_disasm_window)
1860         (struct tui_data_window, struct tui_cmd_window) <name>: New
1861         method.
1862         (tui_win_name): Don't declare.
1863         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1864         (tui_win_name): Remove.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-winsource.h (tui_update_source_window)
1869         (tui_update_source_window_as_is): Change parameter type.
1870         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1871         to be a tui_source_window_base.
1872         (tui_update_source_window_as_is): Likewise.
1873         * tui/tui-win.c (make_visible_with_new_height): Update.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-winsource.c (tui_erase_source_content)
1878         (tui_show_source_content, tui_show_exec_info_content)
1879         (tui_erase_exec_info_content): Use refresh_window method.
1880         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1881         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1882         from tui_refresh_win.
1883         (tui_data_window::refresh_window): New method.
1884         (tui_win_info::refresh, tui_source_window_base::refresh)
1885         (tui_refresh_all): Use refresh_window method.
1886         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1887         method.
1888         * tui/tui-regs.c (tui_display_register): Call refresh_window
1889         method.
1890         * tui/tui-layout.c (show_source_disasm_command)
1891         (show_source_or_disasm_and_command): Call refresh_window method.
1892         * tui/tui-data.h (struct tui_gen_win_info)
1893         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1894         New method.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui.c (tui_rl_other_window, tui_enable)
1899         (tui_is_window_visible, tui_get_command_dimension): Update.
1900         * tui/tui-winsource.c (tui_update_source_window_as_is)
1901         (tui_clear_source_content, tui_erase_source_content)
1902         (tui_show_source_line, tui_source_window_base::refill)
1903         (tui_source_window_base::do_scroll_horizontal)
1904         (tui_source_window_base::set_is_exec_point_at)
1905         (tui_update_breakpoint_info, tui_set_exec_info_content)
1906         (tui_alloc_source_buffer, tui_line_is_displayed)
1907         (tui_addr_is_displayed): Update.
1908         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1909         (tui_check_and_display_highlight_if_needed)
1910         (tui_win_info::make_visible, tui_win_info::refresh)
1911         (tui_refresh_all): Update.
1912         * tui/tui-windata.c (tui_first_data_item_displayed)
1913         (tui_delete_data_content_windows, tui_erase_data_content)
1914         (tui_display_all_data, tui_data_window::refresh_all)
1915         (tui_check_data_values): Update.
1916         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1917         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1918         (tui_win_info::backward_scroll, tui_refresh_all_win)
1919         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1920         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1921         (tui_source_window_base::set_new_height)
1922         (tui_data_window::set_new_height)
1923         (make_invisible_and_set_new_height)
1924         (make_visible_with_new_height, new_height_ok)
1925         (parse_scrolling_args): Update.
1926         * tui/tui-stack.c (tui_show_frame_info): Update.
1927         * tui/tui-source.c (tui_set_source_content)
1928         (tui_set_source_content_nil, tui_source_is_displayed)
1929         (tui_source_window::do_scroll_vertical): Update.
1930         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1931         (tui_display_registers_from, tui_display_reg_element_at_line)
1932         (tui_check_register_values, tui_reg_command): Update.
1933         * tui/tui-layout.c (tui_default_win_height)
1934         (show_source_disasm_command, show_data, init_and_make_win)
1935         (show_source_or_disasm_and_command): Update.
1936         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1937         (tui_redisplay_readline, tui_mld_flush)
1938         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1939         (tui_getc): Update.
1940         * tui/tui-disasm.c (tui_set_disassem_content)
1941         (tui_disasm_window::do_scroll_vertical): Update.
1942         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1943         Now virtual.
1944         (struct tui_win_info): Derive from tui_gen_win_info.
1945         <~tui_win_info>: Mark as override.
1946         <generic>: Remove member.
1947         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1948         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1949         (~tui_data_window, ~tui_win_info)
1950         (tui_free_all_source_wins_content): Update.
1951         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-layout.c (init_and_make_win): Use new.
1956         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1957         destructor, initializers.
1958         (tui_alloc_generic_win_info): Don't declare.
1959         * tui/tui-data.c (_locator): Add argument to constructor.
1960         (source_win, disasm_win): New globals.
1961         (exec_info): Remove.
1962         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1963         Update.
1964         (tui_alloc_generic_win_info): Remove.
1965         (init_content_element): Use new.
1966         (tui_win_info::tui_win_info): Update.
1967         (free_content_elements) <case DATA_WIN>: Use delete.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1972         * tui/tui-windata.c (tui_first_data_item_displayed)
1973         (tui_delete_data_content_windows): Update.
1974         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1975         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1976         (tui_display_registers_from, tui_check_register_values): Update.
1977         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1978         pointer.
1979         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1980         window.
1981         (tui_free_data_content): Update.
1982         (free_content_elements) <case DATA_WIN>: Free the window.
1983
1984 2019-06-25  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1987         Update.
1988         * tui/tui-layout.c (make_command_window)
1989         (show_source_disasm_command, show_data, init_and_make_win)
1990         (show_source_or_disasm_and_command): Update.
1991         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1992         method.
1993         <can_highight, is_highlighted>: Now bool.
1994         (tui_set_win_highlight): Don't declare.
1995         * tui/tui-data.c (tui_set_win_highlight): Remove.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-wingeneral.c (make_visible): Remove check of window
2000         type.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-win.c (tui_win_info::max_height)
2005         (tui_cmd_window::max_height): New methods.
2006         (new_height_ok): Call max_height.
2007         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2008         <max_height>: New method.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-win.c (tui_source_window_base::set_new_height)
2013         (tui_data_window::set_new_height): New methods.
2014         (make_invisible_and_set_new_height): Call set_new_height method.
2015         * tui/tui-data.h (struct tui_win_info)
2016         (struct tui_source_window_base, struct tui_data_window)
2017         <set_new_height>: New method.
2018
2019 2019-06-25  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2022         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2023         tui_refresh_data_win.
2024         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2025         method.
2026         (tui_refresh_all_win): Call the refresh_all method.
2027         (tui_set_focus): Likewise.
2028         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2029         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2030         Likewise.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-winsource.h (tui_refill_source_window)
2035         (tui_set_is_exec_point_at): Don't declare.
2036         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2037         (tui_source_window_base::refill): Rename from
2038         tui_refill_source_window.
2039         (tui_source_window_base::do_scroll_horizontal): Update.
2040         (tui_source_window_base::set_is_exec_point_at): Rename from
2041         tui_set_is_exec_point_at.
2042         (tui_update_all_breakpoint_info): Update.
2043         * tui/tui-stack.c (tui_show_frame_info): Update.
2044         * tui/tui-layout.c (show_data): Add cast.
2045         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2046         * tui/tui-data.h (struct tui_source_window_base) <refill,
2047         set_is_exec_point_at>: New methods.
2048         (tui_source_windows, tui_add_to_source_windows): Update types.
2049         (tui_add_to_source_windows): Remove redundant declaration.
2050         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2051         (tui_source_windows): Change return type.
2052         (tui_clear_source_windows_detail): Update.
2053         (tui_add_to_source_windows): Change type of parameter.
2054         (tui_free_all_source_wins_content): Update.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-wingeneral.c (tui_win_info::refresh)
2059         (tui_source_window_base::refresh): New methods.
2060         (tui_refresh_all): Call the refresh method.
2061         * tui/tui-data.h (struct tui_win_info)
2062         (struct tui_source_window_base) <refresh>: New method.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui.h (tui_is_window_visible): Return bool.
2067         * tui/tui.c (tui_is_window_visible): Return bool.
2068         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2069         (tui_make_visible, tui_make_invisible)
2070         (tui_win_info::make_visible)
2071         (tui_source_window_base::make_visible, make_all_visible)
2072         (tui_make_all_visible, tui_make_all_invisible): Update.
2073         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2074         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2075         bool.
2076         (struct tui_win_info, struct tui_source_window_base)
2077         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2078         * tui/tui-data.c (tui_init_generic_part): Update.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2083         (tui_source_window_base::make_visible): New methods.
2084         (make_all_visible): Make method call.
2085         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2086         (struct tui_source_window_base, struct tui_cmd_window): Override
2087         make_visible.
2088         (tui_win_is_source_type): Don't declare.
2089         * tui/tui-data.c (tui_win_is_source_type): Remove.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2094         NULL check.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2099         Inline constructor.  Add initializers for members.
2100         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2101         constructors; now inline in class.
2102
2103 2019-06-25  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-regs.c (tui_show_registers): Update.
2106         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2107         bool.
2108         * tui/tui-data.c (tui_data_window::clear_detail)
2109         (tui_data_window): Update.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-windata.c (tui_display_all_data)
2114         (tui_display_data_from_line, tui_display_data_from)
2115         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2116         Update.
2117         * tui/tui-regs.c (tui_last_regs_line_no)
2118         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2119         (tui_show_registers, tui_show_register_group)
2120         (tui_display_registers_from, tui_display_reg_element_at_line)
2121         (tui_display_registers_from_line, tui_check_register_values)
2122         (tui_reg_next, tui_reg_prev): Update.
2123         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2124         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2125         tui_data_window.
2126         (struct tui_win_info) <detail>: Remove.  Add new fields from
2127         tui_data_info.
2128         (TUI_DATA_WIN): Add cast.
2129         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2130         (~tui_data_window): Simplify.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-layout.c (show_source_disasm_command)
2135         (show_source_or_disasm_and_command): Update.
2136         * tui/tui-io.c (update_cmdwin_start_line)
2137         (tui_redisplay_readline): Update.
2138         * tui/tui-data.h (struct tui_command_info): Remove.
2139         (struct tui_win_info) <detail>: Remove command_info member.
2140         (struct tui_data_window) <start_line>: New member, from
2141         tui_command_info.
2142         (TUI_CMD_WIN): Add casts.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-winsource.c (tui_update_source_window)
2147         (tui_refill_source_window)
2148         (tui_source_window_base::do_scroll_horizontal)
2149         (tui_update_breakpoint_info, tui_set_exec_info_content)
2150         (tui_show_exec_info_content, tui_erase_exec_info_content)
2151         (tui_clear_exec_info_content): Update.
2152         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2153         Update.
2154         * tui/tui-win.c (make_invisible_and_set_new_height)
2155         (make_visible_with_new_height): Update.
2156         * tui/tui-source.c (tui_set_source_content)
2157         (tui_show_symtab_source): Update.
2158         * tui/tui-layout.c (extract_display_start_addr)
2159         (show_source_disasm_command, show_data)
2160         (make_source_or_disasm_window)
2161         (show_source_or_disasm_and_command): Update.
2162         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2163         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2164         "gdbarch".
2165         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2166         to tui_source_window_base.
2167         (struct tui_win_info) <detail>: Remove source_info member.
2168         (struct tui_source_window_base) <has_locator>: Inline.
2169         Move contents from tui_source_info; rename has_locator member to
2170         m_has_locator.
2171         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2172         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2173         header file.
2174         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2175         Simplify.
2176         (tui_free_all_source_wins_content): Cast to
2177         tui_source_window_base.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-win.c (make_invisible_and_set_new_height)
2182         (make_visible_with_new_height): Call has_locator method.
2183         * tui/tui-layout.c (show_source_disasm_command, show_data)
2184         (show_source_or_disasm_and_command): Update for bool change.
2185         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2186         (tui_win_info) <has_locator>: New method.
2187         (struct tui_source_window_base) <has_locator>: New method.
2188         (tui_win_has_locator): Don't declare.
2189         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2190         from tui_win_has_locator.
2191         (tui_source_window_base): Use false, not FALSE.
2192
2193 2019-06-25  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2196         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2197         clear_detail method directly.
2198         (tui_clear_win_detail): Remove.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2203         "this", not TUI_DISASM_WIN.
2204
2205 2019-06-25  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2208         declare.
2209         * tui/tui-winsource.c
2210         (tui_source_window_base::do_scroll_horizontal): Rename from
2211         tui_horizontal_source_scroll.
2212         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2213         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2214         from tui_vertical_data_scroll.
2215         * tui/tui-win.h (tui_scroll): Don't declare.
2216         * tui/tui-win.c (tui_win_info::forward_scroll)
2217         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2218         (tui_win_info::right_scroll): Rename and update.
2219         (tui_scroll_forward_command, tui_scroll_backward_command)
2220         (tui_scroll_left_command, tui_scroll_right_command): Update.
2221         (tui_scroll): Remove.
2222         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2223         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2224         from tui_vertical_source_scroll.
2225         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2226         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2227         from tui_vertical_disassem_scroll.
2228         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2229         do_scroll_horizontal>: New methods.
2230         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2231         Likewise.
2232         (struct tui_source_window_base): Add do_scroll_horizontal.
2233         (struct tui_source_window, struct tui_disasm_window): Add
2234         do_scroll_vertical.
2235         (struct tui_data_window, struct tui_cmd_window): Add
2236         do_scroll_horizontal and do_scroll_vertical.
2237         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2238
2239 2019-06-25  Tom Tromey  <tom@tromey.com>
2240
2241         * tui/tui-data.h (struct tui_source_window_base): New struct.
2242         (struct tui_source_window): Derive from tui_source_window_base.
2243         (struct tui_disasm_window): New struct.
2244         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2245         from tui_source_window::clear_detail.
2246         (tui_source_window_base): Rename from tui_source_window.
2247         (~tui_source_window_base): Rename from ~tui_source_window.
2248         (tui_alloc_win_info): Create a tui_disasm_window.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-data.h (struct tui_source_window)
2253         (struct tui_data_window): Declare destructors.
2254         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2255         destructors.
2256         (tui_win_info): Simplify.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-winsource.c (tui_display_main)
2261         (tui_update_source_windows_with_addr)
2262         (tui_update_all_breakpoint_info): Update.
2263         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2264         (new_height_ok, parse_scrolling_args): Update.
2265         * tui/tui-stack.c (tui_show_frame_info): Update.
2266         * tui/tui-data.h (struct tui_list): Remove.
2267         (tui_source_windows): Return a reference to a std::vector.
2268         * tui/tui-data.c (source_windows): Now a std::vector.
2269         (tui_source_windows): Change return type.
2270         (tui_clear_source_windows): Rewrite.
2271         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2272         (tui_free_all_source_wins_content): Rewrite.
2273
2274 2019-06-25  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2277         (struct tui_data_window, struct tui_cmd_window): Declare
2278         clear_detail method.
2279         * tui/tui-data.c (tui_source_window::clear_detail)
2280         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2281         methods.
2282         (tui_clear_win_detail): Simplify.
2283
2284 2019-06-25  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-layout.c (make_source_window, make_disasm_window)
2287         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2288         Return the new window.
2289         (show_source_disasm_command, show_data)
2290         (show_source_or_disasm_and_command): Update.
2291
2292 2019-06-25  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2295         parameter.  Return the new window.
2296         (show_source_disasm_command): Update and remove NULL check.
2297         (show_source_or_disasm_and_command): Update.
2298
2299 2019-06-25  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2302
2303 2019-06-25  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-data.h (struct tui_win_info): Make constructor
2306         protected.  Make destructor virtual.  Add initializers.
2307         (tui_source_window, tui_data_window, tui_cmd_window): New
2308         classes.
2309         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2310         constructor.  Add "type" parameter.
2311         (tui_source_window, tui_data_window, tui_cmd_window): New
2312         constructors.
2313         (tui_alloc_win_info): Instantiate the appropriate subclass.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-win.c (tui_resize_all): Use delete.
2318         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2319         destructor.
2320         (tui_free_window): Don't declare.
2321         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2322         Update.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-data.h (struct tui_win_info): Add constructor.
2327         * tui/tui-data.c (tui_alloc_win_info): Use new.
2328         (tui_free_window): Use delete.
2329
2330 2019-06-22  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2333         declare.
2334         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2335
2336 2019-06-22  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2339         declare.
2340         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2341
2342 2019-06-22  Tom de Vries  <tdevries@suse.de>
2343
2344         * dwarf2read.c (create_addrmap_from_aranges)
2345         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2346         instead of '%zu'.
2347
2348 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2349
2350         * dwarf2read.h (dwarf2_section_info_def): Remove.
2351         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2352         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2353         std::vector<dwarf2_section_info>.
2354         (struct dwo_file) <~dwo_file>: Remove.
2355         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2356         types field.
2357         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2358         (dwarf2_read_debug_names): Likewise.
2359         (create_debug_types_hash_table): Change parameter type to
2360         array_view, adjust code accordingly.
2361         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2362         (partial_die_info::fixup): Likewise.
2363         (determine_prefix): Likewise.
2364         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2365
2366 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2367
2368         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2369         gdb_bfd_ref_ptr.
2370         <~dwo_file>: Remove call to gdb_bfd_unref.
2371         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2372         gdb_bfd_ref_ptr::get.
2373
2374 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2375
2376         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2377         type to htab_up.
2378         * dwarf2read.c (struct dwo_file): Initialize fields.
2379         <~dwo_file>: New.
2380         (free_dwo_file): Remove, move content to ~dwo_file.
2381         (struct dwo_file_deleter): Remove.
2382         (dwo_file_up>: Remove custom deleter.
2383         (free_dwo_files): Remove.
2384         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2385         dwo_files.
2386         (process_skeletonless_type_units): Call unique_ptr::get.
2387         (allocate_dwo_file_hash_table): Add deleter to created hash
2388         table.  Change return type to htab_up.
2389         (lookup_dwo_file_slot): Don't memset dwo_file, call
2390         unique_ptr::get.
2391         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2392         (create_dwo_unit_in_dwp_v2): Likewise.
2393         (open_and_init_dwo_file): Likewise.
2394         (free_dwo_file_from_slot): Remove.
2395
2396 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2397
2398         * dwarf2read.h (struct dwarf2_section_info) <readin,
2399         is_virtual>: Change type to bool.
2400         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2401         true instead of 1.
2402
2403 2019-06-19  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-data.h (tui_init_content_element): Don't declare.
2406
2407 2019-06-19  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-data.h (tui_init_win_info): Don't declare.
2410
2411 2019-06-19  Tom de Vries  <tdevries@suse.de>
2412
2413         * dwarf2read.h (abstract_to_concrete): Change type to
2414         std::unordered_map<sect_offset, std::vector<sect_offset>,
2415         gdb::hash_enum<sect_offset>>.
2416
2417 2019-06-19  Tom Tromey  <tromey@adacore.com>
2418
2419         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2420         EVAL_AVOID_SIDE_EFFECTS specially.
2421
2422 2019-06-19  Tom Tromey  <tromey@adacore.com>
2423
2424         * source-cache.c (highlighter): New global.
2425         (source_cache::get_source_lines): Create a highlighter on demand.
2426
2427 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * defs.h (deprecated_interactive_hook): Delete declaration.
2430         * interps.c (clear_interpreter_hooks): Remove use of
2431         deprecated_interactive_hook.
2432         * top.c (deprecated_interactive_hook): Delete definition.
2433         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2434
2435 2019-06-18  Tom de Vries  <tdevries@suse.de>
2436
2437         PR gdb/24515
2438         * dwarf2read.h (abstract_to_concrete): Change type from
2439         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2440         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2441         * dwarf2read.c (read_variable): Update.
2442         (dwarf2_fetch_die_loc_sect_off): Update.
2443
2444 2019-06-17  Tom de Vries  <tdevries@suse.de>
2445
2446         PR gdb/24617
2447         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2448         accessing parent[parent_len - 1].
2449
2450 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2451
2452         PR gdb/24364
2453         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2454         call dtrace_process_dof with NULL dof.
2455
2456 2019-06-16  Tom de Vries  <tdevries@suse.de>
2457
2458         PR gdb/24445
2459         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2460
2461 2019-06-16  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2464         (make_all_visible): Use address of member.
2465
2466 2019-06-16  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2469         (tui_free_window, free_content, free_content_elements): Remove
2470         unnecessary cast.
2471         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2472         cast.
2473         * tui/tui-regs.c (tui_show_register_group)
2474         (tui_display_registers_from, tui_display_reg_element_at_line):
2475         Remove unnecessary cast.
2476
2477 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2478
2479         * linux-nat.c (normal_mask): Delete.
2480         (_initialize_linux_nat): Don't initialise normal_mask.
2481
2482 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2483
2484         PR gdb/24445
2485         * dwarf-index-write.h (write_psymtabs_to_index): Add
2486         dwz_basename parameter.
2487         * dwarf-index-write.c (write_gdbindex): Move file writing to
2488         write_gdbindex_1.  Change return type void.
2489         (assert_file_size): Move up, remove filename parameter.
2490         (write_gdbindex_1): New function.
2491         (write_debug_names): Change return type to void, call
2492         assert_file_size.
2493         (struct index_wip_file): New struct.
2494         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2495         file logic to index_wip_file.  Write index for dwz file if
2496         needed.
2497         (save_gdb_index_command): Pass basename of dwz file, if present.
2498         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2499         build-id of dwz file, if present.
2500         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2501         (dwarf2_get_dwz_file): Likewise.
2502         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2503         (dwarf2_get_dwz_file): Likewise.
2504
2505 2019-06-16  Tom Tromey  <tom@tromey.com>
2506
2507         * coffread.c (process_coff_symbol): Use xstrdup.
2508         * value.c (create_internalvar): Use xstrdup.
2509
2510 2019-06-16  Tom Tromey  <tom@tromey.com>
2511
2512         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2513         * breakpoint.c (stopin_command, stopat_command)
2514         (until_break_command, decode_location_default): Remove unnecessary
2515         cast.
2516         * utils.c (subset_compare): Remove unnecessary cast.
2517         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2518         cast.
2519         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2520         cast.
2521         * infcmd.c (path_command): Remove unnecessary cast.
2522         * coffread.c (decode_type): Remove unnecessary cast.
2523         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2524         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2525         * tui/tui-stack.c (tui_show_locator_content)
2526         (tui_show_frame_info): Remove unnecessary cast.
2527         * tui/tui-win.c (tui_scroll_forward_command)
2528         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2529         (parse_scrolling_args): Remove unnecessary cast.
2530         * tui/tui-data.c (init_win_info, tui_del_window)
2531         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2532         (free_content_elements): Remove unnecessary cast.
2533         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2534         unnecessary cast.
2535         * tui/tui-source.c (tui_set_source_content)
2536         (tui_vertical_source_scroll): Remove unnecessary cast.
2537         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2538         cast.
2539         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2540         * tui/tui-regs.c (tui_display_registers_from)
2541         (tui_display_register): Remove unnecessary cast.
2542         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2543         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2544         (make_visible): Remove unnecessary cast.
2545         * tui/tui-winsource.c (tui_erase_source_content)
2546         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2547         unnecessary cast.
2548         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2549         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2550         * stabsread.c (read_type, read_array_type, read_range_type):
2551         Remove unnecessary cast.
2552         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2553         (parse_symbol, parse_type, upgrade_type, parse_external)
2554         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2555         unnecessary cast.
2556         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2557
2558 2019-06-16  Tom Tromey  <tom@tromey.com>
2559
2560         * tui/tui-data.c (tui_alloc_generic_win_info)
2561         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2562         checks.
2563
2564 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2565             Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * f-typeprint.c (f_print_type): Don't return early for not
2568         associated or not allocated types.
2569         (f_type_print_varspec_suffix): Add print_rank parameter and print
2570         ranks of array types in case they dangling.
2571         (f_type_print_base): Add print_rank parameter.
2572
2573 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * NEWS: Mention new MI commands.
2576         * break-catch-throw.c (enum exception_event_kind): Move to
2577         breakpoint.h.
2578         (print_mention_exception_catchpoint): Output text as a single
2579         message.
2580         (catch_exception_command_1): Rename to...
2581         (catch_exception_event): ...this, make non-static, update header
2582         command, and change some parameter types.
2583         (catch_catch_command): Update for changes to
2584         catch_exception_command_1.
2585         (catch_throw_command): Likewise.
2586         (catch_rethrow_command): Likewise.
2587         * breakpoint.c (enum exception_event_kind): Delete.
2588         * breakpoint.h (enum exception_event_kind): Moved here from
2589         break-catch-throw.c.
2590         (catch_exception_event): Declare.
2591         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2592         (mi_cmd_catch_throw): New function.
2593         (mi_cmd_catch_rethrow): New function.
2594         (mi_cmd_catch_catch): New function.
2595         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2596         'catch-catch' entries.
2597         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2598         (mi_cmd_catch_rethrow): Declare.
2599         (mi_cmd_catch_catch): Declare.
2600
2601 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * annotate.c (annotate_source_line): Change return type to void,
2604         update implementation to match.
2605         * annotate.h (annotate_source_line): Change return type to void,
2606         update header comment.
2607         * stack.c (print_frame_info): Don't change what frame information
2608         is printed based on whether annotations are on or not.
2609
2610 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2613         (annotate_source): Make static.
2614         (annotate_source_line): Moved from source.c and renamed from
2615         identify_source_line.  Update the return type.
2616         * annotate.h (annotate_source): Delete declaration.
2617         (annotate_source_line): Declaration moved from source.h, and
2618         renamed from identify_source_line.  Return type updated.
2619         * source.c (identify_source_line): Moved to annotate.c and renamed
2620         to annotate_source_line.
2621         (info_line_command): Remove check of annotation_level.
2622         * source.h (identify_source_line): Move declaration to annotate.h
2623         and rename to annotate_source_line.
2624         * stack.c: Add 'annotate.h' include.
2625         (print_frame_info): Remove check of annotation_level before
2626         calling annotate_source_line.
2627
2628 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         * source-cache.c (source_cache::get_plain_source_lines): Use
2631         open_source_file_with_line_charpos instead of just
2632         open_source_file, remove call to find_source_lines.
2633         (source_cache::get_source_lines): Likewise.
2634         * source.c (find_source_lines): Make static.
2635         (get_filename_and_charpos): Renamed into...
2636         (open_source_file_with_line_charpos): ..this along with changes to
2637         return a scoped_fd, and some other minor clean ups.
2638         (identify_source_line): Use open_source_file_with_line_charpos.
2639         (search_command_helper): Use open_source_file_with_line_charpos
2640         instead of just open_source_file, remove call to
2641         find_source_lines.
2642         * source.h (open_source_file_with_line_charpos): Declare new
2643         function.
2644         (find_source_lines): Delete declaration.
2645
2646 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * source.c (get_filename_and_charpos): Remove fullname
2649         parameter.
2650         (identify_source_line): Update call to get_filename_and_charpos.
2651
2652 2019-06-14  Tom Tromey  <tromey@adacore.com>
2653
2654         PR gdb/24502:
2655         * ui-style.h (skip_ansi_escape): Update comment.
2656         * ui-file.h (class no_terminal_escape_file): New class.
2657         * ui-file.c (no_terminal_escape_file::write)
2658         (no_terminal_escape_file::puts): New methods.
2659         * cli/cli-logging.c (handle_redirections): Use
2660         no_terminal_escape_file.
2661
2662 2019-06-14  Tom Tromey  <tromey@adacore.com>
2663
2664         * NEWS: Move convenience variable news above Python news.
2665
2666 2019-06-14  Tom Tromey  <tom@tromey.com>
2667
2668         * gnulib: Move directory to top-level.
2669         * configure.ac: Don't configure gnulib.
2670         * configure: Rebuild.
2671         * common/common-defs.h: Use new path to gnulib.
2672         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2673         (GNULIB_H): Remove.
2674         (INCGNU): Look in new gnulib location.
2675         (HFILES_NO_SRCDIR): Remove gnulib files.
2676         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2677         (generated_files): Remove GNULIB_H.
2678         ($(LIBGNU), all-lib): Remove targets.
2679         (distclean): Don't mention GNULIB_BUILDDIR.
2680         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2681
2682 2019-06-14  Tom Tromey  <tromey@adacore.com>
2683
2684         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2685         Warn if symbol file does not provide any symbols.
2686
2687 2019-06-14  Tom Tromey  <tromey@adacore.com>
2688
2689         * source.c (find_and_open_source): Respect basenames_may_differ.
2690
2691 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * annotate.c (annotate_breakpoints_invalid): Make use of
2694         scoped_restore_terminal_state.
2695         (annotate_frames_invalid): Likewise.
2696
2697 2019-06-14  Tom Tromey  <tromey@adacore.com>
2698
2699         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2700         allow assignment to an internalvar.
2701
2702 2019-06-14  Tom Tromey  <tromey@adacore.com>
2703
2704         * ada-lex.l: Allow "_" in attribute names.
2705
2706 2019-06-14  Tom Tromey  <tromey@adacore.com>
2707
2708         PR gdb/24653:
2709         * regcache.c (registers_changed): Don't call alloca.
2710         * top.c (execute_command): Don't call alloca.
2711
2712 2019-06-13  Pedro Alves  <palves@redhat.com>
2713
2714         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2715         'expression'.  When parsing an expression, error out if there's
2716         junk after "unlimited".
2717         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2718         (do_set_command): Adjust calls to is_unlimited_literal.
2719
2720 2019-06-13  Pedro Alves  <palves@redhat.com>
2721
2722         * compile/compile.c (make_compile_options_def_group): Add braces
2723         around array_view initializer.
2724         * thread.c (make_thread_apply_all_options_def_group)
2725         (make_thread_apply_all_options_def_group): Likewise.
2726
2727 2019-06-13  Pedro Alves  <palves@redhat.com>
2728
2729         * NEWS (New commands): Mention "maint test-options
2730         require-delimiter", "maint test-options unknown-is-error", "maint
2731         test-options unknown-is-operand" and "maint show
2732         test-options-completion-result".
2733         (New command options, command completion): New section.
2734         (Completion improvements): New section.
2735         Mention that you can abbreviate "unlimited".
2736
2737 2019-06-13  Pedro Alves  <palves@redhat.com>
2738
2739         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2740         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2741         * unittests/cli-utils-selftests.c (test_parse_flags)
2742         (test_parse_flags_qcs): Delete.
2743         (test_cli_utils): Don't call deleted functions.
2744
2745 2019-06-13  Pedro Alves  <palves@redhat.com>
2746
2747         * thread.c: Include "cli/cli-option.h".
2748         (tp_array_compar_ascending): Global.
2749         (tp_array_compar): Delete function.
2750         (tp_array_compar_ascending, tp_array_compar_descending): New
2751         functions.
2752         (ascending_option_def, qcs_flag_option_def)
2753         (thr_qcs_flags_option_defs)
2754         (make_thread_apply_all_options_def_group)
2755         (make_thread_apply_options_def_group): New.
2756         (thread_apply_all_command): Use gdb::option::process_options.
2757         (thread_apply_command_completer)
2758         (thread_apply_all_command_completer): New.
2759         (thread_apply_command): Use gdb::option::process_options.
2760         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2761         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2762         to generate help text of "thread apply".  Adjust "taas"'s help.
2763         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2764         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2765
2766 2019-06-13  Pedro Alves  <palves@redhat.com>
2767
2768         * thread.c (thread_apply_command): Check for invalid TID with
2769         isdigit instead of !isalpha.
2770
2771 2019-06-13  Pedro Alves  <palves@redhat.com>
2772
2773         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2774         (validate_flags_qcs): New.
2775         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2776         (validate_flags_qcs): Declare.
2777         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2778         (make_frame_apply_options_def_group): New.
2779         (frame_apply_command_count): Process options with
2780         gdb::option::process_options.
2781         (frame_apply_completer): New.
2782         (frame_apply_level_completer, frame_apply_all_completer)
2783         (frame_apply_completer): New.
2784         (_initialize_stack): Update help of "frame apply", "frame apply
2785         level", "frame apply all" and "faas" to mention supported options
2786         and install command completers.
2787         * stack.h (frame_apply_all_completer): Declare.
2788         * thread.c: Include "stack.h".
2789         (tfaas_command): Add "--".
2790         (_initialize_thread): Update help "tfaas" to mention supported
2791         options and install command completer.
2792
2793 2019-06-13  Pedro Alves  <palves@redhat.com>
2794
2795         * completer.c (complete_nested_command_line): New.
2796         (gdb_completion_word_break_characters_throw): Add assertion.
2797         * completer.h (complete_nested_command_line): Declare.
2798
2799 2019-06-13  Pedro Alves  <palves@redhat.com>
2800
2801         * stack.c (parse_backtrace_qualifiers): New.
2802         (backtrace_command): Use it.
2803         (backtrace_command_completer): Complete on qualifiers.
2804
2805 2019-06-13  Pedro Alves  <palves@redhat.com>
2806
2807         * frame.c: Include "cli/cli-option.h.
2808         (user_set_backtrace_options): New.
2809         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2810         Delete.
2811         (get_prev_frame): Adjust.
2812         (boolean_option_def, uinteger_option_def)
2813         (set_backtrace_option_defs): New.
2814         (_initialize_frame): Adjust and use
2815         gdb::option::add_setshow_cmds_for_options to install "set
2816         backtrace past-main" and "set backtrace past-entry".
2817         * frame.h: Include "cli/cli-option.h".
2818         (struct frame_print_options): Forward declare.
2819         (print_frame_arguments_all, print_frame_arguments_scalars)
2820         (print_frame_arguments_none): Declare.
2821         (print_entry_values): Delete declaration.
2822         (struct frame_print_options, user_frame_print_options): New.
2823         (struct set_backtrace_options): New.
2824         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2825         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2826         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2827         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2828         (list_args_or_locals): Add frame_print_options parameter.
2829         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2830         * python/py-framefilter.c (enumerate_args): Pass down
2831         USER_FRAME_PRINT_OPTIONS.
2832         * stack.c: Include "cli/cli-option.h".
2833         (print_frame_arguments_all, print_frame_arguments_scalars)
2834         (print_frame_arguments_none): Declare.
2835         (print_raw_frame_arguments, print_entry_values): Delete.
2836         (user_frame_print_options): New.
2837         (boolean_option_def, enum_option_def, frame_print_option_defs):
2838         New.
2839         (struct backtrace_cmd_options): New.
2840         (bt_flag_option_def): New.
2841         (backtrace_command_option_defs): New.
2842         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2843         (print_frame_arg, read_frame_arg, print_frame_args)
2844         (print_frame_info, print_frame): Add frame_print_options parameter
2845         and use it.
2846         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2847         (backtrace_command_1): Add frame_print_options and
2848         backtrace_cmd_options parameters and use them.
2849         (make_backtrace_options_def_group): New.
2850         (backtrace_command): Process command options with
2851         gdb::option::process_options.
2852         (backtrace_command_completer): New.
2853         (_initialize_stack): Extend "backtrace"'s help to mention
2854         supported options.  Install completer for "backtrace".
2855         Install some settings commands with add_setshow_cmds_for_options.
2856
2857 2019-06-13  Pedro Alves  <palves@redhat.com>
2858
2859         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2860         and that "set/show print raw frame-arguments" are now deprecated.
2861
2862         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2863         command.
2864         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2865         * stack.c (_initialize_stack): Install "set/show print
2866         raw-frame-arguments", and deprecate "set/show print raw
2867         frame-arguments".
2868         * valprint.c (_initialize_valprint): Deprecate "set/show print
2869         raw".
2870
2871 2019-06-13  Pedro Alves  <palves@redhat.com>
2872
2873         * compile/compile.c (struct compile_options): New.
2874         (compile_flag_option_def, compile_command_option_defs)
2875         (make_compile_options_def_group): New.
2876         (compile_file_command): Handle options with
2877         gdb::option::process_options.
2878         (compile_file_command_completer): New function.
2879         (compile_code_command): Handle options with
2880         gdb::option::process_options.
2881         (compile_code_command_completer): New function.
2882         (_initialize_compiler): Install completers for "compile code" and
2883         "compile file".  Mention available options in "compile code" and
2884         "compile code"'s help.
2885         * completer.c (advance_to_completion_word): New, factored out from
2886         ...
2887         (advance_to_expression_complete_word_point): ... this.
2888         (advance_to_filename_complete_word_point): New.
2889         * completer.h (advance_to_filename_complete_word_point): New
2890         declaration.
2891
2892 2019-06-13  Pedro Alves  <palves@redhat.com>
2893
2894         * compile/compile.c: Include "cli/cli-option.h".
2895         (compile_print_value): Scope data pointer is now a
2896         value_print_options pointer; adjust.
2897         (compile_print_command): Process options.  Scope data pointer is
2898         now a value_print_options pointer; adjust.
2899         (_initialize_compile): Update "compile print"'s help to include
2900         supported options.  Install a completer for "compile print".
2901         * cp-valprint.c (show_vtblprint, show_objectprint)
2902         (show_static_field_print): Delete.
2903         (_initialize_cp_valprint): Don't install "set print
2904         static-members", "set print vtbl", "set print object" here.
2905         * printcmd.c: Include "cli/cli-option.h" and
2906         "common/gdb_optional.h".
2907         (print_command_parse_format): Rework to fill in a
2908         value_print_options instead of a format_data.
2909         (print_value): Change parameter type from format_data pointer to
2910         value_print_options reference.  Adjust.
2911         (print_command_1): Process options.  Adjust to pass down a
2912         value_print_options.
2913         (print_command_completer): New.
2914         (_initialize_printcmd): Install print_command_completer as
2915         handle_brkchars completer for the "print" command.  Update
2916         "print"'s help to include supported options.
2917         * valprint.c: Include "cli/cli-option.h".
2918         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2919         here from cp-valprint.c.
2920         (boolean_option_def, uinteger_option_def)
2921         (value_print_option_defs, make_value_print_options_def_group):
2922         New.  Use gdb::option::add_setshow_cmds_for_options to install
2923         "set print elements", "set print null-stop", "set print repeats",
2924         "set print pretty", "set print union", "set print array", "set
2925         print address", "set print symbol", "set print array-indexes".
2926         * valprint.h: Include <string> and "cli/cli-option.h".
2927         (make_value_print_options_def_group): Declare.
2928         (print_value): Change parameter type from format_data pointer to
2929         value_print_options reference.
2930         (print_command_completer): Declare.
2931
2932 2019-06-13  Pedro Alves  <palves@redhat.com>
2933
2934         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2935         (COMMON_SFILES): Add maint-test-settings.c.
2936         * cli/cli-decode.c (boolean_enums): New global, factored out from
2937         ...
2938         (add_setshow_boolean_cmd): ... here.
2939         * cli/cli-decode.h (boolean_enums): Declare.
2940         * cli/cli-option.c: New file.
2941         * cli/cli-option.h: New file.
2942         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2943         factored out from ...
2944         (parse_cli_boolean_value(const char *)): ... this.
2945         (is_unlimited_literal): Change parameter type to pointer to
2946         pointer.  Adjust and advance ARG pointer.
2947         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2948         (parse_cli_var_enum): New, factored out from ...
2949         (do_set_command): ... this.  Adjust.
2950         * cli/cli-setshow.h (parse_cli_boolean_value)
2951         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2952         (parse_cli_var_enum): Declare.
2953         * cli/cli-utils.c: Include "cli/cli-option.h".
2954         (get_ulongest): New.
2955         * cli/cli-utils.h (get_ulongest): Declare.
2956         (check_for_argument): New overloads.
2957         * maint-test-options.c: New file.
2958
2959 2019-06-13  Pedro Alves  <palves@redhat.com>
2960
2961         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2962         parse a range if "-" is at the end of the string.
2963
2964 2019-06-13  Pedro Alves  <palves@redhat.com>
2965
2966         * cli/cli-setshow.c (parse_auto_binary_operation)
2967         (parse_cli_boolean_value): Don't allow "o".
2968
2969 2019-06-13  Pedro Alves  <palves@redhat.com>
2970
2971         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2972         * NEWS: Mention maint test-settings KIND.
2973         * maint-test-settings.c: New file.
2974
2975 2019-06-13  Pedro Alves  <palves@redhat.com>
2976
2977         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2978         completer.
2979         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2980         "set" completers.
2981
2982 2019-06-13  Pedro Alves  <palves@redhat.com>
2983
2984         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2985         after item.
2986
2987 2019-06-13  Pedro Alves  <palves@redhat.com>
2988
2989         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2990
2991 2019-06-13  Pedro Alves <palves@redhat.com>
2992
2993         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2994         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2995         call.
2996         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2997         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2998         calls.
2999         (check_for_argument): Skip spaces after argument.
3000
3001 2019-06-13  Pedro Alves  <palves@redhat.com>
3002
3003         * thread.c (thread_apply_command): Adjust TID parsing.
3004         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3005         detected before end of string.
3006         (tid_is_in_list): Error out if LIST is invalid.
3007
3008 2019-06-13  Pedro Alves  <palves@redhat.com>
3009
3010         * completer.c (complete_line_internal_1): Rewind completion word
3011         point.
3012         (completion_tracker::advance_custom_word_point_by): Change
3013         parameter type to int.
3014         * completer.h (completion_tracker::advance_custom_word_point_by):
3015         Likewise.
3016
3017 2019-06-13  Pedro Alves  <palves@redhat.com>
3018
3019         * completer.c (advance_to_completion_word): Handle delimiters.
3020
3021 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3022
3023         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3024
3025 2019-06-11  Tom Tromey  <tom@tromey.com>
3026
3027         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3028         (xmalloc_failed): Move to alloc.c.
3029         * alloc.c: New file.
3030         * Makefile.in (COMMON_SFILES): Add alloc.c.
3031
3032 2019-06-11  Tom Tromey  <tom@tromey.com>
3033
3034         * nat/linux-waitpid.c: Don't include server.h.
3035         (linux_debug): Remove.
3036         (my_waitpid): Update.
3037
3038 2019-06-11  Tom Tromey  <tromey@adacore.com>
3039
3040         * infcall.c (_initialize_infcall): Remove trailing newline from
3041         help.
3042         * user-regs.c (_initialize_user_regs): Remove trailing newline
3043         from help.
3044         * typeprint.c (_initialize_typeprint): Remove trailing newline
3045         from help.
3046         * reverse.c (_initialize_reverse): Remove trailing newlines from
3047         help.
3048         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3049         from help.
3050         * language.c (add_set_language_command): Remove trailing newline
3051         from help.
3052         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3053         help.
3054         * disasm.c (_initialize_disasm): Remove trailing newline from
3055         help.
3056         * top.c (init_main): Remove trailing newline from help.
3057         * interps.c (_initialize_interpreter): Remove trailing newline
3058         from help.
3059         * btrace.c (_initialize_btrace): Remove trailing newlines from
3060         help.
3061         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3062         from help.
3063         * python/python.c (_initialize_python): Remove trailing newline
3064         from help.
3065         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3066         help.
3067         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3068         from help.  Reformat some text.
3069         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3070         from help.
3071         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3072         newline from help.
3073
3074 2019-06-11  Tom Tromey  <tromey@adacore.com>
3075
3076         * darwin-nat.c (darwin_decode_exception_message)
3077         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3078
3079 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * valops.c (value_slice): Check for not allocated or not
3082         associated values.
3083
3084 2019-06-10  Tom de Vries  <tdevries@suse.de>
3085
3086         PR gdb/24618
3087         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3088         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3089         invalid.
3090
3091 2019-06-10  Tom de Vries  <tdevries@suse.de>
3092
3093         PR gdb/24611
3094         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3095         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3096
3097 2019-06-10  Tom de Vries  <tdevries@suse.de>
3098
3099         PR symtab/24545
3100         * symtab.c (struct demangled_name_entry): Add language field.
3101         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3102         static minimal symbol".  Set and use language field.
3103
3104 2019-06-10  Tom Tromey  <tromey@adacore.com>
3105
3106         * ada-lang.c (_initialize_ada_language): Update help text.
3107
3108 2019-06-10  Tom Tromey  <tromey@adacore.com>
3109
3110         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3111         with a newline.
3112         * guile/guile.c (handle_boot_error): Don't end warning with a
3113         newline.
3114         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3115         warning with a newline.
3116         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3117         newline.
3118         (s12z_frame_cache): Likewise.
3119         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3120         a newline.
3121         * solib-svr4.c (disable_probes_interface): Don't end warning with
3122         a newline.
3123         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3124         newline.
3125         * python/python.c (do_finish_initialization): Don't end warning
3126         with a newline.
3127
3128 2019-06-10  Tom Tromey  <tom@tromey.com>
3129
3130         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3131         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3132         gdbpy_enter.
3133
3134 2019-06-10  Tom Tromey  <tromey@adacore.com>
3135
3136         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3137         data.
3138         (elf_new_init): Don't call stabsread_new_init.
3139         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3140         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3141         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3142
3143 2019-06-10  Tom de Vries  <tdevries@suse.de>
3144
3145         PR symtab/16264
3146         PR symtab/24517
3147         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3148
3149 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3150
3151         * source.c (find_and_open_source): Also rewrite relative file
3152         names.
3153
3154 2019-04-26  Amos Bird  <amosbird@gmail.com>
3155
3156         * annotate.c (annotate_thread_exited): Add "thread-exited"
3157         annotation.
3158
3159 2019-06-06  Tom Tromey  <tromey@adacore.com>
3160
3161         * maint.h (class scoped_command_stats): Use
3162         DISABLE_COPY_AND_ASSIGN.
3163         <print_time>: New method.
3164         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3165         print_time.
3166         (scoped_command_stats::print_time): New method.
3167
3168 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3171         instructions of lengths 6 or 8 bytes.
3172
3173 2019-06-04  Pedro Alves  <palves@redhat.com>
3174
3175         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3176
3177         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3178         * breakpoint.c (condition_completer): Likewise.
3179         * cli/cli-dump.c (scan_expression): Likewise.
3180         * common/filestuff.c (mkdir_recursive): Likewise.
3181         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3182         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3183         (gdb_abspath): Likewise.
3184         * compile/compile-cplus-types.c
3185         (compile_cplus_instance::decl_name): Likewise.
3186         * completer.c (complete_explicit_location):
3187         (signal_completer, reg_or_group_completer_1): Likewise.
3188         * cp-support.c (cp_remove_params_if_any): Likewise.
3189         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3190         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3191         * infcmd.c (strip_bg_char): Likewise.
3192         * linespec.c (copy_token_string): Likewise.
3193         * mi/mi-main.c (output_cores): Likewise.
3194         * psymtab.c (psymtab_search_name):
3195         * symfile.c (test_set_ext_lang_command): Likewise.
3196         * target.c (target_fileio_read_stralloc): Likewise.
3197         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3198         * value.c (complete_internalvar): Likewise.
3199
3200 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3201
3202         Add objfile property to gdb.Type.
3203         * NEWS: Mention Python API addition.
3204         * python/py-type.c (typy_get_objfile): New method.
3205
3206 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3207
3208         * NEWS: Mention the new set|show style [title|highlight].
3209         Mention changes to "show style", "help" and "apropos".
3210
3211 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3212
3213         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3214         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3215         instead of print_help_for_command.
3216         (print_doc_of_command): New function.
3217         (help_list): Add 'apropos -v word' suggestion.
3218         (print_help_for_command): Style the command name using title style.
3219         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3220         (_initialize_cli_cmds): Describe -v in apropos_command help.
3221
3222 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3223
3224         * cli/cli-style.h (cli_style_option): Add name in constructor,
3225         add m_name class member, add constructor with intensity,
3226         add name class function.
3227         (cli_style_option::add_setshow_commands): Remove name argument.
3228         (highlight_style, title_style): New styles.
3229         * cli/cli-style.c (do_show): New function that shows a style
3230         characteristic styling the style name with itself.
3231         (set_style_name): New function.
3232         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3233         Update all callers according to the changes in cli/cli-style.h.
3234         * utils.h (fputs_highlighted): New function.
3235         * utils.c (fputs_highlighted): Likewise.
3236
3237 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3238
3239         * NEWS: Mention new pipe command and new convenience variables.
3240
3241 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3242
3243         * cli/cli-cmds.c (pipe_command): New function.
3244         (_initialize_cli_cmds): Call add_com for pipe_command.
3245         Define | as an alias for pipe.
3246         (exit_status_set_internal_vars): New function.
3247         (shell_escape): Call exit_status_set_internal_vars.
3248         cli/cli-decode.c (find_command_name_length): Recognize | as
3249         a single character command.
3250
3251 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3252
3253         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3254         top.c (execute_command_to_ui_file): New function, mostly a copy
3255         of execute_command_to_string.
3256         (execute_command_to_string): Implement by calling
3257         execute_command_to_ui_file.
3258
3259 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3260
3261         * top.h (saved_command_line): Remove declaration.
3262         * top.c (previous_saved_command_line, previous_repeat_arguments):
3263         New variables.
3264         (saved_command_line): Make static, define together with other
3265         'repeat variables'.
3266         (dont_repeat): Clear repeat_arguments.
3267         (repeat_previous, get_saved_command_line, save_command_line):
3268         New functions.
3269         (gdb_init): Initialize saved_command_line
3270         and previous_saved_command_line.
3271         * main.c (captured_main_1): Remove saved_command_line initialization.
3272         * event-top.c (handle_line_of_input): Update to use
3273         the new 'repeat' related functions instead of direct access to
3274         saved_command_line.
3275         * command.h (repeat_previous, get_saved_command_line,
3276         save_command_line): New declarations.
3277         (dont_repeat): Add comment.
3278
3279 2019-05-30  Tom Tromey  <tromey@adacore.com>
3280
3281         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3282         Fix comment.
3283         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3284
3285 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3286
3287         PR cli/24587
3288         * completer.c (complete): Initialize variable word.
3289
3290 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3291
3292         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3293         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3294         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3295         'body' is NULL to the outter 'if', protecting the '!is_define'
3296         situation as well.
3297
3298 2019-05-29  Tom Tromey  <tromey@adacore.com>
3299
3300         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3301         (dwarf_unknown): New function.
3302         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3303         (dwarf_type_encoding_name): Use dwarf_unknown.
3304
3305 2019-05-29  Tom Tromey  <tromey@adacore.com>
3306
3307         PR c++/20020:
3308         * cp-valprint.c (cp_print_value_fields): Call
3309         cp_print_static_field inside "try".
3310
3311 2019-05-29  Tom Tromey  <tromey@adacore.com>
3312
3313         * inflow.c (struct terminal_info): Add default operator=.
3314         * configure: Rebuild.
3315         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3316         -Wdeprecated-copy-dtor, -Wredundant-move.
3317
3318 2019-05-29  Tom Tromey  <tromey@adacore.com>
3319
3320         * NEWS: Add entry.
3321         * infcmd.c (print_return_value_1): Handle finish_print
3322         option.
3323         (show_print_finish): New function.
3324         (_initialize_infcmd): Add "set/show print finish" commands.
3325         * valprint.c (user_print_options): Initialize new member.
3326         * valprint.h (struct value_print_options) <finish_print>: New
3327         member.
3328
3329 2019-05-28  Tom Tromey  <tromey@adacore.com>
3330
3331         * ada-lang.c (ada_remove_Xbn_suffix)
3332         (find_old_style_renaming_symbol)
3333         (parse_old_style_renaming): Remove.
3334         (ada_find_renaming_symbol): Don't call
3335         find_old_style_renaming_symbol.
3336         (ada_is_renaming_symbol): Rename from
3337         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3338         bool.  Now static.
3339         (ada_read_var_value): Update and simplify.
3340         * ada-exp.y (write_var_or_type): Remove old code.
3341
3342 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3343
3344         * event-top.c: Remove include comment.
3345         * inflow.c (class scoped_ignore_sigttou): Move from here...
3346         * inflow.h (class scoped_ignore_sigttou): ...to here.
3347         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3348         * top.c:  Remove include comment.
3349
3350 2019-05-27  Tom Tromey  <tom@tromey.com>
3351
3352         * NEWS: Fix typo.
3353
3354 2019-05-22  Tom Tromey  <tromey@adacore.com>
3355
3356         * target.c (target_follow_exec): Constify parameter.
3357         * target-delegates.c: Rebuild.
3358         * remote.c (remote_target::follow_exec): Constify parameter.
3359         * infrun.c (follow_exec): Constify parameter.
3360         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3361         (target_follow_exec): Likewise.
3362
3363 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3364
3365         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3366         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3367
3368 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3369
3370         * NEWS: Add debugredirect and testsuite sections.
3371
3372 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3373
3374         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3375         target descriptions using exclusively floating point register name
3376         aliases.
3377
3378 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         PR gdb/18644:
3381         * f-lang.c (build_fortran_types): Handle the case where
3382         gdbarch_floatformat_for_type returns a nullptr.
3383
3384 2019-05-21  Tom de Vries  <tdevries@suse.de>
3385
3386         PR cli/24587
3387         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3388
3389 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         PR gdb/18644:
3392         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3393         16-byte floats.
3394         * i386-tdep.c (i386_floatformat_for_type): Use
3395         floatformats_ia64_quad for the 16-byte floating point component
3396         within a fortran 32-byte complex number.
3397
3398 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3401         delete default constructor.
3402         (find_partial_die): Update to return const struct.
3403         (partial_die_parent_scope): Move variable declaration into scope
3404         of its use and change its type to auto.
3405         (guess_partial_die_structure_name): Likewise.
3406         (partial_die_info::fixup): Likewise.
3407
3408 2019-05-17  Tom Tromey  <tromey@adacore.com>
3409
3410         * source.c (find_and_open_source): Remove cast.
3411
3412 2019-05-17  Tom Tromey  <tromey@adacore.com>
3413
3414         * annotate.c (annotate_source): Make "filename" const.
3415         * annotate.h (annotate_source): Use const.
3416
3417 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3418
3419         * disasm.c (set_disassembler_options): Send errors to stderr.
3420
3421 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3422
3423         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3424         (cli_interp_base::set_logging): Check debug_redirect.
3425         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3426         * cli/cli-logging.c (debug_redirect): Add static variable.
3427         (pop_output_files): Add default param.
3428         (handle_redirections): Print debug setting.
3429         (show_logging_command): Likewise.
3430         (_initialize_cli_logging): Add debugredirect command.
3431         * interps.c (current_interp_set_logging): Add debug_redirect
3432         parameter.
3433         * interps.h (set_logging): Add debug_redirect parameter.
3434         (current_interp_set_logging): Likewise.
3435         * mi/mi-common.h: Likewise.
3436         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3437
3438 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3439             Tom Tromey  <tromey@adacore.com>
3440
3441         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3442         directly.
3443         * cli/cli-interp.h (make_logging_output): Remove declaration.
3444         * cli/cli-logging.c (make_logging_output): Remove function.
3445         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3446         directly.
3447         * ui-file.c (tee_file::tee_file): Remove bools.
3448         (tee_file::~tee_file): Remove deletes.
3449         * ui-file.h (tee_file): Remove bools.
3450
3451 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3452
3453         * mi/mi-cmds.h (mi_cmd_complete): New function.
3454         * mi/mi-main.c (mi_cmd_complete): Likewise.
3455         * mi/mi-cmds.c: Define new MI command -complete.
3456         * NEWS: Mention new -complete command.
3457
3458 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3459
3460         * completer.h (complete): New function.
3461         * completer.c (complete): Likewise.
3462         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3463         function defined in completer.h.
3464
3465 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3466
3467         * MAINTAINERS (Write After Approval): Add myself.
3468
3469 2019-05-17  Tom de Vries  <tdevries@suse.de>
3470
3471         PR gdb/24094
3472         * dwarf2read.c (struct cu_partial_die_info): New struct.
3473         (find_partial_die): Return cu_partial_die_info.
3474         (partial_die_parent_scope, guess_partial_die_structure_name)
3475         (partial_die_info::fixup): Handle new return type of find_partial_die.
3476
3477 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3478
3479         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3480         "std::string", simplifying the algorithm.
3481
3482 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3483
3484         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3485         (stap_static_probe_ops::get_probes): Likewise.
3486
3487 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3488
3489         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3490         '-')" and "else if".
3491         (stap_parse_single_operand): Join checks for
3492         "gdbarch_stap_parse_special_token_p" and
3493         "gdbarch_stap_parse_special_token" in the same "if" statement.
3494         Invert check when verifying for operation on register
3495         displacement.
3496
3497 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3498
3499         * stap-probe.c (stap_get_opcode): Update comment.
3500         (stap_get_expected_argument_type): Likewise.
3501         (handle_stap_probe): Likewise.
3502
3503 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3504
3505         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3506         return type to 'bool'.  Adjust comment.  Use 'bool' when
3507         appropriate.
3508         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3509         * stap-probe.c (stap_parse_argument_1): Likewise.
3510         (stap_is_operator): Likewise.
3511         (stap_is_generic_prefix): Likewise.
3512         (stap_is_register_prefix): Likewise.
3513         (stap_is_register_indirection_prefix): Likewise.
3514         (stap_is_integer_prefix): Likewise.
3515         (stap_generic_check_suffix): Likewise.
3516         (stap_check_integer_suffix): Likewise.
3517         (stap_check_register_suffix): Likewise.
3518         (stap_check_register_indirection_suffix): Likewise.
3519         (stap_parse_register_operand): Likewise.
3520         (stap_parse_single_operand): Likewise.
3521         (stap_parse_argument_1): Likewise.
3522         (stap_probe::get_argument_count): Likewise.
3523         (stap_is_operator): Likewise.
3524
3525 2019-05-16  Tom Tromey  <tromey@adacore.com>
3526
3527         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3528         keyword to foreach.
3529
3530 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3531
3532         * linux-thread-db.c (try_thread_db_load_1): Change return type
3533         to bool.
3534         (try_thread_db_load): Likewise.
3535         (try_thread_db_load_from_pdir_1): Likewise.
3536         (try_thread_db_load_from_pdir): Likewise.
3537         (try_thread_db_load_from_sdir): Likewise.
3538         (try_thread_db_load_from_dir): Likewise.
3539         (thread_db_load_search): Likewise.
3540         (has_libpthread): Likewise.
3541         (thread_db_load): Likewise.
3542
3543 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3544
3545         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3546         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3547         NULL, and complain/return if that's the case.
3548
3549 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3550
3551         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3552         (advance, posn, abstract_read_memory): New functions.
3553         [struct mem_read_abstraction]: New struct.
3554         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3555
3556 2019-05-14  Tom Tromey  <tromey@adacore.com>
3557
3558         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3559         value is not lval_memory.
3560
3561 2019-05-14  Tom Tromey  <tromey@adacore.com>
3562
3563         * solib.c (info_sharedlibrary_command): Style the file name.
3564
3565 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3566
3567         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3568         (aarch64_vnv_type): Likewise.
3569         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3570         * common/tdesc.c: Likewise.
3571         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3572         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3573         * features/aarch64-fpu.xml: Add ieee half view.
3574         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3575         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3576         * gdbtypes.h (struct builtin_type): Likewise.
3577         (struct objfile_type): Likewise.
3578
3579 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3580
3581         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3582         typo.
3583         * location.h (string_to_event_location): Likewise.
3584
3585 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3586
3587         GDB 8.3 released.
3588
3589 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3590
3591         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3592         New variable declaration.
3593         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3594         New variable.
3595         (print_one_breakpoint): Use ui_out::test_flags and new global
3596         variable to compute use_fixed_output.
3597         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3598         Remove.
3599         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3600         (mi_multi_location_breakpoint_output_fixed): Remove.
3601         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3602         new variable.
3603         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3604         fix_multi_location_breakpoint_output flag if version >= 3.
3605         * ui-out.h (enum ui_out_flag)
3606         <fix_multi_location_breakpoint_output>: New enumerator.
3607
3608 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3609
3610         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3611
3612 2019-05-10  Tom Tromey  <tromey@adacore.com>
3613
3614         * ada-lang.c (catch_ada_completer): New function.
3615         (_initialize_ada_language): Use it.
3616
3617 2019-05-10  Tom Tromey  <tromey@adacore.com>
3618
3619         * thread.c (print_thread_info): Make "requested_threads" const.
3620         * gdbthread.h (print_thread_info): Make "requested_threads"
3621         const.
3622         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3623         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3624
3625 2019-05-08  Tom Tromey  <tom@tromey.com>
3626
3627         * gdbtypes.c (objfile_type_data): Change type.
3628         (objfile_type, _initialize_gdbtypes): Update.
3629
3630 2019-05-08  Tom Tromey  <tom@tromey.com>
3631
3632         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3633         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3634         (_initialize_dwarf2_frame): Update.
3635
3636 2019-05-08  Tom Tromey  <tom@tromey.com>
3637
3638         * objc-lang.c (objc_objfile_data): Change type.
3639         (find_methods): Update.
3640         (_initialize_objc_lang): Remove.
3641
3642 2019-05-08  Tom Tromey  <tom@tromey.com>
3643
3644         * stabsread.c (rs6000_builtin_type_data): Change type.
3645         (rs6000_builtin_type, _initialize_stabsread): Update.
3646
3647 2019-05-08  Tom Tromey  <tom@tromey.com>
3648
3649         * mips-tdep.c (mips_pdr_data): Remove.
3650         (_initialize_mips_tdep): Update.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3655         (hppa_init_objfile_priv_data, read_unwind_info)
3656         (find_unwind_entry, _initialize_hppa_tdep): Update.
3657
3658 2019-05-08  Tom Tromey  <tom@tromey.com>
3659
3660         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3661         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3662         on obstack.
3663         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3664
3665 2019-05-08  Tom Tromey  <tom@tromey.com>
3666
3667         * mdebugread.c (basic_type_data): Change type.
3668         (basic_type, _initialize_mdebugread): Update.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3673
3674 2019-05-08  Tom Tromey  <tom@tromey.com>
3675
3676         * nto-tdep.c (nto_inferior_data_reg): Change type.
3677         (nto_inferior_data): Update.
3678         (nto_inferior_data_cleanup, nto_new_inferior_data)
3679         (_initialize_nto_tdep): Remove.
3680         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3681
3682 2019-05-08  Tom Tromey  <tom@tromey.com>
3683
3684         * ada-lang.c (struct ada_inferior_data): Add initializers.
3685         (ada_inferior_data): Change type.
3686         (ada_inferior_data_cleanup): Remove.
3687         (get_ada_inferior_data, ada_inferior_exit)
3688         (struct ada_pspace_data): Add initializers, destructor.
3689         (ada_pspace_data_handle): Change type.
3690         (get_ada_pspace_data): Update.
3691         (ada_pspace_data_cleanup): Remove.
3692
3693 2019-05-08  Tom Tromey  <tom@tromey.com>
3694
3695         * coffread.c (struct coff_symfile_info): Add initializers.
3696         (coff_objfile_data_key): Move lower.  Change type.
3697         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3698         Update.
3699         (coff_free_info): Remove.
3700
3701 2019-05-08  Tom Tromey  <tom@tromey.com>
3702
3703         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3704         (fbsd_pspace_data_handle): Move lower.  Change type.
3705         (get_fbsd_pspace_data): Update.
3706         (fbsd_pspace_data_cleanup): Remove.
3707         (_initialize_fbsd_tdep): Update.
3708
3709 2019-05-08  Tom Tromey  <tom@tromey.com>
3710
3711         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3712         (get_ada_tasks_pspace_data): Update.
3713         (ada_tasks_pspace_data_cleanup): Remove.
3714         (_initialize_tasks): Update.
3715         (ada_tasks_inferior_data_handle): Change type.
3716         (get_ada_tasks_inferior_data): Update.
3717         (ada_tasks_inferior_data_cleanup): Remove.
3718         (struct ada_tasks_pspace_data): Add initializers.
3719
3720 2019-05-08  Tom Tromey  <tom@tromey.com>
3721
3722         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3723         * symfile-debug.c (debug_sym_get_probes): Change type.
3724         * stap-probe.c (handle_stap_probe):
3725         (stap_static_probe_ops::get_probes): Change type.
3726         * probe.h (class static_probe_ops) <get_probes>: Change type.
3727         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3728         (parse_probes_in_pspace): Update.
3729         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3730         Update.
3731         (any_static_probe_ops::get_probes): Change type.
3732         * elfread.c (elfread_data): New typedef.
3733         (probe_key): Change type.
3734         (elf_get_probes): Likewise.  Update.
3735         (probe_key_free): Remove.
3736         (_initialize_elfread): Update.
3737         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3738         Change type.
3739         (dtrace_process_dof_probe, dtrace_process_dof)
3740         (dtrace_static_probe_ops::get_probe): Change type.
3741
3742 2019-05-08  Tom Tromey  <tom@tromey.com>
3743
3744         * xcoffread.c (struct xcoff_symfile_info): Rename from
3745         coff_symfile_info.  Add initializers.
3746         (xcoff_objfile_data_key): Move lower.  Change type.
3747         (XCOFF_DATA): Rewrite.
3748         (xcoff_free_info): Remove.
3749         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3750         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3751         (xcoff_initial_scan): Update.
3752
3753 2019-05-08  Tom Tromey  <tom@tromey.com>
3754
3755         * solib-svr4.c (struct svr4_info): Add initializers and
3756         destructor.
3757         <probes_table>: Now an htab_up.
3758         (solib_svr4_pspace_data): Change type.
3759         (free_probes_table): Simplify.
3760         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3761         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3762         (probes_table_remove_objfile_probes, register_solib_event_probe)
3763         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3764         (_initialize_svr4_solib): Update.
3765
3766 2019-05-08  Tom Tromey  <tom@tromey.com>
3767
3768         * remote.c (remote_pspace_data): Change type.
3769         (remote_pspace_data_cleanup): Remove.
3770         (get_remote_exec_file, set_pspace_remote_exec_file)
3771         (_initialize_remote): Update.
3772
3773 2019-05-08  Tom Tromey  <tom@tromey.com>
3774
3775         * breakpoint.c (breakpoint_objfile_key): Change type.
3776         (get_breakpoint_objfile_data): Update.
3777         (free_breakpoint_objfile_data): Remove.
3778         (_initialize_breakpoint): Update.
3779
3780 2019-05-08  Tom Tromey  <tom@tromey.com>
3781
3782         * linux-tdep.c (struct linux_info): Add initializers.
3783         (linux_inferior_data): Move.  Change type.
3784         (invalidate_linux_cache_inf): Update.
3785         (linux_inferior_data_cleanup): Remove.
3786         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3787
3788 2019-05-08  Tom Tromey  <tom@tromey.com>
3789
3790         * auxv.c (auxv_inferior_data): Move.  Change type.
3791         (auxv_inferior_data_cleanup): Remove.
3792         (invalidate_auxv_cache_inf): Rewrite.
3793         (get_auxv_inferior_data, _initialize_auxv): Update.
3794
3795 2019-05-08  Tom Tromey  <tom@tromey.com>
3796
3797         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3798         (symfile_debug_objfile_data_key): Change type.
3799         (symfile_debug_installed, debug_qf_has_symbols)
3800         (debug_qf_find_last_source_symtab)
3801         (debug_qf_forget_cached_source_info)
3802         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3803         (debug_qf_print_stats, debug_qf_dump)
3804         (debug_qf_expand_symtabs_for_function)
3805         (debug_qf_expand_all_symtabs)
3806         (debug_qf_expand_symtabs_with_fullname)
3807         (debug_qf_map_matching_symbols)
3808         (debug_qf_expand_symtabs_matching)
3809         (debug_qf_find_pc_sect_compunit_symtab)
3810         (debug_qf_map_symbol_filenames)
3811         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3812         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3813         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3814         (debug_sym_read_linetable, debug_sym_relocate): Update.
3815         (symfile_debug_free_objfile): Remove.
3816         (install_symfile_debug_logging, _initialize_symfile_debug):
3817         Update.
3818
3819 2019-05-08  Tom Tromey  <tom@tromey.com>
3820
3821         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3822         allocate_on_obstack.
3823         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3824         (get_dwarf2_per_objfile): Update.
3825         (set_dwarf2_per_objfile): Remove.
3826         (dwarf2_has_info, dwarf2_get_section_info): Update.
3827         (dwarf2_free_objfile): Remove.
3828         (_initialize_dwarf2_read): Update.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3833         initializers.
3834         <unsupported_script_warning_printed,
3835         script_not_found_warning_printed>: Now bool.
3836         (auto_load_pspace_data): Change type.
3837         (~auto_load_pspace_info): Rename from
3838         auto_load_pspace_data_cleanup.
3839         (get_auto_load_pspace_data, init_loaded_scripts_info)
3840         (clear_section_scripts, maybe_print_unsupported_script_warning)
3841         (maybe_print_script_not_found_warning, _initialize_auto_load):
3842         Update.
3843
3844 2019-05-08  Tom Tromey  <tom@tromey.com>
3845
3846         * objfiles.c (objfile_pspace_info): Add destructor and
3847         initializers.
3848         (objfiles_pspace_data): Change type.
3849         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3850         (get_objfile_pspace_data): Update.
3851         (objfiles_bfd_data): Change type.
3852         (get_objfile_bfd_data): Update.
3853         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3854
3855 2019-05-08  Tom Tromey  <tom@tromey.com>
3856
3857         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3858         Change type.
3859         (get_catch_syscall_inferior_data): Update.
3860         (catch_syscall_inferior_data_cleanup): Remove.
3861         (_initialize_break_catch_syscall): Update.
3862
3863 2019-05-08  Tom Tromey  <tom@tromey.com>
3864
3865         * inflow.c (struct terminal_info): Add destructor and
3866         initializers.
3867         (inflow_inferior_data): Change type.
3868         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3869         (get_inflow_inferior_data, inflow_inferior_exit)
3870         (swap_terminal_info, _initialize_inflow): Update.
3871
3872 2019-05-08  Tom Tromey  <tom@tromey.com>
3873
3874         * target-dcache.c (target_dcache_cleanup): Remove.
3875         (target_dcache_aspace_key): Change type.
3876         (target_dcache_init_p, target_dcache_invalidate)
3877         (target_dcache_get, target_dcache_get_or_init)
3878         (_initialize_target_dcache): Update.
3879         * dcache.h (struct dcache_deleter): New.
3880
3881 2019-05-08  Tom Tromey  <tom@tromey.com>
3882
3883         * symtab.c (struct symbol_cache): Add destructor and
3884         initializers.
3885         (symbol_cache_key): Move.  Change type.
3886         (make_symbol_cache, free_symbol_cache): Remove.
3887         (get_symbol_cache): Update.
3888         (symbol_cache_cleanup): Remove.
3889         (ALL_PSPACES, symbol_cache_flush)
3890         (maintenance_print_symbol_cache)
3891         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3892         Update.
3893
3894 2019-05-08  Tom Tromey  <tom@tromey.com>
3895
3896         * symtab.c (struct main_info): Add destructor and initializers.
3897         (main_progspace_key): Move.  Change type.
3898         (get_main_info): Update.
3899         (main_info_cleanup): Remove.
3900         (_initialize_symtab): Update.
3901
3902 2019-05-08  Tom Tromey  <tom@tromey.com>
3903
3904         * registry.h (DECLARE_REGISTRY): Define the _key class.
3905
3906 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * NEWS: Merge two 'New commands' sections.
3909
3910 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3911
3912         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3913         parameter and use Ada language definition instead.
3914         (ada_val_print_ptr): Remove unused language parameter.
3915         (ada_val_print_num): Remove language parameter and use Ada language
3916         definition instead.
3917         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3918         parameter.
3919         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3920         parameter and use Ada language definition instead.
3921         (ada_val_print_1): Update all ada_val_print_xxx calls.
3922         Remove language parameter.
3923         (ada_val_print): Update ada_val_print_1 call.
3924
3925 2019-05-08  Tom Tromey  <tromey@adacore.com>
3926
3927         * remote.c (remote_hw_watchpoint_limit)
3928         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3929         Now static.
3930
3931 2019-05-08  Tom Tromey  <tromey@adacore.com>
3932
3933         * maint.c (_initialize_maint_cmds): Move initialization code to
3934         remote.c.
3935         (watchdog, show_watchdog): Move to remote.c.
3936         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3937         "watchdog" static.
3938         (_initialize_remote): Move initialization code from maint.c.
3939         * defs.h (watchdog): Don't declare.
3940
3941 2019-05-08  Tom Tromey  <tromey@adacore.com>
3942
3943         * tui/tui-interp.c: Include main.h.
3944         * interps.c: Include main.h.
3945         * main.h (interpreter_p): Declare.
3946         * defs.h (interpreter_p): Don't declare.
3947
3948 2019-05-08  Tom Tromey  <tromey@adacore.com>
3949
3950         * dwarf2loc.c: Include dwarf2read.h.
3951         * defs.h (read_unsigned_leb128): Don't declare.
3952         * dwarf2read.h (read_unsigned_leb128): Declare.
3953
3954 2019-05-08  Tom Tromey  <tromey@adacore.com>
3955
3956         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3957         method.
3958
3959 2019-05-08  Tom Tromey  <tromey@adacore.com>
3960
3961         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3962         when no wrap column is set.
3963
3964 2019-05-08  Tom Tromey  <tromey@adacore.com>
3965
3966         * c-lang.c (c_get_string): Handle non-C-style arrays.
3967
3968 2019-05-08  Tom Tromey  <tromey@adacore.com>
3969
3970         * typeprint.c (print_offset_data::update): Print the bit offset,
3971         not the number of bits remaining.
3972
3973 2019-05-08  Tom Tromey  <tromey@adacore.com>
3974
3975         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3976         padding at end of comment.
3977
3978 2019-05-08  Tom Tromey  <tromey@adacore.com>
3979
3980         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3981         Compare main types.
3982
3983 2019-05-06  Tom Tromey  <tom@tromey.com>
3984
3985         * common/scoped_mmap.c: Include common-defs.h.
3986         * common/scoped_mmap.h: Don't include config.h.
3987
3988 2019-05-04  Tom Tromey  <tom@tromey.com>
3989
3990         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3991         (struct aarch64_call_info): Add initializers.
3992         <si>: Now a std::vector.
3993         (pass_on_stack, aarch64_push_dummy_call): Update.
3994
3995 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3996             Tom Tromey  <tom@tromey.com>
3997
3998         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3999         (ppc_threads): Now a std::vector.  Now static.
4000         (hwdebug_find_thread_points_by_tid)
4001         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4002         Update.
4003
4004 2019-05-04  Tom Tromey  <tom@tromey.com>
4005
4006         * arc-tdep.c (arc_tdesc_init): Return bool.
4007
4008 2019-05-04  Tom Tromey  <tom@tromey.com>
4009
4010         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4011         Use gdb_assert_not_reached.
4012
4013 2019-05-04  Tom Tromey  <tom@tromey.com>
4014
4015         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4016         "false".
4017
4018 2019-05-04  Tom Tromey  <tom@tromey.com>
4019
4020         * arc-tdep.c (arc_tdesc_init): Use bool.
4021
4022 2019-05-04  Tom Tromey  <tom@tromey.com>
4023
4024         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4025
4026 2019-05-04  Tom Tromey  <tom@tromey.com>
4027
4028         * cli/cli-cmds.c (valid_command_p): Return bool.
4029
4030 2019-05-04  Tom Tromey  <tom@tromey.com>
4031
4032         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4033         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4034
4035 2019-05-04  Raul Tambre  <raul@tambre.ee>
4036
4037         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4038         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4039         operator for comparison.
4040
4041 2019-05-04  Tom Tromey  <tom@tromey.com>
4042
4043         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4044         (lookup_partial_symbol, print_partial_symbols)
4045         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4046         (psymbol_compare): Update.
4047         (add_psymbol_to_bcache): Clear the entire psymbol.
4048         (maintenance_check_psymtabs): Update.
4049         * psympriv.h (struct partial_symbol): Don't derive from
4050         general_symbol_info.
4051         <obj_section, unrelocated_address, address,
4052         set_unrelocated_address>: Update.
4053         <ginfo>: New member.
4054         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4055         (debug_names::write_psymbols): Update.
4056
4057 2019-05-04  Tom de Vries  <tdevries@suse.de>
4058
4059         * contrib/cc-with-tweaks.sh: Support -n arg.
4060
4061 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4062
4063         * corelow.c (core_target::detach): Ensure frame cache and
4064         register caches are cleared.
4065         inferior.c (exit_inferior_1): Likewise.
4066
4067 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4068             Tom Tromey  <tom@tromey.com>
4069
4070         * dictionary.c (collate_pending_symbols_by_language): Remove
4071         "struct" from foreach.
4072         * symtab.c (lookup_global_symbol_from_objfile)
4073         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4074         foreach.
4075         * ser-tcp.c (net_open): Remove "struct" from foreach.
4076         * objfiles.c (objfile_relocate, objfile_rebase)
4077         (objfile_has_symbols): Remove "struct" from foreach.
4078         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4079         from foreach.
4080         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4081         foreach.
4082         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4083         "struct" from foreach.
4084         * ada-lang.c (create_excep_cond_exprs)
4085         (ada_exception_catchpoint_cond_string): Remove "struct" from
4086         foreach.
4087
4088 2019-05-03  Tom Tromey  <tromey@adacore.com>
4089
4090         * ada-exp.y (convert_char_literal): Check suffix of each
4091         enumerator.
4092
4093 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4094
4095         PR ada/21406:
4096         * ada-exp.y (yywrap): Don't define.
4097         * ada-lex.l (%option): Add noyywrap
4098         (yywrap): Remove.
4099
4100 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4101
4102         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4103         _WIN32_WINNT to the XP level, unless already defined to a higher
4104         level.
4105
4106         * unittests/parse-connection-spec-selftests.c:
4107         * ser-tcp.c:
4108         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4109         override.
4110
4111         * symfile.c (find_separate_debug_file): Remove colon from the
4112         drive spec of DOS/Windows file names of the target, so that the
4113         file name produced from DEBUGDIR and the target's directory will
4114         be valid on DOS/Windows systems.
4115
4116 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4117
4118         * rust-lang.c (val_print_struct): Handle printing structures
4119         containing strings.
4120
4121 2019-05-02  Tom Tromey  <tromey@adacore.com>
4122
4123         * valarith.c (_initialize_valarith): Remove.
4124
4125 2019-05-01  Tom Tromey  <tromey@adacore.com>
4126
4127         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4128         bitfields.
4129
4130 2019-05-01  Tom Tromey  <tromey@adacore.com>
4131
4132         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4133         for big-endian copies.
4134
4135 2019-04-30  Ali Tamur  <tamur@google.com>
4136         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4137         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4138         (read_3_bytes): New function.
4139
4140 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4141
4142         * windows-nat.c (main_thread_id): Delete.
4143         (handle_output_debug_string): Replace main_thread_id by
4144         current_event.dwThreadId.
4145         (fake_create_process): Likewise.
4146         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4147         Do not set main_thread_id.
4148         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4149         current_event.dwThreadId.
4150         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4151
4152 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4153
4154         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4155         Use current_event.dwThreadId instead of main_thread_id.
4156
4157 2019-04-30  Tom Tromey  <tromey@adacore.com>
4158
4159         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4160         (create_excep_cond_exprs): Iterate over program spaces.
4161         (ada_exception_catchpoint_cond_string): Examine all minimal
4162         symbols for exception types.
4163
4164 2019-04-30  Tom Tromey  <tromey@adacore.com>
4165
4166         PR c++/24470:
4167         * dwarf2read.c (process_structure_scope): Handle case where type
4168         has template parameters but no symbol was created.
4169
4170 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4171             Chris January  <chris.january@arm.com>
4172
4173         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4174         qualifier.
4175         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4176
4177 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * f-typeprint.c (f_print_type): Update rules for printing
4180         whitespace.
4181         (f_type_print_varspec_suffix): Likewise.
4182
4183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4184             Chris January  <chris.january@arm.com>
4185
4186         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4187         function arguments.
4188
4189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * f-lang.c (build_fortran_types): Change name of void type to
4192         lower case.
4193         * f-typeprint.c (f_type_print_base): Print the name of the void
4194         type, rather than a fixed string.
4195         * f-valprint.c (f_decorations): Use lower case void string.
4196
4197 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4198             Chris January  <chris.january@arm.com>
4199
4200         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4201         types for Fortran.
4202
4203 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4204             Chris January  <chris.january@arm.com>
4205             David Lecomber  <david.lecomber@arm.com>
4206
4207         * f-exp.y (BINOP_INTRINSIC): New token.
4208         (exp): New parser rule handling BINOP_INTRINSIC.
4209         (f77_keywords): Add new builtin procedures.
4210         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4211         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4212         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4213         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4214         (print_unop_subexp_f): New function.
4215         (print_binop_subexp_f): New function.
4216         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4217         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4218         (dump_subexp_body_f): Likewise.
4219         (operator_check_f): Likewise.
4220         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4221         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4222
4223 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4226         UNOP_KIND.
4227         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4228         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4229         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4230         (operator_length_f): New fuction.
4231         (print_subexp_f): New function.
4232         (op_name_f): New function.
4233         (dump_subexp_body_f): New function.
4234         (operator_check_f): New function.
4235         (exp_descriptor_f): Replace standard expression handling functions
4236         with new functions.
4237         * gdb/fortran-operator.def: New file.
4238         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4239         * gdb/std-operator.def: Remove UNOP_KIND.
4240
4241 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * std-operator.def: Remove unbalanced, stray double quote
4244         character.
4245
4246 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4247             Chris January  <chris.january@arm.com>
4248             Daniel Everett  <daniel.everett@arm.com>
4249             Nick Forrington  <nick.forrington@arm.com>
4250             Richard Bunt  <richard.bunt@arm.com>
4251
4252         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4253         of depth when printing anonymous structs or unions.
4254         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4255         Don't print either the top-level value, or the children if the
4256         max-depth is exceeded.
4257         (ppscm_print_children): When printing the key of a map, allow one
4258         extra level of depth.
4259         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4260         print either the top-level value, or the children if the max-depth
4261         is exceeded.
4262         (print_children): When printing the key of a map, allow one extra
4263         level of depth.
4264         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4265         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4266         (user_print_options): Initialise max_depth field.
4267         (val_print_scalar_or_string_type_p): New function.
4268         (val_print): Check to see if the max depth has been reached.
4269         (val_print_check_max_depth): Define new function.
4270         (show_print_max_depth): New function.
4271         (_initialize_valprint): Add 'print max-depth' option.
4272         * valprint.h (struct value_print_options) <max_depth>: New field.
4273         (val_print_check_max_depth): Declare new function.
4274         * NEWS: Document new feature.
4275
4276 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4277
4278         * ada-lang.c (ada_language_defn): Initialise new field.
4279         * c-lang.c (c_is_string_type_p): New function.
4280         (c_language_defn): Initialise new field.
4281         (cplus_language_defn): Initialise new field.
4282         (asm_language_defn): Initialise new field.
4283         (minimal_language_defn): Initialise new field.
4284         * c-lang.h (c_is_string_type_p): Declare new function.
4285         * d-lang.c (d_language_defn): Initialise new field.
4286         * f-lang.c (f_is_string_type_p): New function.
4287         (f_language_defn): Initialise new field.
4288         * go-lang.c (go_is_string_type_p): New function.
4289         (go_language_defn): Initialise new field.
4290         * language.c (default_is_string_type_p): New function.
4291         (unknown_language_defn): Initialise new field.
4292         (auto_language_defn): Initialise new field.
4293         * language.h (struct language_defn) <la_is_string_type_p>: New
4294         member variable.
4295         (default_is_string_type_p): Declare new function.
4296         * m2-lang.c (m2_language_defn): Initialise new field.
4297         * objc-lang.c (objc_language_defn): Initialise new field.
4298         * opencl-lang.c (opencl_language_defn): Initialise new field.
4299         * p-lang.c (pascal_is_string_type_p): New function.
4300         (pascal_language_defn): Initialise new field.
4301         * rust-lang.c (rust_is_string_type_p): New function.
4302         (rust_language_defn): Initialise new field.
4303
4304 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4305
4306         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4307         New field.
4308         * ada-lang.c (ada_language_defn): Initialise new field.
4309         * c-lang.c (c_language_defn): Likewise.
4310         (cplus_language_defn): Likewise.
4311         (asm_language_defn): Likewise.
4312         (minimal_language_defn): Likewise.
4313         * d-lang.c (d_language_defn): Likewise.
4314         * f-lang.c (f_language_defn): Likewise.
4315         * go-lang.c (go_language_defn): Likewise.
4316         * language.c (unknown_language_defn): Likewise.
4317         (auto_language_defn): Likewise.
4318         * m2-lang.c (m2_language_defn): Likewise.
4319         * objc-lang.c (objc_language_defn): Likewise.
4320         * opencl-lang.c (opencl_language_defn): Likewise.
4321         * p-lang.c (pascal_language_defn): Likewise.
4322         * rust-lang.c (rust_language_defn): Likewise.
4323
4324 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * ada-lang.c (ada_is_character_type): Change return type to bool.
4327         (ada_is_string_type): Likewise.
4328         * ada-lang.h (ada_is_character_type): Update declaration
4329         (ada_is_string_type): Likewise.
4330
4331 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4332
4333         Support style in 'frame|thread apply'
4334
4335         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4336         * record.c (record_start, record_stop): Update callers of
4337         execute_command_to_string with false.
4338         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4339         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4340         methods.
4341         (class string_file): New constructor with term_out parameter.
4342         Override methods term_out and can_emit_style_escape.  New member
4343         term_out.
4344         (class stdio_file): Override can_emit_style_escape.
4345         (class tee_file): Override term_out and can_emit_style_escape.
4346         * utils.h (can_emit_style_escape): Remove.
4347         * utils.c (can_emit_style_escape): Likewise.
4348         Update all callers of can_emit_style_escape (SOMESTREAM) to
4349         SOMESTREAM->can_emit_style_escape.
4350         * source-cache.c (source_cache::get_source_lines): Likewise.
4351         * stack.c (frame_apply_command_count): Call execute_command_to_string
4352         passing the term_out characteristic of the current gdb_stdout.
4353         * thread.c (thr_try_catch_cmd): Likewise.
4354         * top.c (execute_command_to_string): pass term_out parameter
4355         to construct the string_file for the command output.
4356         * ui-file.c (term_cli_styling): New function (most code moved
4357         from utils.c can_emit_style_escape).
4358         (string_file::string_file, string_file::can_emit_style_escape,
4359         stdio_file::can_emit_style_escape, tee_file::term_out,
4360         tee_file::can_emit_style_escape): New functions.
4361
4362 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4363
4364         * NEWS: Mention the new set|show may-call-functions.
4365         * infcall.c (may_call_functions_p): New variable.
4366         (show_may_call_functions_p): New function.
4367         (call_function_by_hand_dummy): Throws an error if not
4368         may-call-functions.
4369         (_initialize_infcall): Call add_setshow_boolean_cmd for
4370         may-call-functions.
4371
4372 2019-04-25  Keith Seitz  <keiths@redhat.com>
4373
4374         PR c++/24367
4375         * cp-support.c (inspect_type): Don't attempt substitutions
4376         of symbol with the same name.
4377
4378 2019-04-25  Tom Tromey  <tromey@adacore.com>
4379
4380         PR gdb/24475:
4381         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4382         static.
4383
4384 2019-04-25  Tom Tromey  <tromey@adacore.com>
4385
4386         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4387         rvalue reference.
4388         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4389         (gdb_xml_parser::parse): Use std::move.
4390         * python/python-internal.h (gdbpy_convert_exception): Take a const
4391         reference.
4392         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4393         std::move.
4394         * python/py-utils.c (gdbpy_convert_exception): Take a const
4395         reference.
4396         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4397         Use std::move.
4398         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4399         Use std::move.
4400         * mi/mi-main.c (mi_print_exception): Take a const reference.
4401         * main.c (handle_command_errors): Take a const reference.
4402         * linespec.c (parse_linespec): Use std::move.
4403         * infcall.c (run_inferior_call): Use std::move.
4404         (call_function_by_hand_dummy): Use std::move.
4405         * exec.c (try_open_exec_file): Use std::move.
4406         * exceptions.h (exception_print, exception_fprintf)
4407         (exception_print_same): Update.
4408         * exceptions.c (print_exception, exception_print)
4409         (exception_fprintf, exception_print_same): Change parameters to
4410         const reference.
4411         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4412         * common/new-op.c: Use std::move.
4413         * common/common-exceptions.h (struct gdb_exception): Add move
4414         constructor.
4415         (struct gdb_exception_error, struct gdb_exception_quit, struct
4416         gdb_quit_bad_alloc): Change constructor to move constructor.
4417         (throw_exception): Change parameter to rvalue reference.
4418         * common/common-exceptions.c (throw_exception): Take rvalue
4419         reference.
4420         * cli/cli-interp.c (safe_execute_command): Use std::move.
4421         * breakpoint.c (insert_bp_location, location_to_sals): Use
4422         std::move.
4423
4424 2019-04-25  Tom Tromey  <tromey@adacore.com>
4425
4426         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4427         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4428         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4429         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4430         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4431         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4432         guile/scm-value.c: Use unpack.
4433         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4434         gdbscm_gdb_exception.
4435         (gdbscm_throw_gdb_exception): Likewise.
4436         (struct gdbscm_gdb_exception): New.
4437         (unpack): New function.
4438         (gdbscm_wrap): Use unpack.
4439
4440 2019-04-25  Tom Tromey  <tromey@adacore.com>
4441
4442         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4443         (gdb_rl_callback_handler): Use std::move.
4444         * common/common-exceptions.h (struct gdb_exception): Add move
4445         assignment operator.
4446         (throw_exception_sjlj): Change "exception" to const reference.
4447         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4448         (throw_exception_sjlj): Change "exception" to const reference.
4449
4450 2019-04-25  Tom Tromey  <tromey@adacore.com>
4451
4452         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4453         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4454         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4455         Update.
4456         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4457         Update.
4458         * mi/mi-interp.c (mi_interp::exec): Update.
4459         * linespec.c (parse_linespec): Update.
4460         * infcall.c (run_inferior_call): Update.
4461         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4462         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4463         (gdbscm_lookup_global_symbol): Update.
4464         * guile/scm-param.c (gdbscm_parameter_value): Update.
4465         * guile/scm-frame.c (gdbscm_frame_read_register)
4466         (gdbscm_frame_read_var): Update.
4467         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4468         * exec.c (try_open_exec_file): Update.
4469         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4470         (gdb_rl_callback_handler): Update.
4471         * common/common-exceptions.h (exception_none): Don't declare.
4472         * common/common-exceptions.c (exception_none): Don't define.
4473         (struct catcher) <exception>: Update.
4474         * cli/cli-interp.c (safe_execute_command): Update.
4475         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4476
4477 2019-04-25  Ali Tamur  <tamur@google.com>
4478
4479         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4480         (read_attribute_value): Likewise.
4481         (dwarf2_read_addr_index): Update comment.
4482         (read_str_index): Add DW_FORM_strx.
4483         (dwarf2_string_attr): Likewise.
4484         (dwarf2_const_value_attr): Likewise.
4485         (dump_die_shallow): Likewise.
4486         (dwarf2_fetch_constant_bytes): Likewise.
4487         (skip_form_bytes): Likewise.
4488         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4489
4490 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4491
4492         PR corefiles/11608
4493         PR corefiles/18187
4494         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4495         OFFSET.  Verify if current mapping contains an ELF header.
4496         (linux_find_memory_regions_full): Adjust call to
4497         dump_mapping_p.
4498
4499 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4500             Kang Li <kanglictf@gmail.com>
4501
4502         PR gdb/21600
4503
4504         * dwarf2-frame.c (read_initial_length): Be consistent about using
4505         unsigned representation of length.
4506         (decode_frame_entry_1): Likewise.  Check for wraparound of
4507         end pointer as well as buffer overflow.
4508
4509 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4510
4511         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4512         "vq".
4513
4514 2019-04-24  Tom Tromey  <tromey@adacore.com>
4515
4516         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * s12z-tdep.c (s12z_unwind_pc): Delete.
4521         (s12z_unwind_sp): Delete.
4522         (s12z_gdbarch_init): Don't register deleted functions with
4523         gdbarch.
4524
4525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * rl78-tdep.c (rl78_unwind_sp): Delete.
4528         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4529
4530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4533         (xstormy16_unwind_pc): Delete.
4534         (xstormy16_dummy_id): Delete.
4535         (xstormy16_gdbarch_init): Don't register deleted functions with
4536         gdbarch.
4537
4538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * vax-tdep.c (vax_unwind_pc): Delete.
4541         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4542
4543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * v850-tdep.c (v850_unwind_sp): Delete.
4546         (v850_unwind_pc): Delete.
4547         (v850_dummy_id): Delete.
4548         (v850_gdbarch_init): Don't register deleted functions with
4549         gdbarch.
4550
4551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4554         (tilegx_unwind_pc): Delete.
4555         (tilegx_unwind_dummy_id): Delete.
4556         (tilegx_gdbarch_init): Don't register deleted functions with
4557         gdbarch.
4558
4559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4562         (tic6x_dummy_id): Delete.
4563         (tic6x_gdbarch_init): Don't register deleted functions with
4564         gdbarch.
4565
4566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * sparc-tdep.c (sparc_unwind_pc): Delete.
4569         (sparc32_gdbarch_init): Don't register deleted function with
4570         gdbarch.
4571
4572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4573
4574         * sh-tdep.c (sh_unwind_sp): Delete.
4575         (sh_unwind_pc): Delete.
4576         (sh_dummy_id): Delete.
4577         (sh_gdbarch_init): Don't register deleted functions with
4578         gdbarch.
4579
4580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * score-tdep.c (score_unwind_sp): Delete.
4583         (score_unwind_pc): Delete.
4584         (score_dummy_id): Delete.
4585         (score_gdbarch_init): Don't register deleted functions with
4586         gdbarch.
4587
4588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * rx-tdep.c (rx_unwind_pc): Delete.
4591         (rx_unwind_sp): Delete.
4592         (rx_dummy_id): Delete.
4593         (rx_gdbarch_init): Don't register deleted functions with
4594         gdbarch.  Update comment.
4595
4596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4599         (rs6000_dummy_id): Delete.
4600         (rs6000_gdbarch_init): Don't register deleted functions with
4601         gdbarch.
4602
4603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * or1k-tdep.c (or1k_dummy_id): Delete.
4606         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4607
4608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * nios2-tdep.c (nios2_dummy_id): Delete.
4611         (nios2_unwind_sp): Delete.
4612         (nios2_gdbarch_init): Don't register deleted functions with
4613         gdbarch.
4614
4615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * nds32-tdep.c (nds32_dummy_id): Delete.
4618         (nds32_unwind_pc): Delete.
4619         (nds32_unwind_sp): Delete.
4620         (nds32_gdbarch_init): Don't register deleted functions with
4621         gdbarch.
4622
4623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * msp430-tdep.c (msp430_unwind_pc): Delete.
4626         (msp430_unwind_sp): Delete.
4627         (msp430_dummy_id): Delete.
4628         (msp430_gdbarch_init): Don't register deleted functions with
4629         gdbarch.
4630
4631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4632
4633         * moxie-tdep.c (moxie_unwind_sp): Delete.
4634         (moxie_unwind_pc): Delete.
4635         (moxie_dummy_id): Delete.
4636         (moxie_gdbarch_init): Don't register deleted functions with
4637         gdbarch.
4638
4639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4640
4641         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4642         (mn10300_unwind_pc): Delete.
4643         (mn10300_unwind_sp): Delete.
4644         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4645         mn10300_unwind_sp.
4646         (mn10300_frame_unwind_init): Don't register deleted functions with
4647         gdbarch.
4648
4649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * mep-tdep.c (mep_unwind_pc): Delete.
4652         (mep_unwind_sp): Delete.
4653         (mep_dummy_id): Delete.
4654         (mep_gdbarch_init): Don't register deleted functions with
4655         gdbarch.
4656
4657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4658
4659         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4660         (m68hc11_unwind_sp): Delete.
4661         (m68hc11_gdbarch_init): Don't register deleted functions with
4662         gdbarch.
4663
4664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * m32r-tdep.c (m32r_unwind_sp): Delete.
4667         (m32r_unwind_pc): Delete.
4668         (m32r_dummy_id): Delete.
4669         (m32r_gdbarch_init): Don't register deleted functions with
4670         gdbarch.
4671
4672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * m32c-tdep.c (m32c_unwind_pc): Delete.
4675         (m32c_unwind_sp): Delete.
4676         (m32c_dummy_id): Delete.
4677         (m32c_gdbarch_init): Don't register deleted functions with
4678         gdbarch.
4679
4680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4681
4682         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4683         (lm32_unwind_pc): Delete.
4684         (lm32_dummy_id): Delete.
4685         (lm32_gdbarch_init): Don't register deleted functions with
4686         gdbarch.
4687
4688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4691         (iq2000_unwind_pc): Delete.
4692         (iq2000_dummy_id): Delete.
4693         (iq2000_gdbarch_init): Don't register deleted functions with
4694         gdbarch.
4695
4696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4697
4698         * nds32-tdep.c (nds32_type_align): Delete.
4699         (nds32_push_dummy_call): Use type_align instead.
4700
4701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4702
4703         * arm-tdep.c (arm_type_align): Only handle vector override case.
4704         (arm_push_dummy_call): Use type_align.
4705         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4706
4707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4708
4709         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4710         case.
4711         (pass_on_stack): Use type_align.
4712         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4713         function.
4714
4715 2019-04-23  Tom Tromey  <tromey@adacore.com>
4716
4717         * dwarf2read.c (line_header::file_name_at): Remove unused
4718         overload.
4719
4720 2019-04-23  Tom de Vries  <tdevries@suse.de>
4721
4722         PR gdb/24438
4723         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4724         invocation.
4725
4726
4727 2019-03-27  Ali Tamur  <tamur@google.com>
4728
4729         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4730         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4731         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4732         (dwarf_expr_context::get_addr_index): Likewise
4733         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4734         (symbol_needs_eval_context::get_addr_index): Likewise
4735         (disassemble_dwarf_expression): Add DW_OP_addrx
4736         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4737         (read_cutu_die_from_dwo): Update comment
4738         (skip_one_die): Add DW_FORM_addrx
4739         (read_attribute_value): Likewise
4740         (var_decode_location): Add DW_OP_addrx
4741         (dwarf2_const_value_attr): Add DW_FORM_addrx
4742         (dump_die_shallow): Likewise
4743         (dwarf2_fetch_constant_bytes): Likewise
4744         (decode_locdesc): Add DW_OP_addrx
4745         (skip_form_bytes): Add DW_FORM_addrx
4746
4747 2019-04-22  Ali Tamur  <tamur@google.com>
4748
4749         * MAINTAINERS (Write After Approval): Add self.
4750
4751 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4752
4753         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4754         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4755         (open_symbol_file_object): Likewise.
4756         (svr4_default_sos): Add info parameter.
4757         (svr4_read_so_list): Likewise.
4758         (svr4_current_sos_direct): Adjust functions calls to pass down
4759         info.
4760         (svr4_current_sos_1): Add info parameter.
4761         (svr4_current_sos): Call get_svr4_info, pass info down to
4762         svr4_current_sos_1.
4763         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4764         get_svr4_info.
4765         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4766         get_svr4_info.
4767         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4768         to get_svr4_info.
4769         (probes_table_remove_objfile_probes): Likewise.
4770         (register_solib_event_probe): Add info parameter.
4771         (solist_update_incremental): Pass info parameter down to
4772         svr4_read_so_list.
4773         (disable_probes_interface): Add info parameter.
4774         (svr4_handle_solib_event): Pass current_program_space to
4775         get_svr4_info.  Adjust disable_probes_interface cleanup.
4776         (svr4_create_probe_breakpoints): Add info parameter, pass it
4777         down to register_solib_event_probe.
4778         (svr4_create_solib_event_breakpoints): Add info parameter,
4779         pass it down to svr4_create_probe_breakpoints.
4780         (enable_break): Pass info down to
4781         svr4_create_solib_event_breakpoints.
4782         (svr4_solib_create_inferior_hook): Pass current_program_space to
4783         get_svr4_info.
4784         (svr4_clear_solib): Likewise.
4785
4786 2019-04-22  Pedro Alves  <palves@redhat.com>
4787
4788         * solib-svr4.c (svr4_free_objfile_observer): New.
4789         (probe_and_action::objfile): New field.
4790         (probes_table_htab_remove_objfile_probes)
4791         (probes_table_remove_objfile_probes): New functions.
4792         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4793         in the new probe_and_action.  Don't store the probe in 'lookup'.
4794         (svr4_create_probe_breakpoints): Pass objfile to
4795         register_solib_event_probe.
4796         (_initialize_svr4_solib): Register a free_objfile observer.
4797
4798 2019-04-19  Tom Tromey  <tom@tromey.com>
4799
4800         * common/queue.h: Remove.
4801
4802 2019-04-19  Tom Tromey  <tom@tromey.com>
4803
4804         * event-loop.c: Don't include "common/queue.h".
4805
4806 2019-04-19  Tom Tromey  <tom@tromey.com>
4807
4808         * remote.c (remote_target): Use delete.
4809         * remote-notif.h: Include <list>, not "common/queue.h".
4810         (notif_client_p): Remove typedef.
4811         (remote_notif_state): Add constructor, destructor, initializer.
4812         <notif_queue>: Now a std::list.
4813         (remote_notif_state_xfree): Don't declare.
4814         * remote-notif.c (remote_notif_process, handle_notification)
4815         (remote_notif_state_allocate): Update.
4816         (~remote_notif_state): Rename from remote_notif_state_xfree.
4817
4818 2019-04-19  Tom Tromey  <tom@tromey.com>
4819
4820         * symfile.c (reread_symbols): Update.
4821         * objfiles.c (objfile_register_static_link)
4822         (objfile_lookup_static_link): Update
4823         (~objfile) Don't delete static_links.
4824         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4825
4826 2019-04-19  Tom Tromey  <tom@tromey.com>
4827
4828         * type-stack.h (struct type_stack) <insert>: Constify string.
4829         * type-stack.c (type_stack::insert): Constify string.
4830         * gdbtypes.h (lookup_template_type): Update.
4831         (address_space_name_to_int): Update.
4832         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4833         const.
4834         (lookup_template_type): Make name const.
4835         * c-exp.y: Update rules.
4836         (lex_one_token, classify_name, classify_inner_name)
4837         (c_print_token): Update.
4838         * p-exp.y: Update rules.
4839         (yylex): Update.
4840         * f-exp.y: Update rules.
4841         (yylex): Update.
4842         * d-exp.y: Update rules.
4843         (lex_one_token, classify_name, classify_inner_name): Update.
4844         * parse.c (write_dollar_variable, copy_name): Return std::string.
4845         * parser-defs.h (copy_name): Change return type.
4846         * m2-exp.y: Update rules.
4847         (yylex): Update.
4848         * go-exp.y (lex_one_token): Update.
4849         Update rules.
4850         (classify_unsafe_function, classify_packaged_name)
4851         (classify_name, yylex): Update.
4852
4853 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4854
4855         * configure.ac: add --enable-source-highlight switch.
4856         * configure: Regenerate.
4857         * top.c (print_gdb_version): plumb --enable-source-highlight
4858         status to "show configuration".
4859
4860 2019-04-19  Tom Tromey  <tromey@adacore.com>
4861
4862         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4863         Check ADA_TYPE_P.
4864         (empty_record, ada_template_to_fixed_record_type_1)
4865         (template_to_static_fixed_type)
4866         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4867         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4868         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4869         macros.
4870
4871 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4872
4873         PR symtab/24423:
4874         * source.c (print_source_lines_base): Advance "iter" when a
4875         control character is seen.
4876
4877 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4878
4879         * inferior.h (struct infcall_suspend_state_deleter):
4880         Catch exception in destructor to avoid crash.
4881
4882 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4883
4884         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4885         close to the add_com "shell".
4886
4887 2019-04-18  Tom Tromey  <tromey@adacore.com>
4888
4889         * process-stratum-target.h (class process_stratum_target)
4890         <stratum>: Add "final".
4891
4892 2019-04-17  Tom Tromey  <tromey@adacore.com>
4893
4894         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4895         against nullptr before use.
4896
4897 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4898
4899         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4900
4901 2019-04-17  Jim Wilson  <jimw@sifive.com>
4902             Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4905         code read might fail, assume 4-byte breakpoint in that case.
4906
4907 2019-04-15  Leszek Swirski  <leszeks@google.com>
4908
4909         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4910         rather than a hand-rolled POD check when checking for forced MEMORY
4911         classification.
4912
4913 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4914
4915         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4916         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4917         function.
4918         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4919         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4920         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4921         declaration.
4922
4923 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4924
4925         * aarch64-linux-nat.c
4926         (aarch64_linux_nat_target::thread_architecture): Add override.
4927         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4928         each VQ.
4929
4930 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4931
4932         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4933
4934 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4937         target types of size 96-bits, add some additional comments, and
4938         check that the builtin type we found was the correct size.
4939
4940 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4941
4942         * utils.c (prompt_for_continue): Don't restore the styling at the
4943         end, as applied_style has the wrong value.  This fixes styling in
4944         long lists of file names that are interrupted by the "Continue?"
4945         prompt.
4946
4947 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4950         * c-lang.c (c_language_defn): Likewise.
4951         (cplus_language_defn): Likewise.
4952         (asm_language_defn): Likewise.
4953         (minimal_language_defn): Likewise.
4954         * d-lang.c (d_language_defn): Likewise.
4955         * f-lang.c (f_language_defn): Likewise.
4956         * go-lang.c (go_language_defn): Likewise.
4957         * language.c (unknown_language_defn): Likewise.
4958         (auto_language_defn): Likewise.
4959         * language.h (struct language_defn): Remove la_magic field.
4960         (LANG_MAGIC): Delete.
4961         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4962         * objc-lang.c (objc_language_defn): Likewise.
4963         * opencl-lang.c (opencl_language_defn): Likewise.
4964         * p-lang.c (pascal_language_defn): Likewise.
4965         * rust-lang.c (rust_language_defn): Likewise.
4966
4967 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * riscv-tdep.c (riscv_type_align): New function.
4970         (riscv_type_alignment): Delete.
4971         (riscv_arg_location): Use 'type_align'.
4972         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4973
4974 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * gdbtypes.c (type_align): A struct with no non-static fields also
4977         has alignment of 1.
4978
4979 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4980
4981         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4982         component to 0.
4983         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4984         member.
4985         (riscv_struct_info::analyse): New implementation using new
4986         analyse_inner member function.
4987         (riscv_struct_info::field_offset): New member function.
4988         (riscv_struct_info::m_offsets): New member variable.
4989         (riscv_struct_info::analyse_inner): New private member function,
4990         takes the old implementation of riscv_struct_info::analyse but
4991         extended to track field offsets.
4992         (riscv_call_arg_struct): Update the struct folding special cases
4993         to handle cases where empty C++ structs, which are non-zero
4994         length, are found.
4995         (riscv_arg_location): Initialise the length of each location, a
4996         non-zero length now indicates the location is in use.
4997         (riscv_push_dummy_call): Allow for the first location having a
4998         non-zero offset when setting up arguments.
4999         (riscv_return_value): Likewise, but for return values.
5000
5001 2019-04-11  Tom Tromey  <tromey@adacore.com>
5002
5003         * utils.c (internal_vproblem): Make "msg" const.
5004
5005 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5006
5007         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5008         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5009         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5010         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5011
5012 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5013
5014         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5015         function.
5016         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5017         of amd64_collect_native_gregset.
5018         (amd64_linux_nat_target::store_registers): Likewise.
5019
5020 2019-04-10  Tom Tromey  <tom@tromey.com>
5021
5022         * symtab.c (lookup_global_symbol_from_objfile)
5023         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5024         * objfiles.h (class separate_debug_iterator): New.
5025         (class separate_debug_range): New.
5026         (struct objfile) <separate_debug_objfiles>: New method.
5027         (objfile_separate_debug_iterate): Don't declare.
5028         * objfiles.c (separate_debug_iterator::operator++): Rename from
5029         objfile_separate_debug_iterate.
5030         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5031         iterator.
5032         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5033         iterator.
5034
5035 2019-04-10  Tom Tromey  <tom@tromey.com>
5036
5037         * symfile.c (reread_symbols): Remove old comment.
5038         * objfiles.c (free_all_objfiles): Fix a typo.
5039
5040 2019-04-10  Tom Tromey  <tom@tromey.com>
5041
5042         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5043         * minsyms.c (lookup_minimal_symbol): Use foreach.
5044         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5045         (lookup_minimal_symbol_solib_trampoline): Likewise.
5046         * symfile.c (reread_symbols): Use foreach.
5047
5048 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5049             Tom Tromey  <tromey@adacore.com>
5050
5051         PR rust/24414:
5052         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5053         (rust_lex_int_test): Change "value" to be LONGEST.
5054         (rust_lex_tests): Add test for long integer literal.
5055
5056 2019-04-09  Tom Tromey  <tromey@adacore.com>
5057
5058         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5059         to bool.
5060         (extended_remote_target::attach): Update.
5061         (remote_target::remote_notice_new_inferior): Update.
5062         (remote_target::add_current_inferior_and_thread): Update.
5063         * inferior.c (exit_inferior_1): Use "false".
5064         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5065
5066 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5067
5068         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5069         the "start" command.
5070
5071 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5072
5073         * python/py-inferior.c (infpy_thread_from_thread_handle):
5074         Adjust comments to reflect renaming of thread_from_thread_handle
5075         to thread_from_handle.  Adjust keywords.  Fix type error message.
5076         (inferior_object_methods): Add thread_from_handle.  Retain
5077         thread_from_thread_handle, but mark it as deprecated.
5078
5079 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5080
5081         * gdbthread.h (find_thread_by_handle): Revise declaration.
5082         * thread.c (find_thread_by_handle): Likewise.  Adjust
5083         implementation too.
5084         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5085         support for buffer objects as handles.
5086
5087 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5088
5089         * python/py-infthread.c (thpy_thread_handle): New function.
5090         (thread_object_methods): Register thpy_thread_handle.
5091
5092 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5093
5094         * gdbthread.h (thread_to_thread_handle): Declare.
5095         * thread.c (gdbtypes.h): Include.
5096         (thread_to_thread_handle): New function.
5097
5098         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5099         (target_thread_info_to_thread_handle): Declare.
5100         * target.c (target_thread_info_to_thread_handle): New function.
5101         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5102         * target-delegates.c: Regenerate.
5103
5104         * linux-thread-db.c (class thread_db_target): Add method
5105         thread_info_to_thread_handle.
5106         (thread_db_target::thread_info_to_thread_handle): Define.
5107         * remote.c (class remote_target): Add new method
5108         thread_info_to_thread_handle.
5109         (remote_target::thread_info_to_thread_handle): Define.
5110
5111 2019-04-08  Pedro Alves  <palves@redhat.com>
5112
5113         * common/common-exceptions.c (throw_exception): Don't create
5114         named object to throw; throw directly.
5115         (throw_it): Likewise.  Don't initialize gdb_exception::message
5116         here, with new; pass FMT and AP to the ctor instead.
5117         * common/common-exceptions.h: Include <string>.
5118         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5119         const char *, va_list)): New ctor.  Use std::make_shared.
5120         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5121         errors)): Delete.
5122         (gdb_exception_error::gdb_exception_error(enum errors, const char
5123         *, va_list)): New.
5124         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5125         Add assertion.
5126         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5127         errors)): Delete.
5128         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5129         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5130         Add assertion.
5131
5132 2019-04-08  Tom Tromey  <tom@tromey.com>
5133
5134         * valops.c (value_rtti_indirect_type): Replace throw_exception
5135         with throw.
5136         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5137         with throw.
5138         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5139         throw.
5140         * target.c (target_translate_tls_address): Replace throw_exception
5141         with throw.
5142         * stack.c (frame_apply_command_count): Replace throw_exception
5143         with throw.
5144         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5145         throw.
5146         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5147         with throw.
5148         * rs6000-tdep.c (rs6000_frame_cache)
5149         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5150         * remote.c: Replace throw_exception with throw.
5151         * record-full.c (record_full_message, record_full_wait_1)
5152         (record_full_restore): Replace throw_exception with throw.
5153         * record-btrace.c:
5154         (get_thread_current_frame_id, record_btrace_start_replaying)
5155         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5156         (cmd_record_btrace_start): Replace throw_exception with throw.
5157         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5158         throw.
5159         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5160         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5161         * linespec.c:
5162         (find_linespec_symbols): Replace throw_exception with throw.
5163         * infrun.c (displaced_step_prepare, resume): Replace
5164         throw_exception with throw.
5165         * infcmd.c (post_create_inferior): Replace throw_exception with
5166         throw.
5167         * inf-loop.c (inferior_event_handler): Replace throw_exception
5168         with throw.
5169         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5170         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5171         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5172         (get_prev_frame_always, get_frame_pc_if_available)
5173         (get_frame_address_in_block_if_available, get_frame_language):
5174         Replace throw_exception with throw.
5175         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5176         throw_exception with throw.
5177         * eval.c (fetch_subexp_value, evaluate_var_value)
5178         (evaluate_funcall, evaluate_subexp_standard): Replace
5179         throw_exception with throw.
5180         * dwarf2loc.c (call_site_find_chain)
5181         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5182         Replace throw_exception with throw.
5183         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5184         with throw.
5185         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5186         throw.
5187         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5188         * completer.c (complete_line_internal): Replace throw_exception
5189         with throw.
5190         * compile/compile-object-run.c (compile_object_run): Replace
5191         throw_exception with throw.
5192         * cli/cli-script.c (process_next_line): Replace throw_exception
5193         with throw.
5194         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5195         (btrace_enable, btrace_maint_update_pt_packets): Replace
5196         throw_exception with throw.
5197         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5198         throw_exception with throw.
5199         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5200         throw_exception with throw.
5201         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5202         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5203         * aarch64-tdep.c (aarch64_make_prologue_cache)
5204         (aarch64_make_stub_cache): Replace throw_exception with throw.
5205
5206 2019-04-08  Tom Tromey  <tom@tromey.com>
5207
5208         * common/common-exceptions.c (throw_exception): Rename from
5209         throw_exception_cxx.  Remove old copy.  Make argument const.
5210         (throw_it): Create and throw exception objects directly.
5211         * common/common-exceptions.h (throw_exception): Make argument
5212         const.
5213         (struct gdb_exception_error): Add constructor.
5214         (struct gdb_exception_quit): Add constructor.
5215
5216 2019-04-08  Tom Tromey  <tom@tromey.com>
5217
5218         * common/common-exceptions.h (exception_rethrow): Don't declare.
5219         (TRY_SJLJ): Update comment.
5220         (TRY, CATCH, END_CATCH): Remove.
5221         * common/common-exceptions.c (exception_rethrow): Remove.
5222
5223 2019-04-08  Tom Tromey  <tom@tromey.com>
5224
5225         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5226         Remove.
5227         (gdb_exception_error): Rename from
5228         gdb_exception_RETURN_MASK_ERROR.
5229         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5230         (gdb_quit_bad_alloc): Update.
5231         * aarch64-tdep.c: Update.
5232         * ada-lang.c: Update.
5233         * ada-typeprint.c: Update.
5234         * ada-valprint.c: Update.
5235         * amd64-tdep.c: Update.
5236         * arch-utils.c: Update.
5237         * break-catch-throw.c: Update.
5238         * breakpoint.c: Update.
5239         * btrace.c: Update.
5240         * c-varobj.c: Update.
5241         * cli/cli-cmds.c: Update.
5242         * cli/cli-interp.c: Update.
5243         * cli/cli-script.c: Update.
5244         * common/common-exceptions.c: Update.
5245         * common/new-op.c: Update.
5246         * common/selftest.c: Update.
5247         * compile/compile-c-symbols.c: Update.
5248         * compile/compile-cplus-symbols.c: Update.
5249         * compile/compile-object-load.c: Update.
5250         * compile/compile-object-run.c: Update.
5251         * completer.c: Update.
5252         * corelow.c: Update.
5253         * cp-abi.c: Update.
5254         * cp-support.c: Update.
5255         * cp-valprint.c: Update.
5256         * darwin-nat.c: Update.
5257         * disasm-selftests.c: Update.
5258         * dtrace-probe.c: Update.
5259         * dwarf-index-cache.c: Update.
5260         * dwarf-index-write.c: Update.
5261         * dwarf2-frame-tailcall.c: Update.
5262         * dwarf2-frame.c: Update.
5263         * dwarf2loc.c: Update.
5264         * dwarf2read.c: Update.
5265         * eval.c: Update.
5266         * event-loop.c: Update.
5267         * event-top.c: Update.
5268         * exec.c: Update.
5269         * f-valprint.c: Update.
5270         * fbsd-tdep.c: Update.
5271         * frame-unwind.c: Update.
5272         * frame.c: Update.
5273         * gdbtypes.c: Update.
5274         * gnu-v3-abi.c: Update.
5275         * guile/guile-internal.h: Update.
5276         * guile/scm-block.c: Update.
5277         * guile/scm-breakpoint.c: Update.
5278         * guile/scm-cmd.c: Update.
5279         * guile/scm-disasm.c: Update.
5280         * guile/scm-frame.c: Update.
5281         * guile/scm-lazy-string.c: Update.
5282         * guile/scm-math.c: Update.
5283         * guile/scm-param.c: Update.
5284         * guile/scm-ports.c: Update.
5285         * guile/scm-pretty-print.c: Update.
5286         * guile/scm-symbol.c: Update.
5287         * guile/scm-symtab.c: Update.
5288         * guile/scm-type.c: Update.
5289         * guile/scm-value.c: Update.
5290         * i386-linux-tdep.c: Update.
5291         * i386-tdep.c: Update.
5292         * inf-loop.c: Update.
5293         * infcall.c: Update.
5294         * infcmd.c: Update.
5295         * infrun.c: Update.
5296         * jit.c: Update.
5297         * language.c: Update.
5298         * linespec.c: Update.
5299         * linux-fork.c: Update.
5300         * linux-nat.c: Update.
5301         * linux-tdep.c: Update.
5302         * linux-thread-db.c: Update.
5303         * main.c: Update.
5304         * mi/mi-cmd-break.c: Update.
5305         * mi/mi-cmd-stack.c: Update.
5306         * mi/mi-interp.c: Update.
5307         * mi/mi-main.c: Update.
5308         * objc-lang.c: Update.
5309         * p-valprint.c: Update.
5310         * parse.c: Update.
5311         * ppc-linux-tdep.c: Update.
5312         * printcmd.c: Update.
5313         * python/py-arch.c: Update.
5314         * python/py-breakpoint.c: Update.
5315         * python/py-cmd.c: Update.
5316         * python/py-finishbreakpoint.c: Update.
5317         * python/py-frame.c: Update.
5318         * python/py-framefilter.c: Update.
5319         * python/py-gdb-readline.c: Update.
5320         * python/py-inferior.c: Update.
5321         * python/py-infthread.c: Update.
5322         * python/py-lazy-string.c: Update.
5323         * python/py-linetable.c: Update.
5324         * python/py-objfile.c: Update.
5325         * python/py-param.c: Update.
5326         * python/py-prettyprint.c: Update.
5327         * python/py-progspace.c: Update.
5328         * python/py-record-btrace.c: Update.
5329         * python/py-record.c: Update.
5330         * python/py-symbol.c: Update.
5331         * python/py-type.c: Update.
5332         * python/py-unwind.c: Update.
5333         * python/py-utils.c: Update.
5334         * python/py-value.c: Update.
5335         * python/python.c: Update.
5336         * record-btrace.c: Update.
5337         * record-full.c: Update.
5338         * remote-fileio.c: Update.
5339         * remote.c: Update.
5340         * riscv-tdep.c: Update.
5341         * rs6000-aix-tdep.c: Update.
5342         * rs6000-tdep.c: Update.
5343         * rust-exp.y: Update.
5344         * rust-lang.c: Update.
5345         * s390-tdep.c: Update.
5346         * selftest-arch.c: Update.
5347         * solib-dsbt.c: Update.
5348         * solib-frv.c: Update.
5349         * solib-spu.c: Update.
5350         * solib-svr4.c: Update.
5351         * solib.c: Update.
5352         * sparc64-linux-tdep.c: Update.
5353         * stack.c: Update.
5354         * symfile-mem.c: Update.
5355         * symmisc.c: Update.
5356         * target.c: Update.
5357         * thread.c: Update.
5358         * top.c: Update.
5359         * tracefile-tfile.c: Update.
5360         * tui/tui.c: Update.
5361         * typeprint.c: Update.
5362         * unittests/cli-utils-selftests.c: Update.
5363         * unittests/parse-connection-spec-selftests.c: Update.
5364         * valops.c: Update.
5365         * valprint.c: Update.
5366         * value.c: Update.
5367         * varobj.c: Update.
5368         * windows-nat.c: Update.
5369         * x86-linux-nat.c: Update.
5370         * xml-support.c: Update.
5371
5372 2019-04-08  Tom Tromey  <tom@tromey.com>
5373
5374         * xml-support.c: Use C++ exception handling.
5375         * x86-linux-nat.c: Use C++ exception handling.
5376         * windows-nat.c: Use C++ exception handling.
5377         * varobj.c: Use C++ exception handling.
5378         * value.c: Use C++ exception handling.
5379         * valprint.c: Use C++ exception handling.
5380         * valops.c: Use C++ exception handling.
5381         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5382         handling.
5383         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5384         * typeprint.c: Use C++ exception handling.
5385         * tui/tui.c: Use C++ exception handling.
5386         * tracefile-tfile.c: Use C++ exception handling.
5387         * top.c: Use C++ exception handling.
5388         * thread.c: Use C++ exception handling.
5389         * target.c: Use C++ exception handling.
5390         * symmisc.c: Use C++ exception handling.
5391         * symfile-mem.c: Use C++ exception handling.
5392         * stack.c: Use C++ exception handling.
5393         * sparc64-linux-tdep.c: Use C++ exception handling.
5394         * solib.c: Use C++ exception handling.
5395         * solib-svr4.c: Use C++ exception handling.
5396         * solib-spu.c: Use C++ exception handling.
5397         * solib-frv.c: Use C++ exception handling.
5398         * solib-dsbt.c: Use C++ exception handling.
5399         * selftest-arch.c: Use C++ exception handling.
5400         * s390-tdep.c: Use C++ exception handling.
5401         * rust-lang.c: Use C++ exception handling.
5402         * rust-exp.y: Use C++ exception handling.
5403         * rs6000-tdep.c: Use C++ exception handling.
5404         * rs6000-aix-tdep.c: Use C++ exception handling.
5405         * riscv-tdep.c: Use C++ exception handling.
5406         * remote.c: Use C++ exception handling.
5407         * remote-fileio.c: Use C++ exception handling.
5408         * record-full.c: Use C++ exception handling.
5409         * record-btrace.c: Use C++ exception handling.
5410         * python/python.c: Use C++ exception handling.
5411         * python/py-value.c: Use C++ exception handling.
5412         * python/py-utils.c: Use C++ exception handling.
5413         * python/py-unwind.c: Use C++ exception handling.
5414         * python/py-type.c: Use C++ exception handling.
5415         * python/py-symbol.c: Use C++ exception handling.
5416         * python/py-record.c: Use C++ exception handling.
5417         * python/py-record-btrace.c: Use C++ exception handling.
5418         * python/py-progspace.c: Use C++ exception handling.
5419         * python/py-prettyprint.c: Use C++ exception handling.
5420         * python/py-param.c: Use C++ exception handling.
5421         * python/py-objfile.c: Use C++ exception handling.
5422         * python/py-linetable.c: Use C++ exception handling.
5423         * python/py-lazy-string.c: Use C++ exception handling.
5424         * python/py-infthread.c: Use C++ exception handling.
5425         * python/py-inferior.c: Use C++ exception handling.
5426         * python/py-gdb-readline.c: Use C++ exception handling.
5427         * python/py-framefilter.c: Use C++ exception handling.
5428         * python/py-frame.c: Use C++ exception handling.
5429         * python/py-finishbreakpoint.c: Use C++ exception handling.
5430         * python/py-cmd.c: Use C++ exception handling.
5431         * python/py-breakpoint.c: Use C++ exception handling.
5432         * python/py-arch.c: Use C++ exception handling.
5433         * printcmd.c: Use C++ exception handling.
5434         * ppc-linux-tdep.c: Use C++ exception handling.
5435         * parse.c: Use C++ exception handling.
5436         * p-valprint.c: Use C++ exception handling.
5437         * objc-lang.c: Use C++ exception handling.
5438         * mi/mi-main.c: Use C++ exception handling.
5439         * mi/mi-interp.c: Use C++ exception handling.
5440         * mi/mi-cmd-stack.c: Use C++ exception handling.
5441         * mi/mi-cmd-break.c: Use C++ exception handling.
5442         * main.c: Use C++ exception handling.
5443         * linux-thread-db.c: Use C++ exception handling.
5444         * linux-tdep.c: Use C++ exception handling.
5445         * linux-nat.c: Use C++ exception handling.
5446         * linux-fork.c: Use C++ exception handling.
5447         * linespec.c: Use C++ exception handling.
5448         * language.c: Use C++ exception handling.
5449         * jit.c: Use C++ exception handling.
5450         * infrun.c: Use C++ exception handling.
5451         * infcmd.c: Use C++ exception handling.
5452         * infcall.c: Use C++ exception handling.
5453         * inf-loop.c: Use C++ exception handling.
5454         * i386-tdep.c: Use C++ exception handling.
5455         * i386-linux-tdep.c: Use C++ exception handling.
5456         * guile/scm-value.c: Use C++ exception handling.
5457         * guile/scm-type.c: Use C++ exception handling.
5458         * guile/scm-symtab.c: Use C++ exception handling.
5459         * guile/scm-symbol.c: Use C++ exception handling.
5460         * guile/scm-pretty-print.c: Use C++ exception handling.
5461         * guile/scm-ports.c: Use C++ exception handling.
5462         * guile/scm-param.c: Use C++ exception handling.
5463         * guile/scm-math.c: Use C++ exception handling.
5464         * guile/scm-lazy-string.c: Use C++ exception handling.
5465         * guile/scm-frame.c: Use C++ exception handling.
5466         * guile/scm-disasm.c: Use C++ exception handling.
5467         * guile/scm-cmd.c: Use C++ exception handling.
5468         * guile/scm-breakpoint.c: Use C++ exception handling.
5469         * guile/scm-block.c: Use C++ exception handling.
5470         * guile/guile-internal.h: Use C++ exception handling.
5471         * gnu-v3-abi.c: Use C++ exception handling.
5472         * gdbtypes.c: Use C++ exception handling.
5473         * frame.c: Use C++ exception handling.
5474         * frame-unwind.c: Use C++ exception handling.
5475         * fbsd-tdep.c: Use C++ exception handling.
5476         * f-valprint.c: Use C++ exception handling.
5477         * exec.c: Use C++ exception handling.
5478         * event-top.c: Use C++ exception handling.
5479         * event-loop.c: Use C++ exception handling.
5480         * eval.c: Use C++ exception handling.
5481         * dwarf2read.c: Use C++ exception handling.
5482         * dwarf2loc.c: Use C++ exception handling.
5483         * dwarf2-frame.c: Use C++ exception handling.
5484         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5485         * dwarf-index-write.c: Use C++ exception handling.
5486         * dwarf-index-cache.c: Use C++ exception handling.
5487         * dtrace-probe.c: Use C++ exception handling.
5488         * disasm-selftests.c: Use C++ exception handling.
5489         * darwin-nat.c: Use C++ exception handling.
5490         * cp-valprint.c: Use C++ exception handling.
5491         * cp-support.c: Use C++ exception handling.
5492         * cp-abi.c: Use C++ exception handling.
5493         * corelow.c: Use C++ exception handling.
5494         * completer.c: Use C++ exception handling.
5495         * compile/compile-object-run.c: Use C++ exception handling.
5496         * compile/compile-object-load.c: Use C++ exception handling.
5497         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5498         * compile/compile-c-symbols.c: Use C++ exception handling.
5499         * common/selftest.c: Use C++ exception handling.
5500         * common/new-op.c: Use C++ exception handling.
5501         * cli/cli-script.c: Use C++ exception handling.
5502         * cli/cli-interp.c: Use C++ exception handling.
5503         * cli/cli-cmds.c: Use C++ exception handling.
5504         * c-varobj.c: Use C++ exception handling.
5505         * btrace.c: Use C++ exception handling.
5506         * breakpoint.c: Use C++ exception handling.
5507         * break-catch-throw.c: Use C++ exception handling.
5508         * arch-utils.c: Use C++ exception handling.
5509         * amd64-tdep.c: Use C++ exception handling.
5510         * ada-valprint.c: Use C++ exception handling.
5511         * ada-typeprint.c: Use C++ exception handling.
5512         * ada-lang.c: Use C++ exception handling.
5513         * aarch64-tdep.c: Use C++ exception handling.
5514
5515 2019-04-08  Tom Tromey  <tom@tromey.com>
5516
5517         * xml-support.c (gdb_xml_parser::parse): Update.
5518         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5519         * value.c (show_convenience): Update.
5520         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5521         (test_parse_flags_qcs): Update.
5522         * thread.c (thr_try_catch_cmd): Update.
5523         * target.c (target_translate_tls_address): Update.
5524         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5525         (info_frame_command_core, frame_apply_command_count): Update.
5526         * rust-exp.y (rust_lex_exception_test): Update.
5527         * riscv-tdep.c (riscv_print_one_register_info): Update.
5528         * remote.c (remote_target::enable_btrace): Update.
5529         * record-btrace.c (record_btrace_enable_warn): Update.
5530         * python/py-utils.c (gdbpy_convert_exception): Update.
5531         * printcmd.c (do_one_display, print_variable_and_value): Update.
5532         * mi/mi-main.c (mi_print_exception): Update.
5533         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5534         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5535         * linux-nat.c (linux_nat_target::attach): Update.
5536         * linux-fork.c (class scoped_switch_fork_info): Update.
5537         * infrun.c (displaced_step_prepare): Update.
5538         * infcall.c (call_function_by_hand_dummy): Update.
5539         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5540         * gnu-v3-abi.c (print_one_vtable): Update.
5541         * frame.c (get_prev_frame_always): Update.
5542         * f-valprint.c (info_common_command_for_block): Update.
5543         * exec.c (try_open_exec_file): Update.
5544         * exceptions.c (print_exception, exception_print)
5545         (exception_fprintf, exception_print_same): Update.
5546         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5547         * dwarf-index-cache.c (index_cache::store)
5548         (index_cache::lookup_gdb_index): Update.
5549         * darwin-nat.c (maybe_cache_shell): Update.
5550         * cp-valprint.c (cp_print_value_fields): Update.
5551         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5552         (gcc_cplus_symbol_address): Update.
5553         * compile/compile-c-symbols.c (gcc_convert_symbol)
5554         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5555         * common/selftest.c: Update.
5556         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5557         a std::string.
5558         (exception_try_scope_entry, exception_try_scope_exit): Don't
5559         declare.
5560         (struct exception_try_scope): Remove.
5561         (TRY): Don't use exception_try_scope.
5562         (struct gdb_exception): Add constructor, operator=.
5563         <what>: New method.
5564         (struct gdb_exception_RETURN_MASK_ALL)
5565         (struct gdb_exception_RETURN_MASK_ERROR)
5566         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5567         (struct gdb_quit_bad_alloc): Update.
5568         * common/common-exceptions.c (exception_none): Change
5569         initializer.
5570         (struct catcher) <state, exception>: Initialize inline.
5571         <prev>: Remove member.
5572         (current_catcher): Remove.
5573         (catchers): New global.
5574         (exceptions_state_mc_init): Simplify.
5575         (catcher_pop): Remove.
5576         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5577         (try_scope_depth, exception_try_scope_entry)
5578         (exception_try_scope_exit): Remove.
5579         (throw_exception_sjlj): Update.
5580         (exception_messages, exception_messages_size): Remove.
5581         (throw_it): Simplify.
5582         (gdb_exception_sliced_copy): Remove.
5583         (throw_exception_cxx): Update.
5584         * cli/cli-script.c (script_from_file): Update.
5585         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5586         Update.
5587         * ada-valprint.c (ada_val_print): Update.
5588         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5589         (create_excep_cond_exprs): Update.
5590
5591 2019-04-08  Tom Tromey  <tom@tromey.com>
5592
5593         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5594         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5595         (TRY, CATCH, END_CATCH): Remove some definitions.
5596         * common/common-exceptions.c: Don't use GDB_XCPT.
5597         (catcher_list_size): Remove.
5598         (throw_exception, throw_it): Simplify.
5599
5600 2019-04-05  Tom Tromey  <tom@tromey.com>
5601
5602         Revert the header-sorting patch.
5603         * ft32-tdep.c: Revert.
5604         * frv-tdep.c: Revert.
5605         * frv-linux-tdep.c: Revert.
5606         * frame.c: Revert.
5607         * frame-unwind.c: Revert.
5608         * frame-base.c: Revert.
5609         * fork-child.c: Revert.
5610         * findvar.c: Revert.
5611         * findcmd.c: Revert.
5612         * filesystem.c: Revert.
5613         * filename-seen-cache.h: Revert.
5614         * filename-seen-cache.c: Revert.
5615         * fbsd-tdep.c: Revert.
5616         * fbsd-nat.h: Revert.
5617         * fbsd-nat.c: Revert.
5618         * f-valprint.c: Revert.
5619         * f-typeprint.c: Revert.
5620         * f-lang.c: Revert.
5621         * extension.h: Revert.
5622         * extension.c: Revert.
5623         * extension-priv.h: Revert.
5624         * expprint.c: Revert.
5625         * exec.h: Revert.
5626         * exec.c: Revert.
5627         * exceptions.c: Revert.
5628         * event-top.c: Revert.
5629         * event-loop.c: Revert.
5630         * eval.c: Revert.
5631         * elfread.c: Revert.
5632         * dwarf2read.h: Revert.
5633         * dwarf2read.c: Revert.
5634         * dwarf2loc.c: Revert.
5635         * dwarf2expr.h: Revert.
5636         * dwarf2expr.c: Revert.
5637         * dwarf2-frame.c: Revert.
5638         * dwarf2-frame-tailcall.c: Revert.
5639         * dwarf-index-write.h: Revert.
5640         * dwarf-index-write.c: Revert.
5641         * dwarf-index-common.c: Revert.
5642         * dwarf-index-cache.h: Revert.
5643         * dwarf-index-cache.c: Revert.
5644         * dummy-frame.c: Revert.
5645         * dtrace-probe.c: Revert.
5646         * disasm.h: Revert.
5647         * disasm.c: Revert.
5648         * disasm-selftests.c: Revert.
5649         * dictionary.c: Revert.
5650         * dicos-tdep.c: Revert.
5651         * demangle.c: Revert.
5652         * dcache.h: Revert.
5653         * dcache.c: Revert.
5654         * darwin-nat.h: Revert.
5655         * darwin-nat.c: Revert.
5656         * darwin-nat-info.c: Revert.
5657         * d-valprint.c: Revert.
5658         * d-namespace.c: Revert.
5659         * d-lang.c: Revert.
5660         * ctf.c: Revert.
5661         * csky-tdep.c: Revert.
5662         * csky-linux-tdep.c: Revert.
5663         * cris-tdep.c: Revert.
5664         * cris-linux-tdep.c: Revert.
5665         * cp-valprint.c: Revert.
5666         * cp-support.c: Revert.
5667         * cp-namespace.c: Revert.
5668         * cp-abi.c: Revert.
5669         * corelow.c: Revert.
5670         * corefile.c: Revert.
5671         * continuations.c: Revert.
5672         * completer.h: Revert.
5673         * completer.c: Revert.
5674         * complaints.c: Revert.
5675         * coffread.c: Revert.
5676         * coff-pe-read.c: Revert.
5677         * cli-out.h: Revert.
5678         * cli-out.c: Revert.
5679         * charset.c: Revert.
5680         * c-varobj.c: Revert.
5681         * c-valprint.c: Revert.
5682         * c-typeprint.c: Revert.
5683         * c-lang.c: Revert.
5684         * buildsym.c: Revert.
5685         * buildsym-legacy.c: Revert.
5686         * build-id.h: Revert.
5687         * build-id.c: Revert.
5688         * btrace.c: Revert.
5689         * bsd-uthread.c: Revert.
5690         * breakpoint.h: Revert.
5691         * breakpoint.c: Revert.
5692         * break-catch-throw.c: Revert.
5693         * break-catch-syscall.c: Revert.
5694         * break-catch-sig.c: Revert.
5695         * blockframe.c: Revert.
5696         * block.c: Revert.
5697         * bfin-tdep.c: Revert.
5698         * bfin-linux-tdep.c: Revert.
5699         * bfd-target.c: Revert.
5700         * bcache.c: Revert.
5701         * ax-general.c: Revert.
5702         * ax-gdb.h: Revert.
5703         * ax-gdb.c: Revert.
5704         * avr-tdep.c: Revert.
5705         * auxv.c: Revert.
5706         * auto-load.c: Revert.
5707         * arm-wince-tdep.c: Revert.
5708         * arm-tdep.c: Revert.
5709         * arm-symbian-tdep.c: Revert.
5710         * arm-pikeos-tdep.c: Revert.
5711         * arm-obsd-tdep.c: Revert.
5712         * arm-nbsd-tdep.c: Revert.
5713         * arm-nbsd-nat.c: Revert.
5714         * arm-linux-tdep.c: Revert.
5715         * arm-linux-nat.c: Revert.
5716         * arm-fbsd-tdep.c: Revert.
5717         * arm-fbsd-nat.c: Revert.
5718         * arm-bsd-tdep.c: Revert.
5719         * arch-utils.c: Revert.
5720         * arc-tdep.c: Revert.
5721         * arc-newlib-tdep.c: Revert.
5722         * annotate.h: Revert.
5723         * annotate.c: Revert.
5724         * amd64-windows-tdep.c: Revert.
5725         * amd64-windows-nat.c: Revert.
5726         * amd64-tdep.c: Revert.
5727         * amd64-sol2-tdep.c: Revert.
5728         * amd64-obsd-tdep.c: Revert.
5729         * amd64-obsd-nat.c: Revert.
5730         * amd64-nbsd-tdep.c: Revert.
5731         * amd64-nbsd-nat.c: Revert.
5732         * amd64-nat.c: Revert.
5733         * amd64-linux-tdep.c: Revert.
5734         * amd64-linux-nat.c: Revert.
5735         * amd64-fbsd-tdep.c: Revert.
5736         * amd64-fbsd-nat.c: Revert.
5737         * amd64-dicos-tdep.c: Revert.
5738         * amd64-darwin-tdep.c: Revert.
5739         * amd64-bsd-nat.c: Revert.
5740         * alpha-tdep.c: Revert.
5741         * alpha-obsd-tdep.c: Revert.
5742         * alpha-nbsd-tdep.c: Revert.
5743         * alpha-mdebug-tdep.c: Revert.
5744         * alpha-linux-tdep.c: Revert.
5745         * alpha-linux-nat.c: Revert.
5746         * alpha-bsd-tdep.c: Revert.
5747         * alpha-bsd-nat.c: Revert.
5748         * aix-thread.c: Revert.
5749         * agent.c: Revert.
5750         * addrmap.c: Revert.
5751         * ada-varobj.c: Revert.
5752         * ada-valprint.c: Revert.
5753         * ada-typeprint.c: Revert.
5754         * ada-tasks.c: Revert.
5755         * ada-lang.c: Revert.
5756         * aarch64-tdep.c: Revert.
5757         * aarch64-ravenscar-thread.c: Revert.
5758         * aarch64-newlib-tdep.c: Revert.
5759         * aarch64-linux-tdep.c: Revert.
5760         * aarch64-linux-nat.c: Revert.
5761         * aarch64-fbsd-tdep.c: Revert.
5762         * aarch64-fbsd-nat.c: Revert.
5763         * aarch32-linux-nat.c: Revert.
5764
5765 2019-04-05  Tom Tromey  <tom@tromey.com>
5766
5767         * ft32-tdep.c: Sort headers.
5768         * frv-tdep.c: Sort headers.
5769         * frv-linux-tdep.c: Sort headers.
5770         * frame.c: Sort headers.
5771         * frame-unwind.c: Sort headers.
5772         * frame-base.c: Sort headers.
5773         * fork-child.c: Sort headers.
5774         * findvar.c: Sort headers.
5775         * findcmd.c: Sort headers.
5776         * filesystem.c: Sort headers.
5777         * filename-seen-cache.h: Sort headers.
5778         * filename-seen-cache.c: Sort headers.
5779         * fbsd-tdep.c: Sort headers.
5780         * fbsd-nat.h: Sort headers.
5781         * fbsd-nat.c: Sort headers.
5782         * f-valprint.c: Sort headers.
5783         * f-typeprint.c: Sort headers.
5784         * f-lang.c: Sort headers.
5785         * extension.h: Sort headers.
5786         * extension.c: Sort headers.
5787         * extension-priv.h: Sort headers.
5788         * expprint.c: Sort headers.
5789         * exec.h: Sort headers.
5790         * exec.c: Sort headers.
5791         * exceptions.c: Sort headers.
5792         * event-top.c: Sort headers.
5793         * event-loop.c: Sort headers.
5794         * eval.c: Sort headers.
5795         * elfread.c: Sort headers.
5796         * dwarf2read.h: Sort headers.
5797         * dwarf2read.c: Sort headers.
5798         * dwarf2loc.c: Sort headers.
5799         * dwarf2expr.h: Sort headers.
5800         * dwarf2expr.c: Sort headers.
5801         * dwarf2-frame.c: Sort headers.
5802         * dwarf2-frame-tailcall.c: Sort headers.
5803         * dwarf-index-write.h: Sort headers.
5804         * dwarf-index-write.c: Sort headers.
5805         * dwarf-index-common.c: Sort headers.
5806         * dwarf-index-cache.h: Sort headers.
5807         * dwarf-index-cache.c: Sort headers.
5808         * dummy-frame.c: Sort headers.
5809         * dtrace-probe.c: Sort headers.
5810         * disasm.h: Sort headers.
5811         * disasm.c: Sort headers.
5812         * disasm-selftests.c: Sort headers.
5813         * dictionary.c: Sort headers.
5814         * dicos-tdep.c: Sort headers.
5815         * demangle.c: Sort headers.
5816         * dcache.h: Sort headers.
5817         * dcache.c: Sort headers.
5818         * darwin-nat.h: Sort headers.
5819         * darwin-nat.c: Sort headers.
5820         * darwin-nat-info.c: Sort headers.
5821         * d-valprint.c: Sort headers.
5822         * d-namespace.c: Sort headers.
5823         * d-lang.c: Sort headers.
5824         * ctf.c: Sort headers.
5825         * csky-tdep.c: Sort headers.
5826         * csky-linux-tdep.c: Sort headers.
5827         * cris-tdep.c: Sort headers.
5828         * cris-linux-tdep.c: Sort headers.
5829         * cp-valprint.c: Sort headers.
5830         * cp-support.c: Sort headers.
5831         * cp-namespace.c: Sort headers.
5832         * cp-abi.c: Sort headers.
5833         * corelow.c: Sort headers.
5834         * corefile.c: Sort headers.
5835         * continuations.c: Sort headers.
5836         * completer.h: Sort headers.
5837         * completer.c: Sort headers.
5838         * complaints.c: Sort headers.
5839         * coffread.c: Sort headers.
5840         * coff-pe-read.c: Sort headers.
5841         * cli-out.h: Sort headers.
5842         * cli-out.c: Sort headers.
5843         * charset.c: Sort headers.
5844         * c-varobj.c: Sort headers.
5845         * c-valprint.c: Sort headers.
5846         * c-typeprint.c: Sort headers.
5847         * c-lang.c: Sort headers.
5848         * buildsym.c: Sort headers.
5849         * buildsym-legacy.c: Sort headers.
5850         * build-id.h: Sort headers.
5851         * build-id.c: Sort headers.
5852         * btrace.c: Sort headers.
5853         * bsd-uthread.c: Sort headers.
5854         * breakpoint.h: Sort headers.
5855         * breakpoint.c: Sort headers.
5856         * break-catch-throw.c: Sort headers.
5857         * break-catch-syscall.c: Sort headers.
5858         * break-catch-sig.c: Sort headers.
5859         * blockframe.c: Sort headers.
5860         * block.c: Sort headers.
5861         * bfin-tdep.c: Sort headers.
5862         * bfin-linux-tdep.c: Sort headers.
5863         * bfd-target.c: Sort headers.
5864         * bcache.c: Sort headers.
5865         * ax-general.c: Sort headers.
5866         * ax-gdb.h: Sort headers.
5867         * ax-gdb.c: Sort headers.
5868         * avr-tdep.c: Sort headers.
5869         * auxv.c: Sort headers.
5870         * auto-load.c: Sort headers.
5871         * arm-wince-tdep.c: Sort headers.
5872         * arm-tdep.c: Sort headers.
5873         * arm-symbian-tdep.c: Sort headers.
5874         * arm-pikeos-tdep.c: Sort headers.
5875         * arm-obsd-tdep.c: Sort headers.
5876         * arm-nbsd-tdep.c: Sort headers.
5877         * arm-nbsd-nat.c: Sort headers.
5878         * arm-linux-tdep.c: Sort headers.
5879         * arm-linux-nat.c: Sort headers.
5880         * arm-fbsd-tdep.c: Sort headers.
5881         * arm-fbsd-nat.c: Sort headers.
5882         * arm-bsd-tdep.c: Sort headers.
5883         * arch-utils.c: Sort headers.
5884         * arc-tdep.c: Sort headers.
5885         * arc-newlib-tdep.c: Sort headers.
5886         * annotate.h: Sort headers.
5887         * annotate.c: Sort headers.
5888         * amd64-windows-tdep.c: Sort headers.
5889         * amd64-windows-nat.c: Sort headers.
5890         * amd64-tdep.c: Sort headers.
5891         * amd64-sol2-tdep.c: Sort headers.
5892         * amd64-obsd-tdep.c: Sort headers.
5893         * amd64-obsd-nat.c: Sort headers.
5894         * amd64-nbsd-tdep.c: Sort headers.
5895         * amd64-nbsd-nat.c: Sort headers.
5896         * amd64-nat.c: Sort headers.
5897         * amd64-linux-tdep.c: Sort headers.
5898         * amd64-linux-nat.c: Sort headers.
5899         * amd64-fbsd-tdep.c: Sort headers.
5900         * amd64-fbsd-nat.c: Sort headers.
5901         * amd64-dicos-tdep.c: Sort headers.
5902         * amd64-darwin-tdep.c: Sort headers.
5903         * amd64-bsd-nat.c: Sort headers.
5904         * alpha-tdep.c: Sort headers.
5905         * alpha-obsd-tdep.c: Sort headers.
5906         * alpha-nbsd-tdep.c: Sort headers.
5907         * alpha-mdebug-tdep.c: Sort headers.
5908         * alpha-linux-tdep.c: Sort headers.
5909         * alpha-linux-nat.c: Sort headers.
5910         * alpha-bsd-tdep.c: Sort headers.
5911         * alpha-bsd-nat.c: Sort headers.
5912         * aix-thread.c: Sort headers.
5913         * agent.c: Sort headers.
5914         * addrmap.c: Sort headers.
5915         * ada-varobj.c: Sort headers.
5916         * ada-valprint.c: Sort headers.
5917         * ada-typeprint.c: Sort headers.
5918         * ada-tasks.c: Sort headers.
5919         * ada-lang.c: Sort headers.
5920         * aarch64-tdep.c: Sort headers.
5921         * aarch64-ravenscar-thread.c: Sort headers.
5922         * aarch64-newlib-tdep.c: Sort headers.
5923         * aarch64-linux-tdep.c: Sort headers.
5924         * aarch64-linux-nat.c: Sort headers.
5925         * aarch64-fbsd-tdep.c: Sort headers.
5926         * aarch64-fbsd-nat.c: Sort headers.
5927         * aarch32-linux-nat.c: Sort headers.
5928
5929 2019-04-04  Tom Tromey  <tom@tromey.com>
5930
5931         * varobj.c (varobj_create): Update.
5932         * rust-exp.y (struct rust_parser) <update_innermost_block,
5933         lookup_symbol>: New methods.
5934         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5935         Rename.
5936         (rust_parser::rust_lookup_type)
5937         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5938         * printcmd.c (display_command, do_one_display): Update.
5939         * parser-defs.h (struct parser_state) <parser_state>: Add
5940         "tracker" parameter.
5941         (block_tracker): New member.
5942         (class innermost_block_tracker) <innermost_block_tracker>: Add
5943         "types" parameter.
5944         <reset>: Remove method.
5945         (innermost_block): Don't declare.
5946         (null_post_parser): Update.
5947         * parse.c (innermost_block): Remove global.
5948         (write_dollar_variable): Update.
5949         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5950         Remove "tracker_types" parameter.
5951         (parse_expression): Add "tracker" parameter.
5952         (parse_expression_for_completion): Update.
5953         (null_post_parser): Add "tracker" parameter.
5954         * p-exp.y: Update rules.
5955         * m2-exp.y: Update rules.
5956         * language.h (struct language_defn) <la_post_parser>: Add
5957         "tracker" parameter.
5958         * go-exp.y: Update rules.
5959         * f-exp.y: Update rules.
5960         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5961         parameter.
5962         * d-exp.y: Update rules.
5963         * c-exp.y: Update rules.
5964         * breakpoint.c (set_breakpoint_condition): Create an
5965         innermost_block_tracker.
5966         (watch_command_1): Likewise.
5967         * ada-lang.c (resolve): Add "tracker" parameter.
5968         (resolve_subexp): Likewise.
5969         * ada-exp.y (write_var_from_sym): Update.
5970
5971 2019-04-04  Tom Tromey  <tom@tromey.com>
5972
5973         * type-stack.h: New file.
5974         * type-stack.c: New file.
5975         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5976         type-stack.h.
5977         (insert_into_type_stack, insert_type, push_type, push_type_int)
5978         (insert_type_address_space, pop_type, pop_type_int)
5979         (pop_typelist, pop_type_stack, append_type_stack)
5980         (push_type_stack, get_type_stack, push_typelist)
5981         (follow_type_instance_flags, follow_types): Don't declare.
5982         * parse.c (type_stack): Remove global.
5983         (parse_exp_in_context): Update.
5984         (insert_into_type_stack, insert_type, push_type, push_type_int)
5985         (insert_type_address_space, pop_type, pop_type_int)
5986         (pop_typelist, pop_type_stack, append_type_stack)
5987         (push_type_stack, get_type_stack, push_typelist)
5988         (follow_type_instance_flags, follow_types): Remove (moved to
5989         type-stack.c).
5990         * f-exp.y (type_stack): New global.
5991         Update rules.
5992         (push_kind_type, f_parse): Update.
5993         * d-exp.y (type_stack): New global.
5994         Update rules.
5995         (d_parse): Update.
5996         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5997         Update rules.
5998         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5999         (HFILES_NO_SRCDIR): Add type-stack.h.
6000
6001 2019-04-04  Tom Tromey  <tom@tromey.com>
6002
6003         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6004         (rust_parser::convert_ast_to_expression, rust_parse)
6005         (rust_lex_test_completion, rust_lex_tests): Update.
6006         * parser-defs.h (struct expr_completion_state): New.
6007         (struct parser_state) <parser_state>: Add completion parameter.
6008         <mark_struct_expression, mark_completion_tag>: New methods.
6009         <parse_completion, m_completion_state>: New members.
6010         (prefixify_expression, null_post_parser): Update.
6011         (mark_struct_expression, mark_completion_tag): Don't declare.
6012         * parse.c (parse_completion, expout_last_struct)
6013         (expout_tag_completion_type, expout_completion_name): Remove
6014         globals.
6015         (parser_state::mark_struct_expression)
6016         (parser_state::mark_completion_tag): Now methods.
6017         (prefixify_expression): Add last_struct parameter.
6018         (prefixify_subexp): Likewise.
6019         (parse_exp_1): Update.
6020         (parse_exp_in_context): Add cstate parameter.  Update.
6021         (parse_expression_for_completion): Create an
6022         expr_completion_state.
6023         (null_post_parser): Add "completion" parameter.
6024         * p-exp.y: Update rules.
6025         (yylex): Update.
6026         * language.h (struct language_defn) <la_post_parser>: Add
6027         "completing" parameter.
6028         * go-exp.y: Update rules.
6029         (lex_one_token): Update.
6030         * expression.h (parse_completion): Don't declare.
6031         * d-exp.y: Update rules.
6032         (lex_one_token): Update rules.
6033         * c-exp.y: Update rules.
6034         (lex_one_token): Update.
6035         * ada-lang.c (resolve): Add "parse_completion" parameter.
6036         (resolve_subexp): Likewise.
6037         (ada_resolve_function): Likewise.
6038
6039 2019-04-04  Tom Tromey  <tom@tromey.com>
6040
6041         * parser-defs.h (struct parser_state) <start_arglist,
6042         end_arglist>: New methods.
6043         <arglist_len, m_funcall_chain>: New members.
6044         (arglist_len, start_arglist, end_arglist): Don't declare.
6045         * parse.c (arglist_len, funcall_chain): Remove global.
6046         (start_arglist, end_arglist): Remove functions.
6047         (parse_exp_in_context): Update.
6048         * p-exp.y: Update rules.
6049         * m2-exp.y: Update rules.
6050         * go-exp.y: Update rules.
6051         * f-exp.y: Update rules.
6052         * d-exp.y: Update rules.
6053         * c-exp.y: Update rules.
6054
6055 2019-04-04  Tom Tromey  <tom@tromey.com>
6056
6057         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6058         lex_operator, push_back>: New methods.
6059         Update all rules.
6060         (rust_parser::lex_hex, lex_escape): Rename and update.
6061         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6062         (rust_parser::lex_operator): Rename and update.
6063         (rust_parser::lex_number, rustyylex, rustyyerror)
6064         (rust_lex_test_init, rust_lex_test_sequence)
6065         (rust_lex_test_push_back, rust_lex_tests): Update.
6066         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6067         parameter.
6068         <lexptr, prev_lexptr>: New members.
6069         (lexptr, prev_lexptr): Don't declare.
6070         * parse.c (lexptr, prev_lexptr): Remove globals.
6071         (parse_exp_in_context): Update.
6072         * p-exp.y (yylex, yyerror): Update.
6073         * m2-exp.y (parse_number, yylex, yyerror): Update.
6074         * go-exp.y (lex_one_token, yyerror): Update.
6075         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6076         * d-exp.y (lex_one_token, yyerror): Update.
6077         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6078         (lex_one_token, yyerror): Update.
6079         * ada-lex.l (YY_INPUT): Update.
6080         (rewind_to_char): Update.
6081         * ada-exp.y (yyerror): Update.
6082
6083 2019-04-04  Tom Tromey  <tom@tromey.com>
6084
6085         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6086         * parser-defs.h (struct parser_state) <parser_state>: Add new
6087         parameter.
6088         <comma_terminates>: New member.
6089         (comma_terminates): Don't declare global.
6090         * parse.c (comma_terminates): Remove global.
6091         (parse_exp_in_context): Update.
6092         * p-exp.y (yylex): Update.
6093         * m2-exp.y (yylex): Update.
6094         * go-exp.y (lex_one_token): Update.
6095         * f-exp.y (yylex): Update.
6096         * d-exp.y (lex_one_token): Update.
6097         * c-exp.y (lex_one_token): Update.
6098         * ada-lex.l: Update.
6099
6100 2019-04-04  Tom Tromey  <tom@tromey.com>
6101
6102         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6103         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6104         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6105         * parser-defs.h (paren_depth): Don't declare.
6106         * parse.c (paren_depth): Remove global.
6107         (parse_exp_in_context): Update.
6108         * p-exp.y (paren_depth): New global.
6109         (pascal_parse): Initialize it.
6110         * m2-exp.y (paren_depth): New global.
6111         (m2_parse): Initialize it.
6112         * go-exp.y (paren_depth): New global.
6113         (go_parse): Initialize it.
6114         * f-exp.y (paren_depth): New global.
6115         (f_parse): Initialize it.
6116         * d-exp.y (paren_depth): New global.
6117         (d_parse): Initialize it.
6118         * c-exp.y (paren_depth): New global.
6119         (c_parse): Initialize it.
6120         * ada-lex.l (paren_depth): New global.
6121         (lexer_init): Initialize it.
6122
6123 2019-04-04  Tom Tromey  <tom@tromey.com>
6124
6125         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6126         (rust_parser::convert_ast_to_type)
6127         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6128         * parser-defs.h (struct parser_state) <parser_state>: Add
6129         parameters.  Initialize new members.
6130         <expression_context_block, expression_context_pc>: New members.
6131         * parse.c (expression_context_block, expression_context_pc):
6132         Remove globals.
6133         (parse_exp_in_context): Update.
6134         * p-exp.y: Update all rules.
6135         (yylex): Update.
6136         * m2-exp.y: Update all rules.
6137         (yylex): Update.
6138         * go-exp.y (yylex): Update.
6139         * f-exp.y (yylex): Update.
6140         * d-exp.y: Update all rules.
6141         (yylex): Update.
6142         * c-exp.y: Update all rules.
6143         (lex_one_token, classify_name, yylex, c_parse): Update.
6144         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6145
6146 2019-04-04  Tom Tromey  <tom@tromey.com>
6147
6148         * gdbarch.h, gdbarch.c: Rebuild.
6149         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6150         * stap-probe.h:
6151         (struct stap_parse_info): Replace "parser_state" with
6152         "expr_builder".
6153         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6154         (parser_state): New class.
6155         * parse.c (expr_builder): Rename.
6156         (expr_builder::release): Rename.
6157         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6158         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6159         (write_exp_elt_longcst, write_exp_elt_floatcst)
6160         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6161         (write_exp_string_vector, write_exp_bitstring)
6162         (write_exp_msymbol, mark_struct_expression)
6163         (write_dollar_variable)
6164         (insert_type_address_space, increase_expout_size): Replace
6165         "parser_state" with "expr_builder".
6166         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6167         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6168         "parser_state" with "expr_builder".
6169
6170 2019-04-04  Tom Tromey  <tom@tromey.com>
6171
6172         * rust-exp.y: Replace "parse_language" with method call.
6173         * p-exp.y:
6174         (yylex): Replace "parse_language" with method call.
6175         * m2-exp.y:
6176         (yylex): Replace "parse_language" with method call.
6177         * go-exp.y (classify_name): Replace "parse_language" with method
6178         call.
6179         * f-exp.y (yylex): Replace "parse_language" with method call.
6180         * d-exp.y (lex_one_token): Replace "parse_language" with method
6181         call.
6182         * c-exp.y:
6183         (lex_one_token, classify_name, yylex): Replace "parse_language"
6184         with method call.
6185         * ada-exp.y (find_primitive_type, type_char)
6186         (type_system_address): Replace "parse_language" with method call.
6187
6188 2019-04-04  Tom Tromey  <tom@tromey.com>
6189
6190         * rust-exp.y: Replace "parse_gdbarch" with method call.
6191         * parse.c (write_dollar_variable, insert_type_address_space):
6192         Replace "parse_gdbarch" with method call.
6193         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6194         call.
6195         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6196         call.
6197         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6198         "parse_gdbarch" with method call.
6199         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6200         with method call.
6201         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6202         "parse_gdbarch" with method call.
6203         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6204         "parse_gdbarch" with method call.
6205         * c-exp.y (parse_type, parse_number, classify_name): Replace
6206         "parse_gdbarch" with method call.
6207         * ada-lex.l: Replace "parse_gdbarch" with method call.
6208         * ada-exp.y (parse_type, find_primitive_type, type_char)
6209         (type_system_address): Replace "parse_gdbarch" with method call.
6210
6211 2019-04-04  Tom Tromey  <tom@tromey.com>
6212
6213         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6214         * stap-probe.c (stap_parse_argument): Update.
6215         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6216         initial_size parameter.
6217         * rust-exp.y (rust_lex_tests): Update.
6218         * parse.c (parser_state): Update.
6219         (parse_exp_in_context): Update.
6220         * parser-defs.h (struct parser_state) <parser_state>: Remove
6221         "initial_size" parameter.
6222
6223 2019-04-04  Tom Tromey  <tom@tromey.com>
6224
6225         * parser-defs.h (increase_expout_size): Don't declare.
6226         * parse.c (increase_expout_size): Now static.
6227
6228 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6229
6230         * gnu-nat.c (gnu_nat_target::wait): Fix
6231         target_waitstatus_to_string call.
6232
6233 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * eval.c (evaluate_subexp_standard): Handle internal functions
6236         during Fortran function call handling.
6237
6238 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * NEWS: Mention new internal functions.
6241         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6242         (read_base_type): Use dwarf2_init_complex_target_type.
6243         * value.c (creal_internal_fn): New function.
6244         (cimag_internal_fn): New function.
6245         (_initialize_values): Register new internal functions.
6246
6247 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6248
6249         * infrun.c (stop_all_threads): If debug_infrun, always
6250         trace the wait status after wait_one, using
6251         target_waitstatus_to_string and target_pid_to_str.
6252         (handle_inferior_event): Replace various trace of
6253         wait status kind by a single trace.
6254         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6255         wait status kind image by target_waitstatus_to_string.
6256         * target/waitstatus.c (target_waitstatus_to_string): Fix
6257         obsolete comment.
6258
6259 2019-04-01  Tom Tromey  <tromey@adacore.com>
6260
6261         PR symtab/23331:
6262         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6263
6264 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6265             Pedro Alves  <palves@redhat.com>
6266
6267         * top.c (quit_force): Call 'finalize_values'.
6268         * value.c (finalize_values): New function.
6269         * value.h (finalize_values): Declare.
6270
6271 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6272
6273         * NEWS: Announce $_gdb_major and $_gdb_minor.
6274
6275         * top.c (init_gdb_version_vars): New function.
6276         (gdb_init): Call init_gdb_version_vars.
6277
6278 2019-03-29  Tom Tromey  <tromey@adacore.com>
6279
6280         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6281         help text.  Remove dead code.
6282
6283 2019-03-29  Keith Seitz  <keiths@redhat.com>
6284
6285         From Siddhesh Poyarekar:
6286         * f-lang.h (f77_get_upperbound): Return LONGEST.
6287         (f77_get_lowerbound): Likewise.
6288         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6289         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6290         print them.
6291         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6292         plongest to format print it.
6293         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6294         (f77_get_upperbound): Likewise.
6295         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6296         LOWER_BOUND to LONGEST.
6297         (f77_create_arrayprint_offset_tbl): Likewise.
6298
6299 2019-03-29  Keith Seitz  <keiths@redhat.com>
6300
6301         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6302         %s/pulongest for TYPE_LENGTH instead of %d in format
6303         strings.
6304         * ada-typerint.c (ada_print_type): Likewise.
6305         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6306         * compile/compile-c-support.c (generate_register_struct): Likewise.
6307         * gdbtypes.c (recursive_dump_type): Likewise.
6308         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6309         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6310         instead of %d in format strings.
6311         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6312         to std::min to ULONGEST.
6313         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6314         instead of %d in format strings.
6315         * tracepoint.c (info_scope_command): Likewise.
6316         * typeprint.c (print_offset_data::update)
6317         (print_offset_data::finish): Likewise.
6318         * xtensa-tdep.c (xtensa_store_return_value)
6319         (xtensa_push_dummy_call): Likewise.
6320
6321 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6322
6323         * windows-nat.c (display_selector): Fixed format specifications
6324         for 64-bit Cygwin.
6325
6326 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6327
6328         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6329
6330 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6331
6332         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6333         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6334         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6335         (nios2_linux_init_abi): Install it.
6336
6337 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6338
6339         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6340
6341 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6342
6343         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6344
6345 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6346             Tom Tromey  <tromey@adacore.com>
6347
6348         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6349
6350 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6351
6352         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6353         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6354         method to compute the bounds of range types. Also print "[evaluated]"
6355         if the bounds' values come from a dynamic evaluation.
6356
6357 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6360         whitespace when pretty printing is on.
6361
6362 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6363
6364         * ppc-linux-nat.c: Add include.
6365
6366 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6367
6368         * NEWS: Mention AArch64 Pointer Authentication.
6369
6370 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6371
6372         * arm-linux-nat.c: Add include.
6373
6374 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6375
6376         * source-cache.c (source_cache::get_source_lines): Re-read
6377         fullname after calling open_source_file.
6378
6379 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6380
6381         * NEWS: Mention TLS support for FreeBSD.
6382
6383 2019-03-25  Tom Tromey  <tromey@adacore.com>
6384
6385         * minsyms.c (BUNCH_SIZE): Update comment.
6386         (~minimal_symbol_reader): Remove old comment.
6387         (compact_minimal_symbols): Update comment.
6388         (minimal_symbol_reader::install): Remove old comment.  Update
6389         other comments.
6390
6391 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6392
6393         * s390-linux-nat.c: Add include.
6394
6395 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6396
6397         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6398         Call linux_get_hwcap.
6399         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6400         Likewise.
6401         (aarch64_linux_get_hwcap): Remove function.
6402         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6403         declaration.
6404         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6405         linux_get_hwcap.
6406         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6407         * linux-tdep.c (linux_get_hwcap): Add function.
6408         (linux_get_hwcap2): Likewise.
6409         * linux-tdep.h (linux_get_hwcap): Add declaration.
6410         (linux_get_hwcap2): Likewise.
6411         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6412         (ppc_linux_get_hwcap2): Likewise.
6413         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6414         linux_get_hwcap.
6415         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6416         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6417         (ppc_linux_nat_target::read_description): Likewise.
6418         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6419         * s390-linux-nat.c: Likewise.
6420         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6421
6422 2019-03-24  Tom Tromey  <tom@tromey.com>
6423
6424         * ada-lang.c (standard_lookup): Simplify initialization.
6425         (ada_lookup_symbol_nonlocal): Simplify return.
6426         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6427         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6428         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6429         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6430         initialization.
6431         * solib.c (solib_global_lookup): Simplify.
6432         * symtab.c (null_block_symbol): Remove.
6433         (symbol_cache_lookup): Simplify returns.
6434         (lookup_language_this): Simplify returns.
6435         (lookup_symbol_aux): Simplify return.
6436         (lookup_local_symbol): Simplify returns.
6437         (lookup_global_symbol_from_objfile): Simplify return.
6438         (lookup_symbol_in_objfile_symtabs)
6439         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6440         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6441         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6442         * cp-namespace.c (cp_lookup_bare_symbol)
6443         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6444         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6445         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6446         (cp_lookup_symbol_via_imports): Simplify initialization.
6447         (find_symbol_in_baseclass): Likewise.
6448         * symtab.h (null_block_symbol): Remove.
6449         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6450         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6451         (d_lookup_symbol_module): Likewise.
6452         (find_symbol_in_baseclass): Simplify initialization.
6453
6454 2019-03-24  Tom Tromey  <tom@tromey.com>
6455
6456         * expression.h: Don't include symtab.h.
6457         (struct block): Forward declare.
6458
6459 2019-03-24  Tom Tromey  <tom@tromey.com>
6460
6461         * c-exp.y (typebase): Remove casts.
6462         * gdbtypes.c (lookup_unsigned_typename, )
6463         (lookup_signed_typename): Remove cast.
6464         * eval.c (parse_to_comma_and_eval): Remove cast.
6465         * parse.c (write_dollar_variable): Remove cast.
6466         * block.h (struct block) <superblock>: Now const.
6467         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6468         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6469         (map_block): Make "block" const.
6470         * symfile.h (struct quick_symbol_functions)
6471         <map_matching_symbols>: Constify block argument to "callback".
6472         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6473         const.
6474         (find_pc_sect_compunit_symtab): Make "b" const.
6475         (find_symbol_at_address): Likewise.
6476         (search_symbols): Likewise.
6477         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6478         (dw2_debug_names_lookup_symbol): Likewise.
6479         (dw2_map_matching_symbols): Update.
6480         * p-valprint.c (pascal_val_print): Remove "block".
6481         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6482         (aux_add_nonlocal_symbols): Make "block" const.
6483         (resolve_subexp): Remove cast.
6484         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6485         const.
6486         (iterate_over_file_blocks): Likewise.
6487         * f-exp.y (%union) <bval>: Remove.
6488         * coffread.c (patch_opaque_types): Make "b" const.
6489         * spu-tdep.c (spu_catch_start): Make "block" const.
6490         * c-valprint.c (print_unpacked_pointer): Remove "block".
6491         * symmisc.c (dump_symtab_1): Make "b" const.
6492         (block_depth): Make "block" const.
6493         * d-exp.y (%union) <bval>: Remove.
6494         * cp-support.h (cp_lookup_rtti_type): Update.
6495         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6496         * psymtab.c (psym_lookup_symbol): Make "block" const.
6497         (maintenance_check_psymtabs): Make "b" const.
6498         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6499         (enumerate_locals, enumerate_args): Update.
6500         * python/py-symtab.c (stpy_global_block): Make "block" const.
6501         (stpy_static_block): Likewise.
6502         * inline-frame.c (block_starting_point_at): Make "new_block"
6503         const.
6504         * block.c (find_block_in_blockvector): Make return type const.
6505         (blockvector_for_pc_sect): Make "b" const.
6506         (find_block_in_blockvector): Make "b" const.
6507
6508 2019-03-23  Tom Tromey  <tom@tromey.com>
6509
6510         * varobj.c (varobj_create): Update.
6511         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6512         * printcmd.c (display_command, do_one_display): Don't reset
6513         innermost_block.
6514         * parser-defs.h (enum innermost_block_tracker_type): Move to
6515         expression.h.
6516         (innermost_block): Update comment.
6517         * parse.c (parse_exp_1): Add tracker_types parameter.
6518         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6519         tracker_types parameter.  Reset innermost_block.
6520         (parse_exp_in_context): Remove.
6521         (parse_expression_for_completion): Update.
6522         * objfiles.c (~objfile): Don't reset expression_context_block or
6523         innermost_block.
6524         * expression.h (enum innermost_block_tracker_type): Move from
6525         parser-defs.h.
6526         (parse_exp_1): Add tracker_types parameter.
6527         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6528         reset innermost_block.
6529
6530 2019-03-23  Tom Tromey  <tom@tromey.com>
6531
6532         * objfiles.h: Include bcache.h.
6533
6534 2019-03-23  Tom Tromey  <tom@tromey.com>
6535
6536         * linespec.c (get_current_search_block): Use
6537         scoped_restore_current_language.
6538         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6539
6540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6541             Jiong Wang  <jiong.wang@arm.com>
6542
6543         * aarch64-linux-tdep.c
6544         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6545         section.
6546         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6547
6548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6549             Jiong Wang  <jiong.wang@arm.com>
6550
6551         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6552         instructions.
6553         (aarch64_analyze_prologue_test): Add PACIASP test.
6554         (aarch64_prologue_prev_register): Unmask PC value.
6555
6556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6557             Jiong Wang  <jiong.wang@arm.com>
6558
6559         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6560         (aarch64_dwarf2_prev_register): Unmask PC value.
6561         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6562         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6563         DW_CFA_AARCH64_negate_ra_state.
6564         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6565
6566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6567             Jiong Wang  <jiong.wang@arm.com>
6568
6569         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6570         registers.
6571         (aarch64_pseudo_register_name): Likewise.
6572         (aarch64_pseudo_register_type): Likewise.
6573         (aarch64_pseudo_register_reggroup_p): Likewise.
6574         (aarch64_gdbarch_init): Add pauth registers.
6575         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6576         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6577         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6578         (struct gdbarch_tdep): Add regnum for ra_state.
6579
6580 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6581             Jiong Wang  <jiong.wang@arm.com>
6582
6583         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6584
6585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6586             Jiong Wang  <jiong.wang@arm.com>
6587
6588         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6589         function.
6590         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6591         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6592         (aarch64_gdbarch_init): Add puth registers.
6593         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6594         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6595         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6596
6597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6598             Jiong Wang  <jiong.wang@arm.com>
6599
6600         * aarch64-linux-nat.c
6601         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6602         * aarch64-linux-tdep.c
6603         (aarch64_linux_core_read_description): Likewise.
6604         (aarch64_linux_get_hwcap): New function.
6605         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6606         (aarch64_linux_get_hwcap): New declaration.
6607
6608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6609             Jiong Wang  <jiong.wang@arm.com>
6610
6611         * aarch64-linux-nat.c
6612         (aarch64_linux_nat_target::read_description): Add pauth param.
6613         * aarch64-linux-tdep.c
6614         (aarch64_linux_core_read_description): Likewise.
6615         * aarch64-tdep.c (struct target_desc): Add in pauth.
6616         (aarch64_read_description): Add pauth param.
6617         (aarch64_gdbarch_init): Likewise.
6618         * aarch64-tdep.h (aarch64_read_description): Likewise.
6619         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6620         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6621         * features/Makefile: Add new files.
6622         * features/aarch64-pauth.c: New file.
6623         * features/aarch64-pauth.xml: New file.
6624
6625 2019-03-20  Tom Tromey  <tromey@adacore.com>
6626
6627         * infrun.c (handle_inferior_event): Rename from
6628         handle_inferior_event_1.  Create a scoped_value_mark.
6629         (handle_inferior_event): Remove.
6630
6631 2019-03-19  Tom Tromey  <tromey@adacore.com>
6632
6633         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6634         * infrun.h (print_stop_event): Add "displays" parameter.
6635         * infrun.c (print_stop_event): Add "displays" parameter.
6636
6637 2019-03-19  Pedro Alves  <palves@redhat.com>
6638
6639         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6640         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6641         to -1.  Fix TABs vs spaces.
6642         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6643         * tui/tui-out.h (tui_ui_out) Add intro comments.
6644         <m_line, m_start_of_line>: In-class initialize, and add describing
6645         comment.
6646
6647 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6648
6649         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6650         variable names.
6651         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6652
6653 2019-03-18  Pedro Alves  <palves@redhat.com>
6654             Eli Zaretskii <eliz@gnu.org>
6655
6656         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6657         m_line and m_start_of_line.
6658
6659 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6660
6661         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6662         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6663         it returns a newline.  This fixes a regression in TU mode, whereby
6664         the next line is output on the same screen line as the user input.
6665
6666 2019-03-18  Tom Tromey  <tromey@adacore.com>
6667
6668         * minsyms.c (minimal_symbol_reader::install): Remove call to
6669         obstack_blank.
6670
6671 2019-03-18  Pedro Alves  <palves@redhat.com>
6672
6673         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6674         New globals.
6675         (apply_style): New, factored out from ...
6676         (apply_ansi_escape): ... this.  Handle reverse video mode.
6677         (tui_set_reverse_mode): New function.
6678         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6679         * tui/tui-winsource.c (tui_show_source_line): Use
6680         tui_set_reverse_mode instead of setting A_STANDOUT.
6681         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6682         New setter methods.
6683
6684 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6685
6686         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6687         Handle tabs.
6688
6689 2019-03-18  Tom Tromey  <tromey@adacore.com>
6690
6691         * ada-lang.c (empty_array): Add "high" parameter.
6692         (ada_evaluate_subexp): Update.
6693
6694 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6695
6696         * unittests/string_view-selftests.c: Define
6697         _initialize_string_view_selftests unconditionally.
6698
6699 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6700
6701         PR gdb/24350
6702         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6703
6704 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6705
6706         PR gdb/24351
6707         * windows-nat.c (display_selector): Fix format specifiers.
6708
6709 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6710
6711         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6712         tui_refill_source_window instead of tui_refresh_win, to update the
6713         current execution line.  This fixes redisplay of the current line
6714         when stepping through the code with "next" or "step".
6715
6716 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6717
6718         * source-cache.c (source_cache::get_source_lines): Call
6719         find_source_lines to initialize s->nlines.  This fixes vertical
6720         scrolling of TUI source window when the DOWN arrow is pressed.
6721
6722 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6723
6724         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6725         linux-thread-db.c (_initialize_thread_db): Likewise.
6726
6727 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6728
6729         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6730         wclrtoeol in tui_show_source_line".  This reverts changes made in
6731         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6732
6733 2019-03-15  Tom Tromey  <tom@tromey.com>
6734
6735         * symtab.h (struct minimal_symbol): Derive from
6736         general_symbol_info.
6737         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6738         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6739         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6740         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6741         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6742         (MSYMBOL_SEARCH_NAME): Update.
6743         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6744         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6745         * minsyms.c (minimal_symbol_reader::record_full): Update.
6746
6747 2019-03-15  Tom Tromey  <tom@tromey.com>
6748
6749         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6750
6751 2019-03-15  Tom Tromey  <tom@tromey.com>
6752
6753         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6754         unique_xmalloc_ptr.
6755         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6756         Update.
6757         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6758         (build_minimal_symbol_hash_tables)
6759         (minimal_symbol_reader::install): Update.
6760
6761 2019-03-15  Tom Tromey  <tom@tromey.com>
6762
6763         * symtab.c (create_demangled_names_hash): Update.
6764         (symbol_set_names): Update.
6765         * objfiles.h (struct objfile_per_bfd_storage)
6766         <demangled_names_hash>: Now an htab_up.
6767         * objfiles.c (objfile_per_bfd_storage): Simplify.
6768
6769 2019-03-15  Tom Tromey  <tom@tromey.com>
6770
6771         * objfiles.h (struct objfile_per_bfd_storage): Declare
6772         destructor.
6773         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6774         New.
6775         (get_objfile_bfd_data): Use new.  Don't initialize
6776         language_of_main.
6777         (free_objfile_per_bfd_storage): Remove.
6778         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6779
6780 2019-03-15  Tom Tromey  <tom@tromey.com>
6781
6782         * symfile.c (reread_symbols): Update.
6783         * objfiles.c (objfile::objfile): Update.
6784         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6785         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6786         comment.
6787         (minimal_symbol_reader::install): Update.
6788         (terminate_minimal_symbol_table): Remove.
6789         * jit.c (jit_object_close_impl): Update.
6790
6791 2019-03-15  Tom Tromey  <tom@tromey.com>
6792
6793         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6794         initializations.
6795
6796 2019-03-15  Tom Tromey  <tom@tromey.com>
6797
6798         * objfiles.h (struct objfile_per_bfd_storage)
6799         <demangled_hash_languages>: Now a bitset.
6800         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6801         (lookup_minimal_symbol): Update.
6802
6803 2019-03-15  Tom Tromey  <tom@tromey.com>
6804
6805         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6806         Don't return the symbol.
6807         * coffread.c (record_minimal_symbol): Use record_full.
6808
6809 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6810
6811         The MS-Windows port of ncurses fails to switch to a color pair if
6812         one or both of the colors are the implicit default colors.  This
6813         change records the default colors when TUI is initialized, and
6814         then specifies them explicitly when a color pair uses the default
6815         colors.  This allows color styling in TUI mode on MS-Windows.
6816
6817         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6818         ncurses_norm_attr.
6819         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6820         colors in ncurses_norm_attr.
6821         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6822         "none", replace it with the default color recorded in
6823         ncurses_norm_attr.
6824
6825 2019-03-14  Tom Tromey  <tromey@adacore.com>
6826
6827         * source-cache.h (class source_cache) <get_source_lines>: Return
6828         std::string.
6829         * source-cache.c (source_cache::extract_lines): Handle case where
6830         first_pos==npos.  Return std::string.
6831         (source_cache::get_source_lines): Update.
6832
6833 2019-03-14  Tom Tromey  <tromey@adacore.com>
6834
6835         * NEWS: Add item for "style sources" commands.
6836         * source-cache.c (source_cache::get_source_lines): Check
6837         source_styling.
6838         * cli/cli-style.c (source_styling): New global.
6839         (_initialize_cli_style): Add "style sources" commands.
6840         (show_style_sources): New function.
6841         * cli/cli-style.h (source_styling): Declare.
6842
6843 2019-03-14  Pedro Alves  <palves@redhat.com>
6844             Tom Tromey  <tromey@adacore.com>
6845
6846         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6847         * tui/tui-winsource.c (tui_refill_source_window): New function,
6848         from...
6849         (tui_horizontal_source_scroll): ... here.  Move some logic.
6850         * cli/cli-style.c (set_style_enabled): Notify new observable.
6851         * tui/tui-hooks.c (tui_redisplay_source): New function.
6852         (tui_attach_detach_observers): Attach or detach
6853         tui_redisplay_source.
6854         * observable.h (source_styling_changed): New observable.
6855         * observable.c: Define source_styling_changed observable.
6856
6857 2019-03-13  Tom Tromey  <tromey@adacore.com>
6858
6859         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6860         (i386_gnu_nat_target::store_registers): Update.
6861         * target-debug.h (target_debug_print_std_string): New macro.
6862         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6863         * windows-tdep.c (display_one_tib): Update.
6864         * tui/tui-stack.c (tui_make_status_line): Update.
6865         * top.c (print_inferior_quit_action): Update.
6866         * thread.c (thr_try_catch_cmd): Update.
6867         (add_thread_with_info): Update.
6868         (thread_target_id_str): Update.
6869         (thr_try_catch_cmd): Update.
6870         (thread_command): Update.
6871         (thread_find_command): Update.
6872         * record-btrace.c (record_btrace_target::info_record)
6873         (record_btrace_resume_thread, record_btrace_target::resume)
6874         (record_btrace_cancel_resume, record_btrace_step_thread)
6875         (record_btrace_target::wait, record_btrace_target::wait)
6876         (record_btrace_target::wait, record_btrace_target::stop): Update.
6877         * progspace.c (print_program_space): Update.
6878         * process-stratum-target.c
6879         (process_stratum_target::thread_address_space): Update.
6880         * linux-fork.c (linux_fork_mourn_inferior)
6881         (detach_checkpoint_command, info_checkpoints_command)
6882         (linux_fork_context): Update.
6883         (linux_fork_detach): Update.
6884         (class scoped_switch_fork_info): Update.
6885         (delete_checkpoint_command): Update.
6886         * infrun.c (follow_fork_inferior): Update.
6887         (follow_fork_inferior): Update.
6888         (proceed_after_vfork_done): Update.
6889         (handle_vfork_child_exec_or_exit): Update.
6890         (follow_exec): Update.
6891         (displaced_step_prepare_throw): Update.
6892         (displaced_step_restore): Update.
6893         (start_step_over): Update.
6894         (resume_1): Update.
6895         (clear_proceed_status_thread): Update.
6896         (proceed): Update.
6897         (print_target_wait_results): Update.
6898         (do_target_wait): Update.
6899         (context_switch): Update.
6900         (stop_all_threads): Update.
6901         (restart_threads): Update.
6902         (finish_step_over): Update.
6903         (handle_signal_stop): Update.
6904         (switch_back_to_stepped_thread): Update.
6905         (keep_going_pass_signal): Update.
6906         (print_exited_reason): Update.
6907         (normal_stop): Update.
6908         * inferior.c (inferior_pid_to_str): Change return type.
6909         (print_selected_inferior): Update.
6910         (add_inferior): Update.
6911         (detach_inferior): Update.
6912         * dummy-frame.c (fprint_dummy_frames): Update.
6913         * dcache.c (dcache_info_1): Update.
6914         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6915         (btrace_fetch, btrace_clear): Update.
6916         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6917         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6918         type.
6919         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6920         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6921         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6922         * gdbarch.c, gdbarch.h: Rebuild.
6923         * gdbarch.sh (core_pid_to_str): Change return type.
6924         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6925         return type.
6926         (windows_nat_target::pid_to_str): Change return type.
6927         (windows_delete_thread): Update.
6928         (windows_nat_target::attach): Update.
6929         (windows_nat_target::files_info): Update.
6930         * target-delegates.c: Rebuild.
6931         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6932         return type.
6933         (sol_thread_target::pid_to_str): Change return type.
6934         * remote.c (class remote_target) <pid_to_str>: Change return
6935         type.
6936         (remote_target::pid_to_str): Change return type.
6937         (extended_remote_target::attach, remote_target::remote_stop_ns)
6938         (remote_target::remote_notif_remove_queued_reply)
6939         (remote_target::push_stop_reply, remote_target::disable_btrace):
6940         Update.
6941         (extended_remote_target::attach): Update.
6942         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6943         type.
6944         (gdbsim_target::pid_to_str): Change return type.
6945         * ravenscar-thread.c (struct ravenscar_thread_target)
6946         <pid_to_str>: Change return type.
6947         (ravenscar_thread_target::pid_to_str): Change return type.
6948         * procfs.c (class procfs_target) <pid_to_str>: Change return
6949         type.
6950         (procfs_target::pid_to_str): Change return type.
6951         (procfs_target::attach): Update.
6952         (procfs_target::detach): Update.
6953         (procfs_target::fetch_registers): Update.
6954         (procfs_target::store_registers): Update.
6955         (procfs_target::wait): Update.
6956         (procfs_target::files_info): Update.
6957         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6958         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6959         return type.
6960         (nto_procfs_target::pid_to_str): Change return type.
6961         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6962         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6963         return type.
6964         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6965         (exit_lwp): Update.
6966         (attach_proc_task_lwp_callback, get_detach_signal)
6967         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6968         (linux_nat_target::resume, wait_lwp, stop_callback)
6969         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6970         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6971         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6972         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6973         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6974         type.
6975         (inf_ptrace_target::attach): Update.
6976         (inf_ptrace_target::files_info): Update.
6977         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6978         type.
6979         (go32_nat_target::pid_to_str): Change return type.
6980         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6981         (gnu_nat_target::wait): Update.
6982         (gnu_nat_target::wait): Update.
6983         (gnu_nat_target::resume): Update.
6984         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6985         (fbsd_nat_target::wait): Update.
6986         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6987         type.
6988         (darwin_nat_target::attach): Update.
6989         * corelow.c (class core_target) <pid_to_str>: Change return type.
6990         (core_target::pid_to_str): Change return type.
6991         * target.c (normal_pid_to_str): Change return type.
6992         (default_pid_to_str): Likewise.
6993         (target_pid_to_str): Change return type.
6994         (target_translate_tls_address): Update.
6995         (target_announce_detach): Update.
6996         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6997         return type.
6998         (bsd_uthread_target::pid_to_str): Change return type.
6999         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7000         type.
7001         (bsd_kvm_target::pid_to_str): Change return type.
7002         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7003         return type.
7004         (aix_thread_target::pid_to_str): Change return type.
7005         * target.h (struct target_ops) <pid_to_str>: Change return type.
7006         (target_pid_to_str, normal_pid_to_str): Likewise.
7007         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7008         type.
7009         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7010         type.
7011         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7012         return type.
7013         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7014         type.
7015         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7016         type.
7017         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7018         return type.
7019
7020 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7021
7022         * NEWS: Mention that the new default MI version is 3.  Mention
7023         changes to the output of commands and events that deal with
7024         multi-location breakpoints.
7025         * breakpoint.c: Include "mi/mi-out.h".
7026         (print_one_breakpoint): Change output syntax if using MI version
7027         >= 3.
7028         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7029         New.
7030         (mi_multi_location_breakpoint_output_fixed): New.
7031         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7032         (mi_cmd_fix_multi_location_breakpoint_output): New.
7033         (mi_multi_location_breakpoint_output_fixed): New.
7034         * mi/mi-cmds.c (mi_cmds): Register command
7035         -fix-multi-location-breakpoint-output.
7036         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7037         interpreter "mi".
7038
7039 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7040
7041         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7042         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7043         instantiate mi_ui_out based on interpreter name.
7044         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7045         * mi/mi-main.c (mi_load_progress): Likewise.
7046
7047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7048
7049         * NEWS: Combine separate "New targets" sections for 8.3.
7050
7051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7052
7053         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7054         (ppcfbsd_init_abi): Install gdbarch
7055         "fetch_tls_load_module_address" and "get_thread_local_address"
7056         methods.
7057
7058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7059
7060         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7061         (riscv_fbsd_init_abi): Install gdbarch
7062         "fetch_tls_load_module_address" and "get_thread_local_address"
7063         methods.
7064
7065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7066
7067         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7068         (i386fbsd_init_abi): Install gdbarch
7069         "fetch_tls_load_module_address" and "get_thread_local_address"
7070         methods.
7071
7072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7073
7074         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7075         (amd64fbsd_init_abi): Install gdbarch
7076         "fetch_tls_load_module_address" and "get_thread_local_address"
7077         methods.
7078
7079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7080
7081         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7082         (struct fbsd_pspace_data): New type.
7083         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7084         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7085         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7086         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7087         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7088
7089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7090
7091         * gdbtypes.c (lookup_struct_elt): New function.
7092         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7093         * gdbtypes.h (struct struct_elt): New type.
7094         (lookup_struct_elt): New prototype.
7095
7096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7097
7098         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7099         remove disabled code block.
7100
7101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7102
7103         * gdbarch.sh (get_thread_local_address): New method.
7104         * gdbarch.h, gdbarch.c: Regenerate.
7105         * target.c (target_translate_tls_address): Use
7106         gdbarch_get_thread_local_address if present instead of
7107         target::get_thread_local_address.
7108
7109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7110
7111         * target.h (target::get_thread_local_address): Update comment.
7112
7113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7114
7115         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7116         objfile->separate_debug_objfile_backlink if not NULL.
7117
7118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7119
7120         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7121         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7122         (amd64bsd_store_inferior_registers): Likewise.
7123         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7124         Enable segment base registers.
7125         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7126         PT_GETFSBASE and PT_GETGSBASE.
7127         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7128         PT_SETGSBASE.
7129         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7130         segment base registers.
7131         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7132
7133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7134
7135         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7136         Update calls to i386_target_description to add 'segments'
7137         parameter.
7138         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7139         add segment base registers.
7140         * arch/i386.c (i386_create_target_description): Add 'segments'
7141         parameter to enable segment base registers.
7142         * arch/i386.h (i386_create_target_description): Likewise.
7143         * features/i386/32bit-segments.xml: New file.
7144         * features/i386/32bit-segments.c: Generate.
7145         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7146         call to i386_target_description to add 'segments' parameter.
7147         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7148         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7149         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7150         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7151         if feature is present.
7152         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7153         Add 'segments' parameter to call to i386_target_description.
7154         (i386_target_description): Add 'segments' parameter to enable
7155         segment base registers.
7156         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7157         to call to i386_target_description.
7158         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7159         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7160         Define I386_NUM_REGS.
7161         (i386_target_description): Add 'segments' parameter to enable
7162         segment base registers.
7163
7164 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7165
7166         PR/24325
7167         * source-cache.c: #undef open and close, to avoid unresolved
7168         externals during linking.
7169
7170 2019-03-12  Tom Tromey  <tromey@adacore.com>
7171
7172         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7173         const.  Add initializers.
7174         (_initialize_remote): Don't initialize ptid globals.
7175
7176 2019-03-12  Pedro Alves  <palves@redhat.com>
7177
7178         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7179
7180 2019-03-12  Pedro Alves  <palves@redhat.com>
7181
7182         * cp-name-parser.y (main): Remove unused 'len' variable.
7183
7184 2019-03-12  Tom Tromey  <tromey@adacore.com>
7185
7186         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7187         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7188
7189 2019-03-12  Tom Tromey  <tromey@adacore.com>
7190
7191         * linux-nat.c (iterate_over_lwps): Update.
7192         (stop_callback): Remove parameter.
7193         (stop_wait_callback, detach_callback, resume_set_callback)
7194         (select_singlestep_lwp_callback, set_ignore_sigint)
7195         (status_callback, resumed_callback, resume_clear_callback)
7196         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7197         data parameter.
7198         (linux_nat_target::detach, linux_nat_target::resume)
7199         (linux_stop_and_wait_all_lwps, select_event_lwp)
7200         (linux_nat_filter_event, linux_nat_wait_1)
7201         (linux_nat_target::kill, linux_nat_target::stop)
7202         (linux_nat_target::stop): Update.
7203         (linux_nat_resume_callback): Change type.
7204         (resume_stopped_resumed_lwps, count_events_callback)
7205         (select_event_lwp_callback): Likewise.
7206         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7207         * arm-linux-nat.c (struct update_registers_data): Remove.
7208         (update_registers_callback): Change type.
7209         (arm_linux_insert_hw_breakpoint1): Update.
7210         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7211         parameter.
7212         (x86_linux_dr_set_addr): Update.
7213         (x86_linux_dr_set_control): Update.
7214         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7215         (iterate_over_lwps): Use gdb::function_view.
7216         * nat/aarch64-linux-hw-point.c (struct
7217         aarch64_dr_update_callback_param): Remove.
7218         (debug_reg_change_callback): Change type.
7219         (aarch64_notify_debug_reg_change): Update.
7220         * s390-linux-nat.c (s390_refresh_per_info): Update.
7221
7222 2019-03-11  Tom Tromey  <tromey@adacore.com>
7223
7224         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7225         redundant assignment to "this_cu".
7226
7227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7228
7229         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7230
7231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7232
7233         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7234         from...
7235         (rank_one_type): ... this.
7236
7237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7238
7239         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7240         from...
7241         (rank_one_type): ... this.
7242
7243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7244
7245         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7246         from...
7247         (rank_one_type): ... this.
7248
7249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7250
7251         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7252         from...
7253         (rank_one_type): ... this.
7254
7255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7256
7257         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7258         from...
7259         (rank_one_type): ... this.
7260
7261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7262
7263         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7264         from...
7265         (rank_one_type): ... this.
7266
7267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7268
7269         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7270         from...
7271         (rank_one_type): ... this.
7272
7273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7274
7275         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7276         from...
7277         (rank_one_type): ... this.
7278
7279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7280
7281         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7282         from...
7283         (rank_one_type): ... this.
7284
7285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7286
7287         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7288         from...
7289         (rank_one_type): ... this.
7290
7291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7292
7293         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7294         from...
7295         (rank_one_type): ... this.
7296
7297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7298
7299         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7300         from...
7301         (rank_one_type): ... this.
7302
7303 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7304
7305         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7306         inferior-events' shows the example events.
7307
7308 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7309
7310         Support styling on native MS-Windows console
7311
7312         PR/24315
7313         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7314         on MS-Windows if $TERM is not defined.
7315
7316         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7317
7318         * posix-hdep.c (gdb_console_fputs):
7319         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7320         functions.
7321         * ui-file.h (gdb_console_fputs): Add prototype.
7322
7323         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7324         back to fputs only if the former returns zero.
7325
7326 2019-03-07  Tom Tromey  <tom@tromey.com>
7327
7328         * symmisc.c (print_symbol_bcache_statistics): Update.
7329         (print_objfile_statistics): Update.
7330         * symfile.c (allocate_symtab): Update.
7331         * stabsread.c: Don't include bcache.h.
7332         * psymtab.h (struct psymbol_bcache): Don't declare.
7333         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7334         (psymbol_bcache_init, psymbol_bcache_free)
7335         (psymbol_bcache_get_bcache): Don't declare.
7336         * psymtab.c (struct psymbol_bcache): Remove.
7337         (psymtab_storage::psymtab_storage): Update.
7338         (psymtab_storage::~psymtab_storage): Update.
7339         (psymbol_bcache_init, psymbol_bcache_free)
7340         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7341         (add_psymbol_to_bcache): Update.
7342         (allocate_psymtab): Update.
7343         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7344         macro_cache>: No longer pointers.
7345         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7346         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7347         * macrotab.c (macro_bcache): Update.
7348         * macroexp.c: Don't include bcache.h.
7349         * gdbtypes.c (check_types_worklist): Update.
7350         (types_deeply_equal): Remove TRY/CATCH.  Update.
7351         * elfread.c (elf_symtab_read): Update.
7352         * dwarf2read.c: Don't include bcache.h.
7353         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7354         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7355         (print_bcache_statistics, bcache_memory_used): Don't declare.
7356         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7357         methods.  Rename all data members.
7358         * bcache.c (struct bcache): Move to bcache.h.
7359         (bcache::expand_hash_table): Rename from expand_hash_table.
7360         (bcache): Remove.
7361         (bcache::insert): Rename from bcache_full.
7362         (bcache::compare): Rename from bcache_compare.
7363         (bcache_xmalloc): Remove.
7364         (bcache::~bcache): Rename from bcache_xfree.
7365         (bcache::print_statistics): Rename from print_bcache_statistics.
7366         (bcache::memory_used): Rename from bcache_memory_used.
7367
7368 2019-03-07  Pedro Alves  <palves@redhat.com>
7369
7370         * infrun.c (normal_stop): Also check for
7371         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7372
7373 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7374
7375         * f-lang.c (value_from_host_double): Moved to...
7376         * value.c (value_from_host_double): ...here.
7377         * value.h (value_from_host_double): Declare.
7378         * guile/scm-math.c (vlscm_convert_typed_number): Use
7379         value_from_host_double.
7380         (vlscm_convert_number): Likewise.
7381         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7382         * python/py-value.c (convert_value_from_python): Likewise.
7383
7384 2019-03-06  Tom Tromey  <tom@tromey.com>
7385
7386         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7387
7388 2019-03-06  Tom Tromey  <tom@tromey.com>
7389
7390         * utils.h (free_current_contents): Don't declare.
7391         * utils.c (free_current_contents): Remove.
7392
7393 2019-03-06  Tom Tromey  <tom@tromey.com>
7394
7395         * top.c (quit_force): Update.
7396         * main.c (captured_command_loop): Update.
7397         * common/new-op.c (operator new): Update.
7398         * common/common-exceptions.c (struct catcher)
7399         <save_cleanup_chain>: Remove member.
7400         (exceptions_state_mc_init): Update.
7401         (exception_try_scope_entry): Return nullptr.
7402         (exception_try_scope_exit, exception_rethrow)
7403         (throw_exception_sjlj, throw_exception_cxx): Update.
7404         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7405         (all_cleanups, do_cleanups, discard_cleanups)
7406         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7407         (restore_cleanups, restore_final_cleanups): Don't declare.
7408         (do_final_cleanups): Remove parameter.
7409         * common/cleanups.c (cleanup_chain, make_cleanup)
7410         (make_cleanup_dtor, all_cleanups, do_cleanups)
7411         (discard_my_cleanups, discard_cleanups)
7412         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7413         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7414         (null_cleanup): Remove.
7415         (do_final_cleanups): Remove parameter.
7416
7417 2019-03-06  Tom Tromey  <tom@tromey.com>
7418
7419         * remote.c (remote_target::remote_parse_stop_reply): Use
7420         unique_xmalloc_ptr.
7421
7422 2019-03-06  Tom Tromey  <tom@tromey.com>
7423
7424         * stabsread.c (struct stabs_field_info): Rename from field_info.
7425         <list, fnlist>: Add initializers.
7426         <obstack>: New member.
7427         (read_member_functions, read_struct_fields, read_baseclasses):
7428         Allocate on obstack.  Don't use cleanups.
7429         (read_one_struct_field, read_member_functions, read_struct_fields)
7430         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7431         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7432         (read_struct_type): Update.
7433
7434 2019-03-06  Tom Tromey  <tom@tromey.com>
7435
7436         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7437         * common/filestuff.h (make_cleanup_close): Don't declare.
7438         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7439         Remove.
7440
7441 2019-03-06  Tom Tromey  <tom@tromey.com>
7442
7443         * solib-aix.c: Use make_scope_exit.
7444
7445 2019-03-06  Tom Tromey  <tom@tromey.com>
7446
7447         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7448         Use make_scope_exit.
7449
7450 2019-03-06  Tom Tromey  <tom@tromey.com>
7451
7452         * solib-svr4.c (disable_probes_interface): Remove parameter.
7453         (svr4_handle_solib_event): Use make_scope_exit.
7454
7455 2019-03-06  Tom Tromey  <tom@tromey.com>
7456
7457         * remote.c (struct stop_reply_deleter): Remove.
7458         (stop_reply_up): Update.
7459         (struct stop_reply): Derive from notif_event.  Don't typedef.
7460         <regcache>: Now a std::vector.
7461         (stop_reply_xfree): Remove.
7462         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7463         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7464         (remote_target::discard_pending_stop_replies): Use delete.
7465         (remote_target::remote_parse_stop_reply): Update.
7466         (remote_target::process_stop_reply): Update.
7467         * remote-notif.h (struct notif_event): Add virtual destructor.
7468         Remove "dtr" member.
7469         (struct notif_client) <alloc_event>: Return a unique_ptr.
7470         (notif_event_xfree): Don't declare.
7471         (notif_event_up): New typedef.
7472         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7473         (notif_event_xfree, do_notif_event_xfree): Remove.
7474         (remote_notif_state_xfree): Update.
7475
7476 2019-03-06  Tom Tromey  <tom@tromey.com>
7477
7478         * infrun.c (displaced_step_clear_cleanup): Now a
7479         forward_scope_exit type.
7480         (displaced_step_prepare_throw): Update.
7481         (displaced_step_fixup): Update.
7482
7483 2019-03-06  Tom Tromey  <tom@tromey.com>
7484
7485         * inferior.h (class inferior): Update comment.
7486         * gdbthread.h (class thread_info): Update comment.
7487
7488 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7489             Tom Tromey  <tom@tromey.com>
7490
7491         * stabsread.h (struct stab_section_list): Remove.
7492         (coffstab_build_psymtabs): Update.
7493         * dbxread.c (symbuf_sections): Now a std::vector.
7494         (sect_idx): New global.
7495         (fill_symbuf): Update.
7496         (coffstab_build_psymtabs): Change type of stabsects parameter.
7497         Update.
7498         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7499         std::vector.
7500         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7501         (coff_locate_sections): Update.
7502         (coff_symfile_read): Remove cleanups.  Update.
7503         (init_stringtab): Add storage parameter.
7504         (free_stringtab, free_stringtab_cleanup): Remove.
7505         (init_lineno): Add storage parameter.
7506         (free_linetab, free_linetab_cleanup): Remove.
7507
7508 2019-03-06  Pedro Alves  <palves@redhat.com>
7509
7510         * linux-fork.c (fork_info::clobber_regs): Delete.
7511         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7512         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7513         comment.  Adjust.
7514         (scoped_switch_fork_info::scoped_switch_fork_info)
7515         (checkpoint_command, linux_fork_context): Adjust
7516         fork_save_infrun_state calls.
7517
7518 2019-03-06  Pedro Alves  <palves@redhat.com>
7519
7520         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7521         (inf_has_multiple_threads): Return 'bool' and rewrite using
7522         inferior_info::threads().
7523
7524 2019-03-06  Pedro Alves  <palves@redhat.com>
7525
7526         * linux-fork.c: Include <list>.
7527         (fork_list): Now a std::list instance.
7528         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7529         (forks_exist_p, find_last_fork): Adjust.
7530         (new_fork): Delete.
7531         (one_fork_p): New.
7532         (add_fork): Adjust.
7533         (free_fork): Delete, folded into fork_info::~fork_info().
7534         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7535         Adjust.
7536         (init_fork_list): Delete.
7537         (linux_fork_killall, linux_fork_mourn_inferior)
7538         (linux_fork_detach, info_checkpoints_command): Adjust.
7539         (_initialize_linux_fork): No longer call init_fork_list.
7540
7541 2019-03-06  Pedro Alves  <palves@redhat.com>
7542
7543         * linux-fork.c (new_fork): New, split out of ...
7544         (add_fork): ... this.  Return void.  Move "first fork" special
7545         case from here, to ...
7546         (checkpoint_command): ... here.
7547         * linux-linux.h (add_fork): Return void.
7548
7549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7552
7553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7554             Chris January  <chris.january@arm.com>
7555             David Lecomber  <david.lecomber@arm.com>
7556
7557         * f-exp.y: New token, UNOP_INTRINSIC.
7558         (exp): New pattern using UNOP_INTRINSIC token.
7559         (f77_keywords): Add 'abs' keyword.
7560         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7561         (value_from_host_double): New function.
7562         (evaluate_subexp_f): Support UNOP_ABS.
7563
7564 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7567         types.
7568
7569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7572         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7573         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7574
7575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7576
7577         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7578
7579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7580             Chris January  <chris.january@arm.com>
7581
7582         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7583         * f-exp.y: Define 'KIND' token.
7584         (exp): New pattern for KIND expressions.
7585         (ptype): Handle types with a kind extension.
7586         (direct_abs_decl): Extend to spot kind extensions.
7587         (f77_keywords): Add 'kind' to the list.
7588         (push_kind_type): New function.
7589         (convert_to_kind_type): New function.
7590         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7591         * parse.c (operator_length_standard): Likewise.
7592         * parser-defs.h (enum type_pieces): Add tp_kind.
7593         * std-operator.def: Add UNOP_KIND.
7594
7595 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * f-exp.y (f_parse): Set yydebug.
7598
7599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7600
7601         * f-lang.c (evaluate_subexp_f): New function.
7602         (exp_descriptor_f): New global.
7603         (f_language_defn): Use exp_descriptor_f instead of
7604         exp_descriptor_standard.
7605
7606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * f-exp.y (struct token): Add comments.
7609         (dot_ops): Remove uppercase versions and the end marker.
7610         (f77_keywords): Likewise.
7611         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7612         entries in the dot_ops array are case insensitive, and use
7613         strncasecmp to compare strings.  Also some whitespace cleanup in
7614         this area.  Similar for the f77_keywords array, except entries in
7615         this list might be case sensitive.
7616
7617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * f-exp.y (struct f77_boolean_val): Add comments.
7620         (boolean_values): Remove uppercase versions, and end marker.
7621         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7622         and use strncasecmp to achieve case insensitivity.  Additionally,
7623         perform whitespace cleanup around this code.
7624
7625 2019-03-06  Tom Tromey  <tromey@adacore.com>
7626
7627         * remote-sim.c (gdbsim_target_open): Use result of
7628         gdb_argv::release.
7629
7630 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7631         Dirk Schubert  <dirk.schubert@arm.com>
7632         Chris January  <chris.january@arm.com>
7633
7634         * eval.c (evaluate_subexp_standard): Call Fortran argument
7635         wrapping logic.
7636         * f-lang.c (struct value): A value which can be passed into a
7637         Fortran function call.
7638         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7639         where appropriate.
7640         (struct type): Value ready for a Fortran function call.
7641         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7642         is needed.
7643         * f-lang.h (fortran_argument_convert): Declaration.
7644         (fortran_preserve_arg_pointer): Declaration.
7645         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7646
7647 2019-03-05  Tom Tromey  <tromey@adacore.com>
7648
7649         * python/py-prettyprint.c (print_string_repr): Remove #if.
7650         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7651
7652 2019-03-05  Tom Tromey  <tromey@adacore.com>
7653
7654         * target.c (the_dummy_target): Move later.  Change type to
7655         "dummy_target".
7656         (initialize_targets): Don't initialize the_dummy_target.
7657
7658 2019-03-05  Tom Tromey  <tromey@adacore.com>
7659
7660         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7661         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7662
7663 2019-03-05  Tom Tromey  <tromey@adacore.com>
7664
7665         * windows-nat.c (windows_nat_target::attach)
7666         (windows_nat_target::detach): Don't call gdb_flush.
7667         * valprint.c (generic_val_print, val_print, val_print_string):
7668         Don't call gdb_flush.
7669         * utils.c (defaulted_query): Don't call gdb_flush.
7670         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7671         * target.c (target_announce_detach): Don't call gdb_flush.
7672         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7673         * remote.c (extended_remote_target::attach): Don't call
7674         gdb_flush.
7675         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7676         * printcmd.c (do_examine): Don't call gdb_flush.
7677         (info_display_command): Don't call gdb_flush.
7678         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7679         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7680         * memattr.c (info_mem_command): Don't call gdb_flush.
7681         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7682         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7683         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7684         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7685         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7686         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7687         (gnu_nat_target::detach): Don't call gdb_flush.
7688         * f-valprint.c (f_val_print): Don't call gdb_flush.
7689         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7690         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7691         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7692         gdb_flush.
7693         * c-valprint.c (c_val_print): Don't call gdb_flush.
7694         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7695
7696 2019-03-05  Tom Tromey  <tromey@adacore.com>
7697
7698         * varobj.c (update_dynamic_varobj_children): Update.
7699         (install_default_visualizer): Use reset, not release.
7700         * value.c (set_internalvar): Update.
7701         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7702         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7703         ATTRIBUTE_UNUSED_RESULT.
7704
7705 2019-03-05  Tom Tromey  <tromey@adacore.com>
7706
7707         * remote.c (class scoped_remote_fd) <release>: Add
7708         ATTRIBUTE_UNUSED_RESULT.
7709
7710 2019-03-05  Tom Tromey  <tromey@adacore.com>
7711
7712         * macroexp.c (struct macro_buffer) <release>: Add
7713         ATTRIBUTE_UNUSED_RESULT.
7714
7715 2019-03-05  Tom Tromey  <tromey@adacore.com>
7716
7717         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7718         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7719         ATTRIBUTE_UNUSED_RESULT.
7720
7721 2019-03-05  Tom Tromey  <tromey@adacore.com>
7722
7723         * common/scoped_fd.h (class scoped_fd) <release>: Add
7724         ATTRIBUTE_UNUSED_RESULT.
7725
7726 2019-03-05  Tom Tromey  <tromey@adacore.com>
7727
7728         * parser-defs.h (struct parser_state) <release>: Add
7729         ATTRIBUTE_UNUSED_RESULT.
7730
7731 2019-03-05  Tom Tromey  <tromey@adacore.com>
7732
7733         * utils.h (class gdb_argv) <release>: Add
7734         ATTRIBUTE_UNUSED_RESULT.
7735         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7736
7737 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7738
7739         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7740         for-loop range, to avoid compiler warnings.
7741
7742         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7743         avoid compiler warnings about unused variables.
7744
7745         * NEWS: Mention end of support for native debugging on MS-Windows
7746         before XP.
7747
7748         PR gdb/24292
7749         * common/netstuff.c:
7750         * gdbserver/gdbreplay.c
7751         * gdbserver/remote-utils.c:
7752         * ser-tcp.c:
7753         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7754         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7755         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7756         'getaddrinfo' and 'freeaddrinfo' were not available before
7757         Windows XP, and mingw.org's MinGW headers by default define
7758         _WIN32_WINNT to 0x500.
7759
7760 2019-03-01  Gary Benson <gbenson@redhat.com>
7761
7762         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7763
7764 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7765             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7766
7767         PR gdb/8527
7768         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7769         set_sigint_trap, clear_sigint_trap.
7770
7771 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7772
7773         * target.c (target_detach): Clear the regcache and the
7774         frame cache.
7775
7776 2019-02-27  Pedro Alves  <palves@redhat.com>
7777
7778         * utils.c (set_screen_size): When we cap the height/width sizes,
7779         tweak the corresponding command variable to show "unlimited":
7780
7781 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7782             Pedro Alves  <palves@redhat.com>
7783
7784         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7785         before calling rl_set_screen_size.
7786
7787 2019-02-27  Tom Tromey  <tromey@adacore.com>
7788
7789         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7790         define.
7791         * python/py-value.c: Remove Python 2.4 workaround.
7792         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7793         workaround.
7794         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7795         Python 2.4 workaround.
7796         * python/python-internal.h: Remove Python 2.4 comment.
7797         (Py_ssize_t): Don't define.
7798         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7799         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7800         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7801         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7802         * python/python.c (do_start_initialization): Remove Python 2.4
7803         workaround.
7804         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7805         (print_children): Remove Python 2.4 workaround.
7806         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7807         workaround.
7808         (CHARBUFFERPROC_NAME): Remove.
7809         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7810         Python 2.4 workaround.
7811
7812 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7813
7814         * NEWS: Note minimum Python version.
7815
7816 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7817
7818         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7819         code from these functions.  Remove corresponding ifdefs.  Use
7820         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7821         Remove gotos and target of gotos.
7822         (infpy_search_memory): Likewise.
7823
7824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7827         (hppa_gdbarch_init): Don't register deleted functions with
7828         gdbarch.
7829
7830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7833         (h8300_unwind_sp): Delete.
7834         (h8300_dummy_id): Delete.
7835         (h8300_gdbarch_init): Don't register deleted functions with
7836         gdbarch.
7837
7838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7839
7840         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7841         (ft32_unwind_pc): Delete.
7842         (ft32_unwind_sp): Delete.
7843         (ft32_gdbarch_init): Don't register deleted functions with
7844         gdbarch.
7845
7846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7849         (frv_unwind_pc): Delete.
7850         (frv_unwind_sp): Delete.
7851         (frv_gdbarch_init): Don't register deleted functions with
7852         gdbarch.
7853
7854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7855
7856         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7857         (riscv_unwind_pc): Delete.
7858         (riscv_unwind_sp): Delete.
7859         (riscv_gdbarch_init): Don't register deleted functions with
7860         gdbarch.
7861
7862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7865         (csky_unwind_pc): Delete.
7866         (csky_unwind_sp): Delete.
7867         (csky_gdbarch_init): Don't register deleted functions with
7868         gdbarch.
7869
7870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7871
7872         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7873         (cris_unwind_pc): Delete.
7874         (cris_unwind_sp): Delete.
7875         (cris_gdbarch_init): Don't register deleted functions with
7876         gdbarch.
7877
7878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7879
7880         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7881         (bfin_unwind_pc): Delete.
7882         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7883
7884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7885
7886         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7887         (arm_unwind_pc): Delete.
7888         (arm_unwind_sp): Delete.
7889         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7890
7891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7892
7893         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7894         (arc_unwind_pc): Delete.
7895         (arc_unwind_sp): Delete.
7896         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7897
7898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7899
7900         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7901         (alpha_unwind_pc): Delete.
7902         (alpha_gdbarch_init): Don't register deleted functions with
7903         gdbarch.
7904
7905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7906
7907         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7908         (aarch64_unwind_pc): Delete.
7909         (aarch64_unwind_sp): Delete.
7910         (aarch64_gdbarch_init): Don't register deleted functions with
7911         gdbarch.
7912
7913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7914
7915         * gdbtypes.c (type_align): Don't consider static members when
7916         computing structure alignment.
7917
7918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7919
7920         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7921         return 0 for other types.
7922         * arch-utils.c (default_type_align): Always return 0.
7923         * gdbarch.h: Regenerate.
7924         * gdbarch.sh (type_align): Extend comment.
7925         * gdbtypes.c (type_align): Add additional comments, always call
7926         gdbarch_type_align before applying the default rules.
7927         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7928         generic code will then apply a suitable default.
7929         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7930         types, return 0 for other types.
7931
7932 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7933
7934         * NEWS: Create a new section for the next release branch.
7935         Rename the section of the current branch, now that it has
7936         been cut.
7937
7938 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7939
7940         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7941         * version.in: Bump version to 8.3.50.DATE-git.
7942
7943 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7944
7945         * aix-thread.c (ptid_cmp): Remove unused variable.
7946         (get_signaled_thread): Likewise.
7947         (store_regs_user_thread): Likewise.
7948         (store_regs_kernel_thread): Likewise.
7949         (fetch_regs_kernel_thread): Remove shadowed variable.
7950
7951 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7952
7953         * features/riscv/32bit-cpu.xml: Add register numbers.
7954         * features/riscv/32bit-fpu.c: Regenerate.
7955         * features/riscv/32bit-fpu.xml: Add register numbers.
7956         * features/riscv/64bit-cpu.xml: Add register numbers.
7957         * features/riscv/64bit-fpu.c: Regenerate.
7958         * features/riscv/64bit-fpu.xml: Add register numbers.
7959
7960 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7961
7962         * NEWS: Mention two argument form of gdb.Value constructor.
7963         * python/py-value.c (convert_buffer_and_type_to_value): New
7964         function.
7965         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7966         Add support for handling an optional second argument.  Call
7967         convert_buffer_and_type_to_value as appropriate.
7968         * python/python-internal.h (Py_buffer_deleter): New struct.
7969         (Py_buffer_up): New typedef.
7970
7971 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7972
7973         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7974         instead of releasing ownership.
7975
7976 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7977
7978         * dwarf2read.c (open_and_init_dwp_file): Call
7979         elf_numsections instead of bfd_count_sections to initialize
7980         dwp_file->num_sections.
7981
7982 2019-02-25  Tom Tromey  <tromey@adacore.com>
7983
7984         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7985
7986 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7987
7988         * gcore.in: Add '--readnever' option when invoking GDB.
7989
7990 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7991
7992         * MAINTAINERS: Update my email address.
7993
7994 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7995
7996         * build-id.c (build_id_to_debug_bfd_1): New function.
7997         (build_id_to_debug_bfd): Look for separate debug file in
7998         sysroot.
7999
8000 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * gdbarch.sh: Update the copyright year range that is placed into
8003         generated files.
8004
8005 2019-02-22  Keith Seitz  <keiths@redhat.com>
8006
8007         PR symtab/23853
8008         * linespec.c (create_sals_line_offset): Search for the default
8009         symtab's filename instead of its fullname.
8010
8011 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8012
8013         * NEWS: Update style defaults.
8014
8015 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8016
8017         * main.c (captured_main_1): Disable styling in batch mode.
8018
8019 2019-02-20  Tom Tromey  <tom@tromey.com>
8020
8021         * symtab.c (symtab_symbol_info): Fix typos.
8022
8023 2019-02-20  Tom Tromey  <tromey@adacore.com>
8024
8025         * findcmd.c (_initialize_mem_search): Use upper case for
8026         metasyntactic variables.
8027
8028 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8029
8030         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8031         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8032
8033 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8034
8035         * top.h (source_file_name): Change to std::string.
8036         * top.c (source_file_name): Likewise.
8037         (command_line_input): Adjust.
8038         * cli/cli-script.c (script_from_file): Adjust.
8039
8040 2019-02-19  Tom Tromey  <tromey@adacore.com>
8041
8042         * ravenscar-thread.c
8043         (ravenscar_thread_target::update_thread_list): Don't call
8044         ada_build_task_list.
8045         * ada-lang.h (ada_build_task_list): Don't declare.
8046         * ada-tasks.c (struct ada_tasks_inferior_data)
8047         <task_list_valid_p>: Now bool.
8048         (read_known_tasks, ada_task_list_changed)
8049         (ada_tasks_invalidate_inferior_data): Update.
8050         (read_known_tasks_array): Return bool.
8051         (read_known_tasks_list): Likewise.
8052         (read_known_tasks): Return void.
8053         (ada_build_task_list): Now static.
8054
8055 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8056
8057         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8058         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8059
8060 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8061
8062         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8063         variant for ada_tasks_pspace_data_handle and
8064         ada_tasks_inferior_data_handle.
8065         (ada_tasks_pspace_data_cleanup): New function.
8066         (ada_tasks_inferior_data_cleanup): New function.
8067
8068 2019-02-17  Tom Tromey  <tom@tromey.com>
8069
8070         * macrotab.h (macro_source_fullname): Return a std::string.
8071         * macrotab.c (macro_include, check_for_redefinition)
8072         (macro_undef, macro_lookup_definition, foreach_macro)
8073         (foreach_macro_in_scope): Update.
8074         (macro_source_fullname): Return a std::string.
8075         * macrocmd.c (show_pp_source_pos): Update.
8076
8077 2019-02-17  Tom Tromey  <tom@tromey.com>
8078
8079         * macrocmd.c (show_pp_source_pos): Style the file names.
8080
8081 2019-02-17  Tom Tromey  <tom@tromey.com>
8082
8083         PR tui/24197:
8084         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8085
8086 2019-02-17  Tom Tromey  <tom@tromey.com>
8087
8088         * ada-lang.c (user_select_syms): Use filtered printing.
8089         * utils.c (wrap_style): New global.
8090         (desired_style): Remove.
8091         (emit_style_escape): Add stream parameter.
8092         (set_output_style, reset_terminal_style, prompt_for_continue):
8093         Update.
8094         (flush_wrap_buffer): Only flush gdb_stdout.
8095         (wrap_here): Set wrap_style.
8096         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8097         treat escape sequences as a character.  Change when wrap buffer is
8098         flushed.
8099         (fputs_styled): Do not set the output style when the default is
8100         requested.
8101         * ui-style.h (struct ui_file_style) <is_default>: New method.
8102         * source.c (print_source_lines_base): Emit escape sequences in one
8103         piece.
8104
8105 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8106
8107         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8108         integers and enumeration types.
8109
8110 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8111
8112         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8113         instead of lookup_symbol_in_language
8114         (do_exact_match): New function.
8115         (ada_get_symbol_name_matcher): Return do_exact_match when
8116         doing a verbatim match.
8117
8118 2019-02-15  Tom Tromey  <tromey@adacore.com>
8119
8120         * ravenscar-thread.c (ravenscar_thread_target::resume)
8121         (ravenscar_thread_target::wait): Special case wildcard requests.
8122
8123 2019-02-15  Tom Tromey  <tromey@adacore.com>
8124
8125         * ravenscar-thread.c (base_ptid): Remove.
8126         (struct ravenscar_thread_target) <close>: New method.
8127         <m_base_ptid>: New member.
8128         <update_inferior_ptid, active_task, task_is_currently_active,
8129         runtime_initialized>: Declare methods.
8130         <ravenscar_thread_target>: Add constructor.
8131         (ravenscar_thread_target::task_is_currently_active)
8132         (ravenscar_thread_target::update_inferior_ptid)
8133         (ravenscar_runtime_initialized): Rename.  Now methods.
8134         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8135         (ravenscar_thread_target::update_thread_list): Update.
8136         (ravenscar_thread_target::active_task): Now method.
8137         (ravenscar_thread_target::store_registers)
8138         (ravenscar_thread_target::prepare_to_store)
8139         (ravenscar_thread_target::prepare_to_store)
8140         (ravenscar_thread_target::mourn_inferior): Update.
8141         (ravenscar_inferior_created): Use "new" to create target.
8142         (ravenscar_thread_target::get_ada_task_ptid): Update.
8143         (_initialize_ravenscar): Don't initialize base_ptid.
8144         (ravenscar_ops): Remove global.
8145
8146 2019-02-15  Tom Tromey  <tromey@adacore.com>
8147
8148         * target.h (push_target): Declare new overload.
8149         * target.c (push_target): New overload, taking an rvalue reference.
8150         * remote.c (remote_target::open_1): Use push_target overload.
8151         * corelow.c (core_target_open): Use push_target overload.
8152
8153 2019-02-15  Tom Tromey  <tromey@adacore.com>
8154
8155         * ravenscar-thread.c (is_ravenscar_task)
8156         (ravenscar_task_is_currently_active): Return bool.
8157         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8158         (_initialize_ravenscar): Remove "(void)".
8159         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8160         Return bool.
8161
8162 2019-02-15  Tom Tromey  <tromey@adacore.com>
8163
8164         * ravenscar-thread.c (ravenscar_runtime_initializer)
8165         (has_ravenscar_runtime, get_running_thread_id)
8166         (ravenscar_thread_target::resume): Fix indentation.
8167
8168 2019-02-15  Tom Tromey  <tromey@adacore.com>
8169
8170         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8171         from ravenscar_arch_ops.
8172         (sparc_ravenscar_ops::fetch_registers)
8173         (sparc_ravenscar_ops::store_registers): Now methods.
8174         (sparc_ravenscar_prepare_to_store): Remove.
8175         (sparc_ravenscar_ops): Redefine.
8176         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8177         methods and destructor.  Remove members.
8178         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8179         (ravenscar_thread_target::store_registers)
8180         (ravenscar_thread_target::prepare_to_store): Update.
8181         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8182         Remove.
8183         (struct ppc_ravenscar_powerpc_ops): Derive from
8184         ravenscar_arch_ops.
8185         (ppc_ravenscar_powerpc_ops::fetch_registers)
8186         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8187         (ppc_ravenscar_powerpc_ops): Redefine.
8188         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8189         (ppc_ravenscar_e500_ops::fetch_registers)
8190         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8191         (ppc_ravenscar_e500_ops): Redefine.
8192         * aarch64-ravenscar-thread.c
8193         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8194         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8195         (aarch64_ravenscar_fetch_registers)
8196         (aarch64_ravenscar_store_registers): Now methods.
8197         (aarch64_ravenscar_ops): Redefine.
8198
8199 2019-02-15  Tom Tromey  <tromey@adacore.com>
8200
8201         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8202         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8203         (ravenscar_thread_target::stopped_by_watchpoint)
8204         (ravenscar_thread_target::stopped_data_address)
8205         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8206
8207 2019-02-15  Tom Tromey  <tromey@adacore.com>
8208
8209         * ravenscar-thread.c: Fix some typos.
8210
8211 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8212             Tom Tromey  <tromey@adacore.com>
8213
8214         * ada-lang.c (ada_exception_sal): Change addr_string to a
8215         std::string.
8216         (create_ada_exception_catchpoint): Update.
8217
8218 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8219             Tom Tromey  <tromey@adacore.com>
8220
8221         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8222         (bp_location_ops): Remove.
8223         (base_breakpoint_allocate_location): Update.
8224         (free_bp_location): Update.
8225         * ada-lang.c (class ada_catchpoint_location)
8226         <ada_catchpoint_location>: Remove ops parameter.
8227         (ada_catchpoint_location_dtor): Remove.
8228         (ada_catchpoint_location_ops): Remove.
8229         (allocate_location_exception): Update.
8230         * breakpoint.h (struct bp_location_ops): Remove.
8231         (class bp_location) <bp_location>: Remove bp_location_ops
8232         parameter.
8233         <~bp_location>: Add destructor.
8234         <ops>: Remove.
8235
8236 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8237             Pedro Alves  <palves@redhat.com>
8238
8239         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8240         'PATH_MAX'.
8241
8242 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8243             Samuel Thibault  <samuel.thibault@gnu.org>
8244             Thomas Schwinge  <thomas@codesourcery.com>
8245
8246         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8247         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8248
8249 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8250
8251         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8252         (check_empty): Use "const char *".
8253
8254         * gnu-nat.c (gnu_nat_target::detach): Instead of
8255         'detach_inferior (pid)' call
8256         'detach_inferior (find_inferior_pid (pid))'.
8257
8258         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8259         'nat/fork-inferior.o'.
8260         * gnu-nat.c: #include "nat/fork-inferior.h".
8261
8262         * gnu-nat.c (gnu_nat_target::detach): Instead of
8263         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8264         * gnu-nat.h: #include "inf-child.h".
8265         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8266         'i386_gnu_nat_target::fetch_registers'.
8267         (gnu_store_registers): Rename/move to
8268         'i386_gnu_nat_target::store_registers'.
8269
8270         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8271         * gnu-nat.h (mach_thread_info): New function.
8272         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8273
8274         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8275
8276 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8277
8278         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8279
8280 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8281
8282         * windows-nat.c (windows_add_thread): Add new parameter
8283         "main_thread_p" with default value set to false.  Update
8284         function documentation as well as all callers.
8285         (windows_delete_thread): Likewise.
8286         (fake_create_process): Update call to windows_add_thread.
8287         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8288         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8289         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8290         call to windows_delete_thread.
8291
8292 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8293
8294         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8295
8296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8297
8298         * symfile.c (find_separate_debug_file): Use canonical path of
8299         sysroot with child_path instead of gdb_sysroot if it is valid.
8300
8301 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8302
8303         * symfile.c (find_separate_debug_file): Use child_path to
8304         determine if an object file is under a sysroot.
8305
8306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8307
8308         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8309         unittests/child-path-selftests.c.
8310         * common/pathstuff.c (child_path): New function.
8311         * common/pathstuff.h (child_path): New prototype.
8312         * unittests/child-path-selftests.c: New file.
8313
8314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8315
8316         * symfile.c (find_separate_debug_file): Look for separate debug
8317         files in debug directories under the sysroot.
8318
8319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8320
8321         * symtab.h (struct minimal_symbol data_p): New const method.
8322         (struct minimal_symbol text_p): Likewise.
8323         * symtab.c (output_source_filename): Use file name style
8324         to print file name.
8325         (print_symbol_info): Likewise.
8326         (print_msymbol_info): Use address style to print addresses.
8327         Use function name style to print executable text symbols.
8328         (expand_symtab_containing_pc): Use data_p.
8329         (find_pc_sect_compunit_symtab): Likewise.
8330
8331 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8332
8333         * breakpoint.c (describe_other_breakpoints): Use address style
8334         to print addresses.
8335         (say_where): Likewise.
8336
8337 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8338
8339         * ada-typeprint.c (print_func_type): Print function name
8340         style to print function name.
8341         * c-typeprint.c (c_print_type_1): Likewise.
8342
8343 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8344
8345         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8346         for execve.
8347
8348 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8349
8350         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8351         type_stack.
8352
8353 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8354
8355         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8356         TYPE_CODE_REF types.
8357
8358 2019-02-08  Jim Wilson  <jimw@sifive.com>
8359
8360         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8361         (riscv_linux_fregset): New.
8362         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8363
8364 2019-02-07  Tom Tromey  <tom@tromey.com>
8365
8366         * thread.c (thread_cancel_execution_command): Update.
8367         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8368         methods.
8369         (struct thread_fsm_ops): Remove.
8370         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8371         (thread_fsm_should_stop, thread_fsm_return_value)
8372         (thread_fsm_set_finished, thread_fsm_finished_p)
8373         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8374         Don't declare.
8375         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8376         * infrun.c (clear_proceed_status_thread)
8377         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8378         (print_stop_event): Update.
8379         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8380         Add constructor.
8381         (step_command_fsm_ops): Remove.
8382         (new_step_command_fsm): Remove.
8383         (step_1): Update.
8384         (step_command_fsm::should_stop): Rename from
8385         step_command_fsm_should_stop.
8386         (step_command_fsm::clean_up): Rename from
8387         step_command_fsm_clean_up.
8388         (step_command_fsm::do_async_reply_reason): Rename from
8389         step_command_fsm_async_reply_reason.
8390         (struct until_next_fsm): Inherit from thread_fsm.  Add
8391         constructor.
8392         (until_next_fsm_ops): Remove.
8393         (new_until_next_fsm): Remove.
8394         (until_next_fsm::should_stop): Rename from
8395         until_next_fsm_should_stop.
8396         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8397         (until_next_fsm::do_async_reply_reason): Rename from
8398         until_next_fsm_async_reply_reason.
8399         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8400         constructor.  Change type of breakpoint.
8401         (finish_command_fsm_ops): Remove.
8402         (new_finish_command_fsm): Remove.
8403         (finish_command_fsm::should_stop): Rename from
8404         finish_command_fsm_should_stop.
8405         (finish_command_fsm::clean_up): Rename from
8406         finish_command_fsm_clean_up.
8407         (finish_command_fsm::return_value): Rename from
8408         finish_command_fsm_return_value.
8409         (finish_command_fsm::do_async_reply_reason): Rename from
8410         finish_command_fsm_async_reply_reason.
8411         (finish_command): Update.
8412         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8413         Add constructor.
8414         (call_thread_fsm_ops): Remove.
8415         (call_thread_fsm::call_thread_fsm): Rename from
8416         new_call_thread_fsm.
8417         (call_thread_fsm::should_stop): Rename from
8418         call_thread_fsm_should_stop.
8419         (call_thread_fsm::should_notify_stop): Rename from
8420         call_thread_fsm_should_notify_stop.
8421         (run_inferior_call, call_function_by_hand_dummy): Update.
8422         * cli/cli-interp.c (should_print_stop_to_console): Update.
8423         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8424         Add constructor.  Change type of location_breakpoint,
8425         caller_breakpoint.
8426         (until_break_fsm_ops): Remove.
8427         (new_until_break_fsm): Remove.
8428         (until_break_fsm::should_stop): Rename from
8429         until_break_fsm_should_stop.
8430         (until_break_fsm::clean_up): Rename from
8431         until_break_fsm_clean_up.
8432         (until_break_fsm::do_async_reply_reason): Rename from
8433         until_break_fsm_async_reply_reason.
8434         (until_break_command): Update.
8435         * thread-fsm.c: Remove.
8436         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8437
8438 2019-02-07  Tom Tromey  <tom@tromey.com>
8439
8440         * yy-remap.h: Add include guard.
8441         * xtensa-tdep.h: Add include guard.
8442         * xcoffread.h: Rename include guard.
8443         * varobj-iter.h: Add include guard.
8444         * tui/tui.h: Rename include guard.
8445         * tui/tui-winsource.h: Rename include guard.
8446         * tui/tui-wingeneral.h: Rename include guard.
8447         * tui/tui-windata.h: Rename include guard.
8448         * tui/tui-win.h: Rename include guard.
8449         * tui/tui-stack.h: Rename include guard.
8450         * tui/tui-source.h: Rename include guard.
8451         * tui/tui-regs.h: Rename include guard.
8452         * tui/tui-out.h: Rename include guard.
8453         * tui/tui-layout.h: Rename include guard.
8454         * tui/tui-io.h: Rename include guard.
8455         * tui/tui-hooks.h: Rename include guard.
8456         * tui/tui-file.h: Rename include guard.
8457         * tui/tui-disasm.h: Rename include guard.
8458         * tui/tui-data.h: Rename include guard.
8459         * tui/tui-command.h: Rename include guard.
8460         * tic6x-tdep.h: Add include guard.
8461         * target/waitstatus.h: Rename include guard.
8462         * target/wait.h: Rename include guard.
8463         * target/target.h: Rename include guard.
8464         * target/resume.h: Rename include guard.
8465         * target-float.h: Rename include guard.
8466         * stabsread.h: Add include guard.
8467         * rs6000-tdep.h: Add include guard.
8468         * riscv-fbsd-tdep.h: Add include guard.
8469         * regformats/regdef.h: Rename include guard.
8470         * record.h: Rename include guard.
8471         * python/python.h: Rename include guard.
8472         * python/python-internal.h: Rename include guard.
8473         * python/py-stopevent.h: Rename include guard.
8474         * python/py-ref.h: Rename include guard.
8475         * python/py-record.h: Rename include guard.
8476         * python/py-record-full.h: Rename include guard.
8477         * python/py-record-btrace.h: Rename include guard.
8478         * python/py-instruction.h: Rename include guard.
8479         * python/py-events.h: Rename include guard.
8480         * python/py-event.h: Rename include guard.
8481         * procfs.h: Add include guard.
8482         * proc-utils.h: Add include guard.
8483         * p-lang.h: Add include guard.
8484         * or1k-tdep.h: Rename include guard.
8485         * observable.h: Rename include guard.
8486         * nto-tdep.h: Rename include guard.
8487         * nat/x86-linux.h: Rename include guard.
8488         * nat/x86-linux-dregs.h: Rename include guard.
8489         * nat/x86-gcc-cpuid.h: Add include guard.
8490         * nat/x86-dregs.h: Rename include guard.
8491         * nat/x86-cpuid.h: Rename include guard.
8492         * nat/ppc-linux.h: Rename include guard.
8493         * nat/mips-linux-watch.h: Rename include guard.
8494         * nat/linux-waitpid.h: Rename include guard.
8495         * nat/linux-ptrace.h: Rename include guard.
8496         * nat/linux-procfs.h: Rename include guard.
8497         * nat/linux-osdata.h: Rename include guard.
8498         * nat/linux-nat.h: Rename include guard.
8499         * nat/linux-namespaces.h: Rename include guard.
8500         * nat/linux-btrace.h: Rename include guard.
8501         * nat/glibc_thread_db.h: Rename include guard.
8502         * nat/gdb_thread_db.h: Rename include guard.
8503         * nat/gdb_ptrace.h: Rename include guard.
8504         * nat/fork-inferior.h: Rename include guard.
8505         * nat/amd64-linux-siginfo.h: Rename include guard.
8506         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8507         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8508         * nat/aarch64-linux.h: Rename include guard.
8509         * nat/aarch64-linux-hw-point.h: Rename include guard.
8510         * mn10300-tdep.h: Add include guard.
8511         * mips-linux-tdep.h: Add include guard.
8512         * mi/mi-parse.h: Rename include guard.
8513         * mi/mi-out.h: Rename include guard.
8514         * mi/mi-main.h: Rename include guard.
8515         * mi/mi-interp.h: Rename include guard.
8516         * mi/mi-getopt.h: Rename include guard.
8517         * mi/mi-console.h: Rename include guard.
8518         * mi/mi-common.h: Rename include guard.
8519         * mi/mi-cmds.h: Rename include guard.
8520         * mi/mi-cmd-break.h: Rename include guard.
8521         * m2-lang.h: Add include guard.
8522         * location.h: Rename include guard.
8523         * linux-record.h: Rename include guard.
8524         * linux-nat.h: Add include guard.
8525         * linux-fork.h: Add include guard.
8526         * i386-darwin-tdep.h: Rename include guard.
8527         * hppa-linux-offsets.h: Add include guard.
8528         * guile/guile.h: Rename include guard.
8529         * guile/guile-internal.h: Rename include guard.
8530         * gnu-nat.h: Rename include guard.
8531         * gdb-stabs.h: Rename include guard.
8532         * frv-tdep.h: Add include guard.
8533         * f-lang.h: Add include guard.
8534         * event-loop.h: Add include guard.
8535         * darwin-nat.h: Rename include guard.
8536         * cp-abi.h: Rename include guard.
8537         * config/sparc/nm-sol2.h: Rename include guard.
8538         * config/nm-nto.h: Rename include guard.
8539         * config/nm-linux.h: Add include guard.
8540         * config/i386/nm-i386gnu.h: Rename include guard.
8541         * config/djgpp/nl_types.h: Rename include guard.
8542         * config/djgpp/langinfo.h: Rename include guard.
8543         * compile/gcc-cp-plugin.h: Add include guard.
8544         * compile/gcc-c-plugin.h: Add include guard.
8545         * compile/compile.h: Rename include guard.
8546         * compile/compile-object-run.h: Rename include guard.
8547         * compile/compile-object-load.h: Rename include guard.
8548         * compile/compile-internal.h: Rename include guard.
8549         * compile/compile-cplus.h: Rename include guard.
8550         * compile/compile-c.h: Rename include guard.
8551         * common/xml-utils.h: Rename include guard.
8552         * common/x86-xstate.h: Rename include guard.
8553         * common/version.h: Rename include guard.
8554         * common/vec.h: Rename include guard.
8555         * common/tdesc.h: Rename include guard.
8556         * common/selftest.h: Rename include guard.
8557         * common/scoped_restore.h: Rename include guard.
8558         * common/scoped_mmap.h: Rename include guard.
8559         * common/scoped_fd.h: Rename include guard.
8560         * common/safe-iterator.h: Rename include guard.
8561         * common/run-time-clock.h: Rename include guard.
8562         * common/refcounted-object.h: Rename include guard.
8563         * common/queue.h: Rename include guard.
8564         * common/ptid.h: Rename include guard.
8565         * common/print-utils.h: Rename include guard.
8566         * common/preprocessor.h: Rename include guard.
8567         * common/pathstuff.h: Rename include guard.
8568         * common/observable.h: Rename include guard.
8569         * common/netstuff.h: Rename include guard.
8570         * common/job-control.h: Rename include guard.
8571         * common/host-defs.h: Rename include guard.
8572         * common/gdb_wait.h: Rename include guard.
8573         * common/gdb_vecs.h: Rename include guard.
8574         * common/gdb_unlinker.h: Rename include guard.
8575         * common/gdb_unique_ptr.h: Rename include guard.
8576         * common/gdb_tilde_expand.h: Rename include guard.
8577         * common/gdb_sys_time.h: Rename include guard.
8578         * common/gdb_string_view.h: Rename include guard.
8579         * common/gdb_splay_tree.h: Rename include guard.
8580         * common/gdb_setjmp.h: Rename include guard.
8581         * common/gdb_ref_ptr.h: Rename include guard.
8582         * common/gdb_optional.h: Rename include guard.
8583         * common/gdb_locale.h: Rename include guard.
8584         * common/gdb_assert.h: Rename include guard.
8585         * common/filtered-iterator.h: Rename include guard.
8586         * common/filestuff.h: Rename include guard.
8587         * common/fileio.h: Rename include guard.
8588         * common/environ.h: Rename include guard.
8589         * common/common-utils.h: Rename include guard.
8590         * common/common-types.h: Rename include guard.
8591         * common/common-regcache.h: Rename include guard.
8592         * common/common-inferior.h: Rename include guard.
8593         * common/common-gdbthread.h: Rename include guard.
8594         * common/common-exceptions.h: Rename include guard.
8595         * common/common-defs.h: Rename include guard.
8596         * common/common-debug.h: Rename include guard.
8597         * common/cleanups.h: Rename include guard.
8598         * common/buffer.h: Rename include guard.
8599         * common/btrace-common.h: Rename include guard.
8600         * common/break-common.h: Rename include guard.
8601         * cli/cli-utils.h: Rename include guard.
8602         * cli/cli-style.h: Rename include guard.
8603         * cli/cli-setshow.h: Rename include guard.
8604         * cli/cli-script.h: Rename include guard.
8605         * cli/cli-interp.h: Rename include guard.
8606         * cli/cli-decode.h: Rename include guard.
8607         * cli/cli-cmds.h: Rename include guard.
8608         * charset-list.h: Add include guard.
8609         * buildsym-legacy.h: Rename include guard.
8610         * bfin-tdep.h: Add include guard.
8611         * ax.h: Rename include guard.
8612         * arm-linux-tdep.h: Add include guard.
8613         * arm-fbsd-tdep.h: Add include guard.
8614         * arch/xtensa.h: Rename include guard.
8615         * arch/tic6x.h: Add include guard.
8616         * arch/i386.h: Add include guard.
8617         * arch/arm.h: Rename include guard.
8618         * arch/arm-linux.h: Rename include guard.
8619         * arch/arm-get-next-pcs.h: Rename include guard.
8620         * arch/amd64.h: Add include guard.
8621         * arch/aarch64-insn.h: Rename include guard.
8622         * arch-utils.h: Rename include guard.
8623         * annotate.h: Add include guard.
8624         * amd64-darwin-tdep.h: Rename include guard.
8625         * aarch64-linux-tdep.h: Add include guard.
8626         * aarch64-fbsd-tdep.h: Add include guard.
8627         * aarch32-linux-nat.h: Add include guard.
8628
8629 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8630
8631         * macrotab.c (macro_define_internal): New function that
8632         factorizes macro_define_object_internal and macro_define_function
8633         code.
8634         (macro_define_object_internal): Use macro_define_internal.
8635         (macro_define_function): Likewise.
8636
8637 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8638
8639         * macrocmd.c (extract_identifier): Return
8640         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8641         callers.
8642
8643 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8644
8645         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8646
8647 2019-02-05  Tom Tromey  <tom@tromey.com>
8648
8649         * target.c (target_stack::unpush): Move assertion earlier.
8650
8651 2019-01-30  Tom Tromey  <tom@tromey.com>
8652
8653         PR python/23615:
8654         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8655         (gdbpy_parse_and_eval): Likewise.
8656         * python/python-internal.h (gdbpy_allow_threads): New class.
8657
8658 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8659
8660         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8661         (aarch64_fbsd_fpregmap): Move earlier.
8662         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8663         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8664         instead of individual calls to trad_frame_set_reg_addr.
8665         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8666         earlier.
8667         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8668         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8669         instead of individual calls to trad_frame_set_reg_addr.
8670
8671 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8672
8673         * CONTRIBUTE: Replace contribution list with wiki link.
8674
8675 2019-01-25  Tom Tromey  <tom@tromey.com>
8676
8677         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8678
8679 2019-01-25  Tom Tromey  <tom@tromey.com>
8680
8681         * xtensa-linux-nat.c: Fix common/ includes.
8682         * xml-support.h: Fix common/ includes.
8683         * xml-support.c: Fix common/ includes.
8684         * x86-linux-nat.c: Fix common/ includes.
8685         * windows-nat.c: Fix common/ includes.
8686         * varobj.h: Fix common/ includes.
8687         * varobj.c: Fix common/ includes.
8688         * value.c: Fix common/ includes.
8689         * valops.c: Fix common/ includes.
8690         * utils.c: Fix common/ includes.
8691         * unittests/xml-utils-selftests.c: Fix common/ includes.
8692         * unittests/utils-selftests.c: Fix common/ includes.
8693         * unittests/unpack-selftests.c: Fix common/ includes.
8694         * unittests/tracepoint-selftests.c: Fix common/ includes.
8695         * unittests/style-selftests.c: Fix common/ includes.
8696         * unittests/string_view-selftests.c: Fix common/ includes.
8697         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8698         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8699         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8700         * unittests/rsp-low-selftests.c: Fix common/ includes.
8701         * unittests/parse-connection-spec-selftests.c: Fix common/
8702         includes.
8703         * unittests/optional-selftests.c: Fix common/ includes.
8704         * unittests/offset-type-selftests.c: Fix common/ includes.
8705         * unittests/observable-selftests.c: Fix common/ includes.
8706         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8707         * unittests/memrange-selftests.c: Fix common/ includes.
8708         * unittests/memory-map-selftests.c: Fix common/ includes.
8709         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8710         * unittests/function-view-selftests.c: Fix common/ includes.
8711         * unittests/environ-selftests.c: Fix common/ includes.
8712         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8713         * unittests/common-utils-selftests.c: Fix common/ includes.
8714         * unittests/cli-utils-selftests.c: Fix common/ includes.
8715         * unittests/array-view-selftests.c: Fix common/ includes.
8716         * ui-file.c: Fix common/ includes.
8717         * tui/tui-io.c: Fix common/ includes.
8718         * tracepoint.h: Fix common/ includes.
8719         * tracepoint.c: Fix common/ includes.
8720         * tracefile-tfile.c: Fix common/ includes.
8721         * top.h: Fix common/ includes.
8722         * top.c: Fix common/ includes.
8723         * thread.c: Fix common/ includes.
8724         * target/waitstatus.h: Fix common/ includes.
8725         * target/waitstatus.c: Fix common/ includes.
8726         * target.h: Fix common/ includes.
8727         * target.c: Fix common/ includes.
8728         * target-memory.c: Fix common/ includes.
8729         * target-descriptions.c: Fix common/ includes.
8730         * symtab.h: Fix common/ includes.
8731         * symfile.c: Fix common/ includes.
8732         * stap-probe.c: Fix common/ includes.
8733         * spu-linux-nat.c: Fix common/ includes.
8734         * sparc-nat.c: Fix common/ includes.
8735         * source.c: Fix common/ includes.
8736         * solib.c: Fix common/ includes.
8737         * solib-target.c: Fix common/ includes.
8738         * ser-unix.c: Fix common/ includes.
8739         * ser-tcp.c: Fix common/ includes.
8740         * ser-pipe.c: Fix common/ includes.
8741         * ser-base.c: Fix common/ includes.
8742         * selftest-arch.c: Fix common/ includes.
8743         * s12z-tdep.c: Fix common/ includes.
8744         * rust-exp.y: Fix common/ includes.
8745         * rs6000-aix-tdep.c: Fix common/ includes.
8746         * riscv-tdep.c: Fix common/ includes.
8747         * remote.c: Fix common/ includes.
8748         * remote-notif.h: Fix common/ includes.
8749         * remote-fileio.h: Fix common/ includes.
8750         * remote-fileio.c: Fix common/ includes.
8751         * regcache.h: Fix common/ includes.
8752         * regcache.c: Fix common/ includes.
8753         * record-btrace.c: Fix common/ includes.
8754         * python/python.c: Fix common/ includes.
8755         * python/py-type.c: Fix common/ includes.
8756         * python/py-inferior.c: Fix common/ includes.
8757         * progspace.h: Fix common/ includes.
8758         * producer.c: Fix common/ includes.
8759         * procfs.c: Fix common/ includes.
8760         * proc-api.c: Fix common/ includes.
8761         * printcmd.c: Fix common/ includes.
8762         * ppc-linux-nat.c: Fix common/ includes.
8763         * parser-defs.h: Fix common/ includes.
8764         * osdata.c: Fix common/ includes.
8765         * obsd-nat.c: Fix common/ includes.
8766         * nat/x86-linux.c: Fix common/ includes.
8767         * nat/x86-linux-dregs.c: Fix common/ includes.
8768         * nat/x86-dregs.h: Fix common/ includes.
8769         * nat/x86-dregs.c: Fix common/ includes.
8770         * nat/ppc-linux.c: Fix common/ includes.
8771         * nat/mips-linux-watch.h: Fix common/ includes.
8772         * nat/mips-linux-watch.c: Fix common/ includes.
8773         * nat/linux-waitpid.c: Fix common/ includes.
8774         * nat/linux-ptrace.h: Fix common/ includes.
8775         * nat/linux-ptrace.c: Fix common/ includes.
8776         * nat/linux-procfs.c: Fix common/ includes.
8777         * nat/linux-personality.c: Fix common/ includes.
8778         * nat/linux-osdata.c: Fix common/ includes.
8779         * nat/linux-namespaces.c: Fix common/ includes.
8780         * nat/linux-btrace.h: Fix common/ includes.
8781         * nat/linux-btrace.c: Fix common/ includes.
8782         * nat/fork-inferior.c: Fix common/ includes.
8783         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8784         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8785         * nat/aarch64-linux.c: Fix common/ includes.
8786         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8787         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8788         * namespace.h: Fix common/ includes.
8789         * mips-linux-tdep.c: Fix common/ includes.
8790         * minsyms.c: Fix common/ includes.
8791         * mi/mi-parse.h: Fix common/ includes.
8792         * mi/mi-main.c: Fix common/ includes.
8793         * mi/mi-cmd-env.c: Fix common/ includes.
8794         * memrange.h: Fix common/ includes.
8795         * memattr.c: Fix common/ includes.
8796         * maint.h: Fix common/ includes.
8797         * maint.c: Fix common/ includes.
8798         * main.c: Fix common/ includes.
8799         * machoread.c: Fix common/ includes.
8800         * location.c: Fix common/ includes.
8801         * linux-thread-db.c: Fix common/ includes.
8802         * linux-nat.c: Fix common/ includes.
8803         * linux-fork.c: Fix common/ includes.
8804         * inline-frame.c: Fix common/ includes.
8805         * infrun.c: Fix common/ includes.
8806         * inflow.c: Fix common/ includes.
8807         * inferior.h: Fix common/ includes.
8808         * inferior.c: Fix common/ includes.
8809         * infcmd.c: Fix common/ includes.
8810         * inf-ptrace.c: Fix common/ includes.
8811         * inf-child.c: Fix common/ includes.
8812         * ia64-linux-nat.c: Fix common/ includes.
8813         * i387-tdep.c: Fix common/ includes.
8814         * i386-tdep.c: Fix common/ includes.
8815         * i386-linux-tdep.c: Fix common/ includes.
8816         * i386-linux-nat.c: Fix common/ includes.
8817         * i386-go32-tdep.c: Fix common/ includes.
8818         * i386-fbsd-tdep.c: Fix common/ includes.
8819         * i386-fbsd-nat.c: Fix common/ includes.
8820         * guile/scm-type.c: Fix common/ includes.
8821         * guile/guile.c: Fix common/ includes.
8822         * go32-nat.c: Fix common/ includes.
8823         * gnu-nat.c: Fix common/ includes.
8824         * gdbthread.h: Fix common/ includes.
8825         * gdbarch-selftests.c: Fix common/ includes.
8826         * gdb_usleep.c: Fix common/ includes.
8827         * gdb_select.h: Fix common/ includes.
8828         * gdb_bfd.c: Fix common/ includes.
8829         * gcore.c: Fix common/ includes.
8830         * fork-child.c: Fix common/ includes.
8831         * findvar.c: Fix common/ includes.
8832         * fbsd-nat.c: Fix common/ includes.
8833         * event-top.c: Fix common/ includes.
8834         * event-loop.c: Fix common/ includes.
8835         * dwarf2read.c: Fix common/ includes.
8836         * dwarf2loc.c: Fix common/ includes.
8837         * dwarf2-frame.c: Fix common/ includes.
8838         * dwarf-index-cache.c: Fix common/ includes.
8839         * dtrace-probe.c: Fix common/ includes.
8840         * disasm-selftests.c: Fix common/ includes.
8841         * defs.h: Fix common/ includes.
8842         * csky-tdep.c: Fix common/ includes.
8843         * cp-valprint.c: Fix common/ includes.
8844         * cp-support.h: Fix common/ includes.
8845         * cp-support.c: Fix common/ includes.
8846         * corelow.c: Fix common/ includes.
8847         * completer.h: Fix common/ includes.
8848         * completer.c: Fix common/ includes.
8849         * compile/compile.c: Fix common/ includes.
8850         * compile/compile-loc2c.c: Fix common/ includes.
8851         * compile/compile-cplus-types.c: Fix common/ includes.
8852         * compile/compile-cplus-symbols.c: Fix common/ includes.
8853         * command.h: Fix common/ includes.
8854         * cli/cli-dump.c: Fix common/ includes.
8855         * cli/cli-cmds.c: Fix common/ includes.
8856         * charset.c: Fix common/ includes.
8857         * build-id.c: Fix common/ includes.
8858         * btrace.h: Fix common/ includes.
8859         * btrace.c: Fix common/ includes.
8860         * breakpoint.h: Fix common/ includes.
8861         * breakpoint.c: Fix common/ includes.
8862         * ax.h:
8863         (enum agent_op): Fix common/ includes.
8864         * ax-general.c (struct aop_map): Fix common/ includes.
8865         * ax-gdb.c: Fix common/ includes.
8866         * auxv.c: Fix common/ includes.
8867         * auto-load.c: Fix common/ includes.
8868         * arm-tdep.c: Fix common/ includes.
8869         * arch/riscv.c: Fix common/ includes.
8870         * arch/ppc-linux-common.c: Fix common/ includes.
8871         * arch/i386.c: Fix common/ includes.
8872         * arch/arm.c: Fix common/ includes.
8873         * arch/arm-linux.c: Fix common/ includes.
8874         * arch/arm-get-next-pcs.c: Fix common/ includes.
8875         * arch/amd64.c: Fix common/ includes.
8876         * arch/aarch64.c: Fix common/ includes.
8877         * arch/aarch64-insn.c: Fix common/ includes.
8878         * arch-utils.c: Fix common/ includes.
8879         * amd64-windows-tdep.c: Fix common/ includes.
8880         * amd64-tdep.c: Fix common/ includes.
8881         * amd64-sol2-tdep.c: Fix common/ includes.
8882         * amd64-obsd-tdep.c: Fix common/ includes.
8883         * amd64-nbsd-tdep.c: Fix common/ includes.
8884         * amd64-linux-tdep.c: Fix common/ includes.
8885         * amd64-linux-nat.c: Fix common/ includes.
8886         * amd64-fbsd-tdep.c: Fix common/ includes.
8887         * amd64-fbsd-nat.c: Fix common/ includes.
8888         * amd64-dicos-tdep.c: Fix common/ includes.
8889         * amd64-darwin-tdep.c: Fix common/ includes.
8890         * agent.c: Fix common/ includes.
8891         * ada-lang.h: Fix common/ includes.
8892         * ada-lang.c: Fix common/ includes.
8893         * aarch64-tdep.c: Fix common/ includes.
8894
8895 2019-01-25  Tom Tromey  <tom@tromey.com>
8896
8897         * common/create-version.sh: Use common/version.h.
8898
8899 2019-01-24  Pedro Alves  <palves@redhat.com>
8900
8901         * infrun.c (signal_stop, signal_print, signal_program)
8902         (signal_catch, signal_pass): Now arrays instead of pointers.
8903         (update_signals_program_target, do_target_resume)
8904         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8905         * linux-nat.c (linux_nat_target::pass_signals)
8906         (linux_nat_target::create_inferior, linux_nat_target::attach):
8907         Adjust.
8908         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8909         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8910         * procfs.c (procfs_target::pass_signals): Adjust.
8911         * record-full.c (record_full_target::resume): Adjust.
8912         * remote.c (remote_target::pass_signals)
8913         (remote_target::program_signals): Adjust.
8914         * target-debug.h (target_debug_print_signals): Now takes a
8915         gdb::array_view as parameter.  Adjust.
8916         * target.h (target_ops) <pass_signals, program_signals>: Replace
8917         pointer and length parameters with gdb::array_view.
8918         (target_pass_signals, target_program_signals): Likewise.
8919         * target-delegates.c: Regenerate.
8920
8921 2019-01-24  Pedro Alves  <palves@redhat.com>
8922
8923         * common/forward-scope-exit.h
8924         (forward_scope_exit::forward_scope_exit): Pass arguments to
8925         m_bind_function directly, instead of creating a std::bind and
8926         copying that.
8927
8928 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8929
8930         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8931         for static members.
8932         (pass_in_v_vfp_candidate): Likewise.
8933
8934 2019-01-23  Tom Tromey  <tom@tromey.com>
8935             Pedro Alves  <palves@redhat.com>
8936
8937         * regcache.c (class regcache_invalidator): Remove.
8938         (regcache::raw_write): Use make_scope_exit.
8939
8940 2019-01-23  Tom Tromey  <tom@tromey.com>
8941
8942         * ui-out.h (class ui_out_emit_type): Update comment.
8943
8944 2019-01-23  Tom Tromey  <tom@tromey.com>
8945
8946         * infrun.c (fetch_inferior_event): Update comment.
8947
8948 2019-01-23  Tom Tromey  <tom@tromey.com>
8949             Pedro Alves  <palves@redhat.com>
8950
8951         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8952         parameter.
8953         (fetch_inferior_event): Use SCOPE_EXIT.
8954
8955
8956 2019-01-23  Tom Tromey  <tom@tromey.com>
8957             Pedro Alves  <palves@redhat.com>
8958
8959         * infrun.c (disable_thread_events): Delete.
8960         (stop_all_threads): Use SCOPE_EXIT.
8961
8962 2019-01-23  Tom Tromey  <tom@tromey.com>
8963             Pedro Alves  <palves@redhat.com>
8964
8965         * symfile.c: Include forward-scope-exit.h.
8966         (clear_symtab_users_cleanup): Replace forward declaration with
8967         a FORWARD_SCOPE_EXIT.
8968         (syms_from_objfile_1): Use the forward_scope_exit and
8969         gdb::optional instead of cleanup_function.
8970         (reread_symbols): Use the forward_scope_exit instead of
8971         cleanup_function.
8972         (clear_symtab_users_cleanup): Remove function.
8973
8974 2019-01-23  Tom Tromey  <tom@tromey.com>
8975             Pedro Alves  <palves@redhat.com>
8976
8977         * linux-nat.c: Include scope-exit.h.
8978         (cleanup_target_stop): Remove.
8979         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8980         SCOPE_EXIT.
8981
8982 2019-01-23  Tom Tromey  <tom@tromey.com>
8983             Pedro Alves  <palves@redhat.com>
8984
8985         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8986         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8987
8988 2019-01-23  Tom Tromey  <tom@tromey.com>
8989             Andrew Burgess  <andrew.burgess@embecosm.com>
8990             Pedro Alves  <palves@redhat.com>
8991
8992         * infrun.c (fetch_inferior_event): Use scope_exit.
8993         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8994         * top.c (execute_command): Use scope_exit.
8995         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8996         * utils.c (do_bpstat_clear_actions_cleanup)
8997         (make_bpstat_clear_actions_cleanup): Remove.
8998
8999 2019-01-23  Tom Tromey  <tom@tromey.com>
9000             Pedro Alves  <palves@redhat.com>
9001
9002         * infrun.c: Include "common/scope-exit.h"
9003         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9004         (wait_for_inferior): Use SCOPE_EXIT.
9005         (fetch_inferior_event): Use scope_exit.
9006
9007 2019-01-23  Tom Tromey  <tom@tromey.com>
9008             Pedro Alves  <palves@redhat.com>
9009
9010         * breakpoint.c (create_breakpoint): Remove cleanup.
9011
9012 2019-01-23  Tom Tromey  <tom@tromey.com>
9013             Andrew Burgess  <andrew.burgess@embecosm.com>
9014             Pedro Alves  <palves@redhat.com>
9015
9016 2019-01-23  Pedro Alves  <palves@redhat.com>
9017
9018         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9019
9020 2019-01-23  Pedro Alves  <palves@redhat.com>
9021             Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * gdbthread.h: Include "common/forward-scope-exit.h".
9024         (scoped_finish_thread_state): Redefine custom class in terms of
9025         forward_scope_exit.
9026
9027 2019-01-23  Pedro Alves  <palves@redhat.com>
9028             Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * common/forward-scope-exit.h: New file.
9031
9032 2019-01-23  Pedro Alves  <palves@redhat.com>
9033             Andrew Burgess  <andrew.burgess@embecosm.com>
9034             Tom Tromey  <tom@tromey.com>
9035
9036         * common/scope-exit.h: New file.
9037
9038 2019-01-23  Pedro Alves  <palves@redhat.com>
9039
9040         * common/preprocessor.h (ESC): Rename to ...
9041         (ESC_PARENS): ... this.
9042         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9043         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9044
9045 2019-01-23  Tom Tromey  <tom@tromey.com>
9046
9047         * language.h (class scoped_switch_to_sym_language_if_auto):
9048         Initialize m_lang in both cases.
9049
9050 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9051
9052         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9053         with XCNEW.
9054
9055 2019-01-22  Tom Tromey  <tom@tromey.com>
9056
9057         * corelow.c: Do not include sys/file.h.
9058
9059 2019-01-22  Tom Tromey  <tom@tromey.com>
9060
9061         * tui/tui-wingeneral.h: Include gdb_curses.h.
9062
9063 2019-01-22  Tom Tromey  <tom@tromey.com>
9064
9065         * source-cache.h (class source_cache) <get_source_lines,
9066         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9067
9068 2019-01-22  Tom Tromey  <tom@tromey.com>
9069
9070         * remote-fileio.h (struct remote_target): Declare.
9071
9072 2019-01-22  Tom Tromey  <tom@tromey.com>
9073
9074         * python/py-arch.c: Do not include py-ref.h.
9075         * python/py-bpevent.c: Do not include py-ref.h.
9076         * python/py-cmd.c: Do not include py-ref.h.
9077         * python/py-continueevent.c: Do not include py-ref.h.
9078         * python/py-event.h: Do not include py-ref.h.
9079         * python/py-evtregistry.c: Do not include py-ref.h.
9080         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9081         * python/py-frame.c: Do not include py-ref.h.
9082         * python/py-framefilter.c: Do not include py-ref.h.
9083         * python/py-function.c: Do not include py-ref.h.
9084         * python/py-infevents.c: Do not include py-ref.h.
9085         * python/py-linetable.c: Do not include py-ref.h.
9086         * python/py-objfile.c: Do not include py-ref.h.
9087         * python/py-param.c: Do not include py-ref.h.
9088         * python/py-prettyprint.c: Do not include py-ref.h.
9089         * python/py-progspace.c: Do not include py-ref.h.
9090         * python/py-symbol.c: Do not include py-ref.h.
9091         * python/py-symtab.c: Do not include py-ref.h.
9092         * python/py-type.c: Do not include py-ref.h.
9093         * python/py-unwind.c: Do not include py-ref.h.
9094         * python/py-utils.c: Do not include py-ref.h.
9095         * python/py-value.c: Do not include py-ref.h.
9096         * python/py-varobj.c: Do not include py-ref.h.
9097         * python/py-xmethods.c: Do not include py-ref.h.
9098         * python/python.c: Do not include py-ref.h.
9099         * varobj.c: Do not include py-ref.h.
9100
9101 2019-01-22  Tom Tromey  <tom@tromey.com>
9102
9103         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9104         keyword for bcache.
9105
9106 2019-01-22  Tom Tromey  <tom@tromey.com>
9107
9108         * compile/compile-cplus-types.c: Remove a comment by #include.
9109
9110 2019-01-22  Tom Tromey  <tom@tromey.com>
9111
9112         * compile/gcc-c-plugin.h: Include compile-internal.h.
9113
9114 2019-01-22  Tom Tromey  <tom@tromey.com>
9115
9116         * stabsread.c (EXTERN): Do not define.
9117         (symnum, next_symbol_text_func, processing_gcc_compilation)
9118         (within_function, global_sym_chain, global_stabs)
9119         (previous_stab_code, this_object_header_files)
9120         (n_this_object_header_files)
9121         (n_allocated_this_object_header_files): Define.
9122         * stabsread.h (EXTERN): Never define.  Use "extern".
9123
9124 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9125
9126         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9127         history_value.
9128
9129 2019-01-21  Tom Tromey  <tom@tromey.com>
9130
9131         * ui-out.c: Fix includes.
9132         * tui/tui-source.c: Fix includes.
9133         * target.c: Fix includes.
9134         * remote.c: Fix includes.
9135         * regcache.c: Fix includes.
9136         * python/py-block.c: Fix includes.
9137         * printcmd.c: Fix includes.
9138         * or1k-tdep.c: Fix includes.
9139         * mi/mi-main.c: Fix includes.
9140         * m32r-tdep.c: Fix includes.
9141         * csky-tdep.c: Fix includes.
9142         * compile/compile-cplus-types.c: Fix includes.
9143         * cli/cli-interp.c: Fix includes.
9144
9145 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9146
9147         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9148         for padding.
9149
9150 2019-01-16  Tom Tromey  <tom@tromey.com>
9151
9152         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9153         earlier.
9154         (struct objfile) <msymbols_range>: Move from top level.
9155         <msymbols>: New method.
9156         (class objfile_msymbols): Remove.
9157         * symtab.c (default_collect_symbol_completion_matches_break_on):
9158         Update.
9159         * symmisc.c (dump_msymbols): Update.
9160         * stabsread.c (scan_file_globals): Update.
9161         * objc-lang.c (info_selectors_command, info_classes_command)
9162         (find_methods): Update.
9163         * minsyms.c (find_solib_trampoline_target): Update.
9164         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9165         * coffread.c (coff_symfile_read): Update.
9166         * ada-lang.c (ada_lookup_simple_minsym)
9167         (ada_collect_symbol_completion_matches): Update.
9168
9169 2019-01-16  Tom Tromey  <tom@tromey.com>
9170
9171         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9172         type.  Remove no-argument constructor.
9173         <iterator::operator++>: Simplify.
9174         <begin>: Update.
9175         <end>: Use minimal_symbol_count.
9176
9177 2019-01-16  Tom Tromey  <tom@tromey.com>
9178
9179         * objfiles.h (struct objfile) <psymtabs>: New method.
9180         (class objfile_psymtabs): Remove.
9181         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9182         typedef.
9183         <range>: New method.
9184         (require_partial_symbols): Change return type.
9185         * psymtab.c (require_partial_symbols)
9186         (psym_expand_symtabs_matching): Update.
9187         * mdebugread.c (parse_partial_symbols): Update.
9188         * dbxread.c (dbx_end_psymtab): Update.
9189
9190 2019-01-15  Tom Tromey  <tom@tromey.com>
9191
9192         * symtab.c (lookup_objfile_from_block)
9193         (lookup_symbol_in_objfile_symtabs)
9194         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9195         (find_line_symtab, info_sources_command)
9196         (default_collect_symbol_completion_matches_break_on)
9197         (make_source_files_completion_list): Update.
9198         * symmisc.c (print_objfile_statistics, dump_objfile)
9199         (maintenance_print_symbols, maintenance_info_symtabs)
9200         (maintenance_check_symtabs, maintenance_info_line_tables):
9201         Update.
9202         * source.c (select_source_symtab)
9203         (forget_cached_source_info_for_objfile): Update.
9204         * objfiles.h (class objfile_compunits): Remove.
9205         (struct objfile) <compunits_range>: New typedef.
9206         (compunits): New method.
9207         * objfiles.c (objfile_relocate1): Update.
9208         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9209         * maint.c (count_symtabs_and_blocks): Update.
9210         * linespec.c (iterate_over_all_matching_symtabs): Update.
9211         * cp-support.c (add_symbol_overload_list_qualified): Update.
9212         * coffread.c (coff_symtab_read): Update.
9213         * ada-lang.c (add_nonlocal_symbols)
9214         (ada_collect_symbol_completion_matches)
9215         (ada_add_global_exceptions): Update.
9216
9217 2019-01-15  Tom Tromey  <tom@tromey.com>
9218
9219         * progspace.h (program_space) <objfiles_safe_range>: New
9220         typedef.
9221         <objfiles_safe>: New method.
9222         * objfiles.h (class all_objfiles_safe): Remove.
9223         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9224         * jit.c (jit_inferior_exit_hook): Update.
9225
9226 2019-01-17  Tom Tromey  <tom@tromey.com>
9227
9228         * progspace.h (program_space) <objfiles_range>: New typedef.
9229         <objfiles>: New method.
9230         <objfiles_head>: Rename from objfiles.
9231         (object_files): Update.
9232         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9233         * guile/scm-pretty-print.c
9234         (ppscm_find_pretty_printer_from_objfiles): Update.
9235         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9236         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9237         Update.
9238         * python/py-progspace.c (pspy_get_objfiles): Update.
9239         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9240         Update.
9241         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9242         (objfpy_lookup_objfile_by_build_id): Update.
9243         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9244         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9245         Update.
9246         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9247         (expand_symtab_containing_pc, lookup_objfile_from_block)
9248         (lookup_static_symbol, basic_lookup_transparent_type)
9249         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9250         (find_line_symtab, info_sources_command)
9251         (default_collect_symbol_completion_matches_break_on)
9252         (make_source_files_completion_list, find_main_name): Update.
9253         * symmisc.c (print_symbol_bcache_statistics)
9254         (print_objfile_statistics, maintenance_print_symbols)
9255         (maintenance_print_msymbols, maintenance_print_objfiles)
9256         (maintenance_info_symtabs, maintenance_check_symtabs)
9257         (maintenance_expand_symtabs, maintenance_info_line_tables):
9258         Update.
9259         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9260         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9261         (map_overlay_command, unmap_overlay_command)
9262         (simple_overlay_update, expand_symtabs_matching)
9263         (map_symbol_filenames): Update.
9264         * symfile-debug.c (set_debug_symfile): Update.
9265         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9266         Update.
9267         * source.c (select_source_symtab, forget_cached_source_info):
9268         Update.
9269         * solib.c (solib_read_symbols): Update.
9270         * solib-spu.c (append_ocl_sos): Update.
9271         * psymtab.c (maintenance_print_psymbols)
9272         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9273         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9274         * printcmd.c (info_symbol_command): Update.
9275         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9276         Update.
9277         * objfiles.h (class all_objfiles): Remove.
9278         * objfiles.c (have_partial_symbols, have_full_symbols)
9279         (have_minimal_symbols, qsort_cmp, update_section_map)
9280         (shared_objfile_contains_address_p)
9281         (default_iterate_over_objfiles_in_search_order): Update.
9282         * objc-lang.c (info_selectors_command, info_classes_command)
9283         (find_methods): Update.
9284         * minsyms.c (find_solib_trampoline_target): Update.
9285         * maint.c (maintenance_info_sections)
9286         (maintenance_translate_address, count_symtabs_and_blocks):
9287         Update.
9288         * main.c (captured_main_1): Update.
9289         * linux-thread-db.c (try_thread_db_load_from_pdir)
9290         (has_libpthread): Update.
9291         * linespec.c (iterate_over_all_matching_symtabs)
9292         (search_minsyms_for_name): Update.
9293         * jit.c (jit_find_objf_with_entry_addr): Update.
9294         * hppa-tdep.c (find_unwind_entry)
9295         (hppa_lookup_stub_minimal_symbol): Update.
9296         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9297         Update.
9298         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9299         (elf_gnu_ifunc_resolve_by_got): Update.
9300         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9301         * dwarf-index-write.c (save_gdb_index_command): Update.
9302         * cp-support.c (add_symbol_overload_list_qualified): Update.
9303         * breakpoint.c (create_overlay_event_breakpoint)
9304         (create_longjmp_master_breakpoint)
9305         (create_std_terminate_master_breakpoint)
9306         (create_exception_master_breakpoint): Update.
9307         * blockframe.c (find_pc_partial_function): Update.
9308         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9309         (ada_collect_symbol_completion_matches)
9310         (ada_add_global_exceptions): Update.
9311
9312 2019-01-17  Tom Tromey  <tom@tromey.com>
9313
9314         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9315         declare VEC.
9316         (solib_target_parse_libraries): Change return type.
9317         (library_list_start_segment, library_list_start_section)
9318         (library_list_end_library, library_list_start_library); Update.
9319         (solib_target_free_library_list): Remove.
9320         (solib_target_parse_libraries): Remove cleanup.  Change return
9321         type.
9322         (solib_target_current_sos): Update.
9323
9324 2019-01-17  Tom Tromey  <tromey@bapiya>
9325
9326         * valprint.c: Replace "the the" with "the".
9327         * symtab.c: Replace "the the" with "the".
9328         * solib.c: Replace "the the" with "the".
9329         * solib-dsbt.c: Replace "the the" with "the".
9330         * linespec.c: Replace "the the" with "the".
9331         * dwarf2loc.h: Replace "the the" with "the".
9332         * amd64-windows-tdep.c: Replace "the the" with "the".
9333         * aarch64-tdep.c: Replace "the the" with "the".
9334
9335 2019-01-16  Keith Seitz  <keiths@redhat.com>
9336
9337         PR gdb/23773
9338         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9339         <builder>: Rename to ..
9340         <m_builder>: ... this and make private.
9341         (dwarf2_cu::get_builder): New method.  Change all users of
9342         `builder' to use this method.
9343         (dwarf2_start_symtab): Move to ...
9344         (dwarf2_cu::start_symtab): ... here.  Update all callers
9345         (setup_type_unit_groups): Move to ...
9346         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9347         callers.
9348         (dwarf2_cu::reset_builder): New method.
9349         (process_full_compunit, process_full_type_unit): Use
9350         dwarf2_cu::reset_builder.
9351         (follow_die_offset): Record the ancestor CU if it is different
9352         from the followed DIE's CU.
9353         (follow_die_sig_1): Likewise.
9354
9355 2019-01-15  Tom Tromey  <tom@tromey.com>
9356
9357         * remote.c (class remote_state) <buf>: Now a char_vector.
9358         <buf_size>: Remove.
9359         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9360         parameter.
9361         (remote_target::getpkt_or_notif_sane_1)
9362         (remote_target::getpkt_sane)
9363         (remote_target::getpkt_or_notif_sane): Likewise.
9364         (class remote_target) <putpkt>: New overload.
9365         (remote_target::read_frame): Change type of "buf_p".  Remove
9366         sizeof_p parameter.
9367         (packet_ok): New overload.
9368         (packet_check_result): New overload.
9369         Update all uses.
9370
9371 2019-01-14  Tom Tromey  <tom@tromey.com>
9372
9373         * remote-notif.c (handle_notification, remote_notif_ack)
9374         (remote_notif_parse): Make "buf" const.
9375         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9376         const.
9377         (remote_notif_parse, remote_notif_ack, handle_notification):
9378         Likewise.
9379         * remote.c (remote_notif_stop_parse): Make "buf" const.
9380         (remote_target::remote_parse_stop_reply): Make "buf" const.
9381         (remote_notif_stop_ack): Make "buf" const.
9382
9383 2019-01-14  Tom Tromey  <tom@tromey.com>
9384
9385         * remote.c (remote_console_output): Make parameter const.
9386
9387 2019-01-14  Tom Tromey  <tom@tromey.com>
9388
9389         * target-debug.h (target_debug_print_signals): Constify.
9390         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9391         * procfs.c (procfs_target::pass_signals): Update.
9392         * linux-nat.c (linux_nat_target::pass_signals): Update.
9393         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9394         * target-delegates.c: Rebuild.
9395         * remote.c (remote_target::program_signals): Update.
9396         (remote_target::pass_signals): Update.
9397         * target.c (target_pass_signals): Constify argument.
9398         (target_program_signals): Likewise.
9399         * target.h (struct target_ops) <pass_signals, program_signals>:
9400         Constify argument.
9401         (target_pass_signals, target_program_signals): Constify argument.
9402
9403 2019-01-14  Tom Tromey  <tom@tromey.com>
9404
9405         PR tui/28819:
9406         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9407
9408 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9409
9410         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9411         field.
9412         * rs6000-tdep.c: Include reggroups.h.
9413         (IS_V_ALIAS_PSEUDOREG): Define.
9414         (rs6000_register_name): Return names for the "vX" aliases.
9415         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9416         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9417         aliases.  Call default_register_reggroup_p for all other
9418         pseudo-registers.
9419         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9420         New functions.
9421         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9422         Handle "vX" aliases.
9423         (v_alias_pseudo_register_collect): New function.
9424         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9425         (rs6000_gdbarch_init): Initialize "vX" aliases as
9426         pseudo-registers.  Restore registration of
9427         rs6000_pseudo_register_reggroup_p with
9428         set_tdesc_pseudo_register_reggroup_p.
9429
9430 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9431
9432         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9433         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9434         set_gdbarch_num_pseudo_regs.
9435
9436 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9437
9438         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9439         Remove arg prefixname, add do_set and do_show.
9440         Add member functions set_list and show_list.
9441         * cli/cli-style.c (class cli_style_option): Update accordingly.
9442         (style_set_list): Move to file scope.
9443         (style_show_list): Likewise.
9444         (set_style): Call help_list.
9445         (show_style): Call cmd_show_list.
9446         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9447         Update to use the new macro.
9448
9449 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9450
9451         * ada-lang.c (_initialize_ada_language): Expand the help text
9452         for the "catch exception" command.
9453
9454 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9455
9456         * symtab.c (matching_obj_sections): Initialize obj,
9457         declare it closer to its usage.
9458
9459 2019-01-10  Tom Tromey  <tom@tromey.com>
9460
9461         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9462         (basic_inf_threads_range): Remove.
9463         (inf_threads_range, inf_non_exited_threads_range)
9464         (safe_inf_threads_range): Use next_adapter.
9465
9466 2019-01-10  Keith Seitz  <keiths@redhat.com>
9467
9468         PR gdb/23712
9469         PR symtab/23010
9470         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9471         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9472
9473 2019-01-10  Keith Seitz  <keiths@redhat.com>
9474
9475         PR gdb/23712
9476         PR symtab/23010
9477         * dictionary.c (pending_to_vector): Remove.
9478         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9479         Remove _1 suffix, replacing functions of the same name.  Update
9480         all callers.
9481         (dict_create_hashed, dict_create_hashed_expandable)
9482         (dict_create_linear, dict_create_linear_expandable, dict_free)
9483         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9484         Make functions static.
9485
9486 2019-01-10  Keith Seitz  <keiths@redhat.com>
9487
9488         PR gdb/23712
9489         PR symtab/23010
9490         * dictionary.h (struct dictionary): Replace declaration with
9491         multidictionary.
9492         (dict_create_hashed, dict_create_hashed_expandable)
9493         (dict_create_linear, dict_create_linear_expandable)
9494         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9495         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9496         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9497         taking multidictionary argument.
9498         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9499         * block.h (struct block) <dict>: Change to multidictionary
9500         and rename `multidict'.
9501         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9502         symmisc.c: Update all dictionary references to multidictionary.
9503
9504 2019-01-10  Keith Seitz  <keiths@redhat.com>
9505
9506         PR gdb/23712
9507         PR symtab/23010
9508         * dictionary.c: Include unordered_map.
9509         (pending_to_vector): New function.
9510         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9511         Rewrite the non-"_1" functions to take vector instead
9512         of linked list.
9513         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9514         "new" _1 versions of the same name.
9515         (multidictionary): Define.
9516         (std::hash<enum language): New definition.
9517         (collate_pending_symbols_by_language, mdict_create_hashed)
9518         (mdict_create_hashed_expandable, mdict_create_linear)
9519         (mdict_create_linear_expandable, mdict_free)
9520         (find_language_dictionary, create_new_language_dictionary)
9521         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9522         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9523         (mdict_size, mdict_empty): New functions.
9524         * dictionary.h (mdict_iterator): Define.
9525
9526 2019-01-10  Pedro Alves  <palves@redhat.com>
9527
9528         * breakpoint.c (read_uploaded_action)
9529         (create_tracepoint_from_upload): Adjust to use
9530         gdb::unique_xmalloc_ptr.
9531         * ctf.c (ctf_write_uploaded_tp):
9532         (SET_ARRAY_FIELD): Use emplace_back.
9533         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9534         * tracefile-tfile.c (tfile_write_uploaded_tp):
9535         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9536         gdb::unique_xmalloc_ptr.
9537         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9538         at_string, cond_string, cmd_strings>: Replace char pointers
9539         with gdb::unique_xmalloc_ptr.
9540
9541 2019-01-10  Pedro Alves  <palves@redhat.com>
9542
9543         * solib-target.c (library_list_start_library): Don't xstrdup name.
9544
9545 2019-01-10  Pedro Alves  <palves@redhat.com>
9546
9547         * mdebugread.c (parse_partial_symbols): Use
9548         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9549
9550 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9551
9552         * linux-fork.c (scoped_switch_fork_info)
9553         <~scoped_switch_fork_info>: Fix incorrect variable name.
9554
9555 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9556
9557         * linux-fork.c (scoped_switch_fork_info)
9558         <scoped_switch_fork_info>: Make explicit.
9559         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9560
9561 2019-01-10  Tom Tromey  <tom@tromey.com>
9562
9563         * objfiles.h (objfile::reset_psymtabs): Update.
9564         * objfiles.c (objfile::objfile): Update.
9565         * psymtab.h (psymtab_storage::obstack): Update.
9566         (psymtab_storage::m_obstack): Use gdb::optional.
9567         (class psymtab_storage): Update comment.  Remove objfile
9568         parameter.
9569         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9570
9571 2019-01-10  Tom Tromey  <tom@tromey.com>
9572
9573         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9574         <free_psymtabs>: Now private.
9575         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9576         (allocate_psymtab): Use new method.
9577
9578 2019-01-10  Tom Tromey  <tom@tromey.com>
9579
9580         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9581         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9582         * mdebugread.c (parse_partial_symbols): Use
9583         allocate_dependencies.
9584         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9585         allocate_dependencies.
9586         (process_psymtab_comp_unit_reader)
9587         (build_type_psymtab_dependencies): Likewise.
9588         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9589
9590 2019-01-10  Tom Tromey  <tom@tromey.com>
9591
9592         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9593         PSYMBOL_SET_LANGUAGE.
9594         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9595
9596 2019-01-10  Tom Tromey  <tom@tromey.com>
9597
9598         * psymtab.h (psymtab_storage::obstack): New method.
9599         <m_obstack>: Rename from obstack; now private.
9600         * psymtab.c (psymtab_storage): Update.
9601         * dwarf2read.c (create_addrmap_from_index)
9602         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9603         Update.
9604
9605 2019-01-10  Tom Tromey  <tom@tromey.com>
9606
9607         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9608         * objfiles.h (objfile::reset_psymtabs): New method.
9609
9610 2019-01-10  Tom Tromey  <tom@tromey.com>
9611
9612         * symmisc.c (print_symbol_bcache_statistics): Update.
9613         (print_objfile_statistics): Update.
9614         * symfile.c (reread_symbols): Update.
9615         * psymtab.h (class psymtab_storage): New.
9616         * psymtab.c (psymtab_storage): New constructor.
9617         (~psymtab_storage): New destructor.
9618         (require_partial_symbols): Update.
9619         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9620         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9621         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9622         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9623         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9624         (start_psymtab_common, end_psymtab_common)
9625         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9626         (allocate_psymtab): Update.
9627         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9628         Update.
9629         (dump_psymtab_addrmap, maintenance_print_psymbols)
9630         (maintenance_check_psymtabs): Update.
9631         (class objfile_psymtabs): Move to objfiles.h.
9632         * psympriv.h (discard_psymtab): Now inline.
9633         (psymtab_discarder::psymtab_discarder): Update.
9634         (psymtab_discarder::~psymtab_discarder): Update.
9635         (ALL_OBJFILE_PSYMTABS): Rewrite.
9636         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9637         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9638         Remove fields.
9639         <partial_symtabs>: New field.
9640         (class objfile_psymtabs): Move from psymtab.h.  Update.
9641         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9642         psymbol_cache.
9643         (objfile::~objfile): Don't destroy psymbol_cache.
9644         * mdebugread.c (parse_partial_symbols): Update.
9645         * dwarf2read.c (create_addrmap_from_index)
9646         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9647         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9648         (add_partial_subprogram, dwarf2_ranges_read): Update.
9649         * dwarf-index-write.c (write_address_map)
9650         (write_one_signatured_type, recursively_write_psymbols)
9651         (class debug_names, class debug_names, write_psymtabs_to_index):
9652         Update.
9653
9654 2019-01-10  Tom Tromey  <tom@tromey.com>
9655
9656         * symtab.h (SYMBOL_SET_NAMES): Update.
9657         (symbol_set_names): Update.
9658         (MSYMBOL_SET_NAMES): Update.
9659         * symtab.c (symbol_set_names): Change argument to be an
9660         objfile_per_bfd_storage.
9661         * psymtab.c (add_psymbol_to_bcache): Update.
9662         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9663
9664 2019-01-10  Tom Tromey  <tom@tromey.com>
9665
9666         * symtab.c (create_demangled_names_hash): Change argument to be an
9667         objfile_per_bfd_storage.
9668         (symbol_set_names): Update.
9669
9670 2019-01-10  Tom Tromey  <tom@tromey.com>
9671
9672         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9673         init_psymbol_list.
9674         * psymtab.c (init_psymbol_list): Do nothing if already called.
9675         * psympriv.h (init_psymbol_list): Add comment.
9676         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9677         init_psymbol_list.
9678         * dbxread.c (dbx_symfile_read): Unconditionally call
9679         init_psymbol_list.
9680
9681 2019-01-10  Tom Tromey  <tom@tromey.com>
9682
9683         * xcoffread.c (scan_xcoff_symtab): Update.
9684         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9685         "where".
9686         * mdebugread.c (parse_partial_symbols)
9687         (handle_psymbol_enumerators): Update.
9688         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9689         * dbxread.c (read_dbx_symtab): Update.
9690         * psympriv.h (psymbol_placement): New enum.
9691         (add_psymbol_to_list): Update.
9692
9693 2019-01-10  Tom Tromey  <tom@tromey.com>
9694
9695         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9696         static_psymbols parameters.
9697         (scan_xcoff_symtab): Update.
9698         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9699         static_psymbols parameters.
9700         * psympriv.h (start_psymtab_common): Update.
9701         * mdebugread.c (parse_partial_symbols): Update.
9702         * dwarf2read.c (create_partial_symtab): Update.
9703         * dbxread.c (read_dbx_symtab): Update.
9704         (start_psymtab): Remove global_psymbols and static_psymbols
9705         parameters.
9706
9707 2019-01-10  Tom Tromey  <tom@tromey.com>
9708
9709         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9710         * psymtab.c (allocate_psymtab): Add comment.
9711         * psympriv.h (allocate_psymtab): Add comment.
9712         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9713         initializations.
9714         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9715
9716 2019-01-10  Tom Tromey  <tom@tromey.com>
9717
9718         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9719         Don't declare.
9720         * mipsread.c: Include mdebugread.h.
9721         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9722         Declare.
9723         * elfread.c: Include mdebugread.h.
9724
9725 2019-01-09  Tom Tromey  <tom@tromey.com>
9726
9727         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9728         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9729         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9730         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9731         (psym_lookup_symbol, psym_find_last_source_symtab)
9732         (psym_forget_cached_source_info, psym_print_stats)
9733         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9734         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9735         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9736         (psym_find_compunit_symtab_by_address)
9737         (maintenance_print_psymbols, maintenance_info_psymtabs)
9738         (maintenance_check_psymtabs): Use ranged for.
9739         * psymtab.h (class objfile_psymtabs): New.
9740         (require_partial_symbols): Return objfile_psymtabs.
9741         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9742
9743 2019-01-09  Tom Tromey  <tom@tromey.com>
9744
9745         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9746         (find_pc_mapped_section, list_overlays_command)
9747         (map_overlay_command, unmap_overlay_command)
9748         (simple_overlay_update): Use all_objfiles.
9749         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9750         * printcmd.c (info_symbol_command): Use all_objfiles.
9751         * objfiles.h (ALL_OBJSECTIONS): Remove.
9752         * maint.c (maintenance_translate_address): Use all_objfiles.
9753         * gcore.c (gcore_create_callback): Use all_objfiles.
9754         (objfile_find_memory_regions): Likewise.
9755
9756 2019-01-09  Tom Tromey  <tom@tromey.com>
9757
9758         * symtab.c (find_line_symtab, info_sources_command)
9759         (make_source_files_completion_list): Use objfile_compunits.
9760         * source.c (select_source_symtab): Use objfile_compunits.
9761         * objfiles.h (struct objfile): Update comment.
9762         (ALL_OBJFILES): Remove.
9763         (ALL_FILETABS): Remove.
9764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9765         objfile_compunits.
9766
9767 2019-01-09  Tom Tromey  <tom@tromey.com>
9768
9769         * symmisc.c (print_objfile_statistics, dump_objfile)
9770         (maintenance_print_symbols): Use compunit_filetabs.
9771         * source.c (forget_cached_source_info_for_objfile): Use
9772         compunit_filetabs.
9773         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9774         (ALL_FILETABS): Use compunit_filetabs.
9775         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9776         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9777
9778 2019-01-09  Tom Tromey  <tom@tromey.com>
9779
9780         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9781         (compunit_filetabs): New.
9782         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9783         compunit_filetabs.
9784         (info_sources_command, make_source_files_completion_list): Remove
9785         declaration.
9786         * symmisc.c (print_objfile_statistics, dump_objfile)
9787         (maintenance_print_symbols): Remove declaration.
9788         (maintenance_info_symtabs): Use compunit_filetabs.
9789         (maintenance_info_line_tables): Likewise.
9790         * source.c (select_source_symtab): Change local variable name.
9791         (forget_cached_source_info_for_objfile): Remove declaration.
9792         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9793         * objfiles.c (objfile_relocate1): Remove declaration.
9794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9795         declaration.
9796         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9797         * coffread.c (coff_symtab_read): Remove declaration.
9798         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9799         compunit_filetabs.
9800
9801 2019-01-09  Tom Tromey  <tom@tromey.com>
9802
9803         * symtab.c (lookup_objfile_from_block)
9804         (find_pc_sect_compunit_symtab, search_symbols)
9805         (default_collect_symbol_completion_matches_break_on): Use
9806         objfile_compunits.
9807         * objfiles.h (ALL_COMPUNITS): Remove.
9808         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9809         * cp-support.c (add_symbol_overload_list_qualified): Use
9810         objfile_compunits.
9811         * ada-lang.c (ada_collect_symbol_completion_matches)
9812         (ada_add_global_exceptions): Use objfile_compunits.
9813
9814 2019-01-09  Tom Tromey  <tom@tromey.com>
9815
9816         * source.c (select_source_symtab)
9817         (forget_cached_source_info_for_objfile): Remove declaration.
9818         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9819         declaration.
9820         * maint.c (count_symtabs_and_blocks): Remove declaration.
9821         * cp-support.c (add_symbol_overload_list_qualified): Remove
9822         declaration.
9823         * coffread.c (coff_symtab_read): Remove declaration.
9824         * symtab.c (lookup_symbol_in_objfile_symtabs)
9825         (basic_lookup_transparent_type_1): Use objfile_compunits.
9826         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9827         (info_sources_command, search_symbols)
9828         (default_collect_symbol_completion_matches_break_on)
9829         (make_source_files_completion_list): Remove declaration.
9830         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9831         (ada_collect_symbol_completion_matches)
9832         (ada_add_global_exceptions): Remove declaration.
9833         * linespec.c (iterate_over_all_matching_symtabs): Use
9834         objfile_compunits.
9835         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9836         (class objfile_compunits): New.
9837         (ALL_COMPUNITS): Use objfile_compunits.
9838         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9839         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9840         objfile_compunits.
9841         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9842
9843 2019-01-09  Tom Tromey  <tom@tromey.com>
9844
9845         * symtab.c (search_symbols)
9846         (default_collect_symbol_completion_matches_break_on): Use
9847         objfile_msymbols.
9848         * ada-lang.c (ada_lookup_simple_minsym)
9849         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9850         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9851         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9852         objfile_msymbols.
9853         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9854         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9855         * objc-lang.c (find_methods): Use objfile_msymbols.
9856         (info_selectors_command, info_classes_command): Likewise.
9857         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9858         * objfiles.h (class objfile_msymbols): New.
9859         (ALL_OBJFILE_MSYMBOLS): Remove.
9860         (ALL_MSYMBOLS): Remove.
9861
9862 2019-01-09  Tom Tromey  <tom@tromey.com>
9863
9864         * common/next-iterator.h (next_adapter): Add Iterator template
9865         parameter.
9866         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9867         (class all_objfiles_safe): New.
9868         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9869         * objfiles.c (put_objfile_before): Update comment.
9870         (add_separate_debug_objfile): Likewise.
9871         (free_all_objfiles): Use all_objfiles_safe.
9872         (objfile_purge_solibs): Likewise.
9873
9874 2019-01-09  Tom Tromey  <tom@tromey.com>
9875
9876         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9877         (expand_symtab_containing_pc, lookup_static_symbol)
9878         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9879         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9880         all_objfiles.
9881         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9882         * breakpoint.c (create_overlay_event_breakpoint)
9883         (create_longjmp_master_breakpoint)
9884         (create_std_terminate_master_breakpoint)
9885         (create_exception_master_breakpoint): Use all_objfiles.
9886         * linux-thread-db.c (try_thread_db_load_from_pdir)
9887         (has_libpthread): Use all_objfiles.
9888         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9889         * linespec.c (iterate_over_all_matching_symtabs)
9890         (search_minsyms_for_name): Use all_objfiles.
9891         * maint.c (maintenance_info_sections): Use all_objfiles.
9892         * main.c (captured_main_1): Use all_objfiles.
9893         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9894         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9895         * guile/scm-pretty-print.c
9896         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9897         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9898         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9899         (maintenance_print_msymbols): Use all_objfiles.
9900         * source.c (select_source_symtab): Use all_objfiles.
9901         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9902         * symfile.c (remove_symbol_file_command)
9903         (expand_symtabs_matching, map_symbol_filenames): Use
9904         all_objfiles.
9905         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9906         all_objfiles.
9907         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9908         * objc-lang.c (find_methods): Use all_objfiles.
9909         * objfiles.c (have_partial_symbols, have_full_symbols)
9910         (have_minimal_symbols, qsort_cmp)
9911         (default_iterate_over_objfiles_in_search_order): Use
9912         all_objfiles.
9913         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9914         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9915         (maintenance_check_psymtabs): Use all_objfiles.
9916         (ALL_PSYMTABS): Remove.
9917         * compile/compile-object-run.c (do_module_cleanup): Use
9918         all_objfiles.
9919         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9920         * cp-support.c (add_symbol_overload_list_qualified): Use
9921         all_objfiles.
9922         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9923         Use all_objfiles.
9924         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9925         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9926         all_objfiles.
9927         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9928         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9929         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9930         Uses all_objfiles.
9931         * solib.c (solib_read_symbols): Use all_objfiles
9932
9933 2019-01-09  Tom Tromey  <tom@tromey.com>
9934
9935         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9936         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9937         all_objfiles.
9938         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9939         * symmisc.c (print_symbol_bcache_statistics)
9940         (print_objfile_statistics, maintenance_print_objfiles)
9941         (maintenance_info_symtabs, maintenance_check_symtabs)
9942         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9943         all_objfiles.
9944         * source.c (forget_cached_source_info): Use all_objfiles.
9945         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9946         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9947         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9948         * objfiles.c (update_section_map): Use all_objfiles.
9949         (shared_objfile_contains_address_p): Likewise.
9950         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9951         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9952
9953 2019-01-09  Tom Tromey  <tom@tromey.com>
9954
9955         * common/next-iterator.h: New file.
9956         * objfiles.h (class all_objfiles): New.
9957         (struct objfile_iterator): New.
9958
9959 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9960
9961         * NEWS: Move the description of the changed "frame", "select-frame",
9962          and "info frame" commands to the Changed commands section.
9963
9964 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9965
9966         * gdbtypes.c (check_stub_method_group): Remove handling of old
9967         mangling schemes.
9968         * linespec.c (find_methods): Likewise.
9969         * stabsread.c (read_member_functions): Likewise.
9970         * valops.c (search_struct_method): Likewise.
9971         (value_struct_elt_for_reference): Likewise.
9972         * NEWS: Mention this change.
9973
9974 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9975
9976         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9977         print_source_lines.
9978         * source.c (print_source_lines_base): Update line number check.
9979         (print_source_lines): New function.
9980         (source_lines_range::source_lines_range): New function.
9981         * source.h (class source_lines_range): New class.
9982         (print_source_lines): New declaration.
9983
9984 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9985
9986         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9987
9988 2019-01-08  Tom Tromey  <tom@tromey.com>
9989             Simon Marchi  <simon.marchi@ericsson.com>
9990
9991         PR gdb/24060
9992         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9993         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9994         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9995         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9996         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9997         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9998
9999 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10000
10001         * source.c (select_source_symtab): Move header comment to
10002         declaration in source.h.
10003         (forget_cached_source_info_for_objfile): Likewise.
10004         (forget_cached_source_info): Likewise.
10005         (identify_source_line): Likewise.
10006         * source.h (identify_source_line): Move declaration from symtab.h
10007         and add comment from source.c
10008         (print_source_lines): Likewise.
10009         (forget_cached_source_info_for_objfile): Likewise.
10010         (forget_cached_source_info): Likewise.
10011         (select_source_symtab): Likewise.
10012         (enum print_source_lines_flag): Move definition from symtab.h.
10013         * symtab.h (identify_source_line): Move declaration to source.h.
10014         (print_source_lines): Likewise.
10015         (forget_cached_source_info_for_objfile): Likewise.
10016         (forget_cached_source_info): Likewise.
10017         (select_source_symtab): Likewise.
10018         (enum print_source_lines_flag): Move definition to source.h.
10019         * tui/tui-hooks.c: Add 'source.h' include.
10020
10021 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10022
10023         * source.c (print_source_lines_base): Handle requests to print
10024         reverse line number sequences, and guard against empty lines
10025         string.
10026
10027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10028
10029         * source.c (print_source_lines_base): Fix skip of '\r' if next
10030         character is '\n'.
10031
10032 2019-01-06  Tom Tromey  <tom@tromey.com>
10033
10034         * c-exp.y (struct c_parse_state) <macro_original_text,
10035         expansion_obstack>: New member.
10036         (macro_original_text, expansion_obstack): Remove globals.
10037         (scan_macro_expansion, scanning_macro_expansion)
10038         (finished_macro_expansion): Update.
10039         (scan_macro_cleanup): Remove.
10040         (yylex, c_parse): Update.
10041
10042 2019-01-06  Tom Tromey  <tom@tromey.com>
10043
10044         * c-exp.y (struct c_parse_state) <strings>: New member.
10045         (operator_stoken): Update.
10046
10047 2019-01-06  Tom Tromey  <tom@tromey.com>
10048
10049         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10050         (union type_stack_elt) <typelist_val>: Now a pointer to
10051         std::vector.
10052         (type_stack_cleanup): Don't declare.
10053         (push_typelist): Update.
10054         * parse.c (pop_typelist): Return a std::vector.
10055         (push_typelist): Take a std::vector.
10056         (follow_types): Update.  Do not free args.
10057         (type_stack_cleanup): Remove.
10058         * c-exp.y (struct c_parse_state): New.
10059         (cpstate): New global.
10060         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10061         (nonempty_typelist): Update.
10062         (func_mod): Create a new vector.
10063         (c_parse): Create a c_parse_state.
10064         (check_parameter_typelist): Do not delete params.
10065         (function_method): Update.  Do not delete type_list.
10066
10067 2019-01-06  Tom Tromey  <tom@tromey.com>
10068
10069         PR gdb/28155:
10070         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10071         check_typedef.
10072         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10073         (print_return_value): Likewise.
10074
10075 2019-01-05  Tom Tromey  <tom@tromey.com>
10076
10077         * contrib/cleanup_check.py: Remove.
10078         * contrib/gcc-with-excheck: Remove.
10079         * contrib/exsummary.py: Remove.
10080         * contrib/excheck.py: Remove.
10081
10082 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10083
10084         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10085         NULL. Initialize tpprev to NULL instead of assigning it
10086         to NULL on the next statement.
10087         * windows-nat.c (windows_delete_thread): Remove check for
10088         main_thread_id before printing thread exit notifications.
10089         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10090         Remove thread ID check against main_thread_id.
10091         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10092         windows_delete_thread.
10093         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10094
10095 2019-01-04  Tom Tromey  <tom@tromey.com>
10096
10097         * compile/compile.c (_initialize_compile): Use upper case for
10098         metasyntactic variables.
10099         * symmisc.c (_initialize_symmisc): Use upper case for
10100         metasyntactic variables.
10101         * psymtab.c (_initialize_psymtab): Use upper case for
10102         metasyntactic variables.
10103         * demangle.c (demangle_command): Use upper case for metasyntactic
10104         variables.
10105         (_initialize_demangler): Likewise.
10106         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10107         variables.
10108
10109 2019-01-03  Tom Tromey  <tom@tromey.com>
10110
10111         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10112
10113 2019-01-03  Tom Tromey  <tom@tromey.com>
10114
10115         * python/py-symtab.c (salpy_str): Update.
10116         (struct salpy_sal_object) <symtab>: Now a PyObject.
10117         (salpy_dealloc): Update.
10118         (del_objfile_sal): Use gdbpy_ref.
10119
10120 2019-01-03  Tom Tromey  <tom@tromey.com>
10121
10122         * python/py-type.c (convert_field): Use new_reference.  Return
10123         gdbpy_ref.
10124         (make_fielditem): Return gdbpy_ref.
10125         (typy_fields): Update.
10126         (typy_getitem): Update.
10127         (field_name): Return gdbpy_ref.  Use new_reference.
10128         (typy_iterator_iternext): Update.
10129
10130 2019-01-03  Tom Tromey  <tom@tromey.com>
10131
10132         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10133
10134 2019-01-03  Tom Tromey  <tom@tromey.com>
10135
10136         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10137         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10138         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10139         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10140         (pspy_set_type_printers): Likewise.
10141         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10142         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10143         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10144         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10145         (objfpy_set_type_printers): Likewise.
10146
10147 2019-01-03  Tom Tromey  <tom@tromey.com>
10148
10149         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10150         (gdbpy_print_stack): Use gdbpy_err_fetch.
10151         * python/python-internal.h (class gdbpy_err_fetch): New class.
10152         (class gdbpy_enter) <m_error_type, m_error_value,
10153         m_error_traceback>: Remove.
10154         <m_error>: New member.
10155         (gdbpy_exception_to_string): Don't declare.
10156         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10157         * python/py-value.c (convert_value_from_python): Use
10158         gdbpy_err_fetch.
10159         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10160         gdbpy_exception_to_string.
10161         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10162         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10163         gdbpy_err_fetch.
10164
10165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10166
10167         * linux-nat.c (delete_lwp_cleanup): Delete.
10168         (struct lwp_deleter): New struct.
10169         (lwp_info_up): New typedef.
10170         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10171         lwp_info_up.
10172
10173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10174
10175         * linux-fork.c (class scoped_switch_fork_info): New class.
10176         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10177
10178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10179
10180         * valops.c (find_overload_match): Remove use of null_cleanup, and
10181         calls to do_cleanups.
10182
10183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10184
10185         * compile/compile-cplus-types.c
10186         (compile_cplus_instance::decl_name): Handle changes to
10187         cp_func_name.
10188         * cp-support.c (cp_func_name): Update header comment, update
10189         return type.
10190         * cp-support.h (cp_func_name): Update return type in declaration.
10191         * valops.c (find_overload_match): Move temp_func local to top
10192         level of function and change its type.  Use temp_func to hold and
10193         delete temporary string obtained from cp_func_name.
10194
10195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10196
10197         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10198         gdb::char_vector, remove cleanup, and update uses of `msg`.
10199
10200 2019-01-03  Jim Wilson  <jimw@sifive.com>
10201
10202         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10203
10204 2019-01-02  Tom Tromey  <tom@tromey.com>
10205
10206         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10207         (tdesc_parse_xml): Remove cleanups.
10208         * target-descriptions.h (make_cleanup_free_target_description):
10209         Don't declare.
10210         (target_desc_deleter): New struct.
10211         (target_desc_up): New typedef.
10212         * target-descriptions.c (target_desc_deleter::operator()): Rename
10213         from free_target_description.
10214         (make_cleanup_free_target_description): Remove.
10215
10216 2019-01-02  Tom Tromey  <tom@tromey.com>
10217
10218         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10219         constructor, destructor.
10220         (linespec_parser): Remove typedef.
10221         (~linespec_parser): Rename from linespec_parser_delete.
10222         (linespec_lex_to_end, linespec_complete_label)
10223         (linespec_complete): Update.
10224         (decode_line_full): Remove cleanups.
10225         (decode_line_1): Update.
10226
10227 2019-01-02  Tom Tromey  <tom@tromey.com>
10228
10229         * python/python-internal.h (inferior_to_inferior_object): Change
10230         return type.
10231         * python/py-exitedevent.c (create_exited_event_object): Update.
10232         * python/py-inferior.c (inferior_to_inferior_object): Return
10233         gdbpy_ref.
10234         (python_new_inferior, python_inferior_deleted)
10235         (thread_to_thread_object, delete_thread_object)
10236         (build_inferior_list, gdbpy_selected_inferior): Update.
10237         * python/py-infthread.c (create_thread_object): Update.  Also fail
10238         if inferior_to_inferior_object fails.
10239
10240 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10241
10242         * inferior.h (class inferior) <displaced_step_state>: New field.
10243         * infrun.h (struct displaced_step_state): Move here from
10244         infrun.c.  Initialize fields, add constructor.
10245         <inf>: Remove field.
10246         <reset>: New method.
10247         * infrun.c (struct displaced_step_inferior_state): Move to
10248         infrun.h.
10249         (displaced_step_inferior_states): Remove.
10250         (get_displaced_stepping_state): Adust.
10251         (displaced_step_in_progress_any_inferior): Adjust.
10252         (displaced_step_in_progress_thread): Adjust.
10253         (displaced_step_in_progress): Adjust.
10254         (add_displaced_stepping_state): Remove.
10255         (get_displaced_step_closure_by_addr): Adjust.
10256         (remove_displaced_stepping_state): Remove.
10257         (infrun_inferior_exit): Call displaced_step_state.reset.
10258         (use_displaced_stepping): Don't check for NULL.
10259         (displaced_step_prepare_throw): Call
10260         get_displaced_stepping_state.
10261         (displaced_step_fixup): Don't check for NULL.
10262         (prepare_for_detach): Don't check for NULL.
10263
10264 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10265
10266         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10267          in case of call that did not complete.
10268
10269 2019-01-02  Andrey Utkin  <autkin@undo.io>
10270
10271         * symfile.c (find_separate_debug_file): Fix search of debug files for
10272         remote debuggee.
10273
10274 2019-01-02  Tom Tromey  <tom@tromey.com>
10275
10276         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10277         indentation.
10278         * python/py-frame.c (frapy_older): Remove cast.
10279         (frapy_newer): Likewise.
10280         * python/py-breakpoint.c (local_setattro): Remove cast.
10281         * python/py-arch.c (archpy_name): Remove local variable.
10282         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10283
10284 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10285
10286         * unittests/basic_string_view/element_access/char/empty.cc:
10287         Fix year range in copyright header.
10288
10289 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10290
10291         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10292         Delete.
10293         <operator==>: Update with for removed field.
10294         <hash>: Likewise.
10295         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10296         <isa_features>: ...this.
10297         <abi_features>: New field.
10298         (riscv_isa_flen): Update comment.
10299         (riscv_abi_xlen): New declaration.
10300         (riscv_abi_flen): New declaration.
10301         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10302         isa_features.
10303         (riscv_abi_xlen): New function.
10304         (riscv_isa_flen): Update to get answer from isa_features.
10305         (riscv_abi_flen): New function.
10306         (riscv_has_fp_abi): Update to get answer from abi_features.
10307         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10308         xlen and flen.
10309         (riscv_call_info) <xlen, flen>: Update comment.
10310         (riscv_call_arg_struct): Remove invalid assertions
10311         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10312         is removed.
10313         (riscv_gdbarch_init): Gather isa features and abi features
10314         separately, ensure both match on the gdbarch when reusing an old
10315         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10316         a target with 64-bit float hardware.
10317
10318 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10319
10320         * source.c (search_command_helper): Stop reverse search
10321         when line 1 has been searched.
10322
10323 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10324
10325         * record-full.c (record_full_base_target::close): Rewrite
10326         record_full_core_buf_list free logic.
10327
10328 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10329
10330         * break-catch-syscall.c (print_one_catch_syscall): xfree
10331         the last text.
10332
10333 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10334
10335         * top.c (print_gdb_version): Update Copyright year in version
10336         message.
10337
10338 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10339
10340         Update copyright year range in all GDB files.
10341
10342 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10343
10344         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10345
10346 For older changes see ChangeLog-2018.
10347 \f
10348 Local Variables:
10349 mode: change-log
10350 left-margin: 8
10351 fill-column: 74
10352 version-control: never
10353 coding: utf-8
10354 End:
10355