gdb/ChangeLog

   1 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
   4         Call linux_get_hwcap.
   5         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
   6         Likewise.
   7         (aarch64_linux_get_hwcap): Remove function.
   8         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
   9         declaration.
  10         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  11         linux_get_hwcap.
  12         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  13         * linux-tdep.c (linux_get_hwcap): Add function.
  14         (linux_get_hwcap2): Likewise.
  15         * linux-tdep.h (linux_get_hwcap): Add declaration.
  16         (linux_get_hwcap2): Likewise.
  17         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  18         (ppc_linux_get_hwcap2): Likewise.
  19         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  20         linux_get_hwcap.
  21         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  22         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  23         (ppc_linux_nat_target::read_description): Likewise.
  24         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  25         * s390-linux-nat.c: Likewise.
  26         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  27
  28 2019-03-24  Tom Tromey  <tom@tromey.com>
  29
  30         * ada-lang.c (standard_lookup): Simplify initialization.
  31         (ada_lookup_symbol_nonlocal): Simplify return.
  32         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  33         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  34         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  35         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  36         initialization.
  37         * solib.c (solib_global_lookup): Simplify.
  38         * symtab.c (null_block_symbol): Remove.
  39         (symbol_cache_lookup): Simplify returns.
  40         (lookup_language_this): Simplify returns.
  41         (lookup_symbol_aux): Simplify return.
  42         (lookup_local_symbol): Simplify returns.
  43         (lookup_global_symbol_from_objfile): Simplify return.
  44         (lookup_symbol_in_objfile_symtabs)
  45         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  46         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  47         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  48         * cp-namespace.c (cp_lookup_bare_symbol)
  49         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  50         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  51         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  52         (cp_lookup_symbol_via_imports): Simplify initialization.
  53         (find_symbol_in_baseclass): Likewise.
  54         * symtab.h (null_block_symbol): Remove.
  55         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  56         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  57         (d_lookup_symbol_module): Likewise.
  58         (find_symbol_in_baseclass): Simplify initialization.
  59
  60 2019-03-24  Tom Tromey  <tom@tromey.com>
  61
  62         * expression.h: Don't include symtab.h.
  63         (struct block): Forward declare.
  64
  65 2019-03-24  Tom Tromey  <tom@tromey.com>
  66
  67         * c-exp.y (typebase): Remove casts.
  68         * gdbtypes.c (lookup_unsigned_typename, )
  69         (lookup_signed_typename): Remove cast.
  70         * eval.c (parse_to_comma_and_eval): Remove cast.
  71         * parse.c (write_dollar_variable): Remove cast.
  72         * block.h (struct block) <superblock>: Now const.
  73         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
  74         * psymtab.c (psym_map_matching_symbols): Make "block" const.
  75         (map_block): Make "block" const.
  76         * symfile.h (struct quick_symbol_functions)
  77         <map_matching_symbols>: Constify block argument to "callback".
  78         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
  79         const.
  80         (find_pc_sect_compunit_symtab): Make "b" const.
  81         (find_symbol_at_address): Likewise.
  82         (search_symbols): Likewise.
  83         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
  84         (dw2_debug_names_lookup_symbol): Likewise.
  85         (dw2_map_matching_symbols): Update.
  86         * p-valprint.c (pascal_val_print): Remove "block".
  87         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
  88         (aux_add_nonlocal_symbols): Make "block" const.
  89         (resolve_subexp): Remove cast.
  90         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
  91         const.
  92         (iterate_over_file_blocks): Likewise.
  93         * f-exp.y (%union) <bval>: Remove.
  94         * coffread.c (patch_opaque_types): Make "b" const.
  95         * spu-tdep.c (spu_catch_start): Make "block" const.
  96         * c-valprint.c (print_unpacked_pointer): Remove "block".
  97         * symmisc.c (dump_symtab_1): Make "b" const.
  98         (block_depth): Make "block" const.
  99         * d-exp.y (%union) <bval>: Remove.
 100         * cp-support.h (cp_lookup_rtti_type): Update.
 101         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 102         * psymtab.c (psym_lookup_symbol): Make "block" const.
 103         (maintenance_check_psymtabs): Make "b" const.
 104         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 105         (enumerate_locals, enumerate_args): Update.
 106         * python/py-symtab.c (stpy_global_block): Make "block" const.
 107         (stpy_static_block): Likewise.
 108         * inline-frame.c (block_starting_point_at): Make "new_block"
 109         const.
 110         * block.c (find_block_in_blockvector): Make return type const.
 111         (blockvector_for_pc_sect): Make "b" const.
 112         (find_block_in_blockvector): Make "b" const.
 113
 114 2019-03-23  Tom Tromey  <tom@tromey.com>
 115
 116         * varobj.c (varobj_create): Update.
 117         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 118         * printcmd.c (display_command, do_one_display): Don't reset
 119         innermost_block.
 120         * parser-defs.h (enum innermost_block_tracker_type): Move to
 121         expression.h.
 122         (innermost_block): Update comment.
 123         * parse.c (parse_exp_1): Add tracker_types parameter.
 124         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 125         tracker_types parameter.  Reset innermost_block.
 126         (parse_exp_in_context): Remove.
 127         (parse_expression_for_completion): Update.
 128         * objfiles.c (~objfile): Don't reset expression_context_block or
 129         innermost_block.
 130         * expression.h (enum innermost_block_tracker_type): Move from
 131         parser-defs.h.
 132         (parse_exp_1): Add tracker_types parameter.
 133         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 134         reset innermost_block.
 135
 136 2019-03-23  Tom Tromey  <tom@tromey.com>
 137
 138         * objfiles.h: Include bcache.h.
 139
 140 2019-03-23  Tom Tromey  <tom@tromey.com>
 141
 142         * linespec.c (get_current_search_block): Use
 143         scoped_restore_current_language.
 144         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 145
 146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 147             Jiong Wang  <jiong.wang@arm.com>
 148
 149         * aarch64-linux-tdep.c
 150         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 151         section.
 152         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 153
 154 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 155             Jiong Wang  <jiong.wang@arm.com>
 156
 157         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 158         instructions.
 159         (aarch64_analyze_prologue_test): Add PACIASP test.
 160         (aarch64_prologue_prev_register): Unmask PC value.
 161
 162 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 163             Jiong Wang  <jiong.wang@arm.com>
 164
 165         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 166         (aarch64_dwarf2_prev_register): Unmask PC value.
 167         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 168         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 169         DW_CFA_AARCH64_negate_ra_state.
 170         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 171
 172 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 173             Jiong Wang  <jiong.wang@arm.com>
 174
 175         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 176         registers.
 177         (aarch64_pseudo_register_name): Likewise.
 178         (aarch64_pseudo_register_type): Likewise.
 179         (aarch64_pseudo_register_reggroup_p): Likewise.
 180         (aarch64_gdbarch_init): Add pauth registers.
 181         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 182         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 183         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 184         (struct gdbarch_tdep): Add regnum for ra_state.
 185
 186 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 187             Jiong Wang  <jiong.wang@arm.com>
 188
 189         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 190
 191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 192             Jiong Wang  <jiong.wang@arm.com>
 193
 194         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 195         function.
 196         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 197         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 198         (aarch64_gdbarch_init): Add puth registers.
 199         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 200         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 201         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 202
 203 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 204             Jiong Wang  <jiong.wang@arm.com>
 205
 206         * aarch64-linux-nat.c
 207         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 208         * aarch64-linux-tdep.c
 209         (aarch64_linux_core_read_description): Likewise.
 210         (aarch64_linux_get_hwcap): New function.
 211         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 212         (aarch64_linux_get_hwcap): New declaration.
 213
 214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 215             Jiong Wang  <jiong.wang@arm.com>
 216
 217         * aarch64-linux-nat.c
 218         (aarch64_linux_nat_target::read_description): Add pauth param.
 219         * aarch64-linux-tdep.c
 220         (aarch64_linux_core_read_description): Likewise.
 221         * aarch64-tdep.c (struct target_desc): Add in pauth.
 222         (aarch64_read_description): Add pauth param.
 223         (aarch64_gdbarch_init): Likewise.
 224         * aarch64-tdep.h (aarch64_read_description): Likewise.
 225         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 226         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 227         * features/Makefile: Add new files.
 228         * features/aarch64-pauth.c: New file.
 229         * features/aarch64-pauth.xml: New file.
 230
 231 2019-03-20  Tom Tromey  <tromey@adacore.com>
 232
 233         * infrun.c (handle_inferior_event): Rename from
 234         handle_inferior_event_1.  Create a scoped_value_mark.
 235         (handle_inferior_event): Remove.
 236
 237 2019-03-19  Tom Tromey  <tromey@adacore.com>
 238
 239         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 240         * infrun.h (print_stop_event): Add "displays" parameter.
 241         * infrun.c (print_stop_event): Add "displays" parameter.
 242
 243 2019-03-19  Pedro Alves  <palves@redhat.com>
 244
 245         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 246         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 247         to -1.  Fix TABs vs spaces.
 248         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 249         * tui/tui-out.h (tui_ui_out) Add intro comments.
 250         <m_line, m_start_of_line>: In-class initialize, and add describing
 251         comment.
 252
 253 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 254
 255         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 256         variable names.
 257         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 258
 259 2019-03-18  Pedro Alves  <palves@redhat.com>
 260             Eli Zaretskii <eliz@gnu.org>
 261
 262         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 263         m_line and m_start_of_line.
 264
 265 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 266
 267         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 268         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 269         it returns a newline.  This fixes a regression in TU mode, whereby
 270         the next line is output on the same screen line as the user input.
 271
 272 2019-03-18  Tom Tromey  <tromey@adacore.com>
 273
 274         * minsyms.c (minimal_symbol_reader::install): Remove call to
 275         obstack_blank.
 276
 277 2019-03-18  Pedro Alves  <palves@redhat.com>
 278
 279         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 280         New globals.
 281         (apply_style): New, factored out from ...
 282         (apply_ansi_escape): ... this.  Handle reverse video mode.
 283         (tui_set_reverse_mode): New function.
 284         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 285         * tui/tui-winsource.c (tui_show_source_line): Use
 286         tui_set_reverse_mode instead of setting A_STANDOUT.
 287         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 288         New setter methods.
 289
 290 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 291
 292         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 293         Handle tabs.
 294
 295 2019-03-18  Tom Tromey  <tromey@adacore.com>
 296
 297         * ada-lang.c (empty_array): Add "high" parameter.
 298         (ada_evaluate_subexp): Update.
 299
 300 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 301
 302         * unittests/string_view-selftests.c: Define
 303         _initialize_string_view_selftests unconditionally.
 304
 305 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 306
 307         PR gdb/24350
 308         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 309
 310 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 311
 312         PR gdb/24351
 313         * windows-nat.c (display_selector): Fix format specifiers.
 314
 315 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 316
 317         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 318         tui_refill_source_window instead of tui_refresh_win, to update the
 319         current execution line.  This fixes redisplay of the current line
 320         when stepping through the code with "next" or "step".
 321
 322 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 323
 324         * source-cache.c (source_cache::get_source_lines): Call
 325         find_source_lines to initialize s->nlines.  This fixes vertical
 326         scrolling of TUI source window when the DOWN arrow is pressed.
 327
 328 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 329
 330         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 331         linux-thread-db.c (_initialize_thread_db): Likewise.
 332
 333 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 334
 335         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 336         wclrtoeol in tui_show_source_line".  This reverts changes made in
 337         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 338
 339 2019-03-15  Tom Tromey  <tom@tromey.com>
 340
 341         * symtab.h (struct minimal_symbol): Derive from
 342         general_symbol_info.
 343         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 344         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 345         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 346         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 347         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 348         (MSYMBOL_SEARCH_NAME): Update.
 349         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 350         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 351         * minsyms.c (minimal_symbol_reader::record_full): Update.
 352
 353 2019-03-15  Tom Tromey  <tom@tromey.com>
 354
 355         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 356
 357 2019-03-15  Tom Tromey  <tom@tromey.com>
 358
 359         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 360         unique_xmalloc_ptr.
 361         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 362         Update.
 363         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 364         (build_minimal_symbol_hash_tables)
 365         (minimal_symbol_reader::install): Update.
 366
 367 2019-03-15  Tom Tromey  <tom@tromey.com>
 368
 369         * symtab.c (create_demangled_names_hash): Update.
 370         (symbol_set_names): Update.
 371         * objfiles.h (struct objfile_per_bfd_storage)
 372         <demangled_names_hash>: Now an htab_up.
 373         * objfiles.c (objfile_per_bfd_storage): Simplify.
 374
 375 2019-03-15  Tom Tromey  <tom@tromey.com>
 376
 377         * objfiles.h (struct objfile_per_bfd_storage): Declare
 378         destructor.
 379         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 380         New.
 381         (get_objfile_bfd_data): Use new.  Don't initialize
 382         language_of_main.
 383         (free_objfile_per_bfd_storage): Remove.
 384         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 385
 386 2019-03-15  Tom Tromey  <tom@tromey.com>
 387
 388         * symfile.c (reread_symbols): Update.
 389         * objfiles.c (objfile::objfile): Update.
 390         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 391         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 392         comment.
 393         (minimal_symbol_reader::install): Update.
 394         (terminate_minimal_symbol_table): Remove.
 395         * jit.c (jit_object_close_impl): Update.
 396
 397 2019-03-15  Tom Tromey  <tom@tromey.com>
 398
 399         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 400         initializations.
 401
 402 2019-03-15  Tom Tromey  <tom@tromey.com>
 403
 404         * objfiles.h (struct objfile_per_bfd_storage)
 405         <demangled_hash_languages>: Now a bitset.
 406         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 407         (lookup_minimal_symbol): Update.
 408
 409 2019-03-15  Tom Tromey  <tom@tromey.com>
 410
 411         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 412         Don't return the symbol.
 413         * coffread.c (record_minimal_symbol): Use record_full.
 414
 415 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 416
 417         The MS-Windows port of ncurses fails to switch to a color pair if
 418         one or both of the colors are the implicit default colors.  This
 419         change records the default colors when TUI is initialized, and
 420         then specifies them explicitly when a color pair uses the default
 421         colors.  This allows color styling in TUI mode on MS-Windows.
 422
 423         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 424         ncurses_norm_attr.
 425         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 426         colors in ncurses_norm_attr.
 427         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 428         "none", replace it with the default color recorded in
 429         ncurses_norm_attr.
 430
 431 2019-03-14  Tom Tromey  <tromey@adacore.com>
 432
 433         * source-cache.h (class source_cache) <get_source_lines>: Return
 434         std::string.
 435         * source-cache.c (source_cache::extract_lines): Handle case where
 436         first_pos==npos.  Return std::string.
 437         (source_cache::get_source_lines): Update.
 438
 439 2019-03-14  Tom Tromey  <tromey@adacore.com>
 440
 441         * NEWS: Add item for "style sources" commands.
 442         * source-cache.c (source_cache::get_source_lines): Check
 443         source_styling.
 444         * cli/cli-style.c (source_styling): New global.
 445         (_initialize_cli_style): Add "style sources" commands.
 446         (show_style_sources): New function.
 447         * cli/cli-style.h (source_styling): Declare.
 448
 449 2019-03-14  Pedro Alves  <palves@redhat.com>
 450             Tom Tromey  <tromey@adacore.com>
 451
 452         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 453         * tui/tui-winsource.c (tui_refill_source_window): New function,
 454         from...
 455         (tui_horizontal_source_scroll): ... here.  Move some logic.
 456         * cli/cli-style.c (set_style_enabled): Notify new observable.
 457         * tui/tui-hooks.c (tui_redisplay_source): New function.
 458         (tui_attach_detach_observers): Attach or detach
 459         tui_redisplay_source.
 460         * observable.h (source_styling_changed): New observable.
 461         * observable.c: Define source_styling_changed observable.
 462
 463 2019-03-13  Tom Tromey  <tromey@adacore.com>
 464
 465         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 466         (i386_gnu_nat_target::store_registers): Update.
 467         * target-debug.h (target_debug_print_std_string): New macro.
 468         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 469         * windows-tdep.c (display_one_tib): Update.
 470         * tui/tui-stack.c (tui_make_status_line): Update.
 471         * top.c (print_inferior_quit_action): Update.
 472         * thread.c (thr_try_catch_cmd): Update.
 473         (add_thread_with_info): Update.
 474         (thread_target_id_str): Update.
 475         (thr_try_catch_cmd): Update.
 476         (thread_command): Update.
 477         (thread_find_command): Update.
 478         * record-btrace.c (record_btrace_target::info_record)
 479         (record_btrace_resume_thread, record_btrace_target::resume)
 480         (record_btrace_cancel_resume, record_btrace_step_thread)
 481         (record_btrace_target::wait, record_btrace_target::wait)
 482         (record_btrace_target::wait, record_btrace_target::stop): Update.
 483         * progspace.c (print_program_space): Update.
 484         * process-stratum-target.c
 485         (process_stratum_target::thread_address_space): Update.
 486         * linux-fork.c (linux_fork_mourn_inferior)
 487         (detach_checkpoint_command, info_checkpoints_command)
 488         (linux_fork_context): Update.
 489         (linux_fork_detach): Update.
 490         (class scoped_switch_fork_info): Update.
 491         (delete_checkpoint_command): Update.
 492         * infrun.c (follow_fork_inferior): Update.
 493         (follow_fork_inferior): Update.
 494         (proceed_after_vfork_done): Update.
 495         (handle_vfork_child_exec_or_exit): Update.
 496         (follow_exec): Update.
 497         (displaced_step_prepare_throw): Update.
 498         (displaced_step_restore): Update.
 499         (start_step_over): Update.
 500         (resume_1): Update.
 501         (clear_proceed_status_thread): Update.
 502         (proceed): Update.
 503         (print_target_wait_results): Update.
 504         (do_target_wait): Update.
 505         (context_switch): Update.
 506         (stop_all_threads): Update.
 507         (restart_threads): Update.
 508         (finish_step_over): Update.
 509         (handle_signal_stop): Update.
 510         (switch_back_to_stepped_thread): Update.
 511         (keep_going_pass_signal): Update.
 512         (print_exited_reason): Update.
 513         (normal_stop): Update.
 514         * inferior.c (inferior_pid_to_str): Change return type.
 515         (print_selected_inferior): Update.
 516         (add_inferior): Update.
 517         (detach_inferior): Update.
 518         * dummy-frame.c (fprint_dummy_frames): Update.
 519         * dcache.c (dcache_info_1): Update.
 520         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 521         (btrace_fetch, btrace_clear): Update.
 522         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 523         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 524         type.
 525         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 526         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 527         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 528         * gdbarch.c, gdbarch.h: Rebuild.
 529         * gdbarch.sh (core_pid_to_str): Change return type.
 530         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 531         return type.
 532         (windows_nat_target::pid_to_str): Change return type.
 533         (windows_delete_thread): Update.
 534         (windows_nat_target::attach): Update.
 535         (windows_nat_target::files_info): Update.
 536         * target-delegates.c: Rebuild.
 537         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 538         return type.
 539         (sol_thread_target::pid_to_str): Change return type.
 540         * remote.c (class remote_target) <pid_to_str>: Change return
 541         type.
 542         (remote_target::pid_to_str): Change return type.
 543         (extended_remote_target::attach, remote_target::remote_stop_ns)
 544         (remote_target::remote_notif_remove_queued_reply)
 545         (remote_target::push_stop_reply, remote_target::disable_btrace):
 546         Update.
 547         (extended_remote_target::attach): Update.
 548         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 549         type.
 550         (gdbsim_target::pid_to_str): Change return type.
 551         * ravenscar-thread.c (struct ravenscar_thread_target)
 552         <pid_to_str>: Change return type.
 553         (ravenscar_thread_target::pid_to_str): Change return type.
 554         * procfs.c (class procfs_target) <pid_to_str>: Change return
 555         type.
 556         (procfs_target::pid_to_str): Change return type.
 557         (procfs_target::attach): Update.
 558         (procfs_target::detach): Update.
 559         (procfs_target::fetch_registers): Update.
 560         (procfs_target::store_registers): Update.
 561         (procfs_target::wait): Update.
 562         (procfs_target::files_info): Update.
 563         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 564         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 565         return type.
 566         (nto_procfs_target::pid_to_str): Change return type.
 567         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 568         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 569         return type.
 570         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 571         (exit_lwp): Update.
 572         (attach_proc_task_lwp_callback, get_detach_signal)
 573         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 574         (linux_nat_target::resume, wait_lwp, stop_callback)
 575         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 576         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 577         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 578         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 579         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 580         type.
 581         (inf_ptrace_target::attach): Update.
 582         (inf_ptrace_target::files_info): Update.
 583         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 584         type.
 585         (go32_nat_target::pid_to_str): Change return type.
 586         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 587         (gnu_nat_target::wait): Update.
 588         (gnu_nat_target::wait): Update.
 589         (gnu_nat_target::resume): Update.
 590         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 591         (fbsd_nat_target::wait): Update.
 592         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 593         type.
 594         (darwin_nat_target::attach): Update.
 595         * corelow.c (class core_target) <pid_to_str>: Change return type.
 596         (core_target::pid_to_str): Change return type.
 597         * target.c (normal_pid_to_str): Change return type.
 598         (default_pid_to_str): Likewise.
 599         (target_pid_to_str): Change return type.
 600         (target_translate_tls_address): Update.
 601         (target_announce_detach): Update.
 602         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 603         return type.
 604         (bsd_uthread_target::pid_to_str): Change return type.
 605         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 606         type.
 607         (bsd_kvm_target::pid_to_str): Change return type.
 608         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 609         return type.
 610         (aix_thread_target::pid_to_str): Change return type.
 611         * target.h (struct target_ops) <pid_to_str>: Change return type.
 612         (target_pid_to_str, normal_pid_to_str): Likewise.
 613         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 614         type.
 615         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 616         type.
 617         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 618         return type.
 619         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 620         type.
 621         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 622         type.
 623         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 624         return type.
 625
 626 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 627
 628         * NEWS: Mention that the new default MI version is 3.  Mention
 629         changes to the output of commands and events that deal with
 630         multi-location breakpoints.
 631         * breakpoint.c: Include "mi/mi-out.h".
 632         (print_one_breakpoint): Change output syntax if using MI version
 633         >= 3.
 634         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 635         New.
 636         (mi_multi_location_breakpoint_output_fixed): New.
 637         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 638         (mi_cmd_fix_multi_location_breakpoint_output): New.
 639         (mi_multi_location_breakpoint_output_fixed): New.
 640         * mi/mi-cmds.c (mi_cmds): Register command
 641         -fix-multi-location-breakpoint-output.
 642         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 643         interpreter "mi".
 644
 645 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 646
 647         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 648         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 649         instantiate mi_ui_out based on interpreter name.
 650         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 651         * mi/mi-main.c (mi_load_progress): Likewise.
 652
 653 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 654
 655         * NEWS: Combine separate "New targets" sections for 8.3.
 656
 657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 658
 659         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 660         (ppcfbsd_init_abi): Install gdbarch
 661         "fetch_tls_load_module_address" and "get_thread_local_address"
 662         methods.
 663
 664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 665
 666         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 667         (riscv_fbsd_init_abi): Install gdbarch
 668         "fetch_tls_load_module_address" and "get_thread_local_address"
 669         methods.
 670
 671 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 672
 673         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 674         (i386fbsd_init_abi): Install gdbarch
 675         "fetch_tls_load_module_address" and "get_thread_local_address"
 676         methods.
 677
 678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 679
 680         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 681         (amd64fbsd_init_abi): Install gdbarch
 682         "fetch_tls_load_module_address" and "get_thread_local_address"
 683         methods.
 684
 685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 686
 687         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 688         (struct fbsd_pspace_data): New type.
 689         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 690         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 691         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 692         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 693         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 694
 695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 696
 697         * gdbtypes.c (lookup_struct_elt): New function.
 698         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 699         * gdbtypes.h (struct struct_elt): New type.
 700         (lookup_struct_elt): New prototype.
 701
 702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 703
 704         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 705         remove disabled code block.
 706
 707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 708
 709         * gdbarch.sh (get_thread_local_address): New method.
 710         * gdbarch.h, gdbarch.c: Regenerate.
 711         * target.c (target_translate_tls_address): Use
 712         gdbarch_get_thread_local_address if present instead of
 713         target::get_thread_local_address.
 714
 715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 716
 717         * target.h (target::get_thread_local_address): Update comment.
 718
 719 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 720
 721         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 722         objfile->separate_debug_objfile_backlink if not NULL.
 723
 724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 725
 726         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 727         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 728         (amd64bsd_store_inferior_registers): Likewise.
 729         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 730         Enable segment base registers.
 731         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 732         PT_GETFSBASE and PT_GETGSBASE.
 733         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 734         PT_SETGSBASE.
 735         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 736         segment base registers.
 737         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 738
 739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 740
 741         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 742         Update calls to i386_target_description to add 'segments'
 743         parameter.
 744         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 745         add segment base registers.
 746         * arch/i386.c (i386_create_target_description): Add 'segments'
 747         parameter to enable segment base registers.
 748         * arch/i386.h (i386_create_target_description): Likewise.
 749         * features/i386/32bit-segments.xml: New file.
 750         * features/i386/32bit-segments.c: Generate.
 751         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 752         call to i386_target_description to add 'segments' parameter.
 753         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 754         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 755         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 756         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 757         if feature is present.
 758         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 759         Add 'segments' parameter to call to i386_target_description.
 760         (i386_target_description): Add 'segments' parameter to enable
 761         segment base registers.
 762         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 763         to call to i386_target_description.
 764         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 765         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 766         Define I386_NUM_REGS.
 767         (i386_target_description): Add 'segments' parameter to enable
 768         segment base registers.
 769
 770 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 771
 772         PR/24325
 773         * source-cache.c: #undef open and close, to avoid unresolved
 774         externals during linking.
 775
 776 2019-03-12  Tom Tromey  <tromey@adacore.com>
 777
 778         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 779         const.  Add initializers.
 780         (_initialize_remote): Don't initialize ptid globals.
 781
 782 2019-03-12  Pedro Alves  <palves@redhat.com>
 783
 784         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 785
 786 2019-03-12  Pedro Alves  <palves@redhat.com>
 787
 788         * cp-name-parser.y (main): Remove unused 'len' variable.
 789
 790 2019-03-12  Tom Tromey  <tromey@adacore.com>
 791
 792         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 793         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 794
 795 2019-03-12  Tom Tromey  <tromey@adacore.com>
 796
 797         * linux-nat.c (iterate_over_lwps): Update.
 798         (stop_callback): Remove parameter.
 799         (stop_wait_callback, detach_callback, resume_set_callback)
 800         (select_singlestep_lwp_callback, set_ignore_sigint)
 801         (status_callback, resumed_callback, resume_clear_callback)
 802         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 803         data parameter.
 804         (linux_nat_target::detach, linux_nat_target::resume)
 805         (linux_stop_and_wait_all_lwps, select_event_lwp)
 806         (linux_nat_filter_event, linux_nat_wait_1)
 807         (linux_nat_target::kill, linux_nat_target::stop)
 808         (linux_nat_target::stop): Update.
 809         (linux_nat_resume_callback): Change type.
 810         (resume_stopped_resumed_lwps, count_events_callback)
 811         (select_event_lwp_callback): Likewise.
 812         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 813         * arm-linux-nat.c (struct update_registers_data): Remove.
 814         (update_registers_callback): Change type.
 815         (arm_linux_insert_hw_breakpoint1): Update.
 816         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 817         parameter.
 818         (x86_linux_dr_set_addr): Update.
 819         (x86_linux_dr_set_control): Update.
 820         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 821         (iterate_over_lwps): Use gdb::function_view.
 822         * nat/aarch64-linux-hw-point.c (struct
 823         aarch64_dr_update_callback_param): Remove.
 824         (debug_reg_change_callback): Change type.
 825         (aarch64_notify_debug_reg_change): Update.
 826         * s390-linux-nat.c (s390_refresh_per_info): Update.
 827
 828 2019-03-11  Tom Tromey  <tromey@adacore.com>
 829
 830         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 831         redundant assignment to "this_cu".
 832
 833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 834
 835         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 836
 837 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 838
 839         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 840         from...
 841         (rank_one_type): ... this.
 842
 843 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 844
 845         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 846         from...
 847         (rank_one_type): ... this.
 848
 849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 850
 851         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 852         from...
 853         (rank_one_type): ... this.
 854
 855 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 856
 857         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 858         from...
 859         (rank_one_type): ... this.
 860
 861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 862
 863         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 864         from...
 865         (rank_one_type): ... this.
 866
 867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 868
 869         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 870         from...
 871         (rank_one_type): ... this.
 872
 873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 874
 875         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 876         from...
 877         (rank_one_type): ... this.
 878
 879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 880
 881         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 882         from...
 883         (rank_one_type): ... this.
 884
 885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 886
 887         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 888         from...
 889         (rank_one_type): ... this.
 890
 891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 892
 893         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 894         from...
 895         (rank_one_type): ... this.
 896
 897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 898
 899         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 900         from...
 901         (rank_one_type): ... this.
 902
 903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 904
 905         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 906         from...
 907         (rank_one_type): ... this.
 908
 909 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 910
 911         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 912         inferior-events' shows the example events.
 913
 914 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 915
 916         Support styling on native MS-Windows console
 917
 918         PR/24315
 919         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 920         on MS-Windows if $TERM is not defined.
 921
 922         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 923
 924         * posix-hdep.c (gdb_console_fputs):
 925         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 926         functions.
 927         * ui-file.h (gdb_console_fputs): Add prototype.
 928
 929         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 930         back to fputs only if the former returns zero.
 931
 932 2019-03-07  Tom Tromey  <tom@tromey.com>
 933
 934         * symmisc.c (print_symbol_bcache_statistics): Update.
 935         (print_objfile_statistics): Update.
 936         * symfile.c (allocate_symtab): Update.
 937         * stabsread.c: Don't include bcache.h.
 938         * psymtab.h (struct psymbol_bcache): Don't declare.
 939         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 940         (psymbol_bcache_init, psymbol_bcache_free)
 941         (psymbol_bcache_get_bcache): Don't declare.
 942         * psymtab.c (struct psymbol_bcache): Remove.
 943         (psymtab_storage::psymtab_storage): Update.
 944         (psymtab_storage::~psymtab_storage): Update.
 945         (psymbol_bcache_init, psymbol_bcache_free)
 946         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 947         (add_psymbol_to_bcache): Update.
 948         (allocate_psymtab): Update.
 949         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 950         macro_cache>: No longer pointers.
 951         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 952         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 953         * macrotab.c (macro_bcache): Update.
 954         * macroexp.c: Don't include bcache.h.
 955         * gdbtypes.c (check_types_worklist): Update.
 956         (types_deeply_equal): Remove TRY/CATCH.  Update.
 957         * elfread.c (elf_symtab_read): Update.
 958         * dwarf2read.c: Don't include bcache.h.
 959         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 960         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 961         (print_bcache_statistics, bcache_memory_used): Don't declare.
 962         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 963         methods.  Rename all data members.
 964         * bcache.c (struct bcache): Move to bcache.h.
 965         (bcache::expand_hash_table): Rename from expand_hash_table.
 966         (bcache): Remove.
 967         (bcache::insert): Rename from bcache_full.
 968         (bcache::compare): Rename from bcache_compare.
 969         (bcache_xmalloc): Remove.
 970         (bcache::~bcache): Rename from bcache_xfree.
 971         (bcache::print_statistics): Rename from print_bcache_statistics.
 972         (bcache::memory_used): Rename from bcache_memory_used.
 973
 974 2019-03-07  Pedro Alves  <palves@redhat.com>
 975
 976         * infrun.c (normal_stop): Also check for
 977         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 978
 979 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * f-lang.c (value_from_host_double): Moved to...
 982         * value.c (value_from_host_double): ...here.
 983         * value.h (value_from_host_double): Declare.
 984         * guile/scm-math.c (vlscm_convert_typed_number): Use
 985         value_from_host_double.
 986         (vlscm_convert_number): Likewise.
 987         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 988         * python/py-value.c (convert_value_from_python): Likewise.
 989
 990 2019-03-06  Tom Tromey  <tom@tromey.com>
 991
 992         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 993
 994 2019-03-06  Tom Tromey  <tom@tromey.com>
 995
 996         * utils.h (free_current_contents): Don't declare.
 997         * utils.c (free_current_contents): Remove.
 998
 999 2019-03-06  Tom Tromey  <tom@tromey.com>
1000
1001         * top.c (quit_force): Update.
1002         * main.c (captured_command_loop): Update.
1003         * common/new-op.c (operator new): Update.
1004         * common/common-exceptions.c (struct catcher)
1005         <save_cleanup_chain>: Remove member.
1006         (exceptions_state_mc_init): Update.
1007         (exception_try_scope_entry): Return nullptr.
1008         (exception_try_scope_exit, exception_rethrow)
1009         (throw_exception_sjlj, throw_exception_cxx): Update.
1010         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1011         (all_cleanups, do_cleanups, discard_cleanups)
1012         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1013         (restore_cleanups, restore_final_cleanups): Don't declare.
1014         (do_final_cleanups): Remove parameter.
1015         * common/cleanups.c (cleanup_chain, make_cleanup)
1016         (make_cleanup_dtor, all_cleanups, do_cleanups)
1017         (discard_my_cleanups, discard_cleanups)
1018         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1019         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1020         (null_cleanup): Remove.
1021         (do_final_cleanups): Remove parameter.
1022
1023 2019-03-06  Tom Tromey  <tom@tromey.com>
1024
1025         * remote.c (remote_target::remote_parse_stop_reply): Use
1026         unique_xmalloc_ptr.
1027
1028 2019-03-06  Tom Tromey  <tom@tromey.com>
1029
1030         * stabsread.c (struct stabs_field_info): Rename from field_info.
1031         <list, fnlist>: Add initializers.
1032         <obstack>: New member.
1033         (read_member_functions, read_struct_fields, read_baseclasses):
1034         Allocate on obstack.  Don't use cleanups.
1035         (read_one_struct_field, read_member_functions, read_struct_fields)
1036         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1037         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1038         (read_struct_type): Update.
1039
1040 2019-03-06  Tom Tromey  <tom@tromey.com>
1041
1042         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1043         * common/filestuff.h (make_cleanup_close): Don't declare.
1044         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1045         Remove.
1046
1047 2019-03-06  Tom Tromey  <tom@tromey.com>
1048
1049         * solib-aix.c: Use make_scope_exit.
1050
1051 2019-03-06  Tom Tromey  <tom@tromey.com>
1052
1053         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1054         Use make_scope_exit.
1055
1056 2019-03-06  Tom Tromey  <tom@tromey.com>
1057
1058         * solib-svr4.c (disable_probes_interface): Remove parameter.
1059         (svr4_handle_solib_event): Use make_scope_exit.
1060
1061 2019-03-06  Tom Tromey  <tom@tromey.com>
1062
1063         * remote.c (struct stop_reply_deleter): Remove.
1064         (stop_reply_up): Update.
1065         (struct stop_reply): Derive from notif_event.  Don't typedef.
1066         <regcache>: Now a std::vector.
1067         (stop_reply_xfree): Remove.
1068         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1069         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1070         (remote_target::discard_pending_stop_replies): Use delete.
1071         (remote_target::remote_parse_stop_reply): Update.
1072         (remote_target::process_stop_reply): Update.
1073         * remote-notif.h (struct notif_event): Add virtual destructor.
1074         Remove "dtr" member.
1075         (struct notif_client) <alloc_event>: Return a unique_ptr.
1076         (notif_event_xfree): Don't declare.
1077         (notif_event_up): New typedef.
1078         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1079         (notif_event_xfree, do_notif_event_xfree): Remove.
1080         (remote_notif_state_xfree): Update.
1081
1082 2019-03-06  Tom Tromey  <tom@tromey.com>
1083
1084         * infrun.c (displaced_step_clear_cleanup): Now a
1085         forward_scope_exit type.
1086         (displaced_step_prepare_throw): Update.
1087         (displaced_step_fixup): Update.
1088
1089 2019-03-06  Tom Tromey  <tom@tromey.com>
1090
1091         * inferior.h (class inferior): Update comment.
1092         * gdbthread.h (class thread_info): Update comment.
1093
1094 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1095             Tom Tromey  <tom@tromey.com>
1096
1097         * stabsread.h (struct stab_section_list): Remove.
1098         (coffstab_build_psymtabs): Update.
1099         * dbxread.c (symbuf_sections): Now a std::vector.
1100         (sect_idx): New global.
1101         (fill_symbuf): Update.
1102         (coffstab_build_psymtabs): Change type of stabsects parameter.
1103         Update.
1104         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1105         std::vector.
1106         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1107         (coff_locate_sections): Update.
1108         (coff_symfile_read): Remove cleanups.  Update.
1109         (init_stringtab): Add storage parameter.
1110         (free_stringtab, free_stringtab_cleanup): Remove.
1111         (init_lineno): Add storage parameter.
1112         (free_linetab, free_linetab_cleanup): Remove.
1113
1114 2019-03-06  Pedro Alves  <palves@redhat.com>
1115
1116         * linux-fork.c (fork_info::clobber_regs): Delete.
1117         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1118         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1119         comment.  Adjust.
1120         (scoped_switch_fork_info::scoped_switch_fork_info)
1121         (checkpoint_command, linux_fork_context): Adjust
1122         fork_save_infrun_state calls.
1123
1124 2019-03-06  Pedro Alves  <palves@redhat.com>
1125
1126         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1127         (inf_has_multiple_threads): Return 'bool' and rewrite using
1128         inferior_info::threads().
1129
1130 2019-03-06  Pedro Alves  <palves@redhat.com>
1131
1132         * linux-fork.c: Include <list>.
1133         (fork_list): Now a std::list instance.
1134         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1135         (forks_exist_p, find_last_fork): Adjust.
1136         (new_fork): Delete.
1137         (one_fork_p): New.
1138         (add_fork): Adjust.
1139         (free_fork): Delete, folded into fork_info::~fork_info().
1140         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1141         Adjust.
1142         (init_fork_list): Delete.
1143         (linux_fork_killall, linux_fork_mourn_inferior)
1144         (linux_fork_detach, info_checkpoints_command): Adjust.
1145         (_initialize_linux_fork): No longer call init_fork_list.
1146
1147 2019-03-06  Pedro Alves  <palves@redhat.com>
1148
1149         * linux-fork.c (new_fork): New, split out of ...
1150         (add_fork): ... this.  Return void.  Move "first fork" special
1151         case from here, to ...
1152         (checkpoint_command): ... here.
1153         * linux-linux.h (add_fork): Return void.
1154
1155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1158
1159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1160             Chris January  <chris.january@arm.com>
1161             David Lecomber  <david.lecomber@arm.com>
1162
1163         * f-exp.y: New token, UNOP_INTRINSIC.
1164         (exp): New pattern using UNOP_INTRINSIC token.
1165         (f77_keywords): Add 'abs' keyword.
1166         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1167         (value_from_host_double): New function.
1168         (evaluate_subexp_f): Support UNOP_ABS.
1169
1170 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1173         types.
1174
1175 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1178         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1179         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1180
1181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1184
1185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1186             Chris January  <chris.january@arm.com>
1187
1188         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1189         * f-exp.y: Define 'KIND' token.
1190         (exp): New pattern for KIND expressions.
1191         (ptype): Handle types with a kind extension.
1192         (direct_abs_decl): Extend to spot kind extensions.
1193         (f77_keywords): Add 'kind' to the list.
1194         (push_kind_type): New function.
1195         (convert_to_kind_type): New function.
1196         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1197         * parse.c (operator_length_standard): Likewise.
1198         * parser-defs.h (enum type_pieces): Add tp_kind.
1199         * std-operator.def: Add UNOP_KIND.
1200
1201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * f-exp.y (f_parse): Set yydebug.
1204
1205 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * f-lang.c (evaluate_subexp_f): New function.
1208         (exp_descriptor_f): New global.
1209         (f_language_defn): Use exp_descriptor_f instead of
1210         exp_descriptor_standard.
1211
1212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * f-exp.y (struct token): Add comments.
1215         (dot_ops): Remove uppercase versions and the end marker.
1216         (f77_keywords): Likewise.
1217         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1218         entries in the dot_ops array are case insensitive, and use
1219         strncasecmp to compare strings.  Also some whitespace cleanup in
1220         this area.  Similar for the f77_keywords array, except entries in
1221         this list might be case sensitive.
1222
1223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1224
1225         * f-exp.y (struct f77_boolean_val): Add comments.
1226         (boolean_values): Remove uppercase versions, and end marker.
1227         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1228         and use strncasecmp to achieve case insensitivity.  Additionally,
1229         perform whitespace cleanup around this code.
1230
1231 2019-03-06  Tom Tromey  <tromey@adacore.com>
1232
1233         * remote-sim.c (gdbsim_target_open): Use result of
1234         gdb_argv::release.
1235
1236 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1237         Dirk Schubert  <dirk.schubert@arm.com>
1238         Chris January  <chris.january@arm.com>
1239
1240         * eval.c (evaluate_subexp_standard): Call Fortran argument
1241         wrapping logic.
1242         * f-lang.c (struct value): A value which can be passed into a
1243         Fortran function call.
1244         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1245         where appropriate.
1246         (struct type): Value ready for a Fortran function call.
1247         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1248         is needed.
1249         * f-lang.h (fortran_argument_convert): Declaration.
1250         (fortran_preserve_arg_pointer): Declaration.
1251         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1252
1253 2019-03-05  Tom Tromey  <tromey@adacore.com>
1254
1255         * python/py-prettyprint.c (print_string_repr): Remove #if.
1256         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1257
1258 2019-03-05  Tom Tromey  <tromey@adacore.com>
1259
1260         * target.c (the_dummy_target): Move later.  Change type to
1261         "dummy_target".
1262         (initialize_targets): Don't initialize the_dummy_target.
1263
1264 2019-03-05  Tom Tromey  <tromey@adacore.com>
1265
1266         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1267         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1268
1269 2019-03-05  Tom Tromey  <tromey@adacore.com>
1270
1271         * windows-nat.c (windows_nat_target::attach)
1272         (windows_nat_target::detach): Don't call gdb_flush.
1273         * valprint.c (generic_val_print, val_print, val_print_string):
1274         Don't call gdb_flush.
1275         * utils.c (defaulted_query): Don't call gdb_flush.
1276         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1277         * target.c (target_announce_detach): Don't call gdb_flush.
1278         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1279         * remote.c (extended_remote_target::attach): Don't call
1280         gdb_flush.
1281         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1282         * printcmd.c (do_examine): Don't call gdb_flush.
1283         (info_display_command): Don't call gdb_flush.
1284         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1285         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1286         * memattr.c (info_mem_command): Don't call gdb_flush.
1287         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1288         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1289         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1290         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1291         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1292         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1293         (gnu_nat_target::detach): Don't call gdb_flush.
1294         * f-valprint.c (f_val_print): Don't call gdb_flush.
1295         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1296         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1297         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1298         gdb_flush.
1299         * c-valprint.c (c_val_print): Don't call gdb_flush.
1300         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1301
1302 2019-03-05  Tom Tromey  <tromey@adacore.com>
1303
1304         * varobj.c (update_dynamic_varobj_children): Update.
1305         (install_default_visualizer): Use reset, not release.
1306         * value.c (set_internalvar): Update.
1307         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1308         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1309         ATTRIBUTE_UNUSED_RESULT.
1310
1311 2019-03-05  Tom Tromey  <tromey@adacore.com>
1312
1313         * remote.c (class scoped_remote_fd) <release>: Add
1314         ATTRIBUTE_UNUSED_RESULT.
1315
1316 2019-03-05  Tom Tromey  <tromey@adacore.com>
1317
1318         * macroexp.c (struct macro_buffer) <release>: Add
1319         ATTRIBUTE_UNUSED_RESULT.
1320
1321 2019-03-05  Tom Tromey  <tromey@adacore.com>
1322
1323         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1324         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1325         ATTRIBUTE_UNUSED_RESULT.
1326
1327 2019-03-05  Tom Tromey  <tromey@adacore.com>
1328
1329         * common/scoped_fd.h (class scoped_fd) <release>: Add
1330         ATTRIBUTE_UNUSED_RESULT.
1331
1332 2019-03-05  Tom Tromey  <tromey@adacore.com>
1333
1334         * parser-defs.h (struct parser_state) <release>: Add
1335         ATTRIBUTE_UNUSED_RESULT.
1336
1337 2019-03-05  Tom Tromey  <tromey@adacore.com>
1338
1339         * utils.h (class gdb_argv) <release>: Add
1340         ATTRIBUTE_UNUSED_RESULT.
1341         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1342
1343 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1344
1345         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1346         for-loop range, to avoid compiler warnings.
1347
1348         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1349         avoid compiler warnings about unused variables.
1350
1351         * NEWS: Mention end of support for native debugging on MS-Windows
1352         before XP.
1353
1354         PR gdb/24292
1355         * common/netstuff.c:
1356         * gdbserver/gdbreplay.c
1357         * gdbserver/remote-utils.c:
1358         * ser-tcp.c:
1359         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1360         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1361         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1362         'getaddrinfo' and 'freeaddrinfo' were not available before
1363         Windows XP, and mingw.org's MinGW headers by default define
1364         _WIN32_WINNT to 0x500.
1365
1366 2019-03-01  Gary Benson <gbenson@redhat.com>
1367
1368         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1369
1370 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1371             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1372
1373         PR gdb/8527
1374         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1375         set_sigint_trap, clear_sigint_trap.
1376
1377 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1378
1379         * target.c (target_detach): Clear the regcache and the
1380         frame cache.
1381
1382 2019-02-27  Pedro Alves  <palves@redhat.com>
1383
1384         * utils.c (set_screen_size): When we cap the height/width sizes,
1385         tweak the corresponding command variable to show "unlimited":
1386
1387 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1388             Pedro Alves  <palves@redhat.com>
1389
1390         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1391         before calling rl_set_screen_size.
1392
1393 2019-02-27  Tom Tromey  <tromey@adacore.com>
1394
1395         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1396         define.
1397         * python/py-value.c: Remove Python 2.4 workaround.
1398         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1399         workaround.
1400         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1401         Python 2.4 workaround.
1402         * python/python-internal.h: Remove Python 2.4 comment.
1403         (Py_ssize_t): Don't define.
1404         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1405         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1406         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1407         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1408         * python/python.c (do_start_initialization): Remove Python 2.4
1409         workaround.
1410         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1411         (print_children): Remove Python 2.4 workaround.
1412         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1413         workaround.
1414         (CHARBUFFERPROC_NAME): Remove.
1415         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1416         Python 2.4 workaround.
1417
1418 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1419
1420         * NEWS: Note minimum Python version.
1421
1422 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1423
1424         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1425         code from these functions.  Remove corresponding ifdefs.  Use
1426         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1427         Remove gotos and target of gotos.
1428         (infpy_search_memory): Likewise.
1429
1430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1433         (hppa_gdbarch_init): Don't register deleted functions with
1434         gdbarch.
1435
1436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1437
1438         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1439         (h8300_unwind_sp): Delete.
1440         (h8300_dummy_id): Delete.
1441         (h8300_gdbarch_init): Don't register deleted functions with
1442         gdbarch.
1443
1444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1445
1446         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1447         (ft32_unwind_pc): Delete.
1448         (ft32_unwind_sp): Delete.
1449         (ft32_gdbarch_init): Don't register deleted functions with
1450         gdbarch.
1451
1452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1455         (frv_unwind_pc): Delete.
1456         (frv_unwind_sp): Delete.
1457         (frv_gdbarch_init): Don't register deleted functions with
1458         gdbarch.
1459
1460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1463         (riscv_unwind_pc): Delete.
1464         (riscv_unwind_sp): Delete.
1465         (riscv_gdbarch_init): Don't register deleted functions with
1466         gdbarch.
1467
1468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1469
1470         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1471         (csky_unwind_pc): Delete.
1472         (csky_unwind_sp): Delete.
1473         (csky_gdbarch_init): Don't register deleted functions with
1474         gdbarch.
1475
1476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1479         (cris_unwind_pc): Delete.
1480         (cris_unwind_sp): Delete.
1481         (cris_gdbarch_init): Don't register deleted functions with
1482         gdbarch.
1483
1484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1485
1486         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1487         (bfin_unwind_pc): Delete.
1488         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1489
1490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1491
1492         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1493         (arm_unwind_pc): Delete.
1494         (arm_unwind_sp): Delete.
1495         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1496
1497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1500         (arc_unwind_pc): Delete.
1501         (arc_unwind_sp): Delete.
1502         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1503
1504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1507         (alpha_unwind_pc): Delete.
1508         (alpha_gdbarch_init): Don't register deleted functions with
1509         gdbarch.
1510
1511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1514         (aarch64_unwind_pc): Delete.
1515         (aarch64_unwind_sp): Delete.
1516         (aarch64_gdbarch_init): Don't register deleted functions with
1517         gdbarch.
1518
1519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * gdbtypes.c (type_align): Don't consider static members when
1522         computing structure alignment.
1523
1524 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1527         return 0 for other types.
1528         * arch-utils.c (default_type_align): Always return 0.
1529         * gdbarch.h: Regenerate.
1530         * gdbarch.sh (type_align): Extend comment.
1531         * gdbtypes.c (type_align): Add additional comments, always call
1532         gdbarch_type_align before applying the default rules.
1533         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1534         generic code will then apply a suitable default.
1535         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1536         types, return 0 for other types.
1537
1538 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1539
1540         * NEWS: Create a new section for the next release branch.
1541         Rename the section of the current branch, now that it has
1542         been cut.
1543
1544 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1545
1546         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1547         * version.in: Bump version to 8.3.50.DATE-git.
1548
1549 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1550
1551         * aix-thread.c (ptid_cmp): Remove unused variable.
1552         (get_signaled_thread): Likewise.
1553         (store_regs_user_thread): Likewise.
1554         (store_regs_kernel_thread): Likewise.
1555         (fetch_regs_kernel_thread): Remove shadowed variable.
1556
1557 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * features/riscv/32bit-cpu.xml: Add register numbers.
1560         * features/riscv/32bit-fpu.c: Regenerate.
1561         * features/riscv/32bit-fpu.xml: Add register numbers.
1562         * features/riscv/64bit-cpu.xml: Add register numbers.
1563         * features/riscv/64bit-fpu.c: Regenerate.
1564         * features/riscv/64bit-fpu.xml: Add register numbers.
1565
1566 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1567
1568         * NEWS: Mention two argument form of gdb.Value constructor.
1569         * python/py-value.c (convert_buffer_and_type_to_value): New
1570         function.
1571         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1572         Add support for handling an optional second argument.  Call
1573         convert_buffer_and_type_to_value as appropriate.
1574         * python/python-internal.h (Py_buffer_deleter): New struct.
1575         (Py_buffer_up): New typedef.
1576
1577 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1578
1579         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1580         instead of releasing ownership.
1581
1582 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1583
1584         * dwarf2read.c (open_and_init_dwp_file): Call
1585         elf_numsections instead of bfd_count_sections to initialize
1586         dwp_file->num_sections.
1587
1588 2019-02-25  Tom Tromey  <tromey@adacore.com>
1589
1590         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1591
1592 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1593
1594         * gcore.in: Add '--readnever' option when invoking GDB.
1595
1596 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1597
1598         * MAINTAINERS: Update my email address.
1599
1600 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1601
1602         * build-id.c (build_id_to_debug_bfd_1): New function.
1603         (build_id_to_debug_bfd): Look for separate debug file in
1604         sysroot.
1605
1606 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * gdbarch.sh: Update the copyright year range that is placed into
1609         generated files.
1610
1611 2019-02-22  Keith Seitz  <keiths@redhat.com>
1612
1613         PR symtab/23853
1614         * linespec.c (create_sals_line_offset): Search for the default
1615         symtab's filename instead of its fullname.
1616
1617 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1618
1619         * NEWS: Update style defaults.
1620
1621 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1622
1623         * main.c (captured_main_1): Disable styling in batch mode.
1624
1625 2019-02-20  Tom Tromey  <tom@tromey.com>
1626
1627         * symtab.c (symtab_symbol_info): Fix typos.
1628
1629 2019-02-20  Tom Tromey  <tromey@adacore.com>
1630
1631         * findcmd.c (_initialize_mem_search): Use upper case for
1632         metasyntactic variables.
1633
1634 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1635
1636         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1637         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1638
1639 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1640
1641         * top.h (source_file_name): Change to std::string.
1642         * top.c (source_file_name): Likewise.
1643         (command_line_input): Adjust.
1644         * cli/cli-script.c (script_from_file): Adjust.
1645
1646 2019-02-19  Tom Tromey  <tromey@adacore.com>
1647
1648         * ravenscar-thread.c
1649         (ravenscar_thread_target::update_thread_list): Don't call
1650         ada_build_task_list.
1651         * ada-lang.h (ada_build_task_list): Don't declare.
1652         * ada-tasks.c (struct ada_tasks_inferior_data)
1653         <task_list_valid_p>: Now bool.
1654         (read_known_tasks, ada_task_list_changed)
1655         (ada_tasks_invalidate_inferior_data): Update.
1656         (read_known_tasks_array): Return bool.
1657         (read_known_tasks_list): Likewise.
1658         (read_known_tasks): Return void.
1659         (ada_build_task_list): Now static.
1660
1661 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1664         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1665
1666 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1669         variant for ada_tasks_pspace_data_handle and
1670         ada_tasks_inferior_data_handle.
1671         (ada_tasks_pspace_data_cleanup): New function.
1672         (ada_tasks_inferior_data_cleanup): New function.
1673
1674 2019-02-17  Tom Tromey  <tom@tromey.com>
1675
1676         * macrotab.h (macro_source_fullname): Return a std::string.
1677         * macrotab.c (macro_include, check_for_redefinition)
1678         (macro_undef, macro_lookup_definition, foreach_macro)
1679         (foreach_macro_in_scope): Update.
1680         (macro_source_fullname): Return a std::string.
1681         * macrocmd.c (show_pp_source_pos): Update.
1682
1683 2019-02-17  Tom Tromey  <tom@tromey.com>
1684
1685         * macrocmd.c (show_pp_source_pos): Style the file names.
1686
1687 2019-02-17  Tom Tromey  <tom@tromey.com>
1688
1689         PR tui/24197:
1690         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1691
1692 2019-02-17  Tom Tromey  <tom@tromey.com>
1693
1694         * ada-lang.c (user_select_syms): Use filtered printing.
1695         * utils.c (wrap_style): New global.
1696         (desired_style): Remove.
1697         (emit_style_escape): Add stream parameter.
1698         (set_output_style, reset_terminal_style, prompt_for_continue):
1699         Update.
1700         (flush_wrap_buffer): Only flush gdb_stdout.
1701         (wrap_here): Set wrap_style.
1702         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1703         treat escape sequences as a character.  Change when wrap buffer is
1704         flushed.
1705         (fputs_styled): Do not set the output style when the default is
1706         requested.
1707         * ui-style.h (struct ui_file_style) <is_default>: New method.
1708         * source.c (print_source_lines_base): Emit escape sequences in one
1709         piece.
1710
1711 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1712
1713         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1714         integers and enumeration types.
1715
1716 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1717
1718         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1719         instead of lookup_symbol_in_language
1720         (do_exact_match): New function.
1721         (ada_get_symbol_name_matcher): Return do_exact_match when
1722         doing a verbatim match.
1723
1724 2019-02-15  Tom Tromey  <tromey@adacore.com>
1725
1726         * ravenscar-thread.c (ravenscar_thread_target::resume)
1727         (ravenscar_thread_target::wait): Special case wildcard requests.
1728
1729 2019-02-15  Tom Tromey  <tromey@adacore.com>
1730
1731         * ravenscar-thread.c (base_ptid): Remove.
1732         (struct ravenscar_thread_target) <close>: New method.
1733         <m_base_ptid>: New member.
1734         <update_inferior_ptid, active_task, task_is_currently_active,
1735         runtime_initialized>: Declare methods.
1736         <ravenscar_thread_target>: Add constructor.
1737         (ravenscar_thread_target::task_is_currently_active)
1738         (ravenscar_thread_target::update_inferior_ptid)
1739         (ravenscar_runtime_initialized): Rename.  Now methods.
1740         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1741         (ravenscar_thread_target::update_thread_list): Update.
1742         (ravenscar_thread_target::active_task): Now method.
1743         (ravenscar_thread_target::store_registers)
1744         (ravenscar_thread_target::prepare_to_store)
1745         (ravenscar_thread_target::prepare_to_store)
1746         (ravenscar_thread_target::mourn_inferior): Update.
1747         (ravenscar_inferior_created): Use "new" to create target.
1748         (ravenscar_thread_target::get_ada_task_ptid): Update.
1749         (_initialize_ravenscar): Don't initialize base_ptid.
1750         (ravenscar_ops): Remove global.
1751
1752 2019-02-15  Tom Tromey  <tromey@adacore.com>
1753
1754         * target.h (push_target): Declare new overload.
1755         * target.c (push_target): New overload, taking an rvalue reference.
1756         * remote.c (remote_target::open_1): Use push_target overload.
1757         * corelow.c (core_target_open): Use push_target overload.
1758
1759 2019-02-15  Tom Tromey  <tromey@adacore.com>
1760
1761         * ravenscar-thread.c (is_ravenscar_task)
1762         (ravenscar_task_is_currently_active): Return bool.
1763         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1764         (_initialize_ravenscar): Remove "(void)".
1765         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1766         Return bool.
1767
1768 2019-02-15  Tom Tromey  <tromey@adacore.com>
1769
1770         * ravenscar-thread.c (ravenscar_runtime_initializer)
1771         (has_ravenscar_runtime, get_running_thread_id)
1772         (ravenscar_thread_target::resume): Fix indentation.
1773
1774 2019-02-15  Tom Tromey  <tromey@adacore.com>
1775
1776         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1777         from ravenscar_arch_ops.
1778         (sparc_ravenscar_ops::fetch_registers)
1779         (sparc_ravenscar_ops::store_registers): Now methods.
1780         (sparc_ravenscar_prepare_to_store): Remove.
1781         (sparc_ravenscar_ops): Redefine.
1782         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1783         methods and destructor.  Remove members.
1784         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1785         (ravenscar_thread_target::store_registers)
1786         (ravenscar_thread_target::prepare_to_store): Update.
1787         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1788         Remove.
1789         (struct ppc_ravenscar_powerpc_ops): Derive from
1790         ravenscar_arch_ops.
1791         (ppc_ravenscar_powerpc_ops::fetch_registers)
1792         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1793         (ppc_ravenscar_powerpc_ops): Redefine.
1794         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1795         (ppc_ravenscar_e500_ops::fetch_registers)
1796         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1797         (ppc_ravenscar_e500_ops): Redefine.
1798         * aarch64-ravenscar-thread.c
1799         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1800         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1801         (aarch64_ravenscar_fetch_registers)
1802         (aarch64_ravenscar_store_registers): Now methods.
1803         (aarch64_ravenscar_ops): Redefine.
1804
1805 2019-02-15  Tom Tromey  <tromey@adacore.com>
1806
1807         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1808         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1809         (ravenscar_thread_target::stopped_by_watchpoint)
1810         (ravenscar_thread_target::stopped_data_address)
1811         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1812
1813 2019-02-15  Tom Tromey  <tromey@adacore.com>
1814
1815         * ravenscar-thread.c: Fix some typos.
1816
1817 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1818             Tom Tromey  <tromey@adacore.com>
1819
1820         * ada-lang.c (ada_exception_sal): Change addr_string to a
1821         std::string.
1822         (create_ada_exception_catchpoint): Update.
1823
1824 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1825             Tom Tromey  <tromey@adacore.com>
1826
1827         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1828         (bp_location_ops): Remove.
1829         (base_breakpoint_allocate_location): Update.
1830         (free_bp_location): Update.
1831         * ada-lang.c (class ada_catchpoint_location)
1832         <ada_catchpoint_location>: Remove ops parameter.
1833         (ada_catchpoint_location_dtor): Remove.
1834         (ada_catchpoint_location_ops): Remove.
1835         (allocate_location_exception): Update.
1836         * breakpoint.h (struct bp_location_ops): Remove.
1837         (class bp_location) <bp_location>: Remove bp_location_ops
1838         parameter.
1839         <~bp_location>: Add destructor.
1840         <ops>: Remove.
1841
1842 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1843             Pedro Alves  <palves@redhat.com>
1844
1845         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1846         'PATH_MAX'.
1847
1848 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1849             Samuel Thibault  <samuel.thibault@gnu.org>
1850             Thomas Schwinge  <thomas@codesourcery.com>
1851
1852         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1853         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1854
1855 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1856
1857         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1858         (check_empty): Use "const char *".
1859
1860         * gnu-nat.c (gnu_nat_target::detach): Instead of
1861         'detach_inferior (pid)' call
1862         'detach_inferior (find_inferior_pid (pid))'.
1863
1864         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1865         'nat/fork-inferior.o'.
1866         * gnu-nat.c: #include "nat/fork-inferior.h".
1867
1868         * gnu-nat.c (gnu_nat_target::detach): Instead of
1869         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1870         * gnu-nat.h: #include "inf-child.h".
1871         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1872         'i386_gnu_nat_target::fetch_registers'.
1873         (gnu_store_registers): Rename/move to
1874         'i386_gnu_nat_target::store_registers'.
1875
1876         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1877         * gnu-nat.h (mach_thread_info): New function.
1878         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1879
1880         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1881
1882 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1883
1884         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1885
1886 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1887
1888         * windows-nat.c (windows_add_thread): Add new parameter
1889         "main_thread_p" with default value set to false.  Update
1890         function documentation as well as all callers.
1891         (windows_delete_thread): Likewise.
1892         (fake_create_process): Update call to windows_add_thread.
1893         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1894         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1895         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1896         call to windows_delete_thread.
1897
1898 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1899
1900         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1901
1902 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1903
1904         * symfile.c (find_separate_debug_file): Use canonical path of
1905         sysroot with child_path instead of gdb_sysroot if it is valid.
1906
1907 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1908
1909         * symfile.c (find_separate_debug_file): Use child_path to
1910         determine if an object file is under a sysroot.
1911
1912 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1913
1914         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1915         unittests/child-path-selftests.c.
1916         * common/pathstuff.c (child_path): New function.
1917         * common/pathstuff.h (child_path): New prototype.
1918         * unittests/child-path-selftests.c: New file.
1919
1920 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1921
1922         * symfile.c (find_separate_debug_file): Look for separate debug
1923         files in debug directories under the sysroot.
1924
1925 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1926
1927         * symtab.h (struct minimal_symbol data_p): New const method.
1928         (struct minimal_symbol text_p): Likewise.
1929         * symtab.c (output_source_filename): Use file name style
1930         to print file name.
1931         (print_symbol_info): Likewise.
1932         (print_msymbol_info): Use address style to print addresses.
1933         Use function name style to print executable text symbols.
1934         (expand_symtab_containing_pc): Use data_p.
1935         (find_pc_sect_compunit_symtab): Likewise.
1936
1937 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * breakpoint.c (describe_other_breakpoints): Use address style
1940         to print addresses.
1941         (say_where): Likewise.
1942
1943 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1944
1945         * ada-typeprint.c (print_func_type): Print function name
1946         style to print function name.
1947         * c-typeprint.c (c_print_type_1): Likewise.
1948
1949 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1950
1951         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1952         for execve.
1953
1954 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1955
1956         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1957         type_stack.
1958
1959 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1960
1961         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1962         TYPE_CODE_REF types.
1963
1964 2019-02-08  Jim Wilson  <jimw@sifive.com>
1965
1966         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1967         (riscv_linux_fregset): New.
1968         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1969
1970 2019-02-07  Tom Tromey  <tom@tromey.com>
1971
1972         * thread.c (thread_cancel_execution_command): Update.
1973         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1974         methods.
1975         (struct thread_fsm_ops): Remove.
1976         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1977         (thread_fsm_should_stop, thread_fsm_return_value)
1978         (thread_fsm_set_finished, thread_fsm_finished_p)
1979         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1980         Don't declare.
1981         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1982         * infrun.c (clear_proceed_status_thread)
1983         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1984         (print_stop_event): Update.
1985         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1986         Add constructor.
1987         (step_command_fsm_ops): Remove.
1988         (new_step_command_fsm): Remove.
1989         (step_1): Update.
1990         (step_command_fsm::should_stop): Rename from
1991         step_command_fsm_should_stop.
1992         (step_command_fsm::clean_up): Rename from
1993         step_command_fsm_clean_up.
1994         (step_command_fsm::do_async_reply_reason): Rename from
1995         step_command_fsm_async_reply_reason.
1996         (struct until_next_fsm): Inherit from thread_fsm.  Add
1997         constructor.
1998         (until_next_fsm_ops): Remove.
1999         (new_until_next_fsm): Remove.
2000         (until_next_fsm::should_stop): Rename from
2001         until_next_fsm_should_stop.
2002         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2003         (until_next_fsm::do_async_reply_reason): Rename from
2004         until_next_fsm_async_reply_reason.
2005         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2006         constructor.  Change type of breakpoint.
2007         (finish_command_fsm_ops): Remove.
2008         (new_finish_command_fsm): Remove.
2009         (finish_command_fsm::should_stop): Rename from
2010         finish_command_fsm_should_stop.
2011         (finish_command_fsm::clean_up): Rename from
2012         finish_command_fsm_clean_up.
2013         (finish_command_fsm::return_value): Rename from
2014         finish_command_fsm_return_value.
2015         (finish_command_fsm::do_async_reply_reason): Rename from
2016         finish_command_fsm_async_reply_reason.
2017         (finish_command): Update.
2018         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2019         Add constructor.
2020         (call_thread_fsm_ops): Remove.
2021         (call_thread_fsm::call_thread_fsm): Rename from
2022         new_call_thread_fsm.
2023         (call_thread_fsm::should_stop): Rename from
2024         call_thread_fsm_should_stop.
2025         (call_thread_fsm::should_notify_stop): Rename from
2026         call_thread_fsm_should_notify_stop.
2027         (run_inferior_call, call_function_by_hand_dummy): Update.
2028         * cli/cli-interp.c (should_print_stop_to_console): Update.
2029         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2030         Add constructor.  Change type of location_breakpoint,
2031         caller_breakpoint.
2032         (until_break_fsm_ops): Remove.
2033         (new_until_break_fsm): Remove.
2034         (until_break_fsm::should_stop): Rename from
2035         until_break_fsm_should_stop.
2036         (until_break_fsm::clean_up): Rename from
2037         until_break_fsm_clean_up.
2038         (until_break_fsm::do_async_reply_reason): Rename from
2039         until_break_fsm_async_reply_reason.
2040         (until_break_command): Update.
2041         * thread-fsm.c: Remove.
2042         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2043
2044 2019-02-07  Tom Tromey  <tom@tromey.com>
2045
2046         * yy-remap.h: Add include guard.
2047         * xtensa-tdep.h: Add include guard.
2048         * xcoffread.h: Rename include guard.
2049         * varobj-iter.h: Add include guard.
2050         * tui/tui.h: Rename include guard.
2051         * tui/tui-winsource.h: Rename include guard.
2052         * tui/tui-wingeneral.h: Rename include guard.
2053         * tui/tui-windata.h: Rename include guard.
2054         * tui/tui-win.h: Rename include guard.
2055         * tui/tui-stack.h: Rename include guard.
2056         * tui/tui-source.h: Rename include guard.
2057         * tui/tui-regs.h: Rename include guard.
2058         * tui/tui-out.h: Rename include guard.
2059         * tui/tui-layout.h: Rename include guard.
2060         * tui/tui-io.h: Rename include guard.
2061         * tui/tui-hooks.h: Rename include guard.
2062         * tui/tui-file.h: Rename include guard.
2063         * tui/tui-disasm.h: Rename include guard.
2064         * tui/tui-data.h: Rename include guard.
2065         * tui/tui-command.h: Rename include guard.
2066         * tic6x-tdep.h: Add include guard.
2067         * target/waitstatus.h: Rename include guard.
2068         * target/wait.h: Rename include guard.
2069         * target/target.h: Rename include guard.
2070         * target/resume.h: Rename include guard.
2071         * target-float.h: Rename include guard.
2072         * stabsread.h: Add include guard.
2073         * rs6000-tdep.h: Add include guard.
2074         * riscv-fbsd-tdep.h: Add include guard.
2075         * regformats/regdef.h: Rename include guard.
2076         * record.h: Rename include guard.
2077         * python/python.h: Rename include guard.
2078         * python/python-internal.h: Rename include guard.
2079         * python/py-stopevent.h: Rename include guard.
2080         * python/py-ref.h: Rename include guard.
2081         * python/py-record.h: Rename include guard.
2082         * python/py-record-full.h: Rename include guard.
2083         * python/py-record-btrace.h: Rename include guard.
2084         * python/py-instruction.h: Rename include guard.
2085         * python/py-events.h: Rename include guard.
2086         * python/py-event.h: Rename include guard.
2087         * procfs.h: Add include guard.
2088         * proc-utils.h: Add include guard.
2089         * p-lang.h: Add include guard.
2090         * or1k-tdep.h: Rename include guard.
2091         * observable.h: Rename include guard.
2092         * nto-tdep.h: Rename include guard.
2093         * nat/x86-linux.h: Rename include guard.
2094         * nat/x86-linux-dregs.h: Rename include guard.
2095         * nat/x86-gcc-cpuid.h: Add include guard.
2096         * nat/x86-dregs.h: Rename include guard.
2097         * nat/x86-cpuid.h: Rename include guard.
2098         * nat/ppc-linux.h: Rename include guard.
2099         * nat/mips-linux-watch.h: Rename include guard.
2100         * nat/linux-waitpid.h: Rename include guard.
2101         * nat/linux-ptrace.h: Rename include guard.
2102         * nat/linux-procfs.h: Rename include guard.
2103         * nat/linux-osdata.h: Rename include guard.
2104         * nat/linux-nat.h: Rename include guard.
2105         * nat/linux-namespaces.h: Rename include guard.
2106         * nat/linux-btrace.h: Rename include guard.
2107         * nat/glibc_thread_db.h: Rename include guard.
2108         * nat/gdb_thread_db.h: Rename include guard.
2109         * nat/gdb_ptrace.h: Rename include guard.
2110         * nat/fork-inferior.h: Rename include guard.
2111         * nat/amd64-linux-siginfo.h: Rename include guard.
2112         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2113         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2114         * nat/aarch64-linux.h: Rename include guard.
2115         * nat/aarch64-linux-hw-point.h: Rename include guard.
2116         * mn10300-tdep.h: Add include guard.
2117         * mips-linux-tdep.h: Add include guard.
2118         * mi/mi-parse.h: Rename include guard.
2119         * mi/mi-out.h: Rename include guard.
2120         * mi/mi-main.h: Rename include guard.
2121         * mi/mi-interp.h: Rename include guard.
2122         * mi/mi-getopt.h: Rename include guard.
2123         * mi/mi-console.h: Rename include guard.
2124         * mi/mi-common.h: Rename include guard.
2125         * mi/mi-cmds.h: Rename include guard.
2126         * mi/mi-cmd-break.h: Rename include guard.
2127         * m2-lang.h: Add include guard.
2128         * location.h: Rename include guard.
2129         * linux-record.h: Rename include guard.
2130         * linux-nat.h: Add include guard.
2131         * linux-fork.h: Add include guard.
2132         * i386-darwin-tdep.h: Rename include guard.
2133         * hppa-linux-offsets.h: Add include guard.
2134         * guile/guile.h: Rename include guard.
2135         * guile/guile-internal.h: Rename include guard.
2136         * gnu-nat.h: Rename include guard.
2137         * gdb-stabs.h: Rename include guard.
2138         * frv-tdep.h: Add include guard.
2139         * f-lang.h: Add include guard.
2140         * event-loop.h: Add include guard.
2141         * darwin-nat.h: Rename include guard.
2142         * cp-abi.h: Rename include guard.
2143         * config/sparc/nm-sol2.h: Rename include guard.
2144         * config/nm-nto.h: Rename include guard.
2145         * config/nm-linux.h: Add include guard.
2146         * config/i386/nm-i386gnu.h: Rename include guard.
2147         * config/djgpp/nl_types.h: Rename include guard.
2148         * config/djgpp/langinfo.h: Rename include guard.
2149         * compile/gcc-cp-plugin.h: Add include guard.
2150         * compile/gcc-c-plugin.h: Add include guard.
2151         * compile/compile.h: Rename include guard.
2152         * compile/compile-object-run.h: Rename include guard.
2153         * compile/compile-object-load.h: Rename include guard.
2154         * compile/compile-internal.h: Rename include guard.
2155         * compile/compile-cplus.h: Rename include guard.
2156         * compile/compile-c.h: Rename include guard.
2157         * common/xml-utils.h: Rename include guard.
2158         * common/x86-xstate.h: Rename include guard.
2159         * common/version.h: Rename include guard.
2160         * common/vec.h: Rename include guard.
2161         * common/tdesc.h: Rename include guard.
2162         * common/selftest.h: Rename include guard.
2163         * common/scoped_restore.h: Rename include guard.
2164         * common/scoped_mmap.h: Rename include guard.
2165         * common/scoped_fd.h: Rename include guard.
2166         * common/safe-iterator.h: Rename include guard.
2167         * common/run-time-clock.h: Rename include guard.
2168         * common/refcounted-object.h: Rename include guard.
2169         * common/queue.h: Rename include guard.
2170         * common/ptid.h: Rename include guard.
2171         * common/print-utils.h: Rename include guard.
2172         * common/preprocessor.h: Rename include guard.
2173         * common/pathstuff.h: Rename include guard.
2174         * common/observable.h: Rename include guard.
2175         * common/netstuff.h: Rename include guard.
2176         * common/job-control.h: Rename include guard.
2177         * common/host-defs.h: Rename include guard.
2178         * common/gdb_wait.h: Rename include guard.
2179         * common/gdb_vecs.h: Rename include guard.
2180         * common/gdb_unlinker.h: Rename include guard.
2181         * common/gdb_unique_ptr.h: Rename include guard.
2182         * common/gdb_tilde_expand.h: Rename include guard.
2183         * common/gdb_sys_time.h: Rename include guard.
2184         * common/gdb_string_view.h: Rename include guard.
2185         * common/gdb_splay_tree.h: Rename include guard.
2186         * common/gdb_setjmp.h: Rename include guard.
2187         * common/gdb_ref_ptr.h: Rename include guard.
2188         * common/gdb_optional.h: Rename include guard.
2189         * common/gdb_locale.h: Rename include guard.
2190         * common/gdb_assert.h: Rename include guard.
2191         * common/filtered-iterator.h: Rename include guard.
2192         * common/filestuff.h: Rename include guard.
2193         * common/fileio.h: Rename include guard.
2194         * common/environ.h: Rename include guard.
2195         * common/common-utils.h: Rename include guard.
2196         * common/common-types.h: Rename include guard.
2197         * common/common-regcache.h: Rename include guard.
2198         * common/common-inferior.h: Rename include guard.
2199         * common/common-gdbthread.h: Rename include guard.
2200         * common/common-exceptions.h: Rename include guard.
2201         * common/common-defs.h: Rename include guard.
2202         * common/common-debug.h: Rename include guard.
2203         * common/cleanups.h: Rename include guard.
2204         * common/buffer.h: Rename include guard.
2205         * common/btrace-common.h: Rename include guard.
2206         * common/break-common.h: Rename include guard.
2207         * cli/cli-utils.h: Rename include guard.
2208         * cli/cli-style.h: Rename include guard.
2209         * cli/cli-setshow.h: Rename include guard.
2210         * cli/cli-script.h: Rename include guard.
2211         * cli/cli-interp.h: Rename include guard.
2212         * cli/cli-decode.h: Rename include guard.
2213         * cli/cli-cmds.h: Rename include guard.
2214         * charset-list.h: Add include guard.
2215         * buildsym-legacy.h: Rename include guard.
2216         * bfin-tdep.h: Add include guard.
2217         * ax.h: Rename include guard.
2218         * arm-linux-tdep.h: Add include guard.
2219         * arm-fbsd-tdep.h: Add include guard.
2220         * arch/xtensa.h: Rename include guard.
2221         * arch/tic6x.h: Add include guard.
2222         * arch/i386.h: Add include guard.
2223         * arch/arm.h: Rename include guard.
2224         * arch/arm-linux.h: Rename include guard.
2225         * arch/arm-get-next-pcs.h: Rename include guard.
2226         * arch/amd64.h: Add include guard.
2227         * arch/aarch64-insn.h: Rename include guard.
2228         * arch-utils.h: Rename include guard.
2229         * annotate.h: Add include guard.
2230         * amd64-darwin-tdep.h: Rename include guard.
2231         * aarch64-linux-tdep.h: Add include guard.
2232         * aarch64-fbsd-tdep.h: Add include guard.
2233         * aarch32-linux-nat.h: Add include guard.
2234
2235 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2236
2237         * macrotab.c (macro_define_internal): New function that
2238         factorizes macro_define_object_internal and macro_define_function
2239         code.
2240         (macro_define_object_internal): Use macro_define_internal.
2241         (macro_define_function): Likewise.
2242
2243 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2244
2245         * macrocmd.c (extract_identifier): Return
2246         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2247         callers.
2248
2249 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2250
2251         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2252
2253 2019-02-05  Tom Tromey  <tom@tromey.com>
2254
2255         * target.c (target_stack::unpush): Move assertion earlier.
2256
2257 2019-01-30  Tom Tromey  <tom@tromey.com>
2258
2259         PR python/23615:
2260         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2261         (gdbpy_parse_and_eval): Likewise.
2262         * python/python-internal.h (gdbpy_allow_threads): New class.
2263
2264 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2265
2266         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2267         (aarch64_fbsd_fpregmap): Move earlier.
2268         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2269         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2270         instead of individual calls to trad_frame_set_reg_addr.
2271         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2272         earlier.
2273         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2274         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2275         instead of individual calls to trad_frame_set_reg_addr.
2276
2277 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2278
2279         * CONTRIBUTE: Replace contribution list with wiki link.
2280
2281 2019-01-25  Tom Tromey  <tom@tromey.com>
2282
2283         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2284
2285 2019-01-25  Tom Tromey  <tom@tromey.com>
2286
2287         * xtensa-linux-nat.c: Fix common/ includes.
2288         * xml-support.h: Fix common/ includes.
2289         * xml-support.c: Fix common/ includes.
2290         * x86-linux-nat.c: Fix common/ includes.
2291         * windows-nat.c: Fix common/ includes.
2292         * varobj.h: Fix common/ includes.
2293         * varobj.c: Fix common/ includes.
2294         * value.c: Fix common/ includes.
2295         * valops.c: Fix common/ includes.
2296         * utils.c: Fix common/ includes.
2297         * unittests/xml-utils-selftests.c: Fix common/ includes.
2298         * unittests/utils-selftests.c: Fix common/ includes.
2299         * unittests/unpack-selftests.c: Fix common/ includes.
2300         * unittests/tracepoint-selftests.c: Fix common/ includes.
2301         * unittests/style-selftests.c: Fix common/ includes.
2302         * unittests/string_view-selftests.c: Fix common/ includes.
2303         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2304         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2305         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2306         * unittests/rsp-low-selftests.c: Fix common/ includes.
2307         * unittests/parse-connection-spec-selftests.c: Fix common/
2308         includes.
2309         * unittests/optional-selftests.c: Fix common/ includes.
2310         * unittests/offset-type-selftests.c: Fix common/ includes.
2311         * unittests/observable-selftests.c: Fix common/ includes.
2312         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2313         * unittests/memrange-selftests.c: Fix common/ includes.
2314         * unittests/memory-map-selftests.c: Fix common/ includes.
2315         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2316         * unittests/function-view-selftests.c: Fix common/ includes.
2317         * unittests/environ-selftests.c: Fix common/ includes.
2318         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2319         * unittests/common-utils-selftests.c: Fix common/ includes.
2320         * unittests/cli-utils-selftests.c: Fix common/ includes.
2321         * unittests/array-view-selftests.c: Fix common/ includes.
2322         * ui-file.c: Fix common/ includes.
2323         * tui/tui-io.c: Fix common/ includes.
2324         * tracepoint.h: Fix common/ includes.
2325         * tracepoint.c: Fix common/ includes.
2326         * tracefile-tfile.c: Fix common/ includes.
2327         * top.h: Fix common/ includes.
2328         * top.c: Fix common/ includes.
2329         * thread.c: Fix common/ includes.
2330         * target/waitstatus.h: Fix common/ includes.
2331         * target/waitstatus.c: Fix common/ includes.
2332         * target.h: Fix common/ includes.
2333         * target.c: Fix common/ includes.
2334         * target-memory.c: Fix common/ includes.
2335         * target-descriptions.c: Fix common/ includes.
2336         * symtab.h: Fix common/ includes.
2337         * symfile.c: Fix common/ includes.
2338         * stap-probe.c: Fix common/ includes.
2339         * spu-linux-nat.c: Fix common/ includes.
2340         * sparc-nat.c: Fix common/ includes.
2341         * source.c: Fix common/ includes.
2342         * solib.c: Fix common/ includes.
2343         * solib-target.c: Fix common/ includes.
2344         * ser-unix.c: Fix common/ includes.
2345         * ser-tcp.c: Fix common/ includes.
2346         * ser-pipe.c: Fix common/ includes.
2347         * ser-base.c: Fix common/ includes.
2348         * selftest-arch.c: Fix common/ includes.
2349         * s12z-tdep.c: Fix common/ includes.
2350         * rust-exp.y: Fix common/ includes.
2351         * rs6000-aix-tdep.c: Fix common/ includes.
2352         * riscv-tdep.c: Fix common/ includes.
2353         * remote.c: Fix common/ includes.
2354         * remote-notif.h: Fix common/ includes.
2355         * remote-fileio.h: Fix common/ includes.
2356         * remote-fileio.c: Fix common/ includes.
2357         * regcache.h: Fix common/ includes.
2358         * regcache.c: Fix common/ includes.
2359         * record-btrace.c: Fix common/ includes.
2360         * python/python.c: Fix common/ includes.
2361         * python/py-type.c: Fix common/ includes.
2362         * python/py-inferior.c: Fix common/ includes.
2363         * progspace.h: Fix common/ includes.
2364         * producer.c: Fix common/ includes.
2365         * procfs.c: Fix common/ includes.
2366         * proc-api.c: Fix common/ includes.
2367         * printcmd.c: Fix common/ includes.
2368         * ppc-linux-nat.c: Fix common/ includes.
2369         * parser-defs.h: Fix common/ includes.
2370         * osdata.c: Fix common/ includes.
2371         * obsd-nat.c: Fix common/ includes.
2372         * nat/x86-linux.c: Fix common/ includes.
2373         * nat/x86-linux-dregs.c: Fix common/ includes.
2374         * nat/x86-dregs.h: Fix common/ includes.
2375         * nat/x86-dregs.c: Fix common/ includes.
2376         * nat/ppc-linux.c: Fix common/ includes.
2377         * nat/mips-linux-watch.h: Fix common/ includes.
2378         * nat/mips-linux-watch.c: Fix common/ includes.
2379         * nat/linux-waitpid.c: Fix common/ includes.
2380         * nat/linux-ptrace.h: Fix common/ includes.
2381         * nat/linux-ptrace.c: Fix common/ includes.
2382         * nat/linux-procfs.c: Fix common/ includes.
2383         * nat/linux-personality.c: Fix common/ includes.
2384         * nat/linux-osdata.c: Fix common/ includes.
2385         * nat/linux-namespaces.c: Fix common/ includes.
2386         * nat/linux-btrace.h: Fix common/ includes.
2387         * nat/linux-btrace.c: Fix common/ includes.
2388         * nat/fork-inferior.c: Fix common/ includes.
2389         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2390         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2391         * nat/aarch64-linux.c: Fix common/ includes.
2392         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2393         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2394         * namespace.h: Fix common/ includes.
2395         * mips-linux-tdep.c: Fix common/ includes.
2396         * minsyms.c: Fix common/ includes.
2397         * mi/mi-parse.h: Fix common/ includes.
2398         * mi/mi-main.c: Fix common/ includes.
2399         * mi/mi-cmd-env.c: Fix common/ includes.
2400         * memrange.h: Fix common/ includes.
2401         * memattr.c: Fix common/ includes.
2402         * maint.h: Fix common/ includes.
2403         * maint.c: Fix common/ includes.
2404         * main.c: Fix common/ includes.
2405         * machoread.c: Fix common/ includes.
2406         * location.c: Fix common/ includes.
2407         * linux-thread-db.c: Fix common/ includes.
2408         * linux-nat.c: Fix common/ includes.
2409         * linux-fork.c: Fix common/ includes.
2410         * inline-frame.c: Fix common/ includes.
2411         * infrun.c: Fix common/ includes.
2412         * inflow.c: Fix common/ includes.
2413         * inferior.h: Fix common/ includes.
2414         * inferior.c: Fix common/ includes.
2415         * infcmd.c: Fix common/ includes.
2416         * inf-ptrace.c: Fix common/ includes.
2417         * inf-child.c: Fix common/ includes.
2418         * ia64-linux-nat.c: Fix common/ includes.
2419         * i387-tdep.c: Fix common/ includes.
2420         * i386-tdep.c: Fix common/ includes.
2421         * i386-linux-tdep.c: Fix common/ includes.
2422         * i386-linux-nat.c: Fix common/ includes.
2423         * i386-go32-tdep.c: Fix common/ includes.
2424         * i386-fbsd-tdep.c: Fix common/ includes.
2425         * i386-fbsd-nat.c: Fix common/ includes.
2426         * guile/scm-type.c: Fix common/ includes.
2427         * guile/guile.c: Fix common/ includes.
2428         * go32-nat.c: Fix common/ includes.
2429         * gnu-nat.c: Fix common/ includes.
2430         * gdbthread.h: Fix common/ includes.
2431         * gdbarch-selftests.c: Fix common/ includes.
2432         * gdb_usleep.c: Fix common/ includes.
2433         * gdb_select.h: Fix common/ includes.
2434         * gdb_bfd.c: Fix common/ includes.
2435         * gcore.c: Fix common/ includes.
2436         * fork-child.c: Fix common/ includes.
2437         * findvar.c: Fix common/ includes.
2438         * fbsd-nat.c: Fix common/ includes.
2439         * event-top.c: Fix common/ includes.
2440         * event-loop.c: Fix common/ includes.
2441         * dwarf2read.c: Fix common/ includes.
2442         * dwarf2loc.c: Fix common/ includes.
2443         * dwarf2-frame.c: Fix common/ includes.
2444         * dwarf-index-cache.c: Fix common/ includes.
2445         * dtrace-probe.c: Fix common/ includes.
2446         * disasm-selftests.c: Fix common/ includes.
2447         * defs.h: Fix common/ includes.
2448         * csky-tdep.c: Fix common/ includes.
2449         * cp-valprint.c: Fix common/ includes.
2450         * cp-support.h: Fix common/ includes.
2451         * cp-support.c: Fix common/ includes.
2452         * corelow.c: Fix common/ includes.
2453         * completer.h: Fix common/ includes.
2454         * completer.c: Fix common/ includes.
2455         * compile/compile.c: Fix common/ includes.
2456         * compile/compile-loc2c.c: Fix common/ includes.
2457         * compile/compile-cplus-types.c: Fix common/ includes.
2458         * compile/compile-cplus-symbols.c: Fix common/ includes.
2459         * command.h: Fix common/ includes.
2460         * cli/cli-dump.c: Fix common/ includes.
2461         * cli/cli-cmds.c: Fix common/ includes.
2462         * charset.c: Fix common/ includes.
2463         * build-id.c: Fix common/ includes.
2464         * btrace.h: Fix common/ includes.
2465         * btrace.c: Fix common/ includes.
2466         * breakpoint.h: Fix common/ includes.
2467         * breakpoint.c: Fix common/ includes.
2468         * ax.h:
2469         (enum agent_op): Fix common/ includes.
2470         * ax-general.c (struct aop_map): Fix common/ includes.
2471         * ax-gdb.c: Fix common/ includes.
2472         * auxv.c: Fix common/ includes.
2473         * auto-load.c: Fix common/ includes.
2474         * arm-tdep.c: Fix common/ includes.
2475         * arch/riscv.c: Fix common/ includes.
2476         * arch/ppc-linux-common.c: Fix common/ includes.
2477         * arch/i386.c: Fix common/ includes.
2478         * arch/arm.c: Fix common/ includes.
2479         * arch/arm-linux.c: Fix common/ includes.
2480         * arch/arm-get-next-pcs.c: Fix common/ includes.
2481         * arch/amd64.c: Fix common/ includes.
2482         * arch/aarch64.c: Fix common/ includes.
2483         * arch/aarch64-insn.c: Fix common/ includes.
2484         * arch-utils.c: Fix common/ includes.
2485         * amd64-windows-tdep.c: Fix common/ includes.
2486         * amd64-tdep.c: Fix common/ includes.
2487         * amd64-sol2-tdep.c: Fix common/ includes.
2488         * amd64-obsd-tdep.c: Fix common/ includes.
2489         * amd64-nbsd-tdep.c: Fix common/ includes.
2490         * amd64-linux-tdep.c: Fix common/ includes.
2491         * amd64-linux-nat.c: Fix common/ includes.
2492         * amd64-fbsd-tdep.c: Fix common/ includes.
2493         * amd64-fbsd-nat.c: Fix common/ includes.
2494         * amd64-dicos-tdep.c: Fix common/ includes.
2495         * amd64-darwin-tdep.c: Fix common/ includes.
2496         * agent.c: Fix common/ includes.
2497         * ada-lang.h: Fix common/ includes.
2498         * ada-lang.c: Fix common/ includes.
2499         * aarch64-tdep.c: Fix common/ includes.
2500
2501 2019-01-25  Tom Tromey  <tom@tromey.com>
2502
2503         * common/create-version.sh: Use common/version.h.
2504
2505 2019-01-24  Pedro Alves  <palves@redhat.com>
2506
2507         * infrun.c (signal_stop, signal_print, signal_program)
2508         (signal_catch, signal_pass): Now arrays instead of pointers.
2509         (update_signals_program_target, do_target_resume)
2510         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2511         * linux-nat.c (linux_nat_target::pass_signals)
2512         (linux_nat_target::create_inferior, linux_nat_target::attach):
2513         Adjust.
2514         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2515         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2516         * procfs.c (procfs_target::pass_signals): Adjust.
2517         * record-full.c (record_full_target::resume): Adjust.
2518         * remote.c (remote_target::pass_signals)
2519         (remote_target::program_signals): Adjust.
2520         * target-debug.h (target_debug_print_signals): Now takes a
2521         gdb::array_view as parameter.  Adjust.
2522         * target.h (target_ops) <pass_signals, program_signals>: Replace
2523         pointer and length parameters with gdb::array_view.
2524         (target_pass_signals, target_program_signals): Likewise.
2525         * target-delegates.c: Regenerate.
2526
2527 2019-01-24  Pedro Alves  <palves@redhat.com>
2528
2529         * common/forward-scope-exit.h
2530         (forward_scope_exit::forward_scope_exit): Pass arguments to
2531         m_bind_function directly, instead of creating a std::bind and
2532         copying that.
2533
2534 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2535
2536         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2537         for static members.
2538         (pass_in_v_vfp_candidate): Likewise.
2539
2540 2019-01-23  Tom Tromey  <tom@tromey.com>
2541             Pedro Alves  <palves@redhat.com>
2542
2543         * regcache.c (class regcache_invalidator): Remove.
2544         (regcache::raw_write): Use make_scope_exit.
2545
2546 2019-01-23  Tom Tromey  <tom@tromey.com>
2547
2548         * ui-out.h (class ui_out_emit_type): Update comment.
2549
2550 2019-01-23  Tom Tromey  <tom@tromey.com>
2551
2552         * infrun.c (fetch_inferior_event): Update comment.
2553
2554 2019-01-23  Tom Tromey  <tom@tromey.com>
2555             Pedro Alves  <palves@redhat.com>
2556
2557         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2558         parameter.
2559         (fetch_inferior_event): Use SCOPE_EXIT.
2560
2561
2562 2019-01-23  Tom Tromey  <tom@tromey.com>
2563             Pedro Alves  <palves@redhat.com>
2564
2565         * infrun.c (disable_thread_events): Delete.
2566         (stop_all_threads): Use SCOPE_EXIT.
2567
2568 2019-01-23  Tom Tromey  <tom@tromey.com>
2569             Pedro Alves  <palves@redhat.com>
2570
2571         * symfile.c: Include forward-scope-exit.h.
2572         (clear_symtab_users_cleanup): Replace forward declaration with
2573         a FORWARD_SCOPE_EXIT.
2574         (syms_from_objfile_1): Use the forward_scope_exit and
2575         gdb::optional instead of cleanup_function.
2576         (reread_symbols): Use the forward_scope_exit instead of
2577         cleanup_function.
2578         (clear_symtab_users_cleanup): Remove function.
2579
2580 2019-01-23  Tom Tromey  <tom@tromey.com>
2581             Pedro Alves  <palves@redhat.com>
2582
2583         * linux-nat.c: Include scope-exit.h.
2584         (cleanup_target_stop): Remove.
2585         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2586         SCOPE_EXIT.
2587
2588 2019-01-23  Tom Tromey  <tom@tromey.com>
2589             Pedro Alves  <palves@redhat.com>
2590
2591         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2592         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2593
2594 2019-01-23  Tom Tromey  <tom@tromey.com>
2595             Andrew Burgess  <andrew.burgess@embecosm.com>
2596             Pedro Alves  <palves@redhat.com>
2597
2598         * infrun.c (fetch_inferior_event): Use scope_exit.
2599         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2600         * top.c (execute_command): Use scope_exit.
2601         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2602         * utils.c (do_bpstat_clear_actions_cleanup)
2603         (make_bpstat_clear_actions_cleanup): Remove.
2604
2605 2019-01-23  Tom Tromey  <tom@tromey.com>
2606             Pedro Alves  <palves@redhat.com>
2607
2608         * infrun.c: Include "common/scope-exit.h"
2609         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2610         (wait_for_inferior): Use SCOPE_EXIT.
2611         (fetch_inferior_event): Use scope_exit.
2612
2613 2019-01-23  Tom Tromey  <tom@tromey.com>
2614             Pedro Alves  <palves@redhat.com>
2615
2616         * breakpoint.c (create_breakpoint): Remove cleanup.
2617
2618 2019-01-23  Tom Tromey  <tom@tromey.com>
2619             Andrew Burgess  <andrew.burgess@embecosm.com>
2620             Pedro Alves  <palves@redhat.com>
2621
2622 2019-01-23  Pedro Alves  <palves@redhat.com>
2623
2624         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2625
2626 2019-01-23  Pedro Alves  <palves@redhat.com>
2627             Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * gdbthread.h: Include "common/forward-scope-exit.h".
2630         (scoped_finish_thread_state): Redefine custom class in terms of
2631         forward_scope_exit.
2632
2633 2019-01-23  Pedro Alves  <palves@redhat.com>
2634             Andrew Burgess  <andrew.burgess@embecosm.com>
2635
2636         * common/forward-scope-exit.h: New file.
2637
2638 2019-01-23  Pedro Alves  <palves@redhat.com>
2639             Andrew Burgess  <andrew.burgess@embecosm.com>
2640             Tom Tromey  <tom@tromey.com>
2641
2642         * common/scope-exit.h: New file.
2643
2644 2019-01-23  Pedro Alves  <palves@redhat.com>
2645
2646         * common/preprocessor.h (ESC): Rename to ...
2647         (ESC_PARENS): ... this.
2648         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2649         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2650
2651 2019-01-23  Tom Tromey  <tom@tromey.com>
2652
2653         * language.h (class scoped_switch_to_sym_language_if_auto):
2654         Initialize m_lang in both cases.
2655
2656 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2659         with XCNEW.
2660
2661 2019-01-22  Tom Tromey  <tom@tromey.com>
2662
2663         * corelow.c: Do not include sys/file.h.
2664
2665 2019-01-22  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-wingeneral.h: Include gdb_curses.h.
2668
2669 2019-01-22  Tom Tromey  <tom@tromey.com>
2670
2671         * source-cache.h (class source_cache) <get_source_lines,
2672         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2673
2674 2019-01-22  Tom Tromey  <tom@tromey.com>
2675
2676         * remote-fileio.h (struct remote_target): Declare.
2677
2678 2019-01-22  Tom Tromey  <tom@tromey.com>
2679
2680         * python/py-arch.c: Do not include py-ref.h.
2681         * python/py-bpevent.c: Do not include py-ref.h.
2682         * python/py-cmd.c: Do not include py-ref.h.
2683         * python/py-continueevent.c: Do not include py-ref.h.
2684         * python/py-event.h: Do not include py-ref.h.
2685         * python/py-evtregistry.c: Do not include py-ref.h.
2686         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2687         * python/py-frame.c: Do not include py-ref.h.
2688         * python/py-framefilter.c: Do not include py-ref.h.
2689         * python/py-function.c: Do not include py-ref.h.
2690         * python/py-infevents.c: Do not include py-ref.h.
2691         * python/py-linetable.c: Do not include py-ref.h.
2692         * python/py-objfile.c: Do not include py-ref.h.
2693         * python/py-param.c: Do not include py-ref.h.
2694         * python/py-prettyprint.c: Do not include py-ref.h.
2695         * python/py-progspace.c: Do not include py-ref.h.
2696         * python/py-symbol.c: Do not include py-ref.h.
2697         * python/py-symtab.c: Do not include py-ref.h.
2698         * python/py-type.c: Do not include py-ref.h.
2699         * python/py-unwind.c: Do not include py-ref.h.
2700         * python/py-utils.c: Do not include py-ref.h.
2701         * python/py-value.c: Do not include py-ref.h.
2702         * python/py-varobj.c: Do not include py-ref.h.
2703         * python/py-xmethods.c: Do not include py-ref.h.
2704         * python/python.c: Do not include py-ref.h.
2705         * varobj.c: Do not include py-ref.h.
2706
2707 2019-01-22  Tom Tromey  <tom@tromey.com>
2708
2709         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2710         keyword for bcache.
2711
2712 2019-01-22  Tom Tromey  <tom@tromey.com>
2713
2714         * compile/compile-cplus-types.c: Remove a comment by #include.
2715
2716 2019-01-22  Tom Tromey  <tom@tromey.com>
2717
2718         * compile/gcc-c-plugin.h: Include compile-internal.h.
2719
2720 2019-01-22  Tom Tromey  <tom@tromey.com>
2721
2722         * stabsread.c (EXTERN): Do not define.
2723         (symnum, next_symbol_text_func, processing_gcc_compilation)
2724         (within_function, global_sym_chain, global_stabs)
2725         (previous_stab_code, this_object_header_files)
2726         (n_this_object_header_files)
2727         (n_allocated_this_object_header_files): Define.
2728         * stabsread.h (EXTERN): Never define.  Use "extern".
2729
2730 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2731
2732         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2733         history_value.
2734
2735 2019-01-21  Tom Tromey  <tom@tromey.com>
2736
2737         * ui-out.c: Fix includes.
2738         * tui/tui-source.c: Fix includes.
2739         * target.c: Fix includes.
2740         * remote.c: Fix includes.
2741         * regcache.c: Fix includes.
2742         * python/py-block.c: Fix includes.
2743         * printcmd.c: Fix includes.
2744         * or1k-tdep.c: Fix includes.
2745         * mi/mi-main.c: Fix includes.
2746         * m32r-tdep.c: Fix includes.
2747         * csky-tdep.c: Fix includes.
2748         * compile/compile-cplus-types.c: Fix includes.
2749         * cli/cli-interp.c: Fix includes.
2750
2751 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2752
2753         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2754         for padding.
2755
2756 2019-01-16  Tom Tromey  <tom@tromey.com>
2757
2758         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2759         earlier.
2760         (struct objfile) <msymbols_range>: Move from top level.
2761         <msymbols>: New method.
2762         (class objfile_msymbols): Remove.
2763         * symtab.c (default_collect_symbol_completion_matches_break_on):
2764         Update.
2765         * symmisc.c (dump_msymbols): Update.
2766         * stabsread.c (scan_file_globals): Update.
2767         * objc-lang.c (info_selectors_command, info_classes_command)
2768         (find_methods): Update.
2769         * minsyms.c (find_solib_trampoline_target): Update.
2770         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2771         * coffread.c (coff_symfile_read): Update.
2772         * ada-lang.c (ada_lookup_simple_minsym)
2773         (ada_collect_symbol_completion_matches): Update.
2774
2775 2019-01-16  Tom Tromey  <tom@tromey.com>
2776
2777         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2778         type.  Remove no-argument constructor.
2779         <iterator::operator++>: Simplify.
2780         <begin>: Update.
2781         <end>: Use minimal_symbol_count.
2782
2783 2019-01-16  Tom Tromey  <tom@tromey.com>
2784
2785         * objfiles.h (struct objfile) <psymtabs>: New method.
2786         (class objfile_psymtabs): Remove.
2787         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2788         typedef.
2789         <range>: New method.
2790         (require_partial_symbols): Change return type.
2791         * psymtab.c (require_partial_symbols)
2792         (psym_expand_symtabs_matching): Update.
2793         * mdebugread.c (parse_partial_symbols): Update.
2794         * dbxread.c (dbx_end_psymtab): Update.
2795
2796 2019-01-15  Tom Tromey  <tom@tromey.com>
2797
2798         * symtab.c (lookup_objfile_from_block)
2799         (lookup_symbol_in_objfile_symtabs)
2800         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2801         (find_line_symtab, info_sources_command)
2802         (default_collect_symbol_completion_matches_break_on)
2803         (make_source_files_completion_list): Update.
2804         * symmisc.c (print_objfile_statistics, dump_objfile)
2805         (maintenance_print_symbols, maintenance_info_symtabs)
2806         (maintenance_check_symtabs, maintenance_info_line_tables):
2807         Update.
2808         * source.c (select_source_symtab)
2809         (forget_cached_source_info_for_objfile): Update.
2810         * objfiles.h (class objfile_compunits): Remove.
2811         (struct objfile) <compunits_range>: New typedef.
2812         (compunits): New method.
2813         * objfiles.c (objfile_relocate1): Update.
2814         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2815         * maint.c (count_symtabs_and_blocks): Update.
2816         * linespec.c (iterate_over_all_matching_symtabs): Update.
2817         * cp-support.c (add_symbol_overload_list_qualified): Update.
2818         * coffread.c (coff_symtab_read): Update.
2819         * ada-lang.c (add_nonlocal_symbols)
2820         (ada_collect_symbol_completion_matches)
2821         (ada_add_global_exceptions): Update.
2822
2823 2019-01-15  Tom Tromey  <tom@tromey.com>
2824
2825         * progspace.h (program_space) <objfiles_safe_range>: New
2826         typedef.
2827         <objfiles_safe>: New method.
2828         * objfiles.h (class all_objfiles_safe): Remove.
2829         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2830         * jit.c (jit_inferior_exit_hook): Update.
2831
2832 2019-01-17  Tom Tromey  <tom@tromey.com>
2833
2834         * progspace.h (program_space) <objfiles_range>: New typedef.
2835         <objfiles>: New method.
2836         <objfiles_head>: Rename from objfiles.
2837         (object_files): Update.
2838         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2839         * guile/scm-pretty-print.c
2840         (ppscm_find_pretty_printer_from_objfiles): Update.
2841         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2842         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2843         Update.
2844         * python/py-progspace.c (pspy_get_objfiles): Update.
2845         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2846         Update.
2847         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2848         (objfpy_lookup_objfile_by_build_id): Update.
2849         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2850         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2851         Update.
2852         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2853         (expand_symtab_containing_pc, lookup_objfile_from_block)
2854         (lookup_static_symbol, basic_lookup_transparent_type)
2855         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2856         (find_line_symtab, info_sources_command)
2857         (default_collect_symbol_completion_matches_break_on)
2858         (make_source_files_completion_list, find_main_name): Update.
2859         * symmisc.c (print_symbol_bcache_statistics)
2860         (print_objfile_statistics, maintenance_print_symbols)
2861         (maintenance_print_msymbols, maintenance_print_objfiles)
2862         (maintenance_info_symtabs, maintenance_check_symtabs)
2863         (maintenance_expand_symtabs, maintenance_info_line_tables):
2864         Update.
2865         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2866         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2867         (map_overlay_command, unmap_overlay_command)
2868         (simple_overlay_update, expand_symtabs_matching)
2869         (map_symbol_filenames): Update.
2870         * symfile-debug.c (set_debug_symfile): Update.
2871         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2872         Update.
2873         * source.c (select_source_symtab, forget_cached_source_info):
2874         Update.
2875         * solib.c (solib_read_symbols): Update.
2876         * solib-spu.c (append_ocl_sos): Update.
2877         * psymtab.c (maintenance_print_psymbols)
2878         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2879         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2880         * printcmd.c (info_symbol_command): Update.
2881         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2882         Update.
2883         * objfiles.h (class all_objfiles): Remove.
2884         * objfiles.c (have_partial_symbols, have_full_symbols)
2885         (have_minimal_symbols, qsort_cmp, update_section_map)
2886         (shared_objfile_contains_address_p)
2887         (default_iterate_over_objfiles_in_search_order): Update.
2888         * objc-lang.c (info_selectors_command, info_classes_command)
2889         (find_methods): Update.
2890         * minsyms.c (find_solib_trampoline_target): Update.
2891         * maint.c (maintenance_info_sections)
2892         (maintenance_translate_address, count_symtabs_and_blocks):
2893         Update.
2894         * main.c (captured_main_1): Update.
2895         * linux-thread-db.c (try_thread_db_load_from_pdir)
2896         (has_libpthread): Update.
2897         * linespec.c (iterate_over_all_matching_symtabs)
2898         (search_minsyms_for_name): Update.
2899         * jit.c (jit_find_objf_with_entry_addr): Update.
2900         * hppa-tdep.c (find_unwind_entry)
2901         (hppa_lookup_stub_minimal_symbol): Update.
2902         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2903         Update.
2904         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2905         (elf_gnu_ifunc_resolve_by_got): Update.
2906         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2907         * dwarf-index-write.c (save_gdb_index_command): Update.
2908         * cp-support.c (add_symbol_overload_list_qualified): Update.
2909         * breakpoint.c (create_overlay_event_breakpoint)
2910         (create_longjmp_master_breakpoint)
2911         (create_std_terminate_master_breakpoint)
2912         (create_exception_master_breakpoint): Update.
2913         * blockframe.c (find_pc_partial_function): Update.
2914         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2915         (ada_collect_symbol_completion_matches)
2916         (ada_add_global_exceptions): Update.
2917
2918 2019-01-17  Tom Tromey  <tom@tromey.com>
2919
2920         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2921         declare VEC.
2922         (solib_target_parse_libraries): Change return type.
2923         (library_list_start_segment, library_list_start_section)
2924         (library_list_end_library, library_list_start_library); Update.
2925         (solib_target_free_library_list): Remove.
2926         (solib_target_parse_libraries): Remove cleanup.  Change return
2927         type.
2928         (solib_target_current_sos): Update.
2929
2930 2019-01-17  Tom Tromey  <tromey@bapiya>
2931
2932         * valprint.c: Replace "the the" with "the".
2933         * symtab.c: Replace "the the" with "the".
2934         * solib.c: Replace "the the" with "the".
2935         * solib-dsbt.c: Replace "the the" with "the".
2936         * linespec.c: Replace "the the" with "the".
2937         * dwarf2loc.h: Replace "the the" with "the".
2938         * amd64-windows-tdep.c: Replace "the the" with "the".
2939         * aarch64-tdep.c: Replace "the the" with "the".
2940
2941 2019-01-16  Keith Seitz  <keiths@redhat.com>
2942
2943         PR gdb/23773
2944         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2945         <builder>: Rename to ..
2946         <m_builder>: ... this and make private.
2947         (dwarf2_cu::get_builder): New method.  Change all users of
2948         `builder' to use this method.
2949         (dwarf2_start_symtab): Move to ...
2950         (dwarf2_cu::start_symtab): ... here.  Update all callers
2951         (setup_type_unit_groups): Move to ...
2952         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2953         callers.
2954         (dwarf2_cu::reset_builder): New method.
2955         (process_full_compunit, process_full_type_unit): Use
2956         dwarf2_cu::reset_builder.
2957         (follow_die_offset): Record the ancestor CU if it is different
2958         from the followed DIE's CU.
2959         (follow_die_sig_1): Likewise.
2960
2961 2019-01-15  Tom Tromey  <tom@tromey.com>
2962
2963         * remote.c (class remote_state) <buf>: Now a char_vector.
2964         <buf_size>: Remove.
2965         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2966         parameter.
2967         (remote_target::getpkt_or_notif_sane_1)
2968         (remote_target::getpkt_sane)
2969         (remote_target::getpkt_or_notif_sane): Likewise.
2970         (class remote_target) <putpkt>: New overload.
2971         (remote_target::read_frame): Change type of "buf_p".  Remove
2972         sizeof_p parameter.
2973         (packet_ok): New overload.
2974         (packet_check_result): New overload.
2975         Update all uses.
2976
2977 2019-01-14  Tom Tromey  <tom@tromey.com>
2978
2979         * remote-notif.c (handle_notification, remote_notif_ack)
2980         (remote_notif_parse): Make "buf" const.
2981         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2982         const.
2983         (remote_notif_parse, remote_notif_ack, handle_notification):
2984         Likewise.
2985         * remote.c (remote_notif_stop_parse): Make "buf" const.
2986         (remote_target::remote_parse_stop_reply): Make "buf" const.
2987         (remote_notif_stop_ack): Make "buf" const.
2988
2989 2019-01-14  Tom Tromey  <tom@tromey.com>
2990
2991         * remote.c (remote_console_output): Make parameter const.
2992
2993 2019-01-14  Tom Tromey  <tom@tromey.com>
2994
2995         * target-debug.h (target_debug_print_signals): Constify.
2996         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2997         * procfs.c (procfs_target::pass_signals): Update.
2998         * linux-nat.c (linux_nat_target::pass_signals): Update.
2999         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3000         * target-delegates.c: Rebuild.
3001         * remote.c (remote_target::program_signals): Update.
3002         (remote_target::pass_signals): Update.
3003         * target.c (target_pass_signals): Constify argument.
3004         (target_program_signals): Likewise.
3005         * target.h (struct target_ops) <pass_signals, program_signals>:
3006         Constify argument.
3007         (target_pass_signals, target_program_signals): Constify argument.
3008
3009 2019-01-14  Tom Tromey  <tom@tromey.com>
3010
3011         PR tui/28819:
3012         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3013
3014 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3015
3016         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3017         field.
3018         * rs6000-tdep.c: Include reggroups.h.
3019         (IS_V_ALIAS_PSEUDOREG): Define.
3020         (rs6000_register_name): Return names for the "vX" aliases.
3021         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3022         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3023         aliases.  Call default_register_reggroup_p for all other
3024         pseudo-registers.
3025         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3026         New functions.
3027         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3028         Handle "vX" aliases.
3029         (v_alias_pseudo_register_collect): New function.
3030         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3031         (rs6000_gdbarch_init): Initialize "vX" aliases as
3032         pseudo-registers.  Restore registration of
3033         rs6000_pseudo_register_reggroup_p with
3034         set_tdesc_pseudo_register_reggroup_p.
3035
3036 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3037
3038         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3039         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3040         set_gdbarch_num_pseudo_regs.
3041
3042 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3043
3044         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3045         Remove arg prefixname, add do_set and do_show.
3046         Add member functions set_list and show_list.
3047         * cli/cli-style.c (class cli_style_option): Update accordingly.
3048         (style_set_list): Move to file scope.
3049         (style_show_list): Likewise.
3050         (set_style): Call help_list.
3051         (show_style): Call cmd_show_list.
3052         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3053         Update to use the new macro.
3054
3055 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3056
3057         * ada-lang.c (_initialize_ada_language): Expand the help text
3058         for the "catch exception" command.
3059
3060 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3061
3062         * symtab.c (matching_obj_sections): Initialize obj,
3063         declare it closer to its usage.
3064
3065 2019-01-10  Tom Tromey  <tom@tromey.com>
3066
3067         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3068         (basic_inf_threads_range): Remove.
3069         (inf_threads_range, inf_non_exited_threads_range)
3070         (safe_inf_threads_range): Use next_adapter.
3071
3072 2019-01-10  Keith Seitz  <keiths@redhat.com>
3073
3074         PR gdb/23712
3075         PR symtab/23010
3076         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3077         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3078
3079 2019-01-10  Keith Seitz  <keiths@redhat.com>
3080
3081         PR gdb/23712
3082         PR symtab/23010
3083         * dictionary.c (pending_to_vector): Remove.
3084         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3085         Remove _1 suffix, replacing functions of the same name.  Update
3086         all callers.
3087         (dict_create_hashed, dict_create_hashed_expandable)
3088         (dict_create_linear, dict_create_linear_expandable, dict_free)
3089         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3090         Make functions static.
3091
3092 2019-01-10  Keith Seitz  <keiths@redhat.com>
3093
3094         PR gdb/23712
3095         PR symtab/23010
3096         * dictionary.h (struct dictionary): Replace declaration with
3097         multidictionary.
3098         (dict_create_hashed, dict_create_hashed_expandable)
3099         (dict_create_linear, dict_create_linear_expandable)
3100         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3101         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3102         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3103         taking multidictionary argument.
3104         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3105         * block.h (struct block) <dict>: Change to multidictionary
3106         and rename `multidict'.
3107         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3108         symmisc.c: Update all dictionary references to multidictionary.
3109
3110 2019-01-10  Keith Seitz  <keiths@redhat.com>
3111
3112         PR gdb/23712
3113         PR symtab/23010
3114         * dictionary.c: Include unordered_map.
3115         (pending_to_vector): New function.
3116         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3117         Rewrite the non-"_1" functions to take vector instead
3118         of linked list.
3119         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3120         "new" _1 versions of the same name.
3121         (multidictionary): Define.
3122         (std::hash<enum language): New definition.
3123         (collate_pending_symbols_by_language, mdict_create_hashed)
3124         (mdict_create_hashed_expandable, mdict_create_linear)
3125         (mdict_create_linear_expandable, mdict_free)
3126         (find_language_dictionary, create_new_language_dictionary)
3127         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3128         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3129         (mdict_size, mdict_empty): New functions.
3130         * dictionary.h (mdict_iterator): Define.
3131
3132 2019-01-10  Pedro Alves  <palves@redhat.com>
3133
3134         * breakpoint.c (read_uploaded_action)
3135         (create_tracepoint_from_upload): Adjust to use
3136         gdb::unique_xmalloc_ptr.
3137         * ctf.c (ctf_write_uploaded_tp):
3138         (SET_ARRAY_FIELD): Use emplace_back.
3139         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3140         * tracefile-tfile.c (tfile_write_uploaded_tp):
3141         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3142         gdb::unique_xmalloc_ptr.
3143         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3144         at_string, cond_string, cmd_strings>: Replace char pointers
3145         with gdb::unique_xmalloc_ptr.
3146
3147 2019-01-10  Pedro Alves  <palves@redhat.com>
3148
3149         * solib-target.c (library_list_start_library): Don't xstrdup name.
3150
3151 2019-01-10  Pedro Alves  <palves@redhat.com>
3152
3153         * mdebugread.c (parse_partial_symbols): Use
3154         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3155
3156 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * linux-fork.c (scoped_switch_fork_info)
3159         <~scoped_switch_fork_info>: Fix incorrect variable name.
3160
3161 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3162
3163         * linux-fork.c (scoped_switch_fork_info)
3164         <scoped_switch_fork_info>: Make explicit.
3165         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3166
3167 2019-01-10  Tom Tromey  <tom@tromey.com>
3168
3169         * objfiles.h (objfile::reset_psymtabs): Update.
3170         * objfiles.c (objfile::objfile): Update.
3171         * psymtab.h (psymtab_storage::obstack): Update.
3172         (psymtab_storage::m_obstack): Use gdb::optional.
3173         (class psymtab_storage): Update comment.  Remove objfile
3174         parameter.
3175         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3176
3177 2019-01-10  Tom Tromey  <tom@tromey.com>
3178
3179         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3180         <free_psymtabs>: Now private.
3181         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3182         (allocate_psymtab): Use new method.
3183
3184 2019-01-10  Tom Tromey  <tom@tromey.com>
3185
3186         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3187         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3188         * mdebugread.c (parse_partial_symbols): Use
3189         allocate_dependencies.
3190         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3191         allocate_dependencies.
3192         (process_psymtab_comp_unit_reader)
3193         (build_type_psymtab_dependencies): Likewise.
3194         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3195
3196 2019-01-10  Tom Tromey  <tom@tromey.com>
3197
3198         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3199         PSYMBOL_SET_LANGUAGE.
3200         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3201
3202 2019-01-10  Tom Tromey  <tom@tromey.com>
3203
3204         * psymtab.h (psymtab_storage::obstack): New method.
3205         <m_obstack>: Rename from obstack; now private.
3206         * psymtab.c (psymtab_storage): Update.
3207         * dwarf2read.c (create_addrmap_from_index)
3208         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3209         Update.
3210
3211 2019-01-10  Tom Tromey  <tom@tromey.com>
3212
3213         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3214         * objfiles.h (objfile::reset_psymtabs): New method.
3215
3216 2019-01-10  Tom Tromey  <tom@tromey.com>
3217
3218         * symmisc.c (print_symbol_bcache_statistics): Update.
3219         (print_objfile_statistics): Update.
3220         * symfile.c (reread_symbols): Update.
3221         * psymtab.h (class psymtab_storage): New.
3222         * psymtab.c (psymtab_storage): New constructor.
3223         (~psymtab_storage): New destructor.
3224         (require_partial_symbols): Update.
3225         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3226         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3227         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3228         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3229         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3230         (start_psymtab_common, end_psymtab_common)
3231         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3232         (allocate_psymtab): Update.
3233         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3234         Update.
3235         (dump_psymtab_addrmap, maintenance_print_psymbols)
3236         (maintenance_check_psymtabs): Update.
3237         (class objfile_psymtabs): Move to objfiles.h.
3238         * psympriv.h (discard_psymtab): Now inline.
3239         (psymtab_discarder::psymtab_discarder): Update.
3240         (psymtab_discarder::~psymtab_discarder): Update.
3241         (ALL_OBJFILE_PSYMTABS): Rewrite.
3242         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3243         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3244         Remove fields.
3245         <partial_symtabs>: New field.
3246         (class objfile_psymtabs): Move from psymtab.h.  Update.
3247         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3248         psymbol_cache.
3249         (objfile::~objfile): Don't destroy psymbol_cache.
3250         * mdebugread.c (parse_partial_symbols): Update.
3251         * dwarf2read.c (create_addrmap_from_index)
3252         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3253         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3254         (add_partial_subprogram, dwarf2_ranges_read): Update.
3255         * dwarf-index-write.c (write_address_map)
3256         (write_one_signatured_type, recursively_write_psymbols)
3257         (class debug_names, class debug_names, write_psymtabs_to_index):
3258         Update.
3259
3260 2019-01-10  Tom Tromey  <tom@tromey.com>
3261
3262         * symtab.h (SYMBOL_SET_NAMES): Update.
3263         (symbol_set_names): Update.
3264         (MSYMBOL_SET_NAMES): Update.
3265         * symtab.c (symbol_set_names): Change argument to be an
3266         objfile_per_bfd_storage.
3267         * psymtab.c (add_psymbol_to_bcache): Update.
3268         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3269
3270 2019-01-10  Tom Tromey  <tom@tromey.com>
3271
3272         * symtab.c (create_demangled_names_hash): Change argument to be an
3273         objfile_per_bfd_storage.
3274         (symbol_set_names): Update.
3275
3276 2019-01-10  Tom Tromey  <tom@tromey.com>
3277
3278         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3279         init_psymbol_list.
3280         * psymtab.c (init_psymbol_list): Do nothing if already called.
3281         * psympriv.h (init_psymbol_list): Add comment.
3282         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3283         init_psymbol_list.
3284         * dbxread.c (dbx_symfile_read): Unconditionally call
3285         init_psymbol_list.
3286
3287 2019-01-10  Tom Tromey  <tom@tromey.com>
3288
3289         * xcoffread.c (scan_xcoff_symtab): Update.
3290         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3291         "where".
3292         * mdebugread.c (parse_partial_symbols)
3293         (handle_psymbol_enumerators): Update.
3294         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3295         * dbxread.c (read_dbx_symtab): Update.
3296         * psympriv.h (psymbol_placement): New enum.
3297         (add_psymbol_to_list): Update.
3298
3299 2019-01-10  Tom Tromey  <tom@tromey.com>
3300
3301         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3302         static_psymbols parameters.
3303         (scan_xcoff_symtab): Update.
3304         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3305         static_psymbols parameters.
3306         * psympriv.h (start_psymtab_common): Update.
3307         * mdebugread.c (parse_partial_symbols): Update.
3308         * dwarf2read.c (create_partial_symtab): Update.
3309         * dbxread.c (read_dbx_symtab): Update.
3310         (start_psymtab): Remove global_psymbols and static_psymbols
3311         parameters.
3312
3313 2019-01-10  Tom Tromey  <tom@tromey.com>
3314
3315         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3316         * psymtab.c (allocate_psymtab): Add comment.
3317         * psympriv.h (allocate_psymtab): Add comment.
3318         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3319         initializations.
3320         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3321
3322 2019-01-10  Tom Tromey  <tom@tromey.com>
3323
3324         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3325         Don't declare.
3326         * mipsread.c: Include mdebugread.h.
3327         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3328         Declare.
3329         * elfread.c: Include mdebugread.h.
3330
3331 2019-01-09  Tom Tromey  <tom@tromey.com>
3332
3333         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3334         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3335         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3336         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3337         (psym_lookup_symbol, psym_find_last_source_symtab)
3338         (psym_forget_cached_source_info, psym_print_stats)
3339         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3340         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3341         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3342         (psym_find_compunit_symtab_by_address)
3343         (maintenance_print_psymbols, maintenance_info_psymtabs)
3344         (maintenance_check_psymtabs): Use ranged for.
3345         * psymtab.h (class objfile_psymtabs): New.
3346         (require_partial_symbols): Return objfile_psymtabs.
3347         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3348
3349 2019-01-09  Tom Tromey  <tom@tromey.com>
3350
3351         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3352         (find_pc_mapped_section, list_overlays_command)
3353         (map_overlay_command, unmap_overlay_command)
3354         (simple_overlay_update): Use all_objfiles.
3355         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3356         * printcmd.c (info_symbol_command): Use all_objfiles.
3357         * objfiles.h (ALL_OBJSECTIONS): Remove.
3358         * maint.c (maintenance_translate_address): Use all_objfiles.
3359         * gcore.c (gcore_create_callback): Use all_objfiles.
3360         (objfile_find_memory_regions): Likewise.
3361
3362 2019-01-09  Tom Tromey  <tom@tromey.com>
3363
3364         * symtab.c (find_line_symtab, info_sources_command)
3365         (make_source_files_completion_list): Use objfile_compunits.
3366         * source.c (select_source_symtab): Use objfile_compunits.
3367         * objfiles.h (struct objfile): Update comment.
3368         (ALL_OBJFILES): Remove.
3369         (ALL_FILETABS): Remove.
3370         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3371         objfile_compunits.
3372
3373 2019-01-09  Tom Tromey  <tom@tromey.com>
3374
3375         * symmisc.c (print_objfile_statistics, dump_objfile)
3376         (maintenance_print_symbols): Use compunit_filetabs.
3377         * source.c (forget_cached_source_info_for_objfile): Use
3378         compunit_filetabs.
3379         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3380         (ALL_FILETABS): Use compunit_filetabs.
3381         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3382         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3383
3384 2019-01-09  Tom Tromey  <tom@tromey.com>
3385
3386         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3387         (compunit_filetabs): New.
3388         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3389         compunit_filetabs.
3390         (info_sources_command, make_source_files_completion_list): Remove
3391         declaration.
3392         * symmisc.c (print_objfile_statistics, dump_objfile)
3393         (maintenance_print_symbols): Remove declaration.
3394         (maintenance_info_symtabs): Use compunit_filetabs.
3395         (maintenance_info_line_tables): Likewise.
3396         * source.c (select_source_symtab): Change local variable name.
3397         (forget_cached_source_info_for_objfile): Remove declaration.
3398         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3399         * objfiles.c (objfile_relocate1): Remove declaration.
3400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3401         declaration.
3402         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3403         * coffread.c (coff_symtab_read): Remove declaration.
3404         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3405         compunit_filetabs.
3406
3407 2019-01-09  Tom Tromey  <tom@tromey.com>
3408
3409         * symtab.c (lookup_objfile_from_block)
3410         (find_pc_sect_compunit_symtab, search_symbols)
3411         (default_collect_symbol_completion_matches_break_on): Use
3412         objfile_compunits.
3413         * objfiles.h (ALL_COMPUNITS): Remove.
3414         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3415         * cp-support.c (add_symbol_overload_list_qualified): Use
3416         objfile_compunits.
3417         * ada-lang.c (ada_collect_symbol_completion_matches)
3418         (ada_add_global_exceptions): Use objfile_compunits.
3419
3420 2019-01-09  Tom Tromey  <tom@tromey.com>
3421
3422         * source.c (select_source_symtab)
3423         (forget_cached_source_info_for_objfile): Remove declaration.
3424         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3425         declaration.
3426         * maint.c (count_symtabs_and_blocks): Remove declaration.
3427         * cp-support.c (add_symbol_overload_list_qualified): Remove
3428         declaration.
3429         * coffread.c (coff_symtab_read): Remove declaration.
3430         * symtab.c (lookup_symbol_in_objfile_symtabs)
3431         (basic_lookup_transparent_type_1): Use objfile_compunits.
3432         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3433         (info_sources_command, search_symbols)
3434         (default_collect_symbol_completion_matches_break_on)
3435         (make_source_files_completion_list): Remove declaration.
3436         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3437         (ada_collect_symbol_completion_matches)
3438         (ada_add_global_exceptions): Remove declaration.
3439         * linespec.c (iterate_over_all_matching_symtabs): Use
3440         objfile_compunits.
3441         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3442         (class objfile_compunits): New.
3443         (ALL_COMPUNITS): Use objfile_compunits.
3444         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3445         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3446         objfile_compunits.
3447         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3448
3449 2019-01-09  Tom Tromey  <tom@tromey.com>
3450
3451         * symtab.c (search_symbols)
3452         (default_collect_symbol_completion_matches_break_on): Use
3453         objfile_msymbols.
3454         * ada-lang.c (ada_lookup_simple_minsym)
3455         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3456         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3457         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3458         objfile_msymbols.
3459         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3460         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3461         * objc-lang.c (find_methods): Use objfile_msymbols.
3462         (info_selectors_command, info_classes_command): Likewise.
3463         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3464         * objfiles.h (class objfile_msymbols): New.
3465         (ALL_OBJFILE_MSYMBOLS): Remove.
3466         (ALL_MSYMBOLS): Remove.
3467
3468 2019-01-09  Tom Tromey  <tom@tromey.com>
3469
3470         * common/next-iterator.h (next_adapter): Add Iterator template
3471         parameter.
3472         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3473         (class all_objfiles_safe): New.
3474         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3475         * objfiles.c (put_objfile_before): Update comment.
3476         (add_separate_debug_objfile): Likewise.
3477         (free_all_objfiles): Use all_objfiles_safe.
3478         (objfile_purge_solibs): Likewise.
3479
3480 2019-01-09  Tom Tromey  <tom@tromey.com>
3481
3482         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3483         (expand_symtab_containing_pc, lookup_static_symbol)
3484         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3485         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3486         all_objfiles.
3487         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3488         * breakpoint.c (create_overlay_event_breakpoint)
3489         (create_longjmp_master_breakpoint)
3490         (create_std_terminate_master_breakpoint)
3491         (create_exception_master_breakpoint): Use all_objfiles.
3492         * linux-thread-db.c (try_thread_db_load_from_pdir)
3493         (has_libpthread): Use all_objfiles.
3494         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3495         * linespec.c (iterate_over_all_matching_symtabs)
3496         (search_minsyms_for_name): Use all_objfiles.
3497         * maint.c (maintenance_info_sections): Use all_objfiles.
3498         * main.c (captured_main_1): Use all_objfiles.
3499         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3500         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3501         * guile/scm-pretty-print.c
3502         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3503         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3504         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3505         (maintenance_print_msymbols): Use all_objfiles.
3506         * source.c (select_source_symtab): Use all_objfiles.
3507         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3508         * symfile.c (remove_symbol_file_command)
3509         (expand_symtabs_matching, map_symbol_filenames): Use
3510         all_objfiles.
3511         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3512         all_objfiles.
3513         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3514         * objc-lang.c (find_methods): Use all_objfiles.
3515         * objfiles.c (have_partial_symbols, have_full_symbols)
3516         (have_minimal_symbols, qsort_cmp)
3517         (default_iterate_over_objfiles_in_search_order): Use
3518         all_objfiles.
3519         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3520         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3521         (maintenance_check_psymtabs): Use all_objfiles.
3522         (ALL_PSYMTABS): Remove.
3523         * compile/compile-object-run.c (do_module_cleanup): Use
3524         all_objfiles.
3525         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3526         * cp-support.c (add_symbol_overload_list_qualified): Use
3527         all_objfiles.
3528         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3529         Use all_objfiles.
3530         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3531         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3532         all_objfiles.
3533         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3534         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3535         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3536         Uses all_objfiles.
3537         * solib.c (solib_read_symbols): Use all_objfiles
3538
3539 2019-01-09  Tom Tromey  <tom@tromey.com>
3540
3541         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3542         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3543         all_objfiles.
3544         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3545         * symmisc.c (print_symbol_bcache_statistics)
3546         (print_objfile_statistics, maintenance_print_objfiles)
3547         (maintenance_info_symtabs, maintenance_check_symtabs)
3548         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3549         all_objfiles.
3550         * source.c (forget_cached_source_info): Use all_objfiles.
3551         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3552         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3553         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3554         * objfiles.c (update_section_map): Use all_objfiles.
3555         (shared_objfile_contains_address_p): Likewise.
3556         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3557         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3558
3559 2019-01-09  Tom Tromey  <tom@tromey.com>
3560
3561         * common/next-iterator.h: New file.
3562         * objfiles.h (class all_objfiles): New.
3563         (struct objfile_iterator): New.
3564
3565 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3566
3567         * NEWS: Move the description of the changed "frame", "select-frame",
3568          and "info frame" commands to the Changed commands section.
3569
3570 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3571
3572         * gdbtypes.c (check_stub_method_group): Remove handling of old
3573         mangling schemes.
3574         * linespec.c (find_methods): Likewise.
3575         * stabsread.c (read_member_functions): Likewise.
3576         * valops.c (search_struct_method): Likewise.
3577         (value_struct_elt_for_reference): Likewise.
3578         * NEWS: Mention this change.
3579
3580 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3581
3582         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3583         print_source_lines.
3584         * source.c (print_source_lines_base): Update line number check.
3585         (print_source_lines): New function.
3586         (source_lines_range::source_lines_range): New function.
3587         * source.h (class source_lines_range): New class.
3588         (print_source_lines): New declaration.
3589
3590 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3591
3592         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3593
3594 2019-01-08  Tom Tromey  <tom@tromey.com>
3595             Simon Marchi  <simon.marchi@ericsson.com>
3596
3597         PR gdb/24060
3598         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3599         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3600         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3601         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3602         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3603         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3604
3605 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3606
3607         * source.c (select_source_symtab): Move header comment to
3608         declaration in source.h.
3609         (forget_cached_source_info_for_objfile): Likewise.
3610         (forget_cached_source_info): Likewise.
3611         (identify_source_line): Likewise.
3612         * source.h (identify_source_line): Move declaration from symtab.h
3613         and add comment from source.c
3614         (print_source_lines): Likewise.
3615         (forget_cached_source_info_for_objfile): Likewise.
3616         (forget_cached_source_info): Likewise.
3617         (select_source_symtab): Likewise.
3618         (enum print_source_lines_flag): Move definition from symtab.h.
3619         * symtab.h (identify_source_line): Move declaration to source.h.
3620         (print_source_lines): Likewise.
3621         (forget_cached_source_info_for_objfile): Likewise.
3622         (forget_cached_source_info): Likewise.
3623         (select_source_symtab): Likewise.
3624         (enum print_source_lines_flag): Move definition to source.h.
3625         * tui/tui-hooks.c: Add 'source.h' include.
3626
3627 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * source.c (print_source_lines_base): Handle requests to print
3630         reverse line number sequences, and guard against empty lines
3631         string.
3632
3633 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         * source.c (print_source_lines_base): Fix skip of '\r' if next
3636         character is '\n'.
3637
3638 2019-01-06  Tom Tromey  <tom@tromey.com>
3639
3640         * c-exp.y (struct c_parse_state) <macro_original_text,
3641         expansion_obstack>: New member.
3642         (macro_original_text, expansion_obstack): Remove globals.
3643         (scan_macro_expansion, scanning_macro_expansion)
3644         (finished_macro_expansion): Update.
3645         (scan_macro_cleanup): Remove.
3646         (yylex, c_parse): Update.
3647
3648 2019-01-06  Tom Tromey  <tom@tromey.com>
3649
3650         * c-exp.y (struct c_parse_state) <strings>: New member.
3651         (operator_stoken): Update.
3652
3653 2019-01-06  Tom Tromey  <tom@tromey.com>
3654
3655         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3656         (union type_stack_elt) <typelist_val>: Now a pointer to
3657         std::vector.
3658         (type_stack_cleanup): Don't declare.
3659         (push_typelist): Update.
3660         * parse.c (pop_typelist): Return a std::vector.
3661         (push_typelist): Take a std::vector.
3662         (follow_types): Update.  Do not free args.
3663         (type_stack_cleanup): Remove.
3664         * c-exp.y (struct c_parse_state): New.
3665         (cpstate): New global.
3666         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3667         (nonempty_typelist): Update.
3668         (func_mod): Create a new vector.
3669         (c_parse): Create a c_parse_state.
3670         (check_parameter_typelist): Do not delete params.
3671         (function_method): Update.  Do not delete type_list.
3672
3673 2019-01-06  Tom Tromey  <tom@tromey.com>
3674
3675         PR gdb/28155:
3676         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3677         check_typedef.
3678         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3679         (print_return_value): Likewise.
3680
3681 2019-01-05  Tom Tromey  <tom@tromey.com>
3682
3683         * contrib/cleanup_check.py: Remove.
3684         * contrib/gcc-with-excheck: Remove.
3685         * contrib/exsummary.py: Remove.
3686         * contrib/excheck.py: Remove.
3687
3688 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3689
3690         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3691         NULL. Initialize tpprev to NULL instead of assigning it
3692         to NULL on the next statement.
3693         * windows-nat.c (windows_delete_thread): Remove check for
3694         main_thread_id before printing thread exit notifications.
3695         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3696         Remove thread ID check against main_thread_id.
3697         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3698         windows_delete_thread.
3699         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3700
3701 2019-01-04  Tom Tromey  <tom@tromey.com>
3702
3703         * compile/compile.c (_initialize_compile): Use upper case for
3704         metasyntactic variables.
3705         * symmisc.c (_initialize_symmisc): Use upper case for
3706         metasyntactic variables.
3707         * psymtab.c (_initialize_psymtab): Use upper case for
3708         metasyntactic variables.
3709         * demangle.c (demangle_command): Use upper case for metasyntactic
3710         variables.
3711         (_initialize_demangler): Likewise.
3712         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3713         variables.
3714
3715 2019-01-03  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3718
3719 2019-01-03  Tom Tromey  <tom@tromey.com>
3720
3721         * python/py-symtab.c (salpy_str): Update.
3722         (struct salpy_sal_object) <symtab>: Now a PyObject.
3723         (salpy_dealloc): Update.
3724         (del_objfile_sal): Use gdbpy_ref.
3725
3726 2019-01-03  Tom Tromey  <tom@tromey.com>
3727
3728         * python/py-type.c (convert_field): Use new_reference.  Return
3729         gdbpy_ref.
3730         (make_fielditem): Return gdbpy_ref.
3731         (typy_fields): Update.
3732         (typy_getitem): Update.
3733         (field_name): Return gdbpy_ref.  Use new_reference.
3734         (typy_iterator_iternext): Update.
3735
3736 2019-01-03  Tom Tromey  <tom@tromey.com>
3737
3738         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3739
3740 2019-01-03  Tom Tromey  <tom@tromey.com>
3741
3742         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3743         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3744         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3745         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3746         (pspy_set_type_printers): Likewise.
3747         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3748         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3749         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3750         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3751         (objfpy_set_type_printers): Likewise.
3752
3753 2019-01-03  Tom Tromey  <tom@tromey.com>
3754
3755         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3756         (gdbpy_print_stack): Use gdbpy_err_fetch.
3757         * python/python-internal.h (class gdbpy_err_fetch): New class.
3758         (class gdbpy_enter) <m_error_type, m_error_value,
3759         m_error_traceback>: Remove.
3760         <m_error>: New member.
3761         (gdbpy_exception_to_string): Don't declare.
3762         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3763         * python/py-value.c (convert_value_from_python): Use
3764         gdbpy_err_fetch.
3765         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3766         gdbpy_exception_to_string.
3767         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3768         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3769         gdbpy_err_fetch.
3770
3771 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * linux-nat.c (delete_lwp_cleanup): Delete.
3774         (struct lwp_deleter): New struct.
3775         (lwp_info_up): New typedef.
3776         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3777         lwp_info_up.
3778
3779 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * linux-fork.c (class scoped_switch_fork_info): New class.
3782         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3783
3784 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * valops.c (find_overload_match): Remove use of null_cleanup, and
3787         calls to do_cleanups.
3788
3789 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * compile/compile-cplus-types.c
3792         (compile_cplus_instance::decl_name): Handle changes to
3793         cp_func_name.
3794         * cp-support.c (cp_func_name): Update header comment, update
3795         return type.
3796         * cp-support.h (cp_func_name): Update return type in declaration.
3797         * valops.c (find_overload_match): Move temp_func local to top
3798         level of function and change its type.  Use temp_func to hold and
3799         delete temporary string obtained from cp_func_name.
3800
3801 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3804         gdb::char_vector, remove cleanup, and update uses of `msg`.
3805
3806 2019-01-03  Jim Wilson  <jimw@sifive.com>
3807
3808         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3809
3810 2019-01-02  Tom Tromey  <tom@tromey.com>
3811
3812         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3813         (tdesc_parse_xml): Remove cleanups.
3814         * target-descriptions.h (make_cleanup_free_target_description):
3815         Don't declare.
3816         (target_desc_deleter): New struct.
3817         (target_desc_up): New typedef.
3818         * target-descriptions.c (target_desc_deleter::operator()): Rename
3819         from free_target_description.
3820         (make_cleanup_free_target_description): Remove.
3821
3822 2019-01-02  Tom Tromey  <tom@tromey.com>
3823
3824         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3825         constructor, destructor.
3826         (linespec_parser): Remove typedef.
3827         (~linespec_parser): Rename from linespec_parser_delete.
3828         (linespec_lex_to_end, linespec_complete_label)
3829         (linespec_complete): Update.
3830         (decode_line_full): Remove cleanups.
3831         (decode_line_1): Update.
3832
3833 2019-01-02  Tom Tromey  <tom@tromey.com>
3834
3835         * python/python-internal.h (inferior_to_inferior_object): Change
3836         return type.
3837         * python/py-exitedevent.c (create_exited_event_object): Update.
3838         * python/py-inferior.c (inferior_to_inferior_object): Return
3839         gdbpy_ref.
3840         (python_new_inferior, python_inferior_deleted)
3841         (thread_to_thread_object, delete_thread_object)
3842         (build_inferior_list, gdbpy_selected_inferior): Update.
3843         * python/py-infthread.c (create_thread_object): Update.  Also fail
3844         if inferior_to_inferior_object fails.
3845
3846 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3847
3848         * inferior.h (class inferior) <displaced_step_state>: New field.
3849         * infrun.h (struct displaced_step_state): Move here from
3850         infrun.c.  Initialize fields, add constructor.
3851         <inf>: Remove field.
3852         <reset>: New method.
3853         * infrun.c (struct displaced_step_inferior_state): Move to
3854         infrun.h.
3855         (displaced_step_inferior_states): Remove.
3856         (get_displaced_stepping_state): Adust.
3857         (displaced_step_in_progress_any_inferior): Adjust.
3858         (displaced_step_in_progress_thread): Adjust.
3859         (displaced_step_in_progress): Adjust.
3860         (add_displaced_stepping_state): Remove.
3861         (get_displaced_step_closure_by_addr): Adjust.
3862         (remove_displaced_stepping_state): Remove.
3863         (infrun_inferior_exit): Call displaced_step_state.reset.
3864         (use_displaced_stepping): Don't check for NULL.
3865         (displaced_step_prepare_throw): Call
3866         get_displaced_stepping_state.
3867         (displaced_step_fixup): Don't check for NULL.
3868         (prepare_for_detach): Don't check for NULL.
3869
3870 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3871
3872         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3873          in case of call that did not complete.
3874
3875 2019-01-02  Andrey Utkin  <autkin@undo.io>
3876
3877         * symfile.c (find_separate_debug_file): Fix search of debug files for
3878         remote debuggee.
3879
3880 2019-01-02  Tom Tromey  <tom@tromey.com>
3881
3882         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3883         indentation.
3884         * python/py-frame.c (frapy_older): Remove cast.
3885         (frapy_newer): Likewise.
3886         * python/py-breakpoint.c (local_setattro): Remove cast.
3887         * python/py-arch.c (archpy_name): Remove local variable.
3888         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3889
3890 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3891
3892         * unittests/basic_string_view/element_access/char/empty.cc:
3893         Fix year range in copyright header.
3894
3895 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3898         Delete.
3899         <operator==>: Update with for removed field.
3900         <hash>: Likewise.
3901         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3902         <isa_features>: ...this.
3903         <abi_features>: New field.
3904         (riscv_isa_flen): Update comment.
3905         (riscv_abi_xlen): New declaration.
3906         (riscv_abi_flen): New declaration.
3907         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3908         isa_features.
3909         (riscv_abi_xlen): New function.
3910         (riscv_isa_flen): Update to get answer from isa_features.
3911         (riscv_abi_flen): New function.
3912         (riscv_has_fp_abi): Update to get answer from abi_features.
3913         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3914         xlen and flen.
3915         (riscv_call_info) <xlen, flen>: Update comment.
3916         (riscv_call_arg_struct): Remove invalid assertions
3917         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3918         is removed.
3919         (riscv_gdbarch_init): Gather isa features and abi features
3920         separately, ensure both match on the gdbarch when reusing an old
3921         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3922         a target with 64-bit float hardware.
3923
3924 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925
3926         * source.c (search_command_helper): Stop reverse search
3927         when line 1 has been searched.
3928
3929 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3930
3931         * record-full.c (record_full_base_target::close): Rewrite
3932         record_full_core_buf_list free logic.
3933
3934 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3935
3936         * break-catch-syscall.c (print_one_catch_syscall): xfree
3937         the last text.
3938
3939 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3940
3941         * top.c (print_gdb_version): Update Copyright year in version
3942         message.
3943
3944 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3945
3946         Update copyright year range in all GDB files.
3947
3948 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3949
3950         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3951
3952 For older changes see ChangeLog-2018.
3953 \f
3954 Local Variables:
3955 mode: change-log
3956 left-margin: 8
3957 fill-column: 74
3958 version-control: never
3959 coding: utf-8
3960 End:
3961