gdb/ChangeLog

   1 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aarch64_add_reggroups): New function.
   4         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
   5
   6 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
   7
   8         * top.h (source_file_name): Change to std::string.
   9         * top.c (source_file_name): Likewise.
  10         (command_line_input): Adjust.
  11         * cli/cli-script.c (script_from_file): Adjust.
  12
  13 2019-02-19  Tom Tromey  <tromey@adacore.com>
  14
  15         * ravenscar-thread.c
  16         (ravenscar_thread_target::update_thread_list): Don't call
  17         ada_build_task_list.
  18         * ada-lang.h (ada_build_task_list): Don't declare.
  19         * ada-tasks.c (struct ada_tasks_inferior_data)
  20         <task_list_valid_p>: Now bool.
  21         (read_known_tasks, ada_task_list_changed)
  22         (ada_tasks_invalidate_inferior_data): Update.
  23         (read_known_tasks_array): Return bool.
  24         (read_known_tasks_list): Likewise.
  25         (read_known_tasks): Return void.
  26         (ada_build_task_list): Now static.
  27
  28 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  31         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  32
  33 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  34
  35         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  36         variant for ada_tasks_pspace_data_handle and
  37         ada_tasks_inferior_data_handle.
  38         (ada_tasks_pspace_data_cleanup): New function.
  39         (ada_tasks_inferior_data_cleanup): New function.
  40
  41 2019-02-17  Tom Tromey  <tom@tromey.com>
  42
  43         * macrotab.h (macro_source_fullname): Return a std::string.
  44         * macrotab.c (macro_include, check_for_redefinition)
  45         (macro_undef, macro_lookup_definition, foreach_macro)
  46         (foreach_macro_in_scope): Update.
  47         (macro_source_fullname): Return a std::string.
  48         * macrocmd.c (show_pp_source_pos): Update.
  49
  50 2019-02-17  Tom Tromey  <tom@tromey.com>
  51
  52         * macrocmd.c (show_pp_source_pos): Style the file names.
  53
  54 2019-02-17  Tom Tromey  <tom@tromey.com>
  55
  56         PR tui/24197:
  57         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  58
  59 2019-02-17  Tom Tromey  <tom@tromey.com>
  60
  61         * ada-lang.c (user_select_syms): Use filtered printing.
  62         * utils.c (wrap_style): New global.
  63         (desired_style): Remove.
  64         (emit_style_escape): Add stream parameter.
  65         (set_output_style, reset_terminal_style, prompt_for_continue):
  66         Update.
  67         (flush_wrap_buffer): Only flush gdb_stdout.
  68         (wrap_here): Set wrap_style.
  69         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  70         treat escape sequences as a character.  Change when wrap buffer is
  71         flushed.
  72         (fputs_styled): Do not set the output style when the default is
  73         requested.
  74         * ui-style.h (struct ui_file_style) <is_default>: New method.
  75         * source.c (print_source_lines_base): Emit escape sequences in one
  76         piece.
  77
  78 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  79
  80         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  81         integers and enumeration types.
  82
  83 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  84
  85         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  86         instead of lookup_symbol_in_language
  87         (do_exact_match): New function.
  88         (ada_get_symbol_name_matcher): Return do_exact_match when
  89         doing a verbatim match.
  90
  91 2019-02-15  Tom Tromey  <tromey@adacore.com>
  92
  93         * ravenscar-thread.c (ravenscar_thread_target::resume)
  94         (ravenscar_thread_target::wait): Special case wildcard requests.
  95
  96 2019-02-15  Tom Tromey  <tromey@adacore.com>
  97
  98         * ravenscar-thread.c (base_ptid): Remove.
  99         (struct ravenscar_thread_target) <close>: New method.
 100         <m_base_ptid>: New member.
 101         <update_inferior_ptid, active_task, task_is_currently_active,
 102         runtime_initialized>: Declare methods.
 103         <ravenscar_thread_target>: Add constructor.
 104         (ravenscar_thread_target::task_is_currently_active)
 105         (ravenscar_thread_target::update_inferior_ptid)
 106         (ravenscar_runtime_initialized): Rename.  Now methods.
 107         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 108         (ravenscar_thread_target::update_thread_list): Update.
 109         (ravenscar_thread_target::active_task): Now method.
 110         (ravenscar_thread_target::store_registers)
 111         (ravenscar_thread_target::prepare_to_store)
 112         (ravenscar_thread_target::prepare_to_store)
 113         (ravenscar_thread_target::mourn_inferior): Update.
 114         (ravenscar_inferior_created): Use "new" to create target.
 115         (ravenscar_thread_target::get_ada_task_ptid): Update.
 116         (_initialize_ravenscar): Don't initialize base_ptid.
 117         (ravenscar_ops): Remove global.
 118
 119 2019-02-15  Tom Tromey  <tromey@adacore.com>
 120
 121         * target.h (push_target): Declare new overload.
 122         * target.c (push_target): New overload, taking an rvalue reference.
 123         * remote.c (remote_target::open_1): Use push_target overload.
 124         * corelow.c (core_target_open): Use push_target overload.
 125
 126 2019-02-15  Tom Tromey  <tromey@adacore.com>
 127
 128         * ravenscar-thread.c (is_ravenscar_task)
 129         (ravenscar_task_is_currently_active): Return bool.
 130         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 131         (_initialize_ravenscar): Remove "(void)".
 132         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 133         Return bool.
 134
 135 2019-02-15  Tom Tromey  <tromey@adacore.com>
 136
 137         * ravenscar-thread.c (ravenscar_runtime_initializer)
 138         (has_ravenscar_runtime, get_running_thread_id)
 139         (ravenscar_thread_target::resume): Fix indentation.
 140
 141 2019-02-15  Tom Tromey  <tromey@adacore.com>
 142
 143         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 144         from ravenscar_arch_ops.
 145         (sparc_ravenscar_ops::fetch_registers)
 146         (sparc_ravenscar_ops::store_registers): Now methods.
 147         (sparc_ravenscar_prepare_to_store): Remove.
 148         (sparc_ravenscar_ops): Redefine.
 149         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 150         methods and destructor.  Remove members.
 151         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 152         (ravenscar_thread_target::store_registers)
 153         (ravenscar_thread_target::prepare_to_store): Update.
 154         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 155         Remove.
 156         (struct ppc_ravenscar_powerpc_ops): Derive from
 157         ravenscar_arch_ops.
 158         (ppc_ravenscar_powerpc_ops::fetch_registers)
 159         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 160         (ppc_ravenscar_powerpc_ops): Redefine.
 161         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 162         (ppc_ravenscar_e500_ops::fetch_registers)
 163         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 164         (ppc_ravenscar_e500_ops): Redefine.
 165         * aarch64-ravenscar-thread.c
 166         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 167         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 168         (aarch64_ravenscar_fetch_registers)
 169         (aarch64_ravenscar_store_registers): Now methods.
 170         (aarch64_ravenscar_ops): Redefine.
 171
 172 2019-02-15  Tom Tromey  <tromey@adacore.com>
 173
 174         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 175         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 176         (ravenscar_thread_target::stopped_by_watchpoint)
 177         (ravenscar_thread_target::stopped_data_address)
 178         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 179
 180 2019-02-15  Tom Tromey  <tromey@adacore.com>
 181
 182         * ravenscar-thread.c: Fix some typos.
 183
 184 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 185             Tom Tromey  <tromey@adacore.com>
 186
 187         * ada-lang.c (ada_exception_sal): Change addr_string to a
 188         std::string.
 189         (create_ada_exception_catchpoint): Update.
 190
 191 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 192             Tom Tromey  <tromey@adacore.com>
 193
 194         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 195         (bp_location_ops): Remove.
 196         (base_breakpoint_allocate_location): Update.
 197         (free_bp_location): Update.
 198         * ada-lang.c (class ada_catchpoint_location)
 199         <ada_catchpoint_location>: Remove ops parameter.
 200         (ada_catchpoint_location_dtor): Remove.
 201         (ada_catchpoint_location_ops): Remove.
 202         (allocate_location_exception): Update.
 203         * breakpoint.h (struct bp_location_ops): Remove.
 204         (class bp_location) <bp_location>: Remove bp_location_ops
 205         parameter.
 206         <~bp_location>: Add destructor.
 207         <ops>: Remove.
 208
 209 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 210             Pedro Alves  <palves@redhat.com>
 211
 212         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 213         'PATH_MAX'.
 214
 215 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 216             Samuel Thibault  <samuel.thibault@gnu.org>
 217             Thomas Schwinge  <thomas@codesourcery.com>
 218
 219         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 220         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 221
 222 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 223
 224         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 225         (check_empty): Use "const char *".
 226
 227         * gnu-nat.c (gnu_nat_target::detach): Instead of
 228         'detach_inferior (pid)' call
 229         'detach_inferior (find_inferior_pid (pid))'.
 230
 231         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 232         'nat/fork-inferior.o'.
 233         * gnu-nat.c: #include "nat/fork-inferior.h".
 234
 235         * gnu-nat.c (gnu_nat_target::detach): Instead of
 236         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 237         * gnu-nat.h: #include "inf-child.h".
 238         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 239         'i386_gnu_nat_target::fetch_registers'.
 240         (gnu_store_registers): Rename/move to
 241         'i386_gnu_nat_target::store_registers'.
 242
 243         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 244         * gnu-nat.h (mach_thread_info): New function.
 245         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 246
 247         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 248
 249 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 250
 251         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 252
 253 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 254
 255         * windows-nat.c (windows_add_thread): Add new parameter
 256         "main_thread_p" with default value set to false.  Update
 257         function documentation as well as all callers.
 258         (windows_delete_thread): Likewise.
 259         (fake_create_process): Update call to windows_add_thread.
 260         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 261         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 262         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 263         call to windows_delete_thread.
 264
 265 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 266
 267         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 268
 269 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 270
 271         * symfile.c (find_separate_debug_file): Use canonical path of
 272         sysroot with child_path instead of gdb_sysroot if it is valid.
 273
 274 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 275
 276         * symfile.c (find_separate_debug_file): Use child_path to
 277         determine if an object file is under a sysroot.
 278
 279 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 280
 281         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 282         unittests/child-path-selftests.c.
 283         * common/pathstuff.c (child_path): New function.
 284         * common/pathstuff.h (child_path): New prototype.
 285         * unittests/child-path-selftests.c: New file.
 286
 287 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 288
 289         * symfile.c (find_separate_debug_file): Look for separate debug
 290         files in debug directories under the sysroot.
 291
 292 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 293
 294         * symtab.h (struct minimal_symbol data_p): New const method.
 295         (struct minimal_symbol text_p): Likewise.
 296         * symtab.c (output_source_filename): Use file name style
 297         to print file name.
 298         (print_symbol_info): Likewise.
 299         (print_msymbol_info): Use address style to print addresses.
 300         Use function name style to print executable text symbols.
 301         (expand_symtab_containing_pc): Use data_p.
 302         (find_pc_sect_compunit_symtab): Likewise.
 303
 304 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 305
 306         * breakpoint.c (describe_other_breakpoints): Use address style
 307         to print addresses.
 308         (say_where): Likewise.
 309
 310 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 311
 312         * ada-typeprint.c (print_func_type): Print function name
 313         style to print function name.
 314         * c-typeprint.c (c_print_type_1): Likewise.
 315
 316 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 319         for execve.
 320
 321 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 322
 323         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 324         type_stack.
 325
 326 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 327
 328         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 329         TYPE_CODE_REF types.
 330
 331 2019-02-08  Jim Wilson  <jimw@sifive.com>
 332
 333         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 334         (riscv_linux_fregset): New.
 335         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 336
 337 2019-02-07  Tom Tromey  <tom@tromey.com>
 338
 339         * thread.c (thread_cancel_execution_command): Update.
 340         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 341         methods.
 342         (struct thread_fsm_ops): Remove.
 343         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 344         (thread_fsm_should_stop, thread_fsm_return_value)
 345         (thread_fsm_set_finished, thread_fsm_finished_p)
 346         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 347         Don't declare.
 348         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 349         * infrun.c (clear_proceed_status_thread)
 350         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 351         (print_stop_event): Update.
 352         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 353         Add constructor.
 354         (step_command_fsm_ops): Remove.
 355         (new_step_command_fsm): Remove.
 356         (step_1): Update.
 357         (step_command_fsm::should_stop): Rename from
 358         step_command_fsm_should_stop.
 359         (step_command_fsm::clean_up): Rename from
 360         step_command_fsm_clean_up.
 361         (step_command_fsm::do_async_reply_reason): Rename from
 362         step_command_fsm_async_reply_reason.
 363         (struct until_next_fsm): Inherit from thread_fsm.  Add
 364         constructor.
 365         (until_next_fsm_ops): Remove.
 366         (new_until_next_fsm): Remove.
 367         (until_next_fsm::should_stop): Rename from
 368         until_next_fsm_should_stop.
 369         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 370         (until_next_fsm::do_async_reply_reason): Rename from
 371         until_next_fsm_async_reply_reason.
 372         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 373         constructor.  Change type of breakpoint.
 374         (finish_command_fsm_ops): Remove.
 375         (new_finish_command_fsm): Remove.
 376         (finish_command_fsm::should_stop): Rename from
 377         finish_command_fsm_should_stop.
 378         (finish_command_fsm::clean_up): Rename from
 379         finish_command_fsm_clean_up.
 380         (finish_command_fsm::return_value): Rename from
 381         finish_command_fsm_return_value.
 382         (finish_command_fsm::do_async_reply_reason): Rename from
 383         finish_command_fsm_async_reply_reason.
 384         (finish_command): Update.
 385         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 386         Add constructor.
 387         (call_thread_fsm_ops): Remove.
 388         (call_thread_fsm::call_thread_fsm): Rename from
 389         new_call_thread_fsm.
 390         (call_thread_fsm::should_stop): Rename from
 391         call_thread_fsm_should_stop.
 392         (call_thread_fsm::should_notify_stop): Rename from
 393         call_thread_fsm_should_notify_stop.
 394         (run_inferior_call, call_function_by_hand_dummy): Update.
 395         * cli/cli-interp.c (should_print_stop_to_console): Update.
 396         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 397         Add constructor.  Change type of location_breakpoint,
 398         caller_breakpoint.
 399         (until_break_fsm_ops): Remove.
 400         (new_until_break_fsm): Remove.
 401         (until_break_fsm::should_stop): Rename from
 402         until_break_fsm_should_stop.
 403         (until_break_fsm::clean_up): Rename from
 404         until_break_fsm_clean_up.
 405         (until_break_fsm::do_async_reply_reason): Rename from
 406         until_break_fsm_async_reply_reason.
 407         (until_break_command): Update.
 408         * thread-fsm.c: Remove.
 409         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 410
 411 2019-02-07  Tom Tromey  <tom@tromey.com>
 412
 413         * yy-remap.h: Add include guard.
 414         * xtensa-tdep.h: Add include guard.
 415         * xcoffread.h: Rename include guard.
 416         * varobj-iter.h: Add include guard.
 417         * tui/tui.h: Rename include guard.
 418         * tui/tui-winsource.h: Rename include guard.
 419         * tui/tui-wingeneral.h: Rename include guard.
 420         * tui/tui-windata.h: Rename include guard.
 421         * tui/tui-win.h: Rename include guard.
 422         * tui/tui-stack.h: Rename include guard.
 423         * tui/tui-source.h: Rename include guard.
 424         * tui/tui-regs.h: Rename include guard.
 425         * tui/tui-out.h: Rename include guard.
 426         * tui/tui-layout.h: Rename include guard.
 427         * tui/tui-io.h: Rename include guard.
 428         * tui/tui-hooks.h: Rename include guard.
 429         * tui/tui-file.h: Rename include guard.
 430         * tui/tui-disasm.h: Rename include guard.
 431         * tui/tui-data.h: Rename include guard.
 432         * tui/tui-command.h: Rename include guard.
 433         * tic6x-tdep.h: Add include guard.
 434         * target/waitstatus.h: Rename include guard.
 435         * target/wait.h: Rename include guard.
 436         * target/target.h: Rename include guard.
 437         * target/resume.h: Rename include guard.
 438         * target-float.h: Rename include guard.
 439         * stabsread.h: Add include guard.
 440         * rs6000-tdep.h: Add include guard.
 441         * riscv-fbsd-tdep.h: Add include guard.
 442         * regformats/regdef.h: Rename include guard.
 443         * record.h: Rename include guard.
 444         * python/python.h: Rename include guard.
 445         * python/python-internal.h: Rename include guard.
 446         * python/py-stopevent.h: Rename include guard.
 447         * python/py-ref.h: Rename include guard.
 448         * python/py-record.h: Rename include guard.
 449         * python/py-record-full.h: Rename include guard.
 450         * python/py-record-btrace.h: Rename include guard.
 451         * python/py-instruction.h: Rename include guard.
 452         * python/py-events.h: Rename include guard.
 453         * python/py-event.h: Rename include guard.
 454         * procfs.h: Add include guard.
 455         * proc-utils.h: Add include guard.
 456         * p-lang.h: Add include guard.
 457         * or1k-tdep.h: Rename include guard.
 458         * observable.h: Rename include guard.
 459         * nto-tdep.h: Rename include guard.
 460         * nat/x86-linux.h: Rename include guard.
 461         * nat/x86-linux-dregs.h: Rename include guard.
 462         * nat/x86-gcc-cpuid.h: Add include guard.
 463         * nat/x86-dregs.h: Rename include guard.
 464         * nat/x86-cpuid.h: Rename include guard.
 465         * nat/ppc-linux.h: Rename include guard.
 466         * nat/mips-linux-watch.h: Rename include guard.
 467         * nat/linux-waitpid.h: Rename include guard.
 468         * nat/linux-ptrace.h: Rename include guard.
 469         * nat/linux-procfs.h: Rename include guard.
 470         * nat/linux-osdata.h: Rename include guard.
 471         * nat/linux-nat.h: Rename include guard.
 472         * nat/linux-namespaces.h: Rename include guard.
 473         * nat/linux-btrace.h: Rename include guard.
 474         * nat/glibc_thread_db.h: Rename include guard.
 475         * nat/gdb_thread_db.h: Rename include guard.
 476         * nat/gdb_ptrace.h: Rename include guard.
 477         * nat/fork-inferior.h: Rename include guard.
 478         * nat/amd64-linux-siginfo.h: Rename include guard.
 479         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 480         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 481         * nat/aarch64-linux.h: Rename include guard.
 482         * nat/aarch64-linux-hw-point.h: Rename include guard.
 483         * mn10300-tdep.h: Add include guard.
 484         * mips-linux-tdep.h: Add include guard.
 485         * mi/mi-parse.h: Rename include guard.
 486         * mi/mi-out.h: Rename include guard.
 487         * mi/mi-main.h: Rename include guard.
 488         * mi/mi-interp.h: Rename include guard.
 489         * mi/mi-getopt.h: Rename include guard.
 490         * mi/mi-console.h: Rename include guard.
 491         * mi/mi-common.h: Rename include guard.
 492         * mi/mi-cmds.h: Rename include guard.
 493         * mi/mi-cmd-break.h: Rename include guard.
 494         * m2-lang.h: Add include guard.
 495         * location.h: Rename include guard.
 496         * linux-record.h: Rename include guard.
 497         * linux-nat.h: Add include guard.
 498         * linux-fork.h: Add include guard.
 499         * i386-darwin-tdep.h: Rename include guard.
 500         * hppa-linux-offsets.h: Add include guard.
 501         * guile/guile.h: Rename include guard.
 502         * guile/guile-internal.h: Rename include guard.
 503         * gnu-nat.h: Rename include guard.
 504         * gdb-stabs.h: Rename include guard.
 505         * frv-tdep.h: Add include guard.
 506         * f-lang.h: Add include guard.
 507         * event-loop.h: Add include guard.
 508         * darwin-nat.h: Rename include guard.
 509         * cp-abi.h: Rename include guard.
 510         * config/sparc/nm-sol2.h: Rename include guard.
 511         * config/nm-nto.h: Rename include guard.
 512         * config/nm-linux.h: Add include guard.
 513         * config/i386/nm-i386gnu.h: Rename include guard.
 514         * config/djgpp/nl_types.h: Rename include guard.
 515         * config/djgpp/langinfo.h: Rename include guard.
 516         * compile/gcc-cp-plugin.h: Add include guard.
 517         * compile/gcc-c-plugin.h: Add include guard.
 518         * compile/compile.h: Rename include guard.
 519         * compile/compile-object-run.h: Rename include guard.
 520         * compile/compile-object-load.h: Rename include guard.
 521         * compile/compile-internal.h: Rename include guard.
 522         * compile/compile-cplus.h: Rename include guard.
 523         * compile/compile-c.h: Rename include guard.
 524         * common/xml-utils.h: Rename include guard.
 525         * common/x86-xstate.h: Rename include guard.
 526         * common/version.h: Rename include guard.
 527         * common/vec.h: Rename include guard.
 528         * common/tdesc.h: Rename include guard.
 529         * common/selftest.h: Rename include guard.
 530         * common/scoped_restore.h: Rename include guard.
 531         * common/scoped_mmap.h: Rename include guard.
 532         * common/scoped_fd.h: Rename include guard.
 533         * common/safe-iterator.h: Rename include guard.
 534         * common/run-time-clock.h: Rename include guard.
 535         * common/refcounted-object.h: Rename include guard.
 536         * common/queue.h: Rename include guard.
 537         * common/ptid.h: Rename include guard.
 538         * common/print-utils.h: Rename include guard.
 539         * common/preprocessor.h: Rename include guard.
 540         * common/pathstuff.h: Rename include guard.
 541         * common/observable.h: Rename include guard.
 542         * common/netstuff.h: Rename include guard.
 543         * common/job-control.h: Rename include guard.
 544         * common/host-defs.h: Rename include guard.
 545         * common/gdb_wait.h: Rename include guard.
 546         * common/gdb_vecs.h: Rename include guard.
 547         * common/gdb_unlinker.h: Rename include guard.
 548         * common/gdb_unique_ptr.h: Rename include guard.
 549         * common/gdb_tilde_expand.h: Rename include guard.
 550         * common/gdb_sys_time.h: Rename include guard.
 551         * common/gdb_string_view.h: Rename include guard.
 552         * common/gdb_splay_tree.h: Rename include guard.
 553         * common/gdb_setjmp.h: Rename include guard.
 554         * common/gdb_ref_ptr.h: Rename include guard.
 555         * common/gdb_optional.h: Rename include guard.
 556         * common/gdb_locale.h: Rename include guard.
 557         * common/gdb_assert.h: Rename include guard.
 558         * common/filtered-iterator.h: Rename include guard.
 559         * common/filestuff.h: Rename include guard.
 560         * common/fileio.h: Rename include guard.
 561         * common/environ.h: Rename include guard.
 562         * common/common-utils.h: Rename include guard.
 563         * common/common-types.h: Rename include guard.
 564         * common/common-regcache.h: Rename include guard.
 565         * common/common-inferior.h: Rename include guard.
 566         * common/common-gdbthread.h: Rename include guard.
 567         * common/common-exceptions.h: Rename include guard.
 568         * common/common-defs.h: Rename include guard.
 569         * common/common-debug.h: Rename include guard.
 570         * common/cleanups.h: Rename include guard.
 571         * common/buffer.h: Rename include guard.
 572         * common/btrace-common.h: Rename include guard.
 573         * common/break-common.h: Rename include guard.
 574         * cli/cli-utils.h: Rename include guard.
 575         * cli/cli-style.h: Rename include guard.
 576         * cli/cli-setshow.h: Rename include guard.
 577         * cli/cli-script.h: Rename include guard.
 578         * cli/cli-interp.h: Rename include guard.
 579         * cli/cli-decode.h: Rename include guard.
 580         * cli/cli-cmds.h: Rename include guard.
 581         * charset-list.h: Add include guard.
 582         * buildsym-legacy.h: Rename include guard.
 583         * bfin-tdep.h: Add include guard.
 584         * ax.h: Rename include guard.
 585         * arm-linux-tdep.h: Add include guard.
 586         * arm-fbsd-tdep.h: Add include guard.
 587         * arch/xtensa.h: Rename include guard.
 588         * arch/tic6x.h: Add include guard.
 589         * arch/i386.h: Add include guard.
 590         * arch/arm.h: Rename include guard.
 591         * arch/arm-linux.h: Rename include guard.
 592         * arch/arm-get-next-pcs.h: Rename include guard.
 593         * arch/amd64.h: Add include guard.
 594         * arch/aarch64-insn.h: Rename include guard.
 595         * arch-utils.h: Rename include guard.
 596         * annotate.h: Add include guard.
 597         * amd64-darwin-tdep.h: Rename include guard.
 598         * aarch64-linux-tdep.h: Add include guard.
 599         * aarch64-fbsd-tdep.h: Add include guard.
 600         * aarch32-linux-nat.h: Add include guard.
 601
 602 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 603
 604         * macrotab.c (macro_define_internal): New function that
 605         factorizes macro_define_object_internal and macro_define_function
 606         code.
 607         (macro_define_object_internal): Use macro_define_internal.
 608         (macro_define_function): Likewise.
 609
 610 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 611
 612         * macrocmd.c (extract_identifier): Return
 613         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 614         callers.
 615
 616 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 617
 618         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 619
 620 2019-02-05  Tom Tromey  <tom@tromey.com>
 621
 622         * target.c (target_stack::unpush): Move assertion earlier.
 623
 624 2019-01-30  Tom Tromey  <tom@tromey.com>
 625
 626         PR python/23615:
 627         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 628         (gdbpy_parse_and_eval): Likewise.
 629         * python/python-internal.h (gdbpy_allow_threads): New class.
 630
 631 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 632
 633         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 634         (aarch64_fbsd_fpregmap): Move earlier.
 635         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 636         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 637         instead of individual calls to trad_frame_set_reg_addr.
 638         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 639         earlier.
 640         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 641         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 642         instead of individual calls to trad_frame_set_reg_addr.
 643
 644 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 645
 646         * CONTRIBUTE: Replace contribution list with wiki link.
 647
 648 2019-01-25  Tom Tromey  <tom@tromey.com>
 649
 650         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 651
 652 2019-01-25  Tom Tromey  <tom@tromey.com>
 653
 654         * xtensa-linux-nat.c: Fix common/ includes.
 655         * xml-support.h: Fix common/ includes.
 656         * xml-support.c: Fix common/ includes.
 657         * x86-linux-nat.c: Fix common/ includes.
 658         * windows-nat.c: Fix common/ includes.
 659         * varobj.h: Fix common/ includes.
 660         * varobj.c: Fix common/ includes.
 661         * value.c: Fix common/ includes.
 662         * valops.c: Fix common/ includes.
 663         * utils.c: Fix common/ includes.
 664         * unittests/xml-utils-selftests.c: Fix common/ includes.
 665         * unittests/utils-selftests.c: Fix common/ includes.
 666         * unittests/unpack-selftests.c: Fix common/ includes.
 667         * unittests/tracepoint-selftests.c: Fix common/ includes.
 668         * unittests/style-selftests.c: Fix common/ includes.
 669         * unittests/string_view-selftests.c: Fix common/ includes.
 670         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 671         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 672         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 673         * unittests/rsp-low-selftests.c: Fix common/ includes.
 674         * unittests/parse-connection-spec-selftests.c: Fix common/
 675         includes.
 676         * unittests/optional-selftests.c: Fix common/ includes.
 677         * unittests/offset-type-selftests.c: Fix common/ includes.
 678         * unittests/observable-selftests.c: Fix common/ includes.
 679         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 680         * unittests/memrange-selftests.c: Fix common/ includes.
 681         * unittests/memory-map-selftests.c: Fix common/ includes.
 682         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 683         * unittests/function-view-selftests.c: Fix common/ includes.
 684         * unittests/environ-selftests.c: Fix common/ includes.
 685         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 686         * unittests/common-utils-selftests.c: Fix common/ includes.
 687         * unittests/cli-utils-selftests.c: Fix common/ includes.
 688         * unittests/array-view-selftests.c: Fix common/ includes.
 689         * ui-file.c: Fix common/ includes.
 690         * tui/tui-io.c: Fix common/ includes.
 691         * tracepoint.h: Fix common/ includes.
 692         * tracepoint.c: Fix common/ includes.
 693         * tracefile-tfile.c: Fix common/ includes.
 694         * top.h: Fix common/ includes.
 695         * top.c: Fix common/ includes.
 696         * thread.c: Fix common/ includes.
 697         * target/waitstatus.h: Fix common/ includes.
 698         * target/waitstatus.c: Fix common/ includes.
 699         * target.h: Fix common/ includes.
 700         * target.c: Fix common/ includes.
 701         * target-memory.c: Fix common/ includes.
 702         * target-descriptions.c: Fix common/ includes.
 703         * symtab.h: Fix common/ includes.
 704         * symfile.c: Fix common/ includes.
 705         * stap-probe.c: Fix common/ includes.
 706         * spu-linux-nat.c: Fix common/ includes.
 707         * sparc-nat.c: Fix common/ includes.
 708         * source.c: Fix common/ includes.
 709         * solib.c: Fix common/ includes.
 710         * solib-target.c: Fix common/ includes.
 711         * ser-unix.c: Fix common/ includes.
 712         * ser-tcp.c: Fix common/ includes.
 713         * ser-pipe.c: Fix common/ includes.
 714         * ser-base.c: Fix common/ includes.
 715         * selftest-arch.c: Fix common/ includes.
 716         * s12z-tdep.c: Fix common/ includes.
 717         * rust-exp.y: Fix common/ includes.
 718         * rs6000-aix-tdep.c: Fix common/ includes.
 719         * riscv-tdep.c: Fix common/ includes.
 720         * remote.c: Fix common/ includes.
 721         * remote-notif.h: Fix common/ includes.
 722         * remote-fileio.h: Fix common/ includes.
 723         * remote-fileio.c: Fix common/ includes.
 724         * regcache.h: Fix common/ includes.
 725         * regcache.c: Fix common/ includes.
 726         * record-btrace.c: Fix common/ includes.
 727         * python/python.c: Fix common/ includes.
 728         * python/py-type.c: Fix common/ includes.
 729         * python/py-inferior.c: Fix common/ includes.
 730         * progspace.h: Fix common/ includes.
 731         * producer.c: Fix common/ includes.
 732         * procfs.c: Fix common/ includes.
 733         * proc-api.c: Fix common/ includes.
 734         * printcmd.c: Fix common/ includes.
 735         * ppc-linux-nat.c: Fix common/ includes.
 736         * parser-defs.h: Fix common/ includes.
 737         * osdata.c: Fix common/ includes.
 738         * obsd-nat.c: Fix common/ includes.
 739         * nat/x86-linux.c: Fix common/ includes.
 740         * nat/x86-linux-dregs.c: Fix common/ includes.
 741         * nat/x86-dregs.h: Fix common/ includes.
 742         * nat/x86-dregs.c: Fix common/ includes.
 743         * nat/ppc-linux.c: Fix common/ includes.
 744         * nat/mips-linux-watch.h: Fix common/ includes.
 745         * nat/mips-linux-watch.c: Fix common/ includes.
 746         * nat/linux-waitpid.c: Fix common/ includes.
 747         * nat/linux-ptrace.h: Fix common/ includes.
 748         * nat/linux-ptrace.c: Fix common/ includes.
 749         * nat/linux-procfs.c: Fix common/ includes.
 750         * nat/linux-personality.c: Fix common/ includes.
 751         * nat/linux-osdata.c: Fix common/ includes.
 752         * nat/linux-namespaces.c: Fix common/ includes.
 753         * nat/linux-btrace.h: Fix common/ includes.
 754         * nat/linux-btrace.c: Fix common/ includes.
 755         * nat/fork-inferior.c: Fix common/ includes.
 756         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 757         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 758         * nat/aarch64-linux.c: Fix common/ includes.
 759         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 760         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 761         * namespace.h: Fix common/ includes.
 762         * mips-linux-tdep.c: Fix common/ includes.
 763         * minsyms.c: Fix common/ includes.
 764         * mi/mi-parse.h: Fix common/ includes.
 765         * mi/mi-main.c: Fix common/ includes.
 766         * mi/mi-cmd-env.c: Fix common/ includes.
 767         * memrange.h: Fix common/ includes.
 768         * memattr.c: Fix common/ includes.
 769         * maint.h: Fix common/ includes.
 770         * maint.c: Fix common/ includes.
 771         * main.c: Fix common/ includes.
 772         * machoread.c: Fix common/ includes.
 773         * location.c: Fix common/ includes.
 774         * linux-thread-db.c: Fix common/ includes.
 775         * linux-nat.c: Fix common/ includes.
 776         * linux-fork.c: Fix common/ includes.
 777         * inline-frame.c: Fix common/ includes.
 778         * infrun.c: Fix common/ includes.
 779         * inflow.c: Fix common/ includes.
 780         * inferior.h: Fix common/ includes.
 781         * inferior.c: Fix common/ includes.
 782         * infcmd.c: Fix common/ includes.
 783         * inf-ptrace.c: Fix common/ includes.
 784         * inf-child.c: Fix common/ includes.
 785         * ia64-linux-nat.c: Fix common/ includes.
 786         * i387-tdep.c: Fix common/ includes.
 787         * i386-tdep.c: Fix common/ includes.
 788         * i386-linux-tdep.c: Fix common/ includes.
 789         * i386-linux-nat.c: Fix common/ includes.
 790         * i386-go32-tdep.c: Fix common/ includes.
 791         * i386-fbsd-tdep.c: Fix common/ includes.
 792         * i386-fbsd-nat.c: Fix common/ includes.
 793         * guile/scm-type.c: Fix common/ includes.
 794         * guile/guile.c: Fix common/ includes.
 795         * go32-nat.c: Fix common/ includes.
 796         * gnu-nat.c: Fix common/ includes.
 797         * gdbthread.h: Fix common/ includes.
 798         * gdbarch-selftests.c: Fix common/ includes.
 799         * gdb_usleep.c: Fix common/ includes.
 800         * gdb_select.h: Fix common/ includes.
 801         * gdb_bfd.c: Fix common/ includes.
 802         * gcore.c: Fix common/ includes.
 803         * fork-child.c: Fix common/ includes.
 804         * findvar.c: Fix common/ includes.
 805         * fbsd-nat.c: Fix common/ includes.
 806         * event-top.c: Fix common/ includes.
 807         * event-loop.c: Fix common/ includes.
 808         * dwarf2read.c: Fix common/ includes.
 809         * dwarf2loc.c: Fix common/ includes.
 810         * dwarf2-frame.c: Fix common/ includes.
 811         * dwarf-index-cache.c: Fix common/ includes.
 812         * dtrace-probe.c: Fix common/ includes.
 813         * disasm-selftests.c: Fix common/ includes.
 814         * defs.h: Fix common/ includes.
 815         * csky-tdep.c: Fix common/ includes.
 816         * cp-valprint.c: Fix common/ includes.
 817         * cp-support.h: Fix common/ includes.
 818         * cp-support.c: Fix common/ includes.
 819         * corelow.c: Fix common/ includes.
 820         * completer.h: Fix common/ includes.
 821         * completer.c: Fix common/ includes.
 822         * compile/compile.c: Fix common/ includes.
 823         * compile/compile-loc2c.c: Fix common/ includes.
 824         * compile/compile-cplus-types.c: Fix common/ includes.
 825         * compile/compile-cplus-symbols.c: Fix common/ includes.
 826         * command.h: Fix common/ includes.
 827         * cli/cli-dump.c: Fix common/ includes.
 828         * cli/cli-cmds.c: Fix common/ includes.
 829         * charset.c: Fix common/ includes.
 830         * build-id.c: Fix common/ includes.
 831         * btrace.h: Fix common/ includes.
 832         * btrace.c: Fix common/ includes.
 833         * breakpoint.h: Fix common/ includes.
 834         * breakpoint.c: Fix common/ includes.
 835         * ax.h:
 836         (enum agent_op): Fix common/ includes.
 837         * ax-general.c (struct aop_map): Fix common/ includes.
 838         * ax-gdb.c: Fix common/ includes.
 839         * auxv.c: Fix common/ includes.
 840         * auto-load.c: Fix common/ includes.
 841         * arm-tdep.c: Fix common/ includes.
 842         * arch/riscv.c: Fix common/ includes.
 843         * arch/ppc-linux-common.c: Fix common/ includes.
 844         * arch/i386.c: Fix common/ includes.
 845         * arch/arm.c: Fix common/ includes.
 846         * arch/arm-linux.c: Fix common/ includes.
 847         * arch/arm-get-next-pcs.c: Fix common/ includes.
 848         * arch/amd64.c: Fix common/ includes.
 849         * arch/aarch64.c: Fix common/ includes.
 850         * arch/aarch64-insn.c: Fix common/ includes.
 851         * arch-utils.c: Fix common/ includes.
 852         * amd64-windows-tdep.c: Fix common/ includes.
 853         * amd64-tdep.c: Fix common/ includes.
 854         * amd64-sol2-tdep.c: Fix common/ includes.
 855         * amd64-obsd-tdep.c: Fix common/ includes.
 856         * amd64-nbsd-tdep.c: Fix common/ includes.
 857         * amd64-linux-tdep.c: Fix common/ includes.
 858         * amd64-linux-nat.c: Fix common/ includes.
 859         * amd64-fbsd-tdep.c: Fix common/ includes.
 860         * amd64-fbsd-nat.c: Fix common/ includes.
 861         * amd64-dicos-tdep.c: Fix common/ includes.
 862         * amd64-darwin-tdep.c: Fix common/ includes.
 863         * agent.c: Fix common/ includes.
 864         * ada-lang.h: Fix common/ includes.
 865         * ada-lang.c: Fix common/ includes.
 866         * aarch64-tdep.c: Fix common/ includes.
 867
 868 2019-01-25  Tom Tromey  <tom@tromey.com>
 869
 870         * common/create-version.sh: Use common/version.h.
 871
 872 2019-01-24  Pedro Alves  <palves@redhat.com>
 873
 874         * infrun.c (signal_stop, signal_print, signal_program)
 875         (signal_catch, signal_pass): Now arrays instead of pointers.
 876         (update_signals_program_target, do_target_resume)
 877         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 878         * linux-nat.c (linux_nat_target::pass_signals)
 879         (linux_nat_target::create_inferior, linux_nat_target::attach):
 880         Adjust.
 881         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 882         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 883         * procfs.c (procfs_target::pass_signals): Adjust.
 884         * record-full.c (record_full_target::resume): Adjust.
 885         * remote.c (remote_target::pass_signals)
 886         (remote_target::program_signals): Adjust.
 887         * target-debug.h (target_debug_print_signals): Now takes a
 888         gdb::array_view as parameter.  Adjust.
 889         * target.h (target_ops) <pass_signals, program_signals>: Replace
 890         pointer and length parameters with gdb::array_view.
 891         (target_pass_signals, target_program_signals): Likewise.
 892         * target-delegates.c: Regenerate.
 893
 894 2019-01-24  Pedro Alves  <palves@redhat.com>
 895
 896         * common/forward-scope-exit.h
 897         (forward_scope_exit::forward_scope_exit): Pass arguments to
 898         m_bind_function directly, instead of creating a std::bind and
 899         copying that.
 900
 901 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 902
 903         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 904         for static members.
 905         (pass_in_v_vfp_candidate): Likewise.
 906
 907 2019-01-23  Tom Tromey  <tom@tromey.com>
 908             Pedro Alves  <palves@redhat.com>
 909
 910         * regcache.c (class regcache_invalidator): Remove.
 911         (regcache::raw_write): Use make_scope_exit.
 912
 913 2019-01-23  Tom Tromey  <tom@tromey.com>
 914
 915         * ui-out.h (class ui_out_emit_type): Update comment.
 916
 917 2019-01-23  Tom Tromey  <tom@tromey.com>
 918
 919         * infrun.c (fetch_inferior_event): Update comment.
 920
 921 2019-01-23  Tom Tromey  <tom@tromey.com>
 922             Pedro Alves  <palves@redhat.com>
 923
 924         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 925         parameter.
 926         (fetch_inferior_event): Use SCOPE_EXIT.
 927
 928
 929 2019-01-23  Tom Tromey  <tom@tromey.com>
 930             Pedro Alves  <palves@redhat.com>
 931
 932         * infrun.c (disable_thread_events): Delete.
 933         (stop_all_threads): Use SCOPE_EXIT.
 934
 935 2019-01-23  Tom Tromey  <tom@tromey.com>
 936             Pedro Alves  <palves@redhat.com>
 937
 938         * symfile.c: Include forward-scope-exit.h.
 939         (clear_symtab_users_cleanup): Replace forward declaration with
 940         a FORWARD_SCOPE_EXIT.
 941         (syms_from_objfile_1): Use the forward_scope_exit and
 942         gdb::optional instead of cleanup_function.
 943         (reread_symbols): Use the forward_scope_exit instead of
 944         cleanup_function.
 945         (clear_symtab_users_cleanup): Remove function.
 946
 947 2019-01-23  Tom Tromey  <tom@tromey.com>
 948             Pedro Alves  <palves@redhat.com>
 949
 950         * linux-nat.c: Include scope-exit.h.
 951         (cleanup_target_stop): Remove.
 952         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 953         SCOPE_EXIT.
 954
 955 2019-01-23  Tom Tromey  <tom@tromey.com>
 956             Pedro Alves  <palves@redhat.com>
 957
 958         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 959         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 960
 961 2019-01-23  Tom Tromey  <tom@tromey.com>
 962             Andrew Burgess  <andrew.burgess@embecosm.com>
 963             Pedro Alves  <palves@redhat.com>
 964
 965         * infrun.c (fetch_inferior_event): Use scope_exit.
 966         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 967         * top.c (execute_command): Use scope_exit.
 968         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 969         * utils.c (do_bpstat_clear_actions_cleanup)
 970         (make_bpstat_clear_actions_cleanup): Remove.
 971
 972 2019-01-23  Tom Tromey  <tom@tromey.com>
 973             Pedro Alves  <palves@redhat.com>
 974
 975         * infrun.c: Include "common/scope-exit.h"
 976         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 977         (wait_for_inferior): Use SCOPE_EXIT.
 978         (fetch_inferior_event): Use scope_exit.
 979
 980 2019-01-23  Tom Tromey  <tom@tromey.com>
 981             Pedro Alves  <palves@redhat.com>
 982
 983         * breakpoint.c (create_breakpoint): Remove cleanup.
 984
 985 2019-01-23  Tom Tromey  <tom@tromey.com>
 986             Andrew Burgess  <andrew.burgess@embecosm.com>
 987             Pedro Alves  <palves@redhat.com>
 988
 989 2019-01-23  Pedro Alves  <palves@redhat.com>
 990
 991         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 992
 993 2019-01-23  Pedro Alves  <palves@redhat.com>
 994             Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * gdbthread.h: Include "common/forward-scope-exit.h".
 997         (scoped_finish_thread_state): Redefine custom class in terms of
 998         forward_scope_exit.
 999
1000 2019-01-23  Pedro Alves  <palves@redhat.com>
1001             Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * common/forward-scope-exit.h: New file.
1004
1005 2019-01-23  Pedro Alves  <palves@redhat.com>
1006             Andrew Burgess  <andrew.burgess@embecosm.com>
1007             Tom Tromey  <tom@tromey.com>
1008
1009         * common/scope-exit.h: New file.
1010
1011 2019-01-23  Pedro Alves  <palves@redhat.com>
1012
1013         * common/preprocessor.h (ESC): Rename to ...
1014         (ESC_PARENS): ... this.
1015         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1016         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1017
1018 2019-01-23  Tom Tromey  <tom@tromey.com>
1019
1020         * language.h (class scoped_switch_to_sym_language_if_auto):
1021         Initialize m_lang in both cases.
1022
1023 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1026         with XCNEW.
1027
1028 2019-01-22  Tom Tromey  <tom@tromey.com>
1029
1030         * corelow.c: Do not include sys/file.h.
1031
1032 2019-01-22  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-wingeneral.h: Include gdb_curses.h.
1035
1036 2019-01-22  Tom Tromey  <tom@tromey.com>
1037
1038         * source-cache.h (class source_cache) <get_source_lines,
1039         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1040
1041 2019-01-22  Tom Tromey  <tom@tromey.com>
1042
1043         * remote-fileio.h (struct remote_target): Declare.
1044
1045 2019-01-22  Tom Tromey  <tom@tromey.com>
1046
1047         * python/py-arch.c: Do not include py-ref.h.
1048         * python/py-bpevent.c: Do not include py-ref.h.
1049         * python/py-cmd.c: Do not include py-ref.h.
1050         * python/py-continueevent.c: Do not include py-ref.h.
1051         * python/py-event.h: Do not include py-ref.h.
1052         * python/py-evtregistry.c: Do not include py-ref.h.
1053         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1054         * python/py-frame.c: Do not include py-ref.h.
1055         * python/py-framefilter.c: Do not include py-ref.h.
1056         * python/py-function.c: Do not include py-ref.h.
1057         * python/py-infevents.c: Do not include py-ref.h.
1058         * python/py-linetable.c: Do not include py-ref.h.
1059         * python/py-objfile.c: Do not include py-ref.h.
1060         * python/py-param.c: Do not include py-ref.h.
1061         * python/py-prettyprint.c: Do not include py-ref.h.
1062         * python/py-progspace.c: Do not include py-ref.h.
1063         * python/py-symbol.c: Do not include py-ref.h.
1064         * python/py-symtab.c: Do not include py-ref.h.
1065         * python/py-type.c: Do not include py-ref.h.
1066         * python/py-unwind.c: Do not include py-ref.h.
1067         * python/py-utils.c: Do not include py-ref.h.
1068         * python/py-value.c: Do not include py-ref.h.
1069         * python/py-varobj.c: Do not include py-ref.h.
1070         * python/py-xmethods.c: Do not include py-ref.h.
1071         * python/python.c: Do not include py-ref.h.
1072         * varobj.c: Do not include py-ref.h.
1073
1074 2019-01-22  Tom Tromey  <tom@tromey.com>
1075
1076         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1077         keyword for bcache.
1078
1079 2019-01-22  Tom Tromey  <tom@tromey.com>
1080
1081         * compile/compile-cplus-types.c: Remove a comment by #include.
1082
1083 2019-01-22  Tom Tromey  <tom@tromey.com>
1084
1085         * compile/gcc-c-plugin.h: Include compile-internal.h.
1086
1087 2019-01-22  Tom Tromey  <tom@tromey.com>
1088
1089         * stabsread.c (EXTERN): Do not define.
1090         (symnum, next_symbol_text_func, processing_gcc_compilation)
1091         (within_function, global_sym_chain, global_stabs)
1092         (previous_stab_code, this_object_header_files)
1093         (n_this_object_header_files)
1094         (n_allocated_this_object_header_files): Define.
1095         * stabsread.h (EXTERN): Never define.  Use "extern".
1096
1097 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1098
1099         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1100         history_value.
1101
1102 2019-01-21  Tom Tromey  <tom@tromey.com>
1103
1104         * ui-out.c: Fix includes.
1105         * tui/tui-source.c: Fix includes.
1106         * target.c: Fix includes.
1107         * remote.c: Fix includes.
1108         * regcache.c: Fix includes.
1109         * python/py-block.c: Fix includes.
1110         * printcmd.c: Fix includes.
1111         * or1k-tdep.c: Fix includes.
1112         * mi/mi-main.c: Fix includes.
1113         * m32r-tdep.c: Fix includes.
1114         * csky-tdep.c: Fix includes.
1115         * compile/compile-cplus-types.c: Fix includes.
1116         * cli/cli-interp.c: Fix includes.
1117
1118 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1119
1120         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1121         for padding.
1122
1123 2019-01-16  Tom Tromey  <tom@tromey.com>
1124
1125         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1126         earlier.
1127         (struct objfile) <msymbols_range>: Move from top level.
1128         <msymbols>: New method.
1129         (class objfile_msymbols): Remove.
1130         * symtab.c (default_collect_symbol_completion_matches_break_on):
1131         Update.
1132         * symmisc.c (dump_msymbols): Update.
1133         * stabsread.c (scan_file_globals): Update.
1134         * objc-lang.c (info_selectors_command, info_classes_command)
1135         (find_methods): Update.
1136         * minsyms.c (find_solib_trampoline_target): Update.
1137         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1138         * coffread.c (coff_symfile_read): Update.
1139         * ada-lang.c (ada_lookup_simple_minsym)
1140         (ada_collect_symbol_completion_matches): Update.
1141
1142 2019-01-16  Tom Tromey  <tom@tromey.com>
1143
1144         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1145         type.  Remove no-argument constructor.
1146         <iterator::operator++>: Simplify.
1147         <begin>: Update.
1148         <end>: Use minimal_symbol_count.
1149
1150 2019-01-16  Tom Tromey  <tom@tromey.com>
1151
1152         * objfiles.h (struct objfile) <psymtabs>: New method.
1153         (class objfile_psymtabs): Remove.
1154         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1155         typedef.
1156         <range>: New method.
1157         (require_partial_symbols): Change return type.
1158         * psymtab.c (require_partial_symbols)
1159         (psym_expand_symtabs_matching): Update.
1160         * mdebugread.c (parse_partial_symbols): Update.
1161         * dbxread.c (dbx_end_psymtab): Update.
1162
1163 2019-01-15  Tom Tromey  <tom@tromey.com>
1164
1165         * symtab.c (lookup_objfile_from_block)
1166         (lookup_symbol_in_objfile_symtabs)
1167         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1168         (find_line_symtab, info_sources_command)
1169         (default_collect_symbol_completion_matches_break_on)
1170         (make_source_files_completion_list): Update.
1171         * symmisc.c (print_objfile_statistics, dump_objfile)
1172         (maintenance_print_symbols, maintenance_info_symtabs)
1173         (maintenance_check_symtabs, maintenance_info_line_tables):
1174         Update.
1175         * source.c (select_source_symtab)
1176         (forget_cached_source_info_for_objfile): Update.
1177         * objfiles.h (class objfile_compunits): Remove.
1178         (struct objfile) <compunits_range>: New typedef.
1179         (compunits): New method.
1180         * objfiles.c (objfile_relocate1): Update.
1181         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1182         * maint.c (count_symtabs_and_blocks): Update.
1183         * linespec.c (iterate_over_all_matching_symtabs): Update.
1184         * cp-support.c (add_symbol_overload_list_qualified): Update.
1185         * coffread.c (coff_symtab_read): Update.
1186         * ada-lang.c (add_nonlocal_symbols)
1187         (ada_collect_symbol_completion_matches)
1188         (ada_add_global_exceptions): Update.
1189
1190 2019-01-15  Tom Tromey  <tom@tromey.com>
1191
1192         * progspace.h (program_space) <objfiles_safe_range>: New
1193         typedef.
1194         <objfiles_safe>: New method.
1195         * objfiles.h (class all_objfiles_safe): Remove.
1196         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1197         * jit.c (jit_inferior_exit_hook): Update.
1198
1199 2019-01-17  Tom Tromey  <tom@tromey.com>
1200
1201         * progspace.h (program_space) <objfiles_range>: New typedef.
1202         <objfiles>: New method.
1203         <objfiles_head>: Rename from objfiles.
1204         (object_files): Update.
1205         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1206         * guile/scm-pretty-print.c
1207         (ppscm_find_pretty_printer_from_objfiles): Update.
1208         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1209         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1210         Update.
1211         * python/py-progspace.c (pspy_get_objfiles): Update.
1212         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1213         Update.
1214         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1215         (objfpy_lookup_objfile_by_build_id): Update.
1216         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1217         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1218         Update.
1219         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1220         (expand_symtab_containing_pc, lookup_objfile_from_block)
1221         (lookup_static_symbol, basic_lookup_transparent_type)
1222         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1223         (find_line_symtab, info_sources_command)
1224         (default_collect_symbol_completion_matches_break_on)
1225         (make_source_files_completion_list, find_main_name): Update.
1226         * symmisc.c (print_symbol_bcache_statistics)
1227         (print_objfile_statistics, maintenance_print_symbols)
1228         (maintenance_print_msymbols, maintenance_print_objfiles)
1229         (maintenance_info_symtabs, maintenance_check_symtabs)
1230         (maintenance_expand_symtabs, maintenance_info_line_tables):
1231         Update.
1232         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1233         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1234         (map_overlay_command, unmap_overlay_command)
1235         (simple_overlay_update, expand_symtabs_matching)
1236         (map_symbol_filenames): Update.
1237         * symfile-debug.c (set_debug_symfile): Update.
1238         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1239         Update.
1240         * source.c (select_source_symtab, forget_cached_source_info):
1241         Update.
1242         * solib.c (solib_read_symbols): Update.
1243         * solib-spu.c (append_ocl_sos): Update.
1244         * psymtab.c (maintenance_print_psymbols)
1245         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1246         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1247         * printcmd.c (info_symbol_command): Update.
1248         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1249         Update.
1250         * objfiles.h (class all_objfiles): Remove.
1251         * objfiles.c (have_partial_symbols, have_full_symbols)
1252         (have_minimal_symbols, qsort_cmp, update_section_map)
1253         (shared_objfile_contains_address_p)
1254         (default_iterate_over_objfiles_in_search_order): Update.
1255         * objc-lang.c (info_selectors_command, info_classes_command)
1256         (find_methods): Update.
1257         * minsyms.c (find_solib_trampoline_target): Update.
1258         * maint.c (maintenance_info_sections)
1259         (maintenance_translate_address, count_symtabs_and_blocks):
1260         Update.
1261         * main.c (captured_main_1): Update.
1262         * linux-thread-db.c (try_thread_db_load_from_pdir)
1263         (has_libpthread): Update.
1264         * linespec.c (iterate_over_all_matching_symtabs)
1265         (search_minsyms_for_name): Update.
1266         * jit.c (jit_find_objf_with_entry_addr): Update.
1267         * hppa-tdep.c (find_unwind_entry)
1268         (hppa_lookup_stub_minimal_symbol): Update.
1269         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1270         Update.
1271         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1272         (elf_gnu_ifunc_resolve_by_got): Update.
1273         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1274         * dwarf-index-write.c (save_gdb_index_command): Update.
1275         * cp-support.c (add_symbol_overload_list_qualified): Update.
1276         * breakpoint.c (create_overlay_event_breakpoint)
1277         (create_longjmp_master_breakpoint)
1278         (create_std_terminate_master_breakpoint)
1279         (create_exception_master_breakpoint): Update.
1280         * blockframe.c (find_pc_partial_function): Update.
1281         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1282         (ada_collect_symbol_completion_matches)
1283         (ada_add_global_exceptions): Update.
1284
1285 2019-01-17  Tom Tromey  <tom@tromey.com>
1286
1287         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1288         declare VEC.
1289         (solib_target_parse_libraries): Change return type.
1290         (library_list_start_segment, library_list_start_section)
1291         (library_list_end_library, library_list_start_library); Update.
1292         (solib_target_free_library_list): Remove.
1293         (solib_target_parse_libraries): Remove cleanup.  Change return
1294         type.
1295         (solib_target_current_sos): Update.
1296
1297 2019-01-17  Tom Tromey  <tromey@bapiya>
1298
1299         * valprint.c: Replace "the the" with "the".
1300         * symtab.c: Replace "the the" with "the".
1301         * solib.c: Replace "the the" with "the".
1302         * solib-dsbt.c: Replace "the the" with "the".
1303         * linespec.c: Replace "the the" with "the".
1304         * dwarf2loc.h: Replace "the the" with "the".
1305         * amd64-windows-tdep.c: Replace "the the" with "the".
1306         * aarch64-tdep.c: Replace "the the" with "the".
1307
1308 2019-01-16  Keith Seitz  <keiths@redhat.com>
1309
1310         PR gdb/23773
1311         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1312         <builder>: Rename to ..
1313         <m_builder>: ... this and make private.
1314         (dwarf2_cu::get_builder): New method.  Change all users of
1315         `builder' to use this method.
1316         (dwarf2_start_symtab): Move to ...
1317         (dwarf2_cu::start_symtab): ... here.  Update all callers
1318         (setup_type_unit_groups): Move to ...
1319         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1320         callers.
1321         (dwarf2_cu::reset_builder): New method.
1322         (process_full_compunit, process_full_type_unit): Use
1323         dwarf2_cu::reset_builder.
1324         (follow_die_offset): Record the ancestor CU if it is different
1325         from the followed DIE's CU.
1326         (follow_die_sig_1): Likewise.
1327
1328 2019-01-15  Tom Tromey  <tom@tromey.com>
1329
1330         * remote.c (class remote_state) <buf>: Now a char_vector.
1331         <buf_size>: Remove.
1332         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1333         parameter.
1334         (remote_target::getpkt_or_notif_sane_1)
1335         (remote_target::getpkt_sane)
1336         (remote_target::getpkt_or_notif_sane): Likewise.
1337         (class remote_target) <putpkt>: New overload.
1338         (remote_target::read_frame): Change type of "buf_p".  Remove
1339         sizeof_p parameter.
1340         (packet_ok): New overload.
1341         (packet_check_result): New overload.
1342         Update all uses.
1343
1344 2019-01-14  Tom Tromey  <tom@tromey.com>
1345
1346         * remote-notif.c (handle_notification, remote_notif_ack)
1347         (remote_notif_parse): Make "buf" const.
1348         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1349         const.
1350         (remote_notif_parse, remote_notif_ack, handle_notification):
1351         Likewise.
1352         * remote.c (remote_notif_stop_parse): Make "buf" const.
1353         (remote_target::remote_parse_stop_reply): Make "buf" const.
1354         (remote_notif_stop_ack): Make "buf" const.
1355
1356 2019-01-14  Tom Tromey  <tom@tromey.com>
1357
1358         * remote.c (remote_console_output): Make parameter const.
1359
1360 2019-01-14  Tom Tromey  <tom@tromey.com>
1361
1362         * target-debug.h (target_debug_print_signals): Constify.
1363         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1364         * procfs.c (procfs_target::pass_signals): Update.
1365         * linux-nat.c (linux_nat_target::pass_signals): Update.
1366         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1367         * target-delegates.c: Rebuild.
1368         * remote.c (remote_target::program_signals): Update.
1369         (remote_target::pass_signals): Update.
1370         * target.c (target_pass_signals): Constify argument.
1371         (target_program_signals): Likewise.
1372         * target.h (struct target_ops) <pass_signals, program_signals>:
1373         Constify argument.
1374         (target_pass_signals, target_program_signals): Constify argument.
1375
1376 2019-01-14  Tom Tromey  <tom@tromey.com>
1377
1378         PR tui/28819:
1379         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1380
1381 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1382
1383         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1384         field.
1385         * rs6000-tdep.c: Include reggroups.h.
1386         (IS_V_ALIAS_PSEUDOREG): Define.
1387         (rs6000_register_name): Return names for the "vX" aliases.
1388         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1389         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1390         aliases.  Call default_register_reggroup_p for all other
1391         pseudo-registers.
1392         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1393         New functions.
1394         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1395         Handle "vX" aliases.
1396         (v_alias_pseudo_register_collect): New function.
1397         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1398         (rs6000_gdbarch_init): Initialize "vX" aliases as
1399         pseudo-registers.  Restore registration of
1400         rs6000_pseudo_register_reggroup_p with
1401         set_tdesc_pseudo_register_reggroup_p.
1402
1403 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1404
1405         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1406         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1407         set_gdbarch_num_pseudo_regs.
1408
1409 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1410
1411         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1412         Remove arg prefixname, add do_set and do_show.
1413         Add member functions set_list and show_list.
1414         * cli/cli-style.c (class cli_style_option): Update accordingly.
1415         (style_set_list): Move to file scope.
1416         (style_show_list): Likewise.
1417         (set_style): Call help_list.
1418         (show_style): Call cmd_show_list.
1419         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1420         Update to use the new macro.
1421
1422 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1423
1424         * ada-lang.c (_initialize_ada_language): Expand the help text
1425         for the "catch exception" command.
1426
1427 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1428
1429         * symtab.c (matching_obj_sections): Initialize obj,
1430         declare it closer to its usage.
1431
1432 2019-01-10  Tom Tromey  <tom@tromey.com>
1433
1434         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1435         (basic_inf_threads_range): Remove.
1436         (inf_threads_range, inf_non_exited_threads_range)
1437         (safe_inf_threads_range): Use next_adapter.
1438
1439 2019-01-10  Keith Seitz  <keiths@redhat.com>
1440
1441         PR gdb/23712
1442         PR symtab/23010
1443         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1444         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1445
1446 2019-01-10  Keith Seitz  <keiths@redhat.com>
1447
1448         PR gdb/23712
1449         PR symtab/23010
1450         * dictionary.c (pending_to_vector): Remove.
1451         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1452         Remove _1 suffix, replacing functions of the same name.  Update
1453         all callers.
1454         (dict_create_hashed, dict_create_hashed_expandable)
1455         (dict_create_linear, dict_create_linear_expandable, dict_free)
1456         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1457         Make functions static.
1458
1459 2019-01-10  Keith Seitz  <keiths@redhat.com>
1460
1461         PR gdb/23712
1462         PR symtab/23010
1463         * dictionary.h (struct dictionary): Replace declaration with
1464         multidictionary.
1465         (dict_create_hashed, dict_create_hashed_expandable)
1466         (dict_create_linear, dict_create_linear_expandable)
1467         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1468         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1469         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1470         taking multidictionary argument.
1471         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1472         * block.h (struct block) <dict>: Change to multidictionary
1473         and rename `multidict'.
1474         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1475         symmisc.c: Update all dictionary references to multidictionary.
1476
1477 2019-01-10  Keith Seitz  <keiths@redhat.com>
1478
1479         PR gdb/23712
1480         PR symtab/23010
1481         * dictionary.c: Include unordered_map.
1482         (pending_to_vector): New function.
1483         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1484         Rewrite the non-"_1" functions to take vector instead
1485         of linked list.
1486         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1487         "new" _1 versions of the same name.
1488         (multidictionary): Define.
1489         (std::hash<enum language): New definition.
1490         (collate_pending_symbols_by_language, mdict_create_hashed)
1491         (mdict_create_hashed_expandable, mdict_create_linear)
1492         (mdict_create_linear_expandable, mdict_free)
1493         (find_language_dictionary, create_new_language_dictionary)
1494         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1495         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1496         (mdict_size, mdict_empty): New functions.
1497         * dictionary.h (mdict_iterator): Define.
1498
1499 2019-01-10  Pedro Alves  <palves@redhat.com>
1500
1501         * breakpoint.c (read_uploaded_action)
1502         (create_tracepoint_from_upload): Adjust to use
1503         gdb::unique_xmalloc_ptr.
1504         * ctf.c (ctf_write_uploaded_tp):
1505         (SET_ARRAY_FIELD): Use emplace_back.
1506         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1507         * tracefile-tfile.c (tfile_write_uploaded_tp):
1508         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1509         gdb::unique_xmalloc_ptr.
1510         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1511         at_string, cond_string, cmd_strings>: Replace char pointers
1512         with gdb::unique_xmalloc_ptr.
1513
1514 2019-01-10  Pedro Alves  <palves@redhat.com>
1515
1516         * solib-target.c (library_list_start_library): Don't xstrdup name.
1517
1518 2019-01-10  Pedro Alves  <palves@redhat.com>
1519
1520         * mdebugread.c (parse_partial_symbols): Use
1521         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1522
1523 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * linux-fork.c (scoped_switch_fork_info)
1526         <~scoped_switch_fork_info>: Fix incorrect variable name.
1527
1528 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * linux-fork.c (scoped_switch_fork_info)
1531         <scoped_switch_fork_info>: Make explicit.
1532         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1533
1534 2019-01-10  Tom Tromey  <tom@tromey.com>
1535
1536         * objfiles.h (objfile::reset_psymtabs): Update.
1537         * objfiles.c (objfile::objfile): Update.
1538         * psymtab.h (psymtab_storage::obstack): Update.
1539         (psymtab_storage::m_obstack): Use gdb::optional.
1540         (class psymtab_storage): Update comment.  Remove objfile
1541         parameter.
1542         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1543
1544 2019-01-10  Tom Tromey  <tom@tromey.com>
1545
1546         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1547         <free_psymtabs>: Now private.
1548         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1549         (allocate_psymtab): Use new method.
1550
1551 2019-01-10  Tom Tromey  <tom@tromey.com>
1552
1553         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1554         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1555         * mdebugread.c (parse_partial_symbols): Use
1556         allocate_dependencies.
1557         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1558         allocate_dependencies.
1559         (process_psymtab_comp_unit_reader)
1560         (build_type_psymtab_dependencies): Likewise.
1561         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1562
1563 2019-01-10  Tom Tromey  <tom@tromey.com>
1564
1565         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1566         PSYMBOL_SET_LANGUAGE.
1567         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1568
1569 2019-01-10  Tom Tromey  <tom@tromey.com>
1570
1571         * psymtab.h (psymtab_storage::obstack): New method.
1572         <m_obstack>: Rename from obstack; now private.
1573         * psymtab.c (psymtab_storage): Update.
1574         * dwarf2read.c (create_addrmap_from_index)
1575         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1576         Update.
1577
1578 2019-01-10  Tom Tromey  <tom@tromey.com>
1579
1580         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1581         * objfiles.h (objfile::reset_psymtabs): New method.
1582
1583 2019-01-10  Tom Tromey  <tom@tromey.com>
1584
1585         * symmisc.c (print_symbol_bcache_statistics): Update.
1586         (print_objfile_statistics): Update.
1587         * symfile.c (reread_symbols): Update.
1588         * psymtab.h (class psymtab_storage): New.
1589         * psymtab.c (psymtab_storage): New constructor.
1590         (~psymtab_storage): New destructor.
1591         (require_partial_symbols): Update.
1592         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1593         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1594         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1595         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1596         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1597         (start_psymtab_common, end_psymtab_common)
1598         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1599         (allocate_psymtab): Update.
1600         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1601         Update.
1602         (dump_psymtab_addrmap, maintenance_print_psymbols)
1603         (maintenance_check_psymtabs): Update.
1604         (class objfile_psymtabs): Move to objfiles.h.
1605         * psympriv.h (discard_psymtab): Now inline.
1606         (psymtab_discarder::psymtab_discarder): Update.
1607         (psymtab_discarder::~psymtab_discarder): Update.
1608         (ALL_OBJFILE_PSYMTABS): Rewrite.
1609         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1610         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1611         Remove fields.
1612         <partial_symtabs>: New field.
1613         (class objfile_psymtabs): Move from psymtab.h.  Update.
1614         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1615         psymbol_cache.
1616         (objfile::~objfile): Don't destroy psymbol_cache.
1617         * mdebugread.c (parse_partial_symbols): Update.
1618         * dwarf2read.c (create_addrmap_from_index)
1619         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1620         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1621         (add_partial_subprogram, dwarf2_ranges_read): Update.
1622         * dwarf-index-write.c (write_address_map)
1623         (write_one_signatured_type, recursively_write_psymbols)
1624         (class debug_names, class debug_names, write_psymtabs_to_index):
1625         Update.
1626
1627 2019-01-10  Tom Tromey  <tom@tromey.com>
1628
1629         * symtab.h (SYMBOL_SET_NAMES): Update.
1630         (symbol_set_names): Update.
1631         (MSYMBOL_SET_NAMES): Update.
1632         * symtab.c (symbol_set_names): Change argument to be an
1633         objfile_per_bfd_storage.
1634         * psymtab.c (add_psymbol_to_bcache): Update.
1635         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1636
1637 2019-01-10  Tom Tromey  <tom@tromey.com>
1638
1639         * symtab.c (create_demangled_names_hash): Change argument to be an
1640         objfile_per_bfd_storage.
1641         (symbol_set_names): Update.
1642
1643 2019-01-10  Tom Tromey  <tom@tromey.com>
1644
1645         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1646         init_psymbol_list.
1647         * psymtab.c (init_psymbol_list): Do nothing if already called.
1648         * psympriv.h (init_psymbol_list): Add comment.
1649         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1650         init_psymbol_list.
1651         * dbxread.c (dbx_symfile_read): Unconditionally call
1652         init_psymbol_list.
1653
1654 2019-01-10  Tom Tromey  <tom@tromey.com>
1655
1656         * xcoffread.c (scan_xcoff_symtab): Update.
1657         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1658         "where".
1659         * mdebugread.c (parse_partial_symbols)
1660         (handle_psymbol_enumerators): Update.
1661         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1662         * dbxread.c (read_dbx_symtab): Update.
1663         * psympriv.h (psymbol_placement): New enum.
1664         (add_psymbol_to_list): Update.
1665
1666 2019-01-10  Tom Tromey  <tom@tromey.com>
1667
1668         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1669         static_psymbols parameters.
1670         (scan_xcoff_symtab): Update.
1671         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1672         static_psymbols parameters.
1673         * psympriv.h (start_psymtab_common): Update.
1674         * mdebugread.c (parse_partial_symbols): Update.
1675         * dwarf2read.c (create_partial_symtab): Update.
1676         * dbxread.c (read_dbx_symtab): Update.
1677         (start_psymtab): Remove global_psymbols and static_psymbols
1678         parameters.
1679
1680 2019-01-10  Tom Tromey  <tom@tromey.com>
1681
1682         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1683         * psymtab.c (allocate_psymtab): Add comment.
1684         * psympriv.h (allocate_psymtab): Add comment.
1685         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1686         initializations.
1687         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1688
1689 2019-01-10  Tom Tromey  <tom@tromey.com>
1690
1691         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1692         Don't declare.
1693         * mipsread.c: Include mdebugread.h.
1694         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1695         Declare.
1696         * elfread.c: Include mdebugread.h.
1697
1698 2019-01-09  Tom Tromey  <tom@tromey.com>
1699
1700         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1701         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1702         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1703         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1704         (psym_lookup_symbol, psym_find_last_source_symtab)
1705         (psym_forget_cached_source_info, psym_print_stats)
1706         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1707         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1708         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1709         (psym_find_compunit_symtab_by_address)
1710         (maintenance_print_psymbols, maintenance_info_psymtabs)
1711         (maintenance_check_psymtabs): Use ranged for.
1712         * psymtab.h (class objfile_psymtabs): New.
1713         (require_partial_symbols): Return objfile_psymtabs.
1714         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1715
1716 2019-01-09  Tom Tromey  <tom@tromey.com>
1717
1718         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1719         (find_pc_mapped_section, list_overlays_command)
1720         (map_overlay_command, unmap_overlay_command)
1721         (simple_overlay_update): Use all_objfiles.
1722         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1723         * printcmd.c (info_symbol_command): Use all_objfiles.
1724         * objfiles.h (ALL_OBJSECTIONS): Remove.
1725         * maint.c (maintenance_translate_address): Use all_objfiles.
1726         * gcore.c (gcore_create_callback): Use all_objfiles.
1727         (objfile_find_memory_regions): Likewise.
1728
1729 2019-01-09  Tom Tromey  <tom@tromey.com>
1730
1731         * symtab.c (find_line_symtab, info_sources_command)
1732         (make_source_files_completion_list): Use objfile_compunits.
1733         * source.c (select_source_symtab): Use objfile_compunits.
1734         * objfiles.h (struct objfile): Update comment.
1735         (ALL_OBJFILES): Remove.
1736         (ALL_FILETABS): Remove.
1737         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1738         objfile_compunits.
1739
1740 2019-01-09  Tom Tromey  <tom@tromey.com>
1741
1742         * symmisc.c (print_objfile_statistics, dump_objfile)
1743         (maintenance_print_symbols): Use compunit_filetabs.
1744         * source.c (forget_cached_source_info_for_objfile): Use
1745         compunit_filetabs.
1746         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1747         (ALL_FILETABS): Use compunit_filetabs.
1748         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1749         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1750
1751 2019-01-09  Tom Tromey  <tom@tromey.com>
1752
1753         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1754         (compunit_filetabs): New.
1755         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1756         compunit_filetabs.
1757         (info_sources_command, make_source_files_completion_list): Remove
1758         declaration.
1759         * symmisc.c (print_objfile_statistics, dump_objfile)
1760         (maintenance_print_symbols): Remove declaration.
1761         (maintenance_info_symtabs): Use compunit_filetabs.
1762         (maintenance_info_line_tables): Likewise.
1763         * source.c (select_source_symtab): Change local variable name.
1764         (forget_cached_source_info_for_objfile): Remove declaration.
1765         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1766         * objfiles.c (objfile_relocate1): Remove declaration.
1767         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1768         declaration.
1769         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1770         * coffread.c (coff_symtab_read): Remove declaration.
1771         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1772         compunit_filetabs.
1773
1774 2019-01-09  Tom Tromey  <tom@tromey.com>
1775
1776         * symtab.c (lookup_objfile_from_block)
1777         (find_pc_sect_compunit_symtab, search_symbols)
1778         (default_collect_symbol_completion_matches_break_on): Use
1779         objfile_compunits.
1780         * objfiles.h (ALL_COMPUNITS): Remove.
1781         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1782         * cp-support.c (add_symbol_overload_list_qualified): Use
1783         objfile_compunits.
1784         * ada-lang.c (ada_collect_symbol_completion_matches)
1785         (ada_add_global_exceptions): Use objfile_compunits.
1786
1787 2019-01-09  Tom Tromey  <tom@tromey.com>
1788
1789         * source.c (select_source_symtab)
1790         (forget_cached_source_info_for_objfile): Remove declaration.
1791         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1792         declaration.
1793         * maint.c (count_symtabs_and_blocks): Remove declaration.
1794         * cp-support.c (add_symbol_overload_list_qualified): Remove
1795         declaration.
1796         * coffread.c (coff_symtab_read): Remove declaration.
1797         * symtab.c (lookup_symbol_in_objfile_symtabs)
1798         (basic_lookup_transparent_type_1): Use objfile_compunits.
1799         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1800         (info_sources_command, search_symbols)
1801         (default_collect_symbol_completion_matches_break_on)
1802         (make_source_files_completion_list): Remove declaration.
1803         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1804         (ada_collect_symbol_completion_matches)
1805         (ada_add_global_exceptions): Remove declaration.
1806         * linespec.c (iterate_over_all_matching_symtabs): Use
1807         objfile_compunits.
1808         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1809         (class objfile_compunits): New.
1810         (ALL_COMPUNITS): Use objfile_compunits.
1811         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1812         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1813         objfile_compunits.
1814         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1815
1816 2019-01-09  Tom Tromey  <tom@tromey.com>
1817
1818         * symtab.c (search_symbols)
1819         (default_collect_symbol_completion_matches_break_on): Use
1820         objfile_msymbols.
1821         * ada-lang.c (ada_lookup_simple_minsym)
1822         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1823         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1824         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1825         objfile_msymbols.
1826         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1827         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1828         * objc-lang.c (find_methods): Use objfile_msymbols.
1829         (info_selectors_command, info_classes_command): Likewise.
1830         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1831         * objfiles.h (class objfile_msymbols): New.
1832         (ALL_OBJFILE_MSYMBOLS): Remove.
1833         (ALL_MSYMBOLS): Remove.
1834
1835 2019-01-09  Tom Tromey  <tom@tromey.com>
1836
1837         * common/next-iterator.h (next_adapter): Add Iterator template
1838         parameter.
1839         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1840         (class all_objfiles_safe): New.
1841         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1842         * objfiles.c (put_objfile_before): Update comment.
1843         (add_separate_debug_objfile): Likewise.
1844         (free_all_objfiles): Use all_objfiles_safe.
1845         (objfile_purge_solibs): Likewise.
1846
1847 2019-01-09  Tom Tromey  <tom@tromey.com>
1848
1849         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1850         (expand_symtab_containing_pc, lookup_static_symbol)
1851         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1852         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1853         all_objfiles.
1854         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1855         * breakpoint.c (create_overlay_event_breakpoint)
1856         (create_longjmp_master_breakpoint)
1857         (create_std_terminate_master_breakpoint)
1858         (create_exception_master_breakpoint): Use all_objfiles.
1859         * linux-thread-db.c (try_thread_db_load_from_pdir)
1860         (has_libpthread): Use all_objfiles.
1861         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1862         * linespec.c (iterate_over_all_matching_symtabs)
1863         (search_minsyms_for_name): Use all_objfiles.
1864         * maint.c (maintenance_info_sections): Use all_objfiles.
1865         * main.c (captured_main_1): Use all_objfiles.
1866         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1867         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1868         * guile/scm-pretty-print.c
1869         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1870         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1871         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1872         (maintenance_print_msymbols): Use all_objfiles.
1873         * source.c (select_source_symtab): Use all_objfiles.
1874         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1875         * symfile.c (remove_symbol_file_command)
1876         (expand_symtabs_matching, map_symbol_filenames): Use
1877         all_objfiles.
1878         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1879         all_objfiles.
1880         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1881         * objc-lang.c (find_methods): Use all_objfiles.
1882         * objfiles.c (have_partial_symbols, have_full_symbols)
1883         (have_minimal_symbols, qsort_cmp)
1884         (default_iterate_over_objfiles_in_search_order): Use
1885         all_objfiles.
1886         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1887         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1888         (maintenance_check_psymtabs): Use all_objfiles.
1889         (ALL_PSYMTABS): Remove.
1890         * compile/compile-object-run.c (do_module_cleanup): Use
1891         all_objfiles.
1892         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1893         * cp-support.c (add_symbol_overload_list_qualified): Use
1894         all_objfiles.
1895         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1896         Use all_objfiles.
1897         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1898         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1899         all_objfiles.
1900         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1901         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1902         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1903         Uses all_objfiles.
1904         * solib.c (solib_read_symbols): Use all_objfiles
1905
1906 2019-01-09  Tom Tromey  <tom@tromey.com>
1907
1908         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1909         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1910         all_objfiles.
1911         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1912         * symmisc.c (print_symbol_bcache_statistics)
1913         (print_objfile_statistics, maintenance_print_objfiles)
1914         (maintenance_info_symtabs, maintenance_check_symtabs)
1915         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1916         all_objfiles.
1917         * source.c (forget_cached_source_info): Use all_objfiles.
1918         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1919         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1920         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1921         * objfiles.c (update_section_map): Use all_objfiles.
1922         (shared_objfile_contains_address_p): Likewise.
1923         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1924         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1925
1926 2019-01-09  Tom Tromey  <tom@tromey.com>
1927
1928         * common/next-iterator.h: New file.
1929         * objfiles.h (class all_objfiles): New.
1930         (struct objfile_iterator): New.
1931
1932 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1933
1934         * NEWS: Move the description of the changed "frame", "select-frame",
1935          and "info frame" commands to the Changed commands section.
1936
1937 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1938
1939         * gdbtypes.c (check_stub_method_group): Remove handling of old
1940         mangling schemes.
1941         * linespec.c (find_methods): Likewise.
1942         * stabsread.c (read_member_functions): Likewise.
1943         * valops.c (search_struct_method): Likewise.
1944         (value_struct_elt_for_reference): Likewise.
1945         * NEWS: Mention this change.
1946
1947 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1950         print_source_lines.
1951         * source.c (print_source_lines_base): Update line number check.
1952         (print_source_lines): New function.
1953         (source_lines_range::source_lines_range): New function.
1954         * source.h (class source_lines_range): New class.
1955         (print_source_lines): New declaration.
1956
1957 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1958
1959         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1960
1961 2019-01-08  Tom Tromey  <tom@tromey.com>
1962             Simon Marchi  <simon.marchi@ericsson.com>
1963
1964         PR gdb/24060
1965         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1966         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1967         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1968         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1969         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1970         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1971
1972 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1973
1974         * source.c (select_source_symtab): Move header comment to
1975         declaration in source.h.
1976         (forget_cached_source_info_for_objfile): Likewise.
1977         (forget_cached_source_info): Likewise.
1978         (identify_source_line): Likewise.
1979         * source.h (identify_source_line): Move declaration from symtab.h
1980         and add comment from source.c
1981         (print_source_lines): Likewise.
1982         (forget_cached_source_info_for_objfile): Likewise.
1983         (forget_cached_source_info): Likewise.
1984         (select_source_symtab): Likewise.
1985         (enum print_source_lines_flag): Move definition from symtab.h.
1986         * symtab.h (identify_source_line): Move declaration to source.h.
1987         (print_source_lines): Likewise.
1988         (forget_cached_source_info_for_objfile): Likewise.
1989         (forget_cached_source_info): Likewise.
1990         (select_source_symtab): Likewise.
1991         (enum print_source_lines_flag): Move definition to source.h.
1992         * tui/tui-hooks.c: Add 'source.h' include.
1993
1994 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1995
1996         * source.c (print_source_lines_base): Handle requests to print
1997         reverse line number sequences, and guard against empty lines
1998         string.
1999
2000 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2001
2002         * source.c (print_source_lines_base): Fix skip of '\r' if next
2003         character is '\n'.
2004
2005 2019-01-06  Tom Tromey  <tom@tromey.com>
2006
2007         * c-exp.y (struct c_parse_state) <macro_original_text,
2008         expansion_obstack>: New member.
2009         (macro_original_text, expansion_obstack): Remove globals.
2010         (scan_macro_expansion, scanning_macro_expansion)
2011         (finished_macro_expansion): Update.
2012         (scan_macro_cleanup): Remove.
2013         (yylex, c_parse): Update.
2014
2015 2019-01-06  Tom Tromey  <tom@tromey.com>
2016
2017         * c-exp.y (struct c_parse_state) <strings>: New member.
2018         (operator_stoken): Update.
2019
2020 2019-01-06  Tom Tromey  <tom@tromey.com>
2021
2022         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2023         (union type_stack_elt) <typelist_val>: Now a pointer to
2024         std::vector.
2025         (type_stack_cleanup): Don't declare.
2026         (push_typelist): Update.
2027         * parse.c (pop_typelist): Return a std::vector.
2028         (push_typelist): Take a std::vector.
2029         (follow_types): Update.  Do not free args.
2030         (type_stack_cleanup): Remove.
2031         * c-exp.y (struct c_parse_state): New.
2032         (cpstate): New global.
2033         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2034         (nonempty_typelist): Update.
2035         (func_mod): Create a new vector.
2036         (c_parse): Create a c_parse_state.
2037         (check_parameter_typelist): Do not delete params.
2038         (function_method): Update.  Do not delete type_list.
2039
2040 2019-01-06  Tom Tromey  <tom@tromey.com>
2041
2042         PR gdb/28155:
2043         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2044         check_typedef.
2045         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2046         (print_return_value): Likewise.
2047
2048 2019-01-05  Tom Tromey  <tom@tromey.com>
2049
2050         * contrib/cleanup_check.py: Remove.
2051         * contrib/gcc-with-excheck: Remove.
2052         * contrib/exsummary.py: Remove.
2053         * contrib/excheck.py: Remove.
2054
2055 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2056
2057         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2058         NULL. Initialize tpprev to NULL instead of assigning it
2059         to NULL on the next statement.
2060         * windows-nat.c (windows_delete_thread): Remove check for
2061         main_thread_id before printing thread exit notifications.
2062         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2063         Remove thread ID check against main_thread_id.
2064         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2065         windows_delete_thread.
2066         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2067
2068 2019-01-04  Tom Tromey  <tom@tromey.com>
2069
2070         * compile/compile.c (_initialize_compile): Use upper case for
2071         metasyntactic variables.
2072         * symmisc.c (_initialize_symmisc): Use upper case for
2073         metasyntactic variables.
2074         * psymtab.c (_initialize_psymtab): Use upper case for
2075         metasyntactic variables.
2076         * demangle.c (demangle_command): Use upper case for metasyntactic
2077         variables.
2078         (_initialize_demangler): Likewise.
2079         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2080         variables.
2081
2082 2019-01-03  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2085
2086 2019-01-03  Tom Tromey  <tom@tromey.com>
2087
2088         * python/py-symtab.c (salpy_str): Update.
2089         (struct salpy_sal_object) <symtab>: Now a PyObject.
2090         (salpy_dealloc): Update.
2091         (del_objfile_sal): Use gdbpy_ref.
2092
2093 2019-01-03  Tom Tromey  <tom@tromey.com>
2094
2095         * python/py-type.c (convert_field): Use new_reference.  Return
2096         gdbpy_ref.
2097         (make_fielditem): Return gdbpy_ref.
2098         (typy_fields): Update.
2099         (typy_getitem): Update.
2100         (field_name): Return gdbpy_ref.  Use new_reference.
2101         (typy_iterator_iternext): Update.
2102
2103 2019-01-03  Tom Tromey  <tom@tromey.com>
2104
2105         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2106
2107 2019-01-03  Tom Tromey  <tom@tromey.com>
2108
2109         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2110         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2111         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2112         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2113         (pspy_set_type_printers): Likewise.
2114         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2115         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2116         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2117         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2118         (objfpy_set_type_printers): Likewise.
2119
2120 2019-01-03  Tom Tromey  <tom@tromey.com>
2121
2122         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2123         (gdbpy_print_stack): Use gdbpy_err_fetch.
2124         * python/python-internal.h (class gdbpy_err_fetch): New class.
2125         (class gdbpy_enter) <m_error_type, m_error_value,
2126         m_error_traceback>: Remove.
2127         <m_error>: New member.
2128         (gdbpy_exception_to_string): Don't declare.
2129         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2130         * python/py-value.c (convert_value_from_python): Use
2131         gdbpy_err_fetch.
2132         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2133         gdbpy_exception_to_string.
2134         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2135         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2136         gdbpy_err_fetch.
2137
2138 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         * linux-nat.c (delete_lwp_cleanup): Delete.
2141         (struct lwp_deleter): New struct.
2142         (lwp_info_up): New typedef.
2143         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2144         lwp_info_up.
2145
2146 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2147
2148         * linux-fork.c (class scoped_switch_fork_info): New class.
2149         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2150
2151 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * valops.c (find_overload_match): Remove use of null_cleanup, and
2154         calls to do_cleanups.
2155
2156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * compile/compile-cplus-types.c
2159         (compile_cplus_instance::decl_name): Handle changes to
2160         cp_func_name.
2161         * cp-support.c (cp_func_name): Update header comment, update
2162         return type.
2163         * cp-support.h (cp_func_name): Update return type in declaration.
2164         * valops.c (find_overload_match): Move temp_func local to top
2165         level of function and change its type.  Use temp_func to hold and
2166         delete temporary string obtained from cp_func_name.
2167
2168 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2171         gdb::char_vector, remove cleanup, and update uses of `msg`.
2172
2173 2019-01-03  Jim Wilson  <jimw@sifive.com>
2174
2175         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2176
2177 2019-01-02  Tom Tromey  <tom@tromey.com>
2178
2179         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2180         (tdesc_parse_xml): Remove cleanups.
2181         * target-descriptions.h (make_cleanup_free_target_description):
2182         Don't declare.
2183         (target_desc_deleter): New struct.
2184         (target_desc_up): New typedef.
2185         * target-descriptions.c (target_desc_deleter::operator()): Rename
2186         from free_target_description.
2187         (make_cleanup_free_target_description): Remove.
2188
2189 2019-01-02  Tom Tromey  <tom@tromey.com>
2190
2191         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2192         constructor, destructor.
2193         (linespec_parser): Remove typedef.
2194         (~linespec_parser): Rename from linespec_parser_delete.
2195         (linespec_lex_to_end, linespec_complete_label)
2196         (linespec_complete): Update.
2197         (decode_line_full): Remove cleanups.
2198         (decode_line_1): Update.
2199
2200 2019-01-02  Tom Tromey  <tom@tromey.com>
2201
2202         * python/python-internal.h (inferior_to_inferior_object): Change
2203         return type.
2204         * python/py-exitedevent.c (create_exited_event_object): Update.
2205         * python/py-inferior.c (inferior_to_inferior_object): Return
2206         gdbpy_ref.
2207         (python_new_inferior, python_inferior_deleted)
2208         (thread_to_thread_object, delete_thread_object)
2209         (build_inferior_list, gdbpy_selected_inferior): Update.
2210         * python/py-infthread.c (create_thread_object): Update.  Also fail
2211         if inferior_to_inferior_object fails.
2212
2213 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2214
2215         * inferior.h (class inferior) <displaced_step_state>: New field.
2216         * infrun.h (struct displaced_step_state): Move here from
2217         infrun.c.  Initialize fields, add constructor.
2218         <inf>: Remove field.
2219         <reset>: New method.
2220         * infrun.c (struct displaced_step_inferior_state): Move to
2221         infrun.h.
2222         (displaced_step_inferior_states): Remove.
2223         (get_displaced_stepping_state): Adust.
2224         (displaced_step_in_progress_any_inferior): Adjust.
2225         (displaced_step_in_progress_thread): Adjust.
2226         (displaced_step_in_progress): Adjust.
2227         (add_displaced_stepping_state): Remove.
2228         (get_displaced_step_closure_by_addr): Adjust.
2229         (remove_displaced_stepping_state): Remove.
2230         (infrun_inferior_exit): Call displaced_step_state.reset.
2231         (use_displaced_stepping): Don't check for NULL.
2232         (displaced_step_prepare_throw): Call
2233         get_displaced_stepping_state.
2234         (displaced_step_fixup): Don't check for NULL.
2235         (prepare_for_detach): Don't check for NULL.
2236
2237 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2238
2239         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2240          in case of call that did not complete.
2241
2242 2019-01-02  Andrey Utkin  <autkin@undo.io>
2243
2244         * symfile.c (find_separate_debug_file): Fix search of debug files for
2245         remote debuggee.
2246
2247 2019-01-02  Tom Tromey  <tom@tromey.com>
2248
2249         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2250         indentation.
2251         * python/py-frame.c (frapy_older): Remove cast.
2252         (frapy_newer): Likewise.
2253         * python/py-breakpoint.c (local_setattro): Remove cast.
2254         * python/py-arch.c (archpy_name): Remove local variable.
2255         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2256
2257 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2258
2259         * unittests/basic_string_view/element_access/char/empty.cc:
2260         Fix year range in copyright header.
2261
2262 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2265         Delete.
2266         <operator==>: Update with for removed field.
2267         <hash>: Likewise.
2268         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2269         <isa_features>: ...this.
2270         <abi_features>: New field.
2271         (riscv_isa_flen): Update comment.
2272         (riscv_abi_xlen): New declaration.
2273         (riscv_abi_flen): New declaration.
2274         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2275         isa_features.
2276         (riscv_abi_xlen): New function.
2277         (riscv_isa_flen): Update to get answer from isa_features.
2278         (riscv_abi_flen): New function.
2279         (riscv_has_fp_abi): Update to get answer from abi_features.
2280         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2281         xlen and flen.
2282         (riscv_call_info) <xlen, flen>: Update comment.
2283         (riscv_call_arg_struct): Remove invalid assertions
2284         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2285         is removed.
2286         (riscv_gdbarch_init): Gather isa features and abi features
2287         separately, ensure both match on the gdbarch when reusing an old
2288         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2289         a target with 64-bit float hardware.
2290
2291 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2292
2293         * source.c (search_command_helper): Stop reverse search
2294         when line 1 has been searched.
2295
2296 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2297
2298         * record-full.c (record_full_base_target::close): Rewrite
2299         record_full_core_buf_list free logic.
2300
2301 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2302
2303         * break-catch-syscall.c (print_one_catch_syscall): xfree
2304         the last text.
2305
2306 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2307
2308         * top.c (print_gdb_version): Update Copyright year in version
2309         message.
2310
2311 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2312
2313         Update copyright year range in all GDB files.
2314
2315 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2316
2317         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2318
2319 For older changes see ChangeLog-2018.
2320 \f
2321 Local Variables:
2322 mode: change-log
2323 left-margin: 8
2324 fill-column: 74
2325 version-control: never
2326 coding: utf-8
2327 End:
2328