gdb/ChangeLog

   1 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * NEWS: Mention end of support for native debugging on MS-Windows
   4         before XP.
   5
   6 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
   7
   8         PR gdb/24292
   9         * common/netstuff.c:
  10         * gdbserver/gdbreplay.c
  11         * gdbserver/remote-utils.c:
  12         * ser-tcp.c:
  13         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  14         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  15         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  16         'getaddrinfo' and 'freeaddrinfo' were not available before
  17         Windows XP, and mingw.org's MinGW headers by default define
  18         _WIN32_WINNT to 0x500.
  19
  20 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  21
  22         * NEWS: Note minimum Python version.
  23
  24 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  25
  26         * version.in: Set GDB version number to 8.2.90.DATE-git.
  27
  28 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  29
  30         GDB 8.2.90 released.
  31
  32 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  33
  34         * version.in: Set GDB version number to 8.2.90.
  35
  36 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  37
  38         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  39
  40 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  41
  42         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  43         * version.in: Bump version to 8.2.90.DATE-git.
  44
  45 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  46
  47         * aix-thread.c (ptid_cmp): Remove unused variable.
  48         (get_signaled_thread): Likewise.
  49         (store_regs_user_thread): Likewise.
  50         (store_regs_kernel_thread): Likewise.
  51         (fetch_regs_kernel_thread): Remove shadowed variable.
  52
  53 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * features/riscv/32bit-cpu.xml: Add register numbers.
  56         * features/riscv/32bit-fpu.c: Regenerate.
  57         * features/riscv/32bit-fpu.xml: Add register numbers.
  58         * features/riscv/64bit-cpu.xml: Add register numbers.
  59         * features/riscv/64bit-fpu.c: Regenerate.
  60         * features/riscv/64bit-fpu.xml: Add register numbers.
  61
  62 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  63
  64         * NEWS: Mention two argument form of gdb.Value constructor.
  65         * python/py-value.c (convert_buffer_and_type_to_value): New
  66         function.
  67         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  68         Add support for handling an optional second argument.  Call
  69         convert_buffer_and_type_to_value as appropriate.
  70         * python/python-internal.h (Py_buffer_deleter): New struct.
  71         (Py_buffer_up): New typedef.
  72
  73 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  74
  75         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  76         instead of releasing ownership.
  77
  78 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  79
  80         * dwarf2read.c (open_and_init_dwp_file): Call
  81         elf_numsections instead of bfd_count_sections to initialize
  82         dwp_file->num_sections.
  83
  84 2019-02-25  Tom Tromey  <tromey@adacore.com>
  85
  86         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  87
  88 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  89
  90         * gcore.in: Add '--readnever' option when invoking GDB.
  91
  92 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  93
  94         * MAINTAINERS: Update my email address.
  95
  96 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  97
  98         * build-id.c (build_id_to_debug_bfd_1): New function.
  99         (build_id_to_debug_bfd): Look for separate debug file in
 100         sysroot.
 101
 102 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 103
 104         * gdbarch.sh: Update the copyright year range that is placed into
 105         generated files.
 106
 107 2019-02-22  Keith Seitz  <keiths@redhat.com>
 108
 109         PR symtab/23853
 110         * linespec.c (create_sals_line_offset): Search for the default
 111         symtab's filename instead of its fullname.
 112
 113 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 114
 115         * NEWS: Update style defaults.
 116
 117 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 118
 119         * main.c (captured_main_1): Disable styling in batch mode.
 120
 121 2019-02-20  Tom Tromey  <tom@tromey.com>
 122
 123         * symtab.c (symtab_symbol_info): Fix typos.
 124
 125 2019-02-20  Tom Tromey  <tromey@adacore.com>
 126
 127         * findcmd.c (_initialize_mem_search): Use upper case for
 128         metasyntactic variables.
 129
 130 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 131
 132         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 133         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 134
 135 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 136
 137         * top.h (source_file_name): Change to std::string.
 138         * top.c (source_file_name): Likewise.
 139         (command_line_input): Adjust.
 140         * cli/cli-script.c (script_from_file): Adjust.
 141
 142 2019-02-19  Tom Tromey  <tromey@adacore.com>
 143
 144         * ravenscar-thread.c
 145         (ravenscar_thread_target::update_thread_list): Don't call
 146         ada_build_task_list.
 147         * ada-lang.h (ada_build_task_list): Don't declare.
 148         * ada-tasks.c (struct ada_tasks_inferior_data)
 149         <task_list_valid_p>: Now bool.
 150         (read_known_tasks, ada_task_list_changed)
 151         (ada_tasks_invalidate_inferior_data): Update.
 152         (read_known_tasks_array): Return bool.
 153         (read_known_tasks_list): Likewise.
 154         (read_known_tasks): Return void.
 155         (ada_build_task_list): Now static.
 156
 157 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 160         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 161
 162 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 163
 164         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 165         variant for ada_tasks_pspace_data_handle and
 166         ada_tasks_inferior_data_handle.
 167         (ada_tasks_pspace_data_cleanup): New function.
 168         (ada_tasks_inferior_data_cleanup): New function.
 169
 170 2019-02-17  Tom Tromey  <tom@tromey.com>
 171
 172         * macrotab.h (macro_source_fullname): Return a std::string.
 173         * macrotab.c (macro_include, check_for_redefinition)
 174         (macro_undef, macro_lookup_definition, foreach_macro)
 175         (foreach_macro_in_scope): Update.
 176         (macro_source_fullname): Return a std::string.
 177         * macrocmd.c (show_pp_source_pos): Update.
 178
 179 2019-02-17  Tom Tromey  <tom@tromey.com>
 180
 181         * macrocmd.c (show_pp_source_pos): Style the file names.
 182
 183 2019-02-17  Tom Tromey  <tom@tromey.com>
 184
 185         PR tui/24197:
 186         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 187
 188 2019-02-17  Tom Tromey  <tom@tromey.com>
 189
 190         * ada-lang.c (user_select_syms): Use filtered printing.
 191         * utils.c (wrap_style): New global.
 192         (desired_style): Remove.
 193         (emit_style_escape): Add stream parameter.
 194         (set_output_style, reset_terminal_style, prompt_for_continue):
 195         Update.
 196         (flush_wrap_buffer): Only flush gdb_stdout.
 197         (wrap_here): Set wrap_style.
 198         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 199         treat escape sequences as a character.  Change when wrap buffer is
 200         flushed.
 201         (fputs_styled): Do not set the output style when the default is
 202         requested.
 203         * ui-style.h (struct ui_file_style) <is_default>: New method.
 204         * source.c (print_source_lines_base): Emit escape sequences in one
 205         piece.
 206
 207 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 208
 209         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 210         integers and enumeration types.
 211
 212 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 213
 214         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 215         instead of lookup_symbol_in_language
 216         (do_exact_match): New function.
 217         (ada_get_symbol_name_matcher): Return do_exact_match when
 218         doing a verbatim match.
 219
 220 2019-02-15  Tom Tromey  <tromey@adacore.com>
 221
 222         * ravenscar-thread.c (ravenscar_thread_target::resume)
 223         (ravenscar_thread_target::wait): Special case wildcard requests.
 224
 225 2019-02-15  Tom Tromey  <tromey@adacore.com>
 226
 227         * ravenscar-thread.c (base_ptid): Remove.
 228         (struct ravenscar_thread_target) <close>: New method.
 229         <m_base_ptid>: New member.
 230         <update_inferior_ptid, active_task, task_is_currently_active,
 231         runtime_initialized>: Declare methods.
 232         <ravenscar_thread_target>: Add constructor.
 233         (ravenscar_thread_target::task_is_currently_active)
 234         (ravenscar_thread_target::update_inferior_ptid)
 235         (ravenscar_runtime_initialized): Rename.  Now methods.
 236         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 237         (ravenscar_thread_target::update_thread_list): Update.
 238         (ravenscar_thread_target::active_task): Now method.
 239         (ravenscar_thread_target::store_registers)
 240         (ravenscar_thread_target::prepare_to_store)
 241         (ravenscar_thread_target::prepare_to_store)
 242         (ravenscar_thread_target::mourn_inferior): Update.
 243         (ravenscar_inferior_created): Use "new" to create target.
 244         (ravenscar_thread_target::get_ada_task_ptid): Update.
 245         (_initialize_ravenscar): Don't initialize base_ptid.
 246         (ravenscar_ops): Remove global.
 247
 248 2019-02-15  Tom Tromey  <tromey@adacore.com>
 249
 250         * target.h (push_target): Declare new overload.
 251         * target.c (push_target): New overload, taking an rvalue reference.
 252         * remote.c (remote_target::open_1): Use push_target overload.
 253         * corelow.c (core_target_open): Use push_target overload.
 254
 255 2019-02-15  Tom Tromey  <tromey@adacore.com>
 256
 257         * ravenscar-thread.c (is_ravenscar_task)
 258         (ravenscar_task_is_currently_active): Return bool.
 259         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 260         (_initialize_ravenscar): Remove "(void)".
 261         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 262         Return bool.
 263
 264 2019-02-15  Tom Tromey  <tromey@adacore.com>
 265
 266         * ravenscar-thread.c (ravenscar_runtime_initializer)
 267         (has_ravenscar_runtime, get_running_thread_id)
 268         (ravenscar_thread_target::resume): Fix indentation.
 269
 270 2019-02-15  Tom Tromey  <tromey@adacore.com>
 271
 272         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 273         from ravenscar_arch_ops.
 274         (sparc_ravenscar_ops::fetch_registers)
 275         (sparc_ravenscar_ops::store_registers): Now methods.
 276         (sparc_ravenscar_prepare_to_store): Remove.
 277         (sparc_ravenscar_ops): Redefine.
 278         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 279         methods and destructor.  Remove members.
 280         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 281         (ravenscar_thread_target::store_registers)
 282         (ravenscar_thread_target::prepare_to_store): Update.
 283         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 284         Remove.
 285         (struct ppc_ravenscar_powerpc_ops): Derive from
 286         ravenscar_arch_ops.
 287         (ppc_ravenscar_powerpc_ops::fetch_registers)
 288         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 289         (ppc_ravenscar_powerpc_ops): Redefine.
 290         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 291         (ppc_ravenscar_e500_ops::fetch_registers)
 292         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 293         (ppc_ravenscar_e500_ops): Redefine.
 294         * aarch64-ravenscar-thread.c
 295         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 296         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 297         (aarch64_ravenscar_fetch_registers)
 298         (aarch64_ravenscar_store_registers): Now methods.
 299         (aarch64_ravenscar_ops): Redefine.
 300
 301 2019-02-15  Tom Tromey  <tromey@adacore.com>
 302
 303         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 304         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 305         (ravenscar_thread_target::stopped_by_watchpoint)
 306         (ravenscar_thread_target::stopped_data_address)
 307         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 308
 309 2019-02-15  Tom Tromey  <tromey@adacore.com>
 310
 311         * ravenscar-thread.c: Fix some typos.
 312
 313 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 314             Tom Tromey  <tromey@adacore.com>
 315
 316         * ada-lang.c (ada_exception_sal): Change addr_string to a
 317         std::string.
 318         (create_ada_exception_catchpoint): Update.
 319
 320 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 321             Tom Tromey  <tromey@adacore.com>
 322
 323         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 324         (bp_location_ops): Remove.
 325         (base_breakpoint_allocate_location): Update.
 326         (free_bp_location): Update.
 327         * ada-lang.c (class ada_catchpoint_location)
 328         <ada_catchpoint_location>: Remove ops parameter.
 329         (ada_catchpoint_location_dtor): Remove.
 330         (ada_catchpoint_location_ops): Remove.
 331         (allocate_location_exception): Update.
 332         * breakpoint.h (struct bp_location_ops): Remove.
 333         (class bp_location) <bp_location>: Remove bp_location_ops
 334         parameter.
 335         <~bp_location>: Add destructor.
 336         <ops>: Remove.
 337
 338 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 339             Pedro Alves  <palves@redhat.com>
 340
 341         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 342         'PATH_MAX'.
 343
 344 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 345             Samuel Thibault  <samuel.thibault@gnu.org>
 346             Thomas Schwinge  <thomas@codesourcery.com>
 347
 348         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 349         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 350
 351 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 352
 353         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 354         (check_empty): Use "const char *".
 355
 356         * gnu-nat.c (gnu_nat_target::detach): Instead of
 357         'detach_inferior (pid)' call
 358         'detach_inferior (find_inferior_pid (pid))'.
 359
 360         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 361         'nat/fork-inferior.o'.
 362         * gnu-nat.c: #include "nat/fork-inferior.h".
 363
 364         * gnu-nat.c (gnu_nat_target::detach): Instead of
 365         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 366         * gnu-nat.h: #include "inf-child.h".
 367         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 368         'i386_gnu_nat_target::fetch_registers'.
 369         (gnu_store_registers): Rename/move to
 370         'i386_gnu_nat_target::store_registers'.
 371
 372         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 373         * gnu-nat.h (mach_thread_info): New function.
 374         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 375
 376         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 377
 378 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 379
 380         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 381
 382 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 383
 384         * windows-nat.c (windows_add_thread): Add new parameter
 385         "main_thread_p" with default value set to false.  Update
 386         function documentation as well as all callers.
 387         (windows_delete_thread): Likewise.
 388         (fake_create_process): Update call to windows_add_thread.
 389         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 390         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 391         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 392         call to windows_delete_thread.
 393
 394 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 395
 396         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 397
 398 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 399
 400         * symfile.c (find_separate_debug_file): Use canonical path of
 401         sysroot with child_path instead of gdb_sysroot if it is valid.
 402
 403 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 404
 405         * symfile.c (find_separate_debug_file): Use child_path to
 406         determine if an object file is under a sysroot.
 407
 408 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 409
 410         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 411         unittests/child-path-selftests.c.
 412         * common/pathstuff.c (child_path): New function.
 413         * common/pathstuff.h (child_path): New prototype.
 414         * unittests/child-path-selftests.c: New file.
 415
 416 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 417
 418         * symfile.c (find_separate_debug_file): Look for separate debug
 419         files in debug directories under the sysroot.
 420
 421 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 422
 423         * symtab.h (struct minimal_symbol data_p): New const method.
 424         (struct minimal_symbol text_p): Likewise.
 425         * symtab.c (output_source_filename): Use file name style
 426         to print file name.
 427         (print_symbol_info): Likewise.
 428         (print_msymbol_info): Use address style to print addresses.
 429         Use function name style to print executable text symbols.
 430         (expand_symtab_containing_pc): Use data_p.
 431         (find_pc_sect_compunit_symtab): Likewise.
 432
 433 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 434
 435         * breakpoint.c (describe_other_breakpoints): Use address style
 436         to print addresses.
 437         (say_where): Likewise.
 438
 439 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 440
 441         * ada-typeprint.c (print_func_type): Print function name
 442         style to print function name.
 443         * c-typeprint.c (c_print_type_1): Likewise.
 444
 445 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 446
 447         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 448         for execve.
 449
 450 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 451
 452         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 453         type_stack.
 454
 455 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 456
 457         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 458         TYPE_CODE_REF types.
 459
 460 2019-02-08  Jim Wilson  <jimw@sifive.com>
 461
 462         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 463         (riscv_linux_fregset): New.
 464         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 465
 466 2019-02-07  Tom Tromey  <tom@tromey.com>
 467
 468         * thread.c (thread_cancel_execution_command): Update.
 469         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 470         methods.
 471         (struct thread_fsm_ops): Remove.
 472         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 473         (thread_fsm_should_stop, thread_fsm_return_value)
 474         (thread_fsm_set_finished, thread_fsm_finished_p)
 475         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 476         Don't declare.
 477         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 478         * infrun.c (clear_proceed_status_thread)
 479         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 480         (print_stop_event): Update.
 481         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 482         Add constructor.
 483         (step_command_fsm_ops): Remove.
 484         (new_step_command_fsm): Remove.
 485         (step_1): Update.
 486         (step_command_fsm::should_stop): Rename from
 487         step_command_fsm_should_stop.
 488         (step_command_fsm::clean_up): Rename from
 489         step_command_fsm_clean_up.
 490         (step_command_fsm::do_async_reply_reason): Rename from
 491         step_command_fsm_async_reply_reason.
 492         (struct until_next_fsm): Inherit from thread_fsm.  Add
 493         constructor.
 494         (until_next_fsm_ops): Remove.
 495         (new_until_next_fsm): Remove.
 496         (until_next_fsm::should_stop): Rename from
 497         until_next_fsm_should_stop.
 498         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 499         (until_next_fsm::do_async_reply_reason): Rename from
 500         until_next_fsm_async_reply_reason.
 501         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 502         constructor.  Change type of breakpoint.
 503         (finish_command_fsm_ops): Remove.
 504         (new_finish_command_fsm): Remove.
 505         (finish_command_fsm::should_stop): Rename from
 506         finish_command_fsm_should_stop.
 507         (finish_command_fsm::clean_up): Rename from
 508         finish_command_fsm_clean_up.
 509         (finish_command_fsm::return_value): Rename from
 510         finish_command_fsm_return_value.
 511         (finish_command_fsm::do_async_reply_reason): Rename from
 512         finish_command_fsm_async_reply_reason.
 513         (finish_command): Update.
 514         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 515         Add constructor.
 516         (call_thread_fsm_ops): Remove.
 517         (call_thread_fsm::call_thread_fsm): Rename from
 518         new_call_thread_fsm.
 519         (call_thread_fsm::should_stop): Rename from
 520         call_thread_fsm_should_stop.
 521         (call_thread_fsm::should_notify_stop): Rename from
 522         call_thread_fsm_should_notify_stop.
 523         (run_inferior_call, call_function_by_hand_dummy): Update.
 524         * cli/cli-interp.c (should_print_stop_to_console): Update.
 525         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 526         Add constructor.  Change type of location_breakpoint,
 527         caller_breakpoint.
 528         (until_break_fsm_ops): Remove.
 529         (new_until_break_fsm): Remove.
 530         (until_break_fsm::should_stop): Rename from
 531         until_break_fsm_should_stop.
 532         (until_break_fsm::clean_up): Rename from
 533         until_break_fsm_clean_up.
 534         (until_break_fsm::do_async_reply_reason): Rename from
 535         until_break_fsm_async_reply_reason.
 536         (until_break_command): Update.
 537         * thread-fsm.c: Remove.
 538         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 539
 540 2019-02-07  Tom Tromey  <tom@tromey.com>
 541
 542         * yy-remap.h: Add include guard.
 543         * xtensa-tdep.h: Add include guard.
 544         * xcoffread.h: Rename include guard.
 545         * varobj-iter.h: Add include guard.
 546         * tui/tui.h: Rename include guard.
 547         * tui/tui-winsource.h: Rename include guard.
 548         * tui/tui-wingeneral.h: Rename include guard.
 549         * tui/tui-windata.h: Rename include guard.
 550         * tui/tui-win.h: Rename include guard.
 551         * tui/tui-stack.h: Rename include guard.
 552         * tui/tui-source.h: Rename include guard.
 553         * tui/tui-regs.h: Rename include guard.
 554         * tui/tui-out.h: Rename include guard.
 555         * tui/tui-layout.h: Rename include guard.
 556         * tui/tui-io.h: Rename include guard.
 557         * tui/tui-hooks.h: Rename include guard.
 558         * tui/tui-file.h: Rename include guard.
 559         * tui/tui-disasm.h: Rename include guard.
 560         * tui/tui-data.h: Rename include guard.
 561         * tui/tui-command.h: Rename include guard.
 562         * tic6x-tdep.h: Add include guard.
 563         * target/waitstatus.h: Rename include guard.
 564         * target/wait.h: Rename include guard.
 565         * target/target.h: Rename include guard.
 566         * target/resume.h: Rename include guard.
 567         * target-float.h: Rename include guard.
 568         * stabsread.h: Add include guard.
 569         * rs6000-tdep.h: Add include guard.
 570         * riscv-fbsd-tdep.h: Add include guard.
 571         * regformats/regdef.h: Rename include guard.
 572         * record.h: Rename include guard.
 573         * python/python.h: Rename include guard.
 574         * python/python-internal.h: Rename include guard.
 575         * python/py-stopevent.h: Rename include guard.
 576         * python/py-ref.h: Rename include guard.
 577         * python/py-record.h: Rename include guard.
 578         * python/py-record-full.h: Rename include guard.
 579         * python/py-record-btrace.h: Rename include guard.
 580         * python/py-instruction.h: Rename include guard.
 581         * python/py-events.h: Rename include guard.
 582         * python/py-event.h: Rename include guard.
 583         * procfs.h: Add include guard.
 584         * proc-utils.h: Add include guard.
 585         * p-lang.h: Add include guard.
 586         * or1k-tdep.h: Rename include guard.
 587         * observable.h: Rename include guard.
 588         * nto-tdep.h: Rename include guard.
 589         * nat/x86-linux.h: Rename include guard.
 590         * nat/x86-linux-dregs.h: Rename include guard.
 591         * nat/x86-gcc-cpuid.h: Add include guard.
 592         * nat/x86-dregs.h: Rename include guard.
 593         * nat/x86-cpuid.h: Rename include guard.
 594         * nat/ppc-linux.h: Rename include guard.
 595         * nat/mips-linux-watch.h: Rename include guard.
 596         * nat/linux-waitpid.h: Rename include guard.
 597         * nat/linux-ptrace.h: Rename include guard.
 598         * nat/linux-procfs.h: Rename include guard.
 599         * nat/linux-osdata.h: Rename include guard.
 600         * nat/linux-nat.h: Rename include guard.
 601         * nat/linux-namespaces.h: Rename include guard.
 602         * nat/linux-btrace.h: Rename include guard.
 603         * nat/glibc_thread_db.h: Rename include guard.
 604         * nat/gdb_thread_db.h: Rename include guard.
 605         * nat/gdb_ptrace.h: Rename include guard.
 606         * nat/fork-inferior.h: Rename include guard.
 607         * nat/amd64-linux-siginfo.h: Rename include guard.
 608         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 609         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 610         * nat/aarch64-linux.h: Rename include guard.
 611         * nat/aarch64-linux-hw-point.h: Rename include guard.
 612         * mn10300-tdep.h: Add include guard.
 613         * mips-linux-tdep.h: Add include guard.
 614         * mi/mi-parse.h: Rename include guard.
 615         * mi/mi-out.h: Rename include guard.
 616         * mi/mi-main.h: Rename include guard.
 617         * mi/mi-interp.h: Rename include guard.
 618         * mi/mi-getopt.h: Rename include guard.
 619         * mi/mi-console.h: Rename include guard.
 620         * mi/mi-common.h: Rename include guard.
 621         * mi/mi-cmds.h: Rename include guard.
 622         * mi/mi-cmd-break.h: Rename include guard.
 623         * m2-lang.h: Add include guard.
 624         * location.h: Rename include guard.
 625         * linux-record.h: Rename include guard.
 626         * linux-nat.h: Add include guard.
 627         * linux-fork.h: Add include guard.
 628         * i386-darwin-tdep.h: Rename include guard.
 629         * hppa-linux-offsets.h: Add include guard.
 630         * guile/guile.h: Rename include guard.
 631         * guile/guile-internal.h: Rename include guard.
 632         * gnu-nat.h: Rename include guard.
 633         * gdb-stabs.h: Rename include guard.
 634         * frv-tdep.h: Add include guard.
 635         * f-lang.h: Add include guard.
 636         * event-loop.h: Add include guard.
 637         * darwin-nat.h: Rename include guard.
 638         * cp-abi.h: Rename include guard.
 639         * config/sparc/nm-sol2.h: Rename include guard.
 640         * config/nm-nto.h: Rename include guard.
 641         * config/nm-linux.h: Add include guard.
 642         * config/i386/nm-i386gnu.h: Rename include guard.
 643         * config/djgpp/nl_types.h: Rename include guard.
 644         * config/djgpp/langinfo.h: Rename include guard.
 645         * compile/gcc-cp-plugin.h: Add include guard.
 646         * compile/gcc-c-plugin.h: Add include guard.
 647         * compile/compile.h: Rename include guard.
 648         * compile/compile-object-run.h: Rename include guard.
 649         * compile/compile-object-load.h: Rename include guard.
 650         * compile/compile-internal.h: Rename include guard.
 651         * compile/compile-cplus.h: Rename include guard.
 652         * compile/compile-c.h: Rename include guard.
 653         * common/xml-utils.h: Rename include guard.
 654         * common/x86-xstate.h: Rename include guard.
 655         * common/version.h: Rename include guard.
 656         * common/vec.h: Rename include guard.
 657         * common/tdesc.h: Rename include guard.
 658         * common/selftest.h: Rename include guard.
 659         * common/scoped_restore.h: Rename include guard.
 660         * common/scoped_mmap.h: Rename include guard.
 661         * common/scoped_fd.h: Rename include guard.
 662         * common/safe-iterator.h: Rename include guard.
 663         * common/run-time-clock.h: Rename include guard.
 664         * common/refcounted-object.h: Rename include guard.
 665         * common/queue.h: Rename include guard.
 666         * common/ptid.h: Rename include guard.
 667         * common/print-utils.h: Rename include guard.
 668         * common/preprocessor.h: Rename include guard.
 669         * common/pathstuff.h: Rename include guard.
 670         * common/observable.h: Rename include guard.
 671         * common/netstuff.h: Rename include guard.
 672         * common/job-control.h: Rename include guard.
 673         * common/host-defs.h: Rename include guard.
 674         * common/gdb_wait.h: Rename include guard.
 675         * common/gdb_vecs.h: Rename include guard.
 676         * common/gdb_unlinker.h: Rename include guard.
 677         * common/gdb_unique_ptr.h: Rename include guard.
 678         * common/gdb_tilde_expand.h: Rename include guard.
 679         * common/gdb_sys_time.h: Rename include guard.
 680         * common/gdb_string_view.h: Rename include guard.
 681         * common/gdb_splay_tree.h: Rename include guard.
 682         * common/gdb_setjmp.h: Rename include guard.
 683         * common/gdb_ref_ptr.h: Rename include guard.
 684         * common/gdb_optional.h: Rename include guard.
 685         * common/gdb_locale.h: Rename include guard.
 686         * common/gdb_assert.h: Rename include guard.
 687         * common/filtered-iterator.h: Rename include guard.
 688         * common/filestuff.h: Rename include guard.
 689         * common/fileio.h: Rename include guard.
 690         * common/environ.h: Rename include guard.
 691         * common/common-utils.h: Rename include guard.
 692         * common/common-types.h: Rename include guard.
 693         * common/common-regcache.h: Rename include guard.
 694         * common/common-inferior.h: Rename include guard.
 695         * common/common-gdbthread.h: Rename include guard.
 696         * common/common-exceptions.h: Rename include guard.
 697         * common/common-defs.h: Rename include guard.
 698         * common/common-debug.h: Rename include guard.
 699         * common/cleanups.h: Rename include guard.
 700         * common/buffer.h: Rename include guard.
 701         * common/btrace-common.h: Rename include guard.
 702         * common/break-common.h: Rename include guard.
 703         * cli/cli-utils.h: Rename include guard.
 704         * cli/cli-style.h: Rename include guard.
 705         * cli/cli-setshow.h: Rename include guard.
 706         * cli/cli-script.h: Rename include guard.
 707         * cli/cli-interp.h: Rename include guard.
 708         * cli/cli-decode.h: Rename include guard.
 709         * cli/cli-cmds.h: Rename include guard.
 710         * charset-list.h: Add include guard.
 711         * buildsym-legacy.h: Rename include guard.
 712         * bfin-tdep.h: Add include guard.
 713         * ax.h: Rename include guard.
 714         * arm-linux-tdep.h: Add include guard.
 715         * arm-fbsd-tdep.h: Add include guard.
 716         * arch/xtensa.h: Rename include guard.
 717         * arch/tic6x.h: Add include guard.
 718         * arch/i386.h: Add include guard.
 719         * arch/arm.h: Rename include guard.
 720         * arch/arm-linux.h: Rename include guard.
 721         * arch/arm-get-next-pcs.h: Rename include guard.
 722         * arch/amd64.h: Add include guard.
 723         * arch/aarch64-insn.h: Rename include guard.
 724         * arch-utils.h: Rename include guard.
 725         * annotate.h: Add include guard.
 726         * amd64-darwin-tdep.h: Rename include guard.
 727         * aarch64-linux-tdep.h: Add include guard.
 728         * aarch64-fbsd-tdep.h: Add include guard.
 729         * aarch32-linux-nat.h: Add include guard.
 730
 731 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 732
 733         * macrotab.c (macro_define_internal): New function that
 734         factorizes macro_define_object_internal and macro_define_function
 735         code.
 736         (macro_define_object_internal): Use macro_define_internal.
 737         (macro_define_function): Likewise.
 738
 739 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 740
 741         * macrocmd.c (extract_identifier): Return
 742         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 743         callers.
 744
 745 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 746
 747         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 748
 749 2019-02-05  Tom Tromey  <tom@tromey.com>
 750
 751         * target.c (target_stack::unpush): Move assertion earlier.
 752
 753 2019-01-30  Tom Tromey  <tom@tromey.com>
 754
 755         PR python/23615:
 756         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 757         (gdbpy_parse_and_eval): Likewise.
 758         * python/python-internal.h (gdbpy_allow_threads): New class.
 759
 760 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 763         (aarch64_fbsd_fpregmap): Move earlier.
 764         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 765         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 766         instead of individual calls to trad_frame_set_reg_addr.
 767         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 768         earlier.
 769         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 770         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 771         instead of individual calls to trad_frame_set_reg_addr.
 772
 773 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 774
 775         * CONTRIBUTE: Replace contribution list with wiki link.
 776
 777 2019-01-25  Tom Tromey  <tom@tromey.com>
 778
 779         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 780
 781 2019-01-25  Tom Tromey  <tom@tromey.com>
 782
 783         * xtensa-linux-nat.c: Fix common/ includes.
 784         * xml-support.h: Fix common/ includes.
 785         * xml-support.c: Fix common/ includes.
 786         * x86-linux-nat.c: Fix common/ includes.
 787         * windows-nat.c: Fix common/ includes.
 788         * varobj.h: Fix common/ includes.
 789         * varobj.c: Fix common/ includes.
 790         * value.c: Fix common/ includes.
 791         * valops.c: Fix common/ includes.
 792         * utils.c: Fix common/ includes.
 793         * unittests/xml-utils-selftests.c: Fix common/ includes.
 794         * unittests/utils-selftests.c: Fix common/ includes.
 795         * unittests/unpack-selftests.c: Fix common/ includes.
 796         * unittests/tracepoint-selftests.c: Fix common/ includes.
 797         * unittests/style-selftests.c: Fix common/ includes.
 798         * unittests/string_view-selftests.c: Fix common/ includes.
 799         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 800         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 801         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 802         * unittests/rsp-low-selftests.c: Fix common/ includes.
 803         * unittests/parse-connection-spec-selftests.c: Fix common/
 804         includes.
 805         * unittests/optional-selftests.c: Fix common/ includes.
 806         * unittests/offset-type-selftests.c: Fix common/ includes.
 807         * unittests/observable-selftests.c: Fix common/ includes.
 808         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 809         * unittests/memrange-selftests.c: Fix common/ includes.
 810         * unittests/memory-map-selftests.c: Fix common/ includes.
 811         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 812         * unittests/function-view-selftests.c: Fix common/ includes.
 813         * unittests/environ-selftests.c: Fix common/ includes.
 814         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 815         * unittests/common-utils-selftests.c: Fix common/ includes.
 816         * unittests/cli-utils-selftests.c: Fix common/ includes.
 817         * unittests/array-view-selftests.c: Fix common/ includes.
 818         * ui-file.c: Fix common/ includes.
 819         * tui/tui-io.c: Fix common/ includes.
 820         * tracepoint.h: Fix common/ includes.
 821         * tracepoint.c: Fix common/ includes.
 822         * tracefile-tfile.c: Fix common/ includes.
 823         * top.h: Fix common/ includes.
 824         * top.c: Fix common/ includes.
 825         * thread.c: Fix common/ includes.
 826         * target/waitstatus.h: Fix common/ includes.
 827         * target/waitstatus.c: Fix common/ includes.
 828         * target.h: Fix common/ includes.
 829         * target.c: Fix common/ includes.
 830         * target-memory.c: Fix common/ includes.
 831         * target-descriptions.c: Fix common/ includes.
 832         * symtab.h: Fix common/ includes.
 833         * symfile.c: Fix common/ includes.
 834         * stap-probe.c: Fix common/ includes.
 835         * spu-linux-nat.c: Fix common/ includes.
 836         * sparc-nat.c: Fix common/ includes.
 837         * source.c: Fix common/ includes.
 838         * solib.c: Fix common/ includes.
 839         * solib-target.c: Fix common/ includes.
 840         * ser-unix.c: Fix common/ includes.
 841         * ser-tcp.c: Fix common/ includes.
 842         * ser-pipe.c: Fix common/ includes.
 843         * ser-base.c: Fix common/ includes.
 844         * selftest-arch.c: Fix common/ includes.
 845         * s12z-tdep.c: Fix common/ includes.
 846         * rust-exp.y: Fix common/ includes.
 847         * rs6000-aix-tdep.c: Fix common/ includes.
 848         * riscv-tdep.c: Fix common/ includes.
 849         * remote.c: Fix common/ includes.
 850         * remote-notif.h: Fix common/ includes.
 851         * remote-fileio.h: Fix common/ includes.
 852         * remote-fileio.c: Fix common/ includes.
 853         * regcache.h: Fix common/ includes.
 854         * regcache.c: Fix common/ includes.
 855         * record-btrace.c: Fix common/ includes.
 856         * python/python.c: Fix common/ includes.
 857         * python/py-type.c: Fix common/ includes.
 858         * python/py-inferior.c: Fix common/ includes.
 859         * progspace.h: Fix common/ includes.
 860         * producer.c: Fix common/ includes.
 861         * procfs.c: Fix common/ includes.
 862         * proc-api.c: Fix common/ includes.
 863         * printcmd.c: Fix common/ includes.
 864         * ppc-linux-nat.c: Fix common/ includes.
 865         * parser-defs.h: Fix common/ includes.
 866         * osdata.c: Fix common/ includes.
 867         * obsd-nat.c: Fix common/ includes.
 868         * nat/x86-linux.c: Fix common/ includes.
 869         * nat/x86-linux-dregs.c: Fix common/ includes.
 870         * nat/x86-dregs.h: Fix common/ includes.
 871         * nat/x86-dregs.c: Fix common/ includes.
 872         * nat/ppc-linux.c: Fix common/ includes.
 873         * nat/mips-linux-watch.h: Fix common/ includes.
 874         * nat/mips-linux-watch.c: Fix common/ includes.
 875         * nat/linux-waitpid.c: Fix common/ includes.
 876         * nat/linux-ptrace.h: Fix common/ includes.
 877         * nat/linux-ptrace.c: Fix common/ includes.
 878         * nat/linux-procfs.c: Fix common/ includes.
 879         * nat/linux-personality.c: Fix common/ includes.
 880         * nat/linux-osdata.c: Fix common/ includes.
 881         * nat/linux-namespaces.c: Fix common/ includes.
 882         * nat/linux-btrace.h: Fix common/ includes.
 883         * nat/linux-btrace.c: Fix common/ includes.
 884         * nat/fork-inferior.c: Fix common/ includes.
 885         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 886         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 887         * nat/aarch64-linux.c: Fix common/ includes.
 888         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 889         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 890         * namespace.h: Fix common/ includes.
 891         * mips-linux-tdep.c: Fix common/ includes.
 892         * minsyms.c: Fix common/ includes.
 893         * mi/mi-parse.h: Fix common/ includes.
 894         * mi/mi-main.c: Fix common/ includes.
 895         * mi/mi-cmd-env.c: Fix common/ includes.
 896         * memrange.h: Fix common/ includes.
 897         * memattr.c: Fix common/ includes.
 898         * maint.h: Fix common/ includes.
 899         * maint.c: Fix common/ includes.
 900         * main.c: Fix common/ includes.
 901         * machoread.c: Fix common/ includes.
 902         * location.c: Fix common/ includes.
 903         * linux-thread-db.c: Fix common/ includes.
 904         * linux-nat.c: Fix common/ includes.
 905         * linux-fork.c: Fix common/ includes.
 906         * inline-frame.c: Fix common/ includes.
 907         * infrun.c: Fix common/ includes.
 908         * inflow.c: Fix common/ includes.
 909         * inferior.h: Fix common/ includes.
 910         * inferior.c: Fix common/ includes.
 911         * infcmd.c: Fix common/ includes.
 912         * inf-ptrace.c: Fix common/ includes.
 913         * inf-child.c: Fix common/ includes.
 914         * ia64-linux-nat.c: Fix common/ includes.
 915         * i387-tdep.c: Fix common/ includes.
 916         * i386-tdep.c: Fix common/ includes.
 917         * i386-linux-tdep.c: Fix common/ includes.
 918         * i386-linux-nat.c: Fix common/ includes.
 919         * i386-go32-tdep.c: Fix common/ includes.
 920         * i386-fbsd-tdep.c: Fix common/ includes.
 921         * i386-fbsd-nat.c: Fix common/ includes.
 922         * guile/scm-type.c: Fix common/ includes.
 923         * guile/guile.c: Fix common/ includes.
 924         * go32-nat.c: Fix common/ includes.
 925         * gnu-nat.c: Fix common/ includes.
 926         * gdbthread.h: Fix common/ includes.
 927         * gdbarch-selftests.c: Fix common/ includes.
 928         * gdb_usleep.c: Fix common/ includes.
 929         * gdb_select.h: Fix common/ includes.
 930         * gdb_bfd.c: Fix common/ includes.
 931         * gcore.c: Fix common/ includes.
 932         * fork-child.c: Fix common/ includes.
 933         * findvar.c: Fix common/ includes.
 934         * fbsd-nat.c: Fix common/ includes.
 935         * event-top.c: Fix common/ includes.
 936         * event-loop.c: Fix common/ includes.
 937         * dwarf2read.c: Fix common/ includes.
 938         * dwarf2loc.c: Fix common/ includes.
 939         * dwarf2-frame.c: Fix common/ includes.
 940         * dwarf-index-cache.c: Fix common/ includes.
 941         * dtrace-probe.c: Fix common/ includes.
 942         * disasm-selftests.c: Fix common/ includes.
 943         * defs.h: Fix common/ includes.
 944         * csky-tdep.c: Fix common/ includes.
 945         * cp-valprint.c: Fix common/ includes.
 946         * cp-support.h: Fix common/ includes.
 947         * cp-support.c: Fix common/ includes.
 948         * corelow.c: Fix common/ includes.
 949         * completer.h: Fix common/ includes.
 950         * completer.c: Fix common/ includes.
 951         * compile/compile.c: Fix common/ includes.
 952         * compile/compile-loc2c.c: Fix common/ includes.
 953         * compile/compile-cplus-types.c: Fix common/ includes.
 954         * compile/compile-cplus-symbols.c: Fix common/ includes.
 955         * command.h: Fix common/ includes.
 956         * cli/cli-dump.c: Fix common/ includes.
 957         * cli/cli-cmds.c: Fix common/ includes.
 958         * charset.c: Fix common/ includes.
 959         * build-id.c: Fix common/ includes.
 960         * btrace.h: Fix common/ includes.
 961         * btrace.c: Fix common/ includes.
 962         * breakpoint.h: Fix common/ includes.
 963         * breakpoint.c: Fix common/ includes.
 964         * ax.h:
 965         (enum agent_op): Fix common/ includes.
 966         * ax-general.c (struct aop_map): Fix common/ includes.
 967         * ax-gdb.c: Fix common/ includes.
 968         * auxv.c: Fix common/ includes.
 969         * auto-load.c: Fix common/ includes.
 970         * arm-tdep.c: Fix common/ includes.
 971         * arch/riscv.c: Fix common/ includes.
 972         * arch/ppc-linux-common.c: Fix common/ includes.
 973         * arch/i386.c: Fix common/ includes.
 974         * arch/arm.c: Fix common/ includes.
 975         * arch/arm-linux.c: Fix common/ includes.
 976         * arch/arm-get-next-pcs.c: Fix common/ includes.
 977         * arch/amd64.c: Fix common/ includes.
 978         * arch/aarch64.c: Fix common/ includes.
 979         * arch/aarch64-insn.c: Fix common/ includes.
 980         * arch-utils.c: Fix common/ includes.
 981         * amd64-windows-tdep.c: Fix common/ includes.
 982         * amd64-tdep.c: Fix common/ includes.
 983         * amd64-sol2-tdep.c: Fix common/ includes.
 984         * amd64-obsd-tdep.c: Fix common/ includes.
 985         * amd64-nbsd-tdep.c: Fix common/ includes.
 986         * amd64-linux-tdep.c: Fix common/ includes.
 987         * amd64-linux-nat.c: Fix common/ includes.
 988         * amd64-fbsd-tdep.c: Fix common/ includes.
 989         * amd64-fbsd-nat.c: Fix common/ includes.
 990         * amd64-dicos-tdep.c: Fix common/ includes.
 991         * amd64-darwin-tdep.c: Fix common/ includes.
 992         * agent.c: Fix common/ includes.
 993         * ada-lang.h: Fix common/ includes.
 994         * ada-lang.c: Fix common/ includes.
 995         * aarch64-tdep.c: Fix common/ includes.
 996
 997 2019-01-25  Tom Tromey  <tom@tromey.com>
 998
 999         * common/create-version.sh: Use common/version.h.
1000
1001 2019-01-24  Pedro Alves  <palves@redhat.com>
1002
1003         * infrun.c (signal_stop, signal_print, signal_program)
1004         (signal_catch, signal_pass): Now arrays instead of pointers.
1005         (update_signals_program_target, do_target_resume)
1006         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1007         * linux-nat.c (linux_nat_target::pass_signals)
1008         (linux_nat_target::create_inferior, linux_nat_target::attach):
1009         Adjust.
1010         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1011         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1012         * procfs.c (procfs_target::pass_signals): Adjust.
1013         * record-full.c (record_full_target::resume): Adjust.
1014         * remote.c (remote_target::pass_signals)
1015         (remote_target::program_signals): Adjust.
1016         * target-debug.h (target_debug_print_signals): Now takes a
1017         gdb::array_view as parameter.  Adjust.
1018         * target.h (target_ops) <pass_signals, program_signals>: Replace
1019         pointer and length parameters with gdb::array_view.
1020         (target_pass_signals, target_program_signals): Likewise.
1021         * target-delegates.c: Regenerate.
1022
1023 2019-01-24  Pedro Alves  <palves@redhat.com>
1024
1025         * common/forward-scope-exit.h
1026         (forward_scope_exit::forward_scope_exit): Pass arguments to
1027         m_bind_function directly, instead of creating a std::bind and
1028         copying that.
1029
1030 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1031
1032         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1033         for static members.
1034         (pass_in_v_vfp_candidate): Likewise.
1035
1036 2019-01-23  Tom Tromey  <tom@tromey.com>
1037             Pedro Alves  <palves@redhat.com>
1038
1039         * regcache.c (class regcache_invalidator): Remove.
1040         (regcache::raw_write): Use make_scope_exit.
1041
1042 2019-01-23  Tom Tromey  <tom@tromey.com>
1043
1044         * ui-out.h (class ui_out_emit_type): Update comment.
1045
1046 2019-01-23  Tom Tromey  <tom@tromey.com>
1047
1048         * infrun.c (fetch_inferior_event): Update comment.
1049
1050 2019-01-23  Tom Tromey  <tom@tromey.com>
1051             Pedro Alves  <palves@redhat.com>
1052
1053         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1054         parameter.
1055         (fetch_inferior_event): Use SCOPE_EXIT.
1056
1057
1058 2019-01-23  Tom Tromey  <tom@tromey.com>
1059             Pedro Alves  <palves@redhat.com>
1060
1061         * infrun.c (disable_thread_events): Delete.
1062         (stop_all_threads): Use SCOPE_EXIT.
1063
1064 2019-01-23  Tom Tromey  <tom@tromey.com>
1065             Pedro Alves  <palves@redhat.com>
1066
1067         * symfile.c: Include forward-scope-exit.h.
1068         (clear_symtab_users_cleanup): Replace forward declaration with
1069         a FORWARD_SCOPE_EXIT.
1070         (syms_from_objfile_1): Use the forward_scope_exit and
1071         gdb::optional instead of cleanup_function.
1072         (reread_symbols): Use the forward_scope_exit instead of
1073         cleanup_function.
1074         (clear_symtab_users_cleanup): Remove function.
1075
1076 2019-01-23  Tom Tromey  <tom@tromey.com>
1077             Pedro Alves  <palves@redhat.com>
1078
1079         * linux-nat.c: Include scope-exit.h.
1080         (cleanup_target_stop): Remove.
1081         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1082         SCOPE_EXIT.
1083
1084 2019-01-23  Tom Tromey  <tom@tromey.com>
1085             Pedro Alves  <palves@redhat.com>
1086
1087         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1088         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1089
1090 2019-01-23  Tom Tromey  <tom@tromey.com>
1091             Andrew Burgess  <andrew.burgess@embecosm.com>
1092             Pedro Alves  <palves@redhat.com>
1093
1094         * infrun.c (fetch_inferior_event): Use scope_exit.
1095         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1096         * top.c (execute_command): Use scope_exit.
1097         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1098         * utils.c (do_bpstat_clear_actions_cleanup)
1099         (make_bpstat_clear_actions_cleanup): Remove.
1100
1101 2019-01-23  Tom Tromey  <tom@tromey.com>
1102             Pedro Alves  <palves@redhat.com>
1103
1104         * infrun.c: Include "common/scope-exit.h"
1105         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1106         (wait_for_inferior): Use SCOPE_EXIT.
1107         (fetch_inferior_event): Use scope_exit.
1108
1109 2019-01-23  Tom Tromey  <tom@tromey.com>
1110             Pedro Alves  <palves@redhat.com>
1111
1112         * breakpoint.c (create_breakpoint): Remove cleanup.
1113
1114 2019-01-23  Tom Tromey  <tom@tromey.com>
1115             Andrew Burgess  <andrew.burgess@embecosm.com>
1116             Pedro Alves  <palves@redhat.com>
1117
1118 2019-01-23  Pedro Alves  <palves@redhat.com>
1119
1120         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1121
1122 2019-01-23  Pedro Alves  <palves@redhat.com>
1123             Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * gdbthread.h: Include "common/forward-scope-exit.h".
1126         (scoped_finish_thread_state): Redefine custom class in terms of
1127         forward_scope_exit.
1128
1129 2019-01-23  Pedro Alves  <palves@redhat.com>
1130             Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * common/forward-scope-exit.h: New file.
1133
1134 2019-01-23  Pedro Alves  <palves@redhat.com>
1135             Andrew Burgess  <andrew.burgess@embecosm.com>
1136             Tom Tromey  <tom@tromey.com>
1137
1138         * common/scope-exit.h: New file.
1139
1140 2019-01-23  Pedro Alves  <palves@redhat.com>
1141
1142         * common/preprocessor.h (ESC): Rename to ...
1143         (ESC_PARENS): ... this.
1144         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1145         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1146
1147 2019-01-23  Tom Tromey  <tom@tromey.com>
1148
1149         * language.h (class scoped_switch_to_sym_language_if_auto):
1150         Initialize m_lang in both cases.
1151
1152 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1153
1154         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1155         with XCNEW.
1156
1157 2019-01-22  Tom Tromey  <tom@tromey.com>
1158
1159         * corelow.c: Do not include sys/file.h.
1160
1161 2019-01-22  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-wingeneral.h: Include gdb_curses.h.
1164
1165 2019-01-22  Tom Tromey  <tom@tromey.com>
1166
1167         * source-cache.h (class source_cache) <get_source_lines,
1168         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1169
1170 2019-01-22  Tom Tromey  <tom@tromey.com>
1171
1172         * remote-fileio.h (struct remote_target): Declare.
1173
1174 2019-01-22  Tom Tromey  <tom@tromey.com>
1175
1176         * python/py-arch.c: Do not include py-ref.h.
1177         * python/py-bpevent.c: Do not include py-ref.h.
1178         * python/py-cmd.c: Do not include py-ref.h.
1179         * python/py-continueevent.c: Do not include py-ref.h.
1180         * python/py-event.h: Do not include py-ref.h.
1181         * python/py-evtregistry.c: Do not include py-ref.h.
1182         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1183         * python/py-frame.c: Do not include py-ref.h.
1184         * python/py-framefilter.c: Do not include py-ref.h.
1185         * python/py-function.c: Do not include py-ref.h.
1186         * python/py-infevents.c: Do not include py-ref.h.
1187         * python/py-linetable.c: Do not include py-ref.h.
1188         * python/py-objfile.c: Do not include py-ref.h.
1189         * python/py-param.c: Do not include py-ref.h.
1190         * python/py-prettyprint.c: Do not include py-ref.h.
1191         * python/py-progspace.c: Do not include py-ref.h.
1192         * python/py-symbol.c: Do not include py-ref.h.
1193         * python/py-symtab.c: Do not include py-ref.h.
1194         * python/py-type.c: Do not include py-ref.h.
1195         * python/py-unwind.c: Do not include py-ref.h.
1196         * python/py-utils.c: Do not include py-ref.h.
1197         * python/py-value.c: Do not include py-ref.h.
1198         * python/py-varobj.c: Do not include py-ref.h.
1199         * python/py-xmethods.c: Do not include py-ref.h.
1200         * python/python.c: Do not include py-ref.h.
1201         * varobj.c: Do not include py-ref.h.
1202
1203 2019-01-22  Tom Tromey  <tom@tromey.com>
1204
1205         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1206         keyword for bcache.
1207
1208 2019-01-22  Tom Tromey  <tom@tromey.com>
1209
1210         * compile/compile-cplus-types.c: Remove a comment by #include.
1211
1212 2019-01-22  Tom Tromey  <tom@tromey.com>
1213
1214         * compile/gcc-c-plugin.h: Include compile-internal.h.
1215
1216 2019-01-22  Tom Tromey  <tom@tromey.com>
1217
1218         * stabsread.c (EXTERN): Do not define.
1219         (symnum, next_symbol_text_func, processing_gcc_compilation)
1220         (within_function, global_sym_chain, global_stabs)
1221         (previous_stab_code, this_object_header_files)
1222         (n_this_object_header_files)
1223         (n_allocated_this_object_header_files): Define.
1224         * stabsread.h (EXTERN): Never define.  Use "extern".
1225
1226 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1227
1228         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1229         history_value.
1230
1231 2019-01-21  Tom Tromey  <tom@tromey.com>
1232
1233         * ui-out.c: Fix includes.
1234         * tui/tui-source.c: Fix includes.
1235         * target.c: Fix includes.
1236         * remote.c: Fix includes.
1237         * regcache.c: Fix includes.
1238         * python/py-block.c: Fix includes.
1239         * printcmd.c: Fix includes.
1240         * or1k-tdep.c: Fix includes.
1241         * mi/mi-main.c: Fix includes.
1242         * m32r-tdep.c: Fix includes.
1243         * csky-tdep.c: Fix includes.
1244         * compile/compile-cplus-types.c: Fix includes.
1245         * cli/cli-interp.c: Fix includes.
1246
1247 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1248
1249         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1250         for padding.
1251
1252 2019-01-16  Tom Tromey  <tom@tromey.com>
1253
1254         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1255         earlier.
1256         (struct objfile) <msymbols_range>: Move from top level.
1257         <msymbols>: New method.
1258         (class objfile_msymbols): Remove.
1259         * symtab.c (default_collect_symbol_completion_matches_break_on):
1260         Update.
1261         * symmisc.c (dump_msymbols): Update.
1262         * stabsread.c (scan_file_globals): Update.
1263         * objc-lang.c (info_selectors_command, info_classes_command)
1264         (find_methods): Update.
1265         * minsyms.c (find_solib_trampoline_target): Update.
1266         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1267         * coffread.c (coff_symfile_read): Update.
1268         * ada-lang.c (ada_lookup_simple_minsym)
1269         (ada_collect_symbol_completion_matches): Update.
1270
1271 2019-01-16  Tom Tromey  <tom@tromey.com>
1272
1273         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1274         type.  Remove no-argument constructor.
1275         <iterator::operator++>: Simplify.
1276         <begin>: Update.
1277         <end>: Use minimal_symbol_count.
1278
1279 2019-01-16  Tom Tromey  <tom@tromey.com>
1280
1281         * objfiles.h (struct objfile) <psymtabs>: New method.
1282         (class objfile_psymtabs): Remove.
1283         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1284         typedef.
1285         <range>: New method.
1286         (require_partial_symbols): Change return type.
1287         * psymtab.c (require_partial_symbols)
1288         (psym_expand_symtabs_matching): Update.
1289         * mdebugread.c (parse_partial_symbols): Update.
1290         * dbxread.c (dbx_end_psymtab): Update.
1291
1292 2019-01-15  Tom Tromey  <tom@tromey.com>
1293
1294         * symtab.c (lookup_objfile_from_block)
1295         (lookup_symbol_in_objfile_symtabs)
1296         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1297         (find_line_symtab, info_sources_command)
1298         (default_collect_symbol_completion_matches_break_on)
1299         (make_source_files_completion_list): Update.
1300         * symmisc.c (print_objfile_statistics, dump_objfile)
1301         (maintenance_print_symbols, maintenance_info_symtabs)
1302         (maintenance_check_symtabs, maintenance_info_line_tables):
1303         Update.
1304         * source.c (select_source_symtab)
1305         (forget_cached_source_info_for_objfile): Update.
1306         * objfiles.h (class objfile_compunits): Remove.
1307         (struct objfile) <compunits_range>: New typedef.
1308         (compunits): New method.
1309         * objfiles.c (objfile_relocate1): Update.
1310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1311         * maint.c (count_symtabs_and_blocks): Update.
1312         * linespec.c (iterate_over_all_matching_symtabs): Update.
1313         * cp-support.c (add_symbol_overload_list_qualified): Update.
1314         * coffread.c (coff_symtab_read): Update.
1315         * ada-lang.c (add_nonlocal_symbols)
1316         (ada_collect_symbol_completion_matches)
1317         (ada_add_global_exceptions): Update.
1318
1319 2019-01-15  Tom Tromey  <tom@tromey.com>
1320
1321         * progspace.h (program_space) <objfiles_safe_range>: New
1322         typedef.
1323         <objfiles_safe>: New method.
1324         * objfiles.h (class all_objfiles_safe): Remove.
1325         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1326         * jit.c (jit_inferior_exit_hook): Update.
1327
1328 2019-01-17  Tom Tromey  <tom@tromey.com>
1329
1330         * progspace.h (program_space) <objfiles_range>: New typedef.
1331         <objfiles>: New method.
1332         <objfiles_head>: Rename from objfiles.
1333         (object_files): Update.
1334         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1335         * guile/scm-pretty-print.c
1336         (ppscm_find_pretty_printer_from_objfiles): Update.
1337         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1338         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1339         Update.
1340         * python/py-progspace.c (pspy_get_objfiles): Update.
1341         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1342         Update.
1343         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1344         (objfpy_lookup_objfile_by_build_id): Update.
1345         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1346         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1347         Update.
1348         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1349         (expand_symtab_containing_pc, lookup_objfile_from_block)
1350         (lookup_static_symbol, basic_lookup_transparent_type)
1351         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1352         (find_line_symtab, info_sources_command)
1353         (default_collect_symbol_completion_matches_break_on)
1354         (make_source_files_completion_list, find_main_name): Update.
1355         * symmisc.c (print_symbol_bcache_statistics)
1356         (print_objfile_statistics, maintenance_print_symbols)
1357         (maintenance_print_msymbols, maintenance_print_objfiles)
1358         (maintenance_info_symtabs, maintenance_check_symtabs)
1359         (maintenance_expand_symtabs, maintenance_info_line_tables):
1360         Update.
1361         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1362         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1363         (map_overlay_command, unmap_overlay_command)
1364         (simple_overlay_update, expand_symtabs_matching)
1365         (map_symbol_filenames): Update.
1366         * symfile-debug.c (set_debug_symfile): Update.
1367         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1368         Update.
1369         * source.c (select_source_symtab, forget_cached_source_info):
1370         Update.
1371         * solib.c (solib_read_symbols): Update.
1372         * solib-spu.c (append_ocl_sos): Update.
1373         * psymtab.c (maintenance_print_psymbols)
1374         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1375         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1376         * printcmd.c (info_symbol_command): Update.
1377         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1378         Update.
1379         * objfiles.h (class all_objfiles): Remove.
1380         * objfiles.c (have_partial_symbols, have_full_symbols)
1381         (have_minimal_symbols, qsort_cmp, update_section_map)
1382         (shared_objfile_contains_address_p)
1383         (default_iterate_over_objfiles_in_search_order): Update.
1384         * objc-lang.c (info_selectors_command, info_classes_command)
1385         (find_methods): Update.
1386         * minsyms.c (find_solib_trampoline_target): Update.
1387         * maint.c (maintenance_info_sections)
1388         (maintenance_translate_address, count_symtabs_and_blocks):
1389         Update.
1390         * main.c (captured_main_1): Update.
1391         * linux-thread-db.c (try_thread_db_load_from_pdir)
1392         (has_libpthread): Update.
1393         * linespec.c (iterate_over_all_matching_symtabs)
1394         (search_minsyms_for_name): Update.
1395         * jit.c (jit_find_objf_with_entry_addr): Update.
1396         * hppa-tdep.c (find_unwind_entry)
1397         (hppa_lookup_stub_minimal_symbol): Update.
1398         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1399         Update.
1400         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1401         (elf_gnu_ifunc_resolve_by_got): Update.
1402         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1403         * dwarf-index-write.c (save_gdb_index_command): Update.
1404         * cp-support.c (add_symbol_overload_list_qualified): Update.
1405         * breakpoint.c (create_overlay_event_breakpoint)
1406         (create_longjmp_master_breakpoint)
1407         (create_std_terminate_master_breakpoint)
1408         (create_exception_master_breakpoint): Update.
1409         * blockframe.c (find_pc_partial_function): Update.
1410         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1411         (ada_collect_symbol_completion_matches)
1412         (ada_add_global_exceptions): Update.
1413
1414 2019-01-17  Tom Tromey  <tom@tromey.com>
1415
1416         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1417         declare VEC.
1418         (solib_target_parse_libraries): Change return type.
1419         (library_list_start_segment, library_list_start_section)
1420         (library_list_end_library, library_list_start_library); Update.
1421         (solib_target_free_library_list): Remove.
1422         (solib_target_parse_libraries): Remove cleanup.  Change return
1423         type.
1424         (solib_target_current_sos): Update.
1425
1426 2019-01-17  Tom Tromey  <tromey@bapiya>
1427
1428         * valprint.c: Replace "the the" with "the".
1429         * symtab.c: Replace "the the" with "the".
1430         * solib.c: Replace "the the" with "the".
1431         * solib-dsbt.c: Replace "the the" with "the".
1432         * linespec.c: Replace "the the" with "the".
1433         * dwarf2loc.h: Replace "the the" with "the".
1434         * amd64-windows-tdep.c: Replace "the the" with "the".
1435         * aarch64-tdep.c: Replace "the the" with "the".
1436
1437 2019-01-16  Keith Seitz  <keiths@redhat.com>
1438
1439         PR gdb/23773
1440         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1441         <builder>: Rename to ..
1442         <m_builder>: ... this and make private.
1443         (dwarf2_cu::get_builder): New method.  Change all users of
1444         `builder' to use this method.
1445         (dwarf2_start_symtab): Move to ...
1446         (dwarf2_cu::start_symtab): ... here.  Update all callers
1447         (setup_type_unit_groups): Move to ...
1448         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1449         callers.
1450         (dwarf2_cu::reset_builder): New method.
1451         (process_full_compunit, process_full_type_unit): Use
1452         dwarf2_cu::reset_builder.
1453         (follow_die_offset): Record the ancestor CU if it is different
1454         from the followed DIE's CU.
1455         (follow_die_sig_1): Likewise.
1456
1457 2019-01-15  Tom Tromey  <tom@tromey.com>
1458
1459         * remote.c (class remote_state) <buf>: Now a char_vector.
1460         <buf_size>: Remove.
1461         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1462         parameter.
1463         (remote_target::getpkt_or_notif_sane_1)
1464         (remote_target::getpkt_sane)
1465         (remote_target::getpkt_or_notif_sane): Likewise.
1466         (class remote_target) <putpkt>: New overload.
1467         (remote_target::read_frame): Change type of "buf_p".  Remove
1468         sizeof_p parameter.
1469         (packet_ok): New overload.
1470         (packet_check_result): New overload.
1471         Update all uses.
1472
1473 2019-01-14  Tom Tromey  <tom@tromey.com>
1474
1475         * remote-notif.c (handle_notification, remote_notif_ack)
1476         (remote_notif_parse): Make "buf" const.
1477         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1478         const.
1479         (remote_notif_parse, remote_notif_ack, handle_notification):
1480         Likewise.
1481         * remote.c (remote_notif_stop_parse): Make "buf" const.
1482         (remote_target::remote_parse_stop_reply): Make "buf" const.
1483         (remote_notif_stop_ack): Make "buf" const.
1484
1485 2019-01-14  Tom Tromey  <tom@tromey.com>
1486
1487         * remote.c (remote_console_output): Make parameter const.
1488
1489 2019-01-14  Tom Tromey  <tom@tromey.com>
1490
1491         * target-debug.h (target_debug_print_signals): Constify.
1492         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1493         * procfs.c (procfs_target::pass_signals): Update.
1494         * linux-nat.c (linux_nat_target::pass_signals): Update.
1495         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1496         * target-delegates.c: Rebuild.
1497         * remote.c (remote_target::program_signals): Update.
1498         (remote_target::pass_signals): Update.
1499         * target.c (target_pass_signals): Constify argument.
1500         (target_program_signals): Likewise.
1501         * target.h (struct target_ops) <pass_signals, program_signals>:
1502         Constify argument.
1503         (target_pass_signals, target_program_signals): Constify argument.
1504
1505 2019-01-14  Tom Tromey  <tom@tromey.com>
1506
1507         PR tui/28819:
1508         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1509
1510 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1511
1512         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1513         field.
1514         * rs6000-tdep.c: Include reggroups.h.
1515         (IS_V_ALIAS_PSEUDOREG): Define.
1516         (rs6000_register_name): Return names for the "vX" aliases.
1517         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1518         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1519         aliases.  Call default_register_reggroup_p for all other
1520         pseudo-registers.
1521         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1522         New functions.
1523         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1524         Handle "vX" aliases.
1525         (v_alias_pseudo_register_collect): New function.
1526         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1527         (rs6000_gdbarch_init): Initialize "vX" aliases as
1528         pseudo-registers.  Restore registration of
1529         rs6000_pseudo_register_reggroup_p with
1530         set_tdesc_pseudo_register_reggroup_p.
1531
1532 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1533
1534         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1535         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1536         set_gdbarch_num_pseudo_regs.
1537
1538 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1539
1540         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1541         Remove arg prefixname, add do_set and do_show.
1542         Add member functions set_list and show_list.
1543         * cli/cli-style.c (class cli_style_option): Update accordingly.
1544         (style_set_list): Move to file scope.
1545         (style_show_list): Likewise.
1546         (set_style): Call help_list.
1547         (show_style): Call cmd_show_list.
1548         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1549         Update to use the new macro.
1550
1551 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1552
1553         * ada-lang.c (_initialize_ada_language): Expand the help text
1554         for the "catch exception" command.
1555
1556 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1557
1558         * symtab.c (matching_obj_sections): Initialize obj,
1559         declare it closer to its usage.
1560
1561 2019-01-10  Tom Tromey  <tom@tromey.com>
1562
1563         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1564         (basic_inf_threads_range): Remove.
1565         (inf_threads_range, inf_non_exited_threads_range)
1566         (safe_inf_threads_range): Use next_adapter.
1567
1568 2019-01-10  Keith Seitz  <keiths@redhat.com>
1569
1570         PR gdb/23712
1571         PR symtab/23010
1572         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1573         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1574
1575 2019-01-10  Keith Seitz  <keiths@redhat.com>
1576
1577         PR gdb/23712
1578         PR symtab/23010
1579         * dictionary.c (pending_to_vector): Remove.
1580         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1581         Remove _1 suffix, replacing functions of the same name.  Update
1582         all callers.
1583         (dict_create_hashed, dict_create_hashed_expandable)
1584         (dict_create_linear, dict_create_linear_expandable, dict_free)
1585         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1586         Make functions static.
1587
1588 2019-01-10  Keith Seitz  <keiths@redhat.com>
1589
1590         PR gdb/23712
1591         PR symtab/23010
1592         * dictionary.h (struct dictionary): Replace declaration with
1593         multidictionary.
1594         (dict_create_hashed, dict_create_hashed_expandable)
1595         (dict_create_linear, dict_create_linear_expandable)
1596         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1597         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1598         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1599         taking multidictionary argument.
1600         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1601         * block.h (struct block) <dict>: Change to multidictionary
1602         and rename `multidict'.
1603         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1604         symmisc.c: Update all dictionary references to multidictionary.
1605
1606 2019-01-10  Keith Seitz  <keiths@redhat.com>
1607
1608         PR gdb/23712
1609         PR symtab/23010
1610         * dictionary.c: Include unordered_map.
1611         (pending_to_vector): New function.
1612         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1613         Rewrite the non-"_1" functions to take vector instead
1614         of linked list.
1615         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1616         "new" _1 versions of the same name.
1617         (multidictionary): Define.
1618         (std::hash<enum language): New definition.
1619         (collate_pending_symbols_by_language, mdict_create_hashed)
1620         (mdict_create_hashed_expandable, mdict_create_linear)
1621         (mdict_create_linear_expandable, mdict_free)
1622         (find_language_dictionary, create_new_language_dictionary)
1623         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1624         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1625         (mdict_size, mdict_empty): New functions.
1626         * dictionary.h (mdict_iterator): Define.
1627
1628 2019-01-10  Pedro Alves  <palves@redhat.com>
1629
1630         * breakpoint.c (read_uploaded_action)
1631         (create_tracepoint_from_upload): Adjust to use
1632         gdb::unique_xmalloc_ptr.
1633         * ctf.c (ctf_write_uploaded_tp):
1634         (SET_ARRAY_FIELD): Use emplace_back.
1635         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1636         * tracefile-tfile.c (tfile_write_uploaded_tp):
1637         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1638         gdb::unique_xmalloc_ptr.
1639         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1640         at_string, cond_string, cmd_strings>: Replace char pointers
1641         with gdb::unique_xmalloc_ptr.
1642
1643 2019-01-10  Pedro Alves  <palves@redhat.com>
1644
1645         * solib-target.c (library_list_start_library): Don't xstrdup name.
1646
1647 2019-01-10  Pedro Alves  <palves@redhat.com>
1648
1649         * mdebugread.c (parse_partial_symbols): Use
1650         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1651
1652 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * linux-fork.c (scoped_switch_fork_info)
1655         <~scoped_switch_fork_info>: Fix incorrect variable name.
1656
1657 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1658
1659         * linux-fork.c (scoped_switch_fork_info)
1660         <scoped_switch_fork_info>: Make explicit.
1661         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1662
1663 2019-01-10  Tom Tromey  <tom@tromey.com>
1664
1665         * objfiles.h (objfile::reset_psymtabs): Update.
1666         * objfiles.c (objfile::objfile): Update.
1667         * psymtab.h (psymtab_storage::obstack): Update.
1668         (psymtab_storage::m_obstack): Use gdb::optional.
1669         (class psymtab_storage): Update comment.  Remove objfile
1670         parameter.
1671         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1672
1673 2019-01-10  Tom Tromey  <tom@tromey.com>
1674
1675         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1676         <free_psymtabs>: Now private.
1677         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1678         (allocate_psymtab): Use new method.
1679
1680 2019-01-10  Tom Tromey  <tom@tromey.com>
1681
1682         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1683         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1684         * mdebugread.c (parse_partial_symbols): Use
1685         allocate_dependencies.
1686         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1687         allocate_dependencies.
1688         (process_psymtab_comp_unit_reader)
1689         (build_type_psymtab_dependencies): Likewise.
1690         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1691
1692 2019-01-10  Tom Tromey  <tom@tromey.com>
1693
1694         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1695         PSYMBOL_SET_LANGUAGE.
1696         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1697
1698 2019-01-10  Tom Tromey  <tom@tromey.com>
1699
1700         * psymtab.h (psymtab_storage::obstack): New method.
1701         <m_obstack>: Rename from obstack; now private.
1702         * psymtab.c (psymtab_storage): Update.
1703         * dwarf2read.c (create_addrmap_from_index)
1704         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1705         Update.
1706
1707 2019-01-10  Tom Tromey  <tom@tromey.com>
1708
1709         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1710         * objfiles.h (objfile::reset_psymtabs): New method.
1711
1712 2019-01-10  Tom Tromey  <tom@tromey.com>
1713
1714         * symmisc.c (print_symbol_bcache_statistics): Update.
1715         (print_objfile_statistics): Update.
1716         * symfile.c (reread_symbols): Update.
1717         * psymtab.h (class psymtab_storage): New.
1718         * psymtab.c (psymtab_storage): New constructor.
1719         (~psymtab_storage): New destructor.
1720         (require_partial_symbols): Update.
1721         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1722         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1723         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1724         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1725         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1726         (start_psymtab_common, end_psymtab_common)
1727         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1728         (allocate_psymtab): Update.
1729         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1730         Update.
1731         (dump_psymtab_addrmap, maintenance_print_psymbols)
1732         (maintenance_check_psymtabs): Update.
1733         (class objfile_psymtabs): Move to objfiles.h.
1734         * psympriv.h (discard_psymtab): Now inline.
1735         (psymtab_discarder::psymtab_discarder): Update.
1736         (psymtab_discarder::~psymtab_discarder): Update.
1737         (ALL_OBJFILE_PSYMTABS): Rewrite.
1738         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1739         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1740         Remove fields.
1741         <partial_symtabs>: New field.
1742         (class objfile_psymtabs): Move from psymtab.h.  Update.
1743         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1744         psymbol_cache.
1745         (objfile::~objfile): Don't destroy psymbol_cache.
1746         * mdebugread.c (parse_partial_symbols): Update.
1747         * dwarf2read.c (create_addrmap_from_index)
1748         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1749         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1750         (add_partial_subprogram, dwarf2_ranges_read): Update.
1751         * dwarf-index-write.c (write_address_map)
1752         (write_one_signatured_type, recursively_write_psymbols)
1753         (class debug_names, class debug_names, write_psymtabs_to_index):
1754         Update.
1755
1756 2019-01-10  Tom Tromey  <tom@tromey.com>
1757
1758         * symtab.h (SYMBOL_SET_NAMES): Update.
1759         (symbol_set_names): Update.
1760         (MSYMBOL_SET_NAMES): Update.
1761         * symtab.c (symbol_set_names): Change argument to be an
1762         objfile_per_bfd_storage.
1763         * psymtab.c (add_psymbol_to_bcache): Update.
1764         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1765
1766 2019-01-10  Tom Tromey  <tom@tromey.com>
1767
1768         * symtab.c (create_demangled_names_hash): Change argument to be an
1769         objfile_per_bfd_storage.
1770         (symbol_set_names): Update.
1771
1772 2019-01-10  Tom Tromey  <tom@tromey.com>
1773
1774         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1775         init_psymbol_list.
1776         * psymtab.c (init_psymbol_list): Do nothing if already called.
1777         * psympriv.h (init_psymbol_list): Add comment.
1778         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1779         init_psymbol_list.
1780         * dbxread.c (dbx_symfile_read): Unconditionally call
1781         init_psymbol_list.
1782
1783 2019-01-10  Tom Tromey  <tom@tromey.com>
1784
1785         * xcoffread.c (scan_xcoff_symtab): Update.
1786         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1787         "where".
1788         * mdebugread.c (parse_partial_symbols)
1789         (handle_psymbol_enumerators): Update.
1790         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1791         * dbxread.c (read_dbx_symtab): Update.
1792         * psympriv.h (psymbol_placement): New enum.
1793         (add_psymbol_to_list): Update.
1794
1795 2019-01-10  Tom Tromey  <tom@tromey.com>
1796
1797         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1798         static_psymbols parameters.
1799         (scan_xcoff_symtab): Update.
1800         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1801         static_psymbols parameters.
1802         * psympriv.h (start_psymtab_common): Update.
1803         * mdebugread.c (parse_partial_symbols): Update.
1804         * dwarf2read.c (create_partial_symtab): Update.
1805         * dbxread.c (read_dbx_symtab): Update.
1806         (start_psymtab): Remove global_psymbols and static_psymbols
1807         parameters.
1808
1809 2019-01-10  Tom Tromey  <tom@tromey.com>
1810
1811         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1812         * psymtab.c (allocate_psymtab): Add comment.
1813         * psympriv.h (allocate_psymtab): Add comment.
1814         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1815         initializations.
1816         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1817
1818 2019-01-10  Tom Tromey  <tom@tromey.com>
1819
1820         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1821         Don't declare.
1822         * mipsread.c: Include mdebugread.h.
1823         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1824         Declare.
1825         * elfread.c: Include mdebugread.h.
1826
1827 2019-01-09  Tom Tromey  <tom@tromey.com>
1828
1829         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1830         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1831         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1832         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1833         (psym_lookup_symbol, psym_find_last_source_symtab)
1834         (psym_forget_cached_source_info, psym_print_stats)
1835         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1836         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1837         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1838         (psym_find_compunit_symtab_by_address)
1839         (maintenance_print_psymbols, maintenance_info_psymtabs)
1840         (maintenance_check_psymtabs): Use ranged for.
1841         * psymtab.h (class objfile_psymtabs): New.
1842         (require_partial_symbols): Return objfile_psymtabs.
1843         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1844
1845 2019-01-09  Tom Tromey  <tom@tromey.com>
1846
1847         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1848         (find_pc_mapped_section, list_overlays_command)
1849         (map_overlay_command, unmap_overlay_command)
1850         (simple_overlay_update): Use all_objfiles.
1851         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1852         * printcmd.c (info_symbol_command): Use all_objfiles.
1853         * objfiles.h (ALL_OBJSECTIONS): Remove.
1854         * maint.c (maintenance_translate_address): Use all_objfiles.
1855         * gcore.c (gcore_create_callback): Use all_objfiles.
1856         (objfile_find_memory_regions): Likewise.
1857
1858 2019-01-09  Tom Tromey  <tom@tromey.com>
1859
1860         * symtab.c (find_line_symtab, info_sources_command)
1861         (make_source_files_completion_list): Use objfile_compunits.
1862         * source.c (select_source_symtab): Use objfile_compunits.
1863         * objfiles.h (struct objfile): Update comment.
1864         (ALL_OBJFILES): Remove.
1865         (ALL_FILETABS): Remove.
1866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1867         objfile_compunits.
1868
1869 2019-01-09  Tom Tromey  <tom@tromey.com>
1870
1871         * symmisc.c (print_objfile_statistics, dump_objfile)
1872         (maintenance_print_symbols): Use compunit_filetabs.
1873         * source.c (forget_cached_source_info_for_objfile): Use
1874         compunit_filetabs.
1875         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1876         (ALL_FILETABS): Use compunit_filetabs.
1877         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1878         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1879
1880 2019-01-09  Tom Tromey  <tom@tromey.com>
1881
1882         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1883         (compunit_filetabs): New.
1884         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1885         compunit_filetabs.
1886         (info_sources_command, make_source_files_completion_list): Remove
1887         declaration.
1888         * symmisc.c (print_objfile_statistics, dump_objfile)
1889         (maintenance_print_symbols): Remove declaration.
1890         (maintenance_info_symtabs): Use compunit_filetabs.
1891         (maintenance_info_line_tables): Likewise.
1892         * source.c (select_source_symtab): Change local variable name.
1893         (forget_cached_source_info_for_objfile): Remove declaration.
1894         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1895         * objfiles.c (objfile_relocate1): Remove declaration.
1896         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1897         declaration.
1898         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1899         * coffread.c (coff_symtab_read): Remove declaration.
1900         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1901         compunit_filetabs.
1902
1903 2019-01-09  Tom Tromey  <tom@tromey.com>
1904
1905         * symtab.c (lookup_objfile_from_block)
1906         (find_pc_sect_compunit_symtab, search_symbols)
1907         (default_collect_symbol_completion_matches_break_on): Use
1908         objfile_compunits.
1909         * objfiles.h (ALL_COMPUNITS): Remove.
1910         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1911         * cp-support.c (add_symbol_overload_list_qualified): Use
1912         objfile_compunits.
1913         * ada-lang.c (ada_collect_symbol_completion_matches)
1914         (ada_add_global_exceptions): Use objfile_compunits.
1915
1916 2019-01-09  Tom Tromey  <tom@tromey.com>
1917
1918         * source.c (select_source_symtab)
1919         (forget_cached_source_info_for_objfile): Remove declaration.
1920         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1921         declaration.
1922         * maint.c (count_symtabs_and_blocks): Remove declaration.
1923         * cp-support.c (add_symbol_overload_list_qualified): Remove
1924         declaration.
1925         * coffread.c (coff_symtab_read): Remove declaration.
1926         * symtab.c (lookup_symbol_in_objfile_symtabs)
1927         (basic_lookup_transparent_type_1): Use objfile_compunits.
1928         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1929         (info_sources_command, search_symbols)
1930         (default_collect_symbol_completion_matches_break_on)
1931         (make_source_files_completion_list): Remove declaration.
1932         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1933         (ada_collect_symbol_completion_matches)
1934         (ada_add_global_exceptions): Remove declaration.
1935         * linespec.c (iterate_over_all_matching_symtabs): Use
1936         objfile_compunits.
1937         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1938         (class objfile_compunits): New.
1939         (ALL_COMPUNITS): Use objfile_compunits.
1940         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1941         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1942         objfile_compunits.
1943         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1944
1945 2019-01-09  Tom Tromey  <tom@tromey.com>
1946
1947         * symtab.c (search_symbols)
1948         (default_collect_symbol_completion_matches_break_on): Use
1949         objfile_msymbols.
1950         * ada-lang.c (ada_lookup_simple_minsym)
1951         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1952         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1953         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1954         objfile_msymbols.
1955         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1956         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1957         * objc-lang.c (find_methods): Use objfile_msymbols.
1958         (info_selectors_command, info_classes_command): Likewise.
1959         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1960         * objfiles.h (class objfile_msymbols): New.
1961         (ALL_OBJFILE_MSYMBOLS): Remove.
1962         (ALL_MSYMBOLS): Remove.
1963
1964 2019-01-09  Tom Tromey  <tom@tromey.com>
1965
1966         * common/next-iterator.h (next_adapter): Add Iterator template
1967         parameter.
1968         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1969         (class all_objfiles_safe): New.
1970         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1971         * objfiles.c (put_objfile_before): Update comment.
1972         (add_separate_debug_objfile): Likewise.
1973         (free_all_objfiles): Use all_objfiles_safe.
1974         (objfile_purge_solibs): Likewise.
1975
1976 2019-01-09  Tom Tromey  <tom@tromey.com>
1977
1978         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1979         (expand_symtab_containing_pc, lookup_static_symbol)
1980         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1981         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1982         all_objfiles.
1983         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1984         * breakpoint.c (create_overlay_event_breakpoint)
1985         (create_longjmp_master_breakpoint)
1986         (create_std_terminate_master_breakpoint)
1987         (create_exception_master_breakpoint): Use all_objfiles.
1988         * linux-thread-db.c (try_thread_db_load_from_pdir)
1989         (has_libpthread): Use all_objfiles.
1990         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1991         * linespec.c (iterate_over_all_matching_symtabs)
1992         (search_minsyms_for_name): Use all_objfiles.
1993         * maint.c (maintenance_info_sections): Use all_objfiles.
1994         * main.c (captured_main_1): Use all_objfiles.
1995         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1996         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1997         * guile/scm-pretty-print.c
1998         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1999         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2000         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2001         (maintenance_print_msymbols): Use all_objfiles.
2002         * source.c (select_source_symtab): Use all_objfiles.
2003         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2004         * symfile.c (remove_symbol_file_command)
2005         (expand_symtabs_matching, map_symbol_filenames): Use
2006         all_objfiles.
2007         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2008         all_objfiles.
2009         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2010         * objc-lang.c (find_methods): Use all_objfiles.
2011         * objfiles.c (have_partial_symbols, have_full_symbols)
2012         (have_minimal_symbols, qsort_cmp)
2013         (default_iterate_over_objfiles_in_search_order): Use
2014         all_objfiles.
2015         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2016         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2017         (maintenance_check_psymtabs): Use all_objfiles.
2018         (ALL_PSYMTABS): Remove.
2019         * compile/compile-object-run.c (do_module_cleanup): Use
2020         all_objfiles.
2021         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2022         * cp-support.c (add_symbol_overload_list_qualified): Use
2023         all_objfiles.
2024         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2025         Use all_objfiles.
2026         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2027         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2028         all_objfiles.
2029         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2030         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2031         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2032         Uses all_objfiles.
2033         * solib.c (solib_read_symbols): Use all_objfiles
2034
2035 2019-01-09  Tom Tromey  <tom@tromey.com>
2036
2037         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2038         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2039         all_objfiles.
2040         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2041         * symmisc.c (print_symbol_bcache_statistics)
2042         (print_objfile_statistics, maintenance_print_objfiles)
2043         (maintenance_info_symtabs, maintenance_check_symtabs)
2044         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2045         all_objfiles.
2046         * source.c (forget_cached_source_info): Use all_objfiles.
2047         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2048         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2049         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2050         * objfiles.c (update_section_map): Use all_objfiles.
2051         (shared_objfile_contains_address_p): Likewise.
2052         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2053         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2054
2055 2019-01-09  Tom Tromey  <tom@tromey.com>
2056
2057         * common/next-iterator.h: New file.
2058         * objfiles.h (class all_objfiles): New.
2059         (struct objfile_iterator): New.
2060
2061 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2062
2063         * NEWS: Move the description of the changed "frame", "select-frame",
2064          and "info frame" commands to the Changed commands section.
2065
2066 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2067
2068         * gdbtypes.c (check_stub_method_group): Remove handling of old
2069         mangling schemes.
2070         * linespec.c (find_methods): Likewise.
2071         * stabsread.c (read_member_functions): Likewise.
2072         * valops.c (search_struct_method): Likewise.
2073         (value_struct_elt_for_reference): Likewise.
2074         * NEWS: Mention this change.
2075
2076 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2077
2078         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2079         print_source_lines.
2080         * source.c (print_source_lines_base): Update line number check.
2081         (print_source_lines): New function.
2082         (source_lines_range::source_lines_range): New function.
2083         * source.h (class source_lines_range): New class.
2084         (print_source_lines): New declaration.
2085
2086 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2087
2088         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2089
2090 2019-01-08  Tom Tromey  <tom@tromey.com>
2091             Simon Marchi  <simon.marchi@ericsson.com>
2092
2093         PR gdb/24060
2094         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2095         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2096         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2097         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2098         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2099         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2100
2101 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * source.c (select_source_symtab): Move header comment to
2104         declaration in source.h.
2105         (forget_cached_source_info_for_objfile): Likewise.
2106         (forget_cached_source_info): Likewise.
2107         (identify_source_line): Likewise.
2108         * source.h (identify_source_line): Move declaration from symtab.h
2109         and add comment from source.c
2110         (print_source_lines): Likewise.
2111         (forget_cached_source_info_for_objfile): Likewise.
2112         (forget_cached_source_info): Likewise.
2113         (select_source_symtab): Likewise.
2114         (enum print_source_lines_flag): Move definition from symtab.h.
2115         * symtab.h (identify_source_line): Move declaration to source.h.
2116         (print_source_lines): Likewise.
2117         (forget_cached_source_info_for_objfile): Likewise.
2118         (forget_cached_source_info): Likewise.
2119         (select_source_symtab): Likewise.
2120         (enum print_source_lines_flag): Move definition to source.h.
2121         * tui/tui-hooks.c: Add 'source.h' include.
2122
2123 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * source.c (print_source_lines_base): Handle requests to print
2126         reverse line number sequences, and guard against empty lines
2127         string.
2128
2129 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * source.c (print_source_lines_base): Fix skip of '\r' if next
2132         character is '\n'.
2133
2134 2019-01-06  Tom Tromey  <tom@tromey.com>
2135
2136         * c-exp.y (struct c_parse_state) <macro_original_text,
2137         expansion_obstack>: New member.
2138         (macro_original_text, expansion_obstack): Remove globals.
2139         (scan_macro_expansion, scanning_macro_expansion)
2140         (finished_macro_expansion): Update.
2141         (scan_macro_cleanup): Remove.
2142         (yylex, c_parse): Update.
2143
2144 2019-01-06  Tom Tromey  <tom@tromey.com>
2145
2146         * c-exp.y (struct c_parse_state) <strings>: New member.
2147         (operator_stoken): Update.
2148
2149 2019-01-06  Tom Tromey  <tom@tromey.com>
2150
2151         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2152         (union type_stack_elt) <typelist_val>: Now a pointer to
2153         std::vector.
2154         (type_stack_cleanup): Don't declare.
2155         (push_typelist): Update.
2156         * parse.c (pop_typelist): Return a std::vector.
2157         (push_typelist): Take a std::vector.
2158         (follow_types): Update.  Do not free args.
2159         (type_stack_cleanup): Remove.
2160         * c-exp.y (struct c_parse_state): New.
2161         (cpstate): New global.
2162         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2163         (nonempty_typelist): Update.
2164         (func_mod): Create a new vector.
2165         (c_parse): Create a c_parse_state.
2166         (check_parameter_typelist): Do not delete params.
2167         (function_method): Update.  Do not delete type_list.
2168
2169 2019-01-06  Tom Tromey  <tom@tromey.com>
2170
2171         PR gdb/28155:
2172         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2173         check_typedef.
2174         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2175         (print_return_value): Likewise.
2176
2177 2019-01-05  Tom Tromey  <tom@tromey.com>
2178
2179         * contrib/cleanup_check.py: Remove.
2180         * contrib/gcc-with-excheck: Remove.
2181         * contrib/exsummary.py: Remove.
2182         * contrib/excheck.py: Remove.
2183
2184 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2185
2186         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2187         NULL. Initialize tpprev to NULL instead of assigning it
2188         to NULL on the next statement.
2189         * windows-nat.c (windows_delete_thread): Remove check for
2190         main_thread_id before printing thread exit notifications.
2191         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2192         Remove thread ID check against main_thread_id.
2193         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2194         windows_delete_thread.
2195         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2196
2197 2019-01-04  Tom Tromey  <tom@tromey.com>
2198
2199         * compile/compile.c (_initialize_compile): Use upper case for
2200         metasyntactic variables.
2201         * symmisc.c (_initialize_symmisc): Use upper case for
2202         metasyntactic variables.
2203         * psymtab.c (_initialize_psymtab): Use upper case for
2204         metasyntactic variables.
2205         * demangle.c (demangle_command): Use upper case for metasyntactic
2206         variables.
2207         (_initialize_demangler): Likewise.
2208         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2209         variables.
2210
2211 2019-01-03  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2214
2215 2019-01-03  Tom Tromey  <tom@tromey.com>
2216
2217         * python/py-symtab.c (salpy_str): Update.
2218         (struct salpy_sal_object) <symtab>: Now a PyObject.
2219         (salpy_dealloc): Update.
2220         (del_objfile_sal): Use gdbpy_ref.
2221
2222 2019-01-03  Tom Tromey  <tom@tromey.com>
2223
2224         * python/py-type.c (convert_field): Use new_reference.  Return
2225         gdbpy_ref.
2226         (make_fielditem): Return gdbpy_ref.
2227         (typy_fields): Update.
2228         (typy_getitem): Update.
2229         (field_name): Return gdbpy_ref.  Use new_reference.
2230         (typy_iterator_iternext): Update.
2231
2232 2019-01-03  Tom Tromey  <tom@tromey.com>
2233
2234         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2235
2236 2019-01-03  Tom Tromey  <tom@tromey.com>
2237
2238         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2239         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2240         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2241         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2242         (pspy_set_type_printers): Likewise.
2243         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2244         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2245         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2246         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2247         (objfpy_set_type_printers): Likewise.
2248
2249 2019-01-03  Tom Tromey  <tom@tromey.com>
2250
2251         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2252         (gdbpy_print_stack): Use gdbpy_err_fetch.
2253         * python/python-internal.h (class gdbpy_err_fetch): New class.
2254         (class gdbpy_enter) <m_error_type, m_error_value,
2255         m_error_traceback>: Remove.
2256         <m_error>: New member.
2257         (gdbpy_exception_to_string): Don't declare.
2258         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2259         * python/py-value.c (convert_value_from_python): Use
2260         gdbpy_err_fetch.
2261         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2262         gdbpy_exception_to_string.
2263         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2264         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2265         gdbpy_err_fetch.
2266
2267 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * linux-nat.c (delete_lwp_cleanup): Delete.
2270         (struct lwp_deleter): New struct.
2271         (lwp_info_up): New typedef.
2272         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2273         lwp_info_up.
2274
2275 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * linux-fork.c (class scoped_switch_fork_info): New class.
2278         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2279
2280 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * valops.c (find_overload_match): Remove use of null_cleanup, and
2283         calls to do_cleanups.
2284
2285 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * compile/compile-cplus-types.c
2288         (compile_cplus_instance::decl_name): Handle changes to
2289         cp_func_name.
2290         * cp-support.c (cp_func_name): Update header comment, update
2291         return type.
2292         * cp-support.h (cp_func_name): Update return type in declaration.
2293         * valops.c (find_overload_match): Move temp_func local to top
2294         level of function and change its type.  Use temp_func to hold and
2295         delete temporary string obtained from cp_func_name.
2296
2297 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2300         gdb::char_vector, remove cleanup, and update uses of `msg`.
2301
2302 2019-01-03  Jim Wilson  <jimw@sifive.com>
2303
2304         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2305
2306 2019-01-02  Tom Tromey  <tom@tromey.com>
2307
2308         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2309         (tdesc_parse_xml): Remove cleanups.
2310         * target-descriptions.h (make_cleanup_free_target_description):
2311         Don't declare.
2312         (target_desc_deleter): New struct.
2313         (target_desc_up): New typedef.
2314         * target-descriptions.c (target_desc_deleter::operator()): Rename
2315         from free_target_description.
2316         (make_cleanup_free_target_description): Remove.
2317
2318 2019-01-02  Tom Tromey  <tom@tromey.com>
2319
2320         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2321         constructor, destructor.
2322         (linespec_parser): Remove typedef.
2323         (~linespec_parser): Rename from linespec_parser_delete.
2324         (linespec_lex_to_end, linespec_complete_label)
2325         (linespec_complete): Update.
2326         (decode_line_full): Remove cleanups.
2327         (decode_line_1): Update.
2328
2329 2019-01-02  Tom Tromey  <tom@tromey.com>
2330
2331         * python/python-internal.h (inferior_to_inferior_object): Change
2332         return type.
2333         * python/py-exitedevent.c (create_exited_event_object): Update.
2334         * python/py-inferior.c (inferior_to_inferior_object): Return
2335         gdbpy_ref.
2336         (python_new_inferior, python_inferior_deleted)
2337         (thread_to_thread_object, delete_thread_object)
2338         (build_inferior_list, gdbpy_selected_inferior): Update.
2339         * python/py-infthread.c (create_thread_object): Update.  Also fail
2340         if inferior_to_inferior_object fails.
2341
2342 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2343
2344         * inferior.h (class inferior) <displaced_step_state>: New field.
2345         * infrun.h (struct displaced_step_state): Move here from
2346         infrun.c.  Initialize fields, add constructor.
2347         <inf>: Remove field.
2348         <reset>: New method.
2349         * infrun.c (struct displaced_step_inferior_state): Move to
2350         infrun.h.
2351         (displaced_step_inferior_states): Remove.
2352         (get_displaced_stepping_state): Adust.
2353         (displaced_step_in_progress_any_inferior): Adjust.
2354         (displaced_step_in_progress_thread): Adjust.
2355         (displaced_step_in_progress): Adjust.
2356         (add_displaced_stepping_state): Remove.
2357         (get_displaced_step_closure_by_addr): Adjust.
2358         (remove_displaced_stepping_state): Remove.
2359         (infrun_inferior_exit): Call displaced_step_state.reset.
2360         (use_displaced_stepping): Don't check for NULL.
2361         (displaced_step_prepare_throw): Call
2362         get_displaced_stepping_state.
2363         (displaced_step_fixup): Don't check for NULL.
2364         (prepare_for_detach): Don't check for NULL.
2365
2366 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2367
2368         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2369          in case of call that did not complete.
2370
2371 2019-01-02  Andrey Utkin  <autkin@undo.io>
2372
2373         * symfile.c (find_separate_debug_file): Fix search of debug files for
2374         remote debuggee.
2375
2376 2019-01-02  Tom Tromey  <tom@tromey.com>
2377
2378         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2379         indentation.
2380         * python/py-frame.c (frapy_older): Remove cast.
2381         (frapy_newer): Likewise.
2382         * python/py-breakpoint.c (local_setattro): Remove cast.
2383         * python/py-arch.c (archpy_name): Remove local variable.
2384         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2385
2386 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2387
2388         * unittests/basic_string_view/element_access/char/empty.cc:
2389         Fix year range in copyright header.
2390
2391 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2392
2393         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2394         Delete.
2395         <operator==>: Update with for removed field.
2396         <hash>: Likewise.
2397         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2398         <isa_features>: ...this.
2399         <abi_features>: New field.
2400         (riscv_isa_flen): Update comment.
2401         (riscv_abi_xlen): New declaration.
2402         (riscv_abi_flen): New declaration.
2403         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2404         isa_features.
2405         (riscv_abi_xlen): New function.
2406         (riscv_isa_flen): Update to get answer from isa_features.
2407         (riscv_abi_flen): New function.
2408         (riscv_has_fp_abi): Update to get answer from abi_features.
2409         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2410         xlen and flen.
2411         (riscv_call_info) <xlen, flen>: Update comment.
2412         (riscv_call_arg_struct): Remove invalid assertions
2413         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2414         is removed.
2415         (riscv_gdbarch_init): Gather isa features and abi features
2416         separately, ensure both match on the gdbarch when reusing an old
2417         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2418         a target with 64-bit float hardware.
2419
2420 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2421
2422         * source.c (search_command_helper): Stop reverse search
2423         when line 1 has been searched.
2424
2425 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2426
2427         * record-full.c (record_full_base_target::close): Rewrite
2428         record_full_core_buf_list free logic.
2429
2430 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2431
2432         * break-catch-syscall.c (print_one_catch_syscall): xfree
2433         the last text.
2434
2435 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2436
2437         * top.c (print_gdb_version): Update Copyright year in version
2438         message.
2439
2440 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2441
2442         Update copyright year range in all GDB files.
2443
2444 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2445
2446         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2447
2448 For older changes see ChangeLog-2018.
2449 \f
2450 Local Variables:
2451 mode: change-log
2452 left-margin: 8
2453 fill-column: 74
2454 version-control: never
2455 coding: utf-8
2456 End:
2457