gdb: Remove unneeded parameter from set_breakpoint_location_function
[external/binutils.git] / gdb / ChangeLog
1 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * breakpoint.c (set_breakpoint_location_function): Remove
4         explicit_loc parameter.
5         (momentary_breakpoint_from_master): Update call to
6         set_breakpoint_location_function.
7         (add_location_to_breakpoint): Likewise.
8
9 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10
11         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
12         required features based on default bfd type when no specific bfd
13         is present.
14
15 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16
17         * NEWS: Mention that GDB printf and eval commands can now print
18         C-style and Ada-style convenience var strings without
19         calling the inferior.
20         * printcmd.c (printf_c_string): Locally print GDB internal var
21         instead of transiting via the inferior.
22         (printf_wide_c_string): Likewise.
23
24 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
25
26         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
27
28 2019-07-04  Tom Tromey  <tom@tromey.com>
29
30         PR tui/24724:
31         * tui/tui-winsource.c (tui_clear_source_content): Update.
32         (tui_source_window_base::set_is_exec_point_at): Fix comment.
33         (tui_update_breakpoint_info): Update.
34         (tui_set_exec_info_content): Update.
35         * tui/tui-source.c (tui_set_source_content_nil): Update.
36         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
37         has_break.
38         * tui/tui-data.h (enum tui_bp_flag): New.
39         (tui_bp_flags): New enum flags type.
40         (struct tui_source_element) <break_mode>: Change type.  Rename
41         from has_break.
42         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
43         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
44         constants.
45         * tui/tui-winsource.h: Fix comment.
46
47 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
48
49         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
50         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
51         (store_fpregs_to_thread)
52         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
53         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
54         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
55         (IWMMXT_REGS_SIZE): Add define.
56         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
57         (fetch_vfp_regs, store_vfp_regs)
58         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
59         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
60
61 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
62
63         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
64         defines.
65         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
66         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
67         (ARM_INT_REGISTER_SIZE): ...to this.
68         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
69         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
70         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
71         (arm_linux_collect_gregset, supply_nwfpe_register)
72         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
73         defines.
74         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
75         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
76         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
77         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
78         (arm_return_in_memory, arm_store_return_value)
79         (arm_get_longjmp_target, arm_register_g_packet_guesses)
80         (arm_record_ld_st_multiple): Likewise.
81         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
82         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
83
84 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
85
86         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
87         AARCH64_DISPLACED_MODIFIED_INSNS.
88         * aarch64-tdep.c (struct aarch64_displaced_step_data)
89         (aarch64_displaced_step_copy_insn): Likewise.
90         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
91         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
92         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
93         ARM_DISPLACED_MODIFIED_INSNS.
94         * arm-tdep.c (arm_gdbarch_init): Likewise.
95         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
96         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
97         (struct arm_displaced_step_closure): Use
98         ARM_DISPLACED_MODIFIED_INSNS.
99
100 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
101
102         * features/Makefile: Remove unused xml files.
103         * features/aarch64.xml: Remove.
104         * features/i386/amd64-avx-avx512-linux.xml: Remove.
105         * features/i386/amd64-avx-avx512.xml: Remove.
106         * features/i386/amd64-avx-linux.xml: Remove.
107         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
108         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
109         * features/i386/amd64-avx-mpx-linux.xml: Remove.
110         * features/i386/amd64-avx-mpx.xml: Remove.
111         * features/i386/amd64-avx.xml: Remove.
112         * features/i386/amd64-linux.xml: Remove.
113         * features/i386/amd64-mpx-linux.xml: Remove.
114         * features/i386/amd64-mpx.xml: Remove.
115         * features/i386/amd64.xml: Remove.
116         * features/i386/i386-avx-avx512-linux.xml: Remove.
117         * features/i386/i386-avx-avx512.xml: Remove.
118         * features/i386/i386-avx-linux.xml: Remove.
119         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
120         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
121         * features/i386/i386-avx-mpx-linux.xml: Remove.
122         * features/i386/i386-avx-mpx.xml: Remove.
123         * features/i386/i386-avx.xml: Remove.
124         * features/i386/i386-linux.xml: Remove.
125         * features/i386/i386-mmx-linux.xml: Remove.
126         * features/i386/i386-mmx.xml: Remove.
127         * features/i386/i386-mpx-linux.xml: Remove.
128         * features/i386/i386-mpx.xml: Remove.
129         * features/i386/i386.xml: Remove.
130         * features/i386/x32-avx-avx512-linux.xml: Remove.
131         * features/i386/x32-avx-linux.xml: Remove.
132         * features/i386/x32-linux.xml: Remove.
133
134 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
135
136         * regformats/aarch64.dat: Remove.
137         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
138         * regformats/i386/amd64-avx-linux.dat: Remove.
139         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
140         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
141         * regformats/i386/amd64-linux.dat: Remove.
142         * regformats/i386/amd64-mpx-linux.dat: Remove.
143         * regformats/i386/amd64.dat: Remove.
144         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
145         * regformats/i386/i386-avx-linux.dat: Remove.
146         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
147         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
148         * regformats/i386/i386-linux.dat: Remove.
149         * regformats/i386/i386-mmx-linux.dat: Remove.
150         * regformats/i386/i386-mpx-linux.dat: Remove.
151         * regformats/i386/i386.dat: Remove.
152         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
153         * regformats/i386/x32-avx-linux.dat: Remove.
154         * regformats/i386/x32-linux.dat: Remove.
155
156 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
157
158         * aarch64-tdep.c: Remove xml self tests.
159         * amd64-linux-tdep.c: Likewise.
160         * amd64-tdep.c: Likewise.
161         * i386-linux-tdep.c: Likewise.
162         * i386-tdep.c: Likewise.
163
164 2019-07-03  Pedro Alves  <palves@redhat.com>
165
166         PR cli/24732
167         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
168         (pipe_cmd_option_defs): New.
169         (make_pipe_cmd_options_def_group): New.
170         (pipe_command): Use gdb::option::process_options.
171         (pipe_command_completer): New function.
172         (_initialize_cli_cmds): Install completer for "pipe" command.
173
174 2019-07-03  Pedro Alves  <palves@redhat.com>
175
176         * cli/cli-option.c (union option_value) <string>: New field.
177         (struct option_def_and_value): Add ctor, move ctor, dtor and
178         use DISABLE_COPY_AND_ASSIGN.
179         (option_def_and_value::clear_value): New.
180         (parse_option, save_option_value_in_ctx, get_val_type_str)
181         (add_setshow_cmds_for_options): Handle var_string.
182         * cli-option.h (union option_def::var_address) <string>: New
183         field.
184         (struct string_option_def): New.
185         * maint-test-options.c (struct test_options_opts): Add default
186         ctor and use DISABLE_COPY_AND_ASSIGN.
187         <string_opt>: New field.
188         (test_options_opts::~test_options_opts): New.
189         (test_options_opts::dump): Also dump "-string".
190         (test_options_option_defs): Install "string.
191
192 2019-07-03  Pedro Alves  <palves@redhat.com>
193
194         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
195         option_value with a null enumeration.
196         (complete_options): Save the option values in the context.
197         (save_option_value_in_ctx): New, factored out from ...
198         (process_options): ... here.
199         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
200         of the function.
201         * maint-test-options.c (test_options_opts::dump): New, factored
202         out from ...
203         (maintenance_test_options_command_mode): ... here.
204         (maintenance_test_options_command_completion_result): Delete.
205         (maintenance_test_options_command_completion_text): Update
206         comment.
207         (maintenance_show_test_options_completion_result): Change
208         prototype.  Just print
209         maintenance_test_options_command_completion_text.
210         (save_completion_result): New.
211         (maintenance_test_options_completer_mode): Pass options context to
212         complete_options, and then save a dump.
213         (_initialize_maint_test_options): Use add_cmd to install "maint
214         show test-options-completion-result".
215
216 2019-07-03  Pedro Alves  <palves@redhat.com>
217
218         * NEWS (New commands): Mention "with" and "maint with".
219         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
220         (with_command, with_command_completer): New.
221         (pipe_command): Adjust to new repeat_previous
222         interface.
223         (_initialize_cli_cmds): Install the "with" command and its "w"
224         alias.
225         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
226         declarations.
227         * cli/cli-setshow.c (parse_cli_var_uinteger)
228         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
229         argument strings for all var_types.
230         (get_setshow_command_value_string): New, factored out from ...
231         (do_show_command): ... this.
232         * cli/cli-setshow.h: Include <string>.
233         (get_setshow_command_value_string): Declare.
234         * command.h (repeat_previous): Now returns const char *.  Adjust
235         comment.
236         * maint.c: Include "cli/cli-cmds.h".
237         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
238         (_initialize_maint_cmds): Register the "maintenance with" command.
239         * top.c (repeat_previous): Move bits from pipe_command here:
240         Return the saved command line, if any; error out if there's no
241         command to relaunch.
242
243 2019-07-03  Pedro Alves  <palves@redhat.com>
244
245         * NEWS (New commands): Mention "maint set/show test-settings"
246         instead of "maint test-settings".
247         * maint-test-settings.c (maintenance_test_settings_list): Delete.
248         (maintenance_test_settings_set_list): Rename to ...
249         (maintenance_set_test_settings_list): ... this.
250         (maintenance_test_settings_show_list): Rename to  ...
251         (maintenance_show_test_settings_list): ... this.
252         (maintenance_test_settings_cmd): Delete.
253         (maintenance_test_settings_set_cmd): ...
254         (maintenance_set_test_settings_cmd): ... this.
255         (maintenance_test_settings_show_cmd): ...
256         (maintenance_show_test_settings_cmd): ... this.
257         (maintenance_test_settings_show_value_cmd):
258         (maintenance_show_test_settings_value_cmd): ... this.
259         (_initialize_maint_test_settings): No longer install the "maint
260         test-settings" prefix command.  Rename "maint test-settings set"
261         to "maint set test-settings", and "maint test-settings show" to
262         "maint show test-settings".  Adjust all subcommands.
263
264 2019-07-03  Pedro Alves  <palves@redhat.com>
265
266         * maint-test-settings.c: Fix file's intro comment.  Replace all
267         references to "test-options" with references to "test-settings",
268         in comments.
269
270 2019-07-03  Pedro Alves  <palves@redhat.com>
271
272         * maint-test-settings.c (maintenance_test_settings_xxx)
273         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
274         New.
275         (maintenance_test_settings_enums): Use them.
276         (maintenance_test_settings_enum): Default to
277         maintenance_test_settings_xxx.
278         (_initialize_maint_test_settings): Initialize
279         MAINTENANCE_TEST_SETTINGS_FILENAME.
280
281 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
282
283         * breakpoint.h (remove_breakpoints_inf): Change return type to
284         void, move function documentation here.
285         * breakpoint.c (remove_breakpoints_inf): Change return type to
286         void, move function documentation to header.
287
288 2019-07-02  Pedro Alves  <palves@redhat.com>
289
290         * NEWS (Completion improvements): Mention "info threads".
291         * thread.c (struct info_threads_opts, info_threads_option_defs)
292         (make_info_threads_options_def_group): New.
293         (info_threads_command): Use gdb::option::process_options.
294         (info_threads_command_completer): New.
295         (_initialize_thread): Use gdb::option::build_help to build the
296         help text for "info threads".
297
298 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
299
300         * defs.h (generic_load): Move from here...
301         * symfile.h (generic_load): ... to here.  Rename name parameter
302         to args.
303         * symfile.c (generic_load): Add comment.
304
305 2019-07-01  Tom Tromey  <tromey@adacore.com>
306
307         * dwarf2read.c
308         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
309         declaration of without_params.  Fix formatting.
310
311 2019-07-01  Tom Tromey  <tromey@adacore.com>
312
313         * ada-exp.y (find_primitive_type): Update.
314         * ada-lang.h (ada_lookup_symbol): Update.
315         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
316         parameter.
317         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
318
319 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
320
321         PR breakpoints/24541
322         * gdbarch.c: Regenerate.
323         * gdbarch.h: Regenerate.
324         * gdbarch.sh: Add 'stap_adjust_register'.
325         * i386-tdep.c: Include '<unordered_set>'.
326         (i386_stap_adjust_register): New function.
327         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
328         * stap-probe.c (stap_parse_register_operand): Call
329         'gdbarch_stap_adjust_register'.
330
331 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
332
333         PR python/24742
334         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
335         * python/python.c (do_start_initialization): Use 'xmalloc'
336         instead of 'PyMem_Malloc'.
337
338 2019-06-28  Tom Tromey  <tromey@adacore.com>
339
340         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
341         for Ada.
342
343 2019-06-27  Tom Tromey  <tromey@adacore.com>
344
345         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
346         objfile_key.
347         (arm_find_mapping_symbol, arm_record_special_symbol)
348         (_initialize_arm_tdep): Update.
349         (arm_objfile_data_free): Remove.
350
351 2019-06-27  Tom Tromey  <tromey@adacore.com>
352
353         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
354         to cp_print_static_field.
355
356 2019-06-26  Tom Tromey  <tromey@adacore.com>
357
358         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
359         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
360         declare.
361
362 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
363
364         * features/aarch64-core.c (create_feature_aarch64_core):
365         Regenerate.
366         * features/aarch64-core.xml: Add cpsr flags.
367
368 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
369
370         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
371         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
372
373 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
374
375         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
376         field.
377         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
378         use.
379         (arm_record_special_symbol): Don't insert new symbol in sorted
380         position, push it at the end.
381
382 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
383
384         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
385         (arm_mapping_symbol_s): Remove.
386         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
387         (arm_mapping_symbol_vec): New typedef.
388         (struct arm_per_objfile): Add constructor.
389         <section_maps>: Change type to
390         std::unique_ptr<arm_mapping_symbol_vec[]>.
391         (arm_compare_mapping_symbols): Remove.
392         (arm_find_mapping_symbol): Adjust to section_maps type change.
393         (arm_objfile_data_free): Call delete on arm_per_objfile.
394         (arm_record_special_symbol): Adjust to section_maps type change.
395         Allocate arm_per_objfile with new.
396
397 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
398
399         * cli/cli-cmds.c (alias_command): Compare the alias prefix
400         with the command prefix.
401
402 2019-06-25  Tom Tromey  <tom@tromey.com>
403
404         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
405         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
406
407 2019-06-25  Tom Tromey  <tom@tromey.com>
408
409         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
410         type.
411         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
412         protected.
413
414 2019-06-25  Tom Tromey  <tom@tromey.com>
415
416         * tui/tui-winsource.c
417         (tui_source_window_base::set_is_exec_point_at): Add check against
418         LOA_ADDRESS.
419
420 2019-06-25  Tom Tromey  <tom@tromey.com>
421
422         * tui/tui-source.c (tui_set_source_content): Don't check before
423         xfree.
424         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
425
426 2019-06-25  Tom Tromey  <tom@tromey.com>
427
428         * tui/tui-winsource.h (tui_update_source_window_as_is)
429         (tui_alloc_source_buffer, tui_line_is_displayed)
430         (tui_addr_is_displayed): Change type of win_info.
431         * tui/tui-winsource.c (tui_update_source_window_as_is)
432         (tui_clear_source_content, tui_show_source_line)
433         (tui_show_source_content, tui_source_window_base::refill)
434         (tui_source_window_base::set_is_exec_point_at)
435         (tui_source_window_base::set_is_exec_point_at)
436         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
437         (tui_alloc_source_buffer, tui_line_is_displayed)
438         (tui_addr_is_displayed): Change type of win_info.  Update.
439         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
440         (tui_source_window_base::do_make_visible_with_new_height):
441         Update.
442         * tui/tui-source.c (tui_set_source_content)
443         (tui_set_source_content_nil)
444         (tui_source_window::do_scroll_vertical): Update.
445         * tui/tui-layout.c (show_layout): Update.
446         * tui/tui-disasm.c (tui_set_disassem_content)
447         (tui_disasm_window::do_scroll_vertical): Update.
448         * tui/tui-data.h (tui_win_content): Remove.
449         (struct tui_gen_win_info) <content, content_size>: Remove.
450         (struct tui_source_element): Add initializers and destructor.
451         (union tui_which_element, struct tui_win_element): Remove.
452         (struct tui_source_window_base) <content>: New field.
453         (struct tui_data_window): Remove destructor.
454         (tui_alloc_content, tui_free_win_content)
455         (tui_free_all_source_wins_content): Don't declare.
456         * tui/tui-data.c (tui_initialize_static_data): Update.
457         (init_content_element, tui_alloc_content): Remove.
458         (~tui_gen_win_info): Update.
459         (~tui_data_window, tui_free_all_source_wins_content)
460         (tui_free_win_content, free_content, free_content_elements):
461         Remove.
462
463 2019-06-25  Tom Tromey  <tom@tromey.com>
464
465         * tui/tui-winsource.h (tui_clear_source_content)
466         (tui_erase_source_content, tui_show_source_content): Change type
467         of win_info.
468         * tui/tui-winsource.c (tui_clear_source_content)
469         (tui_erase_source_content, tui_show_source_content): Change type
470         of win_info.
471         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
472         * tui/tui-source.h (tui_set_source_content_nil): Change type of
473         win_info.
474         * tui/tui-source.c (tui_set_source_content_nil): Change type of
475         win_info.
476         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
477
478 2019-06-25  Tom Tromey  <tom@tromey.com>
479
480         * tui/tui-winsource.c (tui_clear_source_content)
481         (tui_source_window_base::set_is_exec_point_at): Update.
482         * tui/tui-source.c (tui_set_source_content_nil): Update.
483         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
484         a bool.
485         * tui/tui-data.c (init_content_element): Update.
486
487 2019-06-25  Tom Tromey  <tom@tromey.com>
488
489         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
490         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
491         * tui/tui-layout.c (init_and_make_win): Update.
492         * tui/tui.h (enum tui_win_type): Update.
493         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
494         tui_win_is_auxillary.
495         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
496         tui_win_is_auxillary.
497
498 2019-06-25  Tom Tromey  <tom@tromey.com>
499
500         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
501         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
502         (tui_delete_data_content_windows, tui_display_all_data)
503         (tui_data_window::do_scroll_vertical, tui_display_data_from):
504         Update.
505         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
506         * tui/tui-regs.c (tui_last_regs_line_no)
507         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
508         (tui_show_registers): Update.
509         (tui_show_register_group): Return void.  Update.
510         (tui_display_registers_from, tui_display_reg_element_at_line)
511         (tui_display_registers_from_line, tui_check_register_values):
512         Update.
513         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
514         member.
515         (struct tui_data_window) <regs_content>: Now a std::vector.
516         <regs_content_count>: Remove.
517         (tui_add_content_elements, tui_free_data_content): Don't declare.
518         * tui/tui-data.c (tui_data_window::clear_detail): Update.
519         (init_content_element): Remove DATA_WIN case.  Add assert.
520         (tui_add_content_elements): Remove.
521         (tui_data_window): Update.
522         (tui_free_data_content): Remove.
523         (free_content_elements): Remove DATA_WIN case.
524
525 2019-06-25  Tom Tromey  <tom@tromey.com>
526
527         * tui/tui-data.c (tui_data_item_window): Update.
528         * tui/tui-windata.h (tui_check_data_values): Don't declare.
529         * tui/tui-windata.c (tui_display_all_data)
530         (tui_display_data_from_line): Update.
531         (tui_check_data_values): Remove.
532         * tui/tui-regs.c (tui_show_register_group)
533         (tui_display_reg_element_at_line): Update.
534         * tui/tui-hooks.c (tui_register_changed)
535         (tui_refresh_frame_and_register_information): Call
536         tui_check_register_values.
537         * tui/tui-data.h (struct tui_data_window) <data_content,
538         data_content_count, data_type>: Remove.
539         (enum tui_data_type): Remove.
540
541         * tui/tui-data.c (tui_data_window::clear_detail)
542         (~tui_data_window): Update.
543
544 2019-06-25  Tom Tromey  <tom@tromey.com>
545
546         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
547         declare.
548         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
549         Rename from tui_first_data_item_displayed.  Update.
550         (tui_data_window::refresh_all)
551         (tui_data_window::do_scroll_vertical): Update.
552         * tui/tui-data.h (struct tui_data_window)
553         <first_data_item_displayed>: Declare new method.
554
555 2019-06-25  Tom Tromey  <tom@tromey.com>
556
557         * tui/tui-data.h (tui_init_generic_part): Don't declare.
558         * tui/tui-data.c (tui_init_generic_part): Remove, moving
559         contents...
560         (tui_initialize_static_data): ...here.
561
562 2019-06-25  Tom Tromey  <tom@tromey.com>
563
564         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
565         (tui_display_registers_from, tui_check_register_values): Update.
566         (tui_display_register): Remove win_info parameter; update.
567         (tui_get_register): Change type of parameters.
568         * tui/tui-data.h (struct tui_data_element): Remove.
569         (union tui_which_element) <data>: Remove.
570         <data_window>: Change type.
571         (struct tui_data_item_window): New.
572         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
573         case.  Add assert.
574         (~tui_data_item_window): New destructor.
575         (free_content_elements): Remove DATA_ITEM_WIN case.
576
577 2019-06-25  Tom Tromey  <tom@tromey.com>
578
579         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
580         Remove.
581
582 2019-06-25  Tom Tromey  <tom@tromey.com>
583
584         * tui/tui-data.h (struct tui_command_element): Remove.
585         (union tui_which_element) <command>: Remove.
586         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
587         assert.
588         (free_content_elements): Remove CMD_WIN case.
589
590 2019-06-25  Tom Tromey  <tom@tromey.com>
591
592         * tui/tui-layout.c (tui_set_layout): Update.
593         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
594         * tui/tui-data.c (layout_def): Update.
595
596 2019-06-25  Tom Tromey  <tom@tromey.com>
597
598         * tui/tui-wingeneral.c (tui_refresh_all): Update.
599         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
600         (tui_source_window_base::set_new_height): Update.
601         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
602         Update.
603         (tui_set_locator_fullname, tui_set_locator_info)
604         (tui_show_frame_info): Update.
605         * tui/tui-source.c (tui_set_source_content)
606         (tui_source_is_displayed): Update.
607         * tui/tui-layout.c (show_source_disasm_command, show_data)
608         (show_source_or_disasm_and_command): Update.
609         * tui/tui-disasm.c (tui_set_disassem_content)
610         (tui_get_begin_asm_address): Update.
611         * tui/tui-data.h (struct tui_locator_element): Remove.
612         (union tui_which_element) <locator>: Remove.
613         (struct tui_locator_window): New.
614         (tui_locator_win_info_ptr): Change return type.
615         * tui/tui-data.c (_locator): Change type.
616         (tui_locator_win_info_ptr): Change return type.
617         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
618         (tui_alloc_content): Add assert.
619
620 2019-06-25  Tom Tromey  <tom@tromey.com>
621
622         * tui/tui-winsource.c
623         (tui_exec_info_window::maybe_allocate_content): New method.
624         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
625         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
626         (make_source_or_disasm_window): Add cast.
627         * tui/tui-data.h (union tui_which_element) <simple_string>:
628         Remove.
629         (struct tui_source_info): New.
630         (struct tui_source_window_base) <execution_info>: Change type.
631         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
632         case, and add assert.
633         (tui_alloc_content): Add assert.
634
635 2019-06-25  Tom Tromey  <tom@tromey.com>
636
637         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
638         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
639         * tui/tui-data.c (tui_alloc_win_info): Remove.
640
641 2019-06-25  Tom Tromey  <tom@tromey.com>
642
643         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
644         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
645         can_highlight.
646
647 2019-06-25  Tom Tromey  <tom@tromey.com>
648
649         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
650         make_visible_with_new_height method.
651         (tui_win_info::make_visible_with_new_height): New method.
652         (tui_source_window_base::do_make_visible_with_new_height)
653         (tui_data_window::do_make_visible_with_new_height)
654         (tui_cmd_window::do_make_visible_with_new_height): New methods.
655         (make_visible_with_new_height): Remove.
656         (tui_resize_all, tui_adjust_win_heights): Use
657         make_visible_with_new_height method.
658         * tui/tui-data.h (struct tui_win_info)
659         <do_make_visible_with_new_height, make_visible_with_new_height>:
660         New methods.
661         (struct tui_source_window_base, struct tui_data_window)
662         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
663         methods.
664
665 2019-06-25  Tom Tromey  <tom@tromey.com>
666
667         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
668         method.
669         (update_tab_width): Call update_tab_width method.
670         * tui/tui-data.h (struct tui_win_info)
671         (struct tui_source_window_base) <update_tab_width>: New methods.
672
673 2019-06-25  Tom Tromey  <tom@tromey.com>
674
675         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
676         parameter.
677         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
678         parameter.
679         (tui_gen_win_info::make_visible): Update.
680         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
681         parameter.
682         * tui/tui-data.h (enum tui_box): New enum.
683         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
684
685 2019-06-25  Tom Tromey  <tom@tromey.com>
686
687         * tui/tui-layout.c (make_source_or_disasm_window): Always use
688         init_and_make_win for EXEC_INFO_WIN.
689         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
690         longer inline.
691         (struct tui_win_info) <~tui_win_info>: Inline.
692         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
693         Don't declare.
694         * tui/tui-data.c (source_win, disasm_win): Remove globals.
695         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
696         Remove.
697         (tui_initialize_static_data): Update.
698         (~tui_gen_win_info): Handle more cleanup here.
699         (~tui_source_window_base): Delete "execution_info".
700         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
701
702 2019-06-25  Tom Tromey  <tom@tromey.com>
703
704         * tui/tui-layout.c (make_command_window): Don't set
705         can_highlight.
706         (show_source_disasm_command): Call the reset method.
707         (show_data): Don't set can_highlight.  Call the reset method.
708         (tui_gen_win_info::reset): Rename from init_gen_win_info
709         (init_and_make_win): Simplify.  Return tui_gen_win_info.
710         (show_source_or_disasm_and_command): Call the reset method.
711         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
712         (struct tui_cmd_window): Set can_highlight.
713
714 2019-06-25  Tom Tromey  <tom@tromey.com>
715
716         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
717         from make_visible.
718         (tui_make_visible, tui_make_invisible): Rewrite.
719         (tui_win_info::make_visible): Remove.
720         (tui_source_window_base::make_visible): Update.
721         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
722         method.  Moved from...
723         (struct tui_win_info) <make_visible>: ...here.
724
725 2019-06-25  Tom Tromey  <tom@tromey.com>
726
727         * tui/tui-winsource.c
728         (tui_source_window_base::do_scroll_horizontal): Remove direction
729         parameter.
730         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
731         direction parameter.
732         * tui/tui-win.c (tui_win_info::forward_scroll)
733         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
734         (tui_win_info::right_scroll): Update.
735         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
736         direction parameter.
737         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
738         direction parameter.
739         * tui/tui-data.h (enum tui_scroll_direction): Remove.
740         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
741         Remove direction parameter.
742         (struct tui_source_window_base, struct tui_source_window)
743         (struct tui_disasm_window, struct tui_data_window)
744         (struct tui_cmd_window): Update.
745
746 2019-06-25  Tom Tromey  <tom@tromey.com>
747
748         * tui/tui-winsource.h (tui_set_exec_info_content)
749         (tui_show_exec_info_content, tui_erase_exec_info_content)
750         (tui_clear_exec_info_content, tui_update_exec_info): Change
751         argument to tui_source_window_base.
752         * tui/tui-winsource.c (tui_set_exec_info_content)
753         (tui_show_exec_info_content, tui_erase_exec_info_content)
754         (tui_clear_exec_info_content, tui_update_exec_info): Change
755         argument to tui_source_window_base.
756
757 2019-06-25  Tom Tromey  <tom@tromey.com>
758
759         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
760         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
761
762 2019-06-25  Tom Tromey  <tom@tromey.com>
763
764         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
765         check.
766
767 2019-06-25  Tom Tromey  <tom@tromey.com>
768
769         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
770         type to void.
771         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
772         type to void.
773         * tui/tui-source.c (tui_set_source_content): Update.
774         * tui/tui-disasm.c (tui_set_disassem_content): Update.
775
776 2019-06-25  Tom Tromey  <tom@tromey.com>
777
778         * tui/tui-win.c (window_name_completer, tui_set_focus)
779         (tui_all_windows_info): Use name method.
780         * tui/tui-data.h (struct tui_gen_win_info)
781         (struct tui_source_window, struct tui_disasm_window)
782         (struct tui_data_window, struct tui_cmd_window) <name>: New
783         method.
784         (tui_win_name): Don't declare.
785         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
786         (tui_win_name): Remove.
787
788 2019-06-25  Tom Tromey  <tom@tromey.com>
789
790         * tui/tui-winsource.h (tui_update_source_window)
791         (tui_update_source_window_as_is): Change parameter type.
792         * tui/tui-winsource.c (tui_update_source_window): Change win_info
793         to be a tui_source_window_base.
794         (tui_update_source_window_as_is): Likewise.
795         * tui/tui-win.c (make_visible_with_new_height): Update.
796
797 2019-06-25  Tom Tromey  <tom@tromey.com>
798
799         * tui/tui-winsource.c (tui_erase_source_content)
800         (tui_show_source_content, tui_show_exec_info_content)
801         (tui_erase_exec_info_content): Use refresh_window method.
802         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
803         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
804         from tui_refresh_win.
805         (tui_data_window::refresh_window): New method.
806         (tui_win_info::refresh, tui_source_window_base::refresh)
807         (tui_refresh_all): Use refresh_window method.
808         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
809         method.
810         * tui/tui-regs.c (tui_display_register): Call refresh_window
811         method.
812         * tui/tui-layout.c (show_source_disasm_command)
813         (show_source_or_disasm_and_command): Call refresh_window method.
814         * tui/tui-data.h (struct tui_gen_win_info)
815         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
816         New method.
817
818 2019-06-25  Tom Tromey  <tom@tromey.com>
819
820         * tui/tui.c (tui_rl_other_window, tui_enable)
821         (tui_is_window_visible, tui_get_command_dimension): Update.
822         * tui/tui-winsource.c (tui_update_source_window_as_is)
823         (tui_clear_source_content, tui_erase_source_content)
824         (tui_show_source_line, tui_source_window_base::refill)
825         (tui_source_window_base::do_scroll_horizontal)
826         (tui_source_window_base::set_is_exec_point_at)
827         (tui_update_breakpoint_info, tui_set_exec_info_content)
828         (tui_alloc_source_buffer, tui_line_is_displayed)
829         (tui_addr_is_displayed): Update.
830         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
831         (tui_check_and_display_highlight_if_needed)
832         (tui_win_info::make_visible, tui_win_info::refresh)
833         (tui_refresh_all): Update.
834         * tui/tui-windata.c (tui_first_data_item_displayed)
835         (tui_delete_data_content_windows, tui_erase_data_content)
836         (tui_display_all_data, tui_data_window::refresh_all)
837         (tui_check_data_values): Update.
838         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
839         (tui_set_win_focus_to, tui_win_info::forward_scroll)
840         (tui_win_info::backward_scroll, tui_refresh_all_win)
841         (tui_resize_all, tui_set_focus, tui_all_windows_info)
842         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
843         (tui_source_window_base::set_new_height)
844         (tui_data_window::set_new_height)
845         (make_invisible_and_set_new_height)
846         (make_visible_with_new_height, new_height_ok)
847         (parse_scrolling_args): Update.
848         * tui/tui-stack.c (tui_show_frame_info): Update.
849         * tui/tui-source.c (tui_set_source_content)
850         (tui_set_source_content_nil, tui_source_is_displayed)
851         (tui_source_window::do_scroll_vertical): Update.
852         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
853         (tui_display_registers_from, tui_display_reg_element_at_line)
854         (tui_check_register_values, tui_reg_command): Update.
855         * tui/tui-layout.c (tui_default_win_height)
856         (show_source_disasm_command, show_data, init_and_make_win)
857         (show_source_or_disasm_and_command): Update.
858         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
859         (tui_redisplay_readline, tui_mld_flush)
860         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
861         (tui_getc): Update.
862         * tui/tui-disasm.c (tui_set_disassem_content)
863         (tui_disasm_window::do_scroll_vertical): Update.
864         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
865         Now virtual.
866         (struct tui_win_info): Derive from tui_gen_win_info.
867         <~tui_win_info>: Mark as override.
868         <generic>: Remove member.
869         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
870         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
871         (~tui_data_window, ~tui_win_info)
872         (tui_free_all_source_wins_content): Update.
873         * tui/tui-command.c (tui_refresh_cmd_win): Update.
874
875 2019-06-25  Tom Tromey  <tom@tromey.com>
876
877         * tui/tui-layout.c (init_and_make_win): Use new.
878         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
879         destructor, initializers.
880         (tui_alloc_generic_win_info): Don't declare.
881         * tui/tui-data.c (_locator): Add argument to constructor.
882         (source_win, disasm_win): New globals.
883         (exec_info): Remove.
884         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
885         Update.
886         (tui_alloc_generic_win_info): Remove.
887         (init_content_element): Use new.
888         (tui_win_info::tui_win_info): Update.
889         (free_content_elements) <case DATA_WIN>: Use delete.
890
891 2019-06-25  Tom Tromey  <tom@tromey.com>
892
893         * tui/tui-wingeneral.c (tui_refresh_win): Update.
894         * tui/tui-windata.c (tui_first_data_item_displayed)
895         (tui_delete_data_content_windows): Update.
896         * tui/tui-win.c (tui_data_window::set_new_height): Update.
897         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
898         (tui_display_registers_from, tui_check_register_values): Update.
899         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
900         pointer.
901         * tui/tui-data.c (init_content_element): Update.  Allocate the new
902         window.
903         (tui_free_data_content): Update.
904         (free_content_elements) <case DATA_WIN>: Free the window.
905
906 2019-06-25  Tom Tromey  <tom@tromey.com>
907
908         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
909         Update.
910         * tui/tui-layout.c (make_command_window)
911         (show_source_disasm_command, show_data, init_and_make_win)
912         (show_source_or_disasm_and_command): Update.
913         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
914         method.
915         <can_highight, is_highlighted>: Now bool.
916         (tui_set_win_highlight): Don't declare.
917         * tui/tui-data.c (tui_set_win_highlight): Remove.
918
919 2019-06-25  Tom Tromey  <tom@tromey.com>
920
921         * tui/tui-wingeneral.c (make_visible): Remove check of window
922         type.
923
924 2019-06-25  Tom Tromey  <tom@tromey.com>
925
926         * tui/tui-win.c (tui_win_info::max_height)
927         (tui_cmd_window::max_height): New methods.
928         (new_height_ok): Call max_height.
929         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
930         <max_height>: New method.
931
932 2019-06-25  Tom Tromey  <tom@tromey.com>
933
934         * tui/tui-win.c (tui_source_window_base::set_new_height)
935         (tui_data_window::set_new_height): New methods.
936         (make_invisible_and_set_new_height): Call set_new_height method.
937         * tui/tui-data.h (struct tui_win_info)
938         (struct tui_source_window_base, struct tui_data_window)
939         <set_new_height>: New method.
940
941 2019-06-25  Tom Tromey  <tom@tromey.com>
942
943         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
944         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
945         tui_refresh_data_win.
946         * tui/tui-win.c (tui_source_window_base::refresh_all): New
947         method.
948         (tui_refresh_all_win): Call the refresh_all method.
949         (tui_set_focus): Likewise.
950         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
951         (struct tui_source_window_base, struct tui_data_window) <refresh>:
952         Likewise.
953
954 2019-06-25  Tom Tromey  <tom@tromey.com>
955
956         * tui/tui-winsource.h (tui_refill_source_window)
957         (tui_set_is_exec_point_at): Don't declare.
958         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
959         (tui_source_window_base::refill): Rename from
960         tui_refill_source_window.
961         (tui_source_window_base::do_scroll_horizontal): Update.
962         (tui_source_window_base::set_is_exec_point_at): Rename from
963         tui_set_is_exec_point_at.
964         (tui_update_all_breakpoint_info): Update.
965         * tui/tui-stack.c (tui_show_frame_info): Update.
966         * tui/tui-layout.c (show_data): Add cast.
967         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
968         * tui/tui-data.h (struct tui_source_window_base) <refill,
969         set_is_exec_point_at>: New methods.
970         (tui_source_windows, tui_add_to_source_windows): Update types.
971         (tui_add_to_source_windows): Remove redundant declaration.
972         * tui/tui-data.c (source_windows): Store tui_source_window_base.
973         (tui_source_windows): Change return type.
974         (tui_clear_source_windows_detail): Update.
975         (tui_add_to_source_windows): Change type of parameter.
976         (tui_free_all_source_wins_content): Update.
977
978 2019-06-25  Tom Tromey  <tom@tromey.com>
979
980         * tui/tui-wingeneral.c (tui_win_info::refresh)
981         (tui_source_window_base::refresh): New methods.
982         (tui_refresh_all): Call the refresh method.
983         * tui/tui-data.h (struct tui_win_info)
984         (struct tui_source_window_base) <refresh>: New method.
985
986 2019-06-25  Tom Tromey  <tom@tromey.com>
987
988         * tui/tui.h (tui_is_window_visible): Return bool.
989         * tui/tui.c (tui_is_window_visible): Return bool.
990         * tui/tui-wingeneral.c (tui_make_window, make_visible)
991         (tui_make_visible, tui_make_invisible)
992         (tui_win_info::make_visible)
993         (tui_source_window_base::make_visible, make_all_visible)
994         (tui_make_all_visible, tui_make_all_invisible): Update.
995         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
996         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
997         bool.
998         (struct tui_win_info, struct tui_source_window_base)
999         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1000         * tui/tui-data.c (tui_init_generic_part): Update.
1001
1002 2019-06-25  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1005         (tui_source_window_base::make_visible): New methods.
1006         (make_all_visible): Make method call.
1007         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1008         (struct tui_source_window_base, struct tui_cmd_window): Override
1009         make_visible.
1010         (tui_win_is_source_type): Don't declare.
1011         * tui/tui-data.c (tui_win_is_source_type): Remove.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1016         NULL check.
1017
1018 2019-06-25  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1021         Inline constructor.  Add initializers for members.
1022         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1023         constructors; now inline in class.
1024
1025 2019-06-25  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-regs.c (tui_show_registers): Update.
1028         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1029         bool.
1030         * tui/tui-data.c (tui_data_window::clear_detail)
1031         (tui_data_window): Update.
1032
1033 2019-06-25  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-windata.c (tui_display_all_data)
1036         (tui_display_data_from_line, tui_display_data_from)
1037         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1038         Update.
1039         * tui/tui-regs.c (tui_last_regs_line_no)
1040         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1041         (tui_show_registers, tui_show_register_group)
1042         (tui_display_registers_from, tui_display_reg_element_at_line)
1043         (tui_display_registers_from_line, tui_check_register_values)
1044         (tui_reg_next, tui_reg_prev): Update.
1045         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1046         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1047         tui_data_window.
1048         (struct tui_win_info) <detail>: Remove.  Add new fields from
1049         tui_data_info.
1050         (TUI_DATA_WIN): Add cast.
1051         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1052         (~tui_data_window): Simplify.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-layout.c (show_source_disasm_command)
1057         (show_source_or_disasm_and_command): Update.
1058         * tui/tui-io.c (update_cmdwin_start_line)
1059         (tui_redisplay_readline): Update.
1060         * tui/tui-data.h (struct tui_command_info): Remove.
1061         (struct tui_win_info) <detail>: Remove command_info member.
1062         (struct tui_data_window) <start_line>: New member, from
1063         tui_command_info.
1064         (TUI_CMD_WIN): Add casts.
1065
1066 2019-06-25  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-winsource.c (tui_update_source_window)
1069         (tui_refill_source_window)
1070         (tui_source_window_base::do_scroll_horizontal)
1071         (tui_update_breakpoint_info, tui_set_exec_info_content)
1072         (tui_show_exec_info_content, tui_erase_exec_info_content)
1073         (tui_clear_exec_info_content): Update.
1074         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1075         Update.
1076         * tui/tui-win.c (make_invisible_and_set_new_height)
1077         (make_visible_with_new_height): Update.
1078         * tui/tui-source.c (tui_set_source_content)
1079         (tui_show_symtab_source): Update.
1080         * tui/tui-layout.c (extract_display_start_addr)
1081         (show_source_disasm_command, show_data)
1082         (make_source_or_disasm_window)
1083         (show_source_or_disasm_and_command): Update.
1084         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1085         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1086         "gdbarch".
1087         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1088         to tui_source_window_base.
1089         (struct tui_win_info) <detail>: Remove source_info member.
1090         (struct tui_source_window_base) <has_locator>: Inline.
1091         Move contents from tui_source_info; rename has_locator member to
1092         m_has_locator.
1093         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1094         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1095         header file.
1096         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1097         Simplify.
1098         (tui_free_all_source_wins_content): Cast to
1099         tui_source_window_base.
1100
1101 2019-06-25  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-win.c (make_invisible_and_set_new_height)
1104         (make_visible_with_new_height): Call has_locator method.
1105         * tui/tui-layout.c (show_source_disasm_command, show_data)
1106         (show_source_or_disasm_and_command): Update for bool change.
1107         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1108         (tui_win_info) <has_locator>: New method.
1109         (struct tui_source_window_base) <has_locator>: New method.
1110         (tui_win_has_locator): Don't declare.
1111         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1112         from tui_win_has_locator.
1113         (tui_source_window_base): Use false, not FALSE.
1114
1115 2019-06-25  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1118         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1119         clear_detail method directly.
1120         (tui_clear_win_detail): Remove.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1125         "this", not TUI_DISASM_WIN.
1126
1127 2019-06-25  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1130         declare.
1131         * tui/tui-winsource.c
1132         (tui_source_window_base::do_scroll_horizontal): Rename from
1133         tui_horizontal_source_scroll.
1134         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1135         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1136         from tui_vertical_data_scroll.
1137         * tui/tui-win.h (tui_scroll): Don't declare.
1138         * tui/tui-win.c (tui_win_info::forward_scroll)
1139         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1140         (tui_win_info::right_scroll): Rename and update.
1141         (tui_scroll_forward_command, tui_scroll_backward_command)
1142         (tui_scroll_left_command, tui_scroll_right_command): Update.
1143         (tui_scroll): Remove.
1144         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1145         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1146         from tui_vertical_source_scroll.
1147         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1148         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1149         from tui_vertical_disassem_scroll.
1150         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1151         do_scroll_horizontal>: New methods.
1152         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1153         Likewise.
1154         (struct tui_source_window_base): Add do_scroll_horizontal.
1155         (struct tui_source_window, struct tui_disasm_window): Add
1156         do_scroll_vertical.
1157         (struct tui_data_window, struct tui_cmd_window): Add
1158         do_scroll_horizontal and do_scroll_vertical.
1159         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1160
1161 2019-06-25  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-data.h (struct tui_source_window_base): New struct.
1164         (struct tui_source_window): Derive from tui_source_window_base.
1165         (struct tui_disasm_window): New struct.
1166         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1167         from tui_source_window::clear_detail.
1168         (tui_source_window_base): Rename from tui_source_window.
1169         (~tui_source_window_base): Rename from ~tui_source_window.
1170         (tui_alloc_win_info): Create a tui_disasm_window.
1171
1172 2019-06-25  Tom Tromey  <tom@tromey.com>
1173
1174         * tui/tui-data.h (struct tui_source_window)
1175         (struct tui_data_window): Declare destructors.
1176         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1177         destructors.
1178         (tui_win_info): Simplify.
1179
1180 2019-06-25  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-winsource.c (tui_display_main)
1183         (tui_update_source_windows_with_addr)
1184         (tui_update_all_breakpoint_info): Update.
1185         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1186         (new_height_ok, parse_scrolling_args): Update.
1187         * tui/tui-stack.c (tui_show_frame_info): Update.
1188         * tui/tui-data.h (struct tui_list): Remove.
1189         (tui_source_windows): Return a reference to a std::vector.
1190         * tui/tui-data.c (source_windows): Now a std::vector.
1191         (tui_source_windows): Change return type.
1192         (tui_clear_source_windows): Rewrite.
1193         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1194         (tui_free_all_source_wins_content): Rewrite.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1199         (struct tui_data_window, struct tui_cmd_window): Declare
1200         clear_detail method.
1201         * tui/tui-data.c (tui_source_window::clear_detail)
1202         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1203         methods.
1204         (tui_clear_win_detail): Simplify.
1205
1206 2019-06-25  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-layout.c (make_source_window, make_disasm_window)
1209         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1210         Return the new window.
1211         (show_source_disasm_command, show_data)
1212         (show_source_or_disasm_and_command): Update.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1217         parameter.  Return the new window.
1218         (show_source_disasm_command): Update and remove NULL check.
1219         (show_source_or_disasm_and_command): Update.
1220
1221 2019-06-25  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1224
1225 2019-06-25  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-data.h (struct tui_win_info): Make constructor
1228         protected.  Make destructor virtual.  Add initializers.
1229         (tui_source_window, tui_data_window, tui_cmd_window): New
1230         classes.
1231         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1232         constructor.  Add "type" parameter.
1233         (tui_source_window, tui_data_window, tui_cmd_window): New
1234         constructors.
1235         (tui_alloc_win_info): Instantiate the appropriate subclass.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-win.c (tui_resize_all): Use delete.
1240         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1241         destructor.
1242         (tui_free_window): Don't declare.
1243         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1244         Update.
1245
1246 2019-06-25  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-data.h (struct tui_win_info): Add constructor.
1249         * tui/tui-data.c (tui_alloc_win_info): Use new.
1250         (tui_free_window): Use delete.
1251
1252 2019-06-22  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1255         declare.
1256         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1257
1258 2019-06-22  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1261         declare.
1262         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1263
1264 2019-06-22  Tom de Vries  <tdevries@suse.de>
1265
1266         * dwarf2read.c (create_addrmap_from_aranges)
1267         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1268         instead of '%zu'.
1269
1270 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1271
1272         * dwarf2read.h (dwarf2_section_info_def): Remove.
1273         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1274         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1275         std::vector<dwarf2_section_info>.
1276         (struct dwo_file) <~dwo_file>: Remove.
1277         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1278         types field.
1279         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1280         (dwarf2_read_debug_names): Likewise.
1281         (create_debug_types_hash_table): Change parameter type to
1282         array_view, adjust code accordingly.
1283         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1284         (partial_die_info::fixup): Likewise.
1285         (determine_prefix): Likewise.
1286         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1287
1288 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1289
1290         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1291         gdb_bfd_ref_ptr.
1292         <~dwo_file>: Remove call to gdb_bfd_unref.
1293         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1294         gdb_bfd_ref_ptr::get.
1295
1296 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1297
1298         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1299         type to htab_up.
1300         * dwarf2read.c (struct dwo_file): Initialize fields.
1301         <~dwo_file>: New.
1302         (free_dwo_file): Remove, move content to ~dwo_file.
1303         (struct dwo_file_deleter): Remove.
1304         (dwo_file_up>: Remove custom deleter.
1305         (free_dwo_files): Remove.
1306         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1307         dwo_files.
1308         (process_skeletonless_type_units): Call unique_ptr::get.
1309         (allocate_dwo_file_hash_table): Add deleter to created hash
1310         table.  Change return type to htab_up.
1311         (lookup_dwo_file_slot): Don't memset dwo_file, call
1312         unique_ptr::get.
1313         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1314         (create_dwo_unit_in_dwp_v2): Likewise.
1315         (open_and_init_dwo_file): Likewise.
1316         (free_dwo_file_from_slot): Remove.
1317
1318 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1319
1320         * dwarf2read.h (struct dwarf2_section_info) <readin,
1321         is_virtual>: Change type to bool.
1322         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1323         true instead of 1.
1324
1325 2019-06-19  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-data.h (tui_init_content_element): Don't declare.
1328
1329 2019-06-19  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-data.h (tui_init_win_info): Don't declare.
1332
1333 2019-06-19  Tom de Vries  <tdevries@suse.de>
1334
1335         * dwarf2read.h (abstract_to_concrete): Change type to
1336         std::unordered_map<sect_offset, std::vector<sect_offset>,
1337         gdb::hash_enum<sect_offset>>.
1338
1339 2019-06-19  Tom Tromey  <tromey@adacore.com>
1340
1341         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1342         EVAL_AVOID_SIDE_EFFECTS specially.
1343
1344 2019-06-19  Tom Tromey  <tromey@adacore.com>
1345
1346         * source-cache.c (highlighter): New global.
1347         (source_cache::get_source_lines): Create a highlighter on demand.
1348
1349 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * defs.h (deprecated_interactive_hook): Delete declaration.
1352         * interps.c (clear_interpreter_hooks): Remove use of
1353         deprecated_interactive_hook.
1354         * top.c (deprecated_interactive_hook): Delete definition.
1355         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1356
1357 2019-06-18  Tom de Vries  <tdevries@suse.de>
1358
1359         PR gdb/24515
1360         * dwarf2read.h (abstract_to_concrete): Change type from
1361         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1362         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1363         * dwarf2read.c (read_variable): Update.
1364         (dwarf2_fetch_die_loc_sect_off): Update.
1365
1366 2019-06-17  Tom de Vries  <tdevries@suse.de>
1367
1368         PR gdb/24617
1369         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1370         accessing parent[parent_len - 1].
1371
1372 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1373
1374         PR gdb/24364
1375         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1376         call dtrace_process_dof with NULL dof.
1377
1378 2019-06-16  Tom de Vries  <tdevries@suse.de>
1379
1380         PR gdb/24445
1381         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1382
1383 2019-06-16  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1386         (make_all_visible): Use address of member.
1387
1388 2019-06-16  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1391         (tui_free_window, free_content, free_content_elements): Remove
1392         unnecessary cast.
1393         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1394         cast.
1395         * tui/tui-regs.c (tui_show_register_group)
1396         (tui_display_registers_from, tui_display_reg_element_at_line):
1397         Remove unnecessary cast.
1398
1399 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * linux-nat.c (normal_mask): Delete.
1402         (_initialize_linux_nat): Don't initialise normal_mask.
1403
1404 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1405
1406         PR gdb/24445
1407         * dwarf-index-write.h (write_psymtabs_to_index): Add
1408         dwz_basename parameter.
1409         * dwarf-index-write.c (write_gdbindex): Move file writing to
1410         write_gdbindex_1.  Change return type void.
1411         (assert_file_size): Move up, remove filename parameter.
1412         (write_gdbindex_1): New function.
1413         (write_debug_names): Change return type to void, call
1414         assert_file_size.
1415         (struct index_wip_file): New struct.
1416         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1417         file logic to index_wip_file.  Write index for dwz file if
1418         needed.
1419         (save_gdb_index_command): Pass basename of dwz file, if present.
1420         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1421         build-id of dwz file, if present.
1422         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1423         (dwarf2_get_dwz_file): Likewise.
1424         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1425         (dwarf2_get_dwz_file): Likewise.
1426
1427 2019-06-16  Tom Tromey  <tom@tromey.com>
1428
1429         * coffread.c (process_coff_symbol): Use xstrdup.
1430         * value.c (create_internalvar): Use xstrdup.
1431
1432 2019-06-16  Tom Tromey  <tom@tromey.com>
1433
1434         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1435         * breakpoint.c (stopin_command, stopat_command)
1436         (until_break_command, decode_location_default): Remove unnecessary
1437         cast.
1438         * utils.c (subset_compare): Remove unnecessary cast.
1439         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1440         cast.
1441         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1442         cast.
1443         * infcmd.c (path_command): Remove unnecessary cast.
1444         * coffread.c (decode_type): Remove unnecessary cast.
1445         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1446         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1447         * tui/tui-stack.c (tui_show_locator_content)
1448         (tui_show_frame_info): Remove unnecessary cast.
1449         * tui/tui-win.c (tui_scroll_forward_command)
1450         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1451         (parse_scrolling_args): Remove unnecessary cast.
1452         * tui/tui-data.c (init_win_info, tui_del_window)
1453         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1454         (free_content_elements): Remove unnecessary cast.
1455         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1456         unnecessary cast.
1457         * tui/tui-source.c (tui_set_source_content)
1458         (tui_vertical_source_scroll): Remove unnecessary cast.
1459         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1460         cast.
1461         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1462         * tui/tui-regs.c (tui_display_registers_from)
1463         (tui_display_register): Remove unnecessary cast.
1464         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1465         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1466         (make_visible): Remove unnecessary cast.
1467         * tui/tui-winsource.c (tui_erase_source_content)
1468         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1469         unnecessary cast.
1470         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1471         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1472         * stabsread.c (read_type, read_array_type, read_range_type):
1473         Remove unnecessary cast.
1474         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1475         (parse_symbol, parse_type, upgrade_type, parse_external)
1476         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1477         unnecessary cast.
1478         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1479
1480 2019-06-16  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-data.c (tui_alloc_generic_win_info)
1483         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1484         checks.
1485
1486 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1487             Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * f-typeprint.c (f_print_type): Don't return early for not
1490         associated or not allocated types.
1491         (f_type_print_varspec_suffix): Add print_rank parameter and print
1492         ranks of array types in case they dangling.
1493         (f_type_print_base): Add print_rank parameter.
1494
1495 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * NEWS: Mention new MI commands.
1498         * break-catch-throw.c (enum exception_event_kind): Move to
1499         breakpoint.h.
1500         (print_mention_exception_catchpoint): Output text as a single
1501         message.
1502         (catch_exception_command_1): Rename to...
1503         (catch_exception_event): ...this, make non-static, update header
1504         command, and change some parameter types.
1505         (catch_catch_command): Update for changes to
1506         catch_exception_command_1.
1507         (catch_throw_command): Likewise.
1508         (catch_rethrow_command): Likewise.
1509         * breakpoint.c (enum exception_event_kind): Delete.
1510         * breakpoint.h (enum exception_event_kind): Moved here from
1511         break-catch-throw.c.
1512         (catch_exception_event): Declare.
1513         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1514         (mi_cmd_catch_throw): New function.
1515         (mi_cmd_catch_rethrow): New function.
1516         (mi_cmd_catch_catch): New function.
1517         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1518         'catch-catch' entries.
1519         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1520         (mi_cmd_catch_rethrow): Declare.
1521         (mi_cmd_catch_catch): Declare.
1522
1523 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * annotate.c (annotate_source_line): Change return type to void,
1526         update implementation to match.
1527         * annotate.h (annotate_source_line): Change return type to void,
1528         update header comment.
1529         * stack.c (print_frame_info): Don't change what frame information
1530         is printed based on whether annotations are on or not.
1531
1532 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1535         (annotate_source): Make static.
1536         (annotate_source_line): Moved from source.c and renamed from
1537         identify_source_line.  Update the return type.
1538         * annotate.h (annotate_source): Delete declaration.
1539         (annotate_source_line): Declaration moved from source.h, and
1540         renamed from identify_source_line.  Return type updated.
1541         * source.c (identify_source_line): Moved to annotate.c and renamed
1542         to annotate_source_line.
1543         (info_line_command): Remove check of annotation_level.
1544         * source.h (identify_source_line): Move declaration to annotate.h
1545         and rename to annotate_source_line.
1546         * stack.c: Add 'annotate.h' include.
1547         (print_frame_info): Remove check of annotation_level before
1548         calling annotate_source_line.
1549
1550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         * source-cache.c (source_cache::get_plain_source_lines): Use
1553         open_source_file_with_line_charpos instead of just
1554         open_source_file, remove call to find_source_lines.
1555         (source_cache::get_source_lines): Likewise.
1556         * source.c (find_source_lines): Make static.
1557         (get_filename_and_charpos): Renamed into...
1558         (open_source_file_with_line_charpos): ..this along with changes to
1559         return a scoped_fd, and some other minor clean ups.
1560         (identify_source_line): Use open_source_file_with_line_charpos.
1561         (search_command_helper): Use open_source_file_with_line_charpos
1562         instead of just open_source_file, remove call to
1563         find_source_lines.
1564         * source.h (open_source_file_with_line_charpos): Declare new
1565         function.
1566         (find_source_lines): Delete declaration.
1567
1568 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * source.c (get_filename_and_charpos): Remove fullname
1571         parameter.
1572         (identify_source_line): Update call to get_filename_and_charpos.
1573
1574 2019-06-14  Tom Tromey  <tromey@adacore.com>
1575
1576         PR gdb/24502:
1577         * ui-style.h (skip_ansi_escape): Update comment.
1578         * ui-file.h (class no_terminal_escape_file): New class.
1579         * ui-file.c (no_terminal_escape_file::write)
1580         (no_terminal_escape_file::puts): New methods.
1581         * cli/cli-logging.c (handle_redirections): Use
1582         no_terminal_escape_file.
1583
1584 2019-06-14  Tom Tromey  <tromey@adacore.com>
1585
1586         * NEWS: Move convenience variable news above Python news.
1587
1588 2019-06-14  Tom Tromey  <tom@tromey.com>
1589
1590         * gnulib: Move directory to top-level.
1591         * configure.ac: Don't configure gnulib.
1592         * configure: Rebuild.
1593         * common/common-defs.h: Use new path to gnulib.
1594         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1595         (GNULIB_H): Remove.
1596         (INCGNU): Look in new gnulib location.
1597         (HFILES_NO_SRCDIR): Remove gnulib files.
1598         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1599         (generated_files): Remove GNULIB_H.
1600         ($(LIBGNU), all-lib): Remove targets.
1601         (distclean): Don't mention GNULIB_BUILDDIR.
1602         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1603
1604 2019-06-14  Tom Tromey  <tromey@adacore.com>
1605
1606         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1607         Warn if symbol file does not provide any symbols.
1608
1609 2019-06-14  Tom Tromey  <tromey@adacore.com>
1610
1611         * source.c (find_and_open_source): Respect basenames_may_differ.
1612
1613 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * annotate.c (annotate_breakpoints_invalid): Make use of
1616         scoped_restore_terminal_state.
1617         (annotate_frames_invalid): Likewise.
1618
1619 2019-06-14  Tom Tromey  <tromey@adacore.com>
1620
1621         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1622         allow assignment to an internalvar.
1623
1624 2019-06-14  Tom Tromey  <tromey@adacore.com>
1625
1626         * ada-lex.l: Allow "_" in attribute names.
1627
1628 2019-06-14  Tom Tromey  <tromey@adacore.com>
1629
1630         PR gdb/24653:
1631         * regcache.c (registers_changed): Don't call alloca.
1632         * top.c (execute_command): Don't call alloca.
1633
1634 2019-06-13  Pedro Alves  <palves@redhat.com>
1635
1636         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1637         'expression'.  When parsing an expression, error out if there's
1638         junk after "unlimited".
1639         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1640         (do_set_command): Adjust calls to is_unlimited_literal.
1641
1642 2019-06-13  Pedro Alves  <palves@redhat.com>
1643
1644         * compile/compile.c (make_compile_options_def_group): Add braces
1645         around array_view initializer.
1646         * thread.c (make_thread_apply_all_options_def_group)
1647         (make_thread_apply_all_options_def_group): Likewise.
1648
1649 2019-06-13  Pedro Alves  <palves@redhat.com>
1650
1651         * NEWS (New commands): Mention "maint test-options
1652         require-delimiter", "maint test-options unknown-is-error", "maint
1653         test-options unknown-is-operand" and "maint show
1654         test-options-completion-result".
1655         (New command options, command completion): New section.
1656         (Completion improvements): New section.
1657         Mention that you can abbreviate "unlimited".
1658
1659 2019-06-13  Pedro Alves  <palves@redhat.com>
1660
1661         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1662         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1663         * unittests/cli-utils-selftests.c (test_parse_flags)
1664         (test_parse_flags_qcs): Delete.
1665         (test_cli_utils): Don't call deleted functions.
1666
1667 2019-06-13  Pedro Alves  <palves@redhat.com>
1668
1669         * thread.c: Include "cli/cli-option.h".
1670         (tp_array_compar_ascending): Global.
1671         (tp_array_compar): Delete function.
1672         (tp_array_compar_ascending, tp_array_compar_descending): New
1673         functions.
1674         (ascending_option_def, qcs_flag_option_def)
1675         (thr_qcs_flags_option_defs)
1676         (make_thread_apply_all_options_def_group)
1677         (make_thread_apply_options_def_group): New.
1678         (thread_apply_all_command): Use gdb::option::process_options.
1679         (thread_apply_command_completer)
1680         (thread_apply_all_command_completer): New.
1681         (thread_apply_command): Use gdb::option::process_options.
1682         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1683         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1684         to generate help text of "thread apply".  Adjust "taas"'s help.
1685         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1686         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1687
1688 2019-06-13  Pedro Alves  <palves@redhat.com>
1689
1690         * thread.c (thread_apply_command): Check for invalid TID with
1691         isdigit instead of !isalpha.
1692
1693 2019-06-13  Pedro Alves  <palves@redhat.com>
1694
1695         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1696         (validate_flags_qcs): New.
1697         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1698         (validate_flags_qcs): Declare.
1699         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1700         (make_frame_apply_options_def_group): New.
1701         (frame_apply_command_count): Process options with
1702         gdb::option::process_options.
1703         (frame_apply_completer): New.
1704         (frame_apply_level_completer, frame_apply_all_completer)
1705         (frame_apply_completer): New.
1706         (_initialize_stack): Update help of "frame apply", "frame apply
1707         level", "frame apply all" and "faas" to mention supported options
1708         and install command completers.
1709         * stack.h (frame_apply_all_completer): Declare.
1710         * thread.c: Include "stack.h".
1711         (tfaas_command): Add "--".
1712         (_initialize_thread): Update help "tfaas" to mention supported
1713         options and install command completer.
1714
1715 2019-06-13  Pedro Alves  <palves@redhat.com>
1716
1717         * completer.c (complete_nested_command_line): New.
1718         (gdb_completion_word_break_characters_throw): Add assertion.
1719         * completer.h (complete_nested_command_line): Declare.
1720
1721 2019-06-13  Pedro Alves  <palves@redhat.com>
1722
1723         * stack.c (parse_backtrace_qualifiers): New.
1724         (backtrace_command): Use it.
1725         (backtrace_command_completer): Complete on qualifiers.
1726
1727 2019-06-13  Pedro Alves  <palves@redhat.com>
1728
1729         * frame.c: Include "cli/cli-option.h.
1730         (user_set_backtrace_options): New.
1731         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1732         Delete.
1733         (get_prev_frame): Adjust.
1734         (boolean_option_def, uinteger_option_def)
1735         (set_backtrace_option_defs): New.
1736         (_initialize_frame): Adjust and use
1737         gdb::option::add_setshow_cmds_for_options to install "set
1738         backtrace past-main" and "set backtrace past-entry".
1739         * frame.h: Include "cli/cli-option.h".
1740         (struct frame_print_options): Forward declare.
1741         (print_frame_arguments_all, print_frame_arguments_scalars)
1742         (print_frame_arguments_none): Declare.
1743         (print_entry_values): Delete declaration.
1744         (struct frame_print_options, user_frame_print_options): New.
1745         (struct set_backtrace_options): New.
1746         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1747         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1748         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1749         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1750         (list_args_or_locals): Add frame_print_options parameter.
1751         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1752         * python/py-framefilter.c (enumerate_args): Pass down
1753         USER_FRAME_PRINT_OPTIONS.
1754         * stack.c: Include "cli/cli-option.h".
1755         (print_frame_arguments_all, print_frame_arguments_scalars)
1756         (print_frame_arguments_none): Declare.
1757         (print_raw_frame_arguments, print_entry_values): Delete.
1758         (user_frame_print_options): New.
1759         (boolean_option_def, enum_option_def, frame_print_option_defs):
1760         New.
1761         (struct backtrace_cmd_options): New.
1762         (bt_flag_option_def): New.
1763         (backtrace_command_option_defs): New.
1764         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1765         (print_frame_arg, read_frame_arg, print_frame_args)
1766         (print_frame_info, print_frame): Add frame_print_options parameter
1767         and use it.
1768         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1769         (backtrace_command_1): Add frame_print_options and
1770         backtrace_cmd_options parameters and use them.
1771         (make_backtrace_options_def_group): New.
1772         (backtrace_command): Process command options with
1773         gdb::option::process_options.
1774         (backtrace_command_completer): New.
1775         (_initialize_stack): Extend "backtrace"'s help to mention
1776         supported options.  Install completer for "backtrace".
1777         Install some settings commands with add_setshow_cmds_for_options.
1778
1779 2019-06-13  Pedro Alves  <palves@redhat.com>
1780
1781         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1782         and that "set/show print raw frame-arguments" are now deprecated.
1783
1784         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1785         command.
1786         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1787         * stack.c (_initialize_stack): Install "set/show print
1788         raw-frame-arguments", and deprecate "set/show print raw
1789         frame-arguments".
1790         * valprint.c (_initialize_valprint): Deprecate "set/show print
1791         raw".
1792
1793 2019-06-13  Pedro Alves  <palves@redhat.com>
1794
1795         * compile/compile.c (struct compile_options): New.
1796         (compile_flag_option_def, compile_command_option_defs)
1797         (make_compile_options_def_group): New.
1798         (compile_file_command): Handle options with
1799         gdb::option::process_options.
1800         (compile_file_command_completer): New function.
1801         (compile_code_command): Handle options with
1802         gdb::option::process_options.
1803         (compile_code_command_completer): New function.
1804         (_initialize_compiler): Install completers for "compile code" and
1805         "compile file".  Mention available options in "compile code" and
1806         "compile code"'s help.
1807         * completer.c (advance_to_completion_word): New, factored out from
1808         ...
1809         (advance_to_expression_complete_word_point): ... this.
1810         (advance_to_filename_complete_word_point): New.
1811         * completer.h (advance_to_filename_complete_word_point): New
1812         declaration.
1813
1814 2019-06-13  Pedro Alves  <palves@redhat.com>
1815
1816         * compile/compile.c: Include "cli/cli-option.h".
1817         (compile_print_value): Scope data pointer is now a
1818         value_print_options pointer; adjust.
1819         (compile_print_command): Process options.  Scope data pointer is
1820         now a value_print_options pointer; adjust.
1821         (_initialize_compile): Update "compile print"'s help to include
1822         supported options.  Install a completer for "compile print".
1823         * cp-valprint.c (show_vtblprint, show_objectprint)
1824         (show_static_field_print): Delete.
1825         (_initialize_cp_valprint): Don't install "set print
1826         static-members", "set print vtbl", "set print object" here.
1827         * printcmd.c: Include "cli/cli-option.h" and
1828         "common/gdb_optional.h".
1829         (print_command_parse_format): Rework to fill in a
1830         value_print_options instead of a format_data.
1831         (print_value): Change parameter type from format_data pointer to
1832         value_print_options reference.  Adjust.
1833         (print_command_1): Process options.  Adjust to pass down a
1834         value_print_options.
1835         (print_command_completer): New.
1836         (_initialize_printcmd): Install print_command_completer as
1837         handle_brkchars completer for the "print" command.  Update
1838         "print"'s help to include supported options.
1839         * valprint.c: Include "cli/cli-option.h".
1840         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1841         here from cp-valprint.c.
1842         (boolean_option_def, uinteger_option_def)
1843         (value_print_option_defs, make_value_print_options_def_group):
1844         New.  Use gdb::option::add_setshow_cmds_for_options to install
1845         "set print elements", "set print null-stop", "set print repeats",
1846         "set print pretty", "set print union", "set print array", "set
1847         print address", "set print symbol", "set print array-indexes".
1848         * valprint.h: Include <string> and "cli/cli-option.h".
1849         (make_value_print_options_def_group): Declare.
1850         (print_value): Change parameter type from format_data pointer to
1851         value_print_options reference.
1852         (print_command_completer): Declare.
1853
1854 2019-06-13  Pedro Alves  <palves@redhat.com>
1855
1856         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1857         (COMMON_SFILES): Add maint-test-settings.c.
1858         * cli/cli-decode.c (boolean_enums): New global, factored out from
1859         ...
1860         (add_setshow_boolean_cmd): ... here.
1861         * cli/cli-decode.h (boolean_enums): Declare.
1862         * cli/cli-option.c: New file.
1863         * cli/cli-option.h: New file.
1864         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1865         factored out from ...
1866         (parse_cli_boolean_value(const char *)): ... this.
1867         (is_unlimited_literal): Change parameter type to pointer to
1868         pointer.  Adjust and advance ARG pointer.
1869         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1870         (parse_cli_var_enum): New, factored out from ...
1871         (do_set_command): ... this.  Adjust.
1872         * cli/cli-setshow.h (parse_cli_boolean_value)
1873         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1874         (parse_cli_var_enum): Declare.
1875         * cli/cli-utils.c: Include "cli/cli-option.h".
1876         (get_ulongest): New.
1877         * cli/cli-utils.h (get_ulongest): Declare.
1878         (check_for_argument): New overloads.
1879         * maint-test-options.c: New file.
1880
1881 2019-06-13  Pedro Alves  <palves@redhat.com>
1882
1883         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1884         parse a range if "-" is at the end of the string.
1885
1886 2019-06-13  Pedro Alves  <palves@redhat.com>
1887
1888         * cli/cli-setshow.c (parse_auto_binary_operation)
1889         (parse_cli_boolean_value): Don't allow "o".
1890
1891 2019-06-13  Pedro Alves  <palves@redhat.com>
1892
1893         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1894         * NEWS: Mention maint test-settings KIND.
1895         * maint-test-settings.c: New file.
1896
1897 2019-06-13  Pedro Alves  <palves@redhat.com>
1898
1899         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1900         completer.
1901         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1902         "set" completers.
1903
1904 2019-06-13  Pedro Alves  <palves@redhat.com>
1905
1906         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1907         after item.
1908
1909 2019-06-13  Pedro Alves  <palves@redhat.com>
1910
1911         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1912
1913 2019-06-13  Pedro Alves <palves@redhat.com>
1914
1915         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1916         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1917         call.
1918         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1919         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1920         calls.
1921         (check_for_argument): Skip spaces after argument.
1922
1923 2019-06-13  Pedro Alves  <palves@redhat.com>
1924
1925         * thread.c (thread_apply_command): Adjust TID parsing.
1926         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1927         detected before end of string.
1928         (tid_is_in_list): Error out if LIST is invalid.
1929
1930 2019-06-13  Pedro Alves  <palves@redhat.com>
1931
1932         * completer.c (complete_line_internal_1): Rewind completion word
1933         point.
1934         (completion_tracker::advance_custom_word_point_by): Change
1935         parameter type to int.
1936         * completer.h (completion_tracker::advance_custom_word_point_by):
1937         Likewise.
1938
1939 2019-06-13  Pedro Alves  <palves@redhat.com>
1940
1941         * completer.c (advance_to_completion_word): Handle delimiters.
1942
1943 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1944
1945         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1946
1947 2019-06-11  Tom Tromey  <tom@tromey.com>
1948
1949         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1950         (xmalloc_failed): Move to alloc.c.
1951         * alloc.c: New file.
1952         * Makefile.in (COMMON_SFILES): Add alloc.c.
1953
1954 2019-06-11  Tom Tromey  <tom@tromey.com>
1955
1956         * nat/linux-waitpid.c: Don't include server.h.
1957         (linux_debug): Remove.
1958         (my_waitpid): Update.
1959
1960 2019-06-11  Tom Tromey  <tromey@adacore.com>
1961
1962         * infcall.c (_initialize_infcall): Remove trailing newline from
1963         help.
1964         * user-regs.c (_initialize_user_regs): Remove trailing newline
1965         from help.
1966         * typeprint.c (_initialize_typeprint): Remove trailing newline
1967         from help.
1968         * reverse.c (_initialize_reverse): Remove trailing newlines from
1969         help.
1970         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1971         from help.
1972         * language.c (add_set_language_command): Remove trailing newline
1973         from help.
1974         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1975         help.
1976         * disasm.c (_initialize_disasm): Remove trailing newline from
1977         help.
1978         * top.c (init_main): Remove trailing newline from help.
1979         * interps.c (_initialize_interpreter): Remove trailing newline
1980         from help.
1981         * btrace.c (_initialize_btrace): Remove trailing newlines from
1982         help.
1983         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1984         from help.
1985         * python/python.c (_initialize_python): Remove trailing newline
1986         from help.
1987         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1988         help.
1989         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1990         from help.  Reformat some text.
1991         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1992         from help.
1993         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1994         newline from help.
1995
1996 2019-06-11  Tom Tromey  <tromey@adacore.com>
1997
1998         * darwin-nat.c (darwin_decode_exception_message)
1999         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2000
2001 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * valops.c (value_slice): Check for not allocated or not
2004         associated values.
2005
2006 2019-06-10  Tom de Vries  <tdevries@suse.de>
2007
2008         PR gdb/24618
2009         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2010         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2011         invalid.
2012
2013 2019-06-10  Tom de Vries  <tdevries@suse.de>
2014
2015         PR gdb/24611
2016         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2017         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2018
2019 2019-06-10  Tom de Vries  <tdevries@suse.de>
2020
2021         PR symtab/24545
2022         * symtab.c (struct demangled_name_entry): Add language field.
2023         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2024         static minimal symbol".  Set and use language field.
2025
2026 2019-06-10  Tom Tromey  <tromey@adacore.com>
2027
2028         * ada-lang.c (_initialize_ada_language): Update help text.
2029
2030 2019-06-10  Tom Tromey  <tromey@adacore.com>
2031
2032         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2033         with a newline.
2034         * guile/guile.c (handle_boot_error): Don't end warning with a
2035         newline.
2036         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2037         warning with a newline.
2038         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2039         newline.
2040         (s12z_frame_cache): Likewise.
2041         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2042         a newline.
2043         * solib-svr4.c (disable_probes_interface): Don't end warning with
2044         a newline.
2045         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2046         newline.
2047         * python/python.c (do_finish_initialization): Don't end warning
2048         with a newline.
2049
2050 2019-06-10  Tom Tromey  <tom@tromey.com>
2051
2052         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2053         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2054         gdbpy_enter.
2055
2056 2019-06-10  Tom Tromey  <tromey@adacore.com>
2057
2058         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2059         data.
2060         (elf_new_init): Don't call stabsread_new_init.
2061         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2062         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2063         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2064
2065 2019-06-10  Tom de Vries  <tdevries@suse.de>
2066
2067         PR symtab/16264
2068         PR symtab/24517
2069         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2070
2071 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2072
2073         * source.c (find_and_open_source): Also rewrite relative file
2074         names.
2075
2076 2019-04-26  Amos Bird  <amosbird@gmail.com>
2077
2078         * annotate.c (annotate_thread_exited): Add "thread-exited"
2079         annotation.
2080
2081 2019-06-06  Tom Tromey  <tromey@adacore.com>
2082
2083         * maint.h (class scoped_command_stats): Use
2084         DISABLE_COPY_AND_ASSIGN.
2085         <print_time>: New method.
2086         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2087         print_time.
2088         (scoped_command_stats::print_time): New method.
2089
2090 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2091
2092         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2093         instructions of lengths 6 or 8 bytes.
2094
2095 2019-06-04  Pedro Alves  <palves@redhat.com>
2096
2097         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2098
2099         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2100         * breakpoint.c (condition_completer): Likewise.
2101         * cli/cli-dump.c (scan_expression): Likewise.
2102         * common/filestuff.c (mkdir_recursive): Likewise.
2103         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2104         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2105         (gdb_abspath): Likewise.
2106         * compile/compile-cplus-types.c
2107         (compile_cplus_instance::decl_name): Likewise.
2108         * completer.c (complete_explicit_location):
2109         (signal_completer, reg_or_group_completer_1): Likewise.
2110         * cp-support.c (cp_remove_params_if_any): Likewise.
2111         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2112         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2113         * infcmd.c (strip_bg_char): Likewise.
2114         * linespec.c (copy_token_string): Likewise.
2115         * mi/mi-main.c (output_cores): Likewise.
2116         * psymtab.c (psymtab_search_name):
2117         * symfile.c (test_set_ext_lang_command): Likewise.
2118         * target.c (target_fileio_read_stralloc): Likewise.
2119         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2120         * value.c (complete_internalvar): Likewise.
2121
2122 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2123
2124         Add objfile property to gdb.Type.
2125         * NEWS: Mention Python API addition.
2126         * python/py-type.c (typy_get_objfile): New method.
2127
2128 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2129
2130         * NEWS: Mention the new set|show style [title|highlight].
2131         Mention changes to "show style", "help" and "apropos".
2132
2133 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2134
2135         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2136         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2137         instead of print_help_for_command.
2138         (print_doc_of_command): New function.
2139         (help_list): Add 'apropos -v word' suggestion.
2140         (print_help_for_command): Style the command name using title style.
2141         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2142         (_initialize_cli_cmds): Describe -v in apropos_command help.
2143
2144 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2145
2146         * cli/cli-style.h (cli_style_option): Add name in constructor,
2147         add m_name class member, add constructor with intensity,
2148         add name class function.
2149         (cli_style_option::add_setshow_commands): Remove name argument.
2150         (highlight_style, title_style): New styles.
2151         * cli/cli-style.c (do_show): New function that shows a style
2152         characteristic styling the style name with itself.
2153         (set_style_name): New function.
2154         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2155         Update all callers according to the changes in cli/cli-style.h.
2156         * utils.h (fputs_highlighted): New function.
2157         * utils.c (fputs_highlighted): Likewise.
2158
2159 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2160
2161         * NEWS: Mention new pipe command and new convenience variables.
2162
2163 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2164
2165         * cli/cli-cmds.c (pipe_command): New function.
2166         (_initialize_cli_cmds): Call add_com for pipe_command.
2167         Define | as an alias for pipe.
2168         (exit_status_set_internal_vars): New function.
2169         (shell_escape): Call exit_status_set_internal_vars.
2170         cli/cli-decode.c (find_command_name_length): Recognize | as
2171         a single character command.
2172
2173 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2174
2175         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2176         top.c (execute_command_to_ui_file): New function, mostly a copy
2177         of execute_command_to_string.
2178         (execute_command_to_string): Implement by calling
2179         execute_command_to_ui_file.
2180
2181 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2182
2183         * top.h (saved_command_line): Remove declaration.
2184         * top.c (previous_saved_command_line, previous_repeat_arguments):
2185         New variables.
2186         (saved_command_line): Make static, define together with other
2187         'repeat variables'.
2188         (dont_repeat): Clear repeat_arguments.
2189         (repeat_previous, get_saved_command_line, save_command_line):
2190         New functions.
2191         (gdb_init): Initialize saved_command_line
2192         and previous_saved_command_line.
2193         * main.c (captured_main_1): Remove saved_command_line initialization.
2194         * event-top.c (handle_line_of_input): Update to use
2195         the new 'repeat' related functions instead of direct access to
2196         saved_command_line.
2197         * command.h (repeat_previous, get_saved_command_line,
2198         save_command_line): New declarations.
2199         (dont_repeat): Add comment.
2200
2201 2019-05-30  Tom Tromey  <tromey@adacore.com>
2202
2203         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2204         Fix comment.
2205         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2206
2207 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2208
2209         PR cli/24587
2210         * completer.c (complete): Initialize variable word.
2211
2212 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2213
2214         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2215         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2216         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2217         'body' is NULL to the outter 'if', protecting the '!is_define'
2218         situation as well.
2219
2220 2019-05-29  Tom Tromey  <tromey@adacore.com>
2221
2222         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2223         (dwarf_unknown): New function.
2224         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2225         (dwarf_type_encoding_name): Use dwarf_unknown.
2226
2227 2019-05-29  Tom Tromey  <tromey@adacore.com>
2228
2229         PR c++/20020:
2230         * cp-valprint.c (cp_print_value_fields): Call
2231         cp_print_static_field inside "try".
2232
2233 2019-05-29  Tom Tromey  <tromey@adacore.com>
2234
2235         * inflow.c (struct terminal_info): Add default operator=.
2236         * configure: Rebuild.
2237         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2238         -Wdeprecated-copy-dtor, -Wredundant-move.
2239
2240 2019-05-29  Tom Tromey  <tromey@adacore.com>
2241
2242         * NEWS: Add entry.
2243         * infcmd.c (print_return_value_1): Handle finish_print
2244         option.
2245         (show_print_finish): New function.
2246         (_initialize_infcmd): Add "set/show print finish" commands.
2247         * valprint.c (user_print_options): Initialize new member.
2248         * valprint.h (struct value_print_options) <finish_print>: New
2249         member.
2250
2251 2019-05-28  Tom Tromey  <tromey@adacore.com>
2252
2253         * ada-lang.c (ada_remove_Xbn_suffix)
2254         (find_old_style_renaming_symbol)
2255         (parse_old_style_renaming): Remove.
2256         (ada_find_renaming_symbol): Don't call
2257         find_old_style_renaming_symbol.
2258         (ada_is_renaming_symbol): Rename from
2259         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2260         bool.  Now static.
2261         (ada_read_var_value): Update and simplify.
2262         * ada-exp.y (write_var_or_type): Remove old code.
2263
2264 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2265
2266         * event-top.c: Remove include comment.
2267         * inflow.c (class scoped_ignore_sigttou): Move from here...
2268         * inflow.h (class scoped_ignore_sigttou): ...to here.
2269         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2270         * top.c:  Remove include comment.
2271
2272 2019-05-27  Tom Tromey  <tom@tromey.com>
2273
2274         * NEWS: Fix typo.
2275
2276 2019-05-22  Tom Tromey  <tromey@adacore.com>
2277
2278         * target.c (target_follow_exec): Constify parameter.
2279         * target-delegates.c: Rebuild.
2280         * remote.c (remote_target::follow_exec): Constify parameter.
2281         * infrun.c (follow_exec): Constify parameter.
2282         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2283         (target_follow_exec): Likewise.
2284
2285 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2286
2287         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2288         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2289
2290 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2291
2292         * NEWS: Add debugredirect and testsuite sections.
2293
2294 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2295
2296         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2297         target descriptions using exclusively floating point register name
2298         aliases.
2299
2300 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         PR gdb/18644:
2303         * f-lang.c (build_fortran_types): Handle the case where
2304         gdbarch_floatformat_for_type returns a nullptr.
2305
2306 2019-05-21  Tom de Vries  <tdevries@suse.de>
2307
2308         PR cli/24587
2309         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2310
2311 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2312
2313         PR gdb/18644:
2314         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2315         16-byte floats.
2316         * i386-tdep.c (i386_floatformat_for_type): Use
2317         floatformats_ia64_quad for the 16-byte floating point component
2318         within a fortran 32-byte complex number.
2319
2320 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2321
2322         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2323         delete default constructor.
2324         (find_partial_die): Update to return const struct.
2325         (partial_die_parent_scope): Move variable declaration into scope
2326         of its use and change its type to auto.
2327         (guess_partial_die_structure_name): Likewise.
2328         (partial_die_info::fixup): Likewise.
2329
2330 2019-05-17  Tom Tromey  <tromey@adacore.com>
2331
2332         * source.c (find_and_open_source): Remove cast.
2333
2334 2019-05-17  Tom Tromey  <tromey@adacore.com>
2335
2336         * annotate.c (annotate_source): Make "filename" const.
2337         * annotate.h (annotate_source): Use const.
2338
2339 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2340
2341         * disasm.c (set_disassembler_options): Send errors to stderr.
2342
2343 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2344
2345         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2346         (cli_interp_base::set_logging): Check debug_redirect.
2347         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2348         * cli/cli-logging.c (debug_redirect): Add static variable.
2349         (pop_output_files): Add default param.
2350         (handle_redirections): Print debug setting.
2351         (show_logging_command): Likewise.
2352         (_initialize_cli_logging): Add debugredirect command.
2353         * interps.c (current_interp_set_logging): Add debug_redirect
2354         parameter.
2355         * interps.h (set_logging): Add debug_redirect parameter.
2356         (current_interp_set_logging): Likewise.
2357         * mi/mi-common.h: Likewise.
2358         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2359
2360 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2361             Tom Tromey  <tromey@adacore.com>
2362
2363         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2364         directly.
2365         * cli/cli-interp.h (make_logging_output): Remove declaration.
2366         * cli/cli-logging.c (make_logging_output): Remove function.
2367         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2368         directly.
2369         * ui-file.c (tee_file::tee_file): Remove bools.
2370         (tee_file::~tee_file): Remove deletes.
2371         * ui-file.h (tee_file): Remove bools.
2372
2373 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2374
2375         * mi/mi-cmds.h (mi_cmd_complete): New function.
2376         * mi/mi-main.c (mi_cmd_complete): Likewise.
2377         * mi/mi-cmds.c: Define new MI command -complete.
2378         * NEWS: Mention new -complete command.
2379
2380 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2381
2382         * completer.h (complete): New function.
2383         * completer.c (complete): Likewise.
2384         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2385         function defined in completer.h.
2386
2387 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2388
2389         * MAINTAINERS (Write After Approval): Add myself.
2390
2391 2019-05-17  Tom de Vries  <tdevries@suse.de>
2392
2393         PR gdb/24094
2394         * dwarf2read.c (struct cu_partial_die_info): New struct.
2395         (find_partial_die): Return cu_partial_die_info.
2396         (partial_die_parent_scope, guess_partial_die_structure_name)
2397         (partial_die_info::fixup): Handle new return type of find_partial_die.
2398
2399 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2400
2401         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2402         "std::string", simplifying the algorithm.
2403
2404 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2405
2406         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2407         (stap_static_probe_ops::get_probes): Likewise.
2408
2409 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2410
2411         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2412         '-')" and "else if".
2413         (stap_parse_single_operand): Join checks for
2414         "gdbarch_stap_parse_special_token_p" and
2415         "gdbarch_stap_parse_special_token" in the same "if" statement.
2416         Invert check when verifying for operation on register
2417         displacement.
2418
2419 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2420
2421         * stap-probe.c (stap_get_opcode): Update comment.
2422         (stap_get_expected_argument_type): Likewise.
2423         (handle_stap_probe): Likewise.
2424
2425 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2426
2427         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2428         return type to 'bool'.  Adjust comment.  Use 'bool' when
2429         appropriate.
2430         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2431         * stap-probe.c (stap_parse_argument_1): Likewise.
2432         (stap_is_operator): Likewise.
2433         (stap_is_generic_prefix): Likewise.
2434         (stap_is_register_prefix): Likewise.
2435         (stap_is_register_indirection_prefix): Likewise.
2436         (stap_is_integer_prefix): Likewise.
2437         (stap_generic_check_suffix): Likewise.
2438         (stap_check_integer_suffix): Likewise.
2439         (stap_check_register_suffix): Likewise.
2440         (stap_check_register_indirection_suffix): Likewise.
2441         (stap_parse_register_operand): Likewise.
2442         (stap_parse_single_operand): Likewise.
2443         (stap_parse_argument_1): Likewise.
2444         (stap_probe::get_argument_count): Likewise.
2445         (stap_is_operator): Likewise.
2446
2447 2019-05-16  Tom Tromey  <tromey@adacore.com>
2448
2449         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2450         keyword to foreach.
2451
2452 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2453
2454         * linux-thread-db.c (try_thread_db_load_1): Change return type
2455         to bool.
2456         (try_thread_db_load): Likewise.
2457         (try_thread_db_load_from_pdir_1): Likewise.
2458         (try_thread_db_load_from_pdir): Likewise.
2459         (try_thread_db_load_from_sdir): Likewise.
2460         (try_thread_db_load_from_dir): Likewise.
2461         (thread_db_load_search): Likewise.
2462         (has_libpthread): Likewise.
2463         (thread_db_load): Likewise.
2464
2465 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2466
2467         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2468         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2469         NULL, and complain/return if that's the case.
2470
2471 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2472
2473         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2474         (advance, posn, abstract_read_memory): New functions.
2475         [struct mem_read_abstraction]: New struct.
2476         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2477
2478 2019-05-14  Tom Tromey  <tromey@adacore.com>
2479
2480         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2481         value is not lval_memory.
2482
2483 2019-05-14  Tom Tromey  <tromey@adacore.com>
2484
2485         * solib.c (info_sharedlibrary_command): Style the file name.
2486
2487 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2488
2489         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2490         (aarch64_vnv_type): Likewise.
2491         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2492         * common/tdesc.c: Likewise.
2493         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2494         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2495         * features/aarch64-fpu.xml: Add ieee half view.
2496         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2497         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2498         * gdbtypes.h (struct builtin_type): Likewise.
2499         (struct objfile_type): Likewise.
2500
2501 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2502
2503         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2504         typo.
2505         * location.h (string_to_event_location): Likewise.
2506
2507 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2508
2509         GDB 8.3 released.
2510
2511 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2512
2513         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2514         New variable declaration.
2515         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2516         New variable.
2517         (print_one_breakpoint): Use ui_out::test_flags and new global
2518         variable to compute use_fixed_output.
2519         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2520         Remove.
2521         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2522         (mi_multi_location_breakpoint_output_fixed): Remove.
2523         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2524         new variable.
2525         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2526         fix_multi_location_breakpoint_output flag if version >= 3.
2527         * ui-out.h (enum ui_out_flag)
2528         <fix_multi_location_breakpoint_output>: New enumerator.
2529
2530 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2531
2532         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2533
2534 2019-05-10  Tom Tromey  <tromey@adacore.com>
2535
2536         * ada-lang.c (catch_ada_completer): New function.
2537         (_initialize_ada_language): Use it.
2538
2539 2019-05-10  Tom Tromey  <tromey@adacore.com>
2540
2541         * thread.c (print_thread_info): Make "requested_threads" const.
2542         * gdbthread.h (print_thread_info): Make "requested_threads"
2543         const.
2544         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2545         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2546
2547 2019-05-08  Tom Tromey  <tom@tromey.com>
2548
2549         * gdbtypes.c (objfile_type_data): Change type.
2550         (objfile_type, _initialize_gdbtypes): Update.
2551
2552 2019-05-08  Tom Tromey  <tom@tromey.com>
2553
2554         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2555         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2556         (_initialize_dwarf2_frame): Update.
2557
2558 2019-05-08  Tom Tromey  <tom@tromey.com>
2559
2560         * objc-lang.c (objc_objfile_data): Change type.
2561         (find_methods): Update.
2562         (_initialize_objc_lang): Remove.
2563
2564 2019-05-08  Tom Tromey  <tom@tromey.com>
2565
2566         * stabsread.c (rs6000_builtin_type_data): Change type.
2567         (rs6000_builtin_type, _initialize_stabsread): Update.
2568
2569 2019-05-08  Tom Tromey  <tom@tromey.com>
2570
2571         * mips-tdep.c (mips_pdr_data): Remove.
2572         (_initialize_mips_tdep): Update.
2573
2574 2019-05-08  Tom Tromey  <tom@tromey.com>
2575
2576         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2577         (hppa_init_objfile_priv_data, read_unwind_info)
2578         (find_unwind_entry, _initialize_hppa_tdep): Update.
2579
2580 2019-05-08  Tom Tromey  <tom@tromey.com>
2581
2582         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2583         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2584         on obstack.
2585         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2586
2587 2019-05-08  Tom Tromey  <tom@tromey.com>
2588
2589         * mdebugread.c (basic_type_data): Change type.
2590         (basic_type, _initialize_mdebugread): Update.
2591
2592 2019-05-08  Tom Tromey  <tom@tromey.com>
2593
2594         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2595
2596 2019-05-08  Tom Tromey  <tom@tromey.com>
2597
2598         * nto-tdep.c (nto_inferior_data_reg): Change type.
2599         (nto_inferior_data): Update.
2600         (nto_inferior_data_cleanup, nto_new_inferior_data)
2601         (_initialize_nto_tdep): Remove.
2602         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2603
2604 2019-05-08  Tom Tromey  <tom@tromey.com>
2605
2606         * ada-lang.c (struct ada_inferior_data): Add initializers.
2607         (ada_inferior_data): Change type.
2608         (ada_inferior_data_cleanup): Remove.
2609         (get_ada_inferior_data, ada_inferior_exit)
2610         (struct ada_pspace_data): Add initializers, destructor.
2611         (ada_pspace_data_handle): Change type.
2612         (get_ada_pspace_data): Update.
2613         (ada_pspace_data_cleanup): Remove.
2614
2615 2019-05-08  Tom Tromey  <tom@tromey.com>
2616
2617         * coffread.c (struct coff_symfile_info): Add initializers.
2618         (coff_objfile_data_key): Move lower.  Change type.
2619         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2620         Update.
2621         (coff_free_info): Remove.
2622
2623 2019-05-08  Tom Tromey  <tom@tromey.com>
2624
2625         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2626         (fbsd_pspace_data_handle): Move lower.  Change type.
2627         (get_fbsd_pspace_data): Update.
2628         (fbsd_pspace_data_cleanup): Remove.
2629         (_initialize_fbsd_tdep): Update.
2630
2631 2019-05-08  Tom Tromey  <tom@tromey.com>
2632
2633         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2634         (get_ada_tasks_pspace_data): Update.
2635         (ada_tasks_pspace_data_cleanup): Remove.
2636         (_initialize_tasks): Update.
2637         (ada_tasks_inferior_data_handle): Change type.
2638         (get_ada_tasks_inferior_data): Update.
2639         (ada_tasks_inferior_data_cleanup): Remove.
2640         (struct ada_tasks_pspace_data): Add initializers.
2641
2642 2019-05-08  Tom Tromey  <tom@tromey.com>
2643
2644         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2645         * symfile-debug.c (debug_sym_get_probes): Change type.
2646         * stap-probe.c (handle_stap_probe):
2647         (stap_static_probe_ops::get_probes): Change type.
2648         * probe.h (class static_probe_ops) <get_probes>: Change type.
2649         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2650         (parse_probes_in_pspace): Update.
2651         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2652         Update.
2653         (any_static_probe_ops::get_probes): Change type.
2654         * elfread.c (elfread_data): New typedef.
2655         (probe_key): Change type.
2656         (elf_get_probes): Likewise.  Update.
2657         (probe_key_free): Remove.
2658         (_initialize_elfread): Update.
2659         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2660         Change type.
2661         (dtrace_process_dof_probe, dtrace_process_dof)
2662         (dtrace_static_probe_ops::get_probe): Change type.
2663
2664 2019-05-08  Tom Tromey  <tom@tromey.com>
2665
2666         * xcoffread.c (struct xcoff_symfile_info): Rename from
2667         coff_symfile_info.  Add initializers.
2668         (xcoff_objfile_data_key): Move lower.  Change type.
2669         (XCOFF_DATA): Rewrite.
2670         (xcoff_free_info): Remove.
2671         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2672         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2673         (xcoff_initial_scan): Update.
2674
2675 2019-05-08  Tom Tromey  <tom@tromey.com>
2676
2677         * solib-svr4.c (struct svr4_info): Add initializers and
2678         destructor.
2679         <probes_table>: Now an htab_up.
2680         (solib_svr4_pspace_data): Change type.
2681         (free_probes_table): Simplify.
2682         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2683         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2684         (probes_table_remove_objfile_probes, register_solib_event_probe)
2685         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2686         (_initialize_svr4_solib): Update.
2687
2688 2019-05-08  Tom Tromey  <tom@tromey.com>
2689
2690         * remote.c (remote_pspace_data): Change type.
2691         (remote_pspace_data_cleanup): Remove.
2692         (get_remote_exec_file, set_pspace_remote_exec_file)
2693         (_initialize_remote): Update.
2694
2695 2019-05-08  Tom Tromey  <tom@tromey.com>
2696
2697         * breakpoint.c (breakpoint_objfile_key): Change type.
2698         (get_breakpoint_objfile_data): Update.
2699         (free_breakpoint_objfile_data): Remove.
2700         (_initialize_breakpoint): Update.
2701
2702 2019-05-08  Tom Tromey  <tom@tromey.com>
2703
2704         * linux-tdep.c (struct linux_info): Add initializers.
2705         (linux_inferior_data): Move.  Change type.
2706         (invalidate_linux_cache_inf): Update.
2707         (linux_inferior_data_cleanup): Remove.
2708         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2709
2710 2019-05-08  Tom Tromey  <tom@tromey.com>
2711
2712         * auxv.c (auxv_inferior_data): Move.  Change type.
2713         (auxv_inferior_data_cleanup): Remove.
2714         (invalidate_auxv_cache_inf): Rewrite.
2715         (get_auxv_inferior_data, _initialize_auxv): Update.
2716
2717 2019-05-08  Tom Tromey  <tom@tromey.com>
2718
2719         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2720         (symfile_debug_objfile_data_key): Change type.
2721         (symfile_debug_installed, debug_qf_has_symbols)
2722         (debug_qf_find_last_source_symtab)
2723         (debug_qf_forget_cached_source_info)
2724         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2725         (debug_qf_print_stats, debug_qf_dump)
2726         (debug_qf_expand_symtabs_for_function)
2727         (debug_qf_expand_all_symtabs)
2728         (debug_qf_expand_symtabs_with_fullname)
2729         (debug_qf_map_matching_symbols)
2730         (debug_qf_expand_symtabs_matching)
2731         (debug_qf_find_pc_sect_compunit_symtab)
2732         (debug_qf_map_symbol_filenames)
2733         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2734         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2735         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2736         (debug_sym_read_linetable, debug_sym_relocate): Update.
2737         (symfile_debug_free_objfile): Remove.
2738         (install_symfile_debug_logging, _initialize_symfile_debug):
2739         Update.
2740
2741 2019-05-08  Tom Tromey  <tom@tromey.com>
2742
2743         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2744         allocate_on_obstack.
2745         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2746         (get_dwarf2_per_objfile): Update.
2747         (set_dwarf2_per_objfile): Remove.
2748         (dwarf2_has_info, dwarf2_get_section_info): Update.
2749         (dwarf2_free_objfile): Remove.
2750         (_initialize_dwarf2_read): Update.
2751
2752 2019-05-08  Tom Tromey  <tom@tromey.com>
2753
2754         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2755         initializers.
2756         <unsupported_script_warning_printed,
2757         script_not_found_warning_printed>: Now bool.
2758         (auto_load_pspace_data): Change type.
2759         (~auto_load_pspace_info): Rename from
2760         auto_load_pspace_data_cleanup.
2761         (get_auto_load_pspace_data, init_loaded_scripts_info)
2762         (clear_section_scripts, maybe_print_unsupported_script_warning)
2763         (maybe_print_script_not_found_warning, _initialize_auto_load):
2764         Update.
2765
2766 2019-05-08  Tom Tromey  <tom@tromey.com>
2767
2768         * objfiles.c (objfile_pspace_info): Add destructor and
2769         initializers.
2770         (objfiles_pspace_data): Change type.
2771         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2772         (get_objfile_pspace_data): Update.
2773         (objfiles_bfd_data): Change type.
2774         (get_objfile_bfd_data): Update.
2775         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2776
2777 2019-05-08  Tom Tromey  <tom@tromey.com>
2778
2779         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2780         Change type.
2781         (get_catch_syscall_inferior_data): Update.
2782         (catch_syscall_inferior_data_cleanup): Remove.
2783         (_initialize_break_catch_syscall): Update.
2784
2785 2019-05-08  Tom Tromey  <tom@tromey.com>
2786
2787         * inflow.c (struct terminal_info): Add destructor and
2788         initializers.
2789         (inflow_inferior_data): Change type.
2790         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2791         (get_inflow_inferior_data, inflow_inferior_exit)
2792         (swap_terminal_info, _initialize_inflow): Update.
2793
2794 2019-05-08  Tom Tromey  <tom@tromey.com>
2795
2796         * target-dcache.c (target_dcache_cleanup): Remove.
2797         (target_dcache_aspace_key): Change type.
2798         (target_dcache_init_p, target_dcache_invalidate)
2799         (target_dcache_get, target_dcache_get_or_init)
2800         (_initialize_target_dcache): Update.
2801         * dcache.h (struct dcache_deleter): New.
2802
2803 2019-05-08  Tom Tromey  <tom@tromey.com>
2804
2805         * symtab.c (struct symbol_cache): Add destructor and
2806         initializers.
2807         (symbol_cache_key): Move.  Change type.
2808         (make_symbol_cache, free_symbol_cache): Remove.
2809         (get_symbol_cache): Update.
2810         (symbol_cache_cleanup): Remove.
2811         (ALL_PSPACES, symbol_cache_flush)
2812         (maintenance_print_symbol_cache)
2813         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2814         Update.
2815
2816 2019-05-08  Tom Tromey  <tom@tromey.com>
2817
2818         * symtab.c (struct main_info): Add destructor and initializers.
2819         (main_progspace_key): Move.  Change type.
2820         (get_main_info): Update.
2821         (main_info_cleanup): Remove.
2822         (_initialize_symtab): Update.
2823
2824 2019-05-08  Tom Tromey  <tom@tromey.com>
2825
2826         * registry.h (DECLARE_REGISTRY): Define the _key class.
2827
2828 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * NEWS: Merge two 'New commands' sections.
2831
2832 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2833
2834         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2835         parameter and use Ada language definition instead.
2836         (ada_val_print_ptr): Remove unused language parameter.
2837         (ada_val_print_num): Remove language parameter and use Ada language
2838         definition instead.
2839         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2840         parameter.
2841         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2842         parameter and use Ada language definition instead.
2843         (ada_val_print_1): Update all ada_val_print_xxx calls.
2844         Remove language parameter.
2845         (ada_val_print): Update ada_val_print_1 call.
2846
2847 2019-05-08  Tom Tromey  <tromey@adacore.com>
2848
2849         * remote.c (remote_hw_watchpoint_limit)
2850         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2851         Now static.
2852
2853 2019-05-08  Tom Tromey  <tromey@adacore.com>
2854
2855         * maint.c (_initialize_maint_cmds): Move initialization code to
2856         remote.c.
2857         (watchdog, show_watchdog): Move to remote.c.
2858         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2859         "watchdog" static.
2860         (_initialize_remote): Move initialization code from maint.c.
2861         * defs.h (watchdog): Don't declare.
2862
2863 2019-05-08  Tom Tromey  <tromey@adacore.com>
2864
2865         * tui/tui-interp.c: Include main.h.
2866         * interps.c: Include main.h.
2867         * main.h (interpreter_p): Declare.
2868         * defs.h (interpreter_p): Don't declare.
2869
2870 2019-05-08  Tom Tromey  <tromey@adacore.com>
2871
2872         * dwarf2loc.c: Include dwarf2read.h.
2873         * defs.h (read_unsigned_leb128): Don't declare.
2874         * dwarf2read.h (read_unsigned_leb128): Declare.
2875
2876 2019-05-08  Tom Tromey  <tromey@adacore.com>
2877
2878         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2879         method.
2880
2881 2019-05-08  Tom Tromey  <tromey@adacore.com>
2882
2883         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2884         when no wrap column is set.
2885
2886 2019-05-08  Tom Tromey  <tromey@adacore.com>
2887
2888         * c-lang.c (c_get_string): Handle non-C-style arrays.
2889
2890 2019-05-08  Tom Tromey  <tromey@adacore.com>
2891
2892         * typeprint.c (print_offset_data::update): Print the bit offset,
2893         not the number of bits remaining.
2894
2895 2019-05-08  Tom Tromey  <tromey@adacore.com>
2896
2897         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2898         padding at end of comment.
2899
2900 2019-05-08  Tom Tromey  <tromey@adacore.com>
2901
2902         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2903         Compare main types.
2904
2905 2019-05-06  Tom Tromey  <tom@tromey.com>
2906
2907         * common/scoped_mmap.c: Include common-defs.h.
2908         * common/scoped_mmap.h: Don't include config.h.
2909
2910 2019-05-04  Tom Tromey  <tom@tromey.com>
2911
2912         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2913         (struct aarch64_call_info): Add initializers.
2914         <si>: Now a std::vector.
2915         (pass_on_stack, aarch64_push_dummy_call): Update.
2916
2917 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2918             Tom Tromey  <tom@tromey.com>
2919
2920         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2921         (ppc_threads): Now a std::vector.  Now static.
2922         (hwdebug_find_thread_points_by_tid)
2923         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2924         Update.
2925
2926 2019-05-04  Tom Tromey  <tom@tromey.com>
2927
2928         * arc-tdep.c (arc_tdesc_init): Return bool.
2929
2930 2019-05-04  Tom Tromey  <tom@tromey.com>
2931
2932         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2933         Use gdb_assert_not_reached.
2934
2935 2019-05-04  Tom Tromey  <tom@tromey.com>
2936
2937         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2938         "false".
2939
2940 2019-05-04  Tom Tromey  <tom@tromey.com>
2941
2942         * arc-tdep.c (arc_tdesc_init): Use bool.
2943
2944 2019-05-04  Tom Tromey  <tom@tromey.com>
2945
2946         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2947
2948 2019-05-04  Tom Tromey  <tom@tromey.com>
2949
2950         * cli/cli-cmds.c (valid_command_p): Return bool.
2951
2952 2019-05-04  Tom Tromey  <tom@tromey.com>
2953
2954         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2955         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2956
2957 2019-05-04  Raul Tambre  <raul@tambre.ee>
2958
2959         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2960         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2961         operator for comparison.
2962
2963 2019-05-04  Tom Tromey  <tom@tromey.com>
2964
2965         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2966         (lookup_partial_symbol, print_partial_symbols)
2967         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2968         (psymbol_compare): Update.
2969         (add_psymbol_to_bcache): Clear the entire psymbol.
2970         (maintenance_check_psymtabs): Update.
2971         * psympriv.h (struct partial_symbol): Don't derive from
2972         general_symbol_info.
2973         <obj_section, unrelocated_address, address,
2974         set_unrelocated_address>: Update.
2975         <ginfo>: New member.
2976         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2977         (debug_names::write_psymbols): Update.
2978
2979 2019-05-04  Tom de Vries  <tdevries@suse.de>
2980
2981         * contrib/cc-with-tweaks.sh: Support -n arg.
2982
2983 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2984
2985         * corelow.c (core_target::detach): Ensure frame cache and
2986         register caches are cleared.
2987         inferior.c (exit_inferior_1): Likewise.
2988
2989 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2990             Tom Tromey  <tom@tromey.com>
2991
2992         * dictionary.c (collate_pending_symbols_by_language): Remove
2993         "struct" from foreach.
2994         * symtab.c (lookup_global_symbol_from_objfile)
2995         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2996         foreach.
2997         * ser-tcp.c (net_open): Remove "struct" from foreach.
2998         * objfiles.c (objfile_relocate, objfile_rebase)
2999         (objfile_has_symbols): Remove "struct" from foreach.
3000         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3001         from foreach.
3002         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3003         foreach.
3004         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3005         "struct" from foreach.
3006         * ada-lang.c (create_excep_cond_exprs)
3007         (ada_exception_catchpoint_cond_string): Remove "struct" from
3008         foreach.
3009
3010 2019-05-03  Tom Tromey  <tromey@adacore.com>
3011
3012         * ada-exp.y (convert_char_literal): Check suffix of each
3013         enumerator.
3014
3015 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3016
3017         PR ada/21406:
3018         * ada-exp.y (yywrap): Don't define.
3019         * ada-lex.l (%option): Add noyywrap
3020         (yywrap): Remove.
3021
3022 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3023
3024         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3025         _WIN32_WINNT to the XP level, unless already defined to a higher
3026         level.
3027
3028         * unittests/parse-connection-spec-selftests.c:
3029         * ser-tcp.c:
3030         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3031         override.
3032
3033         * symfile.c (find_separate_debug_file): Remove colon from the
3034         drive spec of DOS/Windows file names of the target, so that the
3035         file name produced from DEBUGDIR and the target's directory will
3036         be valid on DOS/Windows systems.
3037
3038 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3039
3040         * rust-lang.c (val_print_struct): Handle printing structures
3041         containing strings.
3042
3043 2019-05-02  Tom Tromey  <tromey@adacore.com>
3044
3045         * valarith.c (_initialize_valarith): Remove.
3046
3047 2019-05-01  Tom Tromey  <tromey@adacore.com>
3048
3049         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3050         bitfields.
3051
3052 2019-05-01  Tom Tromey  <tromey@adacore.com>
3053
3054         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3055         for big-endian copies.
3056
3057 2019-04-30  Ali Tamur  <tamur@google.com>
3058         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3059         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3060         (read_3_bytes): New function.
3061
3062 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3063
3064         * windows-nat.c (main_thread_id): Delete.
3065         (handle_output_debug_string): Replace main_thread_id by
3066         current_event.dwThreadId.
3067         (fake_create_process): Likewise.
3068         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3069         Do not set main_thread_id.
3070         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3071         current_event.dwThreadId.
3072         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3073
3074 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3075
3076         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3077         Use current_event.dwThreadId instead of main_thread_id.
3078
3079 2019-04-30  Tom Tromey  <tromey@adacore.com>
3080
3081         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3082         (create_excep_cond_exprs): Iterate over program spaces.
3083         (ada_exception_catchpoint_cond_string): Examine all minimal
3084         symbols for exception types.
3085
3086 2019-04-30  Tom Tromey  <tromey@adacore.com>
3087
3088         PR c++/24470:
3089         * dwarf2read.c (process_structure_scope): Handle case where type
3090         has template parameters but no symbol was created.
3091
3092 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3093             Chris January  <chris.january@arm.com>
3094
3095         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3096         qualifier.
3097         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3098
3099 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * f-typeprint.c (f_print_type): Update rules for printing
3102         whitespace.
3103         (f_type_print_varspec_suffix): Likewise.
3104
3105 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3106             Chris January  <chris.january@arm.com>
3107
3108         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3109         function arguments.
3110
3111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * f-lang.c (build_fortran_types): Change name of void type to
3114         lower case.
3115         * f-typeprint.c (f_type_print_base): Print the name of the void
3116         type, rather than a fixed string.
3117         * f-valprint.c (f_decorations): Use lower case void string.
3118
3119 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3120             Chris January  <chris.january@arm.com>
3121
3122         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3123         types for Fortran.
3124
3125 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3126             Chris January  <chris.january@arm.com>
3127             David Lecomber  <david.lecomber@arm.com>
3128
3129         * f-exp.y (BINOP_INTRINSIC): New token.
3130         (exp): New parser rule handling BINOP_INTRINSIC.
3131         (f77_keywords): Add new builtin procedures.
3132         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3133         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3134         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3135         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3136         (print_unop_subexp_f): New function.
3137         (print_binop_subexp_f): New function.
3138         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3139         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3140         (dump_subexp_body_f): Likewise.
3141         (operator_check_f): Likewise.
3142         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3143         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3144
3145 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3148         UNOP_KIND.
3149         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3150         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3151         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3152         (operator_length_f): New fuction.
3153         (print_subexp_f): New function.
3154         (op_name_f): New function.
3155         (dump_subexp_body_f): New function.
3156         (operator_check_f): New function.
3157         (exp_descriptor_f): Replace standard expression handling functions
3158         with new functions.
3159         * gdb/fortran-operator.def: New file.
3160         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3161         * gdb/std-operator.def: Remove UNOP_KIND.
3162
3163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3164
3165         * std-operator.def: Remove unbalanced, stray double quote
3166         character.
3167
3168 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3169             Chris January  <chris.january@arm.com>
3170             Daniel Everett  <daniel.everett@arm.com>
3171             Nick Forrington  <nick.forrington@arm.com>
3172             Richard Bunt  <richard.bunt@arm.com>
3173
3174         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3175         of depth when printing anonymous structs or unions.
3176         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3177         Don't print either the top-level value, or the children if the
3178         max-depth is exceeded.
3179         (ppscm_print_children): When printing the key of a map, allow one
3180         extra level of depth.
3181         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3182         print either the top-level value, or the children if the max-depth
3183         is exceeded.
3184         (print_children): When printing the key of a map, allow one extra
3185         level of depth.
3186         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3187         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3188         (user_print_options): Initialise max_depth field.
3189         (val_print_scalar_or_string_type_p): New function.
3190         (val_print): Check to see if the max depth has been reached.
3191         (val_print_check_max_depth): Define new function.
3192         (show_print_max_depth): New function.
3193         (_initialize_valprint): Add 'print max-depth' option.
3194         * valprint.h (struct value_print_options) <max_depth>: New field.
3195         (val_print_check_max_depth): Declare new function.
3196         * NEWS: Document new feature.
3197
3198 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * ada-lang.c (ada_language_defn): Initialise new field.
3201         * c-lang.c (c_is_string_type_p): New function.
3202         (c_language_defn): Initialise new field.
3203         (cplus_language_defn): Initialise new field.
3204         (asm_language_defn): Initialise new field.
3205         (minimal_language_defn): Initialise new field.
3206         * c-lang.h (c_is_string_type_p): Declare new function.
3207         * d-lang.c (d_language_defn): Initialise new field.
3208         * f-lang.c (f_is_string_type_p): New function.
3209         (f_language_defn): Initialise new field.
3210         * go-lang.c (go_is_string_type_p): New function.
3211         (go_language_defn): Initialise new field.
3212         * language.c (default_is_string_type_p): New function.
3213         (unknown_language_defn): Initialise new field.
3214         (auto_language_defn): Initialise new field.
3215         * language.h (struct language_defn) <la_is_string_type_p>: New
3216         member variable.
3217         (default_is_string_type_p): Declare new function.
3218         * m2-lang.c (m2_language_defn): Initialise new field.
3219         * objc-lang.c (objc_language_defn): Initialise new field.
3220         * opencl-lang.c (opencl_language_defn): Initialise new field.
3221         * p-lang.c (pascal_is_string_type_p): New function.
3222         (pascal_language_defn): Initialise new field.
3223         * rust-lang.c (rust_is_string_type_p): New function.
3224         (rust_language_defn): Initialise new field.
3225
3226 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3229         New field.
3230         * ada-lang.c (ada_language_defn): Initialise new field.
3231         * c-lang.c (c_language_defn): Likewise.
3232         (cplus_language_defn): Likewise.
3233         (asm_language_defn): Likewise.
3234         (minimal_language_defn): Likewise.
3235         * d-lang.c (d_language_defn): Likewise.
3236         * f-lang.c (f_language_defn): Likewise.
3237         * go-lang.c (go_language_defn): Likewise.
3238         * language.c (unknown_language_defn): Likewise.
3239         (auto_language_defn): Likewise.
3240         * m2-lang.c (m2_language_defn): Likewise.
3241         * objc-lang.c (objc_language_defn): Likewise.
3242         * opencl-lang.c (opencl_language_defn): Likewise.
3243         * p-lang.c (pascal_language_defn): Likewise.
3244         * rust-lang.c (rust_language_defn): Likewise.
3245
3246 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3247
3248         * ada-lang.c (ada_is_character_type): Change return type to bool.
3249         (ada_is_string_type): Likewise.
3250         * ada-lang.h (ada_is_character_type): Update declaration
3251         (ada_is_string_type): Likewise.
3252
3253 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3254
3255         Support style in 'frame|thread apply'
3256
3257         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3258         * record.c (record_start, record_stop): Update callers of
3259         execute_command_to_string with false.
3260         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3261         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3262         methods.
3263         (class string_file): New constructor with term_out parameter.
3264         Override methods term_out and can_emit_style_escape.  New member
3265         term_out.
3266         (class stdio_file): Override can_emit_style_escape.
3267         (class tee_file): Override term_out and can_emit_style_escape.
3268         * utils.h (can_emit_style_escape): Remove.
3269         * utils.c (can_emit_style_escape): Likewise.
3270         Update all callers of can_emit_style_escape (SOMESTREAM) to
3271         SOMESTREAM->can_emit_style_escape.
3272         * source-cache.c (source_cache::get_source_lines): Likewise.
3273         * stack.c (frame_apply_command_count): Call execute_command_to_string
3274         passing the term_out characteristic of the current gdb_stdout.
3275         * thread.c (thr_try_catch_cmd): Likewise.
3276         * top.c (execute_command_to_string): pass term_out parameter
3277         to construct the string_file for the command output.
3278         * ui-file.c (term_cli_styling): New function (most code moved
3279         from utils.c can_emit_style_escape).
3280         (string_file::string_file, string_file::can_emit_style_escape,
3281         stdio_file::can_emit_style_escape, tee_file::term_out,
3282         tee_file::can_emit_style_escape): New functions.
3283
3284 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3285
3286         * NEWS: Mention the new set|show may-call-functions.
3287         * infcall.c (may_call_functions_p): New variable.
3288         (show_may_call_functions_p): New function.
3289         (call_function_by_hand_dummy): Throws an error if not
3290         may-call-functions.
3291         (_initialize_infcall): Call add_setshow_boolean_cmd for
3292         may-call-functions.
3293
3294 2019-04-25  Keith Seitz  <keiths@redhat.com>
3295
3296         PR c++/24367
3297         * cp-support.c (inspect_type): Don't attempt substitutions
3298         of symbol with the same name.
3299
3300 2019-04-25  Tom Tromey  <tromey@adacore.com>
3301
3302         PR gdb/24475:
3303         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3304         static.
3305
3306 2019-04-25  Tom Tromey  <tromey@adacore.com>
3307
3308         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3309         rvalue reference.
3310         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3311         (gdb_xml_parser::parse): Use std::move.
3312         * python/python-internal.h (gdbpy_convert_exception): Take a const
3313         reference.
3314         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3315         std::move.
3316         * python/py-utils.c (gdbpy_convert_exception): Take a const
3317         reference.
3318         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3319         Use std::move.
3320         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3321         Use std::move.
3322         * mi/mi-main.c (mi_print_exception): Take a const reference.
3323         * main.c (handle_command_errors): Take a const reference.
3324         * linespec.c (parse_linespec): Use std::move.
3325         * infcall.c (run_inferior_call): Use std::move.
3326         (call_function_by_hand_dummy): Use std::move.
3327         * exec.c (try_open_exec_file): Use std::move.
3328         * exceptions.h (exception_print, exception_fprintf)
3329         (exception_print_same): Update.
3330         * exceptions.c (print_exception, exception_print)
3331         (exception_fprintf, exception_print_same): Change parameters to
3332         const reference.
3333         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3334         * common/new-op.c: Use std::move.
3335         * common/common-exceptions.h (struct gdb_exception): Add move
3336         constructor.
3337         (struct gdb_exception_error, struct gdb_exception_quit, struct
3338         gdb_quit_bad_alloc): Change constructor to move constructor.
3339         (throw_exception): Change parameter to rvalue reference.
3340         * common/common-exceptions.c (throw_exception): Take rvalue
3341         reference.
3342         * cli/cli-interp.c (safe_execute_command): Use std::move.
3343         * breakpoint.c (insert_bp_location, location_to_sals): Use
3344         std::move.
3345
3346 2019-04-25  Tom Tromey  <tromey@adacore.com>
3347
3348         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3349         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3350         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3351         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3352         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3353         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3354         guile/scm-value.c: Use unpack.
3355         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3356         gdbscm_gdb_exception.
3357         (gdbscm_throw_gdb_exception): Likewise.
3358         (struct gdbscm_gdb_exception): New.
3359         (unpack): New function.
3360         (gdbscm_wrap): Use unpack.
3361
3362 2019-04-25  Tom Tromey  <tromey@adacore.com>
3363
3364         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3365         (gdb_rl_callback_handler): Use std::move.
3366         * common/common-exceptions.h (struct gdb_exception): Add move
3367         assignment operator.
3368         (throw_exception_sjlj): Change "exception" to const reference.
3369         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3370         (throw_exception_sjlj): Change "exception" to const reference.
3371
3372 2019-04-25  Tom Tromey  <tromey@adacore.com>
3373
3374         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3375         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3376         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3377         Update.
3378         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3379         Update.
3380         * mi/mi-interp.c (mi_interp::exec): Update.
3381         * linespec.c (parse_linespec): Update.
3382         * infcall.c (run_inferior_call): Update.
3383         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3384         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3385         (gdbscm_lookup_global_symbol): Update.
3386         * guile/scm-param.c (gdbscm_parameter_value): Update.
3387         * guile/scm-frame.c (gdbscm_frame_read_register)
3388         (gdbscm_frame_read_var): Update.
3389         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3390         * exec.c (try_open_exec_file): Update.
3391         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3392         (gdb_rl_callback_handler): Update.
3393         * common/common-exceptions.h (exception_none): Don't declare.
3394         * common/common-exceptions.c (exception_none): Don't define.
3395         (struct catcher) <exception>: Update.
3396         * cli/cli-interp.c (safe_execute_command): Update.
3397         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3398
3399 2019-04-25  Ali Tamur  <tamur@google.com>
3400
3401         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3402         (read_attribute_value): Likewise.
3403         (dwarf2_read_addr_index): Update comment.
3404         (read_str_index): Add DW_FORM_strx.
3405         (dwarf2_string_attr): Likewise.
3406         (dwarf2_const_value_attr): Likewise.
3407         (dump_die_shallow): Likewise.
3408         (dwarf2_fetch_constant_bytes): Likewise.
3409         (skip_form_bytes): Likewise.
3410         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3411
3412 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3413
3414         PR corefiles/11608
3415         PR corefiles/18187
3416         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3417         OFFSET.  Verify if current mapping contains an ELF header.
3418         (linux_find_memory_regions_full): Adjust call to
3419         dump_mapping_p.
3420
3421 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3422             Kang Li <kanglictf@gmail.com>
3423
3424         PR gdb/21600
3425
3426         * dwarf2-frame.c (read_initial_length): Be consistent about using
3427         unsigned representation of length.
3428         (decode_frame_entry_1): Likewise.  Check for wraparound of
3429         end pointer as well as buffer overflow.
3430
3431 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3432
3433         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3434         "vq".
3435
3436 2019-04-24  Tom Tromey  <tromey@adacore.com>
3437
3438         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3439
3440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3441
3442         * s12z-tdep.c (s12z_unwind_pc): Delete.
3443         (s12z_unwind_sp): Delete.
3444         (s12z_gdbarch_init): Don't register deleted functions with
3445         gdbarch.
3446
3447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * rl78-tdep.c (rl78_unwind_sp): Delete.
3450         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3451
3452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3453
3454         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3455         (xstormy16_unwind_pc): Delete.
3456         (xstormy16_dummy_id): Delete.
3457         (xstormy16_gdbarch_init): Don't register deleted functions with
3458         gdbarch.
3459
3460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * vax-tdep.c (vax_unwind_pc): Delete.
3463         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3464
3465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3466
3467         * v850-tdep.c (v850_unwind_sp): Delete.
3468         (v850_unwind_pc): Delete.
3469         (v850_dummy_id): Delete.
3470         (v850_gdbarch_init): Don't register deleted functions with
3471         gdbarch.
3472
3473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3476         (tilegx_unwind_pc): Delete.
3477         (tilegx_unwind_dummy_id): Delete.
3478         (tilegx_gdbarch_init): Don't register deleted functions with
3479         gdbarch.
3480
3481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3482
3483         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3484         (tic6x_dummy_id): Delete.
3485         (tic6x_gdbarch_init): Don't register deleted functions with
3486         gdbarch.
3487
3488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * sparc-tdep.c (sparc_unwind_pc): Delete.
3491         (sparc32_gdbarch_init): Don't register deleted function with
3492         gdbarch.
3493
3494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3495
3496         * sh-tdep.c (sh_unwind_sp): Delete.
3497         (sh_unwind_pc): Delete.
3498         (sh_dummy_id): Delete.
3499         (sh_gdbarch_init): Don't register deleted functions with
3500         gdbarch.
3501
3502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3503
3504         * score-tdep.c (score_unwind_sp): Delete.
3505         (score_unwind_pc): Delete.
3506         (score_dummy_id): Delete.
3507         (score_gdbarch_init): Don't register deleted functions with
3508         gdbarch.
3509
3510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3511
3512         * rx-tdep.c (rx_unwind_pc): Delete.
3513         (rx_unwind_sp): Delete.
3514         (rx_dummy_id): Delete.
3515         (rx_gdbarch_init): Don't register deleted functions with
3516         gdbarch.  Update comment.
3517
3518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3521         (rs6000_dummy_id): Delete.
3522         (rs6000_gdbarch_init): Don't register deleted functions with
3523         gdbarch.
3524
3525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * or1k-tdep.c (or1k_dummy_id): Delete.
3528         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3529
3530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * nios2-tdep.c (nios2_dummy_id): Delete.
3533         (nios2_unwind_sp): Delete.
3534         (nios2_gdbarch_init): Don't register deleted functions with
3535         gdbarch.
3536
3537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * nds32-tdep.c (nds32_dummy_id): Delete.
3540         (nds32_unwind_pc): Delete.
3541         (nds32_unwind_sp): Delete.
3542         (nds32_gdbarch_init): Don't register deleted functions with
3543         gdbarch.
3544
3545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * msp430-tdep.c (msp430_unwind_pc): Delete.
3548         (msp430_unwind_sp): Delete.
3549         (msp430_dummy_id): Delete.
3550         (msp430_gdbarch_init): Don't register deleted functions with
3551         gdbarch.
3552
3553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * moxie-tdep.c (moxie_unwind_sp): Delete.
3556         (moxie_unwind_pc): Delete.
3557         (moxie_dummy_id): Delete.
3558         (moxie_gdbarch_init): Don't register deleted functions with
3559         gdbarch.
3560
3561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3564         (mn10300_unwind_pc): Delete.
3565         (mn10300_unwind_sp): Delete.
3566         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3567         mn10300_unwind_sp.
3568         (mn10300_frame_unwind_init): Don't register deleted functions with
3569         gdbarch.
3570
3571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3572
3573         * mep-tdep.c (mep_unwind_pc): Delete.
3574         (mep_unwind_sp): Delete.
3575         (mep_dummy_id): Delete.
3576         (mep_gdbarch_init): Don't register deleted functions with
3577         gdbarch.
3578
3579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3582         (m68hc11_unwind_sp): Delete.
3583         (m68hc11_gdbarch_init): Don't register deleted functions with
3584         gdbarch.
3585
3586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * m32r-tdep.c (m32r_unwind_sp): Delete.
3589         (m32r_unwind_pc): Delete.
3590         (m32r_dummy_id): Delete.
3591         (m32r_gdbarch_init): Don't register deleted functions with
3592         gdbarch.
3593
3594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3595
3596         * m32c-tdep.c (m32c_unwind_pc): Delete.
3597         (m32c_unwind_sp): Delete.
3598         (m32c_dummy_id): Delete.
3599         (m32c_gdbarch_init): Don't register deleted functions with
3600         gdbarch.
3601
3602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3605         (lm32_unwind_pc): Delete.
3606         (lm32_dummy_id): Delete.
3607         (lm32_gdbarch_init): Don't register deleted functions with
3608         gdbarch.
3609
3610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3613         (iq2000_unwind_pc): Delete.
3614         (iq2000_dummy_id): Delete.
3615         (iq2000_gdbarch_init): Don't register deleted functions with
3616         gdbarch.
3617
3618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * nds32-tdep.c (nds32_type_align): Delete.
3621         (nds32_push_dummy_call): Use type_align instead.
3622
3623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * arm-tdep.c (arm_type_align): Only handle vector override case.
3626         (arm_push_dummy_call): Use type_align.
3627         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3628
3629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3632         case.
3633         (pass_on_stack): Use type_align.
3634         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3635         function.
3636
3637 2019-04-23  Tom Tromey  <tromey@adacore.com>
3638
3639         * dwarf2read.c (line_header::file_name_at): Remove unused
3640         overload.
3641
3642 2019-04-23  Tom de Vries  <tdevries@suse.de>
3643
3644         PR gdb/24438
3645         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3646         invocation.
3647
3648
3649 2019-03-27  Ali Tamur  <tamur@google.com>
3650
3651         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3652         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3653         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3654         (dwarf_expr_context::get_addr_index): Likewise
3655         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3656         (symbol_needs_eval_context::get_addr_index): Likewise
3657         (disassemble_dwarf_expression): Add DW_OP_addrx
3658         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3659         (read_cutu_die_from_dwo): Update comment
3660         (skip_one_die): Add DW_FORM_addrx
3661         (read_attribute_value): Likewise
3662         (var_decode_location): Add DW_OP_addrx
3663         (dwarf2_const_value_attr): Add DW_FORM_addrx
3664         (dump_die_shallow): Likewise
3665         (dwarf2_fetch_constant_bytes): Likewise
3666         (decode_locdesc): Add DW_OP_addrx
3667         (skip_form_bytes): Add DW_FORM_addrx
3668
3669 2019-04-22  Ali Tamur  <tamur@google.com>
3670
3671         * MAINTAINERS (Write After Approval): Add self.
3672
3673 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3676         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3677         (open_symbol_file_object): Likewise.
3678         (svr4_default_sos): Add info parameter.
3679         (svr4_read_so_list): Likewise.
3680         (svr4_current_sos_direct): Adjust functions calls to pass down
3681         info.
3682         (svr4_current_sos_1): Add info parameter.
3683         (svr4_current_sos): Call get_svr4_info, pass info down to
3684         svr4_current_sos_1.
3685         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3686         get_svr4_info.
3687         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3688         get_svr4_info.
3689         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3690         to get_svr4_info.
3691         (probes_table_remove_objfile_probes): Likewise.
3692         (register_solib_event_probe): Add info parameter.
3693         (solist_update_incremental): Pass info parameter down to
3694         svr4_read_so_list.
3695         (disable_probes_interface): Add info parameter.
3696         (svr4_handle_solib_event): Pass current_program_space to
3697         get_svr4_info.  Adjust disable_probes_interface cleanup.
3698         (svr4_create_probe_breakpoints): Add info parameter, pass it
3699         down to register_solib_event_probe.
3700         (svr4_create_solib_event_breakpoints): Add info parameter,
3701         pass it down to svr4_create_probe_breakpoints.
3702         (enable_break): Pass info down to
3703         svr4_create_solib_event_breakpoints.
3704         (svr4_solib_create_inferior_hook): Pass current_program_space to
3705         get_svr4_info.
3706         (svr4_clear_solib): Likewise.
3707
3708 2019-04-22  Pedro Alves  <palves@redhat.com>
3709
3710         * solib-svr4.c (svr4_free_objfile_observer): New.
3711         (probe_and_action::objfile): New field.
3712         (probes_table_htab_remove_objfile_probes)
3713         (probes_table_remove_objfile_probes): New functions.
3714         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3715         in the new probe_and_action.  Don't store the probe in 'lookup'.
3716         (svr4_create_probe_breakpoints): Pass objfile to
3717         register_solib_event_probe.
3718         (_initialize_svr4_solib): Register a free_objfile observer.
3719
3720 2019-04-19  Tom Tromey  <tom@tromey.com>
3721
3722         * common/queue.h: Remove.
3723
3724 2019-04-19  Tom Tromey  <tom@tromey.com>
3725
3726         * event-loop.c: Don't include "common/queue.h".
3727
3728 2019-04-19  Tom Tromey  <tom@tromey.com>
3729
3730         * remote.c (remote_target): Use delete.
3731         * remote-notif.h: Include <list>, not "common/queue.h".
3732         (notif_client_p): Remove typedef.
3733         (remote_notif_state): Add constructor, destructor, initializer.
3734         <notif_queue>: Now a std::list.
3735         (remote_notif_state_xfree): Don't declare.
3736         * remote-notif.c (remote_notif_process, handle_notification)
3737         (remote_notif_state_allocate): Update.
3738         (~remote_notif_state): Rename from remote_notif_state_xfree.
3739
3740 2019-04-19  Tom Tromey  <tom@tromey.com>
3741
3742         * symfile.c (reread_symbols): Update.
3743         * objfiles.c (objfile_register_static_link)
3744         (objfile_lookup_static_link): Update
3745         (~objfile) Don't delete static_links.
3746         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3747
3748 2019-04-19  Tom Tromey  <tom@tromey.com>
3749
3750         * type-stack.h (struct type_stack) <insert>: Constify string.
3751         * type-stack.c (type_stack::insert): Constify string.
3752         * gdbtypes.h (lookup_template_type): Update.
3753         (address_space_name_to_int): Update.
3754         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3755         const.
3756         (lookup_template_type): Make name const.
3757         * c-exp.y: Update rules.
3758         (lex_one_token, classify_name, classify_inner_name)
3759         (c_print_token): Update.
3760         * p-exp.y: Update rules.
3761         (yylex): Update.
3762         * f-exp.y: Update rules.
3763         (yylex): Update.
3764         * d-exp.y: Update rules.
3765         (lex_one_token, classify_name, classify_inner_name): Update.
3766         * parse.c (write_dollar_variable, copy_name): Return std::string.
3767         * parser-defs.h (copy_name): Change return type.
3768         * m2-exp.y: Update rules.
3769         (yylex): Update.
3770         * go-exp.y (lex_one_token): Update.
3771         Update rules.
3772         (classify_unsafe_function, classify_packaged_name)
3773         (classify_name, yylex): Update.
3774
3775 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3776
3777         * configure.ac: add --enable-source-highlight switch.
3778         * configure: Regenerate.
3779         * top.c (print_gdb_version): plumb --enable-source-highlight
3780         status to "show configuration".
3781
3782 2019-04-19  Tom Tromey  <tromey@adacore.com>
3783
3784         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3785         Check ADA_TYPE_P.
3786         (empty_record, ada_template_to_fixed_record_type_1)
3787         (template_to_static_fixed_type)
3788         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3789         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3790         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3791         macros.
3792
3793 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3794
3795         PR symtab/24423:
3796         * source.c (print_source_lines_base): Advance "iter" when a
3797         control character is seen.
3798
3799 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3800
3801         * inferior.h (struct infcall_suspend_state_deleter):
3802         Catch exception in destructor to avoid crash.
3803
3804 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3805
3806         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3807         close to the add_com "shell".
3808
3809 2019-04-18  Tom Tromey  <tromey@adacore.com>
3810
3811         * process-stratum-target.h (class process_stratum_target)
3812         <stratum>: Add "final".
3813
3814 2019-04-17  Tom Tromey  <tromey@adacore.com>
3815
3816         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3817         against nullptr before use.
3818
3819 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3820
3821         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3822
3823 2019-04-17  Jim Wilson  <jimw@sifive.com>
3824             Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3827         code read might fail, assume 4-byte breakpoint in that case.
3828
3829 2019-04-15  Leszek Swirski  <leszeks@google.com>
3830
3831         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3832         rather than a hand-rolled POD check when checking for forced MEMORY
3833         classification.
3834
3835 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3836
3837         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3838         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3839         function.
3840         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3841         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3842         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3843         declaration.
3844
3845 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3846
3847         * aarch64-linux-nat.c
3848         (aarch64_linux_nat_target::thread_architecture): Add override.
3849         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3850         each VQ.
3851
3852 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3853
3854         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3855
3856 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3859         target types of size 96-bits, add some additional comments, and
3860         check that the builtin type we found was the correct size.
3861
3862 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3863
3864         * utils.c (prompt_for_continue): Don't restore the styling at the
3865         end, as applied_style has the wrong value.  This fixes styling in
3866         long lists of file names that are interrupted by the "Continue?"
3867         prompt.
3868
3869 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3870
3871         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3872         * c-lang.c (c_language_defn): Likewise.
3873         (cplus_language_defn): Likewise.
3874         (asm_language_defn): Likewise.
3875         (minimal_language_defn): Likewise.
3876         * d-lang.c (d_language_defn): Likewise.
3877         * f-lang.c (f_language_defn): Likewise.
3878         * go-lang.c (go_language_defn): Likewise.
3879         * language.c (unknown_language_defn): Likewise.
3880         (auto_language_defn): Likewise.
3881         * language.h (struct language_defn): Remove la_magic field.
3882         (LANG_MAGIC): Delete.
3883         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3884         * objc-lang.c (objc_language_defn): Likewise.
3885         * opencl-lang.c (opencl_language_defn): Likewise.
3886         * p-lang.c (pascal_language_defn): Likewise.
3887         * rust-lang.c (rust_language_defn): Likewise.
3888
3889 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * riscv-tdep.c (riscv_type_align): New function.
3892         (riscv_type_alignment): Delete.
3893         (riscv_arg_location): Use 'type_align'.
3894         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3895
3896 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * gdbtypes.c (type_align): A struct with no non-static fields also
3899         has alignment of 1.
3900
3901 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3904         component to 0.
3905         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3906         member.
3907         (riscv_struct_info::analyse): New implementation using new
3908         analyse_inner member function.
3909         (riscv_struct_info::field_offset): New member function.
3910         (riscv_struct_info::m_offsets): New member variable.
3911         (riscv_struct_info::analyse_inner): New private member function,
3912         takes the old implementation of riscv_struct_info::analyse but
3913         extended to track field offsets.
3914         (riscv_call_arg_struct): Update the struct folding special cases
3915         to handle cases where empty C++ structs, which are non-zero
3916         length, are found.
3917         (riscv_arg_location): Initialise the length of each location, a
3918         non-zero length now indicates the location is in use.
3919         (riscv_push_dummy_call): Allow for the first location having a
3920         non-zero offset when setting up arguments.
3921         (riscv_return_value): Likewise, but for return values.
3922
3923 2019-04-11  Tom Tromey  <tromey@adacore.com>
3924
3925         * utils.c (internal_vproblem): Make "msg" const.
3926
3927 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3928
3929         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3930         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3931         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3932         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3933
3934 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3935
3936         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3937         function.
3938         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3939         of amd64_collect_native_gregset.
3940         (amd64_linux_nat_target::store_registers): Likewise.
3941
3942 2019-04-10  Tom Tromey  <tom@tromey.com>
3943
3944         * symtab.c (lookup_global_symbol_from_objfile)
3945         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3946         * objfiles.h (class separate_debug_iterator): New.
3947         (class separate_debug_range): New.
3948         (struct objfile) <separate_debug_objfiles>: New method.
3949         (objfile_separate_debug_iterate): Don't declare.
3950         * objfiles.c (separate_debug_iterator::operator++): Rename from
3951         objfile_separate_debug_iterate.
3952         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3953         iterator.
3954         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3955         iterator.
3956
3957 2019-04-10  Tom Tromey  <tom@tromey.com>
3958
3959         * symfile.c (reread_symbols): Remove old comment.
3960         * objfiles.c (free_all_objfiles): Fix a typo.
3961
3962 2019-04-10  Tom Tromey  <tom@tromey.com>
3963
3964         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3965         * minsyms.c (lookup_minimal_symbol): Use foreach.
3966         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3967         (lookup_minimal_symbol_solib_trampoline): Likewise.
3968         * symfile.c (reread_symbols): Use foreach.
3969
3970 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3971             Tom Tromey  <tromey@adacore.com>
3972
3973         PR rust/24414:
3974         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3975         (rust_lex_int_test): Change "value" to be LONGEST.
3976         (rust_lex_tests): Add test for long integer literal.
3977
3978 2019-04-09  Tom Tromey  <tromey@adacore.com>
3979
3980         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3981         to bool.
3982         (extended_remote_target::attach): Update.
3983         (remote_target::remote_notice_new_inferior): Update.
3984         (remote_target::add_current_inferior_and_thread): Update.
3985         * inferior.c (exit_inferior_1): Use "false".
3986         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3987
3988 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3989
3990         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3991         the "start" command.
3992
3993 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3994
3995         * python/py-inferior.c (infpy_thread_from_thread_handle):
3996         Adjust comments to reflect renaming of thread_from_thread_handle
3997         to thread_from_handle.  Adjust keywords.  Fix type error message.
3998         (inferior_object_methods): Add thread_from_handle.  Retain
3999         thread_from_thread_handle, but mark it as deprecated.
4000
4001 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4002
4003         * gdbthread.h (find_thread_by_handle): Revise declaration.
4004         * thread.c (find_thread_by_handle): Likewise.  Adjust
4005         implementation too.
4006         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4007         support for buffer objects as handles.
4008
4009 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4010
4011         * python/py-infthread.c (thpy_thread_handle): New function.
4012         (thread_object_methods): Register thpy_thread_handle.
4013
4014 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4015
4016         * gdbthread.h (thread_to_thread_handle): Declare.
4017         * thread.c (gdbtypes.h): Include.
4018         (thread_to_thread_handle): New function.
4019
4020         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4021         (target_thread_info_to_thread_handle): Declare.
4022         * target.c (target_thread_info_to_thread_handle): New function.
4023         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4024         * target-delegates.c: Regenerate.
4025
4026         * linux-thread-db.c (class thread_db_target): Add method
4027         thread_info_to_thread_handle.
4028         (thread_db_target::thread_info_to_thread_handle): Define.
4029         * remote.c (class remote_target): Add new method
4030         thread_info_to_thread_handle.
4031         (remote_target::thread_info_to_thread_handle): Define.
4032
4033 2019-04-08  Pedro Alves  <palves@redhat.com>
4034
4035         * common/common-exceptions.c (throw_exception): Don't create
4036         named object to throw; throw directly.
4037         (throw_it): Likewise.  Don't initialize gdb_exception::message
4038         here, with new; pass FMT and AP to the ctor instead.
4039         * common/common-exceptions.h: Include <string>.
4040         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4041         const char *, va_list)): New ctor.  Use std::make_shared.
4042         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4043         errors)): Delete.
4044         (gdb_exception_error::gdb_exception_error(enum errors, const char
4045         *, va_list)): New.
4046         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4047         Add assertion.
4048         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4049         errors)): Delete.
4050         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4051         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4052         Add assertion.
4053
4054 2019-04-08  Tom Tromey  <tom@tromey.com>
4055
4056         * valops.c (value_rtti_indirect_type): Replace throw_exception
4057         with throw.
4058         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4059         with throw.
4060         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4061         throw.
4062         * target.c (target_translate_tls_address): Replace throw_exception
4063         with throw.
4064         * stack.c (frame_apply_command_count): Replace throw_exception
4065         with throw.
4066         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4067         throw.
4068         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4069         with throw.
4070         * rs6000-tdep.c (rs6000_frame_cache)
4071         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4072         * remote.c: Replace throw_exception with throw.
4073         * record-full.c (record_full_message, record_full_wait_1)
4074         (record_full_restore): Replace throw_exception with throw.
4075         * record-btrace.c:
4076         (get_thread_current_frame_id, record_btrace_start_replaying)
4077         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4078         (cmd_record_btrace_start): Replace throw_exception with throw.
4079         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4080         throw.
4081         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4082         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4083         * linespec.c:
4084         (find_linespec_symbols): Replace throw_exception with throw.
4085         * infrun.c (displaced_step_prepare, resume): Replace
4086         throw_exception with throw.
4087         * infcmd.c (post_create_inferior): Replace throw_exception with
4088         throw.
4089         * inf-loop.c (inferior_event_handler): Replace throw_exception
4090         with throw.
4091         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4092         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4093         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4094         (get_prev_frame_always, get_frame_pc_if_available)
4095         (get_frame_address_in_block_if_available, get_frame_language):
4096         Replace throw_exception with throw.
4097         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4098         throw_exception with throw.
4099         * eval.c (fetch_subexp_value, evaluate_var_value)
4100         (evaluate_funcall, evaluate_subexp_standard): Replace
4101         throw_exception with throw.
4102         * dwarf2loc.c (call_site_find_chain)
4103         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4104         Replace throw_exception with throw.
4105         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4106         with throw.
4107         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4108         throw.
4109         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4110         * completer.c (complete_line_internal): Replace throw_exception
4111         with throw.
4112         * compile/compile-object-run.c (compile_object_run): Replace
4113         throw_exception with throw.
4114         * cli/cli-script.c (process_next_line): Replace throw_exception
4115         with throw.
4116         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4117         (btrace_enable, btrace_maint_update_pt_packets): Replace
4118         throw_exception with throw.
4119         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4120         throw_exception with throw.
4121         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4122         throw_exception with throw.
4123         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4124         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4125         * aarch64-tdep.c (aarch64_make_prologue_cache)
4126         (aarch64_make_stub_cache): Replace throw_exception with throw.
4127
4128 2019-04-08  Tom Tromey  <tom@tromey.com>
4129
4130         * common/common-exceptions.c (throw_exception): Rename from
4131         throw_exception_cxx.  Remove old copy.  Make argument const.
4132         (throw_it): Create and throw exception objects directly.
4133         * common/common-exceptions.h (throw_exception): Make argument
4134         const.
4135         (struct gdb_exception_error): Add constructor.
4136         (struct gdb_exception_quit): Add constructor.
4137
4138 2019-04-08  Tom Tromey  <tom@tromey.com>
4139
4140         * common/common-exceptions.h (exception_rethrow): Don't declare.
4141         (TRY_SJLJ): Update comment.
4142         (TRY, CATCH, END_CATCH): Remove.
4143         * common/common-exceptions.c (exception_rethrow): Remove.
4144
4145 2019-04-08  Tom Tromey  <tom@tromey.com>
4146
4147         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4148         Remove.
4149         (gdb_exception_error): Rename from
4150         gdb_exception_RETURN_MASK_ERROR.
4151         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4152         (gdb_quit_bad_alloc): Update.
4153         * aarch64-tdep.c: Update.
4154         * ada-lang.c: Update.
4155         * ada-typeprint.c: Update.
4156         * ada-valprint.c: Update.
4157         * amd64-tdep.c: Update.
4158         * arch-utils.c: Update.
4159         * break-catch-throw.c: Update.
4160         * breakpoint.c: Update.
4161         * btrace.c: Update.
4162         * c-varobj.c: Update.
4163         * cli/cli-cmds.c: Update.
4164         * cli/cli-interp.c: Update.
4165         * cli/cli-script.c: Update.
4166         * common/common-exceptions.c: Update.
4167         * common/new-op.c: Update.
4168         * common/selftest.c: Update.
4169         * compile/compile-c-symbols.c: Update.
4170         * compile/compile-cplus-symbols.c: Update.
4171         * compile/compile-object-load.c: Update.
4172         * compile/compile-object-run.c: Update.
4173         * completer.c: Update.
4174         * corelow.c: Update.
4175         * cp-abi.c: Update.
4176         * cp-support.c: Update.
4177         * cp-valprint.c: Update.
4178         * darwin-nat.c: Update.
4179         * disasm-selftests.c: Update.
4180         * dtrace-probe.c: Update.
4181         * dwarf-index-cache.c: Update.
4182         * dwarf-index-write.c: Update.
4183         * dwarf2-frame-tailcall.c: Update.
4184         * dwarf2-frame.c: Update.
4185         * dwarf2loc.c: Update.
4186         * dwarf2read.c: Update.
4187         * eval.c: Update.
4188         * event-loop.c: Update.
4189         * event-top.c: Update.
4190         * exec.c: Update.
4191         * f-valprint.c: Update.
4192         * fbsd-tdep.c: Update.
4193         * frame-unwind.c: Update.
4194         * frame.c: Update.
4195         * gdbtypes.c: Update.
4196         * gnu-v3-abi.c: Update.
4197         * guile/guile-internal.h: Update.
4198         * guile/scm-block.c: Update.
4199         * guile/scm-breakpoint.c: Update.
4200         * guile/scm-cmd.c: Update.
4201         * guile/scm-disasm.c: Update.
4202         * guile/scm-frame.c: Update.
4203         * guile/scm-lazy-string.c: Update.
4204         * guile/scm-math.c: Update.
4205         * guile/scm-param.c: Update.
4206         * guile/scm-ports.c: Update.
4207         * guile/scm-pretty-print.c: Update.
4208         * guile/scm-symbol.c: Update.
4209         * guile/scm-symtab.c: Update.
4210         * guile/scm-type.c: Update.
4211         * guile/scm-value.c: Update.
4212         * i386-linux-tdep.c: Update.
4213         * i386-tdep.c: Update.
4214         * inf-loop.c: Update.
4215         * infcall.c: Update.
4216         * infcmd.c: Update.
4217         * infrun.c: Update.
4218         * jit.c: Update.
4219         * language.c: Update.
4220         * linespec.c: Update.
4221         * linux-fork.c: Update.
4222         * linux-nat.c: Update.
4223         * linux-tdep.c: Update.
4224         * linux-thread-db.c: Update.
4225         * main.c: Update.
4226         * mi/mi-cmd-break.c: Update.
4227         * mi/mi-cmd-stack.c: Update.
4228         * mi/mi-interp.c: Update.
4229         * mi/mi-main.c: Update.
4230         * objc-lang.c: Update.
4231         * p-valprint.c: Update.
4232         * parse.c: Update.
4233         * ppc-linux-tdep.c: Update.
4234         * printcmd.c: Update.
4235         * python/py-arch.c: Update.
4236         * python/py-breakpoint.c: Update.
4237         * python/py-cmd.c: Update.
4238         * python/py-finishbreakpoint.c: Update.
4239         * python/py-frame.c: Update.
4240         * python/py-framefilter.c: Update.
4241         * python/py-gdb-readline.c: Update.
4242         * python/py-inferior.c: Update.
4243         * python/py-infthread.c: Update.
4244         * python/py-lazy-string.c: Update.
4245         * python/py-linetable.c: Update.
4246         * python/py-objfile.c: Update.
4247         * python/py-param.c: Update.
4248         * python/py-prettyprint.c: Update.
4249         * python/py-progspace.c: Update.
4250         * python/py-record-btrace.c: Update.
4251         * python/py-record.c: Update.
4252         * python/py-symbol.c: Update.
4253         * python/py-type.c: Update.
4254         * python/py-unwind.c: Update.
4255         * python/py-utils.c: Update.
4256         * python/py-value.c: Update.
4257         * python/python.c: Update.
4258         * record-btrace.c: Update.
4259         * record-full.c: Update.
4260         * remote-fileio.c: Update.
4261         * remote.c: Update.
4262         * riscv-tdep.c: Update.
4263         * rs6000-aix-tdep.c: Update.
4264         * rs6000-tdep.c: Update.
4265         * rust-exp.y: Update.
4266         * rust-lang.c: Update.
4267         * s390-tdep.c: Update.
4268         * selftest-arch.c: Update.
4269         * solib-dsbt.c: Update.
4270         * solib-frv.c: Update.
4271         * solib-spu.c: Update.
4272         * solib-svr4.c: Update.
4273         * solib.c: Update.
4274         * sparc64-linux-tdep.c: Update.
4275         * stack.c: Update.
4276         * symfile-mem.c: Update.
4277         * symmisc.c: Update.
4278         * target.c: Update.
4279         * thread.c: Update.
4280         * top.c: Update.
4281         * tracefile-tfile.c: Update.
4282         * tui/tui.c: Update.
4283         * typeprint.c: Update.
4284         * unittests/cli-utils-selftests.c: Update.
4285         * unittests/parse-connection-spec-selftests.c: Update.
4286         * valops.c: Update.
4287         * valprint.c: Update.
4288         * value.c: Update.
4289         * varobj.c: Update.
4290         * windows-nat.c: Update.
4291         * x86-linux-nat.c: Update.
4292         * xml-support.c: Update.
4293
4294 2019-04-08  Tom Tromey  <tom@tromey.com>
4295
4296         * xml-support.c: Use C++ exception handling.
4297         * x86-linux-nat.c: Use C++ exception handling.
4298         * windows-nat.c: Use C++ exception handling.
4299         * varobj.c: Use C++ exception handling.
4300         * value.c: Use C++ exception handling.
4301         * valprint.c: Use C++ exception handling.
4302         * valops.c: Use C++ exception handling.
4303         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4304         handling.
4305         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4306         * typeprint.c: Use C++ exception handling.
4307         * tui/tui.c: Use C++ exception handling.
4308         * tracefile-tfile.c: Use C++ exception handling.
4309         * top.c: Use C++ exception handling.
4310         * thread.c: Use C++ exception handling.
4311         * target.c: Use C++ exception handling.
4312         * symmisc.c: Use C++ exception handling.
4313         * symfile-mem.c: Use C++ exception handling.
4314         * stack.c: Use C++ exception handling.
4315         * sparc64-linux-tdep.c: Use C++ exception handling.
4316         * solib.c: Use C++ exception handling.
4317         * solib-svr4.c: Use C++ exception handling.
4318         * solib-spu.c: Use C++ exception handling.
4319         * solib-frv.c: Use C++ exception handling.
4320         * solib-dsbt.c: Use C++ exception handling.
4321         * selftest-arch.c: Use C++ exception handling.
4322         * s390-tdep.c: Use C++ exception handling.
4323         * rust-lang.c: Use C++ exception handling.
4324         * rust-exp.y: Use C++ exception handling.
4325         * rs6000-tdep.c: Use C++ exception handling.
4326         * rs6000-aix-tdep.c: Use C++ exception handling.
4327         * riscv-tdep.c: Use C++ exception handling.
4328         * remote.c: Use C++ exception handling.
4329         * remote-fileio.c: Use C++ exception handling.
4330         * record-full.c: Use C++ exception handling.
4331         * record-btrace.c: Use C++ exception handling.
4332         * python/python.c: Use C++ exception handling.
4333         * python/py-value.c: Use C++ exception handling.
4334         * python/py-utils.c: Use C++ exception handling.
4335         * python/py-unwind.c: Use C++ exception handling.
4336         * python/py-type.c: Use C++ exception handling.
4337         * python/py-symbol.c: Use C++ exception handling.
4338         * python/py-record.c: Use C++ exception handling.
4339         * python/py-record-btrace.c: Use C++ exception handling.
4340         * python/py-progspace.c: Use C++ exception handling.
4341         * python/py-prettyprint.c: Use C++ exception handling.
4342         * python/py-param.c: Use C++ exception handling.
4343         * python/py-objfile.c: Use C++ exception handling.
4344         * python/py-linetable.c: Use C++ exception handling.
4345         * python/py-lazy-string.c: Use C++ exception handling.
4346         * python/py-infthread.c: Use C++ exception handling.
4347         * python/py-inferior.c: Use C++ exception handling.
4348         * python/py-gdb-readline.c: Use C++ exception handling.
4349         * python/py-framefilter.c: Use C++ exception handling.
4350         * python/py-frame.c: Use C++ exception handling.
4351         * python/py-finishbreakpoint.c: Use C++ exception handling.
4352         * python/py-cmd.c: Use C++ exception handling.
4353         * python/py-breakpoint.c: Use C++ exception handling.
4354         * python/py-arch.c: Use C++ exception handling.
4355         * printcmd.c: Use C++ exception handling.
4356         * ppc-linux-tdep.c: Use C++ exception handling.
4357         * parse.c: Use C++ exception handling.
4358         * p-valprint.c: Use C++ exception handling.
4359         * objc-lang.c: Use C++ exception handling.
4360         * mi/mi-main.c: Use C++ exception handling.
4361         * mi/mi-interp.c: Use C++ exception handling.
4362         * mi/mi-cmd-stack.c: Use C++ exception handling.
4363         * mi/mi-cmd-break.c: Use C++ exception handling.
4364         * main.c: Use C++ exception handling.
4365         * linux-thread-db.c: Use C++ exception handling.
4366         * linux-tdep.c: Use C++ exception handling.
4367         * linux-nat.c: Use C++ exception handling.
4368         * linux-fork.c: Use C++ exception handling.
4369         * linespec.c: Use C++ exception handling.
4370         * language.c: Use C++ exception handling.
4371         * jit.c: Use C++ exception handling.
4372         * infrun.c: Use C++ exception handling.
4373         * infcmd.c: Use C++ exception handling.
4374         * infcall.c: Use C++ exception handling.
4375         * inf-loop.c: Use C++ exception handling.
4376         * i386-tdep.c: Use C++ exception handling.
4377         * i386-linux-tdep.c: Use C++ exception handling.
4378         * guile/scm-value.c: Use C++ exception handling.
4379         * guile/scm-type.c: Use C++ exception handling.
4380         * guile/scm-symtab.c: Use C++ exception handling.
4381         * guile/scm-symbol.c: Use C++ exception handling.
4382         * guile/scm-pretty-print.c: Use C++ exception handling.
4383         * guile/scm-ports.c: Use C++ exception handling.
4384         * guile/scm-param.c: Use C++ exception handling.
4385         * guile/scm-math.c: Use C++ exception handling.
4386         * guile/scm-lazy-string.c: Use C++ exception handling.
4387         * guile/scm-frame.c: Use C++ exception handling.
4388         * guile/scm-disasm.c: Use C++ exception handling.
4389         * guile/scm-cmd.c: Use C++ exception handling.
4390         * guile/scm-breakpoint.c: Use C++ exception handling.
4391         * guile/scm-block.c: Use C++ exception handling.
4392         * guile/guile-internal.h: Use C++ exception handling.
4393         * gnu-v3-abi.c: Use C++ exception handling.
4394         * gdbtypes.c: Use C++ exception handling.
4395         * frame.c: Use C++ exception handling.
4396         * frame-unwind.c: Use C++ exception handling.
4397         * fbsd-tdep.c: Use C++ exception handling.
4398         * f-valprint.c: Use C++ exception handling.
4399         * exec.c: Use C++ exception handling.
4400         * event-top.c: Use C++ exception handling.
4401         * event-loop.c: Use C++ exception handling.
4402         * eval.c: Use C++ exception handling.
4403         * dwarf2read.c: Use C++ exception handling.
4404         * dwarf2loc.c: Use C++ exception handling.
4405         * dwarf2-frame.c: Use C++ exception handling.
4406         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4407         * dwarf-index-write.c: Use C++ exception handling.
4408         * dwarf-index-cache.c: Use C++ exception handling.
4409         * dtrace-probe.c: Use C++ exception handling.
4410         * disasm-selftests.c: Use C++ exception handling.
4411         * darwin-nat.c: Use C++ exception handling.
4412         * cp-valprint.c: Use C++ exception handling.
4413         * cp-support.c: Use C++ exception handling.
4414         * cp-abi.c: Use C++ exception handling.
4415         * corelow.c: Use C++ exception handling.
4416         * completer.c: Use C++ exception handling.
4417         * compile/compile-object-run.c: Use C++ exception handling.
4418         * compile/compile-object-load.c: Use C++ exception handling.
4419         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4420         * compile/compile-c-symbols.c: Use C++ exception handling.
4421         * common/selftest.c: Use C++ exception handling.
4422         * common/new-op.c: Use C++ exception handling.
4423         * cli/cli-script.c: Use C++ exception handling.
4424         * cli/cli-interp.c: Use C++ exception handling.
4425         * cli/cli-cmds.c: Use C++ exception handling.
4426         * c-varobj.c: Use C++ exception handling.
4427         * btrace.c: Use C++ exception handling.
4428         * breakpoint.c: Use C++ exception handling.
4429         * break-catch-throw.c: Use C++ exception handling.
4430         * arch-utils.c: Use C++ exception handling.
4431         * amd64-tdep.c: Use C++ exception handling.
4432         * ada-valprint.c: Use C++ exception handling.
4433         * ada-typeprint.c: Use C++ exception handling.
4434         * ada-lang.c: Use C++ exception handling.
4435         * aarch64-tdep.c: Use C++ exception handling.
4436
4437 2019-04-08  Tom Tromey  <tom@tromey.com>
4438
4439         * xml-support.c (gdb_xml_parser::parse): Update.
4440         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4441         * value.c (show_convenience): Update.
4442         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4443         (test_parse_flags_qcs): Update.
4444         * thread.c (thr_try_catch_cmd): Update.
4445         * target.c (target_translate_tls_address): Update.
4446         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4447         (info_frame_command_core, frame_apply_command_count): Update.
4448         * rust-exp.y (rust_lex_exception_test): Update.
4449         * riscv-tdep.c (riscv_print_one_register_info): Update.
4450         * remote.c (remote_target::enable_btrace): Update.
4451         * record-btrace.c (record_btrace_enable_warn): Update.
4452         * python/py-utils.c (gdbpy_convert_exception): Update.
4453         * printcmd.c (do_one_display, print_variable_and_value): Update.
4454         * mi/mi-main.c (mi_print_exception): Update.
4455         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4456         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4457         * linux-nat.c (linux_nat_target::attach): Update.
4458         * linux-fork.c (class scoped_switch_fork_info): Update.
4459         * infrun.c (displaced_step_prepare): Update.
4460         * infcall.c (call_function_by_hand_dummy): Update.
4461         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4462         * gnu-v3-abi.c (print_one_vtable): Update.
4463         * frame.c (get_prev_frame_always): Update.
4464         * f-valprint.c (info_common_command_for_block): Update.
4465         * exec.c (try_open_exec_file): Update.
4466         * exceptions.c (print_exception, exception_print)
4467         (exception_fprintf, exception_print_same): Update.
4468         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4469         * dwarf-index-cache.c (index_cache::store)
4470         (index_cache::lookup_gdb_index): Update.
4471         * darwin-nat.c (maybe_cache_shell): Update.
4472         * cp-valprint.c (cp_print_value_fields): Update.
4473         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4474         (gcc_cplus_symbol_address): Update.
4475         * compile/compile-c-symbols.c (gcc_convert_symbol)
4476         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4477         * common/selftest.c: Update.
4478         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4479         a std::string.
4480         (exception_try_scope_entry, exception_try_scope_exit): Don't
4481         declare.
4482         (struct exception_try_scope): Remove.
4483         (TRY): Don't use exception_try_scope.
4484         (struct gdb_exception): Add constructor, operator=.
4485         <what>: New method.
4486         (struct gdb_exception_RETURN_MASK_ALL)
4487         (struct gdb_exception_RETURN_MASK_ERROR)
4488         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4489         (struct gdb_quit_bad_alloc): Update.
4490         * common/common-exceptions.c (exception_none): Change
4491         initializer.
4492         (struct catcher) <state, exception>: Initialize inline.
4493         <prev>: Remove member.
4494         (current_catcher): Remove.
4495         (catchers): New global.
4496         (exceptions_state_mc_init): Simplify.
4497         (catcher_pop): Remove.
4498         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4499         (try_scope_depth, exception_try_scope_entry)
4500         (exception_try_scope_exit): Remove.
4501         (throw_exception_sjlj): Update.
4502         (exception_messages, exception_messages_size): Remove.
4503         (throw_it): Simplify.
4504         (gdb_exception_sliced_copy): Remove.
4505         (throw_exception_cxx): Update.
4506         * cli/cli-script.c (script_from_file): Update.
4507         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4508         Update.
4509         * ada-valprint.c (ada_val_print): Update.
4510         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4511         (create_excep_cond_exprs): Update.
4512
4513 2019-04-08  Tom Tromey  <tom@tromey.com>
4514
4515         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4516         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4517         (TRY, CATCH, END_CATCH): Remove some definitions.
4518         * common/common-exceptions.c: Don't use GDB_XCPT.
4519         (catcher_list_size): Remove.
4520         (throw_exception, throw_it): Simplify.
4521
4522 2019-04-05  Tom Tromey  <tom@tromey.com>
4523
4524         Revert the header-sorting patch.
4525         * ft32-tdep.c: Revert.
4526         * frv-tdep.c: Revert.
4527         * frv-linux-tdep.c: Revert.
4528         * frame.c: Revert.
4529         * frame-unwind.c: Revert.
4530         * frame-base.c: Revert.
4531         * fork-child.c: Revert.
4532         * findvar.c: Revert.
4533         * findcmd.c: Revert.
4534         * filesystem.c: Revert.
4535         * filename-seen-cache.h: Revert.
4536         * filename-seen-cache.c: Revert.
4537         * fbsd-tdep.c: Revert.
4538         * fbsd-nat.h: Revert.
4539         * fbsd-nat.c: Revert.
4540         * f-valprint.c: Revert.
4541         * f-typeprint.c: Revert.
4542         * f-lang.c: Revert.
4543         * extension.h: Revert.
4544         * extension.c: Revert.
4545         * extension-priv.h: Revert.
4546         * expprint.c: Revert.
4547         * exec.h: Revert.
4548         * exec.c: Revert.
4549         * exceptions.c: Revert.
4550         * event-top.c: Revert.
4551         * event-loop.c: Revert.
4552         * eval.c: Revert.
4553         * elfread.c: Revert.
4554         * dwarf2read.h: Revert.
4555         * dwarf2read.c: Revert.
4556         * dwarf2loc.c: Revert.
4557         * dwarf2expr.h: Revert.
4558         * dwarf2expr.c: Revert.
4559         * dwarf2-frame.c: Revert.
4560         * dwarf2-frame-tailcall.c: Revert.
4561         * dwarf-index-write.h: Revert.
4562         * dwarf-index-write.c: Revert.
4563         * dwarf-index-common.c: Revert.
4564         * dwarf-index-cache.h: Revert.
4565         * dwarf-index-cache.c: Revert.
4566         * dummy-frame.c: Revert.
4567         * dtrace-probe.c: Revert.
4568         * disasm.h: Revert.
4569         * disasm.c: Revert.
4570         * disasm-selftests.c: Revert.
4571         * dictionary.c: Revert.
4572         * dicos-tdep.c: Revert.
4573         * demangle.c: Revert.
4574         * dcache.h: Revert.
4575         * dcache.c: Revert.
4576         * darwin-nat.h: Revert.
4577         * darwin-nat.c: Revert.
4578         * darwin-nat-info.c: Revert.
4579         * d-valprint.c: Revert.
4580         * d-namespace.c: Revert.
4581         * d-lang.c: Revert.
4582         * ctf.c: Revert.
4583         * csky-tdep.c: Revert.
4584         * csky-linux-tdep.c: Revert.
4585         * cris-tdep.c: Revert.
4586         * cris-linux-tdep.c: Revert.
4587         * cp-valprint.c: Revert.
4588         * cp-support.c: Revert.
4589         * cp-namespace.c: Revert.
4590         * cp-abi.c: Revert.
4591         * corelow.c: Revert.
4592         * corefile.c: Revert.
4593         * continuations.c: Revert.
4594         * completer.h: Revert.
4595         * completer.c: Revert.
4596         * complaints.c: Revert.
4597         * coffread.c: Revert.
4598         * coff-pe-read.c: Revert.
4599         * cli-out.h: Revert.
4600         * cli-out.c: Revert.
4601         * charset.c: Revert.
4602         * c-varobj.c: Revert.
4603         * c-valprint.c: Revert.
4604         * c-typeprint.c: Revert.
4605         * c-lang.c: Revert.
4606         * buildsym.c: Revert.
4607         * buildsym-legacy.c: Revert.
4608         * build-id.h: Revert.
4609         * build-id.c: Revert.
4610         * btrace.c: Revert.
4611         * bsd-uthread.c: Revert.
4612         * breakpoint.h: Revert.
4613         * breakpoint.c: Revert.
4614         * break-catch-throw.c: Revert.
4615         * break-catch-syscall.c: Revert.
4616         * break-catch-sig.c: Revert.
4617         * blockframe.c: Revert.
4618         * block.c: Revert.
4619         * bfin-tdep.c: Revert.
4620         * bfin-linux-tdep.c: Revert.
4621         * bfd-target.c: Revert.
4622         * bcache.c: Revert.
4623         * ax-general.c: Revert.
4624         * ax-gdb.h: Revert.
4625         * ax-gdb.c: Revert.
4626         * avr-tdep.c: Revert.
4627         * auxv.c: Revert.
4628         * auto-load.c: Revert.
4629         * arm-wince-tdep.c: Revert.
4630         * arm-tdep.c: Revert.
4631         * arm-symbian-tdep.c: Revert.
4632         * arm-pikeos-tdep.c: Revert.
4633         * arm-obsd-tdep.c: Revert.
4634         * arm-nbsd-tdep.c: Revert.
4635         * arm-nbsd-nat.c: Revert.
4636         * arm-linux-tdep.c: Revert.
4637         * arm-linux-nat.c: Revert.
4638         * arm-fbsd-tdep.c: Revert.
4639         * arm-fbsd-nat.c: Revert.
4640         * arm-bsd-tdep.c: Revert.
4641         * arch-utils.c: Revert.
4642         * arc-tdep.c: Revert.
4643         * arc-newlib-tdep.c: Revert.
4644         * annotate.h: Revert.
4645         * annotate.c: Revert.
4646         * amd64-windows-tdep.c: Revert.
4647         * amd64-windows-nat.c: Revert.
4648         * amd64-tdep.c: Revert.
4649         * amd64-sol2-tdep.c: Revert.
4650         * amd64-obsd-tdep.c: Revert.
4651         * amd64-obsd-nat.c: Revert.
4652         * amd64-nbsd-tdep.c: Revert.
4653         * amd64-nbsd-nat.c: Revert.
4654         * amd64-nat.c: Revert.
4655         * amd64-linux-tdep.c: Revert.
4656         * amd64-linux-nat.c: Revert.
4657         * amd64-fbsd-tdep.c: Revert.
4658         * amd64-fbsd-nat.c: Revert.
4659         * amd64-dicos-tdep.c: Revert.
4660         * amd64-darwin-tdep.c: Revert.
4661         * amd64-bsd-nat.c: Revert.
4662         * alpha-tdep.c: Revert.
4663         * alpha-obsd-tdep.c: Revert.
4664         * alpha-nbsd-tdep.c: Revert.
4665         * alpha-mdebug-tdep.c: Revert.
4666         * alpha-linux-tdep.c: Revert.
4667         * alpha-linux-nat.c: Revert.
4668         * alpha-bsd-tdep.c: Revert.
4669         * alpha-bsd-nat.c: Revert.
4670         * aix-thread.c: Revert.
4671         * agent.c: Revert.
4672         * addrmap.c: Revert.
4673         * ada-varobj.c: Revert.
4674         * ada-valprint.c: Revert.
4675         * ada-typeprint.c: Revert.
4676         * ada-tasks.c: Revert.
4677         * ada-lang.c: Revert.
4678         * aarch64-tdep.c: Revert.
4679         * aarch64-ravenscar-thread.c: Revert.
4680         * aarch64-newlib-tdep.c: Revert.
4681         * aarch64-linux-tdep.c: Revert.
4682         * aarch64-linux-nat.c: Revert.
4683         * aarch64-fbsd-tdep.c: Revert.
4684         * aarch64-fbsd-nat.c: Revert.
4685         * aarch32-linux-nat.c: Revert.
4686
4687 2019-04-05  Tom Tromey  <tom@tromey.com>
4688
4689         * ft32-tdep.c: Sort headers.
4690         * frv-tdep.c: Sort headers.
4691         * frv-linux-tdep.c: Sort headers.
4692         * frame.c: Sort headers.
4693         * frame-unwind.c: Sort headers.
4694         * frame-base.c: Sort headers.
4695         * fork-child.c: Sort headers.
4696         * findvar.c: Sort headers.
4697         * findcmd.c: Sort headers.
4698         * filesystem.c: Sort headers.
4699         * filename-seen-cache.h: Sort headers.
4700         * filename-seen-cache.c: Sort headers.
4701         * fbsd-tdep.c: Sort headers.
4702         * fbsd-nat.h: Sort headers.
4703         * fbsd-nat.c: Sort headers.
4704         * f-valprint.c: Sort headers.
4705         * f-typeprint.c: Sort headers.
4706         * f-lang.c: Sort headers.
4707         * extension.h: Sort headers.
4708         * extension.c: Sort headers.
4709         * extension-priv.h: Sort headers.
4710         * expprint.c: Sort headers.
4711         * exec.h: Sort headers.
4712         * exec.c: Sort headers.
4713         * exceptions.c: Sort headers.
4714         * event-top.c: Sort headers.
4715         * event-loop.c: Sort headers.
4716         * eval.c: Sort headers.
4717         * elfread.c: Sort headers.
4718         * dwarf2read.h: Sort headers.
4719         * dwarf2read.c: Sort headers.
4720         * dwarf2loc.c: Sort headers.
4721         * dwarf2expr.h: Sort headers.
4722         * dwarf2expr.c: Sort headers.
4723         * dwarf2-frame.c: Sort headers.
4724         * dwarf2-frame-tailcall.c: Sort headers.
4725         * dwarf-index-write.h: Sort headers.
4726         * dwarf-index-write.c: Sort headers.
4727         * dwarf-index-common.c: Sort headers.
4728         * dwarf-index-cache.h: Sort headers.
4729         * dwarf-index-cache.c: Sort headers.
4730         * dummy-frame.c: Sort headers.
4731         * dtrace-probe.c: Sort headers.
4732         * disasm.h: Sort headers.
4733         * disasm.c: Sort headers.
4734         * disasm-selftests.c: Sort headers.
4735         * dictionary.c: Sort headers.
4736         * dicos-tdep.c: Sort headers.
4737         * demangle.c: Sort headers.
4738         * dcache.h: Sort headers.
4739         * dcache.c: Sort headers.
4740         * darwin-nat.h: Sort headers.
4741         * darwin-nat.c: Sort headers.
4742         * darwin-nat-info.c: Sort headers.
4743         * d-valprint.c: Sort headers.
4744         * d-namespace.c: Sort headers.
4745         * d-lang.c: Sort headers.
4746         * ctf.c: Sort headers.
4747         * csky-tdep.c: Sort headers.
4748         * csky-linux-tdep.c: Sort headers.
4749         * cris-tdep.c: Sort headers.
4750         * cris-linux-tdep.c: Sort headers.
4751         * cp-valprint.c: Sort headers.
4752         * cp-support.c: Sort headers.
4753         * cp-namespace.c: Sort headers.
4754         * cp-abi.c: Sort headers.
4755         * corelow.c: Sort headers.
4756         * corefile.c: Sort headers.
4757         * continuations.c: Sort headers.
4758         * completer.h: Sort headers.
4759         * completer.c: Sort headers.
4760         * complaints.c: Sort headers.
4761         * coffread.c: Sort headers.
4762         * coff-pe-read.c: Sort headers.
4763         * cli-out.h: Sort headers.
4764         * cli-out.c: Sort headers.
4765         * charset.c: Sort headers.
4766         * c-varobj.c: Sort headers.
4767         * c-valprint.c: Sort headers.
4768         * c-typeprint.c: Sort headers.
4769         * c-lang.c: Sort headers.
4770         * buildsym.c: Sort headers.
4771         * buildsym-legacy.c: Sort headers.
4772         * build-id.h: Sort headers.
4773         * build-id.c: Sort headers.
4774         * btrace.c: Sort headers.
4775         * bsd-uthread.c: Sort headers.
4776         * breakpoint.h: Sort headers.
4777         * breakpoint.c: Sort headers.
4778         * break-catch-throw.c: Sort headers.
4779         * break-catch-syscall.c: Sort headers.
4780         * break-catch-sig.c: Sort headers.
4781         * blockframe.c: Sort headers.
4782         * block.c: Sort headers.
4783         * bfin-tdep.c: Sort headers.
4784         * bfin-linux-tdep.c: Sort headers.
4785         * bfd-target.c: Sort headers.
4786         * bcache.c: Sort headers.
4787         * ax-general.c: Sort headers.
4788         * ax-gdb.h: Sort headers.
4789         * ax-gdb.c: Sort headers.
4790         * avr-tdep.c: Sort headers.
4791         * auxv.c: Sort headers.
4792         * auto-load.c: Sort headers.
4793         * arm-wince-tdep.c: Sort headers.
4794         * arm-tdep.c: Sort headers.
4795         * arm-symbian-tdep.c: Sort headers.
4796         * arm-pikeos-tdep.c: Sort headers.
4797         * arm-obsd-tdep.c: Sort headers.
4798         * arm-nbsd-tdep.c: Sort headers.
4799         * arm-nbsd-nat.c: Sort headers.
4800         * arm-linux-tdep.c: Sort headers.
4801         * arm-linux-nat.c: Sort headers.
4802         * arm-fbsd-tdep.c: Sort headers.
4803         * arm-fbsd-nat.c: Sort headers.
4804         * arm-bsd-tdep.c: Sort headers.
4805         * arch-utils.c: Sort headers.
4806         * arc-tdep.c: Sort headers.
4807         * arc-newlib-tdep.c: Sort headers.
4808         * annotate.h: Sort headers.
4809         * annotate.c: Sort headers.
4810         * amd64-windows-tdep.c: Sort headers.
4811         * amd64-windows-nat.c: Sort headers.
4812         * amd64-tdep.c: Sort headers.
4813         * amd64-sol2-tdep.c: Sort headers.
4814         * amd64-obsd-tdep.c: Sort headers.
4815         * amd64-obsd-nat.c: Sort headers.
4816         * amd64-nbsd-tdep.c: Sort headers.
4817         * amd64-nbsd-nat.c: Sort headers.
4818         * amd64-nat.c: Sort headers.
4819         * amd64-linux-tdep.c: Sort headers.
4820         * amd64-linux-nat.c: Sort headers.
4821         * amd64-fbsd-tdep.c: Sort headers.
4822         * amd64-fbsd-nat.c: Sort headers.
4823         * amd64-dicos-tdep.c: Sort headers.
4824         * amd64-darwin-tdep.c: Sort headers.
4825         * amd64-bsd-nat.c: Sort headers.
4826         * alpha-tdep.c: Sort headers.
4827         * alpha-obsd-tdep.c: Sort headers.
4828         * alpha-nbsd-tdep.c: Sort headers.
4829         * alpha-mdebug-tdep.c: Sort headers.
4830         * alpha-linux-tdep.c: Sort headers.
4831         * alpha-linux-nat.c: Sort headers.
4832         * alpha-bsd-tdep.c: Sort headers.
4833         * alpha-bsd-nat.c: Sort headers.
4834         * aix-thread.c: Sort headers.
4835         * agent.c: Sort headers.
4836         * addrmap.c: Sort headers.
4837         * ada-varobj.c: Sort headers.
4838         * ada-valprint.c: Sort headers.
4839         * ada-typeprint.c: Sort headers.
4840         * ada-tasks.c: Sort headers.
4841         * ada-lang.c: Sort headers.
4842         * aarch64-tdep.c: Sort headers.
4843         * aarch64-ravenscar-thread.c: Sort headers.
4844         * aarch64-newlib-tdep.c: Sort headers.
4845         * aarch64-linux-tdep.c: Sort headers.
4846         * aarch64-linux-nat.c: Sort headers.
4847         * aarch64-fbsd-tdep.c: Sort headers.
4848         * aarch64-fbsd-nat.c: Sort headers.
4849         * aarch32-linux-nat.c: Sort headers.
4850
4851 2019-04-04  Tom Tromey  <tom@tromey.com>
4852
4853         * varobj.c (varobj_create): Update.
4854         * rust-exp.y (struct rust_parser) <update_innermost_block,
4855         lookup_symbol>: New methods.
4856         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4857         Rename.
4858         (rust_parser::rust_lookup_type)
4859         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4860         * printcmd.c (display_command, do_one_display): Update.
4861         * parser-defs.h (struct parser_state) <parser_state>: Add
4862         "tracker" parameter.
4863         (block_tracker): New member.
4864         (class innermost_block_tracker) <innermost_block_tracker>: Add
4865         "types" parameter.
4866         <reset>: Remove method.
4867         (innermost_block): Don't declare.
4868         (null_post_parser): Update.
4869         * parse.c (innermost_block): Remove global.
4870         (write_dollar_variable): Update.
4871         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4872         Remove "tracker_types" parameter.
4873         (parse_expression): Add "tracker" parameter.
4874         (parse_expression_for_completion): Update.
4875         (null_post_parser): Add "tracker" parameter.
4876         * p-exp.y: Update rules.
4877         * m2-exp.y: Update rules.
4878         * language.h (struct language_defn) <la_post_parser>: Add
4879         "tracker" parameter.
4880         * go-exp.y: Update rules.
4881         * f-exp.y: Update rules.
4882         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4883         parameter.
4884         * d-exp.y: Update rules.
4885         * c-exp.y: Update rules.
4886         * breakpoint.c (set_breakpoint_condition): Create an
4887         innermost_block_tracker.
4888         (watch_command_1): Likewise.
4889         * ada-lang.c (resolve): Add "tracker" parameter.
4890         (resolve_subexp): Likewise.
4891         * ada-exp.y (write_var_from_sym): Update.
4892
4893 2019-04-04  Tom Tromey  <tom@tromey.com>
4894
4895         * type-stack.h: New file.
4896         * type-stack.c: New file.
4897         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4898         type-stack.h.
4899         (insert_into_type_stack, insert_type, push_type, push_type_int)
4900         (insert_type_address_space, pop_type, pop_type_int)
4901         (pop_typelist, pop_type_stack, append_type_stack)
4902         (push_type_stack, get_type_stack, push_typelist)
4903         (follow_type_instance_flags, follow_types): Don't declare.
4904         * parse.c (type_stack): Remove global.
4905         (parse_exp_in_context): Update.
4906         (insert_into_type_stack, insert_type, push_type, push_type_int)
4907         (insert_type_address_space, pop_type, pop_type_int)
4908         (pop_typelist, pop_type_stack, append_type_stack)
4909         (push_type_stack, get_type_stack, push_typelist)
4910         (follow_type_instance_flags, follow_types): Remove (moved to
4911         type-stack.c).
4912         * f-exp.y (type_stack): New global.
4913         Update rules.
4914         (push_kind_type, f_parse): Update.
4915         * d-exp.y (type_stack): New global.
4916         Update rules.
4917         (d_parse): Update.
4918         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4919         Update rules.
4920         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4921         (HFILES_NO_SRCDIR): Add type-stack.h.
4922
4923 2019-04-04  Tom Tromey  <tom@tromey.com>
4924
4925         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4926         (rust_parser::convert_ast_to_expression, rust_parse)
4927         (rust_lex_test_completion, rust_lex_tests): Update.
4928         * parser-defs.h (struct expr_completion_state): New.
4929         (struct parser_state) <parser_state>: Add completion parameter.
4930         <mark_struct_expression, mark_completion_tag>: New methods.
4931         <parse_completion, m_completion_state>: New members.
4932         (prefixify_expression, null_post_parser): Update.
4933         (mark_struct_expression, mark_completion_tag): Don't declare.
4934         * parse.c (parse_completion, expout_last_struct)
4935         (expout_tag_completion_type, expout_completion_name): Remove
4936         globals.
4937         (parser_state::mark_struct_expression)
4938         (parser_state::mark_completion_tag): Now methods.
4939         (prefixify_expression): Add last_struct parameter.
4940         (prefixify_subexp): Likewise.
4941         (parse_exp_1): Update.
4942         (parse_exp_in_context): Add cstate parameter.  Update.
4943         (parse_expression_for_completion): Create an
4944         expr_completion_state.
4945         (null_post_parser): Add "completion" parameter.
4946         * p-exp.y: Update rules.
4947         (yylex): Update.
4948         * language.h (struct language_defn) <la_post_parser>: Add
4949         "completing" parameter.
4950         * go-exp.y: Update rules.
4951         (lex_one_token): Update.
4952         * expression.h (parse_completion): Don't declare.
4953         * d-exp.y: Update rules.
4954         (lex_one_token): Update rules.
4955         * c-exp.y: Update rules.
4956         (lex_one_token): Update.
4957         * ada-lang.c (resolve): Add "parse_completion" parameter.
4958         (resolve_subexp): Likewise.
4959         (ada_resolve_function): Likewise.
4960
4961 2019-04-04  Tom Tromey  <tom@tromey.com>
4962
4963         * parser-defs.h (struct parser_state) <start_arglist,
4964         end_arglist>: New methods.
4965         <arglist_len, m_funcall_chain>: New members.
4966         (arglist_len, start_arglist, end_arglist): Don't declare.
4967         * parse.c (arglist_len, funcall_chain): Remove global.
4968         (start_arglist, end_arglist): Remove functions.
4969         (parse_exp_in_context): Update.
4970         * p-exp.y: Update rules.
4971         * m2-exp.y: Update rules.
4972         * go-exp.y: Update rules.
4973         * f-exp.y: Update rules.
4974         * d-exp.y: Update rules.
4975         * c-exp.y: Update rules.
4976
4977 2019-04-04  Tom Tromey  <tom@tromey.com>
4978
4979         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4980         lex_operator, push_back>: New methods.
4981         Update all rules.
4982         (rust_parser::lex_hex, lex_escape): Rename and update.
4983         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4984         (rust_parser::lex_operator): Rename and update.
4985         (rust_parser::lex_number, rustyylex, rustyyerror)
4986         (rust_lex_test_init, rust_lex_test_sequence)
4987         (rust_lex_test_push_back, rust_lex_tests): Update.
4988         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4989         parameter.
4990         <lexptr, prev_lexptr>: New members.
4991         (lexptr, prev_lexptr): Don't declare.
4992         * parse.c (lexptr, prev_lexptr): Remove globals.
4993         (parse_exp_in_context): Update.
4994         * p-exp.y (yylex, yyerror): Update.
4995         * m2-exp.y (parse_number, yylex, yyerror): Update.
4996         * go-exp.y (lex_one_token, yyerror): Update.
4997         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4998         * d-exp.y (lex_one_token, yyerror): Update.
4999         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5000         (lex_one_token, yyerror): Update.
5001         * ada-lex.l (YY_INPUT): Update.
5002         (rewind_to_char): Update.
5003         * ada-exp.y (yyerror): Update.
5004
5005 2019-04-04  Tom Tromey  <tom@tromey.com>
5006
5007         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5008         * parser-defs.h (struct parser_state) <parser_state>: Add new
5009         parameter.
5010         <comma_terminates>: New member.
5011         (comma_terminates): Don't declare global.
5012         * parse.c (comma_terminates): Remove global.
5013         (parse_exp_in_context): Update.
5014         * p-exp.y (yylex): Update.
5015         * m2-exp.y (yylex): Update.
5016         * go-exp.y (lex_one_token): Update.
5017         * f-exp.y (yylex): Update.
5018         * d-exp.y (lex_one_token): Update.
5019         * c-exp.y (lex_one_token): Update.
5020         * ada-lex.l: Update.
5021
5022 2019-04-04  Tom Tromey  <tom@tromey.com>
5023
5024         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5025         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5026         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5027         * parser-defs.h (paren_depth): Don't declare.
5028         * parse.c (paren_depth): Remove global.
5029         (parse_exp_in_context): Update.
5030         * p-exp.y (paren_depth): New global.
5031         (pascal_parse): Initialize it.
5032         * m2-exp.y (paren_depth): New global.
5033         (m2_parse): Initialize it.
5034         * go-exp.y (paren_depth): New global.
5035         (go_parse): Initialize it.
5036         * f-exp.y (paren_depth): New global.
5037         (f_parse): Initialize it.
5038         * d-exp.y (paren_depth): New global.
5039         (d_parse): Initialize it.
5040         * c-exp.y (paren_depth): New global.
5041         (c_parse): Initialize it.
5042         * ada-lex.l (paren_depth): New global.
5043         (lexer_init): Initialize it.
5044
5045 2019-04-04  Tom Tromey  <tom@tromey.com>
5046
5047         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5048         (rust_parser::convert_ast_to_type)
5049         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5050         * parser-defs.h (struct parser_state) <parser_state>: Add
5051         parameters.  Initialize new members.
5052         <expression_context_block, expression_context_pc>: New members.
5053         * parse.c (expression_context_block, expression_context_pc):
5054         Remove globals.
5055         (parse_exp_in_context): Update.
5056         * p-exp.y: Update all rules.
5057         (yylex): Update.
5058         * m2-exp.y: Update all rules.
5059         (yylex): Update.
5060         * go-exp.y (yylex): Update.
5061         * f-exp.y (yylex): Update.
5062         * d-exp.y: Update all rules.
5063         (yylex): Update.
5064         * c-exp.y: Update all rules.
5065         (lex_one_token, classify_name, yylex, c_parse): Update.
5066         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5067
5068 2019-04-04  Tom Tromey  <tom@tromey.com>
5069
5070         * gdbarch.h, gdbarch.c: Rebuild.
5071         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5072         * stap-probe.h: 
5073         (struct stap_parse_info): Replace "parser_state" with
5074         "expr_builder".
5075         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5076         (parser_state): New class.
5077         * parse.c (expr_builder): Rename.
5078         (expr_builder::release): Rename.
5079         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5080         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5081         (write_exp_elt_longcst, write_exp_elt_floatcst)
5082         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5083         (write_exp_string_vector, write_exp_bitstring)
5084         (write_exp_msymbol, mark_struct_expression)
5085         (write_dollar_variable)
5086         (insert_type_address_space, increase_expout_size): Replace
5087         "parser_state" with "expr_builder".
5088         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5089         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5090         "parser_state" with "expr_builder".
5091
5092 2019-04-04  Tom Tromey  <tom@tromey.com>
5093
5094         * rust-exp.y: Replace "parse_language" with method call.
5095         * p-exp.y: 
5096         (yylex): Replace "parse_language" with method call.
5097         * m2-exp.y: 
5098         (yylex): Replace "parse_language" with method call.
5099         * go-exp.y (classify_name): Replace "parse_language" with method
5100         call.
5101         * f-exp.y (yylex): Replace "parse_language" with method call.
5102         * d-exp.y (lex_one_token): Replace "parse_language" with method
5103         call.
5104         * c-exp.y: 
5105         (lex_one_token, classify_name, yylex): Replace "parse_language"
5106         with method call.
5107         * ada-exp.y (find_primitive_type, type_char)
5108         (type_system_address): Replace "parse_language" with method call.
5109
5110 2019-04-04  Tom Tromey  <tom@tromey.com>
5111
5112         * rust-exp.y: Replace "parse_gdbarch" with method call.
5113         * parse.c (write_dollar_variable, insert_type_address_space):
5114         Replace "parse_gdbarch" with method call.
5115         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5116         call.
5117         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5118         call.
5119         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5120         "parse_gdbarch" with method call.
5121         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5122         with method call.
5123         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5124         "parse_gdbarch" with method call.
5125         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5126         "parse_gdbarch" with method call.
5127         * c-exp.y (parse_type, parse_number, classify_name): Replace
5128         "parse_gdbarch" with method call.
5129         * ada-lex.l: Replace "parse_gdbarch" with method call.
5130         * ada-exp.y (parse_type, find_primitive_type, type_char)
5131         (type_system_address): Replace "parse_gdbarch" with method call.
5132
5133 2019-04-04  Tom Tromey  <tom@tromey.com>
5134
5135         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5136         * stap-probe.c (stap_parse_argument): Update.
5137         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5138         initial_size parameter.
5139         * rust-exp.y (rust_lex_tests): Update.
5140         * parse.c (parser_state): Update.
5141         (parse_exp_in_context): Update.
5142         * parser-defs.h (struct parser_state) <parser_state>: Remove
5143         "initial_size" parameter.
5144
5145 2019-04-04  Tom Tromey  <tom@tromey.com>
5146
5147         * parser-defs.h (increase_expout_size): Don't declare.
5148         * parse.c (increase_expout_size): Now static.
5149
5150 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5151
5152         * gnu-nat.c (gnu_nat_target::wait): Fix
5153         target_waitstatus_to_string call.
5154
5155 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * eval.c (evaluate_subexp_standard): Handle internal functions
5158         during Fortran function call handling.
5159
5160 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5161
5162         * NEWS: Mention new internal functions.
5163         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5164         (read_base_type): Use dwarf2_init_complex_target_type.
5165         * value.c (creal_internal_fn): New function.
5166         (cimag_internal_fn): New function.
5167         (_initialize_values): Register new internal functions.
5168
5169 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5170
5171         * infrun.c (stop_all_threads): If debug_infrun, always
5172         trace the wait status after wait_one, using
5173         target_waitstatus_to_string and target_pid_to_str.
5174         (handle_inferior_event): Replace various trace of
5175         wait status kind by a single trace.
5176         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5177         wait status kind image by target_waitstatus_to_string.
5178         * target/waitstatus.c (target_waitstatus_to_string): Fix
5179         obsolete comment.
5180
5181 2019-04-01  Tom Tromey  <tromey@adacore.com>
5182
5183         PR symtab/23331:
5184         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5185
5186 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5187             Pedro Alves  <palves@redhat.com>
5188
5189         * top.c (quit_force): Call 'finalize_values'.
5190         * value.c (finalize_values): New function.
5191         * value.h (finalize_values): Declare.
5192
5193 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5194
5195         * NEWS: Announce $_gdb_major and $_gdb_minor.
5196
5197         * top.c (init_gdb_version_vars): New function.
5198         (gdb_init): Call init_gdb_version_vars.
5199
5200 2019-03-29  Tom Tromey  <tromey@adacore.com>
5201
5202         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5203         help text.  Remove dead code.
5204
5205 2019-03-29  Keith Seitz  <keiths@redhat.com>
5206
5207         From Siddhesh Poyarekar:
5208         * f-lang.h (f77_get_upperbound): Return LONGEST.
5209         (f77_get_lowerbound): Likewise.
5210         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5211         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5212         print them.
5213         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5214         plongest to format print it.
5215         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5216         (f77_get_upperbound): Likewise.
5217         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5218         LOWER_BOUND to LONGEST.
5219         (f77_create_arrayprint_offset_tbl): Likewise.
5220
5221 2019-03-29  Keith Seitz  <keiths@redhat.com>
5222
5223         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5224         %s/pulongest for TYPE_LENGTH instead of %d in format
5225         strings.
5226         * ada-typerint.c (ada_print_type): Likewise.
5227         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5228         * compile/compile-c-support.c (generate_register_struct): Likewise.
5229         * gdbtypes.c (recursive_dump_type): Likewise.
5230         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5231         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5232         instead of %d in format strings.
5233         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5234         to std::min to ULONGEST.
5235         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5236         instead of %d in format strings.
5237         * tracepoint.c (info_scope_command): Likewise.
5238         * typeprint.c (print_offset_data::update)
5239         (print_offset_data::finish): Likewise.
5240         * xtensa-tdep.c (xtensa_store_return_value)
5241         (xtensa_push_dummy_call): Likewise.
5242
5243 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5244
5245         * windows-nat.c (display_selector): Fixed format specifications
5246         for 64-bit Cygwin.
5247
5248 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5249
5250         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5251
5252 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5253
5254         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5255         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5256         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5257         (nios2_linux_init_abi): Install it.
5258
5259 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5260
5261         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5262
5263 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5264
5265         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5266
5267 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5268             Tom Tromey  <tromey@adacore.com>
5269
5270         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5271
5272 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5273
5274         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5275         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5276         method to compute the bounds of range types. Also print "[evaluated]"
5277         if the bounds' values come from a dynamic evaluation.
5278
5279 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5282         whitespace when pretty printing is on.
5283
5284 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5285
5286         * ppc-linux-nat.c: Add include.
5287
5288 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5289
5290         * NEWS: Mention AArch64 Pointer Authentication.
5291
5292 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * arm-linux-nat.c: Add include.
5295
5296 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5297
5298         * source-cache.c (source_cache::get_source_lines): Re-read
5299         fullname after calling open_source_file.
5300
5301 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5302
5303         * NEWS: Mention TLS support for FreeBSD.
5304
5305 2019-03-25  Tom Tromey  <tromey@adacore.com>
5306
5307         * minsyms.c (BUNCH_SIZE): Update comment.
5308         (~minimal_symbol_reader): Remove old comment.
5309         (compact_minimal_symbols): Update comment.
5310         (minimal_symbol_reader::install): Remove old comment.  Update
5311         other comments.
5312
5313 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5314
5315         * s390-linux-nat.c: Add include.
5316
5317 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5318
5319         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5320         Call linux_get_hwcap.
5321         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5322         Likewise.
5323         (aarch64_linux_get_hwcap): Remove function.
5324         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5325         declaration.
5326         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5327         linux_get_hwcap.
5328         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5329         * linux-tdep.c (linux_get_hwcap): Add function.
5330         (linux_get_hwcap2): Likewise.
5331         * linux-tdep.h (linux_get_hwcap): Add declaration.
5332         (linux_get_hwcap2): Likewise.
5333         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5334         (ppc_linux_get_hwcap2): Likewise.
5335         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5336         linux_get_hwcap.
5337         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5338         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5339         (ppc_linux_nat_target::read_description): Likewise.
5340         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5341         * s390-linux-nat.c: Likewise.
5342         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5343
5344 2019-03-24  Tom Tromey  <tom@tromey.com>
5345
5346         * ada-lang.c (standard_lookup): Simplify initialization.
5347         (ada_lookup_symbol_nonlocal): Simplify return.
5348         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5349         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5350         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5351         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5352         initialization.
5353         * solib.c (solib_global_lookup): Simplify.
5354         * symtab.c (null_block_symbol): Remove.
5355         (symbol_cache_lookup): Simplify returns.
5356         (lookup_language_this): Simplify returns.
5357         (lookup_symbol_aux): Simplify return.
5358         (lookup_local_symbol): Simplify returns.
5359         (lookup_global_symbol_from_objfile): Simplify return.
5360         (lookup_symbol_in_objfile_symtabs)
5361         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5362         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5363         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5364         * cp-namespace.c (cp_lookup_bare_symbol)
5365         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5366         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5367         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5368         (cp_lookup_symbol_via_imports): Simplify initialization.
5369         (find_symbol_in_baseclass): Likewise.
5370         * symtab.h (null_block_symbol): Remove.
5371         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5372         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5373         (d_lookup_symbol_module): Likewise.
5374         (find_symbol_in_baseclass): Simplify initialization.
5375
5376 2019-03-24  Tom Tromey  <tom@tromey.com>
5377
5378         * expression.h: Don't include symtab.h.
5379         (struct block): Forward declare.
5380
5381 2019-03-24  Tom Tromey  <tom@tromey.com>
5382
5383         * c-exp.y (typebase): Remove casts.
5384         * gdbtypes.c (lookup_unsigned_typename, )
5385         (lookup_signed_typename): Remove cast.
5386         * eval.c (parse_to_comma_and_eval): Remove cast.
5387         * parse.c (write_dollar_variable): Remove cast.
5388         * block.h (struct block) <superblock>: Now const.
5389         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5390         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5391         (map_block): Make "block" const.
5392         * symfile.h (struct quick_symbol_functions)
5393         <map_matching_symbols>: Constify block argument to "callback".
5394         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5395         const.
5396         (find_pc_sect_compunit_symtab): Make "b" const.
5397         (find_symbol_at_address): Likewise.
5398         (search_symbols): Likewise.
5399         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5400         (dw2_debug_names_lookup_symbol): Likewise.
5401         (dw2_map_matching_symbols): Update.
5402         * p-valprint.c (pascal_val_print): Remove "block".
5403         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5404         (aux_add_nonlocal_symbols): Make "block" const.
5405         (resolve_subexp): Remove cast.
5406         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5407         const.
5408         (iterate_over_file_blocks): Likewise.
5409         * f-exp.y (%union) <bval>: Remove.
5410         * coffread.c (patch_opaque_types): Make "b" const.
5411         * spu-tdep.c (spu_catch_start): Make "block" const.
5412         * c-valprint.c (print_unpacked_pointer): Remove "block".
5413         * symmisc.c (dump_symtab_1): Make "b" const.
5414         (block_depth): Make "block" const.
5415         * d-exp.y (%union) <bval>: Remove.
5416         * cp-support.h (cp_lookup_rtti_type): Update.
5417         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5418         * psymtab.c (psym_lookup_symbol): Make "block" const.
5419         (maintenance_check_psymtabs): Make "b" const.
5420         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5421         (enumerate_locals, enumerate_args): Update.
5422         * python/py-symtab.c (stpy_global_block): Make "block" const.
5423         (stpy_static_block): Likewise.
5424         * inline-frame.c (block_starting_point_at): Make "new_block"
5425         const.
5426         * block.c (find_block_in_blockvector): Make return type const.
5427         (blockvector_for_pc_sect): Make "b" const.
5428         (find_block_in_blockvector): Make "b" const.
5429
5430 2019-03-23  Tom Tromey  <tom@tromey.com>
5431
5432         * varobj.c (varobj_create): Update.
5433         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5434         * printcmd.c (display_command, do_one_display): Don't reset
5435         innermost_block.
5436         * parser-defs.h (enum innermost_block_tracker_type): Move to
5437         expression.h.
5438         (innermost_block): Update comment.
5439         * parse.c (parse_exp_1): Add tracker_types parameter.
5440         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5441         tracker_types parameter.  Reset innermost_block.
5442         (parse_exp_in_context): Remove.
5443         (parse_expression_for_completion): Update.
5444         * objfiles.c (~objfile): Don't reset expression_context_block or
5445         innermost_block.
5446         * expression.h (enum innermost_block_tracker_type): Move from
5447         parser-defs.h.
5448         (parse_exp_1): Add tracker_types parameter.
5449         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5450         reset innermost_block.
5451
5452 2019-03-23  Tom Tromey  <tom@tromey.com>
5453
5454         * objfiles.h: Include bcache.h.
5455
5456 2019-03-23  Tom Tromey  <tom@tromey.com>
5457
5458         * linespec.c (get_current_search_block): Use
5459         scoped_restore_current_language.
5460         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5461
5462 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5463             Jiong Wang  <jiong.wang@arm.com>
5464
5465         * aarch64-linux-tdep.c
5466         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5467         section.
5468         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5469
5470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5471             Jiong Wang  <jiong.wang@arm.com>
5472
5473         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5474         instructions.
5475         (aarch64_analyze_prologue_test): Add PACIASP test.
5476         (aarch64_prologue_prev_register): Unmask PC value.
5477
5478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5479             Jiong Wang  <jiong.wang@arm.com>
5480
5481         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5482         (aarch64_dwarf2_prev_register): Unmask PC value.
5483         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5484         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5485         DW_CFA_AARCH64_negate_ra_state.
5486         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5487
5488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5489             Jiong Wang  <jiong.wang@arm.com>
5490
5491         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5492         registers.
5493         (aarch64_pseudo_register_name): Likewise.
5494         (aarch64_pseudo_register_type): Likewise.
5495         (aarch64_pseudo_register_reggroup_p): Likewise.
5496         (aarch64_gdbarch_init): Add pauth registers.
5497         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5498         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5499         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5500         (struct gdbarch_tdep): Add regnum for ra_state.
5501
5502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5503             Jiong Wang  <jiong.wang@arm.com>
5504
5505         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5506
5507 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5508             Jiong Wang  <jiong.wang@arm.com>
5509
5510         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5511         function.
5512         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5513         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5514         (aarch64_gdbarch_init): Add puth registers.
5515         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5516         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5517         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5518
5519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5520             Jiong Wang  <jiong.wang@arm.com>
5521
5522         * aarch64-linux-nat.c
5523         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5524         * aarch64-linux-tdep.c
5525         (aarch64_linux_core_read_description): Likewise.
5526         (aarch64_linux_get_hwcap): New function.
5527         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5528         (aarch64_linux_get_hwcap): New declaration.
5529
5530 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5531             Jiong Wang  <jiong.wang@arm.com>
5532
5533         * aarch64-linux-nat.c
5534         (aarch64_linux_nat_target::read_description): Add pauth param.
5535         * aarch64-linux-tdep.c
5536         (aarch64_linux_core_read_description): Likewise.
5537         * aarch64-tdep.c (struct target_desc): Add in pauth.
5538         (aarch64_read_description): Add pauth param.
5539         (aarch64_gdbarch_init): Likewise.
5540         * aarch64-tdep.h (aarch64_read_description): Likewise.
5541         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5542         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5543         * features/Makefile: Add new files.
5544         * features/aarch64-pauth.c: New file.
5545         * features/aarch64-pauth.xml: New file.
5546
5547 2019-03-20  Tom Tromey  <tromey@adacore.com>
5548
5549         * infrun.c (handle_inferior_event): Rename from
5550         handle_inferior_event_1.  Create a scoped_value_mark.
5551         (handle_inferior_event): Remove.
5552
5553 2019-03-19  Tom Tromey  <tromey@adacore.com>
5554
5555         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5556         * infrun.h (print_stop_event): Add "displays" parameter.
5557         * infrun.c (print_stop_event): Add "displays" parameter.
5558
5559 2019-03-19  Pedro Alves  <palves@redhat.com>
5560
5561         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5562         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5563         to -1.  Fix TABs vs spaces.
5564         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5565         * tui/tui-out.h (tui_ui_out) Add intro comments.
5566         <m_line, m_start_of_line>: In-class initialize, and add describing
5567         comment.
5568
5569 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5570
5571         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5572         variable names.
5573         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5574
5575 2019-03-18  Pedro Alves  <palves@redhat.com>
5576             Eli Zaretskii <eliz@gnu.org>
5577
5578         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5579         m_line and m_start_of_line.
5580
5581 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5582
5583         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5584         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5585         it returns a newline.  This fixes a regression in TU mode, whereby
5586         the next line is output on the same screen line as the user input.
5587
5588 2019-03-18  Tom Tromey  <tromey@adacore.com>
5589
5590         * minsyms.c (minimal_symbol_reader::install): Remove call to
5591         obstack_blank.
5592
5593 2019-03-18  Pedro Alves  <palves@redhat.com>
5594
5595         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5596         New globals.
5597         (apply_style): New, factored out from ...
5598         (apply_ansi_escape): ... this.  Handle reverse video mode.
5599         (tui_set_reverse_mode): New function.
5600         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5601         * tui/tui-winsource.c (tui_show_source_line): Use
5602         tui_set_reverse_mode instead of setting A_STANDOUT.
5603         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5604         New setter methods.
5605
5606 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5607
5608         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5609         Handle tabs.
5610
5611 2019-03-18  Tom Tromey  <tromey@adacore.com>
5612
5613         * ada-lang.c (empty_array): Add "high" parameter.
5614         (ada_evaluate_subexp): Update.
5615
5616 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5617
5618         * unittests/string_view-selftests.c: Define
5619         _initialize_string_view_selftests unconditionally.
5620
5621 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5622
5623         PR gdb/24350
5624         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5625
5626 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5627
5628         PR gdb/24351
5629         * windows-nat.c (display_selector): Fix format specifiers.
5630
5631 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5632
5633         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5634         tui_refill_source_window instead of tui_refresh_win, to update the
5635         current execution line.  This fixes redisplay of the current line
5636         when stepping through the code with "next" or "step".
5637
5638 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5639
5640         * source-cache.c (source_cache::get_source_lines): Call
5641         find_source_lines to initialize s->nlines.  This fixes vertical
5642         scrolling of TUI source window when the DOWN arrow is pressed.
5643
5644 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5645
5646         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5647         linux-thread-db.c (_initialize_thread_db): Likewise.
5648
5649 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5650
5651         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5652         wclrtoeol in tui_show_source_line".  This reverts changes made in
5653         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5654
5655 2019-03-15  Tom Tromey  <tom@tromey.com>
5656
5657         * symtab.h (struct minimal_symbol): Derive from
5658         general_symbol_info.
5659         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5660         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5661         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5662         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5663         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5664         (MSYMBOL_SEARCH_NAME): Update.
5665         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5666         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5667         * minsyms.c (minimal_symbol_reader::record_full): Update.
5668
5669 2019-03-15  Tom Tromey  <tom@tromey.com>
5670
5671         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5672
5673 2019-03-15  Tom Tromey  <tom@tromey.com>
5674
5675         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5676         unique_xmalloc_ptr.
5677         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5678         Update.
5679         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5680         (build_minimal_symbol_hash_tables)
5681         (minimal_symbol_reader::install): Update.
5682
5683 2019-03-15  Tom Tromey  <tom@tromey.com>
5684
5685         * symtab.c (create_demangled_names_hash): Update.
5686         (symbol_set_names): Update.
5687         * objfiles.h (struct objfile_per_bfd_storage)
5688         <demangled_names_hash>: Now an htab_up.
5689         * objfiles.c (objfile_per_bfd_storage): Simplify.
5690
5691 2019-03-15  Tom Tromey  <tom@tromey.com>
5692
5693         * objfiles.h (struct objfile_per_bfd_storage): Declare
5694         destructor.
5695         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5696         New.
5697         (get_objfile_bfd_data): Use new.  Don't initialize
5698         language_of_main.
5699         (free_objfile_per_bfd_storage): Remove.
5700         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5701
5702 2019-03-15  Tom Tromey  <tom@tromey.com>
5703
5704         * symfile.c (reread_symbols): Update.
5705         * objfiles.c (objfile::objfile): Update.
5706         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5707         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5708         comment.
5709         (minimal_symbol_reader::install): Update.
5710         (terminate_minimal_symbol_table): Remove.
5711         * jit.c (jit_object_close_impl): Update.
5712
5713 2019-03-15  Tom Tromey  <tom@tromey.com>
5714
5715         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5716         initializations.
5717
5718 2019-03-15  Tom Tromey  <tom@tromey.com>
5719
5720         * objfiles.h (struct objfile_per_bfd_storage)
5721         <demangled_hash_languages>: Now a bitset.
5722         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5723         (lookup_minimal_symbol): Update.
5724
5725 2019-03-15  Tom Tromey  <tom@tromey.com>
5726
5727         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5728         Don't return the symbol.
5729         * coffread.c (record_minimal_symbol): Use record_full.
5730
5731 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5732
5733         The MS-Windows port of ncurses fails to switch to a color pair if
5734         one or both of the colors are the implicit default colors.  This
5735         change records the default colors when TUI is initialized, and
5736         then specifies them explicitly when a color pair uses the default
5737         colors.  This allows color styling in TUI mode on MS-Windows.
5738
5739         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5740         ncurses_norm_attr.
5741         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5742         colors in ncurses_norm_attr.
5743         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5744         "none", replace it with the default color recorded in
5745         ncurses_norm_attr.
5746
5747 2019-03-14  Tom Tromey  <tromey@adacore.com>
5748
5749         * source-cache.h (class source_cache) <get_source_lines>: Return
5750         std::string.
5751         * source-cache.c (source_cache::extract_lines): Handle case where
5752         first_pos==npos.  Return std::string.
5753         (source_cache::get_source_lines): Update.
5754
5755 2019-03-14  Tom Tromey  <tromey@adacore.com>
5756
5757         * NEWS: Add item for "style sources" commands.
5758         * source-cache.c (source_cache::get_source_lines): Check
5759         source_styling.
5760         * cli/cli-style.c (source_styling): New global.
5761         (_initialize_cli_style): Add "style sources" commands.
5762         (show_style_sources): New function.
5763         * cli/cli-style.h (source_styling): Declare.
5764
5765 2019-03-14  Pedro Alves  <palves@redhat.com>
5766             Tom Tromey  <tromey@adacore.com>
5767
5768         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5769         * tui/tui-winsource.c (tui_refill_source_window): New function,
5770         from...
5771         (tui_horizontal_source_scroll): ... here.  Move some logic.
5772         * cli/cli-style.c (set_style_enabled): Notify new observable.
5773         * tui/tui-hooks.c (tui_redisplay_source): New function.
5774         (tui_attach_detach_observers): Attach or detach
5775         tui_redisplay_source.
5776         * observable.h (source_styling_changed): New observable.
5777         * observable.c: Define source_styling_changed observable.
5778
5779 2019-03-13  Tom Tromey  <tromey@adacore.com>
5780
5781         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5782         (i386_gnu_nat_target::store_registers): Update.
5783         * target-debug.h (target_debug_print_std_string): New macro.
5784         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5785         * windows-tdep.c (display_one_tib): Update.
5786         * tui/tui-stack.c (tui_make_status_line): Update.
5787         * top.c (print_inferior_quit_action): Update.
5788         * thread.c (thr_try_catch_cmd): Update.
5789         (add_thread_with_info): Update.
5790         (thread_target_id_str): Update.
5791         (thr_try_catch_cmd): Update.
5792         (thread_command): Update.
5793         (thread_find_command): Update.
5794         * record-btrace.c (record_btrace_target::info_record)
5795         (record_btrace_resume_thread, record_btrace_target::resume)
5796         (record_btrace_cancel_resume, record_btrace_step_thread)
5797         (record_btrace_target::wait, record_btrace_target::wait)
5798         (record_btrace_target::wait, record_btrace_target::stop): Update.
5799         * progspace.c (print_program_space): Update.
5800         * process-stratum-target.c
5801         (process_stratum_target::thread_address_space): Update.
5802         * linux-fork.c (linux_fork_mourn_inferior)
5803         (detach_checkpoint_command, info_checkpoints_command)
5804         (linux_fork_context): Update.
5805         (linux_fork_detach): Update.
5806         (class scoped_switch_fork_info): Update.
5807         (delete_checkpoint_command): Update.
5808         * infrun.c (follow_fork_inferior): Update.
5809         (follow_fork_inferior): Update.
5810         (proceed_after_vfork_done): Update.
5811         (handle_vfork_child_exec_or_exit): Update.
5812         (follow_exec): Update.
5813         (displaced_step_prepare_throw): Update.
5814         (displaced_step_restore): Update.
5815         (start_step_over): Update.
5816         (resume_1): Update.
5817         (clear_proceed_status_thread): Update.
5818         (proceed): Update.
5819         (print_target_wait_results): Update.
5820         (do_target_wait): Update.
5821         (context_switch): Update.
5822         (stop_all_threads): Update.
5823         (restart_threads): Update.
5824         (finish_step_over): Update.
5825         (handle_signal_stop): Update.
5826         (switch_back_to_stepped_thread): Update.
5827         (keep_going_pass_signal): Update.
5828         (print_exited_reason): Update.
5829         (normal_stop): Update.
5830         * inferior.c (inferior_pid_to_str): Change return type.
5831         (print_selected_inferior): Update.
5832         (add_inferior): Update.
5833         (detach_inferior): Update.
5834         * dummy-frame.c (fprint_dummy_frames): Update.
5835         * dcache.c (dcache_info_1): Update.
5836         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5837         (btrace_fetch, btrace_clear): Update.
5838         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5839         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5840         type.
5841         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5842         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5843         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5844         * gdbarch.c, gdbarch.h: Rebuild.
5845         * gdbarch.sh (core_pid_to_str): Change return type.
5846         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5847         return type.
5848         (windows_nat_target::pid_to_str): Change return type.
5849         (windows_delete_thread): Update.
5850         (windows_nat_target::attach): Update.
5851         (windows_nat_target::files_info): Update.
5852         * target-delegates.c: Rebuild.
5853         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5854         return type.
5855         (sol_thread_target::pid_to_str): Change return type.
5856         * remote.c (class remote_target) <pid_to_str>: Change return
5857         type.
5858         (remote_target::pid_to_str): Change return type.
5859         (extended_remote_target::attach, remote_target::remote_stop_ns)
5860         (remote_target::remote_notif_remove_queued_reply)
5861         (remote_target::push_stop_reply, remote_target::disable_btrace):
5862         Update.
5863         (extended_remote_target::attach): Update.
5864         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5865         type.
5866         (gdbsim_target::pid_to_str): Change return type.
5867         * ravenscar-thread.c (struct ravenscar_thread_target)
5868         <pid_to_str>: Change return type.
5869         (ravenscar_thread_target::pid_to_str): Change return type.
5870         * procfs.c (class procfs_target) <pid_to_str>: Change return
5871         type.
5872         (procfs_target::pid_to_str): Change return type.
5873         (procfs_target::attach): Update.
5874         (procfs_target::detach): Update.
5875         (procfs_target::fetch_registers): Update.
5876         (procfs_target::store_registers): Update.
5877         (procfs_target::wait): Update.
5878         (procfs_target::files_info): Update.
5879         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5880         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5881         return type.
5882         (nto_procfs_target::pid_to_str): Change return type.
5883         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5884         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5885         return type.
5886         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5887         (exit_lwp): Update.
5888         (attach_proc_task_lwp_callback, get_detach_signal)
5889         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5890         (linux_nat_target::resume, wait_lwp, stop_callback)
5891         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5892         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5893         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5894         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5895         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5896         type.
5897         (inf_ptrace_target::attach): Update.
5898         (inf_ptrace_target::files_info): Update.
5899         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5900         type.
5901         (go32_nat_target::pid_to_str): Change return type.
5902         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5903         (gnu_nat_target::wait): Update.
5904         (gnu_nat_target::wait): Update.
5905         (gnu_nat_target::resume): Update.
5906         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5907         (fbsd_nat_target::wait): Update.
5908         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5909         type.
5910         (darwin_nat_target::attach): Update.
5911         * corelow.c (class core_target) <pid_to_str>: Change return type.
5912         (core_target::pid_to_str): Change return type.
5913         * target.c (normal_pid_to_str): Change return type.
5914         (default_pid_to_str): Likewise.
5915         (target_pid_to_str): Change return type.
5916         (target_translate_tls_address): Update.
5917         (target_announce_detach): Update.
5918         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5919         return type.
5920         (bsd_uthread_target::pid_to_str): Change return type.
5921         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5922         type.
5923         (bsd_kvm_target::pid_to_str): Change return type.
5924         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5925         return type.
5926         (aix_thread_target::pid_to_str): Change return type.
5927         * target.h (struct target_ops) <pid_to_str>: Change return type.
5928         (target_pid_to_str, normal_pid_to_str): Likewise.
5929         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5930         type.
5931         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5932         type.
5933         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5934         return type.
5935         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5936         type.
5937         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5938         type.
5939         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5940         return type.
5941
5942 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5943
5944         * NEWS: Mention that the new default MI version is 3.  Mention
5945         changes to the output of commands and events that deal with
5946         multi-location breakpoints.
5947         * breakpoint.c: Include "mi/mi-out.h".
5948         (print_one_breakpoint): Change output syntax if using MI version
5949         >= 3.
5950         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5951         New.
5952         (mi_multi_location_breakpoint_output_fixed): New.
5953         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5954         (mi_cmd_fix_multi_location_breakpoint_output): New.
5955         (mi_multi_location_breakpoint_output_fixed): New.
5956         * mi/mi-cmds.c (mi_cmds): Register command
5957         -fix-multi-location-breakpoint-output.
5958         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5959         interpreter "mi".
5960
5961 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5962
5963         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5964         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5965         instantiate mi_ui_out based on interpreter name.
5966         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5967         * mi/mi-main.c (mi_load_progress): Likewise.
5968
5969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5970
5971         * NEWS: Combine separate "New targets" sections for 8.3.
5972
5973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5974
5975         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5976         (ppcfbsd_init_abi): Install gdbarch
5977         "fetch_tls_load_module_address" and "get_thread_local_address"
5978         methods.
5979
5980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5981
5982         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5983         (riscv_fbsd_init_abi): Install gdbarch
5984         "fetch_tls_load_module_address" and "get_thread_local_address"
5985         methods.
5986
5987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5988
5989         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5990         (i386fbsd_init_abi): Install gdbarch
5991         "fetch_tls_load_module_address" and "get_thread_local_address"
5992         methods.
5993
5994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5995
5996         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5997         (amd64fbsd_init_abi): Install gdbarch
5998         "fetch_tls_load_module_address" and "get_thread_local_address"
5999         methods.
6000
6001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6002
6003         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6004         (struct fbsd_pspace_data): New type.
6005         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6006         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6007         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6008         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6009         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6010
6011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6012
6013         * gdbtypes.c (lookup_struct_elt): New function.
6014         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6015         * gdbtypes.h (struct struct_elt): New type.
6016         (lookup_struct_elt): New prototype.
6017
6018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6019
6020         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6021         remove disabled code block.
6022
6023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6024
6025         * gdbarch.sh (get_thread_local_address): New method.
6026         * gdbarch.h, gdbarch.c: Regenerate.
6027         * target.c (target_translate_tls_address): Use
6028         gdbarch_get_thread_local_address if present instead of
6029         target::get_thread_local_address.
6030
6031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6032
6033         * target.h (target::get_thread_local_address): Update comment.
6034
6035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6036
6037         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6038         objfile->separate_debug_objfile_backlink if not NULL.
6039
6040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6041
6042         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6043         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6044         (amd64bsd_store_inferior_registers): Likewise.
6045         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6046         Enable segment base registers.
6047         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6048         PT_GETFSBASE and PT_GETGSBASE.
6049         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6050         PT_SETGSBASE.
6051         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6052         segment base registers.
6053         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6054
6055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6056
6057         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6058         Update calls to i386_target_description to add 'segments'
6059         parameter.
6060         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6061         add segment base registers.
6062         * arch/i386.c (i386_create_target_description): Add 'segments'
6063         parameter to enable segment base registers.
6064         * arch/i386.h (i386_create_target_description): Likewise.
6065         * features/i386/32bit-segments.xml: New file.
6066         * features/i386/32bit-segments.c: Generate.
6067         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6068         call to i386_target_description to add 'segments' parameter.
6069         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6070         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6071         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6072         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6073         if feature is present.
6074         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6075         Add 'segments' parameter to call to i386_target_description.
6076         (i386_target_description): Add 'segments' parameter to enable
6077         segment base registers.
6078         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6079         to call to i386_target_description.
6080         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6081         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6082         Define I386_NUM_REGS.
6083         (i386_target_description): Add 'segments' parameter to enable
6084         segment base registers.
6085
6086 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6087
6088         PR/24325
6089         * source-cache.c: #undef open and close, to avoid unresolved
6090         externals during linking.
6091
6092 2019-03-12  Tom Tromey  <tromey@adacore.com>
6093
6094         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6095         const.  Add initializers.
6096         (_initialize_remote): Don't initialize ptid globals.
6097
6098 2019-03-12  Pedro Alves  <palves@redhat.com>
6099
6100         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6101
6102 2019-03-12  Pedro Alves  <palves@redhat.com>
6103
6104         * cp-name-parser.y (main): Remove unused 'len' variable.
6105
6106 2019-03-12  Tom Tromey  <tromey@adacore.com>
6107
6108         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6109         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6110
6111 2019-03-12  Tom Tromey  <tromey@adacore.com>
6112
6113         * linux-nat.c (iterate_over_lwps): Update.
6114         (stop_callback): Remove parameter.
6115         (stop_wait_callback, detach_callback, resume_set_callback)
6116         (select_singlestep_lwp_callback, set_ignore_sigint)
6117         (status_callback, resumed_callback, resume_clear_callback)
6118         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6119         data parameter.
6120         (linux_nat_target::detach, linux_nat_target::resume)
6121         (linux_stop_and_wait_all_lwps, select_event_lwp)
6122         (linux_nat_filter_event, linux_nat_wait_1)
6123         (linux_nat_target::kill, linux_nat_target::stop)
6124         (linux_nat_target::stop): Update.
6125         (linux_nat_resume_callback): Change type.
6126         (resume_stopped_resumed_lwps, count_events_callback)
6127         (select_event_lwp_callback): Likewise.
6128         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6129         * arm-linux-nat.c (struct update_registers_data): Remove.
6130         (update_registers_callback): Change type.
6131         (arm_linux_insert_hw_breakpoint1): Update.
6132         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6133         parameter.
6134         (x86_linux_dr_set_addr): Update.
6135         (x86_linux_dr_set_control): Update.
6136         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6137         (iterate_over_lwps): Use gdb::function_view.
6138         * nat/aarch64-linux-hw-point.c (struct
6139         aarch64_dr_update_callback_param): Remove.
6140         (debug_reg_change_callback): Change type.
6141         (aarch64_notify_debug_reg_change): Update.
6142         * s390-linux-nat.c (s390_refresh_per_info): Update.
6143
6144 2019-03-11  Tom Tromey  <tromey@adacore.com>
6145
6146         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6147         redundant assignment to "this_cu".
6148
6149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6150
6151         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6152
6153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6154
6155         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6156         from...
6157         (rank_one_type): ... this.
6158
6159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6160
6161         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6162         from...
6163         (rank_one_type): ... this.
6164
6165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6166
6167         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6168         from...
6169         (rank_one_type): ... this.
6170
6171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6172
6173         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6174         from...
6175         (rank_one_type): ... this.
6176
6177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6178
6179         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6180         from...
6181         (rank_one_type): ... this.
6182
6183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6184
6185         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6186         from...
6187         (rank_one_type): ... this.
6188
6189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6190
6191         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6192         from...
6193         (rank_one_type): ... this.
6194
6195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6196
6197         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6198         from...
6199         (rank_one_type): ... this.
6200
6201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6202
6203         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6204         from...
6205         (rank_one_type): ... this.
6206
6207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6208
6209         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6210         from...
6211         (rank_one_type): ... this.
6212
6213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6214
6215         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6216         from...
6217         (rank_one_type): ... this.
6218
6219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6220
6221         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6222         from...
6223         (rank_one_type): ... this.
6224
6225 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6226
6227         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6228         inferior-events' shows the example events.
6229
6230 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6231
6232         Support styling on native MS-Windows console
6233
6234         PR/24315
6235         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6236         on MS-Windows if $TERM is not defined.
6237
6238         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6239
6240         * posix-hdep.c (gdb_console_fputs):
6241         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6242         functions.
6243         * ui-file.h (gdb_console_fputs): Add prototype.
6244
6245         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6246         back to fputs only if the former returns zero.
6247
6248 2019-03-07  Tom Tromey  <tom@tromey.com>
6249
6250         * symmisc.c (print_symbol_bcache_statistics): Update.
6251         (print_objfile_statistics): Update.
6252         * symfile.c (allocate_symtab): Update.
6253         * stabsread.c: Don't include bcache.h.
6254         * psymtab.h (struct psymbol_bcache): Don't declare.
6255         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6256         (psymbol_bcache_init, psymbol_bcache_free)
6257         (psymbol_bcache_get_bcache): Don't declare.
6258         * psymtab.c (struct psymbol_bcache): Remove.
6259         (psymtab_storage::psymtab_storage): Update.
6260         (psymtab_storage::~psymtab_storage): Update.
6261         (psymbol_bcache_init, psymbol_bcache_free)
6262         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6263         (add_psymbol_to_bcache): Update.
6264         (allocate_psymtab): Update.
6265         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6266         macro_cache>: No longer pointers.
6267         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6268         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6269         * macrotab.c (macro_bcache): Update.
6270         * macroexp.c: Don't include bcache.h.
6271         * gdbtypes.c (check_types_worklist): Update.
6272         (types_deeply_equal): Remove TRY/CATCH.  Update.
6273         * elfread.c (elf_symtab_read): Update.
6274         * dwarf2read.c: Don't include bcache.h.
6275         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6276         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6277         (print_bcache_statistics, bcache_memory_used): Don't declare.
6278         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6279         methods.  Rename all data members.
6280         * bcache.c (struct bcache): Move to bcache.h.
6281         (bcache::expand_hash_table): Rename from expand_hash_table.
6282         (bcache): Remove.
6283         (bcache::insert): Rename from bcache_full.
6284         (bcache::compare): Rename from bcache_compare.
6285         (bcache_xmalloc): Remove.
6286         (bcache::~bcache): Rename from bcache_xfree.
6287         (bcache::print_statistics): Rename from print_bcache_statistics.
6288         (bcache::memory_used): Rename from bcache_memory_used.
6289
6290 2019-03-07  Pedro Alves  <palves@redhat.com>
6291
6292         * infrun.c (normal_stop): Also check for
6293         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6294
6295 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6296
6297         * f-lang.c (value_from_host_double): Moved to...
6298         * value.c (value_from_host_double): ...here.
6299         * value.h (value_from_host_double): Declare.
6300         * guile/scm-math.c (vlscm_convert_typed_number): Use
6301         value_from_host_double.
6302         (vlscm_convert_number): Likewise.
6303         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6304         * python/py-value.c (convert_value_from_python): Likewise.
6305
6306 2019-03-06  Tom Tromey  <tom@tromey.com>
6307
6308         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6309
6310 2019-03-06  Tom Tromey  <tom@tromey.com>
6311
6312         * utils.h (free_current_contents): Don't declare.
6313         * utils.c (free_current_contents): Remove.
6314
6315 2019-03-06  Tom Tromey  <tom@tromey.com>
6316
6317         * top.c (quit_force): Update.
6318         * main.c (captured_command_loop): Update.
6319         * common/new-op.c (operator new): Update.
6320         * common/common-exceptions.c (struct catcher)
6321         <save_cleanup_chain>: Remove member.
6322         (exceptions_state_mc_init): Update.
6323         (exception_try_scope_entry): Return nullptr.
6324         (exception_try_scope_exit, exception_rethrow)
6325         (throw_exception_sjlj, throw_exception_cxx): Update.
6326         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6327         (all_cleanups, do_cleanups, discard_cleanups)
6328         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6329         (restore_cleanups, restore_final_cleanups): Don't declare.
6330         (do_final_cleanups): Remove parameter.
6331         * common/cleanups.c (cleanup_chain, make_cleanup)
6332         (make_cleanup_dtor, all_cleanups, do_cleanups)
6333         (discard_my_cleanups, discard_cleanups)
6334         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6335         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6336         (null_cleanup): Remove.
6337         (do_final_cleanups): Remove parameter.
6338
6339 2019-03-06  Tom Tromey  <tom@tromey.com>
6340
6341         * remote.c (remote_target::remote_parse_stop_reply): Use
6342         unique_xmalloc_ptr.
6343
6344 2019-03-06  Tom Tromey  <tom@tromey.com>
6345
6346         * stabsread.c (struct stabs_field_info): Rename from field_info.
6347         <list, fnlist>: Add initializers.
6348         <obstack>: New member.
6349         (read_member_functions, read_struct_fields, read_baseclasses):
6350         Allocate on obstack.  Don't use cleanups.
6351         (read_one_struct_field, read_member_functions, read_struct_fields)
6352         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6353         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6354         (read_struct_type): Update.
6355
6356 2019-03-06  Tom Tromey  <tom@tromey.com>
6357
6358         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6359         * common/filestuff.h (make_cleanup_close): Don't declare.
6360         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6361         Remove.
6362
6363 2019-03-06  Tom Tromey  <tom@tromey.com>
6364
6365         * solib-aix.c: Use make_scope_exit.
6366
6367 2019-03-06  Tom Tromey  <tom@tromey.com>
6368
6369         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6370         Use make_scope_exit.
6371
6372 2019-03-06  Tom Tromey  <tom@tromey.com>
6373
6374         * solib-svr4.c (disable_probes_interface): Remove parameter.
6375         (svr4_handle_solib_event): Use make_scope_exit.
6376
6377 2019-03-06  Tom Tromey  <tom@tromey.com>
6378
6379         * remote.c (struct stop_reply_deleter): Remove.
6380         (stop_reply_up): Update.
6381         (struct stop_reply): Derive from notif_event.  Don't typedef.
6382         <regcache>: Now a std::vector.
6383         (stop_reply_xfree): Remove.
6384         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6385         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6386         (remote_target::discard_pending_stop_replies): Use delete.
6387         (remote_target::remote_parse_stop_reply): Update.
6388         (remote_target::process_stop_reply): Update.
6389         * remote-notif.h (struct notif_event): Add virtual destructor.
6390         Remove "dtr" member.
6391         (struct notif_client) <alloc_event>: Return a unique_ptr.
6392         (notif_event_xfree): Don't declare.
6393         (notif_event_up): New typedef.
6394         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6395         (notif_event_xfree, do_notif_event_xfree): Remove.
6396         (remote_notif_state_xfree): Update.
6397
6398 2019-03-06  Tom Tromey  <tom@tromey.com>
6399
6400         * infrun.c (displaced_step_clear_cleanup): Now a
6401         forward_scope_exit type.
6402         (displaced_step_prepare_throw): Update.
6403         (displaced_step_fixup): Update.
6404
6405 2019-03-06  Tom Tromey  <tom@tromey.com>
6406
6407         * inferior.h (class inferior): Update comment.
6408         * gdbthread.h (class thread_info): Update comment.
6409
6410 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6411             Tom Tromey  <tom@tromey.com>
6412
6413         * stabsread.h (struct stab_section_list): Remove.
6414         (coffstab_build_psymtabs): Update.
6415         * dbxread.c (symbuf_sections): Now a std::vector.
6416         (sect_idx): New global.
6417         (fill_symbuf): Update.
6418         (coffstab_build_psymtabs): Change type of stabsects parameter.
6419         Update.
6420         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6421         std::vector.
6422         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6423         (coff_locate_sections): Update.
6424         (coff_symfile_read): Remove cleanups.  Update.
6425         (init_stringtab): Add storage parameter.
6426         (free_stringtab, free_stringtab_cleanup): Remove.
6427         (init_lineno): Add storage parameter.
6428         (free_linetab, free_linetab_cleanup): Remove.
6429
6430 2019-03-06  Pedro Alves  <palves@redhat.com>
6431
6432         * linux-fork.c (fork_info::clobber_regs): Delete.
6433         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6434         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6435         comment.  Adjust.
6436         (scoped_switch_fork_info::scoped_switch_fork_info)
6437         (checkpoint_command, linux_fork_context): Adjust
6438         fork_save_infrun_state calls.
6439
6440 2019-03-06  Pedro Alves  <palves@redhat.com>
6441
6442         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6443         (inf_has_multiple_threads): Return 'bool' and rewrite using
6444         inferior_info::threads().
6445
6446 2019-03-06  Pedro Alves  <palves@redhat.com>
6447
6448         * linux-fork.c: Include <list>.
6449         (fork_list): Now a std::list instance.
6450         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6451         (forks_exist_p, find_last_fork): Adjust.
6452         (new_fork): Delete.
6453         (one_fork_p): New.
6454         (add_fork): Adjust.
6455         (free_fork): Delete, folded into fork_info::~fork_info().
6456         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6457         Adjust.
6458         (init_fork_list): Delete.
6459         (linux_fork_killall, linux_fork_mourn_inferior)
6460         (linux_fork_detach, info_checkpoints_command): Adjust.
6461         (_initialize_linux_fork): No longer call init_fork_list.
6462
6463 2019-03-06  Pedro Alves  <palves@redhat.com>
6464
6465         * linux-fork.c (new_fork): New, split out of ...
6466         (add_fork): ... this.  Return void.  Move "first fork" special
6467         case from here, to ...
6468         (checkpoint_command): ... here.
6469         * linux-linux.h (add_fork): Return void.
6470
6471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6474
6475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6476             Chris January  <chris.january@arm.com>
6477             David Lecomber  <david.lecomber@arm.com>
6478
6479         * f-exp.y: New token, UNOP_INTRINSIC.
6480         (exp): New pattern using UNOP_INTRINSIC token.
6481         (f77_keywords): Add 'abs' keyword.
6482         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6483         (value_from_host_double): New function.
6484         (evaluate_subexp_f): Support UNOP_ABS.
6485
6486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6489         types.
6490
6491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6494         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6495         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6496
6497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6500
6501 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6502             Chris January  <chris.january@arm.com>
6503
6504         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6505         * f-exp.y: Define 'KIND' token.
6506         (exp): New pattern for KIND expressions.
6507         (ptype): Handle types with a kind extension.
6508         (direct_abs_decl): Extend to spot kind extensions.
6509         (f77_keywords): Add 'kind' to the list.
6510         (push_kind_type): New function.
6511         (convert_to_kind_type): New function.
6512         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6513         * parse.c (operator_length_standard): Likewise.
6514         * parser-defs.h (enum type_pieces): Add tp_kind.
6515         * std-operator.def: Add UNOP_KIND.
6516
6517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * f-exp.y (f_parse): Set yydebug.
6520
6521 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * f-lang.c (evaluate_subexp_f): New function.
6524         (exp_descriptor_f): New global.
6525         (f_language_defn): Use exp_descriptor_f instead of
6526         exp_descriptor_standard.
6527
6528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6529
6530         * f-exp.y (struct token): Add comments.
6531         (dot_ops): Remove uppercase versions and the end marker.
6532         (f77_keywords): Likewise.
6533         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6534         entries in the dot_ops array are case insensitive, and use
6535         strncasecmp to compare strings.  Also some whitespace cleanup in
6536         this area.  Similar for the f77_keywords array, except entries in
6537         this list might be case sensitive.
6538
6539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * f-exp.y (struct f77_boolean_val): Add comments.
6542         (boolean_values): Remove uppercase versions, and end marker.
6543         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6544         and use strncasecmp to achieve case insensitivity.  Additionally,
6545         perform whitespace cleanup around this code.
6546
6547 2019-03-06  Tom Tromey  <tromey@adacore.com>
6548
6549         * remote-sim.c (gdbsim_target_open): Use result of
6550         gdb_argv::release.
6551
6552 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6553         Dirk Schubert  <dirk.schubert@arm.com>
6554         Chris January  <chris.january@arm.com>
6555
6556         * eval.c (evaluate_subexp_standard): Call Fortran argument
6557         wrapping logic.
6558         * f-lang.c (struct value): A value which can be passed into a
6559         Fortran function call.
6560         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6561         where appropriate.
6562         (struct type): Value ready for a Fortran function call.
6563         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6564         is needed.
6565         * f-lang.h (fortran_argument_convert): Declaration.
6566         (fortran_preserve_arg_pointer): Declaration.
6567         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6568
6569 2019-03-05  Tom Tromey  <tromey@adacore.com>
6570
6571         * python/py-prettyprint.c (print_string_repr): Remove #if.
6572         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6573
6574 2019-03-05  Tom Tromey  <tromey@adacore.com>
6575
6576         * target.c (the_dummy_target): Move later.  Change type to
6577         "dummy_target".
6578         (initialize_targets): Don't initialize the_dummy_target.
6579
6580 2019-03-05  Tom Tromey  <tromey@adacore.com>
6581
6582         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6583         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6584
6585 2019-03-05  Tom Tromey  <tromey@adacore.com>
6586
6587         * windows-nat.c (windows_nat_target::attach)
6588         (windows_nat_target::detach): Don't call gdb_flush.
6589         * valprint.c (generic_val_print, val_print, val_print_string):
6590         Don't call gdb_flush.
6591         * utils.c (defaulted_query): Don't call gdb_flush.
6592         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6593         * target.c (target_announce_detach): Don't call gdb_flush.
6594         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6595         * remote.c (extended_remote_target::attach): Don't call
6596         gdb_flush.
6597         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6598         * printcmd.c (do_examine): Don't call gdb_flush.
6599         (info_display_command): Don't call gdb_flush.
6600         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6601         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6602         * memattr.c (info_mem_command): Don't call gdb_flush.
6603         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6604         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6605         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6606         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6607         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6608         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6609         (gnu_nat_target::detach): Don't call gdb_flush.
6610         * f-valprint.c (f_val_print): Don't call gdb_flush.
6611         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6612         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6613         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6614         gdb_flush.
6615         * c-valprint.c (c_val_print): Don't call gdb_flush.
6616         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6617
6618 2019-03-05  Tom Tromey  <tromey@adacore.com>
6619
6620         * varobj.c (update_dynamic_varobj_children): Update.
6621         (install_default_visualizer): Use reset, not release.
6622         * value.c (set_internalvar): Update.
6623         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6624         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6625         ATTRIBUTE_UNUSED_RESULT.
6626
6627 2019-03-05  Tom Tromey  <tromey@adacore.com>
6628
6629         * remote.c (class scoped_remote_fd) <release>: Add
6630         ATTRIBUTE_UNUSED_RESULT.
6631
6632 2019-03-05  Tom Tromey  <tromey@adacore.com>
6633
6634         * macroexp.c (struct macro_buffer) <release>: Add
6635         ATTRIBUTE_UNUSED_RESULT.
6636
6637 2019-03-05  Tom Tromey  <tromey@adacore.com>
6638
6639         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6640         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6641         ATTRIBUTE_UNUSED_RESULT.
6642
6643 2019-03-05  Tom Tromey  <tromey@adacore.com>
6644
6645         * common/scoped_fd.h (class scoped_fd) <release>: Add
6646         ATTRIBUTE_UNUSED_RESULT.
6647
6648 2019-03-05  Tom Tromey  <tromey@adacore.com>
6649
6650         * parser-defs.h (struct parser_state) <release>: Add
6651         ATTRIBUTE_UNUSED_RESULT.
6652
6653 2019-03-05  Tom Tromey  <tromey@adacore.com>
6654
6655         * utils.h (class gdb_argv) <release>: Add
6656         ATTRIBUTE_UNUSED_RESULT.
6657         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6658
6659 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6660
6661         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6662         for-loop range, to avoid compiler warnings.
6663
6664         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6665         avoid compiler warnings about unused variables.
6666
6667         * NEWS: Mention end of support for native debugging on MS-Windows
6668         before XP.
6669
6670         PR gdb/24292
6671         * common/netstuff.c:
6672         * gdbserver/gdbreplay.c
6673         * gdbserver/remote-utils.c:
6674         * ser-tcp.c:
6675         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6676         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6677         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6678         'getaddrinfo' and 'freeaddrinfo' were not available before
6679         Windows XP, and mingw.org's MinGW headers by default define
6680         _WIN32_WINNT to 0x500.
6681
6682 2019-03-01  Gary Benson <gbenson@redhat.com>
6683
6684         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6685
6686 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6687             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6688
6689         PR gdb/8527
6690         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6691         set_sigint_trap, clear_sigint_trap.
6692
6693 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6694
6695         * target.c (target_detach): Clear the regcache and the
6696         frame cache.
6697
6698 2019-02-27  Pedro Alves  <palves@redhat.com>
6699
6700         * utils.c (set_screen_size): When we cap the height/width sizes,
6701         tweak the corresponding command variable to show "unlimited":
6702
6703 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6704             Pedro Alves  <palves@redhat.com>
6705
6706         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6707         before calling rl_set_screen_size.
6708
6709 2019-02-27  Tom Tromey  <tromey@adacore.com>
6710
6711         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6712         define.
6713         * python/py-value.c: Remove Python 2.4 workaround.
6714         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6715         workaround.
6716         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6717         Python 2.4 workaround.
6718         * python/python-internal.h: Remove Python 2.4 comment.
6719         (Py_ssize_t): Don't define.
6720         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6721         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6722         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6723         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6724         * python/python.c (do_start_initialization): Remove Python 2.4
6725         workaround.
6726         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6727         (print_children): Remove Python 2.4 workaround.
6728         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6729         workaround.
6730         (CHARBUFFERPROC_NAME): Remove.
6731         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6732         Python 2.4 workaround.
6733
6734 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6735
6736         * NEWS: Note minimum Python version.
6737
6738 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6739
6740         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6741         code from these functions.  Remove corresponding ifdefs.  Use
6742         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6743         Remove gotos and target of gotos.
6744         (infpy_search_memory): Likewise.
6745
6746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6749         (hppa_gdbarch_init): Don't register deleted functions with
6750         gdbarch.
6751
6752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6755         (h8300_unwind_sp): Delete.
6756         (h8300_dummy_id): Delete.
6757         (h8300_gdbarch_init): Don't register deleted functions with
6758         gdbarch.
6759
6760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6761
6762         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6763         (ft32_unwind_pc): Delete.
6764         (ft32_unwind_sp): Delete.
6765         (ft32_gdbarch_init): Don't register deleted functions with
6766         gdbarch.
6767
6768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6769
6770         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6771         (frv_unwind_pc): Delete.
6772         (frv_unwind_sp): Delete.
6773         (frv_gdbarch_init): Don't register deleted functions with
6774         gdbarch.
6775
6776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6777
6778         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6779         (riscv_unwind_pc): Delete.
6780         (riscv_unwind_sp): Delete.
6781         (riscv_gdbarch_init): Don't register deleted functions with
6782         gdbarch.
6783
6784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6785
6786         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6787         (csky_unwind_pc): Delete.
6788         (csky_unwind_sp): Delete.
6789         (csky_gdbarch_init): Don't register deleted functions with
6790         gdbarch.
6791
6792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6793
6794         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6795         (cris_unwind_pc): Delete.
6796         (cris_unwind_sp): Delete.
6797         (cris_gdbarch_init): Don't register deleted functions with
6798         gdbarch.
6799
6800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6803         (bfin_unwind_pc): Delete.
6804         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6805
6806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6809         (arm_unwind_pc): Delete.
6810         (arm_unwind_sp): Delete.
6811         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6812
6813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6816         (arc_unwind_pc): Delete.
6817         (arc_unwind_sp): Delete.
6818         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6819
6820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6821
6822         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6823         (alpha_unwind_pc): Delete.
6824         (alpha_gdbarch_init): Don't register deleted functions with
6825         gdbarch.
6826
6827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6828
6829         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6830         (aarch64_unwind_pc): Delete.
6831         (aarch64_unwind_sp): Delete.
6832         (aarch64_gdbarch_init): Don't register deleted functions with
6833         gdbarch.
6834
6835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6836
6837         * gdbtypes.c (type_align): Don't consider static members when
6838         computing structure alignment.
6839
6840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6841
6842         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6843         return 0 for other types.
6844         * arch-utils.c (default_type_align): Always return 0.
6845         * gdbarch.h: Regenerate.
6846         * gdbarch.sh (type_align): Extend comment.
6847         * gdbtypes.c (type_align): Add additional comments, always call
6848         gdbarch_type_align before applying the default rules.
6849         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6850         generic code will then apply a suitable default.
6851         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6852         types, return 0 for other types.
6853
6854 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6855
6856         * NEWS: Create a new section for the next release branch.
6857         Rename the section of the current branch, now that it has
6858         been cut.
6859
6860 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6861
6862         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6863         * version.in: Bump version to 8.3.50.DATE-git.
6864
6865 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6866
6867         * aix-thread.c (ptid_cmp): Remove unused variable.
6868         (get_signaled_thread): Likewise.
6869         (store_regs_user_thread): Likewise.
6870         (store_regs_kernel_thread): Likewise.
6871         (fetch_regs_kernel_thread): Remove shadowed variable.
6872
6873 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6874
6875         * features/riscv/32bit-cpu.xml: Add register numbers.
6876         * features/riscv/32bit-fpu.c: Regenerate.
6877         * features/riscv/32bit-fpu.xml: Add register numbers.
6878         * features/riscv/64bit-cpu.xml: Add register numbers.
6879         * features/riscv/64bit-fpu.c: Regenerate.
6880         * features/riscv/64bit-fpu.xml: Add register numbers.
6881
6882 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6883
6884         * NEWS: Mention two argument form of gdb.Value constructor.
6885         * python/py-value.c (convert_buffer_and_type_to_value): New
6886         function.
6887         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6888         Add support for handling an optional second argument.  Call
6889         convert_buffer_and_type_to_value as appropriate.
6890         * python/python-internal.h (Py_buffer_deleter): New struct.
6891         (Py_buffer_up): New typedef.
6892
6893 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6894
6895         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6896         instead of releasing ownership.
6897
6898 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6899
6900         * dwarf2read.c (open_and_init_dwp_file): Call
6901         elf_numsections instead of bfd_count_sections to initialize
6902         dwp_file->num_sections.
6903
6904 2019-02-25  Tom Tromey  <tromey@adacore.com>
6905
6906         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6907
6908 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6909
6910         * gcore.in: Add '--readnever' option when invoking GDB.
6911
6912 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6913
6914         * MAINTAINERS: Update my email address.
6915
6916 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6917
6918         * build-id.c (build_id_to_debug_bfd_1): New function.
6919         (build_id_to_debug_bfd): Look for separate debug file in
6920         sysroot.
6921
6922 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * gdbarch.sh: Update the copyright year range that is placed into
6925         generated files.
6926
6927 2019-02-22  Keith Seitz  <keiths@redhat.com>
6928
6929         PR symtab/23853
6930         * linespec.c (create_sals_line_offset): Search for the default
6931         symtab's filename instead of its fullname.
6932
6933 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6934
6935         * NEWS: Update style defaults.
6936
6937 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6938
6939         * main.c (captured_main_1): Disable styling in batch mode.
6940
6941 2019-02-20  Tom Tromey  <tom@tromey.com>
6942
6943         * symtab.c (symtab_symbol_info): Fix typos.
6944
6945 2019-02-20  Tom Tromey  <tromey@adacore.com>
6946
6947         * findcmd.c (_initialize_mem_search): Use upper case for
6948         metasyntactic variables.
6949
6950 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6951
6952         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6953         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6954
6955 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6956
6957         * top.h (source_file_name): Change to std::string.
6958         * top.c (source_file_name): Likewise.
6959         (command_line_input): Adjust.
6960         * cli/cli-script.c (script_from_file): Adjust.
6961
6962 2019-02-19  Tom Tromey  <tromey@adacore.com>
6963
6964         * ravenscar-thread.c
6965         (ravenscar_thread_target::update_thread_list): Don't call
6966         ada_build_task_list.
6967         * ada-lang.h (ada_build_task_list): Don't declare.
6968         * ada-tasks.c (struct ada_tasks_inferior_data)
6969         <task_list_valid_p>: Now bool.
6970         (read_known_tasks, ada_task_list_changed)
6971         (ada_tasks_invalidate_inferior_data): Update.
6972         (read_known_tasks_array): Return bool.
6973         (read_known_tasks_list): Likewise.
6974         (read_known_tasks): Return void.
6975         (ada_build_task_list): Now static.
6976
6977 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6980         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6981
6982 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6983
6984         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6985         variant for ada_tasks_pspace_data_handle and
6986         ada_tasks_inferior_data_handle.
6987         (ada_tasks_pspace_data_cleanup): New function.
6988         (ada_tasks_inferior_data_cleanup): New function.
6989
6990 2019-02-17  Tom Tromey  <tom@tromey.com>
6991
6992         * macrotab.h (macro_source_fullname): Return a std::string.
6993         * macrotab.c (macro_include, check_for_redefinition)
6994         (macro_undef, macro_lookup_definition, foreach_macro)
6995         (foreach_macro_in_scope): Update.
6996         (macro_source_fullname): Return a std::string.
6997         * macrocmd.c (show_pp_source_pos): Update.
6998
6999 2019-02-17  Tom Tromey  <tom@tromey.com>
7000
7001         * macrocmd.c (show_pp_source_pos): Style the file names.
7002
7003 2019-02-17  Tom Tromey  <tom@tromey.com>
7004
7005         PR tui/24197:
7006         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7007
7008 2019-02-17  Tom Tromey  <tom@tromey.com>
7009
7010         * ada-lang.c (user_select_syms): Use filtered printing.
7011         * utils.c (wrap_style): New global.
7012         (desired_style): Remove.
7013         (emit_style_escape): Add stream parameter.
7014         (set_output_style, reset_terminal_style, prompt_for_continue):
7015         Update.
7016         (flush_wrap_buffer): Only flush gdb_stdout.
7017         (wrap_here): Set wrap_style.
7018         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7019         treat escape sequences as a character.  Change when wrap buffer is
7020         flushed.
7021         (fputs_styled): Do not set the output style when the default is
7022         requested.
7023         * ui-style.h (struct ui_file_style) <is_default>: New method.
7024         * source.c (print_source_lines_base): Emit escape sequences in one
7025         piece.
7026
7027 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7028
7029         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7030         integers and enumeration types.
7031
7032 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7033
7034         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7035         instead of lookup_symbol_in_language
7036         (do_exact_match): New function.
7037         (ada_get_symbol_name_matcher): Return do_exact_match when
7038         doing a verbatim match.
7039
7040 2019-02-15  Tom Tromey  <tromey@adacore.com>
7041
7042         * ravenscar-thread.c (ravenscar_thread_target::resume)
7043         (ravenscar_thread_target::wait): Special case wildcard requests.
7044
7045 2019-02-15  Tom Tromey  <tromey@adacore.com>
7046
7047         * ravenscar-thread.c (base_ptid): Remove.
7048         (struct ravenscar_thread_target) <close>: New method.
7049         <m_base_ptid>: New member.
7050         <update_inferior_ptid, active_task, task_is_currently_active,
7051         runtime_initialized>: Declare methods.
7052         <ravenscar_thread_target>: Add constructor.
7053         (ravenscar_thread_target::task_is_currently_active)
7054         (ravenscar_thread_target::update_inferior_ptid)
7055         (ravenscar_runtime_initialized): Rename.  Now methods.
7056         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7057         (ravenscar_thread_target::update_thread_list): Update.
7058         (ravenscar_thread_target::active_task): Now method.
7059         (ravenscar_thread_target::store_registers)
7060         (ravenscar_thread_target::prepare_to_store)
7061         (ravenscar_thread_target::prepare_to_store)
7062         (ravenscar_thread_target::mourn_inferior): Update.
7063         (ravenscar_inferior_created): Use "new" to create target.
7064         (ravenscar_thread_target::get_ada_task_ptid): Update.
7065         (_initialize_ravenscar): Don't initialize base_ptid.
7066         (ravenscar_ops): Remove global.
7067
7068 2019-02-15  Tom Tromey  <tromey@adacore.com>
7069
7070         * target.h (push_target): Declare new overload.
7071         * target.c (push_target): New overload, taking an rvalue reference.
7072         * remote.c (remote_target::open_1): Use push_target overload.
7073         * corelow.c (core_target_open): Use push_target overload.
7074
7075 2019-02-15  Tom Tromey  <tromey@adacore.com>
7076
7077         * ravenscar-thread.c (is_ravenscar_task)
7078         (ravenscar_task_is_currently_active): Return bool.
7079         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7080         (_initialize_ravenscar): Remove "(void)".
7081         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7082         Return bool.
7083
7084 2019-02-15  Tom Tromey  <tromey@adacore.com>
7085
7086         * ravenscar-thread.c (ravenscar_runtime_initializer)
7087         (has_ravenscar_runtime, get_running_thread_id)
7088         (ravenscar_thread_target::resume): Fix indentation.
7089
7090 2019-02-15  Tom Tromey  <tromey@adacore.com>
7091
7092         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7093         from ravenscar_arch_ops.
7094         (sparc_ravenscar_ops::fetch_registers)
7095         (sparc_ravenscar_ops::store_registers): Now methods.
7096         (sparc_ravenscar_prepare_to_store): Remove.
7097         (sparc_ravenscar_ops): Redefine.
7098         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7099         methods and destructor.  Remove members.
7100         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7101         (ravenscar_thread_target::store_registers)
7102         (ravenscar_thread_target::prepare_to_store): Update.
7103         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7104         Remove.
7105         (struct ppc_ravenscar_powerpc_ops): Derive from
7106         ravenscar_arch_ops.
7107         (ppc_ravenscar_powerpc_ops::fetch_registers)
7108         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7109         (ppc_ravenscar_powerpc_ops): Redefine.
7110         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7111         (ppc_ravenscar_e500_ops::fetch_registers)
7112         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7113         (ppc_ravenscar_e500_ops): Redefine.
7114         * aarch64-ravenscar-thread.c
7115         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7116         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7117         (aarch64_ravenscar_fetch_registers)
7118         (aarch64_ravenscar_store_registers): Now methods.
7119         (aarch64_ravenscar_ops): Redefine.
7120
7121 2019-02-15  Tom Tromey  <tromey@adacore.com>
7122
7123         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7124         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7125         (ravenscar_thread_target::stopped_by_watchpoint)
7126         (ravenscar_thread_target::stopped_data_address)
7127         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7128
7129 2019-02-15  Tom Tromey  <tromey@adacore.com>
7130
7131         * ravenscar-thread.c: Fix some typos.
7132
7133 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7134             Tom Tromey  <tromey@adacore.com>
7135
7136         * ada-lang.c (ada_exception_sal): Change addr_string to a
7137         std::string.
7138         (create_ada_exception_catchpoint): Update.
7139
7140 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7141             Tom Tromey  <tromey@adacore.com>
7142
7143         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7144         (bp_location_ops): Remove.
7145         (base_breakpoint_allocate_location): Update.
7146         (free_bp_location): Update.
7147         * ada-lang.c (class ada_catchpoint_location)
7148         <ada_catchpoint_location>: Remove ops parameter.
7149         (ada_catchpoint_location_dtor): Remove.
7150         (ada_catchpoint_location_ops): Remove.
7151         (allocate_location_exception): Update.
7152         * breakpoint.h (struct bp_location_ops): Remove.
7153         (class bp_location) <bp_location>: Remove bp_location_ops
7154         parameter.
7155         <~bp_location>: Add destructor.
7156         <ops>: Remove.
7157
7158 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7159             Pedro Alves  <palves@redhat.com>
7160
7161         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7162         'PATH_MAX'.
7163
7164 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7165             Samuel Thibault  <samuel.thibault@gnu.org>
7166             Thomas Schwinge  <thomas@codesourcery.com>
7167
7168         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7169         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7170
7171 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7172
7173         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7174         (check_empty): Use "const char *".
7175
7176         * gnu-nat.c (gnu_nat_target::detach): Instead of
7177         'detach_inferior (pid)' call
7178         'detach_inferior (find_inferior_pid (pid))'.
7179
7180         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7181         'nat/fork-inferior.o'.
7182         * gnu-nat.c: #include "nat/fork-inferior.h".
7183
7184         * gnu-nat.c (gnu_nat_target::detach): Instead of
7185         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7186         * gnu-nat.h: #include "inf-child.h".
7187         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7188         'i386_gnu_nat_target::fetch_registers'.
7189         (gnu_store_registers): Rename/move to
7190         'i386_gnu_nat_target::store_registers'.
7191
7192         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7193         * gnu-nat.h (mach_thread_info): New function.
7194         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7195
7196         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7197
7198 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7199
7200         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7201
7202 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7203
7204         * windows-nat.c (windows_add_thread): Add new parameter
7205         "main_thread_p" with default value set to false.  Update
7206         function documentation as well as all callers.
7207         (windows_delete_thread): Likewise.
7208         (fake_create_process): Update call to windows_add_thread.
7209         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7210         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7211         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7212         call to windows_delete_thread.
7213
7214 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7215
7216         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7217
7218 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7219
7220         * symfile.c (find_separate_debug_file): Use canonical path of
7221         sysroot with child_path instead of gdb_sysroot if it is valid.
7222
7223 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7224
7225         * symfile.c (find_separate_debug_file): Use child_path to
7226         determine if an object file is under a sysroot.
7227
7228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7229
7230         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7231         unittests/child-path-selftests.c.
7232         * common/pathstuff.c (child_path): New function.
7233         * common/pathstuff.h (child_path): New prototype.
7234         * unittests/child-path-selftests.c: New file.
7235
7236 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7237
7238         * symfile.c (find_separate_debug_file): Look for separate debug
7239         files in debug directories under the sysroot.
7240
7241 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7242
7243         * symtab.h (struct minimal_symbol data_p): New const method.
7244         (struct minimal_symbol text_p): Likewise.
7245         * symtab.c (output_source_filename): Use file name style
7246         to print file name.
7247         (print_symbol_info): Likewise.
7248         (print_msymbol_info): Use address style to print addresses.
7249         Use function name style to print executable text symbols.
7250         (expand_symtab_containing_pc): Use data_p.
7251         (find_pc_sect_compunit_symtab): Likewise.
7252
7253 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7254
7255         * breakpoint.c (describe_other_breakpoints): Use address style
7256         to print addresses.
7257         (say_where): Likewise.
7258
7259 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7260
7261         * ada-typeprint.c (print_func_type): Print function name
7262         style to print function name.
7263         * c-typeprint.c (c_print_type_1): Likewise.
7264
7265 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7266
7267         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7268         for execve.
7269
7270 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7271
7272         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7273         type_stack.
7274
7275 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7276
7277         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7278         TYPE_CODE_REF types.
7279
7280 2019-02-08  Jim Wilson  <jimw@sifive.com>
7281
7282         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7283         (riscv_linux_fregset): New.
7284         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7285
7286 2019-02-07  Tom Tromey  <tom@tromey.com>
7287
7288         * thread.c (thread_cancel_execution_command): Update.
7289         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7290         methods.
7291         (struct thread_fsm_ops): Remove.
7292         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7293         (thread_fsm_should_stop, thread_fsm_return_value)
7294         (thread_fsm_set_finished, thread_fsm_finished_p)
7295         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7296         Don't declare.
7297         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7298         * infrun.c (clear_proceed_status_thread)
7299         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7300         (print_stop_event): Update.
7301         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7302         Add constructor.
7303         (step_command_fsm_ops): Remove.
7304         (new_step_command_fsm): Remove.
7305         (step_1): Update.
7306         (step_command_fsm::should_stop): Rename from
7307         step_command_fsm_should_stop.
7308         (step_command_fsm::clean_up): Rename from
7309         step_command_fsm_clean_up.
7310         (step_command_fsm::do_async_reply_reason): Rename from
7311         step_command_fsm_async_reply_reason.
7312         (struct until_next_fsm): Inherit from thread_fsm.  Add
7313         constructor.
7314         (until_next_fsm_ops): Remove.
7315         (new_until_next_fsm): Remove.
7316         (until_next_fsm::should_stop): Rename from
7317         until_next_fsm_should_stop.
7318         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7319         (until_next_fsm::do_async_reply_reason): Rename from
7320         until_next_fsm_async_reply_reason.
7321         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7322         constructor.  Change type of breakpoint.
7323         (finish_command_fsm_ops): Remove.
7324         (new_finish_command_fsm): Remove.
7325         (finish_command_fsm::should_stop): Rename from
7326         finish_command_fsm_should_stop.
7327         (finish_command_fsm::clean_up): Rename from
7328         finish_command_fsm_clean_up.
7329         (finish_command_fsm::return_value): Rename from
7330         finish_command_fsm_return_value.
7331         (finish_command_fsm::do_async_reply_reason): Rename from
7332         finish_command_fsm_async_reply_reason.
7333         (finish_command): Update.
7334         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7335         Add constructor.
7336         (call_thread_fsm_ops): Remove.
7337         (call_thread_fsm::call_thread_fsm): Rename from
7338         new_call_thread_fsm.
7339         (call_thread_fsm::should_stop): Rename from
7340         call_thread_fsm_should_stop.
7341         (call_thread_fsm::should_notify_stop): Rename from
7342         call_thread_fsm_should_notify_stop.
7343         (run_inferior_call, call_function_by_hand_dummy): Update.
7344         * cli/cli-interp.c (should_print_stop_to_console): Update.
7345         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7346         Add constructor.  Change type of location_breakpoint,
7347         caller_breakpoint.
7348         (until_break_fsm_ops): Remove.
7349         (new_until_break_fsm): Remove.
7350         (until_break_fsm::should_stop): Rename from
7351         until_break_fsm_should_stop.
7352         (until_break_fsm::clean_up): Rename from
7353         until_break_fsm_clean_up.
7354         (until_break_fsm::do_async_reply_reason): Rename from
7355         until_break_fsm_async_reply_reason.
7356         (until_break_command): Update.
7357         * thread-fsm.c: Remove.
7358         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7359
7360 2019-02-07  Tom Tromey  <tom@tromey.com>
7361
7362         * yy-remap.h: Add include guard.
7363         * xtensa-tdep.h: Add include guard.
7364         * xcoffread.h: Rename include guard.
7365         * varobj-iter.h: Add include guard.
7366         * tui/tui.h: Rename include guard.
7367         * tui/tui-winsource.h: Rename include guard.
7368         * tui/tui-wingeneral.h: Rename include guard.
7369         * tui/tui-windata.h: Rename include guard.
7370         * tui/tui-win.h: Rename include guard.
7371         * tui/tui-stack.h: Rename include guard.
7372         * tui/tui-source.h: Rename include guard.
7373         * tui/tui-regs.h: Rename include guard.
7374         * tui/tui-out.h: Rename include guard.
7375         * tui/tui-layout.h: Rename include guard.
7376         * tui/tui-io.h: Rename include guard.
7377         * tui/tui-hooks.h: Rename include guard.
7378         * tui/tui-file.h: Rename include guard.
7379         * tui/tui-disasm.h: Rename include guard.
7380         * tui/tui-data.h: Rename include guard.
7381         * tui/tui-command.h: Rename include guard.
7382         * tic6x-tdep.h: Add include guard.
7383         * target/waitstatus.h: Rename include guard.
7384         * target/wait.h: Rename include guard.
7385         * target/target.h: Rename include guard.
7386         * target/resume.h: Rename include guard.
7387         * target-float.h: Rename include guard.
7388         * stabsread.h: Add include guard.
7389         * rs6000-tdep.h: Add include guard.
7390         * riscv-fbsd-tdep.h: Add include guard.
7391         * regformats/regdef.h: Rename include guard.
7392         * record.h: Rename include guard.
7393         * python/python.h: Rename include guard.
7394         * python/python-internal.h: Rename include guard.
7395         * python/py-stopevent.h: Rename include guard.
7396         * python/py-ref.h: Rename include guard.
7397         * python/py-record.h: Rename include guard.
7398         * python/py-record-full.h: Rename include guard.
7399         * python/py-record-btrace.h: Rename include guard.
7400         * python/py-instruction.h: Rename include guard.
7401         * python/py-events.h: Rename include guard.
7402         * python/py-event.h: Rename include guard.
7403         * procfs.h: Add include guard.
7404         * proc-utils.h: Add include guard.
7405         * p-lang.h: Add include guard.
7406         * or1k-tdep.h: Rename include guard.
7407         * observable.h: Rename include guard.
7408         * nto-tdep.h: Rename include guard.
7409         * nat/x86-linux.h: Rename include guard.
7410         * nat/x86-linux-dregs.h: Rename include guard.
7411         * nat/x86-gcc-cpuid.h: Add include guard.
7412         * nat/x86-dregs.h: Rename include guard.
7413         * nat/x86-cpuid.h: Rename include guard.
7414         * nat/ppc-linux.h: Rename include guard.
7415         * nat/mips-linux-watch.h: Rename include guard.
7416         * nat/linux-waitpid.h: Rename include guard.
7417         * nat/linux-ptrace.h: Rename include guard.
7418         * nat/linux-procfs.h: Rename include guard.
7419         * nat/linux-osdata.h: Rename include guard.
7420         * nat/linux-nat.h: Rename include guard.
7421         * nat/linux-namespaces.h: Rename include guard.
7422         * nat/linux-btrace.h: Rename include guard.
7423         * nat/glibc_thread_db.h: Rename include guard.
7424         * nat/gdb_thread_db.h: Rename include guard.
7425         * nat/gdb_ptrace.h: Rename include guard.
7426         * nat/fork-inferior.h: Rename include guard.
7427         * nat/amd64-linux-siginfo.h: Rename include guard.
7428         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7429         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7430         * nat/aarch64-linux.h: Rename include guard.
7431         * nat/aarch64-linux-hw-point.h: Rename include guard.
7432         * mn10300-tdep.h: Add include guard.
7433         * mips-linux-tdep.h: Add include guard.
7434         * mi/mi-parse.h: Rename include guard.
7435         * mi/mi-out.h: Rename include guard.
7436         * mi/mi-main.h: Rename include guard.
7437         * mi/mi-interp.h: Rename include guard.
7438         * mi/mi-getopt.h: Rename include guard.
7439         * mi/mi-console.h: Rename include guard.
7440         * mi/mi-common.h: Rename include guard.
7441         * mi/mi-cmds.h: Rename include guard.
7442         * mi/mi-cmd-break.h: Rename include guard.
7443         * m2-lang.h: Add include guard.
7444         * location.h: Rename include guard.
7445         * linux-record.h: Rename include guard.
7446         * linux-nat.h: Add include guard.
7447         * linux-fork.h: Add include guard.
7448         * i386-darwin-tdep.h: Rename include guard.
7449         * hppa-linux-offsets.h: Add include guard.
7450         * guile/guile.h: Rename include guard.
7451         * guile/guile-internal.h: Rename include guard.
7452         * gnu-nat.h: Rename include guard.
7453         * gdb-stabs.h: Rename include guard.
7454         * frv-tdep.h: Add include guard.
7455         * f-lang.h: Add include guard.
7456         * event-loop.h: Add include guard.
7457         * darwin-nat.h: Rename include guard.
7458         * cp-abi.h: Rename include guard.
7459         * config/sparc/nm-sol2.h: Rename include guard.
7460         * config/nm-nto.h: Rename include guard.
7461         * config/nm-linux.h: Add include guard.
7462         * config/i386/nm-i386gnu.h: Rename include guard.
7463         * config/djgpp/nl_types.h: Rename include guard.
7464         * config/djgpp/langinfo.h: Rename include guard.
7465         * compile/gcc-cp-plugin.h: Add include guard.
7466         * compile/gcc-c-plugin.h: Add include guard.
7467         * compile/compile.h: Rename include guard.
7468         * compile/compile-object-run.h: Rename include guard.
7469         * compile/compile-object-load.h: Rename include guard.
7470         * compile/compile-internal.h: Rename include guard.
7471         * compile/compile-cplus.h: Rename include guard.
7472         * compile/compile-c.h: Rename include guard.
7473         * common/xml-utils.h: Rename include guard.
7474         * common/x86-xstate.h: Rename include guard.
7475         * common/version.h: Rename include guard.
7476         * common/vec.h: Rename include guard.
7477         * common/tdesc.h: Rename include guard.
7478         * common/selftest.h: Rename include guard.
7479         * common/scoped_restore.h: Rename include guard.
7480         * common/scoped_mmap.h: Rename include guard.
7481         * common/scoped_fd.h: Rename include guard.
7482         * common/safe-iterator.h: Rename include guard.
7483         * common/run-time-clock.h: Rename include guard.
7484         * common/refcounted-object.h: Rename include guard.
7485         * common/queue.h: Rename include guard.
7486         * common/ptid.h: Rename include guard.
7487         * common/print-utils.h: Rename include guard.
7488         * common/preprocessor.h: Rename include guard.
7489         * common/pathstuff.h: Rename include guard.
7490         * common/observable.h: Rename include guard.
7491         * common/netstuff.h: Rename include guard.
7492         * common/job-control.h: Rename include guard.
7493         * common/host-defs.h: Rename include guard.
7494         * common/gdb_wait.h: Rename include guard.
7495         * common/gdb_vecs.h: Rename include guard.
7496         * common/gdb_unlinker.h: Rename include guard.
7497         * common/gdb_unique_ptr.h: Rename include guard.
7498         * common/gdb_tilde_expand.h: Rename include guard.
7499         * common/gdb_sys_time.h: Rename include guard.
7500         * common/gdb_string_view.h: Rename include guard.
7501         * common/gdb_splay_tree.h: Rename include guard.
7502         * common/gdb_setjmp.h: Rename include guard.
7503         * common/gdb_ref_ptr.h: Rename include guard.
7504         * common/gdb_optional.h: Rename include guard.
7505         * common/gdb_locale.h: Rename include guard.
7506         * common/gdb_assert.h: Rename include guard.
7507         * common/filtered-iterator.h: Rename include guard.
7508         * common/filestuff.h: Rename include guard.
7509         * common/fileio.h: Rename include guard.
7510         * common/environ.h: Rename include guard.
7511         * common/common-utils.h: Rename include guard.
7512         * common/common-types.h: Rename include guard.
7513         * common/common-regcache.h: Rename include guard.
7514         * common/common-inferior.h: Rename include guard.
7515         * common/common-gdbthread.h: Rename include guard.
7516         * common/common-exceptions.h: Rename include guard.
7517         * common/common-defs.h: Rename include guard.
7518         * common/common-debug.h: Rename include guard.
7519         * common/cleanups.h: Rename include guard.
7520         * common/buffer.h: Rename include guard.
7521         * common/btrace-common.h: Rename include guard.
7522         * common/break-common.h: Rename include guard.
7523         * cli/cli-utils.h: Rename include guard.
7524         * cli/cli-style.h: Rename include guard.
7525         * cli/cli-setshow.h: Rename include guard.
7526         * cli/cli-script.h: Rename include guard.
7527         * cli/cli-interp.h: Rename include guard.
7528         * cli/cli-decode.h: Rename include guard.
7529         * cli/cli-cmds.h: Rename include guard.
7530         * charset-list.h: Add include guard.
7531         * buildsym-legacy.h: Rename include guard.
7532         * bfin-tdep.h: Add include guard.
7533         * ax.h: Rename include guard.
7534         * arm-linux-tdep.h: Add include guard.
7535         * arm-fbsd-tdep.h: Add include guard.
7536         * arch/xtensa.h: Rename include guard.
7537         * arch/tic6x.h: Add include guard.
7538         * arch/i386.h: Add include guard.
7539         * arch/arm.h: Rename include guard.
7540         * arch/arm-linux.h: Rename include guard.
7541         * arch/arm-get-next-pcs.h: Rename include guard.
7542         * arch/amd64.h: Add include guard.
7543         * arch/aarch64-insn.h: Rename include guard.
7544         * arch-utils.h: Rename include guard.
7545         * annotate.h: Add include guard.
7546         * amd64-darwin-tdep.h: Rename include guard.
7547         * aarch64-linux-tdep.h: Add include guard.
7548         * aarch64-fbsd-tdep.h: Add include guard.
7549         * aarch32-linux-nat.h: Add include guard.
7550
7551 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7552
7553         * macrotab.c (macro_define_internal): New function that
7554         factorizes macro_define_object_internal and macro_define_function
7555         code.
7556         (macro_define_object_internal): Use macro_define_internal.
7557         (macro_define_function): Likewise.
7558
7559 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7560
7561         * macrocmd.c (extract_identifier): Return
7562         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7563         callers.
7564
7565 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7566
7567         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7568
7569 2019-02-05  Tom Tromey  <tom@tromey.com>
7570
7571         * target.c (target_stack::unpush): Move assertion earlier.
7572
7573 2019-01-30  Tom Tromey  <tom@tromey.com>
7574
7575         PR python/23615:
7576         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7577         (gdbpy_parse_and_eval): Likewise.
7578         * python/python-internal.h (gdbpy_allow_threads): New class.
7579
7580 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7581
7582         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7583         (aarch64_fbsd_fpregmap): Move earlier.
7584         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7585         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7586         instead of individual calls to trad_frame_set_reg_addr.
7587         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7588         earlier.
7589         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7590         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7591         instead of individual calls to trad_frame_set_reg_addr.
7592
7593 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7594
7595         * CONTRIBUTE: Replace contribution list with wiki link.
7596
7597 2019-01-25  Tom Tromey  <tom@tromey.com>
7598
7599         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7600
7601 2019-01-25  Tom Tromey  <tom@tromey.com>
7602
7603         * xtensa-linux-nat.c: Fix common/ includes.
7604         * xml-support.h: Fix common/ includes.
7605         * xml-support.c: Fix common/ includes.
7606         * x86-linux-nat.c: Fix common/ includes.
7607         * windows-nat.c: Fix common/ includes.
7608         * varobj.h: Fix common/ includes.
7609         * varobj.c: Fix common/ includes.
7610         * value.c: Fix common/ includes.
7611         * valops.c: Fix common/ includes.
7612         * utils.c: Fix common/ includes.
7613         * unittests/xml-utils-selftests.c: Fix common/ includes.
7614         * unittests/utils-selftests.c: Fix common/ includes.
7615         * unittests/unpack-selftests.c: Fix common/ includes.
7616         * unittests/tracepoint-selftests.c: Fix common/ includes.
7617         * unittests/style-selftests.c: Fix common/ includes.
7618         * unittests/string_view-selftests.c: Fix common/ includes.
7619         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7620         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7621         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7622         * unittests/rsp-low-selftests.c: Fix common/ includes.
7623         * unittests/parse-connection-spec-selftests.c: Fix common/
7624         includes.
7625         * unittests/optional-selftests.c: Fix common/ includes.
7626         * unittests/offset-type-selftests.c: Fix common/ includes.
7627         * unittests/observable-selftests.c: Fix common/ includes.
7628         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7629         * unittests/memrange-selftests.c: Fix common/ includes.
7630         * unittests/memory-map-selftests.c: Fix common/ includes.
7631         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7632         * unittests/function-view-selftests.c: Fix common/ includes.
7633         * unittests/environ-selftests.c: Fix common/ includes.
7634         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7635         * unittests/common-utils-selftests.c: Fix common/ includes.
7636         * unittests/cli-utils-selftests.c: Fix common/ includes.
7637         * unittests/array-view-selftests.c: Fix common/ includes.
7638         * ui-file.c: Fix common/ includes.
7639         * tui/tui-io.c: Fix common/ includes.
7640         * tracepoint.h: Fix common/ includes.
7641         * tracepoint.c: Fix common/ includes.
7642         * tracefile-tfile.c: Fix common/ includes.
7643         * top.h: Fix common/ includes.
7644         * top.c: Fix common/ includes.
7645         * thread.c: Fix common/ includes.
7646         * target/waitstatus.h: Fix common/ includes.
7647         * target/waitstatus.c: Fix common/ includes.
7648         * target.h: Fix common/ includes.
7649         * target.c: Fix common/ includes.
7650         * target-memory.c: Fix common/ includes.
7651         * target-descriptions.c: Fix common/ includes.
7652         * symtab.h: Fix common/ includes.
7653         * symfile.c: Fix common/ includes.
7654         * stap-probe.c: Fix common/ includes.
7655         * spu-linux-nat.c: Fix common/ includes.
7656         * sparc-nat.c: Fix common/ includes.
7657         * source.c: Fix common/ includes.
7658         * solib.c: Fix common/ includes.
7659         * solib-target.c: Fix common/ includes.
7660         * ser-unix.c: Fix common/ includes.
7661         * ser-tcp.c: Fix common/ includes.
7662         * ser-pipe.c: Fix common/ includes.
7663         * ser-base.c: Fix common/ includes.
7664         * selftest-arch.c: Fix common/ includes.
7665         * s12z-tdep.c: Fix common/ includes.
7666         * rust-exp.y: Fix common/ includes.
7667         * rs6000-aix-tdep.c: Fix common/ includes.
7668         * riscv-tdep.c: Fix common/ includes.
7669         * remote.c: Fix common/ includes.
7670         * remote-notif.h: Fix common/ includes.
7671         * remote-fileio.h: Fix common/ includes.
7672         * remote-fileio.c: Fix common/ includes.
7673         * regcache.h: Fix common/ includes.
7674         * regcache.c: Fix common/ includes.
7675         * record-btrace.c: Fix common/ includes.
7676         * python/python.c: Fix common/ includes.
7677         * python/py-type.c: Fix common/ includes.
7678         * python/py-inferior.c: Fix common/ includes.
7679         * progspace.h: Fix common/ includes.
7680         * producer.c: Fix common/ includes.
7681         * procfs.c: Fix common/ includes.
7682         * proc-api.c: Fix common/ includes.
7683         * printcmd.c: Fix common/ includes.
7684         * ppc-linux-nat.c: Fix common/ includes.
7685         * parser-defs.h: Fix common/ includes.
7686         * osdata.c: Fix common/ includes.
7687         * obsd-nat.c: Fix common/ includes.
7688         * nat/x86-linux.c: Fix common/ includes.
7689         * nat/x86-linux-dregs.c: Fix common/ includes.
7690         * nat/x86-dregs.h: Fix common/ includes.
7691         * nat/x86-dregs.c: Fix common/ includes.
7692         * nat/ppc-linux.c: Fix common/ includes.
7693         * nat/mips-linux-watch.h: Fix common/ includes.
7694         * nat/mips-linux-watch.c: Fix common/ includes.
7695         * nat/linux-waitpid.c: Fix common/ includes.
7696         * nat/linux-ptrace.h: Fix common/ includes.
7697         * nat/linux-ptrace.c: Fix common/ includes.
7698         * nat/linux-procfs.c: Fix common/ includes.
7699         * nat/linux-personality.c: Fix common/ includes.
7700         * nat/linux-osdata.c: Fix common/ includes.
7701         * nat/linux-namespaces.c: Fix common/ includes.
7702         * nat/linux-btrace.h: Fix common/ includes.
7703         * nat/linux-btrace.c: Fix common/ includes.
7704         * nat/fork-inferior.c: Fix common/ includes.
7705         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7706         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7707         * nat/aarch64-linux.c: Fix common/ includes.
7708         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7709         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7710         * namespace.h: Fix common/ includes.
7711         * mips-linux-tdep.c: Fix common/ includes.
7712         * minsyms.c: Fix common/ includes.
7713         * mi/mi-parse.h: Fix common/ includes.
7714         * mi/mi-main.c: Fix common/ includes.
7715         * mi/mi-cmd-env.c: Fix common/ includes.
7716         * memrange.h: Fix common/ includes.
7717         * memattr.c: Fix common/ includes.
7718         * maint.h: Fix common/ includes.
7719         * maint.c: Fix common/ includes.
7720         * main.c: Fix common/ includes.
7721         * machoread.c: Fix common/ includes.
7722         * location.c: Fix common/ includes.
7723         * linux-thread-db.c: Fix common/ includes.
7724         * linux-nat.c: Fix common/ includes.
7725         * linux-fork.c: Fix common/ includes.
7726         * inline-frame.c: Fix common/ includes.
7727         * infrun.c: Fix common/ includes.
7728         * inflow.c: Fix common/ includes.
7729         * inferior.h: Fix common/ includes.
7730         * inferior.c: Fix common/ includes.
7731         * infcmd.c: Fix common/ includes.
7732         * inf-ptrace.c: Fix common/ includes.
7733         * inf-child.c: Fix common/ includes.
7734         * ia64-linux-nat.c: Fix common/ includes.
7735         * i387-tdep.c: Fix common/ includes.
7736         * i386-tdep.c: Fix common/ includes.
7737         * i386-linux-tdep.c: Fix common/ includes.
7738         * i386-linux-nat.c: Fix common/ includes.
7739         * i386-go32-tdep.c: Fix common/ includes.
7740         * i386-fbsd-tdep.c: Fix common/ includes.
7741         * i386-fbsd-nat.c: Fix common/ includes.
7742         * guile/scm-type.c: Fix common/ includes.
7743         * guile/guile.c: Fix common/ includes.
7744         * go32-nat.c: Fix common/ includes.
7745         * gnu-nat.c: Fix common/ includes.
7746         * gdbthread.h: Fix common/ includes.
7747         * gdbarch-selftests.c: Fix common/ includes.
7748         * gdb_usleep.c: Fix common/ includes.
7749         * gdb_select.h: Fix common/ includes.
7750         * gdb_bfd.c: Fix common/ includes.
7751         * gcore.c: Fix common/ includes.
7752         * fork-child.c: Fix common/ includes.
7753         * findvar.c: Fix common/ includes.
7754         * fbsd-nat.c: Fix common/ includes.
7755         * event-top.c: Fix common/ includes.
7756         * event-loop.c: Fix common/ includes.
7757         * dwarf2read.c: Fix common/ includes.
7758         * dwarf2loc.c: Fix common/ includes.
7759         * dwarf2-frame.c: Fix common/ includes.
7760         * dwarf-index-cache.c: Fix common/ includes.
7761         * dtrace-probe.c: Fix common/ includes.
7762         * disasm-selftests.c: Fix common/ includes.
7763         * defs.h: Fix common/ includes.
7764         * csky-tdep.c: Fix common/ includes.
7765         * cp-valprint.c: Fix common/ includes.
7766         * cp-support.h: Fix common/ includes.
7767         * cp-support.c: Fix common/ includes.
7768         * corelow.c: Fix common/ includes.
7769         * completer.h: Fix common/ includes.
7770         * completer.c: Fix common/ includes.
7771         * compile/compile.c: Fix common/ includes.
7772         * compile/compile-loc2c.c: Fix common/ includes.
7773         * compile/compile-cplus-types.c: Fix common/ includes.
7774         * compile/compile-cplus-symbols.c: Fix common/ includes.
7775         * command.h: Fix common/ includes.
7776         * cli/cli-dump.c: Fix common/ includes.
7777         * cli/cli-cmds.c: Fix common/ includes.
7778         * charset.c: Fix common/ includes.
7779         * build-id.c: Fix common/ includes.
7780         * btrace.h: Fix common/ includes.
7781         * btrace.c: Fix common/ includes.
7782         * breakpoint.h: Fix common/ includes.
7783         * breakpoint.c: Fix common/ includes.
7784         * ax.h: 
7785         (enum agent_op): Fix common/ includes.
7786         * ax-general.c (struct aop_map): Fix common/ includes.
7787         * ax-gdb.c: Fix common/ includes.
7788         * auxv.c: Fix common/ includes.
7789         * auto-load.c: Fix common/ includes.
7790         * arm-tdep.c: Fix common/ includes.
7791         * arch/riscv.c: Fix common/ includes.
7792         * arch/ppc-linux-common.c: Fix common/ includes.
7793         * arch/i386.c: Fix common/ includes.
7794         * arch/arm.c: Fix common/ includes.
7795         * arch/arm-linux.c: Fix common/ includes.
7796         * arch/arm-get-next-pcs.c: Fix common/ includes.
7797         * arch/amd64.c: Fix common/ includes.
7798         * arch/aarch64.c: Fix common/ includes.
7799         * arch/aarch64-insn.c: Fix common/ includes.
7800         * arch-utils.c: Fix common/ includes.
7801         * amd64-windows-tdep.c: Fix common/ includes.
7802         * amd64-tdep.c: Fix common/ includes.
7803         * amd64-sol2-tdep.c: Fix common/ includes.
7804         * amd64-obsd-tdep.c: Fix common/ includes.
7805         * amd64-nbsd-tdep.c: Fix common/ includes.
7806         * amd64-linux-tdep.c: Fix common/ includes.
7807         * amd64-linux-nat.c: Fix common/ includes.
7808         * amd64-fbsd-tdep.c: Fix common/ includes.
7809         * amd64-fbsd-nat.c: Fix common/ includes.
7810         * amd64-dicos-tdep.c: Fix common/ includes.
7811         * amd64-darwin-tdep.c: Fix common/ includes.
7812         * agent.c: Fix common/ includes.
7813         * ada-lang.h: Fix common/ includes.
7814         * ada-lang.c: Fix common/ includes.
7815         * aarch64-tdep.c: Fix common/ includes.
7816
7817 2019-01-25  Tom Tromey  <tom@tromey.com>
7818
7819         * common/create-version.sh: Use common/version.h.
7820
7821 2019-01-24  Pedro Alves  <palves@redhat.com>
7822
7823         * infrun.c (signal_stop, signal_print, signal_program)
7824         (signal_catch, signal_pass): Now arrays instead of pointers.
7825         (update_signals_program_target, do_target_resume)
7826         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7827         * linux-nat.c (linux_nat_target::pass_signals)
7828         (linux_nat_target::create_inferior, linux_nat_target::attach):
7829         Adjust.
7830         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7831         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7832         * procfs.c (procfs_target::pass_signals): Adjust.
7833         * record-full.c (record_full_target::resume): Adjust.
7834         * remote.c (remote_target::pass_signals)
7835         (remote_target::program_signals): Adjust.
7836         * target-debug.h (target_debug_print_signals): Now takes a
7837         gdb::array_view as parameter.  Adjust.
7838         * target.h (target_ops) <pass_signals, program_signals>: Replace
7839         pointer and length parameters with gdb::array_view.
7840         (target_pass_signals, target_program_signals): Likewise.
7841         * target-delegates.c: Regenerate.
7842
7843 2019-01-24  Pedro Alves  <palves@redhat.com>
7844
7845         * common/forward-scope-exit.h
7846         (forward_scope_exit::forward_scope_exit): Pass arguments to
7847         m_bind_function directly, instead of creating a std::bind and
7848         copying that.
7849
7850 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7851
7852         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7853         for static members.
7854         (pass_in_v_vfp_candidate): Likewise.
7855
7856 2019-01-23  Tom Tromey  <tom@tromey.com>
7857             Pedro Alves  <palves@redhat.com>
7858
7859         * regcache.c (class regcache_invalidator): Remove.
7860         (regcache::raw_write): Use make_scope_exit.
7861
7862 2019-01-23  Tom Tromey  <tom@tromey.com>
7863
7864         * ui-out.h (class ui_out_emit_type): Update comment.
7865
7866 2019-01-23  Tom Tromey  <tom@tromey.com>
7867
7868         * infrun.c (fetch_inferior_event): Update comment.
7869
7870 2019-01-23  Tom Tromey  <tom@tromey.com>
7871             Pedro Alves  <palves@redhat.com>
7872
7873         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7874         parameter.
7875         (fetch_inferior_event): Use SCOPE_EXIT.
7876
7877
7878 2019-01-23  Tom Tromey  <tom@tromey.com>
7879             Pedro Alves  <palves@redhat.com>
7880
7881         * infrun.c (disable_thread_events): Delete.
7882         (stop_all_threads): Use SCOPE_EXIT.
7883
7884 2019-01-23  Tom Tromey  <tom@tromey.com>
7885             Pedro Alves  <palves@redhat.com>
7886
7887         * symfile.c: Include forward-scope-exit.h.
7888         (clear_symtab_users_cleanup): Replace forward declaration with
7889         a FORWARD_SCOPE_EXIT.
7890         (syms_from_objfile_1): Use the forward_scope_exit and
7891         gdb::optional instead of cleanup_function.
7892         (reread_symbols): Use the forward_scope_exit instead of
7893         cleanup_function.
7894         (clear_symtab_users_cleanup): Remove function.
7895
7896 2019-01-23  Tom Tromey  <tom@tromey.com>
7897             Pedro Alves  <palves@redhat.com>
7898
7899         * linux-nat.c: Include scope-exit.h.
7900         (cleanup_target_stop): Remove.
7901         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7902         SCOPE_EXIT.
7903
7904 2019-01-23  Tom Tromey  <tom@tromey.com>
7905             Pedro Alves  <palves@redhat.com>
7906
7907         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7908         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7909
7910 2019-01-23  Tom Tromey  <tom@tromey.com>
7911             Andrew Burgess  <andrew.burgess@embecosm.com>
7912             Pedro Alves  <palves@redhat.com>
7913
7914         * infrun.c (fetch_inferior_event): Use scope_exit.
7915         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7916         * top.c (execute_command): Use scope_exit.
7917         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7918         * utils.c (do_bpstat_clear_actions_cleanup)
7919         (make_bpstat_clear_actions_cleanup): Remove.
7920
7921 2019-01-23  Tom Tromey  <tom@tromey.com>
7922             Pedro Alves  <palves@redhat.com>
7923
7924         * infrun.c: Include "common/scope-exit.h"
7925         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7926         (wait_for_inferior): Use SCOPE_EXIT.
7927         (fetch_inferior_event): Use scope_exit.
7928
7929 2019-01-23  Tom Tromey  <tom@tromey.com>
7930             Pedro Alves  <palves@redhat.com>
7931
7932         * breakpoint.c (create_breakpoint): Remove cleanup.
7933
7934 2019-01-23  Tom Tromey  <tom@tromey.com>
7935             Andrew Burgess  <andrew.burgess@embecosm.com>
7936             Pedro Alves  <palves@redhat.com>
7937
7938 2019-01-23  Pedro Alves  <palves@redhat.com>
7939
7940         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7941
7942 2019-01-23  Pedro Alves  <palves@redhat.com>
7943             Andrew Burgess  <andrew.burgess@embecosm.com>
7944
7945         * gdbthread.h: Include "common/forward-scope-exit.h".
7946         (scoped_finish_thread_state): Redefine custom class in terms of
7947         forward_scope_exit.
7948
7949 2019-01-23  Pedro Alves  <palves@redhat.com>
7950             Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * common/forward-scope-exit.h: New file.
7953
7954 2019-01-23  Pedro Alves  <palves@redhat.com>
7955             Andrew Burgess  <andrew.burgess@embecosm.com>
7956             Tom Tromey  <tom@tromey.com>
7957
7958         * common/scope-exit.h: New file.
7959
7960 2019-01-23  Pedro Alves  <palves@redhat.com>
7961
7962         * common/preprocessor.h (ESC): Rename to ...
7963         (ESC_PARENS): ... this.
7964         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7965         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7966
7967 2019-01-23  Tom Tromey  <tom@tromey.com>
7968
7969         * language.h (class scoped_switch_to_sym_language_if_auto):
7970         Initialize m_lang in both cases.
7971
7972 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7973
7974         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7975         with XCNEW.
7976
7977 2019-01-22  Tom Tromey  <tom@tromey.com>
7978
7979         * corelow.c: Do not include sys/file.h.
7980
7981 2019-01-22  Tom Tromey  <tom@tromey.com>
7982
7983         * tui/tui-wingeneral.h: Include gdb_curses.h.
7984
7985 2019-01-22  Tom Tromey  <tom@tromey.com>
7986
7987         * source-cache.h (class source_cache) <get_source_lines,
7988         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7989
7990 2019-01-22  Tom Tromey  <tom@tromey.com>
7991
7992         * remote-fileio.h (struct remote_target): Declare.
7993
7994 2019-01-22  Tom Tromey  <tom@tromey.com>
7995
7996         * python/py-arch.c: Do not include py-ref.h.
7997         * python/py-bpevent.c: Do not include py-ref.h.
7998         * python/py-cmd.c: Do not include py-ref.h.
7999         * python/py-continueevent.c: Do not include py-ref.h.
8000         * python/py-event.h: Do not include py-ref.h.
8001         * python/py-evtregistry.c: Do not include py-ref.h.
8002         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8003         * python/py-frame.c: Do not include py-ref.h.
8004         * python/py-framefilter.c: Do not include py-ref.h.
8005         * python/py-function.c: Do not include py-ref.h.
8006         * python/py-infevents.c: Do not include py-ref.h.
8007         * python/py-linetable.c: Do not include py-ref.h.
8008         * python/py-objfile.c: Do not include py-ref.h.
8009         * python/py-param.c: Do not include py-ref.h.
8010         * python/py-prettyprint.c: Do not include py-ref.h.
8011         * python/py-progspace.c: Do not include py-ref.h.
8012         * python/py-symbol.c: Do not include py-ref.h.
8013         * python/py-symtab.c: Do not include py-ref.h.
8014         * python/py-type.c: Do not include py-ref.h.
8015         * python/py-unwind.c: Do not include py-ref.h.
8016         * python/py-utils.c: Do not include py-ref.h.
8017         * python/py-value.c: Do not include py-ref.h.
8018         * python/py-varobj.c: Do not include py-ref.h.
8019         * python/py-xmethods.c: Do not include py-ref.h.
8020         * python/python.c: Do not include py-ref.h.
8021         * varobj.c: Do not include py-ref.h.
8022
8023 2019-01-22  Tom Tromey  <tom@tromey.com>
8024
8025         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8026         keyword for bcache.
8027
8028 2019-01-22  Tom Tromey  <tom@tromey.com>
8029
8030         * compile/compile-cplus-types.c: Remove a comment by #include.
8031
8032 2019-01-22  Tom Tromey  <tom@tromey.com>
8033
8034         * compile/gcc-c-plugin.h: Include compile-internal.h.
8035
8036 2019-01-22  Tom Tromey  <tom@tromey.com>
8037
8038         * stabsread.c (EXTERN): Do not define.
8039         (symnum, next_symbol_text_func, processing_gcc_compilation)
8040         (within_function, global_sym_chain, global_stabs)
8041         (previous_stab_code, this_object_header_files)
8042         (n_this_object_header_files)
8043         (n_allocated_this_object_header_files): Define.
8044         * stabsread.h (EXTERN): Never define.  Use "extern".
8045
8046 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8047
8048         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8049         history_value.
8050
8051 2019-01-21  Tom Tromey  <tom@tromey.com>
8052
8053         * ui-out.c: Fix includes.
8054         * tui/tui-source.c: Fix includes.
8055         * target.c: Fix includes.
8056         * remote.c: Fix includes.
8057         * regcache.c: Fix includes.
8058         * python/py-block.c: Fix includes.
8059         * printcmd.c: Fix includes.
8060         * or1k-tdep.c: Fix includes.
8061         * mi/mi-main.c: Fix includes.
8062         * m32r-tdep.c: Fix includes.
8063         * csky-tdep.c: Fix includes.
8064         * compile/compile-cplus-types.c: Fix includes.
8065         * cli/cli-interp.c: Fix includes.
8066
8067 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8068
8069         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8070         for padding.
8071
8072 2019-01-16  Tom Tromey  <tom@tromey.com>
8073
8074         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8075         earlier.
8076         (struct objfile) <msymbols_range>: Move from top level.
8077         <msymbols>: New method.
8078         (class objfile_msymbols): Remove.
8079         * symtab.c (default_collect_symbol_completion_matches_break_on):
8080         Update.
8081         * symmisc.c (dump_msymbols): Update.
8082         * stabsread.c (scan_file_globals): Update.
8083         * objc-lang.c (info_selectors_command, info_classes_command)
8084         (find_methods): Update.
8085         * minsyms.c (find_solib_trampoline_target): Update.
8086         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8087         * coffread.c (coff_symfile_read): Update.
8088         * ada-lang.c (ada_lookup_simple_minsym)
8089         (ada_collect_symbol_completion_matches): Update.
8090
8091 2019-01-16  Tom Tromey  <tom@tromey.com>
8092
8093         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8094         type.  Remove no-argument constructor.
8095         <iterator::operator++>: Simplify.
8096         <begin>: Update.
8097         <end>: Use minimal_symbol_count.
8098
8099 2019-01-16  Tom Tromey  <tom@tromey.com>
8100
8101         * objfiles.h (struct objfile) <psymtabs>: New method.
8102         (class objfile_psymtabs): Remove.
8103         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8104         typedef.
8105         <range>: New method.
8106         (require_partial_symbols): Change return type.
8107         * psymtab.c (require_partial_symbols)
8108         (psym_expand_symtabs_matching): Update.
8109         * mdebugread.c (parse_partial_symbols): Update.
8110         * dbxread.c (dbx_end_psymtab): Update.
8111
8112 2019-01-15  Tom Tromey  <tom@tromey.com>
8113
8114         * symtab.c (lookup_objfile_from_block)
8115         (lookup_symbol_in_objfile_symtabs)
8116         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8117         (find_line_symtab, info_sources_command)
8118         (default_collect_symbol_completion_matches_break_on)
8119         (make_source_files_completion_list): Update.
8120         * symmisc.c (print_objfile_statistics, dump_objfile)
8121         (maintenance_print_symbols, maintenance_info_symtabs)
8122         (maintenance_check_symtabs, maintenance_info_line_tables):
8123         Update.
8124         * source.c (select_source_symtab)
8125         (forget_cached_source_info_for_objfile): Update.
8126         * objfiles.h (class objfile_compunits): Remove.
8127         (struct objfile) <compunits_range>: New typedef.
8128         (compunits): New method.
8129         * objfiles.c (objfile_relocate1): Update.
8130         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8131         * maint.c (count_symtabs_and_blocks): Update.
8132         * linespec.c (iterate_over_all_matching_symtabs): Update.
8133         * cp-support.c (add_symbol_overload_list_qualified): Update.
8134         * coffread.c (coff_symtab_read): Update.
8135         * ada-lang.c (add_nonlocal_symbols)
8136         (ada_collect_symbol_completion_matches)
8137         (ada_add_global_exceptions): Update.
8138
8139 2019-01-15  Tom Tromey  <tom@tromey.com>
8140
8141         * progspace.h (program_space) <objfiles_safe_range>: New
8142         typedef.
8143         <objfiles_safe>: New method.
8144         * objfiles.h (class all_objfiles_safe): Remove.
8145         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8146         * jit.c (jit_inferior_exit_hook): Update.
8147
8148 2019-01-17  Tom Tromey  <tom@tromey.com>
8149
8150         * progspace.h (program_space) <objfiles_range>: New typedef.
8151         <objfiles>: New method.
8152         <objfiles_head>: Rename from objfiles.
8153         (object_files): Update.
8154         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8155         * guile/scm-pretty-print.c
8156         (ppscm_find_pretty_printer_from_objfiles): Update.
8157         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8158         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8159         Update.
8160         * python/py-progspace.c (pspy_get_objfiles): Update.
8161         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8162         Update.
8163         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8164         (objfpy_lookup_objfile_by_build_id): Update.
8165         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8166         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8167         Update.
8168         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8169         (expand_symtab_containing_pc, lookup_objfile_from_block)
8170         (lookup_static_symbol, basic_lookup_transparent_type)
8171         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8172         (find_line_symtab, info_sources_command)
8173         (default_collect_symbol_completion_matches_break_on)
8174         (make_source_files_completion_list, find_main_name): Update.
8175         * symmisc.c (print_symbol_bcache_statistics)
8176         (print_objfile_statistics, maintenance_print_symbols)
8177         (maintenance_print_msymbols, maintenance_print_objfiles)
8178         (maintenance_info_symtabs, maintenance_check_symtabs)
8179         (maintenance_expand_symtabs, maintenance_info_line_tables):
8180         Update.
8181         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8182         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8183         (map_overlay_command, unmap_overlay_command)
8184         (simple_overlay_update, expand_symtabs_matching)
8185         (map_symbol_filenames): Update.
8186         * symfile-debug.c (set_debug_symfile): Update.
8187         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8188         Update.
8189         * source.c (select_source_symtab, forget_cached_source_info):
8190         Update.
8191         * solib.c (solib_read_symbols): Update.
8192         * solib-spu.c (append_ocl_sos): Update.
8193         * psymtab.c (maintenance_print_psymbols)
8194         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8195         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8196         * printcmd.c (info_symbol_command): Update.
8197         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8198         Update.
8199         * objfiles.h (class all_objfiles): Remove.
8200         * objfiles.c (have_partial_symbols, have_full_symbols)
8201         (have_minimal_symbols, qsort_cmp, update_section_map)
8202         (shared_objfile_contains_address_p)
8203         (default_iterate_over_objfiles_in_search_order): Update.
8204         * objc-lang.c (info_selectors_command, info_classes_command)
8205         (find_methods): Update.
8206         * minsyms.c (find_solib_trampoline_target): Update.
8207         * maint.c (maintenance_info_sections)
8208         (maintenance_translate_address, count_symtabs_and_blocks):
8209         Update.
8210         * main.c (captured_main_1): Update.
8211         * linux-thread-db.c (try_thread_db_load_from_pdir)
8212         (has_libpthread): Update.
8213         * linespec.c (iterate_over_all_matching_symtabs)
8214         (search_minsyms_for_name): Update.
8215         * jit.c (jit_find_objf_with_entry_addr): Update.
8216         * hppa-tdep.c (find_unwind_entry)
8217         (hppa_lookup_stub_minimal_symbol): Update.
8218         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8219         Update.
8220         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8221         (elf_gnu_ifunc_resolve_by_got): Update.
8222         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8223         * dwarf-index-write.c (save_gdb_index_command): Update.
8224         * cp-support.c (add_symbol_overload_list_qualified): Update.
8225         * breakpoint.c (create_overlay_event_breakpoint)
8226         (create_longjmp_master_breakpoint)
8227         (create_std_terminate_master_breakpoint)
8228         (create_exception_master_breakpoint): Update.
8229         * blockframe.c (find_pc_partial_function): Update.
8230         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8231         (ada_collect_symbol_completion_matches)
8232         (ada_add_global_exceptions): Update.
8233
8234 2019-01-17  Tom Tromey  <tom@tromey.com>
8235
8236         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8237         declare VEC.
8238         (solib_target_parse_libraries): Change return type.
8239         (library_list_start_segment, library_list_start_section)
8240         (library_list_end_library, library_list_start_library); Update.
8241         (solib_target_free_library_list): Remove.
8242         (solib_target_parse_libraries): Remove cleanup.  Change return
8243         type.
8244         (solib_target_current_sos): Update.
8245
8246 2019-01-17  Tom Tromey  <tromey@bapiya>
8247
8248         * valprint.c: Replace "the the" with "the".
8249         * symtab.c: Replace "the the" with "the".
8250         * solib.c: Replace "the the" with "the".
8251         * solib-dsbt.c: Replace "the the" with "the".
8252         * linespec.c: Replace "the the" with "the".
8253         * dwarf2loc.h: Replace "the the" with "the".
8254         * amd64-windows-tdep.c: Replace "the the" with "the".
8255         * aarch64-tdep.c: Replace "the the" with "the".
8256
8257 2019-01-16  Keith Seitz  <keiths@redhat.com>
8258
8259         PR gdb/23773
8260         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8261         <builder>: Rename to ..
8262         <m_builder>: ... this and make private.
8263         (dwarf2_cu::get_builder): New method.  Change all users of
8264         `builder' to use this method.
8265         (dwarf2_start_symtab): Move to ...
8266         (dwarf2_cu::start_symtab): ... here.  Update all callers
8267         (setup_type_unit_groups): Move to ...
8268         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8269         callers.
8270         (dwarf2_cu::reset_builder): New method.
8271         (process_full_compunit, process_full_type_unit): Use
8272         dwarf2_cu::reset_builder.
8273         (follow_die_offset): Record the ancestor CU if it is different
8274         from the followed DIE's CU.
8275         (follow_die_sig_1): Likewise.
8276
8277 2019-01-15  Tom Tromey  <tom@tromey.com>
8278
8279         * remote.c (class remote_state) <buf>: Now a char_vector.
8280         <buf_size>: Remove.
8281         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8282         parameter.
8283         (remote_target::getpkt_or_notif_sane_1)
8284         (remote_target::getpkt_sane)
8285         (remote_target::getpkt_or_notif_sane): Likewise.
8286         (class remote_target) <putpkt>: New overload.
8287         (remote_target::read_frame): Change type of "buf_p".  Remove
8288         sizeof_p parameter.
8289         (packet_ok): New overload.
8290         (packet_check_result): New overload.
8291         Update all uses.
8292
8293 2019-01-14  Tom Tromey  <tom@tromey.com>
8294
8295         * remote-notif.c (handle_notification, remote_notif_ack)
8296         (remote_notif_parse): Make "buf" const.
8297         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8298         const.
8299         (remote_notif_parse, remote_notif_ack, handle_notification):
8300         Likewise.
8301         * remote.c (remote_notif_stop_parse): Make "buf" const.
8302         (remote_target::remote_parse_stop_reply): Make "buf" const.
8303         (remote_notif_stop_ack): Make "buf" const.
8304
8305 2019-01-14  Tom Tromey  <tom@tromey.com>
8306
8307         * remote.c (remote_console_output): Make parameter const.
8308
8309 2019-01-14  Tom Tromey  <tom@tromey.com>
8310
8311         * target-debug.h (target_debug_print_signals): Constify.
8312         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8313         * procfs.c (procfs_target::pass_signals): Update.
8314         * linux-nat.c (linux_nat_target::pass_signals): Update.
8315         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8316         * target-delegates.c: Rebuild.
8317         * remote.c (remote_target::program_signals): Update.
8318         (remote_target::pass_signals): Update.
8319         * target.c (target_pass_signals): Constify argument.
8320         (target_program_signals): Likewise.
8321         * target.h (struct target_ops) <pass_signals, program_signals>:
8322         Constify argument.
8323         (target_pass_signals, target_program_signals): Constify argument.
8324
8325 2019-01-14  Tom Tromey  <tom@tromey.com>
8326
8327         PR tui/28819:
8328         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8329
8330 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8331
8332         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8333         field.
8334         * rs6000-tdep.c: Include reggroups.h.
8335         (IS_V_ALIAS_PSEUDOREG): Define.
8336         (rs6000_register_name): Return names for the "vX" aliases.
8337         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8338         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8339         aliases.  Call default_register_reggroup_p for all other
8340         pseudo-registers.
8341         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8342         New functions.
8343         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8344         Handle "vX" aliases.
8345         (v_alias_pseudo_register_collect): New function.
8346         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8347         (rs6000_gdbarch_init): Initialize "vX" aliases as
8348         pseudo-registers.  Restore registration of
8349         rs6000_pseudo_register_reggroup_p with
8350         set_tdesc_pseudo_register_reggroup_p.
8351
8352 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8353
8354         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8355         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8356         set_gdbarch_num_pseudo_regs.
8357
8358 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8359
8360         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8361         Remove arg prefixname, add do_set and do_show.
8362         Add member functions set_list and show_list.
8363         * cli/cli-style.c (class cli_style_option): Update accordingly.
8364         (style_set_list): Move to file scope.
8365         (style_show_list): Likewise.
8366         (set_style): Call help_list.
8367         (show_style): Call cmd_show_list.
8368         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8369         Update to use the new macro.
8370
8371 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8372
8373         * ada-lang.c (_initialize_ada_language): Expand the help text
8374         for the "catch exception" command.
8375
8376 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8377
8378         * symtab.c (matching_obj_sections): Initialize obj,
8379         declare it closer to its usage.
8380
8381 2019-01-10  Tom Tromey  <tom@tromey.com>
8382
8383         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8384         (basic_inf_threads_range): Remove.
8385         (inf_threads_range, inf_non_exited_threads_range)
8386         (safe_inf_threads_range): Use next_adapter.
8387
8388 2019-01-10  Keith Seitz  <keiths@redhat.com>
8389
8390         PR gdb/23712
8391         PR symtab/23010
8392         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8393         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8394
8395 2019-01-10  Keith Seitz  <keiths@redhat.com>
8396
8397         PR gdb/23712
8398         PR symtab/23010
8399         * dictionary.c (pending_to_vector): Remove.
8400         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8401         Remove _1 suffix, replacing functions of the same name.  Update
8402         all callers.
8403         (dict_create_hashed, dict_create_hashed_expandable)
8404         (dict_create_linear, dict_create_linear_expandable, dict_free)
8405         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8406         Make functions static.
8407
8408 2019-01-10  Keith Seitz  <keiths@redhat.com>
8409
8410         PR gdb/23712
8411         PR symtab/23010
8412         * dictionary.h (struct dictionary): Replace declaration with
8413         multidictionary.
8414         (dict_create_hashed, dict_create_hashed_expandable)
8415         (dict_create_linear, dict_create_linear_expandable)
8416         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8417         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8418         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8419         taking multidictionary argument.
8420         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8421         * block.h (struct block) <dict>: Change to multidictionary
8422         and rename `multidict'.
8423         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8424         symmisc.c: Update all dictionary references to multidictionary.
8425
8426 2019-01-10  Keith Seitz  <keiths@redhat.com>
8427
8428         PR gdb/23712
8429         PR symtab/23010
8430         * dictionary.c: Include unordered_map.
8431         (pending_to_vector): New function.
8432         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8433         Rewrite the non-"_1" functions to take vector instead
8434         of linked list.
8435         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8436         "new" _1 versions of the same name.
8437         (multidictionary): Define.
8438         (std::hash<enum language): New definition.
8439         (collate_pending_symbols_by_language, mdict_create_hashed)
8440         (mdict_create_hashed_expandable, mdict_create_linear)
8441         (mdict_create_linear_expandable, mdict_free)
8442         (find_language_dictionary, create_new_language_dictionary)
8443         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8444         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8445         (mdict_size, mdict_empty): New functions.
8446         * dictionary.h (mdict_iterator): Define.
8447
8448 2019-01-10  Pedro Alves  <palves@redhat.com>
8449
8450         * breakpoint.c (read_uploaded_action)
8451         (create_tracepoint_from_upload): Adjust to use
8452         gdb::unique_xmalloc_ptr.
8453         * ctf.c (ctf_write_uploaded_tp):
8454         (SET_ARRAY_FIELD): Use emplace_back.
8455         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8456         * tracefile-tfile.c (tfile_write_uploaded_tp):
8457         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8458         gdb::unique_xmalloc_ptr.
8459         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8460         at_string, cond_string, cmd_strings>: Replace char pointers
8461         with gdb::unique_xmalloc_ptr.
8462
8463 2019-01-10  Pedro Alves  <palves@redhat.com>
8464
8465         * solib-target.c (library_list_start_library): Don't xstrdup name.
8466
8467 2019-01-10  Pedro Alves  <palves@redhat.com>
8468
8469         * mdebugread.c (parse_partial_symbols): Use
8470         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8471
8472 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8473
8474         * linux-fork.c (scoped_switch_fork_info)
8475         <~scoped_switch_fork_info>: Fix incorrect variable name.
8476
8477 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8478
8479         * linux-fork.c (scoped_switch_fork_info)
8480         <scoped_switch_fork_info>: Make explicit.
8481         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8482
8483 2019-01-10  Tom Tromey  <tom@tromey.com>
8484
8485         * objfiles.h (objfile::reset_psymtabs): Update.
8486         * objfiles.c (objfile::objfile): Update.
8487         * psymtab.h (psymtab_storage::obstack): Update.
8488         (psymtab_storage::m_obstack): Use gdb::optional.
8489         (class psymtab_storage): Update comment.  Remove objfile
8490         parameter.
8491         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8492
8493 2019-01-10  Tom Tromey  <tom@tromey.com>
8494
8495         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8496         <free_psymtabs>: Now private.
8497         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8498         (allocate_psymtab): Use new method.
8499
8500 2019-01-10  Tom Tromey  <tom@tromey.com>
8501
8502         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8503         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8504         * mdebugread.c (parse_partial_symbols): Use
8505         allocate_dependencies.
8506         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8507         allocate_dependencies.
8508         (process_psymtab_comp_unit_reader)
8509         (build_type_psymtab_dependencies): Likewise.
8510         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8511
8512 2019-01-10  Tom Tromey  <tom@tromey.com>
8513
8514         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8515         PSYMBOL_SET_LANGUAGE.
8516         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8517
8518 2019-01-10  Tom Tromey  <tom@tromey.com>
8519
8520         * psymtab.h (psymtab_storage::obstack): New method.
8521         <m_obstack>: Rename from obstack; now private.
8522         * psymtab.c (psymtab_storage): Update.
8523         * dwarf2read.c (create_addrmap_from_index)
8524         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8525         Update.
8526
8527 2019-01-10  Tom Tromey  <tom@tromey.com>
8528
8529         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8530         * objfiles.h (objfile::reset_psymtabs): New method.
8531
8532 2019-01-10  Tom Tromey  <tom@tromey.com>
8533
8534         * symmisc.c (print_symbol_bcache_statistics): Update.
8535         (print_objfile_statistics): Update.
8536         * symfile.c (reread_symbols): Update.
8537         * psymtab.h (class psymtab_storage): New.
8538         * psymtab.c (psymtab_storage): New constructor.
8539         (~psymtab_storage): New destructor.
8540         (require_partial_symbols): Update.
8541         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8542         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8543         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8544         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8545         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8546         (start_psymtab_common, end_psymtab_common)
8547         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8548         (allocate_psymtab): Update.
8549         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8550         Update.
8551         (dump_psymtab_addrmap, maintenance_print_psymbols)
8552         (maintenance_check_psymtabs): Update.
8553         (class objfile_psymtabs): Move to objfiles.h.
8554         * psympriv.h (discard_psymtab): Now inline.
8555         (psymtab_discarder::psymtab_discarder): Update.
8556         (psymtab_discarder::~psymtab_discarder): Update.
8557         (ALL_OBJFILE_PSYMTABS): Rewrite.
8558         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8559         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8560         Remove fields.
8561         <partial_symtabs>: New field.
8562         (class objfile_psymtabs): Move from psymtab.h.  Update.
8563         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8564         psymbol_cache.
8565         (objfile::~objfile): Don't destroy psymbol_cache.
8566         * mdebugread.c (parse_partial_symbols): Update.
8567         * dwarf2read.c (create_addrmap_from_index)
8568         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8569         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8570         (add_partial_subprogram, dwarf2_ranges_read): Update.
8571         * dwarf-index-write.c (write_address_map)
8572         (write_one_signatured_type, recursively_write_psymbols)
8573         (class debug_names, class debug_names, write_psymtabs_to_index):
8574         Update.
8575
8576 2019-01-10  Tom Tromey  <tom@tromey.com>
8577
8578         * symtab.h (SYMBOL_SET_NAMES): Update.
8579         (symbol_set_names): Update.
8580         (MSYMBOL_SET_NAMES): Update.
8581         * symtab.c (symbol_set_names): Change argument to be an
8582         objfile_per_bfd_storage.
8583         * psymtab.c (add_psymbol_to_bcache): Update.
8584         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8585
8586 2019-01-10  Tom Tromey  <tom@tromey.com>
8587
8588         * symtab.c (create_demangled_names_hash): Change argument to be an
8589         objfile_per_bfd_storage.
8590         (symbol_set_names): Update.
8591
8592 2019-01-10  Tom Tromey  <tom@tromey.com>
8593
8594         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8595         init_psymbol_list.
8596         * psymtab.c (init_psymbol_list): Do nothing if already called.
8597         * psympriv.h (init_psymbol_list): Add comment.
8598         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8599         init_psymbol_list.
8600         * dbxread.c (dbx_symfile_read): Unconditionally call
8601         init_psymbol_list.
8602
8603 2019-01-10  Tom Tromey  <tom@tromey.com>
8604
8605         * xcoffread.c (scan_xcoff_symtab): Update.
8606         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8607         "where".
8608         * mdebugread.c (parse_partial_symbols)
8609         (handle_psymbol_enumerators): Update.
8610         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8611         * dbxread.c (read_dbx_symtab): Update.
8612         * psympriv.h (psymbol_placement): New enum.
8613         (add_psymbol_to_list): Update.
8614
8615 2019-01-10  Tom Tromey  <tom@tromey.com>
8616
8617         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8618         static_psymbols parameters.
8619         (scan_xcoff_symtab): Update.
8620         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8621         static_psymbols parameters.
8622         * psympriv.h (start_psymtab_common): Update.
8623         * mdebugread.c (parse_partial_symbols): Update.
8624         * dwarf2read.c (create_partial_symtab): Update.
8625         * dbxread.c (read_dbx_symtab): Update.
8626         (start_psymtab): Remove global_psymbols and static_psymbols
8627         parameters.
8628
8629 2019-01-10  Tom Tromey  <tom@tromey.com>
8630
8631         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8632         * psymtab.c (allocate_psymtab): Add comment.
8633         * psympriv.h (allocate_psymtab): Add comment.
8634         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8635         initializations.
8636         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8637
8638 2019-01-10  Tom Tromey  <tom@tromey.com>
8639
8640         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8641         Don't declare.
8642         * mipsread.c: Include mdebugread.h.
8643         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8644         Declare.
8645         * elfread.c: Include mdebugread.h.
8646
8647 2019-01-09  Tom Tromey  <tom@tromey.com>
8648
8649         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8650         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8651         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8652         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8653         (psym_lookup_symbol, psym_find_last_source_symtab)
8654         (psym_forget_cached_source_info, psym_print_stats)
8655         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8656         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8657         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8658         (psym_find_compunit_symtab_by_address)
8659         (maintenance_print_psymbols, maintenance_info_psymtabs)
8660         (maintenance_check_psymtabs): Use ranged for.
8661         * psymtab.h (class objfile_psymtabs): New.
8662         (require_partial_symbols): Return objfile_psymtabs.
8663         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8664
8665 2019-01-09  Tom Tromey  <tom@tromey.com>
8666
8667         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8668         (find_pc_mapped_section, list_overlays_command)
8669         (map_overlay_command, unmap_overlay_command)
8670         (simple_overlay_update): Use all_objfiles.
8671         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8672         * printcmd.c (info_symbol_command): Use all_objfiles.
8673         * objfiles.h (ALL_OBJSECTIONS): Remove.
8674         * maint.c (maintenance_translate_address): Use all_objfiles.
8675         * gcore.c (gcore_create_callback): Use all_objfiles.
8676         (objfile_find_memory_regions): Likewise.
8677
8678 2019-01-09  Tom Tromey  <tom@tromey.com>
8679
8680         * symtab.c (find_line_symtab, info_sources_command)
8681         (make_source_files_completion_list): Use objfile_compunits.
8682         * source.c (select_source_symtab): Use objfile_compunits.
8683         * objfiles.h (struct objfile): Update comment.
8684         (ALL_OBJFILES): Remove.
8685         (ALL_FILETABS): Remove.
8686         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8687         objfile_compunits.
8688
8689 2019-01-09  Tom Tromey  <tom@tromey.com>
8690
8691         * symmisc.c (print_objfile_statistics, dump_objfile)
8692         (maintenance_print_symbols): Use compunit_filetabs.
8693         * source.c (forget_cached_source_info_for_objfile): Use
8694         compunit_filetabs.
8695         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8696         (ALL_FILETABS): Use compunit_filetabs.
8697         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8698         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8699
8700 2019-01-09  Tom Tromey  <tom@tromey.com>
8701
8702         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8703         (compunit_filetabs): New.
8704         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8705         compunit_filetabs.
8706         (info_sources_command, make_source_files_completion_list): Remove
8707         declaration.
8708         * symmisc.c (print_objfile_statistics, dump_objfile)
8709         (maintenance_print_symbols): Remove declaration.
8710         (maintenance_info_symtabs): Use compunit_filetabs.
8711         (maintenance_info_line_tables): Likewise.
8712         * source.c (select_source_symtab): Change local variable name.
8713         (forget_cached_source_info_for_objfile): Remove declaration.
8714         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8715         * objfiles.c (objfile_relocate1): Remove declaration.
8716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8717         declaration.
8718         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8719         * coffread.c (coff_symtab_read): Remove declaration.
8720         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8721         compunit_filetabs.
8722
8723 2019-01-09  Tom Tromey  <tom@tromey.com>
8724
8725         * symtab.c (lookup_objfile_from_block)
8726         (find_pc_sect_compunit_symtab, search_symbols)
8727         (default_collect_symbol_completion_matches_break_on): Use
8728         objfile_compunits.
8729         * objfiles.h (ALL_COMPUNITS): Remove.
8730         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8731         * cp-support.c (add_symbol_overload_list_qualified): Use
8732         objfile_compunits.
8733         * ada-lang.c (ada_collect_symbol_completion_matches)
8734         (ada_add_global_exceptions): Use objfile_compunits.
8735
8736 2019-01-09  Tom Tromey  <tom@tromey.com>
8737
8738         * source.c (select_source_symtab)
8739         (forget_cached_source_info_for_objfile): Remove declaration.
8740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8741         declaration.
8742         * maint.c (count_symtabs_and_blocks): Remove declaration.
8743         * cp-support.c (add_symbol_overload_list_qualified): Remove
8744         declaration.
8745         * coffread.c (coff_symtab_read): Remove declaration.
8746         * symtab.c (lookup_symbol_in_objfile_symtabs)
8747         (basic_lookup_transparent_type_1): Use objfile_compunits.
8748         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8749         (info_sources_command, search_symbols)
8750         (default_collect_symbol_completion_matches_break_on)
8751         (make_source_files_completion_list): Remove declaration.
8752         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8753         (ada_collect_symbol_completion_matches)
8754         (ada_add_global_exceptions): Remove declaration.
8755         * linespec.c (iterate_over_all_matching_symtabs): Use
8756         objfile_compunits.
8757         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8758         (class objfile_compunits): New.
8759         (ALL_COMPUNITS): Use objfile_compunits.
8760         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8761         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8762         objfile_compunits.
8763         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8764
8765 2019-01-09  Tom Tromey  <tom@tromey.com>
8766
8767         * symtab.c (search_symbols)
8768         (default_collect_symbol_completion_matches_break_on): Use
8769         objfile_msymbols.
8770         * ada-lang.c (ada_lookup_simple_minsym)
8771         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8772         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8773         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8774         objfile_msymbols.
8775         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8776         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8777         * objc-lang.c (find_methods): Use objfile_msymbols.
8778         (info_selectors_command, info_classes_command): Likewise.
8779         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8780         * objfiles.h (class objfile_msymbols): New.
8781         (ALL_OBJFILE_MSYMBOLS): Remove.
8782         (ALL_MSYMBOLS): Remove.
8783
8784 2019-01-09  Tom Tromey  <tom@tromey.com>
8785
8786         * common/next-iterator.h (next_adapter): Add Iterator template
8787         parameter.
8788         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8789         (class all_objfiles_safe): New.
8790         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8791         * objfiles.c (put_objfile_before): Update comment.
8792         (add_separate_debug_objfile): Likewise.
8793         (free_all_objfiles): Use all_objfiles_safe.
8794         (objfile_purge_solibs): Likewise.
8795
8796 2019-01-09  Tom Tromey  <tom@tromey.com>
8797
8798         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8799         (expand_symtab_containing_pc, lookup_static_symbol)
8800         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8801         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8802         all_objfiles.
8803         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8804         * breakpoint.c (create_overlay_event_breakpoint)
8805         (create_longjmp_master_breakpoint)
8806         (create_std_terminate_master_breakpoint)
8807         (create_exception_master_breakpoint): Use all_objfiles.
8808         * linux-thread-db.c (try_thread_db_load_from_pdir)
8809         (has_libpthread): Use all_objfiles.
8810         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8811         * linespec.c (iterate_over_all_matching_symtabs)
8812         (search_minsyms_for_name): Use all_objfiles.
8813         * maint.c (maintenance_info_sections): Use all_objfiles.
8814         * main.c (captured_main_1): Use all_objfiles.
8815         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8816         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8817         * guile/scm-pretty-print.c
8818         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8819         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8820         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8821         (maintenance_print_msymbols): Use all_objfiles.
8822         * source.c (select_source_symtab): Use all_objfiles.
8823         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8824         * symfile.c (remove_symbol_file_command)
8825         (expand_symtabs_matching, map_symbol_filenames): Use
8826         all_objfiles.
8827         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8828         all_objfiles.
8829         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8830         * objc-lang.c (find_methods): Use all_objfiles.
8831         * objfiles.c (have_partial_symbols, have_full_symbols)
8832         (have_minimal_symbols, qsort_cmp)
8833         (default_iterate_over_objfiles_in_search_order): Use
8834         all_objfiles.
8835         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8836         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8837         (maintenance_check_psymtabs): Use all_objfiles.
8838         (ALL_PSYMTABS): Remove.
8839         * compile/compile-object-run.c (do_module_cleanup): Use
8840         all_objfiles.
8841         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8842         * cp-support.c (add_symbol_overload_list_qualified): Use
8843         all_objfiles.
8844         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8845         Use all_objfiles.
8846         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8847         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8848         all_objfiles.
8849         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8850         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8851         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8852         Uses all_objfiles.
8853         * solib.c (solib_read_symbols): Use all_objfiles
8854
8855 2019-01-09  Tom Tromey  <tom@tromey.com>
8856
8857         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8858         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8859         all_objfiles.
8860         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8861         * symmisc.c (print_symbol_bcache_statistics)
8862         (print_objfile_statistics, maintenance_print_objfiles)
8863         (maintenance_info_symtabs, maintenance_check_symtabs)
8864         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8865         all_objfiles.
8866         * source.c (forget_cached_source_info): Use all_objfiles.
8867         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8868         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8869         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8870         * objfiles.c (update_section_map): Use all_objfiles.
8871         (shared_objfile_contains_address_p): Likewise.
8872         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8873         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8874
8875 2019-01-09  Tom Tromey  <tom@tromey.com>
8876
8877         * common/next-iterator.h: New file.
8878         * objfiles.h (class all_objfiles): New.
8879         (struct objfile_iterator): New.
8880
8881 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8882
8883         * NEWS: Move the description of the changed "frame", "select-frame",
8884          and "info frame" commands to the Changed commands section.
8885
8886 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8887
8888         * gdbtypes.c (check_stub_method_group): Remove handling of old
8889         mangling schemes.
8890         * linespec.c (find_methods): Likewise.
8891         * stabsread.c (read_member_functions): Likewise.
8892         * valops.c (search_struct_method): Likewise.
8893         (value_struct_elt_for_reference): Likewise.
8894         * NEWS: Mention this change.
8895
8896 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8899         print_source_lines.
8900         * source.c (print_source_lines_base): Update line number check.
8901         (print_source_lines): New function.
8902         (source_lines_range::source_lines_range): New function.
8903         * source.h (class source_lines_range): New class.
8904         (print_source_lines): New declaration.
8905
8906 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8907
8908         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8909
8910 2019-01-08  Tom Tromey  <tom@tromey.com>
8911             Simon Marchi  <simon.marchi@ericsson.com>
8912
8913         PR gdb/24060
8914         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8915         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8916         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8917         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8918         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8919         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8920
8921 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8922
8923         * source.c (select_source_symtab): Move header comment to
8924         declaration in source.h.
8925         (forget_cached_source_info_for_objfile): Likewise.
8926         (forget_cached_source_info): Likewise.
8927         (identify_source_line): Likewise.
8928         * source.h (identify_source_line): Move declaration from symtab.h
8929         and add comment from source.c
8930         (print_source_lines): Likewise.
8931         (forget_cached_source_info_for_objfile): Likewise.
8932         (forget_cached_source_info): Likewise.
8933         (select_source_symtab): Likewise.
8934         (enum print_source_lines_flag): Move definition from symtab.h.
8935         * symtab.h (identify_source_line): Move declaration to source.h.
8936         (print_source_lines): Likewise.
8937         (forget_cached_source_info_for_objfile): Likewise.
8938         (forget_cached_source_info): Likewise.
8939         (select_source_symtab): Likewise.
8940         (enum print_source_lines_flag): Move definition to source.h.
8941         * tui/tui-hooks.c: Add 'source.h' include.
8942
8943 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8944
8945         * source.c (print_source_lines_base): Handle requests to print
8946         reverse line number sequences, and guard against empty lines
8947         string.
8948
8949 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8950
8951         * source.c (print_source_lines_base): Fix skip of '\r' if next
8952         character is '\n'.
8953
8954 2019-01-06  Tom Tromey  <tom@tromey.com>
8955
8956         * c-exp.y (struct c_parse_state) <macro_original_text,
8957         expansion_obstack>: New member.
8958         (macro_original_text, expansion_obstack): Remove globals.
8959         (scan_macro_expansion, scanning_macro_expansion)
8960         (finished_macro_expansion): Update.
8961         (scan_macro_cleanup): Remove.
8962         (yylex, c_parse): Update.
8963
8964 2019-01-06  Tom Tromey  <tom@tromey.com>
8965
8966         * c-exp.y (struct c_parse_state) <strings>: New member.
8967         (operator_stoken): Update.
8968
8969 2019-01-06  Tom Tromey  <tom@tromey.com>
8970
8971         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8972         (union type_stack_elt) <typelist_val>: Now a pointer to
8973         std::vector.
8974         (type_stack_cleanup): Don't declare.
8975         (push_typelist): Update.
8976         * parse.c (pop_typelist): Return a std::vector.
8977         (push_typelist): Take a std::vector.
8978         (follow_types): Update.  Do not free args.
8979         (type_stack_cleanup): Remove.
8980         * c-exp.y (struct c_parse_state): New.
8981         (cpstate): New global.
8982         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8983         (nonempty_typelist): Update.
8984         (func_mod): Create a new vector.
8985         (c_parse): Create a c_parse_state.
8986         (check_parameter_typelist): Do not delete params.
8987         (function_method): Update.  Do not delete type_list.
8988
8989 2019-01-06  Tom Tromey  <tom@tromey.com>
8990
8991         PR gdb/28155:
8992         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8993         check_typedef.
8994         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8995         (print_return_value): Likewise.
8996
8997 2019-01-05  Tom Tromey  <tom@tromey.com>
8998
8999         * contrib/cleanup_check.py: Remove.
9000         * contrib/gcc-with-excheck: Remove.
9001         * contrib/exsummary.py: Remove.
9002         * contrib/excheck.py: Remove.
9003
9004 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9005
9006         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9007         NULL. Initialize tpprev to NULL instead of assigning it
9008         to NULL on the next statement.
9009         * windows-nat.c (windows_delete_thread): Remove check for
9010         main_thread_id before printing thread exit notifications.
9011         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9012         Remove thread ID check against main_thread_id.
9013         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9014         windows_delete_thread.
9015         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9016
9017 2019-01-04  Tom Tromey  <tom@tromey.com>
9018
9019         * compile/compile.c (_initialize_compile): Use upper case for
9020         metasyntactic variables.
9021         * symmisc.c (_initialize_symmisc): Use upper case for
9022         metasyntactic variables.
9023         * psymtab.c (_initialize_psymtab): Use upper case for
9024         metasyntactic variables.
9025         * demangle.c (demangle_command): Use upper case for metasyntactic
9026         variables.
9027         (_initialize_demangler): Likewise.
9028         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9029         variables.
9030
9031 2019-01-03  Tom Tromey  <tom@tromey.com>
9032
9033         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9034
9035 2019-01-03  Tom Tromey  <tom@tromey.com>
9036
9037         * python/py-symtab.c (salpy_str): Update.
9038         (struct salpy_sal_object) <symtab>: Now a PyObject.
9039         (salpy_dealloc): Update.
9040         (del_objfile_sal): Use gdbpy_ref.
9041
9042 2019-01-03  Tom Tromey  <tom@tromey.com>
9043
9044         * python/py-type.c (convert_field): Use new_reference.  Return
9045         gdbpy_ref.
9046         (make_fielditem): Return gdbpy_ref.
9047         (typy_fields): Update.
9048         (typy_getitem): Update.
9049         (field_name): Return gdbpy_ref.  Use new_reference.
9050         (typy_iterator_iternext): Update.
9051
9052 2019-01-03  Tom Tromey  <tom@tromey.com>
9053
9054         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9055
9056 2019-01-03  Tom Tromey  <tom@tromey.com>
9057
9058         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9059         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9060         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9061         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9062         (pspy_set_type_printers): Likewise.
9063         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9064         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9065         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9066         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9067         (objfpy_set_type_printers): Likewise.
9068
9069 2019-01-03  Tom Tromey  <tom@tromey.com>
9070
9071         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9072         (gdbpy_print_stack): Use gdbpy_err_fetch.
9073         * python/python-internal.h (class gdbpy_err_fetch): New class.
9074         (class gdbpy_enter) <m_error_type, m_error_value,
9075         m_error_traceback>: Remove.
9076         <m_error>: New member.
9077         (gdbpy_exception_to_string): Don't declare.
9078         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9079         * python/py-value.c (convert_value_from_python): Use
9080         gdbpy_err_fetch.
9081         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9082         gdbpy_exception_to_string.
9083         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9084         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9085         gdbpy_err_fetch.
9086
9087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9088
9089         * linux-nat.c (delete_lwp_cleanup): Delete.
9090         (struct lwp_deleter): New struct.
9091         (lwp_info_up): New typedef.
9092         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9093         lwp_info_up.
9094
9095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9096
9097         * linux-fork.c (class scoped_switch_fork_info): New class.
9098         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9099
9100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9101
9102         * valops.c (find_overload_match): Remove use of null_cleanup, and
9103         calls to do_cleanups.
9104
9105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * compile/compile-cplus-types.c
9108         (compile_cplus_instance::decl_name): Handle changes to
9109         cp_func_name.
9110         * cp-support.c (cp_func_name): Update header comment, update
9111         return type.
9112         * cp-support.h (cp_func_name): Update return type in declaration.
9113         * valops.c (find_overload_match): Move temp_func local to top
9114         level of function and change its type.  Use temp_func to hold and
9115         delete temporary string obtained from cp_func_name.
9116
9117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9118
9119         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9120         gdb::char_vector, remove cleanup, and update uses of `msg`.
9121
9122 2019-01-03  Jim Wilson  <jimw@sifive.com>
9123
9124         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9125
9126 2019-01-02  Tom Tromey  <tom@tromey.com>
9127
9128         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9129         (tdesc_parse_xml): Remove cleanups.
9130         * target-descriptions.h (make_cleanup_free_target_description):
9131         Don't declare.
9132         (target_desc_deleter): New struct.
9133         (target_desc_up): New typedef.
9134         * target-descriptions.c (target_desc_deleter::operator()): Rename
9135         from free_target_description.
9136         (make_cleanup_free_target_description): Remove.
9137
9138 2019-01-02  Tom Tromey  <tom@tromey.com>
9139
9140         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9141         constructor, destructor.
9142         (linespec_parser): Remove typedef.
9143         (~linespec_parser): Rename from linespec_parser_delete.
9144         (linespec_lex_to_end, linespec_complete_label)
9145         (linespec_complete): Update.
9146         (decode_line_full): Remove cleanups.
9147         (decode_line_1): Update.
9148
9149 2019-01-02  Tom Tromey  <tom@tromey.com>
9150
9151         * python/python-internal.h (inferior_to_inferior_object): Change
9152         return type.
9153         * python/py-exitedevent.c (create_exited_event_object): Update.
9154         * python/py-inferior.c (inferior_to_inferior_object): Return
9155         gdbpy_ref.
9156         (python_new_inferior, python_inferior_deleted)
9157         (thread_to_thread_object, delete_thread_object)
9158         (build_inferior_list, gdbpy_selected_inferior): Update.
9159         * python/py-infthread.c (create_thread_object): Update.  Also fail
9160         if inferior_to_inferior_object fails.
9161
9162 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9163
9164         * inferior.h (class inferior) <displaced_step_state>: New field.
9165         * infrun.h (struct displaced_step_state): Move here from
9166         infrun.c.  Initialize fields, add constructor.
9167         <inf>: Remove field.
9168         <reset>: New method.
9169         * infrun.c (struct displaced_step_inferior_state): Move to
9170         infrun.h.
9171         (displaced_step_inferior_states): Remove.
9172         (get_displaced_stepping_state): Adust.
9173         (displaced_step_in_progress_any_inferior): Adjust.
9174         (displaced_step_in_progress_thread): Adjust.
9175         (displaced_step_in_progress): Adjust.
9176         (add_displaced_stepping_state): Remove.
9177         (get_displaced_step_closure_by_addr): Adjust.
9178         (remove_displaced_stepping_state): Remove.
9179         (infrun_inferior_exit): Call displaced_step_state.reset.
9180         (use_displaced_stepping): Don't check for NULL.
9181         (displaced_step_prepare_throw): Call
9182         get_displaced_stepping_state.
9183         (displaced_step_fixup): Don't check for NULL.
9184         (prepare_for_detach): Don't check for NULL.
9185
9186 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9187
9188         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9189          in case of call that did not complete.
9190
9191 2019-01-02  Andrey Utkin  <autkin@undo.io>
9192
9193         * symfile.c (find_separate_debug_file): Fix search of debug files for
9194         remote debuggee.
9195
9196 2019-01-02  Tom Tromey  <tom@tromey.com>
9197
9198         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9199         indentation.
9200         * python/py-frame.c (frapy_older): Remove cast.
9201         (frapy_newer): Likewise.
9202         * python/py-breakpoint.c (local_setattro): Remove cast.
9203         * python/py-arch.c (archpy_name): Remove local variable.
9204         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9205
9206 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9207
9208         * unittests/basic_string_view/element_access/char/empty.cc:
9209         Fix year range in copyright header.
9210
9211 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9212
9213         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9214         Delete.
9215         <operator==>: Update with for removed field.
9216         <hash>: Likewise.
9217         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9218         <isa_features>: ...this.
9219         <abi_features>: New field.
9220         (riscv_isa_flen): Update comment.
9221         (riscv_abi_xlen): New declaration.
9222         (riscv_abi_flen): New declaration.
9223         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9224         isa_features.
9225         (riscv_abi_xlen): New function.
9226         (riscv_isa_flen): Update to get answer from isa_features.
9227         (riscv_abi_flen): New function.
9228         (riscv_has_fp_abi): Update to get answer from abi_features.
9229         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9230         xlen and flen.
9231         (riscv_call_info) <xlen, flen>: Update comment.
9232         (riscv_call_arg_struct): Remove invalid assertions
9233         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9234         is removed.
9235         (riscv_gdbarch_init): Gather isa features and abi features
9236         separately, ensure both match on the gdbarch when reusing an old
9237         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9238         a target with 64-bit float hardware.
9239
9240 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9241
9242         * source.c (search_command_helper): Stop reverse search
9243         when line 1 has been searched.
9244
9245 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9246
9247         * record-full.c (record_full_base_target::close): Rewrite
9248         record_full_core_buf_list free logic.
9249
9250 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9251
9252         * break-catch-syscall.c (print_one_catch_syscall): xfree
9253         the last text.
9254
9255 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9256
9257         * top.c (print_gdb_version): Update Copyright year in version
9258         message.
9259
9260 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9261
9262         Update copyright year range in all GDB files.
9263
9264 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9265
9266         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9267
9268 For older changes see ChangeLog-2018.
9269 \f
9270 Local Variables:
9271 mode: change-log
9272 left-margin: 8
9273 fill-column: 74
9274 version-control: never
9275 coding: utf-8
9276 End:
9277