gdb/ChangeLog

   1 2019-02-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * ravenscar-thread.c (base_ptid): Remove.
   4         (struct ravenscar_thread_target) <close>: New method.
   5         <m_base_ptid>: New member.
   6         <update_inferior_ptid, active_task, task_is_currently_active,
   7         runtime_initialized>: Declare methods.
   8         <ravenscar_thread_target>: Add constructor.
   9         (ravenscar_thread_target::task_is_currently_active)
  10         (ravenscar_thread_target::update_inferior_ptid)
  11         (ravenscar_runtime_initialized): Rename.  Now methods.
  12         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  13         (ravenscar_thread_target::update_thread_list): Update.
  14         (ravenscar_thread_target::active_task): Now method.
  15         (ravenscar_thread_target::store_registers)
  16         (ravenscar_thread_target::prepare_to_store)
  17         (ravenscar_thread_target::prepare_to_store)
  18         (ravenscar_thread_target::mourn_inferior): Update.
  19         (ravenscar_inferior_created): Use "new" to create target.
  20         (ravenscar_thread_target::get_ada_task_ptid): Update.
  21         (_initialize_ravenscar): Don't initialize base_ptid.
  22         (ravenscar_ops): Remove global.
  23
  24 2019-02-15  Tom Tromey  <tromey@adacore.com>
  25
  26         * target.h (push_target): Declare new overload.
  27         * target.c (push_target): New overload, taking an rvalue reference.
  28         * remote.c (remote_target::open_1): Use push_target overload.
  29         * corelow.c (core_target_open): Use push_target overload.
  30
  31 2019-02-15  Tom Tromey  <tromey@adacore.com>
  32
  33         * ravenscar-thread.c (is_ravenscar_task)
  34         (ravenscar_task_is_currently_active): Return bool.
  35         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  36         (_initialize_ravenscar): Remove "(void)".
  37         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  38         Return bool.
  39
  40 2019-02-15  Tom Tromey  <tromey@adacore.com>
  41
  42         * ravenscar-thread.c (ravenscar_runtime_initializer)
  43         (has_ravenscar_runtime, get_running_thread_id)
  44         (ravenscar_thread_target::resume): Fix indentation.
  45
  46 2019-02-15  Tom Tromey  <tromey@adacore.com>
  47
  48         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  49         from ravenscar_arch_ops.
  50         (sparc_ravenscar_ops::fetch_registers)
  51         (sparc_ravenscar_ops::store_registers): Now methods.
  52         (sparc_ravenscar_prepare_to_store): Remove.
  53         (sparc_ravenscar_ops): Redefine.
  54         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  55         methods and destructor.  Remove members.
  56         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  57         (ravenscar_thread_target::store_registers)
  58         (ravenscar_thread_target::prepare_to_store): Update.
  59         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
  60         Remove.
  61         (struct ppc_ravenscar_powerpc_ops): Derive from
  62         ravenscar_arch_ops.
  63         (ppc_ravenscar_powerpc_ops::fetch_registers)
  64         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
  65         (ppc_ravenscar_powerpc_ops): Redefine.
  66         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
  67         (ppc_ravenscar_e500_ops::fetch_registers)
  68         (ppc_ravenscar_e500_ops::store_registers): Now methods.
  69         (ppc_ravenscar_e500_ops): Redefine.
  70         * aarch64-ravenscar-thread.c
  71         (aarch64_ravenscar_generic_prepare_to_store): Remove.
  72         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
  73         (aarch64_ravenscar_fetch_registers)
  74         (aarch64_ravenscar_store_registers): Now methods.
  75         (aarch64_ravenscar_ops): Redefine.
  76
  77 2019-02-15  Tom Tromey  <tromey@adacore.com>
  78
  79         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
  80         (ravenscar_thread_target::stopped_by_hw_breakpoint)
  81         (ravenscar_thread_target::stopped_by_watchpoint)
  82         (ravenscar_thread_target::stopped_data_address)
  83         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
  84
  85 2019-02-15  Tom Tromey  <tromey@adacore.com>
  86
  87         * ravenscar-thread.c: Fix some typos.
  88
  89 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90             Tom Tromey  <tromey@adacore.com>
  91
  92         * ada-lang.c (ada_exception_sal): Change addr_string to a
  93         std::string.
  94         (create_ada_exception_catchpoint): Update.
  95
  96 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  97             Tom Tromey  <tromey@adacore.com>
  98
  99         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 100         (bp_location_ops): Remove.
 101         (base_breakpoint_allocate_location): Update.
 102         (free_bp_location): Update.
 103         * ada-lang.c (class ada_catchpoint_location)
 104         <ada_catchpoint_location>: Remove ops parameter.
 105         (ada_catchpoint_location_dtor): Remove.
 106         (ada_catchpoint_location_ops): Remove.
 107         (allocate_location_exception): Update.
 108         * breakpoint.h (struct bp_location_ops): Remove.
 109         (class bp_location) <bp_location>: Remove bp_location_ops
 110         parameter.
 111         <~bp_location>: Add destructor.
 112         <ops>: Remove.
 113
 114 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 115             Pedro Alves  <palves@redhat.com>
 116
 117         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 118         'PATH_MAX'.
 119
 120 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 121             Samuel Thibault  <samuel.thibault@gnu.org>
 122             Thomas Schwinge  <thomas@codesourcery.com>
 123
 124         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 125         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 126
 127 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 128
 129         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 130         (check_empty): Use "const char *".
 131
 132         * gnu-nat.c (gnu_nat_target::detach): Instead of
 133         'detach_inferior (pid)' call
 134         'detach_inferior (find_inferior_pid (pid))'.
 135
 136         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 137         'nat/fork-inferior.o'.
 138         * gnu-nat.c: #include "nat/fork-inferior.h".
 139
 140         * gnu-nat.c (gnu_nat_target::detach): Instead of
 141         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 142         * gnu-nat.h: #include "inf-child.h".
 143         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 144         'i386_gnu_nat_target::fetch_registers'.
 145         (gnu_store_registers): Rename/move to
 146         'i386_gnu_nat_target::store_registers'.
 147
 148         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 149         * gnu-nat.h (mach_thread_info): New function.
 150         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 151
 152         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 153
 154 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 155
 156         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 157
 158 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 159
 160         * windows-nat.c (windows_add_thread): Add new parameter
 161         "main_thread_p" with default value set to false.  Update
 162         function documentation as well as all callers.
 163         (windows_delete_thread): Likewise.
 164         (fake_create_process): Update call to windows_add_thread.
 165         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 166         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 167         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 168         call to windows_delete_thread.
 169
 170 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 171
 172         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 173
 174 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 175
 176         * symfile.c (find_separate_debug_file): Use canonical path of
 177         sysroot with child_path instead of gdb_sysroot if it is valid.
 178
 179 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 180
 181         * symfile.c (find_separate_debug_file): Use child_path to
 182         determine if an object file is under a sysroot.
 183
 184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 185
 186         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 187         unittests/child-path-selftests.c.
 188         * common/pathstuff.c (child_path): New function.
 189         * common/pathstuff.h (child_path): New prototype.
 190         * unittests/child-path-selftests.c: New file.
 191
 192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 193
 194         * symfile.c (find_separate_debug_file): Look for separate debug
 195         files in debug directories under the sysroot.
 196
 197 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 198
 199         * symtab.h (struct minimal_symbol data_p): New const method.
 200         (struct minimal_symbol text_p): Likewise.
 201         * symtab.c (output_source_filename): Use file name style
 202         to print file name.
 203         (print_symbol_info): Likewise.
 204         (print_msymbol_info): Use address style to print addresses.
 205         Use function name style to print executable text symbols.
 206         (expand_symtab_containing_pc): Use data_p.
 207         (find_pc_sect_compunit_symtab): Likewise.
 208
 209 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 210
 211         * breakpoint.c (describe_other_breakpoints): Use address style
 212         to print addresses.
 213         (say_where): Likewise.
 214
 215 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216
 217         * ada-typeprint.c (print_func_type): Print function name
 218         style to print function name.
 219         * c-typeprint.c (c_print_type_1): Likewise.
 220
 221 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 222
 223         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 224         for execve.
 225
 226 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 227
 228         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 229         type_stack.
 230
 231 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 232
 233         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 234         TYPE_CODE_REF types.
 235
 236 2019-02-08  Jim Wilson  <jimw@sifive.com>
 237
 238         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 239         (riscv_linux_fregset): New.
 240         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 241
 242 2019-02-07  Tom Tromey  <tom@tromey.com>
 243
 244         * thread.c (thread_cancel_execution_command): Update.
 245         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 246         methods.
 247         (struct thread_fsm_ops): Remove.
 248         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 249         (thread_fsm_should_stop, thread_fsm_return_value)
 250         (thread_fsm_set_finished, thread_fsm_finished_p)
 251         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 252         Don't declare.
 253         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 254         * infrun.c (clear_proceed_status_thread)
 255         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 256         (print_stop_event): Update.
 257         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 258         Add constructor.
 259         (step_command_fsm_ops): Remove.
 260         (new_step_command_fsm): Remove.
 261         (step_1): Update.
 262         (step_command_fsm::should_stop): Rename from
 263         step_command_fsm_should_stop.
 264         (step_command_fsm::clean_up): Rename from
 265         step_command_fsm_clean_up.
 266         (step_command_fsm::do_async_reply_reason): Rename from
 267         step_command_fsm_async_reply_reason.
 268         (struct until_next_fsm): Inherit from thread_fsm.  Add
 269         constructor.
 270         (until_next_fsm_ops): Remove.
 271         (new_until_next_fsm): Remove.
 272         (until_next_fsm::should_stop): Rename from
 273         until_next_fsm_should_stop.
 274         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 275         (until_next_fsm::do_async_reply_reason): Rename from
 276         until_next_fsm_async_reply_reason.
 277         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 278         constructor.  Change type of breakpoint.
 279         (finish_command_fsm_ops): Remove.
 280         (new_finish_command_fsm): Remove.
 281         (finish_command_fsm::should_stop): Rename from
 282         finish_command_fsm_should_stop.
 283         (finish_command_fsm::clean_up): Rename from
 284         finish_command_fsm_clean_up.
 285         (finish_command_fsm::return_value): Rename from
 286         finish_command_fsm_return_value.
 287         (finish_command_fsm::do_async_reply_reason): Rename from
 288         finish_command_fsm_async_reply_reason.
 289         (finish_command): Update.
 290         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 291         Add constructor.
 292         (call_thread_fsm_ops): Remove.
 293         (call_thread_fsm::call_thread_fsm): Rename from
 294         new_call_thread_fsm.
 295         (call_thread_fsm::should_stop): Rename from
 296         call_thread_fsm_should_stop.
 297         (call_thread_fsm::should_notify_stop): Rename from
 298         call_thread_fsm_should_notify_stop.
 299         (run_inferior_call, call_function_by_hand_dummy): Update.
 300         * cli/cli-interp.c (should_print_stop_to_console): Update.
 301         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 302         Add constructor.  Change type of location_breakpoint,
 303         caller_breakpoint.
 304         (until_break_fsm_ops): Remove.
 305         (new_until_break_fsm): Remove.
 306         (until_break_fsm::should_stop): Rename from
 307         until_break_fsm_should_stop.
 308         (until_break_fsm::clean_up): Rename from
 309         until_break_fsm_clean_up.
 310         (until_break_fsm::do_async_reply_reason): Rename from
 311         until_break_fsm_async_reply_reason.
 312         (until_break_command): Update.
 313         * thread-fsm.c: Remove.
 314         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 315
 316 2019-02-07  Tom Tromey  <tom@tromey.com>
 317
 318         * yy-remap.h: Add include guard.
 319         * xtensa-tdep.h: Add include guard.
 320         * xcoffread.h: Rename include guard.
 321         * varobj-iter.h: Add include guard.
 322         * tui/tui.h: Rename include guard.
 323         * tui/tui-winsource.h: Rename include guard.
 324         * tui/tui-wingeneral.h: Rename include guard.
 325         * tui/tui-windata.h: Rename include guard.
 326         * tui/tui-win.h: Rename include guard.
 327         * tui/tui-stack.h: Rename include guard.
 328         * tui/tui-source.h: Rename include guard.
 329         * tui/tui-regs.h: Rename include guard.
 330         * tui/tui-out.h: Rename include guard.
 331         * tui/tui-layout.h: Rename include guard.
 332         * tui/tui-io.h: Rename include guard.
 333         * tui/tui-hooks.h: Rename include guard.
 334         * tui/tui-file.h: Rename include guard.
 335         * tui/tui-disasm.h: Rename include guard.
 336         * tui/tui-data.h: Rename include guard.
 337         * tui/tui-command.h: Rename include guard.
 338         * tic6x-tdep.h: Add include guard.
 339         * target/waitstatus.h: Rename include guard.
 340         * target/wait.h: Rename include guard.
 341         * target/target.h: Rename include guard.
 342         * target/resume.h: Rename include guard.
 343         * target-float.h: Rename include guard.
 344         * stabsread.h: Add include guard.
 345         * rs6000-tdep.h: Add include guard.
 346         * riscv-fbsd-tdep.h: Add include guard.
 347         * regformats/regdef.h: Rename include guard.
 348         * record.h: Rename include guard.
 349         * python/python.h: Rename include guard.
 350         * python/python-internal.h: Rename include guard.
 351         * python/py-stopevent.h: Rename include guard.
 352         * python/py-ref.h: Rename include guard.
 353         * python/py-record.h: Rename include guard.
 354         * python/py-record-full.h: Rename include guard.
 355         * python/py-record-btrace.h: Rename include guard.
 356         * python/py-instruction.h: Rename include guard.
 357         * python/py-events.h: Rename include guard.
 358         * python/py-event.h: Rename include guard.
 359         * procfs.h: Add include guard.
 360         * proc-utils.h: Add include guard.
 361         * p-lang.h: Add include guard.
 362         * or1k-tdep.h: Rename include guard.
 363         * observable.h: Rename include guard.
 364         * nto-tdep.h: Rename include guard.
 365         * nat/x86-linux.h: Rename include guard.
 366         * nat/x86-linux-dregs.h: Rename include guard.
 367         * nat/x86-gcc-cpuid.h: Add include guard.
 368         * nat/x86-dregs.h: Rename include guard.
 369         * nat/x86-cpuid.h: Rename include guard.
 370         * nat/ppc-linux.h: Rename include guard.
 371         * nat/mips-linux-watch.h: Rename include guard.
 372         * nat/linux-waitpid.h: Rename include guard.
 373         * nat/linux-ptrace.h: Rename include guard.
 374         * nat/linux-procfs.h: Rename include guard.
 375         * nat/linux-osdata.h: Rename include guard.
 376         * nat/linux-nat.h: Rename include guard.
 377         * nat/linux-namespaces.h: Rename include guard.
 378         * nat/linux-btrace.h: Rename include guard.
 379         * nat/glibc_thread_db.h: Rename include guard.
 380         * nat/gdb_thread_db.h: Rename include guard.
 381         * nat/gdb_ptrace.h: Rename include guard.
 382         * nat/fork-inferior.h: Rename include guard.
 383         * nat/amd64-linux-siginfo.h: Rename include guard.
 384         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 385         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 386         * nat/aarch64-linux.h: Rename include guard.
 387         * nat/aarch64-linux-hw-point.h: Rename include guard.
 388         * mn10300-tdep.h: Add include guard.
 389         * mips-linux-tdep.h: Add include guard.
 390         * mi/mi-parse.h: Rename include guard.
 391         * mi/mi-out.h: Rename include guard.
 392         * mi/mi-main.h: Rename include guard.
 393         * mi/mi-interp.h: Rename include guard.
 394         * mi/mi-getopt.h: Rename include guard.
 395         * mi/mi-console.h: Rename include guard.
 396         * mi/mi-common.h: Rename include guard.
 397         * mi/mi-cmds.h: Rename include guard.
 398         * mi/mi-cmd-break.h: Rename include guard.
 399         * m2-lang.h: Add include guard.
 400         * location.h: Rename include guard.
 401         * linux-record.h: Rename include guard.
 402         * linux-nat.h: Add include guard.
 403         * linux-fork.h: Add include guard.
 404         * i386-darwin-tdep.h: Rename include guard.
 405         * hppa-linux-offsets.h: Add include guard.
 406         * guile/guile.h: Rename include guard.
 407         * guile/guile-internal.h: Rename include guard.
 408         * gnu-nat.h: Rename include guard.
 409         * gdb-stabs.h: Rename include guard.
 410         * frv-tdep.h: Add include guard.
 411         * f-lang.h: Add include guard.
 412         * event-loop.h: Add include guard.
 413         * darwin-nat.h: Rename include guard.
 414         * cp-abi.h: Rename include guard.
 415         * config/sparc/nm-sol2.h: Rename include guard.
 416         * config/nm-nto.h: Rename include guard.
 417         * config/nm-linux.h: Add include guard.
 418         * config/i386/nm-i386gnu.h: Rename include guard.
 419         * config/djgpp/nl_types.h: Rename include guard.
 420         * config/djgpp/langinfo.h: Rename include guard.
 421         * compile/gcc-cp-plugin.h: Add include guard.
 422         * compile/gcc-c-plugin.h: Add include guard.
 423         * compile/compile.h: Rename include guard.
 424         * compile/compile-object-run.h: Rename include guard.
 425         * compile/compile-object-load.h: Rename include guard.
 426         * compile/compile-internal.h: Rename include guard.
 427         * compile/compile-cplus.h: Rename include guard.
 428         * compile/compile-c.h: Rename include guard.
 429         * common/xml-utils.h: Rename include guard.
 430         * common/x86-xstate.h: Rename include guard.
 431         * common/version.h: Rename include guard.
 432         * common/vec.h: Rename include guard.
 433         * common/tdesc.h: Rename include guard.
 434         * common/selftest.h: Rename include guard.
 435         * common/scoped_restore.h: Rename include guard.
 436         * common/scoped_mmap.h: Rename include guard.
 437         * common/scoped_fd.h: Rename include guard.
 438         * common/safe-iterator.h: Rename include guard.
 439         * common/run-time-clock.h: Rename include guard.
 440         * common/refcounted-object.h: Rename include guard.
 441         * common/queue.h: Rename include guard.
 442         * common/ptid.h: Rename include guard.
 443         * common/print-utils.h: Rename include guard.
 444         * common/preprocessor.h: Rename include guard.
 445         * common/pathstuff.h: Rename include guard.
 446         * common/observable.h: Rename include guard.
 447         * common/netstuff.h: Rename include guard.
 448         * common/job-control.h: Rename include guard.
 449         * common/host-defs.h: Rename include guard.
 450         * common/gdb_wait.h: Rename include guard.
 451         * common/gdb_vecs.h: Rename include guard.
 452         * common/gdb_unlinker.h: Rename include guard.
 453         * common/gdb_unique_ptr.h: Rename include guard.
 454         * common/gdb_tilde_expand.h: Rename include guard.
 455         * common/gdb_sys_time.h: Rename include guard.
 456         * common/gdb_string_view.h: Rename include guard.
 457         * common/gdb_splay_tree.h: Rename include guard.
 458         * common/gdb_setjmp.h: Rename include guard.
 459         * common/gdb_ref_ptr.h: Rename include guard.
 460         * common/gdb_optional.h: Rename include guard.
 461         * common/gdb_locale.h: Rename include guard.
 462         * common/gdb_assert.h: Rename include guard.
 463         * common/filtered-iterator.h: Rename include guard.
 464         * common/filestuff.h: Rename include guard.
 465         * common/fileio.h: Rename include guard.
 466         * common/environ.h: Rename include guard.
 467         * common/common-utils.h: Rename include guard.
 468         * common/common-types.h: Rename include guard.
 469         * common/common-regcache.h: Rename include guard.
 470         * common/common-inferior.h: Rename include guard.
 471         * common/common-gdbthread.h: Rename include guard.
 472         * common/common-exceptions.h: Rename include guard.
 473         * common/common-defs.h: Rename include guard.
 474         * common/common-debug.h: Rename include guard.
 475         * common/cleanups.h: Rename include guard.
 476         * common/buffer.h: Rename include guard.
 477         * common/btrace-common.h: Rename include guard.
 478         * common/break-common.h: Rename include guard.
 479         * cli/cli-utils.h: Rename include guard.
 480         * cli/cli-style.h: Rename include guard.
 481         * cli/cli-setshow.h: Rename include guard.
 482         * cli/cli-script.h: Rename include guard.
 483         * cli/cli-interp.h: Rename include guard.
 484         * cli/cli-decode.h: Rename include guard.
 485         * cli/cli-cmds.h: Rename include guard.
 486         * charset-list.h: Add include guard.
 487         * buildsym-legacy.h: Rename include guard.
 488         * bfin-tdep.h: Add include guard.
 489         * ax.h: Rename include guard.
 490         * arm-linux-tdep.h: Add include guard.
 491         * arm-fbsd-tdep.h: Add include guard.
 492         * arch/xtensa.h: Rename include guard.
 493         * arch/tic6x.h: Add include guard.
 494         * arch/i386.h: Add include guard.
 495         * arch/arm.h: Rename include guard.
 496         * arch/arm-linux.h: Rename include guard.
 497         * arch/arm-get-next-pcs.h: Rename include guard.
 498         * arch/amd64.h: Add include guard.
 499         * arch/aarch64-insn.h: Rename include guard.
 500         * arch-utils.h: Rename include guard.
 501         * annotate.h: Add include guard.
 502         * amd64-darwin-tdep.h: Rename include guard.
 503         * aarch64-linux-tdep.h: Add include guard.
 504         * aarch64-fbsd-tdep.h: Add include guard.
 505         * aarch32-linux-nat.h: Add include guard.
 506
 507 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 508
 509         * macrotab.c (macro_define_internal): New function that
 510         factorizes macro_define_object_internal and macro_define_function
 511         code.
 512         (macro_define_object_internal): Use macro_define_internal.
 513         (macro_define_function): Likewise.
 514
 515 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 516
 517         * macrocmd.c (extract_identifier): Return
 518         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 519         callers.
 520
 521 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 522
 523         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 524
 525 2019-02-05  Tom Tromey  <tom@tromey.com>
 526
 527         * target.c (target_stack::unpush): Move assertion earlier.
 528
 529 2019-01-30  Tom Tromey  <tom@tromey.com>
 530
 531         PR python/23615:
 532         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 533         (gdbpy_parse_and_eval): Likewise.
 534         * python/python-internal.h (gdbpy_allow_threads): New class.
 535
 536 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 537
 538         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 539         (aarch64_fbsd_fpregmap): Move earlier.
 540         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 541         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 542         instead of individual calls to trad_frame_set_reg_addr.
 543         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 544         earlier.
 545         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 546         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 547         instead of individual calls to trad_frame_set_reg_addr.
 548
 549 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 550
 551         * CONTRIBUTE: Replace contribution list with wiki link.
 552
 553 2019-01-25  Tom Tromey  <tom@tromey.com>
 554
 555         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 556
 557 2019-01-25  Tom Tromey  <tom@tromey.com>
 558
 559         * xtensa-linux-nat.c: Fix common/ includes.
 560         * xml-support.h: Fix common/ includes.
 561         * xml-support.c: Fix common/ includes.
 562         * x86-linux-nat.c: Fix common/ includes.
 563         * windows-nat.c: Fix common/ includes.
 564         * varobj.h: Fix common/ includes.
 565         * varobj.c: Fix common/ includes.
 566         * value.c: Fix common/ includes.
 567         * valops.c: Fix common/ includes.
 568         * utils.c: Fix common/ includes.
 569         * unittests/xml-utils-selftests.c: Fix common/ includes.
 570         * unittests/utils-selftests.c: Fix common/ includes.
 571         * unittests/unpack-selftests.c: Fix common/ includes.
 572         * unittests/tracepoint-selftests.c: Fix common/ includes.
 573         * unittests/style-selftests.c: Fix common/ includes.
 574         * unittests/string_view-selftests.c: Fix common/ includes.
 575         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 576         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 577         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 578         * unittests/rsp-low-selftests.c: Fix common/ includes.
 579         * unittests/parse-connection-spec-selftests.c: Fix common/
 580         includes.
 581         * unittests/optional-selftests.c: Fix common/ includes.
 582         * unittests/offset-type-selftests.c: Fix common/ includes.
 583         * unittests/observable-selftests.c: Fix common/ includes.
 584         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 585         * unittests/memrange-selftests.c: Fix common/ includes.
 586         * unittests/memory-map-selftests.c: Fix common/ includes.
 587         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 588         * unittests/function-view-selftests.c: Fix common/ includes.
 589         * unittests/environ-selftests.c: Fix common/ includes.
 590         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 591         * unittests/common-utils-selftests.c: Fix common/ includes.
 592         * unittests/cli-utils-selftests.c: Fix common/ includes.
 593         * unittests/array-view-selftests.c: Fix common/ includes.
 594         * ui-file.c: Fix common/ includes.
 595         * tui/tui-io.c: Fix common/ includes.
 596         * tracepoint.h: Fix common/ includes.
 597         * tracepoint.c: Fix common/ includes.
 598         * tracefile-tfile.c: Fix common/ includes.
 599         * top.h: Fix common/ includes.
 600         * top.c: Fix common/ includes.
 601         * thread.c: Fix common/ includes.
 602         * target/waitstatus.h: Fix common/ includes.
 603         * target/waitstatus.c: Fix common/ includes.
 604         * target.h: Fix common/ includes.
 605         * target.c: Fix common/ includes.
 606         * target-memory.c: Fix common/ includes.
 607         * target-descriptions.c: Fix common/ includes.
 608         * symtab.h: Fix common/ includes.
 609         * symfile.c: Fix common/ includes.
 610         * stap-probe.c: Fix common/ includes.
 611         * spu-linux-nat.c: Fix common/ includes.
 612         * sparc-nat.c: Fix common/ includes.
 613         * source.c: Fix common/ includes.
 614         * solib.c: Fix common/ includes.
 615         * solib-target.c: Fix common/ includes.
 616         * ser-unix.c: Fix common/ includes.
 617         * ser-tcp.c: Fix common/ includes.
 618         * ser-pipe.c: Fix common/ includes.
 619         * ser-base.c: Fix common/ includes.
 620         * selftest-arch.c: Fix common/ includes.
 621         * s12z-tdep.c: Fix common/ includes.
 622         * rust-exp.y: Fix common/ includes.
 623         * rs6000-aix-tdep.c: Fix common/ includes.
 624         * riscv-tdep.c: Fix common/ includes.
 625         * remote.c: Fix common/ includes.
 626         * remote-notif.h: Fix common/ includes.
 627         * remote-fileio.h: Fix common/ includes.
 628         * remote-fileio.c: Fix common/ includes.
 629         * regcache.h: Fix common/ includes.
 630         * regcache.c: Fix common/ includes.
 631         * record-btrace.c: Fix common/ includes.
 632         * python/python.c: Fix common/ includes.
 633         * python/py-type.c: Fix common/ includes.
 634         * python/py-inferior.c: Fix common/ includes.
 635         * progspace.h: Fix common/ includes.
 636         * producer.c: Fix common/ includes.
 637         * procfs.c: Fix common/ includes.
 638         * proc-api.c: Fix common/ includes.
 639         * printcmd.c: Fix common/ includes.
 640         * ppc-linux-nat.c: Fix common/ includes.
 641         * parser-defs.h: Fix common/ includes.
 642         * osdata.c: Fix common/ includes.
 643         * obsd-nat.c: Fix common/ includes.
 644         * nat/x86-linux.c: Fix common/ includes.
 645         * nat/x86-linux-dregs.c: Fix common/ includes.
 646         * nat/x86-dregs.h: Fix common/ includes.
 647         * nat/x86-dregs.c: Fix common/ includes.
 648         * nat/ppc-linux.c: Fix common/ includes.
 649         * nat/mips-linux-watch.h: Fix common/ includes.
 650         * nat/mips-linux-watch.c: Fix common/ includes.
 651         * nat/linux-waitpid.c: Fix common/ includes.
 652         * nat/linux-ptrace.h: Fix common/ includes.
 653         * nat/linux-ptrace.c: Fix common/ includes.
 654         * nat/linux-procfs.c: Fix common/ includes.
 655         * nat/linux-personality.c: Fix common/ includes.
 656         * nat/linux-osdata.c: Fix common/ includes.
 657         * nat/linux-namespaces.c: Fix common/ includes.
 658         * nat/linux-btrace.h: Fix common/ includes.
 659         * nat/linux-btrace.c: Fix common/ includes.
 660         * nat/fork-inferior.c: Fix common/ includes.
 661         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 662         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 663         * nat/aarch64-linux.c: Fix common/ includes.
 664         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 665         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 666         * namespace.h: Fix common/ includes.
 667         * mips-linux-tdep.c: Fix common/ includes.
 668         * minsyms.c: Fix common/ includes.
 669         * mi/mi-parse.h: Fix common/ includes.
 670         * mi/mi-main.c: Fix common/ includes.
 671         * mi/mi-cmd-env.c: Fix common/ includes.
 672         * memrange.h: Fix common/ includes.
 673         * memattr.c: Fix common/ includes.
 674         * maint.h: Fix common/ includes.
 675         * maint.c: Fix common/ includes.
 676         * main.c: Fix common/ includes.
 677         * machoread.c: Fix common/ includes.
 678         * location.c: Fix common/ includes.
 679         * linux-thread-db.c: Fix common/ includes.
 680         * linux-nat.c: Fix common/ includes.
 681         * linux-fork.c: Fix common/ includes.
 682         * inline-frame.c: Fix common/ includes.
 683         * infrun.c: Fix common/ includes.
 684         * inflow.c: Fix common/ includes.
 685         * inferior.h: Fix common/ includes.
 686         * inferior.c: Fix common/ includes.
 687         * infcmd.c: Fix common/ includes.
 688         * inf-ptrace.c: Fix common/ includes.
 689         * inf-child.c: Fix common/ includes.
 690         * ia64-linux-nat.c: Fix common/ includes.
 691         * i387-tdep.c: Fix common/ includes.
 692         * i386-tdep.c: Fix common/ includes.
 693         * i386-linux-tdep.c: Fix common/ includes.
 694         * i386-linux-nat.c: Fix common/ includes.
 695         * i386-go32-tdep.c: Fix common/ includes.
 696         * i386-fbsd-tdep.c: Fix common/ includes.
 697         * i386-fbsd-nat.c: Fix common/ includes.
 698         * guile/scm-type.c: Fix common/ includes.
 699         * guile/guile.c: Fix common/ includes.
 700         * go32-nat.c: Fix common/ includes.
 701         * gnu-nat.c: Fix common/ includes.
 702         * gdbthread.h: Fix common/ includes.
 703         * gdbarch-selftests.c: Fix common/ includes.
 704         * gdb_usleep.c: Fix common/ includes.
 705         * gdb_select.h: Fix common/ includes.
 706         * gdb_bfd.c: Fix common/ includes.
 707         * gcore.c: Fix common/ includes.
 708         * fork-child.c: Fix common/ includes.
 709         * findvar.c: Fix common/ includes.
 710         * fbsd-nat.c: Fix common/ includes.
 711         * event-top.c: Fix common/ includes.
 712         * event-loop.c: Fix common/ includes.
 713         * dwarf2read.c: Fix common/ includes.
 714         * dwarf2loc.c: Fix common/ includes.
 715         * dwarf2-frame.c: Fix common/ includes.
 716         * dwarf-index-cache.c: Fix common/ includes.
 717         * dtrace-probe.c: Fix common/ includes.
 718         * disasm-selftests.c: Fix common/ includes.
 719         * defs.h: Fix common/ includes.
 720         * csky-tdep.c: Fix common/ includes.
 721         * cp-valprint.c: Fix common/ includes.
 722         * cp-support.h: Fix common/ includes.
 723         * cp-support.c: Fix common/ includes.
 724         * corelow.c: Fix common/ includes.
 725         * completer.h: Fix common/ includes.
 726         * completer.c: Fix common/ includes.
 727         * compile/compile.c: Fix common/ includes.
 728         * compile/compile-loc2c.c: Fix common/ includes.
 729         * compile/compile-cplus-types.c: Fix common/ includes.
 730         * compile/compile-cplus-symbols.c: Fix common/ includes.
 731         * command.h: Fix common/ includes.
 732         * cli/cli-dump.c: Fix common/ includes.
 733         * cli/cli-cmds.c: Fix common/ includes.
 734         * charset.c: Fix common/ includes.
 735         * build-id.c: Fix common/ includes.
 736         * btrace.h: Fix common/ includes.
 737         * btrace.c: Fix common/ includes.
 738         * breakpoint.h: Fix common/ includes.
 739         * breakpoint.c: Fix common/ includes.
 740         * ax.h:
 741         (enum agent_op): Fix common/ includes.
 742         * ax-general.c (struct aop_map): Fix common/ includes.
 743         * ax-gdb.c: Fix common/ includes.
 744         * auxv.c: Fix common/ includes.
 745         * auto-load.c: Fix common/ includes.
 746         * arm-tdep.c: Fix common/ includes.
 747         * arch/riscv.c: Fix common/ includes.
 748         * arch/ppc-linux-common.c: Fix common/ includes.
 749         * arch/i386.c: Fix common/ includes.
 750         * arch/arm.c: Fix common/ includes.
 751         * arch/arm-linux.c: Fix common/ includes.
 752         * arch/arm-get-next-pcs.c: Fix common/ includes.
 753         * arch/amd64.c: Fix common/ includes.
 754         * arch/aarch64.c: Fix common/ includes.
 755         * arch/aarch64-insn.c: Fix common/ includes.
 756         * arch-utils.c: Fix common/ includes.
 757         * amd64-windows-tdep.c: Fix common/ includes.
 758         * amd64-tdep.c: Fix common/ includes.
 759         * amd64-sol2-tdep.c: Fix common/ includes.
 760         * amd64-obsd-tdep.c: Fix common/ includes.
 761         * amd64-nbsd-tdep.c: Fix common/ includes.
 762         * amd64-linux-tdep.c: Fix common/ includes.
 763         * amd64-linux-nat.c: Fix common/ includes.
 764         * amd64-fbsd-tdep.c: Fix common/ includes.
 765         * amd64-fbsd-nat.c: Fix common/ includes.
 766         * amd64-dicos-tdep.c: Fix common/ includes.
 767         * amd64-darwin-tdep.c: Fix common/ includes.
 768         * agent.c: Fix common/ includes.
 769         * ada-lang.h: Fix common/ includes.
 770         * ada-lang.c: Fix common/ includes.
 771         * aarch64-tdep.c: Fix common/ includes.
 772
 773 2019-01-25  Tom Tromey  <tom@tromey.com>
 774
 775         * common/create-version.sh: Use common/version.h.
 776
 777 2019-01-24  Pedro Alves  <palves@redhat.com>
 778
 779         * infrun.c (signal_stop, signal_print, signal_program)
 780         (signal_catch, signal_pass): Now arrays instead of pointers.
 781         (update_signals_program_target, do_target_resume)
 782         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 783         * linux-nat.c (linux_nat_target::pass_signals)
 784         (linux_nat_target::create_inferior, linux_nat_target::attach):
 785         Adjust.
 786         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 787         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 788         * procfs.c (procfs_target::pass_signals): Adjust.
 789         * record-full.c (record_full_target::resume): Adjust.
 790         * remote.c (remote_target::pass_signals)
 791         (remote_target::program_signals): Adjust.
 792         * target-debug.h (target_debug_print_signals): Now takes a
 793         gdb::array_view as parameter.  Adjust.
 794         * target.h (target_ops) <pass_signals, program_signals>: Replace
 795         pointer and length parameters with gdb::array_view.
 796         (target_pass_signals, target_program_signals): Likewise.
 797         * target-delegates.c: Regenerate.
 798
 799 2019-01-24  Pedro Alves  <palves@redhat.com>
 800
 801         * common/forward-scope-exit.h
 802         (forward_scope_exit::forward_scope_exit): Pass arguments to
 803         m_bind_function directly, instead of creating a std::bind and
 804         copying that.
 805
 806 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 807
 808         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 809         for static members.
 810         (pass_in_v_vfp_candidate): Likewise.
 811
 812 2019-01-23  Tom Tromey  <tom@tromey.com>
 813             Pedro Alves  <palves@redhat.com>
 814
 815         * regcache.c (class regcache_invalidator): Remove.
 816         (regcache::raw_write): Use make_scope_exit.
 817
 818 2019-01-23  Tom Tromey  <tom@tromey.com>
 819
 820         * ui-out.h (class ui_out_emit_type): Update comment.
 821
 822 2019-01-23  Tom Tromey  <tom@tromey.com>
 823
 824         * infrun.c (fetch_inferior_event): Update comment.
 825
 826 2019-01-23  Tom Tromey  <tom@tromey.com>
 827             Pedro Alves  <palves@redhat.com>
 828
 829         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 830         parameter.
 831         (fetch_inferior_event): Use SCOPE_EXIT.
 832
 833
 834 2019-01-23  Tom Tromey  <tom@tromey.com>
 835             Pedro Alves  <palves@redhat.com>
 836
 837         * infrun.c (disable_thread_events): Delete.
 838         (stop_all_threads): Use SCOPE_EXIT.
 839
 840 2019-01-23  Tom Tromey  <tom@tromey.com>
 841             Pedro Alves  <palves@redhat.com>
 842
 843         * symfile.c: Include forward-scope-exit.h.
 844         (clear_symtab_users_cleanup): Replace forward declaration with
 845         a FORWARD_SCOPE_EXIT.
 846         (syms_from_objfile_1): Use the forward_scope_exit and
 847         gdb::optional instead of cleanup_function.
 848         (reread_symbols): Use the forward_scope_exit instead of
 849         cleanup_function.
 850         (clear_symtab_users_cleanup): Remove function.
 851
 852 2019-01-23  Tom Tromey  <tom@tromey.com>
 853             Pedro Alves  <palves@redhat.com>
 854
 855         * linux-nat.c: Include scope-exit.h.
 856         (cleanup_target_stop): Remove.
 857         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 858         SCOPE_EXIT.
 859
 860 2019-01-23  Tom Tromey  <tom@tromey.com>
 861             Pedro Alves  <palves@redhat.com>
 862
 863         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 864         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 865
 866 2019-01-23  Tom Tromey  <tom@tromey.com>
 867             Andrew Burgess  <andrew.burgess@embecosm.com>
 868             Pedro Alves  <palves@redhat.com>
 869
 870         * infrun.c (fetch_inferior_event): Use scope_exit.
 871         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 872         * top.c (execute_command): Use scope_exit.
 873         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 874         * utils.c (do_bpstat_clear_actions_cleanup)
 875         (make_bpstat_clear_actions_cleanup): Remove.
 876
 877 2019-01-23  Tom Tromey  <tom@tromey.com>
 878             Pedro Alves  <palves@redhat.com>
 879
 880         * infrun.c: Include "common/scope-exit.h"
 881         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 882         (wait_for_inferior): Use SCOPE_EXIT.
 883         (fetch_inferior_event): Use scope_exit.
 884
 885 2019-01-23  Tom Tromey  <tom@tromey.com>
 886             Pedro Alves  <palves@redhat.com>
 887
 888         * breakpoint.c (create_breakpoint): Remove cleanup.
 889
 890 2019-01-23  Tom Tromey  <tom@tromey.com>
 891             Andrew Burgess  <andrew.burgess@embecosm.com>
 892             Pedro Alves  <palves@redhat.com>
 893
 894 2019-01-23  Pedro Alves  <palves@redhat.com>
 895
 896         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 897
 898 2019-01-23  Pedro Alves  <palves@redhat.com>
 899             Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * gdbthread.h: Include "common/forward-scope-exit.h".
 902         (scoped_finish_thread_state): Redefine custom class in terms of
 903         forward_scope_exit.
 904
 905 2019-01-23  Pedro Alves  <palves@redhat.com>
 906             Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * common/forward-scope-exit.h: New file.
 909
 910 2019-01-23  Pedro Alves  <palves@redhat.com>
 911             Andrew Burgess  <andrew.burgess@embecosm.com>
 912             Tom Tromey  <tom@tromey.com>
 913
 914         * common/scope-exit.h: New file.
 915
 916 2019-01-23  Pedro Alves  <palves@redhat.com>
 917
 918         * common/preprocessor.h (ESC): Rename to ...
 919         (ESC_PARENS): ... this.
 920         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 921         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 922
 923 2019-01-23  Tom Tromey  <tom@tromey.com>
 924
 925         * language.h (class scoped_switch_to_sym_language_if_auto):
 926         Initialize m_lang in both cases.
 927
 928 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 929
 930         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 931         with XCNEW.
 932
 933 2019-01-22  Tom Tromey  <tom@tromey.com>
 934
 935         * corelow.c: Do not include sys/file.h.
 936
 937 2019-01-22  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-wingeneral.h: Include gdb_curses.h.
 940
 941 2019-01-22  Tom Tromey  <tom@tromey.com>
 942
 943         * source-cache.h (class source_cache) <get_source_lines,
 944         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 945
 946 2019-01-22  Tom Tromey  <tom@tromey.com>
 947
 948         * remote-fileio.h (struct remote_target): Declare.
 949
 950 2019-01-22  Tom Tromey  <tom@tromey.com>
 951
 952         * python/py-arch.c: Do not include py-ref.h.
 953         * python/py-bpevent.c: Do not include py-ref.h.
 954         * python/py-cmd.c: Do not include py-ref.h.
 955         * python/py-continueevent.c: Do not include py-ref.h.
 956         * python/py-event.h: Do not include py-ref.h.
 957         * python/py-evtregistry.c: Do not include py-ref.h.
 958         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 959         * python/py-frame.c: Do not include py-ref.h.
 960         * python/py-framefilter.c: Do not include py-ref.h.
 961         * python/py-function.c: Do not include py-ref.h.
 962         * python/py-infevents.c: Do not include py-ref.h.
 963         * python/py-linetable.c: Do not include py-ref.h.
 964         * python/py-objfile.c: Do not include py-ref.h.
 965         * python/py-param.c: Do not include py-ref.h.
 966         * python/py-prettyprint.c: Do not include py-ref.h.
 967         * python/py-progspace.c: Do not include py-ref.h.
 968         * python/py-symbol.c: Do not include py-ref.h.
 969         * python/py-symtab.c: Do not include py-ref.h.
 970         * python/py-type.c: Do not include py-ref.h.
 971         * python/py-unwind.c: Do not include py-ref.h.
 972         * python/py-utils.c: Do not include py-ref.h.
 973         * python/py-value.c: Do not include py-ref.h.
 974         * python/py-varobj.c: Do not include py-ref.h.
 975         * python/py-xmethods.c: Do not include py-ref.h.
 976         * python/python.c: Do not include py-ref.h.
 977         * varobj.c: Do not include py-ref.h.
 978
 979 2019-01-22  Tom Tromey  <tom@tromey.com>
 980
 981         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 982         keyword for bcache.
 983
 984 2019-01-22  Tom Tromey  <tom@tromey.com>
 985
 986         * compile/compile-cplus-types.c: Remove a comment by #include.
 987
 988 2019-01-22  Tom Tromey  <tom@tromey.com>
 989
 990         * compile/gcc-c-plugin.h: Include compile-internal.h.
 991
 992 2019-01-22  Tom Tromey  <tom@tromey.com>
 993
 994         * stabsread.c (EXTERN): Do not define.
 995         (symnum, next_symbol_text_func, processing_gcc_compilation)
 996         (within_function, global_sym_chain, global_stabs)
 997         (previous_stab_code, this_object_header_files)
 998         (n_this_object_header_files)
 999         (n_allocated_this_object_header_files): Define.
1000         * stabsread.h (EXTERN): Never define.  Use "extern".
1001
1002 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1003
1004         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1005         history_value.
1006
1007 2019-01-21  Tom Tromey  <tom@tromey.com>
1008
1009         * ui-out.c: Fix includes.
1010         * tui/tui-source.c: Fix includes.
1011         * target.c: Fix includes.
1012         * remote.c: Fix includes.
1013         * regcache.c: Fix includes.
1014         * python/py-block.c: Fix includes.
1015         * printcmd.c: Fix includes.
1016         * or1k-tdep.c: Fix includes.
1017         * mi/mi-main.c: Fix includes.
1018         * m32r-tdep.c: Fix includes.
1019         * csky-tdep.c: Fix includes.
1020         * compile/compile-cplus-types.c: Fix includes.
1021         * cli/cli-interp.c: Fix includes.
1022
1023 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1026         for padding.
1027
1028 2019-01-16  Tom Tromey  <tom@tromey.com>
1029
1030         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1031         earlier.
1032         (struct objfile) <msymbols_range>: Move from top level.
1033         <msymbols>: New method.
1034         (class objfile_msymbols): Remove.
1035         * symtab.c (default_collect_symbol_completion_matches_break_on):
1036         Update.
1037         * symmisc.c (dump_msymbols): Update.
1038         * stabsread.c (scan_file_globals): Update.
1039         * objc-lang.c (info_selectors_command, info_classes_command)
1040         (find_methods): Update.
1041         * minsyms.c (find_solib_trampoline_target): Update.
1042         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1043         * coffread.c (coff_symfile_read): Update.
1044         * ada-lang.c (ada_lookup_simple_minsym)
1045         (ada_collect_symbol_completion_matches): Update.
1046
1047 2019-01-16  Tom Tromey  <tom@tromey.com>
1048
1049         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1050         type.  Remove no-argument constructor.
1051         <iterator::operator++>: Simplify.
1052         <begin>: Update.
1053         <end>: Use minimal_symbol_count.
1054
1055 2019-01-16  Tom Tromey  <tom@tromey.com>
1056
1057         * objfiles.h (struct objfile) <psymtabs>: New method.
1058         (class objfile_psymtabs): Remove.
1059         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1060         typedef.
1061         <range>: New method.
1062         (require_partial_symbols): Change return type.
1063         * psymtab.c (require_partial_symbols)
1064         (psym_expand_symtabs_matching): Update.
1065         * mdebugread.c (parse_partial_symbols): Update.
1066         * dbxread.c (dbx_end_psymtab): Update.
1067
1068 2019-01-15  Tom Tromey  <tom@tromey.com>
1069
1070         * symtab.c (lookup_objfile_from_block)
1071         (lookup_symbol_in_objfile_symtabs)
1072         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1073         (find_line_symtab, info_sources_command)
1074         (default_collect_symbol_completion_matches_break_on)
1075         (make_source_files_completion_list): Update.
1076         * symmisc.c (print_objfile_statistics, dump_objfile)
1077         (maintenance_print_symbols, maintenance_info_symtabs)
1078         (maintenance_check_symtabs, maintenance_info_line_tables):
1079         Update.
1080         * source.c (select_source_symtab)
1081         (forget_cached_source_info_for_objfile): Update.
1082         * objfiles.h (class objfile_compunits): Remove.
1083         (struct objfile) <compunits_range>: New typedef.
1084         (compunits): New method.
1085         * objfiles.c (objfile_relocate1): Update.
1086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1087         * maint.c (count_symtabs_and_blocks): Update.
1088         * linespec.c (iterate_over_all_matching_symtabs): Update.
1089         * cp-support.c (add_symbol_overload_list_qualified): Update.
1090         * coffread.c (coff_symtab_read): Update.
1091         * ada-lang.c (add_nonlocal_symbols)
1092         (ada_collect_symbol_completion_matches)
1093         (ada_add_global_exceptions): Update.
1094
1095 2019-01-15  Tom Tromey  <tom@tromey.com>
1096
1097         * progspace.h (program_space) <objfiles_safe_range>: New
1098         typedef.
1099         <objfiles_safe>: New method.
1100         * objfiles.h (class all_objfiles_safe): Remove.
1101         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1102         * jit.c (jit_inferior_exit_hook): Update.
1103
1104 2019-01-17  Tom Tromey  <tom@tromey.com>
1105
1106         * progspace.h (program_space) <objfiles_range>: New typedef.
1107         <objfiles>: New method.
1108         <objfiles_head>: Rename from objfiles.
1109         (object_files): Update.
1110         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1111         * guile/scm-pretty-print.c
1112         (ppscm_find_pretty_printer_from_objfiles): Update.
1113         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1114         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1115         Update.
1116         * python/py-progspace.c (pspy_get_objfiles): Update.
1117         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1118         Update.
1119         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1120         (objfpy_lookup_objfile_by_build_id): Update.
1121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1122         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1123         Update.
1124         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1125         (expand_symtab_containing_pc, lookup_objfile_from_block)
1126         (lookup_static_symbol, basic_lookup_transparent_type)
1127         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1128         (find_line_symtab, info_sources_command)
1129         (default_collect_symbol_completion_matches_break_on)
1130         (make_source_files_completion_list, find_main_name): Update.
1131         * symmisc.c (print_symbol_bcache_statistics)
1132         (print_objfile_statistics, maintenance_print_symbols)
1133         (maintenance_print_msymbols, maintenance_print_objfiles)
1134         (maintenance_info_symtabs, maintenance_check_symtabs)
1135         (maintenance_expand_symtabs, maintenance_info_line_tables):
1136         Update.
1137         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1138         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1139         (map_overlay_command, unmap_overlay_command)
1140         (simple_overlay_update, expand_symtabs_matching)
1141         (map_symbol_filenames): Update.
1142         * symfile-debug.c (set_debug_symfile): Update.
1143         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1144         Update.
1145         * source.c (select_source_symtab, forget_cached_source_info):
1146         Update.
1147         * solib.c (solib_read_symbols): Update.
1148         * solib-spu.c (append_ocl_sos): Update.
1149         * psymtab.c (maintenance_print_psymbols)
1150         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1151         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1152         * printcmd.c (info_symbol_command): Update.
1153         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1154         Update.
1155         * objfiles.h (class all_objfiles): Remove.
1156         * objfiles.c (have_partial_symbols, have_full_symbols)
1157         (have_minimal_symbols, qsort_cmp, update_section_map)
1158         (shared_objfile_contains_address_p)
1159         (default_iterate_over_objfiles_in_search_order): Update.
1160         * objc-lang.c (info_selectors_command, info_classes_command)
1161         (find_methods): Update.
1162         * minsyms.c (find_solib_trampoline_target): Update.
1163         * maint.c (maintenance_info_sections)
1164         (maintenance_translate_address, count_symtabs_and_blocks):
1165         Update.
1166         * main.c (captured_main_1): Update.
1167         * linux-thread-db.c (try_thread_db_load_from_pdir)
1168         (has_libpthread): Update.
1169         * linespec.c (iterate_over_all_matching_symtabs)
1170         (search_minsyms_for_name): Update.
1171         * jit.c (jit_find_objf_with_entry_addr): Update.
1172         * hppa-tdep.c (find_unwind_entry)
1173         (hppa_lookup_stub_minimal_symbol): Update.
1174         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1175         Update.
1176         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1177         (elf_gnu_ifunc_resolve_by_got): Update.
1178         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1179         * dwarf-index-write.c (save_gdb_index_command): Update.
1180         * cp-support.c (add_symbol_overload_list_qualified): Update.
1181         * breakpoint.c (create_overlay_event_breakpoint)
1182         (create_longjmp_master_breakpoint)
1183         (create_std_terminate_master_breakpoint)
1184         (create_exception_master_breakpoint): Update.
1185         * blockframe.c (find_pc_partial_function): Update.
1186         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1187         (ada_collect_symbol_completion_matches)
1188         (ada_add_global_exceptions): Update.
1189
1190 2019-01-17  Tom Tromey  <tom@tromey.com>
1191
1192         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1193         declare VEC.
1194         (solib_target_parse_libraries): Change return type.
1195         (library_list_start_segment, library_list_start_section)
1196         (library_list_end_library, library_list_start_library); Update.
1197         (solib_target_free_library_list): Remove.
1198         (solib_target_parse_libraries): Remove cleanup.  Change return
1199         type.
1200         (solib_target_current_sos): Update.
1201
1202 2019-01-17  Tom Tromey  <tromey@bapiya>
1203
1204         * valprint.c: Replace "the the" with "the".
1205         * symtab.c: Replace "the the" with "the".
1206         * solib.c: Replace "the the" with "the".
1207         * solib-dsbt.c: Replace "the the" with "the".
1208         * linespec.c: Replace "the the" with "the".
1209         * dwarf2loc.h: Replace "the the" with "the".
1210         * amd64-windows-tdep.c: Replace "the the" with "the".
1211         * aarch64-tdep.c: Replace "the the" with "the".
1212
1213 2019-01-16  Keith Seitz  <keiths@redhat.com>
1214
1215         PR gdb/23773
1216         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1217         <builder>: Rename to ..
1218         <m_builder>: ... this and make private.
1219         (dwarf2_cu::get_builder): New method.  Change all users of
1220         `builder' to use this method.
1221         (dwarf2_start_symtab): Move to ...
1222         (dwarf2_cu::start_symtab): ... here.  Update all callers
1223         (setup_type_unit_groups): Move to ...
1224         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1225         callers.
1226         (dwarf2_cu::reset_builder): New method.
1227         (process_full_compunit, process_full_type_unit): Use
1228         dwarf2_cu::reset_builder.
1229         (follow_die_offset): Record the ancestor CU if it is different
1230         from the followed DIE's CU.
1231         (follow_die_sig_1): Likewise.
1232
1233 2019-01-15  Tom Tromey  <tom@tromey.com>
1234
1235         * remote.c (class remote_state) <buf>: Now a char_vector.
1236         <buf_size>: Remove.
1237         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1238         parameter.
1239         (remote_target::getpkt_or_notif_sane_1)
1240         (remote_target::getpkt_sane)
1241         (remote_target::getpkt_or_notif_sane): Likewise.
1242         (class remote_target) <putpkt>: New overload.
1243         (remote_target::read_frame): Change type of "buf_p".  Remove
1244         sizeof_p parameter.
1245         (packet_ok): New overload.
1246         (packet_check_result): New overload.
1247         Update all uses.
1248
1249 2019-01-14  Tom Tromey  <tom@tromey.com>
1250
1251         * remote-notif.c (handle_notification, remote_notif_ack)
1252         (remote_notif_parse): Make "buf" const.
1253         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1254         const.
1255         (remote_notif_parse, remote_notif_ack, handle_notification):
1256         Likewise.
1257         * remote.c (remote_notif_stop_parse): Make "buf" const.
1258         (remote_target::remote_parse_stop_reply): Make "buf" const.
1259         (remote_notif_stop_ack): Make "buf" const.
1260
1261 2019-01-14  Tom Tromey  <tom@tromey.com>
1262
1263         * remote.c (remote_console_output): Make parameter const.
1264
1265 2019-01-14  Tom Tromey  <tom@tromey.com>
1266
1267         * target-debug.h (target_debug_print_signals): Constify.
1268         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1269         * procfs.c (procfs_target::pass_signals): Update.
1270         * linux-nat.c (linux_nat_target::pass_signals): Update.
1271         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1272         * target-delegates.c: Rebuild.
1273         * remote.c (remote_target::program_signals): Update.
1274         (remote_target::pass_signals): Update.
1275         * target.c (target_pass_signals): Constify argument.
1276         (target_program_signals): Likewise.
1277         * target.h (struct target_ops) <pass_signals, program_signals>:
1278         Constify argument.
1279         (target_pass_signals, target_program_signals): Constify argument.
1280
1281 2019-01-14  Tom Tromey  <tom@tromey.com>
1282
1283         PR tui/28819:
1284         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1285
1286 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1287
1288         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1289         field.
1290         * rs6000-tdep.c: Include reggroups.h.
1291         (IS_V_ALIAS_PSEUDOREG): Define.
1292         (rs6000_register_name): Return names for the "vX" aliases.
1293         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1294         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1295         aliases.  Call default_register_reggroup_p for all other
1296         pseudo-registers.
1297         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1298         New functions.
1299         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1300         Handle "vX" aliases.
1301         (v_alias_pseudo_register_collect): New function.
1302         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1303         (rs6000_gdbarch_init): Initialize "vX" aliases as
1304         pseudo-registers.  Restore registration of
1305         rs6000_pseudo_register_reggroup_p with
1306         set_tdesc_pseudo_register_reggroup_p.
1307
1308 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1309
1310         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1311         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1312         set_gdbarch_num_pseudo_regs.
1313
1314 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1315
1316         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1317         Remove arg prefixname, add do_set and do_show.
1318         Add member functions set_list and show_list.
1319         * cli/cli-style.c (class cli_style_option): Update accordingly.
1320         (style_set_list): Move to file scope.
1321         (style_show_list): Likewise.
1322         (set_style): Call help_list.
1323         (show_style): Call cmd_show_list.
1324         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1325         Update to use the new macro.
1326
1327 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1328
1329         * ada-lang.c (_initialize_ada_language): Expand the help text
1330         for the "catch exception" command.
1331
1332 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1333
1334         * symtab.c (matching_obj_sections): Initialize obj,
1335         declare it closer to its usage.
1336
1337 2019-01-10  Tom Tromey  <tom@tromey.com>
1338
1339         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1340         (basic_inf_threads_range): Remove.
1341         (inf_threads_range, inf_non_exited_threads_range)
1342         (safe_inf_threads_range): Use next_adapter.
1343
1344 2019-01-10  Keith Seitz  <keiths@redhat.com>
1345
1346         PR gdb/23712
1347         PR symtab/23010
1348         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1349         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1350
1351 2019-01-10  Keith Seitz  <keiths@redhat.com>
1352
1353         PR gdb/23712
1354         PR symtab/23010
1355         * dictionary.c (pending_to_vector): Remove.
1356         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1357         Remove _1 suffix, replacing functions of the same name.  Update
1358         all callers.
1359         (dict_create_hashed, dict_create_hashed_expandable)
1360         (dict_create_linear, dict_create_linear_expandable, dict_free)
1361         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1362         Make functions static.
1363
1364 2019-01-10  Keith Seitz  <keiths@redhat.com>
1365
1366         PR gdb/23712
1367         PR symtab/23010
1368         * dictionary.h (struct dictionary): Replace declaration with
1369         multidictionary.
1370         (dict_create_hashed, dict_create_hashed_expandable)
1371         (dict_create_linear, dict_create_linear_expandable)
1372         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1373         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1374         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1375         taking multidictionary argument.
1376         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1377         * block.h (struct block) <dict>: Change to multidictionary
1378         and rename `multidict'.
1379         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1380         symmisc.c: Update all dictionary references to multidictionary.
1381
1382 2019-01-10  Keith Seitz  <keiths@redhat.com>
1383
1384         PR gdb/23712
1385         PR symtab/23010
1386         * dictionary.c: Include unordered_map.
1387         (pending_to_vector): New function.
1388         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1389         Rewrite the non-"_1" functions to take vector instead
1390         of linked list.
1391         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1392         "new" _1 versions of the same name.
1393         (multidictionary): Define.
1394         (std::hash<enum language): New definition.
1395         (collate_pending_symbols_by_language, mdict_create_hashed)
1396         (mdict_create_hashed_expandable, mdict_create_linear)
1397         (mdict_create_linear_expandable, mdict_free)
1398         (find_language_dictionary, create_new_language_dictionary)
1399         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1400         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1401         (mdict_size, mdict_empty): New functions.
1402         * dictionary.h (mdict_iterator): Define.
1403
1404 2019-01-10  Pedro Alves  <palves@redhat.com>
1405
1406         * breakpoint.c (read_uploaded_action)
1407         (create_tracepoint_from_upload): Adjust to use
1408         gdb::unique_xmalloc_ptr.
1409         * ctf.c (ctf_write_uploaded_tp):
1410         (SET_ARRAY_FIELD): Use emplace_back.
1411         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1412         * tracefile-tfile.c (tfile_write_uploaded_tp):
1413         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1414         gdb::unique_xmalloc_ptr.
1415         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1416         at_string, cond_string, cmd_strings>: Replace char pointers
1417         with gdb::unique_xmalloc_ptr.
1418
1419 2019-01-10  Pedro Alves  <palves@redhat.com>
1420
1421         * solib-target.c (library_list_start_library): Don't xstrdup name.
1422
1423 2019-01-10  Pedro Alves  <palves@redhat.com>
1424
1425         * mdebugread.c (parse_partial_symbols): Use
1426         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1427
1428 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1429
1430         * linux-fork.c (scoped_switch_fork_info)
1431         <~scoped_switch_fork_info>: Fix incorrect variable name.
1432
1433 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * linux-fork.c (scoped_switch_fork_info)
1436         <scoped_switch_fork_info>: Make explicit.
1437         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1438
1439 2019-01-10  Tom Tromey  <tom@tromey.com>
1440
1441         * objfiles.h (objfile::reset_psymtabs): Update.
1442         * objfiles.c (objfile::objfile): Update.
1443         * psymtab.h (psymtab_storage::obstack): Update.
1444         (psymtab_storage::m_obstack): Use gdb::optional.
1445         (class psymtab_storage): Update comment.  Remove objfile
1446         parameter.
1447         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1448
1449 2019-01-10  Tom Tromey  <tom@tromey.com>
1450
1451         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1452         <free_psymtabs>: Now private.
1453         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1454         (allocate_psymtab): Use new method.
1455
1456 2019-01-10  Tom Tromey  <tom@tromey.com>
1457
1458         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1459         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1460         * mdebugread.c (parse_partial_symbols): Use
1461         allocate_dependencies.
1462         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1463         allocate_dependencies.
1464         (process_psymtab_comp_unit_reader)
1465         (build_type_psymtab_dependencies): Likewise.
1466         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1467
1468 2019-01-10  Tom Tromey  <tom@tromey.com>
1469
1470         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1471         PSYMBOL_SET_LANGUAGE.
1472         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1473
1474 2019-01-10  Tom Tromey  <tom@tromey.com>
1475
1476         * psymtab.h (psymtab_storage::obstack): New method.
1477         <m_obstack>: Rename from obstack; now private.
1478         * psymtab.c (psymtab_storage): Update.
1479         * dwarf2read.c (create_addrmap_from_index)
1480         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1481         Update.
1482
1483 2019-01-10  Tom Tromey  <tom@tromey.com>
1484
1485         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1486         * objfiles.h (objfile::reset_psymtabs): New method.
1487
1488 2019-01-10  Tom Tromey  <tom@tromey.com>
1489
1490         * symmisc.c (print_symbol_bcache_statistics): Update.
1491         (print_objfile_statistics): Update.
1492         * symfile.c (reread_symbols): Update.
1493         * psymtab.h (class psymtab_storage): New.
1494         * psymtab.c (psymtab_storage): New constructor.
1495         (~psymtab_storage): New destructor.
1496         (require_partial_symbols): Update.
1497         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1498         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1499         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1500         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1501         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1502         (start_psymtab_common, end_psymtab_common)
1503         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1504         (allocate_psymtab): Update.
1505         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1506         Update.
1507         (dump_psymtab_addrmap, maintenance_print_psymbols)
1508         (maintenance_check_psymtabs): Update.
1509         (class objfile_psymtabs): Move to objfiles.h.
1510         * psympriv.h (discard_psymtab): Now inline.
1511         (psymtab_discarder::psymtab_discarder): Update.
1512         (psymtab_discarder::~psymtab_discarder): Update.
1513         (ALL_OBJFILE_PSYMTABS): Rewrite.
1514         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1515         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1516         Remove fields.
1517         <partial_symtabs>: New field.
1518         (class objfile_psymtabs): Move from psymtab.h.  Update.
1519         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1520         psymbol_cache.
1521         (objfile::~objfile): Don't destroy psymbol_cache.
1522         * mdebugread.c (parse_partial_symbols): Update.
1523         * dwarf2read.c (create_addrmap_from_index)
1524         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1525         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1526         (add_partial_subprogram, dwarf2_ranges_read): Update.
1527         * dwarf-index-write.c (write_address_map)
1528         (write_one_signatured_type, recursively_write_psymbols)
1529         (class debug_names, class debug_names, write_psymtabs_to_index):
1530         Update.
1531
1532 2019-01-10  Tom Tromey  <tom@tromey.com>
1533
1534         * symtab.h (SYMBOL_SET_NAMES): Update.
1535         (symbol_set_names): Update.
1536         (MSYMBOL_SET_NAMES): Update.
1537         * symtab.c (symbol_set_names): Change argument to be an
1538         objfile_per_bfd_storage.
1539         * psymtab.c (add_psymbol_to_bcache): Update.
1540         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1541
1542 2019-01-10  Tom Tromey  <tom@tromey.com>
1543
1544         * symtab.c (create_demangled_names_hash): Change argument to be an
1545         objfile_per_bfd_storage.
1546         (symbol_set_names): Update.
1547
1548 2019-01-10  Tom Tromey  <tom@tromey.com>
1549
1550         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1551         init_psymbol_list.
1552         * psymtab.c (init_psymbol_list): Do nothing if already called.
1553         * psympriv.h (init_psymbol_list): Add comment.
1554         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1555         init_psymbol_list.
1556         * dbxread.c (dbx_symfile_read): Unconditionally call
1557         init_psymbol_list.
1558
1559 2019-01-10  Tom Tromey  <tom@tromey.com>
1560
1561         * xcoffread.c (scan_xcoff_symtab): Update.
1562         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1563         "where".
1564         * mdebugread.c (parse_partial_symbols)
1565         (handle_psymbol_enumerators): Update.
1566         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1567         * dbxread.c (read_dbx_symtab): Update.
1568         * psympriv.h (psymbol_placement): New enum.
1569         (add_psymbol_to_list): Update.
1570
1571 2019-01-10  Tom Tromey  <tom@tromey.com>
1572
1573         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1574         static_psymbols parameters.
1575         (scan_xcoff_symtab): Update.
1576         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1577         static_psymbols parameters.
1578         * psympriv.h (start_psymtab_common): Update.
1579         * mdebugread.c (parse_partial_symbols): Update.
1580         * dwarf2read.c (create_partial_symtab): Update.
1581         * dbxread.c (read_dbx_symtab): Update.
1582         (start_psymtab): Remove global_psymbols and static_psymbols
1583         parameters.
1584
1585 2019-01-10  Tom Tromey  <tom@tromey.com>
1586
1587         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1588         * psymtab.c (allocate_psymtab): Add comment.
1589         * psympriv.h (allocate_psymtab): Add comment.
1590         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1591         initializations.
1592         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1593
1594 2019-01-10  Tom Tromey  <tom@tromey.com>
1595
1596         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1597         Don't declare.
1598         * mipsread.c: Include mdebugread.h.
1599         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1600         Declare.
1601         * elfread.c: Include mdebugread.h.
1602
1603 2019-01-09  Tom Tromey  <tom@tromey.com>
1604
1605         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1606         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1607         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1608         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1609         (psym_lookup_symbol, psym_find_last_source_symtab)
1610         (psym_forget_cached_source_info, psym_print_stats)
1611         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1612         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1613         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1614         (psym_find_compunit_symtab_by_address)
1615         (maintenance_print_psymbols, maintenance_info_psymtabs)
1616         (maintenance_check_psymtabs): Use ranged for.
1617         * psymtab.h (class objfile_psymtabs): New.
1618         (require_partial_symbols): Return objfile_psymtabs.
1619         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1620
1621 2019-01-09  Tom Tromey  <tom@tromey.com>
1622
1623         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1624         (find_pc_mapped_section, list_overlays_command)
1625         (map_overlay_command, unmap_overlay_command)
1626         (simple_overlay_update): Use all_objfiles.
1627         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1628         * printcmd.c (info_symbol_command): Use all_objfiles.
1629         * objfiles.h (ALL_OBJSECTIONS): Remove.
1630         * maint.c (maintenance_translate_address): Use all_objfiles.
1631         * gcore.c (gcore_create_callback): Use all_objfiles.
1632         (objfile_find_memory_regions): Likewise.
1633
1634 2019-01-09  Tom Tromey  <tom@tromey.com>
1635
1636         * symtab.c (find_line_symtab, info_sources_command)
1637         (make_source_files_completion_list): Use objfile_compunits.
1638         * source.c (select_source_symtab): Use objfile_compunits.
1639         * objfiles.h (struct objfile): Update comment.
1640         (ALL_OBJFILES): Remove.
1641         (ALL_FILETABS): Remove.
1642         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1643         objfile_compunits.
1644
1645 2019-01-09  Tom Tromey  <tom@tromey.com>
1646
1647         * symmisc.c (print_objfile_statistics, dump_objfile)
1648         (maintenance_print_symbols): Use compunit_filetabs.
1649         * source.c (forget_cached_source_info_for_objfile): Use
1650         compunit_filetabs.
1651         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1652         (ALL_FILETABS): Use compunit_filetabs.
1653         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1654         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1655
1656 2019-01-09  Tom Tromey  <tom@tromey.com>
1657
1658         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1659         (compunit_filetabs): New.
1660         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1661         compunit_filetabs.
1662         (info_sources_command, make_source_files_completion_list): Remove
1663         declaration.
1664         * symmisc.c (print_objfile_statistics, dump_objfile)
1665         (maintenance_print_symbols): Remove declaration.
1666         (maintenance_info_symtabs): Use compunit_filetabs.
1667         (maintenance_info_line_tables): Likewise.
1668         * source.c (select_source_symtab): Change local variable name.
1669         (forget_cached_source_info_for_objfile): Remove declaration.
1670         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1671         * objfiles.c (objfile_relocate1): Remove declaration.
1672         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1673         declaration.
1674         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1675         * coffread.c (coff_symtab_read): Remove declaration.
1676         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1677         compunit_filetabs.
1678
1679 2019-01-09  Tom Tromey  <tom@tromey.com>
1680
1681         * symtab.c (lookup_objfile_from_block)
1682         (find_pc_sect_compunit_symtab, search_symbols)
1683         (default_collect_symbol_completion_matches_break_on): Use
1684         objfile_compunits.
1685         * objfiles.h (ALL_COMPUNITS): Remove.
1686         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1687         * cp-support.c (add_symbol_overload_list_qualified): Use
1688         objfile_compunits.
1689         * ada-lang.c (ada_collect_symbol_completion_matches)
1690         (ada_add_global_exceptions): Use objfile_compunits.
1691
1692 2019-01-09  Tom Tromey  <tom@tromey.com>
1693
1694         * source.c (select_source_symtab)
1695         (forget_cached_source_info_for_objfile): Remove declaration.
1696         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1697         declaration.
1698         * maint.c (count_symtabs_and_blocks): Remove declaration.
1699         * cp-support.c (add_symbol_overload_list_qualified): Remove
1700         declaration.
1701         * coffread.c (coff_symtab_read): Remove declaration.
1702         * symtab.c (lookup_symbol_in_objfile_symtabs)
1703         (basic_lookup_transparent_type_1): Use objfile_compunits.
1704         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1705         (info_sources_command, search_symbols)
1706         (default_collect_symbol_completion_matches_break_on)
1707         (make_source_files_completion_list): Remove declaration.
1708         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1709         (ada_collect_symbol_completion_matches)
1710         (ada_add_global_exceptions): Remove declaration.
1711         * linespec.c (iterate_over_all_matching_symtabs): Use
1712         objfile_compunits.
1713         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1714         (class objfile_compunits): New.
1715         (ALL_COMPUNITS): Use objfile_compunits.
1716         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1717         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1718         objfile_compunits.
1719         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1720
1721 2019-01-09  Tom Tromey  <tom@tromey.com>
1722
1723         * symtab.c (search_symbols)
1724         (default_collect_symbol_completion_matches_break_on): Use
1725         objfile_msymbols.
1726         * ada-lang.c (ada_lookup_simple_minsym)
1727         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1728         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1729         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1730         objfile_msymbols.
1731         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1732         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1733         * objc-lang.c (find_methods): Use objfile_msymbols.
1734         (info_selectors_command, info_classes_command): Likewise.
1735         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1736         * objfiles.h (class objfile_msymbols): New.
1737         (ALL_OBJFILE_MSYMBOLS): Remove.
1738         (ALL_MSYMBOLS): Remove.
1739
1740 2019-01-09  Tom Tromey  <tom@tromey.com>
1741
1742         * common/next-iterator.h (next_adapter): Add Iterator template
1743         parameter.
1744         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1745         (class all_objfiles_safe): New.
1746         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1747         * objfiles.c (put_objfile_before): Update comment.
1748         (add_separate_debug_objfile): Likewise.
1749         (free_all_objfiles): Use all_objfiles_safe.
1750         (objfile_purge_solibs): Likewise.
1751
1752 2019-01-09  Tom Tromey  <tom@tromey.com>
1753
1754         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1755         (expand_symtab_containing_pc, lookup_static_symbol)
1756         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1757         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1758         all_objfiles.
1759         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1760         * breakpoint.c (create_overlay_event_breakpoint)
1761         (create_longjmp_master_breakpoint)
1762         (create_std_terminate_master_breakpoint)
1763         (create_exception_master_breakpoint): Use all_objfiles.
1764         * linux-thread-db.c (try_thread_db_load_from_pdir)
1765         (has_libpthread): Use all_objfiles.
1766         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1767         * linespec.c (iterate_over_all_matching_symtabs)
1768         (search_minsyms_for_name): Use all_objfiles.
1769         * maint.c (maintenance_info_sections): Use all_objfiles.
1770         * main.c (captured_main_1): Use all_objfiles.
1771         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1772         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1773         * guile/scm-pretty-print.c
1774         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1775         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1776         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1777         (maintenance_print_msymbols): Use all_objfiles.
1778         * source.c (select_source_symtab): Use all_objfiles.
1779         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1780         * symfile.c (remove_symbol_file_command)
1781         (expand_symtabs_matching, map_symbol_filenames): Use
1782         all_objfiles.
1783         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1784         all_objfiles.
1785         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1786         * objc-lang.c (find_methods): Use all_objfiles.
1787         * objfiles.c (have_partial_symbols, have_full_symbols)
1788         (have_minimal_symbols, qsort_cmp)
1789         (default_iterate_over_objfiles_in_search_order): Use
1790         all_objfiles.
1791         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1792         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1793         (maintenance_check_psymtabs): Use all_objfiles.
1794         (ALL_PSYMTABS): Remove.
1795         * compile/compile-object-run.c (do_module_cleanup): Use
1796         all_objfiles.
1797         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1798         * cp-support.c (add_symbol_overload_list_qualified): Use
1799         all_objfiles.
1800         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1801         Use all_objfiles.
1802         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1803         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1804         all_objfiles.
1805         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1806         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1807         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1808         Uses all_objfiles.
1809         * solib.c (solib_read_symbols): Use all_objfiles
1810
1811 2019-01-09  Tom Tromey  <tom@tromey.com>
1812
1813         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1814         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1815         all_objfiles.
1816         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1817         * symmisc.c (print_symbol_bcache_statistics)
1818         (print_objfile_statistics, maintenance_print_objfiles)
1819         (maintenance_info_symtabs, maintenance_check_symtabs)
1820         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1821         all_objfiles.
1822         * source.c (forget_cached_source_info): Use all_objfiles.
1823         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1824         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1825         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1826         * objfiles.c (update_section_map): Use all_objfiles.
1827         (shared_objfile_contains_address_p): Likewise.
1828         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1829         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1830
1831 2019-01-09  Tom Tromey  <tom@tromey.com>
1832
1833         * common/next-iterator.h: New file.
1834         * objfiles.h (class all_objfiles): New.
1835         (struct objfile_iterator): New.
1836
1837 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1838
1839         * NEWS: Move the description of the changed "frame", "select-frame",
1840          and "info frame" commands to the Changed commands section.
1841
1842 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1843
1844         * gdbtypes.c (check_stub_method_group): Remove handling of old
1845         mangling schemes.
1846         * linespec.c (find_methods): Likewise.
1847         * stabsread.c (read_member_functions): Likewise.
1848         * valops.c (search_struct_method): Likewise.
1849         (value_struct_elt_for_reference): Likewise.
1850         * NEWS: Mention this change.
1851
1852 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1855         print_source_lines.
1856         * source.c (print_source_lines_base): Update line number check.
1857         (print_source_lines): New function.
1858         (source_lines_range::source_lines_range): New function.
1859         * source.h (class source_lines_range): New class.
1860         (print_source_lines): New declaration.
1861
1862 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1863
1864         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1865
1866 2019-01-08  Tom Tromey  <tom@tromey.com>
1867             Simon Marchi  <simon.marchi@ericsson.com>
1868
1869         PR gdb/24060
1870         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1871         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1872         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1873         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1874         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1875         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1876
1877 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * source.c (select_source_symtab): Move header comment to
1880         declaration in source.h.
1881         (forget_cached_source_info_for_objfile): Likewise.
1882         (forget_cached_source_info): Likewise.
1883         (identify_source_line): Likewise.
1884         * source.h (identify_source_line): Move declaration from symtab.h
1885         and add comment from source.c
1886         (print_source_lines): Likewise.
1887         (forget_cached_source_info_for_objfile): Likewise.
1888         (forget_cached_source_info): Likewise.
1889         (select_source_symtab): Likewise.
1890         (enum print_source_lines_flag): Move definition from symtab.h.
1891         * symtab.h (identify_source_line): Move declaration to source.h.
1892         (print_source_lines): Likewise.
1893         (forget_cached_source_info_for_objfile): Likewise.
1894         (forget_cached_source_info): Likewise.
1895         (select_source_symtab): Likewise.
1896         (enum print_source_lines_flag): Move definition to source.h.
1897         * tui/tui-hooks.c: Add 'source.h' include.
1898
1899 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1900
1901         * source.c (print_source_lines_base): Handle requests to print
1902         reverse line number sequences, and guard against empty lines
1903         string.
1904
1905 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * source.c (print_source_lines_base): Fix skip of '\r' if next
1908         character is '\n'.
1909
1910 2019-01-06  Tom Tromey  <tom@tromey.com>
1911
1912         * c-exp.y (struct c_parse_state) <macro_original_text,
1913         expansion_obstack>: New member.
1914         (macro_original_text, expansion_obstack): Remove globals.
1915         (scan_macro_expansion, scanning_macro_expansion)
1916         (finished_macro_expansion): Update.
1917         (scan_macro_cleanup): Remove.
1918         (yylex, c_parse): Update.
1919
1920 2019-01-06  Tom Tromey  <tom@tromey.com>
1921
1922         * c-exp.y (struct c_parse_state) <strings>: New member.
1923         (operator_stoken): Update.
1924
1925 2019-01-06  Tom Tromey  <tom@tromey.com>
1926
1927         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1928         (union type_stack_elt) <typelist_val>: Now a pointer to
1929         std::vector.
1930         (type_stack_cleanup): Don't declare.
1931         (push_typelist): Update.
1932         * parse.c (pop_typelist): Return a std::vector.
1933         (push_typelist): Take a std::vector.
1934         (follow_types): Update.  Do not free args.
1935         (type_stack_cleanup): Remove.
1936         * c-exp.y (struct c_parse_state): New.
1937         (cpstate): New global.
1938         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1939         (nonempty_typelist): Update.
1940         (func_mod): Create a new vector.
1941         (c_parse): Create a c_parse_state.
1942         (check_parameter_typelist): Do not delete params.
1943         (function_method): Update.  Do not delete type_list.
1944
1945 2019-01-06  Tom Tromey  <tom@tromey.com>
1946
1947         PR gdb/28155:
1948         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1949         check_typedef.
1950         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1951         (print_return_value): Likewise.
1952
1953 2019-01-05  Tom Tromey  <tom@tromey.com>
1954
1955         * contrib/cleanup_check.py: Remove.
1956         * contrib/gcc-with-excheck: Remove.
1957         * contrib/exsummary.py: Remove.
1958         * contrib/excheck.py: Remove.
1959
1960 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1961
1962         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1963         NULL. Initialize tpprev to NULL instead of assigning it
1964         to NULL on the next statement.
1965         * windows-nat.c (windows_delete_thread): Remove check for
1966         main_thread_id before printing thread exit notifications.
1967         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1968         Remove thread ID check against main_thread_id.
1969         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1970         windows_delete_thread.
1971         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1972
1973 2019-01-04  Tom Tromey  <tom@tromey.com>
1974
1975         * compile/compile.c (_initialize_compile): Use upper case for
1976         metasyntactic variables.
1977         * symmisc.c (_initialize_symmisc): Use upper case for
1978         metasyntactic variables.
1979         * psymtab.c (_initialize_psymtab): Use upper case for
1980         metasyntactic variables.
1981         * demangle.c (demangle_command): Use upper case for metasyntactic
1982         variables.
1983         (_initialize_demangler): Likewise.
1984         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1985         variables.
1986
1987 2019-01-03  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1990
1991 2019-01-03  Tom Tromey  <tom@tromey.com>
1992
1993         * python/py-symtab.c (salpy_str): Update.
1994         (struct salpy_sal_object) <symtab>: Now a PyObject.
1995         (salpy_dealloc): Update.
1996         (del_objfile_sal): Use gdbpy_ref.
1997
1998 2019-01-03  Tom Tromey  <tom@tromey.com>
1999
2000         * python/py-type.c (convert_field): Use new_reference.  Return
2001         gdbpy_ref.
2002         (make_fielditem): Return gdbpy_ref.
2003         (typy_fields): Update.
2004         (typy_getitem): Update.
2005         (field_name): Return gdbpy_ref.  Use new_reference.
2006         (typy_iterator_iternext): Update.
2007
2008 2019-01-03  Tom Tromey  <tom@tromey.com>
2009
2010         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2011
2012 2019-01-03  Tom Tromey  <tom@tromey.com>
2013
2014         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2015         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2016         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2017         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2018         (pspy_set_type_printers): Likewise.
2019         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2020         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2021         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2022         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2023         (objfpy_set_type_printers): Likewise.
2024
2025 2019-01-03  Tom Tromey  <tom@tromey.com>
2026
2027         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2028         (gdbpy_print_stack): Use gdbpy_err_fetch.
2029         * python/python-internal.h (class gdbpy_err_fetch): New class.
2030         (class gdbpy_enter) <m_error_type, m_error_value,
2031         m_error_traceback>: Remove.
2032         <m_error>: New member.
2033         (gdbpy_exception_to_string): Don't declare.
2034         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2035         * python/py-value.c (convert_value_from_python): Use
2036         gdbpy_err_fetch.
2037         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2038         gdbpy_exception_to_string.
2039         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2040         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2041         gdbpy_err_fetch.
2042
2043 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * linux-nat.c (delete_lwp_cleanup): Delete.
2046         (struct lwp_deleter): New struct.
2047         (lwp_info_up): New typedef.
2048         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2049         lwp_info_up.
2050
2051 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * linux-fork.c (class scoped_switch_fork_info): New class.
2054         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2055
2056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * valops.c (find_overload_match): Remove use of null_cleanup, and
2059         calls to do_cleanups.
2060
2061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2062
2063         * compile/compile-cplus-types.c
2064         (compile_cplus_instance::decl_name): Handle changes to
2065         cp_func_name.
2066         * cp-support.c (cp_func_name): Update header comment, update
2067         return type.
2068         * cp-support.h (cp_func_name): Update return type in declaration.
2069         * valops.c (find_overload_match): Move temp_func local to top
2070         level of function and change its type.  Use temp_func to hold and
2071         delete temporary string obtained from cp_func_name.
2072
2073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2074
2075         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2076         gdb::char_vector, remove cleanup, and update uses of `msg`.
2077
2078 2019-01-03  Jim Wilson  <jimw@sifive.com>
2079
2080         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2081
2082 2019-01-02  Tom Tromey  <tom@tromey.com>
2083
2084         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2085         (tdesc_parse_xml): Remove cleanups.
2086         * target-descriptions.h (make_cleanup_free_target_description):
2087         Don't declare.
2088         (target_desc_deleter): New struct.
2089         (target_desc_up): New typedef.
2090         * target-descriptions.c (target_desc_deleter::operator()): Rename
2091         from free_target_description.
2092         (make_cleanup_free_target_description): Remove.
2093
2094 2019-01-02  Tom Tromey  <tom@tromey.com>
2095
2096         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2097         constructor, destructor.
2098         (linespec_parser): Remove typedef.
2099         (~linespec_parser): Rename from linespec_parser_delete.
2100         (linespec_lex_to_end, linespec_complete_label)
2101         (linespec_complete): Update.
2102         (decode_line_full): Remove cleanups.
2103         (decode_line_1): Update.
2104
2105 2019-01-02  Tom Tromey  <tom@tromey.com>
2106
2107         * python/python-internal.h (inferior_to_inferior_object): Change
2108         return type.
2109         * python/py-exitedevent.c (create_exited_event_object): Update.
2110         * python/py-inferior.c (inferior_to_inferior_object): Return
2111         gdbpy_ref.
2112         (python_new_inferior, python_inferior_deleted)
2113         (thread_to_thread_object, delete_thread_object)
2114         (build_inferior_list, gdbpy_selected_inferior): Update.
2115         * python/py-infthread.c (create_thread_object): Update.  Also fail
2116         if inferior_to_inferior_object fails.
2117
2118 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2119
2120         * inferior.h (class inferior) <displaced_step_state>: New field.
2121         * infrun.h (struct displaced_step_state): Move here from
2122         infrun.c.  Initialize fields, add constructor.
2123         <inf>: Remove field.
2124         <reset>: New method.
2125         * infrun.c (struct displaced_step_inferior_state): Move to
2126         infrun.h.
2127         (displaced_step_inferior_states): Remove.
2128         (get_displaced_stepping_state): Adust.
2129         (displaced_step_in_progress_any_inferior): Adjust.
2130         (displaced_step_in_progress_thread): Adjust.
2131         (displaced_step_in_progress): Adjust.
2132         (add_displaced_stepping_state): Remove.
2133         (get_displaced_step_closure_by_addr): Adjust.
2134         (remove_displaced_stepping_state): Remove.
2135         (infrun_inferior_exit): Call displaced_step_state.reset.
2136         (use_displaced_stepping): Don't check for NULL.
2137         (displaced_step_prepare_throw): Call
2138         get_displaced_stepping_state.
2139         (displaced_step_fixup): Don't check for NULL.
2140         (prepare_for_detach): Don't check for NULL.
2141
2142 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2143
2144         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2145          in case of call that did not complete.
2146
2147 2019-01-02  Andrey Utkin  <autkin@undo.io>
2148
2149         * symfile.c (find_separate_debug_file): Fix search of debug files for
2150         remote debuggee.
2151
2152 2019-01-02  Tom Tromey  <tom@tromey.com>
2153
2154         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2155         indentation.
2156         * python/py-frame.c (frapy_older): Remove cast.
2157         (frapy_newer): Likewise.
2158         * python/py-breakpoint.c (local_setattro): Remove cast.
2159         * python/py-arch.c (archpy_name): Remove local variable.
2160         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2161
2162 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2163
2164         * unittests/basic_string_view/element_access/char/empty.cc:
2165         Fix year range in copyright header.
2166
2167 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2168
2169         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2170         Delete.
2171         <operator==>: Update with for removed field.
2172         <hash>: Likewise.
2173         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2174         <isa_features>: ...this.
2175         <abi_features>: New field.
2176         (riscv_isa_flen): Update comment.
2177         (riscv_abi_xlen): New declaration.
2178         (riscv_abi_flen): New declaration.
2179         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2180         isa_features.
2181         (riscv_abi_xlen): New function.
2182         (riscv_isa_flen): Update to get answer from isa_features.
2183         (riscv_abi_flen): New function.
2184         (riscv_has_fp_abi): Update to get answer from abi_features.
2185         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2186         xlen and flen.
2187         (riscv_call_info) <xlen, flen>: Update comment.
2188         (riscv_call_arg_struct): Remove invalid assertions
2189         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2190         is removed.
2191         (riscv_gdbarch_init): Gather isa features and abi features
2192         separately, ensure both match on the gdbarch when reusing an old
2193         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2194         a target with 64-bit float hardware.
2195
2196 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2197
2198         * source.c (search_command_helper): Stop reverse search
2199         when line 1 has been searched.
2200
2201 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2202
2203         * record-full.c (record_full_base_target::close): Rewrite
2204         record_full_core_buf_list free logic.
2205
2206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2207
2208         * break-catch-syscall.c (print_one_catch_syscall): xfree
2209         the last text.
2210
2211 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2212
2213         * top.c (print_gdb_version): Update Copyright year in version
2214         message.
2215
2216 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2217
2218         Update copyright year range in all GDB files.
2219
2220 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2221
2222         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2223
2224 For older changes see ChangeLog-2018.
2225 \f
2226 Local Variables:
2227 mode: change-log
2228 left-margin: 8
2229 fill-column: 74
2230 version-control: never
2231 coding: utf-8
2232 End:
2233