gdb/ChangeLog

   1 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * NEWS: Mention dictionary access on blocks.
   4         * python/py-block.c (blpy_getitem): New function.
   5         (block_object_as_mapping): New struct.
   6         (block_object_type): Use new struct for tp_as_mapping field.
   7
   8 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * objfiles.h (objfile): Add a comment describing partial symbols.
  11
  12 2019-08-05  Tom Tromey  <tromey@adacore.com>
  13
  14         * compile/compile.c (_initialize_compile): Use _(), not N_().
  15         * thread.c (_initialize_thread): Use _(), not N_().
  16         * stack.c (_initialize_stack): Use _(), not N_().
  17         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  18
  19 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * dwarf2read.c (struct dw2_symtab_iterator):
  22         <want_specific_block>: Remove.
  23         <block_index>: Change type to gdb::optional.
  24         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  25         change type of BLOCK_INDEX parameter to gdb::optional.
  26         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  27         (dw2_lookup_symbol): Don't pass argument for
  28         WANT_SPECIFIC_BLOCK.
  29         (dw2_expand_symtabs_for_function): Don't pass argument for
  30         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  31         (class dw2_debug_names_iterator)
  32         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  33         parameter, change BLOCK_INDEX type to gdb::optional.
  34         <m_want_specific_block>: Remove.
  35         <m_block_index>: Change type to gdb::optional.
  36         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  37         gdb::optional.  Re-write in function of gdb::optional.
  38         (dw2_debug_names_lookup_symbol): Don't pass argument for
  39         WANT_SPECIFIC_BLOCK.
  40         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  41         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  42         BLOCK_INDEX.
  43
  44 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  45
  46         * NEWS: Mention changes to "info sources" command.
  47
  48 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  49
  50         * symtab.c (filename_partial_match_opts): New struct type.
  51         (struct output_source_filename_data): New members
  52         regexp, c_regexp, partial_match.
  53         (output_source_filename): Use new members to decide to print file.
  54         (info_sources_option_defs): New variable.
  55         (make_info_sources_options_def_group, print_info_sources_header,
  56         info_sources_command_completer):
  57         New functions.
  58         (info_sources_command): Read new optional arguments.
  59         (_initialize_symtab): Update info sources help.
  60
  61 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  62
  63         * ada-lang.c (exception_support_info_v0): Renamed from...
  64         (default_exception_support_info): ... this.  Create new
  65         definition for v1.
  66         (ada_has_this_exception_support): Look up catch_handlers_sym.
  67         (ada_exception_support_info_sniffer): Try v0 after default.
  68
  69 2019-08-01  Tom Tromey  <tromey@adacore.com>
  70
  71         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  72         gdbarch.h.
  73
  74 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * s12z-tdep.c: Fix include path for s12z-opc.h.
  77
  78 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * NEWS: Require GNU make 3.82.
  81
  82 2019-07-16  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  85         declare.
  86
  87 2019-07-30  Tom Tromey  <tromey@adacore.com>
  88
  89         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  90
  91 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  92
  93         * printcmd.c (print_address_symbolic): Print negative offsets.
  94         (build_address_symbolic): Force signed arithmetic when computing
  95         offset.
  96
  97 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  98
  99         PR/24474: Add a function to lookup static variables.
 100         * NEWS: Mention this new function.
 101         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 102         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 103         * python/python.c (python_GdbMethods): Add new function.
 104
 105 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 106
 107         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 108         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 109         (objfpy_lookup_static_symbol): New function.
 110         (objfile_object_methods): Add new functions.
 111
 112 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 113
 114         * NEWS: Mention 'set|show print frame-info'.  Mention new
 115         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 116         backtrace argument.  Mention that python frame filtering code
 117         is now consistent with what 'backtrace' command prints.
 118
 119 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 120
 121         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 122         comments.
 123         (print_frame_info_auto, print_frame_info_source_line,
 124         print_frame_info_location, print_frame_info_source_and_location,
 125         print_frame_info_location_and_address, print_frame_info_short_location):
 126         New declarations.
 127         (struct frame_print_options): New member print_frame_info.
 128         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 129         * stack.h (get_user_print_what_frame_info): New declaration.
 130         (frame_show_address): New declaration.
 131         * stack.c (print_frame_arguments_choices): New value 'presence'.
 132         (print_frame_info_auto, print_frame_info_source_line,
 133         print_frame_info_location, print_frame_info_source_and_location,
 134         print_frame_info_location_and_address, print_frame_info_short_location,
 135         print_frame_info_choices, print_frame_info_print_what): New definitions.
 136         (print_frame_args): Only print dots for args if print frame-arguments
 137         is 'presence'.
 138         (frame_print_option_defs): New element for "frame-info".
 139         (get_user_print_what_frame_info): New function.
 140         (frame_show_address): Make non static.  Move comment to stack.h.
 141         (print_frame_info_to_print_what): New function.
 142         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 143         to decide what to print.
 144         (backtrace_command_1): Handle the new print_frame_arguments_presence
 145         value.
 146         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 147         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 148         (py_print_frame): In non-mi mode, use LOCATION as default for
 149         print_what, similarly to frame information printed directly by
 150         backtrace command. Handle frame-info user option in non MI mode.
 151
 152 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 153
 154         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 155         Add case for debugging 32-bit target on 64-bit host.  Revise
 156         comment.
 157
 158 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 159
 160         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 161         instead of find_function_entry_range_from_pc.
 162
 163 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 164
 165         * stack.c (find_frame_funname): Remove code which preferred
 166         minsym over symtab sym in "certain pathological cases".
 167
 168         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 169         parameter.  Change type of "do_demangle" to bool.
 170         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 171         Pass suitable "prefer_sym_over_minsym" flag to
 172         build_address_symbolic().  Don't output "+" for negative offsets.
 173         * printcmd.c (print_address_symbolic): Update invocation of
 174         build_address_symbolic to include a "prefer_sym_over_minsym"
 175         flag.
 176         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 177         Restrict cases in which use of minimal symbol is preferred to that
 178         of a found symbol.  Update comments.
 179
 180         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 181         for entry pc when entry pc is out of range for that FDE.
 182
 183 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 184
 185         PR gdb/24839:
 186         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 187         type.
 188
 189 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 190
 191         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 192         this function's Python signature.
 193
 194
 195 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 196
 197         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 198         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 199         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 200         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 201         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 202
 203
 204 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 205
 206         * h8300-tdep.c (h8300_register_name_common): New.
 207         h8300_register_name): Use h8300_register_name_common.
 208         (h8300s_register_name): Likewise.
 209         (h8300sx_register_name): Likewise.
 210         (h8300h_register_nam): New.
 211         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 212
 213
 214 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 215
 216         * arm-tdep.c (arm_skip_cmse_entry): New function.
 217         (arm_is_sgstubs_section): New function.
 218         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 219
 220 2019-07-22  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 223         Don't self-assign.
 224
 225 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 228         type_print.
 229
 230 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 233         so that GDB doesn't match any msymbols when searching in the
 234         TYPES_DOMAIN.
 235         (print_symbol_info): Print using typedef_print or type_print based
 236         on the type of the symbol.  Add updated FIXME comment moved from...
 237         (_initialize_symtab): ... move and update FIXME comment to above.
 238
 239 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 240
 241         * NEWS: Mention adding -q option to "info types".
 242         * symtab.c (struct info_types_options): New struct.
 243         (info_types_options_defs): New variable.
 244         (make_info_types_options_def_group): New function.
 245         (info_types_command): Use gdb::option framework to parse options.
 246         (info_types_command_completer): New function.
 247         (_initialize_symtab): Extend the help text on "info types" and
 248         register command completer.
 249
 250 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 251
 252         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 253         (lookup_symbol_in_objfile): Change int to block_enum and add a
 254         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 255
 256 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 257
 258         * MAINTAINERS (Write After Approval): Add self.
 259
 260 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 263         instruction to the dummy code region.
 264
 265 2019-07-19  Tom Tromey  <tromey@adacore.com>
 266
 267         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 268         (ARGSUSED, PARAMS, __func__): Remove rules.
 269
 270 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 271
 272         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 273         * features/arm/arm-with-iwmmxt.c: Remove.
 274         * features/arm/arm-with-iwmmxt.xml: Remove.
 275         * features/arm/arm-with-m-fpa-layout.c: Remove.
 276         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 277         * features/arm/arm-with-m-vfp-d16.c: Remove.
 278         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 279         * features/arm/arm-with-m.c: Remove.
 280         * features/arm/arm-with-m.xml: Remove.
 281         * features/arm/arm-with-neon.c: Remove.
 282         * features/arm/arm-with-neon.xml: Remove.
 283         * features/arm/arm-with-vfpv2.c: Remove.
 284         * features/arm/arm-with-vfpv2.xml: Remove.
 285         * features/arm/arm-with-vfpv3.c: Remove.
 286         * features/arm/arm-with-vfpv3.xml: Remove.
 287
 288 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 289
 290         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 291
 292 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * arch/aarch32.c (aarch32_create_target_description): Create
 295         target descriptions using features.
 296         * arch/arm.c (arm_create_target_description)
 297         (arm_create_mprofile_target_description): Likewise.
 298         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 299
 300 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 301
 302         * Makefile.in: Add new files.
 303         * aarch32-tdep.c: New file.
 304         * aarch32-tdep.h: New file.
 305         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 306         Call aarch32_read_description.
 307         * arch/aarch32.c: New file.
 308         * arch/aarch32.h: New file.
 309         * arch/arm.c (arm_create_target_description)
 310         (arm_create_mprofile_target_description): New function.
 311         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 312         (arm_create_target_description)
 313         (arm_create_mprofile_target_description): New declaration.
 314         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 315         read_description functions.
 316         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 317         Likewise.
 318         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 319         * arm-tdep.c (tdesc_arm_list): New variable.
 320         (arm_register_g_packet_guesses): Call create description functions.
 321         (arm_read_description) (arm_read_mprofile_description): New
 322         function.
 323         * arm-tdep.h (arm_read_description)
 324         (arm_read_mprofile_description): Add declaration.
 325         * configure.tgt: Add new files.
 326
 327 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 328
 329         * top.c (new_ui_command): Open specified terminal just once.
 330
 331 2019-07-18  Tom Tromey  <tromey@adacore.com>
 332
 333         * symtab.c (main_name): Constify return type.
 334         * symfile.c (set_initial_language): Update.
 335         * symtab.h (main_name): Constify return type.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-winsource.c (tui_update_source_window)
 340         (tui_update_source_window_as_is)
 341         (tui_update_source_windows_with_line): Remove return.
 342         * tui/tui-disasm.c (tui_show_disassem)
 343         (tui_show_disassem_and_update_source): Remove return.
 344         * tui/tui.c (tui_reset): Remove return.
 345         * tui/tui-wingeneral.c
 346         (tui_check_and_display_highlight_if_needed): Remove return.
 347
 348 2019-07-17  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-winsource.h (struct tui_exec_info_window)
 355         (struct tui_source_window_base): Move from tui-data.h.
 356         * tui/tui-winsource.c: Move many method definitions from
 357         elsewhere.  Remove "structuring" comments.
 358         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 359         (tui_source_window_base::refresh_window): Move to
 360         tui-winsource.c.
 361         * tui/tui-win.c (tui_source_window_base::refresh_all)
 362         (tui_source_window_base::update_tab_width)
 363         (tui_source_window_base::set_new_height)
 364         (tui_source_window_base::do_make_visible_with_new_height): Move to
 365         tui-winsource.c.
 366         * tui/tui-source.h: Update.
 367         * tui/tui-source.c (tui_source_window_base::reset): Move to
 368         tui-winsource.c.
 369         * tui/tui-disasm.h: Update.
 370         * tui/tui-data.h (struct tui_exec_info_window): Move to
 371         tui-winsource.h.
 372         (struct tui_source_window_base): Likewise.
 373         * tui/tui-data.c (tui_source_window_base::clear_detail)
 374         (tui_source_window_base, ~tui_source_window_base): Move to
 375         tui-winsource.c.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-win.c (tui_resize_all)
 380         (tui_source_window_base::update_tab_width)
 381         (tui_adjust_win_heights): Update.
 382         (tui_win_info::make_invisible_and_set_new_height): Rename from
 383         make_invisible_and_set_new_height.
 384         * tui/tui-data.h (struct tui_win_info)
 385         <make_invisible_and_set_new_height>: New method.
 386
 387 2019-07-17  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui.c: Update.
 390         * tui/tui-source.h (struct tui_source_window): Move from
 391         tui-data.h.
 392         * tui/tui-layout.c: Update.
 393         * tui/tui-disasm.c: Update.
 394         * tui/tui-data.h (struct tui_source_window): Move to
 395         tui-source.h.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 400         tui-data.h.
 401         * tui/tui-data.h (struct tui_disasm_window): Move to
 402         tui-disasm.h.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-regs.h (struct tui_data_item_window): Move from
 407         tui-data.h.
 408         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 409         * tui/tui-data.h (struct tui_data_item_window): Move to
 410         tui-regs.h.
 411         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui.c: Update.
 416         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 417         (tui_cmd_window::max_height): Move to tui-command.c.
 418         * tui/tui-layout.c: Update.
 419         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 420         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 421         tui-command.c.
 422         * tui/tui-command.h (struct tui_cmd_window): Move from
 423         tui-data.h.
 424         * tui/tui-command.c: Remove "structuring" comments.
 425         (tui_cmd_window::clear_detail)
 426         (tui_cmd_window::do_make_visible_with_new_height)
 427         (tui_cmd_window::max_height): Move from elsewhere.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 432         Now static.
 433         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 434         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 435
 436 2019-07-17  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui.c: Update.
 439         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 440         tui-regs.c.
 441         * tui/tui-windata.h: Remove file.
 442         * tui/tui-windata.c: Remove file.
 443         * tui/tui-win.c (tui_data_window::set_new_height)
 444         (tui_data_window::do_make_visible_with_new_height): Move to
 445         tui-regs.c.
 446         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 447         * tui/tui-regs.c: Remove "structuring" comments.
 448         (tui_data_window::first_data_item_displayed)
 449         (tui_data_window::delete_data_content_windows)
 450         (tui_data_window::erase_data_content)
 451         (tui_data_window::display_all_data)
 452         (tui_data_window::refresh_all)
 453         (tui_data_window::do_scroll_vertical)
 454         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 455         (tui_data_window::do_make_visible_with_new_height)
 456         (tui_data_window::refresh_window): Move from elsewhere.
 457         (_initialize_tui_regs): Move to end of file.
 458         * tui/tui-layout.c: Update.
 459         * tui/tui-hooks.c: Update.
 460         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 461         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 462         tui-regs.c.
 463         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 468         seen.
 469
 470 2019-07-17  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-win.c (tui_source_window_base::set_new_height)
 473         (tui_source_window_base::do_make_visible_with_new_height): Use
 474         m_has_locator field directly.
 475         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 476         method.
 477         (struct tui_source_window_base) <has_locator>: Likewise.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 482         Don't declare.
 483         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 484         Remove.
 485         * tui/tui-win.c (tui_source_window_base::set_new_height)
 486         (tui_source_window_base::set_new_height)
 487         (make_invisible_and_set_new_height)
 488         (tui_source_window_base::do_make_visible_with_new_height)
 489         (tui_source_window_base::do_make_visible_with_new_height):
 490         Update.
 491         * tui/tui-layout.c (show_source_disasm_command, show_data)
 492         (show_source_or_disasm_and_command): Update.
 493         * tui/tui-layout.c (show_layout): Update.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-layout.c (make_data_window): Remove.
 498         (show_data): Unify creation and re-initialization cases.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-layout.c (make_source_window, make_disasm_window):
 503         Remove.
 504         (show_data): Unify creation and re-initialization cases.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-layout.c (make_command_window): Remove.
 509         (show_source_disasm_command, show_source_or_disasm_and_command):
 510         Unify creation and re-initialization cases.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 515         creation and re-initialization cases.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-regs.c (tui_get_register): Return void.
 520
 521 2019-07-17  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 524         Simplify.
 525
 526 2019-07-17  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 529         resetting.
 530
 531 2019-07-17  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 534         * tui/tui-regs.c (tui_reg_layout): New function.
 535         (tui_show_registers, tui_reg_command): Use it.
 536         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 537         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 538         parameters.
 539         (tui_layout_command): Remove.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-layout.h (tui/tui-layout): Return void.
 544         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-layout.c (show_source_disasm_command, show_data):
 549         Update.
 550         (reset_locator): Remove.
 551         (show_source_or_disasm_and_command): Update.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-source.c (tui_source_window_base::reset): Remove
 556         win_type parameter.
 557         * tui/tui-layout.c (make_command_window, make_source_window)
 558         (make_disasm_window, make_data_window)
 559         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 560         (reset_locator, show_source_or_disasm_and_command): Update.
 561         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 562         win_type parameter.
 563         (struct tui_source_window_base) <reset>: Likewise.
 564
 565 2019-07-17  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-layout.c (show_source_disasm_command): Use
 568         reset_locator.
 569         (reset_locator): New function.
 570         (init_and_make_win): Remove.
 571         (show_source_or_disasm_and_command): Use reset_locator.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 576         condition.
 577         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 578         Remove condition.
 579         * tui/tui-source.c (tui_source_window_base::reset): New method.
 580         * tui/tui-layout.c (make_command_window): Don't call
 581         init_and_make_win.
 582         (make_source_window, make_disasm_window): Don't call
 583         make_source_or_disasm_window.
 584         (make_data_window): Don't call init_and_make_win.  Change calling
 585         convention.
 586         (show_source_disasm_command, show_data): Simplify.
 587         (make_source_or_disasm_window): Remove.
 588         (show_source_or_disasm_and_command): Simplify.
 589         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 590         (struct tui_source_window_base) <reset>: Likewise.
 591         <execution_info>: Remove initializer.
 592         * tui/tui-data.c (tui_source_window_base): Initialize
 593         execution_info.
 594
 595 2019-07-17  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 598         variable.
 599
 600 2019-07-17  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui.c (tui_rl_other_window): Update.
 603         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 604         superclass method first.  Always iterate over regs_content.
 605         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 606         method.
 607         * tui/tui-win.c (tui_set_focus_command): Update.
 608
 609 2019-07-17  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-win.c (tui_set_focus_command): Rename from
 612         tui_set_focus.  Call tui_enable.
 613         (tui_set_focus_command): Remove.
 614
 615 2019-07-17  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 618         refresh_window.
 619         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 620         touchwin.
 621         (tui_data_window::refresh_window): Call refresh_window on data
 622         items.  Always call superclass refresh_window.
 623         (tui_win_info::refresh): Remove.
 624         (tui_source_window_base::refresh_window): Update.
 625         (tui_refresh_all): Update.
 626         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 627         refresh_window.
 628         (show_source_or_disasm_and_command): Likewise.
 629         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 630         (struct tui_source_window_base) <refresh>: Likewise.
 631
 632 2019-07-17  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-winsource.c (tui_clear_source_content)
 635         (tui_show_source_content): Update.
 636         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 637         whether content is empty.
 638         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 639         Remove.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 644         window's contents.
 645         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 646         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 647
 648 2019-07-17  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 651         (struct tui_data_item_window): Update.
 652
 653 2019-07-17  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 656         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 657         defines.
 658
 659 2019-07-17  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-winsource.h (tui_erase_source_content)
 662         (tui_clear_source_content): Remove "display_prompt" parameter.
 663         * tui/tui-winsource.c (tui_update_source_window_as_is)
 664         (tui_update_source_windows_with_addr): Update.
 665         (tui_clear_source_content): Remove "display_prompt" parameter.
 666         (tui_erase_source_content): Likewise.  Simplify.
 667         (tui_show_source_content): Update.
 668         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 669         * tui/tui-stack.c (tui_show_frame_info): Update.
 670         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 671         Remove defines.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 676         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 677         parameter.
 678         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 679         parameter.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-winsource.c (tui_clear_source_content)
 684         (tui_show_source_content, tui_show_exec_info_content)
 685         (tui_clear_exec_info_content): Update.
 686         * tui/tui-stack.c (tui_show_locator_content): Update.
 687         (tui_show_frame_info): Update.
 688         * tui/tui-source.h (tui_source_window): Don't declare.
 689         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 690         from tui_source_is_displayed.
 691         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 692         Remove field.
 693         (struct tui_source_window_base) <content_in_use>: New field.  Now
 694         bool.
 695         (struct tui_source_window) <showing_source_p>: New method.
 696         (TUI_SRC_WIN): Change cast.
 697         * tui/tui-data.c (tui_initialize_static_data): Update.
 698
 699 2019-07-17  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 702         location_matches_p.
 703         * tui/tui-source.c (tui_source_window::location_matches_p): New
 704         method.
 705         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 706         method.
 707         * tui/tui-data.h (struct tui_source_window_base)
 708         <location_matches_p>: New method.
 709         (struct tui_source_window, struct tui_disasm_window)
 710         <location_matches_p>: Likewise.
 711
 712 2019-07-17  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-win.c (tui_set_win_height_command): Rename from
 715         tui_set_win_height.
 716         (tui_set_win_height_command): Remove.
 717
 718 2019-07-17  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-source.c (tui_source_window): New constructor.  Add
 721         observer.
 722         (~tui_source_window): New destructor.
 723         (tui_source_window::style_changed): New method.
 724         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 725         (tui_attach_detach_observers): Update.
 726         * tui/tui-data.h (struct tui_source_window): Make constructor not
 727         inline.  Add destructor.
 728         (struct tui_source_window) <style_changed>: New method.
 729         <m_observable>: New member.
 730
 731 2019-07-17  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 734         * tui/tui-win.c (tui_resize_all): Fix typo.
 735
 736 2019-07-17  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 739         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 740         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 741         * tui/tui-win.c (window_name_completer): Use foreach.
 742         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 743         (update_tab_width): Likewise.
 744         * tui/tui-layout.c (show_layout): Update.
 745         * tui/tui-data.h (class tui_window_iterator): New.
 746         (struct all_tui_windows): New.
 747         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 748
 749 2019-07-17  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 752         parameter.  Don't reference globals.
 753         (tui_reg_command): Update.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-regs.c (tui_show_registers): Simplify.
 758
 759 2019-07-17  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-regs.c (tui_show_registers): Update.
 762         (tui_show_register_group): Add win_info parameter.
 763
 764 2019-07-17  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 767         Rename from tui_display_reg_element_at_line.
 768         (tui_data_window::display_registers_from_line): Update.
 769         * tui/tui-data.h (struct tui_data_window)
 770         <display_reg_element_at_line>: New method.
 771
 772 2019-07-17  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-regs.h (tui_display_registers_from)
 775         (tui_display_registers_from_line): Don't declare.
 776         * tui/tui-windata.c (tui_data_window::display_all_data)
 777         (tui_data_window::refresh_all)
 778         (tui_data_window::do_scroll_vertical): Update.
 779         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 780         from tui_display_registers_from.
 781         (tui_display_reg_element_at_line): Update.
 782         (tui_data_window::display_registers_from_line): Rename from
 783         tui_display_registers_from_line.
 784         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 785         display_registers_from_line>: New methods.
 786
 787 2019-07-17  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 790         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 791         from tui_erase_data_content.
 792         (tui_data_window::display_all_data)
 793         (tui_data_window::refresh_all)
 794         (tui_data_window::do_scroll_vertical): Update.
 795         * tui/tui-regs.c (tui_show_registers): Update.
 796         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 797         New method.
 798
 799 2019-07-17  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 802         declare.
 803         * tui/tui-windata.c
 804         (tui_data_window::delete_data_content_windows): Rename from
 805         tui_delete_data_content_windows.
 806         (tui_data_window::display_all_data)
 807         (tui_data_window::do_scroll_vertical): Update.
 808         * tui/tui-data.h (struct tui_data_window)
 809         <delete_data_content_windows>: New method.
 810
 811 2019-07-17  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 814         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 815
 816 2019-07-17  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 819         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 820         from tui_display_all_data.
 821         * tui/tui-win.c
 822         (tui_data_window::do_make_visible_with_new_height): Update.
 823         * tui/tui-regs.c (tui_show_registers): Update.
 824         * tui/tui-layout.c (tui_set_layout): Update.
 825         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 826         method.
 827
 828 2019-07-17  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 831         * tui/tui-windata.c (tui_display_data_from): Remove.
 832         (tui_data_window::refresh_all): Update.
 833
 834 2019-07-17  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 837         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 838         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 839         tui_display_registers_from_line.
 840         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 841         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 842         "force_display" parameter.
 843
 844 2019-07-17  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 847         declare.
 848         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 849         Rename from tui_first_reg_element_no_inline.
 850         (tui_display_reg_element_at_line)
 851         (tui_display_registers_from_line): Update.
 852         * tui/tui-data.h (struct tui_data_window)
 853         <first_reg_element_no_inline>: New method.
 854
 855 2019-07-17  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-windata.c (tui_display_data_from)
 858         (tui_data_window::do_scroll_vertical): Update.
 859         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 860         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 861         Rename from tui_line_from_reg_element_no.
 862         (tui_display_registers_from_line): Update.
 863         * tui/tui-data.h (struct tui_data_window)
 864         <line_from_reg_element_no>: New method.
 865
 866 2019-07-17  Tom Tromey  <tom@tromey.com>
 867
 868         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 869         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 870         tui_last_regs_line_no.
 871         (tui_display_reg_element_at_line)
 872         (tui_display_registers_from_line): Update.
 873         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 874         method.
 875
 876 2019-07-17  Tom Tromey  <tom@tromey.com>
 877
 878         PR tui/24722:
 879         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 880         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 881         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 882         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 883         (tui_update_breakpoint_info): Likewise.
 884         * tui/tui-hooks.c (tui_event_create_breakpoint)
 885         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 886         Update.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 891
 892 2019-07-17  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-winsource.c (tui_update_source_window_as_is)
 895         (tui_update_source_windows_with_addr): Update.
 896         * tui/tui-source.h (tui_set_source_content)
 897         (tui_show_symtab_source): Add "win_info" parameter.
 898         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 899         parameter.
 900         (tui_show_symtab_source): Likewise.
 901
 902 2019-07-17  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-wingeneral.c
 905         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 906
 907 2019-07-17  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 910         (struct tui_cmd_window) <can_scroll>: New method.
 911         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 912         method.
 913
 914 2019-07-17  Tom Tromey  <tromey@adacore.com>
 915
 916         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 917         do_field_signed>: Rename.  Change type of "value".
 918         * ui-out.c (ui_out::field_signed): Rename from field_int.
 919         Change type of "value".
 920         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 921         type of "value".
 922         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 923         do_field_int.  Change type of "value".
 924         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 925         do_field_int.  Change type of "value".
 926         * tracepoint.c (trace_status_mi, tfind_1)
 927         (print_one_static_tracepoint_marker): Update.
 928         * thread.c (print_thread_info_1, print_selected_thread_frame):
 929         Update.
 930         * stack.c (print_frame, print_frame_info): Update.
 931         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 932         Update.
 933         * source.c (print_source_lines_base): Update.
 934         * skip.c (info_skip_command): Update.
 935         * record-btrace.c (btrace_ui_out_decode_error)
 936         (btrace_call_history_src_line): Update.
 937         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 938         Update.
 939         * progspace.c (print_program_space): Update.
 940         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 941         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 942         do_field_int.  Change type of "value".
 943         * mi/mi-out.c (mi_ui_out::do_table_begin)
 944         (mi_ui_out::do_table_header): Update.
 945         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 946         type of "value".
 947         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 948         (mi_cmd_data_list_changed_registers, output_register)
 949         (mi_cmd_data_read_memory, mi_load_progress)
 950         (mi_cmd_trace_frame_collected): Update.
 951         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 952         Update.
 953         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 954         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 955         (mi_cmd_var_list_children, varobj_update_one): Update.
 956         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 957         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 958         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 959         * inferior.c (print_inferior): Update.
 960         * gdb_bfd.c (print_one_bfd): Update.
 961         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 962         Update.
 963         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 964         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 965         do_field_int.  Change type of "value".
 966         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 967         do_field_int.  Change type of "value".
 968         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 969         (print_one_breakpoint_location, print_it_catch_fork)
 970         (print_one_catch_fork, print_it_catch_vfork)
 971         (print_one_catch_vfork, print_it_catch_solib)
 972         (print_it_catch_exec, print_it_ranged_breakpoint)
 973         (print_mention_watchpoint, print_mention_masked_watchpoint)
 974         (bkpt_print_it, update_static_tracepoint): Update.
 975         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 976         * break-catch-syscall.c (print_it_catch_syscall): Update.
 977         * ada-tasks.c (print_ada_task_info): Update.
 978         * ada-lang.c (print_it_exception, print_mention_exception):
 979         Update.
 980
 981 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 982
 983         PR breakpoints/24541
 984         * gdbarch.c: Regenerate.
 985         * gdbarch.h: Regenerate.
 986         * gdbarch.sh: Adjust return type and parameter types for
 987         'stap_adjust_register'.
 988         (i386_stap_adjust_register): Adjust signature and return new
 989         register name.
 990         * stap-probe.c (stap_parse_register_operand): Adjust use of
 991         'gdbarch_stap_adjust_register'.
 992
 993 2019-07-17  Tom Tromey  <tromey@adacore.com>
 994
 995         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 996         declare VEC.
 997         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 998         std::vector.
 999         (struct s390_process_info): Add initializers.
1000         (s390_add_process): Use new.
1001         (s390_linux_nat_target::low_forget_process): Use delete.
1002         (s390_linux_nat_target::low_new_fork)
1003         (s390_linux_nat_target::stopped_by_watchpoint)
1004         (s390_linux_nat_target::low_prepare_to_resume)
1005         (s390_linux_nat_target::insert_watchpoint)
1006         (s390_linux_nat_target::insert_hw_breakpoint)
1007         (s390_linux_nat_target::remove_watchpoint)
1008         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1009
1010 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1011
1012         * aarch64-fbsd-nat.c: Include regcache.h.
1013         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1014         argument.
1015         (aarch64_fbsd_nat_target::fetch_registers)
1016         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1017         variable.
1018         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1019
1020 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1021
1022         * fbsd-nat.c: Include gdbarch.h.
1023
1024 2019-07-15  Tom Tromey  <tromey@adacore.com>
1025
1026         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1027
1028 2019-07-15  Tom Tromey  <tromey@adacore.com>
1029
1030         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1031         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1032         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1033         * cli-out.c (cli_ui_out::do_field_int): New method.
1034         * ui-out.c (ui_out::field_unsigned): New method.
1035         * symfile.c (generic_load): Use field_unsigned.
1036         (print_transfer_performance): Likewise.
1037         * record-btrace.c (ui_out_field_uint): Remove.
1038         (btrace_call_history_insn_range, btrace_call_history): Use
1039         field_unsigned.
1040         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1041         field_unsigned.
1042         * ui-out.h (class ui_out) <field_unsigned>: New method.
1043         <do_field_unsigned>: Likewise.
1044
1045 2019-07-15  Tom Tromey  <tromey@adacore.com>
1046
1047         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1048         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1049         * target.c (flash_erase_command): Use field_string.
1050         * infrun.c (print_signal_received_reason): Use field_string.
1051         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1052         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1053         field_string.
1054         * ada-tasks.c (print_ada_task_info): Use field_string.
1055
1056 2019-07-15  Tom Tromey  <tromey@adacore.com>
1057
1058         * target.c (flash_erase_command): Use field_core_addr.
1059         * symfile.c (generic_load): Use field_core_addr.
1060         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1061         Use field_core_addr.
1062         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1063         field_core_addr.
1064
1065 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1068         value if its desired type is smaller than a CORE_ADDR and signed.
1069
1070 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1073         of changes to field names, and use new is_reference field to
1074         decide if a property is a reference or not.
1075         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1076         field.
1077         (struct dwarf2_property_baton): Update header comment, rename
1078         'referenced_type' to 'property_type' and update comments.
1079         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1080         default property type, store in property baton, update to take
1081         accound of renamed field.
1082         (read_func_scope): Update call to attr_to_dynamic_prop.
1083         (read_array_type): Likewise.
1084         (dwarf2_per_cu_addr_sized_int_type): New function.
1085         (read_subrange_index_type): Move type finding code to
1086         dwarf2_per_cu_addr_sized_int_type.
1087         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1088         (dwarf2_per_cu_addr_type): New function.
1089         (set_die_type): Update calls to attr_to_dynamic_prop.
1090
1091 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * dwarf2read.c (read_subrange_index_type): New function.
1094         (read_subrange_type): Move code into new function and call it.
1095         * gdbtypes.c (create_range_type): Add some asserts.
1096
1097 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1098
1099         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1100         update return statements.
1101         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1102         declaration, and update comment to match.
1103         * gdbtypes.c (resolve_dynamic_array): Update call to
1104         dwarf2_evaluate_property to match new return type.
1105
1106 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * valarith.c (value_subscripted_rvalue): Change lowerbound
1109         parameter type from int to LONGEST.
1110         * value.h (value_subscripted_rvalue): Likewise in declaration.
1111
1112 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * cli/cli-utils.c (info_print_command_completer): New function.
1115         * cli/cli-utils.h: Add 'completer.h' include, and forward
1116         declaration for 'struct cmd_list_element'.
1117         (info_print_command_completer): Declare.
1118         * stack.c (_initialize_stack): Add completer for 'info locals' and
1119         'info args'.
1120         * symtab.c (_initialize_symtab): Add completer for 'info
1121         variables' and 'info functions'.
1122         * NEWS: Mention completion for additional info commands.
1123
1124 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * cli/cli-utils.c (extract_info_print_args): Delete.
1127         (extract_arg_maybe_quoted): Delete.
1128         (info_print_options_defs): New variable.
1129         (make_info_print_options_def_group): New function.
1130         (extract_info_print_options): Define new function.
1131         * cli/cli-utils.h (extract_info_print_args): Delete.
1132         (struct info_print_options): New structure.
1133         (extract_info_print_options): Declare new function.
1134         * stack.c (info_locals_command): Update to use new
1135         extract_info_print_options, also add a header comment.
1136         (info_args_command): Likewise.
1137         * symtab.c (info_variables_command): Likewise.
1138         (info_functions_command): Likewise.
1139
1140 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1143         to extract string arguments.
1144         * common/common-utils.c (extract_string_maybe_quoted): New function.
1145         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1146
1147 2019-07-11  Tom Tromey  <tromey@adacore.com>
1148
1149         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1150         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1151         * top.h (gdbinit): Don't declare.
1152         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1153         into...
1154         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1155         * top.c (gdb_init): Don't call init_cli_cmds.
1156         (gdbinit): Remove.
1157         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1158
1159 2019-07-11  Tom Tromey  <tromey@adacore.com>
1160
1161         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1162         after it has been moved.
1163
1164 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1165
1166         * valops.c (value_must_coerce_to_target): Change return type to
1167         bool.
1168         * value.h (value_must_coerce_to_target): Likewise.
1169
1170 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1171
1172         * breakpoint.c (is_hardware_watchpoint): Remove
1173         forward-declaration.
1174         (is_masked_watchpoint): Change return type to bool.
1175         (is_tracepoint): Likewise.
1176         (is_breakpoint): Likewise.
1177         (is_hardware_watchpoint): Likewise.
1178         (is_watchpoint): Likewise.
1179         (is_no_memory_software_watchpoint): Likewise.
1180         (is_catchpoint): Likewise.
1181         (breakpoint_1): Make FILTER parameter's return type bool.
1182         is_masked_watchpoint): Change return type to bool.
1183         (save_breakpoints): Make FILTER parameter's return type bool.
1184         * breakpoint.h (is_breakpoint): Change return type to bool.
1185         (is_watchpoint): Likewise.
1186         (is_catchpoint): Likewise.
1187         (is_tracepoint): Likewise.
1188
1189 2019-07-10  Tom Tromey  <tom@tromey.com>
1190
1191         * defs.h: Don't include gdbarch.h.
1192         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1193         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1194         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1195         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1196         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1197         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1198         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1199         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1200         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1201         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1202         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1203         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1204         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1205         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1206         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1207         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1208         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1209         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1210         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1211         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1212         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1213         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1214         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1215         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1216         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1217         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1218         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1219
1220 2019-07-10  Tom Tromey  <tromey@adacore.com>
1221
1222         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1223         * breakpoint.c (init_ada_exception_breakpoint): Register as
1224         bp_catchpoint.
1225         (print_one_breakpoint_location, print_one_breakpoint): Use
1226         is_ada_exception_catchpoint.
1227         * ada-lang.c (class ada_catchpoint_location): Pass
1228         bp_loc_software_breakpoint to bp_location constructor.
1229         (is_ada_exception_catchpoint): New function.
1230
1231 2019-07-10  Tom Tromey  <tromey@adacore.com>
1232
1233         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1234         VEC.
1235         (struct arm_exidx_entry): New method operator<.
1236         (struct arm_exidx_data) <section_maps>: Change type.
1237         (arm_exidx_data_free): Remove.
1238         (arm_exidx_data_key): Change type.  Move lower.
1239         (arm_exidx_new_objfile): Update.
1240         (arm_compare_exidx_entries): Remove.
1241         (arm_find_exidx_entry, _initialize_arm_tdep)
1242
1243 2019-07-10  Tom Tromey  <tromey@adacore.com>
1244
1245         * solib-spu.c (ocl_program_data_key): Change type.
1246         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1247         Update.
1248
1249 2019-07-10  Tom Tromey  <tromey@adacore.com>
1250
1251         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1252         (struct solib_aix_inferior_data) <library_list>: Change type.
1253         (solib_aix_inferior_data_handle): Change type.
1254         (get_solib_aix_inferior_data): Update.
1255         (solib_aix_free_library_list): Remove.
1256         (library_list_start_library): Update.
1257         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1258         return type.
1259         (solib_aix_get_library_list)
1260         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1261         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1262
1263 2019-07-10  Tom Tromey  <tromey@adacore.com>
1264
1265         * solib-dsbt.c (struct dsbt_info): Add initializers.
1266         (solib_dsbt_pspace_data): Change type.
1267         (dsbt_pspace_data_cleanup): Remove.
1268         (get_dsbt_info, _initialize_dsbt_solib): Update.
1269
1270 2019-07-10  Tom Tromey  <tromey@adacore.com>
1271
1272         * spu-tdep.c (spu_overlay_data): Change type.
1273         (spu_get_overlay_table, spu_overlay_new_objfile)
1274         (_initialize_spu_tdep): Update.
1275
1276 2019-07-10  Tom Tromey  <tromey@adacore.com>
1277
1278         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1279         destructor.
1280         (dbx_objfile_data_key): Change type and declare later.
1281         (DBX_SYMFILE_INFO): Rewrite.
1282         * dbxread.c (dbx_objfile_data_key): Change type.
1283         (dbx_symfile_init): Update.
1284         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1285         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1286         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1287
1288 2019-07-10  Tom Tromey  <tromey@adacore.com>
1289
1290         * jit.c (jit_program_space_key): Change type.  Move lower.
1291         (get_jit_program_space_data): Update.
1292         (jit_program_space_data_cleanup): Remove.
1293         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1294         Update.
1295         (struct jit_program_space_data): Add initializers.
1296
1297 2019-07-10  Tom Tromey  <tromey@adacore.com>
1298
1299         * solib-darwin.c (struct darwin_info): Add initializers.
1300         (solib_darwin_pspace_data): Change type.
1301         (darwin_pspace_data_cleanup): Remove.
1302         (get_darwin_info, _initialize_darwin_solib): Update.
1303
1304 2019-07-10  Tom Tromey  <tromey@adacore.com>
1305
1306         * remote-sim.c (struct sim_inferior_data): Add initializers,
1307         constructor, and destructor.
1308         (sim_inferior_data_key): Change type.  Move lower.
1309         (check_for_duplicate_sim_descriptor): Update.
1310         (get_sim_inferior_data): Use new.  Update.
1311         (~sim_inferior_data_cleanup): Rename from
1312         sim_inferior_data_cleanup.  Simplify.
1313         (gdbsim_close_inferior, simulator_command)
1314         (sim_command_completer, _initialize_remote_sim): Update.
1315         (next_pid, INITIAL_PID): Move earlier.
1316
1317 2019-07-10  Tom Tromey  <tromey@adacore.com>
1318
1319         * python/python-internal.h (create_thread_object): Return
1320         gdbpy_ref.
1321         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1322         * python/py-inferior.c (struct threadlist_entry): Add
1323         constructor.
1324         <thread_obj>: Now a gdbpy_ref.
1325         (thread_to_thread_object): Update.
1326         (add_thread_object): Use new.
1327         (delete_thread_object): Use delete.
1328         (infpy_threads): Update.
1329         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1330         GIL.
1331
1332 2019-07-10  Tom Tromey  <tromey@adacore.com>
1333
1334         * valops.c (value_cast): Specialize error message for Ada.
1335
1336 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1337
1338         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1339
1340 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1341
1342         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1343         bpstat_should_step): Return bool, adjust comments.
1344         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1345         bpstat_should_step): Likewise.
1346
1347 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1348
1349         * features/Makefile: Use feature target descriptions for Arm.
1350         * features/arm/arm-core.c: Generate new file.
1351         * features/arm/arm-fpa.c: Likewise.
1352         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1353         * features/arm/arm-m-profile.c: Likewise.
1354         * features/arm/arm-vfpv2.c: Likewise.
1355         * features/arm/arm-vfpv3.c: Likewise.
1356         * features/arm/xscale-iwmmxt.c: Likewise.
1357         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1358
1359 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1360
1361         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1362         ptrace earlier.
1363
1364 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1365
1366         * features/aarch64-pauth.c: Regenerate.
1367
1368 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1369
1370         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1371         bool.
1372         (bpstat_what): Use false instead of 0.
1373
1374 2019-07-09  Pedro Alves  <palves@redhat.com>
1375
1376         * break-catch-throw.c (is_exception_catchpoint): New.
1377         * breakpoint.c (print_one_breakpoint_location): New parameter
1378         'raw_loc'.  Handle it.  Use
1379         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1380         looking at the breakpoint's type.
1381         (print_one_breakpoint): If handling "maint info breakpoints", also
1382         print locations of exception catchpoints.
1383         * breakpoint.h (is_exception_catchpoint): Declare.
1384
1385 2019-07-09  Pedro Alves  <palves@redhat.com>
1386
1387         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1388         "addr" field.
1389         (allocate_location_exception_catchpoint): New.
1390         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1391         (initialize_throw_catchpoint_ops): Install
1392         allocate_location_exception_catchpoint as allocate_location
1393         method.
1394         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1395         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1396         bp_loc_other.
1397         (breakpoint_address_is_meaningful): Delete.
1398         (bl_address_is_meaningful): New.
1399         (breakpoint_locations_match): Adjust comment.
1400         (bp_location_from_bp_type): New, factored out of...
1401         (bp_location::bp_location(breakpoint *)): ... this.
1402         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1403         factored out of...
1404         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1405         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1406         breakpoint_address_is_meaningful.
1407         (bp_locations_compare): Adjust comment.
1408         (update_global_location_list): Use bl_address_is_meaningful
1409         instead of breakpoint_address_is_meaningful.
1410         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1411         explicit.
1412         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1413         * python/py-breakpoint.c (bppy_get_location): No longer check
1414         whether location is null.
1415
1416 2019-07-09  Pedro Alves  <palves@redhat.com>
1417
1418         PR c++/15468
1419         * breakpoint.c (print_one_breakpoint_location): Remove
1420         single-location assert.
1421
1422 2019-07-09  Tom Tromey  <tom@tromey.com>
1423
1424         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1425         * configure: Rebuild.
1426         * configure.ac: Change common to gdbsupport.
1427         * gdbsupport: Rename from common.
1428         * acinclude.m4: Change common to gdbsupport.
1429         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1430         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1431         gdbsupport.
1432         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1433         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1434         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1435         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1436         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1437         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1438         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1439         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1440         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1441         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1442         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1443         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1444         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1445         coff-pe-read.c, command.h, compile/compile-c-support.c,
1446         compile/compile-c.h, compile/compile-cplus-symbols.c,
1447         compile/compile-cplus-types.c, compile/compile-cplus.h,
1448         compile/compile-loc2c.c, compile/compile.c, completer.c,
1449         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1450         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1451         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1452         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1453         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1454         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1455         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1456         features/aarch64-core.c, features/aarch64-fpu.c,
1457         features/aarch64-pauth.c, features/aarch64-sve.c,
1458         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1459         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1460         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1461         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1462         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1463         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1464         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1465         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1466         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1467         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1468         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1469         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1470         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1471         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1472         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1473         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1474         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1475         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1476         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1477         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1478         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1479         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1480         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1481         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1482         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1483         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1484         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1485         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1486         minsyms.c, mips-linux-tdep.c, namespace.h,
1487         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1488         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1489         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1490         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1491         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1492         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1493         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1494         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1495         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1496         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1497         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1498         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1499         procfs.c, producer.c, progspace.h, psymtab.h,
1500         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1501         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1502         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1503         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1504         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1505         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1506         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1507         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1508         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1509         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1510         target-memory.c, target.c, target.h, target/waitstatus.c,
1511         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1512         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1513         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1514         unittests/array-view-selftests.c,
1515         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1516         unittests/common-utils-selftests.c,
1517         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1518         unittests/format_pieces-selftests.c,
1519         unittests/function-view-selftests.c,
1520         unittests/lookup_name_info-selftests.c,
1521         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1522         unittests/mkdir-recursive-selftests.c,
1523         unittests/observable-selftests.c,
1524         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1525         unittests/parse-connection-spec-selftests.c,
1526         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1527         unittests/scoped_fd-selftests.c,
1528         unittests/scoped_mmap-selftests.c,
1529         unittests/scoped_restore-selftests.c,
1530         unittests/string_view-selftests.c, unittests/style-selftests.c,
1531         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1532         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1533         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1534         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1535         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1536         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1537
1538 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1541         bool value.
1542         (decode_digits_ordinary): Set explicit_line field in sal.
1543         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1544         symtab_and_line that was set on an explicit line number in
1545         assembler code.  Do always update the recorded symtab and line if
1546         we do skip the prologue.
1547
1548 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * breakpoint.c (set_breakpoint_location_function): Remove
1551         explicit_loc parameter.
1552         (momentary_breakpoint_from_master): Update call to
1553         set_breakpoint_location_function.
1554         (add_location_to_breakpoint): Likewise.
1555
1556 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1559         required features based on default bfd type when no specific bfd
1560         is present.
1561
1562 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1563
1564         * NEWS: Mention that GDB printf and eval commands can now print
1565         C-style and Ada-style convenience var strings without
1566         calling the inferior.
1567         * printcmd.c (printf_c_string): Locally print GDB internal var
1568         instead of transiting via the inferior.
1569         (printf_wide_c_string): Likewise.
1570
1571 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1572
1573         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1574
1575 2019-07-04  Tom Tromey  <tom@tromey.com>
1576
1577         PR tui/24724:
1578         * tui/tui-winsource.c (tui_clear_source_content): Update.
1579         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1580         (tui_update_breakpoint_info): Update.
1581         (tui_set_exec_info_content): Update.
1582         * tui/tui-source.c (tui_set_source_content_nil): Update.
1583         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1584         has_break.
1585         * tui/tui-data.h (enum tui_bp_flag): New.
1586         (tui_bp_flags): New enum flags type.
1587         (struct tui_source_element) <break_mode>: Change type.  Rename
1588         from has_break.
1589         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1590         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1591         constants.
1592         * tui/tui-winsource.h: Fix comment.
1593
1594 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1595
1596         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1597         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1598         (store_fpregs_to_thread)
1599         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1600         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1601         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1602         (IWMMXT_REGS_SIZE): Add define.
1603         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1604         (fetch_vfp_regs, store_vfp_regs)
1605         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1606         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1607
1608 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1609
1610         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1611         defines.
1612         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1613         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1614         (ARM_INT_REGISTER_SIZE): ...to this.
1615         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1616         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1617         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1618         (arm_linux_collect_gregset, supply_nwfpe_register)
1619         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1620         defines.
1621         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1622         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1623         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1624         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1625         (arm_return_in_memory, arm_store_return_value)
1626         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1627         (arm_record_ld_st_multiple): Likewise.
1628         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1629         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1630
1631 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1632
1633         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1634         AARCH64_DISPLACED_MODIFIED_INSNS.
1635         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1636         (aarch64_displaced_step_copy_insn): Likewise.
1637         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1638         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1639         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1640         ARM_DISPLACED_MODIFIED_INSNS.
1641         * arm-tdep.c (arm_gdbarch_init): Likewise.
1642         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1643         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1644         (struct arm_displaced_step_closure): Use
1645         ARM_DISPLACED_MODIFIED_INSNS.
1646
1647 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1648
1649         * features/Makefile: Remove unused xml files.
1650         * features/aarch64.xml: Remove.
1651         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1652         * features/i386/amd64-avx-avx512.xml: Remove.
1653         * features/i386/amd64-avx-linux.xml: Remove.
1654         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1655         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1656         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1657         * features/i386/amd64-avx-mpx.xml: Remove.
1658         * features/i386/amd64-avx.xml: Remove.
1659         * features/i386/amd64-linux.xml: Remove.
1660         * features/i386/amd64-mpx-linux.xml: Remove.
1661         * features/i386/amd64-mpx.xml: Remove.
1662         * features/i386/amd64.xml: Remove.
1663         * features/i386/i386-avx-avx512-linux.xml: Remove.
1664         * features/i386/i386-avx-avx512.xml: Remove.
1665         * features/i386/i386-avx-linux.xml: Remove.
1666         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1667         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1668         * features/i386/i386-avx-mpx-linux.xml: Remove.
1669         * features/i386/i386-avx-mpx.xml: Remove.
1670         * features/i386/i386-avx.xml: Remove.
1671         * features/i386/i386-linux.xml: Remove.
1672         * features/i386/i386-mmx-linux.xml: Remove.
1673         * features/i386/i386-mmx.xml: Remove.
1674         * features/i386/i386-mpx-linux.xml: Remove.
1675         * features/i386/i386-mpx.xml: Remove.
1676         * features/i386/i386.xml: Remove.
1677         * features/i386/x32-avx-avx512-linux.xml: Remove.
1678         * features/i386/x32-avx-linux.xml: Remove.
1679         * features/i386/x32-linux.xml: Remove.
1680
1681 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1682
1683         * regformats/aarch64.dat: Remove.
1684         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1685         * regformats/i386/amd64-avx-linux.dat: Remove.
1686         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1687         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1688         * regformats/i386/amd64-linux.dat: Remove.
1689         * regformats/i386/amd64-mpx-linux.dat: Remove.
1690         * regformats/i386/amd64.dat: Remove.
1691         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1692         * regformats/i386/i386-avx-linux.dat: Remove.
1693         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1694         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1695         * regformats/i386/i386-linux.dat: Remove.
1696         * regformats/i386/i386-mmx-linux.dat: Remove.
1697         * regformats/i386/i386-mpx-linux.dat: Remove.
1698         * regformats/i386/i386.dat: Remove.
1699         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1700         * regformats/i386/x32-avx-linux.dat: Remove.
1701         * regformats/i386/x32-linux.dat: Remove.
1702
1703 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1704
1705         * aarch64-tdep.c: Remove xml self tests.
1706         * amd64-linux-tdep.c: Likewise.
1707         * amd64-tdep.c: Likewise.
1708         * i386-linux-tdep.c: Likewise.
1709         * i386-tdep.c: Likewise.
1710
1711 2019-07-03  Pedro Alves  <palves@redhat.com>
1712
1713         PR cli/24732
1714         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1715         (pipe_cmd_option_defs): New.
1716         (make_pipe_cmd_options_def_group): New.
1717         (pipe_command): Use gdb::option::process_options.
1718         (pipe_command_completer): New function.
1719         (_initialize_cli_cmds): Install completer for "pipe" command.
1720
1721 2019-07-03  Pedro Alves  <palves@redhat.com>
1722
1723         * cli/cli-option.c (union option_value) <string>: New field.
1724         (struct option_def_and_value): Add ctor, move ctor, dtor and
1725         use DISABLE_COPY_AND_ASSIGN.
1726         (option_def_and_value::clear_value): New.
1727         (parse_option, save_option_value_in_ctx, get_val_type_str)
1728         (add_setshow_cmds_for_options): Handle var_string.
1729         * cli-option.h (union option_def::var_address) <string>: New
1730         field.
1731         (struct string_option_def): New.
1732         * maint-test-options.c (struct test_options_opts): Add default
1733         ctor and use DISABLE_COPY_AND_ASSIGN.
1734         <string_opt>: New field.
1735         (test_options_opts::~test_options_opts): New.
1736         (test_options_opts::dump): Also dump "-string".
1737         (test_options_option_defs): Install "string.
1738
1739 2019-07-03  Pedro Alves  <palves@redhat.com>
1740
1741         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1742         option_value with a null enumeration.
1743         (complete_options): Save the option values in the context.
1744         (save_option_value_in_ctx): New, factored out from ...
1745         (process_options): ... here.
1746         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1747         of the function.
1748         * maint-test-options.c (test_options_opts::dump): New, factored
1749         out from ...
1750         (maintenance_test_options_command_mode): ... here.
1751         (maintenance_test_options_command_completion_result): Delete.
1752         (maintenance_test_options_command_completion_text): Update
1753         comment.
1754         (maintenance_show_test_options_completion_result): Change
1755         prototype.  Just print
1756         maintenance_test_options_command_completion_text.
1757         (save_completion_result): New.
1758         (maintenance_test_options_completer_mode): Pass options context to
1759         complete_options, and then save a dump.
1760         (_initialize_maint_test_options): Use add_cmd to install "maint
1761         show test-options-completion-result".
1762
1763 2019-07-03  Pedro Alves  <palves@redhat.com>
1764
1765         * NEWS (New commands): Mention "with" and "maint with".
1766         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1767         (with_command, with_command_completer): New.
1768         (pipe_command): Adjust to new repeat_previous
1769         interface.
1770         (_initialize_cli_cmds): Install the "with" command and its "w"
1771         alias.
1772         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1773         declarations.
1774         * cli/cli-setshow.c (parse_cli_var_uinteger)
1775         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1776         argument strings for all var_types.
1777         (get_setshow_command_value_string): New, factored out from ...
1778         (do_show_command): ... this.
1779         * cli/cli-setshow.h: Include <string>.
1780         (get_setshow_command_value_string): Declare.
1781         * command.h (repeat_previous): Now returns const char *.  Adjust
1782         comment.
1783         * maint.c: Include "cli/cli-cmds.h".
1784         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1785         (_initialize_maint_cmds): Register the "maintenance with" command.
1786         * top.c (repeat_previous): Move bits from pipe_command here:
1787         Return the saved command line, if any; error out if there's no
1788         command to relaunch.
1789
1790 2019-07-03  Pedro Alves  <palves@redhat.com>
1791
1792         * NEWS (New commands): Mention "maint set/show test-settings"
1793         instead of "maint test-settings".
1794         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1795         (maintenance_test_settings_set_list): Rename to ...
1796         (maintenance_set_test_settings_list): ... this.
1797         (maintenance_test_settings_show_list): Rename to  ...
1798         (maintenance_show_test_settings_list): ... this.
1799         (maintenance_test_settings_cmd): Delete.
1800         (maintenance_test_settings_set_cmd): ...
1801         (maintenance_set_test_settings_cmd): ... this.
1802         (maintenance_test_settings_show_cmd): ...
1803         (maintenance_show_test_settings_cmd): ... this.
1804         (maintenance_test_settings_show_value_cmd):
1805         (maintenance_show_test_settings_value_cmd): ... this.
1806         (_initialize_maint_test_settings): No longer install the "maint
1807         test-settings" prefix command.  Rename "maint test-settings set"
1808         to "maint set test-settings", and "maint test-settings show" to
1809         "maint show test-settings".  Adjust all subcommands.
1810
1811 2019-07-03  Pedro Alves  <palves@redhat.com>
1812
1813         * maint-test-settings.c: Fix file's intro comment.  Replace all
1814         references to "test-options" with references to "test-settings",
1815         in comments.
1816
1817 2019-07-03  Pedro Alves  <palves@redhat.com>
1818
1819         * maint-test-settings.c (maintenance_test_settings_xxx)
1820         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1821         New.
1822         (maintenance_test_settings_enums): Use them.
1823         (maintenance_test_settings_enum): Default to
1824         maintenance_test_settings_xxx.
1825         (_initialize_maint_test_settings): Initialize
1826         MAINTENANCE_TEST_SETTINGS_FILENAME.
1827
1828 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1829
1830         * breakpoint.h (remove_breakpoints_inf): Change return type to
1831         void, move function documentation here.
1832         * breakpoint.c (remove_breakpoints_inf): Change return type to
1833         void, move function documentation to header.
1834
1835 2019-07-02  Pedro Alves  <palves@redhat.com>
1836
1837         * NEWS (Completion improvements): Mention "info threads".
1838         * thread.c (struct info_threads_opts, info_threads_option_defs)
1839         (make_info_threads_options_def_group): New.
1840         (info_threads_command): Use gdb::option::process_options.
1841         (info_threads_command_completer): New.
1842         (_initialize_thread): Use gdb::option::build_help to build the
1843         help text for "info threads".
1844
1845 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1846
1847         * defs.h (generic_load): Move from here...
1848         * symfile.h (generic_load): ... to here.  Rename name parameter
1849         to args.
1850         * symfile.c (generic_load): Add comment.
1851
1852 2019-07-01  Tom Tromey  <tromey@adacore.com>
1853
1854         * dwarf2read.c
1855         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1856         declaration of without_params.  Fix formatting.
1857
1858 2019-07-01  Tom Tromey  <tromey@adacore.com>
1859
1860         * ada-exp.y (find_primitive_type): Update.
1861         * ada-lang.h (ada_lookup_symbol): Update.
1862         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1863         parameter.
1864         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1865
1866 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1867
1868         PR breakpoints/24541
1869         * gdbarch.c: Regenerate.
1870         * gdbarch.h: Regenerate.
1871         * gdbarch.sh: Add 'stap_adjust_register'.
1872         * i386-tdep.c: Include '<unordered_set>'.
1873         (i386_stap_adjust_register): New function.
1874         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1875         * stap-probe.c (stap_parse_register_operand): Call
1876         'gdbarch_stap_adjust_register'.
1877
1878 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1879
1880         PR python/24742
1881         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1882         * python/python.c (do_start_initialization): Use 'xmalloc'
1883         instead of 'PyMem_Malloc'.
1884
1885 2019-06-28  Tom Tromey  <tromey@adacore.com>
1886
1887         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1888         for Ada.
1889
1890 2019-06-27  Tom Tromey  <tromey@adacore.com>
1891
1892         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1893         objfile_key.
1894         (arm_find_mapping_symbol, arm_record_special_symbol)
1895         (_initialize_arm_tdep): Update.
1896         (arm_objfile_data_free): Remove.
1897
1898 2019-06-27  Tom Tromey  <tromey@adacore.com>
1899
1900         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1901         to cp_print_static_field.
1902
1903 2019-06-26  Tom Tromey  <tromey@adacore.com>
1904
1905         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1906         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1907         declare.
1908
1909 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1910
1911         * features/aarch64-core.c (create_feature_aarch64_core):
1912         Regenerate.
1913         * features/aarch64-core.xml: Add cpsr flags.
1914
1915 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1916
1917         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1918         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1919
1920 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1921
1922         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1923         field.
1924         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1925         use.
1926         (arm_record_special_symbol): Don't insert new symbol in sorted
1927         position, push it at the end.
1928
1929 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1930
1931         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1932         (arm_mapping_symbol_s): Remove.
1933         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1934         (arm_mapping_symbol_vec): New typedef.
1935         (struct arm_per_objfile): Add constructor.
1936         <section_maps>: Change type to
1937         std::unique_ptr<arm_mapping_symbol_vec[]>.
1938         (arm_compare_mapping_symbols): Remove.
1939         (arm_find_mapping_symbol): Adjust to section_maps type change.
1940         (arm_objfile_data_free): Call delete on arm_per_objfile.
1941         (arm_record_special_symbol): Adjust to section_maps type change.
1942         Allocate arm_per_objfile with new.
1943
1944 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1945
1946         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1947         with the command prefix.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1952         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1957         type.
1958         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1959         protected.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-winsource.c
1964         (tui_source_window_base::set_is_exec_point_at): Add check against
1965         LOA_ADDRESS.
1966
1967 2019-06-25  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-source.c (tui_set_source_content): Don't check before
1970         xfree.
1971         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.h (tui_update_source_window_as_is)
1976         (tui_alloc_source_buffer, tui_line_is_displayed)
1977         (tui_addr_is_displayed): Change type of win_info.
1978         * tui/tui-winsource.c (tui_update_source_window_as_is)
1979         (tui_clear_source_content, tui_show_source_line)
1980         (tui_show_source_content, tui_source_window_base::refill)
1981         (tui_source_window_base::set_is_exec_point_at)
1982         (tui_source_window_base::set_is_exec_point_at)
1983         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1984         (tui_alloc_source_buffer, tui_line_is_displayed)
1985         (tui_addr_is_displayed): Change type of win_info.  Update.
1986         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1987         (tui_source_window_base::do_make_visible_with_new_height):
1988         Update.
1989         * tui/tui-source.c (tui_set_source_content)
1990         (tui_set_source_content_nil)
1991         (tui_source_window::do_scroll_vertical): Update.
1992         * tui/tui-layout.c (show_layout): Update.
1993         * tui/tui-disasm.c (tui_set_disassem_content)
1994         (tui_disasm_window::do_scroll_vertical): Update.
1995         * tui/tui-data.h (tui_win_content): Remove.
1996         (struct tui_gen_win_info) <content, content_size>: Remove.
1997         (struct tui_source_element): Add initializers and destructor.
1998         (union tui_which_element, struct tui_win_element): Remove.
1999         (struct tui_source_window_base) <content>: New field.
2000         (struct tui_data_window): Remove destructor.
2001         (tui_alloc_content, tui_free_win_content)
2002         (tui_free_all_source_wins_content): Don't declare.
2003         * tui/tui-data.c (tui_initialize_static_data): Update.
2004         (init_content_element, tui_alloc_content): Remove.
2005         (~tui_gen_win_info): Update.
2006         (~tui_data_window, tui_free_all_source_wins_content)
2007         (tui_free_win_content, free_content, free_content_elements):
2008         Remove.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.h (tui_clear_source_content)
2013         (tui_erase_source_content, tui_show_source_content): Change type
2014         of win_info.
2015         * tui/tui-winsource.c (tui_clear_source_content)
2016         (tui_erase_source_content, tui_show_source_content): Change type
2017         of win_info.
2018         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2019         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2020         win_info.
2021         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2022         win_info.
2023         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2024
2025 2019-06-25  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-winsource.c (tui_clear_source_content)
2028         (tui_source_window_base::set_is_exec_point_at): Update.
2029         * tui/tui-source.c (tui_set_source_content_nil): Update.
2030         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2031         a bool.
2032         * tui/tui-data.c (init_content_element): Update.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2037         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2038         * tui/tui-layout.c (init_and_make_win): Update.
2039         * tui/tui.h (enum tui_win_type): Update.
2040         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2041         tui_win_is_auxillary.
2042         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2043         tui_win_is_auxillary.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2048         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2049         (tui_delete_data_content_windows, tui_display_all_data)
2050         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2051         Update.
2052         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2053         * tui/tui-regs.c (tui_last_regs_line_no)
2054         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2055         (tui_show_registers): Update.
2056         (tui_show_register_group): Return void.  Update.
2057         (tui_display_registers_from, tui_display_reg_element_at_line)
2058         (tui_display_registers_from_line, tui_check_register_values):
2059         Update.
2060         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2061         member.
2062         (struct tui_data_window) <regs_content>: Now a std::vector.
2063         <regs_content_count>: Remove.
2064         (tui_add_content_elements, tui_free_data_content): Don't declare.
2065         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2066         (init_content_element): Remove DATA_WIN case.  Add assert.
2067         (tui_add_content_elements): Remove.
2068         (tui_data_window): Update.
2069         (tui_free_data_content): Remove.
2070         (free_content_elements): Remove DATA_WIN case.
2071
2072 2019-06-25  Tom Tromey  <tom@tromey.com>
2073
2074         * tui/tui-data.c (tui_data_item_window): Update.
2075         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2076         * tui/tui-windata.c (tui_display_all_data)
2077         (tui_display_data_from_line): Update.
2078         (tui_check_data_values): Remove.
2079         * tui/tui-regs.c (tui_show_register_group)
2080         (tui_display_reg_element_at_line): Update.
2081         * tui/tui-hooks.c (tui_register_changed)
2082         (tui_refresh_frame_and_register_information): Call
2083         tui_check_register_values.
2084         * tui/tui-data.h (struct tui_data_window) <data_content,
2085         data_content_count, data_type>: Remove.
2086         (enum tui_data_type): Remove.
2087
2088         * tui/tui-data.c (tui_data_window::clear_detail)
2089         (~tui_data_window): Update.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2094         declare.
2095         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2096         Rename from tui_first_data_item_displayed.  Update.
2097         (tui_data_window::refresh_all)
2098         (tui_data_window::do_scroll_vertical): Update.
2099         * tui/tui-data.h (struct tui_data_window)
2100         <first_data_item_displayed>: Declare new method.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2105         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2106         contents...
2107         (tui_initialize_static_data): ...here.
2108
2109 2019-06-25  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2112         (tui_display_registers_from, tui_check_register_values): Update.
2113         (tui_display_register): Remove win_info parameter; update.
2114         (tui_get_register): Change type of parameters.
2115         * tui/tui-data.h (struct tui_data_element): Remove.
2116         (union tui_which_element) <data>: Remove.
2117         <data_window>: Change type.
2118         (struct tui_data_item_window): New.
2119         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2120         case.  Add assert.
2121         (~tui_data_item_window): New destructor.
2122         (free_content_elements): Remove DATA_ITEM_WIN case.
2123
2124 2019-06-25  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2127         Remove.
2128
2129 2019-06-25  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-data.h (struct tui_command_element): Remove.
2132         (union tui_which_element) <command>: Remove.
2133         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2134         assert.
2135         (free_content_elements): Remove CMD_WIN case.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-layout.c (tui_set_layout): Update.
2140         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2141         * tui/tui-data.c (layout_def): Update.
2142
2143 2019-06-25  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2146         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2147         (tui_source_window_base::set_new_height): Update.
2148         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2149         Update.
2150         (tui_set_locator_fullname, tui_set_locator_info)
2151         (tui_show_frame_info): Update.
2152         * tui/tui-source.c (tui_set_source_content)
2153         (tui_source_is_displayed): Update.
2154         * tui/tui-layout.c (show_source_disasm_command, show_data)
2155         (show_source_or_disasm_and_command): Update.
2156         * tui/tui-disasm.c (tui_set_disassem_content)
2157         (tui_get_begin_asm_address): Update.
2158         * tui/tui-data.h (struct tui_locator_element): Remove.
2159         (union tui_which_element) <locator>: Remove.
2160         (struct tui_locator_window): New.
2161         (tui_locator_win_info_ptr): Change return type.
2162         * tui/tui-data.c (_locator): Change type.
2163         (tui_locator_win_info_ptr): Change return type.
2164         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2165         (tui_alloc_content): Add assert.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-winsource.c
2170         (tui_exec_info_window::maybe_allocate_content): New method.
2171         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2172         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2173         (make_source_or_disasm_window): Add cast.
2174         * tui/tui-data.h (union tui_which_element) <simple_string>:
2175         Remove.
2176         (struct tui_source_info): New.
2177         (struct tui_source_window_base) <execution_info>: Change type.
2178         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2179         case, and add assert.
2180         (tui_alloc_content): Add assert.
2181
2182 2019-06-25  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2185         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2186         * tui/tui-data.c (tui_alloc_win_info): Remove.
2187
2188 2019-06-25  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2191         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2192         can_highlight.
2193
2194 2019-06-25  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2197         make_visible_with_new_height method.
2198         (tui_win_info::make_visible_with_new_height): New method.
2199         (tui_source_window_base::do_make_visible_with_new_height)
2200         (tui_data_window::do_make_visible_with_new_height)
2201         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2202         (make_visible_with_new_height): Remove.
2203         (tui_resize_all, tui_adjust_win_heights): Use
2204         make_visible_with_new_height method.
2205         * tui/tui-data.h (struct tui_win_info)
2206         <do_make_visible_with_new_height, make_visible_with_new_height>:
2207         New methods.
2208         (struct tui_source_window_base, struct tui_data_window)
2209         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2210         methods.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2215         method.
2216         (update_tab_width): Call update_tab_width method.
2217         * tui/tui-data.h (struct tui_win_info)
2218         (struct tui_source_window_base) <update_tab_width>: New methods.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2223         parameter.
2224         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2225         parameter.
2226         (tui_gen_win_info::make_visible): Update.
2227         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2228         parameter.
2229         * tui/tui-data.h (enum tui_box): New enum.
2230         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2235         init_and_make_win for EXEC_INFO_WIN.
2236         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2237         longer inline.
2238         (struct tui_win_info) <~tui_win_info>: Inline.
2239         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2240         Don't declare.
2241         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2242         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2243         Remove.
2244         (tui_initialize_static_data): Update.
2245         (~tui_gen_win_info): Handle more cleanup here.
2246         (~tui_source_window_base): Delete "execution_info".
2247         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2248
2249 2019-06-25  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-layout.c (make_command_window): Don't set
2252         can_highlight.
2253         (show_source_disasm_command): Call the reset method.
2254         (show_data): Don't set can_highlight.  Call the reset method.
2255         (tui_gen_win_info::reset): Rename from init_gen_win_info
2256         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2257         (show_source_or_disasm_and_command): Call the reset method.
2258         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2259         (struct tui_cmd_window): Set can_highlight.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2264         from make_visible.
2265         (tui_make_visible, tui_make_invisible): Rewrite.
2266         (tui_win_info::make_visible): Remove.
2267         (tui_source_window_base::make_visible): Update.
2268         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2269         method.  Moved from...
2270         (struct tui_win_info) <make_visible>: ...here.
2271
2272 2019-06-25  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-winsource.c
2275         (tui_source_window_base::do_scroll_horizontal): Remove direction
2276         parameter.
2277         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2278         direction parameter.
2279         * tui/tui-win.c (tui_win_info::forward_scroll)
2280         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2281         (tui_win_info::right_scroll): Update.
2282         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2283         direction parameter.
2284         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2285         direction parameter.
2286         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2287         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2288         Remove direction parameter.
2289         (struct tui_source_window_base, struct tui_source_window)
2290         (struct tui_disasm_window, struct tui_data_window)
2291         (struct tui_cmd_window): Update.
2292
2293 2019-06-25  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-winsource.h (tui_set_exec_info_content)
2296         (tui_show_exec_info_content, tui_erase_exec_info_content)
2297         (tui_clear_exec_info_content, tui_update_exec_info): Change
2298         argument to tui_source_window_base.
2299         * tui/tui-winsource.c (tui_set_exec_info_content)
2300         (tui_show_exec_info_content, tui_erase_exec_info_content)
2301         (tui_clear_exec_info_content, tui_update_exec_info): Change
2302         argument to tui_source_window_base.
2303
2304 2019-06-25  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2307         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2308
2309 2019-06-25  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2312         check.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2317         type to void.
2318         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2319         type to void.
2320         * tui/tui-source.c (tui_set_source_content): Update.
2321         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2322
2323 2019-06-25  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-win.c (window_name_completer, tui_set_focus)
2326         (tui_all_windows_info): Use name method.
2327         * tui/tui-data.h (struct tui_gen_win_info)
2328         (struct tui_source_window, struct tui_disasm_window)
2329         (struct tui_data_window, struct tui_cmd_window) <name>: New
2330         method.
2331         (tui_win_name): Don't declare.
2332         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2333         (tui_win_name): Remove.
2334
2335 2019-06-25  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-winsource.h (tui_update_source_window)
2338         (tui_update_source_window_as_is): Change parameter type.
2339         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2340         to be a tui_source_window_base.
2341         (tui_update_source_window_as_is): Likewise.
2342         * tui/tui-win.c (make_visible_with_new_height): Update.
2343
2344 2019-06-25  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-winsource.c (tui_erase_source_content)
2347         (tui_show_source_content, tui_show_exec_info_content)
2348         (tui_erase_exec_info_content): Use refresh_window method.
2349         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2350         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2351         from tui_refresh_win.
2352         (tui_data_window::refresh_window): New method.
2353         (tui_win_info::refresh, tui_source_window_base::refresh)
2354         (tui_refresh_all): Use refresh_window method.
2355         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2356         method.
2357         * tui/tui-regs.c (tui_display_register): Call refresh_window
2358         method.
2359         * tui/tui-layout.c (show_source_disasm_command)
2360         (show_source_or_disasm_and_command): Call refresh_window method.
2361         * tui/tui-data.h (struct tui_gen_win_info)
2362         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2363         New method.
2364
2365 2019-06-25  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui.c (tui_rl_other_window, tui_enable)
2368         (tui_is_window_visible, tui_get_command_dimension): Update.
2369         * tui/tui-winsource.c (tui_update_source_window_as_is)
2370         (tui_clear_source_content, tui_erase_source_content)
2371         (tui_show_source_line, tui_source_window_base::refill)
2372         (tui_source_window_base::do_scroll_horizontal)
2373         (tui_source_window_base::set_is_exec_point_at)
2374         (tui_update_breakpoint_info, tui_set_exec_info_content)
2375         (tui_alloc_source_buffer, tui_line_is_displayed)
2376         (tui_addr_is_displayed): Update.
2377         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2378         (tui_check_and_display_highlight_if_needed)
2379         (tui_win_info::make_visible, tui_win_info::refresh)
2380         (tui_refresh_all): Update.
2381         * tui/tui-windata.c (tui_first_data_item_displayed)
2382         (tui_delete_data_content_windows, tui_erase_data_content)
2383         (tui_display_all_data, tui_data_window::refresh_all)
2384         (tui_check_data_values): Update.
2385         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2386         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2387         (tui_win_info::backward_scroll, tui_refresh_all_win)
2388         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2389         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2390         (tui_source_window_base::set_new_height)
2391         (tui_data_window::set_new_height)
2392         (make_invisible_and_set_new_height)
2393         (make_visible_with_new_height, new_height_ok)
2394         (parse_scrolling_args): Update.
2395         * tui/tui-stack.c (tui_show_frame_info): Update.
2396         * tui/tui-source.c (tui_set_source_content)
2397         (tui_set_source_content_nil, tui_source_is_displayed)
2398         (tui_source_window::do_scroll_vertical): Update.
2399         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2400         (tui_display_registers_from, tui_display_reg_element_at_line)
2401         (tui_check_register_values, tui_reg_command): Update.
2402         * tui/tui-layout.c (tui_default_win_height)
2403         (show_source_disasm_command, show_data, init_and_make_win)
2404         (show_source_or_disasm_and_command): Update.
2405         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2406         (tui_redisplay_readline, tui_mld_flush)
2407         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2408         (tui_getc): Update.
2409         * tui/tui-disasm.c (tui_set_disassem_content)
2410         (tui_disasm_window::do_scroll_vertical): Update.
2411         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2412         Now virtual.
2413         (struct tui_win_info): Derive from tui_gen_win_info.
2414         <~tui_win_info>: Mark as override.
2415         <generic>: Remove member.
2416         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2417         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2418         (~tui_data_window, ~tui_win_info)
2419         (tui_free_all_source_wins_content): Update.
2420         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2421
2422 2019-06-25  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-layout.c (init_and_make_win): Use new.
2425         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2426         destructor, initializers.
2427         (tui_alloc_generic_win_info): Don't declare.
2428         * tui/tui-data.c (_locator): Add argument to constructor.
2429         (source_win, disasm_win): New globals.
2430         (exec_info): Remove.
2431         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2432         Update.
2433         (tui_alloc_generic_win_info): Remove.
2434         (init_content_element): Use new.
2435         (tui_win_info::tui_win_info): Update.
2436         (free_content_elements) <case DATA_WIN>: Use delete.
2437
2438 2019-06-25  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2441         * tui/tui-windata.c (tui_first_data_item_displayed)
2442         (tui_delete_data_content_windows): Update.
2443         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2444         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2445         (tui_display_registers_from, tui_check_register_values): Update.
2446         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2447         pointer.
2448         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2449         window.
2450         (tui_free_data_content): Update.
2451         (free_content_elements) <case DATA_WIN>: Free the window.
2452
2453 2019-06-25  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2456         Update.
2457         * tui/tui-layout.c (make_command_window)
2458         (show_source_disasm_command, show_data, init_and_make_win)
2459         (show_source_or_disasm_and_command): Update.
2460         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2461         method.
2462         <can_highight, is_highlighted>: Now bool.
2463         (tui_set_win_highlight): Don't declare.
2464         * tui/tui-data.c (tui_set_win_highlight): Remove.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-wingeneral.c (make_visible): Remove check of window
2469         type.
2470
2471 2019-06-25  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui-win.c (tui_win_info::max_height)
2474         (tui_cmd_window::max_height): New methods.
2475         (new_height_ok): Call max_height.
2476         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2477         <max_height>: New method.
2478
2479 2019-06-25  Tom Tromey  <tom@tromey.com>
2480
2481         * tui/tui-win.c (tui_source_window_base::set_new_height)
2482         (tui_data_window::set_new_height): New methods.
2483         (make_invisible_and_set_new_height): Call set_new_height method.
2484         * tui/tui-data.h (struct tui_win_info)
2485         (struct tui_source_window_base, struct tui_data_window)
2486         <set_new_height>: New method.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2491         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2492         tui_refresh_data_win.
2493         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2494         method.
2495         (tui_refresh_all_win): Call the refresh_all method.
2496         (tui_set_focus): Likewise.
2497         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2498         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2499         Likewise.
2500
2501 2019-06-25  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-winsource.h (tui_refill_source_window)
2504         (tui_set_is_exec_point_at): Don't declare.
2505         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2506         (tui_source_window_base::refill): Rename from
2507         tui_refill_source_window.
2508         (tui_source_window_base::do_scroll_horizontal): Update.
2509         (tui_source_window_base::set_is_exec_point_at): Rename from
2510         tui_set_is_exec_point_at.
2511         (tui_update_all_breakpoint_info): Update.
2512         * tui/tui-stack.c (tui_show_frame_info): Update.
2513         * tui/tui-layout.c (show_data): Add cast.
2514         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2515         * tui/tui-data.h (struct tui_source_window_base) <refill,
2516         set_is_exec_point_at>: New methods.
2517         (tui_source_windows, tui_add_to_source_windows): Update types.
2518         (tui_add_to_source_windows): Remove redundant declaration.
2519         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2520         (tui_source_windows): Change return type.
2521         (tui_clear_source_windows_detail): Update.
2522         (tui_add_to_source_windows): Change type of parameter.
2523         (tui_free_all_source_wins_content): Update.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-wingeneral.c (tui_win_info::refresh)
2528         (tui_source_window_base::refresh): New methods.
2529         (tui_refresh_all): Call the refresh method.
2530         * tui/tui-data.h (struct tui_win_info)
2531         (struct tui_source_window_base) <refresh>: New method.
2532
2533 2019-06-25  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui.h (tui_is_window_visible): Return bool.
2536         * tui/tui.c (tui_is_window_visible): Return bool.
2537         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2538         (tui_make_visible, tui_make_invisible)
2539         (tui_win_info::make_visible)
2540         (tui_source_window_base::make_visible, make_all_visible)
2541         (tui_make_all_visible, tui_make_all_invisible): Update.
2542         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2543         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2544         bool.
2545         (struct tui_win_info, struct tui_source_window_base)
2546         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2547         * tui/tui-data.c (tui_init_generic_part): Update.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2552         (tui_source_window_base::make_visible): New methods.
2553         (make_all_visible): Make method call.
2554         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2555         (struct tui_source_window_base, struct tui_cmd_window): Override
2556         make_visible.
2557         (tui_win_is_source_type): Don't declare.
2558         * tui/tui-data.c (tui_win_is_source_type): Remove.
2559
2560 2019-06-25  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2563         NULL check.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2568         Inline constructor.  Add initializers for members.
2569         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2570         constructors; now inline in class.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-regs.c (tui_show_registers): Update.
2575         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2576         bool.
2577         * tui/tui-data.c (tui_data_window::clear_detail)
2578         (tui_data_window): Update.
2579
2580 2019-06-25  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-windata.c (tui_display_all_data)
2583         (tui_display_data_from_line, tui_display_data_from)
2584         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2585         Update.
2586         * tui/tui-regs.c (tui_last_regs_line_no)
2587         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2588         (tui_show_registers, tui_show_register_group)
2589         (tui_display_registers_from, tui_display_reg_element_at_line)
2590         (tui_display_registers_from_line, tui_check_register_values)
2591         (tui_reg_next, tui_reg_prev): Update.
2592         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2593         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2594         tui_data_window.
2595         (struct tui_win_info) <detail>: Remove.  Add new fields from
2596         tui_data_info.
2597         (TUI_DATA_WIN): Add cast.
2598         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2599         (~tui_data_window): Simplify.
2600
2601 2019-06-25  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-layout.c (show_source_disasm_command)
2604         (show_source_or_disasm_and_command): Update.
2605         * tui/tui-io.c (update_cmdwin_start_line)
2606         (tui_redisplay_readline): Update.
2607         * tui/tui-data.h (struct tui_command_info): Remove.
2608         (struct tui_win_info) <detail>: Remove command_info member.
2609         (struct tui_data_window) <start_line>: New member, from
2610         tui_command_info.
2611         (TUI_CMD_WIN): Add casts.
2612
2613 2019-06-25  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-winsource.c (tui_update_source_window)
2616         (tui_refill_source_window)
2617         (tui_source_window_base::do_scroll_horizontal)
2618         (tui_update_breakpoint_info, tui_set_exec_info_content)
2619         (tui_show_exec_info_content, tui_erase_exec_info_content)
2620         (tui_clear_exec_info_content): Update.
2621         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2622         Update.
2623         * tui/tui-win.c (make_invisible_and_set_new_height)
2624         (make_visible_with_new_height): Update.
2625         * tui/tui-source.c (tui_set_source_content)
2626         (tui_show_symtab_source): Update.
2627         * tui/tui-layout.c (extract_display_start_addr)
2628         (show_source_disasm_command, show_data)
2629         (make_source_or_disasm_window)
2630         (show_source_or_disasm_and_command): Update.
2631         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2632         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2633         "gdbarch".
2634         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2635         to tui_source_window_base.
2636         (struct tui_win_info) <detail>: Remove source_info member.
2637         (struct tui_source_window_base) <has_locator>: Inline.
2638         Move contents from tui_source_info; rename has_locator member to
2639         m_has_locator.
2640         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2641         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2642         header file.
2643         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2644         Simplify.
2645         (tui_free_all_source_wins_content): Cast to
2646         tui_source_window_base.
2647
2648 2019-06-25  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-win.c (make_invisible_and_set_new_height)
2651         (make_visible_with_new_height): Call has_locator method.
2652         * tui/tui-layout.c (show_source_disasm_command, show_data)
2653         (show_source_or_disasm_and_command): Update for bool change.
2654         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2655         (tui_win_info) <has_locator>: New method.
2656         (struct tui_source_window_base) <has_locator>: New method.
2657         (tui_win_has_locator): Don't declare.
2658         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2659         from tui_win_has_locator.
2660         (tui_source_window_base): Use false, not FALSE.
2661
2662 2019-06-25  Tom Tromey  <tom@tromey.com>
2663
2664         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2665         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2666         clear_detail method directly.
2667         (tui_clear_win_detail): Remove.
2668
2669 2019-06-25  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2672         "this", not TUI_DISASM_WIN.
2673
2674 2019-06-25  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2677         declare.
2678         * tui/tui-winsource.c
2679         (tui_source_window_base::do_scroll_horizontal): Rename from
2680         tui_horizontal_source_scroll.
2681         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2682         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2683         from tui_vertical_data_scroll.
2684         * tui/tui-win.h (tui_scroll): Don't declare.
2685         * tui/tui-win.c (tui_win_info::forward_scroll)
2686         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2687         (tui_win_info::right_scroll): Rename and update.
2688         (tui_scroll_forward_command, tui_scroll_backward_command)
2689         (tui_scroll_left_command, tui_scroll_right_command): Update.
2690         (tui_scroll): Remove.
2691         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2692         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2693         from tui_vertical_source_scroll.
2694         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2695         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2696         from tui_vertical_disassem_scroll.
2697         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2698         do_scroll_horizontal>: New methods.
2699         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2700         Likewise.
2701         (struct tui_source_window_base): Add do_scroll_horizontal.
2702         (struct tui_source_window, struct tui_disasm_window): Add
2703         do_scroll_vertical.
2704         (struct tui_data_window, struct tui_cmd_window): Add
2705         do_scroll_horizontal and do_scroll_vertical.
2706         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2707
2708 2019-06-25  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-data.h (struct tui_source_window_base): New struct.
2711         (struct tui_source_window): Derive from tui_source_window_base.
2712         (struct tui_disasm_window): New struct.
2713         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2714         from tui_source_window::clear_detail.
2715         (tui_source_window_base): Rename from tui_source_window.
2716         (~tui_source_window_base): Rename from ~tui_source_window.
2717         (tui_alloc_win_info): Create a tui_disasm_window.
2718
2719 2019-06-25  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-data.h (struct tui_source_window)
2722         (struct tui_data_window): Declare destructors.
2723         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2724         destructors.
2725         (tui_win_info): Simplify.
2726
2727 2019-06-25  Tom Tromey  <tom@tromey.com>
2728
2729         * tui/tui-winsource.c (tui_display_main)
2730         (tui_update_source_windows_with_addr)
2731         (tui_update_all_breakpoint_info): Update.
2732         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2733         (new_height_ok, parse_scrolling_args): Update.
2734         * tui/tui-stack.c (tui_show_frame_info): Update.
2735         * tui/tui-data.h (struct tui_list): Remove.
2736         (tui_source_windows): Return a reference to a std::vector.
2737         * tui/tui-data.c (source_windows): Now a std::vector.
2738         (tui_source_windows): Change return type.
2739         (tui_clear_source_windows): Rewrite.
2740         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2741         (tui_free_all_source_wins_content): Rewrite.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2746         (struct tui_data_window, struct tui_cmd_window): Declare
2747         clear_detail method.
2748         * tui/tui-data.c (tui_source_window::clear_detail)
2749         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2750         methods.
2751         (tui_clear_win_detail): Simplify.
2752
2753 2019-06-25  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-layout.c (make_source_window, make_disasm_window)
2756         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2757         Return the new window.
2758         (show_source_disasm_command, show_data)
2759         (show_source_or_disasm_and_command): Update.
2760
2761 2019-06-25  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2764         parameter.  Return the new window.
2765         (show_source_disasm_command): Update and remove NULL check.
2766         (show_source_or_disasm_and_command): Update.
2767
2768 2019-06-25  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2771
2772 2019-06-25  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-data.h (struct tui_win_info): Make constructor
2775         protected.  Make destructor virtual.  Add initializers.
2776         (tui_source_window, tui_data_window, tui_cmd_window): New
2777         classes.
2778         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2779         constructor.  Add "type" parameter.
2780         (tui_source_window, tui_data_window, tui_cmd_window): New
2781         constructors.
2782         (tui_alloc_win_info): Instantiate the appropriate subclass.
2783
2784 2019-06-25  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-win.c (tui_resize_all): Use delete.
2787         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2788         destructor.
2789         (tui_free_window): Don't declare.
2790         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2791         Update.
2792
2793 2019-06-25  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-data.h (struct tui_win_info): Add constructor.
2796         * tui/tui-data.c (tui_alloc_win_info): Use new.
2797         (tui_free_window): Use delete.
2798
2799 2019-06-22  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2802         declare.
2803         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2804
2805 2019-06-22  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2808         declare.
2809         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2810
2811 2019-06-22  Tom de Vries  <tdevries@suse.de>
2812
2813         * dwarf2read.c (create_addrmap_from_aranges)
2814         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2815         instead of '%zu'.
2816
2817 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2818
2819         * dwarf2read.h (dwarf2_section_info_def): Remove.
2820         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2821         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2822         std::vector<dwarf2_section_info>.
2823         (struct dwo_file) <~dwo_file>: Remove.
2824         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2825         types field.
2826         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2827         (dwarf2_read_debug_names): Likewise.
2828         (create_debug_types_hash_table): Change parameter type to
2829         array_view, adjust code accordingly.
2830         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2831         (partial_die_info::fixup): Likewise.
2832         (determine_prefix): Likewise.
2833         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2834
2835 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2836
2837         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2838         gdb_bfd_ref_ptr.
2839         <~dwo_file>: Remove call to gdb_bfd_unref.
2840         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2841         gdb_bfd_ref_ptr::get.
2842
2843 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2844
2845         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2846         type to htab_up.
2847         * dwarf2read.c (struct dwo_file): Initialize fields.
2848         <~dwo_file>: New.
2849         (free_dwo_file): Remove, move content to ~dwo_file.
2850         (struct dwo_file_deleter): Remove.
2851         (dwo_file_up>: Remove custom deleter.
2852         (free_dwo_files): Remove.
2853         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2854         dwo_files.
2855         (process_skeletonless_type_units): Call unique_ptr::get.
2856         (allocate_dwo_file_hash_table): Add deleter to created hash
2857         table.  Change return type to htab_up.
2858         (lookup_dwo_file_slot): Don't memset dwo_file, call
2859         unique_ptr::get.
2860         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2861         (create_dwo_unit_in_dwp_v2): Likewise.
2862         (open_and_init_dwo_file): Likewise.
2863         (free_dwo_file_from_slot): Remove.
2864
2865 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2866
2867         * dwarf2read.h (struct dwarf2_section_info) <readin,
2868         is_virtual>: Change type to bool.
2869         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2870         true instead of 1.
2871
2872 2019-06-19  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-data.h (tui_init_content_element): Don't declare.
2875
2876 2019-06-19  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui-data.h (tui_init_win_info): Don't declare.
2879
2880 2019-06-19  Tom de Vries  <tdevries@suse.de>
2881
2882         * dwarf2read.h (abstract_to_concrete): Change type to
2883         std::unordered_map<sect_offset, std::vector<sect_offset>,
2884         gdb::hash_enum<sect_offset>>.
2885
2886 2019-06-19  Tom Tromey  <tromey@adacore.com>
2887
2888         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2889         EVAL_AVOID_SIDE_EFFECTS specially.
2890
2891 2019-06-19  Tom Tromey  <tromey@adacore.com>
2892
2893         * source-cache.c (highlighter): New global.
2894         (source_cache::get_source_lines): Create a highlighter on demand.
2895
2896 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * defs.h (deprecated_interactive_hook): Delete declaration.
2899         * interps.c (clear_interpreter_hooks): Remove use of
2900         deprecated_interactive_hook.
2901         * top.c (deprecated_interactive_hook): Delete definition.
2902         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2903
2904 2019-06-18  Tom de Vries  <tdevries@suse.de>
2905
2906         PR gdb/24515
2907         * dwarf2read.h (abstract_to_concrete): Change type from
2908         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2909         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2910         * dwarf2read.c (read_variable): Update.
2911         (dwarf2_fetch_die_loc_sect_off): Update.
2912
2913 2019-06-17  Tom de Vries  <tdevries@suse.de>
2914
2915         PR gdb/24617
2916         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2917         accessing parent[parent_len - 1].
2918
2919 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2920
2921         PR gdb/24364
2922         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2923         call dtrace_process_dof with NULL dof.
2924
2925 2019-06-16  Tom de Vries  <tdevries@suse.de>
2926
2927         PR gdb/24445
2928         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2929
2930 2019-06-16  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2933         (make_all_visible): Use address of member.
2934
2935 2019-06-16  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2938         (tui_free_window, free_content, free_content_elements): Remove
2939         unnecessary cast.
2940         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2941         cast.
2942         * tui/tui-regs.c (tui_show_register_group)
2943         (tui_display_registers_from, tui_display_reg_element_at_line):
2944         Remove unnecessary cast.
2945
2946 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         * linux-nat.c (normal_mask): Delete.
2949         (_initialize_linux_nat): Don't initialise normal_mask.
2950
2951 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2952
2953         PR gdb/24445
2954         * dwarf-index-write.h (write_psymtabs_to_index): Add
2955         dwz_basename parameter.
2956         * dwarf-index-write.c (write_gdbindex): Move file writing to
2957         write_gdbindex_1.  Change return type void.
2958         (assert_file_size): Move up, remove filename parameter.
2959         (write_gdbindex_1): New function.
2960         (write_debug_names): Change return type to void, call
2961         assert_file_size.
2962         (struct index_wip_file): New struct.
2963         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2964         file logic to index_wip_file.  Write index for dwz file if
2965         needed.
2966         (save_gdb_index_command): Pass basename of dwz file, if present.
2967         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2968         build-id of dwz file, if present.
2969         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2970         (dwarf2_get_dwz_file): Likewise.
2971         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2972         (dwarf2_get_dwz_file): Likewise.
2973
2974 2019-06-16  Tom Tromey  <tom@tromey.com>
2975
2976         * coffread.c (process_coff_symbol): Use xstrdup.
2977         * value.c (create_internalvar): Use xstrdup.
2978
2979 2019-06-16  Tom Tromey  <tom@tromey.com>
2980
2981         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2982         * breakpoint.c (stopin_command, stopat_command)
2983         (until_break_command, decode_location_default): Remove unnecessary
2984         cast.
2985         * utils.c (subset_compare): Remove unnecessary cast.
2986         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2987         cast.
2988         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2989         cast.
2990         * infcmd.c (path_command): Remove unnecessary cast.
2991         * coffread.c (decode_type): Remove unnecessary cast.
2992         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2993         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2994         * tui/tui-stack.c (tui_show_locator_content)
2995         (tui_show_frame_info): Remove unnecessary cast.
2996         * tui/tui-win.c (tui_scroll_forward_command)
2997         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2998         (parse_scrolling_args): Remove unnecessary cast.
2999         * tui/tui-data.c (init_win_info, tui_del_window)
3000         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3001         (free_content_elements): Remove unnecessary cast.
3002         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3003         unnecessary cast.
3004         * tui/tui-source.c (tui_set_source_content)
3005         (tui_vertical_source_scroll): Remove unnecessary cast.
3006         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3007         cast.
3008         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3009         * tui/tui-regs.c (tui_display_registers_from)
3010         (tui_display_register): Remove unnecessary cast.
3011         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3012         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3013         (make_visible): Remove unnecessary cast.
3014         * tui/tui-winsource.c (tui_erase_source_content)
3015         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3016         unnecessary cast.
3017         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3018         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3019         * stabsread.c (read_type, read_array_type, read_range_type):
3020         Remove unnecessary cast.
3021         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3022         (parse_symbol, parse_type, upgrade_type, parse_external)
3023         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3024         unnecessary cast.
3025         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3026
3027 2019-06-16  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-data.c (tui_alloc_generic_win_info)
3030         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3031         checks.
3032
3033 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3034             Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * f-typeprint.c (f_print_type): Don't return early for not
3037         associated or not allocated types.
3038         (f_type_print_varspec_suffix): Add print_rank parameter and print
3039         ranks of array types in case they dangling.
3040         (f_type_print_base): Add print_rank parameter.
3041
3042 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3043
3044         * NEWS: Mention new MI commands.
3045         * break-catch-throw.c (enum exception_event_kind): Move to
3046         breakpoint.h.
3047         (print_mention_exception_catchpoint): Output text as a single
3048         message.
3049         (catch_exception_command_1): Rename to...
3050         (catch_exception_event): ...this, make non-static, update header
3051         command, and change some parameter types.
3052         (catch_catch_command): Update for changes to
3053         catch_exception_command_1.
3054         (catch_throw_command): Likewise.
3055         (catch_rethrow_command): Likewise.
3056         * breakpoint.c (enum exception_event_kind): Delete.
3057         * breakpoint.h (enum exception_event_kind): Moved here from
3058         break-catch-throw.c.
3059         (catch_exception_event): Declare.
3060         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3061         (mi_cmd_catch_throw): New function.
3062         (mi_cmd_catch_rethrow): New function.
3063         (mi_cmd_catch_catch): New function.
3064         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3065         'catch-catch' entries.
3066         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3067         (mi_cmd_catch_rethrow): Declare.
3068         (mi_cmd_catch_catch): Declare.
3069
3070 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * annotate.c (annotate_source_line): Change return type to void,
3073         update implementation to match.
3074         * annotate.h (annotate_source_line): Change return type to void,
3075         update header comment.
3076         * stack.c (print_frame_info): Don't change what frame information
3077         is printed based on whether annotations are on or not.
3078
3079 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3082         (annotate_source): Make static.
3083         (annotate_source_line): Moved from source.c and renamed from
3084         identify_source_line.  Update the return type.
3085         * annotate.h (annotate_source): Delete declaration.
3086         (annotate_source_line): Declaration moved from source.h, and
3087         renamed from identify_source_line.  Return type updated.
3088         * source.c (identify_source_line): Moved to annotate.c and renamed
3089         to annotate_source_line.
3090         (info_line_command): Remove check of annotation_level.
3091         * source.h (identify_source_line): Move declaration to annotate.h
3092         and rename to annotate_source_line.
3093         * stack.c: Add 'annotate.h' include.
3094         (print_frame_info): Remove check of annotation_level before
3095         calling annotate_source_line.
3096
3097 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * source-cache.c (source_cache::get_plain_source_lines): Use
3100         open_source_file_with_line_charpos instead of just
3101         open_source_file, remove call to find_source_lines.
3102         (source_cache::get_source_lines): Likewise.
3103         * source.c (find_source_lines): Make static.
3104         (get_filename_and_charpos): Renamed into...
3105         (open_source_file_with_line_charpos): ..this along with changes to
3106         return a scoped_fd, and some other minor clean ups.
3107         (identify_source_line): Use open_source_file_with_line_charpos.
3108         (search_command_helper): Use open_source_file_with_line_charpos
3109         instead of just open_source_file, remove call to
3110         find_source_lines.
3111         * source.h (open_source_file_with_line_charpos): Declare new
3112         function.
3113         (find_source_lines): Delete declaration.
3114
3115 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3116
3117         * source.c (get_filename_and_charpos): Remove fullname
3118         parameter.
3119         (identify_source_line): Update call to get_filename_and_charpos.
3120
3121 2019-06-14  Tom Tromey  <tromey@adacore.com>
3122
3123         PR gdb/24502:
3124         * ui-style.h (skip_ansi_escape): Update comment.
3125         * ui-file.h (class no_terminal_escape_file): New class.
3126         * ui-file.c (no_terminal_escape_file::write)
3127         (no_terminal_escape_file::puts): New methods.
3128         * cli/cli-logging.c (handle_redirections): Use
3129         no_terminal_escape_file.
3130
3131 2019-06-14  Tom Tromey  <tromey@adacore.com>
3132
3133         * NEWS: Move convenience variable news above Python news.
3134
3135 2019-06-14  Tom Tromey  <tom@tromey.com>
3136
3137         * gnulib: Move directory to top-level.
3138         * configure.ac: Don't configure gnulib.
3139         * configure: Rebuild.
3140         * common/common-defs.h: Use new path to gnulib.
3141         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3142         (GNULIB_H): Remove.
3143         (INCGNU): Look in new gnulib location.
3144         (HFILES_NO_SRCDIR): Remove gnulib files.
3145         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3146         (generated_files): Remove GNULIB_H.
3147         ($(LIBGNU), all-lib): Remove targets.
3148         (distclean): Don't mention GNULIB_BUILDDIR.
3149         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3150
3151 2019-06-14  Tom Tromey  <tromey@adacore.com>
3152
3153         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3154         Warn if symbol file does not provide any symbols.
3155
3156 2019-06-14  Tom Tromey  <tromey@adacore.com>
3157
3158         * source.c (find_and_open_source): Respect basenames_may_differ.
3159
3160 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * annotate.c (annotate_breakpoints_invalid): Make use of
3163         scoped_restore_terminal_state.
3164         (annotate_frames_invalid): Likewise.
3165
3166 2019-06-14  Tom Tromey  <tromey@adacore.com>
3167
3168         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3169         allow assignment to an internalvar.
3170
3171 2019-06-14  Tom Tromey  <tromey@adacore.com>
3172
3173         * ada-lex.l: Allow "_" in attribute names.
3174
3175 2019-06-14  Tom Tromey  <tromey@adacore.com>
3176
3177         PR gdb/24653:
3178         * regcache.c (registers_changed): Don't call alloca.
3179         * top.c (execute_command): Don't call alloca.
3180
3181 2019-06-13  Pedro Alves  <palves@redhat.com>
3182
3183         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3184         'expression'.  When parsing an expression, error out if there's
3185         junk after "unlimited".
3186         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3187         (do_set_command): Adjust calls to is_unlimited_literal.
3188
3189 2019-06-13  Pedro Alves  <palves@redhat.com>
3190
3191         * compile/compile.c (make_compile_options_def_group): Add braces
3192         around array_view initializer.
3193         * thread.c (make_thread_apply_all_options_def_group)
3194         (make_thread_apply_all_options_def_group): Likewise.
3195
3196 2019-06-13  Pedro Alves  <palves@redhat.com>
3197
3198         * NEWS (New commands): Mention "maint test-options
3199         require-delimiter", "maint test-options unknown-is-error", "maint
3200         test-options unknown-is-operand" and "maint show
3201         test-options-completion-result".
3202         (New command options, command completion): New section.
3203         (Completion improvements): New section.
3204         Mention that you can abbreviate "unlimited".
3205
3206 2019-06-13  Pedro Alves  <palves@redhat.com>
3207
3208         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3209         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3210         * unittests/cli-utils-selftests.c (test_parse_flags)
3211         (test_parse_flags_qcs): Delete.
3212         (test_cli_utils): Don't call deleted functions.
3213
3214 2019-06-13  Pedro Alves  <palves@redhat.com>
3215
3216         * thread.c: Include "cli/cli-option.h".
3217         (tp_array_compar_ascending): Global.
3218         (tp_array_compar): Delete function.
3219         (tp_array_compar_ascending, tp_array_compar_descending): New
3220         functions.
3221         (ascending_option_def, qcs_flag_option_def)
3222         (thr_qcs_flags_option_defs)
3223         (make_thread_apply_all_options_def_group)
3224         (make_thread_apply_options_def_group): New.
3225         (thread_apply_all_command): Use gdb::option::process_options.
3226         (thread_apply_command_completer)
3227         (thread_apply_all_command_completer): New.
3228         (thread_apply_command): Use gdb::option::process_options.
3229         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3230         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3231         to generate help text of "thread apply".  Adjust "taas"'s help.
3232         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3233         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3234
3235 2019-06-13  Pedro Alves  <palves@redhat.com>
3236
3237         * thread.c (thread_apply_command): Check for invalid TID with
3238         isdigit instead of !isalpha.
3239
3240 2019-06-13  Pedro Alves  <palves@redhat.com>
3241
3242         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3243         (validate_flags_qcs): New.
3244         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3245         (validate_flags_qcs): Declare.
3246         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3247         (make_frame_apply_options_def_group): New.
3248         (frame_apply_command_count): Process options with
3249         gdb::option::process_options.
3250         (frame_apply_completer): New.
3251         (frame_apply_level_completer, frame_apply_all_completer)
3252         (frame_apply_completer): New.
3253         (_initialize_stack): Update help of "frame apply", "frame apply
3254         level", "frame apply all" and "faas" to mention supported options
3255         and install command completers.
3256         * stack.h (frame_apply_all_completer): Declare.
3257         * thread.c: Include "stack.h".
3258         (tfaas_command): Add "--".
3259         (_initialize_thread): Update help "tfaas" to mention supported
3260         options and install command completer.
3261
3262 2019-06-13  Pedro Alves  <palves@redhat.com>
3263
3264         * completer.c (complete_nested_command_line): New.
3265         (gdb_completion_word_break_characters_throw): Add assertion.
3266         * completer.h (complete_nested_command_line): Declare.
3267
3268 2019-06-13  Pedro Alves  <palves@redhat.com>
3269
3270         * stack.c (parse_backtrace_qualifiers): New.
3271         (backtrace_command): Use it.
3272         (backtrace_command_completer): Complete on qualifiers.
3273
3274 2019-06-13  Pedro Alves  <palves@redhat.com>
3275
3276         * frame.c: Include "cli/cli-option.h.
3277         (user_set_backtrace_options): New.
3278         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3279         Delete.
3280         (get_prev_frame): Adjust.
3281         (boolean_option_def, uinteger_option_def)
3282         (set_backtrace_option_defs): New.
3283         (_initialize_frame): Adjust and use
3284         gdb::option::add_setshow_cmds_for_options to install "set
3285         backtrace past-main" and "set backtrace past-entry".
3286         * frame.h: Include "cli/cli-option.h".
3287         (struct frame_print_options): Forward declare.
3288         (print_frame_arguments_all, print_frame_arguments_scalars)
3289         (print_frame_arguments_none): Declare.
3290         (print_entry_values): Delete declaration.
3291         (struct frame_print_options, user_frame_print_options): New.
3292         (struct set_backtrace_options): New.
3293         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3294         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3295         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3296         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3297         (list_args_or_locals): Add frame_print_options parameter.
3298         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3299         * python/py-framefilter.c (enumerate_args): Pass down
3300         USER_FRAME_PRINT_OPTIONS.
3301         * stack.c: Include "cli/cli-option.h".
3302         (print_frame_arguments_all, print_frame_arguments_scalars)
3303         (print_frame_arguments_none): Declare.
3304         (print_raw_frame_arguments, print_entry_values): Delete.
3305         (user_frame_print_options): New.
3306         (boolean_option_def, enum_option_def, frame_print_option_defs):
3307         New.
3308         (struct backtrace_cmd_options): New.
3309         (bt_flag_option_def): New.
3310         (backtrace_command_option_defs): New.
3311         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3312         (print_frame_arg, read_frame_arg, print_frame_args)
3313         (print_frame_info, print_frame): Add frame_print_options parameter
3314         and use it.
3315         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3316         (backtrace_command_1): Add frame_print_options and
3317         backtrace_cmd_options parameters and use them.
3318         (make_backtrace_options_def_group): New.
3319         (backtrace_command): Process command options with
3320         gdb::option::process_options.
3321         (backtrace_command_completer): New.
3322         (_initialize_stack): Extend "backtrace"'s help to mention
3323         supported options.  Install completer for "backtrace".
3324         Install some settings commands with add_setshow_cmds_for_options.
3325
3326 2019-06-13  Pedro Alves  <palves@redhat.com>
3327
3328         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3329         and that "set/show print raw frame-arguments" are now deprecated.
3330
3331         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3332         command.
3333         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3334         * stack.c (_initialize_stack): Install "set/show print
3335         raw-frame-arguments", and deprecate "set/show print raw
3336         frame-arguments".
3337         * valprint.c (_initialize_valprint): Deprecate "set/show print
3338         raw".
3339
3340 2019-06-13  Pedro Alves  <palves@redhat.com>
3341
3342         * compile/compile.c (struct compile_options): New.
3343         (compile_flag_option_def, compile_command_option_defs)
3344         (make_compile_options_def_group): New.
3345         (compile_file_command): Handle options with
3346         gdb::option::process_options.
3347         (compile_file_command_completer): New function.
3348         (compile_code_command): Handle options with
3349         gdb::option::process_options.
3350         (compile_code_command_completer): New function.
3351         (_initialize_compiler): Install completers for "compile code" and
3352         "compile file".  Mention available options in "compile code" and
3353         "compile code"'s help.
3354         * completer.c (advance_to_completion_word): New, factored out from
3355         ...
3356         (advance_to_expression_complete_word_point): ... this.
3357         (advance_to_filename_complete_word_point): New.
3358         * completer.h (advance_to_filename_complete_word_point): New
3359         declaration.
3360
3361 2019-06-13  Pedro Alves  <palves@redhat.com>
3362
3363         * compile/compile.c: Include "cli/cli-option.h".
3364         (compile_print_value): Scope data pointer is now a
3365         value_print_options pointer; adjust.
3366         (compile_print_command): Process options.  Scope data pointer is
3367         now a value_print_options pointer; adjust.
3368         (_initialize_compile): Update "compile print"'s help to include
3369         supported options.  Install a completer for "compile print".
3370         * cp-valprint.c (show_vtblprint, show_objectprint)
3371         (show_static_field_print): Delete.
3372         (_initialize_cp_valprint): Don't install "set print
3373         static-members", "set print vtbl", "set print object" here.
3374         * printcmd.c: Include "cli/cli-option.h" and
3375         "common/gdb_optional.h".
3376         (print_command_parse_format): Rework to fill in a
3377         value_print_options instead of a format_data.
3378         (print_value): Change parameter type from format_data pointer to
3379         value_print_options reference.  Adjust.
3380         (print_command_1): Process options.  Adjust to pass down a
3381         value_print_options.
3382         (print_command_completer): New.
3383         (_initialize_printcmd): Install print_command_completer as
3384         handle_brkchars completer for the "print" command.  Update
3385         "print"'s help to include supported options.
3386         * valprint.c: Include "cli/cli-option.h".
3387         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3388         here from cp-valprint.c.
3389         (boolean_option_def, uinteger_option_def)
3390         (value_print_option_defs, make_value_print_options_def_group):
3391         New.  Use gdb::option::add_setshow_cmds_for_options to install
3392         "set print elements", "set print null-stop", "set print repeats",
3393         "set print pretty", "set print union", "set print array", "set
3394         print address", "set print symbol", "set print array-indexes".
3395         * valprint.h: Include <string> and "cli/cli-option.h".
3396         (make_value_print_options_def_group): Declare.
3397         (print_value): Change parameter type from format_data pointer to
3398         value_print_options reference.
3399         (print_command_completer): Declare.
3400
3401 2019-06-13  Pedro Alves  <palves@redhat.com>
3402
3403         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3404         (COMMON_SFILES): Add maint-test-settings.c.
3405         * cli/cli-decode.c (boolean_enums): New global, factored out from
3406         ...
3407         (add_setshow_boolean_cmd): ... here.
3408         * cli/cli-decode.h (boolean_enums): Declare.
3409         * cli/cli-option.c: New file.
3410         * cli/cli-option.h: New file.
3411         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3412         factored out from ...
3413         (parse_cli_boolean_value(const char *)): ... this.
3414         (is_unlimited_literal): Change parameter type to pointer to
3415         pointer.  Adjust and advance ARG pointer.
3416         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3417         (parse_cli_var_enum): New, factored out from ...
3418         (do_set_command): ... this.  Adjust.
3419         * cli/cli-setshow.h (parse_cli_boolean_value)
3420         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3421         (parse_cli_var_enum): Declare.
3422         * cli/cli-utils.c: Include "cli/cli-option.h".
3423         (get_ulongest): New.
3424         * cli/cli-utils.h (get_ulongest): Declare.
3425         (check_for_argument): New overloads.
3426         * maint-test-options.c: New file.
3427
3428 2019-06-13  Pedro Alves  <palves@redhat.com>
3429
3430         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3431         parse a range if "-" is at the end of the string.
3432
3433 2019-06-13  Pedro Alves  <palves@redhat.com>
3434
3435         * cli/cli-setshow.c (parse_auto_binary_operation)
3436         (parse_cli_boolean_value): Don't allow "o".
3437
3438 2019-06-13  Pedro Alves  <palves@redhat.com>
3439
3440         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3441         * NEWS: Mention maint test-settings KIND.
3442         * maint-test-settings.c: New file.
3443
3444 2019-06-13  Pedro Alves  <palves@redhat.com>
3445
3446         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3447         completer.
3448         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3449         "set" completers.
3450
3451 2019-06-13  Pedro Alves  <palves@redhat.com>
3452
3453         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3454         after item.
3455
3456 2019-06-13  Pedro Alves  <palves@redhat.com>
3457
3458         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3459
3460 2019-06-13  Pedro Alves <palves@redhat.com>
3461
3462         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3463         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3464         call.
3465         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3466         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3467         calls.
3468         (check_for_argument): Skip spaces after argument.
3469
3470 2019-06-13  Pedro Alves  <palves@redhat.com>
3471
3472         * thread.c (thread_apply_command): Adjust TID parsing.
3473         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3474         detected before end of string.
3475         (tid_is_in_list): Error out if LIST is invalid.
3476
3477 2019-06-13  Pedro Alves  <palves@redhat.com>
3478
3479         * completer.c (complete_line_internal_1): Rewind completion word
3480         point.
3481         (completion_tracker::advance_custom_word_point_by): Change
3482         parameter type to int.
3483         * completer.h (completion_tracker::advance_custom_word_point_by):
3484         Likewise.
3485
3486 2019-06-13  Pedro Alves  <palves@redhat.com>
3487
3488         * completer.c (advance_to_completion_word): Handle delimiters.
3489
3490 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3491
3492         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3493
3494 2019-06-11  Tom Tromey  <tom@tromey.com>
3495
3496         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3497         (xmalloc_failed): Move to alloc.c.
3498         * alloc.c: New file.
3499         * Makefile.in (COMMON_SFILES): Add alloc.c.
3500
3501 2019-06-11  Tom Tromey  <tom@tromey.com>
3502
3503         * nat/linux-waitpid.c: Don't include server.h.
3504         (linux_debug): Remove.
3505         (my_waitpid): Update.
3506
3507 2019-06-11  Tom Tromey  <tromey@adacore.com>
3508
3509         * infcall.c (_initialize_infcall): Remove trailing newline from
3510         help.
3511         * user-regs.c (_initialize_user_regs): Remove trailing newline
3512         from help.
3513         * typeprint.c (_initialize_typeprint): Remove trailing newline
3514         from help.
3515         * reverse.c (_initialize_reverse): Remove trailing newlines from
3516         help.
3517         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3518         from help.
3519         * language.c (add_set_language_command): Remove trailing newline
3520         from help.
3521         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3522         help.
3523         * disasm.c (_initialize_disasm): Remove trailing newline from
3524         help.
3525         * top.c (init_main): Remove trailing newline from help.
3526         * interps.c (_initialize_interpreter): Remove trailing newline
3527         from help.
3528         * btrace.c (_initialize_btrace): Remove trailing newlines from
3529         help.
3530         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3531         from help.
3532         * python/python.c (_initialize_python): Remove trailing newline
3533         from help.
3534         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3535         help.
3536         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3537         from help.  Reformat some text.
3538         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3539         from help.
3540         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3541         newline from help.
3542
3543 2019-06-11  Tom Tromey  <tromey@adacore.com>
3544
3545         * darwin-nat.c (darwin_decode_exception_message)
3546         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3547
3548 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3549
3550         * valops.c (value_slice): Check for not allocated or not
3551         associated values.
3552
3553 2019-06-10  Tom de Vries  <tdevries@suse.de>
3554
3555         PR gdb/24618
3556         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3557         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3558         invalid.
3559
3560 2019-06-10  Tom de Vries  <tdevries@suse.de>
3561
3562         PR gdb/24611
3563         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3564         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3565
3566 2019-06-10  Tom de Vries  <tdevries@suse.de>
3567
3568         PR symtab/24545
3569         * symtab.c (struct demangled_name_entry): Add language field.
3570         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3571         static minimal symbol".  Set and use language field.
3572
3573 2019-06-10  Tom Tromey  <tromey@adacore.com>
3574
3575         * ada-lang.c (_initialize_ada_language): Update help text.
3576
3577 2019-06-10  Tom Tromey  <tromey@adacore.com>
3578
3579         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3580         with a newline.
3581         * guile/guile.c (handle_boot_error): Don't end warning with a
3582         newline.
3583         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3584         warning with a newline.
3585         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3586         newline.
3587         (s12z_frame_cache): Likewise.
3588         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3589         a newline.
3590         * solib-svr4.c (disable_probes_interface): Don't end warning with
3591         a newline.
3592         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3593         newline.
3594         * python/python.c (do_finish_initialization): Don't end warning
3595         with a newline.
3596
3597 2019-06-10  Tom Tromey  <tom@tromey.com>
3598
3599         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3600         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3601         gdbpy_enter.
3602
3603 2019-06-10  Tom Tromey  <tromey@adacore.com>
3604
3605         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3606         data.
3607         (elf_new_init): Don't call stabsread_new_init.
3608         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3609         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3610         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3611
3612 2019-06-10  Tom de Vries  <tdevries@suse.de>
3613
3614         PR symtab/16264
3615         PR symtab/24517
3616         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3617
3618 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3619
3620         * source.c (find_and_open_source): Also rewrite relative file
3621         names.
3622
3623 2019-04-26  Amos Bird  <amosbird@gmail.com>
3624
3625         * annotate.c (annotate_thread_exited): Add "thread-exited"
3626         annotation.
3627
3628 2019-06-06  Tom Tromey  <tromey@adacore.com>
3629
3630         * maint.h (class scoped_command_stats): Use
3631         DISABLE_COPY_AND_ASSIGN.
3632         <print_time>: New method.
3633         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3634         print_time.
3635         (scoped_command_stats::print_time): New method.
3636
3637 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3638
3639         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3640         instructions of lengths 6 or 8 bytes.
3641
3642 2019-06-04  Pedro Alves  <palves@redhat.com>
3643
3644         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3645
3646         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3647         * breakpoint.c (condition_completer): Likewise.
3648         * cli/cli-dump.c (scan_expression): Likewise.
3649         * common/filestuff.c (mkdir_recursive): Likewise.
3650         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3651         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3652         (gdb_abspath): Likewise.
3653         * compile/compile-cplus-types.c
3654         (compile_cplus_instance::decl_name): Likewise.
3655         * completer.c (complete_explicit_location):
3656         (signal_completer, reg_or_group_completer_1): Likewise.
3657         * cp-support.c (cp_remove_params_if_any): Likewise.
3658         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3659         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3660         * infcmd.c (strip_bg_char): Likewise.
3661         * linespec.c (copy_token_string): Likewise.
3662         * mi/mi-main.c (output_cores): Likewise.
3663         * psymtab.c (psymtab_search_name):
3664         * symfile.c (test_set_ext_lang_command): Likewise.
3665         * target.c (target_fileio_read_stralloc): Likewise.
3666         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3667         * value.c (complete_internalvar): Likewise.
3668
3669 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3670
3671         Add objfile property to gdb.Type.
3672         * NEWS: Mention Python API addition.
3673         * python/py-type.c (typy_get_objfile): New method.
3674
3675 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3676
3677         * NEWS: Mention the new set|show style [title|highlight].
3678         Mention changes to "show style", "help" and "apropos".
3679
3680 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3681
3682         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3683         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3684         instead of print_help_for_command.
3685         (print_doc_of_command): New function.
3686         (help_list): Add 'apropos -v word' suggestion.
3687         (print_help_for_command): Style the command name using title style.
3688         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3689         (_initialize_cli_cmds): Describe -v in apropos_command help.
3690
3691 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3692
3693         * cli/cli-style.h (cli_style_option): Add name in constructor,
3694         add m_name class member, add constructor with intensity,
3695         add name class function.
3696         (cli_style_option::add_setshow_commands): Remove name argument.
3697         (highlight_style, title_style): New styles.
3698         * cli/cli-style.c (do_show): New function that shows a style
3699         characteristic styling the style name with itself.
3700         (set_style_name): New function.
3701         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3702         Update all callers according to the changes in cli/cli-style.h.
3703         * utils.h (fputs_highlighted): New function.
3704         * utils.c (fputs_highlighted): Likewise.
3705
3706 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3707
3708         * NEWS: Mention new pipe command and new convenience variables.
3709
3710 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3711
3712         * cli/cli-cmds.c (pipe_command): New function.
3713         (_initialize_cli_cmds): Call add_com for pipe_command.
3714         Define | as an alias for pipe.
3715         (exit_status_set_internal_vars): New function.
3716         (shell_escape): Call exit_status_set_internal_vars.
3717         cli/cli-decode.c (find_command_name_length): Recognize | as
3718         a single character command.
3719
3720 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3721
3722         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3723         top.c (execute_command_to_ui_file): New function, mostly a copy
3724         of execute_command_to_string.
3725         (execute_command_to_string): Implement by calling
3726         execute_command_to_ui_file.
3727
3728 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3729
3730         * top.h (saved_command_line): Remove declaration.
3731         * top.c (previous_saved_command_line, previous_repeat_arguments):
3732         New variables.
3733         (saved_command_line): Make static, define together with other
3734         'repeat variables'.
3735         (dont_repeat): Clear repeat_arguments.
3736         (repeat_previous, get_saved_command_line, save_command_line):
3737         New functions.
3738         (gdb_init): Initialize saved_command_line
3739         and previous_saved_command_line.
3740         * main.c (captured_main_1): Remove saved_command_line initialization.
3741         * event-top.c (handle_line_of_input): Update to use
3742         the new 'repeat' related functions instead of direct access to
3743         saved_command_line.
3744         * command.h (repeat_previous, get_saved_command_line,
3745         save_command_line): New declarations.
3746         (dont_repeat): Add comment.
3747
3748 2019-05-30  Tom Tromey  <tromey@adacore.com>
3749
3750         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3751         Fix comment.
3752         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3753
3754 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3755
3756         PR cli/24587
3757         * completer.c (complete): Initialize variable word.
3758
3759 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3760
3761         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3762         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3763         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3764         'body' is NULL to the outter 'if', protecting the '!is_define'
3765         situation as well.
3766
3767 2019-05-29  Tom Tromey  <tromey@adacore.com>
3768
3769         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3770         (dwarf_unknown): New function.
3771         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3772         (dwarf_type_encoding_name): Use dwarf_unknown.
3773
3774 2019-05-29  Tom Tromey  <tromey@adacore.com>
3775
3776         PR c++/20020:
3777         * cp-valprint.c (cp_print_value_fields): Call
3778         cp_print_static_field inside "try".
3779
3780 2019-05-29  Tom Tromey  <tromey@adacore.com>
3781
3782         * inflow.c (struct terminal_info): Add default operator=.
3783         * configure: Rebuild.
3784         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3785         -Wdeprecated-copy-dtor, -Wredundant-move.
3786
3787 2019-05-29  Tom Tromey  <tromey@adacore.com>
3788
3789         * NEWS: Add entry.
3790         * infcmd.c (print_return_value_1): Handle finish_print
3791         option.
3792         (show_print_finish): New function.
3793         (_initialize_infcmd): Add "set/show print finish" commands.
3794         * valprint.c (user_print_options): Initialize new member.
3795         * valprint.h (struct value_print_options) <finish_print>: New
3796         member.
3797
3798 2019-05-28  Tom Tromey  <tromey@adacore.com>
3799
3800         * ada-lang.c (ada_remove_Xbn_suffix)
3801         (find_old_style_renaming_symbol)
3802         (parse_old_style_renaming): Remove.
3803         (ada_find_renaming_symbol): Don't call
3804         find_old_style_renaming_symbol.
3805         (ada_is_renaming_symbol): Rename from
3806         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3807         bool.  Now static.
3808         (ada_read_var_value): Update and simplify.
3809         * ada-exp.y (write_var_or_type): Remove old code.
3810
3811 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3812
3813         * event-top.c: Remove include comment.
3814         * inflow.c (class scoped_ignore_sigttou): Move from here...
3815         * inflow.h (class scoped_ignore_sigttou): ...to here.
3816         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3817         * top.c:  Remove include comment.
3818
3819 2019-05-27  Tom Tromey  <tom@tromey.com>
3820
3821         * NEWS: Fix typo.
3822
3823 2019-05-22  Tom Tromey  <tromey@adacore.com>
3824
3825         * target.c (target_follow_exec): Constify parameter.
3826         * target-delegates.c: Rebuild.
3827         * remote.c (remote_target::follow_exec): Constify parameter.
3828         * infrun.c (follow_exec): Constify parameter.
3829         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3830         (target_follow_exec): Likewise.
3831
3832 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3833
3834         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3835         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3836
3837 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3838
3839         * NEWS: Add debugredirect and testsuite sections.
3840
3841 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3842
3843         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3844         target descriptions using exclusively floating point register name
3845         aliases.
3846
3847 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         PR gdb/18644:
3850         * f-lang.c (build_fortran_types): Handle the case where
3851         gdbarch_floatformat_for_type returns a nullptr.
3852
3853 2019-05-21  Tom de Vries  <tdevries@suse.de>
3854
3855         PR cli/24587
3856         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3857
3858 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         PR gdb/18644:
3861         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3862         16-byte floats.
3863         * i386-tdep.c (i386_floatformat_for_type): Use
3864         floatformats_ia64_quad for the 16-byte floating point component
3865         within a fortran 32-byte complex number.
3866
3867 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3870         delete default constructor.
3871         (find_partial_die): Update to return const struct.
3872         (partial_die_parent_scope): Move variable declaration into scope
3873         of its use and change its type to auto.
3874         (guess_partial_die_structure_name): Likewise.
3875         (partial_die_info::fixup): Likewise.
3876
3877 2019-05-17  Tom Tromey  <tromey@adacore.com>
3878
3879         * source.c (find_and_open_source): Remove cast.
3880
3881 2019-05-17  Tom Tromey  <tromey@adacore.com>
3882
3883         * annotate.c (annotate_source): Make "filename" const.
3884         * annotate.h (annotate_source): Use const.
3885
3886 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3887
3888         * disasm.c (set_disassembler_options): Send errors to stderr.
3889
3890 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3891
3892         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3893         (cli_interp_base::set_logging): Check debug_redirect.
3894         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3895         * cli/cli-logging.c (debug_redirect): Add static variable.
3896         (pop_output_files): Add default param.
3897         (handle_redirections): Print debug setting.
3898         (show_logging_command): Likewise.
3899         (_initialize_cli_logging): Add debugredirect command.
3900         * interps.c (current_interp_set_logging): Add debug_redirect
3901         parameter.
3902         * interps.h (set_logging): Add debug_redirect parameter.
3903         (current_interp_set_logging): Likewise.
3904         * mi/mi-common.h: Likewise.
3905         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3906
3907 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3908             Tom Tromey  <tromey@adacore.com>
3909
3910         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3911         directly.
3912         * cli/cli-interp.h (make_logging_output): Remove declaration.
3913         * cli/cli-logging.c (make_logging_output): Remove function.
3914         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3915         directly.
3916         * ui-file.c (tee_file::tee_file): Remove bools.
3917         (tee_file::~tee_file): Remove deletes.
3918         * ui-file.h (tee_file): Remove bools.
3919
3920 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3921
3922         * mi/mi-cmds.h (mi_cmd_complete): New function.
3923         * mi/mi-main.c (mi_cmd_complete): Likewise.
3924         * mi/mi-cmds.c: Define new MI command -complete.
3925         * NEWS: Mention new -complete command.
3926
3927 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3928
3929         * completer.h (complete): New function.
3930         * completer.c (complete): Likewise.
3931         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3932         function defined in completer.h.
3933
3934 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3935
3936         * MAINTAINERS (Write After Approval): Add myself.
3937
3938 2019-05-17  Tom de Vries  <tdevries@suse.de>
3939
3940         PR gdb/24094
3941         * dwarf2read.c (struct cu_partial_die_info): New struct.
3942         (find_partial_die): Return cu_partial_die_info.
3943         (partial_die_parent_scope, guess_partial_die_structure_name)
3944         (partial_die_info::fixup): Handle new return type of find_partial_die.
3945
3946 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3947
3948         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3949         "std::string", simplifying the algorithm.
3950
3951 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3952
3953         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3954         (stap_static_probe_ops::get_probes): Likewise.
3955
3956 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3957
3958         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3959         '-')" and "else if".
3960         (stap_parse_single_operand): Join checks for
3961         "gdbarch_stap_parse_special_token_p" and
3962         "gdbarch_stap_parse_special_token" in the same "if" statement.
3963         Invert check when verifying for operation on register
3964         displacement.
3965
3966 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3967
3968         * stap-probe.c (stap_get_opcode): Update comment.
3969         (stap_get_expected_argument_type): Likewise.
3970         (handle_stap_probe): Likewise.
3971
3972 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3973
3974         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3975         return type to 'bool'.  Adjust comment.  Use 'bool' when
3976         appropriate.
3977         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3978         * stap-probe.c (stap_parse_argument_1): Likewise.
3979         (stap_is_operator): Likewise.
3980         (stap_is_generic_prefix): Likewise.
3981         (stap_is_register_prefix): Likewise.
3982         (stap_is_register_indirection_prefix): Likewise.
3983         (stap_is_integer_prefix): Likewise.
3984         (stap_generic_check_suffix): Likewise.
3985         (stap_check_integer_suffix): Likewise.
3986         (stap_check_register_suffix): Likewise.
3987         (stap_check_register_indirection_suffix): Likewise.
3988         (stap_parse_register_operand): Likewise.
3989         (stap_parse_single_operand): Likewise.
3990         (stap_parse_argument_1): Likewise.
3991         (stap_probe::get_argument_count): Likewise.
3992         (stap_is_operator): Likewise.
3993
3994 2019-05-16  Tom Tromey  <tromey@adacore.com>
3995
3996         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3997         keyword to foreach.
3998
3999 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4000
4001         * linux-thread-db.c (try_thread_db_load_1): Change return type
4002         to bool.
4003         (try_thread_db_load): Likewise.
4004         (try_thread_db_load_from_pdir_1): Likewise.
4005         (try_thread_db_load_from_pdir): Likewise.
4006         (try_thread_db_load_from_sdir): Likewise.
4007         (try_thread_db_load_from_dir): Likewise.
4008         (thread_db_load_search): Likewise.
4009         (has_libpthread): Likewise.
4010         (thread_db_load): Likewise.
4011
4012 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4013
4014         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4015         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4016         NULL, and complain/return if that's the case.
4017
4018 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4019
4020         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4021         (advance, posn, abstract_read_memory): New functions.
4022         [struct mem_read_abstraction]: New struct.
4023         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4024
4025 2019-05-14  Tom Tromey  <tromey@adacore.com>
4026
4027         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4028         value is not lval_memory.
4029
4030 2019-05-14  Tom Tromey  <tromey@adacore.com>
4031
4032         * solib.c (info_sharedlibrary_command): Style the file name.
4033
4034 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4035
4036         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4037         (aarch64_vnv_type): Likewise.
4038         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4039         * common/tdesc.c: Likewise.
4040         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4041         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4042         * features/aarch64-fpu.xml: Add ieee half view.
4043         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4044         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4045         * gdbtypes.h (struct builtin_type): Likewise.
4046         (struct objfile_type): Likewise.
4047
4048 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4049
4050         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4051         typo.
4052         * location.h (string_to_event_location): Likewise.
4053
4054 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4055
4056         GDB 8.3 released.
4057
4058 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4059
4060         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4061         New variable declaration.
4062         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4063         New variable.
4064         (print_one_breakpoint): Use ui_out::test_flags and new global
4065         variable to compute use_fixed_output.
4066         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4067         Remove.
4068         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4069         (mi_multi_location_breakpoint_output_fixed): Remove.
4070         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4071         new variable.
4072         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4073         fix_multi_location_breakpoint_output flag if version >= 3.
4074         * ui-out.h (enum ui_out_flag)
4075         <fix_multi_location_breakpoint_output>: New enumerator.
4076
4077 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4078
4079         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4080
4081 2019-05-10  Tom Tromey  <tromey@adacore.com>
4082
4083         * ada-lang.c (catch_ada_completer): New function.
4084         (_initialize_ada_language): Use it.
4085
4086 2019-05-10  Tom Tromey  <tromey@adacore.com>
4087
4088         * thread.c (print_thread_info): Make "requested_threads" const.
4089         * gdbthread.h (print_thread_info): Make "requested_threads"
4090         const.
4091         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4092         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * gdbtypes.c (objfile_type_data): Change type.
4097         (objfile_type, _initialize_gdbtypes): Update.
4098
4099 2019-05-08  Tom Tromey  <tom@tromey.com>
4100
4101         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4102         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4103         (_initialize_dwarf2_frame): Update.
4104
4105 2019-05-08  Tom Tromey  <tom@tromey.com>
4106
4107         * objc-lang.c (objc_objfile_data): Change type.
4108         (find_methods): Update.
4109         (_initialize_objc_lang): Remove.
4110
4111 2019-05-08  Tom Tromey  <tom@tromey.com>
4112
4113         * stabsread.c (rs6000_builtin_type_data): Change type.
4114         (rs6000_builtin_type, _initialize_stabsread): Update.
4115
4116 2019-05-08  Tom Tromey  <tom@tromey.com>
4117
4118         * mips-tdep.c (mips_pdr_data): Remove.
4119         (_initialize_mips_tdep): Update.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4124         (hppa_init_objfile_priv_data, read_unwind_info)
4125         (find_unwind_entry, _initialize_hppa_tdep): Update.
4126
4127 2019-05-08  Tom Tromey  <tom@tromey.com>
4128
4129         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4130         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4131         on obstack.
4132         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4133
4134 2019-05-08  Tom Tromey  <tom@tromey.com>
4135
4136         * mdebugread.c (basic_type_data): Change type.
4137         (basic_type, _initialize_mdebugread): Update.
4138
4139 2019-05-08  Tom Tromey  <tom@tromey.com>
4140
4141         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4142
4143 2019-05-08  Tom Tromey  <tom@tromey.com>
4144
4145         * nto-tdep.c (nto_inferior_data_reg): Change type.
4146         (nto_inferior_data): Update.
4147         (nto_inferior_data_cleanup, nto_new_inferior_data)
4148         (_initialize_nto_tdep): Remove.
4149         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4150
4151 2019-05-08  Tom Tromey  <tom@tromey.com>
4152
4153         * ada-lang.c (struct ada_inferior_data): Add initializers.
4154         (ada_inferior_data): Change type.
4155         (ada_inferior_data_cleanup): Remove.
4156         (get_ada_inferior_data, ada_inferior_exit)
4157         (struct ada_pspace_data): Add initializers, destructor.
4158         (ada_pspace_data_handle): Change type.
4159         (get_ada_pspace_data): Update.
4160         (ada_pspace_data_cleanup): Remove.
4161
4162 2019-05-08  Tom Tromey  <tom@tromey.com>
4163
4164         * coffread.c (struct coff_symfile_info): Add initializers.
4165         (coff_objfile_data_key): Move lower.  Change type.
4166         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4167         Update.
4168         (coff_free_info): Remove.
4169
4170 2019-05-08  Tom Tromey  <tom@tromey.com>
4171
4172         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4173         (fbsd_pspace_data_handle): Move lower.  Change type.
4174         (get_fbsd_pspace_data): Update.
4175         (fbsd_pspace_data_cleanup): Remove.
4176         (_initialize_fbsd_tdep): Update.
4177
4178 2019-05-08  Tom Tromey  <tom@tromey.com>
4179
4180         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4181         (get_ada_tasks_pspace_data): Update.
4182         (ada_tasks_pspace_data_cleanup): Remove.
4183         (_initialize_tasks): Update.
4184         (ada_tasks_inferior_data_handle): Change type.
4185         (get_ada_tasks_inferior_data): Update.
4186         (ada_tasks_inferior_data_cleanup): Remove.
4187         (struct ada_tasks_pspace_data): Add initializers.
4188
4189 2019-05-08  Tom Tromey  <tom@tromey.com>
4190
4191         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4192         * symfile-debug.c (debug_sym_get_probes): Change type.
4193         * stap-probe.c (handle_stap_probe):
4194         (stap_static_probe_ops::get_probes): Change type.
4195         * probe.h (class static_probe_ops) <get_probes>: Change type.
4196         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4197         (parse_probes_in_pspace): Update.
4198         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4199         Update.
4200         (any_static_probe_ops::get_probes): Change type.
4201         * elfread.c (elfread_data): New typedef.
4202         (probe_key): Change type.
4203         (elf_get_probes): Likewise.  Update.
4204         (probe_key_free): Remove.
4205         (_initialize_elfread): Update.
4206         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4207         Change type.
4208         (dtrace_process_dof_probe, dtrace_process_dof)
4209         (dtrace_static_probe_ops::get_probe): Change type.
4210
4211 2019-05-08  Tom Tromey  <tom@tromey.com>
4212
4213         * xcoffread.c (struct xcoff_symfile_info): Rename from
4214         coff_symfile_info.  Add initializers.
4215         (xcoff_objfile_data_key): Move lower.  Change type.
4216         (XCOFF_DATA): Rewrite.
4217         (xcoff_free_info): Remove.
4218         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4219         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4220         (xcoff_initial_scan): Update.
4221
4222 2019-05-08  Tom Tromey  <tom@tromey.com>
4223
4224         * solib-svr4.c (struct svr4_info): Add initializers and
4225         destructor.
4226         <probes_table>: Now an htab_up.
4227         (solib_svr4_pspace_data): Change type.
4228         (free_probes_table): Simplify.
4229         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4230         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4231         (probes_table_remove_objfile_probes, register_solib_event_probe)
4232         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4233         (_initialize_svr4_solib): Update.
4234
4235 2019-05-08  Tom Tromey  <tom@tromey.com>
4236
4237         * remote.c (remote_pspace_data): Change type.
4238         (remote_pspace_data_cleanup): Remove.
4239         (get_remote_exec_file, set_pspace_remote_exec_file)
4240         (_initialize_remote): Update.
4241
4242 2019-05-08  Tom Tromey  <tom@tromey.com>
4243
4244         * breakpoint.c (breakpoint_objfile_key): Change type.
4245         (get_breakpoint_objfile_data): Update.
4246         (free_breakpoint_objfile_data): Remove.
4247         (_initialize_breakpoint): Update.
4248
4249 2019-05-08  Tom Tromey  <tom@tromey.com>
4250
4251         * linux-tdep.c (struct linux_info): Add initializers.
4252         (linux_inferior_data): Move.  Change type.
4253         (invalidate_linux_cache_inf): Update.
4254         (linux_inferior_data_cleanup): Remove.
4255         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4256
4257 2019-05-08  Tom Tromey  <tom@tromey.com>
4258
4259         * auxv.c (auxv_inferior_data): Move.  Change type.
4260         (auxv_inferior_data_cleanup): Remove.
4261         (invalidate_auxv_cache_inf): Rewrite.
4262         (get_auxv_inferior_data, _initialize_auxv): Update.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4267         (symfile_debug_objfile_data_key): Change type.
4268         (symfile_debug_installed, debug_qf_has_symbols)
4269         (debug_qf_find_last_source_symtab)
4270         (debug_qf_forget_cached_source_info)
4271         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4272         (debug_qf_print_stats, debug_qf_dump)
4273         (debug_qf_expand_symtabs_for_function)
4274         (debug_qf_expand_all_symtabs)
4275         (debug_qf_expand_symtabs_with_fullname)
4276         (debug_qf_map_matching_symbols)
4277         (debug_qf_expand_symtabs_matching)
4278         (debug_qf_find_pc_sect_compunit_symtab)
4279         (debug_qf_map_symbol_filenames)
4280         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4281         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4282         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4283         (debug_sym_read_linetable, debug_sym_relocate): Update.
4284         (symfile_debug_free_objfile): Remove.
4285         (install_symfile_debug_logging, _initialize_symfile_debug):
4286         Update.
4287
4288 2019-05-08  Tom Tromey  <tom@tromey.com>
4289
4290         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4291         allocate_on_obstack.
4292         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4293         (get_dwarf2_per_objfile): Update.
4294         (set_dwarf2_per_objfile): Remove.
4295         (dwarf2_has_info, dwarf2_get_section_info): Update.
4296         (dwarf2_free_objfile): Remove.
4297         (_initialize_dwarf2_read): Update.
4298
4299 2019-05-08  Tom Tromey  <tom@tromey.com>
4300
4301         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4302         initializers.
4303         <unsupported_script_warning_printed,
4304         script_not_found_warning_printed>: Now bool.
4305         (auto_load_pspace_data): Change type.
4306         (~auto_load_pspace_info): Rename from
4307         auto_load_pspace_data_cleanup.
4308         (get_auto_load_pspace_data, init_loaded_scripts_info)
4309         (clear_section_scripts, maybe_print_unsupported_script_warning)
4310         (maybe_print_script_not_found_warning, _initialize_auto_load):
4311         Update.
4312
4313 2019-05-08  Tom Tromey  <tom@tromey.com>
4314
4315         * objfiles.c (objfile_pspace_info): Add destructor and
4316         initializers.
4317         (objfiles_pspace_data): Change type.
4318         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4319         (get_objfile_pspace_data): Update.
4320         (objfiles_bfd_data): Change type.
4321         (get_objfile_bfd_data): Update.
4322         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4323
4324 2019-05-08  Tom Tromey  <tom@tromey.com>
4325
4326         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4327         Change type.
4328         (get_catch_syscall_inferior_data): Update.
4329         (catch_syscall_inferior_data_cleanup): Remove.
4330         (_initialize_break_catch_syscall): Update.
4331
4332 2019-05-08  Tom Tromey  <tom@tromey.com>
4333
4334         * inflow.c (struct terminal_info): Add destructor and
4335         initializers.
4336         (inflow_inferior_data): Change type.
4337         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4338         (get_inflow_inferior_data, inflow_inferior_exit)
4339         (swap_terminal_info, _initialize_inflow): Update.
4340
4341 2019-05-08  Tom Tromey  <tom@tromey.com>
4342
4343         * target-dcache.c (target_dcache_cleanup): Remove.
4344         (target_dcache_aspace_key): Change type.
4345         (target_dcache_init_p, target_dcache_invalidate)
4346         (target_dcache_get, target_dcache_get_or_init)
4347         (_initialize_target_dcache): Update.
4348         * dcache.h (struct dcache_deleter): New.
4349
4350 2019-05-08  Tom Tromey  <tom@tromey.com>
4351
4352         * symtab.c (struct symbol_cache): Add destructor and
4353         initializers.
4354         (symbol_cache_key): Move.  Change type.
4355         (make_symbol_cache, free_symbol_cache): Remove.
4356         (get_symbol_cache): Update.
4357         (symbol_cache_cleanup): Remove.
4358         (ALL_PSPACES, symbol_cache_flush)
4359         (maintenance_print_symbol_cache)
4360         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4361         Update.
4362
4363 2019-05-08  Tom Tromey  <tom@tromey.com>
4364
4365         * symtab.c (struct main_info): Add destructor and initializers.
4366         (main_progspace_key): Move.  Change type.
4367         (get_main_info): Update.
4368         (main_info_cleanup): Remove.
4369         (_initialize_symtab): Update.
4370
4371 2019-05-08  Tom Tromey  <tom@tromey.com>
4372
4373         * registry.h (DECLARE_REGISTRY): Define the _key class.
4374
4375 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4376
4377         * NEWS: Merge two 'New commands' sections.
4378
4379 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4380
4381         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4382         parameter and use Ada language definition instead.
4383         (ada_val_print_ptr): Remove unused language parameter.
4384         (ada_val_print_num): Remove language parameter and use Ada language
4385         definition instead.
4386         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4387         parameter.
4388         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4389         parameter and use Ada language definition instead.
4390         (ada_val_print_1): Update all ada_val_print_xxx calls.
4391         Remove language parameter.
4392         (ada_val_print): Update ada_val_print_1 call.
4393
4394 2019-05-08  Tom Tromey  <tromey@adacore.com>
4395
4396         * remote.c (remote_hw_watchpoint_limit)
4397         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4398         Now static.
4399
4400 2019-05-08  Tom Tromey  <tromey@adacore.com>
4401
4402         * maint.c (_initialize_maint_cmds): Move initialization code to
4403         remote.c.
4404         (watchdog, show_watchdog): Move to remote.c.
4405         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4406         "watchdog" static.
4407         (_initialize_remote): Move initialization code from maint.c.
4408         * defs.h (watchdog): Don't declare.
4409
4410 2019-05-08  Tom Tromey  <tromey@adacore.com>
4411
4412         * tui/tui-interp.c: Include main.h.
4413         * interps.c: Include main.h.
4414         * main.h (interpreter_p): Declare.
4415         * defs.h (interpreter_p): Don't declare.
4416
4417 2019-05-08  Tom Tromey  <tromey@adacore.com>
4418
4419         * dwarf2loc.c: Include dwarf2read.h.
4420         * defs.h (read_unsigned_leb128): Don't declare.
4421         * dwarf2read.h (read_unsigned_leb128): Declare.
4422
4423 2019-05-08  Tom Tromey  <tromey@adacore.com>
4424
4425         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4426         method.
4427
4428 2019-05-08  Tom Tromey  <tromey@adacore.com>
4429
4430         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4431         when no wrap column is set.
4432
4433 2019-05-08  Tom Tromey  <tromey@adacore.com>
4434
4435         * c-lang.c (c_get_string): Handle non-C-style arrays.
4436
4437 2019-05-08  Tom Tromey  <tromey@adacore.com>
4438
4439         * typeprint.c (print_offset_data::update): Print the bit offset,
4440         not the number of bits remaining.
4441
4442 2019-05-08  Tom Tromey  <tromey@adacore.com>
4443
4444         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4445         padding at end of comment.
4446
4447 2019-05-08  Tom Tromey  <tromey@adacore.com>
4448
4449         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4450         Compare main types.
4451
4452 2019-05-06  Tom Tromey  <tom@tromey.com>
4453
4454         * common/scoped_mmap.c: Include common-defs.h.
4455         * common/scoped_mmap.h: Don't include config.h.
4456
4457 2019-05-04  Tom Tromey  <tom@tromey.com>
4458
4459         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4460         (struct aarch64_call_info): Add initializers.
4461         <si>: Now a std::vector.
4462         (pass_on_stack, aarch64_push_dummy_call): Update.
4463
4464 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4465             Tom Tromey  <tom@tromey.com>
4466
4467         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4468         (ppc_threads): Now a std::vector.  Now static.
4469         (hwdebug_find_thread_points_by_tid)
4470         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4471         Update.
4472
4473 2019-05-04  Tom Tromey  <tom@tromey.com>
4474
4475         * arc-tdep.c (arc_tdesc_init): Return bool.
4476
4477 2019-05-04  Tom Tromey  <tom@tromey.com>
4478
4479         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4480         Use gdb_assert_not_reached.
4481
4482 2019-05-04  Tom Tromey  <tom@tromey.com>
4483
4484         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4485         "false".
4486
4487 2019-05-04  Tom Tromey  <tom@tromey.com>
4488
4489         * arc-tdep.c (arc_tdesc_init): Use bool.
4490
4491 2019-05-04  Tom Tromey  <tom@tromey.com>
4492
4493         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4494
4495 2019-05-04  Tom Tromey  <tom@tromey.com>
4496
4497         * cli/cli-cmds.c (valid_command_p): Return bool.
4498
4499 2019-05-04  Tom Tromey  <tom@tromey.com>
4500
4501         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4502         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4503
4504 2019-05-04  Raul Tambre  <raul@tambre.ee>
4505
4506         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4507         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4508         operator for comparison.
4509
4510 2019-05-04  Tom Tromey  <tom@tromey.com>
4511
4512         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4513         (lookup_partial_symbol, print_partial_symbols)
4514         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4515         (psymbol_compare): Update.
4516         (add_psymbol_to_bcache): Clear the entire psymbol.
4517         (maintenance_check_psymtabs): Update.
4518         * psympriv.h (struct partial_symbol): Don't derive from
4519         general_symbol_info.
4520         <obj_section, unrelocated_address, address,
4521         set_unrelocated_address>: Update.
4522         <ginfo>: New member.
4523         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4524         (debug_names::write_psymbols): Update.
4525
4526 2019-05-04  Tom de Vries  <tdevries@suse.de>
4527
4528         * contrib/cc-with-tweaks.sh: Support -n arg.
4529
4530 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4531
4532         * corelow.c (core_target::detach): Ensure frame cache and
4533         register caches are cleared.
4534         inferior.c (exit_inferior_1): Likewise.
4535
4536 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4537             Tom Tromey  <tom@tromey.com>
4538
4539         * dictionary.c (collate_pending_symbols_by_language): Remove
4540         "struct" from foreach.
4541         * symtab.c (lookup_global_symbol_from_objfile)
4542         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4543         foreach.
4544         * ser-tcp.c (net_open): Remove "struct" from foreach.
4545         * objfiles.c (objfile_relocate, objfile_rebase)
4546         (objfile_has_symbols): Remove "struct" from foreach.
4547         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4548         from foreach.
4549         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4550         foreach.
4551         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4552         "struct" from foreach.
4553         * ada-lang.c (create_excep_cond_exprs)
4554         (ada_exception_catchpoint_cond_string): Remove "struct" from
4555         foreach.
4556
4557 2019-05-03  Tom Tromey  <tromey@adacore.com>
4558
4559         * ada-exp.y (convert_char_literal): Check suffix of each
4560         enumerator.
4561
4562 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4563
4564         PR ada/21406:
4565         * ada-exp.y (yywrap): Don't define.
4566         * ada-lex.l (%option): Add noyywrap
4567         (yywrap): Remove.
4568
4569 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4570
4571         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4572         _WIN32_WINNT to the XP level, unless already defined to a higher
4573         level.
4574
4575         * unittests/parse-connection-spec-selftests.c:
4576         * ser-tcp.c:
4577         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4578         override.
4579
4580         * symfile.c (find_separate_debug_file): Remove colon from the
4581         drive spec of DOS/Windows file names of the target, so that the
4582         file name produced from DEBUGDIR and the target's directory will
4583         be valid on DOS/Windows systems.
4584
4585 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * rust-lang.c (val_print_struct): Handle printing structures
4588         containing strings.
4589
4590 2019-05-02  Tom Tromey  <tromey@adacore.com>
4591
4592         * valarith.c (_initialize_valarith): Remove.
4593
4594 2019-05-01  Tom Tromey  <tromey@adacore.com>
4595
4596         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4597         bitfields.
4598
4599 2019-05-01  Tom Tromey  <tromey@adacore.com>
4600
4601         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4602         for big-endian copies.
4603
4604 2019-04-30  Ali Tamur  <tamur@google.com>
4605         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4606         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4607         (read_3_bytes): New function.
4608
4609 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4610
4611         * windows-nat.c (main_thread_id): Delete.
4612         (handle_output_debug_string): Replace main_thread_id by
4613         current_event.dwThreadId.
4614         (fake_create_process): Likewise.
4615         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4616         Do not set main_thread_id.
4617         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4618         current_event.dwThreadId.
4619         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4620
4621 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4622
4623         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4624         Use current_event.dwThreadId instead of main_thread_id.
4625
4626 2019-04-30  Tom Tromey  <tromey@adacore.com>
4627
4628         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4629         (create_excep_cond_exprs): Iterate over program spaces.
4630         (ada_exception_catchpoint_cond_string): Examine all minimal
4631         symbols for exception types.
4632
4633 2019-04-30  Tom Tromey  <tromey@adacore.com>
4634
4635         PR c++/24470:
4636         * dwarf2read.c (process_structure_scope): Handle case where type
4637         has template parameters but no symbol was created.
4638
4639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4640             Chris January  <chris.january@arm.com>
4641
4642         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4643         qualifier.
4644         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4645
4646 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         * f-typeprint.c (f_print_type): Update rules for printing
4649         whitespace.
4650         (f_type_print_varspec_suffix): Likewise.
4651
4652 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4653             Chris January  <chris.january@arm.com>
4654
4655         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4656         function arguments.
4657
4658 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * f-lang.c (build_fortran_types): Change name of void type to
4661         lower case.
4662         * f-typeprint.c (f_type_print_base): Print the name of the void
4663         type, rather than a fixed string.
4664         * f-valprint.c (f_decorations): Use lower case void string.
4665
4666 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4667             Chris January  <chris.january@arm.com>
4668
4669         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4670         types for Fortran.
4671
4672 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4673             Chris January  <chris.january@arm.com>
4674             David Lecomber  <david.lecomber@arm.com>
4675
4676         * f-exp.y (BINOP_INTRINSIC): New token.
4677         (exp): New parser rule handling BINOP_INTRINSIC.
4678         (f77_keywords): Add new builtin procedures.
4679         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4680         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4681         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4682         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4683         (print_unop_subexp_f): New function.
4684         (print_binop_subexp_f): New function.
4685         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4686         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4687         (dump_subexp_body_f): Likewise.
4688         (operator_check_f): Likewise.
4689         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4690         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4691
4692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4695         UNOP_KIND.
4696         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4697         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4698         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4699         (operator_length_f): New fuction.
4700         (print_subexp_f): New function.
4701         (op_name_f): New function.
4702         (dump_subexp_body_f): New function.
4703         (operator_check_f): New function.
4704         (exp_descriptor_f): Replace standard expression handling functions
4705         with new functions.
4706         * gdb/fortran-operator.def: New file.
4707         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4708         * gdb/std-operator.def: Remove UNOP_KIND.
4709
4710 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4711
4712         * std-operator.def: Remove unbalanced, stray double quote
4713         character.
4714
4715 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4716             Chris January  <chris.january@arm.com>
4717             Daniel Everett  <daniel.everett@arm.com>
4718             Nick Forrington  <nick.forrington@arm.com>
4719             Richard Bunt  <richard.bunt@arm.com>
4720
4721         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4722         of depth when printing anonymous structs or unions.
4723         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4724         Don't print either the top-level value, or the children if the
4725         max-depth is exceeded.
4726         (ppscm_print_children): When printing the key of a map, allow one
4727         extra level of depth.
4728         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4729         print either the top-level value, or the children if the max-depth
4730         is exceeded.
4731         (print_children): When printing the key of a map, allow one extra
4732         level of depth.
4733         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4734         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4735         (user_print_options): Initialise max_depth field.
4736         (val_print_scalar_or_string_type_p): New function.
4737         (val_print): Check to see if the max depth has been reached.
4738         (val_print_check_max_depth): Define new function.
4739         (show_print_max_depth): New function.
4740         (_initialize_valprint): Add 'print max-depth' option.
4741         * valprint.h (struct value_print_options) <max_depth>: New field.
4742         (val_print_check_max_depth): Declare new function.
4743         * NEWS: Document new feature.
4744
4745 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4746
4747         * ada-lang.c (ada_language_defn): Initialise new field.
4748         * c-lang.c (c_is_string_type_p): New function.
4749         (c_language_defn): Initialise new field.
4750         (cplus_language_defn): Initialise new field.
4751         (asm_language_defn): Initialise new field.
4752         (minimal_language_defn): Initialise new field.
4753         * c-lang.h (c_is_string_type_p): Declare new function.
4754         * d-lang.c (d_language_defn): Initialise new field.
4755         * f-lang.c (f_is_string_type_p): New function.
4756         (f_language_defn): Initialise new field.
4757         * go-lang.c (go_is_string_type_p): New function.
4758         (go_language_defn): Initialise new field.
4759         * language.c (default_is_string_type_p): New function.
4760         (unknown_language_defn): Initialise new field.
4761         (auto_language_defn): Initialise new field.
4762         * language.h (struct language_defn) <la_is_string_type_p>: New
4763         member variable.
4764         (default_is_string_type_p): Declare new function.
4765         * m2-lang.c (m2_language_defn): Initialise new field.
4766         * objc-lang.c (objc_language_defn): Initialise new field.
4767         * opencl-lang.c (opencl_language_defn): Initialise new field.
4768         * p-lang.c (pascal_is_string_type_p): New function.
4769         (pascal_language_defn): Initialise new field.
4770         * rust-lang.c (rust_is_string_type_p): New function.
4771         (rust_language_defn): Initialise new field.
4772
4773 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4776         New field.
4777         * ada-lang.c (ada_language_defn): Initialise new field.
4778         * c-lang.c (c_language_defn): Likewise.
4779         (cplus_language_defn): Likewise.
4780         (asm_language_defn): Likewise.
4781         (minimal_language_defn): Likewise.
4782         * d-lang.c (d_language_defn): Likewise.
4783         * f-lang.c (f_language_defn): Likewise.
4784         * go-lang.c (go_language_defn): Likewise.
4785         * language.c (unknown_language_defn): Likewise.
4786         (auto_language_defn): Likewise.
4787         * m2-lang.c (m2_language_defn): Likewise.
4788         * objc-lang.c (objc_language_defn): Likewise.
4789         * opencl-lang.c (opencl_language_defn): Likewise.
4790         * p-lang.c (pascal_language_defn): Likewise.
4791         * rust-lang.c (rust_language_defn): Likewise.
4792
4793 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * ada-lang.c (ada_is_character_type): Change return type to bool.
4796         (ada_is_string_type): Likewise.
4797         * ada-lang.h (ada_is_character_type): Update declaration
4798         (ada_is_string_type): Likewise.
4799
4800 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4801
4802         Support style in 'frame|thread apply'
4803
4804         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4805         * record.c (record_start, record_stop): Update callers of
4806         execute_command_to_string with false.
4807         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4808         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4809         methods.
4810         (class string_file): New constructor with term_out parameter.
4811         Override methods term_out and can_emit_style_escape.  New member
4812         term_out.
4813         (class stdio_file): Override can_emit_style_escape.
4814         (class tee_file): Override term_out and can_emit_style_escape.
4815         * utils.h (can_emit_style_escape): Remove.
4816         * utils.c (can_emit_style_escape): Likewise.
4817         Update all callers of can_emit_style_escape (SOMESTREAM) to
4818         SOMESTREAM->can_emit_style_escape.
4819         * source-cache.c (source_cache::get_source_lines): Likewise.
4820         * stack.c (frame_apply_command_count): Call execute_command_to_string
4821         passing the term_out characteristic of the current gdb_stdout.
4822         * thread.c (thr_try_catch_cmd): Likewise.
4823         * top.c (execute_command_to_string): pass term_out parameter
4824         to construct the string_file for the command output.
4825         * ui-file.c (term_cli_styling): New function (most code moved
4826         from utils.c can_emit_style_escape).
4827         (string_file::string_file, string_file::can_emit_style_escape,
4828         stdio_file::can_emit_style_escape, tee_file::term_out,
4829         tee_file::can_emit_style_escape): New functions.
4830
4831 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4832
4833         * NEWS: Mention the new set|show may-call-functions.
4834         * infcall.c (may_call_functions_p): New variable.
4835         (show_may_call_functions_p): New function.
4836         (call_function_by_hand_dummy): Throws an error if not
4837         may-call-functions.
4838         (_initialize_infcall): Call add_setshow_boolean_cmd for
4839         may-call-functions.
4840
4841 2019-04-25  Keith Seitz  <keiths@redhat.com>
4842
4843         PR c++/24367
4844         * cp-support.c (inspect_type): Don't attempt substitutions
4845         of symbol with the same name.
4846
4847 2019-04-25  Tom Tromey  <tromey@adacore.com>
4848
4849         PR gdb/24475:
4850         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4851         static.
4852
4853 2019-04-25  Tom Tromey  <tromey@adacore.com>
4854
4855         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4856         rvalue reference.
4857         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4858         (gdb_xml_parser::parse): Use std::move.
4859         * python/python-internal.h (gdbpy_convert_exception): Take a const
4860         reference.
4861         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4862         std::move.
4863         * python/py-utils.c (gdbpy_convert_exception): Take a const
4864         reference.
4865         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4866         Use std::move.
4867         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4868         Use std::move.
4869         * mi/mi-main.c (mi_print_exception): Take a const reference.
4870         * main.c (handle_command_errors): Take a const reference.
4871         * linespec.c (parse_linespec): Use std::move.
4872         * infcall.c (run_inferior_call): Use std::move.
4873         (call_function_by_hand_dummy): Use std::move.
4874         * exec.c (try_open_exec_file): Use std::move.
4875         * exceptions.h (exception_print, exception_fprintf)
4876         (exception_print_same): Update.
4877         * exceptions.c (print_exception, exception_print)
4878         (exception_fprintf, exception_print_same): Change parameters to
4879         const reference.
4880         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4881         * common/new-op.c: Use std::move.
4882         * common/common-exceptions.h (struct gdb_exception): Add move
4883         constructor.
4884         (struct gdb_exception_error, struct gdb_exception_quit, struct
4885         gdb_quit_bad_alloc): Change constructor to move constructor.
4886         (throw_exception): Change parameter to rvalue reference.
4887         * common/common-exceptions.c (throw_exception): Take rvalue
4888         reference.
4889         * cli/cli-interp.c (safe_execute_command): Use std::move.
4890         * breakpoint.c (insert_bp_location, location_to_sals): Use
4891         std::move.
4892
4893 2019-04-25  Tom Tromey  <tromey@adacore.com>
4894
4895         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4896         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4897         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4898         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4899         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4900         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4901         guile/scm-value.c: Use unpack.
4902         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4903         gdbscm_gdb_exception.
4904         (gdbscm_throw_gdb_exception): Likewise.
4905         (struct gdbscm_gdb_exception): New.
4906         (unpack): New function.
4907         (gdbscm_wrap): Use unpack.
4908
4909 2019-04-25  Tom Tromey  <tromey@adacore.com>
4910
4911         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4912         (gdb_rl_callback_handler): Use std::move.
4913         * common/common-exceptions.h (struct gdb_exception): Add move
4914         assignment operator.
4915         (throw_exception_sjlj): Change "exception" to const reference.
4916         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4917         (throw_exception_sjlj): Change "exception" to const reference.
4918
4919 2019-04-25  Tom Tromey  <tromey@adacore.com>
4920
4921         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4922         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4923         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4924         Update.
4925         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4926         Update.
4927         * mi/mi-interp.c (mi_interp::exec): Update.
4928         * linespec.c (parse_linespec): Update.
4929         * infcall.c (run_inferior_call): Update.
4930         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4931         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4932         (gdbscm_lookup_global_symbol): Update.
4933         * guile/scm-param.c (gdbscm_parameter_value): Update.
4934         * guile/scm-frame.c (gdbscm_frame_read_register)
4935         (gdbscm_frame_read_var): Update.
4936         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4937         * exec.c (try_open_exec_file): Update.
4938         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4939         (gdb_rl_callback_handler): Update.
4940         * common/common-exceptions.h (exception_none): Don't declare.
4941         * common/common-exceptions.c (exception_none): Don't define.
4942         (struct catcher) <exception>: Update.
4943         * cli/cli-interp.c (safe_execute_command): Update.
4944         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4945
4946 2019-04-25  Ali Tamur  <tamur@google.com>
4947
4948         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4949         (read_attribute_value): Likewise.
4950         (dwarf2_read_addr_index): Update comment.
4951         (read_str_index): Add DW_FORM_strx.
4952         (dwarf2_string_attr): Likewise.
4953         (dwarf2_const_value_attr): Likewise.
4954         (dump_die_shallow): Likewise.
4955         (dwarf2_fetch_constant_bytes): Likewise.
4956         (skip_form_bytes): Likewise.
4957         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4958
4959 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4960
4961         PR corefiles/11608
4962         PR corefiles/18187
4963         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4964         OFFSET.  Verify if current mapping contains an ELF header.
4965         (linux_find_memory_regions_full): Adjust call to
4966         dump_mapping_p.
4967
4968 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4969             Kang Li <kanglictf@gmail.com>
4970
4971         PR gdb/21600
4972
4973         * dwarf2-frame.c (read_initial_length): Be consistent about using
4974         unsigned representation of length.
4975         (decode_frame_entry_1): Likewise.  Check for wraparound of
4976         end pointer as well as buffer overflow.
4977
4978 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4979
4980         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4981         "vq".
4982
4983 2019-04-24  Tom Tromey  <tromey@adacore.com>
4984
4985         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4986
4987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * s12z-tdep.c (s12z_unwind_pc): Delete.
4990         (s12z_unwind_sp): Delete.
4991         (s12z_gdbarch_init): Don't register deleted functions with
4992         gdbarch.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * rl78-tdep.c (rl78_unwind_sp): Delete.
4997         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4998
4999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5002         (xstormy16_unwind_pc): Delete.
5003         (xstormy16_dummy_id): Delete.
5004         (xstormy16_gdbarch_init): Don't register deleted functions with
5005         gdbarch.
5006
5007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * vax-tdep.c (vax_unwind_pc): Delete.
5010         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5011
5012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * v850-tdep.c (v850_unwind_sp): Delete.
5015         (v850_unwind_pc): Delete.
5016         (v850_dummy_id): Delete.
5017         (v850_gdbarch_init): Don't register deleted functions with
5018         gdbarch.
5019
5020 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5023         (tilegx_unwind_pc): Delete.
5024         (tilegx_unwind_dummy_id): Delete.
5025         (tilegx_gdbarch_init): Don't register deleted functions with
5026         gdbarch.
5027
5028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5031         (tic6x_dummy_id): Delete.
5032         (tic6x_gdbarch_init): Don't register deleted functions with
5033         gdbarch.
5034
5035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * sparc-tdep.c (sparc_unwind_pc): Delete.
5038         (sparc32_gdbarch_init): Don't register deleted function with
5039         gdbarch.
5040
5041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * sh-tdep.c (sh_unwind_sp): Delete.
5044         (sh_unwind_pc): Delete.
5045         (sh_dummy_id): Delete.
5046         (sh_gdbarch_init): Don't register deleted functions with
5047         gdbarch.
5048
5049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * score-tdep.c (score_unwind_sp): Delete.
5052         (score_unwind_pc): Delete.
5053         (score_dummy_id): Delete.
5054         (score_gdbarch_init): Don't register deleted functions with
5055         gdbarch.
5056
5057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * rx-tdep.c (rx_unwind_pc): Delete.
5060         (rx_unwind_sp): Delete.
5061         (rx_dummy_id): Delete.
5062         (rx_gdbarch_init): Don't register deleted functions with
5063         gdbarch.  Update comment.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5068         (rs6000_dummy_id): Delete.
5069         (rs6000_gdbarch_init): Don't register deleted functions with
5070         gdbarch.
5071
5072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * or1k-tdep.c (or1k_dummy_id): Delete.
5075         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5076
5077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5078
5079         * nios2-tdep.c (nios2_dummy_id): Delete.
5080         (nios2_unwind_sp): Delete.
5081         (nios2_gdbarch_init): Don't register deleted functions with
5082         gdbarch.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * nds32-tdep.c (nds32_dummy_id): Delete.
5087         (nds32_unwind_pc): Delete.
5088         (nds32_unwind_sp): Delete.
5089         (nds32_gdbarch_init): Don't register deleted functions with
5090         gdbarch.
5091
5092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * msp430-tdep.c (msp430_unwind_pc): Delete.
5095         (msp430_unwind_sp): Delete.
5096         (msp430_dummy_id): Delete.
5097         (msp430_gdbarch_init): Don't register deleted functions with
5098         gdbarch.
5099
5100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * moxie-tdep.c (moxie_unwind_sp): Delete.
5103         (moxie_unwind_pc): Delete.
5104         (moxie_dummy_id): Delete.
5105         (moxie_gdbarch_init): Don't register deleted functions with
5106         gdbarch.
5107
5108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5111         (mn10300_unwind_pc): Delete.
5112         (mn10300_unwind_sp): Delete.
5113         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5114         mn10300_unwind_sp.
5115         (mn10300_frame_unwind_init): Don't register deleted functions with
5116         gdbarch.
5117
5118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * mep-tdep.c (mep_unwind_pc): Delete.
5121         (mep_unwind_sp): Delete.
5122         (mep_dummy_id): Delete.
5123         (mep_gdbarch_init): Don't register deleted functions with
5124         gdbarch.
5125
5126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5129         (m68hc11_unwind_sp): Delete.
5130         (m68hc11_gdbarch_init): Don't register deleted functions with
5131         gdbarch.
5132
5133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * m32r-tdep.c (m32r_unwind_sp): Delete.
5136         (m32r_unwind_pc): Delete.
5137         (m32r_dummy_id): Delete.
5138         (m32r_gdbarch_init): Don't register deleted functions with
5139         gdbarch.
5140
5141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         * m32c-tdep.c (m32c_unwind_pc): Delete.
5144         (m32c_unwind_sp): Delete.
5145         (m32c_dummy_id): Delete.
5146         (m32c_gdbarch_init): Don't register deleted functions with
5147         gdbarch.
5148
5149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5152         (lm32_unwind_pc): Delete.
5153         (lm32_dummy_id): Delete.
5154         (lm32_gdbarch_init): Don't register deleted functions with
5155         gdbarch.
5156
5157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5160         (iq2000_unwind_pc): Delete.
5161         (iq2000_dummy_id): Delete.
5162         (iq2000_gdbarch_init): Don't register deleted functions with
5163         gdbarch.
5164
5165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * nds32-tdep.c (nds32_type_align): Delete.
5168         (nds32_push_dummy_call): Use type_align instead.
5169
5170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5171
5172         * arm-tdep.c (arm_type_align): Only handle vector override case.
5173         (arm_push_dummy_call): Use type_align.
5174         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5175
5176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5177
5178         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5179         case.
5180         (pass_on_stack): Use type_align.
5181         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5182         function.
5183
5184 2019-04-23  Tom Tromey  <tromey@adacore.com>
5185
5186         * dwarf2read.c (line_header::file_name_at): Remove unused
5187         overload.
5188
5189 2019-04-23  Tom de Vries  <tdevries@suse.de>
5190
5191         PR gdb/24438
5192         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5193         invocation.
5194
5195
5196 2019-03-27  Ali Tamur  <tamur@google.com>
5197
5198         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5199         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5200         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5201         (dwarf_expr_context::get_addr_index): Likewise
5202         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5203         (symbol_needs_eval_context::get_addr_index): Likewise
5204         (disassemble_dwarf_expression): Add DW_OP_addrx
5205         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5206         (read_cutu_die_from_dwo): Update comment
5207         (skip_one_die): Add DW_FORM_addrx
5208         (read_attribute_value): Likewise
5209         (var_decode_location): Add DW_OP_addrx
5210         (dwarf2_const_value_attr): Add DW_FORM_addrx
5211         (dump_die_shallow): Likewise
5212         (dwarf2_fetch_constant_bytes): Likewise
5213         (decode_locdesc): Add DW_OP_addrx
5214         (skip_form_bytes): Add DW_FORM_addrx
5215
5216 2019-04-22  Ali Tamur  <tamur@google.com>
5217
5218         * MAINTAINERS (Write After Approval): Add self.
5219
5220 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5221
5222         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5223         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5224         (open_symbol_file_object): Likewise.
5225         (svr4_default_sos): Add info parameter.
5226         (svr4_read_so_list): Likewise.
5227         (svr4_current_sos_direct): Adjust functions calls to pass down
5228         info.
5229         (svr4_current_sos_1): Add info parameter.
5230         (svr4_current_sos): Call get_svr4_info, pass info down to
5231         svr4_current_sos_1.
5232         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5233         get_svr4_info.
5234         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5235         get_svr4_info.
5236         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5237         to get_svr4_info.
5238         (probes_table_remove_objfile_probes): Likewise.
5239         (register_solib_event_probe): Add info parameter.
5240         (solist_update_incremental): Pass info parameter down to
5241         svr4_read_so_list.
5242         (disable_probes_interface): Add info parameter.
5243         (svr4_handle_solib_event): Pass current_program_space to
5244         get_svr4_info.  Adjust disable_probes_interface cleanup.
5245         (svr4_create_probe_breakpoints): Add info parameter, pass it
5246         down to register_solib_event_probe.
5247         (svr4_create_solib_event_breakpoints): Add info parameter,
5248         pass it down to svr4_create_probe_breakpoints.
5249         (enable_break): Pass info down to
5250         svr4_create_solib_event_breakpoints.
5251         (svr4_solib_create_inferior_hook): Pass current_program_space to
5252         get_svr4_info.
5253         (svr4_clear_solib): Likewise.
5254
5255 2019-04-22  Pedro Alves  <palves@redhat.com>
5256
5257         * solib-svr4.c (svr4_free_objfile_observer): New.
5258         (probe_and_action::objfile): New field.
5259         (probes_table_htab_remove_objfile_probes)
5260         (probes_table_remove_objfile_probes): New functions.
5261         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5262         in the new probe_and_action.  Don't store the probe in 'lookup'.
5263         (svr4_create_probe_breakpoints): Pass objfile to
5264         register_solib_event_probe.
5265         (_initialize_svr4_solib): Register a free_objfile observer.
5266
5267 2019-04-19  Tom Tromey  <tom@tromey.com>
5268
5269         * common/queue.h: Remove.
5270
5271 2019-04-19  Tom Tromey  <tom@tromey.com>
5272
5273         * event-loop.c: Don't include "common/queue.h".
5274
5275 2019-04-19  Tom Tromey  <tom@tromey.com>
5276
5277         * remote.c (remote_target): Use delete.
5278         * remote-notif.h: Include <list>, not "common/queue.h".
5279         (notif_client_p): Remove typedef.
5280         (remote_notif_state): Add constructor, destructor, initializer.
5281         <notif_queue>: Now a std::list.
5282         (remote_notif_state_xfree): Don't declare.
5283         * remote-notif.c (remote_notif_process, handle_notification)
5284         (remote_notif_state_allocate): Update.
5285         (~remote_notif_state): Rename from remote_notif_state_xfree.
5286
5287 2019-04-19  Tom Tromey  <tom@tromey.com>
5288
5289         * symfile.c (reread_symbols): Update.
5290         * objfiles.c (objfile_register_static_link)
5291         (objfile_lookup_static_link): Update
5292         (~objfile) Don't delete static_links.
5293         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5294
5295 2019-04-19  Tom Tromey  <tom@tromey.com>
5296
5297         * type-stack.h (struct type_stack) <insert>: Constify string.
5298         * type-stack.c (type_stack::insert): Constify string.
5299         * gdbtypes.h (lookup_template_type): Update.
5300         (address_space_name_to_int): Update.
5301         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5302         const.
5303         (lookup_template_type): Make name const.
5304         * c-exp.y: Update rules.
5305         (lex_one_token, classify_name, classify_inner_name)
5306         (c_print_token): Update.
5307         * p-exp.y: Update rules.
5308         (yylex): Update.
5309         * f-exp.y: Update rules.
5310         (yylex): Update.
5311         * d-exp.y: Update rules.
5312         (lex_one_token, classify_name, classify_inner_name): Update.
5313         * parse.c (write_dollar_variable, copy_name): Return std::string.
5314         * parser-defs.h (copy_name): Change return type.
5315         * m2-exp.y: Update rules.
5316         (yylex): Update.
5317         * go-exp.y (lex_one_token): Update.
5318         Update rules.
5319         (classify_unsafe_function, classify_packaged_name)
5320         (classify_name, yylex): Update.
5321
5322 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5323
5324         * configure.ac: add --enable-source-highlight switch.
5325         * configure: Regenerate.
5326         * top.c (print_gdb_version): plumb --enable-source-highlight
5327         status to "show configuration".
5328
5329 2019-04-19  Tom Tromey  <tromey@adacore.com>
5330
5331         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5332         Check ADA_TYPE_P.
5333         (empty_record, ada_template_to_fixed_record_type_1)
5334         (template_to_static_fixed_type)
5335         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5336         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5337         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5338         macros.
5339
5340 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5341
5342         PR symtab/24423:
5343         * source.c (print_source_lines_base): Advance "iter" when a
5344         control character is seen.
5345
5346 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5347
5348         * inferior.h (struct infcall_suspend_state_deleter):
5349         Catch exception in destructor to avoid crash.
5350
5351 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5352
5353         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5354         close to the add_com "shell".
5355
5356 2019-04-18  Tom Tromey  <tromey@adacore.com>
5357
5358         * process-stratum-target.h (class process_stratum_target)
5359         <stratum>: Add "final".
5360
5361 2019-04-17  Tom Tromey  <tromey@adacore.com>
5362
5363         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5364         against nullptr before use.
5365
5366 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5367
5368         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5369
5370 2019-04-17  Jim Wilson  <jimw@sifive.com>
5371             Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5374         code read might fail, assume 4-byte breakpoint in that case.
5375
5376 2019-04-15  Leszek Swirski  <leszeks@google.com>
5377
5378         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5379         rather than a hand-rolled POD check when checking for forced MEMORY
5380         classification.
5381
5382 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5383
5384         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5385         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5386         function.
5387         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5388         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5389         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5390         declaration.
5391
5392 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5393
5394         * aarch64-linux-nat.c
5395         (aarch64_linux_nat_target::thread_architecture): Add override.
5396         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5397         each VQ.
5398
5399 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5400
5401         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5402
5403 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5406         target types of size 96-bits, add some additional comments, and
5407         check that the builtin type we found was the correct size.
5408
5409 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5410
5411         * utils.c (prompt_for_continue): Don't restore the styling at the
5412         end, as applied_style has the wrong value.  This fixes styling in
5413         long lists of file names that are interrupted by the "Continue?"
5414         prompt.
5415
5416 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5419         * c-lang.c (c_language_defn): Likewise.
5420         (cplus_language_defn): Likewise.
5421         (asm_language_defn): Likewise.
5422         (minimal_language_defn): Likewise.
5423         * d-lang.c (d_language_defn): Likewise.
5424         * f-lang.c (f_language_defn): Likewise.
5425         * go-lang.c (go_language_defn): Likewise.
5426         * language.c (unknown_language_defn): Likewise.
5427         (auto_language_defn): Likewise.
5428         * language.h (struct language_defn): Remove la_magic field.
5429         (LANG_MAGIC): Delete.
5430         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5431         * objc-lang.c (objc_language_defn): Likewise.
5432         * opencl-lang.c (opencl_language_defn): Likewise.
5433         * p-lang.c (pascal_language_defn): Likewise.
5434         * rust-lang.c (rust_language_defn): Likewise.
5435
5436 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * riscv-tdep.c (riscv_type_align): New function.
5439         (riscv_type_alignment): Delete.
5440         (riscv_arg_location): Use 'type_align'.
5441         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5442
5443 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5444
5445         * gdbtypes.c (type_align): A struct with no non-static fields also
5446         has alignment of 1.
5447
5448 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5449
5450         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5451         component to 0.
5452         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5453         member.
5454         (riscv_struct_info::analyse): New implementation using new
5455         analyse_inner member function.
5456         (riscv_struct_info::field_offset): New member function.
5457         (riscv_struct_info::m_offsets): New member variable.
5458         (riscv_struct_info::analyse_inner): New private member function,
5459         takes the old implementation of riscv_struct_info::analyse but
5460         extended to track field offsets.
5461         (riscv_call_arg_struct): Update the struct folding special cases
5462         to handle cases where empty C++ structs, which are non-zero
5463         length, are found.
5464         (riscv_arg_location): Initialise the length of each location, a
5465         non-zero length now indicates the location is in use.
5466         (riscv_push_dummy_call): Allow for the first location having a
5467         non-zero offset when setting up arguments.
5468         (riscv_return_value): Likewise, but for return values.
5469
5470 2019-04-11  Tom Tromey  <tromey@adacore.com>
5471
5472         * utils.c (internal_vproblem): Make "msg" const.
5473
5474 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5475
5476         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5477         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5478         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5479         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5480
5481 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5482
5483         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5484         function.
5485         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5486         of amd64_collect_native_gregset.
5487         (amd64_linux_nat_target::store_registers): Likewise.
5488
5489 2019-04-10  Tom Tromey  <tom@tromey.com>
5490
5491         * symtab.c (lookup_global_symbol_from_objfile)
5492         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5493         * objfiles.h (class separate_debug_iterator): New.
5494         (class separate_debug_range): New.
5495         (struct objfile) <separate_debug_objfiles>: New method.
5496         (objfile_separate_debug_iterate): Don't declare.
5497         * objfiles.c (separate_debug_iterator::operator++): Rename from
5498         objfile_separate_debug_iterate.
5499         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5500         iterator.
5501         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5502         iterator.
5503
5504 2019-04-10  Tom Tromey  <tom@tromey.com>
5505
5506         * symfile.c (reread_symbols): Remove old comment.
5507         * objfiles.c (free_all_objfiles): Fix a typo.
5508
5509 2019-04-10  Tom Tromey  <tom@tromey.com>
5510
5511         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5512         * minsyms.c (lookup_minimal_symbol): Use foreach.
5513         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5514         (lookup_minimal_symbol_solib_trampoline): Likewise.
5515         * symfile.c (reread_symbols): Use foreach.
5516
5517 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5518             Tom Tromey  <tromey@adacore.com>
5519
5520         PR rust/24414:
5521         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5522         (rust_lex_int_test): Change "value" to be LONGEST.
5523         (rust_lex_tests): Add test for long integer literal.
5524
5525 2019-04-09  Tom Tromey  <tromey@adacore.com>
5526
5527         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5528         to bool.
5529         (extended_remote_target::attach): Update.
5530         (remote_target::remote_notice_new_inferior): Update.
5531         (remote_target::add_current_inferior_and_thread): Update.
5532         * inferior.c (exit_inferior_1): Use "false".
5533         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5534
5535 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5536
5537         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5538         the "start" command.
5539
5540 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5541
5542         * python/py-inferior.c (infpy_thread_from_thread_handle):
5543         Adjust comments to reflect renaming of thread_from_thread_handle
5544         to thread_from_handle.  Adjust keywords.  Fix type error message.
5545         (inferior_object_methods): Add thread_from_handle.  Retain
5546         thread_from_thread_handle, but mark it as deprecated.
5547
5548 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5549
5550         * gdbthread.h (find_thread_by_handle): Revise declaration.
5551         * thread.c (find_thread_by_handle): Likewise.  Adjust
5552         implementation too.
5553         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5554         support for buffer objects as handles.
5555
5556 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5557
5558         * python/py-infthread.c (thpy_thread_handle): New function.
5559         (thread_object_methods): Register thpy_thread_handle.
5560
5561 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5562
5563         * gdbthread.h (thread_to_thread_handle): Declare.
5564         * thread.c (gdbtypes.h): Include.
5565         (thread_to_thread_handle): New function.
5566
5567         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5568         (target_thread_info_to_thread_handle): Declare.
5569         * target.c (target_thread_info_to_thread_handle): New function.
5570         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5571         * target-delegates.c: Regenerate.
5572
5573         * linux-thread-db.c (class thread_db_target): Add method
5574         thread_info_to_thread_handle.
5575         (thread_db_target::thread_info_to_thread_handle): Define.
5576         * remote.c (class remote_target): Add new method
5577         thread_info_to_thread_handle.
5578         (remote_target::thread_info_to_thread_handle): Define.
5579
5580 2019-04-08  Pedro Alves  <palves@redhat.com>
5581
5582         * common/common-exceptions.c (throw_exception): Don't create
5583         named object to throw; throw directly.
5584         (throw_it): Likewise.  Don't initialize gdb_exception::message
5585         here, with new; pass FMT and AP to the ctor instead.
5586         * common/common-exceptions.h: Include <string>.
5587         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5588         const char *, va_list)): New ctor.  Use std::make_shared.
5589         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5590         errors)): Delete.
5591         (gdb_exception_error::gdb_exception_error(enum errors, const char
5592         *, va_list)): New.
5593         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5594         Add assertion.
5595         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5596         errors)): Delete.
5597         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5598         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5599         Add assertion.
5600
5601 2019-04-08  Tom Tromey  <tom@tromey.com>
5602
5603         * valops.c (value_rtti_indirect_type): Replace throw_exception
5604         with throw.
5605         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5606         with throw.
5607         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5608         throw.
5609         * target.c (target_translate_tls_address): Replace throw_exception
5610         with throw.
5611         * stack.c (frame_apply_command_count): Replace throw_exception
5612         with throw.
5613         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5614         throw.
5615         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5616         with throw.
5617         * rs6000-tdep.c (rs6000_frame_cache)
5618         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5619         * remote.c: Replace throw_exception with throw.
5620         * record-full.c (record_full_message, record_full_wait_1)
5621         (record_full_restore): Replace throw_exception with throw.
5622         * record-btrace.c:
5623         (get_thread_current_frame_id, record_btrace_start_replaying)
5624         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5625         (cmd_record_btrace_start): Replace throw_exception with throw.
5626         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5627         throw.
5628         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5629         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5630         * linespec.c:
5631         (find_linespec_symbols): Replace throw_exception with throw.
5632         * infrun.c (displaced_step_prepare, resume): Replace
5633         throw_exception with throw.
5634         * infcmd.c (post_create_inferior): Replace throw_exception with
5635         throw.
5636         * inf-loop.c (inferior_event_handler): Replace throw_exception
5637         with throw.
5638         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5639         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5640         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5641         (get_prev_frame_always, get_frame_pc_if_available)
5642         (get_frame_address_in_block_if_available, get_frame_language):
5643         Replace throw_exception with throw.
5644         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5645         throw_exception with throw.
5646         * eval.c (fetch_subexp_value, evaluate_var_value)
5647         (evaluate_funcall, evaluate_subexp_standard): Replace
5648         throw_exception with throw.
5649         * dwarf2loc.c (call_site_find_chain)
5650         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5651         Replace throw_exception with throw.
5652         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5653         with throw.
5654         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5655         throw.
5656         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5657         * completer.c (complete_line_internal): Replace throw_exception
5658         with throw.
5659         * compile/compile-object-run.c (compile_object_run): Replace
5660         throw_exception with throw.
5661         * cli/cli-script.c (process_next_line): Replace throw_exception
5662         with throw.
5663         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5664         (btrace_enable, btrace_maint_update_pt_packets): Replace
5665         throw_exception with throw.
5666         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5667         throw_exception with throw.
5668         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5669         throw_exception with throw.
5670         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5671         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5672         * aarch64-tdep.c (aarch64_make_prologue_cache)
5673         (aarch64_make_stub_cache): Replace throw_exception with throw.
5674
5675 2019-04-08  Tom Tromey  <tom@tromey.com>
5676
5677         * common/common-exceptions.c (throw_exception): Rename from
5678         throw_exception_cxx.  Remove old copy.  Make argument const.
5679         (throw_it): Create and throw exception objects directly.
5680         * common/common-exceptions.h (throw_exception): Make argument
5681         const.
5682         (struct gdb_exception_error): Add constructor.
5683         (struct gdb_exception_quit): Add constructor.
5684
5685 2019-04-08  Tom Tromey  <tom@tromey.com>
5686
5687         * common/common-exceptions.h (exception_rethrow): Don't declare.
5688         (TRY_SJLJ): Update comment.
5689         (TRY, CATCH, END_CATCH): Remove.
5690         * common/common-exceptions.c (exception_rethrow): Remove.
5691
5692 2019-04-08  Tom Tromey  <tom@tromey.com>
5693
5694         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5695         Remove.
5696         (gdb_exception_error): Rename from
5697         gdb_exception_RETURN_MASK_ERROR.
5698         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5699         (gdb_quit_bad_alloc): Update.
5700         * aarch64-tdep.c: Update.
5701         * ada-lang.c: Update.
5702         * ada-typeprint.c: Update.
5703         * ada-valprint.c: Update.
5704         * amd64-tdep.c: Update.
5705         * arch-utils.c: Update.
5706         * break-catch-throw.c: Update.
5707         * breakpoint.c: Update.
5708         * btrace.c: Update.
5709         * c-varobj.c: Update.
5710         * cli/cli-cmds.c: Update.
5711         * cli/cli-interp.c: Update.
5712         * cli/cli-script.c: Update.
5713         * common/common-exceptions.c: Update.
5714         * common/new-op.c: Update.
5715         * common/selftest.c: Update.
5716         * compile/compile-c-symbols.c: Update.
5717         * compile/compile-cplus-symbols.c: Update.
5718         * compile/compile-object-load.c: Update.
5719         * compile/compile-object-run.c: Update.
5720         * completer.c: Update.
5721         * corelow.c: Update.
5722         * cp-abi.c: Update.
5723         * cp-support.c: Update.
5724         * cp-valprint.c: Update.
5725         * darwin-nat.c: Update.
5726         * disasm-selftests.c: Update.
5727         * dtrace-probe.c: Update.
5728         * dwarf-index-cache.c: Update.
5729         * dwarf-index-write.c: Update.
5730         * dwarf2-frame-tailcall.c: Update.
5731         * dwarf2-frame.c: Update.
5732         * dwarf2loc.c: Update.
5733         * dwarf2read.c: Update.
5734         * eval.c: Update.
5735         * event-loop.c: Update.
5736         * event-top.c: Update.
5737         * exec.c: Update.
5738         * f-valprint.c: Update.
5739         * fbsd-tdep.c: Update.
5740         * frame-unwind.c: Update.
5741         * frame.c: Update.
5742         * gdbtypes.c: Update.
5743         * gnu-v3-abi.c: Update.
5744         * guile/guile-internal.h: Update.
5745         * guile/scm-block.c: Update.
5746         * guile/scm-breakpoint.c: Update.
5747         * guile/scm-cmd.c: Update.
5748         * guile/scm-disasm.c: Update.
5749         * guile/scm-frame.c: Update.
5750         * guile/scm-lazy-string.c: Update.
5751         * guile/scm-math.c: Update.
5752         * guile/scm-param.c: Update.
5753         * guile/scm-ports.c: Update.
5754         * guile/scm-pretty-print.c: Update.
5755         * guile/scm-symbol.c: Update.
5756         * guile/scm-symtab.c: Update.
5757         * guile/scm-type.c: Update.
5758         * guile/scm-value.c: Update.
5759         * i386-linux-tdep.c: Update.
5760         * i386-tdep.c: Update.
5761         * inf-loop.c: Update.
5762         * infcall.c: Update.
5763         * infcmd.c: Update.
5764         * infrun.c: Update.
5765         * jit.c: Update.
5766         * language.c: Update.
5767         * linespec.c: Update.
5768         * linux-fork.c: Update.
5769         * linux-nat.c: Update.
5770         * linux-tdep.c: Update.
5771         * linux-thread-db.c: Update.
5772         * main.c: Update.
5773         * mi/mi-cmd-break.c: Update.
5774         * mi/mi-cmd-stack.c: Update.
5775         * mi/mi-interp.c: Update.
5776         * mi/mi-main.c: Update.
5777         * objc-lang.c: Update.
5778         * p-valprint.c: Update.
5779         * parse.c: Update.
5780         * ppc-linux-tdep.c: Update.
5781         * printcmd.c: Update.
5782         * python/py-arch.c: Update.
5783         * python/py-breakpoint.c: Update.
5784         * python/py-cmd.c: Update.
5785         * python/py-finishbreakpoint.c: Update.
5786         * python/py-frame.c: Update.
5787         * python/py-framefilter.c: Update.
5788         * python/py-gdb-readline.c: Update.
5789         * python/py-inferior.c: Update.
5790         * python/py-infthread.c: Update.
5791         * python/py-lazy-string.c: Update.
5792         * python/py-linetable.c: Update.
5793         * python/py-objfile.c: Update.
5794         * python/py-param.c: Update.
5795         * python/py-prettyprint.c: Update.
5796         * python/py-progspace.c: Update.
5797         * python/py-record-btrace.c: Update.
5798         * python/py-record.c: Update.
5799         * python/py-symbol.c: Update.
5800         * python/py-type.c: Update.
5801         * python/py-unwind.c: Update.
5802         * python/py-utils.c: Update.
5803         * python/py-value.c: Update.
5804         * python/python.c: Update.
5805         * record-btrace.c: Update.
5806         * record-full.c: Update.
5807         * remote-fileio.c: Update.
5808         * remote.c: Update.
5809         * riscv-tdep.c: Update.
5810         * rs6000-aix-tdep.c: Update.
5811         * rs6000-tdep.c: Update.
5812         * rust-exp.y: Update.
5813         * rust-lang.c: Update.
5814         * s390-tdep.c: Update.
5815         * selftest-arch.c: Update.
5816         * solib-dsbt.c: Update.
5817         * solib-frv.c: Update.
5818         * solib-spu.c: Update.
5819         * solib-svr4.c: Update.
5820         * solib.c: Update.
5821         * sparc64-linux-tdep.c: Update.
5822         * stack.c: Update.
5823         * symfile-mem.c: Update.
5824         * symmisc.c: Update.
5825         * target.c: Update.
5826         * thread.c: Update.
5827         * top.c: Update.
5828         * tracefile-tfile.c: Update.
5829         * tui/tui.c: Update.
5830         * typeprint.c: Update.
5831         * unittests/cli-utils-selftests.c: Update.
5832         * unittests/parse-connection-spec-selftests.c: Update.
5833         * valops.c: Update.
5834         * valprint.c: Update.
5835         * value.c: Update.
5836         * varobj.c: Update.
5837         * windows-nat.c: Update.
5838         * x86-linux-nat.c: Update.
5839         * xml-support.c: Update.
5840
5841 2019-04-08  Tom Tromey  <tom@tromey.com>
5842
5843         * xml-support.c: Use C++ exception handling.
5844         * x86-linux-nat.c: Use C++ exception handling.
5845         * windows-nat.c: Use C++ exception handling.
5846         * varobj.c: Use C++ exception handling.
5847         * value.c: Use C++ exception handling.
5848         * valprint.c: Use C++ exception handling.
5849         * valops.c: Use C++ exception handling.
5850         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5851         handling.
5852         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5853         * typeprint.c: Use C++ exception handling.
5854         * tui/tui.c: Use C++ exception handling.
5855         * tracefile-tfile.c: Use C++ exception handling.
5856         * top.c: Use C++ exception handling.
5857         * thread.c: Use C++ exception handling.
5858         * target.c: Use C++ exception handling.
5859         * symmisc.c: Use C++ exception handling.
5860         * symfile-mem.c: Use C++ exception handling.
5861         * stack.c: Use C++ exception handling.
5862         * sparc64-linux-tdep.c: Use C++ exception handling.
5863         * solib.c: Use C++ exception handling.
5864         * solib-svr4.c: Use C++ exception handling.
5865         * solib-spu.c: Use C++ exception handling.
5866         * solib-frv.c: Use C++ exception handling.
5867         * solib-dsbt.c: Use C++ exception handling.
5868         * selftest-arch.c: Use C++ exception handling.
5869         * s390-tdep.c: Use C++ exception handling.
5870         * rust-lang.c: Use C++ exception handling.
5871         * rust-exp.y: Use C++ exception handling.
5872         * rs6000-tdep.c: Use C++ exception handling.
5873         * rs6000-aix-tdep.c: Use C++ exception handling.
5874         * riscv-tdep.c: Use C++ exception handling.
5875         * remote.c: Use C++ exception handling.
5876         * remote-fileio.c: Use C++ exception handling.
5877         * record-full.c: Use C++ exception handling.
5878         * record-btrace.c: Use C++ exception handling.
5879         * python/python.c: Use C++ exception handling.
5880         * python/py-value.c: Use C++ exception handling.
5881         * python/py-utils.c: Use C++ exception handling.
5882         * python/py-unwind.c: Use C++ exception handling.
5883         * python/py-type.c: Use C++ exception handling.
5884         * python/py-symbol.c: Use C++ exception handling.
5885         * python/py-record.c: Use C++ exception handling.
5886         * python/py-record-btrace.c: Use C++ exception handling.
5887         * python/py-progspace.c: Use C++ exception handling.
5888         * python/py-prettyprint.c: Use C++ exception handling.
5889         * python/py-param.c: Use C++ exception handling.
5890         * python/py-objfile.c: Use C++ exception handling.
5891         * python/py-linetable.c: Use C++ exception handling.
5892         * python/py-lazy-string.c: Use C++ exception handling.
5893         * python/py-infthread.c: Use C++ exception handling.
5894         * python/py-inferior.c: Use C++ exception handling.
5895         * python/py-gdb-readline.c: Use C++ exception handling.
5896         * python/py-framefilter.c: Use C++ exception handling.
5897         * python/py-frame.c: Use C++ exception handling.
5898         * python/py-finishbreakpoint.c: Use C++ exception handling.
5899         * python/py-cmd.c: Use C++ exception handling.
5900         * python/py-breakpoint.c: Use C++ exception handling.
5901         * python/py-arch.c: Use C++ exception handling.
5902         * printcmd.c: Use C++ exception handling.
5903         * ppc-linux-tdep.c: Use C++ exception handling.
5904         * parse.c: Use C++ exception handling.
5905         * p-valprint.c: Use C++ exception handling.
5906         * objc-lang.c: Use C++ exception handling.
5907         * mi/mi-main.c: Use C++ exception handling.
5908         * mi/mi-interp.c: Use C++ exception handling.
5909         * mi/mi-cmd-stack.c: Use C++ exception handling.
5910         * mi/mi-cmd-break.c: Use C++ exception handling.
5911         * main.c: Use C++ exception handling.
5912         * linux-thread-db.c: Use C++ exception handling.
5913         * linux-tdep.c: Use C++ exception handling.
5914         * linux-nat.c: Use C++ exception handling.
5915         * linux-fork.c: Use C++ exception handling.
5916         * linespec.c: Use C++ exception handling.
5917         * language.c: Use C++ exception handling.
5918         * jit.c: Use C++ exception handling.
5919         * infrun.c: Use C++ exception handling.
5920         * infcmd.c: Use C++ exception handling.
5921         * infcall.c: Use C++ exception handling.
5922         * inf-loop.c: Use C++ exception handling.
5923         * i386-tdep.c: Use C++ exception handling.
5924         * i386-linux-tdep.c: Use C++ exception handling.
5925         * guile/scm-value.c: Use C++ exception handling.
5926         * guile/scm-type.c: Use C++ exception handling.
5927         * guile/scm-symtab.c: Use C++ exception handling.
5928         * guile/scm-symbol.c: Use C++ exception handling.
5929         * guile/scm-pretty-print.c: Use C++ exception handling.
5930         * guile/scm-ports.c: Use C++ exception handling.
5931         * guile/scm-param.c: Use C++ exception handling.
5932         * guile/scm-math.c: Use C++ exception handling.
5933         * guile/scm-lazy-string.c: Use C++ exception handling.
5934         * guile/scm-frame.c: Use C++ exception handling.
5935         * guile/scm-disasm.c: Use C++ exception handling.
5936         * guile/scm-cmd.c: Use C++ exception handling.
5937         * guile/scm-breakpoint.c: Use C++ exception handling.
5938         * guile/scm-block.c: Use C++ exception handling.
5939         * guile/guile-internal.h: Use C++ exception handling.
5940         * gnu-v3-abi.c: Use C++ exception handling.
5941         * gdbtypes.c: Use C++ exception handling.
5942         * frame.c: Use C++ exception handling.
5943         * frame-unwind.c: Use C++ exception handling.
5944         * fbsd-tdep.c: Use C++ exception handling.
5945         * f-valprint.c: Use C++ exception handling.
5946         * exec.c: Use C++ exception handling.
5947         * event-top.c: Use C++ exception handling.
5948         * event-loop.c: Use C++ exception handling.
5949         * eval.c: Use C++ exception handling.
5950         * dwarf2read.c: Use C++ exception handling.
5951         * dwarf2loc.c: Use C++ exception handling.
5952         * dwarf2-frame.c: Use C++ exception handling.
5953         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5954         * dwarf-index-write.c: Use C++ exception handling.
5955         * dwarf-index-cache.c: Use C++ exception handling.
5956         * dtrace-probe.c: Use C++ exception handling.
5957         * disasm-selftests.c: Use C++ exception handling.
5958         * darwin-nat.c: Use C++ exception handling.
5959         * cp-valprint.c: Use C++ exception handling.
5960         * cp-support.c: Use C++ exception handling.
5961         * cp-abi.c: Use C++ exception handling.
5962         * corelow.c: Use C++ exception handling.
5963         * completer.c: Use C++ exception handling.
5964         * compile/compile-object-run.c: Use C++ exception handling.
5965         * compile/compile-object-load.c: Use C++ exception handling.
5966         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5967         * compile/compile-c-symbols.c: Use C++ exception handling.
5968         * common/selftest.c: Use C++ exception handling.
5969         * common/new-op.c: Use C++ exception handling.
5970         * cli/cli-script.c: Use C++ exception handling.
5971         * cli/cli-interp.c: Use C++ exception handling.
5972         * cli/cli-cmds.c: Use C++ exception handling.
5973         * c-varobj.c: Use C++ exception handling.
5974         * btrace.c: Use C++ exception handling.
5975         * breakpoint.c: Use C++ exception handling.
5976         * break-catch-throw.c: Use C++ exception handling.
5977         * arch-utils.c: Use C++ exception handling.
5978         * amd64-tdep.c: Use C++ exception handling.
5979         * ada-valprint.c: Use C++ exception handling.
5980         * ada-typeprint.c: Use C++ exception handling.
5981         * ada-lang.c: Use C++ exception handling.
5982         * aarch64-tdep.c: Use C++ exception handling.
5983
5984 2019-04-08  Tom Tromey  <tom@tromey.com>
5985
5986         * xml-support.c (gdb_xml_parser::parse): Update.
5987         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5988         * value.c (show_convenience): Update.
5989         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5990         (test_parse_flags_qcs): Update.
5991         * thread.c (thr_try_catch_cmd): Update.
5992         * target.c (target_translate_tls_address): Update.
5993         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5994         (info_frame_command_core, frame_apply_command_count): Update.
5995         * rust-exp.y (rust_lex_exception_test): Update.
5996         * riscv-tdep.c (riscv_print_one_register_info): Update.
5997         * remote.c (remote_target::enable_btrace): Update.
5998         * record-btrace.c (record_btrace_enable_warn): Update.
5999         * python/py-utils.c (gdbpy_convert_exception): Update.
6000         * printcmd.c (do_one_display, print_variable_and_value): Update.
6001         * mi/mi-main.c (mi_print_exception): Update.
6002         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6003         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6004         * linux-nat.c (linux_nat_target::attach): Update.
6005         * linux-fork.c (class scoped_switch_fork_info): Update.
6006         * infrun.c (displaced_step_prepare): Update.
6007         * infcall.c (call_function_by_hand_dummy): Update.
6008         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6009         * gnu-v3-abi.c (print_one_vtable): Update.
6010         * frame.c (get_prev_frame_always): Update.
6011         * f-valprint.c (info_common_command_for_block): Update.
6012         * exec.c (try_open_exec_file): Update.
6013         * exceptions.c (print_exception, exception_print)
6014         (exception_fprintf, exception_print_same): Update.
6015         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6016         * dwarf-index-cache.c (index_cache::store)
6017         (index_cache::lookup_gdb_index): Update.
6018         * darwin-nat.c (maybe_cache_shell): Update.
6019         * cp-valprint.c (cp_print_value_fields): Update.
6020         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6021         (gcc_cplus_symbol_address): Update.
6022         * compile/compile-c-symbols.c (gcc_convert_symbol)
6023         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6024         * common/selftest.c: Update.
6025         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6026         a std::string.
6027         (exception_try_scope_entry, exception_try_scope_exit): Don't
6028         declare.
6029         (struct exception_try_scope): Remove.
6030         (TRY): Don't use exception_try_scope.
6031         (struct gdb_exception): Add constructor, operator=.
6032         <what>: New method.
6033         (struct gdb_exception_RETURN_MASK_ALL)
6034         (struct gdb_exception_RETURN_MASK_ERROR)
6035         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6036         (struct gdb_quit_bad_alloc): Update.
6037         * common/common-exceptions.c (exception_none): Change
6038         initializer.
6039         (struct catcher) <state, exception>: Initialize inline.
6040         <prev>: Remove member.
6041         (current_catcher): Remove.
6042         (catchers): New global.
6043         (exceptions_state_mc_init): Simplify.
6044         (catcher_pop): Remove.
6045         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6046         (try_scope_depth, exception_try_scope_entry)
6047         (exception_try_scope_exit): Remove.
6048         (throw_exception_sjlj): Update.
6049         (exception_messages, exception_messages_size): Remove.
6050         (throw_it): Simplify.
6051         (gdb_exception_sliced_copy): Remove.
6052         (throw_exception_cxx): Update.
6053         * cli/cli-script.c (script_from_file): Update.
6054         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6055         Update.
6056         * ada-valprint.c (ada_val_print): Update.
6057         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6058         (create_excep_cond_exprs): Update.
6059
6060 2019-04-08  Tom Tromey  <tom@tromey.com>
6061
6062         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6063         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6064         (TRY, CATCH, END_CATCH): Remove some definitions.
6065         * common/common-exceptions.c: Don't use GDB_XCPT.
6066         (catcher_list_size): Remove.
6067         (throw_exception, throw_it): Simplify.
6068
6069 2019-04-05  Tom Tromey  <tom@tromey.com>
6070
6071         Revert the header-sorting patch.
6072         * ft32-tdep.c: Revert.
6073         * frv-tdep.c: Revert.
6074         * frv-linux-tdep.c: Revert.
6075         * frame.c: Revert.
6076         * frame-unwind.c: Revert.
6077         * frame-base.c: Revert.
6078         * fork-child.c: Revert.
6079         * findvar.c: Revert.
6080         * findcmd.c: Revert.
6081         * filesystem.c: Revert.
6082         * filename-seen-cache.h: Revert.
6083         * filename-seen-cache.c: Revert.
6084         * fbsd-tdep.c: Revert.
6085         * fbsd-nat.h: Revert.
6086         * fbsd-nat.c: Revert.
6087         * f-valprint.c: Revert.
6088         * f-typeprint.c: Revert.
6089         * f-lang.c: Revert.
6090         * extension.h: Revert.
6091         * extension.c: Revert.
6092         * extension-priv.h: Revert.
6093         * expprint.c: Revert.
6094         * exec.h: Revert.
6095         * exec.c: Revert.
6096         * exceptions.c: Revert.
6097         * event-top.c: Revert.
6098         * event-loop.c: Revert.
6099         * eval.c: Revert.
6100         * elfread.c: Revert.
6101         * dwarf2read.h: Revert.
6102         * dwarf2read.c: Revert.
6103         * dwarf2loc.c: Revert.
6104         * dwarf2expr.h: Revert.
6105         * dwarf2expr.c: Revert.
6106         * dwarf2-frame.c: Revert.
6107         * dwarf2-frame-tailcall.c: Revert.
6108         * dwarf-index-write.h: Revert.
6109         * dwarf-index-write.c: Revert.
6110         * dwarf-index-common.c: Revert.
6111         * dwarf-index-cache.h: Revert.
6112         * dwarf-index-cache.c: Revert.
6113         * dummy-frame.c: Revert.
6114         * dtrace-probe.c: Revert.
6115         * disasm.h: Revert.
6116         * disasm.c: Revert.
6117         * disasm-selftests.c: Revert.
6118         * dictionary.c: Revert.
6119         * dicos-tdep.c: Revert.
6120         * demangle.c: Revert.
6121         * dcache.h: Revert.
6122         * dcache.c: Revert.
6123         * darwin-nat.h: Revert.
6124         * darwin-nat.c: Revert.
6125         * darwin-nat-info.c: Revert.
6126         * d-valprint.c: Revert.
6127         * d-namespace.c: Revert.
6128         * d-lang.c: Revert.
6129         * ctf.c: Revert.
6130         * csky-tdep.c: Revert.
6131         * csky-linux-tdep.c: Revert.
6132         * cris-tdep.c: Revert.
6133         * cris-linux-tdep.c: Revert.
6134         * cp-valprint.c: Revert.
6135         * cp-support.c: Revert.
6136         * cp-namespace.c: Revert.
6137         * cp-abi.c: Revert.
6138         * corelow.c: Revert.
6139         * corefile.c: Revert.
6140         * continuations.c: Revert.
6141         * completer.h: Revert.
6142         * completer.c: Revert.
6143         * complaints.c: Revert.
6144         * coffread.c: Revert.
6145         * coff-pe-read.c: Revert.
6146         * cli-out.h: Revert.
6147         * cli-out.c: Revert.
6148         * charset.c: Revert.
6149         * c-varobj.c: Revert.
6150         * c-valprint.c: Revert.
6151         * c-typeprint.c: Revert.
6152         * c-lang.c: Revert.
6153         * buildsym.c: Revert.
6154         * buildsym-legacy.c: Revert.
6155         * build-id.h: Revert.
6156         * build-id.c: Revert.
6157         * btrace.c: Revert.
6158         * bsd-uthread.c: Revert.
6159         * breakpoint.h: Revert.
6160         * breakpoint.c: Revert.
6161         * break-catch-throw.c: Revert.
6162         * break-catch-syscall.c: Revert.
6163         * break-catch-sig.c: Revert.
6164         * blockframe.c: Revert.
6165         * block.c: Revert.
6166         * bfin-tdep.c: Revert.
6167         * bfin-linux-tdep.c: Revert.
6168         * bfd-target.c: Revert.
6169         * bcache.c: Revert.
6170         * ax-general.c: Revert.
6171         * ax-gdb.h: Revert.
6172         * ax-gdb.c: Revert.
6173         * avr-tdep.c: Revert.
6174         * auxv.c: Revert.
6175         * auto-load.c: Revert.
6176         * arm-wince-tdep.c: Revert.
6177         * arm-tdep.c: Revert.
6178         * arm-symbian-tdep.c: Revert.
6179         * arm-pikeos-tdep.c: Revert.
6180         * arm-obsd-tdep.c: Revert.
6181         * arm-nbsd-tdep.c: Revert.
6182         * arm-nbsd-nat.c: Revert.
6183         * arm-linux-tdep.c: Revert.
6184         * arm-linux-nat.c: Revert.
6185         * arm-fbsd-tdep.c: Revert.
6186         * arm-fbsd-nat.c: Revert.
6187         * arm-bsd-tdep.c: Revert.
6188         * arch-utils.c: Revert.
6189         * arc-tdep.c: Revert.
6190         * arc-newlib-tdep.c: Revert.
6191         * annotate.h: Revert.
6192         * annotate.c: Revert.
6193         * amd64-windows-tdep.c: Revert.
6194         * amd64-windows-nat.c: Revert.
6195         * amd64-tdep.c: Revert.
6196         * amd64-sol2-tdep.c: Revert.
6197         * amd64-obsd-tdep.c: Revert.
6198         * amd64-obsd-nat.c: Revert.
6199         * amd64-nbsd-tdep.c: Revert.
6200         * amd64-nbsd-nat.c: Revert.
6201         * amd64-nat.c: Revert.
6202         * amd64-linux-tdep.c: Revert.
6203         * amd64-linux-nat.c: Revert.
6204         * amd64-fbsd-tdep.c: Revert.
6205         * amd64-fbsd-nat.c: Revert.
6206         * amd64-dicos-tdep.c: Revert.
6207         * amd64-darwin-tdep.c: Revert.
6208         * amd64-bsd-nat.c: Revert.
6209         * alpha-tdep.c: Revert.
6210         * alpha-obsd-tdep.c: Revert.
6211         * alpha-nbsd-tdep.c: Revert.
6212         * alpha-mdebug-tdep.c: Revert.
6213         * alpha-linux-tdep.c: Revert.
6214         * alpha-linux-nat.c: Revert.
6215         * alpha-bsd-tdep.c: Revert.
6216         * alpha-bsd-nat.c: Revert.
6217         * aix-thread.c: Revert.
6218         * agent.c: Revert.
6219         * addrmap.c: Revert.
6220         * ada-varobj.c: Revert.
6221         * ada-valprint.c: Revert.
6222         * ada-typeprint.c: Revert.
6223         * ada-tasks.c: Revert.
6224         * ada-lang.c: Revert.
6225         * aarch64-tdep.c: Revert.
6226         * aarch64-ravenscar-thread.c: Revert.
6227         * aarch64-newlib-tdep.c: Revert.
6228         * aarch64-linux-tdep.c: Revert.
6229         * aarch64-linux-nat.c: Revert.
6230         * aarch64-fbsd-tdep.c: Revert.
6231         * aarch64-fbsd-nat.c: Revert.
6232         * aarch32-linux-nat.c: Revert.
6233
6234 2019-04-05  Tom Tromey  <tom@tromey.com>
6235
6236         * ft32-tdep.c: Sort headers.
6237         * frv-tdep.c: Sort headers.
6238         * frv-linux-tdep.c: Sort headers.
6239         * frame.c: Sort headers.
6240         * frame-unwind.c: Sort headers.
6241         * frame-base.c: Sort headers.
6242         * fork-child.c: Sort headers.
6243         * findvar.c: Sort headers.
6244         * findcmd.c: Sort headers.
6245         * filesystem.c: Sort headers.
6246         * filename-seen-cache.h: Sort headers.
6247         * filename-seen-cache.c: Sort headers.
6248         * fbsd-tdep.c: Sort headers.
6249         * fbsd-nat.h: Sort headers.
6250         * fbsd-nat.c: Sort headers.
6251         * f-valprint.c: Sort headers.
6252         * f-typeprint.c: Sort headers.
6253         * f-lang.c: Sort headers.
6254         * extension.h: Sort headers.
6255         * extension.c: Sort headers.
6256         * extension-priv.h: Sort headers.
6257         * expprint.c: Sort headers.
6258         * exec.h: Sort headers.
6259         * exec.c: Sort headers.
6260         * exceptions.c: Sort headers.
6261         * event-top.c: Sort headers.
6262         * event-loop.c: Sort headers.
6263         * eval.c: Sort headers.
6264         * elfread.c: Sort headers.
6265         * dwarf2read.h: Sort headers.
6266         * dwarf2read.c: Sort headers.
6267         * dwarf2loc.c: Sort headers.
6268         * dwarf2expr.h: Sort headers.
6269         * dwarf2expr.c: Sort headers.
6270         * dwarf2-frame.c: Sort headers.
6271         * dwarf2-frame-tailcall.c: Sort headers.
6272         * dwarf-index-write.h: Sort headers.
6273         * dwarf-index-write.c: Sort headers.
6274         * dwarf-index-common.c: Sort headers.
6275         * dwarf-index-cache.h: Sort headers.
6276         * dwarf-index-cache.c: Sort headers.
6277         * dummy-frame.c: Sort headers.
6278         * dtrace-probe.c: Sort headers.
6279         * disasm.h: Sort headers.
6280         * disasm.c: Sort headers.
6281         * disasm-selftests.c: Sort headers.
6282         * dictionary.c: Sort headers.
6283         * dicos-tdep.c: Sort headers.
6284         * demangle.c: Sort headers.
6285         * dcache.h: Sort headers.
6286         * dcache.c: Sort headers.
6287         * darwin-nat.h: Sort headers.
6288         * darwin-nat.c: Sort headers.
6289         * darwin-nat-info.c: Sort headers.
6290         * d-valprint.c: Sort headers.
6291         * d-namespace.c: Sort headers.
6292         * d-lang.c: Sort headers.
6293         * ctf.c: Sort headers.
6294         * csky-tdep.c: Sort headers.
6295         * csky-linux-tdep.c: Sort headers.
6296         * cris-tdep.c: Sort headers.
6297         * cris-linux-tdep.c: Sort headers.
6298         * cp-valprint.c: Sort headers.
6299         * cp-support.c: Sort headers.
6300         * cp-namespace.c: Sort headers.
6301         * cp-abi.c: Sort headers.
6302         * corelow.c: Sort headers.
6303         * corefile.c: Sort headers.
6304         * continuations.c: Sort headers.
6305         * completer.h: Sort headers.
6306         * completer.c: Sort headers.
6307         * complaints.c: Sort headers.
6308         * coffread.c: Sort headers.
6309         * coff-pe-read.c: Sort headers.
6310         * cli-out.h: Sort headers.
6311         * cli-out.c: Sort headers.
6312         * charset.c: Sort headers.
6313         * c-varobj.c: Sort headers.
6314         * c-valprint.c: Sort headers.
6315         * c-typeprint.c: Sort headers.
6316         * c-lang.c: Sort headers.
6317         * buildsym.c: Sort headers.
6318         * buildsym-legacy.c: Sort headers.
6319         * build-id.h: Sort headers.
6320         * build-id.c: Sort headers.
6321         * btrace.c: Sort headers.
6322         * bsd-uthread.c: Sort headers.
6323         * breakpoint.h: Sort headers.
6324         * breakpoint.c: Sort headers.
6325         * break-catch-throw.c: Sort headers.
6326         * break-catch-syscall.c: Sort headers.
6327         * break-catch-sig.c: Sort headers.
6328         * blockframe.c: Sort headers.
6329         * block.c: Sort headers.
6330         * bfin-tdep.c: Sort headers.
6331         * bfin-linux-tdep.c: Sort headers.
6332         * bfd-target.c: Sort headers.
6333         * bcache.c: Sort headers.
6334         * ax-general.c: Sort headers.
6335         * ax-gdb.h: Sort headers.
6336         * ax-gdb.c: Sort headers.
6337         * avr-tdep.c: Sort headers.
6338         * auxv.c: Sort headers.
6339         * auto-load.c: Sort headers.
6340         * arm-wince-tdep.c: Sort headers.
6341         * arm-tdep.c: Sort headers.
6342         * arm-symbian-tdep.c: Sort headers.
6343         * arm-pikeos-tdep.c: Sort headers.
6344         * arm-obsd-tdep.c: Sort headers.
6345         * arm-nbsd-tdep.c: Sort headers.
6346         * arm-nbsd-nat.c: Sort headers.
6347         * arm-linux-tdep.c: Sort headers.
6348         * arm-linux-nat.c: Sort headers.
6349         * arm-fbsd-tdep.c: Sort headers.
6350         * arm-fbsd-nat.c: Sort headers.
6351         * arm-bsd-tdep.c: Sort headers.
6352         * arch-utils.c: Sort headers.
6353         * arc-tdep.c: Sort headers.
6354         * arc-newlib-tdep.c: Sort headers.
6355         * annotate.h: Sort headers.
6356         * annotate.c: Sort headers.
6357         * amd64-windows-tdep.c: Sort headers.
6358         * amd64-windows-nat.c: Sort headers.
6359         * amd64-tdep.c: Sort headers.
6360         * amd64-sol2-tdep.c: Sort headers.
6361         * amd64-obsd-tdep.c: Sort headers.
6362         * amd64-obsd-nat.c: Sort headers.
6363         * amd64-nbsd-tdep.c: Sort headers.
6364         * amd64-nbsd-nat.c: Sort headers.
6365         * amd64-nat.c: Sort headers.
6366         * amd64-linux-tdep.c: Sort headers.
6367         * amd64-linux-nat.c: Sort headers.
6368         * amd64-fbsd-tdep.c: Sort headers.
6369         * amd64-fbsd-nat.c: Sort headers.
6370         * amd64-dicos-tdep.c: Sort headers.
6371         * amd64-darwin-tdep.c: Sort headers.
6372         * amd64-bsd-nat.c: Sort headers.
6373         * alpha-tdep.c: Sort headers.
6374         * alpha-obsd-tdep.c: Sort headers.
6375         * alpha-nbsd-tdep.c: Sort headers.
6376         * alpha-mdebug-tdep.c: Sort headers.
6377         * alpha-linux-tdep.c: Sort headers.
6378         * alpha-linux-nat.c: Sort headers.
6379         * alpha-bsd-tdep.c: Sort headers.
6380         * alpha-bsd-nat.c: Sort headers.
6381         * aix-thread.c: Sort headers.
6382         * agent.c: Sort headers.
6383         * addrmap.c: Sort headers.
6384         * ada-varobj.c: Sort headers.
6385         * ada-valprint.c: Sort headers.
6386         * ada-typeprint.c: Sort headers.
6387         * ada-tasks.c: Sort headers.
6388         * ada-lang.c: Sort headers.
6389         * aarch64-tdep.c: Sort headers.
6390         * aarch64-ravenscar-thread.c: Sort headers.
6391         * aarch64-newlib-tdep.c: Sort headers.
6392         * aarch64-linux-tdep.c: Sort headers.
6393         * aarch64-linux-nat.c: Sort headers.
6394         * aarch64-fbsd-tdep.c: Sort headers.
6395         * aarch64-fbsd-nat.c: Sort headers.
6396         * aarch32-linux-nat.c: Sort headers.
6397
6398 2019-04-04  Tom Tromey  <tom@tromey.com>
6399
6400         * varobj.c (varobj_create): Update.
6401         * rust-exp.y (struct rust_parser) <update_innermost_block,
6402         lookup_symbol>: New methods.
6403         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6404         Rename.
6405         (rust_parser::rust_lookup_type)
6406         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6407         * printcmd.c (display_command, do_one_display): Update.
6408         * parser-defs.h (struct parser_state) <parser_state>: Add
6409         "tracker" parameter.
6410         (block_tracker): New member.
6411         (class innermost_block_tracker) <innermost_block_tracker>: Add
6412         "types" parameter.
6413         <reset>: Remove method.
6414         (innermost_block): Don't declare.
6415         (null_post_parser): Update.
6416         * parse.c (innermost_block): Remove global.
6417         (write_dollar_variable): Update.
6418         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6419         Remove "tracker_types" parameter.
6420         (parse_expression): Add "tracker" parameter.
6421         (parse_expression_for_completion): Update.
6422         (null_post_parser): Add "tracker" parameter.
6423         * p-exp.y: Update rules.
6424         * m2-exp.y: Update rules.
6425         * language.h (struct language_defn) <la_post_parser>: Add
6426         "tracker" parameter.
6427         * go-exp.y: Update rules.
6428         * f-exp.y: Update rules.
6429         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6430         parameter.
6431         * d-exp.y: Update rules.
6432         * c-exp.y: Update rules.
6433         * breakpoint.c (set_breakpoint_condition): Create an
6434         innermost_block_tracker.
6435         (watch_command_1): Likewise.
6436         * ada-lang.c (resolve): Add "tracker" parameter.
6437         (resolve_subexp): Likewise.
6438         * ada-exp.y (write_var_from_sym): Update.
6439
6440 2019-04-04  Tom Tromey  <tom@tromey.com>
6441
6442         * type-stack.h: New file.
6443         * type-stack.c: New file.
6444         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6445         type-stack.h.
6446         (insert_into_type_stack, insert_type, push_type, push_type_int)
6447         (insert_type_address_space, pop_type, pop_type_int)
6448         (pop_typelist, pop_type_stack, append_type_stack)
6449         (push_type_stack, get_type_stack, push_typelist)
6450         (follow_type_instance_flags, follow_types): Don't declare.
6451         * parse.c (type_stack): Remove global.
6452         (parse_exp_in_context): Update.
6453         (insert_into_type_stack, insert_type, push_type, push_type_int)
6454         (insert_type_address_space, pop_type, pop_type_int)
6455         (pop_typelist, pop_type_stack, append_type_stack)
6456         (push_type_stack, get_type_stack, push_typelist)
6457         (follow_type_instance_flags, follow_types): Remove (moved to
6458         type-stack.c).
6459         * f-exp.y (type_stack): New global.
6460         Update rules.
6461         (push_kind_type, f_parse): Update.
6462         * d-exp.y (type_stack): New global.
6463         Update rules.
6464         (d_parse): Update.
6465         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6466         Update rules.
6467         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6468         (HFILES_NO_SRCDIR): Add type-stack.h.
6469
6470 2019-04-04  Tom Tromey  <tom@tromey.com>
6471
6472         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6473         (rust_parser::convert_ast_to_expression, rust_parse)
6474         (rust_lex_test_completion, rust_lex_tests): Update.
6475         * parser-defs.h (struct expr_completion_state): New.
6476         (struct parser_state) <parser_state>: Add completion parameter.
6477         <mark_struct_expression, mark_completion_tag>: New methods.
6478         <parse_completion, m_completion_state>: New members.
6479         (prefixify_expression, null_post_parser): Update.
6480         (mark_struct_expression, mark_completion_tag): Don't declare.
6481         * parse.c (parse_completion, expout_last_struct)
6482         (expout_tag_completion_type, expout_completion_name): Remove
6483         globals.
6484         (parser_state::mark_struct_expression)
6485         (parser_state::mark_completion_tag): Now methods.
6486         (prefixify_expression): Add last_struct parameter.
6487         (prefixify_subexp): Likewise.
6488         (parse_exp_1): Update.
6489         (parse_exp_in_context): Add cstate parameter.  Update.
6490         (parse_expression_for_completion): Create an
6491         expr_completion_state.
6492         (null_post_parser): Add "completion" parameter.
6493         * p-exp.y: Update rules.
6494         (yylex): Update.
6495         * language.h (struct language_defn) <la_post_parser>: Add
6496         "completing" parameter.
6497         * go-exp.y: Update rules.
6498         (lex_one_token): Update.
6499         * expression.h (parse_completion): Don't declare.
6500         * d-exp.y: Update rules.
6501         (lex_one_token): Update rules.
6502         * c-exp.y: Update rules.
6503         (lex_one_token): Update.
6504         * ada-lang.c (resolve): Add "parse_completion" parameter.
6505         (resolve_subexp): Likewise.
6506         (ada_resolve_function): Likewise.
6507
6508 2019-04-04  Tom Tromey  <tom@tromey.com>
6509
6510         * parser-defs.h (struct parser_state) <start_arglist,
6511         end_arglist>: New methods.
6512         <arglist_len, m_funcall_chain>: New members.
6513         (arglist_len, start_arglist, end_arglist): Don't declare.
6514         * parse.c (arglist_len, funcall_chain): Remove global.
6515         (start_arglist, end_arglist): Remove functions.
6516         (parse_exp_in_context): Update.
6517         * p-exp.y: Update rules.
6518         * m2-exp.y: Update rules.
6519         * go-exp.y: Update rules.
6520         * f-exp.y: Update rules.
6521         * d-exp.y: Update rules.
6522         * c-exp.y: Update rules.
6523
6524 2019-04-04  Tom Tromey  <tom@tromey.com>
6525
6526         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6527         lex_operator, push_back>: New methods.
6528         Update all rules.
6529         (rust_parser::lex_hex, lex_escape): Rename and update.
6530         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6531         (rust_parser::lex_operator): Rename and update.
6532         (rust_parser::lex_number, rustyylex, rustyyerror)
6533         (rust_lex_test_init, rust_lex_test_sequence)
6534         (rust_lex_test_push_back, rust_lex_tests): Update.
6535         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6536         parameter.
6537         <lexptr, prev_lexptr>: New members.
6538         (lexptr, prev_lexptr): Don't declare.
6539         * parse.c (lexptr, prev_lexptr): Remove globals.
6540         (parse_exp_in_context): Update.
6541         * p-exp.y (yylex, yyerror): Update.
6542         * m2-exp.y (parse_number, yylex, yyerror): Update.
6543         * go-exp.y (lex_one_token, yyerror): Update.
6544         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6545         * d-exp.y (lex_one_token, yyerror): Update.
6546         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6547         (lex_one_token, yyerror): Update.
6548         * ada-lex.l (YY_INPUT): Update.
6549         (rewind_to_char): Update.
6550         * ada-exp.y (yyerror): Update.
6551
6552 2019-04-04  Tom Tromey  <tom@tromey.com>
6553
6554         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6555         * parser-defs.h (struct parser_state) <parser_state>: Add new
6556         parameter.
6557         <comma_terminates>: New member.
6558         (comma_terminates): Don't declare global.
6559         * parse.c (comma_terminates): Remove global.
6560         (parse_exp_in_context): Update.
6561         * p-exp.y (yylex): Update.
6562         * m2-exp.y (yylex): Update.
6563         * go-exp.y (lex_one_token): Update.
6564         * f-exp.y (yylex): Update.
6565         * d-exp.y (lex_one_token): Update.
6566         * c-exp.y (lex_one_token): Update.
6567         * ada-lex.l: Update.
6568
6569 2019-04-04  Tom Tromey  <tom@tromey.com>
6570
6571         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6572         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6573         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6574         * parser-defs.h (paren_depth): Don't declare.
6575         * parse.c (paren_depth): Remove global.
6576         (parse_exp_in_context): Update.
6577         * p-exp.y (paren_depth): New global.
6578         (pascal_parse): Initialize it.
6579         * m2-exp.y (paren_depth): New global.
6580         (m2_parse): Initialize it.
6581         * go-exp.y (paren_depth): New global.
6582         (go_parse): Initialize it.
6583         * f-exp.y (paren_depth): New global.
6584         (f_parse): Initialize it.
6585         * d-exp.y (paren_depth): New global.
6586         (d_parse): Initialize it.
6587         * c-exp.y (paren_depth): New global.
6588         (c_parse): Initialize it.
6589         * ada-lex.l (paren_depth): New global.
6590         (lexer_init): Initialize it.
6591
6592 2019-04-04  Tom Tromey  <tom@tromey.com>
6593
6594         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6595         (rust_parser::convert_ast_to_type)
6596         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6597         * parser-defs.h (struct parser_state) <parser_state>: Add
6598         parameters.  Initialize new members.
6599         <expression_context_block, expression_context_pc>: New members.
6600         * parse.c (expression_context_block, expression_context_pc):
6601         Remove globals.
6602         (parse_exp_in_context): Update.
6603         * p-exp.y: Update all rules.
6604         (yylex): Update.
6605         * m2-exp.y: Update all rules.
6606         (yylex): Update.
6607         * go-exp.y (yylex): Update.
6608         * f-exp.y (yylex): Update.
6609         * d-exp.y: Update all rules.
6610         (yylex): Update.
6611         * c-exp.y: Update all rules.
6612         (lex_one_token, classify_name, yylex, c_parse): Update.
6613         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6614
6615 2019-04-04  Tom Tromey  <tom@tromey.com>
6616
6617         * gdbarch.h, gdbarch.c: Rebuild.
6618         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6619         * stap-probe.h:
6620         (struct stap_parse_info): Replace "parser_state" with
6621         "expr_builder".
6622         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6623         (parser_state): New class.
6624         * parse.c (expr_builder): Rename.
6625         (expr_builder::release): Rename.
6626         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6627         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6628         (write_exp_elt_longcst, write_exp_elt_floatcst)
6629         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6630         (write_exp_string_vector, write_exp_bitstring)
6631         (write_exp_msymbol, mark_struct_expression)
6632         (write_dollar_variable)
6633         (insert_type_address_space, increase_expout_size): Replace
6634         "parser_state" with "expr_builder".
6635         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6636         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6637         "parser_state" with "expr_builder".
6638
6639 2019-04-04  Tom Tromey  <tom@tromey.com>
6640
6641         * rust-exp.y: Replace "parse_language" with method call.
6642         * p-exp.y:
6643         (yylex): Replace "parse_language" with method call.
6644         * m2-exp.y:
6645         (yylex): Replace "parse_language" with method call.
6646         * go-exp.y (classify_name): Replace "parse_language" with method
6647         call.
6648         * f-exp.y (yylex): Replace "parse_language" with method call.
6649         * d-exp.y (lex_one_token): Replace "parse_language" with method
6650         call.
6651         * c-exp.y:
6652         (lex_one_token, classify_name, yylex): Replace "parse_language"
6653         with method call.
6654         * ada-exp.y (find_primitive_type, type_char)
6655         (type_system_address): Replace "parse_language" with method call.
6656
6657 2019-04-04  Tom Tromey  <tom@tromey.com>
6658
6659         * rust-exp.y: Replace "parse_gdbarch" with method call.
6660         * parse.c (write_dollar_variable, insert_type_address_space):
6661         Replace "parse_gdbarch" with method call.
6662         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6663         call.
6664         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6665         call.
6666         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6667         "parse_gdbarch" with method call.
6668         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6669         with method call.
6670         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6671         "parse_gdbarch" with method call.
6672         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6673         "parse_gdbarch" with method call.
6674         * c-exp.y (parse_type, parse_number, classify_name): Replace
6675         "parse_gdbarch" with method call.
6676         * ada-lex.l: Replace "parse_gdbarch" with method call.
6677         * ada-exp.y (parse_type, find_primitive_type, type_char)
6678         (type_system_address): Replace "parse_gdbarch" with method call.
6679
6680 2019-04-04  Tom Tromey  <tom@tromey.com>
6681
6682         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6683         * stap-probe.c (stap_parse_argument): Update.
6684         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6685         initial_size parameter.
6686         * rust-exp.y (rust_lex_tests): Update.
6687         * parse.c (parser_state): Update.
6688         (parse_exp_in_context): Update.
6689         * parser-defs.h (struct parser_state) <parser_state>: Remove
6690         "initial_size" parameter.
6691
6692 2019-04-04  Tom Tromey  <tom@tromey.com>
6693
6694         * parser-defs.h (increase_expout_size): Don't declare.
6695         * parse.c (increase_expout_size): Now static.
6696
6697 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6698
6699         * gnu-nat.c (gnu_nat_target::wait): Fix
6700         target_waitstatus_to_string call.
6701
6702 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * eval.c (evaluate_subexp_standard): Handle internal functions
6705         during Fortran function call handling.
6706
6707 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6708
6709         * NEWS: Mention new internal functions.
6710         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6711         (read_base_type): Use dwarf2_init_complex_target_type.
6712         * value.c (creal_internal_fn): New function.
6713         (cimag_internal_fn): New function.
6714         (_initialize_values): Register new internal functions.
6715
6716 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6717
6718         * infrun.c (stop_all_threads): If debug_infrun, always
6719         trace the wait status after wait_one, using
6720         target_waitstatus_to_string and target_pid_to_str.
6721         (handle_inferior_event): Replace various trace of
6722         wait status kind by a single trace.
6723         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6724         wait status kind image by target_waitstatus_to_string.
6725         * target/waitstatus.c (target_waitstatus_to_string): Fix
6726         obsolete comment.
6727
6728 2019-04-01  Tom Tromey  <tromey@adacore.com>
6729
6730         PR symtab/23331:
6731         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6732
6733 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6734             Pedro Alves  <palves@redhat.com>
6735
6736         * top.c (quit_force): Call 'finalize_values'.
6737         * value.c (finalize_values): New function.
6738         * value.h (finalize_values): Declare.
6739
6740 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6741
6742         * NEWS: Announce $_gdb_major and $_gdb_minor.
6743
6744         * top.c (init_gdb_version_vars): New function.
6745         (gdb_init): Call init_gdb_version_vars.
6746
6747 2019-03-29  Tom Tromey  <tromey@adacore.com>
6748
6749         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6750         help text.  Remove dead code.
6751
6752 2019-03-29  Keith Seitz  <keiths@redhat.com>
6753
6754         From Siddhesh Poyarekar:
6755         * f-lang.h (f77_get_upperbound): Return LONGEST.
6756         (f77_get_lowerbound): Likewise.
6757         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6758         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6759         print them.
6760         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6761         plongest to format print it.
6762         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6763         (f77_get_upperbound): Likewise.
6764         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6765         LOWER_BOUND to LONGEST.
6766         (f77_create_arrayprint_offset_tbl): Likewise.
6767
6768 2019-03-29  Keith Seitz  <keiths@redhat.com>
6769
6770         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6771         %s/pulongest for TYPE_LENGTH instead of %d in format
6772         strings.
6773         * ada-typerint.c (ada_print_type): Likewise.
6774         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6775         * compile/compile-c-support.c (generate_register_struct): Likewise.
6776         * gdbtypes.c (recursive_dump_type): Likewise.
6777         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6778         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6779         instead of %d in format strings.
6780         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6781         to std::min to ULONGEST.
6782         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6783         instead of %d in format strings.
6784         * tracepoint.c (info_scope_command): Likewise.
6785         * typeprint.c (print_offset_data::update)
6786         (print_offset_data::finish): Likewise.
6787         * xtensa-tdep.c (xtensa_store_return_value)
6788         (xtensa_push_dummy_call): Likewise.
6789
6790 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6791
6792         * windows-nat.c (display_selector): Fixed format specifications
6793         for 64-bit Cygwin.
6794
6795 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6798
6799 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6800
6801         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6802         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6803         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6804         (nios2_linux_init_abi): Install it.
6805
6806 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6807
6808         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6809
6810 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6811
6812         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6813
6814 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6815             Tom Tromey  <tromey@adacore.com>
6816
6817         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6818
6819 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6820
6821         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6822         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6823         method to compute the bounds of range types. Also print "[evaluated]"
6824         if the bounds' values come from a dynamic evaluation.
6825
6826 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6827
6828         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6829         whitespace when pretty printing is on.
6830
6831 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6832
6833         * ppc-linux-nat.c: Add include.
6834
6835 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6836
6837         * NEWS: Mention AArch64 Pointer Authentication.
6838
6839 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6840
6841         * arm-linux-nat.c: Add include.
6842
6843 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6844
6845         * source-cache.c (source_cache::get_source_lines): Re-read
6846         fullname after calling open_source_file.
6847
6848 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6849
6850         * NEWS: Mention TLS support for FreeBSD.
6851
6852 2019-03-25  Tom Tromey  <tromey@adacore.com>
6853
6854         * minsyms.c (BUNCH_SIZE): Update comment.
6855         (~minimal_symbol_reader): Remove old comment.
6856         (compact_minimal_symbols): Update comment.
6857         (minimal_symbol_reader::install): Remove old comment.  Update
6858         other comments.
6859
6860 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6861
6862         * s390-linux-nat.c: Add include.
6863
6864 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6865
6866         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6867         Call linux_get_hwcap.
6868         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6869         Likewise.
6870         (aarch64_linux_get_hwcap): Remove function.
6871         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6872         declaration.
6873         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6874         linux_get_hwcap.
6875         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6876         * linux-tdep.c (linux_get_hwcap): Add function.
6877         (linux_get_hwcap2): Likewise.
6878         * linux-tdep.h (linux_get_hwcap): Add declaration.
6879         (linux_get_hwcap2): Likewise.
6880         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6881         (ppc_linux_get_hwcap2): Likewise.
6882         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6883         linux_get_hwcap.
6884         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6885         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6886         (ppc_linux_nat_target::read_description): Likewise.
6887         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6888         * s390-linux-nat.c: Likewise.
6889         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6890
6891 2019-03-24  Tom Tromey  <tom@tromey.com>
6892
6893         * ada-lang.c (standard_lookup): Simplify initialization.
6894         (ada_lookup_symbol_nonlocal): Simplify return.
6895         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6896         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6897         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6898         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6899         initialization.
6900         * solib.c (solib_global_lookup): Simplify.
6901         * symtab.c (null_block_symbol): Remove.
6902         (symbol_cache_lookup): Simplify returns.
6903         (lookup_language_this): Simplify returns.
6904         (lookup_symbol_aux): Simplify return.
6905         (lookup_local_symbol): Simplify returns.
6906         (lookup_global_symbol_from_objfile): Simplify return.
6907         (lookup_symbol_in_objfile_symtabs)
6908         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6909         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6910         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6911         * cp-namespace.c (cp_lookup_bare_symbol)
6912         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6913         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6914         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6915         (cp_lookup_symbol_via_imports): Simplify initialization.
6916         (find_symbol_in_baseclass): Likewise.
6917         * symtab.h (null_block_symbol): Remove.
6918         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6919         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6920         (d_lookup_symbol_module): Likewise.
6921         (find_symbol_in_baseclass): Simplify initialization.
6922
6923 2019-03-24  Tom Tromey  <tom@tromey.com>
6924
6925         * expression.h: Don't include symtab.h.
6926         (struct block): Forward declare.
6927
6928 2019-03-24  Tom Tromey  <tom@tromey.com>
6929
6930         * c-exp.y (typebase): Remove casts.
6931         * gdbtypes.c (lookup_unsigned_typename, )
6932         (lookup_signed_typename): Remove cast.
6933         * eval.c (parse_to_comma_and_eval): Remove cast.
6934         * parse.c (write_dollar_variable): Remove cast.
6935         * block.h (struct block) <superblock>: Now const.
6936         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6937         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6938         (map_block): Make "block" const.
6939         * symfile.h (struct quick_symbol_functions)
6940         <map_matching_symbols>: Constify block argument to "callback".
6941         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6942         const.
6943         (find_pc_sect_compunit_symtab): Make "b" const.
6944         (find_symbol_at_address): Likewise.
6945         (search_symbols): Likewise.
6946         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6947         (dw2_debug_names_lookup_symbol): Likewise.
6948         (dw2_map_matching_symbols): Update.
6949         * p-valprint.c (pascal_val_print): Remove "block".
6950         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6951         (aux_add_nonlocal_symbols): Make "block" const.
6952         (resolve_subexp): Remove cast.
6953         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6954         const.
6955         (iterate_over_file_blocks): Likewise.
6956         * f-exp.y (%union) <bval>: Remove.
6957         * coffread.c (patch_opaque_types): Make "b" const.
6958         * spu-tdep.c (spu_catch_start): Make "block" const.
6959         * c-valprint.c (print_unpacked_pointer): Remove "block".
6960         * symmisc.c (dump_symtab_1): Make "b" const.
6961         (block_depth): Make "block" const.
6962         * d-exp.y (%union) <bval>: Remove.
6963         * cp-support.h (cp_lookup_rtti_type): Update.
6964         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6965         * psymtab.c (psym_lookup_symbol): Make "block" const.
6966         (maintenance_check_psymtabs): Make "b" const.
6967         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6968         (enumerate_locals, enumerate_args): Update.
6969         * python/py-symtab.c (stpy_global_block): Make "block" const.
6970         (stpy_static_block): Likewise.
6971         * inline-frame.c (block_starting_point_at): Make "new_block"
6972         const.
6973         * block.c (find_block_in_blockvector): Make return type const.
6974         (blockvector_for_pc_sect): Make "b" const.
6975         (find_block_in_blockvector): Make "b" const.
6976
6977 2019-03-23  Tom Tromey  <tom@tromey.com>
6978
6979         * varobj.c (varobj_create): Update.
6980         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6981         * printcmd.c (display_command, do_one_display): Don't reset
6982         innermost_block.
6983         * parser-defs.h (enum innermost_block_tracker_type): Move to
6984         expression.h.
6985         (innermost_block): Update comment.
6986         * parse.c (parse_exp_1): Add tracker_types parameter.
6987         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6988         tracker_types parameter.  Reset innermost_block.
6989         (parse_exp_in_context): Remove.
6990         (parse_expression_for_completion): Update.
6991         * objfiles.c (~objfile): Don't reset expression_context_block or
6992         innermost_block.
6993         * expression.h (enum innermost_block_tracker_type): Move from
6994         parser-defs.h.
6995         (parse_exp_1): Add tracker_types parameter.
6996         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6997         reset innermost_block.
6998
6999 2019-03-23  Tom Tromey  <tom@tromey.com>
7000
7001         * objfiles.h: Include bcache.h.
7002
7003 2019-03-23  Tom Tromey  <tom@tromey.com>
7004
7005         * linespec.c (get_current_search_block): Use
7006         scoped_restore_current_language.
7007         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7008
7009 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7010             Jiong Wang  <jiong.wang@arm.com>
7011
7012         * aarch64-linux-tdep.c
7013         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7014         section.
7015         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7016
7017 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7018             Jiong Wang  <jiong.wang@arm.com>
7019
7020         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7021         instructions.
7022         (aarch64_analyze_prologue_test): Add PACIASP test.
7023         (aarch64_prologue_prev_register): Unmask PC value.
7024
7025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7026             Jiong Wang  <jiong.wang@arm.com>
7027
7028         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7029         (aarch64_dwarf2_prev_register): Unmask PC value.
7030         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7031         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7032         DW_CFA_AARCH64_negate_ra_state.
7033         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7034
7035 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7036             Jiong Wang  <jiong.wang@arm.com>
7037
7038         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7039         registers.
7040         (aarch64_pseudo_register_name): Likewise.
7041         (aarch64_pseudo_register_type): Likewise.
7042         (aarch64_pseudo_register_reggroup_p): Likewise.
7043         (aarch64_gdbarch_init): Add pauth registers.
7044         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7045         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7046         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7047         (struct gdbarch_tdep): Add regnum for ra_state.
7048
7049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7050             Jiong Wang  <jiong.wang@arm.com>
7051
7052         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7053
7054 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7055             Jiong Wang  <jiong.wang@arm.com>
7056
7057         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7058         function.
7059         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7060         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7061         (aarch64_gdbarch_init): Add puth registers.
7062         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7063         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7064         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7065
7066 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7067             Jiong Wang  <jiong.wang@arm.com>
7068
7069         * aarch64-linux-nat.c
7070         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7071         * aarch64-linux-tdep.c
7072         (aarch64_linux_core_read_description): Likewise.
7073         (aarch64_linux_get_hwcap): New function.
7074         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7075         (aarch64_linux_get_hwcap): New declaration.
7076
7077 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7078             Jiong Wang  <jiong.wang@arm.com>
7079
7080         * aarch64-linux-nat.c
7081         (aarch64_linux_nat_target::read_description): Add pauth param.
7082         * aarch64-linux-tdep.c
7083         (aarch64_linux_core_read_description): Likewise.
7084         * aarch64-tdep.c (struct target_desc): Add in pauth.
7085         (aarch64_read_description): Add pauth param.
7086         (aarch64_gdbarch_init): Likewise.
7087         * aarch64-tdep.h (aarch64_read_description): Likewise.
7088         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7089         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7090         * features/Makefile: Add new files.
7091         * features/aarch64-pauth.c: New file.
7092         * features/aarch64-pauth.xml: New file.
7093
7094 2019-03-20  Tom Tromey  <tromey@adacore.com>
7095
7096         * infrun.c (handle_inferior_event): Rename from
7097         handle_inferior_event_1.  Create a scoped_value_mark.
7098         (handle_inferior_event): Remove.
7099
7100 2019-03-19  Tom Tromey  <tromey@adacore.com>
7101
7102         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7103         * infrun.h (print_stop_event): Add "displays" parameter.
7104         * infrun.c (print_stop_event): Add "displays" parameter.
7105
7106 2019-03-19  Pedro Alves  <palves@redhat.com>
7107
7108         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7109         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7110         to -1.  Fix TABs vs spaces.
7111         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7112         * tui/tui-out.h (tui_ui_out) Add intro comments.
7113         <m_line, m_start_of_line>: In-class initialize, and add describing
7114         comment.
7115
7116 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7117
7118         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7119         variable names.
7120         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7121
7122 2019-03-18  Pedro Alves  <palves@redhat.com>
7123             Eli Zaretskii <eliz@gnu.org>
7124
7125         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7126         m_line and m_start_of_line.
7127
7128 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7129
7130         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7131         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7132         it returns a newline.  This fixes a regression in TU mode, whereby
7133         the next line is output on the same screen line as the user input.
7134
7135 2019-03-18  Tom Tromey  <tromey@adacore.com>
7136
7137         * minsyms.c (minimal_symbol_reader::install): Remove call to
7138         obstack_blank.
7139
7140 2019-03-18  Pedro Alves  <palves@redhat.com>
7141
7142         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7143         New globals.
7144         (apply_style): New, factored out from ...
7145         (apply_ansi_escape): ... this.  Handle reverse video mode.
7146         (tui_set_reverse_mode): New function.
7147         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7148         * tui/tui-winsource.c (tui_show_source_line): Use
7149         tui_set_reverse_mode instead of setting A_STANDOUT.
7150         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7151         New setter methods.
7152
7153 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7154
7155         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7156         Handle tabs.
7157
7158 2019-03-18  Tom Tromey  <tromey@adacore.com>
7159
7160         * ada-lang.c (empty_array): Add "high" parameter.
7161         (ada_evaluate_subexp): Update.
7162
7163 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7164
7165         * unittests/string_view-selftests.c: Define
7166         _initialize_string_view_selftests unconditionally.
7167
7168 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7169
7170         PR gdb/24350
7171         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7172
7173 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7174
7175         PR gdb/24351
7176         * windows-nat.c (display_selector): Fix format specifiers.
7177
7178 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7179
7180         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7181         tui_refill_source_window instead of tui_refresh_win, to update the
7182         current execution line.  This fixes redisplay of the current line
7183         when stepping through the code with "next" or "step".
7184
7185 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7186
7187         * source-cache.c (source_cache::get_source_lines): Call
7188         find_source_lines to initialize s->nlines.  This fixes vertical
7189         scrolling of TUI source window when the DOWN arrow is pressed.
7190
7191 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7192
7193         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7194         linux-thread-db.c (_initialize_thread_db): Likewise.
7195
7196 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7197
7198         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7199         wclrtoeol in tui_show_source_line".  This reverts changes made in
7200         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7201
7202 2019-03-15  Tom Tromey  <tom@tromey.com>
7203
7204         * symtab.h (struct minimal_symbol): Derive from
7205         general_symbol_info.
7206         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7207         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7208         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7209         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7210         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7211         (MSYMBOL_SEARCH_NAME): Update.
7212         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7213         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7214         * minsyms.c (minimal_symbol_reader::record_full): Update.
7215
7216 2019-03-15  Tom Tromey  <tom@tromey.com>
7217
7218         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7219
7220 2019-03-15  Tom Tromey  <tom@tromey.com>
7221
7222         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7223         unique_xmalloc_ptr.
7224         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7225         Update.
7226         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7227         (build_minimal_symbol_hash_tables)
7228         (minimal_symbol_reader::install): Update.
7229
7230 2019-03-15  Tom Tromey  <tom@tromey.com>
7231
7232         * symtab.c (create_demangled_names_hash): Update.
7233         (symbol_set_names): Update.
7234         * objfiles.h (struct objfile_per_bfd_storage)
7235         <demangled_names_hash>: Now an htab_up.
7236         * objfiles.c (objfile_per_bfd_storage): Simplify.
7237
7238 2019-03-15  Tom Tromey  <tom@tromey.com>
7239
7240         * objfiles.h (struct objfile_per_bfd_storage): Declare
7241         destructor.
7242         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7243         New.
7244         (get_objfile_bfd_data): Use new.  Don't initialize
7245         language_of_main.
7246         (free_objfile_per_bfd_storage): Remove.
7247         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7248
7249 2019-03-15  Tom Tromey  <tom@tromey.com>
7250
7251         * symfile.c (reread_symbols): Update.
7252         * objfiles.c (objfile::objfile): Update.
7253         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7254         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7255         comment.
7256         (minimal_symbol_reader::install): Update.
7257         (terminate_minimal_symbol_table): Remove.
7258         * jit.c (jit_object_close_impl): Update.
7259
7260 2019-03-15  Tom Tromey  <tom@tromey.com>
7261
7262         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7263         initializations.
7264
7265 2019-03-15  Tom Tromey  <tom@tromey.com>
7266
7267         * objfiles.h (struct objfile_per_bfd_storage)
7268         <demangled_hash_languages>: Now a bitset.
7269         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7270         (lookup_minimal_symbol): Update.
7271
7272 2019-03-15  Tom Tromey  <tom@tromey.com>
7273
7274         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7275         Don't return the symbol.
7276         * coffread.c (record_minimal_symbol): Use record_full.
7277
7278 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7279
7280         The MS-Windows port of ncurses fails to switch to a color pair if
7281         one or both of the colors are the implicit default colors.  This
7282         change records the default colors when TUI is initialized, and
7283         then specifies them explicitly when a color pair uses the default
7284         colors.  This allows color styling in TUI mode on MS-Windows.
7285
7286         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7287         ncurses_norm_attr.
7288         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7289         colors in ncurses_norm_attr.
7290         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7291         "none", replace it with the default color recorded in
7292         ncurses_norm_attr.
7293
7294 2019-03-14  Tom Tromey  <tromey@adacore.com>
7295
7296         * source-cache.h (class source_cache) <get_source_lines>: Return
7297         std::string.
7298         * source-cache.c (source_cache::extract_lines): Handle case where
7299         first_pos==npos.  Return std::string.
7300         (source_cache::get_source_lines): Update.
7301
7302 2019-03-14  Tom Tromey  <tromey@adacore.com>
7303
7304         * NEWS: Add item for "style sources" commands.
7305         * source-cache.c (source_cache::get_source_lines): Check
7306         source_styling.
7307         * cli/cli-style.c (source_styling): New global.
7308         (_initialize_cli_style): Add "style sources" commands.
7309         (show_style_sources): New function.
7310         * cli/cli-style.h (source_styling): Declare.
7311
7312 2019-03-14  Pedro Alves  <palves@redhat.com>
7313             Tom Tromey  <tromey@adacore.com>
7314
7315         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7316         * tui/tui-winsource.c (tui_refill_source_window): New function,
7317         from...
7318         (tui_horizontal_source_scroll): ... here.  Move some logic.
7319         * cli/cli-style.c (set_style_enabled): Notify new observable.
7320         * tui/tui-hooks.c (tui_redisplay_source): New function.
7321         (tui_attach_detach_observers): Attach or detach
7322         tui_redisplay_source.
7323         * observable.h (source_styling_changed): New observable.
7324         * observable.c: Define source_styling_changed observable.
7325
7326 2019-03-13  Tom Tromey  <tromey@adacore.com>
7327
7328         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7329         (i386_gnu_nat_target::store_registers): Update.
7330         * target-debug.h (target_debug_print_std_string): New macro.
7331         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7332         * windows-tdep.c (display_one_tib): Update.
7333         * tui/tui-stack.c (tui_make_status_line): Update.
7334         * top.c (print_inferior_quit_action): Update.
7335         * thread.c (thr_try_catch_cmd): Update.
7336         (add_thread_with_info): Update.
7337         (thread_target_id_str): Update.
7338         (thr_try_catch_cmd): Update.
7339         (thread_command): Update.
7340         (thread_find_command): Update.
7341         * record-btrace.c (record_btrace_target::info_record)
7342         (record_btrace_resume_thread, record_btrace_target::resume)
7343         (record_btrace_cancel_resume, record_btrace_step_thread)
7344         (record_btrace_target::wait, record_btrace_target::wait)
7345         (record_btrace_target::wait, record_btrace_target::stop): Update.
7346         * progspace.c (print_program_space): Update.
7347         * process-stratum-target.c
7348         (process_stratum_target::thread_address_space): Update.
7349         * linux-fork.c (linux_fork_mourn_inferior)
7350         (detach_checkpoint_command, info_checkpoints_command)
7351         (linux_fork_context): Update.
7352         (linux_fork_detach): Update.
7353         (class scoped_switch_fork_info): Update.
7354         (delete_checkpoint_command): Update.
7355         * infrun.c (follow_fork_inferior): Update.
7356         (follow_fork_inferior): Update.
7357         (proceed_after_vfork_done): Update.
7358         (handle_vfork_child_exec_or_exit): Update.
7359         (follow_exec): Update.
7360         (displaced_step_prepare_throw): Update.
7361         (displaced_step_restore): Update.
7362         (start_step_over): Update.
7363         (resume_1): Update.
7364         (clear_proceed_status_thread): Update.
7365         (proceed): Update.
7366         (print_target_wait_results): Update.
7367         (do_target_wait): Update.
7368         (context_switch): Update.
7369         (stop_all_threads): Update.
7370         (restart_threads): Update.
7371         (finish_step_over): Update.
7372         (handle_signal_stop): Update.
7373         (switch_back_to_stepped_thread): Update.
7374         (keep_going_pass_signal): Update.
7375         (print_exited_reason): Update.
7376         (normal_stop): Update.
7377         * inferior.c (inferior_pid_to_str): Change return type.
7378         (print_selected_inferior): Update.
7379         (add_inferior): Update.
7380         (detach_inferior): Update.
7381         * dummy-frame.c (fprint_dummy_frames): Update.
7382         * dcache.c (dcache_info_1): Update.
7383         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7384         (btrace_fetch, btrace_clear): Update.
7385         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7386         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7387         type.
7388         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7389         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7390         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7391         * gdbarch.c, gdbarch.h: Rebuild.
7392         * gdbarch.sh (core_pid_to_str): Change return type.
7393         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7394         return type.
7395         (windows_nat_target::pid_to_str): Change return type.
7396         (windows_delete_thread): Update.
7397         (windows_nat_target::attach): Update.
7398         (windows_nat_target::files_info): Update.
7399         * target-delegates.c: Rebuild.
7400         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7401         return type.
7402         (sol_thread_target::pid_to_str): Change return type.
7403         * remote.c (class remote_target) <pid_to_str>: Change return
7404         type.
7405         (remote_target::pid_to_str): Change return type.
7406         (extended_remote_target::attach, remote_target::remote_stop_ns)
7407         (remote_target::remote_notif_remove_queued_reply)
7408         (remote_target::push_stop_reply, remote_target::disable_btrace):
7409         Update.
7410         (extended_remote_target::attach): Update.
7411         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7412         type.
7413         (gdbsim_target::pid_to_str): Change return type.
7414         * ravenscar-thread.c (struct ravenscar_thread_target)
7415         <pid_to_str>: Change return type.
7416         (ravenscar_thread_target::pid_to_str): Change return type.
7417         * procfs.c (class procfs_target) <pid_to_str>: Change return
7418         type.
7419         (procfs_target::pid_to_str): Change return type.
7420         (procfs_target::attach): Update.
7421         (procfs_target::detach): Update.
7422         (procfs_target::fetch_registers): Update.
7423         (procfs_target::store_registers): Update.
7424         (procfs_target::wait): Update.
7425         (procfs_target::files_info): Update.
7426         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7427         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7428         return type.
7429         (nto_procfs_target::pid_to_str): Change return type.
7430         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7431         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7432         return type.
7433         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7434         (exit_lwp): Update.
7435         (attach_proc_task_lwp_callback, get_detach_signal)
7436         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7437         (linux_nat_target::resume, wait_lwp, stop_callback)
7438         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7439         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7440         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7441         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7442         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7443         type.
7444         (inf_ptrace_target::attach): Update.
7445         (inf_ptrace_target::files_info): Update.
7446         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7447         type.
7448         (go32_nat_target::pid_to_str): Change return type.
7449         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7450         (gnu_nat_target::wait): Update.
7451         (gnu_nat_target::wait): Update.
7452         (gnu_nat_target::resume): Update.
7453         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7454         (fbsd_nat_target::wait): Update.
7455         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7456         type.
7457         (darwin_nat_target::attach): Update.
7458         * corelow.c (class core_target) <pid_to_str>: Change return type.
7459         (core_target::pid_to_str): Change return type.
7460         * target.c (normal_pid_to_str): Change return type.
7461         (default_pid_to_str): Likewise.
7462         (target_pid_to_str): Change return type.
7463         (target_translate_tls_address): Update.
7464         (target_announce_detach): Update.
7465         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7466         return type.
7467         (bsd_uthread_target::pid_to_str): Change return type.
7468         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7469         type.
7470         (bsd_kvm_target::pid_to_str): Change return type.
7471         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7472         return type.
7473         (aix_thread_target::pid_to_str): Change return type.
7474         * target.h (struct target_ops) <pid_to_str>: Change return type.
7475         (target_pid_to_str, normal_pid_to_str): Likewise.
7476         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7477         type.
7478         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7479         type.
7480         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7481         return type.
7482         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7483         type.
7484         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7485         type.
7486         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7487         return type.
7488
7489 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7490
7491         * NEWS: Mention that the new default MI version is 3.  Mention
7492         changes to the output of commands and events that deal with
7493         multi-location breakpoints.
7494         * breakpoint.c: Include "mi/mi-out.h".
7495         (print_one_breakpoint): Change output syntax if using MI version
7496         >= 3.
7497         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7498         New.
7499         (mi_multi_location_breakpoint_output_fixed): New.
7500         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7501         (mi_cmd_fix_multi_location_breakpoint_output): New.
7502         (mi_multi_location_breakpoint_output_fixed): New.
7503         * mi/mi-cmds.c (mi_cmds): Register command
7504         -fix-multi-location-breakpoint-output.
7505         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7506         interpreter "mi".
7507
7508 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7509
7510         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7511         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7512         instantiate mi_ui_out based on interpreter name.
7513         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7514         * mi/mi-main.c (mi_load_progress): Likewise.
7515
7516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7517
7518         * NEWS: Combine separate "New targets" sections for 8.3.
7519
7520 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7521
7522         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7523         (ppcfbsd_init_abi): Install gdbarch
7524         "fetch_tls_load_module_address" and "get_thread_local_address"
7525         methods.
7526
7527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7528
7529         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7530         (riscv_fbsd_init_abi): Install gdbarch
7531         "fetch_tls_load_module_address" and "get_thread_local_address"
7532         methods.
7533
7534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7535
7536         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7537         (i386fbsd_init_abi): Install gdbarch
7538         "fetch_tls_load_module_address" and "get_thread_local_address"
7539         methods.
7540
7541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7542
7543         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7544         (amd64fbsd_init_abi): Install gdbarch
7545         "fetch_tls_load_module_address" and "get_thread_local_address"
7546         methods.
7547
7548 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7549
7550         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7551         (struct fbsd_pspace_data): New type.
7552         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7553         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7554         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7555         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7556         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7557
7558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7559
7560         * gdbtypes.c (lookup_struct_elt): New function.
7561         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7562         * gdbtypes.h (struct struct_elt): New type.
7563         (lookup_struct_elt): New prototype.
7564
7565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7566
7567         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7568         remove disabled code block.
7569
7570 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7571
7572         * gdbarch.sh (get_thread_local_address): New method.
7573         * gdbarch.h, gdbarch.c: Regenerate.
7574         * target.c (target_translate_tls_address): Use
7575         gdbarch_get_thread_local_address if present instead of
7576         target::get_thread_local_address.
7577
7578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7579
7580         * target.h (target::get_thread_local_address): Update comment.
7581
7582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7583
7584         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7585         objfile->separate_debug_objfile_backlink if not NULL.
7586
7587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7588
7589         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7590         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7591         (amd64bsd_store_inferior_registers): Likewise.
7592         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7593         Enable segment base registers.
7594         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7595         PT_GETFSBASE and PT_GETGSBASE.
7596         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7597         PT_SETGSBASE.
7598         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7599         segment base registers.
7600         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7601
7602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7603
7604         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7605         Update calls to i386_target_description to add 'segments'
7606         parameter.
7607         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7608         add segment base registers.
7609         * arch/i386.c (i386_create_target_description): Add 'segments'
7610         parameter to enable segment base registers.
7611         * arch/i386.h (i386_create_target_description): Likewise.
7612         * features/i386/32bit-segments.xml: New file.
7613         * features/i386/32bit-segments.c: Generate.
7614         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7615         call to i386_target_description to add 'segments' parameter.
7616         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7617         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7618         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7619         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7620         if feature is present.
7621         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7622         Add 'segments' parameter to call to i386_target_description.
7623         (i386_target_description): Add 'segments' parameter to enable
7624         segment base registers.
7625         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7626         to call to i386_target_description.
7627         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7628         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7629         Define I386_NUM_REGS.
7630         (i386_target_description): Add 'segments' parameter to enable
7631         segment base registers.
7632
7633 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7634
7635         PR/24325
7636         * source-cache.c: #undef open and close, to avoid unresolved
7637         externals during linking.
7638
7639 2019-03-12  Tom Tromey  <tromey@adacore.com>
7640
7641         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7642         const.  Add initializers.
7643         (_initialize_remote): Don't initialize ptid globals.
7644
7645 2019-03-12  Pedro Alves  <palves@redhat.com>
7646
7647         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7648
7649 2019-03-12  Pedro Alves  <palves@redhat.com>
7650
7651         * cp-name-parser.y (main): Remove unused 'len' variable.
7652
7653 2019-03-12  Tom Tromey  <tromey@adacore.com>
7654
7655         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7656         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7657
7658 2019-03-12  Tom Tromey  <tromey@adacore.com>
7659
7660         * linux-nat.c (iterate_over_lwps): Update.
7661         (stop_callback): Remove parameter.
7662         (stop_wait_callback, detach_callback, resume_set_callback)
7663         (select_singlestep_lwp_callback, set_ignore_sigint)
7664         (status_callback, resumed_callback, resume_clear_callback)
7665         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7666         data parameter.
7667         (linux_nat_target::detach, linux_nat_target::resume)
7668         (linux_stop_and_wait_all_lwps, select_event_lwp)
7669         (linux_nat_filter_event, linux_nat_wait_1)
7670         (linux_nat_target::kill, linux_nat_target::stop)
7671         (linux_nat_target::stop): Update.
7672         (linux_nat_resume_callback): Change type.
7673         (resume_stopped_resumed_lwps, count_events_callback)
7674         (select_event_lwp_callback): Likewise.
7675         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7676         * arm-linux-nat.c (struct update_registers_data): Remove.
7677         (update_registers_callback): Change type.
7678         (arm_linux_insert_hw_breakpoint1): Update.
7679         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7680         parameter.
7681         (x86_linux_dr_set_addr): Update.
7682         (x86_linux_dr_set_control): Update.
7683         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7684         (iterate_over_lwps): Use gdb::function_view.
7685         * nat/aarch64-linux-hw-point.c (struct
7686         aarch64_dr_update_callback_param): Remove.
7687         (debug_reg_change_callback): Change type.
7688         (aarch64_notify_debug_reg_change): Update.
7689         * s390-linux-nat.c (s390_refresh_per_info): Update.
7690
7691 2019-03-11  Tom Tromey  <tromey@adacore.com>
7692
7693         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7694         redundant assignment to "this_cu".
7695
7696 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7697
7698         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7699
7700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7701
7702         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7703         from...
7704         (rank_one_type): ... this.
7705
7706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7707
7708         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7709         from...
7710         (rank_one_type): ... this.
7711
7712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7713
7714         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7715         from...
7716         (rank_one_type): ... this.
7717
7718 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7719
7720         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7721         from...
7722         (rank_one_type): ... this.
7723
7724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7725
7726         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7727         from...
7728         (rank_one_type): ... this.
7729
7730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7731
7732         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7733         from...
7734         (rank_one_type): ... this.
7735
7736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7737
7738         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7739         from...
7740         (rank_one_type): ... this.
7741
7742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7743
7744         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7745         from...
7746         (rank_one_type): ... this.
7747
7748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7749
7750         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7751         from...
7752         (rank_one_type): ... this.
7753
7754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7755
7756         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7757         from...
7758         (rank_one_type): ... this.
7759
7760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7761
7762         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7763         from...
7764         (rank_one_type): ... this.
7765
7766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7767
7768         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7769         from...
7770         (rank_one_type): ... this.
7771
7772 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7773
7774         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7775         inferior-events' shows the example events.
7776
7777 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7778
7779         Support styling on native MS-Windows console
7780
7781         PR/24315
7782         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7783         on MS-Windows if $TERM is not defined.
7784
7785         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7786
7787         * posix-hdep.c (gdb_console_fputs):
7788         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7789         functions.
7790         * ui-file.h (gdb_console_fputs): Add prototype.
7791
7792         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7793         back to fputs only if the former returns zero.
7794
7795 2019-03-07  Tom Tromey  <tom@tromey.com>
7796
7797         * symmisc.c (print_symbol_bcache_statistics): Update.
7798         (print_objfile_statistics): Update.
7799         * symfile.c (allocate_symtab): Update.
7800         * stabsread.c: Don't include bcache.h.
7801         * psymtab.h (struct psymbol_bcache): Don't declare.
7802         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7803         (psymbol_bcache_init, psymbol_bcache_free)
7804         (psymbol_bcache_get_bcache): Don't declare.
7805         * psymtab.c (struct psymbol_bcache): Remove.
7806         (psymtab_storage::psymtab_storage): Update.
7807         (psymtab_storage::~psymtab_storage): Update.
7808         (psymbol_bcache_init, psymbol_bcache_free)
7809         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7810         (add_psymbol_to_bcache): Update.
7811         (allocate_psymtab): Update.
7812         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7813         macro_cache>: No longer pointers.
7814         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7815         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7816         * macrotab.c (macro_bcache): Update.
7817         * macroexp.c: Don't include bcache.h.
7818         * gdbtypes.c (check_types_worklist): Update.
7819         (types_deeply_equal): Remove TRY/CATCH.  Update.
7820         * elfread.c (elf_symtab_read): Update.
7821         * dwarf2read.c: Don't include bcache.h.
7822         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7823         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7824         (print_bcache_statistics, bcache_memory_used): Don't declare.
7825         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7826         methods.  Rename all data members.
7827         * bcache.c (struct bcache): Move to bcache.h.
7828         (bcache::expand_hash_table): Rename from expand_hash_table.
7829         (bcache): Remove.
7830         (bcache::insert): Rename from bcache_full.
7831         (bcache::compare): Rename from bcache_compare.
7832         (bcache_xmalloc): Remove.
7833         (bcache::~bcache): Rename from bcache_xfree.
7834         (bcache::print_statistics): Rename from print_bcache_statistics.
7835         (bcache::memory_used): Rename from bcache_memory_used.
7836
7837 2019-03-07  Pedro Alves  <palves@redhat.com>
7838
7839         * infrun.c (normal_stop): Also check for
7840         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7841
7842 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * f-lang.c (value_from_host_double): Moved to...
7845         * value.c (value_from_host_double): ...here.
7846         * value.h (value_from_host_double): Declare.
7847         * guile/scm-math.c (vlscm_convert_typed_number): Use
7848         value_from_host_double.
7849         (vlscm_convert_number): Likewise.
7850         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7851         * python/py-value.c (convert_value_from_python): Likewise.
7852
7853 2019-03-06  Tom Tromey  <tom@tromey.com>
7854
7855         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7856
7857 2019-03-06  Tom Tromey  <tom@tromey.com>
7858
7859         * utils.h (free_current_contents): Don't declare.
7860         * utils.c (free_current_contents): Remove.
7861
7862 2019-03-06  Tom Tromey  <tom@tromey.com>
7863
7864         * top.c (quit_force): Update.
7865         * main.c (captured_command_loop): Update.
7866         * common/new-op.c (operator new): Update.
7867         * common/common-exceptions.c (struct catcher)
7868         <save_cleanup_chain>: Remove member.
7869         (exceptions_state_mc_init): Update.
7870         (exception_try_scope_entry): Return nullptr.
7871         (exception_try_scope_exit, exception_rethrow)
7872         (throw_exception_sjlj, throw_exception_cxx): Update.
7873         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7874         (all_cleanups, do_cleanups, discard_cleanups)
7875         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7876         (restore_cleanups, restore_final_cleanups): Don't declare.
7877         (do_final_cleanups): Remove parameter.
7878         * common/cleanups.c (cleanup_chain, make_cleanup)
7879         (make_cleanup_dtor, all_cleanups, do_cleanups)
7880         (discard_my_cleanups, discard_cleanups)
7881         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7882         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7883         (null_cleanup): Remove.
7884         (do_final_cleanups): Remove parameter.
7885
7886 2019-03-06  Tom Tromey  <tom@tromey.com>
7887
7888         * remote.c (remote_target::remote_parse_stop_reply): Use
7889         unique_xmalloc_ptr.
7890
7891 2019-03-06  Tom Tromey  <tom@tromey.com>
7892
7893         * stabsread.c (struct stabs_field_info): Rename from field_info.
7894         <list, fnlist>: Add initializers.
7895         <obstack>: New member.
7896         (read_member_functions, read_struct_fields, read_baseclasses):
7897         Allocate on obstack.  Don't use cleanups.
7898         (read_one_struct_field, read_member_functions, read_struct_fields)
7899         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7900         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7901         (read_struct_type): Update.
7902
7903 2019-03-06  Tom Tromey  <tom@tromey.com>
7904
7905         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7906         * common/filestuff.h (make_cleanup_close): Don't declare.
7907         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7908         Remove.
7909
7910 2019-03-06  Tom Tromey  <tom@tromey.com>
7911
7912         * solib-aix.c: Use make_scope_exit.
7913
7914 2019-03-06  Tom Tromey  <tom@tromey.com>
7915
7916         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7917         Use make_scope_exit.
7918
7919 2019-03-06  Tom Tromey  <tom@tromey.com>
7920
7921         * solib-svr4.c (disable_probes_interface): Remove parameter.
7922         (svr4_handle_solib_event): Use make_scope_exit.
7923
7924 2019-03-06  Tom Tromey  <tom@tromey.com>
7925
7926         * remote.c (struct stop_reply_deleter): Remove.
7927         (stop_reply_up): Update.
7928         (struct stop_reply): Derive from notif_event.  Don't typedef.
7929         <regcache>: Now a std::vector.
7930         (stop_reply_xfree): Remove.
7931         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7932         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7933         (remote_target::discard_pending_stop_replies): Use delete.
7934         (remote_target::remote_parse_stop_reply): Update.
7935         (remote_target::process_stop_reply): Update.
7936         * remote-notif.h (struct notif_event): Add virtual destructor.
7937         Remove "dtr" member.
7938         (struct notif_client) <alloc_event>: Return a unique_ptr.
7939         (notif_event_xfree): Don't declare.
7940         (notif_event_up): New typedef.
7941         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7942         (notif_event_xfree, do_notif_event_xfree): Remove.
7943         (remote_notif_state_xfree): Update.
7944
7945 2019-03-06  Tom Tromey  <tom@tromey.com>
7946
7947         * infrun.c (displaced_step_clear_cleanup): Now a
7948         forward_scope_exit type.
7949         (displaced_step_prepare_throw): Update.
7950         (displaced_step_fixup): Update.
7951
7952 2019-03-06  Tom Tromey  <tom@tromey.com>
7953
7954         * inferior.h (class inferior): Update comment.
7955         * gdbthread.h (class thread_info): Update comment.
7956
7957 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7958             Tom Tromey  <tom@tromey.com>
7959
7960         * stabsread.h (struct stab_section_list): Remove.
7961         (coffstab_build_psymtabs): Update.
7962         * dbxread.c (symbuf_sections): Now a std::vector.
7963         (sect_idx): New global.
7964         (fill_symbuf): Update.
7965         (coffstab_build_psymtabs): Change type of stabsects parameter.
7966         Update.
7967         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7968         std::vector.
7969         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7970         (coff_locate_sections): Update.
7971         (coff_symfile_read): Remove cleanups.  Update.
7972         (init_stringtab): Add storage parameter.
7973         (free_stringtab, free_stringtab_cleanup): Remove.
7974         (init_lineno): Add storage parameter.
7975         (free_linetab, free_linetab_cleanup): Remove.
7976
7977 2019-03-06  Pedro Alves  <palves@redhat.com>
7978
7979         * linux-fork.c (fork_info::clobber_regs): Delete.
7980         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7981         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7982         comment.  Adjust.
7983         (scoped_switch_fork_info::scoped_switch_fork_info)
7984         (checkpoint_command, linux_fork_context): Adjust
7985         fork_save_infrun_state calls.
7986
7987 2019-03-06  Pedro Alves  <palves@redhat.com>
7988
7989         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7990         (inf_has_multiple_threads): Return 'bool' and rewrite using
7991         inferior_info::threads().
7992
7993 2019-03-06  Pedro Alves  <palves@redhat.com>
7994
7995         * linux-fork.c: Include <list>.
7996         (fork_list): Now a std::list instance.
7997         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7998         (forks_exist_p, find_last_fork): Adjust.
7999         (new_fork): Delete.
8000         (one_fork_p): New.
8001         (add_fork): Adjust.
8002         (free_fork): Delete, folded into fork_info::~fork_info().
8003         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8004         Adjust.
8005         (init_fork_list): Delete.
8006         (linux_fork_killall, linux_fork_mourn_inferior)
8007         (linux_fork_detach, info_checkpoints_command): Adjust.
8008         (_initialize_linux_fork): No longer call init_fork_list.
8009
8010 2019-03-06  Pedro Alves  <palves@redhat.com>
8011
8012         * linux-fork.c (new_fork): New, split out of ...
8013         (add_fork): ... this.  Return void.  Move "first fork" special
8014         case from here, to ...
8015         (checkpoint_command): ... here.
8016         * linux-linux.h (add_fork): Return void.
8017
8018 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8019
8020         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8021
8022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8023             Chris January  <chris.january@arm.com>
8024             David Lecomber  <david.lecomber@arm.com>
8025
8026         * f-exp.y: New token, UNOP_INTRINSIC.
8027         (exp): New pattern using UNOP_INTRINSIC token.
8028         (f77_keywords): Add 'abs' keyword.
8029         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8030         (value_from_host_double): New function.
8031         (evaluate_subexp_f): Support UNOP_ABS.
8032
8033 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8034
8035         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8036         types.
8037
8038 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8039
8040         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8041         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8042         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8043
8044 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8047
8048 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8049             Chris January  <chris.january@arm.com>
8050
8051         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8052         * f-exp.y: Define 'KIND' token.
8053         (exp): New pattern for KIND expressions.
8054         (ptype): Handle types with a kind extension.
8055         (direct_abs_decl): Extend to spot kind extensions.
8056         (f77_keywords): Add 'kind' to the list.
8057         (push_kind_type): New function.
8058         (convert_to_kind_type): New function.
8059         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8060         * parse.c (operator_length_standard): Likewise.
8061         * parser-defs.h (enum type_pieces): Add tp_kind.
8062         * std-operator.def: Add UNOP_KIND.
8063
8064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * f-exp.y (f_parse): Set yydebug.
8067
8068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * f-lang.c (evaluate_subexp_f): New function.
8071         (exp_descriptor_f): New global.
8072         (f_language_defn): Use exp_descriptor_f instead of
8073         exp_descriptor_standard.
8074
8075 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * f-exp.y (struct token): Add comments.
8078         (dot_ops): Remove uppercase versions and the end marker.
8079         (f77_keywords): Likewise.
8080         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8081         entries in the dot_ops array are case insensitive, and use
8082         strncasecmp to compare strings.  Also some whitespace cleanup in
8083         this area.  Similar for the f77_keywords array, except entries in
8084         this list might be case sensitive.
8085
8086 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         * f-exp.y (struct f77_boolean_val): Add comments.
8089         (boolean_values): Remove uppercase versions, and end marker.
8090         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8091         and use strncasecmp to achieve case insensitivity.  Additionally,
8092         perform whitespace cleanup around this code.
8093
8094 2019-03-06  Tom Tromey  <tromey@adacore.com>
8095
8096         * remote-sim.c (gdbsim_target_open): Use result of
8097         gdb_argv::release.
8098
8099 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8100         Dirk Schubert  <dirk.schubert@arm.com>
8101         Chris January  <chris.january@arm.com>
8102
8103         * eval.c (evaluate_subexp_standard): Call Fortran argument
8104         wrapping logic.
8105         * f-lang.c (struct value): A value which can be passed into a
8106         Fortran function call.
8107         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8108         where appropriate.
8109         (struct type): Value ready for a Fortran function call.
8110         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8111         is needed.
8112         * f-lang.h (fortran_argument_convert): Declaration.
8113         (fortran_preserve_arg_pointer): Declaration.
8114         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8115
8116 2019-03-05  Tom Tromey  <tromey@adacore.com>
8117
8118         * python/py-prettyprint.c (print_string_repr): Remove #if.
8119         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8120
8121 2019-03-05  Tom Tromey  <tromey@adacore.com>
8122
8123         * target.c (the_dummy_target): Move later.  Change type to
8124         "dummy_target".
8125         (initialize_targets): Don't initialize the_dummy_target.
8126
8127 2019-03-05  Tom Tromey  <tromey@adacore.com>
8128
8129         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8130         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8131
8132 2019-03-05  Tom Tromey  <tromey@adacore.com>
8133
8134         * windows-nat.c (windows_nat_target::attach)
8135         (windows_nat_target::detach): Don't call gdb_flush.
8136         * valprint.c (generic_val_print, val_print, val_print_string):
8137         Don't call gdb_flush.
8138         * utils.c (defaulted_query): Don't call gdb_flush.
8139         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8140         * target.c (target_announce_detach): Don't call gdb_flush.
8141         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8142         * remote.c (extended_remote_target::attach): Don't call
8143         gdb_flush.
8144         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8145         * printcmd.c (do_examine): Don't call gdb_flush.
8146         (info_display_command): Don't call gdb_flush.
8147         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8148         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8149         * memattr.c (info_mem_command): Don't call gdb_flush.
8150         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8151         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8152         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8153         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8154         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8155         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8156         (gnu_nat_target::detach): Don't call gdb_flush.
8157         * f-valprint.c (f_val_print): Don't call gdb_flush.
8158         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8159         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8160         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8161         gdb_flush.
8162         * c-valprint.c (c_val_print): Don't call gdb_flush.
8163         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8164
8165 2019-03-05  Tom Tromey  <tromey@adacore.com>
8166
8167         * varobj.c (update_dynamic_varobj_children): Update.
8168         (install_default_visualizer): Use reset, not release.
8169         * value.c (set_internalvar): Update.
8170         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8171         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8172         ATTRIBUTE_UNUSED_RESULT.
8173
8174 2019-03-05  Tom Tromey  <tromey@adacore.com>
8175
8176         * remote.c (class scoped_remote_fd) <release>: Add
8177         ATTRIBUTE_UNUSED_RESULT.
8178
8179 2019-03-05  Tom Tromey  <tromey@adacore.com>
8180
8181         * macroexp.c (struct macro_buffer) <release>: Add
8182         ATTRIBUTE_UNUSED_RESULT.
8183
8184 2019-03-05  Tom Tromey  <tromey@adacore.com>
8185
8186         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8187         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8188         ATTRIBUTE_UNUSED_RESULT.
8189
8190 2019-03-05  Tom Tromey  <tromey@adacore.com>
8191
8192         * common/scoped_fd.h (class scoped_fd) <release>: Add
8193         ATTRIBUTE_UNUSED_RESULT.
8194
8195 2019-03-05  Tom Tromey  <tromey@adacore.com>
8196
8197         * parser-defs.h (struct parser_state) <release>: Add
8198         ATTRIBUTE_UNUSED_RESULT.
8199
8200 2019-03-05  Tom Tromey  <tromey@adacore.com>
8201
8202         * utils.h (class gdb_argv) <release>: Add
8203         ATTRIBUTE_UNUSED_RESULT.
8204         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8205
8206 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8207
8208         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8209         for-loop range, to avoid compiler warnings.
8210
8211         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8212         avoid compiler warnings about unused variables.
8213
8214         * NEWS: Mention end of support for native debugging on MS-Windows
8215         before XP.
8216
8217         PR gdb/24292
8218         * common/netstuff.c:
8219         * gdbserver/gdbreplay.c
8220         * gdbserver/remote-utils.c:
8221         * ser-tcp.c:
8222         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8223         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8224         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8225         'getaddrinfo' and 'freeaddrinfo' were not available before
8226         Windows XP, and mingw.org's MinGW headers by default define
8227         _WIN32_WINNT to 0x500.
8228
8229 2019-03-01  Gary Benson <gbenson@redhat.com>
8230
8231         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8232
8233 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8234             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8235
8236         PR gdb/8527
8237         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8238         set_sigint_trap, clear_sigint_trap.
8239
8240 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8241
8242         * target.c (target_detach): Clear the regcache and the
8243         frame cache.
8244
8245 2019-02-27  Pedro Alves  <palves@redhat.com>
8246
8247         * utils.c (set_screen_size): When we cap the height/width sizes,
8248         tweak the corresponding command variable to show "unlimited":
8249
8250 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8251             Pedro Alves  <palves@redhat.com>
8252
8253         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8254         before calling rl_set_screen_size.
8255
8256 2019-02-27  Tom Tromey  <tromey@adacore.com>
8257
8258         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8259         define.
8260         * python/py-value.c: Remove Python 2.4 workaround.
8261         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8262         workaround.
8263         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8264         Python 2.4 workaround.
8265         * python/python-internal.h: Remove Python 2.4 comment.
8266         (Py_ssize_t): Don't define.
8267         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8268         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8269         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8270         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8271         * python/python.c (do_start_initialization): Remove Python 2.4
8272         workaround.
8273         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8274         (print_children): Remove Python 2.4 workaround.
8275         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8276         workaround.
8277         (CHARBUFFERPROC_NAME): Remove.
8278         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8279         Python 2.4 workaround.
8280
8281 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8282
8283         * NEWS: Note minimum Python version.
8284
8285 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8286
8287         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8288         code from these functions.  Remove corresponding ifdefs.  Use
8289         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8290         Remove gotos and target of gotos.
8291         (infpy_search_memory): Likewise.
8292
8293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8294
8295         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8296         (hppa_gdbarch_init): Don't register deleted functions with
8297         gdbarch.
8298
8299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8300
8301         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8302         (h8300_unwind_sp): Delete.
8303         (h8300_dummy_id): Delete.
8304         (h8300_gdbarch_init): Don't register deleted functions with
8305         gdbarch.
8306
8307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8308
8309         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8310         (ft32_unwind_pc): Delete.
8311         (ft32_unwind_sp): Delete.
8312         (ft32_gdbarch_init): Don't register deleted functions with
8313         gdbarch.
8314
8315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8316
8317         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8318         (frv_unwind_pc): Delete.
8319         (frv_unwind_sp): Delete.
8320         (frv_gdbarch_init): Don't register deleted functions with
8321         gdbarch.
8322
8323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8326         (riscv_unwind_pc): Delete.
8327         (riscv_unwind_sp): Delete.
8328         (riscv_gdbarch_init): Don't register deleted functions with
8329         gdbarch.
8330
8331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8332
8333         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8334         (csky_unwind_pc): Delete.
8335         (csky_unwind_sp): Delete.
8336         (csky_gdbarch_init): Don't register deleted functions with
8337         gdbarch.
8338
8339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8342         (cris_unwind_pc): Delete.
8343         (cris_unwind_sp): Delete.
8344         (cris_gdbarch_init): Don't register deleted functions with
8345         gdbarch.
8346
8347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8350         (bfin_unwind_pc): Delete.
8351         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8352
8353 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8354
8355         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8356         (arm_unwind_pc): Delete.
8357         (arm_unwind_sp): Delete.
8358         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8359
8360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8363         (arc_unwind_pc): Delete.
8364         (arc_unwind_sp): Delete.
8365         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8366
8367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8368
8369         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8370         (alpha_unwind_pc): Delete.
8371         (alpha_gdbarch_init): Don't register deleted functions with
8372         gdbarch.
8373
8374 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8377         (aarch64_unwind_pc): Delete.
8378         (aarch64_unwind_sp): Delete.
8379         (aarch64_gdbarch_init): Don't register deleted functions with
8380         gdbarch.
8381
8382 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8383
8384         * gdbtypes.c (type_align): Don't consider static members when
8385         computing structure alignment.
8386
8387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8388
8389         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8390         return 0 for other types.
8391         * arch-utils.c (default_type_align): Always return 0.
8392         * gdbarch.h: Regenerate.
8393         * gdbarch.sh (type_align): Extend comment.
8394         * gdbtypes.c (type_align): Add additional comments, always call
8395         gdbarch_type_align before applying the default rules.
8396         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8397         generic code will then apply a suitable default.
8398         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8399         types, return 0 for other types.
8400
8401 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8402
8403         * NEWS: Create a new section for the next release branch.
8404         Rename the section of the current branch, now that it has
8405         been cut.
8406
8407 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8408
8409         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8410         * version.in: Bump version to 8.3.50.DATE-git.
8411
8412 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8413
8414         * aix-thread.c (ptid_cmp): Remove unused variable.
8415         (get_signaled_thread): Likewise.
8416         (store_regs_user_thread): Likewise.
8417         (store_regs_kernel_thread): Likewise.
8418         (fetch_regs_kernel_thread): Remove shadowed variable.
8419
8420 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8421
8422         * features/riscv/32bit-cpu.xml: Add register numbers.
8423         * features/riscv/32bit-fpu.c: Regenerate.
8424         * features/riscv/32bit-fpu.xml: Add register numbers.
8425         * features/riscv/64bit-cpu.xml: Add register numbers.
8426         * features/riscv/64bit-fpu.c: Regenerate.
8427         * features/riscv/64bit-fpu.xml: Add register numbers.
8428
8429 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8430
8431         * NEWS: Mention two argument form of gdb.Value constructor.
8432         * python/py-value.c (convert_buffer_and_type_to_value): New
8433         function.
8434         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8435         Add support for handling an optional second argument.  Call
8436         convert_buffer_and_type_to_value as appropriate.
8437         * python/python-internal.h (Py_buffer_deleter): New struct.
8438         (Py_buffer_up): New typedef.
8439
8440 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8441
8442         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8443         instead of releasing ownership.
8444
8445 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8446
8447         * dwarf2read.c (open_and_init_dwp_file): Call
8448         elf_numsections instead of bfd_count_sections to initialize
8449         dwp_file->num_sections.
8450
8451 2019-02-25  Tom Tromey  <tromey@adacore.com>
8452
8453         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8454
8455 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8456
8457         * gcore.in: Add '--readnever' option when invoking GDB.
8458
8459 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8460
8461         * MAINTAINERS: Update my email address.
8462
8463 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8464
8465         * build-id.c (build_id_to_debug_bfd_1): New function.
8466         (build_id_to_debug_bfd): Look for separate debug file in
8467         sysroot.
8468
8469 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8470
8471         * gdbarch.sh: Update the copyright year range that is placed into
8472         generated files.
8473
8474 2019-02-22  Keith Seitz  <keiths@redhat.com>
8475
8476         PR symtab/23853
8477         * linespec.c (create_sals_line_offset): Search for the default
8478         symtab's filename instead of its fullname.
8479
8480 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8481
8482         * NEWS: Update style defaults.
8483
8484 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8485
8486         * main.c (captured_main_1): Disable styling in batch mode.
8487
8488 2019-02-20  Tom Tromey  <tom@tromey.com>
8489
8490         * symtab.c (symtab_symbol_info): Fix typos.
8491
8492 2019-02-20  Tom Tromey  <tromey@adacore.com>
8493
8494         * findcmd.c (_initialize_mem_search): Use upper case for
8495         metasyntactic variables.
8496
8497 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8498
8499         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8500         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8501
8502 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8503
8504         * top.h (source_file_name): Change to std::string.
8505         * top.c (source_file_name): Likewise.
8506         (command_line_input): Adjust.
8507         * cli/cli-script.c (script_from_file): Adjust.
8508
8509 2019-02-19  Tom Tromey  <tromey@adacore.com>
8510
8511         * ravenscar-thread.c
8512         (ravenscar_thread_target::update_thread_list): Don't call
8513         ada_build_task_list.
8514         * ada-lang.h (ada_build_task_list): Don't declare.
8515         * ada-tasks.c (struct ada_tasks_inferior_data)
8516         <task_list_valid_p>: Now bool.
8517         (read_known_tasks, ada_task_list_changed)
8518         (ada_tasks_invalidate_inferior_data): Update.
8519         (read_known_tasks_array): Return bool.
8520         (read_known_tasks_list): Likewise.
8521         (read_known_tasks): Return void.
8522         (ada_build_task_list): Now static.
8523
8524 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8527         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8528
8529 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8530
8531         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8532         variant for ada_tasks_pspace_data_handle and
8533         ada_tasks_inferior_data_handle.
8534         (ada_tasks_pspace_data_cleanup): New function.
8535         (ada_tasks_inferior_data_cleanup): New function.
8536
8537 2019-02-17  Tom Tromey  <tom@tromey.com>
8538
8539         * macrotab.h (macro_source_fullname): Return a std::string.
8540         * macrotab.c (macro_include, check_for_redefinition)
8541         (macro_undef, macro_lookup_definition, foreach_macro)
8542         (foreach_macro_in_scope): Update.
8543         (macro_source_fullname): Return a std::string.
8544         * macrocmd.c (show_pp_source_pos): Update.
8545
8546 2019-02-17  Tom Tromey  <tom@tromey.com>
8547
8548         * macrocmd.c (show_pp_source_pos): Style the file names.
8549
8550 2019-02-17  Tom Tromey  <tom@tromey.com>
8551
8552         PR tui/24197:
8553         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8554
8555 2019-02-17  Tom Tromey  <tom@tromey.com>
8556
8557         * ada-lang.c (user_select_syms): Use filtered printing.
8558         * utils.c (wrap_style): New global.
8559         (desired_style): Remove.
8560         (emit_style_escape): Add stream parameter.
8561         (set_output_style, reset_terminal_style, prompt_for_continue):
8562         Update.
8563         (flush_wrap_buffer): Only flush gdb_stdout.
8564         (wrap_here): Set wrap_style.
8565         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8566         treat escape sequences as a character.  Change when wrap buffer is
8567         flushed.
8568         (fputs_styled): Do not set the output style when the default is
8569         requested.
8570         * ui-style.h (struct ui_file_style) <is_default>: New method.
8571         * source.c (print_source_lines_base): Emit escape sequences in one
8572         piece.
8573
8574 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8575
8576         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8577         integers and enumeration types.
8578
8579 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8580
8581         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8582         instead of lookup_symbol_in_language
8583         (do_exact_match): New function.
8584         (ada_get_symbol_name_matcher): Return do_exact_match when
8585         doing a verbatim match.
8586
8587 2019-02-15  Tom Tromey  <tromey@adacore.com>
8588
8589         * ravenscar-thread.c (ravenscar_thread_target::resume)
8590         (ravenscar_thread_target::wait): Special case wildcard requests.
8591
8592 2019-02-15  Tom Tromey  <tromey@adacore.com>
8593
8594         * ravenscar-thread.c (base_ptid): Remove.
8595         (struct ravenscar_thread_target) <close>: New method.
8596         <m_base_ptid>: New member.
8597         <update_inferior_ptid, active_task, task_is_currently_active,
8598         runtime_initialized>: Declare methods.
8599         <ravenscar_thread_target>: Add constructor.
8600         (ravenscar_thread_target::task_is_currently_active)
8601         (ravenscar_thread_target::update_inferior_ptid)
8602         (ravenscar_runtime_initialized): Rename.  Now methods.
8603         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8604         (ravenscar_thread_target::update_thread_list): Update.
8605         (ravenscar_thread_target::active_task): Now method.
8606         (ravenscar_thread_target::store_registers)
8607         (ravenscar_thread_target::prepare_to_store)
8608         (ravenscar_thread_target::prepare_to_store)
8609         (ravenscar_thread_target::mourn_inferior): Update.
8610         (ravenscar_inferior_created): Use "new" to create target.
8611         (ravenscar_thread_target::get_ada_task_ptid): Update.
8612         (_initialize_ravenscar): Don't initialize base_ptid.
8613         (ravenscar_ops): Remove global.
8614
8615 2019-02-15  Tom Tromey  <tromey@adacore.com>
8616
8617         * target.h (push_target): Declare new overload.
8618         * target.c (push_target): New overload, taking an rvalue reference.
8619         * remote.c (remote_target::open_1): Use push_target overload.
8620         * corelow.c (core_target_open): Use push_target overload.
8621
8622 2019-02-15  Tom Tromey  <tromey@adacore.com>
8623
8624         * ravenscar-thread.c (is_ravenscar_task)
8625         (ravenscar_task_is_currently_active): Return bool.
8626         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8627         (_initialize_ravenscar): Remove "(void)".
8628         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8629         Return bool.
8630
8631 2019-02-15  Tom Tromey  <tromey@adacore.com>
8632
8633         * ravenscar-thread.c (ravenscar_runtime_initializer)
8634         (has_ravenscar_runtime, get_running_thread_id)
8635         (ravenscar_thread_target::resume): Fix indentation.
8636
8637 2019-02-15  Tom Tromey  <tromey@adacore.com>
8638
8639         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8640         from ravenscar_arch_ops.
8641         (sparc_ravenscar_ops::fetch_registers)
8642         (sparc_ravenscar_ops::store_registers): Now methods.
8643         (sparc_ravenscar_prepare_to_store): Remove.
8644         (sparc_ravenscar_ops): Redefine.
8645         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8646         methods and destructor.  Remove members.
8647         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8648         (ravenscar_thread_target::store_registers)
8649         (ravenscar_thread_target::prepare_to_store): Update.
8650         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8651         Remove.
8652         (struct ppc_ravenscar_powerpc_ops): Derive from
8653         ravenscar_arch_ops.
8654         (ppc_ravenscar_powerpc_ops::fetch_registers)
8655         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8656         (ppc_ravenscar_powerpc_ops): Redefine.
8657         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8658         (ppc_ravenscar_e500_ops::fetch_registers)
8659         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8660         (ppc_ravenscar_e500_ops): Redefine.
8661         * aarch64-ravenscar-thread.c
8662         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8663         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8664         (aarch64_ravenscar_fetch_registers)
8665         (aarch64_ravenscar_store_registers): Now methods.
8666         (aarch64_ravenscar_ops): Redefine.
8667
8668 2019-02-15  Tom Tromey  <tromey@adacore.com>
8669
8670         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8671         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8672         (ravenscar_thread_target::stopped_by_watchpoint)
8673         (ravenscar_thread_target::stopped_data_address)
8674         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8675
8676 2019-02-15  Tom Tromey  <tromey@adacore.com>
8677
8678         * ravenscar-thread.c: Fix some typos.
8679
8680 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8681             Tom Tromey  <tromey@adacore.com>
8682
8683         * ada-lang.c (ada_exception_sal): Change addr_string to a
8684         std::string.
8685         (create_ada_exception_catchpoint): Update.
8686
8687 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8688             Tom Tromey  <tromey@adacore.com>
8689
8690         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8691         (bp_location_ops): Remove.
8692         (base_breakpoint_allocate_location): Update.
8693         (free_bp_location): Update.
8694         * ada-lang.c (class ada_catchpoint_location)
8695         <ada_catchpoint_location>: Remove ops parameter.
8696         (ada_catchpoint_location_dtor): Remove.
8697         (ada_catchpoint_location_ops): Remove.
8698         (allocate_location_exception): Update.
8699         * breakpoint.h (struct bp_location_ops): Remove.
8700         (class bp_location) <bp_location>: Remove bp_location_ops
8701         parameter.
8702         <~bp_location>: Add destructor.
8703         <ops>: Remove.
8704
8705 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8706             Pedro Alves  <palves@redhat.com>
8707
8708         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8709         'PATH_MAX'.
8710
8711 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8712             Samuel Thibault  <samuel.thibault@gnu.org>
8713             Thomas Schwinge  <thomas@codesourcery.com>
8714
8715         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8716         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8717
8718 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8719
8720         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8721         (check_empty): Use "const char *".
8722
8723         * gnu-nat.c (gnu_nat_target::detach): Instead of
8724         'detach_inferior (pid)' call
8725         'detach_inferior (find_inferior_pid (pid))'.
8726
8727         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8728         'nat/fork-inferior.o'.
8729         * gnu-nat.c: #include "nat/fork-inferior.h".
8730
8731         * gnu-nat.c (gnu_nat_target::detach): Instead of
8732         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8733         * gnu-nat.h: #include "inf-child.h".
8734         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8735         'i386_gnu_nat_target::fetch_registers'.
8736         (gnu_store_registers): Rename/move to
8737         'i386_gnu_nat_target::store_registers'.
8738
8739         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8740         * gnu-nat.h (mach_thread_info): New function.
8741         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8742
8743         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8744
8745 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8746
8747         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8748
8749 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8750
8751         * windows-nat.c (windows_add_thread): Add new parameter
8752         "main_thread_p" with default value set to false.  Update
8753         function documentation as well as all callers.
8754         (windows_delete_thread): Likewise.
8755         (fake_create_process): Update call to windows_add_thread.
8756         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8757         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8758         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8759         call to windows_delete_thread.
8760
8761 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8762
8763         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8764
8765 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8766
8767         * symfile.c (find_separate_debug_file): Use canonical path of
8768         sysroot with child_path instead of gdb_sysroot if it is valid.
8769
8770 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8771
8772         * symfile.c (find_separate_debug_file): Use child_path to
8773         determine if an object file is under a sysroot.
8774
8775 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8776
8777         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8778         unittests/child-path-selftests.c.
8779         * common/pathstuff.c (child_path): New function.
8780         * common/pathstuff.h (child_path): New prototype.
8781         * unittests/child-path-selftests.c: New file.
8782
8783 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8784
8785         * symfile.c (find_separate_debug_file): Look for separate debug
8786         files in debug directories under the sysroot.
8787
8788 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8789
8790         * symtab.h (struct minimal_symbol data_p): New const method.
8791         (struct minimal_symbol text_p): Likewise.
8792         * symtab.c (output_source_filename): Use file name style
8793         to print file name.
8794         (print_symbol_info): Likewise.
8795         (print_msymbol_info): Use address style to print addresses.
8796         Use function name style to print executable text symbols.
8797         (expand_symtab_containing_pc): Use data_p.
8798         (find_pc_sect_compunit_symtab): Likewise.
8799
8800 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8801
8802         * breakpoint.c (describe_other_breakpoints): Use address style
8803         to print addresses.
8804         (say_where): Likewise.
8805
8806 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8807
8808         * ada-typeprint.c (print_func_type): Print function name
8809         style to print function name.
8810         * c-typeprint.c (c_print_type_1): Likewise.
8811
8812 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8813
8814         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8815         for execve.
8816
8817 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8818
8819         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8820         type_stack.
8821
8822 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8823
8824         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8825         TYPE_CODE_REF types.
8826
8827 2019-02-08  Jim Wilson  <jimw@sifive.com>
8828
8829         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8830         (riscv_linux_fregset): New.
8831         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8832
8833 2019-02-07  Tom Tromey  <tom@tromey.com>
8834
8835         * thread.c (thread_cancel_execution_command): Update.
8836         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8837         methods.
8838         (struct thread_fsm_ops): Remove.
8839         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8840         (thread_fsm_should_stop, thread_fsm_return_value)
8841         (thread_fsm_set_finished, thread_fsm_finished_p)
8842         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8843         Don't declare.
8844         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8845         * infrun.c (clear_proceed_status_thread)
8846         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8847         (print_stop_event): Update.
8848         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8849         Add constructor.
8850         (step_command_fsm_ops): Remove.
8851         (new_step_command_fsm): Remove.
8852         (step_1): Update.
8853         (step_command_fsm::should_stop): Rename from
8854         step_command_fsm_should_stop.
8855         (step_command_fsm::clean_up): Rename from
8856         step_command_fsm_clean_up.
8857         (step_command_fsm::do_async_reply_reason): Rename from
8858         step_command_fsm_async_reply_reason.
8859         (struct until_next_fsm): Inherit from thread_fsm.  Add
8860         constructor.
8861         (until_next_fsm_ops): Remove.
8862         (new_until_next_fsm): Remove.
8863         (until_next_fsm::should_stop): Rename from
8864         until_next_fsm_should_stop.
8865         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8866         (until_next_fsm::do_async_reply_reason): Rename from
8867         until_next_fsm_async_reply_reason.
8868         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8869         constructor.  Change type of breakpoint.
8870         (finish_command_fsm_ops): Remove.
8871         (new_finish_command_fsm): Remove.
8872         (finish_command_fsm::should_stop): Rename from
8873         finish_command_fsm_should_stop.
8874         (finish_command_fsm::clean_up): Rename from
8875         finish_command_fsm_clean_up.
8876         (finish_command_fsm::return_value): Rename from
8877         finish_command_fsm_return_value.
8878         (finish_command_fsm::do_async_reply_reason): Rename from
8879         finish_command_fsm_async_reply_reason.
8880         (finish_command): Update.
8881         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8882         Add constructor.
8883         (call_thread_fsm_ops): Remove.
8884         (call_thread_fsm::call_thread_fsm): Rename from
8885         new_call_thread_fsm.
8886         (call_thread_fsm::should_stop): Rename from
8887         call_thread_fsm_should_stop.
8888         (call_thread_fsm::should_notify_stop): Rename from
8889         call_thread_fsm_should_notify_stop.
8890         (run_inferior_call, call_function_by_hand_dummy): Update.
8891         * cli/cli-interp.c (should_print_stop_to_console): Update.
8892         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8893         Add constructor.  Change type of location_breakpoint,
8894         caller_breakpoint.
8895         (until_break_fsm_ops): Remove.
8896         (new_until_break_fsm): Remove.
8897         (until_break_fsm::should_stop): Rename from
8898         until_break_fsm_should_stop.
8899         (until_break_fsm::clean_up): Rename from
8900         until_break_fsm_clean_up.
8901         (until_break_fsm::do_async_reply_reason): Rename from
8902         until_break_fsm_async_reply_reason.
8903         (until_break_command): Update.
8904         * thread-fsm.c: Remove.
8905         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8906
8907 2019-02-07  Tom Tromey  <tom@tromey.com>
8908
8909         * yy-remap.h: Add include guard.
8910         * xtensa-tdep.h: Add include guard.
8911         * xcoffread.h: Rename include guard.
8912         * varobj-iter.h: Add include guard.
8913         * tui/tui.h: Rename include guard.
8914         * tui/tui-winsource.h: Rename include guard.
8915         * tui/tui-wingeneral.h: Rename include guard.
8916         * tui/tui-windata.h: Rename include guard.
8917         * tui/tui-win.h: Rename include guard.
8918         * tui/tui-stack.h: Rename include guard.
8919         * tui/tui-source.h: Rename include guard.
8920         * tui/tui-regs.h: Rename include guard.
8921         * tui/tui-out.h: Rename include guard.
8922         * tui/tui-layout.h: Rename include guard.
8923         * tui/tui-io.h: Rename include guard.
8924         * tui/tui-hooks.h: Rename include guard.
8925         * tui/tui-file.h: Rename include guard.
8926         * tui/tui-disasm.h: Rename include guard.
8927         * tui/tui-data.h: Rename include guard.
8928         * tui/tui-command.h: Rename include guard.
8929         * tic6x-tdep.h: Add include guard.
8930         * target/waitstatus.h: Rename include guard.
8931         * target/wait.h: Rename include guard.
8932         * target/target.h: Rename include guard.
8933         * target/resume.h: Rename include guard.
8934         * target-float.h: Rename include guard.
8935         * stabsread.h: Add include guard.
8936         * rs6000-tdep.h: Add include guard.
8937         * riscv-fbsd-tdep.h: Add include guard.
8938         * regformats/regdef.h: Rename include guard.
8939         * record.h: Rename include guard.
8940         * python/python.h: Rename include guard.
8941         * python/python-internal.h: Rename include guard.
8942         * python/py-stopevent.h: Rename include guard.
8943         * python/py-ref.h: Rename include guard.
8944         * python/py-record.h: Rename include guard.
8945         * python/py-record-full.h: Rename include guard.
8946         * python/py-record-btrace.h: Rename include guard.
8947         * python/py-instruction.h: Rename include guard.
8948         * python/py-events.h: Rename include guard.
8949         * python/py-event.h: Rename include guard.
8950         * procfs.h: Add include guard.
8951         * proc-utils.h: Add include guard.
8952         * p-lang.h: Add include guard.
8953         * or1k-tdep.h: Rename include guard.
8954         * observable.h: Rename include guard.
8955         * nto-tdep.h: Rename include guard.
8956         * nat/x86-linux.h: Rename include guard.
8957         * nat/x86-linux-dregs.h: Rename include guard.
8958         * nat/x86-gcc-cpuid.h: Add include guard.
8959         * nat/x86-dregs.h: Rename include guard.
8960         * nat/x86-cpuid.h: Rename include guard.
8961         * nat/ppc-linux.h: Rename include guard.
8962         * nat/mips-linux-watch.h: Rename include guard.
8963         * nat/linux-waitpid.h: Rename include guard.
8964         * nat/linux-ptrace.h: Rename include guard.
8965         * nat/linux-procfs.h: Rename include guard.
8966         * nat/linux-osdata.h: Rename include guard.
8967         * nat/linux-nat.h: Rename include guard.
8968         * nat/linux-namespaces.h: Rename include guard.
8969         * nat/linux-btrace.h: Rename include guard.
8970         * nat/glibc_thread_db.h: Rename include guard.
8971         * nat/gdb_thread_db.h: Rename include guard.
8972         * nat/gdb_ptrace.h: Rename include guard.
8973         * nat/fork-inferior.h: Rename include guard.
8974         * nat/amd64-linux-siginfo.h: Rename include guard.
8975         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8976         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8977         * nat/aarch64-linux.h: Rename include guard.
8978         * nat/aarch64-linux-hw-point.h: Rename include guard.
8979         * mn10300-tdep.h: Add include guard.
8980         * mips-linux-tdep.h: Add include guard.
8981         * mi/mi-parse.h: Rename include guard.
8982         * mi/mi-out.h: Rename include guard.
8983         * mi/mi-main.h: Rename include guard.
8984         * mi/mi-interp.h: Rename include guard.
8985         * mi/mi-getopt.h: Rename include guard.
8986         * mi/mi-console.h: Rename include guard.
8987         * mi/mi-common.h: Rename include guard.
8988         * mi/mi-cmds.h: Rename include guard.
8989         * mi/mi-cmd-break.h: Rename include guard.
8990         * m2-lang.h: Add include guard.
8991         * location.h: Rename include guard.
8992         * linux-record.h: Rename include guard.
8993         * linux-nat.h: Add include guard.
8994         * linux-fork.h: Add include guard.
8995         * i386-darwin-tdep.h: Rename include guard.
8996         * hppa-linux-offsets.h: Add include guard.
8997         * guile/guile.h: Rename include guard.
8998         * guile/guile-internal.h: Rename include guard.
8999         * gnu-nat.h: Rename include guard.
9000         * gdb-stabs.h: Rename include guard.
9001         * frv-tdep.h: Add include guard.
9002         * f-lang.h: Add include guard.
9003         * event-loop.h: Add include guard.
9004         * darwin-nat.h: Rename include guard.
9005         * cp-abi.h: Rename include guard.
9006         * config/sparc/nm-sol2.h: Rename include guard.
9007         * config/nm-nto.h: Rename include guard.
9008         * config/nm-linux.h: Add include guard.
9009         * config/i386/nm-i386gnu.h: Rename include guard.
9010         * config/djgpp/nl_types.h: Rename include guard.
9011         * config/djgpp/langinfo.h: Rename include guard.
9012         * compile/gcc-cp-plugin.h: Add include guard.
9013         * compile/gcc-c-plugin.h: Add include guard.
9014         * compile/compile.h: Rename include guard.
9015         * compile/compile-object-run.h: Rename include guard.
9016         * compile/compile-object-load.h: Rename include guard.
9017         * compile/compile-internal.h: Rename include guard.
9018         * compile/compile-cplus.h: Rename include guard.
9019         * compile/compile-c.h: Rename include guard.
9020         * common/xml-utils.h: Rename include guard.
9021         * common/x86-xstate.h: Rename include guard.
9022         * common/version.h: Rename include guard.
9023         * common/vec.h: Rename include guard.
9024         * common/tdesc.h: Rename include guard.
9025         * common/selftest.h: Rename include guard.
9026         * common/scoped_restore.h: Rename include guard.
9027         * common/scoped_mmap.h: Rename include guard.
9028         * common/scoped_fd.h: Rename include guard.
9029         * common/safe-iterator.h: Rename include guard.
9030         * common/run-time-clock.h: Rename include guard.
9031         * common/refcounted-object.h: Rename include guard.
9032         * common/queue.h: Rename include guard.
9033         * common/ptid.h: Rename include guard.
9034         * common/print-utils.h: Rename include guard.
9035         * common/preprocessor.h: Rename include guard.
9036         * common/pathstuff.h: Rename include guard.
9037         * common/observable.h: Rename include guard.
9038         * common/netstuff.h: Rename include guard.
9039         * common/job-control.h: Rename include guard.
9040         * common/host-defs.h: Rename include guard.
9041         * common/gdb_wait.h: Rename include guard.
9042         * common/gdb_vecs.h: Rename include guard.
9043         * common/gdb_unlinker.h: Rename include guard.
9044         * common/gdb_unique_ptr.h: Rename include guard.
9045         * common/gdb_tilde_expand.h: Rename include guard.
9046         * common/gdb_sys_time.h: Rename include guard.
9047         * common/gdb_string_view.h: Rename include guard.
9048         * common/gdb_splay_tree.h: Rename include guard.
9049         * common/gdb_setjmp.h: Rename include guard.
9050         * common/gdb_ref_ptr.h: Rename include guard.
9051         * common/gdb_optional.h: Rename include guard.
9052         * common/gdb_locale.h: Rename include guard.
9053         * common/gdb_assert.h: Rename include guard.
9054         * common/filtered-iterator.h: Rename include guard.
9055         * common/filestuff.h: Rename include guard.
9056         * common/fileio.h: Rename include guard.
9057         * common/environ.h: Rename include guard.
9058         * common/common-utils.h: Rename include guard.
9059         * common/common-types.h: Rename include guard.
9060         * common/common-regcache.h: Rename include guard.
9061         * common/common-inferior.h: Rename include guard.
9062         * common/common-gdbthread.h: Rename include guard.
9063         * common/common-exceptions.h: Rename include guard.
9064         * common/common-defs.h: Rename include guard.
9065         * common/common-debug.h: Rename include guard.
9066         * common/cleanups.h: Rename include guard.
9067         * common/buffer.h: Rename include guard.
9068         * common/btrace-common.h: Rename include guard.
9069         * common/break-common.h: Rename include guard.
9070         * cli/cli-utils.h: Rename include guard.
9071         * cli/cli-style.h: Rename include guard.
9072         * cli/cli-setshow.h: Rename include guard.
9073         * cli/cli-script.h: Rename include guard.
9074         * cli/cli-interp.h: Rename include guard.
9075         * cli/cli-decode.h: Rename include guard.
9076         * cli/cli-cmds.h: Rename include guard.
9077         * charset-list.h: Add include guard.
9078         * buildsym-legacy.h: Rename include guard.
9079         * bfin-tdep.h: Add include guard.
9080         * ax.h: Rename include guard.
9081         * arm-linux-tdep.h: Add include guard.
9082         * arm-fbsd-tdep.h: Add include guard.
9083         * arch/xtensa.h: Rename include guard.
9084         * arch/tic6x.h: Add include guard.
9085         * arch/i386.h: Add include guard.
9086         * arch/arm.h: Rename include guard.
9087         * arch/arm-linux.h: Rename include guard.
9088         * arch/arm-get-next-pcs.h: Rename include guard.
9089         * arch/amd64.h: Add include guard.
9090         * arch/aarch64-insn.h: Rename include guard.
9091         * arch-utils.h: Rename include guard.
9092         * annotate.h: Add include guard.
9093         * amd64-darwin-tdep.h: Rename include guard.
9094         * aarch64-linux-tdep.h: Add include guard.
9095         * aarch64-fbsd-tdep.h: Add include guard.
9096         * aarch32-linux-nat.h: Add include guard.
9097
9098 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9099
9100         * macrotab.c (macro_define_internal): New function that
9101         factorizes macro_define_object_internal and macro_define_function
9102         code.
9103         (macro_define_object_internal): Use macro_define_internal.
9104         (macro_define_function): Likewise.
9105
9106 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9107
9108         * macrocmd.c (extract_identifier): Return
9109         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9110         callers.
9111
9112 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9113
9114         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9115
9116 2019-02-05  Tom Tromey  <tom@tromey.com>
9117
9118         * target.c (target_stack::unpush): Move assertion earlier.
9119
9120 2019-01-30  Tom Tromey  <tom@tromey.com>
9121
9122         PR python/23615:
9123         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9124         (gdbpy_parse_and_eval): Likewise.
9125         * python/python-internal.h (gdbpy_allow_threads): New class.
9126
9127 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9128
9129         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9130         (aarch64_fbsd_fpregmap): Move earlier.
9131         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9132         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9133         instead of individual calls to trad_frame_set_reg_addr.
9134         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9135         earlier.
9136         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9137         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9138         instead of individual calls to trad_frame_set_reg_addr.
9139
9140 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9141
9142         * CONTRIBUTE: Replace contribution list with wiki link.
9143
9144 2019-01-25  Tom Tromey  <tom@tromey.com>
9145
9146         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9147
9148 2019-01-25  Tom Tromey  <tom@tromey.com>
9149
9150         * xtensa-linux-nat.c: Fix common/ includes.
9151         * xml-support.h: Fix common/ includes.
9152         * xml-support.c: Fix common/ includes.
9153         * x86-linux-nat.c: Fix common/ includes.
9154         * windows-nat.c: Fix common/ includes.
9155         * varobj.h: Fix common/ includes.
9156         * varobj.c: Fix common/ includes.
9157         * value.c: Fix common/ includes.
9158         * valops.c: Fix common/ includes.
9159         * utils.c: Fix common/ includes.
9160         * unittests/xml-utils-selftests.c: Fix common/ includes.
9161         * unittests/utils-selftests.c: Fix common/ includes.
9162         * unittests/unpack-selftests.c: Fix common/ includes.
9163         * unittests/tracepoint-selftests.c: Fix common/ includes.
9164         * unittests/style-selftests.c: Fix common/ includes.
9165         * unittests/string_view-selftests.c: Fix common/ includes.
9166         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9167         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9168         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9169         * unittests/rsp-low-selftests.c: Fix common/ includes.
9170         * unittests/parse-connection-spec-selftests.c: Fix common/
9171         includes.
9172         * unittests/optional-selftests.c: Fix common/ includes.
9173         * unittests/offset-type-selftests.c: Fix common/ includes.
9174         * unittests/observable-selftests.c: Fix common/ includes.
9175         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9176         * unittests/memrange-selftests.c: Fix common/ includes.
9177         * unittests/memory-map-selftests.c: Fix common/ includes.
9178         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9179         * unittests/function-view-selftests.c: Fix common/ includes.
9180         * unittests/environ-selftests.c: Fix common/ includes.
9181         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9182         * unittests/common-utils-selftests.c: Fix common/ includes.
9183         * unittests/cli-utils-selftests.c: Fix common/ includes.
9184         * unittests/array-view-selftests.c: Fix common/ includes.
9185         * ui-file.c: Fix common/ includes.
9186         * tui/tui-io.c: Fix common/ includes.
9187         * tracepoint.h: Fix common/ includes.
9188         * tracepoint.c: Fix common/ includes.
9189         * tracefile-tfile.c: Fix common/ includes.
9190         * top.h: Fix common/ includes.
9191         * top.c: Fix common/ includes.
9192         * thread.c: Fix common/ includes.
9193         * target/waitstatus.h: Fix common/ includes.
9194         * target/waitstatus.c: Fix common/ includes.
9195         * target.h: Fix common/ includes.
9196         * target.c: Fix common/ includes.
9197         * target-memory.c: Fix common/ includes.
9198         * target-descriptions.c: Fix common/ includes.
9199         * symtab.h: Fix common/ includes.
9200         * symfile.c: Fix common/ includes.
9201         * stap-probe.c: Fix common/ includes.
9202         * spu-linux-nat.c: Fix common/ includes.
9203         * sparc-nat.c: Fix common/ includes.
9204         * source.c: Fix common/ includes.
9205         * solib.c: Fix common/ includes.
9206         * solib-target.c: Fix common/ includes.
9207         * ser-unix.c: Fix common/ includes.
9208         * ser-tcp.c: Fix common/ includes.
9209         * ser-pipe.c: Fix common/ includes.
9210         * ser-base.c: Fix common/ includes.
9211         * selftest-arch.c: Fix common/ includes.
9212         * s12z-tdep.c: Fix common/ includes.
9213         * rust-exp.y: Fix common/ includes.
9214         * rs6000-aix-tdep.c: Fix common/ includes.
9215         * riscv-tdep.c: Fix common/ includes.
9216         * remote.c: Fix common/ includes.
9217         * remote-notif.h: Fix common/ includes.
9218         * remote-fileio.h: Fix common/ includes.
9219         * remote-fileio.c: Fix common/ includes.
9220         * regcache.h: Fix common/ includes.
9221         * regcache.c: Fix common/ includes.
9222         * record-btrace.c: Fix common/ includes.
9223         * python/python.c: Fix common/ includes.
9224         * python/py-type.c: Fix common/ includes.
9225         * python/py-inferior.c: Fix common/ includes.
9226         * progspace.h: Fix common/ includes.
9227         * producer.c: Fix common/ includes.
9228         * procfs.c: Fix common/ includes.
9229         * proc-api.c: Fix common/ includes.
9230         * printcmd.c: Fix common/ includes.
9231         * ppc-linux-nat.c: Fix common/ includes.
9232         * parser-defs.h: Fix common/ includes.
9233         * osdata.c: Fix common/ includes.
9234         * obsd-nat.c: Fix common/ includes.
9235         * nat/x86-linux.c: Fix common/ includes.
9236         * nat/x86-linux-dregs.c: Fix common/ includes.
9237         * nat/x86-dregs.h: Fix common/ includes.
9238         * nat/x86-dregs.c: Fix common/ includes.
9239         * nat/ppc-linux.c: Fix common/ includes.
9240         * nat/mips-linux-watch.h: Fix common/ includes.
9241         * nat/mips-linux-watch.c: Fix common/ includes.
9242         * nat/linux-waitpid.c: Fix common/ includes.
9243         * nat/linux-ptrace.h: Fix common/ includes.
9244         * nat/linux-ptrace.c: Fix common/ includes.
9245         * nat/linux-procfs.c: Fix common/ includes.
9246         * nat/linux-personality.c: Fix common/ includes.
9247         * nat/linux-osdata.c: Fix common/ includes.
9248         * nat/linux-namespaces.c: Fix common/ includes.
9249         * nat/linux-btrace.h: Fix common/ includes.
9250         * nat/linux-btrace.c: Fix common/ includes.
9251         * nat/fork-inferior.c: Fix common/ includes.
9252         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9253         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9254         * nat/aarch64-linux.c: Fix common/ includes.
9255         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9256         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9257         * namespace.h: Fix common/ includes.
9258         * mips-linux-tdep.c: Fix common/ includes.
9259         * minsyms.c: Fix common/ includes.
9260         * mi/mi-parse.h: Fix common/ includes.
9261         * mi/mi-main.c: Fix common/ includes.
9262         * mi/mi-cmd-env.c: Fix common/ includes.
9263         * memrange.h: Fix common/ includes.
9264         * memattr.c: Fix common/ includes.
9265         * maint.h: Fix common/ includes.
9266         * maint.c: Fix common/ includes.
9267         * main.c: Fix common/ includes.
9268         * machoread.c: Fix common/ includes.
9269         * location.c: Fix common/ includes.
9270         * linux-thread-db.c: Fix common/ includes.
9271         * linux-nat.c: Fix common/ includes.
9272         * linux-fork.c: Fix common/ includes.
9273         * inline-frame.c: Fix common/ includes.
9274         * infrun.c: Fix common/ includes.
9275         * inflow.c: Fix common/ includes.
9276         * inferior.h: Fix common/ includes.
9277         * inferior.c: Fix common/ includes.
9278         * infcmd.c: Fix common/ includes.
9279         * inf-ptrace.c: Fix common/ includes.
9280         * inf-child.c: Fix common/ includes.
9281         * ia64-linux-nat.c: Fix common/ includes.
9282         * i387-tdep.c: Fix common/ includes.
9283         * i386-tdep.c: Fix common/ includes.
9284         * i386-linux-tdep.c: Fix common/ includes.
9285         * i386-linux-nat.c: Fix common/ includes.
9286         * i386-go32-tdep.c: Fix common/ includes.
9287         * i386-fbsd-tdep.c: Fix common/ includes.
9288         * i386-fbsd-nat.c: Fix common/ includes.
9289         * guile/scm-type.c: Fix common/ includes.
9290         * guile/guile.c: Fix common/ includes.
9291         * go32-nat.c: Fix common/ includes.
9292         * gnu-nat.c: Fix common/ includes.
9293         * gdbthread.h: Fix common/ includes.
9294         * gdbarch-selftests.c: Fix common/ includes.
9295         * gdb_usleep.c: Fix common/ includes.
9296         * gdb_select.h: Fix common/ includes.
9297         * gdb_bfd.c: Fix common/ includes.
9298         * gcore.c: Fix common/ includes.
9299         * fork-child.c: Fix common/ includes.
9300         * findvar.c: Fix common/ includes.
9301         * fbsd-nat.c: Fix common/ includes.
9302         * event-top.c: Fix common/ includes.
9303         * event-loop.c: Fix common/ includes.
9304         * dwarf2read.c: Fix common/ includes.
9305         * dwarf2loc.c: Fix common/ includes.
9306         * dwarf2-frame.c: Fix common/ includes.
9307         * dwarf-index-cache.c: Fix common/ includes.
9308         * dtrace-probe.c: Fix common/ includes.
9309         * disasm-selftests.c: Fix common/ includes.
9310         * defs.h: Fix common/ includes.
9311         * csky-tdep.c: Fix common/ includes.
9312         * cp-valprint.c: Fix common/ includes.
9313         * cp-support.h: Fix common/ includes.
9314         * cp-support.c: Fix common/ includes.
9315         * corelow.c: Fix common/ includes.
9316         * completer.h: Fix common/ includes.
9317         * completer.c: Fix common/ includes.
9318         * compile/compile.c: Fix common/ includes.
9319         * compile/compile-loc2c.c: Fix common/ includes.
9320         * compile/compile-cplus-types.c: Fix common/ includes.
9321         * compile/compile-cplus-symbols.c: Fix common/ includes.
9322         * command.h: Fix common/ includes.
9323         * cli/cli-dump.c: Fix common/ includes.
9324         * cli/cli-cmds.c: Fix common/ includes.
9325         * charset.c: Fix common/ includes.
9326         * build-id.c: Fix common/ includes.
9327         * btrace.h: Fix common/ includes.
9328         * btrace.c: Fix common/ includes.
9329         * breakpoint.h: Fix common/ includes.
9330         * breakpoint.c: Fix common/ includes.
9331         * ax.h:
9332         (enum agent_op): Fix common/ includes.
9333         * ax-general.c (struct aop_map): Fix common/ includes.
9334         * ax-gdb.c: Fix common/ includes.
9335         * auxv.c: Fix common/ includes.
9336         * auto-load.c: Fix common/ includes.
9337         * arm-tdep.c: Fix common/ includes.
9338         * arch/riscv.c: Fix common/ includes.
9339         * arch/ppc-linux-common.c: Fix common/ includes.
9340         * arch/i386.c: Fix common/ includes.
9341         * arch/arm.c: Fix common/ includes.
9342         * arch/arm-linux.c: Fix common/ includes.
9343         * arch/arm-get-next-pcs.c: Fix common/ includes.
9344         * arch/amd64.c: Fix common/ includes.
9345         * arch/aarch64.c: Fix common/ includes.
9346         * arch/aarch64-insn.c: Fix common/ includes.
9347         * arch-utils.c: Fix common/ includes.
9348         * amd64-windows-tdep.c: Fix common/ includes.
9349         * amd64-tdep.c: Fix common/ includes.
9350         * amd64-sol2-tdep.c: Fix common/ includes.
9351         * amd64-obsd-tdep.c: Fix common/ includes.
9352         * amd64-nbsd-tdep.c: Fix common/ includes.
9353         * amd64-linux-tdep.c: Fix common/ includes.
9354         * amd64-linux-nat.c: Fix common/ includes.
9355         * amd64-fbsd-tdep.c: Fix common/ includes.
9356         * amd64-fbsd-nat.c: Fix common/ includes.
9357         * amd64-dicos-tdep.c: Fix common/ includes.
9358         * amd64-darwin-tdep.c: Fix common/ includes.
9359         * agent.c: Fix common/ includes.
9360         * ada-lang.h: Fix common/ includes.
9361         * ada-lang.c: Fix common/ includes.
9362         * aarch64-tdep.c: Fix common/ includes.
9363
9364 2019-01-25  Tom Tromey  <tom@tromey.com>
9365
9366         * common/create-version.sh: Use common/version.h.
9367
9368 2019-01-24  Pedro Alves  <palves@redhat.com>
9369
9370         * infrun.c (signal_stop, signal_print, signal_program)
9371         (signal_catch, signal_pass): Now arrays instead of pointers.
9372         (update_signals_program_target, do_target_resume)
9373         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9374         * linux-nat.c (linux_nat_target::pass_signals)
9375         (linux_nat_target::create_inferior, linux_nat_target::attach):
9376         Adjust.
9377         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9378         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9379         * procfs.c (procfs_target::pass_signals): Adjust.
9380         * record-full.c (record_full_target::resume): Adjust.
9381         * remote.c (remote_target::pass_signals)
9382         (remote_target::program_signals): Adjust.
9383         * target-debug.h (target_debug_print_signals): Now takes a
9384         gdb::array_view as parameter.  Adjust.
9385         * target.h (target_ops) <pass_signals, program_signals>: Replace
9386         pointer and length parameters with gdb::array_view.
9387         (target_pass_signals, target_program_signals): Likewise.
9388         * target-delegates.c: Regenerate.
9389
9390 2019-01-24  Pedro Alves  <palves@redhat.com>
9391
9392         * common/forward-scope-exit.h
9393         (forward_scope_exit::forward_scope_exit): Pass arguments to
9394         m_bind_function directly, instead of creating a std::bind and
9395         copying that.
9396
9397 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9398
9399         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9400         for static members.
9401         (pass_in_v_vfp_candidate): Likewise.
9402
9403 2019-01-23  Tom Tromey  <tom@tromey.com>
9404             Pedro Alves  <palves@redhat.com>
9405
9406         * regcache.c (class regcache_invalidator): Remove.
9407         (regcache::raw_write): Use make_scope_exit.
9408
9409 2019-01-23  Tom Tromey  <tom@tromey.com>
9410
9411         * ui-out.h (class ui_out_emit_type): Update comment.
9412
9413 2019-01-23  Tom Tromey  <tom@tromey.com>
9414
9415         * infrun.c (fetch_inferior_event): Update comment.
9416
9417 2019-01-23  Tom Tromey  <tom@tromey.com>
9418             Pedro Alves  <palves@redhat.com>
9419
9420         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9421         parameter.
9422         (fetch_inferior_event): Use SCOPE_EXIT.
9423
9424
9425 2019-01-23  Tom Tromey  <tom@tromey.com>
9426             Pedro Alves  <palves@redhat.com>
9427
9428         * infrun.c (disable_thread_events): Delete.
9429         (stop_all_threads): Use SCOPE_EXIT.
9430
9431 2019-01-23  Tom Tromey  <tom@tromey.com>
9432             Pedro Alves  <palves@redhat.com>
9433
9434         * symfile.c: Include forward-scope-exit.h.
9435         (clear_symtab_users_cleanup): Replace forward declaration with
9436         a FORWARD_SCOPE_EXIT.
9437         (syms_from_objfile_1): Use the forward_scope_exit and
9438         gdb::optional instead of cleanup_function.
9439         (reread_symbols): Use the forward_scope_exit instead of
9440         cleanup_function.
9441         (clear_symtab_users_cleanup): Remove function.
9442
9443 2019-01-23  Tom Tromey  <tom@tromey.com>
9444             Pedro Alves  <palves@redhat.com>
9445
9446         * linux-nat.c: Include scope-exit.h.
9447         (cleanup_target_stop): Remove.
9448         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9449         SCOPE_EXIT.
9450
9451 2019-01-23  Tom Tromey  <tom@tromey.com>
9452             Pedro Alves  <palves@redhat.com>
9453
9454         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9455         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9456
9457 2019-01-23  Tom Tromey  <tom@tromey.com>
9458             Andrew Burgess  <andrew.burgess@embecosm.com>
9459             Pedro Alves  <palves@redhat.com>
9460
9461         * infrun.c (fetch_inferior_event): Use scope_exit.
9462         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9463         * top.c (execute_command): Use scope_exit.
9464         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9465         * utils.c (do_bpstat_clear_actions_cleanup)
9466         (make_bpstat_clear_actions_cleanup): Remove.
9467
9468 2019-01-23  Tom Tromey  <tom@tromey.com>
9469             Pedro Alves  <palves@redhat.com>
9470
9471         * infrun.c: Include "common/scope-exit.h"
9472         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9473         (wait_for_inferior): Use SCOPE_EXIT.
9474         (fetch_inferior_event): Use scope_exit.
9475
9476 2019-01-23  Tom Tromey  <tom@tromey.com>
9477             Pedro Alves  <palves@redhat.com>
9478
9479         * breakpoint.c (create_breakpoint): Remove cleanup.
9480
9481 2019-01-23  Tom Tromey  <tom@tromey.com>
9482             Andrew Burgess  <andrew.burgess@embecosm.com>
9483             Pedro Alves  <palves@redhat.com>
9484
9485 2019-01-23  Pedro Alves  <palves@redhat.com>
9486
9487         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9488
9489 2019-01-23  Pedro Alves  <palves@redhat.com>
9490             Andrew Burgess  <andrew.burgess@embecosm.com>
9491
9492         * gdbthread.h: Include "common/forward-scope-exit.h".
9493         (scoped_finish_thread_state): Redefine custom class in terms of
9494         forward_scope_exit.
9495
9496 2019-01-23  Pedro Alves  <palves@redhat.com>
9497             Andrew Burgess  <andrew.burgess@embecosm.com>
9498
9499         * common/forward-scope-exit.h: New file.
9500
9501 2019-01-23  Pedro Alves  <palves@redhat.com>
9502             Andrew Burgess  <andrew.burgess@embecosm.com>
9503             Tom Tromey  <tom@tromey.com>
9504
9505         * common/scope-exit.h: New file.
9506
9507 2019-01-23  Pedro Alves  <palves@redhat.com>
9508
9509         * common/preprocessor.h (ESC): Rename to ...
9510         (ESC_PARENS): ... this.
9511         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9512         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9513
9514 2019-01-23  Tom Tromey  <tom@tromey.com>
9515
9516         * language.h (class scoped_switch_to_sym_language_if_auto):
9517         Initialize m_lang in both cases.
9518
9519 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9520
9521         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9522         with XCNEW.
9523
9524 2019-01-22  Tom Tromey  <tom@tromey.com>
9525
9526         * corelow.c: Do not include sys/file.h.
9527
9528 2019-01-22  Tom Tromey  <tom@tromey.com>
9529
9530         * tui/tui-wingeneral.h: Include gdb_curses.h.
9531
9532 2019-01-22  Tom Tromey  <tom@tromey.com>
9533
9534         * source-cache.h (class source_cache) <get_source_lines,
9535         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9536
9537 2019-01-22  Tom Tromey  <tom@tromey.com>
9538
9539         * remote-fileio.h (struct remote_target): Declare.
9540
9541 2019-01-22  Tom Tromey  <tom@tromey.com>
9542
9543         * python/py-arch.c: Do not include py-ref.h.
9544         * python/py-bpevent.c: Do not include py-ref.h.
9545         * python/py-cmd.c: Do not include py-ref.h.
9546         * python/py-continueevent.c: Do not include py-ref.h.
9547         * python/py-event.h: Do not include py-ref.h.
9548         * python/py-evtregistry.c: Do not include py-ref.h.
9549         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9550         * python/py-frame.c: Do not include py-ref.h.
9551         * python/py-framefilter.c: Do not include py-ref.h.
9552         * python/py-function.c: Do not include py-ref.h.
9553         * python/py-infevents.c: Do not include py-ref.h.
9554         * python/py-linetable.c: Do not include py-ref.h.
9555         * python/py-objfile.c: Do not include py-ref.h.
9556         * python/py-param.c: Do not include py-ref.h.
9557         * python/py-prettyprint.c: Do not include py-ref.h.
9558         * python/py-progspace.c: Do not include py-ref.h.
9559         * python/py-symbol.c: Do not include py-ref.h.
9560         * python/py-symtab.c: Do not include py-ref.h.
9561         * python/py-type.c: Do not include py-ref.h.
9562         * python/py-unwind.c: Do not include py-ref.h.
9563         * python/py-utils.c: Do not include py-ref.h.
9564         * python/py-value.c: Do not include py-ref.h.
9565         * python/py-varobj.c: Do not include py-ref.h.
9566         * python/py-xmethods.c: Do not include py-ref.h.
9567         * python/python.c: Do not include py-ref.h.
9568         * varobj.c: Do not include py-ref.h.
9569
9570 2019-01-22  Tom Tromey  <tom@tromey.com>
9571
9572         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9573         keyword for bcache.
9574
9575 2019-01-22  Tom Tromey  <tom@tromey.com>
9576
9577         * compile/compile-cplus-types.c: Remove a comment by #include.
9578
9579 2019-01-22  Tom Tromey  <tom@tromey.com>
9580
9581         * compile/gcc-c-plugin.h: Include compile-internal.h.
9582
9583 2019-01-22  Tom Tromey  <tom@tromey.com>
9584
9585         * stabsread.c (EXTERN): Do not define.
9586         (symnum, next_symbol_text_func, processing_gcc_compilation)
9587         (within_function, global_sym_chain, global_stabs)
9588         (previous_stab_code, this_object_header_files)
9589         (n_this_object_header_files)
9590         (n_allocated_this_object_header_files): Define.
9591         * stabsread.h (EXTERN): Never define.  Use "extern".
9592
9593 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9594
9595         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9596         history_value.
9597
9598 2019-01-21  Tom Tromey  <tom@tromey.com>
9599
9600         * ui-out.c: Fix includes.
9601         * tui/tui-source.c: Fix includes.
9602         * target.c: Fix includes.
9603         * remote.c: Fix includes.
9604         * regcache.c: Fix includes.
9605         * python/py-block.c: Fix includes.
9606         * printcmd.c: Fix includes.
9607         * or1k-tdep.c: Fix includes.
9608         * mi/mi-main.c: Fix includes.
9609         * m32r-tdep.c: Fix includes.
9610         * csky-tdep.c: Fix includes.
9611         * compile/compile-cplus-types.c: Fix includes.
9612         * cli/cli-interp.c: Fix includes.
9613
9614 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9615
9616         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9617         for padding.
9618
9619 2019-01-16  Tom Tromey  <tom@tromey.com>
9620
9621         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9622         earlier.
9623         (struct objfile) <msymbols_range>: Move from top level.
9624         <msymbols>: New method.
9625         (class objfile_msymbols): Remove.
9626         * symtab.c (default_collect_symbol_completion_matches_break_on):
9627         Update.
9628         * symmisc.c (dump_msymbols): Update.
9629         * stabsread.c (scan_file_globals): Update.
9630         * objc-lang.c (info_selectors_command, info_classes_command)
9631         (find_methods): Update.
9632         * minsyms.c (find_solib_trampoline_target): Update.
9633         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9634         * coffread.c (coff_symfile_read): Update.
9635         * ada-lang.c (ada_lookup_simple_minsym)
9636         (ada_collect_symbol_completion_matches): Update.
9637
9638 2019-01-16  Tom Tromey  <tom@tromey.com>
9639
9640         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9641         type.  Remove no-argument constructor.
9642         <iterator::operator++>: Simplify.
9643         <begin>: Update.
9644         <end>: Use minimal_symbol_count.
9645
9646 2019-01-16  Tom Tromey  <tom@tromey.com>
9647
9648         * objfiles.h (struct objfile) <psymtabs>: New method.
9649         (class objfile_psymtabs): Remove.
9650         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9651         typedef.
9652         <range>: New method.
9653         (require_partial_symbols): Change return type.
9654         * psymtab.c (require_partial_symbols)
9655         (psym_expand_symtabs_matching): Update.
9656         * mdebugread.c (parse_partial_symbols): Update.
9657         * dbxread.c (dbx_end_psymtab): Update.
9658
9659 2019-01-15  Tom Tromey  <tom@tromey.com>
9660
9661         * symtab.c (lookup_objfile_from_block)
9662         (lookup_symbol_in_objfile_symtabs)
9663         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9664         (find_line_symtab, info_sources_command)
9665         (default_collect_symbol_completion_matches_break_on)
9666         (make_source_files_completion_list): Update.
9667         * symmisc.c (print_objfile_statistics, dump_objfile)
9668         (maintenance_print_symbols, maintenance_info_symtabs)
9669         (maintenance_check_symtabs, maintenance_info_line_tables):
9670         Update.
9671         * source.c (select_source_symtab)
9672         (forget_cached_source_info_for_objfile): Update.
9673         * objfiles.h (class objfile_compunits): Remove.
9674         (struct objfile) <compunits_range>: New typedef.
9675         (compunits): New method.
9676         * objfiles.c (objfile_relocate1): Update.
9677         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9678         * maint.c (count_symtabs_and_blocks): Update.
9679         * linespec.c (iterate_over_all_matching_symtabs): Update.
9680         * cp-support.c (add_symbol_overload_list_qualified): Update.
9681         * coffread.c (coff_symtab_read): Update.
9682         * ada-lang.c (add_nonlocal_symbols)
9683         (ada_collect_symbol_completion_matches)
9684         (ada_add_global_exceptions): Update.
9685
9686 2019-01-15  Tom Tromey  <tom@tromey.com>
9687
9688         * progspace.h (program_space) <objfiles_safe_range>: New
9689         typedef.
9690         <objfiles_safe>: New method.
9691         * objfiles.h (class all_objfiles_safe): Remove.
9692         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9693         * jit.c (jit_inferior_exit_hook): Update.
9694
9695 2019-01-17  Tom Tromey  <tom@tromey.com>
9696
9697         * progspace.h (program_space) <objfiles_range>: New typedef.
9698         <objfiles>: New method.
9699         <objfiles_head>: Rename from objfiles.
9700         (object_files): Update.
9701         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9702         * guile/scm-pretty-print.c
9703         (ppscm_find_pretty_printer_from_objfiles): Update.
9704         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9705         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9706         Update.
9707         * python/py-progspace.c (pspy_get_objfiles): Update.
9708         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9709         Update.
9710         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9711         (objfpy_lookup_objfile_by_build_id): Update.
9712         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9713         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9714         Update.
9715         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9716         (expand_symtab_containing_pc, lookup_objfile_from_block)
9717         (lookup_static_symbol, basic_lookup_transparent_type)
9718         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9719         (find_line_symtab, info_sources_command)
9720         (default_collect_symbol_completion_matches_break_on)
9721         (make_source_files_completion_list, find_main_name): Update.
9722         * symmisc.c (print_symbol_bcache_statistics)
9723         (print_objfile_statistics, maintenance_print_symbols)
9724         (maintenance_print_msymbols, maintenance_print_objfiles)
9725         (maintenance_info_symtabs, maintenance_check_symtabs)
9726         (maintenance_expand_symtabs, maintenance_info_line_tables):
9727         Update.
9728         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9729         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9730         (map_overlay_command, unmap_overlay_command)
9731         (simple_overlay_update, expand_symtabs_matching)
9732         (map_symbol_filenames): Update.
9733         * symfile-debug.c (set_debug_symfile): Update.
9734         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9735         Update.
9736         * source.c (select_source_symtab, forget_cached_source_info):
9737         Update.
9738         * solib.c (solib_read_symbols): Update.
9739         * solib-spu.c (append_ocl_sos): Update.
9740         * psymtab.c (maintenance_print_psymbols)
9741         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9742         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9743         * printcmd.c (info_symbol_command): Update.
9744         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9745         Update.
9746         * objfiles.h (class all_objfiles): Remove.
9747         * objfiles.c (have_partial_symbols, have_full_symbols)
9748         (have_minimal_symbols, qsort_cmp, update_section_map)
9749         (shared_objfile_contains_address_p)
9750         (default_iterate_over_objfiles_in_search_order): Update.
9751         * objc-lang.c (info_selectors_command, info_classes_command)
9752         (find_methods): Update.
9753         * minsyms.c (find_solib_trampoline_target): Update.
9754         * maint.c (maintenance_info_sections)
9755         (maintenance_translate_address, count_symtabs_and_blocks):
9756         Update.
9757         * main.c (captured_main_1): Update.
9758         * linux-thread-db.c (try_thread_db_load_from_pdir)
9759         (has_libpthread): Update.
9760         * linespec.c (iterate_over_all_matching_symtabs)
9761         (search_minsyms_for_name): Update.
9762         * jit.c (jit_find_objf_with_entry_addr): Update.
9763         * hppa-tdep.c (find_unwind_entry)
9764         (hppa_lookup_stub_minimal_symbol): Update.
9765         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9766         Update.
9767         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9768         (elf_gnu_ifunc_resolve_by_got): Update.
9769         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9770         * dwarf-index-write.c (save_gdb_index_command): Update.
9771         * cp-support.c (add_symbol_overload_list_qualified): Update.
9772         * breakpoint.c (create_overlay_event_breakpoint)
9773         (create_longjmp_master_breakpoint)
9774         (create_std_terminate_master_breakpoint)
9775         (create_exception_master_breakpoint): Update.
9776         * blockframe.c (find_pc_partial_function): Update.
9777         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9778         (ada_collect_symbol_completion_matches)
9779         (ada_add_global_exceptions): Update.
9780
9781 2019-01-17  Tom Tromey  <tom@tromey.com>
9782
9783         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9784         declare VEC.
9785         (solib_target_parse_libraries): Change return type.
9786         (library_list_start_segment, library_list_start_section)
9787         (library_list_end_library, library_list_start_library); Update.
9788         (solib_target_free_library_list): Remove.
9789         (solib_target_parse_libraries): Remove cleanup.  Change return
9790         type.
9791         (solib_target_current_sos): Update.
9792
9793 2019-01-17  Tom Tromey  <tromey@bapiya>
9794
9795         * valprint.c: Replace "the the" with "the".
9796         * symtab.c: Replace "the the" with "the".
9797         * solib.c: Replace "the the" with "the".
9798         * solib-dsbt.c: Replace "the the" with "the".
9799         * linespec.c: Replace "the the" with "the".
9800         * dwarf2loc.h: Replace "the the" with "the".
9801         * amd64-windows-tdep.c: Replace "the the" with "the".
9802         * aarch64-tdep.c: Replace "the the" with "the".
9803
9804 2019-01-16  Keith Seitz  <keiths@redhat.com>
9805
9806         PR gdb/23773
9807         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9808         <builder>: Rename to ..
9809         <m_builder>: ... this and make private.
9810         (dwarf2_cu::get_builder): New method.  Change all users of
9811         `builder' to use this method.
9812         (dwarf2_start_symtab): Move to ...
9813         (dwarf2_cu::start_symtab): ... here.  Update all callers
9814         (setup_type_unit_groups): Move to ...
9815         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9816         callers.
9817         (dwarf2_cu::reset_builder): New method.
9818         (process_full_compunit, process_full_type_unit): Use
9819         dwarf2_cu::reset_builder.
9820         (follow_die_offset): Record the ancestor CU if it is different
9821         from the followed DIE's CU.
9822         (follow_die_sig_1): Likewise.
9823
9824 2019-01-15  Tom Tromey  <tom@tromey.com>
9825
9826         * remote.c (class remote_state) <buf>: Now a char_vector.
9827         <buf_size>: Remove.
9828         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9829         parameter.
9830         (remote_target::getpkt_or_notif_sane_1)
9831         (remote_target::getpkt_sane)
9832         (remote_target::getpkt_or_notif_sane): Likewise.
9833         (class remote_target) <putpkt>: New overload.
9834         (remote_target::read_frame): Change type of "buf_p".  Remove
9835         sizeof_p parameter.
9836         (packet_ok): New overload.
9837         (packet_check_result): New overload.
9838         Update all uses.
9839
9840 2019-01-14  Tom Tromey  <tom@tromey.com>
9841
9842         * remote-notif.c (handle_notification, remote_notif_ack)
9843         (remote_notif_parse): Make "buf" const.
9844         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9845         const.
9846         (remote_notif_parse, remote_notif_ack, handle_notification):
9847         Likewise.
9848         * remote.c (remote_notif_stop_parse): Make "buf" const.
9849         (remote_target::remote_parse_stop_reply): Make "buf" const.
9850         (remote_notif_stop_ack): Make "buf" const.
9851
9852 2019-01-14  Tom Tromey  <tom@tromey.com>
9853
9854         * remote.c (remote_console_output): Make parameter const.
9855
9856 2019-01-14  Tom Tromey  <tom@tromey.com>
9857
9858         * target-debug.h (target_debug_print_signals): Constify.
9859         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9860         * procfs.c (procfs_target::pass_signals): Update.
9861         * linux-nat.c (linux_nat_target::pass_signals): Update.
9862         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9863         * target-delegates.c: Rebuild.
9864         * remote.c (remote_target::program_signals): Update.
9865         (remote_target::pass_signals): Update.
9866         * target.c (target_pass_signals): Constify argument.
9867         (target_program_signals): Likewise.
9868         * target.h (struct target_ops) <pass_signals, program_signals>:
9869         Constify argument.
9870         (target_pass_signals, target_program_signals): Constify argument.
9871
9872 2019-01-14  Tom Tromey  <tom@tromey.com>
9873
9874         PR tui/28819:
9875         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9876
9877 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9878
9879         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9880         field.
9881         * rs6000-tdep.c: Include reggroups.h.
9882         (IS_V_ALIAS_PSEUDOREG): Define.
9883         (rs6000_register_name): Return names for the "vX" aliases.
9884         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9885         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9886         aliases.  Call default_register_reggroup_p for all other
9887         pseudo-registers.
9888         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9889         New functions.
9890         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9891         Handle "vX" aliases.
9892         (v_alias_pseudo_register_collect): New function.
9893         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9894         (rs6000_gdbarch_init): Initialize "vX" aliases as
9895         pseudo-registers.  Restore registration of
9896         rs6000_pseudo_register_reggroup_p with
9897         set_tdesc_pseudo_register_reggroup_p.
9898
9899 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9900
9901         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9902         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9903         set_gdbarch_num_pseudo_regs.
9904
9905 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9906
9907         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9908         Remove arg prefixname, add do_set and do_show.
9909         Add member functions set_list and show_list.
9910         * cli/cli-style.c (class cli_style_option): Update accordingly.
9911         (style_set_list): Move to file scope.
9912         (style_show_list): Likewise.
9913         (set_style): Call help_list.
9914         (show_style): Call cmd_show_list.
9915         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9916         Update to use the new macro.
9917
9918 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9919
9920         * ada-lang.c (_initialize_ada_language): Expand the help text
9921         for the "catch exception" command.
9922
9923 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9924
9925         * symtab.c (matching_obj_sections): Initialize obj,
9926         declare it closer to its usage.
9927
9928 2019-01-10  Tom Tromey  <tom@tromey.com>
9929
9930         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9931         (basic_inf_threads_range): Remove.
9932         (inf_threads_range, inf_non_exited_threads_range)
9933         (safe_inf_threads_range): Use next_adapter.
9934
9935 2019-01-10  Keith Seitz  <keiths@redhat.com>
9936
9937         PR gdb/23712
9938         PR symtab/23010
9939         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9940         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9941
9942 2019-01-10  Keith Seitz  <keiths@redhat.com>
9943
9944         PR gdb/23712
9945         PR symtab/23010
9946         * dictionary.c (pending_to_vector): Remove.
9947         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9948         Remove _1 suffix, replacing functions of the same name.  Update
9949         all callers.
9950         (dict_create_hashed, dict_create_hashed_expandable)
9951         (dict_create_linear, dict_create_linear_expandable, dict_free)
9952         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9953         Make functions static.
9954
9955 2019-01-10  Keith Seitz  <keiths@redhat.com>
9956
9957         PR gdb/23712
9958         PR symtab/23010
9959         * dictionary.h (struct dictionary): Replace declaration with
9960         multidictionary.
9961         (dict_create_hashed, dict_create_hashed_expandable)
9962         (dict_create_linear, dict_create_linear_expandable)
9963         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9964         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9965         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9966         taking multidictionary argument.
9967         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9968         * block.h (struct block) <dict>: Change to multidictionary
9969         and rename `multidict'.
9970         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9971         symmisc.c: Update all dictionary references to multidictionary.
9972
9973 2019-01-10  Keith Seitz  <keiths@redhat.com>
9974
9975         PR gdb/23712
9976         PR symtab/23010
9977         * dictionary.c: Include unordered_map.
9978         (pending_to_vector): New function.
9979         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9980         Rewrite the non-"_1" functions to take vector instead
9981         of linked list.
9982         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9983         "new" _1 versions of the same name.
9984         (multidictionary): Define.
9985         (std::hash<enum language): New definition.
9986         (collate_pending_symbols_by_language, mdict_create_hashed)
9987         (mdict_create_hashed_expandable, mdict_create_linear)
9988         (mdict_create_linear_expandable, mdict_free)
9989         (find_language_dictionary, create_new_language_dictionary)
9990         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9991         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9992         (mdict_size, mdict_empty): New functions.
9993         * dictionary.h (mdict_iterator): Define.
9994
9995 2019-01-10  Pedro Alves  <palves@redhat.com>
9996
9997         * breakpoint.c (read_uploaded_action)
9998         (create_tracepoint_from_upload): Adjust to use
9999         gdb::unique_xmalloc_ptr.
10000         * ctf.c (ctf_write_uploaded_tp):
10001         (SET_ARRAY_FIELD): Use emplace_back.
10002         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10003         * tracefile-tfile.c (tfile_write_uploaded_tp):
10004         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10005         gdb::unique_xmalloc_ptr.
10006         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10007         at_string, cond_string, cmd_strings>: Replace char pointers
10008         with gdb::unique_xmalloc_ptr.
10009
10010 2019-01-10  Pedro Alves  <palves@redhat.com>
10011
10012         * solib-target.c (library_list_start_library): Don't xstrdup name.
10013
10014 2019-01-10  Pedro Alves  <palves@redhat.com>
10015
10016         * mdebugread.c (parse_partial_symbols): Use
10017         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10018
10019 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10020
10021         * linux-fork.c (scoped_switch_fork_info)
10022         <~scoped_switch_fork_info>: Fix incorrect variable name.
10023
10024 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10025
10026         * linux-fork.c (scoped_switch_fork_info)
10027         <scoped_switch_fork_info>: Make explicit.
10028         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10029
10030 2019-01-10  Tom Tromey  <tom@tromey.com>
10031
10032         * objfiles.h (objfile::reset_psymtabs): Update.
10033         * objfiles.c (objfile::objfile): Update.
10034         * psymtab.h (psymtab_storage::obstack): Update.
10035         (psymtab_storage::m_obstack): Use gdb::optional.
10036         (class psymtab_storage): Update comment.  Remove objfile
10037         parameter.
10038         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10039
10040 2019-01-10  Tom Tromey  <tom@tromey.com>
10041
10042         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10043         <free_psymtabs>: Now private.
10044         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10045         (allocate_psymtab): Use new method.
10046
10047 2019-01-10  Tom Tromey  <tom@tromey.com>
10048
10049         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10050         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10051         * mdebugread.c (parse_partial_symbols): Use
10052         allocate_dependencies.
10053         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10054         allocate_dependencies.
10055         (process_psymtab_comp_unit_reader)
10056         (build_type_psymtab_dependencies): Likewise.
10057         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10058
10059 2019-01-10  Tom Tromey  <tom@tromey.com>
10060
10061         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10062         PSYMBOL_SET_LANGUAGE.
10063         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10064
10065 2019-01-10  Tom Tromey  <tom@tromey.com>
10066
10067         * psymtab.h (psymtab_storage::obstack): New method.
10068         <m_obstack>: Rename from obstack; now private.
10069         * psymtab.c (psymtab_storage): Update.
10070         * dwarf2read.c (create_addrmap_from_index)
10071         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10072         Update.
10073
10074 2019-01-10  Tom Tromey  <tom@tromey.com>
10075
10076         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10077         * objfiles.h (objfile::reset_psymtabs): New method.
10078
10079 2019-01-10  Tom Tromey  <tom@tromey.com>
10080
10081         * symmisc.c (print_symbol_bcache_statistics): Update.
10082         (print_objfile_statistics): Update.
10083         * symfile.c (reread_symbols): Update.
10084         * psymtab.h (class psymtab_storage): New.
10085         * psymtab.c (psymtab_storage): New constructor.
10086         (~psymtab_storage): New destructor.
10087         (require_partial_symbols): Update.
10088         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10089         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10090         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10091         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10092         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10093         (start_psymtab_common, end_psymtab_common)
10094         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10095         (allocate_psymtab): Update.
10096         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10097         Update.
10098         (dump_psymtab_addrmap, maintenance_print_psymbols)
10099         (maintenance_check_psymtabs): Update.
10100         (class objfile_psymtabs): Move to objfiles.h.
10101         * psympriv.h (discard_psymtab): Now inline.
10102         (psymtab_discarder::psymtab_discarder): Update.
10103         (psymtab_discarder::~psymtab_discarder): Update.
10104         (ALL_OBJFILE_PSYMTABS): Rewrite.
10105         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10106         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10107         Remove fields.
10108         <partial_symtabs>: New field.
10109         (class objfile_psymtabs): Move from psymtab.h.  Update.
10110         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10111         psymbol_cache.
10112         (objfile::~objfile): Don't destroy psymbol_cache.
10113         * mdebugread.c (parse_partial_symbols): Update.
10114         * dwarf2read.c (create_addrmap_from_index)
10115         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10116         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10117         (add_partial_subprogram, dwarf2_ranges_read): Update.
10118         * dwarf-index-write.c (write_address_map)
10119         (write_one_signatured_type, recursively_write_psymbols)
10120         (class debug_names, class debug_names, write_psymtabs_to_index):
10121         Update.
10122
10123 2019-01-10  Tom Tromey  <tom@tromey.com>
10124
10125         * symtab.h (SYMBOL_SET_NAMES): Update.
10126         (symbol_set_names): Update.
10127         (MSYMBOL_SET_NAMES): Update.
10128         * symtab.c (symbol_set_names): Change argument to be an
10129         objfile_per_bfd_storage.
10130         * psymtab.c (add_psymbol_to_bcache): Update.
10131         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10132
10133 2019-01-10  Tom Tromey  <tom@tromey.com>
10134
10135         * symtab.c (create_demangled_names_hash): Change argument to be an
10136         objfile_per_bfd_storage.
10137         (symbol_set_names): Update.
10138
10139 2019-01-10  Tom Tromey  <tom@tromey.com>
10140
10141         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10142         init_psymbol_list.
10143         * psymtab.c (init_psymbol_list): Do nothing if already called.
10144         * psympriv.h (init_psymbol_list): Add comment.
10145         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10146         init_psymbol_list.
10147         * dbxread.c (dbx_symfile_read): Unconditionally call
10148         init_psymbol_list.
10149
10150 2019-01-10  Tom Tromey  <tom@tromey.com>
10151
10152         * xcoffread.c (scan_xcoff_symtab): Update.
10153         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10154         "where".
10155         * mdebugread.c (parse_partial_symbols)
10156         (handle_psymbol_enumerators): Update.
10157         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10158         * dbxread.c (read_dbx_symtab): Update.
10159         * psympriv.h (psymbol_placement): New enum.
10160         (add_psymbol_to_list): Update.
10161
10162 2019-01-10  Tom Tromey  <tom@tromey.com>
10163
10164         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10165         static_psymbols parameters.
10166         (scan_xcoff_symtab): Update.
10167         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10168         static_psymbols parameters.
10169         * psympriv.h (start_psymtab_common): Update.
10170         * mdebugread.c (parse_partial_symbols): Update.
10171         * dwarf2read.c (create_partial_symtab): Update.
10172         * dbxread.c (read_dbx_symtab): Update.
10173         (start_psymtab): Remove global_psymbols and static_psymbols
10174         parameters.
10175
10176 2019-01-10  Tom Tromey  <tom@tromey.com>
10177
10178         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10179         * psymtab.c (allocate_psymtab): Add comment.
10180         * psympriv.h (allocate_psymtab): Add comment.
10181         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10182         initializations.
10183         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10184
10185 2019-01-10  Tom Tromey  <tom@tromey.com>
10186
10187         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10188         Don't declare.
10189         * mipsread.c: Include mdebugread.h.
10190         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10191         Declare.
10192         * elfread.c: Include mdebugread.h.
10193
10194 2019-01-09  Tom Tromey  <tom@tromey.com>
10195
10196         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10197         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10198         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10199         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10200         (psym_lookup_symbol, psym_find_last_source_symtab)
10201         (psym_forget_cached_source_info, psym_print_stats)
10202         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10203         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10204         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10205         (psym_find_compunit_symtab_by_address)
10206         (maintenance_print_psymbols, maintenance_info_psymtabs)
10207         (maintenance_check_psymtabs): Use ranged for.
10208         * psymtab.h (class objfile_psymtabs): New.
10209         (require_partial_symbols): Return objfile_psymtabs.
10210         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10211
10212 2019-01-09  Tom Tromey  <tom@tromey.com>
10213
10214         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10215         (find_pc_mapped_section, list_overlays_command)
10216         (map_overlay_command, unmap_overlay_command)
10217         (simple_overlay_update): Use all_objfiles.
10218         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10219         * printcmd.c (info_symbol_command): Use all_objfiles.
10220         * objfiles.h (ALL_OBJSECTIONS): Remove.
10221         * maint.c (maintenance_translate_address): Use all_objfiles.
10222         * gcore.c (gcore_create_callback): Use all_objfiles.
10223         (objfile_find_memory_regions): Likewise.
10224
10225 2019-01-09  Tom Tromey  <tom@tromey.com>
10226
10227         * symtab.c (find_line_symtab, info_sources_command)
10228         (make_source_files_completion_list): Use objfile_compunits.
10229         * source.c (select_source_symtab): Use objfile_compunits.
10230         * objfiles.h (struct objfile): Update comment.
10231         (ALL_OBJFILES): Remove.
10232         (ALL_FILETABS): Remove.
10233         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10234         objfile_compunits.
10235
10236 2019-01-09  Tom Tromey  <tom@tromey.com>
10237
10238         * symmisc.c (print_objfile_statistics, dump_objfile)
10239         (maintenance_print_symbols): Use compunit_filetabs.
10240         * source.c (forget_cached_source_info_for_objfile): Use
10241         compunit_filetabs.
10242         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10243         (ALL_FILETABS): Use compunit_filetabs.
10244         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10245         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10246
10247 2019-01-09  Tom Tromey  <tom@tromey.com>
10248
10249         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10250         (compunit_filetabs): New.
10251         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10252         compunit_filetabs.
10253         (info_sources_command, make_source_files_completion_list): Remove
10254         declaration.
10255         * symmisc.c (print_objfile_statistics, dump_objfile)
10256         (maintenance_print_symbols): Remove declaration.
10257         (maintenance_info_symtabs): Use compunit_filetabs.
10258         (maintenance_info_line_tables): Likewise.
10259         * source.c (select_source_symtab): Change local variable name.
10260         (forget_cached_source_info_for_objfile): Remove declaration.
10261         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10262         * objfiles.c (objfile_relocate1): Remove declaration.
10263         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10264         declaration.
10265         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10266         * coffread.c (coff_symtab_read): Remove declaration.
10267         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10268         compunit_filetabs.
10269
10270 2019-01-09  Tom Tromey  <tom@tromey.com>
10271
10272         * symtab.c (lookup_objfile_from_block)
10273         (find_pc_sect_compunit_symtab, search_symbols)
10274         (default_collect_symbol_completion_matches_break_on): Use
10275         objfile_compunits.
10276         * objfiles.h (ALL_COMPUNITS): Remove.
10277         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10278         * cp-support.c (add_symbol_overload_list_qualified): Use
10279         objfile_compunits.
10280         * ada-lang.c (ada_collect_symbol_completion_matches)
10281         (ada_add_global_exceptions): Use objfile_compunits.
10282
10283 2019-01-09  Tom Tromey  <tom@tromey.com>
10284
10285         * source.c (select_source_symtab)
10286         (forget_cached_source_info_for_objfile): Remove declaration.
10287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10288         declaration.
10289         * maint.c (count_symtabs_and_blocks): Remove declaration.
10290         * cp-support.c (add_symbol_overload_list_qualified): Remove
10291         declaration.
10292         * coffread.c (coff_symtab_read): Remove declaration.
10293         * symtab.c (lookup_symbol_in_objfile_symtabs)
10294         (basic_lookup_transparent_type_1): Use objfile_compunits.
10295         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10296         (info_sources_command, search_symbols)
10297         (default_collect_symbol_completion_matches_break_on)
10298         (make_source_files_completion_list): Remove declaration.
10299         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10300         (ada_collect_symbol_completion_matches)
10301         (ada_add_global_exceptions): Remove declaration.
10302         * linespec.c (iterate_over_all_matching_symtabs): Use
10303         objfile_compunits.
10304         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10305         (class objfile_compunits): New.
10306         (ALL_COMPUNITS): Use objfile_compunits.
10307         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10308         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10309         objfile_compunits.
10310         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10311
10312 2019-01-09  Tom Tromey  <tom@tromey.com>
10313
10314         * symtab.c (search_symbols)
10315         (default_collect_symbol_completion_matches_break_on): Use
10316         objfile_msymbols.
10317         * ada-lang.c (ada_lookup_simple_minsym)
10318         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10319         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10320         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10321         objfile_msymbols.
10322         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10323         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10324         * objc-lang.c (find_methods): Use objfile_msymbols.
10325         (info_selectors_command, info_classes_command): Likewise.
10326         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10327         * objfiles.h (class objfile_msymbols): New.
10328         (ALL_OBJFILE_MSYMBOLS): Remove.
10329         (ALL_MSYMBOLS): Remove.
10330
10331 2019-01-09  Tom Tromey  <tom@tromey.com>
10332
10333         * common/next-iterator.h (next_adapter): Add Iterator template
10334         parameter.
10335         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10336         (class all_objfiles_safe): New.
10337         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10338         * objfiles.c (put_objfile_before): Update comment.
10339         (add_separate_debug_objfile): Likewise.
10340         (free_all_objfiles): Use all_objfiles_safe.
10341         (objfile_purge_solibs): Likewise.
10342
10343 2019-01-09  Tom Tromey  <tom@tromey.com>
10344
10345         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10346         (expand_symtab_containing_pc, lookup_static_symbol)
10347         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10348         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10349         all_objfiles.
10350         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10351         * breakpoint.c (create_overlay_event_breakpoint)
10352         (create_longjmp_master_breakpoint)
10353         (create_std_terminate_master_breakpoint)
10354         (create_exception_master_breakpoint): Use all_objfiles.
10355         * linux-thread-db.c (try_thread_db_load_from_pdir)
10356         (has_libpthread): Use all_objfiles.
10357         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10358         * linespec.c (iterate_over_all_matching_symtabs)
10359         (search_minsyms_for_name): Use all_objfiles.
10360         * maint.c (maintenance_info_sections): Use all_objfiles.
10361         * main.c (captured_main_1): Use all_objfiles.
10362         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10363         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10364         * guile/scm-pretty-print.c
10365         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10366         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10367         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10368         (maintenance_print_msymbols): Use all_objfiles.
10369         * source.c (select_source_symtab): Use all_objfiles.
10370         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10371         * symfile.c (remove_symbol_file_command)
10372         (expand_symtabs_matching, map_symbol_filenames): Use
10373         all_objfiles.
10374         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10375         all_objfiles.
10376         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10377         * objc-lang.c (find_methods): Use all_objfiles.
10378         * objfiles.c (have_partial_symbols, have_full_symbols)
10379         (have_minimal_symbols, qsort_cmp)
10380         (default_iterate_over_objfiles_in_search_order): Use
10381         all_objfiles.
10382         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10383         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10384         (maintenance_check_psymtabs): Use all_objfiles.
10385         (ALL_PSYMTABS): Remove.
10386         * compile/compile-object-run.c (do_module_cleanup): Use
10387         all_objfiles.
10388         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10389         * cp-support.c (add_symbol_overload_list_qualified): Use
10390         all_objfiles.
10391         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10392         Use all_objfiles.
10393         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10394         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10395         all_objfiles.
10396         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10397         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10398         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10399         Uses all_objfiles.
10400         * solib.c (solib_read_symbols): Use all_objfiles
10401
10402 2019-01-09  Tom Tromey  <tom@tromey.com>
10403
10404         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10405         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10406         all_objfiles.
10407         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10408         * symmisc.c (print_symbol_bcache_statistics)
10409         (print_objfile_statistics, maintenance_print_objfiles)
10410         (maintenance_info_symtabs, maintenance_check_symtabs)
10411         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10412         all_objfiles.
10413         * source.c (forget_cached_source_info): Use all_objfiles.
10414         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10415         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10416         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10417         * objfiles.c (update_section_map): Use all_objfiles.
10418         (shared_objfile_contains_address_p): Likewise.
10419         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10420         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10421
10422 2019-01-09  Tom Tromey  <tom@tromey.com>
10423
10424         * common/next-iterator.h: New file.
10425         * objfiles.h (class all_objfiles): New.
10426         (struct objfile_iterator): New.
10427
10428 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10429
10430         * NEWS: Move the description of the changed "frame", "select-frame",
10431          and "info frame" commands to the Changed commands section.
10432
10433 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10434
10435         * gdbtypes.c (check_stub_method_group): Remove handling of old
10436         mangling schemes.
10437         * linespec.c (find_methods): Likewise.
10438         * stabsread.c (read_member_functions): Likewise.
10439         * valops.c (search_struct_method): Likewise.
10440         (value_struct_elt_for_reference): Likewise.
10441         * NEWS: Mention this change.
10442
10443 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10444
10445         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10446         print_source_lines.
10447         * source.c (print_source_lines_base): Update line number check.
10448         (print_source_lines): New function.
10449         (source_lines_range::source_lines_range): New function.
10450         * source.h (class source_lines_range): New class.
10451         (print_source_lines): New declaration.
10452
10453 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10454
10455         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10456
10457 2019-01-08  Tom Tromey  <tom@tromey.com>
10458             Simon Marchi  <simon.marchi@ericsson.com>
10459
10460         PR gdb/24060
10461         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10462         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10463         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10464         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10465         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10466         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10467
10468 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10469
10470         * source.c (select_source_symtab): Move header comment to
10471         declaration in source.h.
10472         (forget_cached_source_info_for_objfile): Likewise.
10473         (forget_cached_source_info): Likewise.
10474         (identify_source_line): Likewise.
10475         * source.h (identify_source_line): Move declaration from symtab.h
10476         and add comment from source.c
10477         (print_source_lines): Likewise.
10478         (forget_cached_source_info_for_objfile): Likewise.
10479         (forget_cached_source_info): Likewise.
10480         (select_source_symtab): Likewise.
10481         (enum print_source_lines_flag): Move definition from symtab.h.
10482         * symtab.h (identify_source_line): Move declaration to source.h.
10483         (print_source_lines): Likewise.
10484         (forget_cached_source_info_for_objfile): Likewise.
10485         (forget_cached_source_info): Likewise.
10486         (select_source_symtab): Likewise.
10487         (enum print_source_lines_flag): Move definition to source.h.
10488         * tui/tui-hooks.c: Add 'source.h' include.
10489
10490 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10491
10492         * source.c (print_source_lines_base): Handle requests to print
10493         reverse line number sequences, and guard against empty lines
10494         string.
10495
10496 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10497
10498         * source.c (print_source_lines_base): Fix skip of '\r' if next
10499         character is '\n'.
10500
10501 2019-01-06  Tom Tromey  <tom@tromey.com>
10502
10503         * c-exp.y (struct c_parse_state) <macro_original_text,
10504         expansion_obstack>: New member.
10505         (macro_original_text, expansion_obstack): Remove globals.
10506         (scan_macro_expansion, scanning_macro_expansion)
10507         (finished_macro_expansion): Update.
10508         (scan_macro_cleanup): Remove.
10509         (yylex, c_parse): Update.
10510
10511 2019-01-06  Tom Tromey  <tom@tromey.com>
10512
10513         * c-exp.y (struct c_parse_state) <strings>: New member.
10514         (operator_stoken): Update.
10515
10516 2019-01-06  Tom Tromey  <tom@tromey.com>
10517
10518         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10519         (union type_stack_elt) <typelist_val>: Now a pointer to
10520         std::vector.
10521         (type_stack_cleanup): Don't declare.
10522         (push_typelist): Update.
10523         * parse.c (pop_typelist): Return a std::vector.
10524         (push_typelist): Take a std::vector.
10525         (follow_types): Update.  Do not free args.
10526         (type_stack_cleanup): Remove.
10527         * c-exp.y (struct c_parse_state): New.
10528         (cpstate): New global.
10529         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10530         (nonempty_typelist): Update.
10531         (func_mod): Create a new vector.
10532         (c_parse): Create a c_parse_state.
10533         (check_parameter_typelist): Do not delete params.
10534         (function_method): Update.  Do not delete type_list.
10535
10536 2019-01-06  Tom Tromey  <tom@tromey.com>
10537
10538         PR gdb/28155:
10539         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10540         check_typedef.
10541         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10542         (print_return_value): Likewise.
10543
10544 2019-01-05  Tom Tromey  <tom@tromey.com>
10545
10546         * contrib/cleanup_check.py: Remove.
10547         * contrib/gcc-with-excheck: Remove.
10548         * contrib/exsummary.py: Remove.
10549         * contrib/excheck.py: Remove.
10550
10551 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10552
10553         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10554         NULL. Initialize tpprev to NULL instead of assigning it
10555         to NULL on the next statement.
10556         * windows-nat.c (windows_delete_thread): Remove check for
10557         main_thread_id before printing thread exit notifications.
10558         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10559         Remove thread ID check against main_thread_id.
10560         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10561         windows_delete_thread.
10562         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10563
10564 2019-01-04  Tom Tromey  <tom@tromey.com>
10565
10566         * compile/compile.c (_initialize_compile): Use upper case for
10567         metasyntactic variables.
10568         * symmisc.c (_initialize_symmisc): Use upper case for
10569         metasyntactic variables.
10570         * psymtab.c (_initialize_psymtab): Use upper case for
10571         metasyntactic variables.
10572         * demangle.c (demangle_command): Use upper case for metasyntactic
10573         variables.
10574         (_initialize_demangler): Likewise.
10575         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10576         variables.
10577
10578 2019-01-03  Tom Tromey  <tom@tromey.com>
10579
10580         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10581
10582 2019-01-03  Tom Tromey  <tom@tromey.com>
10583
10584         * python/py-symtab.c (salpy_str): Update.
10585         (struct salpy_sal_object) <symtab>: Now a PyObject.
10586         (salpy_dealloc): Update.
10587         (del_objfile_sal): Use gdbpy_ref.
10588
10589 2019-01-03  Tom Tromey  <tom@tromey.com>
10590
10591         * python/py-type.c (convert_field): Use new_reference.  Return
10592         gdbpy_ref.
10593         (make_fielditem): Return gdbpy_ref.
10594         (typy_fields): Update.
10595         (typy_getitem): Update.
10596         (field_name): Return gdbpy_ref.  Use new_reference.
10597         (typy_iterator_iternext): Update.
10598
10599 2019-01-03  Tom Tromey  <tom@tromey.com>
10600
10601         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10602
10603 2019-01-03  Tom Tromey  <tom@tromey.com>
10604
10605         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10606         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10607         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10608         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10609         (pspy_set_type_printers): Likewise.
10610         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10611         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10612         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10613         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10614         (objfpy_set_type_printers): Likewise.
10615
10616 2019-01-03  Tom Tromey  <tom@tromey.com>
10617
10618         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10619         (gdbpy_print_stack): Use gdbpy_err_fetch.
10620         * python/python-internal.h (class gdbpy_err_fetch): New class.
10621         (class gdbpy_enter) <m_error_type, m_error_value,
10622         m_error_traceback>: Remove.
10623         <m_error>: New member.
10624         (gdbpy_exception_to_string): Don't declare.
10625         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10626         * python/py-value.c (convert_value_from_python): Use
10627         gdbpy_err_fetch.
10628         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10629         gdbpy_exception_to_string.
10630         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10631         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10632         gdbpy_err_fetch.
10633
10634 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10635
10636         * linux-nat.c (delete_lwp_cleanup): Delete.
10637         (struct lwp_deleter): New struct.
10638         (lwp_info_up): New typedef.
10639         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10640         lwp_info_up.
10641
10642 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10643
10644         * linux-fork.c (class scoped_switch_fork_info): New class.
10645         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10646
10647 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10648
10649         * valops.c (find_overload_match): Remove use of null_cleanup, and
10650         calls to do_cleanups.
10651
10652 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10653
10654         * compile/compile-cplus-types.c
10655         (compile_cplus_instance::decl_name): Handle changes to
10656         cp_func_name.
10657         * cp-support.c (cp_func_name): Update header comment, update
10658         return type.
10659         * cp-support.h (cp_func_name): Update return type in declaration.
10660         * valops.c (find_overload_match): Move temp_func local to top
10661         level of function and change its type.  Use temp_func to hold and
10662         delete temporary string obtained from cp_func_name.
10663
10664 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10665
10666         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10667         gdb::char_vector, remove cleanup, and update uses of `msg`.
10668
10669 2019-01-03  Jim Wilson  <jimw@sifive.com>
10670
10671         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10672
10673 2019-01-02  Tom Tromey  <tom@tromey.com>
10674
10675         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10676         (tdesc_parse_xml): Remove cleanups.
10677         * target-descriptions.h (make_cleanup_free_target_description):
10678         Don't declare.
10679         (target_desc_deleter): New struct.
10680         (target_desc_up): New typedef.
10681         * target-descriptions.c (target_desc_deleter::operator()): Rename
10682         from free_target_description.
10683         (make_cleanup_free_target_description): Remove.
10684
10685 2019-01-02  Tom Tromey  <tom@tromey.com>
10686
10687         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10688         constructor, destructor.
10689         (linespec_parser): Remove typedef.
10690         (~linespec_parser): Rename from linespec_parser_delete.
10691         (linespec_lex_to_end, linespec_complete_label)
10692         (linespec_complete): Update.
10693         (decode_line_full): Remove cleanups.
10694         (decode_line_1): Update.
10695
10696 2019-01-02  Tom Tromey  <tom@tromey.com>
10697
10698         * python/python-internal.h (inferior_to_inferior_object): Change
10699         return type.
10700         * python/py-exitedevent.c (create_exited_event_object): Update.
10701         * python/py-inferior.c (inferior_to_inferior_object): Return
10702         gdbpy_ref.
10703         (python_new_inferior, python_inferior_deleted)
10704         (thread_to_thread_object, delete_thread_object)
10705         (build_inferior_list, gdbpy_selected_inferior): Update.
10706         * python/py-infthread.c (create_thread_object): Update.  Also fail
10707         if inferior_to_inferior_object fails.
10708
10709 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10710
10711         * inferior.h (class inferior) <displaced_step_state>: New field.
10712         * infrun.h (struct displaced_step_state): Move here from
10713         infrun.c.  Initialize fields, add constructor.
10714         <inf>: Remove field.
10715         <reset>: New method.
10716         * infrun.c (struct displaced_step_inferior_state): Move to
10717         infrun.h.
10718         (displaced_step_inferior_states): Remove.
10719         (get_displaced_stepping_state): Adust.
10720         (displaced_step_in_progress_any_inferior): Adjust.
10721         (displaced_step_in_progress_thread): Adjust.
10722         (displaced_step_in_progress): Adjust.
10723         (add_displaced_stepping_state): Remove.
10724         (get_displaced_step_closure_by_addr): Adjust.
10725         (remove_displaced_stepping_state): Remove.
10726         (infrun_inferior_exit): Call displaced_step_state.reset.
10727         (use_displaced_stepping): Don't check for NULL.
10728         (displaced_step_prepare_throw): Call
10729         get_displaced_stepping_state.
10730         (displaced_step_fixup): Don't check for NULL.
10731         (prepare_for_detach): Don't check for NULL.
10732
10733 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10734
10735         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10736          in case of call that did not complete.
10737
10738 2019-01-02  Andrey Utkin  <autkin@undo.io>
10739
10740         * symfile.c (find_separate_debug_file): Fix search of debug files for
10741         remote debuggee.
10742
10743 2019-01-02  Tom Tromey  <tom@tromey.com>
10744
10745         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10746         indentation.
10747         * python/py-frame.c (frapy_older): Remove cast.
10748         (frapy_newer): Likewise.
10749         * python/py-breakpoint.c (local_setattro): Remove cast.
10750         * python/py-arch.c (archpy_name): Remove local variable.
10751         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10752
10753 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10754
10755         * unittests/basic_string_view/element_access/char/empty.cc:
10756         Fix year range in copyright header.
10757
10758 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10761         Delete.
10762         <operator==>: Update with for removed field.
10763         <hash>: Likewise.
10764         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10765         <isa_features>: ...this.
10766         <abi_features>: New field.
10767         (riscv_isa_flen): Update comment.
10768         (riscv_abi_xlen): New declaration.
10769         (riscv_abi_flen): New declaration.
10770         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10771         isa_features.
10772         (riscv_abi_xlen): New function.
10773         (riscv_isa_flen): Update to get answer from isa_features.
10774         (riscv_abi_flen): New function.
10775         (riscv_has_fp_abi): Update to get answer from abi_features.
10776         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10777         xlen and flen.
10778         (riscv_call_info) <xlen, flen>: Update comment.
10779         (riscv_call_arg_struct): Remove invalid assertions
10780         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10781         is removed.
10782         (riscv_gdbarch_init): Gather isa features and abi features
10783         separately, ensure both match on the gdbarch when reusing an old
10784         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10785         a target with 64-bit float hardware.
10786
10787 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10788
10789         * source.c (search_command_helper): Stop reverse search
10790         when line 1 has been searched.
10791
10792 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10793
10794         * record-full.c (record_full_base_target::close): Rewrite
10795         record_full_core_buf_list free logic.
10796
10797 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10798
10799         * break-catch-syscall.c (print_one_catch_syscall): xfree
10800         the last text.
10801
10802 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10803
10804         * top.c (print_gdb_version): Update Copyright year in version
10805         message.
10806
10807 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10808
10809         Update copyright year range in all GDB files.
10810
10811 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10812
10813         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10814
10815 For older changes see ChangeLog-2018.
10816 \f
10817 Local Variables:
10818 mode: change-log
10819 left-margin: 8
10820 fill-column: 74
10821 version-control: never
10822 coding: utf-8
10823 End:
10824