gdb/ChangeLog

   1 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * s12z-tdep.c: Fix include path for s12z-opc.h.
   4
   5 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * NEWS: Require GNU make 3.82.
   8
   9 2019-07-16  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  12         declare.
  13
  14 2019-07-30  Tom Tromey  <tromey@adacore.com>
  15
  16         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  17
  18 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  19
  20         * printcmd.c (print_address_symbolic): Print negative offsets.
  21         (build_address_symbolic): Force signed arithmetic when computing
  22         offset.
  23
  24 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  25
  26         PR/24474: Add a function to lookup static variables.
  27         * NEWS: Mention this new function.
  28         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  29         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  30         * python/python.c (python_GdbMethods): Add new function.
  31
  32 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  35         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  36         (objfpy_lookup_static_symbol): New function.
  37         (objfile_object_methods): Add new functions.
  38
  39 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  40
  41         * NEWS: Mention 'set|show print frame-info'.  Mention new
  42         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  43         backtrace argument.  Mention that python frame filtering code
  44         is now consistent with what 'backtrace' command prints.
  45
  46 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  47
  48         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  49         comments.
  50         (print_frame_info_auto, print_frame_info_source_line,
  51         print_frame_info_location, print_frame_info_source_and_location,
  52         print_frame_info_location_and_address, print_frame_info_short_location):
  53         New declarations.
  54         (struct frame_print_options): New member print_frame_info.
  55         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  56         * stack.h (get_user_print_what_frame_info): New declaration.
  57         (frame_show_address): New declaration.
  58         * stack.c (print_frame_arguments_choices): New value 'presence'.
  59         (print_frame_info_auto, print_frame_info_source_line,
  60         print_frame_info_location, print_frame_info_source_and_location,
  61         print_frame_info_location_and_address, print_frame_info_short_location,
  62         print_frame_info_choices, print_frame_info_print_what): New definitions.
  63         (print_frame_args): Only print dots for args if print frame-arguments
  64         is 'presence'.
  65         (frame_print_option_defs): New element for "frame-info".
  66         (get_user_print_what_frame_info): New function.
  67         (frame_show_address): Make non static.  Move comment to stack.h.
  68         (print_frame_info_to_print_what): New function.
  69         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  70         to decide what to print.
  71         (backtrace_command_1): Handle the new print_frame_arguments_presence
  72         value.
  73         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  74         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  75         (py_print_frame): In non-mi mode, use LOCATION as default for
  76         print_what, similarly to frame information printed directly by
  77         backtrace command. Handle frame-info user option in non MI mode.
  78
  79 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  80
  81         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  82         Add case for debugging 32-bit target on 64-bit host.  Revise
  83         comment.
  84
  85 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  86
  87         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  88         instead of find_function_entry_range_from_pc.
  89
  90 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  91
  92         * stack.c (find_frame_funname): Remove code which preferred
  93         minsym over symtab sym in "certain pathological cases".
  94
  95         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  96         parameter.  Change type of "do_demangle" to bool.
  97         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  98         Pass suitable "prefer_sym_over_minsym" flag to
  99         build_address_symbolic().  Don't output "+" for negative offsets.
 100         * printcmd.c (print_address_symbolic): Update invocation of
 101         build_address_symbolic to include a "prefer_sym_over_minsym"
 102         flag.
 103         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 104         Restrict cases in which use of minimal symbol is preferred to that
 105         of a found symbol.  Update comments.
 106
 107         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 108         for entry pc when entry pc is out of range for that FDE.
 109
 110 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 111
 112         PR gdb/24839:
 113         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 114         type.
 115
 116 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 117
 118         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 119         this function's Python signature.
 120
 121
 122 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 125         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 126         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 127         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 128         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 129
 130
 131 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 132
 133         * h8300-tdep.c (h8300_register_name_common): New.
 134         h8300_register_name): Use h8300_register_name_common.
 135         (h8300s_register_name): Likewise.
 136         (h8300sx_register_name): Likewise.
 137         (h8300h_register_nam): New.
 138         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 139
 140
 141 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 142
 143         * arm-tdep.c (arm_skip_cmse_entry): New function.
 144         (arm_is_sgstubs_section): New function.
 145         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 146
 147 2019-07-22  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 150         Don't self-assign.
 151
 152 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 153
 154         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 155         type_print.
 156
 157 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 160         so that GDB doesn't match any msymbols when searching in the
 161         TYPES_DOMAIN.
 162         (print_symbol_info): Print using typedef_print or type_print based
 163         on the type of the symbol.  Add updated FIXME comment moved from...
 164         (_initialize_symtab): ... move and update FIXME comment to above.
 165
 166 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         * NEWS: Mention adding -q option to "info types".
 169         * symtab.c (struct info_types_options): New struct.
 170         (info_types_options_defs): New variable.
 171         (make_info_types_options_def_group): New function.
 172         (info_types_command): Use gdb::option framework to parse options.
 173         (info_types_command_completer): New function.
 174         (_initialize_symtab): Extend the help text on "info types" and
 175         register command completer.
 176
 177 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 178
 179         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 180         (lookup_symbol_in_objfile): Change int to block_enum and add a
 181         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 182
 183 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 184
 185         * MAINTAINERS (Write After Approval): Add self.
 186
 187 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 188
 189         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 190         instruction to the dummy code region.
 191
 192 2019-07-19  Tom Tromey  <tromey@adacore.com>
 193
 194         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 195         (ARGSUSED, PARAMS, __func__): Remove rules.
 196
 197 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 198
 199         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 200         * features/arm/arm-with-iwmmxt.c: Remove.
 201         * features/arm/arm-with-iwmmxt.xml: Remove.
 202         * features/arm/arm-with-m-fpa-layout.c: Remove.
 203         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 204         * features/arm/arm-with-m-vfp-d16.c: Remove.
 205         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 206         * features/arm/arm-with-m.c: Remove.
 207         * features/arm/arm-with-m.xml: Remove.
 208         * features/arm/arm-with-neon.c: Remove.
 209         * features/arm/arm-with-neon.xml: Remove.
 210         * features/arm/arm-with-vfpv2.c: Remove.
 211         * features/arm/arm-with-vfpv2.xml: Remove.
 212         * features/arm/arm-with-vfpv3.c: Remove.
 213         * features/arm/arm-with-vfpv3.xml: Remove.
 214
 215 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 216
 217         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 218
 219 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 220
 221         * arch/aarch32.c (aarch32_create_target_description): Create
 222         target descriptions using features.
 223         * arch/arm.c (arm_create_target_description)
 224         (arm_create_mprofile_target_description): Likewise.
 225         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 226
 227 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 228
 229         * Makefile.in: Add new files.
 230         * aarch32-tdep.c: New file.
 231         * aarch32-tdep.h: New file.
 232         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 233         Call aarch32_read_description.
 234         * arch/aarch32.c: New file.
 235         * arch/aarch32.h: New file.
 236         * arch/arm.c (arm_create_target_description)
 237         (arm_create_mprofile_target_description): New function.
 238         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 239         (arm_create_target_description)
 240         (arm_create_mprofile_target_description): New declaration.
 241         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 242         read_description functions.
 243         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 244         Likewise.
 245         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 246         * arm-tdep.c (tdesc_arm_list): New variable.
 247         (arm_register_g_packet_guesses): Call create description functions.
 248         (arm_read_description) (arm_read_mprofile_description): New
 249         function.
 250         * arm-tdep.h (arm_read_description)
 251         (arm_read_mprofile_description): Add declaration.
 252         * configure.tgt: Add new files.
 253
 254 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 255
 256         * top.c (new_ui_command): Open specified terminal just once.
 257
 258 2019-07-18  Tom Tromey  <tromey@adacore.com>
 259
 260         * symtab.c (main_name): Constify return type.
 261         * symfile.c (set_initial_language): Update.
 262         * symtab.h (main_name): Constify return type.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-winsource.c (tui_update_source_window)
 267         (tui_update_source_window_as_is)
 268         (tui_update_source_windows_with_line): Remove return.
 269         * tui/tui-disasm.c (tui_show_disassem)
 270         (tui_show_disassem_and_update_source): Remove return.
 271         * tui/tui.c (tui_reset): Remove return.
 272         * tui/tui-wingeneral.c
 273         (tui_check_and_display_highlight_if_needed): Remove return.
 274
 275 2019-07-17  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 278
 279 2019-07-17  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-winsource.h (struct tui_exec_info_window)
 282         (struct tui_source_window_base): Move from tui-data.h.
 283         * tui/tui-winsource.c: Move many method definitions from
 284         elsewhere.  Remove "structuring" comments.
 285         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 286         (tui_source_window_base::refresh_window): Move to
 287         tui-winsource.c.
 288         * tui/tui-win.c (tui_source_window_base::refresh_all)
 289         (tui_source_window_base::update_tab_width)
 290         (tui_source_window_base::set_new_height)
 291         (tui_source_window_base::do_make_visible_with_new_height): Move to
 292         tui-winsource.c.
 293         * tui/tui-source.h: Update.
 294         * tui/tui-source.c (tui_source_window_base::reset): Move to
 295         tui-winsource.c.
 296         * tui/tui-disasm.h: Update.
 297         * tui/tui-data.h (struct tui_exec_info_window): Move to
 298         tui-winsource.h.
 299         (struct tui_source_window_base): Likewise.
 300         * tui/tui-data.c (tui_source_window_base::clear_detail)
 301         (tui_source_window_base, ~tui_source_window_base): Move to
 302         tui-winsource.c.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-win.c (tui_resize_all)
 307         (tui_source_window_base::update_tab_width)
 308         (tui_adjust_win_heights): Update.
 309         (tui_win_info::make_invisible_and_set_new_height): Rename from
 310         make_invisible_and_set_new_height.
 311         * tui/tui-data.h (struct tui_win_info)
 312         <make_invisible_and_set_new_height>: New method.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui.c: Update.
 317         * tui/tui-source.h (struct tui_source_window): Move from
 318         tui-data.h.
 319         * tui/tui-layout.c: Update.
 320         * tui/tui-disasm.c: Update.
 321         * tui/tui-data.h (struct tui_source_window): Move to
 322         tui-source.h.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 327         tui-data.h.
 328         * tui/tui-data.h (struct tui_disasm_window): Move to
 329         tui-disasm.h.
 330
 331 2019-07-17  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-regs.h (struct tui_data_item_window): Move from
 334         tui-data.h.
 335         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 336         * tui/tui-data.h (struct tui_data_item_window): Move to
 337         tui-regs.h.
 338         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui.c: Update.
 343         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 344         (tui_cmd_window::max_height): Move to tui-command.c.
 345         * tui/tui-layout.c: Update.
 346         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 347         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 348         tui-command.c.
 349         * tui/tui-command.h (struct tui_cmd_window): Move from
 350         tui-data.h.
 351         * tui/tui-command.c: Remove "structuring" comments.
 352         (tui_cmd_window::clear_detail)
 353         (tui_cmd_window::do_make_visible_with_new_height)
 354         (tui_cmd_window::max_height): Move from elsewhere.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 359         Now static.
 360         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 361         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui.c: Update.
 366         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 367         tui-regs.c.
 368         * tui/tui-windata.h: Remove file.
 369         * tui/tui-windata.c: Remove file.
 370         * tui/tui-win.c (tui_data_window::set_new_height)
 371         (tui_data_window::do_make_visible_with_new_height): Move to
 372         tui-regs.c.
 373         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 374         * tui/tui-regs.c: Remove "structuring" comments.
 375         (tui_data_window::first_data_item_displayed)
 376         (tui_data_window::delete_data_content_windows)
 377         (tui_data_window::erase_data_content)
 378         (tui_data_window::display_all_data)
 379         (tui_data_window::refresh_all)
 380         (tui_data_window::do_scroll_vertical)
 381         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 382         (tui_data_window::do_make_visible_with_new_height)
 383         (tui_data_window::refresh_window): Move from elsewhere.
 384         (_initialize_tui_regs): Move to end of file.
 385         * tui/tui-layout.c: Update.
 386         * tui/tui-hooks.c: Update.
 387         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 388         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 389         tui-regs.c.
 390         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 391
 392 2019-07-17  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 395         seen.
 396
 397 2019-07-17  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-win.c (tui_source_window_base::set_new_height)
 400         (tui_source_window_base::do_make_visible_with_new_height): Use
 401         m_has_locator field directly.
 402         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 403         method.
 404         (struct tui_source_window_base) <has_locator>: Likewise.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 409         Don't declare.
 410         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 411         Remove.
 412         * tui/tui-win.c (tui_source_window_base::set_new_height)
 413         (tui_source_window_base::set_new_height)
 414         (make_invisible_and_set_new_height)
 415         (tui_source_window_base::do_make_visible_with_new_height)
 416         (tui_source_window_base::do_make_visible_with_new_height):
 417         Update.
 418         * tui/tui-layout.c (show_source_disasm_command, show_data)
 419         (show_source_or_disasm_and_command): Update.
 420         * tui/tui-layout.c (show_layout): Update.
 421
 422 2019-07-17  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-layout.c (make_data_window): Remove.
 425         (show_data): Unify creation and re-initialization cases.
 426
 427 2019-07-17  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.c (make_source_window, make_disasm_window):
 430         Remove.
 431         (show_data): Unify creation and re-initialization cases.
 432
 433 2019-07-17  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-layout.c (make_command_window): Remove.
 436         (show_source_disasm_command, show_source_or_disasm_and_command):
 437         Unify creation and re-initialization cases.
 438
 439 2019-07-17  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 442         creation and re-initialization cases.
 443
 444 2019-07-17  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-regs.c (tui_get_register): Return void.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 451         Simplify.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 456         resetting.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 461         * tui/tui-regs.c (tui_reg_layout): New function.
 462         (tui_show_registers, tui_reg_command): Use it.
 463         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 464         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 465         parameters.
 466         (tui_layout_command): Remove.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-layout.h (tui/tui-layout): Return void.
 471         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-layout.c (show_source_disasm_command, show_data):
 476         Update.
 477         (reset_locator): Remove.
 478         (show_source_or_disasm_and_command): Update.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-source.c (tui_source_window_base::reset): Remove
 483         win_type parameter.
 484         * tui/tui-layout.c (make_command_window, make_source_window)
 485         (make_disasm_window, make_data_window)
 486         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 487         (reset_locator, show_source_or_disasm_and_command): Update.
 488         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 489         win_type parameter.
 490         (struct tui_source_window_base) <reset>: Likewise.
 491
 492 2019-07-17  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-layout.c (show_source_disasm_command): Use
 495         reset_locator.
 496         (reset_locator): New function.
 497         (init_and_make_win): Remove.
 498         (show_source_or_disasm_and_command): Use reset_locator.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 503         condition.
 504         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 505         Remove condition.
 506         * tui/tui-source.c (tui_source_window_base::reset): New method.
 507         * tui/tui-layout.c (make_command_window): Don't call
 508         init_and_make_win.
 509         (make_source_window, make_disasm_window): Don't call
 510         make_source_or_disasm_window.
 511         (make_data_window): Don't call init_and_make_win.  Change calling
 512         convention.
 513         (show_source_disasm_command, show_data): Simplify.
 514         (make_source_or_disasm_window): Remove.
 515         (show_source_or_disasm_and_command): Simplify.
 516         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 517         (struct tui_source_window_base) <reset>: Likewise.
 518         <execution_info>: Remove initializer.
 519         * tui/tui-data.c (tui_source_window_base): Initialize
 520         execution_info.
 521
 522 2019-07-17  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 525         variable.
 526
 527 2019-07-17  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui.c (tui_rl_other_window): Update.
 530         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 531         superclass method first.  Always iterate over regs_content.
 532         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 533         method.
 534         * tui/tui-win.c (tui_set_focus_command): Update.
 535
 536 2019-07-17  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-win.c (tui_set_focus_command): Rename from
 539         tui_set_focus.  Call tui_enable.
 540         (tui_set_focus_command): Remove.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 545         refresh_window.
 546         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 547         touchwin.
 548         (tui_data_window::refresh_window): Call refresh_window on data
 549         items.  Always call superclass refresh_window.
 550         (tui_win_info::refresh): Remove.
 551         (tui_source_window_base::refresh_window): Update.
 552         (tui_refresh_all): Update.
 553         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 554         refresh_window.
 555         (show_source_or_disasm_and_command): Likewise.
 556         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 557         (struct tui_source_window_base) <refresh>: Likewise.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.c (tui_clear_source_content)
 562         (tui_show_source_content): Update.
 563         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 564         whether content is empty.
 565         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 566         Remove.
 567
 568 2019-07-17  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 571         window's contents.
 572         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 573         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 578         (struct tui_data_item_window): Update.
 579
 580 2019-07-17  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 583         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 584         defines.
 585
 586 2019-07-17  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-winsource.h (tui_erase_source_content)
 589         (tui_clear_source_content): Remove "display_prompt" parameter.
 590         * tui/tui-winsource.c (tui_update_source_window_as_is)
 591         (tui_update_source_windows_with_addr): Update.
 592         (tui_clear_source_content): Remove "display_prompt" parameter.
 593         (tui_erase_source_content): Likewise.  Simplify.
 594         (tui_show_source_content): Update.
 595         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 596         * tui/tui-stack.c (tui_show_frame_info): Update.
 597         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 598         Remove defines.
 599
 600 2019-07-17  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 603         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 604         parameter.
 605         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 606         parameter.
 607
 608 2019-07-17  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-winsource.c (tui_clear_source_content)
 611         (tui_show_source_content, tui_show_exec_info_content)
 612         (tui_clear_exec_info_content): Update.
 613         * tui/tui-stack.c (tui_show_locator_content): Update.
 614         (tui_show_frame_info): Update.
 615         * tui/tui-source.h (tui_source_window): Don't declare.
 616         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 617         from tui_source_is_displayed.
 618         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 619         Remove field.
 620         (struct tui_source_window_base) <content_in_use>: New field.  Now
 621         bool.
 622         (struct tui_source_window) <showing_source_p>: New method.
 623         (TUI_SRC_WIN): Change cast.
 624         * tui/tui-data.c (tui_initialize_static_data): Update.
 625
 626 2019-07-17  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 629         location_matches_p.
 630         * tui/tui-source.c (tui_source_window::location_matches_p): New
 631         method.
 632         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 633         method.
 634         * tui/tui-data.h (struct tui_source_window_base)
 635         <location_matches_p>: New method.
 636         (struct tui_source_window, struct tui_disasm_window)
 637         <location_matches_p>: Likewise.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-win.c (tui_set_win_height_command): Rename from
 642         tui_set_win_height.
 643         (tui_set_win_height_command): Remove.
 644
 645 2019-07-17  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-source.c (tui_source_window): New constructor.  Add
 648         observer.
 649         (~tui_source_window): New destructor.
 650         (tui_source_window::style_changed): New method.
 651         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 652         (tui_attach_detach_observers): Update.
 653         * tui/tui-data.h (struct tui_source_window): Make constructor not
 654         inline.  Add destructor.
 655         (struct tui_source_window) <style_changed>: New method.
 656         <m_observable>: New member.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 661         * tui/tui-win.c (tui_resize_all): Fix typo.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 666         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 667         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 668         * tui/tui-win.c (window_name_completer): Use foreach.
 669         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 670         (update_tab_width): Likewise.
 671         * tui/tui-layout.c (show_layout): Update.
 672         * tui/tui-data.h (class tui_window_iterator): New.
 673         (struct all_tui_windows): New.
 674         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 675
 676 2019-07-17  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 679         parameter.  Don't reference globals.
 680         (tui_reg_command): Update.
 681
 682 2019-07-17  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-regs.c (tui_show_registers): Simplify.
 685
 686 2019-07-17  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-regs.c (tui_show_registers): Update.
 689         (tui_show_register_group): Add win_info parameter.
 690
 691 2019-07-17  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 694         Rename from tui_display_reg_element_at_line.
 695         (tui_data_window::display_registers_from_line): Update.
 696         * tui/tui-data.h (struct tui_data_window)
 697         <display_reg_element_at_line>: New method.
 698
 699 2019-07-17  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-regs.h (tui_display_registers_from)
 702         (tui_display_registers_from_line): Don't declare.
 703         * tui/tui-windata.c (tui_data_window::display_all_data)
 704         (tui_data_window::refresh_all)
 705         (tui_data_window::do_scroll_vertical): Update.
 706         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 707         from tui_display_registers_from.
 708         (tui_display_reg_element_at_line): Update.
 709         (tui_data_window::display_registers_from_line): Rename from
 710         tui_display_registers_from_line.
 711         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 712         display_registers_from_line>: New methods.
 713
 714 2019-07-17  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 717         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 718         from tui_erase_data_content.
 719         (tui_data_window::display_all_data)
 720         (tui_data_window::refresh_all)
 721         (tui_data_window::do_scroll_vertical): Update.
 722         * tui/tui-regs.c (tui_show_registers): Update.
 723         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 724         New method.
 725
 726 2019-07-17  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 729         declare.
 730         * tui/tui-windata.c
 731         (tui_data_window::delete_data_content_windows): Rename from
 732         tui_delete_data_content_windows.
 733         (tui_data_window::display_all_data)
 734         (tui_data_window::do_scroll_vertical): Update.
 735         * tui/tui-data.h (struct tui_data_window)
 736         <delete_data_content_windows>: New method.
 737
 738 2019-07-17  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 741         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 742
 743 2019-07-17  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 746         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 747         from tui_display_all_data.
 748         * tui/tui-win.c
 749         (tui_data_window::do_make_visible_with_new_height): Update.
 750         * tui/tui-regs.c (tui_show_registers): Update.
 751         * tui/tui-layout.c (tui_set_layout): Update.
 752         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 753         method.
 754
 755 2019-07-17  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 758         * tui/tui-windata.c (tui_display_data_from): Remove.
 759         (tui_data_window::refresh_all): Update.
 760
 761 2019-07-17  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 764         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 765         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 766         tui_display_registers_from_line.
 767         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 768         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 769         "force_display" parameter.
 770
 771 2019-07-17  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 774         declare.
 775         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 776         Rename from tui_first_reg_element_no_inline.
 777         (tui_display_reg_element_at_line)
 778         (tui_display_registers_from_line): Update.
 779         * tui/tui-data.h (struct tui_data_window)
 780         <first_reg_element_no_inline>: New method.
 781
 782 2019-07-17  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-windata.c (tui_display_data_from)
 785         (tui_data_window::do_scroll_vertical): Update.
 786         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 787         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 788         Rename from tui_line_from_reg_element_no.
 789         (tui_display_registers_from_line): Update.
 790         * tui/tui-data.h (struct tui_data_window)
 791         <line_from_reg_element_no>: New method.
 792
 793 2019-07-17  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 796         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 797         tui_last_regs_line_no.
 798         (tui_display_reg_element_at_line)
 799         (tui_display_registers_from_line): Update.
 800         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 801         method.
 802
 803 2019-07-17  Tom Tromey  <tom@tromey.com>
 804
 805         PR tui/24722:
 806         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 807         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 808         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 809         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 810         (tui_update_breakpoint_info): Likewise.
 811         * tui/tui-hooks.c (tui_event_create_breakpoint)
 812         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 813         Update.
 814
 815 2019-07-17  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 818
 819 2019-07-17  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-winsource.c (tui_update_source_window_as_is)
 822         (tui_update_source_windows_with_addr): Update.
 823         * tui/tui-source.h (tui_set_source_content)
 824         (tui_show_symtab_source): Add "win_info" parameter.
 825         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 826         parameter.
 827         (tui_show_symtab_source): Likewise.
 828
 829 2019-07-17  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-wingeneral.c
 832         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 833
 834 2019-07-17  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 837         (struct tui_cmd_window) <can_scroll>: New method.
 838         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 839         method.
 840
 841 2019-07-17  Tom Tromey  <tromey@adacore.com>
 842
 843         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 844         do_field_signed>: Rename.  Change type of "value".
 845         * ui-out.c (ui_out::field_signed): Rename from field_int.
 846         Change type of "value".
 847         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 848         type of "value".
 849         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 850         do_field_int.  Change type of "value".
 851         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 852         do_field_int.  Change type of "value".
 853         * tracepoint.c (trace_status_mi, tfind_1)
 854         (print_one_static_tracepoint_marker): Update.
 855         * thread.c (print_thread_info_1, print_selected_thread_frame):
 856         Update.
 857         * stack.c (print_frame, print_frame_info): Update.
 858         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 859         Update.
 860         * source.c (print_source_lines_base): Update.
 861         * skip.c (info_skip_command): Update.
 862         * record-btrace.c (btrace_ui_out_decode_error)
 863         (btrace_call_history_src_line): Update.
 864         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 865         Update.
 866         * progspace.c (print_program_space): Update.
 867         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 868         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 869         do_field_int.  Change type of "value".
 870         * mi/mi-out.c (mi_ui_out::do_table_begin)
 871         (mi_ui_out::do_table_header): Update.
 872         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 873         type of "value".
 874         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 875         (mi_cmd_data_list_changed_registers, output_register)
 876         (mi_cmd_data_read_memory, mi_load_progress)
 877         (mi_cmd_trace_frame_collected): Update.
 878         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 879         Update.
 880         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 881         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 882         (mi_cmd_var_list_children, varobj_update_one): Update.
 883         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 884         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 886         * inferior.c (print_inferior): Update.
 887         * gdb_bfd.c (print_one_bfd): Update.
 888         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 889         Update.
 890         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 891         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 892         do_field_int.  Change type of "value".
 893         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 894         do_field_int.  Change type of "value".
 895         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 896         (print_one_breakpoint_location, print_it_catch_fork)
 897         (print_one_catch_fork, print_it_catch_vfork)
 898         (print_one_catch_vfork, print_it_catch_solib)
 899         (print_it_catch_exec, print_it_ranged_breakpoint)
 900         (print_mention_watchpoint, print_mention_masked_watchpoint)
 901         (bkpt_print_it, update_static_tracepoint): Update.
 902         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 903         * break-catch-syscall.c (print_it_catch_syscall): Update.
 904         * ada-tasks.c (print_ada_task_info): Update.
 905         * ada-lang.c (print_it_exception, print_mention_exception):
 906         Update.
 907
 908 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         PR breakpoints/24541
 911         * gdbarch.c: Regenerate.
 912         * gdbarch.h: Regenerate.
 913         * gdbarch.sh: Adjust return type and parameter types for
 914         'stap_adjust_register'.
 915         (i386_stap_adjust_register): Adjust signature and return new
 916         register name.
 917         * stap-probe.c (stap_parse_register_operand): Adjust use of
 918         'gdbarch_stap_adjust_register'.
 919
 920 2019-07-17  Tom Tromey  <tromey@adacore.com>
 921
 922         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 923         declare VEC.
 924         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 925         std::vector.
 926         (struct s390_process_info): Add initializers.
 927         (s390_add_process): Use new.
 928         (s390_linux_nat_target::low_forget_process): Use delete.
 929         (s390_linux_nat_target::low_new_fork)
 930         (s390_linux_nat_target::stopped_by_watchpoint)
 931         (s390_linux_nat_target::low_prepare_to_resume)
 932         (s390_linux_nat_target::insert_watchpoint)
 933         (s390_linux_nat_target::insert_hw_breakpoint)
 934         (s390_linux_nat_target::remove_watchpoint)
 935         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 936
 937 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 938
 939         * aarch64-fbsd-nat.c: Include regcache.h.
 940         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 941         argument.
 942         (aarch64_fbsd_nat_target::fetch_registers)
 943         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 944         variable.
 945         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 946
 947 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 948
 949         * fbsd-nat.c: Include gdbarch.h.
 950
 951 2019-07-15  Tom Tromey  <tromey@adacore.com>
 952
 953         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 954
 955 2019-07-15  Tom Tromey  <tromey@adacore.com>
 956
 957         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 958         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 959         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 960         * cli-out.c (cli_ui_out::do_field_int): New method.
 961         * ui-out.c (ui_out::field_unsigned): New method.
 962         * symfile.c (generic_load): Use field_unsigned.
 963         (print_transfer_performance): Likewise.
 964         * record-btrace.c (ui_out_field_uint): Remove.
 965         (btrace_call_history_insn_range, btrace_call_history): Use
 966         field_unsigned.
 967         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 968         field_unsigned.
 969         * ui-out.h (class ui_out) <field_unsigned>: New method.
 970         <do_field_unsigned>: Likewise.
 971
 972 2019-07-15  Tom Tromey  <tromey@adacore.com>
 973
 974         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 975         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 976         * target.c (flash_erase_command): Use field_string.
 977         * infrun.c (print_signal_received_reason): Use field_string.
 978         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 979         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 980         field_string.
 981         * ada-tasks.c (print_ada_task_info): Use field_string.
 982
 983 2019-07-15  Tom Tromey  <tromey@adacore.com>
 984
 985         * target.c (flash_erase_command): Use field_core_addr.
 986         * symfile.c (generic_load): Use field_core_addr.
 987         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 988         Use field_core_addr.
 989         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 990         field_core_addr.
 991
 992 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 995         value if its desired type is smaller than a CORE_ADDR and signed.
 996
 997 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1000         of changes to field names, and use new is_reference field to
1001         decide if a property is a reference or not.
1002         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1003         field.
1004         (struct dwarf2_property_baton): Update header comment, rename
1005         'referenced_type' to 'property_type' and update comments.
1006         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1007         default property type, store in property baton, update to take
1008         accound of renamed field.
1009         (read_func_scope): Update call to attr_to_dynamic_prop.
1010         (read_array_type): Likewise.
1011         (dwarf2_per_cu_addr_sized_int_type): New function.
1012         (read_subrange_index_type): Move type finding code to
1013         dwarf2_per_cu_addr_sized_int_type.
1014         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1015         (dwarf2_per_cu_addr_type): New function.
1016         (set_die_type): Update calls to attr_to_dynamic_prop.
1017
1018 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * dwarf2read.c (read_subrange_index_type): New function.
1021         (read_subrange_type): Move code into new function and call it.
1022         * gdbtypes.c (create_range_type): Add some asserts.
1023
1024 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1027         update return statements.
1028         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1029         declaration, and update comment to match.
1030         * gdbtypes.c (resolve_dynamic_array): Update call to
1031         dwarf2_evaluate_property to match new return type.
1032
1033 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * valarith.c (value_subscripted_rvalue): Change lowerbound
1036         parameter type from int to LONGEST.
1037         * value.h (value_subscripted_rvalue): Likewise in declaration.
1038
1039 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * cli/cli-utils.c (info_print_command_completer): New function.
1042         * cli/cli-utils.h: Add 'completer.h' include, and forward
1043         declaration for 'struct cmd_list_element'.
1044         (info_print_command_completer): Declare.
1045         * stack.c (_initialize_stack): Add completer for 'info locals' and
1046         'info args'.
1047         * symtab.c (_initialize_symtab): Add completer for 'info
1048         variables' and 'info functions'.
1049         * NEWS: Mention completion for additional info commands.
1050
1051 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * cli/cli-utils.c (extract_info_print_args): Delete.
1054         (extract_arg_maybe_quoted): Delete.
1055         (info_print_options_defs): New variable.
1056         (make_info_print_options_def_group): New function.
1057         (extract_info_print_options): Define new function.
1058         * cli/cli-utils.h (extract_info_print_args): Delete.
1059         (struct info_print_options): New structure.
1060         (extract_info_print_options): Declare new function.
1061         * stack.c (info_locals_command): Update to use new
1062         extract_info_print_options, also add a header comment.
1063         (info_args_command): Likewise.
1064         * symtab.c (info_variables_command): Likewise.
1065         (info_functions_command): Likewise.
1066
1067 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1070         to extract string arguments.
1071         * common/common-utils.c (extract_string_maybe_quoted): New function.
1072         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1073
1074 2019-07-11  Tom Tromey  <tromey@adacore.com>
1075
1076         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1077         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1078         * top.h (gdbinit): Don't declare.
1079         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1080         into...
1081         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1082         * top.c (gdb_init): Don't call init_cli_cmds.
1083         (gdbinit): Remove.
1084         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1085
1086 2019-07-11  Tom Tromey  <tromey@adacore.com>
1087
1088         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1089         after it has been moved.
1090
1091 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1092
1093         * valops.c (value_must_coerce_to_target): Change return type to
1094         bool.
1095         * value.h (value_must_coerce_to_target): Likewise.
1096
1097 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1098
1099         * breakpoint.c (is_hardware_watchpoint): Remove
1100         forward-declaration.
1101         (is_masked_watchpoint): Change return type to bool.
1102         (is_tracepoint): Likewise.
1103         (is_breakpoint): Likewise.
1104         (is_hardware_watchpoint): Likewise.
1105         (is_watchpoint): Likewise.
1106         (is_no_memory_software_watchpoint): Likewise.
1107         (is_catchpoint): Likewise.
1108         (breakpoint_1): Make FILTER parameter's return type bool.
1109         is_masked_watchpoint): Change return type to bool.
1110         (save_breakpoints): Make FILTER parameter's return type bool.
1111         * breakpoint.h (is_breakpoint): Change return type to bool.
1112         (is_watchpoint): Likewise.
1113         (is_catchpoint): Likewise.
1114         (is_tracepoint): Likewise.
1115
1116 2019-07-10  Tom Tromey  <tom@tromey.com>
1117
1118         * defs.h: Don't include gdbarch.h.
1119         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1120         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1121         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1122         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1123         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1124         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1125         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1126         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1127         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1128         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1129         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1130         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1131         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1132         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1133         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1134         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1135         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1136         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1137         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1138         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1139         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1140         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1141         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1142         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1143         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1144         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1145         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1146
1147 2019-07-10  Tom Tromey  <tromey@adacore.com>
1148
1149         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1150         * breakpoint.c (init_ada_exception_breakpoint): Register as
1151         bp_catchpoint.
1152         (print_one_breakpoint_location, print_one_breakpoint): Use
1153         is_ada_exception_catchpoint.
1154         * ada-lang.c (class ada_catchpoint_location): Pass
1155         bp_loc_software_breakpoint to bp_location constructor.
1156         (is_ada_exception_catchpoint): New function.
1157
1158 2019-07-10  Tom Tromey  <tromey@adacore.com>
1159
1160         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1161         VEC.
1162         (struct arm_exidx_entry): New method operator<.
1163         (struct arm_exidx_data) <section_maps>: Change type.
1164         (arm_exidx_data_free): Remove.
1165         (arm_exidx_data_key): Change type.  Move lower.
1166         (arm_exidx_new_objfile): Update.
1167         (arm_compare_exidx_entries): Remove.
1168         (arm_find_exidx_entry, _initialize_arm_tdep)
1169
1170 2019-07-10  Tom Tromey  <tromey@adacore.com>
1171
1172         * solib-spu.c (ocl_program_data_key): Change type.
1173         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1174         Update.
1175
1176 2019-07-10  Tom Tromey  <tromey@adacore.com>
1177
1178         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1179         (struct solib_aix_inferior_data) <library_list>: Change type.
1180         (solib_aix_inferior_data_handle): Change type.
1181         (get_solib_aix_inferior_data): Update.
1182         (solib_aix_free_library_list): Remove.
1183         (library_list_start_library): Update.
1184         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1185         return type.
1186         (solib_aix_get_library_list)
1187         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1188         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1189
1190 2019-07-10  Tom Tromey  <tromey@adacore.com>
1191
1192         * solib-dsbt.c (struct dsbt_info): Add initializers.
1193         (solib_dsbt_pspace_data): Change type.
1194         (dsbt_pspace_data_cleanup): Remove.
1195         (get_dsbt_info, _initialize_dsbt_solib): Update.
1196
1197 2019-07-10  Tom Tromey  <tromey@adacore.com>
1198
1199         * spu-tdep.c (spu_overlay_data): Change type.
1200         (spu_get_overlay_table, spu_overlay_new_objfile)
1201         (_initialize_spu_tdep): Update.
1202
1203 2019-07-10  Tom Tromey  <tromey@adacore.com>
1204
1205         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1206         destructor.
1207         (dbx_objfile_data_key): Change type and declare later.
1208         (DBX_SYMFILE_INFO): Rewrite.
1209         * dbxread.c (dbx_objfile_data_key): Change type.
1210         (dbx_symfile_init): Update.
1211         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1212         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1213         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1214
1215 2019-07-10  Tom Tromey  <tromey@adacore.com>
1216
1217         * jit.c (jit_program_space_key): Change type.  Move lower.
1218         (get_jit_program_space_data): Update.
1219         (jit_program_space_data_cleanup): Remove.
1220         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1221         Update.
1222         (struct jit_program_space_data): Add initializers.
1223
1224 2019-07-10  Tom Tromey  <tromey@adacore.com>
1225
1226         * solib-darwin.c (struct darwin_info): Add initializers.
1227         (solib_darwin_pspace_data): Change type.
1228         (darwin_pspace_data_cleanup): Remove.
1229         (get_darwin_info, _initialize_darwin_solib): Update.
1230
1231 2019-07-10  Tom Tromey  <tromey@adacore.com>
1232
1233         * remote-sim.c (struct sim_inferior_data): Add initializers,
1234         constructor, and destructor.
1235         (sim_inferior_data_key): Change type.  Move lower.
1236         (check_for_duplicate_sim_descriptor): Update.
1237         (get_sim_inferior_data): Use new.  Update.
1238         (~sim_inferior_data_cleanup): Rename from
1239         sim_inferior_data_cleanup.  Simplify.
1240         (gdbsim_close_inferior, simulator_command)
1241         (sim_command_completer, _initialize_remote_sim): Update.
1242         (next_pid, INITIAL_PID): Move earlier.
1243
1244 2019-07-10  Tom Tromey  <tromey@adacore.com>
1245
1246         * python/python-internal.h (create_thread_object): Return
1247         gdbpy_ref.
1248         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1249         * python/py-inferior.c (struct threadlist_entry): Add
1250         constructor.
1251         <thread_obj>: Now a gdbpy_ref.
1252         (thread_to_thread_object): Update.
1253         (add_thread_object): Use new.
1254         (delete_thread_object): Use delete.
1255         (infpy_threads): Update.
1256         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1257         GIL.
1258
1259 2019-07-10  Tom Tromey  <tromey@adacore.com>
1260
1261         * valops.c (value_cast): Specialize error message for Ada.
1262
1263 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1264
1265         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1266
1267 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1268
1269         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1270         bpstat_should_step): Return bool, adjust comments.
1271         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1272         bpstat_should_step): Likewise.
1273
1274 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1275
1276         * features/Makefile: Use feature target descriptions for Arm.
1277         * features/arm/arm-core.c: Generate new file.
1278         * features/arm/arm-fpa.c: Likewise.
1279         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1280         * features/arm/arm-m-profile.c: Likewise.
1281         * features/arm/arm-vfpv2.c: Likewise.
1282         * features/arm/arm-vfpv3.c: Likewise.
1283         * features/arm/xscale-iwmmxt.c: Likewise.
1284         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1285
1286 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1287
1288         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1289         ptrace earlier.
1290
1291 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1292
1293         * features/aarch64-pauth.c: Regenerate.
1294
1295 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1296
1297         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1298         bool.
1299         (bpstat_what): Use false instead of 0.
1300
1301 2019-07-09  Pedro Alves  <palves@redhat.com>
1302
1303         * break-catch-throw.c (is_exception_catchpoint): New.
1304         * breakpoint.c (print_one_breakpoint_location): New parameter
1305         'raw_loc'.  Handle it.  Use
1306         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1307         looking at the breakpoint's type.
1308         (print_one_breakpoint): If handling "maint info breakpoints", also
1309         print locations of exception catchpoints.
1310         * breakpoint.h (is_exception_catchpoint): Declare.
1311
1312 2019-07-09  Pedro Alves  <palves@redhat.com>
1313
1314         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1315         "addr" field.
1316         (allocate_location_exception_catchpoint): New.
1317         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1318         (initialize_throw_catchpoint_ops): Install
1319         allocate_location_exception_catchpoint as allocate_location
1320         method.
1321         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1322         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1323         bp_loc_other.
1324         (breakpoint_address_is_meaningful): Delete.
1325         (bl_address_is_meaningful): New.
1326         (breakpoint_locations_match): Adjust comment.
1327         (bp_location_from_bp_type): New, factored out of...
1328         (bp_location::bp_location(breakpoint *)): ... this.
1329         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1330         factored out of...
1331         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1332         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1333         breakpoint_address_is_meaningful.
1334         (bp_locations_compare): Adjust comment.
1335         (update_global_location_list): Use bl_address_is_meaningful
1336         instead of breakpoint_address_is_meaningful.
1337         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1338         explicit.
1339         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1340         * python/py-breakpoint.c (bppy_get_location): No longer check
1341         whether location is null.
1342
1343 2019-07-09  Pedro Alves  <palves@redhat.com>
1344
1345         PR c++/15468
1346         * breakpoint.c (print_one_breakpoint_location): Remove
1347         single-location assert.
1348
1349 2019-07-09  Tom Tromey  <tom@tromey.com>
1350
1351         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1352         * configure: Rebuild.
1353         * configure.ac: Change common to gdbsupport.
1354         * gdbsupport: Rename from common.
1355         * acinclude.m4: Change common to gdbsupport.
1356         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1357         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1358         gdbsupport.
1359         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1360         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1361         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1362         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1363         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1364         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1365         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1366         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1367         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1368         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1369         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1370         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1371         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1372         coff-pe-read.c, command.h, compile/compile-c-support.c,
1373         compile/compile-c.h, compile/compile-cplus-symbols.c,
1374         compile/compile-cplus-types.c, compile/compile-cplus.h,
1375         compile/compile-loc2c.c, compile/compile.c, completer.c,
1376         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1377         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1378         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1379         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1380         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1381         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1382         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1383         features/aarch64-core.c, features/aarch64-fpu.c,
1384         features/aarch64-pauth.c, features/aarch64-sve.c,
1385         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1386         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1387         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1388         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1389         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1390         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1391         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1392         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1393         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1394         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1395         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1396         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1397         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1398         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1399         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1400         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1401         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1402         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1403         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1404         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1405         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1406         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1407         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1408         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1409         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1410         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1411         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1412         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1413         minsyms.c, mips-linux-tdep.c, namespace.h,
1414         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1415         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1416         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1417         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1418         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1419         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1420         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1421         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1422         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1423         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1424         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1425         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1426         procfs.c, producer.c, progspace.h, psymtab.h,
1427         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1428         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1429         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1430         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1431         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1432         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1433         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1434         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1435         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1436         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1437         target-memory.c, target.c, target.h, target/waitstatus.c,
1438         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1439         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1440         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1441         unittests/array-view-selftests.c,
1442         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1443         unittests/common-utils-selftests.c,
1444         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1445         unittests/format_pieces-selftests.c,
1446         unittests/function-view-selftests.c,
1447         unittests/lookup_name_info-selftests.c,
1448         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1449         unittests/mkdir-recursive-selftests.c,
1450         unittests/observable-selftests.c,
1451         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1452         unittests/parse-connection-spec-selftests.c,
1453         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1454         unittests/scoped_fd-selftests.c,
1455         unittests/scoped_mmap-selftests.c,
1456         unittests/scoped_restore-selftests.c,
1457         unittests/string_view-selftests.c, unittests/style-selftests.c,
1458         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1459         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1460         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1461         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1462         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1463         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1464
1465 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1468         bool value.
1469         (decode_digits_ordinary): Set explicit_line field in sal.
1470         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1471         symtab_and_line that was set on an explicit line number in
1472         assembler code.  Do always update the recorded symtab and line if
1473         we do skip the prologue.
1474
1475 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * breakpoint.c (set_breakpoint_location_function): Remove
1478         explicit_loc parameter.
1479         (momentary_breakpoint_from_master): Update call to
1480         set_breakpoint_location_function.
1481         (add_location_to_breakpoint): Likewise.
1482
1483 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1484
1485         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1486         required features based on default bfd type when no specific bfd
1487         is present.
1488
1489 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1490
1491         * NEWS: Mention that GDB printf and eval commands can now print
1492         C-style and Ada-style convenience var strings without
1493         calling the inferior.
1494         * printcmd.c (printf_c_string): Locally print GDB internal var
1495         instead of transiting via the inferior.
1496         (printf_wide_c_string): Likewise.
1497
1498 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1499
1500         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1501
1502 2019-07-04  Tom Tromey  <tom@tromey.com>
1503
1504         PR tui/24724:
1505         * tui/tui-winsource.c (tui_clear_source_content): Update.
1506         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1507         (tui_update_breakpoint_info): Update.
1508         (tui_set_exec_info_content): Update.
1509         * tui/tui-source.c (tui_set_source_content_nil): Update.
1510         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1511         has_break.
1512         * tui/tui-data.h (enum tui_bp_flag): New.
1513         (tui_bp_flags): New enum flags type.
1514         (struct tui_source_element) <break_mode>: Change type.  Rename
1515         from has_break.
1516         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1517         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1518         constants.
1519         * tui/tui-winsource.h: Fix comment.
1520
1521 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1522
1523         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1524         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1525         (store_fpregs_to_thread)
1526         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1527         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1528         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1529         (IWMMXT_REGS_SIZE): Add define.
1530         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1531         (fetch_vfp_regs, store_vfp_regs)
1532         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1533         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1534
1535 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1536
1537         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1538         defines.
1539         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1540         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1541         (ARM_INT_REGISTER_SIZE): ...to this.
1542         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1543         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1544         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1545         (arm_linux_collect_gregset, supply_nwfpe_register)
1546         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1547         defines.
1548         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1549         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1550         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1551         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1552         (arm_return_in_memory, arm_store_return_value)
1553         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1554         (arm_record_ld_st_multiple): Likewise.
1555         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1556         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1557
1558 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1559
1560         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1561         AARCH64_DISPLACED_MODIFIED_INSNS.
1562         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1563         (aarch64_displaced_step_copy_insn): Likewise.
1564         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1565         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1566         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1567         ARM_DISPLACED_MODIFIED_INSNS.
1568         * arm-tdep.c (arm_gdbarch_init): Likewise.
1569         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1570         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1571         (struct arm_displaced_step_closure): Use
1572         ARM_DISPLACED_MODIFIED_INSNS.
1573
1574 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1575
1576         * features/Makefile: Remove unused xml files.
1577         * features/aarch64.xml: Remove.
1578         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1579         * features/i386/amd64-avx-avx512.xml: Remove.
1580         * features/i386/amd64-avx-linux.xml: Remove.
1581         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1582         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1583         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1584         * features/i386/amd64-avx-mpx.xml: Remove.
1585         * features/i386/amd64-avx.xml: Remove.
1586         * features/i386/amd64-linux.xml: Remove.
1587         * features/i386/amd64-mpx-linux.xml: Remove.
1588         * features/i386/amd64-mpx.xml: Remove.
1589         * features/i386/amd64.xml: Remove.
1590         * features/i386/i386-avx-avx512-linux.xml: Remove.
1591         * features/i386/i386-avx-avx512.xml: Remove.
1592         * features/i386/i386-avx-linux.xml: Remove.
1593         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1594         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1595         * features/i386/i386-avx-mpx-linux.xml: Remove.
1596         * features/i386/i386-avx-mpx.xml: Remove.
1597         * features/i386/i386-avx.xml: Remove.
1598         * features/i386/i386-linux.xml: Remove.
1599         * features/i386/i386-mmx-linux.xml: Remove.
1600         * features/i386/i386-mmx.xml: Remove.
1601         * features/i386/i386-mpx-linux.xml: Remove.
1602         * features/i386/i386-mpx.xml: Remove.
1603         * features/i386/i386.xml: Remove.
1604         * features/i386/x32-avx-avx512-linux.xml: Remove.
1605         * features/i386/x32-avx-linux.xml: Remove.
1606         * features/i386/x32-linux.xml: Remove.
1607
1608 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1609
1610         * regformats/aarch64.dat: Remove.
1611         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1612         * regformats/i386/amd64-avx-linux.dat: Remove.
1613         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1614         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1615         * regformats/i386/amd64-linux.dat: Remove.
1616         * regformats/i386/amd64-mpx-linux.dat: Remove.
1617         * regformats/i386/amd64.dat: Remove.
1618         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1619         * regformats/i386/i386-avx-linux.dat: Remove.
1620         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1621         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1622         * regformats/i386/i386-linux.dat: Remove.
1623         * regformats/i386/i386-mmx-linux.dat: Remove.
1624         * regformats/i386/i386-mpx-linux.dat: Remove.
1625         * regformats/i386/i386.dat: Remove.
1626         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1627         * regformats/i386/x32-avx-linux.dat: Remove.
1628         * regformats/i386/x32-linux.dat: Remove.
1629
1630 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1631
1632         * aarch64-tdep.c: Remove xml self tests.
1633         * amd64-linux-tdep.c: Likewise.
1634         * amd64-tdep.c: Likewise.
1635         * i386-linux-tdep.c: Likewise.
1636         * i386-tdep.c: Likewise.
1637
1638 2019-07-03  Pedro Alves  <palves@redhat.com>
1639
1640         PR cli/24732
1641         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1642         (pipe_cmd_option_defs): New.
1643         (make_pipe_cmd_options_def_group): New.
1644         (pipe_command): Use gdb::option::process_options.
1645         (pipe_command_completer): New function.
1646         (_initialize_cli_cmds): Install completer for "pipe" command.
1647
1648 2019-07-03  Pedro Alves  <palves@redhat.com>
1649
1650         * cli/cli-option.c (union option_value) <string>: New field.
1651         (struct option_def_and_value): Add ctor, move ctor, dtor and
1652         use DISABLE_COPY_AND_ASSIGN.
1653         (option_def_and_value::clear_value): New.
1654         (parse_option, save_option_value_in_ctx, get_val_type_str)
1655         (add_setshow_cmds_for_options): Handle var_string.
1656         * cli-option.h (union option_def::var_address) <string>: New
1657         field.
1658         (struct string_option_def): New.
1659         * maint-test-options.c (struct test_options_opts): Add default
1660         ctor and use DISABLE_COPY_AND_ASSIGN.
1661         <string_opt>: New field.
1662         (test_options_opts::~test_options_opts): New.
1663         (test_options_opts::dump): Also dump "-string".
1664         (test_options_option_defs): Install "string.
1665
1666 2019-07-03  Pedro Alves  <palves@redhat.com>
1667
1668         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1669         option_value with a null enumeration.
1670         (complete_options): Save the option values in the context.
1671         (save_option_value_in_ctx): New, factored out from ...
1672         (process_options): ... here.
1673         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1674         of the function.
1675         * maint-test-options.c (test_options_opts::dump): New, factored
1676         out from ...
1677         (maintenance_test_options_command_mode): ... here.
1678         (maintenance_test_options_command_completion_result): Delete.
1679         (maintenance_test_options_command_completion_text): Update
1680         comment.
1681         (maintenance_show_test_options_completion_result): Change
1682         prototype.  Just print
1683         maintenance_test_options_command_completion_text.
1684         (save_completion_result): New.
1685         (maintenance_test_options_completer_mode): Pass options context to
1686         complete_options, and then save a dump.
1687         (_initialize_maint_test_options): Use add_cmd to install "maint
1688         show test-options-completion-result".
1689
1690 2019-07-03  Pedro Alves  <palves@redhat.com>
1691
1692         * NEWS (New commands): Mention "with" and "maint with".
1693         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1694         (with_command, with_command_completer): New.
1695         (pipe_command): Adjust to new repeat_previous
1696         interface.
1697         (_initialize_cli_cmds): Install the "with" command and its "w"
1698         alias.
1699         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1700         declarations.
1701         * cli/cli-setshow.c (parse_cli_var_uinteger)
1702         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1703         argument strings for all var_types.
1704         (get_setshow_command_value_string): New, factored out from ...
1705         (do_show_command): ... this.
1706         * cli/cli-setshow.h: Include <string>.
1707         (get_setshow_command_value_string): Declare.
1708         * command.h (repeat_previous): Now returns const char *.  Adjust
1709         comment.
1710         * maint.c: Include "cli/cli-cmds.h".
1711         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1712         (_initialize_maint_cmds): Register the "maintenance with" command.
1713         * top.c (repeat_previous): Move bits from pipe_command here:
1714         Return the saved command line, if any; error out if there's no
1715         command to relaunch.
1716
1717 2019-07-03  Pedro Alves  <palves@redhat.com>
1718
1719         * NEWS (New commands): Mention "maint set/show test-settings"
1720         instead of "maint test-settings".
1721         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1722         (maintenance_test_settings_set_list): Rename to ...
1723         (maintenance_set_test_settings_list): ... this.
1724         (maintenance_test_settings_show_list): Rename to  ...
1725         (maintenance_show_test_settings_list): ... this.
1726         (maintenance_test_settings_cmd): Delete.
1727         (maintenance_test_settings_set_cmd): ...
1728         (maintenance_set_test_settings_cmd): ... this.
1729         (maintenance_test_settings_show_cmd): ...
1730         (maintenance_show_test_settings_cmd): ... this.
1731         (maintenance_test_settings_show_value_cmd):
1732         (maintenance_show_test_settings_value_cmd): ... this.
1733         (_initialize_maint_test_settings): No longer install the "maint
1734         test-settings" prefix command.  Rename "maint test-settings set"
1735         to "maint set test-settings", and "maint test-settings show" to
1736         "maint show test-settings".  Adjust all subcommands.
1737
1738 2019-07-03  Pedro Alves  <palves@redhat.com>
1739
1740         * maint-test-settings.c: Fix file's intro comment.  Replace all
1741         references to "test-options" with references to "test-settings",
1742         in comments.
1743
1744 2019-07-03  Pedro Alves  <palves@redhat.com>
1745
1746         * maint-test-settings.c (maintenance_test_settings_xxx)
1747         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1748         New.
1749         (maintenance_test_settings_enums): Use them.
1750         (maintenance_test_settings_enum): Default to
1751         maintenance_test_settings_xxx.
1752         (_initialize_maint_test_settings): Initialize
1753         MAINTENANCE_TEST_SETTINGS_FILENAME.
1754
1755 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1756
1757         * breakpoint.h (remove_breakpoints_inf): Change return type to
1758         void, move function documentation here.
1759         * breakpoint.c (remove_breakpoints_inf): Change return type to
1760         void, move function documentation to header.
1761
1762 2019-07-02  Pedro Alves  <palves@redhat.com>
1763
1764         * NEWS (Completion improvements): Mention "info threads".
1765         * thread.c (struct info_threads_opts, info_threads_option_defs)
1766         (make_info_threads_options_def_group): New.
1767         (info_threads_command): Use gdb::option::process_options.
1768         (info_threads_command_completer): New.
1769         (_initialize_thread): Use gdb::option::build_help to build the
1770         help text for "info threads".
1771
1772 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1773
1774         * defs.h (generic_load): Move from here...
1775         * symfile.h (generic_load): ... to here.  Rename name parameter
1776         to args.
1777         * symfile.c (generic_load): Add comment.
1778
1779 2019-07-01  Tom Tromey  <tromey@adacore.com>
1780
1781         * dwarf2read.c
1782         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1783         declaration of without_params.  Fix formatting.
1784
1785 2019-07-01  Tom Tromey  <tromey@adacore.com>
1786
1787         * ada-exp.y (find_primitive_type): Update.
1788         * ada-lang.h (ada_lookup_symbol): Update.
1789         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1790         parameter.
1791         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1792
1793 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1794
1795         PR breakpoints/24541
1796         * gdbarch.c: Regenerate.
1797         * gdbarch.h: Regenerate.
1798         * gdbarch.sh: Add 'stap_adjust_register'.
1799         * i386-tdep.c: Include '<unordered_set>'.
1800         (i386_stap_adjust_register): New function.
1801         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1802         * stap-probe.c (stap_parse_register_operand): Call
1803         'gdbarch_stap_adjust_register'.
1804
1805 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1806
1807         PR python/24742
1808         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1809         * python/python.c (do_start_initialization): Use 'xmalloc'
1810         instead of 'PyMem_Malloc'.
1811
1812 2019-06-28  Tom Tromey  <tromey@adacore.com>
1813
1814         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1815         for Ada.
1816
1817 2019-06-27  Tom Tromey  <tromey@adacore.com>
1818
1819         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1820         objfile_key.
1821         (arm_find_mapping_symbol, arm_record_special_symbol)
1822         (_initialize_arm_tdep): Update.
1823         (arm_objfile_data_free): Remove.
1824
1825 2019-06-27  Tom Tromey  <tromey@adacore.com>
1826
1827         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1828         to cp_print_static_field.
1829
1830 2019-06-26  Tom Tromey  <tromey@adacore.com>
1831
1832         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1833         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1834         declare.
1835
1836 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1837
1838         * features/aarch64-core.c (create_feature_aarch64_core):
1839         Regenerate.
1840         * features/aarch64-core.xml: Add cpsr flags.
1841
1842 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1843
1844         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1845         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1846
1847 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1848
1849         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1850         field.
1851         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1852         use.
1853         (arm_record_special_symbol): Don't insert new symbol in sorted
1854         position, push it at the end.
1855
1856 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1857
1858         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1859         (arm_mapping_symbol_s): Remove.
1860         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1861         (arm_mapping_symbol_vec): New typedef.
1862         (struct arm_per_objfile): Add constructor.
1863         <section_maps>: Change type to
1864         std::unique_ptr<arm_mapping_symbol_vec[]>.
1865         (arm_compare_mapping_symbols): Remove.
1866         (arm_find_mapping_symbol): Adjust to section_maps type change.
1867         (arm_objfile_data_free): Call delete on arm_per_objfile.
1868         (arm_record_special_symbol): Adjust to section_maps type change.
1869         Allocate arm_per_objfile with new.
1870
1871 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1872
1873         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1874         with the command prefix.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1879         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1884         type.
1885         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1886         protected.
1887
1888 2019-06-25  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-winsource.c
1891         (tui_source_window_base::set_is_exec_point_at): Add check against
1892         LOA_ADDRESS.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-source.c (tui_set_source_content): Don't check before
1897         xfree.
1898         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1899
1900 2019-06-25  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui-winsource.h (tui_update_source_window_as_is)
1903         (tui_alloc_source_buffer, tui_line_is_displayed)
1904         (tui_addr_is_displayed): Change type of win_info.
1905         * tui/tui-winsource.c (tui_update_source_window_as_is)
1906         (tui_clear_source_content, tui_show_source_line)
1907         (tui_show_source_content, tui_source_window_base::refill)
1908         (tui_source_window_base::set_is_exec_point_at)
1909         (tui_source_window_base::set_is_exec_point_at)
1910         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1911         (tui_alloc_source_buffer, tui_line_is_displayed)
1912         (tui_addr_is_displayed): Change type of win_info.  Update.
1913         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1914         (tui_source_window_base::do_make_visible_with_new_height):
1915         Update.
1916         * tui/tui-source.c (tui_set_source_content)
1917         (tui_set_source_content_nil)
1918         (tui_source_window::do_scroll_vertical): Update.
1919         * tui/tui-layout.c (show_layout): Update.
1920         * tui/tui-disasm.c (tui_set_disassem_content)
1921         (tui_disasm_window::do_scroll_vertical): Update.
1922         * tui/tui-data.h (tui_win_content): Remove.
1923         (struct tui_gen_win_info) <content, content_size>: Remove.
1924         (struct tui_source_element): Add initializers and destructor.
1925         (union tui_which_element, struct tui_win_element): Remove.
1926         (struct tui_source_window_base) <content>: New field.
1927         (struct tui_data_window): Remove destructor.
1928         (tui_alloc_content, tui_free_win_content)
1929         (tui_free_all_source_wins_content): Don't declare.
1930         * tui/tui-data.c (tui_initialize_static_data): Update.
1931         (init_content_element, tui_alloc_content): Remove.
1932         (~tui_gen_win_info): Update.
1933         (~tui_data_window, tui_free_all_source_wins_content)
1934         (tui_free_win_content, free_content, free_content_elements):
1935         Remove.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-winsource.h (tui_clear_source_content)
1940         (tui_erase_source_content, tui_show_source_content): Change type
1941         of win_info.
1942         * tui/tui-winsource.c (tui_clear_source_content)
1943         (tui_erase_source_content, tui_show_source_content): Change type
1944         of win_info.
1945         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1946         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1947         win_info.
1948         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1949         win_info.
1950         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1951
1952 2019-06-25  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-winsource.c (tui_clear_source_content)
1955         (tui_source_window_base::set_is_exec_point_at): Update.
1956         * tui/tui-source.c (tui_set_source_content_nil): Update.
1957         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1958         a bool.
1959         * tui/tui-data.c (init_content_element): Update.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1964         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1965         * tui/tui-layout.c (init_and_make_win): Update.
1966         * tui/tui.h (enum tui_win_type): Update.
1967         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1968         tui_win_is_auxillary.
1969         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1970         tui_win_is_auxillary.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1975         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1976         (tui_delete_data_content_windows, tui_display_all_data)
1977         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1978         Update.
1979         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1980         * tui/tui-regs.c (tui_last_regs_line_no)
1981         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1982         (tui_show_registers): Update.
1983         (tui_show_register_group): Return void.  Update.
1984         (tui_display_registers_from, tui_display_reg_element_at_line)
1985         (tui_display_registers_from_line, tui_check_register_values):
1986         Update.
1987         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1988         member.
1989         (struct tui_data_window) <regs_content>: Now a std::vector.
1990         <regs_content_count>: Remove.
1991         (tui_add_content_elements, tui_free_data_content): Don't declare.
1992         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1993         (init_content_element): Remove DATA_WIN case.  Add assert.
1994         (tui_add_content_elements): Remove.
1995         (tui_data_window): Update.
1996         (tui_free_data_content): Remove.
1997         (free_content_elements): Remove DATA_WIN case.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-data.c (tui_data_item_window): Update.
2002         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2003         * tui/tui-windata.c (tui_display_all_data)
2004         (tui_display_data_from_line): Update.
2005         (tui_check_data_values): Remove.
2006         * tui/tui-regs.c (tui_show_register_group)
2007         (tui_display_reg_element_at_line): Update.
2008         * tui/tui-hooks.c (tui_register_changed)
2009         (tui_refresh_frame_and_register_information): Call
2010         tui_check_register_values.
2011         * tui/tui-data.h (struct tui_data_window) <data_content,
2012         data_content_count, data_type>: Remove.
2013         (enum tui_data_type): Remove.
2014
2015         * tui/tui-data.c (tui_data_window::clear_detail)
2016         (~tui_data_window): Update.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2021         declare.
2022         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2023         Rename from tui_first_data_item_displayed.  Update.
2024         (tui_data_window::refresh_all)
2025         (tui_data_window::do_scroll_vertical): Update.
2026         * tui/tui-data.h (struct tui_data_window)
2027         <first_data_item_displayed>: Declare new method.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2032         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2033         contents...
2034         (tui_initialize_static_data): ...here.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2039         (tui_display_registers_from, tui_check_register_values): Update.
2040         (tui_display_register): Remove win_info parameter; update.
2041         (tui_get_register): Change type of parameters.
2042         * tui/tui-data.h (struct tui_data_element): Remove.
2043         (union tui_which_element) <data>: Remove.
2044         <data_window>: Change type.
2045         (struct tui_data_item_window): New.
2046         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2047         case.  Add assert.
2048         (~tui_data_item_window): New destructor.
2049         (free_content_elements): Remove DATA_ITEM_WIN case.
2050
2051 2019-06-25  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2054         Remove.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-data.h (struct tui_command_element): Remove.
2059         (union tui_which_element) <command>: Remove.
2060         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2061         assert.
2062         (free_content_elements): Remove CMD_WIN case.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-layout.c (tui_set_layout): Update.
2067         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2068         * tui/tui-data.c (layout_def): Update.
2069
2070 2019-06-25  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2073         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2074         (tui_source_window_base::set_new_height): Update.
2075         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2076         Update.
2077         (tui_set_locator_fullname, tui_set_locator_info)
2078         (tui_show_frame_info): Update.
2079         * tui/tui-source.c (tui_set_source_content)
2080         (tui_source_is_displayed): Update.
2081         * tui/tui-layout.c (show_source_disasm_command, show_data)
2082         (show_source_or_disasm_and_command): Update.
2083         * tui/tui-disasm.c (tui_set_disassem_content)
2084         (tui_get_begin_asm_address): Update.
2085         * tui/tui-data.h (struct tui_locator_element): Remove.
2086         (union tui_which_element) <locator>: Remove.
2087         (struct tui_locator_window): New.
2088         (tui_locator_win_info_ptr): Change return type.
2089         * tui/tui-data.c (_locator): Change type.
2090         (tui_locator_win_info_ptr): Change return type.
2091         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2092         (tui_alloc_content): Add assert.
2093
2094 2019-06-25  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-winsource.c
2097         (tui_exec_info_window::maybe_allocate_content): New method.
2098         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2099         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2100         (make_source_or_disasm_window): Add cast.
2101         * tui/tui-data.h (union tui_which_element) <simple_string>:
2102         Remove.
2103         (struct tui_source_info): New.
2104         (struct tui_source_window_base) <execution_info>: Change type.
2105         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2106         case, and add assert.
2107         (tui_alloc_content): Add assert.
2108
2109 2019-06-25  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2112         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2113         * tui/tui-data.c (tui_alloc_win_info): Remove.
2114
2115 2019-06-25  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2118         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2119         can_highlight.
2120
2121 2019-06-25  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2124         make_visible_with_new_height method.
2125         (tui_win_info::make_visible_with_new_height): New method.
2126         (tui_source_window_base::do_make_visible_with_new_height)
2127         (tui_data_window::do_make_visible_with_new_height)
2128         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2129         (make_visible_with_new_height): Remove.
2130         (tui_resize_all, tui_adjust_win_heights): Use
2131         make_visible_with_new_height method.
2132         * tui/tui-data.h (struct tui_win_info)
2133         <do_make_visible_with_new_height, make_visible_with_new_height>:
2134         New methods.
2135         (struct tui_source_window_base, struct tui_data_window)
2136         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2137         methods.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2142         method.
2143         (update_tab_width): Call update_tab_width method.
2144         * tui/tui-data.h (struct tui_win_info)
2145         (struct tui_source_window_base) <update_tab_width>: New methods.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2150         parameter.
2151         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2152         parameter.
2153         (tui_gen_win_info::make_visible): Update.
2154         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2155         parameter.
2156         * tui/tui-data.h (enum tui_box): New enum.
2157         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2158
2159 2019-06-25  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2162         init_and_make_win for EXEC_INFO_WIN.
2163         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2164         longer inline.
2165         (struct tui_win_info) <~tui_win_info>: Inline.
2166         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2167         Don't declare.
2168         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2169         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2170         Remove.
2171         (tui_initialize_static_data): Update.
2172         (~tui_gen_win_info): Handle more cleanup here.
2173         (~tui_source_window_base): Delete "execution_info".
2174         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2175
2176 2019-06-25  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-layout.c (make_command_window): Don't set
2179         can_highlight.
2180         (show_source_disasm_command): Call the reset method.
2181         (show_data): Don't set can_highlight.  Call the reset method.
2182         (tui_gen_win_info::reset): Rename from init_gen_win_info
2183         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2184         (show_source_or_disasm_and_command): Call the reset method.
2185         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2186         (struct tui_cmd_window): Set can_highlight.
2187
2188 2019-06-25  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2191         from make_visible.
2192         (tui_make_visible, tui_make_invisible): Rewrite.
2193         (tui_win_info::make_visible): Remove.
2194         (tui_source_window_base::make_visible): Update.
2195         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2196         method.  Moved from...
2197         (struct tui_win_info) <make_visible>: ...here.
2198
2199 2019-06-25  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-winsource.c
2202         (tui_source_window_base::do_scroll_horizontal): Remove direction
2203         parameter.
2204         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2205         direction parameter.
2206         * tui/tui-win.c (tui_win_info::forward_scroll)
2207         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2208         (tui_win_info::right_scroll): Update.
2209         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2210         direction parameter.
2211         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2212         direction parameter.
2213         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2214         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2215         Remove direction parameter.
2216         (struct tui_source_window_base, struct tui_source_window)
2217         (struct tui_disasm_window, struct tui_data_window)
2218         (struct tui_cmd_window): Update.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-winsource.h (tui_set_exec_info_content)
2223         (tui_show_exec_info_content, tui_erase_exec_info_content)
2224         (tui_clear_exec_info_content, tui_update_exec_info): Change
2225         argument to tui_source_window_base.
2226         * tui/tui-winsource.c (tui_set_exec_info_content)
2227         (tui_show_exec_info_content, tui_erase_exec_info_content)
2228         (tui_clear_exec_info_content, tui_update_exec_info): Change
2229         argument to tui_source_window_base.
2230
2231 2019-06-25  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2234         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2239         check.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2244         type to void.
2245         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2246         type to void.
2247         * tui/tui-source.c (tui_set_source_content): Update.
2248         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-win.c (window_name_completer, tui_set_focus)
2253         (tui_all_windows_info): Use name method.
2254         * tui/tui-data.h (struct tui_gen_win_info)
2255         (struct tui_source_window, struct tui_disasm_window)
2256         (struct tui_data_window, struct tui_cmd_window) <name>: New
2257         method.
2258         (tui_win_name): Don't declare.
2259         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2260         (tui_win_name): Remove.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.h (tui_update_source_window)
2265         (tui_update_source_window_as_is): Change parameter type.
2266         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2267         to be a tui_source_window_base.
2268         (tui_update_source_window_as_is): Likewise.
2269         * tui/tui-win.c (make_visible_with_new_height): Update.
2270
2271 2019-06-25  Tom Tromey  <tom@tromey.com>
2272
2273         * tui/tui-winsource.c (tui_erase_source_content)
2274         (tui_show_source_content, tui_show_exec_info_content)
2275         (tui_erase_exec_info_content): Use refresh_window method.
2276         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2277         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2278         from tui_refresh_win.
2279         (tui_data_window::refresh_window): New method.
2280         (tui_win_info::refresh, tui_source_window_base::refresh)
2281         (tui_refresh_all): Use refresh_window method.
2282         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2283         method.
2284         * tui/tui-regs.c (tui_display_register): Call refresh_window
2285         method.
2286         * tui/tui-layout.c (show_source_disasm_command)
2287         (show_source_or_disasm_and_command): Call refresh_window method.
2288         * tui/tui-data.h (struct tui_gen_win_info)
2289         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2290         New method.
2291
2292 2019-06-25  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui.c (tui_rl_other_window, tui_enable)
2295         (tui_is_window_visible, tui_get_command_dimension): Update.
2296         * tui/tui-winsource.c (tui_update_source_window_as_is)
2297         (tui_clear_source_content, tui_erase_source_content)
2298         (tui_show_source_line, tui_source_window_base::refill)
2299         (tui_source_window_base::do_scroll_horizontal)
2300         (tui_source_window_base::set_is_exec_point_at)
2301         (tui_update_breakpoint_info, tui_set_exec_info_content)
2302         (tui_alloc_source_buffer, tui_line_is_displayed)
2303         (tui_addr_is_displayed): Update.
2304         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2305         (tui_check_and_display_highlight_if_needed)
2306         (tui_win_info::make_visible, tui_win_info::refresh)
2307         (tui_refresh_all): Update.
2308         * tui/tui-windata.c (tui_first_data_item_displayed)
2309         (tui_delete_data_content_windows, tui_erase_data_content)
2310         (tui_display_all_data, tui_data_window::refresh_all)
2311         (tui_check_data_values): Update.
2312         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2313         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2314         (tui_win_info::backward_scroll, tui_refresh_all_win)
2315         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2316         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2317         (tui_source_window_base::set_new_height)
2318         (tui_data_window::set_new_height)
2319         (make_invisible_and_set_new_height)
2320         (make_visible_with_new_height, new_height_ok)
2321         (parse_scrolling_args): Update.
2322         * tui/tui-stack.c (tui_show_frame_info): Update.
2323         * tui/tui-source.c (tui_set_source_content)
2324         (tui_set_source_content_nil, tui_source_is_displayed)
2325         (tui_source_window::do_scroll_vertical): Update.
2326         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2327         (tui_display_registers_from, tui_display_reg_element_at_line)
2328         (tui_check_register_values, tui_reg_command): Update.
2329         * tui/tui-layout.c (tui_default_win_height)
2330         (show_source_disasm_command, show_data, init_and_make_win)
2331         (show_source_or_disasm_and_command): Update.
2332         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2333         (tui_redisplay_readline, tui_mld_flush)
2334         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2335         (tui_getc): Update.
2336         * tui/tui-disasm.c (tui_set_disassem_content)
2337         (tui_disasm_window::do_scroll_vertical): Update.
2338         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2339         Now virtual.
2340         (struct tui_win_info): Derive from tui_gen_win_info.
2341         <~tui_win_info>: Mark as override.
2342         <generic>: Remove member.
2343         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2344         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2345         (~tui_data_window, ~tui_win_info)
2346         (tui_free_all_source_wins_content): Update.
2347         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-layout.c (init_and_make_win): Use new.
2352         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2353         destructor, initializers.
2354         (tui_alloc_generic_win_info): Don't declare.
2355         * tui/tui-data.c (_locator): Add argument to constructor.
2356         (source_win, disasm_win): New globals.
2357         (exec_info): Remove.
2358         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2359         Update.
2360         (tui_alloc_generic_win_info): Remove.
2361         (init_content_element): Use new.
2362         (tui_win_info::tui_win_info): Update.
2363         (free_content_elements) <case DATA_WIN>: Use delete.
2364
2365 2019-06-25  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2368         * tui/tui-windata.c (tui_first_data_item_displayed)
2369         (tui_delete_data_content_windows): Update.
2370         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2371         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2372         (tui_display_registers_from, tui_check_register_values): Update.
2373         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2374         pointer.
2375         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2376         window.
2377         (tui_free_data_content): Update.
2378         (free_content_elements) <case DATA_WIN>: Free the window.
2379
2380 2019-06-25  Tom Tromey  <tom@tromey.com>
2381
2382         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2383         Update.
2384         * tui/tui-layout.c (make_command_window)
2385         (show_source_disasm_command, show_data, init_and_make_win)
2386         (show_source_or_disasm_and_command): Update.
2387         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2388         method.
2389         <can_highight, is_highlighted>: Now bool.
2390         (tui_set_win_highlight): Don't declare.
2391         * tui/tui-data.c (tui_set_win_highlight): Remove.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-wingeneral.c (make_visible): Remove check of window
2396         type.
2397
2398 2019-06-25  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-win.c (tui_win_info::max_height)
2401         (tui_cmd_window::max_height): New methods.
2402         (new_height_ok): Call max_height.
2403         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2404         <max_height>: New method.
2405
2406 2019-06-25  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-win.c (tui_source_window_base::set_new_height)
2409         (tui_data_window::set_new_height): New methods.
2410         (make_invisible_and_set_new_height): Call set_new_height method.
2411         * tui/tui-data.h (struct tui_win_info)
2412         (struct tui_source_window_base, struct tui_data_window)
2413         <set_new_height>: New method.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2418         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2419         tui_refresh_data_win.
2420         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2421         method.
2422         (tui_refresh_all_win): Call the refresh_all method.
2423         (tui_set_focus): Likewise.
2424         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2425         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2426         Likewise.
2427
2428 2019-06-25  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui-winsource.h (tui_refill_source_window)
2431         (tui_set_is_exec_point_at): Don't declare.
2432         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2433         (tui_source_window_base::refill): Rename from
2434         tui_refill_source_window.
2435         (tui_source_window_base::do_scroll_horizontal): Update.
2436         (tui_source_window_base::set_is_exec_point_at): Rename from
2437         tui_set_is_exec_point_at.
2438         (tui_update_all_breakpoint_info): Update.
2439         * tui/tui-stack.c (tui_show_frame_info): Update.
2440         * tui/tui-layout.c (show_data): Add cast.
2441         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2442         * tui/tui-data.h (struct tui_source_window_base) <refill,
2443         set_is_exec_point_at>: New methods.
2444         (tui_source_windows, tui_add_to_source_windows): Update types.
2445         (tui_add_to_source_windows): Remove redundant declaration.
2446         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2447         (tui_source_windows): Change return type.
2448         (tui_clear_source_windows_detail): Update.
2449         (tui_add_to_source_windows): Change type of parameter.
2450         (tui_free_all_source_wins_content): Update.
2451
2452 2019-06-25  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-wingeneral.c (tui_win_info::refresh)
2455         (tui_source_window_base::refresh): New methods.
2456         (tui_refresh_all): Call the refresh method.
2457         * tui/tui-data.h (struct tui_win_info)
2458         (struct tui_source_window_base) <refresh>: New method.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui.h (tui_is_window_visible): Return bool.
2463         * tui/tui.c (tui_is_window_visible): Return bool.
2464         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2465         (tui_make_visible, tui_make_invisible)
2466         (tui_win_info::make_visible)
2467         (tui_source_window_base::make_visible, make_all_visible)
2468         (tui_make_all_visible, tui_make_all_invisible): Update.
2469         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2470         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2471         bool.
2472         (struct tui_win_info, struct tui_source_window_base)
2473         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2474         * tui/tui-data.c (tui_init_generic_part): Update.
2475
2476 2019-06-25  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2479         (tui_source_window_base::make_visible): New methods.
2480         (make_all_visible): Make method call.
2481         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2482         (struct tui_source_window_base, struct tui_cmd_window): Override
2483         make_visible.
2484         (tui_win_is_source_type): Don't declare.
2485         * tui/tui-data.c (tui_win_is_source_type): Remove.
2486
2487 2019-06-25  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2490         NULL check.
2491
2492 2019-06-25  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2495         Inline constructor.  Add initializers for members.
2496         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2497         constructors; now inline in class.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-regs.c (tui_show_registers): Update.
2502         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2503         bool.
2504         * tui/tui-data.c (tui_data_window::clear_detail)
2505         (tui_data_window): Update.
2506
2507 2019-06-25  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-windata.c (tui_display_all_data)
2510         (tui_display_data_from_line, tui_display_data_from)
2511         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2512         Update.
2513         * tui/tui-regs.c (tui_last_regs_line_no)
2514         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2515         (tui_show_registers, tui_show_register_group)
2516         (tui_display_registers_from, tui_display_reg_element_at_line)
2517         (tui_display_registers_from_line, tui_check_register_values)
2518         (tui_reg_next, tui_reg_prev): Update.
2519         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2520         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2521         tui_data_window.
2522         (struct tui_win_info) <detail>: Remove.  Add new fields from
2523         tui_data_info.
2524         (TUI_DATA_WIN): Add cast.
2525         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2526         (~tui_data_window): Simplify.
2527
2528 2019-06-25  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-layout.c (show_source_disasm_command)
2531         (show_source_or_disasm_and_command): Update.
2532         * tui/tui-io.c (update_cmdwin_start_line)
2533         (tui_redisplay_readline): Update.
2534         * tui/tui-data.h (struct tui_command_info): Remove.
2535         (struct tui_win_info) <detail>: Remove command_info member.
2536         (struct tui_data_window) <start_line>: New member, from
2537         tui_command_info.
2538         (TUI_CMD_WIN): Add casts.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-winsource.c (tui_update_source_window)
2543         (tui_refill_source_window)
2544         (tui_source_window_base::do_scroll_horizontal)
2545         (tui_update_breakpoint_info, tui_set_exec_info_content)
2546         (tui_show_exec_info_content, tui_erase_exec_info_content)
2547         (tui_clear_exec_info_content): Update.
2548         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2549         Update.
2550         * tui/tui-win.c (make_invisible_and_set_new_height)
2551         (make_visible_with_new_height): Update.
2552         * tui/tui-source.c (tui_set_source_content)
2553         (tui_show_symtab_source): Update.
2554         * tui/tui-layout.c (extract_display_start_addr)
2555         (show_source_disasm_command, show_data)
2556         (make_source_or_disasm_window)
2557         (show_source_or_disasm_and_command): Update.
2558         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2559         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2560         "gdbarch".
2561         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2562         to tui_source_window_base.
2563         (struct tui_win_info) <detail>: Remove source_info member.
2564         (struct tui_source_window_base) <has_locator>: Inline.
2565         Move contents from tui_source_info; rename has_locator member to
2566         m_has_locator.
2567         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2568         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2569         header file.
2570         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2571         Simplify.
2572         (tui_free_all_source_wins_content): Cast to
2573         tui_source_window_base.
2574
2575 2019-06-25  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-win.c (make_invisible_and_set_new_height)
2578         (make_visible_with_new_height): Call has_locator method.
2579         * tui/tui-layout.c (show_source_disasm_command, show_data)
2580         (show_source_or_disasm_and_command): Update for bool change.
2581         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2582         (tui_win_info) <has_locator>: New method.
2583         (struct tui_source_window_base) <has_locator>: New method.
2584         (tui_win_has_locator): Don't declare.
2585         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2586         from tui_win_has_locator.
2587         (tui_source_window_base): Use false, not FALSE.
2588
2589 2019-06-25  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2592         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2593         clear_detail method directly.
2594         (tui_clear_win_detail): Remove.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2599         "this", not TUI_DISASM_WIN.
2600
2601 2019-06-25  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2604         declare.
2605         * tui/tui-winsource.c
2606         (tui_source_window_base::do_scroll_horizontal): Rename from
2607         tui_horizontal_source_scroll.
2608         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2609         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2610         from tui_vertical_data_scroll.
2611         * tui/tui-win.h (tui_scroll): Don't declare.
2612         * tui/tui-win.c (tui_win_info::forward_scroll)
2613         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2614         (tui_win_info::right_scroll): Rename and update.
2615         (tui_scroll_forward_command, tui_scroll_backward_command)
2616         (tui_scroll_left_command, tui_scroll_right_command): Update.
2617         (tui_scroll): Remove.
2618         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2619         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2620         from tui_vertical_source_scroll.
2621         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2622         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2623         from tui_vertical_disassem_scroll.
2624         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2625         do_scroll_horizontal>: New methods.
2626         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2627         Likewise.
2628         (struct tui_source_window_base): Add do_scroll_horizontal.
2629         (struct tui_source_window, struct tui_disasm_window): Add
2630         do_scroll_vertical.
2631         (struct tui_data_window, struct tui_cmd_window): Add
2632         do_scroll_horizontal and do_scroll_vertical.
2633         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2634
2635 2019-06-25  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-data.h (struct tui_source_window_base): New struct.
2638         (struct tui_source_window): Derive from tui_source_window_base.
2639         (struct tui_disasm_window): New struct.
2640         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2641         from tui_source_window::clear_detail.
2642         (tui_source_window_base): Rename from tui_source_window.
2643         (~tui_source_window_base): Rename from ~tui_source_window.
2644         (tui_alloc_win_info): Create a tui_disasm_window.
2645
2646 2019-06-25  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-data.h (struct tui_source_window)
2649         (struct tui_data_window): Declare destructors.
2650         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2651         destructors.
2652         (tui_win_info): Simplify.
2653
2654 2019-06-25  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-winsource.c (tui_display_main)
2657         (tui_update_source_windows_with_addr)
2658         (tui_update_all_breakpoint_info): Update.
2659         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2660         (new_height_ok, parse_scrolling_args): Update.
2661         * tui/tui-stack.c (tui_show_frame_info): Update.
2662         * tui/tui-data.h (struct tui_list): Remove.
2663         (tui_source_windows): Return a reference to a std::vector.
2664         * tui/tui-data.c (source_windows): Now a std::vector.
2665         (tui_source_windows): Change return type.
2666         (tui_clear_source_windows): Rewrite.
2667         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2668         (tui_free_all_source_wins_content): Rewrite.
2669
2670 2019-06-25  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2673         (struct tui_data_window, struct tui_cmd_window): Declare
2674         clear_detail method.
2675         * tui/tui-data.c (tui_source_window::clear_detail)
2676         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2677         methods.
2678         (tui_clear_win_detail): Simplify.
2679
2680 2019-06-25  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-layout.c (make_source_window, make_disasm_window)
2683         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2684         Return the new window.
2685         (show_source_disasm_command, show_data)
2686         (show_source_or_disasm_and_command): Update.
2687
2688 2019-06-25  Tom Tromey  <tom@tromey.com>
2689
2690         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2691         parameter.  Return the new window.
2692         (show_source_disasm_command): Update and remove NULL check.
2693         (show_source_or_disasm_and_command): Update.
2694
2695 2019-06-25  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2698
2699 2019-06-25  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-data.h (struct tui_win_info): Make constructor
2702         protected.  Make destructor virtual.  Add initializers.
2703         (tui_source_window, tui_data_window, tui_cmd_window): New
2704         classes.
2705         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2706         constructor.  Add "type" parameter.
2707         (tui_source_window, tui_data_window, tui_cmd_window): New
2708         constructors.
2709         (tui_alloc_win_info): Instantiate the appropriate subclass.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-win.c (tui_resize_all): Use delete.
2714         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2715         destructor.
2716         (tui_free_window): Don't declare.
2717         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2718         Update.
2719
2720 2019-06-25  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-data.h (struct tui_win_info): Add constructor.
2723         * tui/tui-data.c (tui_alloc_win_info): Use new.
2724         (tui_free_window): Use delete.
2725
2726 2019-06-22  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2729         declare.
2730         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2731
2732 2019-06-22  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2735         declare.
2736         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2737
2738 2019-06-22  Tom de Vries  <tdevries@suse.de>
2739
2740         * dwarf2read.c (create_addrmap_from_aranges)
2741         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2742         instead of '%zu'.
2743
2744 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2745
2746         * dwarf2read.h (dwarf2_section_info_def): Remove.
2747         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2748         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2749         std::vector<dwarf2_section_info>.
2750         (struct dwo_file) <~dwo_file>: Remove.
2751         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2752         types field.
2753         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2754         (dwarf2_read_debug_names): Likewise.
2755         (create_debug_types_hash_table): Change parameter type to
2756         array_view, adjust code accordingly.
2757         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2758         (partial_die_info::fixup): Likewise.
2759         (determine_prefix): Likewise.
2760         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2761
2762 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2763
2764         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2765         gdb_bfd_ref_ptr.
2766         <~dwo_file>: Remove call to gdb_bfd_unref.
2767         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2768         gdb_bfd_ref_ptr::get.
2769
2770 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2771
2772         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2773         type to htab_up.
2774         * dwarf2read.c (struct dwo_file): Initialize fields.
2775         <~dwo_file>: New.
2776         (free_dwo_file): Remove, move content to ~dwo_file.
2777         (struct dwo_file_deleter): Remove.
2778         (dwo_file_up>: Remove custom deleter.
2779         (free_dwo_files): Remove.
2780         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2781         dwo_files.
2782         (process_skeletonless_type_units): Call unique_ptr::get.
2783         (allocate_dwo_file_hash_table): Add deleter to created hash
2784         table.  Change return type to htab_up.
2785         (lookup_dwo_file_slot): Don't memset dwo_file, call
2786         unique_ptr::get.
2787         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2788         (create_dwo_unit_in_dwp_v2): Likewise.
2789         (open_and_init_dwo_file): Likewise.
2790         (free_dwo_file_from_slot): Remove.
2791
2792 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2793
2794         * dwarf2read.h (struct dwarf2_section_info) <readin,
2795         is_virtual>: Change type to bool.
2796         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2797         true instead of 1.
2798
2799 2019-06-19  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-data.h (tui_init_content_element): Don't declare.
2802
2803 2019-06-19  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-data.h (tui_init_win_info): Don't declare.
2806
2807 2019-06-19  Tom de Vries  <tdevries@suse.de>
2808
2809         * dwarf2read.h (abstract_to_concrete): Change type to
2810         std::unordered_map<sect_offset, std::vector<sect_offset>,
2811         gdb::hash_enum<sect_offset>>.
2812
2813 2019-06-19  Tom Tromey  <tromey@adacore.com>
2814
2815         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2816         EVAL_AVOID_SIDE_EFFECTS specially.
2817
2818 2019-06-19  Tom Tromey  <tromey@adacore.com>
2819
2820         * source-cache.c (highlighter): New global.
2821         (source_cache::get_source_lines): Create a highlighter on demand.
2822
2823 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * defs.h (deprecated_interactive_hook): Delete declaration.
2826         * interps.c (clear_interpreter_hooks): Remove use of
2827         deprecated_interactive_hook.
2828         * top.c (deprecated_interactive_hook): Delete definition.
2829         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2830
2831 2019-06-18  Tom de Vries  <tdevries@suse.de>
2832
2833         PR gdb/24515
2834         * dwarf2read.h (abstract_to_concrete): Change type from
2835         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2836         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2837         * dwarf2read.c (read_variable): Update.
2838         (dwarf2_fetch_die_loc_sect_off): Update.
2839
2840 2019-06-17  Tom de Vries  <tdevries@suse.de>
2841
2842         PR gdb/24617
2843         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2844         accessing parent[parent_len - 1].
2845
2846 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2847
2848         PR gdb/24364
2849         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2850         call dtrace_process_dof with NULL dof.
2851
2852 2019-06-16  Tom de Vries  <tdevries@suse.de>
2853
2854         PR gdb/24445
2855         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2856
2857 2019-06-16  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2860         (make_all_visible): Use address of member.
2861
2862 2019-06-16  Tom Tromey  <tom@tromey.com>
2863
2864         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2865         (tui_free_window, free_content, free_content_elements): Remove
2866         unnecessary cast.
2867         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2868         cast.
2869         * tui/tui-regs.c (tui_show_register_group)
2870         (tui_display_registers_from, tui_display_reg_element_at_line):
2871         Remove unnecessary cast.
2872
2873 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * linux-nat.c (normal_mask): Delete.
2876         (_initialize_linux_nat): Don't initialise normal_mask.
2877
2878 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2879
2880         PR gdb/24445
2881         * dwarf-index-write.h (write_psymtabs_to_index): Add
2882         dwz_basename parameter.
2883         * dwarf-index-write.c (write_gdbindex): Move file writing to
2884         write_gdbindex_1.  Change return type void.
2885         (assert_file_size): Move up, remove filename parameter.
2886         (write_gdbindex_1): New function.
2887         (write_debug_names): Change return type to void, call
2888         assert_file_size.
2889         (struct index_wip_file): New struct.
2890         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2891         file logic to index_wip_file.  Write index for dwz file if
2892         needed.
2893         (save_gdb_index_command): Pass basename of dwz file, if present.
2894         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2895         build-id of dwz file, if present.
2896         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2897         (dwarf2_get_dwz_file): Likewise.
2898         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2899         (dwarf2_get_dwz_file): Likewise.
2900
2901 2019-06-16  Tom Tromey  <tom@tromey.com>
2902
2903         * coffread.c (process_coff_symbol): Use xstrdup.
2904         * value.c (create_internalvar): Use xstrdup.
2905
2906 2019-06-16  Tom Tromey  <tom@tromey.com>
2907
2908         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2909         * breakpoint.c (stopin_command, stopat_command)
2910         (until_break_command, decode_location_default): Remove unnecessary
2911         cast.
2912         * utils.c (subset_compare): Remove unnecessary cast.
2913         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2914         cast.
2915         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2916         cast.
2917         * infcmd.c (path_command): Remove unnecessary cast.
2918         * coffread.c (decode_type): Remove unnecessary cast.
2919         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2920         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2921         * tui/tui-stack.c (tui_show_locator_content)
2922         (tui_show_frame_info): Remove unnecessary cast.
2923         * tui/tui-win.c (tui_scroll_forward_command)
2924         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2925         (parse_scrolling_args): Remove unnecessary cast.
2926         * tui/tui-data.c (init_win_info, tui_del_window)
2927         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2928         (free_content_elements): Remove unnecessary cast.
2929         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2930         unnecessary cast.
2931         * tui/tui-source.c (tui_set_source_content)
2932         (tui_vertical_source_scroll): Remove unnecessary cast.
2933         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2934         cast.
2935         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2936         * tui/tui-regs.c (tui_display_registers_from)
2937         (tui_display_register): Remove unnecessary cast.
2938         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2939         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2940         (make_visible): Remove unnecessary cast.
2941         * tui/tui-winsource.c (tui_erase_source_content)
2942         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2943         unnecessary cast.
2944         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2945         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2946         * stabsread.c (read_type, read_array_type, read_range_type):
2947         Remove unnecessary cast.
2948         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2949         (parse_symbol, parse_type, upgrade_type, parse_external)
2950         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2951         unnecessary cast.
2952         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2953
2954 2019-06-16  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-data.c (tui_alloc_generic_win_info)
2957         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2958         checks.
2959
2960 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2961             Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * f-typeprint.c (f_print_type): Don't return early for not
2964         associated or not allocated types.
2965         (f_type_print_varspec_suffix): Add print_rank parameter and print
2966         ranks of array types in case they dangling.
2967         (f_type_print_base): Add print_rank parameter.
2968
2969 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * NEWS: Mention new MI commands.
2972         * break-catch-throw.c (enum exception_event_kind): Move to
2973         breakpoint.h.
2974         (print_mention_exception_catchpoint): Output text as a single
2975         message.
2976         (catch_exception_command_1): Rename to...
2977         (catch_exception_event): ...this, make non-static, update header
2978         command, and change some parameter types.
2979         (catch_catch_command): Update for changes to
2980         catch_exception_command_1.
2981         (catch_throw_command): Likewise.
2982         (catch_rethrow_command): Likewise.
2983         * breakpoint.c (enum exception_event_kind): Delete.
2984         * breakpoint.h (enum exception_event_kind): Moved here from
2985         break-catch-throw.c.
2986         (catch_exception_event): Declare.
2987         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2988         (mi_cmd_catch_throw): New function.
2989         (mi_cmd_catch_rethrow): New function.
2990         (mi_cmd_catch_catch): New function.
2991         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2992         'catch-catch' entries.
2993         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2994         (mi_cmd_catch_rethrow): Declare.
2995         (mi_cmd_catch_catch): Declare.
2996
2997 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * annotate.c (annotate_source_line): Change return type to void,
3000         update implementation to match.
3001         * annotate.h (annotate_source_line): Change return type to void,
3002         update header comment.
3003         * stack.c (print_frame_info): Don't change what frame information
3004         is printed based on whether annotations are on or not.
3005
3006 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3007
3008         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3009         (annotate_source): Make static.
3010         (annotate_source_line): Moved from source.c and renamed from
3011         identify_source_line.  Update the return type.
3012         * annotate.h (annotate_source): Delete declaration.
3013         (annotate_source_line): Declaration moved from source.h, and
3014         renamed from identify_source_line.  Return type updated.
3015         * source.c (identify_source_line): Moved to annotate.c and renamed
3016         to annotate_source_line.
3017         (info_line_command): Remove check of annotation_level.
3018         * source.h (identify_source_line): Move declaration to annotate.h
3019         and rename to annotate_source_line.
3020         * stack.c: Add 'annotate.h' include.
3021         (print_frame_info): Remove check of annotation_level before
3022         calling annotate_source_line.
3023
3024 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * source-cache.c (source_cache::get_plain_source_lines): Use
3027         open_source_file_with_line_charpos instead of just
3028         open_source_file, remove call to find_source_lines.
3029         (source_cache::get_source_lines): Likewise.
3030         * source.c (find_source_lines): Make static.
3031         (get_filename_and_charpos): Renamed into...
3032         (open_source_file_with_line_charpos): ..this along with changes to
3033         return a scoped_fd, and some other minor clean ups.
3034         (identify_source_line): Use open_source_file_with_line_charpos.
3035         (search_command_helper): Use open_source_file_with_line_charpos
3036         instead of just open_source_file, remove call to
3037         find_source_lines.
3038         * source.h (open_source_file_with_line_charpos): Declare new
3039         function.
3040         (find_source_lines): Delete declaration.
3041
3042 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3043
3044         * source.c (get_filename_and_charpos): Remove fullname
3045         parameter.
3046         (identify_source_line): Update call to get_filename_and_charpos.
3047
3048 2019-06-14  Tom Tromey  <tromey@adacore.com>
3049
3050         PR gdb/24502:
3051         * ui-style.h (skip_ansi_escape): Update comment.
3052         * ui-file.h (class no_terminal_escape_file): New class.
3053         * ui-file.c (no_terminal_escape_file::write)
3054         (no_terminal_escape_file::puts): New methods.
3055         * cli/cli-logging.c (handle_redirections): Use
3056         no_terminal_escape_file.
3057
3058 2019-06-14  Tom Tromey  <tromey@adacore.com>
3059
3060         * NEWS: Move convenience variable news above Python news.
3061
3062 2019-06-14  Tom Tromey  <tom@tromey.com>
3063
3064         * gnulib: Move directory to top-level.
3065         * configure.ac: Don't configure gnulib.
3066         * configure: Rebuild.
3067         * common/common-defs.h: Use new path to gnulib.
3068         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3069         (GNULIB_H): Remove.
3070         (INCGNU): Look in new gnulib location.
3071         (HFILES_NO_SRCDIR): Remove gnulib files.
3072         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3073         (generated_files): Remove GNULIB_H.
3074         ($(LIBGNU), all-lib): Remove targets.
3075         (distclean): Don't mention GNULIB_BUILDDIR.
3076         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3077
3078 2019-06-14  Tom Tromey  <tromey@adacore.com>
3079
3080         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3081         Warn if symbol file does not provide any symbols.
3082
3083 2019-06-14  Tom Tromey  <tromey@adacore.com>
3084
3085         * source.c (find_and_open_source): Respect basenames_may_differ.
3086
3087 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * annotate.c (annotate_breakpoints_invalid): Make use of
3090         scoped_restore_terminal_state.
3091         (annotate_frames_invalid): Likewise.
3092
3093 2019-06-14  Tom Tromey  <tromey@adacore.com>
3094
3095         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3096         allow assignment to an internalvar.
3097
3098 2019-06-14  Tom Tromey  <tromey@adacore.com>
3099
3100         * ada-lex.l: Allow "_" in attribute names.
3101
3102 2019-06-14  Tom Tromey  <tromey@adacore.com>
3103
3104         PR gdb/24653:
3105         * regcache.c (registers_changed): Don't call alloca.
3106         * top.c (execute_command): Don't call alloca.
3107
3108 2019-06-13  Pedro Alves  <palves@redhat.com>
3109
3110         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3111         'expression'.  When parsing an expression, error out if there's
3112         junk after "unlimited".
3113         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3114         (do_set_command): Adjust calls to is_unlimited_literal.
3115
3116 2019-06-13  Pedro Alves  <palves@redhat.com>
3117
3118         * compile/compile.c (make_compile_options_def_group): Add braces
3119         around array_view initializer.
3120         * thread.c (make_thread_apply_all_options_def_group)
3121         (make_thread_apply_all_options_def_group): Likewise.
3122
3123 2019-06-13  Pedro Alves  <palves@redhat.com>
3124
3125         * NEWS (New commands): Mention "maint test-options
3126         require-delimiter", "maint test-options unknown-is-error", "maint
3127         test-options unknown-is-operand" and "maint show
3128         test-options-completion-result".
3129         (New command options, command completion): New section.
3130         (Completion improvements): New section.
3131         Mention that you can abbreviate "unlimited".
3132
3133 2019-06-13  Pedro Alves  <palves@redhat.com>
3134
3135         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3136         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3137         * unittests/cli-utils-selftests.c (test_parse_flags)
3138         (test_parse_flags_qcs): Delete.
3139         (test_cli_utils): Don't call deleted functions.
3140
3141 2019-06-13  Pedro Alves  <palves@redhat.com>
3142
3143         * thread.c: Include "cli/cli-option.h".
3144         (tp_array_compar_ascending): Global.
3145         (tp_array_compar): Delete function.
3146         (tp_array_compar_ascending, tp_array_compar_descending): New
3147         functions.
3148         (ascending_option_def, qcs_flag_option_def)
3149         (thr_qcs_flags_option_defs)
3150         (make_thread_apply_all_options_def_group)
3151         (make_thread_apply_options_def_group): New.
3152         (thread_apply_all_command): Use gdb::option::process_options.
3153         (thread_apply_command_completer)
3154         (thread_apply_all_command_completer): New.
3155         (thread_apply_command): Use gdb::option::process_options.
3156         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3157         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3158         to generate help text of "thread apply".  Adjust "taas"'s help.
3159         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3160         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3161
3162 2019-06-13  Pedro Alves  <palves@redhat.com>
3163
3164         * thread.c (thread_apply_command): Check for invalid TID with
3165         isdigit instead of !isalpha.
3166
3167 2019-06-13  Pedro Alves  <palves@redhat.com>
3168
3169         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3170         (validate_flags_qcs): New.
3171         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3172         (validate_flags_qcs): Declare.
3173         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3174         (make_frame_apply_options_def_group): New.
3175         (frame_apply_command_count): Process options with
3176         gdb::option::process_options.
3177         (frame_apply_completer): New.
3178         (frame_apply_level_completer, frame_apply_all_completer)
3179         (frame_apply_completer): New.
3180         (_initialize_stack): Update help of "frame apply", "frame apply
3181         level", "frame apply all" and "faas" to mention supported options
3182         and install command completers.
3183         * stack.h (frame_apply_all_completer): Declare.
3184         * thread.c: Include "stack.h".
3185         (tfaas_command): Add "--".
3186         (_initialize_thread): Update help "tfaas" to mention supported
3187         options and install command completer.
3188
3189 2019-06-13  Pedro Alves  <palves@redhat.com>
3190
3191         * completer.c (complete_nested_command_line): New.
3192         (gdb_completion_word_break_characters_throw): Add assertion.
3193         * completer.h (complete_nested_command_line): Declare.
3194
3195 2019-06-13  Pedro Alves  <palves@redhat.com>
3196
3197         * stack.c (parse_backtrace_qualifiers): New.
3198         (backtrace_command): Use it.
3199         (backtrace_command_completer): Complete on qualifiers.
3200
3201 2019-06-13  Pedro Alves  <palves@redhat.com>
3202
3203         * frame.c: Include "cli/cli-option.h.
3204         (user_set_backtrace_options): New.
3205         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3206         Delete.
3207         (get_prev_frame): Adjust.
3208         (boolean_option_def, uinteger_option_def)
3209         (set_backtrace_option_defs): New.
3210         (_initialize_frame): Adjust and use
3211         gdb::option::add_setshow_cmds_for_options to install "set
3212         backtrace past-main" and "set backtrace past-entry".
3213         * frame.h: Include "cli/cli-option.h".
3214         (struct frame_print_options): Forward declare.
3215         (print_frame_arguments_all, print_frame_arguments_scalars)
3216         (print_frame_arguments_none): Declare.
3217         (print_entry_values): Delete declaration.
3218         (struct frame_print_options, user_frame_print_options): New.
3219         (struct set_backtrace_options): New.
3220         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3221         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3222         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3223         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3224         (list_args_or_locals): Add frame_print_options parameter.
3225         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3226         * python/py-framefilter.c (enumerate_args): Pass down
3227         USER_FRAME_PRINT_OPTIONS.
3228         * stack.c: Include "cli/cli-option.h".
3229         (print_frame_arguments_all, print_frame_arguments_scalars)
3230         (print_frame_arguments_none): Declare.
3231         (print_raw_frame_arguments, print_entry_values): Delete.
3232         (user_frame_print_options): New.
3233         (boolean_option_def, enum_option_def, frame_print_option_defs):
3234         New.
3235         (struct backtrace_cmd_options): New.
3236         (bt_flag_option_def): New.
3237         (backtrace_command_option_defs): New.
3238         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3239         (print_frame_arg, read_frame_arg, print_frame_args)
3240         (print_frame_info, print_frame): Add frame_print_options parameter
3241         and use it.
3242         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3243         (backtrace_command_1): Add frame_print_options and
3244         backtrace_cmd_options parameters and use them.
3245         (make_backtrace_options_def_group): New.
3246         (backtrace_command): Process command options with
3247         gdb::option::process_options.
3248         (backtrace_command_completer): New.
3249         (_initialize_stack): Extend "backtrace"'s help to mention
3250         supported options.  Install completer for "backtrace".
3251         Install some settings commands with add_setshow_cmds_for_options.
3252
3253 2019-06-13  Pedro Alves  <palves@redhat.com>
3254
3255         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3256         and that "set/show print raw frame-arguments" are now deprecated.
3257
3258         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3259         command.
3260         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3261         * stack.c (_initialize_stack): Install "set/show print
3262         raw-frame-arguments", and deprecate "set/show print raw
3263         frame-arguments".
3264         * valprint.c (_initialize_valprint): Deprecate "set/show print
3265         raw".
3266
3267 2019-06-13  Pedro Alves  <palves@redhat.com>
3268
3269         * compile/compile.c (struct compile_options): New.
3270         (compile_flag_option_def, compile_command_option_defs)
3271         (make_compile_options_def_group): New.
3272         (compile_file_command): Handle options with
3273         gdb::option::process_options.
3274         (compile_file_command_completer): New function.
3275         (compile_code_command): Handle options with
3276         gdb::option::process_options.
3277         (compile_code_command_completer): New function.
3278         (_initialize_compiler): Install completers for "compile code" and
3279         "compile file".  Mention available options in "compile code" and
3280         "compile code"'s help.
3281         * completer.c (advance_to_completion_word): New, factored out from
3282         ...
3283         (advance_to_expression_complete_word_point): ... this.
3284         (advance_to_filename_complete_word_point): New.
3285         * completer.h (advance_to_filename_complete_word_point): New
3286         declaration.
3287
3288 2019-06-13  Pedro Alves  <palves@redhat.com>
3289
3290         * compile/compile.c: Include "cli/cli-option.h".
3291         (compile_print_value): Scope data pointer is now a
3292         value_print_options pointer; adjust.
3293         (compile_print_command): Process options.  Scope data pointer is
3294         now a value_print_options pointer; adjust.
3295         (_initialize_compile): Update "compile print"'s help to include
3296         supported options.  Install a completer for "compile print".
3297         * cp-valprint.c (show_vtblprint, show_objectprint)
3298         (show_static_field_print): Delete.
3299         (_initialize_cp_valprint): Don't install "set print
3300         static-members", "set print vtbl", "set print object" here.
3301         * printcmd.c: Include "cli/cli-option.h" and
3302         "common/gdb_optional.h".
3303         (print_command_parse_format): Rework to fill in a
3304         value_print_options instead of a format_data.
3305         (print_value): Change parameter type from format_data pointer to
3306         value_print_options reference.  Adjust.
3307         (print_command_1): Process options.  Adjust to pass down a
3308         value_print_options.
3309         (print_command_completer): New.
3310         (_initialize_printcmd): Install print_command_completer as
3311         handle_brkchars completer for the "print" command.  Update
3312         "print"'s help to include supported options.
3313         * valprint.c: Include "cli/cli-option.h".
3314         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3315         here from cp-valprint.c.
3316         (boolean_option_def, uinteger_option_def)
3317         (value_print_option_defs, make_value_print_options_def_group):
3318         New.  Use gdb::option::add_setshow_cmds_for_options to install
3319         "set print elements", "set print null-stop", "set print repeats",
3320         "set print pretty", "set print union", "set print array", "set
3321         print address", "set print symbol", "set print array-indexes".
3322         * valprint.h: Include <string> and "cli/cli-option.h".
3323         (make_value_print_options_def_group): Declare.
3324         (print_value): Change parameter type from format_data pointer to
3325         value_print_options reference.
3326         (print_command_completer): Declare.
3327
3328 2019-06-13  Pedro Alves  <palves@redhat.com>
3329
3330         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3331         (COMMON_SFILES): Add maint-test-settings.c.
3332         * cli/cli-decode.c (boolean_enums): New global, factored out from
3333         ...
3334         (add_setshow_boolean_cmd): ... here.
3335         * cli/cli-decode.h (boolean_enums): Declare.
3336         * cli/cli-option.c: New file.
3337         * cli/cli-option.h: New file.
3338         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3339         factored out from ...
3340         (parse_cli_boolean_value(const char *)): ... this.
3341         (is_unlimited_literal): Change parameter type to pointer to
3342         pointer.  Adjust and advance ARG pointer.
3343         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3344         (parse_cli_var_enum): New, factored out from ...
3345         (do_set_command): ... this.  Adjust.
3346         * cli/cli-setshow.h (parse_cli_boolean_value)
3347         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3348         (parse_cli_var_enum): Declare.
3349         * cli/cli-utils.c: Include "cli/cli-option.h".
3350         (get_ulongest): New.
3351         * cli/cli-utils.h (get_ulongest): Declare.
3352         (check_for_argument): New overloads.
3353         * maint-test-options.c: New file.
3354
3355 2019-06-13  Pedro Alves  <palves@redhat.com>
3356
3357         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3358         parse a range if "-" is at the end of the string.
3359
3360 2019-06-13  Pedro Alves  <palves@redhat.com>
3361
3362         * cli/cli-setshow.c (parse_auto_binary_operation)
3363         (parse_cli_boolean_value): Don't allow "o".
3364
3365 2019-06-13  Pedro Alves  <palves@redhat.com>
3366
3367         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3368         * NEWS: Mention maint test-settings KIND.
3369         * maint-test-settings.c: New file.
3370
3371 2019-06-13  Pedro Alves  <palves@redhat.com>
3372
3373         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3374         completer.
3375         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3376         "set" completers.
3377
3378 2019-06-13  Pedro Alves  <palves@redhat.com>
3379
3380         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3381         after item.
3382
3383 2019-06-13  Pedro Alves  <palves@redhat.com>
3384
3385         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3386
3387 2019-06-13  Pedro Alves <palves@redhat.com>
3388
3389         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3390         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3391         call.
3392         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3393         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3394         calls.
3395         (check_for_argument): Skip spaces after argument.
3396
3397 2019-06-13  Pedro Alves  <palves@redhat.com>
3398
3399         * thread.c (thread_apply_command): Adjust TID parsing.
3400         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3401         detected before end of string.
3402         (tid_is_in_list): Error out if LIST is invalid.
3403
3404 2019-06-13  Pedro Alves  <palves@redhat.com>
3405
3406         * completer.c (complete_line_internal_1): Rewind completion word
3407         point.
3408         (completion_tracker::advance_custom_word_point_by): Change
3409         parameter type to int.
3410         * completer.h (completion_tracker::advance_custom_word_point_by):
3411         Likewise.
3412
3413 2019-06-13  Pedro Alves  <palves@redhat.com>
3414
3415         * completer.c (advance_to_completion_word): Handle delimiters.
3416
3417 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3418
3419         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3420
3421 2019-06-11  Tom Tromey  <tom@tromey.com>
3422
3423         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3424         (xmalloc_failed): Move to alloc.c.
3425         * alloc.c: New file.
3426         * Makefile.in (COMMON_SFILES): Add alloc.c.
3427
3428 2019-06-11  Tom Tromey  <tom@tromey.com>
3429
3430         * nat/linux-waitpid.c: Don't include server.h.
3431         (linux_debug): Remove.
3432         (my_waitpid): Update.
3433
3434 2019-06-11  Tom Tromey  <tromey@adacore.com>
3435
3436         * infcall.c (_initialize_infcall): Remove trailing newline from
3437         help.
3438         * user-regs.c (_initialize_user_regs): Remove trailing newline
3439         from help.
3440         * typeprint.c (_initialize_typeprint): Remove trailing newline
3441         from help.
3442         * reverse.c (_initialize_reverse): Remove trailing newlines from
3443         help.
3444         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3445         from help.
3446         * language.c (add_set_language_command): Remove trailing newline
3447         from help.
3448         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3449         help.
3450         * disasm.c (_initialize_disasm): Remove trailing newline from
3451         help.
3452         * top.c (init_main): Remove trailing newline from help.
3453         * interps.c (_initialize_interpreter): Remove trailing newline
3454         from help.
3455         * btrace.c (_initialize_btrace): Remove trailing newlines from
3456         help.
3457         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3458         from help.
3459         * python/python.c (_initialize_python): Remove trailing newline
3460         from help.
3461         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3462         help.
3463         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3464         from help.  Reformat some text.
3465         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3466         from help.
3467         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3468         newline from help.
3469
3470 2019-06-11  Tom Tromey  <tromey@adacore.com>
3471
3472         * darwin-nat.c (darwin_decode_exception_message)
3473         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3474
3475 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * valops.c (value_slice): Check for not allocated or not
3478         associated values.
3479
3480 2019-06-10  Tom de Vries  <tdevries@suse.de>
3481
3482         PR gdb/24618
3483         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3484         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3485         invalid.
3486
3487 2019-06-10  Tom de Vries  <tdevries@suse.de>
3488
3489         PR gdb/24611
3490         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3491         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3492
3493 2019-06-10  Tom de Vries  <tdevries@suse.de>
3494
3495         PR symtab/24545
3496         * symtab.c (struct demangled_name_entry): Add language field.
3497         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3498         static minimal symbol".  Set and use language field.
3499
3500 2019-06-10  Tom Tromey  <tromey@adacore.com>
3501
3502         * ada-lang.c (_initialize_ada_language): Update help text.
3503
3504 2019-06-10  Tom Tromey  <tromey@adacore.com>
3505
3506         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3507         with a newline.
3508         * guile/guile.c (handle_boot_error): Don't end warning with a
3509         newline.
3510         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3511         warning with a newline.
3512         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3513         newline.
3514         (s12z_frame_cache): Likewise.
3515         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3516         a newline.
3517         * solib-svr4.c (disable_probes_interface): Don't end warning with
3518         a newline.
3519         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3520         newline.
3521         * python/python.c (do_finish_initialization): Don't end warning
3522         with a newline.
3523
3524 2019-06-10  Tom Tromey  <tom@tromey.com>
3525
3526         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3527         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3528         gdbpy_enter.
3529
3530 2019-06-10  Tom Tromey  <tromey@adacore.com>
3531
3532         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3533         data.
3534         (elf_new_init): Don't call stabsread_new_init.
3535         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3536         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3537         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3538
3539 2019-06-10  Tom de Vries  <tdevries@suse.de>
3540
3541         PR symtab/16264
3542         PR symtab/24517
3543         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3544
3545 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3546
3547         * source.c (find_and_open_source): Also rewrite relative file
3548         names.
3549
3550 2019-04-26  Amos Bird  <amosbird@gmail.com>
3551
3552         * annotate.c (annotate_thread_exited): Add "thread-exited"
3553         annotation.
3554
3555 2019-06-06  Tom Tromey  <tromey@adacore.com>
3556
3557         * maint.h (class scoped_command_stats): Use
3558         DISABLE_COPY_AND_ASSIGN.
3559         <print_time>: New method.
3560         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3561         print_time.
3562         (scoped_command_stats::print_time): New method.
3563
3564 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3565
3566         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3567         instructions of lengths 6 or 8 bytes.
3568
3569 2019-06-04  Pedro Alves  <palves@redhat.com>
3570
3571         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3572
3573         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3574         * breakpoint.c (condition_completer): Likewise.
3575         * cli/cli-dump.c (scan_expression): Likewise.
3576         * common/filestuff.c (mkdir_recursive): Likewise.
3577         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3578         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3579         (gdb_abspath): Likewise.
3580         * compile/compile-cplus-types.c
3581         (compile_cplus_instance::decl_name): Likewise.
3582         * completer.c (complete_explicit_location):
3583         (signal_completer, reg_or_group_completer_1): Likewise.
3584         * cp-support.c (cp_remove_params_if_any): Likewise.
3585         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3586         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3587         * infcmd.c (strip_bg_char): Likewise.
3588         * linespec.c (copy_token_string): Likewise.
3589         * mi/mi-main.c (output_cores): Likewise.
3590         * psymtab.c (psymtab_search_name):
3591         * symfile.c (test_set_ext_lang_command): Likewise.
3592         * target.c (target_fileio_read_stralloc): Likewise.
3593         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3594         * value.c (complete_internalvar): Likewise.
3595
3596 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3597
3598         Add objfile property to gdb.Type.
3599         * NEWS: Mention Python API addition.
3600         * python/py-type.c (typy_get_objfile): New method.
3601
3602 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3603
3604         * NEWS: Mention the new set|show style [title|highlight].
3605         Mention changes to "show style", "help" and "apropos".
3606
3607 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3608
3609         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3610         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3611         instead of print_help_for_command.
3612         (print_doc_of_command): New function.
3613         (help_list): Add 'apropos -v word' suggestion.
3614         (print_help_for_command): Style the command name using title style.
3615         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3616         (_initialize_cli_cmds): Describe -v in apropos_command help.
3617
3618 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3619
3620         * cli/cli-style.h (cli_style_option): Add name in constructor,
3621         add m_name class member, add constructor with intensity,
3622         add name class function.
3623         (cli_style_option::add_setshow_commands): Remove name argument.
3624         (highlight_style, title_style): New styles.
3625         * cli/cli-style.c (do_show): New function that shows a style
3626         characteristic styling the style name with itself.
3627         (set_style_name): New function.
3628         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3629         Update all callers according to the changes in cli/cli-style.h.
3630         * utils.h (fputs_highlighted): New function.
3631         * utils.c (fputs_highlighted): Likewise.
3632
3633 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3634
3635         * NEWS: Mention new pipe command and new convenience variables.
3636
3637 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3638
3639         * cli/cli-cmds.c (pipe_command): New function.
3640         (_initialize_cli_cmds): Call add_com for pipe_command.
3641         Define | as an alias for pipe.
3642         (exit_status_set_internal_vars): New function.
3643         (shell_escape): Call exit_status_set_internal_vars.
3644         cli/cli-decode.c (find_command_name_length): Recognize | as
3645         a single character command.
3646
3647 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3648
3649         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3650         top.c (execute_command_to_ui_file): New function, mostly a copy
3651         of execute_command_to_string.
3652         (execute_command_to_string): Implement by calling
3653         execute_command_to_ui_file.
3654
3655 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3656
3657         * top.h (saved_command_line): Remove declaration.
3658         * top.c (previous_saved_command_line, previous_repeat_arguments):
3659         New variables.
3660         (saved_command_line): Make static, define together with other
3661         'repeat variables'.
3662         (dont_repeat): Clear repeat_arguments.
3663         (repeat_previous, get_saved_command_line, save_command_line):
3664         New functions.
3665         (gdb_init): Initialize saved_command_line
3666         and previous_saved_command_line.
3667         * main.c (captured_main_1): Remove saved_command_line initialization.
3668         * event-top.c (handle_line_of_input): Update to use
3669         the new 'repeat' related functions instead of direct access to
3670         saved_command_line.
3671         * command.h (repeat_previous, get_saved_command_line,
3672         save_command_line): New declarations.
3673         (dont_repeat): Add comment.
3674
3675 2019-05-30  Tom Tromey  <tromey@adacore.com>
3676
3677         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3678         Fix comment.
3679         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3680
3681 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3682
3683         PR cli/24587
3684         * completer.c (complete): Initialize variable word.
3685
3686 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3687
3688         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3689         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3690         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3691         'body' is NULL to the outter 'if', protecting the '!is_define'
3692         situation as well.
3693
3694 2019-05-29  Tom Tromey  <tromey@adacore.com>
3695
3696         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3697         (dwarf_unknown): New function.
3698         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3699         (dwarf_type_encoding_name): Use dwarf_unknown.
3700
3701 2019-05-29  Tom Tromey  <tromey@adacore.com>
3702
3703         PR c++/20020:
3704         * cp-valprint.c (cp_print_value_fields): Call
3705         cp_print_static_field inside "try".
3706
3707 2019-05-29  Tom Tromey  <tromey@adacore.com>
3708
3709         * inflow.c (struct terminal_info): Add default operator=.
3710         * configure: Rebuild.
3711         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3712         -Wdeprecated-copy-dtor, -Wredundant-move.
3713
3714 2019-05-29  Tom Tromey  <tromey@adacore.com>
3715
3716         * NEWS: Add entry.
3717         * infcmd.c (print_return_value_1): Handle finish_print
3718         option.
3719         (show_print_finish): New function.
3720         (_initialize_infcmd): Add "set/show print finish" commands.
3721         * valprint.c (user_print_options): Initialize new member.
3722         * valprint.h (struct value_print_options) <finish_print>: New
3723         member.
3724
3725 2019-05-28  Tom Tromey  <tromey@adacore.com>
3726
3727         * ada-lang.c (ada_remove_Xbn_suffix)
3728         (find_old_style_renaming_symbol)
3729         (parse_old_style_renaming): Remove.
3730         (ada_find_renaming_symbol): Don't call
3731         find_old_style_renaming_symbol.
3732         (ada_is_renaming_symbol): Rename from
3733         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3734         bool.  Now static.
3735         (ada_read_var_value): Update and simplify.
3736         * ada-exp.y (write_var_or_type): Remove old code.
3737
3738 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3739
3740         * event-top.c: Remove include comment.
3741         * inflow.c (class scoped_ignore_sigttou): Move from here...
3742         * inflow.h (class scoped_ignore_sigttou): ...to here.
3743         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3744         * top.c:  Remove include comment.
3745
3746 2019-05-27  Tom Tromey  <tom@tromey.com>
3747
3748         * NEWS: Fix typo.
3749
3750 2019-05-22  Tom Tromey  <tromey@adacore.com>
3751
3752         * target.c (target_follow_exec): Constify parameter.
3753         * target-delegates.c: Rebuild.
3754         * remote.c (remote_target::follow_exec): Constify parameter.
3755         * infrun.c (follow_exec): Constify parameter.
3756         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3757         (target_follow_exec): Likewise.
3758
3759 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3760
3761         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3762         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3763
3764 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3765
3766         * NEWS: Add debugredirect and testsuite sections.
3767
3768 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3769
3770         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3771         target descriptions using exclusively floating point register name
3772         aliases.
3773
3774 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         PR gdb/18644:
3777         * f-lang.c (build_fortran_types): Handle the case where
3778         gdbarch_floatformat_for_type returns a nullptr.
3779
3780 2019-05-21  Tom de Vries  <tdevries@suse.de>
3781
3782         PR cli/24587
3783         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3784
3785 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3786
3787         PR gdb/18644:
3788         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3789         16-byte floats.
3790         * i386-tdep.c (i386_floatformat_for_type): Use
3791         floatformats_ia64_quad for the 16-byte floating point component
3792         within a fortran 32-byte complex number.
3793
3794 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3795
3796         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3797         delete default constructor.
3798         (find_partial_die): Update to return const struct.
3799         (partial_die_parent_scope): Move variable declaration into scope
3800         of its use and change its type to auto.
3801         (guess_partial_die_structure_name): Likewise.
3802         (partial_die_info::fixup): Likewise.
3803
3804 2019-05-17  Tom Tromey  <tromey@adacore.com>
3805
3806         * source.c (find_and_open_source): Remove cast.
3807
3808 2019-05-17  Tom Tromey  <tromey@adacore.com>
3809
3810         * annotate.c (annotate_source): Make "filename" const.
3811         * annotate.h (annotate_source): Use const.
3812
3813 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3814
3815         * disasm.c (set_disassembler_options): Send errors to stderr.
3816
3817 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3818
3819         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3820         (cli_interp_base::set_logging): Check debug_redirect.
3821         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3822         * cli/cli-logging.c (debug_redirect): Add static variable.
3823         (pop_output_files): Add default param.
3824         (handle_redirections): Print debug setting.
3825         (show_logging_command): Likewise.
3826         (_initialize_cli_logging): Add debugredirect command.
3827         * interps.c (current_interp_set_logging): Add debug_redirect
3828         parameter.
3829         * interps.h (set_logging): Add debug_redirect parameter.
3830         (current_interp_set_logging): Likewise.
3831         * mi/mi-common.h: Likewise.
3832         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3833
3834 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3835             Tom Tromey  <tromey@adacore.com>
3836
3837         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3838         directly.
3839         * cli/cli-interp.h (make_logging_output): Remove declaration.
3840         * cli/cli-logging.c (make_logging_output): Remove function.
3841         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3842         directly.
3843         * ui-file.c (tee_file::tee_file): Remove bools.
3844         (tee_file::~tee_file): Remove deletes.
3845         * ui-file.h (tee_file): Remove bools.
3846
3847 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3848
3849         * mi/mi-cmds.h (mi_cmd_complete): New function.
3850         * mi/mi-main.c (mi_cmd_complete): Likewise.
3851         * mi/mi-cmds.c: Define new MI command -complete.
3852         * NEWS: Mention new -complete command.
3853
3854 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3855
3856         * completer.h (complete): New function.
3857         * completer.c (complete): Likewise.
3858         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3859         function defined in completer.h.
3860
3861 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3862
3863         * MAINTAINERS (Write After Approval): Add myself.
3864
3865 2019-05-17  Tom de Vries  <tdevries@suse.de>
3866
3867         PR gdb/24094
3868         * dwarf2read.c (struct cu_partial_die_info): New struct.
3869         (find_partial_die): Return cu_partial_die_info.
3870         (partial_die_parent_scope, guess_partial_die_structure_name)
3871         (partial_die_info::fixup): Handle new return type of find_partial_die.
3872
3873 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3874
3875         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3876         "std::string", simplifying the algorithm.
3877
3878 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3879
3880         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3881         (stap_static_probe_ops::get_probes): Likewise.
3882
3883 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3884
3885         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3886         '-')" and "else if".
3887         (stap_parse_single_operand): Join checks for
3888         "gdbarch_stap_parse_special_token_p" and
3889         "gdbarch_stap_parse_special_token" in the same "if" statement.
3890         Invert check when verifying for operation on register
3891         displacement.
3892
3893 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3894
3895         * stap-probe.c (stap_get_opcode): Update comment.
3896         (stap_get_expected_argument_type): Likewise.
3897         (handle_stap_probe): Likewise.
3898
3899 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3900
3901         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3902         return type to 'bool'.  Adjust comment.  Use 'bool' when
3903         appropriate.
3904         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3905         * stap-probe.c (stap_parse_argument_1): Likewise.
3906         (stap_is_operator): Likewise.
3907         (stap_is_generic_prefix): Likewise.
3908         (stap_is_register_prefix): Likewise.
3909         (stap_is_register_indirection_prefix): Likewise.
3910         (stap_is_integer_prefix): Likewise.
3911         (stap_generic_check_suffix): Likewise.
3912         (stap_check_integer_suffix): Likewise.
3913         (stap_check_register_suffix): Likewise.
3914         (stap_check_register_indirection_suffix): Likewise.
3915         (stap_parse_register_operand): Likewise.
3916         (stap_parse_single_operand): Likewise.
3917         (stap_parse_argument_1): Likewise.
3918         (stap_probe::get_argument_count): Likewise.
3919         (stap_is_operator): Likewise.
3920
3921 2019-05-16  Tom Tromey  <tromey@adacore.com>
3922
3923         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3924         keyword to foreach.
3925
3926 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3927
3928         * linux-thread-db.c (try_thread_db_load_1): Change return type
3929         to bool.
3930         (try_thread_db_load): Likewise.
3931         (try_thread_db_load_from_pdir_1): Likewise.
3932         (try_thread_db_load_from_pdir): Likewise.
3933         (try_thread_db_load_from_sdir): Likewise.
3934         (try_thread_db_load_from_dir): Likewise.
3935         (thread_db_load_search): Likewise.
3936         (has_libpthread): Likewise.
3937         (thread_db_load): Likewise.
3938
3939 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3940
3941         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3942         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3943         NULL, and complain/return if that's the case.
3944
3945 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3946
3947         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3948         (advance, posn, abstract_read_memory): New functions.
3949         [struct mem_read_abstraction]: New struct.
3950         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3951
3952 2019-05-14  Tom Tromey  <tromey@adacore.com>
3953
3954         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3955         value is not lval_memory.
3956
3957 2019-05-14  Tom Tromey  <tromey@adacore.com>
3958
3959         * solib.c (info_sharedlibrary_command): Style the file name.
3960
3961 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3962
3963         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3964         (aarch64_vnv_type): Likewise.
3965         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3966         * common/tdesc.c: Likewise.
3967         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3968         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3969         * features/aarch64-fpu.xml: Add ieee half view.
3970         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3971         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3972         * gdbtypes.h (struct builtin_type): Likewise.
3973         (struct objfile_type): Likewise.
3974
3975 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3976
3977         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3978         typo.
3979         * location.h (string_to_event_location): Likewise.
3980
3981 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3982
3983         GDB 8.3 released.
3984
3985 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3986
3987         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3988         New variable declaration.
3989         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3990         New variable.
3991         (print_one_breakpoint): Use ui_out::test_flags and new global
3992         variable to compute use_fixed_output.
3993         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3994         Remove.
3995         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3996         (mi_multi_location_breakpoint_output_fixed): Remove.
3997         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3998         new variable.
3999         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4000         fix_multi_location_breakpoint_output flag if version >= 3.
4001         * ui-out.h (enum ui_out_flag)
4002         <fix_multi_location_breakpoint_output>: New enumerator.
4003
4004 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4005
4006         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4007
4008 2019-05-10  Tom Tromey  <tromey@adacore.com>
4009
4010         * ada-lang.c (catch_ada_completer): New function.
4011         (_initialize_ada_language): Use it.
4012
4013 2019-05-10  Tom Tromey  <tromey@adacore.com>
4014
4015         * thread.c (print_thread_info): Make "requested_threads" const.
4016         * gdbthread.h (print_thread_info): Make "requested_threads"
4017         const.
4018         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4019         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4020
4021 2019-05-08  Tom Tromey  <tom@tromey.com>
4022
4023         * gdbtypes.c (objfile_type_data): Change type.
4024         (objfile_type, _initialize_gdbtypes): Update.
4025
4026 2019-05-08  Tom Tromey  <tom@tromey.com>
4027
4028         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4029         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4030         (_initialize_dwarf2_frame): Update.
4031
4032 2019-05-08  Tom Tromey  <tom@tromey.com>
4033
4034         * objc-lang.c (objc_objfile_data): Change type.
4035         (find_methods): Update.
4036         (_initialize_objc_lang): Remove.
4037
4038 2019-05-08  Tom Tromey  <tom@tromey.com>
4039
4040         * stabsread.c (rs6000_builtin_type_data): Change type.
4041         (rs6000_builtin_type, _initialize_stabsread): Update.
4042
4043 2019-05-08  Tom Tromey  <tom@tromey.com>
4044
4045         * mips-tdep.c (mips_pdr_data): Remove.
4046         (_initialize_mips_tdep): Update.
4047
4048 2019-05-08  Tom Tromey  <tom@tromey.com>
4049
4050         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4051         (hppa_init_objfile_priv_data, read_unwind_info)
4052         (find_unwind_entry, _initialize_hppa_tdep): Update.
4053
4054 2019-05-08  Tom Tromey  <tom@tromey.com>
4055
4056         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4057         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4058         on obstack.
4059         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4060
4061 2019-05-08  Tom Tromey  <tom@tromey.com>
4062
4063         * mdebugread.c (basic_type_data): Change type.
4064         (basic_type, _initialize_mdebugread): Update.
4065
4066 2019-05-08  Tom Tromey  <tom@tromey.com>
4067
4068         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * nto-tdep.c (nto_inferior_data_reg): Change type.
4073         (nto_inferior_data): Update.
4074         (nto_inferior_data_cleanup, nto_new_inferior_data)
4075         (_initialize_nto_tdep): Remove.
4076         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4077
4078 2019-05-08  Tom Tromey  <tom@tromey.com>
4079
4080         * ada-lang.c (struct ada_inferior_data): Add initializers.
4081         (ada_inferior_data): Change type.
4082         (ada_inferior_data_cleanup): Remove.
4083         (get_ada_inferior_data, ada_inferior_exit)
4084         (struct ada_pspace_data): Add initializers, destructor.
4085         (ada_pspace_data_handle): Change type.
4086         (get_ada_pspace_data): Update.
4087         (ada_pspace_data_cleanup): Remove.
4088
4089 2019-05-08  Tom Tromey  <tom@tromey.com>
4090
4091         * coffread.c (struct coff_symfile_info): Add initializers.
4092         (coff_objfile_data_key): Move lower.  Change type.
4093         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4094         Update.
4095         (coff_free_info): Remove.
4096
4097 2019-05-08  Tom Tromey  <tom@tromey.com>
4098
4099         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4100         (fbsd_pspace_data_handle): Move lower.  Change type.
4101         (get_fbsd_pspace_data): Update.
4102         (fbsd_pspace_data_cleanup): Remove.
4103         (_initialize_fbsd_tdep): Update.
4104
4105 2019-05-08  Tom Tromey  <tom@tromey.com>
4106
4107         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4108         (get_ada_tasks_pspace_data): Update.
4109         (ada_tasks_pspace_data_cleanup): Remove.
4110         (_initialize_tasks): Update.
4111         (ada_tasks_inferior_data_handle): Change type.
4112         (get_ada_tasks_inferior_data): Update.
4113         (ada_tasks_inferior_data_cleanup): Remove.
4114         (struct ada_tasks_pspace_data): Add initializers.
4115
4116 2019-05-08  Tom Tromey  <tom@tromey.com>
4117
4118         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4119         * symfile-debug.c (debug_sym_get_probes): Change type.
4120         * stap-probe.c (handle_stap_probe):
4121         (stap_static_probe_ops::get_probes): Change type.
4122         * probe.h (class static_probe_ops) <get_probes>: Change type.
4123         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4124         (parse_probes_in_pspace): Update.
4125         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4126         Update.
4127         (any_static_probe_ops::get_probes): Change type.
4128         * elfread.c (elfread_data): New typedef.
4129         (probe_key): Change type.
4130         (elf_get_probes): Likewise.  Update.
4131         (probe_key_free): Remove.
4132         (_initialize_elfread): Update.
4133         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4134         Change type.
4135         (dtrace_process_dof_probe, dtrace_process_dof)
4136         (dtrace_static_probe_ops::get_probe): Change type.
4137
4138 2019-05-08  Tom Tromey  <tom@tromey.com>
4139
4140         * xcoffread.c (struct xcoff_symfile_info): Rename from
4141         coff_symfile_info.  Add initializers.
4142         (xcoff_objfile_data_key): Move lower.  Change type.
4143         (XCOFF_DATA): Rewrite.
4144         (xcoff_free_info): Remove.
4145         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4146         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4147         (xcoff_initial_scan): Update.
4148
4149 2019-05-08  Tom Tromey  <tom@tromey.com>
4150
4151         * solib-svr4.c (struct svr4_info): Add initializers and
4152         destructor.
4153         <probes_table>: Now an htab_up.
4154         (solib_svr4_pspace_data): Change type.
4155         (free_probes_table): Simplify.
4156         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4157         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4158         (probes_table_remove_objfile_probes, register_solib_event_probe)
4159         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4160         (_initialize_svr4_solib): Update.
4161
4162 2019-05-08  Tom Tromey  <tom@tromey.com>
4163
4164         * remote.c (remote_pspace_data): Change type.
4165         (remote_pspace_data_cleanup): Remove.
4166         (get_remote_exec_file, set_pspace_remote_exec_file)
4167         (_initialize_remote): Update.
4168
4169 2019-05-08  Tom Tromey  <tom@tromey.com>
4170
4171         * breakpoint.c (breakpoint_objfile_key): Change type.
4172         (get_breakpoint_objfile_data): Update.
4173         (free_breakpoint_objfile_data): Remove.
4174         (_initialize_breakpoint): Update.
4175
4176 2019-05-08  Tom Tromey  <tom@tromey.com>
4177
4178         * linux-tdep.c (struct linux_info): Add initializers.
4179         (linux_inferior_data): Move.  Change type.
4180         (invalidate_linux_cache_inf): Update.
4181         (linux_inferior_data_cleanup): Remove.
4182         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4183
4184 2019-05-08  Tom Tromey  <tom@tromey.com>
4185
4186         * auxv.c (auxv_inferior_data): Move.  Change type.
4187         (auxv_inferior_data_cleanup): Remove.
4188         (invalidate_auxv_cache_inf): Rewrite.
4189         (get_auxv_inferior_data, _initialize_auxv): Update.
4190
4191 2019-05-08  Tom Tromey  <tom@tromey.com>
4192
4193         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4194         (symfile_debug_objfile_data_key): Change type.
4195         (symfile_debug_installed, debug_qf_has_symbols)
4196         (debug_qf_find_last_source_symtab)
4197         (debug_qf_forget_cached_source_info)
4198         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4199         (debug_qf_print_stats, debug_qf_dump)
4200         (debug_qf_expand_symtabs_for_function)
4201         (debug_qf_expand_all_symtabs)
4202         (debug_qf_expand_symtabs_with_fullname)
4203         (debug_qf_map_matching_symbols)
4204         (debug_qf_expand_symtabs_matching)
4205         (debug_qf_find_pc_sect_compunit_symtab)
4206         (debug_qf_map_symbol_filenames)
4207         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4208         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4209         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4210         (debug_sym_read_linetable, debug_sym_relocate): Update.
4211         (symfile_debug_free_objfile): Remove.
4212         (install_symfile_debug_logging, _initialize_symfile_debug):
4213         Update.
4214
4215 2019-05-08  Tom Tromey  <tom@tromey.com>
4216
4217         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4218         allocate_on_obstack.
4219         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4220         (get_dwarf2_per_objfile): Update.
4221         (set_dwarf2_per_objfile): Remove.
4222         (dwarf2_has_info, dwarf2_get_section_info): Update.
4223         (dwarf2_free_objfile): Remove.
4224         (_initialize_dwarf2_read): Update.
4225
4226 2019-05-08  Tom Tromey  <tom@tromey.com>
4227
4228         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4229         initializers.
4230         <unsupported_script_warning_printed,
4231         script_not_found_warning_printed>: Now bool.
4232         (auto_load_pspace_data): Change type.
4233         (~auto_load_pspace_info): Rename from
4234         auto_load_pspace_data_cleanup.
4235         (get_auto_load_pspace_data, init_loaded_scripts_info)
4236         (clear_section_scripts, maybe_print_unsupported_script_warning)
4237         (maybe_print_script_not_found_warning, _initialize_auto_load):
4238         Update.
4239
4240 2019-05-08  Tom Tromey  <tom@tromey.com>
4241
4242         * objfiles.c (objfile_pspace_info): Add destructor and
4243         initializers.
4244         (objfiles_pspace_data): Change type.
4245         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4246         (get_objfile_pspace_data): Update.
4247         (objfiles_bfd_data): Change type.
4248         (get_objfile_bfd_data): Update.
4249         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4250
4251 2019-05-08  Tom Tromey  <tom@tromey.com>
4252
4253         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4254         Change type.
4255         (get_catch_syscall_inferior_data): Update.
4256         (catch_syscall_inferior_data_cleanup): Remove.
4257         (_initialize_break_catch_syscall): Update.
4258
4259 2019-05-08  Tom Tromey  <tom@tromey.com>
4260
4261         * inflow.c (struct terminal_info): Add destructor and
4262         initializers.
4263         (inflow_inferior_data): Change type.
4264         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4265         (get_inflow_inferior_data, inflow_inferior_exit)
4266         (swap_terminal_info, _initialize_inflow): Update.
4267
4268 2019-05-08  Tom Tromey  <tom@tromey.com>
4269
4270         * target-dcache.c (target_dcache_cleanup): Remove.
4271         (target_dcache_aspace_key): Change type.
4272         (target_dcache_init_p, target_dcache_invalidate)
4273         (target_dcache_get, target_dcache_get_or_init)
4274         (_initialize_target_dcache): Update.
4275         * dcache.h (struct dcache_deleter): New.
4276
4277 2019-05-08  Tom Tromey  <tom@tromey.com>
4278
4279         * symtab.c (struct symbol_cache): Add destructor and
4280         initializers.
4281         (symbol_cache_key): Move.  Change type.
4282         (make_symbol_cache, free_symbol_cache): Remove.
4283         (get_symbol_cache): Update.
4284         (symbol_cache_cleanup): Remove.
4285         (ALL_PSPACES, symbol_cache_flush)
4286         (maintenance_print_symbol_cache)
4287         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4288         Update.
4289
4290 2019-05-08  Tom Tromey  <tom@tromey.com>
4291
4292         * symtab.c (struct main_info): Add destructor and initializers.
4293         (main_progspace_key): Move.  Change type.
4294         (get_main_info): Update.
4295         (main_info_cleanup): Remove.
4296         (_initialize_symtab): Update.
4297
4298 2019-05-08  Tom Tromey  <tom@tromey.com>
4299
4300         * registry.h (DECLARE_REGISTRY): Define the _key class.
4301
4302 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4303
4304         * NEWS: Merge two 'New commands' sections.
4305
4306 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4307
4308         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4309         parameter and use Ada language definition instead.
4310         (ada_val_print_ptr): Remove unused language parameter.
4311         (ada_val_print_num): Remove language parameter and use Ada language
4312         definition instead.
4313         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4314         parameter.
4315         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4316         parameter and use Ada language definition instead.
4317         (ada_val_print_1): Update all ada_val_print_xxx calls.
4318         Remove language parameter.
4319         (ada_val_print): Update ada_val_print_1 call.
4320
4321 2019-05-08  Tom Tromey  <tromey@adacore.com>
4322
4323         * remote.c (remote_hw_watchpoint_limit)
4324         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4325         Now static.
4326
4327 2019-05-08  Tom Tromey  <tromey@adacore.com>
4328
4329         * maint.c (_initialize_maint_cmds): Move initialization code to
4330         remote.c.
4331         (watchdog, show_watchdog): Move to remote.c.
4332         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4333         "watchdog" static.
4334         (_initialize_remote): Move initialization code from maint.c.
4335         * defs.h (watchdog): Don't declare.
4336
4337 2019-05-08  Tom Tromey  <tromey@adacore.com>
4338
4339         * tui/tui-interp.c: Include main.h.
4340         * interps.c: Include main.h.
4341         * main.h (interpreter_p): Declare.
4342         * defs.h (interpreter_p): Don't declare.
4343
4344 2019-05-08  Tom Tromey  <tromey@adacore.com>
4345
4346         * dwarf2loc.c: Include dwarf2read.h.
4347         * defs.h (read_unsigned_leb128): Don't declare.
4348         * dwarf2read.h (read_unsigned_leb128): Declare.
4349
4350 2019-05-08  Tom Tromey  <tromey@adacore.com>
4351
4352         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4353         method.
4354
4355 2019-05-08  Tom Tromey  <tromey@adacore.com>
4356
4357         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4358         when no wrap column is set.
4359
4360 2019-05-08  Tom Tromey  <tromey@adacore.com>
4361
4362         * c-lang.c (c_get_string): Handle non-C-style arrays.
4363
4364 2019-05-08  Tom Tromey  <tromey@adacore.com>
4365
4366         * typeprint.c (print_offset_data::update): Print the bit offset,
4367         not the number of bits remaining.
4368
4369 2019-05-08  Tom Tromey  <tromey@adacore.com>
4370
4371         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4372         padding at end of comment.
4373
4374 2019-05-08  Tom Tromey  <tromey@adacore.com>
4375
4376         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4377         Compare main types.
4378
4379 2019-05-06  Tom Tromey  <tom@tromey.com>
4380
4381         * common/scoped_mmap.c: Include common-defs.h.
4382         * common/scoped_mmap.h: Don't include config.h.
4383
4384 2019-05-04  Tom Tromey  <tom@tromey.com>
4385
4386         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4387         (struct aarch64_call_info): Add initializers.
4388         <si>: Now a std::vector.
4389         (pass_on_stack, aarch64_push_dummy_call): Update.
4390
4391 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4392             Tom Tromey  <tom@tromey.com>
4393
4394         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4395         (ppc_threads): Now a std::vector.  Now static.
4396         (hwdebug_find_thread_points_by_tid)
4397         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4398         Update.
4399
4400 2019-05-04  Tom Tromey  <tom@tromey.com>
4401
4402         * arc-tdep.c (arc_tdesc_init): Return bool.
4403
4404 2019-05-04  Tom Tromey  <tom@tromey.com>
4405
4406         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4407         Use gdb_assert_not_reached.
4408
4409 2019-05-04  Tom Tromey  <tom@tromey.com>
4410
4411         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4412         "false".
4413
4414 2019-05-04  Tom Tromey  <tom@tromey.com>
4415
4416         * arc-tdep.c (arc_tdesc_init): Use bool.
4417
4418 2019-05-04  Tom Tromey  <tom@tromey.com>
4419
4420         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4421
4422 2019-05-04  Tom Tromey  <tom@tromey.com>
4423
4424         * cli/cli-cmds.c (valid_command_p): Return bool.
4425
4426 2019-05-04  Tom Tromey  <tom@tromey.com>
4427
4428         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4429         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4430
4431 2019-05-04  Raul Tambre  <raul@tambre.ee>
4432
4433         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4434         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4435         operator for comparison.
4436
4437 2019-05-04  Tom Tromey  <tom@tromey.com>
4438
4439         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4440         (lookup_partial_symbol, print_partial_symbols)
4441         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4442         (psymbol_compare): Update.
4443         (add_psymbol_to_bcache): Clear the entire psymbol.
4444         (maintenance_check_psymtabs): Update.
4445         * psympriv.h (struct partial_symbol): Don't derive from
4446         general_symbol_info.
4447         <obj_section, unrelocated_address, address,
4448         set_unrelocated_address>: Update.
4449         <ginfo>: New member.
4450         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4451         (debug_names::write_psymbols): Update.
4452
4453 2019-05-04  Tom de Vries  <tdevries@suse.de>
4454
4455         * contrib/cc-with-tweaks.sh: Support -n arg.
4456
4457 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4458
4459         * corelow.c (core_target::detach): Ensure frame cache and
4460         register caches are cleared.
4461         inferior.c (exit_inferior_1): Likewise.
4462
4463 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4464             Tom Tromey  <tom@tromey.com>
4465
4466         * dictionary.c (collate_pending_symbols_by_language): Remove
4467         "struct" from foreach.
4468         * symtab.c (lookup_global_symbol_from_objfile)
4469         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4470         foreach.
4471         * ser-tcp.c (net_open): Remove "struct" from foreach.
4472         * objfiles.c (objfile_relocate, objfile_rebase)
4473         (objfile_has_symbols): Remove "struct" from foreach.
4474         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4475         from foreach.
4476         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4477         foreach.
4478         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4479         "struct" from foreach.
4480         * ada-lang.c (create_excep_cond_exprs)
4481         (ada_exception_catchpoint_cond_string): Remove "struct" from
4482         foreach.
4483
4484 2019-05-03  Tom Tromey  <tromey@adacore.com>
4485
4486         * ada-exp.y (convert_char_literal): Check suffix of each
4487         enumerator.
4488
4489 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4490
4491         PR ada/21406:
4492         * ada-exp.y (yywrap): Don't define.
4493         * ada-lex.l (%option): Add noyywrap
4494         (yywrap): Remove.
4495
4496 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4497
4498         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4499         _WIN32_WINNT to the XP level, unless already defined to a higher
4500         level.
4501
4502         * unittests/parse-connection-spec-selftests.c:
4503         * ser-tcp.c:
4504         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4505         override.
4506
4507         * symfile.c (find_separate_debug_file): Remove colon from the
4508         drive spec of DOS/Windows file names of the target, so that the
4509         file name produced from DEBUGDIR and the target's directory will
4510         be valid on DOS/Windows systems.
4511
4512 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * rust-lang.c (val_print_struct): Handle printing structures
4515         containing strings.
4516
4517 2019-05-02  Tom Tromey  <tromey@adacore.com>
4518
4519         * valarith.c (_initialize_valarith): Remove.
4520
4521 2019-05-01  Tom Tromey  <tromey@adacore.com>
4522
4523         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4524         bitfields.
4525
4526 2019-05-01  Tom Tromey  <tromey@adacore.com>
4527
4528         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4529         for big-endian copies.
4530
4531 2019-04-30  Ali Tamur  <tamur@google.com>
4532         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4533         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4534         (read_3_bytes): New function.
4535
4536 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4537
4538         * windows-nat.c (main_thread_id): Delete.
4539         (handle_output_debug_string): Replace main_thread_id by
4540         current_event.dwThreadId.
4541         (fake_create_process): Likewise.
4542         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4543         Do not set main_thread_id.
4544         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4545         current_event.dwThreadId.
4546         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4547
4548 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4549
4550         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4551         Use current_event.dwThreadId instead of main_thread_id.
4552
4553 2019-04-30  Tom Tromey  <tromey@adacore.com>
4554
4555         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4556         (create_excep_cond_exprs): Iterate over program spaces.
4557         (ada_exception_catchpoint_cond_string): Examine all minimal
4558         symbols for exception types.
4559
4560 2019-04-30  Tom Tromey  <tromey@adacore.com>
4561
4562         PR c++/24470:
4563         * dwarf2read.c (process_structure_scope): Handle case where type
4564         has template parameters but no symbol was created.
4565
4566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4567             Chris January  <chris.january@arm.com>
4568
4569         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4570         qualifier.
4571         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4572
4573 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * f-typeprint.c (f_print_type): Update rules for printing
4576         whitespace.
4577         (f_type_print_varspec_suffix): Likewise.
4578
4579 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4580             Chris January  <chris.january@arm.com>
4581
4582         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4583         function arguments.
4584
4585 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * f-lang.c (build_fortran_types): Change name of void type to
4588         lower case.
4589         * f-typeprint.c (f_type_print_base): Print the name of the void
4590         type, rather than a fixed string.
4591         * f-valprint.c (f_decorations): Use lower case void string.
4592
4593 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4594             Chris January  <chris.january@arm.com>
4595
4596         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4597         types for Fortran.
4598
4599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4600             Chris January  <chris.january@arm.com>
4601             David Lecomber  <david.lecomber@arm.com>
4602
4603         * f-exp.y (BINOP_INTRINSIC): New token.
4604         (exp): New parser rule handling BINOP_INTRINSIC.
4605         (f77_keywords): Add new builtin procedures.
4606         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4607         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4608         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4609         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4610         (print_unop_subexp_f): New function.
4611         (print_binop_subexp_f): New function.
4612         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4613         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4614         (dump_subexp_body_f): Likewise.
4615         (operator_check_f): Likewise.
4616         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4617         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4618
4619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4620
4621         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4622         UNOP_KIND.
4623         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4624         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4625         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4626         (operator_length_f): New fuction.
4627         (print_subexp_f): New function.
4628         (op_name_f): New function.
4629         (dump_subexp_body_f): New function.
4630         (operator_check_f): New function.
4631         (exp_descriptor_f): Replace standard expression handling functions
4632         with new functions.
4633         * gdb/fortran-operator.def: New file.
4634         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4635         * gdb/std-operator.def: Remove UNOP_KIND.
4636
4637 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * std-operator.def: Remove unbalanced, stray double quote
4640         character.
4641
4642 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4643             Chris January  <chris.january@arm.com>
4644             Daniel Everett  <daniel.everett@arm.com>
4645             Nick Forrington  <nick.forrington@arm.com>
4646             Richard Bunt  <richard.bunt@arm.com>
4647
4648         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4649         of depth when printing anonymous structs or unions.
4650         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4651         Don't print either the top-level value, or the children if the
4652         max-depth is exceeded.
4653         (ppscm_print_children): When printing the key of a map, allow one
4654         extra level of depth.
4655         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4656         print either the top-level value, or the children if the max-depth
4657         is exceeded.
4658         (print_children): When printing the key of a map, allow one extra
4659         level of depth.
4660         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4661         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4662         (user_print_options): Initialise max_depth field.
4663         (val_print_scalar_or_string_type_p): New function.
4664         (val_print): Check to see if the max depth has been reached.
4665         (val_print_check_max_depth): Define new function.
4666         (show_print_max_depth): New function.
4667         (_initialize_valprint): Add 'print max-depth' option.
4668         * valprint.h (struct value_print_options) <max_depth>: New field.
4669         (val_print_check_max_depth): Declare new function.
4670         * NEWS: Document new feature.
4671
4672 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * ada-lang.c (ada_language_defn): Initialise new field.
4675         * c-lang.c (c_is_string_type_p): New function.
4676         (c_language_defn): Initialise new field.
4677         (cplus_language_defn): Initialise new field.
4678         (asm_language_defn): Initialise new field.
4679         (minimal_language_defn): Initialise new field.
4680         * c-lang.h (c_is_string_type_p): Declare new function.
4681         * d-lang.c (d_language_defn): Initialise new field.
4682         * f-lang.c (f_is_string_type_p): New function.
4683         (f_language_defn): Initialise new field.
4684         * go-lang.c (go_is_string_type_p): New function.
4685         (go_language_defn): Initialise new field.
4686         * language.c (default_is_string_type_p): New function.
4687         (unknown_language_defn): Initialise new field.
4688         (auto_language_defn): Initialise new field.
4689         * language.h (struct language_defn) <la_is_string_type_p>: New
4690         member variable.
4691         (default_is_string_type_p): Declare new function.
4692         * m2-lang.c (m2_language_defn): Initialise new field.
4693         * objc-lang.c (objc_language_defn): Initialise new field.
4694         * opencl-lang.c (opencl_language_defn): Initialise new field.
4695         * p-lang.c (pascal_is_string_type_p): New function.
4696         (pascal_language_defn): Initialise new field.
4697         * rust-lang.c (rust_is_string_type_p): New function.
4698         (rust_language_defn): Initialise new field.
4699
4700 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4701
4702         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4703         New field.
4704         * ada-lang.c (ada_language_defn): Initialise new field.
4705         * c-lang.c (c_language_defn): Likewise.
4706         (cplus_language_defn): Likewise.
4707         (asm_language_defn): Likewise.
4708         (minimal_language_defn): Likewise.
4709         * d-lang.c (d_language_defn): Likewise.
4710         * f-lang.c (f_language_defn): Likewise.
4711         * go-lang.c (go_language_defn): Likewise.
4712         * language.c (unknown_language_defn): Likewise.
4713         (auto_language_defn): Likewise.
4714         * m2-lang.c (m2_language_defn): Likewise.
4715         * objc-lang.c (objc_language_defn): Likewise.
4716         * opencl-lang.c (opencl_language_defn): Likewise.
4717         * p-lang.c (pascal_language_defn): Likewise.
4718         * rust-lang.c (rust_language_defn): Likewise.
4719
4720 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4721
4722         * ada-lang.c (ada_is_character_type): Change return type to bool.
4723         (ada_is_string_type): Likewise.
4724         * ada-lang.h (ada_is_character_type): Update declaration
4725         (ada_is_string_type): Likewise.
4726
4727 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4728
4729         Support style in 'frame|thread apply'
4730
4731         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4732         * record.c (record_start, record_stop): Update callers of
4733         execute_command_to_string with false.
4734         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4735         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4736         methods.
4737         (class string_file): New constructor with term_out parameter.
4738         Override methods term_out and can_emit_style_escape.  New member
4739         term_out.
4740         (class stdio_file): Override can_emit_style_escape.
4741         (class tee_file): Override term_out and can_emit_style_escape.
4742         * utils.h (can_emit_style_escape): Remove.
4743         * utils.c (can_emit_style_escape): Likewise.
4744         Update all callers of can_emit_style_escape (SOMESTREAM) to
4745         SOMESTREAM->can_emit_style_escape.
4746         * source-cache.c (source_cache::get_source_lines): Likewise.
4747         * stack.c (frame_apply_command_count): Call execute_command_to_string
4748         passing the term_out characteristic of the current gdb_stdout.
4749         * thread.c (thr_try_catch_cmd): Likewise.
4750         * top.c (execute_command_to_string): pass term_out parameter
4751         to construct the string_file for the command output.
4752         * ui-file.c (term_cli_styling): New function (most code moved
4753         from utils.c can_emit_style_escape).
4754         (string_file::string_file, string_file::can_emit_style_escape,
4755         stdio_file::can_emit_style_escape, tee_file::term_out,
4756         tee_file::can_emit_style_escape): New functions.
4757
4758 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4759
4760         * NEWS: Mention the new set|show may-call-functions.
4761         * infcall.c (may_call_functions_p): New variable.
4762         (show_may_call_functions_p): New function.
4763         (call_function_by_hand_dummy): Throws an error if not
4764         may-call-functions.
4765         (_initialize_infcall): Call add_setshow_boolean_cmd for
4766         may-call-functions.
4767
4768 2019-04-25  Keith Seitz  <keiths@redhat.com>
4769
4770         PR c++/24367
4771         * cp-support.c (inspect_type): Don't attempt substitutions
4772         of symbol with the same name.
4773
4774 2019-04-25  Tom Tromey  <tromey@adacore.com>
4775
4776         PR gdb/24475:
4777         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4778         static.
4779
4780 2019-04-25  Tom Tromey  <tromey@adacore.com>
4781
4782         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4783         rvalue reference.
4784         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4785         (gdb_xml_parser::parse): Use std::move.
4786         * python/python-internal.h (gdbpy_convert_exception): Take a const
4787         reference.
4788         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4789         std::move.
4790         * python/py-utils.c (gdbpy_convert_exception): Take a const
4791         reference.
4792         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4793         Use std::move.
4794         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4795         Use std::move.
4796         * mi/mi-main.c (mi_print_exception): Take a const reference.
4797         * main.c (handle_command_errors): Take a const reference.
4798         * linespec.c (parse_linespec): Use std::move.
4799         * infcall.c (run_inferior_call): Use std::move.
4800         (call_function_by_hand_dummy): Use std::move.
4801         * exec.c (try_open_exec_file): Use std::move.
4802         * exceptions.h (exception_print, exception_fprintf)
4803         (exception_print_same): Update.
4804         * exceptions.c (print_exception, exception_print)
4805         (exception_fprintf, exception_print_same): Change parameters to
4806         const reference.
4807         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4808         * common/new-op.c: Use std::move.
4809         * common/common-exceptions.h (struct gdb_exception): Add move
4810         constructor.
4811         (struct gdb_exception_error, struct gdb_exception_quit, struct
4812         gdb_quit_bad_alloc): Change constructor to move constructor.
4813         (throw_exception): Change parameter to rvalue reference.
4814         * common/common-exceptions.c (throw_exception): Take rvalue
4815         reference.
4816         * cli/cli-interp.c (safe_execute_command): Use std::move.
4817         * breakpoint.c (insert_bp_location, location_to_sals): Use
4818         std::move.
4819
4820 2019-04-25  Tom Tromey  <tromey@adacore.com>
4821
4822         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4823         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4824         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4825         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4826         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4827         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4828         guile/scm-value.c: Use unpack.
4829         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4830         gdbscm_gdb_exception.
4831         (gdbscm_throw_gdb_exception): Likewise.
4832         (struct gdbscm_gdb_exception): New.
4833         (unpack): New function.
4834         (gdbscm_wrap): Use unpack.
4835
4836 2019-04-25  Tom Tromey  <tromey@adacore.com>
4837
4838         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4839         (gdb_rl_callback_handler): Use std::move.
4840         * common/common-exceptions.h (struct gdb_exception): Add move
4841         assignment operator.
4842         (throw_exception_sjlj): Change "exception" to const reference.
4843         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4844         (throw_exception_sjlj): Change "exception" to const reference.
4845
4846 2019-04-25  Tom Tromey  <tromey@adacore.com>
4847
4848         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4849         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4850         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4851         Update.
4852         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4853         Update.
4854         * mi/mi-interp.c (mi_interp::exec): Update.
4855         * linespec.c (parse_linespec): Update.
4856         * infcall.c (run_inferior_call): Update.
4857         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4858         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4859         (gdbscm_lookup_global_symbol): Update.
4860         * guile/scm-param.c (gdbscm_parameter_value): Update.
4861         * guile/scm-frame.c (gdbscm_frame_read_register)
4862         (gdbscm_frame_read_var): Update.
4863         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4864         * exec.c (try_open_exec_file): Update.
4865         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4866         (gdb_rl_callback_handler): Update.
4867         * common/common-exceptions.h (exception_none): Don't declare.
4868         * common/common-exceptions.c (exception_none): Don't define.
4869         (struct catcher) <exception>: Update.
4870         * cli/cli-interp.c (safe_execute_command): Update.
4871         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4872
4873 2019-04-25  Ali Tamur  <tamur@google.com>
4874
4875         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4876         (read_attribute_value): Likewise.
4877         (dwarf2_read_addr_index): Update comment.
4878         (read_str_index): Add DW_FORM_strx.
4879         (dwarf2_string_attr): Likewise.
4880         (dwarf2_const_value_attr): Likewise.
4881         (dump_die_shallow): Likewise.
4882         (dwarf2_fetch_constant_bytes): Likewise.
4883         (skip_form_bytes): Likewise.
4884         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4885
4886 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4887
4888         PR corefiles/11608
4889         PR corefiles/18187
4890         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4891         OFFSET.  Verify if current mapping contains an ELF header.
4892         (linux_find_memory_regions_full): Adjust call to
4893         dump_mapping_p.
4894
4895 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4896             Kang Li <kanglictf@gmail.com>
4897
4898         PR gdb/21600
4899
4900         * dwarf2-frame.c (read_initial_length): Be consistent about using
4901         unsigned representation of length.
4902         (decode_frame_entry_1): Likewise.  Check for wraparound of
4903         end pointer as well as buffer overflow.
4904
4905 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4906
4907         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4908         "vq".
4909
4910 2019-04-24  Tom Tromey  <tromey@adacore.com>
4911
4912         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4913
4914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * s12z-tdep.c (s12z_unwind_pc): Delete.
4917         (s12z_unwind_sp): Delete.
4918         (s12z_gdbarch_init): Don't register deleted functions with
4919         gdbarch.
4920
4921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * rl78-tdep.c (rl78_unwind_sp): Delete.
4924         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4925
4926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4929         (xstormy16_unwind_pc): Delete.
4930         (xstormy16_dummy_id): Delete.
4931         (xstormy16_gdbarch_init): Don't register deleted functions with
4932         gdbarch.
4933
4934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * vax-tdep.c (vax_unwind_pc): Delete.
4937         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4938
4939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * v850-tdep.c (v850_unwind_sp): Delete.
4942         (v850_unwind_pc): Delete.
4943         (v850_dummy_id): Delete.
4944         (v850_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4950         (tilegx_unwind_pc): Delete.
4951         (tilegx_unwind_dummy_id): Delete.
4952         (tilegx_gdbarch_init): Don't register deleted functions with
4953         gdbarch.
4954
4955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4958         (tic6x_dummy_id): Delete.
4959         (tic6x_gdbarch_init): Don't register deleted functions with
4960         gdbarch.
4961
4962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4963
4964         * sparc-tdep.c (sparc_unwind_pc): Delete.
4965         (sparc32_gdbarch_init): Don't register deleted function with
4966         gdbarch.
4967
4968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * sh-tdep.c (sh_unwind_sp): Delete.
4971         (sh_unwind_pc): Delete.
4972         (sh_dummy_id): Delete.
4973         (sh_gdbarch_init): Don't register deleted functions with
4974         gdbarch.
4975
4976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * score-tdep.c (score_unwind_sp): Delete.
4979         (score_unwind_pc): Delete.
4980         (score_dummy_id): Delete.
4981         (score_gdbarch_init): Don't register deleted functions with
4982         gdbarch.
4983
4984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4985
4986         * rx-tdep.c (rx_unwind_pc): Delete.
4987         (rx_unwind_sp): Delete.
4988         (rx_dummy_id): Delete.
4989         (rx_gdbarch_init): Don't register deleted functions with
4990         gdbarch.  Update comment.
4991
4992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4995         (rs6000_dummy_id): Delete.
4996         (rs6000_gdbarch_init): Don't register deleted functions with
4997         gdbarch.
4998
4999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * or1k-tdep.c (or1k_dummy_id): Delete.
5002         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5003
5004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * nios2-tdep.c (nios2_dummy_id): Delete.
5007         (nios2_unwind_sp): Delete.
5008         (nios2_gdbarch_init): Don't register deleted functions with
5009         gdbarch.
5010
5011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * nds32-tdep.c (nds32_dummy_id): Delete.
5014         (nds32_unwind_pc): Delete.
5015         (nds32_unwind_sp): Delete.
5016         (nds32_gdbarch_init): Don't register deleted functions with
5017         gdbarch.
5018
5019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * msp430-tdep.c (msp430_unwind_pc): Delete.
5022         (msp430_unwind_sp): Delete.
5023         (msp430_dummy_id): Delete.
5024         (msp430_gdbarch_init): Don't register deleted functions with
5025         gdbarch.
5026
5027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * moxie-tdep.c (moxie_unwind_sp): Delete.
5030         (moxie_unwind_pc): Delete.
5031         (moxie_dummy_id): Delete.
5032         (moxie_gdbarch_init): Don't register deleted functions with
5033         gdbarch.
5034
5035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5038         (mn10300_unwind_pc): Delete.
5039         (mn10300_unwind_sp): Delete.
5040         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5041         mn10300_unwind_sp.
5042         (mn10300_frame_unwind_init): Don't register deleted functions with
5043         gdbarch.
5044
5045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * mep-tdep.c (mep_unwind_pc): Delete.
5048         (mep_unwind_sp): Delete.
5049         (mep_dummy_id): Delete.
5050         (mep_gdbarch_init): Don't register deleted functions with
5051         gdbarch.
5052
5053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5054
5055         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5056         (m68hc11_unwind_sp): Delete.
5057         (m68hc11_gdbarch_init): Don't register deleted functions with
5058         gdbarch.
5059
5060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * m32r-tdep.c (m32r_unwind_sp): Delete.
5063         (m32r_unwind_pc): Delete.
5064         (m32r_dummy_id): Delete.
5065         (m32r_gdbarch_init): Don't register deleted functions with
5066         gdbarch.
5067
5068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * m32c-tdep.c (m32c_unwind_pc): Delete.
5071         (m32c_unwind_sp): Delete.
5072         (m32c_dummy_id): Delete.
5073         (m32c_gdbarch_init): Don't register deleted functions with
5074         gdbarch.
5075
5076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5077
5078         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5079         (lm32_unwind_pc): Delete.
5080         (lm32_dummy_id): Delete.
5081         (lm32_gdbarch_init): Don't register deleted functions with
5082         gdbarch.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5087         (iq2000_unwind_pc): Delete.
5088         (iq2000_dummy_id): Delete.
5089         (iq2000_gdbarch_init): Don't register deleted functions with
5090         gdbarch.
5091
5092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * nds32-tdep.c (nds32_type_align): Delete.
5095         (nds32_push_dummy_call): Use type_align instead.
5096
5097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * arm-tdep.c (arm_type_align): Only handle vector override case.
5100         (arm_push_dummy_call): Use type_align.
5101         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5102
5103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5104
5105         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5106         case.
5107         (pass_on_stack): Use type_align.
5108         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5109         function.
5110
5111 2019-04-23  Tom Tromey  <tromey@adacore.com>
5112
5113         * dwarf2read.c (line_header::file_name_at): Remove unused
5114         overload.
5115
5116 2019-04-23  Tom de Vries  <tdevries@suse.de>
5117
5118         PR gdb/24438
5119         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5120         invocation.
5121
5122
5123 2019-03-27  Ali Tamur  <tamur@google.com>
5124
5125         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5126         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5127         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5128         (dwarf_expr_context::get_addr_index): Likewise
5129         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5130         (symbol_needs_eval_context::get_addr_index): Likewise
5131         (disassemble_dwarf_expression): Add DW_OP_addrx
5132         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5133         (read_cutu_die_from_dwo): Update comment
5134         (skip_one_die): Add DW_FORM_addrx
5135         (read_attribute_value): Likewise
5136         (var_decode_location): Add DW_OP_addrx
5137         (dwarf2_const_value_attr): Add DW_FORM_addrx
5138         (dump_die_shallow): Likewise
5139         (dwarf2_fetch_constant_bytes): Likewise
5140         (decode_locdesc): Add DW_OP_addrx
5141         (skip_form_bytes): Add DW_FORM_addrx
5142
5143 2019-04-22  Ali Tamur  <tamur@google.com>
5144
5145         * MAINTAINERS (Write After Approval): Add self.
5146
5147 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5148
5149         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5150         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5151         (open_symbol_file_object): Likewise.
5152         (svr4_default_sos): Add info parameter.
5153         (svr4_read_so_list): Likewise.
5154         (svr4_current_sos_direct): Adjust functions calls to pass down
5155         info.
5156         (svr4_current_sos_1): Add info parameter.
5157         (svr4_current_sos): Call get_svr4_info, pass info down to
5158         svr4_current_sos_1.
5159         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5160         get_svr4_info.
5161         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5162         get_svr4_info.
5163         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5164         to get_svr4_info.
5165         (probes_table_remove_objfile_probes): Likewise.
5166         (register_solib_event_probe): Add info parameter.
5167         (solist_update_incremental): Pass info parameter down to
5168         svr4_read_so_list.
5169         (disable_probes_interface): Add info parameter.
5170         (svr4_handle_solib_event): Pass current_program_space to
5171         get_svr4_info.  Adjust disable_probes_interface cleanup.
5172         (svr4_create_probe_breakpoints): Add info parameter, pass it
5173         down to register_solib_event_probe.
5174         (svr4_create_solib_event_breakpoints): Add info parameter,
5175         pass it down to svr4_create_probe_breakpoints.
5176         (enable_break): Pass info down to
5177         svr4_create_solib_event_breakpoints.
5178         (svr4_solib_create_inferior_hook): Pass current_program_space to
5179         get_svr4_info.
5180         (svr4_clear_solib): Likewise.
5181
5182 2019-04-22  Pedro Alves  <palves@redhat.com>
5183
5184         * solib-svr4.c (svr4_free_objfile_observer): New.
5185         (probe_and_action::objfile): New field.
5186         (probes_table_htab_remove_objfile_probes)
5187         (probes_table_remove_objfile_probes): New functions.
5188         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5189         in the new probe_and_action.  Don't store the probe in 'lookup'.
5190         (svr4_create_probe_breakpoints): Pass objfile to
5191         register_solib_event_probe.
5192         (_initialize_svr4_solib): Register a free_objfile observer.
5193
5194 2019-04-19  Tom Tromey  <tom@tromey.com>
5195
5196         * common/queue.h: Remove.
5197
5198 2019-04-19  Tom Tromey  <tom@tromey.com>
5199
5200         * event-loop.c: Don't include "common/queue.h".
5201
5202 2019-04-19  Tom Tromey  <tom@tromey.com>
5203
5204         * remote.c (remote_target): Use delete.
5205         * remote-notif.h: Include <list>, not "common/queue.h".
5206         (notif_client_p): Remove typedef.
5207         (remote_notif_state): Add constructor, destructor, initializer.
5208         <notif_queue>: Now a std::list.
5209         (remote_notif_state_xfree): Don't declare.
5210         * remote-notif.c (remote_notif_process, handle_notification)
5211         (remote_notif_state_allocate): Update.
5212         (~remote_notif_state): Rename from remote_notif_state_xfree.
5213
5214 2019-04-19  Tom Tromey  <tom@tromey.com>
5215
5216         * symfile.c (reread_symbols): Update.
5217         * objfiles.c (objfile_register_static_link)
5218         (objfile_lookup_static_link): Update
5219         (~objfile) Don't delete static_links.
5220         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5221
5222 2019-04-19  Tom Tromey  <tom@tromey.com>
5223
5224         * type-stack.h (struct type_stack) <insert>: Constify string.
5225         * type-stack.c (type_stack::insert): Constify string.
5226         * gdbtypes.h (lookup_template_type): Update.
5227         (address_space_name_to_int): Update.
5228         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5229         const.
5230         (lookup_template_type): Make name const.
5231         * c-exp.y: Update rules.
5232         (lex_one_token, classify_name, classify_inner_name)
5233         (c_print_token): Update.
5234         * p-exp.y: Update rules.
5235         (yylex): Update.
5236         * f-exp.y: Update rules.
5237         (yylex): Update.
5238         * d-exp.y: Update rules.
5239         (lex_one_token, classify_name, classify_inner_name): Update.
5240         * parse.c (write_dollar_variable, copy_name): Return std::string.
5241         * parser-defs.h (copy_name): Change return type.
5242         * m2-exp.y: Update rules.
5243         (yylex): Update.
5244         * go-exp.y (lex_one_token): Update.
5245         Update rules.
5246         (classify_unsafe_function, classify_packaged_name)
5247         (classify_name, yylex): Update.
5248
5249 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5250
5251         * configure.ac: add --enable-source-highlight switch.
5252         * configure: Regenerate.
5253         * top.c (print_gdb_version): plumb --enable-source-highlight
5254         status to "show configuration".
5255
5256 2019-04-19  Tom Tromey  <tromey@adacore.com>
5257
5258         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5259         Check ADA_TYPE_P.
5260         (empty_record, ada_template_to_fixed_record_type_1)
5261         (template_to_static_fixed_type)
5262         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5263         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5264         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5265         macros.
5266
5267 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5268
5269         PR symtab/24423:
5270         * source.c (print_source_lines_base): Advance "iter" when a
5271         control character is seen.
5272
5273 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5274
5275         * inferior.h (struct infcall_suspend_state_deleter):
5276         Catch exception in destructor to avoid crash.
5277
5278 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5279
5280         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5281         close to the add_com "shell".
5282
5283 2019-04-18  Tom Tromey  <tromey@adacore.com>
5284
5285         * process-stratum-target.h (class process_stratum_target)
5286         <stratum>: Add "final".
5287
5288 2019-04-17  Tom Tromey  <tromey@adacore.com>
5289
5290         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5291         against nullptr before use.
5292
5293 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5294
5295         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5296
5297 2019-04-17  Jim Wilson  <jimw@sifive.com>
5298             Andrew Burgess  <andrew.burgess@embecosm.com>
5299
5300         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5301         code read might fail, assume 4-byte breakpoint in that case.
5302
5303 2019-04-15  Leszek Swirski  <leszeks@google.com>
5304
5305         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5306         rather than a hand-rolled POD check when checking for forced MEMORY
5307         classification.
5308
5309 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5312         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5313         function.
5314         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5315         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5316         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5317         declaration.
5318
5319 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5320
5321         * aarch64-linux-nat.c
5322         (aarch64_linux_nat_target::thread_architecture): Add override.
5323         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5324         each VQ.
5325
5326 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5327
5328         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5329
5330 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5331
5332         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5333         target types of size 96-bits, add some additional comments, and
5334         check that the builtin type we found was the correct size.
5335
5336 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5337
5338         * utils.c (prompt_for_continue): Don't restore the styling at the
5339         end, as applied_style has the wrong value.  This fixes styling in
5340         long lists of file names that are interrupted by the "Continue?"
5341         prompt.
5342
5343 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5346         * c-lang.c (c_language_defn): Likewise.
5347         (cplus_language_defn): Likewise.
5348         (asm_language_defn): Likewise.
5349         (minimal_language_defn): Likewise.
5350         * d-lang.c (d_language_defn): Likewise.
5351         * f-lang.c (f_language_defn): Likewise.
5352         * go-lang.c (go_language_defn): Likewise.
5353         * language.c (unknown_language_defn): Likewise.
5354         (auto_language_defn): Likewise.
5355         * language.h (struct language_defn): Remove la_magic field.
5356         (LANG_MAGIC): Delete.
5357         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5358         * objc-lang.c (objc_language_defn): Likewise.
5359         * opencl-lang.c (opencl_language_defn): Likewise.
5360         * p-lang.c (pascal_language_defn): Likewise.
5361         * rust-lang.c (rust_language_defn): Likewise.
5362
5363 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5364
5365         * riscv-tdep.c (riscv_type_align): New function.
5366         (riscv_type_alignment): Delete.
5367         (riscv_arg_location): Use 'type_align'.
5368         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5369
5370 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5371
5372         * gdbtypes.c (type_align): A struct with no non-static fields also
5373         has alignment of 1.
5374
5375 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5378         component to 0.
5379         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5380         member.
5381         (riscv_struct_info::analyse): New implementation using new
5382         analyse_inner member function.
5383         (riscv_struct_info::field_offset): New member function.
5384         (riscv_struct_info::m_offsets): New member variable.
5385         (riscv_struct_info::analyse_inner): New private member function,
5386         takes the old implementation of riscv_struct_info::analyse but
5387         extended to track field offsets.
5388         (riscv_call_arg_struct): Update the struct folding special cases
5389         to handle cases where empty C++ structs, which are non-zero
5390         length, are found.
5391         (riscv_arg_location): Initialise the length of each location, a
5392         non-zero length now indicates the location is in use.
5393         (riscv_push_dummy_call): Allow for the first location having a
5394         non-zero offset when setting up arguments.
5395         (riscv_return_value): Likewise, but for return values.
5396
5397 2019-04-11  Tom Tromey  <tromey@adacore.com>
5398
5399         * utils.c (internal_vproblem): Make "msg" const.
5400
5401 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5402
5403         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5404         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5405         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5406         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5407
5408 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5409
5410         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5411         function.
5412         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5413         of amd64_collect_native_gregset.
5414         (amd64_linux_nat_target::store_registers): Likewise.
5415
5416 2019-04-10  Tom Tromey  <tom@tromey.com>
5417
5418         * symtab.c (lookup_global_symbol_from_objfile)
5419         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5420         * objfiles.h (class separate_debug_iterator): New.
5421         (class separate_debug_range): New.
5422         (struct objfile) <separate_debug_objfiles>: New method.
5423         (objfile_separate_debug_iterate): Don't declare.
5424         * objfiles.c (separate_debug_iterator::operator++): Rename from
5425         objfile_separate_debug_iterate.
5426         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5427         iterator.
5428         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5429         iterator.
5430
5431 2019-04-10  Tom Tromey  <tom@tromey.com>
5432
5433         * symfile.c (reread_symbols): Remove old comment.
5434         * objfiles.c (free_all_objfiles): Fix a typo.
5435
5436 2019-04-10  Tom Tromey  <tom@tromey.com>
5437
5438         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5439         * minsyms.c (lookup_minimal_symbol): Use foreach.
5440         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5441         (lookup_minimal_symbol_solib_trampoline): Likewise.
5442         * symfile.c (reread_symbols): Use foreach.
5443
5444 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5445             Tom Tromey  <tromey@adacore.com>
5446
5447         PR rust/24414:
5448         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5449         (rust_lex_int_test): Change "value" to be LONGEST.
5450         (rust_lex_tests): Add test for long integer literal.
5451
5452 2019-04-09  Tom Tromey  <tromey@adacore.com>
5453
5454         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5455         to bool.
5456         (extended_remote_target::attach): Update.
5457         (remote_target::remote_notice_new_inferior): Update.
5458         (remote_target::add_current_inferior_and_thread): Update.
5459         * inferior.c (exit_inferior_1): Use "false".
5460         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5461
5462 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5463
5464         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5465         the "start" command.
5466
5467 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5468
5469         * python/py-inferior.c (infpy_thread_from_thread_handle):
5470         Adjust comments to reflect renaming of thread_from_thread_handle
5471         to thread_from_handle.  Adjust keywords.  Fix type error message.
5472         (inferior_object_methods): Add thread_from_handle.  Retain
5473         thread_from_thread_handle, but mark it as deprecated.
5474
5475 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5476
5477         * gdbthread.h (find_thread_by_handle): Revise declaration.
5478         * thread.c (find_thread_by_handle): Likewise.  Adjust
5479         implementation too.
5480         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5481         support for buffer objects as handles.
5482
5483 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5484
5485         * python/py-infthread.c (thpy_thread_handle): New function.
5486         (thread_object_methods): Register thpy_thread_handle.
5487
5488 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5489
5490         * gdbthread.h (thread_to_thread_handle): Declare.
5491         * thread.c (gdbtypes.h): Include.
5492         (thread_to_thread_handle): New function.
5493
5494         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5495         (target_thread_info_to_thread_handle): Declare.
5496         * target.c (target_thread_info_to_thread_handle): New function.
5497         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5498         * target-delegates.c: Regenerate.
5499
5500         * linux-thread-db.c (class thread_db_target): Add method
5501         thread_info_to_thread_handle.
5502         (thread_db_target::thread_info_to_thread_handle): Define.
5503         * remote.c (class remote_target): Add new method
5504         thread_info_to_thread_handle.
5505         (remote_target::thread_info_to_thread_handle): Define.
5506
5507 2019-04-08  Pedro Alves  <palves@redhat.com>
5508
5509         * common/common-exceptions.c (throw_exception): Don't create
5510         named object to throw; throw directly.
5511         (throw_it): Likewise.  Don't initialize gdb_exception::message
5512         here, with new; pass FMT and AP to the ctor instead.
5513         * common/common-exceptions.h: Include <string>.
5514         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5515         const char *, va_list)): New ctor.  Use std::make_shared.
5516         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5517         errors)): Delete.
5518         (gdb_exception_error::gdb_exception_error(enum errors, const char
5519         *, va_list)): New.
5520         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5521         Add assertion.
5522         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5523         errors)): Delete.
5524         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5525         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5526         Add assertion.
5527
5528 2019-04-08  Tom Tromey  <tom@tromey.com>
5529
5530         * valops.c (value_rtti_indirect_type): Replace throw_exception
5531         with throw.
5532         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5533         with throw.
5534         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5535         throw.
5536         * target.c (target_translate_tls_address): Replace throw_exception
5537         with throw.
5538         * stack.c (frame_apply_command_count): Replace throw_exception
5539         with throw.
5540         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5541         throw.
5542         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5543         with throw.
5544         * rs6000-tdep.c (rs6000_frame_cache)
5545         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5546         * remote.c: Replace throw_exception with throw.
5547         * record-full.c (record_full_message, record_full_wait_1)
5548         (record_full_restore): Replace throw_exception with throw.
5549         * record-btrace.c:
5550         (get_thread_current_frame_id, record_btrace_start_replaying)
5551         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5552         (cmd_record_btrace_start): Replace throw_exception with throw.
5553         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5554         throw.
5555         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5556         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5557         * linespec.c:
5558         (find_linespec_symbols): Replace throw_exception with throw.
5559         * infrun.c (displaced_step_prepare, resume): Replace
5560         throw_exception with throw.
5561         * infcmd.c (post_create_inferior): Replace throw_exception with
5562         throw.
5563         * inf-loop.c (inferior_event_handler): Replace throw_exception
5564         with throw.
5565         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5566         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5567         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5568         (get_prev_frame_always, get_frame_pc_if_available)
5569         (get_frame_address_in_block_if_available, get_frame_language):
5570         Replace throw_exception with throw.
5571         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5572         throw_exception with throw.
5573         * eval.c (fetch_subexp_value, evaluate_var_value)
5574         (evaluate_funcall, evaluate_subexp_standard): Replace
5575         throw_exception with throw.
5576         * dwarf2loc.c (call_site_find_chain)
5577         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5578         Replace throw_exception with throw.
5579         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5580         with throw.
5581         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5582         throw.
5583         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5584         * completer.c (complete_line_internal): Replace throw_exception
5585         with throw.
5586         * compile/compile-object-run.c (compile_object_run): Replace
5587         throw_exception with throw.
5588         * cli/cli-script.c (process_next_line): Replace throw_exception
5589         with throw.
5590         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5591         (btrace_enable, btrace_maint_update_pt_packets): Replace
5592         throw_exception with throw.
5593         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5594         throw_exception with throw.
5595         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5596         throw_exception with throw.
5597         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5598         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5599         * aarch64-tdep.c (aarch64_make_prologue_cache)
5600         (aarch64_make_stub_cache): Replace throw_exception with throw.
5601
5602 2019-04-08  Tom Tromey  <tom@tromey.com>
5603
5604         * common/common-exceptions.c (throw_exception): Rename from
5605         throw_exception_cxx.  Remove old copy.  Make argument const.
5606         (throw_it): Create and throw exception objects directly.
5607         * common/common-exceptions.h (throw_exception): Make argument
5608         const.
5609         (struct gdb_exception_error): Add constructor.
5610         (struct gdb_exception_quit): Add constructor.
5611
5612 2019-04-08  Tom Tromey  <tom@tromey.com>
5613
5614         * common/common-exceptions.h (exception_rethrow): Don't declare.
5615         (TRY_SJLJ): Update comment.
5616         (TRY, CATCH, END_CATCH): Remove.
5617         * common/common-exceptions.c (exception_rethrow): Remove.
5618
5619 2019-04-08  Tom Tromey  <tom@tromey.com>
5620
5621         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5622         Remove.
5623         (gdb_exception_error): Rename from
5624         gdb_exception_RETURN_MASK_ERROR.
5625         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5626         (gdb_quit_bad_alloc): Update.
5627         * aarch64-tdep.c: Update.
5628         * ada-lang.c: Update.
5629         * ada-typeprint.c: Update.
5630         * ada-valprint.c: Update.
5631         * amd64-tdep.c: Update.
5632         * arch-utils.c: Update.
5633         * break-catch-throw.c: Update.
5634         * breakpoint.c: Update.
5635         * btrace.c: Update.
5636         * c-varobj.c: Update.
5637         * cli/cli-cmds.c: Update.
5638         * cli/cli-interp.c: Update.
5639         * cli/cli-script.c: Update.
5640         * common/common-exceptions.c: Update.
5641         * common/new-op.c: Update.
5642         * common/selftest.c: Update.
5643         * compile/compile-c-symbols.c: Update.
5644         * compile/compile-cplus-symbols.c: Update.
5645         * compile/compile-object-load.c: Update.
5646         * compile/compile-object-run.c: Update.
5647         * completer.c: Update.
5648         * corelow.c: Update.
5649         * cp-abi.c: Update.
5650         * cp-support.c: Update.
5651         * cp-valprint.c: Update.
5652         * darwin-nat.c: Update.
5653         * disasm-selftests.c: Update.
5654         * dtrace-probe.c: Update.
5655         * dwarf-index-cache.c: Update.
5656         * dwarf-index-write.c: Update.
5657         * dwarf2-frame-tailcall.c: Update.
5658         * dwarf2-frame.c: Update.
5659         * dwarf2loc.c: Update.
5660         * dwarf2read.c: Update.
5661         * eval.c: Update.
5662         * event-loop.c: Update.
5663         * event-top.c: Update.
5664         * exec.c: Update.
5665         * f-valprint.c: Update.
5666         * fbsd-tdep.c: Update.
5667         * frame-unwind.c: Update.
5668         * frame.c: Update.
5669         * gdbtypes.c: Update.
5670         * gnu-v3-abi.c: Update.
5671         * guile/guile-internal.h: Update.
5672         * guile/scm-block.c: Update.
5673         * guile/scm-breakpoint.c: Update.
5674         * guile/scm-cmd.c: Update.
5675         * guile/scm-disasm.c: Update.
5676         * guile/scm-frame.c: Update.
5677         * guile/scm-lazy-string.c: Update.
5678         * guile/scm-math.c: Update.
5679         * guile/scm-param.c: Update.
5680         * guile/scm-ports.c: Update.
5681         * guile/scm-pretty-print.c: Update.
5682         * guile/scm-symbol.c: Update.
5683         * guile/scm-symtab.c: Update.
5684         * guile/scm-type.c: Update.
5685         * guile/scm-value.c: Update.
5686         * i386-linux-tdep.c: Update.
5687         * i386-tdep.c: Update.
5688         * inf-loop.c: Update.
5689         * infcall.c: Update.
5690         * infcmd.c: Update.
5691         * infrun.c: Update.
5692         * jit.c: Update.
5693         * language.c: Update.
5694         * linespec.c: Update.
5695         * linux-fork.c: Update.
5696         * linux-nat.c: Update.
5697         * linux-tdep.c: Update.
5698         * linux-thread-db.c: Update.
5699         * main.c: Update.
5700         * mi/mi-cmd-break.c: Update.
5701         * mi/mi-cmd-stack.c: Update.
5702         * mi/mi-interp.c: Update.
5703         * mi/mi-main.c: Update.
5704         * objc-lang.c: Update.
5705         * p-valprint.c: Update.
5706         * parse.c: Update.
5707         * ppc-linux-tdep.c: Update.
5708         * printcmd.c: Update.
5709         * python/py-arch.c: Update.
5710         * python/py-breakpoint.c: Update.
5711         * python/py-cmd.c: Update.
5712         * python/py-finishbreakpoint.c: Update.
5713         * python/py-frame.c: Update.
5714         * python/py-framefilter.c: Update.
5715         * python/py-gdb-readline.c: Update.
5716         * python/py-inferior.c: Update.
5717         * python/py-infthread.c: Update.
5718         * python/py-lazy-string.c: Update.
5719         * python/py-linetable.c: Update.
5720         * python/py-objfile.c: Update.
5721         * python/py-param.c: Update.
5722         * python/py-prettyprint.c: Update.
5723         * python/py-progspace.c: Update.
5724         * python/py-record-btrace.c: Update.
5725         * python/py-record.c: Update.
5726         * python/py-symbol.c: Update.
5727         * python/py-type.c: Update.
5728         * python/py-unwind.c: Update.
5729         * python/py-utils.c: Update.
5730         * python/py-value.c: Update.
5731         * python/python.c: Update.
5732         * record-btrace.c: Update.
5733         * record-full.c: Update.
5734         * remote-fileio.c: Update.
5735         * remote.c: Update.
5736         * riscv-tdep.c: Update.
5737         * rs6000-aix-tdep.c: Update.
5738         * rs6000-tdep.c: Update.
5739         * rust-exp.y: Update.
5740         * rust-lang.c: Update.
5741         * s390-tdep.c: Update.
5742         * selftest-arch.c: Update.
5743         * solib-dsbt.c: Update.
5744         * solib-frv.c: Update.
5745         * solib-spu.c: Update.
5746         * solib-svr4.c: Update.
5747         * solib.c: Update.
5748         * sparc64-linux-tdep.c: Update.
5749         * stack.c: Update.
5750         * symfile-mem.c: Update.
5751         * symmisc.c: Update.
5752         * target.c: Update.
5753         * thread.c: Update.
5754         * top.c: Update.
5755         * tracefile-tfile.c: Update.
5756         * tui/tui.c: Update.
5757         * typeprint.c: Update.
5758         * unittests/cli-utils-selftests.c: Update.
5759         * unittests/parse-connection-spec-selftests.c: Update.
5760         * valops.c: Update.
5761         * valprint.c: Update.
5762         * value.c: Update.
5763         * varobj.c: Update.
5764         * windows-nat.c: Update.
5765         * x86-linux-nat.c: Update.
5766         * xml-support.c: Update.
5767
5768 2019-04-08  Tom Tromey  <tom@tromey.com>
5769
5770         * xml-support.c: Use C++ exception handling.
5771         * x86-linux-nat.c: Use C++ exception handling.
5772         * windows-nat.c: Use C++ exception handling.
5773         * varobj.c: Use C++ exception handling.
5774         * value.c: Use C++ exception handling.
5775         * valprint.c: Use C++ exception handling.
5776         * valops.c: Use C++ exception handling.
5777         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5778         handling.
5779         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5780         * typeprint.c: Use C++ exception handling.
5781         * tui/tui.c: Use C++ exception handling.
5782         * tracefile-tfile.c: Use C++ exception handling.
5783         * top.c: Use C++ exception handling.
5784         * thread.c: Use C++ exception handling.
5785         * target.c: Use C++ exception handling.
5786         * symmisc.c: Use C++ exception handling.
5787         * symfile-mem.c: Use C++ exception handling.
5788         * stack.c: Use C++ exception handling.
5789         * sparc64-linux-tdep.c: Use C++ exception handling.
5790         * solib.c: Use C++ exception handling.
5791         * solib-svr4.c: Use C++ exception handling.
5792         * solib-spu.c: Use C++ exception handling.
5793         * solib-frv.c: Use C++ exception handling.
5794         * solib-dsbt.c: Use C++ exception handling.
5795         * selftest-arch.c: Use C++ exception handling.
5796         * s390-tdep.c: Use C++ exception handling.
5797         * rust-lang.c: Use C++ exception handling.
5798         * rust-exp.y: Use C++ exception handling.
5799         * rs6000-tdep.c: Use C++ exception handling.
5800         * rs6000-aix-tdep.c: Use C++ exception handling.
5801         * riscv-tdep.c: Use C++ exception handling.
5802         * remote.c: Use C++ exception handling.
5803         * remote-fileio.c: Use C++ exception handling.
5804         * record-full.c: Use C++ exception handling.
5805         * record-btrace.c: Use C++ exception handling.
5806         * python/python.c: Use C++ exception handling.
5807         * python/py-value.c: Use C++ exception handling.
5808         * python/py-utils.c: Use C++ exception handling.
5809         * python/py-unwind.c: Use C++ exception handling.
5810         * python/py-type.c: Use C++ exception handling.
5811         * python/py-symbol.c: Use C++ exception handling.
5812         * python/py-record.c: Use C++ exception handling.
5813         * python/py-record-btrace.c: Use C++ exception handling.
5814         * python/py-progspace.c: Use C++ exception handling.
5815         * python/py-prettyprint.c: Use C++ exception handling.
5816         * python/py-param.c: Use C++ exception handling.
5817         * python/py-objfile.c: Use C++ exception handling.
5818         * python/py-linetable.c: Use C++ exception handling.
5819         * python/py-lazy-string.c: Use C++ exception handling.
5820         * python/py-infthread.c: Use C++ exception handling.
5821         * python/py-inferior.c: Use C++ exception handling.
5822         * python/py-gdb-readline.c: Use C++ exception handling.
5823         * python/py-framefilter.c: Use C++ exception handling.
5824         * python/py-frame.c: Use C++ exception handling.
5825         * python/py-finishbreakpoint.c: Use C++ exception handling.
5826         * python/py-cmd.c: Use C++ exception handling.
5827         * python/py-breakpoint.c: Use C++ exception handling.
5828         * python/py-arch.c: Use C++ exception handling.
5829         * printcmd.c: Use C++ exception handling.
5830         * ppc-linux-tdep.c: Use C++ exception handling.
5831         * parse.c: Use C++ exception handling.
5832         * p-valprint.c: Use C++ exception handling.
5833         * objc-lang.c: Use C++ exception handling.
5834         * mi/mi-main.c: Use C++ exception handling.
5835         * mi/mi-interp.c: Use C++ exception handling.
5836         * mi/mi-cmd-stack.c: Use C++ exception handling.
5837         * mi/mi-cmd-break.c: Use C++ exception handling.
5838         * main.c: Use C++ exception handling.
5839         * linux-thread-db.c: Use C++ exception handling.
5840         * linux-tdep.c: Use C++ exception handling.
5841         * linux-nat.c: Use C++ exception handling.
5842         * linux-fork.c: Use C++ exception handling.
5843         * linespec.c: Use C++ exception handling.
5844         * language.c: Use C++ exception handling.
5845         * jit.c: Use C++ exception handling.
5846         * infrun.c: Use C++ exception handling.
5847         * infcmd.c: Use C++ exception handling.
5848         * infcall.c: Use C++ exception handling.
5849         * inf-loop.c: Use C++ exception handling.
5850         * i386-tdep.c: Use C++ exception handling.
5851         * i386-linux-tdep.c: Use C++ exception handling.
5852         * guile/scm-value.c: Use C++ exception handling.
5853         * guile/scm-type.c: Use C++ exception handling.
5854         * guile/scm-symtab.c: Use C++ exception handling.
5855         * guile/scm-symbol.c: Use C++ exception handling.
5856         * guile/scm-pretty-print.c: Use C++ exception handling.
5857         * guile/scm-ports.c: Use C++ exception handling.
5858         * guile/scm-param.c: Use C++ exception handling.
5859         * guile/scm-math.c: Use C++ exception handling.
5860         * guile/scm-lazy-string.c: Use C++ exception handling.
5861         * guile/scm-frame.c: Use C++ exception handling.
5862         * guile/scm-disasm.c: Use C++ exception handling.
5863         * guile/scm-cmd.c: Use C++ exception handling.
5864         * guile/scm-breakpoint.c: Use C++ exception handling.
5865         * guile/scm-block.c: Use C++ exception handling.
5866         * guile/guile-internal.h: Use C++ exception handling.
5867         * gnu-v3-abi.c: Use C++ exception handling.
5868         * gdbtypes.c: Use C++ exception handling.
5869         * frame.c: Use C++ exception handling.
5870         * frame-unwind.c: Use C++ exception handling.
5871         * fbsd-tdep.c: Use C++ exception handling.
5872         * f-valprint.c: Use C++ exception handling.
5873         * exec.c: Use C++ exception handling.
5874         * event-top.c: Use C++ exception handling.
5875         * event-loop.c: Use C++ exception handling.
5876         * eval.c: Use C++ exception handling.
5877         * dwarf2read.c: Use C++ exception handling.
5878         * dwarf2loc.c: Use C++ exception handling.
5879         * dwarf2-frame.c: Use C++ exception handling.
5880         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5881         * dwarf-index-write.c: Use C++ exception handling.
5882         * dwarf-index-cache.c: Use C++ exception handling.
5883         * dtrace-probe.c: Use C++ exception handling.
5884         * disasm-selftests.c: Use C++ exception handling.
5885         * darwin-nat.c: Use C++ exception handling.
5886         * cp-valprint.c: Use C++ exception handling.
5887         * cp-support.c: Use C++ exception handling.
5888         * cp-abi.c: Use C++ exception handling.
5889         * corelow.c: Use C++ exception handling.
5890         * completer.c: Use C++ exception handling.
5891         * compile/compile-object-run.c: Use C++ exception handling.
5892         * compile/compile-object-load.c: Use C++ exception handling.
5893         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5894         * compile/compile-c-symbols.c: Use C++ exception handling.
5895         * common/selftest.c: Use C++ exception handling.
5896         * common/new-op.c: Use C++ exception handling.
5897         * cli/cli-script.c: Use C++ exception handling.
5898         * cli/cli-interp.c: Use C++ exception handling.
5899         * cli/cli-cmds.c: Use C++ exception handling.
5900         * c-varobj.c: Use C++ exception handling.
5901         * btrace.c: Use C++ exception handling.
5902         * breakpoint.c: Use C++ exception handling.
5903         * break-catch-throw.c: Use C++ exception handling.
5904         * arch-utils.c: Use C++ exception handling.
5905         * amd64-tdep.c: Use C++ exception handling.
5906         * ada-valprint.c: Use C++ exception handling.
5907         * ada-typeprint.c: Use C++ exception handling.
5908         * ada-lang.c: Use C++ exception handling.
5909         * aarch64-tdep.c: Use C++ exception handling.
5910
5911 2019-04-08  Tom Tromey  <tom@tromey.com>
5912
5913         * xml-support.c (gdb_xml_parser::parse): Update.
5914         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5915         * value.c (show_convenience): Update.
5916         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5917         (test_parse_flags_qcs): Update.
5918         * thread.c (thr_try_catch_cmd): Update.
5919         * target.c (target_translate_tls_address): Update.
5920         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5921         (info_frame_command_core, frame_apply_command_count): Update.
5922         * rust-exp.y (rust_lex_exception_test): Update.
5923         * riscv-tdep.c (riscv_print_one_register_info): Update.
5924         * remote.c (remote_target::enable_btrace): Update.
5925         * record-btrace.c (record_btrace_enable_warn): Update.
5926         * python/py-utils.c (gdbpy_convert_exception): Update.
5927         * printcmd.c (do_one_display, print_variable_and_value): Update.
5928         * mi/mi-main.c (mi_print_exception): Update.
5929         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5930         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5931         * linux-nat.c (linux_nat_target::attach): Update.
5932         * linux-fork.c (class scoped_switch_fork_info): Update.
5933         * infrun.c (displaced_step_prepare): Update.
5934         * infcall.c (call_function_by_hand_dummy): Update.
5935         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5936         * gnu-v3-abi.c (print_one_vtable): Update.
5937         * frame.c (get_prev_frame_always): Update.
5938         * f-valprint.c (info_common_command_for_block): Update.
5939         * exec.c (try_open_exec_file): Update.
5940         * exceptions.c (print_exception, exception_print)
5941         (exception_fprintf, exception_print_same): Update.
5942         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5943         * dwarf-index-cache.c (index_cache::store)
5944         (index_cache::lookup_gdb_index): Update.
5945         * darwin-nat.c (maybe_cache_shell): Update.
5946         * cp-valprint.c (cp_print_value_fields): Update.
5947         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5948         (gcc_cplus_symbol_address): Update.
5949         * compile/compile-c-symbols.c (gcc_convert_symbol)
5950         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5951         * common/selftest.c: Update.
5952         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5953         a std::string.
5954         (exception_try_scope_entry, exception_try_scope_exit): Don't
5955         declare.
5956         (struct exception_try_scope): Remove.
5957         (TRY): Don't use exception_try_scope.
5958         (struct gdb_exception): Add constructor, operator=.
5959         <what>: New method.
5960         (struct gdb_exception_RETURN_MASK_ALL)
5961         (struct gdb_exception_RETURN_MASK_ERROR)
5962         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5963         (struct gdb_quit_bad_alloc): Update.
5964         * common/common-exceptions.c (exception_none): Change
5965         initializer.
5966         (struct catcher) <state, exception>: Initialize inline.
5967         <prev>: Remove member.
5968         (current_catcher): Remove.
5969         (catchers): New global.
5970         (exceptions_state_mc_init): Simplify.
5971         (catcher_pop): Remove.
5972         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5973         (try_scope_depth, exception_try_scope_entry)
5974         (exception_try_scope_exit): Remove.
5975         (throw_exception_sjlj): Update.
5976         (exception_messages, exception_messages_size): Remove.
5977         (throw_it): Simplify.
5978         (gdb_exception_sliced_copy): Remove.
5979         (throw_exception_cxx): Update.
5980         * cli/cli-script.c (script_from_file): Update.
5981         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5982         Update.
5983         * ada-valprint.c (ada_val_print): Update.
5984         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5985         (create_excep_cond_exprs): Update.
5986
5987 2019-04-08  Tom Tromey  <tom@tromey.com>
5988
5989         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5990         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5991         (TRY, CATCH, END_CATCH): Remove some definitions.
5992         * common/common-exceptions.c: Don't use GDB_XCPT.
5993         (catcher_list_size): Remove.
5994         (throw_exception, throw_it): Simplify.
5995
5996 2019-04-05  Tom Tromey  <tom@tromey.com>
5997
5998         Revert the header-sorting patch.
5999         * ft32-tdep.c: Revert.
6000         * frv-tdep.c: Revert.
6001         * frv-linux-tdep.c: Revert.
6002         * frame.c: Revert.
6003         * frame-unwind.c: Revert.
6004         * frame-base.c: Revert.
6005         * fork-child.c: Revert.
6006         * findvar.c: Revert.
6007         * findcmd.c: Revert.
6008         * filesystem.c: Revert.
6009         * filename-seen-cache.h: Revert.
6010         * filename-seen-cache.c: Revert.
6011         * fbsd-tdep.c: Revert.
6012         * fbsd-nat.h: Revert.
6013         * fbsd-nat.c: Revert.
6014         * f-valprint.c: Revert.
6015         * f-typeprint.c: Revert.
6016         * f-lang.c: Revert.
6017         * extension.h: Revert.
6018         * extension.c: Revert.
6019         * extension-priv.h: Revert.
6020         * expprint.c: Revert.
6021         * exec.h: Revert.
6022         * exec.c: Revert.
6023         * exceptions.c: Revert.
6024         * event-top.c: Revert.
6025         * event-loop.c: Revert.
6026         * eval.c: Revert.
6027         * elfread.c: Revert.
6028         * dwarf2read.h: Revert.
6029         * dwarf2read.c: Revert.
6030         * dwarf2loc.c: Revert.
6031         * dwarf2expr.h: Revert.
6032         * dwarf2expr.c: Revert.
6033         * dwarf2-frame.c: Revert.
6034         * dwarf2-frame-tailcall.c: Revert.
6035         * dwarf-index-write.h: Revert.
6036         * dwarf-index-write.c: Revert.
6037         * dwarf-index-common.c: Revert.
6038         * dwarf-index-cache.h: Revert.
6039         * dwarf-index-cache.c: Revert.
6040         * dummy-frame.c: Revert.
6041         * dtrace-probe.c: Revert.
6042         * disasm.h: Revert.
6043         * disasm.c: Revert.
6044         * disasm-selftests.c: Revert.
6045         * dictionary.c: Revert.
6046         * dicos-tdep.c: Revert.
6047         * demangle.c: Revert.
6048         * dcache.h: Revert.
6049         * dcache.c: Revert.
6050         * darwin-nat.h: Revert.
6051         * darwin-nat.c: Revert.
6052         * darwin-nat-info.c: Revert.
6053         * d-valprint.c: Revert.
6054         * d-namespace.c: Revert.
6055         * d-lang.c: Revert.
6056         * ctf.c: Revert.
6057         * csky-tdep.c: Revert.
6058         * csky-linux-tdep.c: Revert.
6059         * cris-tdep.c: Revert.
6060         * cris-linux-tdep.c: Revert.
6061         * cp-valprint.c: Revert.
6062         * cp-support.c: Revert.
6063         * cp-namespace.c: Revert.
6064         * cp-abi.c: Revert.
6065         * corelow.c: Revert.
6066         * corefile.c: Revert.
6067         * continuations.c: Revert.
6068         * completer.h: Revert.
6069         * completer.c: Revert.
6070         * complaints.c: Revert.
6071         * coffread.c: Revert.
6072         * coff-pe-read.c: Revert.
6073         * cli-out.h: Revert.
6074         * cli-out.c: Revert.
6075         * charset.c: Revert.
6076         * c-varobj.c: Revert.
6077         * c-valprint.c: Revert.
6078         * c-typeprint.c: Revert.
6079         * c-lang.c: Revert.
6080         * buildsym.c: Revert.
6081         * buildsym-legacy.c: Revert.
6082         * build-id.h: Revert.
6083         * build-id.c: Revert.
6084         * btrace.c: Revert.
6085         * bsd-uthread.c: Revert.
6086         * breakpoint.h: Revert.
6087         * breakpoint.c: Revert.
6088         * break-catch-throw.c: Revert.
6089         * break-catch-syscall.c: Revert.
6090         * break-catch-sig.c: Revert.
6091         * blockframe.c: Revert.
6092         * block.c: Revert.
6093         * bfin-tdep.c: Revert.
6094         * bfin-linux-tdep.c: Revert.
6095         * bfd-target.c: Revert.
6096         * bcache.c: Revert.
6097         * ax-general.c: Revert.
6098         * ax-gdb.h: Revert.
6099         * ax-gdb.c: Revert.
6100         * avr-tdep.c: Revert.
6101         * auxv.c: Revert.
6102         * auto-load.c: Revert.
6103         * arm-wince-tdep.c: Revert.
6104         * arm-tdep.c: Revert.
6105         * arm-symbian-tdep.c: Revert.
6106         * arm-pikeos-tdep.c: Revert.
6107         * arm-obsd-tdep.c: Revert.
6108         * arm-nbsd-tdep.c: Revert.
6109         * arm-nbsd-nat.c: Revert.
6110         * arm-linux-tdep.c: Revert.
6111         * arm-linux-nat.c: Revert.
6112         * arm-fbsd-tdep.c: Revert.
6113         * arm-fbsd-nat.c: Revert.
6114         * arm-bsd-tdep.c: Revert.
6115         * arch-utils.c: Revert.
6116         * arc-tdep.c: Revert.
6117         * arc-newlib-tdep.c: Revert.
6118         * annotate.h: Revert.
6119         * annotate.c: Revert.
6120         * amd64-windows-tdep.c: Revert.
6121         * amd64-windows-nat.c: Revert.
6122         * amd64-tdep.c: Revert.
6123         * amd64-sol2-tdep.c: Revert.
6124         * amd64-obsd-tdep.c: Revert.
6125         * amd64-obsd-nat.c: Revert.
6126         * amd64-nbsd-tdep.c: Revert.
6127         * amd64-nbsd-nat.c: Revert.
6128         * amd64-nat.c: Revert.
6129         * amd64-linux-tdep.c: Revert.
6130         * amd64-linux-nat.c: Revert.
6131         * amd64-fbsd-tdep.c: Revert.
6132         * amd64-fbsd-nat.c: Revert.
6133         * amd64-dicos-tdep.c: Revert.
6134         * amd64-darwin-tdep.c: Revert.
6135         * amd64-bsd-nat.c: Revert.
6136         * alpha-tdep.c: Revert.
6137         * alpha-obsd-tdep.c: Revert.
6138         * alpha-nbsd-tdep.c: Revert.
6139         * alpha-mdebug-tdep.c: Revert.
6140         * alpha-linux-tdep.c: Revert.
6141         * alpha-linux-nat.c: Revert.
6142         * alpha-bsd-tdep.c: Revert.
6143         * alpha-bsd-nat.c: Revert.
6144         * aix-thread.c: Revert.
6145         * agent.c: Revert.
6146         * addrmap.c: Revert.
6147         * ada-varobj.c: Revert.
6148         * ada-valprint.c: Revert.
6149         * ada-typeprint.c: Revert.
6150         * ada-tasks.c: Revert.
6151         * ada-lang.c: Revert.
6152         * aarch64-tdep.c: Revert.
6153         * aarch64-ravenscar-thread.c: Revert.
6154         * aarch64-newlib-tdep.c: Revert.
6155         * aarch64-linux-tdep.c: Revert.
6156         * aarch64-linux-nat.c: Revert.
6157         * aarch64-fbsd-tdep.c: Revert.
6158         * aarch64-fbsd-nat.c: Revert.
6159         * aarch32-linux-nat.c: Revert.
6160
6161 2019-04-05  Tom Tromey  <tom@tromey.com>
6162
6163         * ft32-tdep.c: Sort headers.
6164         * frv-tdep.c: Sort headers.
6165         * frv-linux-tdep.c: Sort headers.
6166         * frame.c: Sort headers.
6167         * frame-unwind.c: Sort headers.
6168         * frame-base.c: Sort headers.
6169         * fork-child.c: Sort headers.
6170         * findvar.c: Sort headers.
6171         * findcmd.c: Sort headers.
6172         * filesystem.c: Sort headers.
6173         * filename-seen-cache.h: Sort headers.
6174         * filename-seen-cache.c: Sort headers.
6175         * fbsd-tdep.c: Sort headers.
6176         * fbsd-nat.h: Sort headers.
6177         * fbsd-nat.c: Sort headers.
6178         * f-valprint.c: Sort headers.
6179         * f-typeprint.c: Sort headers.
6180         * f-lang.c: Sort headers.
6181         * extension.h: Sort headers.
6182         * extension.c: Sort headers.
6183         * extension-priv.h: Sort headers.
6184         * expprint.c: Sort headers.
6185         * exec.h: Sort headers.
6186         * exec.c: Sort headers.
6187         * exceptions.c: Sort headers.
6188         * event-top.c: Sort headers.
6189         * event-loop.c: Sort headers.
6190         * eval.c: Sort headers.
6191         * elfread.c: Sort headers.
6192         * dwarf2read.h: Sort headers.
6193         * dwarf2read.c: Sort headers.
6194         * dwarf2loc.c: Sort headers.
6195         * dwarf2expr.h: Sort headers.
6196         * dwarf2expr.c: Sort headers.
6197         * dwarf2-frame.c: Sort headers.
6198         * dwarf2-frame-tailcall.c: Sort headers.
6199         * dwarf-index-write.h: Sort headers.
6200         * dwarf-index-write.c: Sort headers.
6201         * dwarf-index-common.c: Sort headers.
6202         * dwarf-index-cache.h: Sort headers.
6203         * dwarf-index-cache.c: Sort headers.
6204         * dummy-frame.c: Sort headers.
6205         * dtrace-probe.c: Sort headers.
6206         * disasm.h: Sort headers.
6207         * disasm.c: Sort headers.
6208         * disasm-selftests.c: Sort headers.
6209         * dictionary.c: Sort headers.
6210         * dicos-tdep.c: Sort headers.
6211         * demangle.c: Sort headers.
6212         * dcache.h: Sort headers.
6213         * dcache.c: Sort headers.
6214         * darwin-nat.h: Sort headers.
6215         * darwin-nat.c: Sort headers.
6216         * darwin-nat-info.c: Sort headers.
6217         * d-valprint.c: Sort headers.
6218         * d-namespace.c: Sort headers.
6219         * d-lang.c: Sort headers.
6220         * ctf.c: Sort headers.
6221         * csky-tdep.c: Sort headers.
6222         * csky-linux-tdep.c: Sort headers.
6223         * cris-tdep.c: Sort headers.
6224         * cris-linux-tdep.c: Sort headers.
6225         * cp-valprint.c: Sort headers.
6226         * cp-support.c: Sort headers.
6227         * cp-namespace.c: Sort headers.
6228         * cp-abi.c: Sort headers.
6229         * corelow.c: Sort headers.
6230         * corefile.c: Sort headers.
6231         * continuations.c: Sort headers.
6232         * completer.h: Sort headers.
6233         * completer.c: Sort headers.
6234         * complaints.c: Sort headers.
6235         * coffread.c: Sort headers.
6236         * coff-pe-read.c: Sort headers.
6237         * cli-out.h: Sort headers.
6238         * cli-out.c: Sort headers.
6239         * charset.c: Sort headers.
6240         * c-varobj.c: Sort headers.
6241         * c-valprint.c: Sort headers.
6242         * c-typeprint.c: Sort headers.
6243         * c-lang.c: Sort headers.
6244         * buildsym.c: Sort headers.
6245         * buildsym-legacy.c: Sort headers.
6246         * build-id.h: Sort headers.
6247         * build-id.c: Sort headers.
6248         * btrace.c: Sort headers.
6249         * bsd-uthread.c: Sort headers.
6250         * breakpoint.h: Sort headers.
6251         * breakpoint.c: Sort headers.
6252         * break-catch-throw.c: Sort headers.
6253         * break-catch-syscall.c: Sort headers.
6254         * break-catch-sig.c: Sort headers.
6255         * blockframe.c: Sort headers.
6256         * block.c: Sort headers.
6257         * bfin-tdep.c: Sort headers.
6258         * bfin-linux-tdep.c: Sort headers.
6259         * bfd-target.c: Sort headers.
6260         * bcache.c: Sort headers.
6261         * ax-general.c: Sort headers.
6262         * ax-gdb.h: Sort headers.
6263         * ax-gdb.c: Sort headers.
6264         * avr-tdep.c: Sort headers.
6265         * auxv.c: Sort headers.
6266         * auto-load.c: Sort headers.
6267         * arm-wince-tdep.c: Sort headers.
6268         * arm-tdep.c: Sort headers.
6269         * arm-symbian-tdep.c: Sort headers.
6270         * arm-pikeos-tdep.c: Sort headers.
6271         * arm-obsd-tdep.c: Sort headers.
6272         * arm-nbsd-tdep.c: Sort headers.
6273         * arm-nbsd-nat.c: Sort headers.
6274         * arm-linux-tdep.c: Sort headers.
6275         * arm-linux-nat.c: Sort headers.
6276         * arm-fbsd-tdep.c: Sort headers.
6277         * arm-fbsd-nat.c: Sort headers.
6278         * arm-bsd-tdep.c: Sort headers.
6279         * arch-utils.c: Sort headers.
6280         * arc-tdep.c: Sort headers.
6281         * arc-newlib-tdep.c: Sort headers.
6282         * annotate.h: Sort headers.
6283         * annotate.c: Sort headers.
6284         * amd64-windows-tdep.c: Sort headers.
6285         * amd64-windows-nat.c: Sort headers.
6286         * amd64-tdep.c: Sort headers.
6287         * amd64-sol2-tdep.c: Sort headers.
6288         * amd64-obsd-tdep.c: Sort headers.
6289         * amd64-obsd-nat.c: Sort headers.
6290         * amd64-nbsd-tdep.c: Sort headers.
6291         * amd64-nbsd-nat.c: Sort headers.
6292         * amd64-nat.c: Sort headers.
6293         * amd64-linux-tdep.c: Sort headers.
6294         * amd64-linux-nat.c: Sort headers.
6295         * amd64-fbsd-tdep.c: Sort headers.
6296         * amd64-fbsd-nat.c: Sort headers.
6297         * amd64-dicos-tdep.c: Sort headers.
6298         * amd64-darwin-tdep.c: Sort headers.
6299         * amd64-bsd-nat.c: Sort headers.
6300         * alpha-tdep.c: Sort headers.
6301         * alpha-obsd-tdep.c: Sort headers.
6302         * alpha-nbsd-tdep.c: Sort headers.
6303         * alpha-mdebug-tdep.c: Sort headers.
6304         * alpha-linux-tdep.c: Sort headers.
6305         * alpha-linux-nat.c: Sort headers.
6306         * alpha-bsd-tdep.c: Sort headers.
6307         * alpha-bsd-nat.c: Sort headers.
6308         * aix-thread.c: Sort headers.
6309         * agent.c: Sort headers.
6310         * addrmap.c: Sort headers.
6311         * ada-varobj.c: Sort headers.
6312         * ada-valprint.c: Sort headers.
6313         * ada-typeprint.c: Sort headers.
6314         * ada-tasks.c: Sort headers.
6315         * ada-lang.c: Sort headers.
6316         * aarch64-tdep.c: Sort headers.
6317         * aarch64-ravenscar-thread.c: Sort headers.
6318         * aarch64-newlib-tdep.c: Sort headers.
6319         * aarch64-linux-tdep.c: Sort headers.
6320         * aarch64-linux-nat.c: Sort headers.
6321         * aarch64-fbsd-tdep.c: Sort headers.
6322         * aarch64-fbsd-nat.c: Sort headers.
6323         * aarch32-linux-nat.c: Sort headers.
6324
6325 2019-04-04  Tom Tromey  <tom@tromey.com>
6326
6327         * varobj.c (varobj_create): Update.
6328         * rust-exp.y (struct rust_parser) <update_innermost_block,
6329         lookup_symbol>: New methods.
6330         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6331         Rename.
6332         (rust_parser::rust_lookup_type)
6333         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6334         * printcmd.c (display_command, do_one_display): Update.
6335         * parser-defs.h (struct parser_state) <parser_state>: Add
6336         "tracker" parameter.
6337         (block_tracker): New member.
6338         (class innermost_block_tracker) <innermost_block_tracker>: Add
6339         "types" parameter.
6340         <reset>: Remove method.
6341         (innermost_block): Don't declare.
6342         (null_post_parser): Update.
6343         * parse.c (innermost_block): Remove global.
6344         (write_dollar_variable): Update.
6345         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6346         Remove "tracker_types" parameter.
6347         (parse_expression): Add "tracker" parameter.
6348         (parse_expression_for_completion): Update.
6349         (null_post_parser): Add "tracker" parameter.
6350         * p-exp.y: Update rules.
6351         * m2-exp.y: Update rules.
6352         * language.h (struct language_defn) <la_post_parser>: Add
6353         "tracker" parameter.
6354         * go-exp.y: Update rules.
6355         * f-exp.y: Update rules.
6356         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6357         parameter.
6358         * d-exp.y: Update rules.
6359         * c-exp.y: Update rules.
6360         * breakpoint.c (set_breakpoint_condition): Create an
6361         innermost_block_tracker.
6362         (watch_command_1): Likewise.
6363         * ada-lang.c (resolve): Add "tracker" parameter.
6364         (resolve_subexp): Likewise.
6365         * ada-exp.y (write_var_from_sym): Update.
6366
6367 2019-04-04  Tom Tromey  <tom@tromey.com>
6368
6369         * type-stack.h: New file.
6370         * type-stack.c: New file.
6371         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6372         type-stack.h.
6373         (insert_into_type_stack, insert_type, push_type, push_type_int)
6374         (insert_type_address_space, pop_type, pop_type_int)
6375         (pop_typelist, pop_type_stack, append_type_stack)
6376         (push_type_stack, get_type_stack, push_typelist)
6377         (follow_type_instance_flags, follow_types): Don't declare.
6378         * parse.c (type_stack): Remove global.
6379         (parse_exp_in_context): Update.
6380         (insert_into_type_stack, insert_type, push_type, push_type_int)
6381         (insert_type_address_space, pop_type, pop_type_int)
6382         (pop_typelist, pop_type_stack, append_type_stack)
6383         (push_type_stack, get_type_stack, push_typelist)
6384         (follow_type_instance_flags, follow_types): Remove (moved to
6385         type-stack.c).
6386         * f-exp.y (type_stack): New global.
6387         Update rules.
6388         (push_kind_type, f_parse): Update.
6389         * d-exp.y (type_stack): New global.
6390         Update rules.
6391         (d_parse): Update.
6392         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6393         Update rules.
6394         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6395         (HFILES_NO_SRCDIR): Add type-stack.h.
6396
6397 2019-04-04  Tom Tromey  <tom@tromey.com>
6398
6399         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6400         (rust_parser::convert_ast_to_expression, rust_parse)
6401         (rust_lex_test_completion, rust_lex_tests): Update.
6402         * parser-defs.h (struct expr_completion_state): New.
6403         (struct parser_state) <parser_state>: Add completion parameter.
6404         <mark_struct_expression, mark_completion_tag>: New methods.
6405         <parse_completion, m_completion_state>: New members.
6406         (prefixify_expression, null_post_parser): Update.
6407         (mark_struct_expression, mark_completion_tag): Don't declare.
6408         * parse.c (parse_completion, expout_last_struct)
6409         (expout_tag_completion_type, expout_completion_name): Remove
6410         globals.
6411         (parser_state::mark_struct_expression)
6412         (parser_state::mark_completion_tag): Now methods.
6413         (prefixify_expression): Add last_struct parameter.
6414         (prefixify_subexp): Likewise.
6415         (parse_exp_1): Update.
6416         (parse_exp_in_context): Add cstate parameter.  Update.
6417         (parse_expression_for_completion): Create an
6418         expr_completion_state.
6419         (null_post_parser): Add "completion" parameter.
6420         * p-exp.y: Update rules.
6421         (yylex): Update.
6422         * language.h (struct language_defn) <la_post_parser>: Add
6423         "completing" parameter.
6424         * go-exp.y: Update rules.
6425         (lex_one_token): Update.
6426         * expression.h (parse_completion): Don't declare.
6427         * d-exp.y: Update rules.
6428         (lex_one_token): Update rules.
6429         * c-exp.y: Update rules.
6430         (lex_one_token): Update.
6431         * ada-lang.c (resolve): Add "parse_completion" parameter.
6432         (resolve_subexp): Likewise.
6433         (ada_resolve_function): Likewise.
6434
6435 2019-04-04  Tom Tromey  <tom@tromey.com>
6436
6437         * parser-defs.h (struct parser_state) <start_arglist,
6438         end_arglist>: New methods.
6439         <arglist_len, m_funcall_chain>: New members.
6440         (arglist_len, start_arglist, end_arglist): Don't declare.
6441         * parse.c (arglist_len, funcall_chain): Remove global.
6442         (start_arglist, end_arglist): Remove functions.
6443         (parse_exp_in_context): Update.
6444         * p-exp.y: Update rules.
6445         * m2-exp.y: Update rules.
6446         * go-exp.y: Update rules.
6447         * f-exp.y: Update rules.
6448         * d-exp.y: Update rules.
6449         * c-exp.y: Update rules.
6450
6451 2019-04-04  Tom Tromey  <tom@tromey.com>
6452
6453         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6454         lex_operator, push_back>: New methods.
6455         Update all rules.
6456         (rust_parser::lex_hex, lex_escape): Rename and update.
6457         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6458         (rust_parser::lex_operator): Rename and update.
6459         (rust_parser::lex_number, rustyylex, rustyyerror)
6460         (rust_lex_test_init, rust_lex_test_sequence)
6461         (rust_lex_test_push_back, rust_lex_tests): Update.
6462         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6463         parameter.
6464         <lexptr, prev_lexptr>: New members.
6465         (lexptr, prev_lexptr): Don't declare.
6466         * parse.c (lexptr, prev_lexptr): Remove globals.
6467         (parse_exp_in_context): Update.
6468         * p-exp.y (yylex, yyerror): Update.
6469         * m2-exp.y (parse_number, yylex, yyerror): Update.
6470         * go-exp.y (lex_one_token, yyerror): Update.
6471         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6472         * d-exp.y (lex_one_token, yyerror): Update.
6473         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6474         (lex_one_token, yyerror): Update.
6475         * ada-lex.l (YY_INPUT): Update.
6476         (rewind_to_char): Update.
6477         * ada-exp.y (yyerror): Update.
6478
6479 2019-04-04  Tom Tromey  <tom@tromey.com>
6480
6481         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6482         * parser-defs.h (struct parser_state) <parser_state>: Add new
6483         parameter.
6484         <comma_terminates>: New member.
6485         (comma_terminates): Don't declare global.
6486         * parse.c (comma_terminates): Remove global.
6487         (parse_exp_in_context): Update.
6488         * p-exp.y (yylex): Update.
6489         * m2-exp.y (yylex): Update.
6490         * go-exp.y (lex_one_token): Update.
6491         * f-exp.y (yylex): Update.
6492         * d-exp.y (lex_one_token): Update.
6493         * c-exp.y (lex_one_token): Update.
6494         * ada-lex.l: Update.
6495
6496 2019-04-04  Tom Tromey  <tom@tromey.com>
6497
6498         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6499         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6500         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6501         * parser-defs.h (paren_depth): Don't declare.
6502         * parse.c (paren_depth): Remove global.
6503         (parse_exp_in_context): Update.
6504         * p-exp.y (paren_depth): New global.
6505         (pascal_parse): Initialize it.
6506         * m2-exp.y (paren_depth): New global.
6507         (m2_parse): Initialize it.
6508         * go-exp.y (paren_depth): New global.
6509         (go_parse): Initialize it.
6510         * f-exp.y (paren_depth): New global.
6511         (f_parse): Initialize it.
6512         * d-exp.y (paren_depth): New global.
6513         (d_parse): Initialize it.
6514         * c-exp.y (paren_depth): New global.
6515         (c_parse): Initialize it.
6516         * ada-lex.l (paren_depth): New global.
6517         (lexer_init): Initialize it.
6518
6519 2019-04-04  Tom Tromey  <tom@tromey.com>
6520
6521         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6522         (rust_parser::convert_ast_to_type)
6523         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6524         * parser-defs.h (struct parser_state) <parser_state>: Add
6525         parameters.  Initialize new members.
6526         <expression_context_block, expression_context_pc>: New members.
6527         * parse.c (expression_context_block, expression_context_pc):
6528         Remove globals.
6529         (parse_exp_in_context): Update.
6530         * p-exp.y: Update all rules.
6531         (yylex): Update.
6532         * m2-exp.y: Update all rules.
6533         (yylex): Update.
6534         * go-exp.y (yylex): Update.
6535         * f-exp.y (yylex): Update.
6536         * d-exp.y: Update all rules.
6537         (yylex): Update.
6538         * c-exp.y: Update all rules.
6539         (lex_one_token, classify_name, yylex, c_parse): Update.
6540         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6541
6542 2019-04-04  Tom Tromey  <tom@tromey.com>
6543
6544         * gdbarch.h, gdbarch.c: Rebuild.
6545         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6546         * stap-probe.h:
6547         (struct stap_parse_info): Replace "parser_state" with
6548         "expr_builder".
6549         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6550         (parser_state): New class.
6551         * parse.c (expr_builder): Rename.
6552         (expr_builder::release): Rename.
6553         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6554         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6555         (write_exp_elt_longcst, write_exp_elt_floatcst)
6556         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6557         (write_exp_string_vector, write_exp_bitstring)
6558         (write_exp_msymbol, mark_struct_expression)
6559         (write_dollar_variable)
6560         (insert_type_address_space, increase_expout_size): Replace
6561         "parser_state" with "expr_builder".
6562         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6563         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6564         "parser_state" with "expr_builder".
6565
6566 2019-04-04  Tom Tromey  <tom@tromey.com>
6567
6568         * rust-exp.y: Replace "parse_language" with method call.
6569         * p-exp.y:
6570         (yylex): Replace "parse_language" with method call.
6571         * m2-exp.y:
6572         (yylex): Replace "parse_language" with method call.
6573         * go-exp.y (classify_name): Replace "parse_language" with method
6574         call.
6575         * f-exp.y (yylex): Replace "parse_language" with method call.
6576         * d-exp.y (lex_one_token): Replace "parse_language" with method
6577         call.
6578         * c-exp.y:
6579         (lex_one_token, classify_name, yylex): Replace "parse_language"
6580         with method call.
6581         * ada-exp.y (find_primitive_type, type_char)
6582         (type_system_address): Replace "parse_language" with method call.
6583
6584 2019-04-04  Tom Tromey  <tom@tromey.com>
6585
6586         * rust-exp.y: Replace "parse_gdbarch" with method call.
6587         * parse.c (write_dollar_variable, insert_type_address_space):
6588         Replace "parse_gdbarch" with method call.
6589         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6590         call.
6591         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6592         call.
6593         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6594         "parse_gdbarch" with method call.
6595         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6596         with method call.
6597         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6598         "parse_gdbarch" with method call.
6599         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6600         "parse_gdbarch" with method call.
6601         * c-exp.y (parse_type, parse_number, classify_name): Replace
6602         "parse_gdbarch" with method call.
6603         * ada-lex.l: Replace "parse_gdbarch" with method call.
6604         * ada-exp.y (parse_type, find_primitive_type, type_char)
6605         (type_system_address): Replace "parse_gdbarch" with method call.
6606
6607 2019-04-04  Tom Tromey  <tom@tromey.com>
6608
6609         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6610         * stap-probe.c (stap_parse_argument): Update.
6611         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6612         initial_size parameter.
6613         * rust-exp.y (rust_lex_tests): Update.
6614         * parse.c (parser_state): Update.
6615         (parse_exp_in_context): Update.
6616         * parser-defs.h (struct parser_state) <parser_state>: Remove
6617         "initial_size" parameter.
6618
6619 2019-04-04  Tom Tromey  <tom@tromey.com>
6620
6621         * parser-defs.h (increase_expout_size): Don't declare.
6622         * parse.c (increase_expout_size): Now static.
6623
6624 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6625
6626         * gnu-nat.c (gnu_nat_target::wait): Fix
6627         target_waitstatus_to_string call.
6628
6629 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6630
6631         * eval.c (evaluate_subexp_standard): Handle internal functions
6632         during Fortran function call handling.
6633
6634 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * NEWS: Mention new internal functions.
6637         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6638         (read_base_type): Use dwarf2_init_complex_target_type.
6639         * value.c (creal_internal_fn): New function.
6640         (cimag_internal_fn): New function.
6641         (_initialize_values): Register new internal functions.
6642
6643 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6644
6645         * infrun.c (stop_all_threads): If debug_infrun, always
6646         trace the wait status after wait_one, using
6647         target_waitstatus_to_string and target_pid_to_str.
6648         (handle_inferior_event): Replace various trace of
6649         wait status kind by a single trace.
6650         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6651         wait status kind image by target_waitstatus_to_string.
6652         * target/waitstatus.c (target_waitstatus_to_string): Fix
6653         obsolete comment.
6654
6655 2019-04-01  Tom Tromey  <tromey@adacore.com>
6656
6657         PR symtab/23331:
6658         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6659
6660 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6661             Pedro Alves  <palves@redhat.com>
6662
6663         * top.c (quit_force): Call 'finalize_values'.
6664         * value.c (finalize_values): New function.
6665         * value.h (finalize_values): Declare.
6666
6667 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6668
6669         * NEWS: Announce $_gdb_major and $_gdb_minor.
6670
6671         * top.c (init_gdb_version_vars): New function.
6672         (gdb_init): Call init_gdb_version_vars.
6673
6674 2019-03-29  Tom Tromey  <tromey@adacore.com>
6675
6676         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6677         help text.  Remove dead code.
6678
6679 2019-03-29  Keith Seitz  <keiths@redhat.com>
6680
6681         From Siddhesh Poyarekar:
6682         * f-lang.h (f77_get_upperbound): Return LONGEST.
6683         (f77_get_lowerbound): Likewise.
6684         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6685         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6686         print them.
6687         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6688         plongest to format print it.
6689         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6690         (f77_get_upperbound): Likewise.
6691         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6692         LOWER_BOUND to LONGEST.
6693         (f77_create_arrayprint_offset_tbl): Likewise.
6694
6695 2019-03-29  Keith Seitz  <keiths@redhat.com>
6696
6697         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6698         %s/pulongest for TYPE_LENGTH instead of %d in format
6699         strings.
6700         * ada-typerint.c (ada_print_type): Likewise.
6701         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6702         * compile/compile-c-support.c (generate_register_struct): Likewise.
6703         * gdbtypes.c (recursive_dump_type): Likewise.
6704         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6705         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6706         instead of %d in format strings.
6707         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6708         to std::min to ULONGEST.
6709         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6710         instead of %d in format strings.
6711         * tracepoint.c (info_scope_command): Likewise.
6712         * typeprint.c (print_offset_data::update)
6713         (print_offset_data::finish): Likewise.
6714         * xtensa-tdep.c (xtensa_store_return_value)
6715         (xtensa_push_dummy_call): Likewise.
6716
6717 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6718
6719         * windows-nat.c (display_selector): Fixed format specifications
6720         for 64-bit Cygwin.
6721
6722 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6723
6724         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6725
6726 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6727
6728         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6729         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6730         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6731         (nios2_linux_init_abi): Install it.
6732
6733 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6734
6735         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6736
6737 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6738
6739         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6740
6741 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6742             Tom Tromey  <tromey@adacore.com>
6743
6744         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6745
6746 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6747
6748         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6749         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6750         method to compute the bounds of range types. Also print "[evaluated]"
6751         if the bounds' values come from a dynamic evaluation.
6752
6753 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6754
6755         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6756         whitespace when pretty printing is on.
6757
6758 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6759
6760         * ppc-linux-nat.c: Add include.
6761
6762 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6763
6764         * NEWS: Mention AArch64 Pointer Authentication.
6765
6766 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6767
6768         * arm-linux-nat.c: Add include.
6769
6770 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6771
6772         * source-cache.c (source_cache::get_source_lines): Re-read
6773         fullname after calling open_source_file.
6774
6775 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6776
6777         * NEWS: Mention TLS support for FreeBSD.
6778
6779 2019-03-25  Tom Tromey  <tromey@adacore.com>
6780
6781         * minsyms.c (BUNCH_SIZE): Update comment.
6782         (~minimal_symbol_reader): Remove old comment.
6783         (compact_minimal_symbols): Update comment.
6784         (minimal_symbol_reader::install): Remove old comment.  Update
6785         other comments.
6786
6787 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6788
6789         * s390-linux-nat.c: Add include.
6790
6791 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6792
6793         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6794         Call linux_get_hwcap.
6795         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6796         Likewise.
6797         (aarch64_linux_get_hwcap): Remove function.
6798         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6799         declaration.
6800         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6801         linux_get_hwcap.
6802         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6803         * linux-tdep.c (linux_get_hwcap): Add function.
6804         (linux_get_hwcap2): Likewise.
6805         * linux-tdep.h (linux_get_hwcap): Add declaration.
6806         (linux_get_hwcap2): Likewise.
6807         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6808         (ppc_linux_get_hwcap2): Likewise.
6809         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6810         linux_get_hwcap.
6811         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6812         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6813         (ppc_linux_nat_target::read_description): Likewise.
6814         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6815         * s390-linux-nat.c: Likewise.
6816         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6817
6818 2019-03-24  Tom Tromey  <tom@tromey.com>
6819
6820         * ada-lang.c (standard_lookup): Simplify initialization.
6821         (ada_lookup_symbol_nonlocal): Simplify return.
6822         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6823         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6824         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6825         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6826         initialization.
6827         * solib.c (solib_global_lookup): Simplify.
6828         * symtab.c (null_block_symbol): Remove.
6829         (symbol_cache_lookup): Simplify returns.
6830         (lookup_language_this): Simplify returns.
6831         (lookup_symbol_aux): Simplify return.
6832         (lookup_local_symbol): Simplify returns.
6833         (lookup_global_symbol_from_objfile): Simplify return.
6834         (lookup_symbol_in_objfile_symtabs)
6835         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6836         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6837         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6838         * cp-namespace.c (cp_lookup_bare_symbol)
6839         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6840         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6841         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6842         (cp_lookup_symbol_via_imports): Simplify initialization.
6843         (find_symbol_in_baseclass): Likewise.
6844         * symtab.h (null_block_symbol): Remove.
6845         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6846         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6847         (d_lookup_symbol_module): Likewise.
6848         (find_symbol_in_baseclass): Simplify initialization.
6849
6850 2019-03-24  Tom Tromey  <tom@tromey.com>
6851
6852         * expression.h: Don't include symtab.h.
6853         (struct block): Forward declare.
6854
6855 2019-03-24  Tom Tromey  <tom@tromey.com>
6856
6857         * c-exp.y (typebase): Remove casts.
6858         * gdbtypes.c (lookup_unsigned_typename, )
6859         (lookup_signed_typename): Remove cast.
6860         * eval.c (parse_to_comma_and_eval): Remove cast.
6861         * parse.c (write_dollar_variable): Remove cast.
6862         * block.h (struct block) <superblock>: Now const.
6863         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6864         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6865         (map_block): Make "block" const.
6866         * symfile.h (struct quick_symbol_functions)
6867         <map_matching_symbols>: Constify block argument to "callback".
6868         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6869         const.
6870         (find_pc_sect_compunit_symtab): Make "b" const.
6871         (find_symbol_at_address): Likewise.
6872         (search_symbols): Likewise.
6873         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6874         (dw2_debug_names_lookup_symbol): Likewise.
6875         (dw2_map_matching_symbols): Update.
6876         * p-valprint.c (pascal_val_print): Remove "block".
6877         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6878         (aux_add_nonlocal_symbols): Make "block" const.
6879         (resolve_subexp): Remove cast.
6880         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6881         const.
6882         (iterate_over_file_blocks): Likewise.
6883         * f-exp.y (%union) <bval>: Remove.
6884         * coffread.c (patch_opaque_types): Make "b" const.
6885         * spu-tdep.c (spu_catch_start): Make "block" const.
6886         * c-valprint.c (print_unpacked_pointer): Remove "block".
6887         * symmisc.c (dump_symtab_1): Make "b" const.
6888         (block_depth): Make "block" const.
6889         * d-exp.y (%union) <bval>: Remove.
6890         * cp-support.h (cp_lookup_rtti_type): Update.
6891         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6892         * psymtab.c (psym_lookup_symbol): Make "block" const.
6893         (maintenance_check_psymtabs): Make "b" const.
6894         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6895         (enumerate_locals, enumerate_args): Update.
6896         * python/py-symtab.c (stpy_global_block): Make "block" const.
6897         (stpy_static_block): Likewise.
6898         * inline-frame.c (block_starting_point_at): Make "new_block"
6899         const.
6900         * block.c (find_block_in_blockvector): Make return type const.
6901         (blockvector_for_pc_sect): Make "b" const.
6902         (find_block_in_blockvector): Make "b" const.
6903
6904 2019-03-23  Tom Tromey  <tom@tromey.com>
6905
6906         * varobj.c (varobj_create): Update.
6907         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6908         * printcmd.c (display_command, do_one_display): Don't reset
6909         innermost_block.
6910         * parser-defs.h (enum innermost_block_tracker_type): Move to
6911         expression.h.
6912         (innermost_block): Update comment.
6913         * parse.c (parse_exp_1): Add tracker_types parameter.
6914         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6915         tracker_types parameter.  Reset innermost_block.
6916         (parse_exp_in_context): Remove.
6917         (parse_expression_for_completion): Update.
6918         * objfiles.c (~objfile): Don't reset expression_context_block or
6919         innermost_block.
6920         * expression.h (enum innermost_block_tracker_type): Move from
6921         parser-defs.h.
6922         (parse_exp_1): Add tracker_types parameter.
6923         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6924         reset innermost_block.
6925
6926 2019-03-23  Tom Tromey  <tom@tromey.com>
6927
6928         * objfiles.h: Include bcache.h.
6929
6930 2019-03-23  Tom Tromey  <tom@tromey.com>
6931
6932         * linespec.c (get_current_search_block): Use
6933         scoped_restore_current_language.
6934         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6935
6936 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6937             Jiong Wang  <jiong.wang@arm.com>
6938
6939         * aarch64-linux-tdep.c
6940         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6941         section.
6942         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6943
6944 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6945             Jiong Wang  <jiong.wang@arm.com>
6946
6947         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6948         instructions.
6949         (aarch64_analyze_prologue_test): Add PACIASP test.
6950         (aarch64_prologue_prev_register): Unmask PC value.
6951
6952 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6953             Jiong Wang  <jiong.wang@arm.com>
6954
6955         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6956         (aarch64_dwarf2_prev_register): Unmask PC value.
6957         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6958         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6959         DW_CFA_AARCH64_negate_ra_state.
6960         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6961
6962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6963             Jiong Wang  <jiong.wang@arm.com>
6964
6965         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6966         registers.
6967         (aarch64_pseudo_register_name): Likewise.
6968         (aarch64_pseudo_register_type): Likewise.
6969         (aarch64_pseudo_register_reggroup_p): Likewise.
6970         (aarch64_gdbarch_init): Add pauth registers.
6971         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6972         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6973         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6974         (struct gdbarch_tdep): Add regnum for ra_state.
6975
6976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6977             Jiong Wang  <jiong.wang@arm.com>
6978
6979         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6980
6981 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6982             Jiong Wang  <jiong.wang@arm.com>
6983
6984         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6985         function.
6986         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6987         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6988         (aarch64_gdbarch_init): Add puth registers.
6989         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6990         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6991         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6992
6993 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6994             Jiong Wang  <jiong.wang@arm.com>
6995
6996         * aarch64-linux-nat.c
6997         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6998         * aarch64-linux-tdep.c
6999         (aarch64_linux_core_read_description): Likewise.
7000         (aarch64_linux_get_hwcap): New function.
7001         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7002         (aarch64_linux_get_hwcap): New declaration.
7003
7004 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7005             Jiong Wang  <jiong.wang@arm.com>
7006
7007         * aarch64-linux-nat.c
7008         (aarch64_linux_nat_target::read_description): Add pauth param.
7009         * aarch64-linux-tdep.c
7010         (aarch64_linux_core_read_description): Likewise.
7011         * aarch64-tdep.c (struct target_desc): Add in pauth.
7012         (aarch64_read_description): Add pauth param.
7013         (aarch64_gdbarch_init): Likewise.
7014         * aarch64-tdep.h (aarch64_read_description): Likewise.
7015         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7016         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7017         * features/Makefile: Add new files.
7018         * features/aarch64-pauth.c: New file.
7019         * features/aarch64-pauth.xml: New file.
7020
7021 2019-03-20  Tom Tromey  <tromey@adacore.com>
7022
7023         * infrun.c (handle_inferior_event): Rename from
7024         handle_inferior_event_1.  Create a scoped_value_mark.
7025         (handle_inferior_event): Remove.
7026
7027 2019-03-19  Tom Tromey  <tromey@adacore.com>
7028
7029         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7030         * infrun.h (print_stop_event): Add "displays" parameter.
7031         * infrun.c (print_stop_event): Add "displays" parameter.
7032
7033 2019-03-19  Pedro Alves  <palves@redhat.com>
7034
7035         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7036         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7037         to -1.  Fix TABs vs spaces.
7038         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7039         * tui/tui-out.h (tui_ui_out) Add intro comments.
7040         <m_line, m_start_of_line>: In-class initialize, and add describing
7041         comment.
7042
7043 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7044
7045         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7046         variable names.
7047         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7048
7049 2019-03-18  Pedro Alves  <palves@redhat.com>
7050             Eli Zaretskii <eliz@gnu.org>
7051
7052         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7053         m_line and m_start_of_line.
7054
7055 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7056
7057         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7058         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7059         it returns a newline.  This fixes a regression in TU mode, whereby
7060         the next line is output on the same screen line as the user input.
7061
7062 2019-03-18  Tom Tromey  <tromey@adacore.com>
7063
7064         * minsyms.c (minimal_symbol_reader::install): Remove call to
7065         obstack_blank.
7066
7067 2019-03-18  Pedro Alves  <palves@redhat.com>
7068
7069         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7070         New globals.
7071         (apply_style): New, factored out from ...
7072         (apply_ansi_escape): ... this.  Handle reverse video mode.
7073         (tui_set_reverse_mode): New function.
7074         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7075         * tui/tui-winsource.c (tui_show_source_line): Use
7076         tui_set_reverse_mode instead of setting A_STANDOUT.
7077         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7078         New setter methods.
7079
7080 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7081
7082         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7083         Handle tabs.
7084
7085 2019-03-18  Tom Tromey  <tromey@adacore.com>
7086
7087         * ada-lang.c (empty_array): Add "high" parameter.
7088         (ada_evaluate_subexp): Update.
7089
7090 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7091
7092         * unittests/string_view-selftests.c: Define
7093         _initialize_string_view_selftests unconditionally.
7094
7095 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7096
7097         PR gdb/24350
7098         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7099
7100 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7101
7102         PR gdb/24351
7103         * windows-nat.c (display_selector): Fix format specifiers.
7104
7105 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7106
7107         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7108         tui_refill_source_window instead of tui_refresh_win, to update the
7109         current execution line.  This fixes redisplay of the current line
7110         when stepping through the code with "next" or "step".
7111
7112 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7113
7114         * source-cache.c (source_cache::get_source_lines): Call
7115         find_source_lines to initialize s->nlines.  This fixes vertical
7116         scrolling of TUI source window when the DOWN arrow is pressed.
7117
7118 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7119
7120         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7121         linux-thread-db.c (_initialize_thread_db): Likewise.
7122
7123 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7124
7125         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7126         wclrtoeol in tui_show_source_line".  This reverts changes made in
7127         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7128
7129 2019-03-15  Tom Tromey  <tom@tromey.com>
7130
7131         * symtab.h (struct minimal_symbol): Derive from
7132         general_symbol_info.
7133         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7134         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7135         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7136         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7137         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7138         (MSYMBOL_SEARCH_NAME): Update.
7139         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7140         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7141         * minsyms.c (minimal_symbol_reader::record_full): Update.
7142
7143 2019-03-15  Tom Tromey  <tom@tromey.com>
7144
7145         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7146
7147 2019-03-15  Tom Tromey  <tom@tromey.com>
7148
7149         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7150         unique_xmalloc_ptr.
7151         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7152         Update.
7153         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7154         (build_minimal_symbol_hash_tables)
7155         (minimal_symbol_reader::install): Update.
7156
7157 2019-03-15  Tom Tromey  <tom@tromey.com>
7158
7159         * symtab.c (create_demangled_names_hash): Update.
7160         (symbol_set_names): Update.
7161         * objfiles.h (struct objfile_per_bfd_storage)
7162         <demangled_names_hash>: Now an htab_up.
7163         * objfiles.c (objfile_per_bfd_storage): Simplify.
7164
7165 2019-03-15  Tom Tromey  <tom@tromey.com>
7166
7167         * objfiles.h (struct objfile_per_bfd_storage): Declare
7168         destructor.
7169         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7170         New.
7171         (get_objfile_bfd_data): Use new.  Don't initialize
7172         language_of_main.
7173         (free_objfile_per_bfd_storage): Remove.
7174         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7175
7176 2019-03-15  Tom Tromey  <tom@tromey.com>
7177
7178         * symfile.c (reread_symbols): Update.
7179         * objfiles.c (objfile::objfile): Update.
7180         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7181         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7182         comment.
7183         (minimal_symbol_reader::install): Update.
7184         (terminate_minimal_symbol_table): Remove.
7185         * jit.c (jit_object_close_impl): Update.
7186
7187 2019-03-15  Tom Tromey  <tom@tromey.com>
7188
7189         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7190         initializations.
7191
7192 2019-03-15  Tom Tromey  <tom@tromey.com>
7193
7194         * objfiles.h (struct objfile_per_bfd_storage)
7195         <demangled_hash_languages>: Now a bitset.
7196         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7197         (lookup_minimal_symbol): Update.
7198
7199 2019-03-15  Tom Tromey  <tom@tromey.com>
7200
7201         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7202         Don't return the symbol.
7203         * coffread.c (record_minimal_symbol): Use record_full.
7204
7205 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7206
7207         The MS-Windows port of ncurses fails to switch to a color pair if
7208         one or both of the colors are the implicit default colors.  This
7209         change records the default colors when TUI is initialized, and
7210         then specifies them explicitly when a color pair uses the default
7211         colors.  This allows color styling in TUI mode on MS-Windows.
7212
7213         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7214         ncurses_norm_attr.
7215         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7216         colors in ncurses_norm_attr.
7217         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7218         "none", replace it with the default color recorded in
7219         ncurses_norm_attr.
7220
7221 2019-03-14  Tom Tromey  <tromey@adacore.com>
7222
7223         * source-cache.h (class source_cache) <get_source_lines>: Return
7224         std::string.
7225         * source-cache.c (source_cache::extract_lines): Handle case where
7226         first_pos==npos.  Return std::string.
7227         (source_cache::get_source_lines): Update.
7228
7229 2019-03-14  Tom Tromey  <tromey@adacore.com>
7230
7231         * NEWS: Add item for "style sources" commands.
7232         * source-cache.c (source_cache::get_source_lines): Check
7233         source_styling.
7234         * cli/cli-style.c (source_styling): New global.
7235         (_initialize_cli_style): Add "style sources" commands.
7236         (show_style_sources): New function.
7237         * cli/cli-style.h (source_styling): Declare.
7238
7239 2019-03-14  Pedro Alves  <palves@redhat.com>
7240             Tom Tromey  <tromey@adacore.com>
7241
7242         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7243         * tui/tui-winsource.c (tui_refill_source_window): New function,
7244         from...
7245         (tui_horizontal_source_scroll): ... here.  Move some logic.
7246         * cli/cli-style.c (set_style_enabled): Notify new observable.
7247         * tui/tui-hooks.c (tui_redisplay_source): New function.
7248         (tui_attach_detach_observers): Attach or detach
7249         tui_redisplay_source.
7250         * observable.h (source_styling_changed): New observable.
7251         * observable.c: Define source_styling_changed observable.
7252
7253 2019-03-13  Tom Tromey  <tromey@adacore.com>
7254
7255         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7256         (i386_gnu_nat_target::store_registers): Update.
7257         * target-debug.h (target_debug_print_std_string): New macro.
7258         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7259         * windows-tdep.c (display_one_tib): Update.
7260         * tui/tui-stack.c (tui_make_status_line): Update.
7261         * top.c (print_inferior_quit_action): Update.
7262         * thread.c (thr_try_catch_cmd): Update.
7263         (add_thread_with_info): Update.
7264         (thread_target_id_str): Update.
7265         (thr_try_catch_cmd): Update.
7266         (thread_command): Update.
7267         (thread_find_command): Update.
7268         * record-btrace.c (record_btrace_target::info_record)
7269         (record_btrace_resume_thread, record_btrace_target::resume)
7270         (record_btrace_cancel_resume, record_btrace_step_thread)
7271         (record_btrace_target::wait, record_btrace_target::wait)
7272         (record_btrace_target::wait, record_btrace_target::stop): Update.
7273         * progspace.c (print_program_space): Update.
7274         * process-stratum-target.c
7275         (process_stratum_target::thread_address_space): Update.
7276         * linux-fork.c (linux_fork_mourn_inferior)
7277         (detach_checkpoint_command, info_checkpoints_command)
7278         (linux_fork_context): Update.
7279         (linux_fork_detach): Update.
7280         (class scoped_switch_fork_info): Update.
7281         (delete_checkpoint_command): Update.
7282         * infrun.c (follow_fork_inferior): Update.
7283         (follow_fork_inferior): Update.
7284         (proceed_after_vfork_done): Update.
7285         (handle_vfork_child_exec_or_exit): Update.
7286         (follow_exec): Update.
7287         (displaced_step_prepare_throw): Update.
7288         (displaced_step_restore): Update.
7289         (start_step_over): Update.
7290         (resume_1): Update.
7291         (clear_proceed_status_thread): Update.
7292         (proceed): Update.
7293         (print_target_wait_results): Update.
7294         (do_target_wait): Update.
7295         (context_switch): Update.
7296         (stop_all_threads): Update.
7297         (restart_threads): Update.
7298         (finish_step_over): Update.
7299         (handle_signal_stop): Update.
7300         (switch_back_to_stepped_thread): Update.
7301         (keep_going_pass_signal): Update.
7302         (print_exited_reason): Update.
7303         (normal_stop): Update.
7304         * inferior.c (inferior_pid_to_str): Change return type.
7305         (print_selected_inferior): Update.
7306         (add_inferior): Update.
7307         (detach_inferior): Update.
7308         * dummy-frame.c (fprint_dummy_frames): Update.
7309         * dcache.c (dcache_info_1): Update.
7310         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7311         (btrace_fetch, btrace_clear): Update.
7312         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7313         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7314         type.
7315         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7316         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7317         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7318         * gdbarch.c, gdbarch.h: Rebuild.
7319         * gdbarch.sh (core_pid_to_str): Change return type.
7320         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7321         return type.
7322         (windows_nat_target::pid_to_str): Change return type.
7323         (windows_delete_thread): Update.
7324         (windows_nat_target::attach): Update.
7325         (windows_nat_target::files_info): Update.
7326         * target-delegates.c: Rebuild.
7327         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7328         return type.
7329         (sol_thread_target::pid_to_str): Change return type.
7330         * remote.c (class remote_target) <pid_to_str>: Change return
7331         type.
7332         (remote_target::pid_to_str): Change return type.
7333         (extended_remote_target::attach, remote_target::remote_stop_ns)
7334         (remote_target::remote_notif_remove_queued_reply)
7335         (remote_target::push_stop_reply, remote_target::disable_btrace):
7336         Update.
7337         (extended_remote_target::attach): Update.
7338         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7339         type.
7340         (gdbsim_target::pid_to_str): Change return type.
7341         * ravenscar-thread.c (struct ravenscar_thread_target)
7342         <pid_to_str>: Change return type.
7343         (ravenscar_thread_target::pid_to_str): Change return type.
7344         * procfs.c (class procfs_target) <pid_to_str>: Change return
7345         type.
7346         (procfs_target::pid_to_str): Change return type.
7347         (procfs_target::attach): Update.
7348         (procfs_target::detach): Update.
7349         (procfs_target::fetch_registers): Update.
7350         (procfs_target::store_registers): Update.
7351         (procfs_target::wait): Update.
7352         (procfs_target::files_info): Update.
7353         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7354         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7355         return type.
7356         (nto_procfs_target::pid_to_str): Change return type.
7357         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7358         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7359         return type.
7360         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7361         (exit_lwp): Update.
7362         (attach_proc_task_lwp_callback, get_detach_signal)
7363         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7364         (linux_nat_target::resume, wait_lwp, stop_callback)
7365         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7366         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7367         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7368         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7369         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7370         type.
7371         (inf_ptrace_target::attach): Update.
7372         (inf_ptrace_target::files_info): Update.
7373         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7374         type.
7375         (go32_nat_target::pid_to_str): Change return type.
7376         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7377         (gnu_nat_target::wait): Update.
7378         (gnu_nat_target::wait): Update.
7379         (gnu_nat_target::resume): Update.
7380         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7381         (fbsd_nat_target::wait): Update.
7382         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7383         type.
7384         (darwin_nat_target::attach): Update.
7385         * corelow.c (class core_target) <pid_to_str>: Change return type.
7386         (core_target::pid_to_str): Change return type.
7387         * target.c (normal_pid_to_str): Change return type.
7388         (default_pid_to_str): Likewise.
7389         (target_pid_to_str): Change return type.
7390         (target_translate_tls_address): Update.
7391         (target_announce_detach): Update.
7392         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7393         return type.
7394         (bsd_uthread_target::pid_to_str): Change return type.
7395         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7396         type.
7397         (bsd_kvm_target::pid_to_str): Change return type.
7398         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7399         return type.
7400         (aix_thread_target::pid_to_str): Change return type.
7401         * target.h (struct target_ops) <pid_to_str>: Change return type.
7402         (target_pid_to_str, normal_pid_to_str): Likewise.
7403         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7404         type.
7405         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7406         type.
7407         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7408         return type.
7409         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7410         type.
7411         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7412         type.
7413         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7414         return type.
7415
7416 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7417
7418         * NEWS: Mention that the new default MI version is 3.  Mention
7419         changes to the output of commands and events that deal with
7420         multi-location breakpoints.
7421         * breakpoint.c: Include "mi/mi-out.h".
7422         (print_one_breakpoint): Change output syntax if using MI version
7423         >= 3.
7424         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7425         New.
7426         (mi_multi_location_breakpoint_output_fixed): New.
7427         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7428         (mi_cmd_fix_multi_location_breakpoint_output): New.
7429         (mi_multi_location_breakpoint_output_fixed): New.
7430         * mi/mi-cmds.c (mi_cmds): Register command
7431         -fix-multi-location-breakpoint-output.
7432         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7433         interpreter "mi".
7434
7435 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7436
7437         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7438         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7439         instantiate mi_ui_out based on interpreter name.
7440         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7441         * mi/mi-main.c (mi_load_progress): Likewise.
7442
7443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7444
7445         * NEWS: Combine separate "New targets" sections for 8.3.
7446
7447 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7448
7449         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7450         (ppcfbsd_init_abi): Install gdbarch
7451         "fetch_tls_load_module_address" and "get_thread_local_address"
7452         methods.
7453
7454 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7455
7456         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7457         (riscv_fbsd_init_abi): Install gdbarch
7458         "fetch_tls_load_module_address" and "get_thread_local_address"
7459         methods.
7460
7461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7462
7463         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7464         (i386fbsd_init_abi): Install gdbarch
7465         "fetch_tls_load_module_address" and "get_thread_local_address"
7466         methods.
7467
7468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7469
7470         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7471         (amd64fbsd_init_abi): Install gdbarch
7472         "fetch_tls_load_module_address" and "get_thread_local_address"
7473         methods.
7474
7475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7476
7477         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7478         (struct fbsd_pspace_data): New type.
7479         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7480         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7481         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7482         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7483         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7484
7485 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7486
7487         * gdbtypes.c (lookup_struct_elt): New function.
7488         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7489         * gdbtypes.h (struct struct_elt): New type.
7490         (lookup_struct_elt): New prototype.
7491
7492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7493
7494         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7495         remove disabled code block.
7496
7497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7498
7499         * gdbarch.sh (get_thread_local_address): New method.
7500         * gdbarch.h, gdbarch.c: Regenerate.
7501         * target.c (target_translate_tls_address): Use
7502         gdbarch_get_thread_local_address if present instead of
7503         target::get_thread_local_address.
7504
7505 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7506
7507         * target.h (target::get_thread_local_address): Update comment.
7508
7509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7510
7511         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7512         objfile->separate_debug_objfile_backlink if not NULL.
7513
7514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7515
7516         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7517         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7518         (amd64bsd_store_inferior_registers): Likewise.
7519         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7520         Enable segment base registers.
7521         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7522         PT_GETFSBASE and PT_GETGSBASE.
7523         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7524         PT_SETGSBASE.
7525         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7526         segment base registers.
7527         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7528
7529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7530
7531         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7532         Update calls to i386_target_description to add 'segments'
7533         parameter.
7534         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7535         add segment base registers.
7536         * arch/i386.c (i386_create_target_description): Add 'segments'
7537         parameter to enable segment base registers.
7538         * arch/i386.h (i386_create_target_description): Likewise.
7539         * features/i386/32bit-segments.xml: New file.
7540         * features/i386/32bit-segments.c: Generate.
7541         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7542         call to i386_target_description to add 'segments' parameter.
7543         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7544         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7545         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7546         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7547         if feature is present.
7548         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7549         Add 'segments' parameter to call to i386_target_description.
7550         (i386_target_description): Add 'segments' parameter to enable
7551         segment base registers.
7552         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7553         to call to i386_target_description.
7554         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7555         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7556         Define I386_NUM_REGS.
7557         (i386_target_description): Add 'segments' parameter to enable
7558         segment base registers.
7559
7560 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7561
7562         PR/24325
7563         * source-cache.c: #undef open and close, to avoid unresolved
7564         externals during linking.
7565
7566 2019-03-12  Tom Tromey  <tromey@adacore.com>
7567
7568         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7569         const.  Add initializers.
7570         (_initialize_remote): Don't initialize ptid globals.
7571
7572 2019-03-12  Pedro Alves  <palves@redhat.com>
7573
7574         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7575
7576 2019-03-12  Pedro Alves  <palves@redhat.com>
7577
7578         * cp-name-parser.y (main): Remove unused 'len' variable.
7579
7580 2019-03-12  Tom Tromey  <tromey@adacore.com>
7581
7582         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7583         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7584
7585 2019-03-12  Tom Tromey  <tromey@adacore.com>
7586
7587         * linux-nat.c (iterate_over_lwps): Update.
7588         (stop_callback): Remove parameter.
7589         (stop_wait_callback, detach_callback, resume_set_callback)
7590         (select_singlestep_lwp_callback, set_ignore_sigint)
7591         (status_callback, resumed_callback, resume_clear_callback)
7592         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7593         data parameter.
7594         (linux_nat_target::detach, linux_nat_target::resume)
7595         (linux_stop_and_wait_all_lwps, select_event_lwp)
7596         (linux_nat_filter_event, linux_nat_wait_1)
7597         (linux_nat_target::kill, linux_nat_target::stop)
7598         (linux_nat_target::stop): Update.
7599         (linux_nat_resume_callback): Change type.
7600         (resume_stopped_resumed_lwps, count_events_callback)
7601         (select_event_lwp_callback): Likewise.
7602         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7603         * arm-linux-nat.c (struct update_registers_data): Remove.
7604         (update_registers_callback): Change type.
7605         (arm_linux_insert_hw_breakpoint1): Update.
7606         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7607         parameter.
7608         (x86_linux_dr_set_addr): Update.
7609         (x86_linux_dr_set_control): Update.
7610         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7611         (iterate_over_lwps): Use gdb::function_view.
7612         * nat/aarch64-linux-hw-point.c (struct
7613         aarch64_dr_update_callback_param): Remove.
7614         (debug_reg_change_callback): Change type.
7615         (aarch64_notify_debug_reg_change): Update.
7616         * s390-linux-nat.c (s390_refresh_per_info): Update.
7617
7618 2019-03-11  Tom Tromey  <tromey@adacore.com>
7619
7620         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7621         redundant assignment to "this_cu".
7622
7623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7624
7625         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7626
7627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7628
7629         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7630         from...
7631         (rank_one_type): ... this.
7632
7633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7634
7635         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7636         from...
7637         (rank_one_type): ... this.
7638
7639 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7640
7641         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7642         from...
7643         (rank_one_type): ... this.
7644
7645 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7646
7647         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7648         from...
7649         (rank_one_type): ... this.
7650
7651 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7652
7653         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7654         from...
7655         (rank_one_type): ... this.
7656
7657 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7658
7659         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7660         from...
7661         (rank_one_type): ... this.
7662
7663 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7664
7665         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7666         from...
7667         (rank_one_type): ... this.
7668
7669 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7670
7671         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7672         from...
7673         (rank_one_type): ... this.
7674
7675 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7676
7677         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7678         from...
7679         (rank_one_type): ... this.
7680
7681 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7682
7683         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7684         from...
7685         (rank_one_type): ... this.
7686
7687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7688
7689         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7690         from...
7691         (rank_one_type): ... this.
7692
7693 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7694
7695         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7696         from...
7697         (rank_one_type): ... this.
7698
7699 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7700
7701         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7702         inferior-events' shows the example events.
7703
7704 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7705
7706         Support styling on native MS-Windows console
7707
7708         PR/24315
7709         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7710         on MS-Windows if $TERM is not defined.
7711
7712         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7713
7714         * posix-hdep.c (gdb_console_fputs):
7715         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7716         functions.
7717         * ui-file.h (gdb_console_fputs): Add prototype.
7718
7719         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7720         back to fputs only if the former returns zero.
7721
7722 2019-03-07  Tom Tromey  <tom@tromey.com>
7723
7724         * symmisc.c (print_symbol_bcache_statistics): Update.
7725         (print_objfile_statistics): Update.
7726         * symfile.c (allocate_symtab): Update.
7727         * stabsread.c: Don't include bcache.h.
7728         * psymtab.h (struct psymbol_bcache): Don't declare.
7729         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7730         (psymbol_bcache_init, psymbol_bcache_free)
7731         (psymbol_bcache_get_bcache): Don't declare.
7732         * psymtab.c (struct psymbol_bcache): Remove.
7733         (psymtab_storage::psymtab_storage): Update.
7734         (psymtab_storage::~psymtab_storage): Update.
7735         (psymbol_bcache_init, psymbol_bcache_free)
7736         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7737         (add_psymbol_to_bcache): Update.
7738         (allocate_psymtab): Update.
7739         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7740         macro_cache>: No longer pointers.
7741         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7742         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7743         * macrotab.c (macro_bcache): Update.
7744         * macroexp.c: Don't include bcache.h.
7745         * gdbtypes.c (check_types_worklist): Update.
7746         (types_deeply_equal): Remove TRY/CATCH.  Update.
7747         * elfread.c (elf_symtab_read): Update.
7748         * dwarf2read.c: Don't include bcache.h.
7749         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7750         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7751         (print_bcache_statistics, bcache_memory_used): Don't declare.
7752         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7753         methods.  Rename all data members.
7754         * bcache.c (struct bcache): Move to bcache.h.
7755         (bcache::expand_hash_table): Rename from expand_hash_table.
7756         (bcache): Remove.
7757         (bcache::insert): Rename from bcache_full.
7758         (bcache::compare): Rename from bcache_compare.
7759         (bcache_xmalloc): Remove.
7760         (bcache::~bcache): Rename from bcache_xfree.
7761         (bcache::print_statistics): Rename from print_bcache_statistics.
7762         (bcache::memory_used): Rename from bcache_memory_used.
7763
7764 2019-03-07  Pedro Alves  <palves@redhat.com>
7765
7766         * infrun.c (normal_stop): Also check for
7767         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7768
7769 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * f-lang.c (value_from_host_double): Moved to...
7772         * value.c (value_from_host_double): ...here.
7773         * value.h (value_from_host_double): Declare.
7774         * guile/scm-math.c (vlscm_convert_typed_number): Use
7775         value_from_host_double.
7776         (vlscm_convert_number): Likewise.
7777         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7778         * python/py-value.c (convert_value_from_python): Likewise.
7779
7780 2019-03-06  Tom Tromey  <tom@tromey.com>
7781
7782         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7783
7784 2019-03-06  Tom Tromey  <tom@tromey.com>
7785
7786         * utils.h (free_current_contents): Don't declare.
7787         * utils.c (free_current_contents): Remove.
7788
7789 2019-03-06  Tom Tromey  <tom@tromey.com>
7790
7791         * top.c (quit_force): Update.
7792         * main.c (captured_command_loop): Update.
7793         * common/new-op.c (operator new): Update.
7794         * common/common-exceptions.c (struct catcher)
7795         <save_cleanup_chain>: Remove member.
7796         (exceptions_state_mc_init): Update.
7797         (exception_try_scope_entry): Return nullptr.
7798         (exception_try_scope_exit, exception_rethrow)
7799         (throw_exception_sjlj, throw_exception_cxx): Update.
7800         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7801         (all_cleanups, do_cleanups, discard_cleanups)
7802         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7803         (restore_cleanups, restore_final_cleanups): Don't declare.
7804         (do_final_cleanups): Remove parameter.
7805         * common/cleanups.c (cleanup_chain, make_cleanup)
7806         (make_cleanup_dtor, all_cleanups, do_cleanups)
7807         (discard_my_cleanups, discard_cleanups)
7808         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7809         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7810         (null_cleanup): Remove.
7811         (do_final_cleanups): Remove parameter.
7812
7813 2019-03-06  Tom Tromey  <tom@tromey.com>
7814
7815         * remote.c (remote_target::remote_parse_stop_reply): Use
7816         unique_xmalloc_ptr.
7817
7818 2019-03-06  Tom Tromey  <tom@tromey.com>
7819
7820         * stabsread.c (struct stabs_field_info): Rename from field_info.
7821         <list, fnlist>: Add initializers.
7822         <obstack>: New member.
7823         (read_member_functions, read_struct_fields, read_baseclasses):
7824         Allocate on obstack.  Don't use cleanups.
7825         (read_one_struct_field, read_member_functions, read_struct_fields)
7826         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7827         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7828         (read_struct_type): Update.
7829
7830 2019-03-06  Tom Tromey  <tom@tromey.com>
7831
7832         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7833         * common/filestuff.h (make_cleanup_close): Don't declare.
7834         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7835         Remove.
7836
7837 2019-03-06  Tom Tromey  <tom@tromey.com>
7838
7839         * solib-aix.c: Use make_scope_exit.
7840
7841 2019-03-06  Tom Tromey  <tom@tromey.com>
7842
7843         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7844         Use make_scope_exit.
7845
7846 2019-03-06  Tom Tromey  <tom@tromey.com>
7847
7848         * solib-svr4.c (disable_probes_interface): Remove parameter.
7849         (svr4_handle_solib_event): Use make_scope_exit.
7850
7851 2019-03-06  Tom Tromey  <tom@tromey.com>
7852
7853         * remote.c (struct stop_reply_deleter): Remove.
7854         (stop_reply_up): Update.
7855         (struct stop_reply): Derive from notif_event.  Don't typedef.
7856         <regcache>: Now a std::vector.
7857         (stop_reply_xfree): Remove.
7858         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7859         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7860         (remote_target::discard_pending_stop_replies): Use delete.
7861         (remote_target::remote_parse_stop_reply): Update.
7862         (remote_target::process_stop_reply): Update.
7863         * remote-notif.h (struct notif_event): Add virtual destructor.
7864         Remove "dtr" member.
7865         (struct notif_client) <alloc_event>: Return a unique_ptr.
7866         (notif_event_xfree): Don't declare.
7867         (notif_event_up): New typedef.
7868         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7869         (notif_event_xfree, do_notif_event_xfree): Remove.
7870         (remote_notif_state_xfree): Update.
7871
7872 2019-03-06  Tom Tromey  <tom@tromey.com>
7873
7874         * infrun.c (displaced_step_clear_cleanup): Now a
7875         forward_scope_exit type.
7876         (displaced_step_prepare_throw): Update.
7877         (displaced_step_fixup): Update.
7878
7879 2019-03-06  Tom Tromey  <tom@tromey.com>
7880
7881         * inferior.h (class inferior): Update comment.
7882         * gdbthread.h (class thread_info): Update comment.
7883
7884 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7885             Tom Tromey  <tom@tromey.com>
7886
7887         * stabsread.h (struct stab_section_list): Remove.
7888         (coffstab_build_psymtabs): Update.
7889         * dbxread.c (symbuf_sections): Now a std::vector.
7890         (sect_idx): New global.
7891         (fill_symbuf): Update.
7892         (coffstab_build_psymtabs): Change type of stabsects parameter.
7893         Update.
7894         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7895         std::vector.
7896         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7897         (coff_locate_sections): Update.
7898         (coff_symfile_read): Remove cleanups.  Update.
7899         (init_stringtab): Add storage parameter.
7900         (free_stringtab, free_stringtab_cleanup): Remove.
7901         (init_lineno): Add storage parameter.
7902         (free_linetab, free_linetab_cleanup): Remove.
7903
7904 2019-03-06  Pedro Alves  <palves@redhat.com>
7905
7906         * linux-fork.c (fork_info::clobber_regs): Delete.
7907         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7908         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7909         comment.  Adjust.
7910         (scoped_switch_fork_info::scoped_switch_fork_info)
7911         (checkpoint_command, linux_fork_context): Adjust
7912         fork_save_infrun_state calls.
7913
7914 2019-03-06  Pedro Alves  <palves@redhat.com>
7915
7916         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7917         (inf_has_multiple_threads): Return 'bool' and rewrite using
7918         inferior_info::threads().
7919
7920 2019-03-06  Pedro Alves  <palves@redhat.com>
7921
7922         * linux-fork.c: Include <list>.
7923         (fork_list): Now a std::list instance.
7924         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7925         (forks_exist_p, find_last_fork): Adjust.
7926         (new_fork): Delete.
7927         (one_fork_p): New.
7928         (add_fork): Adjust.
7929         (free_fork): Delete, folded into fork_info::~fork_info().
7930         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7931         Adjust.
7932         (init_fork_list): Delete.
7933         (linux_fork_killall, linux_fork_mourn_inferior)
7934         (linux_fork_detach, info_checkpoints_command): Adjust.
7935         (_initialize_linux_fork): No longer call init_fork_list.
7936
7937 2019-03-06  Pedro Alves  <palves@redhat.com>
7938
7939         * linux-fork.c (new_fork): New, split out of ...
7940         (add_fork): ... this.  Return void.  Move "first fork" special
7941         case from here, to ...
7942         (checkpoint_command): ... here.
7943         * linux-linux.h (add_fork): Return void.
7944
7945 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7946
7947         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7948
7949 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7950             Chris January  <chris.january@arm.com>
7951             David Lecomber  <david.lecomber@arm.com>
7952
7953         * f-exp.y: New token, UNOP_INTRINSIC.
7954         (exp): New pattern using UNOP_INTRINSIC token.
7955         (f77_keywords): Add 'abs' keyword.
7956         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7957         (value_from_host_double): New function.
7958         (evaluate_subexp_f): Support UNOP_ABS.
7959
7960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7963         types.
7964
7965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7966
7967         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7968         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7969         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7970
7971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7974
7975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7976             Chris January  <chris.january@arm.com>
7977
7978         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7979         * f-exp.y: Define 'KIND' token.
7980         (exp): New pattern for KIND expressions.
7981         (ptype): Handle types with a kind extension.
7982         (direct_abs_decl): Extend to spot kind extensions.
7983         (f77_keywords): Add 'kind' to the list.
7984         (push_kind_type): New function.
7985         (convert_to_kind_type): New function.
7986         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7987         * parse.c (operator_length_standard): Likewise.
7988         * parser-defs.h (enum type_pieces): Add tp_kind.
7989         * std-operator.def: Add UNOP_KIND.
7990
7991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * f-exp.y (f_parse): Set yydebug.
7994
7995 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7996
7997         * f-lang.c (evaluate_subexp_f): New function.
7998         (exp_descriptor_f): New global.
7999         (f_language_defn): Use exp_descriptor_f instead of
8000         exp_descriptor_standard.
8001
8002 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8003
8004         * f-exp.y (struct token): Add comments.
8005         (dot_ops): Remove uppercase versions and the end marker.
8006         (f77_keywords): Likewise.
8007         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8008         entries in the dot_ops array are case insensitive, and use
8009         strncasecmp to compare strings.  Also some whitespace cleanup in
8010         this area.  Similar for the f77_keywords array, except entries in
8011         this list might be case sensitive.
8012
8013 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         * f-exp.y (struct f77_boolean_val): Add comments.
8016         (boolean_values): Remove uppercase versions, and end marker.
8017         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8018         and use strncasecmp to achieve case insensitivity.  Additionally,
8019         perform whitespace cleanup around this code.
8020
8021 2019-03-06  Tom Tromey  <tromey@adacore.com>
8022
8023         * remote-sim.c (gdbsim_target_open): Use result of
8024         gdb_argv::release.
8025
8026 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8027         Dirk Schubert  <dirk.schubert@arm.com>
8028         Chris January  <chris.january@arm.com>
8029
8030         * eval.c (evaluate_subexp_standard): Call Fortran argument
8031         wrapping logic.
8032         * f-lang.c (struct value): A value which can be passed into a
8033         Fortran function call.
8034         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8035         where appropriate.
8036         (struct type): Value ready for a Fortran function call.
8037         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8038         is needed.
8039         * f-lang.h (fortran_argument_convert): Declaration.
8040         (fortran_preserve_arg_pointer): Declaration.
8041         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8042
8043 2019-03-05  Tom Tromey  <tromey@adacore.com>
8044
8045         * python/py-prettyprint.c (print_string_repr): Remove #if.
8046         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8047
8048 2019-03-05  Tom Tromey  <tromey@adacore.com>
8049
8050         * target.c (the_dummy_target): Move later.  Change type to
8051         "dummy_target".
8052         (initialize_targets): Don't initialize the_dummy_target.
8053
8054 2019-03-05  Tom Tromey  <tromey@adacore.com>
8055
8056         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8057         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8058
8059 2019-03-05  Tom Tromey  <tromey@adacore.com>
8060
8061         * windows-nat.c (windows_nat_target::attach)
8062         (windows_nat_target::detach): Don't call gdb_flush.
8063         * valprint.c (generic_val_print, val_print, val_print_string):
8064         Don't call gdb_flush.
8065         * utils.c (defaulted_query): Don't call gdb_flush.
8066         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8067         * target.c (target_announce_detach): Don't call gdb_flush.
8068         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8069         * remote.c (extended_remote_target::attach): Don't call
8070         gdb_flush.
8071         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8072         * printcmd.c (do_examine): Don't call gdb_flush.
8073         (info_display_command): Don't call gdb_flush.
8074         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8075         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8076         * memattr.c (info_mem_command): Don't call gdb_flush.
8077         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8078         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8079         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8080         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8081         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8082         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8083         (gnu_nat_target::detach): Don't call gdb_flush.
8084         * f-valprint.c (f_val_print): Don't call gdb_flush.
8085         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8086         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8087         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8088         gdb_flush.
8089         * c-valprint.c (c_val_print): Don't call gdb_flush.
8090         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8091
8092 2019-03-05  Tom Tromey  <tromey@adacore.com>
8093
8094         * varobj.c (update_dynamic_varobj_children): Update.
8095         (install_default_visualizer): Use reset, not release.
8096         * value.c (set_internalvar): Update.
8097         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8098         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8099         ATTRIBUTE_UNUSED_RESULT.
8100
8101 2019-03-05  Tom Tromey  <tromey@adacore.com>
8102
8103         * remote.c (class scoped_remote_fd) <release>: Add
8104         ATTRIBUTE_UNUSED_RESULT.
8105
8106 2019-03-05  Tom Tromey  <tromey@adacore.com>
8107
8108         * macroexp.c (struct macro_buffer) <release>: Add
8109         ATTRIBUTE_UNUSED_RESULT.
8110
8111 2019-03-05  Tom Tromey  <tromey@adacore.com>
8112
8113         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8114         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8115         ATTRIBUTE_UNUSED_RESULT.
8116
8117 2019-03-05  Tom Tromey  <tromey@adacore.com>
8118
8119         * common/scoped_fd.h (class scoped_fd) <release>: Add
8120         ATTRIBUTE_UNUSED_RESULT.
8121
8122 2019-03-05  Tom Tromey  <tromey@adacore.com>
8123
8124         * parser-defs.h (struct parser_state) <release>: Add
8125         ATTRIBUTE_UNUSED_RESULT.
8126
8127 2019-03-05  Tom Tromey  <tromey@adacore.com>
8128
8129         * utils.h (class gdb_argv) <release>: Add
8130         ATTRIBUTE_UNUSED_RESULT.
8131         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8132
8133 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8134
8135         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8136         for-loop range, to avoid compiler warnings.
8137
8138         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8139         avoid compiler warnings about unused variables.
8140
8141         * NEWS: Mention end of support for native debugging on MS-Windows
8142         before XP.
8143
8144         PR gdb/24292
8145         * common/netstuff.c:
8146         * gdbserver/gdbreplay.c
8147         * gdbserver/remote-utils.c:
8148         * ser-tcp.c:
8149         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8150         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8151         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8152         'getaddrinfo' and 'freeaddrinfo' were not available before
8153         Windows XP, and mingw.org's MinGW headers by default define
8154         _WIN32_WINNT to 0x500.
8155
8156 2019-03-01  Gary Benson <gbenson@redhat.com>
8157
8158         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8159
8160 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8161             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8162
8163         PR gdb/8527
8164         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8165         set_sigint_trap, clear_sigint_trap.
8166
8167 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8168
8169         * target.c (target_detach): Clear the regcache and the
8170         frame cache.
8171
8172 2019-02-27  Pedro Alves  <palves@redhat.com>
8173
8174         * utils.c (set_screen_size): When we cap the height/width sizes,
8175         tweak the corresponding command variable to show "unlimited":
8176
8177 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8178             Pedro Alves  <palves@redhat.com>
8179
8180         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8181         before calling rl_set_screen_size.
8182
8183 2019-02-27  Tom Tromey  <tromey@adacore.com>
8184
8185         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8186         define.
8187         * python/py-value.c: Remove Python 2.4 workaround.
8188         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8189         workaround.
8190         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8191         Python 2.4 workaround.
8192         * python/python-internal.h: Remove Python 2.4 comment.
8193         (Py_ssize_t): Don't define.
8194         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8195         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8196         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8197         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8198         * python/python.c (do_start_initialization): Remove Python 2.4
8199         workaround.
8200         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8201         (print_children): Remove Python 2.4 workaround.
8202         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8203         workaround.
8204         (CHARBUFFERPROC_NAME): Remove.
8205         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8206         Python 2.4 workaround.
8207
8208 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8209
8210         * NEWS: Note minimum Python version.
8211
8212 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8213
8214         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8215         code from these functions.  Remove corresponding ifdefs.  Use
8216         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8217         Remove gotos and target of gotos.
8218         (infpy_search_memory): Likewise.
8219
8220 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8223         (hppa_gdbarch_init): Don't register deleted functions with
8224         gdbarch.
8225
8226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8227
8228         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8229         (h8300_unwind_sp): Delete.
8230         (h8300_dummy_id): Delete.
8231         (h8300_gdbarch_init): Don't register deleted functions with
8232         gdbarch.
8233
8234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8235
8236         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8237         (ft32_unwind_pc): Delete.
8238         (ft32_unwind_sp): Delete.
8239         (ft32_gdbarch_init): Don't register deleted functions with
8240         gdbarch.
8241
8242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8243
8244         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8245         (frv_unwind_pc): Delete.
8246         (frv_unwind_sp): Delete.
8247         (frv_gdbarch_init): Don't register deleted functions with
8248         gdbarch.
8249
8250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8251
8252         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8253         (riscv_unwind_pc): Delete.
8254         (riscv_unwind_sp): Delete.
8255         (riscv_gdbarch_init): Don't register deleted functions with
8256         gdbarch.
8257
8258 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8259
8260         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8261         (csky_unwind_pc): Delete.
8262         (csky_unwind_sp): Delete.
8263         (csky_gdbarch_init): Don't register deleted functions with
8264         gdbarch.
8265
8266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8267
8268         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8269         (cris_unwind_pc): Delete.
8270         (cris_unwind_sp): Delete.
8271         (cris_gdbarch_init): Don't register deleted functions with
8272         gdbarch.
8273
8274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8275
8276         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8277         (bfin_unwind_pc): Delete.
8278         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8279
8280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8281
8282         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8283         (arm_unwind_pc): Delete.
8284         (arm_unwind_sp): Delete.
8285         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8286
8287 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8290         (arc_unwind_pc): Delete.
8291         (arc_unwind_sp): Delete.
8292         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8293
8294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8295
8296         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8297         (alpha_unwind_pc): Delete.
8298         (alpha_gdbarch_init): Don't register deleted functions with
8299         gdbarch.
8300
8301 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8302
8303         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8304         (aarch64_unwind_pc): Delete.
8305         (aarch64_unwind_sp): Delete.
8306         (aarch64_gdbarch_init): Don't register deleted functions with
8307         gdbarch.
8308
8309 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * gdbtypes.c (type_align): Don't consider static members when
8312         computing structure alignment.
8313
8314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8315
8316         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8317         return 0 for other types.
8318         * arch-utils.c (default_type_align): Always return 0.
8319         * gdbarch.h: Regenerate.
8320         * gdbarch.sh (type_align): Extend comment.
8321         * gdbtypes.c (type_align): Add additional comments, always call
8322         gdbarch_type_align before applying the default rules.
8323         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8324         generic code will then apply a suitable default.
8325         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8326         types, return 0 for other types.
8327
8328 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8329
8330         * NEWS: Create a new section for the next release branch.
8331         Rename the section of the current branch, now that it has
8332         been cut.
8333
8334 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8335
8336         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8337         * version.in: Bump version to 8.3.50.DATE-git.
8338
8339 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8340
8341         * aix-thread.c (ptid_cmp): Remove unused variable.
8342         (get_signaled_thread): Likewise.
8343         (store_regs_user_thread): Likewise.
8344         (store_regs_kernel_thread): Likewise.
8345         (fetch_regs_kernel_thread): Remove shadowed variable.
8346
8347 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * features/riscv/32bit-cpu.xml: Add register numbers.
8350         * features/riscv/32bit-fpu.c: Regenerate.
8351         * features/riscv/32bit-fpu.xml: Add register numbers.
8352         * features/riscv/64bit-cpu.xml: Add register numbers.
8353         * features/riscv/64bit-fpu.c: Regenerate.
8354         * features/riscv/64bit-fpu.xml: Add register numbers.
8355
8356 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8357
8358         * NEWS: Mention two argument form of gdb.Value constructor.
8359         * python/py-value.c (convert_buffer_and_type_to_value): New
8360         function.
8361         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8362         Add support for handling an optional second argument.  Call
8363         convert_buffer_and_type_to_value as appropriate.
8364         * python/python-internal.h (Py_buffer_deleter): New struct.
8365         (Py_buffer_up): New typedef.
8366
8367 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8368
8369         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8370         instead of releasing ownership.
8371
8372 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8373
8374         * dwarf2read.c (open_and_init_dwp_file): Call
8375         elf_numsections instead of bfd_count_sections to initialize
8376         dwp_file->num_sections.
8377
8378 2019-02-25  Tom Tromey  <tromey@adacore.com>
8379
8380         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8381
8382 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8383
8384         * gcore.in: Add '--readnever' option when invoking GDB.
8385
8386 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8387
8388         * MAINTAINERS: Update my email address.
8389
8390 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8391
8392         * build-id.c (build_id_to_debug_bfd_1): New function.
8393         (build_id_to_debug_bfd): Look for separate debug file in
8394         sysroot.
8395
8396 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8397
8398         * gdbarch.sh: Update the copyright year range that is placed into
8399         generated files.
8400
8401 2019-02-22  Keith Seitz  <keiths@redhat.com>
8402
8403         PR symtab/23853
8404         * linespec.c (create_sals_line_offset): Search for the default
8405         symtab's filename instead of its fullname.
8406
8407 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8408
8409         * NEWS: Update style defaults.
8410
8411 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8412
8413         * main.c (captured_main_1): Disable styling in batch mode.
8414
8415 2019-02-20  Tom Tromey  <tom@tromey.com>
8416
8417         * symtab.c (symtab_symbol_info): Fix typos.
8418
8419 2019-02-20  Tom Tromey  <tromey@adacore.com>
8420
8421         * findcmd.c (_initialize_mem_search): Use upper case for
8422         metasyntactic variables.
8423
8424 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8425
8426         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8427         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8428
8429 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8430
8431         * top.h (source_file_name): Change to std::string.
8432         * top.c (source_file_name): Likewise.
8433         (command_line_input): Adjust.
8434         * cli/cli-script.c (script_from_file): Adjust.
8435
8436 2019-02-19  Tom Tromey  <tromey@adacore.com>
8437
8438         * ravenscar-thread.c
8439         (ravenscar_thread_target::update_thread_list): Don't call
8440         ada_build_task_list.
8441         * ada-lang.h (ada_build_task_list): Don't declare.
8442         * ada-tasks.c (struct ada_tasks_inferior_data)
8443         <task_list_valid_p>: Now bool.
8444         (read_known_tasks, ada_task_list_changed)
8445         (ada_tasks_invalidate_inferior_data): Update.
8446         (read_known_tasks_array): Return bool.
8447         (read_known_tasks_list): Likewise.
8448         (read_known_tasks): Return void.
8449         (ada_build_task_list): Now static.
8450
8451 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8452
8453         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8454         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8455
8456 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8457
8458         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8459         variant for ada_tasks_pspace_data_handle and
8460         ada_tasks_inferior_data_handle.
8461         (ada_tasks_pspace_data_cleanup): New function.
8462         (ada_tasks_inferior_data_cleanup): New function.
8463
8464 2019-02-17  Tom Tromey  <tom@tromey.com>
8465
8466         * macrotab.h (macro_source_fullname): Return a std::string.
8467         * macrotab.c (macro_include, check_for_redefinition)
8468         (macro_undef, macro_lookup_definition, foreach_macro)
8469         (foreach_macro_in_scope): Update.
8470         (macro_source_fullname): Return a std::string.
8471         * macrocmd.c (show_pp_source_pos): Update.
8472
8473 2019-02-17  Tom Tromey  <tom@tromey.com>
8474
8475         * macrocmd.c (show_pp_source_pos): Style the file names.
8476
8477 2019-02-17  Tom Tromey  <tom@tromey.com>
8478
8479         PR tui/24197:
8480         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8481
8482 2019-02-17  Tom Tromey  <tom@tromey.com>
8483
8484         * ada-lang.c (user_select_syms): Use filtered printing.
8485         * utils.c (wrap_style): New global.
8486         (desired_style): Remove.
8487         (emit_style_escape): Add stream parameter.
8488         (set_output_style, reset_terminal_style, prompt_for_continue):
8489         Update.
8490         (flush_wrap_buffer): Only flush gdb_stdout.
8491         (wrap_here): Set wrap_style.
8492         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8493         treat escape sequences as a character.  Change when wrap buffer is
8494         flushed.
8495         (fputs_styled): Do not set the output style when the default is
8496         requested.
8497         * ui-style.h (struct ui_file_style) <is_default>: New method.
8498         * source.c (print_source_lines_base): Emit escape sequences in one
8499         piece.
8500
8501 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8502
8503         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8504         integers and enumeration types.
8505
8506 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8507
8508         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8509         instead of lookup_symbol_in_language
8510         (do_exact_match): New function.
8511         (ada_get_symbol_name_matcher): Return do_exact_match when
8512         doing a verbatim match.
8513
8514 2019-02-15  Tom Tromey  <tromey@adacore.com>
8515
8516         * ravenscar-thread.c (ravenscar_thread_target::resume)
8517         (ravenscar_thread_target::wait): Special case wildcard requests.
8518
8519 2019-02-15  Tom Tromey  <tromey@adacore.com>
8520
8521         * ravenscar-thread.c (base_ptid): Remove.
8522         (struct ravenscar_thread_target) <close>: New method.
8523         <m_base_ptid>: New member.
8524         <update_inferior_ptid, active_task, task_is_currently_active,
8525         runtime_initialized>: Declare methods.
8526         <ravenscar_thread_target>: Add constructor.
8527         (ravenscar_thread_target::task_is_currently_active)
8528         (ravenscar_thread_target::update_inferior_ptid)
8529         (ravenscar_runtime_initialized): Rename.  Now methods.
8530         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8531         (ravenscar_thread_target::update_thread_list): Update.
8532         (ravenscar_thread_target::active_task): Now method.
8533         (ravenscar_thread_target::store_registers)
8534         (ravenscar_thread_target::prepare_to_store)
8535         (ravenscar_thread_target::prepare_to_store)
8536         (ravenscar_thread_target::mourn_inferior): Update.
8537         (ravenscar_inferior_created): Use "new" to create target.
8538         (ravenscar_thread_target::get_ada_task_ptid): Update.
8539         (_initialize_ravenscar): Don't initialize base_ptid.
8540         (ravenscar_ops): Remove global.
8541
8542 2019-02-15  Tom Tromey  <tromey@adacore.com>
8543
8544         * target.h (push_target): Declare new overload.
8545         * target.c (push_target): New overload, taking an rvalue reference.
8546         * remote.c (remote_target::open_1): Use push_target overload.
8547         * corelow.c (core_target_open): Use push_target overload.
8548
8549 2019-02-15  Tom Tromey  <tromey@adacore.com>
8550
8551         * ravenscar-thread.c (is_ravenscar_task)
8552         (ravenscar_task_is_currently_active): Return bool.
8553         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8554         (_initialize_ravenscar): Remove "(void)".
8555         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8556         Return bool.
8557
8558 2019-02-15  Tom Tromey  <tromey@adacore.com>
8559
8560         * ravenscar-thread.c (ravenscar_runtime_initializer)
8561         (has_ravenscar_runtime, get_running_thread_id)
8562         (ravenscar_thread_target::resume): Fix indentation.
8563
8564 2019-02-15  Tom Tromey  <tromey@adacore.com>
8565
8566         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8567         from ravenscar_arch_ops.
8568         (sparc_ravenscar_ops::fetch_registers)
8569         (sparc_ravenscar_ops::store_registers): Now methods.
8570         (sparc_ravenscar_prepare_to_store): Remove.
8571         (sparc_ravenscar_ops): Redefine.
8572         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8573         methods and destructor.  Remove members.
8574         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8575         (ravenscar_thread_target::store_registers)
8576         (ravenscar_thread_target::prepare_to_store): Update.
8577         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8578         Remove.
8579         (struct ppc_ravenscar_powerpc_ops): Derive from
8580         ravenscar_arch_ops.
8581         (ppc_ravenscar_powerpc_ops::fetch_registers)
8582         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8583         (ppc_ravenscar_powerpc_ops): Redefine.
8584         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8585         (ppc_ravenscar_e500_ops::fetch_registers)
8586         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8587         (ppc_ravenscar_e500_ops): Redefine.
8588         * aarch64-ravenscar-thread.c
8589         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8590         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8591         (aarch64_ravenscar_fetch_registers)
8592         (aarch64_ravenscar_store_registers): Now methods.
8593         (aarch64_ravenscar_ops): Redefine.
8594
8595 2019-02-15  Tom Tromey  <tromey@adacore.com>
8596
8597         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8598         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8599         (ravenscar_thread_target::stopped_by_watchpoint)
8600         (ravenscar_thread_target::stopped_data_address)
8601         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8602
8603 2019-02-15  Tom Tromey  <tromey@adacore.com>
8604
8605         * ravenscar-thread.c: Fix some typos.
8606
8607 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8608             Tom Tromey  <tromey@adacore.com>
8609
8610         * ada-lang.c (ada_exception_sal): Change addr_string to a
8611         std::string.
8612         (create_ada_exception_catchpoint): Update.
8613
8614 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8615             Tom Tromey  <tromey@adacore.com>
8616
8617         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8618         (bp_location_ops): Remove.
8619         (base_breakpoint_allocate_location): Update.
8620         (free_bp_location): Update.
8621         * ada-lang.c (class ada_catchpoint_location)
8622         <ada_catchpoint_location>: Remove ops parameter.
8623         (ada_catchpoint_location_dtor): Remove.
8624         (ada_catchpoint_location_ops): Remove.
8625         (allocate_location_exception): Update.
8626         * breakpoint.h (struct bp_location_ops): Remove.
8627         (class bp_location) <bp_location>: Remove bp_location_ops
8628         parameter.
8629         <~bp_location>: Add destructor.
8630         <ops>: Remove.
8631
8632 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8633             Pedro Alves  <palves@redhat.com>
8634
8635         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8636         'PATH_MAX'.
8637
8638 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8639             Samuel Thibault  <samuel.thibault@gnu.org>
8640             Thomas Schwinge  <thomas@codesourcery.com>
8641
8642         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8643         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8644
8645 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8646
8647         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8648         (check_empty): Use "const char *".
8649
8650         * gnu-nat.c (gnu_nat_target::detach): Instead of
8651         'detach_inferior (pid)' call
8652         'detach_inferior (find_inferior_pid (pid))'.
8653
8654         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8655         'nat/fork-inferior.o'.
8656         * gnu-nat.c: #include "nat/fork-inferior.h".
8657
8658         * gnu-nat.c (gnu_nat_target::detach): Instead of
8659         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8660         * gnu-nat.h: #include "inf-child.h".
8661         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8662         'i386_gnu_nat_target::fetch_registers'.
8663         (gnu_store_registers): Rename/move to
8664         'i386_gnu_nat_target::store_registers'.
8665
8666         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8667         * gnu-nat.h (mach_thread_info): New function.
8668         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8669
8670         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8671
8672 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8673
8674         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8675
8676 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8677
8678         * windows-nat.c (windows_add_thread): Add new parameter
8679         "main_thread_p" with default value set to false.  Update
8680         function documentation as well as all callers.
8681         (windows_delete_thread): Likewise.
8682         (fake_create_process): Update call to windows_add_thread.
8683         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8684         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8685         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8686         call to windows_delete_thread.
8687
8688 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8689
8690         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8691
8692 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8693
8694         * symfile.c (find_separate_debug_file): Use canonical path of
8695         sysroot with child_path instead of gdb_sysroot if it is valid.
8696
8697 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8698
8699         * symfile.c (find_separate_debug_file): Use child_path to
8700         determine if an object file is under a sysroot.
8701
8702 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8703
8704         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8705         unittests/child-path-selftests.c.
8706         * common/pathstuff.c (child_path): New function.
8707         * common/pathstuff.h (child_path): New prototype.
8708         * unittests/child-path-selftests.c: New file.
8709
8710 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8711
8712         * symfile.c (find_separate_debug_file): Look for separate debug
8713         files in debug directories under the sysroot.
8714
8715 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8716
8717         * symtab.h (struct minimal_symbol data_p): New const method.
8718         (struct minimal_symbol text_p): Likewise.
8719         * symtab.c (output_source_filename): Use file name style
8720         to print file name.
8721         (print_symbol_info): Likewise.
8722         (print_msymbol_info): Use address style to print addresses.
8723         Use function name style to print executable text symbols.
8724         (expand_symtab_containing_pc): Use data_p.
8725         (find_pc_sect_compunit_symtab): Likewise.
8726
8727 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8728
8729         * breakpoint.c (describe_other_breakpoints): Use address style
8730         to print addresses.
8731         (say_where): Likewise.
8732
8733 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8734
8735         * ada-typeprint.c (print_func_type): Print function name
8736         style to print function name.
8737         * c-typeprint.c (c_print_type_1): Likewise.
8738
8739 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8740
8741         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8742         for execve.
8743
8744 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8745
8746         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8747         type_stack.
8748
8749 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8750
8751         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8752         TYPE_CODE_REF types.
8753
8754 2019-02-08  Jim Wilson  <jimw@sifive.com>
8755
8756         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8757         (riscv_linux_fregset): New.
8758         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8759
8760 2019-02-07  Tom Tromey  <tom@tromey.com>
8761
8762         * thread.c (thread_cancel_execution_command): Update.
8763         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8764         methods.
8765         (struct thread_fsm_ops): Remove.
8766         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8767         (thread_fsm_should_stop, thread_fsm_return_value)
8768         (thread_fsm_set_finished, thread_fsm_finished_p)
8769         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8770         Don't declare.
8771         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8772         * infrun.c (clear_proceed_status_thread)
8773         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8774         (print_stop_event): Update.
8775         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8776         Add constructor.
8777         (step_command_fsm_ops): Remove.
8778         (new_step_command_fsm): Remove.
8779         (step_1): Update.
8780         (step_command_fsm::should_stop): Rename from
8781         step_command_fsm_should_stop.
8782         (step_command_fsm::clean_up): Rename from
8783         step_command_fsm_clean_up.
8784         (step_command_fsm::do_async_reply_reason): Rename from
8785         step_command_fsm_async_reply_reason.
8786         (struct until_next_fsm): Inherit from thread_fsm.  Add
8787         constructor.
8788         (until_next_fsm_ops): Remove.
8789         (new_until_next_fsm): Remove.
8790         (until_next_fsm::should_stop): Rename from
8791         until_next_fsm_should_stop.
8792         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8793         (until_next_fsm::do_async_reply_reason): Rename from
8794         until_next_fsm_async_reply_reason.
8795         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8796         constructor.  Change type of breakpoint.
8797         (finish_command_fsm_ops): Remove.
8798         (new_finish_command_fsm): Remove.
8799         (finish_command_fsm::should_stop): Rename from
8800         finish_command_fsm_should_stop.
8801         (finish_command_fsm::clean_up): Rename from
8802         finish_command_fsm_clean_up.
8803         (finish_command_fsm::return_value): Rename from
8804         finish_command_fsm_return_value.
8805         (finish_command_fsm::do_async_reply_reason): Rename from
8806         finish_command_fsm_async_reply_reason.
8807         (finish_command): Update.
8808         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8809         Add constructor.
8810         (call_thread_fsm_ops): Remove.
8811         (call_thread_fsm::call_thread_fsm): Rename from
8812         new_call_thread_fsm.
8813         (call_thread_fsm::should_stop): Rename from
8814         call_thread_fsm_should_stop.
8815         (call_thread_fsm::should_notify_stop): Rename from
8816         call_thread_fsm_should_notify_stop.
8817         (run_inferior_call, call_function_by_hand_dummy): Update.
8818         * cli/cli-interp.c (should_print_stop_to_console): Update.
8819         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8820         Add constructor.  Change type of location_breakpoint,
8821         caller_breakpoint.
8822         (until_break_fsm_ops): Remove.
8823         (new_until_break_fsm): Remove.
8824         (until_break_fsm::should_stop): Rename from
8825         until_break_fsm_should_stop.
8826         (until_break_fsm::clean_up): Rename from
8827         until_break_fsm_clean_up.
8828         (until_break_fsm::do_async_reply_reason): Rename from
8829         until_break_fsm_async_reply_reason.
8830         (until_break_command): Update.
8831         * thread-fsm.c: Remove.
8832         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8833
8834 2019-02-07  Tom Tromey  <tom@tromey.com>
8835
8836         * yy-remap.h: Add include guard.
8837         * xtensa-tdep.h: Add include guard.
8838         * xcoffread.h: Rename include guard.
8839         * varobj-iter.h: Add include guard.
8840         * tui/tui.h: Rename include guard.
8841         * tui/tui-winsource.h: Rename include guard.
8842         * tui/tui-wingeneral.h: Rename include guard.
8843         * tui/tui-windata.h: Rename include guard.
8844         * tui/tui-win.h: Rename include guard.
8845         * tui/tui-stack.h: Rename include guard.
8846         * tui/tui-source.h: Rename include guard.
8847         * tui/tui-regs.h: Rename include guard.
8848         * tui/tui-out.h: Rename include guard.
8849         * tui/tui-layout.h: Rename include guard.
8850         * tui/tui-io.h: Rename include guard.
8851         * tui/tui-hooks.h: Rename include guard.
8852         * tui/tui-file.h: Rename include guard.
8853         * tui/tui-disasm.h: Rename include guard.
8854         * tui/tui-data.h: Rename include guard.
8855         * tui/tui-command.h: Rename include guard.
8856         * tic6x-tdep.h: Add include guard.
8857         * target/waitstatus.h: Rename include guard.
8858         * target/wait.h: Rename include guard.
8859         * target/target.h: Rename include guard.
8860         * target/resume.h: Rename include guard.
8861         * target-float.h: Rename include guard.
8862         * stabsread.h: Add include guard.
8863         * rs6000-tdep.h: Add include guard.
8864         * riscv-fbsd-tdep.h: Add include guard.
8865         * regformats/regdef.h: Rename include guard.
8866         * record.h: Rename include guard.
8867         * python/python.h: Rename include guard.
8868         * python/python-internal.h: Rename include guard.
8869         * python/py-stopevent.h: Rename include guard.
8870         * python/py-ref.h: Rename include guard.
8871         * python/py-record.h: Rename include guard.
8872         * python/py-record-full.h: Rename include guard.
8873         * python/py-record-btrace.h: Rename include guard.
8874         * python/py-instruction.h: Rename include guard.
8875         * python/py-events.h: Rename include guard.
8876         * python/py-event.h: Rename include guard.
8877         * procfs.h: Add include guard.
8878         * proc-utils.h: Add include guard.
8879         * p-lang.h: Add include guard.
8880         * or1k-tdep.h: Rename include guard.
8881         * observable.h: Rename include guard.
8882         * nto-tdep.h: Rename include guard.
8883         * nat/x86-linux.h: Rename include guard.
8884         * nat/x86-linux-dregs.h: Rename include guard.
8885         * nat/x86-gcc-cpuid.h: Add include guard.
8886         * nat/x86-dregs.h: Rename include guard.
8887         * nat/x86-cpuid.h: Rename include guard.
8888         * nat/ppc-linux.h: Rename include guard.
8889         * nat/mips-linux-watch.h: Rename include guard.
8890         * nat/linux-waitpid.h: Rename include guard.
8891         * nat/linux-ptrace.h: Rename include guard.
8892         * nat/linux-procfs.h: Rename include guard.
8893         * nat/linux-osdata.h: Rename include guard.
8894         * nat/linux-nat.h: Rename include guard.
8895         * nat/linux-namespaces.h: Rename include guard.
8896         * nat/linux-btrace.h: Rename include guard.
8897         * nat/glibc_thread_db.h: Rename include guard.
8898         * nat/gdb_thread_db.h: Rename include guard.
8899         * nat/gdb_ptrace.h: Rename include guard.
8900         * nat/fork-inferior.h: Rename include guard.
8901         * nat/amd64-linux-siginfo.h: Rename include guard.
8902         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8903         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8904         * nat/aarch64-linux.h: Rename include guard.
8905         * nat/aarch64-linux-hw-point.h: Rename include guard.
8906         * mn10300-tdep.h: Add include guard.
8907         * mips-linux-tdep.h: Add include guard.
8908         * mi/mi-parse.h: Rename include guard.
8909         * mi/mi-out.h: Rename include guard.
8910         * mi/mi-main.h: Rename include guard.
8911         * mi/mi-interp.h: Rename include guard.
8912         * mi/mi-getopt.h: Rename include guard.
8913         * mi/mi-console.h: Rename include guard.
8914         * mi/mi-common.h: Rename include guard.
8915         * mi/mi-cmds.h: Rename include guard.
8916         * mi/mi-cmd-break.h: Rename include guard.
8917         * m2-lang.h: Add include guard.
8918         * location.h: Rename include guard.
8919         * linux-record.h: Rename include guard.
8920         * linux-nat.h: Add include guard.
8921         * linux-fork.h: Add include guard.
8922         * i386-darwin-tdep.h: Rename include guard.
8923         * hppa-linux-offsets.h: Add include guard.
8924         * guile/guile.h: Rename include guard.
8925         * guile/guile-internal.h: Rename include guard.
8926         * gnu-nat.h: Rename include guard.
8927         * gdb-stabs.h: Rename include guard.
8928         * frv-tdep.h: Add include guard.
8929         * f-lang.h: Add include guard.
8930         * event-loop.h: Add include guard.
8931         * darwin-nat.h: Rename include guard.
8932         * cp-abi.h: Rename include guard.
8933         * config/sparc/nm-sol2.h: Rename include guard.
8934         * config/nm-nto.h: Rename include guard.
8935         * config/nm-linux.h: Add include guard.
8936         * config/i386/nm-i386gnu.h: Rename include guard.
8937         * config/djgpp/nl_types.h: Rename include guard.
8938         * config/djgpp/langinfo.h: Rename include guard.
8939         * compile/gcc-cp-plugin.h: Add include guard.
8940         * compile/gcc-c-plugin.h: Add include guard.
8941         * compile/compile.h: Rename include guard.
8942         * compile/compile-object-run.h: Rename include guard.
8943         * compile/compile-object-load.h: Rename include guard.
8944         * compile/compile-internal.h: Rename include guard.
8945         * compile/compile-cplus.h: Rename include guard.
8946         * compile/compile-c.h: Rename include guard.
8947         * common/xml-utils.h: Rename include guard.
8948         * common/x86-xstate.h: Rename include guard.
8949         * common/version.h: Rename include guard.
8950         * common/vec.h: Rename include guard.
8951         * common/tdesc.h: Rename include guard.
8952         * common/selftest.h: Rename include guard.
8953         * common/scoped_restore.h: Rename include guard.
8954         * common/scoped_mmap.h: Rename include guard.
8955         * common/scoped_fd.h: Rename include guard.
8956         * common/safe-iterator.h: Rename include guard.
8957         * common/run-time-clock.h: Rename include guard.
8958         * common/refcounted-object.h: Rename include guard.
8959         * common/queue.h: Rename include guard.
8960         * common/ptid.h: Rename include guard.
8961         * common/print-utils.h: Rename include guard.
8962         * common/preprocessor.h: Rename include guard.
8963         * common/pathstuff.h: Rename include guard.
8964         * common/observable.h: Rename include guard.
8965         * common/netstuff.h: Rename include guard.
8966         * common/job-control.h: Rename include guard.
8967         * common/host-defs.h: Rename include guard.
8968         * common/gdb_wait.h: Rename include guard.
8969         * common/gdb_vecs.h: Rename include guard.
8970         * common/gdb_unlinker.h: Rename include guard.
8971         * common/gdb_unique_ptr.h: Rename include guard.
8972         * common/gdb_tilde_expand.h: Rename include guard.
8973         * common/gdb_sys_time.h: Rename include guard.
8974         * common/gdb_string_view.h: Rename include guard.
8975         * common/gdb_splay_tree.h: Rename include guard.
8976         * common/gdb_setjmp.h: Rename include guard.
8977         * common/gdb_ref_ptr.h: Rename include guard.
8978         * common/gdb_optional.h: Rename include guard.
8979         * common/gdb_locale.h: Rename include guard.
8980         * common/gdb_assert.h: Rename include guard.
8981         * common/filtered-iterator.h: Rename include guard.
8982         * common/filestuff.h: Rename include guard.
8983         * common/fileio.h: Rename include guard.
8984         * common/environ.h: Rename include guard.
8985         * common/common-utils.h: Rename include guard.
8986         * common/common-types.h: Rename include guard.
8987         * common/common-regcache.h: Rename include guard.
8988         * common/common-inferior.h: Rename include guard.
8989         * common/common-gdbthread.h: Rename include guard.
8990         * common/common-exceptions.h: Rename include guard.
8991         * common/common-defs.h: Rename include guard.
8992         * common/common-debug.h: Rename include guard.
8993         * common/cleanups.h: Rename include guard.
8994         * common/buffer.h: Rename include guard.
8995         * common/btrace-common.h: Rename include guard.
8996         * common/break-common.h: Rename include guard.
8997         * cli/cli-utils.h: Rename include guard.
8998         * cli/cli-style.h: Rename include guard.
8999         * cli/cli-setshow.h: Rename include guard.
9000         * cli/cli-script.h: Rename include guard.
9001         * cli/cli-interp.h: Rename include guard.
9002         * cli/cli-decode.h: Rename include guard.
9003         * cli/cli-cmds.h: Rename include guard.
9004         * charset-list.h: Add include guard.
9005         * buildsym-legacy.h: Rename include guard.
9006         * bfin-tdep.h: Add include guard.
9007         * ax.h: Rename include guard.
9008         * arm-linux-tdep.h: Add include guard.
9009         * arm-fbsd-tdep.h: Add include guard.
9010         * arch/xtensa.h: Rename include guard.
9011         * arch/tic6x.h: Add include guard.
9012         * arch/i386.h: Add include guard.
9013         * arch/arm.h: Rename include guard.
9014         * arch/arm-linux.h: Rename include guard.
9015         * arch/arm-get-next-pcs.h: Rename include guard.
9016         * arch/amd64.h: Add include guard.
9017         * arch/aarch64-insn.h: Rename include guard.
9018         * arch-utils.h: Rename include guard.
9019         * annotate.h: Add include guard.
9020         * amd64-darwin-tdep.h: Rename include guard.
9021         * aarch64-linux-tdep.h: Add include guard.
9022         * aarch64-fbsd-tdep.h: Add include guard.
9023         * aarch32-linux-nat.h: Add include guard.
9024
9025 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9026
9027         * macrotab.c (macro_define_internal): New function that
9028         factorizes macro_define_object_internal and macro_define_function
9029         code.
9030         (macro_define_object_internal): Use macro_define_internal.
9031         (macro_define_function): Likewise.
9032
9033 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9034
9035         * macrocmd.c (extract_identifier): Return
9036         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9037         callers.
9038
9039 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9040
9041         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9042
9043 2019-02-05  Tom Tromey  <tom@tromey.com>
9044
9045         * target.c (target_stack::unpush): Move assertion earlier.
9046
9047 2019-01-30  Tom Tromey  <tom@tromey.com>
9048
9049         PR python/23615:
9050         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9051         (gdbpy_parse_and_eval): Likewise.
9052         * python/python-internal.h (gdbpy_allow_threads): New class.
9053
9054 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9055
9056         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9057         (aarch64_fbsd_fpregmap): Move earlier.
9058         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9059         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9060         instead of individual calls to trad_frame_set_reg_addr.
9061         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9062         earlier.
9063         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9064         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9065         instead of individual calls to trad_frame_set_reg_addr.
9066
9067 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9068
9069         * CONTRIBUTE: Replace contribution list with wiki link.
9070
9071 2019-01-25  Tom Tromey  <tom@tromey.com>
9072
9073         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9074
9075 2019-01-25  Tom Tromey  <tom@tromey.com>
9076
9077         * xtensa-linux-nat.c: Fix common/ includes.
9078         * xml-support.h: Fix common/ includes.
9079         * xml-support.c: Fix common/ includes.
9080         * x86-linux-nat.c: Fix common/ includes.
9081         * windows-nat.c: Fix common/ includes.
9082         * varobj.h: Fix common/ includes.
9083         * varobj.c: Fix common/ includes.
9084         * value.c: Fix common/ includes.
9085         * valops.c: Fix common/ includes.
9086         * utils.c: Fix common/ includes.
9087         * unittests/xml-utils-selftests.c: Fix common/ includes.
9088         * unittests/utils-selftests.c: Fix common/ includes.
9089         * unittests/unpack-selftests.c: Fix common/ includes.
9090         * unittests/tracepoint-selftests.c: Fix common/ includes.
9091         * unittests/style-selftests.c: Fix common/ includes.
9092         * unittests/string_view-selftests.c: Fix common/ includes.
9093         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9094         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9095         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9096         * unittests/rsp-low-selftests.c: Fix common/ includes.
9097         * unittests/parse-connection-spec-selftests.c: Fix common/
9098         includes.
9099         * unittests/optional-selftests.c: Fix common/ includes.
9100         * unittests/offset-type-selftests.c: Fix common/ includes.
9101         * unittests/observable-selftests.c: Fix common/ includes.
9102         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9103         * unittests/memrange-selftests.c: Fix common/ includes.
9104         * unittests/memory-map-selftests.c: Fix common/ includes.
9105         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9106         * unittests/function-view-selftests.c: Fix common/ includes.
9107         * unittests/environ-selftests.c: Fix common/ includes.
9108         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9109         * unittests/common-utils-selftests.c: Fix common/ includes.
9110         * unittests/cli-utils-selftests.c: Fix common/ includes.
9111         * unittests/array-view-selftests.c: Fix common/ includes.
9112         * ui-file.c: Fix common/ includes.
9113         * tui/tui-io.c: Fix common/ includes.
9114         * tracepoint.h: Fix common/ includes.
9115         * tracepoint.c: Fix common/ includes.
9116         * tracefile-tfile.c: Fix common/ includes.
9117         * top.h: Fix common/ includes.
9118         * top.c: Fix common/ includes.
9119         * thread.c: Fix common/ includes.
9120         * target/waitstatus.h: Fix common/ includes.
9121         * target/waitstatus.c: Fix common/ includes.
9122         * target.h: Fix common/ includes.
9123         * target.c: Fix common/ includes.
9124         * target-memory.c: Fix common/ includes.
9125         * target-descriptions.c: Fix common/ includes.
9126         * symtab.h: Fix common/ includes.
9127         * symfile.c: Fix common/ includes.
9128         * stap-probe.c: Fix common/ includes.
9129         * spu-linux-nat.c: Fix common/ includes.
9130         * sparc-nat.c: Fix common/ includes.
9131         * source.c: Fix common/ includes.
9132         * solib.c: Fix common/ includes.
9133         * solib-target.c: Fix common/ includes.
9134         * ser-unix.c: Fix common/ includes.
9135         * ser-tcp.c: Fix common/ includes.
9136         * ser-pipe.c: Fix common/ includes.
9137         * ser-base.c: Fix common/ includes.
9138         * selftest-arch.c: Fix common/ includes.
9139         * s12z-tdep.c: Fix common/ includes.
9140         * rust-exp.y: Fix common/ includes.
9141         * rs6000-aix-tdep.c: Fix common/ includes.
9142         * riscv-tdep.c: Fix common/ includes.
9143         * remote.c: Fix common/ includes.
9144         * remote-notif.h: Fix common/ includes.
9145         * remote-fileio.h: Fix common/ includes.
9146         * remote-fileio.c: Fix common/ includes.
9147         * regcache.h: Fix common/ includes.
9148         * regcache.c: Fix common/ includes.
9149         * record-btrace.c: Fix common/ includes.
9150         * python/python.c: Fix common/ includes.
9151         * python/py-type.c: Fix common/ includes.
9152         * python/py-inferior.c: Fix common/ includes.
9153         * progspace.h: Fix common/ includes.
9154         * producer.c: Fix common/ includes.
9155         * procfs.c: Fix common/ includes.
9156         * proc-api.c: Fix common/ includes.
9157         * printcmd.c: Fix common/ includes.
9158         * ppc-linux-nat.c: Fix common/ includes.
9159         * parser-defs.h: Fix common/ includes.
9160         * osdata.c: Fix common/ includes.
9161         * obsd-nat.c: Fix common/ includes.
9162         * nat/x86-linux.c: Fix common/ includes.
9163         * nat/x86-linux-dregs.c: Fix common/ includes.
9164         * nat/x86-dregs.h: Fix common/ includes.
9165         * nat/x86-dregs.c: Fix common/ includes.
9166         * nat/ppc-linux.c: Fix common/ includes.
9167         * nat/mips-linux-watch.h: Fix common/ includes.
9168         * nat/mips-linux-watch.c: Fix common/ includes.
9169         * nat/linux-waitpid.c: Fix common/ includes.
9170         * nat/linux-ptrace.h: Fix common/ includes.
9171         * nat/linux-ptrace.c: Fix common/ includes.
9172         * nat/linux-procfs.c: Fix common/ includes.
9173         * nat/linux-personality.c: Fix common/ includes.
9174         * nat/linux-osdata.c: Fix common/ includes.
9175         * nat/linux-namespaces.c: Fix common/ includes.
9176         * nat/linux-btrace.h: Fix common/ includes.
9177         * nat/linux-btrace.c: Fix common/ includes.
9178         * nat/fork-inferior.c: Fix common/ includes.
9179         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9180         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9181         * nat/aarch64-linux.c: Fix common/ includes.
9182         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9183         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9184         * namespace.h: Fix common/ includes.
9185         * mips-linux-tdep.c: Fix common/ includes.
9186         * minsyms.c: Fix common/ includes.
9187         * mi/mi-parse.h: Fix common/ includes.
9188         * mi/mi-main.c: Fix common/ includes.
9189         * mi/mi-cmd-env.c: Fix common/ includes.
9190         * memrange.h: Fix common/ includes.
9191         * memattr.c: Fix common/ includes.
9192         * maint.h: Fix common/ includes.
9193         * maint.c: Fix common/ includes.
9194         * main.c: Fix common/ includes.
9195         * machoread.c: Fix common/ includes.
9196         * location.c: Fix common/ includes.
9197         * linux-thread-db.c: Fix common/ includes.
9198         * linux-nat.c: Fix common/ includes.
9199         * linux-fork.c: Fix common/ includes.
9200         * inline-frame.c: Fix common/ includes.
9201         * infrun.c: Fix common/ includes.
9202         * inflow.c: Fix common/ includes.
9203         * inferior.h: Fix common/ includes.
9204         * inferior.c: Fix common/ includes.
9205         * infcmd.c: Fix common/ includes.
9206         * inf-ptrace.c: Fix common/ includes.
9207         * inf-child.c: Fix common/ includes.
9208         * ia64-linux-nat.c: Fix common/ includes.
9209         * i387-tdep.c: Fix common/ includes.
9210         * i386-tdep.c: Fix common/ includes.
9211         * i386-linux-tdep.c: Fix common/ includes.
9212         * i386-linux-nat.c: Fix common/ includes.
9213         * i386-go32-tdep.c: Fix common/ includes.
9214         * i386-fbsd-tdep.c: Fix common/ includes.
9215         * i386-fbsd-nat.c: Fix common/ includes.
9216         * guile/scm-type.c: Fix common/ includes.
9217         * guile/guile.c: Fix common/ includes.
9218         * go32-nat.c: Fix common/ includes.
9219         * gnu-nat.c: Fix common/ includes.
9220         * gdbthread.h: Fix common/ includes.
9221         * gdbarch-selftests.c: Fix common/ includes.
9222         * gdb_usleep.c: Fix common/ includes.
9223         * gdb_select.h: Fix common/ includes.
9224         * gdb_bfd.c: Fix common/ includes.
9225         * gcore.c: Fix common/ includes.
9226         * fork-child.c: Fix common/ includes.
9227         * findvar.c: Fix common/ includes.
9228         * fbsd-nat.c: Fix common/ includes.
9229         * event-top.c: Fix common/ includes.
9230         * event-loop.c: Fix common/ includes.
9231         * dwarf2read.c: Fix common/ includes.
9232         * dwarf2loc.c: Fix common/ includes.
9233         * dwarf2-frame.c: Fix common/ includes.
9234         * dwarf-index-cache.c: Fix common/ includes.
9235         * dtrace-probe.c: Fix common/ includes.
9236         * disasm-selftests.c: Fix common/ includes.
9237         * defs.h: Fix common/ includes.
9238         * csky-tdep.c: Fix common/ includes.
9239         * cp-valprint.c: Fix common/ includes.
9240         * cp-support.h: Fix common/ includes.
9241         * cp-support.c: Fix common/ includes.
9242         * corelow.c: Fix common/ includes.
9243         * completer.h: Fix common/ includes.
9244         * completer.c: Fix common/ includes.
9245         * compile/compile.c: Fix common/ includes.
9246         * compile/compile-loc2c.c: Fix common/ includes.
9247         * compile/compile-cplus-types.c: Fix common/ includes.
9248         * compile/compile-cplus-symbols.c: Fix common/ includes.
9249         * command.h: Fix common/ includes.
9250         * cli/cli-dump.c: Fix common/ includes.
9251         * cli/cli-cmds.c: Fix common/ includes.
9252         * charset.c: Fix common/ includes.
9253         * build-id.c: Fix common/ includes.
9254         * btrace.h: Fix common/ includes.
9255         * btrace.c: Fix common/ includes.
9256         * breakpoint.h: Fix common/ includes.
9257         * breakpoint.c: Fix common/ includes.
9258         * ax.h:
9259         (enum agent_op): Fix common/ includes.
9260         * ax-general.c (struct aop_map): Fix common/ includes.
9261         * ax-gdb.c: Fix common/ includes.
9262         * auxv.c: Fix common/ includes.
9263         * auto-load.c: Fix common/ includes.
9264         * arm-tdep.c: Fix common/ includes.
9265         * arch/riscv.c: Fix common/ includes.
9266         * arch/ppc-linux-common.c: Fix common/ includes.
9267         * arch/i386.c: Fix common/ includes.
9268         * arch/arm.c: Fix common/ includes.
9269         * arch/arm-linux.c: Fix common/ includes.
9270         * arch/arm-get-next-pcs.c: Fix common/ includes.
9271         * arch/amd64.c: Fix common/ includes.
9272         * arch/aarch64.c: Fix common/ includes.
9273         * arch/aarch64-insn.c: Fix common/ includes.
9274         * arch-utils.c: Fix common/ includes.
9275         * amd64-windows-tdep.c: Fix common/ includes.
9276         * amd64-tdep.c: Fix common/ includes.
9277         * amd64-sol2-tdep.c: Fix common/ includes.
9278         * amd64-obsd-tdep.c: Fix common/ includes.
9279         * amd64-nbsd-tdep.c: Fix common/ includes.
9280         * amd64-linux-tdep.c: Fix common/ includes.
9281         * amd64-linux-nat.c: Fix common/ includes.
9282         * amd64-fbsd-tdep.c: Fix common/ includes.
9283         * amd64-fbsd-nat.c: Fix common/ includes.
9284         * amd64-dicos-tdep.c: Fix common/ includes.
9285         * amd64-darwin-tdep.c: Fix common/ includes.
9286         * agent.c: Fix common/ includes.
9287         * ada-lang.h: Fix common/ includes.
9288         * ada-lang.c: Fix common/ includes.
9289         * aarch64-tdep.c: Fix common/ includes.
9290
9291 2019-01-25  Tom Tromey  <tom@tromey.com>
9292
9293         * common/create-version.sh: Use common/version.h.
9294
9295 2019-01-24  Pedro Alves  <palves@redhat.com>
9296
9297         * infrun.c (signal_stop, signal_print, signal_program)
9298         (signal_catch, signal_pass): Now arrays instead of pointers.
9299         (update_signals_program_target, do_target_resume)
9300         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9301         * linux-nat.c (linux_nat_target::pass_signals)
9302         (linux_nat_target::create_inferior, linux_nat_target::attach):
9303         Adjust.
9304         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9305         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9306         * procfs.c (procfs_target::pass_signals): Adjust.
9307         * record-full.c (record_full_target::resume): Adjust.
9308         * remote.c (remote_target::pass_signals)
9309         (remote_target::program_signals): Adjust.
9310         * target-debug.h (target_debug_print_signals): Now takes a
9311         gdb::array_view as parameter.  Adjust.
9312         * target.h (target_ops) <pass_signals, program_signals>: Replace
9313         pointer and length parameters with gdb::array_view.
9314         (target_pass_signals, target_program_signals): Likewise.
9315         * target-delegates.c: Regenerate.
9316
9317 2019-01-24  Pedro Alves  <palves@redhat.com>
9318
9319         * common/forward-scope-exit.h
9320         (forward_scope_exit::forward_scope_exit): Pass arguments to
9321         m_bind_function directly, instead of creating a std::bind and
9322         copying that.
9323
9324 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9325
9326         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9327         for static members.
9328         (pass_in_v_vfp_candidate): Likewise.
9329
9330 2019-01-23  Tom Tromey  <tom@tromey.com>
9331             Pedro Alves  <palves@redhat.com>
9332
9333         * regcache.c (class regcache_invalidator): Remove.
9334         (regcache::raw_write): Use make_scope_exit.
9335
9336 2019-01-23  Tom Tromey  <tom@tromey.com>
9337
9338         * ui-out.h (class ui_out_emit_type): Update comment.
9339
9340 2019-01-23  Tom Tromey  <tom@tromey.com>
9341
9342         * infrun.c (fetch_inferior_event): Update comment.
9343
9344 2019-01-23  Tom Tromey  <tom@tromey.com>
9345             Pedro Alves  <palves@redhat.com>
9346
9347         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9348         parameter.
9349         (fetch_inferior_event): Use SCOPE_EXIT.
9350
9351
9352 2019-01-23  Tom Tromey  <tom@tromey.com>
9353             Pedro Alves  <palves@redhat.com>
9354
9355         * infrun.c (disable_thread_events): Delete.
9356         (stop_all_threads): Use SCOPE_EXIT.
9357
9358 2019-01-23  Tom Tromey  <tom@tromey.com>
9359             Pedro Alves  <palves@redhat.com>
9360
9361         * symfile.c: Include forward-scope-exit.h.
9362         (clear_symtab_users_cleanup): Replace forward declaration with
9363         a FORWARD_SCOPE_EXIT.
9364         (syms_from_objfile_1): Use the forward_scope_exit and
9365         gdb::optional instead of cleanup_function.
9366         (reread_symbols): Use the forward_scope_exit instead of
9367         cleanup_function.
9368         (clear_symtab_users_cleanup): Remove function.
9369
9370 2019-01-23  Tom Tromey  <tom@tromey.com>
9371             Pedro Alves  <palves@redhat.com>
9372
9373         * linux-nat.c: Include scope-exit.h.
9374         (cleanup_target_stop): Remove.
9375         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9376         SCOPE_EXIT.
9377
9378 2019-01-23  Tom Tromey  <tom@tromey.com>
9379             Pedro Alves  <palves@redhat.com>
9380
9381         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9382         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9383
9384 2019-01-23  Tom Tromey  <tom@tromey.com>
9385             Andrew Burgess  <andrew.burgess@embecosm.com>
9386             Pedro Alves  <palves@redhat.com>
9387
9388         * infrun.c (fetch_inferior_event): Use scope_exit.
9389         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9390         * top.c (execute_command): Use scope_exit.
9391         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9392         * utils.c (do_bpstat_clear_actions_cleanup)
9393         (make_bpstat_clear_actions_cleanup): Remove.
9394
9395 2019-01-23  Tom Tromey  <tom@tromey.com>
9396             Pedro Alves  <palves@redhat.com>
9397
9398         * infrun.c: Include "common/scope-exit.h"
9399         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9400         (wait_for_inferior): Use SCOPE_EXIT.
9401         (fetch_inferior_event): Use scope_exit.
9402
9403 2019-01-23  Tom Tromey  <tom@tromey.com>
9404             Pedro Alves  <palves@redhat.com>
9405
9406         * breakpoint.c (create_breakpoint): Remove cleanup.
9407
9408 2019-01-23  Tom Tromey  <tom@tromey.com>
9409             Andrew Burgess  <andrew.burgess@embecosm.com>
9410             Pedro Alves  <palves@redhat.com>
9411
9412 2019-01-23  Pedro Alves  <palves@redhat.com>
9413
9414         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9415
9416 2019-01-23  Pedro Alves  <palves@redhat.com>
9417             Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * gdbthread.h: Include "common/forward-scope-exit.h".
9420         (scoped_finish_thread_state): Redefine custom class in terms of
9421         forward_scope_exit.
9422
9423 2019-01-23  Pedro Alves  <palves@redhat.com>
9424             Andrew Burgess  <andrew.burgess@embecosm.com>
9425
9426         * common/forward-scope-exit.h: New file.
9427
9428 2019-01-23  Pedro Alves  <palves@redhat.com>
9429             Andrew Burgess  <andrew.burgess@embecosm.com>
9430             Tom Tromey  <tom@tromey.com>
9431
9432         * common/scope-exit.h: New file.
9433
9434 2019-01-23  Pedro Alves  <palves@redhat.com>
9435
9436         * common/preprocessor.h (ESC): Rename to ...
9437         (ESC_PARENS): ... this.
9438         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9439         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9440
9441 2019-01-23  Tom Tromey  <tom@tromey.com>
9442
9443         * language.h (class scoped_switch_to_sym_language_if_auto):
9444         Initialize m_lang in both cases.
9445
9446 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9447
9448         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9449         with XCNEW.
9450
9451 2019-01-22  Tom Tromey  <tom@tromey.com>
9452
9453         * corelow.c: Do not include sys/file.h.
9454
9455 2019-01-22  Tom Tromey  <tom@tromey.com>
9456
9457         * tui/tui-wingeneral.h: Include gdb_curses.h.
9458
9459 2019-01-22  Tom Tromey  <tom@tromey.com>
9460
9461         * source-cache.h (class source_cache) <get_source_lines,
9462         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9463
9464 2019-01-22  Tom Tromey  <tom@tromey.com>
9465
9466         * remote-fileio.h (struct remote_target): Declare.
9467
9468 2019-01-22  Tom Tromey  <tom@tromey.com>
9469
9470         * python/py-arch.c: Do not include py-ref.h.
9471         * python/py-bpevent.c: Do not include py-ref.h.
9472         * python/py-cmd.c: Do not include py-ref.h.
9473         * python/py-continueevent.c: Do not include py-ref.h.
9474         * python/py-event.h: Do not include py-ref.h.
9475         * python/py-evtregistry.c: Do not include py-ref.h.
9476         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9477         * python/py-frame.c: Do not include py-ref.h.
9478         * python/py-framefilter.c: Do not include py-ref.h.
9479         * python/py-function.c: Do not include py-ref.h.
9480         * python/py-infevents.c: Do not include py-ref.h.
9481         * python/py-linetable.c: Do not include py-ref.h.
9482         * python/py-objfile.c: Do not include py-ref.h.
9483         * python/py-param.c: Do not include py-ref.h.
9484         * python/py-prettyprint.c: Do not include py-ref.h.
9485         * python/py-progspace.c: Do not include py-ref.h.
9486         * python/py-symbol.c: Do not include py-ref.h.
9487         * python/py-symtab.c: Do not include py-ref.h.
9488         * python/py-type.c: Do not include py-ref.h.
9489         * python/py-unwind.c: Do not include py-ref.h.
9490         * python/py-utils.c: Do not include py-ref.h.
9491         * python/py-value.c: Do not include py-ref.h.
9492         * python/py-varobj.c: Do not include py-ref.h.
9493         * python/py-xmethods.c: Do not include py-ref.h.
9494         * python/python.c: Do not include py-ref.h.
9495         * varobj.c: Do not include py-ref.h.
9496
9497 2019-01-22  Tom Tromey  <tom@tromey.com>
9498
9499         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9500         keyword for bcache.
9501
9502 2019-01-22  Tom Tromey  <tom@tromey.com>
9503
9504         * compile/compile-cplus-types.c: Remove a comment by #include.
9505
9506 2019-01-22  Tom Tromey  <tom@tromey.com>
9507
9508         * compile/gcc-c-plugin.h: Include compile-internal.h.
9509
9510 2019-01-22  Tom Tromey  <tom@tromey.com>
9511
9512         * stabsread.c (EXTERN): Do not define.
9513         (symnum, next_symbol_text_func, processing_gcc_compilation)
9514         (within_function, global_sym_chain, global_stabs)
9515         (previous_stab_code, this_object_header_files)
9516         (n_this_object_header_files)
9517         (n_allocated_this_object_header_files): Define.
9518         * stabsread.h (EXTERN): Never define.  Use "extern".
9519
9520 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9521
9522         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9523         history_value.
9524
9525 2019-01-21  Tom Tromey  <tom@tromey.com>
9526
9527         * ui-out.c: Fix includes.
9528         * tui/tui-source.c: Fix includes.
9529         * target.c: Fix includes.
9530         * remote.c: Fix includes.
9531         * regcache.c: Fix includes.
9532         * python/py-block.c: Fix includes.
9533         * printcmd.c: Fix includes.
9534         * or1k-tdep.c: Fix includes.
9535         * mi/mi-main.c: Fix includes.
9536         * m32r-tdep.c: Fix includes.
9537         * csky-tdep.c: Fix includes.
9538         * compile/compile-cplus-types.c: Fix includes.
9539         * cli/cli-interp.c: Fix includes.
9540
9541 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9542
9543         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9544         for padding.
9545
9546 2019-01-16  Tom Tromey  <tom@tromey.com>
9547
9548         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9549         earlier.
9550         (struct objfile) <msymbols_range>: Move from top level.
9551         <msymbols>: New method.
9552         (class objfile_msymbols): Remove.
9553         * symtab.c (default_collect_symbol_completion_matches_break_on):
9554         Update.
9555         * symmisc.c (dump_msymbols): Update.
9556         * stabsread.c (scan_file_globals): Update.
9557         * objc-lang.c (info_selectors_command, info_classes_command)
9558         (find_methods): Update.
9559         * minsyms.c (find_solib_trampoline_target): Update.
9560         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9561         * coffread.c (coff_symfile_read): Update.
9562         * ada-lang.c (ada_lookup_simple_minsym)
9563         (ada_collect_symbol_completion_matches): Update.
9564
9565 2019-01-16  Tom Tromey  <tom@tromey.com>
9566
9567         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9568         type.  Remove no-argument constructor.
9569         <iterator::operator++>: Simplify.
9570         <begin>: Update.
9571         <end>: Use minimal_symbol_count.
9572
9573 2019-01-16  Tom Tromey  <tom@tromey.com>
9574
9575         * objfiles.h (struct objfile) <psymtabs>: New method.
9576         (class objfile_psymtabs): Remove.
9577         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9578         typedef.
9579         <range>: New method.
9580         (require_partial_symbols): Change return type.
9581         * psymtab.c (require_partial_symbols)
9582         (psym_expand_symtabs_matching): Update.
9583         * mdebugread.c (parse_partial_symbols): Update.
9584         * dbxread.c (dbx_end_psymtab): Update.
9585
9586 2019-01-15  Tom Tromey  <tom@tromey.com>
9587
9588         * symtab.c (lookup_objfile_from_block)
9589         (lookup_symbol_in_objfile_symtabs)
9590         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9591         (find_line_symtab, info_sources_command)
9592         (default_collect_symbol_completion_matches_break_on)
9593         (make_source_files_completion_list): Update.
9594         * symmisc.c (print_objfile_statistics, dump_objfile)
9595         (maintenance_print_symbols, maintenance_info_symtabs)
9596         (maintenance_check_symtabs, maintenance_info_line_tables):
9597         Update.
9598         * source.c (select_source_symtab)
9599         (forget_cached_source_info_for_objfile): Update.
9600         * objfiles.h (class objfile_compunits): Remove.
9601         (struct objfile) <compunits_range>: New typedef.
9602         (compunits): New method.
9603         * objfiles.c (objfile_relocate1): Update.
9604         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9605         * maint.c (count_symtabs_and_blocks): Update.
9606         * linespec.c (iterate_over_all_matching_symtabs): Update.
9607         * cp-support.c (add_symbol_overload_list_qualified): Update.
9608         * coffread.c (coff_symtab_read): Update.
9609         * ada-lang.c (add_nonlocal_symbols)
9610         (ada_collect_symbol_completion_matches)
9611         (ada_add_global_exceptions): Update.
9612
9613 2019-01-15  Tom Tromey  <tom@tromey.com>
9614
9615         * progspace.h (program_space) <objfiles_safe_range>: New
9616         typedef.
9617         <objfiles_safe>: New method.
9618         * objfiles.h (class all_objfiles_safe): Remove.
9619         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9620         * jit.c (jit_inferior_exit_hook): Update.
9621
9622 2019-01-17  Tom Tromey  <tom@tromey.com>
9623
9624         * progspace.h (program_space) <objfiles_range>: New typedef.
9625         <objfiles>: New method.
9626         <objfiles_head>: Rename from objfiles.
9627         (object_files): Update.
9628         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9629         * guile/scm-pretty-print.c
9630         (ppscm_find_pretty_printer_from_objfiles): Update.
9631         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9632         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9633         Update.
9634         * python/py-progspace.c (pspy_get_objfiles): Update.
9635         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9636         Update.
9637         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9638         (objfpy_lookup_objfile_by_build_id): Update.
9639         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9640         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9641         Update.
9642         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9643         (expand_symtab_containing_pc, lookup_objfile_from_block)
9644         (lookup_static_symbol, basic_lookup_transparent_type)
9645         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9646         (find_line_symtab, info_sources_command)
9647         (default_collect_symbol_completion_matches_break_on)
9648         (make_source_files_completion_list, find_main_name): Update.
9649         * symmisc.c (print_symbol_bcache_statistics)
9650         (print_objfile_statistics, maintenance_print_symbols)
9651         (maintenance_print_msymbols, maintenance_print_objfiles)
9652         (maintenance_info_symtabs, maintenance_check_symtabs)
9653         (maintenance_expand_symtabs, maintenance_info_line_tables):
9654         Update.
9655         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9656         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9657         (map_overlay_command, unmap_overlay_command)
9658         (simple_overlay_update, expand_symtabs_matching)
9659         (map_symbol_filenames): Update.
9660         * symfile-debug.c (set_debug_symfile): Update.
9661         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9662         Update.
9663         * source.c (select_source_symtab, forget_cached_source_info):
9664         Update.
9665         * solib.c (solib_read_symbols): Update.
9666         * solib-spu.c (append_ocl_sos): Update.
9667         * psymtab.c (maintenance_print_psymbols)
9668         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9669         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9670         * printcmd.c (info_symbol_command): Update.
9671         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9672         Update.
9673         * objfiles.h (class all_objfiles): Remove.
9674         * objfiles.c (have_partial_symbols, have_full_symbols)
9675         (have_minimal_symbols, qsort_cmp, update_section_map)
9676         (shared_objfile_contains_address_p)
9677         (default_iterate_over_objfiles_in_search_order): Update.
9678         * objc-lang.c (info_selectors_command, info_classes_command)
9679         (find_methods): Update.
9680         * minsyms.c (find_solib_trampoline_target): Update.
9681         * maint.c (maintenance_info_sections)
9682         (maintenance_translate_address, count_symtabs_and_blocks):
9683         Update.
9684         * main.c (captured_main_1): Update.
9685         * linux-thread-db.c (try_thread_db_load_from_pdir)
9686         (has_libpthread): Update.
9687         * linespec.c (iterate_over_all_matching_symtabs)
9688         (search_minsyms_for_name): Update.
9689         * jit.c (jit_find_objf_with_entry_addr): Update.
9690         * hppa-tdep.c (find_unwind_entry)
9691         (hppa_lookup_stub_minimal_symbol): Update.
9692         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9693         Update.
9694         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9695         (elf_gnu_ifunc_resolve_by_got): Update.
9696         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9697         * dwarf-index-write.c (save_gdb_index_command): Update.
9698         * cp-support.c (add_symbol_overload_list_qualified): Update.
9699         * breakpoint.c (create_overlay_event_breakpoint)
9700         (create_longjmp_master_breakpoint)
9701         (create_std_terminate_master_breakpoint)
9702         (create_exception_master_breakpoint): Update.
9703         * blockframe.c (find_pc_partial_function): Update.
9704         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9705         (ada_collect_symbol_completion_matches)
9706         (ada_add_global_exceptions): Update.
9707
9708 2019-01-17  Tom Tromey  <tom@tromey.com>
9709
9710         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9711         declare VEC.
9712         (solib_target_parse_libraries): Change return type.
9713         (library_list_start_segment, library_list_start_section)
9714         (library_list_end_library, library_list_start_library); Update.
9715         (solib_target_free_library_list): Remove.
9716         (solib_target_parse_libraries): Remove cleanup.  Change return
9717         type.
9718         (solib_target_current_sos): Update.
9719
9720 2019-01-17  Tom Tromey  <tromey@bapiya>
9721
9722         * valprint.c: Replace "the the" with "the".
9723         * symtab.c: Replace "the the" with "the".
9724         * solib.c: Replace "the the" with "the".
9725         * solib-dsbt.c: Replace "the the" with "the".
9726         * linespec.c: Replace "the the" with "the".
9727         * dwarf2loc.h: Replace "the the" with "the".
9728         * amd64-windows-tdep.c: Replace "the the" with "the".
9729         * aarch64-tdep.c: Replace "the the" with "the".
9730
9731 2019-01-16  Keith Seitz  <keiths@redhat.com>
9732
9733         PR gdb/23773
9734         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9735         <builder>: Rename to ..
9736         <m_builder>: ... this and make private.
9737         (dwarf2_cu::get_builder): New method.  Change all users of
9738         `builder' to use this method.
9739         (dwarf2_start_symtab): Move to ...
9740         (dwarf2_cu::start_symtab): ... here.  Update all callers
9741         (setup_type_unit_groups): Move to ...
9742         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9743         callers.
9744         (dwarf2_cu::reset_builder): New method.
9745         (process_full_compunit, process_full_type_unit): Use
9746         dwarf2_cu::reset_builder.
9747         (follow_die_offset): Record the ancestor CU if it is different
9748         from the followed DIE's CU.
9749         (follow_die_sig_1): Likewise.
9750
9751 2019-01-15  Tom Tromey  <tom@tromey.com>
9752
9753         * remote.c (class remote_state) <buf>: Now a char_vector.
9754         <buf_size>: Remove.
9755         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9756         parameter.
9757         (remote_target::getpkt_or_notif_sane_1)
9758         (remote_target::getpkt_sane)
9759         (remote_target::getpkt_or_notif_sane): Likewise.
9760         (class remote_target) <putpkt>: New overload.
9761         (remote_target::read_frame): Change type of "buf_p".  Remove
9762         sizeof_p parameter.
9763         (packet_ok): New overload.
9764         (packet_check_result): New overload.
9765         Update all uses.
9766
9767 2019-01-14  Tom Tromey  <tom@tromey.com>
9768
9769         * remote-notif.c (handle_notification, remote_notif_ack)
9770         (remote_notif_parse): Make "buf" const.
9771         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9772         const.
9773         (remote_notif_parse, remote_notif_ack, handle_notification):
9774         Likewise.
9775         * remote.c (remote_notif_stop_parse): Make "buf" const.
9776         (remote_target::remote_parse_stop_reply): Make "buf" const.
9777         (remote_notif_stop_ack): Make "buf" const.
9778
9779 2019-01-14  Tom Tromey  <tom@tromey.com>
9780
9781         * remote.c (remote_console_output): Make parameter const.
9782
9783 2019-01-14  Tom Tromey  <tom@tromey.com>
9784
9785         * target-debug.h (target_debug_print_signals): Constify.
9786         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9787         * procfs.c (procfs_target::pass_signals): Update.
9788         * linux-nat.c (linux_nat_target::pass_signals): Update.
9789         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9790         * target-delegates.c: Rebuild.
9791         * remote.c (remote_target::program_signals): Update.
9792         (remote_target::pass_signals): Update.
9793         * target.c (target_pass_signals): Constify argument.
9794         (target_program_signals): Likewise.
9795         * target.h (struct target_ops) <pass_signals, program_signals>:
9796         Constify argument.
9797         (target_pass_signals, target_program_signals): Constify argument.
9798
9799 2019-01-14  Tom Tromey  <tom@tromey.com>
9800
9801         PR tui/28819:
9802         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9803
9804 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9805
9806         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9807         field.
9808         * rs6000-tdep.c: Include reggroups.h.
9809         (IS_V_ALIAS_PSEUDOREG): Define.
9810         (rs6000_register_name): Return names for the "vX" aliases.
9811         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9812         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9813         aliases.  Call default_register_reggroup_p for all other
9814         pseudo-registers.
9815         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9816         New functions.
9817         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9818         Handle "vX" aliases.
9819         (v_alias_pseudo_register_collect): New function.
9820         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9821         (rs6000_gdbarch_init): Initialize "vX" aliases as
9822         pseudo-registers.  Restore registration of
9823         rs6000_pseudo_register_reggroup_p with
9824         set_tdesc_pseudo_register_reggroup_p.
9825
9826 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9827
9828         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9829         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9830         set_gdbarch_num_pseudo_regs.
9831
9832 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9833
9834         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9835         Remove arg prefixname, add do_set and do_show.
9836         Add member functions set_list and show_list.
9837         * cli/cli-style.c (class cli_style_option): Update accordingly.
9838         (style_set_list): Move to file scope.
9839         (style_show_list): Likewise.
9840         (set_style): Call help_list.
9841         (show_style): Call cmd_show_list.
9842         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9843         Update to use the new macro.
9844
9845 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9846
9847         * ada-lang.c (_initialize_ada_language): Expand the help text
9848         for the "catch exception" command.
9849
9850 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9851
9852         * symtab.c (matching_obj_sections): Initialize obj,
9853         declare it closer to its usage.
9854
9855 2019-01-10  Tom Tromey  <tom@tromey.com>
9856
9857         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9858         (basic_inf_threads_range): Remove.
9859         (inf_threads_range, inf_non_exited_threads_range)
9860         (safe_inf_threads_range): Use next_adapter.
9861
9862 2019-01-10  Keith Seitz  <keiths@redhat.com>
9863
9864         PR gdb/23712
9865         PR symtab/23010
9866         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9867         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9868
9869 2019-01-10  Keith Seitz  <keiths@redhat.com>
9870
9871         PR gdb/23712
9872         PR symtab/23010
9873         * dictionary.c (pending_to_vector): Remove.
9874         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9875         Remove _1 suffix, replacing functions of the same name.  Update
9876         all callers.
9877         (dict_create_hashed, dict_create_hashed_expandable)
9878         (dict_create_linear, dict_create_linear_expandable, dict_free)
9879         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9880         Make functions static.
9881
9882 2019-01-10  Keith Seitz  <keiths@redhat.com>
9883
9884         PR gdb/23712
9885         PR symtab/23010
9886         * dictionary.h (struct dictionary): Replace declaration with
9887         multidictionary.
9888         (dict_create_hashed, dict_create_hashed_expandable)
9889         (dict_create_linear, dict_create_linear_expandable)
9890         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9891         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9892         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9893         taking multidictionary argument.
9894         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9895         * block.h (struct block) <dict>: Change to multidictionary
9896         and rename `multidict'.
9897         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9898         symmisc.c: Update all dictionary references to multidictionary.
9899
9900 2019-01-10  Keith Seitz  <keiths@redhat.com>
9901
9902         PR gdb/23712
9903         PR symtab/23010
9904         * dictionary.c: Include unordered_map.
9905         (pending_to_vector): New function.
9906         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9907         Rewrite the non-"_1" functions to take vector instead
9908         of linked list.
9909         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9910         "new" _1 versions of the same name.
9911         (multidictionary): Define.
9912         (std::hash<enum language): New definition.
9913         (collate_pending_symbols_by_language, mdict_create_hashed)
9914         (mdict_create_hashed_expandable, mdict_create_linear)
9915         (mdict_create_linear_expandable, mdict_free)
9916         (find_language_dictionary, create_new_language_dictionary)
9917         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9918         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9919         (mdict_size, mdict_empty): New functions.
9920         * dictionary.h (mdict_iterator): Define.
9921
9922 2019-01-10  Pedro Alves  <palves@redhat.com>
9923
9924         * breakpoint.c (read_uploaded_action)
9925         (create_tracepoint_from_upload): Adjust to use
9926         gdb::unique_xmalloc_ptr.
9927         * ctf.c (ctf_write_uploaded_tp):
9928         (SET_ARRAY_FIELD): Use emplace_back.
9929         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9930         * tracefile-tfile.c (tfile_write_uploaded_tp):
9931         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9932         gdb::unique_xmalloc_ptr.
9933         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9934         at_string, cond_string, cmd_strings>: Replace char pointers
9935         with gdb::unique_xmalloc_ptr.
9936
9937 2019-01-10  Pedro Alves  <palves@redhat.com>
9938
9939         * solib-target.c (library_list_start_library): Don't xstrdup name.
9940
9941 2019-01-10  Pedro Alves  <palves@redhat.com>
9942
9943         * mdebugread.c (parse_partial_symbols): Use
9944         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9945
9946 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9947
9948         * linux-fork.c (scoped_switch_fork_info)
9949         <~scoped_switch_fork_info>: Fix incorrect variable name.
9950
9951 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9952
9953         * linux-fork.c (scoped_switch_fork_info)
9954         <scoped_switch_fork_info>: Make explicit.
9955         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9956
9957 2019-01-10  Tom Tromey  <tom@tromey.com>
9958
9959         * objfiles.h (objfile::reset_psymtabs): Update.
9960         * objfiles.c (objfile::objfile): Update.
9961         * psymtab.h (psymtab_storage::obstack): Update.
9962         (psymtab_storage::m_obstack): Use gdb::optional.
9963         (class psymtab_storage): Update comment.  Remove objfile
9964         parameter.
9965         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9966
9967 2019-01-10  Tom Tromey  <tom@tromey.com>
9968
9969         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9970         <free_psymtabs>: Now private.
9971         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9972         (allocate_psymtab): Use new method.
9973
9974 2019-01-10  Tom Tromey  <tom@tromey.com>
9975
9976         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9977         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9978         * mdebugread.c (parse_partial_symbols): Use
9979         allocate_dependencies.
9980         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9981         allocate_dependencies.
9982         (process_psymtab_comp_unit_reader)
9983         (build_type_psymtab_dependencies): Likewise.
9984         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9985
9986 2019-01-10  Tom Tromey  <tom@tromey.com>
9987
9988         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9989         PSYMBOL_SET_LANGUAGE.
9990         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9991
9992 2019-01-10  Tom Tromey  <tom@tromey.com>
9993
9994         * psymtab.h (psymtab_storage::obstack): New method.
9995         <m_obstack>: Rename from obstack; now private.
9996         * psymtab.c (psymtab_storage): Update.
9997         * dwarf2read.c (create_addrmap_from_index)
9998         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9999         Update.
10000
10001 2019-01-10  Tom Tromey  <tom@tromey.com>
10002
10003         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10004         * objfiles.h (objfile::reset_psymtabs): New method.
10005
10006 2019-01-10  Tom Tromey  <tom@tromey.com>
10007
10008         * symmisc.c (print_symbol_bcache_statistics): Update.
10009         (print_objfile_statistics): Update.
10010         * symfile.c (reread_symbols): Update.
10011         * psymtab.h (class psymtab_storage): New.
10012         * psymtab.c (psymtab_storage): New constructor.
10013         (~psymtab_storage): New destructor.
10014         (require_partial_symbols): Update.
10015         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10016         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10017         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10018         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10019         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10020         (start_psymtab_common, end_psymtab_common)
10021         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10022         (allocate_psymtab): Update.
10023         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10024         Update.
10025         (dump_psymtab_addrmap, maintenance_print_psymbols)
10026         (maintenance_check_psymtabs): Update.
10027         (class objfile_psymtabs): Move to objfiles.h.
10028         * psympriv.h (discard_psymtab): Now inline.
10029         (psymtab_discarder::psymtab_discarder): Update.
10030         (psymtab_discarder::~psymtab_discarder): Update.
10031         (ALL_OBJFILE_PSYMTABS): Rewrite.
10032         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10033         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10034         Remove fields.
10035         <partial_symtabs>: New field.
10036         (class objfile_psymtabs): Move from psymtab.h.  Update.
10037         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10038         psymbol_cache.
10039         (objfile::~objfile): Don't destroy psymbol_cache.
10040         * mdebugread.c (parse_partial_symbols): Update.
10041         * dwarf2read.c (create_addrmap_from_index)
10042         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10043         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10044         (add_partial_subprogram, dwarf2_ranges_read): Update.
10045         * dwarf-index-write.c (write_address_map)
10046         (write_one_signatured_type, recursively_write_psymbols)
10047         (class debug_names, class debug_names, write_psymtabs_to_index):
10048         Update.
10049
10050 2019-01-10  Tom Tromey  <tom@tromey.com>
10051
10052         * symtab.h (SYMBOL_SET_NAMES): Update.
10053         (symbol_set_names): Update.
10054         (MSYMBOL_SET_NAMES): Update.
10055         * symtab.c (symbol_set_names): Change argument to be an
10056         objfile_per_bfd_storage.
10057         * psymtab.c (add_psymbol_to_bcache): Update.
10058         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10059
10060 2019-01-10  Tom Tromey  <tom@tromey.com>
10061
10062         * symtab.c (create_demangled_names_hash): Change argument to be an
10063         objfile_per_bfd_storage.
10064         (symbol_set_names): Update.
10065
10066 2019-01-10  Tom Tromey  <tom@tromey.com>
10067
10068         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10069         init_psymbol_list.
10070         * psymtab.c (init_psymbol_list): Do nothing if already called.
10071         * psympriv.h (init_psymbol_list): Add comment.
10072         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10073         init_psymbol_list.
10074         * dbxread.c (dbx_symfile_read): Unconditionally call
10075         init_psymbol_list.
10076
10077 2019-01-10  Tom Tromey  <tom@tromey.com>
10078
10079         * xcoffread.c (scan_xcoff_symtab): Update.
10080         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10081         "where".
10082         * mdebugread.c (parse_partial_symbols)
10083         (handle_psymbol_enumerators): Update.
10084         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10085         * dbxread.c (read_dbx_symtab): Update.
10086         * psympriv.h (psymbol_placement): New enum.
10087         (add_psymbol_to_list): Update.
10088
10089 2019-01-10  Tom Tromey  <tom@tromey.com>
10090
10091         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10092         static_psymbols parameters.
10093         (scan_xcoff_symtab): Update.
10094         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10095         static_psymbols parameters.
10096         * psympriv.h (start_psymtab_common): Update.
10097         * mdebugread.c (parse_partial_symbols): Update.
10098         * dwarf2read.c (create_partial_symtab): Update.
10099         * dbxread.c (read_dbx_symtab): Update.
10100         (start_psymtab): Remove global_psymbols and static_psymbols
10101         parameters.
10102
10103 2019-01-10  Tom Tromey  <tom@tromey.com>
10104
10105         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10106         * psymtab.c (allocate_psymtab): Add comment.
10107         * psympriv.h (allocate_psymtab): Add comment.
10108         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10109         initializations.
10110         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10111
10112 2019-01-10  Tom Tromey  <tom@tromey.com>
10113
10114         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10115         Don't declare.
10116         * mipsread.c: Include mdebugread.h.
10117         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10118         Declare.
10119         * elfread.c: Include mdebugread.h.
10120
10121 2019-01-09  Tom Tromey  <tom@tromey.com>
10122
10123         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10124         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10125         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10126         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10127         (psym_lookup_symbol, psym_find_last_source_symtab)
10128         (psym_forget_cached_source_info, psym_print_stats)
10129         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10130         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10131         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10132         (psym_find_compunit_symtab_by_address)
10133         (maintenance_print_psymbols, maintenance_info_psymtabs)
10134         (maintenance_check_psymtabs): Use ranged for.
10135         * psymtab.h (class objfile_psymtabs): New.
10136         (require_partial_symbols): Return objfile_psymtabs.
10137         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10138
10139 2019-01-09  Tom Tromey  <tom@tromey.com>
10140
10141         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10142         (find_pc_mapped_section, list_overlays_command)
10143         (map_overlay_command, unmap_overlay_command)
10144         (simple_overlay_update): Use all_objfiles.
10145         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10146         * printcmd.c (info_symbol_command): Use all_objfiles.
10147         * objfiles.h (ALL_OBJSECTIONS): Remove.
10148         * maint.c (maintenance_translate_address): Use all_objfiles.
10149         * gcore.c (gcore_create_callback): Use all_objfiles.
10150         (objfile_find_memory_regions): Likewise.
10151
10152 2019-01-09  Tom Tromey  <tom@tromey.com>
10153
10154         * symtab.c (find_line_symtab, info_sources_command)
10155         (make_source_files_completion_list): Use objfile_compunits.
10156         * source.c (select_source_symtab): Use objfile_compunits.
10157         * objfiles.h (struct objfile): Update comment.
10158         (ALL_OBJFILES): Remove.
10159         (ALL_FILETABS): Remove.
10160         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10161         objfile_compunits.
10162
10163 2019-01-09  Tom Tromey  <tom@tromey.com>
10164
10165         * symmisc.c (print_objfile_statistics, dump_objfile)
10166         (maintenance_print_symbols): Use compunit_filetabs.
10167         * source.c (forget_cached_source_info_for_objfile): Use
10168         compunit_filetabs.
10169         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10170         (ALL_FILETABS): Use compunit_filetabs.
10171         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10172         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10173
10174 2019-01-09  Tom Tromey  <tom@tromey.com>
10175
10176         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10177         (compunit_filetabs): New.
10178         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10179         compunit_filetabs.
10180         (info_sources_command, make_source_files_completion_list): Remove
10181         declaration.
10182         * symmisc.c (print_objfile_statistics, dump_objfile)
10183         (maintenance_print_symbols): Remove declaration.
10184         (maintenance_info_symtabs): Use compunit_filetabs.
10185         (maintenance_info_line_tables): Likewise.
10186         * source.c (select_source_symtab): Change local variable name.
10187         (forget_cached_source_info_for_objfile): Remove declaration.
10188         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10189         * objfiles.c (objfile_relocate1): Remove declaration.
10190         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10191         declaration.
10192         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10193         * coffread.c (coff_symtab_read): Remove declaration.
10194         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10195         compunit_filetabs.
10196
10197 2019-01-09  Tom Tromey  <tom@tromey.com>
10198
10199         * symtab.c (lookup_objfile_from_block)
10200         (find_pc_sect_compunit_symtab, search_symbols)
10201         (default_collect_symbol_completion_matches_break_on): Use
10202         objfile_compunits.
10203         * objfiles.h (ALL_COMPUNITS): Remove.
10204         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10205         * cp-support.c (add_symbol_overload_list_qualified): Use
10206         objfile_compunits.
10207         * ada-lang.c (ada_collect_symbol_completion_matches)
10208         (ada_add_global_exceptions): Use objfile_compunits.
10209
10210 2019-01-09  Tom Tromey  <tom@tromey.com>
10211
10212         * source.c (select_source_symtab)
10213         (forget_cached_source_info_for_objfile): Remove declaration.
10214         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10215         declaration.
10216         * maint.c (count_symtabs_and_blocks): Remove declaration.
10217         * cp-support.c (add_symbol_overload_list_qualified): Remove
10218         declaration.
10219         * coffread.c (coff_symtab_read): Remove declaration.
10220         * symtab.c (lookup_symbol_in_objfile_symtabs)
10221         (basic_lookup_transparent_type_1): Use objfile_compunits.
10222         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10223         (info_sources_command, search_symbols)
10224         (default_collect_symbol_completion_matches_break_on)
10225         (make_source_files_completion_list): Remove declaration.
10226         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10227         (ada_collect_symbol_completion_matches)
10228         (ada_add_global_exceptions): Remove declaration.
10229         * linespec.c (iterate_over_all_matching_symtabs): Use
10230         objfile_compunits.
10231         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10232         (class objfile_compunits): New.
10233         (ALL_COMPUNITS): Use objfile_compunits.
10234         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10235         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10236         objfile_compunits.
10237         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10238
10239 2019-01-09  Tom Tromey  <tom@tromey.com>
10240
10241         * symtab.c (search_symbols)
10242         (default_collect_symbol_completion_matches_break_on): Use
10243         objfile_msymbols.
10244         * ada-lang.c (ada_lookup_simple_minsym)
10245         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10246         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10247         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10248         objfile_msymbols.
10249         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10250         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10251         * objc-lang.c (find_methods): Use objfile_msymbols.
10252         (info_selectors_command, info_classes_command): Likewise.
10253         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10254         * objfiles.h (class objfile_msymbols): New.
10255         (ALL_OBJFILE_MSYMBOLS): Remove.
10256         (ALL_MSYMBOLS): Remove.
10257
10258 2019-01-09  Tom Tromey  <tom@tromey.com>
10259
10260         * common/next-iterator.h (next_adapter): Add Iterator template
10261         parameter.
10262         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10263         (class all_objfiles_safe): New.
10264         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10265         * objfiles.c (put_objfile_before): Update comment.
10266         (add_separate_debug_objfile): Likewise.
10267         (free_all_objfiles): Use all_objfiles_safe.
10268         (objfile_purge_solibs): Likewise.
10269
10270 2019-01-09  Tom Tromey  <tom@tromey.com>
10271
10272         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10273         (expand_symtab_containing_pc, lookup_static_symbol)
10274         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10275         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10276         all_objfiles.
10277         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10278         * breakpoint.c (create_overlay_event_breakpoint)
10279         (create_longjmp_master_breakpoint)
10280         (create_std_terminate_master_breakpoint)
10281         (create_exception_master_breakpoint): Use all_objfiles.
10282         * linux-thread-db.c (try_thread_db_load_from_pdir)
10283         (has_libpthread): Use all_objfiles.
10284         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10285         * linespec.c (iterate_over_all_matching_symtabs)
10286         (search_minsyms_for_name): Use all_objfiles.
10287         * maint.c (maintenance_info_sections): Use all_objfiles.
10288         * main.c (captured_main_1): Use all_objfiles.
10289         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10290         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10291         * guile/scm-pretty-print.c
10292         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10293         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10294         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10295         (maintenance_print_msymbols): Use all_objfiles.
10296         * source.c (select_source_symtab): Use all_objfiles.
10297         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10298         * symfile.c (remove_symbol_file_command)
10299         (expand_symtabs_matching, map_symbol_filenames): Use
10300         all_objfiles.
10301         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10302         all_objfiles.
10303         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10304         * objc-lang.c (find_methods): Use all_objfiles.
10305         * objfiles.c (have_partial_symbols, have_full_symbols)
10306         (have_minimal_symbols, qsort_cmp)
10307         (default_iterate_over_objfiles_in_search_order): Use
10308         all_objfiles.
10309         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10310         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10311         (maintenance_check_psymtabs): Use all_objfiles.
10312         (ALL_PSYMTABS): Remove.
10313         * compile/compile-object-run.c (do_module_cleanup): Use
10314         all_objfiles.
10315         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10316         * cp-support.c (add_symbol_overload_list_qualified): Use
10317         all_objfiles.
10318         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10319         Use all_objfiles.
10320         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10321         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10322         all_objfiles.
10323         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10324         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10325         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10326         Uses all_objfiles.
10327         * solib.c (solib_read_symbols): Use all_objfiles
10328
10329 2019-01-09  Tom Tromey  <tom@tromey.com>
10330
10331         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10332         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10333         all_objfiles.
10334         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10335         * symmisc.c (print_symbol_bcache_statistics)
10336         (print_objfile_statistics, maintenance_print_objfiles)
10337         (maintenance_info_symtabs, maintenance_check_symtabs)
10338         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10339         all_objfiles.
10340         * source.c (forget_cached_source_info): Use all_objfiles.
10341         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10342         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10343         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10344         * objfiles.c (update_section_map): Use all_objfiles.
10345         (shared_objfile_contains_address_p): Likewise.
10346         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10347         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10348
10349 2019-01-09  Tom Tromey  <tom@tromey.com>
10350
10351         * common/next-iterator.h: New file.
10352         * objfiles.h (class all_objfiles): New.
10353         (struct objfile_iterator): New.
10354
10355 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10356
10357         * NEWS: Move the description of the changed "frame", "select-frame",
10358          and "info frame" commands to the Changed commands section.
10359
10360 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10361
10362         * gdbtypes.c (check_stub_method_group): Remove handling of old
10363         mangling schemes.
10364         * linespec.c (find_methods): Likewise.
10365         * stabsread.c (read_member_functions): Likewise.
10366         * valops.c (search_struct_method): Likewise.
10367         (value_struct_elt_for_reference): Likewise.
10368         * NEWS: Mention this change.
10369
10370 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10371
10372         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10373         print_source_lines.
10374         * source.c (print_source_lines_base): Update line number check.
10375         (print_source_lines): New function.
10376         (source_lines_range::source_lines_range): New function.
10377         * source.h (class source_lines_range): New class.
10378         (print_source_lines): New declaration.
10379
10380 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10381
10382         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10383
10384 2019-01-08  Tom Tromey  <tom@tromey.com>
10385             Simon Marchi  <simon.marchi@ericsson.com>
10386
10387         PR gdb/24060
10388         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10389         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10390         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10391         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10392         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10393         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10394
10395 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10396
10397         * source.c (select_source_symtab): Move header comment to
10398         declaration in source.h.
10399         (forget_cached_source_info_for_objfile): Likewise.
10400         (forget_cached_source_info): Likewise.
10401         (identify_source_line): Likewise.
10402         * source.h (identify_source_line): Move declaration from symtab.h
10403         and add comment from source.c
10404         (print_source_lines): Likewise.
10405         (forget_cached_source_info_for_objfile): Likewise.
10406         (forget_cached_source_info): Likewise.
10407         (select_source_symtab): Likewise.
10408         (enum print_source_lines_flag): Move definition from symtab.h.
10409         * symtab.h (identify_source_line): Move declaration to source.h.
10410         (print_source_lines): Likewise.
10411         (forget_cached_source_info_for_objfile): Likewise.
10412         (forget_cached_source_info): Likewise.
10413         (select_source_symtab): Likewise.
10414         (enum print_source_lines_flag): Move definition to source.h.
10415         * tui/tui-hooks.c: Add 'source.h' include.
10416
10417 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * source.c (print_source_lines_base): Handle requests to print
10420         reverse line number sequences, and guard against empty lines
10421         string.
10422
10423 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10424
10425         * source.c (print_source_lines_base): Fix skip of '\r' if next
10426         character is '\n'.
10427
10428 2019-01-06  Tom Tromey  <tom@tromey.com>
10429
10430         * c-exp.y (struct c_parse_state) <macro_original_text,
10431         expansion_obstack>: New member.
10432         (macro_original_text, expansion_obstack): Remove globals.
10433         (scan_macro_expansion, scanning_macro_expansion)
10434         (finished_macro_expansion): Update.
10435         (scan_macro_cleanup): Remove.
10436         (yylex, c_parse): Update.
10437
10438 2019-01-06  Tom Tromey  <tom@tromey.com>
10439
10440         * c-exp.y (struct c_parse_state) <strings>: New member.
10441         (operator_stoken): Update.
10442
10443 2019-01-06  Tom Tromey  <tom@tromey.com>
10444
10445         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10446         (union type_stack_elt) <typelist_val>: Now a pointer to
10447         std::vector.
10448         (type_stack_cleanup): Don't declare.
10449         (push_typelist): Update.
10450         * parse.c (pop_typelist): Return a std::vector.
10451         (push_typelist): Take a std::vector.
10452         (follow_types): Update.  Do not free args.
10453         (type_stack_cleanup): Remove.
10454         * c-exp.y (struct c_parse_state): New.
10455         (cpstate): New global.
10456         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10457         (nonempty_typelist): Update.
10458         (func_mod): Create a new vector.
10459         (c_parse): Create a c_parse_state.
10460         (check_parameter_typelist): Do not delete params.
10461         (function_method): Update.  Do not delete type_list.
10462
10463 2019-01-06  Tom Tromey  <tom@tromey.com>
10464
10465         PR gdb/28155:
10466         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10467         check_typedef.
10468         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10469         (print_return_value): Likewise.
10470
10471 2019-01-05  Tom Tromey  <tom@tromey.com>
10472
10473         * contrib/cleanup_check.py: Remove.
10474         * contrib/gcc-with-excheck: Remove.
10475         * contrib/exsummary.py: Remove.
10476         * contrib/excheck.py: Remove.
10477
10478 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10479
10480         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10481         NULL. Initialize tpprev to NULL instead of assigning it
10482         to NULL on the next statement.
10483         * windows-nat.c (windows_delete_thread): Remove check for
10484         main_thread_id before printing thread exit notifications.
10485         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10486         Remove thread ID check against main_thread_id.
10487         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10488         windows_delete_thread.
10489         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10490
10491 2019-01-04  Tom Tromey  <tom@tromey.com>
10492
10493         * compile/compile.c (_initialize_compile): Use upper case for
10494         metasyntactic variables.
10495         * symmisc.c (_initialize_symmisc): Use upper case for
10496         metasyntactic variables.
10497         * psymtab.c (_initialize_psymtab): Use upper case for
10498         metasyntactic variables.
10499         * demangle.c (demangle_command): Use upper case for metasyntactic
10500         variables.
10501         (_initialize_demangler): Likewise.
10502         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10503         variables.
10504
10505 2019-01-03  Tom Tromey  <tom@tromey.com>
10506
10507         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10508
10509 2019-01-03  Tom Tromey  <tom@tromey.com>
10510
10511         * python/py-symtab.c (salpy_str): Update.
10512         (struct salpy_sal_object) <symtab>: Now a PyObject.
10513         (salpy_dealloc): Update.
10514         (del_objfile_sal): Use gdbpy_ref.
10515
10516 2019-01-03  Tom Tromey  <tom@tromey.com>
10517
10518         * python/py-type.c (convert_field): Use new_reference.  Return
10519         gdbpy_ref.
10520         (make_fielditem): Return gdbpy_ref.
10521         (typy_fields): Update.
10522         (typy_getitem): Update.
10523         (field_name): Return gdbpy_ref.  Use new_reference.
10524         (typy_iterator_iternext): Update.
10525
10526 2019-01-03  Tom Tromey  <tom@tromey.com>
10527
10528         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10529
10530 2019-01-03  Tom Tromey  <tom@tromey.com>
10531
10532         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10533         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10534         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10535         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10536         (pspy_set_type_printers): Likewise.
10537         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10538         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10539         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10540         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10541         (objfpy_set_type_printers): Likewise.
10542
10543 2019-01-03  Tom Tromey  <tom@tromey.com>
10544
10545         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10546         (gdbpy_print_stack): Use gdbpy_err_fetch.
10547         * python/python-internal.h (class gdbpy_err_fetch): New class.
10548         (class gdbpy_enter) <m_error_type, m_error_value,
10549         m_error_traceback>: Remove.
10550         <m_error>: New member.
10551         (gdbpy_exception_to_string): Don't declare.
10552         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10553         * python/py-value.c (convert_value_from_python): Use
10554         gdbpy_err_fetch.
10555         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10556         gdbpy_exception_to_string.
10557         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10558         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10559         gdbpy_err_fetch.
10560
10561 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10562
10563         * linux-nat.c (delete_lwp_cleanup): Delete.
10564         (struct lwp_deleter): New struct.
10565         (lwp_info_up): New typedef.
10566         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10567         lwp_info_up.
10568
10569 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10570
10571         * linux-fork.c (class scoped_switch_fork_info): New class.
10572         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10573
10574 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10575
10576         * valops.c (find_overload_match): Remove use of null_cleanup, and
10577         calls to do_cleanups.
10578
10579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10580
10581         * compile/compile-cplus-types.c
10582         (compile_cplus_instance::decl_name): Handle changes to
10583         cp_func_name.
10584         * cp-support.c (cp_func_name): Update header comment, update
10585         return type.
10586         * cp-support.h (cp_func_name): Update return type in declaration.
10587         * valops.c (find_overload_match): Move temp_func local to top
10588         level of function and change its type.  Use temp_func to hold and
10589         delete temporary string obtained from cp_func_name.
10590
10591 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10592
10593         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10594         gdb::char_vector, remove cleanup, and update uses of `msg`.
10595
10596 2019-01-03  Jim Wilson  <jimw@sifive.com>
10597
10598         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10599
10600 2019-01-02  Tom Tromey  <tom@tromey.com>
10601
10602         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10603         (tdesc_parse_xml): Remove cleanups.
10604         * target-descriptions.h (make_cleanup_free_target_description):
10605         Don't declare.
10606         (target_desc_deleter): New struct.
10607         (target_desc_up): New typedef.
10608         * target-descriptions.c (target_desc_deleter::operator()): Rename
10609         from free_target_description.
10610         (make_cleanup_free_target_description): Remove.
10611
10612 2019-01-02  Tom Tromey  <tom@tromey.com>
10613
10614         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10615         constructor, destructor.
10616         (linespec_parser): Remove typedef.
10617         (~linespec_parser): Rename from linespec_parser_delete.
10618         (linespec_lex_to_end, linespec_complete_label)
10619         (linespec_complete): Update.
10620         (decode_line_full): Remove cleanups.
10621         (decode_line_1): Update.
10622
10623 2019-01-02  Tom Tromey  <tom@tromey.com>
10624
10625         * python/python-internal.h (inferior_to_inferior_object): Change
10626         return type.
10627         * python/py-exitedevent.c (create_exited_event_object): Update.
10628         * python/py-inferior.c (inferior_to_inferior_object): Return
10629         gdbpy_ref.
10630         (python_new_inferior, python_inferior_deleted)
10631         (thread_to_thread_object, delete_thread_object)
10632         (build_inferior_list, gdbpy_selected_inferior): Update.
10633         * python/py-infthread.c (create_thread_object): Update.  Also fail
10634         if inferior_to_inferior_object fails.
10635
10636 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10637
10638         * inferior.h (class inferior) <displaced_step_state>: New field.
10639         * infrun.h (struct displaced_step_state): Move here from
10640         infrun.c.  Initialize fields, add constructor.
10641         <inf>: Remove field.
10642         <reset>: New method.
10643         * infrun.c (struct displaced_step_inferior_state): Move to
10644         infrun.h.
10645         (displaced_step_inferior_states): Remove.
10646         (get_displaced_stepping_state): Adust.
10647         (displaced_step_in_progress_any_inferior): Adjust.
10648         (displaced_step_in_progress_thread): Adjust.
10649         (displaced_step_in_progress): Adjust.
10650         (add_displaced_stepping_state): Remove.
10651         (get_displaced_step_closure_by_addr): Adjust.
10652         (remove_displaced_stepping_state): Remove.
10653         (infrun_inferior_exit): Call displaced_step_state.reset.
10654         (use_displaced_stepping): Don't check for NULL.
10655         (displaced_step_prepare_throw): Call
10656         get_displaced_stepping_state.
10657         (displaced_step_fixup): Don't check for NULL.
10658         (prepare_for_detach): Don't check for NULL.
10659
10660 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10661
10662         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10663          in case of call that did not complete.
10664
10665 2019-01-02  Andrey Utkin  <autkin@undo.io>
10666
10667         * symfile.c (find_separate_debug_file): Fix search of debug files for
10668         remote debuggee.
10669
10670 2019-01-02  Tom Tromey  <tom@tromey.com>
10671
10672         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10673         indentation.
10674         * python/py-frame.c (frapy_older): Remove cast.
10675         (frapy_newer): Likewise.
10676         * python/py-breakpoint.c (local_setattro): Remove cast.
10677         * python/py-arch.c (archpy_name): Remove local variable.
10678         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10679
10680 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10681
10682         * unittests/basic_string_view/element_access/char/empty.cc:
10683         Fix year range in copyright header.
10684
10685 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10686
10687         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10688         Delete.
10689         <operator==>: Update with for removed field.
10690         <hash>: Likewise.
10691         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10692         <isa_features>: ...this.
10693         <abi_features>: New field.
10694         (riscv_isa_flen): Update comment.
10695         (riscv_abi_xlen): New declaration.
10696         (riscv_abi_flen): New declaration.
10697         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10698         isa_features.
10699         (riscv_abi_xlen): New function.
10700         (riscv_isa_flen): Update to get answer from isa_features.
10701         (riscv_abi_flen): New function.
10702         (riscv_has_fp_abi): Update to get answer from abi_features.
10703         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10704         xlen and flen.
10705         (riscv_call_info) <xlen, flen>: Update comment.
10706         (riscv_call_arg_struct): Remove invalid assertions
10707         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10708         is removed.
10709         (riscv_gdbarch_init): Gather isa features and abi features
10710         separately, ensure both match on the gdbarch when reusing an old
10711         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10712         a target with 64-bit float hardware.
10713
10714 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10715
10716         * source.c (search_command_helper): Stop reverse search
10717         when line 1 has been searched.
10718
10719 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10720
10721         * record-full.c (record_full_base_target::close): Rewrite
10722         record_full_core_buf_list free logic.
10723
10724 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10725
10726         * break-catch-syscall.c (print_one_catch_syscall): xfree
10727         the last text.
10728
10729 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10730
10731         * top.c (print_gdb_version): Update Copyright year in version
10732         message.
10733
10734 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10735
10736         Update copyright year range in all GDB files.
10737
10738 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10739
10740         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10741
10742 For older changes see ChangeLog-2018.
10743 \f
10744 Local Variables:
10745 mode: change-log
10746 left-margin: 8
10747 fill-column: 74
10748 version-control: never
10749 coding: utf-8
10750 End:
10751