gdb/ChangeLog

   1 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
   2
   3         * dwarf2read.c (open_and_init_dwp_file): Call
   4         elf_numsections instead of bfd_count_sections to initialize
   5         dwp_file->num_sections.
   6
   7 2019-02-25  Tom Tromey  <tromey@adacore.com>
   8
   9         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  10
  11 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  12
  13         * gcore.in: Add '--readnever' option when invoking GDB.
  14
  15 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  16
  17         * MAINTAINERS: Update my email address.
  18
  19 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * build-id.c (build_id_to_debug_bfd_1): New function.
  22         (build_id_to_debug_bfd): Look for separate debug file in
  23         sysroot.
  24
  25 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  26
  27         * gdbarch.sh: Update the copyright year range that is placed into
  28         generated files.
  29
  30 2019-02-22  Keith Seitz  <keiths@redhat.com>
  31
  32         PR symtab/23853
  33         * linespec.c (create_sals_line_offset): Search for the default
  34         symtab's filename instead of its fullname.
  35
  36 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  37
  38         * NEWS: Update style defaults.
  39
  40 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  41
  42         * main.c (captured_main_1): Disable styling in batch mode.
  43
  44 2019-02-20  Tom Tromey  <tom@tromey.com>
  45
  46         * symtab.c (symtab_symbol_info): Fix typos.
  47
  48 2019-02-20  Tom Tromey  <tromey@adacore.com>
  49
  50         * findcmd.c (_initialize_mem_search): Use upper case for
  51         metasyntactic variables.
  52
  53 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  54
  55         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  56         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  57
  58 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  59
  60         * top.h (source_file_name): Change to std::string.
  61         * top.c (source_file_name): Likewise.
  62         (command_line_input): Adjust.
  63         * cli/cli-script.c (script_from_file): Adjust.
  64
  65 2019-02-19  Tom Tromey  <tromey@adacore.com>
  66
  67         * ravenscar-thread.c
  68         (ravenscar_thread_target::update_thread_list): Don't call
  69         ada_build_task_list.
  70         * ada-lang.h (ada_build_task_list): Don't declare.
  71         * ada-tasks.c (struct ada_tasks_inferior_data)
  72         <task_list_valid_p>: Now bool.
  73         (read_known_tasks, ada_task_list_changed)
  74         (ada_tasks_invalidate_inferior_data): Update.
  75         (read_known_tasks_array): Return bool.
  76         (read_known_tasks_list): Likewise.
  77         (read_known_tasks): Return void.
  78         (ada_build_task_list): Now static.
  79
  80 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  83         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  84
  85 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  86
  87         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  88         variant for ada_tasks_pspace_data_handle and
  89         ada_tasks_inferior_data_handle.
  90         (ada_tasks_pspace_data_cleanup): New function.
  91         (ada_tasks_inferior_data_cleanup): New function.
  92
  93 2019-02-17  Tom Tromey  <tom@tromey.com>
  94
  95         * macrotab.h (macro_source_fullname): Return a std::string.
  96         * macrotab.c (macro_include, check_for_redefinition)
  97         (macro_undef, macro_lookup_definition, foreach_macro)
  98         (foreach_macro_in_scope): Update.
  99         (macro_source_fullname): Return a std::string.
 100         * macrocmd.c (show_pp_source_pos): Update.
 101
 102 2019-02-17  Tom Tromey  <tom@tromey.com>
 103
 104         * macrocmd.c (show_pp_source_pos): Style the file names.
 105
 106 2019-02-17  Tom Tromey  <tom@tromey.com>
 107
 108         PR tui/24197:
 109         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 110
 111 2019-02-17  Tom Tromey  <tom@tromey.com>
 112
 113         * ada-lang.c (user_select_syms): Use filtered printing.
 114         * utils.c (wrap_style): New global.
 115         (desired_style): Remove.
 116         (emit_style_escape): Add stream parameter.
 117         (set_output_style, reset_terminal_style, prompt_for_continue):
 118         Update.
 119         (flush_wrap_buffer): Only flush gdb_stdout.
 120         (wrap_here): Set wrap_style.
 121         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 122         treat escape sequences as a character.  Change when wrap buffer is
 123         flushed.
 124         (fputs_styled): Do not set the output style when the default is
 125         requested.
 126         * ui-style.h (struct ui_file_style) <is_default>: New method.
 127         * source.c (print_source_lines_base): Emit escape sequences in one
 128         piece.
 129
 130 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 131
 132         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 133         integers and enumeration types.
 134
 135 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 136
 137         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 138         instead of lookup_symbol_in_language
 139         (do_exact_match): New function.
 140         (ada_get_symbol_name_matcher): Return do_exact_match when
 141         doing a verbatim match.
 142
 143 2019-02-15  Tom Tromey  <tromey@adacore.com>
 144
 145         * ravenscar-thread.c (ravenscar_thread_target::resume)
 146         (ravenscar_thread_target::wait): Special case wildcard requests.
 147
 148 2019-02-15  Tom Tromey  <tromey@adacore.com>
 149
 150         * ravenscar-thread.c (base_ptid): Remove.
 151         (struct ravenscar_thread_target) <close>: New method.
 152         <m_base_ptid>: New member.
 153         <update_inferior_ptid, active_task, task_is_currently_active,
 154         runtime_initialized>: Declare methods.
 155         <ravenscar_thread_target>: Add constructor.
 156         (ravenscar_thread_target::task_is_currently_active)
 157         (ravenscar_thread_target::update_inferior_ptid)
 158         (ravenscar_runtime_initialized): Rename.  Now methods.
 159         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 160         (ravenscar_thread_target::update_thread_list): Update.
 161         (ravenscar_thread_target::active_task): Now method.
 162         (ravenscar_thread_target::store_registers)
 163         (ravenscar_thread_target::prepare_to_store)
 164         (ravenscar_thread_target::prepare_to_store)
 165         (ravenscar_thread_target::mourn_inferior): Update.
 166         (ravenscar_inferior_created): Use "new" to create target.
 167         (ravenscar_thread_target::get_ada_task_ptid): Update.
 168         (_initialize_ravenscar): Don't initialize base_ptid.
 169         (ravenscar_ops): Remove global.
 170
 171 2019-02-15  Tom Tromey  <tromey@adacore.com>
 172
 173         * target.h (push_target): Declare new overload.
 174         * target.c (push_target): New overload, taking an rvalue reference.
 175         * remote.c (remote_target::open_1): Use push_target overload.
 176         * corelow.c (core_target_open): Use push_target overload.
 177
 178 2019-02-15  Tom Tromey  <tromey@adacore.com>
 179
 180         * ravenscar-thread.c (is_ravenscar_task)
 181         (ravenscar_task_is_currently_active): Return bool.
 182         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 183         (_initialize_ravenscar): Remove "(void)".
 184         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 185         Return bool.
 186
 187 2019-02-15  Tom Tromey  <tromey@adacore.com>
 188
 189         * ravenscar-thread.c (ravenscar_runtime_initializer)
 190         (has_ravenscar_runtime, get_running_thread_id)
 191         (ravenscar_thread_target::resume): Fix indentation.
 192
 193 2019-02-15  Tom Tromey  <tromey@adacore.com>
 194
 195         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 196         from ravenscar_arch_ops.
 197         (sparc_ravenscar_ops::fetch_registers)
 198         (sparc_ravenscar_ops::store_registers): Now methods.
 199         (sparc_ravenscar_prepare_to_store): Remove.
 200         (sparc_ravenscar_ops): Redefine.
 201         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 202         methods and destructor.  Remove members.
 203         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 204         (ravenscar_thread_target::store_registers)
 205         (ravenscar_thread_target::prepare_to_store): Update.
 206         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 207         Remove.
 208         (struct ppc_ravenscar_powerpc_ops): Derive from
 209         ravenscar_arch_ops.
 210         (ppc_ravenscar_powerpc_ops::fetch_registers)
 211         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 212         (ppc_ravenscar_powerpc_ops): Redefine.
 213         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 214         (ppc_ravenscar_e500_ops::fetch_registers)
 215         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 216         (ppc_ravenscar_e500_ops): Redefine.
 217         * aarch64-ravenscar-thread.c
 218         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 219         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 220         (aarch64_ravenscar_fetch_registers)
 221         (aarch64_ravenscar_store_registers): Now methods.
 222         (aarch64_ravenscar_ops): Redefine.
 223
 224 2019-02-15  Tom Tromey  <tromey@adacore.com>
 225
 226         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 227         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 228         (ravenscar_thread_target::stopped_by_watchpoint)
 229         (ravenscar_thread_target::stopped_data_address)
 230         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 231
 232 2019-02-15  Tom Tromey  <tromey@adacore.com>
 233
 234         * ravenscar-thread.c: Fix some typos.
 235
 236 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 237             Tom Tromey  <tromey@adacore.com>
 238
 239         * ada-lang.c (ada_exception_sal): Change addr_string to a
 240         std::string.
 241         (create_ada_exception_catchpoint): Update.
 242
 243 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 244             Tom Tromey  <tromey@adacore.com>
 245
 246         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 247         (bp_location_ops): Remove.
 248         (base_breakpoint_allocate_location): Update.
 249         (free_bp_location): Update.
 250         * ada-lang.c (class ada_catchpoint_location)
 251         <ada_catchpoint_location>: Remove ops parameter.
 252         (ada_catchpoint_location_dtor): Remove.
 253         (ada_catchpoint_location_ops): Remove.
 254         (allocate_location_exception): Update.
 255         * breakpoint.h (struct bp_location_ops): Remove.
 256         (class bp_location) <bp_location>: Remove bp_location_ops
 257         parameter.
 258         <~bp_location>: Add destructor.
 259         <ops>: Remove.
 260
 261 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 262             Pedro Alves  <palves@redhat.com>
 263
 264         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 265         'PATH_MAX'.
 266
 267 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 268             Samuel Thibault  <samuel.thibault@gnu.org>
 269             Thomas Schwinge  <thomas@codesourcery.com>
 270
 271         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 272         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 273
 274 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 275
 276         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 277         (check_empty): Use "const char *".
 278
 279         * gnu-nat.c (gnu_nat_target::detach): Instead of
 280         'detach_inferior (pid)' call
 281         'detach_inferior (find_inferior_pid (pid))'.
 282
 283         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 284         'nat/fork-inferior.o'.
 285         * gnu-nat.c: #include "nat/fork-inferior.h".
 286
 287         * gnu-nat.c (gnu_nat_target::detach): Instead of
 288         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 289         * gnu-nat.h: #include "inf-child.h".
 290         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 291         'i386_gnu_nat_target::fetch_registers'.
 292         (gnu_store_registers): Rename/move to
 293         'i386_gnu_nat_target::store_registers'.
 294
 295         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 296         * gnu-nat.h (mach_thread_info): New function.
 297         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 298
 299         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 300
 301 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 302
 303         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 304
 305 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 306
 307         * windows-nat.c (windows_add_thread): Add new parameter
 308         "main_thread_p" with default value set to false.  Update
 309         function documentation as well as all callers.
 310         (windows_delete_thread): Likewise.
 311         (fake_create_process): Update call to windows_add_thread.
 312         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 313         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 314         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 315         call to windows_delete_thread.
 316
 317 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 318
 319         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 320
 321 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 322
 323         * symfile.c (find_separate_debug_file): Use canonical path of
 324         sysroot with child_path instead of gdb_sysroot if it is valid.
 325
 326 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 327
 328         * symfile.c (find_separate_debug_file): Use child_path to
 329         determine if an object file is under a sysroot.
 330
 331 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 332
 333         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 334         unittests/child-path-selftests.c.
 335         * common/pathstuff.c (child_path): New function.
 336         * common/pathstuff.h (child_path): New prototype.
 337         * unittests/child-path-selftests.c: New file.
 338
 339 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 340
 341         * symfile.c (find_separate_debug_file): Look for separate debug
 342         files in debug directories under the sysroot.
 343
 344 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 345
 346         * symtab.h (struct minimal_symbol data_p): New const method.
 347         (struct minimal_symbol text_p): Likewise.
 348         * symtab.c (output_source_filename): Use file name style
 349         to print file name.
 350         (print_symbol_info): Likewise.
 351         (print_msymbol_info): Use address style to print addresses.
 352         Use function name style to print executable text symbols.
 353         (expand_symtab_containing_pc): Use data_p.
 354         (find_pc_sect_compunit_symtab): Likewise.
 355
 356 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 357
 358         * breakpoint.c (describe_other_breakpoints): Use address style
 359         to print addresses.
 360         (say_where): Likewise.
 361
 362 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 363
 364         * ada-typeprint.c (print_func_type): Print function name
 365         style to print function name.
 366         * c-typeprint.c (c_print_type_1): Likewise.
 367
 368 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 369
 370         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 371         for execve.
 372
 373 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 374
 375         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 376         type_stack.
 377
 378 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 379
 380         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 381         TYPE_CODE_REF types.
 382
 383 2019-02-08  Jim Wilson  <jimw@sifive.com>
 384
 385         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 386         (riscv_linux_fregset): New.
 387         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 388
 389 2019-02-07  Tom Tromey  <tom@tromey.com>
 390
 391         * thread.c (thread_cancel_execution_command): Update.
 392         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 393         methods.
 394         (struct thread_fsm_ops): Remove.
 395         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 396         (thread_fsm_should_stop, thread_fsm_return_value)
 397         (thread_fsm_set_finished, thread_fsm_finished_p)
 398         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 399         Don't declare.
 400         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 401         * infrun.c (clear_proceed_status_thread)
 402         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 403         (print_stop_event): Update.
 404         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 405         Add constructor.
 406         (step_command_fsm_ops): Remove.
 407         (new_step_command_fsm): Remove.
 408         (step_1): Update.
 409         (step_command_fsm::should_stop): Rename from
 410         step_command_fsm_should_stop.
 411         (step_command_fsm::clean_up): Rename from
 412         step_command_fsm_clean_up.
 413         (step_command_fsm::do_async_reply_reason): Rename from
 414         step_command_fsm_async_reply_reason.
 415         (struct until_next_fsm): Inherit from thread_fsm.  Add
 416         constructor.
 417         (until_next_fsm_ops): Remove.
 418         (new_until_next_fsm): Remove.
 419         (until_next_fsm::should_stop): Rename from
 420         until_next_fsm_should_stop.
 421         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 422         (until_next_fsm::do_async_reply_reason): Rename from
 423         until_next_fsm_async_reply_reason.
 424         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 425         constructor.  Change type of breakpoint.
 426         (finish_command_fsm_ops): Remove.
 427         (new_finish_command_fsm): Remove.
 428         (finish_command_fsm::should_stop): Rename from
 429         finish_command_fsm_should_stop.
 430         (finish_command_fsm::clean_up): Rename from
 431         finish_command_fsm_clean_up.
 432         (finish_command_fsm::return_value): Rename from
 433         finish_command_fsm_return_value.
 434         (finish_command_fsm::do_async_reply_reason): Rename from
 435         finish_command_fsm_async_reply_reason.
 436         (finish_command): Update.
 437         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 438         Add constructor.
 439         (call_thread_fsm_ops): Remove.
 440         (call_thread_fsm::call_thread_fsm): Rename from
 441         new_call_thread_fsm.
 442         (call_thread_fsm::should_stop): Rename from
 443         call_thread_fsm_should_stop.
 444         (call_thread_fsm::should_notify_stop): Rename from
 445         call_thread_fsm_should_notify_stop.
 446         (run_inferior_call, call_function_by_hand_dummy): Update.
 447         * cli/cli-interp.c (should_print_stop_to_console): Update.
 448         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 449         Add constructor.  Change type of location_breakpoint,
 450         caller_breakpoint.
 451         (until_break_fsm_ops): Remove.
 452         (new_until_break_fsm): Remove.
 453         (until_break_fsm::should_stop): Rename from
 454         until_break_fsm_should_stop.
 455         (until_break_fsm::clean_up): Rename from
 456         until_break_fsm_clean_up.
 457         (until_break_fsm::do_async_reply_reason): Rename from
 458         until_break_fsm_async_reply_reason.
 459         (until_break_command): Update.
 460         * thread-fsm.c: Remove.
 461         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 462
 463 2019-02-07  Tom Tromey  <tom@tromey.com>
 464
 465         * yy-remap.h: Add include guard.
 466         * xtensa-tdep.h: Add include guard.
 467         * xcoffread.h: Rename include guard.
 468         * varobj-iter.h: Add include guard.
 469         * tui/tui.h: Rename include guard.
 470         * tui/tui-winsource.h: Rename include guard.
 471         * tui/tui-wingeneral.h: Rename include guard.
 472         * tui/tui-windata.h: Rename include guard.
 473         * tui/tui-win.h: Rename include guard.
 474         * tui/tui-stack.h: Rename include guard.
 475         * tui/tui-source.h: Rename include guard.
 476         * tui/tui-regs.h: Rename include guard.
 477         * tui/tui-out.h: Rename include guard.
 478         * tui/tui-layout.h: Rename include guard.
 479         * tui/tui-io.h: Rename include guard.
 480         * tui/tui-hooks.h: Rename include guard.
 481         * tui/tui-file.h: Rename include guard.
 482         * tui/tui-disasm.h: Rename include guard.
 483         * tui/tui-data.h: Rename include guard.
 484         * tui/tui-command.h: Rename include guard.
 485         * tic6x-tdep.h: Add include guard.
 486         * target/waitstatus.h: Rename include guard.
 487         * target/wait.h: Rename include guard.
 488         * target/target.h: Rename include guard.
 489         * target/resume.h: Rename include guard.
 490         * target-float.h: Rename include guard.
 491         * stabsread.h: Add include guard.
 492         * rs6000-tdep.h: Add include guard.
 493         * riscv-fbsd-tdep.h: Add include guard.
 494         * regformats/regdef.h: Rename include guard.
 495         * record.h: Rename include guard.
 496         * python/python.h: Rename include guard.
 497         * python/python-internal.h: Rename include guard.
 498         * python/py-stopevent.h: Rename include guard.
 499         * python/py-ref.h: Rename include guard.
 500         * python/py-record.h: Rename include guard.
 501         * python/py-record-full.h: Rename include guard.
 502         * python/py-record-btrace.h: Rename include guard.
 503         * python/py-instruction.h: Rename include guard.
 504         * python/py-events.h: Rename include guard.
 505         * python/py-event.h: Rename include guard.
 506         * procfs.h: Add include guard.
 507         * proc-utils.h: Add include guard.
 508         * p-lang.h: Add include guard.
 509         * or1k-tdep.h: Rename include guard.
 510         * observable.h: Rename include guard.
 511         * nto-tdep.h: Rename include guard.
 512         * nat/x86-linux.h: Rename include guard.
 513         * nat/x86-linux-dregs.h: Rename include guard.
 514         * nat/x86-gcc-cpuid.h: Add include guard.
 515         * nat/x86-dregs.h: Rename include guard.
 516         * nat/x86-cpuid.h: Rename include guard.
 517         * nat/ppc-linux.h: Rename include guard.
 518         * nat/mips-linux-watch.h: Rename include guard.
 519         * nat/linux-waitpid.h: Rename include guard.
 520         * nat/linux-ptrace.h: Rename include guard.
 521         * nat/linux-procfs.h: Rename include guard.
 522         * nat/linux-osdata.h: Rename include guard.
 523         * nat/linux-nat.h: Rename include guard.
 524         * nat/linux-namespaces.h: Rename include guard.
 525         * nat/linux-btrace.h: Rename include guard.
 526         * nat/glibc_thread_db.h: Rename include guard.
 527         * nat/gdb_thread_db.h: Rename include guard.
 528         * nat/gdb_ptrace.h: Rename include guard.
 529         * nat/fork-inferior.h: Rename include guard.
 530         * nat/amd64-linux-siginfo.h: Rename include guard.
 531         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 532         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 533         * nat/aarch64-linux.h: Rename include guard.
 534         * nat/aarch64-linux-hw-point.h: Rename include guard.
 535         * mn10300-tdep.h: Add include guard.
 536         * mips-linux-tdep.h: Add include guard.
 537         * mi/mi-parse.h: Rename include guard.
 538         * mi/mi-out.h: Rename include guard.
 539         * mi/mi-main.h: Rename include guard.
 540         * mi/mi-interp.h: Rename include guard.
 541         * mi/mi-getopt.h: Rename include guard.
 542         * mi/mi-console.h: Rename include guard.
 543         * mi/mi-common.h: Rename include guard.
 544         * mi/mi-cmds.h: Rename include guard.
 545         * mi/mi-cmd-break.h: Rename include guard.
 546         * m2-lang.h: Add include guard.
 547         * location.h: Rename include guard.
 548         * linux-record.h: Rename include guard.
 549         * linux-nat.h: Add include guard.
 550         * linux-fork.h: Add include guard.
 551         * i386-darwin-tdep.h: Rename include guard.
 552         * hppa-linux-offsets.h: Add include guard.
 553         * guile/guile.h: Rename include guard.
 554         * guile/guile-internal.h: Rename include guard.
 555         * gnu-nat.h: Rename include guard.
 556         * gdb-stabs.h: Rename include guard.
 557         * frv-tdep.h: Add include guard.
 558         * f-lang.h: Add include guard.
 559         * event-loop.h: Add include guard.
 560         * darwin-nat.h: Rename include guard.
 561         * cp-abi.h: Rename include guard.
 562         * config/sparc/nm-sol2.h: Rename include guard.
 563         * config/nm-nto.h: Rename include guard.
 564         * config/nm-linux.h: Add include guard.
 565         * config/i386/nm-i386gnu.h: Rename include guard.
 566         * config/djgpp/nl_types.h: Rename include guard.
 567         * config/djgpp/langinfo.h: Rename include guard.
 568         * compile/gcc-cp-plugin.h: Add include guard.
 569         * compile/gcc-c-plugin.h: Add include guard.
 570         * compile/compile.h: Rename include guard.
 571         * compile/compile-object-run.h: Rename include guard.
 572         * compile/compile-object-load.h: Rename include guard.
 573         * compile/compile-internal.h: Rename include guard.
 574         * compile/compile-cplus.h: Rename include guard.
 575         * compile/compile-c.h: Rename include guard.
 576         * common/xml-utils.h: Rename include guard.
 577         * common/x86-xstate.h: Rename include guard.
 578         * common/version.h: Rename include guard.
 579         * common/vec.h: Rename include guard.
 580         * common/tdesc.h: Rename include guard.
 581         * common/selftest.h: Rename include guard.
 582         * common/scoped_restore.h: Rename include guard.
 583         * common/scoped_mmap.h: Rename include guard.
 584         * common/scoped_fd.h: Rename include guard.
 585         * common/safe-iterator.h: Rename include guard.
 586         * common/run-time-clock.h: Rename include guard.
 587         * common/refcounted-object.h: Rename include guard.
 588         * common/queue.h: Rename include guard.
 589         * common/ptid.h: Rename include guard.
 590         * common/print-utils.h: Rename include guard.
 591         * common/preprocessor.h: Rename include guard.
 592         * common/pathstuff.h: Rename include guard.
 593         * common/observable.h: Rename include guard.
 594         * common/netstuff.h: Rename include guard.
 595         * common/job-control.h: Rename include guard.
 596         * common/host-defs.h: Rename include guard.
 597         * common/gdb_wait.h: Rename include guard.
 598         * common/gdb_vecs.h: Rename include guard.
 599         * common/gdb_unlinker.h: Rename include guard.
 600         * common/gdb_unique_ptr.h: Rename include guard.
 601         * common/gdb_tilde_expand.h: Rename include guard.
 602         * common/gdb_sys_time.h: Rename include guard.
 603         * common/gdb_string_view.h: Rename include guard.
 604         * common/gdb_splay_tree.h: Rename include guard.
 605         * common/gdb_setjmp.h: Rename include guard.
 606         * common/gdb_ref_ptr.h: Rename include guard.
 607         * common/gdb_optional.h: Rename include guard.
 608         * common/gdb_locale.h: Rename include guard.
 609         * common/gdb_assert.h: Rename include guard.
 610         * common/filtered-iterator.h: Rename include guard.
 611         * common/filestuff.h: Rename include guard.
 612         * common/fileio.h: Rename include guard.
 613         * common/environ.h: Rename include guard.
 614         * common/common-utils.h: Rename include guard.
 615         * common/common-types.h: Rename include guard.
 616         * common/common-regcache.h: Rename include guard.
 617         * common/common-inferior.h: Rename include guard.
 618         * common/common-gdbthread.h: Rename include guard.
 619         * common/common-exceptions.h: Rename include guard.
 620         * common/common-defs.h: Rename include guard.
 621         * common/common-debug.h: Rename include guard.
 622         * common/cleanups.h: Rename include guard.
 623         * common/buffer.h: Rename include guard.
 624         * common/btrace-common.h: Rename include guard.
 625         * common/break-common.h: Rename include guard.
 626         * cli/cli-utils.h: Rename include guard.
 627         * cli/cli-style.h: Rename include guard.
 628         * cli/cli-setshow.h: Rename include guard.
 629         * cli/cli-script.h: Rename include guard.
 630         * cli/cli-interp.h: Rename include guard.
 631         * cli/cli-decode.h: Rename include guard.
 632         * cli/cli-cmds.h: Rename include guard.
 633         * charset-list.h: Add include guard.
 634         * buildsym-legacy.h: Rename include guard.
 635         * bfin-tdep.h: Add include guard.
 636         * ax.h: Rename include guard.
 637         * arm-linux-tdep.h: Add include guard.
 638         * arm-fbsd-tdep.h: Add include guard.
 639         * arch/xtensa.h: Rename include guard.
 640         * arch/tic6x.h: Add include guard.
 641         * arch/i386.h: Add include guard.
 642         * arch/arm.h: Rename include guard.
 643         * arch/arm-linux.h: Rename include guard.
 644         * arch/arm-get-next-pcs.h: Rename include guard.
 645         * arch/amd64.h: Add include guard.
 646         * arch/aarch64-insn.h: Rename include guard.
 647         * arch-utils.h: Rename include guard.
 648         * annotate.h: Add include guard.
 649         * amd64-darwin-tdep.h: Rename include guard.
 650         * aarch64-linux-tdep.h: Add include guard.
 651         * aarch64-fbsd-tdep.h: Add include guard.
 652         * aarch32-linux-nat.h: Add include guard.
 653
 654 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 655
 656         * macrotab.c (macro_define_internal): New function that
 657         factorizes macro_define_object_internal and macro_define_function
 658         code.
 659         (macro_define_object_internal): Use macro_define_internal.
 660         (macro_define_function): Likewise.
 661
 662 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 663
 664         * macrocmd.c (extract_identifier): Return
 665         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 666         callers.
 667
 668 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 669
 670         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 671
 672 2019-02-05  Tom Tromey  <tom@tromey.com>
 673
 674         * target.c (target_stack::unpush): Move assertion earlier.
 675
 676 2019-01-30  Tom Tromey  <tom@tromey.com>
 677
 678         PR python/23615:
 679         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 680         (gdbpy_parse_and_eval): Likewise.
 681         * python/python-internal.h (gdbpy_allow_threads): New class.
 682
 683 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 684
 685         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 686         (aarch64_fbsd_fpregmap): Move earlier.
 687         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 688         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 689         instead of individual calls to trad_frame_set_reg_addr.
 690         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 691         earlier.
 692         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 693         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 694         instead of individual calls to trad_frame_set_reg_addr.
 695
 696 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 697
 698         * CONTRIBUTE: Replace contribution list with wiki link.
 699
 700 2019-01-25  Tom Tromey  <tom@tromey.com>
 701
 702         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 703
 704 2019-01-25  Tom Tromey  <tom@tromey.com>
 705
 706         * xtensa-linux-nat.c: Fix common/ includes.
 707         * xml-support.h: Fix common/ includes.
 708         * xml-support.c: Fix common/ includes.
 709         * x86-linux-nat.c: Fix common/ includes.
 710         * windows-nat.c: Fix common/ includes.
 711         * varobj.h: Fix common/ includes.
 712         * varobj.c: Fix common/ includes.
 713         * value.c: Fix common/ includes.
 714         * valops.c: Fix common/ includes.
 715         * utils.c: Fix common/ includes.
 716         * unittests/xml-utils-selftests.c: Fix common/ includes.
 717         * unittests/utils-selftests.c: Fix common/ includes.
 718         * unittests/unpack-selftests.c: Fix common/ includes.
 719         * unittests/tracepoint-selftests.c: Fix common/ includes.
 720         * unittests/style-selftests.c: Fix common/ includes.
 721         * unittests/string_view-selftests.c: Fix common/ includes.
 722         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 723         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 724         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 725         * unittests/rsp-low-selftests.c: Fix common/ includes.
 726         * unittests/parse-connection-spec-selftests.c: Fix common/
 727         includes.
 728         * unittests/optional-selftests.c: Fix common/ includes.
 729         * unittests/offset-type-selftests.c: Fix common/ includes.
 730         * unittests/observable-selftests.c: Fix common/ includes.
 731         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 732         * unittests/memrange-selftests.c: Fix common/ includes.
 733         * unittests/memory-map-selftests.c: Fix common/ includes.
 734         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 735         * unittests/function-view-selftests.c: Fix common/ includes.
 736         * unittests/environ-selftests.c: Fix common/ includes.
 737         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 738         * unittests/common-utils-selftests.c: Fix common/ includes.
 739         * unittests/cli-utils-selftests.c: Fix common/ includes.
 740         * unittests/array-view-selftests.c: Fix common/ includes.
 741         * ui-file.c: Fix common/ includes.
 742         * tui/tui-io.c: Fix common/ includes.
 743         * tracepoint.h: Fix common/ includes.
 744         * tracepoint.c: Fix common/ includes.
 745         * tracefile-tfile.c: Fix common/ includes.
 746         * top.h: Fix common/ includes.
 747         * top.c: Fix common/ includes.
 748         * thread.c: Fix common/ includes.
 749         * target/waitstatus.h: Fix common/ includes.
 750         * target/waitstatus.c: Fix common/ includes.
 751         * target.h: Fix common/ includes.
 752         * target.c: Fix common/ includes.
 753         * target-memory.c: Fix common/ includes.
 754         * target-descriptions.c: Fix common/ includes.
 755         * symtab.h: Fix common/ includes.
 756         * symfile.c: Fix common/ includes.
 757         * stap-probe.c: Fix common/ includes.
 758         * spu-linux-nat.c: Fix common/ includes.
 759         * sparc-nat.c: Fix common/ includes.
 760         * source.c: Fix common/ includes.
 761         * solib.c: Fix common/ includes.
 762         * solib-target.c: Fix common/ includes.
 763         * ser-unix.c: Fix common/ includes.
 764         * ser-tcp.c: Fix common/ includes.
 765         * ser-pipe.c: Fix common/ includes.
 766         * ser-base.c: Fix common/ includes.
 767         * selftest-arch.c: Fix common/ includes.
 768         * s12z-tdep.c: Fix common/ includes.
 769         * rust-exp.y: Fix common/ includes.
 770         * rs6000-aix-tdep.c: Fix common/ includes.
 771         * riscv-tdep.c: Fix common/ includes.
 772         * remote.c: Fix common/ includes.
 773         * remote-notif.h: Fix common/ includes.
 774         * remote-fileio.h: Fix common/ includes.
 775         * remote-fileio.c: Fix common/ includes.
 776         * regcache.h: Fix common/ includes.
 777         * regcache.c: Fix common/ includes.
 778         * record-btrace.c: Fix common/ includes.
 779         * python/python.c: Fix common/ includes.
 780         * python/py-type.c: Fix common/ includes.
 781         * python/py-inferior.c: Fix common/ includes.
 782         * progspace.h: Fix common/ includes.
 783         * producer.c: Fix common/ includes.
 784         * procfs.c: Fix common/ includes.
 785         * proc-api.c: Fix common/ includes.
 786         * printcmd.c: Fix common/ includes.
 787         * ppc-linux-nat.c: Fix common/ includes.
 788         * parser-defs.h: Fix common/ includes.
 789         * osdata.c: Fix common/ includes.
 790         * obsd-nat.c: Fix common/ includes.
 791         * nat/x86-linux.c: Fix common/ includes.
 792         * nat/x86-linux-dregs.c: Fix common/ includes.
 793         * nat/x86-dregs.h: Fix common/ includes.
 794         * nat/x86-dregs.c: Fix common/ includes.
 795         * nat/ppc-linux.c: Fix common/ includes.
 796         * nat/mips-linux-watch.h: Fix common/ includes.
 797         * nat/mips-linux-watch.c: Fix common/ includes.
 798         * nat/linux-waitpid.c: Fix common/ includes.
 799         * nat/linux-ptrace.h: Fix common/ includes.
 800         * nat/linux-ptrace.c: Fix common/ includes.
 801         * nat/linux-procfs.c: Fix common/ includes.
 802         * nat/linux-personality.c: Fix common/ includes.
 803         * nat/linux-osdata.c: Fix common/ includes.
 804         * nat/linux-namespaces.c: Fix common/ includes.
 805         * nat/linux-btrace.h: Fix common/ includes.
 806         * nat/linux-btrace.c: Fix common/ includes.
 807         * nat/fork-inferior.c: Fix common/ includes.
 808         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 809         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 810         * nat/aarch64-linux.c: Fix common/ includes.
 811         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 812         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 813         * namespace.h: Fix common/ includes.
 814         * mips-linux-tdep.c: Fix common/ includes.
 815         * minsyms.c: Fix common/ includes.
 816         * mi/mi-parse.h: Fix common/ includes.
 817         * mi/mi-main.c: Fix common/ includes.
 818         * mi/mi-cmd-env.c: Fix common/ includes.
 819         * memrange.h: Fix common/ includes.
 820         * memattr.c: Fix common/ includes.
 821         * maint.h: Fix common/ includes.
 822         * maint.c: Fix common/ includes.
 823         * main.c: Fix common/ includes.
 824         * machoread.c: Fix common/ includes.
 825         * location.c: Fix common/ includes.
 826         * linux-thread-db.c: Fix common/ includes.
 827         * linux-nat.c: Fix common/ includes.
 828         * linux-fork.c: Fix common/ includes.
 829         * inline-frame.c: Fix common/ includes.
 830         * infrun.c: Fix common/ includes.
 831         * inflow.c: Fix common/ includes.
 832         * inferior.h: Fix common/ includes.
 833         * inferior.c: Fix common/ includes.
 834         * infcmd.c: Fix common/ includes.
 835         * inf-ptrace.c: Fix common/ includes.
 836         * inf-child.c: Fix common/ includes.
 837         * ia64-linux-nat.c: Fix common/ includes.
 838         * i387-tdep.c: Fix common/ includes.
 839         * i386-tdep.c: Fix common/ includes.
 840         * i386-linux-tdep.c: Fix common/ includes.
 841         * i386-linux-nat.c: Fix common/ includes.
 842         * i386-go32-tdep.c: Fix common/ includes.
 843         * i386-fbsd-tdep.c: Fix common/ includes.
 844         * i386-fbsd-nat.c: Fix common/ includes.
 845         * guile/scm-type.c: Fix common/ includes.
 846         * guile/guile.c: Fix common/ includes.
 847         * go32-nat.c: Fix common/ includes.
 848         * gnu-nat.c: Fix common/ includes.
 849         * gdbthread.h: Fix common/ includes.
 850         * gdbarch-selftests.c: Fix common/ includes.
 851         * gdb_usleep.c: Fix common/ includes.
 852         * gdb_select.h: Fix common/ includes.
 853         * gdb_bfd.c: Fix common/ includes.
 854         * gcore.c: Fix common/ includes.
 855         * fork-child.c: Fix common/ includes.
 856         * findvar.c: Fix common/ includes.
 857         * fbsd-nat.c: Fix common/ includes.
 858         * event-top.c: Fix common/ includes.
 859         * event-loop.c: Fix common/ includes.
 860         * dwarf2read.c: Fix common/ includes.
 861         * dwarf2loc.c: Fix common/ includes.
 862         * dwarf2-frame.c: Fix common/ includes.
 863         * dwarf-index-cache.c: Fix common/ includes.
 864         * dtrace-probe.c: Fix common/ includes.
 865         * disasm-selftests.c: Fix common/ includes.
 866         * defs.h: Fix common/ includes.
 867         * csky-tdep.c: Fix common/ includes.
 868         * cp-valprint.c: Fix common/ includes.
 869         * cp-support.h: Fix common/ includes.
 870         * cp-support.c: Fix common/ includes.
 871         * corelow.c: Fix common/ includes.
 872         * completer.h: Fix common/ includes.
 873         * completer.c: Fix common/ includes.
 874         * compile/compile.c: Fix common/ includes.
 875         * compile/compile-loc2c.c: Fix common/ includes.
 876         * compile/compile-cplus-types.c: Fix common/ includes.
 877         * compile/compile-cplus-symbols.c: Fix common/ includes.
 878         * command.h: Fix common/ includes.
 879         * cli/cli-dump.c: Fix common/ includes.
 880         * cli/cli-cmds.c: Fix common/ includes.
 881         * charset.c: Fix common/ includes.
 882         * build-id.c: Fix common/ includes.
 883         * btrace.h: Fix common/ includes.
 884         * btrace.c: Fix common/ includes.
 885         * breakpoint.h: Fix common/ includes.
 886         * breakpoint.c: Fix common/ includes.
 887         * ax.h:
 888         (enum agent_op): Fix common/ includes.
 889         * ax-general.c (struct aop_map): Fix common/ includes.
 890         * ax-gdb.c: Fix common/ includes.
 891         * auxv.c: Fix common/ includes.
 892         * auto-load.c: Fix common/ includes.
 893         * arm-tdep.c: Fix common/ includes.
 894         * arch/riscv.c: Fix common/ includes.
 895         * arch/ppc-linux-common.c: Fix common/ includes.
 896         * arch/i386.c: Fix common/ includes.
 897         * arch/arm.c: Fix common/ includes.
 898         * arch/arm-linux.c: Fix common/ includes.
 899         * arch/arm-get-next-pcs.c: Fix common/ includes.
 900         * arch/amd64.c: Fix common/ includes.
 901         * arch/aarch64.c: Fix common/ includes.
 902         * arch/aarch64-insn.c: Fix common/ includes.
 903         * arch-utils.c: Fix common/ includes.
 904         * amd64-windows-tdep.c: Fix common/ includes.
 905         * amd64-tdep.c: Fix common/ includes.
 906         * amd64-sol2-tdep.c: Fix common/ includes.
 907         * amd64-obsd-tdep.c: Fix common/ includes.
 908         * amd64-nbsd-tdep.c: Fix common/ includes.
 909         * amd64-linux-tdep.c: Fix common/ includes.
 910         * amd64-linux-nat.c: Fix common/ includes.
 911         * amd64-fbsd-tdep.c: Fix common/ includes.
 912         * amd64-fbsd-nat.c: Fix common/ includes.
 913         * amd64-dicos-tdep.c: Fix common/ includes.
 914         * amd64-darwin-tdep.c: Fix common/ includes.
 915         * agent.c: Fix common/ includes.
 916         * ada-lang.h: Fix common/ includes.
 917         * ada-lang.c: Fix common/ includes.
 918         * aarch64-tdep.c: Fix common/ includes.
 919
 920 2019-01-25  Tom Tromey  <tom@tromey.com>
 921
 922         * common/create-version.sh: Use common/version.h.
 923
 924 2019-01-24  Pedro Alves  <palves@redhat.com>
 925
 926         * infrun.c (signal_stop, signal_print, signal_program)
 927         (signal_catch, signal_pass): Now arrays instead of pointers.
 928         (update_signals_program_target, do_target_resume)
 929         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 930         * linux-nat.c (linux_nat_target::pass_signals)
 931         (linux_nat_target::create_inferior, linux_nat_target::attach):
 932         Adjust.
 933         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 934         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 935         * procfs.c (procfs_target::pass_signals): Adjust.
 936         * record-full.c (record_full_target::resume): Adjust.
 937         * remote.c (remote_target::pass_signals)
 938         (remote_target::program_signals): Adjust.
 939         * target-debug.h (target_debug_print_signals): Now takes a
 940         gdb::array_view as parameter.  Adjust.
 941         * target.h (target_ops) <pass_signals, program_signals>: Replace
 942         pointer and length parameters with gdb::array_view.
 943         (target_pass_signals, target_program_signals): Likewise.
 944         * target-delegates.c: Regenerate.
 945
 946 2019-01-24  Pedro Alves  <palves@redhat.com>
 947
 948         * common/forward-scope-exit.h
 949         (forward_scope_exit::forward_scope_exit): Pass arguments to
 950         m_bind_function directly, instead of creating a std::bind and
 951         copying that.
 952
 953 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 954
 955         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 956         for static members.
 957         (pass_in_v_vfp_candidate): Likewise.
 958
 959 2019-01-23  Tom Tromey  <tom@tromey.com>
 960             Pedro Alves  <palves@redhat.com>
 961
 962         * regcache.c (class regcache_invalidator): Remove.
 963         (regcache::raw_write): Use make_scope_exit.
 964
 965 2019-01-23  Tom Tromey  <tom@tromey.com>
 966
 967         * ui-out.h (class ui_out_emit_type): Update comment.
 968
 969 2019-01-23  Tom Tromey  <tom@tromey.com>
 970
 971         * infrun.c (fetch_inferior_event): Update comment.
 972
 973 2019-01-23  Tom Tromey  <tom@tromey.com>
 974             Pedro Alves  <palves@redhat.com>
 975
 976         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 977         parameter.
 978         (fetch_inferior_event): Use SCOPE_EXIT.
 979
 980
 981 2019-01-23  Tom Tromey  <tom@tromey.com>
 982             Pedro Alves  <palves@redhat.com>
 983
 984         * infrun.c (disable_thread_events): Delete.
 985         (stop_all_threads): Use SCOPE_EXIT.
 986
 987 2019-01-23  Tom Tromey  <tom@tromey.com>
 988             Pedro Alves  <palves@redhat.com>
 989
 990         * symfile.c: Include forward-scope-exit.h.
 991         (clear_symtab_users_cleanup): Replace forward declaration with
 992         a FORWARD_SCOPE_EXIT.
 993         (syms_from_objfile_1): Use the forward_scope_exit and
 994         gdb::optional instead of cleanup_function.
 995         (reread_symbols): Use the forward_scope_exit instead of
 996         cleanup_function.
 997         (clear_symtab_users_cleanup): Remove function.
 998
 999 2019-01-23  Tom Tromey  <tom@tromey.com>
1000             Pedro Alves  <palves@redhat.com>
1001
1002         * linux-nat.c: Include scope-exit.h.
1003         (cleanup_target_stop): Remove.
1004         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1005         SCOPE_EXIT.
1006
1007 2019-01-23  Tom Tromey  <tom@tromey.com>
1008             Pedro Alves  <palves@redhat.com>
1009
1010         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1011         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1012
1013 2019-01-23  Tom Tromey  <tom@tromey.com>
1014             Andrew Burgess  <andrew.burgess@embecosm.com>
1015             Pedro Alves  <palves@redhat.com>
1016
1017         * infrun.c (fetch_inferior_event): Use scope_exit.
1018         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1019         * top.c (execute_command): Use scope_exit.
1020         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1021         * utils.c (do_bpstat_clear_actions_cleanup)
1022         (make_bpstat_clear_actions_cleanup): Remove.
1023
1024 2019-01-23  Tom Tromey  <tom@tromey.com>
1025             Pedro Alves  <palves@redhat.com>
1026
1027         * infrun.c: Include "common/scope-exit.h"
1028         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1029         (wait_for_inferior): Use SCOPE_EXIT.
1030         (fetch_inferior_event): Use scope_exit.
1031
1032 2019-01-23  Tom Tromey  <tom@tromey.com>
1033             Pedro Alves  <palves@redhat.com>
1034
1035         * breakpoint.c (create_breakpoint): Remove cleanup.
1036
1037 2019-01-23  Tom Tromey  <tom@tromey.com>
1038             Andrew Burgess  <andrew.burgess@embecosm.com>
1039             Pedro Alves  <palves@redhat.com>
1040
1041 2019-01-23  Pedro Alves  <palves@redhat.com>
1042
1043         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1044
1045 2019-01-23  Pedro Alves  <palves@redhat.com>
1046             Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * gdbthread.h: Include "common/forward-scope-exit.h".
1049         (scoped_finish_thread_state): Redefine custom class in terms of
1050         forward_scope_exit.
1051
1052 2019-01-23  Pedro Alves  <palves@redhat.com>
1053             Andrew Burgess  <andrew.burgess@embecosm.com>
1054
1055         * common/forward-scope-exit.h: New file.
1056
1057 2019-01-23  Pedro Alves  <palves@redhat.com>
1058             Andrew Burgess  <andrew.burgess@embecosm.com>
1059             Tom Tromey  <tom@tromey.com>
1060
1061         * common/scope-exit.h: New file.
1062
1063 2019-01-23  Pedro Alves  <palves@redhat.com>
1064
1065         * common/preprocessor.h (ESC): Rename to ...
1066         (ESC_PARENS): ... this.
1067         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1068         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1069
1070 2019-01-23  Tom Tromey  <tom@tromey.com>
1071
1072         * language.h (class scoped_switch_to_sym_language_if_auto):
1073         Initialize m_lang in both cases.
1074
1075 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1076
1077         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1078         with XCNEW.
1079
1080 2019-01-22  Tom Tromey  <tom@tromey.com>
1081
1082         * corelow.c: Do not include sys/file.h.
1083
1084 2019-01-22  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-wingeneral.h: Include gdb_curses.h.
1087
1088 2019-01-22  Tom Tromey  <tom@tromey.com>
1089
1090         * source-cache.h (class source_cache) <get_source_lines,
1091         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1092
1093 2019-01-22  Tom Tromey  <tom@tromey.com>
1094
1095         * remote-fileio.h (struct remote_target): Declare.
1096
1097 2019-01-22  Tom Tromey  <tom@tromey.com>
1098
1099         * python/py-arch.c: Do not include py-ref.h.
1100         * python/py-bpevent.c: Do not include py-ref.h.
1101         * python/py-cmd.c: Do not include py-ref.h.
1102         * python/py-continueevent.c: Do not include py-ref.h.
1103         * python/py-event.h: Do not include py-ref.h.
1104         * python/py-evtregistry.c: Do not include py-ref.h.
1105         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1106         * python/py-frame.c: Do not include py-ref.h.
1107         * python/py-framefilter.c: Do not include py-ref.h.
1108         * python/py-function.c: Do not include py-ref.h.
1109         * python/py-infevents.c: Do not include py-ref.h.
1110         * python/py-linetable.c: Do not include py-ref.h.
1111         * python/py-objfile.c: Do not include py-ref.h.
1112         * python/py-param.c: Do not include py-ref.h.
1113         * python/py-prettyprint.c: Do not include py-ref.h.
1114         * python/py-progspace.c: Do not include py-ref.h.
1115         * python/py-symbol.c: Do not include py-ref.h.
1116         * python/py-symtab.c: Do not include py-ref.h.
1117         * python/py-type.c: Do not include py-ref.h.
1118         * python/py-unwind.c: Do not include py-ref.h.
1119         * python/py-utils.c: Do not include py-ref.h.
1120         * python/py-value.c: Do not include py-ref.h.
1121         * python/py-varobj.c: Do not include py-ref.h.
1122         * python/py-xmethods.c: Do not include py-ref.h.
1123         * python/python.c: Do not include py-ref.h.
1124         * varobj.c: Do not include py-ref.h.
1125
1126 2019-01-22  Tom Tromey  <tom@tromey.com>
1127
1128         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1129         keyword for bcache.
1130
1131 2019-01-22  Tom Tromey  <tom@tromey.com>
1132
1133         * compile/compile-cplus-types.c: Remove a comment by #include.
1134
1135 2019-01-22  Tom Tromey  <tom@tromey.com>
1136
1137         * compile/gcc-c-plugin.h: Include compile-internal.h.
1138
1139 2019-01-22  Tom Tromey  <tom@tromey.com>
1140
1141         * stabsread.c (EXTERN): Do not define.
1142         (symnum, next_symbol_text_func, processing_gcc_compilation)
1143         (within_function, global_sym_chain, global_stabs)
1144         (previous_stab_code, this_object_header_files)
1145         (n_this_object_header_files)
1146         (n_allocated_this_object_header_files): Define.
1147         * stabsread.h (EXTERN): Never define.  Use "extern".
1148
1149 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1150
1151         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1152         history_value.
1153
1154 2019-01-21  Tom Tromey  <tom@tromey.com>
1155
1156         * ui-out.c: Fix includes.
1157         * tui/tui-source.c: Fix includes.
1158         * target.c: Fix includes.
1159         * remote.c: Fix includes.
1160         * regcache.c: Fix includes.
1161         * python/py-block.c: Fix includes.
1162         * printcmd.c: Fix includes.
1163         * or1k-tdep.c: Fix includes.
1164         * mi/mi-main.c: Fix includes.
1165         * m32r-tdep.c: Fix includes.
1166         * csky-tdep.c: Fix includes.
1167         * compile/compile-cplus-types.c: Fix includes.
1168         * cli/cli-interp.c: Fix includes.
1169
1170 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1171
1172         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1173         for padding.
1174
1175 2019-01-16  Tom Tromey  <tom@tromey.com>
1176
1177         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1178         earlier.
1179         (struct objfile) <msymbols_range>: Move from top level.
1180         <msymbols>: New method.
1181         (class objfile_msymbols): Remove.
1182         * symtab.c (default_collect_symbol_completion_matches_break_on):
1183         Update.
1184         * symmisc.c (dump_msymbols): Update.
1185         * stabsread.c (scan_file_globals): Update.
1186         * objc-lang.c (info_selectors_command, info_classes_command)
1187         (find_methods): Update.
1188         * minsyms.c (find_solib_trampoline_target): Update.
1189         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1190         * coffread.c (coff_symfile_read): Update.
1191         * ada-lang.c (ada_lookup_simple_minsym)
1192         (ada_collect_symbol_completion_matches): Update.
1193
1194 2019-01-16  Tom Tromey  <tom@tromey.com>
1195
1196         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1197         type.  Remove no-argument constructor.
1198         <iterator::operator++>: Simplify.
1199         <begin>: Update.
1200         <end>: Use minimal_symbol_count.
1201
1202 2019-01-16  Tom Tromey  <tom@tromey.com>
1203
1204         * objfiles.h (struct objfile) <psymtabs>: New method.
1205         (class objfile_psymtabs): Remove.
1206         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1207         typedef.
1208         <range>: New method.
1209         (require_partial_symbols): Change return type.
1210         * psymtab.c (require_partial_symbols)
1211         (psym_expand_symtabs_matching): Update.
1212         * mdebugread.c (parse_partial_symbols): Update.
1213         * dbxread.c (dbx_end_psymtab): Update.
1214
1215 2019-01-15  Tom Tromey  <tom@tromey.com>
1216
1217         * symtab.c (lookup_objfile_from_block)
1218         (lookup_symbol_in_objfile_symtabs)
1219         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1220         (find_line_symtab, info_sources_command)
1221         (default_collect_symbol_completion_matches_break_on)
1222         (make_source_files_completion_list): Update.
1223         * symmisc.c (print_objfile_statistics, dump_objfile)
1224         (maintenance_print_symbols, maintenance_info_symtabs)
1225         (maintenance_check_symtabs, maintenance_info_line_tables):
1226         Update.
1227         * source.c (select_source_symtab)
1228         (forget_cached_source_info_for_objfile): Update.
1229         * objfiles.h (class objfile_compunits): Remove.
1230         (struct objfile) <compunits_range>: New typedef.
1231         (compunits): New method.
1232         * objfiles.c (objfile_relocate1): Update.
1233         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1234         * maint.c (count_symtabs_and_blocks): Update.
1235         * linespec.c (iterate_over_all_matching_symtabs): Update.
1236         * cp-support.c (add_symbol_overload_list_qualified): Update.
1237         * coffread.c (coff_symtab_read): Update.
1238         * ada-lang.c (add_nonlocal_symbols)
1239         (ada_collect_symbol_completion_matches)
1240         (ada_add_global_exceptions): Update.
1241
1242 2019-01-15  Tom Tromey  <tom@tromey.com>
1243
1244         * progspace.h (program_space) <objfiles_safe_range>: New
1245         typedef.
1246         <objfiles_safe>: New method.
1247         * objfiles.h (class all_objfiles_safe): Remove.
1248         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1249         * jit.c (jit_inferior_exit_hook): Update.
1250
1251 2019-01-17  Tom Tromey  <tom@tromey.com>
1252
1253         * progspace.h (program_space) <objfiles_range>: New typedef.
1254         <objfiles>: New method.
1255         <objfiles_head>: Rename from objfiles.
1256         (object_files): Update.
1257         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1258         * guile/scm-pretty-print.c
1259         (ppscm_find_pretty_printer_from_objfiles): Update.
1260         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1261         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1262         Update.
1263         * python/py-progspace.c (pspy_get_objfiles): Update.
1264         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1265         Update.
1266         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1267         (objfpy_lookup_objfile_by_build_id): Update.
1268         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1269         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1270         Update.
1271         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1272         (expand_symtab_containing_pc, lookup_objfile_from_block)
1273         (lookup_static_symbol, basic_lookup_transparent_type)
1274         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1275         (find_line_symtab, info_sources_command)
1276         (default_collect_symbol_completion_matches_break_on)
1277         (make_source_files_completion_list, find_main_name): Update.
1278         * symmisc.c (print_symbol_bcache_statistics)
1279         (print_objfile_statistics, maintenance_print_symbols)
1280         (maintenance_print_msymbols, maintenance_print_objfiles)
1281         (maintenance_info_symtabs, maintenance_check_symtabs)
1282         (maintenance_expand_symtabs, maintenance_info_line_tables):
1283         Update.
1284         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1285         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1286         (map_overlay_command, unmap_overlay_command)
1287         (simple_overlay_update, expand_symtabs_matching)
1288         (map_symbol_filenames): Update.
1289         * symfile-debug.c (set_debug_symfile): Update.
1290         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1291         Update.
1292         * source.c (select_source_symtab, forget_cached_source_info):
1293         Update.
1294         * solib.c (solib_read_symbols): Update.
1295         * solib-spu.c (append_ocl_sos): Update.
1296         * psymtab.c (maintenance_print_psymbols)
1297         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1298         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1299         * printcmd.c (info_symbol_command): Update.
1300         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1301         Update.
1302         * objfiles.h (class all_objfiles): Remove.
1303         * objfiles.c (have_partial_symbols, have_full_symbols)
1304         (have_minimal_symbols, qsort_cmp, update_section_map)
1305         (shared_objfile_contains_address_p)
1306         (default_iterate_over_objfiles_in_search_order): Update.
1307         * objc-lang.c (info_selectors_command, info_classes_command)
1308         (find_methods): Update.
1309         * minsyms.c (find_solib_trampoline_target): Update.
1310         * maint.c (maintenance_info_sections)
1311         (maintenance_translate_address, count_symtabs_and_blocks):
1312         Update.
1313         * main.c (captured_main_1): Update.
1314         * linux-thread-db.c (try_thread_db_load_from_pdir)
1315         (has_libpthread): Update.
1316         * linespec.c (iterate_over_all_matching_symtabs)
1317         (search_minsyms_for_name): Update.
1318         * jit.c (jit_find_objf_with_entry_addr): Update.
1319         * hppa-tdep.c (find_unwind_entry)
1320         (hppa_lookup_stub_minimal_symbol): Update.
1321         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1322         Update.
1323         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1324         (elf_gnu_ifunc_resolve_by_got): Update.
1325         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1326         * dwarf-index-write.c (save_gdb_index_command): Update.
1327         * cp-support.c (add_symbol_overload_list_qualified): Update.
1328         * breakpoint.c (create_overlay_event_breakpoint)
1329         (create_longjmp_master_breakpoint)
1330         (create_std_terminate_master_breakpoint)
1331         (create_exception_master_breakpoint): Update.
1332         * blockframe.c (find_pc_partial_function): Update.
1333         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1334         (ada_collect_symbol_completion_matches)
1335         (ada_add_global_exceptions): Update.
1336
1337 2019-01-17  Tom Tromey  <tom@tromey.com>
1338
1339         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1340         declare VEC.
1341         (solib_target_parse_libraries): Change return type.
1342         (library_list_start_segment, library_list_start_section)
1343         (library_list_end_library, library_list_start_library); Update.
1344         (solib_target_free_library_list): Remove.
1345         (solib_target_parse_libraries): Remove cleanup.  Change return
1346         type.
1347         (solib_target_current_sos): Update.
1348
1349 2019-01-17  Tom Tromey  <tromey@bapiya>
1350
1351         * valprint.c: Replace "the the" with "the".
1352         * symtab.c: Replace "the the" with "the".
1353         * solib.c: Replace "the the" with "the".
1354         * solib-dsbt.c: Replace "the the" with "the".
1355         * linespec.c: Replace "the the" with "the".
1356         * dwarf2loc.h: Replace "the the" with "the".
1357         * amd64-windows-tdep.c: Replace "the the" with "the".
1358         * aarch64-tdep.c: Replace "the the" with "the".
1359
1360 2019-01-16  Keith Seitz  <keiths@redhat.com>
1361
1362         PR gdb/23773
1363         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1364         <builder>: Rename to ..
1365         <m_builder>: ... this and make private.
1366         (dwarf2_cu::get_builder): New method.  Change all users of
1367         `builder' to use this method.
1368         (dwarf2_start_symtab): Move to ...
1369         (dwarf2_cu::start_symtab): ... here.  Update all callers
1370         (setup_type_unit_groups): Move to ...
1371         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1372         callers.
1373         (dwarf2_cu::reset_builder): New method.
1374         (process_full_compunit, process_full_type_unit): Use
1375         dwarf2_cu::reset_builder.
1376         (follow_die_offset): Record the ancestor CU if it is different
1377         from the followed DIE's CU.
1378         (follow_die_sig_1): Likewise.
1379
1380 2019-01-15  Tom Tromey  <tom@tromey.com>
1381
1382         * remote.c (class remote_state) <buf>: Now a char_vector.
1383         <buf_size>: Remove.
1384         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1385         parameter.
1386         (remote_target::getpkt_or_notif_sane_1)
1387         (remote_target::getpkt_sane)
1388         (remote_target::getpkt_or_notif_sane): Likewise.
1389         (class remote_target) <putpkt>: New overload.
1390         (remote_target::read_frame): Change type of "buf_p".  Remove
1391         sizeof_p parameter.
1392         (packet_ok): New overload.
1393         (packet_check_result): New overload.
1394         Update all uses.
1395
1396 2019-01-14  Tom Tromey  <tom@tromey.com>
1397
1398         * remote-notif.c (handle_notification, remote_notif_ack)
1399         (remote_notif_parse): Make "buf" const.
1400         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1401         const.
1402         (remote_notif_parse, remote_notif_ack, handle_notification):
1403         Likewise.
1404         * remote.c (remote_notif_stop_parse): Make "buf" const.
1405         (remote_target::remote_parse_stop_reply): Make "buf" const.
1406         (remote_notif_stop_ack): Make "buf" const.
1407
1408 2019-01-14  Tom Tromey  <tom@tromey.com>
1409
1410         * remote.c (remote_console_output): Make parameter const.
1411
1412 2019-01-14  Tom Tromey  <tom@tromey.com>
1413
1414         * target-debug.h (target_debug_print_signals): Constify.
1415         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1416         * procfs.c (procfs_target::pass_signals): Update.
1417         * linux-nat.c (linux_nat_target::pass_signals): Update.
1418         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1419         * target-delegates.c: Rebuild.
1420         * remote.c (remote_target::program_signals): Update.
1421         (remote_target::pass_signals): Update.
1422         * target.c (target_pass_signals): Constify argument.
1423         (target_program_signals): Likewise.
1424         * target.h (struct target_ops) <pass_signals, program_signals>:
1425         Constify argument.
1426         (target_pass_signals, target_program_signals): Constify argument.
1427
1428 2019-01-14  Tom Tromey  <tom@tromey.com>
1429
1430         PR tui/28819:
1431         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1432
1433 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1434
1435         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1436         field.
1437         * rs6000-tdep.c: Include reggroups.h.
1438         (IS_V_ALIAS_PSEUDOREG): Define.
1439         (rs6000_register_name): Return names for the "vX" aliases.
1440         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1441         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1442         aliases.  Call default_register_reggroup_p for all other
1443         pseudo-registers.
1444         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1445         New functions.
1446         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1447         Handle "vX" aliases.
1448         (v_alias_pseudo_register_collect): New function.
1449         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1450         (rs6000_gdbarch_init): Initialize "vX" aliases as
1451         pseudo-registers.  Restore registration of
1452         rs6000_pseudo_register_reggroup_p with
1453         set_tdesc_pseudo_register_reggroup_p.
1454
1455 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1456
1457         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1458         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1459         set_gdbarch_num_pseudo_regs.
1460
1461 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1462
1463         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1464         Remove arg prefixname, add do_set and do_show.
1465         Add member functions set_list and show_list.
1466         * cli/cli-style.c (class cli_style_option): Update accordingly.
1467         (style_set_list): Move to file scope.
1468         (style_show_list): Likewise.
1469         (set_style): Call help_list.
1470         (show_style): Call cmd_show_list.
1471         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1472         Update to use the new macro.
1473
1474 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1475
1476         * ada-lang.c (_initialize_ada_language): Expand the help text
1477         for the "catch exception" command.
1478
1479 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1480
1481         * symtab.c (matching_obj_sections): Initialize obj,
1482         declare it closer to its usage.
1483
1484 2019-01-10  Tom Tromey  <tom@tromey.com>
1485
1486         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1487         (basic_inf_threads_range): Remove.
1488         (inf_threads_range, inf_non_exited_threads_range)
1489         (safe_inf_threads_range): Use next_adapter.
1490
1491 2019-01-10  Keith Seitz  <keiths@redhat.com>
1492
1493         PR gdb/23712
1494         PR symtab/23010
1495         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1496         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1497
1498 2019-01-10  Keith Seitz  <keiths@redhat.com>
1499
1500         PR gdb/23712
1501         PR symtab/23010
1502         * dictionary.c (pending_to_vector): Remove.
1503         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1504         Remove _1 suffix, replacing functions of the same name.  Update
1505         all callers.
1506         (dict_create_hashed, dict_create_hashed_expandable)
1507         (dict_create_linear, dict_create_linear_expandable, dict_free)
1508         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1509         Make functions static.
1510
1511 2019-01-10  Keith Seitz  <keiths@redhat.com>
1512
1513         PR gdb/23712
1514         PR symtab/23010
1515         * dictionary.h (struct dictionary): Replace declaration with
1516         multidictionary.
1517         (dict_create_hashed, dict_create_hashed_expandable)
1518         (dict_create_linear, dict_create_linear_expandable)
1519         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1520         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1521         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1522         taking multidictionary argument.
1523         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1524         * block.h (struct block) <dict>: Change to multidictionary
1525         and rename `multidict'.
1526         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1527         symmisc.c: Update all dictionary references to multidictionary.
1528
1529 2019-01-10  Keith Seitz  <keiths@redhat.com>
1530
1531         PR gdb/23712
1532         PR symtab/23010
1533         * dictionary.c: Include unordered_map.
1534         (pending_to_vector): New function.
1535         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1536         Rewrite the non-"_1" functions to take vector instead
1537         of linked list.
1538         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1539         "new" _1 versions of the same name.
1540         (multidictionary): Define.
1541         (std::hash<enum language): New definition.
1542         (collate_pending_symbols_by_language, mdict_create_hashed)
1543         (mdict_create_hashed_expandable, mdict_create_linear)
1544         (mdict_create_linear_expandable, mdict_free)
1545         (find_language_dictionary, create_new_language_dictionary)
1546         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1547         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1548         (mdict_size, mdict_empty): New functions.
1549         * dictionary.h (mdict_iterator): Define.
1550
1551 2019-01-10  Pedro Alves  <palves@redhat.com>
1552
1553         * breakpoint.c (read_uploaded_action)
1554         (create_tracepoint_from_upload): Adjust to use
1555         gdb::unique_xmalloc_ptr.
1556         * ctf.c (ctf_write_uploaded_tp):
1557         (SET_ARRAY_FIELD): Use emplace_back.
1558         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1559         * tracefile-tfile.c (tfile_write_uploaded_tp):
1560         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1561         gdb::unique_xmalloc_ptr.
1562         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1563         at_string, cond_string, cmd_strings>: Replace char pointers
1564         with gdb::unique_xmalloc_ptr.
1565
1566 2019-01-10  Pedro Alves  <palves@redhat.com>
1567
1568         * solib-target.c (library_list_start_library): Don't xstrdup name.
1569
1570 2019-01-10  Pedro Alves  <palves@redhat.com>
1571
1572         * mdebugread.c (parse_partial_symbols): Use
1573         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1574
1575 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * linux-fork.c (scoped_switch_fork_info)
1578         <~scoped_switch_fork_info>: Fix incorrect variable name.
1579
1580 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * linux-fork.c (scoped_switch_fork_info)
1583         <scoped_switch_fork_info>: Make explicit.
1584         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1585
1586 2019-01-10  Tom Tromey  <tom@tromey.com>
1587
1588         * objfiles.h (objfile::reset_psymtabs): Update.
1589         * objfiles.c (objfile::objfile): Update.
1590         * psymtab.h (psymtab_storage::obstack): Update.
1591         (psymtab_storage::m_obstack): Use gdb::optional.
1592         (class psymtab_storage): Update comment.  Remove objfile
1593         parameter.
1594         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1595
1596 2019-01-10  Tom Tromey  <tom@tromey.com>
1597
1598         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1599         <free_psymtabs>: Now private.
1600         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1601         (allocate_psymtab): Use new method.
1602
1603 2019-01-10  Tom Tromey  <tom@tromey.com>
1604
1605         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1606         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1607         * mdebugread.c (parse_partial_symbols): Use
1608         allocate_dependencies.
1609         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1610         allocate_dependencies.
1611         (process_psymtab_comp_unit_reader)
1612         (build_type_psymtab_dependencies): Likewise.
1613         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1614
1615 2019-01-10  Tom Tromey  <tom@tromey.com>
1616
1617         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1618         PSYMBOL_SET_LANGUAGE.
1619         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1620
1621 2019-01-10  Tom Tromey  <tom@tromey.com>
1622
1623         * psymtab.h (psymtab_storage::obstack): New method.
1624         <m_obstack>: Rename from obstack; now private.
1625         * psymtab.c (psymtab_storage): Update.
1626         * dwarf2read.c (create_addrmap_from_index)
1627         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1628         Update.
1629
1630 2019-01-10  Tom Tromey  <tom@tromey.com>
1631
1632         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1633         * objfiles.h (objfile::reset_psymtabs): New method.
1634
1635 2019-01-10  Tom Tromey  <tom@tromey.com>
1636
1637         * symmisc.c (print_symbol_bcache_statistics): Update.
1638         (print_objfile_statistics): Update.
1639         * symfile.c (reread_symbols): Update.
1640         * psymtab.h (class psymtab_storage): New.
1641         * psymtab.c (psymtab_storage): New constructor.
1642         (~psymtab_storage): New destructor.
1643         (require_partial_symbols): Update.
1644         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1645         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1646         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1647         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1648         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1649         (start_psymtab_common, end_psymtab_common)
1650         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1651         (allocate_psymtab): Update.
1652         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1653         Update.
1654         (dump_psymtab_addrmap, maintenance_print_psymbols)
1655         (maintenance_check_psymtabs): Update.
1656         (class objfile_psymtabs): Move to objfiles.h.
1657         * psympriv.h (discard_psymtab): Now inline.
1658         (psymtab_discarder::psymtab_discarder): Update.
1659         (psymtab_discarder::~psymtab_discarder): Update.
1660         (ALL_OBJFILE_PSYMTABS): Rewrite.
1661         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1662         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1663         Remove fields.
1664         <partial_symtabs>: New field.
1665         (class objfile_psymtabs): Move from psymtab.h.  Update.
1666         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1667         psymbol_cache.
1668         (objfile::~objfile): Don't destroy psymbol_cache.
1669         * mdebugread.c (parse_partial_symbols): Update.
1670         * dwarf2read.c (create_addrmap_from_index)
1671         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1672         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1673         (add_partial_subprogram, dwarf2_ranges_read): Update.
1674         * dwarf-index-write.c (write_address_map)
1675         (write_one_signatured_type, recursively_write_psymbols)
1676         (class debug_names, class debug_names, write_psymtabs_to_index):
1677         Update.
1678
1679 2019-01-10  Tom Tromey  <tom@tromey.com>
1680
1681         * symtab.h (SYMBOL_SET_NAMES): Update.
1682         (symbol_set_names): Update.
1683         (MSYMBOL_SET_NAMES): Update.
1684         * symtab.c (symbol_set_names): Change argument to be an
1685         objfile_per_bfd_storage.
1686         * psymtab.c (add_psymbol_to_bcache): Update.
1687         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1688
1689 2019-01-10  Tom Tromey  <tom@tromey.com>
1690
1691         * symtab.c (create_demangled_names_hash): Change argument to be an
1692         objfile_per_bfd_storage.
1693         (symbol_set_names): Update.
1694
1695 2019-01-10  Tom Tromey  <tom@tromey.com>
1696
1697         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1698         init_psymbol_list.
1699         * psymtab.c (init_psymbol_list): Do nothing if already called.
1700         * psympriv.h (init_psymbol_list): Add comment.
1701         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1702         init_psymbol_list.
1703         * dbxread.c (dbx_symfile_read): Unconditionally call
1704         init_psymbol_list.
1705
1706 2019-01-10  Tom Tromey  <tom@tromey.com>
1707
1708         * xcoffread.c (scan_xcoff_symtab): Update.
1709         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1710         "where".
1711         * mdebugread.c (parse_partial_symbols)
1712         (handle_psymbol_enumerators): Update.
1713         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1714         * dbxread.c (read_dbx_symtab): Update.
1715         * psympriv.h (psymbol_placement): New enum.
1716         (add_psymbol_to_list): Update.
1717
1718 2019-01-10  Tom Tromey  <tom@tromey.com>
1719
1720         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1721         static_psymbols parameters.
1722         (scan_xcoff_symtab): Update.
1723         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1724         static_psymbols parameters.
1725         * psympriv.h (start_psymtab_common): Update.
1726         * mdebugread.c (parse_partial_symbols): Update.
1727         * dwarf2read.c (create_partial_symtab): Update.
1728         * dbxread.c (read_dbx_symtab): Update.
1729         (start_psymtab): Remove global_psymbols and static_psymbols
1730         parameters.
1731
1732 2019-01-10  Tom Tromey  <tom@tromey.com>
1733
1734         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1735         * psymtab.c (allocate_psymtab): Add comment.
1736         * psympriv.h (allocate_psymtab): Add comment.
1737         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1738         initializations.
1739         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1740
1741 2019-01-10  Tom Tromey  <tom@tromey.com>
1742
1743         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1744         Don't declare.
1745         * mipsread.c: Include mdebugread.h.
1746         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1747         Declare.
1748         * elfread.c: Include mdebugread.h.
1749
1750 2019-01-09  Tom Tromey  <tom@tromey.com>
1751
1752         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1753         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1754         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1755         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1756         (psym_lookup_symbol, psym_find_last_source_symtab)
1757         (psym_forget_cached_source_info, psym_print_stats)
1758         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1759         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1760         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1761         (psym_find_compunit_symtab_by_address)
1762         (maintenance_print_psymbols, maintenance_info_psymtabs)
1763         (maintenance_check_psymtabs): Use ranged for.
1764         * psymtab.h (class objfile_psymtabs): New.
1765         (require_partial_symbols): Return objfile_psymtabs.
1766         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1767
1768 2019-01-09  Tom Tromey  <tom@tromey.com>
1769
1770         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1771         (find_pc_mapped_section, list_overlays_command)
1772         (map_overlay_command, unmap_overlay_command)
1773         (simple_overlay_update): Use all_objfiles.
1774         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1775         * printcmd.c (info_symbol_command): Use all_objfiles.
1776         * objfiles.h (ALL_OBJSECTIONS): Remove.
1777         * maint.c (maintenance_translate_address): Use all_objfiles.
1778         * gcore.c (gcore_create_callback): Use all_objfiles.
1779         (objfile_find_memory_regions): Likewise.
1780
1781 2019-01-09  Tom Tromey  <tom@tromey.com>
1782
1783         * symtab.c (find_line_symtab, info_sources_command)
1784         (make_source_files_completion_list): Use objfile_compunits.
1785         * source.c (select_source_symtab): Use objfile_compunits.
1786         * objfiles.h (struct objfile): Update comment.
1787         (ALL_OBJFILES): Remove.
1788         (ALL_FILETABS): Remove.
1789         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1790         objfile_compunits.
1791
1792 2019-01-09  Tom Tromey  <tom@tromey.com>
1793
1794         * symmisc.c (print_objfile_statistics, dump_objfile)
1795         (maintenance_print_symbols): Use compunit_filetabs.
1796         * source.c (forget_cached_source_info_for_objfile): Use
1797         compunit_filetabs.
1798         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1799         (ALL_FILETABS): Use compunit_filetabs.
1800         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1801         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1802
1803 2019-01-09  Tom Tromey  <tom@tromey.com>
1804
1805         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1806         (compunit_filetabs): New.
1807         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1808         compunit_filetabs.
1809         (info_sources_command, make_source_files_completion_list): Remove
1810         declaration.
1811         * symmisc.c (print_objfile_statistics, dump_objfile)
1812         (maintenance_print_symbols): Remove declaration.
1813         (maintenance_info_symtabs): Use compunit_filetabs.
1814         (maintenance_info_line_tables): Likewise.
1815         * source.c (select_source_symtab): Change local variable name.
1816         (forget_cached_source_info_for_objfile): Remove declaration.
1817         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1818         * objfiles.c (objfile_relocate1): Remove declaration.
1819         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1820         declaration.
1821         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1822         * coffread.c (coff_symtab_read): Remove declaration.
1823         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1824         compunit_filetabs.
1825
1826 2019-01-09  Tom Tromey  <tom@tromey.com>
1827
1828         * symtab.c (lookup_objfile_from_block)
1829         (find_pc_sect_compunit_symtab, search_symbols)
1830         (default_collect_symbol_completion_matches_break_on): Use
1831         objfile_compunits.
1832         * objfiles.h (ALL_COMPUNITS): Remove.
1833         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1834         * cp-support.c (add_symbol_overload_list_qualified): Use
1835         objfile_compunits.
1836         * ada-lang.c (ada_collect_symbol_completion_matches)
1837         (ada_add_global_exceptions): Use objfile_compunits.
1838
1839 2019-01-09  Tom Tromey  <tom@tromey.com>
1840
1841         * source.c (select_source_symtab)
1842         (forget_cached_source_info_for_objfile): Remove declaration.
1843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1844         declaration.
1845         * maint.c (count_symtabs_and_blocks): Remove declaration.
1846         * cp-support.c (add_symbol_overload_list_qualified): Remove
1847         declaration.
1848         * coffread.c (coff_symtab_read): Remove declaration.
1849         * symtab.c (lookup_symbol_in_objfile_symtabs)
1850         (basic_lookup_transparent_type_1): Use objfile_compunits.
1851         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1852         (info_sources_command, search_symbols)
1853         (default_collect_symbol_completion_matches_break_on)
1854         (make_source_files_completion_list): Remove declaration.
1855         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1856         (ada_collect_symbol_completion_matches)
1857         (ada_add_global_exceptions): Remove declaration.
1858         * linespec.c (iterate_over_all_matching_symtabs): Use
1859         objfile_compunits.
1860         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1861         (class objfile_compunits): New.
1862         (ALL_COMPUNITS): Use objfile_compunits.
1863         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1864         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1865         objfile_compunits.
1866         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1867
1868 2019-01-09  Tom Tromey  <tom@tromey.com>
1869
1870         * symtab.c (search_symbols)
1871         (default_collect_symbol_completion_matches_break_on): Use
1872         objfile_msymbols.
1873         * ada-lang.c (ada_lookup_simple_minsym)
1874         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1875         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1876         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1877         objfile_msymbols.
1878         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1879         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1880         * objc-lang.c (find_methods): Use objfile_msymbols.
1881         (info_selectors_command, info_classes_command): Likewise.
1882         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1883         * objfiles.h (class objfile_msymbols): New.
1884         (ALL_OBJFILE_MSYMBOLS): Remove.
1885         (ALL_MSYMBOLS): Remove.
1886
1887 2019-01-09  Tom Tromey  <tom@tromey.com>
1888
1889         * common/next-iterator.h (next_adapter): Add Iterator template
1890         parameter.
1891         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1892         (class all_objfiles_safe): New.
1893         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1894         * objfiles.c (put_objfile_before): Update comment.
1895         (add_separate_debug_objfile): Likewise.
1896         (free_all_objfiles): Use all_objfiles_safe.
1897         (objfile_purge_solibs): Likewise.
1898
1899 2019-01-09  Tom Tromey  <tom@tromey.com>
1900
1901         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1902         (expand_symtab_containing_pc, lookup_static_symbol)
1903         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1904         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1905         all_objfiles.
1906         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1907         * breakpoint.c (create_overlay_event_breakpoint)
1908         (create_longjmp_master_breakpoint)
1909         (create_std_terminate_master_breakpoint)
1910         (create_exception_master_breakpoint): Use all_objfiles.
1911         * linux-thread-db.c (try_thread_db_load_from_pdir)
1912         (has_libpthread): Use all_objfiles.
1913         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1914         * linespec.c (iterate_over_all_matching_symtabs)
1915         (search_minsyms_for_name): Use all_objfiles.
1916         * maint.c (maintenance_info_sections): Use all_objfiles.
1917         * main.c (captured_main_1): Use all_objfiles.
1918         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1919         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1920         * guile/scm-pretty-print.c
1921         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1922         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1923         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1924         (maintenance_print_msymbols): Use all_objfiles.
1925         * source.c (select_source_symtab): Use all_objfiles.
1926         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1927         * symfile.c (remove_symbol_file_command)
1928         (expand_symtabs_matching, map_symbol_filenames): Use
1929         all_objfiles.
1930         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1931         all_objfiles.
1932         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1933         * objc-lang.c (find_methods): Use all_objfiles.
1934         * objfiles.c (have_partial_symbols, have_full_symbols)
1935         (have_minimal_symbols, qsort_cmp)
1936         (default_iterate_over_objfiles_in_search_order): Use
1937         all_objfiles.
1938         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1939         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1940         (maintenance_check_psymtabs): Use all_objfiles.
1941         (ALL_PSYMTABS): Remove.
1942         * compile/compile-object-run.c (do_module_cleanup): Use
1943         all_objfiles.
1944         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1945         * cp-support.c (add_symbol_overload_list_qualified): Use
1946         all_objfiles.
1947         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1948         Use all_objfiles.
1949         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1950         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1951         all_objfiles.
1952         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1953         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1954         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1955         Uses all_objfiles.
1956         * solib.c (solib_read_symbols): Use all_objfiles
1957
1958 2019-01-09  Tom Tromey  <tom@tromey.com>
1959
1960         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1961         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1962         all_objfiles.
1963         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1964         * symmisc.c (print_symbol_bcache_statistics)
1965         (print_objfile_statistics, maintenance_print_objfiles)
1966         (maintenance_info_symtabs, maintenance_check_symtabs)
1967         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1968         all_objfiles.
1969         * source.c (forget_cached_source_info): Use all_objfiles.
1970         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1971         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1972         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1973         * objfiles.c (update_section_map): Use all_objfiles.
1974         (shared_objfile_contains_address_p): Likewise.
1975         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1976         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1977
1978 2019-01-09  Tom Tromey  <tom@tromey.com>
1979
1980         * common/next-iterator.h: New file.
1981         * objfiles.h (class all_objfiles): New.
1982         (struct objfile_iterator): New.
1983
1984 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985
1986         * NEWS: Move the description of the changed "frame", "select-frame",
1987          and "info frame" commands to the Changed commands section.
1988
1989 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1990
1991         * gdbtypes.c (check_stub_method_group): Remove handling of old
1992         mangling schemes.
1993         * linespec.c (find_methods): Likewise.
1994         * stabsread.c (read_member_functions): Likewise.
1995         * valops.c (search_struct_method): Likewise.
1996         (value_struct_elt_for_reference): Likewise.
1997         * NEWS: Mention this change.
1998
1999 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2000
2001         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2002         print_source_lines.
2003         * source.c (print_source_lines_base): Update line number check.
2004         (print_source_lines): New function.
2005         (source_lines_range::source_lines_range): New function.
2006         * source.h (class source_lines_range): New class.
2007         (print_source_lines): New declaration.
2008
2009 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2010
2011         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2012
2013 2019-01-08  Tom Tromey  <tom@tromey.com>
2014             Simon Marchi  <simon.marchi@ericsson.com>
2015
2016         PR gdb/24060
2017         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2018         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2019         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2020         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2021         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2022         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2023
2024 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2025
2026         * source.c (select_source_symtab): Move header comment to
2027         declaration in source.h.
2028         (forget_cached_source_info_for_objfile): Likewise.
2029         (forget_cached_source_info): Likewise.
2030         (identify_source_line): Likewise.
2031         * source.h (identify_source_line): Move declaration from symtab.h
2032         and add comment from source.c
2033         (print_source_lines): Likewise.
2034         (forget_cached_source_info_for_objfile): Likewise.
2035         (forget_cached_source_info): Likewise.
2036         (select_source_symtab): Likewise.
2037         (enum print_source_lines_flag): Move definition from symtab.h.
2038         * symtab.h (identify_source_line): Move declaration to source.h.
2039         (print_source_lines): Likewise.
2040         (forget_cached_source_info_for_objfile): Likewise.
2041         (forget_cached_source_info): Likewise.
2042         (select_source_symtab): Likewise.
2043         (enum print_source_lines_flag): Move definition to source.h.
2044         * tui/tui-hooks.c: Add 'source.h' include.
2045
2046 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * source.c (print_source_lines_base): Handle requests to print
2049         reverse line number sequences, and guard against empty lines
2050         string.
2051
2052 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2053
2054         * source.c (print_source_lines_base): Fix skip of '\r' if next
2055         character is '\n'.
2056
2057 2019-01-06  Tom Tromey  <tom@tromey.com>
2058
2059         * c-exp.y (struct c_parse_state) <macro_original_text,
2060         expansion_obstack>: New member.
2061         (macro_original_text, expansion_obstack): Remove globals.
2062         (scan_macro_expansion, scanning_macro_expansion)
2063         (finished_macro_expansion): Update.
2064         (scan_macro_cleanup): Remove.
2065         (yylex, c_parse): Update.
2066
2067 2019-01-06  Tom Tromey  <tom@tromey.com>
2068
2069         * c-exp.y (struct c_parse_state) <strings>: New member.
2070         (operator_stoken): Update.
2071
2072 2019-01-06  Tom Tromey  <tom@tromey.com>
2073
2074         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2075         (union type_stack_elt) <typelist_val>: Now a pointer to
2076         std::vector.
2077         (type_stack_cleanup): Don't declare.
2078         (push_typelist): Update.
2079         * parse.c (pop_typelist): Return a std::vector.
2080         (push_typelist): Take a std::vector.
2081         (follow_types): Update.  Do not free args.
2082         (type_stack_cleanup): Remove.
2083         * c-exp.y (struct c_parse_state): New.
2084         (cpstate): New global.
2085         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2086         (nonempty_typelist): Update.
2087         (func_mod): Create a new vector.
2088         (c_parse): Create a c_parse_state.
2089         (check_parameter_typelist): Do not delete params.
2090         (function_method): Update.  Do not delete type_list.
2091
2092 2019-01-06  Tom Tromey  <tom@tromey.com>
2093
2094         PR gdb/28155:
2095         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2096         check_typedef.
2097         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2098         (print_return_value): Likewise.
2099
2100 2019-01-05  Tom Tromey  <tom@tromey.com>
2101
2102         * contrib/cleanup_check.py: Remove.
2103         * contrib/gcc-with-excheck: Remove.
2104         * contrib/exsummary.py: Remove.
2105         * contrib/excheck.py: Remove.
2106
2107 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2108
2109         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2110         NULL. Initialize tpprev to NULL instead of assigning it
2111         to NULL on the next statement.
2112         * windows-nat.c (windows_delete_thread): Remove check for
2113         main_thread_id before printing thread exit notifications.
2114         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2115         Remove thread ID check against main_thread_id.
2116         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2117         windows_delete_thread.
2118         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2119
2120 2019-01-04  Tom Tromey  <tom@tromey.com>
2121
2122         * compile/compile.c (_initialize_compile): Use upper case for
2123         metasyntactic variables.
2124         * symmisc.c (_initialize_symmisc): Use upper case for
2125         metasyntactic variables.
2126         * psymtab.c (_initialize_psymtab): Use upper case for
2127         metasyntactic variables.
2128         * demangle.c (demangle_command): Use upper case for metasyntactic
2129         variables.
2130         (_initialize_demangler): Likewise.
2131         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2132         variables.
2133
2134 2019-01-03  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2137
2138 2019-01-03  Tom Tromey  <tom@tromey.com>
2139
2140         * python/py-symtab.c (salpy_str): Update.
2141         (struct salpy_sal_object) <symtab>: Now a PyObject.
2142         (salpy_dealloc): Update.
2143         (del_objfile_sal): Use gdbpy_ref.
2144
2145 2019-01-03  Tom Tromey  <tom@tromey.com>
2146
2147         * python/py-type.c (convert_field): Use new_reference.  Return
2148         gdbpy_ref.
2149         (make_fielditem): Return gdbpy_ref.
2150         (typy_fields): Update.
2151         (typy_getitem): Update.
2152         (field_name): Return gdbpy_ref.  Use new_reference.
2153         (typy_iterator_iternext): Update.
2154
2155 2019-01-03  Tom Tromey  <tom@tromey.com>
2156
2157         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2158
2159 2019-01-03  Tom Tromey  <tom@tromey.com>
2160
2161         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2162         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2163         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2164         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2165         (pspy_set_type_printers): Likewise.
2166         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2167         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2168         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2169         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2170         (objfpy_set_type_printers): Likewise.
2171
2172 2019-01-03  Tom Tromey  <tom@tromey.com>
2173
2174         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2175         (gdbpy_print_stack): Use gdbpy_err_fetch.
2176         * python/python-internal.h (class gdbpy_err_fetch): New class.
2177         (class gdbpy_enter) <m_error_type, m_error_value,
2178         m_error_traceback>: Remove.
2179         <m_error>: New member.
2180         (gdbpy_exception_to_string): Don't declare.
2181         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2182         * python/py-value.c (convert_value_from_python): Use
2183         gdbpy_err_fetch.
2184         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2185         gdbpy_exception_to_string.
2186         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2187         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2188         gdbpy_err_fetch.
2189
2190 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * linux-nat.c (delete_lwp_cleanup): Delete.
2193         (struct lwp_deleter): New struct.
2194         (lwp_info_up): New typedef.
2195         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2196         lwp_info_up.
2197
2198 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * linux-fork.c (class scoped_switch_fork_info): New class.
2201         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2202
2203 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2204
2205         * valops.c (find_overload_match): Remove use of null_cleanup, and
2206         calls to do_cleanups.
2207
2208 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * compile/compile-cplus-types.c
2211         (compile_cplus_instance::decl_name): Handle changes to
2212         cp_func_name.
2213         * cp-support.c (cp_func_name): Update header comment, update
2214         return type.
2215         * cp-support.h (cp_func_name): Update return type in declaration.
2216         * valops.c (find_overload_match): Move temp_func local to top
2217         level of function and change its type.  Use temp_func to hold and
2218         delete temporary string obtained from cp_func_name.
2219
2220 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2223         gdb::char_vector, remove cleanup, and update uses of `msg`.
2224
2225 2019-01-03  Jim Wilson  <jimw@sifive.com>
2226
2227         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2228
2229 2019-01-02  Tom Tromey  <tom@tromey.com>
2230
2231         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2232         (tdesc_parse_xml): Remove cleanups.
2233         * target-descriptions.h (make_cleanup_free_target_description):
2234         Don't declare.
2235         (target_desc_deleter): New struct.
2236         (target_desc_up): New typedef.
2237         * target-descriptions.c (target_desc_deleter::operator()): Rename
2238         from free_target_description.
2239         (make_cleanup_free_target_description): Remove.
2240
2241 2019-01-02  Tom Tromey  <tom@tromey.com>
2242
2243         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2244         constructor, destructor.
2245         (linespec_parser): Remove typedef.
2246         (~linespec_parser): Rename from linespec_parser_delete.
2247         (linespec_lex_to_end, linespec_complete_label)
2248         (linespec_complete): Update.
2249         (decode_line_full): Remove cleanups.
2250         (decode_line_1): Update.
2251
2252 2019-01-02  Tom Tromey  <tom@tromey.com>
2253
2254         * python/python-internal.h (inferior_to_inferior_object): Change
2255         return type.
2256         * python/py-exitedevent.c (create_exited_event_object): Update.
2257         * python/py-inferior.c (inferior_to_inferior_object): Return
2258         gdbpy_ref.
2259         (python_new_inferior, python_inferior_deleted)
2260         (thread_to_thread_object, delete_thread_object)
2261         (build_inferior_list, gdbpy_selected_inferior): Update.
2262         * python/py-infthread.c (create_thread_object): Update.  Also fail
2263         if inferior_to_inferior_object fails.
2264
2265 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2266
2267         * inferior.h (class inferior) <displaced_step_state>: New field.
2268         * infrun.h (struct displaced_step_state): Move here from
2269         infrun.c.  Initialize fields, add constructor.
2270         <inf>: Remove field.
2271         <reset>: New method.
2272         * infrun.c (struct displaced_step_inferior_state): Move to
2273         infrun.h.
2274         (displaced_step_inferior_states): Remove.
2275         (get_displaced_stepping_state): Adust.
2276         (displaced_step_in_progress_any_inferior): Adjust.
2277         (displaced_step_in_progress_thread): Adjust.
2278         (displaced_step_in_progress): Adjust.
2279         (add_displaced_stepping_state): Remove.
2280         (get_displaced_step_closure_by_addr): Adjust.
2281         (remove_displaced_stepping_state): Remove.
2282         (infrun_inferior_exit): Call displaced_step_state.reset.
2283         (use_displaced_stepping): Don't check for NULL.
2284         (displaced_step_prepare_throw): Call
2285         get_displaced_stepping_state.
2286         (displaced_step_fixup): Don't check for NULL.
2287         (prepare_for_detach): Don't check for NULL.
2288
2289 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2290
2291         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2292          in case of call that did not complete.
2293
2294 2019-01-02  Andrey Utkin  <autkin@undo.io>
2295
2296         * symfile.c (find_separate_debug_file): Fix search of debug files for
2297         remote debuggee.
2298
2299 2019-01-02  Tom Tromey  <tom@tromey.com>
2300
2301         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2302         indentation.
2303         * python/py-frame.c (frapy_older): Remove cast.
2304         (frapy_newer): Likewise.
2305         * python/py-breakpoint.c (local_setattro): Remove cast.
2306         * python/py-arch.c (archpy_name): Remove local variable.
2307         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2308
2309 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2310
2311         * unittests/basic_string_view/element_access/char/empty.cc:
2312         Fix year range in copyright header.
2313
2314 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2317         Delete.
2318         <operator==>: Update with for removed field.
2319         <hash>: Likewise.
2320         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2321         <isa_features>: ...this.
2322         <abi_features>: New field.
2323         (riscv_isa_flen): Update comment.
2324         (riscv_abi_xlen): New declaration.
2325         (riscv_abi_flen): New declaration.
2326         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2327         isa_features.
2328         (riscv_abi_xlen): New function.
2329         (riscv_isa_flen): Update to get answer from isa_features.
2330         (riscv_abi_flen): New function.
2331         (riscv_has_fp_abi): Update to get answer from abi_features.
2332         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2333         xlen and flen.
2334         (riscv_call_info) <xlen, flen>: Update comment.
2335         (riscv_call_arg_struct): Remove invalid assertions
2336         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2337         is removed.
2338         (riscv_gdbarch_init): Gather isa features and abi features
2339         separately, ensure both match on the gdbarch when reusing an old
2340         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2341         a target with 64-bit float hardware.
2342
2343 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2344
2345         * source.c (search_command_helper): Stop reverse search
2346         when line 1 has been searched.
2347
2348 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2349
2350         * record-full.c (record_full_base_target::close): Rewrite
2351         record_full_core_buf_list free logic.
2352
2353 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2354
2355         * break-catch-syscall.c (print_one_catch_syscall): xfree
2356         the last text.
2357
2358 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2359
2360         * top.c (print_gdb_version): Update Copyright year in version
2361         message.
2362
2363 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2364
2365         Update copyright year range in all GDB files.
2366
2367 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2368
2369         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2370
2371 For older changes see ChangeLog-2018.
2372 \f
2373 Local Variables:
2374 mode: change-log
2375 left-margin: 8
2376 fill-column: 74
2377 version-control: never
2378 coding: utf-8
2379 End:
2380