Update two cleanup comments
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Tom Tromey  <tom@tromey.com>
2
3         * inferior.h (class inferior): Update comment.
4         * gdbthread.h (class thread_info): Update comment.
5
6 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7             Tom Tromey  <tom@tromey.com>
8
9         * stabsread.h (struct stab_section_list): Remove.
10         (coffstab_build_psymtabs): Update.
11         * dbxread.c (symbuf_sections): Now a std::vector.
12         (sect_idx): New global.
13         (fill_symbuf): Update.
14         (coffstab_build_psymtabs): Change type of stabsects parameter.
15         Update.
16         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
17         std::vector.
18         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
19         (coff_locate_sections): Update.
20         (coff_symfile_read): Remove cleanups.  Update.
21         (init_stringtab): Add storage parameter.
22         (free_stringtab, free_stringtab_cleanup): Remove.
23         (init_lineno): Add storage parameter.
24         (free_linetab, free_linetab_cleanup): Remove.
25
26 2019-03-06  Pedro Alves  <palves@redhat.com>
27
28         * linux-fork.c (fork_info::clobber_regs): Delete.
29         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
30         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
31         comment.  Adjust.
32         (scoped_switch_fork_info::scoped_switch_fork_info)
33         (checkpoint_command, linux_fork_context): Adjust
34         fork_save_infrun_state calls.
35
36 2019-03-06  Pedro Alves  <palves@redhat.com>
37
38         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
39         (inf_has_multiple_threads): Return 'bool' and rewrite using
40         inferior_info::threads().
41
42 2019-03-06  Pedro Alves  <palves@redhat.com>
43
44         * linux-fork.c: Include <list>.
45         (fork_list): Now a std::list instance.
46         (fork_info): Add ctor, dtor, and in-class initialize all fields.
47         (forks_exist_p, find_last_fork): Adjust.
48         (new_fork): Delete.
49         (one_fork_p): New.
50         (add_fork): Adjust.
51         (free_fork): Delete, folded into fork_info::~fork_info().
52         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
53         Adjust.
54         (init_fork_list): Delete.
55         (linux_fork_killall, linux_fork_mourn_inferior)
56         (linux_fork_detach, info_checkpoints_command): Adjust.
57         (_initialize_linux_fork): No longer call init_fork_list.
58
59 2019-03-06  Pedro Alves  <palves@redhat.com>
60
61         * linux-fork.c (new_fork): New, split out of ...
62         (add_fork): ... this.  Return void.  Move "first fork" special
63         case from here, to ...
64         (checkpoint_command): ... here.
65         * linux-linux.h (add_fork): Return void.
66
67 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
68
69         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
70
71 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
72             Chris January  <chris.january@arm.com>
73             David Lecomber  <david.lecomber@arm.com>
74
75         * f-exp.y: New token, UNOP_INTRINSIC.
76         (exp): New pattern using UNOP_INTRINSIC token.
77         (f77_keywords): Add 'abs' keyword.
78         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
79         (value_from_host_double): New function.
80         (evaluate_subexp_f): Support UNOP_ABS.
81
82 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
83
84         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
85         types.
86
87 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
88
89         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
90         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
91         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
92
93 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
94
95         * f-exp.y (convert_to_kind_type): Handle more type kinds.
96
97 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
98             Chris January  <chris.january@arm.com>
99
100         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
101         * f-exp.y: Define 'KIND' token.
102         (exp): New pattern for KIND expressions.
103         (ptype): Handle types with a kind extension.
104         (direct_abs_decl): Extend to spot kind extensions.
105         (f77_keywords): Add 'kind' to the list.
106         (push_kind_type): New function.
107         (convert_to_kind_type): New function.
108         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
109         * parse.c (operator_length_standard): Likewise.
110         * parser-defs.h (enum type_pieces): Add tp_kind.
111         * std-operator.def: Add UNOP_KIND.
112
113 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
114
115         * f-exp.y (f_parse): Set yydebug.
116
117 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
118
119         * f-lang.c (evaluate_subexp_f): New function.
120         (exp_descriptor_f): New global.
121         (f_language_defn): Use exp_descriptor_f instead of
122         exp_descriptor_standard.
123
124 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
125
126         * f-exp.y (struct token): Add comments.
127         (dot_ops): Remove uppercase versions and the end marker.
128         (f77_keywords): Likewise.
129         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
130         entries in the dot_ops array are case insensitive, and use
131         strncasecmp to compare strings.  Also some whitespace cleanup in
132         this area.  Similar for the f77_keywords array, except entries in
133         this list might be case sensitive.
134
135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
136
137         * f-exp.y (struct f77_boolean_val): Add comments.
138         (boolean_values): Remove uppercase versions, and end marker.
139         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
140         and use strncasecmp to achieve case insensitivity.  Additionally,
141         perform whitespace cleanup around this code.
142
143 2019-03-06  Tom Tromey  <tromey@adacore.com>
144
145         * remote-sim.c (gdbsim_target_open): Use result of
146         gdb_argv::release.
147
148 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
149         Dirk Schubert  <dirk.schubert@arm.com>
150         Chris January  <chris.january@arm.com>
151
152         * eval.c (evaluate_subexp_standard): Call Fortran argument
153         wrapping logic.
154         * f-lang.c (struct value): A value which can be passed into a
155         Fortran function call.
156         (fortran_argument_convert): Wrap Fortran arguments in a pointer
157         where appropriate.
158         (struct type): Value ready for a Fortran function call.
159         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
160         is needed.
161         * f-lang.h (fortran_argument_convert): Declaration.
162         (fortran_preserve_arg_pointer): Declaration.
163         * infcall.c (value_arg_coerce): Call Fortran argument logic.
164
165 2019-03-05  Tom Tromey  <tromey@adacore.com>
166
167         * python/py-prettyprint.c (print_string_repr): Remove #if.
168         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
169
170 2019-03-05  Tom Tromey  <tromey@adacore.com>
171
172         * target.c (the_dummy_target): Move later.  Change type to
173         "dummy_target".
174         (initialize_targets): Don't initialize the_dummy_target.
175
176 2019-03-05  Tom Tromey  <tromey@adacore.com>
177
178         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
179         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
180
181 2019-03-05  Tom Tromey  <tromey@adacore.com>
182
183         * windows-nat.c (windows_nat_target::attach)
184         (windows_nat_target::detach): Don't call gdb_flush.
185         * valprint.c (generic_val_print, val_print, val_print_string):
186         Don't call gdb_flush.
187         * utils.c (defaulted_query): Don't call gdb_flush.
188         * typeprint.c (print_type_scalar): Don't call gdb_flush.
189         * target.c (target_announce_detach): Don't call gdb_flush.
190         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
191         * remote.c (extended_remote_target::attach): Don't call
192         gdb_flush.
193         * procfs.c (procfs_target::detach): Don't call gdb_flush.
194         * printcmd.c (do_examine): Don't call gdb_flush.
195         (info_display_command): Don't call gdb_flush.
196         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
197         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
198         * memattr.c (info_mem_command): Don't call gdb_flush.
199         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
200         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
201         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
202         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
203         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
204         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
205         (gnu_nat_target::detach): Don't call gdb_flush.
206         * f-valprint.c (f_val_print): Don't call gdb_flush.
207         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
208         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
209         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
210         gdb_flush.
211         * c-valprint.c (c_val_print): Don't call gdb_flush.
212         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
213
214 2019-03-05  Tom Tromey  <tromey@adacore.com>
215
216         * varobj.c (update_dynamic_varobj_children): Update.
217         (install_default_visualizer): Use reset, not release.
218         * value.c (set_internalvar): Update.
219         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
220         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
221         ATTRIBUTE_UNUSED_RESULT.
222
223 2019-03-05  Tom Tromey  <tromey@adacore.com>
224
225         * remote.c (class scoped_remote_fd) <release>: Add
226         ATTRIBUTE_UNUSED_RESULT.
227
228 2019-03-05  Tom Tromey  <tromey@adacore.com>
229
230         * macroexp.c (struct macro_buffer) <release>: Add
231         ATTRIBUTE_UNUSED_RESULT.
232
233 2019-03-05  Tom Tromey  <tromey@adacore.com>
234
235         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
236         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
237         ATTRIBUTE_UNUSED_RESULT.
238
239 2019-03-05  Tom Tromey  <tromey@adacore.com>
240
241         * common/scoped_fd.h (class scoped_fd) <release>: Add
242         ATTRIBUTE_UNUSED_RESULT.
243
244 2019-03-05  Tom Tromey  <tromey@adacore.com>
245
246         * parser-defs.h (struct parser_state) <release>: Add
247         ATTRIBUTE_UNUSED_RESULT.
248
249 2019-03-05  Tom Tromey  <tromey@adacore.com>
250
251         * utils.h (class gdb_argv) <release>: Add
252         ATTRIBUTE_UNUSED_RESULT.
253         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
254
255 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
256
257         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
258         for-loop range, to avoid compiler warnings.
259
260         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
261         avoid compiler warnings about unused variables.
262
263         * NEWS: Mention end of support for native debugging on MS-Windows
264         before XP.
265
266         PR gdb/24292
267         * common/netstuff.c:
268         * gdbserver/gdbreplay.c
269         * gdbserver/remote-utils.c:
270         * ser-tcp.c:
271         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
272         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
273         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
274         'getaddrinfo' and 'freeaddrinfo' were not available before
275         Windows XP, and mingw.org's MinGW headers by default define
276         _WIN32_WINNT to 0x500.
277
278 2019-03-01  Gary Benson <gbenson@redhat.com>
279
280         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
281
282 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
283             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
284
285         PR gdb/8527
286         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
287         set_sigint_trap, clear_sigint_trap.
288
289 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
290
291         * target.c (target_detach): Clear the regcache and the
292         frame cache.
293
294 2019-02-27  Pedro Alves  <palves@redhat.com>
295
296         * utils.c (set_screen_size): When we cap the height/width sizes,
297         tweak the corresponding command variable to show "unlimited":
298
299 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
300             Pedro Alves  <palves@redhat.com>
301
302         * utils.c (set_screen_size): Reduce "infinite" rows and columns
303         before calling rl_set_screen_size.
304
305 2019-02-27  Tom Tromey  <tromey@adacore.com>
306
307         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
308         define.
309         * python/py-value.c: Remove Python 2.4 workaround.
310         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
311         workaround.
312         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
313         Python 2.4 workaround.
314         * python/python-internal.h: Remove Python 2.4 comment.
315         (Py_ssize_t): Don't define.
316         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
317         (gdb_Py_DECREF): Remove Python 2.4 workaround.
318         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
319         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
320         * python/python.c (do_start_initialization): Remove Python 2.4
321         workaround.
322         * python/py-prettyprint.c (class dummy_python_frame): Remove.
323         (print_children): Remove Python 2.4 workaround.
324         * python/py-inferior.c (buffer_procs): Remove Python 2.4
325         workaround.
326         (CHARBUFFERPROC_NAME): Remove.
327         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
328         Python 2.4 workaround.
329
330 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
331
332         * NEWS: Note minimum Python version.
333
334 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
335
336         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
337         code from these functions.  Remove corresponding ifdefs.  Use
338         Py_buffer_up instead of explicit calls to PyBuffer_Release.
339         Remove gotos and target of gotos.
340         (infpy_search_memory): Likewise.
341
342 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
343
344         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
345         (hppa_gdbarch_init): Don't register deleted functions with
346         gdbarch.
347
348 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
349
350         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
351         (h8300_unwind_sp): Delete.
352         (h8300_dummy_id): Delete.
353         (h8300_gdbarch_init): Don't register deleted functions with
354         gdbarch.
355
356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
357
358         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
359         (ft32_unwind_pc): Delete.
360         (ft32_unwind_sp): Delete.
361         (ft32_gdbarch_init): Don't register deleted functions with
362         gdbarch.
363
364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
365
366         * gdb/frv-tdep.c (frv_dummy_id): Delete.
367         (frv_unwind_pc): Delete.
368         (frv_unwind_sp): Delete.
369         (frv_gdbarch_init): Don't register deleted functions with
370         gdbarch.
371
372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
373
374         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
375         (riscv_unwind_pc): Delete.
376         (riscv_unwind_sp): Delete.
377         (riscv_gdbarch_init): Don't register deleted functions with
378         gdbarch.
379
380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
381
382         * gdb/csky-tdep.c (csky_dummy_id): Delete.
383         (csky_unwind_pc): Delete.
384         (csky_unwind_sp): Delete.
385         (csky_gdbarch_init): Don't register deleted functions with
386         gdbarch.
387
388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
389
390         * gdb/cris-tdep.c (cris_dummy_id): Delete.
391         (cris_unwind_pc): Delete.
392         (cris_unwind_sp): Delete.
393         (cris_gdbarch_init): Don't register deleted functions with
394         gdbarch.
395
396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
397
398         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
399         (bfin_unwind_pc): Delete.
400         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
401
402 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
403
404         * gdb/arm-tdep.c (arm_dummy_id): Delete.
405         (arm_unwind_pc): Delete.
406         (arm_unwind_sp): Delete.
407         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
408
409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
410
411         * gdb/arc-tdep.c (arc_dummy_id): Delete.
412         (arc_unwind_pc): Delete.
413         (arc_unwind_sp): Delete.
414         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
415
416 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
417
418         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
419         (alpha_unwind_pc): Delete.
420         (alpha_gdbarch_init): Don't register deleted functions with
421         gdbarch.
422
423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
424
425         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
426         (aarch64_unwind_pc): Delete.
427         (aarch64_unwind_sp): Delete.
428         (aarch64_gdbarch_init): Don't register deleted functions with
429         gdbarch.
430
431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
432
433         * gdbtypes.c (type_align): Don't consider static members when
434         computing structure alignment.
435
436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
437
438         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
439         return 0 for other types.
440         * arch-utils.c (default_type_align): Always return 0.
441         * gdbarch.h: Regenerate.
442         * gdbarch.sh (type_align): Extend comment.
443         * gdbtypes.c (type_align): Add additional comments, always call
444         gdbarch_type_align before applying the default rules.
445         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
446         generic code will then apply a suitable default.
447         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
448         types, return 0 for other types.
449
450 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
451
452         * NEWS: Create a new section for the next release branch.
453         Rename the section of the current branch, now that it has
454         been cut.
455
456 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
457
458         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
459         * version.in: Bump version to 8.3.50.DATE-git.
460
461 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
462
463         * aix-thread.c (ptid_cmp): Remove unused variable.
464         (get_signaled_thread): Likewise.
465         (store_regs_user_thread): Likewise.
466         (store_regs_kernel_thread): Likewise.
467         (fetch_regs_kernel_thread): Remove shadowed variable.
468
469 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
470
471         * features/riscv/32bit-cpu.xml: Add register numbers.
472         * features/riscv/32bit-fpu.c: Regenerate.
473         * features/riscv/32bit-fpu.xml: Add register numbers.
474         * features/riscv/64bit-cpu.xml: Add register numbers.
475         * features/riscv/64bit-fpu.c: Regenerate.
476         * features/riscv/64bit-fpu.xml: Add register numbers.
477
478 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
479
480         * NEWS: Mention two argument form of gdb.Value constructor.
481         * python/py-value.c (convert_buffer_and_type_to_value): New
482         function.
483         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
484         Add support for handling an optional second argument.  Call
485         convert_buffer_and_type_to_value as appropriate.
486         * python/python-internal.h (Py_buffer_deleter): New struct.
487         (Py_buffer_up): New typedef.
488
489 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
490
491         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
492         instead of releasing ownership.
493
494 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
495
496         * dwarf2read.c (open_and_init_dwp_file): Call
497         elf_numsections instead of bfd_count_sections to initialize
498         dwp_file->num_sections.
499
500 2019-02-25  Tom Tromey  <tromey@adacore.com>
501
502         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
503
504 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
505
506         * gcore.in: Add '--readnever' option when invoking GDB.
507
508 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
509
510         * MAINTAINERS: Update my email address.
511
512 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
513
514         * build-id.c (build_id_to_debug_bfd_1): New function.
515         (build_id_to_debug_bfd): Look for separate debug file in
516         sysroot.
517
518 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
519
520         * gdbarch.sh: Update the copyright year range that is placed into
521         generated files.
522
523 2019-02-22  Keith Seitz  <keiths@redhat.com>
524
525         PR symtab/23853
526         * linespec.c (create_sals_line_offset): Search for the default
527         symtab's filename instead of its fullname.
528
529 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
530
531         * NEWS: Update style defaults.
532
533 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
534
535         * main.c (captured_main_1): Disable styling in batch mode.
536
537 2019-02-20  Tom Tromey  <tom@tromey.com>
538
539         * symtab.c (symtab_symbol_info): Fix typos.
540
541 2019-02-20  Tom Tromey  <tromey@adacore.com>
542
543         * findcmd.c (_initialize_mem_search): Use upper case for
544         metasyntactic variables.
545
546 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
547
548         * aarch64-tdep.c (aarch64_add_reggroups): New function.
549         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
550
551 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
552
553         * top.h (source_file_name): Change to std::string.
554         * top.c (source_file_name): Likewise.
555         (command_line_input): Adjust.
556         * cli/cli-script.c (script_from_file): Adjust.
557
558 2019-02-19  Tom Tromey  <tromey@adacore.com>
559
560         * ravenscar-thread.c
561         (ravenscar_thread_target::update_thread_list): Don't call
562         ada_build_task_list.
563         * ada-lang.h (ada_build_task_list): Don't declare.
564         * ada-tasks.c (struct ada_tasks_inferior_data)
565         <task_list_valid_p>: Now bool.
566         (read_known_tasks, ada_task_list_changed)
567         (ada_tasks_invalidate_inferior_data): Update.
568         (read_known_tasks_array): Return bool.
569         (read_known_tasks_list): Likewise.
570         (read_known_tasks): Return void.
571         (ada_build_task_list): Now static.
572
573 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
574
575         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
576         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
577
578 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
579
580         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
581         variant for ada_tasks_pspace_data_handle and
582         ada_tasks_inferior_data_handle.
583         (ada_tasks_pspace_data_cleanup): New function.
584         (ada_tasks_inferior_data_cleanup): New function.
585
586 2019-02-17  Tom Tromey  <tom@tromey.com>
587
588         * macrotab.h (macro_source_fullname): Return a std::string.
589         * macrotab.c (macro_include, check_for_redefinition)
590         (macro_undef, macro_lookup_definition, foreach_macro)
591         (foreach_macro_in_scope): Update.
592         (macro_source_fullname): Return a std::string.
593         * macrocmd.c (show_pp_source_pos): Update.
594
595 2019-02-17  Tom Tromey  <tom@tromey.com>
596
597         * macrocmd.c (show_pp_source_pos): Style the file names.
598
599 2019-02-17  Tom Tromey  <tom@tromey.com>
600
601         PR tui/24197:
602         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
603
604 2019-02-17  Tom Tromey  <tom@tromey.com>
605
606         * ada-lang.c (user_select_syms): Use filtered printing.
607         * utils.c (wrap_style): New global.
608         (desired_style): Remove.
609         (emit_style_escape): Add stream parameter.
610         (set_output_style, reset_terminal_style, prompt_for_continue):
611         Update.
612         (flush_wrap_buffer): Only flush gdb_stdout.
613         (wrap_here): Set wrap_style.
614         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
615         treat escape sequences as a character.  Change when wrap buffer is
616         flushed.
617         (fputs_styled): Do not set the output style when the default is
618         requested.
619         * ui-style.h (struct ui_file_style) <is_default>: New method.
620         * source.c (print_source_lines_base): Emit escape sequences in one
621         piece.
622
623 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
624
625         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
626         integers and enumeration types.
627
628 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
629
630         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
631         instead of lookup_symbol_in_language
632         (do_exact_match): New function.
633         (ada_get_symbol_name_matcher): Return do_exact_match when
634         doing a verbatim match.
635
636 2019-02-15  Tom Tromey  <tromey@adacore.com>
637
638         * ravenscar-thread.c (ravenscar_thread_target::resume)
639         (ravenscar_thread_target::wait): Special case wildcard requests.
640
641 2019-02-15  Tom Tromey  <tromey@adacore.com>
642
643         * ravenscar-thread.c (base_ptid): Remove.
644         (struct ravenscar_thread_target) <close>: New method.
645         <m_base_ptid>: New member.
646         <update_inferior_ptid, active_task, task_is_currently_active,
647         runtime_initialized>: Declare methods.
648         <ravenscar_thread_target>: Add constructor.
649         (ravenscar_thread_target::task_is_currently_active)
650         (ravenscar_thread_target::update_inferior_ptid)
651         (ravenscar_runtime_initialized): Rename.  Now methods.
652         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
653         (ravenscar_thread_target::update_thread_list): Update.
654         (ravenscar_thread_target::active_task): Now method.
655         (ravenscar_thread_target::store_registers)
656         (ravenscar_thread_target::prepare_to_store)
657         (ravenscar_thread_target::prepare_to_store)
658         (ravenscar_thread_target::mourn_inferior): Update.
659         (ravenscar_inferior_created): Use "new" to create target.
660         (ravenscar_thread_target::get_ada_task_ptid): Update.
661         (_initialize_ravenscar): Don't initialize base_ptid.
662         (ravenscar_ops): Remove global.
663
664 2019-02-15  Tom Tromey  <tromey@adacore.com>
665
666         * target.h (push_target): Declare new overload.
667         * target.c (push_target): New overload, taking an rvalue reference.
668         * remote.c (remote_target::open_1): Use push_target overload.
669         * corelow.c (core_target_open): Use push_target overload.
670
671 2019-02-15  Tom Tromey  <tromey@adacore.com>
672
673         * ravenscar-thread.c (is_ravenscar_task)
674         (ravenscar_task_is_currently_active): Return bool.
675         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
676         (_initialize_ravenscar): Remove "(void)".
677         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
678         Return bool.
679
680 2019-02-15  Tom Tromey  <tromey@adacore.com>
681
682         * ravenscar-thread.c (ravenscar_runtime_initializer)
683         (has_ravenscar_runtime, get_running_thread_id)
684         (ravenscar_thread_target::resume): Fix indentation.
685
686 2019-02-15  Tom Tromey  <tromey@adacore.com>
687
688         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
689         from ravenscar_arch_ops.
690         (sparc_ravenscar_ops::fetch_registers)
691         (sparc_ravenscar_ops::store_registers): Now methods.
692         (sparc_ravenscar_prepare_to_store): Remove.
693         (sparc_ravenscar_ops): Redefine.
694         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
695         methods and destructor.  Remove members.
696         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
697         (ravenscar_thread_target::store_registers)
698         (ravenscar_thread_target::prepare_to_store): Update.
699         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
700         Remove.
701         (struct ppc_ravenscar_powerpc_ops): Derive from
702         ravenscar_arch_ops.
703         (ppc_ravenscar_powerpc_ops::fetch_registers)
704         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
705         (ppc_ravenscar_powerpc_ops): Redefine.
706         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
707         (ppc_ravenscar_e500_ops::fetch_registers)
708         (ppc_ravenscar_e500_ops::store_registers): Now methods.
709         (ppc_ravenscar_e500_ops): Redefine.
710         * aarch64-ravenscar-thread.c
711         (aarch64_ravenscar_generic_prepare_to_store): Remove.
712         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
713         (aarch64_ravenscar_fetch_registers)
714         (aarch64_ravenscar_store_registers): Now methods.
715         (aarch64_ravenscar_ops): Redefine.
716
717 2019-02-15  Tom Tromey  <tromey@adacore.com>
718
719         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
720         (ravenscar_thread_target::stopped_by_hw_breakpoint)
721         (ravenscar_thread_target::stopped_by_watchpoint)
722         (ravenscar_thread_target::stopped_data_address)
723         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
724
725 2019-02-15  Tom Tromey  <tromey@adacore.com>
726
727         * ravenscar-thread.c: Fix some typos.
728
729 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
730             Tom Tromey  <tromey@adacore.com>
731
732         * ada-lang.c (ada_exception_sal): Change addr_string to a
733         std::string.
734         (create_ada_exception_catchpoint): Update.
735
736 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
737             Tom Tromey  <tromey@adacore.com>
738
739         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
740         (bp_location_ops): Remove.
741         (base_breakpoint_allocate_location): Update.
742         (free_bp_location): Update.
743         * ada-lang.c (class ada_catchpoint_location)
744         <ada_catchpoint_location>: Remove ops parameter.
745         (ada_catchpoint_location_dtor): Remove.
746         (ada_catchpoint_location_ops): Remove.
747         (allocate_location_exception): Update.
748         * breakpoint.h (struct bp_location_ops): Remove.
749         (class bp_location) <bp_location>: Remove bp_location_ops
750         parameter.
751         <~bp_location>: Add destructor.
752         <ops>: Remove.
753
754 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
755             Pedro Alves  <palves@redhat.com>
756
757         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
758         'PATH_MAX'.
759
760 2019-02-14  David Michael  <fedora.dm0@gmail.com>
761             Samuel Thibault  <samuel.thibault@gnu.org>
762             Thomas Schwinge  <thomas@codesourcery.com>
763
764         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
765         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
766
767 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
768
769         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
770         (check_empty): Use "const char *".
771
772         * gnu-nat.c (gnu_nat_target::detach): Instead of
773         'detach_inferior (pid)' call
774         'detach_inferior (find_inferior_pid (pid))'.
775
776         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
777         'nat/fork-inferior.o'.
778         * gnu-nat.c: #include "nat/fork-inferior.h".
779
780         * gnu-nat.c (gnu_nat_target::detach): Instead of
781         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
782         * gnu-nat.h: #include "inf-child.h".
783         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
784         'i386_gnu_nat_target::fetch_registers'.
785         (gnu_store_registers): Rename/move to
786         'i386_gnu_nat_target::store_registers'.
787
788         * config/i386/nm-i386gnu.h: Don't "#include" any files.
789         * gnu-nat.h (mach_thread_info): New function.
790         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
791
792         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
793
794 2019-02-14  Frederic Konrad  <konrad@adacore.com>
795
796         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
797
798 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
799
800         * windows-nat.c (windows_add_thread): Add new parameter
801         "main_thread_p" with default value set to false.  Update
802         function documentation as well as all callers.
803         (windows_delete_thread): Likewise.
804         (fake_create_process): Update call to windows_add_thread.
805         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
806         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
807         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
808         call to windows_delete_thread.
809
810 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
811
812         * MAINTAINERS: Add Andrew Burgess as global maintainer.
813
814 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
815
816         * symfile.c (find_separate_debug_file): Use canonical path of
817         sysroot with child_path instead of gdb_sysroot if it is valid.
818
819 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
820
821         * symfile.c (find_separate_debug_file): Use child_path to
822         determine if an object file is under a sysroot.
823
824 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
825
826         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
827         unittests/child-path-selftests.c.
828         * common/pathstuff.c (child_path): New function.
829         * common/pathstuff.h (child_path): New prototype.
830         * unittests/child-path-selftests.c: New file.
831
832 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
833
834         * symfile.c (find_separate_debug_file): Look for separate debug
835         files in debug directories under the sysroot.
836
837 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
838
839         * symtab.h (struct minimal_symbol data_p): New const method.
840         (struct minimal_symbol text_p): Likewise.
841         * symtab.c (output_source_filename): Use file name style
842         to print file name.
843         (print_symbol_info): Likewise.
844         (print_msymbol_info): Use address style to print addresses.
845         Use function name style to print executable text symbols.
846         (expand_symtab_containing_pc): Use data_p.
847         (find_pc_sect_compunit_symtab): Likewise.
848
849 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
850
851         * breakpoint.c (describe_other_breakpoints): Use address style
852         to print addresses.
853         (say_where): Likewise.
854
855 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
856
857         * ada-typeprint.c (print_func_type): Print function name
858         style to print function name.
859         * c-typeprint.c (c_print_type_1): Likewise.
860
861 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
862
863         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
864         for execve.
865
866 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
867
868         * c-exp.y (direct_abs_decl): Use emplace_back to record the
869         type_stack.
870
871 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
872
873         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
874         TYPE_CODE_REF types.
875
876 2019-02-08  Jim Wilson  <jimw@sifive.com>
877
878         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
879         (riscv_linux_fregset): New.
880         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
881
882 2019-02-07  Tom Tromey  <tom@tromey.com>
883
884         * thread.c (thread_cancel_execution_command): Update.
885         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
886         methods.
887         (struct thread_fsm_ops): Remove.
888         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
889         (thread_fsm_should_stop, thread_fsm_return_value)
890         (thread_fsm_set_finished, thread_fsm_finished_p)
891         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
892         Don't declare.
893         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
894         * infrun.c (clear_proceed_status_thread)
895         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
896         (print_stop_event): Update.
897         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
898         Add constructor.
899         (step_command_fsm_ops): Remove.
900         (new_step_command_fsm): Remove.
901         (step_1): Update.
902         (step_command_fsm::should_stop): Rename from
903         step_command_fsm_should_stop.
904         (step_command_fsm::clean_up): Rename from
905         step_command_fsm_clean_up.
906         (step_command_fsm::do_async_reply_reason): Rename from
907         step_command_fsm_async_reply_reason.
908         (struct until_next_fsm): Inherit from thread_fsm.  Add
909         constructor.
910         (until_next_fsm_ops): Remove.
911         (new_until_next_fsm): Remove.
912         (until_next_fsm::should_stop): Rename from
913         until_next_fsm_should_stop.
914         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
915         (until_next_fsm::do_async_reply_reason): Rename from
916         until_next_fsm_async_reply_reason.
917         (struct finish_command_fsm): Inherit from thread_fsm.  Add
918         constructor.  Change type of breakpoint.
919         (finish_command_fsm_ops): Remove.
920         (new_finish_command_fsm): Remove.
921         (finish_command_fsm::should_stop): Rename from
922         finish_command_fsm_should_stop.
923         (finish_command_fsm::clean_up): Rename from
924         finish_command_fsm_clean_up.
925         (finish_command_fsm::return_value): Rename from
926         finish_command_fsm_return_value.
927         (finish_command_fsm::do_async_reply_reason): Rename from
928         finish_command_fsm_async_reply_reason.
929         (finish_command): Update.
930         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
931         Add constructor.
932         (call_thread_fsm_ops): Remove.
933         (call_thread_fsm::call_thread_fsm): Rename from
934         new_call_thread_fsm.
935         (call_thread_fsm::should_stop): Rename from
936         call_thread_fsm_should_stop.
937         (call_thread_fsm::should_notify_stop): Rename from
938         call_thread_fsm_should_notify_stop.
939         (run_inferior_call, call_function_by_hand_dummy): Update.
940         * cli/cli-interp.c (should_print_stop_to_console): Update.
941         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
942         Add constructor.  Change type of location_breakpoint,
943         caller_breakpoint.
944         (until_break_fsm_ops): Remove.
945         (new_until_break_fsm): Remove.
946         (until_break_fsm::should_stop): Rename from
947         until_break_fsm_should_stop.
948         (until_break_fsm::clean_up): Rename from
949         until_break_fsm_clean_up.
950         (until_break_fsm::do_async_reply_reason): Rename from
951         until_break_fsm_async_reply_reason.
952         (until_break_command): Update.
953         * thread-fsm.c: Remove.
954         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
955
956 2019-02-07  Tom Tromey  <tom@tromey.com>
957
958         * yy-remap.h: Add include guard.
959         * xtensa-tdep.h: Add include guard.
960         * xcoffread.h: Rename include guard.
961         * varobj-iter.h: Add include guard.
962         * tui/tui.h: Rename include guard.
963         * tui/tui-winsource.h: Rename include guard.
964         * tui/tui-wingeneral.h: Rename include guard.
965         * tui/tui-windata.h: Rename include guard.
966         * tui/tui-win.h: Rename include guard.
967         * tui/tui-stack.h: Rename include guard.
968         * tui/tui-source.h: Rename include guard.
969         * tui/tui-regs.h: Rename include guard.
970         * tui/tui-out.h: Rename include guard.
971         * tui/tui-layout.h: Rename include guard.
972         * tui/tui-io.h: Rename include guard.
973         * tui/tui-hooks.h: Rename include guard.
974         * tui/tui-file.h: Rename include guard.
975         * tui/tui-disasm.h: Rename include guard.
976         * tui/tui-data.h: Rename include guard.
977         * tui/tui-command.h: Rename include guard.
978         * tic6x-tdep.h: Add include guard.
979         * target/waitstatus.h: Rename include guard.
980         * target/wait.h: Rename include guard.
981         * target/target.h: Rename include guard.
982         * target/resume.h: Rename include guard.
983         * target-float.h: Rename include guard.
984         * stabsread.h: Add include guard.
985         * rs6000-tdep.h: Add include guard.
986         * riscv-fbsd-tdep.h: Add include guard.
987         * regformats/regdef.h: Rename include guard.
988         * record.h: Rename include guard.
989         * python/python.h: Rename include guard.
990         * python/python-internal.h: Rename include guard.
991         * python/py-stopevent.h: Rename include guard.
992         * python/py-ref.h: Rename include guard.
993         * python/py-record.h: Rename include guard.
994         * python/py-record-full.h: Rename include guard.
995         * python/py-record-btrace.h: Rename include guard.
996         * python/py-instruction.h: Rename include guard.
997         * python/py-events.h: Rename include guard.
998         * python/py-event.h: Rename include guard.
999         * procfs.h: Add include guard.
1000         * proc-utils.h: Add include guard.
1001         * p-lang.h: Add include guard.
1002         * or1k-tdep.h: Rename include guard.
1003         * observable.h: Rename include guard.
1004         * nto-tdep.h: Rename include guard.
1005         * nat/x86-linux.h: Rename include guard.
1006         * nat/x86-linux-dregs.h: Rename include guard.
1007         * nat/x86-gcc-cpuid.h: Add include guard.
1008         * nat/x86-dregs.h: Rename include guard.
1009         * nat/x86-cpuid.h: Rename include guard.
1010         * nat/ppc-linux.h: Rename include guard.
1011         * nat/mips-linux-watch.h: Rename include guard.
1012         * nat/linux-waitpid.h: Rename include guard.
1013         * nat/linux-ptrace.h: Rename include guard.
1014         * nat/linux-procfs.h: Rename include guard.
1015         * nat/linux-osdata.h: Rename include guard.
1016         * nat/linux-nat.h: Rename include guard.
1017         * nat/linux-namespaces.h: Rename include guard.
1018         * nat/linux-btrace.h: Rename include guard.
1019         * nat/glibc_thread_db.h: Rename include guard.
1020         * nat/gdb_thread_db.h: Rename include guard.
1021         * nat/gdb_ptrace.h: Rename include guard.
1022         * nat/fork-inferior.h: Rename include guard.
1023         * nat/amd64-linux-siginfo.h: Rename include guard.
1024         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1025         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1026         * nat/aarch64-linux.h: Rename include guard.
1027         * nat/aarch64-linux-hw-point.h: Rename include guard.
1028         * mn10300-tdep.h: Add include guard.
1029         * mips-linux-tdep.h: Add include guard.
1030         * mi/mi-parse.h: Rename include guard.
1031         * mi/mi-out.h: Rename include guard.
1032         * mi/mi-main.h: Rename include guard.
1033         * mi/mi-interp.h: Rename include guard.
1034         * mi/mi-getopt.h: Rename include guard.
1035         * mi/mi-console.h: Rename include guard.
1036         * mi/mi-common.h: Rename include guard.
1037         * mi/mi-cmds.h: Rename include guard.
1038         * mi/mi-cmd-break.h: Rename include guard.
1039         * m2-lang.h: Add include guard.
1040         * location.h: Rename include guard.
1041         * linux-record.h: Rename include guard.
1042         * linux-nat.h: Add include guard.
1043         * linux-fork.h: Add include guard.
1044         * i386-darwin-tdep.h: Rename include guard.
1045         * hppa-linux-offsets.h: Add include guard.
1046         * guile/guile.h: Rename include guard.
1047         * guile/guile-internal.h: Rename include guard.
1048         * gnu-nat.h: Rename include guard.
1049         * gdb-stabs.h: Rename include guard.
1050         * frv-tdep.h: Add include guard.
1051         * f-lang.h: Add include guard.
1052         * event-loop.h: Add include guard.
1053         * darwin-nat.h: Rename include guard.
1054         * cp-abi.h: Rename include guard.
1055         * config/sparc/nm-sol2.h: Rename include guard.
1056         * config/nm-nto.h: Rename include guard.
1057         * config/nm-linux.h: Add include guard.
1058         * config/i386/nm-i386gnu.h: Rename include guard.
1059         * config/djgpp/nl_types.h: Rename include guard.
1060         * config/djgpp/langinfo.h: Rename include guard.
1061         * compile/gcc-cp-plugin.h: Add include guard.
1062         * compile/gcc-c-plugin.h: Add include guard.
1063         * compile/compile.h: Rename include guard.
1064         * compile/compile-object-run.h: Rename include guard.
1065         * compile/compile-object-load.h: Rename include guard.
1066         * compile/compile-internal.h: Rename include guard.
1067         * compile/compile-cplus.h: Rename include guard.
1068         * compile/compile-c.h: Rename include guard.
1069         * common/xml-utils.h: Rename include guard.
1070         * common/x86-xstate.h: Rename include guard.
1071         * common/version.h: Rename include guard.
1072         * common/vec.h: Rename include guard.
1073         * common/tdesc.h: Rename include guard.
1074         * common/selftest.h: Rename include guard.
1075         * common/scoped_restore.h: Rename include guard.
1076         * common/scoped_mmap.h: Rename include guard.
1077         * common/scoped_fd.h: Rename include guard.
1078         * common/safe-iterator.h: Rename include guard.
1079         * common/run-time-clock.h: Rename include guard.
1080         * common/refcounted-object.h: Rename include guard.
1081         * common/queue.h: Rename include guard.
1082         * common/ptid.h: Rename include guard.
1083         * common/print-utils.h: Rename include guard.
1084         * common/preprocessor.h: Rename include guard.
1085         * common/pathstuff.h: Rename include guard.
1086         * common/observable.h: Rename include guard.
1087         * common/netstuff.h: Rename include guard.
1088         * common/job-control.h: Rename include guard.
1089         * common/host-defs.h: Rename include guard.
1090         * common/gdb_wait.h: Rename include guard.
1091         * common/gdb_vecs.h: Rename include guard.
1092         * common/gdb_unlinker.h: Rename include guard.
1093         * common/gdb_unique_ptr.h: Rename include guard.
1094         * common/gdb_tilde_expand.h: Rename include guard.
1095         * common/gdb_sys_time.h: Rename include guard.
1096         * common/gdb_string_view.h: Rename include guard.
1097         * common/gdb_splay_tree.h: Rename include guard.
1098         * common/gdb_setjmp.h: Rename include guard.
1099         * common/gdb_ref_ptr.h: Rename include guard.
1100         * common/gdb_optional.h: Rename include guard.
1101         * common/gdb_locale.h: Rename include guard.
1102         * common/gdb_assert.h: Rename include guard.
1103         * common/filtered-iterator.h: Rename include guard.
1104         * common/filestuff.h: Rename include guard.
1105         * common/fileio.h: Rename include guard.
1106         * common/environ.h: Rename include guard.
1107         * common/common-utils.h: Rename include guard.
1108         * common/common-types.h: Rename include guard.
1109         * common/common-regcache.h: Rename include guard.
1110         * common/common-inferior.h: Rename include guard.
1111         * common/common-gdbthread.h: Rename include guard.
1112         * common/common-exceptions.h: Rename include guard.
1113         * common/common-defs.h: Rename include guard.
1114         * common/common-debug.h: Rename include guard.
1115         * common/cleanups.h: Rename include guard.
1116         * common/buffer.h: Rename include guard.
1117         * common/btrace-common.h: Rename include guard.
1118         * common/break-common.h: Rename include guard.
1119         * cli/cli-utils.h: Rename include guard.
1120         * cli/cli-style.h: Rename include guard.
1121         * cli/cli-setshow.h: Rename include guard.
1122         * cli/cli-script.h: Rename include guard.
1123         * cli/cli-interp.h: Rename include guard.
1124         * cli/cli-decode.h: Rename include guard.
1125         * cli/cli-cmds.h: Rename include guard.
1126         * charset-list.h: Add include guard.
1127         * buildsym-legacy.h: Rename include guard.
1128         * bfin-tdep.h: Add include guard.
1129         * ax.h: Rename include guard.
1130         * arm-linux-tdep.h: Add include guard.
1131         * arm-fbsd-tdep.h: Add include guard.
1132         * arch/xtensa.h: Rename include guard.
1133         * arch/tic6x.h: Add include guard.
1134         * arch/i386.h: Add include guard.
1135         * arch/arm.h: Rename include guard.
1136         * arch/arm-linux.h: Rename include guard.
1137         * arch/arm-get-next-pcs.h: Rename include guard.
1138         * arch/amd64.h: Add include guard.
1139         * arch/aarch64-insn.h: Rename include guard.
1140         * arch-utils.h: Rename include guard.
1141         * annotate.h: Add include guard.
1142         * amd64-darwin-tdep.h: Rename include guard.
1143         * aarch64-linux-tdep.h: Add include guard.
1144         * aarch64-fbsd-tdep.h: Add include guard.
1145         * aarch32-linux-nat.h: Add include guard.
1146
1147 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1148
1149         * macrotab.c (macro_define_internal): New function that
1150         factorizes macro_define_object_internal and macro_define_function
1151         code.
1152         (macro_define_object_internal): Use macro_define_internal.
1153         (macro_define_function): Likewise.
1154
1155 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1156
1157         * macrocmd.c (extract_identifier): Return
1158         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1159         callers.
1160
1161 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1162
1163         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1164
1165 2019-02-05  Tom Tromey  <tom@tromey.com>
1166
1167         * target.c (target_stack::unpush): Move assertion earlier.
1168
1169 2019-01-30  Tom Tromey  <tom@tromey.com>
1170
1171         PR python/23615:
1172         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1173         (gdbpy_parse_and_eval): Likewise.
1174         * python/python-internal.h (gdbpy_allow_threads): New class.
1175
1176 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1177
1178         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1179         (aarch64_fbsd_fpregmap): Move earlier.
1180         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1181         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1182         instead of individual calls to trad_frame_set_reg_addr.
1183         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1184         earlier.
1185         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1186         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1187         instead of individual calls to trad_frame_set_reg_addr.
1188
1189 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1190
1191         * CONTRIBUTE: Replace contribution list with wiki link.
1192
1193 2019-01-25  Tom Tromey  <tom@tromey.com>
1194
1195         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1196
1197 2019-01-25  Tom Tromey  <tom@tromey.com>
1198
1199         * xtensa-linux-nat.c: Fix common/ includes.
1200         * xml-support.h: Fix common/ includes.
1201         * xml-support.c: Fix common/ includes.
1202         * x86-linux-nat.c: Fix common/ includes.
1203         * windows-nat.c: Fix common/ includes.
1204         * varobj.h: Fix common/ includes.
1205         * varobj.c: Fix common/ includes.
1206         * value.c: Fix common/ includes.
1207         * valops.c: Fix common/ includes.
1208         * utils.c: Fix common/ includes.
1209         * unittests/xml-utils-selftests.c: Fix common/ includes.
1210         * unittests/utils-selftests.c: Fix common/ includes.
1211         * unittests/unpack-selftests.c: Fix common/ includes.
1212         * unittests/tracepoint-selftests.c: Fix common/ includes.
1213         * unittests/style-selftests.c: Fix common/ includes.
1214         * unittests/string_view-selftests.c: Fix common/ includes.
1215         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1216         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1217         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1218         * unittests/rsp-low-selftests.c: Fix common/ includes.
1219         * unittests/parse-connection-spec-selftests.c: Fix common/
1220         includes.
1221         * unittests/optional-selftests.c: Fix common/ includes.
1222         * unittests/offset-type-selftests.c: Fix common/ includes.
1223         * unittests/observable-selftests.c: Fix common/ includes.
1224         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1225         * unittests/memrange-selftests.c: Fix common/ includes.
1226         * unittests/memory-map-selftests.c: Fix common/ includes.
1227         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1228         * unittests/function-view-selftests.c: Fix common/ includes.
1229         * unittests/environ-selftests.c: Fix common/ includes.
1230         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1231         * unittests/common-utils-selftests.c: Fix common/ includes.
1232         * unittests/cli-utils-selftests.c: Fix common/ includes.
1233         * unittests/array-view-selftests.c: Fix common/ includes.
1234         * ui-file.c: Fix common/ includes.
1235         * tui/tui-io.c: Fix common/ includes.
1236         * tracepoint.h: Fix common/ includes.
1237         * tracepoint.c: Fix common/ includes.
1238         * tracefile-tfile.c: Fix common/ includes.
1239         * top.h: Fix common/ includes.
1240         * top.c: Fix common/ includes.
1241         * thread.c: Fix common/ includes.
1242         * target/waitstatus.h: Fix common/ includes.
1243         * target/waitstatus.c: Fix common/ includes.
1244         * target.h: Fix common/ includes.
1245         * target.c: Fix common/ includes.
1246         * target-memory.c: Fix common/ includes.
1247         * target-descriptions.c: Fix common/ includes.
1248         * symtab.h: Fix common/ includes.
1249         * symfile.c: Fix common/ includes.
1250         * stap-probe.c: Fix common/ includes.
1251         * spu-linux-nat.c: Fix common/ includes.
1252         * sparc-nat.c: Fix common/ includes.
1253         * source.c: Fix common/ includes.
1254         * solib.c: Fix common/ includes.
1255         * solib-target.c: Fix common/ includes.
1256         * ser-unix.c: Fix common/ includes.
1257         * ser-tcp.c: Fix common/ includes.
1258         * ser-pipe.c: Fix common/ includes.
1259         * ser-base.c: Fix common/ includes.
1260         * selftest-arch.c: Fix common/ includes.
1261         * s12z-tdep.c: Fix common/ includes.
1262         * rust-exp.y: Fix common/ includes.
1263         * rs6000-aix-tdep.c: Fix common/ includes.
1264         * riscv-tdep.c: Fix common/ includes.
1265         * remote.c: Fix common/ includes.
1266         * remote-notif.h: Fix common/ includes.
1267         * remote-fileio.h: Fix common/ includes.
1268         * remote-fileio.c: Fix common/ includes.
1269         * regcache.h: Fix common/ includes.
1270         * regcache.c: Fix common/ includes.
1271         * record-btrace.c: Fix common/ includes.
1272         * python/python.c: Fix common/ includes.
1273         * python/py-type.c: Fix common/ includes.
1274         * python/py-inferior.c: Fix common/ includes.
1275         * progspace.h: Fix common/ includes.
1276         * producer.c: Fix common/ includes.
1277         * procfs.c: Fix common/ includes.
1278         * proc-api.c: Fix common/ includes.
1279         * printcmd.c: Fix common/ includes.
1280         * ppc-linux-nat.c: Fix common/ includes.
1281         * parser-defs.h: Fix common/ includes.
1282         * osdata.c: Fix common/ includes.
1283         * obsd-nat.c: Fix common/ includes.
1284         * nat/x86-linux.c: Fix common/ includes.
1285         * nat/x86-linux-dregs.c: Fix common/ includes.
1286         * nat/x86-dregs.h: Fix common/ includes.
1287         * nat/x86-dregs.c: Fix common/ includes.
1288         * nat/ppc-linux.c: Fix common/ includes.
1289         * nat/mips-linux-watch.h: Fix common/ includes.
1290         * nat/mips-linux-watch.c: Fix common/ includes.
1291         * nat/linux-waitpid.c: Fix common/ includes.
1292         * nat/linux-ptrace.h: Fix common/ includes.
1293         * nat/linux-ptrace.c: Fix common/ includes.
1294         * nat/linux-procfs.c: Fix common/ includes.
1295         * nat/linux-personality.c: Fix common/ includes.
1296         * nat/linux-osdata.c: Fix common/ includes.
1297         * nat/linux-namespaces.c: Fix common/ includes.
1298         * nat/linux-btrace.h: Fix common/ includes.
1299         * nat/linux-btrace.c: Fix common/ includes.
1300         * nat/fork-inferior.c: Fix common/ includes.
1301         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1302         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1303         * nat/aarch64-linux.c: Fix common/ includes.
1304         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1305         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1306         * namespace.h: Fix common/ includes.
1307         * mips-linux-tdep.c: Fix common/ includes.
1308         * minsyms.c: Fix common/ includes.
1309         * mi/mi-parse.h: Fix common/ includes.
1310         * mi/mi-main.c: Fix common/ includes.
1311         * mi/mi-cmd-env.c: Fix common/ includes.
1312         * memrange.h: Fix common/ includes.
1313         * memattr.c: Fix common/ includes.
1314         * maint.h: Fix common/ includes.
1315         * maint.c: Fix common/ includes.
1316         * main.c: Fix common/ includes.
1317         * machoread.c: Fix common/ includes.
1318         * location.c: Fix common/ includes.
1319         * linux-thread-db.c: Fix common/ includes.
1320         * linux-nat.c: Fix common/ includes.
1321         * linux-fork.c: Fix common/ includes.
1322         * inline-frame.c: Fix common/ includes.
1323         * infrun.c: Fix common/ includes.
1324         * inflow.c: Fix common/ includes.
1325         * inferior.h: Fix common/ includes.
1326         * inferior.c: Fix common/ includes.
1327         * infcmd.c: Fix common/ includes.
1328         * inf-ptrace.c: Fix common/ includes.
1329         * inf-child.c: Fix common/ includes.
1330         * ia64-linux-nat.c: Fix common/ includes.
1331         * i387-tdep.c: Fix common/ includes.
1332         * i386-tdep.c: Fix common/ includes.
1333         * i386-linux-tdep.c: Fix common/ includes.
1334         * i386-linux-nat.c: Fix common/ includes.
1335         * i386-go32-tdep.c: Fix common/ includes.
1336         * i386-fbsd-tdep.c: Fix common/ includes.
1337         * i386-fbsd-nat.c: Fix common/ includes.
1338         * guile/scm-type.c: Fix common/ includes.
1339         * guile/guile.c: Fix common/ includes.
1340         * go32-nat.c: Fix common/ includes.
1341         * gnu-nat.c: Fix common/ includes.
1342         * gdbthread.h: Fix common/ includes.
1343         * gdbarch-selftests.c: Fix common/ includes.
1344         * gdb_usleep.c: Fix common/ includes.
1345         * gdb_select.h: Fix common/ includes.
1346         * gdb_bfd.c: Fix common/ includes.
1347         * gcore.c: Fix common/ includes.
1348         * fork-child.c: Fix common/ includes.
1349         * findvar.c: Fix common/ includes.
1350         * fbsd-nat.c: Fix common/ includes.
1351         * event-top.c: Fix common/ includes.
1352         * event-loop.c: Fix common/ includes.
1353         * dwarf2read.c: Fix common/ includes.
1354         * dwarf2loc.c: Fix common/ includes.
1355         * dwarf2-frame.c: Fix common/ includes.
1356         * dwarf-index-cache.c: Fix common/ includes.
1357         * dtrace-probe.c: Fix common/ includes.
1358         * disasm-selftests.c: Fix common/ includes.
1359         * defs.h: Fix common/ includes.
1360         * csky-tdep.c: Fix common/ includes.
1361         * cp-valprint.c: Fix common/ includes.
1362         * cp-support.h: Fix common/ includes.
1363         * cp-support.c: Fix common/ includes.
1364         * corelow.c: Fix common/ includes.
1365         * completer.h: Fix common/ includes.
1366         * completer.c: Fix common/ includes.
1367         * compile/compile.c: Fix common/ includes.
1368         * compile/compile-loc2c.c: Fix common/ includes.
1369         * compile/compile-cplus-types.c: Fix common/ includes.
1370         * compile/compile-cplus-symbols.c: Fix common/ includes.
1371         * command.h: Fix common/ includes.
1372         * cli/cli-dump.c: Fix common/ includes.
1373         * cli/cli-cmds.c: Fix common/ includes.
1374         * charset.c: Fix common/ includes.
1375         * build-id.c: Fix common/ includes.
1376         * btrace.h: Fix common/ includes.
1377         * btrace.c: Fix common/ includes.
1378         * breakpoint.h: Fix common/ includes.
1379         * breakpoint.c: Fix common/ includes.
1380         * ax.h: 
1381         (enum agent_op): Fix common/ includes.
1382         * ax-general.c (struct aop_map): Fix common/ includes.
1383         * ax-gdb.c: Fix common/ includes.
1384         * auxv.c: Fix common/ includes.
1385         * auto-load.c: Fix common/ includes.
1386         * arm-tdep.c: Fix common/ includes.
1387         * arch/riscv.c: Fix common/ includes.
1388         * arch/ppc-linux-common.c: Fix common/ includes.
1389         * arch/i386.c: Fix common/ includes.
1390         * arch/arm.c: Fix common/ includes.
1391         * arch/arm-linux.c: Fix common/ includes.
1392         * arch/arm-get-next-pcs.c: Fix common/ includes.
1393         * arch/amd64.c: Fix common/ includes.
1394         * arch/aarch64.c: Fix common/ includes.
1395         * arch/aarch64-insn.c: Fix common/ includes.
1396         * arch-utils.c: Fix common/ includes.
1397         * amd64-windows-tdep.c: Fix common/ includes.
1398         * amd64-tdep.c: Fix common/ includes.
1399         * amd64-sol2-tdep.c: Fix common/ includes.
1400         * amd64-obsd-tdep.c: Fix common/ includes.
1401         * amd64-nbsd-tdep.c: Fix common/ includes.
1402         * amd64-linux-tdep.c: Fix common/ includes.
1403         * amd64-linux-nat.c: Fix common/ includes.
1404         * amd64-fbsd-tdep.c: Fix common/ includes.
1405         * amd64-fbsd-nat.c: Fix common/ includes.
1406         * amd64-dicos-tdep.c: Fix common/ includes.
1407         * amd64-darwin-tdep.c: Fix common/ includes.
1408         * agent.c: Fix common/ includes.
1409         * ada-lang.h: Fix common/ includes.
1410         * ada-lang.c: Fix common/ includes.
1411         * aarch64-tdep.c: Fix common/ includes.
1412
1413 2019-01-25  Tom Tromey  <tom@tromey.com>
1414
1415         * common/create-version.sh: Use common/version.h.
1416
1417 2019-01-24  Pedro Alves  <palves@redhat.com>
1418
1419         * infrun.c (signal_stop, signal_print, signal_program)
1420         (signal_catch, signal_pass): Now arrays instead of pointers.
1421         (update_signals_program_target, do_target_resume)
1422         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1423         * linux-nat.c (linux_nat_target::pass_signals)
1424         (linux_nat_target::create_inferior, linux_nat_target::attach):
1425         Adjust.
1426         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1427         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1428         * procfs.c (procfs_target::pass_signals): Adjust.
1429         * record-full.c (record_full_target::resume): Adjust.
1430         * remote.c (remote_target::pass_signals)
1431         (remote_target::program_signals): Adjust.
1432         * target-debug.h (target_debug_print_signals): Now takes a
1433         gdb::array_view as parameter.  Adjust.
1434         * target.h (target_ops) <pass_signals, program_signals>: Replace
1435         pointer and length parameters with gdb::array_view.
1436         (target_pass_signals, target_program_signals): Likewise.
1437         * target-delegates.c: Regenerate.
1438
1439 2019-01-24  Pedro Alves  <palves@redhat.com>
1440
1441         * common/forward-scope-exit.h
1442         (forward_scope_exit::forward_scope_exit): Pass arguments to
1443         m_bind_function directly, instead of creating a std::bind and
1444         copying that.
1445
1446 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1447
1448         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1449         for static members.
1450         (pass_in_v_vfp_candidate): Likewise.
1451
1452 2019-01-23  Tom Tromey  <tom@tromey.com>
1453             Pedro Alves  <palves@redhat.com>
1454
1455         * regcache.c (class regcache_invalidator): Remove.
1456         (regcache::raw_write): Use make_scope_exit.
1457
1458 2019-01-23  Tom Tromey  <tom@tromey.com>
1459
1460         * ui-out.h (class ui_out_emit_type): Update comment.
1461
1462 2019-01-23  Tom Tromey  <tom@tromey.com>
1463
1464         * infrun.c (fetch_inferior_event): Update comment.
1465
1466 2019-01-23  Tom Tromey  <tom@tromey.com>
1467             Pedro Alves  <palves@redhat.com>
1468
1469         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1470         parameter.
1471         (fetch_inferior_event): Use SCOPE_EXIT.
1472
1473
1474 2019-01-23  Tom Tromey  <tom@tromey.com>
1475             Pedro Alves  <palves@redhat.com>
1476
1477         * infrun.c (disable_thread_events): Delete.
1478         (stop_all_threads): Use SCOPE_EXIT.
1479
1480 2019-01-23  Tom Tromey  <tom@tromey.com>
1481             Pedro Alves  <palves@redhat.com>
1482
1483         * symfile.c: Include forward-scope-exit.h.
1484         (clear_symtab_users_cleanup): Replace forward declaration with
1485         a FORWARD_SCOPE_EXIT.
1486         (syms_from_objfile_1): Use the forward_scope_exit and
1487         gdb::optional instead of cleanup_function.
1488         (reread_symbols): Use the forward_scope_exit instead of
1489         cleanup_function.
1490         (clear_symtab_users_cleanup): Remove function.
1491
1492 2019-01-23  Tom Tromey  <tom@tromey.com>
1493             Pedro Alves  <palves@redhat.com>
1494
1495         * linux-nat.c: Include scope-exit.h.
1496         (cleanup_target_stop): Remove.
1497         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1498         SCOPE_EXIT.
1499
1500 2019-01-23  Tom Tromey  <tom@tromey.com>
1501             Pedro Alves  <palves@redhat.com>
1502
1503         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1504         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1505
1506 2019-01-23  Tom Tromey  <tom@tromey.com>
1507             Andrew Burgess  <andrew.burgess@embecosm.com>
1508             Pedro Alves  <palves@redhat.com>
1509
1510         * infrun.c (fetch_inferior_event): Use scope_exit.
1511         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1512         * top.c (execute_command): Use scope_exit.
1513         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1514         * utils.c (do_bpstat_clear_actions_cleanup)
1515         (make_bpstat_clear_actions_cleanup): Remove.
1516
1517 2019-01-23  Tom Tromey  <tom@tromey.com>
1518             Pedro Alves  <palves@redhat.com>
1519
1520         * infrun.c: Include "common/scope-exit.h"
1521         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1522         (wait_for_inferior): Use SCOPE_EXIT.
1523         (fetch_inferior_event): Use scope_exit.
1524
1525 2019-01-23  Tom Tromey  <tom@tromey.com>
1526             Pedro Alves  <palves@redhat.com>
1527
1528         * breakpoint.c (create_breakpoint): Remove cleanup.
1529
1530 2019-01-23  Tom Tromey  <tom@tromey.com>
1531             Andrew Burgess  <andrew.burgess@embecosm.com>
1532             Pedro Alves  <palves@redhat.com>
1533
1534 2019-01-23  Pedro Alves  <palves@redhat.com>
1535
1536         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1537
1538 2019-01-23  Pedro Alves  <palves@redhat.com>
1539             Andrew Burgess  <andrew.burgess@embecosm.com>
1540
1541         * gdbthread.h: Include "common/forward-scope-exit.h".
1542         (scoped_finish_thread_state): Redefine custom class in terms of
1543         forward_scope_exit.
1544
1545 2019-01-23  Pedro Alves  <palves@redhat.com>
1546             Andrew Burgess  <andrew.burgess@embecosm.com>
1547
1548         * common/forward-scope-exit.h: New file.
1549
1550 2019-01-23  Pedro Alves  <palves@redhat.com>
1551             Andrew Burgess  <andrew.burgess@embecosm.com>
1552             Tom Tromey  <tom@tromey.com>
1553
1554         * common/scope-exit.h: New file.
1555
1556 2019-01-23  Pedro Alves  <palves@redhat.com>
1557
1558         * common/preprocessor.h (ESC): Rename to ...
1559         (ESC_PARENS): ... this.
1560         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1561         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1562
1563 2019-01-23  Tom Tromey  <tom@tromey.com>
1564
1565         * language.h (class scoped_switch_to_sym_language_if_auto):
1566         Initialize m_lang in both cases.
1567
1568 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1569
1570         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1571         with XCNEW.
1572
1573 2019-01-22  Tom Tromey  <tom@tromey.com>
1574
1575         * corelow.c: Do not include sys/file.h.
1576
1577 2019-01-22  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-wingeneral.h: Include gdb_curses.h.
1580
1581 2019-01-22  Tom Tromey  <tom@tromey.com>
1582
1583         * source-cache.h (class source_cache) <get_source_lines,
1584         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1585
1586 2019-01-22  Tom Tromey  <tom@tromey.com>
1587
1588         * remote-fileio.h (struct remote_target): Declare.
1589
1590 2019-01-22  Tom Tromey  <tom@tromey.com>
1591
1592         * python/py-arch.c: Do not include py-ref.h.
1593         * python/py-bpevent.c: Do not include py-ref.h.
1594         * python/py-cmd.c: Do not include py-ref.h.
1595         * python/py-continueevent.c: Do not include py-ref.h.
1596         * python/py-event.h: Do not include py-ref.h.
1597         * python/py-evtregistry.c: Do not include py-ref.h.
1598         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1599         * python/py-frame.c: Do not include py-ref.h.
1600         * python/py-framefilter.c: Do not include py-ref.h.
1601         * python/py-function.c: Do not include py-ref.h.
1602         * python/py-infevents.c: Do not include py-ref.h.
1603         * python/py-linetable.c: Do not include py-ref.h.
1604         * python/py-objfile.c: Do not include py-ref.h.
1605         * python/py-param.c: Do not include py-ref.h.
1606         * python/py-prettyprint.c: Do not include py-ref.h.
1607         * python/py-progspace.c: Do not include py-ref.h.
1608         * python/py-symbol.c: Do not include py-ref.h.
1609         * python/py-symtab.c: Do not include py-ref.h.
1610         * python/py-type.c: Do not include py-ref.h.
1611         * python/py-unwind.c: Do not include py-ref.h.
1612         * python/py-utils.c: Do not include py-ref.h.
1613         * python/py-value.c: Do not include py-ref.h.
1614         * python/py-varobj.c: Do not include py-ref.h.
1615         * python/py-xmethods.c: Do not include py-ref.h.
1616         * python/python.c: Do not include py-ref.h.
1617         * varobj.c: Do not include py-ref.h.
1618
1619 2019-01-22  Tom Tromey  <tom@tromey.com>
1620
1621         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1622         keyword for bcache.
1623
1624 2019-01-22  Tom Tromey  <tom@tromey.com>
1625
1626         * compile/compile-cplus-types.c: Remove a comment by #include.
1627
1628 2019-01-22  Tom Tromey  <tom@tromey.com>
1629
1630         * compile/gcc-c-plugin.h: Include compile-internal.h.
1631
1632 2019-01-22  Tom Tromey  <tom@tromey.com>
1633
1634         * stabsread.c (EXTERN): Do not define.
1635         (symnum, next_symbol_text_func, processing_gcc_compilation)
1636         (within_function, global_sym_chain, global_stabs)
1637         (previous_stab_code, this_object_header_files)
1638         (n_this_object_header_files)
1639         (n_allocated_this_object_header_files): Define.
1640         * stabsread.h (EXTERN): Never define.  Use "extern".
1641
1642 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1643
1644         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1645         history_value.
1646
1647 2019-01-21  Tom Tromey  <tom@tromey.com>
1648
1649         * ui-out.c: Fix includes.
1650         * tui/tui-source.c: Fix includes.
1651         * target.c: Fix includes.
1652         * remote.c: Fix includes.
1653         * regcache.c: Fix includes.
1654         * python/py-block.c: Fix includes.
1655         * printcmd.c: Fix includes.
1656         * or1k-tdep.c: Fix includes.
1657         * mi/mi-main.c: Fix includes.
1658         * m32r-tdep.c: Fix includes.
1659         * csky-tdep.c: Fix includes.
1660         * compile/compile-cplus-types.c: Fix includes.
1661         * cli/cli-interp.c: Fix includes.
1662
1663 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1664
1665         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1666         for padding.
1667
1668 2019-01-16  Tom Tromey  <tom@tromey.com>
1669
1670         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1671         earlier.
1672         (struct objfile) <msymbols_range>: Move from top level.
1673         <msymbols>: New method.
1674         (class objfile_msymbols): Remove.
1675         * symtab.c (default_collect_symbol_completion_matches_break_on):
1676         Update.
1677         * symmisc.c (dump_msymbols): Update.
1678         * stabsread.c (scan_file_globals): Update.
1679         * objc-lang.c (info_selectors_command, info_classes_command)
1680         (find_methods): Update.
1681         * minsyms.c (find_solib_trampoline_target): Update.
1682         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1683         * coffread.c (coff_symfile_read): Update.
1684         * ada-lang.c (ada_lookup_simple_minsym)
1685         (ada_collect_symbol_completion_matches): Update.
1686
1687 2019-01-16  Tom Tromey  <tom@tromey.com>
1688
1689         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1690         type.  Remove no-argument constructor.
1691         <iterator::operator++>: Simplify.
1692         <begin>: Update.
1693         <end>: Use minimal_symbol_count.
1694
1695 2019-01-16  Tom Tromey  <tom@tromey.com>
1696
1697         * objfiles.h (struct objfile) <psymtabs>: New method.
1698         (class objfile_psymtabs): Remove.
1699         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1700         typedef.
1701         <range>: New method.
1702         (require_partial_symbols): Change return type.
1703         * psymtab.c (require_partial_symbols)
1704         (psym_expand_symtabs_matching): Update.
1705         * mdebugread.c (parse_partial_symbols): Update.
1706         * dbxread.c (dbx_end_psymtab): Update.
1707
1708 2019-01-15  Tom Tromey  <tom@tromey.com>
1709
1710         * symtab.c (lookup_objfile_from_block)
1711         (lookup_symbol_in_objfile_symtabs)
1712         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1713         (find_line_symtab, info_sources_command)
1714         (default_collect_symbol_completion_matches_break_on)
1715         (make_source_files_completion_list): Update.
1716         * symmisc.c (print_objfile_statistics, dump_objfile)
1717         (maintenance_print_symbols, maintenance_info_symtabs)
1718         (maintenance_check_symtabs, maintenance_info_line_tables):
1719         Update.
1720         * source.c (select_source_symtab)
1721         (forget_cached_source_info_for_objfile): Update.
1722         * objfiles.h (class objfile_compunits): Remove.
1723         (struct objfile) <compunits_range>: New typedef.
1724         (compunits): New method.
1725         * objfiles.c (objfile_relocate1): Update.
1726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1727         * maint.c (count_symtabs_and_blocks): Update.
1728         * linespec.c (iterate_over_all_matching_symtabs): Update.
1729         * cp-support.c (add_symbol_overload_list_qualified): Update.
1730         * coffread.c (coff_symtab_read): Update.
1731         * ada-lang.c (add_nonlocal_symbols)
1732         (ada_collect_symbol_completion_matches)
1733         (ada_add_global_exceptions): Update.
1734
1735 2019-01-15  Tom Tromey  <tom@tromey.com>
1736
1737         * progspace.h (program_space) <objfiles_safe_range>: New
1738         typedef.
1739         <objfiles_safe>: New method.
1740         * objfiles.h (class all_objfiles_safe): Remove.
1741         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1742         * jit.c (jit_inferior_exit_hook): Update.
1743
1744 2019-01-17  Tom Tromey  <tom@tromey.com>
1745
1746         * progspace.h (program_space) <objfiles_range>: New typedef.
1747         <objfiles>: New method.
1748         <objfiles_head>: Rename from objfiles.
1749         (object_files): Update.
1750         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1751         * guile/scm-pretty-print.c
1752         (ppscm_find_pretty_printer_from_objfiles): Update.
1753         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1754         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1755         Update.
1756         * python/py-progspace.c (pspy_get_objfiles): Update.
1757         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1758         Update.
1759         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1760         (objfpy_lookup_objfile_by_build_id): Update.
1761         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1762         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1763         Update.
1764         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1765         (expand_symtab_containing_pc, lookup_objfile_from_block)
1766         (lookup_static_symbol, basic_lookup_transparent_type)
1767         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1768         (find_line_symtab, info_sources_command)
1769         (default_collect_symbol_completion_matches_break_on)
1770         (make_source_files_completion_list, find_main_name): Update.
1771         * symmisc.c (print_symbol_bcache_statistics)
1772         (print_objfile_statistics, maintenance_print_symbols)
1773         (maintenance_print_msymbols, maintenance_print_objfiles)
1774         (maintenance_info_symtabs, maintenance_check_symtabs)
1775         (maintenance_expand_symtabs, maintenance_info_line_tables):
1776         Update.
1777         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1778         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1779         (map_overlay_command, unmap_overlay_command)
1780         (simple_overlay_update, expand_symtabs_matching)
1781         (map_symbol_filenames): Update.
1782         * symfile-debug.c (set_debug_symfile): Update.
1783         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1784         Update.
1785         * source.c (select_source_symtab, forget_cached_source_info):
1786         Update.
1787         * solib.c (solib_read_symbols): Update.
1788         * solib-spu.c (append_ocl_sos): Update.
1789         * psymtab.c (maintenance_print_psymbols)
1790         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1791         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1792         * printcmd.c (info_symbol_command): Update.
1793         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1794         Update.
1795         * objfiles.h (class all_objfiles): Remove.
1796         * objfiles.c (have_partial_symbols, have_full_symbols)
1797         (have_minimal_symbols, qsort_cmp, update_section_map)
1798         (shared_objfile_contains_address_p)
1799         (default_iterate_over_objfiles_in_search_order): Update.
1800         * objc-lang.c (info_selectors_command, info_classes_command)
1801         (find_methods): Update.
1802         * minsyms.c (find_solib_trampoline_target): Update.
1803         * maint.c (maintenance_info_sections)
1804         (maintenance_translate_address, count_symtabs_and_blocks):
1805         Update.
1806         * main.c (captured_main_1): Update.
1807         * linux-thread-db.c (try_thread_db_load_from_pdir)
1808         (has_libpthread): Update.
1809         * linespec.c (iterate_over_all_matching_symtabs)
1810         (search_minsyms_for_name): Update.
1811         * jit.c (jit_find_objf_with_entry_addr): Update.
1812         * hppa-tdep.c (find_unwind_entry)
1813         (hppa_lookup_stub_minimal_symbol): Update.
1814         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1815         Update.
1816         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1817         (elf_gnu_ifunc_resolve_by_got): Update.
1818         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1819         * dwarf-index-write.c (save_gdb_index_command): Update.
1820         * cp-support.c (add_symbol_overload_list_qualified): Update.
1821         * breakpoint.c (create_overlay_event_breakpoint)
1822         (create_longjmp_master_breakpoint)
1823         (create_std_terminate_master_breakpoint)
1824         (create_exception_master_breakpoint): Update.
1825         * blockframe.c (find_pc_partial_function): Update.
1826         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1827         (ada_collect_symbol_completion_matches)
1828         (ada_add_global_exceptions): Update.
1829
1830 2019-01-17  Tom Tromey  <tom@tromey.com>
1831
1832         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1833         declare VEC.
1834         (solib_target_parse_libraries): Change return type.
1835         (library_list_start_segment, library_list_start_section)
1836         (library_list_end_library, library_list_start_library); Update.
1837         (solib_target_free_library_list): Remove.
1838         (solib_target_parse_libraries): Remove cleanup.  Change return
1839         type.
1840         (solib_target_current_sos): Update.
1841
1842 2019-01-17  Tom Tromey  <tromey@bapiya>
1843
1844         * valprint.c: Replace "the the" with "the".
1845         * symtab.c: Replace "the the" with "the".
1846         * solib.c: Replace "the the" with "the".
1847         * solib-dsbt.c: Replace "the the" with "the".
1848         * linespec.c: Replace "the the" with "the".
1849         * dwarf2loc.h: Replace "the the" with "the".
1850         * amd64-windows-tdep.c: Replace "the the" with "the".
1851         * aarch64-tdep.c: Replace "the the" with "the".
1852
1853 2019-01-16  Keith Seitz  <keiths@redhat.com>
1854
1855         PR gdb/23773
1856         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1857         <builder>: Rename to ..
1858         <m_builder>: ... this and make private.
1859         (dwarf2_cu::get_builder): New method.  Change all users of
1860         `builder' to use this method.
1861         (dwarf2_start_symtab): Move to ...
1862         (dwarf2_cu::start_symtab): ... here.  Update all callers
1863         (setup_type_unit_groups): Move to ...
1864         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1865         callers.
1866         (dwarf2_cu::reset_builder): New method.
1867         (process_full_compunit, process_full_type_unit): Use
1868         dwarf2_cu::reset_builder.
1869         (follow_die_offset): Record the ancestor CU if it is different
1870         from the followed DIE's CU.
1871         (follow_die_sig_1): Likewise.
1872
1873 2019-01-15  Tom Tromey  <tom@tromey.com>
1874
1875         * remote.c (class remote_state) <buf>: Now a char_vector.
1876         <buf_size>: Remove.
1877         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1878         parameter.
1879         (remote_target::getpkt_or_notif_sane_1)
1880         (remote_target::getpkt_sane)
1881         (remote_target::getpkt_or_notif_sane): Likewise.
1882         (class remote_target) <putpkt>: New overload.
1883         (remote_target::read_frame): Change type of "buf_p".  Remove
1884         sizeof_p parameter.
1885         (packet_ok): New overload.
1886         (packet_check_result): New overload.
1887         Update all uses.
1888
1889 2019-01-14  Tom Tromey  <tom@tromey.com>
1890
1891         * remote-notif.c (handle_notification, remote_notif_ack)
1892         (remote_notif_parse): Make "buf" const.
1893         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1894         const.
1895         (remote_notif_parse, remote_notif_ack, handle_notification):
1896         Likewise.
1897         * remote.c (remote_notif_stop_parse): Make "buf" const.
1898         (remote_target::remote_parse_stop_reply): Make "buf" const.
1899         (remote_notif_stop_ack): Make "buf" const.
1900
1901 2019-01-14  Tom Tromey  <tom@tromey.com>
1902
1903         * remote.c (remote_console_output): Make parameter const.
1904
1905 2019-01-14  Tom Tromey  <tom@tromey.com>
1906
1907         * target-debug.h (target_debug_print_signals): Constify.
1908         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1909         * procfs.c (procfs_target::pass_signals): Update.
1910         * linux-nat.c (linux_nat_target::pass_signals): Update.
1911         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1912         * target-delegates.c: Rebuild.
1913         * remote.c (remote_target::program_signals): Update.
1914         (remote_target::pass_signals): Update.
1915         * target.c (target_pass_signals): Constify argument.
1916         (target_program_signals): Likewise.
1917         * target.h (struct target_ops) <pass_signals, program_signals>:
1918         Constify argument.
1919         (target_pass_signals, target_program_signals): Constify argument.
1920
1921 2019-01-14  Tom Tromey  <tom@tromey.com>
1922
1923         PR tui/28819:
1924         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1925
1926 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1927
1928         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1929         field.
1930         * rs6000-tdep.c: Include reggroups.h.
1931         (IS_V_ALIAS_PSEUDOREG): Define.
1932         (rs6000_register_name): Return names for the "vX" aliases.
1933         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1934         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1935         aliases.  Call default_register_reggroup_p for all other
1936         pseudo-registers.
1937         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1938         New functions.
1939         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1940         Handle "vX" aliases.
1941         (v_alias_pseudo_register_collect): New function.
1942         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1943         (rs6000_gdbarch_init): Initialize "vX" aliases as
1944         pseudo-registers.  Restore registration of
1945         rs6000_pseudo_register_reggroup_p with
1946         set_tdesc_pseudo_register_reggroup_p.
1947
1948 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1949
1950         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1951         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1952         set_gdbarch_num_pseudo_regs.
1953
1954 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1955
1956         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1957         Remove arg prefixname, add do_set and do_show.
1958         Add member functions set_list and show_list.
1959         * cli/cli-style.c (class cli_style_option): Update accordingly.
1960         (style_set_list): Move to file scope.
1961         (style_show_list): Likewise.
1962         (set_style): Call help_list.
1963         (show_style): Call cmd_show_list.
1964         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1965         Update to use the new macro.
1966
1967 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1968
1969         * ada-lang.c (_initialize_ada_language): Expand the help text
1970         for the "catch exception" command.
1971
1972 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1973
1974         * symtab.c (matching_obj_sections): Initialize obj,
1975         declare it closer to its usage.
1976
1977 2019-01-10  Tom Tromey  <tom@tromey.com>
1978
1979         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1980         (basic_inf_threads_range): Remove.
1981         (inf_threads_range, inf_non_exited_threads_range)
1982         (safe_inf_threads_range): Use next_adapter.
1983
1984 2019-01-10  Keith Seitz  <keiths@redhat.com>
1985
1986         PR gdb/23712
1987         PR symtab/23010
1988         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1989         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1990
1991 2019-01-10  Keith Seitz  <keiths@redhat.com>
1992
1993         PR gdb/23712
1994         PR symtab/23010
1995         * dictionary.c (pending_to_vector): Remove.
1996         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1997         Remove _1 suffix, replacing functions of the same name.  Update
1998         all callers.
1999         (dict_create_hashed, dict_create_hashed_expandable)
2000         (dict_create_linear, dict_create_linear_expandable, dict_free)
2001         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2002         Make functions static.
2003
2004 2019-01-10  Keith Seitz  <keiths@redhat.com>
2005
2006         PR gdb/23712
2007         PR symtab/23010
2008         * dictionary.h (struct dictionary): Replace declaration with
2009         multidictionary.
2010         (dict_create_hashed, dict_create_hashed_expandable)
2011         (dict_create_linear, dict_create_linear_expandable)
2012         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2013         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2014         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2015         taking multidictionary argument.
2016         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2017         * block.h (struct block) <dict>: Change to multidictionary
2018         and rename `multidict'.
2019         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2020         symmisc.c: Update all dictionary references to multidictionary.
2021
2022 2019-01-10  Keith Seitz  <keiths@redhat.com>
2023
2024         PR gdb/23712
2025         PR symtab/23010
2026         * dictionary.c: Include unordered_map.
2027         (pending_to_vector): New function.
2028         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2029         Rewrite the non-"_1" functions to take vector instead
2030         of linked list.
2031         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2032         "new" _1 versions of the same name.
2033         (multidictionary): Define.
2034         (std::hash<enum language): New definition.
2035         (collate_pending_symbols_by_language, mdict_create_hashed)
2036         (mdict_create_hashed_expandable, mdict_create_linear)
2037         (mdict_create_linear_expandable, mdict_free)
2038         (find_language_dictionary, create_new_language_dictionary)
2039         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2040         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2041         (mdict_size, mdict_empty): New functions.
2042         * dictionary.h (mdict_iterator): Define.
2043
2044 2019-01-10  Pedro Alves  <palves@redhat.com>
2045
2046         * breakpoint.c (read_uploaded_action)
2047         (create_tracepoint_from_upload): Adjust to use
2048         gdb::unique_xmalloc_ptr.
2049         * ctf.c (ctf_write_uploaded_tp):
2050         (SET_ARRAY_FIELD): Use emplace_back.
2051         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2052         * tracefile-tfile.c (tfile_write_uploaded_tp):
2053         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2054         gdb::unique_xmalloc_ptr.
2055         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2056         at_string, cond_string, cmd_strings>: Replace char pointers
2057         with gdb::unique_xmalloc_ptr.
2058
2059 2019-01-10  Pedro Alves  <palves@redhat.com>
2060
2061         * solib-target.c (library_list_start_library): Don't xstrdup name.
2062
2063 2019-01-10  Pedro Alves  <palves@redhat.com>
2064
2065         * mdebugread.c (parse_partial_symbols): Use
2066         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2067
2068 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2069
2070         * linux-fork.c (scoped_switch_fork_info)
2071         <~scoped_switch_fork_info>: Fix incorrect variable name.
2072
2073 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2074
2075         * linux-fork.c (scoped_switch_fork_info)
2076         <scoped_switch_fork_info>: Make explicit.
2077         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2078
2079 2019-01-10  Tom Tromey  <tom@tromey.com>
2080
2081         * objfiles.h (objfile::reset_psymtabs): Update.
2082         * objfiles.c (objfile::objfile): Update.
2083         * psymtab.h (psymtab_storage::obstack): Update.
2084         (psymtab_storage::m_obstack): Use gdb::optional.
2085         (class psymtab_storage): Update comment.  Remove objfile
2086         parameter.
2087         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2088
2089 2019-01-10  Tom Tromey  <tom@tromey.com>
2090
2091         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2092         <free_psymtabs>: Now private.
2093         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2094         (allocate_psymtab): Use new method.
2095
2096 2019-01-10  Tom Tromey  <tom@tromey.com>
2097
2098         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2099         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2100         * mdebugread.c (parse_partial_symbols): Use
2101         allocate_dependencies.
2102         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2103         allocate_dependencies.
2104         (process_psymtab_comp_unit_reader)
2105         (build_type_psymtab_dependencies): Likewise.
2106         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2107
2108 2019-01-10  Tom Tromey  <tom@tromey.com>
2109
2110         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2111         PSYMBOL_SET_LANGUAGE.
2112         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2113
2114 2019-01-10  Tom Tromey  <tom@tromey.com>
2115
2116         * psymtab.h (psymtab_storage::obstack): New method.
2117         <m_obstack>: Rename from obstack; now private.
2118         * psymtab.c (psymtab_storage): Update.
2119         * dwarf2read.c (create_addrmap_from_index)
2120         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2121         Update.
2122
2123 2019-01-10  Tom Tromey  <tom@tromey.com>
2124
2125         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2126         * objfiles.h (objfile::reset_psymtabs): New method.
2127
2128 2019-01-10  Tom Tromey  <tom@tromey.com>
2129
2130         * symmisc.c (print_symbol_bcache_statistics): Update.
2131         (print_objfile_statistics): Update.
2132         * symfile.c (reread_symbols): Update.
2133         * psymtab.h (class psymtab_storage): New.
2134         * psymtab.c (psymtab_storage): New constructor.
2135         (~psymtab_storage): New destructor.
2136         (require_partial_symbols): Update.
2137         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2138         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2139         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2140         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2141         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2142         (start_psymtab_common, end_psymtab_common)
2143         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2144         (allocate_psymtab): Update.
2145         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2146         Update.
2147         (dump_psymtab_addrmap, maintenance_print_psymbols)
2148         (maintenance_check_psymtabs): Update.
2149         (class objfile_psymtabs): Move to objfiles.h.
2150         * psympriv.h (discard_psymtab): Now inline.
2151         (psymtab_discarder::psymtab_discarder): Update.
2152         (psymtab_discarder::~psymtab_discarder): Update.
2153         (ALL_OBJFILE_PSYMTABS): Rewrite.
2154         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2155         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2156         Remove fields.
2157         <partial_symtabs>: New field.
2158         (class objfile_psymtabs): Move from psymtab.h.  Update.
2159         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2160         psymbol_cache.
2161         (objfile::~objfile): Don't destroy psymbol_cache.
2162         * mdebugread.c (parse_partial_symbols): Update.
2163         * dwarf2read.c (create_addrmap_from_index)
2164         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2165         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2166         (add_partial_subprogram, dwarf2_ranges_read): Update.
2167         * dwarf-index-write.c (write_address_map)
2168         (write_one_signatured_type, recursively_write_psymbols)
2169         (class debug_names, class debug_names, write_psymtabs_to_index):
2170         Update.
2171
2172 2019-01-10  Tom Tromey  <tom@tromey.com>
2173
2174         * symtab.h (SYMBOL_SET_NAMES): Update.
2175         (symbol_set_names): Update.
2176         (MSYMBOL_SET_NAMES): Update.
2177         * symtab.c (symbol_set_names): Change argument to be an
2178         objfile_per_bfd_storage.
2179         * psymtab.c (add_psymbol_to_bcache): Update.
2180         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2181
2182 2019-01-10  Tom Tromey  <tom@tromey.com>
2183
2184         * symtab.c (create_demangled_names_hash): Change argument to be an
2185         objfile_per_bfd_storage.
2186         (symbol_set_names): Update.
2187
2188 2019-01-10  Tom Tromey  <tom@tromey.com>
2189
2190         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2191         init_psymbol_list.
2192         * psymtab.c (init_psymbol_list): Do nothing if already called.
2193         * psympriv.h (init_psymbol_list): Add comment.
2194         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2195         init_psymbol_list.
2196         * dbxread.c (dbx_symfile_read): Unconditionally call
2197         init_psymbol_list.
2198
2199 2019-01-10  Tom Tromey  <tom@tromey.com>
2200
2201         * xcoffread.c (scan_xcoff_symtab): Update.
2202         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2203         "where".
2204         * mdebugread.c (parse_partial_symbols)
2205         (handle_psymbol_enumerators): Update.
2206         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2207         * dbxread.c (read_dbx_symtab): Update.
2208         * psympriv.h (psymbol_placement): New enum.
2209         (add_psymbol_to_list): Update.
2210
2211 2019-01-10  Tom Tromey  <tom@tromey.com>
2212
2213         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2214         static_psymbols parameters.
2215         (scan_xcoff_symtab): Update.
2216         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2217         static_psymbols parameters.
2218         * psympriv.h (start_psymtab_common): Update.
2219         * mdebugread.c (parse_partial_symbols): Update.
2220         * dwarf2read.c (create_partial_symtab): Update.
2221         * dbxread.c (read_dbx_symtab): Update.
2222         (start_psymtab): Remove global_psymbols and static_psymbols
2223         parameters.
2224
2225 2019-01-10  Tom Tromey  <tom@tromey.com>
2226
2227         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2228         * psymtab.c (allocate_psymtab): Add comment.
2229         * psympriv.h (allocate_psymtab): Add comment.
2230         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2231         initializations.
2232         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2233
2234 2019-01-10  Tom Tromey  <tom@tromey.com>
2235
2236         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2237         Don't declare.
2238         * mipsread.c: Include mdebugread.h.
2239         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2240         Declare.
2241         * elfread.c: Include mdebugread.h.
2242
2243 2019-01-09  Tom Tromey  <tom@tromey.com>
2244
2245         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2246         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2247         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2248         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2249         (psym_lookup_symbol, psym_find_last_source_symtab)
2250         (psym_forget_cached_source_info, psym_print_stats)
2251         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2252         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2253         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2254         (psym_find_compunit_symtab_by_address)
2255         (maintenance_print_psymbols, maintenance_info_psymtabs)
2256         (maintenance_check_psymtabs): Use ranged for.
2257         * psymtab.h (class objfile_psymtabs): New.
2258         (require_partial_symbols): Return objfile_psymtabs.
2259         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2260
2261 2019-01-09  Tom Tromey  <tom@tromey.com>
2262
2263         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2264         (find_pc_mapped_section, list_overlays_command)
2265         (map_overlay_command, unmap_overlay_command)
2266         (simple_overlay_update): Use all_objfiles.
2267         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2268         * printcmd.c (info_symbol_command): Use all_objfiles.
2269         * objfiles.h (ALL_OBJSECTIONS): Remove.
2270         * maint.c (maintenance_translate_address): Use all_objfiles.
2271         * gcore.c (gcore_create_callback): Use all_objfiles.
2272         (objfile_find_memory_regions): Likewise.
2273
2274 2019-01-09  Tom Tromey  <tom@tromey.com>
2275
2276         * symtab.c (find_line_symtab, info_sources_command)
2277         (make_source_files_completion_list): Use objfile_compunits.
2278         * source.c (select_source_symtab): Use objfile_compunits.
2279         * objfiles.h (struct objfile): Update comment.
2280         (ALL_OBJFILES): Remove.
2281         (ALL_FILETABS): Remove.
2282         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2283         objfile_compunits.
2284
2285 2019-01-09  Tom Tromey  <tom@tromey.com>
2286
2287         * symmisc.c (print_objfile_statistics, dump_objfile)
2288         (maintenance_print_symbols): Use compunit_filetabs.
2289         * source.c (forget_cached_source_info_for_objfile): Use
2290         compunit_filetabs.
2291         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2292         (ALL_FILETABS): Use compunit_filetabs.
2293         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2294         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2295
2296 2019-01-09  Tom Tromey  <tom@tromey.com>
2297
2298         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2299         (compunit_filetabs): New.
2300         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2301         compunit_filetabs.
2302         (info_sources_command, make_source_files_completion_list): Remove
2303         declaration.
2304         * symmisc.c (print_objfile_statistics, dump_objfile)
2305         (maintenance_print_symbols): Remove declaration.
2306         (maintenance_info_symtabs): Use compunit_filetabs.
2307         (maintenance_info_line_tables): Likewise.
2308         * source.c (select_source_symtab): Change local variable name.
2309         (forget_cached_source_info_for_objfile): Remove declaration.
2310         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2311         * objfiles.c (objfile_relocate1): Remove declaration.
2312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2313         declaration.
2314         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2315         * coffread.c (coff_symtab_read): Remove declaration.
2316         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2317         compunit_filetabs.
2318
2319 2019-01-09  Tom Tromey  <tom@tromey.com>
2320
2321         * symtab.c (lookup_objfile_from_block)
2322         (find_pc_sect_compunit_symtab, search_symbols)
2323         (default_collect_symbol_completion_matches_break_on): Use
2324         objfile_compunits.
2325         * objfiles.h (ALL_COMPUNITS): Remove.
2326         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2327         * cp-support.c (add_symbol_overload_list_qualified): Use
2328         objfile_compunits.
2329         * ada-lang.c (ada_collect_symbol_completion_matches)
2330         (ada_add_global_exceptions): Use objfile_compunits.
2331
2332 2019-01-09  Tom Tromey  <tom@tromey.com>
2333
2334         * source.c (select_source_symtab)
2335         (forget_cached_source_info_for_objfile): Remove declaration.
2336         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2337         declaration.
2338         * maint.c (count_symtabs_and_blocks): Remove declaration.
2339         * cp-support.c (add_symbol_overload_list_qualified): Remove
2340         declaration.
2341         * coffread.c (coff_symtab_read): Remove declaration.
2342         * symtab.c (lookup_symbol_in_objfile_symtabs)
2343         (basic_lookup_transparent_type_1): Use objfile_compunits.
2344         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2345         (info_sources_command, search_symbols)
2346         (default_collect_symbol_completion_matches_break_on)
2347         (make_source_files_completion_list): Remove declaration.
2348         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2349         (ada_collect_symbol_completion_matches)
2350         (ada_add_global_exceptions): Remove declaration.
2351         * linespec.c (iterate_over_all_matching_symtabs): Use
2352         objfile_compunits.
2353         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2354         (class objfile_compunits): New.
2355         (ALL_COMPUNITS): Use objfile_compunits.
2356         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2357         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2358         objfile_compunits.
2359         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2360
2361 2019-01-09  Tom Tromey  <tom@tromey.com>
2362
2363         * symtab.c (search_symbols)
2364         (default_collect_symbol_completion_matches_break_on): Use
2365         objfile_msymbols.
2366         * ada-lang.c (ada_lookup_simple_minsym)
2367         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2368         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2369         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2370         objfile_msymbols.
2371         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2372         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2373         * objc-lang.c (find_methods): Use objfile_msymbols.
2374         (info_selectors_command, info_classes_command): Likewise.
2375         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2376         * objfiles.h (class objfile_msymbols): New.
2377         (ALL_OBJFILE_MSYMBOLS): Remove.
2378         (ALL_MSYMBOLS): Remove.
2379
2380 2019-01-09  Tom Tromey  <tom@tromey.com>
2381
2382         * common/next-iterator.h (next_adapter): Add Iterator template
2383         parameter.
2384         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2385         (class all_objfiles_safe): New.
2386         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2387         * objfiles.c (put_objfile_before): Update comment.
2388         (add_separate_debug_objfile): Likewise.
2389         (free_all_objfiles): Use all_objfiles_safe.
2390         (objfile_purge_solibs): Likewise.
2391
2392 2019-01-09  Tom Tromey  <tom@tromey.com>
2393
2394         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2395         (expand_symtab_containing_pc, lookup_static_symbol)
2396         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2397         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2398         all_objfiles.
2399         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2400         * breakpoint.c (create_overlay_event_breakpoint)
2401         (create_longjmp_master_breakpoint)
2402         (create_std_terminate_master_breakpoint)
2403         (create_exception_master_breakpoint): Use all_objfiles.
2404         * linux-thread-db.c (try_thread_db_load_from_pdir)
2405         (has_libpthread): Use all_objfiles.
2406         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2407         * linespec.c (iterate_over_all_matching_symtabs)
2408         (search_minsyms_for_name): Use all_objfiles.
2409         * maint.c (maintenance_info_sections): Use all_objfiles.
2410         * main.c (captured_main_1): Use all_objfiles.
2411         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2412         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2413         * guile/scm-pretty-print.c
2414         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2415         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2416         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2417         (maintenance_print_msymbols): Use all_objfiles.
2418         * source.c (select_source_symtab): Use all_objfiles.
2419         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2420         * symfile.c (remove_symbol_file_command)
2421         (expand_symtabs_matching, map_symbol_filenames): Use
2422         all_objfiles.
2423         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2424         all_objfiles.
2425         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2426         * objc-lang.c (find_methods): Use all_objfiles.
2427         * objfiles.c (have_partial_symbols, have_full_symbols)
2428         (have_minimal_symbols, qsort_cmp)
2429         (default_iterate_over_objfiles_in_search_order): Use
2430         all_objfiles.
2431         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2432         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2433         (maintenance_check_psymtabs): Use all_objfiles.
2434         (ALL_PSYMTABS): Remove.
2435         * compile/compile-object-run.c (do_module_cleanup): Use
2436         all_objfiles.
2437         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2438         * cp-support.c (add_symbol_overload_list_qualified): Use
2439         all_objfiles.
2440         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2441         Use all_objfiles.
2442         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2443         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2444         all_objfiles.
2445         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2446         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2447         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2448         Uses all_objfiles.
2449         * solib.c (solib_read_symbols): Use all_objfiles
2450
2451 2019-01-09  Tom Tromey  <tom@tromey.com>
2452
2453         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2454         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2455         all_objfiles.
2456         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2457         * symmisc.c (print_symbol_bcache_statistics)
2458         (print_objfile_statistics, maintenance_print_objfiles)
2459         (maintenance_info_symtabs, maintenance_check_symtabs)
2460         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2461         all_objfiles.
2462         * source.c (forget_cached_source_info): Use all_objfiles.
2463         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2464         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2465         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2466         * objfiles.c (update_section_map): Use all_objfiles.
2467         (shared_objfile_contains_address_p): Likewise.
2468         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2469         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2470
2471 2019-01-09  Tom Tromey  <tom@tromey.com>
2472
2473         * common/next-iterator.h: New file.
2474         * objfiles.h (class all_objfiles): New.
2475         (struct objfile_iterator): New.
2476
2477 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2478
2479         * NEWS: Move the description of the changed "frame", "select-frame",
2480          and "info frame" commands to the Changed commands section.
2481
2482 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2483
2484         * gdbtypes.c (check_stub_method_group): Remove handling of old
2485         mangling schemes.
2486         * linespec.c (find_methods): Likewise.
2487         * stabsread.c (read_member_functions): Likewise.
2488         * valops.c (search_struct_method): Likewise.
2489         (value_struct_elt_for_reference): Likewise.
2490         * NEWS: Mention this change.
2491
2492 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2495         print_source_lines.
2496         * source.c (print_source_lines_base): Update line number check.
2497         (print_source_lines): New function.
2498         (source_lines_range::source_lines_range): New function.
2499         * source.h (class source_lines_range): New class.
2500         (print_source_lines): New declaration.
2501
2502 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2503
2504         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2505
2506 2019-01-08  Tom Tromey  <tom@tromey.com>
2507             Simon Marchi  <simon.marchi@ericsson.com>
2508
2509         PR gdb/24060
2510         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2511         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2512         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2513         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2514         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2515         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2516
2517 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2518
2519         * source.c (select_source_symtab): Move header comment to
2520         declaration in source.h.
2521         (forget_cached_source_info_for_objfile): Likewise.
2522         (forget_cached_source_info): Likewise.
2523         (identify_source_line): Likewise.
2524         * source.h (identify_source_line): Move declaration from symtab.h
2525         and add comment from source.c
2526         (print_source_lines): Likewise.
2527         (forget_cached_source_info_for_objfile): Likewise.
2528         (forget_cached_source_info): Likewise.
2529         (select_source_symtab): Likewise.
2530         (enum print_source_lines_flag): Move definition from symtab.h.
2531         * symtab.h (identify_source_line): Move declaration to source.h.
2532         (print_source_lines): Likewise.
2533         (forget_cached_source_info_for_objfile): Likewise.
2534         (forget_cached_source_info): Likewise.
2535         (select_source_symtab): Likewise.
2536         (enum print_source_lines_flag): Move definition to source.h.
2537         * tui/tui-hooks.c: Add 'source.h' include.
2538
2539 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * source.c (print_source_lines_base): Handle requests to print
2542         reverse line number sequences, and guard against empty lines
2543         string.
2544
2545 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * source.c (print_source_lines_base): Fix skip of '\r' if next
2548         character is '\n'.
2549
2550 2019-01-06  Tom Tromey  <tom@tromey.com>
2551
2552         * c-exp.y (struct c_parse_state) <macro_original_text,
2553         expansion_obstack>: New member.
2554         (macro_original_text, expansion_obstack): Remove globals.
2555         (scan_macro_expansion, scanning_macro_expansion)
2556         (finished_macro_expansion): Update.
2557         (scan_macro_cleanup): Remove.
2558         (yylex, c_parse): Update.
2559
2560 2019-01-06  Tom Tromey  <tom@tromey.com>
2561
2562         * c-exp.y (struct c_parse_state) <strings>: New member.
2563         (operator_stoken): Update.
2564
2565 2019-01-06  Tom Tromey  <tom@tromey.com>
2566
2567         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2568         (union type_stack_elt) <typelist_val>: Now a pointer to
2569         std::vector.
2570         (type_stack_cleanup): Don't declare.
2571         (push_typelist): Update.
2572         * parse.c (pop_typelist): Return a std::vector.
2573         (push_typelist): Take a std::vector.
2574         (follow_types): Update.  Do not free args.
2575         (type_stack_cleanup): Remove.
2576         * c-exp.y (struct c_parse_state): New.
2577         (cpstate): New global.
2578         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2579         (nonempty_typelist): Update.
2580         (func_mod): Create a new vector.
2581         (c_parse): Create a c_parse_state.
2582         (check_parameter_typelist): Do not delete params.
2583         (function_method): Update.  Do not delete type_list.
2584
2585 2019-01-06  Tom Tromey  <tom@tromey.com>
2586
2587         PR gdb/28155:
2588         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2589         check_typedef.
2590         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2591         (print_return_value): Likewise.
2592
2593 2019-01-05  Tom Tromey  <tom@tromey.com>
2594
2595         * contrib/cleanup_check.py: Remove.
2596         * contrib/gcc-with-excheck: Remove.
2597         * contrib/exsummary.py: Remove.
2598         * contrib/excheck.py: Remove.
2599
2600 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2601
2602         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2603         NULL. Initialize tpprev to NULL instead of assigning it
2604         to NULL on the next statement.
2605         * windows-nat.c (windows_delete_thread): Remove check for
2606         main_thread_id before printing thread exit notifications.
2607         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2608         Remove thread ID check against main_thread_id.
2609         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2610         windows_delete_thread.
2611         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2612
2613 2019-01-04  Tom Tromey  <tom@tromey.com>
2614
2615         * compile/compile.c (_initialize_compile): Use upper case for
2616         metasyntactic variables.
2617         * symmisc.c (_initialize_symmisc): Use upper case for
2618         metasyntactic variables.
2619         * psymtab.c (_initialize_psymtab): Use upper case for
2620         metasyntactic variables.
2621         * demangle.c (demangle_command): Use upper case for metasyntactic
2622         variables.
2623         (_initialize_demangler): Likewise.
2624         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2625         variables.
2626
2627 2019-01-03  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2630
2631 2019-01-03  Tom Tromey  <tom@tromey.com>
2632
2633         * python/py-symtab.c (salpy_str): Update.
2634         (struct salpy_sal_object) <symtab>: Now a PyObject.
2635         (salpy_dealloc): Update.
2636         (del_objfile_sal): Use gdbpy_ref.
2637
2638 2019-01-03  Tom Tromey  <tom@tromey.com>
2639
2640         * python/py-type.c (convert_field): Use new_reference.  Return
2641         gdbpy_ref.
2642         (make_fielditem): Return gdbpy_ref.
2643         (typy_fields): Update.
2644         (typy_getitem): Update.
2645         (field_name): Return gdbpy_ref.  Use new_reference.
2646         (typy_iterator_iternext): Update.
2647
2648 2019-01-03  Tom Tromey  <tom@tromey.com>
2649
2650         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2651
2652 2019-01-03  Tom Tromey  <tom@tromey.com>
2653
2654         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2655         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2656         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2657         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2658         (pspy_set_type_printers): Likewise.
2659         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2660         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2661         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2662         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2663         (objfpy_set_type_printers): Likewise.
2664
2665 2019-01-03  Tom Tromey  <tom@tromey.com>
2666
2667         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2668         (gdbpy_print_stack): Use gdbpy_err_fetch.
2669         * python/python-internal.h (class gdbpy_err_fetch): New class.
2670         (class gdbpy_enter) <m_error_type, m_error_value,
2671         m_error_traceback>: Remove.
2672         <m_error>: New member.
2673         (gdbpy_exception_to_string): Don't declare.
2674         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2675         * python/py-value.c (convert_value_from_python): Use
2676         gdbpy_err_fetch.
2677         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2678         gdbpy_exception_to_string.
2679         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2680         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2681         gdbpy_err_fetch.
2682
2683 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * linux-nat.c (delete_lwp_cleanup): Delete.
2686         (struct lwp_deleter): New struct.
2687         (lwp_info_up): New typedef.
2688         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2689         lwp_info_up.
2690
2691 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * linux-fork.c (class scoped_switch_fork_info): New class.
2694         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2695
2696 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * valops.c (find_overload_match): Remove use of null_cleanup, and
2699         calls to do_cleanups.
2700
2701 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * compile/compile-cplus-types.c
2704         (compile_cplus_instance::decl_name): Handle changes to
2705         cp_func_name.
2706         * cp-support.c (cp_func_name): Update header comment, update
2707         return type.
2708         * cp-support.h (cp_func_name): Update return type in declaration.
2709         * valops.c (find_overload_match): Move temp_func local to top
2710         level of function and change its type.  Use temp_func to hold and
2711         delete temporary string obtained from cp_func_name.
2712
2713 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2716         gdb::char_vector, remove cleanup, and update uses of `msg`.
2717
2718 2019-01-03  Jim Wilson  <jimw@sifive.com>
2719
2720         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2721
2722 2019-01-02  Tom Tromey  <tom@tromey.com>
2723
2724         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2725         (tdesc_parse_xml): Remove cleanups.
2726         * target-descriptions.h (make_cleanup_free_target_description):
2727         Don't declare.
2728         (target_desc_deleter): New struct.
2729         (target_desc_up): New typedef.
2730         * target-descriptions.c (target_desc_deleter::operator()): Rename
2731         from free_target_description.
2732         (make_cleanup_free_target_description): Remove.
2733
2734 2019-01-02  Tom Tromey  <tom@tromey.com>
2735
2736         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2737         constructor, destructor.
2738         (linespec_parser): Remove typedef.
2739         (~linespec_parser): Rename from linespec_parser_delete.
2740         (linespec_lex_to_end, linespec_complete_label)
2741         (linespec_complete): Update.
2742         (decode_line_full): Remove cleanups.
2743         (decode_line_1): Update.
2744
2745 2019-01-02  Tom Tromey  <tom@tromey.com>
2746
2747         * python/python-internal.h (inferior_to_inferior_object): Change
2748         return type.
2749         * python/py-exitedevent.c (create_exited_event_object): Update.
2750         * python/py-inferior.c (inferior_to_inferior_object): Return
2751         gdbpy_ref.
2752         (python_new_inferior, python_inferior_deleted)
2753         (thread_to_thread_object, delete_thread_object)
2754         (build_inferior_list, gdbpy_selected_inferior): Update.
2755         * python/py-infthread.c (create_thread_object): Update.  Also fail
2756         if inferior_to_inferior_object fails.
2757
2758 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2759
2760         * inferior.h (class inferior) <displaced_step_state>: New field.
2761         * infrun.h (struct displaced_step_state): Move here from
2762         infrun.c.  Initialize fields, add constructor.
2763         <inf>: Remove field.
2764         <reset>: New method.
2765         * infrun.c (struct displaced_step_inferior_state): Move to
2766         infrun.h.
2767         (displaced_step_inferior_states): Remove.
2768         (get_displaced_stepping_state): Adust.
2769         (displaced_step_in_progress_any_inferior): Adjust.
2770         (displaced_step_in_progress_thread): Adjust.
2771         (displaced_step_in_progress): Adjust.
2772         (add_displaced_stepping_state): Remove.
2773         (get_displaced_step_closure_by_addr): Adjust.
2774         (remove_displaced_stepping_state): Remove.
2775         (infrun_inferior_exit): Call displaced_step_state.reset.
2776         (use_displaced_stepping): Don't check for NULL.
2777         (displaced_step_prepare_throw): Call
2778         get_displaced_stepping_state.
2779         (displaced_step_fixup): Don't check for NULL.
2780         (prepare_for_detach): Don't check for NULL.
2781
2782 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2783
2784         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2785          in case of call that did not complete.
2786
2787 2019-01-02  Andrey Utkin  <autkin@undo.io>
2788
2789         * symfile.c (find_separate_debug_file): Fix search of debug files for
2790         remote debuggee.
2791
2792 2019-01-02  Tom Tromey  <tom@tromey.com>
2793
2794         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2795         indentation.
2796         * python/py-frame.c (frapy_older): Remove cast.
2797         (frapy_newer): Likewise.
2798         * python/py-breakpoint.c (local_setattro): Remove cast.
2799         * python/py-arch.c (archpy_name): Remove local variable.
2800         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2801
2802 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2803
2804         * unittests/basic_string_view/element_access/char/empty.cc:
2805         Fix year range in copyright header.
2806
2807 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2810         Delete.
2811         <operator==>: Update with for removed field.
2812         <hash>: Likewise.
2813         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2814         <isa_features>: ...this.
2815         <abi_features>: New field.
2816         (riscv_isa_flen): Update comment.
2817         (riscv_abi_xlen): New declaration.
2818         (riscv_abi_flen): New declaration.
2819         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2820         isa_features.
2821         (riscv_abi_xlen): New function.
2822         (riscv_isa_flen): Update to get answer from isa_features.
2823         (riscv_abi_flen): New function.
2824         (riscv_has_fp_abi): Update to get answer from abi_features.
2825         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2826         xlen and flen.
2827         (riscv_call_info) <xlen, flen>: Update comment.
2828         (riscv_call_arg_struct): Remove invalid assertions
2829         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2830         is removed.
2831         (riscv_gdbarch_init): Gather isa features and abi features
2832         separately, ensure both match on the gdbarch when reusing an old
2833         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2834         a target with 64-bit float hardware.
2835
2836 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2837
2838         * source.c (search_command_helper): Stop reverse search
2839         when line 1 has been searched.
2840
2841 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2842
2843         * record-full.c (record_full_base_target::close): Rewrite
2844         record_full_core_buf_list free logic.
2845
2846 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2847
2848         * break-catch-syscall.c (print_one_catch_syscall): xfree
2849         the last text.
2850
2851 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2852
2853         * top.c (print_gdb_version): Update Copyright year in version
2854         message.
2855
2856 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2857
2858         Update copyright year range in all GDB files.
2859
2860 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2861
2862         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2863
2864 For older changes see ChangeLog-2018.
2865 \f
2866 Local Variables:
2867 mode: change-log
2868 left-margin: 8
2869 fill-column: 74
2870 version-control: never
2871 coding: utf-8
2872 End:
2873