gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (make_data_window): Remove.
   4         (show_data): Unify creation and re-initialization cases.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-layout.c (make_source_window, make_disasm_window):
   9         Remove.
  10         (show_data): Unify creation and re-initialization cases.
  11
  12 2019-07-17  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-layout.c (make_command_window): Remove.
  15         (show_source_disasm_command, show_source_or_disasm_and_command):
  16         Unify creation and re-initialization cases.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  21         creation and re-initialization cases.
  22
  23 2019-07-17  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-regs.c (tui_get_register): Return void.
  26
  27 2019-07-17  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  30         Simplify.
  31
  32 2019-07-17  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  35         resetting.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  40         * tui/tui-regs.c (tui_reg_layout): New function.
  41         (tui_show_registers, tui_reg_command): Use it.
  42         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  43         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  44         parameters.
  45         (tui_layout_command): Remove.
  46
  47 2019-07-17  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-layout.h (tui/tui-layout): Return void.
  50         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  51
  52 2019-07-17  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-layout.c (show_source_disasm_command, show_data):
  55         Update.
  56         (reset_locator): Remove.
  57         (show_source_or_disasm_and_command): Update.
  58
  59 2019-07-17  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-source.c (tui_source_window_base::reset): Remove
  62         win_type parameter.
  63         * tui/tui-layout.c (make_command_window, make_source_window)
  64         (make_disasm_window, make_data_window)
  65         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  66         (reset_locator, show_source_or_disasm_and_command): Update.
  67         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  68         win_type parameter.
  69         (struct tui_source_window_base) <reset>: Likewise.
  70
  71 2019-07-17  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-layout.c (show_source_disasm_command): Use
  74         reset_locator.
  75         (reset_locator): New function.
  76         (init_and_make_win): Remove.
  77         (show_source_or_disasm_and_command): Use reset_locator.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  82         condition.
  83         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  84         Remove condition.
  85         * tui/tui-source.c (tui_source_window_base::reset): New method.
  86         * tui/tui-layout.c (make_command_window): Don't call
  87         init_and_make_win.
  88         (make_source_window, make_disasm_window): Don't call
  89         make_source_or_disasm_window.
  90         (make_data_window): Don't call init_and_make_win.  Change calling
  91         convention.
  92         (show_source_disasm_command, show_data): Simplify.
  93         (make_source_or_disasm_window): Remove.
  94         (show_source_or_disasm_and_command): Simplify.
  95         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  96         (struct tui_source_window_base) <reset>: Likewise.
  97         <execution_info>: Remove initializer.
  98         * tui/tui-data.c (tui_source_window_base): Initialize
  99         execution_info.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 104         variable.
 105
 106 2019-07-17  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui.c (tui_rl_other_window): Update.
 109         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 110         superclass method first.  Always iterate over regs_content.
 111         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 112         method.
 113         * tui/tui-win.c (tui_set_focus_command): Update.
 114
 115 2019-07-17  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-win.c (tui_set_focus_command): Rename from
 118         tui_set_focus.  Call tui_enable.
 119         (tui_set_focus_command): Remove.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 124         refresh_window.
 125         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 126         touchwin.
 127         (tui_data_window::refresh_window): Call refresh_window on data
 128         items.  Always call superclass refresh_window.
 129         (tui_win_info::refresh): Remove.
 130         (tui_source_window_base::refresh_window): Update.
 131         (tui_refresh_all): Update.
 132         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 133         refresh_window.
 134         (show_source_or_disasm_and_command): Likewise.
 135         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 136         (struct tui_source_window_base) <refresh>: Likewise.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.c (tui_clear_source_content)
 141         (tui_show_source_content): Update.
 142         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 143         whether content is empty.
 144         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 145         Remove.
 146
 147 2019-07-17  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 150         window's contents.
 151         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 152         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 157         (struct tui_data_item_window): Update.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 162         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 163         defines.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-winsource.h (tui_erase_source_content)
 168         (tui_clear_source_content): Remove "display_prompt" parameter.
 169         * tui/tui-winsource.c (tui_update_source_window_as_is)
 170         (tui_update_source_windows_with_addr): Update.
 171         (tui_clear_source_content): Remove "display_prompt" parameter.
 172         (tui_erase_source_content): Likewise.  Simplify.
 173         (tui_show_source_content): Update.
 174         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 175         * tui/tui-stack.c (tui_show_frame_info): Update.
 176         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 177         Remove defines.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 182         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 183         parameter.
 184         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 185         parameter.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-winsource.c (tui_clear_source_content)
 190         (tui_show_source_content, tui_show_exec_info_content)
 191         (tui_clear_exec_info_content): Update.
 192         * tui/tui-stack.c (tui_show_locator_content): Update.
 193         (tui_show_frame_info): Update.
 194         * tui/tui-source.h (tui_source_window): Don't declare.
 195         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 196         from tui_source_is_displayed.
 197         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 198         Remove field.
 199         (struct tui_source_window_base) <content_in_use>: New field.  Now
 200         bool.
 201         (struct tui_source_window) <showing_source_p>: New method.
 202         (TUI_SRC_WIN): Change cast.
 203         * tui/tui-data.c (tui_initialize_static_data): Update.
 204
 205 2019-07-17  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 208         location_matches_p.
 209         * tui/tui-source.c (tui_source_window::location_matches_p): New
 210         method.
 211         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 212         method.
 213         * tui/tui-data.h (struct tui_source_window_base)
 214         <location_matches_p>: New method.
 215         (struct tui_source_window, struct tui_disasm_window)
 216         <location_matches_p>: Likewise.
 217
 218 2019-07-17  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-win.c (tui_set_win_height_command): Rename from
 221         tui_set_win_height.
 222         (tui_set_win_height_command): Remove.
 223
 224 2019-07-17  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-source.c (tui_source_window): New constructor.  Add
 227         observer.
 228         (~tui_source_window): New destructor.
 229         (tui_source_window::style_changed): New method.
 230         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 231         (tui_attach_detach_observers): Update.
 232         * tui/tui-data.h (struct tui_source_window): Make constructor not
 233         inline.  Add destructor.
 234         (struct tui_source_window) <style_changed>: New method.
 235         <m_observable>: New member.
 236
 237 2019-07-17  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 240         * tui/tui-win.c (tui_resize_all): Fix typo.
 241
 242 2019-07-17  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 245         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 246         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 247         * tui/tui-win.c (window_name_completer): Use foreach.
 248         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 249         (update_tab_width): Likewise.
 250         * tui/tui-layout.c (show_layout): Update.
 251         * tui/tui-data.h (class tui_window_iterator): New.
 252         (struct all_tui_windows): New.
 253         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 258         parameter.  Don't reference globals.
 259         (tui_reg_command): Update.
 260
 261 2019-07-17  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-regs.c (tui_show_registers): Simplify.
 264
 265 2019-07-17  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-regs.c (tui_show_registers): Update.
 268         (tui_show_register_group): Add win_info parameter.
 269
 270 2019-07-17  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 273         Rename from tui_display_reg_element_at_line.
 274         (tui_data_window::display_registers_from_line): Update.
 275         * tui/tui-data.h (struct tui_data_window)
 276         <display_reg_element_at_line>: New method.
 277
 278 2019-07-17  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-regs.h (tui_display_registers_from)
 281         (tui_display_registers_from_line): Don't declare.
 282         * tui/tui-windata.c (tui_data_window::display_all_data)
 283         (tui_data_window::refresh_all)
 284         (tui_data_window::do_scroll_vertical): Update.
 285         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 286         from tui_display_registers_from.
 287         (tui_display_reg_element_at_line): Update.
 288         (tui_data_window::display_registers_from_line): Rename from
 289         tui_display_registers_from_line.
 290         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 291         display_registers_from_line>: New methods.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 296         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 297         from tui_erase_data_content.
 298         (tui_data_window::display_all_data)
 299         (tui_data_window::refresh_all)
 300         (tui_data_window::do_scroll_vertical): Update.
 301         * tui/tui-regs.c (tui_show_registers): Update.
 302         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 303         New method.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 308         declare.
 309         * tui/tui-windata.c
 310         (tui_data_window::delete_data_content_windows): Rename from
 311         tui_delete_data_content_windows.
 312         (tui_data_window::display_all_data)
 313         (tui_data_window::do_scroll_vertical): Update.
 314         * tui/tui-data.h (struct tui_data_window)
 315         <delete_data_content_windows>: New method.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 320         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 325         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 326         from tui_display_all_data.
 327         * tui/tui-win.c
 328         (tui_data_window::do_make_visible_with_new_height): Update.
 329         * tui/tui-regs.c (tui_show_registers): Update.
 330         * tui/tui-layout.c (tui_set_layout): Update.
 331         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 332         method.
 333
 334 2019-07-17  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 337         * tui/tui-windata.c (tui_display_data_from): Remove.
 338         (tui_data_window::refresh_all): Update.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 343         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 344         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 345         tui_display_registers_from_line.
 346         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 347         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 348         "force_display" parameter.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 353         declare.
 354         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 355         Rename from tui_first_reg_element_no_inline.
 356         (tui_display_reg_element_at_line)
 357         (tui_display_registers_from_line): Update.
 358         * tui/tui-data.h (struct tui_data_window)
 359         <first_reg_element_no_inline>: New method.
 360
 361 2019-07-17  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-windata.c (tui_display_data_from)
 364         (tui_data_window::do_scroll_vertical): Update.
 365         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 366         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 367         Rename from tui_line_from_reg_element_no.
 368         (tui_display_registers_from_line): Update.
 369         * tui/tui-data.h (struct tui_data_window)
 370         <line_from_reg_element_no>: New method.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 375         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 376         tui_last_regs_line_no.
 377         (tui_display_reg_element_at_line)
 378         (tui_display_registers_from_line): Update.
 379         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 380         method.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         PR tui/24722:
 385         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 386         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 387         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 388         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 389         (tui_update_breakpoint_info): Likewise.
 390         * tui/tui-hooks.c (tui_event_create_breakpoint)
 391         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 392         Update.
 393
 394 2019-07-17  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 397
 398 2019-07-17  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-winsource.c (tui_update_source_window_as_is)
 401         (tui_update_source_windows_with_addr): Update.
 402         * tui/tui-source.h (tui_set_source_content)
 403         (tui_show_symtab_source): Add "win_info" parameter.
 404         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 405         parameter.
 406         (tui_show_symtab_source): Likewise.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-wingeneral.c
 411         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 416         (struct tui_cmd_window) <can_scroll>: New method.
 417         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 418         method.
 419
 420 2019-07-17  Tom Tromey  <tromey@adacore.com>
 421
 422         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 423         do_field_signed>: Rename.  Change type of "value".
 424         * ui-out.c (ui_out::field_signed): Rename from field_int.
 425         Change type of "value".
 426         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 427         type of "value".
 428         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 429         do_field_int.  Change type of "value".
 430         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 431         do_field_int.  Change type of "value".
 432         * tracepoint.c (trace_status_mi, tfind_1)
 433         (print_one_static_tracepoint_marker): Update.
 434         * thread.c (print_thread_info_1, print_selected_thread_frame):
 435         Update.
 436         * stack.c (print_frame, print_frame_info): Update.
 437         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 438         Update.
 439         * source.c (print_source_lines_base): Update.
 440         * skip.c (info_skip_command): Update.
 441         * record-btrace.c (btrace_ui_out_decode_error)
 442         (btrace_call_history_src_line): Update.
 443         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 444         Update.
 445         * progspace.c (print_program_space): Update.
 446         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 447         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 448         do_field_int.  Change type of "value".
 449         * mi/mi-out.c (mi_ui_out::do_table_begin)
 450         (mi_ui_out::do_table_header): Update.
 451         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 452         type of "value".
 453         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 454         (mi_cmd_data_list_changed_registers, output_register)
 455         (mi_cmd_data_read_memory, mi_load_progress)
 456         (mi_cmd_trace_frame_collected): Update.
 457         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 458         Update.
 459         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 460         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 461         (mi_cmd_var_list_children, varobj_update_one): Update.
 462         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 463         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 465         * inferior.c (print_inferior): Update.
 466         * gdb_bfd.c (print_one_bfd): Update.
 467         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 468         Update.
 469         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 470         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 471         do_field_int.  Change type of "value".
 472         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 473         do_field_int.  Change type of "value".
 474         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 475         (print_one_breakpoint_location, print_it_catch_fork)
 476         (print_one_catch_fork, print_it_catch_vfork)
 477         (print_one_catch_vfork, print_it_catch_solib)
 478         (print_it_catch_exec, print_it_ranged_breakpoint)
 479         (print_mention_watchpoint, print_mention_masked_watchpoint)
 480         (bkpt_print_it, update_static_tracepoint): Update.
 481         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 482         * break-catch-syscall.c (print_it_catch_syscall): Update.
 483         * ada-tasks.c (print_ada_task_info): Update.
 484         * ada-lang.c (print_it_exception, print_mention_exception):
 485         Update.
 486
 487 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 488
 489         PR breakpoints/24541
 490         * gdbarch.c: Regenerate.
 491         * gdbarch.h: Regenerate.
 492         * gdbarch.sh: Adjust return type and parameter types for
 493         'stap_adjust_register'.
 494         (i386_stap_adjust_register): Adjust signature and return new
 495         register name.
 496         * stap-probe.c (stap_parse_register_operand): Adjust use of
 497         'gdbarch_stap_adjust_register'.
 498
 499 2019-07-17  Tom Tromey  <tromey@adacore.com>
 500
 501         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 502         declare VEC.
 503         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 504         std::vector.
 505         (struct s390_process_info): Add initializers.
 506         (s390_add_process): Use new.
 507         (s390_linux_nat_target::low_forget_process): Use delete.
 508         (s390_linux_nat_target::low_new_fork)
 509         (s390_linux_nat_target::stopped_by_watchpoint)
 510         (s390_linux_nat_target::low_prepare_to_resume)
 511         (s390_linux_nat_target::insert_watchpoint)
 512         (s390_linux_nat_target::insert_hw_breakpoint)
 513         (s390_linux_nat_target::remove_watchpoint)
 514         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 515
 516 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 517
 518         * aarch64-fbsd-nat.c: Include regcache.h.
 519         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 520         argument.
 521         (aarch64_fbsd_nat_target::fetch_registers)
 522         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 523         variable.
 524         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 525
 526 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 527
 528         * fbsd-nat.c: Include gdbarch.h.
 529
 530 2019-07-15  Tom Tromey  <tromey@adacore.com>
 531
 532         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 533
 534 2019-07-15  Tom Tromey  <tromey@adacore.com>
 535
 536         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 537         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 538         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 539         * cli-out.c (cli_ui_out::do_field_int): New method.
 540         * ui-out.c (ui_out::field_unsigned): New method.
 541         * symfile.c (generic_load): Use field_unsigned.
 542         (print_transfer_performance): Likewise.
 543         * record-btrace.c (ui_out_field_uint): Remove.
 544         (btrace_call_history_insn_range, btrace_call_history): Use
 545         field_unsigned.
 546         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 547         field_unsigned.
 548         * ui-out.h (class ui_out) <field_unsigned>: New method.
 549         <do_field_unsigned>: Likewise.
 550
 551 2019-07-15  Tom Tromey  <tromey@adacore.com>
 552
 553         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 554         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 555         * target.c (flash_erase_command): Use field_string.
 556         * infrun.c (print_signal_received_reason): Use field_string.
 557         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 558         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 559         field_string.
 560         * ada-tasks.c (print_ada_task_info): Use field_string.
 561
 562 2019-07-15  Tom Tromey  <tromey@adacore.com>
 563
 564         * target.c (flash_erase_command): Use field_core_addr.
 565         * symfile.c (generic_load): Use field_core_addr.
 566         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 567         Use field_core_addr.
 568         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 569         field_core_addr.
 570
 571 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 574         value if its desired type is smaller than a CORE_ADDR and signed.
 575
 576 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 579         of changes to field names, and use new is_reference field to
 580         decide if a property is a reference or not.
 581         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 582         field.
 583         (struct dwarf2_property_baton): Update header comment, rename
 584         'referenced_type' to 'property_type' and update comments.
 585         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 586         default property type, store in property baton, update to take
 587         accound of renamed field.
 588         (read_func_scope): Update call to attr_to_dynamic_prop.
 589         (read_array_type): Likewise.
 590         (dwarf2_per_cu_addr_sized_int_type): New function.
 591         (read_subrange_index_type): Move type finding code to
 592         dwarf2_per_cu_addr_sized_int_type.
 593         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 594         (dwarf2_per_cu_addr_type): New function.
 595         (set_die_type): Update calls to attr_to_dynamic_prop.
 596
 597 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 598
 599         * dwarf2read.c (read_subrange_index_type): New function.
 600         (read_subrange_type): Move code into new function and call it.
 601         * gdbtypes.c (create_range_type): Add some asserts.
 602
 603 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 604
 605         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 606         update return statements.
 607         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 608         declaration, and update comment to match.
 609         * gdbtypes.c (resolve_dynamic_array): Update call to
 610         dwarf2_evaluate_property to match new return type.
 611
 612 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * valarith.c (value_subscripted_rvalue): Change lowerbound
 615         parameter type from int to LONGEST.
 616         * value.h (value_subscripted_rvalue): Likewise in declaration.
 617
 618 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 619
 620         * cli/cli-utils.c (info_print_command_completer): New function.
 621         * cli/cli-utils.h: Add 'completer.h' include, and forward
 622         declaration for 'struct cmd_list_element'.
 623         (info_print_command_completer): Declare.
 624         * stack.c (_initialize_stack): Add completer for 'info locals' and
 625         'info args'.
 626         * symtab.c (_initialize_symtab): Add completer for 'info
 627         variables' and 'info functions'.
 628         * NEWS: Mention completion for additional info commands.
 629
 630 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * cli/cli-utils.c (extract_info_print_args): Delete.
 633         (extract_arg_maybe_quoted): Delete.
 634         (info_print_options_defs): New variable.
 635         (make_info_print_options_def_group): New function.
 636         (extract_info_print_options): Define new function.
 637         * cli/cli-utils.h (extract_info_print_args): Delete.
 638         (struct info_print_options): New structure.
 639         (extract_info_print_options): Declare new function.
 640         * stack.c (info_locals_command): Update to use new
 641         extract_info_print_options, also add a header comment.
 642         (info_args_command): Likewise.
 643         * symtab.c (info_variables_command): Likewise.
 644         (info_functions_command): Likewise.
 645
 646 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 647
 648         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 649         to extract string arguments.
 650         * common/common-utils.c (extract_string_maybe_quoted): New function.
 651         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 652
 653 2019-07-11  Tom Tromey  <tromey@adacore.com>
 654
 655         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 656         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 657         * top.h (gdbinit): Don't declare.
 658         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 659         into...
 660         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 661         * top.c (gdb_init): Don't call init_cli_cmds.
 662         (gdbinit): Remove.
 663         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 664
 665 2019-07-11  Tom Tromey  <tromey@adacore.com>
 666
 667         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 668         after it has been moved.
 669
 670 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * valops.c (value_must_coerce_to_target): Change return type to
 673         bool.
 674         * value.h (value_must_coerce_to_target): Likewise.
 675
 676 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 677
 678         * breakpoint.c (is_hardware_watchpoint): Remove
 679         forward-declaration.
 680         (is_masked_watchpoint): Change return type to bool.
 681         (is_tracepoint): Likewise.
 682         (is_breakpoint): Likewise.
 683         (is_hardware_watchpoint): Likewise.
 684         (is_watchpoint): Likewise.
 685         (is_no_memory_software_watchpoint): Likewise.
 686         (is_catchpoint): Likewise.
 687         (breakpoint_1): Make FILTER parameter's return type bool.
 688         is_masked_watchpoint): Change return type to bool.
 689         (save_breakpoints): Make FILTER parameter's return type bool.
 690         * breakpoint.h (is_breakpoint): Change return type to bool.
 691         (is_watchpoint): Likewise.
 692         (is_catchpoint): Likewise.
 693         (is_tracepoint): Likewise.
 694
 695 2019-07-10  Tom Tromey  <tom@tromey.com>
 696
 697         * defs.h: Don't include gdbarch.h.
 698         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 699         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 700         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 701         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 702         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 703         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 704         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 705         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 706         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 707         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 708         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 709         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 710         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 711         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 712         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 713         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 714         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 715         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 716         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 717         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 718         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 719         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 720         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 721         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 722         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 723         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 724         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 725
 726 2019-07-10  Tom Tromey  <tromey@adacore.com>
 727
 728         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 729         * breakpoint.c (init_ada_exception_breakpoint): Register as
 730         bp_catchpoint.
 731         (print_one_breakpoint_location, print_one_breakpoint): Use
 732         is_ada_exception_catchpoint.
 733         * ada-lang.c (class ada_catchpoint_location): Pass
 734         bp_loc_software_breakpoint to bp_location constructor.
 735         (is_ada_exception_catchpoint): New function.
 736
 737 2019-07-10  Tom Tromey  <tromey@adacore.com>
 738
 739         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 740         VEC.
 741         (struct arm_exidx_entry): New method operator<.
 742         (struct arm_exidx_data) <section_maps>: Change type.
 743         (arm_exidx_data_free): Remove.
 744         (arm_exidx_data_key): Change type.  Move lower.
 745         (arm_exidx_new_objfile): Update.
 746         (arm_compare_exidx_entries): Remove.
 747         (arm_find_exidx_entry, _initialize_arm_tdep)
 748
 749 2019-07-10  Tom Tromey  <tromey@adacore.com>
 750
 751         * solib-spu.c (ocl_program_data_key): Change type.
 752         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 753         Update.
 754
 755 2019-07-10  Tom Tromey  <tromey@adacore.com>
 756
 757         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 758         (struct solib_aix_inferior_data) <library_list>: Change type.
 759         (solib_aix_inferior_data_handle): Change type.
 760         (get_solib_aix_inferior_data): Update.
 761         (solib_aix_free_library_list): Remove.
 762         (library_list_start_library): Update.
 763         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 764         return type.
 765         (solib_aix_get_library_list)
 766         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 767         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 768
 769 2019-07-10  Tom Tromey  <tromey@adacore.com>
 770
 771         * solib-dsbt.c (struct dsbt_info): Add initializers.
 772         (solib_dsbt_pspace_data): Change type.
 773         (dsbt_pspace_data_cleanup): Remove.
 774         (get_dsbt_info, _initialize_dsbt_solib): Update.
 775
 776 2019-07-10  Tom Tromey  <tromey@adacore.com>
 777
 778         * spu-tdep.c (spu_overlay_data): Change type.
 779         (spu_get_overlay_table, spu_overlay_new_objfile)
 780         (_initialize_spu_tdep): Update.
 781
 782 2019-07-10  Tom Tromey  <tromey@adacore.com>
 783
 784         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 785         destructor.
 786         (dbx_objfile_data_key): Change type and declare later.
 787         (DBX_SYMFILE_INFO): Rewrite.
 788         * dbxread.c (dbx_objfile_data_key): Change type.
 789         (dbx_symfile_init): Update.
 790         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 791         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 792         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 793
 794 2019-07-10  Tom Tromey  <tromey@adacore.com>
 795
 796         * jit.c (jit_program_space_key): Change type.  Move lower.
 797         (get_jit_program_space_data): Update.
 798         (jit_program_space_data_cleanup): Remove.
 799         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 800         Update.
 801         (struct jit_program_space_data): Add initializers.
 802
 803 2019-07-10  Tom Tromey  <tromey@adacore.com>
 804
 805         * solib-darwin.c (struct darwin_info): Add initializers.
 806         (solib_darwin_pspace_data): Change type.
 807         (darwin_pspace_data_cleanup): Remove.
 808         (get_darwin_info, _initialize_darwin_solib): Update.
 809
 810 2019-07-10  Tom Tromey  <tromey@adacore.com>
 811
 812         * remote-sim.c (struct sim_inferior_data): Add initializers,
 813         constructor, and destructor.
 814         (sim_inferior_data_key): Change type.  Move lower.
 815         (check_for_duplicate_sim_descriptor): Update.
 816         (get_sim_inferior_data): Use new.  Update.
 817         (~sim_inferior_data_cleanup): Rename from
 818         sim_inferior_data_cleanup.  Simplify.
 819         (gdbsim_close_inferior, simulator_command)
 820         (sim_command_completer, _initialize_remote_sim): Update.
 821         (next_pid, INITIAL_PID): Move earlier.
 822
 823 2019-07-10  Tom Tromey  <tromey@adacore.com>
 824
 825         * python/python-internal.h (create_thread_object): Return
 826         gdbpy_ref.
 827         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 828         * python/py-inferior.c (struct threadlist_entry): Add
 829         constructor.
 830         <thread_obj>: Now a gdbpy_ref.
 831         (thread_to_thread_object): Update.
 832         (add_thread_object): Use new.
 833         (delete_thread_object): Use delete.
 834         (infpy_threads): Update.
 835         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 836         GIL.
 837
 838 2019-07-10  Tom Tromey  <tromey@adacore.com>
 839
 840         * valops.c (value_cast): Specialize error message for Ada.
 841
 842 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 843
 844         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 845
 846 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 847
 848         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 849         bpstat_should_step): Return bool, adjust comments.
 850         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 851         bpstat_should_step): Likewise.
 852
 853 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 854
 855         * features/Makefile: Use feature target descriptions for Arm.
 856         * features/arm/arm-core.c: Generate new file.
 857         * features/arm/arm-fpa.c: Likewise.
 858         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 859         * features/arm/arm-m-profile.c: Likewise.
 860         * features/arm/arm-vfpv2.c: Likewise.
 861         * features/arm/arm-vfpv3.c: Likewise.
 862         * features/arm/xscale-iwmmxt.c: Likewise.
 863         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 864
 865 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 866
 867         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 868         ptrace earlier.
 869
 870 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 871
 872         * features/aarch64-pauth.c: Regenerate.
 873
 874 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 875
 876         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 877         bool.
 878         (bpstat_what): Use false instead of 0.
 879
 880 2019-07-09  Pedro Alves  <palves@redhat.com>
 881
 882         * break-catch-throw.c (is_exception_catchpoint): New.
 883         * breakpoint.c (print_one_breakpoint_location): New parameter
 884         'raw_loc'.  Handle it.  Use
 885         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 886         looking at the breakpoint's type.
 887         (print_one_breakpoint): If handling "maint info breakpoints", also
 888         print locations of exception catchpoints.
 889         * breakpoint.h (is_exception_catchpoint): Declare.
 890
 891 2019-07-09  Pedro Alves  <palves@redhat.com>
 892
 893         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 894         "addr" field.
 895         (allocate_location_exception_catchpoint): New.
 896         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 897         (initialize_throw_catchpoint_ops): Install
 898         allocate_location_exception_catchpoint as allocate_location
 899         method.
 900         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 901         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 902         bp_loc_other.
 903         (breakpoint_address_is_meaningful): Delete.
 904         (bl_address_is_meaningful): New.
 905         (breakpoint_locations_match): Adjust comment.
 906         (bp_location_from_bp_type): New, factored out of...
 907         (bp_location::bp_location(breakpoint *)): ... this.
 908         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 909         factored out of...
 910         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 911         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 912         breakpoint_address_is_meaningful.
 913         (bp_locations_compare): Adjust comment.
 914         (update_global_location_list): Use bl_address_is_meaningful
 915         instead of breakpoint_address_is_meaningful.
 916         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 917         explicit.
 918         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 919         * python/py-breakpoint.c (bppy_get_location): No longer check
 920         whether location is null.
 921
 922 2019-07-09  Pedro Alves  <palves@redhat.com>
 923
 924         PR c++/15468
 925         * breakpoint.c (print_one_breakpoint_location): Remove
 926         single-location assert.
 927
 928 2019-07-09  Tom Tromey  <tom@tromey.com>
 929
 930         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 931         * configure: Rebuild.
 932         * configure.ac: Change common to gdbsupport.
 933         * gdbsupport: Rename from common.
 934         * acinclude.m4: Change common to gdbsupport.
 935         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 936         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 937         gdbsupport.
 938         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 939         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 940         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 941         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 942         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 943         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 944         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 945         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 946         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 947         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 948         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 949         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 950         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 951         coff-pe-read.c, command.h, compile/compile-c-support.c,
 952         compile/compile-c.h, compile/compile-cplus-symbols.c,
 953         compile/compile-cplus-types.c, compile/compile-cplus.h,
 954         compile/compile-loc2c.c, compile/compile.c, completer.c,
 955         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 956         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 957         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 958         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 959         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 960         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 961         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 962         features/aarch64-core.c, features/aarch64-fpu.c,
 963         features/aarch64-pauth.c, features/aarch64-sve.c,
 964         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 965         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 966         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 967         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 968         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 969         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 970         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 971         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 972         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 973         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 974         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 975         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 976         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 977         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 978         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 979         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 980         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 981         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 982         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 983         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 984         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 985         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 986         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 987         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 988         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 989         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 990         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 991         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 992         minsyms.c, mips-linux-tdep.c, namespace.h,
 993         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 994         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 995         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 996         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 997         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 998         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 999         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1000         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1001         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1002         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1003         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1004         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1005         procfs.c, producer.c, progspace.h, psymtab.h,
1006         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1007         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1008         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1009         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1010         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1011         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1012         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1013         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1014         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1015         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1016         target-memory.c, target.c, target.h, target/waitstatus.c,
1017         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1018         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1019         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1020         unittests/array-view-selftests.c,
1021         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1022         unittests/common-utils-selftests.c,
1023         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1024         unittests/format_pieces-selftests.c,
1025         unittests/function-view-selftests.c,
1026         unittests/lookup_name_info-selftests.c,
1027         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1028         unittests/mkdir-recursive-selftests.c,
1029         unittests/observable-selftests.c,
1030         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1031         unittests/parse-connection-spec-selftests.c,
1032         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1033         unittests/scoped_fd-selftests.c,
1034         unittests/scoped_mmap-selftests.c,
1035         unittests/scoped_restore-selftests.c,
1036         unittests/string_view-selftests.c, unittests/style-selftests.c,
1037         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1038         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1039         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1040         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1041         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1042         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1043
1044 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1047         bool value.
1048         (decode_digits_ordinary): Set explicit_line field in sal.
1049         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1050         symtab_and_line that was set on an explicit line number in
1051         assembler code.  Do always update the recorded symtab and line if
1052         we do skip the prologue.
1053
1054 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * breakpoint.c (set_breakpoint_location_function): Remove
1057         explicit_loc parameter.
1058         (momentary_breakpoint_from_master): Update call to
1059         set_breakpoint_location_function.
1060         (add_location_to_breakpoint): Likewise.
1061
1062 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1065         required features based on default bfd type when no specific bfd
1066         is present.
1067
1068 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1069
1070         * NEWS: Mention that GDB printf and eval commands can now print
1071         C-style and Ada-style convenience var strings without
1072         calling the inferior.
1073         * printcmd.c (printf_c_string): Locally print GDB internal var
1074         instead of transiting via the inferior.
1075         (printf_wide_c_string): Likewise.
1076
1077 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1078
1079         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1080
1081 2019-07-04  Tom Tromey  <tom@tromey.com>
1082
1083         PR tui/24724:
1084         * tui/tui-winsource.c (tui_clear_source_content): Update.
1085         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1086         (tui_update_breakpoint_info): Update.
1087         (tui_set_exec_info_content): Update.
1088         * tui/tui-source.c (tui_set_source_content_nil): Update.
1089         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1090         has_break.
1091         * tui/tui-data.h (enum tui_bp_flag): New.
1092         (tui_bp_flags): New enum flags type.
1093         (struct tui_source_element) <break_mode>: Change type.  Rename
1094         from has_break.
1095         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1096         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1097         constants.
1098         * tui/tui-winsource.h: Fix comment.
1099
1100 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1101
1102         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1103         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1104         (store_fpregs_to_thread)
1105         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1106         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1107         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1108         (IWMMXT_REGS_SIZE): Add define.
1109         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1110         (fetch_vfp_regs, store_vfp_regs)
1111         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1112         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1113
1114 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1115
1116         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1117         defines.
1118         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1119         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1120         (ARM_INT_REGISTER_SIZE): ...to this.
1121         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1122         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1123         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1124         (arm_linux_collect_gregset, supply_nwfpe_register)
1125         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1126         defines.
1127         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1128         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1129         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1130         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1131         (arm_return_in_memory, arm_store_return_value)
1132         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1133         (arm_record_ld_st_multiple): Likewise.
1134         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1135         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1136
1137 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1138
1139         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1140         AARCH64_DISPLACED_MODIFIED_INSNS.
1141         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1142         (aarch64_displaced_step_copy_insn): Likewise.
1143         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1144         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1145         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1146         ARM_DISPLACED_MODIFIED_INSNS.
1147         * arm-tdep.c (arm_gdbarch_init): Likewise.
1148         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1149         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1150         (struct arm_displaced_step_closure): Use
1151         ARM_DISPLACED_MODIFIED_INSNS.
1152
1153 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1154
1155         * features/Makefile: Remove unused xml files.
1156         * features/aarch64.xml: Remove.
1157         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1158         * features/i386/amd64-avx-avx512.xml: Remove.
1159         * features/i386/amd64-avx-linux.xml: Remove.
1160         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1161         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1162         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1163         * features/i386/amd64-avx-mpx.xml: Remove.
1164         * features/i386/amd64-avx.xml: Remove.
1165         * features/i386/amd64-linux.xml: Remove.
1166         * features/i386/amd64-mpx-linux.xml: Remove.
1167         * features/i386/amd64-mpx.xml: Remove.
1168         * features/i386/amd64.xml: Remove.
1169         * features/i386/i386-avx-avx512-linux.xml: Remove.
1170         * features/i386/i386-avx-avx512.xml: Remove.
1171         * features/i386/i386-avx-linux.xml: Remove.
1172         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1173         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1174         * features/i386/i386-avx-mpx-linux.xml: Remove.
1175         * features/i386/i386-avx-mpx.xml: Remove.
1176         * features/i386/i386-avx.xml: Remove.
1177         * features/i386/i386-linux.xml: Remove.
1178         * features/i386/i386-mmx-linux.xml: Remove.
1179         * features/i386/i386-mmx.xml: Remove.
1180         * features/i386/i386-mpx-linux.xml: Remove.
1181         * features/i386/i386-mpx.xml: Remove.
1182         * features/i386/i386.xml: Remove.
1183         * features/i386/x32-avx-avx512-linux.xml: Remove.
1184         * features/i386/x32-avx-linux.xml: Remove.
1185         * features/i386/x32-linux.xml: Remove.
1186
1187 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1188
1189         * regformats/aarch64.dat: Remove.
1190         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1191         * regformats/i386/amd64-avx-linux.dat: Remove.
1192         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1193         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1194         * regformats/i386/amd64-linux.dat: Remove.
1195         * regformats/i386/amd64-mpx-linux.dat: Remove.
1196         * regformats/i386/amd64.dat: Remove.
1197         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1198         * regformats/i386/i386-avx-linux.dat: Remove.
1199         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1200         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1201         * regformats/i386/i386-linux.dat: Remove.
1202         * regformats/i386/i386-mmx-linux.dat: Remove.
1203         * regformats/i386/i386-mpx-linux.dat: Remove.
1204         * regformats/i386/i386.dat: Remove.
1205         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1206         * regformats/i386/x32-avx-linux.dat: Remove.
1207         * regformats/i386/x32-linux.dat: Remove.
1208
1209 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1210
1211         * aarch64-tdep.c: Remove xml self tests.
1212         * amd64-linux-tdep.c: Likewise.
1213         * amd64-tdep.c: Likewise.
1214         * i386-linux-tdep.c: Likewise.
1215         * i386-tdep.c: Likewise.
1216
1217 2019-07-03  Pedro Alves  <palves@redhat.com>
1218
1219         PR cli/24732
1220         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1221         (pipe_cmd_option_defs): New.
1222         (make_pipe_cmd_options_def_group): New.
1223         (pipe_command): Use gdb::option::process_options.
1224         (pipe_command_completer): New function.
1225         (_initialize_cli_cmds): Install completer for "pipe" command.
1226
1227 2019-07-03  Pedro Alves  <palves@redhat.com>
1228
1229         * cli/cli-option.c (union option_value) <string>: New field.
1230         (struct option_def_and_value): Add ctor, move ctor, dtor and
1231         use DISABLE_COPY_AND_ASSIGN.
1232         (option_def_and_value::clear_value): New.
1233         (parse_option, save_option_value_in_ctx, get_val_type_str)
1234         (add_setshow_cmds_for_options): Handle var_string.
1235         * cli-option.h (union option_def::var_address) <string>: New
1236         field.
1237         (struct string_option_def): New.
1238         * maint-test-options.c (struct test_options_opts): Add default
1239         ctor and use DISABLE_COPY_AND_ASSIGN.
1240         <string_opt>: New field.
1241         (test_options_opts::~test_options_opts): New.
1242         (test_options_opts::dump): Also dump "-string".
1243         (test_options_option_defs): Install "string.
1244
1245 2019-07-03  Pedro Alves  <palves@redhat.com>
1246
1247         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1248         option_value with a null enumeration.
1249         (complete_options): Save the option values in the context.
1250         (save_option_value_in_ctx): New, factored out from ...
1251         (process_options): ... here.
1252         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1253         of the function.
1254         * maint-test-options.c (test_options_opts::dump): New, factored
1255         out from ...
1256         (maintenance_test_options_command_mode): ... here.
1257         (maintenance_test_options_command_completion_result): Delete.
1258         (maintenance_test_options_command_completion_text): Update
1259         comment.
1260         (maintenance_show_test_options_completion_result): Change
1261         prototype.  Just print
1262         maintenance_test_options_command_completion_text.
1263         (save_completion_result): New.
1264         (maintenance_test_options_completer_mode): Pass options context to
1265         complete_options, and then save a dump.
1266         (_initialize_maint_test_options): Use add_cmd to install "maint
1267         show test-options-completion-result".
1268
1269 2019-07-03  Pedro Alves  <palves@redhat.com>
1270
1271         * NEWS (New commands): Mention "with" and "maint with".
1272         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1273         (with_command, with_command_completer): New.
1274         (pipe_command): Adjust to new repeat_previous
1275         interface.
1276         (_initialize_cli_cmds): Install the "with" command and its "w"
1277         alias.
1278         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1279         declarations.
1280         * cli/cli-setshow.c (parse_cli_var_uinteger)
1281         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1282         argument strings for all var_types.
1283         (get_setshow_command_value_string): New, factored out from ...
1284         (do_show_command): ... this.
1285         * cli/cli-setshow.h: Include <string>.
1286         (get_setshow_command_value_string): Declare.
1287         * command.h (repeat_previous): Now returns const char *.  Adjust
1288         comment.
1289         * maint.c: Include "cli/cli-cmds.h".
1290         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1291         (_initialize_maint_cmds): Register the "maintenance with" command.
1292         * top.c (repeat_previous): Move bits from pipe_command here:
1293         Return the saved command line, if any; error out if there's no
1294         command to relaunch.
1295
1296 2019-07-03  Pedro Alves  <palves@redhat.com>
1297
1298         * NEWS (New commands): Mention "maint set/show test-settings"
1299         instead of "maint test-settings".
1300         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1301         (maintenance_test_settings_set_list): Rename to ...
1302         (maintenance_set_test_settings_list): ... this.
1303         (maintenance_test_settings_show_list): Rename to  ...
1304         (maintenance_show_test_settings_list): ... this.
1305         (maintenance_test_settings_cmd): Delete.
1306         (maintenance_test_settings_set_cmd): ...
1307         (maintenance_set_test_settings_cmd): ... this.
1308         (maintenance_test_settings_show_cmd): ...
1309         (maintenance_show_test_settings_cmd): ... this.
1310         (maintenance_test_settings_show_value_cmd):
1311         (maintenance_show_test_settings_value_cmd): ... this.
1312         (_initialize_maint_test_settings): No longer install the "maint
1313         test-settings" prefix command.  Rename "maint test-settings set"
1314         to "maint set test-settings", and "maint test-settings show" to
1315         "maint show test-settings".  Adjust all subcommands.
1316
1317 2019-07-03  Pedro Alves  <palves@redhat.com>
1318
1319         * maint-test-settings.c: Fix file's intro comment.  Replace all
1320         references to "test-options" with references to "test-settings",
1321         in comments.
1322
1323 2019-07-03  Pedro Alves  <palves@redhat.com>
1324
1325         * maint-test-settings.c (maintenance_test_settings_xxx)
1326         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1327         New.
1328         (maintenance_test_settings_enums): Use them.
1329         (maintenance_test_settings_enum): Default to
1330         maintenance_test_settings_xxx.
1331         (_initialize_maint_test_settings): Initialize
1332         MAINTENANCE_TEST_SETTINGS_FILENAME.
1333
1334 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1335
1336         * breakpoint.h (remove_breakpoints_inf): Change return type to
1337         void, move function documentation here.
1338         * breakpoint.c (remove_breakpoints_inf): Change return type to
1339         void, move function documentation to header.
1340
1341 2019-07-02  Pedro Alves  <palves@redhat.com>
1342
1343         * NEWS (Completion improvements): Mention "info threads".
1344         * thread.c (struct info_threads_opts, info_threads_option_defs)
1345         (make_info_threads_options_def_group): New.
1346         (info_threads_command): Use gdb::option::process_options.
1347         (info_threads_command_completer): New.
1348         (_initialize_thread): Use gdb::option::build_help to build the
1349         help text for "info threads".
1350
1351 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1352
1353         * defs.h (generic_load): Move from here...
1354         * symfile.h (generic_load): ... to here.  Rename name parameter
1355         to args.
1356         * symfile.c (generic_load): Add comment.
1357
1358 2019-07-01  Tom Tromey  <tromey@adacore.com>
1359
1360         * dwarf2read.c
1361         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1362         declaration of without_params.  Fix formatting.
1363
1364 2019-07-01  Tom Tromey  <tromey@adacore.com>
1365
1366         * ada-exp.y (find_primitive_type): Update.
1367         * ada-lang.h (ada_lookup_symbol): Update.
1368         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1369         parameter.
1370         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1371
1372 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1373
1374         PR breakpoints/24541
1375         * gdbarch.c: Regenerate.
1376         * gdbarch.h: Regenerate.
1377         * gdbarch.sh: Add 'stap_adjust_register'.
1378         * i386-tdep.c: Include '<unordered_set>'.
1379         (i386_stap_adjust_register): New function.
1380         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1381         * stap-probe.c (stap_parse_register_operand): Call
1382         'gdbarch_stap_adjust_register'.
1383
1384 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1385
1386         PR python/24742
1387         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1388         * python/python.c (do_start_initialization): Use 'xmalloc'
1389         instead of 'PyMem_Malloc'.
1390
1391 2019-06-28  Tom Tromey  <tromey@adacore.com>
1392
1393         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1394         for Ada.
1395
1396 2019-06-27  Tom Tromey  <tromey@adacore.com>
1397
1398         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1399         objfile_key.
1400         (arm_find_mapping_symbol, arm_record_special_symbol)
1401         (_initialize_arm_tdep): Update.
1402         (arm_objfile_data_free): Remove.
1403
1404 2019-06-27  Tom Tromey  <tromey@adacore.com>
1405
1406         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1407         to cp_print_static_field.
1408
1409 2019-06-26  Tom Tromey  <tromey@adacore.com>
1410
1411         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1412         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1413         declare.
1414
1415 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1416
1417         * features/aarch64-core.c (create_feature_aarch64_core):
1418         Regenerate.
1419         * features/aarch64-core.xml: Add cpsr flags.
1420
1421 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1422
1423         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1424         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1425
1426 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1427
1428         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1429         field.
1430         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1431         use.
1432         (arm_record_special_symbol): Don't insert new symbol in sorted
1433         position, push it at the end.
1434
1435 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1436
1437         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1438         (arm_mapping_symbol_s): Remove.
1439         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1440         (arm_mapping_symbol_vec): New typedef.
1441         (struct arm_per_objfile): Add constructor.
1442         <section_maps>: Change type to
1443         std::unique_ptr<arm_mapping_symbol_vec[]>.
1444         (arm_compare_mapping_symbols): Remove.
1445         (arm_find_mapping_symbol): Adjust to section_maps type change.
1446         (arm_objfile_data_free): Call delete on arm_per_objfile.
1447         (arm_record_special_symbol): Adjust to section_maps type change.
1448         Allocate arm_per_objfile with new.
1449
1450 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451
1452         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1453         with the command prefix.
1454
1455 2019-06-25  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1458         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1459
1460 2019-06-25  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1463         type.
1464         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1465         protected.
1466
1467 2019-06-25  Tom Tromey  <tom@tromey.com>
1468
1469         * tui/tui-winsource.c
1470         (tui_source_window_base::set_is_exec_point_at): Add check against
1471         LOA_ADDRESS.
1472
1473 2019-06-25  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-source.c (tui_set_source_content): Don't check before
1476         xfree.
1477         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1478
1479 2019-06-25  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-winsource.h (tui_update_source_window_as_is)
1482         (tui_alloc_source_buffer, tui_line_is_displayed)
1483         (tui_addr_is_displayed): Change type of win_info.
1484         * tui/tui-winsource.c (tui_update_source_window_as_is)
1485         (tui_clear_source_content, tui_show_source_line)
1486         (tui_show_source_content, tui_source_window_base::refill)
1487         (tui_source_window_base::set_is_exec_point_at)
1488         (tui_source_window_base::set_is_exec_point_at)
1489         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1490         (tui_alloc_source_buffer, tui_line_is_displayed)
1491         (tui_addr_is_displayed): Change type of win_info.  Update.
1492         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1493         (tui_source_window_base::do_make_visible_with_new_height):
1494         Update.
1495         * tui/tui-source.c (tui_set_source_content)
1496         (tui_set_source_content_nil)
1497         (tui_source_window::do_scroll_vertical): Update.
1498         * tui/tui-layout.c (show_layout): Update.
1499         * tui/tui-disasm.c (tui_set_disassem_content)
1500         (tui_disasm_window::do_scroll_vertical): Update.
1501         * tui/tui-data.h (tui_win_content): Remove.
1502         (struct tui_gen_win_info) <content, content_size>: Remove.
1503         (struct tui_source_element): Add initializers and destructor.
1504         (union tui_which_element, struct tui_win_element): Remove.
1505         (struct tui_source_window_base) <content>: New field.
1506         (struct tui_data_window): Remove destructor.
1507         (tui_alloc_content, tui_free_win_content)
1508         (tui_free_all_source_wins_content): Don't declare.
1509         * tui/tui-data.c (tui_initialize_static_data): Update.
1510         (init_content_element, tui_alloc_content): Remove.
1511         (~tui_gen_win_info): Update.
1512         (~tui_data_window, tui_free_all_source_wins_content)
1513         (tui_free_win_content, free_content, free_content_elements):
1514         Remove.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-winsource.h (tui_clear_source_content)
1519         (tui_erase_source_content, tui_show_source_content): Change type
1520         of win_info.
1521         * tui/tui-winsource.c (tui_clear_source_content)
1522         (tui_erase_source_content, tui_show_source_content): Change type
1523         of win_info.
1524         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1525         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1526         win_info.
1527         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1528         win_info.
1529         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1530
1531 2019-06-25  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-winsource.c (tui_clear_source_content)
1534         (tui_source_window_base::set_is_exec_point_at): Update.
1535         * tui/tui-source.c (tui_set_source_content_nil): Update.
1536         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1537         a bool.
1538         * tui/tui-data.c (init_content_element): Update.
1539
1540 2019-06-25  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1543         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1544         * tui/tui-layout.c (init_and_make_win): Update.
1545         * tui/tui.h (enum tui_win_type): Update.
1546         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1547         tui_win_is_auxillary.
1548         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1549         tui_win_is_auxillary.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1554         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1555         (tui_delete_data_content_windows, tui_display_all_data)
1556         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1557         Update.
1558         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1559         * tui/tui-regs.c (tui_last_regs_line_no)
1560         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1561         (tui_show_registers): Update.
1562         (tui_show_register_group): Return void.  Update.
1563         (tui_display_registers_from, tui_display_reg_element_at_line)
1564         (tui_display_registers_from_line, tui_check_register_values):
1565         Update.
1566         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1567         member.
1568         (struct tui_data_window) <regs_content>: Now a std::vector.
1569         <regs_content_count>: Remove.
1570         (tui_add_content_elements, tui_free_data_content): Don't declare.
1571         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1572         (init_content_element): Remove DATA_WIN case.  Add assert.
1573         (tui_add_content_elements): Remove.
1574         (tui_data_window): Update.
1575         (tui_free_data_content): Remove.
1576         (free_content_elements): Remove DATA_WIN case.
1577
1578 2019-06-25  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-data.c (tui_data_item_window): Update.
1581         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1582         * tui/tui-windata.c (tui_display_all_data)
1583         (tui_display_data_from_line): Update.
1584         (tui_check_data_values): Remove.
1585         * tui/tui-regs.c (tui_show_register_group)
1586         (tui_display_reg_element_at_line): Update.
1587         * tui/tui-hooks.c (tui_register_changed)
1588         (tui_refresh_frame_and_register_information): Call
1589         tui_check_register_values.
1590         * tui/tui-data.h (struct tui_data_window) <data_content,
1591         data_content_count, data_type>: Remove.
1592         (enum tui_data_type): Remove.
1593
1594         * tui/tui-data.c (tui_data_window::clear_detail)
1595         (~tui_data_window): Update.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1600         declare.
1601         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1602         Rename from tui_first_data_item_displayed.  Update.
1603         (tui_data_window::refresh_all)
1604         (tui_data_window::do_scroll_vertical): Update.
1605         * tui/tui-data.h (struct tui_data_window)
1606         <first_data_item_displayed>: Declare new method.
1607
1608 2019-06-25  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1611         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1612         contents...
1613         (tui_initialize_static_data): ...here.
1614
1615 2019-06-25  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1618         (tui_display_registers_from, tui_check_register_values): Update.
1619         (tui_display_register): Remove win_info parameter; update.
1620         (tui_get_register): Change type of parameters.
1621         * tui/tui-data.h (struct tui_data_element): Remove.
1622         (union tui_which_element) <data>: Remove.
1623         <data_window>: Change type.
1624         (struct tui_data_item_window): New.
1625         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1626         case.  Add assert.
1627         (~tui_data_item_window): New destructor.
1628         (free_content_elements): Remove DATA_ITEM_WIN case.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1633         Remove.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-data.h (struct tui_command_element): Remove.
1638         (union tui_which_element) <command>: Remove.
1639         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1640         assert.
1641         (free_content_elements): Remove CMD_WIN case.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-layout.c (tui_set_layout): Update.
1646         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1647         * tui/tui-data.c (layout_def): Update.
1648
1649 2019-06-25  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1652         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1653         (tui_source_window_base::set_new_height): Update.
1654         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1655         Update.
1656         (tui_set_locator_fullname, tui_set_locator_info)
1657         (tui_show_frame_info): Update.
1658         * tui/tui-source.c (tui_set_source_content)
1659         (tui_source_is_displayed): Update.
1660         * tui/tui-layout.c (show_source_disasm_command, show_data)
1661         (show_source_or_disasm_and_command): Update.
1662         * tui/tui-disasm.c (tui_set_disassem_content)
1663         (tui_get_begin_asm_address): Update.
1664         * tui/tui-data.h (struct tui_locator_element): Remove.
1665         (union tui_which_element) <locator>: Remove.
1666         (struct tui_locator_window): New.
1667         (tui_locator_win_info_ptr): Change return type.
1668         * tui/tui-data.c (_locator): Change type.
1669         (tui_locator_win_info_ptr): Change return type.
1670         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1671         (tui_alloc_content): Add assert.
1672
1673 2019-06-25  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-winsource.c
1676         (tui_exec_info_window::maybe_allocate_content): New method.
1677         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1678         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1679         (make_source_or_disasm_window): Add cast.
1680         * tui/tui-data.h (union tui_which_element) <simple_string>:
1681         Remove.
1682         (struct tui_source_info): New.
1683         (struct tui_source_window_base) <execution_info>: Change type.
1684         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1685         case, and add assert.
1686         (tui_alloc_content): Add assert.
1687
1688 2019-06-25  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1691         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1692         * tui/tui-data.c (tui_alloc_win_info): Remove.
1693
1694 2019-06-25  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1697         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1698         can_highlight.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1703         make_visible_with_new_height method.
1704         (tui_win_info::make_visible_with_new_height): New method.
1705         (tui_source_window_base::do_make_visible_with_new_height)
1706         (tui_data_window::do_make_visible_with_new_height)
1707         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1708         (make_visible_with_new_height): Remove.
1709         (tui_resize_all, tui_adjust_win_heights): Use
1710         make_visible_with_new_height method.
1711         * tui/tui-data.h (struct tui_win_info)
1712         <do_make_visible_with_new_height, make_visible_with_new_height>:
1713         New methods.
1714         (struct tui_source_window_base, struct tui_data_window)
1715         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1716         methods.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1721         method.
1722         (update_tab_width): Call update_tab_width method.
1723         * tui/tui-data.h (struct tui_win_info)
1724         (struct tui_source_window_base) <update_tab_width>: New methods.
1725
1726 2019-06-25  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1729         parameter.
1730         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1731         parameter.
1732         (tui_gen_win_info::make_visible): Update.
1733         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1734         parameter.
1735         * tui/tui-data.h (enum tui_box): New enum.
1736         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1741         init_and_make_win for EXEC_INFO_WIN.
1742         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1743         longer inline.
1744         (struct tui_win_info) <~tui_win_info>: Inline.
1745         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1746         Don't declare.
1747         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1748         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1749         Remove.
1750         (tui_initialize_static_data): Update.
1751         (~tui_gen_win_info): Handle more cleanup here.
1752         (~tui_source_window_base): Delete "execution_info".
1753         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1754
1755 2019-06-25  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-layout.c (make_command_window): Don't set
1758         can_highlight.
1759         (show_source_disasm_command): Call the reset method.
1760         (show_data): Don't set can_highlight.  Call the reset method.
1761         (tui_gen_win_info::reset): Rename from init_gen_win_info
1762         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1763         (show_source_or_disasm_and_command): Call the reset method.
1764         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1765         (struct tui_cmd_window): Set can_highlight.
1766
1767 2019-06-25  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1770         from make_visible.
1771         (tui_make_visible, tui_make_invisible): Rewrite.
1772         (tui_win_info::make_visible): Remove.
1773         (tui_source_window_base::make_visible): Update.
1774         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1775         method.  Moved from...
1776         (struct tui_win_info) <make_visible>: ...here.
1777
1778 2019-06-25  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-winsource.c
1781         (tui_source_window_base::do_scroll_horizontal): Remove direction
1782         parameter.
1783         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1784         direction parameter.
1785         * tui/tui-win.c (tui_win_info::forward_scroll)
1786         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1787         (tui_win_info::right_scroll): Update.
1788         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1789         direction parameter.
1790         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1791         direction parameter.
1792         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1793         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1794         Remove direction parameter.
1795         (struct tui_source_window_base, struct tui_source_window)
1796         (struct tui_disasm_window, struct tui_data_window)
1797         (struct tui_cmd_window): Update.
1798
1799 2019-06-25  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (tui_set_exec_info_content)
1802         (tui_show_exec_info_content, tui_erase_exec_info_content)
1803         (tui_clear_exec_info_content, tui_update_exec_info): Change
1804         argument to tui_source_window_base.
1805         * tui/tui-winsource.c (tui_set_exec_info_content)
1806         (tui_show_exec_info_content, tui_erase_exec_info_content)
1807         (tui_clear_exec_info_content, tui_update_exec_info): Change
1808         argument to tui_source_window_base.
1809
1810 2019-06-25  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1813         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1818         check.
1819
1820 2019-06-25  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1823         type to void.
1824         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1825         type to void.
1826         * tui/tui-source.c (tui_set_source_content): Update.
1827         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1828
1829 2019-06-25  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-win.c (window_name_completer, tui_set_focus)
1832         (tui_all_windows_info): Use name method.
1833         * tui/tui-data.h (struct tui_gen_win_info)
1834         (struct tui_source_window, struct tui_disasm_window)
1835         (struct tui_data_window, struct tui_cmd_window) <name>: New
1836         method.
1837         (tui_win_name): Don't declare.
1838         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1839         (tui_win_name): Remove.
1840
1841 2019-06-25  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-winsource.h (tui_update_source_window)
1844         (tui_update_source_window_as_is): Change parameter type.
1845         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1846         to be a tui_source_window_base.
1847         (tui_update_source_window_as_is): Likewise.
1848         * tui/tui-win.c (make_visible_with_new_height): Update.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-winsource.c (tui_erase_source_content)
1853         (tui_show_source_content, tui_show_exec_info_content)
1854         (tui_erase_exec_info_content): Use refresh_window method.
1855         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1856         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1857         from tui_refresh_win.
1858         (tui_data_window::refresh_window): New method.
1859         (tui_win_info::refresh, tui_source_window_base::refresh)
1860         (tui_refresh_all): Use refresh_window method.
1861         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1862         method.
1863         * tui/tui-regs.c (tui_display_register): Call refresh_window
1864         method.
1865         * tui/tui-layout.c (show_source_disasm_command)
1866         (show_source_or_disasm_and_command): Call refresh_window method.
1867         * tui/tui-data.h (struct tui_gen_win_info)
1868         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1869         New method.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui.c (tui_rl_other_window, tui_enable)
1874         (tui_is_window_visible, tui_get_command_dimension): Update.
1875         * tui/tui-winsource.c (tui_update_source_window_as_is)
1876         (tui_clear_source_content, tui_erase_source_content)
1877         (tui_show_source_line, tui_source_window_base::refill)
1878         (tui_source_window_base::do_scroll_horizontal)
1879         (tui_source_window_base::set_is_exec_point_at)
1880         (tui_update_breakpoint_info, tui_set_exec_info_content)
1881         (tui_alloc_source_buffer, tui_line_is_displayed)
1882         (tui_addr_is_displayed): Update.
1883         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1884         (tui_check_and_display_highlight_if_needed)
1885         (tui_win_info::make_visible, tui_win_info::refresh)
1886         (tui_refresh_all): Update.
1887         * tui/tui-windata.c (tui_first_data_item_displayed)
1888         (tui_delete_data_content_windows, tui_erase_data_content)
1889         (tui_display_all_data, tui_data_window::refresh_all)
1890         (tui_check_data_values): Update.
1891         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1892         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1893         (tui_win_info::backward_scroll, tui_refresh_all_win)
1894         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1895         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1896         (tui_source_window_base::set_new_height)
1897         (tui_data_window::set_new_height)
1898         (make_invisible_and_set_new_height)
1899         (make_visible_with_new_height, new_height_ok)
1900         (parse_scrolling_args): Update.
1901         * tui/tui-stack.c (tui_show_frame_info): Update.
1902         * tui/tui-source.c (tui_set_source_content)
1903         (tui_set_source_content_nil, tui_source_is_displayed)
1904         (tui_source_window::do_scroll_vertical): Update.
1905         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1906         (tui_display_registers_from, tui_display_reg_element_at_line)
1907         (tui_check_register_values, tui_reg_command): Update.
1908         * tui/tui-layout.c (tui_default_win_height)
1909         (show_source_disasm_command, show_data, init_and_make_win)
1910         (show_source_or_disasm_and_command): Update.
1911         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1912         (tui_redisplay_readline, tui_mld_flush)
1913         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1914         (tui_getc): Update.
1915         * tui/tui-disasm.c (tui_set_disassem_content)
1916         (tui_disasm_window::do_scroll_vertical): Update.
1917         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1918         Now virtual.
1919         (struct tui_win_info): Derive from tui_gen_win_info.
1920         <~tui_win_info>: Mark as override.
1921         <generic>: Remove member.
1922         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1923         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1924         (~tui_data_window, ~tui_win_info)
1925         (tui_free_all_source_wins_content): Update.
1926         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-layout.c (init_and_make_win): Use new.
1931         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1932         destructor, initializers.
1933         (tui_alloc_generic_win_info): Don't declare.
1934         * tui/tui-data.c (_locator): Add argument to constructor.
1935         (source_win, disasm_win): New globals.
1936         (exec_info): Remove.
1937         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1938         Update.
1939         (tui_alloc_generic_win_info): Remove.
1940         (init_content_element): Use new.
1941         (tui_win_info::tui_win_info): Update.
1942         (free_content_elements) <case DATA_WIN>: Use delete.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1947         * tui/tui-windata.c (tui_first_data_item_displayed)
1948         (tui_delete_data_content_windows): Update.
1949         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1950         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1951         (tui_display_registers_from, tui_check_register_values): Update.
1952         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1953         pointer.
1954         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1955         window.
1956         (tui_free_data_content): Update.
1957         (free_content_elements) <case DATA_WIN>: Free the window.
1958
1959 2019-06-25  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1962         Update.
1963         * tui/tui-layout.c (make_command_window)
1964         (show_source_disasm_command, show_data, init_and_make_win)
1965         (show_source_or_disasm_and_command): Update.
1966         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1967         method.
1968         <can_highight, is_highlighted>: Now bool.
1969         (tui_set_win_highlight): Don't declare.
1970         * tui/tui-data.c (tui_set_win_highlight): Remove.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-wingeneral.c (make_visible): Remove check of window
1975         type.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-win.c (tui_win_info::max_height)
1980         (tui_cmd_window::max_height): New methods.
1981         (new_height_ok): Call max_height.
1982         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1983         <max_height>: New method.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-win.c (tui_source_window_base::set_new_height)
1988         (tui_data_window::set_new_height): New methods.
1989         (make_invisible_and_set_new_height): Call set_new_height method.
1990         * tui/tui-data.h (struct tui_win_info)
1991         (struct tui_source_window_base, struct tui_data_window)
1992         <set_new_height>: New method.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1997         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1998         tui_refresh_data_win.
1999         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2000         method.
2001         (tui_refresh_all_win): Call the refresh_all method.
2002         (tui_set_focus): Likewise.
2003         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2004         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2005         Likewise.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-winsource.h (tui_refill_source_window)
2010         (tui_set_is_exec_point_at): Don't declare.
2011         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2012         (tui_source_window_base::refill): Rename from
2013         tui_refill_source_window.
2014         (tui_source_window_base::do_scroll_horizontal): Update.
2015         (tui_source_window_base::set_is_exec_point_at): Rename from
2016         tui_set_is_exec_point_at.
2017         (tui_update_all_breakpoint_info): Update.
2018         * tui/tui-stack.c (tui_show_frame_info): Update.
2019         * tui/tui-layout.c (show_data): Add cast.
2020         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2021         * tui/tui-data.h (struct tui_source_window_base) <refill,
2022         set_is_exec_point_at>: New methods.
2023         (tui_source_windows, tui_add_to_source_windows): Update types.
2024         (tui_add_to_source_windows): Remove redundant declaration.
2025         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2026         (tui_source_windows): Change return type.
2027         (tui_clear_source_windows_detail): Update.
2028         (tui_add_to_source_windows): Change type of parameter.
2029         (tui_free_all_source_wins_content): Update.
2030
2031 2019-06-25  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-wingeneral.c (tui_win_info::refresh)
2034         (tui_source_window_base::refresh): New methods.
2035         (tui_refresh_all): Call the refresh method.
2036         * tui/tui-data.h (struct tui_win_info)
2037         (struct tui_source_window_base) <refresh>: New method.
2038
2039 2019-06-25  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui.h (tui_is_window_visible): Return bool.
2042         * tui/tui.c (tui_is_window_visible): Return bool.
2043         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2044         (tui_make_visible, tui_make_invisible)
2045         (tui_win_info::make_visible)
2046         (tui_source_window_base::make_visible, make_all_visible)
2047         (tui_make_all_visible, tui_make_all_invisible): Update.
2048         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2049         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2050         bool.
2051         (struct tui_win_info, struct tui_source_window_base)
2052         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2053         * tui/tui-data.c (tui_init_generic_part): Update.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2058         (tui_source_window_base::make_visible): New methods.
2059         (make_all_visible): Make method call.
2060         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2061         (struct tui_source_window_base, struct tui_cmd_window): Override
2062         make_visible.
2063         (tui_win_is_source_type): Don't declare.
2064         * tui/tui-data.c (tui_win_is_source_type): Remove.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2069         NULL check.
2070
2071 2019-06-25  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2074         Inline constructor.  Add initializers for members.
2075         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2076         constructors; now inline in class.
2077
2078 2019-06-25  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-regs.c (tui_show_registers): Update.
2081         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2082         bool.
2083         * tui/tui-data.c (tui_data_window::clear_detail)
2084         (tui_data_window): Update.
2085
2086 2019-06-25  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-windata.c (tui_display_all_data)
2089         (tui_display_data_from_line, tui_display_data_from)
2090         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2091         Update.
2092         * tui/tui-regs.c (tui_last_regs_line_no)
2093         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2094         (tui_show_registers, tui_show_register_group)
2095         (tui_display_registers_from, tui_display_reg_element_at_line)
2096         (tui_display_registers_from_line, tui_check_register_values)
2097         (tui_reg_next, tui_reg_prev): Update.
2098         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2099         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2100         tui_data_window.
2101         (struct tui_win_info) <detail>: Remove.  Add new fields from
2102         tui_data_info.
2103         (TUI_DATA_WIN): Add cast.
2104         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2105         (~tui_data_window): Simplify.
2106
2107 2019-06-25  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-layout.c (show_source_disasm_command)
2110         (show_source_or_disasm_and_command): Update.
2111         * tui/tui-io.c (update_cmdwin_start_line)
2112         (tui_redisplay_readline): Update.
2113         * tui/tui-data.h (struct tui_command_info): Remove.
2114         (struct tui_win_info) <detail>: Remove command_info member.
2115         (struct tui_data_window) <start_line>: New member, from
2116         tui_command_info.
2117         (TUI_CMD_WIN): Add casts.
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-winsource.c (tui_update_source_window)
2122         (tui_refill_source_window)
2123         (tui_source_window_base::do_scroll_horizontal)
2124         (tui_update_breakpoint_info, tui_set_exec_info_content)
2125         (tui_show_exec_info_content, tui_erase_exec_info_content)
2126         (tui_clear_exec_info_content): Update.
2127         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2128         Update.
2129         * tui/tui-win.c (make_invisible_and_set_new_height)
2130         (make_visible_with_new_height): Update.
2131         * tui/tui-source.c (tui_set_source_content)
2132         (tui_show_symtab_source): Update.
2133         * tui/tui-layout.c (extract_display_start_addr)
2134         (show_source_disasm_command, show_data)
2135         (make_source_or_disasm_window)
2136         (show_source_or_disasm_and_command): Update.
2137         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2138         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2139         "gdbarch".
2140         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2141         to tui_source_window_base.
2142         (struct tui_win_info) <detail>: Remove source_info member.
2143         (struct tui_source_window_base) <has_locator>: Inline.
2144         Move contents from tui_source_info; rename has_locator member to
2145         m_has_locator.
2146         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2147         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2148         header file.
2149         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2150         Simplify.
2151         (tui_free_all_source_wins_content): Cast to
2152         tui_source_window_base.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-win.c (make_invisible_and_set_new_height)
2157         (make_visible_with_new_height): Call has_locator method.
2158         * tui/tui-layout.c (show_source_disasm_command, show_data)
2159         (show_source_or_disasm_and_command): Update for bool change.
2160         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2161         (tui_win_info) <has_locator>: New method.
2162         (struct tui_source_window_base) <has_locator>: New method.
2163         (tui_win_has_locator): Don't declare.
2164         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2165         from tui_win_has_locator.
2166         (tui_source_window_base): Use false, not FALSE.
2167
2168 2019-06-25  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2171         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2172         clear_detail method directly.
2173         (tui_clear_win_detail): Remove.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2178         "this", not TUI_DISASM_WIN.
2179
2180 2019-06-25  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2183         declare.
2184         * tui/tui-winsource.c
2185         (tui_source_window_base::do_scroll_horizontal): Rename from
2186         tui_horizontal_source_scroll.
2187         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2188         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2189         from tui_vertical_data_scroll.
2190         * tui/tui-win.h (tui_scroll): Don't declare.
2191         * tui/tui-win.c (tui_win_info::forward_scroll)
2192         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2193         (tui_win_info::right_scroll): Rename and update.
2194         (tui_scroll_forward_command, tui_scroll_backward_command)
2195         (tui_scroll_left_command, tui_scroll_right_command): Update.
2196         (tui_scroll): Remove.
2197         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2198         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2199         from tui_vertical_source_scroll.
2200         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2201         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2202         from tui_vertical_disassem_scroll.
2203         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2204         do_scroll_horizontal>: New methods.
2205         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2206         Likewise.
2207         (struct tui_source_window_base): Add do_scroll_horizontal.
2208         (struct tui_source_window, struct tui_disasm_window): Add
2209         do_scroll_vertical.
2210         (struct tui_data_window, struct tui_cmd_window): Add
2211         do_scroll_horizontal and do_scroll_vertical.
2212         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-data.h (struct tui_source_window_base): New struct.
2217         (struct tui_source_window): Derive from tui_source_window_base.
2218         (struct tui_disasm_window): New struct.
2219         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2220         from tui_source_window::clear_detail.
2221         (tui_source_window_base): Rename from tui_source_window.
2222         (~tui_source_window_base): Rename from ~tui_source_window.
2223         (tui_alloc_win_info): Create a tui_disasm_window.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-data.h (struct tui_source_window)
2228         (struct tui_data_window): Declare destructors.
2229         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2230         destructors.
2231         (tui_win_info): Simplify.
2232
2233 2019-06-25  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-winsource.c (tui_display_main)
2236         (tui_update_source_windows_with_addr)
2237         (tui_update_all_breakpoint_info): Update.
2238         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2239         (new_height_ok, parse_scrolling_args): Update.
2240         * tui/tui-stack.c (tui_show_frame_info): Update.
2241         * tui/tui-data.h (struct tui_list): Remove.
2242         (tui_source_windows): Return a reference to a std::vector.
2243         * tui/tui-data.c (source_windows): Now a std::vector.
2244         (tui_source_windows): Change return type.
2245         (tui_clear_source_windows): Rewrite.
2246         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2247         (tui_free_all_source_wins_content): Rewrite.
2248
2249 2019-06-25  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2252         (struct tui_data_window, struct tui_cmd_window): Declare
2253         clear_detail method.
2254         * tui/tui-data.c (tui_source_window::clear_detail)
2255         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2256         methods.
2257         (tui_clear_win_detail): Simplify.
2258
2259 2019-06-25  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-layout.c (make_source_window, make_disasm_window)
2262         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2263         Return the new window.
2264         (show_source_disasm_command, show_data)
2265         (show_source_or_disasm_and_command): Update.
2266
2267 2019-06-25  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2270         parameter.  Return the new window.
2271         (show_source_disasm_command): Update and remove NULL check.
2272         (show_source_or_disasm_and_command): Update.
2273
2274 2019-06-25  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2277
2278 2019-06-25  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-data.h (struct tui_win_info): Make constructor
2281         protected.  Make destructor virtual.  Add initializers.
2282         (tui_source_window, tui_data_window, tui_cmd_window): New
2283         classes.
2284         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2285         constructor.  Add "type" parameter.
2286         (tui_source_window, tui_data_window, tui_cmd_window): New
2287         constructors.
2288         (tui_alloc_win_info): Instantiate the appropriate subclass.
2289
2290 2019-06-25  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-win.c (tui_resize_all): Use delete.
2293         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2294         destructor.
2295         (tui_free_window): Don't declare.
2296         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2297         Update.
2298
2299 2019-06-25  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-data.h (struct tui_win_info): Add constructor.
2302         * tui/tui-data.c (tui_alloc_win_info): Use new.
2303         (tui_free_window): Use delete.
2304
2305 2019-06-22  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2308         declare.
2309         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2310
2311 2019-06-22  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2314         declare.
2315         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2316
2317 2019-06-22  Tom de Vries  <tdevries@suse.de>
2318
2319         * dwarf2read.c (create_addrmap_from_aranges)
2320         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2321         instead of '%zu'.
2322
2323 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2324
2325         * dwarf2read.h (dwarf2_section_info_def): Remove.
2326         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2327         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2328         std::vector<dwarf2_section_info>.
2329         (struct dwo_file) <~dwo_file>: Remove.
2330         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2331         types field.
2332         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2333         (dwarf2_read_debug_names): Likewise.
2334         (create_debug_types_hash_table): Change parameter type to
2335         array_view, adjust code accordingly.
2336         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2337         (partial_die_info::fixup): Likewise.
2338         (determine_prefix): Likewise.
2339         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2340
2341 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2342
2343         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2344         gdb_bfd_ref_ptr.
2345         <~dwo_file>: Remove call to gdb_bfd_unref.
2346         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2347         gdb_bfd_ref_ptr::get.
2348
2349 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2350
2351         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2352         type to htab_up.
2353         * dwarf2read.c (struct dwo_file): Initialize fields.
2354         <~dwo_file>: New.
2355         (free_dwo_file): Remove, move content to ~dwo_file.
2356         (struct dwo_file_deleter): Remove.
2357         (dwo_file_up>: Remove custom deleter.
2358         (free_dwo_files): Remove.
2359         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2360         dwo_files.
2361         (process_skeletonless_type_units): Call unique_ptr::get.
2362         (allocate_dwo_file_hash_table): Add deleter to created hash
2363         table.  Change return type to htab_up.
2364         (lookup_dwo_file_slot): Don't memset dwo_file, call
2365         unique_ptr::get.
2366         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2367         (create_dwo_unit_in_dwp_v2): Likewise.
2368         (open_and_init_dwo_file): Likewise.
2369         (free_dwo_file_from_slot): Remove.
2370
2371 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2372
2373         * dwarf2read.h (struct dwarf2_section_info) <readin,
2374         is_virtual>: Change type to bool.
2375         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2376         true instead of 1.
2377
2378 2019-06-19  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-data.h (tui_init_content_element): Don't declare.
2381
2382 2019-06-19  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-data.h (tui_init_win_info): Don't declare.
2385
2386 2019-06-19  Tom de Vries  <tdevries@suse.de>
2387
2388         * dwarf2read.h (abstract_to_concrete): Change type to
2389         std::unordered_map<sect_offset, std::vector<sect_offset>,
2390         gdb::hash_enum<sect_offset>>.
2391
2392 2019-06-19  Tom Tromey  <tromey@adacore.com>
2393
2394         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2395         EVAL_AVOID_SIDE_EFFECTS specially.
2396
2397 2019-06-19  Tom Tromey  <tromey@adacore.com>
2398
2399         * source-cache.c (highlighter): New global.
2400         (source_cache::get_source_lines): Create a highlighter on demand.
2401
2402 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * defs.h (deprecated_interactive_hook): Delete declaration.
2405         * interps.c (clear_interpreter_hooks): Remove use of
2406         deprecated_interactive_hook.
2407         * top.c (deprecated_interactive_hook): Delete definition.
2408         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2409
2410 2019-06-18  Tom de Vries  <tdevries@suse.de>
2411
2412         PR gdb/24515
2413         * dwarf2read.h (abstract_to_concrete): Change type from
2414         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2415         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2416         * dwarf2read.c (read_variable): Update.
2417         (dwarf2_fetch_die_loc_sect_off): Update.
2418
2419 2019-06-17  Tom de Vries  <tdevries@suse.de>
2420
2421         PR gdb/24617
2422         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2423         accessing parent[parent_len - 1].
2424
2425 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2426
2427         PR gdb/24364
2428         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2429         call dtrace_process_dof with NULL dof.
2430
2431 2019-06-16  Tom de Vries  <tdevries@suse.de>
2432
2433         PR gdb/24445
2434         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2435
2436 2019-06-16  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2439         (make_all_visible): Use address of member.
2440
2441 2019-06-16  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2444         (tui_free_window, free_content, free_content_elements): Remove
2445         unnecessary cast.
2446         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2447         cast.
2448         * tui/tui-regs.c (tui_show_register_group)
2449         (tui_display_registers_from, tui_display_reg_element_at_line):
2450         Remove unnecessary cast.
2451
2452 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2453
2454         * linux-nat.c (normal_mask): Delete.
2455         (_initialize_linux_nat): Don't initialise normal_mask.
2456
2457 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2458
2459         PR gdb/24445
2460         * dwarf-index-write.h (write_psymtabs_to_index): Add
2461         dwz_basename parameter.
2462         * dwarf-index-write.c (write_gdbindex): Move file writing to
2463         write_gdbindex_1.  Change return type void.
2464         (assert_file_size): Move up, remove filename parameter.
2465         (write_gdbindex_1): New function.
2466         (write_debug_names): Change return type to void, call
2467         assert_file_size.
2468         (struct index_wip_file): New struct.
2469         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2470         file logic to index_wip_file.  Write index for dwz file if
2471         needed.
2472         (save_gdb_index_command): Pass basename of dwz file, if present.
2473         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2474         build-id of dwz file, if present.
2475         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2476         (dwarf2_get_dwz_file): Likewise.
2477         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2478         (dwarf2_get_dwz_file): Likewise.
2479
2480 2019-06-16  Tom Tromey  <tom@tromey.com>
2481
2482         * coffread.c (process_coff_symbol): Use xstrdup.
2483         * value.c (create_internalvar): Use xstrdup.
2484
2485 2019-06-16  Tom Tromey  <tom@tromey.com>
2486
2487         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2488         * breakpoint.c (stopin_command, stopat_command)
2489         (until_break_command, decode_location_default): Remove unnecessary
2490         cast.
2491         * utils.c (subset_compare): Remove unnecessary cast.
2492         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2493         cast.
2494         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2495         cast.
2496         * infcmd.c (path_command): Remove unnecessary cast.
2497         * coffread.c (decode_type): Remove unnecessary cast.
2498         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2499         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2500         * tui/tui-stack.c (tui_show_locator_content)
2501         (tui_show_frame_info): Remove unnecessary cast.
2502         * tui/tui-win.c (tui_scroll_forward_command)
2503         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2504         (parse_scrolling_args): Remove unnecessary cast.
2505         * tui/tui-data.c (init_win_info, tui_del_window)
2506         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2507         (free_content_elements): Remove unnecessary cast.
2508         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2509         unnecessary cast.
2510         * tui/tui-source.c (tui_set_source_content)
2511         (tui_vertical_source_scroll): Remove unnecessary cast.
2512         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2513         cast.
2514         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2515         * tui/tui-regs.c (tui_display_registers_from)
2516         (tui_display_register): Remove unnecessary cast.
2517         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2518         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2519         (make_visible): Remove unnecessary cast.
2520         * tui/tui-winsource.c (tui_erase_source_content)
2521         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2522         unnecessary cast.
2523         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2524         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2525         * stabsread.c (read_type, read_array_type, read_range_type):
2526         Remove unnecessary cast.
2527         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2528         (parse_symbol, parse_type, upgrade_type, parse_external)
2529         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2530         unnecessary cast.
2531         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2532
2533 2019-06-16  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-data.c (tui_alloc_generic_win_info)
2536         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2537         checks.
2538
2539 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2540             Andrew Burgess  <andrew.burgess@embecosm.com>
2541
2542         * f-typeprint.c (f_print_type): Don't return early for not
2543         associated or not allocated types.
2544         (f_type_print_varspec_suffix): Add print_rank parameter and print
2545         ranks of array types in case they dangling.
2546         (f_type_print_base): Add print_rank parameter.
2547
2548 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * NEWS: Mention new MI commands.
2551         * break-catch-throw.c (enum exception_event_kind): Move to
2552         breakpoint.h.
2553         (print_mention_exception_catchpoint): Output text as a single
2554         message.
2555         (catch_exception_command_1): Rename to...
2556         (catch_exception_event): ...this, make non-static, update header
2557         command, and change some parameter types.
2558         (catch_catch_command): Update for changes to
2559         catch_exception_command_1.
2560         (catch_throw_command): Likewise.
2561         (catch_rethrow_command): Likewise.
2562         * breakpoint.c (enum exception_event_kind): Delete.
2563         * breakpoint.h (enum exception_event_kind): Moved here from
2564         break-catch-throw.c.
2565         (catch_exception_event): Declare.
2566         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2567         (mi_cmd_catch_throw): New function.
2568         (mi_cmd_catch_rethrow): New function.
2569         (mi_cmd_catch_catch): New function.
2570         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2571         'catch-catch' entries.
2572         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2573         (mi_cmd_catch_rethrow): Declare.
2574         (mi_cmd_catch_catch): Declare.
2575
2576 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * annotate.c (annotate_source_line): Change return type to void,
2579         update implementation to match.
2580         * annotate.h (annotate_source_line): Change return type to void,
2581         update header comment.
2582         * stack.c (print_frame_info): Don't change what frame information
2583         is printed based on whether annotations are on or not.
2584
2585 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2588         (annotate_source): Make static.
2589         (annotate_source_line): Moved from source.c and renamed from
2590         identify_source_line.  Update the return type.
2591         * annotate.h (annotate_source): Delete declaration.
2592         (annotate_source_line): Declaration moved from source.h, and
2593         renamed from identify_source_line.  Return type updated.
2594         * source.c (identify_source_line): Moved to annotate.c and renamed
2595         to annotate_source_line.
2596         (info_line_command): Remove check of annotation_level.
2597         * source.h (identify_source_line): Move declaration to annotate.h
2598         and rename to annotate_source_line.
2599         * stack.c: Add 'annotate.h' include.
2600         (print_frame_info): Remove check of annotation_level before
2601         calling annotate_source_line.
2602
2603 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2604
2605         * source-cache.c (source_cache::get_plain_source_lines): Use
2606         open_source_file_with_line_charpos instead of just
2607         open_source_file, remove call to find_source_lines.
2608         (source_cache::get_source_lines): Likewise.
2609         * source.c (find_source_lines): Make static.
2610         (get_filename_and_charpos): Renamed into...
2611         (open_source_file_with_line_charpos): ..this along with changes to
2612         return a scoped_fd, and some other minor clean ups.
2613         (identify_source_line): Use open_source_file_with_line_charpos.
2614         (search_command_helper): Use open_source_file_with_line_charpos
2615         instead of just open_source_file, remove call to
2616         find_source_lines.
2617         * source.h (open_source_file_with_line_charpos): Declare new
2618         function.
2619         (find_source_lines): Delete declaration.
2620
2621 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2622
2623         * source.c (get_filename_and_charpos): Remove fullname
2624         parameter.
2625         (identify_source_line): Update call to get_filename_and_charpos.
2626
2627 2019-06-14  Tom Tromey  <tromey@adacore.com>
2628
2629         PR gdb/24502:
2630         * ui-style.h (skip_ansi_escape): Update comment.
2631         * ui-file.h (class no_terminal_escape_file): New class.
2632         * ui-file.c (no_terminal_escape_file::write)
2633         (no_terminal_escape_file::puts): New methods.
2634         * cli/cli-logging.c (handle_redirections): Use
2635         no_terminal_escape_file.
2636
2637 2019-06-14  Tom Tromey  <tromey@adacore.com>
2638
2639         * NEWS: Move convenience variable news above Python news.
2640
2641 2019-06-14  Tom Tromey  <tom@tromey.com>
2642
2643         * gnulib: Move directory to top-level.
2644         * configure.ac: Don't configure gnulib.
2645         * configure: Rebuild.
2646         * common/common-defs.h: Use new path to gnulib.
2647         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2648         (GNULIB_H): Remove.
2649         (INCGNU): Look in new gnulib location.
2650         (HFILES_NO_SRCDIR): Remove gnulib files.
2651         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2652         (generated_files): Remove GNULIB_H.
2653         ($(LIBGNU), all-lib): Remove targets.
2654         (distclean): Don't mention GNULIB_BUILDDIR.
2655         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2656
2657 2019-06-14  Tom Tromey  <tromey@adacore.com>
2658
2659         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2660         Warn if symbol file does not provide any symbols.
2661
2662 2019-06-14  Tom Tromey  <tromey@adacore.com>
2663
2664         * source.c (find_and_open_source): Respect basenames_may_differ.
2665
2666 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * annotate.c (annotate_breakpoints_invalid): Make use of
2669         scoped_restore_terminal_state.
2670         (annotate_frames_invalid): Likewise.
2671
2672 2019-06-14  Tom Tromey  <tromey@adacore.com>
2673
2674         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2675         allow assignment to an internalvar.
2676
2677 2019-06-14  Tom Tromey  <tromey@adacore.com>
2678
2679         * ada-lex.l: Allow "_" in attribute names.
2680
2681 2019-06-14  Tom Tromey  <tromey@adacore.com>
2682
2683         PR gdb/24653:
2684         * regcache.c (registers_changed): Don't call alloca.
2685         * top.c (execute_command): Don't call alloca.
2686
2687 2019-06-13  Pedro Alves  <palves@redhat.com>
2688
2689         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2690         'expression'.  When parsing an expression, error out if there's
2691         junk after "unlimited".
2692         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2693         (do_set_command): Adjust calls to is_unlimited_literal.
2694
2695 2019-06-13  Pedro Alves  <palves@redhat.com>
2696
2697         * compile/compile.c (make_compile_options_def_group): Add braces
2698         around array_view initializer.
2699         * thread.c (make_thread_apply_all_options_def_group)
2700         (make_thread_apply_all_options_def_group): Likewise.
2701
2702 2019-06-13  Pedro Alves  <palves@redhat.com>
2703
2704         * NEWS (New commands): Mention "maint test-options
2705         require-delimiter", "maint test-options unknown-is-error", "maint
2706         test-options unknown-is-operand" and "maint show
2707         test-options-completion-result".
2708         (New command options, command completion): New section.
2709         (Completion improvements): New section.
2710         Mention that you can abbreviate "unlimited".
2711
2712 2019-06-13  Pedro Alves  <palves@redhat.com>
2713
2714         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2715         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2716         * unittests/cli-utils-selftests.c (test_parse_flags)
2717         (test_parse_flags_qcs): Delete.
2718         (test_cli_utils): Don't call deleted functions.
2719
2720 2019-06-13  Pedro Alves  <palves@redhat.com>
2721
2722         * thread.c: Include "cli/cli-option.h".
2723         (tp_array_compar_ascending): Global.
2724         (tp_array_compar): Delete function.
2725         (tp_array_compar_ascending, tp_array_compar_descending): New
2726         functions.
2727         (ascending_option_def, qcs_flag_option_def)
2728         (thr_qcs_flags_option_defs)
2729         (make_thread_apply_all_options_def_group)
2730         (make_thread_apply_options_def_group): New.
2731         (thread_apply_all_command): Use gdb::option::process_options.
2732         (thread_apply_command_completer)
2733         (thread_apply_all_command_completer): New.
2734         (thread_apply_command): Use gdb::option::process_options.
2735         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2736         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2737         to generate help text of "thread apply".  Adjust "taas"'s help.
2738         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2739         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2740
2741 2019-06-13  Pedro Alves  <palves@redhat.com>
2742
2743         * thread.c (thread_apply_command): Check for invalid TID with
2744         isdigit instead of !isalpha.
2745
2746 2019-06-13  Pedro Alves  <palves@redhat.com>
2747
2748         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2749         (validate_flags_qcs): New.
2750         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2751         (validate_flags_qcs): Declare.
2752         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2753         (make_frame_apply_options_def_group): New.
2754         (frame_apply_command_count): Process options with
2755         gdb::option::process_options.
2756         (frame_apply_completer): New.
2757         (frame_apply_level_completer, frame_apply_all_completer)
2758         (frame_apply_completer): New.
2759         (_initialize_stack): Update help of "frame apply", "frame apply
2760         level", "frame apply all" and "faas" to mention supported options
2761         and install command completers.
2762         * stack.h (frame_apply_all_completer): Declare.
2763         * thread.c: Include "stack.h".
2764         (tfaas_command): Add "--".
2765         (_initialize_thread): Update help "tfaas" to mention supported
2766         options and install command completer.
2767
2768 2019-06-13  Pedro Alves  <palves@redhat.com>
2769
2770         * completer.c (complete_nested_command_line): New.
2771         (gdb_completion_word_break_characters_throw): Add assertion.
2772         * completer.h (complete_nested_command_line): Declare.
2773
2774 2019-06-13  Pedro Alves  <palves@redhat.com>
2775
2776         * stack.c (parse_backtrace_qualifiers): New.
2777         (backtrace_command): Use it.
2778         (backtrace_command_completer): Complete on qualifiers.
2779
2780 2019-06-13  Pedro Alves  <palves@redhat.com>
2781
2782         * frame.c: Include "cli/cli-option.h.
2783         (user_set_backtrace_options): New.
2784         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2785         Delete.
2786         (get_prev_frame): Adjust.
2787         (boolean_option_def, uinteger_option_def)
2788         (set_backtrace_option_defs): New.
2789         (_initialize_frame): Adjust and use
2790         gdb::option::add_setshow_cmds_for_options to install "set
2791         backtrace past-main" and "set backtrace past-entry".
2792         * frame.h: Include "cli/cli-option.h".
2793         (struct frame_print_options): Forward declare.
2794         (print_frame_arguments_all, print_frame_arguments_scalars)
2795         (print_frame_arguments_none): Declare.
2796         (print_entry_values): Delete declaration.
2797         (struct frame_print_options, user_frame_print_options): New.
2798         (struct set_backtrace_options): New.
2799         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2800         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2801         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2802         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2803         (list_args_or_locals): Add frame_print_options parameter.
2804         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2805         * python/py-framefilter.c (enumerate_args): Pass down
2806         USER_FRAME_PRINT_OPTIONS.
2807         * stack.c: Include "cli/cli-option.h".
2808         (print_frame_arguments_all, print_frame_arguments_scalars)
2809         (print_frame_arguments_none): Declare.
2810         (print_raw_frame_arguments, print_entry_values): Delete.
2811         (user_frame_print_options): New.
2812         (boolean_option_def, enum_option_def, frame_print_option_defs):
2813         New.
2814         (struct backtrace_cmd_options): New.
2815         (bt_flag_option_def): New.
2816         (backtrace_command_option_defs): New.
2817         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2818         (print_frame_arg, read_frame_arg, print_frame_args)
2819         (print_frame_info, print_frame): Add frame_print_options parameter
2820         and use it.
2821         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2822         (backtrace_command_1): Add frame_print_options and
2823         backtrace_cmd_options parameters and use them.
2824         (make_backtrace_options_def_group): New.
2825         (backtrace_command): Process command options with
2826         gdb::option::process_options.
2827         (backtrace_command_completer): New.
2828         (_initialize_stack): Extend "backtrace"'s help to mention
2829         supported options.  Install completer for "backtrace".
2830         Install some settings commands with add_setshow_cmds_for_options.
2831
2832 2019-06-13  Pedro Alves  <palves@redhat.com>
2833
2834         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2835         and that "set/show print raw frame-arguments" are now deprecated.
2836
2837         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2838         command.
2839         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2840         * stack.c (_initialize_stack): Install "set/show print
2841         raw-frame-arguments", and deprecate "set/show print raw
2842         frame-arguments".
2843         * valprint.c (_initialize_valprint): Deprecate "set/show print
2844         raw".
2845
2846 2019-06-13  Pedro Alves  <palves@redhat.com>
2847
2848         * compile/compile.c (struct compile_options): New.
2849         (compile_flag_option_def, compile_command_option_defs)
2850         (make_compile_options_def_group): New.
2851         (compile_file_command): Handle options with
2852         gdb::option::process_options.
2853         (compile_file_command_completer): New function.
2854         (compile_code_command): Handle options with
2855         gdb::option::process_options.
2856         (compile_code_command_completer): New function.
2857         (_initialize_compiler): Install completers for "compile code" and
2858         "compile file".  Mention available options in "compile code" and
2859         "compile code"'s help.
2860         * completer.c (advance_to_completion_word): New, factored out from
2861         ...
2862         (advance_to_expression_complete_word_point): ... this.
2863         (advance_to_filename_complete_word_point): New.
2864         * completer.h (advance_to_filename_complete_word_point): New
2865         declaration.
2866
2867 2019-06-13  Pedro Alves  <palves@redhat.com>
2868
2869         * compile/compile.c: Include "cli/cli-option.h".
2870         (compile_print_value): Scope data pointer is now a
2871         value_print_options pointer; adjust.
2872         (compile_print_command): Process options.  Scope data pointer is
2873         now a value_print_options pointer; adjust.
2874         (_initialize_compile): Update "compile print"'s help to include
2875         supported options.  Install a completer for "compile print".
2876         * cp-valprint.c (show_vtblprint, show_objectprint)
2877         (show_static_field_print): Delete.
2878         (_initialize_cp_valprint): Don't install "set print
2879         static-members", "set print vtbl", "set print object" here.
2880         * printcmd.c: Include "cli/cli-option.h" and
2881         "common/gdb_optional.h".
2882         (print_command_parse_format): Rework to fill in a
2883         value_print_options instead of a format_data.
2884         (print_value): Change parameter type from format_data pointer to
2885         value_print_options reference.  Adjust.
2886         (print_command_1): Process options.  Adjust to pass down a
2887         value_print_options.
2888         (print_command_completer): New.
2889         (_initialize_printcmd): Install print_command_completer as
2890         handle_brkchars completer for the "print" command.  Update
2891         "print"'s help to include supported options.
2892         * valprint.c: Include "cli/cli-option.h".
2893         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2894         here from cp-valprint.c.
2895         (boolean_option_def, uinteger_option_def)
2896         (value_print_option_defs, make_value_print_options_def_group):
2897         New.  Use gdb::option::add_setshow_cmds_for_options to install
2898         "set print elements", "set print null-stop", "set print repeats",
2899         "set print pretty", "set print union", "set print array", "set
2900         print address", "set print symbol", "set print array-indexes".
2901         * valprint.h: Include <string> and "cli/cli-option.h".
2902         (make_value_print_options_def_group): Declare.
2903         (print_value): Change parameter type from format_data pointer to
2904         value_print_options reference.
2905         (print_command_completer): Declare.
2906
2907 2019-06-13  Pedro Alves  <palves@redhat.com>
2908
2909         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2910         (COMMON_SFILES): Add maint-test-settings.c.
2911         * cli/cli-decode.c (boolean_enums): New global, factored out from
2912         ...
2913         (add_setshow_boolean_cmd): ... here.
2914         * cli/cli-decode.h (boolean_enums): Declare.
2915         * cli/cli-option.c: New file.
2916         * cli/cli-option.h: New file.
2917         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2918         factored out from ...
2919         (parse_cli_boolean_value(const char *)): ... this.
2920         (is_unlimited_literal): Change parameter type to pointer to
2921         pointer.  Adjust and advance ARG pointer.
2922         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2923         (parse_cli_var_enum): New, factored out from ...
2924         (do_set_command): ... this.  Adjust.
2925         * cli/cli-setshow.h (parse_cli_boolean_value)
2926         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2927         (parse_cli_var_enum): Declare.
2928         * cli/cli-utils.c: Include "cli/cli-option.h".
2929         (get_ulongest): New.
2930         * cli/cli-utils.h (get_ulongest): Declare.
2931         (check_for_argument): New overloads.
2932         * maint-test-options.c: New file.
2933
2934 2019-06-13  Pedro Alves  <palves@redhat.com>
2935
2936         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2937         parse a range if "-" is at the end of the string.
2938
2939 2019-06-13  Pedro Alves  <palves@redhat.com>
2940
2941         * cli/cli-setshow.c (parse_auto_binary_operation)
2942         (parse_cli_boolean_value): Don't allow "o".
2943
2944 2019-06-13  Pedro Alves  <palves@redhat.com>
2945
2946         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2947         * NEWS: Mention maint test-settings KIND.
2948         * maint-test-settings.c: New file.
2949
2950 2019-06-13  Pedro Alves  <palves@redhat.com>
2951
2952         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2953         completer.
2954         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2955         "set" completers.
2956
2957 2019-06-13  Pedro Alves  <palves@redhat.com>
2958
2959         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2960         after item.
2961
2962 2019-06-13  Pedro Alves  <palves@redhat.com>
2963
2964         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2965
2966 2019-06-13  Pedro Alves <palves@redhat.com>
2967
2968         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2969         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2970         call.
2971         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2972         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2973         calls.
2974         (check_for_argument): Skip spaces after argument.
2975
2976 2019-06-13  Pedro Alves  <palves@redhat.com>
2977
2978         * thread.c (thread_apply_command): Adjust TID parsing.
2979         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2980         detected before end of string.
2981         (tid_is_in_list): Error out if LIST is invalid.
2982
2983 2019-06-13  Pedro Alves  <palves@redhat.com>
2984
2985         * completer.c (complete_line_internal_1): Rewind completion word
2986         point.
2987         (completion_tracker::advance_custom_word_point_by): Change
2988         parameter type to int.
2989         * completer.h (completion_tracker::advance_custom_word_point_by):
2990         Likewise.
2991
2992 2019-06-13  Pedro Alves  <palves@redhat.com>
2993
2994         * completer.c (advance_to_completion_word): Handle delimiters.
2995
2996 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2997
2998         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2999
3000 2019-06-11  Tom Tromey  <tom@tromey.com>
3001
3002         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3003         (xmalloc_failed): Move to alloc.c.
3004         * alloc.c: New file.
3005         * Makefile.in (COMMON_SFILES): Add alloc.c.
3006
3007 2019-06-11  Tom Tromey  <tom@tromey.com>
3008
3009         * nat/linux-waitpid.c: Don't include server.h.
3010         (linux_debug): Remove.
3011         (my_waitpid): Update.
3012
3013 2019-06-11  Tom Tromey  <tromey@adacore.com>
3014
3015         * infcall.c (_initialize_infcall): Remove trailing newline from
3016         help.
3017         * user-regs.c (_initialize_user_regs): Remove trailing newline
3018         from help.
3019         * typeprint.c (_initialize_typeprint): Remove trailing newline
3020         from help.
3021         * reverse.c (_initialize_reverse): Remove trailing newlines from
3022         help.
3023         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3024         from help.
3025         * language.c (add_set_language_command): Remove trailing newline
3026         from help.
3027         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3028         help.
3029         * disasm.c (_initialize_disasm): Remove trailing newline from
3030         help.
3031         * top.c (init_main): Remove trailing newline from help.
3032         * interps.c (_initialize_interpreter): Remove trailing newline
3033         from help.
3034         * btrace.c (_initialize_btrace): Remove trailing newlines from
3035         help.
3036         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3037         from help.
3038         * python/python.c (_initialize_python): Remove trailing newline
3039         from help.
3040         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3041         help.
3042         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3043         from help.  Reformat some text.
3044         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3045         from help.
3046         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3047         newline from help.
3048
3049 2019-06-11  Tom Tromey  <tromey@adacore.com>
3050
3051         * darwin-nat.c (darwin_decode_exception_message)
3052         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3053
3054 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3055
3056         * valops.c (value_slice): Check for not allocated or not
3057         associated values.
3058
3059 2019-06-10  Tom de Vries  <tdevries@suse.de>
3060
3061         PR gdb/24618
3062         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3063         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3064         invalid.
3065
3066 2019-06-10  Tom de Vries  <tdevries@suse.de>
3067
3068         PR gdb/24611
3069         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3070         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3071
3072 2019-06-10  Tom de Vries  <tdevries@suse.de>
3073
3074         PR symtab/24545
3075         * symtab.c (struct demangled_name_entry): Add language field.
3076         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3077         static minimal symbol".  Set and use language field.
3078
3079 2019-06-10  Tom Tromey  <tromey@adacore.com>
3080
3081         * ada-lang.c (_initialize_ada_language): Update help text.
3082
3083 2019-06-10  Tom Tromey  <tromey@adacore.com>
3084
3085         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3086         with a newline.
3087         * guile/guile.c (handle_boot_error): Don't end warning with a
3088         newline.
3089         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3090         warning with a newline.
3091         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3092         newline.
3093         (s12z_frame_cache): Likewise.
3094         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3095         a newline.
3096         * solib-svr4.c (disable_probes_interface): Don't end warning with
3097         a newline.
3098         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3099         newline.
3100         * python/python.c (do_finish_initialization): Don't end warning
3101         with a newline.
3102
3103 2019-06-10  Tom Tromey  <tom@tromey.com>
3104
3105         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3106         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3107         gdbpy_enter.
3108
3109 2019-06-10  Tom Tromey  <tromey@adacore.com>
3110
3111         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3112         data.
3113         (elf_new_init): Don't call stabsread_new_init.
3114         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3115         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3116         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3117
3118 2019-06-10  Tom de Vries  <tdevries@suse.de>
3119
3120         PR symtab/16264
3121         PR symtab/24517
3122         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3123
3124 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3125
3126         * source.c (find_and_open_source): Also rewrite relative file
3127         names.
3128
3129 2019-04-26  Amos Bird  <amosbird@gmail.com>
3130
3131         * annotate.c (annotate_thread_exited): Add "thread-exited"
3132         annotation.
3133
3134 2019-06-06  Tom Tromey  <tromey@adacore.com>
3135
3136         * maint.h (class scoped_command_stats): Use
3137         DISABLE_COPY_AND_ASSIGN.
3138         <print_time>: New method.
3139         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3140         print_time.
3141         (scoped_command_stats::print_time): New method.
3142
3143 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3146         instructions of lengths 6 or 8 bytes.
3147
3148 2019-06-04  Pedro Alves  <palves@redhat.com>
3149
3150         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3151
3152         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3153         * breakpoint.c (condition_completer): Likewise.
3154         * cli/cli-dump.c (scan_expression): Likewise.
3155         * common/filestuff.c (mkdir_recursive): Likewise.
3156         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3157         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3158         (gdb_abspath): Likewise.
3159         * compile/compile-cplus-types.c
3160         (compile_cplus_instance::decl_name): Likewise.
3161         * completer.c (complete_explicit_location):
3162         (signal_completer, reg_or_group_completer_1): Likewise.
3163         * cp-support.c (cp_remove_params_if_any): Likewise.
3164         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3165         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3166         * infcmd.c (strip_bg_char): Likewise.
3167         * linespec.c (copy_token_string): Likewise.
3168         * mi/mi-main.c (output_cores): Likewise.
3169         * psymtab.c (psymtab_search_name):
3170         * symfile.c (test_set_ext_lang_command): Likewise.
3171         * target.c (target_fileio_read_stralloc): Likewise.
3172         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3173         * value.c (complete_internalvar): Likewise.
3174
3175 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3176
3177         Add objfile property to gdb.Type.
3178         * NEWS: Mention Python API addition.
3179         * python/py-type.c (typy_get_objfile): New method.
3180
3181 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3182
3183         * NEWS: Mention the new set|show style [title|highlight].
3184         Mention changes to "show style", "help" and "apropos".
3185
3186 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3187
3188         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3189         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3190         instead of print_help_for_command.
3191         (print_doc_of_command): New function.
3192         (help_list): Add 'apropos -v word' suggestion.
3193         (print_help_for_command): Style the command name using title style.
3194         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3195         (_initialize_cli_cmds): Describe -v in apropos_command help.
3196
3197 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3198
3199         * cli/cli-style.h (cli_style_option): Add name in constructor,
3200         add m_name class member, add constructor with intensity,
3201         add name class function.
3202         (cli_style_option::add_setshow_commands): Remove name argument.
3203         (highlight_style, title_style): New styles.
3204         * cli/cli-style.c (do_show): New function that shows a style
3205         characteristic styling the style name with itself.
3206         (set_style_name): New function.
3207         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3208         Update all callers according to the changes in cli/cli-style.h.
3209         * utils.h (fputs_highlighted): New function.
3210         * utils.c (fputs_highlighted): Likewise.
3211
3212 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3213
3214         * NEWS: Mention new pipe command and new convenience variables.
3215
3216 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3217
3218         * cli/cli-cmds.c (pipe_command): New function.
3219         (_initialize_cli_cmds): Call add_com for pipe_command.
3220         Define | as an alias for pipe.
3221         (exit_status_set_internal_vars): New function.
3222         (shell_escape): Call exit_status_set_internal_vars.
3223         cli/cli-decode.c (find_command_name_length): Recognize | as
3224         a single character command.
3225
3226 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3227
3228         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3229         top.c (execute_command_to_ui_file): New function, mostly a copy
3230         of execute_command_to_string.
3231         (execute_command_to_string): Implement by calling
3232         execute_command_to_ui_file.
3233
3234 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3235
3236         * top.h (saved_command_line): Remove declaration.
3237         * top.c (previous_saved_command_line, previous_repeat_arguments):
3238         New variables.
3239         (saved_command_line): Make static, define together with other
3240         'repeat variables'.
3241         (dont_repeat): Clear repeat_arguments.
3242         (repeat_previous, get_saved_command_line, save_command_line):
3243         New functions.
3244         (gdb_init): Initialize saved_command_line
3245         and previous_saved_command_line.
3246         * main.c (captured_main_1): Remove saved_command_line initialization.
3247         * event-top.c (handle_line_of_input): Update to use
3248         the new 'repeat' related functions instead of direct access to
3249         saved_command_line.
3250         * command.h (repeat_previous, get_saved_command_line,
3251         save_command_line): New declarations.
3252         (dont_repeat): Add comment.
3253
3254 2019-05-30  Tom Tromey  <tromey@adacore.com>
3255
3256         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3257         Fix comment.
3258         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3259
3260 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3261
3262         PR cli/24587
3263         * completer.c (complete): Initialize variable word.
3264
3265 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3266
3267         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3268         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3269         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3270         'body' is NULL to the outter 'if', protecting the '!is_define'
3271         situation as well.
3272
3273 2019-05-29  Tom Tromey  <tromey@adacore.com>
3274
3275         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3276         (dwarf_unknown): New function.
3277         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3278         (dwarf_type_encoding_name): Use dwarf_unknown.
3279
3280 2019-05-29  Tom Tromey  <tromey@adacore.com>
3281
3282         PR c++/20020:
3283         * cp-valprint.c (cp_print_value_fields): Call
3284         cp_print_static_field inside "try".
3285
3286 2019-05-29  Tom Tromey  <tromey@adacore.com>
3287
3288         * inflow.c (struct terminal_info): Add default operator=.
3289         * configure: Rebuild.
3290         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3291         -Wdeprecated-copy-dtor, -Wredundant-move.
3292
3293 2019-05-29  Tom Tromey  <tromey@adacore.com>
3294
3295         * NEWS: Add entry.
3296         * infcmd.c (print_return_value_1): Handle finish_print
3297         option.
3298         (show_print_finish): New function.
3299         (_initialize_infcmd): Add "set/show print finish" commands.
3300         * valprint.c (user_print_options): Initialize new member.
3301         * valprint.h (struct value_print_options) <finish_print>: New
3302         member.
3303
3304 2019-05-28  Tom Tromey  <tromey@adacore.com>
3305
3306         * ada-lang.c (ada_remove_Xbn_suffix)
3307         (find_old_style_renaming_symbol)
3308         (parse_old_style_renaming): Remove.
3309         (ada_find_renaming_symbol): Don't call
3310         find_old_style_renaming_symbol.
3311         (ada_is_renaming_symbol): Rename from
3312         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3313         bool.  Now static.
3314         (ada_read_var_value): Update and simplify.
3315         * ada-exp.y (write_var_or_type): Remove old code.
3316
3317 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3318
3319         * event-top.c: Remove include comment.
3320         * inflow.c (class scoped_ignore_sigttou): Move from here...
3321         * inflow.h (class scoped_ignore_sigttou): ...to here.
3322         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3323         * top.c:  Remove include comment.
3324
3325 2019-05-27  Tom Tromey  <tom@tromey.com>
3326
3327         * NEWS: Fix typo.
3328
3329 2019-05-22  Tom Tromey  <tromey@adacore.com>
3330
3331         * target.c (target_follow_exec): Constify parameter.
3332         * target-delegates.c: Rebuild.
3333         * remote.c (remote_target::follow_exec): Constify parameter.
3334         * infrun.c (follow_exec): Constify parameter.
3335         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3336         (target_follow_exec): Likewise.
3337
3338 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3339
3340         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3341         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3342
3343 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3344
3345         * NEWS: Add debugredirect and testsuite sections.
3346
3347 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3348
3349         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3350         target descriptions using exclusively floating point register name
3351         aliases.
3352
3353 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3354
3355         PR gdb/18644:
3356         * f-lang.c (build_fortran_types): Handle the case where
3357         gdbarch_floatformat_for_type returns a nullptr.
3358
3359 2019-05-21  Tom de Vries  <tdevries@suse.de>
3360
3361         PR cli/24587
3362         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3363
3364 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3365
3366         PR gdb/18644:
3367         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3368         16-byte floats.
3369         * i386-tdep.c (i386_floatformat_for_type): Use
3370         floatformats_ia64_quad for the 16-byte floating point component
3371         within a fortran 32-byte complex number.
3372
3373 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3374
3375         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3376         delete default constructor.
3377         (find_partial_die): Update to return const struct.
3378         (partial_die_parent_scope): Move variable declaration into scope
3379         of its use and change its type to auto.
3380         (guess_partial_die_structure_name): Likewise.
3381         (partial_die_info::fixup): Likewise.
3382
3383 2019-05-17  Tom Tromey  <tromey@adacore.com>
3384
3385         * source.c (find_and_open_source): Remove cast.
3386
3387 2019-05-17  Tom Tromey  <tromey@adacore.com>
3388
3389         * annotate.c (annotate_source): Make "filename" const.
3390         * annotate.h (annotate_source): Use const.
3391
3392 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3393
3394         * disasm.c (set_disassembler_options): Send errors to stderr.
3395
3396 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3397
3398         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3399         (cli_interp_base::set_logging): Check debug_redirect.
3400         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3401         * cli/cli-logging.c (debug_redirect): Add static variable.
3402         (pop_output_files): Add default param.
3403         (handle_redirections): Print debug setting.
3404         (show_logging_command): Likewise.
3405         (_initialize_cli_logging): Add debugredirect command.
3406         * interps.c (current_interp_set_logging): Add debug_redirect
3407         parameter.
3408         * interps.h (set_logging): Add debug_redirect parameter.
3409         (current_interp_set_logging): Likewise.
3410         * mi/mi-common.h: Likewise.
3411         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3412
3413 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3414             Tom Tromey  <tromey@adacore.com>
3415
3416         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3417         directly.
3418         * cli/cli-interp.h (make_logging_output): Remove declaration.
3419         * cli/cli-logging.c (make_logging_output): Remove function.
3420         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3421         directly.
3422         * ui-file.c (tee_file::tee_file): Remove bools.
3423         (tee_file::~tee_file): Remove deletes.
3424         * ui-file.h (tee_file): Remove bools.
3425
3426 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3427
3428         * mi/mi-cmds.h (mi_cmd_complete): New function.
3429         * mi/mi-main.c (mi_cmd_complete): Likewise.
3430         * mi/mi-cmds.c: Define new MI command -complete.
3431         * NEWS: Mention new -complete command.
3432
3433 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3434
3435         * completer.h (complete): New function.
3436         * completer.c (complete): Likewise.
3437         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3438         function defined in completer.h.
3439
3440 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3441
3442         * MAINTAINERS (Write After Approval): Add myself.
3443
3444 2019-05-17  Tom de Vries  <tdevries@suse.de>
3445
3446         PR gdb/24094
3447         * dwarf2read.c (struct cu_partial_die_info): New struct.
3448         (find_partial_die): Return cu_partial_die_info.
3449         (partial_die_parent_scope, guess_partial_die_structure_name)
3450         (partial_die_info::fixup): Handle new return type of find_partial_die.
3451
3452 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3453
3454         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3455         "std::string", simplifying the algorithm.
3456
3457 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3458
3459         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3460         (stap_static_probe_ops::get_probes): Likewise.
3461
3462 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3463
3464         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3465         '-')" and "else if".
3466         (stap_parse_single_operand): Join checks for
3467         "gdbarch_stap_parse_special_token_p" and
3468         "gdbarch_stap_parse_special_token" in the same "if" statement.
3469         Invert check when verifying for operation on register
3470         displacement.
3471
3472 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3473
3474         * stap-probe.c (stap_get_opcode): Update comment.
3475         (stap_get_expected_argument_type): Likewise.
3476         (handle_stap_probe): Likewise.
3477
3478 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3479
3480         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3481         return type to 'bool'.  Adjust comment.  Use 'bool' when
3482         appropriate.
3483         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3484         * stap-probe.c (stap_parse_argument_1): Likewise.
3485         (stap_is_operator): Likewise.
3486         (stap_is_generic_prefix): Likewise.
3487         (stap_is_register_prefix): Likewise.
3488         (stap_is_register_indirection_prefix): Likewise.
3489         (stap_is_integer_prefix): Likewise.
3490         (stap_generic_check_suffix): Likewise.
3491         (stap_check_integer_suffix): Likewise.
3492         (stap_check_register_suffix): Likewise.
3493         (stap_check_register_indirection_suffix): Likewise.
3494         (stap_parse_register_operand): Likewise.
3495         (stap_parse_single_operand): Likewise.
3496         (stap_parse_argument_1): Likewise.
3497         (stap_probe::get_argument_count): Likewise.
3498         (stap_is_operator): Likewise.
3499
3500 2019-05-16  Tom Tromey  <tromey@adacore.com>
3501
3502         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3503         keyword to foreach.
3504
3505 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3506
3507         * linux-thread-db.c (try_thread_db_load_1): Change return type
3508         to bool.
3509         (try_thread_db_load): Likewise.
3510         (try_thread_db_load_from_pdir_1): Likewise.
3511         (try_thread_db_load_from_pdir): Likewise.
3512         (try_thread_db_load_from_sdir): Likewise.
3513         (try_thread_db_load_from_dir): Likewise.
3514         (thread_db_load_search): Likewise.
3515         (has_libpthread): Likewise.
3516         (thread_db_load): Likewise.
3517
3518 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3519
3520         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3521         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3522         NULL, and complain/return if that's the case.
3523
3524 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3525
3526         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3527         (advance, posn, abstract_read_memory): New functions.
3528         [struct mem_read_abstraction]: New struct.
3529         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3530
3531 2019-05-14  Tom Tromey  <tromey@adacore.com>
3532
3533         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3534         value is not lval_memory.
3535
3536 2019-05-14  Tom Tromey  <tromey@adacore.com>
3537
3538         * solib.c (info_sharedlibrary_command): Style the file name.
3539
3540 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3541
3542         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3543         (aarch64_vnv_type): Likewise.
3544         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3545         * common/tdesc.c: Likewise.
3546         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3547         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3548         * features/aarch64-fpu.xml: Add ieee half view.
3549         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3550         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3551         * gdbtypes.h (struct builtin_type): Likewise.
3552         (struct objfile_type): Likewise.
3553
3554 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3555
3556         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3557         typo.
3558         * location.h (string_to_event_location): Likewise.
3559
3560 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3561
3562         GDB 8.3 released.
3563
3564 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3565
3566         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3567         New variable declaration.
3568         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3569         New variable.
3570         (print_one_breakpoint): Use ui_out::test_flags and new global
3571         variable to compute use_fixed_output.
3572         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3573         Remove.
3574         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3575         (mi_multi_location_breakpoint_output_fixed): Remove.
3576         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3577         new variable.
3578         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3579         fix_multi_location_breakpoint_output flag if version >= 3.
3580         * ui-out.h (enum ui_out_flag)
3581         <fix_multi_location_breakpoint_output>: New enumerator.
3582
3583 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3584
3585         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3586
3587 2019-05-10  Tom Tromey  <tromey@adacore.com>
3588
3589         * ada-lang.c (catch_ada_completer): New function.
3590         (_initialize_ada_language): Use it.
3591
3592 2019-05-10  Tom Tromey  <tromey@adacore.com>
3593
3594         * thread.c (print_thread_info): Make "requested_threads" const.
3595         * gdbthread.h (print_thread_info): Make "requested_threads"
3596         const.
3597         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3598         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * gdbtypes.c (objfile_type_data): Change type.
3603         (objfile_type, _initialize_gdbtypes): Update.
3604
3605 2019-05-08  Tom Tromey  <tom@tromey.com>
3606
3607         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3608         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3609         (_initialize_dwarf2_frame): Update.
3610
3611 2019-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * objc-lang.c (objc_objfile_data): Change type.
3614         (find_methods): Update.
3615         (_initialize_objc_lang): Remove.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * stabsread.c (rs6000_builtin_type_data): Change type.
3620         (rs6000_builtin_type, _initialize_stabsread): Update.
3621
3622 2019-05-08  Tom Tromey  <tom@tromey.com>
3623
3624         * mips-tdep.c (mips_pdr_data): Remove.
3625         (_initialize_mips_tdep): Update.
3626
3627 2019-05-08  Tom Tromey  <tom@tromey.com>
3628
3629         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3630         (hppa_init_objfile_priv_data, read_unwind_info)
3631         (find_unwind_entry, _initialize_hppa_tdep): Update.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3636         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3637         on obstack.
3638         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3639
3640 2019-05-08  Tom Tromey  <tom@tromey.com>
3641
3642         * mdebugread.c (basic_type_data): Change type.
3643         (basic_type, _initialize_mdebugread): Update.
3644
3645 2019-05-08  Tom Tromey  <tom@tromey.com>
3646
3647         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3648
3649 2019-05-08  Tom Tromey  <tom@tromey.com>
3650
3651         * nto-tdep.c (nto_inferior_data_reg): Change type.
3652         (nto_inferior_data): Update.
3653         (nto_inferior_data_cleanup, nto_new_inferior_data)
3654         (_initialize_nto_tdep): Remove.
3655         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3656
3657 2019-05-08  Tom Tromey  <tom@tromey.com>
3658
3659         * ada-lang.c (struct ada_inferior_data): Add initializers.
3660         (ada_inferior_data): Change type.
3661         (ada_inferior_data_cleanup): Remove.
3662         (get_ada_inferior_data, ada_inferior_exit)
3663         (struct ada_pspace_data): Add initializers, destructor.
3664         (ada_pspace_data_handle): Change type.
3665         (get_ada_pspace_data): Update.
3666         (ada_pspace_data_cleanup): Remove.
3667
3668 2019-05-08  Tom Tromey  <tom@tromey.com>
3669
3670         * coffread.c (struct coff_symfile_info): Add initializers.
3671         (coff_objfile_data_key): Move lower.  Change type.
3672         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3673         Update.
3674         (coff_free_info): Remove.
3675
3676 2019-05-08  Tom Tromey  <tom@tromey.com>
3677
3678         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3679         (fbsd_pspace_data_handle): Move lower.  Change type.
3680         (get_fbsd_pspace_data): Update.
3681         (fbsd_pspace_data_cleanup): Remove.
3682         (_initialize_fbsd_tdep): Update.
3683
3684 2019-05-08  Tom Tromey  <tom@tromey.com>
3685
3686         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3687         (get_ada_tasks_pspace_data): Update.
3688         (ada_tasks_pspace_data_cleanup): Remove.
3689         (_initialize_tasks): Update.
3690         (ada_tasks_inferior_data_handle): Change type.
3691         (get_ada_tasks_inferior_data): Update.
3692         (ada_tasks_inferior_data_cleanup): Remove.
3693         (struct ada_tasks_pspace_data): Add initializers.
3694
3695 2019-05-08  Tom Tromey  <tom@tromey.com>
3696
3697         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3698         * symfile-debug.c (debug_sym_get_probes): Change type.
3699         * stap-probe.c (handle_stap_probe):
3700         (stap_static_probe_ops::get_probes): Change type.
3701         * probe.h (class static_probe_ops) <get_probes>: Change type.
3702         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3703         (parse_probes_in_pspace): Update.
3704         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3705         Update.
3706         (any_static_probe_ops::get_probes): Change type.
3707         * elfread.c (elfread_data): New typedef.
3708         (probe_key): Change type.
3709         (elf_get_probes): Likewise.  Update.
3710         (probe_key_free): Remove.
3711         (_initialize_elfread): Update.
3712         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3713         Change type.
3714         (dtrace_process_dof_probe, dtrace_process_dof)
3715         (dtrace_static_probe_ops::get_probe): Change type.
3716
3717 2019-05-08  Tom Tromey  <tom@tromey.com>
3718
3719         * xcoffread.c (struct xcoff_symfile_info): Rename from
3720         coff_symfile_info.  Add initializers.
3721         (xcoff_objfile_data_key): Move lower.  Change type.
3722         (XCOFF_DATA): Rewrite.
3723         (xcoff_free_info): Remove.
3724         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3725         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3726         (xcoff_initial_scan): Update.
3727
3728 2019-05-08  Tom Tromey  <tom@tromey.com>
3729
3730         * solib-svr4.c (struct svr4_info): Add initializers and
3731         destructor.
3732         <probes_table>: Now an htab_up.
3733         (solib_svr4_pspace_data): Change type.
3734         (free_probes_table): Simplify.
3735         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3736         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3737         (probes_table_remove_objfile_probes, register_solib_event_probe)
3738         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3739         (_initialize_svr4_solib): Update.
3740
3741 2019-05-08  Tom Tromey  <tom@tromey.com>
3742
3743         * remote.c (remote_pspace_data): Change type.
3744         (remote_pspace_data_cleanup): Remove.
3745         (get_remote_exec_file, set_pspace_remote_exec_file)
3746         (_initialize_remote): Update.
3747
3748 2019-05-08  Tom Tromey  <tom@tromey.com>
3749
3750         * breakpoint.c (breakpoint_objfile_key): Change type.
3751         (get_breakpoint_objfile_data): Update.
3752         (free_breakpoint_objfile_data): Remove.
3753         (_initialize_breakpoint): Update.
3754
3755 2019-05-08  Tom Tromey  <tom@tromey.com>
3756
3757         * linux-tdep.c (struct linux_info): Add initializers.
3758         (linux_inferior_data): Move.  Change type.
3759         (invalidate_linux_cache_inf): Update.
3760         (linux_inferior_data_cleanup): Remove.
3761         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3762
3763 2019-05-08  Tom Tromey  <tom@tromey.com>
3764
3765         * auxv.c (auxv_inferior_data): Move.  Change type.
3766         (auxv_inferior_data_cleanup): Remove.
3767         (invalidate_auxv_cache_inf): Rewrite.
3768         (get_auxv_inferior_data, _initialize_auxv): Update.
3769
3770 2019-05-08  Tom Tromey  <tom@tromey.com>
3771
3772         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3773         (symfile_debug_objfile_data_key): Change type.
3774         (symfile_debug_installed, debug_qf_has_symbols)
3775         (debug_qf_find_last_source_symtab)
3776         (debug_qf_forget_cached_source_info)
3777         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3778         (debug_qf_print_stats, debug_qf_dump)
3779         (debug_qf_expand_symtabs_for_function)
3780         (debug_qf_expand_all_symtabs)
3781         (debug_qf_expand_symtabs_with_fullname)
3782         (debug_qf_map_matching_symbols)
3783         (debug_qf_expand_symtabs_matching)
3784         (debug_qf_find_pc_sect_compunit_symtab)
3785         (debug_qf_map_symbol_filenames)
3786         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3787         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3788         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3789         (debug_sym_read_linetable, debug_sym_relocate): Update.
3790         (symfile_debug_free_objfile): Remove.
3791         (install_symfile_debug_logging, _initialize_symfile_debug):
3792         Update.
3793
3794 2019-05-08  Tom Tromey  <tom@tromey.com>
3795
3796         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3797         allocate_on_obstack.
3798         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3799         (get_dwarf2_per_objfile): Update.
3800         (set_dwarf2_per_objfile): Remove.
3801         (dwarf2_has_info, dwarf2_get_section_info): Update.
3802         (dwarf2_free_objfile): Remove.
3803         (_initialize_dwarf2_read): Update.
3804
3805 2019-05-08  Tom Tromey  <tom@tromey.com>
3806
3807         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3808         initializers.
3809         <unsupported_script_warning_printed,
3810         script_not_found_warning_printed>: Now bool.
3811         (auto_load_pspace_data): Change type.
3812         (~auto_load_pspace_info): Rename from
3813         auto_load_pspace_data_cleanup.
3814         (get_auto_load_pspace_data, init_loaded_scripts_info)
3815         (clear_section_scripts, maybe_print_unsupported_script_warning)
3816         (maybe_print_script_not_found_warning, _initialize_auto_load):
3817         Update.
3818
3819 2019-05-08  Tom Tromey  <tom@tromey.com>
3820
3821         * objfiles.c (objfile_pspace_info): Add destructor and
3822         initializers.
3823         (objfiles_pspace_data): Change type.
3824         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3825         (get_objfile_pspace_data): Update.
3826         (objfiles_bfd_data): Change type.
3827         (get_objfile_bfd_data): Update.
3828         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3833         Change type.
3834         (get_catch_syscall_inferior_data): Update.
3835         (catch_syscall_inferior_data_cleanup): Remove.
3836         (_initialize_break_catch_syscall): Update.
3837
3838 2019-05-08  Tom Tromey  <tom@tromey.com>
3839
3840         * inflow.c (struct terminal_info): Add destructor and
3841         initializers.
3842         (inflow_inferior_data): Change type.
3843         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3844         (get_inflow_inferior_data, inflow_inferior_exit)
3845         (swap_terminal_info, _initialize_inflow): Update.
3846
3847 2019-05-08  Tom Tromey  <tom@tromey.com>
3848
3849         * target-dcache.c (target_dcache_cleanup): Remove.
3850         (target_dcache_aspace_key): Change type.
3851         (target_dcache_init_p, target_dcache_invalidate)
3852         (target_dcache_get, target_dcache_get_or_init)
3853         (_initialize_target_dcache): Update.
3854         * dcache.h (struct dcache_deleter): New.
3855
3856 2019-05-08  Tom Tromey  <tom@tromey.com>
3857
3858         * symtab.c (struct symbol_cache): Add destructor and
3859         initializers.
3860         (symbol_cache_key): Move.  Change type.
3861         (make_symbol_cache, free_symbol_cache): Remove.
3862         (get_symbol_cache): Update.
3863         (symbol_cache_cleanup): Remove.
3864         (ALL_PSPACES, symbol_cache_flush)
3865         (maintenance_print_symbol_cache)
3866         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3867         Update.
3868
3869 2019-05-08  Tom Tromey  <tom@tromey.com>
3870
3871         * symtab.c (struct main_info): Add destructor and initializers.
3872         (main_progspace_key): Move.  Change type.
3873         (get_main_info): Update.
3874         (main_info_cleanup): Remove.
3875         (_initialize_symtab): Update.
3876
3877 2019-05-08  Tom Tromey  <tom@tromey.com>
3878
3879         * registry.h (DECLARE_REGISTRY): Define the _key class.
3880
3881 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3882
3883         * NEWS: Merge two 'New commands' sections.
3884
3885 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3886
3887         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3888         parameter and use Ada language definition instead.
3889         (ada_val_print_ptr): Remove unused language parameter.
3890         (ada_val_print_num): Remove language parameter and use Ada language
3891         definition instead.
3892         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3893         parameter.
3894         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3895         parameter and use Ada language definition instead.
3896         (ada_val_print_1): Update all ada_val_print_xxx calls.
3897         Remove language parameter.
3898         (ada_val_print): Update ada_val_print_1 call.
3899
3900 2019-05-08  Tom Tromey  <tromey@adacore.com>
3901
3902         * remote.c (remote_hw_watchpoint_limit)
3903         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3904         Now static.
3905
3906 2019-05-08  Tom Tromey  <tromey@adacore.com>
3907
3908         * maint.c (_initialize_maint_cmds): Move initialization code to
3909         remote.c.
3910         (watchdog, show_watchdog): Move to remote.c.
3911         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3912         "watchdog" static.
3913         (_initialize_remote): Move initialization code from maint.c.
3914         * defs.h (watchdog): Don't declare.
3915
3916 2019-05-08  Tom Tromey  <tromey@adacore.com>
3917
3918         * tui/tui-interp.c: Include main.h.
3919         * interps.c: Include main.h.
3920         * main.h (interpreter_p): Declare.
3921         * defs.h (interpreter_p): Don't declare.
3922
3923 2019-05-08  Tom Tromey  <tromey@adacore.com>
3924
3925         * dwarf2loc.c: Include dwarf2read.h.
3926         * defs.h (read_unsigned_leb128): Don't declare.
3927         * dwarf2read.h (read_unsigned_leb128): Declare.
3928
3929 2019-05-08  Tom Tromey  <tromey@adacore.com>
3930
3931         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3932         method.
3933
3934 2019-05-08  Tom Tromey  <tromey@adacore.com>
3935
3936         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3937         when no wrap column is set.
3938
3939 2019-05-08  Tom Tromey  <tromey@adacore.com>
3940
3941         * c-lang.c (c_get_string): Handle non-C-style arrays.
3942
3943 2019-05-08  Tom Tromey  <tromey@adacore.com>
3944
3945         * typeprint.c (print_offset_data::update): Print the bit offset,
3946         not the number of bits remaining.
3947
3948 2019-05-08  Tom Tromey  <tromey@adacore.com>
3949
3950         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3951         padding at end of comment.
3952
3953 2019-05-08  Tom Tromey  <tromey@adacore.com>
3954
3955         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3956         Compare main types.
3957
3958 2019-05-06  Tom Tromey  <tom@tromey.com>
3959
3960         * common/scoped_mmap.c: Include common-defs.h.
3961         * common/scoped_mmap.h: Don't include config.h.
3962
3963 2019-05-04  Tom Tromey  <tom@tromey.com>
3964
3965         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3966         (struct aarch64_call_info): Add initializers.
3967         <si>: Now a std::vector.
3968         (pass_on_stack, aarch64_push_dummy_call): Update.
3969
3970 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3971             Tom Tromey  <tom@tromey.com>
3972
3973         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3974         (ppc_threads): Now a std::vector.  Now static.
3975         (hwdebug_find_thread_points_by_tid)
3976         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3977         Update.
3978
3979 2019-05-04  Tom Tromey  <tom@tromey.com>
3980
3981         * arc-tdep.c (arc_tdesc_init): Return bool.
3982
3983 2019-05-04  Tom Tromey  <tom@tromey.com>
3984
3985         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3986         Use gdb_assert_not_reached.
3987
3988 2019-05-04  Tom Tromey  <tom@tromey.com>
3989
3990         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3991         "false".
3992
3993 2019-05-04  Tom Tromey  <tom@tromey.com>
3994
3995         * arc-tdep.c (arc_tdesc_init): Use bool.
3996
3997 2019-05-04  Tom Tromey  <tom@tromey.com>
3998
3999         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4000
4001 2019-05-04  Tom Tromey  <tom@tromey.com>
4002
4003         * cli/cli-cmds.c (valid_command_p): Return bool.
4004
4005 2019-05-04  Tom Tromey  <tom@tromey.com>
4006
4007         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4008         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4009
4010 2019-05-04  Raul Tambre  <raul@tambre.ee>
4011
4012         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4013         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4014         operator for comparison.
4015
4016 2019-05-04  Tom Tromey  <tom@tromey.com>
4017
4018         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4019         (lookup_partial_symbol, print_partial_symbols)
4020         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4021         (psymbol_compare): Update.
4022         (add_psymbol_to_bcache): Clear the entire psymbol.
4023         (maintenance_check_psymtabs): Update.
4024         * psympriv.h (struct partial_symbol): Don't derive from
4025         general_symbol_info.
4026         <obj_section, unrelocated_address, address,
4027         set_unrelocated_address>: Update.
4028         <ginfo>: New member.
4029         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4030         (debug_names::write_psymbols): Update.
4031
4032 2019-05-04  Tom de Vries  <tdevries@suse.de>
4033
4034         * contrib/cc-with-tweaks.sh: Support -n arg.
4035
4036 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4037
4038         * corelow.c (core_target::detach): Ensure frame cache and
4039         register caches are cleared.
4040         inferior.c (exit_inferior_1): Likewise.
4041
4042 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4043             Tom Tromey  <tom@tromey.com>
4044
4045         * dictionary.c (collate_pending_symbols_by_language): Remove
4046         "struct" from foreach.
4047         * symtab.c (lookup_global_symbol_from_objfile)
4048         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4049         foreach.
4050         * ser-tcp.c (net_open): Remove "struct" from foreach.
4051         * objfiles.c (objfile_relocate, objfile_rebase)
4052         (objfile_has_symbols): Remove "struct" from foreach.
4053         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4054         from foreach.
4055         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4056         foreach.
4057         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4058         "struct" from foreach.
4059         * ada-lang.c (create_excep_cond_exprs)
4060         (ada_exception_catchpoint_cond_string): Remove "struct" from
4061         foreach.
4062
4063 2019-05-03  Tom Tromey  <tromey@adacore.com>
4064
4065         * ada-exp.y (convert_char_literal): Check suffix of each
4066         enumerator.
4067
4068 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4069
4070         PR ada/21406:
4071         * ada-exp.y (yywrap): Don't define.
4072         * ada-lex.l (%option): Add noyywrap
4073         (yywrap): Remove.
4074
4075 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4076
4077         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4078         _WIN32_WINNT to the XP level, unless already defined to a higher
4079         level.
4080
4081         * unittests/parse-connection-spec-selftests.c:
4082         * ser-tcp.c:
4083         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4084         override.
4085
4086         * symfile.c (find_separate_debug_file): Remove colon from the
4087         drive spec of DOS/Windows file names of the target, so that the
4088         file name produced from DEBUGDIR and the target's directory will
4089         be valid on DOS/Windows systems.
4090
4091 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * rust-lang.c (val_print_struct): Handle printing structures
4094         containing strings.
4095
4096 2019-05-02  Tom Tromey  <tromey@adacore.com>
4097
4098         * valarith.c (_initialize_valarith): Remove.
4099
4100 2019-05-01  Tom Tromey  <tromey@adacore.com>
4101
4102         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4103         bitfields.
4104
4105 2019-05-01  Tom Tromey  <tromey@adacore.com>
4106
4107         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4108         for big-endian copies.
4109
4110 2019-04-30  Ali Tamur  <tamur@google.com>
4111         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4112         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4113         (read_3_bytes): New function.
4114
4115 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4116
4117         * windows-nat.c (main_thread_id): Delete.
4118         (handle_output_debug_string): Replace main_thread_id by
4119         current_event.dwThreadId.
4120         (fake_create_process): Likewise.
4121         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4122         Do not set main_thread_id.
4123         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4124         current_event.dwThreadId.
4125         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4126
4127 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4128
4129         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4130         Use current_event.dwThreadId instead of main_thread_id.
4131
4132 2019-04-30  Tom Tromey  <tromey@adacore.com>
4133
4134         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4135         (create_excep_cond_exprs): Iterate over program spaces.
4136         (ada_exception_catchpoint_cond_string): Examine all minimal
4137         symbols for exception types.
4138
4139 2019-04-30  Tom Tromey  <tromey@adacore.com>
4140
4141         PR c++/24470:
4142         * dwarf2read.c (process_structure_scope): Handle case where type
4143         has template parameters but no symbol was created.
4144
4145 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4146             Chris January  <chris.january@arm.com>
4147
4148         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4149         qualifier.
4150         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4151
4152 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * f-typeprint.c (f_print_type): Update rules for printing
4155         whitespace.
4156         (f_type_print_varspec_suffix): Likewise.
4157
4158 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4159             Chris January  <chris.january@arm.com>
4160
4161         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4162         function arguments.
4163
4164 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * f-lang.c (build_fortran_types): Change name of void type to
4167         lower case.
4168         * f-typeprint.c (f_type_print_base): Print the name of the void
4169         type, rather than a fixed string.
4170         * f-valprint.c (f_decorations): Use lower case void string.
4171
4172 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4173             Chris January  <chris.january@arm.com>
4174
4175         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4176         types for Fortran.
4177
4178 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4179             Chris January  <chris.january@arm.com>
4180             David Lecomber  <david.lecomber@arm.com>
4181
4182         * f-exp.y (BINOP_INTRINSIC): New token.
4183         (exp): New parser rule handling BINOP_INTRINSIC.
4184         (f77_keywords): Add new builtin procedures.
4185         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4186         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4187         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4188         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4189         (print_unop_subexp_f): New function.
4190         (print_binop_subexp_f): New function.
4191         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4192         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4193         (dump_subexp_body_f): Likewise.
4194         (operator_check_f): Likewise.
4195         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4196         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4197
4198 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4201         UNOP_KIND.
4202         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4203         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4204         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4205         (operator_length_f): New fuction.
4206         (print_subexp_f): New function.
4207         (op_name_f): New function.
4208         (dump_subexp_body_f): New function.
4209         (operator_check_f): New function.
4210         (exp_descriptor_f): Replace standard expression handling functions
4211         with new functions.
4212         * gdb/fortran-operator.def: New file.
4213         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4214         * gdb/std-operator.def: Remove UNOP_KIND.
4215
4216 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4217
4218         * std-operator.def: Remove unbalanced, stray double quote
4219         character.
4220
4221 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4222             Chris January  <chris.january@arm.com>
4223             Daniel Everett  <daniel.everett@arm.com>
4224             Nick Forrington  <nick.forrington@arm.com>
4225             Richard Bunt  <richard.bunt@arm.com>
4226
4227         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4228         of depth when printing anonymous structs or unions.
4229         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4230         Don't print either the top-level value, or the children if the
4231         max-depth is exceeded.
4232         (ppscm_print_children): When printing the key of a map, allow one
4233         extra level of depth.
4234         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4235         print either the top-level value, or the children if the max-depth
4236         is exceeded.
4237         (print_children): When printing the key of a map, allow one extra
4238         level of depth.
4239         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4240         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4241         (user_print_options): Initialise max_depth field.
4242         (val_print_scalar_or_string_type_p): New function.
4243         (val_print): Check to see if the max depth has been reached.
4244         (val_print_check_max_depth): Define new function.
4245         (show_print_max_depth): New function.
4246         (_initialize_valprint): Add 'print max-depth' option.
4247         * valprint.h (struct value_print_options) <max_depth>: New field.
4248         (val_print_check_max_depth): Declare new function.
4249         * NEWS: Document new feature.
4250
4251 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * ada-lang.c (ada_language_defn): Initialise new field.
4254         * c-lang.c (c_is_string_type_p): New function.
4255         (c_language_defn): Initialise new field.
4256         (cplus_language_defn): Initialise new field.
4257         (asm_language_defn): Initialise new field.
4258         (minimal_language_defn): Initialise new field.
4259         * c-lang.h (c_is_string_type_p): Declare new function.
4260         * d-lang.c (d_language_defn): Initialise new field.
4261         * f-lang.c (f_is_string_type_p): New function.
4262         (f_language_defn): Initialise new field.
4263         * go-lang.c (go_is_string_type_p): New function.
4264         (go_language_defn): Initialise new field.
4265         * language.c (default_is_string_type_p): New function.
4266         (unknown_language_defn): Initialise new field.
4267         (auto_language_defn): Initialise new field.
4268         * language.h (struct language_defn) <la_is_string_type_p>: New
4269         member variable.
4270         (default_is_string_type_p): Declare new function.
4271         * m2-lang.c (m2_language_defn): Initialise new field.
4272         * objc-lang.c (objc_language_defn): Initialise new field.
4273         * opencl-lang.c (opencl_language_defn): Initialise new field.
4274         * p-lang.c (pascal_is_string_type_p): New function.
4275         (pascal_language_defn): Initialise new field.
4276         * rust-lang.c (rust_is_string_type_p): New function.
4277         (rust_language_defn): Initialise new field.
4278
4279 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4280
4281         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4282         New field.
4283         * ada-lang.c (ada_language_defn): Initialise new field.
4284         * c-lang.c (c_language_defn): Likewise.
4285         (cplus_language_defn): Likewise.
4286         (asm_language_defn): Likewise.
4287         (minimal_language_defn): Likewise.
4288         * d-lang.c (d_language_defn): Likewise.
4289         * f-lang.c (f_language_defn): Likewise.
4290         * go-lang.c (go_language_defn): Likewise.
4291         * language.c (unknown_language_defn): Likewise.
4292         (auto_language_defn): Likewise.
4293         * m2-lang.c (m2_language_defn): Likewise.
4294         * objc-lang.c (objc_language_defn): Likewise.
4295         * opencl-lang.c (opencl_language_defn): Likewise.
4296         * p-lang.c (pascal_language_defn): Likewise.
4297         * rust-lang.c (rust_language_defn): Likewise.
4298
4299 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4300
4301         * ada-lang.c (ada_is_character_type): Change return type to bool.
4302         (ada_is_string_type): Likewise.
4303         * ada-lang.h (ada_is_character_type): Update declaration
4304         (ada_is_string_type): Likewise.
4305
4306 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         Support style in 'frame|thread apply'
4309
4310         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4311         * record.c (record_start, record_stop): Update callers of
4312         execute_command_to_string with false.
4313         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4314         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4315         methods.
4316         (class string_file): New constructor with term_out parameter.
4317         Override methods term_out and can_emit_style_escape.  New member
4318         term_out.
4319         (class stdio_file): Override can_emit_style_escape.
4320         (class tee_file): Override term_out and can_emit_style_escape.
4321         * utils.h (can_emit_style_escape): Remove.
4322         * utils.c (can_emit_style_escape): Likewise.
4323         Update all callers of can_emit_style_escape (SOMESTREAM) to
4324         SOMESTREAM->can_emit_style_escape.
4325         * source-cache.c (source_cache::get_source_lines): Likewise.
4326         * stack.c (frame_apply_command_count): Call execute_command_to_string
4327         passing the term_out characteristic of the current gdb_stdout.
4328         * thread.c (thr_try_catch_cmd): Likewise.
4329         * top.c (execute_command_to_string): pass term_out parameter
4330         to construct the string_file for the command output.
4331         * ui-file.c (term_cli_styling): New function (most code moved
4332         from utils.c can_emit_style_escape).
4333         (string_file::string_file, string_file::can_emit_style_escape,
4334         stdio_file::can_emit_style_escape, tee_file::term_out,
4335         tee_file::can_emit_style_escape): New functions.
4336
4337 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4338
4339         * NEWS: Mention the new set|show may-call-functions.
4340         * infcall.c (may_call_functions_p): New variable.
4341         (show_may_call_functions_p): New function.
4342         (call_function_by_hand_dummy): Throws an error if not
4343         may-call-functions.
4344         (_initialize_infcall): Call add_setshow_boolean_cmd for
4345         may-call-functions.
4346
4347 2019-04-25  Keith Seitz  <keiths@redhat.com>
4348
4349         PR c++/24367
4350         * cp-support.c (inspect_type): Don't attempt substitutions
4351         of symbol with the same name.
4352
4353 2019-04-25  Tom Tromey  <tromey@adacore.com>
4354
4355         PR gdb/24475:
4356         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4357         static.
4358
4359 2019-04-25  Tom Tromey  <tromey@adacore.com>
4360
4361         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4362         rvalue reference.
4363         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4364         (gdb_xml_parser::parse): Use std::move.
4365         * python/python-internal.h (gdbpy_convert_exception): Take a const
4366         reference.
4367         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4368         std::move.
4369         * python/py-utils.c (gdbpy_convert_exception): Take a const
4370         reference.
4371         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4372         Use std::move.
4373         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4374         Use std::move.
4375         * mi/mi-main.c (mi_print_exception): Take a const reference.
4376         * main.c (handle_command_errors): Take a const reference.
4377         * linespec.c (parse_linespec): Use std::move.
4378         * infcall.c (run_inferior_call): Use std::move.
4379         (call_function_by_hand_dummy): Use std::move.
4380         * exec.c (try_open_exec_file): Use std::move.
4381         * exceptions.h (exception_print, exception_fprintf)
4382         (exception_print_same): Update.
4383         * exceptions.c (print_exception, exception_print)
4384         (exception_fprintf, exception_print_same): Change parameters to
4385         const reference.
4386         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4387         * common/new-op.c: Use std::move.
4388         * common/common-exceptions.h (struct gdb_exception): Add move
4389         constructor.
4390         (struct gdb_exception_error, struct gdb_exception_quit, struct
4391         gdb_quit_bad_alloc): Change constructor to move constructor.
4392         (throw_exception): Change parameter to rvalue reference.
4393         * common/common-exceptions.c (throw_exception): Take rvalue
4394         reference.
4395         * cli/cli-interp.c (safe_execute_command): Use std::move.
4396         * breakpoint.c (insert_bp_location, location_to_sals): Use
4397         std::move.
4398
4399 2019-04-25  Tom Tromey  <tromey@adacore.com>
4400
4401         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4402         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4403         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4404         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4405         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4406         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4407         guile/scm-value.c: Use unpack.
4408         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4409         gdbscm_gdb_exception.
4410         (gdbscm_throw_gdb_exception): Likewise.
4411         (struct gdbscm_gdb_exception): New.
4412         (unpack): New function.
4413         (gdbscm_wrap): Use unpack.
4414
4415 2019-04-25  Tom Tromey  <tromey@adacore.com>
4416
4417         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4418         (gdb_rl_callback_handler): Use std::move.
4419         * common/common-exceptions.h (struct gdb_exception): Add move
4420         assignment operator.
4421         (throw_exception_sjlj): Change "exception" to const reference.
4422         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4423         (throw_exception_sjlj): Change "exception" to const reference.
4424
4425 2019-04-25  Tom Tromey  <tromey@adacore.com>
4426
4427         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4428         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4429         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4430         Update.
4431         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4432         Update.
4433         * mi/mi-interp.c (mi_interp::exec): Update.
4434         * linespec.c (parse_linespec): Update.
4435         * infcall.c (run_inferior_call): Update.
4436         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4437         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4438         (gdbscm_lookup_global_symbol): Update.
4439         * guile/scm-param.c (gdbscm_parameter_value): Update.
4440         * guile/scm-frame.c (gdbscm_frame_read_register)
4441         (gdbscm_frame_read_var): Update.
4442         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4443         * exec.c (try_open_exec_file): Update.
4444         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4445         (gdb_rl_callback_handler): Update.
4446         * common/common-exceptions.h (exception_none): Don't declare.
4447         * common/common-exceptions.c (exception_none): Don't define.
4448         (struct catcher) <exception>: Update.
4449         * cli/cli-interp.c (safe_execute_command): Update.
4450         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4451
4452 2019-04-25  Ali Tamur  <tamur@google.com>
4453
4454         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4455         (read_attribute_value): Likewise.
4456         (dwarf2_read_addr_index): Update comment.
4457         (read_str_index): Add DW_FORM_strx.
4458         (dwarf2_string_attr): Likewise.
4459         (dwarf2_const_value_attr): Likewise.
4460         (dump_die_shallow): Likewise.
4461         (dwarf2_fetch_constant_bytes): Likewise.
4462         (skip_form_bytes): Likewise.
4463         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4464
4465 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4466
4467         PR corefiles/11608
4468         PR corefiles/18187
4469         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4470         OFFSET.  Verify if current mapping contains an ELF header.
4471         (linux_find_memory_regions_full): Adjust call to
4472         dump_mapping_p.
4473
4474 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4475             Kang Li <kanglictf@gmail.com>
4476
4477         PR gdb/21600
4478
4479         * dwarf2-frame.c (read_initial_length): Be consistent about using
4480         unsigned representation of length.
4481         (decode_frame_entry_1): Likewise.  Check for wraparound of
4482         end pointer as well as buffer overflow.
4483
4484 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4485
4486         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4487         "vq".
4488
4489 2019-04-24  Tom Tromey  <tromey@adacore.com>
4490
4491         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4492
4493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * s12z-tdep.c (s12z_unwind_pc): Delete.
4496         (s12z_unwind_sp): Delete.
4497         (s12z_gdbarch_init): Don't register deleted functions with
4498         gdbarch.
4499
4500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * rl78-tdep.c (rl78_unwind_sp): Delete.
4503         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4504
4505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4508         (xstormy16_unwind_pc): Delete.
4509         (xstormy16_dummy_id): Delete.
4510         (xstormy16_gdbarch_init): Don't register deleted functions with
4511         gdbarch.
4512
4513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * vax-tdep.c (vax_unwind_pc): Delete.
4516         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * v850-tdep.c (v850_unwind_sp): Delete.
4521         (v850_unwind_pc): Delete.
4522         (v850_dummy_id): Delete.
4523         (v850_gdbarch_init): Don't register deleted functions with
4524         gdbarch.
4525
4526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4529         (tilegx_unwind_pc): Delete.
4530         (tilegx_unwind_dummy_id): Delete.
4531         (tilegx_gdbarch_init): Don't register deleted functions with
4532         gdbarch.
4533
4534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4537         (tic6x_dummy_id): Delete.
4538         (tic6x_gdbarch_init): Don't register deleted functions with
4539         gdbarch.
4540
4541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4542
4543         * sparc-tdep.c (sparc_unwind_pc): Delete.
4544         (sparc32_gdbarch_init): Don't register deleted function with
4545         gdbarch.
4546
4547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * sh-tdep.c (sh_unwind_sp): Delete.
4550         (sh_unwind_pc): Delete.
4551         (sh_dummy_id): Delete.
4552         (sh_gdbarch_init): Don't register deleted functions with
4553         gdbarch.
4554
4555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4556
4557         * score-tdep.c (score_unwind_sp): Delete.
4558         (score_unwind_pc): Delete.
4559         (score_dummy_id): Delete.
4560         (score_gdbarch_init): Don't register deleted functions with
4561         gdbarch.
4562
4563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4564
4565         * rx-tdep.c (rx_unwind_pc): Delete.
4566         (rx_unwind_sp): Delete.
4567         (rx_dummy_id): Delete.
4568         (rx_gdbarch_init): Don't register deleted functions with
4569         gdbarch.  Update comment.
4570
4571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4574         (rs6000_dummy_id): Delete.
4575         (rs6000_gdbarch_init): Don't register deleted functions with
4576         gdbarch.
4577
4578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * or1k-tdep.c (or1k_dummy_id): Delete.
4581         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4582
4583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4584
4585         * nios2-tdep.c (nios2_dummy_id): Delete.
4586         (nios2_unwind_sp): Delete.
4587         (nios2_gdbarch_init): Don't register deleted functions with
4588         gdbarch.
4589
4590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * nds32-tdep.c (nds32_dummy_id): Delete.
4593         (nds32_unwind_pc): Delete.
4594         (nds32_unwind_sp): Delete.
4595         (nds32_gdbarch_init): Don't register deleted functions with
4596         gdbarch.
4597
4598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * msp430-tdep.c (msp430_unwind_pc): Delete.
4601         (msp430_unwind_sp): Delete.
4602         (msp430_dummy_id): Delete.
4603         (msp430_gdbarch_init): Don't register deleted functions with
4604         gdbarch.
4605
4606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * moxie-tdep.c (moxie_unwind_sp): Delete.
4609         (moxie_unwind_pc): Delete.
4610         (moxie_dummy_id): Delete.
4611         (moxie_gdbarch_init): Don't register deleted functions with
4612         gdbarch.
4613
4614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4615
4616         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4617         (mn10300_unwind_pc): Delete.
4618         (mn10300_unwind_sp): Delete.
4619         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4620         mn10300_unwind_sp.
4621         (mn10300_frame_unwind_init): Don't register deleted functions with
4622         gdbarch.
4623
4624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * mep-tdep.c (mep_unwind_pc): Delete.
4627         (mep_unwind_sp): Delete.
4628         (mep_dummy_id): Delete.
4629         (mep_gdbarch_init): Don't register deleted functions with
4630         gdbarch.
4631
4632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4635         (m68hc11_unwind_sp): Delete.
4636         (m68hc11_gdbarch_init): Don't register deleted functions with
4637         gdbarch.
4638
4639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4640
4641         * m32r-tdep.c (m32r_unwind_sp): Delete.
4642         (m32r_unwind_pc): Delete.
4643         (m32r_dummy_id): Delete.
4644         (m32r_gdbarch_init): Don't register deleted functions with
4645         gdbarch.
4646
4647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * m32c-tdep.c (m32c_unwind_pc): Delete.
4650         (m32c_unwind_sp): Delete.
4651         (m32c_dummy_id): Delete.
4652         (m32c_gdbarch_init): Don't register deleted functions with
4653         gdbarch.
4654
4655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4658         (lm32_unwind_pc): Delete.
4659         (lm32_dummy_id): Delete.
4660         (lm32_gdbarch_init): Don't register deleted functions with
4661         gdbarch.
4662
4663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4666         (iq2000_unwind_pc): Delete.
4667         (iq2000_dummy_id): Delete.
4668         (iq2000_gdbarch_init): Don't register deleted functions with
4669         gdbarch.
4670
4671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * nds32-tdep.c (nds32_type_align): Delete.
4674         (nds32_push_dummy_call): Use type_align instead.
4675
4676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4677
4678         * arm-tdep.c (arm_type_align): Only handle vector override case.
4679         (arm_push_dummy_call): Use type_align.
4680         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4681
4682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4683
4684         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4685         case.
4686         (pass_on_stack): Use type_align.
4687         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4688         function.
4689
4690 2019-04-23  Tom Tromey  <tromey@adacore.com>
4691
4692         * dwarf2read.c (line_header::file_name_at): Remove unused
4693         overload.
4694
4695 2019-04-23  Tom de Vries  <tdevries@suse.de>
4696
4697         PR gdb/24438
4698         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4699         invocation.
4700
4701
4702 2019-03-27  Ali Tamur  <tamur@google.com>
4703
4704         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4705         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4706         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4707         (dwarf_expr_context::get_addr_index): Likewise
4708         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4709         (symbol_needs_eval_context::get_addr_index): Likewise
4710         (disassemble_dwarf_expression): Add DW_OP_addrx
4711         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4712         (read_cutu_die_from_dwo): Update comment
4713         (skip_one_die): Add DW_FORM_addrx
4714         (read_attribute_value): Likewise
4715         (var_decode_location): Add DW_OP_addrx
4716         (dwarf2_const_value_attr): Add DW_FORM_addrx
4717         (dump_die_shallow): Likewise
4718         (dwarf2_fetch_constant_bytes): Likewise
4719         (decode_locdesc): Add DW_OP_addrx
4720         (skip_form_bytes): Add DW_FORM_addrx
4721
4722 2019-04-22  Ali Tamur  <tamur@google.com>
4723
4724         * MAINTAINERS (Write After Approval): Add self.
4725
4726 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4727
4728         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4729         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4730         (open_symbol_file_object): Likewise.
4731         (svr4_default_sos): Add info parameter.
4732         (svr4_read_so_list): Likewise.
4733         (svr4_current_sos_direct): Adjust functions calls to pass down
4734         info.
4735         (svr4_current_sos_1): Add info parameter.
4736         (svr4_current_sos): Call get_svr4_info, pass info down to
4737         svr4_current_sos_1.
4738         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4739         get_svr4_info.
4740         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4741         get_svr4_info.
4742         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4743         to get_svr4_info.
4744         (probes_table_remove_objfile_probes): Likewise.
4745         (register_solib_event_probe): Add info parameter.
4746         (solist_update_incremental): Pass info parameter down to
4747         svr4_read_so_list.
4748         (disable_probes_interface): Add info parameter.
4749         (svr4_handle_solib_event): Pass current_program_space to
4750         get_svr4_info.  Adjust disable_probes_interface cleanup.
4751         (svr4_create_probe_breakpoints): Add info parameter, pass it
4752         down to register_solib_event_probe.
4753         (svr4_create_solib_event_breakpoints): Add info parameter,
4754         pass it down to svr4_create_probe_breakpoints.
4755         (enable_break): Pass info down to
4756         svr4_create_solib_event_breakpoints.
4757         (svr4_solib_create_inferior_hook): Pass current_program_space to
4758         get_svr4_info.
4759         (svr4_clear_solib): Likewise.
4760
4761 2019-04-22  Pedro Alves  <palves@redhat.com>
4762
4763         * solib-svr4.c (svr4_free_objfile_observer): New.
4764         (probe_and_action::objfile): New field.
4765         (probes_table_htab_remove_objfile_probes)
4766         (probes_table_remove_objfile_probes): New functions.
4767         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4768         in the new probe_and_action.  Don't store the probe in 'lookup'.
4769         (svr4_create_probe_breakpoints): Pass objfile to
4770         register_solib_event_probe.
4771         (_initialize_svr4_solib): Register a free_objfile observer.
4772
4773 2019-04-19  Tom Tromey  <tom@tromey.com>
4774
4775         * common/queue.h: Remove.
4776
4777 2019-04-19  Tom Tromey  <tom@tromey.com>
4778
4779         * event-loop.c: Don't include "common/queue.h".
4780
4781 2019-04-19  Tom Tromey  <tom@tromey.com>
4782
4783         * remote.c (remote_target): Use delete.
4784         * remote-notif.h: Include <list>, not "common/queue.h".
4785         (notif_client_p): Remove typedef.
4786         (remote_notif_state): Add constructor, destructor, initializer.
4787         <notif_queue>: Now a std::list.
4788         (remote_notif_state_xfree): Don't declare.
4789         * remote-notif.c (remote_notif_process, handle_notification)
4790         (remote_notif_state_allocate): Update.
4791         (~remote_notif_state): Rename from remote_notif_state_xfree.
4792
4793 2019-04-19  Tom Tromey  <tom@tromey.com>
4794
4795         * symfile.c (reread_symbols): Update.
4796         * objfiles.c (objfile_register_static_link)
4797         (objfile_lookup_static_link): Update
4798         (~objfile) Don't delete static_links.
4799         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4800
4801 2019-04-19  Tom Tromey  <tom@tromey.com>
4802
4803         * type-stack.h (struct type_stack) <insert>: Constify string.
4804         * type-stack.c (type_stack::insert): Constify string.
4805         * gdbtypes.h (lookup_template_type): Update.
4806         (address_space_name_to_int): Update.
4807         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4808         const.
4809         (lookup_template_type): Make name const.
4810         * c-exp.y: Update rules.
4811         (lex_one_token, classify_name, classify_inner_name)
4812         (c_print_token): Update.
4813         * p-exp.y: Update rules.
4814         (yylex): Update.
4815         * f-exp.y: Update rules.
4816         (yylex): Update.
4817         * d-exp.y: Update rules.
4818         (lex_one_token, classify_name, classify_inner_name): Update.
4819         * parse.c (write_dollar_variable, copy_name): Return std::string.
4820         * parser-defs.h (copy_name): Change return type.
4821         * m2-exp.y: Update rules.
4822         (yylex): Update.
4823         * go-exp.y (lex_one_token): Update.
4824         Update rules.
4825         (classify_unsafe_function, classify_packaged_name)
4826         (classify_name, yylex): Update.
4827
4828 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4829
4830         * configure.ac: add --enable-source-highlight switch.
4831         * configure: Regenerate.
4832         * top.c (print_gdb_version): plumb --enable-source-highlight
4833         status to "show configuration".
4834
4835 2019-04-19  Tom Tromey  <tromey@adacore.com>
4836
4837         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4838         Check ADA_TYPE_P.
4839         (empty_record, ada_template_to_fixed_record_type_1)
4840         (template_to_static_fixed_type)
4841         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4842         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4843         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4844         macros.
4845
4846 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4847
4848         PR symtab/24423:
4849         * source.c (print_source_lines_base): Advance "iter" when a
4850         control character is seen.
4851
4852 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4853
4854         * inferior.h (struct infcall_suspend_state_deleter):
4855         Catch exception in destructor to avoid crash.
4856
4857 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4858
4859         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4860         close to the add_com "shell".
4861
4862 2019-04-18  Tom Tromey  <tromey@adacore.com>
4863
4864         * process-stratum-target.h (class process_stratum_target)
4865         <stratum>: Add "final".
4866
4867 2019-04-17  Tom Tromey  <tromey@adacore.com>
4868
4869         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4870         against nullptr before use.
4871
4872 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4873
4874         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4875
4876 2019-04-17  Jim Wilson  <jimw@sifive.com>
4877             Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4880         code read might fail, assume 4-byte breakpoint in that case.
4881
4882 2019-04-15  Leszek Swirski  <leszeks@google.com>
4883
4884         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4885         rather than a hand-rolled POD check when checking for forced MEMORY
4886         classification.
4887
4888 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4889
4890         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4891         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4892         function.
4893         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4894         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4895         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4896         declaration.
4897
4898 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4899
4900         * aarch64-linux-nat.c
4901         (aarch64_linux_nat_target::thread_architecture): Add override.
4902         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4903         each VQ.
4904
4905 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4906
4907         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4908
4909 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4910
4911         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4912         target types of size 96-bits, add some additional comments, and
4913         check that the builtin type we found was the correct size.
4914
4915 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4916
4917         * utils.c (prompt_for_continue): Don't restore the styling at the
4918         end, as applied_style has the wrong value.  This fixes styling in
4919         long lists of file names that are interrupted by the "Continue?"
4920         prompt.
4921
4922 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4925         * c-lang.c (c_language_defn): Likewise.
4926         (cplus_language_defn): Likewise.
4927         (asm_language_defn): Likewise.
4928         (minimal_language_defn): Likewise.
4929         * d-lang.c (d_language_defn): Likewise.
4930         * f-lang.c (f_language_defn): Likewise.
4931         * go-lang.c (go_language_defn): Likewise.
4932         * language.c (unknown_language_defn): Likewise.
4933         (auto_language_defn): Likewise.
4934         * language.h (struct language_defn): Remove la_magic field.
4935         (LANG_MAGIC): Delete.
4936         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4937         * objc-lang.c (objc_language_defn): Likewise.
4938         * opencl-lang.c (opencl_language_defn): Likewise.
4939         * p-lang.c (pascal_language_defn): Likewise.
4940         * rust-lang.c (rust_language_defn): Likewise.
4941
4942 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * riscv-tdep.c (riscv_type_align): New function.
4945         (riscv_type_alignment): Delete.
4946         (riscv_arg_location): Use 'type_align'.
4947         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4948
4949 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * gdbtypes.c (type_align): A struct with no non-static fields also
4952         has alignment of 1.
4953
4954 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4957         component to 0.
4958         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4959         member.
4960         (riscv_struct_info::analyse): New implementation using new
4961         analyse_inner member function.
4962         (riscv_struct_info::field_offset): New member function.
4963         (riscv_struct_info::m_offsets): New member variable.
4964         (riscv_struct_info::analyse_inner): New private member function,
4965         takes the old implementation of riscv_struct_info::analyse but
4966         extended to track field offsets.
4967         (riscv_call_arg_struct): Update the struct folding special cases
4968         to handle cases where empty C++ structs, which are non-zero
4969         length, are found.
4970         (riscv_arg_location): Initialise the length of each location, a
4971         non-zero length now indicates the location is in use.
4972         (riscv_push_dummy_call): Allow for the first location having a
4973         non-zero offset when setting up arguments.
4974         (riscv_return_value): Likewise, but for return values.
4975
4976 2019-04-11  Tom Tromey  <tromey@adacore.com>
4977
4978         * utils.c (internal_vproblem): Make "msg" const.
4979
4980 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4981
4982         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4983         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4984         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4985         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4986
4987 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4988
4989         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4990         function.
4991         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4992         of amd64_collect_native_gregset.
4993         (amd64_linux_nat_target::store_registers): Likewise.
4994
4995 2019-04-10  Tom Tromey  <tom@tromey.com>
4996
4997         * symtab.c (lookup_global_symbol_from_objfile)
4998         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4999         * objfiles.h (class separate_debug_iterator): New.
5000         (class separate_debug_range): New.
5001         (struct objfile) <separate_debug_objfiles>: New method.
5002         (objfile_separate_debug_iterate): Don't declare.
5003         * objfiles.c (separate_debug_iterator::operator++): Rename from
5004         objfile_separate_debug_iterate.
5005         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5006         iterator.
5007         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5008         iterator.
5009
5010 2019-04-10  Tom Tromey  <tom@tromey.com>
5011
5012         * symfile.c (reread_symbols): Remove old comment.
5013         * objfiles.c (free_all_objfiles): Fix a typo.
5014
5015 2019-04-10  Tom Tromey  <tom@tromey.com>
5016
5017         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5018         * minsyms.c (lookup_minimal_symbol): Use foreach.
5019         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5020         (lookup_minimal_symbol_solib_trampoline): Likewise.
5021         * symfile.c (reread_symbols): Use foreach.
5022
5023 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5024             Tom Tromey  <tromey@adacore.com>
5025
5026         PR rust/24414:
5027         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5028         (rust_lex_int_test): Change "value" to be LONGEST.
5029         (rust_lex_tests): Add test for long integer literal.
5030
5031 2019-04-09  Tom Tromey  <tromey@adacore.com>
5032
5033         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5034         to bool.
5035         (extended_remote_target::attach): Update.
5036         (remote_target::remote_notice_new_inferior): Update.
5037         (remote_target::add_current_inferior_and_thread): Update.
5038         * inferior.c (exit_inferior_1): Use "false".
5039         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5040
5041 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5042
5043         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5044         the "start" command.
5045
5046 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5047
5048         * python/py-inferior.c (infpy_thread_from_thread_handle):
5049         Adjust comments to reflect renaming of thread_from_thread_handle
5050         to thread_from_handle.  Adjust keywords.  Fix type error message.
5051         (inferior_object_methods): Add thread_from_handle.  Retain
5052         thread_from_thread_handle, but mark it as deprecated.
5053
5054 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5055
5056         * gdbthread.h (find_thread_by_handle): Revise declaration.
5057         * thread.c (find_thread_by_handle): Likewise.  Adjust
5058         implementation too.
5059         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5060         support for buffer objects as handles.
5061
5062 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5063
5064         * python/py-infthread.c (thpy_thread_handle): New function.
5065         (thread_object_methods): Register thpy_thread_handle.
5066
5067 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5068
5069         * gdbthread.h (thread_to_thread_handle): Declare.
5070         * thread.c (gdbtypes.h): Include.
5071         (thread_to_thread_handle): New function.
5072
5073         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5074         (target_thread_info_to_thread_handle): Declare.
5075         * target.c (target_thread_info_to_thread_handle): New function.
5076         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5077         * target-delegates.c: Regenerate.
5078
5079         * linux-thread-db.c (class thread_db_target): Add method
5080         thread_info_to_thread_handle.
5081         (thread_db_target::thread_info_to_thread_handle): Define.
5082         * remote.c (class remote_target): Add new method
5083         thread_info_to_thread_handle.
5084         (remote_target::thread_info_to_thread_handle): Define.
5085
5086 2019-04-08  Pedro Alves  <palves@redhat.com>
5087
5088         * common/common-exceptions.c (throw_exception): Don't create
5089         named object to throw; throw directly.
5090         (throw_it): Likewise.  Don't initialize gdb_exception::message
5091         here, with new; pass FMT and AP to the ctor instead.
5092         * common/common-exceptions.h: Include <string>.
5093         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5094         const char *, va_list)): New ctor.  Use std::make_shared.
5095         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5096         errors)): Delete.
5097         (gdb_exception_error::gdb_exception_error(enum errors, const char
5098         *, va_list)): New.
5099         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5100         Add assertion.
5101         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5102         errors)): Delete.
5103         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5104         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5105         Add assertion.
5106
5107 2019-04-08  Tom Tromey  <tom@tromey.com>
5108
5109         * valops.c (value_rtti_indirect_type): Replace throw_exception
5110         with throw.
5111         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5112         with throw.
5113         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5114         throw.
5115         * target.c (target_translate_tls_address): Replace throw_exception
5116         with throw.
5117         * stack.c (frame_apply_command_count): Replace throw_exception
5118         with throw.
5119         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5120         throw.
5121         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5122         with throw.
5123         * rs6000-tdep.c (rs6000_frame_cache)
5124         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5125         * remote.c: Replace throw_exception with throw.
5126         * record-full.c (record_full_message, record_full_wait_1)
5127         (record_full_restore): Replace throw_exception with throw.
5128         * record-btrace.c:
5129         (get_thread_current_frame_id, record_btrace_start_replaying)
5130         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5131         (cmd_record_btrace_start): Replace throw_exception with throw.
5132         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5133         throw.
5134         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5135         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5136         * linespec.c:
5137         (find_linespec_symbols): Replace throw_exception with throw.
5138         * infrun.c (displaced_step_prepare, resume): Replace
5139         throw_exception with throw.
5140         * infcmd.c (post_create_inferior): Replace throw_exception with
5141         throw.
5142         * inf-loop.c (inferior_event_handler): Replace throw_exception
5143         with throw.
5144         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5145         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5146         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5147         (get_prev_frame_always, get_frame_pc_if_available)
5148         (get_frame_address_in_block_if_available, get_frame_language):
5149         Replace throw_exception with throw.
5150         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5151         throw_exception with throw.
5152         * eval.c (fetch_subexp_value, evaluate_var_value)
5153         (evaluate_funcall, evaluate_subexp_standard): Replace
5154         throw_exception with throw.
5155         * dwarf2loc.c (call_site_find_chain)
5156         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5157         Replace throw_exception with throw.
5158         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5159         with throw.
5160         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5161         throw.
5162         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5163         * completer.c (complete_line_internal): Replace throw_exception
5164         with throw.
5165         * compile/compile-object-run.c (compile_object_run): Replace
5166         throw_exception with throw.
5167         * cli/cli-script.c (process_next_line): Replace throw_exception
5168         with throw.
5169         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5170         (btrace_enable, btrace_maint_update_pt_packets): Replace
5171         throw_exception with throw.
5172         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5173         throw_exception with throw.
5174         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5175         throw_exception with throw.
5176         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5177         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5178         * aarch64-tdep.c (aarch64_make_prologue_cache)
5179         (aarch64_make_stub_cache): Replace throw_exception with throw.
5180
5181 2019-04-08  Tom Tromey  <tom@tromey.com>
5182
5183         * common/common-exceptions.c (throw_exception): Rename from
5184         throw_exception_cxx.  Remove old copy.  Make argument const.
5185         (throw_it): Create and throw exception objects directly.
5186         * common/common-exceptions.h (throw_exception): Make argument
5187         const.
5188         (struct gdb_exception_error): Add constructor.
5189         (struct gdb_exception_quit): Add constructor.
5190
5191 2019-04-08  Tom Tromey  <tom@tromey.com>
5192
5193         * common/common-exceptions.h (exception_rethrow): Don't declare.
5194         (TRY_SJLJ): Update comment.
5195         (TRY, CATCH, END_CATCH): Remove.
5196         * common/common-exceptions.c (exception_rethrow): Remove.
5197
5198 2019-04-08  Tom Tromey  <tom@tromey.com>
5199
5200         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5201         Remove.
5202         (gdb_exception_error): Rename from
5203         gdb_exception_RETURN_MASK_ERROR.
5204         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5205         (gdb_quit_bad_alloc): Update.
5206         * aarch64-tdep.c: Update.
5207         * ada-lang.c: Update.
5208         * ada-typeprint.c: Update.
5209         * ada-valprint.c: Update.
5210         * amd64-tdep.c: Update.
5211         * arch-utils.c: Update.
5212         * break-catch-throw.c: Update.
5213         * breakpoint.c: Update.
5214         * btrace.c: Update.
5215         * c-varobj.c: Update.
5216         * cli/cli-cmds.c: Update.
5217         * cli/cli-interp.c: Update.
5218         * cli/cli-script.c: Update.
5219         * common/common-exceptions.c: Update.
5220         * common/new-op.c: Update.
5221         * common/selftest.c: Update.
5222         * compile/compile-c-symbols.c: Update.
5223         * compile/compile-cplus-symbols.c: Update.
5224         * compile/compile-object-load.c: Update.
5225         * compile/compile-object-run.c: Update.
5226         * completer.c: Update.
5227         * corelow.c: Update.
5228         * cp-abi.c: Update.
5229         * cp-support.c: Update.
5230         * cp-valprint.c: Update.
5231         * darwin-nat.c: Update.
5232         * disasm-selftests.c: Update.
5233         * dtrace-probe.c: Update.
5234         * dwarf-index-cache.c: Update.
5235         * dwarf-index-write.c: Update.
5236         * dwarf2-frame-tailcall.c: Update.
5237         * dwarf2-frame.c: Update.
5238         * dwarf2loc.c: Update.
5239         * dwarf2read.c: Update.
5240         * eval.c: Update.
5241         * event-loop.c: Update.
5242         * event-top.c: Update.
5243         * exec.c: Update.
5244         * f-valprint.c: Update.
5245         * fbsd-tdep.c: Update.
5246         * frame-unwind.c: Update.
5247         * frame.c: Update.
5248         * gdbtypes.c: Update.
5249         * gnu-v3-abi.c: Update.
5250         * guile/guile-internal.h: Update.
5251         * guile/scm-block.c: Update.
5252         * guile/scm-breakpoint.c: Update.
5253         * guile/scm-cmd.c: Update.
5254         * guile/scm-disasm.c: Update.
5255         * guile/scm-frame.c: Update.
5256         * guile/scm-lazy-string.c: Update.
5257         * guile/scm-math.c: Update.
5258         * guile/scm-param.c: Update.
5259         * guile/scm-ports.c: Update.
5260         * guile/scm-pretty-print.c: Update.
5261         * guile/scm-symbol.c: Update.
5262         * guile/scm-symtab.c: Update.
5263         * guile/scm-type.c: Update.
5264         * guile/scm-value.c: Update.
5265         * i386-linux-tdep.c: Update.
5266         * i386-tdep.c: Update.
5267         * inf-loop.c: Update.
5268         * infcall.c: Update.
5269         * infcmd.c: Update.
5270         * infrun.c: Update.
5271         * jit.c: Update.
5272         * language.c: Update.
5273         * linespec.c: Update.
5274         * linux-fork.c: Update.
5275         * linux-nat.c: Update.
5276         * linux-tdep.c: Update.
5277         * linux-thread-db.c: Update.
5278         * main.c: Update.
5279         * mi/mi-cmd-break.c: Update.
5280         * mi/mi-cmd-stack.c: Update.
5281         * mi/mi-interp.c: Update.
5282         * mi/mi-main.c: Update.
5283         * objc-lang.c: Update.
5284         * p-valprint.c: Update.
5285         * parse.c: Update.
5286         * ppc-linux-tdep.c: Update.
5287         * printcmd.c: Update.
5288         * python/py-arch.c: Update.
5289         * python/py-breakpoint.c: Update.
5290         * python/py-cmd.c: Update.
5291         * python/py-finishbreakpoint.c: Update.
5292         * python/py-frame.c: Update.
5293         * python/py-framefilter.c: Update.
5294         * python/py-gdb-readline.c: Update.
5295         * python/py-inferior.c: Update.
5296         * python/py-infthread.c: Update.
5297         * python/py-lazy-string.c: Update.
5298         * python/py-linetable.c: Update.
5299         * python/py-objfile.c: Update.
5300         * python/py-param.c: Update.
5301         * python/py-prettyprint.c: Update.
5302         * python/py-progspace.c: Update.
5303         * python/py-record-btrace.c: Update.
5304         * python/py-record.c: Update.
5305         * python/py-symbol.c: Update.
5306         * python/py-type.c: Update.
5307         * python/py-unwind.c: Update.
5308         * python/py-utils.c: Update.
5309         * python/py-value.c: Update.
5310         * python/python.c: Update.
5311         * record-btrace.c: Update.
5312         * record-full.c: Update.
5313         * remote-fileio.c: Update.
5314         * remote.c: Update.
5315         * riscv-tdep.c: Update.
5316         * rs6000-aix-tdep.c: Update.
5317         * rs6000-tdep.c: Update.
5318         * rust-exp.y: Update.
5319         * rust-lang.c: Update.
5320         * s390-tdep.c: Update.
5321         * selftest-arch.c: Update.
5322         * solib-dsbt.c: Update.
5323         * solib-frv.c: Update.
5324         * solib-spu.c: Update.
5325         * solib-svr4.c: Update.
5326         * solib.c: Update.
5327         * sparc64-linux-tdep.c: Update.
5328         * stack.c: Update.
5329         * symfile-mem.c: Update.
5330         * symmisc.c: Update.
5331         * target.c: Update.
5332         * thread.c: Update.
5333         * top.c: Update.
5334         * tracefile-tfile.c: Update.
5335         * tui/tui.c: Update.
5336         * typeprint.c: Update.
5337         * unittests/cli-utils-selftests.c: Update.
5338         * unittests/parse-connection-spec-selftests.c: Update.
5339         * valops.c: Update.
5340         * valprint.c: Update.
5341         * value.c: Update.
5342         * varobj.c: Update.
5343         * windows-nat.c: Update.
5344         * x86-linux-nat.c: Update.
5345         * xml-support.c: Update.
5346
5347 2019-04-08  Tom Tromey  <tom@tromey.com>
5348
5349         * xml-support.c: Use C++ exception handling.
5350         * x86-linux-nat.c: Use C++ exception handling.
5351         * windows-nat.c: Use C++ exception handling.
5352         * varobj.c: Use C++ exception handling.
5353         * value.c: Use C++ exception handling.
5354         * valprint.c: Use C++ exception handling.
5355         * valops.c: Use C++ exception handling.
5356         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5357         handling.
5358         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5359         * typeprint.c: Use C++ exception handling.
5360         * tui/tui.c: Use C++ exception handling.
5361         * tracefile-tfile.c: Use C++ exception handling.
5362         * top.c: Use C++ exception handling.
5363         * thread.c: Use C++ exception handling.
5364         * target.c: Use C++ exception handling.
5365         * symmisc.c: Use C++ exception handling.
5366         * symfile-mem.c: Use C++ exception handling.
5367         * stack.c: Use C++ exception handling.
5368         * sparc64-linux-tdep.c: Use C++ exception handling.
5369         * solib.c: Use C++ exception handling.
5370         * solib-svr4.c: Use C++ exception handling.
5371         * solib-spu.c: Use C++ exception handling.
5372         * solib-frv.c: Use C++ exception handling.
5373         * solib-dsbt.c: Use C++ exception handling.
5374         * selftest-arch.c: Use C++ exception handling.
5375         * s390-tdep.c: Use C++ exception handling.
5376         * rust-lang.c: Use C++ exception handling.
5377         * rust-exp.y: Use C++ exception handling.
5378         * rs6000-tdep.c: Use C++ exception handling.
5379         * rs6000-aix-tdep.c: Use C++ exception handling.
5380         * riscv-tdep.c: Use C++ exception handling.
5381         * remote.c: Use C++ exception handling.
5382         * remote-fileio.c: Use C++ exception handling.
5383         * record-full.c: Use C++ exception handling.
5384         * record-btrace.c: Use C++ exception handling.
5385         * python/python.c: Use C++ exception handling.
5386         * python/py-value.c: Use C++ exception handling.
5387         * python/py-utils.c: Use C++ exception handling.
5388         * python/py-unwind.c: Use C++ exception handling.
5389         * python/py-type.c: Use C++ exception handling.
5390         * python/py-symbol.c: Use C++ exception handling.
5391         * python/py-record.c: Use C++ exception handling.
5392         * python/py-record-btrace.c: Use C++ exception handling.
5393         * python/py-progspace.c: Use C++ exception handling.
5394         * python/py-prettyprint.c: Use C++ exception handling.
5395         * python/py-param.c: Use C++ exception handling.
5396         * python/py-objfile.c: Use C++ exception handling.
5397         * python/py-linetable.c: Use C++ exception handling.
5398         * python/py-lazy-string.c: Use C++ exception handling.
5399         * python/py-infthread.c: Use C++ exception handling.
5400         * python/py-inferior.c: Use C++ exception handling.
5401         * python/py-gdb-readline.c: Use C++ exception handling.
5402         * python/py-framefilter.c: Use C++ exception handling.
5403         * python/py-frame.c: Use C++ exception handling.
5404         * python/py-finishbreakpoint.c: Use C++ exception handling.
5405         * python/py-cmd.c: Use C++ exception handling.
5406         * python/py-breakpoint.c: Use C++ exception handling.
5407         * python/py-arch.c: Use C++ exception handling.
5408         * printcmd.c: Use C++ exception handling.
5409         * ppc-linux-tdep.c: Use C++ exception handling.
5410         * parse.c: Use C++ exception handling.
5411         * p-valprint.c: Use C++ exception handling.
5412         * objc-lang.c: Use C++ exception handling.
5413         * mi/mi-main.c: Use C++ exception handling.
5414         * mi/mi-interp.c: Use C++ exception handling.
5415         * mi/mi-cmd-stack.c: Use C++ exception handling.
5416         * mi/mi-cmd-break.c: Use C++ exception handling.
5417         * main.c: Use C++ exception handling.
5418         * linux-thread-db.c: Use C++ exception handling.
5419         * linux-tdep.c: Use C++ exception handling.
5420         * linux-nat.c: Use C++ exception handling.
5421         * linux-fork.c: Use C++ exception handling.
5422         * linespec.c: Use C++ exception handling.
5423         * language.c: Use C++ exception handling.
5424         * jit.c: Use C++ exception handling.
5425         * infrun.c: Use C++ exception handling.
5426         * infcmd.c: Use C++ exception handling.
5427         * infcall.c: Use C++ exception handling.
5428         * inf-loop.c: Use C++ exception handling.
5429         * i386-tdep.c: Use C++ exception handling.
5430         * i386-linux-tdep.c: Use C++ exception handling.
5431         * guile/scm-value.c: Use C++ exception handling.
5432         * guile/scm-type.c: Use C++ exception handling.
5433         * guile/scm-symtab.c: Use C++ exception handling.
5434         * guile/scm-symbol.c: Use C++ exception handling.
5435         * guile/scm-pretty-print.c: Use C++ exception handling.
5436         * guile/scm-ports.c: Use C++ exception handling.
5437         * guile/scm-param.c: Use C++ exception handling.
5438         * guile/scm-math.c: Use C++ exception handling.
5439         * guile/scm-lazy-string.c: Use C++ exception handling.
5440         * guile/scm-frame.c: Use C++ exception handling.
5441         * guile/scm-disasm.c: Use C++ exception handling.
5442         * guile/scm-cmd.c: Use C++ exception handling.
5443         * guile/scm-breakpoint.c: Use C++ exception handling.
5444         * guile/scm-block.c: Use C++ exception handling.
5445         * guile/guile-internal.h: Use C++ exception handling.
5446         * gnu-v3-abi.c: Use C++ exception handling.
5447         * gdbtypes.c: Use C++ exception handling.
5448         * frame.c: Use C++ exception handling.
5449         * frame-unwind.c: Use C++ exception handling.
5450         * fbsd-tdep.c: Use C++ exception handling.
5451         * f-valprint.c: Use C++ exception handling.
5452         * exec.c: Use C++ exception handling.
5453         * event-top.c: Use C++ exception handling.
5454         * event-loop.c: Use C++ exception handling.
5455         * eval.c: Use C++ exception handling.
5456         * dwarf2read.c: Use C++ exception handling.
5457         * dwarf2loc.c: Use C++ exception handling.
5458         * dwarf2-frame.c: Use C++ exception handling.
5459         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5460         * dwarf-index-write.c: Use C++ exception handling.
5461         * dwarf-index-cache.c: Use C++ exception handling.
5462         * dtrace-probe.c: Use C++ exception handling.
5463         * disasm-selftests.c: Use C++ exception handling.
5464         * darwin-nat.c: Use C++ exception handling.
5465         * cp-valprint.c: Use C++ exception handling.
5466         * cp-support.c: Use C++ exception handling.
5467         * cp-abi.c: Use C++ exception handling.
5468         * corelow.c: Use C++ exception handling.
5469         * completer.c: Use C++ exception handling.
5470         * compile/compile-object-run.c: Use C++ exception handling.
5471         * compile/compile-object-load.c: Use C++ exception handling.
5472         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5473         * compile/compile-c-symbols.c: Use C++ exception handling.
5474         * common/selftest.c: Use C++ exception handling.
5475         * common/new-op.c: Use C++ exception handling.
5476         * cli/cli-script.c: Use C++ exception handling.
5477         * cli/cli-interp.c: Use C++ exception handling.
5478         * cli/cli-cmds.c: Use C++ exception handling.
5479         * c-varobj.c: Use C++ exception handling.
5480         * btrace.c: Use C++ exception handling.
5481         * breakpoint.c: Use C++ exception handling.
5482         * break-catch-throw.c: Use C++ exception handling.
5483         * arch-utils.c: Use C++ exception handling.
5484         * amd64-tdep.c: Use C++ exception handling.
5485         * ada-valprint.c: Use C++ exception handling.
5486         * ada-typeprint.c: Use C++ exception handling.
5487         * ada-lang.c: Use C++ exception handling.
5488         * aarch64-tdep.c: Use C++ exception handling.
5489
5490 2019-04-08  Tom Tromey  <tom@tromey.com>
5491
5492         * xml-support.c (gdb_xml_parser::parse): Update.
5493         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5494         * value.c (show_convenience): Update.
5495         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5496         (test_parse_flags_qcs): Update.
5497         * thread.c (thr_try_catch_cmd): Update.
5498         * target.c (target_translate_tls_address): Update.
5499         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5500         (info_frame_command_core, frame_apply_command_count): Update.
5501         * rust-exp.y (rust_lex_exception_test): Update.
5502         * riscv-tdep.c (riscv_print_one_register_info): Update.
5503         * remote.c (remote_target::enable_btrace): Update.
5504         * record-btrace.c (record_btrace_enable_warn): Update.
5505         * python/py-utils.c (gdbpy_convert_exception): Update.
5506         * printcmd.c (do_one_display, print_variable_and_value): Update.
5507         * mi/mi-main.c (mi_print_exception): Update.
5508         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5509         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5510         * linux-nat.c (linux_nat_target::attach): Update.
5511         * linux-fork.c (class scoped_switch_fork_info): Update.
5512         * infrun.c (displaced_step_prepare): Update.
5513         * infcall.c (call_function_by_hand_dummy): Update.
5514         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5515         * gnu-v3-abi.c (print_one_vtable): Update.
5516         * frame.c (get_prev_frame_always): Update.
5517         * f-valprint.c (info_common_command_for_block): Update.
5518         * exec.c (try_open_exec_file): Update.
5519         * exceptions.c (print_exception, exception_print)
5520         (exception_fprintf, exception_print_same): Update.
5521         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5522         * dwarf-index-cache.c (index_cache::store)
5523         (index_cache::lookup_gdb_index): Update.
5524         * darwin-nat.c (maybe_cache_shell): Update.
5525         * cp-valprint.c (cp_print_value_fields): Update.
5526         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5527         (gcc_cplus_symbol_address): Update.
5528         * compile/compile-c-symbols.c (gcc_convert_symbol)
5529         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5530         * common/selftest.c: Update.
5531         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5532         a std::string.
5533         (exception_try_scope_entry, exception_try_scope_exit): Don't
5534         declare.
5535         (struct exception_try_scope): Remove.
5536         (TRY): Don't use exception_try_scope.
5537         (struct gdb_exception): Add constructor, operator=.
5538         <what>: New method.
5539         (struct gdb_exception_RETURN_MASK_ALL)
5540         (struct gdb_exception_RETURN_MASK_ERROR)
5541         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5542         (struct gdb_quit_bad_alloc): Update.
5543         * common/common-exceptions.c (exception_none): Change
5544         initializer.
5545         (struct catcher) <state, exception>: Initialize inline.
5546         <prev>: Remove member.
5547         (current_catcher): Remove.
5548         (catchers): New global.
5549         (exceptions_state_mc_init): Simplify.
5550         (catcher_pop): Remove.
5551         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5552         (try_scope_depth, exception_try_scope_entry)
5553         (exception_try_scope_exit): Remove.
5554         (throw_exception_sjlj): Update.
5555         (exception_messages, exception_messages_size): Remove.
5556         (throw_it): Simplify.
5557         (gdb_exception_sliced_copy): Remove.
5558         (throw_exception_cxx): Update.
5559         * cli/cli-script.c (script_from_file): Update.
5560         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5561         Update.
5562         * ada-valprint.c (ada_val_print): Update.
5563         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5564         (create_excep_cond_exprs): Update.
5565
5566 2019-04-08  Tom Tromey  <tom@tromey.com>
5567
5568         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5569         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5570         (TRY, CATCH, END_CATCH): Remove some definitions.
5571         * common/common-exceptions.c: Don't use GDB_XCPT.
5572         (catcher_list_size): Remove.
5573         (throw_exception, throw_it): Simplify.
5574
5575 2019-04-05  Tom Tromey  <tom@tromey.com>
5576
5577         Revert the header-sorting patch.
5578         * ft32-tdep.c: Revert.
5579         * frv-tdep.c: Revert.
5580         * frv-linux-tdep.c: Revert.
5581         * frame.c: Revert.
5582         * frame-unwind.c: Revert.
5583         * frame-base.c: Revert.
5584         * fork-child.c: Revert.
5585         * findvar.c: Revert.
5586         * findcmd.c: Revert.
5587         * filesystem.c: Revert.
5588         * filename-seen-cache.h: Revert.
5589         * filename-seen-cache.c: Revert.
5590         * fbsd-tdep.c: Revert.
5591         * fbsd-nat.h: Revert.
5592         * fbsd-nat.c: Revert.
5593         * f-valprint.c: Revert.
5594         * f-typeprint.c: Revert.
5595         * f-lang.c: Revert.
5596         * extension.h: Revert.
5597         * extension.c: Revert.
5598         * extension-priv.h: Revert.
5599         * expprint.c: Revert.
5600         * exec.h: Revert.
5601         * exec.c: Revert.
5602         * exceptions.c: Revert.
5603         * event-top.c: Revert.
5604         * event-loop.c: Revert.
5605         * eval.c: Revert.
5606         * elfread.c: Revert.
5607         * dwarf2read.h: Revert.
5608         * dwarf2read.c: Revert.
5609         * dwarf2loc.c: Revert.
5610         * dwarf2expr.h: Revert.
5611         * dwarf2expr.c: Revert.
5612         * dwarf2-frame.c: Revert.
5613         * dwarf2-frame-tailcall.c: Revert.
5614         * dwarf-index-write.h: Revert.
5615         * dwarf-index-write.c: Revert.
5616         * dwarf-index-common.c: Revert.
5617         * dwarf-index-cache.h: Revert.
5618         * dwarf-index-cache.c: Revert.
5619         * dummy-frame.c: Revert.
5620         * dtrace-probe.c: Revert.
5621         * disasm.h: Revert.
5622         * disasm.c: Revert.
5623         * disasm-selftests.c: Revert.
5624         * dictionary.c: Revert.
5625         * dicos-tdep.c: Revert.
5626         * demangle.c: Revert.
5627         * dcache.h: Revert.
5628         * dcache.c: Revert.
5629         * darwin-nat.h: Revert.
5630         * darwin-nat.c: Revert.
5631         * darwin-nat-info.c: Revert.
5632         * d-valprint.c: Revert.
5633         * d-namespace.c: Revert.
5634         * d-lang.c: Revert.
5635         * ctf.c: Revert.
5636         * csky-tdep.c: Revert.
5637         * csky-linux-tdep.c: Revert.
5638         * cris-tdep.c: Revert.
5639         * cris-linux-tdep.c: Revert.
5640         * cp-valprint.c: Revert.
5641         * cp-support.c: Revert.
5642         * cp-namespace.c: Revert.
5643         * cp-abi.c: Revert.
5644         * corelow.c: Revert.
5645         * corefile.c: Revert.
5646         * continuations.c: Revert.
5647         * completer.h: Revert.
5648         * completer.c: Revert.
5649         * complaints.c: Revert.
5650         * coffread.c: Revert.
5651         * coff-pe-read.c: Revert.
5652         * cli-out.h: Revert.
5653         * cli-out.c: Revert.
5654         * charset.c: Revert.
5655         * c-varobj.c: Revert.
5656         * c-valprint.c: Revert.
5657         * c-typeprint.c: Revert.
5658         * c-lang.c: Revert.
5659         * buildsym.c: Revert.
5660         * buildsym-legacy.c: Revert.
5661         * build-id.h: Revert.
5662         * build-id.c: Revert.
5663         * btrace.c: Revert.
5664         * bsd-uthread.c: Revert.
5665         * breakpoint.h: Revert.
5666         * breakpoint.c: Revert.
5667         * break-catch-throw.c: Revert.
5668         * break-catch-syscall.c: Revert.
5669         * break-catch-sig.c: Revert.
5670         * blockframe.c: Revert.
5671         * block.c: Revert.
5672         * bfin-tdep.c: Revert.
5673         * bfin-linux-tdep.c: Revert.
5674         * bfd-target.c: Revert.
5675         * bcache.c: Revert.
5676         * ax-general.c: Revert.
5677         * ax-gdb.h: Revert.
5678         * ax-gdb.c: Revert.
5679         * avr-tdep.c: Revert.
5680         * auxv.c: Revert.
5681         * auto-load.c: Revert.
5682         * arm-wince-tdep.c: Revert.
5683         * arm-tdep.c: Revert.
5684         * arm-symbian-tdep.c: Revert.
5685         * arm-pikeos-tdep.c: Revert.
5686         * arm-obsd-tdep.c: Revert.
5687         * arm-nbsd-tdep.c: Revert.
5688         * arm-nbsd-nat.c: Revert.
5689         * arm-linux-tdep.c: Revert.
5690         * arm-linux-nat.c: Revert.
5691         * arm-fbsd-tdep.c: Revert.
5692         * arm-fbsd-nat.c: Revert.
5693         * arm-bsd-tdep.c: Revert.
5694         * arch-utils.c: Revert.
5695         * arc-tdep.c: Revert.
5696         * arc-newlib-tdep.c: Revert.
5697         * annotate.h: Revert.
5698         * annotate.c: Revert.
5699         * amd64-windows-tdep.c: Revert.
5700         * amd64-windows-nat.c: Revert.
5701         * amd64-tdep.c: Revert.
5702         * amd64-sol2-tdep.c: Revert.
5703         * amd64-obsd-tdep.c: Revert.
5704         * amd64-obsd-nat.c: Revert.
5705         * amd64-nbsd-tdep.c: Revert.
5706         * amd64-nbsd-nat.c: Revert.
5707         * amd64-nat.c: Revert.
5708         * amd64-linux-tdep.c: Revert.
5709         * amd64-linux-nat.c: Revert.
5710         * amd64-fbsd-tdep.c: Revert.
5711         * amd64-fbsd-nat.c: Revert.
5712         * amd64-dicos-tdep.c: Revert.
5713         * amd64-darwin-tdep.c: Revert.
5714         * amd64-bsd-nat.c: Revert.
5715         * alpha-tdep.c: Revert.
5716         * alpha-obsd-tdep.c: Revert.
5717         * alpha-nbsd-tdep.c: Revert.
5718         * alpha-mdebug-tdep.c: Revert.
5719         * alpha-linux-tdep.c: Revert.
5720         * alpha-linux-nat.c: Revert.
5721         * alpha-bsd-tdep.c: Revert.
5722         * alpha-bsd-nat.c: Revert.
5723         * aix-thread.c: Revert.
5724         * agent.c: Revert.
5725         * addrmap.c: Revert.
5726         * ada-varobj.c: Revert.
5727         * ada-valprint.c: Revert.
5728         * ada-typeprint.c: Revert.
5729         * ada-tasks.c: Revert.
5730         * ada-lang.c: Revert.
5731         * aarch64-tdep.c: Revert.
5732         * aarch64-ravenscar-thread.c: Revert.
5733         * aarch64-newlib-tdep.c: Revert.
5734         * aarch64-linux-tdep.c: Revert.
5735         * aarch64-linux-nat.c: Revert.
5736         * aarch64-fbsd-tdep.c: Revert.
5737         * aarch64-fbsd-nat.c: Revert.
5738         * aarch32-linux-nat.c: Revert.
5739
5740 2019-04-05  Tom Tromey  <tom@tromey.com>
5741
5742         * ft32-tdep.c: Sort headers.
5743         * frv-tdep.c: Sort headers.
5744         * frv-linux-tdep.c: Sort headers.
5745         * frame.c: Sort headers.
5746         * frame-unwind.c: Sort headers.
5747         * frame-base.c: Sort headers.
5748         * fork-child.c: Sort headers.
5749         * findvar.c: Sort headers.
5750         * findcmd.c: Sort headers.
5751         * filesystem.c: Sort headers.
5752         * filename-seen-cache.h: Sort headers.
5753         * filename-seen-cache.c: Sort headers.
5754         * fbsd-tdep.c: Sort headers.
5755         * fbsd-nat.h: Sort headers.
5756         * fbsd-nat.c: Sort headers.
5757         * f-valprint.c: Sort headers.
5758         * f-typeprint.c: Sort headers.
5759         * f-lang.c: Sort headers.
5760         * extension.h: Sort headers.
5761         * extension.c: Sort headers.
5762         * extension-priv.h: Sort headers.
5763         * expprint.c: Sort headers.
5764         * exec.h: Sort headers.
5765         * exec.c: Sort headers.
5766         * exceptions.c: Sort headers.
5767         * event-top.c: Sort headers.
5768         * event-loop.c: Sort headers.
5769         * eval.c: Sort headers.
5770         * elfread.c: Sort headers.
5771         * dwarf2read.h: Sort headers.
5772         * dwarf2read.c: Sort headers.
5773         * dwarf2loc.c: Sort headers.
5774         * dwarf2expr.h: Sort headers.
5775         * dwarf2expr.c: Sort headers.
5776         * dwarf2-frame.c: Sort headers.
5777         * dwarf2-frame-tailcall.c: Sort headers.
5778         * dwarf-index-write.h: Sort headers.
5779         * dwarf-index-write.c: Sort headers.
5780         * dwarf-index-common.c: Sort headers.
5781         * dwarf-index-cache.h: Sort headers.
5782         * dwarf-index-cache.c: Sort headers.
5783         * dummy-frame.c: Sort headers.
5784         * dtrace-probe.c: Sort headers.
5785         * disasm.h: Sort headers.
5786         * disasm.c: Sort headers.
5787         * disasm-selftests.c: Sort headers.
5788         * dictionary.c: Sort headers.
5789         * dicos-tdep.c: Sort headers.
5790         * demangle.c: Sort headers.
5791         * dcache.h: Sort headers.
5792         * dcache.c: Sort headers.
5793         * darwin-nat.h: Sort headers.
5794         * darwin-nat.c: Sort headers.
5795         * darwin-nat-info.c: Sort headers.
5796         * d-valprint.c: Sort headers.
5797         * d-namespace.c: Sort headers.
5798         * d-lang.c: Sort headers.
5799         * ctf.c: Sort headers.
5800         * csky-tdep.c: Sort headers.
5801         * csky-linux-tdep.c: Sort headers.
5802         * cris-tdep.c: Sort headers.
5803         * cris-linux-tdep.c: Sort headers.
5804         * cp-valprint.c: Sort headers.
5805         * cp-support.c: Sort headers.
5806         * cp-namespace.c: Sort headers.
5807         * cp-abi.c: Sort headers.
5808         * corelow.c: Sort headers.
5809         * corefile.c: Sort headers.
5810         * continuations.c: Sort headers.
5811         * completer.h: Sort headers.
5812         * completer.c: Sort headers.
5813         * complaints.c: Sort headers.
5814         * coffread.c: Sort headers.
5815         * coff-pe-read.c: Sort headers.
5816         * cli-out.h: Sort headers.
5817         * cli-out.c: Sort headers.
5818         * charset.c: Sort headers.
5819         * c-varobj.c: Sort headers.
5820         * c-valprint.c: Sort headers.
5821         * c-typeprint.c: Sort headers.
5822         * c-lang.c: Sort headers.
5823         * buildsym.c: Sort headers.
5824         * buildsym-legacy.c: Sort headers.
5825         * build-id.h: Sort headers.
5826         * build-id.c: Sort headers.
5827         * btrace.c: Sort headers.
5828         * bsd-uthread.c: Sort headers.
5829         * breakpoint.h: Sort headers.
5830         * breakpoint.c: Sort headers.
5831         * break-catch-throw.c: Sort headers.
5832         * break-catch-syscall.c: Sort headers.
5833         * break-catch-sig.c: Sort headers.
5834         * blockframe.c: Sort headers.
5835         * block.c: Sort headers.
5836         * bfin-tdep.c: Sort headers.
5837         * bfin-linux-tdep.c: Sort headers.
5838         * bfd-target.c: Sort headers.
5839         * bcache.c: Sort headers.
5840         * ax-general.c: Sort headers.
5841         * ax-gdb.h: Sort headers.
5842         * ax-gdb.c: Sort headers.
5843         * avr-tdep.c: Sort headers.
5844         * auxv.c: Sort headers.
5845         * auto-load.c: Sort headers.
5846         * arm-wince-tdep.c: Sort headers.
5847         * arm-tdep.c: Sort headers.
5848         * arm-symbian-tdep.c: Sort headers.
5849         * arm-pikeos-tdep.c: Sort headers.
5850         * arm-obsd-tdep.c: Sort headers.
5851         * arm-nbsd-tdep.c: Sort headers.
5852         * arm-nbsd-nat.c: Sort headers.
5853         * arm-linux-tdep.c: Sort headers.
5854         * arm-linux-nat.c: Sort headers.
5855         * arm-fbsd-tdep.c: Sort headers.
5856         * arm-fbsd-nat.c: Sort headers.
5857         * arm-bsd-tdep.c: Sort headers.
5858         * arch-utils.c: Sort headers.
5859         * arc-tdep.c: Sort headers.
5860         * arc-newlib-tdep.c: Sort headers.
5861         * annotate.h: Sort headers.
5862         * annotate.c: Sort headers.
5863         * amd64-windows-tdep.c: Sort headers.
5864         * amd64-windows-nat.c: Sort headers.
5865         * amd64-tdep.c: Sort headers.
5866         * amd64-sol2-tdep.c: Sort headers.
5867         * amd64-obsd-tdep.c: Sort headers.
5868         * amd64-obsd-nat.c: Sort headers.
5869         * amd64-nbsd-tdep.c: Sort headers.
5870         * amd64-nbsd-nat.c: Sort headers.
5871         * amd64-nat.c: Sort headers.
5872         * amd64-linux-tdep.c: Sort headers.
5873         * amd64-linux-nat.c: Sort headers.
5874         * amd64-fbsd-tdep.c: Sort headers.
5875         * amd64-fbsd-nat.c: Sort headers.
5876         * amd64-dicos-tdep.c: Sort headers.
5877         * amd64-darwin-tdep.c: Sort headers.
5878         * amd64-bsd-nat.c: Sort headers.
5879         * alpha-tdep.c: Sort headers.
5880         * alpha-obsd-tdep.c: Sort headers.
5881         * alpha-nbsd-tdep.c: Sort headers.
5882         * alpha-mdebug-tdep.c: Sort headers.
5883         * alpha-linux-tdep.c: Sort headers.
5884         * alpha-linux-nat.c: Sort headers.
5885         * alpha-bsd-tdep.c: Sort headers.
5886         * alpha-bsd-nat.c: Sort headers.
5887         * aix-thread.c: Sort headers.
5888         * agent.c: Sort headers.
5889         * addrmap.c: Sort headers.
5890         * ada-varobj.c: Sort headers.
5891         * ada-valprint.c: Sort headers.
5892         * ada-typeprint.c: Sort headers.
5893         * ada-tasks.c: Sort headers.
5894         * ada-lang.c: Sort headers.
5895         * aarch64-tdep.c: Sort headers.
5896         * aarch64-ravenscar-thread.c: Sort headers.
5897         * aarch64-newlib-tdep.c: Sort headers.
5898         * aarch64-linux-tdep.c: Sort headers.
5899         * aarch64-linux-nat.c: Sort headers.
5900         * aarch64-fbsd-tdep.c: Sort headers.
5901         * aarch64-fbsd-nat.c: Sort headers.
5902         * aarch32-linux-nat.c: Sort headers.
5903
5904 2019-04-04  Tom Tromey  <tom@tromey.com>
5905
5906         * varobj.c (varobj_create): Update.
5907         * rust-exp.y (struct rust_parser) <update_innermost_block,
5908         lookup_symbol>: New methods.
5909         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5910         Rename.
5911         (rust_parser::rust_lookup_type)
5912         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5913         * printcmd.c (display_command, do_one_display): Update.
5914         * parser-defs.h (struct parser_state) <parser_state>: Add
5915         "tracker" parameter.
5916         (block_tracker): New member.
5917         (class innermost_block_tracker) <innermost_block_tracker>: Add
5918         "types" parameter.
5919         <reset>: Remove method.
5920         (innermost_block): Don't declare.
5921         (null_post_parser): Update.
5922         * parse.c (innermost_block): Remove global.
5923         (write_dollar_variable): Update.
5924         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5925         Remove "tracker_types" parameter.
5926         (parse_expression): Add "tracker" parameter.
5927         (parse_expression_for_completion): Update.
5928         (null_post_parser): Add "tracker" parameter.
5929         * p-exp.y: Update rules.
5930         * m2-exp.y: Update rules.
5931         * language.h (struct language_defn) <la_post_parser>: Add
5932         "tracker" parameter.
5933         * go-exp.y: Update rules.
5934         * f-exp.y: Update rules.
5935         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5936         parameter.
5937         * d-exp.y: Update rules.
5938         * c-exp.y: Update rules.
5939         * breakpoint.c (set_breakpoint_condition): Create an
5940         innermost_block_tracker.
5941         (watch_command_1): Likewise.
5942         * ada-lang.c (resolve): Add "tracker" parameter.
5943         (resolve_subexp): Likewise.
5944         * ada-exp.y (write_var_from_sym): Update.
5945
5946 2019-04-04  Tom Tromey  <tom@tromey.com>
5947
5948         * type-stack.h: New file.
5949         * type-stack.c: New file.
5950         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5951         type-stack.h.
5952         (insert_into_type_stack, insert_type, push_type, push_type_int)
5953         (insert_type_address_space, pop_type, pop_type_int)
5954         (pop_typelist, pop_type_stack, append_type_stack)
5955         (push_type_stack, get_type_stack, push_typelist)
5956         (follow_type_instance_flags, follow_types): Don't declare.
5957         * parse.c (type_stack): Remove global.
5958         (parse_exp_in_context): Update.
5959         (insert_into_type_stack, insert_type, push_type, push_type_int)
5960         (insert_type_address_space, pop_type, pop_type_int)
5961         (pop_typelist, pop_type_stack, append_type_stack)
5962         (push_type_stack, get_type_stack, push_typelist)
5963         (follow_type_instance_flags, follow_types): Remove (moved to
5964         type-stack.c).
5965         * f-exp.y (type_stack): New global.
5966         Update rules.
5967         (push_kind_type, f_parse): Update.
5968         * d-exp.y (type_stack): New global.
5969         Update rules.
5970         (d_parse): Update.
5971         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5972         Update rules.
5973         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5974         (HFILES_NO_SRCDIR): Add type-stack.h.
5975
5976 2019-04-04  Tom Tromey  <tom@tromey.com>
5977
5978         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5979         (rust_parser::convert_ast_to_expression, rust_parse)
5980         (rust_lex_test_completion, rust_lex_tests): Update.
5981         * parser-defs.h (struct expr_completion_state): New.
5982         (struct parser_state) <parser_state>: Add completion parameter.
5983         <mark_struct_expression, mark_completion_tag>: New methods.
5984         <parse_completion, m_completion_state>: New members.
5985         (prefixify_expression, null_post_parser): Update.
5986         (mark_struct_expression, mark_completion_tag): Don't declare.
5987         * parse.c (parse_completion, expout_last_struct)
5988         (expout_tag_completion_type, expout_completion_name): Remove
5989         globals.
5990         (parser_state::mark_struct_expression)
5991         (parser_state::mark_completion_tag): Now methods.
5992         (prefixify_expression): Add last_struct parameter.
5993         (prefixify_subexp): Likewise.
5994         (parse_exp_1): Update.
5995         (parse_exp_in_context): Add cstate parameter.  Update.
5996         (parse_expression_for_completion): Create an
5997         expr_completion_state.
5998         (null_post_parser): Add "completion" parameter.
5999         * p-exp.y: Update rules.
6000         (yylex): Update.
6001         * language.h (struct language_defn) <la_post_parser>: Add
6002         "completing" parameter.
6003         * go-exp.y: Update rules.
6004         (lex_one_token): Update.
6005         * expression.h (parse_completion): Don't declare.
6006         * d-exp.y: Update rules.
6007         (lex_one_token): Update rules.
6008         * c-exp.y: Update rules.
6009         (lex_one_token): Update.
6010         * ada-lang.c (resolve): Add "parse_completion" parameter.
6011         (resolve_subexp): Likewise.
6012         (ada_resolve_function): Likewise.
6013
6014 2019-04-04  Tom Tromey  <tom@tromey.com>
6015
6016         * parser-defs.h (struct parser_state) <start_arglist,
6017         end_arglist>: New methods.
6018         <arglist_len, m_funcall_chain>: New members.
6019         (arglist_len, start_arglist, end_arglist): Don't declare.
6020         * parse.c (arglist_len, funcall_chain): Remove global.
6021         (start_arglist, end_arglist): Remove functions.
6022         (parse_exp_in_context): Update.
6023         * p-exp.y: Update rules.
6024         * m2-exp.y: Update rules.
6025         * go-exp.y: Update rules.
6026         * f-exp.y: Update rules.
6027         * d-exp.y: Update rules.
6028         * c-exp.y: Update rules.
6029
6030 2019-04-04  Tom Tromey  <tom@tromey.com>
6031
6032         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6033         lex_operator, push_back>: New methods.
6034         Update all rules.
6035         (rust_parser::lex_hex, lex_escape): Rename and update.
6036         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6037         (rust_parser::lex_operator): Rename and update.
6038         (rust_parser::lex_number, rustyylex, rustyyerror)
6039         (rust_lex_test_init, rust_lex_test_sequence)
6040         (rust_lex_test_push_back, rust_lex_tests): Update.
6041         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6042         parameter.
6043         <lexptr, prev_lexptr>: New members.
6044         (lexptr, prev_lexptr): Don't declare.
6045         * parse.c (lexptr, prev_lexptr): Remove globals.
6046         (parse_exp_in_context): Update.
6047         * p-exp.y (yylex, yyerror): Update.
6048         * m2-exp.y (parse_number, yylex, yyerror): Update.
6049         * go-exp.y (lex_one_token, yyerror): Update.
6050         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6051         * d-exp.y (lex_one_token, yyerror): Update.
6052         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6053         (lex_one_token, yyerror): Update.
6054         * ada-lex.l (YY_INPUT): Update.
6055         (rewind_to_char): Update.
6056         * ada-exp.y (yyerror): Update.
6057
6058 2019-04-04  Tom Tromey  <tom@tromey.com>
6059
6060         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6061         * parser-defs.h (struct parser_state) <parser_state>: Add new
6062         parameter.
6063         <comma_terminates>: New member.
6064         (comma_terminates): Don't declare global.
6065         * parse.c (comma_terminates): Remove global.
6066         (parse_exp_in_context): Update.
6067         * p-exp.y (yylex): Update.
6068         * m2-exp.y (yylex): Update.
6069         * go-exp.y (lex_one_token): Update.
6070         * f-exp.y (yylex): Update.
6071         * d-exp.y (lex_one_token): Update.
6072         * c-exp.y (lex_one_token): Update.
6073         * ada-lex.l: Update.
6074
6075 2019-04-04  Tom Tromey  <tom@tromey.com>
6076
6077         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6078         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6079         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6080         * parser-defs.h (paren_depth): Don't declare.
6081         * parse.c (paren_depth): Remove global.
6082         (parse_exp_in_context): Update.
6083         * p-exp.y (paren_depth): New global.
6084         (pascal_parse): Initialize it.
6085         * m2-exp.y (paren_depth): New global.
6086         (m2_parse): Initialize it.
6087         * go-exp.y (paren_depth): New global.
6088         (go_parse): Initialize it.
6089         * f-exp.y (paren_depth): New global.
6090         (f_parse): Initialize it.
6091         * d-exp.y (paren_depth): New global.
6092         (d_parse): Initialize it.
6093         * c-exp.y (paren_depth): New global.
6094         (c_parse): Initialize it.
6095         * ada-lex.l (paren_depth): New global.
6096         (lexer_init): Initialize it.
6097
6098 2019-04-04  Tom Tromey  <tom@tromey.com>
6099
6100         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6101         (rust_parser::convert_ast_to_type)
6102         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6103         * parser-defs.h (struct parser_state) <parser_state>: Add
6104         parameters.  Initialize new members.
6105         <expression_context_block, expression_context_pc>: New members.
6106         * parse.c (expression_context_block, expression_context_pc):
6107         Remove globals.
6108         (parse_exp_in_context): Update.
6109         * p-exp.y: Update all rules.
6110         (yylex): Update.
6111         * m2-exp.y: Update all rules.
6112         (yylex): Update.
6113         * go-exp.y (yylex): Update.
6114         * f-exp.y (yylex): Update.
6115         * d-exp.y: Update all rules.
6116         (yylex): Update.
6117         * c-exp.y: Update all rules.
6118         (lex_one_token, classify_name, yylex, c_parse): Update.
6119         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6120
6121 2019-04-04  Tom Tromey  <tom@tromey.com>
6122
6123         * gdbarch.h, gdbarch.c: Rebuild.
6124         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6125         * stap-probe.h:
6126         (struct stap_parse_info): Replace "parser_state" with
6127         "expr_builder".
6128         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6129         (parser_state): New class.
6130         * parse.c (expr_builder): Rename.
6131         (expr_builder::release): Rename.
6132         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6133         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6134         (write_exp_elt_longcst, write_exp_elt_floatcst)
6135         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6136         (write_exp_string_vector, write_exp_bitstring)
6137         (write_exp_msymbol, mark_struct_expression)
6138         (write_dollar_variable)
6139         (insert_type_address_space, increase_expout_size): Replace
6140         "parser_state" with "expr_builder".
6141         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6142         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6143         "parser_state" with "expr_builder".
6144
6145 2019-04-04  Tom Tromey  <tom@tromey.com>
6146
6147         * rust-exp.y: Replace "parse_language" with method call.
6148         * p-exp.y:
6149         (yylex): Replace "parse_language" with method call.
6150         * m2-exp.y:
6151         (yylex): Replace "parse_language" with method call.
6152         * go-exp.y (classify_name): Replace "parse_language" with method
6153         call.
6154         * f-exp.y (yylex): Replace "parse_language" with method call.
6155         * d-exp.y (lex_one_token): Replace "parse_language" with method
6156         call.
6157         * c-exp.y:
6158         (lex_one_token, classify_name, yylex): Replace "parse_language"
6159         with method call.
6160         * ada-exp.y (find_primitive_type, type_char)
6161         (type_system_address): Replace "parse_language" with method call.
6162
6163 2019-04-04  Tom Tromey  <tom@tromey.com>
6164
6165         * rust-exp.y: Replace "parse_gdbarch" with method call.
6166         * parse.c (write_dollar_variable, insert_type_address_space):
6167         Replace "parse_gdbarch" with method call.
6168         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6169         call.
6170         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6171         call.
6172         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6173         "parse_gdbarch" with method call.
6174         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6175         with method call.
6176         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6177         "parse_gdbarch" with method call.
6178         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6179         "parse_gdbarch" with method call.
6180         * c-exp.y (parse_type, parse_number, classify_name): Replace
6181         "parse_gdbarch" with method call.
6182         * ada-lex.l: Replace "parse_gdbarch" with method call.
6183         * ada-exp.y (parse_type, find_primitive_type, type_char)
6184         (type_system_address): Replace "parse_gdbarch" with method call.
6185
6186 2019-04-04  Tom Tromey  <tom@tromey.com>
6187
6188         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6189         * stap-probe.c (stap_parse_argument): Update.
6190         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6191         initial_size parameter.
6192         * rust-exp.y (rust_lex_tests): Update.
6193         * parse.c (parser_state): Update.
6194         (parse_exp_in_context): Update.
6195         * parser-defs.h (struct parser_state) <parser_state>: Remove
6196         "initial_size" parameter.
6197
6198 2019-04-04  Tom Tromey  <tom@tromey.com>
6199
6200         * parser-defs.h (increase_expout_size): Don't declare.
6201         * parse.c (increase_expout_size): Now static.
6202
6203 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6204
6205         * gnu-nat.c (gnu_nat_target::wait): Fix
6206         target_waitstatus_to_string call.
6207
6208 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * eval.c (evaluate_subexp_standard): Handle internal functions
6211         during Fortran function call handling.
6212
6213 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6214
6215         * NEWS: Mention new internal functions.
6216         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6217         (read_base_type): Use dwarf2_init_complex_target_type.
6218         * value.c (creal_internal_fn): New function.
6219         (cimag_internal_fn): New function.
6220         (_initialize_values): Register new internal functions.
6221
6222 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6223
6224         * infrun.c (stop_all_threads): If debug_infrun, always
6225         trace the wait status after wait_one, using
6226         target_waitstatus_to_string and target_pid_to_str.
6227         (handle_inferior_event): Replace various trace of
6228         wait status kind by a single trace.
6229         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6230         wait status kind image by target_waitstatus_to_string.
6231         * target/waitstatus.c (target_waitstatus_to_string): Fix
6232         obsolete comment.
6233
6234 2019-04-01  Tom Tromey  <tromey@adacore.com>
6235
6236         PR symtab/23331:
6237         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6238
6239 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6240             Pedro Alves  <palves@redhat.com>
6241
6242         * top.c (quit_force): Call 'finalize_values'.
6243         * value.c (finalize_values): New function.
6244         * value.h (finalize_values): Declare.
6245
6246 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6247
6248         * NEWS: Announce $_gdb_major and $_gdb_minor.
6249
6250         * top.c (init_gdb_version_vars): New function.
6251         (gdb_init): Call init_gdb_version_vars.
6252
6253 2019-03-29  Tom Tromey  <tromey@adacore.com>
6254
6255         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6256         help text.  Remove dead code.
6257
6258 2019-03-29  Keith Seitz  <keiths@redhat.com>
6259
6260         From Siddhesh Poyarekar:
6261         * f-lang.h (f77_get_upperbound): Return LONGEST.
6262         (f77_get_lowerbound): Likewise.
6263         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6264         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6265         print them.
6266         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6267         plongest to format print it.
6268         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6269         (f77_get_upperbound): Likewise.
6270         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6271         LOWER_BOUND to LONGEST.
6272         (f77_create_arrayprint_offset_tbl): Likewise.
6273
6274 2019-03-29  Keith Seitz  <keiths@redhat.com>
6275
6276         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6277         %s/pulongest for TYPE_LENGTH instead of %d in format
6278         strings.
6279         * ada-typerint.c (ada_print_type): Likewise.
6280         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6281         * compile/compile-c-support.c (generate_register_struct): Likewise.
6282         * gdbtypes.c (recursive_dump_type): Likewise.
6283         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6284         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6285         instead of %d in format strings.
6286         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6287         to std::min to ULONGEST.
6288         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6289         instead of %d in format strings.
6290         * tracepoint.c (info_scope_command): Likewise.
6291         * typeprint.c (print_offset_data::update)
6292         (print_offset_data::finish): Likewise.
6293         * xtensa-tdep.c (xtensa_store_return_value)
6294         (xtensa_push_dummy_call): Likewise.
6295
6296 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6297
6298         * windows-nat.c (display_selector): Fixed format specifications
6299         for 64-bit Cygwin.
6300
6301 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6302
6303         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6304
6305 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6306
6307         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6308         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6309         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6310         (nios2_linux_init_abi): Install it.
6311
6312 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6313
6314         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6315
6316 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6317
6318         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6319
6320 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6321             Tom Tromey  <tromey@adacore.com>
6322
6323         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6324
6325 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6326
6327         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6328         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6329         method to compute the bounds of range types. Also print "[evaluated]"
6330         if the bounds' values come from a dynamic evaluation.
6331
6332 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6335         whitespace when pretty printing is on.
6336
6337 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6338
6339         * ppc-linux-nat.c: Add include.
6340
6341 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6342
6343         * NEWS: Mention AArch64 Pointer Authentication.
6344
6345 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6346
6347         * arm-linux-nat.c: Add include.
6348
6349 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6350
6351         * source-cache.c (source_cache::get_source_lines): Re-read
6352         fullname after calling open_source_file.
6353
6354 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6355
6356         * NEWS: Mention TLS support for FreeBSD.
6357
6358 2019-03-25  Tom Tromey  <tromey@adacore.com>
6359
6360         * minsyms.c (BUNCH_SIZE): Update comment.
6361         (~minimal_symbol_reader): Remove old comment.
6362         (compact_minimal_symbols): Update comment.
6363         (minimal_symbol_reader::install): Remove old comment.  Update
6364         other comments.
6365
6366 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6367
6368         * s390-linux-nat.c: Add include.
6369
6370 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6371
6372         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6373         Call linux_get_hwcap.
6374         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6375         Likewise.
6376         (aarch64_linux_get_hwcap): Remove function.
6377         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6378         declaration.
6379         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6380         linux_get_hwcap.
6381         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6382         * linux-tdep.c (linux_get_hwcap): Add function.
6383         (linux_get_hwcap2): Likewise.
6384         * linux-tdep.h (linux_get_hwcap): Add declaration.
6385         (linux_get_hwcap2): Likewise.
6386         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6387         (ppc_linux_get_hwcap2): Likewise.
6388         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6389         linux_get_hwcap.
6390         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6391         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6392         (ppc_linux_nat_target::read_description): Likewise.
6393         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6394         * s390-linux-nat.c: Likewise.
6395         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6396
6397 2019-03-24  Tom Tromey  <tom@tromey.com>
6398
6399         * ada-lang.c (standard_lookup): Simplify initialization.
6400         (ada_lookup_symbol_nonlocal): Simplify return.
6401         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6402         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6403         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6404         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6405         initialization.
6406         * solib.c (solib_global_lookup): Simplify.
6407         * symtab.c (null_block_symbol): Remove.
6408         (symbol_cache_lookup): Simplify returns.
6409         (lookup_language_this): Simplify returns.
6410         (lookup_symbol_aux): Simplify return.
6411         (lookup_local_symbol): Simplify returns.
6412         (lookup_global_symbol_from_objfile): Simplify return.
6413         (lookup_symbol_in_objfile_symtabs)
6414         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6415         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6416         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6417         * cp-namespace.c (cp_lookup_bare_symbol)
6418         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6419         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6420         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6421         (cp_lookup_symbol_via_imports): Simplify initialization.
6422         (find_symbol_in_baseclass): Likewise.
6423         * symtab.h (null_block_symbol): Remove.
6424         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6425         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6426         (d_lookup_symbol_module): Likewise.
6427         (find_symbol_in_baseclass): Simplify initialization.
6428
6429 2019-03-24  Tom Tromey  <tom@tromey.com>
6430
6431         * expression.h: Don't include symtab.h.
6432         (struct block): Forward declare.
6433
6434 2019-03-24  Tom Tromey  <tom@tromey.com>
6435
6436         * c-exp.y (typebase): Remove casts.
6437         * gdbtypes.c (lookup_unsigned_typename, )
6438         (lookup_signed_typename): Remove cast.
6439         * eval.c (parse_to_comma_and_eval): Remove cast.
6440         * parse.c (write_dollar_variable): Remove cast.
6441         * block.h (struct block) <superblock>: Now const.
6442         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6443         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6444         (map_block): Make "block" const.
6445         * symfile.h (struct quick_symbol_functions)
6446         <map_matching_symbols>: Constify block argument to "callback".
6447         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6448         const.
6449         (find_pc_sect_compunit_symtab): Make "b" const.
6450         (find_symbol_at_address): Likewise.
6451         (search_symbols): Likewise.
6452         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6453         (dw2_debug_names_lookup_symbol): Likewise.
6454         (dw2_map_matching_symbols): Update.
6455         * p-valprint.c (pascal_val_print): Remove "block".
6456         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6457         (aux_add_nonlocal_symbols): Make "block" const.
6458         (resolve_subexp): Remove cast.
6459         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6460         const.
6461         (iterate_over_file_blocks): Likewise.
6462         * f-exp.y (%union) <bval>: Remove.
6463         * coffread.c (patch_opaque_types): Make "b" const.
6464         * spu-tdep.c (spu_catch_start): Make "block" const.
6465         * c-valprint.c (print_unpacked_pointer): Remove "block".
6466         * symmisc.c (dump_symtab_1): Make "b" const.
6467         (block_depth): Make "block" const.
6468         * d-exp.y (%union) <bval>: Remove.
6469         * cp-support.h (cp_lookup_rtti_type): Update.
6470         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6471         * psymtab.c (psym_lookup_symbol): Make "block" const.
6472         (maintenance_check_psymtabs): Make "b" const.
6473         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6474         (enumerate_locals, enumerate_args): Update.
6475         * python/py-symtab.c (stpy_global_block): Make "block" const.
6476         (stpy_static_block): Likewise.
6477         * inline-frame.c (block_starting_point_at): Make "new_block"
6478         const.
6479         * block.c (find_block_in_blockvector): Make return type const.
6480         (blockvector_for_pc_sect): Make "b" const.
6481         (find_block_in_blockvector): Make "b" const.
6482
6483 2019-03-23  Tom Tromey  <tom@tromey.com>
6484
6485         * varobj.c (varobj_create): Update.
6486         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6487         * printcmd.c (display_command, do_one_display): Don't reset
6488         innermost_block.
6489         * parser-defs.h (enum innermost_block_tracker_type): Move to
6490         expression.h.
6491         (innermost_block): Update comment.
6492         * parse.c (parse_exp_1): Add tracker_types parameter.
6493         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6494         tracker_types parameter.  Reset innermost_block.
6495         (parse_exp_in_context): Remove.
6496         (parse_expression_for_completion): Update.
6497         * objfiles.c (~objfile): Don't reset expression_context_block or
6498         innermost_block.
6499         * expression.h (enum innermost_block_tracker_type): Move from
6500         parser-defs.h.
6501         (parse_exp_1): Add tracker_types parameter.
6502         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6503         reset innermost_block.
6504
6505 2019-03-23  Tom Tromey  <tom@tromey.com>
6506
6507         * objfiles.h: Include bcache.h.
6508
6509 2019-03-23  Tom Tromey  <tom@tromey.com>
6510
6511         * linespec.c (get_current_search_block): Use
6512         scoped_restore_current_language.
6513         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6514
6515 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6516             Jiong Wang  <jiong.wang@arm.com>
6517
6518         * aarch64-linux-tdep.c
6519         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6520         section.
6521         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6522
6523 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6524             Jiong Wang  <jiong.wang@arm.com>
6525
6526         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6527         instructions.
6528         (aarch64_analyze_prologue_test): Add PACIASP test.
6529         (aarch64_prologue_prev_register): Unmask PC value.
6530
6531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6532             Jiong Wang  <jiong.wang@arm.com>
6533
6534         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6535         (aarch64_dwarf2_prev_register): Unmask PC value.
6536         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6537         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6538         DW_CFA_AARCH64_negate_ra_state.
6539         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6540
6541 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6542             Jiong Wang  <jiong.wang@arm.com>
6543
6544         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6545         registers.
6546         (aarch64_pseudo_register_name): Likewise.
6547         (aarch64_pseudo_register_type): Likewise.
6548         (aarch64_pseudo_register_reggroup_p): Likewise.
6549         (aarch64_gdbarch_init): Add pauth registers.
6550         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6551         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6552         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6553         (struct gdbarch_tdep): Add regnum for ra_state.
6554
6555 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6556             Jiong Wang  <jiong.wang@arm.com>
6557
6558         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6559
6560 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6561             Jiong Wang  <jiong.wang@arm.com>
6562
6563         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6564         function.
6565         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6566         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6567         (aarch64_gdbarch_init): Add puth registers.
6568         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6569         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6570         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6571
6572 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6573             Jiong Wang  <jiong.wang@arm.com>
6574
6575         * aarch64-linux-nat.c
6576         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6577         * aarch64-linux-tdep.c
6578         (aarch64_linux_core_read_description): Likewise.
6579         (aarch64_linux_get_hwcap): New function.
6580         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6581         (aarch64_linux_get_hwcap): New declaration.
6582
6583 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6584             Jiong Wang  <jiong.wang@arm.com>
6585
6586         * aarch64-linux-nat.c
6587         (aarch64_linux_nat_target::read_description): Add pauth param.
6588         * aarch64-linux-tdep.c
6589         (aarch64_linux_core_read_description): Likewise.
6590         * aarch64-tdep.c (struct target_desc): Add in pauth.
6591         (aarch64_read_description): Add pauth param.
6592         (aarch64_gdbarch_init): Likewise.
6593         * aarch64-tdep.h (aarch64_read_description): Likewise.
6594         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6595         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6596         * features/Makefile: Add new files.
6597         * features/aarch64-pauth.c: New file.
6598         * features/aarch64-pauth.xml: New file.
6599
6600 2019-03-20  Tom Tromey  <tromey@adacore.com>
6601
6602         * infrun.c (handle_inferior_event): Rename from
6603         handle_inferior_event_1.  Create a scoped_value_mark.
6604         (handle_inferior_event): Remove.
6605
6606 2019-03-19  Tom Tromey  <tromey@adacore.com>
6607
6608         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6609         * infrun.h (print_stop_event): Add "displays" parameter.
6610         * infrun.c (print_stop_event): Add "displays" parameter.
6611
6612 2019-03-19  Pedro Alves  <palves@redhat.com>
6613
6614         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6615         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6616         to -1.  Fix TABs vs spaces.
6617         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6618         * tui/tui-out.h (tui_ui_out) Add intro comments.
6619         <m_line, m_start_of_line>: In-class initialize, and add describing
6620         comment.
6621
6622 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6623
6624         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6625         variable names.
6626         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6627
6628 2019-03-18  Pedro Alves  <palves@redhat.com>
6629             Eli Zaretskii <eliz@gnu.org>
6630
6631         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6632         m_line and m_start_of_line.
6633
6634 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6635
6636         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6637         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6638         it returns a newline.  This fixes a regression in TU mode, whereby
6639         the next line is output on the same screen line as the user input.
6640
6641 2019-03-18  Tom Tromey  <tromey@adacore.com>
6642
6643         * minsyms.c (minimal_symbol_reader::install): Remove call to
6644         obstack_blank.
6645
6646 2019-03-18  Pedro Alves  <palves@redhat.com>
6647
6648         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6649         New globals.
6650         (apply_style): New, factored out from ...
6651         (apply_ansi_escape): ... this.  Handle reverse video mode.
6652         (tui_set_reverse_mode): New function.
6653         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6654         * tui/tui-winsource.c (tui_show_source_line): Use
6655         tui_set_reverse_mode instead of setting A_STANDOUT.
6656         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6657         New setter methods.
6658
6659 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6660
6661         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6662         Handle tabs.
6663
6664 2019-03-18  Tom Tromey  <tromey@adacore.com>
6665
6666         * ada-lang.c (empty_array): Add "high" parameter.
6667         (ada_evaluate_subexp): Update.
6668
6669 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6670
6671         * unittests/string_view-selftests.c: Define
6672         _initialize_string_view_selftests unconditionally.
6673
6674 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6675
6676         PR gdb/24350
6677         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6678
6679 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6680
6681         PR gdb/24351
6682         * windows-nat.c (display_selector): Fix format specifiers.
6683
6684 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6685
6686         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6687         tui_refill_source_window instead of tui_refresh_win, to update the
6688         current execution line.  This fixes redisplay of the current line
6689         when stepping through the code with "next" or "step".
6690
6691 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6692
6693         * source-cache.c (source_cache::get_source_lines): Call
6694         find_source_lines to initialize s->nlines.  This fixes vertical
6695         scrolling of TUI source window when the DOWN arrow is pressed.
6696
6697 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6698
6699         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6700         linux-thread-db.c (_initialize_thread_db): Likewise.
6701
6702 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6703
6704         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6705         wclrtoeol in tui_show_source_line".  This reverts changes made in
6706         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6707
6708 2019-03-15  Tom Tromey  <tom@tromey.com>
6709
6710         * symtab.h (struct minimal_symbol): Derive from
6711         general_symbol_info.
6712         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6713         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6714         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6715         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6716         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6717         (MSYMBOL_SEARCH_NAME): Update.
6718         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6719         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6720         * minsyms.c (minimal_symbol_reader::record_full): Update.
6721
6722 2019-03-15  Tom Tromey  <tom@tromey.com>
6723
6724         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6725
6726 2019-03-15  Tom Tromey  <tom@tromey.com>
6727
6728         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6729         unique_xmalloc_ptr.
6730         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6731         Update.
6732         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6733         (build_minimal_symbol_hash_tables)
6734         (minimal_symbol_reader::install): Update.
6735
6736 2019-03-15  Tom Tromey  <tom@tromey.com>
6737
6738         * symtab.c (create_demangled_names_hash): Update.
6739         (symbol_set_names): Update.
6740         * objfiles.h (struct objfile_per_bfd_storage)
6741         <demangled_names_hash>: Now an htab_up.
6742         * objfiles.c (objfile_per_bfd_storage): Simplify.
6743
6744 2019-03-15  Tom Tromey  <tom@tromey.com>
6745
6746         * objfiles.h (struct objfile_per_bfd_storage): Declare
6747         destructor.
6748         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6749         New.
6750         (get_objfile_bfd_data): Use new.  Don't initialize
6751         language_of_main.
6752         (free_objfile_per_bfd_storage): Remove.
6753         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6754
6755 2019-03-15  Tom Tromey  <tom@tromey.com>
6756
6757         * symfile.c (reread_symbols): Update.
6758         * objfiles.c (objfile::objfile): Update.
6759         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6760         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6761         comment.
6762         (minimal_symbol_reader::install): Update.
6763         (terminate_minimal_symbol_table): Remove.
6764         * jit.c (jit_object_close_impl): Update.
6765
6766 2019-03-15  Tom Tromey  <tom@tromey.com>
6767
6768         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6769         initializations.
6770
6771 2019-03-15  Tom Tromey  <tom@tromey.com>
6772
6773         * objfiles.h (struct objfile_per_bfd_storage)
6774         <demangled_hash_languages>: Now a bitset.
6775         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6776         (lookup_minimal_symbol): Update.
6777
6778 2019-03-15  Tom Tromey  <tom@tromey.com>
6779
6780         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6781         Don't return the symbol.
6782         * coffread.c (record_minimal_symbol): Use record_full.
6783
6784 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6785
6786         The MS-Windows port of ncurses fails to switch to a color pair if
6787         one or both of the colors are the implicit default colors.  This
6788         change records the default colors when TUI is initialized, and
6789         then specifies them explicitly when a color pair uses the default
6790         colors.  This allows color styling in TUI mode on MS-Windows.
6791
6792         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6793         ncurses_norm_attr.
6794         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6795         colors in ncurses_norm_attr.
6796         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6797         "none", replace it with the default color recorded in
6798         ncurses_norm_attr.
6799
6800 2019-03-14  Tom Tromey  <tromey@adacore.com>
6801
6802         * source-cache.h (class source_cache) <get_source_lines>: Return
6803         std::string.
6804         * source-cache.c (source_cache::extract_lines): Handle case where
6805         first_pos==npos.  Return std::string.
6806         (source_cache::get_source_lines): Update.
6807
6808 2019-03-14  Tom Tromey  <tromey@adacore.com>
6809
6810         * NEWS: Add item for "style sources" commands.
6811         * source-cache.c (source_cache::get_source_lines): Check
6812         source_styling.
6813         * cli/cli-style.c (source_styling): New global.
6814         (_initialize_cli_style): Add "style sources" commands.
6815         (show_style_sources): New function.
6816         * cli/cli-style.h (source_styling): Declare.
6817
6818 2019-03-14  Pedro Alves  <palves@redhat.com>
6819             Tom Tromey  <tromey@adacore.com>
6820
6821         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6822         * tui/tui-winsource.c (tui_refill_source_window): New function,
6823         from...
6824         (tui_horizontal_source_scroll): ... here.  Move some logic.
6825         * cli/cli-style.c (set_style_enabled): Notify new observable.
6826         * tui/tui-hooks.c (tui_redisplay_source): New function.
6827         (tui_attach_detach_observers): Attach or detach
6828         tui_redisplay_source.
6829         * observable.h (source_styling_changed): New observable.
6830         * observable.c: Define source_styling_changed observable.
6831
6832 2019-03-13  Tom Tromey  <tromey@adacore.com>
6833
6834         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6835         (i386_gnu_nat_target::store_registers): Update.
6836         * target-debug.h (target_debug_print_std_string): New macro.
6837         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6838         * windows-tdep.c (display_one_tib): Update.
6839         * tui/tui-stack.c (tui_make_status_line): Update.
6840         * top.c (print_inferior_quit_action): Update.
6841         * thread.c (thr_try_catch_cmd): Update.
6842         (add_thread_with_info): Update.
6843         (thread_target_id_str): Update.
6844         (thr_try_catch_cmd): Update.
6845         (thread_command): Update.
6846         (thread_find_command): Update.
6847         * record-btrace.c (record_btrace_target::info_record)
6848         (record_btrace_resume_thread, record_btrace_target::resume)
6849         (record_btrace_cancel_resume, record_btrace_step_thread)
6850         (record_btrace_target::wait, record_btrace_target::wait)
6851         (record_btrace_target::wait, record_btrace_target::stop): Update.
6852         * progspace.c (print_program_space): Update.
6853         * process-stratum-target.c
6854         (process_stratum_target::thread_address_space): Update.
6855         * linux-fork.c (linux_fork_mourn_inferior)
6856         (detach_checkpoint_command, info_checkpoints_command)
6857         (linux_fork_context): Update.
6858         (linux_fork_detach): Update.
6859         (class scoped_switch_fork_info): Update.
6860         (delete_checkpoint_command): Update.
6861         * infrun.c (follow_fork_inferior): Update.
6862         (follow_fork_inferior): Update.
6863         (proceed_after_vfork_done): Update.
6864         (handle_vfork_child_exec_or_exit): Update.
6865         (follow_exec): Update.
6866         (displaced_step_prepare_throw): Update.
6867         (displaced_step_restore): Update.
6868         (start_step_over): Update.
6869         (resume_1): Update.
6870         (clear_proceed_status_thread): Update.
6871         (proceed): Update.
6872         (print_target_wait_results): Update.
6873         (do_target_wait): Update.
6874         (context_switch): Update.
6875         (stop_all_threads): Update.
6876         (restart_threads): Update.
6877         (finish_step_over): Update.
6878         (handle_signal_stop): Update.
6879         (switch_back_to_stepped_thread): Update.
6880         (keep_going_pass_signal): Update.
6881         (print_exited_reason): Update.
6882         (normal_stop): Update.
6883         * inferior.c (inferior_pid_to_str): Change return type.
6884         (print_selected_inferior): Update.
6885         (add_inferior): Update.
6886         (detach_inferior): Update.
6887         * dummy-frame.c (fprint_dummy_frames): Update.
6888         * dcache.c (dcache_info_1): Update.
6889         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6890         (btrace_fetch, btrace_clear): Update.
6891         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6892         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6893         type.
6894         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6895         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6896         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6897         * gdbarch.c, gdbarch.h: Rebuild.
6898         * gdbarch.sh (core_pid_to_str): Change return type.
6899         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6900         return type.
6901         (windows_nat_target::pid_to_str): Change return type.
6902         (windows_delete_thread): Update.
6903         (windows_nat_target::attach): Update.
6904         (windows_nat_target::files_info): Update.
6905         * target-delegates.c: Rebuild.
6906         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6907         return type.
6908         (sol_thread_target::pid_to_str): Change return type.
6909         * remote.c (class remote_target) <pid_to_str>: Change return
6910         type.
6911         (remote_target::pid_to_str): Change return type.
6912         (extended_remote_target::attach, remote_target::remote_stop_ns)
6913         (remote_target::remote_notif_remove_queued_reply)
6914         (remote_target::push_stop_reply, remote_target::disable_btrace):
6915         Update.
6916         (extended_remote_target::attach): Update.
6917         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6918         type.
6919         (gdbsim_target::pid_to_str): Change return type.
6920         * ravenscar-thread.c (struct ravenscar_thread_target)
6921         <pid_to_str>: Change return type.
6922         (ravenscar_thread_target::pid_to_str): Change return type.
6923         * procfs.c (class procfs_target) <pid_to_str>: Change return
6924         type.
6925         (procfs_target::pid_to_str): Change return type.
6926         (procfs_target::attach): Update.
6927         (procfs_target::detach): Update.
6928         (procfs_target::fetch_registers): Update.
6929         (procfs_target::store_registers): Update.
6930         (procfs_target::wait): Update.
6931         (procfs_target::files_info): Update.
6932         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6933         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6934         return type.
6935         (nto_procfs_target::pid_to_str): Change return type.
6936         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6937         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6938         return type.
6939         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6940         (exit_lwp): Update.
6941         (attach_proc_task_lwp_callback, get_detach_signal)
6942         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6943         (linux_nat_target::resume, wait_lwp, stop_callback)
6944         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6945         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6946         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6947         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6948         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6949         type.
6950         (inf_ptrace_target::attach): Update.
6951         (inf_ptrace_target::files_info): Update.
6952         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6953         type.
6954         (go32_nat_target::pid_to_str): Change return type.
6955         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6956         (gnu_nat_target::wait): Update.
6957         (gnu_nat_target::wait): Update.
6958         (gnu_nat_target::resume): Update.
6959         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6960         (fbsd_nat_target::wait): Update.
6961         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6962         type.
6963         (darwin_nat_target::attach): Update.
6964         * corelow.c (class core_target) <pid_to_str>: Change return type.
6965         (core_target::pid_to_str): Change return type.
6966         * target.c (normal_pid_to_str): Change return type.
6967         (default_pid_to_str): Likewise.
6968         (target_pid_to_str): Change return type.
6969         (target_translate_tls_address): Update.
6970         (target_announce_detach): Update.
6971         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6972         return type.
6973         (bsd_uthread_target::pid_to_str): Change return type.
6974         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6975         type.
6976         (bsd_kvm_target::pid_to_str): Change return type.
6977         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6978         return type.
6979         (aix_thread_target::pid_to_str): Change return type.
6980         * target.h (struct target_ops) <pid_to_str>: Change return type.
6981         (target_pid_to_str, normal_pid_to_str): Likewise.
6982         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6983         type.
6984         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6985         type.
6986         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6987         return type.
6988         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6989         type.
6990         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6991         type.
6992         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6993         return type.
6994
6995 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6996
6997         * NEWS: Mention that the new default MI version is 3.  Mention
6998         changes to the output of commands and events that deal with
6999         multi-location breakpoints.
7000         * breakpoint.c: Include "mi/mi-out.h".
7001         (print_one_breakpoint): Change output syntax if using MI version
7002         >= 3.
7003         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7004         New.
7005         (mi_multi_location_breakpoint_output_fixed): New.
7006         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7007         (mi_cmd_fix_multi_location_breakpoint_output): New.
7008         (mi_multi_location_breakpoint_output_fixed): New.
7009         * mi/mi-cmds.c (mi_cmds): Register command
7010         -fix-multi-location-breakpoint-output.
7011         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7012         interpreter "mi".
7013
7014 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7015
7016         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7017         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7018         instantiate mi_ui_out based on interpreter name.
7019         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7020         * mi/mi-main.c (mi_load_progress): Likewise.
7021
7022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7023
7024         * NEWS: Combine separate "New targets" sections for 8.3.
7025
7026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7027
7028         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7029         (ppcfbsd_init_abi): Install gdbarch
7030         "fetch_tls_load_module_address" and "get_thread_local_address"
7031         methods.
7032
7033 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7034
7035         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7036         (riscv_fbsd_init_abi): Install gdbarch
7037         "fetch_tls_load_module_address" and "get_thread_local_address"
7038         methods.
7039
7040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7041
7042         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7043         (i386fbsd_init_abi): Install gdbarch
7044         "fetch_tls_load_module_address" and "get_thread_local_address"
7045         methods.
7046
7047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7048
7049         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7050         (amd64fbsd_init_abi): Install gdbarch
7051         "fetch_tls_load_module_address" and "get_thread_local_address"
7052         methods.
7053
7054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7055
7056         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7057         (struct fbsd_pspace_data): New type.
7058         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7059         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7060         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7061         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7062         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7063
7064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7065
7066         * gdbtypes.c (lookup_struct_elt): New function.
7067         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7068         * gdbtypes.h (struct struct_elt): New type.
7069         (lookup_struct_elt): New prototype.
7070
7071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7072
7073         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7074         remove disabled code block.
7075
7076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7077
7078         * gdbarch.sh (get_thread_local_address): New method.
7079         * gdbarch.h, gdbarch.c: Regenerate.
7080         * target.c (target_translate_tls_address): Use
7081         gdbarch_get_thread_local_address if present instead of
7082         target::get_thread_local_address.
7083
7084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7085
7086         * target.h (target::get_thread_local_address): Update comment.
7087
7088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7089
7090         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7091         objfile->separate_debug_objfile_backlink if not NULL.
7092
7093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7094
7095         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7096         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7097         (amd64bsd_store_inferior_registers): Likewise.
7098         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7099         Enable segment base registers.
7100         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7101         PT_GETFSBASE and PT_GETGSBASE.
7102         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7103         PT_SETGSBASE.
7104         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7105         segment base registers.
7106         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7107
7108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7109
7110         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7111         Update calls to i386_target_description to add 'segments'
7112         parameter.
7113         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7114         add segment base registers.
7115         * arch/i386.c (i386_create_target_description): Add 'segments'
7116         parameter to enable segment base registers.
7117         * arch/i386.h (i386_create_target_description): Likewise.
7118         * features/i386/32bit-segments.xml: New file.
7119         * features/i386/32bit-segments.c: Generate.
7120         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7121         call to i386_target_description to add 'segments' parameter.
7122         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7123         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7124         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7125         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7126         if feature is present.
7127         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7128         Add 'segments' parameter to call to i386_target_description.
7129         (i386_target_description): Add 'segments' parameter to enable
7130         segment base registers.
7131         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7132         to call to i386_target_description.
7133         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7134         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7135         Define I386_NUM_REGS.
7136         (i386_target_description): Add 'segments' parameter to enable
7137         segment base registers.
7138
7139 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7140
7141         PR/24325
7142         * source-cache.c: #undef open and close, to avoid unresolved
7143         externals during linking.
7144
7145 2019-03-12  Tom Tromey  <tromey@adacore.com>
7146
7147         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7148         const.  Add initializers.
7149         (_initialize_remote): Don't initialize ptid globals.
7150
7151 2019-03-12  Pedro Alves  <palves@redhat.com>
7152
7153         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7154
7155 2019-03-12  Pedro Alves  <palves@redhat.com>
7156
7157         * cp-name-parser.y (main): Remove unused 'len' variable.
7158
7159 2019-03-12  Tom Tromey  <tromey@adacore.com>
7160
7161         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7162         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7163
7164 2019-03-12  Tom Tromey  <tromey@adacore.com>
7165
7166         * linux-nat.c (iterate_over_lwps): Update.
7167         (stop_callback): Remove parameter.
7168         (stop_wait_callback, detach_callback, resume_set_callback)
7169         (select_singlestep_lwp_callback, set_ignore_sigint)
7170         (status_callback, resumed_callback, resume_clear_callback)
7171         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7172         data parameter.
7173         (linux_nat_target::detach, linux_nat_target::resume)
7174         (linux_stop_and_wait_all_lwps, select_event_lwp)
7175         (linux_nat_filter_event, linux_nat_wait_1)
7176         (linux_nat_target::kill, linux_nat_target::stop)
7177         (linux_nat_target::stop): Update.
7178         (linux_nat_resume_callback): Change type.
7179         (resume_stopped_resumed_lwps, count_events_callback)
7180         (select_event_lwp_callback): Likewise.
7181         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7182         * arm-linux-nat.c (struct update_registers_data): Remove.
7183         (update_registers_callback): Change type.
7184         (arm_linux_insert_hw_breakpoint1): Update.
7185         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7186         parameter.
7187         (x86_linux_dr_set_addr): Update.
7188         (x86_linux_dr_set_control): Update.
7189         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7190         (iterate_over_lwps): Use gdb::function_view.
7191         * nat/aarch64-linux-hw-point.c (struct
7192         aarch64_dr_update_callback_param): Remove.
7193         (debug_reg_change_callback): Change type.
7194         (aarch64_notify_debug_reg_change): Update.
7195         * s390-linux-nat.c (s390_refresh_per_info): Update.
7196
7197 2019-03-11  Tom Tromey  <tromey@adacore.com>
7198
7199         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7200         redundant assignment to "this_cu".
7201
7202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7203
7204         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7205
7206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7207
7208         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7209         from...
7210         (rank_one_type): ... this.
7211
7212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7213
7214         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7215         from...
7216         (rank_one_type): ... this.
7217
7218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7219
7220         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7221         from...
7222         (rank_one_type): ... this.
7223
7224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7225
7226         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7227         from...
7228         (rank_one_type): ... this.
7229
7230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7231
7232         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7233         from...
7234         (rank_one_type): ... this.
7235
7236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7237
7238         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7239         from...
7240         (rank_one_type): ... this.
7241
7242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7243
7244         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7245         from...
7246         (rank_one_type): ... this.
7247
7248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7249
7250         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7251         from...
7252         (rank_one_type): ... this.
7253
7254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7255
7256         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7257         from...
7258         (rank_one_type): ... this.
7259
7260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7261
7262         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7263         from...
7264         (rank_one_type): ... this.
7265
7266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7267
7268         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7269         from...
7270         (rank_one_type): ... this.
7271
7272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7273
7274         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7275         from...
7276         (rank_one_type): ... this.
7277
7278 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7279
7280         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7281         inferior-events' shows the example events.
7282
7283 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7284
7285         Support styling on native MS-Windows console
7286
7287         PR/24315
7288         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7289         on MS-Windows if $TERM is not defined.
7290
7291         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7292
7293         * posix-hdep.c (gdb_console_fputs):
7294         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7295         functions.
7296         * ui-file.h (gdb_console_fputs): Add prototype.
7297
7298         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7299         back to fputs only if the former returns zero.
7300
7301 2019-03-07  Tom Tromey  <tom@tromey.com>
7302
7303         * symmisc.c (print_symbol_bcache_statistics): Update.
7304         (print_objfile_statistics): Update.
7305         * symfile.c (allocate_symtab): Update.
7306         * stabsread.c: Don't include bcache.h.
7307         * psymtab.h (struct psymbol_bcache): Don't declare.
7308         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7309         (psymbol_bcache_init, psymbol_bcache_free)
7310         (psymbol_bcache_get_bcache): Don't declare.
7311         * psymtab.c (struct psymbol_bcache): Remove.
7312         (psymtab_storage::psymtab_storage): Update.
7313         (psymtab_storage::~psymtab_storage): Update.
7314         (psymbol_bcache_init, psymbol_bcache_free)
7315         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7316         (add_psymbol_to_bcache): Update.
7317         (allocate_psymtab): Update.
7318         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7319         macro_cache>: No longer pointers.
7320         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7321         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7322         * macrotab.c (macro_bcache): Update.
7323         * macroexp.c: Don't include bcache.h.
7324         * gdbtypes.c (check_types_worklist): Update.
7325         (types_deeply_equal): Remove TRY/CATCH.  Update.
7326         * elfread.c (elf_symtab_read): Update.
7327         * dwarf2read.c: Don't include bcache.h.
7328         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7329         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7330         (print_bcache_statistics, bcache_memory_used): Don't declare.
7331         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7332         methods.  Rename all data members.
7333         * bcache.c (struct bcache): Move to bcache.h.
7334         (bcache::expand_hash_table): Rename from expand_hash_table.
7335         (bcache): Remove.
7336         (bcache::insert): Rename from bcache_full.
7337         (bcache::compare): Rename from bcache_compare.
7338         (bcache_xmalloc): Remove.
7339         (bcache::~bcache): Rename from bcache_xfree.
7340         (bcache::print_statistics): Rename from print_bcache_statistics.
7341         (bcache::memory_used): Rename from bcache_memory_used.
7342
7343 2019-03-07  Pedro Alves  <palves@redhat.com>
7344
7345         * infrun.c (normal_stop): Also check for
7346         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7347
7348 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7349
7350         * f-lang.c (value_from_host_double): Moved to...
7351         * value.c (value_from_host_double): ...here.
7352         * value.h (value_from_host_double): Declare.
7353         * guile/scm-math.c (vlscm_convert_typed_number): Use
7354         value_from_host_double.
7355         (vlscm_convert_number): Likewise.
7356         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7357         * python/py-value.c (convert_value_from_python): Likewise.
7358
7359 2019-03-06  Tom Tromey  <tom@tromey.com>
7360
7361         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7362
7363 2019-03-06  Tom Tromey  <tom@tromey.com>
7364
7365         * utils.h (free_current_contents): Don't declare.
7366         * utils.c (free_current_contents): Remove.
7367
7368 2019-03-06  Tom Tromey  <tom@tromey.com>
7369
7370         * top.c (quit_force): Update.
7371         * main.c (captured_command_loop): Update.
7372         * common/new-op.c (operator new): Update.
7373         * common/common-exceptions.c (struct catcher)
7374         <save_cleanup_chain>: Remove member.
7375         (exceptions_state_mc_init): Update.
7376         (exception_try_scope_entry): Return nullptr.
7377         (exception_try_scope_exit, exception_rethrow)
7378         (throw_exception_sjlj, throw_exception_cxx): Update.
7379         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7380         (all_cleanups, do_cleanups, discard_cleanups)
7381         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7382         (restore_cleanups, restore_final_cleanups): Don't declare.
7383         (do_final_cleanups): Remove parameter.
7384         * common/cleanups.c (cleanup_chain, make_cleanup)
7385         (make_cleanup_dtor, all_cleanups, do_cleanups)
7386         (discard_my_cleanups, discard_cleanups)
7387         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7388         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7389         (null_cleanup): Remove.
7390         (do_final_cleanups): Remove parameter.
7391
7392 2019-03-06  Tom Tromey  <tom@tromey.com>
7393
7394         * remote.c (remote_target::remote_parse_stop_reply): Use
7395         unique_xmalloc_ptr.
7396
7397 2019-03-06  Tom Tromey  <tom@tromey.com>
7398
7399         * stabsread.c (struct stabs_field_info): Rename from field_info.
7400         <list, fnlist>: Add initializers.
7401         <obstack>: New member.
7402         (read_member_functions, read_struct_fields, read_baseclasses):
7403         Allocate on obstack.  Don't use cleanups.
7404         (read_one_struct_field, read_member_functions, read_struct_fields)
7405         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7406         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7407         (read_struct_type): Update.
7408
7409 2019-03-06  Tom Tromey  <tom@tromey.com>
7410
7411         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7412         * common/filestuff.h (make_cleanup_close): Don't declare.
7413         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7414         Remove.
7415
7416 2019-03-06  Tom Tromey  <tom@tromey.com>
7417
7418         * solib-aix.c: Use make_scope_exit.
7419
7420 2019-03-06  Tom Tromey  <tom@tromey.com>
7421
7422         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7423         Use make_scope_exit.
7424
7425 2019-03-06  Tom Tromey  <tom@tromey.com>
7426
7427         * solib-svr4.c (disable_probes_interface): Remove parameter.
7428         (svr4_handle_solib_event): Use make_scope_exit.
7429
7430 2019-03-06  Tom Tromey  <tom@tromey.com>
7431
7432         * remote.c (struct stop_reply_deleter): Remove.
7433         (stop_reply_up): Update.
7434         (struct stop_reply): Derive from notif_event.  Don't typedef.
7435         <regcache>: Now a std::vector.
7436         (stop_reply_xfree): Remove.
7437         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7438         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7439         (remote_target::discard_pending_stop_replies): Use delete.
7440         (remote_target::remote_parse_stop_reply): Update.
7441         (remote_target::process_stop_reply): Update.
7442         * remote-notif.h (struct notif_event): Add virtual destructor.
7443         Remove "dtr" member.
7444         (struct notif_client) <alloc_event>: Return a unique_ptr.
7445         (notif_event_xfree): Don't declare.
7446         (notif_event_up): New typedef.
7447         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7448         (notif_event_xfree, do_notif_event_xfree): Remove.
7449         (remote_notif_state_xfree): Update.
7450
7451 2019-03-06  Tom Tromey  <tom@tromey.com>
7452
7453         * infrun.c (displaced_step_clear_cleanup): Now a
7454         forward_scope_exit type.
7455         (displaced_step_prepare_throw): Update.
7456         (displaced_step_fixup): Update.
7457
7458 2019-03-06  Tom Tromey  <tom@tromey.com>
7459
7460         * inferior.h (class inferior): Update comment.
7461         * gdbthread.h (class thread_info): Update comment.
7462
7463 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7464             Tom Tromey  <tom@tromey.com>
7465
7466         * stabsread.h (struct stab_section_list): Remove.
7467         (coffstab_build_psymtabs): Update.
7468         * dbxread.c (symbuf_sections): Now a std::vector.
7469         (sect_idx): New global.
7470         (fill_symbuf): Update.
7471         (coffstab_build_psymtabs): Change type of stabsects parameter.
7472         Update.
7473         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7474         std::vector.
7475         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7476         (coff_locate_sections): Update.
7477         (coff_symfile_read): Remove cleanups.  Update.
7478         (init_stringtab): Add storage parameter.
7479         (free_stringtab, free_stringtab_cleanup): Remove.
7480         (init_lineno): Add storage parameter.
7481         (free_linetab, free_linetab_cleanup): Remove.
7482
7483 2019-03-06  Pedro Alves  <palves@redhat.com>
7484
7485         * linux-fork.c (fork_info::clobber_regs): Delete.
7486         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7487         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7488         comment.  Adjust.
7489         (scoped_switch_fork_info::scoped_switch_fork_info)
7490         (checkpoint_command, linux_fork_context): Adjust
7491         fork_save_infrun_state calls.
7492
7493 2019-03-06  Pedro Alves  <palves@redhat.com>
7494
7495         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7496         (inf_has_multiple_threads): Return 'bool' and rewrite using
7497         inferior_info::threads().
7498
7499 2019-03-06  Pedro Alves  <palves@redhat.com>
7500
7501         * linux-fork.c: Include <list>.
7502         (fork_list): Now a std::list instance.
7503         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7504         (forks_exist_p, find_last_fork): Adjust.
7505         (new_fork): Delete.
7506         (one_fork_p): New.
7507         (add_fork): Adjust.
7508         (free_fork): Delete, folded into fork_info::~fork_info().
7509         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7510         Adjust.
7511         (init_fork_list): Delete.
7512         (linux_fork_killall, linux_fork_mourn_inferior)
7513         (linux_fork_detach, info_checkpoints_command): Adjust.
7514         (_initialize_linux_fork): No longer call init_fork_list.
7515
7516 2019-03-06  Pedro Alves  <palves@redhat.com>
7517
7518         * linux-fork.c (new_fork): New, split out of ...
7519         (add_fork): ... this.  Return void.  Move "first fork" special
7520         case from here, to ...
7521         (checkpoint_command): ... here.
7522         * linux-linux.h (add_fork): Return void.
7523
7524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7525
7526         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7527
7528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7529             Chris January  <chris.january@arm.com>
7530             David Lecomber  <david.lecomber@arm.com>
7531
7532         * f-exp.y: New token, UNOP_INTRINSIC.
7533         (exp): New pattern using UNOP_INTRINSIC token.
7534         (f77_keywords): Add 'abs' keyword.
7535         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7536         (value_from_host_double): New function.
7537         (evaluate_subexp_f): Support UNOP_ABS.
7538
7539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7542         types.
7543
7544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7547         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7548         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7549
7550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7553
7554 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7555             Chris January  <chris.january@arm.com>
7556
7557         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7558         * f-exp.y: Define 'KIND' token.
7559         (exp): New pattern for KIND expressions.
7560         (ptype): Handle types with a kind extension.
7561         (direct_abs_decl): Extend to spot kind extensions.
7562         (f77_keywords): Add 'kind' to the list.
7563         (push_kind_type): New function.
7564         (convert_to_kind_type): New function.
7565         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7566         * parse.c (operator_length_standard): Likewise.
7567         * parser-defs.h (enum type_pieces): Add tp_kind.
7568         * std-operator.def: Add UNOP_KIND.
7569
7570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * f-exp.y (f_parse): Set yydebug.
7573
7574 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7575
7576         * f-lang.c (evaluate_subexp_f): New function.
7577         (exp_descriptor_f): New global.
7578         (f_language_defn): Use exp_descriptor_f instead of
7579         exp_descriptor_standard.
7580
7581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7582
7583         * f-exp.y (struct token): Add comments.
7584         (dot_ops): Remove uppercase versions and the end marker.
7585         (f77_keywords): Likewise.
7586         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7587         entries in the dot_ops array are case insensitive, and use
7588         strncasecmp to compare strings.  Also some whitespace cleanup in
7589         this area.  Similar for the f77_keywords array, except entries in
7590         this list might be case sensitive.
7591
7592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7593
7594         * f-exp.y (struct f77_boolean_val): Add comments.
7595         (boolean_values): Remove uppercase versions, and end marker.
7596         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7597         and use strncasecmp to achieve case insensitivity.  Additionally,
7598         perform whitespace cleanup around this code.
7599
7600 2019-03-06  Tom Tromey  <tromey@adacore.com>
7601
7602         * remote-sim.c (gdbsim_target_open): Use result of
7603         gdb_argv::release.
7604
7605 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7606         Dirk Schubert  <dirk.schubert@arm.com>
7607         Chris January  <chris.january@arm.com>
7608
7609         * eval.c (evaluate_subexp_standard): Call Fortran argument
7610         wrapping logic.
7611         * f-lang.c (struct value): A value which can be passed into a
7612         Fortran function call.
7613         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7614         where appropriate.
7615         (struct type): Value ready for a Fortran function call.
7616         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7617         is needed.
7618         * f-lang.h (fortran_argument_convert): Declaration.
7619         (fortran_preserve_arg_pointer): Declaration.
7620         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7621
7622 2019-03-05  Tom Tromey  <tromey@adacore.com>
7623
7624         * python/py-prettyprint.c (print_string_repr): Remove #if.
7625         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7626
7627 2019-03-05  Tom Tromey  <tromey@adacore.com>
7628
7629         * target.c (the_dummy_target): Move later.  Change type to
7630         "dummy_target".
7631         (initialize_targets): Don't initialize the_dummy_target.
7632
7633 2019-03-05  Tom Tromey  <tromey@adacore.com>
7634
7635         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7636         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7637
7638 2019-03-05  Tom Tromey  <tromey@adacore.com>
7639
7640         * windows-nat.c (windows_nat_target::attach)
7641         (windows_nat_target::detach): Don't call gdb_flush.
7642         * valprint.c (generic_val_print, val_print, val_print_string):
7643         Don't call gdb_flush.
7644         * utils.c (defaulted_query): Don't call gdb_flush.
7645         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7646         * target.c (target_announce_detach): Don't call gdb_flush.
7647         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7648         * remote.c (extended_remote_target::attach): Don't call
7649         gdb_flush.
7650         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7651         * printcmd.c (do_examine): Don't call gdb_flush.
7652         (info_display_command): Don't call gdb_flush.
7653         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7654         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7655         * memattr.c (info_mem_command): Don't call gdb_flush.
7656         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7657         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7658         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7659         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7660         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7661         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7662         (gnu_nat_target::detach): Don't call gdb_flush.
7663         * f-valprint.c (f_val_print): Don't call gdb_flush.
7664         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7665         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7666         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7667         gdb_flush.
7668         * c-valprint.c (c_val_print): Don't call gdb_flush.
7669         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7670
7671 2019-03-05  Tom Tromey  <tromey@adacore.com>
7672
7673         * varobj.c (update_dynamic_varobj_children): Update.
7674         (install_default_visualizer): Use reset, not release.
7675         * value.c (set_internalvar): Update.
7676         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7677         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7678         ATTRIBUTE_UNUSED_RESULT.
7679
7680 2019-03-05  Tom Tromey  <tromey@adacore.com>
7681
7682         * remote.c (class scoped_remote_fd) <release>: Add
7683         ATTRIBUTE_UNUSED_RESULT.
7684
7685 2019-03-05  Tom Tromey  <tromey@adacore.com>
7686
7687         * macroexp.c (struct macro_buffer) <release>: Add
7688         ATTRIBUTE_UNUSED_RESULT.
7689
7690 2019-03-05  Tom Tromey  <tromey@adacore.com>
7691
7692         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7693         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7694         ATTRIBUTE_UNUSED_RESULT.
7695
7696 2019-03-05  Tom Tromey  <tromey@adacore.com>
7697
7698         * common/scoped_fd.h (class scoped_fd) <release>: Add
7699         ATTRIBUTE_UNUSED_RESULT.
7700
7701 2019-03-05  Tom Tromey  <tromey@adacore.com>
7702
7703         * parser-defs.h (struct parser_state) <release>: Add
7704         ATTRIBUTE_UNUSED_RESULT.
7705
7706 2019-03-05  Tom Tromey  <tromey@adacore.com>
7707
7708         * utils.h (class gdb_argv) <release>: Add
7709         ATTRIBUTE_UNUSED_RESULT.
7710         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7711
7712 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7713
7714         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7715         for-loop range, to avoid compiler warnings.
7716
7717         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7718         avoid compiler warnings about unused variables.
7719
7720         * NEWS: Mention end of support for native debugging on MS-Windows
7721         before XP.
7722
7723         PR gdb/24292
7724         * common/netstuff.c:
7725         * gdbserver/gdbreplay.c
7726         * gdbserver/remote-utils.c:
7727         * ser-tcp.c:
7728         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7729         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7730         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7731         'getaddrinfo' and 'freeaddrinfo' were not available before
7732         Windows XP, and mingw.org's MinGW headers by default define
7733         _WIN32_WINNT to 0x500.
7734
7735 2019-03-01  Gary Benson <gbenson@redhat.com>
7736
7737         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7738
7739 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7740             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7741
7742         PR gdb/8527
7743         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7744         set_sigint_trap, clear_sigint_trap.
7745
7746 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7747
7748         * target.c (target_detach): Clear the regcache and the
7749         frame cache.
7750
7751 2019-02-27  Pedro Alves  <palves@redhat.com>
7752
7753         * utils.c (set_screen_size): When we cap the height/width sizes,
7754         tweak the corresponding command variable to show "unlimited":
7755
7756 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7757             Pedro Alves  <palves@redhat.com>
7758
7759         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7760         before calling rl_set_screen_size.
7761
7762 2019-02-27  Tom Tromey  <tromey@adacore.com>
7763
7764         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7765         define.
7766         * python/py-value.c: Remove Python 2.4 workaround.
7767         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7768         workaround.
7769         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7770         Python 2.4 workaround.
7771         * python/python-internal.h: Remove Python 2.4 comment.
7772         (Py_ssize_t): Don't define.
7773         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7774         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7775         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7776         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7777         * python/python.c (do_start_initialization): Remove Python 2.4
7778         workaround.
7779         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7780         (print_children): Remove Python 2.4 workaround.
7781         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7782         workaround.
7783         (CHARBUFFERPROC_NAME): Remove.
7784         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7785         Python 2.4 workaround.
7786
7787 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7788
7789         * NEWS: Note minimum Python version.
7790
7791 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7792
7793         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7794         code from these functions.  Remove corresponding ifdefs.  Use
7795         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7796         Remove gotos and target of gotos.
7797         (infpy_search_memory): Likewise.
7798
7799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7802         (hppa_gdbarch_init): Don't register deleted functions with
7803         gdbarch.
7804
7805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7806
7807         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7808         (h8300_unwind_sp): Delete.
7809         (h8300_dummy_id): Delete.
7810         (h8300_gdbarch_init): Don't register deleted functions with
7811         gdbarch.
7812
7813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7814
7815         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7816         (ft32_unwind_pc): Delete.
7817         (ft32_unwind_sp): Delete.
7818         (ft32_gdbarch_init): Don't register deleted functions with
7819         gdbarch.
7820
7821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7822
7823         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7824         (frv_unwind_pc): Delete.
7825         (frv_unwind_sp): Delete.
7826         (frv_gdbarch_init): Don't register deleted functions with
7827         gdbarch.
7828
7829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7832         (riscv_unwind_pc): Delete.
7833         (riscv_unwind_sp): Delete.
7834         (riscv_gdbarch_init): Don't register deleted functions with
7835         gdbarch.
7836
7837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7840         (csky_unwind_pc): Delete.
7841         (csky_unwind_sp): Delete.
7842         (csky_gdbarch_init): Don't register deleted functions with
7843         gdbarch.
7844
7845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7846
7847         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7848         (cris_unwind_pc): Delete.
7849         (cris_unwind_sp): Delete.
7850         (cris_gdbarch_init): Don't register deleted functions with
7851         gdbarch.
7852
7853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7854
7855         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7856         (bfin_unwind_pc): Delete.
7857         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7858
7859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7860
7861         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7862         (arm_unwind_pc): Delete.
7863         (arm_unwind_sp): Delete.
7864         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7865
7866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7869         (arc_unwind_pc): Delete.
7870         (arc_unwind_sp): Delete.
7871         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7872
7873 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7876         (alpha_unwind_pc): Delete.
7877         (alpha_gdbarch_init): Don't register deleted functions with
7878         gdbarch.
7879
7880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7883         (aarch64_unwind_pc): Delete.
7884         (aarch64_unwind_sp): Delete.
7885         (aarch64_gdbarch_init): Don't register deleted functions with
7886         gdbarch.
7887
7888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7889
7890         * gdbtypes.c (type_align): Don't consider static members when
7891         computing structure alignment.
7892
7893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7896         return 0 for other types.
7897         * arch-utils.c (default_type_align): Always return 0.
7898         * gdbarch.h: Regenerate.
7899         * gdbarch.sh (type_align): Extend comment.
7900         * gdbtypes.c (type_align): Add additional comments, always call
7901         gdbarch_type_align before applying the default rules.
7902         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7903         generic code will then apply a suitable default.
7904         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7905         types, return 0 for other types.
7906
7907 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7908
7909         * NEWS: Create a new section for the next release branch.
7910         Rename the section of the current branch, now that it has
7911         been cut.
7912
7913 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7914
7915         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7916         * version.in: Bump version to 8.3.50.DATE-git.
7917
7918 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7919
7920         * aix-thread.c (ptid_cmp): Remove unused variable.
7921         (get_signaled_thread): Likewise.
7922         (store_regs_user_thread): Likewise.
7923         (store_regs_kernel_thread): Likewise.
7924         (fetch_regs_kernel_thread): Remove shadowed variable.
7925
7926 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7927
7928         * features/riscv/32bit-cpu.xml: Add register numbers.
7929         * features/riscv/32bit-fpu.c: Regenerate.
7930         * features/riscv/32bit-fpu.xml: Add register numbers.
7931         * features/riscv/64bit-cpu.xml: Add register numbers.
7932         * features/riscv/64bit-fpu.c: Regenerate.
7933         * features/riscv/64bit-fpu.xml: Add register numbers.
7934
7935 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7936
7937         * NEWS: Mention two argument form of gdb.Value constructor.
7938         * python/py-value.c (convert_buffer_and_type_to_value): New
7939         function.
7940         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7941         Add support for handling an optional second argument.  Call
7942         convert_buffer_and_type_to_value as appropriate.
7943         * python/python-internal.h (Py_buffer_deleter): New struct.
7944         (Py_buffer_up): New typedef.
7945
7946 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7947
7948         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7949         instead of releasing ownership.
7950
7951 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7952
7953         * dwarf2read.c (open_and_init_dwp_file): Call
7954         elf_numsections instead of bfd_count_sections to initialize
7955         dwp_file->num_sections.
7956
7957 2019-02-25  Tom Tromey  <tromey@adacore.com>
7958
7959         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7960
7961 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7962
7963         * gcore.in: Add '--readnever' option when invoking GDB.
7964
7965 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7966
7967         * MAINTAINERS: Update my email address.
7968
7969 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7970
7971         * build-id.c (build_id_to_debug_bfd_1): New function.
7972         (build_id_to_debug_bfd): Look for separate debug file in
7973         sysroot.
7974
7975 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7976
7977         * gdbarch.sh: Update the copyright year range that is placed into
7978         generated files.
7979
7980 2019-02-22  Keith Seitz  <keiths@redhat.com>
7981
7982         PR symtab/23853
7983         * linespec.c (create_sals_line_offset): Search for the default
7984         symtab's filename instead of its fullname.
7985
7986 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7987
7988         * NEWS: Update style defaults.
7989
7990 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7991
7992         * main.c (captured_main_1): Disable styling in batch mode.
7993
7994 2019-02-20  Tom Tromey  <tom@tromey.com>
7995
7996         * symtab.c (symtab_symbol_info): Fix typos.
7997
7998 2019-02-20  Tom Tromey  <tromey@adacore.com>
7999
8000         * findcmd.c (_initialize_mem_search): Use upper case for
8001         metasyntactic variables.
8002
8003 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8004
8005         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8006         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8007
8008 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8009
8010         * top.h (source_file_name): Change to std::string.
8011         * top.c (source_file_name): Likewise.
8012         (command_line_input): Adjust.
8013         * cli/cli-script.c (script_from_file): Adjust.
8014
8015 2019-02-19  Tom Tromey  <tromey@adacore.com>
8016
8017         * ravenscar-thread.c
8018         (ravenscar_thread_target::update_thread_list): Don't call
8019         ada_build_task_list.
8020         * ada-lang.h (ada_build_task_list): Don't declare.
8021         * ada-tasks.c (struct ada_tasks_inferior_data)
8022         <task_list_valid_p>: Now bool.
8023         (read_known_tasks, ada_task_list_changed)
8024         (ada_tasks_invalidate_inferior_data): Update.
8025         (read_known_tasks_array): Return bool.
8026         (read_known_tasks_list): Likewise.
8027         (read_known_tasks): Return void.
8028         (ada_build_task_list): Now static.
8029
8030 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8031
8032         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8033         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8034
8035 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8036
8037         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8038         variant for ada_tasks_pspace_data_handle and
8039         ada_tasks_inferior_data_handle.
8040         (ada_tasks_pspace_data_cleanup): New function.
8041         (ada_tasks_inferior_data_cleanup): New function.
8042
8043 2019-02-17  Tom Tromey  <tom@tromey.com>
8044
8045         * macrotab.h (macro_source_fullname): Return a std::string.
8046         * macrotab.c (macro_include, check_for_redefinition)
8047         (macro_undef, macro_lookup_definition, foreach_macro)
8048         (foreach_macro_in_scope): Update.
8049         (macro_source_fullname): Return a std::string.
8050         * macrocmd.c (show_pp_source_pos): Update.
8051
8052 2019-02-17  Tom Tromey  <tom@tromey.com>
8053
8054         * macrocmd.c (show_pp_source_pos): Style the file names.
8055
8056 2019-02-17  Tom Tromey  <tom@tromey.com>
8057
8058         PR tui/24197:
8059         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8060
8061 2019-02-17  Tom Tromey  <tom@tromey.com>
8062
8063         * ada-lang.c (user_select_syms): Use filtered printing.
8064         * utils.c (wrap_style): New global.
8065         (desired_style): Remove.
8066         (emit_style_escape): Add stream parameter.
8067         (set_output_style, reset_terminal_style, prompt_for_continue):
8068         Update.
8069         (flush_wrap_buffer): Only flush gdb_stdout.
8070         (wrap_here): Set wrap_style.
8071         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8072         treat escape sequences as a character.  Change when wrap buffer is
8073         flushed.
8074         (fputs_styled): Do not set the output style when the default is
8075         requested.
8076         * ui-style.h (struct ui_file_style) <is_default>: New method.
8077         * source.c (print_source_lines_base): Emit escape sequences in one
8078         piece.
8079
8080 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8081
8082         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8083         integers and enumeration types.
8084
8085 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8086
8087         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8088         instead of lookup_symbol_in_language
8089         (do_exact_match): New function.
8090         (ada_get_symbol_name_matcher): Return do_exact_match when
8091         doing a verbatim match.
8092
8093 2019-02-15  Tom Tromey  <tromey@adacore.com>
8094
8095         * ravenscar-thread.c (ravenscar_thread_target::resume)
8096         (ravenscar_thread_target::wait): Special case wildcard requests.
8097
8098 2019-02-15  Tom Tromey  <tromey@adacore.com>
8099
8100         * ravenscar-thread.c (base_ptid): Remove.
8101         (struct ravenscar_thread_target) <close>: New method.
8102         <m_base_ptid>: New member.
8103         <update_inferior_ptid, active_task, task_is_currently_active,
8104         runtime_initialized>: Declare methods.
8105         <ravenscar_thread_target>: Add constructor.
8106         (ravenscar_thread_target::task_is_currently_active)
8107         (ravenscar_thread_target::update_inferior_ptid)
8108         (ravenscar_runtime_initialized): Rename.  Now methods.
8109         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8110         (ravenscar_thread_target::update_thread_list): Update.
8111         (ravenscar_thread_target::active_task): Now method.
8112         (ravenscar_thread_target::store_registers)
8113         (ravenscar_thread_target::prepare_to_store)
8114         (ravenscar_thread_target::prepare_to_store)
8115         (ravenscar_thread_target::mourn_inferior): Update.
8116         (ravenscar_inferior_created): Use "new" to create target.
8117         (ravenscar_thread_target::get_ada_task_ptid): Update.
8118         (_initialize_ravenscar): Don't initialize base_ptid.
8119         (ravenscar_ops): Remove global.
8120
8121 2019-02-15  Tom Tromey  <tromey@adacore.com>
8122
8123         * target.h (push_target): Declare new overload.
8124         * target.c (push_target): New overload, taking an rvalue reference.
8125         * remote.c (remote_target::open_1): Use push_target overload.
8126         * corelow.c (core_target_open): Use push_target overload.
8127
8128 2019-02-15  Tom Tromey  <tromey@adacore.com>
8129
8130         * ravenscar-thread.c (is_ravenscar_task)
8131         (ravenscar_task_is_currently_active): Return bool.
8132         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8133         (_initialize_ravenscar): Remove "(void)".
8134         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8135         Return bool.
8136
8137 2019-02-15  Tom Tromey  <tromey@adacore.com>
8138
8139         * ravenscar-thread.c (ravenscar_runtime_initializer)
8140         (has_ravenscar_runtime, get_running_thread_id)
8141         (ravenscar_thread_target::resume): Fix indentation.
8142
8143 2019-02-15  Tom Tromey  <tromey@adacore.com>
8144
8145         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8146         from ravenscar_arch_ops.
8147         (sparc_ravenscar_ops::fetch_registers)
8148         (sparc_ravenscar_ops::store_registers): Now methods.
8149         (sparc_ravenscar_prepare_to_store): Remove.
8150         (sparc_ravenscar_ops): Redefine.
8151         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8152         methods and destructor.  Remove members.
8153         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8154         (ravenscar_thread_target::store_registers)
8155         (ravenscar_thread_target::prepare_to_store): Update.
8156         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8157         Remove.
8158         (struct ppc_ravenscar_powerpc_ops): Derive from
8159         ravenscar_arch_ops.
8160         (ppc_ravenscar_powerpc_ops::fetch_registers)
8161         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8162         (ppc_ravenscar_powerpc_ops): Redefine.
8163         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8164         (ppc_ravenscar_e500_ops::fetch_registers)
8165         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8166         (ppc_ravenscar_e500_ops): Redefine.
8167         * aarch64-ravenscar-thread.c
8168         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8169         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8170         (aarch64_ravenscar_fetch_registers)
8171         (aarch64_ravenscar_store_registers): Now methods.
8172         (aarch64_ravenscar_ops): Redefine.
8173
8174 2019-02-15  Tom Tromey  <tromey@adacore.com>
8175
8176         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8177         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8178         (ravenscar_thread_target::stopped_by_watchpoint)
8179         (ravenscar_thread_target::stopped_data_address)
8180         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8181
8182 2019-02-15  Tom Tromey  <tromey@adacore.com>
8183
8184         * ravenscar-thread.c: Fix some typos.
8185
8186 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8187             Tom Tromey  <tromey@adacore.com>
8188
8189         * ada-lang.c (ada_exception_sal): Change addr_string to a
8190         std::string.
8191         (create_ada_exception_catchpoint): Update.
8192
8193 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8194             Tom Tromey  <tromey@adacore.com>
8195
8196         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8197         (bp_location_ops): Remove.
8198         (base_breakpoint_allocate_location): Update.
8199         (free_bp_location): Update.
8200         * ada-lang.c (class ada_catchpoint_location)
8201         <ada_catchpoint_location>: Remove ops parameter.
8202         (ada_catchpoint_location_dtor): Remove.
8203         (ada_catchpoint_location_ops): Remove.
8204         (allocate_location_exception): Update.
8205         * breakpoint.h (struct bp_location_ops): Remove.
8206         (class bp_location) <bp_location>: Remove bp_location_ops
8207         parameter.
8208         <~bp_location>: Add destructor.
8209         <ops>: Remove.
8210
8211 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8212             Pedro Alves  <palves@redhat.com>
8213
8214         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8215         'PATH_MAX'.
8216
8217 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8218             Samuel Thibault  <samuel.thibault@gnu.org>
8219             Thomas Schwinge  <thomas@codesourcery.com>
8220
8221         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8222         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8223
8224 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8225
8226         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8227         (check_empty): Use "const char *".
8228
8229         * gnu-nat.c (gnu_nat_target::detach): Instead of
8230         'detach_inferior (pid)' call
8231         'detach_inferior (find_inferior_pid (pid))'.
8232
8233         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8234         'nat/fork-inferior.o'.
8235         * gnu-nat.c: #include "nat/fork-inferior.h".
8236
8237         * gnu-nat.c (gnu_nat_target::detach): Instead of
8238         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8239         * gnu-nat.h: #include "inf-child.h".
8240         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8241         'i386_gnu_nat_target::fetch_registers'.
8242         (gnu_store_registers): Rename/move to
8243         'i386_gnu_nat_target::store_registers'.
8244
8245         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8246         * gnu-nat.h (mach_thread_info): New function.
8247         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8248
8249         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8250
8251 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8252
8253         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8254
8255 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8256
8257         * windows-nat.c (windows_add_thread): Add new parameter
8258         "main_thread_p" with default value set to false.  Update
8259         function documentation as well as all callers.
8260         (windows_delete_thread): Likewise.
8261         (fake_create_process): Update call to windows_add_thread.
8262         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8263         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8264         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8265         call to windows_delete_thread.
8266
8267 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8268
8269         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8270
8271 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8272
8273         * symfile.c (find_separate_debug_file): Use canonical path of
8274         sysroot with child_path instead of gdb_sysroot if it is valid.
8275
8276 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8277
8278         * symfile.c (find_separate_debug_file): Use child_path to
8279         determine if an object file is under a sysroot.
8280
8281 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8282
8283         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8284         unittests/child-path-selftests.c.
8285         * common/pathstuff.c (child_path): New function.
8286         * common/pathstuff.h (child_path): New prototype.
8287         * unittests/child-path-selftests.c: New file.
8288
8289 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8290
8291         * symfile.c (find_separate_debug_file): Look for separate debug
8292         files in debug directories under the sysroot.
8293
8294 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8295
8296         * symtab.h (struct minimal_symbol data_p): New const method.
8297         (struct minimal_symbol text_p): Likewise.
8298         * symtab.c (output_source_filename): Use file name style
8299         to print file name.
8300         (print_symbol_info): Likewise.
8301         (print_msymbol_info): Use address style to print addresses.
8302         Use function name style to print executable text symbols.
8303         (expand_symtab_containing_pc): Use data_p.
8304         (find_pc_sect_compunit_symtab): Likewise.
8305
8306 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8307
8308         * breakpoint.c (describe_other_breakpoints): Use address style
8309         to print addresses.
8310         (say_where): Likewise.
8311
8312 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8313
8314         * ada-typeprint.c (print_func_type): Print function name
8315         style to print function name.
8316         * c-typeprint.c (c_print_type_1): Likewise.
8317
8318 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8319
8320         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8321         for execve.
8322
8323 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8324
8325         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8326         type_stack.
8327
8328 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8329
8330         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8331         TYPE_CODE_REF types.
8332
8333 2019-02-08  Jim Wilson  <jimw@sifive.com>
8334
8335         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8336         (riscv_linux_fregset): New.
8337         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8338
8339 2019-02-07  Tom Tromey  <tom@tromey.com>
8340
8341         * thread.c (thread_cancel_execution_command): Update.
8342         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8343         methods.
8344         (struct thread_fsm_ops): Remove.
8345         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8346         (thread_fsm_should_stop, thread_fsm_return_value)
8347         (thread_fsm_set_finished, thread_fsm_finished_p)
8348         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8349         Don't declare.
8350         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8351         * infrun.c (clear_proceed_status_thread)
8352         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8353         (print_stop_event): Update.
8354         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8355         Add constructor.
8356         (step_command_fsm_ops): Remove.
8357         (new_step_command_fsm): Remove.
8358         (step_1): Update.
8359         (step_command_fsm::should_stop): Rename from
8360         step_command_fsm_should_stop.
8361         (step_command_fsm::clean_up): Rename from
8362         step_command_fsm_clean_up.
8363         (step_command_fsm::do_async_reply_reason): Rename from
8364         step_command_fsm_async_reply_reason.
8365         (struct until_next_fsm): Inherit from thread_fsm.  Add
8366         constructor.
8367         (until_next_fsm_ops): Remove.
8368         (new_until_next_fsm): Remove.
8369         (until_next_fsm::should_stop): Rename from
8370         until_next_fsm_should_stop.
8371         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8372         (until_next_fsm::do_async_reply_reason): Rename from
8373         until_next_fsm_async_reply_reason.
8374         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8375         constructor.  Change type of breakpoint.
8376         (finish_command_fsm_ops): Remove.
8377         (new_finish_command_fsm): Remove.
8378         (finish_command_fsm::should_stop): Rename from
8379         finish_command_fsm_should_stop.
8380         (finish_command_fsm::clean_up): Rename from
8381         finish_command_fsm_clean_up.
8382         (finish_command_fsm::return_value): Rename from
8383         finish_command_fsm_return_value.
8384         (finish_command_fsm::do_async_reply_reason): Rename from
8385         finish_command_fsm_async_reply_reason.
8386         (finish_command): Update.
8387         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8388         Add constructor.
8389         (call_thread_fsm_ops): Remove.
8390         (call_thread_fsm::call_thread_fsm): Rename from
8391         new_call_thread_fsm.
8392         (call_thread_fsm::should_stop): Rename from
8393         call_thread_fsm_should_stop.
8394         (call_thread_fsm::should_notify_stop): Rename from
8395         call_thread_fsm_should_notify_stop.
8396         (run_inferior_call, call_function_by_hand_dummy): Update.
8397         * cli/cli-interp.c (should_print_stop_to_console): Update.
8398         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8399         Add constructor.  Change type of location_breakpoint,
8400         caller_breakpoint.
8401         (until_break_fsm_ops): Remove.
8402         (new_until_break_fsm): Remove.
8403         (until_break_fsm::should_stop): Rename from
8404         until_break_fsm_should_stop.
8405         (until_break_fsm::clean_up): Rename from
8406         until_break_fsm_clean_up.
8407         (until_break_fsm::do_async_reply_reason): Rename from
8408         until_break_fsm_async_reply_reason.
8409         (until_break_command): Update.
8410         * thread-fsm.c: Remove.
8411         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8412
8413 2019-02-07  Tom Tromey  <tom@tromey.com>
8414
8415         * yy-remap.h: Add include guard.
8416         * xtensa-tdep.h: Add include guard.
8417         * xcoffread.h: Rename include guard.
8418         * varobj-iter.h: Add include guard.
8419         * tui/tui.h: Rename include guard.
8420         * tui/tui-winsource.h: Rename include guard.
8421         * tui/tui-wingeneral.h: Rename include guard.
8422         * tui/tui-windata.h: Rename include guard.
8423         * tui/tui-win.h: Rename include guard.
8424         * tui/tui-stack.h: Rename include guard.
8425         * tui/tui-source.h: Rename include guard.
8426         * tui/tui-regs.h: Rename include guard.
8427         * tui/tui-out.h: Rename include guard.
8428         * tui/tui-layout.h: Rename include guard.
8429         * tui/tui-io.h: Rename include guard.
8430         * tui/tui-hooks.h: Rename include guard.
8431         * tui/tui-file.h: Rename include guard.
8432         * tui/tui-disasm.h: Rename include guard.
8433         * tui/tui-data.h: Rename include guard.
8434         * tui/tui-command.h: Rename include guard.
8435         * tic6x-tdep.h: Add include guard.
8436         * target/waitstatus.h: Rename include guard.
8437         * target/wait.h: Rename include guard.
8438         * target/target.h: Rename include guard.
8439         * target/resume.h: Rename include guard.
8440         * target-float.h: Rename include guard.
8441         * stabsread.h: Add include guard.
8442         * rs6000-tdep.h: Add include guard.
8443         * riscv-fbsd-tdep.h: Add include guard.
8444         * regformats/regdef.h: Rename include guard.
8445         * record.h: Rename include guard.
8446         * python/python.h: Rename include guard.
8447         * python/python-internal.h: Rename include guard.
8448         * python/py-stopevent.h: Rename include guard.
8449         * python/py-ref.h: Rename include guard.
8450         * python/py-record.h: Rename include guard.
8451         * python/py-record-full.h: Rename include guard.
8452         * python/py-record-btrace.h: Rename include guard.
8453         * python/py-instruction.h: Rename include guard.
8454         * python/py-events.h: Rename include guard.
8455         * python/py-event.h: Rename include guard.
8456         * procfs.h: Add include guard.
8457         * proc-utils.h: Add include guard.
8458         * p-lang.h: Add include guard.
8459         * or1k-tdep.h: Rename include guard.
8460         * observable.h: Rename include guard.
8461         * nto-tdep.h: Rename include guard.
8462         * nat/x86-linux.h: Rename include guard.
8463         * nat/x86-linux-dregs.h: Rename include guard.
8464         * nat/x86-gcc-cpuid.h: Add include guard.
8465         * nat/x86-dregs.h: Rename include guard.
8466         * nat/x86-cpuid.h: Rename include guard.
8467         * nat/ppc-linux.h: Rename include guard.
8468         * nat/mips-linux-watch.h: Rename include guard.
8469         * nat/linux-waitpid.h: Rename include guard.
8470         * nat/linux-ptrace.h: Rename include guard.
8471         * nat/linux-procfs.h: Rename include guard.
8472         * nat/linux-osdata.h: Rename include guard.
8473         * nat/linux-nat.h: Rename include guard.
8474         * nat/linux-namespaces.h: Rename include guard.
8475         * nat/linux-btrace.h: Rename include guard.
8476         * nat/glibc_thread_db.h: Rename include guard.
8477         * nat/gdb_thread_db.h: Rename include guard.
8478         * nat/gdb_ptrace.h: Rename include guard.
8479         * nat/fork-inferior.h: Rename include guard.
8480         * nat/amd64-linux-siginfo.h: Rename include guard.
8481         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8482         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8483         * nat/aarch64-linux.h: Rename include guard.
8484         * nat/aarch64-linux-hw-point.h: Rename include guard.
8485         * mn10300-tdep.h: Add include guard.
8486         * mips-linux-tdep.h: Add include guard.
8487         * mi/mi-parse.h: Rename include guard.
8488         * mi/mi-out.h: Rename include guard.
8489         * mi/mi-main.h: Rename include guard.
8490         * mi/mi-interp.h: Rename include guard.
8491         * mi/mi-getopt.h: Rename include guard.
8492         * mi/mi-console.h: Rename include guard.
8493         * mi/mi-common.h: Rename include guard.
8494         * mi/mi-cmds.h: Rename include guard.
8495         * mi/mi-cmd-break.h: Rename include guard.
8496         * m2-lang.h: Add include guard.
8497         * location.h: Rename include guard.
8498         * linux-record.h: Rename include guard.
8499         * linux-nat.h: Add include guard.
8500         * linux-fork.h: Add include guard.
8501         * i386-darwin-tdep.h: Rename include guard.
8502         * hppa-linux-offsets.h: Add include guard.
8503         * guile/guile.h: Rename include guard.
8504         * guile/guile-internal.h: Rename include guard.
8505         * gnu-nat.h: Rename include guard.
8506         * gdb-stabs.h: Rename include guard.
8507         * frv-tdep.h: Add include guard.
8508         * f-lang.h: Add include guard.
8509         * event-loop.h: Add include guard.
8510         * darwin-nat.h: Rename include guard.
8511         * cp-abi.h: Rename include guard.
8512         * config/sparc/nm-sol2.h: Rename include guard.
8513         * config/nm-nto.h: Rename include guard.
8514         * config/nm-linux.h: Add include guard.
8515         * config/i386/nm-i386gnu.h: Rename include guard.
8516         * config/djgpp/nl_types.h: Rename include guard.
8517         * config/djgpp/langinfo.h: Rename include guard.
8518         * compile/gcc-cp-plugin.h: Add include guard.
8519         * compile/gcc-c-plugin.h: Add include guard.
8520         * compile/compile.h: Rename include guard.
8521         * compile/compile-object-run.h: Rename include guard.
8522         * compile/compile-object-load.h: Rename include guard.
8523         * compile/compile-internal.h: Rename include guard.
8524         * compile/compile-cplus.h: Rename include guard.
8525         * compile/compile-c.h: Rename include guard.
8526         * common/xml-utils.h: Rename include guard.
8527         * common/x86-xstate.h: Rename include guard.
8528         * common/version.h: Rename include guard.
8529         * common/vec.h: Rename include guard.
8530         * common/tdesc.h: Rename include guard.
8531         * common/selftest.h: Rename include guard.
8532         * common/scoped_restore.h: Rename include guard.
8533         * common/scoped_mmap.h: Rename include guard.
8534         * common/scoped_fd.h: Rename include guard.
8535         * common/safe-iterator.h: Rename include guard.
8536         * common/run-time-clock.h: Rename include guard.
8537         * common/refcounted-object.h: Rename include guard.
8538         * common/queue.h: Rename include guard.
8539         * common/ptid.h: Rename include guard.
8540         * common/print-utils.h: Rename include guard.
8541         * common/preprocessor.h: Rename include guard.
8542         * common/pathstuff.h: Rename include guard.
8543         * common/observable.h: Rename include guard.
8544         * common/netstuff.h: Rename include guard.
8545         * common/job-control.h: Rename include guard.
8546         * common/host-defs.h: Rename include guard.
8547         * common/gdb_wait.h: Rename include guard.
8548         * common/gdb_vecs.h: Rename include guard.
8549         * common/gdb_unlinker.h: Rename include guard.
8550         * common/gdb_unique_ptr.h: Rename include guard.
8551         * common/gdb_tilde_expand.h: Rename include guard.
8552         * common/gdb_sys_time.h: Rename include guard.
8553         * common/gdb_string_view.h: Rename include guard.
8554         * common/gdb_splay_tree.h: Rename include guard.
8555         * common/gdb_setjmp.h: Rename include guard.
8556         * common/gdb_ref_ptr.h: Rename include guard.
8557         * common/gdb_optional.h: Rename include guard.
8558         * common/gdb_locale.h: Rename include guard.
8559         * common/gdb_assert.h: Rename include guard.
8560         * common/filtered-iterator.h: Rename include guard.
8561         * common/filestuff.h: Rename include guard.
8562         * common/fileio.h: Rename include guard.
8563         * common/environ.h: Rename include guard.
8564         * common/common-utils.h: Rename include guard.
8565         * common/common-types.h: Rename include guard.
8566         * common/common-regcache.h: Rename include guard.
8567         * common/common-inferior.h: Rename include guard.
8568         * common/common-gdbthread.h: Rename include guard.
8569         * common/common-exceptions.h: Rename include guard.
8570         * common/common-defs.h: Rename include guard.
8571         * common/common-debug.h: Rename include guard.
8572         * common/cleanups.h: Rename include guard.
8573         * common/buffer.h: Rename include guard.
8574         * common/btrace-common.h: Rename include guard.
8575         * common/break-common.h: Rename include guard.
8576         * cli/cli-utils.h: Rename include guard.
8577         * cli/cli-style.h: Rename include guard.
8578         * cli/cli-setshow.h: Rename include guard.
8579         * cli/cli-script.h: Rename include guard.
8580         * cli/cli-interp.h: Rename include guard.
8581         * cli/cli-decode.h: Rename include guard.
8582         * cli/cli-cmds.h: Rename include guard.
8583         * charset-list.h: Add include guard.
8584         * buildsym-legacy.h: Rename include guard.
8585         * bfin-tdep.h: Add include guard.
8586         * ax.h: Rename include guard.
8587         * arm-linux-tdep.h: Add include guard.
8588         * arm-fbsd-tdep.h: Add include guard.
8589         * arch/xtensa.h: Rename include guard.
8590         * arch/tic6x.h: Add include guard.
8591         * arch/i386.h: Add include guard.
8592         * arch/arm.h: Rename include guard.
8593         * arch/arm-linux.h: Rename include guard.
8594         * arch/arm-get-next-pcs.h: Rename include guard.
8595         * arch/amd64.h: Add include guard.
8596         * arch/aarch64-insn.h: Rename include guard.
8597         * arch-utils.h: Rename include guard.
8598         * annotate.h: Add include guard.
8599         * amd64-darwin-tdep.h: Rename include guard.
8600         * aarch64-linux-tdep.h: Add include guard.
8601         * aarch64-fbsd-tdep.h: Add include guard.
8602         * aarch32-linux-nat.h: Add include guard.
8603
8604 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8605
8606         * macrotab.c (macro_define_internal): New function that
8607         factorizes macro_define_object_internal and macro_define_function
8608         code.
8609         (macro_define_object_internal): Use macro_define_internal.
8610         (macro_define_function): Likewise.
8611
8612 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8613
8614         * macrocmd.c (extract_identifier): Return
8615         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8616         callers.
8617
8618 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8619
8620         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8621
8622 2019-02-05  Tom Tromey  <tom@tromey.com>
8623
8624         * target.c (target_stack::unpush): Move assertion earlier.
8625
8626 2019-01-30  Tom Tromey  <tom@tromey.com>
8627
8628         PR python/23615:
8629         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8630         (gdbpy_parse_and_eval): Likewise.
8631         * python/python-internal.h (gdbpy_allow_threads): New class.
8632
8633 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8634
8635         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8636         (aarch64_fbsd_fpregmap): Move earlier.
8637         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8638         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8639         instead of individual calls to trad_frame_set_reg_addr.
8640         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8641         earlier.
8642         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8643         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8644         instead of individual calls to trad_frame_set_reg_addr.
8645
8646 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8647
8648         * CONTRIBUTE: Replace contribution list with wiki link.
8649
8650 2019-01-25  Tom Tromey  <tom@tromey.com>
8651
8652         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8653
8654 2019-01-25  Tom Tromey  <tom@tromey.com>
8655
8656         * xtensa-linux-nat.c: Fix common/ includes.
8657         * xml-support.h: Fix common/ includes.
8658         * xml-support.c: Fix common/ includes.
8659         * x86-linux-nat.c: Fix common/ includes.
8660         * windows-nat.c: Fix common/ includes.
8661         * varobj.h: Fix common/ includes.
8662         * varobj.c: Fix common/ includes.
8663         * value.c: Fix common/ includes.
8664         * valops.c: Fix common/ includes.
8665         * utils.c: Fix common/ includes.
8666         * unittests/xml-utils-selftests.c: Fix common/ includes.
8667         * unittests/utils-selftests.c: Fix common/ includes.
8668         * unittests/unpack-selftests.c: Fix common/ includes.
8669         * unittests/tracepoint-selftests.c: Fix common/ includes.
8670         * unittests/style-selftests.c: Fix common/ includes.
8671         * unittests/string_view-selftests.c: Fix common/ includes.
8672         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8673         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8674         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8675         * unittests/rsp-low-selftests.c: Fix common/ includes.
8676         * unittests/parse-connection-spec-selftests.c: Fix common/
8677         includes.
8678         * unittests/optional-selftests.c: Fix common/ includes.
8679         * unittests/offset-type-selftests.c: Fix common/ includes.
8680         * unittests/observable-selftests.c: Fix common/ includes.
8681         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8682         * unittests/memrange-selftests.c: Fix common/ includes.
8683         * unittests/memory-map-selftests.c: Fix common/ includes.
8684         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8685         * unittests/function-view-selftests.c: Fix common/ includes.
8686         * unittests/environ-selftests.c: Fix common/ includes.
8687         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8688         * unittests/common-utils-selftests.c: Fix common/ includes.
8689         * unittests/cli-utils-selftests.c: Fix common/ includes.
8690         * unittests/array-view-selftests.c: Fix common/ includes.
8691         * ui-file.c: Fix common/ includes.
8692         * tui/tui-io.c: Fix common/ includes.
8693         * tracepoint.h: Fix common/ includes.
8694         * tracepoint.c: Fix common/ includes.
8695         * tracefile-tfile.c: Fix common/ includes.
8696         * top.h: Fix common/ includes.
8697         * top.c: Fix common/ includes.
8698         * thread.c: Fix common/ includes.
8699         * target/waitstatus.h: Fix common/ includes.
8700         * target/waitstatus.c: Fix common/ includes.
8701         * target.h: Fix common/ includes.
8702         * target.c: Fix common/ includes.
8703         * target-memory.c: Fix common/ includes.
8704         * target-descriptions.c: Fix common/ includes.
8705         * symtab.h: Fix common/ includes.
8706         * symfile.c: Fix common/ includes.
8707         * stap-probe.c: Fix common/ includes.
8708         * spu-linux-nat.c: Fix common/ includes.
8709         * sparc-nat.c: Fix common/ includes.
8710         * source.c: Fix common/ includes.
8711         * solib.c: Fix common/ includes.
8712         * solib-target.c: Fix common/ includes.
8713         * ser-unix.c: Fix common/ includes.
8714         * ser-tcp.c: Fix common/ includes.
8715         * ser-pipe.c: Fix common/ includes.
8716         * ser-base.c: Fix common/ includes.
8717         * selftest-arch.c: Fix common/ includes.
8718         * s12z-tdep.c: Fix common/ includes.
8719         * rust-exp.y: Fix common/ includes.
8720         * rs6000-aix-tdep.c: Fix common/ includes.
8721         * riscv-tdep.c: Fix common/ includes.
8722         * remote.c: Fix common/ includes.
8723         * remote-notif.h: Fix common/ includes.
8724         * remote-fileio.h: Fix common/ includes.
8725         * remote-fileio.c: Fix common/ includes.
8726         * regcache.h: Fix common/ includes.
8727         * regcache.c: Fix common/ includes.
8728         * record-btrace.c: Fix common/ includes.
8729         * python/python.c: Fix common/ includes.
8730         * python/py-type.c: Fix common/ includes.
8731         * python/py-inferior.c: Fix common/ includes.
8732         * progspace.h: Fix common/ includes.
8733         * producer.c: Fix common/ includes.
8734         * procfs.c: Fix common/ includes.
8735         * proc-api.c: Fix common/ includes.
8736         * printcmd.c: Fix common/ includes.
8737         * ppc-linux-nat.c: Fix common/ includes.
8738         * parser-defs.h: Fix common/ includes.
8739         * osdata.c: Fix common/ includes.
8740         * obsd-nat.c: Fix common/ includes.
8741         * nat/x86-linux.c: Fix common/ includes.
8742         * nat/x86-linux-dregs.c: Fix common/ includes.
8743         * nat/x86-dregs.h: Fix common/ includes.
8744         * nat/x86-dregs.c: Fix common/ includes.
8745         * nat/ppc-linux.c: Fix common/ includes.
8746         * nat/mips-linux-watch.h: Fix common/ includes.
8747         * nat/mips-linux-watch.c: Fix common/ includes.
8748         * nat/linux-waitpid.c: Fix common/ includes.
8749         * nat/linux-ptrace.h: Fix common/ includes.
8750         * nat/linux-ptrace.c: Fix common/ includes.
8751         * nat/linux-procfs.c: Fix common/ includes.
8752         * nat/linux-personality.c: Fix common/ includes.
8753         * nat/linux-osdata.c: Fix common/ includes.
8754         * nat/linux-namespaces.c: Fix common/ includes.
8755         * nat/linux-btrace.h: Fix common/ includes.
8756         * nat/linux-btrace.c: Fix common/ includes.
8757         * nat/fork-inferior.c: Fix common/ includes.
8758         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8759         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8760         * nat/aarch64-linux.c: Fix common/ includes.
8761         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8762         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8763         * namespace.h: Fix common/ includes.
8764         * mips-linux-tdep.c: Fix common/ includes.
8765         * minsyms.c: Fix common/ includes.
8766         * mi/mi-parse.h: Fix common/ includes.
8767         * mi/mi-main.c: Fix common/ includes.
8768         * mi/mi-cmd-env.c: Fix common/ includes.
8769         * memrange.h: Fix common/ includes.
8770         * memattr.c: Fix common/ includes.
8771         * maint.h: Fix common/ includes.
8772         * maint.c: Fix common/ includes.
8773         * main.c: Fix common/ includes.
8774         * machoread.c: Fix common/ includes.
8775         * location.c: Fix common/ includes.
8776         * linux-thread-db.c: Fix common/ includes.
8777         * linux-nat.c: Fix common/ includes.
8778         * linux-fork.c: Fix common/ includes.
8779         * inline-frame.c: Fix common/ includes.
8780         * infrun.c: Fix common/ includes.
8781         * inflow.c: Fix common/ includes.
8782         * inferior.h: Fix common/ includes.
8783         * inferior.c: Fix common/ includes.
8784         * infcmd.c: Fix common/ includes.
8785         * inf-ptrace.c: Fix common/ includes.
8786         * inf-child.c: Fix common/ includes.
8787         * ia64-linux-nat.c: Fix common/ includes.
8788         * i387-tdep.c: Fix common/ includes.
8789         * i386-tdep.c: Fix common/ includes.
8790         * i386-linux-tdep.c: Fix common/ includes.
8791         * i386-linux-nat.c: Fix common/ includes.
8792         * i386-go32-tdep.c: Fix common/ includes.
8793         * i386-fbsd-tdep.c: Fix common/ includes.
8794         * i386-fbsd-nat.c: Fix common/ includes.
8795         * guile/scm-type.c: Fix common/ includes.
8796         * guile/guile.c: Fix common/ includes.
8797         * go32-nat.c: Fix common/ includes.
8798         * gnu-nat.c: Fix common/ includes.
8799         * gdbthread.h: Fix common/ includes.
8800         * gdbarch-selftests.c: Fix common/ includes.
8801         * gdb_usleep.c: Fix common/ includes.
8802         * gdb_select.h: Fix common/ includes.
8803         * gdb_bfd.c: Fix common/ includes.
8804         * gcore.c: Fix common/ includes.
8805         * fork-child.c: Fix common/ includes.
8806         * findvar.c: Fix common/ includes.
8807         * fbsd-nat.c: Fix common/ includes.
8808         * event-top.c: Fix common/ includes.
8809         * event-loop.c: Fix common/ includes.
8810         * dwarf2read.c: Fix common/ includes.
8811         * dwarf2loc.c: Fix common/ includes.
8812         * dwarf2-frame.c: Fix common/ includes.
8813         * dwarf-index-cache.c: Fix common/ includes.
8814         * dtrace-probe.c: Fix common/ includes.
8815         * disasm-selftests.c: Fix common/ includes.
8816         * defs.h: Fix common/ includes.
8817         * csky-tdep.c: Fix common/ includes.
8818         * cp-valprint.c: Fix common/ includes.
8819         * cp-support.h: Fix common/ includes.
8820         * cp-support.c: Fix common/ includes.
8821         * corelow.c: Fix common/ includes.
8822         * completer.h: Fix common/ includes.
8823         * completer.c: Fix common/ includes.
8824         * compile/compile.c: Fix common/ includes.
8825         * compile/compile-loc2c.c: Fix common/ includes.
8826         * compile/compile-cplus-types.c: Fix common/ includes.
8827         * compile/compile-cplus-symbols.c: Fix common/ includes.
8828         * command.h: Fix common/ includes.
8829         * cli/cli-dump.c: Fix common/ includes.
8830         * cli/cli-cmds.c: Fix common/ includes.
8831         * charset.c: Fix common/ includes.
8832         * build-id.c: Fix common/ includes.
8833         * btrace.h: Fix common/ includes.
8834         * btrace.c: Fix common/ includes.
8835         * breakpoint.h: Fix common/ includes.
8836         * breakpoint.c: Fix common/ includes.
8837         * ax.h:
8838         (enum agent_op): Fix common/ includes.
8839         * ax-general.c (struct aop_map): Fix common/ includes.
8840         * ax-gdb.c: Fix common/ includes.
8841         * auxv.c: Fix common/ includes.
8842         * auto-load.c: Fix common/ includes.
8843         * arm-tdep.c: Fix common/ includes.
8844         * arch/riscv.c: Fix common/ includes.
8845         * arch/ppc-linux-common.c: Fix common/ includes.
8846         * arch/i386.c: Fix common/ includes.
8847         * arch/arm.c: Fix common/ includes.
8848         * arch/arm-linux.c: Fix common/ includes.
8849         * arch/arm-get-next-pcs.c: Fix common/ includes.
8850         * arch/amd64.c: Fix common/ includes.
8851         * arch/aarch64.c: Fix common/ includes.
8852         * arch/aarch64-insn.c: Fix common/ includes.
8853         * arch-utils.c: Fix common/ includes.
8854         * amd64-windows-tdep.c: Fix common/ includes.
8855         * amd64-tdep.c: Fix common/ includes.
8856         * amd64-sol2-tdep.c: Fix common/ includes.
8857         * amd64-obsd-tdep.c: Fix common/ includes.
8858         * amd64-nbsd-tdep.c: Fix common/ includes.
8859         * amd64-linux-tdep.c: Fix common/ includes.
8860         * amd64-linux-nat.c: Fix common/ includes.
8861         * amd64-fbsd-tdep.c: Fix common/ includes.
8862         * amd64-fbsd-nat.c: Fix common/ includes.
8863         * amd64-dicos-tdep.c: Fix common/ includes.
8864         * amd64-darwin-tdep.c: Fix common/ includes.
8865         * agent.c: Fix common/ includes.
8866         * ada-lang.h: Fix common/ includes.
8867         * ada-lang.c: Fix common/ includes.
8868         * aarch64-tdep.c: Fix common/ includes.
8869
8870 2019-01-25  Tom Tromey  <tom@tromey.com>
8871
8872         * common/create-version.sh: Use common/version.h.
8873
8874 2019-01-24  Pedro Alves  <palves@redhat.com>
8875
8876         * infrun.c (signal_stop, signal_print, signal_program)
8877         (signal_catch, signal_pass): Now arrays instead of pointers.
8878         (update_signals_program_target, do_target_resume)
8879         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8880         * linux-nat.c (linux_nat_target::pass_signals)
8881         (linux_nat_target::create_inferior, linux_nat_target::attach):
8882         Adjust.
8883         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8884         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8885         * procfs.c (procfs_target::pass_signals): Adjust.
8886         * record-full.c (record_full_target::resume): Adjust.
8887         * remote.c (remote_target::pass_signals)
8888         (remote_target::program_signals): Adjust.
8889         * target-debug.h (target_debug_print_signals): Now takes a
8890         gdb::array_view as parameter.  Adjust.
8891         * target.h (target_ops) <pass_signals, program_signals>: Replace
8892         pointer and length parameters with gdb::array_view.
8893         (target_pass_signals, target_program_signals): Likewise.
8894         * target-delegates.c: Regenerate.
8895
8896 2019-01-24  Pedro Alves  <palves@redhat.com>
8897
8898         * common/forward-scope-exit.h
8899         (forward_scope_exit::forward_scope_exit): Pass arguments to
8900         m_bind_function directly, instead of creating a std::bind and
8901         copying that.
8902
8903 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8904
8905         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8906         for static members.
8907         (pass_in_v_vfp_candidate): Likewise.
8908
8909 2019-01-23  Tom Tromey  <tom@tromey.com>
8910             Pedro Alves  <palves@redhat.com>
8911
8912         * regcache.c (class regcache_invalidator): Remove.
8913         (regcache::raw_write): Use make_scope_exit.
8914
8915 2019-01-23  Tom Tromey  <tom@tromey.com>
8916
8917         * ui-out.h (class ui_out_emit_type): Update comment.
8918
8919 2019-01-23  Tom Tromey  <tom@tromey.com>
8920
8921         * infrun.c (fetch_inferior_event): Update comment.
8922
8923 2019-01-23  Tom Tromey  <tom@tromey.com>
8924             Pedro Alves  <palves@redhat.com>
8925
8926         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8927         parameter.
8928         (fetch_inferior_event): Use SCOPE_EXIT.
8929
8930
8931 2019-01-23  Tom Tromey  <tom@tromey.com>
8932             Pedro Alves  <palves@redhat.com>
8933
8934         * infrun.c (disable_thread_events): Delete.
8935         (stop_all_threads): Use SCOPE_EXIT.
8936
8937 2019-01-23  Tom Tromey  <tom@tromey.com>
8938             Pedro Alves  <palves@redhat.com>
8939
8940         * symfile.c: Include forward-scope-exit.h.
8941         (clear_symtab_users_cleanup): Replace forward declaration with
8942         a FORWARD_SCOPE_EXIT.
8943         (syms_from_objfile_1): Use the forward_scope_exit and
8944         gdb::optional instead of cleanup_function.
8945         (reread_symbols): Use the forward_scope_exit instead of
8946         cleanup_function.
8947         (clear_symtab_users_cleanup): Remove function.
8948
8949 2019-01-23  Tom Tromey  <tom@tromey.com>
8950             Pedro Alves  <palves@redhat.com>
8951
8952         * linux-nat.c: Include scope-exit.h.
8953         (cleanup_target_stop): Remove.
8954         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8955         SCOPE_EXIT.
8956
8957 2019-01-23  Tom Tromey  <tom@tromey.com>
8958             Pedro Alves  <palves@redhat.com>
8959
8960         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8961         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8962
8963 2019-01-23  Tom Tromey  <tom@tromey.com>
8964             Andrew Burgess  <andrew.burgess@embecosm.com>
8965             Pedro Alves  <palves@redhat.com>
8966
8967         * infrun.c (fetch_inferior_event): Use scope_exit.
8968         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8969         * top.c (execute_command): Use scope_exit.
8970         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8971         * utils.c (do_bpstat_clear_actions_cleanup)
8972         (make_bpstat_clear_actions_cleanup): Remove.
8973
8974 2019-01-23  Tom Tromey  <tom@tromey.com>
8975             Pedro Alves  <palves@redhat.com>
8976
8977         * infrun.c: Include "common/scope-exit.h"
8978         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8979         (wait_for_inferior): Use SCOPE_EXIT.
8980         (fetch_inferior_event): Use scope_exit.
8981
8982 2019-01-23  Tom Tromey  <tom@tromey.com>
8983             Pedro Alves  <palves@redhat.com>
8984
8985         * breakpoint.c (create_breakpoint): Remove cleanup.
8986
8987 2019-01-23  Tom Tromey  <tom@tromey.com>
8988             Andrew Burgess  <andrew.burgess@embecosm.com>
8989             Pedro Alves  <palves@redhat.com>
8990
8991 2019-01-23  Pedro Alves  <palves@redhat.com>
8992
8993         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8994
8995 2019-01-23  Pedro Alves  <palves@redhat.com>
8996             Andrew Burgess  <andrew.burgess@embecosm.com>
8997
8998         * gdbthread.h: Include "common/forward-scope-exit.h".
8999         (scoped_finish_thread_state): Redefine custom class in terms of
9000         forward_scope_exit.
9001
9002 2019-01-23  Pedro Alves  <palves@redhat.com>
9003             Andrew Burgess  <andrew.burgess@embecosm.com>
9004
9005         * common/forward-scope-exit.h: New file.
9006
9007 2019-01-23  Pedro Alves  <palves@redhat.com>
9008             Andrew Burgess  <andrew.burgess@embecosm.com>
9009             Tom Tromey  <tom@tromey.com>
9010
9011         * common/scope-exit.h: New file.
9012
9013 2019-01-23  Pedro Alves  <palves@redhat.com>
9014
9015         * common/preprocessor.h (ESC): Rename to ...
9016         (ESC_PARENS): ... this.
9017         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9018         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9019
9020 2019-01-23  Tom Tromey  <tom@tromey.com>
9021
9022         * language.h (class scoped_switch_to_sym_language_if_auto):
9023         Initialize m_lang in both cases.
9024
9025 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9026
9027         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9028         with XCNEW.
9029
9030 2019-01-22  Tom Tromey  <tom@tromey.com>
9031
9032         * corelow.c: Do not include sys/file.h.
9033
9034 2019-01-22  Tom Tromey  <tom@tromey.com>
9035
9036         * tui/tui-wingeneral.h: Include gdb_curses.h.
9037
9038 2019-01-22  Tom Tromey  <tom@tromey.com>
9039
9040         * source-cache.h (class source_cache) <get_source_lines,
9041         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9042
9043 2019-01-22  Tom Tromey  <tom@tromey.com>
9044
9045         * remote-fileio.h (struct remote_target): Declare.
9046
9047 2019-01-22  Tom Tromey  <tom@tromey.com>
9048
9049         * python/py-arch.c: Do not include py-ref.h.
9050         * python/py-bpevent.c: Do not include py-ref.h.
9051         * python/py-cmd.c: Do not include py-ref.h.
9052         * python/py-continueevent.c: Do not include py-ref.h.
9053         * python/py-event.h: Do not include py-ref.h.
9054         * python/py-evtregistry.c: Do not include py-ref.h.
9055         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9056         * python/py-frame.c: Do not include py-ref.h.
9057         * python/py-framefilter.c: Do not include py-ref.h.
9058         * python/py-function.c: Do not include py-ref.h.
9059         * python/py-infevents.c: Do not include py-ref.h.
9060         * python/py-linetable.c: Do not include py-ref.h.
9061         * python/py-objfile.c: Do not include py-ref.h.
9062         * python/py-param.c: Do not include py-ref.h.
9063         * python/py-prettyprint.c: Do not include py-ref.h.
9064         * python/py-progspace.c: Do not include py-ref.h.
9065         * python/py-symbol.c: Do not include py-ref.h.
9066         * python/py-symtab.c: Do not include py-ref.h.
9067         * python/py-type.c: Do not include py-ref.h.
9068         * python/py-unwind.c: Do not include py-ref.h.
9069         * python/py-utils.c: Do not include py-ref.h.
9070         * python/py-value.c: Do not include py-ref.h.
9071         * python/py-varobj.c: Do not include py-ref.h.
9072         * python/py-xmethods.c: Do not include py-ref.h.
9073         * python/python.c: Do not include py-ref.h.
9074         * varobj.c: Do not include py-ref.h.
9075
9076 2019-01-22  Tom Tromey  <tom@tromey.com>
9077
9078         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9079         keyword for bcache.
9080
9081 2019-01-22  Tom Tromey  <tom@tromey.com>
9082
9083         * compile/compile-cplus-types.c: Remove a comment by #include.
9084
9085 2019-01-22  Tom Tromey  <tom@tromey.com>
9086
9087         * compile/gcc-c-plugin.h: Include compile-internal.h.
9088
9089 2019-01-22  Tom Tromey  <tom@tromey.com>
9090
9091         * stabsread.c (EXTERN): Do not define.
9092         (symnum, next_symbol_text_func, processing_gcc_compilation)
9093         (within_function, global_sym_chain, global_stabs)
9094         (previous_stab_code, this_object_header_files)
9095         (n_this_object_header_files)
9096         (n_allocated_this_object_header_files): Define.
9097         * stabsread.h (EXTERN): Never define.  Use "extern".
9098
9099 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9100
9101         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9102         history_value.
9103
9104 2019-01-21  Tom Tromey  <tom@tromey.com>
9105
9106         * ui-out.c: Fix includes.
9107         * tui/tui-source.c: Fix includes.
9108         * target.c: Fix includes.
9109         * remote.c: Fix includes.
9110         * regcache.c: Fix includes.
9111         * python/py-block.c: Fix includes.
9112         * printcmd.c: Fix includes.
9113         * or1k-tdep.c: Fix includes.
9114         * mi/mi-main.c: Fix includes.
9115         * m32r-tdep.c: Fix includes.
9116         * csky-tdep.c: Fix includes.
9117         * compile/compile-cplus-types.c: Fix includes.
9118         * cli/cli-interp.c: Fix includes.
9119
9120 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9121
9122         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9123         for padding.
9124
9125 2019-01-16  Tom Tromey  <tom@tromey.com>
9126
9127         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9128         earlier.
9129         (struct objfile) <msymbols_range>: Move from top level.
9130         <msymbols>: New method.
9131         (class objfile_msymbols): Remove.
9132         * symtab.c (default_collect_symbol_completion_matches_break_on):
9133         Update.
9134         * symmisc.c (dump_msymbols): Update.
9135         * stabsread.c (scan_file_globals): Update.
9136         * objc-lang.c (info_selectors_command, info_classes_command)
9137         (find_methods): Update.
9138         * minsyms.c (find_solib_trampoline_target): Update.
9139         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9140         * coffread.c (coff_symfile_read): Update.
9141         * ada-lang.c (ada_lookup_simple_minsym)
9142         (ada_collect_symbol_completion_matches): Update.
9143
9144 2019-01-16  Tom Tromey  <tom@tromey.com>
9145
9146         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9147         type.  Remove no-argument constructor.
9148         <iterator::operator++>: Simplify.
9149         <begin>: Update.
9150         <end>: Use minimal_symbol_count.
9151
9152 2019-01-16  Tom Tromey  <tom@tromey.com>
9153
9154         * objfiles.h (struct objfile) <psymtabs>: New method.
9155         (class objfile_psymtabs): Remove.
9156         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9157         typedef.
9158         <range>: New method.
9159         (require_partial_symbols): Change return type.
9160         * psymtab.c (require_partial_symbols)
9161         (psym_expand_symtabs_matching): Update.
9162         * mdebugread.c (parse_partial_symbols): Update.
9163         * dbxread.c (dbx_end_psymtab): Update.
9164
9165 2019-01-15  Tom Tromey  <tom@tromey.com>
9166
9167         * symtab.c (lookup_objfile_from_block)
9168         (lookup_symbol_in_objfile_symtabs)
9169         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9170         (find_line_symtab, info_sources_command)
9171         (default_collect_symbol_completion_matches_break_on)
9172         (make_source_files_completion_list): Update.
9173         * symmisc.c (print_objfile_statistics, dump_objfile)
9174         (maintenance_print_symbols, maintenance_info_symtabs)
9175         (maintenance_check_symtabs, maintenance_info_line_tables):
9176         Update.
9177         * source.c (select_source_symtab)
9178         (forget_cached_source_info_for_objfile): Update.
9179         * objfiles.h (class objfile_compunits): Remove.
9180         (struct objfile) <compunits_range>: New typedef.
9181         (compunits): New method.
9182         * objfiles.c (objfile_relocate1): Update.
9183         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9184         * maint.c (count_symtabs_and_blocks): Update.
9185         * linespec.c (iterate_over_all_matching_symtabs): Update.
9186         * cp-support.c (add_symbol_overload_list_qualified): Update.
9187         * coffread.c (coff_symtab_read): Update.
9188         * ada-lang.c (add_nonlocal_symbols)
9189         (ada_collect_symbol_completion_matches)
9190         (ada_add_global_exceptions): Update.
9191
9192 2019-01-15  Tom Tromey  <tom@tromey.com>
9193
9194         * progspace.h (program_space) <objfiles_safe_range>: New
9195         typedef.
9196         <objfiles_safe>: New method.
9197         * objfiles.h (class all_objfiles_safe): Remove.
9198         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9199         * jit.c (jit_inferior_exit_hook): Update.
9200
9201 2019-01-17  Tom Tromey  <tom@tromey.com>
9202
9203         * progspace.h (program_space) <objfiles_range>: New typedef.
9204         <objfiles>: New method.
9205         <objfiles_head>: Rename from objfiles.
9206         (object_files): Update.
9207         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9208         * guile/scm-pretty-print.c
9209         (ppscm_find_pretty_printer_from_objfiles): Update.
9210         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9211         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9212         Update.
9213         * python/py-progspace.c (pspy_get_objfiles): Update.
9214         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9215         Update.
9216         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9217         (objfpy_lookup_objfile_by_build_id): Update.
9218         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9219         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9220         Update.
9221         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9222         (expand_symtab_containing_pc, lookup_objfile_from_block)
9223         (lookup_static_symbol, basic_lookup_transparent_type)
9224         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9225         (find_line_symtab, info_sources_command)
9226         (default_collect_symbol_completion_matches_break_on)
9227         (make_source_files_completion_list, find_main_name): Update.
9228         * symmisc.c (print_symbol_bcache_statistics)
9229         (print_objfile_statistics, maintenance_print_symbols)
9230         (maintenance_print_msymbols, maintenance_print_objfiles)
9231         (maintenance_info_symtabs, maintenance_check_symtabs)
9232         (maintenance_expand_symtabs, maintenance_info_line_tables):
9233         Update.
9234         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9235         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9236         (map_overlay_command, unmap_overlay_command)
9237         (simple_overlay_update, expand_symtabs_matching)
9238         (map_symbol_filenames): Update.
9239         * symfile-debug.c (set_debug_symfile): Update.
9240         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9241         Update.
9242         * source.c (select_source_symtab, forget_cached_source_info):
9243         Update.
9244         * solib.c (solib_read_symbols): Update.
9245         * solib-spu.c (append_ocl_sos): Update.
9246         * psymtab.c (maintenance_print_psymbols)
9247         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9248         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9249         * printcmd.c (info_symbol_command): Update.
9250         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9251         Update.
9252         * objfiles.h (class all_objfiles): Remove.
9253         * objfiles.c (have_partial_symbols, have_full_symbols)
9254         (have_minimal_symbols, qsort_cmp, update_section_map)
9255         (shared_objfile_contains_address_p)
9256         (default_iterate_over_objfiles_in_search_order): Update.
9257         * objc-lang.c (info_selectors_command, info_classes_command)
9258         (find_methods): Update.
9259         * minsyms.c (find_solib_trampoline_target): Update.
9260         * maint.c (maintenance_info_sections)
9261         (maintenance_translate_address, count_symtabs_and_blocks):
9262         Update.
9263         * main.c (captured_main_1): Update.
9264         * linux-thread-db.c (try_thread_db_load_from_pdir)
9265         (has_libpthread): Update.
9266         * linespec.c (iterate_over_all_matching_symtabs)
9267         (search_minsyms_for_name): Update.
9268         * jit.c (jit_find_objf_with_entry_addr): Update.
9269         * hppa-tdep.c (find_unwind_entry)
9270         (hppa_lookup_stub_minimal_symbol): Update.
9271         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9272         Update.
9273         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9274         (elf_gnu_ifunc_resolve_by_got): Update.
9275         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9276         * dwarf-index-write.c (save_gdb_index_command): Update.
9277         * cp-support.c (add_symbol_overload_list_qualified): Update.
9278         * breakpoint.c (create_overlay_event_breakpoint)
9279         (create_longjmp_master_breakpoint)
9280         (create_std_terminate_master_breakpoint)
9281         (create_exception_master_breakpoint): Update.
9282         * blockframe.c (find_pc_partial_function): Update.
9283         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9284         (ada_collect_symbol_completion_matches)
9285         (ada_add_global_exceptions): Update.
9286
9287 2019-01-17  Tom Tromey  <tom@tromey.com>
9288
9289         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9290         declare VEC.
9291         (solib_target_parse_libraries): Change return type.
9292         (library_list_start_segment, library_list_start_section)
9293         (library_list_end_library, library_list_start_library); Update.
9294         (solib_target_free_library_list): Remove.
9295         (solib_target_parse_libraries): Remove cleanup.  Change return
9296         type.
9297         (solib_target_current_sos): Update.
9298
9299 2019-01-17  Tom Tromey  <tromey@bapiya>
9300
9301         * valprint.c: Replace "the the" with "the".
9302         * symtab.c: Replace "the the" with "the".
9303         * solib.c: Replace "the the" with "the".
9304         * solib-dsbt.c: Replace "the the" with "the".
9305         * linespec.c: Replace "the the" with "the".
9306         * dwarf2loc.h: Replace "the the" with "the".
9307         * amd64-windows-tdep.c: Replace "the the" with "the".
9308         * aarch64-tdep.c: Replace "the the" with "the".
9309
9310 2019-01-16  Keith Seitz  <keiths@redhat.com>
9311
9312         PR gdb/23773
9313         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9314         <builder>: Rename to ..
9315         <m_builder>: ... this and make private.
9316         (dwarf2_cu::get_builder): New method.  Change all users of
9317         `builder' to use this method.
9318         (dwarf2_start_symtab): Move to ...
9319         (dwarf2_cu::start_symtab): ... here.  Update all callers
9320         (setup_type_unit_groups): Move to ...
9321         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9322         callers.
9323         (dwarf2_cu::reset_builder): New method.
9324         (process_full_compunit, process_full_type_unit): Use
9325         dwarf2_cu::reset_builder.
9326         (follow_die_offset): Record the ancestor CU if it is different
9327         from the followed DIE's CU.
9328         (follow_die_sig_1): Likewise.
9329
9330 2019-01-15  Tom Tromey  <tom@tromey.com>
9331
9332         * remote.c (class remote_state) <buf>: Now a char_vector.
9333         <buf_size>: Remove.
9334         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9335         parameter.
9336         (remote_target::getpkt_or_notif_sane_1)
9337         (remote_target::getpkt_sane)
9338         (remote_target::getpkt_or_notif_sane): Likewise.
9339         (class remote_target) <putpkt>: New overload.
9340         (remote_target::read_frame): Change type of "buf_p".  Remove
9341         sizeof_p parameter.
9342         (packet_ok): New overload.
9343         (packet_check_result): New overload.
9344         Update all uses.
9345
9346 2019-01-14  Tom Tromey  <tom@tromey.com>
9347
9348         * remote-notif.c (handle_notification, remote_notif_ack)
9349         (remote_notif_parse): Make "buf" const.
9350         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9351         const.
9352         (remote_notif_parse, remote_notif_ack, handle_notification):
9353         Likewise.
9354         * remote.c (remote_notif_stop_parse): Make "buf" const.
9355         (remote_target::remote_parse_stop_reply): Make "buf" const.
9356         (remote_notif_stop_ack): Make "buf" const.
9357
9358 2019-01-14  Tom Tromey  <tom@tromey.com>
9359
9360         * remote.c (remote_console_output): Make parameter const.
9361
9362 2019-01-14  Tom Tromey  <tom@tromey.com>
9363
9364         * target-debug.h (target_debug_print_signals): Constify.
9365         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9366         * procfs.c (procfs_target::pass_signals): Update.
9367         * linux-nat.c (linux_nat_target::pass_signals): Update.
9368         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9369         * target-delegates.c: Rebuild.
9370         * remote.c (remote_target::program_signals): Update.
9371         (remote_target::pass_signals): Update.
9372         * target.c (target_pass_signals): Constify argument.
9373         (target_program_signals): Likewise.
9374         * target.h (struct target_ops) <pass_signals, program_signals>:
9375         Constify argument.
9376         (target_pass_signals, target_program_signals): Constify argument.
9377
9378 2019-01-14  Tom Tromey  <tom@tromey.com>
9379
9380         PR tui/28819:
9381         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9382
9383 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9384
9385         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9386         field.
9387         * rs6000-tdep.c: Include reggroups.h.
9388         (IS_V_ALIAS_PSEUDOREG): Define.
9389         (rs6000_register_name): Return names for the "vX" aliases.
9390         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9391         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9392         aliases.  Call default_register_reggroup_p for all other
9393         pseudo-registers.
9394         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9395         New functions.
9396         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9397         Handle "vX" aliases.
9398         (v_alias_pseudo_register_collect): New function.
9399         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9400         (rs6000_gdbarch_init): Initialize "vX" aliases as
9401         pseudo-registers.  Restore registration of
9402         rs6000_pseudo_register_reggroup_p with
9403         set_tdesc_pseudo_register_reggroup_p.
9404
9405 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9406
9407         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9408         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9409         set_gdbarch_num_pseudo_regs.
9410
9411 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9412
9413         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9414         Remove arg prefixname, add do_set and do_show.
9415         Add member functions set_list and show_list.
9416         * cli/cli-style.c (class cli_style_option): Update accordingly.
9417         (style_set_list): Move to file scope.
9418         (style_show_list): Likewise.
9419         (set_style): Call help_list.
9420         (show_style): Call cmd_show_list.
9421         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9422         Update to use the new macro.
9423
9424 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9425
9426         * ada-lang.c (_initialize_ada_language): Expand the help text
9427         for the "catch exception" command.
9428
9429 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9430
9431         * symtab.c (matching_obj_sections): Initialize obj,
9432         declare it closer to its usage.
9433
9434 2019-01-10  Tom Tromey  <tom@tromey.com>
9435
9436         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9437         (basic_inf_threads_range): Remove.
9438         (inf_threads_range, inf_non_exited_threads_range)
9439         (safe_inf_threads_range): Use next_adapter.
9440
9441 2019-01-10  Keith Seitz  <keiths@redhat.com>
9442
9443         PR gdb/23712
9444         PR symtab/23010
9445         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9446         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9447
9448 2019-01-10  Keith Seitz  <keiths@redhat.com>
9449
9450         PR gdb/23712
9451         PR symtab/23010
9452         * dictionary.c (pending_to_vector): Remove.
9453         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9454         Remove _1 suffix, replacing functions of the same name.  Update
9455         all callers.
9456         (dict_create_hashed, dict_create_hashed_expandable)
9457         (dict_create_linear, dict_create_linear_expandable, dict_free)
9458         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9459         Make functions static.
9460
9461 2019-01-10  Keith Seitz  <keiths@redhat.com>
9462
9463         PR gdb/23712
9464         PR symtab/23010
9465         * dictionary.h (struct dictionary): Replace declaration with
9466         multidictionary.
9467         (dict_create_hashed, dict_create_hashed_expandable)
9468         (dict_create_linear, dict_create_linear_expandable)
9469         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9470         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9471         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9472         taking multidictionary argument.
9473         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9474         * block.h (struct block) <dict>: Change to multidictionary
9475         and rename `multidict'.
9476         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9477         symmisc.c: Update all dictionary references to multidictionary.
9478
9479 2019-01-10  Keith Seitz  <keiths@redhat.com>
9480
9481         PR gdb/23712
9482         PR symtab/23010
9483         * dictionary.c: Include unordered_map.
9484         (pending_to_vector): New function.
9485         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9486         Rewrite the non-"_1" functions to take vector instead
9487         of linked list.
9488         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9489         "new" _1 versions of the same name.
9490         (multidictionary): Define.
9491         (std::hash<enum language): New definition.
9492         (collate_pending_symbols_by_language, mdict_create_hashed)
9493         (mdict_create_hashed_expandable, mdict_create_linear)
9494         (mdict_create_linear_expandable, mdict_free)
9495         (find_language_dictionary, create_new_language_dictionary)
9496         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9497         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9498         (mdict_size, mdict_empty): New functions.
9499         * dictionary.h (mdict_iterator): Define.
9500
9501 2019-01-10  Pedro Alves  <palves@redhat.com>
9502
9503         * breakpoint.c (read_uploaded_action)
9504         (create_tracepoint_from_upload): Adjust to use
9505         gdb::unique_xmalloc_ptr.
9506         * ctf.c (ctf_write_uploaded_tp):
9507         (SET_ARRAY_FIELD): Use emplace_back.
9508         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9509         * tracefile-tfile.c (tfile_write_uploaded_tp):
9510         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9511         gdb::unique_xmalloc_ptr.
9512         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9513         at_string, cond_string, cmd_strings>: Replace char pointers
9514         with gdb::unique_xmalloc_ptr.
9515
9516 2019-01-10  Pedro Alves  <palves@redhat.com>
9517
9518         * solib-target.c (library_list_start_library): Don't xstrdup name.
9519
9520 2019-01-10  Pedro Alves  <palves@redhat.com>
9521
9522         * mdebugread.c (parse_partial_symbols): Use
9523         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9524
9525 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9526
9527         * linux-fork.c (scoped_switch_fork_info)
9528         <~scoped_switch_fork_info>: Fix incorrect variable name.
9529
9530 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9531
9532         * linux-fork.c (scoped_switch_fork_info)
9533         <scoped_switch_fork_info>: Make explicit.
9534         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9535
9536 2019-01-10  Tom Tromey  <tom@tromey.com>
9537
9538         * objfiles.h (objfile::reset_psymtabs): Update.
9539         * objfiles.c (objfile::objfile): Update.
9540         * psymtab.h (psymtab_storage::obstack): Update.
9541         (psymtab_storage::m_obstack): Use gdb::optional.
9542         (class psymtab_storage): Update comment.  Remove objfile
9543         parameter.
9544         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9545
9546 2019-01-10  Tom Tromey  <tom@tromey.com>
9547
9548         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9549         <free_psymtabs>: Now private.
9550         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9551         (allocate_psymtab): Use new method.
9552
9553 2019-01-10  Tom Tromey  <tom@tromey.com>
9554
9555         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9556         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9557         * mdebugread.c (parse_partial_symbols): Use
9558         allocate_dependencies.
9559         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9560         allocate_dependencies.
9561         (process_psymtab_comp_unit_reader)
9562         (build_type_psymtab_dependencies): Likewise.
9563         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9564
9565 2019-01-10  Tom Tromey  <tom@tromey.com>
9566
9567         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9568         PSYMBOL_SET_LANGUAGE.
9569         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9570
9571 2019-01-10  Tom Tromey  <tom@tromey.com>
9572
9573         * psymtab.h (psymtab_storage::obstack): New method.
9574         <m_obstack>: Rename from obstack; now private.
9575         * psymtab.c (psymtab_storage): Update.
9576         * dwarf2read.c (create_addrmap_from_index)
9577         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9578         Update.
9579
9580 2019-01-10  Tom Tromey  <tom@tromey.com>
9581
9582         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9583         * objfiles.h (objfile::reset_psymtabs): New method.
9584
9585 2019-01-10  Tom Tromey  <tom@tromey.com>
9586
9587         * symmisc.c (print_symbol_bcache_statistics): Update.
9588         (print_objfile_statistics): Update.
9589         * symfile.c (reread_symbols): Update.
9590         * psymtab.h (class psymtab_storage): New.
9591         * psymtab.c (psymtab_storage): New constructor.
9592         (~psymtab_storage): New destructor.
9593         (require_partial_symbols): Update.
9594         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9595         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9596         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9597         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9598         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9599         (start_psymtab_common, end_psymtab_common)
9600         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9601         (allocate_psymtab): Update.
9602         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9603         Update.
9604         (dump_psymtab_addrmap, maintenance_print_psymbols)
9605         (maintenance_check_psymtabs): Update.
9606         (class objfile_psymtabs): Move to objfiles.h.
9607         * psympriv.h (discard_psymtab): Now inline.
9608         (psymtab_discarder::psymtab_discarder): Update.
9609         (psymtab_discarder::~psymtab_discarder): Update.
9610         (ALL_OBJFILE_PSYMTABS): Rewrite.
9611         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9612         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9613         Remove fields.
9614         <partial_symtabs>: New field.
9615         (class objfile_psymtabs): Move from psymtab.h.  Update.
9616         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9617         psymbol_cache.
9618         (objfile::~objfile): Don't destroy psymbol_cache.
9619         * mdebugread.c (parse_partial_symbols): Update.
9620         * dwarf2read.c (create_addrmap_from_index)
9621         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9622         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9623         (add_partial_subprogram, dwarf2_ranges_read): Update.
9624         * dwarf-index-write.c (write_address_map)
9625         (write_one_signatured_type, recursively_write_psymbols)
9626         (class debug_names, class debug_names, write_psymtabs_to_index):
9627         Update.
9628
9629 2019-01-10  Tom Tromey  <tom@tromey.com>
9630
9631         * symtab.h (SYMBOL_SET_NAMES): Update.
9632         (symbol_set_names): Update.
9633         (MSYMBOL_SET_NAMES): Update.
9634         * symtab.c (symbol_set_names): Change argument to be an
9635         objfile_per_bfd_storage.
9636         * psymtab.c (add_psymbol_to_bcache): Update.
9637         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9638
9639 2019-01-10  Tom Tromey  <tom@tromey.com>
9640
9641         * symtab.c (create_demangled_names_hash): Change argument to be an
9642         objfile_per_bfd_storage.
9643         (symbol_set_names): Update.
9644
9645 2019-01-10  Tom Tromey  <tom@tromey.com>
9646
9647         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9648         init_psymbol_list.
9649         * psymtab.c (init_psymbol_list): Do nothing if already called.
9650         * psympriv.h (init_psymbol_list): Add comment.
9651         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9652         init_psymbol_list.
9653         * dbxread.c (dbx_symfile_read): Unconditionally call
9654         init_psymbol_list.
9655
9656 2019-01-10  Tom Tromey  <tom@tromey.com>
9657
9658         * xcoffread.c (scan_xcoff_symtab): Update.
9659         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9660         "where".
9661         * mdebugread.c (parse_partial_symbols)
9662         (handle_psymbol_enumerators): Update.
9663         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9664         * dbxread.c (read_dbx_symtab): Update.
9665         * psympriv.h (psymbol_placement): New enum.
9666         (add_psymbol_to_list): Update.
9667
9668 2019-01-10  Tom Tromey  <tom@tromey.com>
9669
9670         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9671         static_psymbols parameters.
9672         (scan_xcoff_symtab): Update.
9673         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9674         static_psymbols parameters.
9675         * psympriv.h (start_psymtab_common): Update.
9676         * mdebugread.c (parse_partial_symbols): Update.
9677         * dwarf2read.c (create_partial_symtab): Update.
9678         * dbxread.c (read_dbx_symtab): Update.
9679         (start_psymtab): Remove global_psymbols and static_psymbols
9680         parameters.
9681
9682 2019-01-10  Tom Tromey  <tom@tromey.com>
9683
9684         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9685         * psymtab.c (allocate_psymtab): Add comment.
9686         * psympriv.h (allocate_psymtab): Add comment.
9687         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9688         initializations.
9689         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9690
9691 2019-01-10  Tom Tromey  <tom@tromey.com>
9692
9693         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9694         Don't declare.
9695         * mipsread.c: Include mdebugread.h.
9696         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9697         Declare.
9698         * elfread.c: Include mdebugread.h.
9699
9700 2019-01-09  Tom Tromey  <tom@tromey.com>
9701
9702         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9703         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9704         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9705         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9706         (psym_lookup_symbol, psym_find_last_source_symtab)
9707         (psym_forget_cached_source_info, psym_print_stats)
9708         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9709         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9710         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9711         (psym_find_compunit_symtab_by_address)
9712         (maintenance_print_psymbols, maintenance_info_psymtabs)
9713         (maintenance_check_psymtabs): Use ranged for.
9714         * psymtab.h (class objfile_psymtabs): New.
9715         (require_partial_symbols): Return objfile_psymtabs.
9716         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9717
9718 2019-01-09  Tom Tromey  <tom@tromey.com>
9719
9720         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9721         (find_pc_mapped_section, list_overlays_command)
9722         (map_overlay_command, unmap_overlay_command)
9723         (simple_overlay_update): Use all_objfiles.
9724         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9725         * printcmd.c (info_symbol_command): Use all_objfiles.
9726         * objfiles.h (ALL_OBJSECTIONS): Remove.
9727         * maint.c (maintenance_translate_address): Use all_objfiles.
9728         * gcore.c (gcore_create_callback): Use all_objfiles.
9729         (objfile_find_memory_regions): Likewise.
9730
9731 2019-01-09  Tom Tromey  <tom@tromey.com>
9732
9733         * symtab.c (find_line_symtab, info_sources_command)
9734         (make_source_files_completion_list): Use objfile_compunits.
9735         * source.c (select_source_symtab): Use objfile_compunits.
9736         * objfiles.h (struct objfile): Update comment.
9737         (ALL_OBJFILES): Remove.
9738         (ALL_FILETABS): Remove.
9739         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9740         objfile_compunits.
9741
9742 2019-01-09  Tom Tromey  <tom@tromey.com>
9743
9744         * symmisc.c (print_objfile_statistics, dump_objfile)
9745         (maintenance_print_symbols): Use compunit_filetabs.
9746         * source.c (forget_cached_source_info_for_objfile): Use
9747         compunit_filetabs.
9748         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9749         (ALL_FILETABS): Use compunit_filetabs.
9750         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9751         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9752
9753 2019-01-09  Tom Tromey  <tom@tromey.com>
9754
9755         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9756         (compunit_filetabs): New.
9757         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9758         compunit_filetabs.
9759         (info_sources_command, make_source_files_completion_list): Remove
9760         declaration.
9761         * symmisc.c (print_objfile_statistics, dump_objfile)
9762         (maintenance_print_symbols): Remove declaration.
9763         (maintenance_info_symtabs): Use compunit_filetabs.
9764         (maintenance_info_line_tables): Likewise.
9765         * source.c (select_source_symtab): Change local variable name.
9766         (forget_cached_source_info_for_objfile): Remove declaration.
9767         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9768         * objfiles.c (objfile_relocate1): Remove declaration.
9769         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9770         declaration.
9771         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9772         * coffread.c (coff_symtab_read): Remove declaration.
9773         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9774         compunit_filetabs.
9775
9776 2019-01-09  Tom Tromey  <tom@tromey.com>
9777
9778         * symtab.c (lookup_objfile_from_block)
9779         (find_pc_sect_compunit_symtab, search_symbols)
9780         (default_collect_symbol_completion_matches_break_on): Use
9781         objfile_compunits.
9782         * objfiles.h (ALL_COMPUNITS): Remove.
9783         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9784         * cp-support.c (add_symbol_overload_list_qualified): Use
9785         objfile_compunits.
9786         * ada-lang.c (ada_collect_symbol_completion_matches)
9787         (ada_add_global_exceptions): Use objfile_compunits.
9788
9789 2019-01-09  Tom Tromey  <tom@tromey.com>
9790
9791         * source.c (select_source_symtab)
9792         (forget_cached_source_info_for_objfile): Remove declaration.
9793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9794         declaration.
9795         * maint.c (count_symtabs_and_blocks): Remove declaration.
9796         * cp-support.c (add_symbol_overload_list_qualified): Remove
9797         declaration.
9798         * coffread.c (coff_symtab_read): Remove declaration.
9799         * symtab.c (lookup_symbol_in_objfile_symtabs)
9800         (basic_lookup_transparent_type_1): Use objfile_compunits.
9801         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9802         (info_sources_command, search_symbols)
9803         (default_collect_symbol_completion_matches_break_on)
9804         (make_source_files_completion_list): Remove declaration.
9805         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9806         (ada_collect_symbol_completion_matches)
9807         (ada_add_global_exceptions): Remove declaration.
9808         * linespec.c (iterate_over_all_matching_symtabs): Use
9809         objfile_compunits.
9810         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9811         (class objfile_compunits): New.
9812         (ALL_COMPUNITS): Use objfile_compunits.
9813         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9814         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9815         objfile_compunits.
9816         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9817
9818 2019-01-09  Tom Tromey  <tom@tromey.com>
9819
9820         * symtab.c (search_symbols)
9821         (default_collect_symbol_completion_matches_break_on): Use
9822         objfile_msymbols.
9823         * ada-lang.c (ada_lookup_simple_minsym)
9824         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9825         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9826         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9827         objfile_msymbols.
9828         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9829         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9830         * objc-lang.c (find_methods): Use objfile_msymbols.
9831         (info_selectors_command, info_classes_command): Likewise.
9832         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9833         * objfiles.h (class objfile_msymbols): New.
9834         (ALL_OBJFILE_MSYMBOLS): Remove.
9835         (ALL_MSYMBOLS): Remove.
9836
9837 2019-01-09  Tom Tromey  <tom@tromey.com>
9838
9839         * common/next-iterator.h (next_adapter): Add Iterator template
9840         parameter.
9841         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9842         (class all_objfiles_safe): New.
9843         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9844         * objfiles.c (put_objfile_before): Update comment.
9845         (add_separate_debug_objfile): Likewise.
9846         (free_all_objfiles): Use all_objfiles_safe.
9847         (objfile_purge_solibs): Likewise.
9848
9849 2019-01-09  Tom Tromey  <tom@tromey.com>
9850
9851         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9852         (expand_symtab_containing_pc, lookup_static_symbol)
9853         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9854         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9855         all_objfiles.
9856         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9857         * breakpoint.c (create_overlay_event_breakpoint)
9858         (create_longjmp_master_breakpoint)
9859         (create_std_terminate_master_breakpoint)
9860         (create_exception_master_breakpoint): Use all_objfiles.
9861         * linux-thread-db.c (try_thread_db_load_from_pdir)
9862         (has_libpthread): Use all_objfiles.
9863         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9864         * linespec.c (iterate_over_all_matching_symtabs)
9865         (search_minsyms_for_name): Use all_objfiles.
9866         * maint.c (maintenance_info_sections): Use all_objfiles.
9867         * main.c (captured_main_1): Use all_objfiles.
9868         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9869         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9870         * guile/scm-pretty-print.c
9871         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9872         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9873         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9874         (maintenance_print_msymbols): Use all_objfiles.
9875         * source.c (select_source_symtab): Use all_objfiles.
9876         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9877         * symfile.c (remove_symbol_file_command)
9878         (expand_symtabs_matching, map_symbol_filenames): Use
9879         all_objfiles.
9880         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9881         all_objfiles.
9882         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9883         * objc-lang.c (find_methods): Use all_objfiles.
9884         * objfiles.c (have_partial_symbols, have_full_symbols)
9885         (have_minimal_symbols, qsort_cmp)
9886         (default_iterate_over_objfiles_in_search_order): Use
9887         all_objfiles.
9888         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9889         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9890         (maintenance_check_psymtabs): Use all_objfiles.
9891         (ALL_PSYMTABS): Remove.
9892         * compile/compile-object-run.c (do_module_cleanup): Use
9893         all_objfiles.
9894         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9895         * cp-support.c (add_symbol_overload_list_qualified): Use
9896         all_objfiles.
9897         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9898         Use all_objfiles.
9899         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9900         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9901         all_objfiles.
9902         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9903         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9904         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9905         Uses all_objfiles.
9906         * solib.c (solib_read_symbols): Use all_objfiles
9907
9908 2019-01-09  Tom Tromey  <tom@tromey.com>
9909
9910         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9911         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9912         all_objfiles.
9913         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9914         * symmisc.c (print_symbol_bcache_statistics)
9915         (print_objfile_statistics, maintenance_print_objfiles)
9916         (maintenance_info_symtabs, maintenance_check_symtabs)
9917         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9918         all_objfiles.
9919         * source.c (forget_cached_source_info): Use all_objfiles.
9920         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9921         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9922         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9923         * objfiles.c (update_section_map): Use all_objfiles.
9924         (shared_objfile_contains_address_p): Likewise.
9925         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9926         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9927
9928 2019-01-09  Tom Tromey  <tom@tromey.com>
9929
9930         * common/next-iterator.h: New file.
9931         * objfiles.h (class all_objfiles): New.
9932         (struct objfile_iterator): New.
9933
9934 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9935
9936         * NEWS: Move the description of the changed "frame", "select-frame",
9937          and "info frame" commands to the Changed commands section.
9938
9939 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9940
9941         * gdbtypes.c (check_stub_method_group): Remove handling of old
9942         mangling schemes.
9943         * linespec.c (find_methods): Likewise.
9944         * stabsread.c (read_member_functions): Likewise.
9945         * valops.c (search_struct_method): Likewise.
9946         (value_struct_elt_for_reference): Likewise.
9947         * NEWS: Mention this change.
9948
9949 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9950
9951         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9952         print_source_lines.
9953         * source.c (print_source_lines_base): Update line number check.
9954         (print_source_lines): New function.
9955         (source_lines_range::source_lines_range): New function.
9956         * source.h (class source_lines_range): New class.
9957         (print_source_lines): New declaration.
9958
9959 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9960
9961         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9962
9963 2019-01-08  Tom Tromey  <tom@tromey.com>
9964             Simon Marchi  <simon.marchi@ericsson.com>
9965
9966         PR gdb/24060
9967         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9968         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9969         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9970         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9971         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9972         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9973
9974 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9975
9976         * source.c (select_source_symtab): Move header comment to
9977         declaration in source.h.
9978         (forget_cached_source_info_for_objfile): Likewise.
9979         (forget_cached_source_info): Likewise.
9980         (identify_source_line): Likewise.
9981         * source.h (identify_source_line): Move declaration from symtab.h
9982         and add comment from source.c
9983         (print_source_lines): Likewise.
9984         (forget_cached_source_info_for_objfile): Likewise.
9985         (forget_cached_source_info): Likewise.
9986         (select_source_symtab): Likewise.
9987         (enum print_source_lines_flag): Move definition from symtab.h.
9988         * symtab.h (identify_source_line): Move declaration to source.h.
9989         (print_source_lines): Likewise.
9990         (forget_cached_source_info_for_objfile): Likewise.
9991         (forget_cached_source_info): Likewise.
9992         (select_source_symtab): Likewise.
9993         (enum print_source_lines_flag): Move definition to source.h.
9994         * tui/tui-hooks.c: Add 'source.h' include.
9995
9996 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9997
9998         * source.c (print_source_lines_base): Handle requests to print
9999         reverse line number sequences, and guard against empty lines
10000         string.
10001
10002 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10003
10004         * source.c (print_source_lines_base): Fix skip of '\r' if next
10005         character is '\n'.
10006
10007 2019-01-06  Tom Tromey  <tom@tromey.com>
10008
10009         * c-exp.y (struct c_parse_state) <macro_original_text,
10010         expansion_obstack>: New member.
10011         (macro_original_text, expansion_obstack): Remove globals.
10012         (scan_macro_expansion, scanning_macro_expansion)
10013         (finished_macro_expansion): Update.
10014         (scan_macro_cleanup): Remove.
10015         (yylex, c_parse): Update.
10016
10017 2019-01-06  Tom Tromey  <tom@tromey.com>
10018
10019         * c-exp.y (struct c_parse_state) <strings>: New member.
10020         (operator_stoken): Update.
10021
10022 2019-01-06  Tom Tromey  <tom@tromey.com>
10023
10024         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10025         (union type_stack_elt) <typelist_val>: Now a pointer to
10026         std::vector.
10027         (type_stack_cleanup): Don't declare.
10028         (push_typelist): Update.
10029         * parse.c (pop_typelist): Return a std::vector.
10030         (push_typelist): Take a std::vector.
10031         (follow_types): Update.  Do not free args.
10032         (type_stack_cleanup): Remove.
10033         * c-exp.y (struct c_parse_state): New.
10034         (cpstate): New global.
10035         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10036         (nonempty_typelist): Update.
10037         (func_mod): Create a new vector.
10038         (c_parse): Create a c_parse_state.
10039         (check_parameter_typelist): Do not delete params.
10040         (function_method): Update.  Do not delete type_list.
10041
10042 2019-01-06  Tom Tromey  <tom@tromey.com>
10043
10044         PR gdb/28155:
10045         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10046         check_typedef.
10047         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10048         (print_return_value): Likewise.
10049
10050 2019-01-05  Tom Tromey  <tom@tromey.com>
10051
10052         * contrib/cleanup_check.py: Remove.
10053         * contrib/gcc-with-excheck: Remove.
10054         * contrib/exsummary.py: Remove.
10055         * contrib/excheck.py: Remove.
10056
10057 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10058
10059         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10060         NULL. Initialize tpprev to NULL instead of assigning it
10061         to NULL on the next statement.
10062         * windows-nat.c (windows_delete_thread): Remove check for
10063         main_thread_id before printing thread exit notifications.
10064         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10065         Remove thread ID check against main_thread_id.
10066         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10067         windows_delete_thread.
10068         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10069
10070 2019-01-04  Tom Tromey  <tom@tromey.com>
10071
10072         * compile/compile.c (_initialize_compile): Use upper case for
10073         metasyntactic variables.
10074         * symmisc.c (_initialize_symmisc): Use upper case for
10075         metasyntactic variables.
10076         * psymtab.c (_initialize_psymtab): Use upper case for
10077         metasyntactic variables.
10078         * demangle.c (demangle_command): Use upper case for metasyntactic
10079         variables.
10080         (_initialize_demangler): Likewise.
10081         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10082         variables.
10083
10084 2019-01-03  Tom Tromey  <tom@tromey.com>
10085
10086         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10087
10088 2019-01-03  Tom Tromey  <tom@tromey.com>
10089
10090         * python/py-symtab.c (salpy_str): Update.
10091         (struct salpy_sal_object) <symtab>: Now a PyObject.
10092         (salpy_dealloc): Update.
10093         (del_objfile_sal): Use gdbpy_ref.
10094
10095 2019-01-03  Tom Tromey  <tom@tromey.com>
10096
10097         * python/py-type.c (convert_field): Use new_reference.  Return
10098         gdbpy_ref.
10099         (make_fielditem): Return gdbpy_ref.
10100         (typy_fields): Update.
10101         (typy_getitem): Update.
10102         (field_name): Return gdbpy_ref.  Use new_reference.
10103         (typy_iterator_iternext): Update.
10104
10105 2019-01-03  Tom Tromey  <tom@tromey.com>
10106
10107         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10108
10109 2019-01-03  Tom Tromey  <tom@tromey.com>
10110
10111         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10112         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10113         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10114         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10115         (pspy_set_type_printers): Likewise.
10116         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10117         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10118         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10119         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10120         (objfpy_set_type_printers): Likewise.
10121
10122 2019-01-03  Tom Tromey  <tom@tromey.com>
10123
10124         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10125         (gdbpy_print_stack): Use gdbpy_err_fetch.
10126         * python/python-internal.h (class gdbpy_err_fetch): New class.
10127         (class gdbpy_enter) <m_error_type, m_error_value,
10128         m_error_traceback>: Remove.
10129         <m_error>: New member.
10130         (gdbpy_exception_to_string): Don't declare.
10131         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10132         * python/py-value.c (convert_value_from_python): Use
10133         gdbpy_err_fetch.
10134         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10135         gdbpy_exception_to_string.
10136         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10137         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10138         gdbpy_err_fetch.
10139
10140 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10141
10142         * linux-nat.c (delete_lwp_cleanup): Delete.
10143         (struct lwp_deleter): New struct.
10144         (lwp_info_up): New typedef.
10145         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10146         lwp_info_up.
10147
10148 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10149
10150         * linux-fork.c (class scoped_switch_fork_info): New class.
10151         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10152
10153 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10154
10155         * valops.c (find_overload_match): Remove use of null_cleanup, and
10156         calls to do_cleanups.
10157
10158 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10159
10160         * compile/compile-cplus-types.c
10161         (compile_cplus_instance::decl_name): Handle changes to
10162         cp_func_name.
10163         * cp-support.c (cp_func_name): Update header comment, update
10164         return type.
10165         * cp-support.h (cp_func_name): Update return type in declaration.
10166         * valops.c (find_overload_match): Move temp_func local to top
10167         level of function and change its type.  Use temp_func to hold and
10168         delete temporary string obtained from cp_func_name.
10169
10170 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10171
10172         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10173         gdb::char_vector, remove cleanup, and update uses of `msg`.
10174
10175 2019-01-03  Jim Wilson  <jimw@sifive.com>
10176
10177         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10178
10179 2019-01-02  Tom Tromey  <tom@tromey.com>
10180
10181         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10182         (tdesc_parse_xml): Remove cleanups.
10183         * target-descriptions.h (make_cleanup_free_target_description):
10184         Don't declare.
10185         (target_desc_deleter): New struct.
10186         (target_desc_up): New typedef.
10187         * target-descriptions.c (target_desc_deleter::operator()): Rename
10188         from free_target_description.
10189         (make_cleanup_free_target_description): Remove.
10190
10191 2019-01-02  Tom Tromey  <tom@tromey.com>
10192
10193         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10194         constructor, destructor.
10195         (linespec_parser): Remove typedef.
10196         (~linespec_parser): Rename from linespec_parser_delete.
10197         (linespec_lex_to_end, linespec_complete_label)
10198         (linespec_complete): Update.
10199         (decode_line_full): Remove cleanups.
10200         (decode_line_1): Update.
10201
10202 2019-01-02  Tom Tromey  <tom@tromey.com>
10203
10204         * python/python-internal.h (inferior_to_inferior_object): Change
10205         return type.
10206         * python/py-exitedevent.c (create_exited_event_object): Update.
10207         * python/py-inferior.c (inferior_to_inferior_object): Return
10208         gdbpy_ref.
10209         (python_new_inferior, python_inferior_deleted)
10210         (thread_to_thread_object, delete_thread_object)
10211         (build_inferior_list, gdbpy_selected_inferior): Update.
10212         * python/py-infthread.c (create_thread_object): Update.  Also fail
10213         if inferior_to_inferior_object fails.
10214
10215 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10216
10217         * inferior.h (class inferior) <displaced_step_state>: New field.
10218         * infrun.h (struct displaced_step_state): Move here from
10219         infrun.c.  Initialize fields, add constructor.
10220         <inf>: Remove field.
10221         <reset>: New method.
10222         * infrun.c (struct displaced_step_inferior_state): Move to
10223         infrun.h.
10224         (displaced_step_inferior_states): Remove.
10225         (get_displaced_stepping_state): Adust.
10226         (displaced_step_in_progress_any_inferior): Adjust.
10227         (displaced_step_in_progress_thread): Adjust.
10228         (displaced_step_in_progress): Adjust.
10229         (add_displaced_stepping_state): Remove.
10230         (get_displaced_step_closure_by_addr): Adjust.
10231         (remove_displaced_stepping_state): Remove.
10232         (infrun_inferior_exit): Call displaced_step_state.reset.
10233         (use_displaced_stepping): Don't check for NULL.
10234         (displaced_step_prepare_throw): Call
10235         get_displaced_stepping_state.
10236         (displaced_step_fixup): Don't check for NULL.
10237         (prepare_for_detach): Don't check for NULL.
10238
10239 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10240
10241         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10242          in case of call that did not complete.
10243
10244 2019-01-02  Andrey Utkin  <autkin@undo.io>
10245
10246         * symfile.c (find_separate_debug_file): Fix search of debug files for
10247         remote debuggee.
10248
10249 2019-01-02  Tom Tromey  <tom@tromey.com>
10250
10251         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10252         indentation.
10253         * python/py-frame.c (frapy_older): Remove cast.
10254         (frapy_newer): Likewise.
10255         * python/py-breakpoint.c (local_setattro): Remove cast.
10256         * python/py-arch.c (archpy_name): Remove local variable.
10257         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10258
10259 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10260
10261         * unittests/basic_string_view/element_access/char/empty.cc:
10262         Fix year range in copyright header.
10263
10264 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10265
10266         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10267         Delete.
10268         <operator==>: Update with for removed field.
10269         <hash>: Likewise.
10270         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10271         <isa_features>: ...this.
10272         <abi_features>: New field.
10273         (riscv_isa_flen): Update comment.
10274         (riscv_abi_xlen): New declaration.
10275         (riscv_abi_flen): New declaration.
10276         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10277         isa_features.
10278         (riscv_abi_xlen): New function.
10279         (riscv_isa_flen): Update to get answer from isa_features.
10280         (riscv_abi_flen): New function.
10281         (riscv_has_fp_abi): Update to get answer from abi_features.
10282         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10283         xlen and flen.
10284         (riscv_call_info) <xlen, flen>: Update comment.
10285         (riscv_call_arg_struct): Remove invalid assertions
10286         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10287         is removed.
10288         (riscv_gdbarch_init): Gather isa features and abi features
10289         separately, ensure both match on the gdbarch when reusing an old
10290         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10291         a target with 64-bit float hardware.
10292
10293 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10294
10295         * source.c (search_command_helper): Stop reverse search
10296         when line 1 has been searched.
10297
10298 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10299
10300         * record-full.c (record_full_base_target::close): Rewrite
10301         record_full_core_buf_list free logic.
10302
10303 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10304
10305         * break-catch-syscall.c (print_one_catch_syscall): xfree
10306         the last text.
10307
10308 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10309
10310         * top.c (print_gdb_version): Update Copyright year in version
10311         message.
10312
10313 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10314
10315         Update copyright year range in all GDB files.
10316
10317 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10318
10319         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10320
10321 For older changes see ChangeLog-2018.
10322 \f
10323 Local Variables:
10324 mode: change-log
10325 left-margin: 8
10326 fill-column: 74
10327 version-control: never
10328 coding: utf-8
10329 End:
10330