gdb/fortran: Add support for the ABS intrinsic function
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2             Chris January  <chris.january@arm.com>
3             David Lecomber  <david.lecomber@arm.com>
4
5         * f-exp.y: New token, UNOP_INTRINSIC.
6         (exp): New pattern using UNOP_INTRINSIC token.
7         (f77_keywords): Add 'abs' keyword.
8         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9         (value_from_host_double): New function.
10         (evaluate_subexp_f): Support UNOP_ABS.
11
12 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13
14         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
15         types.
16
17 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
18
19         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
20         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
21         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
22
23 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
24
25         * f-exp.y (convert_to_kind_type): Handle more type kinds.
26
27 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
28             Chris January  <chris.january@arm.com>
29
30         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
31         * f-exp.y: Define 'KIND' token.
32         (exp): New pattern for KIND expressions.
33         (ptype): Handle types with a kind extension.
34         (direct_abs_decl): Extend to spot kind extensions.
35         (f77_keywords): Add 'kind' to the list.
36         (push_kind_type): New function.
37         (convert_to_kind_type): New function.
38         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
39         * parse.c (operator_length_standard): Likewise.
40         * parser-defs.h (enum type_pieces): Add tp_kind.
41         * std-operator.def: Add UNOP_KIND.
42
43 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
44
45         * f-exp.y (f_parse): Set yydebug.
46
47 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
48
49         * f-lang.c (evaluate_subexp_f): New function.
50         (exp_descriptor_f): New global.
51         (f_language_defn): Use exp_descriptor_f instead of
52         exp_descriptor_standard.
53
54 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
55
56         * f-exp.y (struct token): Add comments.
57         (dot_ops): Remove uppercase versions and the end marker.
58         (f77_keywords): Likewise.
59         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
60         entries in the dot_ops array are case insensitive, and use
61         strncasecmp to compare strings.  Also some whitespace cleanup in
62         this area.  Similar for the f77_keywords array, except entries in
63         this list might be case sensitive.
64
65 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
66
67         * f-exp.y (struct f77_boolean_val): Add comments.
68         (boolean_values): Remove uppercase versions, and end marker.
69         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
70         and use strncasecmp to achieve case insensitivity.  Additionally,
71         perform whitespace cleanup around this code.
72
73 2019-03-06  Tom Tromey  <tromey@adacore.com>
74
75         * remote-sim.c (gdbsim_target_open): Use result of
76         gdb_argv::release.
77
78 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
79         Dirk Schubert  <dirk.schubert@arm.com>
80         Chris January  <chris.january@arm.com>
81
82         * eval.c (evaluate_subexp_standard): Call Fortran argument
83         wrapping logic.
84         * f-lang.c (struct value): A value which can be passed into a
85         Fortran function call.
86         (fortran_argument_convert): Wrap Fortran arguments in a pointer
87         where appropriate.
88         (struct type): Value ready for a Fortran function call.
89         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
90         is needed.
91         * f-lang.h (fortran_argument_convert): Declaration.
92         (fortran_preserve_arg_pointer): Declaration.
93         * infcall.c (value_arg_coerce): Call Fortran argument logic.
94
95 2019-03-05  Tom Tromey  <tromey@adacore.com>
96
97         * python/py-prettyprint.c (print_string_repr): Remove #if.
98         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
99
100 2019-03-05  Tom Tromey  <tromey@adacore.com>
101
102         * target.c (the_dummy_target): Move later.  Change type to
103         "dummy_target".
104         (initialize_targets): Don't initialize the_dummy_target.
105
106 2019-03-05  Tom Tromey  <tromey@adacore.com>
107
108         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
109         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
110
111 2019-03-05  Tom Tromey  <tromey@adacore.com>
112
113         * windows-nat.c (windows_nat_target::attach)
114         (windows_nat_target::detach): Don't call gdb_flush.
115         * valprint.c (generic_val_print, val_print, val_print_string):
116         Don't call gdb_flush.
117         * utils.c (defaulted_query): Don't call gdb_flush.
118         * typeprint.c (print_type_scalar): Don't call gdb_flush.
119         * target.c (target_announce_detach): Don't call gdb_flush.
120         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
121         * remote.c (extended_remote_target::attach): Don't call
122         gdb_flush.
123         * procfs.c (procfs_target::detach): Don't call gdb_flush.
124         * printcmd.c (do_examine): Don't call gdb_flush.
125         (info_display_command): Don't call gdb_flush.
126         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
127         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
128         * memattr.c (info_mem_command): Don't call gdb_flush.
129         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
130         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
131         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
132         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
133         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
134         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
135         (gnu_nat_target::detach): Don't call gdb_flush.
136         * f-valprint.c (f_val_print): Don't call gdb_flush.
137         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
138         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
139         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
140         gdb_flush.
141         * c-valprint.c (c_val_print): Don't call gdb_flush.
142         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
143
144 2019-03-05  Tom Tromey  <tromey@adacore.com>
145
146         * varobj.c (update_dynamic_varobj_children): Update.
147         (install_default_visualizer): Use reset, not release.
148         * value.c (set_internalvar): Update.
149         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
150         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
151         ATTRIBUTE_UNUSED_RESULT.
152
153 2019-03-05  Tom Tromey  <tromey@adacore.com>
154
155         * remote.c (class scoped_remote_fd) <release>: Add
156         ATTRIBUTE_UNUSED_RESULT.
157
158 2019-03-05  Tom Tromey  <tromey@adacore.com>
159
160         * macroexp.c (struct macro_buffer) <release>: Add
161         ATTRIBUTE_UNUSED_RESULT.
162
163 2019-03-05  Tom Tromey  <tromey@adacore.com>
164
165         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
166         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
167         ATTRIBUTE_UNUSED_RESULT.
168
169 2019-03-05  Tom Tromey  <tromey@adacore.com>
170
171         * common/scoped_fd.h (class scoped_fd) <release>: Add
172         ATTRIBUTE_UNUSED_RESULT.
173
174 2019-03-05  Tom Tromey  <tromey@adacore.com>
175
176         * parser-defs.h (struct parser_state) <release>: Add
177         ATTRIBUTE_UNUSED_RESULT.
178
179 2019-03-05  Tom Tromey  <tromey@adacore.com>
180
181         * utils.h (class gdb_argv) <release>: Add
182         ATTRIBUTE_UNUSED_RESULT.
183         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
184
185 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
186
187         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
188         for-loop range, to avoid compiler warnings.
189
190         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
191         avoid compiler warnings about unused variables.
192
193         * NEWS: Mention end of support for native debugging on MS-Windows
194         before XP.
195
196         PR gdb/24292
197         * common/netstuff.c:
198         * gdbserver/gdbreplay.c
199         * gdbserver/remote-utils.c:
200         * ser-tcp.c:
201         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
202         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
203         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
204         'getaddrinfo' and 'freeaddrinfo' were not available before
205         Windows XP, and mingw.org's MinGW headers by default define
206         _WIN32_WINNT to 0x500.
207
208 2019-03-01  Gary Benson <gbenson@redhat.com>
209
210         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
211
212 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
213             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
214
215         PR gdb/8527
216         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
217         set_sigint_trap, clear_sigint_trap.
218
219 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
220
221         * target.c (target_detach): Clear the regcache and the
222         frame cache.
223
224 2019-02-27  Pedro Alves  <palves@redhat.com>
225
226         * utils.c (set_screen_size): When we cap the height/width sizes,
227         tweak the corresponding command variable to show "unlimited":
228
229 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
230             Pedro Alves  <palves@redhat.com>
231
232         * utils.c (set_screen_size): Reduce "infinite" rows and columns
233         before calling rl_set_screen_size.
234
235 2019-02-27  Tom Tromey  <tromey@adacore.com>
236
237         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
238         define.
239         * python/py-value.c: Remove Python 2.4 workaround.
240         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
241         workaround.
242         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
243         Python 2.4 workaround.
244         * python/python-internal.h: Remove Python 2.4 comment.
245         (Py_ssize_t): Don't define.
246         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
247         (gdb_Py_DECREF): Remove Python 2.4 workaround.
248         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
249         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
250         * python/python.c (do_start_initialization): Remove Python 2.4
251         workaround.
252         * python/py-prettyprint.c (class dummy_python_frame): Remove.
253         (print_children): Remove Python 2.4 workaround.
254         * python/py-inferior.c (buffer_procs): Remove Python 2.4
255         workaround.
256         (CHARBUFFERPROC_NAME): Remove.
257         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
258         Python 2.4 workaround.
259
260 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
261
262         * NEWS: Note minimum Python version.
263
264 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
265
266         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
267         code from these functions.  Remove corresponding ifdefs.  Use
268         Py_buffer_up instead of explicit calls to PyBuffer_Release.
269         Remove gotos and target of gotos.
270         (infpy_search_memory): Likewise.
271
272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
273
274         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
275         (hppa_gdbarch_init): Don't register deleted functions with
276         gdbarch.
277
278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
279
280         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
281         (h8300_unwind_sp): Delete.
282         (h8300_dummy_id): Delete.
283         (h8300_gdbarch_init): Don't register deleted functions with
284         gdbarch.
285
286 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
287
288         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
289         (ft32_unwind_pc): Delete.
290         (ft32_unwind_sp): Delete.
291         (ft32_gdbarch_init): Don't register deleted functions with
292         gdbarch.
293
294 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
295
296         * gdb/frv-tdep.c (frv_dummy_id): Delete.
297         (frv_unwind_pc): Delete.
298         (frv_unwind_sp): Delete.
299         (frv_gdbarch_init): Don't register deleted functions with
300         gdbarch.
301
302 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
303
304         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
305         (riscv_unwind_pc): Delete.
306         (riscv_unwind_sp): Delete.
307         (riscv_gdbarch_init): Don't register deleted functions with
308         gdbarch.
309
310 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
311
312         * gdb/csky-tdep.c (csky_dummy_id): Delete.
313         (csky_unwind_pc): Delete.
314         (csky_unwind_sp): Delete.
315         (csky_gdbarch_init): Don't register deleted functions with
316         gdbarch.
317
318 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
319
320         * gdb/cris-tdep.c (cris_dummy_id): Delete.
321         (cris_unwind_pc): Delete.
322         (cris_unwind_sp): Delete.
323         (cris_gdbarch_init): Don't register deleted functions with
324         gdbarch.
325
326 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
327
328         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
329         (bfin_unwind_pc): Delete.
330         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
331
332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
333
334         * gdb/arm-tdep.c (arm_dummy_id): Delete.
335         (arm_unwind_pc): Delete.
336         (arm_unwind_sp): Delete.
337         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
338
339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
340
341         * gdb/arc-tdep.c (arc_dummy_id): Delete.
342         (arc_unwind_pc): Delete.
343         (arc_unwind_sp): Delete.
344         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
345
346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
347
348         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
349         (alpha_unwind_pc): Delete.
350         (alpha_gdbarch_init): Don't register deleted functions with
351         gdbarch.
352
353 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
354
355         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
356         (aarch64_unwind_pc): Delete.
357         (aarch64_unwind_sp): Delete.
358         (aarch64_gdbarch_init): Don't register deleted functions with
359         gdbarch.
360
361 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
362
363         * gdbtypes.c (type_align): Don't consider static members when
364         computing structure alignment.
365
366 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
367
368         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
369         return 0 for other types.
370         * arch-utils.c (default_type_align): Always return 0.
371         * gdbarch.h: Regenerate.
372         * gdbarch.sh (type_align): Extend comment.
373         * gdbtypes.c (type_align): Add additional comments, always call
374         gdbarch_type_align before applying the default rules.
375         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
376         generic code will then apply a suitable default.
377         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
378         types, return 0 for other types.
379
380 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
381
382         * NEWS: Create a new section for the next release branch.
383         Rename the section of the current branch, now that it has
384         been cut.
385
386 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
387
388         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
389         * version.in: Bump version to 8.3.50.DATE-git.
390
391 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
392
393         * aix-thread.c (ptid_cmp): Remove unused variable.
394         (get_signaled_thread): Likewise.
395         (store_regs_user_thread): Likewise.
396         (store_regs_kernel_thread): Likewise.
397         (fetch_regs_kernel_thread): Remove shadowed variable.
398
399 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
400
401         * features/riscv/32bit-cpu.xml: Add register numbers.
402         * features/riscv/32bit-fpu.c: Regenerate.
403         * features/riscv/32bit-fpu.xml: Add register numbers.
404         * features/riscv/64bit-cpu.xml: Add register numbers.
405         * features/riscv/64bit-fpu.c: Regenerate.
406         * features/riscv/64bit-fpu.xml: Add register numbers.
407
408 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
409
410         * NEWS: Mention two argument form of gdb.Value constructor.
411         * python/py-value.c (convert_buffer_and_type_to_value): New
412         function.
413         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
414         Add support for handling an optional second argument.  Call
415         convert_buffer_and_type_to_value as appropriate.
416         * python/python-internal.h (Py_buffer_deleter): New struct.
417         (Py_buffer_up): New typedef.
418
419 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
420
421         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
422         instead of releasing ownership.
423
424 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
425
426         * dwarf2read.c (open_and_init_dwp_file): Call
427         elf_numsections instead of bfd_count_sections to initialize
428         dwp_file->num_sections.
429
430 2019-02-25  Tom Tromey  <tromey@adacore.com>
431
432         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
433
434 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
435
436         * gcore.in: Add '--readnever' option when invoking GDB.
437
438 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
439
440         * MAINTAINERS: Update my email address.
441
442 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
443
444         * build-id.c (build_id_to_debug_bfd_1): New function.
445         (build_id_to_debug_bfd): Look for separate debug file in
446         sysroot.
447
448 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
449
450         * gdbarch.sh: Update the copyright year range that is placed into
451         generated files.
452
453 2019-02-22  Keith Seitz  <keiths@redhat.com>
454
455         PR symtab/23853
456         * linespec.c (create_sals_line_offset): Search for the default
457         symtab's filename instead of its fullname.
458
459 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
460
461         * NEWS: Update style defaults.
462
463 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
464
465         * main.c (captured_main_1): Disable styling in batch mode.
466
467 2019-02-20  Tom Tromey  <tom@tromey.com>
468
469         * symtab.c (symtab_symbol_info): Fix typos.
470
471 2019-02-20  Tom Tromey  <tromey@adacore.com>
472
473         * findcmd.c (_initialize_mem_search): Use upper case for
474         metasyntactic variables.
475
476 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
477
478         * aarch64-tdep.c (aarch64_add_reggroups): New function.
479         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
480
481 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
482
483         * top.h (source_file_name): Change to std::string.
484         * top.c (source_file_name): Likewise.
485         (command_line_input): Adjust.
486         * cli/cli-script.c (script_from_file): Adjust.
487
488 2019-02-19  Tom Tromey  <tromey@adacore.com>
489
490         * ravenscar-thread.c
491         (ravenscar_thread_target::update_thread_list): Don't call
492         ada_build_task_list.
493         * ada-lang.h (ada_build_task_list): Don't declare.
494         * ada-tasks.c (struct ada_tasks_inferior_data)
495         <task_list_valid_p>: Now bool.
496         (read_known_tasks, ada_task_list_changed)
497         (ada_tasks_invalidate_inferior_data): Update.
498         (read_known_tasks_array): Return bool.
499         (read_known_tasks_list): Likewise.
500         (read_known_tasks): Return void.
501         (ada_build_task_list): Now static.
502
503 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
504
505         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
506         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
507
508 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
509
510         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
511         variant for ada_tasks_pspace_data_handle and
512         ada_tasks_inferior_data_handle.
513         (ada_tasks_pspace_data_cleanup): New function.
514         (ada_tasks_inferior_data_cleanup): New function.
515
516 2019-02-17  Tom Tromey  <tom@tromey.com>
517
518         * macrotab.h (macro_source_fullname): Return a std::string.
519         * macrotab.c (macro_include, check_for_redefinition)
520         (macro_undef, macro_lookup_definition, foreach_macro)
521         (foreach_macro_in_scope): Update.
522         (macro_source_fullname): Return a std::string.
523         * macrocmd.c (show_pp_source_pos): Update.
524
525 2019-02-17  Tom Tromey  <tom@tromey.com>
526
527         * macrocmd.c (show_pp_source_pos): Style the file names.
528
529 2019-02-17  Tom Tromey  <tom@tromey.com>
530
531         PR tui/24197:
532         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
533
534 2019-02-17  Tom Tromey  <tom@tromey.com>
535
536         * ada-lang.c (user_select_syms): Use filtered printing.
537         * utils.c (wrap_style): New global.
538         (desired_style): Remove.
539         (emit_style_escape): Add stream parameter.
540         (set_output_style, reset_terminal_style, prompt_for_continue):
541         Update.
542         (flush_wrap_buffer): Only flush gdb_stdout.
543         (wrap_here): Set wrap_style.
544         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
545         treat escape sequences as a character.  Change when wrap buffer is
546         flushed.
547         (fputs_styled): Do not set the output style when the default is
548         requested.
549         * ui-style.h (struct ui_file_style) <is_default>: New method.
550         * source.c (print_source_lines_base): Emit escape sequences in one
551         piece.
552
553 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
554
555         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
556         integers and enumeration types.
557
558 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
559
560         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
561         instead of lookup_symbol_in_language
562         (do_exact_match): New function.
563         (ada_get_symbol_name_matcher): Return do_exact_match when
564         doing a verbatim match.
565
566 2019-02-15  Tom Tromey  <tromey@adacore.com>
567
568         * ravenscar-thread.c (ravenscar_thread_target::resume)
569         (ravenscar_thread_target::wait): Special case wildcard requests.
570
571 2019-02-15  Tom Tromey  <tromey@adacore.com>
572
573         * ravenscar-thread.c (base_ptid): Remove.
574         (struct ravenscar_thread_target) <close>: New method.
575         <m_base_ptid>: New member.
576         <update_inferior_ptid, active_task, task_is_currently_active,
577         runtime_initialized>: Declare methods.
578         <ravenscar_thread_target>: Add constructor.
579         (ravenscar_thread_target::task_is_currently_active)
580         (ravenscar_thread_target::update_inferior_ptid)
581         (ravenscar_runtime_initialized): Rename.  Now methods.
582         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
583         (ravenscar_thread_target::update_thread_list): Update.
584         (ravenscar_thread_target::active_task): Now method.
585         (ravenscar_thread_target::store_registers)
586         (ravenscar_thread_target::prepare_to_store)
587         (ravenscar_thread_target::prepare_to_store)
588         (ravenscar_thread_target::mourn_inferior): Update.
589         (ravenscar_inferior_created): Use "new" to create target.
590         (ravenscar_thread_target::get_ada_task_ptid): Update.
591         (_initialize_ravenscar): Don't initialize base_ptid.
592         (ravenscar_ops): Remove global.
593
594 2019-02-15  Tom Tromey  <tromey@adacore.com>
595
596         * target.h (push_target): Declare new overload.
597         * target.c (push_target): New overload, taking an rvalue reference.
598         * remote.c (remote_target::open_1): Use push_target overload.
599         * corelow.c (core_target_open): Use push_target overload.
600
601 2019-02-15  Tom Tromey  <tromey@adacore.com>
602
603         * ravenscar-thread.c (is_ravenscar_task)
604         (ravenscar_task_is_currently_active): Return bool.
605         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
606         (_initialize_ravenscar): Remove "(void)".
607         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
608         Return bool.
609
610 2019-02-15  Tom Tromey  <tromey@adacore.com>
611
612         * ravenscar-thread.c (ravenscar_runtime_initializer)
613         (has_ravenscar_runtime, get_running_thread_id)
614         (ravenscar_thread_target::resume): Fix indentation.
615
616 2019-02-15  Tom Tromey  <tromey@adacore.com>
617
618         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
619         from ravenscar_arch_ops.
620         (sparc_ravenscar_ops::fetch_registers)
621         (sparc_ravenscar_ops::store_registers): Now methods.
622         (sparc_ravenscar_prepare_to_store): Remove.
623         (sparc_ravenscar_ops): Redefine.
624         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
625         methods and destructor.  Remove members.
626         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
627         (ravenscar_thread_target::store_registers)
628         (ravenscar_thread_target::prepare_to_store): Update.
629         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
630         Remove.
631         (struct ppc_ravenscar_powerpc_ops): Derive from
632         ravenscar_arch_ops.
633         (ppc_ravenscar_powerpc_ops::fetch_registers)
634         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
635         (ppc_ravenscar_powerpc_ops): Redefine.
636         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
637         (ppc_ravenscar_e500_ops::fetch_registers)
638         (ppc_ravenscar_e500_ops::store_registers): Now methods.
639         (ppc_ravenscar_e500_ops): Redefine.
640         * aarch64-ravenscar-thread.c
641         (aarch64_ravenscar_generic_prepare_to_store): Remove.
642         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
643         (aarch64_ravenscar_fetch_registers)
644         (aarch64_ravenscar_store_registers): Now methods.
645         (aarch64_ravenscar_ops): Redefine.
646
647 2019-02-15  Tom Tromey  <tromey@adacore.com>
648
649         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
650         (ravenscar_thread_target::stopped_by_hw_breakpoint)
651         (ravenscar_thread_target::stopped_by_watchpoint)
652         (ravenscar_thread_target::stopped_data_address)
653         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
654
655 2019-02-15  Tom Tromey  <tromey@adacore.com>
656
657         * ravenscar-thread.c: Fix some typos.
658
659 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
660             Tom Tromey  <tromey@adacore.com>
661
662         * ada-lang.c (ada_exception_sal): Change addr_string to a
663         std::string.
664         (create_ada_exception_catchpoint): Update.
665
666 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
667             Tom Tromey  <tromey@adacore.com>
668
669         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
670         (bp_location_ops): Remove.
671         (base_breakpoint_allocate_location): Update.
672         (free_bp_location): Update.
673         * ada-lang.c (class ada_catchpoint_location)
674         <ada_catchpoint_location>: Remove ops parameter.
675         (ada_catchpoint_location_dtor): Remove.
676         (ada_catchpoint_location_ops): Remove.
677         (allocate_location_exception): Update.
678         * breakpoint.h (struct bp_location_ops): Remove.
679         (class bp_location) <bp_location>: Remove bp_location_ops
680         parameter.
681         <~bp_location>: Add destructor.
682         <ops>: Remove.
683
684 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
685             Pedro Alves  <palves@redhat.com>
686
687         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
688         'PATH_MAX'.
689
690 2019-02-14  David Michael  <fedora.dm0@gmail.com>
691             Samuel Thibault  <samuel.thibault@gnu.org>
692             Thomas Schwinge  <thomas@codesourcery.com>
693
694         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
695         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
696
697 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
698
699         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
700         (check_empty): Use "const char *".
701
702         * gnu-nat.c (gnu_nat_target::detach): Instead of
703         'detach_inferior (pid)' call
704         'detach_inferior (find_inferior_pid (pid))'.
705
706         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
707         'nat/fork-inferior.o'.
708         * gnu-nat.c: #include "nat/fork-inferior.h".
709
710         * gnu-nat.c (gnu_nat_target::detach): Instead of
711         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
712         * gnu-nat.h: #include "inf-child.h".
713         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
714         'i386_gnu_nat_target::fetch_registers'.
715         (gnu_store_registers): Rename/move to
716         'i386_gnu_nat_target::store_registers'.
717
718         * config/i386/nm-i386gnu.h: Don't "#include" any files.
719         * gnu-nat.h (mach_thread_info): New function.
720         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
721
722         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
723
724 2019-02-14  Frederic Konrad  <konrad@adacore.com>
725
726         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
727
728 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
729
730         * windows-nat.c (windows_add_thread): Add new parameter
731         "main_thread_p" with default value set to false.  Update
732         function documentation as well as all callers.
733         (windows_delete_thread): Likewise.
734         (fake_create_process): Update call to windows_add_thread.
735         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
736         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
737         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
738         call to windows_delete_thread.
739
740 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
741
742         * MAINTAINERS: Add Andrew Burgess as global maintainer.
743
744 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
745
746         * symfile.c (find_separate_debug_file): Use canonical path of
747         sysroot with child_path instead of gdb_sysroot if it is valid.
748
749 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
750
751         * symfile.c (find_separate_debug_file): Use child_path to
752         determine if an object file is under a sysroot.
753
754 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
755
756         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
757         unittests/child-path-selftests.c.
758         * common/pathstuff.c (child_path): New function.
759         * common/pathstuff.h (child_path): New prototype.
760         * unittests/child-path-selftests.c: New file.
761
762 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
763
764         * symfile.c (find_separate_debug_file): Look for separate debug
765         files in debug directories under the sysroot.
766
767 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
768
769         * symtab.h (struct minimal_symbol data_p): New const method.
770         (struct minimal_symbol text_p): Likewise.
771         * symtab.c (output_source_filename): Use file name style
772         to print file name.
773         (print_symbol_info): Likewise.
774         (print_msymbol_info): Use address style to print addresses.
775         Use function name style to print executable text symbols.
776         (expand_symtab_containing_pc): Use data_p.
777         (find_pc_sect_compunit_symtab): Likewise.
778
779 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
780
781         * breakpoint.c (describe_other_breakpoints): Use address style
782         to print addresses.
783         (say_where): Likewise.
784
785 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
786
787         * ada-typeprint.c (print_func_type): Print function name
788         style to print function name.
789         * c-typeprint.c (c_print_type_1): Likewise.
790
791 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
792
793         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
794         for execve.
795
796 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
797
798         * c-exp.y (direct_abs_decl): Use emplace_back to record the
799         type_stack.
800
801 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
802
803         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
804         TYPE_CODE_REF types.
805
806 2019-02-08  Jim Wilson  <jimw@sifive.com>
807
808         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
809         (riscv_linux_fregset): New.
810         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
811
812 2019-02-07  Tom Tromey  <tom@tromey.com>
813
814         * thread.c (thread_cancel_execution_command): Update.
815         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
816         methods.
817         (struct thread_fsm_ops): Remove.
818         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
819         (thread_fsm_should_stop, thread_fsm_return_value)
820         (thread_fsm_set_finished, thread_fsm_finished_p)
821         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
822         Don't declare.
823         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
824         * infrun.c (clear_proceed_status_thread)
825         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
826         (print_stop_event): Update.
827         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
828         Add constructor.
829         (step_command_fsm_ops): Remove.
830         (new_step_command_fsm): Remove.
831         (step_1): Update.
832         (step_command_fsm::should_stop): Rename from
833         step_command_fsm_should_stop.
834         (step_command_fsm::clean_up): Rename from
835         step_command_fsm_clean_up.
836         (step_command_fsm::do_async_reply_reason): Rename from
837         step_command_fsm_async_reply_reason.
838         (struct until_next_fsm): Inherit from thread_fsm.  Add
839         constructor.
840         (until_next_fsm_ops): Remove.
841         (new_until_next_fsm): Remove.
842         (until_next_fsm::should_stop): Rename from
843         until_next_fsm_should_stop.
844         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
845         (until_next_fsm::do_async_reply_reason): Rename from
846         until_next_fsm_async_reply_reason.
847         (struct finish_command_fsm): Inherit from thread_fsm.  Add
848         constructor.  Change type of breakpoint.
849         (finish_command_fsm_ops): Remove.
850         (new_finish_command_fsm): Remove.
851         (finish_command_fsm::should_stop): Rename from
852         finish_command_fsm_should_stop.
853         (finish_command_fsm::clean_up): Rename from
854         finish_command_fsm_clean_up.
855         (finish_command_fsm::return_value): Rename from
856         finish_command_fsm_return_value.
857         (finish_command_fsm::do_async_reply_reason): Rename from
858         finish_command_fsm_async_reply_reason.
859         (finish_command): Update.
860         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
861         Add constructor.
862         (call_thread_fsm_ops): Remove.
863         (call_thread_fsm::call_thread_fsm): Rename from
864         new_call_thread_fsm.
865         (call_thread_fsm::should_stop): Rename from
866         call_thread_fsm_should_stop.
867         (call_thread_fsm::should_notify_stop): Rename from
868         call_thread_fsm_should_notify_stop.
869         (run_inferior_call, call_function_by_hand_dummy): Update.
870         * cli/cli-interp.c (should_print_stop_to_console): Update.
871         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
872         Add constructor.  Change type of location_breakpoint,
873         caller_breakpoint.
874         (until_break_fsm_ops): Remove.
875         (new_until_break_fsm): Remove.
876         (until_break_fsm::should_stop): Rename from
877         until_break_fsm_should_stop.
878         (until_break_fsm::clean_up): Rename from
879         until_break_fsm_clean_up.
880         (until_break_fsm::do_async_reply_reason): Rename from
881         until_break_fsm_async_reply_reason.
882         (until_break_command): Update.
883         * thread-fsm.c: Remove.
884         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
885
886 2019-02-07  Tom Tromey  <tom@tromey.com>
887
888         * yy-remap.h: Add include guard.
889         * xtensa-tdep.h: Add include guard.
890         * xcoffread.h: Rename include guard.
891         * varobj-iter.h: Add include guard.
892         * tui/tui.h: Rename include guard.
893         * tui/tui-winsource.h: Rename include guard.
894         * tui/tui-wingeneral.h: Rename include guard.
895         * tui/tui-windata.h: Rename include guard.
896         * tui/tui-win.h: Rename include guard.
897         * tui/tui-stack.h: Rename include guard.
898         * tui/tui-source.h: Rename include guard.
899         * tui/tui-regs.h: Rename include guard.
900         * tui/tui-out.h: Rename include guard.
901         * tui/tui-layout.h: Rename include guard.
902         * tui/tui-io.h: Rename include guard.
903         * tui/tui-hooks.h: Rename include guard.
904         * tui/tui-file.h: Rename include guard.
905         * tui/tui-disasm.h: Rename include guard.
906         * tui/tui-data.h: Rename include guard.
907         * tui/tui-command.h: Rename include guard.
908         * tic6x-tdep.h: Add include guard.
909         * target/waitstatus.h: Rename include guard.
910         * target/wait.h: Rename include guard.
911         * target/target.h: Rename include guard.
912         * target/resume.h: Rename include guard.
913         * target-float.h: Rename include guard.
914         * stabsread.h: Add include guard.
915         * rs6000-tdep.h: Add include guard.
916         * riscv-fbsd-tdep.h: Add include guard.
917         * regformats/regdef.h: Rename include guard.
918         * record.h: Rename include guard.
919         * python/python.h: Rename include guard.
920         * python/python-internal.h: Rename include guard.
921         * python/py-stopevent.h: Rename include guard.
922         * python/py-ref.h: Rename include guard.
923         * python/py-record.h: Rename include guard.
924         * python/py-record-full.h: Rename include guard.
925         * python/py-record-btrace.h: Rename include guard.
926         * python/py-instruction.h: Rename include guard.
927         * python/py-events.h: Rename include guard.
928         * python/py-event.h: Rename include guard.
929         * procfs.h: Add include guard.
930         * proc-utils.h: Add include guard.
931         * p-lang.h: Add include guard.
932         * or1k-tdep.h: Rename include guard.
933         * observable.h: Rename include guard.
934         * nto-tdep.h: Rename include guard.
935         * nat/x86-linux.h: Rename include guard.
936         * nat/x86-linux-dregs.h: Rename include guard.
937         * nat/x86-gcc-cpuid.h: Add include guard.
938         * nat/x86-dregs.h: Rename include guard.
939         * nat/x86-cpuid.h: Rename include guard.
940         * nat/ppc-linux.h: Rename include guard.
941         * nat/mips-linux-watch.h: Rename include guard.
942         * nat/linux-waitpid.h: Rename include guard.
943         * nat/linux-ptrace.h: Rename include guard.
944         * nat/linux-procfs.h: Rename include guard.
945         * nat/linux-osdata.h: Rename include guard.
946         * nat/linux-nat.h: Rename include guard.
947         * nat/linux-namespaces.h: Rename include guard.
948         * nat/linux-btrace.h: Rename include guard.
949         * nat/glibc_thread_db.h: Rename include guard.
950         * nat/gdb_thread_db.h: Rename include guard.
951         * nat/gdb_ptrace.h: Rename include guard.
952         * nat/fork-inferior.h: Rename include guard.
953         * nat/amd64-linux-siginfo.h: Rename include guard.
954         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
955         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
956         * nat/aarch64-linux.h: Rename include guard.
957         * nat/aarch64-linux-hw-point.h: Rename include guard.
958         * mn10300-tdep.h: Add include guard.
959         * mips-linux-tdep.h: Add include guard.
960         * mi/mi-parse.h: Rename include guard.
961         * mi/mi-out.h: Rename include guard.
962         * mi/mi-main.h: Rename include guard.
963         * mi/mi-interp.h: Rename include guard.
964         * mi/mi-getopt.h: Rename include guard.
965         * mi/mi-console.h: Rename include guard.
966         * mi/mi-common.h: Rename include guard.
967         * mi/mi-cmds.h: Rename include guard.
968         * mi/mi-cmd-break.h: Rename include guard.
969         * m2-lang.h: Add include guard.
970         * location.h: Rename include guard.
971         * linux-record.h: Rename include guard.
972         * linux-nat.h: Add include guard.
973         * linux-fork.h: Add include guard.
974         * i386-darwin-tdep.h: Rename include guard.
975         * hppa-linux-offsets.h: Add include guard.
976         * guile/guile.h: Rename include guard.
977         * guile/guile-internal.h: Rename include guard.
978         * gnu-nat.h: Rename include guard.
979         * gdb-stabs.h: Rename include guard.
980         * frv-tdep.h: Add include guard.
981         * f-lang.h: Add include guard.
982         * event-loop.h: Add include guard.
983         * darwin-nat.h: Rename include guard.
984         * cp-abi.h: Rename include guard.
985         * config/sparc/nm-sol2.h: Rename include guard.
986         * config/nm-nto.h: Rename include guard.
987         * config/nm-linux.h: Add include guard.
988         * config/i386/nm-i386gnu.h: Rename include guard.
989         * config/djgpp/nl_types.h: Rename include guard.
990         * config/djgpp/langinfo.h: Rename include guard.
991         * compile/gcc-cp-plugin.h: Add include guard.
992         * compile/gcc-c-plugin.h: Add include guard.
993         * compile/compile.h: Rename include guard.
994         * compile/compile-object-run.h: Rename include guard.
995         * compile/compile-object-load.h: Rename include guard.
996         * compile/compile-internal.h: Rename include guard.
997         * compile/compile-cplus.h: Rename include guard.
998         * compile/compile-c.h: Rename include guard.
999         * common/xml-utils.h: Rename include guard.
1000         * common/x86-xstate.h: Rename include guard.
1001         * common/version.h: Rename include guard.
1002         * common/vec.h: Rename include guard.
1003         * common/tdesc.h: Rename include guard.
1004         * common/selftest.h: Rename include guard.
1005         * common/scoped_restore.h: Rename include guard.
1006         * common/scoped_mmap.h: Rename include guard.
1007         * common/scoped_fd.h: Rename include guard.
1008         * common/safe-iterator.h: Rename include guard.
1009         * common/run-time-clock.h: Rename include guard.
1010         * common/refcounted-object.h: Rename include guard.
1011         * common/queue.h: Rename include guard.
1012         * common/ptid.h: Rename include guard.
1013         * common/print-utils.h: Rename include guard.
1014         * common/preprocessor.h: Rename include guard.
1015         * common/pathstuff.h: Rename include guard.
1016         * common/observable.h: Rename include guard.
1017         * common/netstuff.h: Rename include guard.
1018         * common/job-control.h: Rename include guard.
1019         * common/host-defs.h: Rename include guard.
1020         * common/gdb_wait.h: Rename include guard.
1021         * common/gdb_vecs.h: Rename include guard.
1022         * common/gdb_unlinker.h: Rename include guard.
1023         * common/gdb_unique_ptr.h: Rename include guard.
1024         * common/gdb_tilde_expand.h: Rename include guard.
1025         * common/gdb_sys_time.h: Rename include guard.
1026         * common/gdb_string_view.h: Rename include guard.
1027         * common/gdb_splay_tree.h: Rename include guard.
1028         * common/gdb_setjmp.h: Rename include guard.
1029         * common/gdb_ref_ptr.h: Rename include guard.
1030         * common/gdb_optional.h: Rename include guard.
1031         * common/gdb_locale.h: Rename include guard.
1032         * common/gdb_assert.h: Rename include guard.
1033         * common/filtered-iterator.h: Rename include guard.
1034         * common/filestuff.h: Rename include guard.
1035         * common/fileio.h: Rename include guard.
1036         * common/environ.h: Rename include guard.
1037         * common/common-utils.h: Rename include guard.
1038         * common/common-types.h: Rename include guard.
1039         * common/common-regcache.h: Rename include guard.
1040         * common/common-inferior.h: Rename include guard.
1041         * common/common-gdbthread.h: Rename include guard.
1042         * common/common-exceptions.h: Rename include guard.
1043         * common/common-defs.h: Rename include guard.
1044         * common/common-debug.h: Rename include guard.
1045         * common/cleanups.h: Rename include guard.
1046         * common/buffer.h: Rename include guard.
1047         * common/btrace-common.h: Rename include guard.
1048         * common/break-common.h: Rename include guard.
1049         * cli/cli-utils.h: Rename include guard.
1050         * cli/cli-style.h: Rename include guard.
1051         * cli/cli-setshow.h: Rename include guard.
1052         * cli/cli-script.h: Rename include guard.
1053         * cli/cli-interp.h: Rename include guard.
1054         * cli/cli-decode.h: Rename include guard.
1055         * cli/cli-cmds.h: Rename include guard.
1056         * charset-list.h: Add include guard.
1057         * buildsym-legacy.h: Rename include guard.
1058         * bfin-tdep.h: Add include guard.
1059         * ax.h: Rename include guard.
1060         * arm-linux-tdep.h: Add include guard.
1061         * arm-fbsd-tdep.h: Add include guard.
1062         * arch/xtensa.h: Rename include guard.
1063         * arch/tic6x.h: Add include guard.
1064         * arch/i386.h: Add include guard.
1065         * arch/arm.h: Rename include guard.
1066         * arch/arm-linux.h: Rename include guard.
1067         * arch/arm-get-next-pcs.h: Rename include guard.
1068         * arch/amd64.h: Add include guard.
1069         * arch/aarch64-insn.h: Rename include guard.
1070         * arch-utils.h: Rename include guard.
1071         * annotate.h: Add include guard.
1072         * amd64-darwin-tdep.h: Rename include guard.
1073         * aarch64-linux-tdep.h: Add include guard.
1074         * aarch64-fbsd-tdep.h: Add include guard.
1075         * aarch32-linux-nat.h: Add include guard.
1076
1077 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1078
1079         * macrotab.c (macro_define_internal): New function that
1080         factorizes macro_define_object_internal and macro_define_function
1081         code.
1082         (macro_define_object_internal): Use macro_define_internal.
1083         (macro_define_function): Likewise.
1084
1085 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1086
1087         * macrocmd.c (extract_identifier): Return
1088         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1089         callers.
1090
1091 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1092
1093         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1094
1095 2019-02-05  Tom Tromey  <tom@tromey.com>
1096
1097         * target.c (target_stack::unpush): Move assertion earlier.
1098
1099 2019-01-30  Tom Tromey  <tom@tromey.com>
1100
1101         PR python/23615:
1102         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1103         (gdbpy_parse_and_eval): Likewise.
1104         * python/python-internal.h (gdbpy_allow_threads): New class.
1105
1106 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1107
1108         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1109         (aarch64_fbsd_fpregmap): Move earlier.
1110         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1111         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1112         instead of individual calls to trad_frame_set_reg_addr.
1113         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1114         earlier.
1115         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1116         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1117         instead of individual calls to trad_frame_set_reg_addr.
1118
1119 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1120
1121         * CONTRIBUTE: Replace contribution list with wiki link.
1122
1123 2019-01-25  Tom Tromey  <tom@tromey.com>
1124
1125         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1126
1127 2019-01-25  Tom Tromey  <tom@tromey.com>
1128
1129         * xtensa-linux-nat.c: Fix common/ includes.
1130         * xml-support.h: Fix common/ includes.
1131         * xml-support.c: Fix common/ includes.
1132         * x86-linux-nat.c: Fix common/ includes.
1133         * windows-nat.c: Fix common/ includes.
1134         * varobj.h: Fix common/ includes.
1135         * varobj.c: Fix common/ includes.
1136         * value.c: Fix common/ includes.
1137         * valops.c: Fix common/ includes.
1138         * utils.c: Fix common/ includes.
1139         * unittests/xml-utils-selftests.c: Fix common/ includes.
1140         * unittests/utils-selftests.c: Fix common/ includes.
1141         * unittests/unpack-selftests.c: Fix common/ includes.
1142         * unittests/tracepoint-selftests.c: Fix common/ includes.
1143         * unittests/style-selftests.c: Fix common/ includes.
1144         * unittests/string_view-selftests.c: Fix common/ includes.
1145         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1146         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1147         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1148         * unittests/rsp-low-selftests.c: Fix common/ includes.
1149         * unittests/parse-connection-spec-selftests.c: Fix common/
1150         includes.
1151         * unittests/optional-selftests.c: Fix common/ includes.
1152         * unittests/offset-type-selftests.c: Fix common/ includes.
1153         * unittests/observable-selftests.c: Fix common/ includes.
1154         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1155         * unittests/memrange-selftests.c: Fix common/ includes.
1156         * unittests/memory-map-selftests.c: Fix common/ includes.
1157         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1158         * unittests/function-view-selftests.c: Fix common/ includes.
1159         * unittests/environ-selftests.c: Fix common/ includes.
1160         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1161         * unittests/common-utils-selftests.c: Fix common/ includes.
1162         * unittests/cli-utils-selftests.c: Fix common/ includes.
1163         * unittests/array-view-selftests.c: Fix common/ includes.
1164         * ui-file.c: Fix common/ includes.
1165         * tui/tui-io.c: Fix common/ includes.
1166         * tracepoint.h: Fix common/ includes.
1167         * tracepoint.c: Fix common/ includes.
1168         * tracefile-tfile.c: Fix common/ includes.
1169         * top.h: Fix common/ includes.
1170         * top.c: Fix common/ includes.
1171         * thread.c: Fix common/ includes.
1172         * target/waitstatus.h: Fix common/ includes.
1173         * target/waitstatus.c: Fix common/ includes.
1174         * target.h: Fix common/ includes.
1175         * target.c: Fix common/ includes.
1176         * target-memory.c: Fix common/ includes.
1177         * target-descriptions.c: Fix common/ includes.
1178         * symtab.h: Fix common/ includes.
1179         * symfile.c: Fix common/ includes.
1180         * stap-probe.c: Fix common/ includes.
1181         * spu-linux-nat.c: Fix common/ includes.
1182         * sparc-nat.c: Fix common/ includes.
1183         * source.c: Fix common/ includes.
1184         * solib.c: Fix common/ includes.
1185         * solib-target.c: Fix common/ includes.
1186         * ser-unix.c: Fix common/ includes.
1187         * ser-tcp.c: Fix common/ includes.
1188         * ser-pipe.c: Fix common/ includes.
1189         * ser-base.c: Fix common/ includes.
1190         * selftest-arch.c: Fix common/ includes.
1191         * s12z-tdep.c: Fix common/ includes.
1192         * rust-exp.y: Fix common/ includes.
1193         * rs6000-aix-tdep.c: Fix common/ includes.
1194         * riscv-tdep.c: Fix common/ includes.
1195         * remote.c: Fix common/ includes.
1196         * remote-notif.h: Fix common/ includes.
1197         * remote-fileio.h: Fix common/ includes.
1198         * remote-fileio.c: Fix common/ includes.
1199         * regcache.h: Fix common/ includes.
1200         * regcache.c: Fix common/ includes.
1201         * record-btrace.c: Fix common/ includes.
1202         * python/python.c: Fix common/ includes.
1203         * python/py-type.c: Fix common/ includes.
1204         * python/py-inferior.c: Fix common/ includes.
1205         * progspace.h: Fix common/ includes.
1206         * producer.c: Fix common/ includes.
1207         * procfs.c: Fix common/ includes.
1208         * proc-api.c: Fix common/ includes.
1209         * printcmd.c: Fix common/ includes.
1210         * ppc-linux-nat.c: Fix common/ includes.
1211         * parser-defs.h: Fix common/ includes.
1212         * osdata.c: Fix common/ includes.
1213         * obsd-nat.c: Fix common/ includes.
1214         * nat/x86-linux.c: Fix common/ includes.
1215         * nat/x86-linux-dregs.c: Fix common/ includes.
1216         * nat/x86-dregs.h: Fix common/ includes.
1217         * nat/x86-dregs.c: Fix common/ includes.
1218         * nat/ppc-linux.c: Fix common/ includes.
1219         * nat/mips-linux-watch.h: Fix common/ includes.
1220         * nat/mips-linux-watch.c: Fix common/ includes.
1221         * nat/linux-waitpid.c: Fix common/ includes.
1222         * nat/linux-ptrace.h: Fix common/ includes.
1223         * nat/linux-ptrace.c: Fix common/ includes.
1224         * nat/linux-procfs.c: Fix common/ includes.
1225         * nat/linux-personality.c: Fix common/ includes.
1226         * nat/linux-osdata.c: Fix common/ includes.
1227         * nat/linux-namespaces.c: Fix common/ includes.
1228         * nat/linux-btrace.h: Fix common/ includes.
1229         * nat/linux-btrace.c: Fix common/ includes.
1230         * nat/fork-inferior.c: Fix common/ includes.
1231         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1232         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1233         * nat/aarch64-linux.c: Fix common/ includes.
1234         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1235         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1236         * namespace.h: Fix common/ includes.
1237         * mips-linux-tdep.c: Fix common/ includes.
1238         * minsyms.c: Fix common/ includes.
1239         * mi/mi-parse.h: Fix common/ includes.
1240         * mi/mi-main.c: Fix common/ includes.
1241         * mi/mi-cmd-env.c: Fix common/ includes.
1242         * memrange.h: Fix common/ includes.
1243         * memattr.c: Fix common/ includes.
1244         * maint.h: Fix common/ includes.
1245         * maint.c: Fix common/ includes.
1246         * main.c: Fix common/ includes.
1247         * machoread.c: Fix common/ includes.
1248         * location.c: Fix common/ includes.
1249         * linux-thread-db.c: Fix common/ includes.
1250         * linux-nat.c: Fix common/ includes.
1251         * linux-fork.c: Fix common/ includes.
1252         * inline-frame.c: Fix common/ includes.
1253         * infrun.c: Fix common/ includes.
1254         * inflow.c: Fix common/ includes.
1255         * inferior.h: Fix common/ includes.
1256         * inferior.c: Fix common/ includes.
1257         * infcmd.c: Fix common/ includes.
1258         * inf-ptrace.c: Fix common/ includes.
1259         * inf-child.c: Fix common/ includes.
1260         * ia64-linux-nat.c: Fix common/ includes.
1261         * i387-tdep.c: Fix common/ includes.
1262         * i386-tdep.c: Fix common/ includes.
1263         * i386-linux-tdep.c: Fix common/ includes.
1264         * i386-linux-nat.c: Fix common/ includes.
1265         * i386-go32-tdep.c: Fix common/ includes.
1266         * i386-fbsd-tdep.c: Fix common/ includes.
1267         * i386-fbsd-nat.c: Fix common/ includes.
1268         * guile/scm-type.c: Fix common/ includes.
1269         * guile/guile.c: Fix common/ includes.
1270         * go32-nat.c: Fix common/ includes.
1271         * gnu-nat.c: Fix common/ includes.
1272         * gdbthread.h: Fix common/ includes.
1273         * gdbarch-selftests.c: Fix common/ includes.
1274         * gdb_usleep.c: Fix common/ includes.
1275         * gdb_select.h: Fix common/ includes.
1276         * gdb_bfd.c: Fix common/ includes.
1277         * gcore.c: Fix common/ includes.
1278         * fork-child.c: Fix common/ includes.
1279         * findvar.c: Fix common/ includes.
1280         * fbsd-nat.c: Fix common/ includes.
1281         * event-top.c: Fix common/ includes.
1282         * event-loop.c: Fix common/ includes.
1283         * dwarf2read.c: Fix common/ includes.
1284         * dwarf2loc.c: Fix common/ includes.
1285         * dwarf2-frame.c: Fix common/ includes.
1286         * dwarf-index-cache.c: Fix common/ includes.
1287         * dtrace-probe.c: Fix common/ includes.
1288         * disasm-selftests.c: Fix common/ includes.
1289         * defs.h: Fix common/ includes.
1290         * csky-tdep.c: Fix common/ includes.
1291         * cp-valprint.c: Fix common/ includes.
1292         * cp-support.h: Fix common/ includes.
1293         * cp-support.c: Fix common/ includes.
1294         * corelow.c: Fix common/ includes.
1295         * completer.h: Fix common/ includes.
1296         * completer.c: Fix common/ includes.
1297         * compile/compile.c: Fix common/ includes.
1298         * compile/compile-loc2c.c: Fix common/ includes.
1299         * compile/compile-cplus-types.c: Fix common/ includes.
1300         * compile/compile-cplus-symbols.c: Fix common/ includes.
1301         * command.h: Fix common/ includes.
1302         * cli/cli-dump.c: Fix common/ includes.
1303         * cli/cli-cmds.c: Fix common/ includes.
1304         * charset.c: Fix common/ includes.
1305         * build-id.c: Fix common/ includes.
1306         * btrace.h: Fix common/ includes.
1307         * btrace.c: Fix common/ includes.
1308         * breakpoint.h: Fix common/ includes.
1309         * breakpoint.c: Fix common/ includes.
1310         * ax.h: 
1311         (enum agent_op): Fix common/ includes.
1312         * ax-general.c (struct aop_map): Fix common/ includes.
1313         * ax-gdb.c: Fix common/ includes.
1314         * auxv.c: Fix common/ includes.
1315         * auto-load.c: Fix common/ includes.
1316         * arm-tdep.c: Fix common/ includes.
1317         * arch/riscv.c: Fix common/ includes.
1318         * arch/ppc-linux-common.c: Fix common/ includes.
1319         * arch/i386.c: Fix common/ includes.
1320         * arch/arm.c: Fix common/ includes.
1321         * arch/arm-linux.c: Fix common/ includes.
1322         * arch/arm-get-next-pcs.c: Fix common/ includes.
1323         * arch/amd64.c: Fix common/ includes.
1324         * arch/aarch64.c: Fix common/ includes.
1325         * arch/aarch64-insn.c: Fix common/ includes.
1326         * arch-utils.c: Fix common/ includes.
1327         * amd64-windows-tdep.c: Fix common/ includes.
1328         * amd64-tdep.c: Fix common/ includes.
1329         * amd64-sol2-tdep.c: Fix common/ includes.
1330         * amd64-obsd-tdep.c: Fix common/ includes.
1331         * amd64-nbsd-tdep.c: Fix common/ includes.
1332         * amd64-linux-tdep.c: Fix common/ includes.
1333         * amd64-linux-nat.c: Fix common/ includes.
1334         * amd64-fbsd-tdep.c: Fix common/ includes.
1335         * amd64-fbsd-nat.c: Fix common/ includes.
1336         * amd64-dicos-tdep.c: Fix common/ includes.
1337         * amd64-darwin-tdep.c: Fix common/ includes.
1338         * agent.c: Fix common/ includes.
1339         * ada-lang.h: Fix common/ includes.
1340         * ada-lang.c: Fix common/ includes.
1341         * aarch64-tdep.c: Fix common/ includes.
1342
1343 2019-01-25  Tom Tromey  <tom@tromey.com>
1344
1345         * common/create-version.sh: Use common/version.h.
1346
1347 2019-01-24  Pedro Alves  <palves@redhat.com>
1348
1349         * infrun.c (signal_stop, signal_print, signal_program)
1350         (signal_catch, signal_pass): Now arrays instead of pointers.
1351         (update_signals_program_target, do_target_resume)
1352         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1353         * linux-nat.c (linux_nat_target::pass_signals)
1354         (linux_nat_target::create_inferior, linux_nat_target::attach):
1355         Adjust.
1356         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1357         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1358         * procfs.c (procfs_target::pass_signals): Adjust.
1359         * record-full.c (record_full_target::resume): Adjust.
1360         * remote.c (remote_target::pass_signals)
1361         (remote_target::program_signals): Adjust.
1362         * target-debug.h (target_debug_print_signals): Now takes a
1363         gdb::array_view as parameter.  Adjust.
1364         * target.h (target_ops) <pass_signals, program_signals>: Replace
1365         pointer and length parameters with gdb::array_view.
1366         (target_pass_signals, target_program_signals): Likewise.
1367         * target-delegates.c: Regenerate.
1368
1369 2019-01-24  Pedro Alves  <palves@redhat.com>
1370
1371         * common/forward-scope-exit.h
1372         (forward_scope_exit::forward_scope_exit): Pass arguments to
1373         m_bind_function directly, instead of creating a std::bind and
1374         copying that.
1375
1376 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1377
1378         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1379         for static members.
1380         (pass_in_v_vfp_candidate): Likewise.
1381
1382 2019-01-23  Tom Tromey  <tom@tromey.com>
1383             Pedro Alves  <palves@redhat.com>
1384
1385         * regcache.c (class regcache_invalidator): Remove.
1386         (regcache::raw_write): Use make_scope_exit.
1387
1388 2019-01-23  Tom Tromey  <tom@tromey.com>
1389
1390         * ui-out.h (class ui_out_emit_type): Update comment.
1391
1392 2019-01-23  Tom Tromey  <tom@tromey.com>
1393
1394         * infrun.c (fetch_inferior_event): Update comment.
1395
1396 2019-01-23  Tom Tromey  <tom@tromey.com>
1397             Pedro Alves  <palves@redhat.com>
1398
1399         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1400         parameter.
1401         (fetch_inferior_event): Use SCOPE_EXIT.
1402
1403
1404 2019-01-23  Tom Tromey  <tom@tromey.com>
1405             Pedro Alves  <palves@redhat.com>
1406
1407         * infrun.c (disable_thread_events): Delete.
1408         (stop_all_threads): Use SCOPE_EXIT.
1409
1410 2019-01-23  Tom Tromey  <tom@tromey.com>
1411             Pedro Alves  <palves@redhat.com>
1412
1413         * symfile.c: Include forward-scope-exit.h.
1414         (clear_symtab_users_cleanup): Replace forward declaration with
1415         a FORWARD_SCOPE_EXIT.
1416         (syms_from_objfile_1): Use the forward_scope_exit and
1417         gdb::optional instead of cleanup_function.
1418         (reread_symbols): Use the forward_scope_exit instead of
1419         cleanup_function.
1420         (clear_symtab_users_cleanup): Remove function.
1421
1422 2019-01-23  Tom Tromey  <tom@tromey.com>
1423             Pedro Alves  <palves@redhat.com>
1424
1425         * linux-nat.c: Include scope-exit.h.
1426         (cleanup_target_stop): Remove.
1427         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1428         SCOPE_EXIT.
1429
1430 2019-01-23  Tom Tromey  <tom@tromey.com>
1431             Pedro Alves  <palves@redhat.com>
1432
1433         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1434         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1435
1436 2019-01-23  Tom Tromey  <tom@tromey.com>
1437             Andrew Burgess  <andrew.burgess@embecosm.com>
1438             Pedro Alves  <palves@redhat.com>
1439
1440         * infrun.c (fetch_inferior_event): Use scope_exit.
1441         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1442         * top.c (execute_command): Use scope_exit.
1443         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1444         * utils.c (do_bpstat_clear_actions_cleanup)
1445         (make_bpstat_clear_actions_cleanup): Remove.
1446
1447 2019-01-23  Tom Tromey  <tom@tromey.com>
1448             Pedro Alves  <palves@redhat.com>
1449
1450         * infrun.c: Include "common/scope-exit.h"
1451         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1452         (wait_for_inferior): Use SCOPE_EXIT.
1453         (fetch_inferior_event): Use scope_exit.
1454
1455 2019-01-23  Tom Tromey  <tom@tromey.com>
1456             Pedro Alves  <palves@redhat.com>
1457
1458         * breakpoint.c (create_breakpoint): Remove cleanup.
1459
1460 2019-01-23  Tom Tromey  <tom@tromey.com>
1461             Andrew Burgess  <andrew.burgess@embecosm.com>
1462             Pedro Alves  <palves@redhat.com>
1463
1464 2019-01-23  Pedro Alves  <palves@redhat.com>
1465
1466         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1467
1468 2019-01-23  Pedro Alves  <palves@redhat.com>
1469             Andrew Burgess  <andrew.burgess@embecosm.com>
1470
1471         * gdbthread.h: Include "common/forward-scope-exit.h".
1472         (scoped_finish_thread_state): Redefine custom class in terms of
1473         forward_scope_exit.
1474
1475 2019-01-23  Pedro Alves  <palves@redhat.com>
1476             Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * common/forward-scope-exit.h: New file.
1479
1480 2019-01-23  Pedro Alves  <palves@redhat.com>
1481             Andrew Burgess  <andrew.burgess@embecosm.com>
1482             Tom Tromey  <tom@tromey.com>
1483
1484         * common/scope-exit.h: New file.
1485
1486 2019-01-23  Pedro Alves  <palves@redhat.com>
1487
1488         * common/preprocessor.h (ESC): Rename to ...
1489         (ESC_PARENS): ... this.
1490         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1491         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1492
1493 2019-01-23  Tom Tromey  <tom@tromey.com>
1494
1495         * language.h (class scoped_switch_to_sym_language_if_auto):
1496         Initialize m_lang in both cases.
1497
1498 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1499
1500         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1501         with XCNEW.
1502
1503 2019-01-22  Tom Tromey  <tom@tromey.com>
1504
1505         * corelow.c: Do not include sys/file.h.
1506
1507 2019-01-22  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-wingeneral.h: Include gdb_curses.h.
1510
1511 2019-01-22  Tom Tromey  <tom@tromey.com>
1512
1513         * source-cache.h (class source_cache) <get_source_lines,
1514         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1515
1516 2019-01-22  Tom Tromey  <tom@tromey.com>
1517
1518         * remote-fileio.h (struct remote_target): Declare.
1519
1520 2019-01-22  Tom Tromey  <tom@tromey.com>
1521
1522         * python/py-arch.c: Do not include py-ref.h.
1523         * python/py-bpevent.c: Do not include py-ref.h.
1524         * python/py-cmd.c: Do not include py-ref.h.
1525         * python/py-continueevent.c: Do not include py-ref.h.
1526         * python/py-event.h: Do not include py-ref.h.
1527         * python/py-evtregistry.c: Do not include py-ref.h.
1528         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1529         * python/py-frame.c: Do not include py-ref.h.
1530         * python/py-framefilter.c: Do not include py-ref.h.
1531         * python/py-function.c: Do not include py-ref.h.
1532         * python/py-infevents.c: Do not include py-ref.h.
1533         * python/py-linetable.c: Do not include py-ref.h.
1534         * python/py-objfile.c: Do not include py-ref.h.
1535         * python/py-param.c: Do not include py-ref.h.
1536         * python/py-prettyprint.c: Do not include py-ref.h.
1537         * python/py-progspace.c: Do not include py-ref.h.
1538         * python/py-symbol.c: Do not include py-ref.h.
1539         * python/py-symtab.c: Do not include py-ref.h.
1540         * python/py-type.c: Do not include py-ref.h.
1541         * python/py-unwind.c: Do not include py-ref.h.
1542         * python/py-utils.c: Do not include py-ref.h.
1543         * python/py-value.c: Do not include py-ref.h.
1544         * python/py-varobj.c: Do not include py-ref.h.
1545         * python/py-xmethods.c: Do not include py-ref.h.
1546         * python/python.c: Do not include py-ref.h.
1547         * varobj.c: Do not include py-ref.h.
1548
1549 2019-01-22  Tom Tromey  <tom@tromey.com>
1550
1551         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1552         keyword for bcache.
1553
1554 2019-01-22  Tom Tromey  <tom@tromey.com>
1555
1556         * compile/compile-cplus-types.c: Remove a comment by #include.
1557
1558 2019-01-22  Tom Tromey  <tom@tromey.com>
1559
1560         * compile/gcc-c-plugin.h: Include compile-internal.h.
1561
1562 2019-01-22  Tom Tromey  <tom@tromey.com>
1563
1564         * stabsread.c (EXTERN): Do not define.
1565         (symnum, next_symbol_text_func, processing_gcc_compilation)
1566         (within_function, global_sym_chain, global_stabs)
1567         (previous_stab_code, this_object_header_files)
1568         (n_this_object_header_files)
1569         (n_allocated_this_object_header_files): Define.
1570         * stabsread.h (EXTERN): Never define.  Use "extern".
1571
1572 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1573
1574         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1575         history_value.
1576
1577 2019-01-21  Tom Tromey  <tom@tromey.com>
1578
1579         * ui-out.c: Fix includes.
1580         * tui/tui-source.c: Fix includes.
1581         * target.c: Fix includes.
1582         * remote.c: Fix includes.
1583         * regcache.c: Fix includes.
1584         * python/py-block.c: Fix includes.
1585         * printcmd.c: Fix includes.
1586         * or1k-tdep.c: Fix includes.
1587         * mi/mi-main.c: Fix includes.
1588         * m32r-tdep.c: Fix includes.
1589         * csky-tdep.c: Fix includes.
1590         * compile/compile-cplus-types.c: Fix includes.
1591         * cli/cli-interp.c: Fix includes.
1592
1593 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1594
1595         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1596         for padding.
1597
1598 2019-01-16  Tom Tromey  <tom@tromey.com>
1599
1600         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1601         earlier.
1602         (struct objfile) <msymbols_range>: Move from top level.
1603         <msymbols>: New method.
1604         (class objfile_msymbols): Remove.
1605         * symtab.c (default_collect_symbol_completion_matches_break_on):
1606         Update.
1607         * symmisc.c (dump_msymbols): Update.
1608         * stabsread.c (scan_file_globals): Update.
1609         * objc-lang.c (info_selectors_command, info_classes_command)
1610         (find_methods): Update.
1611         * minsyms.c (find_solib_trampoline_target): Update.
1612         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1613         * coffread.c (coff_symfile_read): Update.
1614         * ada-lang.c (ada_lookup_simple_minsym)
1615         (ada_collect_symbol_completion_matches): Update.
1616
1617 2019-01-16  Tom Tromey  <tom@tromey.com>
1618
1619         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1620         type.  Remove no-argument constructor.
1621         <iterator::operator++>: Simplify.
1622         <begin>: Update.
1623         <end>: Use minimal_symbol_count.
1624
1625 2019-01-16  Tom Tromey  <tom@tromey.com>
1626
1627         * objfiles.h (struct objfile) <psymtabs>: New method.
1628         (class objfile_psymtabs): Remove.
1629         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1630         typedef.
1631         <range>: New method.
1632         (require_partial_symbols): Change return type.
1633         * psymtab.c (require_partial_symbols)
1634         (psym_expand_symtabs_matching): Update.
1635         * mdebugread.c (parse_partial_symbols): Update.
1636         * dbxread.c (dbx_end_psymtab): Update.
1637
1638 2019-01-15  Tom Tromey  <tom@tromey.com>
1639
1640         * symtab.c (lookup_objfile_from_block)
1641         (lookup_symbol_in_objfile_symtabs)
1642         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1643         (find_line_symtab, info_sources_command)
1644         (default_collect_symbol_completion_matches_break_on)
1645         (make_source_files_completion_list): Update.
1646         * symmisc.c (print_objfile_statistics, dump_objfile)
1647         (maintenance_print_symbols, maintenance_info_symtabs)
1648         (maintenance_check_symtabs, maintenance_info_line_tables):
1649         Update.
1650         * source.c (select_source_symtab)
1651         (forget_cached_source_info_for_objfile): Update.
1652         * objfiles.h (class objfile_compunits): Remove.
1653         (struct objfile) <compunits_range>: New typedef.
1654         (compunits): New method.
1655         * objfiles.c (objfile_relocate1): Update.
1656         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1657         * maint.c (count_symtabs_and_blocks): Update.
1658         * linespec.c (iterate_over_all_matching_symtabs): Update.
1659         * cp-support.c (add_symbol_overload_list_qualified): Update.
1660         * coffread.c (coff_symtab_read): Update.
1661         * ada-lang.c (add_nonlocal_symbols)
1662         (ada_collect_symbol_completion_matches)
1663         (ada_add_global_exceptions): Update.
1664
1665 2019-01-15  Tom Tromey  <tom@tromey.com>
1666
1667         * progspace.h (program_space) <objfiles_safe_range>: New
1668         typedef.
1669         <objfiles_safe>: New method.
1670         * objfiles.h (class all_objfiles_safe): Remove.
1671         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1672         * jit.c (jit_inferior_exit_hook): Update.
1673
1674 2019-01-17  Tom Tromey  <tom@tromey.com>
1675
1676         * progspace.h (program_space) <objfiles_range>: New typedef.
1677         <objfiles>: New method.
1678         <objfiles_head>: Rename from objfiles.
1679         (object_files): Update.
1680         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1681         * guile/scm-pretty-print.c
1682         (ppscm_find_pretty_printer_from_objfiles): Update.
1683         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1684         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1685         Update.
1686         * python/py-progspace.c (pspy_get_objfiles): Update.
1687         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1688         Update.
1689         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1690         (objfpy_lookup_objfile_by_build_id): Update.
1691         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1692         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1693         Update.
1694         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1695         (expand_symtab_containing_pc, lookup_objfile_from_block)
1696         (lookup_static_symbol, basic_lookup_transparent_type)
1697         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1698         (find_line_symtab, info_sources_command)
1699         (default_collect_symbol_completion_matches_break_on)
1700         (make_source_files_completion_list, find_main_name): Update.
1701         * symmisc.c (print_symbol_bcache_statistics)
1702         (print_objfile_statistics, maintenance_print_symbols)
1703         (maintenance_print_msymbols, maintenance_print_objfiles)
1704         (maintenance_info_symtabs, maintenance_check_symtabs)
1705         (maintenance_expand_symtabs, maintenance_info_line_tables):
1706         Update.
1707         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1708         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1709         (map_overlay_command, unmap_overlay_command)
1710         (simple_overlay_update, expand_symtabs_matching)
1711         (map_symbol_filenames): Update.
1712         * symfile-debug.c (set_debug_symfile): Update.
1713         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1714         Update.
1715         * source.c (select_source_symtab, forget_cached_source_info):
1716         Update.
1717         * solib.c (solib_read_symbols): Update.
1718         * solib-spu.c (append_ocl_sos): Update.
1719         * psymtab.c (maintenance_print_psymbols)
1720         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1721         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1722         * printcmd.c (info_symbol_command): Update.
1723         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1724         Update.
1725         * objfiles.h (class all_objfiles): Remove.
1726         * objfiles.c (have_partial_symbols, have_full_symbols)
1727         (have_minimal_symbols, qsort_cmp, update_section_map)
1728         (shared_objfile_contains_address_p)
1729         (default_iterate_over_objfiles_in_search_order): Update.
1730         * objc-lang.c (info_selectors_command, info_classes_command)
1731         (find_methods): Update.
1732         * minsyms.c (find_solib_trampoline_target): Update.
1733         * maint.c (maintenance_info_sections)
1734         (maintenance_translate_address, count_symtabs_and_blocks):
1735         Update.
1736         * main.c (captured_main_1): Update.
1737         * linux-thread-db.c (try_thread_db_load_from_pdir)
1738         (has_libpthread): Update.
1739         * linespec.c (iterate_over_all_matching_symtabs)
1740         (search_minsyms_for_name): Update.
1741         * jit.c (jit_find_objf_with_entry_addr): Update.
1742         * hppa-tdep.c (find_unwind_entry)
1743         (hppa_lookup_stub_minimal_symbol): Update.
1744         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1745         Update.
1746         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1747         (elf_gnu_ifunc_resolve_by_got): Update.
1748         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1749         * dwarf-index-write.c (save_gdb_index_command): Update.
1750         * cp-support.c (add_symbol_overload_list_qualified): Update.
1751         * breakpoint.c (create_overlay_event_breakpoint)
1752         (create_longjmp_master_breakpoint)
1753         (create_std_terminate_master_breakpoint)
1754         (create_exception_master_breakpoint): Update.
1755         * blockframe.c (find_pc_partial_function): Update.
1756         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1757         (ada_collect_symbol_completion_matches)
1758         (ada_add_global_exceptions): Update.
1759
1760 2019-01-17  Tom Tromey  <tom@tromey.com>
1761
1762         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1763         declare VEC.
1764         (solib_target_parse_libraries): Change return type.
1765         (library_list_start_segment, library_list_start_section)
1766         (library_list_end_library, library_list_start_library); Update.
1767         (solib_target_free_library_list): Remove.
1768         (solib_target_parse_libraries): Remove cleanup.  Change return
1769         type.
1770         (solib_target_current_sos): Update.
1771
1772 2019-01-17  Tom Tromey  <tromey@bapiya>
1773
1774         * valprint.c: Replace "the the" with "the".
1775         * symtab.c: Replace "the the" with "the".
1776         * solib.c: Replace "the the" with "the".
1777         * solib-dsbt.c: Replace "the the" with "the".
1778         * linespec.c: Replace "the the" with "the".
1779         * dwarf2loc.h: Replace "the the" with "the".
1780         * amd64-windows-tdep.c: Replace "the the" with "the".
1781         * aarch64-tdep.c: Replace "the the" with "the".
1782
1783 2019-01-16  Keith Seitz  <keiths@redhat.com>
1784
1785         PR gdb/23773
1786         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1787         <builder>: Rename to ..
1788         <m_builder>: ... this and make private.
1789         (dwarf2_cu::get_builder): New method.  Change all users of
1790         `builder' to use this method.
1791         (dwarf2_start_symtab): Move to ...
1792         (dwarf2_cu::start_symtab): ... here.  Update all callers
1793         (setup_type_unit_groups): Move to ...
1794         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1795         callers.
1796         (dwarf2_cu::reset_builder): New method.
1797         (process_full_compunit, process_full_type_unit): Use
1798         dwarf2_cu::reset_builder.
1799         (follow_die_offset): Record the ancestor CU if it is different
1800         from the followed DIE's CU.
1801         (follow_die_sig_1): Likewise.
1802
1803 2019-01-15  Tom Tromey  <tom@tromey.com>
1804
1805         * remote.c (class remote_state) <buf>: Now a char_vector.
1806         <buf_size>: Remove.
1807         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1808         parameter.
1809         (remote_target::getpkt_or_notif_sane_1)
1810         (remote_target::getpkt_sane)
1811         (remote_target::getpkt_or_notif_sane): Likewise.
1812         (class remote_target) <putpkt>: New overload.
1813         (remote_target::read_frame): Change type of "buf_p".  Remove
1814         sizeof_p parameter.
1815         (packet_ok): New overload.
1816         (packet_check_result): New overload.
1817         Update all uses.
1818
1819 2019-01-14  Tom Tromey  <tom@tromey.com>
1820
1821         * remote-notif.c (handle_notification, remote_notif_ack)
1822         (remote_notif_parse): Make "buf" const.
1823         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1824         const.
1825         (remote_notif_parse, remote_notif_ack, handle_notification):
1826         Likewise.
1827         * remote.c (remote_notif_stop_parse): Make "buf" const.
1828         (remote_target::remote_parse_stop_reply): Make "buf" const.
1829         (remote_notif_stop_ack): Make "buf" const.
1830
1831 2019-01-14  Tom Tromey  <tom@tromey.com>
1832
1833         * remote.c (remote_console_output): Make parameter const.
1834
1835 2019-01-14  Tom Tromey  <tom@tromey.com>
1836
1837         * target-debug.h (target_debug_print_signals): Constify.
1838         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1839         * procfs.c (procfs_target::pass_signals): Update.
1840         * linux-nat.c (linux_nat_target::pass_signals): Update.
1841         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1842         * target-delegates.c: Rebuild.
1843         * remote.c (remote_target::program_signals): Update.
1844         (remote_target::pass_signals): Update.
1845         * target.c (target_pass_signals): Constify argument.
1846         (target_program_signals): Likewise.
1847         * target.h (struct target_ops) <pass_signals, program_signals>:
1848         Constify argument.
1849         (target_pass_signals, target_program_signals): Constify argument.
1850
1851 2019-01-14  Tom Tromey  <tom@tromey.com>
1852
1853         PR tui/28819:
1854         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1855
1856 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1857
1858         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1859         field.
1860         * rs6000-tdep.c: Include reggroups.h.
1861         (IS_V_ALIAS_PSEUDOREG): Define.
1862         (rs6000_register_name): Return names for the "vX" aliases.
1863         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1864         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1865         aliases.  Call default_register_reggroup_p for all other
1866         pseudo-registers.
1867         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1868         New functions.
1869         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1870         Handle "vX" aliases.
1871         (v_alias_pseudo_register_collect): New function.
1872         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1873         (rs6000_gdbarch_init): Initialize "vX" aliases as
1874         pseudo-registers.  Restore registration of
1875         rs6000_pseudo_register_reggroup_p with
1876         set_tdesc_pseudo_register_reggroup_p.
1877
1878 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1879
1880         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1881         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1882         set_gdbarch_num_pseudo_regs.
1883
1884 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1885
1886         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1887         Remove arg prefixname, add do_set and do_show.
1888         Add member functions set_list and show_list.
1889         * cli/cli-style.c (class cli_style_option): Update accordingly.
1890         (style_set_list): Move to file scope.
1891         (style_show_list): Likewise.
1892         (set_style): Call help_list.
1893         (show_style): Call cmd_show_list.
1894         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1895         Update to use the new macro.
1896
1897 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1898
1899         * ada-lang.c (_initialize_ada_language): Expand the help text
1900         for the "catch exception" command.
1901
1902 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1903
1904         * symtab.c (matching_obj_sections): Initialize obj,
1905         declare it closer to its usage.
1906
1907 2019-01-10  Tom Tromey  <tom@tromey.com>
1908
1909         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1910         (basic_inf_threads_range): Remove.
1911         (inf_threads_range, inf_non_exited_threads_range)
1912         (safe_inf_threads_range): Use next_adapter.
1913
1914 2019-01-10  Keith Seitz  <keiths@redhat.com>
1915
1916         PR gdb/23712
1917         PR symtab/23010
1918         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1919         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1920
1921 2019-01-10  Keith Seitz  <keiths@redhat.com>
1922
1923         PR gdb/23712
1924         PR symtab/23010
1925         * dictionary.c (pending_to_vector): Remove.
1926         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1927         Remove _1 suffix, replacing functions of the same name.  Update
1928         all callers.
1929         (dict_create_hashed, dict_create_hashed_expandable)
1930         (dict_create_linear, dict_create_linear_expandable, dict_free)
1931         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1932         Make functions static.
1933
1934 2019-01-10  Keith Seitz  <keiths@redhat.com>
1935
1936         PR gdb/23712
1937         PR symtab/23010
1938         * dictionary.h (struct dictionary): Replace declaration with
1939         multidictionary.
1940         (dict_create_hashed, dict_create_hashed_expandable)
1941         (dict_create_linear, dict_create_linear_expandable)
1942         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1943         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1944         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1945         taking multidictionary argument.
1946         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1947         * block.h (struct block) <dict>: Change to multidictionary
1948         and rename `multidict'.
1949         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1950         symmisc.c: Update all dictionary references to multidictionary.
1951
1952 2019-01-10  Keith Seitz  <keiths@redhat.com>
1953
1954         PR gdb/23712
1955         PR symtab/23010
1956         * dictionary.c: Include unordered_map.
1957         (pending_to_vector): New function.
1958         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1959         Rewrite the non-"_1" functions to take vector instead
1960         of linked list.
1961         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1962         "new" _1 versions of the same name.
1963         (multidictionary): Define.
1964         (std::hash<enum language): New definition.
1965         (collate_pending_symbols_by_language, mdict_create_hashed)
1966         (mdict_create_hashed_expandable, mdict_create_linear)
1967         (mdict_create_linear_expandable, mdict_free)
1968         (find_language_dictionary, create_new_language_dictionary)
1969         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1970         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1971         (mdict_size, mdict_empty): New functions.
1972         * dictionary.h (mdict_iterator): Define.
1973
1974 2019-01-10  Pedro Alves  <palves@redhat.com>
1975
1976         * breakpoint.c (read_uploaded_action)
1977         (create_tracepoint_from_upload): Adjust to use
1978         gdb::unique_xmalloc_ptr.
1979         * ctf.c (ctf_write_uploaded_tp):
1980         (SET_ARRAY_FIELD): Use emplace_back.
1981         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1982         * tracefile-tfile.c (tfile_write_uploaded_tp):
1983         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1984         gdb::unique_xmalloc_ptr.
1985         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1986         at_string, cond_string, cmd_strings>: Replace char pointers
1987         with gdb::unique_xmalloc_ptr.
1988
1989 2019-01-10  Pedro Alves  <palves@redhat.com>
1990
1991         * solib-target.c (library_list_start_library): Don't xstrdup name.
1992
1993 2019-01-10  Pedro Alves  <palves@redhat.com>
1994
1995         * mdebugread.c (parse_partial_symbols): Use
1996         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1997
1998 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * linux-fork.c (scoped_switch_fork_info)
2001         <~scoped_switch_fork_info>: Fix incorrect variable name.
2002
2003 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * linux-fork.c (scoped_switch_fork_info)
2006         <scoped_switch_fork_info>: Make explicit.
2007         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2008
2009 2019-01-10  Tom Tromey  <tom@tromey.com>
2010
2011         * objfiles.h (objfile::reset_psymtabs): Update.
2012         * objfiles.c (objfile::objfile): Update.
2013         * psymtab.h (psymtab_storage::obstack): Update.
2014         (psymtab_storage::m_obstack): Use gdb::optional.
2015         (class psymtab_storage): Update comment.  Remove objfile
2016         parameter.
2017         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2018
2019 2019-01-10  Tom Tromey  <tom@tromey.com>
2020
2021         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2022         <free_psymtabs>: Now private.
2023         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2024         (allocate_psymtab): Use new method.
2025
2026 2019-01-10  Tom Tromey  <tom@tromey.com>
2027
2028         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2029         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2030         * mdebugread.c (parse_partial_symbols): Use
2031         allocate_dependencies.
2032         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2033         allocate_dependencies.
2034         (process_psymtab_comp_unit_reader)
2035         (build_type_psymtab_dependencies): Likewise.
2036         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2037
2038 2019-01-10  Tom Tromey  <tom@tromey.com>
2039
2040         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2041         PSYMBOL_SET_LANGUAGE.
2042         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2043
2044 2019-01-10  Tom Tromey  <tom@tromey.com>
2045
2046         * psymtab.h (psymtab_storage::obstack): New method.
2047         <m_obstack>: Rename from obstack; now private.
2048         * psymtab.c (psymtab_storage): Update.
2049         * dwarf2read.c (create_addrmap_from_index)
2050         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2051         Update.
2052
2053 2019-01-10  Tom Tromey  <tom@tromey.com>
2054
2055         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2056         * objfiles.h (objfile::reset_psymtabs): New method.
2057
2058 2019-01-10  Tom Tromey  <tom@tromey.com>
2059
2060         * symmisc.c (print_symbol_bcache_statistics): Update.
2061         (print_objfile_statistics): Update.
2062         * symfile.c (reread_symbols): Update.
2063         * psymtab.h (class psymtab_storage): New.
2064         * psymtab.c (psymtab_storage): New constructor.
2065         (~psymtab_storage): New destructor.
2066         (require_partial_symbols): Update.
2067         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2068         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2069         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2070         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2071         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2072         (start_psymtab_common, end_psymtab_common)
2073         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2074         (allocate_psymtab): Update.
2075         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2076         Update.
2077         (dump_psymtab_addrmap, maintenance_print_psymbols)
2078         (maintenance_check_psymtabs): Update.
2079         (class objfile_psymtabs): Move to objfiles.h.
2080         * psympriv.h (discard_psymtab): Now inline.
2081         (psymtab_discarder::psymtab_discarder): Update.
2082         (psymtab_discarder::~psymtab_discarder): Update.
2083         (ALL_OBJFILE_PSYMTABS): Rewrite.
2084         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2085         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2086         Remove fields.
2087         <partial_symtabs>: New field.
2088         (class objfile_psymtabs): Move from psymtab.h.  Update.
2089         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2090         psymbol_cache.
2091         (objfile::~objfile): Don't destroy psymbol_cache.
2092         * mdebugread.c (parse_partial_symbols): Update.
2093         * dwarf2read.c (create_addrmap_from_index)
2094         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2095         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2096         (add_partial_subprogram, dwarf2_ranges_read): Update.
2097         * dwarf-index-write.c (write_address_map)
2098         (write_one_signatured_type, recursively_write_psymbols)
2099         (class debug_names, class debug_names, write_psymtabs_to_index):
2100         Update.
2101
2102 2019-01-10  Tom Tromey  <tom@tromey.com>
2103
2104         * symtab.h (SYMBOL_SET_NAMES): Update.
2105         (symbol_set_names): Update.
2106         (MSYMBOL_SET_NAMES): Update.
2107         * symtab.c (symbol_set_names): Change argument to be an
2108         objfile_per_bfd_storage.
2109         * psymtab.c (add_psymbol_to_bcache): Update.
2110         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2111
2112 2019-01-10  Tom Tromey  <tom@tromey.com>
2113
2114         * symtab.c (create_demangled_names_hash): Change argument to be an
2115         objfile_per_bfd_storage.
2116         (symbol_set_names): Update.
2117
2118 2019-01-10  Tom Tromey  <tom@tromey.com>
2119
2120         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2121         init_psymbol_list.
2122         * psymtab.c (init_psymbol_list): Do nothing if already called.
2123         * psympriv.h (init_psymbol_list): Add comment.
2124         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2125         init_psymbol_list.
2126         * dbxread.c (dbx_symfile_read): Unconditionally call
2127         init_psymbol_list.
2128
2129 2019-01-10  Tom Tromey  <tom@tromey.com>
2130
2131         * xcoffread.c (scan_xcoff_symtab): Update.
2132         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2133         "where".
2134         * mdebugread.c (parse_partial_symbols)
2135         (handle_psymbol_enumerators): Update.
2136         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2137         * dbxread.c (read_dbx_symtab): Update.
2138         * psympriv.h (psymbol_placement): New enum.
2139         (add_psymbol_to_list): Update.
2140
2141 2019-01-10  Tom Tromey  <tom@tromey.com>
2142
2143         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2144         static_psymbols parameters.
2145         (scan_xcoff_symtab): Update.
2146         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2147         static_psymbols parameters.
2148         * psympriv.h (start_psymtab_common): Update.
2149         * mdebugread.c (parse_partial_symbols): Update.
2150         * dwarf2read.c (create_partial_symtab): Update.
2151         * dbxread.c (read_dbx_symtab): Update.
2152         (start_psymtab): Remove global_psymbols and static_psymbols
2153         parameters.
2154
2155 2019-01-10  Tom Tromey  <tom@tromey.com>
2156
2157         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2158         * psymtab.c (allocate_psymtab): Add comment.
2159         * psympriv.h (allocate_psymtab): Add comment.
2160         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2161         initializations.
2162         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2163
2164 2019-01-10  Tom Tromey  <tom@tromey.com>
2165
2166         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2167         Don't declare.
2168         * mipsread.c: Include mdebugread.h.
2169         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2170         Declare.
2171         * elfread.c: Include mdebugread.h.
2172
2173 2019-01-09  Tom Tromey  <tom@tromey.com>
2174
2175         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2176         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2177         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2178         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2179         (psym_lookup_symbol, psym_find_last_source_symtab)
2180         (psym_forget_cached_source_info, psym_print_stats)
2181         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2182         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2183         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2184         (psym_find_compunit_symtab_by_address)
2185         (maintenance_print_psymbols, maintenance_info_psymtabs)
2186         (maintenance_check_psymtabs): Use ranged for.
2187         * psymtab.h (class objfile_psymtabs): New.
2188         (require_partial_symbols): Return objfile_psymtabs.
2189         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2190
2191 2019-01-09  Tom Tromey  <tom@tromey.com>
2192
2193         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2194         (find_pc_mapped_section, list_overlays_command)
2195         (map_overlay_command, unmap_overlay_command)
2196         (simple_overlay_update): Use all_objfiles.
2197         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2198         * printcmd.c (info_symbol_command): Use all_objfiles.
2199         * objfiles.h (ALL_OBJSECTIONS): Remove.
2200         * maint.c (maintenance_translate_address): Use all_objfiles.
2201         * gcore.c (gcore_create_callback): Use all_objfiles.
2202         (objfile_find_memory_regions): Likewise.
2203
2204 2019-01-09  Tom Tromey  <tom@tromey.com>
2205
2206         * symtab.c (find_line_symtab, info_sources_command)
2207         (make_source_files_completion_list): Use objfile_compunits.
2208         * source.c (select_source_symtab): Use objfile_compunits.
2209         * objfiles.h (struct objfile): Update comment.
2210         (ALL_OBJFILES): Remove.
2211         (ALL_FILETABS): Remove.
2212         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2213         objfile_compunits.
2214
2215 2019-01-09  Tom Tromey  <tom@tromey.com>
2216
2217         * symmisc.c (print_objfile_statistics, dump_objfile)
2218         (maintenance_print_symbols): Use compunit_filetabs.
2219         * source.c (forget_cached_source_info_for_objfile): Use
2220         compunit_filetabs.
2221         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2222         (ALL_FILETABS): Use compunit_filetabs.
2223         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2224         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2225
2226 2019-01-09  Tom Tromey  <tom@tromey.com>
2227
2228         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2229         (compunit_filetabs): New.
2230         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2231         compunit_filetabs.
2232         (info_sources_command, make_source_files_completion_list): Remove
2233         declaration.
2234         * symmisc.c (print_objfile_statistics, dump_objfile)
2235         (maintenance_print_symbols): Remove declaration.
2236         (maintenance_info_symtabs): Use compunit_filetabs.
2237         (maintenance_info_line_tables): Likewise.
2238         * source.c (select_source_symtab): Change local variable name.
2239         (forget_cached_source_info_for_objfile): Remove declaration.
2240         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2241         * objfiles.c (objfile_relocate1): Remove declaration.
2242         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2243         declaration.
2244         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2245         * coffread.c (coff_symtab_read): Remove declaration.
2246         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2247         compunit_filetabs.
2248
2249 2019-01-09  Tom Tromey  <tom@tromey.com>
2250
2251         * symtab.c (lookup_objfile_from_block)
2252         (find_pc_sect_compunit_symtab, search_symbols)
2253         (default_collect_symbol_completion_matches_break_on): Use
2254         objfile_compunits.
2255         * objfiles.h (ALL_COMPUNITS): Remove.
2256         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2257         * cp-support.c (add_symbol_overload_list_qualified): Use
2258         objfile_compunits.
2259         * ada-lang.c (ada_collect_symbol_completion_matches)
2260         (ada_add_global_exceptions): Use objfile_compunits.
2261
2262 2019-01-09  Tom Tromey  <tom@tromey.com>
2263
2264         * source.c (select_source_symtab)
2265         (forget_cached_source_info_for_objfile): Remove declaration.
2266         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2267         declaration.
2268         * maint.c (count_symtabs_and_blocks): Remove declaration.
2269         * cp-support.c (add_symbol_overload_list_qualified): Remove
2270         declaration.
2271         * coffread.c (coff_symtab_read): Remove declaration.
2272         * symtab.c (lookup_symbol_in_objfile_symtabs)
2273         (basic_lookup_transparent_type_1): Use objfile_compunits.
2274         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2275         (info_sources_command, search_symbols)
2276         (default_collect_symbol_completion_matches_break_on)
2277         (make_source_files_completion_list): Remove declaration.
2278         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2279         (ada_collect_symbol_completion_matches)
2280         (ada_add_global_exceptions): Remove declaration.
2281         * linespec.c (iterate_over_all_matching_symtabs): Use
2282         objfile_compunits.
2283         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2284         (class objfile_compunits): New.
2285         (ALL_COMPUNITS): Use objfile_compunits.
2286         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2287         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2288         objfile_compunits.
2289         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2290
2291 2019-01-09  Tom Tromey  <tom@tromey.com>
2292
2293         * symtab.c (search_symbols)
2294         (default_collect_symbol_completion_matches_break_on): Use
2295         objfile_msymbols.
2296         * ada-lang.c (ada_lookup_simple_minsym)
2297         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2298         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2299         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2300         objfile_msymbols.
2301         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2302         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2303         * objc-lang.c (find_methods): Use objfile_msymbols.
2304         (info_selectors_command, info_classes_command): Likewise.
2305         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2306         * objfiles.h (class objfile_msymbols): New.
2307         (ALL_OBJFILE_MSYMBOLS): Remove.
2308         (ALL_MSYMBOLS): Remove.
2309
2310 2019-01-09  Tom Tromey  <tom@tromey.com>
2311
2312         * common/next-iterator.h (next_adapter): Add Iterator template
2313         parameter.
2314         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2315         (class all_objfiles_safe): New.
2316         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2317         * objfiles.c (put_objfile_before): Update comment.
2318         (add_separate_debug_objfile): Likewise.
2319         (free_all_objfiles): Use all_objfiles_safe.
2320         (objfile_purge_solibs): Likewise.
2321
2322 2019-01-09  Tom Tromey  <tom@tromey.com>
2323
2324         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2325         (expand_symtab_containing_pc, lookup_static_symbol)
2326         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2327         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2328         all_objfiles.
2329         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2330         * breakpoint.c (create_overlay_event_breakpoint)
2331         (create_longjmp_master_breakpoint)
2332         (create_std_terminate_master_breakpoint)
2333         (create_exception_master_breakpoint): Use all_objfiles.
2334         * linux-thread-db.c (try_thread_db_load_from_pdir)
2335         (has_libpthread): Use all_objfiles.
2336         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2337         * linespec.c (iterate_over_all_matching_symtabs)
2338         (search_minsyms_for_name): Use all_objfiles.
2339         * maint.c (maintenance_info_sections): Use all_objfiles.
2340         * main.c (captured_main_1): Use all_objfiles.
2341         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2342         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2343         * guile/scm-pretty-print.c
2344         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2345         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2346         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2347         (maintenance_print_msymbols): Use all_objfiles.
2348         * source.c (select_source_symtab): Use all_objfiles.
2349         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2350         * symfile.c (remove_symbol_file_command)
2351         (expand_symtabs_matching, map_symbol_filenames): Use
2352         all_objfiles.
2353         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2354         all_objfiles.
2355         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2356         * objc-lang.c (find_methods): Use all_objfiles.
2357         * objfiles.c (have_partial_symbols, have_full_symbols)
2358         (have_minimal_symbols, qsort_cmp)
2359         (default_iterate_over_objfiles_in_search_order): Use
2360         all_objfiles.
2361         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2362         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2363         (maintenance_check_psymtabs): Use all_objfiles.
2364         (ALL_PSYMTABS): Remove.
2365         * compile/compile-object-run.c (do_module_cleanup): Use
2366         all_objfiles.
2367         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2368         * cp-support.c (add_symbol_overload_list_qualified): Use
2369         all_objfiles.
2370         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2371         Use all_objfiles.
2372         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2373         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2374         all_objfiles.
2375         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2376         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2377         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2378         Uses all_objfiles.
2379         * solib.c (solib_read_symbols): Use all_objfiles
2380
2381 2019-01-09  Tom Tromey  <tom@tromey.com>
2382
2383         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2384         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2385         all_objfiles.
2386         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2387         * symmisc.c (print_symbol_bcache_statistics)
2388         (print_objfile_statistics, maintenance_print_objfiles)
2389         (maintenance_info_symtabs, maintenance_check_symtabs)
2390         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2391         all_objfiles.
2392         * source.c (forget_cached_source_info): Use all_objfiles.
2393         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2394         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2395         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2396         * objfiles.c (update_section_map): Use all_objfiles.
2397         (shared_objfile_contains_address_p): Likewise.
2398         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2399         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2400
2401 2019-01-09  Tom Tromey  <tom@tromey.com>
2402
2403         * common/next-iterator.h: New file.
2404         * objfiles.h (class all_objfiles): New.
2405         (struct objfile_iterator): New.
2406
2407 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2408
2409         * NEWS: Move the description of the changed "frame", "select-frame",
2410          and "info frame" commands to the Changed commands section.
2411
2412 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2413
2414         * gdbtypes.c (check_stub_method_group): Remove handling of old
2415         mangling schemes.
2416         * linespec.c (find_methods): Likewise.
2417         * stabsread.c (read_member_functions): Likewise.
2418         * valops.c (search_struct_method): Likewise.
2419         (value_struct_elt_for_reference): Likewise.
2420         * NEWS: Mention this change.
2421
2422 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2423
2424         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2425         print_source_lines.
2426         * source.c (print_source_lines_base): Update line number check.
2427         (print_source_lines): New function.
2428         (source_lines_range::source_lines_range): New function.
2429         * source.h (class source_lines_range): New class.
2430         (print_source_lines): New declaration.
2431
2432 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2433
2434         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2435
2436 2019-01-08  Tom Tromey  <tom@tromey.com>
2437             Simon Marchi  <simon.marchi@ericsson.com>
2438
2439         PR gdb/24060
2440         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2441         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2442         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2443         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2444         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2445         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2446
2447 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * source.c (select_source_symtab): Move header comment to
2450         declaration in source.h.
2451         (forget_cached_source_info_for_objfile): Likewise.
2452         (forget_cached_source_info): Likewise.
2453         (identify_source_line): Likewise.
2454         * source.h (identify_source_line): Move declaration from symtab.h
2455         and add comment from source.c
2456         (print_source_lines): Likewise.
2457         (forget_cached_source_info_for_objfile): Likewise.
2458         (forget_cached_source_info): Likewise.
2459         (select_source_symtab): Likewise.
2460         (enum print_source_lines_flag): Move definition from symtab.h.
2461         * symtab.h (identify_source_line): Move declaration to source.h.
2462         (print_source_lines): Likewise.
2463         (forget_cached_source_info_for_objfile): Likewise.
2464         (forget_cached_source_info): Likewise.
2465         (select_source_symtab): Likewise.
2466         (enum print_source_lines_flag): Move definition to source.h.
2467         * tui/tui-hooks.c: Add 'source.h' include.
2468
2469 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * source.c (print_source_lines_base): Handle requests to print
2472         reverse line number sequences, and guard against empty lines
2473         string.
2474
2475 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * source.c (print_source_lines_base): Fix skip of '\r' if next
2478         character is '\n'.
2479
2480 2019-01-06  Tom Tromey  <tom@tromey.com>
2481
2482         * c-exp.y (struct c_parse_state) <macro_original_text,
2483         expansion_obstack>: New member.
2484         (macro_original_text, expansion_obstack): Remove globals.
2485         (scan_macro_expansion, scanning_macro_expansion)
2486         (finished_macro_expansion): Update.
2487         (scan_macro_cleanup): Remove.
2488         (yylex, c_parse): Update.
2489
2490 2019-01-06  Tom Tromey  <tom@tromey.com>
2491
2492         * c-exp.y (struct c_parse_state) <strings>: New member.
2493         (operator_stoken): Update.
2494
2495 2019-01-06  Tom Tromey  <tom@tromey.com>
2496
2497         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2498         (union type_stack_elt) <typelist_val>: Now a pointer to
2499         std::vector.
2500         (type_stack_cleanup): Don't declare.
2501         (push_typelist): Update.
2502         * parse.c (pop_typelist): Return a std::vector.
2503         (push_typelist): Take a std::vector.
2504         (follow_types): Update.  Do not free args.
2505         (type_stack_cleanup): Remove.
2506         * c-exp.y (struct c_parse_state): New.
2507         (cpstate): New global.
2508         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2509         (nonempty_typelist): Update.
2510         (func_mod): Create a new vector.
2511         (c_parse): Create a c_parse_state.
2512         (check_parameter_typelist): Do not delete params.
2513         (function_method): Update.  Do not delete type_list.
2514
2515 2019-01-06  Tom Tromey  <tom@tromey.com>
2516
2517         PR gdb/28155:
2518         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2519         check_typedef.
2520         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2521         (print_return_value): Likewise.
2522
2523 2019-01-05  Tom Tromey  <tom@tromey.com>
2524
2525         * contrib/cleanup_check.py: Remove.
2526         * contrib/gcc-with-excheck: Remove.
2527         * contrib/exsummary.py: Remove.
2528         * contrib/excheck.py: Remove.
2529
2530 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2531
2532         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2533         NULL. Initialize tpprev to NULL instead of assigning it
2534         to NULL on the next statement.
2535         * windows-nat.c (windows_delete_thread): Remove check for
2536         main_thread_id before printing thread exit notifications.
2537         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2538         Remove thread ID check against main_thread_id.
2539         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2540         windows_delete_thread.
2541         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2542
2543 2019-01-04  Tom Tromey  <tom@tromey.com>
2544
2545         * compile/compile.c (_initialize_compile): Use upper case for
2546         metasyntactic variables.
2547         * symmisc.c (_initialize_symmisc): Use upper case for
2548         metasyntactic variables.
2549         * psymtab.c (_initialize_psymtab): Use upper case for
2550         metasyntactic variables.
2551         * demangle.c (demangle_command): Use upper case for metasyntactic
2552         variables.
2553         (_initialize_demangler): Likewise.
2554         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2555         variables.
2556
2557 2019-01-03  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2560
2561 2019-01-03  Tom Tromey  <tom@tromey.com>
2562
2563         * python/py-symtab.c (salpy_str): Update.
2564         (struct salpy_sal_object) <symtab>: Now a PyObject.
2565         (salpy_dealloc): Update.
2566         (del_objfile_sal): Use gdbpy_ref.
2567
2568 2019-01-03  Tom Tromey  <tom@tromey.com>
2569
2570         * python/py-type.c (convert_field): Use new_reference.  Return
2571         gdbpy_ref.
2572         (make_fielditem): Return gdbpy_ref.
2573         (typy_fields): Update.
2574         (typy_getitem): Update.
2575         (field_name): Return gdbpy_ref.  Use new_reference.
2576         (typy_iterator_iternext): Update.
2577
2578 2019-01-03  Tom Tromey  <tom@tromey.com>
2579
2580         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2581
2582 2019-01-03  Tom Tromey  <tom@tromey.com>
2583
2584         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2585         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2586         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2587         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2588         (pspy_set_type_printers): Likewise.
2589         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2590         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2591         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2592         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2593         (objfpy_set_type_printers): Likewise.
2594
2595 2019-01-03  Tom Tromey  <tom@tromey.com>
2596
2597         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2598         (gdbpy_print_stack): Use gdbpy_err_fetch.
2599         * python/python-internal.h (class gdbpy_err_fetch): New class.
2600         (class gdbpy_enter) <m_error_type, m_error_value,
2601         m_error_traceback>: Remove.
2602         <m_error>: New member.
2603         (gdbpy_exception_to_string): Don't declare.
2604         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2605         * python/py-value.c (convert_value_from_python): Use
2606         gdbpy_err_fetch.
2607         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2608         gdbpy_exception_to_string.
2609         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2610         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2611         gdbpy_err_fetch.
2612
2613 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * linux-nat.c (delete_lwp_cleanup): Delete.
2616         (struct lwp_deleter): New struct.
2617         (lwp_info_up): New typedef.
2618         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2619         lwp_info_up.
2620
2621 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2622
2623         * linux-fork.c (class scoped_switch_fork_info): New class.
2624         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2625
2626 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * valops.c (find_overload_match): Remove use of null_cleanup, and
2629         calls to do_cleanups.
2630
2631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * compile/compile-cplus-types.c
2634         (compile_cplus_instance::decl_name): Handle changes to
2635         cp_func_name.
2636         * cp-support.c (cp_func_name): Update header comment, update
2637         return type.
2638         * cp-support.h (cp_func_name): Update return type in declaration.
2639         * valops.c (find_overload_match): Move temp_func local to top
2640         level of function and change its type.  Use temp_func to hold and
2641         delete temporary string obtained from cp_func_name.
2642
2643 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2644
2645         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2646         gdb::char_vector, remove cleanup, and update uses of `msg`.
2647
2648 2019-01-03  Jim Wilson  <jimw@sifive.com>
2649
2650         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2651
2652 2019-01-02  Tom Tromey  <tom@tromey.com>
2653
2654         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2655         (tdesc_parse_xml): Remove cleanups.
2656         * target-descriptions.h (make_cleanup_free_target_description):
2657         Don't declare.
2658         (target_desc_deleter): New struct.
2659         (target_desc_up): New typedef.
2660         * target-descriptions.c (target_desc_deleter::operator()): Rename
2661         from free_target_description.
2662         (make_cleanup_free_target_description): Remove.
2663
2664 2019-01-02  Tom Tromey  <tom@tromey.com>
2665
2666         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2667         constructor, destructor.
2668         (linespec_parser): Remove typedef.
2669         (~linespec_parser): Rename from linespec_parser_delete.
2670         (linespec_lex_to_end, linespec_complete_label)
2671         (linespec_complete): Update.
2672         (decode_line_full): Remove cleanups.
2673         (decode_line_1): Update.
2674
2675 2019-01-02  Tom Tromey  <tom@tromey.com>
2676
2677         * python/python-internal.h (inferior_to_inferior_object): Change
2678         return type.
2679         * python/py-exitedevent.c (create_exited_event_object): Update.
2680         * python/py-inferior.c (inferior_to_inferior_object): Return
2681         gdbpy_ref.
2682         (python_new_inferior, python_inferior_deleted)
2683         (thread_to_thread_object, delete_thread_object)
2684         (build_inferior_list, gdbpy_selected_inferior): Update.
2685         * python/py-infthread.c (create_thread_object): Update.  Also fail
2686         if inferior_to_inferior_object fails.
2687
2688 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2689
2690         * inferior.h (class inferior) <displaced_step_state>: New field.
2691         * infrun.h (struct displaced_step_state): Move here from
2692         infrun.c.  Initialize fields, add constructor.
2693         <inf>: Remove field.
2694         <reset>: New method.
2695         * infrun.c (struct displaced_step_inferior_state): Move to
2696         infrun.h.
2697         (displaced_step_inferior_states): Remove.
2698         (get_displaced_stepping_state): Adust.
2699         (displaced_step_in_progress_any_inferior): Adjust.
2700         (displaced_step_in_progress_thread): Adjust.
2701         (displaced_step_in_progress): Adjust.
2702         (add_displaced_stepping_state): Remove.
2703         (get_displaced_step_closure_by_addr): Adjust.
2704         (remove_displaced_stepping_state): Remove.
2705         (infrun_inferior_exit): Call displaced_step_state.reset.
2706         (use_displaced_stepping): Don't check for NULL.
2707         (displaced_step_prepare_throw): Call
2708         get_displaced_stepping_state.
2709         (displaced_step_fixup): Don't check for NULL.
2710         (prepare_for_detach): Don't check for NULL.
2711
2712 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2713
2714         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2715          in case of call that did not complete.
2716
2717 2019-01-02  Andrey Utkin  <autkin@undo.io>
2718
2719         * symfile.c (find_separate_debug_file): Fix search of debug files for
2720         remote debuggee.
2721
2722 2019-01-02  Tom Tromey  <tom@tromey.com>
2723
2724         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2725         indentation.
2726         * python/py-frame.c (frapy_older): Remove cast.
2727         (frapy_newer): Likewise.
2728         * python/py-breakpoint.c (local_setattro): Remove cast.
2729         * python/py-arch.c (archpy_name): Remove local variable.
2730         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2731
2732 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2733
2734         * unittests/basic_string_view/element_access/char/empty.cc:
2735         Fix year range in copyright header.
2736
2737 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2738
2739         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2740         Delete.
2741         <operator==>: Update with for removed field.
2742         <hash>: Likewise.
2743         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2744         <isa_features>: ...this.
2745         <abi_features>: New field.
2746         (riscv_isa_flen): Update comment.
2747         (riscv_abi_xlen): New declaration.
2748         (riscv_abi_flen): New declaration.
2749         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2750         isa_features.
2751         (riscv_abi_xlen): New function.
2752         (riscv_isa_flen): Update to get answer from isa_features.
2753         (riscv_abi_flen): New function.
2754         (riscv_has_fp_abi): Update to get answer from abi_features.
2755         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2756         xlen and flen.
2757         (riscv_call_info) <xlen, flen>: Update comment.
2758         (riscv_call_arg_struct): Remove invalid assertions
2759         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2760         is removed.
2761         (riscv_gdbarch_init): Gather isa features and abi features
2762         separately, ensure both match on the gdbarch when reusing an old
2763         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2764         a target with 64-bit float hardware.
2765
2766 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2767
2768         * source.c (search_command_helper): Stop reverse search
2769         when line 1 has been searched.
2770
2771 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2772
2773         * record-full.c (record_full_base_target::close): Rewrite
2774         record_full_core_buf_list free logic.
2775
2776 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2777
2778         * break-catch-syscall.c (print_one_catch_syscall): xfree
2779         the last text.
2780
2781 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2782
2783         * top.c (print_gdb_version): Update Copyright year in version
2784         message.
2785
2786 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2787
2788         Update copyright year range in all GDB files.
2789
2790 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2791
2792         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2793
2794 For older changes see ChangeLog-2018.
2795 \f
2796 Local Variables:
2797 mode: change-log
2798 left-margin: 8
2799 fill-column: 74
2800 version-control: never
2801 coding: utf-8
2802 End:
2803