gdb/ChangeLog

   1 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
   4         leading underscore.
   5         (GdbOutputErrorFile): Likewise.
   6         (global scope): Adjust constructor calls to GdbOutput{,Error}File
   7         accordingly.
   8         (execute_unwinders): Rename to have a leading underscore.
   9         (auto_load_packages): Likewise.
  10         (global scope): Adjust call to auto_load_packages accordingly.
  11         (GdbSetPythonDirectory): Likewise.
  12         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
  13         instead of execute_unwinders.
  14
  15 2019-08-15  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-layout.c (show_layout, show_source_disasm_command)
  18         (show_data): Don't change window visibility.
  19         (tui_gen_win_info::resize): Remove special case for command
  20         window.  Use wresize, when available.
  21         (show_source_or_disasm_and_command): Don't change window
  22         visibility.
  23         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
  24         <make_visible>: New method.
  25         * tui/tui-command.c (tui_cmd_window::resize): New method.
  26
  27 2019-08-15  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
  30         (struct tui_source_windows): New.
  31         * tui/tui-winsource.c (tui_display_main): Update.
  32         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  33         (new_height_ok, parse_scrolling_args): Update.
  34         * tui/tui-layout.c (show_layout, show_data): Update.
  35         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
  36         (tui_add_to_source_windows): Don't declare.
  37         * tui/tui-data.c (source_windows, tui_source_windows)
  38         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
  39
  40 2019-08-15  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
  43         Rename from reset.
  44         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
  45         * tui/tui-layout.c (show_source_disasm_command, show_data):
  46         Update.
  47         (tui_gen_win_info::resize): Rename.
  48         (show_source_or_disasm_and_command): Update.
  49         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
  50         reset.
  51
  52 2019-08-15  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-stack.c (tui_initialize_static_data): Remove.
  55         * tui/tui-interp.c (tui_interp::init): Don't call
  56         tui_initialize_static_data.
  57         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
  58
  59 2019-08-15  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
  62         examine tui_win_list.
  63
  64 2019-08-15  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
  67         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
  68         tui_clear_source_content.
  69         (tui_clear_source_content): Remove.
  70         (tui_source_window_base::do_erase_source_content): Hoist call to
  71         content.clear().
  72         * tui/tui-stack.c (tui_show_frame_info): Don't call
  73         tui_clear_source_content.
  74
  75 2019-08-15  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.h (struct tui_source_window_base)
  78         <do_erase_source_content>: New method.
  79         <erase_source_content>: New method.
  80         (tui_erase_source_content): Don't declare.
  81         * tui/tui-winsource.c (tui_clear_source_content): Update.
  82         (tui_source_window_base::do_erase_source_content): Rename from
  83         tui_erase_source_content.
  84         (tui_source_window_base::show_source_content): Update.
  85         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  86         * tui/tui-source.h (struct tui_source_window)
  87         <erase_source_content>: New method.
  88         * tui/tui-disasm.h (struct tui_disasm_window)
  89         <erase_source_content>: New method.
  90
  91 2019-08-15  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
  94         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
  95         constructor.
  96         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
  97         * tui/tui-source.c (tui_set_source_content): Update.
  98         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  99
 100 2019-08-15  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 103         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 104         tui-source.c.
 105         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 106         Declare.
 107         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 108         method.
 109         (tui_source_window::maybe_update): Update.
 110
 111 2019-08-15  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 114         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 115         tui-disasm.c.
 116         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 117         Declare.
 118         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 119         method.
 120         (tui_disasm_window::maybe_update): Update.
 121
 122 2019-08-15  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-winsource.h (struct tui_source_window_base)
 125         <maybe_update>: Declare.
 126         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 127         method.
 128         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 129         Declare.
 130         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 131         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 132         Declare.
 133         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 134
 135 2019-08-15  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 138
 139 2019-08-15  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.c: Include tui-stack.h.
 142         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 143         (struct tui_locator_window): Move from tui-data.h.
 144         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 145         (tui_initialize_static_data): Move from tui-data.c.
 146         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 147         (struct tui_locator_window): Move to tui-stack.c.
 148         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 149         (tui_initialize_static_data): Move to tui-stack.c.
 150
 151 2019-08-15  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-layout.c (show_source_disasm_command)
 154         (show_source_or_disasm_and_command): Use make_visible method, not
 155         tui_make_window.
 156         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 157         Remove.
 158
 159 2019-08-15  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-wingeneral.h (tui_make_window): Update.
 162         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 163         parameter.
 164         (tui_gen_win_info::make_visible): Update.
 165         * tui/tui-regs.c (tui_data_window::display_registers_from):
 166         Update.
 167         * tui/tui-layout.c (show_source_disasm_command)
 168         (show_source_or_disasm_and_command): Update.
 169         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 170         (enum tui_box): Remove.
 171         (struct tui_win_info) <can_box>: New method.
 172         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 173         method.
 174
 175 2019-08-15  Tom de Vries  <tdevries@suse.de>
 176
 177         * linux-nat-trad.c: Include gdbarch.h.
 178
 179 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 180
 181         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 182         register sizes.
 183
 184 2019-08-14  Tom Tromey  <tromey@adacore.com>
 185
 186         * darwin-nat.c: Include gdbarch.h.
 187         * darwin-nat-info.c: Include gdbarch.h.
 188
 189 2019-08-13  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 192         Remove.
 193         * tui/tui-data.c (tui_initialize_static_data): Update.
 194
 195 2019-08-13  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.h (struct tui_exec_info_window)
 198         <~tui_exec_info_window, maybe_allocate_content, get_content,
 199         m_content>: Remove.
 200         (struct tui_source_window_base) <set_exec_info_content,
 201         show_exec_info_content>: Don't declare.
 202         * tui/tui-winsource.c
 203         (tui_exec_info_window::maybe_allocate_content): Remove.
 204         (tui_source_window_base::update_exec_info): Rename from
 205         set_exec_info_content.
 206         (tui_source_window_base::show_exec_info_content)
 207         (tui_source_window_base::update_exec_info): Remove.
 208
 209 2019-08-13  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 212         declare.
 213         * tui/tui-winsource.c (tui_update_source_window_as_is)
 214         (tui_update_source_windows_with_addr, tui_erase_source_content):
 215         Update.
 216         (tui_clear_exec_info_content): Remove.
 217
 218 2019-08-13  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 221         declare.
 222         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 223         call tui_erase_exec_info_content.
 224         (tui_clear_exec_info_content): Rename from
 225         tui_erase_exec_info_content.
 226         (tui_clear_exec_info_content): Delete.
 227
 228 2019-08-13  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-winsource.h (struct tui_source_window_base)
 231         <show_exec_info_content>: Declare.
 232         (tui_show_exec_info_content): Don't declare.
 233         * tui/tui-winsource.c
 234         (tui_source_window_base::show_exec_info_content): Rename from
 235         tui_show_exec_info_content.
 236         (tui_source_window_base::update_exec_info): Update.
 237
 238 2019-08-13  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 241         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 242         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 243         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 244         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 245         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 246         ... here.
 247
 248 2019-08-13  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-winsource.h (struct tui_source_window_base)
 251         <update_exec_info>: Declare.
 252         (tui_update_exec_info): Don't declare.
 253         * tui/tui-winsource.c (tui_update_source_window_as_is)
 254         (tui_source_window_base::refresh_all)
 255         (tui_update_all_breakpoint_info): Update.
 256         (tui_source_window_base::update_exec_info): Rename from
 257         tui_update_exec_info.
 258         * tui/tui-stack.c (tui_show_frame_info): Update.
 259
 260 2019-08-13  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-winsource.h (struct tui_source_window_base)
 263         <set_exec_info_content>: Declare.
 264         (tui_set_exec_info_content): Don't declare.
 265         * tui/tui-winsource.c
 266         (tui_source_window_base::set_exec_info_content): Rename from
 267         tui_set_exec_info_content.
 268         (tui_update_exec_info): Update.
 269
 270 2019-08-13  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-winsource.h (struct tui_source_window_base)
 273         <show_source_content>: Declare.
 274         (tui_show_source_content): Don't declare.
 275         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 276         (tui_source_window_base::show_source_content): Rename from
 277         tui_show_source_content.
 278         (tui_source_window_base::refresh_all): Update.
 279         * tui/tui-layout.c (show_source_disasm_command)
 280         (show_source_or_disasm_and_command): Update.
 281
 282 2019-08-13  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-winsource.c (tui_erase_source_content)
 285         (tui_show_source_content, tui_source_window_base::refresh_all):
 286         Update.
 287         * tui/tui-wingeneral.h
 288         (tui_check_and_display_highlight_if_needed): Don't declare.
 289         * tui/tui-wingeneral.c
 290         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 291         check_and_display_highlight_if_needed.
 292         * tui/tui-win.c (tui_rehighlight_all)
 293         (tui_win_info::make_visible_with_new_height): Update.
 294         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 295         (tui_data_window::erase_data_content)
 296         (tui_data_window::display_all_data): Update.
 297         * tui/tui-data.h (struct tui_win_info)
 298         <check_and_display_highlight_if_needed>: Declare.
 299
 300 2019-08-13  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-win.c (tui_resize_all): Call
 303         tui_delete_invisible_windows.
 304         * tui/tui-layout.c (show_layout): Call
 305         tui_delete_invisible_windows.
 306         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 307         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 308
 309 2019-08-13  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 312         tui_add_win_to_layout.
 313
 314 2019-08-13  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 317         * tui/tui-layout.c (tui_default_win_height): Now static.
 318
 319 2019-08-13  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 322         single switch.
 323         (show_source_disasm_command, show_source_or_disasm_and_command):
 324         Don't check current layout.
 325
 326 2019-08-13  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-wingeneral.c (make_all_visible): Remove.
 329         (tui_make_all_invisible): Simplify.
 330         * tui/tui-layout.c (tui_make_all_invisible): Move from
 331         tui-wingeneral.c; simplify.
 332         (show_layout): Hoist call to tui_make_all_invisible.
 333         (show_data): Don't call tui_make_all_invisible.
 334
 335 2019-08-13  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 338         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 339
 340 2019-08-13  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 343         tui-data.c.
 344         (show_source_disasm_command, show_data)
 345         (show_source_or_disasm_and_command): Don't use
 346         tui_set_current_layout_to.
 347         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 348         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 349         tui-layout.c.
 350         (tui_set_current_layout_to): Remove.
 351
 352 2019-08-13  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-layout.c (tui_set_layout): Update.
 355         * tui/tui-data.h (struct tui_layout_def): Remove.
 356         (tui_layout_def): Don't declare.
 357         * tui/tui-data.c (layout_def): Remove.
 358         (tui_layout_def): Remove.
 359
 360 2019-08-13  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-winsource.h (struct tui_source_window_base)
 363         <clear_detail>: No longer "override".
 364         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 365         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 366         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 367         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 368         Remove.
 369         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 370
 371 2019-08-13  Tom Tromey  <tromey@adacore.com>
 372
 373         * tracepoint.c: Don't include readline.h or history.h.
 374
 375 2019-08-12  Tom Tromey  <tom@tromey.com>
 376
 377         * configure: Rebuild.
 378         * configure.ac: Check for readline 7.
 379         * NEWS: Mention readline 7 requirement.
 380         * README: Update.
 381
 382 2019-08-12  Tom Tromey  <tom@tromey.com>
 383
 384         * mingw-hdep.c (gdb_select): Remove readline hack.
 385
 386 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 387
 388         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 389         when the function fails.
 390
 391 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 392
 393         * s390-tdep.c (s390_type_align): New function.
 394         (s390_gdbarch_init): Set it as type_align gdbarch method.
 395
 396 2019-08-09  Tom de Vries  <tdevries@suse.de>
 397
 398         PR gdb/24591
 399         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 400         pc_low with relocation offset.
 401
 402 2019-08-07  Tom Tromey  <tromey@adacore.com>
 403
 404         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 405         (print_frame_args): Update.
 406         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 407         Update.
 408         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 409         * frame.h (struct frame_arg): Add initializers.
 410         <error>: Now a unique_xmalloc_ptr.
 411
 412 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 413
 414         * NEWS: Expand the Pointer Authentication entry.
 415         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 416         (aarch64_frame_unmask_lr): ... to this.
 417         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 418         Call aarch64_frame_unmask_lr.
 419         * frame.c (struct frame_info): Add "masked" variable.
 420         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 421         (fprint_frame): Check for masked pc.
 422         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 423         declarations.
 424         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 425         * stack.c (print_frame): Check for masked pc.
 426
 427 2019-08-06  Tom Tromey  <tom@tromey.com>
 428
 429         * stabsread.c (patch_block_stabs, read_one_struct_field)
 430         (read_enum_type): Use obstack_strndup.
 431         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 432         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 433         * dwarf2read.c (guess_full_die_structure_name)
 434         (anonymous_struct_prefix): Use obstack_strndup.
 435         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 436         * c-exp.y (yylex): Use obstack_strndup.
 437         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 438         (write_var_or_type): Use obstack_strndup.
 439
 440 2019-08-06  Tom Tromey  <tom@tromey.com>
 441
 442         * symfile.c (reread_symbols): Use obstack_strdup.
 443         * stabsread.c (read_type): Use obstack_strdup.
 444         * gdb_obstack.h (obstack_strdup): New overload.
 445         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 446         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 447         (dwarf2_canonicalize_name): Use obstack_strdup.
 448         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 449         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 450         Use obstack_strdup.
 451
 452 2019-08-06  Tom Tromey  <tom@tromey.com>
 453
 454         * gdb_obstack.h (obstack_strdup): Define.
 455         * gdb_obstack.c (obstack_strdup): Don't define.
 456
 457 2019-08-06  Tom Tromey  <tom@tromey.com>
 458
 459         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 460         obstack_strdup.
 461         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 462         obstack_strdup.
 463         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 464         * stabsread.c (common_block_start): Use obstack_strdup.
 465         * objfiles.c (set_objfile_main_name, objfile): Use
 466         obstack_strdup.
 467         * namespace.c (add_using_directive): Use obstack_strdup.
 468         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 469         * jit.c (finalize_symtab): Use obstack_strdup.
 470         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 471         (guess_partial_die_structure_name, partial_die_info::fixup)
 472         (dwarf2_name): Use obstack_strdup.
 473         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 474         obstack_strdup.
 475         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 476         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 477         obstack_strdup.
 478         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 479
 480 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 481
 482         * unittests/help-doc-selftests.c: New file.
 483         * Makefile.in: Add the new file.
 484
 485 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 486
 487         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 488         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 489         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 490         the trailing '.' is not output, and the first character is uppercased.
 491         (print_help_for_command): Update call to print_doc_line.
 492         (print_doc_of_command): Likewise.
 493         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 494         * cli/cli-option.c (append_indented_doc): Do not append newline.
 495         (build_help_option): Append newline after first appended_indented_doc
 496         only if a second call is done.
 497         (build_help): Append 2 new lines before each option, except the first
 498         one.
 499         * compile/compile.c (_initialize_compile): Add new lines after
 500         %OPTIONS%, when not at the end of the help.
 501         Change help doc or code
 502         producing the help doc to respect the invariants.
 503         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 504         Also removed the new line after 'Options:', as all other commands
 505         do not put an empty line between 'Options:' and the first option.
 506         * printcmd.c (_initialize_printcmd): Likewise.
 507         * stack.c (_initialize_stack): Likewise.
 508         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 509         incorrectly telling COMMAND is optional.
 510         * ada-lang.c (_initialize_ada_language): Change help doc or code
 511         producing the help doc to respect the invariants.
 512         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 513         * breakpoint.c (_initialize_breakpoint): Likewise.
 514         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 515         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 516         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 517         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 518         _initialize_cli_style): Likewise.
 519         * corelow.c (core_target_info): Likewise.
 520         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 521         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 522         * filesystem.c (_initialize_filesystem): Likewise.
 523         * frame.c (_initialize_frame): Likewise.
 524         * gnu-nat.c (add_task_commands): Likewise.
 525         * infcall.c (_initialize_infcall): Likewise.
 526         * infcmd.c (_initialize_infcmd): Likewise.
 527         * interps.c (_initialize_interpreter): Likewise.
 528         * language.c (_initialize_language): Likewise.
 529         * linux-fork.c (_initialize_linux_fork): Likewise.
 530         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 531         * maint.c (_initialize_maint_cmds): Likewise.
 532         * memattr.c (_initialize_mem): Likewise.
 533         * printcmd.c (_initialize_printcmd): Likewise.
 534         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 535         _RegEx): Likewise.
 536         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 537         * record-btrace.c (_initialize_record_btrace): Likewise.
 538         * record-full.c (_initialize_record_full): Likewise.
 539         * record.c (_initialize_record): Likewise.
 540         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 541         * regcache.c (_initialize_regcache): Likewise.
 542         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 543         _initialize_remote): Likewise.
 544         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 545         * serial.c (_initialize_serial): Likewise.
 546         * skip.c (_initialize_step_skip): Likewise.
 547         * source.c (_initialize_source): Likewise.
 548         * stack.c (_initialize_stack): Likewise.
 549         * symfile.c (_initialize_symfile): Likewise.
 550         * symtab.c (_initialize_symtab): Likewise.
 551         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 552         * top.c (init_main): Likewise.
 553         * tracefile-tfile.c (tfile_target_info): Likewise.
 554         * tracepoint.c (_initialize_tracepoint): Likewise.
 555         * tui/tui-win.c (_initialize_tui_win): Likewise.
 556         * utils.c (add_internal_problem_command): Likewise.
 557         * valprint.c (value_print_option_defs): Likewise.
 558
 559 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 560
 561         PR build/24886
 562         * configure.ac: Drop enable-libmcheck support.
 563         * configure, config.in: Rebuild.
 564         * libmcheck.m4: Remove.
 565         * acinclude.m4: Don't include it.
 566         * Makefile.in: Don't distribute it.
 567         * top.c (print_gdb_configuration): Don't mention it.
 568
 569 2019-08-06  Tom Tromey  <tom@tromey.com>
 570
 571         * utils.c (set_output_style): Sometimes pass stream to
 572         emit_style_escape.
 573         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 574         * record-btrace.c (btrace_insn_history): Update.
 575         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 576         method.
 577         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 578         Update initializers.
 579         <m_uiout>: New field.
 580         <m_di>: Move lower.
 581         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 582         Remove "uiout" parameter.
 583         (dump_insns): Update.
 584         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 585         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 586
 587 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 588
 589         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 590         (error_in_psymtab_expansion): Likewise.
 591         (lookup_symbol_via_quick_fns): Likewise.
 592         (basic_lookup_transparent_type_quick): Likewise.
 593         (basic_lookup_transparent_type_1): Likewise.
 594
 595 2019-08-06  Tom Tromey  <tromey@adacore.com>
 596
 597         * source.c (last_source_error): Now bool.
 598         (print_source_lines_base): Make "noprint" bool.  Only open
 599         source file when last_source_visited changes.
 600
 601 2019-08-06  Tom Tromey  <tromey@adacore.com>
 602
 603         * annotate.c (annotate_source_line): Use g_source_cache.
 604         * source-cache.c (source_cache::get_plain_source_lines): Change
 605         parameters.  Populate m_offset_cache.
 606         (source_cache::ensure): New method.
 607         (source_cache::get_line_charpos): New method.
 608         (extract_lines): Move lower.  Change parameters.
 609         (source_cache::get_source_lines): Move lower.
 610         * source-cache.h (class source_cache): Update comment.
 611         <get_line_charpos>: New method.
 612         <get_source_lines>: Update comment.
 613         <clear>: Clear m_offset_cache.
 614         <get_plain_source_lines>: Change parameters.
 615         <ensure>: New method
 616         <m_offset_cache>: New member.
 617         * source.c (forget_cached_source_info_for_objfile): Update.
 618         (info_source_command): Use g_source_cache.
 619         (find_source_lines, open_source_file_with_line_charpos): Remove.
 620         (print_source_lines_base, search_command_helper): Use g_source_cache.
 621         * source.h (open_source_file_with_line_charpos): Don't declare.
 622         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 623         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 624         Use g_source_cache.
 625
 626 2019-08-06  Tom Tromey  <tromey@adacore.com>
 627
 628         * source-cache.c (source_cache::get_plain_source_lines):
 629         Remove "first_line" and "last_line" parameters.
 630         (source_cache::get_source_lines): Cache plain text.
 631         * source-cache.h (class source_cache)
 632         <get_plain_source_lines>: Update.
 633
 634 2019-08-06  Tom Tromey  <tromey@adacore.com>
 635
 636         * source-cache.c (extract_lines): No longer a method.
 637         Changed type of parameter.  Include final newline.
 638         (selftests::extract_lines_test): New function.
 639         (_initialize_source_cache): Likewise.
 640         * source-cache.h (class source_cache)
 641         <extract_lines>: Don't declare.
 642
 643 2019-08-06  Tom Tromey  <tromey@adacore.com>
 644
 645         * breakpoint.c (init_breakpoint_sal): Update.
 646         (breakpoint): Update.
 647         * breakpoint.h (struct breakpoint) <filter>: Now a
 648         unique_xmalloc_ptr.
 649
 650 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 651
 652         * NEWS: Mention dictionary access on blocks.
 653         * python/py-block.c (blpy_getitem): New function.
 654         (block_object_as_mapping): New struct.
 655         (block_object_type): Use new struct for tp_as_mapping field.
 656
 657 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 658
 659         * objfiles.h (objfile): Add a comment describing partial symbols.
 660
 661 2019-08-05  Tom Tromey  <tromey@adacore.com>
 662
 663         * compile/compile.c (_initialize_compile): Use _(), not N_().
 664         * thread.c (_initialize_thread): Use _(), not N_().
 665         * stack.c (_initialize_stack): Use _(), not N_().
 666         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 667
 668 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 669
 670         * dwarf2read.c (struct dw2_symtab_iterator):
 671         <want_specific_block>: Remove.
 672         <block_index>: Change type to gdb::optional.
 673         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 674         change type of BLOCK_INDEX parameter to gdb::optional.
 675         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 676         (dw2_lookup_symbol): Don't pass argument for
 677         WANT_SPECIFIC_BLOCK.
 678         (dw2_expand_symtabs_for_function): Don't pass argument for
 679         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 680         (class dw2_debug_names_iterator)
 681         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 682         parameter, change BLOCK_INDEX type to gdb::optional.
 683         <m_want_specific_block>: Remove.
 684         <m_block_index>: Change type to gdb::optional.
 685         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 686         gdb::optional.  Re-write in function of gdb::optional.
 687         (dw2_debug_names_lookup_symbol): Don't pass argument for
 688         WANT_SPECIFIC_BLOCK.
 689         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 690         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 691         BLOCK_INDEX.
 692
 693 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 694
 695         * NEWS: Mention changes to "info sources" command.
 696
 697 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 698
 699         * symtab.c (filename_partial_match_opts): New struct type.
 700         (struct output_source_filename_data): New members
 701         regexp, c_regexp, partial_match.
 702         (output_source_filename): Use new members to decide to print file.
 703         (info_sources_option_defs): New variable.
 704         (make_info_sources_options_def_group, print_info_sources_header,
 705         info_sources_command_completer):
 706         New functions.
 707         (info_sources_command): Read new optional arguments.
 708         (_initialize_symtab): Update info sources help.
 709
 710 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 711
 712         * ada-lang.c (exception_support_info_v0): Renamed from...
 713         (default_exception_support_info): ... this.  Create new
 714         definition for v1.
 715         (ada_has_this_exception_support): Look up catch_handlers_sym.
 716         (ada_exception_support_info_sniffer): Try v0 after default.
 717
 718 2019-08-01  Tom Tromey  <tromey@adacore.com>
 719
 720         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 721         gdbarch.h.
 722
 723 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 724
 725         * s12z-tdep.c: Fix include path for s12z-opc.h.
 726
 727 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 728
 729         * NEWS: Require GNU make 3.82.
 730
 731 2019-07-16  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 734         declare.
 735
 736 2019-07-30  Tom Tromey  <tromey@adacore.com>
 737
 738         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 739
 740 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 741
 742         * printcmd.c (print_address_symbolic): Print negative offsets.
 743         (build_address_symbolic): Force signed arithmetic when computing
 744         offset.
 745
 746 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 747
 748         PR/24474: Add a function to lookup static variables.
 749         * NEWS: Mention this new function.
 750         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 751         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 752         * python/python.c (python_GdbMethods): Add new function.
 753
 754 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 755
 756         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 757         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 758         (objfpy_lookup_static_symbol): New function.
 759         (objfile_object_methods): Add new functions.
 760
 761 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 762
 763         * NEWS: Mention 'set|show print frame-info'.  Mention new
 764         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 765         backtrace argument.  Mention that python frame filtering code
 766         is now consistent with what 'backtrace' command prints.
 767
 768 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 769
 770         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 771         comments.
 772         (print_frame_info_auto, print_frame_info_source_line,
 773         print_frame_info_location, print_frame_info_source_and_location,
 774         print_frame_info_location_and_address, print_frame_info_short_location):
 775         New declarations.
 776         (struct frame_print_options): New member print_frame_info.
 777         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 778         * stack.h (get_user_print_what_frame_info): New declaration.
 779         (frame_show_address): New declaration.
 780         * stack.c (print_frame_arguments_choices): New value 'presence'.
 781         (print_frame_info_auto, print_frame_info_source_line,
 782         print_frame_info_location, print_frame_info_source_and_location,
 783         print_frame_info_location_and_address, print_frame_info_short_location,
 784         print_frame_info_choices, print_frame_info_print_what): New definitions.
 785         (print_frame_args): Only print dots for args if print frame-arguments
 786         is 'presence'.
 787         (frame_print_option_defs): New element for "frame-info".
 788         (get_user_print_what_frame_info): New function.
 789         (frame_show_address): Make non static.  Move comment to stack.h.
 790         (print_frame_info_to_print_what): New function.
 791         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 792         to decide what to print.
 793         (backtrace_command_1): Handle the new print_frame_arguments_presence
 794         value.
 795         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 796         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 797         (py_print_frame): In non-mi mode, use LOCATION as default for
 798         print_what, similarly to frame information printed directly by
 799         backtrace command. Handle frame-info user option in non MI mode.
 800
 801 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 802
 803         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 804         Add case for debugging 32-bit target on 64-bit host.  Revise
 805         comment.
 806
 807 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 808
 809         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 810         instead of find_function_entry_range_from_pc.
 811
 812 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 813
 814         * stack.c (find_frame_funname): Remove code which preferred
 815         minsym over symtab sym in "certain pathological cases".
 816
 817         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 818         parameter.  Change type of "do_demangle" to bool.
 819         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 820         Pass suitable "prefer_sym_over_minsym" flag to
 821         build_address_symbolic().  Don't output "+" for negative offsets.
 822         * printcmd.c (print_address_symbolic): Update invocation of
 823         build_address_symbolic to include a "prefer_sym_over_minsym"
 824         flag.
 825         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 826         Restrict cases in which use of minimal symbol is preferred to that
 827         of a found symbol.  Update comments.
 828
 829         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 830         for entry pc when entry pc is out of range for that FDE.
 831
 832 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 833
 834         PR gdb/24839:
 835         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 836         type.
 837
 838 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 839
 840         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 841         this function's Python signature.
 842
 843
 844 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 845
 846         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 847         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 848         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 849         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 850         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 851
 852
 853 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 854
 855         * h8300-tdep.c (h8300_register_name_common): New.
 856         h8300_register_name): Use h8300_register_name_common.
 857         (h8300s_register_name): Likewise.
 858         (h8300sx_register_name): Likewise.
 859         (h8300h_register_nam): New.
 860         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 861
 862
 863 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 864
 865         * arm-tdep.c (arm_skip_cmse_entry): New function.
 866         (arm_is_sgstubs_section): New function.
 867         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 868
 869 2019-07-22  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 872         Don't self-assign.
 873
 874 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 877         type_print.
 878
 879 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 882         so that GDB doesn't match any msymbols when searching in the
 883         TYPES_DOMAIN.
 884         (print_symbol_info): Print using typedef_print or type_print based
 885         on the type of the symbol.  Add updated FIXME comment moved from...
 886         (_initialize_symtab): ... move and update FIXME comment to above.
 887
 888 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * NEWS: Mention adding -q option to "info types".
 891         * symtab.c (struct info_types_options): New struct.
 892         (info_types_options_defs): New variable.
 893         (make_info_types_options_def_group): New function.
 894         (info_types_command): Use gdb::option framework to parse options.
 895         (info_types_command_completer): New function.
 896         (_initialize_symtab): Extend the help text on "info types" and
 897         register command completer.
 898
 899 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 900
 901         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 902         (lookup_symbol_in_objfile): Change int to block_enum and add a
 903         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 904
 905 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 906
 907         * MAINTAINERS (Write After Approval): Add self.
 908
 909 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 912         instruction to the dummy code region.
 913
 914 2019-07-19  Tom Tromey  <tromey@adacore.com>
 915
 916         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 917         (ARGSUSED, PARAMS, __func__): Remove rules.
 918
 919 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 920
 921         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 922         * features/arm/arm-with-iwmmxt.c: Remove.
 923         * features/arm/arm-with-iwmmxt.xml: Remove.
 924         * features/arm/arm-with-m-fpa-layout.c: Remove.
 925         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 926         * features/arm/arm-with-m-vfp-d16.c: Remove.
 927         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 928         * features/arm/arm-with-m.c: Remove.
 929         * features/arm/arm-with-m.xml: Remove.
 930         * features/arm/arm-with-neon.c: Remove.
 931         * features/arm/arm-with-neon.xml: Remove.
 932         * features/arm/arm-with-vfpv2.c: Remove.
 933         * features/arm/arm-with-vfpv2.xml: Remove.
 934         * features/arm/arm-with-vfpv3.c: Remove.
 935         * features/arm/arm-with-vfpv3.xml: Remove.
 936
 937 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 938
 939         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 940
 941 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 942
 943         * arch/aarch32.c (aarch32_create_target_description): Create
 944         target descriptions using features.
 945         * arch/arm.c (arm_create_target_description)
 946         (arm_create_mprofile_target_description): Likewise.
 947         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 948
 949 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 950
 951         * Makefile.in: Add new files.
 952         * aarch32-tdep.c: New file.
 953         * aarch32-tdep.h: New file.
 954         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 955         Call aarch32_read_description.
 956         * arch/aarch32.c: New file.
 957         * arch/aarch32.h: New file.
 958         * arch/arm.c (arm_create_target_description)
 959         (arm_create_mprofile_target_description): New function.
 960         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 961         (arm_create_target_description)
 962         (arm_create_mprofile_target_description): New declaration.
 963         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 964         read_description functions.
 965         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 966         Likewise.
 967         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 968         * arm-tdep.c (tdesc_arm_list): New variable.
 969         (arm_register_g_packet_guesses): Call create description functions.
 970         (arm_read_description) (arm_read_mprofile_description): New
 971         function.
 972         * arm-tdep.h (arm_read_description)
 973         (arm_read_mprofile_description): Add declaration.
 974         * configure.tgt: Add new files.
 975
 976 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 977
 978         * top.c (new_ui_command): Open specified terminal just once.
 979
 980 2019-07-18  Tom Tromey  <tromey@adacore.com>
 981
 982         * symtab.c (main_name): Constify return type.
 983         * symfile.c (set_initial_language): Update.
 984         * symtab.h (main_name): Constify return type.
 985
 986 2019-07-17  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-winsource.c (tui_update_source_window)
 989         (tui_update_source_window_as_is)
 990         (tui_update_source_windows_with_line): Remove return.
 991         * tui/tui-disasm.c (tui_show_disassem)
 992         (tui_show_disassem_and_update_source): Remove return.
 993         * tui/tui.c (tui_reset): Remove return.
 994         * tui/tui-wingeneral.c
 995         (tui_check_and_display_highlight_if_needed): Remove return.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1000
1001 2019-07-17  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-winsource.h (struct tui_exec_info_window)
1004         (struct tui_source_window_base): Move from tui-data.h.
1005         * tui/tui-winsource.c: Move many method definitions from
1006         elsewhere.  Remove "structuring" comments.
1007         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1008         (tui_source_window_base::refresh_window): Move to
1009         tui-winsource.c.
1010         * tui/tui-win.c (tui_source_window_base::refresh_all)
1011         (tui_source_window_base::update_tab_width)
1012         (tui_source_window_base::set_new_height)
1013         (tui_source_window_base::do_make_visible_with_new_height): Move to
1014         tui-winsource.c.
1015         * tui/tui-source.h: Update.
1016         * tui/tui-source.c (tui_source_window_base::reset): Move to
1017         tui-winsource.c.
1018         * tui/tui-disasm.h: Update.
1019         * tui/tui-data.h (struct tui_exec_info_window): Move to
1020         tui-winsource.h.
1021         (struct tui_source_window_base): Likewise.
1022         * tui/tui-data.c (tui_source_window_base::clear_detail)
1023         (tui_source_window_base, ~tui_source_window_base): Move to
1024         tui-winsource.c.
1025
1026 2019-07-17  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-win.c (tui_resize_all)
1029         (tui_source_window_base::update_tab_width)
1030         (tui_adjust_win_heights): Update.
1031         (tui_win_info::make_invisible_and_set_new_height): Rename from
1032         make_invisible_and_set_new_height.
1033         * tui/tui-data.h (struct tui_win_info)
1034         <make_invisible_and_set_new_height>: New method.
1035
1036 2019-07-17  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui.c: Update.
1039         * tui/tui-source.h (struct tui_source_window): Move from
1040         tui-data.h.
1041         * tui/tui-layout.c: Update.
1042         * tui/tui-disasm.c: Update.
1043         * tui/tui-data.h (struct tui_source_window): Move to
1044         tui-source.h.
1045
1046 2019-07-17  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1049         tui-data.h.
1050         * tui/tui-data.h (struct tui_disasm_window): Move to
1051         tui-disasm.h.
1052
1053 2019-07-17  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-regs.h (struct tui_data_item_window): Move from
1056         tui-data.h.
1057         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1058         * tui/tui-data.h (struct tui_data_item_window): Move to
1059         tui-regs.h.
1060         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1061
1062 2019-07-17  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui.c: Update.
1065         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1066         (tui_cmd_window::max_height): Move to tui-command.c.
1067         * tui/tui-layout.c: Update.
1068         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1069         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1070         tui-command.c.
1071         * tui/tui-command.h (struct tui_cmd_window): Move from
1072         tui-data.h.
1073         * tui/tui-command.c: Remove "structuring" comments.
1074         (tui_cmd_window::clear_detail)
1075         (tui_cmd_window::do_make_visible_with_new_height)
1076         (tui_cmd_window::max_height): Move from elsewhere.
1077
1078 2019-07-17  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1081         Now static.
1082         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1083         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1084
1085 2019-07-17  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui.c: Update.
1088         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1089         tui-regs.c.
1090         * tui/tui-windata.h: Remove file.
1091         * tui/tui-windata.c: Remove file.
1092         * tui/tui-win.c (tui_data_window::set_new_height)
1093         (tui_data_window::do_make_visible_with_new_height): Move to
1094         tui-regs.c.
1095         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1096         * tui/tui-regs.c: Remove "structuring" comments.
1097         (tui_data_window::first_data_item_displayed)
1098         (tui_data_window::delete_data_content_windows)
1099         (tui_data_window::erase_data_content)
1100         (tui_data_window::display_all_data)
1101         (tui_data_window::refresh_all)
1102         (tui_data_window::do_scroll_vertical)
1103         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1104         (tui_data_window::do_make_visible_with_new_height)
1105         (tui_data_window::refresh_window): Move from elsewhere.
1106         (_initialize_tui_regs): Move to end of file.
1107         * tui/tui-layout.c: Update.
1108         * tui/tui-hooks.c: Update.
1109         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1110         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1111         tui-regs.c.
1112         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1113
1114 2019-07-17  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1117         seen.
1118
1119 2019-07-17  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-win.c (tui_source_window_base::set_new_height)
1122         (tui_source_window_base::do_make_visible_with_new_height): Use
1123         m_has_locator field directly.
1124         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1125         method.
1126         (struct tui_source_window_base) <has_locator>: Likewise.
1127
1128 2019-07-17  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1131         Don't declare.
1132         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1133         Remove.
1134         * tui/tui-win.c (tui_source_window_base::set_new_height)
1135         (tui_source_window_base::set_new_height)
1136         (make_invisible_and_set_new_height)
1137         (tui_source_window_base::do_make_visible_with_new_height)
1138         (tui_source_window_base::do_make_visible_with_new_height):
1139         Update.
1140         * tui/tui-layout.c (show_source_disasm_command, show_data)
1141         (show_source_or_disasm_and_command): Update.
1142         * tui/tui-layout.c (show_layout): Update.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-layout.c (make_data_window): Remove.
1147         (show_data): Unify creation and re-initialization cases.
1148
1149 2019-07-17  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-layout.c (make_source_window, make_disasm_window):
1152         Remove.
1153         (show_data): Unify creation and re-initialization cases.
1154
1155 2019-07-17  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-layout.c (make_command_window): Remove.
1158         (show_source_disasm_command, show_source_or_disasm_and_command):
1159         Unify creation and re-initialization cases.
1160
1161 2019-07-17  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1164         creation and re-initialization cases.
1165
1166 2019-07-17  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-regs.c (tui_get_register): Return void.
1169
1170 2019-07-17  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1173         Simplify.
1174
1175 2019-07-17  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1178         resetting.
1179
1180 2019-07-17  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1183         * tui/tui-regs.c (tui_reg_layout): New function.
1184         (tui_show_registers, tui_reg_command): Use it.
1185         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1186         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1187         parameters.
1188         (tui_layout_command): Remove.
1189
1190 2019-07-17  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-layout.h (tui/tui-layout): Return void.
1193         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1194
1195 2019-07-17  Tom Tromey  <tom@tromey.com>
1196
1197         * tui/tui-layout.c (show_source_disasm_command, show_data):
1198         Update.
1199         (reset_locator): Remove.
1200         (show_source_or_disasm_and_command): Update.
1201
1202 2019-07-17  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-source.c (tui_source_window_base::reset): Remove
1205         win_type parameter.
1206         * tui/tui-layout.c (make_command_window, make_source_window)
1207         (make_disasm_window, make_data_window)
1208         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1209         (reset_locator, show_source_or_disasm_and_command): Update.
1210         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1211         win_type parameter.
1212         (struct tui_source_window_base) <reset>: Likewise.
1213
1214 2019-07-17  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-layout.c (show_source_disasm_command): Use
1217         reset_locator.
1218         (reset_locator): New function.
1219         (init_and_make_win): Remove.
1220         (show_source_or_disasm_and_command): Use reset_locator.
1221
1222 2019-07-17  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1225         condition.
1226         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1227         Remove condition.
1228         * tui/tui-source.c (tui_source_window_base::reset): New method.
1229         * tui/tui-layout.c (make_command_window): Don't call
1230         init_and_make_win.
1231         (make_source_window, make_disasm_window): Don't call
1232         make_source_or_disasm_window.
1233         (make_data_window): Don't call init_and_make_win.  Change calling
1234         convention.
1235         (show_source_disasm_command, show_data): Simplify.
1236         (make_source_or_disasm_window): Remove.
1237         (show_source_or_disasm_and_command): Simplify.
1238         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1239         (struct tui_source_window_base) <reset>: Likewise.
1240         <execution_info>: Remove initializer.
1241         * tui/tui-data.c (tui_source_window_base): Initialize
1242         execution_info.
1243
1244 2019-07-17  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1247         variable.
1248
1249 2019-07-17  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui.c (tui_rl_other_window): Update.
1252         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1253         superclass method first.  Always iterate over regs_content.
1254         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1255         method.
1256         * tui/tui-win.c (tui_set_focus_command): Update.
1257
1258 2019-07-17  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-win.c (tui_set_focus_command): Rename from
1261         tui_set_focus.  Call tui_enable.
1262         (tui_set_focus_command): Remove.
1263
1264 2019-07-17  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1267         refresh_window.
1268         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1269         touchwin.
1270         (tui_data_window::refresh_window): Call refresh_window on data
1271         items.  Always call superclass refresh_window.
1272         (tui_win_info::refresh): Remove.
1273         (tui_source_window_base::refresh_window): Update.
1274         (tui_refresh_all): Update.
1275         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1276         refresh_window.
1277         (show_source_or_disasm_and_command): Likewise.
1278         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1279         (struct tui_source_window_base) <refresh>: Likewise.
1280
1281 2019-07-17  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-winsource.c (tui_clear_source_content)
1284         (tui_show_source_content): Update.
1285         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1286         whether content is empty.
1287         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1288         Remove.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1293         window's contents.
1294         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1295         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1296
1297 2019-07-17  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1300         (struct tui_data_item_window): Update.
1301
1302 2019-07-17  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1305         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1306         defines.
1307
1308 2019-07-17  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-winsource.h (tui_erase_source_content)
1311         (tui_clear_source_content): Remove "display_prompt" parameter.
1312         * tui/tui-winsource.c (tui_update_source_window_as_is)
1313         (tui_update_source_windows_with_addr): Update.
1314         (tui_clear_source_content): Remove "display_prompt" parameter.
1315         (tui_erase_source_content): Likewise.  Simplify.
1316         (tui_show_source_content): Update.
1317         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1318         * tui/tui-stack.c (tui_show_frame_info): Update.
1319         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1320         Remove defines.
1321
1322 2019-07-17  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1325         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1326         parameter.
1327         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1328         parameter.
1329
1330 2019-07-17  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-winsource.c (tui_clear_source_content)
1333         (tui_show_source_content, tui_show_exec_info_content)
1334         (tui_clear_exec_info_content): Update.
1335         * tui/tui-stack.c (tui_show_locator_content): Update.
1336         (tui_show_frame_info): Update.
1337         * tui/tui-source.h (tui_source_window): Don't declare.
1338         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1339         from tui_source_is_displayed.
1340         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1341         Remove field.
1342         (struct tui_source_window_base) <content_in_use>: New field.  Now
1343         bool.
1344         (struct tui_source_window) <showing_source_p>: New method.
1345         (TUI_SRC_WIN): Change cast.
1346         * tui/tui-data.c (tui_initialize_static_data): Update.
1347
1348 2019-07-17  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1351         location_matches_p.
1352         * tui/tui-source.c (tui_source_window::location_matches_p): New
1353         method.
1354         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1355         method.
1356         * tui/tui-data.h (struct tui_source_window_base)
1357         <location_matches_p>: New method.
1358         (struct tui_source_window, struct tui_disasm_window)
1359         <location_matches_p>: Likewise.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-win.c (tui_set_win_height_command): Rename from
1364         tui_set_win_height.
1365         (tui_set_win_height_command): Remove.
1366
1367 2019-07-17  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-source.c (tui_source_window): New constructor.  Add
1370         observer.
1371         (~tui_source_window): New destructor.
1372         (tui_source_window::style_changed): New method.
1373         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1374         (tui_attach_detach_observers): Update.
1375         * tui/tui-data.h (struct tui_source_window): Make constructor not
1376         inline.  Add destructor.
1377         (struct tui_source_window) <style_changed>: New method.
1378         <m_observable>: New member.
1379
1380 2019-07-17  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1383         * tui/tui-win.c (tui_resize_all): Fix typo.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1388         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1389         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1390         * tui/tui-win.c (window_name_completer): Use foreach.
1391         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1392         (update_tab_width): Likewise.
1393         * tui/tui-layout.c (show_layout): Update.
1394         * tui/tui-data.h (class tui_window_iterator): New.
1395         (struct all_tui_windows): New.
1396         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1397
1398 2019-07-17  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1401         parameter.  Don't reference globals.
1402         (tui_reg_command): Update.
1403
1404 2019-07-17  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-regs.c (tui_show_registers): Simplify.
1407
1408 2019-07-17  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-regs.c (tui_show_registers): Update.
1411         (tui_show_register_group): Add win_info parameter.
1412
1413 2019-07-17  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1416         Rename from tui_display_reg_element_at_line.
1417         (tui_data_window::display_registers_from_line): Update.
1418         * tui/tui-data.h (struct tui_data_window)
1419         <display_reg_element_at_line>: New method.
1420
1421 2019-07-17  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-regs.h (tui_display_registers_from)
1424         (tui_display_registers_from_line): Don't declare.
1425         * tui/tui-windata.c (tui_data_window::display_all_data)
1426         (tui_data_window::refresh_all)
1427         (tui_data_window::do_scroll_vertical): Update.
1428         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1429         from tui_display_registers_from.
1430         (tui_display_reg_element_at_line): Update.
1431         (tui_data_window::display_registers_from_line): Rename from
1432         tui_display_registers_from_line.
1433         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1434         display_registers_from_line>: New methods.
1435
1436 2019-07-17  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1439         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1440         from tui_erase_data_content.
1441         (tui_data_window::display_all_data)
1442         (tui_data_window::refresh_all)
1443         (tui_data_window::do_scroll_vertical): Update.
1444         * tui/tui-regs.c (tui_show_registers): Update.
1445         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1446         New method.
1447
1448 2019-07-17  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1451         declare.
1452         * tui/tui-windata.c
1453         (tui_data_window::delete_data_content_windows): Rename from
1454         tui_delete_data_content_windows.
1455         (tui_data_window::display_all_data)
1456         (tui_data_window::do_scroll_vertical): Update.
1457         * tui/tui-data.h (struct tui_data_window)
1458         <delete_data_content_windows>: New method.
1459
1460 2019-07-17  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1463         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1464
1465 2019-07-17  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1468         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1469         from tui_display_all_data.
1470         * tui/tui-win.c
1471         (tui_data_window::do_make_visible_with_new_height): Update.
1472         * tui/tui-regs.c (tui_show_registers): Update.
1473         * tui/tui-layout.c (tui_set_layout): Update.
1474         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1475         method.
1476
1477 2019-07-17  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1480         * tui/tui-windata.c (tui_display_data_from): Remove.
1481         (tui_data_window::refresh_all): Update.
1482
1483 2019-07-17  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1486         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1487         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1488         tui_display_registers_from_line.
1489         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1490         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1491         "force_display" parameter.
1492
1493 2019-07-17  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1496         declare.
1497         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1498         Rename from tui_first_reg_element_no_inline.
1499         (tui_display_reg_element_at_line)
1500         (tui_display_registers_from_line): Update.
1501         * tui/tui-data.h (struct tui_data_window)
1502         <first_reg_element_no_inline>: New method.
1503
1504 2019-07-17  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-windata.c (tui_display_data_from)
1507         (tui_data_window::do_scroll_vertical): Update.
1508         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1509         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1510         Rename from tui_line_from_reg_element_no.
1511         (tui_display_registers_from_line): Update.
1512         * tui/tui-data.h (struct tui_data_window)
1513         <line_from_reg_element_no>: New method.
1514
1515 2019-07-17  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1518         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1519         tui_last_regs_line_no.
1520         (tui_display_reg_element_at_line)
1521         (tui_display_registers_from_line): Update.
1522         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1523         method.
1524
1525 2019-07-17  Tom Tromey  <tom@tromey.com>
1526
1527         PR tui/24722:
1528         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1529         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1530         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1531         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1532         (tui_update_breakpoint_info): Likewise.
1533         * tui/tui-hooks.c (tui_event_create_breakpoint)
1534         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1535         Update.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1540
1541 2019-07-17  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-winsource.c (tui_update_source_window_as_is)
1544         (tui_update_source_windows_with_addr): Update.
1545         * tui/tui-source.h (tui_set_source_content)
1546         (tui_show_symtab_source): Add "win_info" parameter.
1547         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1548         parameter.
1549         (tui_show_symtab_source): Likewise.
1550
1551 2019-07-17  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-wingeneral.c
1554         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1555
1556 2019-07-17  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1559         (struct tui_cmd_window) <can_scroll>: New method.
1560         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1561         method.
1562
1563 2019-07-17  Tom Tromey  <tromey@adacore.com>
1564
1565         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1566         do_field_signed>: Rename.  Change type of "value".
1567         * ui-out.c (ui_out::field_signed): Rename from field_int.
1568         Change type of "value".
1569         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1570         type of "value".
1571         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1572         do_field_int.  Change type of "value".
1573         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1574         do_field_int.  Change type of "value".
1575         * tracepoint.c (trace_status_mi, tfind_1)
1576         (print_one_static_tracepoint_marker): Update.
1577         * thread.c (print_thread_info_1, print_selected_thread_frame):
1578         Update.
1579         * stack.c (print_frame, print_frame_info): Update.
1580         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1581         Update.
1582         * source.c (print_source_lines_base): Update.
1583         * skip.c (info_skip_command): Update.
1584         * record-btrace.c (btrace_ui_out_decode_error)
1585         (btrace_call_history_src_line): Update.
1586         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1587         Update.
1588         * progspace.c (print_program_space): Update.
1589         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1590         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1591         do_field_int.  Change type of "value".
1592         * mi/mi-out.c (mi_ui_out::do_table_begin)
1593         (mi_ui_out::do_table_header): Update.
1594         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1595         type of "value".
1596         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1597         (mi_cmd_data_list_changed_registers, output_register)
1598         (mi_cmd_data_read_memory, mi_load_progress)
1599         (mi_cmd_trace_frame_collected): Update.
1600         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1601         Update.
1602         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1603         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1604         (mi_cmd_var_list_children, varobj_update_one): Update.
1605         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1606         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1607         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1608         * inferior.c (print_inferior): Update.
1609         * gdb_bfd.c (print_one_bfd): Update.
1610         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1611         Update.
1612         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1613         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1614         do_field_int.  Change type of "value".
1615         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1616         do_field_int.  Change type of "value".
1617         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1618         (print_one_breakpoint_location, print_it_catch_fork)
1619         (print_one_catch_fork, print_it_catch_vfork)
1620         (print_one_catch_vfork, print_it_catch_solib)
1621         (print_it_catch_exec, print_it_ranged_breakpoint)
1622         (print_mention_watchpoint, print_mention_masked_watchpoint)
1623         (bkpt_print_it, update_static_tracepoint): Update.
1624         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1625         * break-catch-syscall.c (print_it_catch_syscall): Update.
1626         * ada-tasks.c (print_ada_task_info): Update.
1627         * ada-lang.c (print_it_exception, print_mention_exception):
1628         Update.
1629
1630 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1631
1632         PR breakpoints/24541
1633         * gdbarch.c: Regenerate.
1634         * gdbarch.h: Regenerate.
1635         * gdbarch.sh: Adjust return type and parameter types for
1636         'stap_adjust_register'.
1637         (i386_stap_adjust_register): Adjust signature and return new
1638         register name.
1639         * stap-probe.c (stap_parse_register_operand): Adjust use of
1640         'gdbarch_stap_adjust_register'.
1641
1642 2019-07-17  Tom Tromey  <tromey@adacore.com>
1643
1644         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1645         declare VEC.
1646         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1647         std::vector.
1648         (struct s390_process_info): Add initializers.
1649         (s390_add_process): Use new.
1650         (s390_linux_nat_target::low_forget_process): Use delete.
1651         (s390_linux_nat_target::low_new_fork)
1652         (s390_linux_nat_target::stopped_by_watchpoint)
1653         (s390_linux_nat_target::low_prepare_to_resume)
1654         (s390_linux_nat_target::insert_watchpoint)
1655         (s390_linux_nat_target::insert_hw_breakpoint)
1656         (s390_linux_nat_target::remove_watchpoint)
1657         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1658
1659 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1660
1661         * aarch64-fbsd-nat.c: Include regcache.h.
1662         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1663         argument.
1664         (aarch64_fbsd_nat_target::fetch_registers)
1665         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1666         variable.
1667         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1668
1669 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1670
1671         * fbsd-nat.c: Include gdbarch.h.
1672
1673 2019-07-15  Tom Tromey  <tromey@adacore.com>
1674
1675         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1676
1677 2019-07-15  Tom Tromey  <tromey@adacore.com>
1678
1679         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1680         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1681         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1682         * cli-out.c (cli_ui_out::do_field_int): New method.
1683         * ui-out.c (ui_out::field_unsigned): New method.
1684         * symfile.c (generic_load): Use field_unsigned.
1685         (print_transfer_performance): Likewise.
1686         * record-btrace.c (ui_out_field_uint): Remove.
1687         (btrace_call_history_insn_range, btrace_call_history): Use
1688         field_unsigned.
1689         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1690         field_unsigned.
1691         * ui-out.h (class ui_out) <field_unsigned>: New method.
1692         <do_field_unsigned>: Likewise.
1693
1694 2019-07-15  Tom Tromey  <tromey@adacore.com>
1695
1696         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1697         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1698         * target.c (flash_erase_command): Use field_string.
1699         * infrun.c (print_signal_received_reason): Use field_string.
1700         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1701         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1702         field_string.
1703         * ada-tasks.c (print_ada_task_info): Use field_string.
1704
1705 2019-07-15  Tom Tromey  <tromey@adacore.com>
1706
1707         * target.c (flash_erase_command): Use field_core_addr.
1708         * symfile.c (generic_load): Use field_core_addr.
1709         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1710         Use field_core_addr.
1711         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1712         field_core_addr.
1713
1714 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1715
1716         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1717         value if its desired type is smaller than a CORE_ADDR and signed.
1718
1719 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1722         of changes to field names, and use new is_reference field to
1723         decide if a property is a reference or not.
1724         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1725         field.
1726         (struct dwarf2_property_baton): Update header comment, rename
1727         'referenced_type' to 'property_type' and update comments.
1728         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1729         default property type, store in property baton, update to take
1730         accound of renamed field.
1731         (read_func_scope): Update call to attr_to_dynamic_prop.
1732         (read_array_type): Likewise.
1733         (dwarf2_per_cu_addr_sized_int_type): New function.
1734         (read_subrange_index_type): Move type finding code to
1735         dwarf2_per_cu_addr_sized_int_type.
1736         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1737         (dwarf2_per_cu_addr_type): New function.
1738         (set_die_type): Update calls to attr_to_dynamic_prop.
1739
1740 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * dwarf2read.c (read_subrange_index_type): New function.
1743         (read_subrange_type): Move code into new function and call it.
1744         * gdbtypes.c (create_range_type): Add some asserts.
1745
1746 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1749         update return statements.
1750         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1751         declaration, and update comment to match.
1752         * gdbtypes.c (resolve_dynamic_array): Update call to
1753         dwarf2_evaluate_property to match new return type.
1754
1755 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * valarith.c (value_subscripted_rvalue): Change lowerbound
1758         parameter type from int to LONGEST.
1759         * value.h (value_subscripted_rvalue): Likewise in declaration.
1760
1761 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1762
1763         * cli/cli-utils.c (info_print_command_completer): New function.
1764         * cli/cli-utils.h: Add 'completer.h' include, and forward
1765         declaration for 'struct cmd_list_element'.
1766         (info_print_command_completer): Declare.
1767         * stack.c (_initialize_stack): Add completer for 'info locals' and
1768         'info args'.
1769         * symtab.c (_initialize_symtab): Add completer for 'info
1770         variables' and 'info functions'.
1771         * NEWS: Mention completion for additional info commands.
1772
1773 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * cli/cli-utils.c (extract_info_print_args): Delete.
1776         (extract_arg_maybe_quoted): Delete.
1777         (info_print_options_defs): New variable.
1778         (make_info_print_options_def_group): New function.
1779         (extract_info_print_options): Define new function.
1780         * cli/cli-utils.h (extract_info_print_args): Delete.
1781         (struct info_print_options): New structure.
1782         (extract_info_print_options): Declare new function.
1783         * stack.c (info_locals_command): Update to use new
1784         extract_info_print_options, also add a header comment.
1785         (info_args_command): Likewise.
1786         * symtab.c (info_variables_command): Likewise.
1787         (info_functions_command): Likewise.
1788
1789 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1792         to extract string arguments.
1793         * common/common-utils.c (extract_string_maybe_quoted): New function.
1794         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1795
1796 2019-07-11  Tom Tromey  <tromey@adacore.com>
1797
1798         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1799         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1800         * top.h (gdbinit): Don't declare.
1801         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1802         into...
1803         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1804         * top.c (gdb_init): Don't call init_cli_cmds.
1805         (gdbinit): Remove.
1806         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1807
1808 2019-07-11  Tom Tromey  <tromey@adacore.com>
1809
1810         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1811         after it has been moved.
1812
1813 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1814
1815         * valops.c (value_must_coerce_to_target): Change return type to
1816         bool.
1817         * value.h (value_must_coerce_to_target): Likewise.
1818
1819 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1820
1821         * breakpoint.c (is_hardware_watchpoint): Remove
1822         forward-declaration.
1823         (is_masked_watchpoint): Change return type to bool.
1824         (is_tracepoint): Likewise.
1825         (is_breakpoint): Likewise.
1826         (is_hardware_watchpoint): Likewise.
1827         (is_watchpoint): Likewise.
1828         (is_no_memory_software_watchpoint): Likewise.
1829         (is_catchpoint): Likewise.
1830         (breakpoint_1): Make FILTER parameter's return type bool.
1831         is_masked_watchpoint): Change return type to bool.
1832         (save_breakpoints): Make FILTER parameter's return type bool.
1833         * breakpoint.h (is_breakpoint): Change return type to bool.
1834         (is_watchpoint): Likewise.
1835         (is_catchpoint): Likewise.
1836         (is_tracepoint): Likewise.
1837
1838 2019-07-10  Tom Tromey  <tom@tromey.com>
1839
1840         * defs.h: Don't include gdbarch.h.
1841         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1842         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1843         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1844         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1845         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1846         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1847         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1848         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1849         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1850         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1851         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1852         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1853         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1854         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1855         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1856         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1857         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1858         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1859         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1860         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1861         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1862         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1863         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1864         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1865         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1866         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1867         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1868
1869 2019-07-10  Tom Tromey  <tromey@adacore.com>
1870
1871         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1872         * breakpoint.c (init_ada_exception_breakpoint): Register as
1873         bp_catchpoint.
1874         (print_one_breakpoint_location, print_one_breakpoint): Use
1875         is_ada_exception_catchpoint.
1876         * ada-lang.c (class ada_catchpoint_location): Pass
1877         bp_loc_software_breakpoint to bp_location constructor.
1878         (is_ada_exception_catchpoint): New function.
1879
1880 2019-07-10  Tom Tromey  <tromey@adacore.com>
1881
1882         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1883         VEC.
1884         (struct arm_exidx_entry): New method operator<.
1885         (struct arm_exidx_data) <section_maps>: Change type.
1886         (arm_exidx_data_free): Remove.
1887         (arm_exidx_data_key): Change type.  Move lower.
1888         (arm_exidx_new_objfile): Update.
1889         (arm_compare_exidx_entries): Remove.
1890         (arm_find_exidx_entry, _initialize_arm_tdep)
1891
1892 2019-07-10  Tom Tromey  <tromey@adacore.com>
1893
1894         * solib-spu.c (ocl_program_data_key): Change type.
1895         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1896         Update.
1897
1898 2019-07-10  Tom Tromey  <tromey@adacore.com>
1899
1900         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1901         (struct solib_aix_inferior_data) <library_list>: Change type.
1902         (solib_aix_inferior_data_handle): Change type.
1903         (get_solib_aix_inferior_data): Update.
1904         (solib_aix_free_library_list): Remove.
1905         (library_list_start_library): Update.
1906         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1907         return type.
1908         (solib_aix_get_library_list)
1909         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1910         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1911
1912 2019-07-10  Tom Tromey  <tromey@adacore.com>
1913
1914         * solib-dsbt.c (struct dsbt_info): Add initializers.
1915         (solib_dsbt_pspace_data): Change type.
1916         (dsbt_pspace_data_cleanup): Remove.
1917         (get_dsbt_info, _initialize_dsbt_solib): Update.
1918
1919 2019-07-10  Tom Tromey  <tromey@adacore.com>
1920
1921         * spu-tdep.c (spu_overlay_data): Change type.
1922         (spu_get_overlay_table, spu_overlay_new_objfile)
1923         (_initialize_spu_tdep): Update.
1924
1925 2019-07-10  Tom Tromey  <tromey@adacore.com>
1926
1927         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1928         destructor.
1929         (dbx_objfile_data_key): Change type and declare later.
1930         (DBX_SYMFILE_INFO): Rewrite.
1931         * dbxread.c (dbx_objfile_data_key): Change type.
1932         (dbx_symfile_init): Update.
1933         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1934         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1935         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1936
1937 2019-07-10  Tom Tromey  <tromey@adacore.com>
1938
1939         * jit.c (jit_program_space_key): Change type.  Move lower.
1940         (get_jit_program_space_data): Update.
1941         (jit_program_space_data_cleanup): Remove.
1942         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1943         Update.
1944         (struct jit_program_space_data): Add initializers.
1945
1946 2019-07-10  Tom Tromey  <tromey@adacore.com>
1947
1948         * solib-darwin.c (struct darwin_info): Add initializers.
1949         (solib_darwin_pspace_data): Change type.
1950         (darwin_pspace_data_cleanup): Remove.
1951         (get_darwin_info, _initialize_darwin_solib): Update.
1952
1953 2019-07-10  Tom Tromey  <tromey@adacore.com>
1954
1955         * remote-sim.c (struct sim_inferior_data): Add initializers,
1956         constructor, and destructor.
1957         (sim_inferior_data_key): Change type.  Move lower.
1958         (check_for_duplicate_sim_descriptor): Update.
1959         (get_sim_inferior_data): Use new.  Update.
1960         (~sim_inferior_data_cleanup): Rename from
1961         sim_inferior_data_cleanup.  Simplify.
1962         (gdbsim_close_inferior, simulator_command)
1963         (sim_command_completer, _initialize_remote_sim): Update.
1964         (next_pid, INITIAL_PID): Move earlier.
1965
1966 2019-07-10  Tom Tromey  <tromey@adacore.com>
1967
1968         * python/python-internal.h (create_thread_object): Return
1969         gdbpy_ref.
1970         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1971         * python/py-inferior.c (struct threadlist_entry): Add
1972         constructor.
1973         <thread_obj>: Now a gdbpy_ref.
1974         (thread_to_thread_object): Update.
1975         (add_thread_object): Use new.
1976         (delete_thread_object): Use delete.
1977         (infpy_threads): Update.
1978         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1979         GIL.
1980
1981 2019-07-10  Tom Tromey  <tromey@adacore.com>
1982
1983         * valops.c (value_cast): Specialize error message for Ada.
1984
1985 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1986
1987         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1988
1989 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1990
1991         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1992         bpstat_should_step): Return bool, adjust comments.
1993         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1994         bpstat_should_step): Likewise.
1995
1996 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1997
1998         * features/Makefile: Use feature target descriptions for Arm.
1999         * features/arm/arm-core.c: Generate new file.
2000         * features/arm/arm-fpa.c: Likewise.
2001         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2002         * features/arm/arm-m-profile.c: Likewise.
2003         * features/arm/arm-vfpv2.c: Likewise.
2004         * features/arm/arm-vfpv3.c: Likewise.
2005         * features/arm/xscale-iwmmxt.c: Likewise.
2006         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2007
2008 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2009
2010         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2011         ptrace earlier.
2012
2013 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2014
2015         * features/aarch64-pauth.c: Regenerate.
2016
2017 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2018
2019         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2020         bool.
2021         (bpstat_what): Use false instead of 0.
2022
2023 2019-07-09  Pedro Alves  <palves@redhat.com>
2024
2025         * break-catch-throw.c (is_exception_catchpoint): New.
2026         * breakpoint.c (print_one_breakpoint_location): New parameter
2027         'raw_loc'.  Handle it.  Use
2028         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2029         looking at the breakpoint's type.
2030         (print_one_breakpoint): If handling "maint info breakpoints", also
2031         print locations of exception catchpoints.
2032         * breakpoint.h (is_exception_catchpoint): Declare.
2033
2034 2019-07-09  Pedro Alves  <palves@redhat.com>
2035
2036         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2037         "addr" field.
2038         (allocate_location_exception_catchpoint): New.
2039         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2040         (initialize_throw_catchpoint_ops): Install
2041         allocate_location_exception_catchpoint as allocate_location
2042         method.
2043         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2044         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2045         bp_loc_other.
2046         (breakpoint_address_is_meaningful): Delete.
2047         (bl_address_is_meaningful): New.
2048         (breakpoint_locations_match): Adjust comment.
2049         (bp_location_from_bp_type): New, factored out of...
2050         (bp_location::bp_location(breakpoint *)): ... this.
2051         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2052         factored out of...
2053         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2054         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2055         breakpoint_address_is_meaningful.
2056         (bp_locations_compare): Adjust comment.
2057         (update_global_location_list): Use bl_address_is_meaningful
2058         instead of breakpoint_address_is_meaningful.
2059         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2060         explicit.
2061         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2062         * python/py-breakpoint.c (bppy_get_location): No longer check
2063         whether location is null.
2064
2065 2019-07-09  Pedro Alves  <palves@redhat.com>
2066
2067         PR c++/15468
2068         * breakpoint.c (print_one_breakpoint_location): Remove
2069         single-location assert.
2070
2071 2019-07-09  Tom Tromey  <tom@tromey.com>
2072
2073         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2074         * configure: Rebuild.
2075         * configure.ac: Change common to gdbsupport.
2076         * gdbsupport: Rename from common.
2077         * acinclude.m4: Change common to gdbsupport.
2078         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2079         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2080         gdbsupport.
2081         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2082         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2083         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2084         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2085         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2086         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2087         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2088         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2089         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2090         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2091         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2092         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2093         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2094         coff-pe-read.c, command.h, compile/compile-c-support.c,
2095         compile/compile-c.h, compile/compile-cplus-symbols.c,
2096         compile/compile-cplus-types.c, compile/compile-cplus.h,
2097         compile/compile-loc2c.c, compile/compile.c, completer.c,
2098         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2099         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2100         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2101         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2102         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2103         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2104         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2105         features/aarch64-core.c, features/aarch64-fpu.c,
2106         features/aarch64-pauth.c, features/aarch64-sve.c,
2107         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2108         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2109         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2110         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2111         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2112         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2113         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2114         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2115         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2116         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2117         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2118         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2119         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2120         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2121         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2122         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2123         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2124         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2125         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2126         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2127         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2128         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2129         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2130         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2131         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2132         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2133         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2134         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2135         minsyms.c, mips-linux-tdep.c, namespace.h,
2136         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2137         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2138         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2139         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2140         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2141         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2142         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2143         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2144         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2145         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2146         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2147         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2148         procfs.c, producer.c, progspace.h, psymtab.h,
2149         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2150         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2151         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2152         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2153         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2154         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2155         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2156         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2157         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2158         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2159         target-memory.c, target.c, target.h, target/waitstatus.c,
2160         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2161         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2162         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2163         unittests/array-view-selftests.c,
2164         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2165         unittests/common-utils-selftests.c,
2166         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2167         unittests/format_pieces-selftests.c,
2168         unittests/function-view-selftests.c,
2169         unittests/lookup_name_info-selftests.c,
2170         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2171         unittests/mkdir-recursive-selftests.c,
2172         unittests/observable-selftests.c,
2173         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2174         unittests/parse-connection-spec-selftests.c,
2175         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2176         unittests/scoped_fd-selftests.c,
2177         unittests/scoped_mmap-selftests.c,
2178         unittests/scoped_restore-selftests.c,
2179         unittests/string_view-selftests.c, unittests/style-selftests.c,
2180         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2181         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2182         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2183         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2184         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2185         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2186
2187 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2190         bool value.
2191         (decode_digits_ordinary): Set explicit_line field in sal.
2192         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2193         symtab_and_line that was set on an explicit line number in
2194         assembler code.  Do always update the recorded symtab and line if
2195         we do skip the prologue.
2196
2197 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * breakpoint.c (set_breakpoint_location_function): Remove
2200         explicit_loc parameter.
2201         (momentary_breakpoint_from_master): Update call to
2202         set_breakpoint_location_function.
2203         (add_location_to_breakpoint): Likewise.
2204
2205 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2206
2207         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2208         required features based on default bfd type when no specific bfd
2209         is present.
2210
2211 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2212
2213         * NEWS: Mention that GDB printf and eval commands can now print
2214         C-style and Ada-style convenience var strings without
2215         calling the inferior.
2216         * printcmd.c (printf_c_string): Locally print GDB internal var
2217         instead of transiting via the inferior.
2218         (printf_wide_c_string): Likewise.
2219
2220 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2221
2222         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2223
2224 2019-07-04  Tom Tromey  <tom@tromey.com>
2225
2226         PR tui/24724:
2227         * tui/tui-winsource.c (tui_clear_source_content): Update.
2228         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2229         (tui_update_breakpoint_info): Update.
2230         (tui_set_exec_info_content): Update.
2231         * tui/tui-source.c (tui_set_source_content_nil): Update.
2232         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2233         has_break.
2234         * tui/tui-data.h (enum tui_bp_flag): New.
2235         (tui_bp_flags): New enum flags type.
2236         (struct tui_source_element) <break_mode>: Change type.  Rename
2237         from has_break.
2238         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2239         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2240         constants.
2241         * tui/tui-winsource.h: Fix comment.
2242
2243 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2244
2245         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2246         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2247         (store_fpregs_to_thread)
2248         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2249         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2250         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2251         (IWMMXT_REGS_SIZE): Add define.
2252         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2253         (fetch_vfp_regs, store_vfp_regs)
2254         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2255         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2256
2257 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2258
2259         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2260         defines.
2261         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2262         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2263         (ARM_INT_REGISTER_SIZE): ...to this.
2264         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2265         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2266         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2267         (arm_linux_collect_gregset, supply_nwfpe_register)
2268         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2269         defines.
2270         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2271         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2272         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2273         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2274         (arm_return_in_memory, arm_store_return_value)
2275         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2276         (arm_record_ld_st_multiple): Likewise.
2277         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2278         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2279
2280 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2281
2282         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2283         AARCH64_DISPLACED_MODIFIED_INSNS.
2284         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2285         (aarch64_displaced_step_copy_insn): Likewise.
2286         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2287         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2288         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2289         ARM_DISPLACED_MODIFIED_INSNS.
2290         * arm-tdep.c (arm_gdbarch_init): Likewise.
2291         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2292         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2293         (struct arm_displaced_step_closure): Use
2294         ARM_DISPLACED_MODIFIED_INSNS.
2295
2296 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2297
2298         * features/Makefile: Remove unused xml files.
2299         * features/aarch64.xml: Remove.
2300         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2301         * features/i386/amd64-avx-avx512.xml: Remove.
2302         * features/i386/amd64-avx-linux.xml: Remove.
2303         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2304         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2305         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2306         * features/i386/amd64-avx-mpx.xml: Remove.
2307         * features/i386/amd64-avx.xml: Remove.
2308         * features/i386/amd64-linux.xml: Remove.
2309         * features/i386/amd64-mpx-linux.xml: Remove.
2310         * features/i386/amd64-mpx.xml: Remove.
2311         * features/i386/amd64.xml: Remove.
2312         * features/i386/i386-avx-avx512-linux.xml: Remove.
2313         * features/i386/i386-avx-avx512.xml: Remove.
2314         * features/i386/i386-avx-linux.xml: Remove.
2315         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2316         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2317         * features/i386/i386-avx-mpx-linux.xml: Remove.
2318         * features/i386/i386-avx-mpx.xml: Remove.
2319         * features/i386/i386-avx.xml: Remove.
2320         * features/i386/i386-linux.xml: Remove.
2321         * features/i386/i386-mmx-linux.xml: Remove.
2322         * features/i386/i386-mmx.xml: Remove.
2323         * features/i386/i386-mpx-linux.xml: Remove.
2324         * features/i386/i386-mpx.xml: Remove.
2325         * features/i386/i386.xml: Remove.
2326         * features/i386/x32-avx-avx512-linux.xml: Remove.
2327         * features/i386/x32-avx-linux.xml: Remove.
2328         * features/i386/x32-linux.xml: Remove.
2329
2330 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2331
2332         * regformats/aarch64.dat: Remove.
2333         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2334         * regformats/i386/amd64-avx-linux.dat: Remove.
2335         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2336         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2337         * regformats/i386/amd64-linux.dat: Remove.
2338         * regformats/i386/amd64-mpx-linux.dat: Remove.
2339         * regformats/i386/amd64.dat: Remove.
2340         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2341         * regformats/i386/i386-avx-linux.dat: Remove.
2342         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2343         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2344         * regformats/i386/i386-linux.dat: Remove.
2345         * regformats/i386/i386-mmx-linux.dat: Remove.
2346         * regformats/i386/i386-mpx-linux.dat: Remove.
2347         * regformats/i386/i386.dat: Remove.
2348         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2349         * regformats/i386/x32-avx-linux.dat: Remove.
2350         * regformats/i386/x32-linux.dat: Remove.
2351
2352 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2353
2354         * aarch64-tdep.c: Remove xml self tests.
2355         * amd64-linux-tdep.c: Likewise.
2356         * amd64-tdep.c: Likewise.
2357         * i386-linux-tdep.c: Likewise.
2358         * i386-tdep.c: Likewise.
2359
2360 2019-07-03  Pedro Alves  <palves@redhat.com>
2361
2362         PR cli/24732
2363         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2364         (pipe_cmd_option_defs): New.
2365         (make_pipe_cmd_options_def_group): New.
2366         (pipe_command): Use gdb::option::process_options.
2367         (pipe_command_completer): New function.
2368         (_initialize_cli_cmds): Install completer for "pipe" command.
2369
2370 2019-07-03  Pedro Alves  <palves@redhat.com>
2371
2372         * cli/cli-option.c (union option_value) <string>: New field.
2373         (struct option_def_and_value): Add ctor, move ctor, dtor and
2374         use DISABLE_COPY_AND_ASSIGN.
2375         (option_def_and_value::clear_value): New.
2376         (parse_option, save_option_value_in_ctx, get_val_type_str)
2377         (add_setshow_cmds_for_options): Handle var_string.
2378         * cli-option.h (union option_def::var_address) <string>: New
2379         field.
2380         (struct string_option_def): New.
2381         * maint-test-options.c (struct test_options_opts): Add default
2382         ctor and use DISABLE_COPY_AND_ASSIGN.
2383         <string_opt>: New field.
2384         (test_options_opts::~test_options_opts): New.
2385         (test_options_opts::dump): Also dump "-string".
2386         (test_options_option_defs): Install "string.
2387
2388 2019-07-03  Pedro Alves  <palves@redhat.com>
2389
2390         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2391         option_value with a null enumeration.
2392         (complete_options): Save the option values in the context.
2393         (save_option_value_in_ctx): New, factored out from ...
2394         (process_options): ... here.
2395         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2396         of the function.
2397         * maint-test-options.c (test_options_opts::dump): New, factored
2398         out from ...
2399         (maintenance_test_options_command_mode): ... here.
2400         (maintenance_test_options_command_completion_result): Delete.
2401         (maintenance_test_options_command_completion_text): Update
2402         comment.
2403         (maintenance_show_test_options_completion_result): Change
2404         prototype.  Just print
2405         maintenance_test_options_command_completion_text.
2406         (save_completion_result): New.
2407         (maintenance_test_options_completer_mode): Pass options context to
2408         complete_options, and then save a dump.
2409         (_initialize_maint_test_options): Use add_cmd to install "maint
2410         show test-options-completion-result".
2411
2412 2019-07-03  Pedro Alves  <palves@redhat.com>
2413
2414         * NEWS (New commands): Mention "with" and "maint with".
2415         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2416         (with_command, with_command_completer): New.
2417         (pipe_command): Adjust to new repeat_previous
2418         interface.
2419         (_initialize_cli_cmds): Install the "with" command and its "w"
2420         alias.
2421         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2422         declarations.
2423         * cli/cli-setshow.c (parse_cli_var_uinteger)
2424         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2425         argument strings for all var_types.
2426         (get_setshow_command_value_string): New, factored out from ...
2427         (do_show_command): ... this.
2428         * cli/cli-setshow.h: Include <string>.
2429         (get_setshow_command_value_string): Declare.
2430         * command.h (repeat_previous): Now returns const char *.  Adjust
2431         comment.
2432         * maint.c: Include "cli/cli-cmds.h".
2433         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2434         (_initialize_maint_cmds): Register the "maintenance with" command.
2435         * top.c (repeat_previous): Move bits from pipe_command here:
2436         Return the saved command line, if any; error out if there's no
2437         command to relaunch.
2438
2439 2019-07-03  Pedro Alves  <palves@redhat.com>
2440
2441         * NEWS (New commands): Mention "maint set/show test-settings"
2442         instead of "maint test-settings".
2443         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2444         (maintenance_test_settings_set_list): Rename to ...
2445         (maintenance_set_test_settings_list): ... this.
2446         (maintenance_test_settings_show_list): Rename to  ...
2447         (maintenance_show_test_settings_list): ... this.
2448         (maintenance_test_settings_cmd): Delete.
2449         (maintenance_test_settings_set_cmd): ...
2450         (maintenance_set_test_settings_cmd): ... this.
2451         (maintenance_test_settings_show_cmd): ...
2452         (maintenance_show_test_settings_cmd): ... this.
2453         (maintenance_test_settings_show_value_cmd):
2454         (maintenance_show_test_settings_value_cmd): ... this.
2455         (_initialize_maint_test_settings): No longer install the "maint
2456         test-settings" prefix command.  Rename "maint test-settings set"
2457         to "maint set test-settings", and "maint test-settings show" to
2458         "maint show test-settings".  Adjust all subcommands.
2459
2460 2019-07-03  Pedro Alves  <palves@redhat.com>
2461
2462         * maint-test-settings.c: Fix file's intro comment.  Replace all
2463         references to "test-options" with references to "test-settings",
2464         in comments.
2465
2466 2019-07-03  Pedro Alves  <palves@redhat.com>
2467
2468         * maint-test-settings.c (maintenance_test_settings_xxx)
2469         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2470         New.
2471         (maintenance_test_settings_enums): Use them.
2472         (maintenance_test_settings_enum): Default to
2473         maintenance_test_settings_xxx.
2474         (_initialize_maint_test_settings): Initialize
2475         MAINTENANCE_TEST_SETTINGS_FILENAME.
2476
2477 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2478
2479         * breakpoint.h (remove_breakpoints_inf): Change return type to
2480         void, move function documentation here.
2481         * breakpoint.c (remove_breakpoints_inf): Change return type to
2482         void, move function documentation to header.
2483
2484 2019-07-02  Pedro Alves  <palves@redhat.com>
2485
2486         * NEWS (Completion improvements): Mention "info threads".
2487         * thread.c (struct info_threads_opts, info_threads_option_defs)
2488         (make_info_threads_options_def_group): New.
2489         (info_threads_command): Use gdb::option::process_options.
2490         (info_threads_command_completer): New.
2491         (_initialize_thread): Use gdb::option::build_help to build the
2492         help text for "info threads".
2493
2494 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2495
2496         * defs.h (generic_load): Move from here...
2497         * symfile.h (generic_load): ... to here.  Rename name parameter
2498         to args.
2499         * symfile.c (generic_load): Add comment.
2500
2501 2019-07-01  Tom Tromey  <tromey@adacore.com>
2502
2503         * dwarf2read.c
2504         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2505         declaration of without_params.  Fix formatting.
2506
2507 2019-07-01  Tom Tromey  <tromey@adacore.com>
2508
2509         * ada-exp.y (find_primitive_type): Update.
2510         * ada-lang.h (ada_lookup_symbol): Update.
2511         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2512         parameter.
2513         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2514
2515 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2516
2517         PR breakpoints/24541
2518         * gdbarch.c: Regenerate.
2519         * gdbarch.h: Regenerate.
2520         * gdbarch.sh: Add 'stap_adjust_register'.
2521         * i386-tdep.c: Include '<unordered_set>'.
2522         (i386_stap_adjust_register): New function.
2523         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2524         * stap-probe.c (stap_parse_register_operand): Call
2525         'gdbarch_stap_adjust_register'.
2526
2527 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2528
2529         PR python/24742
2530         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2531         * python/python.c (do_start_initialization): Use 'xmalloc'
2532         instead of 'PyMem_Malloc'.
2533
2534 2019-06-28  Tom Tromey  <tromey@adacore.com>
2535
2536         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2537         for Ada.
2538
2539 2019-06-27  Tom Tromey  <tromey@adacore.com>
2540
2541         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2542         objfile_key.
2543         (arm_find_mapping_symbol, arm_record_special_symbol)
2544         (_initialize_arm_tdep): Update.
2545         (arm_objfile_data_free): Remove.
2546
2547 2019-06-27  Tom Tromey  <tromey@adacore.com>
2548
2549         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2550         to cp_print_static_field.
2551
2552 2019-06-26  Tom Tromey  <tromey@adacore.com>
2553
2554         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2555         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2556         declare.
2557
2558 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2559
2560         * features/aarch64-core.c (create_feature_aarch64_core):
2561         Regenerate.
2562         * features/aarch64-core.xml: Add cpsr flags.
2563
2564 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2565
2566         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2567         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2568
2569 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2570
2571         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2572         field.
2573         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2574         use.
2575         (arm_record_special_symbol): Don't insert new symbol in sorted
2576         position, push it at the end.
2577
2578 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2579
2580         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2581         (arm_mapping_symbol_s): Remove.
2582         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2583         (arm_mapping_symbol_vec): New typedef.
2584         (struct arm_per_objfile): Add constructor.
2585         <section_maps>: Change type to
2586         std::unique_ptr<arm_mapping_symbol_vec[]>.
2587         (arm_compare_mapping_symbols): Remove.
2588         (arm_find_mapping_symbol): Adjust to section_maps type change.
2589         (arm_objfile_data_free): Call delete on arm_per_objfile.
2590         (arm_record_special_symbol): Adjust to section_maps type change.
2591         Allocate arm_per_objfile with new.
2592
2593 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2594
2595         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2596         with the command prefix.
2597
2598 2019-06-25  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2601         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2606         type.
2607         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2608         protected.
2609
2610 2019-06-25  Tom Tromey  <tom@tromey.com>
2611
2612         * tui/tui-winsource.c
2613         (tui_source_window_base::set_is_exec_point_at): Add check against
2614         LOA_ADDRESS.
2615
2616 2019-06-25  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-source.c (tui_set_source_content): Don't check before
2619         xfree.
2620         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2621
2622 2019-06-25  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-winsource.h (tui_update_source_window_as_is)
2625         (tui_alloc_source_buffer, tui_line_is_displayed)
2626         (tui_addr_is_displayed): Change type of win_info.
2627         * tui/tui-winsource.c (tui_update_source_window_as_is)
2628         (tui_clear_source_content, tui_show_source_line)
2629         (tui_show_source_content, tui_source_window_base::refill)
2630         (tui_source_window_base::set_is_exec_point_at)
2631         (tui_source_window_base::set_is_exec_point_at)
2632         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2633         (tui_alloc_source_buffer, tui_line_is_displayed)
2634         (tui_addr_is_displayed): Change type of win_info.  Update.
2635         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2636         (tui_source_window_base::do_make_visible_with_new_height):
2637         Update.
2638         * tui/tui-source.c (tui_set_source_content)
2639         (tui_set_source_content_nil)
2640         (tui_source_window::do_scroll_vertical): Update.
2641         * tui/tui-layout.c (show_layout): Update.
2642         * tui/tui-disasm.c (tui_set_disassem_content)
2643         (tui_disasm_window::do_scroll_vertical): Update.
2644         * tui/tui-data.h (tui_win_content): Remove.
2645         (struct tui_gen_win_info) <content, content_size>: Remove.
2646         (struct tui_source_element): Add initializers and destructor.
2647         (union tui_which_element, struct tui_win_element): Remove.
2648         (struct tui_source_window_base) <content>: New field.
2649         (struct tui_data_window): Remove destructor.
2650         (tui_alloc_content, tui_free_win_content)
2651         (tui_free_all_source_wins_content): Don't declare.
2652         * tui/tui-data.c (tui_initialize_static_data): Update.
2653         (init_content_element, tui_alloc_content): Remove.
2654         (~tui_gen_win_info): Update.
2655         (~tui_data_window, tui_free_all_source_wins_content)
2656         (tui_free_win_content, free_content, free_content_elements):
2657         Remove.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-winsource.h (tui_clear_source_content)
2662         (tui_erase_source_content, tui_show_source_content): Change type
2663         of win_info.
2664         * tui/tui-winsource.c (tui_clear_source_content)
2665         (tui_erase_source_content, tui_show_source_content): Change type
2666         of win_info.
2667         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2668         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2669         win_info.
2670         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2671         win_info.
2672         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2673
2674 2019-06-25  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui-winsource.c (tui_clear_source_content)
2677         (tui_source_window_base::set_is_exec_point_at): Update.
2678         * tui/tui-source.c (tui_set_source_content_nil): Update.
2679         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2680         a bool.
2681         * tui/tui-data.c (init_content_element): Update.
2682
2683 2019-06-25  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2686         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2687         * tui/tui-layout.c (init_and_make_win): Update.
2688         * tui/tui.h (enum tui_win_type): Update.
2689         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2690         tui_win_is_auxillary.
2691         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2692         tui_win_is_auxillary.
2693
2694 2019-06-25  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2697         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2698         (tui_delete_data_content_windows, tui_display_all_data)
2699         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2700         Update.
2701         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2702         * tui/tui-regs.c (tui_last_regs_line_no)
2703         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2704         (tui_show_registers): Update.
2705         (tui_show_register_group): Return void.  Update.
2706         (tui_display_registers_from, tui_display_reg_element_at_line)
2707         (tui_display_registers_from_line, tui_check_register_values):
2708         Update.
2709         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2710         member.
2711         (struct tui_data_window) <regs_content>: Now a std::vector.
2712         <regs_content_count>: Remove.
2713         (tui_add_content_elements, tui_free_data_content): Don't declare.
2714         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2715         (init_content_element): Remove DATA_WIN case.  Add assert.
2716         (tui_add_content_elements): Remove.
2717         (tui_data_window): Update.
2718         (tui_free_data_content): Remove.
2719         (free_content_elements): Remove DATA_WIN case.
2720
2721 2019-06-25  Tom Tromey  <tom@tromey.com>
2722
2723         * tui/tui-data.c (tui_data_item_window): Update.
2724         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2725         * tui/tui-windata.c (tui_display_all_data)
2726         (tui_display_data_from_line): Update.
2727         (tui_check_data_values): Remove.
2728         * tui/tui-regs.c (tui_show_register_group)
2729         (tui_display_reg_element_at_line): Update.
2730         * tui/tui-hooks.c (tui_register_changed)
2731         (tui_refresh_frame_and_register_information): Call
2732         tui_check_register_values.
2733         * tui/tui-data.h (struct tui_data_window) <data_content,
2734         data_content_count, data_type>: Remove.
2735         (enum tui_data_type): Remove.
2736
2737         * tui/tui-data.c (tui_data_window::clear_detail)
2738         (~tui_data_window): Update.
2739
2740 2019-06-25  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2743         declare.
2744         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2745         Rename from tui_first_data_item_displayed.  Update.
2746         (tui_data_window::refresh_all)
2747         (tui_data_window::do_scroll_vertical): Update.
2748         * tui/tui-data.h (struct tui_data_window)
2749         <first_data_item_displayed>: Declare new method.
2750
2751 2019-06-25  Tom Tromey  <tom@tromey.com>
2752
2753         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2754         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2755         contents...
2756         (tui_initialize_static_data): ...here.
2757
2758 2019-06-25  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2761         (tui_display_registers_from, tui_check_register_values): Update.
2762         (tui_display_register): Remove win_info parameter; update.
2763         (tui_get_register): Change type of parameters.
2764         * tui/tui-data.h (struct tui_data_element): Remove.
2765         (union tui_which_element) <data>: Remove.
2766         <data_window>: Change type.
2767         (struct tui_data_item_window): New.
2768         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2769         case.  Add assert.
2770         (~tui_data_item_window): New destructor.
2771         (free_content_elements): Remove DATA_ITEM_WIN case.
2772
2773 2019-06-25  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2776         Remove.
2777
2778 2019-06-25  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui-data.h (struct tui_command_element): Remove.
2781         (union tui_which_element) <command>: Remove.
2782         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2783         assert.
2784         (free_content_elements): Remove CMD_WIN case.
2785
2786 2019-06-25  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-layout.c (tui_set_layout): Update.
2789         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2790         * tui/tui-data.c (layout_def): Update.
2791
2792 2019-06-25  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2795         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2796         (tui_source_window_base::set_new_height): Update.
2797         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2798         Update.
2799         (tui_set_locator_fullname, tui_set_locator_info)
2800         (tui_show_frame_info): Update.
2801         * tui/tui-source.c (tui_set_source_content)
2802         (tui_source_is_displayed): Update.
2803         * tui/tui-layout.c (show_source_disasm_command, show_data)
2804         (show_source_or_disasm_and_command): Update.
2805         * tui/tui-disasm.c (tui_set_disassem_content)
2806         (tui_get_begin_asm_address): Update.
2807         * tui/tui-data.h (struct tui_locator_element): Remove.
2808         (union tui_which_element) <locator>: Remove.
2809         (struct tui_locator_window): New.
2810         (tui_locator_win_info_ptr): Change return type.
2811         * tui/tui-data.c (_locator): Change type.
2812         (tui_locator_win_info_ptr): Change return type.
2813         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2814         (tui_alloc_content): Add assert.
2815
2816 2019-06-25  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-winsource.c
2819         (tui_exec_info_window::maybe_allocate_content): New method.
2820         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2821         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2822         (make_source_or_disasm_window): Add cast.
2823         * tui/tui-data.h (union tui_which_element) <simple_string>:
2824         Remove.
2825         (struct tui_source_info): New.
2826         (struct tui_source_window_base) <execution_info>: Change type.
2827         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2828         case, and add assert.
2829         (tui_alloc_content): Add assert.
2830
2831 2019-06-25  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2834         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2835         * tui/tui-data.c (tui_alloc_win_info): Remove.
2836
2837 2019-06-25  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2840         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2841         can_highlight.
2842
2843 2019-06-25  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2846         make_visible_with_new_height method.
2847         (tui_win_info::make_visible_with_new_height): New method.
2848         (tui_source_window_base::do_make_visible_with_new_height)
2849         (tui_data_window::do_make_visible_with_new_height)
2850         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2851         (make_visible_with_new_height): Remove.
2852         (tui_resize_all, tui_adjust_win_heights): Use
2853         make_visible_with_new_height method.
2854         * tui/tui-data.h (struct tui_win_info)
2855         <do_make_visible_with_new_height, make_visible_with_new_height>:
2856         New methods.
2857         (struct tui_source_window_base, struct tui_data_window)
2858         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2859         methods.
2860
2861 2019-06-25  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2864         method.
2865         (update_tab_width): Call update_tab_width method.
2866         * tui/tui-data.h (struct tui_win_info)
2867         (struct tui_source_window_base) <update_tab_width>: New methods.
2868
2869 2019-06-25  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2872         parameter.
2873         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2874         parameter.
2875         (tui_gen_win_info::make_visible): Update.
2876         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2877         parameter.
2878         * tui/tui-data.h (enum tui_box): New enum.
2879         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2880
2881 2019-06-25  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2884         init_and_make_win for EXEC_INFO_WIN.
2885         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2886         longer inline.
2887         (struct tui_win_info) <~tui_win_info>: Inline.
2888         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2889         Don't declare.
2890         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2891         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2892         Remove.
2893         (tui_initialize_static_data): Update.
2894         (~tui_gen_win_info): Handle more cleanup here.
2895         (~tui_source_window_base): Delete "execution_info".
2896         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-layout.c (make_command_window): Don't set
2901         can_highlight.
2902         (show_source_disasm_command): Call the reset method.
2903         (show_data): Don't set can_highlight.  Call the reset method.
2904         (tui_gen_win_info::reset): Rename from init_gen_win_info
2905         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2906         (show_source_or_disasm_and_command): Call the reset method.
2907         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2908         (struct tui_cmd_window): Set can_highlight.
2909
2910 2019-06-25  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2913         from make_visible.
2914         (tui_make_visible, tui_make_invisible): Rewrite.
2915         (tui_win_info::make_visible): Remove.
2916         (tui_source_window_base::make_visible): Update.
2917         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2918         method.  Moved from...
2919         (struct tui_win_info) <make_visible>: ...here.
2920
2921 2019-06-25  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-winsource.c
2924         (tui_source_window_base::do_scroll_horizontal): Remove direction
2925         parameter.
2926         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2927         direction parameter.
2928         * tui/tui-win.c (tui_win_info::forward_scroll)
2929         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2930         (tui_win_info::right_scroll): Update.
2931         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2932         direction parameter.
2933         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2934         direction parameter.
2935         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2936         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2937         Remove direction parameter.
2938         (struct tui_source_window_base, struct tui_source_window)
2939         (struct tui_disasm_window, struct tui_data_window)
2940         (struct tui_cmd_window): Update.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-winsource.h (tui_set_exec_info_content)
2945         (tui_show_exec_info_content, tui_erase_exec_info_content)
2946         (tui_clear_exec_info_content, tui_update_exec_info): Change
2947         argument to tui_source_window_base.
2948         * tui/tui-winsource.c (tui_set_exec_info_content)
2949         (tui_show_exec_info_content, tui_erase_exec_info_content)
2950         (tui_clear_exec_info_content, tui_update_exec_info): Change
2951         argument to tui_source_window_base.
2952
2953 2019-06-25  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2956         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2957
2958 2019-06-25  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2961         check.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2966         type to void.
2967         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2968         type to void.
2969         * tui/tui-source.c (tui_set_source_content): Update.
2970         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-win.c (window_name_completer, tui_set_focus)
2975         (tui_all_windows_info): Use name method.
2976         * tui/tui-data.h (struct tui_gen_win_info)
2977         (struct tui_source_window, struct tui_disasm_window)
2978         (struct tui_data_window, struct tui_cmd_window) <name>: New
2979         method.
2980         (tui_win_name): Don't declare.
2981         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2982         (tui_win_name): Remove.
2983
2984 2019-06-25  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-winsource.h (tui_update_source_window)
2987         (tui_update_source_window_as_is): Change parameter type.
2988         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2989         to be a tui_source_window_base.
2990         (tui_update_source_window_as_is): Likewise.
2991         * tui/tui-win.c (make_visible_with_new_height): Update.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-winsource.c (tui_erase_source_content)
2996         (tui_show_source_content, tui_show_exec_info_content)
2997         (tui_erase_exec_info_content): Use refresh_window method.
2998         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2999         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3000         from tui_refresh_win.
3001         (tui_data_window::refresh_window): New method.
3002         (tui_win_info::refresh, tui_source_window_base::refresh)
3003         (tui_refresh_all): Use refresh_window method.
3004         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3005         method.
3006         * tui/tui-regs.c (tui_display_register): Call refresh_window
3007         method.
3008         * tui/tui-layout.c (show_source_disasm_command)
3009         (show_source_or_disasm_and_command): Call refresh_window method.
3010         * tui/tui-data.h (struct tui_gen_win_info)
3011         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3012         New method.
3013
3014 2019-06-25  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui.c (tui_rl_other_window, tui_enable)
3017         (tui_is_window_visible, tui_get_command_dimension): Update.
3018         * tui/tui-winsource.c (tui_update_source_window_as_is)
3019         (tui_clear_source_content, tui_erase_source_content)
3020         (tui_show_source_line, tui_source_window_base::refill)
3021         (tui_source_window_base::do_scroll_horizontal)
3022         (tui_source_window_base::set_is_exec_point_at)
3023         (tui_update_breakpoint_info, tui_set_exec_info_content)
3024         (tui_alloc_source_buffer, tui_line_is_displayed)
3025         (tui_addr_is_displayed): Update.
3026         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3027         (tui_check_and_display_highlight_if_needed)
3028         (tui_win_info::make_visible, tui_win_info::refresh)
3029         (tui_refresh_all): Update.
3030         * tui/tui-windata.c (tui_first_data_item_displayed)
3031         (tui_delete_data_content_windows, tui_erase_data_content)
3032         (tui_display_all_data, tui_data_window::refresh_all)
3033         (tui_check_data_values): Update.
3034         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3035         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3036         (tui_win_info::backward_scroll, tui_refresh_all_win)
3037         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3038         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3039         (tui_source_window_base::set_new_height)
3040         (tui_data_window::set_new_height)
3041         (make_invisible_and_set_new_height)
3042         (make_visible_with_new_height, new_height_ok)
3043         (parse_scrolling_args): Update.
3044         * tui/tui-stack.c (tui_show_frame_info): Update.
3045         * tui/tui-source.c (tui_set_source_content)
3046         (tui_set_source_content_nil, tui_source_is_displayed)
3047         (tui_source_window::do_scroll_vertical): Update.
3048         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3049         (tui_display_registers_from, tui_display_reg_element_at_line)
3050         (tui_check_register_values, tui_reg_command): Update.
3051         * tui/tui-layout.c (tui_default_win_height)
3052         (show_source_disasm_command, show_data, init_and_make_win)
3053         (show_source_or_disasm_and_command): Update.
3054         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3055         (tui_redisplay_readline, tui_mld_flush)
3056         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3057         (tui_getc): Update.
3058         * tui/tui-disasm.c (tui_set_disassem_content)
3059         (tui_disasm_window::do_scroll_vertical): Update.
3060         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3061         Now virtual.
3062         (struct tui_win_info): Derive from tui_gen_win_info.
3063         <~tui_win_info>: Mark as override.
3064         <generic>: Remove member.
3065         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3066         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3067         (~tui_data_window, ~tui_win_info)
3068         (tui_free_all_source_wins_content): Update.
3069         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3070
3071 2019-06-25  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-layout.c (init_and_make_win): Use new.
3074         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3075         destructor, initializers.
3076         (tui_alloc_generic_win_info): Don't declare.
3077         * tui/tui-data.c (_locator): Add argument to constructor.
3078         (source_win, disasm_win): New globals.
3079         (exec_info): Remove.
3080         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3081         Update.
3082         (tui_alloc_generic_win_info): Remove.
3083         (init_content_element): Use new.
3084         (tui_win_info::tui_win_info): Update.
3085         (free_content_elements) <case DATA_WIN>: Use delete.
3086
3087 2019-06-25  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3090         * tui/tui-windata.c (tui_first_data_item_displayed)
3091         (tui_delete_data_content_windows): Update.
3092         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3093         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3094         (tui_display_registers_from, tui_check_register_values): Update.
3095         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3096         pointer.
3097         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3098         window.
3099         (tui_free_data_content): Update.
3100         (free_content_elements) <case DATA_WIN>: Free the window.
3101
3102 2019-06-25  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3105         Update.
3106         * tui/tui-layout.c (make_command_window)
3107         (show_source_disasm_command, show_data, init_and_make_win)
3108         (show_source_or_disasm_and_command): Update.
3109         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3110         method.
3111         <can_highight, is_highlighted>: Now bool.
3112         (tui_set_win_highlight): Don't declare.
3113         * tui/tui-data.c (tui_set_win_highlight): Remove.
3114
3115 2019-06-25  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-wingeneral.c (make_visible): Remove check of window
3118         type.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-win.c (tui_win_info::max_height)
3123         (tui_cmd_window::max_height): New methods.
3124         (new_height_ok): Call max_height.
3125         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3126         <max_height>: New method.
3127
3128 2019-06-25  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-win.c (tui_source_window_base::set_new_height)
3131         (tui_data_window::set_new_height): New methods.
3132         (make_invisible_and_set_new_height): Call set_new_height method.
3133         * tui/tui-data.h (struct tui_win_info)
3134         (struct tui_source_window_base, struct tui_data_window)
3135         <set_new_height>: New method.
3136
3137 2019-06-25  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3140         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3141         tui_refresh_data_win.
3142         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3143         method.
3144         (tui_refresh_all_win): Call the refresh_all method.
3145         (tui_set_focus): Likewise.
3146         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3147         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3148         Likewise.
3149
3150 2019-06-25  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-winsource.h (tui_refill_source_window)
3153         (tui_set_is_exec_point_at): Don't declare.
3154         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3155         (tui_source_window_base::refill): Rename from
3156         tui_refill_source_window.
3157         (tui_source_window_base::do_scroll_horizontal): Update.
3158         (tui_source_window_base::set_is_exec_point_at): Rename from
3159         tui_set_is_exec_point_at.
3160         (tui_update_all_breakpoint_info): Update.
3161         * tui/tui-stack.c (tui_show_frame_info): Update.
3162         * tui/tui-layout.c (show_data): Add cast.
3163         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3164         * tui/tui-data.h (struct tui_source_window_base) <refill,
3165         set_is_exec_point_at>: New methods.
3166         (tui_source_windows, tui_add_to_source_windows): Update types.
3167         (tui_add_to_source_windows): Remove redundant declaration.
3168         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3169         (tui_source_windows): Change return type.
3170         (tui_clear_source_windows_detail): Update.
3171         (tui_add_to_source_windows): Change type of parameter.
3172         (tui_free_all_source_wins_content): Update.
3173
3174 2019-06-25  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-wingeneral.c (tui_win_info::refresh)
3177         (tui_source_window_base::refresh): New methods.
3178         (tui_refresh_all): Call the refresh method.
3179         * tui/tui-data.h (struct tui_win_info)
3180         (struct tui_source_window_base) <refresh>: New method.
3181
3182 2019-06-25  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui.h (tui_is_window_visible): Return bool.
3185         * tui/tui.c (tui_is_window_visible): Return bool.
3186         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3187         (tui_make_visible, tui_make_invisible)
3188         (tui_win_info::make_visible)
3189         (tui_source_window_base::make_visible, make_all_visible)
3190         (tui_make_all_visible, tui_make_all_invisible): Update.
3191         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3192         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3193         bool.
3194         (struct tui_win_info, struct tui_source_window_base)
3195         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3196         * tui/tui-data.c (tui_init_generic_part): Update.
3197
3198 2019-06-25  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3201         (tui_source_window_base::make_visible): New methods.
3202         (make_all_visible): Make method call.
3203         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3204         (struct tui_source_window_base, struct tui_cmd_window): Override
3205         make_visible.
3206         (tui_win_is_source_type): Don't declare.
3207         * tui/tui-data.c (tui_win_is_source_type): Remove.
3208
3209 2019-06-25  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3212         NULL check.
3213
3214 2019-06-25  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3217         Inline constructor.  Add initializers for members.
3218         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3219         constructors; now inline in class.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-regs.c (tui_show_registers): Update.
3224         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3225         bool.
3226         * tui/tui-data.c (tui_data_window::clear_detail)
3227         (tui_data_window): Update.
3228
3229 2019-06-25  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-windata.c (tui_display_all_data)
3232         (tui_display_data_from_line, tui_display_data_from)
3233         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3234         Update.
3235         * tui/tui-regs.c (tui_last_regs_line_no)
3236         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3237         (tui_show_registers, tui_show_register_group)
3238         (tui_display_registers_from, tui_display_reg_element_at_line)
3239         (tui_display_registers_from_line, tui_check_register_values)
3240         (tui_reg_next, tui_reg_prev): Update.
3241         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3242         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3243         tui_data_window.
3244         (struct tui_win_info) <detail>: Remove.  Add new fields from
3245         tui_data_info.
3246         (TUI_DATA_WIN): Add cast.
3247         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3248         (~tui_data_window): Simplify.
3249
3250 2019-06-25  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-layout.c (show_source_disasm_command)
3253         (show_source_or_disasm_and_command): Update.
3254         * tui/tui-io.c (update_cmdwin_start_line)
3255         (tui_redisplay_readline): Update.
3256         * tui/tui-data.h (struct tui_command_info): Remove.
3257         (struct tui_win_info) <detail>: Remove command_info member.
3258         (struct tui_data_window) <start_line>: New member, from
3259         tui_command_info.
3260         (TUI_CMD_WIN): Add casts.
3261
3262 2019-06-25  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-winsource.c (tui_update_source_window)
3265         (tui_refill_source_window)
3266         (tui_source_window_base::do_scroll_horizontal)
3267         (tui_update_breakpoint_info, tui_set_exec_info_content)
3268         (tui_show_exec_info_content, tui_erase_exec_info_content)
3269         (tui_clear_exec_info_content): Update.
3270         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3271         Update.
3272         * tui/tui-win.c (make_invisible_and_set_new_height)
3273         (make_visible_with_new_height): Update.
3274         * tui/tui-source.c (tui_set_source_content)
3275         (tui_show_symtab_source): Update.
3276         * tui/tui-layout.c (extract_display_start_addr)
3277         (show_source_disasm_command, show_data)
3278         (make_source_or_disasm_window)
3279         (show_source_or_disasm_and_command): Update.
3280         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3281         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3282         "gdbarch".
3283         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3284         to tui_source_window_base.
3285         (struct tui_win_info) <detail>: Remove source_info member.
3286         (struct tui_source_window_base) <has_locator>: Inline.
3287         Move contents from tui_source_info; rename has_locator member to
3288         m_has_locator.
3289         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3290         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3291         header file.
3292         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3293         Simplify.
3294         (tui_free_all_source_wins_content): Cast to
3295         tui_source_window_base.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-win.c (make_invisible_and_set_new_height)
3300         (make_visible_with_new_height): Call has_locator method.
3301         * tui/tui-layout.c (show_source_disasm_command, show_data)
3302         (show_source_or_disasm_and_command): Update for bool change.
3303         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3304         (tui_win_info) <has_locator>: New method.
3305         (struct tui_source_window_base) <has_locator>: New method.
3306         (tui_win_has_locator): Don't declare.
3307         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3308         from tui_win_has_locator.
3309         (tui_source_window_base): Use false, not FALSE.
3310
3311 2019-06-25  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3314         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3315         clear_detail method directly.
3316         (tui_clear_win_detail): Remove.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3321         "this", not TUI_DISASM_WIN.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3326         declare.
3327         * tui/tui-winsource.c
3328         (tui_source_window_base::do_scroll_horizontal): Rename from
3329         tui_horizontal_source_scroll.
3330         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3331         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3332         from tui_vertical_data_scroll.
3333         * tui/tui-win.h (tui_scroll): Don't declare.
3334         * tui/tui-win.c (tui_win_info::forward_scroll)
3335         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3336         (tui_win_info::right_scroll): Rename and update.
3337         (tui_scroll_forward_command, tui_scroll_backward_command)
3338         (tui_scroll_left_command, tui_scroll_right_command): Update.
3339         (tui_scroll): Remove.
3340         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3341         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3342         from tui_vertical_source_scroll.
3343         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3344         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3345         from tui_vertical_disassem_scroll.
3346         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3347         do_scroll_horizontal>: New methods.
3348         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3349         Likewise.
3350         (struct tui_source_window_base): Add do_scroll_horizontal.
3351         (struct tui_source_window, struct tui_disasm_window): Add
3352         do_scroll_vertical.
3353         (struct tui_data_window, struct tui_cmd_window): Add
3354         do_scroll_horizontal and do_scroll_vertical.
3355         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-data.h (struct tui_source_window_base): New struct.
3360         (struct tui_source_window): Derive from tui_source_window_base.
3361         (struct tui_disasm_window): New struct.
3362         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3363         from tui_source_window::clear_detail.
3364         (tui_source_window_base): Rename from tui_source_window.
3365         (~tui_source_window_base): Rename from ~tui_source_window.
3366         (tui_alloc_win_info): Create a tui_disasm_window.
3367
3368 2019-06-25  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-data.h (struct tui_source_window)
3371         (struct tui_data_window): Declare destructors.
3372         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3373         destructors.
3374         (tui_win_info): Simplify.
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-winsource.c (tui_display_main)
3379         (tui_update_source_windows_with_addr)
3380         (tui_update_all_breakpoint_info): Update.
3381         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3382         (new_height_ok, parse_scrolling_args): Update.
3383         * tui/tui-stack.c (tui_show_frame_info): Update.
3384         * tui/tui-data.h (struct tui_list): Remove.
3385         (tui_source_windows): Return a reference to a std::vector.
3386         * tui/tui-data.c (source_windows): Now a std::vector.
3387         (tui_source_windows): Change return type.
3388         (tui_clear_source_windows): Rewrite.
3389         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3390         (tui_free_all_source_wins_content): Rewrite.
3391
3392 2019-06-25  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3395         (struct tui_data_window, struct tui_cmd_window): Declare
3396         clear_detail method.
3397         * tui/tui-data.c (tui_source_window::clear_detail)
3398         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3399         methods.
3400         (tui_clear_win_detail): Simplify.
3401
3402 2019-06-25  Tom Tromey  <tom@tromey.com>
3403
3404         * tui/tui-layout.c (make_source_window, make_disasm_window)
3405         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3406         Return the new window.
3407         (show_source_disasm_command, show_data)
3408         (show_source_or_disasm_and_command): Update.
3409
3410 2019-06-25  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3413         parameter.  Return the new window.
3414         (show_source_disasm_command): Update and remove NULL check.
3415         (show_source_or_disasm_and_command): Update.
3416
3417 2019-06-25  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-data.h (struct tui_win_info): Make constructor
3424         protected.  Make destructor virtual.  Add initializers.
3425         (tui_source_window, tui_data_window, tui_cmd_window): New
3426         classes.
3427         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3428         constructor.  Add "type" parameter.
3429         (tui_source_window, tui_data_window, tui_cmd_window): New
3430         constructors.
3431         (tui_alloc_win_info): Instantiate the appropriate subclass.
3432
3433 2019-06-25  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-win.c (tui_resize_all): Use delete.
3436         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3437         destructor.
3438         (tui_free_window): Don't declare.
3439         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3440         Update.
3441
3442 2019-06-25  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-data.h (struct tui_win_info): Add constructor.
3445         * tui/tui-data.c (tui_alloc_win_info): Use new.
3446         (tui_free_window): Use delete.
3447
3448 2019-06-22  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3451         declare.
3452         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3453
3454 2019-06-22  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3457         declare.
3458         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3459
3460 2019-06-22  Tom de Vries  <tdevries@suse.de>
3461
3462         * dwarf2read.c (create_addrmap_from_aranges)
3463         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3464         instead of '%zu'.
3465
3466 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3467
3468         * dwarf2read.h (dwarf2_section_info_def): Remove.
3469         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3470         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3471         std::vector<dwarf2_section_info>.
3472         (struct dwo_file) <~dwo_file>: Remove.
3473         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3474         types field.
3475         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3476         (dwarf2_read_debug_names): Likewise.
3477         (create_debug_types_hash_table): Change parameter type to
3478         array_view, adjust code accordingly.
3479         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3480         (partial_die_info::fixup): Likewise.
3481         (determine_prefix): Likewise.
3482         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3483
3484 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3485
3486         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3487         gdb_bfd_ref_ptr.
3488         <~dwo_file>: Remove call to gdb_bfd_unref.
3489         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3490         gdb_bfd_ref_ptr::get.
3491
3492 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3493
3494         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3495         type to htab_up.
3496         * dwarf2read.c (struct dwo_file): Initialize fields.
3497         <~dwo_file>: New.
3498         (free_dwo_file): Remove, move content to ~dwo_file.
3499         (struct dwo_file_deleter): Remove.
3500         (dwo_file_up>: Remove custom deleter.
3501         (free_dwo_files): Remove.
3502         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3503         dwo_files.
3504         (process_skeletonless_type_units): Call unique_ptr::get.
3505         (allocate_dwo_file_hash_table): Add deleter to created hash
3506         table.  Change return type to htab_up.
3507         (lookup_dwo_file_slot): Don't memset dwo_file, call
3508         unique_ptr::get.
3509         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3510         (create_dwo_unit_in_dwp_v2): Likewise.
3511         (open_and_init_dwo_file): Likewise.
3512         (free_dwo_file_from_slot): Remove.
3513
3514 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3515
3516         * dwarf2read.h (struct dwarf2_section_info) <readin,
3517         is_virtual>: Change type to bool.
3518         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3519         true instead of 1.
3520
3521 2019-06-19  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-data.h (tui_init_content_element): Don't declare.
3524
3525 2019-06-19  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-data.h (tui_init_win_info): Don't declare.
3528
3529 2019-06-19  Tom de Vries  <tdevries@suse.de>
3530
3531         * dwarf2read.h (abstract_to_concrete): Change type to
3532         std::unordered_map<sect_offset, std::vector<sect_offset>,
3533         gdb::hash_enum<sect_offset>>.
3534
3535 2019-06-19  Tom Tromey  <tromey@adacore.com>
3536
3537         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3538         EVAL_AVOID_SIDE_EFFECTS specially.
3539
3540 2019-06-19  Tom Tromey  <tromey@adacore.com>
3541
3542         * source-cache.c (highlighter): New global.
3543         (source_cache::get_source_lines): Create a highlighter on demand.
3544
3545 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * defs.h (deprecated_interactive_hook): Delete declaration.
3548         * interps.c (clear_interpreter_hooks): Remove use of
3549         deprecated_interactive_hook.
3550         * top.c (deprecated_interactive_hook): Delete definition.
3551         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3552
3553 2019-06-18  Tom de Vries  <tdevries@suse.de>
3554
3555         PR gdb/24515
3556         * dwarf2read.h (abstract_to_concrete): Change type from
3557         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3558         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3559         * dwarf2read.c (read_variable): Update.
3560         (dwarf2_fetch_die_loc_sect_off): Update.
3561
3562 2019-06-17  Tom de Vries  <tdevries@suse.de>
3563
3564         PR gdb/24617
3565         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3566         accessing parent[parent_len - 1].
3567
3568 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3569
3570         PR gdb/24364
3571         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3572         call dtrace_process_dof with NULL dof.
3573
3574 2019-06-16  Tom de Vries  <tdevries@suse.de>
3575
3576         PR gdb/24445
3577         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3578
3579 2019-06-16  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3582         (make_all_visible): Use address of member.
3583
3584 2019-06-16  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3587         (tui_free_window, free_content, free_content_elements): Remove
3588         unnecessary cast.
3589         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3590         cast.
3591         * tui/tui-regs.c (tui_show_register_group)
3592         (tui_display_registers_from, tui_display_reg_element_at_line):
3593         Remove unnecessary cast.
3594
3595 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3596
3597         * linux-nat.c (normal_mask): Delete.
3598         (_initialize_linux_nat): Don't initialise normal_mask.
3599
3600 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3601
3602         PR gdb/24445
3603         * dwarf-index-write.h (write_psymtabs_to_index): Add
3604         dwz_basename parameter.
3605         * dwarf-index-write.c (write_gdbindex): Move file writing to
3606         write_gdbindex_1.  Change return type void.
3607         (assert_file_size): Move up, remove filename parameter.
3608         (write_gdbindex_1): New function.
3609         (write_debug_names): Change return type to void, call
3610         assert_file_size.
3611         (struct index_wip_file): New struct.
3612         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3613         file logic to index_wip_file.  Write index for dwz file if
3614         needed.
3615         (save_gdb_index_command): Pass basename of dwz file, if present.
3616         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3617         build-id of dwz file, if present.
3618         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3619         (dwarf2_get_dwz_file): Likewise.
3620         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3621         (dwarf2_get_dwz_file): Likewise.
3622
3623 2019-06-16  Tom Tromey  <tom@tromey.com>
3624
3625         * coffread.c (process_coff_symbol): Use xstrdup.
3626         * value.c (create_internalvar): Use xstrdup.
3627
3628 2019-06-16  Tom Tromey  <tom@tromey.com>
3629
3630         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3631         * breakpoint.c (stopin_command, stopat_command)
3632         (until_break_command, decode_location_default): Remove unnecessary
3633         cast.
3634         * utils.c (subset_compare): Remove unnecessary cast.
3635         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3636         cast.
3637         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3638         cast.
3639         * infcmd.c (path_command): Remove unnecessary cast.
3640         * coffread.c (decode_type): Remove unnecessary cast.
3641         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3642         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3643         * tui/tui-stack.c (tui_show_locator_content)
3644         (tui_show_frame_info): Remove unnecessary cast.
3645         * tui/tui-win.c (tui_scroll_forward_command)
3646         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3647         (parse_scrolling_args): Remove unnecessary cast.
3648         * tui/tui-data.c (init_win_info, tui_del_window)
3649         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3650         (free_content_elements): Remove unnecessary cast.
3651         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3652         unnecessary cast.
3653         * tui/tui-source.c (tui_set_source_content)
3654         (tui_vertical_source_scroll): Remove unnecessary cast.
3655         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3656         cast.
3657         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3658         * tui/tui-regs.c (tui_display_registers_from)
3659         (tui_display_register): Remove unnecessary cast.
3660         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3661         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3662         (make_visible): Remove unnecessary cast.
3663         * tui/tui-winsource.c (tui_erase_source_content)
3664         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3665         unnecessary cast.
3666         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3667         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3668         * stabsread.c (read_type, read_array_type, read_range_type):
3669         Remove unnecessary cast.
3670         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3671         (parse_symbol, parse_type, upgrade_type, parse_external)
3672         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3673         unnecessary cast.
3674         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3675
3676 2019-06-16  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-data.c (tui_alloc_generic_win_info)
3679         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3680         checks.
3681
3682 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3683             Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * f-typeprint.c (f_print_type): Don't return early for not
3686         associated or not allocated types.
3687         (f_type_print_varspec_suffix): Add print_rank parameter and print
3688         ranks of array types in case they dangling.
3689         (f_type_print_base): Add print_rank parameter.
3690
3691 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * NEWS: Mention new MI commands.
3694         * break-catch-throw.c (enum exception_event_kind): Move to
3695         breakpoint.h.
3696         (print_mention_exception_catchpoint): Output text as a single
3697         message.
3698         (catch_exception_command_1): Rename to...
3699         (catch_exception_event): ...this, make non-static, update header
3700         command, and change some parameter types.
3701         (catch_catch_command): Update for changes to
3702         catch_exception_command_1.
3703         (catch_throw_command): Likewise.
3704         (catch_rethrow_command): Likewise.
3705         * breakpoint.c (enum exception_event_kind): Delete.
3706         * breakpoint.h (enum exception_event_kind): Moved here from
3707         break-catch-throw.c.
3708         (catch_exception_event): Declare.
3709         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3710         (mi_cmd_catch_throw): New function.
3711         (mi_cmd_catch_rethrow): New function.
3712         (mi_cmd_catch_catch): New function.
3713         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3714         'catch-catch' entries.
3715         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3716         (mi_cmd_catch_rethrow): Declare.
3717         (mi_cmd_catch_catch): Declare.
3718
3719 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * annotate.c (annotate_source_line): Change return type to void,
3722         update implementation to match.
3723         * annotate.h (annotate_source_line): Change return type to void,
3724         update header comment.
3725         * stack.c (print_frame_info): Don't change what frame information
3726         is printed based on whether annotations are on or not.
3727
3728 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3731         (annotate_source): Make static.
3732         (annotate_source_line): Moved from source.c and renamed from
3733         identify_source_line.  Update the return type.
3734         * annotate.h (annotate_source): Delete declaration.
3735         (annotate_source_line): Declaration moved from source.h, and
3736         renamed from identify_source_line.  Return type updated.
3737         * source.c (identify_source_line): Moved to annotate.c and renamed
3738         to annotate_source_line.
3739         (info_line_command): Remove check of annotation_level.
3740         * source.h (identify_source_line): Move declaration to annotate.h
3741         and rename to annotate_source_line.
3742         * stack.c: Add 'annotate.h' include.
3743         (print_frame_info): Remove check of annotation_level before
3744         calling annotate_source_line.
3745
3746 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * source-cache.c (source_cache::get_plain_source_lines): Use
3749         open_source_file_with_line_charpos instead of just
3750         open_source_file, remove call to find_source_lines.
3751         (source_cache::get_source_lines): Likewise.
3752         * source.c (find_source_lines): Make static.
3753         (get_filename_and_charpos): Renamed into...
3754         (open_source_file_with_line_charpos): ..this along with changes to
3755         return a scoped_fd, and some other minor clean ups.
3756         (identify_source_line): Use open_source_file_with_line_charpos.
3757         (search_command_helper): Use open_source_file_with_line_charpos
3758         instead of just open_source_file, remove call to
3759         find_source_lines.
3760         * source.h (open_source_file_with_line_charpos): Declare new
3761         function.
3762         (find_source_lines): Delete declaration.
3763
3764 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * source.c (get_filename_and_charpos): Remove fullname
3767         parameter.
3768         (identify_source_line): Update call to get_filename_and_charpos.
3769
3770 2019-06-14  Tom Tromey  <tromey@adacore.com>
3771
3772         PR gdb/24502:
3773         * ui-style.h (skip_ansi_escape): Update comment.
3774         * ui-file.h (class no_terminal_escape_file): New class.
3775         * ui-file.c (no_terminal_escape_file::write)
3776         (no_terminal_escape_file::puts): New methods.
3777         * cli/cli-logging.c (handle_redirections): Use
3778         no_terminal_escape_file.
3779
3780 2019-06-14  Tom Tromey  <tromey@adacore.com>
3781
3782         * NEWS: Move convenience variable news above Python news.
3783
3784 2019-06-14  Tom Tromey  <tom@tromey.com>
3785
3786         * gnulib: Move directory to top-level.
3787         * configure.ac: Don't configure gnulib.
3788         * configure: Rebuild.
3789         * common/common-defs.h: Use new path to gnulib.
3790         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3791         (GNULIB_H): Remove.
3792         (INCGNU): Look in new gnulib location.
3793         (HFILES_NO_SRCDIR): Remove gnulib files.
3794         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3795         (generated_files): Remove GNULIB_H.
3796         ($(LIBGNU), all-lib): Remove targets.
3797         (distclean): Don't mention GNULIB_BUILDDIR.
3798         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3799
3800 2019-06-14  Tom Tromey  <tromey@adacore.com>
3801
3802         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3803         Warn if symbol file does not provide any symbols.
3804
3805 2019-06-14  Tom Tromey  <tromey@adacore.com>
3806
3807         * source.c (find_and_open_source): Respect basenames_may_differ.
3808
3809 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * annotate.c (annotate_breakpoints_invalid): Make use of
3812         scoped_restore_terminal_state.
3813         (annotate_frames_invalid): Likewise.
3814
3815 2019-06-14  Tom Tromey  <tromey@adacore.com>
3816
3817         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3818         allow assignment to an internalvar.
3819
3820 2019-06-14  Tom Tromey  <tromey@adacore.com>
3821
3822         * ada-lex.l: Allow "_" in attribute names.
3823
3824 2019-06-14  Tom Tromey  <tromey@adacore.com>
3825
3826         PR gdb/24653:
3827         * regcache.c (registers_changed): Don't call alloca.
3828         * top.c (execute_command): Don't call alloca.
3829
3830 2019-06-13  Pedro Alves  <palves@redhat.com>
3831
3832         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3833         'expression'.  When parsing an expression, error out if there's
3834         junk after "unlimited".
3835         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3836         (do_set_command): Adjust calls to is_unlimited_literal.
3837
3838 2019-06-13  Pedro Alves  <palves@redhat.com>
3839
3840         * compile/compile.c (make_compile_options_def_group): Add braces
3841         around array_view initializer.
3842         * thread.c (make_thread_apply_all_options_def_group)
3843         (make_thread_apply_all_options_def_group): Likewise.
3844
3845 2019-06-13  Pedro Alves  <palves@redhat.com>
3846
3847         * NEWS (New commands): Mention "maint test-options
3848         require-delimiter", "maint test-options unknown-is-error", "maint
3849         test-options unknown-is-operand" and "maint show
3850         test-options-completion-result".
3851         (New command options, command completion): New section.
3852         (Completion improvements): New section.
3853         Mention that you can abbreviate "unlimited".
3854
3855 2019-06-13  Pedro Alves  <palves@redhat.com>
3856
3857         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3858         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3859         * unittests/cli-utils-selftests.c (test_parse_flags)
3860         (test_parse_flags_qcs): Delete.
3861         (test_cli_utils): Don't call deleted functions.
3862
3863 2019-06-13  Pedro Alves  <palves@redhat.com>
3864
3865         * thread.c: Include "cli/cli-option.h".
3866         (tp_array_compar_ascending): Global.
3867         (tp_array_compar): Delete function.
3868         (tp_array_compar_ascending, tp_array_compar_descending): New
3869         functions.
3870         (ascending_option_def, qcs_flag_option_def)
3871         (thr_qcs_flags_option_defs)
3872         (make_thread_apply_all_options_def_group)
3873         (make_thread_apply_options_def_group): New.
3874         (thread_apply_all_command): Use gdb::option::process_options.
3875         (thread_apply_command_completer)
3876         (thread_apply_all_command_completer): New.
3877         (thread_apply_command): Use gdb::option::process_options.
3878         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3879         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3880         to generate help text of "thread apply".  Adjust "taas"'s help.
3881         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3882         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3883
3884 2019-06-13  Pedro Alves  <palves@redhat.com>
3885
3886         * thread.c (thread_apply_command): Check for invalid TID with
3887         isdigit instead of !isalpha.
3888
3889 2019-06-13  Pedro Alves  <palves@redhat.com>
3890
3891         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3892         (validate_flags_qcs): New.
3893         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3894         (validate_flags_qcs): Declare.
3895         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3896         (make_frame_apply_options_def_group): New.
3897         (frame_apply_command_count): Process options with
3898         gdb::option::process_options.
3899         (frame_apply_completer): New.
3900         (frame_apply_level_completer, frame_apply_all_completer)
3901         (frame_apply_completer): New.
3902         (_initialize_stack): Update help of "frame apply", "frame apply
3903         level", "frame apply all" and "faas" to mention supported options
3904         and install command completers.
3905         * stack.h (frame_apply_all_completer): Declare.
3906         * thread.c: Include "stack.h".
3907         (tfaas_command): Add "--".
3908         (_initialize_thread): Update help "tfaas" to mention supported
3909         options and install command completer.
3910
3911 2019-06-13  Pedro Alves  <palves@redhat.com>
3912
3913         * completer.c (complete_nested_command_line): New.
3914         (gdb_completion_word_break_characters_throw): Add assertion.
3915         * completer.h (complete_nested_command_line): Declare.
3916
3917 2019-06-13  Pedro Alves  <palves@redhat.com>
3918
3919         * stack.c (parse_backtrace_qualifiers): New.
3920         (backtrace_command): Use it.
3921         (backtrace_command_completer): Complete on qualifiers.
3922
3923 2019-06-13  Pedro Alves  <palves@redhat.com>
3924
3925         * frame.c: Include "cli/cli-option.h.
3926         (user_set_backtrace_options): New.
3927         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3928         Delete.
3929         (get_prev_frame): Adjust.
3930         (boolean_option_def, uinteger_option_def)
3931         (set_backtrace_option_defs): New.
3932         (_initialize_frame): Adjust and use
3933         gdb::option::add_setshow_cmds_for_options to install "set
3934         backtrace past-main" and "set backtrace past-entry".
3935         * frame.h: Include "cli/cli-option.h".
3936         (struct frame_print_options): Forward declare.
3937         (print_frame_arguments_all, print_frame_arguments_scalars)
3938         (print_frame_arguments_none): Declare.
3939         (print_entry_values): Delete declaration.
3940         (struct frame_print_options, user_frame_print_options): New.
3941         (struct set_backtrace_options): New.
3942         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3943         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3944         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3945         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3946         (list_args_or_locals): Add frame_print_options parameter.
3947         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3948         * python/py-framefilter.c (enumerate_args): Pass down
3949         USER_FRAME_PRINT_OPTIONS.
3950         * stack.c: Include "cli/cli-option.h".
3951         (print_frame_arguments_all, print_frame_arguments_scalars)
3952         (print_frame_arguments_none): Declare.
3953         (print_raw_frame_arguments, print_entry_values): Delete.
3954         (user_frame_print_options): New.
3955         (boolean_option_def, enum_option_def, frame_print_option_defs):
3956         New.
3957         (struct backtrace_cmd_options): New.
3958         (bt_flag_option_def): New.
3959         (backtrace_command_option_defs): New.
3960         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3961         (print_frame_arg, read_frame_arg, print_frame_args)
3962         (print_frame_info, print_frame): Add frame_print_options parameter
3963         and use it.
3964         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3965         (backtrace_command_1): Add frame_print_options and
3966         backtrace_cmd_options parameters and use them.
3967         (make_backtrace_options_def_group): New.
3968         (backtrace_command): Process command options with
3969         gdb::option::process_options.
3970         (backtrace_command_completer): New.
3971         (_initialize_stack): Extend "backtrace"'s help to mention
3972         supported options.  Install completer for "backtrace".
3973         Install some settings commands with add_setshow_cmds_for_options.
3974
3975 2019-06-13  Pedro Alves  <palves@redhat.com>
3976
3977         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3978         and that "set/show print raw frame-arguments" are now deprecated.
3979
3980         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3981         command.
3982         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3983         * stack.c (_initialize_stack): Install "set/show print
3984         raw-frame-arguments", and deprecate "set/show print raw
3985         frame-arguments".
3986         * valprint.c (_initialize_valprint): Deprecate "set/show print
3987         raw".
3988
3989 2019-06-13  Pedro Alves  <palves@redhat.com>
3990
3991         * compile/compile.c (struct compile_options): New.
3992         (compile_flag_option_def, compile_command_option_defs)
3993         (make_compile_options_def_group): New.
3994         (compile_file_command): Handle options with
3995         gdb::option::process_options.
3996         (compile_file_command_completer): New function.
3997         (compile_code_command): Handle options with
3998         gdb::option::process_options.
3999         (compile_code_command_completer): New function.
4000         (_initialize_compiler): Install completers for "compile code" and
4001         "compile file".  Mention available options in "compile code" and
4002         "compile code"'s help.
4003         * completer.c (advance_to_completion_word): New, factored out from
4004         ...
4005         (advance_to_expression_complete_word_point): ... this.
4006         (advance_to_filename_complete_word_point): New.
4007         * completer.h (advance_to_filename_complete_word_point): New
4008         declaration.
4009
4010 2019-06-13  Pedro Alves  <palves@redhat.com>
4011
4012         * compile/compile.c: Include "cli/cli-option.h".
4013         (compile_print_value): Scope data pointer is now a
4014         value_print_options pointer; adjust.
4015         (compile_print_command): Process options.  Scope data pointer is
4016         now a value_print_options pointer; adjust.
4017         (_initialize_compile): Update "compile print"'s help to include
4018         supported options.  Install a completer for "compile print".
4019         * cp-valprint.c (show_vtblprint, show_objectprint)
4020         (show_static_field_print): Delete.
4021         (_initialize_cp_valprint): Don't install "set print
4022         static-members", "set print vtbl", "set print object" here.
4023         * printcmd.c: Include "cli/cli-option.h" and
4024         "common/gdb_optional.h".
4025         (print_command_parse_format): Rework to fill in a
4026         value_print_options instead of a format_data.
4027         (print_value): Change parameter type from format_data pointer to
4028         value_print_options reference.  Adjust.
4029         (print_command_1): Process options.  Adjust to pass down a
4030         value_print_options.
4031         (print_command_completer): New.
4032         (_initialize_printcmd): Install print_command_completer as
4033         handle_brkchars completer for the "print" command.  Update
4034         "print"'s help to include supported options.
4035         * valprint.c: Include "cli/cli-option.h".
4036         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4037         here from cp-valprint.c.
4038         (boolean_option_def, uinteger_option_def)
4039         (value_print_option_defs, make_value_print_options_def_group):
4040         New.  Use gdb::option::add_setshow_cmds_for_options to install
4041         "set print elements", "set print null-stop", "set print repeats",
4042         "set print pretty", "set print union", "set print array", "set
4043         print address", "set print symbol", "set print array-indexes".
4044         * valprint.h: Include <string> and "cli/cli-option.h".
4045         (make_value_print_options_def_group): Declare.
4046         (print_value): Change parameter type from format_data pointer to
4047         value_print_options reference.
4048         (print_command_completer): Declare.
4049
4050 2019-06-13  Pedro Alves  <palves@redhat.com>
4051
4052         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4053         (COMMON_SFILES): Add maint-test-settings.c.
4054         * cli/cli-decode.c (boolean_enums): New global, factored out from
4055         ...
4056         (add_setshow_boolean_cmd): ... here.
4057         * cli/cli-decode.h (boolean_enums): Declare.
4058         * cli/cli-option.c: New file.
4059         * cli/cli-option.h: New file.
4060         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4061         factored out from ...
4062         (parse_cli_boolean_value(const char *)): ... this.
4063         (is_unlimited_literal): Change parameter type to pointer to
4064         pointer.  Adjust and advance ARG pointer.
4065         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4066         (parse_cli_var_enum): New, factored out from ...
4067         (do_set_command): ... this.  Adjust.
4068         * cli/cli-setshow.h (parse_cli_boolean_value)
4069         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4070         (parse_cli_var_enum): Declare.
4071         * cli/cli-utils.c: Include "cli/cli-option.h".
4072         (get_ulongest): New.
4073         * cli/cli-utils.h (get_ulongest): Declare.
4074         (check_for_argument): New overloads.
4075         * maint-test-options.c: New file.
4076
4077 2019-06-13  Pedro Alves  <palves@redhat.com>
4078
4079         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4080         parse a range if "-" is at the end of the string.
4081
4082 2019-06-13  Pedro Alves  <palves@redhat.com>
4083
4084         * cli/cli-setshow.c (parse_auto_binary_operation)
4085         (parse_cli_boolean_value): Don't allow "o".
4086
4087 2019-06-13  Pedro Alves  <palves@redhat.com>
4088
4089         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4090         * NEWS: Mention maint test-settings KIND.
4091         * maint-test-settings.c: New file.
4092
4093 2019-06-13  Pedro Alves  <palves@redhat.com>
4094
4095         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4096         completer.
4097         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4098         "set" completers.
4099
4100 2019-06-13  Pedro Alves  <palves@redhat.com>
4101
4102         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4103         after item.
4104
4105 2019-06-13  Pedro Alves  <palves@redhat.com>
4106
4107         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4108
4109 2019-06-13  Pedro Alves <palves@redhat.com>
4110
4111         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4112         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4113         call.
4114         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4115         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4116         calls.
4117         (check_for_argument): Skip spaces after argument.
4118
4119 2019-06-13  Pedro Alves  <palves@redhat.com>
4120
4121         * thread.c (thread_apply_command): Adjust TID parsing.
4122         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4123         detected before end of string.
4124         (tid_is_in_list): Error out if LIST is invalid.
4125
4126 2019-06-13  Pedro Alves  <palves@redhat.com>
4127
4128         * completer.c (complete_line_internal_1): Rewind completion word
4129         point.
4130         (completion_tracker::advance_custom_word_point_by): Change
4131         parameter type to int.
4132         * completer.h (completion_tracker::advance_custom_word_point_by):
4133         Likewise.
4134
4135 2019-06-13  Pedro Alves  <palves@redhat.com>
4136
4137         * completer.c (advance_to_completion_word): Handle delimiters.
4138
4139 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4140
4141         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4142
4143 2019-06-11  Tom Tromey  <tom@tromey.com>
4144
4145         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4146         (xmalloc_failed): Move to alloc.c.
4147         * alloc.c: New file.
4148         * Makefile.in (COMMON_SFILES): Add alloc.c.
4149
4150 2019-06-11  Tom Tromey  <tom@tromey.com>
4151
4152         * nat/linux-waitpid.c: Don't include server.h.
4153         (linux_debug): Remove.
4154         (my_waitpid): Update.
4155
4156 2019-06-11  Tom Tromey  <tromey@adacore.com>
4157
4158         * infcall.c (_initialize_infcall): Remove trailing newline from
4159         help.
4160         * user-regs.c (_initialize_user_regs): Remove trailing newline
4161         from help.
4162         * typeprint.c (_initialize_typeprint): Remove trailing newline
4163         from help.
4164         * reverse.c (_initialize_reverse): Remove trailing newlines from
4165         help.
4166         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4167         from help.
4168         * language.c (add_set_language_command): Remove trailing newline
4169         from help.
4170         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4171         help.
4172         * disasm.c (_initialize_disasm): Remove trailing newline from
4173         help.
4174         * top.c (init_main): Remove trailing newline from help.
4175         * interps.c (_initialize_interpreter): Remove trailing newline
4176         from help.
4177         * btrace.c (_initialize_btrace): Remove trailing newlines from
4178         help.
4179         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4180         from help.
4181         * python/python.c (_initialize_python): Remove trailing newline
4182         from help.
4183         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4184         help.
4185         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4186         from help.  Reformat some text.
4187         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4188         from help.
4189         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4190         newline from help.
4191
4192 2019-06-11  Tom Tromey  <tromey@adacore.com>
4193
4194         * darwin-nat.c (darwin_decode_exception_message)
4195         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4196
4197 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * valops.c (value_slice): Check for not allocated or not
4200         associated values.
4201
4202 2019-06-10  Tom de Vries  <tdevries@suse.de>
4203
4204         PR gdb/24618
4205         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4206         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4207         invalid.
4208
4209 2019-06-10  Tom de Vries  <tdevries@suse.de>
4210
4211         PR gdb/24611
4212         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4213         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4214
4215 2019-06-10  Tom de Vries  <tdevries@suse.de>
4216
4217         PR symtab/24545
4218         * symtab.c (struct demangled_name_entry): Add language field.
4219         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4220         static minimal symbol".  Set and use language field.
4221
4222 2019-06-10  Tom Tromey  <tromey@adacore.com>
4223
4224         * ada-lang.c (_initialize_ada_language): Update help text.
4225
4226 2019-06-10  Tom Tromey  <tromey@adacore.com>
4227
4228         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4229         with a newline.
4230         * guile/guile.c (handle_boot_error): Don't end warning with a
4231         newline.
4232         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4233         warning with a newline.
4234         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4235         newline.
4236         (s12z_frame_cache): Likewise.
4237         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4238         a newline.
4239         * solib-svr4.c (disable_probes_interface): Don't end warning with
4240         a newline.
4241         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4242         newline.
4243         * python/python.c (do_finish_initialization): Don't end warning
4244         with a newline.
4245
4246 2019-06-10  Tom Tromey  <tom@tromey.com>
4247
4248         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4249         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4250         gdbpy_enter.
4251
4252 2019-06-10  Tom Tromey  <tromey@adacore.com>
4253
4254         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4255         data.
4256         (elf_new_init): Don't call stabsread_new_init.
4257         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4258         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4259         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4260
4261 2019-06-10  Tom de Vries  <tdevries@suse.de>
4262
4263         PR symtab/16264
4264         PR symtab/24517
4265         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4266
4267 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4268
4269         * source.c (find_and_open_source): Also rewrite relative file
4270         names.
4271
4272 2019-04-26  Amos Bird  <amosbird@gmail.com>
4273
4274         * annotate.c (annotate_thread_exited): Add "thread-exited"
4275         annotation.
4276
4277 2019-06-06  Tom Tromey  <tromey@adacore.com>
4278
4279         * maint.h (class scoped_command_stats): Use
4280         DISABLE_COPY_AND_ASSIGN.
4281         <print_time>: New method.
4282         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4283         print_time.
4284         (scoped_command_stats::print_time): New method.
4285
4286 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4289         instructions of lengths 6 or 8 bytes.
4290
4291 2019-06-04  Pedro Alves  <palves@redhat.com>
4292
4293         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4294
4295         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4296         * breakpoint.c (condition_completer): Likewise.
4297         * cli/cli-dump.c (scan_expression): Likewise.
4298         * common/filestuff.c (mkdir_recursive): Likewise.
4299         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4300         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4301         (gdb_abspath): Likewise.
4302         * compile/compile-cplus-types.c
4303         (compile_cplus_instance::decl_name): Likewise.
4304         * completer.c (complete_explicit_location):
4305         (signal_completer, reg_or_group_completer_1): Likewise.
4306         * cp-support.c (cp_remove_params_if_any): Likewise.
4307         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4308         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4309         * infcmd.c (strip_bg_char): Likewise.
4310         * linespec.c (copy_token_string): Likewise.
4311         * mi/mi-main.c (output_cores): Likewise.
4312         * psymtab.c (psymtab_search_name):
4313         * symfile.c (test_set_ext_lang_command): Likewise.
4314         * target.c (target_fileio_read_stralloc): Likewise.
4315         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4316         * value.c (complete_internalvar): Likewise.
4317
4318 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4319
4320         Add objfile property to gdb.Type.
4321         * NEWS: Mention Python API addition.
4322         * python/py-type.c (typy_get_objfile): New method.
4323
4324 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4325
4326         * NEWS: Mention the new set|show style [title|highlight].
4327         Mention changes to "show style", "help" and "apropos".
4328
4329 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4330
4331         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4332         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4333         instead of print_help_for_command.
4334         (print_doc_of_command): New function.
4335         (help_list): Add 'apropos -v word' suggestion.
4336         (print_help_for_command): Style the command name using title style.
4337         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4338         (_initialize_cli_cmds): Describe -v in apropos_command help.
4339
4340 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4341
4342         * cli/cli-style.h (cli_style_option): Add name in constructor,
4343         add m_name class member, add constructor with intensity,
4344         add name class function.
4345         (cli_style_option::add_setshow_commands): Remove name argument.
4346         (highlight_style, title_style): New styles.
4347         * cli/cli-style.c (do_show): New function that shows a style
4348         characteristic styling the style name with itself.
4349         (set_style_name): New function.
4350         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4351         Update all callers according to the changes in cli/cli-style.h.
4352         * utils.h (fputs_highlighted): New function.
4353         * utils.c (fputs_highlighted): Likewise.
4354
4355 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4356
4357         * NEWS: Mention new pipe command and new convenience variables.
4358
4359 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4360
4361         * cli/cli-cmds.c (pipe_command): New function.
4362         (_initialize_cli_cmds): Call add_com for pipe_command.
4363         Define | as an alias for pipe.
4364         (exit_status_set_internal_vars): New function.
4365         (shell_escape): Call exit_status_set_internal_vars.
4366         cli/cli-decode.c (find_command_name_length): Recognize | as
4367         a single character command.
4368
4369 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4370
4371         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4372         top.c (execute_command_to_ui_file): New function, mostly a copy
4373         of execute_command_to_string.
4374         (execute_command_to_string): Implement by calling
4375         execute_command_to_ui_file.
4376
4377 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4378
4379         * top.h (saved_command_line): Remove declaration.
4380         * top.c (previous_saved_command_line, previous_repeat_arguments):
4381         New variables.
4382         (saved_command_line): Make static, define together with other
4383         'repeat variables'.
4384         (dont_repeat): Clear repeat_arguments.
4385         (repeat_previous, get_saved_command_line, save_command_line):
4386         New functions.
4387         (gdb_init): Initialize saved_command_line
4388         and previous_saved_command_line.
4389         * main.c (captured_main_1): Remove saved_command_line initialization.
4390         * event-top.c (handle_line_of_input): Update to use
4391         the new 'repeat' related functions instead of direct access to
4392         saved_command_line.
4393         * command.h (repeat_previous, get_saved_command_line,
4394         save_command_line): New declarations.
4395         (dont_repeat): Add comment.
4396
4397 2019-05-30  Tom Tromey  <tromey@adacore.com>
4398
4399         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4400         Fix comment.
4401         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4402
4403 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4404
4405         PR cli/24587
4406         * completer.c (complete): Initialize variable word.
4407
4408 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4409
4410         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4411         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4412         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4413         'body' is NULL to the outter 'if', protecting the '!is_define'
4414         situation as well.
4415
4416 2019-05-29  Tom Tromey  <tromey@adacore.com>
4417
4418         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4419         (dwarf_unknown): New function.
4420         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4421         (dwarf_type_encoding_name): Use dwarf_unknown.
4422
4423 2019-05-29  Tom Tromey  <tromey@adacore.com>
4424
4425         PR c++/20020:
4426         * cp-valprint.c (cp_print_value_fields): Call
4427         cp_print_static_field inside "try".
4428
4429 2019-05-29  Tom Tromey  <tromey@adacore.com>
4430
4431         * inflow.c (struct terminal_info): Add default operator=.
4432         * configure: Rebuild.
4433         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4434         -Wdeprecated-copy-dtor, -Wredundant-move.
4435
4436 2019-05-29  Tom Tromey  <tromey@adacore.com>
4437
4438         * NEWS: Add entry.
4439         * infcmd.c (print_return_value_1): Handle finish_print
4440         option.
4441         (show_print_finish): New function.
4442         (_initialize_infcmd): Add "set/show print finish" commands.
4443         * valprint.c (user_print_options): Initialize new member.
4444         * valprint.h (struct value_print_options) <finish_print>: New
4445         member.
4446
4447 2019-05-28  Tom Tromey  <tromey@adacore.com>
4448
4449         * ada-lang.c (ada_remove_Xbn_suffix)
4450         (find_old_style_renaming_symbol)
4451         (parse_old_style_renaming): Remove.
4452         (ada_find_renaming_symbol): Don't call
4453         find_old_style_renaming_symbol.
4454         (ada_is_renaming_symbol): Rename from
4455         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4456         bool.  Now static.
4457         (ada_read_var_value): Update and simplify.
4458         * ada-exp.y (write_var_or_type): Remove old code.
4459
4460 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4461
4462         * event-top.c: Remove include comment.
4463         * inflow.c (class scoped_ignore_sigttou): Move from here...
4464         * inflow.h (class scoped_ignore_sigttou): ...to here.
4465         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4466         * top.c:  Remove include comment.
4467
4468 2019-05-27  Tom Tromey  <tom@tromey.com>
4469
4470         * NEWS: Fix typo.
4471
4472 2019-05-22  Tom Tromey  <tromey@adacore.com>
4473
4474         * target.c (target_follow_exec): Constify parameter.
4475         * target-delegates.c: Rebuild.
4476         * remote.c (remote_target::follow_exec): Constify parameter.
4477         * infrun.c (follow_exec): Constify parameter.
4478         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4479         (target_follow_exec): Likewise.
4480
4481 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4482
4483         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4484         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4485
4486 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * NEWS: Add debugredirect and testsuite sections.
4489
4490 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4491
4492         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4493         target descriptions using exclusively floating point register name
4494         aliases.
4495
4496 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         PR gdb/18644:
4499         * f-lang.c (build_fortran_types): Handle the case where
4500         gdbarch_floatformat_for_type returns a nullptr.
4501
4502 2019-05-21  Tom de Vries  <tdevries@suse.de>
4503
4504         PR cli/24587
4505         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4506
4507 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         PR gdb/18644:
4510         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4511         16-byte floats.
4512         * i386-tdep.c (i386_floatformat_for_type): Use
4513         floatformats_ia64_quad for the 16-byte floating point component
4514         within a fortran 32-byte complex number.
4515
4516 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4519         delete default constructor.
4520         (find_partial_die): Update to return const struct.
4521         (partial_die_parent_scope): Move variable declaration into scope
4522         of its use and change its type to auto.
4523         (guess_partial_die_structure_name): Likewise.
4524         (partial_die_info::fixup): Likewise.
4525
4526 2019-05-17  Tom Tromey  <tromey@adacore.com>
4527
4528         * source.c (find_and_open_source): Remove cast.
4529
4530 2019-05-17  Tom Tromey  <tromey@adacore.com>
4531
4532         * annotate.c (annotate_source): Make "filename" const.
4533         * annotate.h (annotate_source): Use const.
4534
4535 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4536
4537         * disasm.c (set_disassembler_options): Send errors to stderr.
4538
4539 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4540
4541         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4542         (cli_interp_base::set_logging): Check debug_redirect.
4543         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4544         * cli/cli-logging.c (debug_redirect): Add static variable.
4545         (pop_output_files): Add default param.
4546         (handle_redirections): Print debug setting.
4547         (show_logging_command): Likewise.
4548         (_initialize_cli_logging): Add debugredirect command.
4549         * interps.c (current_interp_set_logging): Add debug_redirect
4550         parameter.
4551         * interps.h (set_logging): Add debug_redirect parameter.
4552         (current_interp_set_logging): Likewise.
4553         * mi/mi-common.h: Likewise.
4554         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4555
4556 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4557             Tom Tromey  <tromey@adacore.com>
4558
4559         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4560         directly.
4561         * cli/cli-interp.h (make_logging_output): Remove declaration.
4562         * cli/cli-logging.c (make_logging_output): Remove function.
4563         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4564         directly.
4565         * ui-file.c (tee_file::tee_file): Remove bools.
4566         (tee_file::~tee_file): Remove deletes.
4567         * ui-file.h (tee_file): Remove bools.
4568
4569 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4570
4571         * mi/mi-cmds.h (mi_cmd_complete): New function.
4572         * mi/mi-main.c (mi_cmd_complete): Likewise.
4573         * mi/mi-cmds.c: Define new MI command -complete.
4574         * NEWS: Mention new -complete command.
4575
4576 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4577
4578         * completer.h (complete): New function.
4579         * completer.c (complete): Likewise.
4580         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4581         function defined in completer.h.
4582
4583 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4584
4585         * MAINTAINERS (Write After Approval): Add myself.
4586
4587 2019-05-17  Tom de Vries  <tdevries@suse.de>
4588
4589         PR gdb/24094
4590         * dwarf2read.c (struct cu_partial_die_info): New struct.
4591         (find_partial_die): Return cu_partial_die_info.
4592         (partial_die_parent_scope, guess_partial_die_structure_name)
4593         (partial_die_info::fixup): Handle new return type of find_partial_die.
4594
4595 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4596
4597         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4598         "std::string", simplifying the algorithm.
4599
4600 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4601
4602         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4603         (stap_static_probe_ops::get_probes): Likewise.
4604
4605 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4606
4607         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4608         '-')" and "else if".
4609         (stap_parse_single_operand): Join checks for
4610         "gdbarch_stap_parse_special_token_p" and
4611         "gdbarch_stap_parse_special_token" in the same "if" statement.
4612         Invert check when verifying for operation on register
4613         displacement.
4614
4615 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4616
4617         * stap-probe.c (stap_get_opcode): Update comment.
4618         (stap_get_expected_argument_type): Likewise.
4619         (handle_stap_probe): Likewise.
4620
4621 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4622
4623         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4624         return type to 'bool'.  Adjust comment.  Use 'bool' when
4625         appropriate.
4626         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4627         * stap-probe.c (stap_parse_argument_1): Likewise.
4628         (stap_is_operator): Likewise.
4629         (stap_is_generic_prefix): Likewise.
4630         (stap_is_register_prefix): Likewise.
4631         (stap_is_register_indirection_prefix): Likewise.
4632         (stap_is_integer_prefix): Likewise.
4633         (stap_generic_check_suffix): Likewise.
4634         (stap_check_integer_suffix): Likewise.
4635         (stap_check_register_suffix): Likewise.
4636         (stap_check_register_indirection_suffix): Likewise.
4637         (stap_parse_register_operand): Likewise.
4638         (stap_parse_single_operand): Likewise.
4639         (stap_parse_argument_1): Likewise.
4640         (stap_probe::get_argument_count): Likewise.
4641         (stap_is_operator): Likewise.
4642
4643 2019-05-16  Tom Tromey  <tromey@adacore.com>
4644
4645         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4646         keyword to foreach.
4647
4648 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4649
4650         * linux-thread-db.c (try_thread_db_load_1): Change return type
4651         to bool.
4652         (try_thread_db_load): Likewise.
4653         (try_thread_db_load_from_pdir_1): Likewise.
4654         (try_thread_db_load_from_pdir): Likewise.
4655         (try_thread_db_load_from_sdir): Likewise.
4656         (try_thread_db_load_from_dir): Likewise.
4657         (thread_db_load_search): Likewise.
4658         (has_libpthread): Likewise.
4659         (thread_db_load): Likewise.
4660
4661 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4662
4663         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4664         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4665         NULL, and complain/return if that's the case.
4666
4667 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4668
4669         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4670         (advance, posn, abstract_read_memory): New functions.
4671         [struct mem_read_abstraction]: New struct.
4672         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4673
4674 2019-05-14  Tom Tromey  <tromey@adacore.com>
4675
4676         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4677         value is not lval_memory.
4678
4679 2019-05-14  Tom Tromey  <tromey@adacore.com>
4680
4681         * solib.c (info_sharedlibrary_command): Style the file name.
4682
4683 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4684
4685         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4686         (aarch64_vnv_type): Likewise.
4687         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4688         * common/tdesc.c: Likewise.
4689         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4690         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4691         * features/aarch64-fpu.xml: Add ieee half view.
4692         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4693         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4694         * gdbtypes.h (struct builtin_type): Likewise.
4695         (struct objfile_type): Likewise.
4696
4697 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4698
4699         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4700         typo.
4701         * location.h (string_to_event_location): Likewise.
4702
4703 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4704
4705         GDB 8.3 released.
4706
4707 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4708
4709         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4710         New variable declaration.
4711         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4712         New variable.
4713         (print_one_breakpoint): Use ui_out::test_flags and new global
4714         variable to compute use_fixed_output.
4715         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4716         Remove.
4717         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4718         (mi_multi_location_breakpoint_output_fixed): Remove.
4719         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4720         new variable.
4721         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4722         fix_multi_location_breakpoint_output flag if version >= 3.
4723         * ui-out.h (enum ui_out_flag)
4724         <fix_multi_location_breakpoint_output>: New enumerator.
4725
4726 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4727
4728         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4729
4730 2019-05-10  Tom Tromey  <tromey@adacore.com>
4731
4732         * ada-lang.c (catch_ada_completer): New function.
4733         (_initialize_ada_language): Use it.
4734
4735 2019-05-10  Tom Tromey  <tromey@adacore.com>
4736
4737         * thread.c (print_thread_info): Make "requested_threads" const.
4738         * gdbthread.h (print_thread_info): Make "requested_threads"
4739         const.
4740         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4741         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4742
4743 2019-05-08  Tom Tromey  <tom@tromey.com>
4744
4745         * gdbtypes.c (objfile_type_data): Change type.
4746         (objfile_type, _initialize_gdbtypes): Update.
4747
4748 2019-05-08  Tom Tromey  <tom@tromey.com>
4749
4750         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4751         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4752         (_initialize_dwarf2_frame): Update.
4753
4754 2019-05-08  Tom Tromey  <tom@tromey.com>
4755
4756         * objc-lang.c (objc_objfile_data): Change type.
4757         (find_methods): Update.
4758         (_initialize_objc_lang): Remove.
4759
4760 2019-05-08  Tom Tromey  <tom@tromey.com>
4761
4762         * stabsread.c (rs6000_builtin_type_data): Change type.
4763         (rs6000_builtin_type, _initialize_stabsread): Update.
4764
4765 2019-05-08  Tom Tromey  <tom@tromey.com>
4766
4767         * mips-tdep.c (mips_pdr_data): Remove.
4768         (_initialize_mips_tdep): Update.
4769
4770 2019-05-08  Tom Tromey  <tom@tromey.com>
4771
4772         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4773         (hppa_init_objfile_priv_data, read_unwind_info)
4774         (find_unwind_entry, _initialize_hppa_tdep): Update.
4775
4776 2019-05-08  Tom Tromey  <tom@tromey.com>
4777
4778         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4779         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4780         on obstack.
4781         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4782
4783 2019-05-08  Tom Tromey  <tom@tromey.com>
4784
4785         * mdebugread.c (basic_type_data): Change type.
4786         (basic_type, _initialize_mdebugread): Update.
4787
4788 2019-05-08  Tom Tromey  <tom@tromey.com>
4789
4790         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4791
4792 2019-05-08  Tom Tromey  <tom@tromey.com>
4793
4794         * nto-tdep.c (nto_inferior_data_reg): Change type.
4795         (nto_inferior_data): Update.
4796         (nto_inferior_data_cleanup, nto_new_inferior_data)
4797         (_initialize_nto_tdep): Remove.
4798         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4799
4800 2019-05-08  Tom Tromey  <tom@tromey.com>
4801
4802         * ada-lang.c (struct ada_inferior_data): Add initializers.
4803         (ada_inferior_data): Change type.
4804         (ada_inferior_data_cleanup): Remove.
4805         (get_ada_inferior_data, ada_inferior_exit)
4806         (struct ada_pspace_data): Add initializers, destructor.
4807         (ada_pspace_data_handle): Change type.
4808         (get_ada_pspace_data): Update.
4809         (ada_pspace_data_cleanup): Remove.
4810
4811 2019-05-08  Tom Tromey  <tom@tromey.com>
4812
4813         * coffread.c (struct coff_symfile_info): Add initializers.
4814         (coff_objfile_data_key): Move lower.  Change type.
4815         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4816         Update.
4817         (coff_free_info): Remove.
4818
4819 2019-05-08  Tom Tromey  <tom@tromey.com>
4820
4821         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4822         (fbsd_pspace_data_handle): Move lower.  Change type.
4823         (get_fbsd_pspace_data): Update.
4824         (fbsd_pspace_data_cleanup): Remove.
4825         (_initialize_fbsd_tdep): Update.
4826
4827 2019-05-08  Tom Tromey  <tom@tromey.com>
4828
4829         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4830         (get_ada_tasks_pspace_data): Update.
4831         (ada_tasks_pspace_data_cleanup): Remove.
4832         (_initialize_tasks): Update.
4833         (ada_tasks_inferior_data_handle): Change type.
4834         (get_ada_tasks_inferior_data): Update.
4835         (ada_tasks_inferior_data_cleanup): Remove.
4836         (struct ada_tasks_pspace_data): Add initializers.
4837
4838 2019-05-08  Tom Tromey  <tom@tromey.com>
4839
4840         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4841         * symfile-debug.c (debug_sym_get_probes): Change type.
4842         * stap-probe.c (handle_stap_probe):
4843         (stap_static_probe_ops::get_probes): Change type.
4844         * probe.h (class static_probe_ops) <get_probes>: Change type.
4845         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4846         (parse_probes_in_pspace): Update.
4847         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4848         Update.
4849         (any_static_probe_ops::get_probes): Change type.
4850         * elfread.c (elfread_data): New typedef.
4851         (probe_key): Change type.
4852         (elf_get_probes): Likewise.  Update.
4853         (probe_key_free): Remove.
4854         (_initialize_elfread): Update.
4855         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4856         Change type.
4857         (dtrace_process_dof_probe, dtrace_process_dof)
4858         (dtrace_static_probe_ops::get_probe): Change type.
4859
4860 2019-05-08  Tom Tromey  <tom@tromey.com>
4861
4862         * xcoffread.c (struct xcoff_symfile_info): Rename from
4863         coff_symfile_info.  Add initializers.
4864         (xcoff_objfile_data_key): Move lower.  Change type.
4865         (XCOFF_DATA): Rewrite.
4866         (xcoff_free_info): Remove.
4867         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4868         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4869         (xcoff_initial_scan): Update.
4870
4871 2019-05-08  Tom Tromey  <tom@tromey.com>
4872
4873         * solib-svr4.c (struct svr4_info): Add initializers and
4874         destructor.
4875         <probes_table>: Now an htab_up.
4876         (solib_svr4_pspace_data): Change type.
4877         (free_probes_table): Simplify.
4878         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4879         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4880         (probes_table_remove_objfile_probes, register_solib_event_probe)
4881         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4882         (_initialize_svr4_solib): Update.
4883
4884 2019-05-08  Tom Tromey  <tom@tromey.com>
4885
4886         * remote.c (remote_pspace_data): Change type.
4887         (remote_pspace_data_cleanup): Remove.
4888         (get_remote_exec_file, set_pspace_remote_exec_file)
4889         (_initialize_remote): Update.
4890
4891 2019-05-08  Tom Tromey  <tom@tromey.com>
4892
4893         * breakpoint.c (breakpoint_objfile_key): Change type.
4894         (get_breakpoint_objfile_data): Update.
4895         (free_breakpoint_objfile_data): Remove.
4896         (_initialize_breakpoint): Update.
4897
4898 2019-05-08  Tom Tromey  <tom@tromey.com>
4899
4900         * linux-tdep.c (struct linux_info): Add initializers.
4901         (linux_inferior_data): Move.  Change type.
4902         (invalidate_linux_cache_inf): Update.
4903         (linux_inferior_data_cleanup): Remove.
4904         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4905
4906 2019-05-08  Tom Tromey  <tom@tromey.com>
4907
4908         * auxv.c (auxv_inferior_data): Move.  Change type.
4909         (auxv_inferior_data_cleanup): Remove.
4910         (invalidate_auxv_cache_inf): Rewrite.
4911         (get_auxv_inferior_data, _initialize_auxv): Update.
4912
4913 2019-05-08  Tom Tromey  <tom@tromey.com>
4914
4915         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4916         (symfile_debug_objfile_data_key): Change type.
4917         (symfile_debug_installed, debug_qf_has_symbols)
4918         (debug_qf_find_last_source_symtab)
4919         (debug_qf_forget_cached_source_info)
4920         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4921         (debug_qf_print_stats, debug_qf_dump)
4922         (debug_qf_expand_symtabs_for_function)
4923         (debug_qf_expand_all_symtabs)
4924         (debug_qf_expand_symtabs_with_fullname)
4925         (debug_qf_map_matching_symbols)
4926         (debug_qf_expand_symtabs_matching)
4927         (debug_qf_find_pc_sect_compunit_symtab)
4928         (debug_qf_map_symbol_filenames)
4929         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4930         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4931         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4932         (debug_sym_read_linetable, debug_sym_relocate): Update.
4933         (symfile_debug_free_objfile): Remove.
4934         (install_symfile_debug_logging, _initialize_symfile_debug):
4935         Update.
4936
4937 2019-05-08  Tom Tromey  <tom@tromey.com>
4938
4939         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4940         allocate_on_obstack.
4941         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4942         (get_dwarf2_per_objfile): Update.
4943         (set_dwarf2_per_objfile): Remove.
4944         (dwarf2_has_info, dwarf2_get_section_info): Update.
4945         (dwarf2_free_objfile): Remove.
4946         (_initialize_dwarf2_read): Update.
4947
4948 2019-05-08  Tom Tromey  <tom@tromey.com>
4949
4950         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4951         initializers.
4952         <unsupported_script_warning_printed,
4953         script_not_found_warning_printed>: Now bool.
4954         (auto_load_pspace_data): Change type.
4955         (~auto_load_pspace_info): Rename from
4956         auto_load_pspace_data_cleanup.
4957         (get_auto_load_pspace_data, init_loaded_scripts_info)
4958         (clear_section_scripts, maybe_print_unsupported_script_warning)
4959         (maybe_print_script_not_found_warning, _initialize_auto_load):
4960         Update.
4961
4962 2019-05-08  Tom Tromey  <tom@tromey.com>
4963
4964         * objfiles.c (objfile_pspace_info): Add destructor and
4965         initializers.
4966         (objfiles_pspace_data): Change type.
4967         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4968         (get_objfile_pspace_data): Update.
4969         (objfiles_bfd_data): Change type.
4970         (get_objfile_bfd_data): Update.
4971         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4972
4973 2019-05-08  Tom Tromey  <tom@tromey.com>
4974
4975         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4976         Change type.
4977         (get_catch_syscall_inferior_data): Update.
4978         (catch_syscall_inferior_data_cleanup): Remove.
4979         (_initialize_break_catch_syscall): Update.
4980
4981 2019-05-08  Tom Tromey  <tom@tromey.com>
4982
4983         * inflow.c (struct terminal_info): Add destructor and
4984         initializers.
4985         (inflow_inferior_data): Change type.
4986         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4987         (get_inflow_inferior_data, inflow_inferior_exit)
4988         (swap_terminal_info, _initialize_inflow): Update.
4989
4990 2019-05-08  Tom Tromey  <tom@tromey.com>
4991
4992         * target-dcache.c (target_dcache_cleanup): Remove.
4993         (target_dcache_aspace_key): Change type.
4994         (target_dcache_init_p, target_dcache_invalidate)
4995         (target_dcache_get, target_dcache_get_or_init)
4996         (_initialize_target_dcache): Update.
4997         * dcache.h (struct dcache_deleter): New.
4998
4999 2019-05-08  Tom Tromey  <tom@tromey.com>
5000
5001         * symtab.c (struct symbol_cache): Add destructor and
5002         initializers.
5003         (symbol_cache_key): Move.  Change type.
5004         (make_symbol_cache, free_symbol_cache): Remove.
5005         (get_symbol_cache): Update.
5006         (symbol_cache_cleanup): Remove.
5007         (ALL_PSPACES, symbol_cache_flush)
5008         (maintenance_print_symbol_cache)
5009         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5010         Update.
5011
5012 2019-05-08  Tom Tromey  <tom@tromey.com>
5013
5014         * symtab.c (struct main_info): Add destructor and initializers.
5015         (main_progspace_key): Move.  Change type.
5016         (get_main_info): Update.
5017         (main_info_cleanup): Remove.
5018         (_initialize_symtab): Update.
5019
5020 2019-05-08  Tom Tromey  <tom@tromey.com>
5021
5022         * registry.h (DECLARE_REGISTRY): Define the _key class.
5023
5024 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         * NEWS: Merge two 'New commands' sections.
5027
5028 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5029
5030         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5031         parameter and use Ada language definition instead.
5032         (ada_val_print_ptr): Remove unused language parameter.
5033         (ada_val_print_num): Remove language parameter and use Ada language
5034         definition instead.
5035         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5036         parameter.
5037         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5038         parameter and use Ada language definition instead.
5039         (ada_val_print_1): Update all ada_val_print_xxx calls.
5040         Remove language parameter.
5041         (ada_val_print): Update ada_val_print_1 call.
5042
5043 2019-05-08  Tom Tromey  <tromey@adacore.com>
5044
5045         * remote.c (remote_hw_watchpoint_limit)
5046         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5047         Now static.
5048
5049 2019-05-08  Tom Tromey  <tromey@adacore.com>
5050
5051         * maint.c (_initialize_maint_cmds): Move initialization code to
5052         remote.c.
5053         (watchdog, show_watchdog): Move to remote.c.
5054         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5055         "watchdog" static.
5056         (_initialize_remote): Move initialization code from maint.c.
5057         * defs.h (watchdog): Don't declare.
5058
5059 2019-05-08  Tom Tromey  <tromey@adacore.com>
5060
5061         * tui/tui-interp.c: Include main.h.
5062         * interps.c: Include main.h.
5063         * main.h (interpreter_p): Declare.
5064         * defs.h (interpreter_p): Don't declare.
5065
5066 2019-05-08  Tom Tromey  <tromey@adacore.com>
5067
5068         * dwarf2loc.c: Include dwarf2read.h.
5069         * defs.h (read_unsigned_leb128): Don't declare.
5070         * dwarf2read.h (read_unsigned_leb128): Declare.
5071
5072 2019-05-08  Tom Tromey  <tromey@adacore.com>
5073
5074         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5075         method.
5076
5077 2019-05-08  Tom Tromey  <tromey@adacore.com>
5078
5079         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5080         when no wrap column is set.
5081
5082 2019-05-08  Tom Tromey  <tromey@adacore.com>
5083
5084         * c-lang.c (c_get_string): Handle non-C-style arrays.
5085
5086 2019-05-08  Tom Tromey  <tromey@adacore.com>
5087
5088         * typeprint.c (print_offset_data::update): Print the bit offset,
5089         not the number of bits remaining.
5090
5091 2019-05-08  Tom Tromey  <tromey@adacore.com>
5092
5093         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5094         padding at end of comment.
5095
5096 2019-05-08  Tom Tromey  <tromey@adacore.com>
5097
5098         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5099         Compare main types.
5100
5101 2019-05-06  Tom Tromey  <tom@tromey.com>
5102
5103         * common/scoped_mmap.c: Include common-defs.h.
5104         * common/scoped_mmap.h: Don't include config.h.
5105
5106 2019-05-04  Tom Tromey  <tom@tromey.com>
5107
5108         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5109         (struct aarch64_call_info): Add initializers.
5110         <si>: Now a std::vector.
5111         (pass_on_stack, aarch64_push_dummy_call): Update.
5112
5113 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5114             Tom Tromey  <tom@tromey.com>
5115
5116         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5117         (ppc_threads): Now a std::vector.  Now static.
5118         (hwdebug_find_thread_points_by_tid)
5119         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5120         Update.
5121
5122 2019-05-04  Tom Tromey  <tom@tromey.com>
5123
5124         * arc-tdep.c (arc_tdesc_init): Return bool.
5125
5126 2019-05-04  Tom Tromey  <tom@tromey.com>
5127
5128         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5129         Use gdb_assert_not_reached.
5130
5131 2019-05-04  Tom Tromey  <tom@tromey.com>
5132
5133         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5134         "false".
5135
5136 2019-05-04  Tom Tromey  <tom@tromey.com>
5137
5138         * arc-tdep.c (arc_tdesc_init): Use bool.
5139
5140 2019-05-04  Tom Tromey  <tom@tromey.com>
5141
5142         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5143
5144 2019-05-04  Tom Tromey  <tom@tromey.com>
5145
5146         * cli/cli-cmds.c (valid_command_p): Return bool.
5147
5148 2019-05-04  Tom Tromey  <tom@tromey.com>
5149
5150         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5151         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5152
5153 2019-05-04  Raul Tambre  <raul@tambre.ee>
5154
5155         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5156         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5157         operator for comparison.
5158
5159 2019-05-04  Tom Tromey  <tom@tromey.com>
5160
5161         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5162         (lookup_partial_symbol, print_partial_symbols)
5163         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5164         (psymbol_compare): Update.
5165         (add_psymbol_to_bcache): Clear the entire psymbol.
5166         (maintenance_check_psymtabs): Update.
5167         * psympriv.h (struct partial_symbol): Don't derive from
5168         general_symbol_info.
5169         <obj_section, unrelocated_address, address,
5170         set_unrelocated_address>: Update.
5171         <ginfo>: New member.
5172         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5173         (debug_names::write_psymbols): Update.
5174
5175 2019-05-04  Tom de Vries  <tdevries@suse.de>
5176
5177         * contrib/cc-with-tweaks.sh: Support -n arg.
5178
5179 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5180
5181         * corelow.c (core_target::detach): Ensure frame cache and
5182         register caches are cleared.
5183         inferior.c (exit_inferior_1): Likewise.
5184
5185 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5186             Tom Tromey  <tom@tromey.com>
5187
5188         * dictionary.c (collate_pending_symbols_by_language): Remove
5189         "struct" from foreach.
5190         * symtab.c (lookup_global_symbol_from_objfile)
5191         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5192         foreach.
5193         * ser-tcp.c (net_open): Remove "struct" from foreach.
5194         * objfiles.c (objfile_relocate, objfile_rebase)
5195         (objfile_has_symbols): Remove "struct" from foreach.
5196         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5197         from foreach.
5198         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5199         foreach.
5200         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5201         "struct" from foreach.
5202         * ada-lang.c (create_excep_cond_exprs)
5203         (ada_exception_catchpoint_cond_string): Remove "struct" from
5204         foreach.
5205
5206 2019-05-03  Tom Tromey  <tromey@adacore.com>
5207
5208         * ada-exp.y (convert_char_literal): Check suffix of each
5209         enumerator.
5210
5211 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5212
5213         PR ada/21406:
5214         * ada-exp.y (yywrap): Don't define.
5215         * ada-lex.l (%option): Add noyywrap
5216         (yywrap): Remove.
5217
5218 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5219
5220         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5221         _WIN32_WINNT to the XP level, unless already defined to a higher
5222         level.
5223
5224         * unittests/parse-connection-spec-selftests.c:
5225         * ser-tcp.c:
5226         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5227         override.
5228
5229         * symfile.c (find_separate_debug_file): Remove colon from the
5230         drive spec of DOS/Windows file names of the target, so that the
5231         file name produced from DEBUGDIR and the target's directory will
5232         be valid on DOS/Windows systems.
5233
5234 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5235
5236         * rust-lang.c (val_print_struct): Handle printing structures
5237         containing strings.
5238
5239 2019-05-02  Tom Tromey  <tromey@adacore.com>
5240
5241         * valarith.c (_initialize_valarith): Remove.
5242
5243 2019-05-01  Tom Tromey  <tromey@adacore.com>
5244
5245         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5246         bitfields.
5247
5248 2019-05-01  Tom Tromey  <tromey@adacore.com>
5249
5250         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5251         for big-endian copies.
5252
5253 2019-04-30  Ali Tamur  <tamur@google.com>
5254         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5255         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5256         (read_3_bytes): New function.
5257
5258 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5259
5260         * windows-nat.c (main_thread_id): Delete.
5261         (handle_output_debug_string): Replace main_thread_id by
5262         current_event.dwThreadId.
5263         (fake_create_process): Likewise.
5264         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5265         Do not set main_thread_id.
5266         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5267         current_event.dwThreadId.
5268         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5269
5270 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5271
5272         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5273         Use current_event.dwThreadId instead of main_thread_id.
5274
5275 2019-04-30  Tom Tromey  <tromey@adacore.com>
5276
5277         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5278         (create_excep_cond_exprs): Iterate over program spaces.
5279         (ada_exception_catchpoint_cond_string): Examine all minimal
5280         symbols for exception types.
5281
5282 2019-04-30  Tom Tromey  <tromey@adacore.com>
5283
5284         PR c++/24470:
5285         * dwarf2read.c (process_structure_scope): Handle case where type
5286         has template parameters but no symbol was created.
5287
5288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5289             Chris January  <chris.january@arm.com>
5290
5291         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5292         qualifier.
5293         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5294
5295 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * f-typeprint.c (f_print_type): Update rules for printing
5298         whitespace.
5299         (f_type_print_varspec_suffix): Likewise.
5300
5301 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5302             Chris January  <chris.january@arm.com>
5303
5304         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5305         function arguments.
5306
5307 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5308
5309         * f-lang.c (build_fortran_types): Change name of void type to
5310         lower case.
5311         * f-typeprint.c (f_type_print_base): Print the name of the void
5312         type, rather than a fixed string.
5313         * f-valprint.c (f_decorations): Use lower case void string.
5314
5315 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5316             Chris January  <chris.january@arm.com>
5317
5318         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5319         types for Fortran.
5320
5321 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5322             Chris January  <chris.january@arm.com>
5323             David Lecomber  <david.lecomber@arm.com>
5324
5325         * f-exp.y (BINOP_INTRINSIC): New token.
5326         (exp): New parser rule handling BINOP_INTRINSIC.
5327         (f77_keywords): Add new builtin procedures.
5328         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5329         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5330         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5331         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5332         (print_unop_subexp_f): New function.
5333         (print_binop_subexp_f): New function.
5334         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5335         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5336         (dump_subexp_body_f): Likewise.
5337         (operator_check_f): Likewise.
5338         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5339         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5340
5341 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5344         UNOP_KIND.
5345         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5346         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5347         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5348         (operator_length_f): New fuction.
5349         (print_subexp_f): New function.
5350         (op_name_f): New function.
5351         (dump_subexp_body_f): New function.
5352         (operator_check_f): New function.
5353         (exp_descriptor_f): Replace standard expression handling functions
5354         with new functions.
5355         * gdb/fortran-operator.def: New file.
5356         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5357         * gdb/std-operator.def: Remove UNOP_KIND.
5358
5359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * std-operator.def: Remove unbalanced, stray double quote
5362         character.
5363
5364 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5365             Chris January  <chris.january@arm.com>
5366             Daniel Everett  <daniel.everett@arm.com>
5367             Nick Forrington  <nick.forrington@arm.com>
5368             Richard Bunt  <richard.bunt@arm.com>
5369
5370         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5371         of depth when printing anonymous structs or unions.
5372         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5373         Don't print either the top-level value, or the children if the
5374         max-depth is exceeded.
5375         (ppscm_print_children): When printing the key of a map, allow one
5376         extra level of depth.
5377         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5378         print either the top-level value, or the children if the max-depth
5379         is exceeded.
5380         (print_children): When printing the key of a map, allow one extra
5381         level of depth.
5382         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5383         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5384         (user_print_options): Initialise max_depth field.
5385         (val_print_scalar_or_string_type_p): New function.
5386         (val_print): Check to see if the max depth has been reached.
5387         (val_print_check_max_depth): Define new function.
5388         (show_print_max_depth): New function.
5389         (_initialize_valprint): Add 'print max-depth' option.
5390         * valprint.h (struct value_print_options) <max_depth>: New field.
5391         (val_print_check_max_depth): Declare new function.
5392         * NEWS: Document new feature.
5393
5394 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5395
5396         * ada-lang.c (ada_language_defn): Initialise new field.
5397         * c-lang.c (c_is_string_type_p): New function.
5398         (c_language_defn): Initialise new field.
5399         (cplus_language_defn): Initialise new field.
5400         (asm_language_defn): Initialise new field.
5401         (minimal_language_defn): Initialise new field.
5402         * c-lang.h (c_is_string_type_p): Declare new function.
5403         * d-lang.c (d_language_defn): Initialise new field.
5404         * f-lang.c (f_is_string_type_p): New function.
5405         (f_language_defn): Initialise new field.
5406         * go-lang.c (go_is_string_type_p): New function.
5407         (go_language_defn): Initialise new field.
5408         * language.c (default_is_string_type_p): New function.
5409         (unknown_language_defn): Initialise new field.
5410         (auto_language_defn): Initialise new field.
5411         * language.h (struct language_defn) <la_is_string_type_p>: New
5412         member variable.
5413         (default_is_string_type_p): Declare new function.
5414         * m2-lang.c (m2_language_defn): Initialise new field.
5415         * objc-lang.c (objc_language_defn): Initialise new field.
5416         * opencl-lang.c (opencl_language_defn): Initialise new field.
5417         * p-lang.c (pascal_is_string_type_p): New function.
5418         (pascal_language_defn): Initialise new field.
5419         * rust-lang.c (rust_is_string_type_p): New function.
5420         (rust_language_defn): Initialise new field.
5421
5422 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5423
5424         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5425         New field.
5426         * ada-lang.c (ada_language_defn): Initialise new field.
5427         * c-lang.c (c_language_defn): Likewise.
5428         (cplus_language_defn): Likewise.
5429         (asm_language_defn): Likewise.
5430         (minimal_language_defn): Likewise.
5431         * d-lang.c (d_language_defn): Likewise.
5432         * f-lang.c (f_language_defn): Likewise.
5433         * go-lang.c (go_language_defn): Likewise.
5434         * language.c (unknown_language_defn): Likewise.
5435         (auto_language_defn): Likewise.
5436         * m2-lang.c (m2_language_defn): Likewise.
5437         * objc-lang.c (objc_language_defn): Likewise.
5438         * opencl-lang.c (opencl_language_defn): Likewise.
5439         * p-lang.c (pascal_language_defn): Likewise.
5440         * rust-lang.c (rust_language_defn): Likewise.
5441
5442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * ada-lang.c (ada_is_character_type): Change return type to bool.
5445         (ada_is_string_type): Likewise.
5446         * ada-lang.h (ada_is_character_type): Update declaration
5447         (ada_is_string_type): Likewise.
5448
5449 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5450
5451         Support style in 'frame|thread apply'
5452
5453         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5454         * record.c (record_start, record_stop): Update callers of
5455         execute_command_to_string with false.
5456         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5457         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5458         methods.
5459         (class string_file): New constructor with term_out parameter.
5460         Override methods term_out and can_emit_style_escape.  New member
5461         term_out.
5462         (class stdio_file): Override can_emit_style_escape.
5463         (class tee_file): Override term_out and can_emit_style_escape.
5464         * utils.h (can_emit_style_escape): Remove.
5465         * utils.c (can_emit_style_escape): Likewise.
5466         Update all callers of can_emit_style_escape (SOMESTREAM) to
5467         SOMESTREAM->can_emit_style_escape.
5468         * source-cache.c (source_cache::get_source_lines): Likewise.
5469         * stack.c (frame_apply_command_count): Call execute_command_to_string
5470         passing the term_out characteristic of the current gdb_stdout.
5471         * thread.c (thr_try_catch_cmd): Likewise.
5472         * top.c (execute_command_to_string): pass term_out parameter
5473         to construct the string_file for the command output.
5474         * ui-file.c (term_cli_styling): New function (most code moved
5475         from utils.c can_emit_style_escape).
5476         (string_file::string_file, string_file::can_emit_style_escape,
5477         stdio_file::can_emit_style_escape, tee_file::term_out,
5478         tee_file::can_emit_style_escape): New functions.
5479
5480 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5481
5482         * NEWS: Mention the new set|show may-call-functions.
5483         * infcall.c (may_call_functions_p): New variable.
5484         (show_may_call_functions_p): New function.
5485         (call_function_by_hand_dummy): Throws an error if not
5486         may-call-functions.
5487         (_initialize_infcall): Call add_setshow_boolean_cmd for
5488         may-call-functions.
5489
5490 2019-04-25  Keith Seitz  <keiths@redhat.com>
5491
5492         PR c++/24367
5493         * cp-support.c (inspect_type): Don't attempt substitutions
5494         of symbol with the same name.
5495
5496 2019-04-25  Tom Tromey  <tromey@adacore.com>
5497
5498         PR gdb/24475:
5499         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5500         static.
5501
5502 2019-04-25  Tom Tromey  <tromey@adacore.com>
5503
5504         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5505         rvalue reference.
5506         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5507         (gdb_xml_parser::parse): Use std::move.
5508         * python/python-internal.h (gdbpy_convert_exception): Take a const
5509         reference.
5510         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5511         std::move.
5512         * python/py-utils.c (gdbpy_convert_exception): Take a const
5513         reference.
5514         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5515         Use std::move.
5516         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5517         Use std::move.
5518         * mi/mi-main.c (mi_print_exception): Take a const reference.
5519         * main.c (handle_command_errors): Take a const reference.
5520         * linespec.c (parse_linespec): Use std::move.
5521         * infcall.c (run_inferior_call): Use std::move.
5522         (call_function_by_hand_dummy): Use std::move.
5523         * exec.c (try_open_exec_file): Use std::move.
5524         * exceptions.h (exception_print, exception_fprintf)
5525         (exception_print_same): Update.
5526         * exceptions.c (print_exception, exception_print)
5527         (exception_fprintf, exception_print_same): Change parameters to
5528         const reference.
5529         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5530         * common/new-op.c: Use std::move.
5531         * common/common-exceptions.h (struct gdb_exception): Add move
5532         constructor.
5533         (struct gdb_exception_error, struct gdb_exception_quit, struct
5534         gdb_quit_bad_alloc): Change constructor to move constructor.
5535         (throw_exception): Change parameter to rvalue reference.
5536         * common/common-exceptions.c (throw_exception): Take rvalue
5537         reference.
5538         * cli/cli-interp.c (safe_execute_command): Use std::move.
5539         * breakpoint.c (insert_bp_location, location_to_sals): Use
5540         std::move.
5541
5542 2019-04-25  Tom Tromey  <tromey@adacore.com>
5543
5544         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5545         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5546         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5547         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5548         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5549         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5550         guile/scm-value.c: Use unpack.
5551         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5552         gdbscm_gdb_exception.
5553         (gdbscm_throw_gdb_exception): Likewise.
5554         (struct gdbscm_gdb_exception): New.
5555         (unpack): New function.
5556         (gdbscm_wrap): Use unpack.
5557
5558 2019-04-25  Tom Tromey  <tromey@adacore.com>
5559
5560         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5561         (gdb_rl_callback_handler): Use std::move.
5562         * common/common-exceptions.h (struct gdb_exception): Add move
5563         assignment operator.
5564         (throw_exception_sjlj): Change "exception" to const reference.
5565         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5566         (throw_exception_sjlj): Change "exception" to const reference.
5567
5568 2019-04-25  Tom Tromey  <tromey@adacore.com>
5569
5570         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5571         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5572         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5573         Update.
5574         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5575         Update.
5576         * mi/mi-interp.c (mi_interp::exec): Update.
5577         * linespec.c (parse_linespec): Update.
5578         * infcall.c (run_inferior_call): Update.
5579         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5580         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5581         (gdbscm_lookup_global_symbol): Update.
5582         * guile/scm-param.c (gdbscm_parameter_value): Update.
5583         * guile/scm-frame.c (gdbscm_frame_read_register)
5584         (gdbscm_frame_read_var): Update.
5585         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5586         * exec.c (try_open_exec_file): Update.
5587         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5588         (gdb_rl_callback_handler): Update.
5589         * common/common-exceptions.h (exception_none): Don't declare.
5590         * common/common-exceptions.c (exception_none): Don't define.
5591         (struct catcher) <exception>: Update.
5592         * cli/cli-interp.c (safe_execute_command): Update.
5593         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5594
5595 2019-04-25  Ali Tamur  <tamur@google.com>
5596
5597         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5598         (read_attribute_value): Likewise.
5599         (dwarf2_read_addr_index): Update comment.
5600         (read_str_index): Add DW_FORM_strx.
5601         (dwarf2_string_attr): Likewise.
5602         (dwarf2_const_value_attr): Likewise.
5603         (dump_die_shallow): Likewise.
5604         (dwarf2_fetch_constant_bytes): Likewise.
5605         (skip_form_bytes): Likewise.
5606         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5607
5608 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5609
5610         PR corefiles/11608
5611         PR corefiles/18187
5612         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5613         OFFSET.  Verify if current mapping contains an ELF header.
5614         (linux_find_memory_regions_full): Adjust call to
5615         dump_mapping_p.
5616
5617 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5618             Kang Li <kanglictf@gmail.com>
5619
5620         PR gdb/21600
5621
5622         * dwarf2-frame.c (read_initial_length): Be consistent about using
5623         unsigned representation of length.
5624         (decode_frame_entry_1): Likewise.  Check for wraparound of
5625         end pointer as well as buffer overflow.
5626
5627 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5628
5629         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5630         "vq".
5631
5632 2019-04-24  Tom Tromey  <tromey@adacore.com>
5633
5634         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5635
5636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5637
5638         * s12z-tdep.c (s12z_unwind_pc): Delete.
5639         (s12z_unwind_sp): Delete.
5640         (s12z_gdbarch_init): Don't register deleted functions with
5641         gdbarch.
5642
5643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5644
5645         * rl78-tdep.c (rl78_unwind_sp): Delete.
5646         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5647
5648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5651         (xstormy16_unwind_pc): Delete.
5652         (xstormy16_dummy_id): Delete.
5653         (xstormy16_gdbarch_init): Don't register deleted functions with
5654         gdbarch.
5655
5656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * vax-tdep.c (vax_unwind_pc): Delete.
5659         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5660
5661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * v850-tdep.c (v850_unwind_sp): Delete.
5664         (v850_unwind_pc): Delete.
5665         (v850_dummy_id): Delete.
5666         (v850_gdbarch_init): Don't register deleted functions with
5667         gdbarch.
5668
5669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5670
5671         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5672         (tilegx_unwind_pc): Delete.
5673         (tilegx_unwind_dummy_id): Delete.
5674         (tilegx_gdbarch_init): Don't register deleted functions with
5675         gdbarch.
5676
5677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5678
5679         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5680         (tic6x_dummy_id): Delete.
5681         (tic6x_gdbarch_init): Don't register deleted functions with
5682         gdbarch.
5683
5684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * sparc-tdep.c (sparc_unwind_pc): Delete.
5687         (sparc32_gdbarch_init): Don't register deleted function with
5688         gdbarch.
5689
5690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5691
5692         * sh-tdep.c (sh_unwind_sp): Delete.
5693         (sh_unwind_pc): Delete.
5694         (sh_dummy_id): Delete.
5695         (sh_gdbarch_init): Don't register deleted functions with
5696         gdbarch.
5697
5698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * score-tdep.c (score_unwind_sp): Delete.
5701         (score_unwind_pc): Delete.
5702         (score_dummy_id): Delete.
5703         (score_gdbarch_init): Don't register deleted functions with
5704         gdbarch.
5705
5706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * rx-tdep.c (rx_unwind_pc): Delete.
5709         (rx_unwind_sp): Delete.
5710         (rx_dummy_id): Delete.
5711         (rx_gdbarch_init): Don't register deleted functions with
5712         gdbarch.  Update comment.
5713
5714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5715
5716         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5717         (rs6000_dummy_id): Delete.
5718         (rs6000_gdbarch_init): Don't register deleted functions with
5719         gdbarch.
5720
5721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5722
5723         * or1k-tdep.c (or1k_dummy_id): Delete.
5724         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5725
5726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * nios2-tdep.c (nios2_dummy_id): Delete.
5729         (nios2_unwind_sp): Delete.
5730         (nios2_gdbarch_init): Don't register deleted functions with
5731         gdbarch.
5732
5733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5734
5735         * nds32-tdep.c (nds32_dummy_id): Delete.
5736         (nds32_unwind_pc): Delete.
5737         (nds32_unwind_sp): Delete.
5738         (nds32_gdbarch_init): Don't register deleted functions with
5739         gdbarch.
5740
5741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * msp430-tdep.c (msp430_unwind_pc): Delete.
5744         (msp430_unwind_sp): Delete.
5745         (msp430_dummy_id): Delete.
5746         (msp430_gdbarch_init): Don't register deleted functions with
5747         gdbarch.
5748
5749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5750
5751         * moxie-tdep.c (moxie_unwind_sp): Delete.
5752         (moxie_unwind_pc): Delete.
5753         (moxie_dummy_id): Delete.
5754         (moxie_gdbarch_init): Don't register deleted functions with
5755         gdbarch.
5756
5757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5758
5759         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5760         (mn10300_unwind_pc): Delete.
5761         (mn10300_unwind_sp): Delete.
5762         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5763         mn10300_unwind_sp.
5764         (mn10300_frame_unwind_init): Don't register deleted functions with
5765         gdbarch.
5766
5767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * mep-tdep.c (mep_unwind_pc): Delete.
5770         (mep_unwind_sp): Delete.
5771         (mep_dummy_id): Delete.
5772         (mep_gdbarch_init): Don't register deleted functions with
5773         gdbarch.
5774
5775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5776
5777         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5778         (m68hc11_unwind_sp): Delete.
5779         (m68hc11_gdbarch_init): Don't register deleted functions with
5780         gdbarch.
5781
5782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * m32r-tdep.c (m32r_unwind_sp): Delete.
5785         (m32r_unwind_pc): Delete.
5786         (m32r_dummy_id): Delete.
5787         (m32r_gdbarch_init): Don't register deleted functions with
5788         gdbarch.
5789
5790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5791
5792         * m32c-tdep.c (m32c_unwind_pc): Delete.
5793         (m32c_unwind_sp): Delete.
5794         (m32c_dummy_id): Delete.
5795         (m32c_gdbarch_init): Don't register deleted functions with
5796         gdbarch.
5797
5798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5801         (lm32_unwind_pc): Delete.
5802         (lm32_dummy_id): Delete.
5803         (lm32_gdbarch_init): Don't register deleted functions with
5804         gdbarch.
5805
5806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5809         (iq2000_unwind_pc): Delete.
5810         (iq2000_dummy_id): Delete.
5811         (iq2000_gdbarch_init): Don't register deleted functions with
5812         gdbarch.
5813
5814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5815
5816         * nds32-tdep.c (nds32_type_align): Delete.
5817         (nds32_push_dummy_call): Use type_align instead.
5818
5819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5820
5821         * arm-tdep.c (arm_type_align): Only handle vector override case.
5822         (arm_push_dummy_call): Use type_align.
5823         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5824
5825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5826
5827         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5828         case.
5829         (pass_on_stack): Use type_align.
5830         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5831         function.
5832
5833 2019-04-23  Tom Tromey  <tromey@adacore.com>
5834
5835         * dwarf2read.c (line_header::file_name_at): Remove unused
5836         overload.
5837
5838 2019-04-23  Tom de Vries  <tdevries@suse.de>
5839
5840         PR gdb/24438
5841         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5842         invocation.
5843
5844
5845 2019-03-27  Ali Tamur  <tamur@google.com>
5846
5847         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5848         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5849         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5850         (dwarf_expr_context::get_addr_index): Likewise
5851         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5852         (symbol_needs_eval_context::get_addr_index): Likewise
5853         (disassemble_dwarf_expression): Add DW_OP_addrx
5854         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5855         (read_cutu_die_from_dwo): Update comment
5856         (skip_one_die): Add DW_FORM_addrx
5857         (read_attribute_value): Likewise
5858         (var_decode_location): Add DW_OP_addrx
5859         (dwarf2_const_value_attr): Add DW_FORM_addrx
5860         (dump_die_shallow): Likewise
5861         (dwarf2_fetch_constant_bytes): Likewise
5862         (decode_locdesc): Add DW_OP_addrx
5863         (skip_form_bytes): Add DW_FORM_addrx
5864
5865 2019-04-22  Ali Tamur  <tamur@google.com>
5866
5867         * MAINTAINERS (Write After Approval): Add self.
5868
5869 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5870
5871         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5872         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5873         (open_symbol_file_object): Likewise.
5874         (svr4_default_sos): Add info parameter.
5875         (svr4_read_so_list): Likewise.
5876         (svr4_current_sos_direct): Adjust functions calls to pass down
5877         info.
5878         (svr4_current_sos_1): Add info parameter.
5879         (svr4_current_sos): Call get_svr4_info, pass info down to
5880         svr4_current_sos_1.
5881         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5882         get_svr4_info.
5883         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5884         get_svr4_info.
5885         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5886         to get_svr4_info.
5887         (probes_table_remove_objfile_probes): Likewise.
5888         (register_solib_event_probe): Add info parameter.
5889         (solist_update_incremental): Pass info parameter down to
5890         svr4_read_so_list.
5891         (disable_probes_interface): Add info parameter.
5892         (svr4_handle_solib_event): Pass current_program_space to
5893         get_svr4_info.  Adjust disable_probes_interface cleanup.
5894         (svr4_create_probe_breakpoints): Add info parameter, pass it
5895         down to register_solib_event_probe.
5896         (svr4_create_solib_event_breakpoints): Add info parameter,
5897         pass it down to svr4_create_probe_breakpoints.
5898         (enable_break): Pass info down to
5899         svr4_create_solib_event_breakpoints.
5900         (svr4_solib_create_inferior_hook): Pass current_program_space to
5901         get_svr4_info.
5902         (svr4_clear_solib): Likewise.
5903
5904 2019-04-22  Pedro Alves  <palves@redhat.com>
5905
5906         * solib-svr4.c (svr4_free_objfile_observer): New.
5907         (probe_and_action::objfile): New field.
5908         (probes_table_htab_remove_objfile_probes)
5909         (probes_table_remove_objfile_probes): New functions.
5910         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5911         in the new probe_and_action.  Don't store the probe in 'lookup'.
5912         (svr4_create_probe_breakpoints): Pass objfile to
5913         register_solib_event_probe.
5914         (_initialize_svr4_solib): Register a free_objfile observer.
5915
5916 2019-04-19  Tom Tromey  <tom@tromey.com>
5917
5918         * common/queue.h: Remove.
5919
5920 2019-04-19  Tom Tromey  <tom@tromey.com>
5921
5922         * event-loop.c: Don't include "common/queue.h".
5923
5924 2019-04-19  Tom Tromey  <tom@tromey.com>
5925
5926         * remote.c (remote_target): Use delete.
5927         * remote-notif.h: Include <list>, not "common/queue.h".
5928         (notif_client_p): Remove typedef.
5929         (remote_notif_state): Add constructor, destructor, initializer.
5930         <notif_queue>: Now a std::list.
5931         (remote_notif_state_xfree): Don't declare.
5932         * remote-notif.c (remote_notif_process, handle_notification)
5933         (remote_notif_state_allocate): Update.
5934         (~remote_notif_state): Rename from remote_notif_state_xfree.
5935
5936 2019-04-19  Tom Tromey  <tom@tromey.com>
5937
5938         * symfile.c (reread_symbols): Update.
5939         * objfiles.c (objfile_register_static_link)
5940         (objfile_lookup_static_link): Update
5941         (~objfile) Don't delete static_links.
5942         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5943
5944 2019-04-19  Tom Tromey  <tom@tromey.com>
5945
5946         * type-stack.h (struct type_stack) <insert>: Constify string.
5947         * type-stack.c (type_stack::insert): Constify string.
5948         * gdbtypes.h (lookup_template_type): Update.
5949         (address_space_name_to_int): Update.
5950         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5951         const.
5952         (lookup_template_type): Make name const.
5953         * c-exp.y: Update rules.
5954         (lex_one_token, classify_name, classify_inner_name)
5955         (c_print_token): Update.
5956         * p-exp.y: Update rules.
5957         (yylex): Update.
5958         * f-exp.y: Update rules.
5959         (yylex): Update.
5960         * d-exp.y: Update rules.
5961         (lex_one_token, classify_name, classify_inner_name): Update.
5962         * parse.c (write_dollar_variable, copy_name): Return std::string.
5963         * parser-defs.h (copy_name): Change return type.
5964         * m2-exp.y: Update rules.
5965         (yylex): Update.
5966         * go-exp.y (lex_one_token): Update.
5967         Update rules.
5968         (classify_unsafe_function, classify_packaged_name)
5969         (classify_name, yylex): Update.
5970
5971 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5972
5973         * configure.ac: add --enable-source-highlight switch.
5974         * configure: Regenerate.
5975         * top.c (print_gdb_version): plumb --enable-source-highlight
5976         status to "show configuration".
5977
5978 2019-04-19  Tom Tromey  <tromey@adacore.com>
5979
5980         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5981         Check ADA_TYPE_P.
5982         (empty_record, ada_template_to_fixed_record_type_1)
5983         (template_to_static_fixed_type)
5984         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5985         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5986         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5987         macros.
5988
5989 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5990
5991         PR symtab/24423:
5992         * source.c (print_source_lines_base): Advance "iter" when a
5993         control character is seen.
5994
5995 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5996
5997         * inferior.h (struct infcall_suspend_state_deleter):
5998         Catch exception in destructor to avoid crash.
5999
6000 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6001
6002         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6003         close to the add_com "shell".
6004
6005 2019-04-18  Tom Tromey  <tromey@adacore.com>
6006
6007         * process-stratum-target.h (class process_stratum_target)
6008         <stratum>: Add "final".
6009
6010 2019-04-17  Tom Tromey  <tromey@adacore.com>
6011
6012         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6013         against nullptr before use.
6014
6015 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6016
6017         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6018
6019 2019-04-17  Jim Wilson  <jimw@sifive.com>
6020             Andrew Burgess  <andrew.burgess@embecosm.com>
6021
6022         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6023         code read might fail, assume 4-byte breakpoint in that case.
6024
6025 2019-04-15  Leszek Swirski  <leszeks@google.com>
6026
6027         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6028         rather than a hand-rolled POD check when checking for forced MEMORY
6029         classification.
6030
6031 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6032
6033         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6034         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6035         function.
6036         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6037         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6038         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6039         declaration.
6040
6041 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6042
6043         * aarch64-linux-nat.c
6044         (aarch64_linux_nat_target::thread_architecture): Add override.
6045         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6046         each VQ.
6047
6048 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6049
6050         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6051
6052 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6053
6054         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6055         target types of size 96-bits, add some additional comments, and
6056         check that the builtin type we found was the correct size.
6057
6058 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6059
6060         * utils.c (prompt_for_continue): Don't restore the styling at the
6061         end, as applied_style has the wrong value.  This fixes styling in
6062         long lists of file names that are interrupted by the "Continue?"
6063         prompt.
6064
6065 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6068         * c-lang.c (c_language_defn): Likewise.
6069         (cplus_language_defn): Likewise.
6070         (asm_language_defn): Likewise.
6071         (minimal_language_defn): Likewise.
6072         * d-lang.c (d_language_defn): Likewise.
6073         * f-lang.c (f_language_defn): Likewise.
6074         * go-lang.c (go_language_defn): Likewise.
6075         * language.c (unknown_language_defn): Likewise.
6076         (auto_language_defn): Likewise.
6077         * language.h (struct language_defn): Remove la_magic field.
6078         (LANG_MAGIC): Delete.
6079         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6080         * objc-lang.c (objc_language_defn): Likewise.
6081         * opencl-lang.c (opencl_language_defn): Likewise.
6082         * p-lang.c (pascal_language_defn): Likewise.
6083         * rust-lang.c (rust_language_defn): Likewise.
6084
6085 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * riscv-tdep.c (riscv_type_align): New function.
6088         (riscv_type_alignment): Delete.
6089         (riscv_arg_location): Use 'type_align'.
6090         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6091
6092 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6093
6094         * gdbtypes.c (type_align): A struct with no non-static fields also
6095         has alignment of 1.
6096
6097 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6100         component to 0.
6101         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6102         member.
6103         (riscv_struct_info::analyse): New implementation using new
6104         analyse_inner member function.
6105         (riscv_struct_info::field_offset): New member function.
6106         (riscv_struct_info::m_offsets): New member variable.
6107         (riscv_struct_info::analyse_inner): New private member function,
6108         takes the old implementation of riscv_struct_info::analyse but
6109         extended to track field offsets.
6110         (riscv_call_arg_struct): Update the struct folding special cases
6111         to handle cases where empty C++ structs, which are non-zero
6112         length, are found.
6113         (riscv_arg_location): Initialise the length of each location, a
6114         non-zero length now indicates the location is in use.
6115         (riscv_push_dummy_call): Allow for the first location having a
6116         non-zero offset when setting up arguments.
6117         (riscv_return_value): Likewise, but for return values.
6118
6119 2019-04-11  Tom Tromey  <tromey@adacore.com>
6120
6121         * utils.c (internal_vproblem): Make "msg" const.
6122
6123 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6124
6125         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6126         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6127         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6128         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6129
6130 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6131
6132         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6133         function.
6134         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6135         of amd64_collect_native_gregset.
6136         (amd64_linux_nat_target::store_registers): Likewise.
6137
6138 2019-04-10  Tom Tromey  <tom@tromey.com>
6139
6140         * symtab.c (lookup_global_symbol_from_objfile)
6141         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6142         * objfiles.h (class separate_debug_iterator): New.
6143         (class separate_debug_range): New.
6144         (struct objfile) <separate_debug_objfiles>: New method.
6145         (objfile_separate_debug_iterate): Don't declare.
6146         * objfiles.c (separate_debug_iterator::operator++): Rename from
6147         objfile_separate_debug_iterate.
6148         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6149         iterator.
6150         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6151         iterator.
6152
6153 2019-04-10  Tom Tromey  <tom@tromey.com>
6154
6155         * symfile.c (reread_symbols): Remove old comment.
6156         * objfiles.c (free_all_objfiles): Fix a typo.
6157
6158 2019-04-10  Tom Tromey  <tom@tromey.com>
6159
6160         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6161         * minsyms.c (lookup_minimal_symbol): Use foreach.
6162         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6163         (lookup_minimal_symbol_solib_trampoline): Likewise.
6164         * symfile.c (reread_symbols): Use foreach.
6165
6166 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6167             Tom Tromey  <tromey@adacore.com>
6168
6169         PR rust/24414:
6170         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6171         (rust_lex_int_test): Change "value" to be LONGEST.
6172         (rust_lex_tests): Add test for long integer literal.
6173
6174 2019-04-09  Tom Tromey  <tromey@adacore.com>
6175
6176         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6177         to bool.
6178         (extended_remote_target::attach): Update.
6179         (remote_target::remote_notice_new_inferior): Update.
6180         (remote_target::add_current_inferior_and_thread): Update.
6181         * inferior.c (exit_inferior_1): Use "false".
6182         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6183
6184 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6185
6186         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6187         the "start" command.
6188
6189 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6190
6191         * python/py-inferior.c (infpy_thread_from_thread_handle):
6192         Adjust comments to reflect renaming of thread_from_thread_handle
6193         to thread_from_handle.  Adjust keywords.  Fix type error message.
6194         (inferior_object_methods): Add thread_from_handle.  Retain
6195         thread_from_thread_handle, but mark it as deprecated.
6196
6197 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6198
6199         * gdbthread.h (find_thread_by_handle): Revise declaration.
6200         * thread.c (find_thread_by_handle): Likewise.  Adjust
6201         implementation too.
6202         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6203         support for buffer objects as handles.
6204
6205 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6206
6207         * python/py-infthread.c (thpy_thread_handle): New function.
6208         (thread_object_methods): Register thpy_thread_handle.
6209
6210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6211
6212         * gdbthread.h (thread_to_thread_handle): Declare.
6213         * thread.c (gdbtypes.h): Include.
6214         (thread_to_thread_handle): New function.
6215
6216         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6217         (target_thread_info_to_thread_handle): Declare.
6218         * target.c (target_thread_info_to_thread_handle): New function.
6219         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6220         * target-delegates.c: Regenerate.
6221
6222         * linux-thread-db.c (class thread_db_target): Add method
6223         thread_info_to_thread_handle.
6224         (thread_db_target::thread_info_to_thread_handle): Define.
6225         * remote.c (class remote_target): Add new method
6226         thread_info_to_thread_handle.
6227         (remote_target::thread_info_to_thread_handle): Define.
6228
6229 2019-04-08  Pedro Alves  <palves@redhat.com>
6230
6231         * common/common-exceptions.c (throw_exception): Don't create
6232         named object to throw; throw directly.
6233         (throw_it): Likewise.  Don't initialize gdb_exception::message
6234         here, with new; pass FMT and AP to the ctor instead.
6235         * common/common-exceptions.h: Include <string>.
6236         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6237         const char *, va_list)): New ctor.  Use std::make_shared.
6238         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6239         errors)): Delete.
6240         (gdb_exception_error::gdb_exception_error(enum errors, const char
6241         *, va_list)): New.
6242         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6243         Add assertion.
6244         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6245         errors)): Delete.
6246         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6247         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6248         Add assertion.
6249
6250 2019-04-08  Tom Tromey  <tom@tromey.com>
6251
6252         * valops.c (value_rtti_indirect_type): Replace throw_exception
6253         with throw.
6254         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6255         with throw.
6256         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6257         throw.
6258         * target.c (target_translate_tls_address): Replace throw_exception
6259         with throw.
6260         * stack.c (frame_apply_command_count): Replace throw_exception
6261         with throw.
6262         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6263         throw.
6264         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6265         with throw.
6266         * rs6000-tdep.c (rs6000_frame_cache)
6267         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6268         * remote.c: Replace throw_exception with throw.
6269         * record-full.c (record_full_message, record_full_wait_1)
6270         (record_full_restore): Replace throw_exception with throw.
6271         * record-btrace.c:
6272         (get_thread_current_frame_id, record_btrace_start_replaying)
6273         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6274         (cmd_record_btrace_start): Replace throw_exception with throw.
6275         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6276         throw.
6277         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6278         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6279         * linespec.c:
6280         (find_linespec_symbols): Replace throw_exception with throw.
6281         * infrun.c (displaced_step_prepare, resume): Replace
6282         throw_exception with throw.
6283         * infcmd.c (post_create_inferior): Replace throw_exception with
6284         throw.
6285         * inf-loop.c (inferior_event_handler): Replace throw_exception
6286         with throw.
6287         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6288         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6289         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6290         (get_prev_frame_always, get_frame_pc_if_available)
6291         (get_frame_address_in_block_if_available, get_frame_language):
6292         Replace throw_exception with throw.
6293         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6294         throw_exception with throw.
6295         * eval.c (fetch_subexp_value, evaluate_var_value)
6296         (evaluate_funcall, evaluate_subexp_standard): Replace
6297         throw_exception with throw.
6298         * dwarf2loc.c (call_site_find_chain)
6299         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6300         Replace throw_exception with throw.
6301         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6302         with throw.
6303         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6304         throw.
6305         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6306         * completer.c (complete_line_internal): Replace throw_exception
6307         with throw.
6308         * compile/compile-object-run.c (compile_object_run): Replace
6309         throw_exception with throw.
6310         * cli/cli-script.c (process_next_line): Replace throw_exception
6311         with throw.
6312         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6313         (btrace_enable, btrace_maint_update_pt_packets): Replace
6314         throw_exception with throw.
6315         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6316         throw_exception with throw.
6317         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6318         throw_exception with throw.
6319         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6320         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6321         * aarch64-tdep.c (aarch64_make_prologue_cache)
6322         (aarch64_make_stub_cache): Replace throw_exception with throw.
6323
6324 2019-04-08  Tom Tromey  <tom@tromey.com>
6325
6326         * common/common-exceptions.c (throw_exception): Rename from
6327         throw_exception_cxx.  Remove old copy.  Make argument const.
6328         (throw_it): Create and throw exception objects directly.
6329         * common/common-exceptions.h (throw_exception): Make argument
6330         const.
6331         (struct gdb_exception_error): Add constructor.
6332         (struct gdb_exception_quit): Add constructor.
6333
6334 2019-04-08  Tom Tromey  <tom@tromey.com>
6335
6336         * common/common-exceptions.h (exception_rethrow): Don't declare.
6337         (TRY_SJLJ): Update comment.
6338         (TRY, CATCH, END_CATCH): Remove.
6339         * common/common-exceptions.c (exception_rethrow): Remove.
6340
6341 2019-04-08  Tom Tromey  <tom@tromey.com>
6342
6343         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6344         Remove.
6345         (gdb_exception_error): Rename from
6346         gdb_exception_RETURN_MASK_ERROR.
6347         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6348         (gdb_quit_bad_alloc): Update.
6349         * aarch64-tdep.c: Update.
6350         * ada-lang.c: Update.
6351         * ada-typeprint.c: Update.
6352         * ada-valprint.c: Update.
6353         * amd64-tdep.c: Update.
6354         * arch-utils.c: Update.
6355         * break-catch-throw.c: Update.
6356         * breakpoint.c: Update.
6357         * btrace.c: Update.
6358         * c-varobj.c: Update.
6359         * cli/cli-cmds.c: Update.
6360         * cli/cli-interp.c: Update.
6361         * cli/cli-script.c: Update.
6362         * common/common-exceptions.c: Update.
6363         * common/new-op.c: Update.
6364         * common/selftest.c: Update.
6365         * compile/compile-c-symbols.c: Update.
6366         * compile/compile-cplus-symbols.c: Update.
6367         * compile/compile-object-load.c: Update.
6368         * compile/compile-object-run.c: Update.
6369         * completer.c: Update.
6370         * corelow.c: Update.
6371         * cp-abi.c: Update.
6372         * cp-support.c: Update.
6373         * cp-valprint.c: Update.
6374         * darwin-nat.c: Update.
6375         * disasm-selftests.c: Update.
6376         * dtrace-probe.c: Update.
6377         * dwarf-index-cache.c: Update.
6378         * dwarf-index-write.c: Update.
6379         * dwarf2-frame-tailcall.c: Update.
6380         * dwarf2-frame.c: Update.
6381         * dwarf2loc.c: Update.
6382         * dwarf2read.c: Update.
6383         * eval.c: Update.
6384         * event-loop.c: Update.
6385         * event-top.c: Update.
6386         * exec.c: Update.
6387         * f-valprint.c: Update.
6388         * fbsd-tdep.c: Update.
6389         * frame-unwind.c: Update.
6390         * frame.c: Update.
6391         * gdbtypes.c: Update.
6392         * gnu-v3-abi.c: Update.
6393         * guile/guile-internal.h: Update.
6394         * guile/scm-block.c: Update.
6395         * guile/scm-breakpoint.c: Update.
6396         * guile/scm-cmd.c: Update.
6397         * guile/scm-disasm.c: Update.
6398         * guile/scm-frame.c: Update.
6399         * guile/scm-lazy-string.c: Update.
6400         * guile/scm-math.c: Update.
6401         * guile/scm-param.c: Update.
6402         * guile/scm-ports.c: Update.
6403         * guile/scm-pretty-print.c: Update.
6404         * guile/scm-symbol.c: Update.
6405         * guile/scm-symtab.c: Update.
6406         * guile/scm-type.c: Update.
6407         * guile/scm-value.c: Update.
6408         * i386-linux-tdep.c: Update.
6409         * i386-tdep.c: Update.
6410         * inf-loop.c: Update.
6411         * infcall.c: Update.
6412         * infcmd.c: Update.
6413         * infrun.c: Update.
6414         * jit.c: Update.
6415         * language.c: Update.
6416         * linespec.c: Update.
6417         * linux-fork.c: Update.
6418         * linux-nat.c: Update.
6419         * linux-tdep.c: Update.
6420         * linux-thread-db.c: Update.
6421         * main.c: Update.
6422         * mi/mi-cmd-break.c: Update.
6423         * mi/mi-cmd-stack.c: Update.
6424         * mi/mi-interp.c: Update.
6425         * mi/mi-main.c: Update.
6426         * objc-lang.c: Update.
6427         * p-valprint.c: Update.
6428         * parse.c: Update.
6429         * ppc-linux-tdep.c: Update.
6430         * printcmd.c: Update.
6431         * python/py-arch.c: Update.
6432         * python/py-breakpoint.c: Update.
6433         * python/py-cmd.c: Update.
6434         * python/py-finishbreakpoint.c: Update.
6435         * python/py-frame.c: Update.
6436         * python/py-framefilter.c: Update.
6437         * python/py-gdb-readline.c: Update.
6438         * python/py-inferior.c: Update.
6439         * python/py-infthread.c: Update.
6440         * python/py-lazy-string.c: Update.
6441         * python/py-linetable.c: Update.
6442         * python/py-objfile.c: Update.
6443         * python/py-param.c: Update.
6444         * python/py-prettyprint.c: Update.
6445         * python/py-progspace.c: Update.
6446         * python/py-record-btrace.c: Update.
6447         * python/py-record.c: Update.
6448         * python/py-symbol.c: Update.
6449         * python/py-type.c: Update.
6450         * python/py-unwind.c: Update.
6451         * python/py-utils.c: Update.
6452         * python/py-value.c: Update.
6453         * python/python.c: Update.
6454         * record-btrace.c: Update.
6455         * record-full.c: Update.
6456         * remote-fileio.c: Update.
6457         * remote.c: Update.
6458         * riscv-tdep.c: Update.
6459         * rs6000-aix-tdep.c: Update.
6460         * rs6000-tdep.c: Update.
6461         * rust-exp.y: Update.
6462         * rust-lang.c: Update.
6463         * s390-tdep.c: Update.
6464         * selftest-arch.c: Update.
6465         * solib-dsbt.c: Update.
6466         * solib-frv.c: Update.
6467         * solib-spu.c: Update.
6468         * solib-svr4.c: Update.
6469         * solib.c: Update.
6470         * sparc64-linux-tdep.c: Update.
6471         * stack.c: Update.
6472         * symfile-mem.c: Update.
6473         * symmisc.c: Update.
6474         * target.c: Update.
6475         * thread.c: Update.
6476         * top.c: Update.
6477         * tracefile-tfile.c: Update.
6478         * tui/tui.c: Update.
6479         * typeprint.c: Update.
6480         * unittests/cli-utils-selftests.c: Update.
6481         * unittests/parse-connection-spec-selftests.c: Update.
6482         * valops.c: Update.
6483         * valprint.c: Update.
6484         * value.c: Update.
6485         * varobj.c: Update.
6486         * windows-nat.c: Update.
6487         * x86-linux-nat.c: Update.
6488         * xml-support.c: Update.
6489
6490 2019-04-08  Tom Tromey  <tom@tromey.com>
6491
6492         * xml-support.c: Use C++ exception handling.
6493         * x86-linux-nat.c: Use C++ exception handling.
6494         * windows-nat.c: Use C++ exception handling.
6495         * varobj.c: Use C++ exception handling.
6496         * value.c: Use C++ exception handling.
6497         * valprint.c: Use C++ exception handling.
6498         * valops.c: Use C++ exception handling.
6499         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6500         handling.
6501         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6502         * typeprint.c: Use C++ exception handling.
6503         * tui/tui.c: Use C++ exception handling.
6504         * tracefile-tfile.c: Use C++ exception handling.
6505         * top.c: Use C++ exception handling.
6506         * thread.c: Use C++ exception handling.
6507         * target.c: Use C++ exception handling.
6508         * symmisc.c: Use C++ exception handling.
6509         * symfile-mem.c: Use C++ exception handling.
6510         * stack.c: Use C++ exception handling.
6511         * sparc64-linux-tdep.c: Use C++ exception handling.
6512         * solib.c: Use C++ exception handling.
6513         * solib-svr4.c: Use C++ exception handling.
6514         * solib-spu.c: Use C++ exception handling.
6515         * solib-frv.c: Use C++ exception handling.
6516         * solib-dsbt.c: Use C++ exception handling.
6517         * selftest-arch.c: Use C++ exception handling.
6518         * s390-tdep.c: Use C++ exception handling.
6519         * rust-lang.c: Use C++ exception handling.
6520         * rust-exp.y: Use C++ exception handling.
6521         * rs6000-tdep.c: Use C++ exception handling.
6522         * rs6000-aix-tdep.c: Use C++ exception handling.
6523         * riscv-tdep.c: Use C++ exception handling.
6524         * remote.c: Use C++ exception handling.
6525         * remote-fileio.c: Use C++ exception handling.
6526         * record-full.c: Use C++ exception handling.
6527         * record-btrace.c: Use C++ exception handling.
6528         * python/python.c: Use C++ exception handling.
6529         * python/py-value.c: Use C++ exception handling.
6530         * python/py-utils.c: Use C++ exception handling.
6531         * python/py-unwind.c: Use C++ exception handling.
6532         * python/py-type.c: Use C++ exception handling.
6533         * python/py-symbol.c: Use C++ exception handling.
6534         * python/py-record.c: Use C++ exception handling.
6535         * python/py-record-btrace.c: Use C++ exception handling.
6536         * python/py-progspace.c: Use C++ exception handling.
6537         * python/py-prettyprint.c: Use C++ exception handling.
6538         * python/py-param.c: Use C++ exception handling.
6539         * python/py-objfile.c: Use C++ exception handling.
6540         * python/py-linetable.c: Use C++ exception handling.
6541         * python/py-lazy-string.c: Use C++ exception handling.
6542         * python/py-infthread.c: Use C++ exception handling.
6543         * python/py-inferior.c: Use C++ exception handling.
6544         * python/py-gdb-readline.c: Use C++ exception handling.
6545         * python/py-framefilter.c: Use C++ exception handling.
6546         * python/py-frame.c: Use C++ exception handling.
6547         * python/py-finishbreakpoint.c: Use C++ exception handling.
6548         * python/py-cmd.c: Use C++ exception handling.
6549         * python/py-breakpoint.c: Use C++ exception handling.
6550         * python/py-arch.c: Use C++ exception handling.
6551         * printcmd.c: Use C++ exception handling.
6552         * ppc-linux-tdep.c: Use C++ exception handling.
6553         * parse.c: Use C++ exception handling.
6554         * p-valprint.c: Use C++ exception handling.
6555         * objc-lang.c: Use C++ exception handling.
6556         * mi/mi-main.c: Use C++ exception handling.
6557         * mi/mi-interp.c: Use C++ exception handling.
6558         * mi/mi-cmd-stack.c: Use C++ exception handling.
6559         * mi/mi-cmd-break.c: Use C++ exception handling.
6560         * main.c: Use C++ exception handling.
6561         * linux-thread-db.c: Use C++ exception handling.
6562         * linux-tdep.c: Use C++ exception handling.
6563         * linux-nat.c: Use C++ exception handling.
6564         * linux-fork.c: Use C++ exception handling.
6565         * linespec.c: Use C++ exception handling.
6566         * language.c: Use C++ exception handling.
6567         * jit.c: Use C++ exception handling.
6568         * infrun.c: Use C++ exception handling.
6569         * infcmd.c: Use C++ exception handling.
6570         * infcall.c: Use C++ exception handling.
6571         * inf-loop.c: Use C++ exception handling.
6572         * i386-tdep.c: Use C++ exception handling.
6573         * i386-linux-tdep.c: Use C++ exception handling.
6574         * guile/scm-value.c: Use C++ exception handling.
6575         * guile/scm-type.c: Use C++ exception handling.
6576         * guile/scm-symtab.c: Use C++ exception handling.
6577         * guile/scm-symbol.c: Use C++ exception handling.
6578         * guile/scm-pretty-print.c: Use C++ exception handling.
6579         * guile/scm-ports.c: Use C++ exception handling.
6580         * guile/scm-param.c: Use C++ exception handling.
6581         * guile/scm-math.c: Use C++ exception handling.
6582         * guile/scm-lazy-string.c: Use C++ exception handling.
6583         * guile/scm-frame.c: Use C++ exception handling.
6584         * guile/scm-disasm.c: Use C++ exception handling.
6585         * guile/scm-cmd.c: Use C++ exception handling.
6586         * guile/scm-breakpoint.c: Use C++ exception handling.
6587         * guile/scm-block.c: Use C++ exception handling.
6588         * guile/guile-internal.h: Use C++ exception handling.
6589         * gnu-v3-abi.c: Use C++ exception handling.
6590         * gdbtypes.c: Use C++ exception handling.
6591         * frame.c: Use C++ exception handling.
6592         * frame-unwind.c: Use C++ exception handling.
6593         * fbsd-tdep.c: Use C++ exception handling.
6594         * f-valprint.c: Use C++ exception handling.
6595         * exec.c: Use C++ exception handling.
6596         * event-top.c: Use C++ exception handling.
6597         * event-loop.c: Use C++ exception handling.
6598         * eval.c: Use C++ exception handling.
6599         * dwarf2read.c: Use C++ exception handling.
6600         * dwarf2loc.c: Use C++ exception handling.
6601         * dwarf2-frame.c: Use C++ exception handling.
6602         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6603         * dwarf-index-write.c: Use C++ exception handling.
6604         * dwarf-index-cache.c: Use C++ exception handling.
6605         * dtrace-probe.c: Use C++ exception handling.
6606         * disasm-selftests.c: Use C++ exception handling.
6607         * darwin-nat.c: Use C++ exception handling.
6608         * cp-valprint.c: Use C++ exception handling.
6609         * cp-support.c: Use C++ exception handling.
6610         * cp-abi.c: Use C++ exception handling.
6611         * corelow.c: Use C++ exception handling.
6612         * completer.c: Use C++ exception handling.
6613         * compile/compile-object-run.c: Use C++ exception handling.
6614         * compile/compile-object-load.c: Use C++ exception handling.
6615         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6616         * compile/compile-c-symbols.c: Use C++ exception handling.
6617         * common/selftest.c: Use C++ exception handling.
6618         * common/new-op.c: Use C++ exception handling.
6619         * cli/cli-script.c: Use C++ exception handling.
6620         * cli/cli-interp.c: Use C++ exception handling.
6621         * cli/cli-cmds.c: Use C++ exception handling.
6622         * c-varobj.c: Use C++ exception handling.
6623         * btrace.c: Use C++ exception handling.
6624         * breakpoint.c: Use C++ exception handling.
6625         * break-catch-throw.c: Use C++ exception handling.
6626         * arch-utils.c: Use C++ exception handling.
6627         * amd64-tdep.c: Use C++ exception handling.
6628         * ada-valprint.c: Use C++ exception handling.
6629         * ada-typeprint.c: Use C++ exception handling.
6630         * ada-lang.c: Use C++ exception handling.
6631         * aarch64-tdep.c: Use C++ exception handling.
6632
6633 2019-04-08  Tom Tromey  <tom@tromey.com>
6634
6635         * xml-support.c (gdb_xml_parser::parse): Update.
6636         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6637         * value.c (show_convenience): Update.
6638         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6639         (test_parse_flags_qcs): Update.
6640         * thread.c (thr_try_catch_cmd): Update.
6641         * target.c (target_translate_tls_address): Update.
6642         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6643         (info_frame_command_core, frame_apply_command_count): Update.
6644         * rust-exp.y (rust_lex_exception_test): Update.
6645         * riscv-tdep.c (riscv_print_one_register_info): Update.
6646         * remote.c (remote_target::enable_btrace): Update.
6647         * record-btrace.c (record_btrace_enable_warn): Update.
6648         * python/py-utils.c (gdbpy_convert_exception): Update.
6649         * printcmd.c (do_one_display, print_variable_and_value): Update.
6650         * mi/mi-main.c (mi_print_exception): Update.
6651         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6652         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6653         * linux-nat.c (linux_nat_target::attach): Update.
6654         * linux-fork.c (class scoped_switch_fork_info): Update.
6655         * infrun.c (displaced_step_prepare): Update.
6656         * infcall.c (call_function_by_hand_dummy): Update.
6657         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6658         * gnu-v3-abi.c (print_one_vtable): Update.
6659         * frame.c (get_prev_frame_always): Update.
6660         * f-valprint.c (info_common_command_for_block): Update.
6661         * exec.c (try_open_exec_file): Update.
6662         * exceptions.c (print_exception, exception_print)
6663         (exception_fprintf, exception_print_same): Update.
6664         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6665         * dwarf-index-cache.c (index_cache::store)
6666         (index_cache::lookup_gdb_index): Update.
6667         * darwin-nat.c (maybe_cache_shell): Update.
6668         * cp-valprint.c (cp_print_value_fields): Update.
6669         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6670         (gcc_cplus_symbol_address): Update.
6671         * compile/compile-c-symbols.c (gcc_convert_symbol)
6672         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6673         * common/selftest.c: Update.
6674         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6675         a std::string.
6676         (exception_try_scope_entry, exception_try_scope_exit): Don't
6677         declare.
6678         (struct exception_try_scope): Remove.
6679         (TRY): Don't use exception_try_scope.
6680         (struct gdb_exception): Add constructor, operator=.
6681         <what>: New method.
6682         (struct gdb_exception_RETURN_MASK_ALL)
6683         (struct gdb_exception_RETURN_MASK_ERROR)
6684         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6685         (struct gdb_quit_bad_alloc): Update.
6686         * common/common-exceptions.c (exception_none): Change
6687         initializer.
6688         (struct catcher) <state, exception>: Initialize inline.
6689         <prev>: Remove member.
6690         (current_catcher): Remove.
6691         (catchers): New global.
6692         (exceptions_state_mc_init): Simplify.
6693         (catcher_pop): Remove.
6694         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6695         (try_scope_depth, exception_try_scope_entry)
6696         (exception_try_scope_exit): Remove.
6697         (throw_exception_sjlj): Update.
6698         (exception_messages, exception_messages_size): Remove.
6699         (throw_it): Simplify.
6700         (gdb_exception_sliced_copy): Remove.
6701         (throw_exception_cxx): Update.
6702         * cli/cli-script.c (script_from_file): Update.
6703         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6704         Update.
6705         * ada-valprint.c (ada_val_print): Update.
6706         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6707         (create_excep_cond_exprs): Update.
6708
6709 2019-04-08  Tom Tromey  <tom@tromey.com>
6710
6711         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6712         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6713         (TRY, CATCH, END_CATCH): Remove some definitions.
6714         * common/common-exceptions.c: Don't use GDB_XCPT.
6715         (catcher_list_size): Remove.
6716         (throw_exception, throw_it): Simplify.
6717
6718 2019-04-05  Tom Tromey  <tom@tromey.com>
6719
6720         Revert the header-sorting patch.
6721         * ft32-tdep.c: Revert.
6722         * frv-tdep.c: Revert.
6723         * frv-linux-tdep.c: Revert.
6724         * frame.c: Revert.
6725         * frame-unwind.c: Revert.
6726         * frame-base.c: Revert.
6727         * fork-child.c: Revert.
6728         * findvar.c: Revert.
6729         * findcmd.c: Revert.
6730         * filesystem.c: Revert.
6731         * filename-seen-cache.h: Revert.
6732         * filename-seen-cache.c: Revert.
6733         * fbsd-tdep.c: Revert.
6734         * fbsd-nat.h: Revert.
6735         * fbsd-nat.c: Revert.
6736         * f-valprint.c: Revert.
6737         * f-typeprint.c: Revert.
6738         * f-lang.c: Revert.
6739         * extension.h: Revert.
6740         * extension.c: Revert.
6741         * extension-priv.h: Revert.
6742         * expprint.c: Revert.
6743         * exec.h: Revert.
6744         * exec.c: Revert.
6745         * exceptions.c: Revert.
6746         * event-top.c: Revert.
6747         * event-loop.c: Revert.
6748         * eval.c: Revert.
6749         * elfread.c: Revert.
6750         * dwarf2read.h: Revert.
6751         * dwarf2read.c: Revert.
6752         * dwarf2loc.c: Revert.
6753         * dwarf2expr.h: Revert.
6754         * dwarf2expr.c: Revert.
6755         * dwarf2-frame.c: Revert.
6756         * dwarf2-frame-tailcall.c: Revert.
6757         * dwarf-index-write.h: Revert.
6758         * dwarf-index-write.c: Revert.
6759         * dwarf-index-common.c: Revert.
6760         * dwarf-index-cache.h: Revert.
6761         * dwarf-index-cache.c: Revert.
6762         * dummy-frame.c: Revert.
6763         * dtrace-probe.c: Revert.
6764         * disasm.h: Revert.
6765         * disasm.c: Revert.
6766         * disasm-selftests.c: Revert.
6767         * dictionary.c: Revert.
6768         * dicos-tdep.c: Revert.
6769         * demangle.c: Revert.
6770         * dcache.h: Revert.
6771         * dcache.c: Revert.
6772         * darwin-nat.h: Revert.
6773         * darwin-nat.c: Revert.
6774         * darwin-nat-info.c: Revert.
6775         * d-valprint.c: Revert.
6776         * d-namespace.c: Revert.
6777         * d-lang.c: Revert.
6778         * ctf.c: Revert.
6779         * csky-tdep.c: Revert.
6780         * csky-linux-tdep.c: Revert.
6781         * cris-tdep.c: Revert.
6782         * cris-linux-tdep.c: Revert.
6783         * cp-valprint.c: Revert.
6784         * cp-support.c: Revert.
6785         * cp-namespace.c: Revert.
6786         * cp-abi.c: Revert.
6787         * corelow.c: Revert.
6788         * corefile.c: Revert.
6789         * continuations.c: Revert.
6790         * completer.h: Revert.
6791         * completer.c: Revert.
6792         * complaints.c: Revert.
6793         * coffread.c: Revert.
6794         * coff-pe-read.c: Revert.
6795         * cli-out.h: Revert.
6796         * cli-out.c: Revert.
6797         * charset.c: Revert.
6798         * c-varobj.c: Revert.
6799         * c-valprint.c: Revert.
6800         * c-typeprint.c: Revert.
6801         * c-lang.c: Revert.
6802         * buildsym.c: Revert.
6803         * buildsym-legacy.c: Revert.
6804         * build-id.h: Revert.
6805         * build-id.c: Revert.
6806         * btrace.c: Revert.
6807         * bsd-uthread.c: Revert.
6808         * breakpoint.h: Revert.
6809         * breakpoint.c: Revert.
6810         * break-catch-throw.c: Revert.
6811         * break-catch-syscall.c: Revert.
6812         * break-catch-sig.c: Revert.
6813         * blockframe.c: Revert.
6814         * block.c: Revert.
6815         * bfin-tdep.c: Revert.
6816         * bfin-linux-tdep.c: Revert.
6817         * bfd-target.c: Revert.
6818         * bcache.c: Revert.
6819         * ax-general.c: Revert.
6820         * ax-gdb.h: Revert.
6821         * ax-gdb.c: Revert.
6822         * avr-tdep.c: Revert.
6823         * auxv.c: Revert.
6824         * auto-load.c: Revert.
6825         * arm-wince-tdep.c: Revert.
6826         * arm-tdep.c: Revert.
6827         * arm-symbian-tdep.c: Revert.
6828         * arm-pikeos-tdep.c: Revert.
6829         * arm-obsd-tdep.c: Revert.
6830         * arm-nbsd-tdep.c: Revert.
6831         * arm-nbsd-nat.c: Revert.
6832         * arm-linux-tdep.c: Revert.
6833         * arm-linux-nat.c: Revert.
6834         * arm-fbsd-tdep.c: Revert.
6835         * arm-fbsd-nat.c: Revert.
6836         * arm-bsd-tdep.c: Revert.
6837         * arch-utils.c: Revert.
6838         * arc-tdep.c: Revert.
6839         * arc-newlib-tdep.c: Revert.
6840         * annotate.h: Revert.
6841         * annotate.c: Revert.
6842         * amd64-windows-tdep.c: Revert.
6843         * amd64-windows-nat.c: Revert.
6844         * amd64-tdep.c: Revert.
6845         * amd64-sol2-tdep.c: Revert.
6846         * amd64-obsd-tdep.c: Revert.
6847         * amd64-obsd-nat.c: Revert.
6848         * amd64-nbsd-tdep.c: Revert.
6849         * amd64-nbsd-nat.c: Revert.
6850         * amd64-nat.c: Revert.
6851         * amd64-linux-tdep.c: Revert.
6852         * amd64-linux-nat.c: Revert.
6853         * amd64-fbsd-tdep.c: Revert.
6854         * amd64-fbsd-nat.c: Revert.
6855         * amd64-dicos-tdep.c: Revert.
6856         * amd64-darwin-tdep.c: Revert.
6857         * amd64-bsd-nat.c: Revert.
6858         * alpha-tdep.c: Revert.
6859         * alpha-obsd-tdep.c: Revert.
6860         * alpha-nbsd-tdep.c: Revert.
6861         * alpha-mdebug-tdep.c: Revert.
6862         * alpha-linux-tdep.c: Revert.
6863         * alpha-linux-nat.c: Revert.
6864         * alpha-bsd-tdep.c: Revert.
6865         * alpha-bsd-nat.c: Revert.
6866         * aix-thread.c: Revert.
6867         * agent.c: Revert.
6868         * addrmap.c: Revert.
6869         * ada-varobj.c: Revert.
6870         * ada-valprint.c: Revert.
6871         * ada-typeprint.c: Revert.
6872         * ada-tasks.c: Revert.
6873         * ada-lang.c: Revert.
6874         * aarch64-tdep.c: Revert.
6875         * aarch64-ravenscar-thread.c: Revert.
6876         * aarch64-newlib-tdep.c: Revert.
6877         * aarch64-linux-tdep.c: Revert.
6878         * aarch64-linux-nat.c: Revert.
6879         * aarch64-fbsd-tdep.c: Revert.
6880         * aarch64-fbsd-nat.c: Revert.
6881         * aarch32-linux-nat.c: Revert.
6882
6883 2019-04-05  Tom Tromey  <tom@tromey.com>
6884
6885         * ft32-tdep.c: Sort headers.
6886         * frv-tdep.c: Sort headers.
6887         * frv-linux-tdep.c: Sort headers.
6888         * frame.c: Sort headers.
6889         * frame-unwind.c: Sort headers.
6890         * frame-base.c: Sort headers.
6891         * fork-child.c: Sort headers.
6892         * findvar.c: Sort headers.
6893         * findcmd.c: Sort headers.
6894         * filesystem.c: Sort headers.
6895         * filename-seen-cache.h: Sort headers.
6896         * filename-seen-cache.c: Sort headers.
6897         * fbsd-tdep.c: Sort headers.
6898         * fbsd-nat.h: Sort headers.
6899         * fbsd-nat.c: Sort headers.
6900         * f-valprint.c: Sort headers.
6901         * f-typeprint.c: Sort headers.
6902         * f-lang.c: Sort headers.
6903         * extension.h: Sort headers.
6904         * extension.c: Sort headers.
6905         * extension-priv.h: Sort headers.
6906         * expprint.c: Sort headers.
6907         * exec.h: Sort headers.
6908         * exec.c: Sort headers.
6909         * exceptions.c: Sort headers.
6910         * event-top.c: Sort headers.
6911         * event-loop.c: Sort headers.
6912         * eval.c: Sort headers.
6913         * elfread.c: Sort headers.
6914         * dwarf2read.h: Sort headers.
6915         * dwarf2read.c: Sort headers.
6916         * dwarf2loc.c: Sort headers.
6917         * dwarf2expr.h: Sort headers.
6918         * dwarf2expr.c: Sort headers.
6919         * dwarf2-frame.c: Sort headers.
6920         * dwarf2-frame-tailcall.c: Sort headers.
6921         * dwarf-index-write.h: Sort headers.
6922         * dwarf-index-write.c: Sort headers.
6923         * dwarf-index-common.c: Sort headers.
6924         * dwarf-index-cache.h: Sort headers.
6925         * dwarf-index-cache.c: Sort headers.
6926         * dummy-frame.c: Sort headers.
6927         * dtrace-probe.c: Sort headers.
6928         * disasm.h: Sort headers.
6929         * disasm.c: Sort headers.
6930         * disasm-selftests.c: Sort headers.
6931         * dictionary.c: Sort headers.
6932         * dicos-tdep.c: Sort headers.
6933         * demangle.c: Sort headers.
6934         * dcache.h: Sort headers.
6935         * dcache.c: Sort headers.
6936         * darwin-nat.h: Sort headers.
6937         * darwin-nat.c: Sort headers.
6938         * darwin-nat-info.c: Sort headers.
6939         * d-valprint.c: Sort headers.
6940         * d-namespace.c: Sort headers.
6941         * d-lang.c: Sort headers.
6942         * ctf.c: Sort headers.
6943         * csky-tdep.c: Sort headers.
6944         * csky-linux-tdep.c: Sort headers.
6945         * cris-tdep.c: Sort headers.
6946         * cris-linux-tdep.c: Sort headers.
6947         * cp-valprint.c: Sort headers.
6948         * cp-support.c: Sort headers.
6949         * cp-namespace.c: Sort headers.
6950         * cp-abi.c: Sort headers.
6951         * corelow.c: Sort headers.
6952         * corefile.c: Sort headers.
6953         * continuations.c: Sort headers.
6954         * completer.h: Sort headers.
6955         * completer.c: Sort headers.
6956         * complaints.c: Sort headers.
6957         * coffread.c: Sort headers.
6958         * coff-pe-read.c: Sort headers.
6959         * cli-out.h: Sort headers.
6960         * cli-out.c: Sort headers.
6961         * charset.c: Sort headers.
6962         * c-varobj.c: Sort headers.
6963         * c-valprint.c: Sort headers.
6964         * c-typeprint.c: Sort headers.
6965         * c-lang.c: Sort headers.
6966         * buildsym.c: Sort headers.
6967         * buildsym-legacy.c: Sort headers.
6968         * build-id.h: Sort headers.
6969         * build-id.c: Sort headers.
6970         * btrace.c: Sort headers.
6971         * bsd-uthread.c: Sort headers.
6972         * breakpoint.h: Sort headers.
6973         * breakpoint.c: Sort headers.
6974         * break-catch-throw.c: Sort headers.
6975         * break-catch-syscall.c: Sort headers.
6976         * break-catch-sig.c: Sort headers.
6977         * blockframe.c: Sort headers.
6978         * block.c: Sort headers.
6979         * bfin-tdep.c: Sort headers.
6980         * bfin-linux-tdep.c: Sort headers.
6981         * bfd-target.c: Sort headers.
6982         * bcache.c: Sort headers.
6983         * ax-general.c: Sort headers.
6984         * ax-gdb.h: Sort headers.
6985         * ax-gdb.c: Sort headers.
6986         * avr-tdep.c: Sort headers.
6987         * auxv.c: Sort headers.
6988         * auto-load.c: Sort headers.
6989         * arm-wince-tdep.c: Sort headers.
6990         * arm-tdep.c: Sort headers.
6991         * arm-symbian-tdep.c: Sort headers.
6992         * arm-pikeos-tdep.c: Sort headers.
6993         * arm-obsd-tdep.c: Sort headers.
6994         * arm-nbsd-tdep.c: Sort headers.
6995         * arm-nbsd-nat.c: Sort headers.
6996         * arm-linux-tdep.c: Sort headers.
6997         * arm-linux-nat.c: Sort headers.
6998         * arm-fbsd-tdep.c: Sort headers.
6999         * arm-fbsd-nat.c: Sort headers.
7000         * arm-bsd-tdep.c: Sort headers.
7001         * arch-utils.c: Sort headers.
7002         * arc-tdep.c: Sort headers.
7003         * arc-newlib-tdep.c: Sort headers.
7004         * annotate.h: Sort headers.
7005         * annotate.c: Sort headers.
7006         * amd64-windows-tdep.c: Sort headers.
7007         * amd64-windows-nat.c: Sort headers.
7008         * amd64-tdep.c: Sort headers.
7009         * amd64-sol2-tdep.c: Sort headers.
7010         * amd64-obsd-tdep.c: Sort headers.
7011         * amd64-obsd-nat.c: Sort headers.
7012         * amd64-nbsd-tdep.c: Sort headers.
7013         * amd64-nbsd-nat.c: Sort headers.
7014         * amd64-nat.c: Sort headers.
7015         * amd64-linux-tdep.c: Sort headers.
7016         * amd64-linux-nat.c: Sort headers.
7017         * amd64-fbsd-tdep.c: Sort headers.
7018         * amd64-fbsd-nat.c: Sort headers.
7019         * amd64-dicos-tdep.c: Sort headers.
7020         * amd64-darwin-tdep.c: Sort headers.
7021         * amd64-bsd-nat.c: Sort headers.
7022         * alpha-tdep.c: Sort headers.
7023         * alpha-obsd-tdep.c: Sort headers.
7024         * alpha-nbsd-tdep.c: Sort headers.
7025         * alpha-mdebug-tdep.c: Sort headers.
7026         * alpha-linux-tdep.c: Sort headers.
7027         * alpha-linux-nat.c: Sort headers.
7028         * alpha-bsd-tdep.c: Sort headers.
7029         * alpha-bsd-nat.c: Sort headers.
7030         * aix-thread.c: Sort headers.
7031         * agent.c: Sort headers.
7032         * addrmap.c: Sort headers.
7033         * ada-varobj.c: Sort headers.
7034         * ada-valprint.c: Sort headers.
7035         * ada-typeprint.c: Sort headers.
7036         * ada-tasks.c: Sort headers.
7037         * ada-lang.c: Sort headers.
7038         * aarch64-tdep.c: Sort headers.
7039         * aarch64-ravenscar-thread.c: Sort headers.
7040         * aarch64-newlib-tdep.c: Sort headers.
7041         * aarch64-linux-tdep.c: Sort headers.
7042         * aarch64-linux-nat.c: Sort headers.
7043         * aarch64-fbsd-tdep.c: Sort headers.
7044         * aarch64-fbsd-nat.c: Sort headers.
7045         * aarch32-linux-nat.c: Sort headers.
7046
7047 2019-04-04  Tom Tromey  <tom@tromey.com>
7048
7049         * varobj.c (varobj_create): Update.
7050         * rust-exp.y (struct rust_parser) <update_innermost_block,
7051         lookup_symbol>: New methods.
7052         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7053         Rename.
7054         (rust_parser::rust_lookup_type)
7055         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7056         * printcmd.c (display_command, do_one_display): Update.
7057         * parser-defs.h (struct parser_state) <parser_state>: Add
7058         "tracker" parameter.
7059         (block_tracker): New member.
7060         (class innermost_block_tracker) <innermost_block_tracker>: Add
7061         "types" parameter.
7062         <reset>: Remove method.
7063         (innermost_block): Don't declare.
7064         (null_post_parser): Update.
7065         * parse.c (innermost_block): Remove global.
7066         (write_dollar_variable): Update.
7067         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7068         Remove "tracker_types" parameter.
7069         (parse_expression): Add "tracker" parameter.
7070         (parse_expression_for_completion): Update.
7071         (null_post_parser): Add "tracker" parameter.
7072         * p-exp.y: Update rules.
7073         * m2-exp.y: Update rules.
7074         * language.h (struct language_defn) <la_post_parser>: Add
7075         "tracker" parameter.
7076         * go-exp.y: Update rules.
7077         * f-exp.y: Update rules.
7078         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7079         parameter.
7080         * d-exp.y: Update rules.
7081         * c-exp.y: Update rules.
7082         * breakpoint.c (set_breakpoint_condition): Create an
7083         innermost_block_tracker.
7084         (watch_command_1): Likewise.
7085         * ada-lang.c (resolve): Add "tracker" parameter.
7086         (resolve_subexp): Likewise.
7087         * ada-exp.y (write_var_from_sym): Update.
7088
7089 2019-04-04  Tom Tromey  <tom@tromey.com>
7090
7091         * type-stack.h: New file.
7092         * type-stack.c: New file.
7093         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7094         type-stack.h.
7095         (insert_into_type_stack, insert_type, push_type, push_type_int)
7096         (insert_type_address_space, pop_type, pop_type_int)
7097         (pop_typelist, pop_type_stack, append_type_stack)
7098         (push_type_stack, get_type_stack, push_typelist)
7099         (follow_type_instance_flags, follow_types): Don't declare.
7100         * parse.c (type_stack): Remove global.
7101         (parse_exp_in_context): Update.
7102         (insert_into_type_stack, insert_type, push_type, push_type_int)
7103         (insert_type_address_space, pop_type, pop_type_int)
7104         (pop_typelist, pop_type_stack, append_type_stack)
7105         (push_type_stack, get_type_stack, push_typelist)
7106         (follow_type_instance_flags, follow_types): Remove (moved to
7107         type-stack.c).
7108         * f-exp.y (type_stack): New global.
7109         Update rules.
7110         (push_kind_type, f_parse): Update.
7111         * d-exp.y (type_stack): New global.
7112         Update rules.
7113         (d_parse): Update.
7114         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7115         Update rules.
7116         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7117         (HFILES_NO_SRCDIR): Add type-stack.h.
7118
7119 2019-04-04  Tom Tromey  <tom@tromey.com>
7120
7121         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7122         (rust_parser::convert_ast_to_expression, rust_parse)
7123         (rust_lex_test_completion, rust_lex_tests): Update.
7124         * parser-defs.h (struct expr_completion_state): New.
7125         (struct parser_state) <parser_state>: Add completion parameter.
7126         <mark_struct_expression, mark_completion_tag>: New methods.
7127         <parse_completion, m_completion_state>: New members.
7128         (prefixify_expression, null_post_parser): Update.
7129         (mark_struct_expression, mark_completion_tag): Don't declare.
7130         * parse.c (parse_completion, expout_last_struct)
7131         (expout_tag_completion_type, expout_completion_name): Remove
7132         globals.
7133         (parser_state::mark_struct_expression)
7134         (parser_state::mark_completion_tag): Now methods.
7135         (prefixify_expression): Add last_struct parameter.
7136         (prefixify_subexp): Likewise.
7137         (parse_exp_1): Update.
7138         (parse_exp_in_context): Add cstate parameter.  Update.
7139         (parse_expression_for_completion): Create an
7140         expr_completion_state.
7141         (null_post_parser): Add "completion" parameter.
7142         * p-exp.y: Update rules.
7143         (yylex): Update.
7144         * language.h (struct language_defn) <la_post_parser>: Add
7145         "completing" parameter.
7146         * go-exp.y: Update rules.
7147         (lex_one_token): Update.
7148         * expression.h (parse_completion): Don't declare.
7149         * d-exp.y: Update rules.
7150         (lex_one_token): Update rules.
7151         * c-exp.y: Update rules.
7152         (lex_one_token): Update.
7153         * ada-lang.c (resolve): Add "parse_completion" parameter.
7154         (resolve_subexp): Likewise.
7155         (ada_resolve_function): Likewise.
7156
7157 2019-04-04  Tom Tromey  <tom@tromey.com>
7158
7159         * parser-defs.h (struct parser_state) <start_arglist,
7160         end_arglist>: New methods.
7161         <arglist_len, m_funcall_chain>: New members.
7162         (arglist_len, start_arglist, end_arglist): Don't declare.
7163         * parse.c (arglist_len, funcall_chain): Remove global.
7164         (start_arglist, end_arglist): Remove functions.
7165         (parse_exp_in_context): Update.
7166         * p-exp.y: Update rules.
7167         * m2-exp.y: Update rules.
7168         * go-exp.y: Update rules.
7169         * f-exp.y: Update rules.
7170         * d-exp.y: Update rules.
7171         * c-exp.y: Update rules.
7172
7173 2019-04-04  Tom Tromey  <tom@tromey.com>
7174
7175         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7176         lex_operator, push_back>: New methods.
7177         Update all rules.
7178         (rust_parser::lex_hex, lex_escape): Rename and update.
7179         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7180         (rust_parser::lex_operator): Rename and update.
7181         (rust_parser::lex_number, rustyylex, rustyyerror)
7182         (rust_lex_test_init, rust_lex_test_sequence)
7183         (rust_lex_test_push_back, rust_lex_tests): Update.
7184         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7185         parameter.
7186         <lexptr, prev_lexptr>: New members.
7187         (lexptr, prev_lexptr): Don't declare.
7188         * parse.c (lexptr, prev_lexptr): Remove globals.
7189         (parse_exp_in_context): Update.
7190         * p-exp.y (yylex, yyerror): Update.
7191         * m2-exp.y (parse_number, yylex, yyerror): Update.
7192         * go-exp.y (lex_one_token, yyerror): Update.
7193         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7194         * d-exp.y (lex_one_token, yyerror): Update.
7195         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7196         (lex_one_token, yyerror): Update.
7197         * ada-lex.l (YY_INPUT): Update.
7198         (rewind_to_char): Update.
7199         * ada-exp.y (yyerror): Update.
7200
7201 2019-04-04  Tom Tromey  <tom@tromey.com>
7202
7203         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7204         * parser-defs.h (struct parser_state) <parser_state>: Add new
7205         parameter.
7206         <comma_terminates>: New member.
7207         (comma_terminates): Don't declare global.
7208         * parse.c (comma_terminates): Remove global.
7209         (parse_exp_in_context): Update.
7210         * p-exp.y (yylex): Update.
7211         * m2-exp.y (yylex): Update.
7212         * go-exp.y (lex_one_token): Update.
7213         * f-exp.y (yylex): Update.
7214         * d-exp.y (lex_one_token): Update.
7215         * c-exp.y (lex_one_token): Update.
7216         * ada-lex.l: Update.
7217
7218 2019-04-04  Tom Tromey  <tom@tromey.com>
7219
7220         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7221         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7222         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7223         * parser-defs.h (paren_depth): Don't declare.
7224         * parse.c (paren_depth): Remove global.
7225         (parse_exp_in_context): Update.
7226         * p-exp.y (paren_depth): New global.
7227         (pascal_parse): Initialize it.
7228         * m2-exp.y (paren_depth): New global.
7229         (m2_parse): Initialize it.
7230         * go-exp.y (paren_depth): New global.
7231         (go_parse): Initialize it.
7232         * f-exp.y (paren_depth): New global.
7233         (f_parse): Initialize it.
7234         * d-exp.y (paren_depth): New global.
7235         (d_parse): Initialize it.
7236         * c-exp.y (paren_depth): New global.
7237         (c_parse): Initialize it.
7238         * ada-lex.l (paren_depth): New global.
7239         (lexer_init): Initialize it.
7240
7241 2019-04-04  Tom Tromey  <tom@tromey.com>
7242
7243         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7244         (rust_parser::convert_ast_to_type)
7245         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7246         * parser-defs.h (struct parser_state) <parser_state>: Add
7247         parameters.  Initialize new members.
7248         <expression_context_block, expression_context_pc>: New members.
7249         * parse.c (expression_context_block, expression_context_pc):
7250         Remove globals.
7251         (parse_exp_in_context): Update.
7252         * p-exp.y: Update all rules.
7253         (yylex): Update.
7254         * m2-exp.y: Update all rules.
7255         (yylex): Update.
7256         * go-exp.y (yylex): Update.
7257         * f-exp.y (yylex): Update.
7258         * d-exp.y: Update all rules.
7259         (yylex): Update.
7260         * c-exp.y: Update all rules.
7261         (lex_one_token, classify_name, yylex, c_parse): Update.
7262         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7263
7264 2019-04-04  Tom Tromey  <tom@tromey.com>
7265
7266         * gdbarch.h, gdbarch.c: Rebuild.
7267         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7268         * stap-probe.h:
7269         (struct stap_parse_info): Replace "parser_state" with
7270         "expr_builder".
7271         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7272         (parser_state): New class.
7273         * parse.c (expr_builder): Rename.
7274         (expr_builder::release): Rename.
7275         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7276         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7277         (write_exp_elt_longcst, write_exp_elt_floatcst)
7278         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7279         (write_exp_string_vector, write_exp_bitstring)
7280         (write_exp_msymbol, mark_struct_expression)
7281         (write_dollar_variable)
7282         (insert_type_address_space, increase_expout_size): Replace
7283         "parser_state" with "expr_builder".
7284         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7285         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7286         "parser_state" with "expr_builder".
7287
7288 2019-04-04  Tom Tromey  <tom@tromey.com>
7289
7290         * rust-exp.y: Replace "parse_language" with method call.
7291         * p-exp.y:
7292         (yylex): Replace "parse_language" with method call.
7293         * m2-exp.y:
7294         (yylex): Replace "parse_language" with method call.
7295         * go-exp.y (classify_name): Replace "parse_language" with method
7296         call.
7297         * f-exp.y (yylex): Replace "parse_language" with method call.
7298         * d-exp.y (lex_one_token): Replace "parse_language" with method
7299         call.
7300         * c-exp.y:
7301         (lex_one_token, classify_name, yylex): Replace "parse_language"
7302         with method call.
7303         * ada-exp.y (find_primitive_type, type_char)
7304         (type_system_address): Replace "parse_language" with method call.
7305
7306 2019-04-04  Tom Tromey  <tom@tromey.com>
7307
7308         * rust-exp.y: Replace "parse_gdbarch" with method call.
7309         * parse.c (write_dollar_variable, insert_type_address_space):
7310         Replace "parse_gdbarch" with method call.
7311         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7312         call.
7313         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7314         call.
7315         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7316         "parse_gdbarch" with method call.
7317         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7318         with method call.
7319         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7320         "parse_gdbarch" with method call.
7321         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7322         "parse_gdbarch" with method call.
7323         * c-exp.y (parse_type, parse_number, classify_name): Replace
7324         "parse_gdbarch" with method call.
7325         * ada-lex.l: Replace "parse_gdbarch" with method call.
7326         * ada-exp.y (parse_type, find_primitive_type, type_char)
7327         (type_system_address): Replace "parse_gdbarch" with method call.
7328
7329 2019-04-04  Tom Tromey  <tom@tromey.com>
7330
7331         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7332         * stap-probe.c (stap_parse_argument): Update.
7333         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7334         initial_size parameter.
7335         * rust-exp.y (rust_lex_tests): Update.
7336         * parse.c (parser_state): Update.
7337         (parse_exp_in_context): Update.
7338         * parser-defs.h (struct parser_state) <parser_state>: Remove
7339         "initial_size" parameter.
7340
7341 2019-04-04  Tom Tromey  <tom@tromey.com>
7342
7343         * parser-defs.h (increase_expout_size): Don't declare.
7344         * parse.c (increase_expout_size): Now static.
7345
7346 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7347
7348         * gnu-nat.c (gnu_nat_target::wait): Fix
7349         target_waitstatus_to_string call.
7350
7351 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * eval.c (evaluate_subexp_standard): Handle internal functions
7354         during Fortran function call handling.
7355
7356 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         * NEWS: Mention new internal functions.
7359         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7360         (read_base_type): Use dwarf2_init_complex_target_type.
7361         * value.c (creal_internal_fn): New function.
7362         (cimag_internal_fn): New function.
7363         (_initialize_values): Register new internal functions.
7364
7365 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7366
7367         * infrun.c (stop_all_threads): If debug_infrun, always
7368         trace the wait status after wait_one, using
7369         target_waitstatus_to_string and target_pid_to_str.
7370         (handle_inferior_event): Replace various trace of
7371         wait status kind by a single trace.
7372         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7373         wait status kind image by target_waitstatus_to_string.
7374         * target/waitstatus.c (target_waitstatus_to_string): Fix
7375         obsolete comment.
7376
7377 2019-04-01  Tom Tromey  <tromey@adacore.com>
7378
7379         PR symtab/23331:
7380         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7381
7382 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7383             Pedro Alves  <palves@redhat.com>
7384
7385         * top.c (quit_force): Call 'finalize_values'.
7386         * value.c (finalize_values): New function.
7387         * value.h (finalize_values): Declare.
7388
7389 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7390
7391         * NEWS: Announce $_gdb_major and $_gdb_minor.
7392
7393         * top.c (init_gdb_version_vars): New function.
7394         (gdb_init): Call init_gdb_version_vars.
7395
7396 2019-03-29  Tom Tromey  <tromey@adacore.com>
7397
7398         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7399         help text.  Remove dead code.
7400
7401 2019-03-29  Keith Seitz  <keiths@redhat.com>
7402
7403         From Siddhesh Poyarekar:
7404         * f-lang.h (f77_get_upperbound): Return LONGEST.
7405         (f77_get_lowerbound): Likewise.
7406         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7407         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7408         print them.
7409         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7410         plongest to format print it.
7411         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7412         (f77_get_upperbound): Likewise.
7413         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7414         LOWER_BOUND to LONGEST.
7415         (f77_create_arrayprint_offset_tbl): Likewise.
7416
7417 2019-03-29  Keith Seitz  <keiths@redhat.com>
7418
7419         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7420         %s/pulongest for TYPE_LENGTH instead of %d in format
7421         strings.
7422         * ada-typerint.c (ada_print_type): Likewise.
7423         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7424         * compile/compile-c-support.c (generate_register_struct): Likewise.
7425         * gdbtypes.c (recursive_dump_type): Likewise.
7426         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7427         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7428         instead of %d in format strings.
7429         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7430         to std::min to ULONGEST.
7431         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7432         instead of %d in format strings.
7433         * tracepoint.c (info_scope_command): Likewise.
7434         * typeprint.c (print_offset_data::update)
7435         (print_offset_data::finish): Likewise.
7436         * xtensa-tdep.c (xtensa_store_return_value)
7437         (xtensa_push_dummy_call): Likewise.
7438
7439 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7440
7441         * windows-nat.c (display_selector): Fixed format specifications
7442         for 64-bit Cygwin.
7443
7444 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7445
7446         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7447
7448 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7449
7450         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7451         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7452         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7453         (nios2_linux_init_abi): Install it.
7454
7455 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7456
7457         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7458
7459 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7460
7461         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7462
7463 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7464             Tom Tromey  <tromey@adacore.com>
7465
7466         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7467
7468 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7469
7470         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7471         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7472         method to compute the bounds of range types. Also print "[evaluated]"
7473         if the bounds' values come from a dynamic evaluation.
7474
7475 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7476
7477         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7478         whitespace when pretty printing is on.
7479
7480 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7481
7482         * ppc-linux-nat.c: Add include.
7483
7484 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7485
7486         * NEWS: Mention AArch64 Pointer Authentication.
7487
7488 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7489
7490         * arm-linux-nat.c: Add include.
7491
7492 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7493
7494         * source-cache.c (source_cache::get_source_lines): Re-read
7495         fullname after calling open_source_file.
7496
7497 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7498
7499         * NEWS: Mention TLS support for FreeBSD.
7500
7501 2019-03-25  Tom Tromey  <tromey@adacore.com>
7502
7503         * minsyms.c (BUNCH_SIZE): Update comment.
7504         (~minimal_symbol_reader): Remove old comment.
7505         (compact_minimal_symbols): Update comment.
7506         (minimal_symbol_reader::install): Remove old comment.  Update
7507         other comments.
7508
7509 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7510
7511         * s390-linux-nat.c: Add include.
7512
7513 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7514
7515         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7516         Call linux_get_hwcap.
7517         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7518         Likewise.
7519         (aarch64_linux_get_hwcap): Remove function.
7520         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7521         declaration.
7522         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7523         linux_get_hwcap.
7524         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7525         * linux-tdep.c (linux_get_hwcap): Add function.
7526         (linux_get_hwcap2): Likewise.
7527         * linux-tdep.h (linux_get_hwcap): Add declaration.
7528         (linux_get_hwcap2): Likewise.
7529         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7530         (ppc_linux_get_hwcap2): Likewise.
7531         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7532         linux_get_hwcap.
7533         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7534         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7535         (ppc_linux_nat_target::read_description): Likewise.
7536         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7537         * s390-linux-nat.c: Likewise.
7538         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7539
7540 2019-03-24  Tom Tromey  <tom@tromey.com>
7541
7542         * ada-lang.c (standard_lookup): Simplify initialization.
7543         (ada_lookup_symbol_nonlocal): Simplify return.
7544         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7545         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7546         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7547         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7548         initialization.
7549         * solib.c (solib_global_lookup): Simplify.
7550         * symtab.c (null_block_symbol): Remove.
7551         (symbol_cache_lookup): Simplify returns.
7552         (lookup_language_this): Simplify returns.
7553         (lookup_symbol_aux): Simplify return.
7554         (lookup_local_symbol): Simplify returns.
7555         (lookup_global_symbol_from_objfile): Simplify return.
7556         (lookup_symbol_in_objfile_symtabs)
7557         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7558         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7559         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7560         * cp-namespace.c (cp_lookup_bare_symbol)
7561         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7562         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7563         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7564         (cp_lookup_symbol_via_imports): Simplify initialization.
7565         (find_symbol_in_baseclass): Likewise.
7566         * symtab.h (null_block_symbol): Remove.
7567         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7568         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7569         (d_lookup_symbol_module): Likewise.
7570         (find_symbol_in_baseclass): Simplify initialization.
7571
7572 2019-03-24  Tom Tromey  <tom@tromey.com>
7573
7574         * expression.h: Don't include symtab.h.
7575         (struct block): Forward declare.
7576
7577 2019-03-24  Tom Tromey  <tom@tromey.com>
7578
7579         * c-exp.y (typebase): Remove casts.
7580         * gdbtypes.c (lookup_unsigned_typename, )
7581         (lookup_signed_typename): Remove cast.
7582         * eval.c (parse_to_comma_and_eval): Remove cast.
7583         * parse.c (write_dollar_variable): Remove cast.
7584         * block.h (struct block) <superblock>: Now const.
7585         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7586         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7587         (map_block): Make "block" const.
7588         * symfile.h (struct quick_symbol_functions)
7589         <map_matching_symbols>: Constify block argument to "callback".
7590         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7591         const.
7592         (find_pc_sect_compunit_symtab): Make "b" const.
7593         (find_symbol_at_address): Likewise.
7594         (search_symbols): Likewise.
7595         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7596         (dw2_debug_names_lookup_symbol): Likewise.
7597         (dw2_map_matching_symbols): Update.
7598         * p-valprint.c (pascal_val_print): Remove "block".
7599         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7600         (aux_add_nonlocal_symbols): Make "block" const.
7601         (resolve_subexp): Remove cast.
7602         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7603         const.
7604         (iterate_over_file_blocks): Likewise.
7605         * f-exp.y (%union) <bval>: Remove.
7606         * coffread.c (patch_opaque_types): Make "b" const.
7607         * spu-tdep.c (spu_catch_start): Make "block" const.
7608         * c-valprint.c (print_unpacked_pointer): Remove "block".
7609         * symmisc.c (dump_symtab_1): Make "b" const.
7610         (block_depth): Make "block" const.
7611         * d-exp.y (%union) <bval>: Remove.
7612         * cp-support.h (cp_lookup_rtti_type): Update.
7613         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7614         * psymtab.c (psym_lookup_symbol): Make "block" const.
7615         (maintenance_check_psymtabs): Make "b" const.
7616         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7617         (enumerate_locals, enumerate_args): Update.
7618         * python/py-symtab.c (stpy_global_block): Make "block" const.
7619         (stpy_static_block): Likewise.
7620         * inline-frame.c (block_starting_point_at): Make "new_block"
7621         const.
7622         * block.c (find_block_in_blockvector): Make return type const.
7623         (blockvector_for_pc_sect): Make "b" const.
7624         (find_block_in_blockvector): Make "b" const.
7625
7626 2019-03-23  Tom Tromey  <tom@tromey.com>
7627
7628         * varobj.c (varobj_create): Update.
7629         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7630         * printcmd.c (display_command, do_one_display): Don't reset
7631         innermost_block.
7632         * parser-defs.h (enum innermost_block_tracker_type): Move to
7633         expression.h.
7634         (innermost_block): Update comment.
7635         * parse.c (parse_exp_1): Add tracker_types parameter.
7636         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7637         tracker_types parameter.  Reset innermost_block.
7638         (parse_exp_in_context): Remove.
7639         (parse_expression_for_completion): Update.
7640         * objfiles.c (~objfile): Don't reset expression_context_block or
7641         innermost_block.
7642         * expression.h (enum innermost_block_tracker_type): Move from
7643         parser-defs.h.
7644         (parse_exp_1): Add tracker_types parameter.
7645         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7646         reset innermost_block.
7647
7648 2019-03-23  Tom Tromey  <tom@tromey.com>
7649
7650         * objfiles.h: Include bcache.h.
7651
7652 2019-03-23  Tom Tromey  <tom@tromey.com>
7653
7654         * linespec.c (get_current_search_block): Use
7655         scoped_restore_current_language.
7656         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7657
7658 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7659             Jiong Wang  <jiong.wang@arm.com>
7660
7661         * aarch64-linux-tdep.c
7662         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7663         section.
7664         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7665
7666 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7667             Jiong Wang  <jiong.wang@arm.com>
7668
7669         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7670         instructions.
7671         (aarch64_analyze_prologue_test): Add PACIASP test.
7672         (aarch64_prologue_prev_register): Unmask PC value.
7673
7674 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7675             Jiong Wang  <jiong.wang@arm.com>
7676
7677         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7678         (aarch64_dwarf2_prev_register): Unmask PC value.
7679         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7680         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7681         DW_CFA_AARCH64_negate_ra_state.
7682         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7683
7684 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7685             Jiong Wang  <jiong.wang@arm.com>
7686
7687         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7688         registers.
7689         (aarch64_pseudo_register_name): Likewise.
7690         (aarch64_pseudo_register_type): Likewise.
7691         (aarch64_pseudo_register_reggroup_p): Likewise.
7692         (aarch64_gdbarch_init): Add pauth registers.
7693         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7694         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7695         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7696         (struct gdbarch_tdep): Add regnum for ra_state.
7697
7698 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7699             Jiong Wang  <jiong.wang@arm.com>
7700
7701         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7702
7703 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7704             Jiong Wang  <jiong.wang@arm.com>
7705
7706         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7707         function.
7708         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7709         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7710         (aarch64_gdbarch_init): Add puth registers.
7711         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7712         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7713         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7714
7715 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7716             Jiong Wang  <jiong.wang@arm.com>
7717
7718         * aarch64-linux-nat.c
7719         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7720         * aarch64-linux-tdep.c
7721         (aarch64_linux_core_read_description): Likewise.
7722         (aarch64_linux_get_hwcap): New function.
7723         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7724         (aarch64_linux_get_hwcap): New declaration.
7725
7726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7727             Jiong Wang  <jiong.wang@arm.com>
7728
7729         * aarch64-linux-nat.c
7730         (aarch64_linux_nat_target::read_description): Add pauth param.
7731         * aarch64-linux-tdep.c
7732         (aarch64_linux_core_read_description): Likewise.
7733         * aarch64-tdep.c (struct target_desc): Add in pauth.
7734         (aarch64_read_description): Add pauth param.
7735         (aarch64_gdbarch_init): Likewise.
7736         * aarch64-tdep.h (aarch64_read_description): Likewise.
7737         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7738         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7739         * features/Makefile: Add new files.
7740         * features/aarch64-pauth.c: New file.
7741         * features/aarch64-pauth.xml: New file.
7742
7743 2019-03-20  Tom Tromey  <tromey@adacore.com>
7744
7745         * infrun.c (handle_inferior_event): Rename from
7746         handle_inferior_event_1.  Create a scoped_value_mark.
7747         (handle_inferior_event): Remove.
7748
7749 2019-03-19  Tom Tromey  <tromey@adacore.com>
7750
7751         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7752         * infrun.h (print_stop_event): Add "displays" parameter.
7753         * infrun.c (print_stop_event): Add "displays" parameter.
7754
7755 2019-03-19  Pedro Alves  <palves@redhat.com>
7756
7757         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7758         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7759         to -1.  Fix TABs vs spaces.
7760         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7761         * tui/tui-out.h (tui_ui_out) Add intro comments.
7762         <m_line, m_start_of_line>: In-class initialize, and add describing
7763         comment.
7764
7765 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7766
7767         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7768         variable names.
7769         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7770
7771 2019-03-18  Pedro Alves  <palves@redhat.com>
7772             Eli Zaretskii <eliz@gnu.org>
7773
7774         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7775         m_line and m_start_of_line.
7776
7777 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7778
7779         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7780         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7781         it returns a newline.  This fixes a regression in TU mode, whereby
7782         the next line is output on the same screen line as the user input.
7783
7784 2019-03-18  Tom Tromey  <tromey@adacore.com>
7785
7786         * minsyms.c (minimal_symbol_reader::install): Remove call to
7787         obstack_blank.
7788
7789 2019-03-18  Pedro Alves  <palves@redhat.com>
7790
7791         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7792         New globals.
7793         (apply_style): New, factored out from ...
7794         (apply_ansi_escape): ... this.  Handle reverse video mode.
7795         (tui_set_reverse_mode): New function.
7796         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7797         * tui/tui-winsource.c (tui_show_source_line): Use
7798         tui_set_reverse_mode instead of setting A_STANDOUT.
7799         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7800         New setter methods.
7801
7802 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7803
7804         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7805         Handle tabs.
7806
7807 2019-03-18  Tom Tromey  <tromey@adacore.com>
7808
7809         * ada-lang.c (empty_array): Add "high" parameter.
7810         (ada_evaluate_subexp): Update.
7811
7812 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7813
7814         * unittests/string_view-selftests.c: Define
7815         _initialize_string_view_selftests unconditionally.
7816
7817 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7818
7819         PR gdb/24350
7820         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7821
7822 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7823
7824         PR gdb/24351
7825         * windows-nat.c (display_selector): Fix format specifiers.
7826
7827 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7828
7829         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7830         tui_refill_source_window instead of tui_refresh_win, to update the
7831         current execution line.  This fixes redisplay of the current line
7832         when stepping through the code with "next" or "step".
7833
7834 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7835
7836         * source-cache.c (source_cache::get_source_lines): Call
7837         find_source_lines to initialize s->nlines.  This fixes vertical
7838         scrolling of TUI source window when the DOWN arrow is pressed.
7839
7840 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7841
7842         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7843         linux-thread-db.c (_initialize_thread_db): Likewise.
7844
7845 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7846
7847         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7848         wclrtoeol in tui_show_source_line".  This reverts changes made in
7849         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7850
7851 2019-03-15  Tom Tromey  <tom@tromey.com>
7852
7853         * symtab.h (struct minimal_symbol): Derive from
7854         general_symbol_info.
7855         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7856         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7857         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7858         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7859         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7860         (MSYMBOL_SEARCH_NAME): Update.
7861         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7862         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7863         * minsyms.c (minimal_symbol_reader::record_full): Update.
7864
7865 2019-03-15  Tom Tromey  <tom@tromey.com>
7866
7867         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7868
7869 2019-03-15  Tom Tromey  <tom@tromey.com>
7870
7871         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7872         unique_xmalloc_ptr.
7873         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7874         Update.
7875         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7876         (build_minimal_symbol_hash_tables)
7877         (minimal_symbol_reader::install): Update.
7878
7879 2019-03-15  Tom Tromey  <tom@tromey.com>
7880
7881         * symtab.c (create_demangled_names_hash): Update.
7882         (symbol_set_names): Update.
7883         * objfiles.h (struct objfile_per_bfd_storage)
7884         <demangled_names_hash>: Now an htab_up.
7885         * objfiles.c (objfile_per_bfd_storage): Simplify.
7886
7887 2019-03-15  Tom Tromey  <tom@tromey.com>
7888
7889         * objfiles.h (struct objfile_per_bfd_storage): Declare
7890         destructor.
7891         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7892         New.
7893         (get_objfile_bfd_data): Use new.  Don't initialize
7894         language_of_main.
7895         (free_objfile_per_bfd_storage): Remove.
7896         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7897
7898 2019-03-15  Tom Tromey  <tom@tromey.com>
7899
7900         * symfile.c (reread_symbols): Update.
7901         * objfiles.c (objfile::objfile): Update.
7902         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7903         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7904         comment.
7905         (minimal_symbol_reader::install): Update.
7906         (terminate_minimal_symbol_table): Remove.
7907         * jit.c (jit_object_close_impl): Update.
7908
7909 2019-03-15  Tom Tromey  <tom@tromey.com>
7910
7911         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7912         initializations.
7913
7914 2019-03-15  Tom Tromey  <tom@tromey.com>
7915
7916         * objfiles.h (struct objfile_per_bfd_storage)
7917         <demangled_hash_languages>: Now a bitset.
7918         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7919         (lookup_minimal_symbol): Update.
7920
7921 2019-03-15  Tom Tromey  <tom@tromey.com>
7922
7923         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7924         Don't return the symbol.
7925         * coffread.c (record_minimal_symbol): Use record_full.
7926
7927 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7928
7929         The MS-Windows port of ncurses fails to switch to a color pair if
7930         one or both of the colors are the implicit default colors.  This
7931         change records the default colors when TUI is initialized, and
7932         then specifies them explicitly when a color pair uses the default
7933         colors.  This allows color styling in TUI mode on MS-Windows.
7934
7935         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7936         ncurses_norm_attr.
7937         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7938         colors in ncurses_norm_attr.
7939         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7940         "none", replace it with the default color recorded in
7941         ncurses_norm_attr.
7942
7943 2019-03-14  Tom Tromey  <tromey@adacore.com>
7944
7945         * source-cache.h (class source_cache) <get_source_lines>: Return
7946         std::string.
7947         * source-cache.c (source_cache::extract_lines): Handle case where
7948         first_pos==npos.  Return std::string.
7949         (source_cache::get_source_lines): Update.
7950
7951 2019-03-14  Tom Tromey  <tromey@adacore.com>
7952
7953         * NEWS: Add item for "style sources" commands.
7954         * source-cache.c (source_cache::get_source_lines): Check
7955         source_styling.
7956         * cli/cli-style.c (source_styling): New global.
7957         (_initialize_cli_style): Add "style sources" commands.
7958         (show_style_sources): New function.
7959         * cli/cli-style.h (source_styling): Declare.
7960
7961 2019-03-14  Pedro Alves  <palves@redhat.com>
7962             Tom Tromey  <tromey@adacore.com>
7963
7964         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7965         * tui/tui-winsource.c (tui_refill_source_window): New function,
7966         from...
7967         (tui_horizontal_source_scroll): ... here.  Move some logic.
7968         * cli/cli-style.c (set_style_enabled): Notify new observable.
7969         * tui/tui-hooks.c (tui_redisplay_source): New function.
7970         (tui_attach_detach_observers): Attach or detach
7971         tui_redisplay_source.
7972         * observable.h (source_styling_changed): New observable.
7973         * observable.c: Define source_styling_changed observable.
7974
7975 2019-03-13  Tom Tromey  <tromey@adacore.com>
7976
7977         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7978         (i386_gnu_nat_target::store_registers): Update.
7979         * target-debug.h (target_debug_print_std_string): New macro.
7980         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7981         * windows-tdep.c (display_one_tib): Update.
7982         * tui/tui-stack.c (tui_make_status_line): Update.
7983         * top.c (print_inferior_quit_action): Update.
7984         * thread.c (thr_try_catch_cmd): Update.
7985         (add_thread_with_info): Update.
7986         (thread_target_id_str): Update.
7987         (thr_try_catch_cmd): Update.
7988         (thread_command): Update.
7989         (thread_find_command): Update.
7990         * record-btrace.c (record_btrace_target::info_record)
7991         (record_btrace_resume_thread, record_btrace_target::resume)
7992         (record_btrace_cancel_resume, record_btrace_step_thread)
7993         (record_btrace_target::wait, record_btrace_target::wait)
7994         (record_btrace_target::wait, record_btrace_target::stop): Update.
7995         * progspace.c (print_program_space): Update.
7996         * process-stratum-target.c
7997         (process_stratum_target::thread_address_space): Update.
7998         * linux-fork.c (linux_fork_mourn_inferior)
7999         (detach_checkpoint_command, info_checkpoints_command)
8000         (linux_fork_context): Update.
8001         (linux_fork_detach): Update.
8002         (class scoped_switch_fork_info): Update.
8003         (delete_checkpoint_command): Update.
8004         * infrun.c (follow_fork_inferior): Update.
8005         (follow_fork_inferior): Update.
8006         (proceed_after_vfork_done): Update.
8007         (handle_vfork_child_exec_or_exit): Update.
8008         (follow_exec): Update.
8009         (displaced_step_prepare_throw): Update.
8010         (displaced_step_restore): Update.
8011         (start_step_over): Update.
8012         (resume_1): Update.
8013         (clear_proceed_status_thread): Update.
8014         (proceed): Update.
8015         (print_target_wait_results): Update.
8016         (do_target_wait): Update.
8017         (context_switch): Update.
8018         (stop_all_threads): Update.
8019         (restart_threads): Update.
8020         (finish_step_over): Update.
8021         (handle_signal_stop): Update.
8022         (switch_back_to_stepped_thread): Update.
8023         (keep_going_pass_signal): Update.
8024         (print_exited_reason): Update.
8025         (normal_stop): Update.
8026         * inferior.c (inferior_pid_to_str): Change return type.
8027         (print_selected_inferior): Update.
8028         (add_inferior): Update.
8029         (detach_inferior): Update.
8030         * dummy-frame.c (fprint_dummy_frames): Update.
8031         * dcache.c (dcache_info_1): Update.
8032         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8033         (btrace_fetch, btrace_clear): Update.
8034         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8035         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8036         type.
8037         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8038         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8039         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8040         * gdbarch.c, gdbarch.h: Rebuild.
8041         * gdbarch.sh (core_pid_to_str): Change return type.
8042         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8043         return type.
8044         (windows_nat_target::pid_to_str): Change return type.
8045         (windows_delete_thread): Update.
8046         (windows_nat_target::attach): Update.
8047         (windows_nat_target::files_info): Update.
8048         * target-delegates.c: Rebuild.
8049         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8050         return type.
8051         (sol_thread_target::pid_to_str): Change return type.
8052         * remote.c (class remote_target) <pid_to_str>: Change return
8053         type.
8054         (remote_target::pid_to_str): Change return type.
8055         (extended_remote_target::attach, remote_target::remote_stop_ns)
8056         (remote_target::remote_notif_remove_queued_reply)
8057         (remote_target::push_stop_reply, remote_target::disable_btrace):
8058         Update.
8059         (extended_remote_target::attach): Update.
8060         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8061         type.
8062         (gdbsim_target::pid_to_str): Change return type.
8063         * ravenscar-thread.c (struct ravenscar_thread_target)
8064         <pid_to_str>: Change return type.
8065         (ravenscar_thread_target::pid_to_str): Change return type.
8066         * procfs.c (class procfs_target) <pid_to_str>: Change return
8067         type.
8068         (procfs_target::pid_to_str): Change return type.
8069         (procfs_target::attach): Update.
8070         (procfs_target::detach): Update.
8071         (procfs_target::fetch_registers): Update.
8072         (procfs_target::store_registers): Update.
8073         (procfs_target::wait): Update.
8074         (procfs_target::files_info): Update.
8075         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8076         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8077         return type.
8078         (nto_procfs_target::pid_to_str): Change return type.
8079         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8080         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8081         return type.
8082         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8083         (exit_lwp): Update.
8084         (attach_proc_task_lwp_callback, get_detach_signal)
8085         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8086         (linux_nat_target::resume, wait_lwp, stop_callback)
8087         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8088         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8089         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8090         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8091         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8092         type.
8093         (inf_ptrace_target::attach): Update.
8094         (inf_ptrace_target::files_info): Update.
8095         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8096         type.
8097         (go32_nat_target::pid_to_str): Change return type.
8098         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8099         (gnu_nat_target::wait): Update.
8100         (gnu_nat_target::wait): Update.
8101         (gnu_nat_target::resume): Update.
8102         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8103         (fbsd_nat_target::wait): Update.
8104         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8105         type.
8106         (darwin_nat_target::attach): Update.
8107         * corelow.c (class core_target) <pid_to_str>: Change return type.
8108         (core_target::pid_to_str): Change return type.
8109         * target.c (normal_pid_to_str): Change return type.
8110         (default_pid_to_str): Likewise.
8111         (target_pid_to_str): Change return type.
8112         (target_translate_tls_address): Update.
8113         (target_announce_detach): Update.
8114         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8115         return type.
8116         (bsd_uthread_target::pid_to_str): Change return type.
8117         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8118         type.
8119         (bsd_kvm_target::pid_to_str): Change return type.
8120         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8121         return type.
8122         (aix_thread_target::pid_to_str): Change return type.
8123         * target.h (struct target_ops) <pid_to_str>: Change return type.
8124         (target_pid_to_str, normal_pid_to_str): Likewise.
8125         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8126         type.
8127         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8128         type.
8129         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8130         return type.
8131         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8132         type.
8133         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8134         type.
8135         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8136         return type.
8137
8138 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8139
8140         * NEWS: Mention that the new default MI version is 3.  Mention
8141         changes to the output of commands and events that deal with
8142         multi-location breakpoints.
8143         * breakpoint.c: Include "mi/mi-out.h".
8144         (print_one_breakpoint): Change output syntax if using MI version
8145         >= 3.
8146         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8147         New.
8148         (mi_multi_location_breakpoint_output_fixed): New.
8149         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8150         (mi_cmd_fix_multi_location_breakpoint_output): New.
8151         (mi_multi_location_breakpoint_output_fixed): New.
8152         * mi/mi-cmds.c (mi_cmds): Register command
8153         -fix-multi-location-breakpoint-output.
8154         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8155         interpreter "mi".
8156
8157 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8158
8159         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8160         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8161         instantiate mi_ui_out based on interpreter name.
8162         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8163         * mi/mi-main.c (mi_load_progress): Likewise.
8164
8165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8166
8167         * NEWS: Combine separate "New targets" sections for 8.3.
8168
8169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8170
8171         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8172         (ppcfbsd_init_abi): Install gdbarch
8173         "fetch_tls_load_module_address" and "get_thread_local_address"
8174         methods.
8175
8176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8177
8178         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8179         (riscv_fbsd_init_abi): Install gdbarch
8180         "fetch_tls_load_module_address" and "get_thread_local_address"
8181         methods.
8182
8183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8184
8185         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8186         (i386fbsd_init_abi): Install gdbarch
8187         "fetch_tls_load_module_address" and "get_thread_local_address"
8188         methods.
8189
8190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8191
8192         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8193         (amd64fbsd_init_abi): Install gdbarch
8194         "fetch_tls_load_module_address" and "get_thread_local_address"
8195         methods.
8196
8197 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8198
8199         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8200         (struct fbsd_pspace_data): New type.
8201         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8202         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8203         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8204         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8205         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8206
8207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8208
8209         * gdbtypes.c (lookup_struct_elt): New function.
8210         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8211         * gdbtypes.h (struct struct_elt): New type.
8212         (lookup_struct_elt): New prototype.
8213
8214 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8215
8216         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8217         remove disabled code block.
8218
8219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8220
8221         * gdbarch.sh (get_thread_local_address): New method.
8222         * gdbarch.h, gdbarch.c: Regenerate.
8223         * target.c (target_translate_tls_address): Use
8224         gdbarch_get_thread_local_address if present instead of
8225         target::get_thread_local_address.
8226
8227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8228
8229         * target.h (target::get_thread_local_address): Update comment.
8230
8231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8232
8233         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8234         objfile->separate_debug_objfile_backlink if not NULL.
8235
8236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8237
8238         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8239         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8240         (amd64bsd_store_inferior_registers): Likewise.
8241         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8242         Enable segment base registers.
8243         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8244         PT_GETFSBASE and PT_GETGSBASE.
8245         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8246         PT_SETGSBASE.
8247         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8248         segment base registers.
8249         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8250
8251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8252
8253         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8254         Update calls to i386_target_description to add 'segments'
8255         parameter.
8256         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8257         add segment base registers.
8258         * arch/i386.c (i386_create_target_description): Add 'segments'
8259         parameter to enable segment base registers.
8260         * arch/i386.h (i386_create_target_description): Likewise.
8261         * features/i386/32bit-segments.xml: New file.
8262         * features/i386/32bit-segments.c: Generate.
8263         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8264         call to i386_target_description to add 'segments' parameter.
8265         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8266         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8267         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8268         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8269         if feature is present.
8270         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8271         Add 'segments' parameter to call to i386_target_description.
8272         (i386_target_description): Add 'segments' parameter to enable
8273         segment base registers.
8274         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8275         to call to i386_target_description.
8276         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8277         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8278         Define I386_NUM_REGS.
8279         (i386_target_description): Add 'segments' parameter to enable
8280         segment base registers.
8281
8282 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8283
8284         PR/24325
8285         * source-cache.c: #undef open and close, to avoid unresolved
8286         externals during linking.
8287
8288 2019-03-12  Tom Tromey  <tromey@adacore.com>
8289
8290         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8291         const.  Add initializers.
8292         (_initialize_remote): Don't initialize ptid globals.
8293
8294 2019-03-12  Pedro Alves  <palves@redhat.com>
8295
8296         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8297
8298 2019-03-12  Pedro Alves  <palves@redhat.com>
8299
8300         * cp-name-parser.y (main): Remove unused 'len' variable.
8301
8302 2019-03-12  Tom Tromey  <tromey@adacore.com>
8303
8304         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8305         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8306
8307 2019-03-12  Tom Tromey  <tromey@adacore.com>
8308
8309         * linux-nat.c (iterate_over_lwps): Update.
8310         (stop_callback): Remove parameter.
8311         (stop_wait_callback, detach_callback, resume_set_callback)
8312         (select_singlestep_lwp_callback, set_ignore_sigint)
8313         (status_callback, resumed_callback, resume_clear_callback)
8314         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8315         data parameter.
8316         (linux_nat_target::detach, linux_nat_target::resume)
8317         (linux_stop_and_wait_all_lwps, select_event_lwp)
8318         (linux_nat_filter_event, linux_nat_wait_1)
8319         (linux_nat_target::kill, linux_nat_target::stop)
8320         (linux_nat_target::stop): Update.
8321         (linux_nat_resume_callback): Change type.
8322         (resume_stopped_resumed_lwps, count_events_callback)
8323         (select_event_lwp_callback): Likewise.
8324         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8325         * arm-linux-nat.c (struct update_registers_data): Remove.
8326         (update_registers_callback): Change type.
8327         (arm_linux_insert_hw_breakpoint1): Update.
8328         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8329         parameter.
8330         (x86_linux_dr_set_addr): Update.
8331         (x86_linux_dr_set_control): Update.
8332         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8333         (iterate_over_lwps): Use gdb::function_view.
8334         * nat/aarch64-linux-hw-point.c (struct
8335         aarch64_dr_update_callback_param): Remove.
8336         (debug_reg_change_callback): Change type.
8337         (aarch64_notify_debug_reg_change): Update.
8338         * s390-linux-nat.c (s390_refresh_per_info): Update.
8339
8340 2019-03-11  Tom Tromey  <tromey@adacore.com>
8341
8342         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8343         redundant assignment to "this_cu".
8344
8345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8346
8347         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8348
8349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8350
8351         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8352         from...
8353         (rank_one_type): ... this.
8354
8355 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8356
8357         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8358         from...
8359         (rank_one_type): ... this.
8360
8361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8362
8363         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8364         from...
8365         (rank_one_type): ... this.
8366
8367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8368
8369         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8370         from...
8371         (rank_one_type): ... this.
8372
8373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8374
8375         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8376         from...
8377         (rank_one_type): ... this.
8378
8379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8380
8381         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8382         from...
8383         (rank_one_type): ... this.
8384
8385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8386
8387         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8388         from...
8389         (rank_one_type): ... this.
8390
8391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8392
8393         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8394         from...
8395         (rank_one_type): ... this.
8396
8397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8398
8399         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8400         from...
8401         (rank_one_type): ... this.
8402
8403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8404
8405         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8406         from...
8407         (rank_one_type): ... this.
8408
8409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8410
8411         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8412         from...
8413         (rank_one_type): ... this.
8414
8415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8416
8417         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8418         from...
8419         (rank_one_type): ... this.
8420
8421 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8422
8423         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8424         inferior-events' shows the example events.
8425
8426 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8427
8428         Support styling on native MS-Windows console
8429
8430         PR/24315
8431         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8432         on MS-Windows if $TERM is not defined.
8433
8434         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8435
8436         * posix-hdep.c (gdb_console_fputs):
8437         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8438         functions.
8439         * ui-file.h (gdb_console_fputs): Add prototype.
8440
8441         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8442         back to fputs only if the former returns zero.
8443
8444 2019-03-07  Tom Tromey  <tom@tromey.com>
8445
8446         * symmisc.c (print_symbol_bcache_statistics): Update.
8447         (print_objfile_statistics): Update.
8448         * symfile.c (allocate_symtab): Update.
8449         * stabsread.c: Don't include bcache.h.
8450         * psymtab.h (struct psymbol_bcache): Don't declare.
8451         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8452         (psymbol_bcache_init, psymbol_bcache_free)
8453         (psymbol_bcache_get_bcache): Don't declare.
8454         * psymtab.c (struct psymbol_bcache): Remove.
8455         (psymtab_storage::psymtab_storage): Update.
8456         (psymtab_storage::~psymtab_storage): Update.
8457         (psymbol_bcache_init, psymbol_bcache_free)
8458         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8459         (add_psymbol_to_bcache): Update.
8460         (allocate_psymtab): Update.
8461         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8462         macro_cache>: No longer pointers.
8463         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8464         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8465         * macrotab.c (macro_bcache): Update.
8466         * macroexp.c: Don't include bcache.h.
8467         * gdbtypes.c (check_types_worklist): Update.
8468         (types_deeply_equal): Remove TRY/CATCH.  Update.
8469         * elfread.c (elf_symtab_read): Update.
8470         * dwarf2read.c: Don't include bcache.h.
8471         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8472         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8473         (print_bcache_statistics, bcache_memory_used): Don't declare.
8474         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8475         methods.  Rename all data members.
8476         * bcache.c (struct bcache): Move to bcache.h.
8477         (bcache::expand_hash_table): Rename from expand_hash_table.
8478         (bcache): Remove.
8479         (bcache::insert): Rename from bcache_full.
8480         (bcache::compare): Rename from bcache_compare.
8481         (bcache_xmalloc): Remove.
8482         (bcache::~bcache): Rename from bcache_xfree.
8483         (bcache::print_statistics): Rename from print_bcache_statistics.
8484         (bcache::memory_used): Rename from bcache_memory_used.
8485
8486 2019-03-07  Pedro Alves  <palves@redhat.com>
8487
8488         * infrun.c (normal_stop): Also check for
8489         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8490
8491 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8492
8493         * f-lang.c (value_from_host_double): Moved to...
8494         * value.c (value_from_host_double): ...here.
8495         * value.h (value_from_host_double): Declare.
8496         * guile/scm-math.c (vlscm_convert_typed_number): Use
8497         value_from_host_double.
8498         (vlscm_convert_number): Likewise.
8499         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8500         * python/py-value.c (convert_value_from_python): Likewise.
8501
8502 2019-03-06  Tom Tromey  <tom@tromey.com>
8503
8504         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8505
8506 2019-03-06  Tom Tromey  <tom@tromey.com>
8507
8508         * utils.h (free_current_contents): Don't declare.
8509         * utils.c (free_current_contents): Remove.
8510
8511 2019-03-06  Tom Tromey  <tom@tromey.com>
8512
8513         * top.c (quit_force): Update.
8514         * main.c (captured_command_loop): Update.
8515         * common/new-op.c (operator new): Update.
8516         * common/common-exceptions.c (struct catcher)
8517         <save_cleanup_chain>: Remove member.
8518         (exceptions_state_mc_init): Update.
8519         (exception_try_scope_entry): Return nullptr.
8520         (exception_try_scope_exit, exception_rethrow)
8521         (throw_exception_sjlj, throw_exception_cxx): Update.
8522         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8523         (all_cleanups, do_cleanups, discard_cleanups)
8524         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8525         (restore_cleanups, restore_final_cleanups): Don't declare.
8526         (do_final_cleanups): Remove parameter.
8527         * common/cleanups.c (cleanup_chain, make_cleanup)
8528         (make_cleanup_dtor, all_cleanups, do_cleanups)
8529         (discard_my_cleanups, discard_cleanups)
8530         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8531         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8532         (null_cleanup): Remove.
8533         (do_final_cleanups): Remove parameter.
8534
8535 2019-03-06  Tom Tromey  <tom@tromey.com>
8536
8537         * remote.c (remote_target::remote_parse_stop_reply): Use
8538         unique_xmalloc_ptr.
8539
8540 2019-03-06  Tom Tromey  <tom@tromey.com>
8541
8542         * stabsread.c (struct stabs_field_info): Rename from field_info.
8543         <list, fnlist>: Add initializers.
8544         <obstack>: New member.
8545         (read_member_functions, read_struct_fields, read_baseclasses):
8546         Allocate on obstack.  Don't use cleanups.
8547         (read_one_struct_field, read_member_functions, read_struct_fields)
8548         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8549         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8550         (read_struct_type): Update.
8551
8552 2019-03-06  Tom Tromey  <tom@tromey.com>
8553
8554         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8555         * common/filestuff.h (make_cleanup_close): Don't declare.
8556         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8557         Remove.
8558
8559 2019-03-06  Tom Tromey  <tom@tromey.com>
8560
8561         * solib-aix.c: Use make_scope_exit.
8562
8563 2019-03-06  Tom Tromey  <tom@tromey.com>
8564
8565         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8566         Use make_scope_exit.
8567
8568 2019-03-06  Tom Tromey  <tom@tromey.com>
8569
8570         * solib-svr4.c (disable_probes_interface): Remove parameter.
8571         (svr4_handle_solib_event): Use make_scope_exit.
8572
8573 2019-03-06  Tom Tromey  <tom@tromey.com>
8574
8575         * remote.c (struct stop_reply_deleter): Remove.
8576         (stop_reply_up): Update.
8577         (struct stop_reply): Derive from notif_event.  Don't typedef.
8578         <regcache>: Now a std::vector.
8579         (stop_reply_xfree): Remove.
8580         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8581         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8582         (remote_target::discard_pending_stop_replies): Use delete.
8583         (remote_target::remote_parse_stop_reply): Update.
8584         (remote_target::process_stop_reply): Update.
8585         * remote-notif.h (struct notif_event): Add virtual destructor.
8586         Remove "dtr" member.
8587         (struct notif_client) <alloc_event>: Return a unique_ptr.
8588         (notif_event_xfree): Don't declare.
8589         (notif_event_up): New typedef.
8590         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8591         (notif_event_xfree, do_notif_event_xfree): Remove.
8592         (remote_notif_state_xfree): Update.
8593
8594 2019-03-06  Tom Tromey  <tom@tromey.com>
8595
8596         * infrun.c (displaced_step_clear_cleanup): Now a
8597         forward_scope_exit type.
8598         (displaced_step_prepare_throw): Update.
8599         (displaced_step_fixup): Update.
8600
8601 2019-03-06  Tom Tromey  <tom@tromey.com>
8602
8603         * inferior.h (class inferior): Update comment.
8604         * gdbthread.h (class thread_info): Update comment.
8605
8606 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8607             Tom Tromey  <tom@tromey.com>
8608
8609         * stabsread.h (struct stab_section_list): Remove.
8610         (coffstab_build_psymtabs): Update.
8611         * dbxread.c (symbuf_sections): Now a std::vector.
8612         (sect_idx): New global.
8613         (fill_symbuf): Update.
8614         (coffstab_build_psymtabs): Change type of stabsects parameter.
8615         Update.
8616         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8617         std::vector.
8618         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8619         (coff_locate_sections): Update.
8620         (coff_symfile_read): Remove cleanups.  Update.
8621         (init_stringtab): Add storage parameter.
8622         (free_stringtab, free_stringtab_cleanup): Remove.
8623         (init_lineno): Add storage parameter.
8624         (free_linetab, free_linetab_cleanup): Remove.
8625
8626 2019-03-06  Pedro Alves  <palves@redhat.com>
8627
8628         * linux-fork.c (fork_info::clobber_regs): Delete.
8629         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8630         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8631         comment.  Adjust.
8632         (scoped_switch_fork_info::scoped_switch_fork_info)
8633         (checkpoint_command, linux_fork_context): Adjust
8634         fork_save_infrun_state calls.
8635
8636 2019-03-06  Pedro Alves  <palves@redhat.com>
8637
8638         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8639         (inf_has_multiple_threads): Return 'bool' and rewrite using
8640         inferior_info::threads().
8641
8642 2019-03-06  Pedro Alves  <palves@redhat.com>
8643
8644         * linux-fork.c: Include <list>.
8645         (fork_list): Now a std::list instance.
8646         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8647         (forks_exist_p, find_last_fork): Adjust.
8648         (new_fork): Delete.
8649         (one_fork_p): New.
8650         (add_fork): Adjust.
8651         (free_fork): Delete, folded into fork_info::~fork_info().
8652         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8653         Adjust.
8654         (init_fork_list): Delete.
8655         (linux_fork_killall, linux_fork_mourn_inferior)
8656         (linux_fork_detach, info_checkpoints_command): Adjust.
8657         (_initialize_linux_fork): No longer call init_fork_list.
8658
8659 2019-03-06  Pedro Alves  <palves@redhat.com>
8660
8661         * linux-fork.c (new_fork): New, split out of ...
8662         (add_fork): ... this.  Return void.  Move "first fork" special
8663         case from here, to ...
8664         (checkpoint_command): ... here.
8665         * linux-linux.h (add_fork): Return void.
8666
8667 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8668
8669         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8670
8671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8672             Chris January  <chris.january@arm.com>
8673             David Lecomber  <david.lecomber@arm.com>
8674
8675         * f-exp.y: New token, UNOP_INTRINSIC.
8676         (exp): New pattern using UNOP_INTRINSIC token.
8677         (f77_keywords): Add 'abs' keyword.
8678         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8679         (value_from_host_double): New function.
8680         (evaluate_subexp_f): Support UNOP_ABS.
8681
8682 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8683
8684         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8685         types.
8686
8687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8688
8689         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8690         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8691         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8692
8693 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8694
8695         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8696
8697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8698             Chris January  <chris.january@arm.com>
8699
8700         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8701         * f-exp.y: Define 'KIND' token.
8702         (exp): New pattern for KIND expressions.
8703         (ptype): Handle types with a kind extension.
8704         (direct_abs_decl): Extend to spot kind extensions.
8705         (f77_keywords): Add 'kind' to the list.
8706         (push_kind_type): New function.
8707         (convert_to_kind_type): New function.
8708         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8709         * parse.c (operator_length_standard): Likewise.
8710         * parser-defs.h (enum type_pieces): Add tp_kind.
8711         * std-operator.def: Add UNOP_KIND.
8712
8713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8714
8715         * f-exp.y (f_parse): Set yydebug.
8716
8717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8718
8719         * f-lang.c (evaluate_subexp_f): New function.
8720         (exp_descriptor_f): New global.
8721         (f_language_defn): Use exp_descriptor_f instead of
8722         exp_descriptor_standard.
8723
8724 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8725
8726         * f-exp.y (struct token): Add comments.
8727         (dot_ops): Remove uppercase versions and the end marker.
8728         (f77_keywords): Likewise.
8729         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8730         entries in the dot_ops array are case insensitive, and use
8731         strncasecmp to compare strings.  Also some whitespace cleanup in
8732         this area.  Similar for the f77_keywords array, except entries in
8733         this list might be case sensitive.
8734
8735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * f-exp.y (struct f77_boolean_val): Add comments.
8738         (boolean_values): Remove uppercase versions, and end marker.
8739         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8740         and use strncasecmp to achieve case insensitivity.  Additionally,
8741         perform whitespace cleanup around this code.
8742
8743 2019-03-06  Tom Tromey  <tromey@adacore.com>
8744
8745         * remote-sim.c (gdbsim_target_open): Use result of
8746         gdb_argv::release.
8747
8748 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8749         Dirk Schubert  <dirk.schubert@arm.com>
8750         Chris January  <chris.january@arm.com>
8751
8752         * eval.c (evaluate_subexp_standard): Call Fortran argument
8753         wrapping logic.
8754         * f-lang.c (struct value): A value which can be passed into a
8755         Fortran function call.
8756         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8757         where appropriate.
8758         (struct type): Value ready for a Fortran function call.
8759         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8760         is needed.
8761         * f-lang.h (fortran_argument_convert): Declaration.
8762         (fortran_preserve_arg_pointer): Declaration.
8763         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8764
8765 2019-03-05  Tom Tromey  <tromey@adacore.com>
8766
8767         * python/py-prettyprint.c (print_string_repr): Remove #if.
8768         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8769
8770 2019-03-05  Tom Tromey  <tromey@adacore.com>
8771
8772         * target.c (the_dummy_target): Move later.  Change type to
8773         "dummy_target".
8774         (initialize_targets): Don't initialize the_dummy_target.
8775
8776 2019-03-05  Tom Tromey  <tromey@adacore.com>
8777
8778         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8779         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8780
8781 2019-03-05  Tom Tromey  <tromey@adacore.com>
8782
8783         * windows-nat.c (windows_nat_target::attach)
8784         (windows_nat_target::detach): Don't call gdb_flush.
8785         * valprint.c (generic_val_print, val_print, val_print_string):
8786         Don't call gdb_flush.
8787         * utils.c (defaulted_query): Don't call gdb_flush.
8788         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8789         * target.c (target_announce_detach): Don't call gdb_flush.
8790         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8791         * remote.c (extended_remote_target::attach): Don't call
8792         gdb_flush.
8793         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8794         * printcmd.c (do_examine): Don't call gdb_flush.
8795         (info_display_command): Don't call gdb_flush.
8796         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8797         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8798         * memattr.c (info_mem_command): Don't call gdb_flush.
8799         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8800         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8801         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8802         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8803         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8804         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8805         (gnu_nat_target::detach): Don't call gdb_flush.
8806         * f-valprint.c (f_val_print): Don't call gdb_flush.
8807         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8808         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8809         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8810         gdb_flush.
8811         * c-valprint.c (c_val_print): Don't call gdb_flush.
8812         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8813
8814 2019-03-05  Tom Tromey  <tromey@adacore.com>
8815
8816         * varobj.c (update_dynamic_varobj_children): Update.
8817         (install_default_visualizer): Use reset, not release.
8818         * value.c (set_internalvar): Update.
8819         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8820         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8821         ATTRIBUTE_UNUSED_RESULT.
8822
8823 2019-03-05  Tom Tromey  <tromey@adacore.com>
8824
8825         * remote.c (class scoped_remote_fd) <release>: Add
8826         ATTRIBUTE_UNUSED_RESULT.
8827
8828 2019-03-05  Tom Tromey  <tromey@adacore.com>
8829
8830         * macroexp.c (struct macro_buffer) <release>: Add
8831         ATTRIBUTE_UNUSED_RESULT.
8832
8833 2019-03-05  Tom Tromey  <tromey@adacore.com>
8834
8835         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8836         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8837         ATTRIBUTE_UNUSED_RESULT.
8838
8839 2019-03-05  Tom Tromey  <tromey@adacore.com>
8840
8841         * common/scoped_fd.h (class scoped_fd) <release>: Add
8842         ATTRIBUTE_UNUSED_RESULT.
8843
8844 2019-03-05  Tom Tromey  <tromey@adacore.com>
8845
8846         * parser-defs.h (struct parser_state) <release>: Add
8847         ATTRIBUTE_UNUSED_RESULT.
8848
8849 2019-03-05  Tom Tromey  <tromey@adacore.com>
8850
8851         * utils.h (class gdb_argv) <release>: Add
8852         ATTRIBUTE_UNUSED_RESULT.
8853         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8854
8855 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8856
8857         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8858         for-loop range, to avoid compiler warnings.
8859
8860         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8861         avoid compiler warnings about unused variables.
8862
8863         * NEWS: Mention end of support for native debugging on MS-Windows
8864         before XP.
8865
8866         PR gdb/24292
8867         * common/netstuff.c:
8868         * gdbserver/gdbreplay.c
8869         * gdbserver/remote-utils.c:
8870         * ser-tcp.c:
8871         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8872         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8873         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8874         'getaddrinfo' and 'freeaddrinfo' were not available before
8875         Windows XP, and mingw.org's MinGW headers by default define
8876         _WIN32_WINNT to 0x500.
8877
8878 2019-03-01  Gary Benson <gbenson@redhat.com>
8879
8880         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8881
8882 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8883             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8884
8885         PR gdb/8527
8886         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8887         set_sigint_trap, clear_sigint_trap.
8888
8889 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8890
8891         * target.c (target_detach): Clear the regcache and the
8892         frame cache.
8893
8894 2019-02-27  Pedro Alves  <palves@redhat.com>
8895
8896         * utils.c (set_screen_size): When we cap the height/width sizes,
8897         tweak the corresponding command variable to show "unlimited":
8898
8899 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8900             Pedro Alves  <palves@redhat.com>
8901
8902         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8903         before calling rl_set_screen_size.
8904
8905 2019-02-27  Tom Tromey  <tromey@adacore.com>
8906
8907         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8908         define.
8909         * python/py-value.c: Remove Python 2.4 workaround.
8910         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8911         workaround.
8912         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8913         Python 2.4 workaround.
8914         * python/python-internal.h: Remove Python 2.4 comment.
8915         (Py_ssize_t): Don't define.
8916         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8917         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8918         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8919         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8920         * python/python.c (do_start_initialization): Remove Python 2.4
8921         workaround.
8922         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8923         (print_children): Remove Python 2.4 workaround.
8924         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8925         workaround.
8926         (CHARBUFFERPROC_NAME): Remove.
8927         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8928         Python 2.4 workaround.
8929
8930 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8931
8932         * NEWS: Note minimum Python version.
8933
8934 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8935
8936         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8937         code from these functions.  Remove corresponding ifdefs.  Use
8938         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8939         Remove gotos and target of gotos.
8940         (infpy_search_memory): Likewise.
8941
8942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8943
8944         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8945         (hppa_gdbarch_init): Don't register deleted functions with
8946         gdbarch.
8947
8948 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8951         (h8300_unwind_sp): Delete.
8952         (h8300_dummy_id): Delete.
8953         (h8300_gdbarch_init): Don't register deleted functions with
8954         gdbarch.
8955
8956 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8959         (ft32_unwind_pc): Delete.
8960         (ft32_unwind_sp): Delete.
8961         (ft32_gdbarch_init): Don't register deleted functions with
8962         gdbarch.
8963
8964 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8965
8966         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8967         (frv_unwind_pc): Delete.
8968         (frv_unwind_sp): Delete.
8969         (frv_gdbarch_init): Don't register deleted functions with
8970         gdbarch.
8971
8972 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8973
8974         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8975         (riscv_unwind_pc): Delete.
8976         (riscv_unwind_sp): Delete.
8977         (riscv_gdbarch_init): Don't register deleted functions with
8978         gdbarch.
8979
8980 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8981
8982         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8983         (csky_unwind_pc): Delete.
8984         (csky_unwind_sp): Delete.
8985         (csky_gdbarch_init): Don't register deleted functions with
8986         gdbarch.
8987
8988 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8989
8990         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8991         (cris_unwind_pc): Delete.
8992         (cris_unwind_sp): Delete.
8993         (cris_gdbarch_init): Don't register deleted functions with
8994         gdbarch.
8995
8996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8997
8998         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8999         (bfin_unwind_pc): Delete.
9000         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9001
9002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9005         (arm_unwind_pc): Delete.
9006         (arm_unwind_sp): Delete.
9007         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9008
9009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9010
9011         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9012         (arc_unwind_pc): Delete.
9013         (arc_unwind_sp): Delete.
9014         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9015
9016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9017
9018         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9019         (alpha_unwind_pc): Delete.
9020         (alpha_gdbarch_init): Don't register deleted functions with
9021         gdbarch.
9022
9023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9024
9025         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9026         (aarch64_unwind_pc): Delete.
9027         (aarch64_unwind_sp): Delete.
9028         (aarch64_gdbarch_init): Don't register deleted functions with
9029         gdbarch.
9030
9031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9032
9033         * gdbtypes.c (type_align): Don't consider static members when
9034         computing structure alignment.
9035
9036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9037
9038         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9039         return 0 for other types.
9040         * arch-utils.c (default_type_align): Always return 0.
9041         * gdbarch.h: Regenerate.
9042         * gdbarch.sh (type_align): Extend comment.
9043         * gdbtypes.c (type_align): Add additional comments, always call
9044         gdbarch_type_align before applying the default rules.
9045         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9046         generic code will then apply a suitable default.
9047         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9048         types, return 0 for other types.
9049
9050 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9051
9052         * NEWS: Create a new section for the next release branch.
9053         Rename the section of the current branch, now that it has
9054         been cut.
9055
9056 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9057
9058         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9059         * version.in: Bump version to 8.3.50.DATE-git.
9060
9061 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9062
9063         * aix-thread.c (ptid_cmp): Remove unused variable.
9064         (get_signaled_thread): Likewise.
9065         (store_regs_user_thread): Likewise.
9066         (store_regs_kernel_thread): Likewise.
9067         (fetch_regs_kernel_thread): Remove shadowed variable.
9068
9069 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9070
9071         * features/riscv/32bit-cpu.xml: Add register numbers.
9072         * features/riscv/32bit-fpu.c: Regenerate.
9073         * features/riscv/32bit-fpu.xml: Add register numbers.
9074         * features/riscv/64bit-cpu.xml: Add register numbers.
9075         * features/riscv/64bit-fpu.c: Regenerate.
9076         * features/riscv/64bit-fpu.xml: Add register numbers.
9077
9078 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9079
9080         * NEWS: Mention two argument form of gdb.Value constructor.
9081         * python/py-value.c (convert_buffer_and_type_to_value): New
9082         function.
9083         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9084         Add support for handling an optional second argument.  Call
9085         convert_buffer_and_type_to_value as appropriate.
9086         * python/python-internal.h (Py_buffer_deleter): New struct.
9087         (Py_buffer_up): New typedef.
9088
9089 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9090
9091         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9092         instead of releasing ownership.
9093
9094 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9095
9096         * dwarf2read.c (open_and_init_dwp_file): Call
9097         elf_numsections instead of bfd_count_sections to initialize
9098         dwp_file->num_sections.
9099
9100 2019-02-25  Tom Tromey  <tromey@adacore.com>
9101
9102         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9103
9104 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9105
9106         * gcore.in: Add '--readnever' option when invoking GDB.
9107
9108 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9109
9110         * MAINTAINERS: Update my email address.
9111
9112 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9113
9114         * build-id.c (build_id_to_debug_bfd_1): New function.
9115         (build_id_to_debug_bfd): Look for separate debug file in
9116         sysroot.
9117
9118 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9119
9120         * gdbarch.sh: Update the copyright year range that is placed into
9121         generated files.
9122
9123 2019-02-22  Keith Seitz  <keiths@redhat.com>
9124
9125         PR symtab/23853
9126         * linespec.c (create_sals_line_offset): Search for the default
9127         symtab's filename instead of its fullname.
9128
9129 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9130
9131         * NEWS: Update style defaults.
9132
9133 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9134
9135         * main.c (captured_main_1): Disable styling in batch mode.
9136
9137 2019-02-20  Tom Tromey  <tom@tromey.com>
9138
9139         * symtab.c (symtab_symbol_info): Fix typos.
9140
9141 2019-02-20  Tom Tromey  <tromey@adacore.com>
9142
9143         * findcmd.c (_initialize_mem_search): Use upper case for
9144         metasyntactic variables.
9145
9146 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9147
9148         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9149         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9150
9151 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9152
9153         * top.h (source_file_name): Change to std::string.
9154         * top.c (source_file_name): Likewise.
9155         (command_line_input): Adjust.
9156         * cli/cli-script.c (script_from_file): Adjust.
9157
9158 2019-02-19  Tom Tromey  <tromey@adacore.com>
9159
9160         * ravenscar-thread.c
9161         (ravenscar_thread_target::update_thread_list): Don't call
9162         ada_build_task_list.
9163         * ada-lang.h (ada_build_task_list): Don't declare.
9164         * ada-tasks.c (struct ada_tasks_inferior_data)
9165         <task_list_valid_p>: Now bool.
9166         (read_known_tasks, ada_task_list_changed)
9167         (ada_tasks_invalidate_inferior_data): Update.
9168         (read_known_tasks_array): Return bool.
9169         (read_known_tasks_list): Likewise.
9170         (read_known_tasks): Return void.
9171         (ada_build_task_list): Now static.
9172
9173 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9174
9175         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9176         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9177
9178 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9179
9180         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9181         variant for ada_tasks_pspace_data_handle and
9182         ada_tasks_inferior_data_handle.
9183         (ada_tasks_pspace_data_cleanup): New function.
9184         (ada_tasks_inferior_data_cleanup): New function.
9185
9186 2019-02-17  Tom Tromey  <tom@tromey.com>
9187
9188         * macrotab.h (macro_source_fullname): Return a std::string.
9189         * macrotab.c (macro_include, check_for_redefinition)
9190         (macro_undef, macro_lookup_definition, foreach_macro)
9191         (foreach_macro_in_scope): Update.
9192         (macro_source_fullname): Return a std::string.
9193         * macrocmd.c (show_pp_source_pos): Update.
9194
9195 2019-02-17  Tom Tromey  <tom@tromey.com>
9196
9197         * macrocmd.c (show_pp_source_pos): Style the file names.
9198
9199 2019-02-17  Tom Tromey  <tom@tromey.com>
9200
9201         PR tui/24197:
9202         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9203
9204 2019-02-17  Tom Tromey  <tom@tromey.com>
9205
9206         * ada-lang.c (user_select_syms): Use filtered printing.
9207         * utils.c (wrap_style): New global.
9208         (desired_style): Remove.
9209         (emit_style_escape): Add stream parameter.
9210         (set_output_style, reset_terminal_style, prompt_for_continue):
9211         Update.
9212         (flush_wrap_buffer): Only flush gdb_stdout.
9213         (wrap_here): Set wrap_style.
9214         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9215         treat escape sequences as a character.  Change when wrap buffer is
9216         flushed.
9217         (fputs_styled): Do not set the output style when the default is
9218         requested.
9219         * ui-style.h (struct ui_file_style) <is_default>: New method.
9220         * source.c (print_source_lines_base): Emit escape sequences in one
9221         piece.
9222
9223 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9224
9225         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9226         integers and enumeration types.
9227
9228 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9229
9230         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9231         instead of lookup_symbol_in_language
9232         (do_exact_match): New function.
9233         (ada_get_symbol_name_matcher): Return do_exact_match when
9234         doing a verbatim match.
9235
9236 2019-02-15  Tom Tromey  <tromey@adacore.com>
9237
9238         * ravenscar-thread.c (ravenscar_thread_target::resume)
9239         (ravenscar_thread_target::wait): Special case wildcard requests.
9240
9241 2019-02-15  Tom Tromey  <tromey@adacore.com>
9242
9243         * ravenscar-thread.c (base_ptid): Remove.
9244         (struct ravenscar_thread_target) <close>: New method.
9245         <m_base_ptid>: New member.
9246         <update_inferior_ptid, active_task, task_is_currently_active,
9247         runtime_initialized>: Declare methods.
9248         <ravenscar_thread_target>: Add constructor.
9249         (ravenscar_thread_target::task_is_currently_active)
9250         (ravenscar_thread_target::update_inferior_ptid)
9251         (ravenscar_runtime_initialized): Rename.  Now methods.
9252         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9253         (ravenscar_thread_target::update_thread_list): Update.
9254         (ravenscar_thread_target::active_task): Now method.
9255         (ravenscar_thread_target::store_registers)
9256         (ravenscar_thread_target::prepare_to_store)
9257         (ravenscar_thread_target::prepare_to_store)
9258         (ravenscar_thread_target::mourn_inferior): Update.
9259         (ravenscar_inferior_created): Use "new" to create target.
9260         (ravenscar_thread_target::get_ada_task_ptid): Update.
9261         (_initialize_ravenscar): Don't initialize base_ptid.
9262         (ravenscar_ops): Remove global.
9263
9264 2019-02-15  Tom Tromey  <tromey@adacore.com>
9265
9266         * target.h (push_target): Declare new overload.
9267         * target.c (push_target): New overload, taking an rvalue reference.
9268         * remote.c (remote_target::open_1): Use push_target overload.
9269         * corelow.c (core_target_open): Use push_target overload.
9270
9271 2019-02-15  Tom Tromey  <tromey@adacore.com>
9272
9273         * ravenscar-thread.c (is_ravenscar_task)
9274         (ravenscar_task_is_currently_active): Return bool.
9275         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9276         (_initialize_ravenscar): Remove "(void)".
9277         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9278         Return bool.
9279
9280 2019-02-15  Tom Tromey  <tromey@adacore.com>
9281
9282         * ravenscar-thread.c (ravenscar_runtime_initializer)
9283         (has_ravenscar_runtime, get_running_thread_id)
9284         (ravenscar_thread_target::resume): Fix indentation.
9285
9286 2019-02-15  Tom Tromey  <tromey@adacore.com>
9287
9288         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9289         from ravenscar_arch_ops.
9290         (sparc_ravenscar_ops::fetch_registers)
9291         (sparc_ravenscar_ops::store_registers): Now methods.
9292         (sparc_ravenscar_prepare_to_store): Remove.
9293         (sparc_ravenscar_ops): Redefine.
9294         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9295         methods and destructor.  Remove members.
9296         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9297         (ravenscar_thread_target::store_registers)
9298         (ravenscar_thread_target::prepare_to_store): Update.
9299         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9300         Remove.
9301         (struct ppc_ravenscar_powerpc_ops): Derive from
9302         ravenscar_arch_ops.
9303         (ppc_ravenscar_powerpc_ops::fetch_registers)
9304         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9305         (ppc_ravenscar_powerpc_ops): Redefine.
9306         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9307         (ppc_ravenscar_e500_ops::fetch_registers)
9308         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9309         (ppc_ravenscar_e500_ops): Redefine.
9310         * aarch64-ravenscar-thread.c
9311         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9312         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9313         (aarch64_ravenscar_fetch_registers)
9314         (aarch64_ravenscar_store_registers): Now methods.
9315         (aarch64_ravenscar_ops): Redefine.
9316
9317 2019-02-15  Tom Tromey  <tromey@adacore.com>
9318
9319         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9320         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9321         (ravenscar_thread_target::stopped_by_watchpoint)
9322         (ravenscar_thread_target::stopped_data_address)
9323         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9324
9325 2019-02-15  Tom Tromey  <tromey@adacore.com>
9326
9327         * ravenscar-thread.c: Fix some typos.
9328
9329 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9330             Tom Tromey  <tromey@adacore.com>
9331
9332         * ada-lang.c (ada_exception_sal): Change addr_string to a
9333         std::string.
9334         (create_ada_exception_catchpoint): Update.
9335
9336 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9337             Tom Tromey  <tromey@adacore.com>
9338
9339         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9340         (bp_location_ops): Remove.
9341         (base_breakpoint_allocate_location): Update.
9342         (free_bp_location): Update.
9343         * ada-lang.c (class ada_catchpoint_location)
9344         <ada_catchpoint_location>: Remove ops parameter.
9345         (ada_catchpoint_location_dtor): Remove.
9346         (ada_catchpoint_location_ops): Remove.
9347         (allocate_location_exception): Update.
9348         * breakpoint.h (struct bp_location_ops): Remove.
9349         (class bp_location) <bp_location>: Remove bp_location_ops
9350         parameter.
9351         <~bp_location>: Add destructor.
9352         <ops>: Remove.
9353
9354 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9355             Pedro Alves  <palves@redhat.com>
9356
9357         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9358         'PATH_MAX'.
9359
9360 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9361             Samuel Thibault  <samuel.thibault@gnu.org>
9362             Thomas Schwinge  <thomas@codesourcery.com>
9363
9364         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9365         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9366
9367 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9368
9369         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9370         (check_empty): Use "const char *".
9371
9372         * gnu-nat.c (gnu_nat_target::detach): Instead of
9373         'detach_inferior (pid)' call
9374         'detach_inferior (find_inferior_pid (pid))'.
9375
9376         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9377         'nat/fork-inferior.o'.
9378         * gnu-nat.c: #include "nat/fork-inferior.h".
9379
9380         * gnu-nat.c (gnu_nat_target::detach): Instead of
9381         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9382         * gnu-nat.h: #include "inf-child.h".
9383         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9384         'i386_gnu_nat_target::fetch_registers'.
9385         (gnu_store_registers): Rename/move to
9386         'i386_gnu_nat_target::store_registers'.
9387
9388         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9389         * gnu-nat.h (mach_thread_info): New function.
9390         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9391
9392         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9393
9394 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9395
9396         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9397
9398 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9399
9400         * windows-nat.c (windows_add_thread): Add new parameter
9401         "main_thread_p" with default value set to false.  Update
9402         function documentation as well as all callers.
9403         (windows_delete_thread): Likewise.
9404         (fake_create_process): Update call to windows_add_thread.
9405         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9406         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9407         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9408         call to windows_delete_thread.
9409
9410 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9411
9412         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9413
9414 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9415
9416         * symfile.c (find_separate_debug_file): Use canonical path of
9417         sysroot with child_path instead of gdb_sysroot if it is valid.
9418
9419 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9420
9421         * symfile.c (find_separate_debug_file): Use child_path to
9422         determine if an object file is under a sysroot.
9423
9424 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9425
9426         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9427         unittests/child-path-selftests.c.
9428         * common/pathstuff.c (child_path): New function.
9429         * common/pathstuff.h (child_path): New prototype.
9430         * unittests/child-path-selftests.c: New file.
9431
9432 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9433
9434         * symfile.c (find_separate_debug_file): Look for separate debug
9435         files in debug directories under the sysroot.
9436
9437 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9438
9439         * symtab.h (struct minimal_symbol data_p): New const method.
9440         (struct minimal_symbol text_p): Likewise.
9441         * symtab.c (output_source_filename): Use file name style
9442         to print file name.
9443         (print_symbol_info): Likewise.
9444         (print_msymbol_info): Use address style to print addresses.
9445         Use function name style to print executable text symbols.
9446         (expand_symtab_containing_pc): Use data_p.
9447         (find_pc_sect_compunit_symtab): Likewise.
9448
9449 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9450
9451         * breakpoint.c (describe_other_breakpoints): Use address style
9452         to print addresses.
9453         (say_where): Likewise.
9454
9455 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9456
9457         * ada-typeprint.c (print_func_type): Print function name
9458         style to print function name.
9459         * c-typeprint.c (c_print_type_1): Likewise.
9460
9461 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9462
9463         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9464         for execve.
9465
9466 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9467
9468         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9469         type_stack.
9470
9471 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9472
9473         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9474         TYPE_CODE_REF types.
9475
9476 2019-02-08  Jim Wilson  <jimw@sifive.com>
9477
9478         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9479         (riscv_linux_fregset): New.
9480         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9481
9482 2019-02-07  Tom Tromey  <tom@tromey.com>
9483
9484         * thread.c (thread_cancel_execution_command): Update.
9485         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9486         methods.
9487         (struct thread_fsm_ops): Remove.
9488         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9489         (thread_fsm_should_stop, thread_fsm_return_value)
9490         (thread_fsm_set_finished, thread_fsm_finished_p)
9491         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9492         Don't declare.
9493         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9494         * infrun.c (clear_proceed_status_thread)
9495         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9496         (print_stop_event): Update.
9497         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9498         Add constructor.
9499         (step_command_fsm_ops): Remove.
9500         (new_step_command_fsm): Remove.
9501         (step_1): Update.
9502         (step_command_fsm::should_stop): Rename from
9503         step_command_fsm_should_stop.
9504         (step_command_fsm::clean_up): Rename from
9505         step_command_fsm_clean_up.
9506         (step_command_fsm::do_async_reply_reason): Rename from
9507         step_command_fsm_async_reply_reason.
9508         (struct until_next_fsm): Inherit from thread_fsm.  Add
9509         constructor.
9510         (until_next_fsm_ops): Remove.
9511         (new_until_next_fsm): Remove.
9512         (until_next_fsm::should_stop): Rename from
9513         until_next_fsm_should_stop.
9514         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9515         (until_next_fsm::do_async_reply_reason): Rename from
9516         until_next_fsm_async_reply_reason.
9517         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9518         constructor.  Change type of breakpoint.
9519         (finish_command_fsm_ops): Remove.
9520         (new_finish_command_fsm): Remove.
9521         (finish_command_fsm::should_stop): Rename from
9522         finish_command_fsm_should_stop.
9523         (finish_command_fsm::clean_up): Rename from
9524         finish_command_fsm_clean_up.
9525         (finish_command_fsm::return_value): Rename from
9526         finish_command_fsm_return_value.
9527         (finish_command_fsm::do_async_reply_reason): Rename from
9528         finish_command_fsm_async_reply_reason.
9529         (finish_command): Update.
9530         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9531         Add constructor.
9532         (call_thread_fsm_ops): Remove.
9533         (call_thread_fsm::call_thread_fsm): Rename from
9534         new_call_thread_fsm.
9535         (call_thread_fsm::should_stop): Rename from
9536         call_thread_fsm_should_stop.
9537         (call_thread_fsm::should_notify_stop): Rename from
9538         call_thread_fsm_should_notify_stop.
9539         (run_inferior_call, call_function_by_hand_dummy): Update.
9540         * cli/cli-interp.c (should_print_stop_to_console): Update.
9541         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9542         Add constructor.  Change type of location_breakpoint,
9543         caller_breakpoint.
9544         (until_break_fsm_ops): Remove.
9545         (new_until_break_fsm): Remove.
9546         (until_break_fsm::should_stop): Rename from
9547         until_break_fsm_should_stop.
9548         (until_break_fsm::clean_up): Rename from
9549         until_break_fsm_clean_up.
9550         (until_break_fsm::do_async_reply_reason): Rename from
9551         until_break_fsm_async_reply_reason.
9552         (until_break_command): Update.
9553         * thread-fsm.c: Remove.
9554         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9555
9556 2019-02-07  Tom Tromey  <tom@tromey.com>
9557
9558         * yy-remap.h: Add include guard.
9559         * xtensa-tdep.h: Add include guard.
9560         * xcoffread.h: Rename include guard.
9561         * varobj-iter.h: Add include guard.
9562         * tui/tui.h: Rename include guard.
9563         * tui/tui-winsource.h: Rename include guard.
9564         * tui/tui-wingeneral.h: Rename include guard.
9565         * tui/tui-windata.h: Rename include guard.
9566         * tui/tui-win.h: Rename include guard.
9567         * tui/tui-stack.h: Rename include guard.
9568         * tui/tui-source.h: Rename include guard.
9569         * tui/tui-regs.h: Rename include guard.
9570         * tui/tui-out.h: Rename include guard.
9571         * tui/tui-layout.h: Rename include guard.
9572         * tui/tui-io.h: Rename include guard.
9573         * tui/tui-hooks.h: Rename include guard.
9574         * tui/tui-file.h: Rename include guard.
9575         * tui/tui-disasm.h: Rename include guard.
9576         * tui/tui-data.h: Rename include guard.
9577         * tui/tui-command.h: Rename include guard.
9578         * tic6x-tdep.h: Add include guard.
9579         * target/waitstatus.h: Rename include guard.
9580         * target/wait.h: Rename include guard.
9581         * target/target.h: Rename include guard.
9582         * target/resume.h: Rename include guard.
9583         * target-float.h: Rename include guard.
9584         * stabsread.h: Add include guard.
9585         * rs6000-tdep.h: Add include guard.
9586         * riscv-fbsd-tdep.h: Add include guard.
9587         * regformats/regdef.h: Rename include guard.
9588         * record.h: Rename include guard.
9589         * python/python.h: Rename include guard.
9590         * python/python-internal.h: Rename include guard.
9591         * python/py-stopevent.h: Rename include guard.
9592         * python/py-ref.h: Rename include guard.
9593         * python/py-record.h: Rename include guard.
9594         * python/py-record-full.h: Rename include guard.
9595         * python/py-record-btrace.h: Rename include guard.
9596         * python/py-instruction.h: Rename include guard.
9597         * python/py-events.h: Rename include guard.
9598         * python/py-event.h: Rename include guard.
9599         * procfs.h: Add include guard.
9600         * proc-utils.h: Add include guard.
9601         * p-lang.h: Add include guard.
9602         * or1k-tdep.h: Rename include guard.
9603         * observable.h: Rename include guard.
9604         * nto-tdep.h: Rename include guard.
9605         * nat/x86-linux.h: Rename include guard.
9606         * nat/x86-linux-dregs.h: Rename include guard.
9607         * nat/x86-gcc-cpuid.h: Add include guard.
9608         * nat/x86-dregs.h: Rename include guard.
9609         * nat/x86-cpuid.h: Rename include guard.
9610         * nat/ppc-linux.h: Rename include guard.
9611         * nat/mips-linux-watch.h: Rename include guard.
9612         * nat/linux-waitpid.h: Rename include guard.
9613         * nat/linux-ptrace.h: Rename include guard.
9614         * nat/linux-procfs.h: Rename include guard.
9615         * nat/linux-osdata.h: Rename include guard.
9616         * nat/linux-nat.h: Rename include guard.
9617         * nat/linux-namespaces.h: Rename include guard.
9618         * nat/linux-btrace.h: Rename include guard.
9619         * nat/glibc_thread_db.h: Rename include guard.
9620         * nat/gdb_thread_db.h: Rename include guard.
9621         * nat/gdb_ptrace.h: Rename include guard.
9622         * nat/fork-inferior.h: Rename include guard.
9623         * nat/amd64-linux-siginfo.h: Rename include guard.
9624         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9625         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9626         * nat/aarch64-linux.h: Rename include guard.
9627         * nat/aarch64-linux-hw-point.h: Rename include guard.
9628         * mn10300-tdep.h: Add include guard.
9629         * mips-linux-tdep.h: Add include guard.
9630         * mi/mi-parse.h: Rename include guard.
9631         * mi/mi-out.h: Rename include guard.
9632         * mi/mi-main.h: Rename include guard.
9633         * mi/mi-interp.h: Rename include guard.
9634         * mi/mi-getopt.h: Rename include guard.
9635         * mi/mi-console.h: Rename include guard.
9636         * mi/mi-common.h: Rename include guard.
9637         * mi/mi-cmds.h: Rename include guard.
9638         * mi/mi-cmd-break.h: Rename include guard.
9639         * m2-lang.h: Add include guard.
9640         * location.h: Rename include guard.
9641         * linux-record.h: Rename include guard.
9642         * linux-nat.h: Add include guard.
9643         * linux-fork.h: Add include guard.
9644         * i386-darwin-tdep.h: Rename include guard.
9645         * hppa-linux-offsets.h: Add include guard.
9646         * guile/guile.h: Rename include guard.
9647         * guile/guile-internal.h: Rename include guard.
9648         * gnu-nat.h: Rename include guard.
9649         * gdb-stabs.h: Rename include guard.
9650         * frv-tdep.h: Add include guard.
9651         * f-lang.h: Add include guard.
9652         * event-loop.h: Add include guard.
9653         * darwin-nat.h: Rename include guard.
9654         * cp-abi.h: Rename include guard.
9655         * config/sparc/nm-sol2.h: Rename include guard.
9656         * config/nm-nto.h: Rename include guard.
9657         * config/nm-linux.h: Add include guard.
9658         * config/i386/nm-i386gnu.h: Rename include guard.
9659         * config/djgpp/nl_types.h: Rename include guard.
9660         * config/djgpp/langinfo.h: Rename include guard.
9661         * compile/gcc-cp-plugin.h: Add include guard.
9662         * compile/gcc-c-plugin.h: Add include guard.
9663         * compile/compile.h: Rename include guard.
9664         * compile/compile-object-run.h: Rename include guard.
9665         * compile/compile-object-load.h: Rename include guard.
9666         * compile/compile-internal.h: Rename include guard.
9667         * compile/compile-cplus.h: Rename include guard.
9668         * compile/compile-c.h: Rename include guard.
9669         * common/xml-utils.h: Rename include guard.
9670         * common/x86-xstate.h: Rename include guard.
9671         * common/version.h: Rename include guard.
9672         * common/vec.h: Rename include guard.
9673         * common/tdesc.h: Rename include guard.
9674         * common/selftest.h: Rename include guard.
9675         * common/scoped_restore.h: Rename include guard.
9676         * common/scoped_mmap.h: Rename include guard.
9677         * common/scoped_fd.h: Rename include guard.
9678         * common/safe-iterator.h: Rename include guard.
9679         * common/run-time-clock.h: Rename include guard.
9680         * common/refcounted-object.h: Rename include guard.
9681         * common/queue.h: Rename include guard.
9682         * common/ptid.h: Rename include guard.
9683         * common/print-utils.h: Rename include guard.
9684         * common/preprocessor.h: Rename include guard.
9685         * common/pathstuff.h: Rename include guard.
9686         * common/observable.h: Rename include guard.
9687         * common/netstuff.h: Rename include guard.
9688         * common/job-control.h: Rename include guard.
9689         * common/host-defs.h: Rename include guard.
9690         * common/gdb_wait.h: Rename include guard.
9691         * common/gdb_vecs.h: Rename include guard.
9692         * common/gdb_unlinker.h: Rename include guard.
9693         * common/gdb_unique_ptr.h: Rename include guard.
9694         * common/gdb_tilde_expand.h: Rename include guard.
9695         * common/gdb_sys_time.h: Rename include guard.
9696         * common/gdb_string_view.h: Rename include guard.
9697         * common/gdb_splay_tree.h: Rename include guard.
9698         * common/gdb_setjmp.h: Rename include guard.
9699         * common/gdb_ref_ptr.h: Rename include guard.
9700         * common/gdb_optional.h: Rename include guard.
9701         * common/gdb_locale.h: Rename include guard.
9702         * common/gdb_assert.h: Rename include guard.
9703         * common/filtered-iterator.h: Rename include guard.
9704         * common/filestuff.h: Rename include guard.
9705         * common/fileio.h: Rename include guard.
9706         * common/environ.h: Rename include guard.
9707         * common/common-utils.h: Rename include guard.
9708         * common/common-types.h: Rename include guard.
9709         * common/common-regcache.h: Rename include guard.
9710         * common/common-inferior.h: Rename include guard.
9711         * common/common-gdbthread.h: Rename include guard.
9712         * common/common-exceptions.h: Rename include guard.
9713         * common/common-defs.h: Rename include guard.
9714         * common/common-debug.h: Rename include guard.
9715         * common/cleanups.h: Rename include guard.
9716         * common/buffer.h: Rename include guard.
9717         * common/btrace-common.h: Rename include guard.
9718         * common/break-common.h: Rename include guard.
9719         * cli/cli-utils.h: Rename include guard.
9720         * cli/cli-style.h: Rename include guard.
9721         * cli/cli-setshow.h: Rename include guard.
9722         * cli/cli-script.h: Rename include guard.
9723         * cli/cli-interp.h: Rename include guard.
9724         * cli/cli-decode.h: Rename include guard.
9725         * cli/cli-cmds.h: Rename include guard.
9726         * charset-list.h: Add include guard.
9727         * buildsym-legacy.h: Rename include guard.
9728         * bfin-tdep.h: Add include guard.
9729         * ax.h: Rename include guard.
9730         * arm-linux-tdep.h: Add include guard.
9731         * arm-fbsd-tdep.h: Add include guard.
9732         * arch/xtensa.h: Rename include guard.
9733         * arch/tic6x.h: Add include guard.
9734         * arch/i386.h: Add include guard.
9735         * arch/arm.h: Rename include guard.
9736         * arch/arm-linux.h: Rename include guard.
9737         * arch/arm-get-next-pcs.h: Rename include guard.
9738         * arch/amd64.h: Add include guard.
9739         * arch/aarch64-insn.h: Rename include guard.
9740         * arch-utils.h: Rename include guard.
9741         * annotate.h: Add include guard.
9742         * amd64-darwin-tdep.h: Rename include guard.
9743         * aarch64-linux-tdep.h: Add include guard.
9744         * aarch64-fbsd-tdep.h: Add include guard.
9745         * aarch32-linux-nat.h: Add include guard.
9746
9747 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9748
9749         * macrotab.c (macro_define_internal): New function that
9750         factorizes macro_define_object_internal and macro_define_function
9751         code.
9752         (macro_define_object_internal): Use macro_define_internal.
9753         (macro_define_function): Likewise.
9754
9755 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9756
9757         * macrocmd.c (extract_identifier): Return
9758         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9759         callers.
9760
9761 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9762
9763         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9764
9765 2019-02-05  Tom Tromey  <tom@tromey.com>
9766
9767         * target.c (target_stack::unpush): Move assertion earlier.
9768
9769 2019-01-30  Tom Tromey  <tom@tromey.com>
9770
9771         PR python/23615:
9772         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9773         (gdbpy_parse_and_eval): Likewise.
9774         * python/python-internal.h (gdbpy_allow_threads): New class.
9775
9776 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9777
9778         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9779         (aarch64_fbsd_fpregmap): Move earlier.
9780         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9781         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9782         instead of individual calls to trad_frame_set_reg_addr.
9783         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9784         earlier.
9785         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9786         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9787         instead of individual calls to trad_frame_set_reg_addr.
9788
9789 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9790
9791         * CONTRIBUTE: Replace contribution list with wiki link.
9792
9793 2019-01-25  Tom Tromey  <tom@tromey.com>
9794
9795         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9796
9797 2019-01-25  Tom Tromey  <tom@tromey.com>
9798
9799         * xtensa-linux-nat.c: Fix common/ includes.
9800         * xml-support.h: Fix common/ includes.
9801         * xml-support.c: Fix common/ includes.
9802         * x86-linux-nat.c: Fix common/ includes.
9803         * windows-nat.c: Fix common/ includes.
9804         * varobj.h: Fix common/ includes.
9805         * varobj.c: Fix common/ includes.
9806         * value.c: Fix common/ includes.
9807         * valops.c: Fix common/ includes.
9808         * utils.c: Fix common/ includes.
9809         * unittests/xml-utils-selftests.c: Fix common/ includes.
9810         * unittests/utils-selftests.c: Fix common/ includes.
9811         * unittests/unpack-selftests.c: Fix common/ includes.
9812         * unittests/tracepoint-selftests.c: Fix common/ includes.
9813         * unittests/style-selftests.c: Fix common/ includes.
9814         * unittests/string_view-selftests.c: Fix common/ includes.
9815         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9816         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9817         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9818         * unittests/rsp-low-selftests.c: Fix common/ includes.
9819         * unittests/parse-connection-spec-selftests.c: Fix common/
9820         includes.
9821         * unittests/optional-selftests.c: Fix common/ includes.
9822         * unittests/offset-type-selftests.c: Fix common/ includes.
9823         * unittests/observable-selftests.c: Fix common/ includes.
9824         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9825         * unittests/memrange-selftests.c: Fix common/ includes.
9826         * unittests/memory-map-selftests.c: Fix common/ includes.
9827         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9828         * unittests/function-view-selftests.c: Fix common/ includes.
9829         * unittests/environ-selftests.c: Fix common/ includes.
9830         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9831         * unittests/common-utils-selftests.c: Fix common/ includes.
9832         * unittests/cli-utils-selftests.c: Fix common/ includes.
9833         * unittests/array-view-selftests.c: Fix common/ includes.
9834         * ui-file.c: Fix common/ includes.
9835         * tui/tui-io.c: Fix common/ includes.
9836         * tracepoint.h: Fix common/ includes.
9837         * tracepoint.c: Fix common/ includes.
9838         * tracefile-tfile.c: Fix common/ includes.
9839         * top.h: Fix common/ includes.
9840         * top.c: Fix common/ includes.
9841         * thread.c: Fix common/ includes.
9842         * target/waitstatus.h: Fix common/ includes.
9843         * target/waitstatus.c: Fix common/ includes.
9844         * target.h: Fix common/ includes.
9845         * target.c: Fix common/ includes.
9846         * target-memory.c: Fix common/ includes.
9847         * target-descriptions.c: Fix common/ includes.
9848         * symtab.h: Fix common/ includes.
9849         * symfile.c: Fix common/ includes.
9850         * stap-probe.c: Fix common/ includes.
9851         * spu-linux-nat.c: Fix common/ includes.
9852         * sparc-nat.c: Fix common/ includes.
9853         * source.c: Fix common/ includes.
9854         * solib.c: Fix common/ includes.
9855         * solib-target.c: Fix common/ includes.
9856         * ser-unix.c: Fix common/ includes.
9857         * ser-tcp.c: Fix common/ includes.
9858         * ser-pipe.c: Fix common/ includes.
9859         * ser-base.c: Fix common/ includes.
9860         * selftest-arch.c: Fix common/ includes.
9861         * s12z-tdep.c: Fix common/ includes.
9862         * rust-exp.y: Fix common/ includes.
9863         * rs6000-aix-tdep.c: Fix common/ includes.
9864         * riscv-tdep.c: Fix common/ includes.
9865         * remote.c: Fix common/ includes.
9866         * remote-notif.h: Fix common/ includes.
9867         * remote-fileio.h: Fix common/ includes.
9868         * remote-fileio.c: Fix common/ includes.
9869         * regcache.h: Fix common/ includes.
9870         * regcache.c: Fix common/ includes.
9871         * record-btrace.c: Fix common/ includes.
9872         * python/python.c: Fix common/ includes.
9873         * python/py-type.c: Fix common/ includes.
9874         * python/py-inferior.c: Fix common/ includes.
9875         * progspace.h: Fix common/ includes.
9876         * producer.c: Fix common/ includes.
9877         * procfs.c: Fix common/ includes.
9878         * proc-api.c: Fix common/ includes.
9879         * printcmd.c: Fix common/ includes.
9880         * ppc-linux-nat.c: Fix common/ includes.
9881         * parser-defs.h: Fix common/ includes.
9882         * osdata.c: Fix common/ includes.
9883         * obsd-nat.c: Fix common/ includes.
9884         * nat/x86-linux.c: Fix common/ includes.
9885         * nat/x86-linux-dregs.c: Fix common/ includes.
9886         * nat/x86-dregs.h: Fix common/ includes.
9887         * nat/x86-dregs.c: Fix common/ includes.
9888         * nat/ppc-linux.c: Fix common/ includes.
9889         * nat/mips-linux-watch.h: Fix common/ includes.
9890         * nat/mips-linux-watch.c: Fix common/ includes.
9891         * nat/linux-waitpid.c: Fix common/ includes.
9892         * nat/linux-ptrace.h: Fix common/ includes.
9893         * nat/linux-ptrace.c: Fix common/ includes.
9894         * nat/linux-procfs.c: Fix common/ includes.
9895         * nat/linux-personality.c: Fix common/ includes.
9896         * nat/linux-osdata.c: Fix common/ includes.
9897         * nat/linux-namespaces.c: Fix common/ includes.
9898         * nat/linux-btrace.h: Fix common/ includes.
9899         * nat/linux-btrace.c: Fix common/ includes.
9900         * nat/fork-inferior.c: Fix common/ includes.
9901         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9902         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9903         * nat/aarch64-linux.c: Fix common/ includes.
9904         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9905         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9906         * namespace.h: Fix common/ includes.
9907         * mips-linux-tdep.c: Fix common/ includes.
9908         * minsyms.c: Fix common/ includes.
9909         * mi/mi-parse.h: Fix common/ includes.
9910         * mi/mi-main.c: Fix common/ includes.
9911         * mi/mi-cmd-env.c: Fix common/ includes.
9912         * memrange.h: Fix common/ includes.
9913         * memattr.c: Fix common/ includes.
9914         * maint.h: Fix common/ includes.
9915         * maint.c: Fix common/ includes.
9916         * main.c: Fix common/ includes.
9917         * machoread.c: Fix common/ includes.
9918         * location.c: Fix common/ includes.
9919         * linux-thread-db.c: Fix common/ includes.
9920         * linux-nat.c: Fix common/ includes.
9921         * linux-fork.c: Fix common/ includes.
9922         * inline-frame.c: Fix common/ includes.
9923         * infrun.c: Fix common/ includes.
9924         * inflow.c: Fix common/ includes.
9925         * inferior.h: Fix common/ includes.
9926         * inferior.c: Fix common/ includes.
9927         * infcmd.c: Fix common/ includes.
9928         * inf-ptrace.c: Fix common/ includes.
9929         * inf-child.c: Fix common/ includes.
9930         * ia64-linux-nat.c: Fix common/ includes.
9931         * i387-tdep.c: Fix common/ includes.
9932         * i386-tdep.c: Fix common/ includes.
9933         * i386-linux-tdep.c: Fix common/ includes.
9934         * i386-linux-nat.c: Fix common/ includes.
9935         * i386-go32-tdep.c: Fix common/ includes.
9936         * i386-fbsd-tdep.c: Fix common/ includes.
9937         * i386-fbsd-nat.c: Fix common/ includes.
9938         * guile/scm-type.c: Fix common/ includes.
9939         * guile/guile.c: Fix common/ includes.
9940         * go32-nat.c: Fix common/ includes.
9941         * gnu-nat.c: Fix common/ includes.
9942         * gdbthread.h: Fix common/ includes.
9943         * gdbarch-selftests.c: Fix common/ includes.
9944         * gdb_usleep.c: Fix common/ includes.
9945         * gdb_select.h: Fix common/ includes.
9946         * gdb_bfd.c: Fix common/ includes.
9947         * gcore.c: Fix common/ includes.
9948         * fork-child.c: Fix common/ includes.
9949         * findvar.c: Fix common/ includes.
9950         * fbsd-nat.c: Fix common/ includes.
9951         * event-top.c: Fix common/ includes.
9952         * event-loop.c: Fix common/ includes.
9953         * dwarf2read.c: Fix common/ includes.
9954         * dwarf2loc.c: Fix common/ includes.
9955         * dwarf2-frame.c: Fix common/ includes.
9956         * dwarf-index-cache.c: Fix common/ includes.
9957         * dtrace-probe.c: Fix common/ includes.
9958         * disasm-selftests.c: Fix common/ includes.
9959         * defs.h: Fix common/ includes.
9960         * csky-tdep.c: Fix common/ includes.
9961         * cp-valprint.c: Fix common/ includes.
9962         * cp-support.h: Fix common/ includes.
9963         * cp-support.c: Fix common/ includes.
9964         * corelow.c: Fix common/ includes.
9965         * completer.h: Fix common/ includes.
9966         * completer.c: Fix common/ includes.
9967         * compile/compile.c: Fix common/ includes.
9968         * compile/compile-loc2c.c: Fix common/ includes.
9969         * compile/compile-cplus-types.c: Fix common/ includes.
9970         * compile/compile-cplus-symbols.c: Fix common/ includes.
9971         * command.h: Fix common/ includes.
9972         * cli/cli-dump.c: Fix common/ includes.
9973         * cli/cli-cmds.c: Fix common/ includes.
9974         * charset.c: Fix common/ includes.
9975         * build-id.c: Fix common/ includes.
9976         * btrace.h: Fix common/ includes.
9977         * btrace.c: Fix common/ includes.
9978         * breakpoint.h: Fix common/ includes.
9979         * breakpoint.c: Fix common/ includes.
9980         * ax.h:
9981         (enum agent_op): Fix common/ includes.
9982         * ax-general.c (struct aop_map): Fix common/ includes.
9983         * ax-gdb.c: Fix common/ includes.
9984         * auxv.c: Fix common/ includes.
9985         * auto-load.c: Fix common/ includes.
9986         * arm-tdep.c: Fix common/ includes.
9987         * arch/riscv.c: Fix common/ includes.
9988         * arch/ppc-linux-common.c: Fix common/ includes.
9989         * arch/i386.c: Fix common/ includes.
9990         * arch/arm.c: Fix common/ includes.
9991         * arch/arm-linux.c: Fix common/ includes.
9992         * arch/arm-get-next-pcs.c: Fix common/ includes.
9993         * arch/amd64.c: Fix common/ includes.
9994         * arch/aarch64.c: Fix common/ includes.
9995         * arch/aarch64-insn.c: Fix common/ includes.
9996         * arch-utils.c: Fix common/ includes.
9997         * amd64-windows-tdep.c: Fix common/ includes.
9998         * amd64-tdep.c: Fix common/ includes.
9999         * amd64-sol2-tdep.c: Fix common/ includes.
10000         * amd64-obsd-tdep.c: Fix common/ includes.
10001         * amd64-nbsd-tdep.c: Fix common/ includes.
10002         * amd64-linux-tdep.c: Fix common/ includes.
10003         * amd64-linux-nat.c: Fix common/ includes.
10004         * amd64-fbsd-tdep.c: Fix common/ includes.
10005         * amd64-fbsd-nat.c: Fix common/ includes.
10006         * amd64-dicos-tdep.c: Fix common/ includes.
10007         * amd64-darwin-tdep.c: Fix common/ includes.
10008         * agent.c: Fix common/ includes.
10009         * ada-lang.h: Fix common/ includes.
10010         * ada-lang.c: Fix common/ includes.
10011         * aarch64-tdep.c: Fix common/ includes.
10012
10013 2019-01-25  Tom Tromey  <tom@tromey.com>
10014
10015         * common/create-version.sh: Use common/version.h.
10016
10017 2019-01-24  Pedro Alves  <palves@redhat.com>
10018
10019         * infrun.c (signal_stop, signal_print, signal_program)
10020         (signal_catch, signal_pass): Now arrays instead of pointers.
10021         (update_signals_program_target, do_target_resume)
10022         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10023         * linux-nat.c (linux_nat_target::pass_signals)
10024         (linux_nat_target::create_inferior, linux_nat_target::attach):
10025         Adjust.
10026         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10027         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10028         * procfs.c (procfs_target::pass_signals): Adjust.
10029         * record-full.c (record_full_target::resume): Adjust.
10030         * remote.c (remote_target::pass_signals)
10031         (remote_target::program_signals): Adjust.
10032         * target-debug.h (target_debug_print_signals): Now takes a
10033         gdb::array_view as parameter.  Adjust.
10034         * target.h (target_ops) <pass_signals, program_signals>: Replace
10035         pointer and length parameters with gdb::array_view.
10036         (target_pass_signals, target_program_signals): Likewise.
10037         * target-delegates.c: Regenerate.
10038
10039 2019-01-24  Pedro Alves  <palves@redhat.com>
10040
10041         * common/forward-scope-exit.h
10042         (forward_scope_exit::forward_scope_exit): Pass arguments to
10043         m_bind_function directly, instead of creating a std::bind and
10044         copying that.
10045
10046 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10047
10048         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10049         for static members.
10050         (pass_in_v_vfp_candidate): Likewise.
10051
10052 2019-01-23  Tom Tromey  <tom@tromey.com>
10053             Pedro Alves  <palves@redhat.com>
10054
10055         * regcache.c (class regcache_invalidator): Remove.
10056         (regcache::raw_write): Use make_scope_exit.
10057
10058 2019-01-23  Tom Tromey  <tom@tromey.com>
10059
10060         * ui-out.h (class ui_out_emit_type): Update comment.
10061
10062 2019-01-23  Tom Tromey  <tom@tromey.com>
10063
10064         * infrun.c (fetch_inferior_event): Update comment.
10065
10066 2019-01-23  Tom Tromey  <tom@tromey.com>
10067             Pedro Alves  <palves@redhat.com>
10068
10069         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10070         parameter.
10071         (fetch_inferior_event): Use SCOPE_EXIT.
10072
10073
10074 2019-01-23  Tom Tromey  <tom@tromey.com>
10075             Pedro Alves  <palves@redhat.com>
10076
10077         * infrun.c (disable_thread_events): Delete.
10078         (stop_all_threads): Use SCOPE_EXIT.
10079
10080 2019-01-23  Tom Tromey  <tom@tromey.com>
10081             Pedro Alves  <palves@redhat.com>
10082
10083         * symfile.c: Include forward-scope-exit.h.
10084         (clear_symtab_users_cleanup): Replace forward declaration with
10085         a FORWARD_SCOPE_EXIT.
10086         (syms_from_objfile_1): Use the forward_scope_exit and
10087         gdb::optional instead of cleanup_function.
10088         (reread_symbols): Use the forward_scope_exit instead of
10089         cleanup_function.
10090         (clear_symtab_users_cleanup): Remove function.
10091
10092 2019-01-23  Tom Tromey  <tom@tromey.com>
10093             Pedro Alves  <palves@redhat.com>
10094
10095         * linux-nat.c: Include scope-exit.h.
10096         (cleanup_target_stop): Remove.
10097         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10098         SCOPE_EXIT.
10099
10100 2019-01-23  Tom Tromey  <tom@tromey.com>
10101             Pedro Alves  <palves@redhat.com>
10102
10103         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10104         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10105
10106 2019-01-23  Tom Tromey  <tom@tromey.com>
10107             Andrew Burgess  <andrew.burgess@embecosm.com>
10108             Pedro Alves  <palves@redhat.com>
10109
10110         * infrun.c (fetch_inferior_event): Use scope_exit.
10111         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10112         * top.c (execute_command): Use scope_exit.
10113         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10114         * utils.c (do_bpstat_clear_actions_cleanup)
10115         (make_bpstat_clear_actions_cleanup): Remove.
10116
10117 2019-01-23  Tom Tromey  <tom@tromey.com>
10118             Pedro Alves  <palves@redhat.com>
10119
10120         * infrun.c: Include "common/scope-exit.h"
10121         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10122         (wait_for_inferior): Use SCOPE_EXIT.
10123         (fetch_inferior_event): Use scope_exit.
10124
10125 2019-01-23  Tom Tromey  <tom@tromey.com>
10126             Pedro Alves  <palves@redhat.com>
10127
10128         * breakpoint.c (create_breakpoint): Remove cleanup.
10129
10130 2019-01-23  Tom Tromey  <tom@tromey.com>
10131             Andrew Burgess  <andrew.burgess@embecosm.com>
10132             Pedro Alves  <palves@redhat.com>
10133
10134 2019-01-23  Pedro Alves  <palves@redhat.com>
10135
10136         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10137
10138 2019-01-23  Pedro Alves  <palves@redhat.com>
10139             Andrew Burgess  <andrew.burgess@embecosm.com>
10140
10141         * gdbthread.h: Include "common/forward-scope-exit.h".
10142         (scoped_finish_thread_state): Redefine custom class in terms of
10143         forward_scope_exit.
10144
10145 2019-01-23  Pedro Alves  <palves@redhat.com>
10146             Andrew Burgess  <andrew.burgess@embecosm.com>
10147
10148         * common/forward-scope-exit.h: New file.
10149
10150 2019-01-23  Pedro Alves  <palves@redhat.com>
10151             Andrew Burgess  <andrew.burgess@embecosm.com>
10152             Tom Tromey  <tom@tromey.com>
10153
10154         * common/scope-exit.h: New file.
10155
10156 2019-01-23  Pedro Alves  <palves@redhat.com>
10157
10158         * common/preprocessor.h (ESC): Rename to ...
10159         (ESC_PARENS): ... this.
10160         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10161         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10162
10163 2019-01-23  Tom Tromey  <tom@tromey.com>
10164
10165         * language.h (class scoped_switch_to_sym_language_if_auto):
10166         Initialize m_lang in both cases.
10167
10168 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10169
10170         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10171         with XCNEW.
10172
10173 2019-01-22  Tom Tromey  <tom@tromey.com>
10174
10175         * corelow.c: Do not include sys/file.h.
10176
10177 2019-01-22  Tom Tromey  <tom@tromey.com>
10178
10179         * tui/tui-wingeneral.h: Include gdb_curses.h.
10180
10181 2019-01-22  Tom Tromey  <tom@tromey.com>
10182
10183         * source-cache.h (class source_cache) <get_source_lines,
10184         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10185
10186 2019-01-22  Tom Tromey  <tom@tromey.com>
10187
10188         * remote-fileio.h (struct remote_target): Declare.
10189
10190 2019-01-22  Tom Tromey  <tom@tromey.com>
10191
10192         * python/py-arch.c: Do not include py-ref.h.
10193         * python/py-bpevent.c: Do not include py-ref.h.
10194         * python/py-cmd.c: Do not include py-ref.h.
10195         * python/py-continueevent.c: Do not include py-ref.h.
10196         * python/py-event.h: Do not include py-ref.h.
10197         * python/py-evtregistry.c: Do not include py-ref.h.
10198         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10199         * python/py-frame.c: Do not include py-ref.h.
10200         * python/py-framefilter.c: Do not include py-ref.h.
10201         * python/py-function.c: Do not include py-ref.h.
10202         * python/py-infevents.c: Do not include py-ref.h.
10203         * python/py-linetable.c: Do not include py-ref.h.
10204         * python/py-objfile.c: Do not include py-ref.h.
10205         * python/py-param.c: Do not include py-ref.h.
10206         * python/py-prettyprint.c: Do not include py-ref.h.
10207         * python/py-progspace.c: Do not include py-ref.h.
10208         * python/py-symbol.c: Do not include py-ref.h.
10209         * python/py-symtab.c: Do not include py-ref.h.
10210         * python/py-type.c: Do not include py-ref.h.
10211         * python/py-unwind.c: Do not include py-ref.h.
10212         * python/py-utils.c: Do not include py-ref.h.
10213         * python/py-value.c: Do not include py-ref.h.
10214         * python/py-varobj.c: Do not include py-ref.h.
10215         * python/py-xmethods.c: Do not include py-ref.h.
10216         * python/python.c: Do not include py-ref.h.
10217         * varobj.c: Do not include py-ref.h.
10218
10219 2019-01-22  Tom Tromey  <tom@tromey.com>
10220
10221         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10222         keyword for bcache.
10223
10224 2019-01-22  Tom Tromey  <tom@tromey.com>
10225
10226         * compile/compile-cplus-types.c: Remove a comment by #include.
10227
10228 2019-01-22  Tom Tromey  <tom@tromey.com>
10229
10230         * compile/gcc-c-plugin.h: Include compile-internal.h.
10231
10232 2019-01-22  Tom Tromey  <tom@tromey.com>
10233
10234         * stabsread.c (EXTERN): Do not define.
10235         (symnum, next_symbol_text_func, processing_gcc_compilation)
10236         (within_function, global_sym_chain, global_stabs)
10237         (previous_stab_code, this_object_header_files)
10238         (n_this_object_header_files)
10239         (n_allocated_this_object_header_files): Define.
10240         * stabsread.h (EXTERN): Never define.  Use "extern".
10241
10242 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10243
10244         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10245         history_value.
10246
10247 2019-01-21  Tom Tromey  <tom@tromey.com>
10248
10249         * ui-out.c: Fix includes.
10250         * tui/tui-source.c: Fix includes.
10251         * target.c: Fix includes.
10252         * remote.c: Fix includes.
10253         * regcache.c: Fix includes.
10254         * python/py-block.c: Fix includes.
10255         * printcmd.c: Fix includes.
10256         * or1k-tdep.c: Fix includes.
10257         * mi/mi-main.c: Fix includes.
10258         * m32r-tdep.c: Fix includes.
10259         * csky-tdep.c: Fix includes.
10260         * compile/compile-cplus-types.c: Fix includes.
10261         * cli/cli-interp.c: Fix includes.
10262
10263 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10264
10265         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10266         for padding.
10267
10268 2019-01-16  Tom Tromey  <tom@tromey.com>
10269
10270         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10271         earlier.
10272         (struct objfile) <msymbols_range>: Move from top level.
10273         <msymbols>: New method.
10274         (class objfile_msymbols): Remove.
10275         * symtab.c (default_collect_symbol_completion_matches_break_on):
10276         Update.
10277         * symmisc.c (dump_msymbols): Update.
10278         * stabsread.c (scan_file_globals): Update.
10279         * objc-lang.c (info_selectors_command, info_classes_command)
10280         (find_methods): Update.
10281         * minsyms.c (find_solib_trampoline_target): Update.
10282         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10283         * coffread.c (coff_symfile_read): Update.
10284         * ada-lang.c (ada_lookup_simple_minsym)
10285         (ada_collect_symbol_completion_matches): Update.
10286
10287 2019-01-16  Tom Tromey  <tom@tromey.com>
10288
10289         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10290         type.  Remove no-argument constructor.
10291         <iterator::operator++>: Simplify.
10292         <begin>: Update.
10293         <end>: Use minimal_symbol_count.
10294
10295 2019-01-16  Tom Tromey  <tom@tromey.com>
10296
10297         * objfiles.h (struct objfile) <psymtabs>: New method.
10298         (class objfile_psymtabs): Remove.
10299         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10300         typedef.
10301         <range>: New method.
10302         (require_partial_symbols): Change return type.
10303         * psymtab.c (require_partial_symbols)
10304         (psym_expand_symtabs_matching): Update.
10305         * mdebugread.c (parse_partial_symbols): Update.
10306         * dbxread.c (dbx_end_psymtab): Update.
10307
10308 2019-01-15  Tom Tromey  <tom@tromey.com>
10309
10310         * symtab.c (lookup_objfile_from_block)
10311         (lookup_symbol_in_objfile_symtabs)
10312         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10313         (find_line_symtab, info_sources_command)
10314         (default_collect_symbol_completion_matches_break_on)
10315         (make_source_files_completion_list): Update.
10316         * symmisc.c (print_objfile_statistics, dump_objfile)
10317         (maintenance_print_symbols, maintenance_info_symtabs)
10318         (maintenance_check_symtabs, maintenance_info_line_tables):
10319         Update.
10320         * source.c (select_source_symtab)
10321         (forget_cached_source_info_for_objfile): Update.
10322         * objfiles.h (class objfile_compunits): Remove.
10323         (struct objfile) <compunits_range>: New typedef.
10324         (compunits): New method.
10325         * objfiles.c (objfile_relocate1): Update.
10326         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10327         * maint.c (count_symtabs_and_blocks): Update.
10328         * linespec.c (iterate_over_all_matching_symtabs): Update.
10329         * cp-support.c (add_symbol_overload_list_qualified): Update.
10330         * coffread.c (coff_symtab_read): Update.
10331         * ada-lang.c (add_nonlocal_symbols)
10332         (ada_collect_symbol_completion_matches)
10333         (ada_add_global_exceptions): Update.
10334
10335 2019-01-15  Tom Tromey  <tom@tromey.com>
10336
10337         * progspace.h (program_space) <objfiles_safe_range>: New
10338         typedef.
10339         <objfiles_safe>: New method.
10340         * objfiles.h (class all_objfiles_safe): Remove.
10341         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10342         * jit.c (jit_inferior_exit_hook): Update.
10343
10344 2019-01-17  Tom Tromey  <tom@tromey.com>
10345
10346         * progspace.h (program_space) <objfiles_range>: New typedef.
10347         <objfiles>: New method.
10348         <objfiles_head>: Rename from objfiles.
10349         (object_files): Update.
10350         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10351         * guile/scm-pretty-print.c
10352         (ppscm_find_pretty_printer_from_objfiles): Update.
10353         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10354         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10355         Update.
10356         * python/py-progspace.c (pspy_get_objfiles): Update.
10357         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10358         Update.
10359         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10360         (objfpy_lookup_objfile_by_build_id): Update.
10361         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10362         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10363         Update.
10364         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10365         (expand_symtab_containing_pc, lookup_objfile_from_block)
10366         (lookup_static_symbol, basic_lookup_transparent_type)
10367         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10368         (find_line_symtab, info_sources_command)
10369         (default_collect_symbol_completion_matches_break_on)
10370         (make_source_files_completion_list, find_main_name): Update.
10371         * symmisc.c (print_symbol_bcache_statistics)
10372         (print_objfile_statistics, maintenance_print_symbols)
10373         (maintenance_print_msymbols, maintenance_print_objfiles)
10374         (maintenance_info_symtabs, maintenance_check_symtabs)
10375         (maintenance_expand_symtabs, maintenance_info_line_tables):
10376         Update.
10377         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10378         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10379         (map_overlay_command, unmap_overlay_command)
10380         (simple_overlay_update, expand_symtabs_matching)
10381         (map_symbol_filenames): Update.
10382         * symfile-debug.c (set_debug_symfile): Update.
10383         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10384         Update.
10385         * source.c (select_source_symtab, forget_cached_source_info):
10386         Update.
10387         * solib.c (solib_read_symbols): Update.
10388         * solib-spu.c (append_ocl_sos): Update.
10389         * psymtab.c (maintenance_print_psymbols)
10390         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10391         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10392         * printcmd.c (info_symbol_command): Update.
10393         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10394         Update.
10395         * objfiles.h (class all_objfiles): Remove.
10396         * objfiles.c (have_partial_symbols, have_full_symbols)
10397         (have_minimal_symbols, qsort_cmp, update_section_map)
10398         (shared_objfile_contains_address_p)
10399         (default_iterate_over_objfiles_in_search_order): Update.
10400         * objc-lang.c (info_selectors_command, info_classes_command)
10401         (find_methods): Update.
10402         * minsyms.c (find_solib_trampoline_target): Update.
10403         * maint.c (maintenance_info_sections)
10404         (maintenance_translate_address, count_symtabs_and_blocks):
10405         Update.
10406         * main.c (captured_main_1): Update.
10407         * linux-thread-db.c (try_thread_db_load_from_pdir)
10408         (has_libpthread): Update.
10409         * linespec.c (iterate_over_all_matching_symtabs)
10410         (search_minsyms_for_name): Update.
10411         * jit.c (jit_find_objf_with_entry_addr): Update.
10412         * hppa-tdep.c (find_unwind_entry)
10413         (hppa_lookup_stub_minimal_symbol): Update.
10414         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10415         Update.
10416         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10417         (elf_gnu_ifunc_resolve_by_got): Update.
10418         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10419         * dwarf-index-write.c (save_gdb_index_command): Update.
10420         * cp-support.c (add_symbol_overload_list_qualified): Update.
10421         * breakpoint.c (create_overlay_event_breakpoint)
10422         (create_longjmp_master_breakpoint)
10423         (create_std_terminate_master_breakpoint)
10424         (create_exception_master_breakpoint): Update.
10425         * blockframe.c (find_pc_partial_function): Update.
10426         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10427         (ada_collect_symbol_completion_matches)
10428         (ada_add_global_exceptions): Update.
10429
10430 2019-01-17  Tom Tromey  <tom@tromey.com>
10431
10432         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10433         declare VEC.
10434         (solib_target_parse_libraries): Change return type.
10435         (library_list_start_segment, library_list_start_section)
10436         (library_list_end_library, library_list_start_library); Update.
10437         (solib_target_free_library_list): Remove.
10438         (solib_target_parse_libraries): Remove cleanup.  Change return
10439         type.
10440         (solib_target_current_sos): Update.
10441
10442 2019-01-17  Tom Tromey  <tromey@bapiya>
10443
10444         * valprint.c: Replace "the the" with "the".
10445         * symtab.c: Replace "the the" with "the".
10446         * solib.c: Replace "the the" with "the".
10447         * solib-dsbt.c: Replace "the the" with "the".
10448         * linespec.c: Replace "the the" with "the".
10449         * dwarf2loc.h: Replace "the the" with "the".
10450         * amd64-windows-tdep.c: Replace "the the" with "the".
10451         * aarch64-tdep.c: Replace "the the" with "the".
10452
10453 2019-01-16  Keith Seitz  <keiths@redhat.com>
10454
10455         PR gdb/23773
10456         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10457         <builder>: Rename to ..
10458         <m_builder>: ... this and make private.
10459         (dwarf2_cu::get_builder): New method.  Change all users of
10460         `builder' to use this method.
10461         (dwarf2_start_symtab): Move to ...
10462         (dwarf2_cu::start_symtab): ... here.  Update all callers
10463         (setup_type_unit_groups): Move to ...
10464         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10465         callers.
10466         (dwarf2_cu::reset_builder): New method.
10467         (process_full_compunit, process_full_type_unit): Use
10468         dwarf2_cu::reset_builder.
10469         (follow_die_offset): Record the ancestor CU if it is different
10470         from the followed DIE's CU.
10471         (follow_die_sig_1): Likewise.
10472
10473 2019-01-15  Tom Tromey  <tom@tromey.com>
10474
10475         * remote.c (class remote_state) <buf>: Now a char_vector.
10476         <buf_size>: Remove.
10477         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10478         parameter.
10479         (remote_target::getpkt_or_notif_sane_1)
10480         (remote_target::getpkt_sane)
10481         (remote_target::getpkt_or_notif_sane): Likewise.
10482         (class remote_target) <putpkt>: New overload.
10483         (remote_target::read_frame): Change type of "buf_p".  Remove
10484         sizeof_p parameter.
10485         (packet_ok): New overload.
10486         (packet_check_result): New overload.
10487         Update all uses.
10488
10489 2019-01-14  Tom Tromey  <tom@tromey.com>
10490
10491         * remote-notif.c (handle_notification, remote_notif_ack)
10492         (remote_notif_parse): Make "buf" const.
10493         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10494         const.
10495         (remote_notif_parse, remote_notif_ack, handle_notification):
10496         Likewise.
10497         * remote.c (remote_notif_stop_parse): Make "buf" const.
10498         (remote_target::remote_parse_stop_reply): Make "buf" const.
10499         (remote_notif_stop_ack): Make "buf" const.
10500
10501 2019-01-14  Tom Tromey  <tom@tromey.com>
10502
10503         * remote.c (remote_console_output): Make parameter const.
10504
10505 2019-01-14  Tom Tromey  <tom@tromey.com>
10506
10507         * target-debug.h (target_debug_print_signals): Constify.
10508         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10509         * procfs.c (procfs_target::pass_signals): Update.
10510         * linux-nat.c (linux_nat_target::pass_signals): Update.
10511         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10512         * target-delegates.c: Rebuild.
10513         * remote.c (remote_target::program_signals): Update.
10514         (remote_target::pass_signals): Update.
10515         * target.c (target_pass_signals): Constify argument.
10516         (target_program_signals): Likewise.
10517         * target.h (struct target_ops) <pass_signals, program_signals>:
10518         Constify argument.
10519         (target_pass_signals, target_program_signals): Constify argument.
10520
10521 2019-01-14  Tom Tromey  <tom@tromey.com>
10522
10523         PR tui/28819:
10524         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10525
10526 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10527
10528         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10529         field.
10530         * rs6000-tdep.c: Include reggroups.h.
10531         (IS_V_ALIAS_PSEUDOREG): Define.
10532         (rs6000_register_name): Return names for the "vX" aliases.
10533         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10534         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10535         aliases.  Call default_register_reggroup_p for all other
10536         pseudo-registers.
10537         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10538         New functions.
10539         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10540         Handle "vX" aliases.
10541         (v_alias_pseudo_register_collect): New function.
10542         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10543         (rs6000_gdbarch_init): Initialize "vX" aliases as
10544         pseudo-registers.  Restore registration of
10545         rs6000_pseudo_register_reggroup_p with
10546         set_tdesc_pseudo_register_reggroup_p.
10547
10548 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10549
10550         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10551         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10552         set_gdbarch_num_pseudo_regs.
10553
10554 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10555
10556         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10557         Remove arg prefixname, add do_set and do_show.
10558         Add member functions set_list and show_list.
10559         * cli/cli-style.c (class cli_style_option): Update accordingly.
10560         (style_set_list): Move to file scope.
10561         (style_show_list): Likewise.
10562         (set_style): Call help_list.
10563         (show_style): Call cmd_show_list.
10564         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10565         Update to use the new macro.
10566
10567 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10568
10569         * ada-lang.c (_initialize_ada_language): Expand the help text
10570         for the "catch exception" command.
10571
10572 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10573
10574         * symtab.c (matching_obj_sections): Initialize obj,
10575         declare it closer to its usage.
10576
10577 2019-01-10  Tom Tromey  <tom@tromey.com>
10578
10579         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10580         (basic_inf_threads_range): Remove.
10581         (inf_threads_range, inf_non_exited_threads_range)
10582         (safe_inf_threads_range): Use next_adapter.
10583
10584 2019-01-10  Keith Seitz  <keiths@redhat.com>
10585
10586         PR gdb/23712
10587         PR symtab/23010
10588         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10589         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10590
10591 2019-01-10  Keith Seitz  <keiths@redhat.com>
10592
10593         PR gdb/23712
10594         PR symtab/23010
10595         * dictionary.c (pending_to_vector): Remove.
10596         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10597         Remove _1 suffix, replacing functions of the same name.  Update
10598         all callers.
10599         (dict_create_hashed, dict_create_hashed_expandable)
10600         (dict_create_linear, dict_create_linear_expandable, dict_free)
10601         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10602         Make functions static.
10603
10604 2019-01-10  Keith Seitz  <keiths@redhat.com>
10605
10606         PR gdb/23712
10607         PR symtab/23010
10608         * dictionary.h (struct dictionary): Replace declaration with
10609         multidictionary.
10610         (dict_create_hashed, dict_create_hashed_expandable)
10611         (dict_create_linear, dict_create_linear_expandable)
10612         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10613         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10614         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10615         taking multidictionary argument.
10616         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10617         * block.h (struct block) <dict>: Change to multidictionary
10618         and rename `multidict'.
10619         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10620         symmisc.c: Update all dictionary references to multidictionary.
10621
10622 2019-01-10  Keith Seitz  <keiths@redhat.com>
10623
10624         PR gdb/23712
10625         PR symtab/23010
10626         * dictionary.c: Include unordered_map.
10627         (pending_to_vector): New function.
10628         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10629         Rewrite the non-"_1" functions to take vector instead
10630         of linked list.
10631         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10632         "new" _1 versions of the same name.
10633         (multidictionary): Define.
10634         (std::hash<enum language): New definition.
10635         (collate_pending_symbols_by_language, mdict_create_hashed)
10636         (mdict_create_hashed_expandable, mdict_create_linear)
10637         (mdict_create_linear_expandable, mdict_free)
10638         (find_language_dictionary, create_new_language_dictionary)
10639         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10640         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10641         (mdict_size, mdict_empty): New functions.
10642         * dictionary.h (mdict_iterator): Define.
10643
10644 2019-01-10  Pedro Alves  <palves@redhat.com>
10645
10646         * breakpoint.c (read_uploaded_action)
10647         (create_tracepoint_from_upload): Adjust to use
10648         gdb::unique_xmalloc_ptr.
10649         * ctf.c (ctf_write_uploaded_tp):
10650         (SET_ARRAY_FIELD): Use emplace_back.
10651         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10652         * tracefile-tfile.c (tfile_write_uploaded_tp):
10653         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10654         gdb::unique_xmalloc_ptr.
10655         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10656         at_string, cond_string, cmd_strings>: Replace char pointers
10657         with gdb::unique_xmalloc_ptr.
10658
10659 2019-01-10  Pedro Alves  <palves@redhat.com>
10660
10661         * solib-target.c (library_list_start_library): Don't xstrdup name.
10662
10663 2019-01-10  Pedro Alves  <palves@redhat.com>
10664
10665         * mdebugread.c (parse_partial_symbols): Use
10666         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10667
10668 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10669
10670         * linux-fork.c (scoped_switch_fork_info)
10671         <~scoped_switch_fork_info>: Fix incorrect variable name.
10672
10673 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10674
10675         * linux-fork.c (scoped_switch_fork_info)
10676         <scoped_switch_fork_info>: Make explicit.
10677         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10678
10679 2019-01-10  Tom Tromey  <tom@tromey.com>
10680
10681         * objfiles.h (objfile::reset_psymtabs): Update.
10682         * objfiles.c (objfile::objfile): Update.
10683         * psymtab.h (psymtab_storage::obstack): Update.
10684         (psymtab_storage::m_obstack): Use gdb::optional.
10685         (class psymtab_storage): Update comment.  Remove objfile
10686         parameter.
10687         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10688
10689 2019-01-10  Tom Tromey  <tom@tromey.com>
10690
10691         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10692         <free_psymtabs>: Now private.
10693         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10694         (allocate_psymtab): Use new method.
10695
10696 2019-01-10  Tom Tromey  <tom@tromey.com>
10697
10698         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10699         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10700         * mdebugread.c (parse_partial_symbols): Use
10701         allocate_dependencies.
10702         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10703         allocate_dependencies.
10704         (process_psymtab_comp_unit_reader)
10705         (build_type_psymtab_dependencies): Likewise.
10706         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10707
10708 2019-01-10  Tom Tromey  <tom@tromey.com>
10709
10710         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10711         PSYMBOL_SET_LANGUAGE.
10712         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10713
10714 2019-01-10  Tom Tromey  <tom@tromey.com>
10715
10716         * psymtab.h (psymtab_storage::obstack): New method.
10717         <m_obstack>: Rename from obstack; now private.
10718         * psymtab.c (psymtab_storage): Update.
10719         * dwarf2read.c (create_addrmap_from_index)
10720         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10721         Update.
10722
10723 2019-01-10  Tom Tromey  <tom@tromey.com>
10724
10725         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10726         * objfiles.h (objfile::reset_psymtabs): New method.
10727
10728 2019-01-10  Tom Tromey  <tom@tromey.com>
10729
10730         * symmisc.c (print_symbol_bcache_statistics): Update.
10731         (print_objfile_statistics): Update.
10732         * symfile.c (reread_symbols): Update.
10733         * psymtab.h (class psymtab_storage): New.
10734         * psymtab.c (psymtab_storage): New constructor.
10735         (~psymtab_storage): New destructor.
10736         (require_partial_symbols): Update.
10737         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10738         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10739         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10740         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10741         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10742         (start_psymtab_common, end_psymtab_common)
10743         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10744         (allocate_psymtab): Update.
10745         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10746         Update.
10747         (dump_psymtab_addrmap, maintenance_print_psymbols)
10748         (maintenance_check_psymtabs): Update.
10749         (class objfile_psymtabs): Move to objfiles.h.
10750         * psympriv.h (discard_psymtab): Now inline.
10751         (psymtab_discarder::psymtab_discarder): Update.
10752         (psymtab_discarder::~psymtab_discarder): Update.
10753         (ALL_OBJFILE_PSYMTABS): Rewrite.
10754         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10755         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10756         Remove fields.
10757         <partial_symtabs>: New field.
10758         (class objfile_psymtabs): Move from psymtab.h.  Update.
10759         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10760         psymbol_cache.
10761         (objfile::~objfile): Don't destroy psymbol_cache.
10762         * mdebugread.c (parse_partial_symbols): Update.
10763         * dwarf2read.c (create_addrmap_from_index)
10764         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10765         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10766         (add_partial_subprogram, dwarf2_ranges_read): Update.
10767         * dwarf-index-write.c (write_address_map)
10768         (write_one_signatured_type, recursively_write_psymbols)
10769         (class debug_names, class debug_names, write_psymtabs_to_index):
10770         Update.
10771
10772 2019-01-10  Tom Tromey  <tom@tromey.com>
10773
10774         * symtab.h (SYMBOL_SET_NAMES): Update.
10775         (symbol_set_names): Update.
10776         (MSYMBOL_SET_NAMES): Update.
10777         * symtab.c (symbol_set_names): Change argument to be an
10778         objfile_per_bfd_storage.
10779         * psymtab.c (add_psymbol_to_bcache): Update.
10780         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10781
10782 2019-01-10  Tom Tromey  <tom@tromey.com>
10783
10784         * symtab.c (create_demangled_names_hash): Change argument to be an
10785         objfile_per_bfd_storage.
10786         (symbol_set_names): Update.
10787
10788 2019-01-10  Tom Tromey  <tom@tromey.com>
10789
10790         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10791         init_psymbol_list.
10792         * psymtab.c (init_psymbol_list): Do nothing if already called.
10793         * psympriv.h (init_psymbol_list): Add comment.
10794         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10795         init_psymbol_list.
10796         * dbxread.c (dbx_symfile_read): Unconditionally call
10797         init_psymbol_list.
10798
10799 2019-01-10  Tom Tromey  <tom@tromey.com>
10800
10801         * xcoffread.c (scan_xcoff_symtab): Update.
10802         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10803         "where".
10804         * mdebugread.c (parse_partial_symbols)
10805         (handle_psymbol_enumerators): Update.
10806         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10807         * dbxread.c (read_dbx_symtab): Update.
10808         * psympriv.h (psymbol_placement): New enum.
10809         (add_psymbol_to_list): Update.
10810
10811 2019-01-10  Tom Tromey  <tom@tromey.com>
10812
10813         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10814         static_psymbols parameters.
10815         (scan_xcoff_symtab): Update.
10816         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10817         static_psymbols parameters.
10818         * psympriv.h (start_psymtab_common): Update.
10819         * mdebugread.c (parse_partial_symbols): Update.
10820         * dwarf2read.c (create_partial_symtab): Update.
10821         * dbxread.c (read_dbx_symtab): Update.
10822         (start_psymtab): Remove global_psymbols and static_psymbols
10823         parameters.
10824
10825 2019-01-10  Tom Tromey  <tom@tromey.com>
10826
10827         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10828         * psymtab.c (allocate_psymtab): Add comment.
10829         * psympriv.h (allocate_psymtab): Add comment.
10830         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10831         initializations.
10832         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10833
10834 2019-01-10  Tom Tromey  <tom@tromey.com>
10835
10836         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10837         Don't declare.
10838         * mipsread.c: Include mdebugread.h.
10839         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10840         Declare.
10841         * elfread.c: Include mdebugread.h.
10842
10843 2019-01-09  Tom Tromey  <tom@tromey.com>
10844
10845         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10846         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10847         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10848         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10849         (psym_lookup_symbol, psym_find_last_source_symtab)
10850         (psym_forget_cached_source_info, psym_print_stats)
10851         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10852         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10853         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10854         (psym_find_compunit_symtab_by_address)
10855         (maintenance_print_psymbols, maintenance_info_psymtabs)
10856         (maintenance_check_psymtabs): Use ranged for.
10857         * psymtab.h (class objfile_psymtabs): New.
10858         (require_partial_symbols): Return objfile_psymtabs.
10859         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10860
10861 2019-01-09  Tom Tromey  <tom@tromey.com>
10862
10863         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10864         (find_pc_mapped_section, list_overlays_command)
10865         (map_overlay_command, unmap_overlay_command)
10866         (simple_overlay_update): Use all_objfiles.
10867         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10868         * printcmd.c (info_symbol_command): Use all_objfiles.
10869         * objfiles.h (ALL_OBJSECTIONS): Remove.
10870         * maint.c (maintenance_translate_address): Use all_objfiles.
10871         * gcore.c (gcore_create_callback): Use all_objfiles.
10872         (objfile_find_memory_regions): Likewise.
10873
10874 2019-01-09  Tom Tromey  <tom@tromey.com>
10875
10876         * symtab.c (find_line_symtab, info_sources_command)
10877         (make_source_files_completion_list): Use objfile_compunits.
10878         * source.c (select_source_symtab): Use objfile_compunits.
10879         * objfiles.h (struct objfile): Update comment.
10880         (ALL_OBJFILES): Remove.
10881         (ALL_FILETABS): Remove.
10882         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10883         objfile_compunits.
10884
10885 2019-01-09  Tom Tromey  <tom@tromey.com>
10886
10887         * symmisc.c (print_objfile_statistics, dump_objfile)
10888         (maintenance_print_symbols): Use compunit_filetabs.
10889         * source.c (forget_cached_source_info_for_objfile): Use
10890         compunit_filetabs.
10891         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10892         (ALL_FILETABS): Use compunit_filetabs.
10893         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10894         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10895
10896 2019-01-09  Tom Tromey  <tom@tromey.com>
10897
10898         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10899         (compunit_filetabs): New.
10900         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10901         compunit_filetabs.
10902         (info_sources_command, make_source_files_completion_list): Remove
10903         declaration.
10904         * symmisc.c (print_objfile_statistics, dump_objfile)
10905         (maintenance_print_symbols): Remove declaration.
10906         (maintenance_info_symtabs): Use compunit_filetabs.
10907         (maintenance_info_line_tables): Likewise.
10908         * source.c (select_source_symtab): Change local variable name.
10909         (forget_cached_source_info_for_objfile): Remove declaration.
10910         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10911         * objfiles.c (objfile_relocate1): Remove declaration.
10912         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10913         declaration.
10914         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10915         * coffread.c (coff_symtab_read): Remove declaration.
10916         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10917         compunit_filetabs.
10918
10919 2019-01-09  Tom Tromey  <tom@tromey.com>
10920
10921         * symtab.c (lookup_objfile_from_block)
10922         (find_pc_sect_compunit_symtab, search_symbols)
10923         (default_collect_symbol_completion_matches_break_on): Use
10924         objfile_compunits.
10925         * objfiles.h (ALL_COMPUNITS): Remove.
10926         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10927         * cp-support.c (add_symbol_overload_list_qualified): Use
10928         objfile_compunits.
10929         * ada-lang.c (ada_collect_symbol_completion_matches)
10930         (ada_add_global_exceptions): Use objfile_compunits.
10931
10932 2019-01-09  Tom Tromey  <tom@tromey.com>
10933
10934         * source.c (select_source_symtab)
10935         (forget_cached_source_info_for_objfile): Remove declaration.
10936         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10937         declaration.
10938         * maint.c (count_symtabs_and_blocks): Remove declaration.
10939         * cp-support.c (add_symbol_overload_list_qualified): Remove
10940         declaration.
10941         * coffread.c (coff_symtab_read): Remove declaration.
10942         * symtab.c (lookup_symbol_in_objfile_symtabs)
10943         (basic_lookup_transparent_type_1): Use objfile_compunits.
10944         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10945         (info_sources_command, search_symbols)
10946         (default_collect_symbol_completion_matches_break_on)
10947         (make_source_files_completion_list): Remove declaration.
10948         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10949         (ada_collect_symbol_completion_matches)
10950         (ada_add_global_exceptions): Remove declaration.
10951         * linespec.c (iterate_over_all_matching_symtabs): Use
10952         objfile_compunits.
10953         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10954         (class objfile_compunits): New.
10955         (ALL_COMPUNITS): Use objfile_compunits.
10956         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10957         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10958         objfile_compunits.
10959         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10960
10961 2019-01-09  Tom Tromey  <tom@tromey.com>
10962
10963         * symtab.c (search_symbols)
10964         (default_collect_symbol_completion_matches_break_on): Use
10965         objfile_msymbols.
10966         * ada-lang.c (ada_lookup_simple_minsym)
10967         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10968         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10969         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10970         objfile_msymbols.
10971         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10972         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10973         * objc-lang.c (find_methods): Use objfile_msymbols.
10974         (info_selectors_command, info_classes_command): Likewise.
10975         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10976         * objfiles.h (class objfile_msymbols): New.
10977         (ALL_OBJFILE_MSYMBOLS): Remove.
10978         (ALL_MSYMBOLS): Remove.
10979
10980 2019-01-09  Tom Tromey  <tom@tromey.com>
10981
10982         * common/next-iterator.h (next_adapter): Add Iterator template
10983         parameter.
10984         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10985         (class all_objfiles_safe): New.
10986         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10987         * objfiles.c (put_objfile_before): Update comment.
10988         (add_separate_debug_objfile): Likewise.
10989         (free_all_objfiles): Use all_objfiles_safe.
10990         (objfile_purge_solibs): Likewise.
10991
10992 2019-01-09  Tom Tromey  <tom@tromey.com>
10993
10994         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10995         (expand_symtab_containing_pc, lookup_static_symbol)
10996         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10997         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10998         all_objfiles.
10999         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11000         * breakpoint.c (create_overlay_event_breakpoint)
11001         (create_longjmp_master_breakpoint)
11002         (create_std_terminate_master_breakpoint)
11003         (create_exception_master_breakpoint): Use all_objfiles.
11004         * linux-thread-db.c (try_thread_db_load_from_pdir)
11005         (has_libpthread): Use all_objfiles.
11006         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11007         * linespec.c (iterate_over_all_matching_symtabs)
11008         (search_minsyms_for_name): Use all_objfiles.
11009         * maint.c (maintenance_info_sections): Use all_objfiles.
11010         * main.c (captured_main_1): Use all_objfiles.
11011         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11012         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11013         * guile/scm-pretty-print.c
11014         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11015         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11016         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11017         (maintenance_print_msymbols): Use all_objfiles.
11018         * source.c (select_source_symtab): Use all_objfiles.
11019         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11020         * symfile.c (remove_symbol_file_command)
11021         (expand_symtabs_matching, map_symbol_filenames): Use
11022         all_objfiles.
11023         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11024         all_objfiles.
11025         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11026         * objc-lang.c (find_methods): Use all_objfiles.
11027         * objfiles.c (have_partial_symbols, have_full_symbols)
11028         (have_minimal_symbols, qsort_cmp)
11029         (default_iterate_over_objfiles_in_search_order): Use
11030         all_objfiles.
11031         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11032         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11033         (maintenance_check_psymtabs): Use all_objfiles.
11034         (ALL_PSYMTABS): Remove.
11035         * compile/compile-object-run.c (do_module_cleanup): Use
11036         all_objfiles.
11037         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11038         * cp-support.c (add_symbol_overload_list_qualified): Use
11039         all_objfiles.
11040         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11041         Use all_objfiles.
11042         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11043         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11044         all_objfiles.
11045         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11046         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11047         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11048         Uses all_objfiles.
11049         * solib.c (solib_read_symbols): Use all_objfiles
11050
11051 2019-01-09  Tom Tromey  <tom@tromey.com>
11052
11053         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11054         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11055         all_objfiles.
11056         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11057         * symmisc.c (print_symbol_bcache_statistics)
11058         (print_objfile_statistics, maintenance_print_objfiles)
11059         (maintenance_info_symtabs, maintenance_check_symtabs)
11060         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11061         all_objfiles.
11062         * source.c (forget_cached_source_info): Use all_objfiles.
11063         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11064         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11065         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11066         * objfiles.c (update_section_map): Use all_objfiles.
11067         (shared_objfile_contains_address_p): Likewise.
11068         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11069         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11070
11071 2019-01-09  Tom Tromey  <tom@tromey.com>
11072
11073         * common/next-iterator.h: New file.
11074         * objfiles.h (class all_objfiles): New.
11075         (struct objfile_iterator): New.
11076
11077 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11078
11079         * NEWS: Move the description of the changed "frame", "select-frame",
11080          and "info frame" commands to the Changed commands section.
11081
11082 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11083
11084         * gdbtypes.c (check_stub_method_group): Remove handling of old
11085         mangling schemes.
11086         * linespec.c (find_methods): Likewise.
11087         * stabsread.c (read_member_functions): Likewise.
11088         * valops.c (search_struct_method): Likewise.
11089         (value_struct_elt_for_reference): Likewise.
11090         * NEWS: Mention this change.
11091
11092 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11093
11094         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11095         print_source_lines.
11096         * source.c (print_source_lines_base): Update line number check.
11097         (print_source_lines): New function.
11098         (source_lines_range::source_lines_range): New function.
11099         * source.h (class source_lines_range): New class.
11100         (print_source_lines): New declaration.
11101
11102 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11103
11104         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11105
11106 2019-01-08  Tom Tromey  <tom@tromey.com>
11107             Simon Marchi  <simon.marchi@ericsson.com>
11108
11109         PR gdb/24060
11110         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11111         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11112         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11113         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11114         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11115         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11116
11117 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11118
11119         * source.c (select_source_symtab): Move header comment to
11120         declaration in source.h.
11121         (forget_cached_source_info_for_objfile): Likewise.
11122         (forget_cached_source_info): Likewise.
11123         (identify_source_line): Likewise.
11124         * source.h (identify_source_line): Move declaration from symtab.h
11125         and add comment from source.c
11126         (print_source_lines): Likewise.
11127         (forget_cached_source_info_for_objfile): Likewise.
11128         (forget_cached_source_info): Likewise.
11129         (select_source_symtab): Likewise.
11130         (enum print_source_lines_flag): Move definition from symtab.h.
11131         * symtab.h (identify_source_line): Move declaration to source.h.
11132         (print_source_lines): Likewise.
11133         (forget_cached_source_info_for_objfile): Likewise.
11134         (forget_cached_source_info): Likewise.
11135         (select_source_symtab): Likewise.
11136         (enum print_source_lines_flag): Move definition to source.h.
11137         * tui/tui-hooks.c: Add 'source.h' include.
11138
11139 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11140
11141         * source.c (print_source_lines_base): Handle requests to print
11142         reverse line number sequences, and guard against empty lines
11143         string.
11144
11145 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11146
11147         * source.c (print_source_lines_base): Fix skip of '\r' if next
11148         character is '\n'.
11149
11150 2019-01-06  Tom Tromey  <tom@tromey.com>
11151
11152         * c-exp.y (struct c_parse_state) <macro_original_text,
11153         expansion_obstack>: New member.
11154         (macro_original_text, expansion_obstack): Remove globals.
11155         (scan_macro_expansion, scanning_macro_expansion)
11156         (finished_macro_expansion): Update.
11157         (scan_macro_cleanup): Remove.
11158         (yylex, c_parse): Update.
11159
11160 2019-01-06  Tom Tromey  <tom@tromey.com>
11161
11162         * c-exp.y (struct c_parse_state) <strings>: New member.
11163         (operator_stoken): Update.
11164
11165 2019-01-06  Tom Tromey  <tom@tromey.com>
11166
11167         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11168         (union type_stack_elt) <typelist_val>: Now a pointer to
11169         std::vector.
11170         (type_stack_cleanup): Don't declare.
11171         (push_typelist): Update.
11172         * parse.c (pop_typelist): Return a std::vector.
11173         (push_typelist): Take a std::vector.
11174         (follow_types): Update.  Do not free args.
11175         (type_stack_cleanup): Remove.
11176         * c-exp.y (struct c_parse_state): New.
11177         (cpstate): New global.
11178         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11179         (nonempty_typelist): Update.
11180         (func_mod): Create a new vector.
11181         (c_parse): Create a c_parse_state.
11182         (check_parameter_typelist): Do not delete params.
11183         (function_method): Update.  Do not delete type_list.
11184
11185 2019-01-06  Tom Tromey  <tom@tromey.com>
11186
11187         PR gdb/28155:
11188         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11189         check_typedef.
11190         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11191         (print_return_value): Likewise.
11192
11193 2019-01-05  Tom Tromey  <tom@tromey.com>
11194
11195         * contrib/cleanup_check.py: Remove.
11196         * contrib/gcc-with-excheck: Remove.
11197         * contrib/exsummary.py: Remove.
11198         * contrib/excheck.py: Remove.
11199
11200 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11201
11202         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11203         NULL. Initialize tpprev to NULL instead of assigning it
11204         to NULL on the next statement.
11205         * windows-nat.c (windows_delete_thread): Remove check for
11206         main_thread_id before printing thread exit notifications.
11207         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11208         Remove thread ID check against main_thread_id.
11209         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11210         windows_delete_thread.
11211         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11212
11213 2019-01-04  Tom Tromey  <tom@tromey.com>
11214
11215         * compile/compile.c (_initialize_compile): Use upper case for
11216         metasyntactic variables.
11217         * symmisc.c (_initialize_symmisc): Use upper case for
11218         metasyntactic variables.
11219         * psymtab.c (_initialize_psymtab): Use upper case for
11220         metasyntactic variables.
11221         * demangle.c (demangle_command): Use upper case for metasyntactic
11222         variables.
11223         (_initialize_demangler): Likewise.
11224         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11225         variables.
11226
11227 2019-01-03  Tom Tromey  <tom@tromey.com>
11228
11229         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11230
11231 2019-01-03  Tom Tromey  <tom@tromey.com>
11232
11233         * python/py-symtab.c (salpy_str): Update.
11234         (struct salpy_sal_object) <symtab>: Now a PyObject.
11235         (salpy_dealloc): Update.
11236         (del_objfile_sal): Use gdbpy_ref.
11237
11238 2019-01-03  Tom Tromey  <tom@tromey.com>
11239
11240         * python/py-type.c (convert_field): Use new_reference.  Return
11241         gdbpy_ref.
11242         (make_fielditem): Return gdbpy_ref.
11243         (typy_fields): Update.
11244         (typy_getitem): Update.
11245         (field_name): Return gdbpy_ref.  Use new_reference.
11246         (typy_iterator_iternext): Update.
11247
11248 2019-01-03  Tom Tromey  <tom@tromey.com>
11249
11250         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11251
11252 2019-01-03  Tom Tromey  <tom@tromey.com>
11253
11254         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11255         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11256         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11257         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11258         (pspy_set_type_printers): Likewise.
11259         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11260         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11261         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11262         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11263         (objfpy_set_type_printers): Likewise.
11264
11265 2019-01-03  Tom Tromey  <tom@tromey.com>
11266
11267         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11268         (gdbpy_print_stack): Use gdbpy_err_fetch.
11269         * python/python-internal.h (class gdbpy_err_fetch): New class.
11270         (class gdbpy_enter) <m_error_type, m_error_value,
11271         m_error_traceback>: Remove.
11272         <m_error>: New member.
11273         (gdbpy_exception_to_string): Don't declare.
11274         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11275         * python/py-value.c (convert_value_from_python): Use
11276         gdbpy_err_fetch.
11277         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11278         gdbpy_exception_to_string.
11279         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11280         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11281         gdbpy_err_fetch.
11282
11283 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11284
11285         * linux-nat.c (delete_lwp_cleanup): Delete.
11286         (struct lwp_deleter): New struct.
11287         (lwp_info_up): New typedef.
11288         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11289         lwp_info_up.
11290
11291 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11292
11293         * linux-fork.c (class scoped_switch_fork_info): New class.
11294         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11295
11296 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11297
11298         * valops.c (find_overload_match): Remove use of null_cleanup, and
11299         calls to do_cleanups.
11300
11301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * compile/compile-cplus-types.c
11304         (compile_cplus_instance::decl_name): Handle changes to
11305         cp_func_name.
11306         * cp-support.c (cp_func_name): Update header comment, update
11307         return type.
11308         * cp-support.h (cp_func_name): Update return type in declaration.
11309         * valops.c (find_overload_match): Move temp_func local to top
11310         level of function and change its type.  Use temp_func to hold and
11311         delete temporary string obtained from cp_func_name.
11312
11313 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11314
11315         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11316         gdb::char_vector, remove cleanup, and update uses of `msg`.
11317
11318 2019-01-03  Jim Wilson  <jimw@sifive.com>
11319
11320         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11321
11322 2019-01-02  Tom Tromey  <tom@tromey.com>
11323
11324         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11325         (tdesc_parse_xml): Remove cleanups.
11326         * target-descriptions.h (make_cleanup_free_target_description):
11327         Don't declare.
11328         (target_desc_deleter): New struct.
11329         (target_desc_up): New typedef.
11330         * target-descriptions.c (target_desc_deleter::operator()): Rename
11331         from free_target_description.
11332         (make_cleanup_free_target_description): Remove.
11333
11334 2019-01-02  Tom Tromey  <tom@tromey.com>
11335
11336         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11337         constructor, destructor.
11338         (linespec_parser): Remove typedef.
11339         (~linespec_parser): Rename from linespec_parser_delete.
11340         (linespec_lex_to_end, linespec_complete_label)
11341         (linespec_complete): Update.
11342         (decode_line_full): Remove cleanups.
11343         (decode_line_1): Update.
11344
11345 2019-01-02  Tom Tromey  <tom@tromey.com>
11346
11347         * python/python-internal.h (inferior_to_inferior_object): Change
11348         return type.
11349         * python/py-exitedevent.c (create_exited_event_object): Update.
11350         * python/py-inferior.c (inferior_to_inferior_object): Return
11351         gdbpy_ref.
11352         (python_new_inferior, python_inferior_deleted)
11353         (thread_to_thread_object, delete_thread_object)
11354         (build_inferior_list, gdbpy_selected_inferior): Update.
11355         * python/py-infthread.c (create_thread_object): Update.  Also fail
11356         if inferior_to_inferior_object fails.
11357
11358 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11359
11360         * inferior.h (class inferior) <displaced_step_state>: New field.
11361         * infrun.h (struct displaced_step_state): Move here from
11362         infrun.c.  Initialize fields, add constructor.
11363         <inf>: Remove field.
11364         <reset>: New method.
11365         * infrun.c (struct displaced_step_inferior_state): Move to
11366         infrun.h.
11367         (displaced_step_inferior_states): Remove.
11368         (get_displaced_stepping_state): Adust.
11369         (displaced_step_in_progress_any_inferior): Adjust.
11370         (displaced_step_in_progress_thread): Adjust.
11371         (displaced_step_in_progress): Adjust.
11372         (add_displaced_stepping_state): Remove.
11373         (get_displaced_step_closure_by_addr): Adjust.
11374         (remove_displaced_stepping_state): Remove.
11375         (infrun_inferior_exit): Call displaced_step_state.reset.
11376         (use_displaced_stepping): Don't check for NULL.
11377         (displaced_step_prepare_throw): Call
11378         get_displaced_stepping_state.
11379         (displaced_step_fixup): Don't check for NULL.
11380         (prepare_for_detach): Don't check for NULL.
11381
11382 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11383
11384         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11385          in case of call that did not complete.
11386
11387 2019-01-02  Andrey Utkin  <autkin@undo.io>
11388
11389         * symfile.c (find_separate_debug_file): Fix search of debug files for
11390         remote debuggee.
11391
11392 2019-01-02  Tom Tromey  <tom@tromey.com>
11393
11394         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11395         indentation.
11396         * python/py-frame.c (frapy_older): Remove cast.
11397         (frapy_newer): Likewise.
11398         * python/py-breakpoint.c (local_setattro): Remove cast.
11399         * python/py-arch.c (archpy_name): Remove local variable.
11400         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11401
11402 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11403
11404         * unittests/basic_string_view/element_access/char/empty.cc:
11405         Fix year range in copyright header.
11406
11407 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11408
11409         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11410         Delete.
11411         <operator==>: Update with for removed field.
11412         <hash>: Likewise.
11413         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11414         <isa_features>: ...this.
11415         <abi_features>: New field.
11416         (riscv_isa_flen): Update comment.
11417         (riscv_abi_xlen): New declaration.
11418         (riscv_abi_flen): New declaration.
11419         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11420         isa_features.
11421         (riscv_abi_xlen): New function.
11422         (riscv_isa_flen): Update to get answer from isa_features.
11423         (riscv_abi_flen): New function.
11424         (riscv_has_fp_abi): Update to get answer from abi_features.
11425         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11426         xlen and flen.
11427         (riscv_call_info) <xlen, flen>: Update comment.
11428         (riscv_call_arg_struct): Remove invalid assertions
11429         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11430         is removed.
11431         (riscv_gdbarch_init): Gather isa features and abi features
11432         separately, ensure both match on the gdbarch when reusing an old
11433         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11434         a target with 64-bit float hardware.
11435
11436 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11437
11438         * source.c (search_command_helper): Stop reverse search
11439         when line 1 has been searched.
11440
11441 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11442
11443         * record-full.c (record_full_base_target::close): Rewrite
11444         record_full_core_buf_list free logic.
11445
11446 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11447
11448         * break-catch-syscall.c (print_one_catch_syscall): xfree
11449         the last text.
11450
11451 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11452
11453         * top.c (print_gdb_version): Update Copyright year in version
11454         message.
11455
11456 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11457
11458         Update copyright year range in all GDB files.
11459
11460 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11461
11462         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11463
11464 For older changes see ChangeLog-2018.
11465 \f
11466 Local Variables:
11467 mode: change-log
11468 left-margin: 8
11469 fill-column: 74
11470 version-control: never
11471 coding: utf-8
11472 End:
11473