gdb/ChangeLog

   1 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * build-id.c (build_id_to_debug_bfd_1): New function.
   4         (build_id_to_debug_bfd): Look for separate debug file in
   5         sysroot.
   6
   7 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
   8
   9         * gdbarch.sh: Update the copyright year range that is placed into
  10         generated files.
  11
  12 2019-02-22  Keith Seitz  <keiths@redhat.com>
  13
  14         PR symtab/23853
  15         * linespec.c (create_sals_line_offset): Search for the default
  16         symtab's filename instead of its fullname.
  17
  18 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * NEWS: Update style defaults.
  21
  22 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * main.c (captured_main_1): Disable styling in batch mode.
  25
  26 2019-02-20  Tom Tromey  <tom@tromey.com>
  27
  28         * symtab.c (symtab_symbol_info): Fix typos.
  29
  30 2019-02-20  Tom Tromey  <tromey@adacore.com>
  31
  32         * findcmd.c (_initialize_mem_search): Use upper case for
  33         metasyntactic variables.
  34
  35 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  36
  37         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  38         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  39
  40 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  41
  42         * top.h (source_file_name): Change to std::string.
  43         * top.c (source_file_name): Likewise.
  44         (command_line_input): Adjust.
  45         * cli/cli-script.c (script_from_file): Adjust.
  46
  47 2019-02-19  Tom Tromey  <tromey@adacore.com>
  48
  49         * ravenscar-thread.c
  50         (ravenscar_thread_target::update_thread_list): Don't call
  51         ada_build_task_list.
  52         * ada-lang.h (ada_build_task_list): Don't declare.
  53         * ada-tasks.c (struct ada_tasks_inferior_data)
  54         <task_list_valid_p>: Now bool.
  55         (read_known_tasks, ada_task_list_changed)
  56         (ada_tasks_invalidate_inferior_data): Update.
  57         (read_known_tasks_array): Return bool.
  58         (read_known_tasks_list): Likewise.
  59         (read_known_tasks): Return void.
  60         (ada_build_task_list): Now static.
  61
  62 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  63
  64         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  65         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  66
  67 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  68
  69         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  70         variant for ada_tasks_pspace_data_handle and
  71         ada_tasks_inferior_data_handle.
  72         (ada_tasks_pspace_data_cleanup): New function.
  73         (ada_tasks_inferior_data_cleanup): New function.
  74
  75 2019-02-17  Tom Tromey  <tom@tromey.com>
  76
  77         * macrotab.h (macro_source_fullname): Return a std::string.
  78         * macrotab.c (macro_include, check_for_redefinition)
  79         (macro_undef, macro_lookup_definition, foreach_macro)
  80         (foreach_macro_in_scope): Update.
  81         (macro_source_fullname): Return a std::string.
  82         * macrocmd.c (show_pp_source_pos): Update.
  83
  84 2019-02-17  Tom Tromey  <tom@tromey.com>
  85
  86         * macrocmd.c (show_pp_source_pos): Style the file names.
  87
  88 2019-02-17  Tom Tromey  <tom@tromey.com>
  89
  90         PR tui/24197:
  91         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  92
  93 2019-02-17  Tom Tromey  <tom@tromey.com>
  94
  95         * ada-lang.c (user_select_syms): Use filtered printing.
  96         * utils.c (wrap_style): New global.
  97         (desired_style): Remove.
  98         (emit_style_escape): Add stream parameter.
  99         (set_output_style, reset_terminal_style, prompt_for_continue):
 100         Update.
 101         (flush_wrap_buffer): Only flush gdb_stdout.
 102         (wrap_here): Set wrap_style.
 103         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 104         treat escape sequences as a character.  Change when wrap buffer is
 105         flushed.
 106         (fputs_styled): Do not set the output style when the default is
 107         requested.
 108         * ui-style.h (struct ui_file_style) <is_default>: New method.
 109         * source.c (print_source_lines_base): Emit escape sequences in one
 110         piece.
 111
 112 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 113
 114         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 115         integers and enumeration types.
 116
 117 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 118
 119         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 120         instead of lookup_symbol_in_language
 121         (do_exact_match): New function.
 122         (ada_get_symbol_name_matcher): Return do_exact_match when
 123         doing a verbatim match.
 124
 125 2019-02-15  Tom Tromey  <tromey@adacore.com>
 126
 127         * ravenscar-thread.c (ravenscar_thread_target::resume)
 128         (ravenscar_thread_target::wait): Special case wildcard requests.
 129
 130 2019-02-15  Tom Tromey  <tromey@adacore.com>
 131
 132         * ravenscar-thread.c (base_ptid): Remove.
 133         (struct ravenscar_thread_target) <close>: New method.
 134         <m_base_ptid>: New member.
 135         <update_inferior_ptid, active_task, task_is_currently_active,
 136         runtime_initialized>: Declare methods.
 137         <ravenscar_thread_target>: Add constructor.
 138         (ravenscar_thread_target::task_is_currently_active)
 139         (ravenscar_thread_target::update_inferior_ptid)
 140         (ravenscar_runtime_initialized): Rename.  Now methods.
 141         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 142         (ravenscar_thread_target::update_thread_list): Update.
 143         (ravenscar_thread_target::active_task): Now method.
 144         (ravenscar_thread_target::store_registers)
 145         (ravenscar_thread_target::prepare_to_store)
 146         (ravenscar_thread_target::prepare_to_store)
 147         (ravenscar_thread_target::mourn_inferior): Update.
 148         (ravenscar_inferior_created): Use "new" to create target.
 149         (ravenscar_thread_target::get_ada_task_ptid): Update.
 150         (_initialize_ravenscar): Don't initialize base_ptid.
 151         (ravenscar_ops): Remove global.
 152
 153 2019-02-15  Tom Tromey  <tromey@adacore.com>
 154
 155         * target.h (push_target): Declare new overload.
 156         * target.c (push_target): New overload, taking an rvalue reference.
 157         * remote.c (remote_target::open_1): Use push_target overload.
 158         * corelow.c (core_target_open): Use push_target overload.
 159
 160 2019-02-15  Tom Tromey  <tromey@adacore.com>
 161
 162         * ravenscar-thread.c (is_ravenscar_task)
 163         (ravenscar_task_is_currently_active): Return bool.
 164         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 165         (_initialize_ravenscar): Remove "(void)".
 166         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 167         Return bool.
 168
 169 2019-02-15  Tom Tromey  <tromey@adacore.com>
 170
 171         * ravenscar-thread.c (ravenscar_runtime_initializer)
 172         (has_ravenscar_runtime, get_running_thread_id)
 173         (ravenscar_thread_target::resume): Fix indentation.
 174
 175 2019-02-15  Tom Tromey  <tromey@adacore.com>
 176
 177         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 178         from ravenscar_arch_ops.
 179         (sparc_ravenscar_ops::fetch_registers)
 180         (sparc_ravenscar_ops::store_registers): Now methods.
 181         (sparc_ravenscar_prepare_to_store): Remove.
 182         (sparc_ravenscar_ops): Redefine.
 183         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 184         methods and destructor.  Remove members.
 185         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 186         (ravenscar_thread_target::store_registers)
 187         (ravenscar_thread_target::prepare_to_store): Update.
 188         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 189         Remove.
 190         (struct ppc_ravenscar_powerpc_ops): Derive from
 191         ravenscar_arch_ops.
 192         (ppc_ravenscar_powerpc_ops::fetch_registers)
 193         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 194         (ppc_ravenscar_powerpc_ops): Redefine.
 195         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 196         (ppc_ravenscar_e500_ops::fetch_registers)
 197         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 198         (ppc_ravenscar_e500_ops): Redefine.
 199         * aarch64-ravenscar-thread.c
 200         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 201         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 202         (aarch64_ravenscar_fetch_registers)
 203         (aarch64_ravenscar_store_registers): Now methods.
 204         (aarch64_ravenscar_ops): Redefine.
 205
 206 2019-02-15  Tom Tromey  <tromey@adacore.com>
 207
 208         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 209         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 210         (ravenscar_thread_target::stopped_by_watchpoint)
 211         (ravenscar_thread_target::stopped_data_address)
 212         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 213
 214 2019-02-15  Tom Tromey  <tromey@adacore.com>
 215
 216         * ravenscar-thread.c: Fix some typos.
 217
 218 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 219             Tom Tromey  <tromey@adacore.com>
 220
 221         * ada-lang.c (ada_exception_sal): Change addr_string to a
 222         std::string.
 223         (create_ada_exception_catchpoint): Update.
 224
 225 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 226             Tom Tromey  <tromey@adacore.com>
 227
 228         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 229         (bp_location_ops): Remove.
 230         (base_breakpoint_allocate_location): Update.
 231         (free_bp_location): Update.
 232         * ada-lang.c (class ada_catchpoint_location)
 233         <ada_catchpoint_location>: Remove ops parameter.
 234         (ada_catchpoint_location_dtor): Remove.
 235         (ada_catchpoint_location_ops): Remove.
 236         (allocate_location_exception): Update.
 237         * breakpoint.h (struct bp_location_ops): Remove.
 238         (class bp_location) <bp_location>: Remove bp_location_ops
 239         parameter.
 240         <~bp_location>: Add destructor.
 241         <ops>: Remove.
 242
 243 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 244             Pedro Alves  <palves@redhat.com>
 245
 246         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 247         'PATH_MAX'.
 248
 249 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 250             Samuel Thibault  <samuel.thibault@gnu.org>
 251             Thomas Schwinge  <thomas@codesourcery.com>
 252
 253         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 254         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 255
 256 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 257
 258         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 259         (check_empty): Use "const char *".
 260
 261         * gnu-nat.c (gnu_nat_target::detach): Instead of
 262         'detach_inferior (pid)' call
 263         'detach_inferior (find_inferior_pid (pid))'.
 264
 265         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 266         'nat/fork-inferior.o'.
 267         * gnu-nat.c: #include "nat/fork-inferior.h".
 268
 269         * gnu-nat.c (gnu_nat_target::detach): Instead of
 270         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 271         * gnu-nat.h: #include "inf-child.h".
 272         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 273         'i386_gnu_nat_target::fetch_registers'.
 274         (gnu_store_registers): Rename/move to
 275         'i386_gnu_nat_target::store_registers'.
 276
 277         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 278         * gnu-nat.h (mach_thread_info): New function.
 279         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 280
 281         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 282
 283 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 284
 285         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 286
 287 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 288
 289         * windows-nat.c (windows_add_thread): Add new parameter
 290         "main_thread_p" with default value set to false.  Update
 291         function documentation as well as all callers.
 292         (windows_delete_thread): Likewise.
 293         (fake_create_process): Update call to windows_add_thread.
 294         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 295         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 296         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 297         call to windows_delete_thread.
 298
 299 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 300
 301         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 302
 303 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 304
 305         * symfile.c (find_separate_debug_file): Use canonical path of
 306         sysroot with child_path instead of gdb_sysroot if it is valid.
 307
 308 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 309
 310         * symfile.c (find_separate_debug_file): Use child_path to
 311         determine if an object file is under a sysroot.
 312
 313 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 314
 315         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 316         unittests/child-path-selftests.c.
 317         * common/pathstuff.c (child_path): New function.
 318         * common/pathstuff.h (child_path): New prototype.
 319         * unittests/child-path-selftests.c: New file.
 320
 321 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 322
 323         * symfile.c (find_separate_debug_file): Look for separate debug
 324         files in debug directories under the sysroot.
 325
 326 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 327
 328         * symtab.h (struct minimal_symbol data_p): New const method.
 329         (struct minimal_symbol text_p): Likewise.
 330         * symtab.c (output_source_filename): Use file name style
 331         to print file name.
 332         (print_symbol_info): Likewise.
 333         (print_msymbol_info): Use address style to print addresses.
 334         Use function name style to print executable text symbols.
 335         (expand_symtab_containing_pc): Use data_p.
 336         (find_pc_sect_compunit_symtab): Likewise.
 337
 338 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 339
 340         * breakpoint.c (describe_other_breakpoints): Use address style
 341         to print addresses.
 342         (say_where): Likewise.
 343
 344 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 345
 346         * ada-typeprint.c (print_func_type): Print function name
 347         style to print function name.
 348         * c-typeprint.c (c_print_type_1): Likewise.
 349
 350 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 351
 352         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 353         for execve.
 354
 355 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 356
 357         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 358         type_stack.
 359
 360 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 361
 362         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 363         TYPE_CODE_REF types.
 364
 365 2019-02-08  Jim Wilson  <jimw@sifive.com>
 366
 367         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 368         (riscv_linux_fregset): New.
 369         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 370
 371 2019-02-07  Tom Tromey  <tom@tromey.com>
 372
 373         * thread.c (thread_cancel_execution_command): Update.
 374         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 375         methods.
 376         (struct thread_fsm_ops): Remove.
 377         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 378         (thread_fsm_should_stop, thread_fsm_return_value)
 379         (thread_fsm_set_finished, thread_fsm_finished_p)
 380         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 381         Don't declare.
 382         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 383         * infrun.c (clear_proceed_status_thread)
 384         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 385         (print_stop_event): Update.
 386         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 387         Add constructor.
 388         (step_command_fsm_ops): Remove.
 389         (new_step_command_fsm): Remove.
 390         (step_1): Update.
 391         (step_command_fsm::should_stop): Rename from
 392         step_command_fsm_should_stop.
 393         (step_command_fsm::clean_up): Rename from
 394         step_command_fsm_clean_up.
 395         (step_command_fsm::do_async_reply_reason): Rename from
 396         step_command_fsm_async_reply_reason.
 397         (struct until_next_fsm): Inherit from thread_fsm.  Add
 398         constructor.
 399         (until_next_fsm_ops): Remove.
 400         (new_until_next_fsm): Remove.
 401         (until_next_fsm::should_stop): Rename from
 402         until_next_fsm_should_stop.
 403         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 404         (until_next_fsm::do_async_reply_reason): Rename from
 405         until_next_fsm_async_reply_reason.
 406         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 407         constructor.  Change type of breakpoint.
 408         (finish_command_fsm_ops): Remove.
 409         (new_finish_command_fsm): Remove.
 410         (finish_command_fsm::should_stop): Rename from
 411         finish_command_fsm_should_stop.
 412         (finish_command_fsm::clean_up): Rename from
 413         finish_command_fsm_clean_up.
 414         (finish_command_fsm::return_value): Rename from
 415         finish_command_fsm_return_value.
 416         (finish_command_fsm::do_async_reply_reason): Rename from
 417         finish_command_fsm_async_reply_reason.
 418         (finish_command): Update.
 419         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 420         Add constructor.
 421         (call_thread_fsm_ops): Remove.
 422         (call_thread_fsm::call_thread_fsm): Rename from
 423         new_call_thread_fsm.
 424         (call_thread_fsm::should_stop): Rename from
 425         call_thread_fsm_should_stop.
 426         (call_thread_fsm::should_notify_stop): Rename from
 427         call_thread_fsm_should_notify_stop.
 428         (run_inferior_call, call_function_by_hand_dummy): Update.
 429         * cli/cli-interp.c (should_print_stop_to_console): Update.
 430         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 431         Add constructor.  Change type of location_breakpoint,
 432         caller_breakpoint.
 433         (until_break_fsm_ops): Remove.
 434         (new_until_break_fsm): Remove.
 435         (until_break_fsm::should_stop): Rename from
 436         until_break_fsm_should_stop.
 437         (until_break_fsm::clean_up): Rename from
 438         until_break_fsm_clean_up.
 439         (until_break_fsm::do_async_reply_reason): Rename from
 440         until_break_fsm_async_reply_reason.
 441         (until_break_command): Update.
 442         * thread-fsm.c: Remove.
 443         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 444
 445 2019-02-07  Tom Tromey  <tom@tromey.com>
 446
 447         * yy-remap.h: Add include guard.
 448         * xtensa-tdep.h: Add include guard.
 449         * xcoffread.h: Rename include guard.
 450         * varobj-iter.h: Add include guard.
 451         * tui/tui.h: Rename include guard.
 452         * tui/tui-winsource.h: Rename include guard.
 453         * tui/tui-wingeneral.h: Rename include guard.
 454         * tui/tui-windata.h: Rename include guard.
 455         * tui/tui-win.h: Rename include guard.
 456         * tui/tui-stack.h: Rename include guard.
 457         * tui/tui-source.h: Rename include guard.
 458         * tui/tui-regs.h: Rename include guard.
 459         * tui/tui-out.h: Rename include guard.
 460         * tui/tui-layout.h: Rename include guard.
 461         * tui/tui-io.h: Rename include guard.
 462         * tui/tui-hooks.h: Rename include guard.
 463         * tui/tui-file.h: Rename include guard.
 464         * tui/tui-disasm.h: Rename include guard.
 465         * tui/tui-data.h: Rename include guard.
 466         * tui/tui-command.h: Rename include guard.
 467         * tic6x-tdep.h: Add include guard.
 468         * target/waitstatus.h: Rename include guard.
 469         * target/wait.h: Rename include guard.
 470         * target/target.h: Rename include guard.
 471         * target/resume.h: Rename include guard.
 472         * target-float.h: Rename include guard.
 473         * stabsread.h: Add include guard.
 474         * rs6000-tdep.h: Add include guard.
 475         * riscv-fbsd-tdep.h: Add include guard.
 476         * regformats/regdef.h: Rename include guard.
 477         * record.h: Rename include guard.
 478         * python/python.h: Rename include guard.
 479         * python/python-internal.h: Rename include guard.
 480         * python/py-stopevent.h: Rename include guard.
 481         * python/py-ref.h: Rename include guard.
 482         * python/py-record.h: Rename include guard.
 483         * python/py-record-full.h: Rename include guard.
 484         * python/py-record-btrace.h: Rename include guard.
 485         * python/py-instruction.h: Rename include guard.
 486         * python/py-events.h: Rename include guard.
 487         * python/py-event.h: Rename include guard.
 488         * procfs.h: Add include guard.
 489         * proc-utils.h: Add include guard.
 490         * p-lang.h: Add include guard.
 491         * or1k-tdep.h: Rename include guard.
 492         * observable.h: Rename include guard.
 493         * nto-tdep.h: Rename include guard.
 494         * nat/x86-linux.h: Rename include guard.
 495         * nat/x86-linux-dregs.h: Rename include guard.
 496         * nat/x86-gcc-cpuid.h: Add include guard.
 497         * nat/x86-dregs.h: Rename include guard.
 498         * nat/x86-cpuid.h: Rename include guard.
 499         * nat/ppc-linux.h: Rename include guard.
 500         * nat/mips-linux-watch.h: Rename include guard.
 501         * nat/linux-waitpid.h: Rename include guard.
 502         * nat/linux-ptrace.h: Rename include guard.
 503         * nat/linux-procfs.h: Rename include guard.
 504         * nat/linux-osdata.h: Rename include guard.
 505         * nat/linux-nat.h: Rename include guard.
 506         * nat/linux-namespaces.h: Rename include guard.
 507         * nat/linux-btrace.h: Rename include guard.
 508         * nat/glibc_thread_db.h: Rename include guard.
 509         * nat/gdb_thread_db.h: Rename include guard.
 510         * nat/gdb_ptrace.h: Rename include guard.
 511         * nat/fork-inferior.h: Rename include guard.
 512         * nat/amd64-linux-siginfo.h: Rename include guard.
 513         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 514         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 515         * nat/aarch64-linux.h: Rename include guard.
 516         * nat/aarch64-linux-hw-point.h: Rename include guard.
 517         * mn10300-tdep.h: Add include guard.
 518         * mips-linux-tdep.h: Add include guard.
 519         * mi/mi-parse.h: Rename include guard.
 520         * mi/mi-out.h: Rename include guard.
 521         * mi/mi-main.h: Rename include guard.
 522         * mi/mi-interp.h: Rename include guard.
 523         * mi/mi-getopt.h: Rename include guard.
 524         * mi/mi-console.h: Rename include guard.
 525         * mi/mi-common.h: Rename include guard.
 526         * mi/mi-cmds.h: Rename include guard.
 527         * mi/mi-cmd-break.h: Rename include guard.
 528         * m2-lang.h: Add include guard.
 529         * location.h: Rename include guard.
 530         * linux-record.h: Rename include guard.
 531         * linux-nat.h: Add include guard.
 532         * linux-fork.h: Add include guard.
 533         * i386-darwin-tdep.h: Rename include guard.
 534         * hppa-linux-offsets.h: Add include guard.
 535         * guile/guile.h: Rename include guard.
 536         * guile/guile-internal.h: Rename include guard.
 537         * gnu-nat.h: Rename include guard.
 538         * gdb-stabs.h: Rename include guard.
 539         * frv-tdep.h: Add include guard.
 540         * f-lang.h: Add include guard.
 541         * event-loop.h: Add include guard.
 542         * darwin-nat.h: Rename include guard.
 543         * cp-abi.h: Rename include guard.
 544         * config/sparc/nm-sol2.h: Rename include guard.
 545         * config/nm-nto.h: Rename include guard.
 546         * config/nm-linux.h: Add include guard.
 547         * config/i386/nm-i386gnu.h: Rename include guard.
 548         * config/djgpp/nl_types.h: Rename include guard.
 549         * config/djgpp/langinfo.h: Rename include guard.
 550         * compile/gcc-cp-plugin.h: Add include guard.
 551         * compile/gcc-c-plugin.h: Add include guard.
 552         * compile/compile.h: Rename include guard.
 553         * compile/compile-object-run.h: Rename include guard.
 554         * compile/compile-object-load.h: Rename include guard.
 555         * compile/compile-internal.h: Rename include guard.
 556         * compile/compile-cplus.h: Rename include guard.
 557         * compile/compile-c.h: Rename include guard.
 558         * common/xml-utils.h: Rename include guard.
 559         * common/x86-xstate.h: Rename include guard.
 560         * common/version.h: Rename include guard.
 561         * common/vec.h: Rename include guard.
 562         * common/tdesc.h: Rename include guard.
 563         * common/selftest.h: Rename include guard.
 564         * common/scoped_restore.h: Rename include guard.
 565         * common/scoped_mmap.h: Rename include guard.
 566         * common/scoped_fd.h: Rename include guard.
 567         * common/safe-iterator.h: Rename include guard.
 568         * common/run-time-clock.h: Rename include guard.
 569         * common/refcounted-object.h: Rename include guard.
 570         * common/queue.h: Rename include guard.
 571         * common/ptid.h: Rename include guard.
 572         * common/print-utils.h: Rename include guard.
 573         * common/preprocessor.h: Rename include guard.
 574         * common/pathstuff.h: Rename include guard.
 575         * common/observable.h: Rename include guard.
 576         * common/netstuff.h: Rename include guard.
 577         * common/job-control.h: Rename include guard.
 578         * common/host-defs.h: Rename include guard.
 579         * common/gdb_wait.h: Rename include guard.
 580         * common/gdb_vecs.h: Rename include guard.
 581         * common/gdb_unlinker.h: Rename include guard.
 582         * common/gdb_unique_ptr.h: Rename include guard.
 583         * common/gdb_tilde_expand.h: Rename include guard.
 584         * common/gdb_sys_time.h: Rename include guard.
 585         * common/gdb_string_view.h: Rename include guard.
 586         * common/gdb_splay_tree.h: Rename include guard.
 587         * common/gdb_setjmp.h: Rename include guard.
 588         * common/gdb_ref_ptr.h: Rename include guard.
 589         * common/gdb_optional.h: Rename include guard.
 590         * common/gdb_locale.h: Rename include guard.
 591         * common/gdb_assert.h: Rename include guard.
 592         * common/filtered-iterator.h: Rename include guard.
 593         * common/filestuff.h: Rename include guard.
 594         * common/fileio.h: Rename include guard.
 595         * common/environ.h: Rename include guard.
 596         * common/common-utils.h: Rename include guard.
 597         * common/common-types.h: Rename include guard.
 598         * common/common-regcache.h: Rename include guard.
 599         * common/common-inferior.h: Rename include guard.
 600         * common/common-gdbthread.h: Rename include guard.
 601         * common/common-exceptions.h: Rename include guard.
 602         * common/common-defs.h: Rename include guard.
 603         * common/common-debug.h: Rename include guard.
 604         * common/cleanups.h: Rename include guard.
 605         * common/buffer.h: Rename include guard.
 606         * common/btrace-common.h: Rename include guard.
 607         * common/break-common.h: Rename include guard.
 608         * cli/cli-utils.h: Rename include guard.
 609         * cli/cli-style.h: Rename include guard.
 610         * cli/cli-setshow.h: Rename include guard.
 611         * cli/cli-script.h: Rename include guard.
 612         * cli/cli-interp.h: Rename include guard.
 613         * cli/cli-decode.h: Rename include guard.
 614         * cli/cli-cmds.h: Rename include guard.
 615         * charset-list.h: Add include guard.
 616         * buildsym-legacy.h: Rename include guard.
 617         * bfin-tdep.h: Add include guard.
 618         * ax.h: Rename include guard.
 619         * arm-linux-tdep.h: Add include guard.
 620         * arm-fbsd-tdep.h: Add include guard.
 621         * arch/xtensa.h: Rename include guard.
 622         * arch/tic6x.h: Add include guard.
 623         * arch/i386.h: Add include guard.
 624         * arch/arm.h: Rename include guard.
 625         * arch/arm-linux.h: Rename include guard.
 626         * arch/arm-get-next-pcs.h: Rename include guard.
 627         * arch/amd64.h: Add include guard.
 628         * arch/aarch64-insn.h: Rename include guard.
 629         * arch-utils.h: Rename include guard.
 630         * annotate.h: Add include guard.
 631         * amd64-darwin-tdep.h: Rename include guard.
 632         * aarch64-linux-tdep.h: Add include guard.
 633         * aarch64-fbsd-tdep.h: Add include guard.
 634         * aarch32-linux-nat.h: Add include guard.
 635
 636 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 637
 638         * macrotab.c (macro_define_internal): New function that
 639         factorizes macro_define_object_internal and macro_define_function
 640         code.
 641         (macro_define_object_internal): Use macro_define_internal.
 642         (macro_define_function): Likewise.
 643
 644 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 645
 646         * macrocmd.c (extract_identifier): Return
 647         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 648         callers.
 649
 650 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 651
 652         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 653
 654 2019-02-05  Tom Tromey  <tom@tromey.com>
 655
 656         * target.c (target_stack::unpush): Move assertion earlier.
 657
 658 2019-01-30  Tom Tromey  <tom@tromey.com>
 659
 660         PR python/23615:
 661         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 662         (gdbpy_parse_and_eval): Likewise.
 663         * python/python-internal.h (gdbpy_allow_threads): New class.
 664
 665 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 666
 667         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 668         (aarch64_fbsd_fpregmap): Move earlier.
 669         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 670         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 671         instead of individual calls to trad_frame_set_reg_addr.
 672         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 673         earlier.
 674         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 675         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 676         instead of individual calls to trad_frame_set_reg_addr.
 677
 678 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 679
 680         * CONTRIBUTE: Replace contribution list with wiki link.
 681
 682 2019-01-25  Tom Tromey  <tom@tromey.com>
 683
 684         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 685
 686 2019-01-25  Tom Tromey  <tom@tromey.com>
 687
 688         * xtensa-linux-nat.c: Fix common/ includes.
 689         * xml-support.h: Fix common/ includes.
 690         * xml-support.c: Fix common/ includes.
 691         * x86-linux-nat.c: Fix common/ includes.
 692         * windows-nat.c: Fix common/ includes.
 693         * varobj.h: Fix common/ includes.
 694         * varobj.c: Fix common/ includes.
 695         * value.c: Fix common/ includes.
 696         * valops.c: Fix common/ includes.
 697         * utils.c: Fix common/ includes.
 698         * unittests/xml-utils-selftests.c: Fix common/ includes.
 699         * unittests/utils-selftests.c: Fix common/ includes.
 700         * unittests/unpack-selftests.c: Fix common/ includes.
 701         * unittests/tracepoint-selftests.c: Fix common/ includes.
 702         * unittests/style-selftests.c: Fix common/ includes.
 703         * unittests/string_view-selftests.c: Fix common/ includes.
 704         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 705         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 706         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 707         * unittests/rsp-low-selftests.c: Fix common/ includes.
 708         * unittests/parse-connection-spec-selftests.c: Fix common/
 709         includes.
 710         * unittests/optional-selftests.c: Fix common/ includes.
 711         * unittests/offset-type-selftests.c: Fix common/ includes.
 712         * unittests/observable-selftests.c: Fix common/ includes.
 713         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 714         * unittests/memrange-selftests.c: Fix common/ includes.
 715         * unittests/memory-map-selftests.c: Fix common/ includes.
 716         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 717         * unittests/function-view-selftests.c: Fix common/ includes.
 718         * unittests/environ-selftests.c: Fix common/ includes.
 719         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 720         * unittests/common-utils-selftests.c: Fix common/ includes.
 721         * unittests/cli-utils-selftests.c: Fix common/ includes.
 722         * unittests/array-view-selftests.c: Fix common/ includes.
 723         * ui-file.c: Fix common/ includes.
 724         * tui/tui-io.c: Fix common/ includes.
 725         * tracepoint.h: Fix common/ includes.
 726         * tracepoint.c: Fix common/ includes.
 727         * tracefile-tfile.c: Fix common/ includes.
 728         * top.h: Fix common/ includes.
 729         * top.c: Fix common/ includes.
 730         * thread.c: Fix common/ includes.
 731         * target/waitstatus.h: Fix common/ includes.
 732         * target/waitstatus.c: Fix common/ includes.
 733         * target.h: Fix common/ includes.
 734         * target.c: Fix common/ includes.
 735         * target-memory.c: Fix common/ includes.
 736         * target-descriptions.c: Fix common/ includes.
 737         * symtab.h: Fix common/ includes.
 738         * symfile.c: Fix common/ includes.
 739         * stap-probe.c: Fix common/ includes.
 740         * spu-linux-nat.c: Fix common/ includes.
 741         * sparc-nat.c: Fix common/ includes.
 742         * source.c: Fix common/ includes.
 743         * solib.c: Fix common/ includes.
 744         * solib-target.c: Fix common/ includes.
 745         * ser-unix.c: Fix common/ includes.
 746         * ser-tcp.c: Fix common/ includes.
 747         * ser-pipe.c: Fix common/ includes.
 748         * ser-base.c: Fix common/ includes.
 749         * selftest-arch.c: Fix common/ includes.
 750         * s12z-tdep.c: Fix common/ includes.
 751         * rust-exp.y: Fix common/ includes.
 752         * rs6000-aix-tdep.c: Fix common/ includes.
 753         * riscv-tdep.c: Fix common/ includes.
 754         * remote.c: Fix common/ includes.
 755         * remote-notif.h: Fix common/ includes.
 756         * remote-fileio.h: Fix common/ includes.
 757         * remote-fileio.c: Fix common/ includes.
 758         * regcache.h: Fix common/ includes.
 759         * regcache.c: Fix common/ includes.
 760         * record-btrace.c: Fix common/ includes.
 761         * python/python.c: Fix common/ includes.
 762         * python/py-type.c: Fix common/ includes.
 763         * python/py-inferior.c: Fix common/ includes.
 764         * progspace.h: Fix common/ includes.
 765         * producer.c: Fix common/ includes.
 766         * procfs.c: Fix common/ includes.
 767         * proc-api.c: Fix common/ includes.
 768         * printcmd.c: Fix common/ includes.
 769         * ppc-linux-nat.c: Fix common/ includes.
 770         * parser-defs.h: Fix common/ includes.
 771         * osdata.c: Fix common/ includes.
 772         * obsd-nat.c: Fix common/ includes.
 773         * nat/x86-linux.c: Fix common/ includes.
 774         * nat/x86-linux-dregs.c: Fix common/ includes.
 775         * nat/x86-dregs.h: Fix common/ includes.
 776         * nat/x86-dregs.c: Fix common/ includes.
 777         * nat/ppc-linux.c: Fix common/ includes.
 778         * nat/mips-linux-watch.h: Fix common/ includes.
 779         * nat/mips-linux-watch.c: Fix common/ includes.
 780         * nat/linux-waitpid.c: Fix common/ includes.
 781         * nat/linux-ptrace.h: Fix common/ includes.
 782         * nat/linux-ptrace.c: Fix common/ includes.
 783         * nat/linux-procfs.c: Fix common/ includes.
 784         * nat/linux-personality.c: Fix common/ includes.
 785         * nat/linux-osdata.c: Fix common/ includes.
 786         * nat/linux-namespaces.c: Fix common/ includes.
 787         * nat/linux-btrace.h: Fix common/ includes.
 788         * nat/linux-btrace.c: Fix common/ includes.
 789         * nat/fork-inferior.c: Fix common/ includes.
 790         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 791         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 792         * nat/aarch64-linux.c: Fix common/ includes.
 793         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 794         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 795         * namespace.h: Fix common/ includes.
 796         * mips-linux-tdep.c: Fix common/ includes.
 797         * minsyms.c: Fix common/ includes.
 798         * mi/mi-parse.h: Fix common/ includes.
 799         * mi/mi-main.c: Fix common/ includes.
 800         * mi/mi-cmd-env.c: Fix common/ includes.
 801         * memrange.h: Fix common/ includes.
 802         * memattr.c: Fix common/ includes.
 803         * maint.h: Fix common/ includes.
 804         * maint.c: Fix common/ includes.
 805         * main.c: Fix common/ includes.
 806         * machoread.c: Fix common/ includes.
 807         * location.c: Fix common/ includes.
 808         * linux-thread-db.c: Fix common/ includes.
 809         * linux-nat.c: Fix common/ includes.
 810         * linux-fork.c: Fix common/ includes.
 811         * inline-frame.c: Fix common/ includes.
 812         * infrun.c: Fix common/ includes.
 813         * inflow.c: Fix common/ includes.
 814         * inferior.h: Fix common/ includes.
 815         * inferior.c: Fix common/ includes.
 816         * infcmd.c: Fix common/ includes.
 817         * inf-ptrace.c: Fix common/ includes.
 818         * inf-child.c: Fix common/ includes.
 819         * ia64-linux-nat.c: Fix common/ includes.
 820         * i387-tdep.c: Fix common/ includes.
 821         * i386-tdep.c: Fix common/ includes.
 822         * i386-linux-tdep.c: Fix common/ includes.
 823         * i386-linux-nat.c: Fix common/ includes.
 824         * i386-go32-tdep.c: Fix common/ includes.
 825         * i386-fbsd-tdep.c: Fix common/ includes.
 826         * i386-fbsd-nat.c: Fix common/ includes.
 827         * guile/scm-type.c: Fix common/ includes.
 828         * guile/guile.c: Fix common/ includes.
 829         * go32-nat.c: Fix common/ includes.
 830         * gnu-nat.c: Fix common/ includes.
 831         * gdbthread.h: Fix common/ includes.
 832         * gdbarch-selftests.c: Fix common/ includes.
 833         * gdb_usleep.c: Fix common/ includes.
 834         * gdb_select.h: Fix common/ includes.
 835         * gdb_bfd.c: Fix common/ includes.
 836         * gcore.c: Fix common/ includes.
 837         * fork-child.c: Fix common/ includes.
 838         * findvar.c: Fix common/ includes.
 839         * fbsd-nat.c: Fix common/ includes.
 840         * event-top.c: Fix common/ includes.
 841         * event-loop.c: Fix common/ includes.
 842         * dwarf2read.c: Fix common/ includes.
 843         * dwarf2loc.c: Fix common/ includes.
 844         * dwarf2-frame.c: Fix common/ includes.
 845         * dwarf-index-cache.c: Fix common/ includes.
 846         * dtrace-probe.c: Fix common/ includes.
 847         * disasm-selftests.c: Fix common/ includes.
 848         * defs.h: Fix common/ includes.
 849         * csky-tdep.c: Fix common/ includes.
 850         * cp-valprint.c: Fix common/ includes.
 851         * cp-support.h: Fix common/ includes.
 852         * cp-support.c: Fix common/ includes.
 853         * corelow.c: Fix common/ includes.
 854         * completer.h: Fix common/ includes.
 855         * completer.c: Fix common/ includes.
 856         * compile/compile.c: Fix common/ includes.
 857         * compile/compile-loc2c.c: Fix common/ includes.
 858         * compile/compile-cplus-types.c: Fix common/ includes.
 859         * compile/compile-cplus-symbols.c: Fix common/ includes.
 860         * command.h: Fix common/ includes.
 861         * cli/cli-dump.c: Fix common/ includes.
 862         * cli/cli-cmds.c: Fix common/ includes.
 863         * charset.c: Fix common/ includes.
 864         * build-id.c: Fix common/ includes.
 865         * btrace.h: Fix common/ includes.
 866         * btrace.c: Fix common/ includes.
 867         * breakpoint.h: Fix common/ includes.
 868         * breakpoint.c: Fix common/ includes.
 869         * ax.h:
 870         (enum agent_op): Fix common/ includes.
 871         * ax-general.c (struct aop_map): Fix common/ includes.
 872         * ax-gdb.c: Fix common/ includes.
 873         * auxv.c: Fix common/ includes.
 874         * auto-load.c: Fix common/ includes.
 875         * arm-tdep.c: Fix common/ includes.
 876         * arch/riscv.c: Fix common/ includes.
 877         * arch/ppc-linux-common.c: Fix common/ includes.
 878         * arch/i386.c: Fix common/ includes.
 879         * arch/arm.c: Fix common/ includes.
 880         * arch/arm-linux.c: Fix common/ includes.
 881         * arch/arm-get-next-pcs.c: Fix common/ includes.
 882         * arch/amd64.c: Fix common/ includes.
 883         * arch/aarch64.c: Fix common/ includes.
 884         * arch/aarch64-insn.c: Fix common/ includes.
 885         * arch-utils.c: Fix common/ includes.
 886         * amd64-windows-tdep.c: Fix common/ includes.
 887         * amd64-tdep.c: Fix common/ includes.
 888         * amd64-sol2-tdep.c: Fix common/ includes.
 889         * amd64-obsd-tdep.c: Fix common/ includes.
 890         * amd64-nbsd-tdep.c: Fix common/ includes.
 891         * amd64-linux-tdep.c: Fix common/ includes.
 892         * amd64-linux-nat.c: Fix common/ includes.
 893         * amd64-fbsd-tdep.c: Fix common/ includes.
 894         * amd64-fbsd-nat.c: Fix common/ includes.
 895         * amd64-dicos-tdep.c: Fix common/ includes.
 896         * amd64-darwin-tdep.c: Fix common/ includes.
 897         * agent.c: Fix common/ includes.
 898         * ada-lang.h: Fix common/ includes.
 899         * ada-lang.c: Fix common/ includes.
 900         * aarch64-tdep.c: Fix common/ includes.
 901
 902 2019-01-25  Tom Tromey  <tom@tromey.com>
 903
 904         * common/create-version.sh: Use common/version.h.
 905
 906 2019-01-24  Pedro Alves  <palves@redhat.com>
 907
 908         * infrun.c (signal_stop, signal_print, signal_program)
 909         (signal_catch, signal_pass): Now arrays instead of pointers.
 910         (update_signals_program_target, do_target_resume)
 911         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 912         * linux-nat.c (linux_nat_target::pass_signals)
 913         (linux_nat_target::create_inferior, linux_nat_target::attach):
 914         Adjust.
 915         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 916         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 917         * procfs.c (procfs_target::pass_signals): Adjust.
 918         * record-full.c (record_full_target::resume): Adjust.
 919         * remote.c (remote_target::pass_signals)
 920         (remote_target::program_signals): Adjust.
 921         * target-debug.h (target_debug_print_signals): Now takes a
 922         gdb::array_view as parameter.  Adjust.
 923         * target.h (target_ops) <pass_signals, program_signals>: Replace
 924         pointer and length parameters with gdb::array_view.
 925         (target_pass_signals, target_program_signals): Likewise.
 926         * target-delegates.c: Regenerate.
 927
 928 2019-01-24  Pedro Alves  <palves@redhat.com>
 929
 930         * common/forward-scope-exit.h
 931         (forward_scope_exit::forward_scope_exit): Pass arguments to
 932         m_bind_function directly, instead of creating a std::bind and
 933         copying that.
 934
 935 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 936
 937         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 938         for static members.
 939         (pass_in_v_vfp_candidate): Likewise.
 940
 941 2019-01-23  Tom Tromey  <tom@tromey.com>
 942             Pedro Alves  <palves@redhat.com>
 943
 944         * regcache.c (class regcache_invalidator): Remove.
 945         (regcache::raw_write): Use make_scope_exit.
 946
 947 2019-01-23  Tom Tromey  <tom@tromey.com>
 948
 949         * ui-out.h (class ui_out_emit_type): Update comment.
 950
 951 2019-01-23  Tom Tromey  <tom@tromey.com>
 952
 953         * infrun.c (fetch_inferior_event): Update comment.
 954
 955 2019-01-23  Tom Tromey  <tom@tromey.com>
 956             Pedro Alves  <palves@redhat.com>
 957
 958         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 959         parameter.
 960         (fetch_inferior_event): Use SCOPE_EXIT.
 961
 962
 963 2019-01-23  Tom Tromey  <tom@tromey.com>
 964             Pedro Alves  <palves@redhat.com>
 965
 966         * infrun.c (disable_thread_events): Delete.
 967         (stop_all_threads): Use SCOPE_EXIT.
 968
 969 2019-01-23  Tom Tromey  <tom@tromey.com>
 970             Pedro Alves  <palves@redhat.com>
 971
 972         * symfile.c: Include forward-scope-exit.h.
 973         (clear_symtab_users_cleanup): Replace forward declaration with
 974         a FORWARD_SCOPE_EXIT.
 975         (syms_from_objfile_1): Use the forward_scope_exit and
 976         gdb::optional instead of cleanup_function.
 977         (reread_symbols): Use the forward_scope_exit instead of
 978         cleanup_function.
 979         (clear_symtab_users_cleanup): Remove function.
 980
 981 2019-01-23  Tom Tromey  <tom@tromey.com>
 982             Pedro Alves  <palves@redhat.com>
 983
 984         * linux-nat.c: Include scope-exit.h.
 985         (cleanup_target_stop): Remove.
 986         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 987         SCOPE_EXIT.
 988
 989 2019-01-23  Tom Tromey  <tom@tromey.com>
 990             Pedro Alves  <palves@redhat.com>
 991
 992         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 993         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 994
 995 2019-01-23  Tom Tromey  <tom@tromey.com>
 996             Andrew Burgess  <andrew.burgess@embecosm.com>
 997             Pedro Alves  <palves@redhat.com>
 998
 999         * infrun.c (fetch_inferior_event): Use scope_exit.
1000         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1001         * top.c (execute_command): Use scope_exit.
1002         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1003         * utils.c (do_bpstat_clear_actions_cleanup)
1004         (make_bpstat_clear_actions_cleanup): Remove.
1005
1006 2019-01-23  Tom Tromey  <tom@tromey.com>
1007             Pedro Alves  <palves@redhat.com>
1008
1009         * infrun.c: Include "common/scope-exit.h"
1010         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1011         (wait_for_inferior): Use SCOPE_EXIT.
1012         (fetch_inferior_event): Use scope_exit.
1013
1014 2019-01-23  Tom Tromey  <tom@tromey.com>
1015             Pedro Alves  <palves@redhat.com>
1016
1017         * breakpoint.c (create_breakpoint): Remove cleanup.
1018
1019 2019-01-23  Tom Tromey  <tom@tromey.com>
1020             Andrew Burgess  <andrew.burgess@embecosm.com>
1021             Pedro Alves  <palves@redhat.com>
1022
1023 2019-01-23  Pedro Alves  <palves@redhat.com>
1024
1025         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1026
1027 2019-01-23  Pedro Alves  <palves@redhat.com>
1028             Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * gdbthread.h: Include "common/forward-scope-exit.h".
1031         (scoped_finish_thread_state): Redefine custom class in terms of
1032         forward_scope_exit.
1033
1034 2019-01-23  Pedro Alves  <palves@redhat.com>
1035             Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * common/forward-scope-exit.h: New file.
1038
1039 2019-01-23  Pedro Alves  <palves@redhat.com>
1040             Andrew Burgess  <andrew.burgess@embecosm.com>
1041             Tom Tromey  <tom@tromey.com>
1042
1043         * common/scope-exit.h: New file.
1044
1045 2019-01-23  Pedro Alves  <palves@redhat.com>
1046
1047         * common/preprocessor.h (ESC): Rename to ...
1048         (ESC_PARENS): ... this.
1049         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1050         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1051
1052 2019-01-23  Tom Tromey  <tom@tromey.com>
1053
1054         * language.h (class scoped_switch_to_sym_language_if_auto):
1055         Initialize m_lang in both cases.
1056
1057 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1058
1059         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1060         with XCNEW.
1061
1062 2019-01-22  Tom Tromey  <tom@tromey.com>
1063
1064         * corelow.c: Do not include sys/file.h.
1065
1066 2019-01-22  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-wingeneral.h: Include gdb_curses.h.
1069
1070 2019-01-22  Tom Tromey  <tom@tromey.com>
1071
1072         * source-cache.h (class source_cache) <get_source_lines,
1073         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1074
1075 2019-01-22  Tom Tromey  <tom@tromey.com>
1076
1077         * remote-fileio.h (struct remote_target): Declare.
1078
1079 2019-01-22  Tom Tromey  <tom@tromey.com>
1080
1081         * python/py-arch.c: Do not include py-ref.h.
1082         * python/py-bpevent.c: Do not include py-ref.h.
1083         * python/py-cmd.c: Do not include py-ref.h.
1084         * python/py-continueevent.c: Do not include py-ref.h.
1085         * python/py-event.h: Do not include py-ref.h.
1086         * python/py-evtregistry.c: Do not include py-ref.h.
1087         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1088         * python/py-frame.c: Do not include py-ref.h.
1089         * python/py-framefilter.c: Do not include py-ref.h.
1090         * python/py-function.c: Do not include py-ref.h.
1091         * python/py-infevents.c: Do not include py-ref.h.
1092         * python/py-linetable.c: Do not include py-ref.h.
1093         * python/py-objfile.c: Do not include py-ref.h.
1094         * python/py-param.c: Do not include py-ref.h.
1095         * python/py-prettyprint.c: Do not include py-ref.h.
1096         * python/py-progspace.c: Do not include py-ref.h.
1097         * python/py-symbol.c: Do not include py-ref.h.
1098         * python/py-symtab.c: Do not include py-ref.h.
1099         * python/py-type.c: Do not include py-ref.h.
1100         * python/py-unwind.c: Do not include py-ref.h.
1101         * python/py-utils.c: Do not include py-ref.h.
1102         * python/py-value.c: Do not include py-ref.h.
1103         * python/py-varobj.c: Do not include py-ref.h.
1104         * python/py-xmethods.c: Do not include py-ref.h.
1105         * python/python.c: Do not include py-ref.h.
1106         * varobj.c: Do not include py-ref.h.
1107
1108 2019-01-22  Tom Tromey  <tom@tromey.com>
1109
1110         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1111         keyword for bcache.
1112
1113 2019-01-22  Tom Tromey  <tom@tromey.com>
1114
1115         * compile/compile-cplus-types.c: Remove a comment by #include.
1116
1117 2019-01-22  Tom Tromey  <tom@tromey.com>
1118
1119         * compile/gcc-c-plugin.h: Include compile-internal.h.
1120
1121 2019-01-22  Tom Tromey  <tom@tromey.com>
1122
1123         * stabsread.c (EXTERN): Do not define.
1124         (symnum, next_symbol_text_func, processing_gcc_compilation)
1125         (within_function, global_sym_chain, global_stabs)
1126         (previous_stab_code, this_object_header_files)
1127         (n_this_object_header_files)
1128         (n_allocated_this_object_header_files): Define.
1129         * stabsread.h (EXTERN): Never define.  Use "extern".
1130
1131 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1132
1133         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1134         history_value.
1135
1136 2019-01-21  Tom Tromey  <tom@tromey.com>
1137
1138         * ui-out.c: Fix includes.
1139         * tui/tui-source.c: Fix includes.
1140         * target.c: Fix includes.
1141         * remote.c: Fix includes.
1142         * regcache.c: Fix includes.
1143         * python/py-block.c: Fix includes.
1144         * printcmd.c: Fix includes.
1145         * or1k-tdep.c: Fix includes.
1146         * mi/mi-main.c: Fix includes.
1147         * m32r-tdep.c: Fix includes.
1148         * csky-tdep.c: Fix includes.
1149         * compile/compile-cplus-types.c: Fix includes.
1150         * cli/cli-interp.c: Fix includes.
1151
1152 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1153
1154         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1155         for padding.
1156
1157 2019-01-16  Tom Tromey  <tom@tromey.com>
1158
1159         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1160         earlier.
1161         (struct objfile) <msymbols_range>: Move from top level.
1162         <msymbols>: New method.
1163         (class objfile_msymbols): Remove.
1164         * symtab.c (default_collect_symbol_completion_matches_break_on):
1165         Update.
1166         * symmisc.c (dump_msymbols): Update.
1167         * stabsread.c (scan_file_globals): Update.
1168         * objc-lang.c (info_selectors_command, info_classes_command)
1169         (find_methods): Update.
1170         * minsyms.c (find_solib_trampoline_target): Update.
1171         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1172         * coffread.c (coff_symfile_read): Update.
1173         * ada-lang.c (ada_lookup_simple_minsym)
1174         (ada_collect_symbol_completion_matches): Update.
1175
1176 2019-01-16  Tom Tromey  <tom@tromey.com>
1177
1178         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1179         type.  Remove no-argument constructor.
1180         <iterator::operator++>: Simplify.
1181         <begin>: Update.
1182         <end>: Use minimal_symbol_count.
1183
1184 2019-01-16  Tom Tromey  <tom@tromey.com>
1185
1186         * objfiles.h (struct objfile) <psymtabs>: New method.
1187         (class objfile_psymtabs): Remove.
1188         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1189         typedef.
1190         <range>: New method.
1191         (require_partial_symbols): Change return type.
1192         * psymtab.c (require_partial_symbols)
1193         (psym_expand_symtabs_matching): Update.
1194         * mdebugread.c (parse_partial_symbols): Update.
1195         * dbxread.c (dbx_end_psymtab): Update.
1196
1197 2019-01-15  Tom Tromey  <tom@tromey.com>
1198
1199         * symtab.c (lookup_objfile_from_block)
1200         (lookup_symbol_in_objfile_symtabs)
1201         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1202         (find_line_symtab, info_sources_command)
1203         (default_collect_symbol_completion_matches_break_on)
1204         (make_source_files_completion_list): Update.
1205         * symmisc.c (print_objfile_statistics, dump_objfile)
1206         (maintenance_print_symbols, maintenance_info_symtabs)
1207         (maintenance_check_symtabs, maintenance_info_line_tables):
1208         Update.
1209         * source.c (select_source_symtab)
1210         (forget_cached_source_info_for_objfile): Update.
1211         * objfiles.h (class objfile_compunits): Remove.
1212         (struct objfile) <compunits_range>: New typedef.
1213         (compunits): New method.
1214         * objfiles.c (objfile_relocate1): Update.
1215         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1216         * maint.c (count_symtabs_and_blocks): Update.
1217         * linespec.c (iterate_over_all_matching_symtabs): Update.
1218         * cp-support.c (add_symbol_overload_list_qualified): Update.
1219         * coffread.c (coff_symtab_read): Update.
1220         * ada-lang.c (add_nonlocal_symbols)
1221         (ada_collect_symbol_completion_matches)
1222         (ada_add_global_exceptions): Update.
1223
1224 2019-01-15  Tom Tromey  <tom@tromey.com>
1225
1226         * progspace.h (program_space) <objfiles_safe_range>: New
1227         typedef.
1228         <objfiles_safe>: New method.
1229         * objfiles.h (class all_objfiles_safe): Remove.
1230         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1231         * jit.c (jit_inferior_exit_hook): Update.
1232
1233 2019-01-17  Tom Tromey  <tom@tromey.com>
1234
1235         * progspace.h (program_space) <objfiles_range>: New typedef.
1236         <objfiles>: New method.
1237         <objfiles_head>: Rename from objfiles.
1238         (object_files): Update.
1239         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1240         * guile/scm-pretty-print.c
1241         (ppscm_find_pretty_printer_from_objfiles): Update.
1242         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1243         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1244         Update.
1245         * python/py-progspace.c (pspy_get_objfiles): Update.
1246         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1247         Update.
1248         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1249         (objfpy_lookup_objfile_by_build_id): Update.
1250         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1251         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1252         Update.
1253         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1254         (expand_symtab_containing_pc, lookup_objfile_from_block)
1255         (lookup_static_symbol, basic_lookup_transparent_type)
1256         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1257         (find_line_symtab, info_sources_command)
1258         (default_collect_symbol_completion_matches_break_on)
1259         (make_source_files_completion_list, find_main_name): Update.
1260         * symmisc.c (print_symbol_bcache_statistics)
1261         (print_objfile_statistics, maintenance_print_symbols)
1262         (maintenance_print_msymbols, maintenance_print_objfiles)
1263         (maintenance_info_symtabs, maintenance_check_symtabs)
1264         (maintenance_expand_symtabs, maintenance_info_line_tables):
1265         Update.
1266         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1267         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1268         (map_overlay_command, unmap_overlay_command)
1269         (simple_overlay_update, expand_symtabs_matching)
1270         (map_symbol_filenames): Update.
1271         * symfile-debug.c (set_debug_symfile): Update.
1272         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1273         Update.
1274         * source.c (select_source_symtab, forget_cached_source_info):
1275         Update.
1276         * solib.c (solib_read_symbols): Update.
1277         * solib-spu.c (append_ocl_sos): Update.
1278         * psymtab.c (maintenance_print_psymbols)
1279         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1280         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1281         * printcmd.c (info_symbol_command): Update.
1282         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1283         Update.
1284         * objfiles.h (class all_objfiles): Remove.
1285         * objfiles.c (have_partial_symbols, have_full_symbols)
1286         (have_minimal_symbols, qsort_cmp, update_section_map)
1287         (shared_objfile_contains_address_p)
1288         (default_iterate_over_objfiles_in_search_order): Update.
1289         * objc-lang.c (info_selectors_command, info_classes_command)
1290         (find_methods): Update.
1291         * minsyms.c (find_solib_trampoline_target): Update.
1292         * maint.c (maintenance_info_sections)
1293         (maintenance_translate_address, count_symtabs_and_blocks):
1294         Update.
1295         * main.c (captured_main_1): Update.
1296         * linux-thread-db.c (try_thread_db_load_from_pdir)
1297         (has_libpthread): Update.
1298         * linespec.c (iterate_over_all_matching_symtabs)
1299         (search_minsyms_for_name): Update.
1300         * jit.c (jit_find_objf_with_entry_addr): Update.
1301         * hppa-tdep.c (find_unwind_entry)
1302         (hppa_lookup_stub_minimal_symbol): Update.
1303         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1304         Update.
1305         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1306         (elf_gnu_ifunc_resolve_by_got): Update.
1307         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1308         * dwarf-index-write.c (save_gdb_index_command): Update.
1309         * cp-support.c (add_symbol_overload_list_qualified): Update.
1310         * breakpoint.c (create_overlay_event_breakpoint)
1311         (create_longjmp_master_breakpoint)
1312         (create_std_terminate_master_breakpoint)
1313         (create_exception_master_breakpoint): Update.
1314         * blockframe.c (find_pc_partial_function): Update.
1315         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1316         (ada_collect_symbol_completion_matches)
1317         (ada_add_global_exceptions): Update.
1318
1319 2019-01-17  Tom Tromey  <tom@tromey.com>
1320
1321         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1322         declare VEC.
1323         (solib_target_parse_libraries): Change return type.
1324         (library_list_start_segment, library_list_start_section)
1325         (library_list_end_library, library_list_start_library); Update.
1326         (solib_target_free_library_list): Remove.
1327         (solib_target_parse_libraries): Remove cleanup.  Change return
1328         type.
1329         (solib_target_current_sos): Update.
1330
1331 2019-01-17  Tom Tromey  <tromey@bapiya>
1332
1333         * valprint.c: Replace "the the" with "the".
1334         * symtab.c: Replace "the the" with "the".
1335         * solib.c: Replace "the the" with "the".
1336         * solib-dsbt.c: Replace "the the" with "the".
1337         * linespec.c: Replace "the the" with "the".
1338         * dwarf2loc.h: Replace "the the" with "the".
1339         * amd64-windows-tdep.c: Replace "the the" with "the".
1340         * aarch64-tdep.c: Replace "the the" with "the".
1341
1342 2019-01-16  Keith Seitz  <keiths@redhat.com>
1343
1344         PR gdb/23773
1345         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1346         <builder>: Rename to ..
1347         <m_builder>: ... this and make private.
1348         (dwarf2_cu::get_builder): New method.  Change all users of
1349         `builder' to use this method.
1350         (dwarf2_start_symtab): Move to ...
1351         (dwarf2_cu::start_symtab): ... here.  Update all callers
1352         (setup_type_unit_groups): Move to ...
1353         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1354         callers.
1355         (dwarf2_cu::reset_builder): New method.
1356         (process_full_compunit, process_full_type_unit): Use
1357         dwarf2_cu::reset_builder.
1358         (follow_die_offset): Record the ancestor CU if it is different
1359         from the followed DIE's CU.
1360         (follow_die_sig_1): Likewise.
1361
1362 2019-01-15  Tom Tromey  <tom@tromey.com>
1363
1364         * remote.c (class remote_state) <buf>: Now a char_vector.
1365         <buf_size>: Remove.
1366         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1367         parameter.
1368         (remote_target::getpkt_or_notif_sane_1)
1369         (remote_target::getpkt_sane)
1370         (remote_target::getpkt_or_notif_sane): Likewise.
1371         (class remote_target) <putpkt>: New overload.
1372         (remote_target::read_frame): Change type of "buf_p".  Remove
1373         sizeof_p parameter.
1374         (packet_ok): New overload.
1375         (packet_check_result): New overload.
1376         Update all uses.
1377
1378 2019-01-14  Tom Tromey  <tom@tromey.com>
1379
1380         * remote-notif.c (handle_notification, remote_notif_ack)
1381         (remote_notif_parse): Make "buf" const.
1382         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1383         const.
1384         (remote_notif_parse, remote_notif_ack, handle_notification):
1385         Likewise.
1386         * remote.c (remote_notif_stop_parse): Make "buf" const.
1387         (remote_target::remote_parse_stop_reply): Make "buf" const.
1388         (remote_notif_stop_ack): Make "buf" const.
1389
1390 2019-01-14  Tom Tromey  <tom@tromey.com>
1391
1392         * remote.c (remote_console_output): Make parameter const.
1393
1394 2019-01-14  Tom Tromey  <tom@tromey.com>
1395
1396         * target-debug.h (target_debug_print_signals): Constify.
1397         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1398         * procfs.c (procfs_target::pass_signals): Update.
1399         * linux-nat.c (linux_nat_target::pass_signals): Update.
1400         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1401         * target-delegates.c: Rebuild.
1402         * remote.c (remote_target::program_signals): Update.
1403         (remote_target::pass_signals): Update.
1404         * target.c (target_pass_signals): Constify argument.
1405         (target_program_signals): Likewise.
1406         * target.h (struct target_ops) <pass_signals, program_signals>:
1407         Constify argument.
1408         (target_pass_signals, target_program_signals): Constify argument.
1409
1410 2019-01-14  Tom Tromey  <tom@tromey.com>
1411
1412         PR tui/28819:
1413         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1414
1415 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1416
1417         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1418         field.
1419         * rs6000-tdep.c: Include reggroups.h.
1420         (IS_V_ALIAS_PSEUDOREG): Define.
1421         (rs6000_register_name): Return names for the "vX" aliases.
1422         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1423         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1424         aliases.  Call default_register_reggroup_p for all other
1425         pseudo-registers.
1426         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1427         New functions.
1428         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1429         Handle "vX" aliases.
1430         (v_alias_pseudo_register_collect): New function.
1431         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1432         (rs6000_gdbarch_init): Initialize "vX" aliases as
1433         pseudo-registers.  Restore registration of
1434         rs6000_pseudo_register_reggroup_p with
1435         set_tdesc_pseudo_register_reggroup_p.
1436
1437 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1438
1439         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1440         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1441         set_gdbarch_num_pseudo_regs.
1442
1443 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1444
1445         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1446         Remove arg prefixname, add do_set and do_show.
1447         Add member functions set_list and show_list.
1448         * cli/cli-style.c (class cli_style_option): Update accordingly.
1449         (style_set_list): Move to file scope.
1450         (style_show_list): Likewise.
1451         (set_style): Call help_list.
1452         (show_style): Call cmd_show_list.
1453         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1454         Update to use the new macro.
1455
1456 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1457
1458         * ada-lang.c (_initialize_ada_language): Expand the help text
1459         for the "catch exception" command.
1460
1461 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1462
1463         * symtab.c (matching_obj_sections): Initialize obj,
1464         declare it closer to its usage.
1465
1466 2019-01-10  Tom Tromey  <tom@tromey.com>
1467
1468         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1469         (basic_inf_threads_range): Remove.
1470         (inf_threads_range, inf_non_exited_threads_range)
1471         (safe_inf_threads_range): Use next_adapter.
1472
1473 2019-01-10  Keith Seitz  <keiths@redhat.com>
1474
1475         PR gdb/23712
1476         PR symtab/23010
1477         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1478         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1479
1480 2019-01-10  Keith Seitz  <keiths@redhat.com>
1481
1482         PR gdb/23712
1483         PR symtab/23010
1484         * dictionary.c (pending_to_vector): Remove.
1485         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1486         Remove _1 suffix, replacing functions of the same name.  Update
1487         all callers.
1488         (dict_create_hashed, dict_create_hashed_expandable)
1489         (dict_create_linear, dict_create_linear_expandable, dict_free)
1490         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1491         Make functions static.
1492
1493 2019-01-10  Keith Seitz  <keiths@redhat.com>
1494
1495         PR gdb/23712
1496         PR symtab/23010
1497         * dictionary.h (struct dictionary): Replace declaration with
1498         multidictionary.
1499         (dict_create_hashed, dict_create_hashed_expandable)
1500         (dict_create_linear, dict_create_linear_expandable)
1501         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1502         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1503         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1504         taking multidictionary argument.
1505         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1506         * block.h (struct block) <dict>: Change to multidictionary
1507         and rename `multidict'.
1508         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1509         symmisc.c: Update all dictionary references to multidictionary.
1510
1511 2019-01-10  Keith Seitz  <keiths@redhat.com>
1512
1513         PR gdb/23712
1514         PR symtab/23010
1515         * dictionary.c: Include unordered_map.
1516         (pending_to_vector): New function.
1517         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1518         Rewrite the non-"_1" functions to take vector instead
1519         of linked list.
1520         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1521         "new" _1 versions of the same name.
1522         (multidictionary): Define.
1523         (std::hash<enum language): New definition.
1524         (collate_pending_symbols_by_language, mdict_create_hashed)
1525         (mdict_create_hashed_expandable, mdict_create_linear)
1526         (mdict_create_linear_expandable, mdict_free)
1527         (find_language_dictionary, create_new_language_dictionary)
1528         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1529         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1530         (mdict_size, mdict_empty): New functions.
1531         * dictionary.h (mdict_iterator): Define.
1532
1533 2019-01-10  Pedro Alves  <palves@redhat.com>
1534
1535         * breakpoint.c (read_uploaded_action)
1536         (create_tracepoint_from_upload): Adjust to use
1537         gdb::unique_xmalloc_ptr.
1538         * ctf.c (ctf_write_uploaded_tp):
1539         (SET_ARRAY_FIELD): Use emplace_back.
1540         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1541         * tracefile-tfile.c (tfile_write_uploaded_tp):
1542         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1543         gdb::unique_xmalloc_ptr.
1544         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1545         at_string, cond_string, cmd_strings>: Replace char pointers
1546         with gdb::unique_xmalloc_ptr.
1547
1548 2019-01-10  Pedro Alves  <palves@redhat.com>
1549
1550         * solib-target.c (library_list_start_library): Don't xstrdup name.
1551
1552 2019-01-10  Pedro Alves  <palves@redhat.com>
1553
1554         * mdebugread.c (parse_partial_symbols): Use
1555         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1556
1557 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * linux-fork.c (scoped_switch_fork_info)
1560         <~scoped_switch_fork_info>: Fix incorrect variable name.
1561
1562 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * linux-fork.c (scoped_switch_fork_info)
1565         <scoped_switch_fork_info>: Make explicit.
1566         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1567
1568 2019-01-10  Tom Tromey  <tom@tromey.com>
1569
1570         * objfiles.h (objfile::reset_psymtabs): Update.
1571         * objfiles.c (objfile::objfile): Update.
1572         * psymtab.h (psymtab_storage::obstack): Update.
1573         (psymtab_storage::m_obstack): Use gdb::optional.
1574         (class psymtab_storage): Update comment.  Remove objfile
1575         parameter.
1576         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1577
1578 2019-01-10  Tom Tromey  <tom@tromey.com>
1579
1580         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1581         <free_psymtabs>: Now private.
1582         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1583         (allocate_psymtab): Use new method.
1584
1585 2019-01-10  Tom Tromey  <tom@tromey.com>
1586
1587         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1588         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1589         * mdebugread.c (parse_partial_symbols): Use
1590         allocate_dependencies.
1591         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1592         allocate_dependencies.
1593         (process_psymtab_comp_unit_reader)
1594         (build_type_psymtab_dependencies): Likewise.
1595         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1596
1597 2019-01-10  Tom Tromey  <tom@tromey.com>
1598
1599         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1600         PSYMBOL_SET_LANGUAGE.
1601         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1602
1603 2019-01-10  Tom Tromey  <tom@tromey.com>
1604
1605         * psymtab.h (psymtab_storage::obstack): New method.
1606         <m_obstack>: Rename from obstack; now private.
1607         * psymtab.c (psymtab_storage): Update.
1608         * dwarf2read.c (create_addrmap_from_index)
1609         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1610         Update.
1611
1612 2019-01-10  Tom Tromey  <tom@tromey.com>
1613
1614         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1615         * objfiles.h (objfile::reset_psymtabs): New method.
1616
1617 2019-01-10  Tom Tromey  <tom@tromey.com>
1618
1619         * symmisc.c (print_symbol_bcache_statistics): Update.
1620         (print_objfile_statistics): Update.
1621         * symfile.c (reread_symbols): Update.
1622         * psymtab.h (class psymtab_storage): New.
1623         * psymtab.c (psymtab_storage): New constructor.
1624         (~psymtab_storage): New destructor.
1625         (require_partial_symbols): Update.
1626         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1627         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1628         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1629         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1630         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1631         (start_psymtab_common, end_psymtab_common)
1632         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1633         (allocate_psymtab): Update.
1634         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1635         Update.
1636         (dump_psymtab_addrmap, maintenance_print_psymbols)
1637         (maintenance_check_psymtabs): Update.
1638         (class objfile_psymtabs): Move to objfiles.h.
1639         * psympriv.h (discard_psymtab): Now inline.
1640         (psymtab_discarder::psymtab_discarder): Update.
1641         (psymtab_discarder::~psymtab_discarder): Update.
1642         (ALL_OBJFILE_PSYMTABS): Rewrite.
1643         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1644         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1645         Remove fields.
1646         <partial_symtabs>: New field.
1647         (class objfile_psymtabs): Move from psymtab.h.  Update.
1648         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1649         psymbol_cache.
1650         (objfile::~objfile): Don't destroy psymbol_cache.
1651         * mdebugread.c (parse_partial_symbols): Update.
1652         * dwarf2read.c (create_addrmap_from_index)
1653         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1654         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1655         (add_partial_subprogram, dwarf2_ranges_read): Update.
1656         * dwarf-index-write.c (write_address_map)
1657         (write_one_signatured_type, recursively_write_psymbols)
1658         (class debug_names, class debug_names, write_psymtabs_to_index):
1659         Update.
1660
1661 2019-01-10  Tom Tromey  <tom@tromey.com>
1662
1663         * symtab.h (SYMBOL_SET_NAMES): Update.
1664         (symbol_set_names): Update.
1665         (MSYMBOL_SET_NAMES): Update.
1666         * symtab.c (symbol_set_names): Change argument to be an
1667         objfile_per_bfd_storage.
1668         * psymtab.c (add_psymbol_to_bcache): Update.
1669         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1670
1671 2019-01-10  Tom Tromey  <tom@tromey.com>
1672
1673         * symtab.c (create_demangled_names_hash): Change argument to be an
1674         objfile_per_bfd_storage.
1675         (symbol_set_names): Update.
1676
1677 2019-01-10  Tom Tromey  <tom@tromey.com>
1678
1679         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1680         init_psymbol_list.
1681         * psymtab.c (init_psymbol_list): Do nothing if already called.
1682         * psympriv.h (init_psymbol_list): Add comment.
1683         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1684         init_psymbol_list.
1685         * dbxread.c (dbx_symfile_read): Unconditionally call
1686         init_psymbol_list.
1687
1688 2019-01-10  Tom Tromey  <tom@tromey.com>
1689
1690         * xcoffread.c (scan_xcoff_symtab): Update.
1691         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1692         "where".
1693         * mdebugread.c (parse_partial_symbols)
1694         (handle_psymbol_enumerators): Update.
1695         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1696         * dbxread.c (read_dbx_symtab): Update.
1697         * psympriv.h (psymbol_placement): New enum.
1698         (add_psymbol_to_list): Update.
1699
1700 2019-01-10  Tom Tromey  <tom@tromey.com>
1701
1702         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1703         static_psymbols parameters.
1704         (scan_xcoff_symtab): Update.
1705         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1706         static_psymbols parameters.
1707         * psympriv.h (start_psymtab_common): Update.
1708         * mdebugread.c (parse_partial_symbols): Update.
1709         * dwarf2read.c (create_partial_symtab): Update.
1710         * dbxread.c (read_dbx_symtab): Update.
1711         (start_psymtab): Remove global_psymbols and static_psymbols
1712         parameters.
1713
1714 2019-01-10  Tom Tromey  <tom@tromey.com>
1715
1716         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1717         * psymtab.c (allocate_psymtab): Add comment.
1718         * psympriv.h (allocate_psymtab): Add comment.
1719         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1720         initializations.
1721         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1722
1723 2019-01-10  Tom Tromey  <tom@tromey.com>
1724
1725         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1726         Don't declare.
1727         * mipsread.c: Include mdebugread.h.
1728         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1729         Declare.
1730         * elfread.c: Include mdebugread.h.
1731
1732 2019-01-09  Tom Tromey  <tom@tromey.com>
1733
1734         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1735         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1736         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1737         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1738         (psym_lookup_symbol, psym_find_last_source_symtab)
1739         (psym_forget_cached_source_info, psym_print_stats)
1740         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1741         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1742         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1743         (psym_find_compunit_symtab_by_address)
1744         (maintenance_print_psymbols, maintenance_info_psymtabs)
1745         (maintenance_check_psymtabs): Use ranged for.
1746         * psymtab.h (class objfile_psymtabs): New.
1747         (require_partial_symbols): Return objfile_psymtabs.
1748         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1749
1750 2019-01-09  Tom Tromey  <tom@tromey.com>
1751
1752         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1753         (find_pc_mapped_section, list_overlays_command)
1754         (map_overlay_command, unmap_overlay_command)
1755         (simple_overlay_update): Use all_objfiles.
1756         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1757         * printcmd.c (info_symbol_command): Use all_objfiles.
1758         * objfiles.h (ALL_OBJSECTIONS): Remove.
1759         * maint.c (maintenance_translate_address): Use all_objfiles.
1760         * gcore.c (gcore_create_callback): Use all_objfiles.
1761         (objfile_find_memory_regions): Likewise.
1762
1763 2019-01-09  Tom Tromey  <tom@tromey.com>
1764
1765         * symtab.c (find_line_symtab, info_sources_command)
1766         (make_source_files_completion_list): Use objfile_compunits.
1767         * source.c (select_source_symtab): Use objfile_compunits.
1768         * objfiles.h (struct objfile): Update comment.
1769         (ALL_OBJFILES): Remove.
1770         (ALL_FILETABS): Remove.
1771         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1772         objfile_compunits.
1773
1774 2019-01-09  Tom Tromey  <tom@tromey.com>
1775
1776         * symmisc.c (print_objfile_statistics, dump_objfile)
1777         (maintenance_print_symbols): Use compunit_filetabs.
1778         * source.c (forget_cached_source_info_for_objfile): Use
1779         compunit_filetabs.
1780         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1781         (ALL_FILETABS): Use compunit_filetabs.
1782         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1783         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1784
1785 2019-01-09  Tom Tromey  <tom@tromey.com>
1786
1787         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1788         (compunit_filetabs): New.
1789         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1790         compunit_filetabs.
1791         (info_sources_command, make_source_files_completion_list): Remove
1792         declaration.
1793         * symmisc.c (print_objfile_statistics, dump_objfile)
1794         (maintenance_print_symbols): Remove declaration.
1795         (maintenance_info_symtabs): Use compunit_filetabs.
1796         (maintenance_info_line_tables): Likewise.
1797         * source.c (select_source_symtab): Change local variable name.
1798         (forget_cached_source_info_for_objfile): Remove declaration.
1799         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1800         * objfiles.c (objfile_relocate1): Remove declaration.
1801         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1802         declaration.
1803         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1804         * coffread.c (coff_symtab_read): Remove declaration.
1805         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1806         compunit_filetabs.
1807
1808 2019-01-09  Tom Tromey  <tom@tromey.com>
1809
1810         * symtab.c (lookup_objfile_from_block)
1811         (find_pc_sect_compunit_symtab, search_symbols)
1812         (default_collect_symbol_completion_matches_break_on): Use
1813         objfile_compunits.
1814         * objfiles.h (ALL_COMPUNITS): Remove.
1815         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1816         * cp-support.c (add_symbol_overload_list_qualified): Use
1817         objfile_compunits.
1818         * ada-lang.c (ada_collect_symbol_completion_matches)
1819         (ada_add_global_exceptions): Use objfile_compunits.
1820
1821 2019-01-09  Tom Tromey  <tom@tromey.com>
1822
1823         * source.c (select_source_symtab)
1824         (forget_cached_source_info_for_objfile): Remove declaration.
1825         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1826         declaration.
1827         * maint.c (count_symtabs_and_blocks): Remove declaration.
1828         * cp-support.c (add_symbol_overload_list_qualified): Remove
1829         declaration.
1830         * coffread.c (coff_symtab_read): Remove declaration.
1831         * symtab.c (lookup_symbol_in_objfile_symtabs)
1832         (basic_lookup_transparent_type_1): Use objfile_compunits.
1833         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1834         (info_sources_command, search_symbols)
1835         (default_collect_symbol_completion_matches_break_on)
1836         (make_source_files_completion_list): Remove declaration.
1837         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1838         (ada_collect_symbol_completion_matches)
1839         (ada_add_global_exceptions): Remove declaration.
1840         * linespec.c (iterate_over_all_matching_symtabs): Use
1841         objfile_compunits.
1842         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1843         (class objfile_compunits): New.
1844         (ALL_COMPUNITS): Use objfile_compunits.
1845         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1846         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1847         objfile_compunits.
1848         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1849
1850 2019-01-09  Tom Tromey  <tom@tromey.com>
1851
1852         * symtab.c (search_symbols)
1853         (default_collect_symbol_completion_matches_break_on): Use
1854         objfile_msymbols.
1855         * ada-lang.c (ada_lookup_simple_minsym)
1856         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1857         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1858         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1859         objfile_msymbols.
1860         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1861         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1862         * objc-lang.c (find_methods): Use objfile_msymbols.
1863         (info_selectors_command, info_classes_command): Likewise.
1864         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1865         * objfiles.h (class objfile_msymbols): New.
1866         (ALL_OBJFILE_MSYMBOLS): Remove.
1867         (ALL_MSYMBOLS): Remove.
1868
1869 2019-01-09  Tom Tromey  <tom@tromey.com>
1870
1871         * common/next-iterator.h (next_adapter): Add Iterator template
1872         parameter.
1873         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1874         (class all_objfiles_safe): New.
1875         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1876         * objfiles.c (put_objfile_before): Update comment.
1877         (add_separate_debug_objfile): Likewise.
1878         (free_all_objfiles): Use all_objfiles_safe.
1879         (objfile_purge_solibs): Likewise.
1880
1881 2019-01-09  Tom Tromey  <tom@tromey.com>
1882
1883         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1884         (expand_symtab_containing_pc, lookup_static_symbol)
1885         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1886         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1887         all_objfiles.
1888         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1889         * breakpoint.c (create_overlay_event_breakpoint)
1890         (create_longjmp_master_breakpoint)
1891         (create_std_terminate_master_breakpoint)
1892         (create_exception_master_breakpoint): Use all_objfiles.
1893         * linux-thread-db.c (try_thread_db_load_from_pdir)
1894         (has_libpthread): Use all_objfiles.
1895         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1896         * linespec.c (iterate_over_all_matching_symtabs)
1897         (search_minsyms_for_name): Use all_objfiles.
1898         * maint.c (maintenance_info_sections): Use all_objfiles.
1899         * main.c (captured_main_1): Use all_objfiles.
1900         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1901         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1902         * guile/scm-pretty-print.c
1903         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1904         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1905         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1906         (maintenance_print_msymbols): Use all_objfiles.
1907         * source.c (select_source_symtab): Use all_objfiles.
1908         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1909         * symfile.c (remove_symbol_file_command)
1910         (expand_symtabs_matching, map_symbol_filenames): Use
1911         all_objfiles.
1912         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1913         all_objfiles.
1914         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1915         * objc-lang.c (find_methods): Use all_objfiles.
1916         * objfiles.c (have_partial_symbols, have_full_symbols)
1917         (have_minimal_symbols, qsort_cmp)
1918         (default_iterate_over_objfiles_in_search_order): Use
1919         all_objfiles.
1920         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1921         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1922         (maintenance_check_psymtabs): Use all_objfiles.
1923         (ALL_PSYMTABS): Remove.
1924         * compile/compile-object-run.c (do_module_cleanup): Use
1925         all_objfiles.
1926         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1927         * cp-support.c (add_symbol_overload_list_qualified): Use
1928         all_objfiles.
1929         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1930         Use all_objfiles.
1931         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1932         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1933         all_objfiles.
1934         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1935         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1936         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1937         Uses all_objfiles.
1938         * solib.c (solib_read_symbols): Use all_objfiles
1939
1940 2019-01-09  Tom Tromey  <tom@tromey.com>
1941
1942         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1943         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1944         all_objfiles.
1945         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1946         * symmisc.c (print_symbol_bcache_statistics)
1947         (print_objfile_statistics, maintenance_print_objfiles)
1948         (maintenance_info_symtabs, maintenance_check_symtabs)
1949         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1950         all_objfiles.
1951         * source.c (forget_cached_source_info): Use all_objfiles.
1952         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1953         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1954         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1955         * objfiles.c (update_section_map): Use all_objfiles.
1956         (shared_objfile_contains_address_p): Likewise.
1957         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1958         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1959
1960 2019-01-09  Tom Tromey  <tom@tromey.com>
1961
1962         * common/next-iterator.h: New file.
1963         * objfiles.h (class all_objfiles): New.
1964         (struct objfile_iterator): New.
1965
1966 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         * NEWS: Move the description of the changed "frame", "select-frame",
1969          and "info frame" commands to the Changed commands section.
1970
1971 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1972
1973         * gdbtypes.c (check_stub_method_group): Remove handling of old
1974         mangling schemes.
1975         * linespec.c (find_methods): Likewise.
1976         * stabsread.c (read_member_functions): Likewise.
1977         * valops.c (search_struct_method): Likewise.
1978         (value_struct_elt_for_reference): Likewise.
1979         * NEWS: Mention this change.
1980
1981 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1982
1983         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1984         print_source_lines.
1985         * source.c (print_source_lines_base): Update line number check.
1986         (print_source_lines): New function.
1987         (source_lines_range::source_lines_range): New function.
1988         * source.h (class source_lines_range): New class.
1989         (print_source_lines): New declaration.
1990
1991 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1992
1993         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1994
1995 2019-01-08  Tom Tromey  <tom@tromey.com>
1996             Simon Marchi  <simon.marchi@ericsson.com>
1997
1998         PR gdb/24060
1999         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2000         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2001         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2002         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2003         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2004         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2005
2006 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2007
2008         * source.c (select_source_symtab): Move header comment to
2009         declaration in source.h.
2010         (forget_cached_source_info_for_objfile): Likewise.
2011         (forget_cached_source_info): Likewise.
2012         (identify_source_line): Likewise.
2013         * source.h (identify_source_line): Move declaration from symtab.h
2014         and add comment from source.c
2015         (print_source_lines): Likewise.
2016         (forget_cached_source_info_for_objfile): Likewise.
2017         (forget_cached_source_info): Likewise.
2018         (select_source_symtab): Likewise.
2019         (enum print_source_lines_flag): Move definition from symtab.h.
2020         * symtab.h (identify_source_line): Move declaration to source.h.
2021         (print_source_lines): Likewise.
2022         (forget_cached_source_info_for_objfile): Likewise.
2023         (forget_cached_source_info): Likewise.
2024         (select_source_symtab): Likewise.
2025         (enum print_source_lines_flag): Move definition to source.h.
2026         * tui/tui-hooks.c: Add 'source.h' include.
2027
2028 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * source.c (print_source_lines_base): Handle requests to print
2031         reverse line number sequences, and guard against empty lines
2032         string.
2033
2034 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * source.c (print_source_lines_base): Fix skip of '\r' if next
2037         character is '\n'.
2038
2039 2019-01-06  Tom Tromey  <tom@tromey.com>
2040
2041         * c-exp.y (struct c_parse_state) <macro_original_text,
2042         expansion_obstack>: New member.
2043         (macro_original_text, expansion_obstack): Remove globals.
2044         (scan_macro_expansion, scanning_macro_expansion)
2045         (finished_macro_expansion): Update.
2046         (scan_macro_cleanup): Remove.
2047         (yylex, c_parse): Update.
2048
2049 2019-01-06  Tom Tromey  <tom@tromey.com>
2050
2051         * c-exp.y (struct c_parse_state) <strings>: New member.
2052         (operator_stoken): Update.
2053
2054 2019-01-06  Tom Tromey  <tom@tromey.com>
2055
2056         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2057         (union type_stack_elt) <typelist_val>: Now a pointer to
2058         std::vector.
2059         (type_stack_cleanup): Don't declare.
2060         (push_typelist): Update.
2061         * parse.c (pop_typelist): Return a std::vector.
2062         (push_typelist): Take a std::vector.
2063         (follow_types): Update.  Do not free args.
2064         (type_stack_cleanup): Remove.
2065         * c-exp.y (struct c_parse_state): New.
2066         (cpstate): New global.
2067         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2068         (nonempty_typelist): Update.
2069         (func_mod): Create a new vector.
2070         (c_parse): Create a c_parse_state.
2071         (check_parameter_typelist): Do not delete params.
2072         (function_method): Update.  Do not delete type_list.
2073
2074 2019-01-06  Tom Tromey  <tom@tromey.com>
2075
2076         PR gdb/28155:
2077         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2078         check_typedef.
2079         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2080         (print_return_value): Likewise.
2081
2082 2019-01-05  Tom Tromey  <tom@tromey.com>
2083
2084         * contrib/cleanup_check.py: Remove.
2085         * contrib/gcc-with-excheck: Remove.
2086         * contrib/exsummary.py: Remove.
2087         * contrib/excheck.py: Remove.
2088
2089 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2090
2091         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2092         NULL. Initialize tpprev to NULL instead of assigning it
2093         to NULL on the next statement.
2094         * windows-nat.c (windows_delete_thread): Remove check for
2095         main_thread_id before printing thread exit notifications.
2096         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2097         Remove thread ID check against main_thread_id.
2098         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2099         windows_delete_thread.
2100         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2101
2102 2019-01-04  Tom Tromey  <tom@tromey.com>
2103
2104         * compile/compile.c (_initialize_compile): Use upper case for
2105         metasyntactic variables.
2106         * symmisc.c (_initialize_symmisc): Use upper case for
2107         metasyntactic variables.
2108         * psymtab.c (_initialize_psymtab): Use upper case for
2109         metasyntactic variables.
2110         * demangle.c (demangle_command): Use upper case for metasyntactic
2111         variables.
2112         (_initialize_demangler): Likewise.
2113         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2114         variables.
2115
2116 2019-01-03  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2119
2120 2019-01-03  Tom Tromey  <tom@tromey.com>
2121
2122         * python/py-symtab.c (salpy_str): Update.
2123         (struct salpy_sal_object) <symtab>: Now a PyObject.
2124         (salpy_dealloc): Update.
2125         (del_objfile_sal): Use gdbpy_ref.
2126
2127 2019-01-03  Tom Tromey  <tom@tromey.com>
2128
2129         * python/py-type.c (convert_field): Use new_reference.  Return
2130         gdbpy_ref.
2131         (make_fielditem): Return gdbpy_ref.
2132         (typy_fields): Update.
2133         (typy_getitem): Update.
2134         (field_name): Return gdbpy_ref.  Use new_reference.
2135         (typy_iterator_iternext): Update.
2136
2137 2019-01-03  Tom Tromey  <tom@tromey.com>
2138
2139         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2140
2141 2019-01-03  Tom Tromey  <tom@tromey.com>
2142
2143         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2144         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2145         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2146         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2147         (pspy_set_type_printers): Likewise.
2148         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2149         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2150         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2151         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2152         (objfpy_set_type_printers): Likewise.
2153
2154 2019-01-03  Tom Tromey  <tom@tromey.com>
2155
2156         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2157         (gdbpy_print_stack): Use gdbpy_err_fetch.
2158         * python/python-internal.h (class gdbpy_err_fetch): New class.
2159         (class gdbpy_enter) <m_error_type, m_error_value,
2160         m_error_traceback>: Remove.
2161         <m_error>: New member.
2162         (gdbpy_exception_to_string): Don't declare.
2163         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2164         * python/py-value.c (convert_value_from_python): Use
2165         gdbpy_err_fetch.
2166         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2167         gdbpy_exception_to_string.
2168         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2169         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2170         gdbpy_err_fetch.
2171
2172 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * linux-nat.c (delete_lwp_cleanup): Delete.
2175         (struct lwp_deleter): New struct.
2176         (lwp_info_up): New typedef.
2177         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2178         lwp_info_up.
2179
2180 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2181
2182         * linux-fork.c (class scoped_switch_fork_info): New class.
2183         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2184
2185 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * valops.c (find_overload_match): Remove use of null_cleanup, and
2188         calls to do_cleanups.
2189
2190 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * compile/compile-cplus-types.c
2193         (compile_cplus_instance::decl_name): Handle changes to
2194         cp_func_name.
2195         * cp-support.c (cp_func_name): Update header comment, update
2196         return type.
2197         * cp-support.h (cp_func_name): Update return type in declaration.
2198         * valops.c (find_overload_match): Move temp_func local to top
2199         level of function and change its type.  Use temp_func to hold and
2200         delete temporary string obtained from cp_func_name.
2201
2202 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2205         gdb::char_vector, remove cleanup, and update uses of `msg`.
2206
2207 2019-01-03  Jim Wilson  <jimw@sifive.com>
2208
2209         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2210
2211 2019-01-02  Tom Tromey  <tom@tromey.com>
2212
2213         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2214         (tdesc_parse_xml): Remove cleanups.
2215         * target-descriptions.h (make_cleanup_free_target_description):
2216         Don't declare.
2217         (target_desc_deleter): New struct.
2218         (target_desc_up): New typedef.
2219         * target-descriptions.c (target_desc_deleter::operator()): Rename
2220         from free_target_description.
2221         (make_cleanup_free_target_description): Remove.
2222
2223 2019-01-02  Tom Tromey  <tom@tromey.com>
2224
2225         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2226         constructor, destructor.
2227         (linespec_parser): Remove typedef.
2228         (~linespec_parser): Rename from linespec_parser_delete.
2229         (linespec_lex_to_end, linespec_complete_label)
2230         (linespec_complete): Update.
2231         (decode_line_full): Remove cleanups.
2232         (decode_line_1): Update.
2233
2234 2019-01-02  Tom Tromey  <tom@tromey.com>
2235
2236         * python/python-internal.h (inferior_to_inferior_object): Change
2237         return type.
2238         * python/py-exitedevent.c (create_exited_event_object): Update.
2239         * python/py-inferior.c (inferior_to_inferior_object): Return
2240         gdbpy_ref.
2241         (python_new_inferior, python_inferior_deleted)
2242         (thread_to_thread_object, delete_thread_object)
2243         (build_inferior_list, gdbpy_selected_inferior): Update.
2244         * python/py-infthread.c (create_thread_object): Update.  Also fail
2245         if inferior_to_inferior_object fails.
2246
2247 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2248
2249         * inferior.h (class inferior) <displaced_step_state>: New field.
2250         * infrun.h (struct displaced_step_state): Move here from
2251         infrun.c.  Initialize fields, add constructor.
2252         <inf>: Remove field.
2253         <reset>: New method.
2254         * infrun.c (struct displaced_step_inferior_state): Move to
2255         infrun.h.
2256         (displaced_step_inferior_states): Remove.
2257         (get_displaced_stepping_state): Adust.
2258         (displaced_step_in_progress_any_inferior): Adjust.
2259         (displaced_step_in_progress_thread): Adjust.
2260         (displaced_step_in_progress): Adjust.
2261         (add_displaced_stepping_state): Remove.
2262         (get_displaced_step_closure_by_addr): Adjust.
2263         (remove_displaced_stepping_state): Remove.
2264         (infrun_inferior_exit): Call displaced_step_state.reset.
2265         (use_displaced_stepping): Don't check for NULL.
2266         (displaced_step_prepare_throw): Call
2267         get_displaced_stepping_state.
2268         (displaced_step_fixup): Don't check for NULL.
2269         (prepare_for_detach): Don't check for NULL.
2270
2271 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2272
2273         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2274          in case of call that did not complete.
2275
2276 2019-01-02  Andrey Utkin  <autkin@undo.io>
2277
2278         * symfile.c (find_separate_debug_file): Fix search of debug files for
2279         remote debuggee.
2280
2281 2019-01-02  Tom Tromey  <tom@tromey.com>
2282
2283         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2284         indentation.
2285         * python/py-frame.c (frapy_older): Remove cast.
2286         (frapy_newer): Likewise.
2287         * python/py-breakpoint.c (local_setattro): Remove cast.
2288         * python/py-arch.c (archpy_name): Remove local variable.
2289         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2290
2291 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2292
2293         * unittests/basic_string_view/element_access/char/empty.cc:
2294         Fix year range in copyright header.
2295
2296 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2299         Delete.
2300         <operator==>: Update with for removed field.
2301         <hash>: Likewise.
2302         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2303         <isa_features>: ...this.
2304         <abi_features>: New field.
2305         (riscv_isa_flen): Update comment.
2306         (riscv_abi_xlen): New declaration.
2307         (riscv_abi_flen): New declaration.
2308         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2309         isa_features.
2310         (riscv_abi_xlen): New function.
2311         (riscv_isa_flen): Update to get answer from isa_features.
2312         (riscv_abi_flen): New function.
2313         (riscv_has_fp_abi): Update to get answer from abi_features.
2314         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2315         xlen and flen.
2316         (riscv_call_info) <xlen, flen>: Update comment.
2317         (riscv_call_arg_struct): Remove invalid assertions
2318         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2319         is removed.
2320         (riscv_gdbarch_init): Gather isa features and abi features
2321         separately, ensure both match on the gdbarch when reusing an old
2322         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2323         a target with 64-bit float hardware.
2324
2325 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2326
2327         * source.c (search_command_helper): Stop reverse search
2328         when line 1 has been searched.
2329
2330 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2331
2332         * record-full.c (record_full_base_target::close): Rewrite
2333         record_full_core_buf_list free logic.
2334
2335 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2336
2337         * break-catch-syscall.c (print_one_catch_syscall): xfree
2338         the last text.
2339
2340 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2341
2342         * top.c (print_gdb_version): Update Copyright year in version
2343         message.
2344
2345 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2346
2347         Update copyright year range in all GDB files.
2348
2349 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2350
2351         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2352
2353 For older changes see ChangeLog-2018.
2354 \f
2355 Local Variables:
2356 mode: change-log
2357 left-margin: 8
2358 fill-column: 74
2359 version-control: never
2360 coding: utf-8
2361 End:
2362