gdb/ChangeLog

   1 2019-01-25  Tom Tromey  <tom@tromey.com>
   2
   3         * xtensa-linux-nat.c: Fix common/ includes.
   4         * xml-support.h: Fix common/ includes.
   5         * xml-support.c: Fix common/ includes.
   6         * x86-linux-nat.c: Fix common/ includes.
   7         * windows-nat.c: Fix common/ includes.
   8         * varobj.h: Fix common/ includes.
   9         * varobj.c: Fix common/ includes.
  10         * value.c: Fix common/ includes.
  11         * valops.c: Fix common/ includes.
  12         * utils.c: Fix common/ includes.
  13         * unittests/xml-utils-selftests.c: Fix common/ includes.
  14         * unittests/utils-selftests.c: Fix common/ includes.
  15         * unittests/unpack-selftests.c: Fix common/ includes.
  16         * unittests/tracepoint-selftests.c: Fix common/ includes.
  17         * unittests/style-selftests.c: Fix common/ includes.
  18         * unittests/string_view-selftests.c: Fix common/ includes.
  19         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  20         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  21         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  22         * unittests/rsp-low-selftests.c: Fix common/ includes.
  23         * unittests/parse-connection-spec-selftests.c: Fix common/
  24         includes.
  25         * unittests/optional-selftests.c: Fix common/ includes.
  26         * unittests/offset-type-selftests.c: Fix common/ includes.
  27         * unittests/observable-selftests.c: Fix common/ includes.
  28         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  29         * unittests/memrange-selftests.c: Fix common/ includes.
  30         * unittests/memory-map-selftests.c: Fix common/ includes.
  31         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  32         * unittests/function-view-selftests.c: Fix common/ includes.
  33         * unittests/environ-selftests.c: Fix common/ includes.
  34         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  35         * unittests/common-utils-selftests.c: Fix common/ includes.
  36         * unittests/cli-utils-selftests.c: Fix common/ includes.
  37         * unittests/array-view-selftests.c: Fix common/ includes.
  38         * ui-file.c: Fix common/ includes.
  39         * tui/tui-io.c: Fix common/ includes.
  40         * tracepoint.h: Fix common/ includes.
  41         * tracepoint.c: Fix common/ includes.
  42         * tracefile-tfile.c: Fix common/ includes.
  43         * top.h: Fix common/ includes.
  44         * top.c: Fix common/ includes.
  45         * thread.c: Fix common/ includes.
  46         * target/waitstatus.h: Fix common/ includes.
  47         * target/waitstatus.c: Fix common/ includes.
  48         * target.h: Fix common/ includes.
  49         * target.c: Fix common/ includes.
  50         * target-memory.c: Fix common/ includes.
  51         * target-descriptions.c: Fix common/ includes.
  52         * symtab.h: Fix common/ includes.
  53         * symfile.c: Fix common/ includes.
  54         * stap-probe.c: Fix common/ includes.
  55         * spu-linux-nat.c: Fix common/ includes.
  56         * sparc-nat.c: Fix common/ includes.
  57         * source.c: Fix common/ includes.
  58         * solib.c: Fix common/ includes.
  59         * solib-target.c: Fix common/ includes.
  60         * ser-unix.c: Fix common/ includes.
  61         * ser-tcp.c: Fix common/ includes.
  62         * ser-pipe.c: Fix common/ includes.
  63         * ser-base.c: Fix common/ includes.
  64         * selftest-arch.c: Fix common/ includes.
  65         * s12z-tdep.c: Fix common/ includes.
  66         * rust-exp.y: Fix common/ includes.
  67         * rs6000-aix-tdep.c: Fix common/ includes.
  68         * riscv-tdep.c: Fix common/ includes.
  69         * remote.c: Fix common/ includes.
  70         * remote-notif.h: Fix common/ includes.
  71         * remote-fileio.h: Fix common/ includes.
  72         * remote-fileio.c: Fix common/ includes.
  73         * regcache.h: Fix common/ includes.
  74         * regcache.c: Fix common/ includes.
  75         * record-btrace.c: Fix common/ includes.
  76         * python/python.c: Fix common/ includes.
  77         * python/py-type.c: Fix common/ includes.
  78         * python/py-inferior.c: Fix common/ includes.
  79         * progspace.h: Fix common/ includes.
  80         * producer.c: Fix common/ includes.
  81         * procfs.c: Fix common/ includes.
  82         * proc-api.c: Fix common/ includes.
  83         * printcmd.c: Fix common/ includes.
  84         * ppc-linux-nat.c: Fix common/ includes.
  85         * parser-defs.h: Fix common/ includes.
  86         * osdata.c: Fix common/ includes.
  87         * obsd-nat.c: Fix common/ includes.
  88         * nat/x86-linux.c: Fix common/ includes.
  89         * nat/x86-linux-dregs.c: Fix common/ includes.
  90         * nat/x86-dregs.h: Fix common/ includes.
  91         * nat/x86-dregs.c: Fix common/ includes.
  92         * nat/ppc-linux.c: Fix common/ includes.
  93         * nat/mips-linux-watch.h: Fix common/ includes.
  94         * nat/mips-linux-watch.c: Fix common/ includes.
  95         * nat/linux-waitpid.c: Fix common/ includes.
  96         * nat/linux-ptrace.h: Fix common/ includes.
  97         * nat/linux-ptrace.c: Fix common/ includes.
  98         * nat/linux-procfs.c: Fix common/ includes.
  99         * nat/linux-personality.c: Fix common/ includes.
 100         * nat/linux-osdata.c: Fix common/ includes.
 101         * nat/linux-namespaces.c: Fix common/ includes.
 102         * nat/linux-btrace.h: Fix common/ includes.
 103         * nat/linux-btrace.c: Fix common/ includes.
 104         * nat/fork-inferior.c: Fix common/ includes.
 105         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 106         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 107         * nat/aarch64-linux.c: Fix common/ includes.
 108         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 109         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 110         * namespace.h: Fix common/ includes.
 111         * mips-linux-tdep.c: Fix common/ includes.
 112         * minsyms.c: Fix common/ includes.
 113         * mi/mi-parse.h: Fix common/ includes.
 114         * mi/mi-main.c: Fix common/ includes.
 115         * mi/mi-cmd-env.c: Fix common/ includes.
 116         * memrange.h: Fix common/ includes.
 117         * memattr.c: Fix common/ includes.
 118         * maint.h: Fix common/ includes.
 119         * maint.c: Fix common/ includes.
 120         * main.c: Fix common/ includes.
 121         * machoread.c: Fix common/ includes.
 122         * location.c: Fix common/ includes.
 123         * linux-thread-db.c: Fix common/ includes.
 124         * linux-nat.c: Fix common/ includes.
 125         * linux-fork.c: Fix common/ includes.
 126         * inline-frame.c: Fix common/ includes.
 127         * infrun.c: Fix common/ includes.
 128         * inflow.c: Fix common/ includes.
 129         * inferior.h: Fix common/ includes.
 130         * inferior.c: Fix common/ includes.
 131         * infcmd.c: Fix common/ includes.
 132         * inf-ptrace.c: Fix common/ includes.
 133         * inf-child.c: Fix common/ includes.
 134         * ia64-linux-nat.c: Fix common/ includes.
 135         * i387-tdep.c: Fix common/ includes.
 136         * i386-tdep.c: Fix common/ includes.
 137         * i386-linux-tdep.c: Fix common/ includes.
 138         * i386-linux-nat.c: Fix common/ includes.
 139         * i386-go32-tdep.c: Fix common/ includes.
 140         * i386-fbsd-tdep.c: Fix common/ includes.
 141         * i386-fbsd-nat.c: Fix common/ includes.
 142         * guile/scm-type.c: Fix common/ includes.
 143         * guile/guile.c: Fix common/ includes.
 144         * go32-nat.c: Fix common/ includes.
 145         * gnu-nat.c: Fix common/ includes.
 146         * gdbthread.h: Fix common/ includes.
 147         * gdbarch-selftests.c: Fix common/ includes.
 148         * gdb_usleep.c: Fix common/ includes.
 149         * gdb_select.h: Fix common/ includes.
 150         * gdb_bfd.c: Fix common/ includes.
 151         * gcore.c: Fix common/ includes.
 152         * fork-child.c: Fix common/ includes.
 153         * findvar.c: Fix common/ includes.
 154         * fbsd-nat.c: Fix common/ includes.
 155         * event-top.c: Fix common/ includes.
 156         * event-loop.c: Fix common/ includes.
 157         * dwarf2read.c: Fix common/ includes.
 158         * dwarf2loc.c: Fix common/ includes.
 159         * dwarf2-frame.c: Fix common/ includes.
 160         * dwarf-index-cache.c: Fix common/ includes.
 161         * dtrace-probe.c: Fix common/ includes.
 162         * disasm-selftests.c: Fix common/ includes.
 163         * defs.h: Fix common/ includes.
 164         * csky-tdep.c: Fix common/ includes.
 165         * cp-valprint.c: Fix common/ includes.
 166         * cp-support.h: Fix common/ includes.
 167         * cp-support.c: Fix common/ includes.
 168         * corelow.c: Fix common/ includes.
 169         * completer.h: Fix common/ includes.
 170         * completer.c: Fix common/ includes.
 171         * compile/compile.c: Fix common/ includes.
 172         * compile/compile-loc2c.c: Fix common/ includes.
 173         * compile/compile-cplus-types.c: Fix common/ includes.
 174         * compile/compile-cplus-symbols.c: Fix common/ includes.
 175         * command.h: Fix common/ includes.
 176         * cli/cli-dump.c: Fix common/ includes.
 177         * cli/cli-cmds.c: Fix common/ includes.
 178         * charset.c: Fix common/ includes.
 179         * build-id.c: Fix common/ includes.
 180         * btrace.h: Fix common/ includes.
 181         * btrace.c: Fix common/ includes.
 182         * breakpoint.h: Fix common/ includes.
 183         * breakpoint.c: Fix common/ includes.
 184         * ax.h:
 185         (enum agent_op): Fix common/ includes.
 186         * ax-general.c (struct aop_map): Fix common/ includes.
 187         * ax-gdb.c: Fix common/ includes.
 188         * auxv.c: Fix common/ includes.
 189         * auto-load.c: Fix common/ includes.
 190         * arm-tdep.c: Fix common/ includes.
 191         * arch/riscv.c: Fix common/ includes.
 192         * arch/ppc-linux-common.c: Fix common/ includes.
 193         * arch/i386.c: Fix common/ includes.
 194         * arch/arm.c: Fix common/ includes.
 195         * arch/arm-linux.c: Fix common/ includes.
 196         * arch/arm-get-next-pcs.c: Fix common/ includes.
 197         * arch/amd64.c: Fix common/ includes.
 198         * arch/aarch64.c: Fix common/ includes.
 199         * arch/aarch64-insn.c: Fix common/ includes.
 200         * arch-utils.c: Fix common/ includes.
 201         * amd64-windows-tdep.c: Fix common/ includes.
 202         * amd64-tdep.c: Fix common/ includes.
 203         * amd64-sol2-tdep.c: Fix common/ includes.
 204         * amd64-obsd-tdep.c: Fix common/ includes.
 205         * amd64-nbsd-tdep.c: Fix common/ includes.
 206         * amd64-linux-tdep.c: Fix common/ includes.
 207         * amd64-linux-nat.c: Fix common/ includes.
 208         * amd64-fbsd-tdep.c: Fix common/ includes.
 209         * amd64-fbsd-nat.c: Fix common/ includes.
 210         * amd64-dicos-tdep.c: Fix common/ includes.
 211         * amd64-darwin-tdep.c: Fix common/ includes.
 212         * agent.c: Fix common/ includes.
 213         * ada-lang.h: Fix common/ includes.
 214         * ada-lang.c: Fix common/ includes.
 215         * aarch64-tdep.c: Fix common/ includes.
 216
 217 2019-01-25  Tom Tromey  <tom@tromey.com>
 218
 219         * common/create-version.sh: Use common/version.h.
 220
 221 2019-01-24  Pedro Alves  <palves@redhat.com>
 222
 223         * infrun.c (signal_stop, signal_print, signal_program)
 224         (signal_catch, signal_pass): Now arrays instead of pointers.
 225         (update_signals_program_target, do_target_resume)
 226         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 227         * linux-nat.c (linux_nat_target::pass_signals)
 228         (linux_nat_target::create_inferior, linux_nat_target::attach):
 229         Adjust.
 230         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 231         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 232         * procfs.c (procfs_target::pass_signals): Adjust.
 233         * record-full.c (record_full_target::resume): Adjust.
 234         * remote.c (remote_target::pass_signals)
 235         (remote_target::program_signals): Adjust.
 236         * target-debug.h (target_debug_print_signals): Now takes a
 237         gdb::array_view as parameter.  Adjust.
 238         * target.h (target_ops) <pass_signals, program_signals>: Replace
 239         pointer and length parameters with gdb::array_view.
 240         (target_pass_signals, target_program_signals): Likewise.
 241         * target-delegates.c: Regenerate.
 242
 243 2019-01-24  Pedro Alves  <palves@redhat.com>
 244
 245         * common/forward-scope-exit.h
 246         (forward_scope_exit::forward_scope_exit): Pass arguments to
 247         m_bind_function directly, instead of creating a std::bind and
 248         copying that.
 249
 250 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 251
 252         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 253         for static members.
 254         (pass_in_v_vfp_candidate): Likewise.
 255
 256 2019-01-23  Tom Tromey  <tom@tromey.com>
 257             Pedro Alves  <palves@redhat.com>
 258
 259         * regcache.c (class regcache_invalidator): Remove.
 260         (regcache::raw_write): Use make_scope_exit.
 261
 262 2019-01-23  Tom Tromey  <tom@tromey.com>
 263
 264         * ui-out.h (class ui_out_emit_type): Update comment.
 265
 266 2019-01-23  Tom Tromey  <tom@tromey.com>
 267
 268         * infrun.c (fetch_inferior_event): Update comment.
 269
 270 2019-01-23  Tom Tromey  <tom@tromey.com>
 271             Pedro Alves  <palves@redhat.com>
 272
 273         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 274         parameter.
 275         (fetch_inferior_event): Use SCOPE_EXIT.
 276
 277
 278 2019-01-23  Tom Tromey  <tom@tromey.com>
 279             Pedro Alves  <palves@redhat.com>
 280
 281         * infrun.c (disable_thread_events): Delete.
 282         (stop_all_threads): Use SCOPE_EXIT.
 283
 284 2019-01-23  Tom Tromey  <tom@tromey.com>
 285             Pedro Alves  <palves@redhat.com>
 286
 287         * symfile.c: Include forward-scope-exit.h.
 288         (clear_symtab_users_cleanup): Replace forward declaration with
 289         a FORWARD_SCOPE_EXIT.
 290         (syms_from_objfile_1): Use the forward_scope_exit and
 291         gdb::optional instead of cleanup_function.
 292         (reread_symbols): Use the forward_scope_exit instead of
 293         cleanup_function.
 294         (clear_symtab_users_cleanup): Remove function.
 295
 296 2019-01-23  Tom Tromey  <tom@tromey.com>
 297             Pedro Alves  <palves@redhat.com>
 298
 299         * linux-nat.c: Include scope-exit.h.
 300         (cleanup_target_stop): Remove.
 301         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 302         SCOPE_EXIT.
 303
 304 2019-01-23  Tom Tromey  <tom@tromey.com>
 305             Pedro Alves  <palves@redhat.com>
 306
 307         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 308         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 309
 310 2019-01-23  Tom Tromey  <tom@tromey.com>
 311             Andrew Burgess  <andrew.burgess@embecosm.com>
 312             Pedro Alves  <palves@redhat.com>
 313
 314         * infrun.c (fetch_inferior_event): Use scope_exit.
 315         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 316         * top.c (execute_command): Use scope_exit.
 317         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 318         * utils.c (do_bpstat_clear_actions_cleanup)
 319         (make_bpstat_clear_actions_cleanup): Remove.
 320
 321 2019-01-23  Tom Tromey  <tom@tromey.com>
 322             Pedro Alves  <palves@redhat.com>
 323
 324         * infrun.c: Include "common/scope-exit.h"
 325         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 326         (wait_for_inferior): Use SCOPE_EXIT.
 327         (fetch_inferior_event): Use scope_exit.
 328
 329 2019-01-23  Tom Tromey  <tom@tromey.com>
 330             Pedro Alves  <palves@redhat.com>
 331
 332         * breakpoint.c (create_breakpoint): Remove cleanup.
 333
 334 2019-01-23  Tom Tromey  <tom@tromey.com>
 335             Andrew Burgess  <andrew.burgess@embecosm.com>
 336             Pedro Alves  <palves@redhat.com>
 337
 338 2019-01-23  Pedro Alves  <palves@redhat.com>
 339
 340         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 341
 342 2019-01-23  Pedro Alves  <palves@redhat.com>
 343             Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * gdbthread.h: Include "common/forward-scope-exit.h".
 346         (scoped_finish_thread_state): Redefine custom class in terms of
 347         forward_scope_exit.
 348
 349 2019-01-23  Pedro Alves  <palves@redhat.com>
 350             Andrew Burgess  <andrew.burgess@embecosm.com>
 351
 352         * common/forward-scope-exit.h: New file.
 353
 354 2019-01-23  Pedro Alves  <palves@redhat.com>
 355             Andrew Burgess  <andrew.burgess@embecosm.com>
 356             Tom Tromey  <tom@tromey.com>
 357
 358         * common/scope-exit.h: New file.
 359
 360 2019-01-23  Pedro Alves  <palves@redhat.com>
 361
 362         * common/preprocessor.h (ESC): Rename to ...
 363         (ESC_PARENS): ... this.
 364         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 365         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 366
 367 2019-01-23  Tom Tromey  <tom@tromey.com>
 368
 369         * language.h (class scoped_switch_to_sym_language_if_auto):
 370         Initialize m_lang in both cases.
 371
 372 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 373
 374         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 375         with XCNEW.
 376
 377 2019-01-22  Tom Tromey  <tom@tromey.com>
 378
 379         * corelow.c: Do not include sys/file.h.
 380
 381 2019-01-22  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-wingeneral.h: Include gdb_curses.h.
 384
 385 2019-01-22  Tom Tromey  <tom@tromey.com>
 386
 387         * source-cache.h (class source_cache) <get_source_lines,
 388         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 389
 390 2019-01-22  Tom Tromey  <tom@tromey.com>
 391
 392         * remote-fileio.h (struct remote_target): Declare.
 393
 394 2019-01-22  Tom Tromey  <tom@tromey.com>
 395
 396         * python/py-arch.c: Do not include py-ref.h.
 397         * python/py-bpevent.c: Do not include py-ref.h.
 398         * python/py-cmd.c: Do not include py-ref.h.
 399         * python/py-continueevent.c: Do not include py-ref.h.
 400         * python/py-event.h: Do not include py-ref.h.
 401         * python/py-evtregistry.c: Do not include py-ref.h.
 402         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 403         * python/py-frame.c: Do not include py-ref.h.
 404         * python/py-framefilter.c: Do not include py-ref.h.
 405         * python/py-function.c: Do not include py-ref.h.
 406         * python/py-infevents.c: Do not include py-ref.h.
 407         * python/py-linetable.c: Do not include py-ref.h.
 408         * python/py-objfile.c: Do not include py-ref.h.
 409         * python/py-param.c: Do not include py-ref.h.
 410         * python/py-prettyprint.c: Do not include py-ref.h.
 411         * python/py-progspace.c: Do not include py-ref.h.
 412         * python/py-symbol.c: Do not include py-ref.h.
 413         * python/py-symtab.c: Do not include py-ref.h.
 414         * python/py-type.c: Do not include py-ref.h.
 415         * python/py-unwind.c: Do not include py-ref.h.
 416         * python/py-utils.c: Do not include py-ref.h.
 417         * python/py-value.c: Do not include py-ref.h.
 418         * python/py-varobj.c: Do not include py-ref.h.
 419         * python/py-xmethods.c: Do not include py-ref.h.
 420         * python/python.c: Do not include py-ref.h.
 421         * varobj.c: Do not include py-ref.h.
 422
 423 2019-01-22  Tom Tromey  <tom@tromey.com>
 424
 425         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 426         keyword for bcache.
 427
 428 2019-01-22  Tom Tromey  <tom@tromey.com>
 429
 430         * compile/compile-cplus-types.c: Remove a comment by #include.
 431
 432 2019-01-22  Tom Tromey  <tom@tromey.com>
 433
 434         * compile/gcc-c-plugin.h: Include compile-internal.h.
 435
 436 2019-01-22  Tom Tromey  <tom@tromey.com>
 437
 438         * stabsread.c (EXTERN): Do not define.
 439         (symnum, next_symbol_text_func, processing_gcc_compilation)
 440         (within_function, global_sym_chain, global_stabs)
 441         (previous_stab_code, this_object_header_files)
 442         (n_this_object_header_files)
 443         (n_allocated_this_object_header_files): Define.
 444         * stabsread.h (EXTERN): Never define.  Use "extern".
 445
 446 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 447
 448         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 449         history_value.
 450
 451 2019-01-21  Tom Tromey  <tom@tromey.com>
 452
 453         * ui-out.c: Fix includes.
 454         * tui/tui-source.c: Fix includes.
 455         * target.c: Fix includes.
 456         * remote.c: Fix includes.
 457         * regcache.c: Fix includes.
 458         * python/py-block.c: Fix includes.
 459         * printcmd.c: Fix includes.
 460         * or1k-tdep.c: Fix includes.
 461         * mi/mi-main.c: Fix includes.
 462         * m32r-tdep.c: Fix includes.
 463         * csky-tdep.c: Fix includes.
 464         * compile/compile-cplus-types.c: Fix includes.
 465         * cli/cli-interp.c: Fix includes.
 466
 467 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 468
 469         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 470         for padding.
 471
 472 2019-01-16  Tom Tromey  <tom@tromey.com>
 473
 474         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 475         earlier.
 476         (struct objfile) <msymbols_range>: Move from top level.
 477         <msymbols>: New method.
 478         (class objfile_msymbols): Remove.
 479         * symtab.c (default_collect_symbol_completion_matches_break_on):
 480         Update.
 481         * symmisc.c (dump_msymbols): Update.
 482         * stabsread.c (scan_file_globals): Update.
 483         * objc-lang.c (info_selectors_command, info_classes_command)
 484         (find_methods): Update.
 485         * minsyms.c (find_solib_trampoline_target): Update.
 486         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 487         * coffread.c (coff_symfile_read): Update.
 488         * ada-lang.c (ada_lookup_simple_minsym)
 489         (ada_collect_symbol_completion_matches): Update.
 490
 491 2019-01-16  Tom Tromey  <tom@tromey.com>
 492
 493         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 494         type.  Remove no-argument constructor.
 495         <iterator::operator++>: Simplify.
 496         <begin>: Update.
 497         <end>: Use minimal_symbol_count.
 498
 499 2019-01-16  Tom Tromey  <tom@tromey.com>
 500
 501         * objfiles.h (struct objfile) <psymtabs>: New method.
 502         (class objfile_psymtabs): Remove.
 503         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 504         typedef.
 505         <range>: New method.
 506         (require_partial_symbols): Change return type.
 507         * psymtab.c (require_partial_symbols)
 508         (psym_expand_symtabs_matching): Update.
 509         * mdebugread.c (parse_partial_symbols): Update.
 510         * dbxread.c (dbx_end_psymtab): Update.
 511
 512 2019-01-15  Tom Tromey  <tom@tromey.com>
 513
 514         * symtab.c (lookup_objfile_from_block)
 515         (lookup_symbol_in_objfile_symtabs)
 516         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 517         (find_line_symtab, info_sources_command)
 518         (default_collect_symbol_completion_matches_break_on)
 519         (make_source_files_completion_list): Update.
 520         * symmisc.c (print_objfile_statistics, dump_objfile)
 521         (maintenance_print_symbols, maintenance_info_symtabs)
 522         (maintenance_check_symtabs, maintenance_info_line_tables):
 523         Update.
 524         * source.c (select_source_symtab)
 525         (forget_cached_source_info_for_objfile): Update.
 526         * objfiles.h (class objfile_compunits): Remove.
 527         (struct objfile) <compunits_range>: New typedef.
 528         (compunits): New method.
 529         * objfiles.c (objfile_relocate1): Update.
 530         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 531         * maint.c (count_symtabs_and_blocks): Update.
 532         * linespec.c (iterate_over_all_matching_symtabs): Update.
 533         * cp-support.c (add_symbol_overload_list_qualified): Update.
 534         * coffread.c (coff_symtab_read): Update.
 535         * ada-lang.c (add_nonlocal_symbols)
 536         (ada_collect_symbol_completion_matches)
 537         (ada_add_global_exceptions): Update.
 538
 539 2019-01-15  Tom Tromey  <tom@tromey.com>
 540
 541         * progspace.h (program_space) <objfiles_safe_range>: New
 542         typedef.
 543         <objfiles_safe>: New method.
 544         * objfiles.h (class all_objfiles_safe): Remove.
 545         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 546         * jit.c (jit_inferior_exit_hook): Update.
 547
 548 2019-01-17  Tom Tromey  <tom@tromey.com>
 549
 550         * progspace.h (program_space) <objfiles_range>: New typedef.
 551         <objfiles>: New method.
 552         <objfiles_head>: Rename from objfiles.
 553         (object_files): Update.
 554         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 555         * guile/scm-pretty-print.c
 556         (ppscm_find_pretty_printer_from_objfiles): Update.
 557         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 558         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 559         Update.
 560         * python/py-progspace.c (pspy_get_objfiles): Update.
 561         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 562         Update.
 563         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 564         (objfpy_lookup_objfile_by_build_id): Update.
 565         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 566         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 567         Update.
 568         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 569         (expand_symtab_containing_pc, lookup_objfile_from_block)
 570         (lookup_static_symbol, basic_lookup_transparent_type)
 571         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 572         (find_line_symtab, info_sources_command)
 573         (default_collect_symbol_completion_matches_break_on)
 574         (make_source_files_completion_list, find_main_name): Update.
 575         * symmisc.c (print_symbol_bcache_statistics)
 576         (print_objfile_statistics, maintenance_print_symbols)
 577         (maintenance_print_msymbols, maintenance_print_objfiles)
 578         (maintenance_info_symtabs, maintenance_check_symtabs)
 579         (maintenance_expand_symtabs, maintenance_info_line_tables):
 580         Update.
 581         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 582         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 583         (map_overlay_command, unmap_overlay_command)
 584         (simple_overlay_update, expand_symtabs_matching)
 585         (map_symbol_filenames): Update.
 586         * symfile-debug.c (set_debug_symfile): Update.
 587         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 588         Update.
 589         * source.c (select_source_symtab, forget_cached_source_info):
 590         Update.
 591         * solib.c (solib_read_symbols): Update.
 592         * solib-spu.c (append_ocl_sos): Update.
 593         * psymtab.c (maintenance_print_psymbols)
 594         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 595         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 596         * printcmd.c (info_symbol_command): Update.
 597         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 598         Update.
 599         * objfiles.h (class all_objfiles): Remove.
 600         * objfiles.c (have_partial_symbols, have_full_symbols)
 601         (have_minimal_symbols, qsort_cmp, update_section_map)
 602         (shared_objfile_contains_address_p)
 603         (default_iterate_over_objfiles_in_search_order): Update.
 604         * objc-lang.c (info_selectors_command, info_classes_command)
 605         (find_methods): Update.
 606         * minsyms.c (find_solib_trampoline_target): Update.
 607         * maint.c (maintenance_info_sections)
 608         (maintenance_translate_address, count_symtabs_and_blocks):
 609         Update.
 610         * main.c (captured_main_1): Update.
 611         * linux-thread-db.c (try_thread_db_load_from_pdir)
 612         (has_libpthread): Update.
 613         * linespec.c (iterate_over_all_matching_symtabs)
 614         (search_minsyms_for_name): Update.
 615         * jit.c (jit_find_objf_with_entry_addr): Update.
 616         * hppa-tdep.c (find_unwind_entry)
 617         (hppa_lookup_stub_minimal_symbol): Update.
 618         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 619         Update.
 620         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 621         (elf_gnu_ifunc_resolve_by_got): Update.
 622         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 623         * dwarf-index-write.c (save_gdb_index_command): Update.
 624         * cp-support.c (add_symbol_overload_list_qualified): Update.
 625         * breakpoint.c (create_overlay_event_breakpoint)
 626         (create_longjmp_master_breakpoint)
 627         (create_std_terminate_master_breakpoint)
 628         (create_exception_master_breakpoint): Update.
 629         * blockframe.c (find_pc_partial_function): Update.
 630         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 631         (ada_collect_symbol_completion_matches)
 632         (ada_add_global_exceptions): Update.
 633
 634 2019-01-17  Tom Tromey  <tom@tromey.com>
 635
 636         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 637         declare VEC.
 638         (solib_target_parse_libraries): Change return type.
 639         (library_list_start_segment, library_list_start_section)
 640         (library_list_end_library, library_list_start_library); Update.
 641         (solib_target_free_library_list): Remove.
 642         (solib_target_parse_libraries): Remove cleanup.  Change return
 643         type.
 644         (solib_target_current_sos): Update.
 645
 646 2019-01-17  Tom Tromey  <tromey@bapiya>
 647
 648         * valprint.c: Replace "the the" with "the".
 649         * symtab.c: Replace "the the" with "the".
 650         * solib.c: Replace "the the" with "the".
 651         * solib-dsbt.c: Replace "the the" with "the".
 652         * linespec.c: Replace "the the" with "the".
 653         * dwarf2loc.h: Replace "the the" with "the".
 654         * amd64-windows-tdep.c: Replace "the the" with "the".
 655         * aarch64-tdep.c: Replace "the the" with "the".
 656
 657 2019-01-16  Keith Seitz  <keiths@redhat.com>
 658
 659         PR gdb/23773
 660         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 661         <builder>: Rename to ..
 662         <m_builder>: ... this and make private.
 663         (dwarf2_cu::get_builder): New method.  Change all users of
 664         `builder' to use this method.
 665         (dwarf2_start_symtab): Move to ...
 666         (dwarf2_cu::start_symtab): ... here.  Update all callers
 667         (setup_type_unit_groups): Move to ...
 668         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 669         callers.
 670         (dwarf2_cu::reset_builder): New method.
 671         (process_full_compunit, process_full_type_unit): Use
 672         dwarf2_cu::reset_builder.
 673         (follow_die_offset): Record the ancestor CU if it is different
 674         from the followed DIE's CU.
 675         (follow_die_sig_1): Likewise.
 676
 677 2019-01-15  Tom Tromey  <tom@tromey.com>
 678
 679         * remote.c (class remote_state) <buf>: Now a char_vector.
 680         <buf_size>: Remove.
 681         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 682         parameter.
 683         (remote_target::getpkt_or_notif_sane_1)
 684         (remote_target::getpkt_sane)
 685         (remote_target::getpkt_or_notif_sane): Likewise.
 686         (class remote_target) <putpkt>: New overload.
 687         (remote_target::read_frame): Change type of "buf_p".  Remove
 688         sizeof_p parameter.
 689         (packet_ok): New overload.
 690         (packet_check_result): New overload.
 691         Update all uses.
 692
 693 2019-01-14  Tom Tromey  <tom@tromey.com>
 694
 695         * remote-notif.c (handle_notification, remote_notif_ack)
 696         (remote_notif_parse): Make "buf" const.
 697         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 698         const.
 699         (remote_notif_parse, remote_notif_ack, handle_notification):
 700         Likewise.
 701         * remote.c (remote_notif_stop_parse): Make "buf" const.
 702         (remote_target::remote_parse_stop_reply): Make "buf" const.
 703         (remote_notif_stop_ack): Make "buf" const.
 704
 705 2019-01-14  Tom Tromey  <tom@tromey.com>
 706
 707         * remote.c (remote_console_output): Make parameter const.
 708
 709 2019-01-14  Tom Tromey  <tom@tromey.com>
 710
 711         * target-debug.h (target_debug_print_signals): Constify.
 712         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 713         * procfs.c (procfs_target::pass_signals): Update.
 714         * linux-nat.c (linux_nat_target::pass_signals): Update.
 715         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 716         * target-delegates.c: Rebuild.
 717         * remote.c (remote_target::program_signals): Update.
 718         (remote_target::pass_signals): Update.
 719         * target.c (target_pass_signals): Constify argument.
 720         (target_program_signals): Likewise.
 721         * target.h (struct target_ops) <pass_signals, program_signals>:
 722         Constify argument.
 723         (target_pass_signals, target_program_signals): Constify argument.
 724
 725 2019-01-14  Tom Tromey  <tom@tromey.com>
 726
 727         PR tui/28819:
 728         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 729
 730 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 731
 732         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 733         field.
 734         * rs6000-tdep.c: Include reggroups.h.
 735         (IS_V_ALIAS_PSEUDOREG): Define.
 736         (rs6000_register_name): Return names for the "vX" aliases.
 737         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 738         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 739         aliases.  Call default_register_reggroup_p for all other
 740         pseudo-registers.
 741         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 742         New functions.
 743         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 744         Handle "vX" aliases.
 745         (v_alias_pseudo_register_collect): New function.
 746         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 747         (rs6000_gdbarch_init): Initialize "vX" aliases as
 748         pseudo-registers.  Restore registration of
 749         rs6000_pseudo_register_reggroup_p with
 750         set_tdesc_pseudo_register_reggroup_p.
 751
 752 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 753
 754         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 755         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 756         set_gdbarch_num_pseudo_regs.
 757
 758 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 759
 760         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 761         Remove arg prefixname, add do_set and do_show.
 762         Add member functions set_list and show_list.
 763         * cli/cli-style.c (class cli_style_option): Update accordingly.
 764         (style_set_list): Move to file scope.
 765         (style_show_list): Likewise.
 766         (set_style): Call help_list.
 767         (show_style): Call cmd_show_list.
 768         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 769         Update to use the new macro.
 770
 771 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 772
 773         * ada-lang.c (_initialize_ada_language): Expand the help text
 774         for the "catch exception" command.
 775
 776 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 777
 778         * symtab.c (matching_obj_sections): Initialize obj,
 779         declare it closer to its usage.
 780
 781 2019-01-10  Tom Tromey  <tom@tromey.com>
 782
 783         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 784         (basic_inf_threads_range): Remove.
 785         (inf_threads_range, inf_non_exited_threads_range)
 786         (safe_inf_threads_range): Use next_adapter.
 787
 788 2019-01-10  Keith Seitz  <keiths@redhat.com>
 789
 790         PR gdb/23712
 791         PR symtab/23010
 792         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 793         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 794
 795 2019-01-10  Keith Seitz  <keiths@redhat.com>
 796
 797         PR gdb/23712
 798         PR symtab/23010
 799         * dictionary.c (pending_to_vector): Remove.
 800         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 801         Remove _1 suffix, replacing functions of the same name.  Update
 802         all callers.
 803         (dict_create_hashed, dict_create_hashed_expandable)
 804         (dict_create_linear, dict_create_linear_expandable, dict_free)
 805         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 806         Make functions static.
 807
 808 2019-01-10  Keith Seitz  <keiths@redhat.com>
 809
 810         PR gdb/23712
 811         PR symtab/23010
 812         * dictionary.h (struct dictionary): Replace declaration with
 813         multidictionary.
 814         (dict_create_hashed, dict_create_hashed_expandable)
 815         (dict_create_linear, dict_create_linear_expandable)
 816         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 817         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 818         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 819         taking multidictionary argument.
 820         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 821         * block.h (struct block) <dict>: Change to multidictionary
 822         and rename `multidict'.
 823         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 824         symmisc.c: Update all dictionary references to multidictionary.
 825
 826 2019-01-10  Keith Seitz  <keiths@redhat.com>
 827
 828         PR gdb/23712
 829         PR symtab/23010
 830         * dictionary.c: Include unordered_map.
 831         (pending_to_vector): New function.
 832         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 833         Rewrite the non-"_1" functions to take vector instead
 834         of linked list.
 835         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 836         "new" _1 versions of the same name.
 837         (multidictionary): Define.
 838         (std::hash<enum language): New definition.
 839         (collate_pending_symbols_by_language, mdict_create_hashed)
 840         (mdict_create_hashed_expandable, mdict_create_linear)
 841         (mdict_create_linear_expandable, mdict_free)
 842         (find_language_dictionary, create_new_language_dictionary)
 843         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 844         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 845         (mdict_size, mdict_empty): New functions.
 846         * dictionary.h (mdict_iterator): Define.
 847
 848 2019-01-10  Pedro Alves  <palves@redhat.com>
 849
 850         * breakpoint.c (read_uploaded_action)
 851         (create_tracepoint_from_upload): Adjust to use
 852         gdb::unique_xmalloc_ptr.
 853         * ctf.c (ctf_write_uploaded_tp):
 854         (SET_ARRAY_FIELD): Use emplace_back.
 855         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 856         * tracefile-tfile.c (tfile_write_uploaded_tp):
 857         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 858         gdb::unique_xmalloc_ptr.
 859         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 860         at_string, cond_string, cmd_strings>: Replace char pointers
 861         with gdb::unique_xmalloc_ptr.
 862
 863 2019-01-10  Pedro Alves  <palves@redhat.com>
 864
 865         * solib-target.c (library_list_start_library): Don't xstrdup name.
 866
 867 2019-01-10  Pedro Alves  <palves@redhat.com>
 868
 869         * mdebugread.c (parse_partial_symbols): Use
 870         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 871
 872 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * linux-fork.c (scoped_switch_fork_info)
 875         <~scoped_switch_fork_info>: Fix incorrect variable name.
 876
 877 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * linux-fork.c (scoped_switch_fork_info)
 880         <scoped_switch_fork_info>: Make explicit.
 881         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 882
 883 2019-01-10  Tom Tromey  <tom@tromey.com>
 884
 885         * objfiles.h (objfile::reset_psymtabs): Update.
 886         * objfiles.c (objfile::objfile): Update.
 887         * psymtab.h (psymtab_storage::obstack): Update.
 888         (psymtab_storage::m_obstack): Use gdb::optional.
 889         (class psymtab_storage): Update comment.  Remove objfile
 890         parameter.
 891         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 892
 893 2019-01-10  Tom Tromey  <tom@tromey.com>
 894
 895         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 896         <free_psymtabs>: Now private.
 897         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 898         (allocate_psymtab): Use new method.
 899
 900 2019-01-10  Tom Tromey  <tom@tromey.com>
 901
 902         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 903         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 904         * mdebugread.c (parse_partial_symbols): Use
 905         allocate_dependencies.
 906         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 907         allocate_dependencies.
 908         (process_psymtab_comp_unit_reader)
 909         (build_type_psymtab_dependencies): Likewise.
 910         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 911
 912 2019-01-10  Tom Tromey  <tom@tromey.com>
 913
 914         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 915         PSYMBOL_SET_LANGUAGE.
 916         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 917
 918 2019-01-10  Tom Tromey  <tom@tromey.com>
 919
 920         * psymtab.h (psymtab_storage::obstack): New method.
 921         <m_obstack>: Rename from obstack; now private.
 922         * psymtab.c (psymtab_storage): Update.
 923         * dwarf2read.c (create_addrmap_from_index)
 924         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 925         Update.
 926
 927 2019-01-10  Tom Tromey  <tom@tromey.com>
 928
 929         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 930         * objfiles.h (objfile::reset_psymtabs): New method.
 931
 932 2019-01-10  Tom Tromey  <tom@tromey.com>
 933
 934         * symmisc.c (print_symbol_bcache_statistics): Update.
 935         (print_objfile_statistics): Update.
 936         * symfile.c (reread_symbols): Update.
 937         * psymtab.h (class psymtab_storage): New.
 938         * psymtab.c (psymtab_storage): New constructor.
 939         (~psymtab_storage): New destructor.
 940         (require_partial_symbols): Update.
 941         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 942         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 943         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 944         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 945         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 946         (start_psymtab_common, end_psymtab_common)
 947         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 948         (allocate_psymtab): Update.
 949         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 950         Update.
 951         (dump_psymtab_addrmap, maintenance_print_psymbols)
 952         (maintenance_check_psymtabs): Update.
 953         (class objfile_psymtabs): Move to objfiles.h.
 954         * psympriv.h (discard_psymtab): Now inline.
 955         (psymtab_discarder::psymtab_discarder): Update.
 956         (psymtab_discarder::~psymtab_discarder): Update.
 957         (ALL_OBJFILE_PSYMTABS): Rewrite.
 958         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 959         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 960         Remove fields.
 961         <partial_symtabs>: New field.
 962         (class objfile_psymtabs): Move from psymtab.h.  Update.
 963         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 964         psymbol_cache.
 965         (objfile::~objfile): Don't destroy psymbol_cache.
 966         * mdebugread.c (parse_partial_symbols): Update.
 967         * dwarf2read.c (create_addrmap_from_index)
 968         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 969         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 970         (add_partial_subprogram, dwarf2_ranges_read): Update.
 971         * dwarf-index-write.c (write_address_map)
 972         (write_one_signatured_type, recursively_write_psymbols)
 973         (class debug_names, class debug_names, write_psymtabs_to_index):
 974         Update.
 975
 976 2019-01-10  Tom Tromey  <tom@tromey.com>
 977
 978         * symtab.h (SYMBOL_SET_NAMES): Update.
 979         (symbol_set_names): Update.
 980         (MSYMBOL_SET_NAMES): Update.
 981         * symtab.c (symbol_set_names): Change argument to be an
 982         objfile_per_bfd_storage.
 983         * psymtab.c (add_psymbol_to_bcache): Update.
 984         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 985
 986 2019-01-10  Tom Tromey  <tom@tromey.com>
 987
 988         * symtab.c (create_demangled_names_hash): Change argument to be an
 989         objfile_per_bfd_storage.
 990         (symbol_set_names): Update.
 991
 992 2019-01-10  Tom Tromey  <tom@tromey.com>
 993
 994         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 995         init_psymbol_list.
 996         * psymtab.c (init_psymbol_list): Do nothing if already called.
 997         * psympriv.h (init_psymbol_list): Add comment.
 998         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 999         init_psymbol_list.
1000         * dbxread.c (dbx_symfile_read): Unconditionally call
1001         init_psymbol_list.
1002
1003 2019-01-10  Tom Tromey  <tom@tromey.com>
1004
1005         * xcoffread.c (scan_xcoff_symtab): Update.
1006         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1007         "where".
1008         * mdebugread.c (parse_partial_symbols)
1009         (handle_psymbol_enumerators): Update.
1010         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1011         * dbxread.c (read_dbx_symtab): Update.
1012         * psympriv.h (psymbol_placement): New enum.
1013         (add_psymbol_to_list): Update.
1014
1015 2019-01-10  Tom Tromey  <tom@tromey.com>
1016
1017         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1018         static_psymbols parameters.
1019         (scan_xcoff_symtab): Update.
1020         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1021         static_psymbols parameters.
1022         * psympriv.h (start_psymtab_common): Update.
1023         * mdebugread.c (parse_partial_symbols): Update.
1024         * dwarf2read.c (create_partial_symtab): Update.
1025         * dbxread.c (read_dbx_symtab): Update.
1026         (start_psymtab): Remove global_psymbols and static_psymbols
1027         parameters.
1028
1029 2019-01-10  Tom Tromey  <tom@tromey.com>
1030
1031         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1032         * psymtab.c (allocate_psymtab): Add comment.
1033         * psympriv.h (allocate_psymtab): Add comment.
1034         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1035         initializations.
1036         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1037
1038 2019-01-10  Tom Tromey  <tom@tromey.com>
1039
1040         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1041         Don't declare.
1042         * mipsread.c: Include mdebugread.h.
1043         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1044         Declare.
1045         * elfread.c: Include mdebugread.h.
1046
1047 2019-01-09  Tom Tromey  <tom@tromey.com>
1048
1049         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1050         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1051         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1052         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1053         (psym_lookup_symbol, psym_find_last_source_symtab)
1054         (psym_forget_cached_source_info, psym_print_stats)
1055         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1056         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1057         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1058         (psym_find_compunit_symtab_by_address)
1059         (maintenance_print_psymbols, maintenance_info_psymtabs)
1060         (maintenance_check_psymtabs): Use ranged for.
1061         * psymtab.h (class objfile_psymtabs): New.
1062         (require_partial_symbols): Return objfile_psymtabs.
1063         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1064
1065 2019-01-09  Tom Tromey  <tom@tromey.com>
1066
1067         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1068         (find_pc_mapped_section, list_overlays_command)
1069         (map_overlay_command, unmap_overlay_command)
1070         (simple_overlay_update): Use all_objfiles.
1071         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1072         * printcmd.c (info_symbol_command): Use all_objfiles.
1073         * objfiles.h (ALL_OBJSECTIONS): Remove.
1074         * maint.c (maintenance_translate_address): Use all_objfiles.
1075         * gcore.c (gcore_create_callback): Use all_objfiles.
1076         (objfile_find_memory_regions): Likewise.
1077
1078 2019-01-09  Tom Tromey  <tom@tromey.com>
1079
1080         * symtab.c (find_line_symtab, info_sources_command)
1081         (make_source_files_completion_list): Use objfile_compunits.
1082         * source.c (select_source_symtab): Use objfile_compunits.
1083         * objfiles.h (struct objfile): Update comment.
1084         (ALL_OBJFILES): Remove.
1085         (ALL_FILETABS): Remove.
1086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1087         objfile_compunits.
1088
1089 2019-01-09  Tom Tromey  <tom@tromey.com>
1090
1091         * symmisc.c (print_objfile_statistics, dump_objfile)
1092         (maintenance_print_symbols): Use compunit_filetabs.
1093         * source.c (forget_cached_source_info_for_objfile): Use
1094         compunit_filetabs.
1095         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1096         (ALL_FILETABS): Use compunit_filetabs.
1097         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1098         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1099
1100 2019-01-09  Tom Tromey  <tom@tromey.com>
1101
1102         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1103         (compunit_filetabs): New.
1104         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1105         compunit_filetabs.
1106         (info_sources_command, make_source_files_completion_list): Remove
1107         declaration.
1108         * symmisc.c (print_objfile_statistics, dump_objfile)
1109         (maintenance_print_symbols): Remove declaration.
1110         (maintenance_info_symtabs): Use compunit_filetabs.
1111         (maintenance_info_line_tables): Likewise.
1112         * source.c (select_source_symtab): Change local variable name.
1113         (forget_cached_source_info_for_objfile): Remove declaration.
1114         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1115         * objfiles.c (objfile_relocate1): Remove declaration.
1116         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1117         declaration.
1118         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1119         * coffread.c (coff_symtab_read): Remove declaration.
1120         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1121         compunit_filetabs.
1122
1123 2019-01-09  Tom Tromey  <tom@tromey.com>
1124
1125         * symtab.c (lookup_objfile_from_block)
1126         (find_pc_sect_compunit_symtab, search_symbols)
1127         (default_collect_symbol_completion_matches_break_on): Use
1128         objfile_compunits.
1129         * objfiles.h (ALL_COMPUNITS): Remove.
1130         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1131         * cp-support.c (add_symbol_overload_list_qualified): Use
1132         objfile_compunits.
1133         * ada-lang.c (ada_collect_symbol_completion_matches)
1134         (ada_add_global_exceptions): Use objfile_compunits.
1135
1136 2019-01-09  Tom Tromey  <tom@tromey.com>
1137
1138         * source.c (select_source_symtab)
1139         (forget_cached_source_info_for_objfile): Remove declaration.
1140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1141         declaration.
1142         * maint.c (count_symtabs_and_blocks): Remove declaration.
1143         * cp-support.c (add_symbol_overload_list_qualified): Remove
1144         declaration.
1145         * coffread.c (coff_symtab_read): Remove declaration.
1146         * symtab.c (lookup_symbol_in_objfile_symtabs)
1147         (basic_lookup_transparent_type_1): Use objfile_compunits.
1148         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1149         (info_sources_command, search_symbols)
1150         (default_collect_symbol_completion_matches_break_on)
1151         (make_source_files_completion_list): Remove declaration.
1152         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1153         (ada_collect_symbol_completion_matches)
1154         (ada_add_global_exceptions): Remove declaration.
1155         * linespec.c (iterate_over_all_matching_symtabs): Use
1156         objfile_compunits.
1157         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1158         (class objfile_compunits): New.
1159         (ALL_COMPUNITS): Use objfile_compunits.
1160         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1161         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1162         objfile_compunits.
1163         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1164
1165 2019-01-09  Tom Tromey  <tom@tromey.com>
1166
1167         * symtab.c (search_symbols)
1168         (default_collect_symbol_completion_matches_break_on): Use
1169         objfile_msymbols.
1170         * ada-lang.c (ada_lookup_simple_minsym)
1171         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1172         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1173         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1174         objfile_msymbols.
1175         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1176         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1177         * objc-lang.c (find_methods): Use objfile_msymbols.
1178         (info_selectors_command, info_classes_command): Likewise.
1179         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1180         * objfiles.h (class objfile_msymbols): New.
1181         (ALL_OBJFILE_MSYMBOLS): Remove.
1182         (ALL_MSYMBOLS): Remove.
1183
1184 2019-01-09  Tom Tromey  <tom@tromey.com>
1185
1186         * common/next-iterator.h (next_adapter): Add Iterator template
1187         parameter.
1188         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1189         (class all_objfiles_safe): New.
1190         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1191         * objfiles.c (put_objfile_before): Update comment.
1192         (add_separate_debug_objfile): Likewise.
1193         (free_all_objfiles): Use all_objfiles_safe.
1194         (objfile_purge_solibs): Likewise.
1195
1196 2019-01-09  Tom Tromey  <tom@tromey.com>
1197
1198         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1199         (expand_symtab_containing_pc, lookup_static_symbol)
1200         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1201         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1202         all_objfiles.
1203         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1204         * breakpoint.c (create_overlay_event_breakpoint)
1205         (create_longjmp_master_breakpoint)
1206         (create_std_terminate_master_breakpoint)
1207         (create_exception_master_breakpoint): Use all_objfiles.
1208         * linux-thread-db.c (try_thread_db_load_from_pdir)
1209         (has_libpthread): Use all_objfiles.
1210         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1211         * linespec.c (iterate_over_all_matching_symtabs)
1212         (search_minsyms_for_name): Use all_objfiles.
1213         * maint.c (maintenance_info_sections): Use all_objfiles.
1214         * main.c (captured_main_1): Use all_objfiles.
1215         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1216         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1217         * guile/scm-pretty-print.c
1218         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1219         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1220         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1221         (maintenance_print_msymbols): Use all_objfiles.
1222         * source.c (select_source_symtab): Use all_objfiles.
1223         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1224         * symfile.c (remove_symbol_file_command)
1225         (expand_symtabs_matching, map_symbol_filenames): Use
1226         all_objfiles.
1227         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1228         all_objfiles.
1229         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1230         * objc-lang.c (find_methods): Use all_objfiles.
1231         * objfiles.c (have_partial_symbols, have_full_symbols)
1232         (have_minimal_symbols, qsort_cmp)
1233         (default_iterate_over_objfiles_in_search_order): Use
1234         all_objfiles.
1235         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1236         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1237         (maintenance_check_psymtabs): Use all_objfiles.
1238         (ALL_PSYMTABS): Remove.
1239         * compile/compile-object-run.c (do_module_cleanup): Use
1240         all_objfiles.
1241         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1242         * cp-support.c (add_symbol_overload_list_qualified): Use
1243         all_objfiles.
1244         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1245         Use all_objfiles.
1246         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1247         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1248         all_objfiles.
1249         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1250         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1251         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1252         Uses all_objfiles.
1253         * solib.c (solib_read_symbols): Use all_objfiles
1254
1255 2019-01-09  Tom Tromey  <tom@tromey.com>
1256
1257         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1258         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1259         all_objfiles.
1260         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1261         * symmisc.c (print_symbol_bcache_statistics)
1262         (print_objfile_statistics, maintenance_print_objfiles)
1263         (maintenance_info_symtabs, maintenance_check_symtabs)
1264         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1265         all_objfiles.
1266         * source.c (forget_cached_source_info): Use all_objfiles.
1267         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1268         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1269         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1270         * objfiles.c (update_section_map): Use all_objfiles.
1271         (shared_objfile_contains_address_p): Likewise.
1272         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1273         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1274
1275 2019-01-09  Tom Tromey  <tom@tromey.com>
1276
1277         * common/next-iterator.h: New file.
1278         * objfiles.h (class all_objfiles): New.
1279         (struct objfile_iterator): New.
1280
1281 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1282
1283         * NEWS: Move the description of the changed "frame", "select-frame",
1284          and "info frame" commands to the Changed commands section.
1285
1286 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1287
1288         * gdbtypes.c (check_stub_method_group): Remove handling of old
1289         mangling schemes.
1290         * linespec.c (find_methods): Likewise.
1291         * stabsread.c (read_member_functions): Likewise.
1292         * valops.c (search_struct_method): Likewise.
1293         (value_struct_elt_for_reference): Likewise.
1294         * NEWS: Mention this change.
1295
1296 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1299         print_source_lines.
1300         * source.c (print_source_lines_base): Update line number check.
1301         (print_source_lines): New function.
1302         (source_lines_range::source_lines_range): New function.
1303         * source.h (class source_lines_range): New class.
1304         (print_source_lines): New declaration.
1305
1306 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1307
1308         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1309
1310 2019-01-08  Tom Tromey  <tom@tromey.com>
1311             Simon Marchi  <simon.marchi@ericsson.com>
1312
1313         PR gdb/24060
1314         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1315         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1316         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1317         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1318         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1319         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1320
1321 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * source.c (select_source_symtab): Move header comment to
1324         declaration in source.h.
1325         (forget_cached_source_info_for_objfile): Likewise.
1326         (forget_cached_source_info): Likewise.
1327         (identify_source_line): Likewise.
1328         * source.h (identify_source_line): Move declaration from symtab.h
1329         and add comment from source.c
1330         (print_source_lines): Likewise.
1331         (forget_cached_source_info_for_objfile): Likewise.
1332         (forget_cached_source_info): Likewise.
1333         (select_source_symtab): Likewise.
1334         (enum print_source_lines_flag): Move definition from symtab.h.
1335         * symtab.h (identify_source_line): Move declaration to source.h.
1336         (print_source_lines): Likewise.
1337         (forget_cached_source_info_for_objfile): Likewise.
1338         (forget_cached_source_info): Likewise.
1339         (select_source_symtab): Likewise.
1340         (enum print_source_lines_flag): Move definition to source.h.
1341         * tui/tui-hooks.c: Add 'source.h' include.
1342
1343 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * source.c (print_source_lines_base): Handle requests to print
1346         reverse line number sequences, and guard against empty lines
1347         string.
1348
1349 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1350
1351         * source.c (print_source_lines_base): Fix skip of '\r' if next
1352         character is '\n'.
1353
1354 2019-01-06  Tom Tromey  <tom@tromey.com>
1355
1356         * c-exp.y (struct c_parse_state) <macro_original_text,
1357         expansion_obstack>: New member.
1358         (macro_original_text, expansion_obstack): Remove globals.
1359         (scan_macro_expansion, scanning_macro_expansion)
1360         (finished_macro_expansion): Update.
1361         (scan_macro_cleanup): Remove.
1362         (yylex, c_parse): Update.
1363
1364 2019-01-06  Tom Tromey  <tom@tromey.com>
1365
1366         * c-exp.y (struct c_parse_state) <strings>: New member.
1367         (operator_stoken): Update.
1368
1369 2019-01-06  Tom Tromey  <tom@tromey.com>
1370
1371         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1372         (union type_stack_elt) <typelist_val>: Now a pointer to
1373         std::vector.
1374         (type_stack_cleanup): Don't declare.
1375         (push_typelist): Update.
1376         * parse.c (pop_typelist): Return a std::vector.
1377         (push_typelist): Take a std::vector.
1378         (follow_types): Update.  Do not free args.
1379         (type_stack_cleanup): Remove.
1380         * c-exp.y (struct c_parse_state): New.
1381         (cpstate): New global.
1382         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1383         (nonempty_typelist): Update.
1384         (func_mod): Create a new vector.
1385         (c_parse): Create a c_parse_state.
1386         (check_parameter_typelist): Do not delete params.
1387         (function_method): Update.  Do not delete type_list.
1388
1389 2019-01-06  Tom Tromey  <tom@tromey.com>
1390
1391         PR gdb/28155:
1392         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1393         check_typedef.
1394         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1395         (print_return_value): Likewise.
1396
1397 2019-01-05  Tom Tromey  <tom@tromey.com>
1398
1399         * contrib/cleanup_check.py: Remove.
1400         * contrib/gcc-with-excheck: Remove.
1401         * contrib/exsummary.py: Remove.
1402         * contrib/excheck.py: Remove.
1403
1404 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1405
1406         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1407         NULL. Initialize tpprev to NULL instead of assigning it
1408         to NULL on the next statement.
1409         * windows-nat.c (windows_delete_thread): Remove check for
1410         main_thread_id before printing thread exit notifications.
1411         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1412         Remove thread ID check against main_thread_id.
1413         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1414         windows_delete_thread.
1415         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1416
1417 2019-01-04  Tom Tromey  <tom@tromey.com>
1418
1419         * compile/compile.c (_initialize_compile): Use upper case for
1420         metasyntactic variables.
1421         * symmisc.c (_initialize_symmisc): Use upper case for
1422         metasyntactic variables.
1423         * psymtab.c (_initialize_psymtab): Use upper case for
1424         metasyntactic variables.
1425         * demangle.c (demangle_command): Use upper case for metasyntactic
1426         variables.
1427         (_initialize_demangler): Likewise.
1428         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1429         variables.
1430
1431 2019-01-03  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1434
1435 2019-01-03  Tom Tromey  <tom@tromey.com>
1436
1437         * python/py-symtab.c (salpy_str): Update.
1438         (struct salpy_sal_object) <symtab>: Now a PyObject.
1439         (salpy_dealloc): Update.
1440         (del_objfile_sal): Use gdbpy_ref.
1441
1442 2019-01-03  Tom Tromey  <tom@tromey.com>
1443
1444         * python/py-type.c (convert_field): Use new_reference.  Return
1445         gdbpy_ref.
1446         (make_fielditem): Return gdbpy_ref.
1447         (typy_fields): Update.
1448         (typy_getitem): Update.
1449         (field_name): Return gdbpy_ref.  Use new_reference.
1450         (typy_iterator_iternext): Update.
1451
1452 2019-01-03  Tom Tromey  <tom@tromey.com>
1453
1454         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1455
1456 2019-01-03  Tom Tromey  <tom@tromey.com>
1457
1458         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1459         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1460         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1461         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1462         (pspy_set_type_printers): Likewise.
1463         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1464         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1465         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1466         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1467         (objfpy_set_type_printers): Likewise.
1468
1469 2019-01-03  Tom Tromey  <tom@tromey.com>
1470
1471         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1472         (gdbpy_print_stack): Use gdbpy_err_fetch.
1473         * python/python-internal.h (class gdbpy_err_fetch): New class.
1474         (class gdbpy_enter) <m_error_type, m_error_value,
1475         m_error_traceback>: Remove.
1476         <m_error>: New member.
1477         (gdbpy_exception_to_string): Don't declare.
1478         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1479         * python/py-value.c (convert_value_from_python): Use
1480         gdbpy_err_fetch.
1481         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1482         gdbpy_exception_to_string.
1483         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1484         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1485         gdbpy_err_fetch.
1486
1487 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * linux-nat.c (delete_lwp_cleanup): Delete.
1490         (struct lwp_deleter): New struct.
1491         (lwp_info_up): New typedef.
1492         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1493         lwp_info_up.
1494
1495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * linux-fork.c (class scoped_switch_fork_info): New class.
1498         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1499
1500 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * valops.c (find_overload_match): Remove use of null_cleanup, and
1503         calls to do_cleanups.
1504
1505 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * compile/compile-cplus-types.c
1508         (compile_cplus_instance::decl_name): Handle changes to
1509         cp_func_name.
1510         * cp-support.c (cp_func_name): Update header comment, update
1511         return type.
1512         * cp-support.h (cp_func_name): Update return type in declaration.
1513         * valops.c (find_overload_match): Move temp_func local to top
1514         level of function and change its type.  Use temp_func to hold and
1515         delete temporary string obtained from cp_func_name.
1516
1517 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1520         gdb::char_vector, remove cleanup, and update uses of `msg`.
1521
1522 2019-01-03  Jim Wilson  <jimw@sifive.com>
1523
1524         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1525
1526 2019-01-02  Tom Tromey  <tom@tromey.com>
1527
1528         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1529         (tdesc_parse_xml): Remove cleanups.
1530         * target-descriptions.h (make_cleanup_free_target_description):
1531         Don't declare.
1532         (target_desc_deleter): New struct.
1533         (target_desc_up): New typedef.
1534         * target-descriptions.c (target_desc_deleter::operator()): Rename
1535         from free_target_description.
1536         (make_cleanup_free_target_description): Remove.
1537
1538 2019-01-02  Tom Tromey  <tom@tromey.com>
1539
1540         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1541         constructor, destructor.
1542         (linespec_parser): Remove typedef.
1543         (~linespec_parser): Rename from linespec_parser_delete.
1544         (linespec_lex_to_end, linespec_complete_label)
1545         (linespec_complete): Update.
1546         (decode_line_full): Remove cleanups.
1547         (decode_line_1): Update.
1548
1549 2019-01-02  Tom Tromey  <tom@tromey.com>
1550
1551         * python/python-internal.h (inferior_to_inferior_object): Change
1552         return type.
1553         * python/py-exitedevent.c (create_exited_event_object): Update.
1554         * python/py-inferior.c (inferior_to_inferior_object): Return
1555         gdbpy_ref.
1556         (python_new_inferior, python_inferior_deleted)
1557         (thread_to_thread_object, delete_thread_object)
1558         (build_inferior_list, gdbpy_selected_inferior): Update.
1559         * python/py-infthread.c (create_thread_object): Update.  Also fail
1560         if inferior_to_inferior_object fails.
1561
1562 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1563
1564         * inferior.h (class inferior) <displaced_step_state>: New field.
1565         * infrun.h (struct displaced_step_state): Move here from
1566         infrun.c.  Initialize fields, add constructor.
1567         <inf>: Remove field.
1568         <reset>: New method.
1569         * infrun.c (struct displaced_step_inferior_state): Move to
1570         infrun.h.
1571         (displaced_step_inferior_states): Remove.
1572         (get_displaced_stepping_state): Adust.
1573         (displaced_step_in_progress_any_inferior): Adjust.
1574         (displaced_step_in_progress_thread): Adjust.
1575         (displaced_step_in_progress): Adjust.
1576         (add_displaced_stepping_state): Remove.
1577         (get_displaced_step_closure_by_addr): Adjust.
1578         (remove_displaced_stepping_state): Remove.
1579         (infrun_inferior_exit): Call displaced_step_state.reset.
1580         (use_displaced_stepping): Don't check for NULL.
1581         (displaced_step_prepare_throw): Call
1582         get_displaced_stepping_state.
1583         (displaced_step_fixup): Don't check for NULL.
1584         (prepare_for_detach): Don't check for NULL.
1585
1586 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1587
1588         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1589          in case of call that did not complete.
1590
1591 2019-01-02  Andrey Utkin  <autkin@undo.io>
1592
1593         * symfile.c (find_separate_debug_file): Fix search of debug files for
1594         remote debuggee.
1595
1596 2019-01-02  Tom Tromey  <tom@tromey.com>
1597
1598         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1599         indentation.
1600         * python/py-frame.c (frapy_older): Remove cast.
1601         (frapy_newer): Likewise.
1602         * python/py-breakpoint.c (local_setattro): Remove cast.
1603         * python/py-arch.c (archpy_name): Remove local variable.
1604         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1605
1606 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1607
1608         * unittests/basic_string_view/element_access/char/empty.cc:
1609         Fix year range in copyright header.
1610
1611 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1614         Delete.
1615         <operator==>: Update with for removed field.
1616         <hash>: Likewise.
1617         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1618         <isa_features>: ...this.
1619         <abi_features>: New field.
1620         (riscv_isa_flen): Update comment.
1621         (riscv_abi_xlen): New declaration.
1622         (riscv_abi_flen): New declaration.
1623         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1624         isa_features.
1625         (riscv_abi_xlen): New function.
1626         (riscv_isa_flen): Update to get answer from isa_features.
1627         (riscv_abi_flen): New function.
1628         (riscv_has_fp_abi): Update to get answer from abi_features.
1629         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1630         xlen and flen.
1631         (riscv_call_info) <xlen, flen>: Update comment.
1632         (riscv_call_arg_struct): Remove invalid assertions
1633         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1634         is removed.
1635         (riscv_gdbarch_init): Gather isa features and abi features
1636         separately, ensure both match on the gdbarch when reusing an old
1637         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1638         a target with 64-bit float hardware.
1639
1640 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1641
1642         * source.c (search_command_helper): Stop reverse search
1643         when line 1 has been searched.
1644
1645 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1646
1647         * record-full.c (record_full_base_target::close): Rewrite
1648         record_full_core_buf_list free logic.
1649
1650 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1651
1652         * break-catch-syscall.c (print_one_catch_syscall): xfree
1653         the last text.
1654
1655 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1656
1657         * top.c (print_gdb_version): Update Copyright year in version
1658         message.
1659
1660 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1661
1662         Update copyright year range in all GDB files.
1663
1664 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1665
1666         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1667
1668 For older changes see ChangeLog-2018.
1669 \f
1670 Local Variables:
1671 mode: change-log
1672 left-margin: 8
1673 fill-column: 74
1674 version-control: never
1675 coding: utf-8
1676 End:
1677