gdb/ChangeLog

   1 2019-07-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
   4
   5 2019-07-15  Tom Tromey  <tromey@adacore.com>
   6
   7         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
   8         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
   9         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
  10         * cli-out.c (cli_ui_out::do_field_int): New method.
  11         * ui-out.c (ui_out::field_unsigned): New method.
  12         * symfile.c (generic_load): Use field_unsigned.
  13         (print_transfer_performance): Likewise.
  14         * record-btrace.c (ui_out_field_uint): Remove.
  15         (btrace_call_history_insn_range, btrace_call_history): Use
  16         field_unsigned.
  17         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
  18         field_unsigned.
  19         * ui-out.h (class ui_out) <field_unsigned>: New method.
  20         <do_field_unsigned>: Likewise.
  21
  22 2019-07-15  Tom Tromey  <tromey@adacore.com>
  23
  24         * mi/mi-main.c (list_available_thread_groups): Use field_string.
  25         * mi/mi-interp.c (mi_memory_changed): Use field_string.
  26         * target.c (flash_erase_command): Use field_string.
  27         * infrun.c (print_signal_received_reason): Use field_string.
  28         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
  29         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
  30         field_string.
  31         * ada-tasks.c (print_ada_task_info): Use field_string.
  32
  33 2019-07-15  Tom Tromey  <tromey@adacore.com>
  34
  35         * target.c (flash_erase_command): Use field_core_addr.
  36         * symfile.c (generic_load): Use field_core_addr.
  37         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
  38         Use field_core_addr.
  39         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
  40         field_core_addr.
  41
  42 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  43
  44         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  45         value if its desired type is smaller than a CORE_ADDR and signed.
  46
  47 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  50         of changes to field names, and use new is_reference field to
  51         decide if a property is a reference or not.
  52         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  53         field.
  54         (struct dwarf2_property_baton): Update header comment, rename
  55         'referenced_type' to 'property_type' and update comments.
  56         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  57         default property type, store in property baton, update to take
  58         accound of renamed field.
  59         (read_func_scope): Update call to attr_to_dynamic_prop.
  60         (read_array_type): Likewise.
  61         (dwarf2_per_cu_addr_sized_int_type): New function.
  62         (read_subrange_index_type): Move type finding code to
  63         dwarf2_per_cu_addr_sized_int_type.
  64         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  65         (dwarf2_per_cu_addr_type): New function.
  66         (set_die_type): Update calls to attr_to_dynamic_prop.
  67
  68 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         * dwarf2read.c (read_subrange_index_type): New function.
  71         (read_subrange_type): Move code into new function and call it.
  72         * gdbtypes.c (create_range_type): Add some asserts.
  73
  74 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  77         update return statements.
  78         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  79         declaration, and update comment to match.
  80         * gdbtypes.c (resolve_dynamic_array): Update call to
  81         dwarf2_evaluate_property to match new return type.
  82
  83 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  84
  85         * valarith.c (value_subscripted_rvalue): Change lowerbound
  86         parameter type from int to LONGEST.
  87         * value.h (value_subscripted_rvalue): Likewise in declaration.
  88
  89 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         * cli/cli-utils.c (info_print_command_completer): New function.
  92         * cli/cli-utils.h: Add 'completer.h' include, and forward
  93         declaration for 'struct cmd_list_element'.
  94         (info_print_command_completer): Declare.
  95         * stack.c (_initialize_stack): Add completer for 'info locals' and
  96         'info args'.
  97         * symtab.c (_initialize_symtab): Add completer for 'info
  98         variables' and 'info functions'.
  99         * NEWS: Mention completion for additional info commands.
 100
 101 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 102
 103         * cli/cli-utils.c (extract_info_print_args): Delete.
 104         (extract_arg_maybe_quoted): Delete.
 105         (info_print_options_defs): New variable.
 106         (make_info_print_options_def_group): New function.
 107         (extract_info_print_options): Define new function.
 108         * cli/cli-utils.h (extract_info_print_args): Delete.
 109         (struct info_print_options): New structure.
 110         (extract_info_print_options): Declare new function.
 111         * stack.c (info_locals_command): Update to use new
 112         extract_info_print_options, also add a header comment.
 113         (info_args_command): Likewise.
 114         * symtab.c (info_variables_command): Likewise.
 115         (info_functions_command): Likewise.
 116
 117 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 118
 119         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 120         to extract string arguments.
 121         * common/common-utils.c (extract_string_maybe_quoted): New function.
 122         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 123
 124 2019-07-11  Tom Tromey  <tromey@adacore.com>
 125
 126         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 127         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 128         * top.h (gdbinit): Don't declare.
 129         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 130         into...
 131         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 132         * top.c (gdb_init): Don't call init_cli_cmds.
 133         (gdbinit): Remove.
 134         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 135
 136 2019-07-11  Tom Tromey  <tromey@adacore.com>
 137
 138         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 139         after it has been moved.
 140
 141 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 142
 143         * valops.c (value_must_coerce_to_target): Change return type to
 144         bool.
 145         * value.h (value_must_coerce_to_target): Likewise.
 146
 147 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 148
 149         * breakpoint.c (is_hardware_watchpoint): Remove
 150         forward-declaration.
 151         (is_masked_watchpoint): Change return type to bool.
 152         (is_tracepoint): Likewise.
 153         (is_breakpoint): Likewise.
 154         (is_hardware_watchpoint): Likewise.
 155         (is_watchpoint): Likewise.
 156         (is_no_memory_software_watchpoint): Likewise.
 157         (is_catchpoint): Likewise.
 158         (breakpoint_1): Make FILTER parameter's return type bool.
 159         is_masked_watchpoint): Change return type to bool.
 160         (save_breakpoints): Make FILTER parameter's return type bool.
 161         * breakpoint.h (is_breakpoint): Change return type to bool.
 162         (is_watchpoint): Likewise.
 163         (is_catchpoint): Likewise.
 164         (is_tracepoint): Likewise.
 165
 166 2019-07-10  Tom Tromey  <tom@tromey.com>
 167
 168         * defs.h: Don't include gdbarch.h.
 169         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 170         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 171         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 172         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 173         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 174         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 175         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 176         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 177         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 178         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 179         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 180         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 181         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 182         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 183         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 184         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 185         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 186         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 187         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 188         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 189         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 190         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 191         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 192         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 193         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 194         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 195         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 196
 197 2019-07-10  Tom Tromey  <tromey@adacore.com>
 198
 199         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 200         * breakpoint.c (init_ada_exception_breakpoint): Register as
 201         bp_catchpoint.
 202         (print_one_breakpoint_location, print_one_breakpoint): Use
 203         is_ada_exception_catchpoint.
 204         * ada-lang.c (class ada_catchpoint_location): Pass
 205         bp_loc_software_breakpoint to bp_location constructor.
 206         (is_ada_exception_catchpoint): New function.
 207
 208 2019-07-10  Tom Tromey  <tromey@adacore.com>
 209
 210         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 211         VEC.
 212         (struct arm_exidx_entry): New method operator<.
 213         (struct arm_exidx_data) <section_maps>: Change type.
 214         (arm_exidx_data_free): Remove.
 215         (arm_exidx_data_key): Change type.  Move lower.
 216         (arm_exidx_new_objfile): Update.
 217         (arm_compare_exidx_entries): Remove.
 218         (arm_find_exidx_entry, _initialize_arm_tdep)
 219
 220 2019-07-10  Tom Tromey  <tromey@adacore.com>
 221
 222         * solib-spu.c (ocl_program_data_key): Change type.
 223         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 224         Update.
 225
 226 2019-07-10  Tom Tromey  <tromey@adacore.com>
 227
 228         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 229         (struct solib_aix_inferior_data) <library_list>: Change type.
 230         (solib_aix_inferior_data_handle): Change type.
 231         (get_solib_aix_inferior_data): Update.
 232         (solib_aix_free_library_list): Remove.
 233         (library_list_start_library): Update.
 234         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 235         return type.
 236         (solib_aix_get_library_list)
 237         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 238         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 239
 240 2019-07-10  Tom Tromey  <tromey@adacore.com>
 241
 242         * solib-dsbt.c (struct dsbt_info): Add initializers.
 243         (solib_dsbt_pspace_data): Change type.
 244         (dsbt_pspace_data_cleanup): Remove.
 245         (get_dsbt_info, _initialize_dsbt_solib): Update.
 246
 247 2019-07-10  Tom Tromey  <tromey@adacore.com>
 248
 249         * spu-tdep.c (spu_overlay_data): Change type.
 250         (spu_get_overlay_table, spu_overlay_new_objfile)
 251         (_initialize_spu_tdep): Update.
 252
 253 2019-07-10  Tom Tromey  <tromey@adacore.com>
 254
 255         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 256         destructor.
 257         (dbx_objfile_data_key): Change type and declare later.
 258         (DBX_SYMFILE_INFO): Rewrite.
 259         * dbxread.c (dbx_objfile_data_key): Change type.
 260         (dbx_symfile_init): Update.
 261         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 262         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 263         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 264
 265 2019-07-10  Tom Tromey  <tromey@adacore.com>
 266
 267         * jit.c (jit_program_space_key): Change type.  Move lower.
 268         (get_jit_program_space_data): Update.
 269         (jit_program_space_data_cleanup): Remove.
 270         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 271         Update.
 272         (struct jit_program_space_data): Add initializers.
 273
 274 2019-07-10  Tom Tromey  <tromey@adacore.com>
 275
 276         * solib-darwin.c (struct darwin_info): Add initializers.
 277         (solib_darwin_pspace_data): Change type.
 278         (darwin_pspace_data_cleanup): Remove.
 279         (get_darwin_info, _initialize_darwin_solib): Update.
 280
 281 2019-07-10  Tom Tromey  <tromey@adacore.com>
 282
 283         * remote-sim.c (struct sim_inferior_data): Add initializers,
 284         constructor, and destructor.
 285         (sim_inferior_data_key): Change type.  Move lower.
 286         (check_for_duplicate_sim_descriptor): Update.
 287         (get_sim_inferior_data): Use new.  Update.
 288         (~sim_inferior_data_cleanup): Rename from
 289         sim_inferior_data_cleanup.  Simplify.
 290         (gdbsim_close_inferior, simulator_command)
 291         (sim_command_completer, _initialize_remote_sim): Update.
 292         (next_pid, INITIAL_PID): Move earlier.
 293
 294 2019-07-10  Tom Tromey  <tromey@adacore.com>
 295
 296         * python/python-internal.h (create_thread_object): Return
 297         gdbpy_ref.
 298         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 299         * python/py-inferior.c (struct threadlist_entry): Add
 300         constructor.
 301         <thread_obj>: Now a gdbpy_ref.
 302         (thread_to_thread_object): Update.
 303         (add_thread_object): Use new.
 304         (delete_thread_object): Use delete.
 305         (infpy_threads): Update.
 306         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 307         GIL.
 308
 309 2019-07-10  Tom Tromey  <tromey@adacore.com>
 310
 311         * valops.c (value_cast): Specialize error message for Ada.
 312
 313 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 314
 315         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 316
 317 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 318
 319         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 320         bpstat_should_step): Return bool, adjust comments.
 321         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 322         bpstat_should_step): Likewise.
 323
 324 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 325
 326         * features/Makefile: Use feature target descriptions for Arm.
 327         * features/arm/arm-core.c: Generate new file.
 328         * features/arm/arm-fpa.c: Likewise.
 329         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 330         * features/arm/arm-m-profile.c: Likewise.
 331         * features/arm/arm-vfpv2.c: Likewise.
 332         * features/arm/arm-vfpv3.c: Likewise.
 333         * features/arm/xscale-iwmmxt.c: Likewise.
 334         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 335
 336 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 337
 338         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 339         ptrace earlier.
 340
 341 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 342
 343         * features/aarch64-pauth.c: Regenerate.
 344
 345 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 346
 347         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 348         bool.
 349         (bpstat_what): Use false instead of 0.
 350
 351 2019-07-09  Pedro Alves  <palves@redhat.com>
 352
 353         * break-catch-throw.c (is_exception_catchpoint): New.
 354         * breakpoint.c (print_one_breakpoint_location): New parameter
 355         'raw_loc'.  Handle it.  Use
 356         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 357         looking at the breakpoint's type.
 358         (print_one_breakpoint): If handling "maint info breakpoints", also
 359         print locations of exception catchpoints.
 360         * breakpoint.h (is_exception_catchpoint): Declare.
 361
 362 2019-07-09  Pedro Alves  <palves@redhat.com>
 363
 364         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 365         "addr" field.
 366         (allocate_location_exception_catchpoint): New.
 367         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 368         (initialize_throw_catchpoint_ops): Install
 369         allocate_location_exception_catchpoint as allocate_location
 370         method.
 371         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 372         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 373         bp_loc_other.
 374         (breakpoint_address_is_meaningful): Delete.
 375         (bl_address_is_meaningful): New.
 376         (breakpoint_locations_match): Adjust comment.
 377         (bp_location_from_bp_type): New, factored out of...
 378         (bp_location::bp_location(breakpoint *)): ... this.
 379         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 380         factored out of...
 381         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 382         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 383         breakpoint_address_is_meaningful.
 384         (bp_locations_compare): Adjust comment.
 385         (update_global_location_list): Use bl_address_is_meaningful
 386         instead of breakpoint_address_is_meaningful.
 387         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 388         explicit.
 389         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 390         * python/py-breakpoint.c (bppy_get_location): No longer check
 391         whether location is null.
 392
 393 2019-07-09  Pedro Alves  <palves@redhat.com>
 394
 395         PR c++/15468
 396         * breakpoint.c (print_one_breakpoint_location): Remove
 397         single-location assert.
 398
 399 2019-07-09  Tom Tromey  <tom@tromey.com>
 400
 401         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 402         * configure: Rebuild.
 403         * configure.ac: Change common to gdbsupport.
 404         * gdbsupport: Rename from common.
 405         * acinclude.m4: Change common to gdbsupport.
 406         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 407         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 408         gdbsupport.
 409         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 410         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 411         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 412         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 413         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 414         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 415         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 416         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 417         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 418         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 419         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 420         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 421         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 422         coff-pe-read.c, command.h, compile/compile-c-support.c,
 423         compile/compile-c.h, compile/compile-cplus-symbols.c,
 424         compile/compile-cplus-types.c, compile/compile-cplus.h,
 425         compile/compile-loc2c.c, compile/compile.c, completer.c,
 426         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 427         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 428         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 429         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 430         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 431         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 432         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 433         features/aarch64-core.c, features/aarch64-fpu.c,
 434         features/aarch64-pauth.c, features/aarch64-sve.c,
 435         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 436         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 437         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 438         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 439         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 440         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 441         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 442         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 443         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 444         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 445         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 446         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 447         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 448         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 449         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 450         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 451         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 452         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 453         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 454         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 455         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 456         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 457         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 458         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 459         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 460         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 461         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 462         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 463         minsyms.c, mips-linux-tdep.c, namespace.h,
 464         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 465         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 466         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 467         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 468         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 469         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 470         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 471         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 472         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 473         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 474         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 475         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 476         procfs.c, producer.c, progspace.h, psymtab.h,
 477         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 478         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 479         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 480         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 481         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 482         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 483         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 484         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 485         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 486         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 487         target-memory.c, target.c, target.h, target/waitstatus.c,
 488         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 489         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 490         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 491         unittests/array-view-selftests.c,
 492         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 493         unittests/common-utils-selftests.c,
 494         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 495         unittests/format_pieces-selftests.c,
 496         unittests/function-view-selftests.c,
 497         unittests/lookup_name_info-selftests.c,
 498         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 499         unittests/mkdir-recursive-selftests.c,
 500         unittests/observable-selftests.c,
 501         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 502         unittests/parse-connection-spec-selftests.c,
 503         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 504         unittests/scoped_fd-selftests.c,
 505         unittests/scoped_mmap-selftests.c,
 506         unittests/scoped_restore-selftests.c,
 507         unittests/string_view-selftests.c, unittests/style-selftests.c,
 508         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 509         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 510         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 511         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 512         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 513         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 514
 515 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 518         bool value.
 519         (decode_digits_ordinary): Set explicit_line field in sal.
 520         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 521         symtab_and_line that was set on an explicit line number in
 522         assembler code.  Do always update the recorded symtab and line if
 523         we do skip the prologue.
 524
 525 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * breakpoint.c (set_breakpoint_location_function): Remove
 528         explicit_loc parameter.
 529         (momentary_breakpoint_from_master): Update call to
 530         set_breakpoint_location_function.
 531         (add_location_to_breakpoint): Likewise.
 532
 533 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 536         required features based on default bfd type when no specific bfd
 537         is present.
 538
 539 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 540
 541         * NEWS: Mention that GDB printf and eval commands can now print
 542         C-style and Ada-style convenience var strings without
 543         calling the inferior.
 544         * printcmd.c (printf_c_string): Locally print GDB internal var
 545         instead of transiting via the inferior.
 546         (printf_wide_c_string): Likewise.
 547
 548 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 549
 550         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 551
 552 2019-07-04  Tom Tromey  <tom@tromey.com>
 553
 554         PR tui/24724:
 555         * tui/tui-winsource.c (tui_clear_source_content): Update.
 556         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 557         (tui_update_breakpoint_info): Update.
 558         (tui_set_exec_info_content): Update.
 559         * tui/tui-source.c (tui_set_source_content_nil): Update.
 560         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 561         has_break.
 562         * tui/tui-data.h (enum tui_bp_flag): New.
 563         (tui_bp_flags): New enum flags type.
 564         (struct tui_source_element) <break_mode>: Change type.  Rename
 565         from has_break.
 566         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 567         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 568         constants.
 569         * tui/tui-winsource.h: Fix comment.
 570
 571 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 572
 573         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 574         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 575         (store_fpregs_to_thread)
 576         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 577         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 578         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 579         (IWMMXT_REGS_SIZE): Add define.
 580         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 581         (fetch_vfp_regs, store_vfp_regs)
 582         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 583         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 584
 585 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 586
 587         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 588         defines.
 589         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 590         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 591         (ARM_INT_REGISTER_SIZE): ...to this.
 592         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 593         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 594         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 595         (arm_linux_collect_gregset, supply_nwfpe_register)
 596         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 597         defines.
 598         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 599         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 600         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 601         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 602         (arm_return_in_memory, arm_store_return_value)
 603         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 604         (arm_record_ld_st_multiple): Likewise.
 605         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 606         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 607
 608 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 609
 610         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 611         AARCH64_DISPLACED_MODIFIED_INSNS.
 612         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 613         (aarch64_displaced_step_copy_insn): Likewise.
 614         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 615         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 616         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 617         ARM_DISPLACED_MODIFIED_INSNS.
 618         * arm-tdep.c (arm_gdbarch_init): Likewise.
 619         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 620         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 621         (struct arm_displaced_step_closure): Use
 622         ARM_DISPLACED_MODIFIED_INSNS.
 623
 624 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 625
 626         * features/Makefile: Remove unused xml files.
 627         * features/aarch64.xml: Remove.
 628         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 629         * features/i386/amd64-avx-avx512.xml: Remove.
 630         * features/i386/amd64-avx-linux.xml: Remove.
 631         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 632         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 633         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 634         * features/i386/amd64-avx-mpx.xml: Remove.
 635         * features/i386/amd64-avx.xml: Remove.
 636         * features/i386/amd64-linux.xml: Remove.
 637         * features/i386/amd64-mpx-linux.xml: Remove.
 638         * features/i386/amd64-mpx.xml: Remove.
 639         * features/i386/amd64.xml: Remove.
 640         * features/i386/i386-avx-avx512-linux.xml: Remove.
 641         * features/i386/i386-avx-avx512.xml: Remove.
 642         * features/i386/i386-avx-linux.xml: Remove.
 643         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 644         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 645         * features/i386/i386-avx-mpx-linux.xml: Remove.
 646         * features/i386/i386-avx-mpx.xml: Remove.
 647         * features/i386/i386-avx.xml: Remove.
 648         * features/i386/i386-linux.xml: Remove.
 649         * features/i386/i386-mmx-linux.xml: Remove.
 650         * features/i386/i386-mmx.xml: Remove.
 651         * features/i386/i386-mpx-linux.xml: Remove.
 652         * features/i386/i386-mpx.xml: Remove.
 653         * features/i386/i386.xml: Remove.
 654         * features/i386/x32-avx-avx512-linux.xml: Remove.
 655         * features/i386/x32-avx-linux.xml: Remove.
 656         * features/i386/x32-linux.xml: Remove.
 657
 658 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 659
 660         * regformats/aarch64.dat: Remove.
 661         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 662         * regformats/i386/amd64-avx-linux.dat: Remove.
 663         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 664         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 665         * regformats/i386/amd64-linux.dat: Remove.
 666         * regformats/i386/amd64-mpx-linux.dat: Remove.
 667         * regformats/i386/amd64.dat: Remove.
 668         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 669         * regformats/i386/i386-avx-linux.dat: Remove.
 670         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 671         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 672         * regformats/i386/i386-linux.dat: Remove.
 673         * regformats/i386/i386-mmx-linux.dat: Remove.
 674         * regformats/i386/i386-mpx-linux.dat: Remove.
 675         * regformats/i386/i386.dat: Remove.
 676         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 677         * regformats/i386/x32-avx-linux.dat: Remove.
 678         * regformats/i386/x32-linux.dat: Remove.
 679
 680 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 681
 682         * aarch64-tdep.c: Remove xml self tests.
 683         * amd64-linux-tdep.c: Likewise.
 684         * amd64-tdep.c: Likewise.
 685         * i386-linux-tdep.c: Likewise.
 686         * i386-tdep.c: Likewise.
 687
 688 2019-07-03  Pedro Alves  <palves@redhat.com>
 689
 690         PR cli/24732
 691         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 692         (pipe_cmd_option_defs): New.
 693         (make_pipe_cmd_options_def_group): New.
 694         (pipe_command): Use gdb::option::process_options.
 695         (pipe_command_completer): New function.
 696         (_initialize_cli_cmds): Install completer for "pipe" command.
 697
 698 2019-07-03  Pedro Alves  <palves@redhat.com>
 699
 700         * cli/cli-option.c (union option_value) <string>: New field.
 701         (struct option_def_and_value): Add ctor, move ctor, dtor and
 702         use DISABLE_COPY_AND_ASSIGN.
 703         (option_def_and_value::clear_value): New.
 704         (parse_option, save_option_value_in_ctx, get_val_type_str)
 705         (add_setshow_cmds_for_options): Handle var_string.
 706         * cli-option.h (union option_def::var_address) <string>: New
 707         field.
 708         (struct string_option_def): New.
 709         * maint-test-options.c (struct test_options_opts): Add default
 710         ctor and use DISABLE_COPY_AND_ASSIGN.
 711         <string_opt>: New field.
 712         (test_options_opts::~test_options_opts): New.
 713         (test_options_opts::dump): Also dump "-string".
 714         (test_options_option_defs): Install "string.
 715
 716 2019-07-03  Pedro Alves  <palves@redhat.com>
 717
 718         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 719         option_value with a null enumeration.
 720         (complete_options): Save the option values in the context.
 721         (save_option_value_in_ctx): New, factored out from ...
 722         (process_options): ... here.
 723         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 724         of the function.
 725         * maint-test-options.c (test_options_opts::dump): New, factored
 726         out from ...
 727         (maintenance_test_options_command_mode): ... here.
 728         (maintenance_test_options_command_completion_result): Delete.
 729         (maintenance_test_options_command_completion_text): Update
 730         comment.
 731         (maintenance_show_test_options_completion_result): Change
 732         prototype.  Just print
 733         maintenance_test_options_command_completion_text.
 734         (save_completion_result): New.
 735         (maintenance_test_options_completer_mode): Pass options context to
 736         complete_options, and then save a dump.
 737         (_initialize_maint_test_options): Use add_cmd to install "maint
 738         show test-options-completion-result".
 739
 740 2019-07-03  Pedro Alves  <palves@redhat.com>
 741
 742         * NEWS (New commands): Mention "with" and "maint with".
 743         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 744         (with_command, with_command_completer): New.
 745         (pipe_command): Adjust to new repeat_previous
 746         interface.
 747         (_initialize_cli_cmds): Install the "with" command and its "w"
 748         alias.
 749         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 750         declarations.
 751         * cli/cli-setshow.c (parse_cli_var_uinteger)
 752         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 753         argument strings for all var_types.
 754         (get_setshow_command_value_string): New, factored out from ...
 755         (do_show_command): ... this.
 756         * cli/cli-setshow.h: Include <string>.
 757         (get_setshow_command_value_string): Declare.
 758         * command.h (repeat_previous): Now returns const char *.  Adjust
 759         comment.
 760         * maint.c: Include "cli/cli-cmds.h".
 761         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 762         (_initialize_maint_cmds): Register the "maintenance with" command.
 763         * top.c (repeat_previous): Move bits from pipe_command here:
 764         Return the saved command line, if any; error out if there's no
 765         command to relaunch.
 766
 767 2019-07-03  Pedro Alves  <palves@redhat.com>
 768
 769         * NEWS (New commands): Mention "maint set/show test-settings"
 770         instead of "maint test-settings".
 771         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 772         (maintenance_test_settings_set_list): Rename to ...
 773         (maintenance_set_test_settings_list): ... this.
 774         (maintenance_test_settings_show_list): Rename to  ...
 775         (maintenance_show_test_settings_list): ... this.
 776         (maintenance_test_settings_cmd): Delete.
 777         (maintenance_test_settings_set_cmd): ...
 778         (maintenance_set_test_settings_cmd): ... this.
 779         (maintenance_test_settings_show_cmd): ...
 780         (maintenance_show_test_settings_cmd): ... this.
 781         (maintenance_test_settings_show_value_cmd):
 782         (maintenance_show_test_settings_value_cmd): ... this.
 783         (_initialize_maint_test_settings): No longer install the "maint
 784         test-settings" prefix command.  Rename "maint test-settings set"
 785         to "maint set test-settings", and "maint test-settings show" to
 786         "maint show test-settings".  Adjust all subcommands.
 787
 788 2019-07-03  Pedro Alves  <palves@redhat.com>
 789
 790         * maint-test-settings.c: Fix file's intro comment.  Replace all
 791         references to "test-options" with references to "test-settings",
 792         in comments.
 793
 794 2019-07-03  Pedro Alves  <palves@redhat.com>
 795
 796         * maint-test-settings.c (maintenance_test_settings_xxx)
 797         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 798         New.
 799         (maintenance_test_settings_enums): Use them.
 800         (maintenance_test_settings_enum): Default to
 801         maintenance_test_settings_xxx.
 802         (_initialize_maint_test_settings): Initialize
 803         MAINTENANCE_TEST_SETTINGS_FILENAME.
 804
 805 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 806
 807         * breakpoint.h (remove_breakpoints_inf): Change return type to
 808         void, move function documentation here.
 809         * breakpoint.c (remove_breakpoints_inf): Change return type to
 810         void, move function documentation to header.
 811
 812 2019-07-02  Pedro Alves  <palves@redhat.com>
 813
 814         * NEWS (Completion improvements): Mention "info threads".
 815         * thread.c (struct info_threads_opts, info_threads_option_defs)
 816         (make_info_threads_options_def_group): New.
 817         (info_threads_command): Use gdb::option::process_options.
 818         (info_threads_command_completer): New.
 819         (_initialize_thread): Use gdb::option::build_help to build the
 820         help text for "info threads".
 821
 822 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 823
 824         * defs.h (generic_load): Move from here...
 825         * symfile.h (generic_load): ... to here.  Rename name parameter
 826         to args.
 827         * symfile.c (generic_load): Add comment.
 828
 829 2019-07-01  Tom Tromey  <tromey@adacore.com>
 830
 831         * dwarf2read.c
 832         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 833         declaration of without_params.  Fix formatting.
 834
 835 2019-07-01  Tom Tromey  <tromey@adacore.com>
 836
 837         * ada-exp.y (find_primitive_type): Update.
 838         * ada-lang.h (ada_lookup_symbol): Update.
 839         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 840         parameter.
 841         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 842
 843 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 844
 845         PR breakpoints/24541
 846         * gdbarch.c: Regenerate.
 847         * gdbarch.h: Regenerate.
 848         * gdbarch.sh: Add 'stap_adjust_register'.
 849         * i386-tdep.c: Include '<unordered_set>'.
 850         (i386_stap_adjust_register): New function.
 851         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 852         * stap-probe.c (stap_parse_register_operand): Call
 853         'gdbarch_stap_adjust_register'.
 854
 855 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 856
 857         PR python/24742
 858         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 859         * python/python.c (do_start_initialization): Use 'xmalloc'
 860         instead of 'PyMem_Malloc'.
 861
 862 2019-06-28  Tom Tromey  <tromey@adacore.com>
 863
 864         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 865         for Ada.
 866
 867 2019-06-27  Tom Tromey  <tromey@adacore.com>
 868
 869         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 870         objfile_key.
 871         (arm_find_mapping_symbol, arm_record_special_symbol)
 872         (_initialize_arm_tdep): Update.
 873         (arm_objfile_data_free): Remove.
 874
 875 2019-06-27  Tom Tromey  <tromey@adacore.com>
 876
 877         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 878         to cp_print_static_field.
 879
 880 2019-06-26  Tom Tromey  <tromey@adacore.com>
 881
 882         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 883         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 884         declare.
 885
 886 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 887
 888         * features/aarch64-core.c (create_feature_aarch64_core):
 889         Regenerate.
 890         * features/aarch64-core.xml: Add cpsr flags.
 891
 892 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 893
 894         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 895         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 896
 897 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 898
 899         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 900         field.
 901         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 902         use.
 903         (arm_record_special_symbol): Don't insert new symbol in sorted
 904         position, push it at the end.
 905
 906 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 907
 908         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 909         (arm_mapping_symbol_s): Remove.
 910         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 911         (arm_mapping_symbol_vec): New typedef.
 912         (struct arm_per_objfile): Add constructor.
 913         <section_maps>: Change type to
 914         std::unique_ptr<arm_mapping_symbol_vec[]>.
 915         (arm_compare_mapping_symbols): Remove.
 916         (arm_find_mapping_symbol): Adjust to section_maps type change.
 917         (arm_objfile_data_free): Call delete on arm_per_objfile.
 918         (arm_record_special_symbol): Adjust to section_maps type change.
 919         Allocate arm_per_objfile with new.
 920
 921 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 922
 923         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 924         with the command prefix.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 929         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 930
 931 2019-06-25  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 934         type.
 935         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 936         protected.
 937
 938 2019-06-25  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-winsource.c
 941         (tui_source_window_base::set_is_exec_point_at): Add check against
 942         LOA_ADDRESS.
 943
 944 2019-06-25  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-source.c (tui_set_source_content): Don't check before
 947         xfree.
 948         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 949
 950 2019-06-25  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-winsource.h (tui_update_source_window_as_is)
 953         (tui_alloc_source_buffer, tui_line_is_displayed)
 954         (tui_addr_is_displayed): Change type of win_info.
 955         * tui/tui-winsource.c (tui_update_source_window_as_is)
 956         (tui_clear_source_content, tui_show_source_line)
 957         (tui_show_source_content, tui_source_window_base::refill)
 958         (tui_source_window_base::set_is_exec_point_at)
 959         (tui_source_window_base::set_is_exec_point_at)
 960         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 961         (tui_alloc_source_buffer, tui_line_is_displayed)
 962         (tui_addr_is_displayed): Change type of win_info.  Update.
 963         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 964         (tui_source_window_base::do_make_visible_with_new_height):
 965         Update.
 966         * tui/tui-source.c (tui_set_source_content)
 967         (tui_set_source_content_nil)
 968         (tui_source_window::do_scroll_vertical): Update.
 969         * tui/tui-layout.c (show_layout): Update.
 970         * tui/tui-disasm.c (tui_set_disassem_content)
 971         (tui_disasm_window::do_scroll_vertical): Update.
 972         * tui/tui-data.h (tui_win_content): Remove.
 973         (struct tui_gen_win_info) <content, content_size>: Remove.
 974         (struct tui_source_element): Add initializers and destructor.
 975         (union tui_which_element, struct tui_win_element): Remove.
 976         (struct tui_source_window_base) <content>: New field.
 977         (struct tui_data_window): Remove destructor.
 978         (tui_alloc_content, tui_free_win_content)
 979         (tui_free_all_source_wins_content): Don't declare.
 980         * tui/tui-data.c (tui_initialize_static_data): Update.
 981         (init_content_element, tui_alloc_content): Remove.
 982         (~tui_gen_win_info): Update.
 983         (~tui_data_window, tui_free_all_source_wins_content)
 984         (tui_free_win_content, free_content, free_content_elements):
 985         Remove.
 986
 987 2019-06-25  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-winsource.h (tui_clear_source_content)
 990         (tui_erase_source_content, tui_show_source_content): Change type
 991         of win_info.
 992         * tui/tui-winsource.c (tui_clear_source_content)
 993         (tui_erase_source_content, tui_show_source_content): Change type
 994         of win_info.
 995         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 996         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 997         win_info.
 998         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 999         win_info.
1000         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1001
1002 2019-06-25  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-winsource.c (tui_clear_source_content)
1005         (tui_source_window_base::set_is_exec_point_at): Update.
1006         * tui/tui-source.c (tui_set_source_content_nil): Update.
1007         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1008         a bool.
1009         * tui/tui-data.c (init_content_element): Update.
1010
1011 2019-06-25  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1014         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1015         * tui/tui-layout.c (init_and_make_win): Update.
1016         * tui/tui.h (enum tui_win_type): Update.
1017         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1018         tui_win_is_auxillary.
1019         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1020         tui_win_is_auxillary.
1021
1022 2019-06-25  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1025         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1026         (tui_delete_data_content_windows, tui_display_all_data)
1027         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1028         Update.
1029         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1030         * tui/tui-regs.c (tui_last_regs_line_no)
1031         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1032         (tui_show_registers): Update.
1033         (tui_show_register_group): Return void.  Update.
1034         (tui_display_registers_from, tui_display_reg_element_at_line)
1035         (tui_display_registers_from_line, tui_check_register_values):
1036         Update.
1037         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1038         member.
1039         (struct tui_data_window) <regs_content>: Now a std::vector.
1040         <regs_content_count>: Remove.
1041         (tui_add_content_elements, tui_free_data_content): Don't declare.
1042         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1043         (init_content_element): Remove DATA_WIN case.  Add assert.
1044         (tui_add_content_elements): Remove.
1045         (tui_data_window): Update.
1046         (tui_free_data_content): Remove.
1047         (free_content_elements): Remove DATA_WIN case.
1048
1049 2019-06-25  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-data.c (tui_data_item_window): Update.
1052         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1053         * tui/tui-windata.c (tui_display_all_data)
1054         (tui_display_data_from_line): Update.
1055         (tui_check_data_values): Remove.
1056         * tui/tui-regs.c (tui_show_register_group)
1057         (tui_display_reg_element_at_line): Update.
1058         * tui/tui-hooks.c (tui_register_changed)
1059         (tui_refresh_frame_and_register_information): Call
1060         tui_check_register_values.
1061         * tui/tui-data.h (struct tui_data_window) <data_content,
1062         data_content_count, data_type>: Remove.
1063         (enum tui_data_type): Remove.
1064
1065         * tui/tui-data.c (tui_data_window::clear_detail)
1066         (~tui_data_window): Update.
1067
1068 2019-06-25  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1071         declare.
1072         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1073         Rename from tui_first_data_item_displayed.  Update.
1074         (tui_data_window::refresh_all)
1075         (tui_data_window::do_scroll_vertical): Update.
1076         * tui/tui-data.h (struct tui_data_window)
1077         <first_data_item_displayed>: Declare new method.
1078
1079 2019-06-25  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1082         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1083         contents...
1084         (tui_initialize_static_data): ...here.
1085
1086 2019-06-25  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1089         (tui_display_registers_from, tui_check_register_values): Update.
1090         (tui_display_register): Remove win_info parameter; update.
1091         (tui_get_register): Change type of parameters.
1092         * tui/tui-data.h (struct tui_data_element): Remove.
1093         (union tui_which_element) <data>: Remove.
1094         <data_window>: Change type.
1095         (struct tui_data_item_window): New.
1096         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1097         case.  Add assert.
1098         (~tui_data_item_window): New destructor.
1099         (free_content_elements): Remove DATA_ITEM_WIN case.
1100
1101 2019-06-25  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1104         Remove.
1105
1106 2019-06-25  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-data.h (struct tui_command_element): Remove.
1109         (union tui_which_element) <command>: Remove.
1110         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1111         assert.
1112         (free_content_elements): Remove CMD_WIN case.
1113
1114 2019-06-25  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-layout.c (tui_set_layout): Update.
1117         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1118         * tui/tui-data.c (layout_def): Update.
1119
1120 2019-06-25  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1123         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1124         (tui_source_window_base::set_new_height): Update.
1125         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1126         Update.
1127         (tui_set_locator_fullname, tui_set_locator_info)
1128         (tui_show_frame_info): Update.
1129         * tui/tui-source.c (tui_set_source_content)
1130         (tui_source_is_displayed): Update.
1131         * tui/tui-layout.c (show_source_disasm_command, show_data)
1132         (show_source_or_disasm_and_command): Update.
1133         * tui/tui-disasm.c (tui_set_disassem_content)
1134         (tui_get_begin_asm_address): Update.
1135         * tui/tui-data.h (struct tui_locator_element): Remove.
1136         (union tui_which_element) <locator>: Remove.
1137         (struct tui_locator_window): New.
1138         (tui_locator_win_info_ptr): Change return type.
1139         * tui/tui-data.c (_locator): Change type.
1140         (tui_locator_win_info_ptr): Change return type.
1141         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1142         (tui_alloc_content): Add assert.
1143
1144 2019-06-25  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-winsource.c
1147         (tui_exec_info_window::maybe_allocate_content): New method.
1148         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1149         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1150         (make_source_or_disasm_window): Add cast.
1151         * tui/tui-data.h (union tui_which_element) <simple_string>:
1152         Remove.
1153         (struct tui_source_info): New.
1154         (struct tui_source_window_base) <execution_info>: Change type.
1155         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1156         case, and add assert.
1157         (tui_alloc_content): Add assert.
1158
1159 2019-06-25  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1162         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1163         * tui/tui-data.c (tui_alloc_win_info): Remove.
1164
1165 2019-06-25  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1168         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1169         can_highlight.
1170
1171 2019-06-25  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1174         make_visible_with_new_height method.
1175         (tui_win_info::make_visible_with_new_height): New method.
1176         (tui_source_window_base::do_make_visible_with_new_height)
1177         (tui_data_window::do_make_visible_with_new_height)
1178         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1179         (make_visible_with_new_height): Remove.
1180         (tui_resize_all, tui_adjust_win_heights): Use
1181         make_visible_with_new_height method.
1182         * tui/tui-data.h (struct tui_win_info)
1183         <do_make_visible_with_new_height, make_visible_with_new_height>:
1184         New methods.
1185         (struct tui_source_window_base, struct tui_data_window)
1186         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1187         methods.
1188
1189 2019-06-25  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1192         method.
1193         (update_tab_width): Call update_tab_width method.
1194         * tui/tui-data.h (struct tui_win_info)
1195         (struct tui_source_window_base) <update_tab_width>: New methods.
1196
1197 2019-06-25  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1200         parameter.
1201         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1202         parameter.
1203         (tui_gen_win_info::make_visible): Update.
1204         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1205         parameter.
1206         * tui/tui-data.h (enum tui_box): New enum.
1207         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1208
1209 2019-06-25  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1212         init_and_make_win for EXEC_INFO_WIN.
1213         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1214         longer inline.
1215         (struct tui_win_info) <~tui_win_info>: Inline.
1216         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1217         Don't declare.
1218         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1219         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1220         Remove.
1221         (tui_initialize_static_data): Update.
1222         (~tui_gen_win_info): Handle more cleanup here.
1223         (~tui_source_window_base): Delete "execution_info".
1224         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-layout.c (make_command_window): Don't set
1229         can_highlight.
1230         (show_source_disasm_command): Call the reset method.
1231         (show_data): Don't set can_highlight.  Call the reset method.
1232         (tui_gen_win_info::reset): Rename from init_gen_win_info
1233         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1234         (show_source_or_disasm_and_command): Call the reset method.
1235         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1236         (struct tui_cmd_window): Set can_highlight.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1241         from make_visible.
1242         (tui_make_visible, tui_make_invisible): Rewrite.
1243         (tui_win_info::make_visible): Remove.
1244         (tui_source_window_base::make_visible): Update.
1245         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1246         method.  Moved from...
1247         (struct tui_win_info) <make_visible>: ...here.
1248
1249 2019-06-25  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-winsource.c
1252         (tui_source_window_base::do_scroll_horizontal): Remove direction
1253         parameter.
1254         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1255         direction parameter.
1256         * tui/tui-win.c (tui_win_info::forward_scroll)
1257         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1258         (tui_win_info::right_scroll): Update.
1259         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1260         direction parameter.
1261         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1262         direction parameter.
1263         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1264         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1265         Remove direction parameter.
1266         (struct tui_source_window_base, struct tui_source_window)
1267         (struct tui_disasm_window, struct tui_data_window)
1268         (struct tui_cmd_window): Update.
1269
1270 2019-06-25  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-winsource.h (tui_set_exec_info_content)
1273         (tui_show_exec_info_content, tui_erase_exec_info_content)
1274         (tui_clear_exec_info_content, tui_update_exec_info): Change
1275         argument to tui_source_window_base.
1276         * tui/tui-winsource.c (tui_set_exec_info_content)
1277         (tui_show_exec_info_content, tui_erase_exec_info_content)
1278         (tui_clear_exec_info_content, tui_update_exec_info): Change
1279         argument to tui_source_window_base.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1284         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1285
1286 2019-06-25  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1289         check.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1294         type to void.
1295         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1296         type to void.
1297         * tui/tui-source.c (tui_set_source_content): Update.
1298         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1299
1300 2019-06-25  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-win.c (window_name_completer, tui_set_focus)
1303         (tui_all_windows_info): Use name method.
1304         * tui/tui-data.h (struct tui_gen_win_info)
1305         (struct tui_source_window, struct tui_disasm_window)
1306         (struct tui_data_window, struct tui_cmd_window) <name>: New
1307         method.
1308         (tui_win_name): Don't declare.
1309         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1310         (tui_win_name): Remove.
1311
1312 2019-06-25  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-winsource.h (tui_update_source_window)
1315         (tui_update_source_window_as_is): Change parameter type.
1316         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1317         to be a tui_source_window_base.
1318         (tui_update_source_window_as_is): Likewise.
1319         * tui/tui-win.c (make_visible_with_new_height): Update.
1320
1321 2019-06-25  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-winsource.c (tui_erase_source_content)
1324         (tui_show_source_content, tui_show_exec_info_content)
1325         (tui_erase_exec_info_content): Use refresh_window method.
1326         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1327         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1328         from tui_refresh_win.
1329         (tui_data_window::refresh_window): New method.
1330         (tui_win_info::refresh, tui_source_window_base::refresh)
1331         (tui_refresh_all): Use refresh_window method.
1332         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1333         method.
1334         * tui/tui-regs.c (tui_display_register): Call refresh_window
1335         method.
1336         * tui/tui-layout.c (show_source_disasm_command)
1337         (show_source_or_disasm_and_command): Call refresh_window method.
1338         * tui/tui-data.h (struct tui_gen_win_info)
1339         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1340         New method.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui.c (tui_rl_other_window, tui_enable)
1345         (tui_is_window_visible, tui_get_command_dimension): Update.
1346         * tui/tui-winsource.c (tui_update_source_window_as_is)
1347         (tui_clear_source_content, tui_erase_source_content)
1348         (tui_show_source_line, tui_source_window_base::refill)
1349         (tui_source_window_base::do_scroll_horizontal)
1350         (tui_source_window_base::set_is_exec_point_at)
1351         (tui_update_breakpoint_info, tui_set_exec_info_content)
1352         (tui_alloc_source_buffer, tui_line_is_displayed)
1353         (tui_addr_is_displayed): Update.
1354         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1355         (tui_check_and_display_highlight_if_needed)
1356         (tui_win_info::make_visible, tui_win_info::refresh)
1357         (tui_refresh_all): Update.
1358         * tui/tui-windata.c (tui_first_data_item_displayed)
1359         (tui_delete_data_content_windows, tui_erase_data_content)
1360         (tui_display_all_data, tui_data_window::refresh_all)
1361         (tui_check_data_values): Update.
1362         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1363         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1364         (tui_win_info::backward_scroll, tui_refresh_all_win)
1365         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1366         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1367         (tui_source_window_base::set_new_height)
1368         (tui_data_window::set_new_height)
1369         (make_invisible_and_set_new_height)
1370         (make_visible_with_new_height, new_height_ok)
1371         (parse_scrolling_args): Update.
1372         * tui/tui-stack.c (tui_show_frame_info): Update.
1373         * tui/tui-source.c (tui_set_source_content)
1374         (tui_set_source_content_nil, tui_source_is_displayed)
1375         (tui_source_window::do_scroll_vertical): Update.
1376         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1377         (tui_display_registers_from, tui_display_reg_element_at_line)
1378         (tui_check_register_values, tui_reg_command): Update.
1379         * tui/tui-layout.c (tui_default_win_height)
1380         (show_source_disasm_command, show_data, init_and_make_win)
1381         (show_source_or_disasm_and_command): Update.
1382         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1383         (tui_redisplay_readline, tui_mld_flush)
1384         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1385         (tui_getc): Update.
1386         * tui/tui-disasm.c (tui_set_disassem_content)
1387         (tui_disasm_window::do_scroll_vertical): Update.
1388         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1389         Now virtual.
1390         (struct tui_win_info): Derive from tui_gen_win_info.
1391         <~tui_win_info>: Mark as override.
1392         <generic>: Remove member.
1393         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1394         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1395         (~tui_data_window, ~tui_win_info)
1396         (tui_free_all_source_wins_content): Update.
1397         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1398
1399 2019-06-25  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-layout.c (init_and_make_win): Use new.
1402         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1403         destructor, initializers.
1404         (tui_alloc_generic_win_info): Don't declare.
1405         * tui/tui-data.c (_locator): Add argument to constructor.
1406         (source_win, disasm_win): New globals.
1407         (exec_info): Remove.
1408         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1409         Update.
1410         (tui_alloc_generic_win_info): Remove.
1411         (init_content_element): Use new.
1412         (tui_win_info::tui_win_info): Update.
1413         (free_content_elements) <case DATA_WIN>: Use delete.
1414
1415 2019-06-25  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1418         * tui/tui-windata.c (tui_first_data_item_displayed)
1419         (tui_delete_data_content_windows): Update.
1420         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1421         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1422         (tui_display_registers_from, tui_check_register_values): Update.
1423         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1424         pointer.
1425         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1426         window.
1427         (tui_free_data_content): Update.
1428         (free_content_elements) <case DATA_WIN>: Free the window.
1429
1430 2019-06-25  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1433         Update.
1434         * tui/tui-layout.c (make_command_window)
1435         (show_source_disasm_command, show_data, init_and_make_win)
1436         (show_source_or_disasm_and_command): Update.
1437         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1438         method.
1439         <can_highight, is_highlighted>: Now bool.
1440         (tui_set_win_highlight): Don't declare.
1441         * tui/tui-data.c (tui_set_win_highlight): Remove.
1442
1443 2019-06-25  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-wingeneral.c (make_visible): Remove check of window
1446         type.
1447
1448 2019-06-25  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-win.c (tui_win_info::max_height)
1451         (tui_cmd_window::max_height): New methods.
1452         (new_height_ok): Call max_height.
1453         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1454         <max_height>: New method.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-win.c (tui_source_window_base::set_new_height)
1459         (tui_data_window::set_new_height): New methods.
1460         (make_invisible_and_set_new_height): Call set_new_height method.
1461         * tui/tui-data.h (struct tui_win_info)
1462         (struct tui_source_window_base, struct tui_data_window)
1463         <set_new_height>: New method.
1464
1465 2019-06-25  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1468         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1469         tui_refresh_data_win.
1470         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1471         method.
1472         (tui_refresh_all_win): Call the refresh_all method.
1473         (tui_set_focus): Likewise.
1474         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1475         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1476         Likewise.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-winsource.h (tui_refill_source_window)
1481         (tui_set_is_exec_point_at): Don't declare.
1482         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1483         (tui_source_window_base::refill): Rename from
1484         tui_refill_source_window.
1485         (tui_source_window_base::do_scroll_horizontal): Update.
1486         (tui_source_window_base::set_is_exec_point_at): Rename from
1487         tui_set_is_exec_point_at.
1488         (tui_update_all_breakpoint_info): Update.
1489         * tui/tui-stack.c (tui_show_frame_info): Update.
1490         * tui/tui-layout.c (show_data): Add cast.
1491         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1492         * tui/tui-data.h (struct tui_source_window_base) <refill,
1493         set_is_exec_point_at>: New methods.
1494         (tui_source_windows, tui_add_to_source_windows): Update types.
1495         (tui_add_to_source_windows): Remove redundant declaration.
1496         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1497         (tui_source_windows): Change return type.
1498         (tui_clear_source_windows_detail): Update.
1499         (tui_add_to_source_windows): Change type of parameter.
1500         (tui_free_all_source_wins_content): Update.
1501
1502 2019-06-25  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-wingeneral.c (tui_win_info::refresh)
1505         (tui_source_window_base::refresh): New methods.
1506         (tui_refresh_all): Call the refresh method.
1507         * tui/tui-data.h (struct tui_win_info)
1508         (struct tui_source_window_base) <refresh>: New method.
1509
1510 2019-06-25  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui.h (tui_is_window_visible): Return bool.
1513         * tui/tui.c (tui_is_window_visible): Return bool.
1514         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1515         (tui_make_visible, tui_make_invisible)
1516         (tui_win_info::make_visible)
1517         (tui_source_window_base::make_visible, make_all_visible)
1518         (tui_make_all_visible, tui_make_all_invisible): Update.
1519         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1520         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1521         bool.
1522         (struct tui_win_info, struct tui_source_window_base)
1523         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1524         * tui/tui-data.c (tui_init_generic_part): Update.
1525
1526 2019-06-25  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1529         (tui_source_window_base::make_visible): New methods.
1530         (make_all_visible): Make method call.
1531         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1532         (struct tui_source_window_base, struct tui_cmd_window): Override
1533         make_visible.
1534         (tui_win_is_source_type): Don't declare.
1535         * tui/tui-data.c (tui_win_is_source_type): Remove.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1540         NULL check.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1545         Inline constructor.  Add initializers for members.
1546         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1547         constructors; now inline in class.
1548
1549 2019-06-25  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-regs.c (tui_show_registers): Update.
1552         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1553         bool.
1554         * tui/tui-data.c (tui_data_window::clear_detail)
1555         (tui_data_window): Update.
1556
1557 2019-06-25  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-windata.c (tui_display_all_data)
1560         (tui_display_data_from_line, tui_display_data_from)
1561         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1562         Update.
1563         * tui/tui-regs.c (tui_last_regs_line_no)
1564         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1565         (tui_show_registers, tui_show_register_group)
1566         (tui_display_registers_from, tui_display_reg_element_at_line)
1567         (tui_display_registers_from_line, tui_check_register_values)
1568         (tui_reg_next, tui_reg_prev): Update.
1569         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1570         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1571         tui_data_window.
1572         (struct tui_win_info) <detail>: Remove.  Add new fields from
1573         tui_data_info.
1574         (TUI_DATA_WIN): Add cast.
1575         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1576         (~tui_data_window): Simplify.
1577
1578 2019-06-25  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-layout.c (show_source_disasm_command)
1581         (show_source_or_disasm_and_command): Update.
1582         * tui/tui-io.c (update_cmdwin_start_line)
1583         (tui_redisplay_readline): Update.
1584         * tui/tui-data.h (struct tui_command_info): Remove.
1585         (struct tui_win_info) <detail>: Remove command_info member.
1586         (struct tui_data_window) <start_line>: New member, from
1587         tui_command_info.
1588         (TUI_CMD_WIN): Add casts.
1589
1590 2019-06-25  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-winsource.c (tui_update_source_window)
1593         (tui_refill_source_window)
1594         (tui_source_window_base::do_scroll_horizontal)
1595         (tui_update_breakpoint_info, tui_set_exec_info_content)
1596         (tui_show_exec_info_content, tui_erase_exec_info_content)
1597         (tui_clear_exec_info_content): Update.
1598         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1599         Update.
1600         * tui/tui-win.c (make_invisible_and_set_new_height)
1601         (make_visible_with_new_height): Update.
1602         * tui/tui-source.c (tui_set_source_content)
1603         (tui_show_symtab_source): Update.
1604         * tui/tui-layout.c (extract_display_start_addr)
1605         (show_source_disasm_command, show_data)
1606         (make_source_or_disasm_window)
1607         (show_source_or_disasm_and_command): Update.
1608         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1609         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1610         "gdbarch".
1611         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1612         to tui_source_window_base.
1613         (struct tui_win_info) <detail>: Remove source_info member.
1614         (struct tui_source_window_base) <has_locator>: Inline.
1615         Move contents from tui_source_info; rename has_locator member to
1616         m_has_locator.
1617         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1618         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1619         header file.
1620         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1621         Simplify.
1622         (tui_free_all_source_wins_content): Cast to
1623         tui_source_window_base.
1624
1625 2019-06-25  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-win.c (make_invisible_and_set_new_height)
1628         (make_visible_with_new_height): Call has_locator method.
1629         * tui/tui-layout.c (show_source_disasm_command, show_data)
1630         (show_source_or_disasm_and_command): Update for bool change.
1631         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1632         (tui_win_info) <has_locator>: New method.
1633         (struct tui_source_window_base) <has_locator>: New method.
1634         (tui_win_has_locator): Don't declare.
1635         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1636         from tui_win_has_locator.
1637         (tui_source_window_base): Use false, not FALSE.
1638
1639 2019-06-25  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1642         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1643         clear_detail method directly.
1644         (tui_clear_win_detail): Remove.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1649         "this", not TUI_DISASM_WIN.
1650
1651 2019-06-25  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1654         declare.
1655         * tui/tui-winsource.c
1656         (tui_source_window_base::do_scroll_horizontal): Rename from
1657         tui_horizontal_source_scroll.
1658         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1659         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1660         from tui_vertical_data_scroll.
1661         * tui/tui-win.h (tui_scroll): Don't declare.
1662         * tui/tui-win.c (tui_win_info::forward_scroll)
1663         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1664         (tui_win_info::right_scroll): Rename and update.
1665         (tui_scroll_forward_command, tui_scroll_backward_command)
1666         (tui_scroll_left_command, tui_scroll_right_command): Update.
1667         (tui_scroll): Remove.
1668         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1669         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1670         from tui_vertical_source_scroll.
1671         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1672         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1673         from tui_vertical_disassem_scroll.
1674         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1675         do_scroll_horizontal>: New methods.
1676         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1677         Likewise.
1678         (struct tui_source_window_base): Add do_scroll_horizontal.
1679         (struct tui_source_window, struct tui_disasm_window): Add
1680         do_scroll_vertical.
1681         (struct tui_data_window, struct tui_cmd_window): Add
1682         do_scroll_horizontal and do_scroll_vertical.
1683         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-data.h (struct tui_source_window_base): New struct.
1688         (struct tui_source_window): Derive from tui_source_window_base.
1689         (struct tui_disasm_window): New struct.
1690         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1691         from tui_source_window::clear_detail.
1692         (tui_source_window_base): Rename from tui_source_window.
1693         (~tui_source_window_base): Rename from ~tui_source_window.
1694         (tui_alloc_win_info): Create a tui_disasm_window.
1695
1696 2019-06-25  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-data.h (struct tui_source_window)
1699         (struct tui_data_window): Declare destructors.
1700         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1701         destructors.
1702         (tui_win_info): Simplify.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-winsource.c (tui_display_main)
1707         (tui_update_source_windows_with_addr)
1708         (tui_update_all_breakpoint_info): Update.
1709         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1710         (new_height_ok, parse_scrolling_args): Update.
1711         * tui/tui-stack.c (tui_show_frame_info): Update.
1712         * tui/tui-data.h (struct tui_list): Remove.
1713         (tui_source_windows): Return a reference to a std::vector.
1714         * tui/tui-data.c (source_windows): Now a std::vector.
1715         (tui_source_windows): Change return type.
1716         (tui_clear_source_windows): Rewrite.
1717         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1718         (tui_free_all_source_wins_content): Rewrite.
1719
1720 2019-06-25  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1723         (struct tui_data_window, struct tui_cmd_window): Declare
1724         clear_detail method.
1725         * tui/tui-data.c (tui_source_window::clear_detail)
1726         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1727         methods.
1728         (tui_clear_win_detail): Simplify.
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-layout.c (make_source_window, make_disasm_window)
1733         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1734         Return the new window.
1735         (show_source_disasm_command, show_data)
1736         (show_source_or_disasm_and_command): Update.
1737
1738 2019-06-25  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1741         parameter.  Return the new window.
1742         (show_source_disasm_command): Update and remove NULL check.
1743         (show_source_or_disasm_and_command): Update.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1748
1749 2019-06-25  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-data.h (struct tui_win_info): Make constructor
1752         protected.  Make destructor virtual.  Add initializers.
1753         (tui_source_window, tui_data_window, tui_cmd_window): New
1754         classes.
1755         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1756         constructor.  Add "type" parameter.
1757         (tui_source_window, tui_data_window, tui_cmd_window): New
1758         constructors.
1759         (tui_alloc_win_info): Instantiate the appropriate subclass.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-win.c (tui_resize_all): Use delete.
1764         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1765         destructor.
1766         (tui_free_window): Don't declare.
1767         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1768         Update.
1769
1770 2019-06-25  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-data.h (struct tui_win_info): Add constructor.
1773         * tui/tui-data.c (tui_alloc_win_info): Use new.
1774         (tui_free_window): Use delete.
1775
1776 2019-06-22  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1779         declare.
1780         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1781
1782 2019-06-22  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1785         declare.
1786         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1787
1788 2019-06-22  Tom de Vries  <tdevries@suse.de>
1789
1790         * dwarf2read.c (create_addrmap_from_aranges)
1791         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1792         instead of '%zu'.
1793
1794 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1795
1796         * dwarf2read.h (dwarf2_section_info_def): Remove.
1797         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1798         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1799         std::vector<dwarf2_section_info>.
1800         (struct dwo_file) <~dwo_file>: Remove.
1801         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1802         types field.
1803         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1804         (dwarf2_read_debug_names): Likewise.
1805         (create_debug_types_hash_table): Change parameter type to
1806         array_view, adjust code accordingly.
1807         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1808         (partial_die_info::fixup): Likewise.
1809         (determine_prefix): Likewise.
1810         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1811
1812 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1813
1814         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1815         gdb_bfd_ref_ptr.
1816         <~dwo_file>: Remove call to gdb_bfd_unref.
1817         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1818         gdb_bfd_ref_ptr::get.
1819
1820 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1821
1822         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1823         type to htab_up.
1824         * dwarf2read.c (struct dwo_file): Initialize fields.
1825         <~dwo_file>: New.
1826         (free_dwo_file): Remove, move content to ~dwo_file.
1827         (struct dwo_file_deleter): Remove.
1828         (dwo_file_up>: Remove custom deleter.
1829         (free_dwo_files): Remove.
1830         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1831         dwo_files.
1832         (process_skeletonless_type_units): Call unique_ptr::get.
1833         (allocate_dwo_file_hash_table): Add deleter to created hash
1834         table.  Change return type to htab_up.
1835         (lookup_dwo_file_slot): Don't memset dwo_file, call
1836         unique_ptr::get.
1837         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1838         (create_dwo_unit_in_dwp_v2): Likewise.
1839         (open_and_init_dwo_file): Likewise.
1840         (free_dwo_file_from_slot): Remove.
1841
1842 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1843
1844         * dwarf2read.h (struct dwarf2_section_info) <readin,
1845         is_virtual>: Change type to bool.
1846         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1847         true instead of 1.
1848
1849 2019-06-19  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-data.h (tui_init_content_element): Don't declare.
1852
1853 2019-06-19  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-data.h (tui_init_win_info): Don't declare.
1856
1857 2019-06-19  Tom de Vries  <tdevries@suse.de>
1858
1859         * dwarf2read.h (abstract_to_concrete): Change type to
1860         std::unordered_map<sect_offset, std::vector<sect_offset>,
1861         gdb::hash_enum<sect_offset>>.
1862
1863 2019-06-19  Tom Tromey  <tromey@adacore.com>
1864
1865         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1866         EVAL_AVOID_SIDE_EFFECTS specially.
1867
1868 2019-06-19  Tom Tromey  <tromey@adacore.com>
1869
1870         * source-cache.c (highlighter): New global.
1871         (source_cache::get_source_lines): Create a highlighter on demand.
1872
1873 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * defs.h (deprecated_interactive_hook): Delete declaration.
1876         * interps.c (clear_interpreter_hooks): Remove use of
1877         deprecated_interactive_hook.
1878         * top.c (deprecated_interactive_hook): Delete definition.
1879         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1880
1881 2019-06-18  Tom de Vries  <tdevries@suse.de>
1882
1883         PR gdb/24515
1884         * dwarf2read.h (abstract_to_concrete): Change type from
1885         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1886         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1887         * dwarf2read.c (read_variable): Update.
1888         (dwarf2_fetch_die_loc_sect_off): Update.
1889
1890 2019-06-17  Tom de Vries  <tdevries@suse.de>
1891
1892         PR gdb/24617
1893         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1894         accessing parent[parent_len - 1].
1895
1896 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1897
1898         PR gdb/24364
1899         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1900         call dtrace_process_dof with NULL dof.
1901
1902 2019-06-16  Tom de Vries  <tdevries@suse.de>
1903
1904         PR gdb/24445
1905         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1906
1907 2019-06-16  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1910         (make_all_visible): Use address of member.
1911
1912 2019-06-16  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1915         (tui_free_window, free_content, free_content_elements): Remove
1916         unnecessary cast.
1917         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1918         cast.
1919         * tui/tui-regs.c (tui_show_register_group)
1920         (tui_display_registers_from, tui_display_reg_element_at_line):
1921         Remove unnecessary cast.
1922
1923 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * linux-nat.c (normal_mask): Delete.
1926         (_initialize_linux_nat): Don't initialise normal_mask.
1927
1928 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1929
1930         PR gdb/24445
1931         * dwarf-index-write.h (write_psymtabs_to_index): Add
1932         dwz_basename parameter.
1933         * dwarf-index-write.c (write_gdbindex): Move file writing to
1934         write_gdbindex_1.  Change return type void.
1935         (assert_file_size): Move up, remove filename parameter.
1936         (write_gdbindex_1): New function.
1937         (write_debug_names): Change return type to void, call
1938         assert_file_size.
1939         (struct index_wip_file): New struct.
1940         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1941         file logic to index_wip_file.  Write index for dwz file if
1942         needed.
1943         (save_gdb_index_command): Pass basename of dwz file, if present.
1944         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1945         build-id of dwz file, if present.
1946         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1947         (dwarf2_get_dwz_file): Likewise.
1948         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1949         (dwarf2_get_dwz_file): Likewise.
1950
1951 2019-06-16  Tom Tromey  <tom@tromey.com>
1952
1953         * coffread.c (process_coff_symbol): Use xstrdup.
1954         * value.c (create_internalvar): Use xstrdup.
1955
1956 2019-06-16  Tom Tromey  <tom@tromey.com>
1957
1958         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1959         * breakpoint.c (stopin_command, stopat_command)
1960         (until_break_command, decode_location_default): Remove unnecessary
1961         cast.
1962         * utils.c (subset_compare): Remove unnecessary cast.
1963         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1964         cast.
1965         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1966         cast.
1967         * infcmd.c (path_command): Remove unnecessary cast.
1968         * coffread.c (decode_type): Remove unnecessary cast.
1969         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1970         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1971         * tui/tui-stack.c (tui_show_locator_content)
1972         (tui_show_frame_info): Remove unnecessary cast.
1973         * tui/tui-win.c (tui_scroll_forward_command)
1974         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1975         (parse_scrolling_args): Remove unnecessary cast.
1976         * tui/tui-data.c (init_win_info, tui_del_window)
1977         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1978         (free_content_elements): Remove unnecessary cast.
1979         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1980         unnecessary cast.
1981         * tui/tui-source.c (tui_set_source_content)
1982         (tui_vertical_source_scroll): Remove unnecessary cast.
1983         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1984         cast.
1985         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1986         * tui/tui-regs.c (tui_display_registers_from)
1987         (tui_display_register): Remove unnecessary cast.
1988         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1989         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1990         (make_visible): Remove unnecessary cast.
1991         * tui/tui-winsource.c (tui_erase_source_content)
1992         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1993         unnecessary cast.
1994         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1995         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1996         * stabsread.c (read_type, read_array_type, read_range_type):
1997         Remove unnecessary cast.
1998         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1999         (parse_symbol, parse_type, upgrade_type, parse_external)
2000         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2001         unnecessary cast.
2002         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2003
2004 2019-06-16  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-data.c (tui_alloc_generic_win_info)
2007         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2008         checks.
2009
2010 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2011             Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * f-typeprint.c (f_print_type): Don't return early for not
2014         associated or not allocated types.
2015         (f_type_print_varspec_suffix): Add print_rank parameter and print
2016         ranks of array types in case they dangling.
2017         (f_type_print_base): Add print_rank parameter.
2018
2019 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * NEWS: Mention new MI commands.
2022         * break-catch-throw.c (enum exception_event_kind): Move to
2023         breakpoint.h.
2024         (print_mention_exception_catchpoint): Output text as a single
2025         message.
2026         (catch_exception_command_1): Rename to...
2027         (catch_exception_event): ...this, make non-static, update header
2028         command, and change some parameter types.
2029         (catch_catch_command): Update for changes to
2030         catch_exception_command_1.
2031         (catch_throw_command): Likewise.
2032         (catch_rethrow_command): Likewise.
2033         * breakpoint.c (enum exception_event_kind): Delete.
2034         * breakpoint.h (enum exception_event_kind): Moved here from
2035         break-catch-throw.c.
2036         (catch_exception_event): Declare.
2037         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2038         (mi_cmd_catch_throw): New function.
2039         (mi_cmd_catch_rethrow): New function.
2040         (mi_cmd_catch_catch): New function.
2041         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2042         'catch-catch' entries.
2043         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2044         (mi_cmd_catch_rethrow): Declare.
2045         (mi_cmd_catch_catch): Declare.
2046
2047 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2048
2049         * annotate.c (annotate_source_line): Change return type to void,
2050         update implementation to match.
2051         * annotate.h (annotate_source_line): Change return type to void,
2052         update header comment.
2053         * stack.c (print_frame_info): Don't change what frame information
2054         is printed based on whether annotations are on or not.
2055
2056 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2059         (annotate_source): Make static.
2060         (annotate_source_line): Moved from source.c and renamed from
2061         identify_source_line.  Update the return type.
2062         * annotate.h (annotate_source): Delete declaration.
2063         (annotate_source_line): Declaration moved from source.h, and
2064         renamed from identify_source_line.  Return type updated.
2065         * source.c (identify_source_line): Moved to annotate.c and renamed
2066         to annotate_source_line.
2067         (info_line_command): Remove check of annotation_level.
2068         * source.h (identify_source_line): Move declaration to annotate.h
2069         and rename to annotate_source_line.
2070         * stack.c: Add 'annotate.h' include.
2071         (print_frame_info): Remove check of annotation_level before
2072         calling annotate_source_line.
2073
2074 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         * source-cache.c (source_cache::get_plain_source_lines): Use
2077         open_source_file_with_line_charpos instead of just
2078         open_source_file, remove call to find_source_lines.
2079         (source_cache::get_source_lines): Likewise.
2080         * source.c (find_source_lines): Make static.
2081         (get_filename_and_charpos): Renamed into...
2082         (open_source_file_with_line_charpos): ..this along with changes to
2083         return a scoped_fd, and some other minor clean ups.
2084         (identify_source_line): Use open_source_file_with_line_charpos.
2085         (search_command_helper): Use open_source_file_with_line_charpos
2086         instead of just open_source_file, remove call to
2087         find_source_lines.
2088         * source.h (open_source_file_with_line_charpos): Declare new
2089         function.
2090         (find_source_lines): Delete declaration.
2091
2092 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2093
2094         * source.c (get_filename_and_charpos): Remove fullname
2095         parameter.
2096         (identify_source_line): Update call to get_filename_and_charpos.
2097
2098 2019-06-14  Tom Tromey  <tromey@adacore.com>
2099
2100         PR gdb/24502:
2101         * ui-style.h (skip_ansi_escape): Update comment.
2102         * ui-file.h (class no_terminal_escape_file): New class.
2103         * ui-file.c (no_terminal_escape_file::write)
2104         (no_terminal_escape_file::puts): New methods.
2105         * cli/cli-logging.c (handle_redirections): Use
2106         no_terminal_escape_file.
2107
2108 2019-06-14  Tom Tromey  <tromey@adacore.com>
2109
2110         * NEWS: Move convenience variable news above Python news.
2111
2112 2019-06-14  Tom Tromey  <tom@tromey.com>
2113
2114         * gnulib: Move directory to top-level.
2115         * configure.ac: Don't configure gnulib.
2116         * configure: Rebuild.
2117         * common/common-defs.h: Use new path to gnulib.
2118         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2119         (GNULIB_H): Remove.
2120         (INCGNU): Look in new gnulib location.
2121         (HFILES_NO_SRCDIR): Remove gnulib files.
2122         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2123         (generated_files): Remove GNULIB_H.
2124         ($(LIBGNU), all-lib): Remove targets.
2125         (distclean): Don't mention GNULIB_BUILDDIR.
2126         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2127
2128 2019-06-14  Tom Tromey  <tromey@adacore.com>
2129
2130         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2131         Warn if symbol file does not provide any symbols.
2132
2133 2019-06-14  Tom Tromey  <tromey@adacore.com>
2134
2135         * source.c (find_and_open_source): Respect basenames_may_differ.
2136
2137 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * annotate.c (annotate_breakpoints_invalid): Make use of
2140         scoped_restore_terminal_state.
2141         (annotate_frames_invalid): Likewise.
2142
2143 2019-06-14  Tom Tromey  <tromey@adacore.com>
2144
2145         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2146         allow assignment to an internalvar.
2147
2148 2019-06-14  Tom Tromey  <tromey@adacore.com>
2149
2150         * ada-lex.l: Allow "_" in attribute names.
2151
2152 2019-06-14  Tom Tromey  <tromey@adacore.com>
2153
2154         PR gdb/24653:
2155         * regcache.c (registers_changed): Don't call alloca.
2156         * top.c (execute_command): Don't call alloca.
2157
2158 2019-06-13  Pedro Alves  <palves@redhat.com>
2159
2160         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2161         'expression'.  When parsing an expression, error out if there's
2162         junk after "unlimited".
2163         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2164         (do_set_command): Adjust calls to is_unlimited_literal.
2165
2166 2019-06-13  Pedro Alves  <palves@redhat.com>
2167
2168         * compile/compile.c (make_compile_options_def_group): Add braces
2169         around array_view initializer.
2170         * thread.c (make_thread_apply_all_options_def_group)
2171         (make_thread_apply_all_options_def_group): Likewise.
2172
2173 2019-06-13  Pedro Alves  <palves@redhat.com>
2174
2175         * NEWS (New commands): Mention "maint test-options
2176         require-delimiter", "maint test-options unknown-is-error", "maint
2177         test-options unknown-is-operand" and "maint show
2178         test-options-completion-result".
2179         (New command options, command completion): New section.
2180         (Completion improvements): New section.
2181         Mention that you can abbreviate "unlimited".
2182
2183 2019-06-13  Pedro Alves  <palves@redhat.com>
2184
2185         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2186         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2187         * unittests/cli-utils-selftests.c (test_parse_flags)
2188         (test_parse_flags_qcs): Delete.
2189         (test_cli_utils): Don't call deleted functions.
2190
2191 2019-06-13  Pedro Alves  <palves@redhat.com>
2192
2193         * thread.c: Include "cli/cli-option.h".
2194         (tp_array_compar_ascending): Global.
2195         (tp_array_compar): Delete function.
2196         (tp_array_compar_ascending, tp_array_compar_descending): New
2197         functions.
2198         (ascending_option_def, qcs_flag_option_def)
2199         (thr_qcs_flags_option_defs)
2200         (make_thread_apply_all_options_def_group)
2201         (make_thread_apply_options_def_group): New.
2202         (thread_apply_all_command): Use gdb::option::process_options.
2203         (thread_apply_command_completer)
2204         (thread_apply_all_command_completer): New.
2205         (thread_apply_command): Use gdb::option::process_options.
2206         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2207         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2208         to generate help text of "thread apply".  Adjust "taas"'s help.
2209         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2210         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2211
2212 2019-06-13  Pedro Alves  <palves@redhat.com>
2213
2214         * thread.c (thread_apply_command): Check for invalid TID with
2215         isdigit instead of !isalpha.
2216
2217 2019-06-13  Pedro Alves  <palves@redhat.com>
2218
2219         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2220         (validate_flags_qcs): New.
2221         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2222         (validate_flags_qcs): Declare.
2223         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2224         (make_frame_apply_options_def_group): New.
2225         (frame_apply_command_count): Process options with
2226         gdb::option::process_options.
2227         (frame_apply_completer): New.
2228         (frame_apply_level_completer, frame_apply_all_completer)
2229         (frame_apply_completer): New.
2230         (_initialize_stack): Update help of "frame apply", "frame apply
2231         level", "frame apply all" and "faas" to mention supported options
2232         and install command completers.
2233         * stack.h (frame_apply_all_completer): Declare.
2234         * thread.c: Include "stack.h".
2235         (tfaas_command): Add "--".
2236         (_initialize_thread): Update help "tfaas" to mention supported
2237         options and install command completer.
2238
2239 2019-06-13  Pedro Alves  <palves@redhat.com>
2240
2241         * completer.c (complete_nested_command_line): New.
2242         (gdb_completion_word_break_characters_throw): Add assertion.
2243         * completer.h (complete_nested_command_line): Declare.
2244
2245 2019-06-13  Pedro Alves  <palves@redhat.com>
2246
2247         * stack.c (parse_backtrace_qualifiers): New.
2248         (backtrace_command): Use it.
2249         (backtrace_command_completer): Complete on qualifiers.
2250
2251 2019-06-13  Pedro Alves  <palves@redhat.com>
2252
2253         * frame.c: Include "cli/cli-option.h.
2254         (user_set_backtrace_options): New.
2255         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2256         Delete.
2257         (get_prev_frame): Adjust.
2258         (boolean_option_def, uinteger_option_def)
2259         (set_backtrace_option_defs): New.
2260         (_initialize_frame): Adjust and use
2261         gdb::option::add_setshow_cmds_for_options to install "set
2262         backtrace past-main" and "set backtrace past-entry".
2263         * frame.h: Include "cli/cli-option.h".
2264         (struct frame_print_options): Forward declare.
2265         (print_frame_arguments_all, print_frame_arguments_scalars)
2266         (print_frame_arguments_none): Declare.
2267         (print_entry_values): Delete declaration.
2268         (struct frame_print_options, user_frame_print_options): New.
2269         (struct set_backtrace_options): New.
2270         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2271         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2272         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2273         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2274         (list_args_or_locals): Add frame_print_options parameter.
2275         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2276         * python/py-framefilter.c (enumerate_args): Pass down
2277         USER_FRAME_PRINT_OPTIONS.
2278         * stack.c: Include "cli/cli-option.h".
2279         (print_frame_arguments_all, print_frame_arguments_scalars)
2280         (print_frame_arguments_none): Declare.
2281         (print_raw_frame_arguments, print_entry_values): Delete.
2282         (user_frame_print_options): New.
2283         (boolean_option_def, enum_option_def, frame_print_option_defs):
2284         New.
2285         (struct backtrace_cmd_options): New.
2286         (bt_flag_option_def): New.
2287         (backtrace_command_option_defs): New.
2288         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2289         (print_frame_arg, read_frame_arg, print_frame_args)
2290         (print_frame_info, print_frame): Add frame_print_options parameter
2291         and use it.
2292         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2293         (backtrace_command_1): Add frame_print_options and
2294         backtrace_cmd_options parameters and use them.
2295         (make_backtrace_options_def_group): New.
2296         (backtrace_command): Process command options with
2297         gdb::option::process_options.
2298         (backtrace_command_completer): New.
2299         (_initialize_stack): Extend "backtrace"'s help to mention
2300         supported options.  Install completer for "backtrace".
2301         Install some settings commands with add_setshow_cmds_for_options.
2302
2303 2019-06-13  Pedro Alves  <palves@redhat.com>
2304
2305         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2306         and that "set/show print raw frame-arguments" are now deprecated.
2307
2308         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2309         command.
2310         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2311         * stack.c (_initialize_stack): Install "set/show print
2312         raw-frame-arguments", and deprecate "set/show print raw
2313         frame-arguments".
2314         * valprint.c (_initialize_valprint): Deprecate "set/show print
2315         raw".
2316
2317 2019-06-13  Pedro Alves  <palves@redhat.com>
2318
2319         * compile/compile.c (struct compile_options): New.
2320         (compile_flag_option_def, compile_command_option_defs)
2321         (make_compile_options_def_group): New.
2322         (compile_file_command): Handle options with
2323         gdb::option::process_options.
2324         (compile_file_command_completer): New function.
2325         (compile_code_command): Handle options with
2326         gdb::option::process_options.
2327         (compile_code_command_completer): New function.
2328         (_initialize_compiler): Install completers for "compile code" and
2329         "compile file".  Mention available options in "compile code" and
2330         "compile code"'s help.
2331         * completer.c (advance_to_completion_word): New, factored out from
2332         ...
2333         (advance_to_expression_complete_word_point): ... this.
2334         (advance_to_filename_complete_word_point): New.
2335         * completer.h (advance_to_filename_complete_word_point): New
2336         declaration.
2337
2338 2019-06-13  Pedro Alves  <palves@redhat.com>
2339
2340         * compile/compile.c: Include "cli/cli-option.h".
2341         (compile_print_value): Scope data pointer is now a
2342         value_print_options pointer; adjust.
2343         (compile_print_command): Process options.  Scope data pointer is
2344         now a value_print_options pointer; adjust.
2345         (_initialize_compile): Update "compile print"'s help to include
2346         supported options.  Install a completer for "compile print".
2347         * cp-valprint.c (show_vtblprint, show_objectprint)
2348         (show_static_field_print): Delete.
2349         (_initialize_cp_valprint): Don't install "set print
2350         static-members", "set print vtbl", "set print object" here.
2351         * printcmd.c: Include "cli/cli-option.h" and
2352         "common/gdb_optional.h".
2353         (print_command_parse_format): Rework to fill in a
2354         value_print_options instead of a format_data.
2355         (print_value): Change parameter type from format_data pointer to
2356         value_print_options reference.  Adjust.
2357         (print_command_1): Process options.  Adjust to pass down a
2358         value_print_options.
2359         (print_command_completer): New.
2360         (_initialize_printcmd): Install print_command_completer as
2361         handle_brkchars completer for the "print" command.  Update
2362         "print"'s help to include supported options.
2363         * valprint.c: Include "cli/cli-option.h".
2364         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2365         here from cp-valprint.c.
2366         (boolean_option_def, uinteger_option_def)
2367         (value_print_option_defs, make_value_print_options_def_group):
2368         New.  Use gdb::option::add_setshow_cmds_for_options to install
2369         "set print elements", "set print null-stop", "set print repeats",
2370         "set print pretty", "set print union", "set print array", "set
2371         print address", "set print symbol", "set print array-indexes".
2372         * valprint.h: Include <string> and "cli/cli-option.h".
2373         (make_value_print_options_def_group): Declare.
2374         (print_value): Change parameter type from format_data pointer to
2375         value_print_options reference.
2376         (print_command_completer): Declare.
2377
2378 2019-06-13  Pedro Alves  <palves@redhat.com>
2379
2380         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2381         (COMMON_SFILES): Add maint-test-settings.c.
2382         * cli/cli-decode.c (boolean_enums): New global, factored out from
2383         ...
2384         (add_setshow_boolean_cmd): ... here.
2385         * cli/cli-decode.h (boolean_enums): Declare.
2386         * cli/cli-option.c: New file.
2387         * cli/cli-option.h: New file.
2388         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2389         factored out from ...
2390         (parse_cli_boolean_value(const char *)): ... this.
2391         (is_unlimited_literal): Change parameter type to pointer to
2392         pointer.  Adjust and advance ARG pointer.
2393         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2394         (parse_cli_var_enum): New, factored out from ...
2395         (do_set_command): ... this.  Adjust.
2396         * cli/cli-setshow.h (parse_cli_boolean_value)
2397         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2398         (parse_cli_var_enum): Declare.
2399         * cli/cli-utils.c: Include "cli/cli-option.h".
2400         (get_ulongest): New.
2401         * cli/cli-utils.h (get_ulongest): Declare.
2402         (check_for_argument): New overloads.
2403         * maint-test-options.c: New file.
2404
2405 2019-06-13  Pedro Alves  <palves@redhat.com>
2406
2407         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2408         parse a range if "-" is at the end of the string.
2409
2410 2019-06-13  Pedro Alves  <palves@redhat.com>
2411
2412         * cli/cli-setshow.c (parse_auto_binary_operation)
2413         (parse_cli_boolean_value): Don't allow "o".
2414
2415 2019-06-13  Pedro Alves  <palves@redhat.com>
2416
2417         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2418         * NEWS: Mention maint test-settings KIND.
2419         * maint-test-settings.c: New file.
2420
2421 2019-06-13  Pedro Alves  <palves@redhat.com>
2422
2423         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2424         completer.
2425         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2426         "set" completers.
2427
2428 2019-06-13  Pedro Alves  <palves@redhat.com>
2429
2430         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2431         after item.
2432
2433 2019-06-13  Pedro Alves  <palves@redhat.com>
2434
2435         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2436
2437 2019-06-13  Pedro Alves <palves@redhat.com>
2438
2439         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2440         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2441         call.
2442         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2443         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2444         calls.
2445         (check_for_argument): Skip spaces after argument.
2446
2447 2019-06-13  Pedro Alves  <palves@redhat.com>
2448
2449         * thread.c (thread_apply_command): Adjust TID parsing.
2450         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2451         detected before end of string.
2452         (tid_is_in_list): Error out if LIST is invalid.
2453
2454 2019-06-13  Pedro Alves  <palves@redhat.com>
2455
2456         * completer.c (complete_line_internal_1): Rewind completion word
2457         point.
2458         (completion_tracker::advance_custom_word_point_by): Change
2459         parameter type to int.
2460         * completer.h (completion_tracker::advance_custom_word_point_by):
2461         Likewise.
2462
2463 2019-06-13  Pedro Alves  <palves@redhat.com>
2464
2465         * completer.c (advance_to_completion_word): Handle delimiters.
2466
2467 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2468
2469         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2470
2471 2019-06-11  Tom Tromey  <tom@tromey.com>
2472
2473         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2474         (xmalloc_failed): Move to alloc.c.
2475         * alloc.c: New file.
2476         * Makefile.in (COMMON_SFILES): Add alloc.c.
2477
2478 2019-06-11  Tom Tromey  <tom@tromey.com>
2479
2480         * nat/linux-waitpid.c: Don't include server.h.
2481         (linux_debug): Remove.
2482         (my_waitpid): Update.
2483
2484 2019-06-11  Tom Tromey  <tromey@adacore.com>
2485
2486         * infcall.c (_initialize_infcall): Remove trailing newline from
2487         help.
2488         * user-regs.c (_initialize_user_regs): Remove trailing newline
2489         from help.
2490         * typeprint.c (_initialize_typeprint): Remove trailing newline
2491         from help.
2492         * reverse.c (_initialize_reverse): Remove trailing newlines from
2493         help.
2494         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2495         from help.
2496         * language.c (add_set_language_command): Remove trailing newline
2497         from help.
2498         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2499         help.
2500         * disasm.c (_initialize_disasm): Remove trailing newline from
2501         help.
2502         * top.c (init_main): Remove trailing newline from help.
2503         * interps.c (_initialize_interpreter): Remove trailing newline
2504         from help.
2505         * btrace.c (_initialize_btrace): Remove trailing newlines from
2506         help.
2507         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2508         from help.
2509         * python/python.c (_initialize_python): Remove trailing newline
2510         from help.
2511         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2512         help.
2513         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2514         from help.  Reformat some text.
2515         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2516         from help.
2517         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2518         newline from help.
2519
2520 2019-06-11  Tom Tromey  <tromey@adacore.com>
2521
2522         * darwin-nat.c (darwin_decode_exception_message)
2523         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2524
2525 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * valops.c (value_slice): Check for not allocated or not
2528         associated values.
2529
2530 2019-06-10  Tom de Vries  <tdevries@suse.de>
2531
2532         PR gdb/24618
2533         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2534         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2535         invalid.
2536
2537 2019-06-10  Tom de Vries  <tdevries@suse.de>
2538
2539         PR gdb/24611
2540         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2541         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2542
2543 2019-06-10  Tom de Vries  <tdevries@suse.de>
2544
2545         PR symtab/24545
2546         * symtab.c (struct demangled_name_entry): Add language field.
2547         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2548         static minimal symbol".  Set and use language field.
2549
2550 2019-06-10  Tom Tromey  <tromey@adacore.com>
2551
2552         * ada-lang.c (_initialize_ada_language): Update help text.
2553
2554 2019-06-10  Tom Tromey  <tromey@adacore.com>
2555
2556         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2557         with a newline.
2558         * guile/guile.c (handle_boot_error): Don't end warning with a
2559         newline.
2560         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2561         warning with a newline.
2562         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2563         newline.
2564         (s12z_frame_cache): Likewise.
2565         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2566         a newline.
2567         * solib-svr4.c (disable_probes_interface): Don't end warning with
2568         a newline.
2569         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2570         newline.
2571         * python/python.c (do_finish_initialization): Don't end warning
2572         with a newline.
2573
2574 2019-06-10  Tom Tromey  <tom@tromey.com>
2575
2576         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2577         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2578         gdbpy_enter.
2579
2580 2019-06-10  Tom Tromey  <tromey@adacore.com>
2581
2582         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2583         data.
2584         (elf_new_init): Don't call stabsread_new_init.
2585         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2586         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2587         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2588
2589 2019-06-10  Tom de Vries  <tdevries@suse.de>
2590
2591         PR symtab/16264
2592         PR symtab/24517
2593         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2594
2595 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2596
2597         * source.c (find_and_open_source): Also rewrite relative file
2598         names.
2599
2600 2019-04-26  Amos Bird  <amosbird@gmail.com>
2601
2602         * annotate.c (annotate_thread_exited): Add "thread-exited"
2603         annotation.
2604
2605 2019-06-06  Tom Tromey  <tromey@adacore.com>
2606
2607         * maint.h (class scoped_command_stats): Use
2608         DISABLE_COPY_AND_ASSIGN.
2609         <print_time>: New method.
2610         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2611         print_time.
2612         (scoped_command_stats::print_time): New method.
2613
2614 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2617         instructions of lengths 6 or 8 bytes.
2618
2619 2019-06-04  Pedro Alves  <palves@redhat.com>
2620
2621         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2622
2623         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2624         * breakpoint.c (condition_completer): Likewise.
2625         * cli/cli-dump.c (scan_expression): Likewise.
2626         * common/filestuff.c (mkdir_recursive): Likewise.
2627         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2628         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2629         (gdb_abspath): Likewise.
2630         * compile/compile-cplus-types.c
2631         (compile_cplus_instance::decl_name): Likewise.
2632         * completer.c (complete_explicit_location):
2633         (signal_completer, reg_or_group_completer_1): Likewise.
2634         * cp-support.c (cp_remove_params_if_any): Likewise.
2635         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2636         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2637         * infcmd.c (strip_bg_char): Likewise.
2638         * linespec.c (copy_token_string): Likewise.
2639         * mi/mi-main.c (output_cores): Likewise.
2640         * psymtab.c (psymtab_search_name):
2641         * symfile.c (test_set_ext_lang_command): Likewise.
2642         * target.c (target_fileio_read_stralloc): Likewise.
2643         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2644         * value.c (complete_internalvar): Likewise.
2645
2646 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2647
2648         Add objfile property to gdb.Type.
2649         * NEWS: Mention Python API addition.
2650         * python/py-type.c (typy_get_objfile): New method.
2651
2652 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2653
2654         * NEWS: Mention the new set|show style [title|highlight].
2655         Mention changes to "show style", "help" and "apropos".
2656
2657 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2658
2659         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2660         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2661         instead of print_help_for_command.
2662         (print_doc_of_command): New function.
2663         (help_list): Add 'apropos -v word' suggestion.
2664         (print_help_for_command): Style the command name using title style.
2665         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2666         (_initialize_cli_cmds): Describe -v in apropos_command help.
2667
2668 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2669
2670         * cli/cli-style.h (cli_style_option): Add name in constructor,
2671         add m_name class member, add constructor with intensity,
2672         add name class function.
2673         (cli_style_option::add_setshow_commands): Remove name argument.
2674         (highlight_style, title_style): New styles.
2675         * cli/cli-style.c (do_show): New function that shows a style
2676         characteristic styling the style name with itself.
2677         (set_style_name): New function.
2678         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2679         Update all callers according to the changes in cli/cli-style.h.
2680         * utils.h (fputs_highlighted): New function.
2681         * utils.c (fputs_highlighted): Likewise.
2682
2683 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2684
2685         * NEWS: Mention new pipe command and new convenience variables.
2686
2687 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2688
2689         * cli/cli-cmds.c (pipe_command): New function.
2690         (_initialize_cli_cmds): Call add_com for pipe_command.
2691         Define | as an alias for pipe.
2692         (exit_status_set_internal_vars): New function.
2693         (shell_escape): Call exit_status_set_internal_vars.
2694         cli/cli-decode.c (find_command_name_length): Recognize | as
2695         a single character command.
2696
2697 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2698
2699         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2700         top.c (execute_command_to_ui_file): New function, mostly a copy
2701         of execute_command_to_string.
2702         (execute_command_to_string): Implement by calling
2703         execute_command_to_ui_file.
2704
2705 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2706
2707         * top.h (saved_command_line): Remove declaration.
2708         * top.c (previous_saved_command_line, previous_repeat_arguments):
2709         New variables.
2710         (saved_command_line): Make static, define together with other
2711         'repeat variables'.
2712         (dont_repeat): Clear repeat_arguments.
2713         (repeat_previous, get_saved_command_line, save_command_line):
2714         New functions.
2715         (gdb_init): Initialize saved_command_line
2716         and previous_saved_command_line.
2717         * main.c (captured_main_1): Remove saved_command_line initialization.
2718         * event-top.c (handle_line_of_input): Update to use
2719         the new 'repeat' related functions instead of direct access to
2720         saved_command_line.
2721         * command.h (repeat_previous, get_saved_command_line,
2722         save_command_line): New declarations.
2723         (dont_repeat): Add comment.
2724
2725 2019-05-30  Tom Tromey  <tromey@adacore.com>
2726
2727         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2728         Fix comment.
2729         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2730
2731 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2732
2733         PR cli/24587
2734         * completer.c (complete): Initialize variable word.
2735
2736 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2737
2738         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2739         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2740         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2741         'body' is NULL to the outter 'if', protecting the '!is_define'
2742         situation as well.
2743
2744 2019-05-29  Tom Tromey  <tromey@adacore.com>
2745
2746         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2747         (dwarf_unknown): New function.
2748         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2749         (dwarf_type_encoding_name): Use dwarf_unknown.
2750
2751 2019-05-29  Tom Tromey  <tromey@adacore.com>
2752
2753         PR c++/20020:
2754         * cp-valprint.c (cp_print_value_fields): Call
2755         cp_print_static_field inside "try".
2756
2757 2019-05-29  Tom Tromey  <tromey@adacore.com>
2758
2759         * inflow.c (struct terminal_info): Add default operator=.
2760         * configure: Rebuild.
2761         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2762         -Wdeprecated-copy-dtor, -Wredundant-move.
2763
2764 2019-05-29  Tom Tromey  <tromey@adacore.com>
2765
2766         * NEWS: Add entry.
2767         * infcmd.c (print_return_value_1): Handle finish_print
2768         option.
2769         (show_print_finish): New function.
2770         (_initialize_infcmd): Add "set/show print finish" commands.
2771         * valprint.c (user_print_options): Initialize new member.
2772         * valprint.h (struct value_print_options) <finish_print>: New
2773         member.
2774
2775 2019-05-28  Tom Tromey  <tromey@adacore.com>
2776
2777         * ada-lang.c (ada_remove_Xbn_suffix)
2778         (find_old_style_renaming_symbol)
2779         (parse_old_style_renaming): Remove.
2780         (ada_find_renaming_symbol): Don't call
2781         find_old_style_renaming_symbol.
2782         (ada_is_renaming_symbol): Rename from
2783         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2784         bool.  Now static.
2785         (ada_read_var_value): Update and simplify.
2786         * ada-exp.y (write_var_or_type): Remove old code.
2787
2788 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2789
2790         * event-top.c: Remove include comment.
2791         * inflow.c (class scoped_ignore_sigttou): Move from here...
2792         * inflow.h (class scoped_ignore_sigttou): ...to here.
2793         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2794         * top.c:  Remove include comment.
2795
2796 2019-05-27  Tom Tromey  <tom@tromey.com>
2797
2798         * NEWS: Fix typo.
2799
2800 2019-05-22  Tom Tromey  <tromey@adacore.com>
2801
2802         * target.c (target_follow_exec): Constify parameter.
2803         * target-delegates.c: Rebuild.
2804         * remote.c (remote_target::follow_exec): Constify parameter.
2805         * infrun.c (follow_exec): Constify parameter.
2806         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2807         (target_follow_exec): Likewise.
2808
2809 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2810
2811         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2812         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2813
2814 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2815
2816         * NEWS: Add debugredirect and testsuite sections.
2817
2818 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2819
2820         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2821         target descriptions using exclusively floating point register name
2822         aliases.
2823
2824 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         PR gdb/18644:
2827         * f-lang.c (build_fortran_types): Handle the case where
2828         gdbarch_floatformat_for_type returns a nullptr.
2829
2830 2019-05-21  Tom de Vries  <tdevries@suse.de>
2831
2832         PR cli/24587
2833         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2834
2835 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         PR gdb/18644:
2838         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2839         16-byte floats.
2840         * i386-tdep.c (i386_floatformat_for_type): Use
2841         floatformats_ia64_quad for the 16-byte floating point component
2842         within a fortran 32-byte complex number.
2843
2844 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2847         delete default constructor.
2848         (find_partial_die): Update to return const struct.
2849         (partial_die_parent_scope): Move variable declaration into scope
2850         of its use and change its type to auto.
2851         (guess_partial_die_structure_name): Likewise.
2852         (partial_die_info::fixup): Likewise.
2853
2854 2019-05-17  Tom Tromey  <tromey@adacore.com>
2855
2856         * source.c (find_and_open_source): Remove cast.
2857
2858 2019-05-17  Tom Tromey  <tromey@adacore.com>
2859
2860         * annotate.c (annotate_source): Make "filename" const.
2861         * annotate.h (annotate_source): Use const.
2862
2863 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2864
2865         * disasm.c (set_disassembler_options): Send errors to stderr.
2866
2867 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2868
2869         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2870         (cli_interp_base::set_logging): Check debug_redirect.
2871         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2872         * cli/cli-logging.c (debug_redirect): Add static variable.
2873         (pop_output_files): Add default param.
2874         (handle_redirections): Print debug setting.
2875         (show_logging_command): Likewise.
2876         (_initialize_cli_logging): Add debugredirect command.
2877         * interps.c (current_interp_set_logging): Add debug_redirect
2878         parameter.
2879         * interps.h (set_logging): Add debug_redirect parameter.
2880         (current_interp_set_logging): Likewise.
2881         * mi/mi-common.h: Likewise.
2882         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2883
2884 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2885             Tom Tromey  <tromey@adacore.com>
2886
2887         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2888         directly.
2889         * cli/cli-interp.h (make_logging_output): Remove declaration.
2890         * cli/cli-logging.c (make_logging_output): Remove function.
2891         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2892         directly.
2893         * ui-file.c (tee_file::tee_file): Remove bools.
2894         (tee_file::~tee_file): Remove deletes.
2895         * ui-file.h (tee_file): Remove bools.
2896
2897 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2898
2899         * mi/mi-cmds.h (mi_cmd_complete): New function.
2900         * mi/mi-main.c (mi_cmd_complete): Likewise.
2901         * mi/mi-cmds.c: Define new MI command -complete.
2902         * NEWS: Mention new -complete command.
2903
2904 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2905
2906         * completer.h (complete): New function.
2907         * completer.c (complete): Likewise.
2908         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2909         function defined in completer.h.
2910
2911 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2912
2913         * MAINTAINERS (Write After Approval): Add myself.
2914
2915 2019-05-17  Tom de Vries  <tdevries@suse.de>
2916
2917         PR gdb/24094
2918         * dwarf2read.c (struct cu_partial_die_info): New struct.
2919         (find_partial_die): Return cu_partial_die_info.
2920         (partial_die_parent_scope, guess_partial_die_structure_name)
2921         (partial_die_info::fixup): Handle new return type of find_partial_die.
2922
2923 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2924
2925         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2926         "std::string", simplifying the algorithm.
2927
2928 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2929
2930         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2931         (stap_static_probe_ops::get_probes): Likewise.
2932
2933 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2934
2935         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2936         '-')" and "else if".
2937         (stap_parse_single_operand): Join checks for
2938         "gdbarch_stap_parse_special_token_p" and
2939         "gdbarch_stap_parse_special_token" in the same "if" statement.
2940         Invert check when verifying for operation on register
2941         displacement.
2942
2943 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2944
2945         * stap-probe.c (stap_get_opcode): Update comment.
2946         (stap_get_expected_argument_type): Likewise.
2947         (handle_stap_probe): Likewise.
2948
2949 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2950
2951         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2952         return type to 'bool'.  Adjust comment.  Use 'bool' when
2953         appropriate.
2954         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2955         * stap-probe.c (stap_parse_argument_1): Likewise.
2956         (stap_is_operator): Likewise.
2957         (stap_is_generic_prefix): Likewise.
2958         (stap_is_register_prefix): Likewise.
2959         (stap_is_register_indirection_prefix): Likewise.
2960         (stap_is_integer_prefix): Likewise.
2961         (stap_generic_check_suffix): Likewise.
2962         (stap_check_integer_suffix): Likewise.
2963         (stap_check_register_suffix): Likewise.
2964         (stap_check_register_indirection_suffix): Likewise.
2965         (stap_parse_register_operand): Likewise.
2966         (stap_parse_single_operand): Likewise.
2967         (stap_parse_argument_1): Likewise.
2968         (stap_probe::get_argument_count): Likewise.
2969         (stap_is_operator): Likewise.
2970
2971 2019-05-16  Tom Tromey  <tromey@adacore.com>
2972
2973         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2974         keyword to foreach.
2975
2976 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2977
2978         * linux-thread-db.c (try_thread_db_load_1): Change return type
2979         to bool.
2980         (try_thread_db_load): Likewise.
2981         (try_thread_db_load_from_pdir_1): Likewise.
2982         (try_thread_db_load_from_pdir): Likewise.
2983         (try_thread_db_load_from_sdir): Likewise.
2984         (try_thread_db_load_from_dir): Likewise.
2985         (thread_db_load_search): Likewise.
2986         (has_libpthread): Likewise.
2987         (thread_db_load): Likewise.
2988
2989 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2990
2991         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2992         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2993         NULL, and complain/return if that's the case.
2994
2995 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2996
2997         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2998         (advance, posn, abstract_read_memory): New functions.
2999         [struct mem_read_abstraction]: New struct.
3000         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3001
3002 2019-05-14  Tom Tromey  <tromey@adacore.com>
3003
3004         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3005         value is not lval_memory.
3006
3007 2019-05-14  Tom Tromey  <tromey@adacore.com>
3008
3009         * solib.c (info_sharedlibrary_command): Style the file name.
3010
3011 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3012
3013         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3014         (aarch64_vnv_type): Likewise.
3015         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3016         * common/tdesc.c: Likewise.
3017         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3018         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3019         * features/aarch64-fpu.xml: Add ieee half view.
3020         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3021         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3022         * gdbtypes.h (struct builtin_type): Likewise.
3023         (struct objfile_type): Likewise.
3024
3025 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3026
3027         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3028         typo.
3029         * location.h (string_to_event_location): Likewise.
3030
3031 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3032
3033         GDB 8.3 released.
3034
3035 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3036
3037         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3038         New variable declaration.
3039         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3040         New variable.
3041         (print_one_breakpoint): Use ui_out::test_flags and new global
3042         variable to compute use_fixed_output.
3043         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3044         Remove.
3045         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3046         (mi_multi_location_breakpoint_output_fixed): Remove.
3047         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3048         new variable.
3049         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3050         fix_multi_location_breakpoint_output flag if version >= 3.
3051         * ui-out.h (enum ui_out_flag)
3052         <fix_multi_location_breakpoint_output>: New enumerator.
3053
3054 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3055
3056         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3057
3058 2019-05-10  Tom Tromey  <tromey@adacore.com>
3059
3060         * ada-lang.c (catch_ada_completer): New function.
3061         (_initialize_ada_language): Use it.
3062
3063 2019-05-10  Tom Tromey  <tromey@adacore.com>
3064
3065         * thread.c (print_thread_info): Make "requested_threads" const.
3066         * gdbthread.h (print_thread_info): Make "requested_threads"
3067         const.
3068         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3069         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3070
3071 2019-05-08  Tom Tromey  <tom@tromey.com>
3072
3073         * gdbtypes.c (objfile_type_data): Change type.
3074         (objfile_type, _initialize_gdbtypes): Update.
3075
3076 2019-05-08  Tom Tromey  <tom@tromey.com>
3077
3078         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3079         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3080         (_initialize_dwarf2_frame): Update.
3081
3082 2019-05-08  Tom Tromey  <tom@tromey.com>
3083
3084         * objc-lang.c (objc_objfile_data): Change type.
3085         (find_methods): Update.
3086         (_initialize_objc_lang): Remove.
3087
3088 2019-05-08  Tom Tromey  <tom@tromey.com>
3089
3090         * stabsread.c (rs6000_builtin_type_data): Change type.
3091         (rs6000_builtin_type, _initialize_stabsread): Update.
3092
3093 2019-05-08  Tom Tromey  <tom@tromey.com>
3094
3095         * mips-tdep.c (mips_pdr_data): Remove.
3096         (_initialize_mips_tdep): Update.
3097
3098 2019-05-08  Tom Tromey  <tom@tromey.com>
3099
3100         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3101         (hppa_init_objfile_priv_data, read_unwind_info)
3102         (find_unwind_entry, _initialize_hppa_tdep): Update.
3103
3104 2019-05-08  Tom Tromey  <tom@tromey.com>
3105
3106         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3107         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3108         on obstack.
3109         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3110
3111 2019-05-08  Tom Tromey  <tom@tromey.com>
3112
3113         * mdebugread.c (basic_type_data): Change type.
3114         (basic_type, _initialize_mdebugread): Update.
3115
3116 2019-05-08  Tom Tromey  <tom@tromey.com>
3117
3118         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3119
3120 2019-05-08  Tom Tromey  <tom@tromey.com>
3121
3122         * nto-tdep.c (nto_inferior_data_reg): Change type.
3123         (nto_inferior_data): Update.
3124         (nto_inferior_data_cleanup, nto_new_inferior_data)
3125         (_initialize_nto_tdep): Remove.
3126         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3127
3128 2019-05-08  Tom Tromey  <tom@tromey.com>
3129
3130         * ada-lang.c (struct ada_inferior_data): Add initializers.
3131         (ada_inferior_data): Change type.
3132         (ada_inferior_data_cleanup): Remove.
3133         (get_ada_inferior_data, ada_inferior_exit)
3134         (struct ada_pspace_data): Add initializers, destructor.
3135         (ada_pspace_data_handle): Change type.
3136         (get_ada_pspace_data): Update.
3137         (ada_pspace_data_cleanup): Remove.
3138
3139 2019-05-08  Tom Tromey  <tom@tromey.com>
3140
3141         * coffread.c (struct coff_symfile_info): Add initializers.
3142         (coff_objfile_data_key): Move lower.  Change type.
3143         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3144         Update.
3145         (coff_free_info): Remove.
3146
3147 2019-05-08  Tom Tromey  <tom@tromey.com>
3148
3149         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3150         (fbsd_pspace_data_handle): Move lower.  Change type.
3151         (get_fbsd_pspace_data): Update.
3152         (fbsd_pspace_data_cleanup): Remove.
3153         (_initialize_fbsd_tdep): Update.
3154
3155 2019-05-08  Tom Tromey  <tom@tromey.com>
3156
3157         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3158         (get_ada_tasks_pspace_data): Update.
3159         (ada_tasks_pspace_data_cleanup): Remove.
3160         (_initialize_tasks): Update.
3161         (ada_tasks_inferior_data_handle): Change type.
3162         (get_ada_tasks_inferior_data): Update.
3163         (ada_tasks_inferior_data_cleanup): Remove.
3164         (struct ada_tasks_pspace_data): Add initializers.
3165
3166 2019-05-08  Tom Tromey  <tom@tromey.com>
3167
3168         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3169         * symfile-debug.c (debug_sym_get_probes): Change type.
3170         * stap-probe.c (handle_stap_probe):
3171         (stap_static_probe_ops::get_probes): Change type.
3172         * probe.h (class static_probe_ops) <get_probes>: Change type.
3173         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3174         (parse_probes_in_pspace): Update.
3175         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3176         Update.
3177         (any_static_probe_ops::get_probes): Change type.
3178         * elfread.c (elfread_data): New typedef.
3179         (probe_key): Change type.
3180         (elf_get_probes): Likewise.  Update.
3181         (probe_key_free): Remove.
3182         (_initialize_elfread): Update.
3183         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3184         Change type.
3185         (dtrace_process_dof_probe, dtrace_process_dof)
3186         (dtrace_static_probe_ops::get_probe): Change type.
3187
3188 2019-05-08  Tom Tromey  <tom@tromey.com>
3189
3190         * xcoffread.c (struct xcoff_symfile_info): Rename from
3191         coff_symfile_info.  Add initializers.
3192         (xcoff_objfile_data_key): Move lower.  Change type.
3193         (XCOFF_DATA): Rewrite.
3194         (xcoff_free_info): Remove.
3195         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3196         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3197         (xcoff_initial_scan): Update.
3198
3199 2019-05-08  Tom Tromey  <tom@tromey.com>
3200
3201         * solib-svr4.c (struct svr4_info): Add initializers and
3202         destructor.
3203         <probes_table>: Now an htab_up.
3204         (solib_svr4_pspace_data): Change type.
3205         (free_probes_table): Simplify.
3206         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3207         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3208         (probes_table_remove_objfile_probes, register_solib_event_probe)
3209         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3210         (_initialize_svr4_solib): Update.
3211
3212 2019-05-08  Tom Tromey  <tom@tromey.com>
3213
3214         * remote.c (remote_pspace_data): Change type.
3215         (remote_pspace_data_cleanup): Remove.
3216         (get_remote_exec_file, set_pspace_remote_exec_file)
3217         (_initialize_remote): Update.
3218
3219 2019-05-08  Tom Tromey  <tom@tromey.com>
3220
3221         * breakpoint.c (breakpoint_objfile_key): Change type.
3222         (get_breakpoint_objfile_data): Update.
3223         (free_breakpoint_objfile_data): Remove.
3224         (_initialize_breakpoint): Update.
3225
3226 2019-05-08  Tom Tromey  <tom@tromey.com>
3227
3228         * linux-tdep.c (struct linux_info): Add initializers.
3229         (linux_inferior_data): Move.  Change type.
3230         (invalidate_linux_cache_inf): Update.
3231         (linux_inferior_data_cleanup): Remove.
3232         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3233
3234 2019-05-08  Tom Tromey  <tom@tromey.com>
3235
3236         * auxv.c (auxv_inferior_data): Move.  Change type.
3237         (auxv_inferior_data_cleanup): Remove.
3238         (invalidate_auxv_cache_inf): Rewrite.
3239         (get_auxv_inferior_data, _initialize_auxv): Update.
3240
3241 2019-05-08  Tom Tromey  <tom@tromey.com>
3242
3243         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3244         (symfile_debug_objfile_data_key): Change type.
3245         (symfile_debug_installed, debug_qf_has_symbols)
3246         (debug_qf_find_last_source_symtab)
3247         (debug_qf_forget_cached_source_info)
3248         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3249         (debug_qf_print_stats, debug_qf_dump)
3250         (debug_qf_expand_symtabs_for_function)
3251         (debug_qf_expand_all_symtabs)
3252         (debug_qf_expand_symtabs_with_fullname)
3253         (debug_qf_map_matching_symbols)
3254         (debug_qf_expand_symtabs_matching)
3255         (debug_qf_find_pc_sect_compunit_symtab)
3256         (debug_qf_map_symbol_filenames)
3257         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3258         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3259         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3260         (debug_sym_read_linetable, debug_sym_relocate): Update.
3261         (symfile_debug_free_objfile): Remove.
3262         (install_symfile_debug_logging, _initialize_symfile_debug):
3263         Update.
3264
3265 2019-05-08  Tom Tromey  <tom@tromey.com>
3266
3267         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3268         allocate_on_obstack.
3269         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3270         (get_dwarf2_per_objfile): Update.
3271         (set_dwarf2_per_objfile): Remove.
3272         (dwarf2_has_info, dwarf2_get_section_info): Update.
3273         (dwarf2_free_objfile): Remove.
3274         (_initialize_dwarf2_read): Update.
3275
3276 2019-05-08  Tom Tromey  <tom@tromey.com>
3277
3278         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3279         initializers.
3280         <unsupported_script_warning_printed,
3281         script_not_found_warning_printed>: Now bool.
3282         (auto_load_pspace_data): Change type.
3283         (~auto_load_pspace_info): Rename from
3284         auto_load_pspace_data_cleanup.
3285         (get_auto_load_pspace_data, init_loaded_scripts_info)
3286         (clear_section_scripts, maybe_print_unsupported_script_warning)
3287         (maybe_print_script_not_found_warning, _initialize_auto_load):
3288         Update.
3289
3290 2019-05-08  Tom Tromey  <tom@tromey.com>
3291
3292         * objfiles.c (objfile_pspace_info): Add destructor and
3293         initializers.
3294         (objfiles_pspace_data): Change type.
3295         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3296         (get_objfile_pspace_data): Update.
3297         (objfiles_bfd_data): Change type.
3298         (get_objfile_bfd_data): Update.
3299         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3300
3301 2019-05-08  Tom Tromey  <tom@tromey.com>
3302
3303         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3304         Change type.
3305         (get_catch_syscall_inferior_data): Update.
3306         (catch_syscall_inferior_data_cleanup): Remove.
3307         (_initialize_break_catch_syscall): Update.
3308
3309 2019-05-08  Tom Tromey  <tom@tromey.com>
3310
3311         * inflow.c (struct terminal_info): Add destructor and
3312         initializers.
3313         (inflow_inferior_data): Change type.
3314         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3315         (get_inflow_inferior_data, inflow_inferior_exit)
3316         (swap_terminal_info, _initialize_inflow): Update.
3317
3318 2019-05-08  Tom Tromey  <tom@tromey.com>
3319
3320         * target-dcache.c (target_dcache_cleanup): Remove.
3321         (target_dcache_aspace_key): Change type.
3322         (target_dcache_init_p, target_dcache_invalidate)
3323         (target_dcache_get, target_dcache_get_or_init)
3324         (_initialize_target_dcache): Update.
3325         * dcache.h (struct dcache_deleter): New.
3326
3327 2019-05-08  Tom Tromey  <tom@tromey.com>
3328
3329         * symtab.c (struct symbol_cache): Add destructor and
3330         initializers.
3331         (symbol_cache_key): Move.  Change type.
3332         (make_symbol_cache, free_symbol_cache): Remove.
3333         (get_symbol_cache): Update.
3334         (symbol_cache_cleanup): Remove.
3335         (ALL_PSPACES, symbol_cache_flush)
3336         (maintenance_print_symbol_cache)
3337         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3338         Update.
3339
3340 2019-05-08  Tom Tromey  <tom@tromey.com>
3341
3342         * symtab.c (struct main_info): Add destructor and initializers.
3343         (main_progspace_key): Move.  Change type.
3344         (get_main_info): Update.
3345         (main_info_cleanup): Remove.
3346         (_initialize_symtab): Update.
3347
3348 2019-05-08  Tom Tromey  <tom@tromey.com>
3349
3350         * registry.h (DECLARE_REGISTRY): Define the _key class.
3351
3352 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3353
3354         * NEWS: Merge two 'New commands' sections.
3355
3356 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3357
3358         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3359         parameter and use Ada language definition instead.
3360         (ada_val_print_ptr): Remove unused language parameter.
3361         (ada_val_print_num): Remove language parameter and use Ada language
3362         definition instead.
3363         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3364         parameter.
3365         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3366         parameter and use Ada language definition instead.
3367         (ada_val_print_1): Update all ada_val_print_xxx calls.
3368         Remove language parameter.
3369         (ada_val_print): Update ada_val_print_1 call.
3370
3371 2019-05-08  Tom Tromey  <tromey@adacore.com>
3372
3373         * remote.c (remote_hw_watchpoint_limit)
3374         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3375         Now static.
3376
3377 2019-05-08  Tom Tromey  <tromey@adacore.com>
3378
3379         * maint.c (_initialize_maint_cmds): Move initialization code to
3380         remote.c.
3381         (watchdog, show_watchdog): Move to remote.c.
3382         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3383         "watchdog" static.
3384         (_initialize_remote): Move initialization code from maint.c.
3385         * defs.h (watchdog): Don't declare.
3386
3387 2019-05-08  Tom Tromey  <tromey@adacore.com>
3388
3389         * tui/tui-interp.c: Include main.h.
3390         * interps.c: Include main.h.
3391         * main.h (interpreter_p): Declare.
3392         * defs.h (interpreter_p): Don't declare.
3393
3394 2019-05-08  Tom Tromey  <tromey@adacore.com>
3395
3396         * dwarf2loc.c: Include dwarf2read.h.
3397         * defs.h (read_unsigned_leb128): Don't declare.
3398         * dwarf2read.h (read_unsigned_leb128): Declare.
3399
3400 2019-05-08  Tom Tromey  <tromey@adacore.com>
3401
3402         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3403         method.
3404
3405 2019-05-08  Tom Tromey  <tromey@adacore.com>
3406
3407         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3408         when no wrap column is set.
3409
3410 2019-05-08  Tom Tromey  <tromey@adacore.com>
3411
3412         * c-lang.c (c_get_string): Handle non-C-style arrays.
3413
3414 2019-05-08  Tom Tromey  <tromey@adacore.com>
3415
3416         * typeprint.c (print_offset_data::update): Print the bit offset,
3417         not the number of bits remaining.
3418
3419 2019-05-08  Tom Tromey  <tromey@adacore.com>
3420
3421         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3422         padding at end of comment.
3423
3424 2019-05-08  Tom Tromey  <tromey@adacore.com>
3425
3426         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3427         Compare main types.
3428
3429 2019-05-06  Tom Tromey  <tom@tromey.com>
3430
3431         * common/scoped_mmap.c: Include common-defs.h.
3432         * common/scoped_mmap.h: Don't include config.h.
3433
3434 2019-05-04  Tom Tromey  <tom@tromey.com>
3435
3436         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3437         (struct aarch64_call_info): Add initializers.
3438         <si>: Now a std::vector.
3439         (pass_on_stack, aarch64_push_dummy_call): Update.
3440
3441 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3442             Tom Tromey  <tom@tromey.com>
3443
3444         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3445         (ppc_threads): Now a std::vector.  Now static.
3446         (hwdebug_find_thread_points_by_tid)
3447         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3448         Update.
3449
3450 2019-05-04  Tom Tromey  <tom@tromey.com>
3451
3452         * arc-tdep.c (arc_tdesc_init): Return bool.
3453
3454 2019-05-04  Tom Tromey  <tom@tromey.com>
3455
3456         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3457         Use gdb_assert_not_reached.
3458
3459 2019-05-04  Tom Tromey  <tom@tromey.com>
3460
3461         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3462         "false".
3463
3464 2019-05-04  Tom Tromey  <tom@tromey.com>
3465
3466         * arc-tdep.c (arc_tdesc_init): Use bool.
3467
3468 2019-05-04  Tom Tromey  <tom@tromey.com>
3469
3470         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3471
3472 2019-05-04  Tom Tromey  <tom@tromey.com>
3473
3474         * cli/cli-cmds.c (valid_command_p): Return bool.
3475
3476 2019-05-04  Tom Tromey  <tom@tromey.com>
3477
3478         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3479         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3480
3481 2019-05-04  Raul Tambre  <raul@tambre.ee>
3482
3483         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3484         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3485         operator for comparison.
3486
3487 2019-05-04  Tom Tromey  <tom@tromey.com>
3488
3489         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3490         (lookup_partial_symbol, print_partial_symbols)
3491         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3492         (psymbol_compare): Update.
3493         (add_psymbol_to_bcache): Clear the entire psymbol.
3494         (maintenance_check_psymtabs): Update.
3495         * psympriv.h (struct partial_symbol): Don't derive from
3496         general_symbol_info.
3497         <obj_section, unrelocated_address, address,
3498         set_unrelocated_address>: Update.
3499         <ginfo>: New member.
3500         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3501         (debug_names::write_psymbols): Update.
3502
3503 2019-05-04  Tom de Vries  <tdevries@suse.de>
3504
3505         * contrib/cc-with-tweaks.sh: Support -n arg.
3506
3507 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3508
3509         * corelow.c (core_target::detach): Ensure frame cache and
3510         register caches are cleared.
3511         inferior.c (exit_inferior_1): Likewise.
3512
3513 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3514             Tom Tromey  <tom@tromey.com>
3515
3516         * dictionary.c (collate_pending_symbols_by_language): Remove
3517         "struct" from foreach.
3518         * symtab.c (lookup_global_symbol_from_objfile)
3519         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3520         foreach.
3521         * ser-tcp.c (net_open): Remove "struct" from foreach.
3522         * objfiles.c (objfile_relocate, objfile_rebase)
3523         (objfile_has_symbols): Remove "struct" from foreach.
3524         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3525         from foreach.
3526         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3527         foreach.
3528         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3529         "struct" from foreach.
3530         * ada-lang.c (create_excep_cond_exprs)
3531         (ada_exception_catchpoint_cond_string): Remove "struct" from
3532         foreach.
3533
3534 2019-05-03  Tom Tromey  <tromey@adacore.com>
3535
3536         * ada-exp.y (convert_char_literal): Check suffix of each
3537         enumerator.
3538
3539 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3540
3541         PR ada/21406:
3542         * ada-exp.y (yywrap): Don't define.
3543         * ada-lex.l (%option): Add noyywrap
3544         (yywrap): Remove.
3545
3546 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3547
3548         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3549         _WIN32_WINNT to the XP level, unless already defined to a higher
3550         level.
3551
3552         * unittests/parse-connection-spec-selftests.c:
3553         * ser-tcp.c:
3554         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3555         override.
3556
3557         * symfile.c (find_separate_debug_file): Remove colon from the
3558         drive spec of DOS/Windows file names of the target, so that the
3559         file name produced from DEBUGDIR and the target's directory will
3560         be valid on DOS/Windows systems.
3561
3562 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * rust-lang.c (val_print_struct): Handle printing structures
3565         containing strings.
3566
3567 2019-05-02  Tom Tromey  <tromey@adacore.com>
3568
3569         * valarith.c (_initialize_valarith): Remove.
3570
3571 2019-05-01  Tom Tromey  <tromey@adacore.com>
3572
3573         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3574         bitfields.
3575
3576 2019-05-01  Tom Tromey  <tromey@adacore.com>
3577
3578         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3579         for big-endian copies.
3580
3581 2019-04-30  Ali Tamur  <tamur@google.com>
3582         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3583         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3584         (read_3_bytes): New function.
3585
3586 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3587
3588         * windows-nat.c (main_thread_id): Delete.
3589         (handle_output_debug_string): Replace main_thread_id by
3590         current_event.dwThreadId.
3591         (fake_create_process): Likewise.
3592         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3593         Do not set main_thread_id.
3594         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3595         current_event.dwThreadId.
3596         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3597
3598 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3599
3600         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3601         Use current_event.dwThreadId instead of main_thread_id.
3602
3603 2019-04-30  Tom Tromey  <tromey@adacore.com>
3604
3605         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3606         (create_excep_cond_exprs): Iterate over program spaces.
3607         (ada_exception_catchpoint_cond_string): Examine all minimal
3608         symbols for exception types.
3609
3610 2019-04-30  Tom Tromey  <tromey@adacore.com>
3611
3612         PR c++/24470:
3613         * dwarf2read.c (process_structure_scope): Handle case where type
3614         has template parameters but no symbol was created.
3615
3616 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3617             Chris January  <chris.january@arm.com>
3618
3619         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3620         qualifier.
3621         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3622
3623 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * f-typeprint.c (f_print_type): Update rules for printing
3626         whitespace.
3627         (f_type_print_varspec_suffix): Likewise.
3628
3629 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3630             Chris January  <chris.january@arm.com>
3631
3632         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3633         function arguments.
3634
3635 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3636
3637         * f-lang.c (build_fortran_types): Change name of void type to
3638         lower case.
3639         * f-typeprint.c (f_type_print_base): Print the name of the void
3640         type, rather than a fixed string.
3641         * f-valprint.c (f_decorations): Use lower case void string.
3642
3643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3644             Chris January  <chris.january@arm.com>
3645
3646         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3647         types for Fortran.
3648
3649 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3650             Chris January  <chris.january@arm.com>
3651             David Lecomber  <david.lecomber@arm.com>
3652
3653         * f-exp.y (BINOP_INTRINSIC): New token.
3654         (exp): New parser rule handling BINOP_INTRINSIC.
3655         (f77_keywords): Add new builtin procedures.
3656         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3657         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3658         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3659         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3660         (print_unop_subexp_f): New function.
3661         (print_binop_subexp_f): New function.
3662         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3663         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3664         (dump_subexp_body_f): Likewise.
3665         (operator_check_f): Likewise.
3666         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3667         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3668
3669 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3670
3671         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3672         UNOP_KIND.
3673         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3674         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3675         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3676         (operator_length_f): New fuction.
3677         (print_subexp_f): New function.
3678         (op_name_f): New function.
3679         (dump_subexp_body_f): New function.
3680         (operator_check_f): New function.
3681         (exp_descriptor_f): Replace standard expression handling functions
3682         with new functions.
3683         * gdb/fortran-operator.def: New file.
3684         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3685         * gdb/std-operator.def: Remove UNOP_KIND.
3686
3687 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * std-operator.def: Remove unbalanced, stray double quote
3690         character.
3691
3692 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3693             Chris January  <chris.january@arm.com>
3694             Daniel Everett  <daniel.everett@arm.com>
3695             Nick Forrington  <nick.forrington@arm.com>
3696             Richard Bunt  <richard.bunt@arm.com>
3697
3698         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3699         of depth when printing anonymous structs or unions.
3700         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3701         Don't print either the top-level value, or the children if the
3702         max-depth is exceeded.
3703         (ppscm_print_children): When printing the key of a map, allow one
3704         extra level of depth.
3705         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3706         print either the top-level value, or the children if the max-depth
3707         is exceeded.
3708         (print_children): When printing the key of a map, allow one extra
3709         level of depth.
3710         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3711         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3712         (user_print_options): Initialise max_depth field.
3713         (val_print_scalar_or_string_type_p): New function.
3714         (val_print): Check to see if the max depth has been reached.
3715         (val_print_check_max_depth): Define new function.
3716         (show_print_max_depth): New function.
3717         (_initialize_valprint): Add 'print max-depth' option.
3718         * valprint.h (struct value_print_options) <max_depth>: New field.
3719         (val_print_check_max_depth): Declare new function.
3720         * NEWS: Document new feature.
3721
3722 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * ada-lang.c (ada_language_defn): Initialise new field.
3725         * c-lang.c (c_is_string_type_p): New function.
3726         (c_language_defn): Initialise new field.
3727         (cplus_language_defn): Initialise new field.
3728         (asm_language_defn): Initialise new field.
3729         (minimal_language_defn): Initialise new field.
3730         * c-lang.h (c_is_string_type_p): Declare new function.
3731         * d-lang.c (d_language_defn): Initialise new field.
3732         * f-lang.c (f_is_string_type_p): New function.
3733         (f_language_defn): Initialise new field.
3734         * go-lang.c (go_is_string_type_p): New function.
3735         (go_language_defn): Initialise new field.
3736         * language.c (default_is_string_type_p): New function.
3737         (unknown_language_defn): Initialise new field.
3738         (auto_language_defn): Initialise new field.
3739         * language.h (struct language_defn) <la_is_string_type_p>: New
3740         member variable.
3741         (default_is_string_type_p): Declare new function.
3742         * m2-lang.c (m2_language_defn): Initialise new field.
3743         * objc-lang.c (objc_language_defn): Initialise new field.
3744         * opencl-lang.c (opencl_language_defn): Initialise new field.
3745         * p-lang.c (pascal_is_string_type_p): New function.
3746         (pascal_language_defn): Initialise new field.
3747         * rust-lang.c (rust_is_string_type_p): New function.
3748         (rust_language_defn): Initialise new field.
3749
3750 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3753         New field.
3754         * ada-lang.c (ada_language_defn): Initialise new field.
3755         * c-lang.c (c_language_defn): Likewise.
3756         (cplus_language_defn): Likewise.
3757         (asm_language_defn): Likewise.
3758         (minimal_language_defn): Likewise.
3759         * d-lang.c (d_language_defn): Likewise.
3760         * f-lang.c (f_language_defn): Likewise.
3761         * go-lang.c (go_language_defn): Likewise.
3762         * language.c (unknown_language_defn): Likewise.
3763         (auto_language_defn): Likewise.
3764         * m2-lang.c (m2_language_defn): Likewise.
3765         * objc-lang.c (objc_language_defn): Likewise.
3766         * opencl-lang.c (opencl_language_defn): Likewise.
3767         * p-lang.c (pascal_language_defn): Likewise.
3768         * rust-lang.c (rust_language_defn): Likewise.
3769
3770 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * ada-lang.c (ada_is_character_type): Change return type to bool.
3773         (ada_is_string_type): Likewise.
3774         * ada-lang.h (ada_is_character_type): Update declaration
3775         (ada_is_string_type): Likewise.
3776
3777 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3778
3779         Support style in 'frame|thread apply'
3780
3781         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3782         * record.c (record_start, record_stop): Update callers of
3783         execute_command_to_string with false.
3784         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3785         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3786         methods.
3787         (class string_file): New constructor with term_out parameter.
3788         Override methods term_out and can_emit_style_escape.  New member
3789         term_out.
3790         (class stdio_file): Override can_emit_style_escape.
3791         (class tee_file): Override term_out and can_emit_style_escape.
3792         * utils.h (can_emit_style_escape): Remove.
3793         * utils.c (can_emit_style_escape): Likewise.
3794         Update all callers of can_emit_style_escape (SOMESTREAM) to
3795         SOMESTREAM->can_emit_style_escape.
3796         * source-cache.c (source_cache::get_source_lines): Likewise.
3797         * stack.c (frame_apply_command_count): Call execute_command_to_string
3798         passing the term_out characteristic of the current gdb_stdout.
3799         * thread.c (thr_try_catch_cmd): Likewise.
3800         * top.c (execute_command_to_string): pass term_out parameter
3801         to construct the string_file for the command output.
3802         * ui-file.c (term_cli_styling): New function (most code moved
3803         from utils.c can_emit_style_escape).
3804         (string_file::string_file, string_file::can_emit_style_escape,
3805         stdio_file::can_emit_style_escape, tee_file::term_out,
3806         tee_file::can_emit_style_escape): New functions.
3807
3808 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3809
3810         * NEWS: Mention the new set|show may-call-functions.
3811         * infcall.c (may_call_functions_p): New variable.
3812         (show_may_call_functions_p): New function.
3813         (call_function_by_hand_dummy): Throws an error if not
3814         may-call-functions.
3815         (_initialize_infcall): Call add_setshow_boolean_cmd for
3816         may-call-functions.
3817
3818 2019-04-25  Keith Seitz  <keiths@redhat.com>
3819
3820         PR c++/24367
3821         * cp-support.c (inspect_type): Don't attempt substitutions
3822         of symbol with the same name.
3823
3824 2019-04-25  Tom Tromey  <tromey@adacore.com>
3825
3826         PR gdb/24475:
3827         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3828         static.
3829
3830 2019-04-25  Tom Tromey  <tromey@adacore.com>
3831
3832         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3833         rvalue reference.
3834         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3835         (gdb_xml_parser::parse): Use std::move.
3836         * python/python-internal.h (gdbpy_convert_exception): Take a const
3837         reference.
3838         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3839         std::move.
3840         * python/py-utils.c (gdbpy_convert_exception): Take a const
3841         reference.
3842         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3843         Use std::move.
3844         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3845         Use std::move.
3846         * mi/mi-main.c (mi_print_exception): Take a const reference.
3847         * main.c (handle_command_errors): Take a const reference.
3848         * linespec.c (parse_linespec): Use std::move.
3849         * infcall.c (run_inferior_call): Use std::move.
3850         (call_function_by_hand_dummy): Use std::move.
3851         * exec.c (try_open_exec_file): Use std::move.
3852         * exceptions.h (exception_print, exception_fprintf)
3853         (exception_print_same): Update.
3854         * exceptions.c (print_exception, exception_print)
3855         (exception_fprintf, exception_print_same): Change parameters to
3856         const reference.
3857         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3858         * common/new-op.c: Use std::move.
3859         * common/common-exceptions.h (struct gdb_exception): Add move
3860         constructor.
3861         (struct gdb_exception_error, struct gdb_exception_quit, struct
3862         gdb_quit_bad_alloc): Change constructor to move constructor.
3863         (throw_exception): Change parameter to rvalue reference.
3864         * common/common-exceptions.c (throw_exception): Take rvalue
3865         reference.
3866         * cli/cli-interp.c (safe_execute_command): Use std::move.
3867         * breakpoint.c (insert_bp_location, location_to_sals): Use
3868         std::move.
3869
3870 2019-04-25  Tom Tromey  <tromey@adacore.com>
3871
3872         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3873         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3874         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3875         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3876         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3877         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3878         guile/scm-value.c: Use unpack.
3879         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3880         gdbscm_gdb_exception.
3881         (gdbscm_throw_gdb_exception): Likewise.
3882         (struct gdbscm_gdb_exception): New.
3883         (unpack): New function.
3884         (gdbscm_wrap): Use unpack.
3885
3886 2019-04-25  Tom Tromey  <tromey@adacore.com>
3887
3888         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3889         (gdb_rl_callback_handler): Use std::move.
3890         * common/common-exceptions.h (struct gdb_exception): Add move
3891         assignment operator.
3892         (throw_exception_sjlj): Change "exception" to const reference.
3893         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3894         (throw_exception_sjlj): Change "exception" to const reference.
3895
3896 2019-04-25  Tom Tromey  <tromey@adacore.com>
3897
3898         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3899         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3900         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3901         Update.
3902         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3903         Update.
3904         * mi/mi-interp.c (mi_interp::exec): Update.
3905         * linespec.c (parse_linespec): Update.
3906         * infcall.c (run_inferior_call): Update.
3907         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3908         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3909         (gdbscm_lookup_global_symbol): Update.
3910         * guile/scm-param.c (gdbscm_parameter_value): Update.
3911         * guile/scm-frame.c (gdbscm_frame_read_register)
3912         (gdbscm_frame_read_var): Update.
3913         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3914         * exec.c (try_open_exec_file): Update.
3915         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3916         (gdb_rl_callback_handler): Update.
3917         * common/common-exceptions.h (exception_none): Don't declare.
3918         * common/common-exceptions.c (exception_none): Don't define.
3919         (struct catcher) <exception>: Update.
3920         * cli/cli-interp.c (safe_execute_command): Update.
3921         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3922
3923 2019-04-25  Ali Tamur  <tamur@google.com>
3924
3925         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3926         (read_attribute_value): Likewise.
3927         (dwarf2_read_addr_index): Update comment.
3928         (read_str_index): Add DW_FORM_strx.
3929         (dwarf2_string_attr): Likewise.
3930         (dwarf2_const_value_attr): Likewise.
3931         (dump_die_shallow): Likewise.
3932         (dwarf2_fetch_constant_bytes): Likewise.
3933         (skip_form_bytes): Likewise.
3934         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3935
3936 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3937
3938         PR corefiles/11608
3939         PR corefiles/18187
3940         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3941         OFFSET.  Verify if current mapping contains an ELF header.
3942         (linux_find_memory_regions_full): Adjust call to
3943         dump_mapping_p.
3944
3945 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3946             Kang Li <kanglictf@gmail.com>
3947
3948         PR gdb/21600
3949
3950         * dwarf2-frame.c (read_initial_length): Be consistent about using
3951         unsigned representation of length.
3952         (decode_frame_entry_1): Likewise.  Check for wraparound of
3953         end pointer as well as buffer overflow.
3954
3955 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3956
3957         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3958         "vq".
3959
3960 2019-04-24  Tom Tromey  <tromey@adacore.com>
3961
3962         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3963
3964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3965
3966         * s12z-tdep.c (s12z_unwind_pc): Delete.
3967         (s12z_unwind_sp): Delete.
3968         (s12z_gdbarch_init): Don't register deleted functions with
3969         gdbarch.
3970
3971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3972
3973         * rl78-tdep.c (rl78_unwind_sp): Delete.
3974         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3975
3976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3979         (xstormy16_unwind_pc): Delete.
3980         (xstormy16_dummy_id): Delete.
3981         (xstormy16_gdbarch_init): Don't register deleted functions with
3982         gdbarch.
3983
3984 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3985
3986         * vax-tdep.c (vax_unwind_pc): Delete.
3987         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3988
3989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * v850-tdep.c (v850_unwind_sp): Delete.
3992         (v850_unwind_pc): Delete.
3993         (v850_dummy_id): Delete.
3994         (v850_gdbarch_init): Don't register deleted functions with
3995         gdbarch.
3996
3997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4000         (tilegx_unwind_pc): Delete.
4001         (tilegx_unwind_dummy_id): Delete.
4002         (tilegx_gdbarch_init): Don't register deleted functions with
4003         gdbarch.
4004
4005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4006
4007         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4008         (tic6x_dummy_id): Delete.
4009         (tic6x_gdbarch_init): Don't register deleted functions with
4010         gdbarch.
4011
4012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * sparc-tdep.c (sparc_unwind_pc): Delete.
4015         (sparc32_gdbarch_init): Don't register deleted function with
4016         gdbarch.
4017
4018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4019
4020         * sh-tdep.c (sh_unwind_sp): Delete.
4021         (sh_unwind_pc): Delete.
4022         (sh_dummy_id): Delete.
4023         (sh_gdbarch_init): Don't register deleted functions with
4024         gdbarch.
4025
4026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * score-tdep.c (score_unwind_sp): Delete.
4029         (score_unwind_pc): Delete.
4030         (score_dummy_id): Delete.
4031         (score_gdbarch_init): Don't register deleted functions with
4032         gdbarch.
4033
4034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * rx-tdep.c (rx_unwind_pc): Delete.
4037         (rx_unwind_sp): Delete.
4038         (rx_dummy_id): Delete.
4039         (rx_gdbarch_init): Don't register deleted functions with
4040         gdbarch.  Update comment.
4041
4042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4043
4044         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4045         (rs6000_dummy_id): Delete.
4046         (rs6000_gdbarch_init): Don't register deleted functions with
4047         gdbarch.
4048
4049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4050
4051         * or1k-tdep.c (or1k_dummy_id): Delete.
4052         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4053
4054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4055
4056         * nios2-tdep.c (nios2_dummy_id): Delete.
4057         (nios2_unwind_sp): Delete.
4058         (nios2_gdbarch_init): Don't register deleted functions with
4059         gdbarch.
4060
4061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * nds32-tdep.c (nds32_dummy_id): Delete.
4064         (nds32_unwind_pc): Delete.
4065         (nds32_unwind_sp): Delete.
4066         (nds32_gdbarch_init): Don't register deleted functions with
4067         gdbarch.
4068
4069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * msp430-tdep.c (msp430_unwind_pc): Delete.
4072         (msp430_unwind_sp): Delete.
4073         (msp430_dummy_id): Delete.
4074         (msp430_gdbarch_init): Don't register deleted functions with
4075         gdbarch.
4076
4077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4078
4079         * moxie-tdep.c (moxie_unwind_sp): Delete.
4080         (moxie_unwind_pc): Delete.
4081         (moxie_dummy_id): Delete.
4082         (moxie_gdbarch_init): Don't register deleted functions with
4083         gdbarch.
4084
4085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4088         (mn10300_unwind_pc): Delete.
4089         (mn10300_unwind_sp): Delete.
4090         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4091         mn10300_unwind_sp.
4092         (mn10300_frame_unwind_init): Don't register deleted functions with
4093         gdbarch.
4094
4095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4096
4097         * mep-tdep.c (mep_unwind_pc): Delete.
4098         (mep_unwind_sp): Delete.
4099         (mep_dummy_id): Delete.
4100         (mep_gdbarch_init): Don't register deleted functions with
4101         gdbarch.
4102
4103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4104
4105         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4106         (m68hc11_unwind_sp): Delete.
4107         (m68hc11_gdbarch_init): Don't register deleted functions with
4108         gdbarch.
4109
4110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4111
4112         * m32r-tdep.c (m32r_unwind_sp): Delete.
4113         (m32r_unwind_pc): Delete.
4114         (m32r_dummy_id): Delete.
4115         (m32r_gdbarch_init): Don't register deleted functions with
4116         gdbarch.
4117
4118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4119
4120         * m32c-tdep.c (m32c_unwind_pc): Delete.
4121         (m32c_unwind_sp): Delete.
4122         (m32c_dummy_id): Delete.
4123         (m32c_gdbarch_init): Don't register deleted functions with
4124         gdbarch.
4125
4126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4129         (lm32_unwind_pc): Delete.
4130         (lm32_dummy_id): Delete.
4131         (lm32_gdbarch_init): Don't register deleted functions with
4132         gdbarch.
4133
4134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4135
4136         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4137         (iq2000_unwind_pc): Delete.
4138         (iq2000_dummy_id): Delete.
4139         (iq2000_gdbarch_init): Don't register deleted functions with
4140         gdbarch.
4141
4142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * nds32-tdep.c (nds32_type_align): Delete.
4145         (nds32_push_dummy_call): Use type_align instead.
4146
4147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * arm-tdep.c (arm_type_align): Only handle vector override case.
4150         (arm_push_dummy_call): Use type_align.
4151         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4152
4153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4156         case.
4157         (pass_on_stack): Use type_align.
4158         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4159         function.
4160
4161 2019-04-23  Tom Tromey  <tromey@adacore.com>
4162
4163         * dwarf2read.c (line_header::file_name_at): Remove unused
4164         overload.
4165
4166 2019-04-23  Tom de Vries  <tdevries@suse.de>
4167
4168         PR gdb/24438
4169         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4170         invocation.
4171
4172
4173 2019-03-27  Ali Tamur  <tamur@google.com>
4174
4175         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4176         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4177         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4178         (dwarf_expr_context::get_addr_index): Likewise
4179         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4180         (symbol_needs_eval_context::get_addr_index): Likewise
4181         (disassemble_dwarf_expression): Add DW_OP_addrx
4182         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4183         (read_cutu_die_from_dwo): Update comment
4184         (skip_one_die): Add DW_FORM_addrx
4185         (read_attribute_value): Likewise
4186         (var_decode_location): Add DW_OP_addrx
4187         (dwarf2_const_value_attr): Add DW_FORM_addrx
4188         (dump_die_shallow): Likewise
4189         (dwarf2_fetch_constant_bytes): Likewise
4190         (decode_locdesc): Add DW_OP_addrx
4191         (skip_form_bytes): Add DW_FORM_addrx
4192
4193 2019-04-22  Ali Tamur  <tamur@google.com>
4194
4195         * MAINTAINERS (Write After Approval): Add self.
4196
4197 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4198
4199         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4200         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4201         (open_symbol_file_object): Likewise.
4202         (svr4_default_sos): Add info parameter.
4203         (svr4_read_so_list): Likewise.
4204         (svr4_current_sos_direct): Adjust functions calls to pass down
4205         info.
4206         (svr4_current_sos_1): Add info parameter.
4207         (svr4_current_sos): Call get_svr4_info, pass info down to
4208         svr4_current_sos_1.
4209         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4210         get_svr4_info.
4211         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4212         get_svr4_info.
4213         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4214         to get_svr4_info.
4215         (probes_table_remove_objfile_probes): Likewise.
4216         (register_solib_event_probe): Add info parameter.
4217         (solist_update_incremental): Pass info parameter down to
4218         svr4_read_so_list.
4219         (disable_probes_interface): Add info parameter.
4220         (svr4_handle_solib_event): Pass current_program_space to
4221         get_svr4_info.  Adjust disable_probes_interface cleanup.
4222         (svr4_create_probe_breakpoints): Add info parameter, pass it
4223         down to register_solib_event_probe.
4224         (svr4_create_solib_event_breakpoints): Add info parameter,
4225         pass it down to svr4_create_probe_breakpoints.
4226         (enable_break): Pass info down to
4227         svr4_create_solib_event_breakpoints.
4228         (svr4_solib_create_inferior_hook): Pass current_program_space to
4229         get_svr4_info.
4230         (svr4_clear_solib): Likewise.
4231
4232 2019-04-22  Pedro Alves  <palves@redhat.com>
4233
4234         * solib-svr4.c (svr4_free_objfile_observer): New.
4235         (probe_and_action::objfile): New field.
4236         (probes_table_htab_remove_objfile_probes)
4237         (probes_table_remove_objfile_probes): New functions.
4238         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4239         in the new probe_and_action.  Don't store the probe in 'lookup'.
4240         (svr4_create_probe_breakpoints): Pass objfile to
4241         register_solib_event_probe.
4242         (_initialize_svr4_solib): Register a free_objfile observer.
4243
4244 2019-04-19  Tom Tromey  <tom@tromey.com>
4245
4246         * common/queue.h: Remove.
4247
4248 2019-04-19  Tom Tromey  <tom@tromey.com>
4249
4250         * event-loop.c: Don't include "common/queue.h".
4251
4252 2019-04-19  Tom Tromey  <tom@tromey.com>
4253
4254         * remote.c (remote_target): Use delete.
4255         * remote-notif.h: Include <list>, not "common/queue.h".
4256         (notif_client_p): Remove typedef.
4257         (remote_notif_state): Add constructor, destructor, initializer.
4258         <notif_queue>: Now a std::list.
4259         (remote_notif_state_xfree): Don't declare.
4260         * remote-notif.c (remote_notif_process, handle_notification)
4261         (remote_notif_state_allocate): Update.
4262         (~remote_notif_state): Rename from remote_notif_state_xfree.
4263
4264 2019-04-19  Tom Tromey  <tom@tromey.com>
4265
4266         * symfile.c (reread_symbols): Update.
4267         * objfiles.c (objfile_register_static_link)
4268         (objfile_lookup_static_link): Update
4269         (~objfile) Don't delete static_links.
4270         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4271
4272 2019-04-19  Tom Tromey  <tom@tromey.com>
4273
4274         * type-stack.h (struct type_stack) <insert>: Constify string.
4275         * type-stack.c (type_stack::insert): Constify string.
4276         * gdbtypes.h (lookup_template_type): Update.
4277         (address_space_name_to_int): Update.
4278         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4279         const.
4280         (lookup_template_type): Make name const.
4281         * c-exp.y: Update rules.
4282         (lex_one_token, classify_name, classify_inner_name)
4283         (c_print_token): Update.
4284         * p-exp.y: Update rules.
4285         (yylex): Update.
4286         * f-exp.y: Update rules.
4287         (yylex): Update.
4288         * d-exp.y: Update rules.
4289         (lex_one_token, classify_name, classify_inner_name): Update.
4290         * parse.c (write_dollar_variable, copy_name): Return std::string.
4291         * parser-defs.h (copy_name): Change return type.
4292         * m2-exp.y: Update rules.
4293         (yylex): Update.
4294         * go-exp.y (lex_one_token): Update.
4295         Update rules.
4296         (classify_unsafe_function, classify_packaged_name)
4297         (classify_name, yylex): Update.
4298
4299 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4300
4301         * configure.ac: add --enable-source-highlight switch.
4302         * configure: Regenerate.
4303         * top.c (print_gdb_version): plumb --enable-source-highlight
4304         status to "show configuration".
4305
4306 2019-04-19  Tom Tromey  <tromey@adacore.com>
4307
4308         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4309         Check ADA_TYPE_P.
4310         (empty_record, ada_template_to_fixed_record_type_1)
4311         (template_to_static_fixed_type)
4312         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4313         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4314         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4315         macros.
4316
4317 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4318
4319         PR symtab/24423:
4320         * source.c (print_source_lines_base): Advance "iter" when a
4321         control character is seen.
4322
4323 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4324
4325         * inferior.h (struct infcall_suspend_state_deleter):
4326         Catch exception in destructor to avoid crash.
4327
4328 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4329
4330         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4331         close to the add_com "shell".
4332
4333 2019-04-18  Tom Tromey  <tromey@adacore.com>
4334
4335         * process-stratum-target.h (class process_stratum_target)
4336         <stratum>: Add "final".
4337
4338 2019-04-17  Tom Tromey  <tromey@adacore.com>
4339
4340         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4341         against nullptr before use.
4342
4343 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4344
4345         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4346
4347 2019-04-17  Jim Wilson  <jimw@sifive.com>
4348             Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4351         code read might fail, assume 4-byte breakpoint in that case.
4352
4353 2019-04-15  Leszek Swirski  <leszeks@google.com>
4354
4355         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4356         rather than a hand-rolled POD check when checking for forced MEMORY
4357         classification.
4358
4359 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4360
4361         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4362         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4363         function.
4364         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4365         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4366         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4367         declaration.
4368
4369 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4370
4371         * aarch64-linux-nat.c
4372         (aarch64_linux_nat_target::thread_architecture): Add override.
4373         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4374         each VQ.
4375
4376 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4377
4378         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4379
4380 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4381
4382         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4383         target types of size 96-bits, add some additional comments, and
4384         check that the builtin type we found was the correct size.
4385
4386 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4387
4388         * utils.c (prompt_for_continue): Don't restore the styling at the
4389         end, as applied_style has the wrong value.  This fixes styling in
4390         long lists of file names that are interrupted by the "Continue?"
4391         prompt.
4392
4393 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4396         * c-lang.c (c_language_defn): Likewise.
4397         (cplus_language_defn): Likewise.
4398         (asm_language_defn): Likewise.
4399         (minimal_language_defn): Likewise.
4400         * d-lang.c (d_language_defn): Likewise.
4401         * f-lang.c (f_language_defn): Likewise.
4402         * go-lang.c (go_language_defn): Likewise.
4403         * language.c (unknown_language_defn): Likewise.
4404         (auto_language_defn): Likewise.
4405         * language.h (struct language_defn): Remove la_magic field.
4406         (LANG_MAGIC): Delete.
4407         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4408         * objc-lang.c (objc_language_defn): Likewise.
4409         * opencl-lang.c (opencl_language_defn): Likewise.
4410         * p-lang.c (pascal_language_defn): Likewise.
4411         * rust-lang.c (rust_language_defn): Likewise.
4412
4413 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * riscv-tdep.c (riscv_type_align): New function.
4416         (riscv_type_alignment): Delete.
4417         (riscv_arg_location): Use 'type_align'.
4418         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4419
4420 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * gdbtypes.c (type_align): A struct with no non-static fields also
4423         has alignment of 1.
4424
4425 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4426
4427         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4428         component to 0.
4429         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4430         member.
4431         (riscv_struct_info::analyse): New implementation using new
4432         analyse_inner member function.
4433         (riscv_struct_info::field_offset): New member function.
4434         (riscv_struct_info::m_offsets): New member variable.
4435         (riscv_struct_info::analyse_inner): New private member function,
4436         takes the old implementation of riscv_struct_info::analyse but
4437         extended to track field offsets.
4438         (riscv_call_arg_struct): Update the struct folding special cases
4439         to handle cases where empty C++ structs, which are non-zero
4440         length, are found.
4441         (riscv_arg_location): Initialise the length of each location, a
4442         non-zero length now indicates the location is in use.
4443         (riscv_push_dummy_call): Allow for the first location having a
4444         non-zero offset when setting up arguments.
4445         (riscv_return_value): Likewise, but for return values.
4446
4447 2019-04-11  Tom Tromey  <tromey@adacore.com>
4448
4449         * utils.c (internal_vproblem): Make "msg" const.
4450
4451 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4452
4453         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4454         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4455         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4456         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4457
4458 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4459
4460         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4461         function.
4462         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4463         of amd64_collect_native_gregset.
4464         (amd64_linux_nat_target::store_registers): Likewise.
4465
4466 2019-04-10  Tom Tromey  <tom@tromey.com>
4467
4468         * symtab.c (lookup_global_symbol_from_objfile)
4469         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4470         * objfiles.h (class separate_debug_iterator): New.
4471         (class separate_debug_range): New.
4472         (struct objfile) <separate_debug_objfiles>: New method.
4473         (objfile_separate_debug_iterate): Don't declare.
4474         * objfiles.c (separate_debug_iterator::operator++): Rename from
4475         objfile_separate_debug_iterate.
4476         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4477         iterator.
4478         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4479         iterator.
4480
4481 2019-04-10  Tom Tromey  <tom@tromey.com>
4482
4483         * symfile.c (reread_symbols): Remove old comment.
4484         * objfiles.c (free_all_objfiles): Fix a typo.
4485
4486 2019-04-10  Tom Tromey  <tom@tromey.com>
4487
4488         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4489         * minsyms.c (lookup_minimal_symbol): Use foreach.
4490         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4491         (lookup_minimal_symbol_solib_trampoline): Likewise.
4492         * symfile.c (reread_symbols): Use foreach.
4493
4494 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4495             Tom Tromey  <tromey@adacore.com>
4496
4497         PR rust/24414:
4498         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4499         (rust_lex_int_test): Change "value" to be LONGEST.
4500         (rust_lex_tests): Add test for long integer literal.
4501
4502 2019-04-09  Tom Tromey  <tromey@adacore.com>
4503
4504         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4505         to bool.
4506         (extended_remote_target::attach): Update.
4507         (remote_target::remote_notice_new_inferior): Update.
4508         (remote_target::add_current_inferior_and_thread): Update.
4509         * inferior.c (exit_inferior_1): Use "false".
4510         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4511
4512 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4513
4514         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4515         the "start" command.
4516
4517 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4518
4519         * python/py-inferior.c (infpy_thread_from_thread_handle):
4520         Adjust comments to reflect renaming of thread_from_thread_handle
4521         to thread_from_handle.  Adjust keywords.  Fix type error message.
4522         (inferior_object_methods): Add thread_from_handle.  Retain
4523         thread_from_thread_handle, but mark it as deprecated.
4524
4525 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4526
4527         * gdbthread.h (find_thread_by_handle): Revise declaration.
4528         * thread.c (find_thread_by_handle): Likewise.  Adjust
4529         implementation too.
4530         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4531         support for buffer objects as handles.
4532
4533 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4534
4535         * python/py-infthread.c (thpy_thread_handle): New function.
4536         (thread_object_methods): Register thpy_thread_handle.
4537
4538 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4539
4540         * gdbthread.h (thread_to_thread_handle): Declare.
4541         * thread.c (gdbtypes.h): Include.
4542         (thread_to_thread_handle): New function.
4543
4544         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4545         (target_thread_info_to_thread_handle): Declare.
4546         * target.c (target_thread_info_to_thread_handle): New function.
4547         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4548         * target-delegates.c: Regenerate.
4549
4550         * linux-thread-db.c (class thread_db_target): Add method
4551         thread_info_to_thread_handle.
4552         (thread_db_target::thread_info_to_thread_handle): Define.
4553         * remote.c (class remote_target): Add new method
4554         thread_info_to_thread_handle.
4555         (remote_target::thread_info_to_thread_handle): Define.
4556
4557 2019-04-08  Pedro Alves  <palves@redhat.com>
4558
4559         * common/common-exceptions.c (throw_exception): Don't create
4560         named object to throw; throw directly.
4561         (throw_it): Likewise.  Don't initialize gdb_exception::message
4562         here, with new; pass FMT and AP to the ctor instead.
4563         * common/common-exceptions.h: Include <string>.
4564         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4565         const char *, va_list)): New ctor.  Use std::make_shared.
4566         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4567         errors)): Delete.
4568         (gdb_exception_error::gdb_exception_error(enum errors, const char
4569         *, va_list)): New.
4570         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4571         Add assertion.
4572         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4573         errors)): Delete.
4574         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4575         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4576         Add assertion.
4577
4578 2019-04-08  Tom Tromey  <tom@tromey.com>
4579
4580         * valops.c (value_rtti_indirect_type): Replace throw_exception
4581         with throw.
4582         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4583         with throw.
4584         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4585         throw.
4586         * target.c (target_translate_tls_address): Replace throw_exception
4587         with throw.
4588         * stack.c (frame_apply_command_count): Replace throw_exception
4589         with throw.
4590         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4591         throw.
4592         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4593         with throw.
4594         * rs6000-tdep.c (rs6000_frame_cache)
4595         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4596         * remote.c: Replace throw_exception with throw.
4597         * record-full.c (record_full_message, record_full_wait_1)
4598         (record_full_restore): Replace throw_exception with throw.
4599         * record-btrace.c:
4600         (get_thread_current_frame_id, record_btrace_start_replaying)
4601         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4602         (cmd_record_btrace_start): Replace throw_exception with throw.
4603         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4604         throw.
4605         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4606         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4607         * linespec.c:
4608         (find_linespec_symbols): Replace throw_exception with throw.
4609         * infrun.c (displaced_step_prepare, resume): Replace
4610         throw_exception with throw.
4611         * infcmd.c (post_create_inferior): Replace throw_exception with
4612         throw.
4613         * inf-loop.c (inferior_event_handler): Replace throw_exception
4614         with throw.
4615         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4616         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4617         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4618         (get_prev_frame_always, get_frame_pc_if_available)
4619         (get_frame_address_in_block_if_available, get_frame_language):
4620         Replace throw_exception with throw.
4621         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4622         throw_exception with throw.
4623         * eval.c (fetch_subexp_value, evaluate_var_value)
4624         (evaluate_funcall, evaluate_subexp_standard): Replace
4625         throw_exception with throw.
4626         * dwarf2loc.c (call_site_find_chain)
4627         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4628         Replace throw_exception with throw.
4629         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4630         with throw.
4631         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4632         throw.
4633         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4634         * completer.c (complete_line_internal): Replace throw_exception
4635         with throw.
4636         * compile/compile-object-run.c (compile_object_run): Replace
4637         throw_exception with throw.
4638         * cli/cli-script.c (process_next_line): Replace throw_exception
4639         with throw.
4640         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4641         (btrace_enable, btrace_maint_update_pt_packets): Replace
4642         throw_exception with throw.
4643         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4644         throw_exception with throw.
4645         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4646         throw_exception with throw.
4647         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4648         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4649         * aarch64-tdep.c (aarch64_make_prologue_cache)
4650         (aarch64_make_stub_cache): Replace throw_exception with throw.
4651
4652 2019-04-08  Tom Tromey  <tom@tromey.com>
4653
4654         * common/common-exceptions.c (throw_exception): Rename from
4655         throw_exception_cxx.  Remove old copy.  Make argument const.
4656         (throw_it): Create and throw exception objects directly.
4657         * common/common-exceptions.h (throw_exception): Make argument
4658         const.
4659         (struct gdb_exception_error): Add constructor.
4660         (struct gdb_exception_quit): Add constructor.
4661
4662 2019-04-08  Tom Tromey  <tom@tromey.com>
4663
4664         * common/common-exceptions.h (exception_rethrow): Don't declare.
4665         (TRY_SJLJ): Update comment.
4666         (TRY, CATCH, END_CATCH): Remove.
4667         * common/common-exceptions.c (exception_rethrow): Remove.
4668
4669 2019-04-08  Tom Tromey  <tom@tromey.com>
4670
4671         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4672         Remove.
4673         (gdb_exception_error): Rename from
4674         gdb_exception_RETURN_MASK_ERROR.
4675         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4676         (gdb_quit_bad_alloc): Update.
4677         * aarch64-tdep.c: Update.
4678         * ada-lang.c: Update.
4679         * ada-typeprint.c: Update.
4680         * ada-valprint.c: Update.
4681         * amd64-tdep.c: Update.
4682         * arch-utils.c: Update.
4683         * break-catch-throw.c: Update.
4684         * breakpoint.c: Update.
4685         * btrace.c: Update.
4686         * c-varobj.c: Update.
4687         * cli/cli-cmds.c: Update.
4688         * cli/cli-interp.c: Update.
4689         * cli/cli-script.c: Update.
4690         * common/common-exceptions.c: Update.
4691         * common/new-op.c: Update.
4692         * common/selftest.c: Update.
4693         * compile/compile-c-symbols.c: Update.
4694         * compile/compile-cplus-symbols.c: Update.
4695         * compile/compile-object-load.c: Update.
4696         * compile/compile-object-run.c: Update.
4697         * completer.c: Update.
4698         * corelow.c: Update.
4699         * cp-abi.c: Update.
4700         * cp-support.c: Update.
4701         * cp-valprint.c: Update.
4702         * darwin-nat.c: Update.
4703         * disasm-selftests.c: Update.
4704         * dtrace-probe.c: Update.
4705         * dwarf-index-cache.c: Update.
4706         * dwarf-index-write.c: Update.
4707         * dwarf2-frame-tailcall.c: Update.
4708         * dwarf2-frame.c: Update.
4709         * dwarf2loc.c: Update.
4710         * dwarf2read.c: Update.
4711         * eval.c: Update.
4712         * event-loop.c: Update.
4713         * event-top.c: Update.
4714         * exec.c: Update.
4715         * f-valprint.c: Update.
4716         * fbsd-tdep.c: Update.
4717         * frame-unwind.c: Update.
4718         * frame.c: Update.
4719         * gdbtypes.c: Update.
4720         * gnu-v3-abi.c: Update.
4721         * guile/guile-internal.h: Update.
4722         * guile/scm-block.c: Update.
4723         * guile/scm-breakpoint.c: Update.
4724         * guile/scm-cmd.c: Update.
4725         * guile/scm-disasm.c: Update.
4726         * guile/scm-frame.c: Update.
4727         * guile/scm-lazy-string.c: Update.
4728         * guile/scm-math.c: Update.
4729         * guile/scm-param.c: Update.
4730         * guile/scm-ports.c: Update.
4731         * guile/scm-pretty-print.c: Update.
4732         * guile/scm-symbol.c: Update.
4733         * guile/scm-symtab.c: Update.
4734         * guile/scm-type.c: Update.
4735         * guile/scm-value.c: Update.
4736         * i386-linux-tdep.c: Update.
4737         * i386-tdep.c: Update.
4738         * inf-loop.c: Update.
4739         * infcall.c: Update.
4740         * infcmd.c: Update.
4741         * infrun.c: Update.
4742         * jit.c: Update.
4743         * language.c: Update.
4744         * linespec.c: Update.
4745         * linux-fork.c: Update.
4746         * linux-nat.c: Update.
4747         * linux-tdep.c: Update.
4748         * linux-thread-db.c: Update.
4749         * main.c: Update.
4750         * mi/mi-cmd-break.c: Update.
4751         * mi/mi-cmd-stack.c: Update.
4752         * mi/mi-interp.c: Update.
4753         * mi/mi-main.c: Update.
4754         * objc-lang.c: Update.
4755         * p-valprint.c: Update.
4756         * parse.c: Update.
4757         * ppc-linux-tdep.c: Update.
4758         * printcmd.c: Update.
4759         * python/py-arch.c: Update.
4760         * python/py-breakpoint.c: Update.
4761         * python/py-cmd.c: Update.
4762         * python/py-finishbreakpoint.c: Update.
4763         * python/py-frame.c: Update.
4764         * python/py-framefilter.c: Update.
4765         * python/py-gdb-readline.c: Update.
4766         * python/py-inferior.c: Update.
4767         * python/py-infthread.c: Update.
4768         * python/py-lazy-string.c: Update.
4769         * python/py-linetable.c: Update.
4770         * python/py-objfile.c: Update.
4771         * python/py-param.c: Update.
4772         * python/py-prettyprint.c: Update.
4773         * python/py-progspace.c: Update.
4774         * python/py-record-btrace.c: Update.
4775         * python/py-record.c: Update.
4776         * python/py-symbol.c: Update.
4777         * python/py-type.c: Update.
4778         * python/py-unwind.c: Update.
4779         * python/py-utils.c: Update.
4780         * python/py-value.c: Update.
4781         * python/python.c: Update.
4782         * record-btrace.c: Update.
4783         * record-full.c: Update.
4784         * remote-fileio.c: Update.
4785         * remote.c: Update.
4786         * riscv-tdep.c: Update.
4787         * rs6000-aix-tdep.c: Update.
4788         * rs6000-tdep.c: Update.
4789         * rust-exp.y: Update.
4790         * rust-lang.c: Update.
4791         * s390-tdep.c: Update.
4792         * selftest-arch.c: Update.
4793         * solib-dsbt.c: Update.
4794         * solib-frv.c: Update.
4795         * solib-spu.c: Update.
4796         * solib-svr4.c: Update.
4797         * solib.c: Update.
4798         * sparc64-linux-tdep.c: Update.
4799         * stack.c: Update.
4800         * symfile-mem.c: Update.
4801         * symmisc.c: Update.
4802         * target.c: Update.
4803         * thread.c: Update.
4804         * top.c: Update.
4805         * tracefile-tfile.c: Update.
4806         * tui/tui.c: Update.
4807         * typeprint.c: Update.
4808         * unittests/cli-utils-selftests.c: Update.
4809         * unittests/parse-connection-spec-selftests.c: Update.
4810         * valops.c: Update.
4811         * valprint.c: Update.
4812         * value.c: Update.
4813         * varobj.c: Update.
4814         * windows-nat.c: Update.
4815         * x86-linux-nat.c: Update.
4816         * xml-support.c: Update.
4817
4818 2019-04-08  Tom Tromey  <tom@tromey.com>
4819
4820         * xml-support.c: Use C++ exception handling.
4821         * x86-linux-nat.c: Use C++ exception handling.
4822         * windows-nat.c: Use C++ exception handling.
4823         * varobj.c: Use C++ exception handling.
4824         * value.c: Use C++ exception handling.
4825         * valprint.c: Use C++ exception handling.
4826         * valops.c: Use C++ exception handling.
4827         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4828         handling.
4829         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4830         * typeprint.c: Use C++ exception handling.
4831         * tui/tui.c: Use C++ exception handling.
4832         * tracefile-tfile.c: Use C++ exception handling.
4833         * top.c: Use C++ exception handling.
4834         * thread.c: Use C++ exception handling.
4835         * target.c: Use C++ exception handling.
4836         * symmisc.c: Use C++ exception handling.
4837         * symfile-mem.c: Use C++ exception handling.
4838         * stack.c: Use C++ exception handling.
4839         * sparc64-linux-tdep.c: Use C++ exception handling.
4840         * solib.c: Use C++ exception handling.
4841         * solib-svr4.c: Use C++ exception handling.
4842         * solib-spu.c: Use C++ exception handling.
4843         * solib-frv.c: Use C++ exception handling.
4844         * solib-dsbt.c: Use C++ exception handling.
4845         * selftest-arch.c: Use C++ exception handling.
4846         * s390-tdep.c: Use C++ exception handling.
4847         * rust-lang.c: Use C++ exception handling.
4848         * rust-exp.y: Use C++ exception handling.
4849         * rs6000-tdep.c: Use C++ exception handling.
4850         * rs6000-aix-tdep.c: Use C++ exception handling.
4851         * riscv-tdep.c: Use C++ exception handling.
4852         * remote.c: Use C++ exception handling.
4853         * remote-fileio.c: Use C++ exception handling.
4854         * record-full.c: Use C++ exception handling.
4855         * record-btrace.c: Use C++ exception handling.
4856         * python/python.c: Use C++ exception handling.
4857         * python/py-value.c: Use C++ exception handling.
4858         * python/py-utils.c: Use C++ exception handling.
4859         * python/py-unwind.c: Use C++ exception handling.
4860         * python/py-type.c: Use C++ exception handling.
4861         * python/py-symbol.c: Use C++ exception handling.
4862         * python/py-record.c: Use C++ exception handling.
4863         * python/py-record-btrace.c: Use C++ exception handling.
4864         * python/py-progspace.c: Use C++ exception handling.
4865         * python/py-prettyprint.c: Use C++ exception handling.
4866         * python/py-param.c: Use C++ exception handling.
4867         * python/py-objfile.c: Use C++ exception handling.
4868         * python/py-linetable.c: Use C++ exception handling.
4869         * python/py-lazy-string.c: Use C++ exception handling.
4870         * python/py-infthread.c: Use C++ exception handling.
4871         * python/py-inferior.c: Use C++ exception handling.
4872         * python/py-gdb-readline.c: Use C++ exception handling.
4873         * python/py-framefilter.c: Use C++ exception handling.
4874         * python/py-frame.c: Use C++ exception handling.
4875         * python/py-finishbreakpoint.c: Use C++ exception handling.
4876         * python/py-cmd.c: Use C++ exception handling.
4877         * python/py-breakpoint.c: Use C++ exception handling.
4878         * python/py-arch.c: Use C++ exception handling.
4879         * printcmd.c: Use C++ exception handling.
4880         * ppc-linux-tdep.c: Use C++ exception handling.
4881         * parse.c: Use C++ exception handling.
4882         * p-valprint.c: Use C++ exception handling.
4883         * objc-lang.c: Use C++ exception handling.
4884         * mi/mi-main.c: Use C++ exception handling.
4885         * mi/mi-interp.c: Use C++ exception handling.
4886         * mi/mi-cmd-stack.c: Use C++ exception handling.
4887         * mi/mi-cmd-break.c: Use C++ exception handling.
4888         * main.c: Use C++ exception handling.
4889         * linux-thread-db.c: Use C++ exception handling.
4890         * linux-tdep.c: Use C++ exception handling.
4891         * linux-nat.c: Use C++ exception handling.
4892         * linux-fork.c: Use C++ exception handling.
4893         * linespec.c: Use C++ exception handling.
4894         * language.c: Use C++ exception handling.
4895         * jit.c: Use C++ exception handling.
4896         * infrun.c: Use C++ exception handling.
4897         * infcmd.c: Use C++ exception handling.
4898         * infcall.c: Use C++ exception handling.
4899         * inf-loop.c: Use C++ exception handling.
4900         * i386-tdep.c: Use C++ exception handling.
4901         * i386-linux-tdep.c: Use C++ exception handling.
4902         * guile/scm-value.c: Use C++ exception handling.
4903         * guile/scm-type.c: Use C++ exception handling.
4904         * guile/scm-symtab.c: Use C++ exception handling.
4905         * guile/scm-symbol.c: Use C++ exception handling.
4906         * guile/scm-pretty-print.c: Use C++ exception handling.
4907         * guile/scm-ports.c: Use C++ exception handling.
4908         * guile/scm-param.c: Use C++ exception handling.
4909         * guile/scm-math.c: Use C++ exception handling.
4910         * guile/scm-lazy-string.c: Use C++ exception handling.
4911         * guile/scm-frame.c: Use C++ exception handling.
4912         * guile/scm-disasm.c: Use C++ exception handling.
4913         * guile/scm-cmd.c: Use C++ exception handling.
4914         * guile/scm-breakpoint.c: Use C++ exception handling.
4915         * guile/scm-block.c: Use C++ exception handling.
4916         * guile/guile-internal.h: Use C++ exception handling.
4917         * gnu-v3-abi.c: Use C++ exception handling.
4918         * gdbtypes.c: Use C++ exception handling.
4919         * frame.c: Use C++ exception handling.
4920         * frame-unwind.c: Use C++ exception handling.
4921         * fbsd-tdep.c: Use C++ exception handling.
4922         * f-valprint.c: Use C++ exception handling.
4923         * exec.c: Use C++ exception handling.
4924         * event-top.c: Use C++ exception handling.
4925         * event-loop.c: Use C++ exception handling.
4926         * eval.c: Use C++ exception handling.
4927         * dwarf2read.c: Use C++ exception handling.
4928         * dwarf2loc.c: Use C++ exception handling.
4929         * dwarf2-frame.c: Use C++ exception handling.
4930         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4931         * dwarf-index-write.c: Use C++ exception handling.
4932         * dwarf-index-cache.c: Use C++ exception handling.
4933         * dtrace-probe.c: Use C++ exception handling.
4934         * disasm-selftests.c: Use C++ exception handling.
4935         * darwin-nat.c: Use C++ exception handling.
4936         * cp-valprint.c: Use C++ exception handling.
4937         * cp-support.c: Use C++ exception handling.
4938         * cp-abi.c: Use C++ exception handling.
4939         * corelow.c: Use C++ exception handling.
4940         * completer.c: Use C++ exception handling.
4941         * compile/compile-object-run.c: Use C++ exception handling.
4942         * compile/compile-object-load.c: Use C++ exception handling.
4943         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4944         * compile/compile-c-symbols.c: Use C++ exception handling.
4945         * common/selftest.c: Use C++ exception handling.
4946         * common/new-op.c: Use C++ exception handling.
4947         * cli/cli-script.c: Use C++ exception handling.
4948         * cli/cli-interp.c: Use C++ exception handling.
4949         * cli/cli-cmds.c: Use C++ exception handling.
4950         * c-varobj.c: Use C++ exception handling.
4951         * btrace.c: Use C++ exception handling.
4952         * breakpoint.c: Use C++ exception handling.
4953         * break-catch-throw.c: Use C++ exception handling.
4954         * arch-utils.c: Use C++ exception handling.
4955         * amd64-tdep.c: Use C++ exception handling.
4956         * ada-valprint.c: Use C++ exception handling.
4957         * ada-typeprint.c: Use C++ exception handling.
4958         * ada-lang.c: Use C++ exception handling.
4959         * aarch64-tdep.c: Use C++ exception handling.
4960
4961 2019-04-08  Tom Tromey  <tom@tromey.com>
4962
4963         * xml-support.c (gdb_xml_parser::parse): Update.
4964         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4965         * value.c (show_convenience): Update.
4966         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4967         (test_parse_flags_qcs): Update.
4968         * thread.c (thr_try_catch_cmd): Update.
4969         * target.c (target_translate_tls_address): Update.
4970         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4971         (info_frame_command_core, frame_apply_command_count): Update.
4972         * rust-exp.y (rust_lex_exception_test): Update.
4973         * riscv-tdep.c (riscv_print_one_register_info): Update.
4974         * remote.c (remote_target::enable_btrace): Update.
4975         * record-btrace.c (record_btrace_enable_warn): Update.
4976         * python/py-utils.c (gdbpy_convert_exception): Update.
4977         * printcmd.c (do_one_display, print_variable_and_value): Update.
4978         * mi/mi-main.c (mi_print_exception): Update.
4979         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4980         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4981         * linux-nat.c (linux_nat_target::attach): Update.
4982         * linux-fork.c (class scoped_switch_fork_info): Update.
4983         * infrun.c (displaced_step_prepare): Update.
4984         * infcall.c (call_function_by_hand_dummy): Update.
4985         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4986         * gnu-v3-abi.c (print_one_vtable): Update.
4987         * frame.c (get_prev_frame_always): Update.
4988         * f-valprint.c (info_common_command_for_block): Update.
4989         * exec.c (try_open_exec_file): Update.
4990         * exceptions.c (print_exception, exception_print)
4991         (exception_fprintf, exception_print_same): Update.
4992         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4993         * dwarf-index-cache.c (index_cache::store)
4994         (index_cache::lookup_gdb_index): Update.
4995         * darwin-nat.c (maybe_cache_shell): Update.
4996         * cp-valprint.c (cp_print_value_fields): Update.
4997         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4998         (gcc_cplus_symbol_address): Update.
4999         * compile/compile-c-symbols.c (gcc_convert_symbol)
5000         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5001         * common/selftest.c: Update.
5002         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5003         a std::string.
5004         (exception_try_scope_entry, exception_try_scope_exit): Don't
5005         declare.
5006         (struct exception_try_scope): Remove.
5007         (TRY): Don't use exception_try_scope.
5008         (struct gdb_exception): Add constructor, operator=.
5009         <what>: New method.
5010         (struct gdb_exception_RETURN_MASK_ALL)
5011         (struct gdb_exception_RETURN_MASK_ERROR)
5012         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5013         (struct gdb_quit_bad_alloc): Update.
5014         * common/common-exceptions.c (exception_none): Change
5015         initializer.
5016         (struct catcher) <state, exception>: Initialize inline.
5017         <prev>: Remove member.
5018         (current_catcher): Remove.
5019         (catchers): New global.
5020         (exceptions_state_mc_init): Simplify.
5021         (catcher_pop): Remove.
5022         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5023         (try_scope_depth, exception_try_scope_entry)
5024         (exception_try_scope_exit): Remove.
5025         (throw_exception_sjlj): Update.
5026         (exception_messages, exception_messages_size): Remove.
5027         (throw_it): Simplify.
5028         (gdb_exception_sliced_copy): Remove.
5029         (throw_exception_cxx): Update.
5030         * cli/cli-script.c (script_from_file): Update.
5031         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5032         Update.
5033         * ada-valprint.c (ada_val_print): Update.
5034         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5035         (create_excep_cond_exprs): Update.
5036
5037 2019-04-08  Tom Tromey  <tom@tromey.com>
5038
5039         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5040         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5041         (TRY, CATCH, END_CATCH): Remove some definitions.
5042         * common/common-exceptions.c: Don't use GDB_XCPT.
5043         (catcher_list_size): Remove.
5044         (throw_exception, throw_it): Simplify.
5045
5046 2019-04-05  Tom Tromey  <tom@tromey.com>
5047
5048         Revert the header-sorting patch.
5049         * ft32-tdep.c: Revert.
5050         * frv-tdep.c: Revert.
5051         * frv-linux-tdep.c: Revert.
5052         * frame.c: Revert.
5053         * frame-unwind.c: Revert.
5054         * frame-base.c: Revert.
5055         * fork-child.c: Revert.
5056         * findvar.c: Revert.
5057         * findcmd.c: Revert.
5058         * filesystem.c: Revert.
5059         * filename-seen-cache.h: Revert.
5060         * filename-seen-cache.c: Revert.
5061         * fbsd-tdep.c: Revert.
5062         * fbsd-nat.h: Revert.
5063         * fbsd-nat.c: Revert.
5064         * f-valprint.c: Revert.
5065         * f-typeprint.c: Revert.
5066         * f-lang.c: Revert.
5067         * extension.h: Revert.
5068         * extension.c: Revert.
5069         * extension-priv.h: Revert.
5070         * expprint.c: Revert.
5071         * exec.h: Revert.
5072         * exec.c: Revert.
5073         * exceptions.c: Revert.
5074         * event-top.c: Revert.
5075         * event-loop.c: Revert.
5076         * eval.c: Revert.
5077         * elfread.c: Revert.
5078         * dwarf2read.h: Revert.
5079         * dwarf2read.c: Revert.
5080         * dwarf2loc.c: Revert.
5081         * dwarf2expr.h: Revert.
5082         * dwarf2expr.c: Revert.
5083         * dwarf2-frame.c: Revert.
5084         * dwarf2-frame-tailcall.c: Revert.
5085         * dwarf-index-write.h: Revert.
5086         * dwarf-index-write.c: Revert.
5087         * dwarf-index-common.c: Revert.
5088         * dwarf-index-cache.h: Revert.
5089         * dwarf-index-cache.c: Revert.
5090         * dummy-frame.c: Revert.
5091         * dtrace-probe.c: Revert.
5092         * disasm.h: Revert.
5093         * disasm.c: Revert.
5094         * disasm-selftests.c: Revert.
5095         * dictionary.c: Revert.
5096         * dicos-tdep.c: Revert.
5097         * demangle.c: Revert.
5098         * dcache.h: Revert.
5099         * dcache.c: Revert.
5100         * darwin-nat.h: Revert.
5101         * darwin-nat.c: Revert.
5102         * darwin-nat-info.c: Revert.
5103         * d-valprint.c: Revert.
5104         * d-namespace.c: Revert.
5105         * d-lang.c: Revert.
5106         * ctf.c: Revert.
5107         * csky-tdep.c: Revert.
5108         * csky-linux-tdep.c: Revert.
5109         * cris-tdep.c: Revert.
5110         * cris-linux-tdep.c: Revert.
5111         * cp-valprint.c: Revert.
5112         * cp-support.c: Revert.
5113         * cp-namespace.c: Revert.
5114         * cp-abi.c: Revert.
5115         * corelow.c: Revert.
5116         * corefile.c: Revert.
5117         * continuations.c: Revert.
5118         * completer.h: Revert.
5119         * completer.c: Revert.
5120         * complaints.c: Revert.
5121         * coffread.c: Revert.
5122         * coff-pe-read.c: Revert.
5123         * cli-out.h: Revert.
5124         * cli-out.c: Revert.
5125         * charset.c: Revert.
5126         * c-varobj.c: Revert.
5127         * c-valprint.c: Revert.
5128         * c-typeprint.c: Revert.
5129         * c-lang.c: Revert.
5130         * buildsym.c: Revert.
5131         * buildsym-legacy.c: Revert.
5132         * build-id.h: Revert.
5133         * build-id.c: Revert.
5134         * btrace.c: Revert.
5135         * bsd-uthread.c: Revert.
5136         * breakpoint.h: Revert.
5137         * breakpoint.c: Revert.
5138         * break-catch-throw.c: Revert.
5139         * break-catch-syscall.c: Revert.
5140         * break-catch-sig.c: Revert.
5141         * blockframe.c: Revert.
5142         * block.c: Revert.
5143         * bfin-tdep.c: Revert.
5144         * bfin-linux-tdep.c: Revert.
5145         * bfd-target.c: Revert.
5146         * bcache.c: Revert.
5147         * ax-general.c: Revert.
5148         * ax-gdb.h: Revert.
5149         * ax-gdb.c: Revert.
5150         * avr-tdep.c: Revert.
5151         * auxv.c: Revert.
5152         * auto-load.c: Revert.
5153         * arm-wince-tdep.c: Revert.
5154         * arm-tdep.c: Revert.
5155         * arm-symbian-tdep.c: Revert.
5156         * arm-pikeos-tdep.c: Revert.
5157         * arm-obsd-tdep.c: Revert.
5158         * arm-nbsd-tdep.c: Revert.
5159         * arm-nbsd-nat.c: Revert.
5160         * arm-linux-tdep.c: Revert.
5161         * arm-linux-nat.c: Revert.
5162         * arm-fbsd-tdep.c: Revert.
5163         * arm-fbsd-nat.c: Revert.
5164         * arm-bsd-tdep.c: Revert.
5165         * arch-utils.c: Revert.
5166         * arc-tdep.c: Revert.
5167         * arc-newlib-tdep.c: Revert.
5168         * annotate.h: Revert.
5169         * annotate.c: Revert.
5170         * amd64-windows-tdep.c: Revert.
5171         * amd64-windows-nat.c: Revert.
5172         * amd64-tdep.c: Revert.
5173         * amd64-sol2-tdep.c: Revert.
5174         * amd64-obsd-tdep.c: Revert.
5175         * amd64-obsd-nat.c: Revert.
5176         * amd64-nbsd-tdep.c: Revert.
5177         * amd64-nbsd-nat.c: Revert.
5178         * amd64-nat.c: Revert.
5179         * amd64-linux-tdep.c: Revert.
5180         * amd64-linux-nat.c: Revert.
5181         * amd64-fbsd-tdep.c: Revert.
5182         * amd64-fbsd-nat.c: Revert.
5183         * amd64-dicos-tdep.c: Revert.
5184         * amd64-darwin-tdep.c: Revert.
5185         * amd64-bsd-nat.c: Revert.
5186         * alpha-tdep.c: Revert.
5187         * alpha-obsd-tdep.c: Revert.
5188         * alpha-nbsd-tdep.c: Revert.
5189         * alpha-mdebug-tdep.c: Revert.
5190         * alpha-linux-tdep.c: Revert.
5191         * alpha-linux-nat.c: Revert.
5192         * alpha-bsd-tdep.c: Revert.
5193         * alpha-bsd-nat.c: Revert.
5194         * aix-thread.c: Revert.
5195         * agent.c: Revert.
5196         * addrmap.c: Revert.
5197         * ada-varobj.c: Revert.
5198         * ada-valprint.c: Revert.
5199         * ada-typeprint.c: Revert.
5200         * ada-tasks.c: Revert.
5201         * ada-lang.c: Revert.
5202         * aarch64-tdep.c: Revert.
5203         * aarch64-ravenscar-thread.c: Revert.
5204         * aarch64-newlib-tdep.c: Revert.
5205         * aarch64-linux-tdep.c: Revert.
5206         * aarch64-linux-nat.c: Revert.
5207         * aarch64-fbsd-tdep.c: Revert.
5208         * aarch64-fbsd-nat.c: Revert.
5209         * aarch32-linux-nat.c: Revert.
5210
5211 2019-04-05  Tom Tromey  <tom@tromey.com>
5212
5213         * ft32-tdep.c: Sort headers.
5214         * frv-tdep.c: Sort headers.
5215         * frv-linux-tdep.c: Sort headers.
5216         * frame.c: Sort headers.
5217         * frame-unwind.c: Sort headers.
5218         * frame-base.c: Sort headers.
5219         * fork-child.c: Sort headers.
5220         * findvar.c: Sort headers.
5221         * findcmd.c: Sort headers.
5222         * filesystem.c: Sort headers.
5223         * filename-seen-cache.h: Sort headers.
5224         * filename-seen-cache.c: Sort headers.
5225         * fbsd-tdep.c: Sort headers.
5226         * fbsd-nat.h: Sort headers.
5227         * fbsd-nat.c: Sort headers.
5228         * f-valprint.c: Sort headers.
5229         * f-typeprint.c: Sort headers.
5230         * f-lang.c: Sort headers.
5231         * extension.h: Sort headers.
5232         * extension.c: Sort headers.
5233         * extension-priv.h: Sort headers.
5234         * expprint.c: Sort headers.
5235         * exec.h: Sort headers.
5236         * exec.c: Sort headers.
5237         * exceptions.c: Sort headers.
5238         * event-top.c: Sort headers.
5239         * event-loop.c: Sort headers.
5240         * eval.c: Sort headers.
5241         * elfread.c: Sort headers.
5242         * dwarf2read.h: Sort headers.
5243         * dwarf2read.c: Sort headers.
5244         * dwarf2loc.c: Sort headers.
5245         * dwarf2expr.h: Sort headers.
5246         * dwarf2expr.c: Sort headers.
5247         * dwarf2-frame.c: Sort headers.
5248         * dwarf2-frame-tailcall.c: Sort headers.
5249         * dwarf-index-write.h: Sort headers.
5250         * dwarf-index-write.c: Sort headers.
5251         * dwarf-index-common.c: Sort headers.
5252         * dwarf-index-cache.h: Sort headers.
5253         * dwarf-index-cache.c: Sort headers.
5254         * dummy-frame.c: Sort headers.
5255         * dtrace-probe.c: Sort headers.
5256         * disasm.h: Sort headers.
5257         * disasm.c: Sort headers.
5258         * disasm-selftests.c: Sort headers.
5259         * dictionary.c: Sort headers.
5260         * dicos-tdep.c: Sort headers.
5261         * demangle.c: Sort headers.
5262         * dcache.h: Sort headers.
5263         * dcache.c: Sort headers.
5264         * darwin-nat.h: Sort headers.
5265         * darwin-nat.c: Sort headers.
5266         * darwin-nat-info.c: Sort headers.
5267         * d-valprint.c: Sort headers.
5268         * d-namespace.c: Sort headers.
5269         * d-lang.c: Sort headers.
5270         * ctf.c: Sort headers.
5271         * csky-tdep.c: Sort headers.
5272         * csky-linux-tdep.c: Sort headers.
5273         * cris-tdep.c: Sort headers.
5274         * cris-linux-tdep.c: Sort headers.
5275         * cp-valprint.c: Sort headers.
5276         * cp-support.c: Sort headers.
5277         * cp-namespace.c: Sort headers.
5278         * cp-abi.c: Sort headers.
5279         * corelow.c: Sort headers.
5280         * corefile.c: Sort headers.
5281         * continuations.c: Sort headers.
5282         * completer.h: Sort headers.
5283         * completer.c: Sort headers.
5284         * complaints.c: Sort headers.
5285         * coffread.c: Sort headers.
5286         * coff-pe-read.c: Sort headers.
5287         * cli-out.h: Sort headers.
5288         * cli-out.c: Sort headers.
5289         * charset.c: Sort headers.
5290         * c-varobj.c: Sort headers.
5291         * c-valprint.c: Sort headers.
5292         * c-typeprint.c: Sort headers.
5293         * c-lang.c: Sort headers.
5294         * buildsym.c: Sort headers.
5295         * buildsym-legacy.c: Sort headers.
5296         * build-id.h: Sort headers.
5297         * build-id.c: Sort headers.
5298         * btrace.c: Sort headers.
5299         * bsd-uthread.c: Sort headers.
5300         * breakpoint.h: Sort headers.
5301         * breakpoint.c: Sort headers.
5302         * break-catch-throw.c: Sort headers.
5303         * break-catch-syscall.c: Sort headers.
5304         * break-catch-sig.c: Sort headers.
5305         * blockframe.c: Sort headers.
5306         * block.c: Sort headers.
5307         * bfin-tdep.c: Sort headers.
5308         * bfin-linux-tdep.c: Sort headers.
5309         * bfd-target.c: Sort headers.
5310         * bcache.c: Sort headers.
5311         * ax-general.c: Sort headers.
5312         * ax-gdb.h: Sort headers.
5313         * ax-gdb.c: Sort headers.
5314         * avr-tdep.c: Sort headers.
5315         * auxv.c: Sort headers.
5316         * auto-load.c: Sort headers.
5317         * arm-wince-tdep.c: Sort headers.
5318         * arm-tdep.c: Sort headers.
5319         * arm-symbian-tdep.c: Sort headers.
5320         * arm-pikeos-tdep.c: Sort headers.
5321         * arm-obsd-tdep.c: Sort headers.
5322         * arm-nbsd-tdep.c: Sort headers.
5323         * arm-nbsd-nat.c: Sort headers.
5324         * arm-linux-tdep.c: Sort headers.
5325         * arm-linux-nat.c: Sort headers.
5326         * arm-fbsd-tdep.c: Sort headers.
5327         * arm-fbsd-nat.c: Sort headers.
5328         * arm-bsd-tdep.c: Sort headers.
5329         * arch-utils.c: Sort headers.
5330         * arc-tdep.c: Sort headers.
5331         * arc-newlib-tdep.c: Sort headers.
5332         * annotate.h: Sort headers.
5333         * annotate.c: Sort headers.
5334         * amd64-windows-tdep.c: Sort headers.
5335         * amd64-windows-nat.c: Sort headers.
5336         * amd64-tdep.c: Sort headers.
5337         * amd64-sol2-tdep.c: Sort headers.
5338         * amd64-obsd-tdep.c: Sort headers.
5339         * amd64-obsd-nat.c: Sort headers.
5340         * amd64-nbsd-tdep.c: Sort headers.
5341         * amd64-nbsd-nat.c: Sort headers.
5342         * amd64-nat.c: Sort headers.
5343         * amd64-linux-tdep.c: Sort headers.
5344         * amd64-linux-nat.c: Sort headers.
5345         * amd64-fbsd-tdep.c: Sort headers.
5346         * amd64-fbsd-nat.c: Sort headers.
5347         * amd64-dicos-tdep.c: Sort headers.
5348         * amd64-darwin-tdep.c: Sort headers.
5349         * amd64-bsd-nat.c: Sort headers.
5350         * alpha-tdep.c: Sort headers.
5351         * alpha-obsd-tdep.c: Sort headers.
5352         * alpha-nbsd-tdep.c: Sort headers.
5353         * alpha-mdebug-tdep.c: Sort headers.
5354         * alpha-linux-tdep.c: Sort headers.
5355         * alpha-linux-nat.c: Sort headers.
5356         * alpha-bsd-tdep.c: Sort headers.
5357         * alpha-bsd-nat.c: Sort headers.
5358         * aix-thread.c: Sort headers.
5359         * agent.c: Sort headers.
5360         * addrmap.c: Sort headers.
5361         * ada-varobj.c: Sort headers.
5362         * ada-valprint.c: Sort headers.
5363         * ada-typeprint.c: Sort headers.
5364         * ada-tasks.c: Sort headers.
5365         * ada-lang.c: Sort headers.
5366         * aarch64-tdep.c: Sort headers.
5367         * aarch64-ravenscar-thread.c: Sort headers.
5368         * aarch64-newlib-tdep.c: Sort headers.
5369         * aarch64-linux-tdep.c: Sort headers.
5370         * aarch64-linux-nat.c: Sort headers.
5371         * aarch64-fbsd-tdep.c: Sort headers.
5372         * aarch64-fbsd-nat.c: Sort headers.
5373         * aarch32-linux-nat.c: Sort headers.
5374
5375 2019-04-04  Tom Tromey  <tom@tromey.com>
5376
5377         * varobj.c (varobj_create): Update.
5378         * rust-exp.y (struct rust_parser) <update_innermost_block,
5379         lookup_symbol>: New methods.
5380         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5381         Rename.
5382         (rust_parser::rust_lookup_type)
5383         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5384         * printcmd.c (display_command, do_one_display): Update.
5385         * parser-defs.h (struct parser_state) <parser_state>: Add
5386         "tracker" parameter.
5387         (block_tracker): New member.
5388         (class innermost_block_tracker) <innermost_block_tracker>: Add
5389         "types" parameter.
5390         <reset>: Remove method.
5391         (innermost_block): Don't declare.
5392         (null_post_parser): Update.
5393         * parse.c (innermost_block): Remove global.
5394         (write_dollar_variable): Update.
5395         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5396         Remove "tracker_types" parameter.
5397         (parse_expression): Add "tracker" parameter.
5398         (parse_expression_for_completion): Update.
5399         (null_post_parser): Add "tracker" parameter.
5400         * p-exp.y: Update rules.
5401         * m2-exp.y: Update rules.
5402         * language.h (struct language_defn) <la_post_parser>: Add
5403         "tracker" parameter.
5404         * go-exp.y: Update rules.
5405         * f-exp.y: Update rules.
5406         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5407         parameter.
5408         * d-exp.y: Update rules.
5409         * c-exp.y: Update rules.
5410         * breakpoint.c (set_breakpoint_condition): Create an
5411         innermost_block_tracker.
5412         (watch_command_1): Likewise.
5413         * ada-lang.c (resolve): Add "tracker" parameter.
5414         (resolve_subexp): Likewise.
5415         * ada-exp.y (write_var_from_sym): Update.
5416
5417 2019-04-04  Tom Tromey  <tom@tromey.com>
5418
5419         * type-stack.h: New file.
5420         * type-stack.c: New file.
5421         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5422         type-stack.h.
5423         (insert_into_type_stack, insert_type, push_type, push_type_int)
5424         (insert_type_address_space, pop_type, pop_type_int)
5425         (pop_typelist, pop_type_stack, append_type_stack)
5426         (push_type_stack, get_type_stack, push_typelist)
5427         (follow_type_instance_flags, follow_types): Don't declare.
5428         * parse.c (type_stack): Remove global.
5429         (parse_exp_in_context): Update.
5430         (insert_into_type_stack, insert_type, push_type, push_type_int)
5431         (insert_type_address_space, pop_type, pop_type_int)
5432         (pop_typelist, pop_type_stack, append_type_stack)
5433         (push_type_stack, get_type_stack, push_typelist)
5434         (follow_type_instance_flags, follow_types): Remove (moved to
5435         type-stack.c).
5436         * f-exp.y (type_stack): New global.
5437         Update rules.
5438         (push_kind_type, f_parse): Update.
5439         * d-exp.y (type_stack): New global.
5440         Update rules.
5441         (d_parse): Update.
5442         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5443         Update rules.
5444         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5445         (HFILES_NO_SRCDIR): Add type-stack.h.
5446
5447 2019-04-04  Tom Tromey  <tom@tromey.com>
5448
5449         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5450         (rust_parser::convert_ast_to_expression, rust_parse)
5451         (rust_lex_test_completion, rust_lex_tests): Update.
5452         * parser-defs.h (struct expr_completion_state): New.
5453         (struct parser_state) <parser_state>: Add completion parameter.
5454         <mark_struct_expression, mark_completion_tag>: New methods.
5455         <parse_completion, m_completion_state>: New members.
5456         (prefixify_expression, null_post_parser): Update.
5457         (mark_struct_expression, mark_completion_tag): Don't declare.
5458         * parse.c (parse_completion, expout_last_struct)
5459         (expout_tag_completion_type, expout_completion_name): Remove
5460         globals.
5461         (parser_state::mark_struct_expression)
5462         (parser_state::mark_completion_tag): Now methods.
5463         (prefixify_expression): Add last_struct parameter.
5464         (prefixify_subexp): Likewise.
5465         (parse_exp_1): Update.
5466         (parse_exp_in_context): Add cstate parameter.  Update.
5467         (parse_expression_for_completion): Create an
5468         expr_completion_state.
5469         (null_post_parser): Add "completion" parameter.
5470         * p-exp.y: Update rules.
5471         (yylex): Update.
5472         * language.h (struct language_defn) <la_post_parser>: Add
5473         "completing" parameter.
5474         * go-exp.y: Update rules.
5475         (lex_one_token): Update.
5476         * expression.h (parse_completion): Don't declare.
5477         * d-exp.y: Update rules.
5478         (lex_one_token): Update rules.
5479         * c-exp.y: Update rules.
5480         (lex_one_token): Update.
5481         * ada-lang.c (resolve): Add "parse_completion" parameter.
5482         (resolve_subexp): Likewise.
5483         (ada_resolve_function): Likewise.
5484
5485 2019-04-04  Tom Tromey  <tom@tromey.com>
5486
5487         * parser-defs.h (struct parser_state) <start_arglist,
5488         end_arglist>: New methods.
5489         <arglist_len, m_funcall_chain>: New members.
5490         (arglist_len, start_arglist, end_arglist): Don't declare.
5491         * parse.c (arglist_len, funcall_chain): Remove global.
5492         (start_arglist, end_arglist): Remove functions.
5493         (parse_exp_in_context): Update.
5494         * p-exp.y: Update rules.
5495         * m2-exp.y: Update rules.
5496         * go-exp.y: Update rules.
5497         * f-exp.y: Update rules.
5498         * d-exp.y: Update rules.
5499         * c-exp.y: Update rules.
5500
5501 2019-04-04  Tom Tromey  <tom@tromey.com>
5502
5503         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5504         lex_operator, push_back>: New methods.
5505         Update all rules.
5506         (rust_parser::lex_hex, lex_escape): Rename and update.
5507         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5508         (rust_parser::lex_operator): Rename and update.
5509         (rust_parser::lex_number, rustyylex, rustyyerror)
5510         (rust_lex_test_init, rust_lex_test_sequence)
5511         (rust_lex_test_push_back, rust_lex_tests): Update.
5512         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5513         parameter.
5514         <lexptr, prev_lexptr>: New members.
5515         (lexptr, prev_lexptr): Don't declare.
5516         * parse.c (lexptr, prev_lexptr): Remove globals.
5517         (parse_exp_in_context): Update.
5518         * p-exp.y (yylex, yyerror): Update.
5519         * m2-exp.y (parse_number, yylex, yyerror): Update.
5520         * go-exp.y (lex_one_token, yyerror): Update.
5521         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5522         * d-exp.y (lex_one_token, yyerror): Update.
5523         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5524         (lex_one_token, yyerror): Update.
5525         * ada-lex.l (YY_INPUT): Update.
5526         (rewind_to_char): Update.
5527         * ada-exp.y (yyerror): Update.
5528
5529 2019-04-04  Tom Tromey  <tom@tromey.com>
5530
5531         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5532         * parser-defs.h (struct parser_state) <parser_state>: Add new
5533         parameter.
5534         <comma_terminates>: New member.
5535         (comma_terminates): Don't declare global.
5536         * parse.c (comma_terminates): Remove global.
5537         (parse_exp_in_context): Update.
5538         * p-exp.y (yylex): Update.
5539         * m2-exp.y (yylex): Update.
5540         * go-exp.y (lex_one_token): Update.
5541         * f-exp.y (yylex): Update.
5542         * d-exp.y (lex_one_token): Update.
5543         * c-exp.y (lex_one_token): Update.
5544         * ada-lex.l: Update.
5545
5546 2019-04-04  Tom Tromey  <tom@tromey.com>
5547
5548         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5549         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5550         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5551         * parser-defs.h (paren_depth): Don't declare.
5552         * parse.c (paren_depth): Remove global.
5553         (parse_exp_in_context): Update.
5554         * p-exp.y (paren_depth): New global.
5555         (pascal_parse): Initialize it.
5556         * m2-exp.y (paren_depth): New global.
5557         (m2_parse): Initialize it.
5558         * go-exp.y (paren_depth): New global.
5559         (go_parse): Initialize it.
5560         * f-exp.y (paren_depth): New global.
5561         (f_parse): Initialize it.
5562         * d-exp.y (paren_depth): New global.
5563         (d_parse): Initialize it.
5564         * c-exp.y (paren_depth): New global.
5565         (c_parse): Initialize it.
5566         * ada-lex.l (paren_depth): New global.
5567         (lexer_init): Initialize it.
5568
5569 2019-04-04  Tom Tromey  <tom@tromey.com>
5570
5571         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5572         (rust_parser::convert_ast_to_type)
5573         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5574         * parser-defs.h (struct parser_state) <parser_state>: Add
5575         parameters.  Initialize new members.
5576         <expression_context_block, expression_context_pc>: New members.
5577         * parse.c (expression_context_block, expression_context_pc):
5578         Remove globals.
5579         (parse_exp_in_context): Update.
5580         * p-exp.y: Update all rules.
5581         (yylex): Update.
5582         * m2-exp.y: Update all rules.
5583         (yylex): Update.
5584         * go-exp.y (yylex): Update.
5585         * f-exp.y (yylex): Update.
5586         * d-exp.y: Update all rules.
5587         (yylex): Update.
5588         * c-exp.y: Update all rules.
5589         (lex_one_token, classify_name, yylex, c_parse): Update.
5590         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5591
5592 2019-04-04  Tom Tromey  <tom@tromey.com>
5593
5594         * gdbarch.h, gdbarch.c: Rebuild.
5595         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5596         * stap-probe.h:
5597         (struct stap_parse_info): Replace "parser_state" with
5598         "expr_builder".
5599         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5600         (parser_state): New class.
5601         * parse.c (expr_builder): Rename.
5602         (expr_builder::release): Rename.
5603         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5604         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5605         (write_exp_elt_longcst, write_exp_elt_floatcst)
5606         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5607         (write_exp_string_vector, write_exp_bitstring)
5608         (write_exp_msymbol, mark_struct_expression)
5609         (write_dollar_variable)
5610         (insert_type_address_space, increase_expout_size): Replace
5611         "parser_state" with "expr_builder".
5612         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5613         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5614         "parser_state" with "expr_builder".
5615
5616 2019-04-04  Tom Tromey  <tom@tromey.com>
5617
5618         * rust-exp.y: Replace "parse_language" with method call.
5619         * p-exp.y:
5620         (yylex): Replace "parse_language" with method call.
5621         * m2-exp.y:
5622         (yylex): Replace "parse_language" with method call.
5623         * go-exp.y (classify_name): Replace "parse_language" with method
5624         call.
5625         * f-exp.y (yylex): Replace "parse_language" with method call.
5626         * d-exp.y (lex_one_token): Replace "parse_language" with method
5627         call.
5628         * c-exp.y:
5629         (lex_one_token, classify_name, yylex): Replace "parse_language"
5630         with method call.
5631         * ada-exp.y (find_primitive_type, type_char)
5632         (type_system_address): Replace "parse_language" with method call.
5633
5634 2019-04-04  Tom Tromey  <tom@tromey.com>
5635
5636         * rust-exp.y: Replace "parse_gdbarch" with method call.
5637         * parse.c (write_dollar_variable, insert_type_address_space):
5638         Replace "parse_gdbarch" with method call.
5639         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5640         call.
5641         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5642         call.
5643         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5644         "parse_gdbarch" with method call.
5645         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5646         with method call.
5647         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5648         "parse_gdbarch" with method call.
5649         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5650         "parse_gdbarch" with method call.
5651         * c-exp.y (parse_type, parse_number, classify_name): Replace
5652         "parse_gdbarch" with method call.
5653         * ada-lex.l: Replace "parse_gdbarch" with method call.
5654         * ada-exp.y (parse_type, find_primitive_type, type_char)
5655         (type_system_address): Replace "parse_gdbarch" with method call.
5656
5657 2019-04-04  Tom Tromey  <tom@tromey.com>
5658
5659         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5660         * stap-probe.c (stap_parse_argument): Update.
5661         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5662         initial_size parameter.
5663         * rust-exp.y (rust_lex_tests): Update.
5664         * parse.c (parser_state): Update.
5665         (parse_exp_in_context): Update.
5666         * parser-defs.h (struct parser_state) <parser_state>: Remove
5667         "initial_size" parameter.
5668
5669 2019-04-04  Tom Tromey  <tom@tromey.com>
5670
5671         * parser-defs.h (increase_expout_size): Don't declare.
5672         * parse.c (increase_expout_size): Now static.
5673
5674 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5675
5676         * gnu-nat.c (gnu_nat_target::wait): Fix
5677         target_waitstatus_to_string call.
5678
5679 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5680
5681         * eval.c (evaluate_subexp_standard): Handle internal functions
5682         during Fortran function call handling.
5683
5684 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * NEWS: Mention new internal functions.
5687         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5688         (read_base_type): Use dwarf2_init_complex_target_type.
5689         * value.c (creal_internal_fn): New function.
5690         (cimag_internal_fn): New function.
5691         (_initialize_values): Register new internal functions.
5692
5693 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5694
5695         * infrun.c (stop_all_threads): If debug_infrun, always
5696         trace the wait status after wait_one, using
5697         target_waitstatus_to_string and target_pid_to_str.
5698         (handle_inferior_event): Replace various trace of
5699         wait status kind by a single trace.
5700         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5701         wait status kind image by target_waitstatus_to_string.
5702         * target/waitstatus.c (target_waitstatus_to_string): Fix
5703         obsolete comment.
5704
5705 2019-04-01  Tom Tromey  <tromey@adacore.com>
5706
5707         PR symtab/23331:
5708         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5709
5710 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5711             Pedro Alves  <palves@redhat.com>
5712
5713         * top.c (quit_force): Call 'finalize_values'.
5714         * value.c (finalize_values): New function.
5715         * value.h (finalize_values): Declare.
5716
5717 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5718
5719         * NEWS: Announce $_gdb_major and $_gdb_minor.
5720
5721         * top.c (init_gdb_version_vars): New function.
5722         (gdb_init): Call init_gdb_version_vars.
5723
5724 2019-03-29  Tom Tromey  <tromey@adacore.com>
5725
5726         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5727         help text.  Remove dead code.
5728
5729 2019-03-29  Keith Seitz  <keiths@redhat.com>
5730
5731         From Siddhesh Poyarekar:
5732         * f-lang.h (f77_get_upperbound): Return LONGEST.
5733         (f77_get_lowerbound): Likewise.
5734         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5735         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5736         print them.
5737         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5738         plongest to format print it.
5739         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5740         (f77_get_upperbound): Likewise.
5741         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5742         LOWER_BOUND to LONGEST.
5743         (f77_create_arrayprint_offset_tbl): Likewise.
5744
5745 2019-03-29  Keith Seitz  <keiths@redhat.com>
5746
5747         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5748         %s/pulongest for TYPE_LENGTH instead of %d in format
5749         strings.
5750         * ada-typerint.c (ada_print_type): Likewise.
5751         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5752         * compile/compile-c-support.c (generate_register_struct): Likewise.
5753         * gdbtypes.c (recursive_dump_type): Likewise.
5754         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5755         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5756         instead of %d in format strings.
5757         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5758         to std::min to ULONGEST.
5759         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5760         instead of %d in format strings.
5761         * tracepoint.c (info_scope_command): Likewise.
5762         * typeprint.c (print_offset_data::update)
5763         (print_offset_data::finish): Likewise.
5764         * xtensa-tdep.c (xtensa_store_return_value)
5765         (xtensa_push_dummy_call): Likewise.
5766
5767 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5768
5769         * windows-nat.c (display_selector): Fixed format specifications
5770         for 64-bit Cygwin.
5771
5772 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5773
5774         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5775
5776 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5777
5778         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5779         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5780         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5781         (nios2_linux_init_abi): Install it.
5782
5783 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5784
5785         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5786
5787 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5788
5789         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5790
5791 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5792             Tom Tromey  <tromey@adacore.com>
5793
5794         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5795
5796 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5797
5798         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5799         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5800         method to compute the bounds of range types. Also print "[evaluated]"
5801         if the bounds' values come from a dynamic evaluation.
5802
5803 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5806         whitespace when pretty printing is on.
5807
5808 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5809
5810         * ppc-linux-nat.c: Add include.
5811
5812 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5813
5814         * NEWS: Mention AArch64 Pointer Authentication.
5815
5816 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5817
5818         * arm-linux-nat.c: Add include.
5819
5820 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5821
5822         * source-cache.c (source_cache::get_source_lines): Re-read
5823         fullname after calling open_source_file.
5824
5825 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5826
5827         * NEWS: Mention TLS support for FreeBSD.
5828
5829 2019-03-25  Tom Tromey  <tromey@adacore.com>
5830
5831         * minsyms.c (BUNCH_SIZE): Update comment.
5832         (~minimal_symbol_reader): Remove old comment.
5833         (compact_minimal_symbols): Update comment.
5834         (minimal_symbol_reader::install): Remove old comment.  Update
5835         other comments.
5836
5837 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5838
5839         * s390-linux-nat.c: Add include.
5840
5841 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5842
5843         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5844         Call linux_get_hwcap.
5845         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5846         Likewise.
5847         (aarch64_linux_get_hwcap): Remove function.
5848         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5849         declaration.
5850         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5851         linux_get_hwcap.
5852         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5853         * linux-tdep.c (linux_get_hwcap): Add function.
5854         (linux_get_hwcap2): Likewise.
5855         * linux-tdep.h (linux_get_hwcap): Add declaration.
5856         (linux_get_hwcap2): Likewise.
5857         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5858         (ppc_linux_get_hwcap2): Likewise.
5859         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5860         linux_get_hwcap.
5861         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5862         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5863         (ppc_linux_nat_target::read_description): Likewise.
5864         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5865         * s390-linux-nat.c: Likewise.
5866         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5867
5868 2019-03-24  Tom Tromey  <tom@tromey.com>
5869
5870         * ada-lang.c (standard_lookup): Simplify initialization.
5871         (ada_lookup_symbol_nonlocal): Simplify return.
5872         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5873         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5874         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5875         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5876         initialization.
5877         * solib.c (solib_global_lookup): Simplify.
5878         * symtab.c (null_block_symbol): Remove.
5879         (symbol_cache_lookup): Simplify returns.
5880         (lookup_language_this): Simplify returns.
5881         (lookup_symbol_aux): Simplify return.
5882         (lookup_local_symbol): Simplify returns.
5883         (lookup_global_symbol_from_objfile): Simplify return.
5884         (lookup_symbol_in_objfile_symtabs)
5885         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5886         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5887         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5888         * cp-namespace.c (cp_lookup_bare_symbol)
5889         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5890         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5891         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5892         (cp_lookup_symbol_via_imports): Simplify initialization.
5893         (find_symbol_in_baseclass): Likewise.
5894         * symtab.h (null_block_symbol): Remove.
5895         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5896         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5897         (d_lookup_symbol_module): Likewise.
5898         (find_symbol_in_baseclass): Simplify initialization.
5899
5900 2019-03-24  Tom Tromey  <tom@tromey.com>
5901
5902         * expression.h: Don't include symtab.h.
5903         (struct block): Forward declare.
5904
5905 2019-03-24  Tom Tromey  <tom@tromey.com>
5906
5907         * c-exp.y (typebase): Remove casts.
5908         * gdbtypes.c (lookup_unsigned_typename, )
5909         (lookup_signed_typename): Remove cast.
5910         * eval.c (parse_to_comma_and_eval): Remove cast.
5911         * parse.c (write_dollar_variable): Remove cast.
5912         * block.h (struct block) <superblock>: Now const.
5913         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5914         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5915         (map_block): Make "block" const.
5916         * symfile.h (struct quick_symbol_functions)
5917         <map_matching_symbols>: Constify block argument to "callback".
5918         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5919         const.
5920         (find_pc_sect_compunit_symtab): Make "b" const.
5921         (find_symbol_at_address): Likewise.
5922         (search_symbols): Likewise.
5923         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5924         (dw2_debug_names_lookup_symbol): Likewise.
5925         (dw2_map_matching_symbols): Update.
5926         * p-valprint.c (pascal_val_print): Remove "block".
5927         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5928         (aux_add_nonlocal_symbols): Make "block" const.
5929         (resolve_subexp): Remove cast.
5930         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5931         const.
5932         (iterate_over_file_blocks): Likewise.
5933         * f-exp.y (%union) <bval>: Remove.
5934         * coffread.c (patch_opaque_types): Make "b" const.
5935         * spu-tdep.c (spu_catch_start): Make "block" const.
5936         * c-valprint.c (print_unpacked_pointer): Remove "block".
5937         * symmisc.c (dump_symtab_1): Make "b" const.
5938         (block_depth): Make "block" const.
5939         * d-exp.y (%union) <bval>: Remove.
5940         * cp-support.h (cp_lookup_rtti_type): Update.
5941         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5942         * psymtab.c (psym_lookup_symbol): Make "block" const.
5943         (maintenance_check_psymtabs): Make "b" const.
5944         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5945         (enumerate_locals, enumerate_args): Update.
5946         * python/py-symtab.c (stpy_global_block): Make "block" const.
5947         (stpy_static_block): Likewise.
5948         * inline-frame.c (block_starting_point_at): Make "new_block"
5949         const.
5950         * block.c (find_block_in_blockvector): Make return type const.
5951         (blockvector_for_pc_sect): Make "b" const.
5952         (find_block_in_blockvector): Make "b" const.
5953
5954 2019-03-23  Tom Tromey  <tom@tromey.com>
5955
5956         * varobj.c (varobj_create): Update.
5957         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5958         * printcmd.c (display_command, do_one_display): Don't reset
5959         innermost_block.
5960         * parser-defs.h (enum innermost_block_tracker_type): Move to
5961         expression.h.
5962         (innermost_block): Update comment.
5963         * parse.c (parse_exp_1): Add tracker_types parameter.
5964         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5965         tracker_types parameter.  Reset innermost_block.
5966         (parse_exp_in_context): Remove.
5967         (parse_expression_for_completion): Update.
5968         * objfiles.c (~objfile): Don't reset expression_context_block or
5969         innermost_block.
5970         * expression.h (enum innermost_block_tracker_type): Move from
5971         parser-defs.h.
5972         (parse_exp_1): Add tracker_types parameter.
5973         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5974         reset innermost_block.
5975
5976 2019-03-23  Tom Tromey  <tom@tromey.com>
5977
5978         * objfiles.h: Include bcache.h.
5979
5980 2019-03-23  Tom Tromey  <tom@tromey.com>
5981
5982         * linespec.c (get_current_search_block): Use
5983         scoped_restore_current_language.
5984         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5985
5986 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5987             Jiong Wang  <jiong.wang@arm.com>
5988
5989         * aarch64-linux-tdep.c
5990         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5991         section.
5992         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5993
5994 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5995             Jiong Wang  <jiong.wang@arm.com>
5996
5997         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5998         instructions.
5999         (aarch64_analyze_prologue_test): Add PACIASP test.
6000         (aarch64_prologue_prev_register): Unmask PC value.
6001
6002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6003             Jiong Wang  <jiong.wang@arm.com>
6004
6005         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6006         (aarch64_dwarf2_prev_register): Unmask PC value.
6007         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6008         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6009         DW_CFA_AARCH64_negate_ra_state.
6010         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6011
6012 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6013             Jiong Wang  <jiong.wang@arm.com>
6014
6015         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6016         registers.
6017         (aarch64_pseudo_register_name): Likewise.
6018         (aarch64_pseudo_register_type): Likewise.
6019         (aarch64_pseudo_register_reggroup_p): Likewise.
6020         (aarch64_gdbarch_init): Add pauth registers.
6021         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6022         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6023         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6024         (struct gdbarch_tdep): Add regnum for ra_state.
6025
6026 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6027             Jiong Wang  <jiong.wang@arm.com>
6028
6029         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6030
6031 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6032             Jiong Wang  <jiong.wang@arm.com>
6033
6034         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6035         function.
6036         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6037         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6038         (aarch64_gdbarch_init): Add puth registers.
6039         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6040         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6041         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6042
6043 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6044             Jiong Wang  <jiong.wang@arm.com>
6045
6046         * aarch64-linux-nat.c
6047         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6048         * aarch64-linux-tdep.c
6049         (aarch64_linux_core_read_description): Likewise.
6050         (aarch64_linux_get_hwcap): New function.
6051         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6052         (aarch64_linux_get_hwcap): New declaration.
6053
6054 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6055             Jiong Wang  <jiong.wang@arm.com>
6056
6057         * aarch64-linux-nat.c
6058         (aarch64_linux_nat_target::read_description): Add pauth param.
6059         * aarch64-linux-tdep.c
6060         (aarch64_linux_core_read_description): Likewise.
6061         * aarch64-tdep.c (struct target_desc): Add in pauth.
6062         (aarch64_read_description): Add pauth param.
6063         (aarch64_gdbarch_init): Likewise.
6064         * aarch64-tdep.h (aarch64_read_description): Likewise.
6065         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6066         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6067         * features/Makefile: Add new files.
6068         * features/aarch64-pauth.c: New file.
6069         * features/aarch64-pauth.xml: New file.
6070
6071 2019-03-20  Tom Tromey  <tromey@adacore.com>
6072
6073         * infrun.c (handle_inferior_event): Rename from
6074         handle_inferior_event_1.  Create a scoped_value_mark.
6075         (handle_inferior_event): Remove.
6076
6077 2019-03-19  Tom Tromey  <tromey@adacore.com>
6078
6079         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6080         * infrun.h (print_stop_event): Add "displays" parameter.
6081         * infrun.c (print_stop_event): Add "displays" parameter.
6082
6083 2019-03-19  Pedro Alves  <palves@redhat.com>
6084
6085         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6086         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6087         to -1.  Fix TABs vs spaces.
6088         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6089         * tui/tui-out.h (tui_ui_out) Add intro comments.
6090         <m_line, m_start_of_line>: In-class initialize, and add describing
6091         comment.
6092
6093 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6094
6095         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6096         variable names.
6097         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6098
6099 2019-03-18  Pedro Alves  <palves@redhat.com>
6100             Eli Zaretskii <eliz@gnu.org>
6101
6102         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6103         m_line and m_start_of_line.
6104
6105 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6106
6107         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6108         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6109         it returns a newline.  This fixes a regression in TU mode, whereby
6110         the next line is output on the same screen line as the user input.
6111
6112 2019-03-18  Tom Tromey  <tromey@adacore.com>
6113
6114         * minsyms.c (minimal_symbol_reader::install): Remove call to
6115         obstack_blank.
6116
6117 2019-03-18  Pedro Alves  <palves@redhat.com>
6118
6119         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6120         New globals.
6121         (apply_style): New, factored out from ...
6122         (apply_ansi_escape): ... this.  Handle reverse video mode.
6123         (tui_set_reverse_mode): New function.
6124         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6125         * tui/tui-winsource.c (tui_show_source_line): Use
6126         tui_set_reverse_mode instead of setting A_STANDOUT.
6127         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6128         New setter methods.
6129
6130 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6131
6132         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6133         Handle tabs.
6134
6135 2019-03-18  Tom Tromey  <tromey@adacore.com>
6136
6137         * ada-lang.c (empty_array): Add "high" parameter.
6138         (ada_evaluate_subexp): Update.
6139
6140 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6141
6142         * unittests/string_view-selftests.c: Define
6143         _initialize_string_view_selftests unconditionally.
6144
6145 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6146
6147         PR gdb/24350
6148         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6149
6150 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6151
6152         PR gdb/24351
6153         * windows-nat.c (display_selector): Fix format specifiers.
6154
6155 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6156
6157         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6158         tui_refill_source_window instead of tui_refresh_win, to update the
6159         current execution line.  This fixes redisplay of the current line
6160         when stepping through the code with "next" or "step".
6161
6162 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6163
6164         * source-cache.c (source_cache::get_source_lines): Call
6165         find_source_lines to initialize s->nlines.  This fixes vertical
6166         scrolling of TUI source window when the DOWN arrow is pressed.
6167
6168 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6169
6170         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6171         linux-thread-db.c (_initialize_thread_db): Likewise.
6172
6173 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6174
6175         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6176         wclrtoeol in tui_show_source_line".  This reverts changes made in
6177         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6178
6179 2019-03-15  Tom Tromey  <tom@tromey.com>
6180
6181         * symtab.h (struct minimal_symbol): Derive from
6182         general_symbol_info.
6183         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6184         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6185         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6186         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6187         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6188         (MSYMBOL_SEARCH_NAME): Update.
6189         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6190         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6191         * minsyms.c (minimal_symbol_reader::record_full): Update.
6192
6193 2019-03-15  Tom Tromey  <tom@tromey.com>
6194
6195         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6196
6197 2019-03-15  Tom Tromey  <tom@tromey.com>
6198
6199         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6200         unique_xmalloc_ptr.
6201         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6202         Update.
6203         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6204         (build_minimal_symbol_hash_tables)
6205         (minimal_symbol_reader::install): Update.
6206
6207 2019-03-15  Tom Tromey  <tom@tromey.com>
6208
6209         * symtab.c (create_demangled_names_hash): Update.
6210         (symbol_set_names): Update.
6211         * objfiles.h (struct objfile_per_bfd_storage)
6212         <demangled_names_hash>: Now an htab_up.
6213         * objfiles.c (objfile_per_bfd_storage): Simplify.
6214
6215 2019-03-15  Tom Tromey  <tom@tromey.com>
6216
6217         * objfiles.h (struct objfile_per_bfd_storage): Declare
6218         destructor.
6219         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6220         New.
6221         (get_objfile_bfd_data): Use new.  Don't initialize
6222         language_of_main.
6223         (free_objfile_per_bfd_storage): Remove.
6224         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6225
6226 2019-03-15  Tom Tromey  <tom@tromey.com>
6227
6228         * symfile.c (reread_symbols): Update.
6229         * objfiles.c (objfile::objfile): Update.
6230         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6231         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6232         comment.
6233         (minimal_symbol_reader::install): Update.
6234         (terminate_minimal_symbol_table): Remove.
6235         * jit.c (jit_object_close_impl): Update.
6236
6237 2019-03-15  Tom Tromey  <tom@tromey.com>
6238
6239         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6240         initializations.
6241
6242 2019-03-15  Tom Tromey  <tom@tromey.com>
6243
6244         * objfiles.h (struct objfile_per_bfd_storage)
6245         <demangled_hash_languages>: Now a bitset.
6246         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6247         (lookup_minimal_symbol): Update.
6248
6249 2019-03-15  Tom Tromey  <tom@tromey.com>
6250
6251         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6252         Don't return the symbol.
6253         * coffread.c (record_minimal_symbol): Use record_full.
6254
6255 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6256
6257         The MS-Windows port of ncurses fails to switch to a color pair if
6258         one or both of the colors are the implicit default colors.  This
6259         change records the default colors when TUI is initialized, and
6260         then specifies them explicitly when a color pair uses the default
6261         colors.  This allows color styling in TUI mode on MS-Windows.
6262
6263         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6264         ncurses_norm_attr.
6265         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6266         colors in ncurses_norm_attr.
6267         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6268         "none", replace it with the default color recorded in
6269         ncurses_norm_attr.
6270
6271 2019-03-14  Tom Tromey  <tromey@adacore.com>
6272
6273         * source-cache.h (class source_cache) <get_source_lines>: Return
6274         std::string.
6275         * source-cache.c (source_cache::extract_lines): Handle case where
6276         first_pos==npos.  Return std::string.
6277         (source_cache::get_source_lines): Update.
6278
6279 2019-03-14  Tom Tromey  <tromey@adacore.com>
6280
6281         * NEWS: Add item for "style sources" commands.
6282         * source-cache.c (source_cache::get_source_lines): Check
6283         source_styling.
6284         * cli/cli-style.c (source_styling): New global.
6285         (_initialize_cli_style): Add "style sources" commands.
6286         (show_style_sources): New function.
6287         * cli/cli-style.h (source_styling): Declare.
6288
6289 2019-03-14  Pedro Alves  <palves@redhat.com>
6290             Tom Tromey  <tromey@adacore.com>
6291
6292         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6293         * tui/tui-winsource.c (tui_refill_source_window): New function,
6294         from...
6295         (tui_horizontal_source_scroll): ... here.  Move some logic.
6296         * cli/cli-style.c (set_style_enabled): Notify new observable.
6297         * tui/tui-hooks.c (tui_redisplay_source): New function.
6298         (tui_attach_detach_observers): Attach or detach
6299         tui_redisplay_source.
6300         * observable.h (source_styling_changed): New observable.
6301         * observable.c: Define source_styling_changed observable.
6302
6303 2019-03-13  Tom Tromey  <tromey@adacore.com>
6304
6305         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6306         (i386_gnu_nat_target::store_registers): Update.
6307         * target-debug.h (target_debug_print_std_string): New macro.
6308         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6309         * windows-tdep.c (display_one_tib): Update.
6310         * tui/tui-stack.c (tui_make_status_line): Update.
6311         * top.c (print_inferior_quit_action): Update.
6312         * thread.c (thr_try_catch_cmd): Update.
6313         (add_thread_with_info): Update.
6314         (thread_target_id_str): Update.
6315         (thr_try_catch_cmd): Update.
6316         (thread_command): Update.
6317         (thread_find_command): Update.
6318         * record-btrace.c (record_btrace_target::info_record)
6319         (record_btrace_resume_thread, record_btrace_target::resume)
6320         (record_btrace_cancel_resume, record_btrace_step_thread)
6321         (record_btrace_target::wait, record_btrace_target::wait)
6322         (record_btrace_target::wait, record_btrace_target::stop): Update.
6323         * progspace.c (print_program_space): Update.
6324         * process-stratum-target.c
6325         (process_stratum_target::thread_address_space): Update.
6326         * linux-fork.c (linux_fork_mourn_inferior)
6327         (detach_checkpoint_command, info_checkpoints_command)
6328         (linux_fork_context): Update.
6329         (linux_fork_detach): Update.
6330         (class scoped_switch_fork_info): Update.
6331         (delete_checkpoint_command): Update.
6332         * infrun.c (follow_fork_inferior): Update.
6333         (follow_fork_inferior): Update.
6334         (proceed_after_vfork_done): Update.
6335         (handle_vfork_child_exec_or_exit): Update.
6336         (follow_exec): Update.
6337         (displaced_step_prepare_throw): Update.
6338         (displaced_step_restore): Update.
6339         (start_step_over): Update.
6340         (resume_1): Update.
6341         (clear_proceed_status_thread): Update.
6342         (proceed): Update.
6343         (print_target_wait_results): Update.
6344         (do_target_wait): Update.
6345         (context_switch): Update.
6346         (stop_all_threads): Update.
6347         (restart_threads): Update.
6348         (finish_step_over): Update.
6349         (handle_signal_stop): Update.
6350         (switch_back_to_stepped_thread): Update.
6351         (keep_going_pass_signal): Update.
6352         (print_exited_reason): Update.
6353         (normal_stop): Update.
6354         * inferior.c (inferior_pid_to_str): Change return type.
6355         (print_selected_inferior): Update.
6356         (add_inferior): Update.
6357         (detach_inferior): Update.
6358         * dummy-frame.c (fprint_dummy_frames): Update.
6359         * dcache.c (dcache_info_1): Update.
6360         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6361         (btrace_fetch, btrace_clear): Update.
6362         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6363         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6364         type.
6365         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6366         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6367         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6368         * gdbarch.c, gdbarch.h: Rebuild.
6369         * gdbarch.sh (core_pid_to_str): Change return type.
6370         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6371         return type.
6372         (windows_nat_target::pid_to_str): Change return type.
6373         (windows_delete_thread): Update.
6374         (windows_nat_target::attach): Update.
6375         (windows_nat_target::files_info): Update.
6376         * target-delegates.c: Rebuild.
6377         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6378         return type.
6379         (sol_thread_target::pid_to_str): Change return type.
6380         * remote.c (class remote_target) <pid_to_str>: Change return
6381         type.
6382         (remote_target::pid_to_str): Change return type.
6383         (extended_remote_target::attach, remote_target::remote_stop_ns)
6384         (remote_target::remote_notif_remove_queued_reply)
6385         (remote_target::push_stop_reply, remote_target::disable_btrace):
6386         Update.
6387         (extended_remote_target::attach): Update.
6388         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6389         type.
6390         (gdbsim_target::pid_to_str): Change return type.
6391         * ravenscar-thread.c (struct ravenscar_thread_target)
6392         <pid_to_str>: Change return type.
6393         (ravenscar_thread_target::pid_to_str): Change return type.
6394         * procfs.c (class procfs_target) <pid_to_str>: Change return
6395         type.
6396         (procfs_target::pid_to_str): Change return type.
6397         (procfs_target::attach): Update.
6398         (procfs_target::detach): Update.
6399         (procfs_target::fetch_registers): Update.
6400         (procfs_target::store_registers): Update.
6401         (procfs_target::wait): Update.
6402         (procfs_target::files_info): Update.
6403         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6404         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6405         return type.
6406         (nto_procfs_target::pid_to_str): Change return type.
6407         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6408         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6409         return type.
6410         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6411         (exit_lwp): Update.
6412         (attach_proc_task_lwp_callback, get_detach_signal)
6413         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6414         (linux_nat_target::resume, wait_lwp, stop_callback)
6415         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6416         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6417         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6418         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6419         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6420         type.
6421         (inf_ptrace_target::attach): Update.
6422         (inf_ptrace_target::files_info): Update.
6423         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6424         type.
6425         (go32_nat_target::pid_to_str): Change return type.
6426         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6427         (gnu_nat_target::wait): Update.
6428         (gnu_nat_target::wait): Update.
6429         (gnu_nat_target::resume): Update.
6430         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6431         (fbsd_nat_target::wait): Update.
6432         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6433         type.
6434         (darwin_nat_target::attach): Update.
6435         * corelow.c (class core_target) <pid_to_str>: Change return type.
6436         (core_target::pid_to_str): Change return type.
6437         * target.c (normal_pid_to_str): Change return type.
6438         (default_pid_to_str): Likewise.
6439         (target_pid_to_str): Change return type.
6440         (target_translate_tls_address): Update.
6441         (target_announce_detach): Update.
6442         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6443         return type.
6444         (bsd_uthread_target::pid_to_str): Change return type.
6445         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6446         type.
6447         (bsd_kvm_target::pid_to_str): Change return type.
6448         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6449         return type.
6450         (aix_thread_target::pid_to_str): Change return type.
6451         * target.h (struct target_ops) <pid_to_str>: Change return type.
6452         (target_pid_to_str, normal_pid_to_str): Likewise.
6453         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6454         type.
6455         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6456         type.
6457         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6458         return type.
6459         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6460         type.
6461         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6462         type.
6463         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6464         return type.
6465
6466 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6467
6468         * NEWS: Mention that the new default MI version is 3.  Mention
6469         changes to the output of commands and events that deal with
6470         multi-location breakpoints.
6471         * breakpoint.c: Include "mi/mi-out.h".
6472         (print_one_breakpoint): Change output syntax if using MI version
6473         >= 3.
6474         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6475         New.
6476         (mi_multi_location_breakpoint_output_fixed): New.
6477         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6478         (mi_cmd_fix_multi_location_breakpoint_output): New.
6479         (mi_multi_location_breakpoint_output_fixed): New.
6480         * mi/mi-cmds.c (mi_cmds): Register command
6481         -fix-multi-location-breakpoint-output.
6482         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6483         interpreter "mi".
6484
6485 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6486
6487         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6488         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6489         instantiate mi_ui_out based on interpreter name.
6490         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6491         * mi/mi-main.c (mi_load_progress): Likewise.
6492
6493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6494
6495         * NEWS: Combine separate "New targets" sections for 8.3.
6496
6497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6498
6499         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6500         (ppcfbsd_init_abi): Install gdbarch
6501         "fetch_tls_load_module_address" and "get_thread_local_address"
6502         methods.
6503
6504 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6505
6506         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6507         (riscv_fbsd_init_abi): Install gdbarch
6508         "fetch_tls_load_module_address" and "get_thread_local_address"
6509         methods.
6510
6511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6512
6513         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6514         (i386fbsd_init_abi): Install gdbarch
6515         "fetch_tls_load_module_address" and "get_thread_local_address"
6516         methods.
6517
6518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6519
6520         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6521         (amd64fbsd_init_abi): Install gdbarch
6522         "fetch_tls_load_module_address" and "get_thread_local_address"
6523         methods.
6524
6525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6526
6527         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6528         (struct fbsd_pspace_data): New type.
6529         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6530         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6531         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6532         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6533         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6534
6535 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6536
6537         * gdbtypes.c (lookup_struct_elt): New function.
6538         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6539         * gdbtypes.h (struct struct_elt): New type.
6540         (lookup_struct_elt): New prototype.
6541
6542 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6543
6544         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6545         remove disabled code block.
6546
6547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6548
6549         * gdbarch.sh (get_thread_local_address): New method.
6550         * gdbarch.h, gdbarch.c: Regenerate.
6551         * target.c (target_translate_tls_address): Use
6552         gdbarch_get_thread_local_address if present instead of
6553         target::get_thread_local_address.
6554
6555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6556
6557         * target.h (target::get_thread_local_address): Update comment.
6558
6559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6560
6561         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6562         objfile->separate_debug_objfile_backlink if not NULL.
6563
6564 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6565
6566         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6567         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6568         (amd64bsd_store_inferior_registers): Likewise.
6569         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6570         Enable segment base registers.
6571         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6572         PT_GETFSBASE and PT_GETGSBASE.
6573         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6574         PT_SETGSBASE.
6575         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6576         segment base registers.
6577         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6578
6579 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6580
6581         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6582         Update calls to i386_target_description to add 'segments'
6583         parameter.
6584         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6585         add segment base registers.
6586         * arch/i386.c (i386_create_target_description): Add 'segments'
6587         parameter to enable segment base registers.
6588         * arch/i386.h (i386_create_target_description): Likewise.
6589         * features/i386/32bit-segments.xml: New file.
6590         * features/i386/32bit-segments.c: Generate.
6591         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6592         call to i386_target_description to add 'segments' parameter.
6593         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6594         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6595         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6596         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6597         if feature is present.
6598         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6599         Add 'segments' parameter to call to i386_target_description.
6600         (i386_target_description): Add 'segments' parameter to enable
6601         segment base registers.
6602         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6603         to call to i386_target_description.
6604         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6605         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6606         Define I386_NUM_REGS.
6607         (i386_target_description): Add 'segments' parameter to enable
6608         segment base registers.
6609
6610 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6611
6612         PR/24325
6613         * source-cache.c: #undef open and close, to avoid unresolved
6614         externals during linking.
6615
6616 2019-03-12  Tom Tromey  <tromey@adacore.com>
6617
6618         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6619         const.  Add initializers.
6620         (_initialize_remote): Don't initialize ptid globals.
6621
6622 2019-03-12  Pedro Alves  <palves@redhat.com>
6623
6624         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6625
6626 2019-03-12  Pedro Alves  <palves@redhat.com>
6627
6628         * cp-name-parser.y (main): Remove unused 'len' variable.
6629
6630 2019-03-12  Tom Tromey  <tromey@adacore.com>
6631
6632         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6633         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6634
6635 2019-03-12  Tom Tromey  <tromey@adacore.com>
6636
6637         * linux-nat.c (iterate_over_lwps): Update.
6638         (stop_callback): Remove parameter.
6639         (stop_wait_callback, detach_callback, resume_set_callback)
6640         (select_singlestep_lwp_callback, set_ignore_sigint)
6641         (status_callback, resumed_callback, resume_clear_callback)
6642         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6643         data parameter.
6644         (linux_nat_target::detach, linux_nat_target::resume)
6645         (linux_stop_and_wait_all_lwps, select_event_lwp)
6646         (linux_nat_filter_event, linux_nat_wait_1)
6647         (linux_nat_target::kill, linux_nat_target::stop)
6648         (linux_nat_target::stop): Update.
6649         (linux_nat_resume_callback): Change type.
6650         (resume_stopped_resumed_lwps, count_events_callback)
6651         (select_event_lwp_callback): Likewise.
6652         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6653         * arm-linux-nat.c (struct update_registers_data): Remove.
6654         (update_registers_callback): Change type.
6655         (arm_linux_insert_hw_breakpoint1): Update.
6656         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6657         parameter.
6658         (x86_linux_dr_set_addr): Update.
6659         (x86_linux_dr_set_control): Update.
6660         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6661         (iterate_over_lwps): Use gdb::function_view.
6662         * nat/aarch64-linux-hw-point.c (struct
6663         aarch64_dr_update_callback_param): Remove.
6664         (debug_reg_change_callback): Change type.
6665         (aarch64_notify_debug_reg_change): Update.
6666         * s390-linux-nat.c (s390_refresh_per_info): Update.
6667
6668 2019-03-11  Tom Tromey  <tromey@adacore.com>
6669
6670         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6671         redundant assignment to "this_cu".
6672
6673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6674
6675         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6676
6677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6678
6679         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6680         from...
6681         (rank_one_type): ... this.
6682
6683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6684
6685         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6686         from...
6687         (rank_one_type): ... this.
6688
6689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6690
6691         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6692         from...
6693         (rank_one_type): ... this.
6694
6695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6696
6697         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6698         from...
6699         (rank_one_type): ... this.
6700
6701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6702
6703         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6704         from...
6705         (rank_one_type): ... this.
6706
6707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6708
6709         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6710         from...
6711         (rank_one_type): ... this.
6712
6713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6714
6715         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6716         from...
6717         (rank_one_type): ... this.
6718
6719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6720
6721         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6722         from...
6723         (rank_one_type): ... this.
6724
6725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6726
6727         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6728         from...
6729         (rank_one_type): ... this.
6730
6731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6732
6733         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6734         from...
6735         (rank_one_type): ... this.
6736
6737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6738
6739         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6740         from...
6741         (rank_one_type): ... this.
6742
6743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6744
6745         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6746         from...
6747         (rank_one_type): ... this.
6748
6749 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6750
6751         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6752         inferior-events' shows the example events.
6753
6754 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6755
6756         Support styling on native MS-Windows console
6757
6758         PR/24315
6759         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6760         on MS-Windows if $TERM is not defined.
6761
6762         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6763
6764         * posix-hdep.c (gdb_console_fputs):
6765         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6766         functions.
6767         * ui-file.h (gdb_console_fputs): Add prototype.
6768
6769         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6770         back to fputs only if the former returns zero.
6771
6772 2019-03-07  Tom Tromey  <tom@tromey.com>
6773
6774         * symmisc.c (print_symbol_bcache_statistics): Update.
6775         (print_objfile_statistics): Update.
6776         * symfile.c (allocate_symtab): Update.
6777         * stabsread.c: Don't include bcache.h.
6778         * psymtab.h (struct psymbol_bcache): Don't declare.
6779         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6780         (psymbol_bcache_init, psymbol_bcache_free)
6781         (psymbol_bcache_get_bcache): Don't declare.
6782         * psymtab.c (struct psymbol_bcache): Remove.
6783         (psymtab_storage::psymtab_storage): Update.
6784         (psymtab_storage::~psymtab_storage): Update.
6785         (psymbol_bcache_init, psymbol_bcache_free)
6786         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6787         (add_psymbol_to_bcache): Update.
6788         (allocate_psymtab): Update.
6789         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6790         macro_cache>: No longer pointers.
6791         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6792         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6793         * macrotab.c (macro_bcache): Update.
6794         * macroexp.c: Don't include bcache.h.
6795         * gdbtypes.c (check_types_worklist): Update.
6796         (types_deeply_equal): Remove TRY/CATCH.  Update.
6797         * elfread.c (elf_symtab_read): Update.
6798         * dwarf2read.c: Don't include bcache.h.
6799         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6800         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6801         (print_bcache_statistics, bcache_memory_used): Don't declare.
6802         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6803         methods.  Rename all data members.
6804         * bcache.c (struct bcache): Move to bcache.h.
6805         (bcache::expand_hash_table): Rename from expand_hash_table.
6806         (bcache): Remove.
6807         (bcache::insert): Rename from bcache_full.
6808         (bcache::compare): Rename from bcache_compare.
6809         (bcache_xmalloc): Remove.
6810         (bcache::~bcache): Rename from bcache_xfree.
6811         (bcache::print_statistics): Rename from print_bcache_statistics.
6812         (bcache::memory_used): Rename from bcache_memory_used.
6813
6814 2019-03-07  Pedro Alves  <palves@redhat.com>
6815
6816         * infrun.c (normal_stop): Also check for
6817         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6818
6819 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6820
6821         * f-lang.c (value_from_host_double): Moved to...
6822         * value.c (value_from_host_double): ...here.
6823         * value.h (value_from_host_double): Declare.
6824         * guile/scm-math.c (vlscm_convert_typed_number): Use
6825         value_from_host_double.
6826         (vlscm_convert_number): Likewise.
6827         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6828         * python/py-value.c (convert_value_from_python): Likewise.
6829
6830 2019-03-06  Tom Tromey  <tom@tromey.com>
6831
6832         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6833
6834 2019-03-06  Tom Tromey  <tom@tromey.com>
6835
6836         * utils.h (free_current_contents): Don't declare.
6837         * utils.c (free_current_contents): Remove.
6838
6839 2019-03-06  Tom Tromey  <tom@tromey.com>
6840
6841         * top.c (quit_force): Update.
6842         * main.c (captured_command_loop): Update.
6843         * common/new-op.c (operator new): Update.
6844         * common/common-exceptions.c (struct catcher)
6845         <save_cleanup_chain>: Remove member.
6846         (exceptions_state_mc_init): Update.
6847         (exception_try_scope_entry): Return nullptr.
6848         (exception_try_scope_exit, exception_rethrow)
6849         (throw_exception_sjlj, throw_exception_cxx): Update.
6850         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6851         (all_cleanups, do_cleanups, discard_cleanups)
6852         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6853         (restore_cleanups, restore_final_cleanups): Don't declare.
6854         (do_final_cleanups): Remove parameter.
6855         * common/cleanups.c (cleanup_chain, make_cleanup)
6856         (make_cleanup_dtor, all_cleanups, do_cleanups)
6857         (discard_my_cleanups, discard_cleanups)
6858         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6859         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6860         (null_cleanup): Remove.
6861         (do_final_cleanups): Remove parameter.
6862
6863 2019-03-06  Tom Tromey  <tom@tromey.com>
6864
6865         * remote.c (remote_target::remote_parse_stop_reply): Use
6866         unique_xmalloc_ptr.
6867
6868 2019-03-06  Tom Tromey  <tom@tromey.com>
6869
6870         * stabsread.c (struct stabs_field_info): Rename from field_info.
6871         <list, fnlist>: Add initializers.
6872         <obstack>: New member.
6873         (read_member_functions, read_struct_fields, read_baseclasses):
6874         Allocate on obstack.  Don't use cleanups.
6875         (read_one_struct_field, read_member_functions, read_struct_fields)
6876         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6877         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6878         (read_struct_type): Update.
6879
6880 2019-03-06  Tom Tromey  <tom@tromey.com>
6881
6882         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6883         * common/filestuff.h (make_cleanup_close): Don't declare.
6884         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6885         Remove.
6886
6887 2019-03-06  Tom Tromey  <tom@tromey.com>
6888
6889         * solib-aix.c: Use make_scope_exit.
6890
6891 2019-03-06  Tom Tromey  <tom@tromey.com>
6892
6893         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6894         Use make_scope_exit.
6895
6896 2019-03-06  Tom Tromey  <tom@tromey.com>
6897
6898         * solib-svr4.c (disable_probes_interface): Remove parameter.
6899         (svr4_handle_solib_event): Use make_scope_exit.
6900
6901 2019-03-06  Tom Tromey  <tom@tromey.com>
6902
6903         * remote.c (struct stop_reply_deleter): Remove.
6904         (stop_reply_up): Update.
6905         (struct stop_reply): Derive from notif_event.  Don't typedef.
6906         <regcache>: Now a std::vector.
6907         (stop_reply_xfree): Remove.
6908         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6909         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6910         (remote_target::discard_pending_stop_replies): Use delete.
6911         (remote_target::remote_parse_stop_reply): Update.
6912         (remote_target::process_stop_reply): Update.
6913         * remote-notif.h (struct notif_event): Add virtual destructor.
6914         Remove "dtr" member.
6915         (struct notif_client) <alloc_event>: Return a unique_ptr.
6916         (notif_event_xfree): Don't declare.
6917         (notif_event_up): New typedef.
6918         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6919         (notif_event_xfree, do_notif_event_xfree): Remove.
6920         (remote_notif_state_xfree): Update.
6921
6922 2019-03-06  Tom Tromey  <tom@tromey.com>
6923
6924         * infrun.c (displaced_step_clear_cleanup): Now a
6925         forward_scope_exit type.
6926         (displaced_step_prepare_throw): Update.
6927         (displaced_step_fixup): Update.
6928
6929 2019-03-06  Tom Tromey  <tom@tromey.com>
6930
6931         * inferior.h (class inferior): Update comment.
6932         * gdbthread.h (class thread_info): Update comment.
6933
6934 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6935             Tom Tromey  <tom@tromey.com>
6936
6937         * stabsread.h (struct stab_section_list): Remove.
6938         (coffstab_build_psymtabs): Update.
6939         * dbxread.c (symbuf_sections): Now a std::vector.
6940         (sect_idx): New global.
6941         (fill_symbuf): Update.
6942         (coffstab_build_psymtabs): Change type of stabsects parameter.
6943         Update.
6944         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6945         std::vector.
6946         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6947         (coff_locate_sections): Update.
6948         (coff_symfile_read): Remove cleanups.  Update.
6949         (init_stringtab): Add storage parameter.
6950         (free_stringtab, free_stringtab_cleanup): Remove.
6951         (init_lineno): Add storage parameter.
6952         (free_linetab, free_linetab_cleanup): Remove.
6953
6954 2019-03-06  Pedro Alves  <palves@redhat.com>
6955
6956         * linux-fork.c (fork_info::clobber_regs): Delete.
6957         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6958         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6959         comment.  Adjust.
6960         (scoped_switch_fork_info::scoped_switch_fork_info)
6961         (checkpoint_command, linux_fork_context): Adjust
6962         fork_save_infrun_state calls.
6963
6964 2019-03-06  Pedro Alves  <palves@redhat.com>
6965
6966         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6967         (inf_has_multiple_threads): Return 'bool' and rewrite using
6968         inferior_info::threads().
6969
6970 2019-03-06  Pedro Alves  <palves@redhat.com>
6971
6972         * linux-fork.c: Include <list>.
6973         (fork_list): Now a std::list instance.
6974         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6975         (forks_exist_p, find_last_fork): Adjust.
6976         (new_fork): Delete.
6977         (one_fork_p): New.
6978         (add_fork): Adjust.
6979         (free_fork): Delete, folded into fork_info::~fork_info().
6980         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6981         Adjust.
6982         (init_fork_list): Delete.
6983         (linux_fork_killall, linux_fork_mourn_inferior)
6984         (linux_fork_detach, info_checkpoints_command): Adjust.
6985         (_initialize_linux_fork): No longer call init_fork_list.
6986
6987 2019-03-06  Pedro Alves  <palves@redhat.com>
6988
6989         * linux-fork.c (new_fork): New, split out of ...
6990         (add_fork): ... this.  Return void.  Move "first fork" special
6991         case from here, to ...
6992         (checkpoint_command): ... here.
6993         * linux-linux.h (add_fork): Return void.
6994
6995 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6996
6997         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6998
6999 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7000             Chris January  <chris.january@arm.com>
7001             David Lecomber  <david.lecomber@arm.com>
7002
7003         * f-exp.y: New token, UNOP_INTRINSIC.
7004         (exp): New pattern using UNOP_INTRINSIC token.
7005         (f77_keywords): Add 'abs' keyword.
7006         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7007         (value_from_host_double): New function.
7008         (evaluate_subexp_f): Support UNOP_ABS.
7009
7010 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7011
7012         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7013         types.
7014
7015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7018         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7019         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7020
7021 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7022
7023         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7024
7025 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7026             Chris January  <chris.january@arm.com>
7027
7028         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7029         * f-exp.y: Define 'KIND' token.
7030         (exp): New pattern for KIND expressions.
7031         (ptype): Handle types with a kind extension.
7032         (direct_abs_decl): Extend to spot kind extensions.
7033         (f77_keywords): Add 'kind' to the list.
7034         (push_kind_type): New function.
7035         (convert_to_kind_type): New function.
7036         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7037         * parse.c (operator_length_standard): Likewise.
7038         * parser-defs.h (enum type_pieces): Add tp_kind.
7039         * std-operator.def: Add UNOP_KIND.
7040
7041 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * f-exp.y (f_parse): Set yydebug.
7044
7045 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * f-lang.c (evaluate_subexp_f): New function.
7048         (exp_descriptor_f): New global.
7049         (f_language_defn): Use exp_descriptor_f instead of
7050         exp_descriptor_standard.
7051
7052 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7053
7054         * f-exp.y (struct token): Add comments.
7055         (dot_ops): Remove uppercase versions and the end marker.
7056         (f77_keywords): Likewise.
7057         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7058         entries in the dot_ops array are case insensitive, and use
7059         strncasecmp to compare strings.  Also some whitespace cleanup in
7060         this area.  Similar for the f77_keywords array, except entries in
7061         this list might be case sensitive.
7062
7063 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7064
7065         * f-exp.y (struct f77_boolean_val): Add comments.
7066         (boolean_values): Remove uppercase versions, and end marker.
7067         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7068         and use strncasecmp to achieve case insensitivity.  Additionally,
7069         perform whitespace cleanup around this code.
7070
7071 2019-03-06  Tom Tromey  <tromey@adacore.com>
7072
7073         * remote-sim.c (gdbsim_target_open): Use result of
7074         gdb_argv::release.
7075
7076 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7077         Dirk Schubert  <dirk.schubert@arm.com>
7078         Chris January  <chris.january@arm.com>
7079
7080         * eval.c (evaluate_subexp_standard): Call Fortran argument
7081         wrapping logic.
7082         * f-lang.c (struct value): A value which can be passed into a
7083         Fortran function call.
7084         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7085         where appropriate.
7086         (struct type): Value ready for a Fortran function call.
7087         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7088         is needed.
7089         * f-lang.h (fortran_argument_convert): Declaration.
7090         (fortran_preserve_arg_pointer): Declaration.
7091         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7092
7093 2019-03-05  Tom Tromey  <tromey@adacore.com>
7094
7095         * python/py-prettyprint.c (print_string_repr): Remove #if.
7096         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7097
7098 2019-03-05  Tom Tromey  <tromey@adacore.com>
7099
7100         * target.c (the_dummy_target): Move later.  Change type to
7101         "dummy_target".
7102         (initialize_targets): Don't initialize the_dummy_target.
7103
7104 2019-03-05  Tom Tromey  <tromey@adacore.com>
7105
7106         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7107         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7108
7109 2019-03-05  Tom Tromey  <tromey@adacore.com>
7110
7111         * windows-nat.c (windows_nat_target::attach)
7112         (windows_nat_target::detach): Don't call gdb_flush.
7113         * valprint.c (generic_val_print, val_print, val_print_string):
7114         Don't call gdb_flush.
7115         * utils.c (defaulted_query): Don't call gdb_flush.
7116         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7117         * target.c (target_announce_detach): Don't call gdb_flush.
7118         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7119         * remote.c (extended_remote_target::attach): Don't call
7120         gdb_flush.
7121         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7122         * printcmd.c (do_examine): Don't call gdb_flush.
7123         (info_display_command): Don't call gdb_flush.
7124         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7125         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7126         * memattr.c (info_mem_command): Don't call gdb_flush.
7127         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7128         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7129         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7130         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7131         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7132         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7133         (gnu_nat_target::detach): Don't call gdb_flush.
7134         * f-valprint.c (f_val_print): Don't call gdb_flush.
7135         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7136         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7137         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7138         gdb_flush.
7139         * c-valprint.c (c_val_print): Don't call gdb_flush.
7140         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7141
7142 2019-03-05  Tom Tromey  <tromey@adacore.com>
7143
7144         * varobj.c (update_dynamic_varobj_children): Update.
7145         (install_default_visualizer): Use reset, not release.
7146         * value.c (set_internalvar): Update.
7147         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7148         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7149         ATTRIBUTE_UNUSED_RESULT.
7150
7151 2019-03-05  Tom Tromey  <tromey@adacore.com>
7152
7153         * remote.c (class scoped_remote_fd) <release>: Add
7154         ATTRIBUTE_UNUSED_RESULT.
7155
7156 2019-03-05  Tom Tromey  <tromey@adacore.com>
7157
7158         * macroexp.c (struct macro_buffer) <release>: Add
7159         ATTRIBUTE_UNUSED_RESULT.
7160
7161 2019-03-05  Tom Tromey  <tromey@adacore.com>
7162
7163         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7164         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7165         ATTRIBUTE_UNUSED_RESULT.
7166
7167 2019-03-05  Tom Tromey  <tromey@adacore.com>
7168
7169         * common/scoped_fd.h (class scoped_fd) <release>: Add
7170         ATTRIBUTE_UNUSED_RESULT.
7171
7172 2019-03-05  Tom Tromey  <tromey@adacore.com>
7173
7174         * parser-defs.h (struct parser_state) <release>: Add
7175         ATTRIBUTE_UNUSED_RESULT.
7176
7177 2019-03-05  Tom Tromey  <tromey@adacore.com>
7178
7179         * utils.h (class gdb_argv) <release>: Add
7180         ATTRIBUTE_UNUSED_RESULT.
7181         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7182
7183 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7184
7185         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7186         for-loop range, to avoid compiler warnings.
7187
7188         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7189         avoid compiler warnings about unused variables.
7190
7191         * NEWS: Mention end of support for native debugging on MS-Windows
7192         before XP.
7193
7194         PR gdb/24292
7195         * common/netstuff.c:
7196         * gdbserver/gdbreplay.c
7197         * gdbserver/remote-utils.c:
7198         * ser-tcp.c:
7199         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7200         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7201         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7202         'getaddrinfo' and 'freeaddrinfo' were not available before
7203         Windows XP, and mingw.org's MinGW headers by default define
7204         _WIN32_WINNT to 0x500.
7205
7206 2019-03-01  Gary Benson <gbenson@redhat.com>
7207
7208         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7209
7210 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7211             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7212
7213         PR gdb/8527
7214         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7215         set_sigint_trap, clear_sigint_trap.
7216
7217 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7218
7219         * target.c (target_detach): Clear the regcache and the
7220         frame cache.
7221
7222 2019-02-27  Pedro Alves  <palves@redhat.com>
7223
7224         * utils.c (set_screen_size): When we cap the height/width sizes,
7225         tweak the corresponding command variable to show "unlimited":
7226
7227 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7228             Pedro Alves  <palves@redhat.com>
7229
7230         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7231         before calling rl_set_screen_size.
7232
7233 2019-02-27  Tom Tromey  <tromey@adacore.com>
7234
7235         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7236         define.
7237         * python/py-value.c: Remove Python 2.4 workaround.
7238         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7239         workaround.
7240         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7241         Python 2.4 workaround.
7242         * python/python-internal.h: Remove Python 2.4 comment.
7243         (Py_ssize_t): Don't define.
7244         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7245         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7246         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7247         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7248         * python/python.c (do_start_initialization): Remove Python 2.4
7249         workaround.
7250         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7251         (print_children): Remove Python 2.4 workaround.
7252         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7253         workaround.
7254         (CHARBUFFERPROC_NAME): Remove.
7255         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7256         Python 2.4 workaround.
7257
7258 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7259
7260         * NEWS: Note minimum Python version.
7261
7262 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7263
7264         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7265         code from these functions.  Remove corresponding ifdefs.  Use
7266         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7267         Remove gotos and target of gotos.
7268         (infpy_search_memory): Likewise.
7269
7270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7273         (hppa_gdbarch_init): Don't register deleted functions with
7274         gdbarch.
7275
7276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7279         (h8300_unwind_sp): Delete.
7280         (h8300_dummy_id): Delete.
7281         (h8300_gdbarch_init): Don't register deleted functions with
7282         gdbarch.
7283
7284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7287         (ft32_unwind_pc): Delete.
7288         (ft32_unwind_sp): Delete.
7289         (ft32_gdbarch_init): Don't register deleted functions with
7290         gdbarch.
7291
7292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7293
7294         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7295         (frv_unwind_pc): Delete.
7296         (frv_unwind_sp): Delete.
7297         (frv_gdbarch_init): Don't register deleted functions with
7298         gdbarch.
7299
7300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7303         (riscv_unwind_pc): Delete.
7304         (riscv_unwind_sp): Delete.
7305         (riscv_gdbarch_init): Don't register deleted functions with
7306         gdbarch.
7307
7308 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7309
7310         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7311         (csky_unwind_pc): Delete.
7312         (csky_unwind_sp): Delete.
7313         (csky_gdbarch_init): Don't register deleted functions with
7314         gdbarch.
7315
7316 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7319         (cris_unwind_pc): Delete.
7320         (cris_unwind_sp): Delete.
7321         (cris_gdbarch_init): Don't register deleted functions with
7322         gdbarch.
7323
7324 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7325
7326         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7327         (bfin_unwind_pc): Delete.
7328         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7329
7330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7331
7332         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7333         (arm_unwind_pc): Delete.
7334         (arm_unwind_sp): Delete.
7335         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7336
7337 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7338
7339         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7340         (arc_unwind_pc): Delete.
7341         (arc_unwind_sp): Delete.
7342         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7343
7344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7345
7346         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7347         (alpha_unwind_pc): Delete.
7348         (alpha_gdbarch_init): Don't register deleted functions with
7349         gdbarch.
7350
7351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7354         (aarch64_unwind_pc): Delete.
7355         (aarch64_unwind_sp): Delete.
7356         (aarch64_gdbarch_init): Don't register deleted functions with
7357         gdbarch.
7358
7359 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7360
7361         * gdbtypes.c (type_align): Don't consider static members when
7362         computing structure alignment.
7363
7364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7365
7366         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7367         return 0 for other types.
7368         * arch-utils.c (default_type_align): Always return 0.
7369         * gdbarch.h: Regenerate.
7370         * gdbarch.sh (type_align): Extend comment.
7371         * gdbtypes.c (type_align): Add additional comments, always call
7372         gdbarch_type_align before applying the default rules.
7373         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7374         generic code will then apply a suitable default.
7375         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7376         types, return 0 for other types.
7377
7378 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7379
7380         * NEWS: Create a new section for the next release branch.
7381         Rename the section of the current branch, now that it has
7382         been cut.
7383
7384 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7385
7386         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7387         * version.in: Bump version to 8.3.50.DATE-git.
7388
7389 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7390
7391         * aix-thread.c (ptid_cmp): Remove unused variable.
7392         (get_signaled_thread): Likewise.
7393         (store_regs_user_thread): Likewise.
7394         (store_regs_kernel_thread): Likewise.
7395         (fetch_regs_kernel_thread): Remove shadowed variable.
7396
7397 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7398
7399         * features/riscv/32bit-cpu.xml: Add register numbers.
7400         * features/riscv/32bit-fpu.c: Regenerate.
7401         * features/riscv/32bit-fpu.xml: Add register numbers.
7402         * features/riscv/64bit-cpu.xml: Add register numbers.
7403         * features/riscv/64bit-fpu.c: Regenerate.
7404         * features/riscv/64bit-fpu.xml: Add register numbers.
7405
7406 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7407
7408         * NEWS: Mention two argument form of gdb.Value constructor.
7409         * python/py-value.c (convert_buffer_and_type_to_value): New
7410         function.
7411         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7412         Add support for handling an optional second argument.  Call
7413         convert_buffer_and_type_to_value as appropriate.
7414         * python/python-internal.h (Py_buffer_deleter): New struct.
7415         (Py_buffer_up): New typedef.
7416
7417 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7418
7419         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7420         instead of releasing ownership.
7421
7422 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7423
7424         * dwarf2read.c (open_and_init_dwp_file): Call
7425         elf_numsections instead of bfd_count_sections to initialize
7426         dwp_file->num_sections.
7427
7428 2019-02-25  Tom Tromey  <tromey@adacore.com>
7429
7430         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7431
7432 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7433
7434         * gcore.in: Add '--readnever' option when invoking GDB.
7435
7436 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7437
7438         * MAINTAINERS: Update my email address.
7439
7440 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7441
7442         * build-id.c (build_id_to_debug_bfd_1): New function.
7443         (build_id_to_debug_bfd): Look for separate debug file in
7444         sysroot.
7445
7446 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * gdbarch.sh: Update the copyright year range that is placed into
7449         generated files.
7450
7451 2019-02-22  Keith Seitz  <keiths@redhat.com>
7452
7453         PR symtab/23853
7454         * linespec.c (create_sals_line_offset): Search for the default
7455         symtab's filename instead of its fullname.
7456
7457 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7458
7459         * NEWS: Update style defaults.
7460
7461 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7462
7463         * main.c (captured_main_1): Disable styling in batch mode.
7464
7465 2019-02-20  Tom Tromey  <tom@tromey.com>
7466
7467         * symtab.c (symtab_symbol_info): Fix typos.
7468
7469 2019-02-20  Tom Tromey  <tromey@adacore.com>
7470
7471         * findcmd.c (_initialize_mem_search): Use upper case for
7472         metasyntactic variables.
7473
7474 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7475
7476         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7477         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7478
7479 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7480
7481         * top.h (source_file_name): Change to std::string.
7482         * top.c (source_file_name): Likewise.
7483         (command_line_input): Adjust.
7484         * cli/cli-script.c (script_from_file): Adjust.
7485
7486 2019-02-19  Tom Tromey  <tromey@adacore.com>
7487
7488         * ravenscar-thread.c
7489         (ravenscar_thread_target::update_thread_list): Don't call
7490         ada_build_task_list.
7491         * ada-lang.h (ada_build_task_list): Don't declare.
7492         * ada-tasks.c (struct ada_tasks_inferior_data)
7493         <task_list_valid_p>: Now bool.
7494         (read_known_tasks, ada_task_list_changed)
7495         (ada_tasks_invalidate_inferior_data): Update.
7496         (read_known_tasks_array): Return bool.
7497         (read_known_tasks_list): Likewise.
7498         (read_known_tasks): Return void.
7499         (ada_build_task_list): Now static.
7500
7501 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7502
7503         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7504         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7505
7506 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7507
7508         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7509         variant for ada_tasks_pspace_data_handle and
7510         ada_tasks_inferior_data_handle.
7511         (ada_tasks_pspace_data_cleanup): New function.
7512         (ada_tasks_inferior_data_cleanup): New function.
7513
7514 2019-02-17  Tom Tromey  <tom@tromey.com>
7515
7516         * macrotab.h (macro_source_fullname): Return a std::string.
7517         * macrotab.c (macro_include, check_for_redefinition)
7518         (macro_undef, macro_lookup_definition, foreach_macro)
7519         (foreach_macro_in_scope): Update.
7520         (macro_source_fullname): Return a std::string.
7521         * macrocmd.c (show_pp_source_pos): Update.
7522
7523 2019-02-17  Tom Tromey  <tom@tromey.com>
7524
7525         * macrocmd.c (show_pp_source_pos): Style the file names.
7526
7527 2019-02-17  Tom Tromey  <tom@tromey.com>
7528
7529         PR tui/24197:
7530         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7531
7532 2019-02-17  Tom Tromey  <tom@tromey.com>
7533
7534         * ada-lang.c (user_select_syms): Use filtered printing.
7535         * utils.c (wrap_style): New global.
7536         (desired_style): Remove.
7537         (emit_style_escape): Add stream parameter.
7538         (set_output_style, reset_terminal_style, prompt_for_continue):
7539         Update.
7540         (flush_wrap_buffer): Only flush gdb_stdout.
7541         (wrap_here): Set wrap_style.
7542         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7543         treat escape sequences as a character.  Change when wrap buffer is
7544         flushed.
7545         (fputs_styled): Do not set the output style when the default is
7546         requested.
7547         * ui-style.h (struct ui_file_style) <is_default>: New method.
7548         * source.c (print_source_lines_base): Emit escape sequences in one
7549         piece.
7550
7551 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7552
7553         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7554         integers and enumeration types.
7555
7556 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7557
7558         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7559         instead of lookup_symbol_in_language
7560         (do_exact_match): New function.
7561         (ada_get_symbol_name_matcher): Return do_exact_match when
7562         doing a verbatim match.
7563
7564 2019-02-15  Tom Tromey  <tromey@adacore.com>
7565
7566         * ravenscar-thread.c (ravenscar_thread_target::resume)
7567         (ravenscar_thread_target::wait): Special case wildcard requests.
7568
7569 2019-02-15  Tom Tromey  <tromey@adacore.com>
7570
7571         * ravenscar-thread.c (base_ptid): Remove.
7572         (struct ravenscar_thread_target) <close>: New method.
7573         <m_base_ptid>: New member.
7574         <update_inferior_ptid, active_task, task_is_currently_active,
7575         runtime_initialized>: Declare methods.
7576         <ravenscar_thread_target>: Add constructor.
7577         (ravenscar_thread_target::task_is_currently_active)
7578         (ravenscar_thread_target::update_inferior_ptid)
7579         (ravenscar_runtime_initialized): Rename.  Now methods.
7580         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7581         (ravenscar_thread_target::update_thread_list): Update.
7582         (ravenscar_thread_target::active_task): Now method.
7583         (ravenscar_thread_target::store_registers)
7584         (ravenscar_thread_target::prepare_to_store)
7585         (ravenscar_thread_target::prepare_to_store)
7586         (ravenscar_thread_target::mourn_inferior): Update.
7587         (ravenscar_inferior_created): Use "new" to create target.
7588         (ravenscar_thread_target::get_ada_task_ptid): Update.
7589         (_initialize_ravenscar): Don't initialize base_ptid.
7590         (ravenscar_ops): Remove global.
7591
7592 2019-02-15  Tom Tromey  <tromey@adacore.com>
7593
7594         * target.h (push_target): Declare new overload.
7595         * target.c (push_target): New overload, taking an rvalue reference.
7596         * remote.c (remote_target::open_1): Use push_target overload.
7597         * corelow.c (core_target_open): Use push_target overload.
7598
7599 2019-02-15  Tom Tromey  <tromey@adacore.com>
7600
7601         * ravenscar-thread.c (is_ravenscar_task)
7602         (ravenscar_task_is_currently_active): Return bool.
7603         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7604         (_initialize_ravenscar): Remove "(void)".
7605         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7606         Return bool.
7607
7608 2019-02-15  Tom Tromey  <tromey@adacore.com>
7609
7610         * ravenscar-thread.c (ravenscar_runtime_initializer)
7611         (has_ravenscar_runtime, get_running_thread_id)
7612         (ravenscar_thread_target::resume): Fix indentation.
7613
7614 2019-02-15  Tom Tromey  <tromey@adacore.com>
7615
7616         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7617         from ravenscar_arch_ops.
7618         (sparc_ravenscar_ops::fetch_registers)
7619         (sparc_ravenscar_ops::store_registers): Now methods.
7620         (sparc_ravenscar_prepare_to_store): Remove.
7621         (sparc_ravenscar_ops): Redefine.
7622         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7623         methods and destructor.  Remove members.
7624         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7625         (ravenscar_thread_target::store_registers)
7626         (ravenscar_thread_target::prepare_to_store): Update.
7627         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7628         Remove.
7629         (struct ppc_ravenscar_powerpc_ops): Derive from
7630         ravenscar_arch_ops.
7631         (ppc_ravenscar_powerpc_ops::fetch_registers)
7632         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7633         (ppc_ravenscar_powerpc_ops): Redefine.
7634         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7635         (ppc_ravenscar_e500_ops::fetch_registers)
7636         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7637         (ppc_ravenscar_e500_ops): Redefine.
7638         * aarch64-ravenscar-thread.c
7639         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7640         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7641         (aarch64_ravenscar_fetch_registers)
7642         (aarch64_ravenscar_store_registers): Now methods.
7643         (aarch64_ravenscar_ops): Redefine.
7644
7645 2019-02-15  Tom Tromey  <tromey@adacore.com>
7646
7647         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7648         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7649         (ravenscar_thread_target::stopped_by_watchpoint)
7650         (ravenscar_thread_target::stopped_data_address)
7651         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7652
7653 2019-02-15  Tom Tromey  <tromey@adacore.com>
7654
7655         * ravenscar-thread.c: Fix some typos.
7656
7657 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7658             Tom Tromey  <tromey@adacore.com>
7659
7660         * ada-lang.c (ada_exception_sal): Change addr_string to a
7661         std::string.
7662         (create_ada_exception_catchpoint): Update.
7663
7664 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7665             Tom Tromey  <tromey@adacore.com>
7666
7667         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7668         (bp_location_ops): Remove.
7669         (base_breakpoint_allocate_location): Update.
7670         (free_bp_location): Update.
7671         * ada-lang.c (class ada_catchpoint_location)
7672         <ada_catchpoint_location>: Remove ops parameter.
7673         (ada_catchpoint_location_dtor): Remove.
7674         (ada_catchpoint_location_ops): Remove.
7675         (allocate_location_exception): Update.
7676         * breakpoint.h (struct bp_location_ops): Remove.
7677         (class bp_location) <bp_location>: Remove bp_location_ops
7678         parameter.
7679         <~bp_location>: Add destructor.
7680         <ops>: Remove.
7681
7682 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7683             Pedro Alves  <palves@redhat.com>
7684
7685         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7686         'PATH_MAX'.
7687
7688 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7689             Samuel Thibault  <samuel.thibault@gnu.org>
7690             Thomas Schwinge  <thomas@codesourcery.com>
7691
7692         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7693         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7694
7695 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7696
7697         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7698         (check_empty): Use "const char *".
7699
7700         * gnu-nat.c (gnu_nat_target::detach): Instead of
7701         'detach_inferior (pid)' call
7702         'detach_inferior (find_inferior_pid (pid))'.
7703
7704         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7705         'nat/fork-inferior.o'.
7706         * gnu-nat.c: #include "nat/fork-inferior.h".
7707
7708         * gnu-nat.c (gnu_nat_target::detach): Instead of
7709         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7710         * gnu-nat.h: #include "inf-child.h".
7711         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7712         'i386_gnu_nat_target::fetch_registers'.
7713         (gnu_store_registers): Rename/move to
7714         'i386_gnu_nat_target::store_registers'.
7715
7716         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7717         * gnu-nat.h (mach_thread_info): New function.
7718         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7719
7720         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7721
7722 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7723
7724         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7725
7726 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7727
7728         * windows-nat.c (windows_add_thread): Add new parameter
7729         "main_thread_p" with default value set to false.  Update
7730         function documentation as well as all callers.
7731         (windows_delete_thread): Likewise.
7732         (fake_create_process): Update call to windows_add_thread.
7733         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7734         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7735         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7736         call to windows_delete_thread.
7737
7738 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7739
7740         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7741
7742 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7743
7744         * symfile.c (find_separate_debug_file): Use canonical path of
7745         sysroot with child_path instead of gdb_sysroot if it is valid.
7746
7747 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7748
7749         * symfile.c (find_separate_debug_file): Use child_path to
7750         determine if an object file is under a sysroot.
7751
7752 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7753
7754         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7755         unittests/child-path-selftests.c.
7756         * common/pathstuff.c (child_path): New function.
7757         * common/pathstuff.h (child_path): New prototype.
7758         * unittests/child-path-selftests.c: New file.
7759
7760 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7761
7762         * symfile.c (find_separate_debug_file): Look for separate debug
7763         files in debug directories under the sysroot.
7764
7765 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7766
7767         * symtab.h (struct minimal_symbol data_p): New const method.
7768         (struct minimal_symbol text_p): Likewise.
7769         * symtab.c (output_source_filename): Use file name style
7770         to print file name.
7771         (print_symbol_info): Likewise.
7772         (print_msymbol_info): Use address style to print addresses.
7773         Use function name style to print executable text symbols.
7774         (expand_symtab_containing_pc): Use data_p.
7775         (find_pc_sect_compunit_symtab): Likewise.
7776
7777 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7778
7779         * breakpoint.c (describe_other_breakpoints): Use address style
7780         to print addresses.
7781         (say_where): Likewise.
7782
7783 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7784
7785         * ada-typeprint.c (print_func_type): Print function name
7786         style to print function name.
7787         * c-typeprint.c (c_print_type_1): Likewise.
7788
7789 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7790
7791         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7792         for execve.
7793
7794 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7795
7796         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7797         type_stack.
7798
7799 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7800
7801         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7802         TYPE_CODE_REF types.
7803
7804 2019-02-08  Jim Wilson  <jimw@sifive.com>
7805
7806         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7807         (riscv_linux_fregset): New.
7808         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7809
7810 2019-02-07  Tom Tromey  <tom@tromey.com>
7811
7812         * thread.c (thread_cancel_execution_command): Update.
7813         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7814         methods.
7815         (struct thread_fsm_ops): Remove.
7816         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7817         (thread_fsm_should_stop, thread_fsm_return_value)
7818         (thread_fsm_set_finished, thread_fsm_finished_p)
7819         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7820         Don't declare.
7821         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7822         * infrun.c (clear_proceed_status_thread)
7823         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7824         (print_stop_event): Update.
7825         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7826         Add constructor.
7827         (step_command_fsm_ops): Remove.
7828         (new_step_command_fsm): Remove.
7829         (step_1): Update.
7830         (step_command_fsm::should_stop): Rename from
7831         step_command_fsm_should_stop.
7832         (step_command_fsm::clean_up): Rename from
7833         step_command_fsm_clean_up.
7834         (step_command_fsm::do_async_reply_reason): Rename from
7835         step_command_fsm_async_reply_reason.
7836         (struct until_next_fsm): Inherit from thread_fsm.  Add
7837         constructor.
7838         (until_next_fsm_ops): Remove.
7839         (new_until_next_fsm): Remove.
7840         (until_next_fsm::should_stop): Rename from
7841         until_next_fsm_should_stop.
7842         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7843         (until_next_fsm::do_async_reply_reason): Rename from
7844         until_next_fsm_async_reply_reason.
7845         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7846         constructor.  Change type of breakpoint.
7847         (finish_command_fsm_ops): Remove.
7848         (new_finish_command_fsm): Remove.
7849         (finish_command_fsm::should_stop): Rename from
7850         finish_command_fsm_should_stop.
7851         (finish_command_fsm::clean_up): Rename from
7852         finish_command_fsm_clean_up.
7853         (finish_command_fsm::return_value): Rename from
7854         finish_command_fsm_return_value.
7855         (finish_command_fsm::do_async_reply_reason): Rename from
7856         finish_command_fsm_async_reply_reason.
7857         (finish_command): Update.
7858         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7859         Add constructor.
7860         (call_thread_fsm_ops): Remove.
7861         (call_thread_fsm::call_thread_fsm): Rename from
7862         new_call_thread_fsm.
7863         (call_thread_fsm::should_stop): Rename from
7864         call_thread_fsm_should_stop.
7865         (call_thread_fsm::should_notify_stop): Rename from
7866         call_thread_fsm_should_notify_stop.
7867         (run_inferior_call, call_function_by_hand_dummy): Update.
7868         * cli/cli-interp.c (should_print_stop_to_console): Update.
7869         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7870         Add constructor.  Change type of location_breakpoint,
7871         caller_breakpoint.
7872         (until_break_fsm_ops): Remove.
7873         (new_until_break_fsm): Remove.
7874         (until_break_fsm::should_stop): Rename from
7875         until_break_fsm_should_stop.
7876         (until_break_fsm::clean_up): Rename from
7877         until_break_fsm_clean_up.
7878         (until_break_fsm::do_async_reply_reason): Rename from
7879         until_break_fsm_async_reply_reason.
7880         (until_break_command): Update.
7881         * thread-fsm.c: Remove.
7882         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7883
7884 2019-02-07  Tom Tromey  <tom@tromey.com>
7885
7886         * yy-remap.h: Add include guard.
7887         * xtensa-tdep.h: Add include guard.
7888         * xcoffread.h: Rename include guard.
7889         * varobj-iter.h: Add include guard.
7890         * tui/tui.h: Rename include guard.
7891         * tui/tui-winsource.h: Rename include guard.
7892         * tui/tui-wingeneral.h: Rename include guard.
7893         * tui/tui-windata.h: Rename include guard.
7894         * tui/tui-win.h: Rename include guard.
7895         * tui/tui-stack.h: Rename include guard.
7896         * tui/tui-source.h: Rename include guard.
7897         * tui/tui-regs.h: Rename include guard.
7898         * tui/tui-out.h: Rename include guard.
7899         * tui/tui-layout.h: Rename include guard.
7900         * tui/tui-io.h: Rename include guard.
7901         * tui/tui-hooks.h: Rename include guard.
7902         * tui/tui-file.h: Rename include guard.
7903         * tui/tui-disasm.h: Rename include guard.
7904         * tui/tui-data.h: Rename include guard.
7905         * tui/tui-command.h: Rename include guard.
7906         * tic6x-tdep.h: Add include guard.
7907         * target/waitstatus.h: Rename include guard.
7908         * target/wait.h: Rename include guard.
7909         * target/target.h: Rename include guard.
7910         * target/resume.h: Rename include guard.
7911         * target-float.h: Rename include guard.
7912         * stabsread.h: Add include guard.
7913         * rs6000-tdep.h: Add include guard.
7914         * riscv-fbsd-tdep.h: Add include guard.
7915         * regformats/regdef.h: Rename include guard.
7916         * record.h: Rename include guard.
7917         * python/python.h: Rename include guard.
7918         * python/python-internal.h: Rename include guard.
7919         * python/py-stopevent.h: Rename include guard.
7920         * python/py-ref.h: Rename include guard.
7921         * python/py-record.h: Rename include guard.
7922         * python/py-record-full.h: Rename include guard.
7923         * python/py-record-btrace.h: Rename include guard.
7924         * python/py-instruction.h: Rename include guard.
7925         * python/py-events.h: Rename include guard.
7926         * python/py-event.h: Rename include guard.
7927         * procfs.h: Add include guard.
7928         * proc-utils.h: Add include guard.
7929         * p-lang.h: Add include guard.
7930         * or1k-tdep.h: Rename include guard.
7931         * observable.h: Rename include guard.
7932         * nto-tdep.h: Rename include guard.
7933         * nat/x86-linux.h: Rename include guard.
7934         * nat/x86-linux-dregs.h: Rename include guard.
7935         * nat/x86-gcc-cpuid.h: Add include guard.
7936         * nat/x86-dregs.h: Rename include guard.
7937         * nat/x86-cpuid.h: Rename include guard.
7938         * nat/ppc-linux.h: Rename include guard.
7939         * nat/mips-linux-watch.h: Rename include guard.
7940         * nat/linux-waitpid.h: Rename include guard.
7941         * nat/linux-ptrace.h: Rename include guard.
7942         * nat/linux-procfs.h: Rename include guard.
7943         * nat/linux-osdata.h: Rename include guard.
7944         * nat/linux-nat.h: Rename include guard.
7945         * nat/linux-namespaces.h: Rename include guard.
7946         * nat/linux-btrace.h: Rename include guard.
7947         * nat/glibc_thread_db.h: Rename include guard.
7948         * nat/gdb_thread_db.h: Rename include guard.
7949         * nat/gdb_ptrace.h: Rename include guard.
7950         * nat/fork-inferior.h: Rename include guard.
7951         * nat/amd64-linux-siginfo.h: Rename include guard.
7952         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7953         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7954         * nat/aarch64-linux.h: Rename include guard.
7955         * nat/aarch64-linux-hw-point.h: Rename include guard.
7956         * mn10300-tdep.h: Add include guard.
7957         * mips-linux-tdep.h: Add include guard.
7958         * mi/mi-parse.h: Rename include guard.
7959         * mi/mi-out.h: Rename include guard.
7960         * mi/mi-main.h: Rename include guard.
7961         * mi/mi-interp.h: Rename include guard.
7962         * mi/mi-getopt.h: Rename include guard.
7963         * mi/mi-console.h: Rename include guard.
7964         * mi/mi-common.h: Rename include guard.
7965         * mi/mi-cmds.h: Rename include guard.
7966         * mi/mi-cmd-break.h: Rename include guard.
7967         * m2-lang.h: Add include guard.
7968         * location.h: Rename include guard.
7969         * linux-record.h: Rename include guard.
7970         * linux-nat.h: Add include guard.
7971         * linux-fork.h: Add include guard.
7972         * i386-darwin-tdep.h: Rename include guard.
7973         * hppa-linux-offsets.h: Add include guard.
7974         * guile/guile.h: Rename include guard.
7975         * guile/guile-internal.h: Rename include guard.
7976         * gnu-nat.h: Rename include guard.
7977         * gdb-stabs.h: Rename include guard.
7978         * frv-tdep.h: Add include guard.
7979         * f-lang.h: Add include guard.
7980         * event-loop.h: Add include guard.
7981         * darwin-nat.h: Rename include guard.
7982         * cp-abi.h: Rename include guard.
7983         * config/sparc/nm-sol2.h: Rename include guard.
7984         * config/nm-nto.h: Rename include guard.
7985         * config/nm-linux.h: Add include guard.
7986         * config/i386/nm-i386gnu.h: Rename include guard.
7987         * config/djgpp/nl_types.h: Rename include guard.
7988         * config/djgpp/langinfo.h: Rename include guard.
7989         * compile/gcc-cp-plugin.h: Add include guard.
7990         * compile/gcc-c-plugin.h: Add include guard.
7991         * compile/compile.h: Rename include guard.
7992         * compile/compile-object-run.h: Rename include guard.
7993         * compile/compile-object-load.h: Rename include guard.
7994         * compile/compile-internal.h: Rename include guard.
7995         * compile/compile-cplus.h: Rename include guard.
7996         * compile/compile-c.h: Rename include guard.
7997         * common/xml-utils.h: Rename include guard.
7998         * common/x86-xstate.h: Rename include guard.
7999         * common/version.h: Rename include guard.
8000         * common/vec.h: Rename include guard.
8001         * common/tdesc.h: Rename include guard.
8002         * common/selftest.h: Rename include guard.
8003         * common/scoped_restore.h: Rename include guard.
8004         * common/scoped_mmap.h: Rename include guard.
8005         * common/scoped_fd.h: Rename include guard.
8006         * common/safe-iterator.h: Rename include guard.
8007         * common/run-time-clock.h: Rename include guard.
8008         * common/refcounted-object.h: Rename include guard.
8009         * common/queue.h: Rename include guard.
8010         * common/ptid.h: Rename include guard.
8011         * common/print-utils.h: Rename include guard.
8012         * common/preprocessor.h: Rename include guard.
8013         * common/pathstuff.h: Rename include guard.
8014         * common/observable.h: Rename include guard.
8015         * common/netstuff.h: Rename include guard.
8016         * common/job-control.h: Rename include guard.
8017         * common/host-defs.h: Rename include guard.
8018         * common/gdb_wait.h: Rename include guard.
8019         * common/gdb_vecs.h: Rename include guard.
8020         * common/gdb_unlinker.h: Rename include guard.
8021         * common/gdb_unique_ptr.h: Rename include guard.
8022         * common/gdb_tilde_expand.h: Rename include guard.
8023         * common/gdb_sys_time.h: Rename include guard.
8024         * common/gdb_string_view.h: Rename include guard.
8025         * common/gdb_splay_tree.h: Rename include guard.
8026         * common/gdb_setjmp.h: Rename include guard.
8027         * common/gdb_ref_ptr.h: Rename include guard.
8028         * common/gdb_optional.h: Rename include guard.
8029         * common/gdb_locale.h: Rename include guard.
8030         * common/gdb_assert.h: Rename include guard.
8031         * common/filtered-iterator.h: Rename include guard.
8032         * common/filestuff.h: Rename include guard.
8033         * common/fileio.h: Rename include guard.
8034         * common/environ.h: Rename include guard.
8035         * common/common-utils.h: Rename include guard.
8036         * common/common-types.h: Rename include guard.
8037         * common/common-regcache.h: Rename include guard.
8038         * common/common-inferior.h: Rename include guard.
8039         * common/common-gdbthread.h: Rename include guard.
8040         * common/common-exceptions.h: Rename include guard.
8041         * common/common-defs.h: Rename include guard.
8042         * common/common-debug.h: Rename include guard.
8043         * common/cleanups.h: Rename include guard.
8044         * common/buffer.h: Rename include guard.
8045         * common/btrace-common.h: Rename include guard.
8046         * common/break-common.h: Rename include guard.
8047         * cli/cli-utils.h: Rename include guard.
8048         * cli/cli-style.h: Rename include guard.
8049         * cli/cli-setshow.h: Rename include guard.
8050         * cli/cli-script.h: Rename include guard.
8051         * cli/cli-interp.h: Rename include guard.
8052         * cli/cli-decode.h: Rename include guard.
8053         * cli/cli-cmds.h: Rename include guard.
8054         * charset-list.h: Add include guard.
8055         * buildsym-legacy.h: Rename include guard.
8056         * bfin-tdep.h: Add include guard.
8057         * ax.h: Rename include guard.
8058         * arm-linux-tdep.h: Add include guard.
8059         * arm-fbsd-tdep.h: Add include guard.
8060         * arch/xtensa.h: Rename include guard.
8061         * arch/tic6x.h: Add include guard.
8062         * arch/i386.h: Add include guard.
8063         * arch/arm.h: Rename include guard.
8064         * arch/arm-linux.h: Rename include guard.
8065         * arch/arm-get-next-pcs.h: Rename include guard.
8066         * arch/amd64.h: Add include guard.
8067         * arch/aarch64-insn.h: Rename include guard.
8068         * arch-utils.h: Rename include guard.
8069         * annotate.h: Add include guard.
8070         * amd64-darwin-tdep.h: Rename include guard.
8071         * aarch64-linux-tdep.h: Add include guard.
8072         * aarch64-fbsd-tdep.h: Add include guard.
8073         * aarch32-linux-nat.h: Add include guard.
8074
8075 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8076
8077         * macrotab.c (macro_define_internal): New function that
8078         factorizes macro_define_object_internal and macro_define_function
8079         code.
8080         (macro_define_object_internal): Use macro_define_internal.
8081         (macro_define_function): Likewise.
8082
8083 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8084
8085         * macrocmd.c (extract_identifier): Return
8086         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8087         callers.
8088
8089 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8090
8091         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8092
8093 2019-02-05  Tom Tromey  <tom@tromey.com>
8094
8095         * target.c (target_stack::unpush): Move assertion earlier.
8096
8097 2019-01-30  Tom Tromey  <tom@tromey.com>
8098
8099         PR python/23615:
8100         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8101         (gdbpy_parse_and_eval): Likewise.
8102         * python/python-internal.h (gdbpy_allow_threads): New class.
8103
8104 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8105
8106         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8107         (aarch64_fbsd_fpregmap): Move earlier.
8108         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8109         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8110         instead of individual calls to trad_frame_set_reg_addr.
8111         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8112         earlier.
8113         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8114         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8115         instead of individual calls to trad_frame_set_reg_addr.
8116
8117 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8118
8119         * CONTRIBUTE: Replace contribution list with wiki link.
8120
8121 2019-01-25  Tom Tromey  <tom@tromey.com>
8122
8123         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8124
8125 2019-01-25  Tom Tromey  <tom@tromey.com>
8126
8127         * xtensa-linux-nat.c: Fix common/ includes.
8128         * xml-support.h: Fix common/ includes.
8129         * xml-support.c: Fix common/ includes.
8130         * x86-linux-nat.c: Fix common/ includes.
8131         * windows-nat.c: Fix common/ includes.
8132         * varobj.h: Fix common/ includes.
8133         * varobj.c: Fix common/ includes.
8134         * value.c: Fix common/ includes.
8135         * valops.c: Fix common/ includes.
8136         * utils.c: Fix common/ includes.
8137         * unittests/xml-utils-selftests.c: Fix common/ includes.
8138         * unittests/utils-selftests.c: Fix common/ includes.
8139         * unittests/unpack-selftests.c: Fix common/ includes.
8140         * unittests/tracepoint-selftests.c: Fix common/ includes.
8141         * unittests/style-selftests.c: Fix common/ includes.
8142         * unittests/string_view-selftests.c: Fix common/ includes.
8143         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8144         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8145         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8146         * unittests/rsp-low-selftests.c: Fix common/ includes.
8147         * unittests/parse-connection-spec-selftests.c: Fix common/
8148         includes.
8149         * unittests/optional-selftests.c: Fix common/ includes.
8150         * unittests/offset-type-selftests.c: Fix common/ includes.
8151         * unittests/observable-selftests.c: Fix common/ includes.
8152         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8153         * unittests/memrange-selftests.c: Fix common/ includes.
8154         * unittests/memory-map-selftests.c: Fix common/ includes.
8155         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8156         * unittests/function-view-selftests.c: Fix common/ includes.
8157         * unittests/environ-selftests.c: Fix common/ includes.
8158         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8159         * unittests/common-utils-selftests.c: Fix common/ includes.
8160         * unittests/cli-utils-selftests.c: Fix common/ includes.
8161         * unittests/array-view-selftests.c: Fix common/ includes.
8162         * ui-file.c: Fix common/ includes.
8163         * tui/tui-io.c: Fix common/ includes.
8164         * tracepoint.h: Fix common/ includes.
8165         * tracepoint.c: Fix common/ includes.
8166         * tracefile-tfile.c: Fix common/ includes.
8167         * top.h: Fix common/ includes.
8168         * top.c: Fix common/ includes.
8169         * thread.c: Fix common/ includes.
8170         * target/waitstatus.h: Fix common/ includes.
8171         * target/waitstatus.c: Fix common/ includes.
8172         * target.h: Fix common/ includes.
8173         * target.c: Fix common/ includes.
8174         * target-memory.c: Fix common/ includes.
8175         * target-descriptions.c: Fix common/ includes.
8176         * symtab.h: Fix common/ includes.
8177         * symfile.c: Fix common/ includes.
8178         * stap-probe.c: Fix common/ includes.
8179         * spu-linux-nat.c: Fix common/ includes.
8180         * sparc-nat.c: Fix common/ includes.
8181         * source.c: Fix common/ includes.
8182         * solib.c: Fix common/ includes.
8183         * solib-target.c: Fix common/ includes.
8184         * ser-unix.c: Fix common/ includes.
8185         * ser-tcp.c: Fix common/ includes.
8186         * ser-pipe.c: Fix common/ includes.
8187         * ser-base.c: Fix common/ includes.
8188         * selftest-arch.c: Fix common/ includes.
8189         * s12z-tdep.c: Fix common/ includes.
8190         * rust-exp.y: Fix common/ includes.
8191         * rs6000-aix-tdep.c: Fix common/ includes.
8192         * riscv-tdep.c: Fix common/ includes.
8193         * remote.c: Fix common/ includes.
8194         * remote-notif.h: Fix common/ includes.
8195         * remote-fileio.h: Fix common/ includes.
8196         * remote-fileio.c: Fix common/ includes.
8197         * regcache.h: Fix common/ includes.
8198         * regcache.c: Fix common/ includes.
8199         * record-btrace.c: Fix common/ includes.
8200         * python/python.c: Fix common/ includes.
8201         * python/py-type.c: Fix common/ includes.
8202         * python/py-inferior.c: Fix common/ includes.
8203         * progspace.h: Fix common/ includes.
8204         * producer.c: Fix common/ includes.
8205         * procfs.c: Fix common/ includes.
8206         * proc-api.c: Fix common/ includes.
8207         * printcmd.c: Fix common/ includes.
8208         * ppc-linux-nat.c: Fix common/ includes.
8209         * parser-defs.h: Fix common/ includes.
8210         * osdata.c: Fix common/ includes.
8211         * obsd-nat.c: Fix common/ includes.
8212         * nat/x86-linux.c: Fix common/ includes.
8213         * nat/x86-linux-dregs.c: Fix common/ includes.
8214         * nat/x86-dregs.h: Fix common/ includes.
8215         * nat/x86-dregs.c: Fix common/ includes.
8216         * nat/ppc-linux.c: Fix common/ includes.
8217         * nat/mips-linux-watch.h: Fix common/ includes.
8218         * nat/mips-linux-watch.c: Fix common/ includes.
8219         * nat/linux-waitpid.c: Fix common/ includes.
8220         * nat/linux-ptrace.h: Fix common/ includes.
8221         * nat/linux-ptrace.c: Fix common/ includes.
8222         * nat/linux-procfs.c: Fix common/ includes.
8223         * nat/linux-personality.c: Fix common/ includes.
8224         * nat/linux-osdata.c: Fix common/ includes.
8225         * nat/linux-namespaces.c: Fix common/ includes.
8226         * nat/linux-btrace.h: Fix common/ includes.
8227         * nat/linux-btrace.c: Fix common/ includes.
8228         * nat/fork-inferior.c: Fix common/ includes.
8229         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8230         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8231         * nat/aarch64-linux.c: Fix common/ includes.
8232         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8233         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8234         * namespace.h: Fix common/ includes.
8235         * mips-linux-tdep.c: Fix common/ includes.
8236         * minsyms.c: Fix common/ includes.
8237         * mi/mi-parse.h: Fix common/ includes.
8238         * mi/mi-main.c: Fix common/ includes.
8239         * mi/mi-cmd-env.c: Fix common/ includes.
8240         * memrange.h: Fix common/ includes.
8241         * memattr.c: Fix common/ includes.
8242         * maint.h: Fix common/ includes.
8243         * maint.c: Fix common/ includes.
8244         * main.c: Fix common/ includes.
8245         * machoread.c: Fix common/ includes.
8246         * location.c: Fix common/ includes.
8247         * linux-thread-db.c: Fix common/ includes.
8248         * linux-nat.c: Fix common/ includes.
8249         * linux-fork.c: Fix common/ includes.
8250         * inline-frame.c: Fix common/ includes.
8251         * infrun.c: Fix common/ includes.
8252         * inflow.c: Fix common/ includes.
8253         * inferior.h: Fix common/ includes.
8254         * inferior.c: Fix common/ includes.
8255         * infcmd.c: Fix common/ includes.
8256         * inf-ptrace.c: Fix common/ includes.
8257         * inf-child.c: Fix common/ includes.
8258         * ia64-linux-nat.c: Fix common/ includes.
8259         * i387-tdep.c: Fix common/ includes.
8260         * i386-tdep.c: Fix common/ includes.
8261         * i386-linux-tdep.c: Fix common/ includes.
8262         * i386-linux-nat.c: Fix common/ includes.
8263         * i386-go32-tdep.c: Fix common/ includes.
8264         * i386-fbsd-tdep.c: Fix common/ includes.
8265         * i386-fbsd-nat.c: Fix common/ includes.
8266         * guile/scm-type.c: Fix common/ includes.
8267         * guile/guile.c: Fix common/ includes.
8268         * go32-nat.c: Fix common/ includes.
8269         * gnu-nat.c: Fix common/ includes.
8270         * gdbthread.h: Fix common/ includes.
8271         * gdbarch-selftests.c: Fix common/ includes.
8272         * gdb_usleep.c: Fix common/ includes.
8273         * gdb_select.h: Fix common/ includes.
8274         * gdb_bfd.c: Fix common/ includes.
8275         * gcore.c: Fix common/ includes.
8276         * fork-child.c: Fix common/ includes.
8277         * findvar.c: Fix common/ includes.
8278         * fbsd-nat.c: Fix common/ includes.
8279         * event-top.c: Fix common/ includes.
8280         * event-loop.c: Fix common/ includes.
8281         * dwarf2read.c: Fix common/ includes.
8282         * dwarf2loc.c: Fix common/ includes.
8283         * dwarf2-frame.c: Fix common/ includes.
8284         * dwarf-index-cache.c: Fix common/ includes.
8285         * dtrace-probe.c: Fix common/ includes.
8286         * disasm-selftests.c: Fix common/ includes.
8287         * defs.h: Fix common/ includes.
8288         * csky-tdep.c: Fix common/ includes.
8289         * cp-valprint.c: Fix common/ includes.
8290         * cp-support.h: Fix common/ includes.
8291         * cp-support.c: Fix common/ includes.
8292         * corelow.c: Fix common/ includes.
8293         * completer.h: Fix common/ includes.
8294         * completer.c: Fix common/ includes.
8295         * compile/compile.c: Fix common/ includes.
8296         * compile/compile-loc2c.c: Fix common/ includes.
8297         * compile/compile-cplus-types.c: Fix common/ includes.
8298         * compile/compile-cplus-symbols.c: Fix common/ includes.
8299         * command.h: Fix common/ includes.
8300         * cli/cli-dump.c: Fix common/ includes.
8301         * cli/cli-cmds.c: Fix common/ includes.
8302         * charset.c: Fix common/ includes.
8303         * build-id.c: Fix common/ includes.
8304         * btrace.h: Fix common/ includes.
8305         * btrace.c: Fix common/ includes.
8306         * breakpoint.h: Fix common/ includes.
8307         * breakpoint.c: Fix common/ includes.
8308         * ax.h:
8309         (enum agent_op): Fix common/ includes.
8310         * ax-general.c (struct aop_map): Fix common/ includes.
8311         * ax-gdb.c: Fix common/ includes.
8312         * auxv.c: Fix common/ includes.
8313         * auto-load.c: Fix common/ includes.
8314         * arm-tdep.c: Fix common/ includes.
8315         * arch/riscv.c: Fix common/ includes.
8316         * arch/ppc-linux-common.c: Fix common/ includes.
8317         * arch/i386.c: Fix common/ includes.
8318         * arch/arm.c: Fix common/ includes.
8319         * arch/arm-linux.c: Fix common/ includes.
8320         * arch/arm-get-next-pcs.c: Fix common/ includes.
8321         * arch/amd64.c: Fix common/ includes.
8322         * arch/aarch64.c: Fix common/ includes.
8323         * arch/aarch64-insn.c: Fix common/ includes.
8324         * arch-utils.c: Fix common/ includes.
8325         * amd64-windows-tdep.c: Fix common/ includes.
8326         * amd64-tdep.c: Fix common/ includes.
8327         * amd64-sol2-tdep.c: Fix common/ includes.
8328         * amd64-obsd-tdep.c: Fix common/ includes.
8329         * amd64-nbsd-tdep.c: Fix common/ includes.
8330         * amd64-linux-tdep.c: Fix common/ includes.
8331         * amd64-linux-nat.c: Fix common/ includes.
8332         * amd64-fbsd-tdep.c: Fix common/ includes.
8333         * amd64-fbsd-nat.c: Fix common/ includes.
8334         * amd64-dicos-tdep.c: Fix common/ includes.
8335         * amd64-darwin-tdep.c: Fix common/ includes.
8336         * agent.c: Fix common/ includes.
8337         * ada-lang.h: Fix common/ includes.
8338         * ada-lang.c: Fix common/ includes.
8339         * aarch64-tdep.c: Fix common/ includes.
8340
8341 2019-01-25  Tom Tromey  <tom@tromey.com>
8342
8343         * common/create-version.sh: Use common/version.h.
8344
8345 2019-01-24  Pedro Alves  <palves@redhat.com>
8346
8347         * infrun.c (signal_stop, signal_print, signal_program)
8348         (signal_catch, signal_pass): Now arrays instead of pointers.
8349         (update_signals_program_target, do_target_resume)
8350         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8351         * linux-nat.c (linux_nat_target::pass_signals)
8352         (linux_nat_target::create_inferior, linux_nat_target::attach):
8353         Adjust.
8354         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8355         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8356         * procfs.c (procfs_target::pass_signals): Adjust.
8357         * record-full.c (record_full_target::resume): Adjust.
8358         * remote.c (remote_target::pass_signals)
8359         (remote_target::program_signals): Adjust.
8360         * target-debug.h (target_debug_print_signals): Now takes a
8361         gdb::array_view as parameter.  Adjust.
8362         * target.h (target_ops) <pass_signals, program_signals>: Replace
8363         pointer and length parameters with gdb::array_view.
8364         (target_pass_signals, target_program_signals): Likewise.
8365         * target-delegates.c: Regenerate.
8366
8367 2019-01-24  Pedro Alves  <palves@redhat.com>
8368
8369         * common/forward-scope-exit.h
8370         (forward_scope_exit::forward_scope_exit): Pass arguments to
8371         m_bind_function directly, instead of creating a std::bind and
8372         copying that.
8373
8374 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8375
8376         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8377         for static members.
8378         (pass_in_v_vfp_candidate): Likewise.
8379
8380 2019-01-23  Tom Tromey  <tom@tromey.com>
8381             Pedro Alves  <palves@redhat.com>
8382
8383         * regcache.c (class regcache_invalidator): Remove.
8384         (regcache::raw_write): Use make_scope_exit.
8385
8386 2019-01-23  Tom Tromey  <tom@tromey.com>
8387
8388         * ui-out.h (class ui_out_emit_type): Update comment.
8389
8390 2019-01-23  Tom Tromey  <tom@tromey.com>
8391
8392         * infrun.c (fetch_inferior_event): Update comment.
8393
8394 2019-01-23  Tom Tromey  <tom@tromey.com>
8395             Pedro Alves  <palves@redhat.com>
8396
8397         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8398         parameter.
8399         (fetch_inferior_event): Use SCOPE_EXIT.
8400
8401
8402 2019-01-23  Tom Tromey  <tom@tromey.com>
8403             Pedro Alves  <palves@redhat.com>
8404
8405         * infrun.c (disable_thread_events): Delete.
8406         (stop_all_threads): Use SCOPE_EXIT.
8407
8408 2019-01-23  Tom Tromey  <tom@tromey.com>
8409             Pedro Alves  <palves@redhat.com>
8410
8411         * symfile.c: Include forward-scope-exit.h.
8412         (clear_symtab_users_cleanup): Replace forward declaration with
8413         a FORWARD_SCOPE_EXIT.
8414         (syms_from_objfile_1): Use the forward_scope_exit and
8415         gdb::optional instead of cleanup_function.
8416         (reread_symbols): Use the forward_scope_exit instead of
8417         cleanup_function.
8418         (clear_symtab_users_cleanup): Remove function.
8419
8420 2019-01-23  Tom Tromey  <tom@tromey.com>
8421             Pedro Alves  <palves@redhat.com>
8422
8423         * linux-nat.c: Include scope-exit.h.
8424         (cleanup_target_stop): Remove.
8425         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8426         SCOPE_EXIT.
8427
8428 2019-01-23  Tom Tromey  <tom@tromey.com>
8429             Pedro Alves  <palves@redhat.com>
8430
8431         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8432         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8433
8434 2019-01-23  Tom Tromey  <tom@tromey.com>
8435             Andrew Burgess  <andrew.burgess@embecosm.com>
8436             Pedro Alves  <palves@redhat.com>
8437
8438         * infrun.c (fetch_inferior_event): Use scope_exit.
8439         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8440         * top.c (execute_command): Use scope_exit.
8441         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8442         * utils.c (do_bpstat_clear_actions_cleanup)
8443         (make_bpstat_clear_actions_cleanup): Remove.
8444
8445 2019-01-23  Tom Tromey  <tom@tromey.com>
8446             Pedro Alves  <palves@redhat.com>
8447
8448         * infrun.c: Include "common/scope-exit.h"
8449         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8450         (wait_for_inferior): Use SCOPE_EXIT.
8451         (fetch_inferior_event): Use scope_exit.
8452
8453 2019-01-23  Tom Tromey  <tom@tromey.com>
8454             Pedro Alves  <palves@redhat.com>
8455
8456         * breakpoint.c (create_breakpoint): Remove cleanup.
8457
8458 2019-01-23  Tom Tromey  <tom@tromey.com>
8459             Andrew Burgess  <andrew.burgess@embecosm.com>
8460             Pedro Alves  <palves@redhat.com>
8461
8462 2019-01-23  Pedro Alves  <palves@redhat.com>
8463
8464         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8465
8466 2019-01-23  Pedro Alves  <palves@redhat.com>
8467             Andrew Burgess  <andrew.burgess@embecosm.com>
8468
8469         * gdbthread.h: Include "common/forward-scope-exit.h".
8470         (scoped_finish_thread_state): Redefine custom class in terms of
8471         forward_scope_exit.
8472
8473 2019-01-23  Pedro Alves  <palves@redhat.com>
8474             Andrew Burgess  <andrew.burgess@embecosm.com>
8475
8476         * common/forward-scope-exit.h: New file.
8477
8478 2019-01-23  Pedro Alves  <palves@redhat.com>
8479             Andrew Burgess  <andrew.burgess@embecosm.com>
8480             Tom Tromey  <tom@tromey.com>
8481
8482         * common/scope-exit.h: New file.
8483
8484 2019-01-23  Pedro Alves  <palves@redhat.com>
8485
8486         * common/preprocessor.h (ESC): Rename to ...
8487         (ESC_PARENS): ... this.
8488         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8489         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8490
8491 2019-01-23  Tom Tromey  <tom@tromey.com>
8492
8493         * language.h (class scoped_switch_to_sym_language_if_auto):
8494         Initialize m_lang in both cases.
8495
8496 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8497
8498         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8499         with XCNEW.
8500
8501 2019-01-22  Tom Tromey  <tom@tromey.com>
8502
8503         * corelow.c: Do not include sys/file.h.
8504
8505 2019-01-22  Tom Tromey  <tom@tromey.com>
8506
8507         * tui/tui-wingeneral.h: Include gdb_curses.h.
8508
8509 2019-01-22  Tom Tromey  <tom@tromey.com>
8510
8511         * source-cache.h (class source_cache) <get_source_lines,
8512         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8513
8514 2019-01-22  Tom Tromey  <tom@tromey.com>
8515
8516         * remote-fileio.h (struct remote_target): Declare.
8517
8518 2019-01-22  Tom Tromey  <tom@tromey.com>
8519
8520         * python/py-arch.c: Do not include py-ref.h.
8521         * python/py-bpevent.c: Do not include py-ref.h.
8522         * python/py-cmd.c: Do not include py-ref.h.
8523         * python/py-continueevent.c: Do not include py-ref.h.
8524         * python/py-event.h: Do not include py-ref.h.
8525         * python/py-evtregistry.c: Do not include py-ref.h.
8526         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8527         * python/py-frame.c: Do not include py-ref.h.
8528         * python/py-framefilter.c: Do not include py-ref.h.
8529         * python/py-function.c: Do not include py-ref.h.
8530         * python/py-infevents.c: Do not include py-ref.h.
8531         * python/py-linetable.c: Do not include py-ref.h.
8532         * python/py-objfile.c: Do not include py-ref.h.
8533         * python/py-param.c: Do not include py-ref.h.
8534         * python/py-prettyprint.c: Do not include py-ref.h.
8535         * python/py-progspace.c: Do not include py-ref.h.
8536         * python/py-symbol.c: Do not include py-ref.h.
8537         * python/py-symtab.c: Do not include py-ref.h.
8538         * python/py-type.c: Do not include py-ref.h.
8539         * python/py-unwind.c: Do not include py-ref.h.
8540         * python/py-utils.c: Do not include py-ref.h.
8541         * python/py-value.c: Do not include py-ref.h.
8542         * python/py-varobj.c: Do not include py-ref.h.
8543         * python/py-xmethods.c: Do not include py-ref.h.
8544         * python/python.c: Do not include py-ref.h.
8545         * varobj.c: Do not include py-ref.h.
8546
8547 2019-01-22  Tom Tromey  <tom@tromey.com>
8548
8549         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8550         keyword for bcache.
8551
8552 2019-01-22  Tom Tromey  <tom@tromey.com>
8553
8554         * compile/compile-cplus-types.c: Remove a comment by #include.
8555
8556 2019-01-22  Tom Tromey  <tom@tromey.com>
8557
8558         * compile/gcc-c-plugin.h: Include compile-internal.h.
8559
8560 2019-01-22  Tom Tromey  <tom@tromey.com>
8561
8562         * stabsread.c (EXTERN): Do not define.
8563         (symnum, next_symbol_text_func, processing_gcc_compilation)
8564         (within_function, global_sym_chain, global_stabs)
8565         (previous_stab_code, this_object_header_files)
8566         (n_this_object_header_files)
8567         (n_allocated_this_object_header_files): Define.
8568         * stabsread.h (EXTERN): Never define.  Use "extern".
8569
8570 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8571
8572         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8573         history_value.
8574
8575 2019-01-21  Tom Tromey  <tom@tromey.com>
8576
8577         * ui-out.c: Fix includes.
8578         * tui/tui-source.c: Fix includes.
8579         * target.c: Fix includes.
8580         * remote.c: Fix includes.
8581         * regcache.c: Fix includes.
8582         * python/py-block.c: Fix includes.
8583         * printcmd.c: Fix includes.
8584         * or1k-tdep.c: Fix includes.
8585         * mi/mi-main.c: Fix includes.
8586         * m32r-tdep.c: Fix includes.
8587         * csky-tdep.c: Fix includes.
8588         * compile/compile-cplus-types.c: Fix includes.
8589         * cli/cli-interp.c: Fix includes.
8590
8591 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8592
8593         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8594         for padding.
8595
8596 2019-01-16  Tom Tromey  <tom@tromey.com>
8597
8598         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8599         earlier.
8600         (struct objfile) <msymbols_range>: Move from top level.
8601         <msymbols>: New method.
8602         (class objfile_msymbols): Remove.
8603         * symtab.c (default_collect_symbol_completion_matches_break_on):
8604         Update.
8605         * symmisc.c (dump_msymbols): Update.
8606         * stabsread.c (scan_file_globals): Update.
8607         * objc-lang.c (info_selectors_command, info_classes_command)
8608         (find_methods): Update.
8609         * minsyms.c (find_solib_trampoline_target): Update.
8610         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8611         * coffread.c (coff_symfile_read): Update.
8612         * ada-lang.c (ada_lookup_simple_minsym)
8613         (ada_collect_symbol_completion_matches): Update.
8614
8615 2019-01-16  Tom Tromey  <tom@tromey.com>
8616
8617         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8618         type.  Remove no-argument constructor.
8619         <iterator::operator++>: Simplify.
8620         <begin>: Update.
8621         <end>: Use minimal_symbol_count.
8622
8623 2019-01-16  Tom Tromey  <tom@tromey.com>
8624
8625         * objfiles.h (struct objfile) <psymtabs>: New method.
8626         (class objfile_psymtabs): Remove.
8627         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8628         typedef.
8629         <range>: New method.
8630         (require_partial_symbols): Change return type.
8631         * psymtab.c (require_partial_symbols)
8632         (psym_expand_symtabs_matching): Update.
8633         * mdebugread.c (parse_partial_symbols): Update.
8634         * dbxread.c (dbx_end_psymtab): Update.
8635
8636 2019-01-15  Tom Tromey  <tom@tromey.com>
8637
8638         * symtab.c (lookup_objfile_from_block)
8639         (lookup_symbol_in_objfile_symtabs)
8640         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8641         (find_line_symtab, info_sources_command)
8642         (default_collect_symbol_completion_matches_break_on)
8643         (make_source_files_completion_list): Update.
8644         * symmisc.c (print_objfile_statistics, dump_objfile)
8645         (maintenance_print_symbols, maintenance_info_symtabs)
8646         (maintenance_check_symtabs, maintenance_info_line_tables):
8647         Update.
8648         * source.c (select_source_symtab)
8649         (forget_cached_source_info_for_objfile): Update.
8650         * objfiles.h (class objfile_compunits): Remove.
8651         (struct objfile) <compunits_range>: New typedef.
8652         (compunits): New method.
8653         * objfiles.c (objfile_relocate1): Update.
8654         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8655         * maint.c (count_symtabs_and_blocks): Update.
8656         * linespec.c (iterate_over_all_matching_symtabs): Update.
8657         * cp-support.c (add_symbol_overload_list_qualified): Update.
8658         * coffread.c (coff_symtab_read): Update.
8659         * ada-lang.c (add_nonlocal_symbols)
8660         (ada_collect_symbol_completion_matches)
8661         (ada_add_global_exceptions): Update.
8662
8663 2019-01-15  Tom Tromey  <tom@tromey.com>
8664
8665         * progspace.h (program_space) <objfiles_safe_range>: New
8666         typedef.
8667         <objfiles_safe>: New method.
8668         * objfiles.h (class all_objfiles_safe): Remove.
8669         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8670         * jit.c (jit_inferior_exit_hook): Update.
8671
8672 2019-01-17  Tom Tromey  <tom@tromey.com>
8673
8674         * progspace.h (program_space) <objfiles_range>: New typedef.
8675         <objfiles>: New method.
8676         <objfiles_head>: Rename from objfiles.
8677         (object_files): Update.
8678         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8679         * guile/scm-pretty-print.c
8680         (ppscm_find_pretty_printer_from_objfiles): Update.
8681         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8682         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8683         Update.
8684         * python/py-progspace.c (pspy_get_objfiles): Update.
8685         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8686         Update.
8687         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8688         (objfpy_lookup_objfile_by_build_id): Update.
8689         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8690         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8691         Update.
8692         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8693         (expand_symtab_containing_pc, lookup_objfile_from_block)
8694         (lookup_static_symbol, basic_lookup_transparent_type)
8695         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8696         (find_line_symtab, info_sources_command)
8697         (default_collect_symbol_completion_matches_break_on)
8698         (make_source_files_completion_list, find_main_name): Update.
8699         * symmisc.c (print_symbol_bcache_statistics)
8700         (print_objfile_statistics, maintenance_print_symbols)
8701         (maintenance_print_msymbols, maintenance_print_objfiles)
8702         (maintenance_info_symtabs, maintenance_check_symtabs)
8703         (maintenance_expand_symtabs, maintenance_info_line_tables):
8704         Update.
8705         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8706         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8707         (map_overlay_command, unmap_overlay_command)
8708         (simple_overlay_update, expand_symtabs_matching)
8709         (map_symbol_filenames): Update.
8710         * symfile-debug.c (set_debug_symfile): Update.
8711         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8712         Update.
8713         * source.c (select_source_symtab, forget_cached_source_info):
8714         Update.
8715         * solib.c (solib_read_symbols): Update.
8716         * solib-spu.c (append_ocl_sos): Update.
8717         * psymtab.c (maintenance_print_psymbols)
8718         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8719         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8720         * printcmd.c (info_symbol_command): Update.
8721         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8722         Update.
8723         * objfiles.h (class all_objfiles): Remove.
8724         * objfiles.c (have_partial_symbols, have_full_symbols)
8725         (have_minimal_symbols, qsort_cmp, update_section_map)
8726         (shared_objfile_contains_address_p)
8727         (default_iterate_over_objfiles_in_search_order): Update.
8728         * objc-lang.c (info_selectors_command, info_classes_command)
8729         (find_methods): Update.
8730         * minsyms.c (find_solib_trampoline_target): Update.
8731         * maint.c (maintenance_info_sections)
8732         (maintenance_translate_address, count_symtabs_and_blocks):
8733         Update.
8734         * main.c (captured_main_1): Update.
8735         * linux-thread-db.c (try_thread_db_load_from_pdir)
8736         (has_libpthread): Update.
8737         * linespec.c (iterate_over_all_matching_symtabs)
8738         (search_minsyms_for_name): Update.
8739         * jit.c (jit_find_objf_with_entry_addr): Update.
8740         * hppa-tdep.c (find_unwind_entry)
8741         (hppa_lookup_stub_minimal_symbol): Update.
8742         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8743         Update.
8744         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8745         (elf_gnu_ifunc_resolve_by_got): Update.
8746         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8747         * dwarf-index-write.c (save_gdb_index_command): Update.
8748         * cp-support.c (add_symbol_overload_list_qualified): Update.
8749         * breakpoint.c (create_overlay_event_breakpoint)
8750         (create_longjmp_master_breakpoint)
8751         (create_std_terminate_master_breakpoint)
8752         (create_exception_master_breakpoint): Update.
8753         * blockframe.c (find_pc_partial_function): Update.
8754         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8755         (ada_collect_symbol_completion_matches)
8756         (ada_add_global_exceptions): Update.
8757
8758 2019-01-17  Tom Tromey  <tom@tromey.com>
8759
8760         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8761         declare VEC.
8762         (solib_target_parse_libraries): Change return type.
8763         (library_list_start_segment, library_list_start_section)
8764         (library_list_end_library, library_list_start_library); Update.
8765         (solib_target_free_library_list): Remove.
8766         (solib_target_parse_libraries): Remove cleanup.  Change return
8767         type.
8768         (solib_target_current_sos): Update.
8769
8770 2019-01-17  Tom Tromey  <tromey@bapiya>
8771
8772         * valprint.c: Replace "the the" with "the".
8773         * symtab.c: Replace "the the" with "the".
8774         * solib.c: Replace "the the" with "the".
8775         * solib-dsbt.c: Replace "the the" with "the".
8776         * linespec.c: Replace "the the" with "the".
8777         * dwarf2loc.h: Replace "the the" with "the".
8778         * amd64-windows-tdep.c: Replace "the the" with "the".
8779         * aarch64-tdep.c: Replace "the the" with "the".
8780
8781 2019-01-16  Keith Seitz  <keiths@redhat.com>
8782
8783         PR gdb/23773
8784         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8785         <builder>: Rename to ..
8786         <m_builder>: ... this and make private.
8787         (dwarf2_cu::get_builder): New method.  Change all users of
8788         `builder' to use this method.
8789         (dwarf2_start_symtab): Move to ...
8790         (dwarf2_cu::start_symtab): ... here.  Update all callers
8791         (setup_type_unit_groups): Move to ...
8792         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8793         callers.
8794         (dwarf2_cu::reset_builder): New method.
8795         (process_full_compunit, process_full_type_unit): Use
8796         dwarf2_cu::reset_builder.
8797         (follow_die_offset): Record the ancestor CU if it is different
8798         from the followed DIE's CU.
8799         (follow_die_sig_1): Likewise.
8800
8801 2019-01-15  Tom Tromey  <tom@tromey.com>
8802
8803         * remote.c (class remote_state) <buf>: Now a char_vector.
8804         <buf_size>: Remove.
8805         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8806         parameter.
8807         (remote_target::getpkt_or_notif_sane_1)
8808         (remote_target::getpkt_sane)
8809         (remote_target::getpkt_or_notif_sane): Likewise.
8810         (class remote_target) <putpkt>: New overload.
8811         (remote_target::read_frame): Change type of "buf_p".  Remove
8812         sizeof_p parameter.
8813         (packet_ok): New overload.
8814         (packet_check_result): New overload.
8815         Update all uses.
8816
8817 2019-01-14  Tom Tromey  <tom@tromey.com>
8818
8819         * remote-notif.c (handle_notification, remote_notif_ack)
8820         (remote_notif_parse): Make "buf" const.
8821         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8822         const.
8823         (remote_notif_parse, remote_notif_ack, handle_notification):
8824         Likewise.
8825         * remote.c (remote_notif_stop_parse): Make "buf" const.
8826         (remote_target::remote_parse_stop_reply): Make "buf" const.
8827         (remote_notif_stop_ack): Make "buf" const.
8828
8829 2019-01-14  Tom Tromey  <tom@tromey.com>
8830
8831         * remote.c (remote_console_output): Make parameter const.
8832
8833 2019-01-14  Tom Tromey  <tom@tromey.com>
8834
8835         * target-debug.h (target_debug_print_signals): Constify.
8836         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8837         * procfs.c (procfs_target::pass_signals): Update.
8838         * linux-nat.c (linux_nat_target::pass_signals): Update.
8839         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8840         * target-delegates.c: Rebuild.
8841         * remote.c (remote_target::program_signals): Update.
8842         (remote_target::pass_signals): Update.
8843         * target.c (target_pass_signals): Constify argument.
8844         (target_program_signals): Likewise.
8845         * target.h (struct target_ops) <pass_signals, program_signals>:
8846         Constify argument.
8847         (target_pass_signals, target_program_signals): Constify argument.
8848
8849 2019-01-14  Tom Tromey  <tom@tromey.com>
8850
8851         PR tui/28819:
8852         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8853
8854 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8855
8856         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8857         field.
8858         * rs6000-tdep.c: Include reggroups.h.
8859         (IS_V_ALIAS_PSEUDOREG): Define.
8860         (rs6000_register_name): Return names for the "vX" aliases.
8861         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8862         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8863         aliases.  Call default_register_reggroup_p for all other
8864         pseudo-registers.
8865         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8866         New functions.
8867         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8868         Handle "vX" aliases.
8869         (v_alias_pseudo_register_collect): New function.
8870         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8871         (rs6000_gdbarch_init): Initialize "vX" aliases as
8872         pseudo-registers.  Restore registration of
8873         rs6000_pseudo_register_reggroup_p with
8874         set_tdesc_pseudo_register_reggroup_p.
8875
8876 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8877
8878         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8879         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8880         set_gdbarch_num_pseudo_regs.
8881
8882 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8883
8884         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8885         Remove arg prefixname, add do_set and do_show.
8886         Add member functions set_list and show_list.
8887         * cli/cli-style.c (class cli_style_option): Update accordingly.
8888         (style_set_list): Move to file scope.
8889         (style_show_list): Likewise.
8890         (set_style): Call help_list.
8891         (show_style): Call cmd_show_list.
8892         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8893         Update to use the new macro.
8894
8895 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8896
8897         * ada-lang.c (_initialize_ada_language): Expand the help text
8898         for the "catch exception" command.
8899
8900 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8901
8902         * symtab.c (matching_obj_sections): Initialize obj,
8903         declare it closer to its usage.
8904
8905 2019-01-10  Tom Tromey  <tom@tromey.com>
8906
8907         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8908         (basic_inf_threads_range): Remove.
8909         (inf_threads_range, inf_non_exited_threads_range)
8910         (safe_inf_threads_range): Use next_adapter.
8911
8912 2019-01-10  Keith Seitz  <keiths@redhat.com>
8913
8914         PR gdb/23712
8915         PR symtab/23010
8916         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8917         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8918
8919 2019-01-10  Keith Seitz  <keiths@redhat.com>
8920
8921         PR gdb/23712
8922         PR symtab/23010
8923         * dictionary.c (pending_to_vector): Remove.
8924         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8925         Remove _1 suffix, replacing functions of the same name.  Update
8926         all callers.
8927         (dict_create_hashed, dict_create_hashed_expandable)
8928         (dict_create_linear, dict_create_linear_expandable, dict_free)
8929         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8930         Make functions static.
8931
8932 2019-01-10  Keith Seitz  <keiths@redhat.com>
8933
8934         PR gdb/23712
8935         PR symtab/23010
8936         * dictionary.h (struct dictionary): Replace declaration with
8937         multidictionary.
8938         (dict_create_hashed, dict_create_hashed_expandable)
8939         (dict_create_linear, dict_create_linear_expandable)
8940         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8941         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8942         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8943         taking multidictionary argument.
8944         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8945         * block.h (struct block) <dict>: Change to multidictionary
8946         and rename `multidict'.
8947         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8948         symmisc.c: Update all dictionary references to multidictionary.
8949
8950 2019-01-10  Keith Seitz  <keiths@redhat.com>
8951
8952         PR gdb/23712
8953         PR symtab/23010
8954         * dictionary.c: Include unordered_map.
8955         (pending_to_vector): New function.
8956         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8957         Rewrite the non-"_1" functions to take vector instead
8958         of linked list.
8959         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8960         "new" _1 versions of the same name.
8961         (multidictionary): Define.
8962         (std::hash<enum language): New definition.
8963         (collate_pending_symbols_by_language, mdict_create_hashed)
8964         (mdict_create_hashed_expandable, mdict_create_linear)
8965         (mdict_create_linear_expandable, mdict_free)
8966         (find_language_dictionary, create_new_language_dictionary)
8967         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8968         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8969         (mdict_size, mdict_empty): New functions.
8970         * dictionary.h (mdict_iterator): Define.
8971
8972 2019-01-10  Pedro Alves  <palves@redhat.com>
8973
8974         * breakpoint.c (read_uploaded_action)
8975         (create_tracepoint_from_upload): Adjust to use
8976         gdb::unique_xmalloc_ptr.
8977         * ctf.c (ctf_write_uploaded_tp):
8978         (SET_ARRAY_FIELD): Use emplace_back.
8979         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8980         * tracefile-tfile.c (tfile_write_uploaded_tp):
8981         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8982         gdb::unique_xmalloc_ptr.
8983         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8984         at_string, cond_string, cmd_strings>: Replace char pointers
8985         with gdb::unique_xmalloc_ptr.
8986
8987 2019-01-10  Pedro Alves  <palves@redhat.com>
8988
8989         * solib-target.c (library_list_start_library): Don't xstrdup name.
8990
8991 2019-01-10  Pedro Alves  <palves@redhat.com>
8992
8993         * mdebugread.c (parse_partial_symbols): Use
8994         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8995
8996 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8997
8998         * linux-fork.c (scoped_switch_fork_info)
8999         <~scoped_switch_fork_info>: Fix incorrect variable name.
9000
9001 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9002
9003         * linux-fork.c (scoped_switch_fork_info)
9004         <scoped_switch_fork_info>: Make explicit.
9005         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9006
9007 2019-01-10  Tom Tromey  <tom@tromey.com>
9008
9009         * objfiles.h (objfile::reset_psymtabs): Update.
9010         * objfiles.c (objfile::objfile): Update.
9011         * psymtab.h (psymtab_storage::obstack): Update.
9012         (psymtab_storage::m_obstack): Use gdb::optional.
9013         (class psymtab_storage): Update comment.  Remove objfile
9014         parameter.
9015         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9016
9017 2019-01-10  Tom Tromey  <tom@tromey.com>
9018
9019         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9020         <free_psymtabs>: Now private.
9021         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9022         (allocate_psymtab): Use new method.
9023
9024 2019-01-10  Tom Tromey  <tom@tromey.com>
9025
9026         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9027         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9028         * mdebugread.c (parse_partial_symbols): Use
9029         allocate_dependencies.
9030         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9031         allocate_dependencies.
9032         (process_psymtab_comp_unit_reader)
9033         (build_type_psymtab_dependencies): Likewise.
9034         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9035
9036 2019-01-10  Tom Tromey  <tom@tromey.com>
9037
9038         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9039         PSYMBOL_SET_LANGUAGE.
9040         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9041
9042 2019-01-10  Tom Tromey  <tom@tromey.com>
9043
9044         * psymtab.h (psymtab_storage::obstack): New method.
9045         <m_obstack>: Rename from obstack; now private.
9046         * psymtab.c (psymtab_storage): Update.
9047         * dwarf2read.c (create_addrmap_from_index)
9048         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9049         Update.
9050
9051 2019-01-10  Tom Tromey  <tom@tromey.com>
9052
9053         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9054         * objfiles.h (objfile::reset_psymtabs): New method.
9055
9056 2019-01-10  Tom Tromey  <tom@tromey.com>
9057
9058         * symmisc.c (print_symbol_bcache_statistics): Update.
9059         (print_objfile_statistics): Update.
9060         * symfile.c (reread_symbols): Update.
9061         * psymtab.h (class psymtab_storage): New.
9062         * psymtab.c (psymtab_storage): New constructor.
9063         (~psymtab_storage): New destructor.
9064         (require_partial_symbols): Update.
9065         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9066         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9067         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9068         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9069         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9070         (start_psymtab_common, end_psymtab_common)
9071         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9072         (allocate_psymtab): Update.
9073         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9074         Update.
9075         (dump_psymtab_addrmap, maintenance_print_psymbols)
9076         (maintenance_check_psymtabs): Update.
9077         (class objfile_psymtabs): Move to objfiles.h.
9078         * psympriv.h (discard_psymtab): Now inline.
9079         (psymtab_discarder::psymtab_discarder): Update.
9080         (psymtab_discarder::~psymtab_discarder): Update.
9081         (ALL_OBJFILE_PSYMTABS): Rewrite.
9082         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9083         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9084         Remove fields.
9085         <partial_symtabs>: New field.
9086         (class objfile_psymtabs): Move from psymtab.h.  Update.
9087         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9088         psymbol_cache.
9089         (objfile::~objfile): Don't destroy psymbol_cache.
9090         * mdebugread.c (parse_partial_symbols): Update.
9091         * dwarf2read.c (create_addrmap_from_index)
9092         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9093         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9094         (add_partial_subprogram, dwarf2_ranges_read): Update.
9095         * dwarf-index-write.c (write_address_map)
9096         (write_one_signatured_type, recursively_write_psymbols)
9097         (class debug_names, class debug_names, write_psymtabs_to_index):
9098         Update.
9099
9100 2019-01-10  Tom Tromey  <tom@tromey.com>
9101
9102         * symtab.h (SYMBOL_SET_NAMES): Update.
9103         (symbol_set_names): Update.
9104         (MSYMBOL_SET_NAMES): Update.
9105         * symtab.c (symbol_set_names): Change argument to be an
9106         objfile_per_bfd_storage.
9107         * psymtab.c (add_psymbol_to_bcache): Update.
9108         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9109
9110 2019-01-10  Tom Tromey  <tom@tromey.com>
9111
9112         * symtab.c (create_demangled_names_hash): Change argument to be an
9113         objfile_per_bfd_storage.
9114         (symbol_set_names): Update.
9115
9116 2019-01-10  Tom Tromey  <tom@tromey.com>
9117
9118         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9119         init_psymbol_list.
9120         * psymtab.c (init_psymbol_list): Do nothing if already called.
9121         * psympriv.h (init_psymbol_list): Add comment.
9122         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9123         init_psymbol_list.
9124         * dbxread.c (dbx_symfile_read): Unconditionally call
9125         init_psymbol_list.
9126
9127 2019-01-10  Tom Tromey  <tom@tromey.com>
9128
9129         * xcoffread.c (scan_xcoff_symtab): Update.
9130         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9131         "where".
9132         * mdebugread.c (parse_partial_symbols)
9133         (handle_psymbol_enumerators): Update.
9134         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9135         * dbxread.c (read_dbx_symtab): Update.
9136         * psympriv.h (psymbol_placement): New enum.
9137         (add_psymbol_to_list): Update.
9138
9139 2019-01-10  Tom Tromey  <tom@tromey.com>
9140
9141         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9142         static_psymbols parameters.
9143         (scan_xcoff_symtab): Update.
9144         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9145         static_psymbols parameters.
9146         * psympriv.h (start_psymtab_common): Update.
9147         * mdebugread.c (parse_partial_symbols): Update.
9148         * dwarf2read.c (create_partial_symtab): Update.
9149         * dbxread.c (read_dbx_symtab): Update.
9150         (start_psymtab): Remove global_psymbols and static_psymbols
9151         parameters.
9152
9153 2019-01-10  Tom Tromey  <tom@tromey.com>
9154
9155         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9156         * psymtab.c (allocate_psymtab): Add comment.
9157         * psympriv.h (allocate_psymtab): Add comment.
9158         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9159         initializations.
9160         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9161
9162 2019-01-10  Tom Tromey  <tom@tromey.com>
9163
9164         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9165         Don't declare.
9166         * mipsread.c: Include mdebugread.h.
9167         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9168         Declare.
9169         * elfread.c: Include mdebugread.h.
9170
9171 2019-01-09  Tom Tromey  <tom@tromey.com>
9172
9173         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9174         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9175         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9176         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9177         (psym_lookup_symbol, psym_find_last_source_symtab)
9178         (psym_forget_cached_source_info, psym_print_stats)
9179         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9180         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9181         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9182         (psym_find_compunit_symtab_by_address)
9183         (maintenance_print_psymbols, maintenance_info_psymtabs)
9184         (maintenance_check_psymtabs): Use ranged for.
9185         * psymtab.h (class objfile_psymtabs): New.
9186         (require_partial_symbols): Return objfile_psymtabs.
9187         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9188
9189 2019-01-09  Tom Tromey  <tom@tromey.com>
9190
9191         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9192         (find_pc_mapped_section, list_overlays_command)
9193         (map_overlay_command, unmap_overlay_command)
9194         (simple_overlay_update): Use all_objfiles.
9195         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9196         * printcmd.c (info_symbol_command): Use all_objfiles.
9197         * objfiles.h (ALL_OBJSECTIONS): Remove.
9198         * maint.c (maintenance_translate_address): Use all_objfiles.
9199         * gcore.c (gcore_create_callback): Use all_objfiles.
9200         (objfile_find_memory_regions): Likewise.
9201
9202 2019-01-09  Tom Tromey  <tom@tromey.com>
9203
9204         * symtab.c (find_line_symtab, info_sources_command)
9205         (make_source_files_completion_list): Use objfile_compunits.
9206         * source.c (select_source_symtab): Use objfile_compunits.
9207         * objfiles.h (struct objfile): Update comment.
9208         (ALL_OBJFILES): Remove.
9209         (ALL_FILETABS): Remove.
9210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9211         objfile_compunits.
9212
9213 2019-01-09  Tom Tromey  <tom@tromey.com>
9214
9215         * symmisc.c (print_objfile_statistics, dump_objfile)
9216         (maintenance_print_symbols): Use compunit_filetabs.
9217         * source.c (forget_cached_source_info_for_objfile): Use
9218         compunit_filetabs.
9219         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9220         (ALL_FILETABS): Use compunit_filetabs.
9221         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9222         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9223
9224 2019-01-09  Tom Tromey  <tom@tromey.com>
9225
9226         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9227         (compunit_filetabs): New.
9228         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9229         compunit_filetabs.
9230         (info_sources_command, make_source_files_completion_list): Remove
9231         declaration.
9232         * symmisc.c (print_objfile_statistics, dump_objfile)
9233         (maintenance_print_symbols): Remove declaration.
9234         (maintenance_info_symtabs): Use compunit_filetabs.
9235         (maintenance_info_line_tables): Likewise.
9236         * source.c (select_source_symtab): Change local variable name.
9237         (forget_cached_source_info_for_objfile): Remove declaration.
9238         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9239         * objfiles.c (objfile_relocate1): Remove declaration.
9240         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9241         declaration.
9242         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9243         * coffread.c (coff_symtab_read): Remove declaration.
9244         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9245         compunit_filetabs.
9246
9247 2019-01-09  Tom Tromey  <tom@tromey.com>
9248
9249         * symtab.c (lookup_objfile_from_block)
9250         (find_pc_sect_compunit_symtab, search_symbols)
9251         (default_collect_symbol_completion_matches_break_on): Use
9252         objfile_compunits.
9253         * objfiles.h (ALL_COMPUNITS): Remove.
9254         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9255         * cp-support.c (add_symbol_overload_list_qualified): Use
9256         objfile_compunits.
9257         * ada-lang.c (ada_collect_symbol_completion_matches)
9258         (ada_add_global_exceptions): Use objfile_compunits.
9259
9260 2019-01-09  Tom Tromey  <tom@tromey.com>
9261
9262         * source.c (select_source_symtab)
9263         (forget_cached_source_info_for_objfile): Remove declaration.
9264         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9265         declaration.
9266         * maint.c (count_symtabs_and_blocks): Remove declaration.
9267         * cp-support.c (add_symbol_overload_list_qualified): Remove
9268         declaration.
9269         * coffread.c (coff_symtab_read): Remove declaration.
9270         * symtab.c (lookup_symbol_in_objfile_symtabs)
9271         (basic_lookup_transparent_type_1): Use objfile_compunits.
9272         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9273         (info_sources_command, search_symbols)
9274         (default_collect_symbol_completion_matches_break_on)
9275         (make_source_files_completion_list): Remove declaration.
9276         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9277         (ada_collect_symbol_completion_matches)
9278         (ada_add_global_exceptions): Remove declaration.
9279         * linespec.c (iterate_over_all_matching_symtabs): Use
9280         objfile_compunits.
9281         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9282         (class objfile_compunits): New.
9283         (ALL_COMPUNITS): Use objfile_compunits.
9284         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9285         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9286         objfile_compunits.
9287         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9288
9289 2019-01-09  Tom Tromey  <tom@tromey.com>
9290
9291         * symtab.c (search_symbols)
9292         (default_collect_symbol_completion_matches_break_on): Use
9293         objfile_msymbols.
9294         * ada-lang.c (ada_lookup_simple_minsym)
9295         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9296         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9297         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9298         objfile_msymbols.
9299         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9300         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9301         * objc-lang.c (find_methods): Use objfile_msymbols.
9302         (info_selectors_command, info_classes_command): Likewise.
9303         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9304         * objfiles.h (class objfile_msymbols): New.
9305         (ALL_OBJFILE_MSYMBOLS): Remove.
9306         (ALL_MSYMBOLS): Remove.
9307
9308 2019-01-09  Tom Tromey  <tom@tromey.com>
9309
9310         * common/next-iterator.h (next_adapter): Add Iterator template
9311         parameter.
9312         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9313         (class all_objfiles_safe): New.
9314         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9315         * objfiles.c (put_objfile_before): Update comment.
9316         (add_separate_debug_objfile): Likewise.
9317         (free_all_objfiles): Use all_objfiles_safe.
9318         (objfile_purge_solibs): Likewise.
9319
9320 2019-01-09  Tom Tromey  <tom@tromey.com>
9321
9322         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9323         (expand_symtab_containing_pc, lookup_static_symbol)
9324         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9325         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9326         all_objfiles.
9327         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9328         * breakpoint.c (create_overlay_event_breakpoint)
9329         (create_longjmp_master_breakpoint)
9330         (create_std_terminate_master_breakpoint)
9331         (create_exception_master_breakpoint): Use all_objfiles.
9332         * linux-thread-db.c (try_thread_db_load_from_pdir)
9333         (has_libpthread): Use all_objfiles.
9334         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9335         * linespec.c (iterate_over_all_matching_symtabs)
9336         (search_minsyms_for_name): Use all_objfiles.
9337         * maint.c (maintenance_info_sections): Use all_objfiles.
9338         * main.c (captured_main_1): Use all_objfiles.
9339         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9340         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9341         * guile/scm-pretty-print.c
9342         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9343         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9344         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9345         (maintenance_print_msymbols): Use all_objfiles.
9346         * source.c (select_source_symtab): Use all_objfiles.
9347         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9348         * symfile.c (remove_symbol_file_command)
9349         (expand_symtabs_matching, map_symbol_filenames): Use
9350         all_objfiles.
9351         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9352         all_objfiles.
9353         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9354         * objc-lang.c (find_methods): Use all_objfiles.
9355         * objfiles.c (have_partial_symbols, have_full_symbols)
9356         (have_minimal_symbols, qsort_cmp)
9357         (default_iterate_over_objfiles_in_search_order): Use
9358         all_objfiles.
9359         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9360         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9361         (maintenance_check_psymtabs): Use all_objfiles.
9362         (ALL_PSYMTABS): Remove.
9363         * compile/compile-object-run.c (do_module_cleanup): Use
9364         all_objfiles.
9365         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9366         * cp-support.c (add_symbol_overload_list_qualified): Use
9367         all_objfiles.
9368         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9369         Use all_objfiles.
9370         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9371         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9372         all_objfiles.
9373         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9374         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9375         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9376         Uses all_objfiles.
9377         * solib.c (solib_read_symbols): Use all_objfiles
9378
9379 2019-01-09  Tom Tromey  <tom@tromey.com>
9380
9381         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9382         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9383         all_objfiles.
9384         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9385         * symmisc.c (print_symbol_bcache_statistics)
9386         (print_objfile_statistics, maintenance_print_objfiles)
9387         (maintenance_info_symtabs, maintenance_check_symtabs)
9388         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9389         all_objfiles.
9390         * source.c (forget_cached_source_info): Use all_objfiles.
9391         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9392         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9393         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9394         * objfiles.c (update_section_map): Use all_objfiles.
9395         (shared_objfile_contains_address_p): Likewise.
9396         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9397         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9398
9399 2019-01-09  Tom Tromey  <tom@tromey.com>
9400
9401         * common/next-iterator.h: New file.
9402         * objfiles.h (class all_objfiles): New.
9403         (struct objfile_iterator): New.
9404
9405 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9406
9407         * NEWS: Move the description of the changed "frame", "select-frame",
9408          and "info frame" commands to the Changed commands section.
9409
9410 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9411
9412         * gdbtypes.c (check_stub_method_group): Remove handling of old
9413         mangling schemes.
9414         * linespec.c (find_methods): Likewise.
9415         * stabsread.c (read_member_functions): Likewise.
9416         * valops.c (search_struct_method): Likewise.
9417         (value_struct_elt_for_reference): Likewise.
9418         * NEWS: Mention this change.
9419
9420 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9423         print_source_lines.
9424         * source.c (print_source_lines_base): Update line number check.
9425         (print_source_lines): New function.
9426         (source_lines_range::source_lines_range): New function.
9427         * source.h (class source_lines_range): New class.
9428         (print_source_lines): New declaration.
9429
9430 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9431
9432         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9433
9434 2019-01-08  Tom Tromey  <tom@tromey.com>
9435             Simon Marchi  <simon.marchi@ericsson.com>
9436
9437         PR gdb/24060
9438         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9439         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9440         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9441         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9442         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9443         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9444
9445 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9446
9447         * source.c (select_source_symtab): Move header comment to
9448         declaration in source.h.
9449         (forget_cached_source_info_for_objfile): Likewise.
9450         (forget_cached_source_info): Likewise.
9451         (identify_source_line): Likewise.
9452         * source.h (identify_source_line): Move declaration from symtab.h
9453         and add comment from source.c
9454         (print_source_lines): Likewise.
9455         (forget_cached_source_info_for_objfile): Likewise.
9456         (forget_cached_source_info): Likewise.
9457         (select_source_symtab): Likewise.
9458         (enum print_source_lines_flag): Move definition from symtab.h.
9459         * symtab.h (identify_source_line): Move declaration to source.h.
9460         (print_source_lines): Likewise.
9461         (forget_cached_source_info_for_objfile): Likewise.
9462         (forget_cached_source_info): Likewise.
9463         (select_source_symtab): Likewise.
9464         (enum print_source_lines_flag): Move definition to source.h.
9465         * tui/tui-hooks.c: Add 'source.h' include.
9466
9467 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9468
9469         * source.c (print_source_lines_base): Handle requests to print
9470         reverse line number sequences, and guard against empty lines
9471         string.
9472
9473 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * source.c (print_source_lines_base): Fix skip of '\r' if next
9476         character is '\n'.
9477
9478 2019-01-06  Tom Tromey  <tom@tromey.com>
9479
9480         * c-exp.y (struct c_parse_state) <macro_original_text,
9481         expansion_obstack>: New member.
9482         (macro_original_text, expansion_obstack): Remove globals.
9483         (scan_macro_expansion, scanning_macro_expansion)
9484         (finished_macro_expansion): Update.
9485         (scan_macro_cleanup): Remove.
9486         (yylex, c_parse): Update.
9487
9488 2019-01-06  Tom Tromey  <tom@tromey.com>
9489
9490         * c-exp.y (struct c_parse_state) <strings>: New member.
9491         (operator_stoken): Update.
9492
9493 2019-01-06  Tom Tromey  <tom@tromey.com>
9494
9495         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9496         (union type_stack_elt) <typelist_val>: Now a pointer to
9497         std::vector.
9498         (type_stack_cleanup): Don't declare.
9499         (push_typelist): Update.
9500         * parse.c (pop_typelist): Return a std::vector.
9501         (push_typelist): Take a std::vector.
9502         (follow_types): Update.  Do not free args.
9503         (type_stack_cleanup): Remove.
9504         * c-exp.y (struct c_parse_state): New.
9505         (cpstate): New global.
9506         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9507         (nonempty_typelist): Update.
9508         (func_mod): Create a new vector.
9509         (c_parse): Create a c_parse_state.
9510         (check_parameter_typelist): Do not delete params.
9511         (function_method): Update.  Do not delete type_list.
9512
9513 2019-01-06  Tom Tromey  <tom@tromey.com>
9514
9515         PR gdb/28155:
9516         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9517         check_typedef.
9518         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9519         (print_return_value): Likewise.
9520
9521 2019-01-05  Tom Tromey  <tom@tromey.com>
9522
9523         * contrib/cleanup_check.py: Remove.
9524         * contrib/gcc-with-excheck: Remove.
9525         * contrib/exsummary.py: Remove.
9526         * contrib/excheck.py: Remove.
9527
9528 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9529
9530         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9531         NULL. Initialize tpprev to NULL instead of assigning it
9532         to NULL on the next statement.
9533         * windows-nat.c (windows_delete_thread): Remove check for
9534         main_thread_id before printing thread exit notifications.
9535         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9536         Remove thread ID check against main_thread_id.
9537         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9538         windows_delete_thread.
9539         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9540
9541 2019-01-04  Tom Tromey  <tom@tromey.com>
9542
9543         * compile/compile.c (_initialize_compile): Use upper case for
9544         metasyntactic variables.
9545         * symmisc.c (_initialize_symmisc): Use upper case for
9546         metasyntactic variables.
9547         * psymtab.c (_initialize_psymtab): Use upper case for
9548         metasyntactic variables.
9549         * demangle.c (demangle_command): Use upper case for metasyntactic
9550         variables.
9551         (_initialize_demangler): Likewise.
9552         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9553         variables.
9554
9555 2019-01-03  Tom Tromey  <tom@tromey.com>
9556
9557         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9558
9559 2019-01-03  Tom Tromey  <tom@tromey.com>
9560
9561         * python/py-symtab.c (salpy_str): Update.
9562         (struct salpy_sal_object) <symtab>: Now a PyObject.
9563         (salpy_dealloc): Update.
9564         (del_objfile_sal): Use gdbpy_ref.
9565
9566 2019-01-03  Tom Tromey  <tom@tromey.com>
9567
9568         * python/py-type.c (convert_field): Use new_reference.  Return
9569         gdbpy_ref.
9570         (make_fielditem): Return gdbpy_ref.
9571         (typy_fields): Update.
9572         (typy_getitem): Update.
9573         (field_name): Return gdbpy_ref.  Use new_reference.
9574         (typy_iterator_iternext): Update.
9575
9576 2019-01-03  Tom Tromey  <tom@tromey.com>
9577
9578         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9579
9580 2019-01-03  Tom Tromey  <tom@tromey.com>
9581
9582         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9583         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9584         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9585         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9586         (pspy_set_type_printers): Likewise.
9587         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9588         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9589         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9590         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9591         (objfpy_set_type_printers): Likewise.
9592
9593 2019-01-03  Tom Tromey  <tom@tromey.com>
9594
9595         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9596         (gdbpy_print_stack): Use gdbpy_err_fetch.
9597         * python/python-internal.h (class gdbpy_err_fetch): New class.
9598         (class gdbpy_enter) <m_error_type, m_error_value,
9599         m_error_traceback>: Remove.
9600         <m_error>: New member.
9601         (gdbpy_exception_to_string): Don't declare.
9602         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9603         * python/py-value.c (convert_value_from_python): Use
9604         gdbpy_err_fetch.
9605         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9606         gdbpy_exception_to_string.
9607         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9608         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9609         gdbpy_err_fetch.
9610
9611 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * linux-nat.c (delete_lwp_cleanup): Delete.
9614         (struct lwp_deleter): New struct.
9615         (lwp_info_up): New typedef.
9616         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9617         lwp_info_up.
9618
9619 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9620
9621         * linux-fork.c (class scoped_switch_fork_info): New class.
9622         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9623
9624 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9625
9626         * valops.c (find_overload_match): Remove use of null_cleanup, and
9627         calls to do_cleanups.
9628
9629 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * compile/compile-cplus-types.c
9632         (compile_cplus_instance::decl_name): Handle changes to
9633         cp_func_name.
9634         * cp-support.c (cp_func_name): Update header comment, update
9635         return type.
9636         * cp-support.h (cp_func_name): Update return type in declaration.
9637         * valops.c (find_overload_match): Move temp_func local to top
9638         level of function and change its type.  Use temp_func to hold and
9639         delete temporary string obtained from cp_func_name.
9640
9641 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9642
9643         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9644         gdb::char_vector, remove cleanup, and update uses of `msg`.
9645
9646 2019-01-03  Jim Wilson  <jimw@sifive.com>
9647
9648         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9649
9650 2019-01-02  Tom Tromey  <tom@tromey.com>
9651
9652         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9653         (tdesc_parse_xml): Remove cleanups.
9654         * target-descriptions.h (make_cleanup_free_target_description):
9655         Don't declare.
9656         (target_desc_deleter): New struct.
9657         (target_desc_up): New typedef.
9658         * target-descriptions.c (target_desc_deleter::operator()): Rename
9659         from free_target_description.
9660         (make_cleanup_free_target_description): Remove.
9661
9662 2019-01-02  Tom Tromey  <tom@tromey.com>
9663
9664         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9665         constructor, destructor.
9666         (linespec_parser): Remove typedef.
9667         (~linespec_parser): Rename from linespec_parser_delete.
9668         (linespec_lex_to_end, linespec_complete_label)
9669         (linespec_complete): Update.
9670         (decode_line_full): Remove cleanups.
9671         (decode_line_1): Update.
9672
9673 2019-01-02  Tom Tromey  <tom@tromey.com>
9674
9675         * python/python-internal.h (inferior_to_inferior_object): Change
9676         return type.
9677         * python/py-exitedevent.c (create_exited_event_object): Update.
9678         * python/py-inferior.c (inferior_to_inferior_object): Return
9679         gdbpy_ref.
9680         (python_new_inferior, python_inferior_deleted)
9681         (thread_to_thread_object, delete_thread_object)
9682         (build_inferior_list, gdbpy_selected_inferior): Update.
9683         * python/py-infthread.c (create_thread_object): Update.  Also fail
9684         if inferior_to_inferior_object fails.
9685
9686 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9687
9688         * inferior.h (class inferior) <displaced_step_state>: New field.
9689         * infrun.h (struct displaced_step_state): Move here from
9690         infrun.c.  Initialize fields, add constructor.
9691         <inf>: Remove field.
9692         <reset>: New method.
9693         * infrun.c (struct displaced_step_inferior_state): Move to
9694         infrun.h.
9695         (displaced_step_inferior_states): Remove.
9696         (get_displaced_stepping_state): Adust.
9697         (displaced_step_in_progress_any_inferior): Adjust.
9698         (displaced_step_in_progress_thread): Adjust.
9699         (displaced_step_in_progress): Adjust.
9700         (add_displaced_stepping_state): Remove.
9701         (get_displaced_step_closure_by_addr): Adjust.
9702         (remove_displaced_stepping_state): Remove.
9703         (infrun_inferior_exit): Call displaced_step_state.reset.
9704         (use_displaced_stepping): Don't check for NULL.
9705         (displaced_step_prepare_throw): Call
9706         get_displaced_stepping_state.
9707         (displaced_step_fixup): Don't check for NULL.
9708         (prepare_for_detach): Don't check for NULL.
9709
9710 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9711
9712         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9713          in case of call that did not complete.
9714
9715 2019-01-02  Andrey Utkin  <autkin@undo.io>
9716
9717         * symfile.c (find_separate_debug_file): Fix search of debug files for
9718         remote debuggee.
9719
9720 2019-01-02  Tom Tromey  <tom@tromey.com>
9721
9722         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9723         indentation.
9724         * python/py-frame.c (frapy_older): Remove cast.
9725         (frapy_newer): Likewise.
9726         * python/py-breakpoint.c (local_setattro): Remove cast.
9727         * python/py-arch.c (archpy_name): Remove local variable.
9728         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9729
9730 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9731
9732         * unittests/basic_string_view/element_access/char/empty.cc:
9733         Fix year range in copyright header.
9734
9735 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9736
9737         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9738         Delete.
9739         <operator==>: Update with for removed field.
9740         <hash>: Likewise.
9741         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9742         <isa_features>: ...this.
9743         <abi_features>: New field.
9744         (riscv_isa_flen): Update comment.
9745         (riscv_abi_xlen): New declaration.
9746         (riscv_abi_flen): New declaration.
9747         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9748         isa_features.
9749         (riscv_abi_xlen): New function.
9750         (riscv_isa_flen): Update to get answer from isa_features.
9751         (riscv_abi_flen): New function.
9752         (riscv_has_fp_abi): Update to get answer from abi_features.
9753         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9754         xlen and flen.
9755         (riscv_call_info) <xlen, flen>: Update comment.
9756         (riscv_call_arg_struct): Remove invalid assertions
9757         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9758         is removed.
9759         (riscv_gdbarch_init): Gather isa features and abi features
9760         separately, ensure both match on the gdbarch when reusing an old
9761         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9762         a target with 64-bit float hardware.
9763
9764 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9765
9766         * source.c (search_command_helper): Stop reverse search
9767         when line 1 has been searched.
9768
9769 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9770
9771         * record-full.c (record_full_base_target::close): Rewrite
9772         record_full_core_buf_list free logic.
9773
9774 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9775
9776         * break-catch-syscall.c (print_one_catch_syscall): xfree
9777         the last text.
9778
9779 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9780
9781         * top.c (print_gdb_version): Update Copyright year in version
9782         message.
9783
9784 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9785
9786         Update copyright year range in all GDB files.
9787
9788 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9789
9790         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9791
9792 For older changes see ChangeLog-2018.
9793 \f
9794 Local Variables:
9795 mode: change-log
9796 left-margin: 8
9797 fill-column: 74
9798 version-control: never
9799 coding: utf-8
9800 End:
9801