gdb/ChangeLog

   1 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * source-cache.c (source_cache::get_source_lines): Re-read
   4         fullname after calling open_source_file.
   5
   6 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
   7
   8         * NEWS: Mention TLS support for FreeBSD.
   9
  10 2019-03-25  Tom Tromey  <tromey@adacore.com>
  11
  12         * minsyms.c (BUNCH_SIZE): Update comment.
  13         (~minimal_symbol_reader): Remove old comment.
  14         (compact_minimal_symbols): Update comment.
  15         (minimal_symbol_reader::install): Remove old comment.  Update
  16         other comments.
  17
  18 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * s390-linux-nat.c: Add include.
  21
  22 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  25         Call linux_get_hwcap.
  26         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  27         Likewise.
  28         (aarch64_linux_get_hwcap): Remove function.
  29         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  30         declaration.
  31         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  32         linux_get_hwcap.
  33         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  34         * linux-tdep.c (linux_get_hwcap): Add function.
  35         (linux_get_hwcap2): Likewise.
  36         * linux-tdep.h (linux_get_hwcap): Add declaration.
  37         (linux_get_hwcap2): Likewise.
  38         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  39         (ppc_linux_get_hwcap2): Likewise.
  40         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  41         linux_get_hwcap.
  42         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  43         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  44         (ppc_linux_nat_target::read_description): Likewise.
  45         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  46         * s390-linux-nat.c: Likewise.
  47         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  48
  49 2019-03-24  Tom Tromey  <tom@tromey.com>
  50
  51         * ada-lang.c (standard_lookup): Simplify initialization.
  52         (ada_lookup_symbol_nonlocal): Simplify return.
  53         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  54         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  55         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  56         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  57         initialization.
  58         * solib.c (solib_global_lookup): Simplify.
  59         * symtab.c (null_block_symbol): Remove.
  60         (symbol_cache_lookup): Simplify returns.
  61         (lookup_language_this): Simplify returns.
  62         (lookup_symbol_aux): Simplify return.
  63         (lookup_local_symbol): Simplify returns.
  64         (lookup_global_symbol_from_objfile): Simplify return.
  65         (lookup_symbol_in_objfile_symtabs)
  66         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  67         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  68         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  69         * cp-namespace.c (cp_lookup_bare_symbol)
  70         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  71         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  72         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  73         (cp_lookup_symbol_via_imports): Simplify initialization.
  74         (find_symbol_in_baseclass): Likewise.
  75         * symtab.h (null_block_symbol): Remove.
  76         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  77         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  78         (d_lookup_symbol_module): Likewise.
  79         (find_symbol_in_baseclass): Simplify initialization.
  80
  81 2019-03-24  Tom Tromey  <tom@tromey.com>
  82
  83         * expression.h: Don't include symtab.h.
  84         (struct block): Forward declare.
  85
  86 2019-03-24  Tom Tromey  <tom@tromey.com>
  87
  88         * c-exp.y (typebase): Remove casts.
  89         * gdbtypes.c (lookup_unsigned_typename, )
  90         (lookup_signed_typename): Remove cast.
  91         * eval.c (parse_to_comma_and_eval): Remove cast.
  92         * parse.c (write_dollar_variable): Remove cast.
  93         * block.h (struct block) <superblock>: Now const.
  94         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
  95         * psymtab.c (psym_map_matching_symbols): Make "block" const.
  96         (map_block): Make "block" const.
  97         * symfile.h (struct quick_symbol_functions)
  98         <map_matching_symbols>: Constify block argument to "callback".
  99         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 100         const.
 101         (find_pc_sect_compunit_symtab): Make "b" const.
 102         (find_symbol_at_address): Likewise.
 103         (search_symbols): Likewise.
 104         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 105         (dw2_debug_names_lookup_symbol): Likewise.
 106         (dw2_map_matching_symbols): Update.
 107         * p-valprint.c (pascal_val_print): Remove "block".
 108         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 109         (aux_add_nonlocal_symbols): Make "block" const.
 110         (resolve_subexp): Remove cast.
 111         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 112         const.
 113         (iterate_over_file_blocks): Likewise.
 114         * f-exp.y (%union) <bval>: Remove.
 115         * coffread.c (patch_opaque_types): Make "b" const.
 116         * spu-tdep.c (spu_catch_start): Make "block" const.
 117         * c-valprint.c (print_unpacked_pointer): Remove "block".
 118         * symmisc.c (dump_symtab_1): Make "b" const.
 119         (block_depth): Make "block" const.
 120         * d-exp.y (%union) <bval>: Remove.
 121         * cp-support.h (cp_lookup_rtti_type): Update.
 122         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 123         * psymtab.c (psym_lookup_symbol): Make "block" const.
 124         (maintenance_check_psymtabs): Make "b" const.
 125         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 126         (enumerate_locals, enumerate_args): Update.
 127         * python/py-symtab.c (stpy_global_block): Make "block" const.
 128         (stpy_static_block): Likewise.
 129         * inline-frame.c (block_starting_point_at): Make "new_block"
 130         const.
 131         * block.c (find_block_in_blockvector): Make return type const.
 132         (blockvector_for_pc_sect): Make "b" const.
 133         (find_block_in_blockvector): Make "b" const.
 134
 135 2019-03-23  Tom Tromey  <tom@tromey.com>
 136
 137         * varobj.c (varobj_create): Update.
 138         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 139         * printcmd.c (display_command, do_one_display): Don't reset
 140         innermost_block.
 141         * parser-defs.h (enum innermost_block_tracker_type): Move to
 142         expression.h.
 143         (innermost_block): Update comment.
 144         * parse.c (parse_exp_1): Add tracker_types parameter.
 145         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 146         tracker_types parameter.  Reset innermost_block.
 147         (parse_exp_in_context): Remove.
 148         (parse_expression_for_completion): Update.
 149         * objfiles.c (~objfile): Don't reset expression_context_block or
 150         innermost_block.
 151         * expression.h (enum innermost_block_tracker_type): Move from
 152         parser-defs.h.
 153         (parse_exp_1): Add tracker_types parameter.
 154         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 155         reset innermost_block.
 156
 157 2019-03-23  Tom Tromey  <tom@tromey.com>
 158
 159         * objfiles.h: Include bcache.h.
 160
 161 2019-03-23  Tom Tromey  <tom@tromey.com>
 162
 163         * linespec.c (get_current_search_block): Use
 164         scoped_restore_current_language.
 165         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 166
 167 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 168             Jiong Wang  <jiong.wang@arm.com>
 169
 170         * aarch64-linux-tdep.c
 171         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 172         section.
 173         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 174
 175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 176             Jiong Wang  <jiong.wang@arm.com>
 177
 178         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 179         instructions.
 180         (aarch64_analyze_prologue_test): Add PACIASP test.
 181         (aarch64_prologue_prev_register): Unmask PC value.
 182
 183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 184             Jiong Wang  <jiong.wang@arm.com>
 185
 186         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 187         (aarch64_dwarf2_prev_register): Unmask PC value.
 188         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 189         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 190         DW_CFA_AARCH64_negate_ra_state.
 191         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 192
 193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 194             Jiong Wang  <jiong.wang@arm.com>
 195
 196         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 197         registers.
 198         (aarch64_pseudo_register_name): Likewise.
 199         (aarch64_pseudo_register_type): Likewise.
 200         (aarch64_pseudo_register_reggroup_p): Likewise.
 201         (aarch64_gdbarch_init): Add pauth registers.
 202         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 203         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 204         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 205         (struct gdbarch_tdep): Add regnum for ra_state.
 206
 207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 208             Jiong Wang  <jiong.wang@arm.com>
 209
 210         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 211
 212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 213             Jiong Wang  <jiong.wang@arm.com>
 214
 215         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 216         function.
 217         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 218         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 219         (aarch64_gdbarch_init): Add puth registers.
 220         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 221         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 222         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 223
 224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 225             Jiong Wang  <jiong.wang@arm.com>
 226
 227         * aarch64-linux-nat.c
 228         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 229         * aarch64-linux-tdep.c
 230         (aarch64_linux_core_read_description): Likewise.
 231         (aarch64_linux_get_hwcap): New function.
 232         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 233         (aarch64_linux_get_hwcap): New declaration.
 234
 235 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 236             Jiong Wang  <jiong.wang@arm.com>
 237
 238         * aarch64-linux-nat.c
 239         (aarch64_linux_nat_target::read_description): Add pauth param.
 240         * aarch64-linux-tdep.c
 241         (aarch64_linux_core_read_description): Likewise.
 242         * aarch64-tdep.c (struct target_desc): Add in pauth.
 243         (aarch64_read_description): Add pauth param.
 244         (aarch64_gdbarch_init): Likewise.
 245         * aarch64-tdep.h (aarch64_read_description): Likewise.
 246         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 247         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 248         * features/Makefile: Add new files.
 249         * features/aarch64-pauth.c: New file.
 250         * features/aarch64-pauth.xml: New file.
 251
 252 2019-03-20  Tom Tromey  <tromey@adacore.com>
 253
 254         * infrun.c (handle_inferior_event): Rename from
 255         handle_inferior_event_1.  Create a scoped_value_mark.
 256         (handle_inferior_event): Remove.
 257
 258 2019-03-19  Tom Tromey  <tromey@adacore.com>
 259
 260         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 261         * infrun.h (print_stop_event): Add "displays" parameter.
 262         * infrun.c (print_stop_event): Add "displays" parameter.
 263
 264 2019-03-19  Pedro Alves  <palves@redhat.com>
 265
 266         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 267         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 268         to -1.  Fix TABs vs spaces.
 269         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 270         * tui/tui-out.h (tui_ui_out) Add intro comments.
 271         <m_line, m_start_of_line>: In-class initialize, and add describing
 272         comment.
 273
 274 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 275
 276         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 277         variable names.
 278         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 279
 280 2019-03-18  Pedro Alves  <palves@redhat.com>
 281             Eli Zaretskii <eliz@gnu.org>
 282
 283         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 284         m_line and m_start_of_line.
 285
 286 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 287
 288         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 289         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 290         it returns a newline.  This fixes a regression in TU mode, whereby
 291         the next line is output on the same screen line as the user input.
 292
 293 2019-03-18  Tom Tromey  <tromey@adacore.com>
 294
 295         * minsyms.c (minimal_symbol_reader::install): Remove call to
 296         obstack_blank.
 297
 298 2019-03-18  Pedro Alves  <palves@redhat.com>
 299
 300         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 301         New globals.
 302         (apply_style): New, factored out from ...
 303         (apply_ansi_escape): ... this.  Handle reverse video mode.
 304         (tui_set_reverse_mode): New function.
 305         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 306         * tui/tui-winsource.c (tui_show_source_line): Use
 307         tui_set_reverse_mode instead of setting A_STANDOUT.
 308         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 309         New setter methods.
 310
 311 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 312
 313         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 314         Handle tabs.
 315
 316 2019-03-18  Tom Tromey  <tromey@adacore.com>
 317
 318         * ada-lang.c (empty_array): Add "high" parameter.
 319         (ada_evaluate_subexp): Update.
 320
 321 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 322
 323         * unittests/string_view-selftests.c: Define
 324         _initialize_string_view_selftests unconditionally.
 325
 326 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 327
 328         PR gdb/24350
 329         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 330
 331 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 332
 333         PR gdb/24351
 334         * windows-nat.c (display_selector): Fix format specifiers.
 335
 336 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 337
 338         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 339         tui_refill_source_window instead of tui_refresh_win, to update the
 340         current execution line.  This fixes redisplay of the current line
 341         when stepping through the code with "next" or "step".
 342
 343 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 344
 345         * source-cache.c (source_cache::get_source_lines): Call
 346         find_source_lines to initialize s->nlines.  This fixes vertical
 347         scrolling of TUI source window when the DOWN arrow is pressed.
 348
 349 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 350
 351         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 352         linux-thread-db.c (_initialize_thread_db): Likewise.
 353
 354 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 355
 356         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 357         wclrtoeol in tui_show_source_line".  This reverts changes made in
 358         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 359
 360 2019-03-15  Tom Tromey  <tom@tromey.com>
 361
 362         * symtab.h (struct minimal_symbol): Derive from
 363         general_symbol_info.
 364         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 365         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 366         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 367         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 368         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 369         (MSYMBOL_SEARCH_NAME): Update.
 370         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 371         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 372         * minsyms.c (minimal_symbol_reader::record_full): Update.
 373
 374 2019-03-15  Tom Tromey  <tom@tromey.com>
 375
 376         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 377
 378 2019-03-15  Tom Tromey  <tom@tromey.com>
 379
 380         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 381         unique_xmalloc_ptr.
 382         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 383         Update.
 384         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 385         (build_minimal_symbol_hash_tables)
 386         (minimal_symbol_reader::install): Update.
 387
 388 2019-03-15  Tom Tromey  <tom@tromey.com>
 389
 390         * symtab.c (create_demangled_names_hash): Update.
 391         (symbol_set_names): Update.
 392         * objfiles.h (struct objfile_per_bfd_storage)
 393         <demangled_names_hash>: Now an htab_up.
 394         * objfiles.c (objfile_per_bfd_storage): Simplify.
 395
 396 2019-03-15  Tom Tromey  <tom@tromey.com>
 397
 398         * objfiles.h (struct objfile_per_bfd_storage): Declare
 399         destructor.
 400         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 401         New.
 402         (get_objfile_bfd_data): Use new.  Don't initialize
 403         language_of_main.
 404         (free_objfile_per_bfd_storage): Remove.
 405         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 406
 407 2019-03-15  Tom Tromey  <tom@tromey.com>
 408
 409         * symfile.c (reread_symbols): Update.
 410         * objfiles.c (objfile::objfile): Update.
 411         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 412         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 413         comment.
 414         (minimal_symbol_reader::install): Update.
 415         (terminate_minimal_symbol_table): Remove.
 416         * jit.c (jit_object_close_impl): Update.
 417
 418 2019-03-15  Tom Tromey  <tom@tromey.com>
 419
 420         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 421         initializations.
 422
 423 2019-03-15  Tom Tromey  <tom@tromey.com>
 424
 425         * objfiles.h (struct objfile_per_bfd_storage)
 426         <demangled_hash_languages>: Now a bitset.
 427         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 428         (lookup_minimal_symbol): Update.
 429
 430 2019-03-15  Tom Tromey  <tom@tromey.com>
 431
 432         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 433         Don't return the symbol.
 434         * coffread.c (record_minimal_symbol): Use record_full.
 435
 436 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 437
 438         The MS-Windows port of ncurses fails to switch to a color pair if
 439         one or both of the colors are the implicit default colors.  This
 440         change records the default colors when TUI is initialized, and
 441         then specifies them explicitly when a color pair uses the default
 442         colors.  This allows color styling in TUI mode on MS-Windows.
 443
 444         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 445         ncurses_norm_attr.
 446         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 447         colors in ncurses_norm_attr.
 448         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 449         "none", replace it with the default color recorded in
 450         ncurses_norm_attr.
 451
 452 2019-03-14  Tom Tromey  <tromey@adacore.com>
 453
 454         * source-cache.h (class source_cache) <get_source_lines>: Return
 455         std::string.
 456         * source-cache.c (source_cache::extract_lines): Handle case where
 457         first_pos==npos.  Return std::string.
 458         (source_cache::get_source_lines): Update.
 459
 460 2019-03-14  Tom Tromey  <tromey@adacore.com>
 461
 462         * NEWS: Add item for "style sources" commands.
 463         * source-cache.c (source_cache::get_source_lines): Check
 464         source_styling.
 465         * cli/cli-style.c (source_styling): New global.
 466         (_initialize_cli_style): Add "style sources" commands.
 467         (show_style_sources): New function.
 468         * cli/cli-style.h (source_styling): Declare.
 469
 470 2019-03-14  Pedro Alves  <palves@redhat.com>
 471             Tom Tromey  <tromey@adacore.com>
 472
 473         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 474         * tui/tui-winsource.c (tui_refill_source_window): New function,
 475         from...
 476         (tui_horizontal_source_scroll): ... here.  Move some logic.
 477         * cli/cli-style.c (set_style_enabled): Notify new observable.
 478         * tui/tui-hooks.c (tui_redisplay_source): New function.
 479         (tui_attach_detach_observers): Attach or detach
 480         tui_redisplay_source.
 481         * observable.h (source_styling_changed): New observable.
 482         * observable.c: Define source_styling_changed observable.
 483
 484 2019-03-13  Tom Tromey  <tromey@adacore.com>
 485
 486         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 487         (i386_gnu_nat_target::store_registers): Update.
 488         * target-debug.h (target_debug_print_std_string): New macro.
 489         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 490         * windows-tdep.c (display_one_tib): Update.
 491         * tui/tui-stack.c (tui_make_status_line): Update.
 492         * top.c (print_inferior_quit_action): Update.
 493         * thread.c (thr_try_catch_cmd): Update.
 494         (add_thread_with_info): Update.
 495         (thread_target_id_str): Update.
 496         (thr_try_catch_cmd): Update.
 497         (thread_command): Update.
 498         (thread_find_command): Update.
 499         * record-btrace.c (record_btrace_target::info_record)
 500         (record_btrace_resume_thread, record_btrace_target::resume)
 501         (record_btrace_cancel_resume, record_btrace_step_thread)
 502         (record_btrace_target::wait, record_btrace_target::wait)
 503         (record_btrace_target::wait, record_btrace_target::stop): Update.
 504         * progspace.c (print_program_space): Update.
 505         * process-stratum-target.c
 506         (process_stratum_target::thread_address_space): Update.
 507         * linux-fork.c (linux_fork_mourn_inferior)
 508         (detach_checkpoint_command, info_checkpoints_command)
 509         (linux_fork_context): Update.
 510         (linux_fork_detach): Update.
 511         (class scoped_switch_fork_info): Update.
 512         (delete_checkpoint_command): Update.
 513         * infrun.c (follow_fork_inferior): Update.
 514         (follow_fork_inferior): Update.
 515         (proceed_after_vfork_done): Update.
 516         (handle_vfork_child_exec_or_exit): Update.
 517         (follow_exec): Update.
 518         (displaced_step_prepare_throw): Update.
 519         (displaced_step_restore): Update.
 520         (start_step_over): Update.
 521         (resume_1): Update.
 522         (clear_proceed_status_thread): Update.
 523         (proceed): Update.
 524         (print_target_wait_results): Update.
 525         (do_target_wait): Update.
 526         (context_switch): Update.
 527         (stop_all_threads): Update.
 528         (restart_threads): Update.
 529         (finish_step_over): Update.
 530         (handle_signal_stop): Update.
 531         (switch_back_to_stepped_thread): Update.
 532         (keep_going_pass_signal): Update.
 533         (print_exited_reason): Update.
 534         (normal_stop): Update.
 535         * inferior.c (inferior_pid_to_str): Change return type.
 536         (print_selected_inferior): Update.
 537         (add_inferior): Update.
 538         (detach_inferior): Update.
 539         * dummy-frame.c (fprint_dummy_frames): Update.
 540         * dcache.c (dcache_info_1): Update.
 541         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 542         (btrace_fetch, btrace_clear): Update.
 543         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 544         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 545         type.
 546         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 547         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 548         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 549         * gdbarch.c, gdbarch.h: Rebuild.
 550         * gdbarch.sh (core_pid_to_str): Change return type.
 551         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 552         return type.
 553         (windows_nat_target::pid_to_str): Change return type.
 554         (windows_delete_thread): Update.
 555         (windows_nat_target::attach): Update.
 556         (windows_nat_target::files_info): Update.
 557         * target-delegates.c: Rebuild.
 558         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 559         return type.
 560         (sol_thread_target::pid_to_str): Change return type.
 561         * remote.c (class remote_target) <pid_to_str>: Change return
 562         type.
 563         (remote_target::pid_to_str): Change return type.
 564         (extended_remote_target::attach, remote_target::remote_stop_ns)
 565         (remote_target::remote_notif_remove_queued_reply)
 566         (remote_target::push_stop_reply, remote_target::disable_btrace):
 567         Update.
 568         (extended_remote_target::attach): Update.
 569         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 570         type.
 571         (gdbsim_target::pid_to_str): Change return type.
 572         * ravenscar-thread.c (struct ravenscar_thread_target)
 573         <pid_to_str>: Change return type.
 574         (ravenscar_thread_target::pid_to_str): Change return type.
 575         * procfs.c (class procfs_target) <pid_to_str>: Change return
 576         type.
 577         (procfs_target::pid_to_str): Change return type.
 578         (procfs_target::attach): Update.
 579         (procfs_target::detach): Update.
 580         (procfs_target::fetch_registers): Update.
 581         (procfs_target::store_registers): Update.
 582         (procfs_target::wait): Update.
 583         (procfs_target::files_info): Update.
 584         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 585         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 586         return type.
 587         (nto_procfs_target::pid_to_str): Change return type.
 588         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 589         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 590         return type.
 591         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 592         (exit_lwp): Update.
 593         (attach_proc_task_lwp_callback, get_detach_signal)
 594         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 595         (linux_nat_target::resume, wait_lwp, stop_callback)
 596         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 597         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 598         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 599         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 600         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 601         type.
 602         (inf_ptrace_target::attach): Update.
 603         (inf_ptrace_target::files_info): Update.
 604         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 605         type.
 606         (go32_nat_target::pid_to_str): Change return type.
 607         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 608         (gnu_nat_target::wait): Update.
 609         (gnu_nat_target::wait): Update.
 610         (gnu_nat_target::resume): Update.
 611         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 612         (fbsd_nat_target::wait): Update.
 613         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 614         type.
 615         (darwin_nat_target::attach): Update.
 616         * corelow.c (class core_target) <pid_to_str>: Change return type.
 617         (core_target::pid_to_str): Change return type.
 618         * target.c (normal_pid_to_str): Change return type.
 619         (default_pid_to_str): Likewise.
 620         (target_pid_to_str): Change return type.
 621         (target_translate_tls_address): Update.
 622         (target_announce_detach): Update.
 623         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 624         return type.
 625         (bsd_uthread_target::pid_to_str): Change return type.
 626         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 627         type.
 628         (bsd_kvm_target::pid_to_str): Change return type.
 629         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 630         return type.
 631         (aix_thread_target::pid_to_str): Change return type.
 632         * target.h (struct target_ops) <pid_to_str>: Change return type.
 633         (target_pid_to_str, normal_pid_to_str): Likewise.
 634         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 635         type.
 636         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 637         type.
 638         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 639         return type.
 640         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 641         type.
 642         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 643         type.
 644         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 645         return type.
 646
 647 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 648
 649         * NEWS: Mention that the new default MI version is 3.  Mention
 650         changes to the output of commands and events that deal with
 651         multi-location breakpoints.
 652         * breakpoint.c: Include "mi/mi-out.h".
 653         (print_one_breakpoint): Change output syntax if using MI version
 654         >= 3.
 655         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 656         New.
 657         (mi_multi_location_breakpoint_output_fixed): New.
 658         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 659         (mi_cmd_fix_multi_location_breakpoint_output): New.
 660         (mi_multi_location_breakpoint_output_fixed): New.
 661         * mi/mi-cmds.c (mi_cmds): Register command
 662         -fix-multi-location-breakpoint-output.
 663         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 664         interpreter "mi".
 665
 666 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 667
 668         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 669         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 670         instantiate mi_ui_out based on interpreter name.
 671         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 672         * mi/mi-main.c (mi_load_progress): Likewise.
 673
 674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 675
 676         * NEWS: Combine separate "New targets" sections for 8.3.
 677
 678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 679
 680         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 681         (ppcfbsd_init_abi): Install gdbarch
 682         "fetch_tls_load_module_address" and "get_thread_local_address"
 683         methods.
 684
 685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 686
 687         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 688         (riscv_fbsd_init_abi): Install gdbarch
 689         "fetch_tls_load_module_address" and "get_thread_local_address"
 690         methods.
 691
 692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 693
 694         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 695         (i386fbsd_init_abi): Install gdbarch
 696         "fetch_tls_load_module_address" and "get_thread_local_address"
 697         methods.
 698
 699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 700
 701         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 702         (amd64fbsd_init_abi): Install gdbarch
 703         "fetch_tls_load_module_address" and "get_thread_local_address"
 704         methods.
 705
 706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 707
 708         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 709         (struct fbsd_pspace_data): New type.
 710         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 711         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 712         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 713         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 714         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 715
 716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 717
 718         * gdbtypes.c (lookup_struct_elt): New function.
 719         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 720         * gdbtypes.h (struct struct_elt): New type.
 721         (lookup_struct_elt): New prototype.
 722
 723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 724
 725         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 726         remove disabled code block.
 727
 728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 729
 730         * gdbarch.sh (get_thread_local_address): New method.
 731         * gdbarch.h, gdbarch.c: Regenerate.
 732         * target.c (target_translate_tls_address): Use
 733         gdbarch_get_thread_local_address if present instead of
 734         target::get_thread_local_address.
 735
 736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 737
 738         * target.h (target::get_thread_local_address): Update comment.
 739
 740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 743         objfile->separate_debug_objfile_backlink if not NULL.
 744
 745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 746
 747         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 748         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 749         (amd64bsd_store_inferior_registers): Likewise.
 750         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 751         Enable segment base registers.
 752         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 753         PT_GETFSBASE and PT_GETGSBASE.
 754         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 755         PT_SETGSBASE.
 756         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 757         segment base registers.
 758         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 759
 760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 763         Update calls to i386_target_description to add 'segments'
 764         parameter.
 765         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 766         add segment base registers.
 767         * arch/i386.c (i386_create_target_description): Add 'segments'
 768         parameter to enable segment base registers.
 769         * arch/i386.h (i386_create_target_description): Likewise.
 770         * features/i386/32bit-segments.xml: New file.
 771         * features/i386/32bit-segments.c: Generate.
 772         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 773         call to i386_target_description to add 'segments' parameter.
 774         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 775         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 776         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 777         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 778         if feature is present.
 779         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 780         Add 'segments' parameter to call to i386_target_description.
 781         (i386_target_description): Add 'segments' parameter to enable
 782         segment base registers.
 783         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 784         to call to i386_target_description.
 785         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 786         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 787         Define I386_NUM_REGS.
 788         (i386_target_description): Add 'segments' parameter to enable
 789         segment base registers.
 790
 791 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 792
 793         PR/24325
 794         * source-cache.c: #undef open and close, to avoid unresolved
 795         externals during linking.
 796
 797 2019-03-12  Tom Tromey  <tromey@adacore.com>
 798
 799         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 800         const.  Add initializers.
 801         (_initialize_remote): Don't initialize ptid globals.
 802
 803 2019-03-12  Pedro Alves  <palves@redhat.com>
 804
 805         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 806
 807 2019-03-12  Pedro Alves  <palves@redhat.com>
 808
 809         * cp-name-parser.y (main): Remove unused 'len' variable.
 810
 811 2019-03-12  Tom Tromey  <tromey@adacore.com>
 812
 813         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 814         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 815
 816 2019-03-12  Tom Tromey  <tromey@adacore.com>
 817
 818         * linux-nat.c (iterate_over_lwps): Update.
 819         (stop_callback): Remove parameter.
 820         (stop_wait_callback, detach_callback, resume_set_callback)
 821         (select_singlestep_lwp_callback, set_ignore_sigint)
 822         (status_callback, resumed_callback, resume_clear_callback)
 823         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 824         data parameter.
 825         (linux_nat_target::detach, linux_nat_target::resume)
 826         (linux_stop_and_wait_all_lwps, select_event_lwp)
 827         (linux_nat_filter_event, linux_nat_wait_1)
 828         (linux_nat_target::kill, linux_nat_target::stop)
 829         (linux_nat_target::stop): Update.
 830         (linux_nat_resume_callback): Change type.
 831         (resume_stopped_resumed_lwps, count_events_callback)
 832         (select_event_lwp_callback): Likewise.
 833         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 834         * arm-linux-nat.c (struct update_registers_data): Remove.
 835         (update_registers_callback): Change type.
 836         (arm_linux_insert_hw_breakpoint1): Update.
 837         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 838         parameter.
 839         (x86_linux_dr_set_addr): Update.
 840         (x86_linux_dr_set_control): Update.
 841         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 842         (iterate_over_lwps): Use gdb::function_view.
 843         * nat/aarch64-linux-hw-point.c (struct
 844         aarch64_dr_update_callback_param): Remove.
 845         (debug_reg_change_callback): Change type.
 846         (aarch64_notify_debug_reg_change): Update.
 847         * s390-linux-nat.c (s390_refresh_per_info): Update.
 848
 849 2019-03-11  Tom Tromey  <tromey@adacore.com>
 850
 851         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 852         redundant assignment to "this_cu".
 853
 854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 855
 856         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 857
 858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 859
 860         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 861         from...
 862         (rank_one_type): ... this.
 863
 864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 865
 866         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 867         from...
 868         (rank_one_type): ... this.
 869
 870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 871
 872         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 873         from...
 874         (rank_one_type): ... this.
 875
 876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 877
 878         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 879         from...
 880         (rank_one_type): ... this.
 881
 882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 885         from...
 886         (rank_one_type): ... this.
 887
 888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 889
 890         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 891         from...
 892         (rank_one_type): ... this.
 893
 894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 895
 896         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 897         from...
 898         (rank_one_type): ... this.
 899
 900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 901
 902         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 903         from...
 904         (rank_one_type): ... this.
 905
 906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 907
 908         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 909         from...
 910         (rank_one_type): ... this.
 911
 912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 913
 914         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 915         from...
 916         (rank_one_type): ... this.
 917
 918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 919
 920         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 921         from...
 922         (rank_one_type): ... this.
 923
 924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 927         from...
 928         (rank_one_type): ... this.
 929
 930 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 931
 932         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 933         inferior-events' shows the example events.
 934
 935 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 936
 937         Support styling on native MS-Windows console
 938
 939         PR/24315
 940         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 941         on MS-Windows if $TERM is not defined.
 942
 943         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 944
 945         * posix-hdep.c (gdb_console_fputs):
 946         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 947         functions.
 948         * ui-file.h (gdb_console_fputs): Add prototype.
 949
 950         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 951         back to fputs only if the former returns zero.
 952
 953 2019-03-07  Tom Tromey  <tom@tromey.com>
 954
 955         * symmisc.c (print_symbol_bcache_statistics): Update.
 956         (print_objfile_statistics): Update.
 957         * symfile.c (allocate_symtab): Update.
 958         * stabsread.c: Don't include bcache.h.
 959         * psymtab.h (struct psymbol_bcache): Don't declare.
 960         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 961         (psymbol_bcache_init, psymbol_bcache_free)
 962         (psymbol_bcache_get_bcache): Don't declare.
 963         * psymtab.c (struct psymbol_bcache): Remove.
 964         (psymtab_storage::psymtab_storage): Update.
 965         (psymtab_storage::~psymtab_storage): Update.
 966         (psymbol_bcache_init, psymbol_bcache_free)
 967         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 968         (add_psymbol_to_bcache): Update.
 969         (allocate_psymtab): Update.
 970         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 971         macro_cache>: No longer pointers.
 972         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 973         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 974         * macrotab.c (macro_bcache): Update.
 975         * macroexp.c: Don't include bcache.h.
 976         * gdbtypes.c (check_types_worklist): Update.
 977         (types_deeply_equal): Remove TRY/CATCH.  Update.
 978         * elfread.c (elf_symtab_read): Update.
 979         * dwarf2read.c: Don't include bcache.h.
 980         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 981         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 982         (print_bcache_statistics, bcache_memory_used): Don't declare.
 983         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 984         methods.  Rename all data members.
 985         * bcache.c (struct bcache): Move to bcache.h.
 986         (bcache::expand_hash_table): Rename from expand_hash_table.
 987         (bcache): Remove.
 988         (bcache::insert): Rename from bcache_full.
 989         (bcache::compare): Rename from bcache_compare.
 990         (bcache_xmalloc): Remove.
 991         (bcache::~bcache): Rename from bcache_xfree.
 992         (bcache::print_statistics): Rename from print_bcache_statistics.
 993         (bcache::memory_used): Rename from bcache_memory_used.
 994
 995 2019-03-07  Pedro Alves  <palves@redhat.com>
 996
 997         * infrun.c (normal_stop): Also check for
 998         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 999
1000 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * f-lang.c (value_from_host_double): Moved to...
1003         * value.c (value_from_host_double): ...here.
1004         * value.h (value_from_host_double): Declare.
1005         * guile/scm-math.c (vlscm_convert_typed_number): Use
1006         value_from_host_double.
1007         (vlscm_convert_number): Likewise.
1008         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1009         * python/py-value.c (convert_value_from_python): Likewise.
1010
1011 2019-03-06  Tom Tromey  <tom@tromey.com>
1012
1013         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1014
1015 2019-03-06  Tom Tromey  <tom@tromey.com>
1016
1017         * utils.h (free_current_contents): Don't declare.
1018         * utils.c (free_current_contents): Remove.
1019
1020 2019-03-06  Tom Tromey  <tom@tromey.com>
1021
1022         * top.c (quit_force): Update.
1023         * main.c (captured_command_loop): Update.
1024         * common/new-op.c (operator new): Update.
1025         * common/common-exceptions.c (struct catcher)
1026         <save_cleanup_chain>: Remove member.
1027         (exceptions_state_mc_init): Update.
1028         (exception_try_scope_entry): Return nullptr.
1029         (exception_try_scope_exit, exception_rethrow)
1030         (throw_exception_sjlj, throw_exception_cxx): Update.
1031         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1032         (all_cleanups, do_cleanups, discard_cleanups)
1033         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1034         (restore_cleanups, restore_final_cleanups): Don't declare.
1035         (do_final_cleanups): Remove parameter.
1036         * common/cleanups.c (cleanup_chain, make_cleanup)
1037         (make_cleanup_dtor, all_cleanups, do_cleanups)
1038         (discard_my_cleanups, discard_cleanups)
1039         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1040         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1041         (null_cleanup): Remove.
1042         (do_final_cleanups): Remove parameter.
1043
1044 2019-03-06  Tom Tromey  <tom@tromey.com>
1045
1046         * remote.c (remote_target::remote_parse_stop_reply): Use
1047         unique_xmalloc_ptr.
1048
1049 2019-03-06  Tom Tromey  <tom@tromey.com>
1050
1051         * stabsread.c (struct stabs_field_info): Rename from field_info.
1052         <list, fnlist>: Add initializers.
1053         <obstack>: New member.
1054         (read_member_functions, read_struct_fields, read_baseclasses):
1055         Allocate on obstack.  Don't use cleanups.
1056         (read_one_struct_field, read_member_functions, read_struct_fields)
1057         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1058         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1059         (read_struct_type): Update.
1060
1061 2019-03-06  Tom Tromey  <tom@tromey.com>
1062
1063         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1064         * common/filestuff.h (make_cleanup_close): Don't declare.
1065         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1066         Remove.
1067
1068 2019-03-06  Tom Tromey  <tom@tromey.com>
1069
1070         * solib-aix.c: Use make_scope_exit.
1071
1072 2019-03-06  Tom Tromey  <tom@tromey.com>
1073
1074         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1075         Use make_scope_exit.
1076
1077 2019-03-06  Tom Tromey  <tom@tromey.com>
1078
1079         * solib-svr4.c (disable_probes_interface): Remove parameter.
1080         (svr4_handle_solib_event): Use make_scope_exit.
1081
1082 2019-03-06  Tom Tromey  <tom@tromey.com>
1083
1084         * remote.c (struct stop_reply_deleter): Remove.
1085         (stop_reply_up): Update.
1086         (struct stop_reply): Derive from notif_event.  Don't typedef.
1087         <regcache>: Now a std::vector.
1088         (stop_reply_xfree): Remove.
1089         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1090         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1091         (remote_target::discard_pending_stop_replies): Use delete.
1092         (remote_target::remote_parse_stop_reply): Update.
1093         (remote_target::process_stop_reply): Update.
1094         * remote-notif.h (struct notif_event): Add virtual destructor.
1095         Remove "dtr" member.
1096         (struct notif_client) <alloc_event>: Return a unique_ptr.
1097         (notif_event_xfree): Don't declare.
1098         (notif_event_up): New typedef.
1099         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1100         (notif_event_xfree, do_notif_event_xfree): Remove.
1101         (remote_notif_state_xfree): Update.
1102
1103 2019-03-06  Tom Tromey  <tom@tromey.com>
1104
1105         * infrun.c (displaced_step_clear_cleanup): Now a
1106         forward_scope_exit type.
1107         (displaced_step_prepare_throw): Update.
1108         (displaced_step_fixup): Update.
1109
1110 2019-03-06  Tom Tromey  <tom@tromey.com>
1111
1112         * inferior.h (class inferior): Update comment.
1113         * gdbthread.h (class thread_info): Update comment.
1114
1115 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1116             Tom Tromey  <tom@tromey.com>
1117
1118         * stabsread.h (struct stab_section_list): Remove.
1119         (coffstab_build_psymtabs): Update.
1120         * dbxread.c (symbuf_sections): Now a std::vector.
1121         (sect_idx): New global.
1122         (fill_symbuf): Update.
1123         (coffstab_build_psymtabs): Change type of stabsects parameter.
1124         Update.
1125         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1126         std::vector.
1127         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1128         (coff_locate_sections): Update.
1129         (coff_symfile_read): Remove cleanups.  Update.
1130         (init_stringtab): Add storage parameter.
1131         (free_stringtab, free_stringtab_cleanup): Remove.
1132         (init_lineno): Add storage parameter.
1133         (free_linetab, free_linetab_cleanup): Remove.
1134
1135 2019-03-06  Pedro Alves  <palves@redhat.com>
1136
1137         * linux-fork.c (fork_info::clobber_regs): Delete.
1138         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1139         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1140         comment.  Adjust.
1141         (scoped_switch_fork_info::scoped_switch_fork_info)
1142         (checkpoint_command, linux_fork_context): Adjust
1143         fork_save_infrun_state calls.
1144
1145 2019-03-06  Pedro Alves  <palves@redhat.com>
1146
1147         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1148         (inf_has_multiple_threads): Return 'bool' and rewrite using
1149         inferior_info::threads().
1150
1151 2019-03-06  Pedro Alves  <palves@redhat.com>
1152
1153         * linux-fork.c: Include <list>.
1154         (fork_list): Now a std::list instance.
1155         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1156         (forks_exist_p, find_last_fork): Adjust.
1157         (new_fork): Delete.
1158         (one_fork_p): New.
1159         (add_fork): Adjust.
1160         (free_fork): Delete, folded into fork_info::~fork_info().
1161         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1162         Adjust.
1163         (init_fork_list): Delete.
1164         (linux_fork_killall, linux_fork_mourn_inferior)
1165         (linux_fork_detach, info_checkpoints_command): Adjust.
1166         (_initialize_linux_fork): No longer call init_fork_list.
1167
1168 2019-03-06  Pedro Alves  <palves@redhat.com>
1169
1170         * linux-fork.c (new_fork): New, split out of ...
1171         (add_fork): ... this.  Return void.  Move "first fork" special
1172         case from here, to ...
1173         (checkpoint_command): ... here.
1174         * linux-linux.h (add_fork): Return void.
1175
1176 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1179
1180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1181             Chris January  <chris.january@arm.com>
1182             David Lecomber  <david.lecomber@arm.com>
1183
1184         * f-exp.y: New token, UNOP_INTRINSIC.
1185         (exp): New pattern using UNOP_INTRINSIC token.
1186         (f77_keywords): Add 'abs' keyword.
1187         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1188         (value_from_host_double): New function.
1189         (evaluate_subexp_f): Support UNOP_ABS.
1190
1191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1194         types.
1195
1196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1197
1198         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1199         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1200         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1201
1202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1205
1206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1207             Chris January  <chris.january@arm.com>
1208
1209         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1210         * f-exp.y: Define 'KIND' token.
1211         (exp): New pattern for KIND expressions.
1212         (ptype): Handle types with a kind extension.
1213         (direct_abs_decl): Extend to spot kind extensions.
1214         (f77_keywords): Add 'kind' to the list.
1215         (push_kind_type): New function.
1216         (convert_to_kind_type): New function.
1217         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1218         * parse.c (operator_length_standard): Likewise.
1219         * parser-defs.h (enum type_pieces): Add tp_kind.
1220         * std-operator.def: Add UNOP_KIND.
1221
1222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * f-exp.y (f_parse): Set yydebug.
1225
1226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * f-lang.c (evaluate_subexp_f): New function.
1229         (exp_descriptor_f): New global.
1230         (f_language_defn): Use exp_descriptor_f instead of
1231         exp_descriptor_standard.
1232
1233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * f-exp.y (struct token): Add comments.
1236         (dot_ops): Remove uppercase versions and the end marker.
1237         (f77_keywords): Likewise.
1238         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1239         entries in the dot_ops array are case insensitive, and use
1240         strncasecmp to compare strings.  Also some whitespace cleanup in
1241         this area.  Similar for the f77_keywords array, except entries in
1242         this list might be case sensitive.
1243
1244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * f-exp.y (struct f77_boolean_val): Add comments.
1247         (boolean_values): Remove uppercase versions, and end marker.
1248         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1249         and use strncasecmp to achieve case insensitivity.  Additionally,
1250         perform whitespace cleanup around this code.
1251
1252 2019-03-06  Tom Tromey  <tromey@adacore.com>
1253
1254         * remote-sim.c (gdbsim_target_open): Use result of
1255         gdb_argv::release.
1256
1257 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1258         Dirk Schubert  <dirk.schubert@arm.com>
1259         Chris January  <chris.january@arm.com>
1260
1261         * eval.c (evaluate_subexp_standard): Call Fortran argument
1262         wrapping logic.
1263         * f-lang.c (struct value): A value which can be passed into a
1264         Fortran function call.
1265         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1266         where appropriate.
1267         (struct type): Value ready for a Fortran function call.
1268         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1269         is needed.
1270         * f-lang.h (fortran_argument_convert): Declaration.
1271         (fortran_preserve_arg_pointer): Declaration.
1272         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1273
1274 2019-03-05  Tom Tromey  <tromey@adacore.com>
1275
1276         * python/py-prettyprint.c (print_string_repr): Remove #if.
1277         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1278
1279 2019-03-05  Tom Tromey  <tromey@adacore.com>
1280
1281         * target.c (the_dummy_target): Move later.  Change type to
1282         "dummy_target".
1283         (initialize_targets): Don't initialize the_dummy_target.
1284
1285 2019-03-05  Tom Tromey  <tromey@adacore.com>
1286
1287         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1288         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1289
1290 2019-03-05  Tom Tromey  <tromey@adacore.com>
1291
1292         * windows-nat.c (windows_nat_target::attach)
1293         (windows_nat_target::detach): Don't call gdb_flush.
1294         * valprint.c (generic_val_print, val_print, val_print_string):
1295         Don't call gdb_flush.
1296         * utils.c (defaulted_query): Don't call gdb_flush.
1297         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1298         * target.c (target_announce_detach): Don't call gdb_flush.
1299         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1300         * remote.c (extended_remote_target::attach): Don't call
1301         gdb_flush.
1302         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1303         * printcmd.c (do_examine): Don't call gdb_flush.
1304         (info_display_command): Don't call gdb_flush.
1305         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1306         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1307         * memattr.c (info_mem_command): Don't call gdb_flush.
1308         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1309         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1310         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1311         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1312         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1313         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1314         (gnu_nat_target::detach): Don't call gdb_flush.
1315         * f-valprint.c (f_val_print): Don't call gdb_flush.
1316         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1317         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1318         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1319         gdb_flush.
1320         * c-valprint.c (c_val_print): Don't call gdb_flush.
1321         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1322
1323 2019-03-05  Tom Tromey  <tromey@adacore.com>
1324
1325         * varobj.c (update_dynamic_varobj_children): Update.
1326         (install_default_visualizer): Use reset, not release.
1327         * value.c (set_internalvar): Update.
1328         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1329         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1330         ATTRIBUTE_UNUSED_RESULT.
1331
1332 2019-03-05  Tom Tromey  <tromey@adacore.com>
1333
1334         * remote.c (class scoped_remote_fd) <release>: Add
1335         ATTRIBUTE_UNUSED_RESULT.
1336
1337 2019-03-05  Tom Tromey  <tromey@adacore.com>
1338
1339         * macroexp.c (struct macro_buffer) <release>: Add
1340         ATTRIBUTE_UNUSED_RESULT.
1341
1342 2019-03-05  Tom Tromey  <tromey@adacore.com>
1343
1344         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1345         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1346         ATTRIBUTE_UNUSED_RESULT.
1347
1348 2019-03-05  Tom Tromey  <tromey@adacore.com>
1349
1350         * common/scoped_fd.h (class scoped_fd) <release>: Add
1351         ATTRIBUTE_UNUSED_RESULT.
1352
1353 2019-03-05  Tom Tromey  <tromey@adacore.com>
1354
1355         * parser-defs.h (struct parser_state) <release>: Add
1356         ATTRIBUTE_UNUSED_RESULT.
1357
1358 2019-03-05  Tom Tromey  <tromey@adacore.com>
1359
1360         * utils.h (class gdb_argv) <release>: Add
1361         ATTRIBUTE_UNUSED_RESULT.
1362         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1363
1364 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1365
1366         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1367         for-loop range, to avoid compiler warnings.
1368
1369         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1370         avoid compiler warnings about unused variables.
1371
1372         * NEWS: Mention end of support for native debugging on MS-Windows
1373         before XP.
1374
1375         PR gdb/24292
1376         * common/netstuff.c:
1377         * gdbserver/gdbreplay.c
1378         * gdbserver/remote-utils.c:
1379         * ser-tcp.c:
1380         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1381         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1382         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1383         'getaddrinfo' and 'freeaddrinfo' were not available before
1384         Windows XP, and mingw.org's MinGW headers by default define
1385         _WIN32_WINNT to 0x500.
1386
1387 2019-03-01  Gary Benson <gbenson@redhat.com>
1388
1389         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1390
1391 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1392             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1393
1394         PR gdb/8527
1395         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1396         set_sigint_trap, clear_sigint_trap.
1397
1398 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * target.c (target_detach): Clear the regcache and the
1401         frame cache.
1402
1403 2019-02-27  Pedro Alves  <palves@redhat.com>
1404
1405         * utils.c (set_screen_size): When we cap the height/width sizes,
1406         tweak the corresponding command variable to show "unlimited":
1407
1408 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1409             Pedro Alves  <palves@redhat.com>
1410
1411         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1412         before calling rl_set_screen_size.
1413
1414 2019-02-27  Tom Tromey  <tromey@adacore.com>
1415
1416         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1417         define.
1418         * python/py-value.c: Remove Python 2.4 workaround.
1419         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1420         workaround.
1421         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1422         Python 2.4 workaround.
1423         * python/python-internal.h: Remove Python 2.4 comment.
1424         (Py_ssize_t): Don't define.
1425         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1426         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1427         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1428         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1429         * python/python.c (do_start_initialization): Remove Python 2.4
1430         workaround.
1431         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1432         (print_children): Remove Python 2.4 workaround.
1433         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1434         workaround.
1435         (CHARBUFFERPROC_NAME): Remove.
1436         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1437         Python 2.4 workaround.
1438
1439 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1440
1441         * NEWS: Note minimum Python version.
1442
1443 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1444
1445         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1446         code from these functions.  Remove corresponding ifdefs.  Use
1447         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1448         Remove gotos and target of gotos.
1449         (infpy_search_memory): Likewise.
1450
1451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1454         (hppa_gdbarch_init): Don't register deleted functions with
1455         gdbarch.
1456
1457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1458
1459         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1460         (h8300_unwind_sp): Delete.
1461         (h8300_dummy_id): Delete.
1462         (h8300_gdbarch_init): Don't register deleted functions with
1463         gdbarch.
1464
1465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1468         (ft32_unwind_pc): Delete.
1469         (ft32_unwind_sp): Delete.
1470         (ft32_gdbarch_init): Don't register deleted functions with
1471         gdbarch.
1472
1473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1476         (frv_unwind_pc): Delete.
1477         (frv_unwind_sp): Delete.
1478         (frv_gdbarch_init): Don't register deleted functions with
1479         gdbarch.
1480
1481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1484         (riscv_unwind_pc): Delete.
1485         (riscv_unwind_sp): Delete.
1486         (riscv_gdbarch_init): Don't register deleted functions with
1487         gdbarch.
1488
1489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1490
1491         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1492         (csky_unwind_pc): Delete.
1493         (csky_unwind_sp): Delete.
1494         (csky_gdbarch_init): Don't register deleted functions with
1495         gdbarch.
1496
1497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1500         (cris_unwind_pc): Delete.
1501         (cris_unwind_sp): Delete.
1502         (cris_gdbarch_init): Don't register deleted functions with
1503         gdbarch.
1504
1505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1508         (bfin_unwind_pc): Delete.
1509         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1510
1511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1514         (arm_unwind_pc): Delete.
1515         (arm_unwind_sp): Delete.
1516         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1517
1518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1521         (arc_unwind_pc): Delete.
1522         (arc_unwind_sp): Delete.
1523         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1524
1525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1526
1527         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1528         (alpha_unwind_pc): Delete.
1529         (alpha_gdbarch_init): Don't register deleted functions with
1530         gdbarch.
1531
1532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1535         (aarch64_unwind_pc): Delete.
1536         (aarch64_unwind_sp): Delete.
1537         (aarch64_gdbarch_init): Don't register deleted functions with
1538         gdbarch.
1539
1540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * gdbtypes.c (type_align): Don't consider static members when
1543         computing structure alignment.
1544
1545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1548         return 0 for other types.
1549         * arch-utils.c (default_type_align): Always return 0.
1550         * gdbarch.h: Regenerate.
1551         * gdbarch.sh (type_align): Extend comment.
1552         * gdbtypes.c (type_align): Add additional comments, always call
1553         gdbarch_type_align before applying the default rules.
1554         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1555         generic code will then apply a suitable default.
1556         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1557         types, return 0 for other types.
1558
1559 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1560
1561         * NEWS: Create a new section for the next release branch.
1562         Rename the section of the current branch, now that it has
1563         been cut.
1564
1565 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1566
1567         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1568         * version.in: Bump version to 8.3.50.DATE-git.
1569
1570 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1571
1572         * aix-thread.c (ptid_cmp): Remove unused variable.
1573         (get_signaled_thread): Likewise.
1574         (store_regs_user_thread): Likewise.
1575         (store_regs_kernel_thread): Likewise.
1576         (fetch_regs_kernel_thread): Remove shadowed variable.
1577
1578 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * features/riscv/32bit-cpu.xml: Add register numbers.
1581         * features/riscv/32bit-fpu.c: Regenerate.
1582         * features/riscv/32bit-fpu.xml: Add register numbers.
1583         * features/riscv/64bit-cpu.xml: Add register numbers.
1584         * features/riscv/64bit-fpu.c: Regenerate.
1585         * features/riscv/64bit-fpu.xml: Add register numbers.
1586
1587 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1588
1589         * NEWS: Mention two argument form of gdb.Value constructor.
1590         * python/py-value.c (convert_buffer_and_type_to_value): New
1591         function.
1592         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1593         Add support for handling an optional second argument.  Call
1594         convert_buffer_and_type_to_value as appropriate.
1595         * python/python-internal.h (Py_buffer_deleter): New struct.
1596         (Py_buffer_up): New typedef.
1597
1598 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1599
1600         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1601         instead of releasing ownership.
1602
1603 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1604
1605         * dwarf2read.c (open_and_init_dwp_file): Call
1606         elf_numsections instead of bfd_count_sections to initialize
1607         dwp_file->num_sections.
1608
1609 2019-02-25  Tom Tromey  <tromey@adacore.com>
1610
1611         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1612
1613 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1614
1615         * gcore.in: Add '--readnever' option when invoking GDB.
1616
1617 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1618
1619         * MAINTAINERS: Update my email address.
1620
1621 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1622
1623         * build-id.c (build_id_to_debug_bfd_1): New function.
1624         (build_id_to_debug_bfd): Look for separate debug file in
1625         sysroot.
1626
1627 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * gdbarch.sh: Update the copyright year range that is placed into
1630         generated files.
1631
1632 2019-02-22  Keith Seitz  <keiths@redhat.com>
1633
1634         PR symtab/23853
1635         * linespec.c (create_sals_line_offset): Search for the default
1636         symtab's filename instead of its fullname.
1637
1638 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1639
1640         * NEWS: Update style defaults.
1641
1642 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1643
1644         * main.c (captured_main_1): Disable styling in batch mode.
1645
1646 2019-02-20  Tom Tromey  <tom@tromey.com>
1647
1648         * symtab.c (symtab_symbol_info): Fix typos.
1649
1650 2019-02-20  Tom Tromey  <tromey@adacore.com>
1651
1652         * findcmd.c (_initialize_mem_search): Use upper case for
1653         metasyntactic variables.
1654
1655 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1656
1657         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1658         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1659
1660 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1661
1662         * top.h (source_file_name): Change to std::string.
1663         * top.c (source_file_name): Likewise.
1664         (command_line_input): Adjust.
1665         * cli/cli-script.c (script_from_file): Adjust.
1666
1667 2019-02-19  Tom Tromey  <tromey@adacore.com>
1668
1669         * ravenscar-thread.c
1670         (ravenscar_thread_target::update_thread_list): Don't call
1671         ada_build_task_list.
1672         * ada-lang.h (ada_build_task_list): Don't declare.
1673         * ada-tasks.c (struct ada_tasks_inferior_data)
1674         <task_list_valid_p>: Now bool.
1675         (read_known_tasks, ada_task_list_changed)
1676         (ada_tasks_invalidate_inferior_data): Update.
1677         (read_known_tasks_array): Return bool.
1678         (read_known_tasks_list): Likewise.
1679         (read_known_tasks): Return void.
1680         (ada_build_task_list): Now static.
1681
1682 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1685         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1686
1687 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1688
1689         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1690         variant for ada_tasks_pspace_data_handle and
1691         ada_tasks_inferior_data_handle.
1692         (ada_tasks_pspace_data_cleanup): New function.
1693         (ada_tasks_inferior_data_cleanup): New function.
1694
1695 2019-02-17  Tom Tromey  <tom@tromey.com>
1696
1697         * macrotab.h (macro_source_fullname): Return a std::string.
1698         * macrotab.c (macro_include, check_for_redefinition)
1699         (macro_undef, macro_lookup_definition, foreach_macro)
1700         (foreach_macro_in_scope): Update.
1701         (macro_source_fullname): Return a std::string.
1702         * macrocmd.c (show_pp_source_pos): Update.
1703
1704 2019-02-17  Tom Tromey  <tom@tromey.com>
1705
1706         * macrocmd.c (show_pp_source_pos): Style the file names.
1707
1708 2019-02-17  Tom Tromey  <tom@tromey.com>
1709
1710         PR tui/24197:
1711         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1712
1713 2019-02-17  Tom Tromey  <tom@tromey.com>
1714
1715         * ada-lang.c (user_select_syms): Use filtered printing.
1716         * utils.c (wrap_style): New global.
1717         (desired_style): Remove.
1718         (emit_style_escape): Add stream parameter.
1719         (set_output_style, reset_terminal_style, prompt_for_continue):
1720         Update.
1721         (flush_wrap_buffer): Only flush gdb_stdout.
1722         (wrap_here): Set wrap_style.
1723         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1724         treat escape sequences as a character.  Change when wrap buffer is
1725         flushed.
1726         (fputs_styled): Do not set the output style when the default is
1727         requested.
1728         * ui-style.h (struct ui_file_style) <is_default>: New method.
1729         * source.c (print_source_lines_base): Emit escape sequences in one
1730         piece.
1731
1732 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1733
1734         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1735         integers and enumeration types.
1736
1737 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1738
1739         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1740         instead of lookup_symbol_in_language
1741         (do_exact_match): New function.
1742         (ada_get_symbol_name_matcher): Return do_exact_match when
1743         doing a verbatim match.
1744
1745 2019-02-15  Tom Tromey  <tromey@adacore.com>
1746
1747         * ravenscar-thread.c (ravenscar_thread_target::resume)
1748         (ravenscar_thread_target::wait): Special case wildcard requests.
1749
1750 2019-02-15  Tom Tromey  <tromey@adacore.com>
1751
1752         * ravenscar-thread.c (base_ptid): Remove.
1753         (struct ravenscar_thread_target) <close>: New method.
1754         <m_base_ptid>: New member.
1755         <update_inferior_ptid, active_task, task_is_currently_active,
1756         runtime_initialized>: Declare methods.
1757         <ravenscar_thread_target>: Add constructor.
1758         (ravenscar_thread_target::task_is_currently_active)
1759         (ravenscar_thread_target::update_inferior_ptid)
1760         (ravenscar_runtime_initialized): Rename.  Now methods.
1761         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1762         (ravenscar_thread_target::update_thread_list): Update.
1763         (ravenscar_thread_target::active_task): Now method.
1764         (ravenscar_thread_target::store_registers)
1765         (ravenscar_thread_target::prepare_to_store)
1766         (ravenscar_thread_target::prepare_to_store)
1767         (ravenscar_thread_target::mourn_inferior): Update.
1768         (ravenscar_inferior_created): Use "new" to create target.
1769         (ravenscar_thread_target::get_ada_task_ptid): Update.
1770         (_initialize_ravenscar): Don't initialize base_ptid.
1771         (ravenscar_ops): Remove global.
1772
1773 2019-02-15  Tom Tromey  <tromey@adacore.com>
1774
1775         * target.h (push_target): Declare new overload.
1776         * target.c (push_target): New overload, taking an rvalue reference.
1777         * remote.c (remote_target::open_1): Use push_target overload.
1778         * corelow.c (core_target_open): Use push_target overload.
1779
1780 2019-02-15  Tom Tromey  <tromey@adacore.com>
1781
1782         * ravenscar-thread.c (is_ravenscar_task)
1783         (ravenscar_task_is_currently_active): Return bool.
1784         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1785         (_initialize_ravenscar): Remove "(void)".
1786         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1787         Return bool.
1788
1789 2019-02-15  Tom Tromey  <tromey@adacore.com>
1790
1791         * ravenscar-thread.c (ravenscar_runtime_initializer)
1792         (has_ravenscar_runtime, get_running_thread_id)
1793         (ravenscar_thread_target::resume): Fix indentation.
1794
1795 2019-02-15  Tom Tromey  <tromey@adacore.com>
1796
1797         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1798         from ravenscar_arch_ops.
1799         (sparc_ravenscar_ops::fetch_registers)
1800         (sparc_ravenscar_ops::store_registers): Now methods.
1801         (sparc_ravenscar_prepare_to_store): Remove.
1802         (sparc_ravenscar_ops): Redefine.
1803         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1804         methods and destructor.  Remove members.
1805         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1806         (ravenscar_thread_target::store_registers)
1807         (ravenscar_thread_target::prepare_to_store): Update.
1808         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1809         Remove.
1810         (struct ppc_ravenscar_powerpc_ops): Derive from
1811         ravenscar_arch_ops.
1812         (ppc_ravenscar_powerpc_ops::fetch_registers)
1813         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1814         (ppc_ravenscar_powerpc_ops): Redefine.
1815         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1816         (ppc_ravenscar_e500_ops::fetch_registers)
1817         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1818         (ppc_ravenscar_e500_ops): Redefine.
1819         * aarch64-ravenscar-thread.c
1820         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1821         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1822         (aarch64_ravenscar_fetch_registers)
1823         (aarch64_ravenscar_store_registers): Now methods.
1824         (aarch64_ravenscar_ops): Redefine.
1825
1826 2019-02-15  Tom Tromey  <tromey@adacore.com>
1827
1828         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1829         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1830         (ravenscar_thread_target::stopped_by_watchpoint)
1831         (ravenscar_thread_target::stopped_data_address)
1832         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1833
1834 2019-02-15  Tom Tromey  <tromey@adacore.com>
1835
1836         * ravenscar-thread.c: Fix some typos.
1837
1838 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1839             Tom Tromey  <tromey@adacore.com>
1840
1841         * ada-lang.c (ada_exception_sal): Change addr_string to a
1842         std::string.
1843         (create_ada_exception_catchpoint): Update.
1844
1845 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1846             Tom Tromey  <tromey@adacore.com>
1847
1848         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1849         (bp_location_ops): Remove.
1850         (base_breakpoint_allocate_location): Update.
1851         (free_bp_location): Update.
1852         * ada-lang.c (class ada_catchpoint_location)
1853         <ada_catchpoint_location>: Remove ops parameter.
1854         (ada_catchpoint_location_dtor): Remove.
1855         (ada_catchpoint_location_ops): Remove.
1856         (allocate_location_exception): Update.
1857         * breakpoint.h (struct bp_location_ops): Remove.
1858         (class bp_location) <bp_location>: Remove bp_location_ops
1859         parameter.
1860         <~bp_location>: Add destructor.
1861         <ops>: Remove.
1862
1863 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1864             Pedro Alves  <palves@redhat.com>
1865
1866         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1867         'PATH_MAX'.
1868
1869 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1870             Samuel Thibault  <samuel.thibault@gnu.org>
1871             Thomas Schwinge  <thomas@codesourcery.com>
1872
1873         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1874         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1875
1876 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1877
1878         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1879         (check_empty): Use "const char *".
1880
1881         * gnu-nat.c (gnu_nat_target::detach): Instead of
1882         'detach_inferior (pid)' call
1883         'detach_inferior (find_inferior_pid (pid))'.
1884
1885         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1886         'nat/fork-inferior.o'.
1887         * gnu-nat.c: #include "nat/fork-inferior.h".
1888
1889         * gnu-nat.c (gnu_nat_target::detach): Instead of
1890         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1891         * gnu-nat.h: #include "inf-child.h".
1892         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1893         'i386_gnu_nat_target::fetch_registers'.
1894         (gnu_store_registers): Rename/move to
1895         'i386_gnu_nat_target::store_registers'.
1896
1897         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1898         * gnu-nat.h (mach_thread_info): New function.
1899         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1900
1901         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1902
1903 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1904
1905         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1906
1907 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1908
1909         * windows-nat.c (windows_add_thread): Add new parameter
1910         "main_thread_p" with default value set to false.  Update
1911         function documentation as well as all callers.
1912         (windows_delete_thread): Likewise.
1913         (fake_create_process): Update call to windows_add_thread.
1914         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1915         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1916         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1917         call to windows_delete_thread.
1918
1919 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1920
1921         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1922
1923 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1924
1925         * symfile.c (find_separate_debug_file): Use canonical path of
1926         sysroot with child_path instead of gdb_sysroot if it is valid.
1927
1928 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1929
1930         * symfile.c (find_separate_debug_file): Use child_path to
1931         determine if an object file is under a sysroot.
1932
1933 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1934
1935         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1936         unittests/child-path-selftests.c.
1937         * common/pathstuff.c (child_path): New function.
1938         * common/pathstuff.h (child_path): New prototype.
1939         * unittests/child-path-selftests.c: New file.
1940
1941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1942
1943         * symfile.c (find_separate_debug_file): Look for separate debug
1944         files in debug directories under the sysroot.
1945
1946 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1947
1948         * symtab.h (struct minimal_symbol data_p): New const method.
1949         (struct minimal_symbol text_p): Likewise.
1950         * symtab.c (output_source_filename): Use file name style
1951         to print file name.
1952         (print_symbol_info): Likewise.
1953         (print_msymbol_info): Use address style to print addresses.
1954         Use function name style to print executable text symbols.
1955         (expand_symtab_containing_pc): Use data_p.
1956         (find_pc_sect_compunit_symtab): Likewise.
1957
1958 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1959
1960         * breakpoint.c (describe_other_breakpoints): Use address style
1961         to print addresses.
1962         (say_where): Likewise.
1963
1964 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1965
1966         * ada-typeprint.c (print_func_type): Print function name
1967         style to print function name.
1968         * c-typeprint.c (c_print_type_1): Likewise.
1969
1970 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1971
1972         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1973         for execve.
1974
1975 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1976
1977         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1978         type_stack.
1979
1980 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1981
1982         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1983         TYPE_CODE_REF types.
1984
1985 2019-02-08  Jim Wilson  <jimw@sifive.com>
1986
1987         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1988         (riscv_linux_fregset): New.
1989         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1990
1991 2019-02-07  Tom Tromey  <tom@tromey.com>
1992
1993         * thread.c (thread_cancel_execution_command): Update.
1994         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1995         methods.
1996         (struct thread_fsm_ops): Remove.
1997         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1998         (thread_fsm_should_stop, thread_fsm_return_value)
1999         (thread_fsm_set_finished, thread_fsm_finished_p)
2000         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2001         Don't declare.
2002         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2003         * infrun.c (clear_proceed_status_thread)
2004         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2005         (print_stop_event): Update.
2006         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2007         Add constructor.
2008         (step_command_fsm_ops): Remove.
2009         (new_step_command_fsm): Remove.
2010         (step_1): Update.
2011         (step_command_fsm::should_stop): Rename from
2012         step_command_fsm_should_stop.
2013         (step_command_fsm::clean_up): Rename from
2014         step_command_fsm_clean_up.
2015         (step_command_fsm::do_async_reply_reason): Rename from
2016         step_command_fsm_async_reply_reason.
2017         (struct until_next_fsm): Inherit from thread_fsm.  Add
2018         constructor.
2019         (until_next_fsm_ops): Remove.
2020         (new_until_next_fsm): Remove.
2021         (until_next_fsm::should_stop): Rename from
2022         until_next_fsm_should_stop.
2023         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2024         (until_next_fsm::do_async_reply_reason): Rename from
2025         until_next_fsm_async_reply_reason.
2026         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2027         constructor.  Change type of breakpoint.
2028         (finish_command_fsm_ops): Remove.
2029         (new_finish_command_fsm): Remove.
2030         (finish_command_fsm::should_stop): Rename from
2031         finish_command_fsm_should_stop.
2032         (finish_command_fsm::clean_up): Rename from
2033         finish_command_fsm_clean_up.
2034         (finish_command_fsm::return_value): Rename from
2035         finish_command_fsm_return_value.
2036         (finish_command_fsm::do_async_reply_reason): Rename from
2037         finish_command_fsm_async_reply_reason.
2038         (finish_command): Update.
2039         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2040         Add constructor.
2041         (call_thread_fsm_ops): Remove.
2042         (call_thread_fsm::call_thread_fsm): Rename from
2043         new_call_thread_fsm.
2044         (call_thread_fsm::should_stop): Rename from
2045         call_thread_fsm_should_stop.
2046         (call_thread_fsm::should_notify_stop): Rename from
2047         call_thread_fsm_should_notify_stop.
2048         (run_inferior_call, call_function_by_hand_dummy): Update.
2049         * cli/cli-interp.c (should_print_stop_to_console): Update.
2050         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2051         Add constructor.  Change type of location_breakpoint,
2052         caller_breakpoint.
2053         (until_break_fsm_ops): Remove.
2054         (new_until_break_fsm): Remove.
2055         (until_break_fsm::should_stop): Rename from
2056         until_break_fsm_should_stop.
2057         (until_break_fsm::clean_up): Rename from
2058         until_break_fsm_clean_up.
2059         (until_break_fsm::do_async_reply_reason): Rename from
2060         until_break_fsm_async_reply_reason.
2061         (until_break_command): Update.
2062         * thread-fsm.c: Remove.
2063         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2064
2065 2019-02-07  Tom Tromey  <tom@tromey.com>
2066
2067         * yy-remap.h: Add include guard.
2068         * xtensa-tdep.h: Add include guard.
2069         * xcoffread.h: Rename include guard.
2070         * varobj-iter.h: Add include guard.
2071         * tui/tui.h: Rename include guard.
2072         * tui/tui-winsource.h: Rename include guard.
2073         * tui/tui-wingeneral.h: Rename include guard.
2074         * tui/tui-windata.h: Rename include guard.
2075         * tui/tui-win.h: Rename include guard.
2076         * tui/tui-stack.h: Rename include guard.
2077         * tui/tui-source.h: Rename include guard.
2078         * tui/tui-regs.h: Rename include guard.
2079         * tui/tui-out.h: Rename include guard.
2080         * tui/tui-layout.h: Rename include guard.
2081         * tui/tui-io.h: Rename include guard.
2082         * tui/tui-hooks.h: Rename include guard.
2083         * tui/tui-file.h: Rename include guard.
2084         * tui/tui-disasm.h: Rename include guard.
2085         * tui/tui-data.h: Rename include guard.
2086         * tui/tui-command.h: Rename include guard.
2087         * tic6x-tdep.h: Add include guard.
2088         * target/waitstatus.h: Rename include guard.
2089         * target/wait.h: Rename include guard.
2090         * target/target.h: Rename include guard.
2091         * target/resume.h: Rename include guard.
2092         * target-float.h: Rename include guard.
2093         * stabsread.h: Add include guard.
2094         * rs6000-tdep.h: Add include guard.
2095         * riscv-fbsd-tdep.h: Add include guard.
2096         * regformats/regdef.h: Rename include guard.
2097         * record.h: Rename include guard.
2098         * python/python.h: Rename include guard.
2099         * python/python-internal.h: Rename include guard.
2100         * python/py-stopevent.h: Rename include guard.
2101         * python/py-ref.h: Rename include guard.
2102         * python/py-record.h: Rename include guard.
2103         * python/py-record-full.h: Rename include guard.
2104         * python/py-record-btrace.h: Rename include guard.
2105         * python/py-instruction.h: Rename include guard.
2106         * python/py-events.h: Rename include guard.
2107         * python/py-event.h: Rename include guard.
2108         * procfs.h: Add include guard.
2109         * proc-utils.h: Add include guard.
2110         * p-lang.h: Add include guard.
2111         * or1k-tdep.h: Rename include guard.
2112         * observable.h: Rename include guard.
2113         * nto-tdep.h: Rename include guard.
2114         * nat/x86-linux.h: Rename include guard.
2115         * nat/x86-linux-dregs.h: Rename include guard.
2116         * nat/x86-gcc-cpuid.h: Add include guard.
2117         * nat/x86-dregs.h: Rename include guard.
2118         * nat/x86-cpuid.h: Rename include guard.
2119         * nat/ppc-linux.h: Rename include guard.
2120         * nat/mips-linux-watch.h: Rename include guard.
2121         * nat/linux-waitpid.h: Rename include guard.
2122         * nat/linux-ptrace.h: Rename include guard.
2123         * nat/linux-procfs.h: Rename include guard.
2124         * nat/linux-osdata.h: Rename include guard.
2125         * nat/linux-nat.h: Rename include guard.
2126         * nat/linux-namespaces.h: Rename include guard.
2127         * nat/linux-btrace.h: Rename include guard.
2128         * nat/glibc_thread_db.h: Rename include guard.
2129         * nat/gdb_thread_db.h: Rename include guard.
2130         * nat/gdb_ptrace.h: Rename include guard.
2131         * nat/fork-inferior.h: Rename include guard.
2132         * nat/amd64-linux-siginfo.h: Rename include guard.
2133         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2134         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2135         * nat/aarch64-linux.h: Rename include guard.
2136         * nat/aarch64-linux-hw-point.h: Rename include guard.
2137         * mn10300-tdep.h: Add include guard.
2138         * mips-linux-tdep.h: Add include guard.
2139         * mi/mi-parse.h: Rename include guard.
2140         * mi/mi-out.h: Rename include guard.
2141         * mi/mi-main.h: Rename include guard.
2142         * mi/mi-interp.h: Rename include guard.
2143         * mi/mi-getopt.h: Rename include guard.
2144         * mi/mi-console.h: Rename include guard.
2145         * mi/mi-common.h: Rename include guard.
2146         * mi/mi-cmds.h: Rename include guard.
2147         * mi/mi-cmd-break.h: Rename include guard.
2148         * m2-lang.h: Add include guard.
2149         * location.h: Rename include guard.
2150         * linux-record.h: Rename include guard.
2151         * linux-nat.h: Add include guard.
2152         * linux-fork.h: Add include guard.
2153         * i386-darwin-tdep.h: Rename include guard.
2154         * hppa-linux-offsets.h: Add include guard.
2155         * guile/guile.h: Rename include guard.
2156         * guile/guile-internal.h: Rename include guard.
2157         * gnu-nat.h: Rename include guard.
2158         * gdb-stabs.h: Rename include guard.
2159         * frv-tdep.h: Add include guard.
2160         * f-lang.h: Add include guard.
2161         * event-loop.h: Add include guard.
2162         * darwin-nat.h: Rename include guard.
2163         * cp-abi.h: Rename include guard.
2164         * config/sparc/nm-sol2.h: Rename include guard.
2165         * config/nm-nto.h: Rename include guard.
2166         * config/nm-linux.h: Add include guard.
2167         * config/i386/nm-i386gnu.h: Rename include guard.
2168         * config/djgpp/nl_types.h: Rename include guard.
2169         * config/djgpp/langinfo.h: Rename include guard.
2170         * compile/gcc-cp-plugin.h: Add include guard.
2171         * compile/gcc-c-plugin.h: Add include guard.
2172         * compile/compile.h: Rename include guard.
2173         * compile/compile-object-run.h: Rename include guard.
2174         * compile/compile-object-load.h: Rename include guard.
2175         * compile/compile-internal.h: Rename include guard.
2176         * compile/compile-cplus.h: Rename include guard.
2177         * compile/compile-c.h: Rename include guard.
2178         * common/xml-utils.h: Rename include guard.
2179         * common/x86-xstate.h: Rename include guard.
2180         * common/version.h: Rename include guard.
2181         * common/vec.h: Rename include guard.
2182         * common/tdesc.h: Rename include guard.
2183         * common/selftest.h: Rename include guard.
2184         * common/scoped_restore.h: Rename include guard.
2185         * common/scoped_mmap.h: Rename include guard.
2186         * common/scoped_fd.h: Rename include guard.
2187         * common/safe-iterator.h: Rename include guard.
2188         * common/run-time-clock.h: Rename include guard.
2189         * common/refcounted-object.h: Rename include guard.
2190         * common/queue.h: Rename include guard.
2191         * common/ptid.h: Rename include guard.
2192         * common/print-utils.h: Rename include guard.
2193         * common/preprocessor.h: Rename include guard.
2194         * common/pathstuff.h: Rename include guard.
2195         * common/observable.h: Rename include guard.
2196         * common/netstuff.h: Rename include guard.
2197         * common/job-control.h: Rename include guard.
2198         * common/host-defs.h: Rename include guard.
2199         * common/gdb_wait.h: Rename include guard.
2200         * common/gdb_vecs.h: Rename include guard.
2201         * common/gdb_unlinker.h: Rename include guard.
2202         * common/gdb_unique_ptr.h: Rename include guard.
2203         * common/gdb_tilde_expand.h: Rename include guard.
2204         * common/gdb_sys_time.h: Rename include guard.
2205         * common/gdb_string_view.h: Rename include guard.
2206         * common/gdb_splay_tree.h: Rename include guard.
2207         * common/gdb_setjmp.h: Rename include guard.
2208         * common/gdb_ref_ptr.h: Rename include guard.
2209         * common/gdb_optional.h: Rename include guard.
2210         * common/gdb_locale.h: Rename include guard.
2211         * common/gdb_assert.h: Rename include guard.
2212         * common/filtered-iterator.h: Rename include guard.
2213         * common/filestuff.h: Rename include guard.
2214         * common/fileio.h: Rename include guard.
2215         * common/environ.h: Rename include guard.
2216         * common/common-utils.h: Rename include guard.
2217         * common/common-types.h: Rename include guard.
2218         * common/common-regcache.h: Rename include guard.
2219         * common/common-inferior.h: Rename include guard.
2220         * common/common-gdbthread.h: Rename include guard.
2221         * common/common-exceptions.h: Rename include guard.
2222         * common/common-defs.h: Rename include guard.
2223         * common/common-debug.h: Rename include guard.
2224         * common/cleanups.h: Rename include guard.
2225         * common/buffer.h: Rename include guard.
2226         * common/btrace-common.h: Rename include guard.
2227         * common/break-common.h: Rename include guard.
2228         * cli/cli-utils.h: Rename include guard.
2229         * cli/cli-style.h: Rename include guard.
2230         * cli/cli-setshow.h: Rename include guard.
2231         * cli/cli-script.h: Rename include guard.
2232         * cli/cli-interp.h: Rename include guard.
2233         * cli/cli-decode.h: Rename include guard.
2234         * cli/cli-cmds.h: Rename include guard.
2235         * charset-list.h: Add include guard.
2236         * buildsym-legacy.h: Rename include guard.
2237         * bfin-tdep.h: Add include guard.
2238         * ax.h: Rename include guard.
2239         * arm-linux-tdep.h: Add include guard.
2240         * arm-fbsd-tdep.h: Add include guard.
2241         * arch/xtensa.h: Rename include guard.
2242         * arch/tic6x.h: Add include guard.
2243         * arch/i386.h: Add include guard.
2244         * arch/arm.h: Rename include guard.
2245         * arch/arm-linux.h: Rename include guard.
2246         * arch/arm-get-next-pcs.h: Rename include guard.
2247         * arch/amd64.h: Add include guard.
2248         * arch/aarch64-insn.h: Rename include guard.
2249         * arch-utils.h: Rename include guard.
2250         * annotate.h: Add include guard.
2251         * amd64-darwin-tdep.h: Rename include guard.
2252         * aarch64-linux-tdep.h: Add include guard.
2253         * aarch64-fbsd-tdep.h: Add include guard.
2254         * aarch32-linux-nat.h: Add include guard.
2255
2256 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2257
2258         * macrotab.c (macro_define_internal): New function that
2259         factorizes macro_define_object_internal and macro_define_function
2260         code.
2261         (macro_define_object_internal): Use macro_define_internal.
2262         (macro_define_function): Likewise.
2263
2264 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2265
2266         * macrocmd.c (extract_identifier): Return
2267         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2268         callers.
2269
2270 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2271
2272         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2273
2274 2019-02-05  Tom Tromey  <tom@tromey.com>
2275
2276         * target.c (target_stack::unpush): Move assertion earlier.
2277
2278 2019-01-30  Tom Tromey  <tom@tromey.com>
2279
2280         PR python/23615:
2281         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2282         (gdbpy_parse_and_eval): Likewise.
2283         * python/python-internal.h (gdbpy_allow_threads): New class.
2284
2285 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2286
2287         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2288         (aarch64_fbsd_fpregmap): Move earlier.
2289         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2290         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2291         instead of individual calls to trad_frame_set_reg_addr.
2292         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2293         earlier.
2294         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2295         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2296         instead of individual calls to trad_frame_set_reg_addr.
2297
2298 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2299
2300         * CONTRIBUTE: Replace contribution list with wiki link.
2301
2302 2019-01-25  Tom Tromey  <tom@tromey.com>
2303
2304         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2305
2306 2019-01-25  Tom Tromey  <tom@tromey.com>
2307
2308         * xtensa-linux-nat.c: Fix common/ includes.
2309         * xml-support.h: Fix common/ includes.
2310         * xml-support.c: Fix common/ includes.
2311         * x86-linux-nat.c: Fix common/ includes.
2312         * windows-nat.c: Fix common/ includes.
2313         * varobj.h: Fix common/ includes.
2314         * varobj.c: Fix common/ includes.
2315         * value.c: Fix common/ includes.
2316         * valops.c: Fix common/ includes.
2317         * utils.c: Fix common/ includes.
2318         * unittests/xml-utils-selftests.c: Fix common/ includes.
2319         * unittests/utils-selftests.c: Fix common/ includes.
2320         * unittests/unpack-selftests.c: Fix common/ includes.
2321         * unittests/tracepoint-selftests.c: Fix common/ includes.
2322         * unittests/style-selftests.c: Fix common/ includes.
2323         * unittests/string_view-selftests.c: Fix common/ includes.
2324         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2325         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2326         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2327         * unittests/rsp-low-selftests.c: Fix common/ includes.
2328         * unittests/parse-connection-spec-selftests.c: Fix common/
2329         includes.
2330         * unittests/optional-selftests.c: Fix common/ includes.
2331         * unittests/offset-type-selftests.c: Fix common/ includes.
2332         * unittests/observable-selftests.c: Fix common/ includes.
2333         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2334         * unittests/memrange-selftests.c: Fix common/ includes.
2335         * unittests/memory-map-selftests.c: Fix common/ includes.
2336         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2337         * unittests/function-view-selftests.c: Fix common/ includes.
2338         * unittests/environ-selftests.c: Fix common/ includes.
2339         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2340         * unittests/common-utils-selftests.c: Fix common/ includes.
2341         * unittests/cli-utils-selftests.c: Fix common/ includes.
2342         * unittests/array-view-selftests.c: Fix common/ includes.
2343         * ui-file.c: Fix common/ includes.
2344         * tui/tui-io.c: Fix common/ includes.
2345         * tracepoint.h: Fix common/ includes.
2346         * tracepoint.c: Fix common/ includes.
2347         * tracefile-tfile.c: Fix common/ includes.
2348         * top.h: Fix common/ includes.
2349         * top.c: Fix common/ includes.
2350         * thread.c: Fix common/ includes.
2351         * target/waitstatus.h: Fix common/ includes.
2352         * target/waitstatus.c: Fix common/ includes.
2353         * target.h: Fix common/ includes.
2354         * target.c: Fix common/ includes.
2355         * target-memory.c: Fix common/ includes.
2356         * target-descriptions.c: Fix common/ includes.
2357         * symtab.h: Fix common/ includes.
2358         * symfile.c: Fix common/ includes.
2359         * stap-probe.c: Fix common/ includes.
2360         * spu-linux-nat.c: Fix common/ includes.
2361         * sparc-nat.c: Fix common/ includes.
2362         * source.c: Fix common/ includes.
2363         * solib.c: Fix common/ includes.
2364         * solib-target.c: Fix common/ includes.
2365         * ser-unix.c: Fix common/ includes.
2366         * ser-tcp.c: Fix common/ includes.
2367         * ser-pipe.c: Fix common/ includes.
2368         * ser-base.c: Fix common/ includes.
2369         * selftest-arch.c: Fix common/ includes.
2370         * s12z-tdep.c: Fix common/ includes.
2371         * rust-exp.y: Fix common/ includes.
2372         * rs6000-aix-tdep.c: Fix common/ includes.
2373         * riscv-tdep.c: Fix common/ includes.
2374         * remote.c: Fix common/ includes.
2375         * remote-notif.h: Fix common/ includes.
2376         * remote-fileio.h: Fix common/ includes.
2377         * remote-fileio.c: Fix common/ includes.
2378         * regcache.h: Fix common/ includes.
2379         * regcache.c: Fix common/ includes.
2380         * record-btrace.c: Fix common/ includes.
2381         * python/python.c: Fix common/ includes.
2382         * python/py-type.c: Fix common/ includes.
2383         * python/py-inferior.c: Fix common/ includes.
2384         * progspace.h: Fix common/ includes.
2385         * producer.c: Fix common/ includes.
2386         * procfs.c: Fix common/ includes.
2387         * proc-api.c: Fix common/ includes.
2388         * printcmd.c: Fix common/ includes.
2389         * ppc-linux-nat.c: Fix common/ includes.
2390         * parser-defs.h: Fix common/ includes.
2391         * osdata.c: Fix common/ includes.
2392         * obsd-nat.c: Fix common/ includes.
2393         * nat/x86-linux.c: Fix common/ includes.
2394         * nat/x86-linux-dregs.c: Fix common/ includes.
2395         * nat/x86-dregs.h: Fix common/ includes.
2396         * nat/x86-dregs.c: Fix common/ includes.
2397         * nat/ppc-linux.c: Fix common/ includes.
2398         * nat/mips-linux-watch.h: Fix common/ includes.
2399         * nat/mips-linux-watch.c: Fix common/ includes.
2400         * nat/linux-waitpid.c: Fix common/ includes.
2401         * nat/linux-ptrace.h: Fix common/ includes.
2402         * nat/linux-ptrace.c: Fix common/ includes.
2403         * nat/linux-procfs.c: Fix common/ includes.
2404         * nat/linux-personality.c: Fix common/ includes.
2405         * nat/linux-osdata.c: Fix common/ includes.
2406         * nat/linux-namespaces.c: Fix common/ includes.
2407         * nat/linux-btrace.h: Fix common/ includes.
2408         * nat/linux-btrace.c: Fix common/ includes.
2409         * nat/fork-inferior.c: Fix common/ includes.
2410         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2411         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2412         * nat/aarch64-linux.c: Fix common/ includes.
2413         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2414         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2415         * namespace.h: Fix common/ includes.
2416         * mips-linux-tdep.c: Fix common/ includes.
2417         * minsyms.c: Fix common/ includes.
2418         * mi/mi-parse.h: Fix common/ includes.
2419         * mi/mi-main.c: Fix common/ includes.
2420         * mi/mi-cmd-env.c: Fix common/ includes.
2421         * memrange.h: Fix common/ includes.
2422         * memattr.c: Fix common/ includes.
2423         * maint.h: Fix common/ includes.
2424         * maint.c: Fix common/ includes.
2425         * main.c: Fix common/ includes.
2426         * machoread.c: Fix common/ includes.
2427         * location.c: Fix common/ includes.
2428         * linux-thread-db.c: Fix common/ includes.
2429         * linux-nat.c: Fix common/ includes.
2430         * linux-fork.c: Fix common/ includes.
2431         * inline-frame.c: Fix common/ includes.
2432         * infrun.c: Fix common/ includes.
2433         * inflow.c: Fix common/ includes.
2434         * inferior.h: Fix common/ includes.
2435         * inferior.c: Fix common/ includes.
2436         * infcmd.c: Fix common/ includes.
2437         * inf-ptrace.c: Fix common/ includes.
2438         * inf-child.c: Fix common/ includes.
2439         * ia64-linux-nat.c: Fix common/ includes.
2440         * i387-tdep.c: Fix common/ includes.
2441         * i386-tdep.c: Fix common/ includes.
2442         * i386-linux-tdep.c: Fix common/ includes.
2443         * i386-linux-nat.c: Fix common/ includes.
2444         * i386-go32-tdep.c: Fix common/ includes.
2445         * i386-fbsd-tdep.c: Fix common/ includes.
2446         * i386-fbsd-nat.c: Fix common/ includes.
2447         * guile/scm-type.c: Fix common/ includes.
2448         * guile/guile.c: Fix common/ includes.
2449         * go32-nat.c: Fix common/ includes.
2450         * gnu-nat.c: Fix common/ includes.
2451         * gdbthread.h: Fix common/ includes.
2452         * gdbarch-selftests.c: Fix common/ includes.
2453         * gdb_usleep.c: Fix common/ includes.
2454         * gdb_select.h: Fix common/ includes.
2455         * gdb_bfd.c: Fix common/ includes.
2456         * gcore.c: Fix common/ includes.
2457         * fork-child.c: Fix common/ includes.
2458         * findvar.c: Fix common/ includes.
2459         * fbsd-nat.c: Fix common/ includes.
2460         * event-top.c: Fix common/ includes.
2461         * event-loop.c: Fix common/ includes.
2462         * dwarf2read.c: Fix common/ includes.
2463         * dwarf2loc.c: Fix common/ includes.
2464         * dwarf2-frame.c: Fix common/ includes.
2465         * dwarf-index-cache.c: Fix common/ includes.
2466         * dtrace-probe.c: Fix common/ includes.
2467         * disasm-selftests.c: Fix common/ includes.
2468         * defs.h: Fix common/ includes.
2469         * csky-tdep.c: Fix common/ includes.
2470         * cp-valprint.c: Fix common/ includes.
2471         * cp-support.h: Fix common/ includes.
2472         * cp-support.c: Fix common/ includes.
2473         * corelow.c: Fix common/ includes.
2474         * completer.h: Fix common/ includes.
2475         * completer.c: Fix common/ includes.
2476         * compile/compile.c: Fix common/ includes.
2477         * compile/compile-loc2c.c: Fix common/ includes.
2478         * compile/compile-cplus-types.c: Fix common/ includes.
2479         * compile/compile-cplus-symbols.c: Fix common/ includes.
2480         * command.h: Fix common/ includes.
2481         * cli/cli-dump.c: Fix common/ includes.
2482         * cli/cli-cmds.c: Fix common/ includes.
2483         * charset.c: Fix common/ includes.
2484         * build-id.c: Fix common/ includes.
2485         * btrace.h: Fix common/ includes.
2486         * btrace.c: Fix common/ includes.
2487         * breakpoint.h: Fix common/ includes.
2488         * breakpoint.c: Fix common/ includes.
2489         * ax.h:
2490         (enum agent_op): Fix common/ includes.
2491         * ax-general.c (struct aop_map): Fix common/ includes.
2492         * ax-gdb.c: Fix common/ includes.
2493         * auxv.c: Fix common/ includes.
2494         * auto-load.c: Fix common/ includes.
2495         * arm-tdep.c: Fix common/ includes.
2496         * arch/riscv.c: Fix common/ includes.
2497         * arch/ppc-linux-common.c: Fix common/ includes.
2498         * arch/i386.c: Fix common/ includes.
2499         * arch/arm.c: Fix common/ includes.
2500         * arch/arm-linux.c: Fix common/ includes.
2501         * arch/arm-get-next-pcs.c: Fix common/ includes.
2502         * arch/amd64.c: Fix common/ includes.
2503         * arch/aarch64.c: Fix common/ includes.
2504         * arch/aarch64-insn.c: Fix common/ includes.
2505         * arch-utils.c: Fix common/ includes.
2506         * amd64-windows-tdep.c: Fix common/ includes.
2507         * amd64-tdep.c: Fix common/ includes.
2508         * amd64-sol2-tdep.c: Fix common/ includes.
2509         * amd64-obsd-tdep.c: Fix common/ includes.
2510         * amd64-nbsd-tdep.c: Fix common/ includes.
2511         * amd64-linux-tdep.c: Fix common/ includes.
2512         * amd64-linux-nat.c: Fix common/ includes.
2513         * amd64-fbsd-tdep.c: Fix common/ includes.
2514         * amd64-fbsd-nat.c: Fix common/ includes.
2515         * amd64-dicos-tdep.c: Fix common/ includes.
2516         * amd64-darwin-tdep.c: Fix common/ includes.
2517         * agent.c: Fix common/ includes.
2518         * ada-lang.h: Fix common/ includes.
2519         * ada-lang.c: Fix common/ includes.
2520         * aarch64-tdep.c: Fix common/ includes.
2521
2522 2019-01-25  Tom Tromey  <tom@tromey.com>
2523
2524         * common/create-version.sh: Use common/version.h.
2525
2526 2019-01-24  Pedro Alves  <palves@redhat.com>
2527
2528         * infrun.c (signal_stop, signal_print, signal_program)
2529         (signal_catch, signal_pass): Now arrays instead of pointers.
2530         (update_signals_program_target, do_target_resume)
2531         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2532         * linux-nat.c (linux_nat_target::pass_signals)
2533         (linux_nat_target::create_inferior, linux_nat_target::attach):
2534         Adjust.
2535         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2536         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2537         * procfs.c (procfs_target::pass_signals): Adjust.
2538         * record-full.c (record_full_target::resume): Adjust.
2539         * remote.c (remote_target::pass_signals)
2540         (remote_target::program_signals): Adjust.
2541         * target-debug.h (target_debug_print_signals): Now takes a
2542         gdb::array_view as parameter.  Adjust.
2543         * target.h (target_ops) <pass_signals, program_signals>: Replace
2544         pointer and length parameters with gdb::array_view.
2545         (target_pass_signals, target_program_signals): Likewise.
2546         * target-delegates.c: Regenerate.
2547
2548 2019-01-24  Pedro Alves  <palves@redhat.com>
2549
2550         * common/forward-scope-exit.h
2551         (forward_scope_exit::forward_scope_exit): Pass arguments to
2552         m_bind_function directly, instead of creating a std::bind and
2553         copying that.
2554
2555 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2556
2557         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2558         for static members.
2559         (pass_in_v_vfp_candidate): Likewise.
2560
2561 2019-01-23  Tom Tromey  <tom@tromey.com>
2562             Pedro Alves  <palves@redhat.com>
2563
2564         * regcache.c (class regcache_invalidator): Remove.
2565         (regcache::raw_write): Use make_scope_exit.
2566
2567 2019-01-23  Tom Tromey  <tom@tromey.com>
2568
2569         * ui-out.h (class ui_out_emit_type): Update comment.
2570
2571 2019-01-23  Tom Tromey  <tom@tromey.com>
2572
2573         * infrun.c (fetch_inferior_event): Update comment.
2574
2575 2019-01-23  Tom Tromey  <tom@tromey.com>
2576             Pedro Alves  <palves@redhat.com>
2577
2578         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2579         parameter.
2580         (fetch_inferior_event): Use SCOPE_EXIT.
2581
2582
2583 2019-01-23  Tom Tromey  <tom@tromey.com>
2584             Pedro Alves  <palves@redhat.com>
2585
2586         * infrun.c (disable_thread_events): Delete.
2587         (stop_all_threads): Use SCOPE_EXIT.
2588
2589 2019-01-23  Tom Tromey  <tom@tromey.com>
2590             Pedro Alves  <palves@redhat.com>
2591
2592         * symfile.c: Include forward-scope-exit.h.
2593         (clear_symtab_users_cleanup): Replace forward declaration with
2594         a FORWARD_SCOPE_EXIT.
2595         (syms_from_objfile_1): Use the forward_scope_exit and
2596         gdb::optional instead of cleanup_function.
2597         (reread_symbols): Use the forward_scope_exit instead of
2598         cleanup_function.
2599         (clear_symtab_users_cleanup): Remove function.
2600
2601 2019-01-23  Tom Tromey  <tom@tromey.com>
2602             Pedro Alves  <palves@redhat.com>
2603
2604         * linux-nat.c: Include scope-exit.h.
2605         (cleanup_target_stop): Remove.
2606         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2607         SCOPE_EXIT.
2608
2609 2019-01-23  Tom Tromey  <tom@tromey.com>
2610             Pedro Alves  <palves@redhat.com>
2611
2612         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2613         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2614
2615 2019-01-23  Tom Tromey  <tom@tromey.com>
2616             Andrew Burgess  <andrew.burgess@embecosm.com>
2617             Pedro Alves  <palves@redhat.com>
2618
2619         * infrun.c (fetch_inferior_event): Use scope_exit.
2620         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2621         * top.c (execute_command): Use scope_exit.
2622         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2623         * utils.c (do_bpstat_clear_actions_cleanup)
2624         (make_bpstat_clear_actions_cleanup): Remove.
2625
2626 2019-01-23  Tom Tromey  <tom@tromey.com>
2627             Pedro Alves  <palves@redhat.com>
2628
2629         * infrun.c: Include "common/scope-exit.h"
2630         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2631         (wait_for_inferior): Use SCOPE_EXIT.
2632         (fetch_inferior_event): Use scope_exit.
2633
2634 2019-01-23  Tom Tromey  <tom@tromey.com>
2635             Pedro Alves  <palves@redhat.com>
2636
2637         * breakpoint.c (create_breakpoint): Remove cleanup.
2638
2639 2019-01-23  Tom Tromey  <tom@tromey.com>
2640             Andrew Burgess  <andrew.burgess@embecosm.com>
2641             Pedro Alves  <palves@redhat.com>
2642
2643 2019-01-23  Pedro Alves  <palves@redhat.com>
2644
2645         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2646
2647 2019-01-23  Pedro Alves  <palves@redhat.com>
2648             Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * gdbthread.h: Include "common/forward-scope-exit.h".
2651         (scoped_finish_thread_state): Redefine custom class in terms of
2652         forward_scope_exit.
2653
2654 2019-01-23  Pedro Alves  <palves@redhat.com>
2655             Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * common/forward-scope-exit.h: New file.
2658
2659 2019-01-23  Pedro Alves  <palves@redhat.com>
2660             Andrew Burgess  <andrew.burgess@embecosm.com>
2661             Tom Tromey  <tom@tromey.com>
2662
2663         * common/scope-exit.h: New file.
2664
2665 2019-01-23  Pedro Alves  <palves@redhat.com>
2666
2667         * common/preprocessor.h (ESC): Rename to ...
2668         (ESC_PARENS): ... this.
2669         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2670         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2671
2672 2019-01-23  Tom Tromey  <tom@tromey.com>
2673
2674         * language.h (class scoped_switch_to_sym_language_if_auto):
2675         Initialize m_lang in both cases.
2676
2677 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2678
2679         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2680         with XCNEW.
2681
2682 2019-01-22  Tom Tromey  <tom@tromey.com>
2683
2684         * corelow.c: Do not include sys/file.h.
2685
2686 2019-01-22  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-wingeneral.h: Include gdb_curses.h.
2689
2690 2019-01-22  Tom Tromey  <tom@tromey.com>
2691
2692         * source-cache.h (class source_cache) <get_source_lines,
2693         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2694
2695 2019-01-22  Tom Tromey  <tom@tromey.com>
2696
2697         * remote-fileio.h (struct remote_target): Declare.
2698
2699 2019-01-22  Tom Tromey  <tom@tromey.com>
2700
2701         * python/py-arch.c: Do not include py-ref.h.
2702         * python/py-bpevent.c: Do not include py-ref.h.
2703         * python/py-cmd.c: Do not include py-ref.h.
2704         * python/py-continueevent.c: Do not include py-ref.h.
2705         * python/py-event.h: Do not include py-ref.h.
2706         * python/py-evtregistry.c: Do not include py-ref.h.
2707         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2708         * python/py-frame.c: Do not include py-ref.h.
2709         * python/py-framefilter.c: Do not include py-ref.h.
2710         * python/py-function.c: Do not include py-ref.h.
2711         * python/py-infevents.c: Do not include py-ref.h.
2712         * python/py-linetable.c: Do not include py-ref.h.
2713         * python/py-objfile.c: Do not include py-ref.h.
2714         * python/py-param.c: Do not include py-ref.h.
2715         * python/py-prettyprint.c: Do not include py-ref.h.
2716         * python/py-progspace.c: Do not include py-ref.h.
2717         * python/py-symbol.c: Do not include py-ref.h.
2718         * python/py-symtab.c: Do not include py-ref.h.
2719         * python/py-type.c: Do not include py-ref.h.
2720         * python/py-unwind.c: Do not include py-ref.h.
2721         * python/py-utils.c: Do not include py-ref.h.
2722         * python/py-value.c: Do not include py-ref.h.
2723         * python/py-varobj.c: Do not include py-ref.h.
2724         * python/py-xmethods.c: Do not include py-ref.h.
2725         * python/python.c: Do not include py-ref.h.
2726         * varobj.c: Do not include py-ref.h.
2727
2728 2019-01-22  Tom Tromey  <tom@tromey.com>
2729
2730         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2731         keyword for bcache.
2732
2733 2019-01-22  Tom Tromey  <tom@tromey.com>
2734
2735         * compile/compile-cplus-types.c: Remove a comment by #include.
2736
2737 2019-01-22  Tom Tromey  <tom@tromey.com>
2738
2739         * compile/gcc-c-plugin.h: Include compile-internal.h.
2740
2741 2019-01-22  Tom Tromey  <tom@tromey.com>
2742
2743         * stabsread.c (EXTERN): Do not define.
2744         (symnum, next_symbol_text_func, processing_gcc_compilation)
2745         (within_function, global_sym_chain, global_stabs)
2746         (previous_stab_code, this_object_header_files)
2747         (n_this_object_header_files)
2748         (n_allocated_this_object_header_files): Define.
2749         * stabsread.h (EXTERN): Never define.  Use "extern".
2750
2751 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2752
2753         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2754         history_value.
2755
2756 2019-01-21  Tom Tromey  <tom@tromey.com>
2757
2758         * ui-out.c: Fix includes.
2759         * tui/tui-source.c: Fix includes.
2760         * target.c: Fix includes.
2761         * remote.c: Fix includes.
2762         * regcache.c: Fix includes.
2763         * python/py-block.c: Fix includes.
2764         * printcmd.c: Fix includes.
2765         * or1k-tdep.c: Fix includes.
2766         * mi/mi-main.c: Fix includes.
2767         * m32r-tdep.c: Fix includes.
2768         * csky-tdep.c: Fix includes.
2769         * compile/compile-cplus-types.c: Fix includes.
2770         * cli/cli-interp.c: Fix includes.
2771
2772 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2773
2774         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2775         for padding.
2776
2777 2019-01-16  Tom Tromey  <tom@tromey.com>
2778
2779         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2780         earlier.
2781         (struct objfile) <msymbols_range>: Move from top level.
2782         <msymbols>: New method.
2783         (class objfile_msymbols): Remove.
2784         * symtab.c (default_collect_symbol_completion_matches_break_on):
2785         Update.
2786         * symmisc.c (dump_msymbols): Update.
2787         * stabsread.c (scan_file_globals): Update.
2788         * objc-lang.c (info_selectors_command, info_classes_command)
2789         (find_methods): Update.
2790         * minsyms.c (find_solib_trampoline_target): Update.
2791         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2792         * coffread.c (coff_symfile_read): Update.
2793         * ada-lang.c (ada_lookup_simple_minsym)
2794         (ada_collect_symbol_completion_matches): Update.
2795
2796 2019-01-16  Tom Tromey  <tom@tromey.com>
2797
2798         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2799         type.  Remove no-argument constructor.
2800         <iterator::operator++>: Simplify.
2801         <begin>: Update.
2802         <end>: Use minimal_symbol_count.
2803
2804 2019-01-16  Tom Tromey  <tom@tromey.com>
2805
2806         * objfiles.h (struct objfile) <psymtabs>: New method.
2807         (class objfile_psymtabs): Remove.
2808         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2809         typedef.
2810         <range>: New method.
2811         (require_partial_symbols): Change return type.
2812         * psymtab.c (require_partial_symbols)
2813         (psym_expand_symtabs_matching): Update.
2814         * mdebugread.c (parse_partial_symbols): Update.
2815         * dbxread.c (dbx_end_psymtab): Update.
2816
2817 2019-01-15  Tom Tromey  <tom@tromey.com>
2818
2819         * symtab.c (lookup_objfile_from_block)
2820         (lookup_symbol_in_objfile_symtabs)
2821         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2822         (find_line_symtab, info_sources_command)
2823         (default_collect_symbol_completion_matches_break_on)
2824         (make_source_files_completion_list): Update.
2825         * symmisc.c (print_objfile_statistics, dump_objfile)
2826         (maintenance_print_symbols, maintenance_info_symtabs)
2827         (maintenance_check_symtabs, maintenance_info_line_tables):
2828         Update.
2829         * source.c (select_source_symtab)
2830         (forget_cached_source_info_for_objfile): Update.
2831         * objfiles.h (class objfile_compunits): Remove.
2832         (struct objfile) <compunits_range>: New typedef.
2833         (compunits): New method.
2834         * objfiles.c (objfile_relocate1): Update.
2835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2836         * maint.c (count_symtabs_and_blocks): Update.
2837         * linespec.c (iterate_over_all_matching_symtabs): Update.
2838         * cp-support.c (add_symbol_overload_list_qualified): Update.
2839         * coffread.c (coff_symtab_read): Update.
2840         * ada-lang.c (add_nonlocal_symbols)
2841         (ada_collect_symbol_completion_matches)
2842         (ada_add_global_exceptions): Update.
2843
2844 2019-01-15  Tom Tromey  <tom@tromey.com>
2845
2846         * progspace.h (program_space) <objfiles_safe_range>: New
2847         typedef.
2848         <objfiles_safe>: New method.
2849         * objfiles.h (class all_objfiles_safe): Remove.
2850         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2851         * jit.c (jit_inferior_exit_hook): Update.
2852
2853 2019-01-17  Tom Tromey  <tom@tromey.com>
2854
2855         * progspace.h (program_space) <objfiles_range>: New typedef.
2856         <objfiles>: New method.
2857         <objfiles_head>: Rename from objfiles.
2858         (object_files): Update.
2859         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2860         * guile/scm-pretty-print.c
2861         (ppscm_find_pretty_printer_from_objfiles): Update.
2862         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2863         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2864         Update.
2865         * python/py-progspace.c (pspy_get_objfiles): Update.
2866         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2867         Update.
2868         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2869         (objfpy_lookup_objfile_by_build_id): Update.
2870         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2871         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2872         Update.
2873         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2874         (expand_symtab_containing_pc, lookup_objfile_from_block)
2875         (lookup_static_symbol, basic_lookup_transparent_type)
2876         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2877         (find_line_symtab, info_sources_command)
2878         (default_collect_symbol_completion_matches_break_on)
2879         (make_source_files_completion_list, find_main_name): Update.
2880         * symmisc.c (print_symbol_bcache_statistics)
2881         (print_objfile_statistics, maintenance_print_symbols)
2882         (maintenance_print_msymbols, maintenance_print_objfiles)
2883         (maintenance_info_symtabs, maintenance_check_symtabs)
2884         (maintenance_expand_symtabs, maintenance_info_line_tables):
2885         Update.
2886         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2887         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2888         (map_overlay_command, unmap_overlay_command)
2889         (simple_overlay_update, expand_symtabs_matching)
2890         (map_symbol_filenames): Update.
2891         * symfile-debug.c (set_debug_symfile): Update.
2892         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2893         Update.
2894         * source.c (select_source_symtab, forget_cached_source_info):
2895         Update.
2896         * solib.c (solib_read_symbols): Update.
2897         * solib-spu.c (append_ocl_sos): Update.
2898         * psymtab.c (maintenance_print_psymbols)
2899         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2900         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2901         * printcmd.c (info_symbol_command): Update.
2902         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2903         Update.
2904         * objfiles.h (class all_objfiles): Remove.
2905         * objfiles.c (have_partial_symbols, have_full_symbols)
2906         (have_minimal_symbols, qsort_cmp, update_section_map)
2907         (shared_objfile_contains_address_p)
2908         (default_iterate_over_objfiles_in_search_order): Update.
2909         * objc-lang.c (info_selectors_command, info_classes_command)
2910         (find_methods): Update.
2911         * minsyms.c (find_solib_trampoline_target): Update.
2912         * maint.c (maintenance_info_sections)
2913         (maintenance_translate_address, count_symtabs_and_blocks):
2914         Update.
2915         * main.c (captured_main_1): Update.
2916         * linux-thread-db.c (try_thread_db_load_from_pdir)
2917         (has_libpthread): Update.
2918         * linespec.c (iterate_over_all_matching_symtabs)
2919         (search_minsyms_for_name): Update.
2920         * jit.c (jit_find_objf_with_entry_addr): Update.
2921         * hppa-tdep.c (find_unwind_entry)
2922         (hppa_lookup_stub_minimal_symbol): Update.
2923         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2924         Update.
2925         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2926         (elf_gnu_ifunc_resolve_by_got): Update.
2927         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2928         * dwarf-index-write.c (save_gdb_index_command): Update.
2929         * cp-support.c (add_symbol_overload_list_qualified): Update.
2930         * breakpoint.c (create_overlay_event_breakpoint)
2931         (create_longjmp_master_breakpoint)
2932         (create_std_terminate_master_breakpoint)
2933         (create_exception_master_breakpoint): Update.
2934         * blockframe.c (find_pc_partial_function): Update.
2935         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2936         (ada_collect_symbol_completion_matches)
2937         (ada_add_global_exceptions): Update.
2938
2939 2019-01-17  Tom Tromey  <tom@tromey.com>
2940
2941         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2942         declare VEC.
2943         (solib_target_parse_libraries): Change return type.
2944         (library_list_start_segment, library_list_start_section)
2945         (library_list_end_library, library_list_start_library); Update.
2946         (solib_target_free_library_list): Remove.
2947         (solib_target_parse_libraries): Remove cleanup.  Change return
2948         type.
2949         (solib_target_current_sos): Update.
2950
2951 2019-01-17  Tom Tromey  <tromey@bapiya>
2952
2953         * valprint.c: Replace "the the" with "the".
2954         * symtab.c: Replace "the the" with "the".
2955         * solib.c: Replace "the the" with "the".
2956         * solib-dsbt.c: Replace "the the" with "the".
2957         * linespec.c: Replace "the the" with "the".
2958         * dwarf2loc.h: Replace "the the" with "the".
2959         * amd64-windows-tdep.c: Replace "the the" with "the".
2960         * aarch64-tdep.c: Replace "the the" with "the".
2961
2962 2019-01-16  Keith Seitz  <keiths@redhat.com>
2963
2964         PR gdb/23773
2965         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2966         <builder>: Rename to ..
2967         <m_builder>: ... this and make private.
2968         (dwarf2_cu::get_builder): New method.  Change all users of
2969         `builder' to use this method.
2970         (dwarf2_start_symtab): Move to ...
2971         (dwarf2_cu::start_symtab): ... here.  Update all callers
2972         (setup_type_unit_groups): Move to ...
2973         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2974         callers.
2975         (dwarf2_cu::reset_builder): New method.
2976         (process_full_compunit, process_full_type_unit): Use
2977         dwarf2_cu::reset_builder.
2978         (follow_die_offset): Record the ancestor CU if it is different
2979         from the followed DIE's CU.
2980         (follow_die_sig_1): Likewise.
2981
2982 2019-01-15  Tom Tromey  <tom@tromey.com>
2983
2984         * remote.c (class remote_state) <buf>: Now a char_vector.
2985         <buf_size>: Remove.
2986         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2987         parameter.
2988         (remote_target::getpkt_or_notif_sane_1)
2989         (remote_target::getpkt_sane)
2990         (remote_target::getpkt_or_notif_sane): Likewise.
2991         (class remote_target) <putpkt>: New overload.
2992         (remote_target::read_frame): Change type of "buf_p".  Remove
2993         sizeof_p parameter.
2994         (packet_ok): New overload.
2995         (packet_check_result): New overload.
2996         Update all uses.
2997
2998 2019-01-14  Tom Tromey  <tom@tromey.com>
2999
3000         * remote-notif.c (handle_notification, remote_notif_ack)
3001         (remote_notif_parse): Make "buf" const.
3002         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3003         const.
3004         (remote_notif_parse, remote_notif_ack, handle_notification):
3005         Likewise.
3006         * remote.c (remote_notif_stop_parse): Make "buf" const.
3007         (remote_target::remote_parse_stop_reply): Make "buf" const.
3008         (remote_notif_stop_ack): Make "buf" const.
3009
3010 2019-01-14  Tom Tromey  <tom@tromey.com>
3011
3012         * remote.c (remote_console_output): Make parameter const.
3013
3014 2019-01-14  Tom Tromey  <tom@tromey.com>
3015
3016         * target-debug.h (target_debug_print_signals): Constify.
3017         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3018         * procfs.c (procfs_target::pass_signals): Update.
3019         * linux-nat.c (linux_nat_target::pass_signals): Update.
3020         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3021         * target-delegates.c: Rebuild.
3022         * remote.c (remote_target::program_signals): Update.
3023         (remote_target::pass_signals): Update.
3024         * target.c (target_pass_signals): Constify argument.
3025         (target_program_signals): Likewise.
3026         * target.h (struct target_ops) <pass_signals, program_signals>:
3027         Constify argument.
3028         (target_pass_signals, target_program_signals): Constify argument.
3029
3030 2019-01-14  Tom Tromey  <tom@tromey.com>
3031
3032         PR tui/28819:
3033         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3034
3035 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3036
3037         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3038         field.
3039         * rs6000-tdep.c: Include reggroups.h.
3040         (IS_V_ALIAS_PSEUDOREG): Define.
3041         (rs6000_register_name): Return names for the "vX" aliases.
3042         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3043         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3044         aliases.  Call default_register_reggroup_p for all other
3045         pseudo-registers.
3046         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3047         New functions.
3048         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3049         Handle "vX" aliases.
3050         (v_alias_pseudo_register_collect): New function.
3051         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3052         (rs6000_gdbarch_init): Initialize "vX" aliases as
3053         pseudo-registers.  Restore registration of
3054         rs6000_pseudo_register_reggroup_p with
3055         set_tdesc_pseudo_register_reggroup_p.
3056
3057 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3058
3059         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3060         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3061         set_gdbarch_num_pseudo_regs.
3062
3063 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3064
3065         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3066         Remove arg prefixname, add do_set and do_show.
3067         Add member functions set_list and show_list.
3068         * cli/cli-style.c (class cli_style_option): Update accordingly.
3069         (style_set_list): Move to file scope.
3070         (style_show_list): Likewise.
3071         (set_style): Call help_list.
3072         (show_style): Call cmd_show_list.
3073         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3074         Update to use the new macro.
3075
3076 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3077
3078         * ada-lang.c (_initialize_ada_language): Expand the help text
3079         for the "catch exception" command.
3080
3081 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3082
3083         * symtab.c (matching_obj_sections): Initialize obj,
3084         declare it closer to its usage.
3085
3086 2019-01-10  Tom Tromey  <tom@tromey.com>
3087
3088         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3089         (basic_inf_threads_range): Remove.
3090         (inf_threads_range, inf_non_exited_threads_range)
3091         (safe_inf_threads_range): Use next_adapter.
3092
3093 2019-01-10  Keith Seitz  <keiths@redhat.com>
3094
3095         PR gdb/23712
3096         PR symtab/23010
3097         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3098         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3099
3100 2019-01-10  Keith Seitz  <keiths@redhat.com>
3101
3102         PR gdb/23712
3103         PR symtab/23010
3104         * dictionary.c (pending_to_vector): Remove.
3105         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3106         Remove _1 suffix, replacing functions of the same name.  Update
3107         all callers.
3108         (dict_create_hashed, dict_create_hashed_expandable)
3109         (dict_create_linear, dict_create_linear_expandable, dict_free)
3110         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3111         Make functions static.
3112
3113 2019-01-10  Keith Seitz  <keiths@redhat.com>
3114
3115         PR gdb/23712
3116         PR symtab/23010
3117         * dictionary.h (struct dictionary): Replace declaration with
3118         multidictionary.
3119         (dict_create_hashed, dict_create_hashed_expandable)
3120         (dict_create_linear, dict_create_linear_expandable)
3121         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3122         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3123         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3124         taking multidictionary argument.
3125         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3126         * block.h (struct block) <dict>: Change to multidictionary
3127         and rename `multidict'.
3128         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3129         symmisc.c: Update all dictionary references to multidictionary.
3130
3131 2019-01-10  Keith Seitz  <keiths@redhat.com>
3132
3133         PR gdb/23712
3134         PR symtab/23010
3135         * dictionary.c: Include unordered_map.
3136         (pending_to_vector): New function.
3137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3138         Rewrite the non-"_1" functions to take vector instead
3139         of linked list.
3140         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3141         "new" _1 versions of the same name.
3142         (multidictionary): Define.
3143         (std::hash<enum language): New definition.
3144         (collate_pending_symbols_by_language, mdict_create_hashed)
3145         (mdict_create_hashed_expandable, mdict_create_linear)
3146         (mdict_create_linear_expandable, mdict_free)
3147         (find_language_dictionary, create_new_language_dictionary)
3148         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3149         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3150         (mdict_size, mdict_empty): New functions.
3151         * dictionary.h (mdict_iterator): Define.
3152
3153 2019-01-10  Pedro Alves  <palves@redhat.com>
3154
3155         * breakpoint.c (read_uploaded_action)
3156         (create_tracepoint_from_upload): Adjust to use
3157         gdb::unique_xmalloc_ptr.
3158         * ctf.c (ctf_write_uploaded_tp):
3159         (SET_ARRAY_FIELD): Use emplace_back.
3160         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3161         * tracefile-tfile.c (tfile_write_uploaded_tp):
3162         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3163         gdb::unique_xmalloc_ptr.
3164         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3165         at_string, cond_string, cmd_strings>: Replace char pointers
3166         with gdb::unique_xmalloc_ptr.
3167
3168 2019-01-10  Pedro Alves  <palves@redhat.com>
3169
3170         * solib-target.c (library_list_start_library): Don't xstrdup name.
3171
3172 2019-01-10  Pedro Alves  <palves@redhat.com>
3173
3174         * mdebugread.c (parse_partial_symbols): Use
3175         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3176
3177 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3178
3179         * linux-fork.c (scoped_switch_fork_info)
3180         <~scoped_switch_fork_info>: Fix incorrect variable name.
3181
3182 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3183
3184         * linux-fork.c (scoped_switch_fork_info)
3185         <scoped_switch_fork_info>: Make explicit.
3186         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3187
3188 2019-01-10  Tom Tromey  <tom@tromey.com>
3189
3190         * objfiles.h (objfile::reset_psymtabs): Update.
3191         * objfiles.c (objfile::objfile): Update.
3192         * psymtab.h (psymtab_storage::obstack): Update.
3193         (psymtab_storage::m_obstack): Use gdb::optional.
3194         (class psymtab_storage): Update comment.  Remove objfile
3195         parameter.
3196         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3197
3198 2019-01-10  Tom Tromey  <tom@tromey.com>
3199
3200         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3201         <free_psymtabs>: Now private.
3202         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3203         (allocate_psymtab): Use new method.
3204
3205 2019-01-10  Tom Tromey  <tom@tromey.com>
3206
3207         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3208         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3209         * mdebugread.c (parse_partial_symbols): Use
3210         allocate_dependencies.
3211         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3212         allocate_dependencies.
3213         (process_psymtab_comp_unit_reader)
3214         (build_type_psymtab_dependencies): Likewise.
3215         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3216
3217 2019-01-10  Tom Tromey  <tom@tromey.com>
3218
3219         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3220         PSYMBOL_SET_LANGUAGE.
3221         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3222
3223 2019-01-10  Tom Tromey  <tom@tromey.com>
3224
3225         * psymtab.h (psymtab_storage::obstack): New method.
3226         <m_obstack>: Rename from obstack; now private.
3227         * psymtab.c (psymtab_storage): Update.
3228         * dwarf2read.c (create_addrmap_from_index)
3229         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3230         Update.
3231
3232 2019-01-10  Tom Tromey  <tom@tromey.com>
3233
3234         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3235         * objfiles.h (objfile::reset_psymtabs): New method.
3236
3237 2019-01-10  Tom Tromey  <tom@tromey.com>
3238
3239         * symmisc.c (print_symbol_bcache_statistics): Update.
3240         (print_objfile_statistics): Update.
3241         * symfile.c (reread_symbols): Update.
3242         * psymtab.h (class psymtab_storage): New.
3243         * psymtab.c (psymtab_storage): New constructor.
3244         (~psymtab_storage): New destructor.
3245         (require_partial_symbols): Update.
3246         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3247         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3248         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3249         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3250         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3251         (start_psymtab_common, end_psymtab_common)
3252         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3253         (allocate_psymtab): Update.
3254         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3255         Update.
3256         (dump_psymtab_addrmap, maintenance_print_psymbols)
3257         (maintenance_check_psymtabs): Update.
3258         (class objfile_psymtabs): Move to objfiles.h.
3259         * psympriv.h (discard_psymtab): Now inline.
3260         (psymtab_discarder::psymtab_discarder): Update.
3261         (psymtab_discarder::~psymtab_discarder): Update.
3262         (ALL_OBJFILE_PSYMTABS): Rewrite.
3263         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3264         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3265         Remove fields.
3266         <partial_symtabs>: New field.
3267         (class objfile_psymtabs): Move from psymtab.h.  Update.
3268         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3269         psymbol_cache.
3270         (objfile::~objfile): Don't destroy psymbol_cache.
3271         * mdebugread.c (parse_partial_symbols): Update.
3272         * dwarf2read.c (create_addrmap_from_index)
3273         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3274         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3275         (add_partial_subprogram, dwarf2_ranges_read): Update.
3276         * dwarf-index-write.c (write_address_map)
3277         (write_one_signatured_type, recursively_write_psymbols)
3278         (class debug_names, class debug_names, write_psymtabs_to_index):
3279         Update.
3280
3281 2019-01-10  Tom Tromey  <tom@tromey.com>
3282
3283         * symtab.h (SYMBOL_SET_NAMES): Update.
3284         (symbol_set_names): Update.
3285         (MSYMBOL_SET_NAMES): Update.
3286         * symtab.c (symbol_set_names): Change argument to be an
3287         objfile_per_bfd_storage.
3288         * psymtab.c (add_psymbol_to_bcache): Update.
3289         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3290
3291 2019-01-10  Tom Tromey  <tom@tromey.com>
3292
3293         * symtab.c (create_demangled_names_hash): Change argument to be an
3294         objfile_per_bfd_storage.
3295         (symbol_set_names): Update.
3296
3297 2019-01-10  Tom Tromey  <tom@tromey.com>
3298
3299         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3300         init_psymbol_list.
3301         * psymtab.c (init_psymbol_list): Do nothing if already called.
3302         * psympriv.h (init_psymbol_list): Add comment.
3303         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3304         init_psymbol_list.
3305         * dbxread.c (dbx_symfile_read): Unconditionally call
3306         init_psymbol_list.
3307
3308 2019-01-10  Tom Tromey  <tom@tromey.com>
3309
3310         * xcoffread.c (scan_xcoff_symtab): Update.
3311         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3312         "where".
3313         * mdebugread.c (parse_partial_symbols)
3314         (handle_psymbol_enumerators): Update.
3315         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3316         * dbxread.c (read_dbx_symtab): Update.
3317         * psympriv.h (psymbol_placement): New enum.
3318         (add_psymbol_to_list): Update.
3319
3320 2019-01-10  Tom Tromey  <tom@tromey.com>
3321
3322         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3323         static_psymbols parameters.
3324         (scan_xcoff_symtab): Update.
3325         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3326         static_psymbols parameters.
3327         * psympriv.h (start_psymtab_common): Update.
3328         * mdebugread.c (parse_partial_symbols): Update.
3329         * dwarf2read.c (create_partial_symtab): Update.
3330         * dbxread.c (read_dbx_symtab): Update.
3331         (start_psymtab): Remove global_psymbols and static_psymbols
3332         parameters.
3333
3334 2019-01-10  Tom Tromey  <tom@tromey.com>
3335
3336         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3337         * psymtab.c (allocate_psymtab): Add comment.
3338         * psympriv.h (allocate_psymtab): Add comment.
3339         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3340         initializations.
3341         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3342
3343 2019-01-10  Tom Tromey  <tom@tromey.com>
3344
3345         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3346         Don't declare.
3347         * mipsread.c: Include mdebugread.h.
3348         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3349         Declare.
3350         * elfread.c: Include mdebugread.h.
3351
3352 2019-01-09  Tom Tromey  <tom@tromey.com>
3353
3354         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3355         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3356         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3357         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3358         (psym_lookup_symbol, psym_find_last_source_symtab)
3359         (psym_forget_cached_source_info, psym_print_stats)
3360         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3361         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3362         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3363         (psym_find_compunit_symtab_by_address)
3364         (maintenance_print_psymbols, maintenance_info_psymtabs)
3365         (maintenance_check_psymtabs): Use ranged for.
3366         * psymtab.h (class objfile_psymtabs): New.
3367         (require_partial_symbols): Return objfile_psymtabs.
3368         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3369
3370 2019-01-09  Tom Tromey  <tom@tromey.com>
3371
3372         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3373         (find_pc_mapped_section, list_overlays_command)
3374         (map_overlay_command, unmap_overlay_command)
3375         (simple_overlay_update): Use all_objfiles.
3376         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3377         * printcmd.c (info_symbol_command): Use all_objfiles.
3378         * objfiles.h (ALL_OBJSECTIONS): Remove.
3379         * maint.c (maintenance_translate_address): Use all_objfiles.
3380         * gcore.c (gcore_create_callback): Use all_objfiles.
3381         (objfile_find_memory_regions): Likewise.
3382
3383 2019-01-09  Tom Tromey  <tom@tromey.com>
3384
3385         * symtab.c (find_line_symtab, info_sources_command)
3386         (make_source_files_completion_list): Use objfile_compunits.
3387         * source.c (select_source_symtab): Use objfile_compunits.
3388         * objfiles.h (struct objfile): Update comment.
3389         (ALL_OBJFILES): Remove.
3390         (ALL_FILETABS): Remove.
3391         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3392         objfile_compunits.
3393
3394 2019-01-09  Tom Tromey  <tom@tromey.com>
3395
3396         * symmisc.c (print_objfile_statistics, dump_objfile)
3397         (maintenance_print_symbols): Use compunit_filetabs.
3398         * source.c (forget_cached_source_info_for_objfile): Use
3399         compunit_filetabs.
3400         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3401         (ALL_FILETABS): Use compunit_filetabs.
3402         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3403         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3404
3405 2019-01-09  Tom Tromey  <tom@tromey.com>
3406
3407         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3408         (compunit_filetabs): New.
3409         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3410         compunit_filetabs.
3411         (info_sources_command, make_source_files_completion_list): Remove
3412         declaration.
3413         * symmisc.c (print_objfile_statistics, dump_objfile)
3414         (maintenance_print_symbols): Remove declaration.
3415         (maintenance_info_symtabs): Use compunit_filetabs.
3416         (maintenance_info_line_tables): Likewise.
3417         * source.c (select_source_symtab): Change local variable name.
3418         (forget_cached_source_info_for_objfile): Remove declaration.
3419         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3420         * objfiles.c (objfile_relocate1): Remove declaration.
3421         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3422         declaration.
3423         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3424         * coffread.c (coff_symtab_read): Remove declaration.
3425         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3426         compunit_filetabs.
3427
3428 2019-01-09  Tom Tromey  <tom@tromey.com>
3429
3430         * symtab.c (lookup_objfile_from_block)
3431         (find_pc_sect_compunit_symtab, search_symbols)
3432         (default_collect_symbol_completion_matches_break_on): Use
3433         objfile_compunits.
3434         * objfiles.h (ALL_COMPUNITS): Remove.
3435         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3436         * cp-support.c (add_symbol_overload_list_qualified): Use
3437         objfile_compunits.
3438         * ada-lang.c (ada_collect_symbol_completion_matches)
3439         (ada_add_global_exceptions): Use objfile_compunits.
3440
3441 2019-01-09  Tom Tromey  <tom@tromey.com>
3442
3443         * source.c (select_source_symtab)
3444         (forget_cached_source_info_for_objfile): Remove declaration.
3445         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3446         declaration.
3447         * maint.c (count_symtabs_and_blocks): Remove declaration.
3448         * cp-support.c (add_symbol_overload_list_qualified): Remove
3449         declaration.
3450         * coffread.c (coff_symtab_read): Remove declaration.
3451         * symtab.c (lookup_symbol_in_objfile_symtabs)
3452         (basic_lookup_transparent_type_1): Use objfile_compunits.
3453         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3454         (info_sources_command, search_symbols)
3455         (default_collect_symbol_completion_matches_break_on)
3456         (make_source_files_completion_list): Remove declaration.
3457         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3458         (ada_collect_symbol_completion_matches)
3459         (ada_add_global_exceptions): Remove declaration.
3460         * linespec.c (iterate_over_all_matching_symtabs): Use
3461         objfile_compunits.
3462         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3463         (class objfile_compunits): New.
3464         (ALL_COMPUNITS): Use objfile_compunits.
3465         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3466         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3467         objfile_compunits.
3468         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3469
3470 2019-01-09  Tom Tromey  <tom@tromey.com>
3471
3472         * symtab.c (search_symbols)
3473         (default_collect_symbol_completion_matches_break_on): Use
3474         objfile_msymbols.
3475         * ada-lang.c (ada_lookup_simple_minsym)
3476         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3477         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3478         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3479         objfile_msymbols.
3480         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3481         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3482         * objc-lang.c (find_methods): Use objfile_msymbols.
3483         (info_selectors_command, info_classes_command): Likewise.
3484         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3485         * objfiles.h (class objfile_msymbols): New.
3486         (ALL_OBJFILE_MSYMBOLS): Remove.
3487         (ALL_MSYMBOLS): Remove.
3488
3489 2019-01-09  Tom Tromey  <tom@tromey.com>
3490
3491         * common/next-iterator.h (next_adapter): Add Iterator template
3492         parameter.
3493         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3494         (class all_objfiles_safe): New.
3495         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3496         * objfiles.c (put_objfile_before): Update comment.
3497         (add_separate_debug_objfile): Likewise.
3498         (free_all_objfiles): Use all_objfiles_safe.
3499         (objfile_purge_solibs): Likewise.
3500
3501 2019-01-09  Tom Tromey  <tom@tromey.com>
3502
3503         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3504         (expand_symtab_containing_pc, lookup_static_symbol)
3505         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3506         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3507         all_objfiles.
3508         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3509         * breakpoint.c (create_overlay_event_breakpoint)
3510         (create_longjmp_master_breakpoint)
3511         (create_std_terminate_master_breakpoint)
3512         (create_exception_master_breakpoint): Use all_objfiles.
3513         * linux-thread-db.c (try_thread_db_load_from_pdir)
3514         (has_libpthread): Use all_objfiles.
3515         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3516         * linespec.c (iterate_over_all_matching_symtabs)
3517         (search_minsyms_for_name): Use all_objfiles.
3518         * maint.c (maintenance_info_sections): Use all_objfiles.
3519         * main.c (captured_main_1): Use all_objfiles.
3520         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3521         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3522         * guile/scm-pretty-print.c
3523         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3524         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3525         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3526         (maintenance_print_msymbols): Use all_objfiles.
3527         * source.c (select_source_symtab): Use all_objfiles.
3528         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3529         * symfile.c (remove_symbol_file_command)
3530         (expand_symtabs_matching, map_symbol_filenames): Use
3531         all_objfiles.
3532         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3533         all_objfiles.
3534         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3535         * objc-lang.c (find_methods): Use all_objfiles.
3536         * objfiles.c (have_partial_symbols, have_full_symbols)
3537         (have_minimal_symbols, qsort_cmp)
3538         (default_iterate_over_objfiles_in_search_order): Use
3539         all_objfiles.
3540         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3541         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3542         (maintenance_check_psymtabs): Use all_objfiles.
3543         (ALL_PSYMTABS): Remove.
3544         * compile/compile-object-run.c (do_module_cleanup): Use
3545         all_objfiles.
3546         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3547         * cp-support.c (add_symbol_overload_list_qualified): Use
3548         all_objfiles.
3549         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3550         Use all_objfiles.
3551         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3552         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3553         all_objfiles.
3554         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3555         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3556         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3557         Uses all_objfiles.
3558         * solib.c (solib_read_symbols): Use all_objfiles
3559
3560 2019-01-09  Tom Tromey  <tom@tromey.com>
3561
3562         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3563         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3564         all_objfiles.
3565         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3566         * symmisc.c (print_symbol_bcache_statistics)
3567         (print_objfile_statistics, maintenance_print_objfiles)
3568         (maintenance_info_symtabs, maintenance_check_symtabs)
3569         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3570         all_objfiles.
3571         * source.c (forget_cached_source_info): Use all_objfiles.
3572         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3573         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3574         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3575         * objfiles.c (update_section_map): Use all_objfiles.
3576         (shared_objfile_contains_address_p): Likewise.
3577         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3578         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3579
3580 2019-01-09  Tom Tromey  <tom@tromey.com>
3581
3582         * common/next-iterator.h: New file.
3583         * objfiles.h (class all_objfiles): New.
3584         (struct objfile_iterator): New.
3585
3586 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3587
3588         * NEWS: Move the description of the changed "frame", "select-frame",
3589          and "info frame" commands to the Changed commands section.
3590
3591 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3592
3593         * gdbtypes.c (check_stub_method_group): Remove handling of old
3594         mangling schemes.
3595         * linespec.c (find_methods): Likewise.
3596         * stabsread.c (read_member_functions): Likewise.
3597         * valops.c (search_struct_method): Likewise.
3598         (value_struct_elt_for_reference): Likewise.
3599         * NEWS: Mention this change.
3600
3601 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3604         print_source_lines.
3605         * source.c (print_source_lines_base): Update line number check.
3606         (print_source_lines): New function.
3607         (source_lines_range::source_lines_range): New function.
3608         * source.h (class source_lines_range): New class.
3609         (print_source_lines): New declaration.
3610
3611 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3612
3613         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3614
3615 2019-01-08  Tom Tromey  <tom@tromey.com>
3616             Simon Marchi  <simon.marchi@ericsson.com>
3617
3618         PR gdb/24060
3619         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3620         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3621         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3622         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3623         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3624         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3625
3626 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * source.c (select_source_symtab): Move header comment to
3629         declaration in source.h.
3630         (forget_cached_source_info_for_objfile): Likewise.
3631         (forget_cached_source_info): Likewise.
3632         (identify_source_line): Likewise.
3633         * source.h (identify_source_line): Move declaration from symtab.h
3634         and add comment from source.c
3635         (print_source_lines): Likewise.
3636         (forget_cached_source_info_for_objfile): Likewise.
3637         (forget_cached_source_info): Likewise.
3638         (select_source_symtab): Likewise.
3639         (enum print_source_lines_flag): Move definition from symtab.h.
3640         * symtab.h (identify_source_line): Move declaration to source.h.
3641         (print_source_lines): Likewise.
3642         (forget_cached_source_info_for_objfile): Likewise.
3643         (forget_cached_source_info): Likewise.
3644         (select_source_symtab): Likewise.
3645         (enum print_source_lines_flag): Move definition to source.h.
3646         * tui/tui-hooks.c: Add 'source.h' include.
3647
3648 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * source.c (print_source_lines_base): Handle requests to print
3651         reverse line number sequences, and guard against empty lines
3652         string.
3653
3654 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * source.c (print_source_lines_base): Fix skip of '\r' if next
3657         character is '\n'.
3658
3659 2019-01-06  Tom Tromey  <tom@tromey.com>
3660
3661         * c-exp.y (struct c_parse_state) <macro_original_text,
3662         expansion_obstack>: New member.
3663         (macro_original_text, expansion_obstack): Remove globals.
3664         (scan_macro_expansion, scanning_macro_expansion)
3665         (finished_macro_expansion): Update.
3666         (scan_macro_cleanup): Remove.
3667         (yylex, c_parse): Update.
3668
3669 2019-01-06  Tom Tromey  <tom@tromey.com>
3670
3671         * c-exp.y (struct c_parse_state) <strings>: New member.
3672         (operator_stoken): Update.
3673
3674 2019-01-06  Tom Tromey  <tom@tromey.com>
3675
3676         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3677         (union type_stack_elt) <typelist_val>: Now a pointer to
3678         std::vector.
3679         (type_stack_cleanup): Don't declare.
3680         (push_typelist): Update.
3681         * parse.c (pop_typelist): Return a std::vector.
3682         (push_typelist): Take a std::vector.
3683         (follow_types): Update.  Do not free args.
3684         (type_stack_cleanup): Remove.
3685         * c-exp.y (struct c_parse_state): New.
3686         (cpstate): New global.
3687         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3688         (nonempty_typelist): Update.
3689         (func_mod): Create a new vector.
3690         (c_parse): Create a c_parse_state.
3691         (check_parameter_typelist): Do not delete params.
3692         (function_method): Update.  Do not delete type_list.
3693
3694 2019-01-06  Tom Tromey  <tom@tromey.com>
3695
3696         PR gdb/28155:
3697         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3698         check_typedef.
3699         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3700         (print_return_value): Likewise.
3701
3702 2019-01-05  Tom Tromey  <tom@tromey.com>
3703
3704         * contrib/cleanup_check.py: Remove.
3705         * contrib/gcc-with-excheck: Remove.
3706         * contrib/exsummary.py: Remove.
3707         * contrib/excheck.py: Remove.
3708
3709 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3710
3711         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3712         NULL. Initialize tpprev to NULL instead of assigning it
3713         to NULL on the next statement.
3714         * windows-nat.c (windows_delete_thread): Remove check for
3715         main_thread_id before printing thread exit notifications.
3716         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3717         Remove thread ID check against main_thread_id.
3718         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3719         windows_delete_thread.
3720         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3721
3722 2019-01-04  Tom Tromey  <tom@tromey.com>
3723
3724         * compile/compile.c (_initialize_compile): Use upper case for
3725         metasyntactic variables.
3726         * symmisc.c (_initialize_symmisc): Use upper case for
3727         metasyntactic variables.
3728         * psymtab.c (_initialize_psymtab): Use upper case for
3729         metasyntactic variables.
3730         * demangle.c (demangle_command): Use upper case for metasyntactic
3731         variables.
3732         (_initialize_demangler): Likewise.
3733         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3734         variables.
3735
3736 2019-01-03  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3739
3740 2019-01-03  Tom Tromey  <tom@tromey.com>
3741
3742         * python/py-symtab.c (salpy_str): Update.
3743         (struct salpy_sal_object) <symtab>: Now a PyObject.
3744         (salpy_dealloc): Update.
3745         (del_objfile_sal): Use gdbpy_ref.
3746
3747 2019-01-03  Tom Tromey  <tom@tromey.com>
3748
3749         * python/py-type.c (convert_field): Use new_reference.  Return
3750         gdbpy_ref.
3751         (make_fielditem): Return gdbpy_ref.
3752         (typy_fields): Update.
3753         (typy_getitem): Update.
3754         (field_name): Return gdbpy_ref.  Use new_reference.
3755         (typy_iterator_iternext): Update.
3756
3757 2019-01-03  Tom Tromey  <tom@tromey.com>
3758
3759         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3760
3761 2019-01-03  Tom Tromey  <tom@tromey.com>
3762
3763         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3764         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3765         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3766         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3767         (pspy_set_type_printers): Likewise.
3768         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3769         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3770         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3771         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3772         (objfpy_set_type_printers): Likewise.
3773
3774 2019-01-03  Tom Tromey  <tom@tromey.com>
3775
3776         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3777         (gdbpy_print_stack): Use gdbpy_err_fetch.
3778         * python/python-internal.h (class gdbpy_err_fetch): New class.
3779         (class gdbpy_enter) <m_error_type, m_error_value,
3780         m_error_traceback>: Remove.
3781         <m_error>: New member.
3782         (gdbpy_exception_to_string): Don't declare.
3783         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3784         * python/py-value.c (convert_value_from_python): Use
3785         gdbpy_err_fetch.
3786         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3787         gdbpy_exception_to_string.
3788         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3789         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3790         gdbpy_err_fetch.
3791
3792 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * linux-nat.c (delete_lwp_cleanup): Delete.
3795         (struct lwp_deleter): New struct.
3796         (lwp_info_up): New typedef.
3797         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3798         lwp_info_up.
3799
3800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * linux-fork.c (class scoped_switch_fork_info): New class.
3803         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3804
3805 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * valops.c (find_overload_match): Remove use of null_cleanup, and
3808         calls to do_cleanups.
3809
3810 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * compile/compile-cplus-types.c
3813         (compile_cplus_instance::decl_name): Handle changes to
3814         cp_func_name.
3815         * cp-support.c (cp_func_name): Update header comment, update
3816         return type.
3817         * cp-support.h (cp_func_name): Update return type in declaration.
3818         * valops.c (find_overload_match): Move temp_func local to top
3819         level of function and change its type.  Use temp_func to hold and
3820         delete temporary string obtained from cp_func_name.
3821
3822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3825         gdb::char_vector, remove cleanup, and update uses of `msg`.
3826
3827 2019-01-03  Jim Wilson  <jimw@sifive.com>
3828
3829         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3830
3831 2019-01-02  Tom Tromey  <tom@tromey.com>
3832
3833         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3834         (tdesc_parse_xml): Remove cleanups.
3835         * target-descriptions.h (make_cleanup_free_target_description):
3836         Don't declare.
3837         (target_desc_deleter): New struct.
3838         (target_desc_up): New typedef.
3839         * target-descriptions.c (target_desc_deleter::operator()): Rename
3840         from free_target_description.
3841         (make_cleanup_free_target_description): Remove.
3842
3843 2019-01-02  Tom Tromey  <tom@tromey.com>
3844
3845         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3846         constructor, destructor.
3847         (linespec_parser): Remove typedef.
3848         (~linespec_parser): Rename from linespec_parser_delete.
3849         (linespec_lex_to_end, linespec_complete_label)
3850         (linespec_complete): Update.
3851         (decode_line_full): Remove cleanups.
3852         (decode_line_1): Update.
3853
3854 2019-01-02  Tom Tromey  <tom@tromey.com>
3855
3856         * python/python-internal.h (inferior_to_inferior_object): Change
3857         return type.
3858         * python/py-exitedevent.c (create_exited_event_object): Update.
3859         * python/py-inferior.c (inferior_to_inferior_object): Return
3860         gdbpy_ref.
3861         (python_new_inferior, python_inferior_deleted)
3862         (thread_to_thread_object, delete_thread_object)
3863         (build_inferior_list, gdbpy_selected_inferior): Update.
3864         * python/py-infthread.c (create_thread_object): Update.  Also fail
3865         if inferior_to_inferior_object fails.
3866
3867 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3868
3869         * inferior.h (class inferior) <displaced_step_state>: New field.
3870         * infrun.h (struct displaced_step_state): Move here from
3871         infrun.c.  Initialize fields, add constructor.
3872         <inf>: Remove field.
3873         <reset>: New method.
3874         * infrun.c (struct displaced_step_inferior_state): Move to
3875         infrun.h.
3876         (displaced_step_inferior_states): Remove.
3877         (get_displaced_stepping_state): Adust.
3878         (displaced_step_in_progress_any_inferior): Adjust.
3879         (displaced_step_in_progress_thread): Adjust.
3880         (displaced_step_in_progress): Adjust.
3881         (add_displaced_stepping_state): Remove.
3882         (get_displaced_step_closure_by_addr): Adjust.
3883         (remove_displaced_stepping_state): Remove.
3884         (infrun_inferior_exit): Call displaced_step_state.reset.
3885         (use_displaced_stepping): Don't check for NULL.
3886         (displaced_step_prepare_throw): Call
3887         get_displaced_stepping_state.
3888         (displaced_step_fixup): Don't check for NULL.
3889         (prepare_for_detach): Don't check for NULL.
3890
3891 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3892
3893         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3894          in case of call that did not complete.
3895
3896 2019-01-02  Andrey Utkin  <autkin@undo.io>
3897
3898         * symfile.c (find_separate_debug_file): Fix search of debug files for
3899         remote debuggee.
3900
3901 2019-01-02  Tom Tromey  <tom@tromey.com>
3902
3903         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3904         indentation.
3905         * python/py-frame.c (frapy_older): Remove cast.
3906         (frapy_newer): Likewise.
3907         * python/py-breakpoint.c (local_setattro): Remove cast.
3908         * python/py-arch.c (archpy_name): Remove local variable.
3909         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3910
3911 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3912
3913         * unittests/basic_string_view/element_access/char/empty.cc:
3914         Fix year range in copyright header.
3915
3916 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3919         Delete.
3920         <operator==>: Update with for removed field.
3921         <hash>: Likewise.
3922         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3923         <isa_features>: ...this.
3924         <abi_features>: New field.
3925         (riscv_isa_flen): Update comment.
3926         (riscv_abi_xlen): New declaration.
3927         (riscv_abi_flen): New declaration.
3928         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3929         isa_features.
3930         (riscv_abi_xlen): New function.
3931         (riscv_isa_flen): Update to get answer from isa_features.
3932         (riscv_abi_flen): New function.
3933         (riscv_has_fp_abi): Update to get answer from abi_features.
3934         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3935         xlen and flen.
3936         (riscv_call_info) <xlen, flen>: Update comment.
3937         (riscv_call_arg_struct): Remove invalid assertions
3938         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3939         is removed.
3940         (riscv_gdbarch_init): Gather isa features and abi features
3941         separately, ensure both match on the gdbarch when reusing an old
3942         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3943         a target with 64-bit float hardware.
3944
3945 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3946
3947         * source.c (search_command_helper): Stop reverse search
3948         when line 1 has been searched.
3949
3950 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3951
3952         * record-full.c (record_full_base_target::close): Rewrite
3953         record_full_core_buf_list free logic.
3954
3955 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3956
3957         * break-catch-syscall.c (print_one_catch_syscall): xfree
3958         the last text.
3959
3960 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3961
3962         * top.c (print_gdb_version): Update Copyright year in version
3963         message.
3964
3965 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3966
3967         Update copyright year range in all GDB files.
3968
3969 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3970
3971         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3972
3973 For older changes see ChangeLog-2018.
3974 \f
3975 Local Variables:
3976 mode: change-log
3977 left-margin: 8
3978 fill-column: 74
3979 version-control: never
3980 coding: utf-8
3981 End:
3982