gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
   4         (struct tui_cmd_window) <can_scroll>: New method.
   5         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
   6         method.
   7
   8 2019-07-17  Tom Tromey  <tromey@adacore.com>
   9
  10         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  11         do_field_signed>: Rename.  Change type of "value".
  12         * ui-out.c (ui_out::field_signed): Rename from field_int.
  13         Change type of "value".
  14         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  15         type of "value".
  16         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  17         do_field_int.  Change type of "value".
  18         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  19         do_field_int.  Change type of "value".
  20         * tracepoint.c (trace_status_mi, tfind_1)
  21         (print_one_static_tracepoint_marker): Update.
  22         * thread.c (print_thread_info_1, print_selected_thread_frame):
  23         Update.
  24         * stack.c (print_frame, print_frame_info): Update.
  25         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  26         Update.
  27         * source.c (print_source_lines_base): Update.
  28         * skip.c (info_skip_command): Update.
  29         * record-btrace.c (btrace_ui_out_decode_error)
  30         (btrace_call_history_src_line): Update.
  31         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
  32         Update.
  33         * progspace.c (print_program_space): Update.
  34         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
  35         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
  36         do_field_int.  Change type of "value".
  37         * mi/mi-out.c (mi_ui_out::do_table_begin)
  38         (mi_ui_out::do_table_header): Update.
  39         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
  40         type of "value".
  41         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
  42         (mi_cmd_data_list_changed_registers, output_register)
  43         (mi_cmd_data_read_memory, mi_load_progress)
  44         (mi_cmd_trace_frame_collected): Update.
  45         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
  46         Update.
  47         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
  48         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
  49         (mi_cmd_var_list_children, varobj_update_one): Update.
  50         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
  51         (mi_cmd_stack_list_args, list_arg_or_local): Update.
  52         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
  53         * inferior.c (print_inferior): Update.
  54         * gdb_bfd.c (print_one_bfd): Update.
  55         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  56         Update.
  57         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
  58         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
  59         do_field_int.  Change type of "value".
  60         * cli-out.c (cli_ui_out::do_field_signed): Rename from
  61         do_field_int.  Change type of "value".
  62         * breakpoint.c (watchpoint_check, print_breakpoint_location)
  63         (print_one_breakpoint_location, print_it_catch_fork)
  64         (print_one_catch_fork, print_it_catch_vfork)
  65         (print_one_catch_vfork, print_it_catch_solib)
  66         (print_it_catch_exec, print_it_ranged_breakpoint)
  67         (print_mention_watchpoint, print_mention_masked_watchpoint)
  68         (bkpt_print_it, update_static_tracepoint): Update.
  69         * break-catch-throw.c (print_it_exception_catchpoint): Update.
  70         * break-catch-syscall.c (print_it_catch_syscall): Update.
  71         * ada-tasks.c (print_ada_task_info): Update.
  72         * ada-lang.c (print_it_exception, print_mention_exception):
  73         Update.
  74
  75 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  76
  77         PR breakpoints/24541
  78         * gdbarch.c: Regenerate.
  79         * gdbarch.h: Regenerate.
  80         * gdbarch.sh: Adjust return type and parameter types for
  81         'stap_adjust_register'.
  82         (i386_stap_adjust_register): Adjust signature and return new
  83         register name.
  84         * stap-probe.c (stap_parse_register_operand): Adjust use of
  85         'gdbarch_stap_adjust_register'.
  86
  87 2019-07-17  Tom Tromey  <tromey@adacore.com>
  88
  89         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
  90         declare VEC.
  91         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
  92         std::vector.
  93         (struct s390_process_info): Add initializers.
  94         (s390_add_process): Use new.
  95         (s390_linux_nat_target::low_forget_process): Use delete.
  96         (s390_linux_nat_target::low_new_fork)
  97         (s390_linux_nat_target::stopped_by_watchpoint)
  98         (s390_linux_nat_target::low_prepare_to_resume)
  99         (s390_linux_nat_target::insert_watchpoint)
 100         (s390_linux_nat_target::insert_hw_breakpoint)
 101         (s390_linux_nat_target::remove_watchpoint)
 102         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 103
 104 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 105
 106         * aarch64-fbsd-nat.c: Include regcache.h.
 107         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 108         argument.
 109         (aarch64_fbsd_nat_target::fetch_registers)
 110         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 111         variable.
 112         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 113
 114 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 115
 116         * fbsd-nat.c: Include gdbarch.h.
 117
 118 2019-07-15  Tom Tromey  <tromey@adacore.com>
 119
 120         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 121
 122 2019-07-15  Tom Tromey  <tromey@adacore.com>
 123
 124         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 125         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 126         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 127         * cli-out.c (cli_ui_out::do_field_int): New method.
 128         * ui-out.c (ui_out::field_unsigned): New method.
 129         * symfile.c (generic_load): Use field_unsigned.
 130         (print_transfer_performance): Likewise.
 131         * record-btrace.c (ui_out_field_uint): Remove.
 132         (btrace_call_history_insn_range, btrace_call_history): Use
 133         field_unsigned.
 134         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 135         field_unsigned.
 136         * ui-out.h (class ui_out) <field_unsigned>: New method.
 137         <do_field_unsigned>: Likewise.
 138
 139 2019-07-15  Tom Tromey  <tromey@adacore.com>
 140
 141         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 142         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 143         * target.c (flash_erase_command): Use field_string.
 144         * infrun.c (print_signal_received_reason): Use field_string.
 145         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 146         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 147         field_string.
 148         * ada-tasks.c (print_ada_task_info): Use field_string.
 149
 150 2019-07-15  Tom Tromey  <tromey@adacore.com>
 151
 152         * target.c (flash_erase_command): Use field_core_addr.
 153         * symfile.c (generic_load): Use field_core_addr.
 154         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 155         Use field_core_addr.
 156         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 157         field_core_addr.
 158
 159 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 160
 161         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 162         value if its desired type is smaller than a CORE_ADDR and signed.
 163
 164 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 167         of changes to field names, and use new is_reference field to
 168         decide if a property is a reference or not.
 169         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 170         field.
 171         (struct dwarf2_property_baton): Update header comment, rename
 172         'referenced_type' to 'property_type' and update comments.
 173         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 174         default property type, store in property baton, update to take
 175         accound of renamed field.
 176         (read_func_scope): Update call to attr_to_dynamic_prop.
 177         (read_array_type): Likewise.
 178         (dwarf2_per_cu_addr_sized_int_type): New function.
 179         (read_subrange_index_type): Move type finding code to
 180         dwarf2_per_cu_addr_sized_int_type.
 181         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 182         (dwarf2_per_cu_addr_type): New function.
 183         (set_die_type): Update calls to attr_to_dynamic_prop.
 184
 185 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 186
 187         * dwarf2read.c (read_subrange_index_type): New function.
 188         (read_subrange_type): Move code into new function and call it.
 189         * gdbtypes.c (create_range_type): Add some asserts.
 190
 191 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 192
 193         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 194         update return statements.
 195         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 196         declaration, and update comment to match.
 197         * gdbtypes.c (resolve_dynamic_array): Update call to
 198         dwarf2_evaluate_property to match new return type.
 199
 200 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * valarith.c (value_subscripted_rvalue): Change lowerbound
 203         parameter type from int to LONGEST.
 204         * value.h (value_subscripted_rvalue): Likewise in declaration.
 205
 206 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * cli/cli-utils.c (info_print_command_completer): New function.
 209         * cli/cli-utils.h: Add 'completer.h' include, and forward
 210         declaration for 'struct cmd_list_element'.
 211         (info_print_command_completer): Declare.
 212         * stack.c (_initialize_stack): Add completer for 'info locals' and
 213         'info args'.
 214         * symtab.c (_initialize_symtab): Add completer for 'info
 215         variables' and 'info functions'.
 216         * NEWS: Mention completion for additional info commands.
 217
 218 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 219
 220         * cli/cli-utils.c (extract_info_print_args): Delete.
 221         (extract_arg_maybe_quoted): Delete.
 222         (info_print_options_defs): New variable.
 223         (make_info_print_options_def_group): New function.
 224         (extract_info_print_options): Define new function.
 225         * cli/cli-utils.h (extract_info_print_args): Delete.
 226         (struct info_print_options): New structure.
 227         (extract_info_print_options): Declare new function.
 228         * stack.c (info_locals_command): Update to use new
 229         extract_info_print_options, also add a header comment.
 230         (info_args_command): Likewise.
 231         * symtab.c (info_variables_command): Likewise.
 232         (info_functions_command): Likewise.
 233
 234 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 235
 236         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 237         to extract string arguments.
 238         * common/common-utils.c (extract_string_maybe_quoted): New function.
 239         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 240
 241 2019-07-11  Tom Tromey  <tromey@adacore.com>
 242
 243         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 244         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 245         * top.h (gdbinit): Don't declare.
 246         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 247         into...
 248         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 249         * top.c (gdb_init): Don't call init_cli_cmds.
 250         (gdbinit): Remove.
 251         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 252
 253 2019-07-11  Tom Tromey  <tromey@adacore.com>
 254
 255         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 256         after it has been moved.
 257
 258 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 259
 260         * valops.c (value_must_coerce_to_target): Change return type to
 261         bool.
 262         * value.h (value_must_coerce_to_target): Likewise.
 263
 264 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 265
 266         * breakpoint.c (is_hardware_watchpoint): Remove
 267         forward-declaration.
 268         (is_masked_watchpoint): Change return type to bool.
 269         (is_tracepoint): Likewise.
 270         (is_breakpoint): Likewise.
 271         (is_hardware_watchpoint): Likewise.
 272         (is_watchpoint): Likewise.
 273         (is_no_memory_software_watchpoint): Likewise.
 274         (is_catchpoint): Likewise.
 275         (breakpoint_1): Make FILTER parameter's return type bool.
 276         is_masked_watchpoint): Change return type to bool.
 277         (save_breakpoints): Make FILTER parameter's return type bool.
 278         * breakpoint.h (is_breakpoint): Change return type to bool.
 279         (is_watchpoint): Likewise.
 280         (is_catchpoint): Likewise.
 281         (is_tracepoint): Likewise.
 282
 283 2019-07-10  Tom Tromey  <tom@tromey.com>
 284
 285         * defs.h: Don't include gdbarch.h.
 286         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 287         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 288         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 289         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 290         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 291         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 292         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 293         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 294         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 295         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 296         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 297         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 298         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 299         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 300         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 301         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 302         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 303         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 304         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 305         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 306         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 307         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 308         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 309         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 310         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 311         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 312         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 313
 314 2019-07-10  Tom Tromey  <tromey@adacore.com>
 315
 316         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 317         * breakpoint.c (init_ada_exception_breakpoint): Register as
 318         bp_catchpoint.
 319         (print_one_breakpoint_location, print_one_breakpoint): Use
 320         is_ada_exception_catchpoint.
 321         * ada-lang.c (class ada_catchpoint_location): Pass
 322         bp_loc_software_breakpoint to bp_location constructor.
 323         (is_ada_exception_catchpoint): New function.
 324
 325 2019-07-10  Tom Tromey  <tromey@adacore.com>
 326
 327         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 328         VEC.
 329         (struct arm_exidx_entry): New method operator<.
 330         (struct arm_exidx_data) <section_maps>: Change type.
 331         (arm_exidx_data_free): Remove.
 332         (arm_exidx_data_key): Change type.  Move lower.
 333         (arm_exidx_new_objfile): Update.
 334         (arm_compare_exidx_entries): Remove.
 335         (arm_find_exidx_entry, _initialize_arm_tdep)
 336
 337 2019-07-10  Tom Tromey  <tromey@adacore.com>
 338
 339         * solib-spu.c (ocl_program_data_key): Change type.
 340         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 341         Update.
 342
 343 2019-07-10  Tom Tromey  <tromey@adacore.com>
 344
 345         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 346         (struct solib_aix_inferior_data) <library_list>: Change type.
 347         (solib_aix_inferior_data_handle): Change type.
 348         (get_solib_aix_inferior_data): Update.
 349         (solib_aix_free_library_list): Remove.
 350         (library_list_start_library): Update.
 351         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 352         return type.
 353         (solib_aix_get_library_list)
 354         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 355         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 356
 357 2019-07-10  Tom Tromey  <tromey@adacore.com>
 358
 359         * solib-dsbt.c (struct dsbt_info): Add initializers.
 360         (solib_dsbt_pspace_data): Change type.
 361         (dsbt_pspace_data_cleanup): Remove.
 362         (get_dsbt_info, _initialize_dsbt_solib): Update.
 363
 364 2019-07-10  Tom Tromey  <tromey@adacore.com>
 365
 366         * spu-tdep.c (spu_overlay_data): Change type.
 367         (spu_get_overlay_table, spu_overlay_new_objfile)
 368         (_initialize_spu_tdep): Update.
 369
 370 2019-07-10  Tom Tromey  <tromey@adacore.com>
 371
 372         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 373         destructor.
 374         (dbx_objfile_data_key): Change type and declare later.
 375         (DBX_SYMFILE_INFO): Rewrite.
 376         * dbxread.c (dbx_objfile_data_key): Change type.
 377         (dbx_symfile_init): Update.
 378         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 379         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 380         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 381
 382 2019-07-10  Tom Tromey  <tromey@adacore.com>
 383
 384         * jit.c (jit_program_space_key): Change type.  Move lower.
 385         (get_jit_program_space_data): Update.
 386         (jit_program_space_data_cleanup): Remove.
 387         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 388         Update.
 389         (struct jit_program_space_data): Add initializers.
 390
 391 2019-07-10  Tom Tromey  <tromey@adacore.com>
 392
 393         * solib-darwin.c (struct darwin_info): Add initializers.
 394         (solib_darwin_pspace_data): Change type.
 395         (darwin_pspace_data_cleanup): Remove.
 396         (get_darwin_info, _initialize_darwin_solib): Update.
 397
 398 2019-07-10  Tom Tromey  <tromey@adacore.com>
 399
 400         * remote-sim.c (struct sim_inferior_data): Add initializers,
 401         constructor, and destructor.
 402         (sim_inferior_data_key): Change type.  Move lower.
 403         (check_for_duplicate_sim_descriptor): Update.
 404         (get_sim_inferior_data): Use new.  Update.
 405         (~sim_inferior_data_cleanup): Rename from
 406         sim_inferior_data_cleanup.  Simplify.
 407         (gdbsim_close_inferior, simulator_command)
 408         (sim_command_completer, _initialize_remote_sim): Update.
 409         (next_pid, INITIAL_PID): Move earlier.
 410
 411 2019-07-10  Tom Tromey  <tromey@adacore.com>
 412
 413         * python/python-internal.h (create_thread_object): Return
 414         gdbpy_ref.
 415         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 416         * python/py-inferior.c (struct threadlist_entry): Add
 417         constructor.
 418         <thread_obj>: Now a gdbpy_ref.
 419         (thread_to_thread_object): Update.
 420         (add_thread_object): Use new.
 421         (delete_thread_object): Use delete.
 422         (infpy_threads): Update.
 423         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 424         GIL.
 425
 426 2019-07-10  Tom Tromey  <tromey@adacore.com>
 427
 428         * valops.c (value_cast): Specialize error message for Ada.
 429
 430 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 431
 432         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 433
 434 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 435
 436         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 437         bpstat_should_step): Return bool, adjust comments.
 438         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 439         bpstat_should_step): Likewise.
 440
 441 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 442
 443         * features/Makefile: Use feature target descriptions for Arm.
 444         * features/arm/arm-core.c: Generate new file.
 445         * features/arm/arm-fpa.c: Likewise.
 446         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 447         * features/arm/arm-m-profile.c: Likewise.
 448         * features/arm/arm-vfpv2.c: Likewise.
 449         * features/arm/arm-vfpv3.c: Likewise.
 450         * features/arm/xscale-iwmmxt.c: Likewise.
 451         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 452
 453 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 454
 455         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 456         ptrace earlier.
 457
 458 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 459
 460         * features/aarch64-pauth.c: Regenerate.
 461
 462 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 463
 464         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 465         bool.
 466         (bpstat_what): Use false instead of 0.
 467
 468 2019-07-09  Pedro Alves  <palves@redhat.com>
 469
 470         * break-catch-throw.c (is_exception_catchpoint): New.
 471         * breakpoint.c (print_one_breakpoint_location): New parameter
 472         'raw_loc'.  Handle it.  Use
 473         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 474         looking at the breakpoint's type.
 475         (print_one_breakpoint): If handling "maint info breakpoints", also
 476         print locations of exception catchpoints.
 477         * breakpoint.h (is_exception_catchpoint): Declare.
 478
 479 2019-07-09  Pedro Alves  <palves@redhat.com>
 480
 481         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 482         "addr" field.
 483         (allocate_location_exception_catchpoint): New.
 484         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 485         (initialize_throw_catchpoint_ops): Install
 486         allocate_location_exception_catchpoint as allocate_location
 487         method.
 488         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 489         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 490         bp_loc_other.
 491         (breakpoint_address_is_meaningful): Delete.
 492         (bl_address_is_meaningful): New.
 493         (breakpoint_locations_match): Adjust comment.
 494         (bp_location_from_bp_type): New, factored out of...
 495         (bp_location::bp_location(breakpoint *)): ... this.
 496         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 497         factored out of...
 498         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 499         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 500         breakpoint_address_is_meaningful.
 501         (bp_locations_compare): Adjust comment.
 502         (update_global_location_list): Use bl_address_is_meaningful
 503         instead of breakpoint_address_is_meaningful.
 504         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 505         explicit.
 506         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 507         * python/py-breakpoint.c (bppy_get_location): No longer check
 508         whether location is null.
 509
 510 2019-07-09  Pedro Alves  <palves@redhat.com>
 511
 512         PR c++/15468
 513         * breakpoint.c (print_one_breakpoint_location): Remove
 514         single-location assert.
 515
 516 2019-07-09  Tom Tromey  <tom@tromey.com>
 517
 518         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 519         * configure: Rebuild.
 520         * configure.ac: Change common to gdbsupport.
 521         * gdbsupport: Rename from common.
 522         * acinclude.m4: Change common to gdbsupport.
 523         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 524         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 525         gdbsupport.
 526         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 527         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 528         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 529         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 530         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 531         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 532         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 533         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 534         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 535         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 536         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 537         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 538         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 539         coff-pe-read.c, command.h, compile/compile-c-support.c,
 540         compile/compile-c.h, compile/compile-cplus-symbols.c,
 541         compile/compile-cplus-types.c, compile/compile-cplus.h,
 542         compile/compile-loc2c.c, compile/compile.c, completer.c,
 543         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 544         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 545         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 546         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 547         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 548         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 549         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 550         features/aarch64-core.c, features/aarch64-fpu.c,
 551         features/aarch64-pauth.c, features/aarch64-sve.c,
 552         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 553         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 554         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 555         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 556         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 557         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 558         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 559         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 560         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 561         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 562         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 563         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 564         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 565         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 566         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 567         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 568         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 569         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 570         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 571         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 572         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 573         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 574         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 575         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 576         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 577         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 578         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 579         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 580         minsyms.c, mips-linux-tdep.c, namespace.h,
 581         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 582         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 583         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 584         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 585         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 586         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 587         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 588         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 589         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 590         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 591         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 592         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 593         procfs.c, producer.c, progspace.h, psymtab.h,
 594         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 595         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 596         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 597         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 598         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 599         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 600         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 601         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 602         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 603         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 604         target-memory.c, target.c, target.h, target/waitstatus.c,
 605         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 606         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 607         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 608         unittests/array-view-selftests.c,
 609         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 610         unittests/common-utils-selftests.c,
 611         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 612         unittests/format_pieces-selftests.c,
 613         unittests/function-view-selftests.c,
 614         unittests/lookup_name_info-selftests.c,
 615         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 616         unittests/mkdir-recursive-selftests.c,
 617         unittests/observable-selftests.c,
 618         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 619         unittests/parse-connection-spec-selftests.c,
 620         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 621         unittests/scoped_fd-selftests.c,
 622         unittests/scoped_mmap-selftests.c,
 623         unittests/scoped_restore-selftests.c,
 624         unittests/string_view-selftests.c, unittests/style-selftests.c,
 625         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 626         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 627         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 628         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 629         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 630         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 631
 632 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 635         bool value.
 636         (decode_digits_ordinary): Set explicit_line field in sal.
 637         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 638         symtab_and_line that was set on an explicit line number in
 639         assembler code.  Do always update the recorded symtab and line if
 640         we do skip the prologue.
 641
 642 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * breakpoint.c (set_breakpoint_location_function): Remove
 645         explicit_loc parameter.
 646         (momentary_breakpoint_from_master): Update call to
 647         set_breakpoint_location_function.
 648         (add_location_to_breakpoint): Likewise.
 649
 650 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 653         required features based on default bfd type when no specific bfd
 654         is present.
 655
 656 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 657
 658         * NEWS: Mention that GDB printf and eval commands can now print
 659         C-style and Ada-style convenience var strings without
 660         calling the inferior.
 661         * printcmd.c (printf_c_string): Locally print GDB internal var
 662         instead of transiting via the inferior.
 663         (printf_wide_c_string): Likewise.
 664
 665 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 666
 667         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 668
 669 2019-07-04  Tom Tromey  <tom@tromey.com>
 670
 671         PR tui/24724:
 672         * tui/tui-winsource.c (tui_clear_source_content): Update.
 673         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 674         (tui_update_breakpoint_info): Update.
 675         (tui_set_exec_info_content): Update.
 676         * tui/tui-source.c (tui_set_source_content_nil): Update.
 677         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 678         has_break.
 679         * tui/tui-data.h (enum tui_bp_flag): New.
 680         (tui_bp_flags): New enum flags type.
 681         (struct tui_source_element) <break_mode>: Change type.  Rename
 682         from has_break.
 683         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 684         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 685         constants.
 686         * tui/tui-winsource.h: Fix comment.
 687
 688 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 689
 690         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 691         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 692         (store_fpregs_to_thread)
 693         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 694         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 695         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 696         (IWMMXT_REGS_SIZE): Add define.
 697         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 698         (fetch_vfp_regs, store_vfp_regs)
 699         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 700         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 701
 702 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 703
 704         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 705         defines.
 706         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 707         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 708         (ARM_INT_REGISTER_SIZE): ...to this.
 709         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 710         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 711         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 712         (arm_linux_collect_gregset, supply_nwfpe_register)
 713         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 714         defines.
 715         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 716         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 717         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 718         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 719         (arm_return_in_memory, arm_store_return_value)
 720         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 721         (arm_record_ld_st_multiple): Likewise.
 722         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 723         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 724
 725 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 726
 727         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 728         AARCH64_DISPLACED_MODIFIED_INSNS.
 729         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 730         (aarch64_displaced_step_copy_insn): Likewise.
 731         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 732         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 733         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 734         ARM_DISPLACED_MODIFIED_INSNS.
 735         * arm-tdep.c (arm_gdbarch_init): Likewise.
 736         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 737         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 738         (struct arm_displaced_step_closure): Use
 739         ARM_DISPLACED_MODIFIED_INSNS.
 740
 741 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 742
 743         * features/Makefile: Remove unused xml files.
 744         * features/aarch64.xml: Remove.
 745         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 746         * features/i386/amd64-avx-avx512.xml: Remove.
 747         * features/i386/amd64-avx-linux.xml: Remove.
 748         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 749         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 750         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 751         * features/i386/amd64-avx-mpx.xml: Remove.
 752         * features/i386/amd64-avx.xml: Remove.
 753         * features/i386/amd64-linux.xml: Remove.
 754         * features/i386/amd64-mpx-linux.xml: Remove.
 755         * features/i386/amd64-mpx.xml: Remove.
 756         * features/i386/amd64.xml: Remove.
 757         * features/i386/i386-avx-avx512-linux.xml: Remove.
 758         * features/i386/i386-avx-avx512.xml: Remove.
 759         * features/i386/i386-avx-linux.xml: Remove.
 760         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 761         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 762         * features/i386/i386-avx-mpx-linux.xml: Remove.
 763         * features/i386/i386-avx-mpx.xml: Remove.
 764         * features/i386/i386-avx.xml: Remove.
 765         * features/i386/i386-linux.xml: Remove.
 766         * features/i386/i386-mmx-linux.xml: Remove.
 767         * features/i386/i386-mmx.xml: Remove.
 768         * features/i386/i386-mpx-linux.xml: Remove.
 769         * features/i386/i386-mpx.xml: Remove.
 770         * features/i386/i386.xml: Remove.
 771         * features/i386/x32-avx-avx512-linux.xml: Remove.
 772         * features/i386/x32-avx-linux.xml: Remove.
 773         * features/i386/x32-linux.xml: Remove.
 774
 775 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 776
 777         * regformats/aarch64.dat: Remove.
 778         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 779         * regformats/i386/amd64-avx-linux.dat: Remove.
 780         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 781         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 782         * regformats/i386/amd64-linux.dat: Remove.
 783         * regformats/i386/amd64-mpx-linux.dat: Remove.
 784         * regformats/i386/amd64.dat: Remove.
 785         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 786         * regformats/i386/i386-avx-linux.dat: Remove.
 787         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 788         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 789         * regformats/i386/i386-linux.dat: Remove.
 790         * regformats/i386/i386-mmx-linux.dat: Remove.
 791         * regformats/i386/i386-mpx-linux.dat: Remove.
 792         * regformats/i386/i386.dat: Remove.
 793         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 794         * regformats/i386/x32-avx-linux.dat: Remove.
 795         * regformats/i386/x32-linux.dat: Remove.
 796
 797 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 798
 799         * aarch64-tdep.c: Remove xml self tests.
 800         * amd64-linux-tdep.c: Likewise.
 801         * amd64-tdep.c: Likewise.
 802         * i386-linux-tdep.c: Likewise.
 803         * i386-tdep.c: Likewise.
 804
 805 2019-07-03  Pedro Alves  <palves@redhat.com>
 806
 807         PR cli/24732
 808         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 809         (pipe_cmd_option_defs): New.
 810         (make_pipe_cmd_options_def_group): New.
 811         (pipe_command): Use gdb::option::process_options.
 812         (pipe_command_completer): New function.
 813         (_initialize_cli_cmds): Install completer for "pipe" command.
 814
 815 2019-07-03  Pedro Alves  <palves@redhat.com>
 816
 817         * cli/cli-option.c (union option_value) <string>: New field.
 818         (struct option_def_and_value): Add ctor, move ctor, dtor and
 819         use DISABLE_COPY_AND_ASSIGN.
 820         (option_def_and_value::clear_value): New.
 821         (parse_option, save_option_value_in_ctx, get_val_type_str)
 822         (add_setshow_cmds_for_options): Handle var_string.
 823         * cli-option.h (union option_def::var_address) <string>: New
 824         field.
 825         (struct string_option_def): New.
 826         * maint-test-options.c (struct test_options_opts): Add default
 827         ctor and use DISABLE_COPY_AND_ASSIGN.
 828         <string_opt>: New field.
 829         (test_options_opts::~test_options_opts): New.
 830         (test_options_opts::dump): Also dump "-string".
 831         (test_options_option_defs): Install "string.
 832
 833 2019-07-03  Pedro Alves  <palves@redhat.com>
 834
 835         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 836         option_value with a null enumeration.
 837         (complete_options): Save the option values in the context.
 838         (save_option_value_in_ctx): New, factored out from ...
 839         (process_options): ... here.
 840         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 841         of the function.
 842         * maint-test-options.c (test_options_opts::dump): New, factored
 843         out from ...
 844         (maintenance_test_options_command_mode): ... here.
 845         (maintenance_test_options_command_completion_result): Delete.
 846         (maintenance_test_options_command_completion_text): Update
 847         comment.
 848         (maintenance_show_test_options_completion_result): Change
 849         prototype.  Just print
 850         maintenance_test_options_command_completion_text.
 851         (save_completion_result): New.
 852         (maintenance_test_options_completer_mode): Pass options context to
 853         complete_options, and then save a dump.
 854         (_initialize_maint_test_options): Use add_cmd to install "maint
 855         show test-options-completion-result".
 856
 857 2019-07-03  Pedro Alves  <palves@redhat.com>
 858
 859         * NEWS (New commands): Mention "with" and "maint with".
 860         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 861         (with_command, with_command_completer): New.
 862         (pipe_command): Adjust to new repeat_previous
 863         interface.
 864         (_initialize_cli_cmds): Install the "with" command and its "w"
 865         alias.
 866         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 867         declarations.
 868         * cli/cli-setshow.c (parse_cli_var_uinteger)
 869         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 870         argument strings for all var_types.
 871         (get_setshow_command_value_string): New, factored out from ...
 872         (do_show_command): ... this.
 873         * cli/cli-setshow.h: Include <string>.
 874         (get_setshow_command_value_string): Declare.
 875         * command.h (repeat_previous): Now returns const char *.  Adjust
 876         comment.
 877         * maint.c: Include "cli/cli-cmds.h".
 878         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 879         (_initialize_maint_cmds): Register the "maintenance with" command.
 880         * top.c (repeat_previous): Move bits from pipe_command here:
 881         Return the saved command line, if any; error out if there's no
 882         command to relaunch.
 883
 884 2019-07-03  Pedro Alves  <palves@redhat.com>
 885
 886         * NEWS (New commands): Mention "maint set/show test-settings"
 887         instead of "maint test-settings".
 888         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 889         (maintenance_test_settings_set_list): Rename to ...
 890         (maintenance_set_test_settings_list): ... this.
 891         (maintenance_test_settings_show_list): Rename to  ...
 892         (maintenance_show_test_settings_list): ... this.
 893         (maintenance_test_settings_cmd): Delete.
 894         (maintenance_test_settings_set_cmd): ...
 895         (maintenance_set_test_settings_cmd): ... this.
 896         (maintenance_test_settings_show_cmd): ...
 897         (maintenance_show_test_settings_cmd): ... this.
 898         (maintenance_test_settings_show_value_cmd):
 899         (maintenance_show_test_settings_value_cmd): ... this.
 900         (_initialize_maint_test_settings): No longer install the "maint
 901         test-settings" prefix command.  Rename "maint test-settings set"
 902         to "maint set test-settings", and "maint test-settings show" to
 903         "maint show test-settings".  Adjust all subcommands.
 904
 905 2019-07-03  Pedro Alves  <palves@redhat.com>
 906
 907         * maint-test-settings.c: Fix file's intro comment.  Replace all
 908         references to "test-options" with references to "test-settings",
 909         in comments.
 910
 911 2019-07-03  Pedro Alves  <palves@redhat.com>
 912
 913         * maint-test-settings.c (maintenance_test_settings_xxx)
 914         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 915         New.
 916         (maintenance_test_settings_enums): Use them.
 917         (maintenance_test_settings_enum): Default to
 918         maintenance_test_settings_xxx.
 919         (_initialize_maint_test_settings): Initialize
 920         MAINTENANCE_TEST_SETTINGS_FILENAME.
 921
 922 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 923
 924         * breakpoint.h (remove_breakpoints_inf): Change return type to
 925         void, move function documentation here.
 926         * breakpoint.c (remove_breakpoints_inf): Change return type to
 927         void, move function documentation to header.
 928
 929 2019-07-02  Pedro Alves  <palves@redhat.com>
 930
 931         * NEWS (Completion improvements): Mention "info threads".
 932         * thread.c (struct info_threads_opts, info_threads_option_defs)
 933         (make_info_threads_options_def_group): New.
 934         (info_threads_command): Use gdb::option::process_options.
 935         (info_threads_command_completer): New.
 936         (_initialize_thread): Use gdb::option::build_help to build the
 937         help text for "info threads".
 938
 939 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 940
 941         * defs.h (generic_load): Move from here...
 942         * symfile.h (generic_load): ... to here.  Rename name parameter
 943         to args.
 944         * symfile.c (generic_load): Add comment.
 945
 946 2019-07-01  Tom Tromey  <tromey@adacore.com>
 947
 948         * dwarf2read.c
 949         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 950         declaration of without_params.  Fix formatting.
 951
 952 2019-07-01  Tom Tromey  <tromey@adacore.com>
 953
 954         * ada-exp.y (find_primitive_type): Update.
 955         * ada-lang.h (ada_lookup_symbol): Update.
 956         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 957         parameter.
 958         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 959
 960 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 961
 962         PR breakpoints/24541
 963         * gdbarch.c: Regenerate.
 964         * gdbarch.h: Regenerate.
 965         * gdbarch.sh: Add 'stap_adjust_register'.
 966         * i386-tdep.c: Include '<unordered_set>'.
 967         (i386_stap_adjust_register): New function.
 968         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 969         * stap-probe.c (stap_parse_register_operand): Call
 970         'gdbarch_stap_adjust_register'.
 971
 972 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 973
 974         PR python/24742
 975         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 976         * python/python.c (do_start_initialization): Use 'xmalloc'
 977         instead of 'PyMem_Malloc'.
 978
 979 2019-06-28  Tom Tromey  <tromey@adacore.com>
 980
 981         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 982         for Ada.
 983
 984 2019-06-27  Tom Tromey  <tromey@adacore.com>
 985
 986         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 987         objfile_key.
 988         (arm_find_mapping_symbol, arm_record_special_symbol)
 989         (_initialize_arm_tdep): Update.
 990         (arm_objfile_data_free): Remove.
 991
 992 2019-06-27  Tom Tromey  <tromey@adacore.com>
 993
 994         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 995         to cp_print_static_field.
 996
 997 2019-06-26  Tom Tromey  <tromey@adacore.com>
 998
 999         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1000         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1001         declare.
1002
1003 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1004
1005         * features/aarch64-core.c (create_feature_aarch64_core):
1006         Regenerate.
1007         * features/aarch64-core.xml: Add cpsr flags.
1008
1009 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1010
1011         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1012         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1013
1014 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1015
1016         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1017         field.
1018         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1019         use.
1020         (arm_record_special_symbol): Don't insert new symbol in sorted
1021         position, push it at the end.
1022
1023 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1024
1025         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1026         (arm_mapping_symbol_s): Remove.
1027         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1028         (arm_mapping_symbol_vec): New typedef.
1029         (struct arm_per_objfile): Add constructor.
1030         <section_maps>: Change type to
1031         std::unique_ptr<arm_mapping_symbol_vec[]>.
1032         (arm_compare_mapping_symbols): Remove.
1033         (arm_find_mapping_symbol): Adjust to section_maps type change.
1034         (arm_objfile_data_free): Call delete on arm_per_objfile.
1035         (arm_record_special_symbol): Adjust to section_maps type change.
1036         Allocate arm_per_objfile with new.
1037
1038 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1039
1040         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1041         with the command prefix.
1042
1043 2019-06-25  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1046         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1051         type.
1052         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1053         protected.
1054
1055 2019-06-25  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-winsource.c
1058         (tui_source_window_base::set_is_exec_point_at): Add check against
1059         LOA_ADDRESS.
1060
1061 2019-06-25  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-source.c (tui_set_source_content): Don't check before
1064         xfree.
1065         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1066
1067 2019-06-25  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-winsource.h (tui_update_source_window_as_is)
1070         (tui_alloc_source_buffer, tui_line_is_displayed)
1071         (tui_addr_is_displayed): Change type of win_info.
1072         * tui/tui-winsource.c (tui_update_source_window_as_is)
1073         (tui_clear_source_content, tui_show_source_line)
1074         (tui_show_source_content, tui_source_window_base::refill)
1075         (tui_source_window_base::set_is_exec_point_at)
1076         (tui_source_window_base::set_is_exec_point_at)
1077         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1078         (tui_alloc_source_buffer, tui_line_is_displayed)
1079         (tui_addr_is_displayed): Change type of win_info.  Update.
1080         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1081         (tui_source_window_base::do_make_visible_with_new_height):
1082         Update.
1083         * tui/tui-source.c (tui_set_source_content)
1084         (tui_set_source_content_nil)
1085         (tui_source_window::do_scroll_vertical): Update.
1086         * tui/tui-layout.c (show_layout): Update.
1087         * tui/tui-disasm.c (tui_set_disassem_content)
1088         (tui_disasm_window::do_scroll_vertical): Update.
1089         * tui/tui-data.h (tui_win_content): Remove.
1090         (struct tui_gen_win_info) <content, content_size>: Remove.
1091         (struct tui_source_element): Add initializers and destructor.
1092         (union tui_which_element, struct tui_win_element): Remove.
1093         (struct tui_source_window_base) <content>: New field.
1094         (struct tui_data_window): Remove destructor.
1095         (tui_alloc_content, tui_free_win_content)
1096         (tui_free_all_source_wins_content): Don't declare.
1097         * tui/tui-data.c (tui_initialize_static_data): Update.
1098         (init_content_element, tui_alloc_content): Remove.
1099         (~tui_gen_win_info): Update.
1100         (~tui_data_window, tui_free_all_source_wins_content)
1101         (tui_free_win_content, free_content, free_content_elements):
1102         Remove.
1103
1104 2019-06-25  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-winsource.h (tui_clear_source_content)
1107         (tui_erase_source_content, tui_show_source_content): Change type
1108         of win_info.
1109         * tui/tui-winsource.c (tui_clear_source_content)
1110         (tui_erase_source_content, tui_show_source_content): Change type
1111         of win_info.
1112         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1113         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1114         win_info.
1115         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1116         win_info.
1117         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1118
1119 2019-06-25  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-winsource.c (tui_clear_source_content)
1122         (tui_source_window_base::set_is_exec_point_at): Update.
1123         * tui/tui-source.c (tui_set_source_content_nil): Update.
1124         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1125         a bool.
1126         * tui/tui-data.c (init_content_element): Update.
1127
1128 2019-06-25  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1131         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1132         * tui/tui-layout.c (init_and_make_win): Update.
1133         * tui/tui.h (enum tui_win_type): Update.
1134         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1135         tui_win_is_auxillary.
1136         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1137         tui_win_is_auxillary.
1138
1139 2019-06-25  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1142         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1143         (tui_delete_data_content_windows, tui_display_all_data)
1144         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1145         Update.
1146         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1147         * tui/tui-regs.c (tui_last_regs_line_no)
1148         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1149         (tui_show_registers): Update.
1150         (tui_show_register_group): Return void.  Update.
1151         (tui_display_registers_from, tui_display_reg_element_at_line)
1152         (tui_display_registers_from_line, tui_check_register_values):
1153         Update.
1154         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1155         member.
1156         (struct tui_data_window) <regs_content>: Now a std::vector.
1157         <regs_content_count>: Remove.
1158         (tui_add_content_elements, tui_free_data_content): Don't declare.
1159         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1160         (init_content_element): Remove DATA_WIN case.  Add assert.
1161         (tui_add_content_elements): Remove.
1162         (tui_data_window): Update.
1163         (tui_free_data_content): Remove.
1164         (free_content_elements): Remove DATA_WIN case.
1165
1166 2019-06-25  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-data.c (tui_data_item_window): Update.
1169         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1170         * tui/tui-windata.c (tui_display_all_data)
1171         (tui_display_data_from_line): Update.
1172         (tui_check_data_values): Remove.
1173         * tui/tui-regs.c (tui_show_register_group)
1174         (tui_display_reg_element_at_line): Update.
1175         * tui/tui-hooks.c (tui_register_changed)
1176         (tui_refresh_frame_and_register_information): Call
1177         tui_check_register_values.
1178         * tui/tui-data.h (struct tui_data_window) <data_content,
1179         data_content_count, data_type>: Remove.
1180         (enum tui_data_type): Remove.
1181
1182         * tui/tui-data.c (tui_data_window::clear_detail)
1183         (~tui_data_window): Update.
1184
1185 2019-06-25  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1188         declare.
1189         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1190         Rename from tui_first_data_item_displayed.  Update.
1191         (tui_data_window::refresh_all)
1192         (tui_data_window::do_scroll_vertical): Update.
1193         * tui/tui-data.h (struct tui_data_window)
1194         <first_data_item_displayed>: Declare new method.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1199         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1200         contents...
1201         (tui_initialize_static_data): ...here.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1206         (tui_display_registers_from, tui_check_register_values): Update.
1207         (tui_display_register): Remove win_info parameter; update.
1208         (tui_get_register): Change type of parameters.
1209         * tui/tui-data.h (struct tui_data_element): Remove.
1210         (union tui_which_element) <data>: Remove.
1211         <data_window>: Change type.
1212         (struct tui_data_item_window): New.
1213         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1214         case.  Add assert.
1215         (~tui_data_item_window): New destructor.
1216         (free_content_elements): Remove DATA_ITEM_WIN case.
1217
1218 2019-06-25  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1221         Remove.
1222
1223 2019-06-25  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-data.h (struct tui_command_element): Remove.
1226         (union tui_which_element) <command>: Remove.
1227         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1228         assert.
1229         (free_content_elements): Remove CMD_WIN case.
1230
1231 2019-06-25  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-layout.c (tui_set_layout): Update.
1234         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1235         * tui/tui-data.c (layout_def): Update.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1240         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1241         (tui_source_window_base::set_new_height): Update.
1242         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1243         Update.
1244         (tui_set_locator_fullname, tui_set_locator_info)
1245         (tui_show_frame_info): Update.
1246         * tui/tui-source.c (tui_set_source_content)
1247         (tui_source_is_displayed): Update.
1248         * tui/tui-layout.c (show_source_disasm_command, show_data)
1249         (show_source_or_disasm_and_command): Update.
1250         * tui/tui-disasm.c (tui_set_disassem_content)
1251         (tui_get_begin_asm_address): Update.
1252         * tui/tui-data.h (struct tui_locator_element): Remove.
1253         (union tui_which_element) <locator>: Remove.
1254         (struct tui_locator_window): New.
1255         (tui_locator_win_info_ptr): Change return type.
1256         * tui/tui-data.c (_locator): Change type.
1257         (tui_locator_win_info_ptr): Change return type.
1258         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1259         (tui_alloc_content): Add assert.
1260
1261 2019-06-25  Tom Tromey  <tom@tromey.com>
1262
1263         * tui/tui-winsource.c
1264         (tui_exec_info_window::maybe_allocate_content): New method.
1265         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1266         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1267         (make_source_or_disasm_window): Add cast.
1268         * tui/tui-data.h (union tui_which_element) <simple_string>:
1269         Remove.
1270         (struct tui_source_info): New.
1271         (struct tui_source_window_base) <execution_info>: Change type.
1272         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1273         case, and add assert.
1274         (tui_alloc_content): Add assert.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1279         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1280         * tui/tui-data.c (tui_alloc_win_info): Remove.
1281
1282 2019-06-25  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1285         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1286         can_highlight.
1287
1288 2019-06-25  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1291         make_visible_with_new_height method.
1292         (tui_win_info::make_visible_with_new_height): New method.
1293         (tui_source_window_base::do_make_visible_with_new_height)
1294         (tui_data_window::do_make_visible_with_new_height)
1295         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1296         (make_visible_with_new_height): Remove.
1297         (tui_resize_all, tui_adjust_win_heights): Use
1298         make_visible_with_new_height method.
1299         * tui/tui-data.h (struct tui_win_info)
1300         <do_make_visible_with_new_height, make_visible_with_new_height>:
1301         New methods.
1302         (struct tui_source_window_base, struct tui_data_window)
1303         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1304         methods.
1305
1306 2019-06-25  Tom Tromey  <tom@tromey.com>
1307
1308         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1309         method.
1310         (update_tab_width): Call update_tab_width method.
1311         * tui/tui-data.h (struct tui_win_info)
1312         (struct tui_source_window_base) <update_tab_width>: New methods.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1317         parameter.
1318         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1319         parameter.
1320         (tui_gen_win_info::make_visible): Update.
1321         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1322         parameter.
1323         * tui/tui-data.h (enum tui_box): New enum.
1324         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1329         init_and_make_win for EXEC_INFO_WIN.
1330         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1331         longer inline.
1332         (struct tui_win_info) <~tui_win_info>: Inline.
1333         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1334         Don't declare.
1335         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1336         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1337         Remove.
1338         (tui_initialize_static_data): Update.
1339         (~tui_gen_win_info): Handle more cleanup here.
1340         (~tui_source_window_base): Delete "execution_info".
1341         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-layout.c (make_command_window): Don't set
1346         can_highlight.
1347         (show_source_disasm_command): Call the reset method.
1348         (show_data): Don't set can_highlight.  Call the reset method.
1349         (tui_gen_win_info::reset): Rename from init_gen_win_info
1350         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1351         (show_source_or_disasm_and_command): Call the reset method.
1352         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1353         (struct tui_cmd_window): Set can_highlight.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1358         from make_visible.
1359         (tui_make_visible, tui_make_invisible): Rewrite.
1360         (tui_win_info::make_visible): Remove.
1361         (tui_source_window_base::make_visible): Update.
1362         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1363         method.  Moved from...
1364         (struct tui_win_info) <make_visible>: ...here.
1365
1366 2019-06-25  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-winsource.c
1369         (tui_source_window_base::do_scroll_horizontal): Remove direction
1370         parameter.
1371         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1372         direction parameter.
1373         * tui/tui-win.c (tui_win_info::forward_scroll)
1374         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1375         (tui_win_info::right_scroll): Update.
1376         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1377         direction parameter.
1378         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1379         direction parameter.
1380         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1381         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1382         Remove direction parameter.
1383         (struct tui_source_window_base, struct tui_source_window)
1384         (struct tui_disasm_window, struct tui_data_window)
1385         (struct tui_cmd_window): Update.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-winsource.h (tui_set_exec_info_content)
1390         (tui_show_exec_info_content, tui_erase_exec_info_content)
1391         (tui_clear_exec_info_content, tui_update_exec_info): Change
1392         argument to tui_source_window_base.
1393         * tui/tui-winsource.c (tui_set_exec_info_content)
1394         (tui_show_exec_info_content, tui_erase_exec_info_content)
1395         (tui_clear_exec_info_content, tui_update_exec_info): Change
1396         argument to tui_source_window_base.
1397
1398 2019-06-25  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1401         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1406         check.
1407
1408 2019-06-25  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1411         type to void.
1412         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1413         type to void.
1414         * tui/tui-source.c (tui_set_source_content): Update.
1415         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1416
1417 2019-06-25  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-win.c (window_name_completer, tui_set_focus)
1420         (tui_all_windows_info): Use name method.
1421         * tui/tui-data.h (struct tui_gen_win_info)
1422         (struct tui_source_window, struct tui_disasm_window)
1423         (struct tui_data_window, struct tui_cmd_window) <name>: New
1424         method.
1425         (tui_win_name): Don't declare.
1426         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1427         (tui_win_name): Remove.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-winsource.h (tui_update_source_window)
1432         (tui_update_source_window_as_is): Change parameter type.
1433         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1434         to be a tui_source_window_base.
1435         (tui_update_source_window_as_is): Likewise.
1436         * tui/tui-win.c (make_visible_with_new_height): Update.
1437
1438 2019-06-25  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-winsource.c (tui_erase_source_content)
1441         (tui_show_source_content, tui_show_exec_info_content)
1442         (tui_erase_exec_info_content): Use refresh_window method.
1443         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1444         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1445         from tui_refresh_win.
1446         (tui_data_window::refresh_window): New method.
1447         (tui_win_info::refresh, tui_source_window_base::refresh)
1448         (tui_refresh_all): Use refresh_window method.
1449         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1450         method.
1451         * tui/tui-regs.c (tui_display_register): Call refresh_window
1452         method.
1453         * tui/tui-layout.c (show_source_disasm_command)
1454         (show_source_or_disasm_and_command): Call refresh_window method.
1455         * tui/tui-data.h (struct tui_gen_win_info)
1456         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1457         New method.
1458
1459 2019-06-25  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui.c (tui_rl_other_window, tui_enable)
1462         (tui_is_window_visible, tui_get_command_dimension): Update.
1463         * tui/tui-winsource.c (tui_update_source_window_as_is)
1464         (tui_clear_source_content, tui_erase_source_content)
1465         (tui_show_source_line, tui_source_window_base::refill)
1466         (tui_source_window_base::do_scroll_horizontal)
1467         (tui_source_window_base::set_is_exec_point_at)
1468         (tui_update_breakpoint_info, tui_set_exec_info_content)
1469         (tui_alloc_source_buffer, tui_line_is_displayed)
1470         (tui_addr_is_displayed): Update.
1471         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1472         (tui_check_and_display_highlight_if_needed)
1473         (tui_win_info::make_visible, tui_win_info::refresh)
1474         (tui_refresh_all): Update.
1475         * tui/tui-windata.c (tui_first_data_item_displayed)
1476         (tui_delete_data_content_windows, tui_erase_data_content)
1477         (tui_display_all_data, tui_data_window::refresh_all)
1478         (tui_check_data_values): Update.
1479         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1480         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1481         (tui_win_info::backward_scroll, tui_refresh_all_win)
1482         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1483         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1484         (tui_source_window_base::set_new_height)
1485         (tui_data_window::set_new_height)
1486         (make_invisible_and_set_new_height)
1487         (make_visible_with_new_height, new_height_ok)
1488         (parse_scrolling_args): Update.
1489         * tui/tui-stack.c (tui_show_frame_info): Update.
1490         * tui/tui-source.c (tui_set_source_content)
1491         (tui_set_source_content_nil, tui_source_is_displayed)
1492         (tui_source_window::do_scroll_vertical): Update.
1493         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1494         (tui_display_registers_from, tui_display_reg_element_at_line)
1495         (tui_check_register_values, tui_reg_command): Update.
1496         * tui/tui-layout.c (tui_default_win_height)
1497         (show_source_disasm_command, show_data, init_and_make_win)
1498         (show_source_or_disasm_and_command): Update.
1499         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1500         (tui_redisplay_readline, tui_mld_flush)
1501         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1502         (tui_getc): Update.
1503         * tui/tui-disasm.c (tui_set_disassem_content)
1504         (tui_disasm_window::do_scroll_vertical): Update.
1505         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1506         Now virtual.
1507         (struct tui_win_info): Derive from tui_gen_win_info.
1508         <~tui_win_info>: Mark as override.
1509         <generic>: Remove member.
1510         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1511         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1512         (~tui_data_window, ~tui_win_info)
1513         (tui_free_all_source_wins_content): Update.
1514         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-layout.c (init_and_make_win): Use new.
1519         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1520         destructor, initializers.
1521         (tui_alloc_generic_win_info): Don't declare.
1522         * tui/tui-data.c (_locator): Add argument to constructor.
1523         (source_win, disasm_win): New globals.
1524         (exec_info): Remove.
1525         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1526         Update.
1527         (tui_alloc_generic_win_info): Remove.
1528         (init_content_element): Use new.
1529         (tui_win_info::tui_win_info): Update.
1530         (free_content_elements) <case DATA_WIN>: Use delete.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1535         * tui/tui-windata.c (tui_first_data_item_displayed)
1536         (tui_delete_data_content_windows): Update.
1537         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1538         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1539         (tui_display_registers_from, tui_check_register_values): Update.
1540         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1541         pointer.
1542         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1543         window.
1544         (tui_free_data_content): Update.
1545         (free_content_elements) <case DATA_WIN>: Free the window.
1546
1547 2019-06-25  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1550         Update.
1551         * tui/tui-layout.c (make_command_window)
1552         (show_source_disasm_command, show_data, init_and_make_win)
1553         (show_source_or_disasm_and_command): Update.
1554         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1555         method.
1556         <can_highight, is_highlighted>: Now bool.
1557         (tui_set_win_highlight): Don't declare.
1558         * tui/tui-data.c (tui_set_win_highlight): Remove.
1559
1560 2019-06-25  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-wingeneral.c (make_visible): Remove check of window
1563         type.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-win.c (tui_win_info::max_height)
1568         (tui_cmd_window::max_height): New methods.
1569         (new_height_ok): Call max_height.
1570         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1571         <max_height>: New method.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-win.c (tui_source_window_base::set_new_height)
1576         (tui_data_window::set_new_height): New methods.
1577         (make_invisible_and_set_new_height): Call set_new_height method.
1578         * tui/tui-data.h (struct tui_win_info)
1579         (struct tui_source_window_base, struct tui_data_window)
1580         <set_new_height>: New method.
1581
1582 2019-06-25  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1585         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1586         tui_refresh_data_win.
1587         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1588         method.
1589         (tui_refresh_all_win): Call the refresh_all method.
1590         (tui_set_focus): Likewise.
1591         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1592         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1593         Likewise.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-winsource.h (tui_refill_source_window)
1598         (tui_set_is_exec_point_at): Don't declare.
1599         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1600         (tui_source_window_base::refill): Rename from
1601         tui_refill_source_window.
1602         (tui_source_window_base::do_scroll_horizontal): Update.
1603         (tui_source_window_base::set_is_exec_point_at): Rename from
1604         tui_set_is_exec_point_at.
1605         (tui_update_all_breakpoint_info): Update.
1606         * tui/tui-stack.c (tui_show_frame_info): Update.
1607         * tui/tui-layout.c (show_data): Add cast.
1608         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1609         * tui/tui-data.h (struct tui_source_window_base) <refill,
1610         set_is_exec_point_at>: New methods.
1611         (tui_source_windows, tui_add_to_source_windows): Update types.
1612         (tui_add_to_source_windows): Remove redundant declaration.
1613         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1614         (tui_source_windows): Change return type.
1615         (tui_clear_source_windows_detail): Update.
1616         (tui_add_to_source_windows): Change type of parameter.
1617         (tui_free_all_source_wins_content): Update.
1618
1619 2019-06-25  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-wingeneral.c (tui_win_info::refresh)
1622         (tui_source_window_base::refresh): New methods.
1623         (tui_refresh_all): Call the refresh method.
1624         * tui/tui-data.h (struct tui_win_info)
1625         (struct tui_source_window_base) <refresh>: New method.
1626
1627 2019-06-25  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui.h (tui_is_window_visible): Return bool.
1630         * tui/tui.c (tui_is_window_visible): Return bool.
1631         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1632         (tui_make_visible, tui_make_invisible)
1633         (tui_win_info::make_visible)
1634         (tui_source_window_base::make_visible, make_all_visible)
1635         (tui_make_all_visible, tui_make_all_invisible): Update.
1636         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1637         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1638         bool.
1639         (struct tui_win_info, struct tui_source_window_base)
1640         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1641         * tui/tui-data.c (tui_init_generic_part): Update.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1646         (tui_source_window_base::make_visible): New methods.
1647         (make_all_visible): Make method call.
1648         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1649         (struct tui_source_window_base, struct tui_cmd_window): Override
1650         make_visible.
1651         (tui_win_is_source_type): Don't declare.
1652         * tui/tui-data.c (tui_win_is_source_type): Remove.
1653
1654 2019-06-25  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1657         NULL check.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1662         Inline constructor.  Add initializers for members.
1663         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1664         constructors; now inline in class.
1665
1666 2019-06-25  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-regs.c (tui_show_registers): Update.
1669         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1670         bool.
1671         * tui/tui-data.c (tui_data_window::clear_detail)
1672         (tui_data_window): Update.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-windata.c (tui_display_all_data)
1677         (tui_display_data_from_line, tui_display_data_from)
1678         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1679         Update.
1680         * tui/tui-regs.c (tui_last_regs_line_no)
1681         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1682         (tui_show_registers, tui_show_register_group)
1683         (tui_display_registers_from, tui_display_reg_element_at_line)
1684         (tui_display_registers_from_line, tui_check_register_values)
1685         (tui_reg_next, tui_reg_prev): Update.
1686         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1687         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1688         tui_data_window.
1689         (struct tui_win_info) <detail>: Remove.  Add new fields from
1690         tui_data_info.
1691         (TUI_DATA_WIN): Add cast.
1692         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1693         (~tui_data_window): Simplify.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-layout.c (show_source_disasm_command)
1698         (show_source_or_disasm_and_command): Update.
1699         * tui/tui-io.c (update_cmdwin_start_line)
1700         (tui_redisplay_readline): Update.
1701         * tui/tui-data.h (struct tui_command_info): Remove.
1702         (struct tui_win_info) <detail>: Remove command_info member.
1703         (struct tui_data_window) <start_line>: New member, from
1704         tui_command_info.
1705         (TUI_CMD_WIN): Add casts.
1706
1707 2019-06-25  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-winsource.c (tui_update_source_window)
1710         (tui_refill_source_window)
1711         (tui_source_window_base::do_scroll_horizontal)
1712         (tui_update_breakpoint_info, tui_set_exec_info_content)
1713         (tui_show_exec_info_content, tui_erase_exec_info_content)
1714         (tui_clear_exec_info_content): Update.
1715         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1716         Update.
1717         * tui/tui-win.c (make_invisible_and_set_new_height)
1718         (make_visible_with_new_height): Update.
1719         * tui/tui-source.c (tui_set_source_content)
1720         (tui_show_symtab_source): Update.
1721         * tui/tui-layout.c (extract_display_start_addr)
1722         (show_source_disasm_command, show_data)
1723         (make_source_or_disasm_window)
1724         (show_source_or_disasm_and_command): Update.
1725         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1726         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1727         "gdbarch".
1728         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1729         to tui_source_window_base.
1730         (struct tui_win_info) <detail>: Remove source_info member.
1731         (struct tui_source_window_base) <has_locator>: Inline.
1732         Move contents from tui_source_info; rename has_locator member to
1733         m_has_locator.
1734         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1735         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1736         header file.
1737         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1738         Simplify.
1739         (tui_free_all_source_wins_content): Cast to
1740         tui_source_window_base.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-win.c (make_invisible_and_set_new_height)
1745         (make_visible_with_new_height): Call has_locator method.
1746         * tui/tui-layout.c (show_source_disasm_command, show_data)
1747         (show_source_or_disasm_and_command): Update for bool change.
1748         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1749         (tui_win_info) <has_locator>: New method.
1750         (struct tui_source_window_base) <has_locator>: New method.
1751         (tui_win_has_locator): Don't declare.
1752         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1753         from tui_win_has_locator.
1754         (tui_source_window_base): Use false, not FALSE.
1755
1756 2019-06-25  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1759         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1760         clear_detail method directly.
1761         (tui_clear_win_detail): Remove.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1766         "this", not TUI_DISASM_WIN.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1771         declare.
1772         * tui/tui-winsource.c
1773         (tui_source_window_base::do_scroll_horizontal): Rename from
1774         tui_horizontal_source_scroll.
1775         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1776         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1777         from tui_vertical_data_scroll.
1778         * tui/tui-win.h (tui_scroll): Don't declare.
1779         * tui/tui-win.c (tui_win_info::forward_scroll)
1780         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1781         (tui_win_info::right_scroll): Rename and update.
1782         (tui_scroll_forward_command, tui_scroll_backward_command)
1783         (tui_scroll_left_command, tui_scroll_right_command): Update.
1784         (tui_scroll): Remove.
1785         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1786         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1787         from tui_vertical_source_scroll.
1788         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1789         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1790         from tui_vertical_disassem_scroll.
1791         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1792         do_scroll_horizontal>: New methods.
1793         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1794         Likewise.
1795         (struct tui_source_window_base): Add do_scroll_horizontal.
1796         (struct tui_source_window, struct tui_disasm_window): Add
1797         do_scroll_vertical.
1798         (struct tui_data_window, struct tui_cmd_window): Add
1799         do_scroll_horizontal and do_scroll_vertical.
1800         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1801
1802 2019-06-25  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-data.h (struct tui_source_window_base): New struct.
1805         (struct tui_source_window): Derive from tui_source_window_base.
1806         (struct tui_disasm_window): New struct.
1807         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1808         from tui_source_window::clear_detail.
1809         (tui_source_window_base): Rename from tui_source_window.
1810         (~tui_source_window_base): Rename from ~tui_source_window.
1811         (tui_alloc_win_info): Create a tui_disasm_window.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-data.h (struct tui_source_window)
1816         (struct tui_data_window): Declare destructors.
1817         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1818         destructors.
1819         (tui_win_info): Simplify.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-winsource.c (tui_display_main)
1824         (tui_update_source_windows_with_addr)
1825         (tui_update_all_breakpoint_info): Update.
1826         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1827         (new_height_ok, parse_scrolling_args): Update.
1828         * tui/tui-stack.c (tui_show_frame_info): Update.
1829         * tui/tui-data.h (struct tui_list): Remove.
1830         (tui_source_windows): Return a reference to a std::vector.
1831         * tui/tui-data.c (source_windows): Now a std::vector.
1832         (tui_source_windows): Change return type.
1833         (tui_clear_source_windows): Rewrite.
1834         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1835         (tui_free_all_source_wins_content): Rewrite.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1840         (struct tui_data_window, struct tui_cmd_window): Declare
1841         clear_detail method.
1842         * tui/tui-data.c (tui_source_window::clear_detail)
1843         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1844         methods.
1845         (tui_clear_win_detail): Simplify.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-layout.c (make_source_window, make_disasm_window)
1850         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1851         Return the new window.
1852         (show_source_disasm_command, show_data)
1853         (show_source_or_disasm_and_command): Update.
1854
1855 2019-06-25  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1858         parameter.  Return the new window.
1859         (show_source_disasm_command): Update and remove NULL check.
1860         (show_source_or_disasm_and_command): Update.
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-data.h (struct tui_win_info): Make constructor
1869         protected.  Make destructor virtual.  Add initializers.
1870         (tui_source_window, tui_data_window, tui_cmd_window): New
1871         classes.
1872         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1873         constructor.  Add "type" parameter.
1874         (tui_source_window, tui_data_window, tui_cmd_window): New
1875         constructors.
1876         (tui_alloc_win_info): Instantiate the appropriate subclass.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-win.c (tui_resize_all): Use delete.
1881         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1882         destructor.
1883         (tui_free_window): Don't declare.
1884         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1885         Update.
1886
1887 2019-06-25  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-data.h (struct tui_win_info): Add constructor.
1890         * tui/tui-data.c (tui_alloc_win_info): Use new.
1891         (tui_free_window): Use delete.
1892
1893 2019-06-22  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1896         declare.
1897         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1898
1899 2019-06-22  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1902         declare.
1903         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1904
1905 2019-06-22  Tom de Vries  <tdevries@suse.de>
1906
1907         * dwarf2read.c (create_addrmap_from_aranges)
1908         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1909         instead of '%zu'.
1910
1911 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1912
1913         * dwarf2read.h (dwarf2_section_info_def): Remove.
1914         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1915         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1916         std::vector<dwarf2_section_info>.
1917         (struct dwo_file) <~dwo_file>: Remove.
1918         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1919         types field.
1920         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1921         (dwarf2_read_debug_names): Likewise.
1922         (create_debug_types_hash_table): Change parameter type to
1923         array_view, adjust code accordingly.
1924         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1925         (partial_die_info::fixup): Likewise.
1926         (determine_prefix): Likewise.
1927         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1928
1929 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1930
1931         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1932         gdb_bfd_ref_ptr.
1933         <~dwo_file>: Remove call to gdb_bfd_unref.
1934         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1935         gdb_bfd_ref_ptr::get.
1936
1937 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1938
1939         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1940         type to htab_up.
1941         * dwarf2read.c (struct dwo_file): Initialize fields.
1942         <~dwo_file>: New.
1943         (free_dwo_file): Remove, move content to ~dwo_file.
1944         (struct dwo_file_deleter): Remove.
1945         (dwo_file_up>: Remove custom deleter.
1946         (free_dwo_files): Remove.
1947         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1948         dwo_files.
1949         (process_skeletonless_type_units): Call unique_ptr::get.
1950         (allocate_dwo_file_hash_table): Add deleter to created hash
1951         table.  Change return type to htab_up.
1952         (lookup_dwo_file_slot): Don't memset dwo_file, call
1953         unique_ptr::get.
1954         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1955         (create_dwo_unit_in_dwp_v2): Likewise.
1956         (open_and_init_dwo_file): Likewise.
1957         (free_dwo_file_from_slot): Remove.
1958
1959 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1960
1961         * dwarf2read.h (struct dwarf2_section_info) <readin,
1962         is_virtual>: Change type to bool.
1963         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1964         true instead of 1.
1965
1966 2019-06-19  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-data.h (tui_init_content_element): Don't declare.
1969
1970 2019-06-19  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-data.h (tui_init_win_info): Don't declare.
1973
1974 2019-06-19  Tom de Vries  <tdevries@suse.de>
1975
1976         * dwarf2read.h (abstract_to_concrete): Change type to
1977         std::unordered_map<sect_offset, std::vector<sect_offset>,
1978         gdb::hash_enum<sect_offset>>.
1979
1980 2019-06-19  Tom Tromey  <tromey@adacore.com>
1981
1982         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1983         EVAL_AVOID_SIDE_EFFECTS specially.
1984
1985 2019-06-19  Tom Tromey  <tromey@adacore.com>
1986
1987         * source-cache.c (highlighter): New global.
1988         (source_cache::get_source_lines): Create a highlighter on demand.
1989
1990 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1991
1992         * defs.h (deprecated_interactive_hook): Delete declaration.
1993         * interps.c (clear_interpreter_hooks): Remove use of
1994         deprecated_interactive_hook.
1995         * top.c (deprecated_interactive_hook): Delete definition.
1996         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1997
1998 2019-06-18  Tom de Vries  <tdevries@suse.de>
1999
2000         PR gdb/24515
2001         * dwarf2read.h (abstract_to_concrete): Change type from
2002         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2003         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2004         * dwarf2read.c (read_variable): Update.
2005         (dwarf2_fetch_die_loc_sect_off): Update.
2006
2007 2019-06-17  Tom de Vries  <tdevries@suse.de>
2008
2009         PR gdb/24617
2010         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2011         accessing parent[parent_len - 1].
2012
2013 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2014
2015         PR gdb/24364
2016         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2017         call dtrace_process_dof with NULL dof.
2018
2019 2019-06-16  Tom de Vries  <tdevries@suse.de>
2020
2021         PR gdb/24445
2022         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2023
2024 2019-06-16  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2027         (make_all_visible): Use address of member.
2028
2029 2019-06-16  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2032         (tui_free_window, free_content, free_content_elements): Remove
2033         unnecessary cast.
2034         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2035         cast.
2036         * tui/tui-regs.c (tui_show_register_group)
2037         (tui_display_registers_from, tui_display_reg_element_at_line):
2038         Remove unnecessary cast.
2039
2040 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2041
2042         * linux-nat.c (normal_mask): Delete.
2043         (_initialize_linux_nat): Don't initialise normal_mask.
2044
2045 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2046
2047         PR gdb/24445
2048         * dwarf-index-write.h (write_psymtabs_to_index): Add
2049         dwz_basename parameter.
2050         * dwarf-index-write.c (write_gdbindex): Move file writing to
2051         write_gdbindex_1.  Change return type void.
2052         (assert_file_size): Move up, remove filename parameter.
2053         (write_gdbindex_1): New function.
2054         (write_debug_names): Change return type to void, call
2055         assert_file_size.
2056         (struct index_wip_file): New struct.
2057         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2058         file logic to index_wip_file.  Write index for dwz file if
2059         needed.
2060         (save_gdb_index_command): Pass basename of dwz file, if present.
2061         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2062         build-id of dwz file, if present.
2063         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2064         (dwarf2_get_dwz_file): Likewise.
2065         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2066         (dwarf2_get_dwz_file): Likewise.
2067
2068 2019-06-16  Tom Tromey  <tom@tromey.com>
2069
2070         * coffread.c (process_coff_symbol): Use xstrdup.
2071         * value.c (create_internalvar): Use xstrdup.
2072
2073 2019-06-16  Tom Tromey  <tom@tromey.com>
2074
2075         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2076         * breakpoint.c (stopin_command, stopat_command)
2077         (until_break_command, decode_location_default): Remove unnecessary
2078         cast.
2079         * utils.c (subset_compare): Remove unnecessary cast.
2080         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2081         cast.
2082         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2083         cast.
2084         * infcmd.c (path_command): Remove unnecessary cast.
2085         * coffread.c (decode_type): Remove unnecessary cast.
2086         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2087         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2088         * tui/tui-stack.c (tui_show_locator_content)
2089         (tui_show_frame_info): Remove unnecessary cast.
2090         * tui/tui-win.c (tui_scroll_forward_command)
2091         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2092         (parse_scrolling_args): Remove unnecessary cast.
2093         * tui/tui-data.c (init_win_info, tui_del_window)
2094         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2095         (free_content_elements): Remove unnecessary cast.
2096         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2097         unnecessary cast.
2098         * tui/tui-source.c (tui_set_source_content)
2099         (tui_vertical_source_scroll): Remove unnecessary cast.
2100         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2101         cast.
2102         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2103         * tui/tui-regs.c (tui_display_registers_from)
2104         (tui_display_register): Remove unnecessary cast.
2105         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2106         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2107         (make_visible): Remove unnecessary cast.
2108         * tui/tui-winsource.c (tui_erase_source_content)
2109         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2110         unnecessary cast.
2111         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2112         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2113         * stabsread.c (read_type, read_array_type, read_range_type):
2114         Remove unnecessary cast.
2115         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2116         (parse_symbol, parse_type, upgrade_type, parse_external)
2117         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2118         unnecessary cast.
2119         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2120
2121 2019-06-16  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-data.c (tui_alloc_generic_win_info)
2124         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2125         checks.
2126
2127 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2128             Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * f-typeprint.c (f_print_type): Don't return early for not
2131         associated or not allocated types.
2132         (f_type_print_varspec_suffix): Add print_rank parameter and print
2133         ranks of array types in case they dangling.
2134         (f_type_print_base): Add print_rank parameter.
2135
2136 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2137
2138         * NEWS: Mention new MI commands.
2139         * break-catch-throw.c (enum exception_event_kind): Move to
2140         breakpoint.h.
2141         (print_mention_exception_catchpoint): Output text as a single
2142         message.
2143         (catch_exception_command_1): Rename to...
2144         (catch_exception_event): ...this, make non-static, update header
2145         command, and change some parameter types.
2146         (catch_catch_command): Update for changes to
2147         catch_exception_command_1.
2148         (catch_throw_command): Likewise.
2149         (catch_rethrow_command): Likewise.
2150         * breakpoint.c (enum exception_event_kind): Delete.
2151         * breakpoint.h (enum exception_event_kind): Moved here from
2152         break-catch-throw.c.
2153         (catch_exception_event): Declare.
2154         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2155         (mi_cmd_catch_throw): New function.
2156         (mi_cmd_catch_rethrow): New function.
2157         (mi_cmd_catch_catch): New function.
2158         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2159         'catch-catch' entries.
2160         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2161         (mi_cmd_catch_rethrow): Declare.
2162         (mi_cmd_catch_catch): Declare.
2163
2164 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * annotate.c (annotate_source_line): Change return type to void,
2167         update implementation to match.
2168         * annotate.h (annotate_source_line): Change return type to void,
2169         update header comment.
2170         * stack.c (print_frame_info): Don't change what frame information
2171         is printed based on whether annotations are on or not.
2172
2173 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2176         (annotate_source): Make static.
2177         (annotate_source_line): Moved from source.c and renamed from
2178         identify_source_line.  Update the return type.
2179         * annotate.h (annotate_source): Delete declaration.
2180         (annotate_source_line): Declaration moved from source.h, and
2181         renamed from identify_source_line.  Return type updated.
2182         * source.c (identify_source_line): Moved to annotate.c and renamed
2183         to annotate_source_line.
2184         (info_line_command): Remove check of annotation_level.
2185         * source.h (identify_source_line): Move declaration to annotate.h
2186         and rename to annotate_source_line.
2187         * stack.c: Add 'annotate.h' include.
2188         (print_frame_info): Remove check of annotation_level before
2189         calling annotate_source_line.
2190
2191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * source-cache.c (source_cache::get_plain_source_lines): Use
2194         open_source_file_with_line_charpos instead of just
2195         open_source_file, remove call to find_source_lines.
2196         (source_cache::get_source_lines): Likewise.
2197         * source.c (find_source_lines): Make static.
2198         (get_filename_and_charpos): Renamed into...
2199         (open_source_file_with_line_charpos): ..this along with changes to
2200         return a scoped_fd, and some other minor clean ups.
2201         (identify_source_line): Use open_source_file_with_line_charpos.
2202         (search_command_helper): Use open_source_file_with_line_charpos
2203         instead of just open_source_file, remove call to
2204         find_source_lines.
2205         * source.h (open_source_file_with_line_charpos): Declare new
2206         function.
2207         (find_source_lines): Delete declaration.
2208
2209 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * source.c (get_filename_and_charpos): Remove fullname
2212         parameter.
2213         (identify_source_line): Update call to get_filename_and_charpos.
2214
2215 2019-06-14  Tom Tromey  <tromey@adacore.com>
2216
2217         PR gdb/24502:
2218         * ui-style.h (skip_ansi_escape): Update comment.
2219         * ui-file.h (class no_terminal_escape_file): New class.
2220         * ui-file.c (no_terminal_escape_file::write)
2221         (no_terminal_escape_file::puts): New methods.
2222         * cli/cli-logging.c (handle_redirections): Use
2223         no_terminal_escape_file.
2224
2225 2019-06-14  Tom Tromey  <tromey@adacore.com>
2226
2227         * NEWS: Move convenience variable news above Python news.
2228
2229 2019-06-14  Tom Tromey  <tom@tromey.com>
2230
2231         * gnulib: Move directory to top-level.
2232         * configure.ac: Don't configure gnulib.
2233         * configure: Rebuild.
2234         * common/common-defs.h: Use new path to gnulib.
2235         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2236         (GNULIB_H): Remove.
2237         (INCGNU): Look in new gnulib location.
2238         (HFILES_NO_SRCDIR): Remove gnulib files.
2239         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2240         (generated_files): Remove GNULIB_H.
2241         ($(LIBGNU), all-lib): Remove targets.
2242         (distclean): Don't mention GNULIB_BUILDDIR.
2243         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2244
2245 2019-06-14  Tom Tromey  <tromey@adacore.com>
2246
2247         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2248         Warn if symbol file does not provide any symbols.
2249
2250 2019-06-14  Tom Tromey  <tromey@adacore.com>
2251
2252         * source.c (find_and_open_source): Respect basenames_may_differ.
2253
2254 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         * annotate.c (annotate_breakpoints_invalid): Make use of
2257         scoped_restore_terminal_state.
2258         (annotate_frames_invalid): Likewise.
2259
2260 2019-06-14  Tom Tromey  <tromey@adacore.com>
2261
2262         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2263         allow assignment to an internalvar.
2264
2265 2019-06-14  Tom Tromey  <tromey@adacore.com>
2266
2267         * ada-lex.l: Allow "_" in attribute names.
2268
2269 2019-06-14  Tom Tromey  <tromey@adacore.com>
2270
2271         PR gdb/24653:
2272         * regcache.c (registers_changed): Don't call alloca.
2273         * top.c (execute_command): Don't call alloca.
2274
2275 2019-06-13  Pedro Alves  <palves@redhat.com>
2276
2277         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2278         'expression'.  When parsing an expression, error out if there's
2279         junk after "unlimited".
2280         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2281         (do_set_command): Adjust calls to is_unlimited_literal.
2282
2283 2019-06-13  Pedro Alves  <palves@redhat.com>
2284
2285         * compile/compile.c (make_compile_options_def_group): Add braces
2286         around array_view initializer.
2287         * thread.c (make_thread_apply_all_options_def_group)
2288         (make_thread_apply_all_options_def_group): Likewise.
2289
2290 2019-06-13  Pedro Alves  <palves@redhat.com>
2291
2292         * NEWS (New commands): Mention "maint test-options
2293         require-delimiter", "maint test-options unknown-is-error", "maint
2294         test-options unknown-is-operand" and "maint show
2295         test-options-completion-result".
2296         (New command options, command completion): New section.
2297         (Completion improvements): New section.
2298         Mention that you can abbreviate "unlimited".
2299
2300 2019-06-13  Pedro Alves  <palves@redhat.com>
2301
2302         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2303         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2304         * unittests/cli-utils-selftests.c (test_parse_flags)
2305         (test_parse_flags_qcs): Delete.
2306         (test_cli_utils): Don't call deleted functions.
2307
2308 2019-06-13  Pedro Alves  <palves@redhat.com>
2309
2310         * thread.c: Include "cli/cli-option.h".
2311         (tp_array_compar_ascending): Global.
2312         (tp_array_compar): Delete function.
2313         (tp_array_compar_ascending, tp_array_compar_descending): New
2314         functions.
2315         (ascending_option_def, qcs_flag_option_def)
2316         (thr_qcs_flags_option_defs)
2317         (make_thread_apply_all_options_def_group)
2318         (make_thread_apply_options_def_group): New.
2319         (thread_apply_all_command): Use gdb::option::process_options.
2320         (thread_apply_command_completer)
2321         (thread_apply_all_command_completer): New.
2322         (thread_apply_command): Use gdb::option::process_options.
2323         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2324         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2325         to generate help text of "thread apply".  Adjust "taas"'s help.
2326         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2327         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2328
2329 2019-06-13  Pedro Alves  <palves@redhat.com>
2330
2331         * thread.c (thread_apply_command): Check for invalid TID with
2332         isdigit instead of !isalpha.
2333
2334 2019-06-13  Pedro Alves  <palves@redhat.com>
2335
2336         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2337         (validate_flags_qcs): New.
2338         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2339         (validate_flags_qcs): Declare.
2340         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2341         (make_frame_apply_options_def_group): New.
2342         (frame_apply_command_count): Process options with
2343         gdb::option::process_options.
2344         (frame_apply_completer): New.
2345         (frame_apply_level_completer, frame_apply_all_completer)
2346         (frame_apply_completer): New.
2347         (_initialize_stack): Update help of "frame apply", "frame apply
2348         level", "frame apply all" and "faas" to mention supported options
2349         and install command completers.
2350         * stack.h (frame_apply_all_completer): Declare.
2351         * thread.c: Include "stack.h".
2352         (tfaas_command): Add "--".
2353         (_initialize_thread): Update help "tfaas" to mention supported
2354         options and install command completer.
2355
2356 2019-06-13  Pedro Alves  <palves@redhat.com>
2357
2358         * completer.c (complete_nested_command_line): New.
2359         (gdb_completion_word_break_characters_throw): Add assertion.
2360         * completer.h (complete_nested_command_line): Declare.
2361
2362 2019-06-13  Pedro Alves  <palves@redhat.com>
2363
2364         * stack.c (parse_backtrace_qualifiers): New.
2365         (backtrace_command): Use it.
2366         (backtrace_command_completer): Complete on qualifiers.
2367
2368 2019-06-13  Pedro Alves  <palves@redhat.com>
2369
2370         * frame.c: Include "cli/cli-option.h.
2371         (user_set_backtrace_options): New.
2372         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2373         Delete.
2374         (get_prev_frame): Adjust.
2375         (boolean_option_def, uinteger_option_def)
2376         (set_backtrace_option_defs): New.
2377         (_initialize_frame): Adjust and use
2378         gdb::option::add_setshow_cmds_for_options to install "set
2379         backtrace past-main" and "set backtrace past-entry".
2380         * frame.h: Include "cli/cli-option.h".
2381         (struct frame_print_options): Forward declare.
2382         (print_frame_arguments_all, print_frame_arguments_scalars)
2383         (print_frame_arguments_none): Declare.
2384         (print_entry_values): Delete declaration.
2385         (struct frame_print_options, user_frame_print_options): New.
2386         (struct set_backtrace_options): New.
2387         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2388         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2389         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2390         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2391         (list_args_or_locals): Add frame_print_options parameter.
2392         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2393         * python/py-framefilter.c (enumerate_args): Pass down
2394         USER_FRAME_PRINT_OPTIONS.
2395         * stack.c: Include "cli/cli-option.h".
2396         (print_frame_arguments_all, print_frame_arguments_scalars)
2397         (print_frame_arguments_none): Declare.
2398         (print_raw_frame_arguments, print_entry_values): Delete.
2399         (user_frame_print_options): New.
2400         (boolean_option_def, enum_option_def, frame_print_option_defs):
2401         New.
2402         (struct backtrace_cmd_options): New.
2403         (bt_flag_option_def): New.
2404         (backtrace_command_option_defs): New.
2405         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2406         (print_frame_arg, read_frame_arg, print_frame_args)
2407         (print_frame_info, print_frame): Add frame_print_options parameter
2408         and use it.
2409         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2410         (backtrace_command_1): Add frame_print_options and
2411         backtrace_cmd_options parameters and use them.
2412         (make_backtrace_options_def_group): New.
2413         (backtrace_command): Process command options with
2414         gdb::option::process_options.
2415         (backtrace_command_completer): New.
2416         (_initialize_stack): Extend "backtrace"'s help to mention
2417         supported options.  Install completer for "backtrace".
2418         Install some settings commands with add_setshow_cmds_for_options.
2419
2420 2019-06-13  Pedro Alves  <palves@redhat.com>
2421
2422         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2423         and that "set/show print raw frame-arguments" are now deprecated.
2424
2425         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2426         command.
2427         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2428         * stack.c (_initialize_stack): Install "set/show print
2429         raw-frame-arguments", and deprecate "set/show print raw
2430         frame-arguments".
2431         * valprint.c (_initialize_valprint): Deprecate "set/show print
2432         raw".
2433
2434 2019-06-13  Pedro Alves  <palves@redhat.com>
2435
2436         * compile/compile.c (struct compile_options): New.
2437         (compile_flag_option_def, compile_command_option_defs)
2438         (make_compile_options_def_group): New.
2439         (compile_file_command): Handle options with
2440         gdb::option::process_options.
2441         (compile_file_command_completer): New function.
2442         (compile_code_command): Handle options with
2443         gdb::option::process_options.
2444         (compile_code_command_completer): New function.
2445         (_initialize_compiler): Install completers for "compile code" and
2446         "compile file".  Mention available options in "compile code" and
2447         "compile code"'s help.
2448         * completer.c (advance_to_completion_word): New, factored out from
2449         ...
2450         (advance_to_expression_complete_word_point): ... this.
2451         (advance_to_filename_complete_word_point): New.
2452         * completer.h (advance_to_filename_complete_word_point): New
2453         declaration.
2454
2455 2019-06-13  Pedro Alves  <palves@redhat.com>
2456
2457         * compile/compile.c: Include "cli/cli-option.h".
2458         (compile_print_value): Scope data pointer is now a
2459         value_print_options pointer; adjust.
2460         (compile_print_command): Process options.  Scope data pointer is
2461         now a value_print_options pointer; adjust.
2462         (_initialize_compile): Update "compile print"'s help to include
2463         supported options.  Install a completer for "compile print".
2464         * cp-valprint.c (show_vtblprint, show_objectprint)
2465         (show_static_field_print): Delete.
2466         (_initialize_cp_valprint): Don't install "set print
2467         static-members", "set print vtbl", "set print object" here.
2468         * printcmd.c: Include "cli/cli-option.h" and
2469         "common/gdb_optional.h".
2470         (print_command_parse_format): Rework to fill in a
2471         value_print_options instead of a format_data.
2472         (print_value): Change parameter type from format_data pointer to
2473         value_print_options reference.  Adjust.
2474         (print_command_1): Process options.  Adjust to pass down a
2475         value_print_options.
2476         (print_command_completer): New.
2477         (_initialize_printcmd): Install print_command_completer as
2478         handle_brkchars completer for the "print" command.  Update
2479         "print"'s help to include supported options.
2480         * valprint.c: Include "cli/cli-option.h".
2481         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2482         here from cp-valprint.c.
2483         (boolean_option_def, uinteger_option_def)
2484         (value_print_option_defs, make_value_print_options_def_group):
2485         New.  Use gdb::option::add_setshow_cmds_for_options to install
2486         "set print elements", "set print null-stop", "set print repeats",
2487         "set print pretty", "set print union", "set print array", "set
2488         print address", "set print symbol", "set print array-indexes".
2489         * valprint.h: Include <string> and "cli/cli-option.h".
2490         (make_value_print_options_def_group): Declare.
2491         (print_value): Change parameter type from format_data pointer to
2492         value_print_options reference.
2493         (print_command_completer): Declare.
2494
2495 2019-06-13  Pedro Alves  <palves@redhat.com>
2496
2497         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2498         (COMMON_SFILES): Add maint-test-settings.c.
2499         * cli/cli-decode.c (boolean_enums): New global, factored out from
2500         ...
2501         (add_setshow_boolean_cmd): ... here.
2502         * cli/cli-decode.h (boolean_enums): Declare.
2503         * cli/cli-option.c: New file.
2504         * cli/cli-option.h: New file.
2505         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2506         factored out from ...
2507         (parse_cli_boolean_value(const char *)): ... this.
2508         (is_unlimited_literal): Change parameter type to pointer to
2509         pointer.  Adjust and advance ARG pointer.
2510         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2511         (parse_cli_var_enum): New, factored out from ...
2512         (do_set_command): ... this.  Adjust.
2513         * cli/cli-setshow.h (parse_cli_boolean_value)
2514         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2515         (parse_cli_var_enum): Declare.
2516         * cli/cli-utils.c: Include "cli/cli-option.h".
2517         (get_ulongest): New.
2518         * cli/cli-utils.h (get_ulongest): Declare.
2519         (check_for_argument): New overloads.
2520         * maint-test-options.c: New file.
2521
2522 2019-06-13  Pedro Alves  <palves@redhat.com>
2523
2524         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2525         parse a range if "-" is at the end of the string.
2526
2527 2019-06-13  Pedro Alves  <palves@redhat.com>
2528
2529         * cli/cli-setshow.c (parse_auto_binary_operation)
2530         (parse_cli_boolean_value): Don't allow "o".
2531
2532 2019-06-13  Pedro Alves  <palves@redhat.com>
2533
2534         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2535         * NEWS: Mention maint test-settings KIND.
2536         * maint-test-settings.c: New file.
2537
2538 2019-06-13  Pedro Alves  <palves@redhat.com>
2539
2540         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2541         completer.
2542         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2543         "set" completers.
2544
2545 2019-06-13  Pedro Alves  <palves@redhat.com>
2546
2547         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2548         after item.
2549
2550 2019-06-13  Pedro Alves  <palves@redhat.com>
2551
2552         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2553
2554 2019-06-13  Pedro Alves <palves@redhat.com>
2555
2556         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2557         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2558         call.
2559         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2560         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2561         calls.
2562         (check_for_argument): Skip spaces after argument.
2563
2564 2019-06-13  Pedro Alves  <palves@redhat.com>
2565
2566         * thread.c (thread_apply_command): Adjust TID parsing.
2567         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2568         detected before end of string.
2569         (tid_is_in_list): Error out if LIST is invalid.
2570
2571 2019-06-13  Pedro Alves  <palves@redhat.com>
2572
2573         * completer.c (complete_line_internal_1): Rewind completion word
2574         point.
2575         (completion_tracker::advance_custom_word_point_by): Change
2576         parameter type to int.
2577         * completer.h (completion_tracker::advance_custom_word_point_by):
2578         Likewise.
2579
2580 2019-06-13  Pedro Alves  <palves@redhat.com>
2581
2582         * completer.c (advance_to_completion_word): Handle delimiters.
2583
2584 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2585
2586         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2587
2588 2019-06-11  Tom Tromey  <tom@tromey.com>
2589
2590         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2591         (xmalloc_failed): Move to alloc.c.
2592         * alloc.c: New file.
2593         * Makefile.in (COMMON_SFILES): Add alloc.c.
2594
2595 2019-06-11  Tom Tromey  <tom@tromey.com>
2596
2597         * nat/linux-waitpid.c: Don't include server.h.
2598         (linux_debug): Remove.
2599         (my_waitpid): Update.
2600
2601 2019-06-11  Tom Tromey  <tromey@adacore.com>
2602
2603         * infcall.c (_initialize_infcall): Remove trailing newline from
2604         help.
2605         * user-regs.c (_initialize_user_regs): Remove trailing newline
2606         from help.
2607         * typeprint.c (_initialize_typeprint): Remove trailing newline
2608         from help.
2609         * reverse.c (_initialize_reverse): Remove trailing newlines from
2610         help.
2611         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2612         from help.
2613         * language.c (add_set_language_command): Remove trailing newline
2614         from help.
2615         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2616         help.
2617         * disasm.c (_initialize_disasm): Remove trailing newline from
2618         help.
2619         * top.c (init_main): Remove trailing newline from help.
2620         * interps.c (_initialize_interpreter): Remove trailing newline
2621         from help.
2622         * btrace.c (_initialize_btrace): Remove trailing newlines from
2623         help.
2624         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2625         from help.
2626         * python/python.c (_initialize_python): Remove trailing newline
2627         from help.
2628         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2629         help.
2630         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2631         from help.  Reformat some text.
2632         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2633         from help.
2634         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2635         newline from help.
2636
2637 2019-06-11  Tom Tromey  <tromey@adacore.com>
2638
2639         * darwin-nat.c (darwin_decode_exception_message)
2640         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2641
2642 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2643
2644         * valops.c (value_slice): Check for not allocated or not
2645         associated values.
2646
2647 2019-06-10  Tom de Vries  <tdevries@suse.de>
2648
2649         PR gdb/24618
2650         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2651         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2652         invalid.
2653
2654 2019-06-10  Tom de Vries  <tdevries@suse.de>
2655
2656         PR gdb/24611
2657         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2658         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2659
2660 2019-06-10  Tom de Vries  <tdevries@suse.de>
2661
2662         PR symtab/24545
2663         * symtab.c (struct demangled_name_entry): Add language field.
2664         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2665         static minimal symbol".  Set and use language field.
2666
2667 2019-06-10  Tom Tromey  <tromey@adacore.com>
2668
2669         * ada-lang.c (_initialize_ada_language): Update help text.
2670
2671 2019-06-10  Tom Tromey  <tromey@adacore.com>
2672
2673         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2674         with a newline.
2675         * guile/guile.c (handle_boot_error): Don't end warning with a
2676         newline.
2677         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2678         warning with a newline.
2679         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2680         newline.
2681         (s12z_frame_cache): Likewise.
2682         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2683         a newline.
2684         * solib-svr4.c (disable_probes_interface): Don't end warning with
2685         a newline.
2686         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2687         newline.
2688         * python/python.c (do_finish_initialization): Don't end warning
2689         with a newline.
2690
2691 2019-06-10  Tom Tromey  <tom@tromey.com>
2692
2693         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2694         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2695         gdbpy_enter.
2696
2697 2019-06-10  Tom Tromey  <tromey@adacore.com>
2698
2699         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2700         data.
2701         (elf_new_init): Don't call stabsread_new_init.
2702         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2703         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2704         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2705
2706 2019-06-10  Tom de Vries  <tdevries@suse.de>
2707
2708         PR symtab/16264
2709         PR symtab/24517
2710         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2711
2712 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2713
2714         * source.c (find_and_open_source): Also rewrite relative file
2715         names.
2716
2717 2019-04-26  Amos Bird  <amosbird@gmail.com>
2718
2719         * annotate.c (annotate_thread_exited): Add "thread-exited"
2720         annotation.
2721
2722 2019-06-06  Tom Tromey  <tromey@adacore.com>
2723
2724         * maint.h (class scoped_command_stats): Use
2725         DISABLE_COPY_AND_ASSIGN.
2726         <print_time>: New method.
2727         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2728         print_time.
2729         (scoped_command_stats::print_time): New method.
2730
2731 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2734         instructions of lengths 6 or 8 bytes.
2735
2736 2019-06-04  Pedro Alves  <palves@redhat.com>
2737
2738         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2739
2740         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2741         * breakpoint.c (condition_completer): Likewise.
2742         * cli/cli-dump.c (scan_expression): Likewise.
2743         * common/filestuff.c (mkdir_recursive): Likewise.
2744         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2745         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2746         (gdb_abspath): Likewise.
2747         * compile/compile-cplus-types.c
2748         (compile_cplus_instance::decl_name): Likewise.
2749         * completer.c (complete_explicit_location):
2750         (signal_completer, reg_or_group_completer_1): Likewise.
2751         * cp-support.c (cp_remove_params_if_any): Likewise.
2752         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2753         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2754         * infcmd.c (strip_bg_char): Likewise.
2755         * linespec.c (copy_token_string): Likewise.
2756         * mi/mi-main.c (output_cores): Likewise.
2757         * psymtab.c (psymtab_search_name):
2758         * symfile.c (test_set_ext_lang_command): Likewise.
2759         * target.c (target_fileio_read_stralloc): Likewise.
2760         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2761         * value.c (complete_internalvar): Likewise.
2762
2763 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2764
2765         Add objfile property to gdb.Type.
2766         * NEWS: Mention Python API addition.
2767         * python/py-type.c (typy_get_objfile): New method.
2768
2769 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2770
2771         * NEWS: Mention the new set|show style [title|highlight].
2772         Mention changes to "show style", "help" and "apropos".
2773
2774 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2775
2776         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2777         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2778         instead of print_help_for_command.
2779         (print_doc_of_command): New function.
2780         (help_list): Add 'apropos -v word' suggestion.
2781         (print_help_for_command): Style the command name using title style.
2782         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2783         (_initialize_cli_cmds): Describe -v in apropos_command help.
2784
2785 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2786
2787         * cli/cli-style.h (cli_style_option): Add name in constructor,
2788         add m_name class member, add constructor with intensity,
2789         add name class function.
2790         (cli_style_option::add_setshow_commands): Remove name argument.
2791         (highlight_style, title_style): New styles.
2792         * cli/cli-style.c (do_show): New function that shows a style
2793         characteristic styling the style name with itself.
2794         (set_style_name): New function.
2795         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2796         Update all callers according to the changes in cli/cli-style.h.
2797         * utils.h (fputs_highlighted): New function.
2798         * utils.c (fputs_highlighted): Likewise.
2799
2800 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2801
2802         * NEWS: Mention new pipe command and new convenience variables.
2803
2804 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2805
2806         * cli/cli-cmds.c (pipe_command): New function.
2807         (_initialize_cli_cmds): Call add_com for pipe_command.
2808         Define | as an alias for pipe.
2809         (exit_status_set_internal_vars): New function.
2810         (shell_escape): Call exit_status_set_internal_vars.
2811         cli/cli-decode.c (find_command_name_length): Recognize | as
2812         a single character command.
2813
2814 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2815
2816         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2817         top.c (execute_command_to_ui_file): New function, mostly a copy
2818         of execute_command_to_string.
2819         (execute_command_to_string): Implement by calling
2820         execute_command_to_ui_file.
2821
2822 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2823
2824         * top.h (saved_command_line): Remove declaration.
2825         * top.c (previous_saved_command_line, previous_repeat_arguments):
2826         New variables.
2827         (saved_command_line): Make static, define together with other
2828         'repeat variables'.
2829         (dont_repeat): Clear repeat_arguments.
2830         (repeat_previous, get_saved_command_line, save_command_line):
2831         New functions.
2832         (gdb_init): Initialize saved_command_line
2833         and previous_saved_command_line.
2834         * main.c (captured_main_1): Remove saved_command_line initialization.
2835         * event-top.c (handle_line_of_input): Update to use
2836         the new 'repeat' related functions instead of direct access to
2837         saved_command_line.
2838         * command.h (repeat_previous, get_saved_command_line,
2839         save_command_line): New declarations.
2840         (dont_repeat): Add comment.
2841
2842 2019-05-30  Tom Tromey  <tromey@adacore.com>
2843
2844         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2845         Fix comment.
2846         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2847
2848 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2849
2850         PR cli/24587
2851         * completer.c (complete): Initialize variable word.
2852
2853 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2854
2855         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2856         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2857         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2858         'body' is NULL to the outter 'if', protecting the '!is_define'
2859         situation as well.
2860
2861 2019-05-29  Tom Tromey  <tromey@adacore.com>
2862
2863         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2864         (dwarf_unknown): New function.
2865         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2866         (dwarf_type_encoding_name): Use dwarf_unknown.
2867
2868 2019-05-29  Tom Tromey  <tromey@adacore.com>
2869
2870         PR c++/20020:
2871         * cp-valprint.c (cp_print_value_fields): Call
2872         cp_print_static_field inside "try".
2873
2874 2019-05-29  Tom Tromey  <tromey@adacore.com>
2875
2876         * inflow.c (struct terminal_info): Add default operator=.
2877         * configure: Rebuild.
2878         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2879         -Wdeprecated-copy-dtor, -Wredundant-move.
2880
2881 2019-05-29  Tom Tromey  <tromey@adacore.com>
2882
2883         * NEWS: Add entry.
2884         * infcmd.c (print_return_value_1): Handle finish_print
2885         option.
2886         (show_print_finish): New function.
2887         (_initialize_infcmd): Add "set/show print finish" commands.
2888         * valprint.c (user_print_options): Initialize new member.
2889         * valprint.h (struct value_print_options) <finish_print>: New
2890         member.
2891
2892 2019-05-28  Tom Tromey  <tromey@adacore.com>
2893
2894         * ada-lang.c (ada_remove_Xbn_suffix)
2895         (find_old_style_renaming_symbol)
2896         (parse_old_style_renaming): Remove.
2897         (ada_find_renaming_symbol): Don't call
2898         find_old_style_renaming_symbol.
2899         (ada_is_renaming_symbol): Rename from
2900         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2901         bool.  Now static.
2902         (ada_read_var_value): Update and simplify.
2903         * ada-exp.y (write_var_or_type): Remove old code.
2904
2905 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * event-top.c: Remove include comment.
2908         * inflow.c (class scoped_ignore_sigttou): Move from here...
2909         * inflow.h (class scoped_ignore_sigttou): ...to here.
2910         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2911         * top.c:  Remove include comment.
2912
2913 2019-05-27  Tom Tromey  <tom@tromey.com>
2914
2915         * NEWS: Fix typo.
2916
2917 2019-05-22  Tom Tromey  <tromey@adacore.com>
2918
2919         * target.c (target_follow_exec): Constify parameter.
2920         * target-delegates.c: Rebuild.
2921         * remote.c (remote_target::follow_exec): Constify parameter.
2922         * infrun.c (follow_exec): Constify parameter.
2923         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2924         (target_follow_exec): Likewise.
2925
2926 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2927
2928         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2929         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2930
2931 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2932
2933         * NEWS: Add debugredirect and testsuite sections.
2934
2935 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2936
2937         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2938         target descriptions using exclusively floating point register name
2939         aliases.
2940
2941 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2942
2943         PR gdb/18644:
2944         * f-lang.c (build_fortran_types): Handle the case where
2945         gdbarch_floatformat_for_type returns a nullptr.
2946
2947 2019-05-21  Tom de Vries  <tdevries@suse.de>
2948
2949         PR cli/24587
2950         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2951
2952 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2953
2954         PR gdb/18644:
2955         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2956         16-byte floats.
2957         * i386-tdep.c (i386_floatformat_for_type): Use
2958         floatformats_ia64_quad for the 16-byte floating point component
2959         within a fortran 32-byte complex number.
2960
2961 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2964         delete default constructor.
2965         (find_partial_die): Update to return const struct.
2966         (partial_die_parent_scope): Move variable declaration into scope
2967         of its use and change its type to auto.
2968         (guess_partial_die_structure_name): Likewise.
2969         (partial_die_info::fixup): Likewise.
2970
2971 2019-05-17  Tom Tromey  <tromey@adacore.com>
2972
2973         * source.c (find_and_open_source): Remove cast.
2974
2975 2019-05-17  Tom Tromey  <tromey@adacore.com>
2976
2977         * annotate.c (annotate_source): Make "filename" const.
2978         * annotate.h (annotate_source): Use const.
2979
2980 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2981
2982         * disasm.c (set_disassembler_options): Send errors to stderr.
2983
2984 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2985
2986         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2987         (cli_interp_base::set_logging): Check debug_redirect.
2988         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2989         * cli/cli-logging.c (debug_redirect): Add static variable.
2990         (pop_output_files): Add default param.
2991         (handle_redirections): Print debug setting.
2992         (show_logging_command): Likewise.
2993         (_initialize_cli_logging): Add debugredirect command.
2994         * interps.c (current_interp_set_logging): Add debug_redirect
2995         parameter.
2996         * interps.h (set_logging): Add debug_redirect parameter.
2997         (current_interp_set_logging): Likewise.
2998         * mi/mi-common.h: Likewise.
2999         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3000
3001 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3002             Tom Tromey  <tromey@adacore.com>
3003
3004         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3005         directly.
3006         * cli/cli-interp.h (make_logging_output): Remove declaration.
3007         * cli/cli-logging.c (make_logging_output): Remove function.
3008         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3009         directly.
3010         * ui-file.c (tee_file::tee_file): Remove bools.
3011         (tee_file::~tee_file): Remove deletes.
3012         * ui-file.h (tee_file): Remove bools.
3013
3014 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3015
3016         * mi/mi-cmds.h (mi_cmd_complete): New function.
3017         * mi/mi-main.c (mi_cmd_complete): Likewise.
3018         * mi/mi-cmds.c: Define new MI command -complete.
3019         * NEWS: Mention new -complete command.
3020
3021 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3022
3023         * completer.h (complete): New function.
3024         * completer.c (complete): Likewise.
3025         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3026         function defined in completer.h.
3027
3028 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3029
3030         * MAINTAINERS (Write After Approval): Add myself.
3031
3032 2019-05-17  Tom de Vries  <tdevries@suse.de>
3033
3034         PR gdb/24094
3035         * dwarf2read.c (struct cu_partial_die_info): New struct.
3036         (find_partial_die): Return cu_partial_die_info.
3037         (partial_die_parent_scope, guess_partial_die_structure_name)
3038         (partial_die_info::fixup): Handle new return type of find_partial_die.
3039
3040 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3041
3042         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3043         "std::string", simplifying the algorithm.
3044
3045 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3046
3047         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3048         (stap_static_probe_ops::get_probes): Likewise.
3049
3050 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3051
3052         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3053         '-')" and "else if".
3054         (stap_parse_single_operand): Join checks for
3055         "gdbarch_stap_parse_special_token_p" and
3056         "gdbarch_stap_parse_special_token" in the same "if" statement.
3057         Invert check when verifying for operation on register
3058         displacement.
3059
3060 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3061
3062         * stap-probe.c (stap_get_opcode): Update comment.
3063         (stap_get_expected_argument_type): Likewise.
3064         (handle_stap_probe): Likewise.
3065
3066 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3067
3068         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3069         return type to 'bool'.  Adjust comment.  Use 'bool' when
3070         appropriate.
3071         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3072         * stap-probe.c (stap_parse_argument_1): Likewise.
3073         (stap_is_operator): Likewise.
3074         (stap_is_generic_prefix): Likewise.
3075         (stap_is_register_prefix): Likewise.
3076         (stap_is_register_indirection_prefix): Likewise.
3077         (stap_is_integer_prefix): Likewise.
3078         (stap_generic_check_suffix): Likewise.
3079         (stap_check_integer_suffix): Likewise.
3080         (stap_check_register_suffix): Likewise.
3081         (stap_check_register_indirection_suffix): Likewise.
3082         (stap_parse_register_operand): Likewise.
3083         (stap_parse_single_operand): Likewise.
3084         (stap_parse_argument_1): Likewise.
3085         (stap_probe::get_argument_count): Likewise.
3086         (stap_is_operator): Likewise.
3087
3088 2019-05-16  Tom Tromey  <tromey@adacore.com>
3089
3090         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3091         keyword to foreach.
3092
3093 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3094
3095         * linux-thread-db.c (try_thread_db_load_1): Change return type
3096         to bool.
3097         (try_thread_db_load): Likewise.
3098         (try_thread_db_load_from_pdir_1): Likewise.
3099         (try_thread_db_load_from_pdir): Likewise.
3100         (try_thread_db_load_from_sdir): Likewise.
3101         (try_thread_db_load_from_dir): Likewise.
3102         (thread_db_load_search): Likewise.
3103         (has_libpthread): Likewise.
3104         (thread_db_load): Likewise.
3105
3106 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3107
3108         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3109         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3110         NULL, and complain/return if that's the case.
3111
3112 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3113
3114         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3115         (advance, posn, abstract_read_memory): New functions.
3116         [struct mem_read_abstraction]: New struct.
3117         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3118
3119 2019-05-14  Tom Tromey  <tromey@adacore.com>
3120
3121         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3122         value is not lval_memory.
3123
3124 2019-05-14  Tom Tromey  <tromey@adacore.com>
3125
3126         * solib.c (info_sharedlibrary_command): Style the file name.
3127
3128 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3129
3130         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3131         (aarch64_vnv_type): Likewise.
3132         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3133         * common/tdesc.c: Likewise.
3134         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3135         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3136         * features/aarch64-fpu.xml: Add ieee half view.
3137         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3138         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3139         * gdbtypes.h (struct builtin_type): Likewise.
3140         (struct objfile_type): Likewise.
3141
3142 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3143
3144         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3145         typo.
3146         * location.h (string_to_event_location): Likewise.
3147
3148 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3149
3150         GDB 8.3 released.
3151
3152 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3153
3154         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3155         New variable declaration.
3156         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3157         New variable.
3158         (print_one_breakpoint): Use ui_out::test_flags and new global
3159         variable to compute use_fixed_output.
3160         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3161         Remove.
3162         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3163         (mi_multi_location_breakpoint_output_fixed): Remove.
3164         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3165         new variable.
3166         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3167         fix_multi_location_breakpoint_output flag if version >= 3.
3168         * ui-out.h (enum ui_out_flag)
3169         <fix_multi_location_breakpoint_output>: New enumerator.
3170
3171 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3172
3173         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3174
3175 2019-05-10  Tom Tromey  <tromey@adacore.com>
3176
3177         * ada-lang.c (catch_ada_completer): New function.
3178         (_initialize_ada_language): Use it.
3179
3180 2019-05-10  Tom Tromey  <tromey@adacore.com>
3181
3182         * thread.c (print_thread_info): Make "requested_threads" const.
3183         * gdbthread.h (print_thread_info): Make "requested_threads"
3184         const.
3185         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3186         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3187
3188 2019-05-08  Tom Tromey  <tom@tromey.com>
3189
3190         * gdbtypes.c (objfile_type_data): Change type.
3191         (objfile_type, _initialize_gdbtypes): Update.
3192
3193 2019-05-08  Tom Tromey  <tom@tromey.com>
3194
3195         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3196         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3197         (_initialize_dwarf2_frame): Update.
3198
3199 2019-05-08  Tom Tromey  <tom@tromey.com>
3200
3201         * objc-lang.c (objc_objfile_data): Change type.
3202         (find_methods): Update.
3203         (_initialize_objc_lang): Remove.
3204
3205 2019-05-08  Tom Tromey  <tom@tromey.com>
3206
3207         * stabsread.c (rs6000_builtin_type_data): Change type.
3208         (rs6000_builtin_type, _initialize_stabsread): Update.
3209
3210 2019-05-08  Tom Tromey  <tom@tromey.com>
3211
3212         * mips-tdep.c (mips_pdr_data): Remove.
3213         (_initialize_mips_tdep): Update.
3214
3215 2019-05-08  Tom Tromey  <tom@tromey.com>
3216
3217         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3218         (hppa_init_objfile_priv_data, read_unwind_info)
3219         (find_unwind_entry, _initialize_hppa_tdep): Update.
3220
3221 2019-05-08  Tom Tromey  <tom@tromey.com>
3222
3223         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3224         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3225         on obstack.
3226         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3227
3228 2019-05-08  Tom Tromey  <tom@tromey.com>
3229
3230         * mdebugread.c (basic_type_data): Change type.
3231         (basic_type, _initialize_mdebugread): Update.
3232
3233 2019-05-08  Tom Tromey  <tom@tromey.com>
3234
3235         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3236
3237 2019-05-08  Tom Tromey  <tom@tromey.com>
3238
3239         * nto-tdep.c (nto_inferior_data_reg): Change type.
3240         (nto_inferior_data): Update.
3241         (nto_inferior_data_cleanup, nto_new_inferior_data)
3242         (_initialize_nto_tdep): Remove.
3243         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3244
3245 2019-05-08  Tom Tromey  <tom@tromey.com>
3246
3247         * ada-lang.c (struct ada_inferior_data): Add initializers.
3248         (ada_inferior_data): Change type.
3249         (ada_inferior_data_cleanup): Remove.
3250         (get_ada_inferior_data, ada_inferior_exit)
3251         (struct ada_pspace_data): Add initializers, destructor.
3252         (ada_pspace_data_handle): Change type.
3253         (get_ada_pspace_data): Update.
3254         (ada_pspace_data_cleanup): Remove.
3255
3256 2019-05-08  Tom Tromey  <tom@tromey.com>
3257
3258         * coffread.c (struct coff_symfile_info): Add initializers.
3259         (coff_objfile_data_key): Move lower.  Change type.
3260         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3261         Update.
3262         (coff_free_info): Remove.
3263
3264 2019-05-08  Tom Tromey  <tom@tromey.com>
3265
3266         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3267         (fbsd_pspace_data_handle): Move lower.  Change type.
3268         (get_fbsd_pspace_data): Update.
3269         (fbsd_pspace_data_cleanup): Remove.
3270         (_initialize_fbsd_tdep): Update.
3271
3272 2019-05-08  Tom Tromey  <tom@tromey.com>
3273
3274         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3275         (get_ada_tasks_pspace_data): Update.
3276         (ada_tasks_pspace_data_cleanup): Remove.
3277         (_initialize_tasks): Update.
3278         (ada_tasks_inferior_data_handle): Change type.
3279         (get_ada_tasks_inferior_data): Update.
3280         (ada_tasks_inferior_data_cleanup): Remove.
3281         (struct ada_tasks_pspace_data): Add initializers.
3282
3283 2019-05-08  Tom Tromey  <tom@tromey.com>
3284
3285         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3286         * symfile-debug.c (debug_sym_get_probes): Change type.
3287         * stap-probe.c (handle_stap_probe):
3288         (stap_static_probe_ops::get_probes): Change type.
3289         * probe.h (class static_probe_ops) <get_probes>: Change type.
3290         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3291         (parse_probes_in_pspace): Update.
3292         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3293         Update.
3294         (any_static_probe_ops::get_probes): Change type.
3295         * elfread.c (elfread_data): New typedef.
3296         (probe_key): Change type.
3297         (elf_get_probes): Likewise.  Update.
3298         (probe_key_free): Remove.
3299         (_initialize_elfread): Update.
3300         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3301         Change type.
3302         (dtrace_process_dof_probe, dtrace_process_dof)
3303         (dtrace_static_probe_ops::get_probe): Change type.
3304
3305 2019-05-08  Tom Tromey  <tom@tromey.com>
3306
3307         * xcoffread.c (struct xcoff_symfile_info): Rename from
3308         coff_symfile_info.  Add initializers.
3309         (xcoff_objfile_data_key): Move lower.  Change type.
3310         (XCOFF_DATA): Rewrite.
3311         (xcoff_free_info): Remove.
3312         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3313         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3314         (xcoff_initial_scan): Update.
3315
3316 2019-05-08  Tom Tromey  <tom@tromey.com>
3317
3318         * solib-svr4.c (struct svr4_info): Add initializers and
3319         destructor.
3320         <probes_table>: Now an htab_up.
3321         (solib_svr4_pspace_data): Change type.
3322         (free_probes_table): Simplify.
3323         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3324         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3325         (probes_table_remove_objfile_probes, register_solib_event_probe)
3326         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3327         (_initialize_svr4_solib): Update.
3328
3329 2019-05-08  Tom Tromey  <tom@tromey.com>
3330
3331         * remote.c (remote_pspace_data): Change type.
3332         (remote_pspace_data_cleanup): Remove.
3333         (get_remote_exec_file, set_pspace_remote_exec_file)
3334         (_initialize_remote): Update.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * breakpoint.c (breakpoint_objfile_key): Change type.
3339         (get_breakpoint_objfile_data): Update.
3340         (free_breakpoint_objfile_data): Remove.
3341         (_initialize_breakpoint): Update.
3342
3343 2019-05-08  Tom Tromey  <tom@tromey.com>
3344
3345         * linux-tdep.c (struct linux_info): Add initializers.
3346         (linux_inferior_data): Move.  Change type.
3347         (invalidate_linux_cache_inf): Update.
3348         (linux_inferior_data_cleanup): Remove.
3349         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3350
3351 2019-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * auxv.c (auxv_inferior_data): Move.  Change type.
3354         (auxv_inferior_data_cleanup): Remove.
3355         (invalidate_auxv_cache_inf): Rewrite.
3356         (get_auxv_inferior_data, _initialize_auxv): Update.
3357
3358 2019-05-08  Tom Tromey  <tom@tromey.com>
3359
3360         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3361         (symfile_debug_objfile_data_key): Change type.
3362         (symfile_debug_installed, debug_qf_has_symbols)
3363         (debug_qf_find_last_source_symtab)
3364         (debug_qf_forget_cached_source_info)
3365         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3366         (debug_qf_print_stats, debug_qf_dump)
3367         (debug_qf_expand_symtabs_for_function)
3368         (debug_qf_expand_all_symtabs)
3369         (debug_qf_expand_symtabs_with_fullname)
3370         (debug_qf_map_matching_symbols)
3371         (debug_qf_expand_symtabs_matching)
3372         (debug_qf_find_pc_sect_compunit_symtab)
3373         (debug_qf_map_symbol_filenames)
3374         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3375         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3376         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3377         (debug_sym_read_linetable, debug_sym_relocate): Update.
3378         (symfile_debug_free_objfile): Remove.
3379         (install_symfile_debug_logging, _initialize_symfile_debug):
3380         Update.
3381
3382 2019-05-08  Tom Tromey  <tom@tromey.com>
3383
3384         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3385         allocate_on_obstack.
3386         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3387         (get_dwarf2_per_objfile): Update.
3388         (set_dwarf2_per_objfile): Remove.
3389         (dwarf2_has_info, dwarf2_get_section_info): Update.
3390         (dwarf2_free_objfile): Remove.
3391         (_initialize_dwarf2_read): Update.
3392
3393 2019-05-08  Tom Tromey  <tom@tromey.com>
3394
3395         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3396         initializers.
3397         <unsupported_script_warning_printed,
3398         script_not_found_warning_printed>: Now bool.
3399         (auto_load_pspace_data): Change type.
3400         (~auto_load_pspace_info): Rename from
3401         auto_load_pspace_data_cleanup.
3402         (get_auto_load_pspace_data, init_loaded_scripts_info)
3403         (clear_section_scripts, maybe_print_unsupported_script_warning)
3404         (maybe_print_script_not_found_warning, _initialize_auto_load):
3405         Update.
3406
3407 2019-05-08  Tom Tromey  <tom@tromey.com>
3408
3409         * objfiles.c (objfile_pspace_info): Add destructor and
3410         initializers.
3411         (objfiles_pspace_data): Change type.
3412         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3413         (get_objfile_pspace_data): Update.
3414         (objfiles_bfd_data): Change type.
3415         (get_objfile_bfd_data): Update.
3416         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3417
3418 2019-05-08  Tom Tromey  <tom@tromey.com>
3419
3420         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3421         Change type.
3422         (get_catch_syscall_inferior_data): Update.
3423         (catch_syscall_inferior_data_cleanup): Remove.
3424         (_initialize_break_catch_syscall): Update.
3425
3426 2019-05-08  Tom Tromey  <tom@tromey.com>
3427
3428         * inflow.c (struct terminal_info): Add destructor and
3429         initializers.
3430         (inflow_inferior_data): Change type.
3431         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3432         (get_inflow_inferior_data, inflow_inferior_exit)
3433         (swap_terminal_info, _initialize_inflow): Update.
3434
3435 2019-05-08  Tom Tromey  <tom@tromey.com>
3436
3437         * target-dcache.c (target_dcache_cleanup): Remove.
3438         (target_dcache_aspace_key): Change type.
3439         (target_dcache_init_p, target_dcache_invalidate)
3440         (target_dcache_get, target_dcache_get_or_init)
3441         (_initialize_target_dcache): Update.
3442         * dcache.h (struct dcache_deleter): New.
3443
3444 2019-05-08  Tom Tromey  <tom@tromey.com>
3445
3446         * symtab.c (struct symbol_cache): Add destructor and
3447         initializers.
3448         (symbol_cache_key): Move.  Change type.
3449         (make_symbol_cache, free_symbol_cache): Remove.
3450         (get_symbol_cache): Update.
3451         (symbol_cache_cleanup): Remove.
3452         (ALL_PSPACES, symbol_cache_flush)
3453         (maintenance_print_symbol_cache)
3454         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3455         Update.
3456
3457 2019-05-08  Tom Tromey  <tom@tromey.com>
3458
3459         * symtab.c (struct main_info): Add destructor and initializers.
3460         (main_progspace_key): Move.  Change type.
3461         (get_main_info): Update.
3462         (main_info_cleanup): Remove.
3463         (_initialize_symtab): Update.
3464
3465 2019-05-08  Tom Tromey  <tom@tromey.com>
3466
3467         * registry.h (DECLARE_REGISTRY): Define the _key class.
3468
3469 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3470
3471         * NEWS: Merge two 'New commands' sections.
3472
3473 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3474
3475         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3476         parameter and use Ada language definition instead.
3477         (ada_val_print_ptr): Remove unused language parameter.
3478         (ada_val_print_num): Remove language parameter and use Ada language
3479         definition instead.
3480         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3481         parameter.
3482         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3483         parameter and use Ada language definition instead.
3484         (ada_val_print_1): Update all ada_val_print_xxx calls.
3485         Remove language parameter.
3486         (ada_val_print): Update ada_val_print_1 call.
3487
3488 2019-05-08  Tom Tromey  <tromey@adacore.com>
3489
3490         * remote.c (remote_hw_watchpoint_limit)
3491         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3492         Now static.
3493
3494 2019-05-08  Tom Tromey  <tromey@adacore.com>
3495
3496         * maint.c (_initialize_maint_cmds): Move initialization code to
3497         remote.c.
3498         (watchdog, show_watchdog): Move to remote.c.
3499         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3500         "watchdog" static.
3501         (_initialize_remote): Move initialization code from maint.c.
3502         * defs.h (watchdog): Don't declare.
3503
3504 2019-05-08  Tom Tromey  <tromey@adacore.com>
3505
3506         * tui/tui-interp.c: Include main.h.
3507         * interps.c: Include main.h.
3508         * main.h (interpreter_p): Declare.
3509         * defs.h (interpreter_p): Don't declare.
3510
3511 2019-05-08  Tom Tromey  <tromey@adacore.com>
3512
3513         * dwarf2loc.c: Include dwarf2read.h.
3514         * defs.h (read_unsigned_leb128): Don't declare.
3515         * dwarf2read.h (read_unsigned_leb128): Declare.
3516
3517 2019-05-08  Tom Tromey  <tromey@adacore.com>
3518
3519         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3520         method.
3521
3522 2019-05-08  Tom Tromey  <tromey@adacore.com>
3523
3524         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3525         when no wrap column is set.
3526
3527 2019-05-08  Tom Tromey  <tromey@adacore.com>
3528
3529         * c-lang.c (c_get_string): Handle non-C-style arrays.
3530
3531 2019-05-08  Tom Tromey  <tromey@adacore.com>
3532
3533         * typeprint.c (print_offset_data::update): Print the bit offset,
3534         not the number of bits remaining.
3535
3536 2019-05-08  Tom Tromey  <tromey@adacore.com>
3537
3538         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3539         padding at end of comment.
3540
3541 2019-05-08  Tom Tromey  <tromey@adacore.com>
3542
3543         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3544         Compare main types.
3545
3546 2019-05-06  Tom Tromey  <tom@tromey.com>
3547
3548         * common/scoped_mmap.c: Include common-defs.h.
3549         * common/scoped_mmap.h: Don't include config.h.
3550
3551 2019-05-04  Tom Tromey  <tom@tromey.com>
3552
3553         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3554         (struct aarch64_call_info): Add initializers.
3555         <si>: Now a std::vector.
3556         (pass_on_stack, aarch64_push_dummy_call): Update.
3557
3558 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3559             Tom Tromey  <tom@tromey.com>
3560
3561         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3562         (ppc_threads): Now a std::vector.  Now static.
3563         (hwdebug_find_thread_points_by_tid)
3564         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3565         Update.
3566
3567 2019-05-04  Tom Tromey  <tom@tromey.com>
3568
3569         * arc-tdep.c (arc_tdesc_init): Return bool.
3570
3571 2019-05-04  Tom Tromey  <tom@tromey.com>
3572
3573         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3574         Use gdb_assert_not_reached.
3575
3576 2019-05-04  Tom Tromey  <tom@tromey.com>
3577
3578         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3579         "false".
3580
3581 2019-05-04  Tom Tromey  <tom@tromey.com>
3582
3583         * arc-tdep.c (arc_tdesc_init): Use bool.
3584
3585 2019-05-04  Tom Tromey  <tom@tromey.com>
3586
3587         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3588
3589 2019-05-04  Tom Tromey  <tom@tromey.com>
3590
3591         * cli/cli-cmds.c (valid_command_p): Return bool.
3592
3593 2019-05-04  Tom Tromey  <tom@tromey.com>
3594
3595         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3596         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3597
3598 2019-05-04  Raul Tambre  <raul@tambre.ee>
3599
3600         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3601         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3602         operator for comparison.
3603
3604 2019-05-04  Tom Tromey  <tom@tromey.com>
3605
3606         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3607         (lookup_partial_symbol, print_partial_symbols)
3608         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3609         (psymbol_compare): Update.
3610         (add_psymbol_to_bcache): Clear the entire psymbol.
3611         (maintenance_check_psymtabs): Update.
3612         * psympriv.h (struct partial_symbol): Don't derive from
3613         general_symbol_info.
3614         <obj_section, unrelocated_address, address,
3615         set_unrelocated_address>: Update.
3616         <ginfo>: New member.
3617         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3618         (debug_names::write_psymbols): Update.
3619
3620 2019-05-04  Tom de Vries  <tdevries@suse.de>
3621
3622         * contrib/cc-with-tweaks.sh: Support -n arg.
3623
3624 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3625
3626         * corelow.c (core_target::detach): Ensure frame cache and
3627         register caches are cleared.
3628         inferior.c (exit_inferior_1): Likewise.
3629
3630 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3631             Tom Tromey  <tom@tromey.com>
3632
3633         * dictionary.c (collate_pending_symbols_by_language): Remove
3634         "struct" from foreach.
3635         * symtab.c (lookup_global_symbol_from_objfile)
3636         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3637         foreach.
3638         * ser-tcp.c (net_open): Remove "struct" from foreach.
3639         * objfiles.c (objfile_relocate, objfile_rebase)
3640         (objfile_has_symbols): Remove "struct" from foreach.
3641         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3642         from foreach.
3643         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3644         foreach.
3645         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3646         "struct" from foreach.
3647         * ada-lang.c (create_excep_cond_exprs)
3648         (ada_exception_catchpoint_cond_string): Remove "struct" from
3649         foreach.
3650
3651 2019-05-03  Tom Tromey  <tromey@adacore.com>
3652
3653         * ada-exp.y (convert_char_literal): Check suffix of each
3654         enumerator.
3655
3656 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3657
3658         PR ada/21406:
3659         * ada-exp.y (yywrap): Don't define.
3660         * ada-lex.l (%option): Add noyywrap
3661         (yywrap): Remove.
3662
3663 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3664
3665         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3666         _WIN32_WINNT to the XP level, unless already defined to a higher
3667         level.
3668
3669         * unittests/parse-connection-spec-selftests.c:
3670         * ser-tcp.c:
3671         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3672         override.
3673
3674         * symfile.c (find_separate_debug_file): Remove colon from the
3675         drive spec of DOS/Windows file names of the target, so that the
3676         file name produced from DEBUGDIR and the target's directory will
3677         be valid on DOS/Windows systems.
3678
3679 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3680
3681         * rust-lang.c (val_print_struct): Handle printing structures
3682         containing strings.
3683
3684 2019-05-02  Tom Tromey  <tromey@adacore.com>
3685
3686         * valarith.c (_initialize_valarith): Remove.
3687
3688 2019-05-01  Tom Tromey  <tromey@adacore.com>
3689
3690         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3691         bitfields.
3692
3693 2019-05-01  Tom Tromey  <tromey@adacore.com>
3694
3695         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3696         for big-endian copies.
3697
3698 2019-04-30  Ali Tamur  <tamur@google.com>
3699         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3700         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3701         (read_3_bytes): New function.
3702
3703 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3704
3705         * windows-nat.c (main_thread_id): Delete.
3706         (handle_output_debug_string): Replace main_thread_id by
3707         current_event.dwThreadId.
3708         (fake_create_process): Likewise.
3709         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3710         Do not set main_thread_id.
3711         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3712         current_event.dwThreadId.
3713         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3714
3715 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3716
3717         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3718         Use current_event.dwThreadId instead of main_thread_id.
3719
3720 2019-04-30  Tom Tromey  <tromey@adacore.com>
3721
3722         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3723         (create_excep_cond_exprs): Iterate over program spaces.
3724         (ada_exception_catchpoint_cond_string): Examine all minimal
3725         symbols for exception types.
3726
3727 2019-04-30  Tom Tromey  <tromey@adacore.com>
3728
3729         PR c++/24470:
3730         * dwarf2read.c (process_structure_scope): Handle case where type
3731         has template parameters but no symbol was created.
3732
3733 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3734             Chris January  <chris.january@arm.com>
3735
3736         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3737         qualifier.
3738         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3739
3740 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3741
3742         * f-typeprint.c (f_print_type): Update rules for printing
3743         whitespace.
3744         (f_type_print_varspec_suffix): Likewise.
3745
3746 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3747             Chris January  <chris.january@arm.com>
3748
3749         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3750         function arguments.
3751
3752 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * f-lang.c (build_fortran_types): Change name of void type to
3755         lower case.
3756         * f-typeprint.c (f_type_print_base): Print the name of the void
3757         type, rather than a fixed string.
3758         * f-valprint.c (f_decorations): Use lower case void string.
3759
3760 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3761             Chris January  <chris.january@arm.com>
3762
3763         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3764         types for Fortran.
3765
3766 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3767             Chris January  <chris.january@arm.com>
3768             David Lecomber  <david.lecomber@arm.com>
3769
3770         * f-exp.y (BINOP_INTRINSIC): New token.
3771         (exp): New parser rule handling BINOP_INTRINSIC.
3772         (f77_keywords): Add new builtin procedures.
3773         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3774         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3775         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3776         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3777         (print_unop_subexp_f): New function.
3778         (print_binop_subexp_f): New function.
3779         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3780         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3781         (dump_subexp_body_f): Likewise.
3782         (operator_check_f): Likewise.
3783         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3784         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3785
3786 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3789         UNOP_KIND.
3790         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3791         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3792         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3793         (operator_length_f): New fuction.
3794         (print_subexp_f): New function.
3795         (op_name_f): New function.
3796         (dump_subexp_body_f): New function.
3797         (operator_check_f): New function.
3798         (exp_descriptor_f): Replace standard expression handling functions
3799         with new functions.
3800         * gdb/fortran-operator.def: New file.
3801         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3802         * gdb/std-operator.def: Remove UNOP_KIND.
3803
3804 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * std-operator.def: Remove unbalanced, stray double quote
3807         character.
3808
3809 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3810             Chris January  <chris.january@arm.com>
3811             Daniel Everett  <daniel.everett@arm.com>
3812             Nick Forrington  <nick.forrington@arm.com>
3813             Richard Bunt  <richard.bunt@arm.com>
3814
3815         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3816         of depth when printing anonymous structs or unions.
3817         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3818         Don't print either the top-level value, or the children if the
3819         max-depth is exceeded.
3820         (ppscm_print_children): When printing the key of a map, allow one
3821         extra level of depth.
3822         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3823         print either the top-level value, or the children if the max-depth
3824         is exceeded.
3825         (print_children): When printing the key of a map, allow one extra
3826         level of depth.
3827         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3828         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3829         (user_print_options): Initialise max_depth field.
3830         (val_print_scalar_or_string_type_p): New function.
3831         (val_print): Check to see if the max depth has been reached.
3832         (val_print_check_max_depth): Define new function.
3833         (show_print_max_depth): New function.
3834         (_initialize_valprint): Add 'print max-depth' option.
3835         * valprint.h (struct value_print_options) <max_depth>: New field.
3836         (val_print_check_max_depth): Declare new function.
3837         * NEWS: Document new feature.
3838
3839 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * ada-lang.c (ada_language_defn): Initialise new field.
3842         * c-lang.c (c_is_string_type_p): New function.
3843         (c_language_defn): Initialise new field.
3844         (cplus_language_defn): Initialise new field.
3845         (asm_language_defn): Initialise new field.
3846         (minimal_language_defn): Initialise new field.
3847         * c-lang.h (c_is_string_type_p): Declare new function.
3848         * d-lang.c (d_language_defn): Initialise new field.
3849         * f-lang.c (f_is_string_type_p): New function.
3850         (f_language_defn): Initialise new field.
3851         * go-lang.c (go_is_string_type_p): New function.
3852         (go_language_defn): Initialise new field.
3853         * language.c (default_is_string_type_p): New function.
3854         (unknown_language_defn): Initialise new field.
3855         (auto_language_defn): Initialise new field.
3856         * language.h (struct language_defn) <la_is_string_type_p>: New
3857         member variable.
3858         (default_is_string_type_p): Declare new function.
3859         * m2-lang.c (m2_language_defn): Initialise new field.
3860         * objc-lang.c (objc_language_defn): Initialise new field.
3861         * opencl-lang.c (opencl_language_defn): Initialise new field.
3862         * p-lang.c (pascal_is_string_type_p): New function.
3863         (pascal_language_defn): Initialise new field.
3864         * rust-lang.c (rust_is_string_type_p): New function.
3865         (rust_language_defn): Initialise new field.
3866
3867 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3870         New field.
3871         * ada-lang.c (ada_language_defn): Initialise new field.
3872         * c-lang.c (c_language_defn): Likewise.
3873         (cplus_language_defn): Likewise.
3874         (asm_language_defn): Likewise.
3875         (minimal_language_defn): Likewise.
3876         * d-lang.c (d_language_defn): Likewise.
3877         * f-lang.c (f_language_defn): Likewise.
3878         * go-lang.c (go_language_defn): Likewise.
3879         * language.c (unknown_language_defn): Likewise.
3880         (auto_language_defn): Likewise.
3881         * m2-lang.c (m2_language_defn): Likewise.
3882         * objc-lang.c (objc_language_defn): Likewise.
3883         * opencl-lang.c (opencl_language_defn): Likewise.
3884         * p-lang.c (pascal_language_defn): Likewise.
3885         * rust-lang.c (rust_language_defn): Likewise.
3886
3887 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * ada-lang.c (ada_is_character_type): Change return type to bool.
3890         (ada_is_string_type): Likewise.
3891         * ada-lang.h (ada_is_character_type): Update declaration
3892         (ada_is_string_type): Likewise.
3893
3894 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3895
3896         Support style in 'frame|thread apply'
3897
3898         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3899         * record.c (record_start, record_stop): Update callers of
3900         execute_command_to_string with false.
3901         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3902         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3903         methods.
3904         (class string_file): New constructor with term_out parameter.
3905         Override methods term_out and can_emit_style_escape.  New member
3906         term_out.
3907         (class stdio_file): Override can_emit_style_escape.
3908         (class tee_file): Override term_out and can_emit_style_escape.
3909         * utils.h (can_emit_style_escape): Remove.
3910         * utils.c (can_emit_style_escape): Likewise.
3911         Update all callers of can_emit_style_escape (SOMESTREAM) to
3912         SOMESTREAM->can_emit_style_escape.
3913         * source-cache.c (source_cache::get_source_lines): Likewise.
3914         * stack.c (frame_apply_command_count): Call execute_command_to_string
3915         passing the term_out characteristic of the current gdb_stdout.
3916         * thread.c (thr_try_catch_cmd): Likewise.
3917         * top.c (execute_command_to_string): pass term_out parameter
3918         to construct the string_file for the command output.
3919         * ui-file.c (term_cli_styling): New function (most code moved
3920         from utils.c can_emit_style_escape).
3921         (string_file::string_file, string_file::can_emit_style_escape,
3922         stdio_file::can_emit_style_escape, tee_file::term_out,
3923         tee_file::can_emit_style_escape): New functions.
3924
3925 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3926
3927         * NEWS: Mention the new set|show may-call-functions.
3928         * infcall.c (may_call_functions_p): New variable.
3929         (show_may_call_functions_p): New function.
3930         (call_function_by_hand_dummy): Throws an error if not
3931         may-call-functions.
3932         (_initialize_infcall): Call add_setshow_boolean_cmd for
3933         may-call-functions.
3934
3935 2019-04-25  Keith Seitz  <keiths@redhat.com>
3936
3937         PR c++/24367
3938         * cp-support.c (inspect_type): Don't attempt substitutions
3939         of symbol with the same name.
3940
3941 2019-04-25  Tom Tromey  <tromey@adacore.com>
3942
3943         PR gdb/24475:
3944         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3945         static.
3946
3947 2019-04-25  Tom Tromey  <tromey@adacore.com>
3948
3949         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3950         rvalue reference.
3951         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3952         (gdb_xml_parser::parse): Use std::move.
3953         * python/python-internal.h (gdbpy_convert_exception): Take a const
3954         reference.
3955         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3956         std::move.
3957         * python/py-utils.c (gdbpy_convert_exception): Take a const
3958         reference.
3959         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3960         Use std::move.
3961         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3962         Use std::move.
3963         * mi/mi-main.c (mi_print_exception): Take a const reference.
3964         * main.c (handle_command_errors): Take a const reference.
3965         * linespec.c (parse_linespec): Use std::move.
3966         * infcall.c (run_inferior_call): Use std::move.
3967         (call_function_by_hand_dummy): Use std::move.
3968         * exec.c (try_open_exec_file): Use std::move.
3969         * exceptions.h (exception_print, exception_fprintf)
3970         (exception_print_same): Update.
3971         * exceptions.c (print_exception, exception_print)
3972         (exception_fprintf, exception_print_same): Change parameters to
3973         const reference.
3974         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3975         * common/new-op.c: Use std::move.
3976         * common/common-exceptions.h (struct gdb_exception): Add move
3977         constructor.
3978         (struct gdb_exception_error, struct gdb_exception_quit, struct
3979         gdb_quit_bad_alloc): Change constructor to move constructor.
3980         (throw_exception): Change parameter to rvalue reference.
3981         * common/common-exceptions.c (throw_exception): Take rvalue
3982         reference.
3983         * cli/cli-interp.c (safe_execute_command): Use std::move.
3984         * breakpoint.c (insert_bp_location, location_to_sals): Use
3985         std::move.
3986
3987 2019-04-25  Tom Tromey  <tromey@adacore.com>
3988
3989         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3990         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3991         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3992         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3993         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3994         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3995         guile/scm-value.c: Use unpack.
3996         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3997         gdbscm_gdb_exception.
3998         (gdbscm_throw_gdb_exception): Likewise.
3999         (struct gdbscm_gdb_exception): New.
4000         (unpack): New function.
4001         (gdbscm_wrap): Use unpack.
4002
4003 2019-04-25  Tom Tromey  <tromey@adacore.com>
4004
4005         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4006         (gdb_rl_callback_handler): Use std::move.
4007         * common/common-exceptions.h (struct gdb_exception): Add move
4008         assignment operator.
4009         (throw_exception_sjlj): Change "exception" to const reference.
4010         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4011         (throw_exception_sjlj): Change "exception" to const reference.
4012
4013 2019-04-25  Tom Tromey  <tromey@adacore.com>
4014
4015         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4016         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4017         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4018         Update.
4019         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4020         Update.
4021         * mi/mi-interp.c (mi_interp::exec): Update.
4022         * linespec.c (parse_linespec): Update.
4023         * infcall.c (run_inferior_call): Update.
4024         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4025         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4026         (gdbscm_lookup_global_symbol): Update.
4027         * guile/scm-param.c (gdbscm_parameter_value): Update.
4028         * guile/scm-frame.c (gdbscm_frame_read_register)
4029         (gdbscm_frame_read_var): Update.
4030         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4031         * exec.c (try_open_exec_file): Update.
4032         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4033         (gdb_rl_callback_handler): Update.
4034         * common/common-exceptions.h (exception_none): Don't declare.
4035         * common/common-exceptions.c (exception_none): Don't define.
4036         (struct catcher) <exception>: Update.
4037         * cli/cli-interp.c (safe_execute_command): Update.
4038         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4039
4040 2019-04-25  Ali Tamur  <tamur@google.com>
4041
4042         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4043         (read_attribute_value): Likewise.
4044         (dwarf2_read_addr_index): Update comment.
4045         (read_str_index): Add DW_FORM_strx.
4046         (dwarf2_string_attr): Likewise.
4047         (dwarf2_const_value_attr): Likewise.
4048         (dump_die_shallow): Likewise.
4049         (dwarf2_fetch_constant_bytes): Likewise.
4050         (skip_form_bytes): Likewise.
4051         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4052
4053 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4054
4055         PR corefiles/11608
4056         PR corefiles/18187
4057         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4058         OFFSET.  Verify if current mapping contains an ELF header.
4059         (linux_find_memory_regions_full): Adjust call to
4060         dump_mapping_p.
4061
4062 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4063             Kang Li <kanglictf@gmail.com>
4064
4065         PR gdb/21600
4066
4067         * dwarf2-frame.c (read_initial_length): Be consistent about using
4068         unsigned representation of length.
4069         (decode_frame_entry_1): Likewise.  Check for wraparound of
4070         end pointer as well as buffer overflow.
4071
4072 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4073
4074         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4075         "vq".
4076
4077 2019-04-24  Tom Tromey  <tromey@adacore.com>
4078
4079         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4080
4081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * s12z-tdep.c (s12z_unwind_pc): Delete.
4084         (s12z_unwind_sp): Delete.
4085         (s12z_gdbarch_init): Don't register deleted functions with
4086         gdbarch.
4087
4088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4089
4090         * rl78-tdep.c (rl78_unwind_sp): Delete.
4091         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4092
4093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4096         (xstormy16_unwind_pc): Delete.
4097         (xstormy16_dummy_id): Delete.
4098         (xstormy16_gdbarch_init): Don't register deleted functions with
4099         gdbarch.
4100
4101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4102
4103         * vax-tdep.c (vax_unwind_pc): Delete.
4104         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4105
4106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * v850-tdep.c (v850_unwind_sp): Delete.
4109         (v850_unwind_pc): Delete.
4110         (v850_dummy_id): Delete.
4111         (v850_gdbarch_init): Don't register deleted functions with
4112         gdbarch.
4113
4114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4115
4116         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4117         (tilegx_unwind_pc): Delete.
4118         (tilegx_unwind_dummy_id): Delete.
4119         (tilegx_gdbarch_init): Don't register deleted functions with
4120         gdbarch.
4121
4122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4123
4124         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4125         (tic6x_dummy_id): Delete.
4126         (tic6x_gdbarch_init): Don't register deleted functions with
4127         gdbarch.
4128
4129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * sparc-tdep.c (sparc_unwind_pc): Delete.
4132         (sparc32_gdbarch_init): Don't register deleted function with
4133         gdbarch.
4134
4135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * sh-tdep.c (sh_unwind_sp): Delete.
4138         (sh_unwind_pc): Delete.
4139         (sh_dummy_id): Delete.
4140         (sh_gdbarch_init): Don't register deleted functions with
4141         gdbarch.
4142
4143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * score-tdep.c (score_unwind_sp): Delete.
4146         (score_unwind_pc): Delete.
4147         (score_dummy_id): Delete.
4148         (score_gdbarch_init): Don't register deleted functions with
4149         gdbarch.
4150
4151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4152
4153         * rx-tdep.c (rx_unwind_pc): Delete.
4154         (rx_unwind_sp): Delete.
4155         (rx_dummy_id): Delete.
4156         (rx_gdbarch_init): Don't register deleted functions with
4157         gdbarch.  Update comment.
4158
4159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4160
4161         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4162         (rs6000_dummy_id): Delete.
4163         (rs6000_gdbarch_init): Don't register deleted functions with
4164         gdbarch.
4165
4166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * or1k-tdep.c (or1k_dummy_id): Delete.
4169         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4170
4171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         * nios2-tdep.c (nios2_dummy_id): Delete.
4174         (nios2_unwind_sp): Delete.
4175         (nios2_gdbarch_init): Don't register deleted functions with
4176         gdbarch.
4177
4178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * nds32-tdep.c (nds32_dummy_id): Delete.
4181         (nds32_unwind_pc): Delete.
4182         (nds32_unwind_sp): Delete.
4183         (nds32_gdbarch_init): Don't register deleted functions with
4184         gdbarch.
4185
4186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * msp430-tdep.c (msp430_unwind_pc): Delete.
4189         (msp430_unwind_sp): Delete.
4190         (msp430_dummy_id): Delete.
4191         (msp430_gdbarch_init): Don't register deleted functions with
4192         gdbarch.
4193
4194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * moxie-tdep.c (moxie_unwind_sp): Delete.
4197         (moxie_unwind_pc): Delete.
4198         (moxie_dummy_id): Delete.
4199         (moxie_gdbarch_init): Don't register deleted functions with
4200         gdbarch.
4201
4202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4205         (mn10300_unwind_pc): Delete.
4206         (mn10300_unwind_sp): Delete.
4207         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4208         mn10300_unwind_sp.
4209         (mn10300_frame_unwind_init): Don't register deleted functions with
4210         gdbarch.
4211
4212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4213
4214         * mep-tdep.c (mep_unwind_pc): Delete.
4215         (mep_unwind_sp): Delete.
4216         (mep_dummy_id): Delete.
4217         (mep_gdbarch_init): Don't register deleted functions with
4218         gdbarch.
4219
4220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4223         (m68hc11_unwind_sp): Delete.
4224         (m68hc11_gdbarch_init): Don't register deleted functions with
4225         gdbarch.
4226
4227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * m32r-tdep.c (m32r_unwind_sp): Delete.
4230         (m32r_unwind_pc): Delete.
4231         (m32r_dummy_id): Delete.
4232         (m32r_gdbarch_init): Don't register deleted functions with
4233         gdbarch.
4234
4235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4236
4237         * m32c-tdep.c (m32c_unwind_pc): Delete.
4238         (m32c_unwind_sp): Delete.
4239         (m32c_dummy_id): Delete.
4240         (m32c_gdbarch_init): Don't register deleted functions with
4241         gdbarch.
4242
4243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4246         (lm32_unwind_pc): Delete.
4247         (lm32_dummy_id): Delete.
4248         (lm32_gdbarch_init): Don't register deleted functions with
4249         gdbarch.
4250
4251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4254         (iq2000_unwind_pc): Delete.
4255         (iq2000_dummy_id): Delete.
4256         (iq2000_gdbarch_init): Don't register deleted functions with
4257         gdbarch.
4258
4259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * nds32-tdep.c (nds32_type_align): Delete.
4262         (nds32_push_dummy_call): Use type_align instead.
4263
4264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * arm-tdep.c (arm_type_align): Only handle vector override case.
4267         (arm_push_dummy_call): Use type_align.
4268         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4269
4270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4273         case.
4274         (pass_on_stack): Use type_align.
4275         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4276         function.
4277
4278 2019-04-23  Tom Tromey  <tromey@adacore.com>
4279
4280         * dwarf2read.c (line_header::file_name_at): Remove unused
4281         overload.
4282
4283 2019-04-23  Tom de Vries  <tdevries@suse.de>
4284
4285         PR gdb/24438
4286         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4287         invocation.
4288
4289
4290 2019-03-27  Ali Tamur  <tamur@google.com>
4291
4292         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4293         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4294         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4295         (dwarf_expr_context::get_addr_index): Likewise
4296         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4297         (symbol_needs_eval_context::get_addr_index): Likewise
4298         (disassemble_dwarf_expression): Add DW_OP_addrx
4299         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4300         (read_cutu_die_from_dwo): Update comment
4301         (skip_one_die): Add DW_FORM_addrx
4302         (read_attribute_value): Likewise
4303         (var_decode_location): Add DW_OP_addrx
4304         (dwarf2_const_value_attr): Add DW_FORM_addrx
4305         (dump_die_shallow): Likewise
4306         (dwarf2_fetch_constant_bytes): Likewise
4307         (decode_locdesc): Add DW_OP_addrx
4308         (skip_form_bytes): Add DW_FORM_addrx
4309
4310 2019-04-22  Ali Tamur  <tamur@google.com>
4311
4312         * MAINTAINERS (Write After Approval): Add self.
4313
4314 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4315
4316         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4317         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4318         (open_symbol_file_object): Likewise.
4319         (svr4_default_sos): Add info parameter.
4320         (svr4_read_so_list): Likewise.
4321         (svr4_current_sos_direct): Adjust functions calls to pass down
4322         info.
4323         (svr4_current_sos_1): Add info parameter.
4324         (svr4_current_sos): Call get_svr4_info, pass info down to
4325         svr4_current_sos_1.
4326         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4327         get_svr4_info.
4328         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4329         get_svr4_info.
4330         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4331         to get_svr4_info.
4332         (probes_table_remove_objfile_probes): Likewise.
4333         (register_solib_event_probe): Add info parameter.
4334         (solist_update_incremental): Pass info parameter down to
4335         svr4_read_so_list.
4336         (disable_probes_interface): Add info parameter.
4337         (svr4_handle_solib_event): Pass current_program_space to
4338         get_svr4_info.  Adjust disable_probes_interface cleanup.
4339         (svr4_create_probe_breakpoints): Add info parameter, pass it
4340         down to register_solib_event_probe.
4341         (svr4_create_solib_event_breakpoints): Add info parameter,
4342         pass it down to svr4_create_probe_breakpoints.
4343         (enable_break): Pass info down to
4344         svr4_create_solib_event_breakpoints.
4345         (svr4_solib_create_inferior_hook): Pass current_program_space to
4346         get_svr4_info.
4347         (svr4_clear_solib): Likewise.
4348
4349 2019-04-22  Pedro Alves  <palves@redhat.com>
4350
4351         * solib-svr4.c (svr4_free_objfile_observer): New.
4352         (probe_and_action::objfile): New field.
4353         (probes_table_htab_remove_objfile_probes)
4354         (probes_table_remove_objfile_probes): New functions.
4355         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4356         in the new probe_and_action.  Don't store the probe in 'lookup'.
4357         (svr4_create_probe_breakpoints): Pass objfile to
4358         register_solib_event_probe.
4359         (_initialize_svr4_solib): Register a free_objfile observer.
4360
4361 2019-04-19  Tom Tromey  <tom@tromey.com>
4362
4363         * common/queue.h: Remove.
4364
4365 2019-04-19  Tom Tromey  <tom@tromey.com>
4366
4367         * event-loop.c: Don't include "common/queue.h".
4368
4369 2019-04-19  Tom Tromey  <tom@tromey.com>
4370
4371         * remote.c (remote_target): Use delete.
4372         * remote-notif.h: Include <list>, not "common/queue.h".
4373         (notif_client_p): Remove typedef.
4374         (remote_notif_state): Add constructor, destructor, initializer.
4375         <notif_queue>: Now a std::list.
4376         (remote_notif_state_xfree): Don't declare.
4377         * remote-notif.c (remote_notif_process, handle_notification)
4378         (remote_notif_state_allocate): Update.
4379         (~remote_notif_state): Rename from remote_notif_state_xfree.
4380
4381 2019-04-19  Tom Tromey  <tom@tromey.com>
4382
4383         * symfile.c (reread_symbols): Update.
4384         * objfiles.c (objfile_register_static_link)
4385         (objfile_lookup_static_link): Update
4386         (~objfile) Don't delete static_links.
4387         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4388
4389 2019-04-19  Tom Tromey  <tom@tromey.com>
4390
4391         * type-stack.h (struct type_stack) <insert>: Constify string.
4392         * type-stack.c (type_stack::insert): Constify string.
4393         * gdbtypes.h (lookup_template_type): Update.
4394         (address_space_name_to_int): Update.
4395         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4396         const.
4397         (lookup_template_type): Make name const.
4398         * c-exp.y: Update rules.
4399         (lex_one_token, classify_name, classify_inner_name)
4400         (c_print_token): Update.
4401         * p-exp.y: Update rules.
4402         (yylex): Update.
4403         * f-exp.y: Update rules.
4404         (yylex): Update.
4405         * d-exp.y: Update rules.
4406         (lex_one_token, classify_name, classify_inner_name): Update.
4407         * parse.c (write_dollar_variable, copy_name): Return std::string.
4408         * parser-defs.h (copy_name): Change return type.
4409         * m2-exp.y: Update rules.
4410         (yylex): Update.
4411         * go-exp.y (lex_one_token): Update.
4412         Update rules.
4413         (classify_unsafe_function, classify_packaged_name)
4414         (classify_name, yylex): Update.
4415
4416 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4417
4418         * configure.ac: add --enable-source-highlight switch.
4419         * configure: Regenerate.
4420         * top.c (print_gdb_version): plumb --enable-source-highlight
4421         status to "show configuration".
4422
4423 2019-04-19  Tom Tromey  <tromey@adacore.com>
4424
4425         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4426         Check ADA_TYPE_P.
4427         (empty_record, ada_template_to_fixed_record_type_1)
4428         (template_to_static_fixed_type)
4429         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4430         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4431         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4432         macros.
4433
4434 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4435
4436         PR symtab/24423:
4437         * source.c (print_source_lines_base): Advance "iter" when a
4438         control character is seen.
4439
4440 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4441
4442         * inferior.h (struct infcall_suspend_state_deleter):
4443         Catch exception in destructor to avoid crash.
4444
4445 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4446
4447         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4448         close to the add_com "shell".
4449
4450 2019-04-18  Tom Tromey  <tromey@adacore.com>
4451
4452         * process-stratum-target.h (class process_stratum_target)
4453         <stratum>: Add "final".
4454
4455 2019-04-17  Tom Tromey  <tromey@adacore.com>
4456
4457         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4458         against nullptr before use.
4459
4460 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4461
4462         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4463
4464 2019-04-17  Jim Wilson  <jimw@sifive.com>
4465             Andrew Burgess  <andrew.burgess@embecosm.com>
4466
4467         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4468         code read might fail, assume 4-byte breakpoint in that case.
4469
4470 2019-04-15  Leszek Swirski  <leszeks@google.com>
4471
4472         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4473         rather than a hand-rolled POD check when checking for forced MEMORY
4474         classification.
4475
4476 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4477
4478         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4479         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4480         function.
4481         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4482         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4483         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4484         declaration.
4485
4486 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * aarch64-linux-nat.c
4489         (aarch64_linux_nat_target::thread_architecture): Add override.
4490         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4491         each VQ.
4492
4493 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4494
4495         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4496
4497 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4500         target types of size 96-bits, add some additional comments, and
4501         check that the builtin type we found was the correct size.
4502
4503 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4504
4505         * utils.c (prompt_for_continue): Don't restore the styling at the
4506         end, as applied_style has the wrong value.  This fixes styling in
4507         long lists of file names that are interrupted by the "Continue?"
4508         prompt.
4509
4510 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4513         * c-lang.c (c_language_defn): Likewise.
4514         (cplus_language_defn): Likewise.
4515         (asm_language_defn): Likewise.
4516         (minimal_language_defn): Likewise.
4517         * d-lang.c (d_language_defn): Likewise.
4518         * f-lang.c (f_language_defn): Likewise.
4519         * go-lang.c (go_language_defn): Likewise.
4520         * language.c (unknown_language_defn): Likewise.
4521         (auto_language_defn): Likewise.
4522         * language.h (struct language_defn): Remove la_magic field.
4523         (LANG_MAGIC): Delete.
4524         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4525         * objc-lang.c (objc_language_defn): Likewise.
4526         * opencl-lang.c (opencl_language_defn): Likewise.
4527         * p-lang.c (pascal_language_defn): Likewise.
4528         * rust-lang.c (rust_language_defn): Likewise.
4529
4530 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4531
4532         * riscv-tdep.c (riscv_type_align): New function.
4533         (riscv_type_alignment): Delete.
4534         (riscv_arg_location): Use 'type_align'.
4535         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4536
4537 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4538
4539         * gdbtypes.c (type_align): A struct with no non-static fields also
4540         has alignment of 1.
4541
4542 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4545         component to 0.
4546         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4547         member.
4548         (riscv_struct_info::analyse): New implementation using new
4549         analyse_inner member function.
4550         (riscv_struct_info::field_offset): New member function.
4551         (riscv_struct_info::m_offsets): New member variable.
4552         (riscv_struct_info::analyse_inner): New private member function,
4553         takes the old implementation of riscv_struct_info::analyse but
4554         extended to track field offsets.
4555         (riscv_call_arg_struct): Update the struct folding special cases
4556         to handle cases where empty C++ structs, which are non-zero
4557         length, are found.
4558         (riscv_arg_location): Initialise the length of each location, a
4559         non-zero length now indicates the location is in use.
4560         (riscv_push_dummy_call): Allow for the first location having a
4561         non-zero offset when setting up arguments.
4562         (riscv_return_value): Likewise, but for return values.
4563
4564 2019-04-11  Tom Tromey  <tromey@adacore.com>
4565
4566         * utils.c (internal_vproblem): Make "msg" const.
4567
4568 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4569
4570         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4571         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4572         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4573         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4574
4575 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4576
4577         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4578         function.
4579         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4580         of amd64_collect_native_gregset.
4581         (amd64_linux_nat_target::store_registers): Likewise.
4582
4583 2019-04-10  Tom Tromey  <tom@tromey.com>
4584
4585         * symtab.c (lookup_global_symbol_from_objfile)
4586         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4587         * objfiles.h (class separate_debug_iterator): New.
4588         (class separate_debug_range): New.
4589         (struct objfile) <separate_debug_objfiles>: New method.
4590         (objfile_separate_debug_iterate): Don't declare.
4591         * objfiles.c (separate_debug_iterator::operator++): Rename from
4592         objfile_separate_debug_iterate.
4593         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4594         iterator.
4595         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4596         iterator.
4597
4598 2019-04-10  Tom Tromey  <tom@tromey.com>
4599
4600         * symfile.c (reread_symbols): Remove old comment.
4601         * objfiles.c (free_all_objfiles): Fix a typo.
4602
4603 2019-04-10  Tom Tromey  <tom@tromey.com>
4604
4605         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4606         * minsyms.c (lookup_minimal_symbol): Use foreach.
4607         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4608         (lookup_minimal_symbol_solib_trampoline): Likewise.
4609         * symfile.c (reread_symbols): Use foreach.
4610
4611 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4612             Tom Tromey  <tromey@adacore.com>
4613
4614         PR rust/24414:
4615         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4616         (rust_lex_int_test): Change "value" to be LONGEST.
4617         (rust_lex_tests): Add test for long integer literal.
4618
4619 2019-04-09  Tom Tromey  <tromey@adacore.com>
4620
4621         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4622         to bool.
4623         (extended_remote_target::attach): Update.
4624         (remote_target::remote_notice_new_inferior): Update.
4625         (remote_target::add_current_inferior_and_thread): Update.
4626         * inferior.c (exit_inferior_1): Use "false".
4627         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4628
4629 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4630
4631         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4632         the "start" command.
4633
4634 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4635
4636         * python/py-inferior.c (infpy_thread_from_thread_handle):
4637         Adjust comments to reflect renaming of thread_from_thread_handle
4638         to thread_from_handle.  Adjust keywords.  Fix type error message.
4639         (inferior_object_methods): Add thread_from_handle.  Retain
4640         thread_from_thread_handle, but mark it as deprecated.
4641
4642 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4643
4644         * gdbthread.h (find_thread_by_handle): Revise declaration.
4645         * thread.c (find_thread_by_handle): Likewise.  Adjust
4646         implementation too.
4647         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4648         support for buffer objects as handles.
4649
4650 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4651
4652         * python/py-infthread.c (thpy_thread_handle): New function.
4653         (thread_object_methods): Register thpy_thread_handle.
4654
4655 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4656
4657         * gdbthread.h (thread_to_thread_handle): Declare.
4658         * thread.c (gdbtypes.h): Include.
4659         (thread_to_thread_handle): New function.
4660
4661         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4662         (target_thread_info_to_thread_handle): Declare.
4663         * target.c (target_thread_info_to_thread_handle): New function.
4664         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4665         * target-delegates.c: Regenerate.
4666
4667         * linux-thread-db.c (class thread_db_target): Add method
4668         thread_info_to_thread_handle.
4669         (thread_db_target::thread_info_to_thread_handle): Define.
4670         * remote.c (class remote_target): Add new method
4671         thread_info_to_thread_handle.
4672         (remote_target::thread_info_to_thread_handle): Define.
4673
4674 2019-04-08  Pedro Alves  <palves@redhat.com>
4675
4676         * common/common-exceptions.c (throw_exception): Don't create
4677         named object to throw; throw directly.
4678         (throw_it): Likewise.  Don't initialize gdb_exception::message
4679         here, with new; pass FMT and AP to the ctor instead.
4680         * common/common-exceptions.h: Include <string>.
4681         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4682         const char *, va_list)): New ctor.  Use std::make_shared.
4683         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4684         errors)): Delete.
4685         (gdb_exception_error::gdb_exception_error(enum errors, const char
4686         *, va_list)): New.
4687         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4688         Add assertion.
4689         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4690         errors)): Delete.
4691         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4692         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4693         Add assertion.
4694
4695 2019-04-08  Tom Tromey  <tom@tromey.com>
4696
4697         * valops.c (value_rtti_indirect_type): Replace throw_exception
4698         with throw.
4699         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4700         with throw.
4701         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4702         throw.
4703         * target.c (target_translate_tls_address): Replace throw_exception
4704         with throw.
4705         * stack.c (frame_apply_command_count): Replace throw_exception
4706         with throw.
4707         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4708         throw.
4709         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4710         with throw.
4711         * rs6000-tdep.c (rs6000_frame_cache)
4712         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4713         * remote.c: Replace throw_exception with throw.
4714         * record-full.c (record_full_message, record_full_wait_1)
4715         (record_full_restore): Replace throw_exception with throw.
4716         * record-btrace.c:
4717         (get_thread_current_frame_id, record_btrace_start_replaying)
4718         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4719         (cmd_record_btrace_start): Replace throw_exception with throw.
4720         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4721         throw.
4722         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4723         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4724         * linespec.c:
4725         (find_linespec_symbols): Replace throw_exception with throw.
4726         * infrun.c (displaced_step_prepare, resume): Replace
4727         throw_exception with throw.
4728         * infcmd.c (post_create_inferior): Replace throw_exception with
4729         throw.
4730         * inf-loop.c (inferior_event_handler): Replace throw_exception
4731         with throw.
4732         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4733         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4734         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4735         (get_prev_frame_always, get_frame_pc_if_available)
4736         (get_frame_address_in_block_if_available, get_frame_language):
4737         Replace throw_exception with throw.
4738         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4739         throw_exception with throw.
4740         * eval.c (fetch_subexp_value, evaluate_var_value)
4741         (evaluate_funcall, evaluate_subexp_standard): Replace
4742         throw_exception with throw.
4743         * dwarf2loc.c (call_site_find_chain)
4744         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4745         Replace throw_exception with throw.
4746         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4747         with throw.
4748         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4749         throw.
4750         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4751         * completer.c (complete_line_internal): Replace throw_exception
4752         with throw.
4753         * compile/compile-object-run.c (compile_object_run): Replace
4754         throw_exception with throw.
4755         * cli/cli-script.c (process_next_line): Replace throw_exception
4756         with throw.
4757         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4758         (btrace_enable, btrace_maint_update_pt_packets): Replace
4759         throw_exception with throw.
4760         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4761         throw_exception with throw.
4762         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4763         throw_exception with throw.
4764         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4765         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4766         * aarch64-tdep.c (aarch64_make_prologue_cache)
4767         (aarch64_make_stub_cache): Replace throw_exception with throw.
4768
4769 2019-04-08  Tom Tromey  <tom@tromey.com>
4770
4771         * common/common-exceptions.c (throw_exception): Rename from
4772         throw_exception_cxx.  Remove old copy.  Make argument const.
4773         (throw_it): Create and throw exception objects directly.
4774         * common/common-exceptions.h (throw_exception): Make argument
4775         const.
4776         (struct gdb_exception_error): Add constructor.
4777         (struct gdb_exception_quit): Add constructor.
4778
4779 2019-04-08  Tom Tromey  <tom@tromey.com>
4780
4781         * common/common-exceptions.h (exception_rethrow): Don't declare.
4782         (TRY_SJLJ): Update comment.
4783         (TRY, CATCH, END_CATCH): Remove.
4784         * common/common-exceptions.c (exception_rethrow): Remove.
4785
4786 2019-04-08  Tom Tromey  <tom@tromey.com>
4787
4788         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4789         Remove.
4790         (gdb_exception_error): Rename from
4791         gdb_exception_RETURN_MASK_ERROR.
4792         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4793         (gdb_quit_bad_alloc): Update.
4794         * aarch64-tdep.c: Update.
4795         * ada-lang.c: Update.
4796         * ada-typeprint.c: Update.
4797         * ada-valprint.c: Update.
4798         * amd64-tdep.c: Update.
4799         * arch-utils.c: Update.
4800         * break-catch-throw.c: Update.
4801         * breakpoint.c: Update.
4802         * btrace.c: Update.
4803         * c-varobj.c: Update.
4804         * cli/cli-cmds.c: Update.
4805         * cli/cli-interp.c: Update.
4806         * cli/cli-script.c: Update.
4807         * common/common-exceptions.c: Update.
4808         * common/new-op.c: Update.
4809         * common/selftest.c: Update.
4810         * compile/compile-c-symbols.c: Update.
4811         * compile/compile-cplus-symbols.c: Update.
4812         * compile/compile-object-load.c: Update.
4813         * compile/compile-object-run.c: Update.
4814         * completer.c: Update.
4815         * corelow.c: Update.
4816         * cp-abi.c: Update.
4817         * cp-support.c: Update.
4818         * cp-valprint.c: Update.
4819         * darwin-nat.c: Update.
4820         * disasm-selftests.c: Update.
4821         * dtrace-probe.c: Update.
4822         * dwarf-index-cache.c: Update.
4823         * dwarf-index-write.c: Update.
4824         * dwarf2-frame-tailcall.c: Update.
4825         * dwarf2-frame.c: Update.
4826         * dwarf2loc.c: Update.
4827         * dwarf2read.c: Update.
4828         * eval.c: Update.
4829         * event-loop.c: Update.
4830         * event-top.c: Update.
4831         * exec.c: Update.
4832         * f-valprint.c: Update.
4833         * fbsd-tdep.c: Update.
4834         * frame-unwind.c: Update.
4835         * frame.c: Update.
4836         * gdbtypes.c: Update.
4837         * gnu-v3-abi.c: Update.
4838         * guile/guile-internal.h: Update.
4839         * guile/scm-block.c: Update.
4840         * guile/scm-breakpoint.c: Update.
4841         * guile/scm-cmd.c: Update.
4842         * guile/scm-disasm.c: Update.
4843         * guile/scm-frame.c: Update.
4844         * guile/scm-lazy-string.c: Update.
4845         * guile/scm-math.c: Update.
4846         * guile/scm-param.c: Update.
4847         * guile/scm-ports.c: Update.
4848         * guile/scm-pretty-print.c: Update.
4849         * guile/scm-symbol.c: Update.
4850         * guile/scm-symtab.c: Update.
4851         * guile/scm-type.c: Update.
4852         * guile/scm-value.c: Update.
4853         * i386-linux-tdep.c: Update.
4854         * i386-tdep.c: Update.
4855         * inf-loop.c: Update.
4856         * infcall.c: Update.
4857         * infcmd.c: Update.
4858         * infrun.c: Update.
4859         * jit.c: Update.
4860         * language.c: Update.
4861         * linespec.c: Update.
4862         * linux-fork.c: Update.
4863         * linux-nat.c: Update.
4864         * linux-tdep.c: Update.
4865         * linux-thread-db.c: Update.
4866         * main.c: Update.
4867         * mi/mi-cmd-break.c: Update.
4868         * mi/mi-cmd-stack.c: Update.
4869         * mi/mi-interp.c: Update.
4870         * mi/mi-main.c: Update.
4871         * objc-lang.c: Update.
4872         * p-valprint.c: Update.
4873         * parse.c: Update.
4874         * ppc-linux-tdep.c: Update.
4875         * printcmd.c: Update.
4876         * python/py-arch.c: Update.
4877         * python/py-breakpoint.c: Update.
4878         * python/py-cmd.c: Update.
4879         * python/py-finishbreakpoint.c: Update.
4880         * python/py-frame.c: Update.
4881         * python/py-framefilter.c: Update.
4882         * python/py-gdb-readline.c: Update.
4883         * python/py-inferior.c: Update.
4884         * python/py-infthread.c: Update.
4885         * python/py-lazy-string.c: Update.
4886         * python/py-linetable.c: Update.
4887         * python/py-objfile.c: Update.
4888         * python/py-param.c: Update.
4889         * python/py-prettyprint.c: Update.
4890         * python/py-progspace.c: Update.
4891         * python/py-record-btrace.c: Update.
4892         * python/py-record.c: Update.
4893         * python/py-symbol.c: Update.
4894         * python/py-type.c: Update.
4895         * python/py-unwind.c: Update.
4896         * python/py-utils.c: Update.
4897         * python/py-value.c: Update.
4898         * python/python.c: Update.
4899         * record-btrace.c: Update.
4900         * record-full.c: Update.
4901         * remote-fileio.c: Update.
4902         * remote.c: Update.
4903         * riscv-tdep.c: Update.
4904         * rs6000-aix-tdep.c: Update.
4905         * rs6000-tdep.c: Update.
4906         * rust-exp.y: Update.
4907         * rust-lang.c: Update.
4908         * s390-tdep.c: Update.
4909         * selftest-arch.c: Update.
4910         * solib-dsbt.c: Update.
4911         * solib-frv.c: Update.
4912         * solib-spu.c: Update.
4913         * solib-svr4.c: Update.
4914         * solib.c: Update.
4915         * sparc64-linux-tdep.c: Update.
4916         * stack.c: Update.
4917         * symfile-mem.c: Update.
4918         * symmisc.c: Update.
4919         * target.c: Update.
4920         * thread.c: Update.
4921         * top.c: Update.
4922         * tracefile-tfile.c: Update.
4923         * tui/tui.c: Update.
4924         * typeprint.c: Update.
4925         * unittests/cli-utils-selftests.c: Update.
4926         * unittests/parse-connection-spec-selftests.c: Update.
4927         * valops.c: Update.
4928         * valprint.c: Update.
4929         * value.c: Update.
4930         * varobj.c: Update.
4931         * windows-nat.c: Update.
4932         * x86-linux-nat.c: Update.
4933         * xml-support.c: Update.
4934
4935 2019-04-08  Tom Tromey  <tom@tromey.com>
4936
4937         * xml-support.c: Use C++ exception handling.
4938         * x86-linux-nat.c: Use C++ exception handling.
4939         * windows-nat.c: Use C++ exception handling.
4940         * varobj.c: Use C++ exception handling.
4941         * value.c: Use C++ exception handling.
4942         * valprint.c: Use C++ exception handling.
4943         * valops.c: Use C++ exception handling.
4944         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4945         handling.
4946         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4947         * typeprint.c: Use C++ exception handling.
4948         * tui/tui.c: Use C++ exception handling.
4949         * tracefile-tfile.c: Use C++ exception handling.
4950         * top.c: Use C++ exception handling.
4951         * thread.c: Use C++ exception handling.
4952         * target.c: Use C++ exception handling.
4953         * symmisc.c: Use C++ exception handling.
4954         * symfile-mem.c: Use C++ exception handling.
4955         * stack.c: Use C++ exception handling.
4956         * sparc64-linux-tdep.c: Use C++ exception handling.
4957         * solib.c: Use C++ exception handling.
4958         * solib-svr4.c: Use C++ exception handling.
4959         * solib-spu.c: Use C++ exception handling.
4960         * solib-frv.c: Use C++ exception handling.
4961         * solib-dsbt.c: Use C++ exception handling.
4962         * selftest-arch.c: Use C++ exception handling.
4963         * s390-tdep.c: Use C++ exception handling.
4964         * rust-lang.c: Use C++ exception handling.
4965         * rust-exp.y: Use C++ exception handling.
4966         * rs6000-tdep.c: Use C++ exception handling.
4967         * rs6000-aix-tdep.c: Use C++ exception handling.
4968         * riscv-tdep.c: Use C++ exception handling.
4969         * remote.c: Use C++ exception handling.
4970         * remote-fileio.c: Use C++ exception handling.
4971         * record-full.c: Use C++ exception handling.
4972         * record-btrace.c: Use C++ exception handling.
4973         * python/python.c: Use C++ exception handling.
4974         * python/py-value.c: Use C++ exception handling.
4975         * python/py-utils.c: Use C++ exception handling.
4976         * python/py-unwind.c: Use C++ exception handling.
4977         * python/py-type.c: Use C++ exception handling.
4978         * python/py-symbol.c: Use C++ exception handling.
4979         * python/py-record.c: Use C++ exception handling.
4980         * python/py-record-btrace.c: Use C++ exception handling.
4981         * python/py-progspace.c: Use C++ exception handling.
4982         * python/py-prettyprint.c: Use C++ exception handling.
4983         * python/py-param.c: Use C++ exception handling.
4984         * python/py-objfile.c: Use C++ exception handling.
4985         * python/py-linetable.c: Use C++ exception handling.
4986         * python/py-lazy-string.c: Use C++ exception handling.
4987         * python/py-infthread.c: Use C++ exception handling.
4988         * python/py-inferior.c: Use C++ exception handling.
4989         * python/py-gdb-readline.c: Use C++ exception handling.
4990         * python/py-framefilter.c: Use C++ exception handling.
4991         * python/py-frame.c: Use C++ exception handling.
4992         * python/py-finishbreakpoint.c: Use C++ exception handling.
4993         * python/py-cmd.c: Use C++ exception handling.
4994         * python/py-breakpoint.c: Use C++ exception handling.
4995         * python/py-arch.c: Use C++ exception handling.
4996         * printcmd.c: Use C++ exception handling.
4997         * ppc-linux-tdep.c: Use C++ exception handling.
4998         * parse.c: Use C++ exception handling.
4999         * p-valprint.c: Use C++ exception handling.
5000         * objc-lang.c: Use C++ exception handling.
5001         * mi/mi-main.c: Use C++ exception handling.
5002         * mi/mi-interp.c: Use C++ exception handling.
5003         * mi/mi-cmd-stack.c: Use C++ exception handling.
5004         * mi/mi-cmd-break.c: Use C++ exception handling.
5005         * main.c: Use C++ exception handling.
5006         * linux-thread-db.c: Use C++ exception handling.
5007         * linux-tdep.c: Use C++ exception handling.
5008         * linux-nat.c: Use C++ exception handling.
5009         * linux-fork.c: Use C++ exception handling.
5010         * linespec.c: Use C++ exception handling.
5011         * language.c: Use C++ exception handling.
5012         * jit.c: Use C++ exception handling.
5013         * infrun.c: Use C++ exception handling.
5014         * infcmd.c: Use C++ exception handling.
5015         * infcall.c: Use C++ exception handling.
5016         * inf-loop.c: Use C++ exception handling.
5017         * i386-tdep.c: Use C++ exception handling.
5018         * i386-linux-tdep.c: Use C++ exception handling.
5019         * guile/scm-value.c: Use C++ exception handling.
5020         * guile/scm-type.c: Use C++ exception handling.
5021         * guile/scm-symtab.c: Use C++ exception handling.
5022         * guile/scm-symbol.c: Use C++ exception handling.
5023         * guile/scm-pretty-print.c: Use C++ exception handling.
5024         * guile/scm-ports.c: Use C++ exception handling.
5025         * guile/scm-param.c: Use C++ exception handling.
5026         * guile/scm-math.c: Use C++ exception handling.
5027         * guile/scm-lazy-string.c: Use C++ exception handling.
5028         * guile/scm-frame.c: Use C++ exception handling.
5029         * guile/scm-disasm.c: Use C++ exception handling.
5030         * guile/scm-cmd.c: Use C++ exception handling.
5031         * guile/scm-breakpoint.c: Use C++ exception handling.
5032         * guile/scm-block.c: Use C++ exception handling.
5033         * guile/guile-internal.h: Use C++ exception handling.
5034         * gnu-v3-abi.c: Use C++ exception handling.
5035         * gdbtypes.c: Use C++ exception handling.
5036         * frame.c: Use C++ exception handling.
5037         * frame-unwind.c: Use C++ exception handling.
5038         * fbsd-tdep.c: Use C++ exception handling.
5039         * f-valprint.c: Use C++ exception handling.
5040         * exec.c: Use C++ exception handling.
5041         * event-top.c: Use C++ exception handling.
5042         * event-loop.c: Use C++ exception handling.
5043         * eval.c: Use C++ exception handling.
5044         * dwarf2read.c: Use C++ exception handling.
5045         * dwarf2loc.c: Use C++ exception handling.
5046         * dwarf2-frame.c: Use C++ exception handling.
5047         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5048         * dwarf-index-write.c: Use C++ exception handling.
5049         * dwarf-index-cache.c: Use C++ exception handling.
5050         * dtrace-probe.c: Use C++ exception handling.
5051         * disasm-selftests.c: Use C++ exception handling.
5052         * darwin-nat.c: Use C++ exception handling.
5053         * cp-valprint.c: Use C++ exception handling.
5054         * cp-support.c: Use C++ exception handling.
5055         * cp-abi.c: Use C++ exception handling.
5056         * corelow.c: Use C++ exception handling.
5057         * completer.c: Use C++ exception handling.
5058         * compile/compile-object-run.c: Use C++ exception handling.
5059         * compile/compile-object-load.c: Use C++ exception handling.
5060         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5061         * compile/compile-c-symbols.c: Use C++ exception handling.
5062         * common/selftest.c: Use C++ exception handling.
5063         * common/new-op.c: Use C++ exception handling.
5064         * cli/cli-script.c: Use C++ exception handling.
5065         * cli/cli-interp.c: Use C++ exception handling.
5066         * cli/cli-cmds.c: Use C++ exception handling.
5067         * c-varobj.c: Use C++ exception handling.
5068         * btrace.c: Use C++ exception handling.
5069         * breakpoint.c: Use C++ exception handling.
5070         * break-catch-throw.c: Use C++ exception handling.
5071         * arch-utils.c: Use C++ exception handling.
5072         * amd64-tdep.c: Use C++ exception handling.
5073         * ada-valprint.c: Use C++ exception handling.
5074         * ada-typeprint.c: Use C++ exception handling.
5075         * ada-lang.c: Use C++ exception handling.
5076         * aarch64-tdep.c: Use C++ exception handling.
5077
5078 2019-04-08  Tom Tromey  <tom@tromey.com>
5079
5080         * xml-support.c (gdb_xml_parser::parse): Update.
5081         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5082         * value.c (show_convenience): Update.
5083         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5084         (test_parse_flags_qcs): Update.
5085         * thread.c (thr_try_catch_cmd): Update.
5086         * target.c (target_translate_tls_address): Update.
5087         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5088         (info_frame_command_core, frame_apply_command_count): Update.
5089         * rust-exp.y (rust_lex_exception_test): Update.
5090         * riscv-tdep.c (riscv_print_one_register_info): Update.
5091         * remote.c (remote_target::enable_btrace): Update.
5092         * record-btrace.c (record_btrace_enable_warn): Update.
5093         * python/py-utils.c (gdbpy_convert_exception): Update.
5094         * printcmd.c (do_one_display, print_variable_and_value): Update.
5095         * mi/mi-main.c (mi_print_exception): Update.
5096         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5097         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5098         * linux-nat.c (linux_nat_target::attach): Update.
5099         * linux-fork.c (class scoped_switch_fork_info): Update.
5100         * infrun.c (displaced_step_prepare): Update.
5101         * infcall.c (call_function_by_hand_dummy): Update.
5102         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5103         * gnu-v3-abi.c (print_one_vtable): Update.
5104         * frame.c (get_prev_frame_always): Update.
5105         * f-valprint.c (info_common_command_for_block): Update.
5106         * exec.c (try_open_exec_file): Update.
5107         * exceptions.c (print_exception, exception_print)
5108         (exception_fprintf, exception_print_same): Update.
5109         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5110         * dwarf-index-cache.c (index_cache::store)
5111         (index_cache::lookup_gdb_index): Update.
5112         * darwin-nat.c (maybe_cache_shell): Update.
5113         * cp-valprint.c (cp_print_value_fields): Update.
5114         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5115         (gcc_cplus_symbol_address): Update.
5116         * compile/compile-c-symbols.c (gcc_convert_symbol)
5117         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5118         * common/selftest.c: Update.
5119         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5120         a std::string.
5121         (exception_try_scope_entry, exception_try_scope_exit): Don't
5122         declare.
5123         (struct exception_try_scope): Remove.
5124         (TRY): Don't use exception_try_scope.
5125         (struct gdb_exception): Add constructor, operator=.
5126         <what>: New method.
5127         (struct gdb_exception_RETURN_MASK_ALL)
5128         (struct gdb_exception_RETURN_MASK_ERROR)
5129         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5130         (struct gdb_quit_bad_alloc): Update.
5131         * common/common-exceptions.c (exception_none): Change
5132         initializer.
5133         (struct catcher) <state, exception>: Initialize inline.
5134         <prev>: Remove member.
5135         (current_catcher): Remove.
5136         (catchers): New global.
5137         (exceptions_state_mc_init): Simplify.
5138         (catcher_pop): Remove.
5139         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5140         (try_scope_depth, exception_try_scope_entry)
5141         (exception_try_scope_exit): Remove.
5142         (throw_exception_sjlj): Update.
5143         (exception_messages, exception_messages_size): Remove.
5144         (throw_it): Simplify.
5145         (gdb_exception_sliced_copy): Remove.
5146         (throw_exception_cxx): Update.
5147         * cli/cli-script.c (script_from_file): Update.
5148         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5149         Update.
5150         * ada-valprint.c (ada_val_print): Update.
5151         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5152         (create_excep_cond_exprs): Update.
5153
5154 2019-04-08  Tom Tromey  <tom@tromey.com>
5155
5156         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5157         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5158         (TRY, CATCH, END_CATCH): Remove some definitions.
5159         * common/common-exceptions.c: Don't use GDB_XCPT.
5160         (catcher_list_size): Remove.
5161         (throw_exception, throw_it): Simplify.
5162
5163 2019-04-05  Tom Tromey  <tom@tromey.com>
5164
5165         Revert the header-sorting patch.
5166         * ft32-tdep.c: Revert.
5167         * frv-tdep.c: Revert.
5168         * frv-linux-tdep.c: Revert.
5169         * frame.c: Revert.
5170         * frame-unwind.c: Revert.
5171         * frame-base.c: Revert.
5172         * fork-child.c: Revert.
5173         * findvar.c: Revert.
5174         * findcmd.c: Revert.
5175         * filesystem.c: Revert.
5176         * filename-seen-cache.h: Revert.
5177         * filename-seen-cache.c: Revert.
5178         * fbsd-tdep.c: Revert.
5179         * fbsd-nat.h: Revert.
5180         * fbsd-nat.c: Revert.
5181         * f-valprint.c: Revert.
5182         * f-typeprint.c: Revert.
5183         * f-lang.c: Revert.
5184         * extension.h: Revert.
5185         * extension.c: Revert.
5186         * extension-priv.h: Revert.
5187         * expprint.c: Revert.
5188         * exec.h: Revert.
5189         * exec.c: Revert.
5190         * exceptions.c: Revert.
5191         * event-top.c: Revert.
5192         * event-loop.c: Revert.
5193         * eval.c: Revert.
5194         * elfread.c: Revert.
5195         * dwarf2read.h: Revert.
5196         * dwarf2read.c: Revert.
5197         * dwarf2loc.c: Revert.
5198         * dwarf2expr.h: Revert.
5199         * dwarf2expr.c: Revert.
5200         * dwarf2-frame.c: Revert.
5201         * dwarf2-frame-tailcall.c: Revert.
5202         * dwarf-index-write.h: Revert.
5203         * dwarf-index-write.c: Revert.
5204         * dwarf-index-common.c: Revert.
5205         * dwarf-index-cache.h: Revert.
5206         * dwarf-index-cache.c: Revert.
5207         * dummy-frame.c: Revert.
5208         * dtrace-probe.c: Revert.
5209         * disasm.h: Revert.
5210         * disasm.c: Revert.
5211         * disasm-selftests.c: Revert.
5212         * dictionary.c: Revert.
5213         * dicos-tdep.c: Revert.
5214         * demangle.c: Revert.
5215         * dcache.h: Revert.
5216         * dcache.c: Revert.
5217         * darwin-nat.h: Revert.
5218         * darwin-nat.c: Revert.
5219         * darwin-nat-info.c: Revert.
5220         * d-valprint.c: Revert.
5221         * d-namespace.c: Revert.
5222         * d-lang.c: Revert.
5223         * ctf.c: Revert.
5224         * csky-tdep.c: Revert.
5225         * csky-linux-tdep.c: Revert.
5226         * cris-tdep.c: Revert.
5227         * cris-linux-tdep.c: Revert.
5228         * cp-valprint.c: Revert.
5229         * cp-support.c: Revert.
5230         * cp-namespace.c: Revert.
5231         * cp-abi.c: Revert.
5232         * corelow.c: Revert.
5233         * corefile.c: Revert.
5234         * continuations.c: Revert.
5235         * completer.h: Revert.
5236         * completer.c: Revert.
5237         * complaints.c: Revert.
5238         * coffread.c: Revert.
5239         * coff-pe-read.c: Revert.
5240         * cli-out.h: Revert.
5241         * cli-out.c: Revert.
5242         * charset.c: Revert.
5243         * c-varobj.c: Revert.
5244         * c-valprint.c: Revert.
5245         * c-typeprint.c: Revert.
5246         * c-lang.c: Revert.
5247         * buildsym.c: Revert.
5248         * buildsym-legacy.c: Revert.
5249         * build-id.h: Revert.
5250         * build-id.c: Revert.
5251         * btrace.c: Revert.
5252         * bsd-uthread.c: Revert.
5253         * breakpoint.h: Revert.
5254         * breakpoint.c: Revert.
5255         * break-catch-throw.c: Revert.
5256         * break-catch-syscall.c: Revert.
5257         * break-catch-sig.c: Revert.
5258         * blockframe.c: Revert.
5259         * block.c: Revert.
5260         * bfin-tdep.c: Revert.
5261         * bfin-linux-tdep.c: Revert.
5262         * bfd-target.c: Revert.
5263         * bcache.c: Revert.
5264         * ax-general.c: Revert.
5265         * ax-gdb.h: Revert.
5266         * ax-gdb.c: Revert.
5267         * avr-tdep.c: Revert.
5268         * auxv.c: Revert.
5269         * auto-load.c: Revert.
5270         * arm-wince-tdep.c: Revert.
5271         * arm-tdep.c: Revert.
5272         * arm-symbian-tdep.c: Revert.
5273         * arm-pikeos-tdep.c: Revert.
5274         * arm-obsd-tdep.c: Revert.
5275         * arm-nbsd-tdep.c: Revert.
5276         * arm-nbsd-nat.c: Revert.
5277         * arm-linux-tdep.c: Revert.
5278         * arm-linux-nat.c: Revert.
5279         * arm-fbsd-tdep.c: Revert.
5280         * arm-fbsd-nat.c: Revert.
5281         * arm-bsd-tdep.c: Revert.
5282         * arch-utils.c: Revert.
5283         * arc-tdep.c: Revert.
5284         * arc-newlib-tdep.c: Revert.
5285         * annotate.h: Revert.
5286         * annotate.c: Revert.
5287         * amd64-windows-tdep.c: Revert.
5288         * amd64-windows-nat.c: Revert.
5289         * amd64-tdep.c: Revert.
5290         * amd64-sol2-tdep.c: Revert.
5291         * amd64-obsd-tdep.c: Revert.
5292         * amd64-obsd-nat.c: Revert.
5293         * amd64-nbsd-tdep.c: Revert.
5294         * amd64-nbsd-nat.c: Revert.
5295         * amd64-nat.c: Revert.
5296         * amd64-linux-tdep.c: Revert.
5297         * amd64-linux-nat.c: Revert.
5298         * amd64-fbsd-tdep.c: Revert.
5299         * amd64-fbsd-nat.c: Revert.
5300         * amd64-dicos-tdep.c: Revert.
5301         * amd64-darwin-tdep.c: Revert.
5302         * amd64-bsd-nat.c: Revert.
5303         * alpha-tdep.c: Revert.
5304         * alpha-obsd-tdep.c: Revert.
5305         * alpha-nbsd-tdep.c: Revert.
5306         * alpha-mdebug-tdep.c: Revert.
5307         * alpha-linux-tdep.c: Revert.
5308         * alpha-linux-nat.c: Revert.
5309         * alpha-bsd-tdep.c: Revert.
5310         * alpha-bsd-nat.c: Revert.
5311         * aix-thread.c: Revert.
5312         * agent.c: Revert.
5313         * addrmap.c: Revert.
5314         * ada-varobj.c: Revert.
5315         * ada-valprint.c: Revert.
5316         * ada-typeprint.c: Revert.
5317         * ada-tasks.c: Revert.
5318         * ada-lang.c: Revert.
5319         * aarch64-tdep.c: Revert.
5320         * aarch64-ravenscar-thread.c: Revert.
5321         * aarch64-newlib-tdep.c: Revert.
5322         * aarch64-linux-tdep.c: Revert.
5323         * aarch64-linux-nat.c: Revert.
5324         * aarch64-fbsd-tdep.c: Revert.
5325         * aarch64-fbsd-nat.c: Revert.
5326         * aarch32-linux-nat.c: Revert.
5327
5328 2019-04-05  Tom Tromey  <tom@tromey.com>
5329
5330         * ft32-tdep.c: Sort headers.
5331         * frv-tdep.c: Sort headers.
5332         * frv-linux-tdep.c: Sort headers.
5333         * frame.c: Sort headers.
5334         * frame-unwind.c: Sort headers.
5335         * frame-base.c: Sort headers.
5336         * fork-child.c: Sort headers.
5337         * findvar.c: Sort headers.
5338         * findcmd.c: Sort headers.
5339         * filesystem.c: Sort headers.
5340         * filename-seen-cache.h: Sort headers.
5341         * filename-seen-cache.c: Sort headers.
5342         * fbsd-tdep.c: Sort headers.
5343         * fbsd-nat.h: Sort headers.
5344         * fbsd-nat.c: Sort headers.
5345         * f-valprint.c: Sort headers.
5346         * f-typeprint.c: Sort headers.
5347         * f-lang.c: Sort headers.
5348         * extension.h: Sort headers.
5349         * extension.c: Sort headers.
5350         * extension-priv.h: Sort headers.
5351         * expprint.c: Sort headers.
5352         * exec.h: Sort headers.
5353         * exec.c: Sort headers.
5354         * exceptions.c: Sort headers.
5355         * event-top.c: Sort headers.
5356         * event-loop.c: Sort headers.
5357         * eval.c: Sort headers.
5358         * elfread.c: Sort headers.
5359         * dwarf2read.h: Sort headers.
5360         * dwarf2read.c: Sort headers.
5361         * dwarf2loc.c: Sort headers.
5362         * dwarf2expr.h: Sort headers.
5363         * dwarf2expr.c: Sort headers.
5364         * dwarf2-frame.c: Sort headers.
5365         * dwarf2-frame-tailcall.c: Sort headers.
5366         * dwarf-index-write.h: Sort headers.
5367         * dwarf-index-write.c: Sort headers.
5368         * dwarf-index-common.c: Sort headers.
5369         * dwarf-index-cache.h: Sort headers.
5370         * dwarf-index-cache.c: Sort headers.
5371         * dummy-frame.c: Sort headers.
5372         * dtrace-probe.c: Sort headers.
5373         * disasm.h: Sort headers.
5374         * disasm.c: Sort headers.
5375         * disasm-selftests.c: Sort headers.
5376         * dictionary.c: Sort headers.
5377         * dicos-tdep.c: Sort headers.
5378         * demangle.c: Sort headers.
5379         * dcache.h: Sort headers.
5380         * dcache.c: Sort headers.
5381         * darwin-nat.h: Sort headers.
5382         * darwin-nat.c: Sort headers.
5383         * darwin-nat-info.c: Sort headers.
5384         * d-valprint.c: Sort headers.
5385         * d-namespace.c: Sort headers.
5386         * d-lang.c: Sort headers.
5387         * ctf.c: Sort headers.
5388         * csky-tdep.c: Sort headers.
5389         * csky-linux-tdep.c: Sort headers.
5390         * cris-tdep.c: Sort headers.
5391         * cris-linux-tdep.c: Sort headers.
5392         * cp-valprint.c: Sort headers.
5393         * cp-support.c: Sort headers.
5394         * cp-namespace.c: Sort headers.
5395         * cp-abi.c: Sort headers.
5396         * corelow.c: Sort headers.
5397         * corefile.c: Sort headers.
5398         * continuations.c: Sort headers.
5399         * completer.h: Sort headers.
5400         * completer.c: Sort headers.
5401         * complaints.c: Sort headers.
5402         * coffread.c: Sort headers.
5403         * coff-pe-read.c: Sort headers.
5404         * cli-out.h: Sort headers.
5405         * cli-out.c: Sort headers.
5406         * charset.c: Sort headers.
5407         * c-varobj.c: Sort headers.
5408         * c-valprint.c: Sort headers.
5409         * c-typeprint.c: Sort headers.
5410         * c-lang.c: Sort headers.
5411         * buildsym.c: Sort headers.
5412         * buildsym-legacy.c: Sort headers.
5413         * build-id.h: Sort headers.
5414         * build-id.c: Sort headers.
5415         * btrace.c: Sort headers.
5416         * bsd-uthread.c: Sort headers.
5417         * breakpoint.h: Sort headers.
5418         * breakpoint.c: Sort headers.
5419         * break-catch-throw.c: Sort headers.
5420         * break-catch-syscall.c: Sort headers.
5421         * break-catch-sig.c: Sort headers.
5422         * blockframe.c: Sort headers.
5423         * block.c: Sort headers.
5424         * bfin-tdep.c: Sort headers.
5425         * bfin-linux-tdep.c: Sort headers.
5426         * bfd-target.c: Sort headers.
5427         * bcache.c: Sort headers.
5428         * ax-general.c: Sort headers.
5429         * ax-gdb.h: Sort headers.
5430         * ax-gdb.c: Sort headers.
5431         * avr-tdep.c: Sort headers.
5432         * auxv.c: Sort headers.
5433         * auto-load.c: Sort headers.
5434         * arm-wince-tdep.c: Sort headers.
5435         * arm-tdep.c: Sort headers.
5436         * arm-symbian-tdep.c: Sort headers.
5437         * arm-pikeos-tdep.c: Sort headers.
5438         * arm-obsd-tdep.c: Sort headers.
5439         * arm-nbsd-tdep.c: Sort headers.
5440         * arm-nbsd-nat.c: Sort headers.
5441         * arm-linux-tdep.c: Sort headers.
5442         * arm-linux-nat.c: Sort headers.
5443         * arm-fbsd-tdep.c: Sort headers.
5444         * arm-fbsd-nat.c: Sort headers.
5445         * arm-bsd-tdep.c: Sort headers.
5446         * arch-utils.c: Sort headers.
5447         * arc-tdep.c: Sort headers.
5448         * arc-newlib-tdep.c: Sort headers.
5449         * annotate.h: Sort headers.
5450         * annotate.c: Sort headers.
5451         * amd64-windows-tdep.c: Sort headers.
5452         * amd64-windows-nat.c: Sort headers.
5453         * amd64-tdep.c: Sort headers.
5454         * amd64-sol2-tdep.c: Sort headers.
5455         * amd64-obsd-tdep.c: Sort headers.
5456         * amd64-obsd-nat.c: Sort headers.
5457         * amd64-nbsd-tdep.c: Sort headers.
5458         * amd64-nbsd-nat.c: Sort headers.
5459         * amd64-nat.c: Sort headers.
5460         * amd64-linux-tdep.c: Sort headers.
5461         * amd64-linux-nat.c: Sort headers.
5462         * amd64-fbsd-tdep.c: Sort headers.
5463         * amd64-fbsd-nat.c: Sort headers.
5464         * amd64-dicos-tdep.c: Sort headers.
5465         * amd64-darwin-tdep.c: Sort headers.
5466         * amd64-bsd-nat.c: Sort headers.
5467         * alpha-tdep.c: Sort headers.
5468         * alpha-obsd-tdep.c: Sort headers.
5469         * alpha-nbsd-tdep.c: Sort headers.
5470         * alpha-mdebug-tdep.c: Sort headers.
5471         * alpha-linux-tdep.c: Sort headers.
5472         * alpha-linux-nat.c: Sort headers.
5473         * alpha-bsd-tdep.c: Sort headers.
5474         * alpha-bsd-nat.c: Sort headers.
5475         * aix-thread.c: Sort headers.
5476         * agent.c: Sort headers.
5477         * addrmap.c: Sort headers.
5478         * ada-varobj.c: Sort headers.
5479         * ada-valprint.c: Sort headers.
5480         * ada-typeprint.c: Sort headers.
5481         * ada-tasks.c: Sort headers.
5482         * ada-lang.c: Sort headers.
5483         * aarch64-tdep.c: Sort headers.
5484         * aarch64-ravenscar-thread.c: Sort headers.
5485         * aarch64-newlib-tdep.c: Sort headers.
5486         * aarch64-linux-tdep.c: Sort headers.
5487         * aarch64-linux-nat.c: Sort headers.
5488         * aarch64-fbsd-tdep.c: Sort headers.
5489         * aarch64-fbsd-nat.c: Sort headers.
5490         * aarch32-linux-nat.c: Sort headers.
5491
5492 2019-04-04  Tom Tromey  <tom@tromey.com>
5493
5494         * varobj.c (varobj_create): Update.
5495         * rust-exp.y (struct rust_parser) <update_innermost_block,
5496         lookup_symbol>: New methods.
5497         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5498         Rename.
5499         (rust_parser::rust_lookup_type)
5500         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5501         * printcmd.c (display_command, do_one_display): Update.
5502         * parser-defs.h (struct parser_state) <parser_state>: Add
5503         "tracker" parameter.
5504         (block_tracker): New member.
5505         (class innermost_block_tracker) <innermost_block_tracker>: Add
5506         "types" parameter.
5507         <reset>: Remove method.
5508         (innermost_block): Don't declare.
5509         (null_post_parser): Update.
5510         * parse.c (innermost_block): Remove global.
5511         (write_dollar_variable): Update.
5512         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5513         Remove "tracker_types" parameter.
5514         (parse_expression): Add "tracker" parameter.
5515         (parse_expression_for_completion): Update.
5516         (null_post_parser): Add "tracker" parameter.
5517         * p-exp.y: Update rules.
5518         * m2-exp.y: Update rules.
5519         * language.h (struct language_defn) <la_post_parser>: Add
5520         "tracker" parameter.
5521         * go-exp.y: Update rules.
5522         * f-exp.y: Update rules.
5523         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5524         parameter.
5525         * d-exp.y: Update rules.
5526         * c-exp.y: Update rules.
5527         * breakpoint.c (set_breakpoint_condition): Create an
5528         innermost_block_tracker.
5529         (watch_command_1): Likewise.
5530         * ada-lang.c (resolve): Add "tracker" parameter.
5531         (resolve_subexp): Likewise.
5532         * ada-exp.y (write_var_from_sym): Update.
5533
5534 2019-04-04  Tom Tromey  <tom@tromey.com>
5535
5536         * type-stack.h: New file.
5537         * type-stack.c: New file.
5538         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5539         type-stack.h.
5540         (insert_into_type_stack, insert_type, push_type, push_type_int)
5541         (insert_type_address_space, pop_type, pop_type_int)
5542         (pop_typelist, pop_type_stack, append_type_stack)
5543         (push_type_stack, get_type_stack, push_typelist)
5544         (follow_type_instance_flags, follow_types): Don't declare.
5545         * parse.c (type_stack): Remove global.
5546         (parse_exp_in_context): Update.
5547         (insert_into_type_stack, insert_type, push_type, push_type_int)
5548         (insert_type_address_space, pop_type, pop_type_int)
5549         (pop_typelist, pop_type_stack, append_type_stack)
5550         (push_type_stack, get_type_stack, push_typelist)
5551         (follow_type_instance_flags, follow_types): Remove (moved to
5552         type-stack.c).
5553         * f-exp.y (type_stack): New global.
5554         Update rules.
5555         (push_kind_type, f_parse): Update.
5556         * d-exp.y (type_stack): New global.
5557         Update rules.
5558         (d_parse): Update.
5559         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5560         Update rules.
5561         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5562         (HFILES_NO_SRCDIR): Add type-stack.h.
5563
5564 2019-04-04  Tom Tromey  <tom@tromey.com>
5565
5566         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5567         (rust_parser::convert_ast_to_expression, rust_parse)
5568         (rust_lex_test_completion, rust_lex_tests): Update.
5569         * parser-defs.h (struct expr_completion_state): New.
5570         (struct parser_state) <parser_state>: Add completion parameter.
5571         <mark_struct_expression, mark_completion_tag>: New methods.
5572         <parse_completion, m_completion_state>: New members.
5573         (prefixify_expression, null_post_parser): Update.
5574         (mark_struct_expression, mark_completion_tag): Don't declare.
5575         * parse.c (parse_completion, expout_last_struct)
5576         (expout_tag_completion_type, expout_completion_name): Remove
5577         globals.
5578         (parser_state::mark_struct_expression)
5579         (parser_state::mark_completion_tag): Now methods.
5580         (prefixify_expression): Add last_struct parameter.
5581         (prefixify_subexp): Likewise.
5582         (parse_exp_1): Update.
5583         (parse_exp_in_context): Add cstate parameter.  Update.
5584         (parse_expression_for_completion): Create an
5585         expr_completion_state.
5586         (null_post_parser): Add "completion" parameter.
5587         * p-exp.y: Update rules.
5588         (yylex): Update.
5589         * language.h (struct language_defn) <la_post_parser>: Add
5590         "completing" parameter.
5591         * go-exp.y: Update rules.
5592         (lex_one_token): Update.
5593         * expression.h (parse_completion): Don't declare.
5594         * d-exp.y: Update rules.
5595         (lex_one_token): Update rules.
5596         * c-exp.y: Update rules.
5597         (lex_one_token): Update.
5598         * ada-lang.c (resolve): Add "parse_completion" parameter.
5599         (resolve_subexp): Likewise.
5600         (ada_resolve_function): Likewise.
5601
5602 2019-04-04  Tom Tromey  <tom@tromey.com>
5603
5604         * parser-defs.h (struct parser_state) <start_arglist,
5605         end_arglist>: New methods.
5606         <arglist_len, m_funcall_chain>: New members.
5607         (arglist_len, start_arglist, end_arglist): Don't declare.
5608         * parse.c (arglist_len, funcall_chain): Remove global.
5609         (start_arglist, end_arglist): Remove functions.
5610         (parse_exp_in_context): Update.
5611         * p-exp.y: Update rules.
5612         * m2-exp.y: Update rules.
5613         * go-exp.y: Update rules.
5614         * f-exp.y: Update rules.
5615         * d-exp.y: Update rules.
5616         * c-exp.y: Update rules.
5617
5618 2019-04-04  Tom Tromey  <tom@tromey.com>
5619
5620         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5621         lex_operator, push_back>: New methods.
5622         Update all rules.
5623         (rust_parser::lex_hex, lex_escape): Rename and update.
5624         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5625         (rust_parser::lex_operator): Rename and update.
5626         (rust_parser::lex_number, rustyylex, rustyyerror)
5627         (rust_lex_test_init, rust_lex_test_sequence)
5628         (rust_lex_test_push_back, rust_lex_tests): Update.
5629         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5630         parameter.
5631         <lexptr, prev_lexptr>: New members.
5632         (lexptr, prev_lexptr): Don't declare.
5633         * parse.c (lexptr, prev_lexptr): Remove globals.
5634         (parse_exp_in_context): Update.
5635         * p-exp.y (yylex, yyerror): Update.
5636         * m2-exp.y (parse_number, yylex, yyerror): Update.
5637         * go-exp.y (lex_one_token, yyerror): Update.
5638         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5639         * d-exp.y (lex_one_token, yyerror): Update.
5640         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5641         (lex_one_token, yyerror): Update.
5642         * ada-lex.l (YY_INPUT): Update.
5643         (rewind_to_char): Update.
5644         * ada-exp.y (yyerror): Update.
5645
5646 2019-04-04  Tom Tromey  <tom@tromey.com>
5647
5648         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5649         * parser-defs.h (struct parser_state) <parser_state>: Add new
5650         parameter.
5651         <comma_terminates>: New member.
5652         (comma_terminates): Don't declare global.
5653         * parse.c (comma_terminates): Remove global.
5654         (parse_exp_in_context): Update.
5655         * p-exp.y (yylex): Update.
5656         * m2-exp.y (yylex): Update.
5657         * go-exp.y (lex_one_token): Update.
5658         * f-exp.y (yylex): Update.
5659         * d-exp.y (lex_one_token): Update.
5660         * c-exp.y (lex_one_token): Update.
5661         * ada-lex.l: Update.
5662
5663 2019-04-04  Tom Tromey  <tom@tromey.com>
5664
5665         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5666         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5667         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5668         * parser-defs.h (paren_depth): Don't declare.
5669         * parse.c (paren_depth): Remove global.
5670         (parse_exp_in_context): Update.
5671         * p-exp.y (paren_depth): New global.
5672         (pascal_parse): Initialize it.
5673         * m2-exp.y (paren_depth): New global.
5674         (m2_parse): Initialize it.
5675         * go-exp.y (paren_depth): New global.
5676         (go_parse): Initialize it.
5677         * f-exp.y (paren_depth): New global.
5678         (f_parse): Initialize it.
5679         * d-exp.y (paren_depth): New global.
5680         (d_parse): Initialize it.
5681         * c-exp.y (paren_depth): New global.
5682         (c_parse): Initialize it.
5683         * ada-lex.l (paren_depth): New global.
5684         (lexer_init): Initialize it.
5685
5686 2019-04-04  Tom Tromey  <tom@tromey.com>
5687
5688         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5689         (rust_parser::convert_ast_to_type)
5690         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5691         * parser-defs.h (struct parser_state) <parser_state>: Add
5692         parameters.  Initialize new members.
5693         <expression_context_block, expression_context_pc>: New members.
5694         * parse.c (expression_context_block, expression_context_pc):
5695         Remove globals.
5696         (parse_exp_in_context): Update.
5697         * p-exp.y: Update all rules.
5698         (yylex): Update.
5699         * m2-exp.y: Update all rules.
5700         (yylex): Update.
5701         * go-exp.y (yylex): Update.
5702         * f-exp.y (yylex): Update.
5703         * d-exp.y: Update all rules.
5704         (yylex): Update.
5705         * c-exp.y: Update all rules.
5706         (lex_one_token, classify_name, yylex, c_parse): Update.
5707         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5708
5709 2019-04-04  Tom Tromey  <tom@tromey.com>
5710
5711         * gdbarch.h, gdbarch.c: Rebuild.
5712         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5713         * stap-probe.h:
5714         (struct stap_parse_info): Replace "parser_state" with
5715         "expr_builder".
5716         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5717         (parser_state): New class.
5718         * parse.c (expr_builder): Rename.
5719         (expr_builder::release): Rename.
5720         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5721         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5722         (write_exp_elt_longcst, write_exp_elt_floatcst)
5723         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5724         (write_exp_string_vector, write_exp_bitstring)
5725         (write_exp_msymbol, mark_struct_expression)
5726         (write_dollar_variable)
5727         (insert_type_address_space, increase_expout_size): Replace
5728         "parser_state" with "expr_builder".
5729         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5730         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5731         "parser_state" with "expr_builder".
5732
5733 2019-04-04  Tom Tromey  <tom@tromey.com>
5734
5735         * rust-exp.y: Replace "parse_language" with method call.
5736         * p-exp.y:
5737         (yylex): Replace "parse_language" with method call.
5738         * m2-exp.y:
5739         (yylex): Replace "parse_language" with method call.
5740         * go-exp.y (classify_name): Replace "parse_language" with method
5741         call.
5742         * f-exp.y (yylex): Replace "parse_language" with method call.
5743         * d-exp.y (lex_one_token): Replace "parse_language" with method
5744         call.
5745         * c-exp.y:
5746         (lex_one_token, classify_name, yylex): Replace "parse_language"
5747         with method call.
5748         * ada-exp.y (find_primitive_type, type_char)
5749         (type_system_address): Replace "parse_language" with method call.
5750
5751 2019-04-04  Tom Tromey  <tom@tromey.com>
5752
5753         * rust-exp.y: Replace "parse_gdbarch" with method call.
5754         * parse.c (write_dollar_variable, insert_type_address_space):
5755         Replace "parse_gdbarch" with method call.
5756         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5757         call.
5758         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5759         call.
5760         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5761         "parse_gdbarch" with method call.
5762         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5763         with method call.
5764         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5765         "parse_gdbarch" with method call.
5766         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5767         "parse_gdbarch" with method call.
5768         * c-exp.y (parse_type, parse_number, classify_name): Replace
5769         "parse_gdbarch" with method call.
5770         * ada-lex.l: Replace "parse_gdbarch" with method call.
5771         * ada-exp.y (parse_type, find_primitive_type, type_char)
5772         (type_system_address): Replace "parse_gdbarch" with method call.
5773
5774 2019-04-04  Tom Tromey  <tom@tromey.com>
5775
5776         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5777         * stap-probe.c (stap_parse_argument): Update.
5778         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5779         initial_size parameter.
5780         * rust-exp.y (rust_lex_tests): Update.
5781         * parse.c (parser_state): Update.
5782         (parse_exp_in_context): Update.
5783         * parser-defs.h (struct parser_state) <parser_state>: Remove
5784         "initial_size" parameter.
5785
5786 2019-04-04  Tom Tromey  <tom@tromey.com>
5787
5788         * parser-defs.h (increase_expout_size): Don't declare.
5789         * parse.c (increase_expout_size): Now static.
5790
5791 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5792
5793         * gnu-nat.c (gnu_nat_target::wait): Fix
5794         target_waitstatus_to_string call.
5795
5796 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5797
5798         * eval.c (evaluate_subexp_standard): Handle internal functions
5799         during Fortran function call handling.
5800
5801 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5802
5803         * NEWS: Mention new internal functions.
5804         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5805         (read_base_type): Use dwarf2_init_complex_target_type.
5806         * value.c (creal_internal_fn): New function.
5807         (cimag_internal_fn): New function.
5808         (_initialize_values): Register new internal functions.
5809
5810 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5811
5812         * infrun.c (stop_all_threads): If debug_infrun, always
5813         trace the wait status after wait_one, using
5814         target_waitstatus_to_string and target_pid_to_str.
5815         (handle_inferior_event): Replace various trace of
5816         wait status kind by a single trace.
5817         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5818         wait status kind image by target_waitstatus_to_string.
5819         * target/waitstatus.c (target_waitstatus_to_string): Fix
5820         obsolete comment.
5821
5822 2019-04-01  Tom Tromey  <tromey@adacore.com>
5823
5824         PR symtab/23331:
5825         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5826
5827 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5828             Pedro Alves  <palves@redhat.com>
5829
5830         * top.c (quit_force): Call 'finalize_values'.
5831         * value.c (finalize_values): New function.
5832         * value.h (finalize_values): Declare.
5833
5834 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5835
5836         * NEWS: Announce $_gdb_major and $_gdb_minor.
5837
5838         * top.c (init_gdb_version_vars): New function.
5839         (gdb_init): Call init_gdb_version_vars.
5840
5841 2019-03-29  Tom Tromey  <tromey@adacore.com>
5842
5843         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5844         help text.  Remove dead code.
5845
5846 2019-03-29  Keith Seitz  <keiths@redhat.com>
5847
5848         From Siddhesh Poyarekar:
5849         * f-lang.h (f77_get_upperbound): Return LONGEST.
5850         (f77_get_lowerbound): Likewise.
5851         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5852         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5853         print them.
5854         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5855         plongest to format print it.
5856         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5857         (f77_get_upperbound): Likewise.
5858         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5859         LOWER_BOUND to LONGEST.
5860         (f77_create_arrayprint_offset_tbl): Likewise.
5861
5862 2019-03-29  Keith Seitz  <keiths@redhat.com>
5863
5864         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5865         %s/pulongest for TYPE_LENGTH instead of %d in format
5866         strings.
5867         * ada-typerint.c (ada_print_type): Likewise.
5868         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5869         * compile/compile-c-support.c (generate_register_struct): Likewise.
5870         * gdbtypes.c (recursive_dump_type): Likewise.
5871         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5872         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5873         instead of %d in format strings.
5874         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5875         to std::min to ULONGEST.
5876         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5877         instead of %d in format strings.
5878         * tracepoint.c (info_scope_command): Likewise.
5879         * typeprint.c (print_offset_data::update)
5880         (print_offset_data::finish): Likewise.
5881         * xtensa-tdep.c (xtensa_store_return_value)
5882         (xtensa_push_dummy_call): Likewise.
5883
5884 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5885
5886         * windows-nat.c (display_selector): Fixed format specifications
5887         for 64-bit Cygwin.
5888
5889 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5890
5891         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5892
5893 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5894
5895         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5896         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5897         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5898         (nios2_linux_init_abi): Install it.
5899
5900 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5901
5902         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5903
5904 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5905
5906         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5907
5908 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5909             Tom Tromey  <tromey@adacore.com>
5910
5911         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5912
5913 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5914
5915         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5916         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5917         method to compute the bounds of range types. Also print "[evaluated]"
5918         if the bounds' values come from a dynamic evaluation.
5919
5920 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5923         whitespace when pretty printing is on.
5924
5925 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5926
5927         * ppc-linux-nat.c: Add include.
5928
5929 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5930
5931         * NEWS: Mention AArch64 Pointer Authentication.
5932
5933 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5934
5935         * arm-linux-nat.c: Add include.
5936
5937 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5938
5939         * source-cache.c (source_cache::get_source_lines): Re-read
5940         fullname after calling open_source_file.
5941
5942 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5943
5944         * NEWS: Mention TLS support for FreeBSD.
5945
5946 2019-03-25  Tom Tromey  <tromey@adacore.com>
5947
5948         * minsyms.c (BUNCH_SIZE): Update comment.
5949         (~minimal_symbol_reader): Remove old comment.
5950         (compact_minimal_symbols): Update comment.
5951         (minimal_symbol_reader::install): Remove old comment.  Update
5952         other comments.
5953
5954 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5955
5956         * s390-linux-nat.c: Add include.
5957
5958 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5959
5960         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5961         Call linux_get_hwcap.
5962         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5963         Likewise.
5964         (aarch64_linux_get_hwcap): Remove function.
5965         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5966         declaration.
5967         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5968         linux_get_hwcap.
5969         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5970         * linux-tdep.c (linux_get_hwcap): Add function.
5971         (linux_get_hwcap2): Likewise.
5972         * linux-tdep.h (linux_get_hwcap): Add declaration.
5973         (linux_get_hwcap2): Likewise.
5974         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5975         (ppc_linux_get_hwcap2): Likewise.
5976         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5977         linux_get_hwcap.
5978         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5979         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5980         (ppc_linux_nat_target::read_description): Likewise.
5981         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5982         * s390-linux-nat.c: Likewise.
5983         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5984
5985 2019-03-24  Tom Tromey  <tom@tromey.com>
5986
5987         * ada-lang.c (standard_lookup): Simplify initialization.
5988         (ada_lookup_symbol_nonlocal): Simplify return.
5989         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5990         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5991         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5992         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5993         initialization.
5994         * solib.c (solib_global_lookup): Simplify.
5995         * symtab.c (null_block_symbol): Remove.
5996         (symbol_cache_lookup): Simplify returns.
5997         (lookup_language_this): Simplify returns.
5998         (lookup_symbol_aux): Simplify return.
5999         (lookup_local_symbol): Simplify returns.
6000         (lookup_global_symbol_from_objfile): Simplify return.
6001         (lookup_symbol_in_objfile_symtabs)
6002         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6003         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6004         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6005         * cp-namespace.c (cp_lookup_bare_symbol)
6006         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6007         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6008         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6009         (cp_lookup_symbol_via_imports): Simplify initialization.
6010         (find_symbol_in_baseclass): Likewise.
6011         * symtab.h (null_block_symbol): Remove.
6012         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6013         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6014         (d_lookup_symbol_module): Likewise.
6015         (find_symbol_in_baseclass): Simplify initialization.
6016
6017 2019-03-24  Tom Tromey  <tom@tromey.com>
6018
6019         * expression.h: Don't include symtab.h.
6020         (struct block): Forward declare.
6021
6022 2019-03-24  Tom Tromey  <tom@tromey.com>
6023
6024         * c-exp.y (typebase): Remove casts.
6025         * gdbtypes.c (lookup_unsigned_typename, )
6026         (lookup_signed_typename): Remove cast.
6027         * eval.c (parse_to_comma_and_eval): Remove cast.
6028         * parse.c (write_dollar_variable): Remove cast.
6029         * block.h (struct block) <superblock>: Now const.
6030         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6031         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6032         (map_block): Make "block" const.
6033         * symfile.h (struct quick_symbol_functions)
6034         <map_matching_symbols>: Constify block argument to "callback".
6035         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6036         const.
6037         (find_pc_sect_compunit_symtab): Make "b" const.
6038         (find_symbol_at_address): Likewise.
6039         (search_symbols): Likewise.
6040         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6041         (dw2_debug_names_lookup_symbol): Likewise.
6042         (dw2_map_matching_symbols): Update.
6043         * p-valprint.c (pascal_val_print): Remove "block".
6044         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6045         (aux_add_nonlocal_symbols): Make "block" const.
6046         (resolve_subexp): Remove cast.
6047         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6048         const.
6049         (iterate_over_file_blocks): Likewise.
6050         * f-exp.y (%union) <bval>: Remove.
6051         * coffread.c (patch_opaque_types): Make "b" const.
6052         * spu-tdep.c (spu_catch_start): Make "block" const.
6053         * c-valprint.c (print_unpacked_pointer): Remove "block".
6054         * symmisc.c (dump_symtab_1): Make "b" const.
6055         (block_depth): Make "block" const.
6056         * d-exp.y (%union) <bval>: Remove.
6057         * cp-support.h (cp_lookup_rtti_type): Update.
6058         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6059         * psymtab.c (psym_lookup_symbol): Make "block" const.
6060         (maintenance_check_psymtabs): Make "b" const.
6061         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6062         (enumerate_locals, enumerate_args): Update.
6063         * python/py-symtab.c (stpy_global_block): Make "block" const.
6064         (stpy_static_block): Likewise.
6065         * inline-frame.c (block_starting_point_at): Make "new_block"
6066         const.
6067         * block.c (find_block_in_blockvector): Make return type const.
6068         (blockvector_for_pc_sect): Make "b" const.
6069         (find_block_in_blockvector): Make "b" const.
6070
6071 2019-03-23  Tom Tromey  <tom@tromey.com>
6072
6073         * varobj.c (varobj_create): Update.
6074         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6075         * printcmd.c (display_command, do_one_display): Don't reset
6076         innermost_block.
6077         * parser-defs.h (enum innermost_block_tracker_type): Move to
6078         expression.h.
6079         (innermost_block): Update comment.
6080         * parse.c (parse_exp_1): Add tracker_types parameter.
6081         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6082         tracker_types parameter.  Reset innermost_block.
6083         (parse_exp_in_context): Remove.
6084         (parse_expression_for_completion): Update.
6085         * objfiles.c (~objfile): Don't reset expression_context_block or
6086         innermost_block.
6087         * expression.h (enum innermost_block_tracker_type): Move from
6088         parser-defs.h.
6089         (parse_exp_1): Add tracker_types parameter.
6090         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6091         reset innermost_block.
6092
6093 2019-03-23  Tom Tromey  <tom@tromey.com>
6094
6095         * objfiles.h: Include bcache.h.
6096
6097 2019-03-23  Tom Tromey  <tom@tromey.com>
6098
6099         * linespec.c (get_current_search_block): Use
6100         scoped_restore_current_language.
6101         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6102
6103 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6104             Jiong Wang  <jiong.wang@arm.com>
6105
6106         * aarch64-linux-tdep.c
6107         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6108         section.
6109         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6110
6111 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6112             Jiong Wang  <jiong.wang@arm.com>
6113
6114         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6115         instructions.
6116         (aarch64_analyze_prologue_test): Add PACIASP test.
6117         (aarch64_prologue_prev_register): Unmask PC value.
6118
6119 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6120             Jiong Wang  <jiong.wang@arm.com>
6121
6122         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6123         (aarch64_dwarf2_prev_register): Unmask PC value.
6124         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6125         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6126         DW_CFA_AARCH64_negate_ra_state.
6127         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6128
6129 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6130             Jiong Wang  <jiong.wang@arm.com>
6131
6132         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6133         registers.
6134         (aarch64_pseudo_register_name): Likewise.
6135         (aarch64_pseudo_register_type): Likewise.
6136         (aarch64_pseudo_register_reggroup_p): Likewise.
6137         (aarch64_gdbarch_init): Add pauth registers.
6138         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6139         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6140         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6141         (struct gdbarch_tdep): Add regnum for ra_state.
6142
6143 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6144             Jiong Wang  <jiong.wang@arm.com>
6145
6146         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6147
6148 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6149             Jiong Wang  <jiong.wang@arm.com>
6150
6151         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6152         function.
6153         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6154         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6155         (aarch64_gdbarch_init): Add puth registers.
6156         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6157         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6158         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6159
6160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6161             Jiong Wang  <jiong.wang@arm.com>
6162
6163         * aarch64-linux-nat.c
6164         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6165         * aarch64-linux-tdep.c
6166         (aarch64_linux_core_read_description): Likewise.
6167         (aarch64_linux_get_hwcap): New function.
6168         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6169         (aarch64_linux_get_hwcap): New declaration.
6170
6171 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6172             Jiong Wang  <jiong.wang@arm.com>
6173
6174         * aarch64-linux-nat.c
6175         (aarch64_linux_nat_target::read_description): Add pauth param.
6176         * aarch64-linux-tdep.c
6177         (aarch64_linux_core_read_description): Likewise.
6178         * aarch64-tdep.c (struct target_desc): Add in pauth.
6179         (aarch64_read_description): Add pauth param.
6180         (aarch64_gdbarch_init): Likewise.
6181         * aarch64-tdep.h (aarch64_read_description): Likewise.
6182         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6183         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6184         * features/Makefile: Add new files.
6185         * features/aarch64-pauth.c: New file.
6186         * features/aarch64-pauth.xml: New file.
6187
6188 2019-03-20  Tom Tromey  <tromey@adacore.com>
6189
6190         * infrun.c (handle_inferior_event): Rename from
6191         handle_inferior_event_1.  Create a scoped_value_mark.
6192         (handle_inferior_event): Remove.
6193
6194 2019-03-19  Tom Tromey  <tromey@adacore.com>
6195
6196         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6197         * infrun.h (print_stop_event): Add "displays" parameter.
6198         * infrun.c (print_stop_event): Add "displays" parameter.
6199
6200 2019-03-19  Pedro Alves  <palves@redhat.com>
6201
6202         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6203         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6204         to -1.  Fix TABs vs spaces.
6205         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6206         * tui/tui-out.h (tui_ui_out) Add intro comments.
6207         <m_line, m_start_of_line>: In-class initialize, and add describing
6208         comment.
6209
6210 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6211
6212         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6213         variable names.
6214         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6215
6216 2019-03-18  Pedro Alves  <palves@redhat.com>
6217             Eli Zaretskii <eliz@gnu.org>
6218
6219         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6220         m_line and m_start_of_line.
6221
6222 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6223
6224         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6225         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6226         it returns a newline.  This fixes a regression in TU mode, whereby
6227         the next line is output on the same screen line as the user input.
6228
6229 2019-03-18  Tom Tromey  <tromey@adacore.com>
6230
6231         * minsyms.c (minimal_symbol_reader::install): Remove call to
6232         obstack_blank.
6233
6234 2019-03-18  Pedro Alves  <palves@redhat.com>
6235
6236         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6237         New globals.
6238         (apply_style): New, factored out from ...
6239         (apply_ansi_escape): ... this.  Handle reverse video mode.
6240         (tui_set_reverse_mode): New function.
6241         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6242         * tui/tui-winsource.c (tui_show_source_line): Use
6243         tui_set_reverse_mode instead of setting A_STANDOUT.
6244         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6245         New setter methods.
6246
6247 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6248
6249         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6250         Handle tabs.
6251
6252 2019-03-18  Tom Tromey  <tromey@adacore.com>
6253
6254         * ada-lang.c (empty_array): Add "high" parameter.
6255         (ada_evaluate_subexp): Update.
6256
6257 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6258
6259         * unittests/string_view-selftests.c: Define
6260         _initialize_string_view_selftests unconditionally.
6261
6262 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6263
6264         PR gdb/24350
6265         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6266
6267 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6268
6269         PR gdb/24351
6270         * windows-nat.c (display_selector): Fix format specifiers.
6271
6272 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6273
6274         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6275         tui_refill_source_window instead of tui_refresh_win, to update the
6276         current execution line.  This fixes redisplay of the current line
6277         when stepping through the code with "next" or "step".
6278
6279 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6280
6281         * source-cache.c (source_cache::get_source_lines): Call
6282         find_source_lines to initialize s->nlines.  This fixes vertical
6283         scrolling of TUI source window when the DOWN arrow is pressed.
6284
6285 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6286
6287         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6288         linux-thread-db.c (_initialize_thread_db): Likewise.
6289
6290 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6291
6292         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6293         wclrtoeol in tui_show_source_line".  This reverts changes made in
6294         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6295
6296 2019-03-15  Tom Tromey  <tom@tromey.com>
6297
6298         * symtab.h (struct minimal_symbol): Derive from
6299         general_symbol_info.
6300         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6301         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6302         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6303         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6304         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6305         (MSYMBOL_SEARCH_NAME): Update.
6306         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6307         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6308         * minsyms.c (minimal_symbol_reader::record_full): Update.
6309
6310 2019-03-15  Tom Tromey  <tom@tromey.com>
6311
6312         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6313
6314 2019-03-15  Tom Tromey  <tom@tromey.com>
6315
6316         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6317         unique_xmalloc_ptr.
6318         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6319         Update.
6320         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6321         (build_minimal_symbol_hash_tables)
6322         (minimal_symbol_reader::install): Update.
6323
6324 2019-03-15  Tom Tromey  <tom@tromey.com>
6325
6326         * symtab.c (create_demangled_names_hash): Update.
6327         (symbol_set_names): Update.
6328         * objfiles.h (struct objfile_per_bfd_storage)
6329         <demangled_names_hash>: Now an htab_up.
6330         * objfiles.c (objfile_per_bfd_storage): Simplify.
6331
6332 2019-03-15  Tom Tromey  <tom@tromey.com>
6333
6334         * objfiles.h (struct objfile_per_bfd_storage): Declare
6335         destructor.
6336         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6337         New.
6338         (get_objfile_bfd_data): Use new.  Don't initialize
6339         language_of_main.
6340         (free_objfile_per_bfd_storage): Remove.
6341         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6342
6343 2019-03-15  Tom Tromey  <tom@tromey.com>
6344
6345         * symfile.c (reread_symbols): Update.
6346         * objfiles.c (objfile::objfile): Update.
6347         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6348         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6349         comment.
6350         (minimal_symbol_reader::install): Update.
6351         (terminate_minimal_symbol_table): Remove.
6352         * jit.c (jit_object_close_impl): Update.
6353
6354 2019-03-15  Tom Tromey  <tom@tromey.com>
6355
6356         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6357         initializations.
6358
6359 2019-03-15  Tom Tromey  <tom@tromey.com>
6360
6361         * objfiles.h (struct objfile_per_bfd_storage)
6362         <demangled_hash_languages>: Now a bitset.
6363         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6364         (lookup_minimal_symbol): Update.
6365
6366 2019-03-15  Tom Tromey  <tom@tromey.com>
6367
6368         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6369         Don't return the symbol.
6370         * coffread.c (record_minimal_symbol): Use record_full.
6371
6372 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6373
6374         The MS-Windows port of ncurses fails to switch to a color pair if
6375         one or both of the colors are the implicit default colors.  This
6376         change records the default colors when TUI is initialized, and
6377         then specifies them explicitly when a color pair uses the default
6378         colors.  This allows color styling in TUI mode on MS-Windows.
6379
6380         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6381         ncurses_norm_attr.
6382         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6383         colors in ncurses_norm_attr.
6384         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6385         "none", replace it with the default color recorded in
6386         ncurses_norm_attr.
6387
6388 2019-03-14  Tom Tromey  <tromey@adacore.com>
6389
6390         * source-cache.h (class source_cache) <get_source_lines>: Return
6391         std::string.
6392         * source-cache.c (source_cache::extract_lines): Handle case where
6393         first_pos==npos.  Return std::string.
6394         (source_cache::get_source_lines): Update.
6395
6396 2019-03-14  Tom Tromey  <tromey@adacore.com>
6397
6398         * NEWS: Add item for "style sources" commands.
6399         * source-cache.c (source_cache::get_source_lines): Check
6400         source_styling.
6401         * cli/cli-style.c (source_styling): New global.
6402         (_initialize_cli_style): Add "style sources" commands.
6403         (show_style_sources): New function.
6404         * cli/cli-style.h (source_styling): Declare.
6405
6406 2019-03-14  Pedro Alves  <palves@redhat.com>
6407             Tom Tromey  <tromey@adacore.com>
6408
6409         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6410         * tui/tui-winsource.c (tui_refill_source_window): New function,
6411         from...
6412         (tui_horizontal_source_scroll): ... here.  Move some logic.
6413         * cli/cli-style.c (set_style_enabled): Notify new observable.
6414         * tui/tui-hooks.c (tui_redisplay_source): New function.
6415         (tui_attach_detach_observers): Attach or detach
6416         tui_redisplay_source.
6417         * observable.h (source_styling_changed): New observable.
6418         * observable.c: Define source_styling_changed observable.
6419
6420 2019-03-13  Tom Tromey  <tromey@adacore.com>
6421
6422         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6423         (i386_gnu_nat_target::store_registers): Update.
6424         * target-debug.h (target_debug_print_std_string): New macro.
6425         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6426         * windows-tdep.c (display_one_tib): Update.
6427         * tui/tui-stack.c (tui_make_status_line): Update.
6428         * top.c (print_inferior_quit_action): Update.
6429         * thread.c (thr_try_catch_cmd): Update.
6430         (add_thread_with_info): Update.
6431         (thread_target_id_str): Update.
6432         (thr_try_catch_cmd): Update.
6433         (thread_command): Update.
6434         (thread_find_command): Update.
6435         * record-btrace.c (record_btrace_target::info_record)
6436         (record_btrace_resume_thread, record_btrace_target::resume)
6437         (record_btrace_cancel_resume, record_btrace_step_thread)
6438         (record_btrace_target::wait, record_btrace_target::wait)
6439         (record_btrace_target::wait, record_btrace_target::stop): Update.
6440         * progspace.c (print_program_space): Update.
6441         * process-stratum-target.c
6442         (process_stratum_target::thread_address_space): Update.
6443         * linux-fork.c (linux_fork_mourn_inferior)
6444         (detach_checkpoint_command, info_checkpoints_command)
6445         (linux_fork_context): Update.
6446         (linux_fork_detach): Update.
6447         (class scoped_switch_fork_info): Update.
6448         (delete_checkpoint_command): Update.
6449         * infrun.c (follow_fork_inferior): Update.
6450         (follow_fork_inferior): Update.
6451         (proceed_after_vfork_done): Update.
6452         (handle_vfork_child_exec_or_exit): Update.
6453         (follow_exec): Update.
6454         (displaced_step_prepare_throw): Update.
6455         (displaced_step_restore): Update.
6456         (start_step_over): Update.
6457         (resume_1): Update.
6458         (clear_proceed_status_thread): Update.
6459         (proceed): Update.
6460         (print_target_wait_results): Update.
6461         (do_target_wait): Update.
6462         (context_switch): Update.
6463         (stop_all_threads): Update.
6464         (restart_threads): Update.
6465         (finish_step_over): Update.
6466         (handle_signal_stop): Update.
6467         (switch_back_to_stepped_thread): Update.
6468         (keep_going_pass_signal): Update.
6469         (print_exited_reason): Update.
6470         (normal_stop): Update.
6471         * inferior.c (inferior_pid_to_str): Change return type.
6472         (print_selected_inferior): Update.
6473         (add_inferior): Update.
6474         (detach_inferior): Update.
6475         * dummy-frame.c (fprint_dummy_frames): Update.
6476         * dcache.c (dcache_info_1): Update.
6477         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6478         (btrace_fetch, btrace_clear): Update.
6479         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6480         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6481         type.
6482         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6483         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6484         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6485         * gdbarch.c, gdbarch.h: Rebuild.
6486         * gdbarch.sh (core_pid_to_str): Change return type.
6487         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6488         return type.
6489         (windows_nat_target::pid_to_str): Change return type.
6490         (windows_delete_thread): Update.
6491         (windows_nat_target::attach): Update.
6492         (windows_nat_target::files_info): Update.
6493         * target-delegates.c: Rebuild.
6494         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6495         return type.
6496         (sol_thread_target::pid_to_str): Change return type.
6497         * remote.c (class remote_target) <pid_to_str>: Change return
6498         type.
6499         (remote_target::pid_to_str): Change return type.
6500         (extended_remote_target::attach, remote_target::remote_stop_ns)
6501         (remote_target::remote_notif_remove_queued_reply)
6502         (remote_target::push_stop_reply, remote_target::disable_btrace):
6503         Update.
6504         (extended_remote_target::attach): Update.
6505         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6506         type.
6507         (gdbsim_target::pid_to_str): Change return type.
6508         * ravenscar-thread.c (struct ravenscar_thread_target)
6509         <pid_to_str>: Change return type.
6510         (ravenscar_thread_target::pid_to_str): Change return type.
6511         * procfs.c (class procfs_target) <pid_to_str>: Change return
6512         type.
6513         (procfs_target::pid_to_str): Change return type.
6514         (procfs_target::attach): Update.
6515         (procfs_target::detach): Update.
6516         (procfs_target::fetch_registers): Update.
6517         (procfs_target::store_registers): Update.
6518         (procfs_target::wait): Update.
6519         (procfs_target::files_info): Update.
6520         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6521         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6522         return type.
6523         (nto_procfs_target::pid_to_str): Change return type.
6524         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6525         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6526         return type.
6527         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6528         (exit_lwp): Update.
6529         (attach_proc_task_lwp_callback, get_detach_signal)
6530         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6531         (linux_nat_target::resume, wait_lwp, stop_callback)
6532         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6533         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6534         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6535         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6536         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6537         type.
6538         (inf_ptrace_target::attach): Update.
6539         (inf_ptrace_target::files_info): Update.
6540         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6541         type.
6542         (go32_nat_target::pid_to_str): Change return type.
6543         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6544         (gnu_nat_target::wait): Update.
6545         (gnu_nat_target::wait): Update.
6546         (gnu_nat_target::resume): Update.
6547         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6548         (fbsd_nat_target::wait): Update.
6549         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6550         type.
6551         (darwin_nat_target::attach): Update.
6552         * corelow.c (class core_target) <pid_to_str>: Change return type.
6553         (core_target::pid_to_str): Change return type.
6554         * target.c (normal_pid_to_str): Change return type.
6555         (default_pid_to_str): Likewise.
6556         (target_pid_to_str): Change return type.
6557         (target_translate_tls_address): Update.
6558         (target_announce_detach): Update.
6559         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6560         return type.
6561         (bsd_uthread_target::pid_to_str): Change return type.
6562         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6563         type.
6564         (bsd_kvm_target::pid_to_str): Change return type.
6565         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6566         return type.
6567         (aix_thread_target::pid_to_str): Change return type.
6568         * target.h (struct target_ops) <pid_to_str>: Change return type.
6569         (target_pid_to_str, normal_pid_to_str): Likewise.
6570         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6571         type.
6572         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6573         type.
6574         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6575         return type.
6576         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6577         type.
6578         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6579         type.
6580         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6581         return type.
6582
6583 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6584
6585         * NEWS: Mention that the new default MI version is 3.  Mention
6586         changes to the output of commands and events that deal with
6587         multi-location breakpoints.
6588         * breakpoint.c: Include "mi/mi-out.h".
6589         (print_one_breakpoint): Change output syntax if using MI version
6590         >= 3.
6591         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6592         New.
6593         (mi_multi_location_breakpoint_output_fixed): New.
6594         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6595         (mi_cmd_fix_multi_location_breakpoint_output): New.
6596         (mi_multi_location_breakpoint_output_fixed): New.
6597         * mi/mi-cmds.c (mi_cmds): Register command
6598         -fix-multi-location-breakpoint-output.
6599         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6600         interpreter "mi".
6601
6602 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6603
6604         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6605         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6606         instantiate mi_ui_out based on interpreter name.
6607         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6608         * mi/mi-main.c (mi_load_progress): Likewise.
6609
6610 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6611
6612         * NEWS: Combine separate "New targets" sections for 8.3.
6613
6614 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6615
6616         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6617         (ppcfbsd_init_abi): Install gdbarch
6618         "fetch_tls_load_module_address" and "get_thread_local_address"
6619         methods.
6620
6621 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6622
6623         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6624         (riscv_fbsd_init_abi): Install gdbarch
6625         "fetch_tls_load_module_address" and "get_thread_local_address"
6626         methods.
6627
6628 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6629
6630         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6631         (i386fbsd_init_abi): Install gdbarch
6632         "fetch_tls_load_module_address" and "get_thread_local_address"
6633         methods.
6634
6635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6636
6637         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6638         (amd64fbsd_init_abi): Install gdbarch
6639         "fetch_tls_load_module_address" and "get_thread_local_address"
6640         methods.
6641
6642 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6643
6644         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6645         (struct fbsd_pspace_data): New type.
6646         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6647         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6648         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6649         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6650         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6651
6652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6653
6654         * gdbtypes.c (lookup_struct_elt): New function.
6655         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6656         * gdbtypes.h (struct struct_elt): New type.
6657         (lookup_struct_elt): New prototype.
6658
6659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6660
6661         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6662         remove disabled code block.
6663
6664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6665
6666         * gdbarch.sh (get_thread_local_address): New method.
6667         * gdbarch.h, gdbarch.c: Regenerate.
6668         * target.c (target_translate_tls_address): Use
6669         gdbarch_get_thread_local_address if present instead of
6670         target::get_thread_local_address.
6671
6672 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6673
6674         * target.h (target::get_thread_local_address): Update comment.
6675
6676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6677
6678         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6679         objfile->separate_debug_objfile_backlink if not NULL.
6680
6681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6682
6683         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6684         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6685         (amd64bsd_store_inferior_registers): Likewise.
6686         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6687         Enable segment base registers.
6688         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6689         PT_GETFSBASE and PT_GETGSBASE.
6690         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6691         PT_SETGSBASE.
6692         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6693         segment base registers.
6694         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6695
6696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6697
6698         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6699         Update calls to i386_target_description to add 'segments'
6700         parameter.
6701         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6702         add segment base registers.
6703         * arch/i386.c (i386_create_target_description): Add 'segments'
6704         parameter to enable segment base registers.
6705         * arch/i386.h (i386_create_target_description): Likewise.
6706         * features/i386/32bit-segments.xml: New file.
6707         * features/i386/32bit-segments.c: Generate.
6708         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6709         call to i386_target_description to add 'segments' parameter.
6710         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6711         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6712         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6713         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6714         if feature is present.
6715         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6716         Add 'segments' parameter to call to i386_target_description.
6717         (i386_target_description): Add 'segments' parameter to enable
6718         segment base registers.
6719         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6720         to call to i386_target_description.
6721         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6722         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6723         Define I386_NUM_REGS.
6724         (i386_target_description): Add 'segments' parameter to enable
6725         segment base registers.
6726
6727 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6728
6729         PR/24325
6730         * source-cache.c: #undef open and close, to avoid unresolved
6731         externals during linking.
6732
6733 2019-03-12  Tom Tromey  <tromey@adacore.com>
6734
6735         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6736         const.  Add initializers.
6737         (_initialize_remote): Don't initialize ptid globals.
6738
6739 2019-03-12  Pedro Alves  <palves@redhat.com>
6740
6741         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6742
6743 2019-03-12  Pedro Alves  <palves@redhat.com>
6744
6745         * cp-name-parser.y (main): Remove unused 'len' variable.
6746
6747 2019-03-12  Tom Tromey  <tromey@adacore.com>
6748
6749         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6750         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6751
6752 2019-03-12  Tom Tromey  <tromey@adacore.com>
6753
6754         * linux-nat.c (iterate_over_lwps): Update.
6755         (stop_callback): Remove parameter.
6756         (stop_wait_callback, detach_callback, resume_set_callback)
6757         (select_singlestep_lwp_callback, set_ignore_sigint)
6758         (status_callback, resumed_callback, resume_clear_callback)
6759         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6760         data parameter.
6761         (linux_nat_target::detach, linux_nat_target::resume)
6762         (linux_stop_and_wait_all_lwps, select_event_lwp)
6763         (linux_nat_filter_event, linux_nat_wait_1)
6764         (linux_nat_target::kill, linux_nat_target::stop)
6765         (linux_nat_target::stop): Update.
6766         (linux_nat_resume_callback): Change type.
6767         (resume_stopped_resumed_lwps, count_events_callback)
6768         (select_event_lwp_callback): Likewise.
6769         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6770         * arm-linux-nat.c (struct update_registers_data): Remove.
6771         (update_registers_callback): Change type.
6772         (arm_linux_insert_hw_breakpoint1): Update.
6773         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6774         parameter.
6775         (x86_linux_dr_set_addr): Update.
6776         (x86_linux_dr_set_control): Update.
6777         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6778         (iterate_over_lwps): Use gdb::function_view.
6779         * nat/aarch64-linux-hw-point.c (struct
6780         aarch64_dr_update_callback_param): Remove.
6781         (debug_reg_change_callback): Change type.
6782         (aarch64_notify_debug_reg_change): Update.
6783         * s390-linux-nat.c (s390_refresh_per_info): Update.
6784
6785 2019-03-11  Tom Tromey  <tromey@adacore.com>
6786
6787         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6788         redundant assignment to "this_cu".
6789
6790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6791
6792         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6793
6794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6795
6796         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6797         from...
6798         (rank_one_type): ... this.
6799
6800 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6801
6802         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6803         from...
6804         (rank_one_type): ... this.
6805
6806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6807
6808         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6809         from...
6810         (rank_one_type): ... this.
6811
6812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6813
6814         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6815         from...
6816         (rank_one_type): ... this.
6817
6818 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6819
6820         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6821         from...
6822         (rank_one_type): ... this.
6823
6824 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6825
6826         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6827         from...
6828         (rank_one_type): ... this.
6829
6830 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6831
6832         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6833         from...
6834         (rank_one_type): ... this.
6835
6836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6837
6838         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6839         from...
6840         (rank_one_type): ... this.
6841
6842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6843
6844         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6845         from...
6846         (rank_one_type): ... this.
6847
6848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6849
6850         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6851         from...
6852         (rank_one_type): ... this.
6853
6854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6855
6856         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6857         from...
6858         (rank_one_type): ... this.
6859
6860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6861
6862         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6863         from...
6864         (rank_one_type): ... this.
6865
6866 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6867
6868         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6869         inferior-events' shows the example events.
6870
6871 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6872
6873         Support styling on native MS-Windows console
6874
6875         PR/24315
6876         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6877         on MS-Windows if $TERM is not defined.
6878
6879         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6880
6881         * posix-hdep.c (gdb_console_fputs):
6882         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6883         functions.
6884         * ui-file.h (gdb_console_fputs): Add prototype.
6885
6886         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6887         back to fputs only if the former returns zero.
6888
6889 2019-03-07  Tom Tromey  <tom@tromey.com>
6890
6891         * symmisc.c (print_symbol_bcache_statistics): Update.
6892         (print_objfile_statistics): Update.
6893         * symfile.c (allocate_symtab): Update.
6894         * stabsread.c: Don't include bcache.h.
6895         * psymtab.h (struct psymbol_bcache): Don't declare.
6896         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6897         (psymbol_bcache_init, psymbol_bcache_free)
6898         (psymbol_bcache_get_bcache): Don't declare.
6899         * psymtab.c (struct psymbol_bcache): Remove.
6900         (psymtab_storage::psymtab_storage): Update.
6901         (psymtab_storage::~psymtab_storage): Update.
6902         (psymbol_bcache_init, psymbol_bcache_free)
6903         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6904         (add_psymbol_to_bcache): Update.
6905         (allocate_psymtab): Update.
6906         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6907         macro_cache>: No longer pointers.
6908         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6909         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6910         * macrotab.c (macro_bcache): Update.
6911         * macroexp.c: Don't include bcache.h.
6912         * gdbtypes.c (check_types_worklist): Update.
6913         (types_deeply_equal): Remove TRY/CATCH.  Update.
6914         * elfread.c (elf_symtab_read): Update.
6915         * dwarf2read.c: Don't include bcache.h.
6916         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6917         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6918         (print_bcache_statistics, bcache_memory_used): Don't declare.
6919         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6920         methods.  Rename all data members.
6921         * bcache.c (struct bcache): Move to bcache.h.
6922         (bcache::expand_hash_table): Rename from expand_hash_table.
6923         (bcache): Remove.
6924         (bcache::insert): Rename from bcache_full.
6925         (bcache::compare): Rename from bcache_compare.
6926         (bcache_xmalloc): Remove.
6927         (bcache::~bcache): Rename from bcache_xfree.
6928         (bcache::print_statistics): Rename from print_bcache_statistics.
6929         (bcache::memory_used): Rename from bcache_memory_used.
6930
6931 2019-03-07  Pedro Alves  <palves@redhat.com>
6932
6933         * infrun.c (normal_stop): Also check for
6934         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6935
6936 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6937
6938         * f-lang.c (value_from_host_double): Moved to...
6939         * value.c (value_from_host_double): ...here.
6940         * value.h (value_from_host_double): Declare.
6941         * guile/scm-math.c (vlscm_convert_typed_number): Use
6942         value_from_host_double.
6943         (vlscm_convert_number): Likewise.
6944         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6945         * python/py-value.c (convert_value_from_python): Likewise.
6946
6947 2019-03-06  Tom Tromey  <tom@tromey.com>
6948
6949         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6950
6951 2019-03-06  Tom Tromey  <tom@tromey.com>
6952
6953         * utils.h (free_current_contents): Don't declare.
6954         * utils.c (free_current_contents): Remove.
6955
6956 2019-03-06  Tom Tromey  <tom@tromey.com>
6957
6958         * top.c (quit_force): Update.
6959         * main.c (captured_command_loop): Update.
6960         * common/new-op.c (operator new): Update.
6961         * common/common-exceptions.c (struct catcher)
6962         <save_cleanup_chain>: Remove member.
6963         (exceptions_state_mc_init): Update.
6964         (exception_try_scope_entry): Return nullptr.
6965         (exception_try_scope_exit, exception_rethrow)
6966         (throw_exception_sjlj, throw_exception_cxx): Update.
6967         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6968         (all_cleanups, do_cleanups, discard_cleanups)
6969         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6970         (restore_cleanups, restore_final_cleanups): Don't declare.
6971         (do_final_cleanups): Remove parameter.
6972         * common/cleanups.c (cleanup_chain, make_cleanup)
6973         (make_cleanup_dtor, all_cleanups, do_cleanups)
6974         (discard_my_cleanups, discard_cleanups)
6975         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6976         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6977         (null_cleanup): Remove.
6978         (do_final_cleanups): Remove parameter.
6979
6980 2019-03-06  Tom Tromey  <tom@tromey.com>
6981
6982         * remote.c (remote_target::remote_parse_stop_reply): Use
6983         unique_xmalloc_ptr.
6984
6985 2019-03-06  Tom Tromey  <tom@tromey.com>
6986
6987         * stabsread.c (struct stabs_field_info): Rename from field_info.
6988         <list, fnlist>: Add initializers.
6989         <obstack>: New member.
6990         (read_member_functions, read_struct_fields, read_baseclasses):
6991         Allocate on obstack.  Don't use cleanups.
6992         (read_one_struct_field, read_member_functions, read_struct_fields)
6993         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6994         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6995         (read_struct_type): Update.
6996
6997 2019-03-06  Tom Tromey  <tom@tromey.com>
6998
6999         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7000         * common/filestuff.h (make_cleanup_close): Don't declare.
7001         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7002         Remove.
7003
7004 2019-03-06  Tom Tromey  <tom@tromey.com>
7005
7006         * solib-aix.c: Use make_scope_exit.
7007
7008 2019-03-06  Tom Tromey  <tom@tromey.com>
7009
7010         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7011         Use make_scope_exit.
7012
7013 2019-03-06  Tom Tromey  <tom@tromey.com>
7014
7015         * solib-svr4.c (disable_probes_interface): Remove parameter.
7016         (svr4_handle_solib_event): Use make_scope_exit.
7017
7018 2019-03-06  Tom Tromey  <tom@tromey.com>
7019
7020         * remote.c (struct stop_reply_deleter): Remove.
7021         (stop_reply_up): Update.
7022         (struct stop_reply): Derive from notif_event.  Don't typedef.
7023         <regcache>: Now a std::vector.
7024         (stop_reply_xfree): Remove.
7025         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7026         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7027         (remote_target::discard_pending_stop_replies): Use delete.
7028         (remote_target::remote_parse_stop_reply): Update.
7029         (remote_target::process_stop_reply): Update.
7030         * remote-notif.h (struct notif_event): Add virtual destructor.
7031         Remove "dtr" member.
7032         (struct notif_client) <alloc_event>: Return a unique_ptr.
7033         (notif_event_xfree): Don't declare.
7034         (notif_event_up): New typedef.
7035         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7036         (notif_event_xfree, do_notif_event_xfree): Remove.
7037         (remote_notif_state_xfree): Update.
7038
7039 2019-03-06  Tom Tromey  <tom@tromey.com>
7040
7041         * infrun.c (displaced_step_clear_cleanup): Now a
7042         forward_scope_exit type.
7043         (displaced_step_prepare_throw): Update.
7044         (displaced_step_fixup): Update.
7045
7046 2019-03-06  Tom Tromey  <tom@tromey.com>
7047
7048         * inferior.h (class inferior): Update comment.
7049         * gdbthread.h (class thread_info): Update comment.
7050
7051 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7052             Tom Tromey  <tom@tromey.com>
7053
7054         * stabsread.h (struct stab_section_list): Remove.
7055         (coffstab_build_psymtabs): Update.
7056         * dbxread.c (symbuf_sections): Now a std::vector.
7057         (sect_idx): New global.
7058         (fill_symbuf): Update.
7059         (coffstab_build_psymtabs): Change type of stabsects parameter.
7060         Update.
7061         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7062         std::vector.
7063         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7064         (coff_locate_sections): Update.
7065         (coff_symfile_read): Remove cleanups.  Update.
7066         (init_stringtab): Add storage parameter.
7067         (free_stringtab, free_stringtab_cleanup): Remove.
7068         (init_lineno): Add storage parameter.
7069         (free_linetab, free_linetab_cleanup): Remove.
7070
7071 2019-03-06  Pedro Alves  <palves@redhat.com>
7072
7073         * linux-fork.c (fork_info::clobber_regs): Delete.
7074         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7075         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7076         comment.  Adjust.
7077         (scoped_switch_fork_info::scoped_switch_fork_info)
7078         (checkpoint_command, linux_fork_context): Adjust
7079         fork_save_infrun_state calls.
7080
7081 2019-03-06  Pedro Alves  <palves@redhat.com>
7082
7083         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7084         (inf_has_multiple_threads): Return 'bool' and rewrite using
7085         inferior_info::threads().
7086
7087 2019-03-06  Pedro Alves  <palves@redhat.com>
7088
7089         * linux-fork.c: Include <list>.
7090         (fork_list): Now a std::list instance.
7091         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7092         (forks_exist_p, find_last_fork): Adjust.
7093         (new_fork): Delete.
7094         (one_fork_p): New.
7095         (add_fork): Adjust.
7096         (free_fork): Delete, folded into fork_info::~fork_info().
7097         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7098         Adjust.
7099         (init_fork_list): Delete.
7100         (linux_fork_killall, linux_fork_mourn_inferior)
7101         (linux_fork_detach, info_checkpoints_command): Adjust.
7102         (_initialize_linux_fork): No longer call init_fork_list.
7103
7104 2019-03-06  Pedro Alves  <palves@redhat.com>
7105
7106         * linux-fork.c (new_fork): New, split out of ...
7107         (add_fork): ... this.  Return void.  Move "first fork" special
7108         case from here, to ...
7109         (checkpoint_command): ... here.
7110         * linux-linux.h (add_fork): Return void.
7111
7112 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7115
7116 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7117             Chris January  <chris.january@arm.com>
7118             David Lecomber  <david.lecomber@arm.com>
7119
7120         * f-exp.y: New token, UNOP_INTRINSIC.
7121         (exp): New pattern using UNOP_INTRINSIC token.
7122         (f77_keywords): Add 'abs' keyword.
7123         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7124         (value_from_host_double): New function.
7125         (evaluate_subexp_f): Support UNOP_ABS.
7126
7127 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7128
7129         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7130         types.
7131
7132 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7133
7134         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7135         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7136         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7137
7138 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7139
7140         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7141
7142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7143             Chris January  <chris.january@arm.com>
7144
7145         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7146         * f-exp.y: Define 'KIND' token.
7147         (exp): New pattern for KIND expressions.
7148         (ptype): Handle types with a kind extension.
7149         (direct_abs_decl): Extend to spot kind extensions.
7150         (f77_keywords): Add 'kind' to the list.
7151         (push_kind_type): New function.
7152         (convert_to_kind_type): New function.
7153         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7154         * parse.c (operator_length_standard): Likewise.
7155         * parser-defs.h (enum type_pieces): Add tp_kind.
7156         * std-operator.def: Add UNOP_KIND.
7157
7158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7159
7160         * f-exp.y (f_parse): Set yydebug.
7161
7162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7163
7164         * f-lang.c (evaluate_subexp_f): New function.
7165         (exp_descriptor_f): New global.
7166         (f_language_defn): Use exp_descriptor_f instead of
7167         exp_descriptor_standard.
7168
7169 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7170
7171         * f-exp.y (struct token): Add comments.
7172         (dot_ops): Remove uppercase versions and the end marker.
7173         (f77_keywords): Likewise.
7174         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7175         entries in the dot_ops array are case insensitive, and use
7176         strncasecmp to compare strings.  Also some whitespace cleanup in
7177         this area.  Similar for the f77_keywords array, except entries in
7178         this list might be case sensitive.
7179
7180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7181
7182         * f-exp.y (struct f77_boolean_val): Add comments.
7183         (boolean_values): Remove uppercase versions, and end marker.
7184         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7185         and use strncasecmp to achieve case insensitivity.  Additionally,
7186         perform whitespace cleanup around this code.
7187
7188 2019-03-06  Tom Tromey  <tromey@adacore.com>
7189
7190         * remote-sim.c (gdbsim_target_open): Use result of
7191         gdb_argv::release.
7192
7193 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7194         Dirk Schubert  <dirk.schubert@arm.com>
7195         Chris January  <chris.january@arm.com>
7196
7197         * eval.c (evaluate_subexp_standard): Call Fortran argument
7198         wrapping logic.
7199         * f-lang.c (struct value): A value which can be passed into a
7200         Fortran function call.
7201         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7202         where appropriate.
7203         (struct type): Value ready for a Fortran function call.
7204         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7205         is needed.
7206         * f-lang.h (fortran_argument_convert): Declaration.
7207         (fortran_preserve_arg_pointer): Declaration.
7208         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7209
7210 2019-03-05  Tom Tromey  <tromey@adacore.com>
7211
7212         * python/py-prettyprint.c (print_string_repr): Remove #if.
7213         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7214
7215 2019-03-05  Tom Tromey  <tromey@adacore.com>
7216
7217         * target.c (the_dummy_target): Move later.  Change type to
7218         "dummy_target".
7219         (initialize_targets): Don't initialize the_dummy_target.
7220
7221 2019-03-05  Tom Tromey  <tromey@adacore.com>
7222
7223         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7224         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7225
7226 2019-03-05  Tom Tromey  <tromey@adacore.com>
7227
7228         * windows-nat.c (windows_nat_target::attach)
7229         (windows_nat_target::detach): Don't call gdb_flush.
7230         * valprint.c (generic_val_print, val_print, val_print_string):
7231         Don't call gdb_flush.
7232         * utils.c (defaulted_query): Don't call gdb_flush.
7233         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7234         * target.c (target_announce_detach): Don't call gdb_flush.
7235         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7236         * remote.c (extended_remote_target::attach): Don't call
7237         gdb_flush.
7238         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7239         * printcmd.c (do_examine): Don't call gdb_flush.
7240         (info_display_command): Don't call gdb_flush.
7241         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7242         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7243         * memattr.c (info_mem_command): Don't call gdb_flush.
7244         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7245         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7246         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7247         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7248         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7249         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7250         (gnu_nat_target::detach): Don't call gdb_flush.
7251         * f-valprint.c (f_val_print): Don't call gdb_flush.
7252         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7253         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7254         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7255         gdb_flush.
7256         * c-valprint.c (c_val_print): Don't call gdb_flush.
7257         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7258
7259 2019-03-05  Tom Tromey  <tromey@adacore.com>
7260
7261         * varobj.c (update_dynamic_varobj_children): Update.
7262         (install_default_visualizer): Use reset, not release.
7263         * value.c (set_internalvar): Update.
7264         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7265         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7266         ATTRIBUTE_UNUSED_RESULT.
7267
7268 2019-03-05  Tom Tromey  <tromey@adacore.com>
7269
7270         * remote.c (class scoped_remote_fd) <release>: Add
7271         ATTRIBUTE_UNUSED_RESULT.
7272
7273 2019-03-05  Tom Tromey  <tromey@adacore.com>
7274
7275         * macroexp.c (struct macro_buffer) <release>: Add
7276         ATTRIBUTE_UNUSED_RESULT.
7277
7278 2019-03-05  Tom Tromey  <tromey@adacore.com>
7279
7280         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7281         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7282         ATTRIBUTE_UNUSED_RESULT.
7283
7284 2019-03-05  Tom Tromey  <tromey@adacore.com>
7285
7286         * common/scoped_fd.h (class scoped_fd) <release>: Add
7287         ATTRIBUTE_UNUSED_RESULT.
7288
7289 2019-03-05  Tom Tromey  <tromey@adacore.com>
7290
7291         * parser-defs.h (struct parser_state) <release>: Add
7292         ATTRIBUTE_UNUSED_RESULT.
7293
7294 2019-03-05  Tom Tromey  <tromey@adacore.com>
7295
7296         * utils.h (class gdb_argv) <release>: Add
7297         ATTRIBUTE_UNUSED_RESULT.
7298         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7299
7300 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7301
7302         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7303         for-loop range, to avoid compiler warnings.
7304
7305         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7306         avoid compiler warnings about unused variables.
7307
7308         * NEWS: Mention end of support for native debugging on MS-Windows
7309         before XP.
7310
7311         PR gdb/24292
7312         * common/netstuff.c:
7313         * gdbserver/gdbreplay.c
7314         * gdbserver/remote-utils.c:
7315         * ser-tcp.c:
7316         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7317         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7318         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7319         'getaddrinfo' and 'freeaddrinfo' were not available before
7320         Windows XP, and mingw.org's MinGW headers by default define
7321         _WIN32_WINNT to 0x500.
7322
7323 2019-03-01  Gary Benson <gbenson@redhat.com>
7324
7325         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7326
7327 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7328             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7329
7330         PR gdb/8527
7331         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7332         set_sigint_trap, clear_sigint_trap.
7333
7334 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7335
7336         * target.c (target_detach): Clear the regcache and the
7337         frame cache.
7338
7339 2019-02-27  Pedro Alves  <palves@redhat.com>
7340
7341         * utils.c (set_screen_size): When we cap the height/width sizes,
7342         tweak the corresponding command variable to show "unlimited":
7343
7344 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7345             Pedro Alves  <palves@redhat.com>
7346
7347         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7348         before calling rl_set_screen_size.
7349
7350 2019-02-27  Tom Tromey  <tromey@adacore.com>
7351
7352         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7353         define.
7354         * python/py-value.c: Remove Python 2.4 workaround.
7355         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7356         workaround.
7357         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7358         Python 2.4 workaround.
7359         * python/python-internal.h: Remove Python 2.4 comment.
7360         (Py_ssize_t): Don't define.
7361         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7362         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7363         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7364         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7365         * python/python.c (do_start_initialization): Remove Python 2.4
7366         workaround.
7367         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7368         (print_children): Remove Python 2.4 workaround.
7369         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7370         workaround.
7371         (CHARBUFFERPROC_NAME): Remove.
7372         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7373         Python 2.4 workaround.
7374
7375 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7376
7377         * NEWS: Note minimum Python version.
7378
7379 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7380
7381         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7382         code from these functions.  Remove corresponding ifdefs.  Use
7383         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7384         Remove gotos and target of gotos.
7385         (infpy_search_memory): Likewise.
7386
7387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7388
7389         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7390         (hppa_gdbarch_init): Don't register deleted functions with
7391         gdbarch.
7392
7393 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7394
7395         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7396         (h8300_unwind_sp): Delete.
7397         (h8300_dummy_id): Delete.
7398         (h8300_gdbarch_init): Don't register deleted functions with
7399         gdbarch.
7400
7401 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7402
7403         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7404         (ft32_unwind_pc): Delete.
7405         (ft32_unwind_sp): Delete.
7406         (ft32_gdbarch_init): Don't register deleted functions with
7407         gdbarch.
7408
7409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7410
7411         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7412         (frv_unwind_pc): Delete.
7413         (frv_unwind_sp): Delete.
7414         (frv_gdbarch_init): Don't register deleted functions with
7415         gdbarch.
7416
7417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7418
7419         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7420         (riscv_unwind_pc): Delete.
7421         (riscv_unwind_sp): Delete.
7422         (riscv_gdbarch_init): Don't register deleted functions with
7423         gdbarch.
7424
7425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7426
7427         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7428         (csky_unwind_pc): Delete.
7429         (csky_unwind_sp): Delete.
7430         (csky_gdbarch_init): Don't register deleted functions with
7431         gdbarch.
7432
7433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7434
7435         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7436         (cris_unwind_pc): Delete.
7437         (cris_unwind_sp): Delete.
7438         (cris_gdbarch_init): Don't register deleted functions with
7439         gdbarch.
7440
7441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7442
7443         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7444         (bfin_unwind_pc): Delete.
7445         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7446
7447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7450         (arm_unwind_pc): Delete.
7451         (arm_unwind_sp): Delete.
7452         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7453
7454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7457         (arc_unwind_pc): Delete.
7458         (arc_unwind_sp): Delete.
7459         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7460
7461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7462
7463         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7464         (alpha_unwind_pc): Delete.
7465         (alpha_gdbarch_init): Don't register deleted functions with
7466         gdbarch.
7467
7468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7469
7470         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7471         (aarch64_unwind_pc): Delete.
7472         (aarch64_unwind_sp): Delete.
7473         (aarch64_gdbarch_init): Don't register deleted functions with
7474         gdbarch.
7475
7476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * gdbtypes.c (type_align): Don't consider static members when
7479         computing structure alignment.
7480
7481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7484         return 0 for other types.
7485         * arch-utils.c (default_type_align): Always return 0.
7486         * gdbarch.h: Regenerate.
7487         * gdbarch.sh (type_align): Extend comment.
7488         * gdbtypes.c (type_align): Add additional comments, always call
7489         gdbarch_type_align before applying the default rules.
7490         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7491         generic code will then apply a suitable default.
7492         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7493         types, return 0 for other types.
7494
7495 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7496
7497         * NEWS: Create a new section for the next release branch.
7498         Rename the section of the current branch, now that it has
7499         been cut.
7500
7501 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7502
7503         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7504         * version.in: Bump version to 8.3.50.DATE-git.
7505
7506 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7507
7508         * aix-thread.c (ptid_cmp): Remove unused variable.
7509         (get_signaled_thread): Likewise.
7510         (store_regs_user_thread): Likewise.
7511         (store_regs_kernel_thread): Likewise.
7512         (fetch_regs_kernel_thread): Remove shadowed variable.
7513
7514 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * features/riscv/32bit-cpu.xml: Add register numbers.
7517         * features/riscv/32bit-fpu.c: Regenerate.
7518         * features/riscv/32bit-fpu.xml: Add register numbers.
7519         * features/riscv/64bit-cpu.xml: Add register numbers.
7520         * features/riscv/64bit-fpu.c: Regenerate.
7521         * features/riscv/64bit-fpu.xml: Add register numbers.
7522
7523 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7524
7525         * NEWS: Mention two argument form of gdb.Value constructor.
7526         * python/py-value.c (convert_buffer_and_type_to_value): New
7527         function.
7528         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7529         Add support for handling an optional second argument.  Call
7530         convert_buffer_and_type_to_value as appropriate.
7531         * python/python-internal.h (Py_buffer_deleter): New struct.
7532         (Py_buffer_up): New typedef.
7533
7534 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7535
7536         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7537         instead of releasing ownership.
7538
7539 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7540
7541         * dwarf2read.c (open_and_init_dwp_file): Call
7542         elf_numsections instead of bfd_count_sections to initialize
7543         dwp_file->num_sections.
7544
7545 2019-02-25  Tom Tromey  <tromey@adacore.com>
7546
7547         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7548
7549 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7550
7551         * gcore.in: Add '--readnever' option when invoking GDB.
7552
7553 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7554
7555         * MAINTAINERS: Update my email address.
7556
7557 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7558
7559         * build-id.c (build_id_to_debug_bfd_1): New function.
7560         (build_id_to_debug_bfd): Look for separate debug file in
7561         sysroot.
7562
7563 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * gdbarch.sh: Update the copyright year range that is placed into
7566         generated files.
7567
7568 2019-02-22  Keith Seitz  <keiths@redhat.com>
7569
7570         PR symtab/23853
7571         * linespec.c (create_sals_line_offset): Search for the default
7572         symtab's filename instead of its fullname.
7573
7574 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7575
7576         * NEWS: Update style defaults.
7577
7578 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7579
7580         * main.c (captured_main_1): Disable styling in batch mode.
7581
7582 2019-02-20  Tom Tromey  <tom@tromey.com>
7583
7584         * symtab.c (symtab_symbol_info): Fix typos.
7585
7586 2019-02-20  Tom Tromey  <tromey@adacore.com>
7587
7588         * findcmd.c (_initialize_mem_search): Use upper case for
7589         metasyntactic variables.
7590
7591 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7592
7593         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7594         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7595
7596 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7597
7598         * top.h (source_file_name): Change to std::string.
7599         * top.c (source_file_name): Likewise.
7600         (command_line_input): Adjust.
7601         * cli/cli-script.c (script_from_file): Adjust.
7602
7603 2019-02-19  Tom Tromey  <tromey@adacore.com>
7604
7605         * ravenscar-thread.c
7606         (ravenscar_thread_target::update_thread_list): Don't call
7607         ada_build_task_list.
7608         * ada-lang.h (ada_build_task_list): Don't declare.
7609         * ada-tasks.c (struct ada_tasks_inferior_data)
7610         <task_list_valid_p>: Now bool.
7611         (read_known_tasks, ada_task_list_changed)
7612         (ada_tasks_invalidate_inferior_data): Update.
7613         (read_known_tasks_array): Return bool.
7614         (read_known_tasks_list): Likewise.
7615         (read_known_tasks): Return void.
7616         (ada_build_task_list): Now static.
7617
7618 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7619
7620         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7621         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7622
7623 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7624
7625         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7626         variant for ada_tasks_pspace_data_handle and
7627         ada_tasks_inferior_data_handle.
7628         (ada_tasks_pspace_data_cleanup): New function.
7629         (ada_tasks_inferior_data_cleanup): New function.
7630
7631 2019-02-17  Tom Tromey  <tom@tromey.com>
7632
7633         * macrotab.h (macro_source_fullname): Return a std::string.
7634         * macrotab.c (macro_include, check_for_redefinition)
7635         (macro_undef, macro_lookup_definition, foreach_macro)
7636         (foreach_macro_in_scope): Update.
7637         (macro_source_fullname): Return a std::string.
7638         * macrocmd.c (show_pp_source_pos): Update.
7639
7640 2019-02-17  Tom Tromey  <tom@tromey.com>
7641
7642         * macrocmd.c (show_pp_source_pos): Style the file names.
7643
7644 2019-02-17  Tom Tromey  <tom@tromey.com>
7645
7646         PR tui/24197:
7647         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7648
7649 2019-02-17  Tom Tromey  <tom@tromey.com>
7650
7651         * ada-lang.c (user_select_syms): Use filtered printing.
7652         * utils.c (wrap_style): New global.
7653         (desired_style): Remove.
7654         (emit_style_escape): Add stream parameter.
7655         (set_output_style, reset_terminal_style, prompt_for_continue):
7656         Update.
7657         (flush_wrap_buffer): Only flush gdb_stdout.
7658         (wrap_here): Set wrap_style.
7659         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7660         treat escape sequences as a character.  Change when wrap buffer is
7661         flushed.
7662         (fputs_styled): Do not set the output style when the default is
7663         requested.
7664         * ui-style.h (struct ui_file_style) <is_default>: New method.
7665         * source.c (print_source_lines_base): Emit escape sequences in one
7666         piece.
7667
7668 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7669
7670         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7671         integers and enumeration types.
7672
7673 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7674
7675         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7676         instead of lookup_symbol_in_language
7677         (do_exact_match): New function.
7678         (ada_get_symbol_name_matcher): Return do_exact_match when
7679         doing a verbatim match.
7680
7681 2019-02-15  Tom Tromey  <tromey@adacore.com>
7682
7683         * ravenscar-thread.c (ravenscar_thread_target::resume)
7684         (ravenscar_thread_target::wait): Special case wildcard requests.
7685
7686 2019-02-15  Tom Tromey  <tromey@adacore.com>
7687
7688         * ravenscar-thread.c (base_ptid): Remove.
7689         (struct ravenscar_thread_target) <close>: New method.
7690         <m_base_ptid>: New member.
7691         <update_inferior_ptid, active_task, task_is_currently_active,
7692         runtime_initialized>: Declare methods.
7693         <ravenscar_thread_target>: Add constructor.
7694         (ravenscar_thread_target::task_is_currently_active)
7695         (ravenscar_thread_target::update_inferior_ptid)
7696         (ravenscar_runtime_initialized): Rename.  Now methods.
7697         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7698         (ravenscar_thread_target::update_thread_list): Update.
7699         (ravenscar_thread_target::active_task): Now method.
7700         (ravenscar_thread_target::store_registers)
7701         (ravenscar_thread_target::prepare_to_store)
7702         (ravenscar_thread_target::prepare_to_store)
7703         (ravenscar_thread_target::mourn_inferior): Update.
7704         (ravenscar_inferior_created): Use "new" to create target.
7705         (ravenscar_thread_target::get_ada_task_ptid): Update.
7706         (_initialize_ravenscar): Don't initialize base_ptid.
7707         (ravenscar_ops): Remove global.
7708
7709 2019-02-15  Tom Tromey  <tromey@adacore.com>
7710
7711         * target.h (push_target): Declare new overload.
7712         * target.c (push_target): New overload, taking an rvalue reference.
7713         * remote.c (remote_target::open_1): Use push_target overload.
7714         * corelow.c (core_target_open): Use push_target overload.
7715
7716 2019-02-15  Tom Tromey  <tromey@adacore.com>
7717
7718         * ravenscar-thread.c (is_ravenscar_task)
7719         (ravenscar_task_is_currently_active): Return bool.
7720         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7721         (_initialize_ravenscar): Remove "(void)".
7722         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7723         Return bool.
7724
7725 2019-02-15  Tom Tromey  <tromey@adacore.com>
7726
7727         * ravenscar-thread.c (ravenscar_runtime_initializer)
7728         (has_ravenscar_runtime, get_running_thread_id)
7729         (ravenscar_thread_target::resume): Fix indentation.
7730
7731 2019-02-15  Tom Tromey  <tromey@adacore.com>
7732
7733         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7734         from ravenscar_arch_ops.
7735         (sparc_ravenscar_ops::fetch_registers)
7736         (sparc_ravenscar_ops::store_registers): Now methods.
7737         (sparc_ravenscar_prepare_to_store): Remove.
7738         (sparc_ravenscar_ops): Redefine.
7739         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7740         methods and destructor.  Remove members.
7741         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7742         (ravenscar_thread_target::store_registers)
7743         (ravenscar_thread_target::prepare_to_store): Update.
7744         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7745         Remove.
7746         (struct ppc_ravenscar_powerpc_ops): Derive from
7747         ravenscar_arch_ops.
7748         (ppc_ravenscar_powerpc_ops::fetch_registers)
7749         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7750         (ppc_ravenscar_powerpc_ops): Redefine.
7751         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7752         (ppc_ravenscar_e500_ops::fetch_registers)
7753         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7754         (ppc_ravenscar_e500_ops): Redefine.
7755         * aarch64-ravenscar-thread.c
7756         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7757         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7758         (aarch64_ravenscar_fetch_registers)
7759         (aarch64_ravenscar_store_registers): Now methods.
7760         (aarch64_ravenscar_ops): Redefine.
7761
7762 2019-02-15  Tom Tromey  <tromey@adacore.com>
7763
7764         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7765         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7766         (ravenscar_thread_target::stopped_by_watchpoint)
7767         (ravenscar_thread_target::stopped_data_address)
7768         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7769
7770 2019-02-15  Tom Tromey  <tromey@adacore.com>
7771
7772         * ravenscar-thread.c: Fix some typos.
7773
7774 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7775             Tom Tromey  <tromey@adacore.com>
7776
7777         * ada-lang.c (ada_exception_sal): Change addr_string to a
7778         std::string.
7779         (create_ada_exception_catchpoint): Update.
7780
7781 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7782             Tom Tromey  <tromey@adacore.com>
7783
7784         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7785         (bp_location_ops): Remove.
7786         (base_breakpoint_allocate_location): Update.
7787         (free_bp_location): Update.
7788         * ada-lang.c (class ada_catchpoint_location)
7789         <ada_catchpoint_location>: Remove ops parameter.
7790         (ada_catchpoint_location_dtor): Remove.
7791         (ada_catchpoint_location_ops): Remove.
7792         (allocate_location_exception): Update.
7793         * breakpoint.h (struct bp_location_ops): Remove.
7794         (class bp_location) <bp_location>: Remove bp_location_ops
7795         parameter.
7796         <~bp_location>: Add destructor.
7797         <ops>: Remove.
7798
7799 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7800             Pedro Alves  <palves@redhat.com>
7801
7802         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7803         'PATH_MAX'.
7804
7805 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7806             Samuel Thibault  <samuel.thibault@gnu.org>
7807             Thomas Schwinge  <thomas@codesourcery.com>
7808
7809         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7810         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7811
7812 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7813
7814         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7815         (check_empty): Use "const char *".
7816
7817         * gnu-nat.c (gnu_nat_target::detach): Instead of
7818         'detach_inferior (pid)' call
7819         'detach_inferior (find_inferior_pid (pid))'.
7820
7821         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7822         'nat/fork-inferior.o'.
7823         * gnu-nat.c: #include "nat/fork-inferior.h".
7824
7825         * gnu-nat.c (gnu_nat_target::detach): Instead of
7826         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7827         * gnu-nat.h: #include "inf-child.h".
7828         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7829         'i386_gnu_nat_target::fetch_registers'.
7830         (gnu_store_registers): Rename/move to
7831         'i386_gnu_nat_target::store_registers'.
7832
7833         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7834         * gnu-nat.h (mach_thread_info): New function.
7835         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7836
7837         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7838
7839 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7840
7841         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7842
7843 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7844
7845         * windows-nat.c (windows_add_thread): Add new parameter
7846         "main_thread_p" with default value set to false.  Update
7847         function documentation as well as all callers.
7848         (windows_delete_thread): Likewise.
7849         (fake_create_process): Update call to windows_add_thread.
7850         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7851         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7852         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7853         call to windows_delete_thread.
7854
7855 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7856
7857         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7858
7859 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7860
7861         * symfile.c (find_separate_debug_file): Use canonical path of
7862         sysroot with child_path instead of gdb_sysroot if it is valid.
7863
7864 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7865
7866         * symfile.c (find_separate_debug_file): Use child_path to
7867         determine if an object file is under a sysroot.
7868
7869 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7870
7871         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7872         unittests/child-path-selftests.c.
7873         * common/pathstuff.c (child_path): New function.
7874         * common/pathstuff.h (child_path): New prototype.
7875         * unittests/child-path-selftests.c: New file.
7876
7877 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7878
7879         * symfile.c (find_separate_debug_file): Look for separate debug
7880         files in debug directories under the sysroot.
7881
7882 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7883
7884         * symtab.h (struct minimal_symbol data_p): New const method.
7885         (struct minimal_symbol text_p): Likewise.
7886         * symtab.c (output_source_filename): Use file name style
7887         to print file name.
7888         (print_symbol_info): Likewise.
7889         (print_msymbol_info): Use address style to print addresses.
7890         Use function name style to print executable text symbols.
7891         (expand_symtab_containing_pc): Use data_p.
7892         (find_pc_sect_compunit_symtab): Likewise.
7893
7894 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7895
7896         * breakpoint.c (describe_other_breakpoints): Use address style
7897         to print addresses.
7898         (say_where): Likewise.
7899
7900 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7901
7902         * ada-typeprint.c (print_func_type): Print function name
7903         style to print function name.
7904         * c-typeprint.c (c_print_type_1): Likewise.
7905
7906 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7907
7908         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7909         for execve.
7910
7911 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7912
7913         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7914         type_stack.
7915
7916 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7917
7918         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7919         TYPE_CODE_REF types.
7920
7921 2019-02-08  Jim Wilson  <jimw@sifive.com>
7922
7923         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7924         (riscv_linux_fregset): New.
7925         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7926
7927 2019-02-07  Tom Tromey  <tom@tromey.com>
7928
7929         * thread.c (thread_cancel_execution_command): Update.
7930         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7931         methods.
7932         (struct thread_fsm_ops): Remove.
7933         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7934         (thread_fsm_should_stop, thread_fsm_return_value)
7935         (thread_fsm_set_finished, thread_fsm_finished_p)
7936         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7937         Don't declare.
7938         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7939         * infrun.c (clear_proceed_status_thread)
7940         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7941         (print_stop_event): Update.
7942         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7943         Add constructor.
7944         (step_command_fsm_ops): Remove.
7945         (new_step_command_fsm): Remove.
7946         (step_1): Update.
7947         (step_command_fsm::should_stop): Rename from
7948         step_command_fsm_should_stop.
7949         (step_command_fsm::clean_up): Rename from
7950         step_command_fsm_clean_up.
7951         (step_command_fsm::do_async_reply_reason): Rename from
7952         step_command_fsm_async_reply_reason.
7953         (struct until_next_fsm): Inherit from thread_fsm.  Add
7954         constructor.
7955         (until_next_fsm_ops): Remove.
7956         (new_until_next_fsm): Remove.
7957         (until_next_fsm::should_stop): Rename from
7958         until_next_fsm_should_stop.
7959         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7960         (until_next_fsm::do_async_reply_reason): Rename from
7961         until_next_fsm_async_reply_reason.
7962         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7963         constructor.  Change type of breakpoint.
7964         (finish_command_fsm_ops): Remove.
7965         (new_finish_command_fsm): Remove.
7966         (finish_command_fsm::should_stop): Rename from
7967         finish_command_fsm_should_stop.
7968         (finish_command_fsm::clean_up): Rename from
7969         finish_command_fsm_clean_up.
7970         (finish_command_fsm::return_value): Rename from
7971         finish_command_fsm_return_value.
7972         (finish_command_fsm::do_async_reply_reason): Rename from
7973         finish_command_fsm_async_reply_reason.
7974         (finish_command): Update.
7975         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7976         Add constructor.
7977         (call_thread_fsm_ops): Remove.
7978         (call_thread_fsm::call_thread_fsm): Rename from
7979         new_call_thread_fsm.
7980         (call_thread_fsm::should_stop): Rename from
7981         call_thread_fsm_should_stop.
7982         (call_thread_fsm::should_notify_stop): Rename from
7983         call_thread_fsm_should_notify_stop.
7984         (run_inferior_call, call_function_by_hand_dummy): Update.
7985         * cli/cli-interp.c (should_print_stop_to_console): Update.
7986         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7987         Add constructor.  Change type of location_breakpoint,
7988         caller_breakpoint.
7989         (until_break_fsm_ops): Remove.
7990         (new_until_break_fsm): Remove.
7991         (until_break_fsm::should_stop): Rename from
7992         until_break_fsm_should_stop.
7993         (until_break_fsm::clean_up): Rename from
7994         until_break_fsm_clean_up.
7995         (until_break_fsm::do_async_reply_reason): Rename from
7996         until_break_fsm_async_reply_reason.
7997         (until_break_command): Update.
7998         * thread-fsm.c: Remove.
7999         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8000
8001 2019-02-07  Tom Tromey  <tom@tromey.com>
8002
8003         * yy-remap.h: Add include guard.
8004         * xtensa-tdep.h: Add include guard.
8005         * xcoffread.h: Rename include guard.
8006         * varobj-iter.h: Add include guard.
8007         * tui/tui.h: Rename include guard.
8008         * tui/tui-winsource.h: Rename include guard.
8009         * tui/tui-wingeneral.h: Rename include guard.
8010         * tui/tui-windata.h: Rename include guard.
8011         * tui/tui-win.h: Rename include guard.
8012         * tui/tui-stack.h: Rename include guard.
8013         * tui/tui-source.h: Rename include guard.
8014         * tui/tui-regs.h: Rename include guard.
8015         * tui/tui-out.h: Rename include guard.
8016         * tui/tui-layout.h: Rename include guard.
8017         * tui/tui-io.h: Rename include guard.
8018         * tui/tui-hooks.h: Rename include guard.
8019         * tui/tui-file.h: Rename include guard.
8020         * tui/tui-disasm.h: Rename include guard.
8021         * tui/tui-data.h: Rename include guard.
8022         * tui/tui-command.h: Rename include guard.
8023         * tic6x-tdep.h: Add include guard.
8024         * target/waitstatus.h: Rename include guard.
8025         * target/wait.h: Rename include guard.
8026         * target/target.h: Rename include guard.
8027         * target/resume.h: Rename include guard.
8028         * target-float.h: Rename include guard.
8029         * stabsread.h: Add include guard.
8030         * rs6000-tdep.h: Add include guard.
8031         * riscv-fbsd-tdep.h: Add include guard.
8032         * regformats/regdef.h: Rename include guard.
8033         * record.h: Rename include guard.
8034         * python/python.h: Rename include guard.
8035         * python/python-internal.h: Rename include guard.
8036         * python/py-stopevent.h: Rename include guard.
8037         * python/py-ref.h: Rename include guard.
8038         * python/py-record.h: Rename include guard.
8039         * python/py-record-full.h: Rename include guard.
8040         * python/py-record-btrace.h: Rename include guard.
8041         * python/py-instruction.h: Rename include guard.
8042         * python/py-events.h: Rename include guard.
8043         * python/py-event.h: Rename include guard.
8044         * procfs.h: Add include guard.
8045         * proc-utils.h: Add include guard.
8046         * p-lang.h: Add include guard.
8047         * or1k-tdep.h: Rename include guard.
8048         * observable.h: Rename include guard.
8049         * nto-tdep.h: Rename include guard.
8050         * nat/x86-linux.h: Rename include guard.
8051         * nat/x86-linux-dregs.h: Rename include guard.
8052         * nat/x86-gcc-cpuid.h: Add include guard.
8053         * nat/x86-dregs.h: Rename include guard.
8054         * nat/x86-cpuid.h: Rename include guard.
8055         * nat/ppc-linux.h: Rename include guard.
8056         * nat/mips-linux-watch.h: Rename include guard.
8057         * nat/linux-waitpid.h: Rename include guard.
8058         * nat/linux-ptrace.h: Rename include guard.
8059         * nat/linux-procfs.h: Rename include guard.
8060         * nat/linux-osdata.h: Rename include guard.
8061         * nat/linux-nat.h: Rename include guard.
8062         * nat/linux-namespaces.h: Rename include guard.
8063         * nat/linux-btrace.h: Rename include guard.
8064         * nat/glibc_thread_db.h: Rename include guard.
8065         * nat/gdb_thread_db.h: Rename include guard.
8066         * nat/gdb_ptrace.h: Rename include guard.
8067         * nat/fork-inferior.h: Rename include guard.
8068         * nat/amd64-linux-siginfo.h: Rename include guard.
8069         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8070         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8071         * nat/aarch64-linux.h: Rename include guard.
8072         * nat/aarch64-linux-hw-point.h: Rename include guard.
8073         * mn10300-tdep.h: Add include guard.
8074         * mips-linux-tdep.h: Add include guard.
8075         * mi/mi-parse.h: Rename include guard.
8076         * mi/mi-out.h: Rename include guard.
8077         * mi/mi-main.h: Rename include guard.
8078         * mi/mi-interp.h: Rename include guard.
8079         * mi/mi-getopt.h: Rename include guard.
8080         * mi/mi-console.h: Rename include guard.
8081         * mi/mi-common.h: Rename include guard.
8082         * mi/mi-cmds.h: Rename include guard.
8083         * mi/mi-cmd-break.h: Rename include guard.
8084         * m2-lang.h: Add include guard.
8085         * location.h: Rename include guard.
8086         * linux-record.h: Rename include guard.
8087         * linux-nat.h: Add include guard.
8088         * linux-fork.h: Add include guard.
8089         * i386-darwin-tdep.h: Rename include guard.
8090         * hppa-linux-offsets.h: Add include guard.
8091         * guile/guile.h: Rename include guard.
8092         * guile/guile-internal.h: Rename include guard.
8093         * gnu-nat.h: Rename include guard.
8094         * gdb-stabs.h: Rename include guard.
8095         * frv-tdep.h: Add include guard.
8096         * f-lang.h: Add include guard.
8097         * event-loop.h: Add include guard.
8098         * darwin-nat.h: Rename include guard.
8099         * cp-abi.h: Rename include guard.
8100         * config/sparc/nm-sol2.h: Rename include guard.
8101         * config/nm-nto.h: Rename include guard.
8102         * config/nm-linux.h: Add include guard.
8103         * config/i386/nm-i386gnu.h: Rename include guard.
8104         * config/djgpp/nl_types.h: Rename include guard.
8105         * config/djgpp/langinfo.h: Rename include guard.
8106         * compile/gcc-cp-plugin.h: Add include guard.
8107         * compile/gcc-c-plugin.h: Add include guard.
8108         * compile/compile.h: Rename include guard.
8109         * compile/compile-object-run.h: Rename include guard.
8110         * compile/compile-object-load.h: Rename include guard.
8111         * compile/compile-internal.h: Rename include guard.
8112         * compile/compile-cplus.h: Rename include guard.
8113         * compile/compile-c.h: Rename include guard.
8114         * common/xml-utils.h: Rename include guard.
8115         * common/x86-xstate.h: Rename include guard.
8116         * common/version.h: Rename include guard.
8117         * common/vec.h: Rename include guard.
8118         * common/tdesc.h: Rename include guard.
8119         * common/selftest.h: Rename include guard.
8120         * common/scoped_restore.h: Rename include guard.
8121         * common/scoped_mmap.h: Rename include guard.
8122         * common/scoped_fd.h: Rename include guard.
8123         * common/safe-iterator.h: Rename include guard.
8124         * common/run-time-clock.h: Rename include guard.
8125         * common/refcounted-object.h: Rename include guard.
8126         * common/queue.h: Rename include guard.
8127         * common/ptid.h: Rename include guard.
8128         * common/print-utils.h: Rename include guard.
8129         * common/preprocessor.h: Rename include guard.
8130         * common/pathstuff.h: Rename include guard.
8131         * common/observable.h: Rename include guard.
8132         * common/netstuff.h: Rename include guard.
8133         * common/job-control.h: Rename include guard.
8134         * common/host-defs.h: Rename include guard.
8135         * common/gdb_wait.h: Rename include guard.
8136         * common/gdb_vecs.h: Rename include guard.
8137         * common/gdb_unlinker.h: Rename include guard.
8138         * common/gdb_unique_ptr.h: Rename include guard.
8139         * common/gdb_tilde_expand.h: Rename include guard.
8140         * common/gdb_sys_time.h: Rename include guard.
8141         * common/gdb_string_view.h: Rename include guard.
8142         * common/gdb_splay_tree.h: Rename include guard.
8143         * common/gdb_setjmp.h: Rename include guard.
8144         * common/gdb_ref_ptr.h: Rename include guard.
8145         * common/gdb_optional.h: Rename include guard.
8146         * common/gdb_locale.h: Rename include guard.
8147         * common/gdb_assert.h: Rename include guard.
8148         * common/filtered-iterator.h: Rename include guard.
8149         * common/filestuff.h: Rename include guard.
8150         * common/fileio.h: Rename include guard.
8151         * common/environ.h: Rename include guard.
8152         * common/common-utils.h: Rename include guard.
8153         * common/common-types.h: Rename include guard.
8154         * common/common-regcache.h: Rename include guard.
8155         * common/common-inferior.h: Rename include guard.
8156         * common/common-gdbthread.h: Rename include guard.
8157         * common/common-exceptions.h: Rename include guard.
8158         * common/common-defs.h: Rename include guard.
8159         * common/common-debug.h: Rename include guard.
8160         * common/cleanups.h: Rename include guard.
8161         * common/buffer.h: Rename include guard.
8162         * common/btrace-common.h: Rename include guard.
8163         * common/break-common.h: Rename include guard.
8164         * cli/cli-utils.h: Rename include guard.
8165         * cli/cli-style.h: Rename include guard.
8166         * cli/cli-setshow.h: Rename include guard.
8167         * cli/cli-script.h: Rename include guard.
8168         * cli/cli-interp.h: Rename include guard.
8169         * cli/cli-decode.h: Rename include guard.
8170         * cli/cli-cmds.h: Rename include guard.
8171         * charset-list.h: Add include guard.
8172         * buildsym-legacy.h: Rename include guard.
8173         * bfin-tdep.h: Add include guard.
8174         * ax.h: Rename include guard.
8175         * arm-linux-tdep.h: Add include guard.
8176         * arm-fbsd-tdep.h: Add include guard.
8177         * arch/xtensa.h: Rename include guard.
8178         * arch/tic6x.h: Add include guard.
8179         * arch/i386.h: Add include guard.
8180         * arch/arm.h: Rename include guard.
8181         * arch/arm-linux.h: Rename include guard.
8182         * arch/arm-get-next-pcs.h: Rename include guard.
8183         * arch/amd64.h: Add include guard.
8184         * arch/aarch64-insn.h: Rename include guard.
8185         * arch-utils.h: Rename include guard.
8186         * annotate.h: Add include guard.
8187         * amd64-darwin-tdep.h: Rename include guard.
8188         * aarch64-linux-tdep.h: Add include guard.
8189         * aarch64-fbsd-tdep.h: Add include guard.
8190         * aarch32-linux-nat.h: Add include guard.
8191
8192 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8193
8194         * macrotab.c (macro_define_internal): New function that
8195         factorizes macro_define_object_internal and macro_define_function
8196         code.
8197         (macro_define_object_internal): Use macro_define_internal.
8198         (macro_define_function): Likewise.
8199
8200 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8201
8202         * macrocmd.c (extract_identifier): Return
8203         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8204         callers.
8205
8206 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8207
8208         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8209
8210 2019-02-05  Tom Tromey  <tom@tromey.com>
8211
8212         * target.c (target_stack::unpush): Move assertion earlier.
8213
8214 2019-01-30  Tom Tromey  <tom@tromey.com>
8215
8216         PR python/23615:
8217         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8218         (gdbpy_parse_and_eval): Likewise.
8219         * python/python-internal.h (gdbpy_allow_threads): New class.
8220
8221 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8222
8223         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8224         (aarch64_fbsd_fpregmap): Move earlier.
8225         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8226         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8227         instead of individual calls to trad_frame_set_reg_addr.
8228         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8229         earlier.
8230         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8231         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8232         instead of individual calls to trad_frame_set_reg_addr.
8233
8234 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8235
8236         * CONTRIBUTE: Replace contribution list with wiki link.
8237
8238 2019-01-25  Tom Tromey  <tom@tromey.com>
8239
8240         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8241
8242 2019-01-25  Tom Tromey  <tom@tromey.com>
8243
8244         * xtensa-linux-nat.c: Fix common/ includes.
8245         * xml-support.h: Fix common/ includes.
8246         * xml-support.c: Fix common/ includes.
8247         * x86-linux-nat.c: Fix common/ includes.
8248         * windows-nat.c: Fix common/ includes.
8249         * varobj.h: Fix common/ includes.
8250         * varobj.c: Fix common/ includes.
8251         * value.c: Fix common/ includes.
8252         * valops.c: Fix common/ includes.
8253         * utils.c: Fix common/ includes.
8254         * unittests/xml-utils-selftests.c: Fix common/ includes.
8255         * unittests/utils-selftests.c: Fix common/ includes.
8256         * unittests/unpack-selftests.c: Fix common/ includes.
8257         * unittests/tracepoint-selftests.c: Fix common/ includes.
8258         * unittests/style-selftests.c: Fix common/ includes.
8259         * unittests/string_view-selftests.c: Fix common/ includes.
8260         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8261         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8262         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8263         * unittests/rsp-low-selftests.c: Fix common/ includes.
8264         * unittests/parse-connection-spec-selftests.c: Fix common/
8265         includes.
8266         * unittests/optional-selftests.c: Fix common/ includes.
8267         * unittests/offset-type-selftests.c: Fix common/ includes.
8268         * unittests/observable-selftests.c: Fix common/ includes.
8269         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8270         * unittests/memrange-selftests.c: Fix common/ includes.
8271         * unittests/memory-map-selftests.c: Fix common/ includes.
8272         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8273         * unittests/function-view-selftests.c: Fix common/ includes.
8274         * unittests/environ-selftests.c: Fix common/ includes.
8275         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8276         * unittests/common-utils-selftests.c: Fix common/ includes.
8277         * unittests/cli-utils-selftests.c: Fix common/ includes.
8278         * unittests/array-view-selftests.c: Fix common/ includes.
8279         * ui-file.c: Fix common/ includes.
8280         * tui/tui-io.c: Fix common/ includes.
8281         * tracepoint.h: Fix common/ includes.
8282         * tracepoint.c: Fix common/ includes.
8283         * tracefile-tfile.c: Fix common/ includes.
8284         * top.h: Fix common/ includes.
8285         * top.c: Fix common/ includes.
8286         * thread.c: Fix common/ includes.
8287         * target/waitstatus.h: Fix common/ includes.
8288         * target/waitstatus.c: Fix common/ includes.
8289         * target.h: Fix common/ includes.
8290         * target.c: Fix common/ includes.
8291         * target-memory.c: Fix common/ includes.
8292         * target-descriptions.c: Fix common/ includes.
8293         * symtab.h: Fix common/ includes.
8294         * symfile.c: Fix common/ includes.
8295         * stap-probe.c: Fix common/ includes.
8296         * spu-linux-nat.c: Fix common/ includes.
8297         * sparc-nat.c: Fix common/ includes.
8298         * source.c: Fix common/ includes.
8299         * solib.c: Fix common/ includes.
8300         * solib-target.c: Fix common/ includes.
8301         * ser-unix.c: Fix common/ includes.
8302         * ser-tcp.c: Fix common/ includes.
8303         * ser-pipe.c: Fix common/ includes.
8304         * ser-base.c: Fix common/ includes.
8305         * selftest-arch.c: Fix common/ includes.
8306         * s12z-tdep.c: Fix common/ includes.
8307         * rust-exp.y: Fix common/ includes.
8308         * rs6000-aix-tdep.c: Fix common/ includes.
8309         * riscv-tdep.c: Fix common/ includes.
8310         * remote.c: Fix common/ includes.
8311         * remote-notif.h: Fix common/ includes.
8312         * remote-fileio.h: Fix common/ includes.
8313         * remote-fileio.c: Fix common/ includes.
8314         * regcache.h: Fix common/ includes.
8315         * regcache.c: Fix common/ includes.
8316         * record-btrace.c: Fix common/ includes.
8317         * python/python.c: Fix common/ includes.
8318         * python/py-type.c: Fix common/ includes.
8319         * python/py-inferior.c: Fix common/ includes.
8320         * progspace.h: Fix common/ includes.
8321         * producer.c: Fix common/ includes.
8322         * procfs.c: Fix common/ includes.
8323         * proc-api.c: Fix common/ includes.
8324         * printcmd.c: Fix common/ includes.
8325         * ppc-linux-nat.c: Fix common/ includes.
8326         * parser-defs.h: Fix common/ includes.
8327         * osdata.c: Fix common/ includes.
8328         * obsd-nat.c: Fix common/ includes.
8329         * nat/x86-linux.c: Fix common/ includes.
8330         * nat/x86-linux-dregs.c: Fix common/ includes.
8331         * nat/x86-dregs.h: Fix common/ includes.
8332         * nat/x86-dregs.c: Fix common/ includes.
8333         * nat/ppc-linux.c: Fix common/ includes.
8334         * nat/mips-linux-watch.h: Fix common/ includes.
8335         * nat/mips-linux-watch.c: Fix common/ includes.
8336         * nat/linux-waitpid.c: Fix common/ includes.
8337         * nat/linux-ptrace.h: Fix common/ includes.
8338         * nat/linux-ptrace.c: Fix common/ includes.
8339         * nat/linux-procfs.c: Fix common/ includes.
8340         * nat/linux-personality.c: Fix common/ includes.
8341         * nat/linux-osdata.c: Fix common/ includes.
8342         * nat/linux-namespaces.c: Fix common/ includes.
8343         * nat/linux-btrace.h: Fix common/ includes.
8344         * nat/linux-btrace.c: Fix common/ includes.
8345         * nat/fork-inferior.c: Fix common/ includes.
8346         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8347         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8348         * nat/aarch64-linux.c: Fix common/ includes.
8349         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8350         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8351         * namespace.h: Fix common/ includes.
8352         * mips-linux-tdep.c: Fix common/ includes.
8353         * minsyms.c: Fix common/ includes.
8354         * mi/mi-parse.h: Fix common/ includes.
8355         * mi/mi-main.c: Fix common/ includes.
8356         * mi/mi-cmd-env.c: Fix common/ includes.
8357         * memrange.h: Fix common/ includes.
8358         * memattr.c: Fix common/ includes.
8359         * maint.h: Fix common/ includes.
8360         * maint.c: Fix common/ includes.
8361         * main.c: Fix common/ includes.
8362         * machoread.c: Fix common/ includes.
8363         * location.c: Fix common/ includes.
8364         * linux-thread-db.c: Fix common/ includes.
8365         * linux-nat.c: Fix common/ includes.
8366         * linux-fork.c: Fix common/ includes.
8367         * inline-frame.c: Fix common/ includes.
8368         * infrun.c: Fix common/ includes.
8369         * inflow.c: Fix common/ includes.
8370         * inferior.h: Fix common/ includes.
8371         * inferior.c: Fix common/ includes.
8372         * infcmd.c: Fix common/ includes.
8373         * inf-ptrace.c: Fix common/ includes.
8374         * inf-child.c: Fix common/ includes.
8375         * ia64-linux-nat.c: Fix common/ includes.
8376         * i387-tdep.c: Fix common/ includes.
8377         * i386-tdep.c: Fix common/ includes.
8378         * i386-linux-tdep.c: Fix common/ includes.
8379         * i386-linux-nat.c: Fix common/ includes.
8380         * i386-go32-tdep.c: Fix common/ includes.
8381         * i386-fbsd-tdep.c: Fix common/ includes.
8382         * i386-fbsd-nat.c: Fix common/ includes.
8383         * guile/scm-type.c: Fix common/ includes.
8384         * guile/guile.c: Fix common/ includes.
8385         * go32-nat.c: Fix common/ includes.
8386         * gnu-nat.c: Fix common/ includes.
8387         * gdbthread.h: Fix common/ includes.
8388         * gdbarch-selftests.c: Fix common/ includes.
8389         * gdb_usleep.c: Fix common/ includes.
8390         * gdb_select.h: Fix common/ includes.
8391         * gdb_bfd.c: Fix common/ includes.
8392         * gcore.c: Fix common/ includes.
8393         * fork-child.c: Fix common/ includes.
8394         * findvar.c: Fix common/ includes.
8395         * fbsd-nat.c: Fix common/ includes.
8396         * event-top.c: Fix common/ includes.
8397         * event-loop.c: Fix common/ includes.
8398         * dwarf2read.c: Fix common/ includes.
8399         * dwarf2loc.c: Fix common/ includes.
8400         * dwarf2-frame.c: Fix common/ includes.
8401         * dwarf-index-cache.c: Fix common/ includes.
8402         * dtrace-probe.c: Fix common/ includes.
8403         * disasm-selftests.c: Fix common/ includes.
8404         * defs.h: Fix common/ includes.
8405         * csky-tdep.c: Fix common/ includes.
8406         * cp-valprint.c: Fix common/ includes.
8407         * cp-support.h: Fix common/ includes.
8408         * cp-support.c: Fix common/ includes.
8409         * corelow.c: Fix common/ includes.
8410         * completer.h: Fix common/ includes.
8411         * completer.c: Fix common/ includes.
8412         * compile/compile.c: Fix common/ includes.
8413         * compile/compile-loc2c.c: Fix common/ includes.
8414         * compile/compile-cplus-types.c: Fix common/ includes.
8415         * compile/compile-cplus-symbols.c: Fix common/ includes.
8416         * command.h: Fix common/ includes.
8417         * cli/cli-dump.c: Fix common/ includes.
8418         * cli/cli-cmds.c: Fix common/ includes.
8419         * charset.c: Fix common/ includes.
8420         * build-id.c: Fix common/ includes.
8421         * btrace.h: Fix common/ includes.
8422         * btrace.c: Fix common/ includes.
8423         * breakpoint.h: Fix common/ includes.
8424         * breakpoint.c: Fix common/ includes.
8425         * ax.h:
8426         (enum agent_op): Fix common/ includes.
8427         * ax-general.c (struct aop_map): Fix common/ includes.
8428         * ax-gdb.c: Fix common/ includes.
8429         * auxv.c: Fix common/ includes.
8430         * auto-load.c: Fix common/ includes.
8431         * arm-tdep.c: Fix common/ includes.
8432         * arch/riscv.c: Fix common/ includes.
8433         * arch/ppc-linux-common.c: Fix common/ includes.
8434         * arch/i386.c: Fix common/ includes.
8435         * arch/arm.c: Fix common/ includes.
8436         * arch/arm-linux.c: Fix common/ includes.
8437         * arch/arm-get-next-pcs.c: Fix common/ includes.
8438         * arch/amd64.c: Fix common/ includes.
8439         * arch/aarch64.c: Fix common/ includes.
8440         * arch/aarch64-insn.c: Fix common/ includes.
8441         * arch-utils.c: Fix common/ includes.
8442         * amd64-windows-tdep.c: Fix common/ includes.
8443         * amd64-tdep.c: Fix common/ includes.
8444         * amd64-sol2-tdep.c: Fix common/ includes.
8445         * amd64-obsd-tdep.c: Fix common/ includes.
8446         * amd64-nbsd-tdep.c: Fix common/ includes.
8447         * amd64-linux-tdep.c: Fix common/ includes.
8448         * amd64-linux-nat.c: Fix common/ includes.
8449         * amd64-fbsd-tdep.c: Fix common/ includes.
8450         * amd64-fbsd-nat.c: Fix common/ includes.
8451         * amd64-dicos-tdep.c: Fix common/ includes.
8452         * amd64-darwin-tdep.c: Fix common/ includes.
8453         * agent.c: Fix common/ includes.
8454         * ada-lang.h: Fix common/ includes.
8455         * ada-lang.c: Fix common/ includes.
8456         * aarch64-tdep.c: Fix common/ includes.
8457
8458 2019-01-25  Tom Tromey  <tom@tromey.com>
8459
8460         * common/create-version.sh: Use common/version.h.
8461
8462 2019-01-24  Pedro Alves  <palves@redhat.com>
8463
8464         * infrun.c (signal_stop, signal_print, signal_program)
8465         (signal_catch, signal_pass): Now arrays instead of pointers.
8466         (update_signals_program_target, do_target_resume)
8467         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8468         * linux-nat.c (linux_nat_target::pass_signals)
8469         (linux_nat_target::create_inferior, linux_nat_target::attach):
8470         Adjust.
8471         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8472         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8473         * procfs.c (procfs_target::pass_signals): Adjust.
8474         * record-full.c (record_full_target::resume): Adjust.
8475         * remote.c (remote_target::pass_signals)
8476         (remote_target::program_signals): Adjust.
8477         * target-debug.h (target_debug_print_signals): Now takes a
8478         gdb::array_view as parameter.  Adjust.
8479         * target.h (target_ops) <pass_signals, program_signals>: Replace
8480         pointer and length parameters with gdb::array_view.
8481         (target_pass_signals, target_program_signals): Likewise.
8482         * target-delegates.c: Regenerate.
8483
8484 2019-01-24  Pedro Alves  <palves@redhat.com>
8485
8486         * common/forward-scope-exit.h
8487         (forward_scope_exit::forward_scope_exit): Pass arguments to
8488         m_bind_function directly, instead of creating a std::bind and
8489         copying that.
8490
8491 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8492
8493         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8494         for static members.
8495         (pass_in_v_vfp_candidate): Likewise.
8496
8497 2019-01-23  Tom Tromey  <tom@tromey.com>
8498             Pedro Alves  <palves@redhat.com>
8499
8500         * regcache.c (class regcache_invalidator): Remove.
8501         (regcache::raw_write): Use make_scope_exit.
8502
8503 2019-01-23  Tom Tromey  <tom@tromey.com>
8504
8505         * ui-out.h (class ui_out_emit_type): Update comment.
8506
8507 2019-01-23  Tom Tromey  <tom@tromey.com>
8508
8509         * infrun.c (fetch_inferior_event): Update comment.
8510
8511 2019-01-23  Tom Tromey  <tom@tromey.com>
8512             Pedro Alves  <palves@redhat.com>
8513
8514         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8515         parameter.
8516         (fetch_inferior_event): Use SCOPE_EXIT.
8517
8518
8519 2019-01-23  Tom Tromey  <tom@tromey.com>
8520             Pedro Alves  <palves@redhat.com>
8521
8522         * infrun.c (disable_thread_events): Delete.
8523         (stop_all_threads): Use SCOPE_EXIT.
8524
8525 2019-01-23  Tom Tromey  <tom@tromey.com>
8526             Pedro Alves  <palves@redhat.com>
8527
8528         * symfile.c: Include forward-scope-exit.h.
8529         (clear_symtab_users_cleanup): Replace forward declaration with
8530         a FORWARD_SCOPE_EXIT.
8531         (syms_from_objfile_1): Use the forward_scope_exit and
8532         gdb::optional instead of cleanup_function.
8533         (reread_symbols): Use the forward_scope_exit instead of
8534         cleanup_function.
8535         (clear_symtab_users_cleanup): Remove function.
8536
8537 2019-01-23  Tom Tromey  <tom@tromey.com>
8538             Pedro Alves  <palves@redhat.com>
8539
8540         * linux-nat.c: Include scope-exit.h.
8541         (cleanup_target_stop): Remove.
8542         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8543         SCOPE_EXIT.
8544
8545 2019-01-23  Tom Tromey  <tom@tromey.com>
8546             Pedro Alves  <palves@redhat.com>
8547
8548         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8549         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8550
8551 2019-01-23  Tom Tromey  <tom@tromey.com>
8552             Andrew Burgess  <andrew.burgess@embecosm.com>
8553             Pedro Alves  <palves@redhat.com>
8554
8555         * infrun.c (fetch_inferior_event): Use scope_exit.
8556         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8557         * top.c (execute_command): Use scope_exit.
8558         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8559         * utils.c (do_bpstat_clear_actions_cleanup)
8560         (make_bpstat_clear_actions_cleanup): Remove.
8561
8562 2019-01-23  Tom Tromey  <tom@tromey.com>
8563             Pedro Alves  <palves@redhat.com>
8564
8565         * infrun.c: Include "common/scope-exit.h"
8566         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8567         (wait_for_inferior): Use SCOPE_EXIT.
8568         (fetch_inferior_event): Use scope_exit.
8569
8570 2019-01-23  Tom Tromey  <tom@tromey.com>
8571             Pedro Alves  <palves@redhat.com>
8572
8573         * breakpoint.c (create_breakpoint): Remove cleanup.
8574
8575 2019-01-23  Tom Tromey  <tom@tromey.com>
8576             Andrew Burgess  <andrew.burgess@embecosm.com>
8577             Pedro Alves  <palves@redhat.com>
8578
8579 2019-01-23  Pedro Alves  <palves@redhat.com>
8580
8581         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8582
8583 2019-01-23  Pedro Alves  <palves@redhat.com>
8584             Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * gdbthread.h: Include "common/forward-scope-exit.h".
8587         (scoped_finish_thread_state): Redefine custom class in terms of
8588         forward_scope_exit.
8589
8590 2019-01-23  Pedro Alves  <palves@redhat.com>
8591             Andrew Burgess  <andrew.burgess@embecosm.com>
8592
8593         * common/forward-scope-exit.h: New file.
8594
8595 2019-01-23  Pedro Alves  <palves@redhat.com>
8596             Andrew Burgess  <andrew.burgess@embecosm.com>
8597             Tom Tromey  <tom@tromey.com>
8598
8599         * common/scope-exit.h: New file.
8600
8601 2019-01-23  Pedro Alves  <palves@redhat.com>
8602
8603         * common/preprocessor.h (ESC): Rename to ...
8604         (ESC_PARENS): ... this.
8605         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8606         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8607
8608 2019-01-23  Tom Tromey  <tom@tromey.com>
8609
8610         * language.h (class scoped_switch_to_sym_language_if_auto):
8611         Initialize m_lang in both cases.
8612
8613 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8614
8615         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8616         with XCNEW.
8617
8618 2019-01-22  Tom Tromey  <tom@tromey.com>
8619
8620         * corelow.c: Do not include sys/file.h.
8621
8622 2019-01-22  Tom Tromey  <tom@tromey.com>
8623
8624         * tui/tui-wingeneral.h: Include gdb_curses.h.
8625
8626 2019-01-22  Tom Tromey  <tom@tromey.com>
8627
8628         * source-cache.h (class source_cache) <get_source_lines,
8629         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8630
8631 2019-01-22  Tom Tromey  <tom@tromey.com>
8632
8633         * remote-fileio.h (struct remote_target): Declare.
8634
8635 2019-01-22  Tom Tromey  <tom@tromey.com>
8636
8637         * python/py-arch.c: Do not include py-ref.h.
8638         * python/py-bpevent.c: Do not include py-ref.h.
8639         * python/py-cmd.c: Do not include py-ref.h.
8640         * python/py-continueevent.c: Do not include py-ref.h.
8641         * python/py-event.h: Do not include py-ref.h.
8642         * python/py-evtregistry.c: Do not include py-ref.h.
8643         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8644         * python/py-frame.c: Do not include py-ref.h.
8645         * python/py-framefilter.c: Do not include py-ref.h.
8646         * python/py-function.c: Do not include py-ref.h.
8647         * python/py-infevents.c: Do not include py-ref.h.
8648         * python/py-linetable.c: Do not include py-ref.h.
8649         * python/py-objfile.c: Do not include py-ref.h.
8650         * python/py-param.c: Do not include py-ref.h.
8651         * python/py-prettyprint.c: Do not include py-ref.h.
8652         * python/py-progspace.c: Do not include py-ref.h.
8653         * python/py-symbol.c: Do not include py-ref.h.
8654         * python/py-symtab.c: Do not include py-ref.h.
8655         * python/py-type.c: Do not include py-ref.h.
8656         * python/py-unwind.c: Do not include py-ref.h.
8657         * python/py-utils.c: Do not include py-ref.h.
8658         * python/py-value.c: Do not include py-ref.h.
8659         * python/py-varobj.c: Do not include py-ref.h.
8660         * python/py-xmethods.c: Do not include py-ref.h.
8661         * python/python.c: Do not include py-ref.h.
8662         * varobj.c: Do not include py-ref.h.
8663
8664 2019-01-22  Tom Tromey  <tom@tromey.com>
8665
8666         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8667         keyword for bcache.
8668
8669 2019-01-22  Tom Tromey  <tom@tromey.com>
8670
8671         * compile/compile-cplus-types.c: Remove a comment by #include.
8672
8673 2019-01-22  Tom Tromey  <tom@tromey.com>
8674
8675         * compile/gcc-c-plugin.h: Include compile-internal.h.
8676
8677 2019-01-22  Tom Tromey  <tom@tromey.com>
8678
8679         * stabsread.c (EXTERN): Do not define.
8680         (symnum, next_symbol_text_func, processing_gcc_compilation)
8681         (within_function, global_sym_chain, global_stabs)
8682         (previous_stab_code, this_object_header_files)
8683         (n_this_object_header_files)
8684         (n_allocated_this_object_header_files): Define.
8685         * stabsread.h (EXTERN): Never define.  Use "extern".
8686
8687 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8688
8689         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8690         history_value.
8691
8692 2019-01-21  Tom Tromey  <tom@tromey.com>
8693
8694         * ui-out.c: Fix includes.
8695         * tui/tui-source.c: Fix includes.
8696         * target.c: Fix includes.
8697         * remote.c: Fix includes.
8698         * regcache.c: Fix includes.
8699         * python/py-block.c: Fix includes.
8700         * printcmd.c: Fix includes.
8701         * or1k-tdep.c: Fix includes.
8702         * mi/mi-main.c: Fix includes.
8703         * m32r-tdep.c: Fix includes.
8704         * csky-tdep.c: Fix includes.
8705         * compile/compile-cplus-types.c: Fix includes.
8706         * cli/cli-interp.c: Fix includes.
8707
8708 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8709
8710         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8711         for padding.
8712
8713 2019-01-16  Tom Tromey  <tom@tromey.com>
8714
8715         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8716         earlier.
8717         (struct objfile) <msymbols_range>: Move from top level.
8718         <msymbols>: New method.
8719         (class objfile_msymbols): Remove.
8720         * symtab.c (default_collect_symbol_completion_matches_break_on):
8721         Update.
8722         * symmisc.c (dump_msymbols): Update.
8723         * stabsread.c (scan_file_globals): Update.
8724         * objc-lang.c (info_selectors_command, info_classes_command)
8725         (find_methods): Update.
8726         * minsyms.c (find_solib_trampoline_target): Update.
8727         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8728         * coffread.c (coff_symfile_read): Update.
8729         * ada-lang.c (ada_lookup_simple_minsym)
8730         (ada_collect_symbol_completion_matches): Update.
8731
8732 2019-01-16  Tom Tromey  <tom@tromey.com>
8733
8734         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8735         type.  Remove no-argument constructor.
8736         <iterator::operator++>: Simplify.
8737         <begin>: Update.
8738         <end>: Use minimal_symbol_count.
8739
8740 2019-01-16  Tom Tromey  <tom@tromey.com>
8741
8742         * objfiles.h (struct objfile) <psymtabs>: New method.
8743         (class objfile_psymtabs): Remove.
8744         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8745         typedef.
8746         <range>: New method.
8747         (require_partial_symbols): Change return type.
8748         * psymtab.c (require_partial_symbols)
8749         (psym_expand_symtabs_matching): Update.
8750         * mdebugread.c (parse_partial_symbols): Update.
8751         * dbxread.c (dbx_end_psymtab): Update.
8752
8753 2019-01-15  Tom Tromey  <tom@tromey.com>
8754
8755         * symtab.c (lookup_objfile_from_block)
8756         (lookup_symbol_in_objfile_symtabs)
8757         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8758         (find_line_symtab, info_sources_command)
8759         (default_collect_symbol_completion_matches_break_on)
8760         (make_source_files_completion_list): Update.
8761         * symmisc.c (print_objfile_statistics, dump_objfile)
8762         (maintenance_print_symbols, maintenance_info_symtabs)
8763         (maintenance_check_symtabs, maintenance_info_line_tables):
8764         Update.
8765         * source.c (select_source_symtab)
8766         (forget_cached_source_info_for_objfile): Update.
8767         * objfiles.h (class objfile_compunits): Remove.
8768         (struct objfile) <compunits_range>: New typedef.
8769         (compunits): New method.
8770         * objfiles.c (objfile_relocate1): Update.
8771         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8772         * maint.c (count_symtabs_and_blocks): Update.
8773         * linespec.c (iterate_over_all_matching_symtabs): Update.
8774         * cp-support.c (add_symbol_overload_list_qualified): Update.
8775         * coffread.c (coff_symtab_read): Update.
8776         * ada-lang.c (add_nonlocal_symbols)
8777         (ada_collect_symbol_completion_matches)
8778         (ada_add_global_exceptions): Update.
8779
8780 2019-01-15  Tom Tromey  <tom@tromey.com>
8781
8782         * progspace.h (program_space) <objfiles_safe_range>: New
8783         typedef.
8784         <objfiles_safe>: New method.
8785         * objfiles.h (class all_objfiles_safe): Remove.
8786         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8787         * jit.c (jit_inferior_exit_hook): Update.
8788
8789 2019-01-17  Tom Tromey  <tom@tromey.com>
8790
8791         * progspace.h (program_space) <objfiles_range>: New typedef.
8792         <objfiles>: New method.
8793         <objfiles_head>: Rename from objfiles.
8794         (object_files): Update.
8795         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8796         * guile/scm-pretty-print.c
8797         (ppscm_find_pretty_printer_from_objfiles): Update.
8798         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8799         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8800         Update.
8801         * python/py-progspace.c (pspy_get_objfiles): Update.
8802         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8803         Update.
8804         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8805         (objfpy_lookup_objfile_by_build_id): Update.
8806         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8807         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8808         Update.
8809         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8810         (expand_symtab_containing_pc, lookup_objfile_from_block)
8811         (lookup_static_symbol, basic_lookup_transparent_type)
8812         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8813         (find_line_symtab, info_sources_command)
8814         (default_collect_symbol_completion_matches_break_on)
8815         (make_source_files_completion_list, find_main_name): Update.
8816         * symmisc.c (print_symbol_bcache_statistics)
8817         (print_objfile_statistics, maintenance_print_symbols)
8818         (maintenance_print_msymbols, maintenance_print_objfiles)
8819         (maintenance_info_symtabs, maintenance_check_symtabs)
8820         (maintenance_expand_symtabs, maintenance_info_line_tables):
8821         Update.
8822         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8823         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8824         (map_overlay_command, unmap_overlay_command)
8825         (simple_overlay_update, expand_symtabs_matching)
8826         (map_symbol_filenames): Update.
8827         * symfile-debug.c (set_debug_symfile): Update.
8828         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8829         Update.
8830         * source.c (select_source_symtab, forget_cached_source_info):
8831         Update.
8832         * solib.c (solib_read_symbols): Update.
8833         * solib-spu.c (append_ocl_sos): Update.
8834         * psymtab.c (maintenance_print_psymbols)
8835         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8836         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8837         * printcmd.c (info_symbol_command): Update.
8838         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8839         Update.
8840         * objfiles.h (class all_objfiles): Remove.
8841         * objfiles.c (have_partial_symbols, have_full_symbols)
8842         (have_minimal_symbols, qsort_cmp, update_section_map)
8843         (shared_objfile_contains_address_p)
8844         (default_iterate_over_objfiles_in_search_order): Update.
8845         * objc-lang.c (info_selectors_command, info_classes_command)
8846         (find_methods): Update.
8847         * minsyms.c (find_solib_trampoline_target): Update.
8848         * maint.c (maintenance_info_sections)
8849         (maintenance_translate_address, count_symtabs_and_blocks):
8850         Update.
8851         * main.c (captured_main_1): Update.
8852         * linux-thread-db.c (try_thread_db_load_from_pdir)
8853         (has_libpthread): Update.
8854         * linespec.c (iterate_over_all_matching_symtabs)
8855         (search_minsyms_for_name): Update.
8856         * jit.c (jit_find_objf_with_entry_addr): Update.
8857         * hppa-tdep.c (find_unwind_entry)
8858         (hppa_lookup_stub_minimal_symbol): Update.
8859         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8860         Update.
8861         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8862         (elf_gnu_ifunc_resolve_by_got): Update.
8863         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8864         * dwarf-index-write.c (save_gdb_index_command): Update.
8865         * cp-support.c (add_symbol_overload_list_qualified): Update.
8866         * breakpoint.c (create_overlay_event_breakpoint)
8867         (create_longjmp_master_breakpoint)
8868         (create_std_terminate_master_breakpoint)
8869         (create_exception_master_breakpoint): Update.
8870         * blockframe.c (find_pc_partial_function): Update.
8871         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8872         (ada_collect_symbol_completion_matches)
8873         (ada_add_global_exceptions): Update.
8874
8875 2019-01-17  Tom Tromey  <tom@tromey.com>
8876
8877         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8878         declare VEC.
8879         (solib_target_parse_libraries): Change return type.
8880         (library_list_start_segment, library_list_start_section)
8881         (library_list_end_library, library_list_start_library); Update.
8882         (solib_target_free_library_list): Remove.
8883         (solib_target_parse_libraries): Remove cleanup.  Change return
8884         type.
8885         (solib_target_current_sos): Update.
8886
8887 2019-01-17  Tom Tromey  <tromey@bapiya>
8888
8889         * valprint.c: Replace "the the" with "the".
8890         * symtab.c: Replace "the the" with "the".
8891         * solib.c: Replace "the the" with "the".
8892         * solib-dsbt.c: Replace "the the" with "the".
8893         * linespec.c: Replace "the the" with "the".
8894         * dwarf2loc.h: Replace "the the" with "the".
8895         * amd64-windows-tdep.c: Replace "the the" with "the".
8896         * aarch64-tdep.c: Replace "the the" with "the".
8897
8898 2019-01-16  Keith Seitz  <keiths@redhat.com>
8899
8900         PR gdb/23773
8901         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8902         <builder>: Rename to ..
8903         <m_builder>: ... this and make private.
8904         (dwarf2_cu::get_builder): New method.  Change all users of
8905         `builder' to use this method.
8906         (dwarf2_start_symtab): Move to ...
8907         (dwarf2_cu::start_symtab): ... here.  Update all callers
8908         (setup_type_unit_groups): Move to ...
8909         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8910         callers.
8911         (dwarf2_cu::reset_builder): New method.
8912         (process_full_compunit, process_full_type_unit): Use
8913         dwarf2_cu::reset_builder.
8914         (follow_die_offset): Record the ancestor CU if it is different
8915         from the followed DIE's CU.
8916         (follow_die_sig_1): Likewise.
8917
8918 2019-01-15  Tom Tromey  <tom@tromey.com>
8919
8920         * remote.c (class remote_state) <buf>: Now a char_vector.
8921         <buf_size>: Remove.
8922         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8923         parameter.
8924         (remote_target::getpkt_or_notif_sane_1)
8925         (remote_target::getpkt_sane)
8926         (remote_target::getpkt_or_notif_sane): Likewise.
8927         (class remote_target) <putpkt>: New overload.
8928         (remote_target::read_frame): Change type of "buf_p".  Remove
8929         sizeof_p parameter.
8930         (packet_ok): New overload.
8931         (packet_check_result): New overload.
8932         Update all uses.
8933
8934 2019-01-14  Tom Tromey  <tom@tromey.com>
8935
8936         * remote-notif.c (handle_notification, remote_notif_ack)
8937         (remote_notif_parse): Make "buf" const.
8938         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8939         const.
8940         (remote_notif_parse, remote_notif_ack, handle_notification):
8941         Likewise.
8942         * remote.c (remote_notif_stop_parse): Make "buf" const.
8943         (remote_target::remote_parse_stop_reply): Make "buf" const.
8944         (remote_notif_stop_ack): Make "buf" const.
8945
8946 2019-01-14  Tom Tromey  <tom@tromey.com>
8947
8948         * remote.c (remote_console_output): Make parameter const.
8949
8950 2019-01-14  Tom Tromey  <tom@tromey.com>
8951
8952         * target-debug.h (target_debug_print_signals): Constify.
8953         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8954         * procfs.c (procfs_target::pass_signals): Update.
8955         * linux-nat.c (linux_nat_target::pass_signals): Update.
8956         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8957         * target-delegates.c: Rebuild.
8958         * remote.c (remote_target::program_signals): Update.
8959         (remote_target::pass_signals): Update.
8960         * target.c (target_pass_signals): Constify argument.
8961         (target_program_signals): Likewise.
8962         * target.h (struct target_ops) <pass_signals, program_signals>:
8963         Constify argument.
8964         (target_pass_signals, target_program_signals): Constify argument.
8965
8966 2019-01-14  Tom Tromey  <tom@tromey.com>
8967
8968         PR tui/28819:
8969         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8970
8971 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8972
8973         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8974         field.
8975         * rs6000-tdep.c: Include reggroups.h.
8976         (IS_V_ALIAS_PSEUDOREG): Define.
8977         (rs6000_register_name): Return names for the "vX" aliases.
8978         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8979         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8980         aliases.  Call default_register_reggroup_p for all other
8981         pseudo-registers.
8982         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8983         New functions.
8984         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8985         Handle "vX" aliases.
8986         (v_alias_pseudo_register_collect): New function.
8987         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8988         (rs6000_gdbarch_init): Initialize "vX" aliases as
8989         pseudo-registers.  Restore registration of
8990         rs6000_pseudo_register_reggroup_p with
8991         set_tdesc_pseudo_register_reggroup_p.
8992
8993 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8994
8995         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8996         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8997         set_gdbarch_num_pseudo_regs.
8998
8999 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9000
9001         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9002         Remove arg prefixname, add do_set and do_show.
9003         Add member functions set_list and show_list.
9004         * cli/cli-style.c (class cli_style_option): Update accordingly.
9005         (style_set_list): Move to file scope.
9006         (style_show_list): Likewise.
9007         (set_style): Call help_list.
9008         (show_style): Call cmd_show_list.
9009         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9010         Update to use the new macro.
9011
9012 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9013
9014         * ada-lang.c (_initialize_ada_language): Expand the help text
9015         for the "catch exception" command.
9016
9017 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9018
9019         * symtab.c (matching_obj_sections): Initialize obj,
9020         declare it closer to its usage.
9021
9022 2019-01-10  Tom Tromey  <tom@tromey.com>
9023
9024         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9025         (basic_inf_threads_range): Remove.
9026         (inf_threads_range, inf_non_exited_threads_range)
9027         (safe_inf_threads_range): Use next_adapter.
9028
9029 2019-01-10  Keith Seitz  <keiths@redhat.com>
9030
9031         PR gdb/23712
9032         PR symtab/23010
9033         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9034         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9035
9036 2019-01-10  Keith Seitz  <keiths@redhat.com>
9037
9038         PR gdb/23712
9039         PR symtab/23010
9040         * dictionary.c (pending_to_vector): Remove.
9041         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9042         Remove _1 suffix, replacing functions of the same name.  Update
9043         all callers.
9044         (dict_create_hashed, dict_create_hashed_expandable)
9045         (dict_create_linear, dict_create_linear_expandable, dict_free)
9046         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9047         Make functions static.
9048
9049 2019-01-10  Keith Seitz  <keiths@redhat.com>
9050
9051         PR gdb/23712
9052         PR symtab/23010
9053         * dictionary.h (struct dictionary): Replace declaration with
9054         multidictionary.
9055         (dict_create_hashed, dict_create_hashed_expandable)
9056         (dict_create_linear, dict_create_linear_expandable)
9057         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9058         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9059         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9060         taking multidictionary argument.
9061         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9062         * block.h (struct block) <dict>: Change to multidictionary
9063         and rename `multidict'.
9064         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9065         symmisc.c: Update all dictionary references to multidictionary.
9066
9067 2019-01-10  Keith Seitz  <keiths@redhat.com>
9068
9069         PR gdb/23712
9070         PR symtab/23010
9071         * dictionary.c: Include unordered_map.
9072         (pending_to_vector): New function.
9073         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9074         Rewrite the non-"_1" functions to take vector instead
9075         of linked list.
9076         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9077         "new" _1 versions of the same name.
9078         (multidictionary): Define.
9079         (std::hash<enum language): New definition.
9080         (collate_pending_symbols_by_language, mdict_create_hashed)
9081         (mdict_create_hashed_expandable, mdict_create_linear)
9082         (mdict_create_linear_expandable, mdict_free)
9083         (find_language_dictionary, create_new_language_dictionary)
9084         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9085         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9086         (mdict_size, mdict_empty): New functions.
9087         * dictionary.h (mdict_iterator): Define.
9088
9089 2019-01-10  Pedro Alves  <palves@redhat.com>
9090
9091         * breakpoint.c (read_uploaded_action)
9092         (create_tracepoint_from_upload): Adjust to use
9093         gdb::unique_xmalloc_ptr.
9094         * ctf.c (ctf_write_uploaded_tp):
9095         (SET_ARRAY_FIELD): Use emplace_back.
9096         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9097         * tracefile-tfile.c (tfile_write_uploaded_tp):
9098         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9099         gdb::unique_xmalloc_ptr.
9100         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9101         at_string, cond_string, cmd_strings>: Replace char pointers
9102         with gdb::unique_xmalloc_ptr.
9103
9104 2019-01-10  Pedro Alves  <palves@redhat.com>
9105
9106         * solib-target.c (library_list_start_library): Don't xstrdup name.
9107
9108 2019-01-10  Pedro Alves  <palves@redhat.com>
9109
9110         * mdebugread.c (parse_partial_symbols): Use
9111         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9112
9113 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9114
9115         * linux-fork.c (scoped_switch_fork_info)
9116         <~scoped_switch_fork_info>: Fix incorrect variable name.
9117
9118 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9119
9120         * linux-fork.c (scoped_switch_fork_info)
9121         <scoped_switch_fork_info>: Make explicit.
9122         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9123
9124 2019-01-10  Tom Tromey  <tom@tromey.com>
9125
9126         * objfiles.h (objfile::reset_psymtabs): Update.
9127         * objfiles.c (objfile::objfile): Update.
9128         * psymtab.h (psymtab_storage::obstack): Update.
9129         (psymtab_storage::m_obstack): Use gdb::optional.
9130         (class psymtab_storage): Update comment.  Remove objfile
9131         parameter.
9132         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9133
9134 2019-01-10  Tom Tromey  <tom@tromey.com>
9135
9136         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9137         <free_psymtabs>: Now private.
9138         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9139         (allocate_psymtab): Use new method.
9140
9141 2019-01-10  Tom Tromey  <tom@tromey.com>
9142
9143         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9144         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9145         * mdebugread.c (parse_partial_symbols): Use
9146         allocate_dependencies.
9147         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9148         allocate_dependencies.
9149         (process_psymtab_comp_unit_reader)
9150         (build_type_psymtab_dependencies): Likewise.
9151         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9152
9153 2019-01-10  Tom Tromey  <tom@tromey.com>
9154
9155         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9156         PSYMBOL_SET_LANGUAGE.
9157         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9158
9159 2019-01-10  Tom Tromey  <tom@tromey.com>
9160
9161         * psymtab.h (psymtab_storage::obstack): New method.
9162         <m_obstack>: Rename from obstack; now private.
9163         * psymtab.c (psymtab_storage): Update.
9164         * dwarf2read.c (create_addrmap_from_index)
9165         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9166         Update.
9167
9168 2019-01-10  Tom Tromey  <tom@tromey.com>
9169
9170         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9171         * objfiles.h (objfile::reset_psymtabs): New method.
9172
9173 2019-01-10  Tom Tromey  <tom@tromey.com>
9174
9175         * symmisc.c (print_symbol_bcache_statistics): Update.
9176         (print_objfile_statistics): Update.
9177         * symfile.c (reread_symbols): Update.
9178         * psymtab.h (class psymtab_storage): New.
9179         * psymtab.c (psymtab_storage): New constructor.
9180         (~psymtab_storage): New destructor.
9181         (require_partial_symbols): Update.
9182         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9183         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9184         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9185         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9186         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9187         (start_psymtab_common, end_psymtab_common)
9188         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9189         (allocate_psymtab): Update.
9190         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9191         Update.
9192         (dump_psymtab_addrmap, maintenance_print_psymbols)
9193         (maintenance_check_psymtabs): Update.
9194         (class objfile_psymtabs): Move to objfiles.h.
9195         * psympriv.h (discard_psymtab): Now inline.
9196         (psymtab_discarder::psymtab_discarder): Update.
9197         (psymtab_discarder::~psymtab_discarder): Update.
9198         (ALL_OBJFILE_PSYMTABS): Rewrite.
9199         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9200         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9201         Remove fields.
9202         <partial_symtabs>: New field.
9203         (class objfile_psymtabs): Move from psymtab.h.  Update.
9204         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9205         psymbol_cache.
9206         (objfile::~objfile): Don't destroy psymbol_cache.
9207         * mdebugread.c (parse_partial_symbols): Update.
9208         * dwarf2read.c (create_addrmap_from_index)
9209         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9210         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9211         (add_partial_subprogram, dwarf2_ranges_read): Update.
9212         * dwarf-index-write.c (write_address_map)
9213         (write_one_signatured_type, recursively_write_psymbols)
9214         (class debug_names, class debug_names, write_psymtabs_to_index):
9215         Update.
9216
9217 2019-01-10  Tom Tromey  <tom@tromey.com>
9218
9219         * symtab.h (SYMBOL_SET_NAMES): Update.
9220         (symbol_set_names): Update.
9221         (MSYMBOL_SET_NAMES): Update.
9222         * symtab.c (symbol_set_names): Change argument to be an
9223         objfile_per_bfd_storage.
9224         * psymtab.c (add_psymbol_to_bcache): Update.
9225         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9226
9227 2019-01-10  Tom Tromey  <tom@tromey.com>
9228
9229         * symtab.c (create_demangled_names_hash): Change argument to be an
9230         objfile_per_bfd_storage.
9231         (symbol_set_names): Update.
9232
9233 2019-01-10  Tom Tromey  <tom@tromey.com>
9234
9235         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9236         init_psymbol_list.
9237         * psymtab.c (init_psymbol_list): Do nothing if already called.
9238         * psympriv.h (init_psymbol_list): Add comment.
9239         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9240         init_psymbol_list.
9241         * dbxread.c (dbx_symfile_read): Unconditionally call
9242         init_psymbol_list.
9243
9244 2019-01-10  Tom Tromey  <tom@tromey.com>
9245
9246         * xcoffread.c (scan_xcoff_symtab): Update.
9247         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9248         "where".
9249         * mdebugread.c (parse_partial_symbols)
9250         (handle_psymbol_enumerators): Update.
9251         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9252         * dbxread.c (read_dbx_symtab): Update.
9253         * psympriv.h (psymbol_placement): New enum.
9254         (add_psymbol_to_list): Update.
9255
9256 2019-01-10  Tom Tromey  <tom@tromey.com>
9257
9258         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9259         static_psymbols parameters.
9260         (scan_xcoff_symtab): Update.
9261         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9262         static_psymbols parameters.
9263         * psympriv.h (start_psymtab_common): Update.
9264         * mdebugread.c (parse_partial_symbols): Update.
9265         * dwarf2read.c (create_partial_symtab): Update.
9266         * dbxread.c (read_dbx_symtab): Update.
9267         (start_psymtab): Remove global_psymbols and static_psymbols
9268         parameters.
9269
9270 2019-01-10  Tom Tromey  <tom@tromey.com>
9271
9272         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9273         * psymtab.c (allocate_psymtab): Add comment.
9274         * psympriv.h (allocate_psymtab): Add comment.
9275         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9276         initializations.
9277         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9278
9279 2019-01-10  Tom Tromey  <tom@tromey.com>
9280
9281         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9282         Don't declare.
9283         * mipsread.c: Include mdebugread.h.
9284         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9285         Declare.
9286         * elfread.c: Include mdebugread.h.
9287
9288 2019-01-09  Tom Tromey  <tom@tromey.com>
9289
9290         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9291         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9292         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9293         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9294         (psym_lookup_symbol, psym_find_last_source_symtab)
9295         (psym_forget_cached_source_info, psym_print_stats)
9296         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9297         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9298         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9299         (psym_find_compunit_symtab_by_address)
9300         (maintenance_print_psymbols, maintenance_info_psymtabs)
9301         (maintenance_check_psymtabs): Use ranged for.
9302         * psymtab.h (class objfile_psymtabs): New.
9303         (require_partial_symbols): Return objfile_psymtabs.
9304         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9305
9306 2019-01-09  Tom Tromey  <tom@tromey.com>
9307
9308         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9309         (find_pc_mapped_section, list_overlays_command)
9310         (map_overlay_command, unmap_overlay_command)
9311         (simple_overlay_update): Use all_objfiles.
9312         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9313         * printcmd.c (info_symbol_command): Use all_objfiles.
9314         * objfiles.h (ALL_OBJSECTIONS): Remove.
9315         * maint.c (maintenance_translate_address): Use all_objfiles.
9316         * gcore.c (gcore_create_callback): Use all_objfiles.
9317         (objfile_find_memory_regions): Likewise.
9318
9319 2019-01-09  Tom Tromey  <tom@tromey.com>
9320
9321         * symtab.c (find_line_symtab, info_sources_command)
9322         (make_source_files_completion_list): Use objfile_compunits.
9323         * source.c (select_source_symtab): Use objfile_compunits.
9324         * objfiles.h (struct objfile): Update comment.
9325         (ALL_OBJFILES): Remove.
9326         (ALL_FILETABS): Remove.
9327         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9328         objfile_compunits.
9329
9330 2019-01-09  Tom Tromey  <tom@tromey.com>
9331
9332         * symmisc.c (print_objfile_statistics, dump_objfile)
9333         (maintenance_print_symbols): Use compunit_filetabs.
9334         * source.c (forget_cached_source_info_for_objfile): Use
9335         compunit_filetabs.
9336         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9337         (ALL_FILETABS): Use compunit_filetabs.
9338         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9339         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9340
9341 2019-01-09  Tom Tromey  <tom@tromey.com>
9342
9343         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9344         (compunit_filetabs): New.
9345         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9346         compunit_filetabs.
9347         (info_sources_command, make_source_files_completion_list): Remove
9348         declaration.
9349         * symmisc.c (print_objfile_statistics, dump_objfile)
9350         (maintenance_print_symbols): Remove declaration.
9351         (maintenance_info_symtabs): Use compunit_filetabs.
9352         (maintenance_info_line_tables): Likewise.
9353         * source.c (select_source_symtab): Change local variable name.
9354         (forget_cached_source_info_for_objfile): Remove declaration.
9355         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9356         * objfiles.c (objfile_relocate1): Remove declaration.
9357         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9358         declaration.
9359         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9360         * coffread.c (coff_symtab_read): Remove declaration.
9361         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9362         compunit_filetabs.
9363
9364 2019-01-09  Tom Tromey  <tom@tromey.com>
9365
9366         * symtab.c (lookup_objfile_from_block)
9367         (find_pc_sect_compunit_symtab, search_symbols)
9368         (default_collect_symbol_completion_matches_break_on): Use
9369         objfile_compunits.
9370         * objfiles.h (ALL_COMPUNITS): Remove.
9371         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9372         * cp-support.c (add_symbol_overload_list_qualified): Use
9373         objfile_compunits.
9374         * ada-lang.c (ada_collect_symbol_completion_matches)
9375         (ada_add_global_exceptions): Use objfile_compunits.
9376
9377 2019-01-09  Tom Tromey  <tom@tromey.com>
9378
9379         * source.c (select_source_symtab)
9380         (forget_cached_source_info_for_objfile): Remove declaration.
9381         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9382         declaration.
9383         * maint.c (count_symtabs_and_blocks): Remove declaration.
9384         * cp-support.c (add_symbol_overload_list_qualified): Remove
9385         declaration.
9386         * coffread.c (coff_symtab_read): Remove declaration.
9387         * symtab.c (lookup_symbol_in_objfile_symtabs)
9388         (basic_lookup_transparent_type_1): Use objfile_compunits.
9389         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9390         (info_sources_command, search_symbols)
9391         (default_collect_symbol_completion_matches_break_on)
9392         (make_source_files_completion_list): Remove declaration.
9393         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9394         (ada_collect_symbol_completion_matches)
9395         (ada_add_global_exceptions): Remove declaration.
9396         * linespec.c (iterate_over_all_matching_symtabs): Use
9397         objfile_compunits.
9398         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9399         (class objfile_compunits): New.
9400         (ALL_COMPUNITS): Use objfile_compunits.
9401         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9402         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9403         objfile_compunits.
9404         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9405
9406 2019-01-09  Tom Tromey  <tom@tromey.com>
9407
9408         * symtab.c (search_symbols)
9409         (default_collect_symbol_completion_matches_break_on): Use
9410         objfile_msymbols.
9411         * ada-lang.c (ada_lookup_simple_minsym)
9412         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9413         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9414         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9415         objfile_msymbols.
9416         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9417         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9418         * objc-lang.c (find_methods): Use objfile_msymbols.
9419         (info_selectors_command, info_classes_command): Likewise.
9420         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9421         * objfiles.h (class objfile_msymbols): New.
9422         (ALL_OBJFILE_MSYMBOLS): Remove.
9423         (ALL_MSYMBOLS): Remove.
9424
9425 2019-01-09  Tom Tromey  <tom@tromey.com>
9426
9427         * common/next-iterator.h (next_adapter): Add Iterator template
9428         parameter.
9429         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9430         (class all_objfiles_safe): New.
9431         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9432         * objfiles.c (put_objfile_before): Update comment.
9433         (add_separate_debug_objfile): Likewise.
9434         (free_all_objfiles): Use all_objfiles_safe.
9435         (objfile_purge_solibs): Likewise.
9436
9437 2019-01-09  Tom Tromey  <tom@tromey.com>
9438
9439         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9440         (expand_symtab_containing_pc, lookup_static_symbol)
9441         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9442         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9443         all_objfiles.
9444         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9445         * breakpoint.c (create_overlay_event_breakpoint)
9446         (create_longjmp_master_breakpoint)
9447         (create_std_terminate_master_breakpoint)
9448         (create_exception_master_breakpoint): Use all_objfiles.
9449         * linux-thread-db.c (try_thread_db_load_from_pdir)
9450         (has_libpthread): Use all_objfiles.
9451         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9452         * linespec.c (iterate_over_all_matching_symtabs)
9453         (search_minsyms_for_name): Use all_objfiles.
9454         * maint.c (maintenance_info_sections): Use all_objfiles.
9455         * main.c (captured_main_1): Use all_objfiles.
9456         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9457         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9458         * guile/scm-pretty-print.c
9459         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9460         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9461         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9462         (maintenance_print_msymbols): Use all_objfiles.
9463         * source.c (select_source_symtab): Use all_objfiles.
9464         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9465         * symfile.c (remove_symbol_file_command)
9466         (expand_symtabs_matching, map_symbol_filenames): Use
9467         all_objfiles.
9468         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9469         all_objfiles.
9470         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9471         * objc-lang.c (find_methods): Use all_objfiles.
9472         * objfiles.c (have_partial_symbols, have_full_symbols)
9473         (have_minimal_symbols, qsort_cmp)
9474         (default_iterate_over_objfiles_in_search_order): Use
9475         all_objfiles.
9476         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9477         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9478         (maintenance_check_psymtabs): Use all_objfiles.
9479         (ALL_PSYMTABS): Remove.
9480         * compile/compile-object-run.c (do_module_cleanup): Use
9481         all_objfiles.
9482         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9483         * cp-support.c (add_symbol_overload_list_qualified): Use
9484         all_objfiles.
9485         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9486         Use all_objfiles.
9487         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9488         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9489         all_objfiles.
9490         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9491         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9492         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9493         Uses all_objfiles.
9494         * solib.c (solib_read_symbols): Use all_objfiles
9495
9496 2019-01-09  Tom Tromey  <tom@tromey.com>
9497
9498         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9499         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9500         all_objfiles.
9501         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9502         * symmisc.c (print_symbol_bcache_statistics)
9503         (print_objfile_statistics, maintenance_print_objfiles)
9504         (maintenance_info_symtabs, maintenance_check_symtabs)
9505         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9506         all_objfiles.
9507         * source.c (forget_cached_source_info): Use all_objfiles.
9508         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9509         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9510         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9511         * objfiles.c (update_section_map): Use all_objfiles.
9512         (shared_objfile_contains_address_p): Likewise.
9513         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9514         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9515
9516 2019-01-09  Tom Tromey  <tom@tromey.com>
9517
9518         * common/next-iterator.h: New file.
9519         * objfiles.h (class all_objfiles): New.
9520         (struct objfile_iterator): New.
9521
9522 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9523
9524         * NEWS: Move the description of the changed "frame", "select-frame",
9525          and "info frame" commands to the Changed commands section.
9526
9527 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9528
9529         * gdbtypes.c (check_stub_method_group): Remove handling of old
9530         mangling schemes.
9531         * linespec.c (find_methods): Likewise.
9532         * stabsread.c (read_member_functions): Likewise.
9533         * valops.c (search_struct_method): Likewise.
9534         (value_struct_elt_for_reference): Likewise.
9535         * NEWS: Mention this change.
9536
9537 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9538
9539         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9540         print_source_lines.
9541         * source.c (print_source_lines_base): Update line number check.
9542         (print_source_lines): New function.
9543         (source_lines_range::source_lines_range): New function.
9544         * source.h (class source_lines_range): New class.
9545         (print_source_lines): New declaration.
9546
9547 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9548
9549         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9550
9551 2019-01-08  Tom Tromey  <tom@tromey.com>
9552             Simon Marchi  <simon.marchi@ericsson.com>
9553
9554         PR gdb/24060
9555         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9556         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9557         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9558         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9559         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9560         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9561
9562 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9563
9564         * source.c (select_source_symtab): Move header comment to
9565         declaration in source.h.
9566         (forget_cached_source_info_for_objfile): Likewise.
9567         (forget_cached_source_info): Likewise.
9568         (identify_source_line): Likewise.
9569         * source.h (identify_source_line): Move declaration from symtab.h
9570         and add comment from source.c
9571         (print_source_lines): Likewise.
9572         (forget_cached_source_info_for_objfile): Likewise.
9573         (forget_cached_source_info): Likewise.
9574         (select_source_symtab): Likewise.
9575         (enum print_source_lines_flag): Move definition from symtab.h.
9576         * symtab.h (identify_source_line): Move declaration to source.h.
9577         (print_source_lines): Likewise.
9578         (forget_cached_source_info_for_objfile): Likewise.
9579         (forget_cached_source_info): Likewise.
9580         (select_source_symtab): Likewise.
9581         (enum print_source_lines_flag): Move definition to source.h.
9582         * tui/tui-hooks.c: Add 'source.h' include.
9583
9584 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9585
9586         * source.c (print_source_lines_base): Handle requests to print
9587         reverse line number sequences, and guard against empty lines
9588         string.
9589
9590 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9591
9592         * source.c (print_source_lines_base): Fix skip of '\r' if next
9593         character is '\n'.
9594
9595 2019-01-06  Tom Tromey  <tom@tromey.com>
9596
9597         * c-exp.y (struct c_parse_state) <macro_original_text,
9598         expansion_obstack>: New member.
9599         (macro_original_text, expansion_obstack): Remove globals.
9600         (scan_macro_expansion, scanning_macro_expansion)
9601         (finished_macro_expansion): Update.
9602         (scan_macro_cleanup): Remove.
9603         (yylex, c_parse): Update.
9604
9605 2019-01-06  Tom Tromey  <tom@tromey.com>
9606
9607         * c-exp.y (struct c_parse_state) <strings>: New member.
9608         (operator_stoken): Update.
9609
9610 2019-01-06  Tom Tromey  <tom@tromey.com>
9611
9612         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9613         (union type_stack_elt) <typelist_val>: Now a pointer to
9614         std::vector.
9615         (type_stack_cleanup): Don't declare.
9616         (push_typelist): Update.
9617         * parse.c (pop_typelist): Return a std::vector.
9618         (push_typelist): Take a std::vector.
9619         (follow_types): Update.  Do not free args.
9620         (type_stack_cleanup): Remove.
9621         * c-exp.y (struct c_parse_state): New.
9622         (cpstate): New global.
9623         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9624         (nonempty_typelist): Update.
9625         (func_mod): Create a new vector.
9626         (c_parse): Create a c_parse_state.
9627         (check_parameter_typelist): Do not delete params.
9628         (function_method): Update.  Do not delete type_list.
9629
9630 2019-01-06  Tom Tromey  <tom@tromey.com>
9631
9632         PR gdb/28155:
9633         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9634         check_typedef.
9635         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9636         (print_return_value): Likewise.
9637
9638 2019-01-05  Tom Tromey  <tom@tromey.com>
9639
9640         * contrib/cleanup_check.py: Remove.
9641         * contrib/gcc-with-excheck: Remove.
9642         * contrib/exsummary.py: Remove.
9643         * contrib/excheck.py: Remove.
9644
9645 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9646
9647         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9648         NULL. Initialize tpprev to NULL instead of assigning it
9649         to NULL on the next statement.
9650         * windows-nat.c (windows_delete_thread): Remove check for
9651         main_thread_id before printing thread exit notifications.
9652         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9653         Remove thread ID check against main_thread_id.
9654         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9655         windows_delete_thread.
9656         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9657
9658 2019-01-04  Tom Tromey  <tom@tromey.com>
9659
9660         * compile/compile.c (_initialize_compile): Use upper case for
9661         metasyntactic variables.
9662         * symmisc.c (_initialize_symmisc): Use upper case for
9663         metasyntactic variables.
9664         * psymtab.c (_initialize_psymtab): Use upper case for
9665         metasyntactic variables.
9666         * demangle.c (demangle_command): Use upper case for metasyntactic
9667         variables.
9668         (_initialize_demangler): Likewise.
9669         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9670         variables.
9671
9672 2019-01-03  Tom Tromey  <tom@tromey.com>
9673
9674         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9675
9676 2019-01-03  Tom Tromey  <tom@tromey.com>
9677
9678         * python/py-symtab.c (salpy_str): Update.
9679         (struct salpy_sal_object) <symtab>: Now a PyObject.
9680         (salpy_dealloc): Update.
9681         (del_objfile_sal): Use gdbpy_ref.
9682
9683 2019-01-03  Tom Tromey  <tom@tromey.com>
9684
9685         * python/py-type.c (convert_field): Use new_reference.  Return
9686         gdbpy_ref.
9687         (make_fielditem): Return gdbpy_ref.
9688         (typy_fields): Update.
9689         (typy_getitem): Update.
9690         (field_name): Return gdbpy_ref.  Use new_reference.
9691         (typy_iterator_iternext): Update.
9692
9693 2019-01-03  Tom Tromey  <tom@tromey.com>
9694
9695         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9696
9697 2019-01-03  Tom Tromey  <tom@tromey.com>
9698
9699         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9700         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9701         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9702         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9703         (pspy_set_type_printers): Likewise.
9704         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9705         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9706         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9707         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9708         (objfpy_set_type_printers): Likewise.
9709
9710 2019-01-03  Tom Tromey  <tom@tromey.com>
9711
9712         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9713         (gdbpy_print_stack): Use gdbpy_err_fetch.
9714         * python/python-internal.h (class gdbpy_err_fetch): New class.
9715         (class gdbpy_enter) <m_error_type, m_error_value,
9716         m_error_traceback>: Remove.
9717         <m_error>: New member.
9718         (gdbpy_exception_to_string): Don't declare.
9719         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9720         * python/py-value.c (convert_value_from_python): Use
9721         gdbpy_err_fetch.
9722         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9723         gdbpy_exception_to_string.
9724         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9725         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9726         gdbpy_err_fetch.
9727
9728 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9729
9730         * linux-nat.c (delete_lwp_cleanup): Delete.
9731         (struct lwp_deleter): New struct.
9732         (lwp_info_up): New typedef.
9733         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9734         lwp_info_up.
9735
9736 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9737
9738         * linux-fork.c (class scoped_switch_fork_info): New class.
9739         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9740
9741 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9742
9743         * valops.c (find_overload_match): Remove use of null_cleanup, and
9744         calls to do_cleanups.
9745
9746 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9747
9748         * compile/compile-cplus-types.c
9749         (compile_cplus_instance::decl_name): Handle changes to
9750         cp_func_name.
9751         * cp-support.c (cp_func_name): Update header comment, update
9752         return type.
9753         * cp-support.h (cp_func_name): Update return type in declaration.
9754         * valops.c (find_overload_match): Move temp_func local to top
9755         level of function and change its type.  Use temp_func to hold and
9756         delete temporary string obtained from cp_func_name.
9757
9758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9759
9760         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9761         gdb::char_vector, remove cleanup, and update uses of `msg`.
9762
9763 2019-01-03  Jim Wilson  <jimw@sifive.com>
9764
9765         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9766
9767 2019-01-02  Tom Tromey  <tom@tromey.com>
9768
9769         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9770         (tdesc_parse_xml): Remove cleanups.
9771         * target-descriptions.h (make_cleanup_free_target_description):
9772         Don't declare.
9773         (target_desc_deleter): New struct.
9774         (target_desc_up): New typedef.
9775         * target-descriptions.c (target_desc_deleter::operator()): Rename
9776         from free_target_description.
9777         (make_cleanup_free_target_description): Remove.
9778
9779 2019-01-02  Tom Tromey  <tom@tromey.com>
9780
9781         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9782         constructor, destructor.
9783         (linespec_parser): Remove typedef.
9784         (~linespec_parser): Rename from linespec_parser_delete.
9785         (linespec_lex_to_end, linespec_complete_label)
9786         (linespec_complete): Update.
9787         (decode_line_full): Remove cleanups.
9788         (decode_line_1): Update.
9789
9790 2019-01-02  Tom Tromey  <tom@tromey.com>
9791
9792         * python/python-internal.h (inferior_to_inferior_object): Change
9793         return type.
9794         * python/py-exitedevent.c (create_exited_event_object): Update.
9795         * python/py-inferior.c (inferior_to_inferior_object): Return
9796         gdbpy_ref.
9797         (python_new_inferior, python_inferior_deleted)
9798         (thread_to_thread_object, delete_thread_object)
9799         (build_inferior_list, gdbpy_selected_inferior): Update.
9800         * python/py-infthread.c (create_thread_object): Update.  Also fail
9801         if inferior_to_inferior_object fails.
9802
9803 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9804
9805         * inferior.h (class inferior) <displaced_step_state>: New field.
9806         * infrun.h (struct displaced_step_state): Move here from
9807         infrun.c.  Initialize fields, add constructor.
9808         <inf>: Remove field.
9809         <reset>: New method.
9810         * infrun.c (struct displaced_step_inferior_state): Move to
9811         infrun.h.
9812         (displaced_step_inferior_states): Remove.
9813         (get_displaced_stepping_state): Adust.
9814         (displaced_step_in_progress_any_inferior): Adjust.
9815         (displaced_step_in_progress_thread): Adjust.
9816         (displaced_step_in_progress): Adjust.
9817         (add_displaced_stepping_state): Remove.
9818         (get_displaced_step_closure_by_addr): Adjust.
9819         (remove_displaced_stepping_state): Remove.
9820         (infrun_inferior_exit): Call displaced_step_state.reset.
9821         (use_displaced_stepping): Don't check for NULL.
9822         (displaced_step_prepare_throw): Call
9823         get_displaced_stepping_state.
9824         (displaced_step_fixup): Don't check for NULL.
9825         (prepare_for_detach): Don't check for NULL.
9826
9827 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9828
9829         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9830          in case of call that did not complete.
9831
9832 2019-01-02  Andrey Utkin  <autkin@undo.io>
9833
9834         * symfile.c (find_separate_debug_file): Fix search of debug files for
9835         remote debuggee.
9836
9837 2019-01-02  Tom Tromey  <tom@tromey.com>
9838
9839         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9840         indentation.
9841         * python/py-frame.c (frapy_older): Remove cast.
9842         (frapy_newer): Likewise.
9843         * python/py-breakpoint.c (local_setattro): Remove cast.
9844         * python/py-arch.c (archpy_name): Remove local variable.
9845         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9846
9847 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9848
9849         * unittests/basic_string_view/element_access/char/empty.cc:
9850         Fix year range in copyright header.
9851
9852 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9853
9854         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9855         Delete.
9856         <operator==>: Update with for removed field.
9857         <hash>: Likewise.
9858         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9859         <isa_features>: ...this.
9860         <abi_features>: New field.
9861         (riscv_isa_flen): Update comment.
9862         (riscv_abi_xlen): New declaration.
9863         (riscv_abi_flen): New declaration.
9864         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9865         isa_features.
9866         (riscv_abi_xlen): New function.
9867         (riscv_isa_flen): Update to get answer from isa_features.
9868         (riscv_abi_flen): New function.
9869         (riscv_has_fp_abi): Update to get answer from abi_features.
9870         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9871         xlen and flen.
9872         (riscv_call_info) <xlen, flen>: Update comment.
9873         (riscv_call_arg_struct): Remove invalid assertions
9874         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9875         is removed.
9876         (riscv_gdbarch_init): Gather isa features and abi features
9877         separately, ensure both match on the gdbarch when reusing an old
9878         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9879         a target with 64-bit float hardware.
9880
9881 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9882
9883         * source.c (search_command_helper): Stop reverse search
9884         when line 1 has been searched.
9885
9886 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9887
9888         * record-full.c (record_full_base_target::close): Rewrite
9889         record_full_core_buf_list free logic.
9890
9891 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9892
9893         * break-catch-syscall.c (print_one_catch_syscall): xfree
9894         the last text.
9895
9896 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9897
9898         * top.c (print_gdb_version): Update Copyright year in version
9899         message.
9900
9901 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9902
9903         Update copyright year range in all GDB files.
9904
9905 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9906
9907         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9908
9909 For older changes see ChangeLog-2018.
9910 \f
9911 Local Variables:
9912 mode: change-log
9913 left-margin: 8
9914 fill-column: 74
9915 version-control: never
9916 coding: utf-8
9917 End:
9918