gdb/ChangeLog

   1 2019-04-01  Tom Tromey  <tromey@adacore.com>
   2
   3         PR symtab/23331:
   4         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
   5
   6 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
   7             Pedro Alves  <palves@redhat.com>
   8
   9         * top.c (quit_force): Call 'finalize_values'.
  10         * value.c (finalize_values): New function.
  11         * value.h (finalize_values): Declare.
  12
  13 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  14
  15         * NEWS: Announce $_gdb_major and $_gdb_minor.
  16
  17         * top.c (init_gdb_version_vars): New function.
  18         (gdb_init): Call init_gdb_version_vars.
  19
  20 2019-03-29  Tom Tromey  <tromey@adacore.com>
  21
  22         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  23         help text.  Remove dead code.
  24
  25 2019-03-29  Keith Seitz  <keiths@redhat.com>
  26
  27         From Siddhesh Poyarekar:
  28         * f-lang.h (f77_get_upperbound): Return LONGEST.
  29         (f77_get_lowerbound): Likewise.
  30         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  31         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  32         print them.
  33         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  34         plongest to format print it.
  35         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  36         (f77_get_upperbound): Likewise.
  37         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  38         LOWER_BOUND to LONGEST.
  39         (f77_create_arrayprint_offset_tbl): Likewise.
  40
  41 2019-03-29  Keith Seitz  <keiths@redhat.com>
  42
  43         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  44         %s/pulongest for TYPE_LENGTH instead of %d in format
  45         strings.
  46         * ada-typerint.c (ada_print_type): Likewise.
  47         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  48         * compile/compile-c-support.c (generate_register_struct): Likewise.
  49         * gdbtypes.c (recursive_dump_type): Likewise.
  50         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  51         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  52         instead of %d in format strings.
  53         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  54         to std::min to ULONGEST.
  55         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  56         instead of %d in format strings.
  57         * tracepoint.c (info_scope_command): Likewise.
  58         * typeprint.c (print_offset_data::update)
  59         (print_offset_data::finish): Likewise.
  60         * xtensa-tdep.c (xtensa_store_return_value)
  61         (xtensa_push_dummy_call): Likewise.
  62
  63 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  64
  65         * windows-nat.c (display_selector): Fixed format specifications
  66         for 64-bit Cygwin.
  67
  68 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  69
  70         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  71
  72 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  73
  74         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  75         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  76         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  77         (nios2_linux_init_abi): Install it.
  78
  79 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  80
  81         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  82
  83 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  84
  85         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  86
  87 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  88             Tom Tromey  <tromey@adacore.com>
  89
  90         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  91
  92 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  93
  94         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  95         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  96         method to compute the bounds of range types. Also print "[evaluated]"
  97         if the bounds' values come from a dynamic evaluation.
  98
  99 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 100
 101         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 102         whitespace when pretty printing is on.
 103
 104 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 105
 106         * ppc-linux-nat.c: Add include.
 107
 108 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 109
 110         * NEWS: Mention AArch64 Pointer Authentication.
 111
 112 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 113
 114         * arm-linux-nat.c: Add include.
 115
 116 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 117
 118         * source-cache.c (source_cache::get_source_lines): Re-read
 119         fullname after calling open_source_file.
 120
 121 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 122
 123         * NEWS: Mention TLS support for FreeBSD.
 124
 125 2019-03-25  Tom Tromey  <tromey@adacore.com>
 126
 127         * minsyms.c (BUNCH_SIZE): Update comment.
 128         (~minimal_symbol_reader): Remove old comment.
 129         (compact_minimal_symbols): Update comment.
 130         (minimal_symbol_reader::install): Remove old comment.  Update
 131         other comments.
 132
 133 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 134
 135         * s390-linux-nat.c: Add include.
 136
 137 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 138
 139         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 140         Call linux_get_hwcap.
 141         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 142         Likewise.
 143         (aarch64_linux_get_hwcap): Remove function.
 144         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 145         declaration.
 146         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 147         linux_get_hwcap.
 148         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 149         * linux-tdep.c (linux_get_hwcap): Add function.
 150         (linux_get_hwcap2): Likewise.
 151         * linux-tdep.h (linux_get_hwcap): Add declaration.
 152         (linux_get_hwcap2): Likewise.
 153         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 154         (ppc_linux_get_hwcap2): Likewise.
 155         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 156         linux_get_hwcap.
 157         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 158         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 159         (ppc_linux_nat_target::read_description): Likewise.
 160         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 161         * s390-linux-nat.c: Likewise.
 162         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 163
 164 2019-03-24  Tom Tromey  <tom@tromey.com>
 165
 166         * ada-lang.c (standard_lookup): Simplify initialization.
 167         (ada_lookup_symbol_nonlocal): Simplify return.
 168         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 169         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 170         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 171         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 172         initialization.
 173         * solib.c (solib_global_lookup): Simplify.
 174         * symtab.c (null_block_symbol): Remove.
 175         (symbol_cache_lookup): Simplify returns.
 176         (lookup_language_this): Simplify returns.
 177         (lookup_symbol_aux): Simplify return.
 178         (lookup_local_symbol): Simplify returns.
 179         (lookup_global_symbol_from_objfile): Simplify return.
 180         (lookup_symbol_in_objfile_symtabs)
 181         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 182         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 183         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 184         * cp-namespace.c (cp_lookup_bare_symbol)
 185         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 186         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 187         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 188         (cp_lookup_symbol_via_imports): Simplify initialization.
 189         (find_symbol_in_baseclass): Likewise.
 190         * symtab.h (null_block_symbol): Remove.
 191         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 192         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 193         (d_lookup_symbol_module): Likewise.
 194         (find_symbol_in_baseclass): Simplify initialization.
 195
 196 2019-03-24  Tom Tromey  <tom@tromey.com>
 197
 198         * expression.h: Don't include symtab.h.
 199         (struct block): Forward declare.
 200
 201 2019-03-24  Tom Tromey  <tom@tromey.com>
 202
 203         * c-exp.y (typebase): Remove casts.
 204         * gdbtypes.c (lookup_unsigned_typename, )
 205         (lookup_signed_typename): Remove cast.
 206         * eval.c (parse_to_comma_and_eval): Remove cast.
 207         * parse.c (write_dollar_variable): Remove cast.
 208         * block.h (struct block) <superblock>: Now const.
 209         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 210         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 211         (map_block): Make "block" const.
 212         * symfile.h (struct quick_symbol_functions)
 213         <map_matching_symbols>: Constify block argument to "callback".
 214         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 215         const.
 216         (find_pc_sect_compunit_symtab): Make "b" const.
 217         (find_symbol_at_address): Likewise.
 218         (search_symbols): Likewise.
 219         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 220         (dw2_debug_names_lookup_symbol): Likewise.
 221         (dw2_map_matching_symbols): Update.
 222         * p-valprint.c (pascal_val_print): Remove "block".
 223         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 224         (aux_add_nonlocal_symbols): Make "block" const.
 225         (resolve_subexp): Remove cast.
 226         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 227         const.
 228         (iterate_over_file_blocks): Likewise.
 229         * f-exp.y (%union) <bval>: Remove.
 230         * coffread.c (patch_opaque_types): Make "b" const.
 231         * spu-tdep.c (spu_catch_start): Make "block" const.
 232         * c-valprint.c (print_unpacked_pointer): Remove "block".
 233         * symmisc.c (dump_symtab_1): Make "b" const.
 234         (block_depth): Make "block" const.
 235         * d-exp.y (%union) <bval>: Remove.
 236         * cp-support.h (cp_lookup_rtti_type): Update.
 237         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 238         * psymtab.c (psym_lookup_symbol): Make "block" const.
 239         (maintenance_check_psymtabs): Make "b" const.
 240         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 241         (enumerate_locals, enumerate_args): Update.
 242         * python/py-symtab.c (stpy_global_block): Make "block" const.
 243         (stpy_static_block): Likewise.
 244         * inline-frame.c (block_starting_point_at): Make "new_block"
 245         const.
 246         * block.c (find_block_in_blockvector): Make return type const.
 247         (blockvector_for_pc_sect): Make "b" const.
 248         (find_block_in_blockvector): Make "b" const.
 249
 250 2019-03-23  Tom Tromey  <tom@tromey.com>
 251
 252         * varobj.c (varobj_create): Update.
 253         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 254         * printcmd.c (display_command, do_one_display): Don't reset
 255         innermost_block.
 256         * parser-defs.h (enum innermost_block_tracker_type): Move to
 257         expression.h.
 258         (innermost_block): Update comment.
 259         * parse.c (parse_exp_1): Add tracker_types parameter.
 260         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 261         tracker_types parameter.  Reset innermost_block.
 262         (parse_exp_in_context): Remove.
 263         (parse_expression_for_completion): Update.
 264         * objfiles.c (~objfile): Don't reset expression_context_block or
 265         innermost_block.
 266         * expression.h (enum innermost_block_tracker_type): Move from
 267         parser-defs.h.
 268         (parse_exp_1): Add tracker_types parameter.
 269         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 270         reset innermost_block.
 271
 272 2019-03-23  Tom Tromey  <tom@tromey.com>
 273
 274         * objfiles.h: Include bcache.h.
 275
 276 2019-03-23  Tom Tromey  <tom@tromey.com>
 277
 278         * linespec.c (get_current_search_block): Use
 279         scoped_restore_current_language.
 280         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 281
 282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 283             Jiong Wang  <jiong.wang@arm.com>
 284
 285         * aarch64-linux-tdep.c
 286         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 287         section.
 288         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 289
 290 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 291             Jiong Wang  <jiong.wang@arm.com>
 292
 293         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 294         instructions.
 295         (aarch64_analyze_prologue_test): Add PACIASP test.
 296         (aarch64_prologue_prev_register): Unmask PC value.
 297
 298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 299             Jiong Wang  <jiong.wang@arm.com>
 300
 301         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 302         (aarch64_dwarf2_prev_register): Unmask PC value.
 303         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 304         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 305         DW_CFA_AARCH64_negate_ra_state.
 306         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 307
 308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 309             Jiong Wang  <jiong.wang@arm.com>
 310
 311         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 312         registers.
 313         (aarch64_pseudo_register_name): Likewise.
 314         (aarch64_pseudo_register_type): Likewise.
 315         (aarch64_pseudo_register_reggroup_p): Likewise.
 316         (aarch64_gdbarch_init): Add pauth registers.
 317         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 318         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 319         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 320         (struct gdbarch_tdep): Add regnum for ra_state.
 321
 322 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 323             Jiong Wang  <jiong.wang@arm.com>
 324
 325         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 326
 327 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 328             Jiong Wang  <jiong.wang@arm.com>
 329
 330         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 331         function.
 332         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 333         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 334         (aarch64_gdbarch_init): Add puth registers.
 335         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 336         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 337         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 338
 339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 340             Jiong Wang  <jiong.wang@arm.com>
 341
 342         * aarch64-linux-nat.c
 343         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 344         * aarch64-linux-tdep.c
 345         (aarch64_linux_core_read_description): Likewise.
 346         (aarch64_linux_get_hwcap): New function.
 347         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 348         (aarch64_linux_get_hwcap): New declaration.
 349
 350 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 351             Jiong Wang  <jiong.wang@arm.com>
 352
 353         * aarch64-linux-nat.c
 354         (aarch64_linux_nat_target::read_description): Add pauth param.
 355         * aarch64-linux-tdep.c
 356         (aarch64_linux_core_read_description): Likewise.
 357         * aarch64-tdep.c (struct target_desc): Add in pauth.
 358         (aarch64_read_description): Add pauth param.
 359         (aarch64_gdbarch_init): Likewise.
 360         * aarch64-tdep.h (aarch64_read_description): Likewise.
 361         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 362         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 363         * features/Makefile: Add new files.
 364         * features/aarch64-pauth.c: New file.
 365         * features/aarch64-pauth.xml: New file.
 366
 367 2019-03-20  Tom Tromey  <tromey@adacore.com>
 368
 369         * infrun.c (handle_inferior_event): Rename from
 370         handle_inferior_event_1.  Create a scoped_value_mark.
 371         (handle_inferior_event): Remove.
 372
 373 2019-03-19  Tom Tromey  <tromey@adacore.com>
 374
 375         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 376         * infrun.h (print_stop_event): Add "displays" parameter.
 377         * infrun.c (print_stop_event): Add "displays" parameter.
 378
 379 2019-03-19  Pedro Alves  <palves@redhat.com>
 380
 381         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 382         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 383         to -1.  Fix TABs vs spaces.
 384         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 385         * tui/tui-out.h (tui_ui_out) Add intro comments.
 386         <m_line, m_start_of_line>: In-class initialize, and add describing
 387         comment.
 388
 389 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 390
 391         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 392         variable names.
 393         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 394
 395 2019-03-18  Pedro Alves  <palves@redhat.com>
 396             Eli Zaretskii <eliz@gnu.org>
 397
 398         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 399         m_line and m_start_of_line.
 400
 401 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 402
 403         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 404         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 405         it returns a newline.  This fixes a regression in TU mode, whereby
 406         the next line is output on the same screen line as the user input.
 407
 408 2019-03-18  Tom Tromey  <tromey@adacore.com>
 409
 410         * minsyms.c (minimal_symbol_reader::install): Remove call to
 411         obstack_blank.
 412
 413 2019-03-18  Pedro Alves  <palves@redhat.com>
 414
 415         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 416         New globals.
 417         (apply_style): New, factored out from ...
 418         (apply_ansi_escape): ... this.  Handle reverse video mode.
 419         (tui_set_reverse_mode): New function.
 420         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 421         * tui/tui-winsource.c (tui_show_source_line): Use
 422         tui_set_reverse_mode instead of setting A_STANDOUT.
 423         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 424         New setter methods.
 425
 426 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 427
 428         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 429         Handle tabs.
 430
 431 2019-03-18  Tom Tromey  <tromey@adacore.com>
 432
 433         * ada-lang.c (empty_array): Add "high" parameter.
 434         (ada_evaluate_subexp): Update.
 435
 436 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 437
 438         * unittests/string_view-selftests.c: Define
 439         _initialize_string_view_selftests unconditionally.
 440
 441 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 442
 443         PR gdb/24350
 444         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 445
 446 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 447
 448         PR gdb/24351
 449         * windows-nat.c (display_selector): Fix format specifiers.
 450
 451 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 452
 453         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 454         tui_refill_source_window instead of tui_refresh_win, to update the
 455         current execution line.  This fixes redisplay of the current line
 456         when stepping through the code with "next" or "step".
 457
 458 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 459
 460         * source-cache.c (source_cache::get_source_lines): Call
 461         find_source_lines to initialize s->nlines.  This fixes vertical
 462         scrolling of TUI source window when the DOWN arrow is pressed.
 463
 464 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 465
 466         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 467         linux-thread-db.c (_initialize_thread_db): Likewise.
 468
 469 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 470
 471         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 472         wclrtoeol in tui_show_source_line".  This reverts changes made in
 473         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 474
 475 2019-03-15  Tom Tromey  <tom@tromey.com>
 476
 477         * symtab.h (struct minimal_symbol): Derive from
 478         general_symbol_info.
 479         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 480         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 481         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 482         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 483         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 484         (MSYMBOL_SEARCH_NAME): Update.
 485         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 486         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 487         * minsyms.c (minimal_symbol_reader::record_full): Update.
 488
 489 2019-03-15  Tom Tromey  <tom@tromey.com>
 490
 491         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 492
 493 2019-03-15  Tom Tromey  <tom@tromey.com>
 494
 495         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 496         unique_xmalloc_ptr.
 497         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 498         Update.
 499         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 500         (build_minimal_symbol_hash_tables)
 501         (minimal_symbol_reader::install): Update.
 502
 503 2019-03-15  Tom Tromey  <tom@tromey.com>
 504
 505         * symtab.c (create_demangled_names_hash): Update.
 506         (symbol_set_names): Update.
 507         * objfiles.h (struct objfile_per_bfd_storage)
 508         <demangled_names_hash>: Now an htab_up.
 509         * objfiles.c (objfile_per_bfd_storage): Simplify.
 510
 511 2019-03-15  Tom Tromey  <tom@tromey.com>
 512
 513         * objfiles.h (struct objfile_per_bfd_storage): Declare
 514         destructor.
 515         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 516         New.
 517         (get_objfile_bfd_data): Use new.  Don't initialize
 518         language_of_main.
 519         (free_objfile_per_bfd_storage): Remove.
 520         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 521
 522 2019-03-15  Tom Tromey  <tom@tromey.com>
 523
 524         * symfile.c (reread_symbols): Update.
 525         * objfiles.c (objfile::objfile): Update.
 526         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 527         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 528         comment.
 529         (minimal_symbol_reader::install): Update.
 530         (terminate_minimal_symbol_table): Remove.
 531         * jit.c (jit_object_close_impl): Update.
 532
 533 2019-03-15  Tom Tromey  <tom@tromey.com>
 534
 535         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 536         initializations.
 537
 538 2019-03-15  Tom Tromey  <tom@tromey.com>
 539
 540         * objfiles.h (struct objfile_per_bfd_storage)
 541         <demangled_hash_languages>: Now a bitset.
 542         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 543         (lookup_minimal_symbol): Update.
 544
 545 2019-03-15  Tom Tromey  <tom@tromey.com>
 546
 547         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 548         Don't return the symbol.
 549         * coffread.c (record_minimal_symbol): Use record_full.
 550
 551 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 552
 553         The MS-Windows port of ncurses fails to switch to a color pair if
 554         one or both of the colors are the implicit default colors.  This
 555         change records the default colors when TUI is initialized, and
 556         then specifies them explicitly when a color pair uses the default
 557         colors.  This allows color styling in TUI mode on MS-Windows.
 558
 559         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 560         ncurses_norm_attr.
 561         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 562         colors in ncurses_norm_attr.
 563         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 564         "none", replace it with the default color recorded in
 565         ncurses_norm_attr.
 566
 567 2019-03-14  Tom Tromey  <tromey@adacore.com>
 568
 569         * source-cache.h (class source_cache) <get_source_lines>: Return
 570         std::string.
 571         * source-cache.c (source_cache::extract_lines): Handle case where
 572         first_pos==npos.  Return std::string.
 573         (source_cache::get_source_lines): Update.
 574
 575 2019-03-14  Tom Tromey  <tromey@adacore.com>
 576
 577         * NEWS: Add item for "style sources" commands.
 578         * source-cache.c (source_cache::get_source_lines): Check
 579         source_styling.
 580         * cli/cli-style.c (source_styling): New global.
 581         (_initialize_cli_style): Add "style sources" commands.
 582         (show_style_sources): New function.
 583         * cli/cli-style.h (source_styling): Declare.
 584
 585 2019-03-14  Pedro Alves  <palves@redhat.com>
 586             Tom Tromey  <tromey@adacore.com>
 587
 588         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 589         * tui/tui-winsource.c (tui_refill_source_window): New function,
 590         from...
 591         (tui_horizontal_source_scroll): ... here.  Move some logic.
 592         * cli/cli-style.c (set_style_enabled): Notify new observable.
 593         * tui/tui-hooks.c (tui_redisplay_source): New function.
 594         (tui_attach_detach_observers): Attach or detach
 595         tui_redisplay_source.
 596         * observable.h (source_styling_changed): New observable.
 597         * observable.c: Define source_styling_changed observable.
 598
 599 2019-03-13  Tom Tromey  <tromey@adacore.com>
 600
 601         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 602         (i386_gnu_nat_target::store_registers): Update.
 603         * target-debug.h (target_debug_print_std_string): New macro.
 604         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 605         * windows-tdep.c (display_one_tib): Update.
 606         * tui/tui-stack.c (tui_make_status_line): Update.
 607         * top.c (print_inferior_quit_action): Update.
 608         * thread.c (thr_try_catch_cmd): Update.
 609         (add_thread_with_info): Update.
 610         (thread_target_id_str): Update.
 611         (thr_try_catch_cmd): Update.
 612         (thread_command): Update.
 613         (thread_find_command): Update.
 614         * record-btrace.c (record_btrace_target::info_record)
 615         (record_btrace_resume_thread, record_btrace_target::resume)
 616         (record_btrace_cancel_resume, record_btrace_step_thread)
 617         (record_btrace_target::wait, record_btrace_target::wait)
 618         (record_btrace_target::wait, record_btrace_target::stop): Update.
 619         * progspace.c (print_program_space): Update.
 620         * process-stratum-target.c
 621         (process_stratum_target::thread_address_space): Update.
 622         * linux-fork.c (linux_fork_mourn_inferior)
 623         (detach_checkpoint_command, info_checkpoints_command)
 624         (linux_fork_context): Update.
 625         (linux_fork_detach): Update.
 626         (class scoped_switch_fork_info): Update.
 627         (delete_checkpoint_command): Update.
 628         * infrun.c (follow_fork_inferior): Update.
 629         (follow_fork_inferior): Update.
 630         (proceed_after_vfork_done): Update.
 631         (handle_vfork_child_exec_or_exit): Update.
 632         (follow_exec): Update.
 633         (displaced_step_prepare_throw): Update.
 634         (displaced_step_restore): Update.
 635         (start_step_over): Update.
 636         (resume_1): Update.
 637         (clear_proceed_status_thread): Update.
 638         (proceed): Update.
 639         (print_target_wait_results): Update.
 640         (do_target_wait): Update.
 641         (context_switch): Update.
 642         (stop_all_threads): Update.
 643         (restart_threads): Update.
 644         (finish_step_over): Update.
 645         (handle_signal_stop): Update.
 646         (switch_back_to_stepped_thread): Update.
 647         (keep_going_pass_signal): Update.
 648         (print_exited_reason): Update.
 649         (normal_stop): Update.
 650         * inferior.c (inferior_pid_to_str): Change return type.
 651         (print_selected_inferior): Update.
 652         (add_inferior): Update.
 653         (detach_inferior): Update.
 654         * dummy-frame.c (fprint_dummy_frames): Update.
 655         * dcache.c (dcache_info_1): Update.
 656         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 657         (btrace_fetch, btrace_clear): Update.
 658         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 659         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 660         type.
 661         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 662         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 663         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 664         * gdbarch.c, gdbarch.h: Rebuild.
 665         * gdbarch.sh (core_pid_to_str): Change return type.
 666         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 667         return type.
 668         (windows_nat_target::pid_to_str): Change return type.
 669         (windows_delete_thread): Update.
 670         (windows_nat_target::attach): Update.
 671         (windows_nat_target::files_info): Update.
 672         * target-delegates.c: Rebuild.
 673         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 674         return type.
 675         (sol_thread_target::pid_to_str): Change return type.
 676         * remote.c (class remote_target) <pid_to_str>: Change return
 677         type.
 678         (remote_target::pid_to_str): Change return type.
 679         (extended_remote_target::attach, remote_target::remote_stop_ns)
 680         (remote_target::remote_notif_remove_queued_reply)
 681         (remote_target::push_stop_reply, remote_target::disable_btrace):
 682         Update.
 683         (extended_remote_target::attach): Update.
 684         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 685         type.
 686         (gdbsim_target::pid_to_str): Change return type.
 687         * ravenscar-thread.c (struct ravenscar_thread_target)
 688         <pid_to_str>: Change return type.
 689         (ravenscar_thread_target::pid_to_str): Change return type.
 690         * procfs.c (class procfs_target) <pid_to_str>: Change return
 691         type.
 692         (procfs_target::pid_to_str): Change return type.
 693         (procfs_target::attach): Update.
 694         (procfs_target::detach): Update.
 695         (procfs_target::fetch_registers): Update.
 696         (procfs_target::store_registers): Update.
 697         (procfs_target::wait): Update.
 698         (procfs_target::files_info): Update.
 699         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 700         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 701         return type.
 702         (nto_procfs_target::pid_to_str): Change return type.
 703         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 704         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 705         return type.
 706         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 707         (exit_lwp): Update.
 708         (attach_proc_task_lwp_callback, get_detach_signal)
 709         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 710         (linux_nat_target::resume, wait_lwp, stop_callback)
 711         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 712         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 713         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 714         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 715         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 716         type.
 717         (inf_ptrace_target::attach): Update.
 718         (inf_ptrace_target::files_info): Update.
 719         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 720         type.
 721         (go32_nat_target::pid_to_str): Change return type.
 722         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 723         (gnu_nat_target::wait): Update.
 724         (gnu_nat_target::wait): Update.
 725         (gnu_nat_target::resume): Update.
 726         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 727         (fbsd_nat_target::wait): Update.
 728         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 729         type.
 730         (darwin_nat_target::attach): Update.
 731         * corelow.c (class core_target) <pid_to_str>: Change return type.
 732         (core_target::pid_to_str): Change return type.
 733         * target.c (normal_pid_to_str): Change return type.
 734         (default_pid_to_str): Likewise.
 735         (target_pid_to_str): Change return type.
 736         (target_translate_tls_address): Update.
 737         (target_announce_detach): Update.
 738         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 739         return type.
 740         (bsd_uthread_target::pid_to_str): Change return type.
 741         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 742         type.
 743         (bsd_kvm_target::pid_to_str): Change return type.
 744         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 745         return type.
 746         (aix_thread_target::pid_to_str): Change return type.
 747         * target.h (struct target_ops) <pid_to_str>: Change return type.
 748         (target_pid_to_str, normal_pid_to_str): Likewise.
 749         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 750         type.
 751         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 752         type.
 753         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 754         return type.
 755         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 756         type.
 757         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 758         type.
 759         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 760         return type.
 761
 762 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 763
 764         * NEWS: Mention that the new default MI version is 3.  Mention
 765         changes to the output of commands and events that deal with
 766         multi-location breakpoints.
 767         * breakpoint.c: Include "mi/mi-out.h".
 768         (print_one_breakpoint): Change output syntax if using MI version
 769         >= 3.
 770         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 771         New.
 772         (mi_multi_location_breakpoint_output_fixed): New.
 773         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 774         (mi_cmd_fix_multi_location_breakpoint_output): New.
 775         (mi_multi_location_breakpoint_output_fixed): New.
 776         * mi/mi-cmds.c (mi_cmds): Register command
 777         -fix-multi-location-breakpoint-output.
 778         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 779         interpreter "mi".
 780
 781 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 782
 783         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 784         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 785         instantiate mi_ui_out based on interpreter name.
 786         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 787         * mi/mi-main.c (mi_load_progress): Likewise.
 788
 789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 790
 791         * NEWS: Combine separate "New targets" sections for 8.3.
 792
 793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 794
 795         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 796         (ppcfbsd_init_abi): Install gdbarch
 797         "fetch_tls_load_module_address" and "get_thread_local_address"
 798         methods.
 799
 800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 801
 802         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 803         (riscv_fbsd_init_abi): Install gdbarch
 804         "fetch_tls_load_module_address" and "get_thread_local_address"
 805         methods.
 806
 807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 808
 809         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 810         (i386fbsd_init_abi): Install gdbarch
 811         "fetch_tls_load_module_address" and "get_thread_local_address"
 812         methods.
 813
 814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 815
 816         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 817         (amd64fbsd_init_abi): Install gdbarch
 818         "fetch_tls_load_module_address" and "get_thread_local_address"
 819         methods.
 820
 821 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 822
 823         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 824         (struct fbsd_pspace_data): New type.
 825         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 826         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 827         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 828         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 829         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 830
 831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 832
 833         * gdbtypes.c (lookup_struct_elt): New function.
 834         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 835         * gdbtypes.h (struct struct_elt): New type.
 836         (lookup_struct_elt): New prototype.
 837
 838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 839
 840         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 841         remove disabled code block.
 842
 843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 844
 845         * gdbarch.sh (get_thread_local_address): New method.
 846         * gdbarch.h, gdbarch.c: Regenerate.
 847         * target.c (target_translate_tls_address): Use
 848         gdbarch_get_thread_local_address if present instead of
 849         target::get_thread_local_address.
 850
 851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 852
 853         * target.h (target::get_thread_local_address): Update comment.
 854
 855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 856
 857         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 858         objfile->separate_debug_objfile_backlink if not NULL.
 859
 860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 861
 862         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 863         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 864         (amd64bsd_store_inferior_registers): Likewise.
 865         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 866         Enable segment base registers.
 867         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 868         PT_GETFSBASE and PT_GETGSBASE.
 869         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 870         PT_SETGSBASE.
 871         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 872         segment base registers.
 873         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 874
 875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 876
 877         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 878         Update calls to i386_target_description to add 'segments'
 879         parameter.
 880         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 881         add segment base registers.
 882         * arch/i386.c (i386_create_target_description): Add 'segments'
 883         parameter to enable segment base registers.
 884         * arch/i386.h (i386_create_target_description): Likewise.
 885         * features/i386/32bit-segments.xml: New file.
 886         * features/i386/32bit-segments.c: Generate.
 887         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 888         call to i386_target_description to add 'segments' parameter.
 889         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 890         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 891         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 892         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 893         if feature is present.
 894         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 895         Add 'segments' parameter to call to i386_target_description.
 896         (i386_target_description): Add 'segments' parameter to enable
 897         segment base registers.
 898         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 899         to call to i386_target_description.
 900         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 901         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 902         Define I386_NUM_REGS.
 903         (i386_target_description): Add 'segments' parameter to enable
 904         segment base registers.
 905
 906 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 907
 908         PR/24325
 909         * source-cache.c: #undef open and close, to avoid unresolved
 910         externals during linking.
 911
 912 2019-03-12  Tom Tromey  <tromey@adacore.com>
 913
 914         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 915         const.  Add initializers.
 916         (_initialize_remote): Don't initialize ptid globals.
 917
 918 2019-03-12  Pedro Alves  <palves@redhat.com>
 919
 920         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 921
 922 2019-03-12  Pedro Alves  <palves@redhat.com>
 923
 924         * cp-name-parser.y (main): Remove unused 'len' variable.
 925
 926 2019-03-12  Tom Tromey  <tromey@adacore.com>
 927
 928         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 929         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 930
 931 2019-03-12  Tom Tromey  <tromey@adacore.com>
 932
 933         * linux-nat.c (iterate_over_lwps): Update.
 934         (stop_callback): Remove parameter.
 935         (stop_wait_callback, detach_callback, resume_set_callback)
 936         (select_singlestep_lwp_callback, set_ignore_sigint)
 937         (status_callback, resumed_callback, resume_clear_callback)
 938         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 939         data parameter.
 940         (linux_nat_target::detach, linux_nat_target::resume)
 941         (linux_stop_and_wait_all_lwps, select_event_lwp)
 942         (linux_nat_filter_event, linux_nat_wait_1)
 943         (linux_nat_target::kill, linux_nat_target::stop)
 944         (linux_nat_target::stop): Update.
 945         (linux_nat_resume_callback): Change type.
 946         (resume_stopped_resumed_lwps, count_events_callback)
 947         (select_event_lwp_callback): Likewise.
 948         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 949         * arm-linux-nat.c (struct update_registers_data): Remove.
 950         (update_registers_callback): Change type.
 951         (arm_linux_insert_hw_breakpoint1): Update.
 952         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 953         parameter.
 954         (x86_linux_dr_set_addr): Update.
 955         (x86_linux_dr_set_control): Update.
 956         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 957         (iterate_over_lwps): Use gdb::function_view.
 958         * nat/aarch64-linux-hw-point.c (struct
 959         aarch64_dr_update_callback_param): Remove.
 960         (debug_reg_change_callback): Change type.
 961         (aarch64_notify_debug_reg_change): Update.
 962         * s390-linux-nat.c (s390_refresh_per_info): Update.
 963
 964 2019-03-11  Tom Tromey  <tromey@adacore.com>
 965
 966         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 967         redundant assignment to "this_cu".
 968
 969 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 970
 971         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 972
 973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 974
 975         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 976         from...
 977         (rank_one_type): ... this.
 978
 979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 980
 981         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 982         from...
 983         (rank_one_type): ... this.
 984
 985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 986
 987         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 988         from...
 989         (rank_one_type): ... this.
 990
 991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 992
 993         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 994         from...
 995         (rank_one_type): ... this.
 996
 997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 998
 999         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1000         from...
1001         (rank_one_type): ... this.
1002
1003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1004
1005         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1006         from...
1007         (rank_one_type): ... this.
1008
1009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1012         from...
1013         (rank_one_type): ... this.
1014
1015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1018         from...
1019         (rank_one_type): ... this.
1020
1021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1022
1023         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1024         from...
1025         (rank_one_type): ... this.
1026
1027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1028
1029         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1030         from...
1031         (rank_one_type): ... this.
1032
1033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1034
1035         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1036         from...
1037         (rank_one_type): ... this.
1038
1039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1040
1041         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1042         from...
1043         (rank_one_type): ... this.
1044
1045 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1046
1047         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1048         inferior-events' shows the example events.
1049
1050 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1051
1052         Support styling on native MS-Windows console
1053
1054         PR/24315
1055         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1056         on MS-Windows if $TERM is not defined.
1057
1058         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1059
1060         * posix-hdep.c (gdb_console_fputs):
1061         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1062         functions.
1063         * ui-file.h (gdb_console_fputs): Add prototype.
1064
1065         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1066         back to fputs only if the former returns zero.
1067
1068 2019-03-07  Tom Tromey  <tom@tromey.com>
1069
1070         * symmisc.c (print_symbol_bcache_statistics): Update.
1071         (print_objfile_statistics): Update.
1072         * symfile.c (allocate_symtab): Update.
1073         * stabsread.c: Don't include bcache.h.
1074         * psymtab.h (struct psymbol_bcache): Don't declare.
1075         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1076         (psymbol_bcache_init, psymbol_bcache_free)
1077         (psymbol_bcache_get_bcache): Don't declare.
1078         * psymtab.c (struct psymbol_bcache): Remove.
1079         (psymtab_storage::psymtab_storage): Update.
1080         (psymtab_storage::~psymtab_storage): Update.
1081         (psymbol_bcache_init, psymbol_bcache_free)
1082         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1083         (add_psymbol_to_bcache): Update.
1084         (allocate_psymtab): Update.
1085         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1086         macro_cache>: No longer pointers.
1087         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1088         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1089         * macrotab.c (macro_bcache): Update.
1090         * macroexp.c: Don't include bcache.h.
1091         * gdbtypes.c (check_types_worklist): Update.
1092         (types_deeply_equal): Remove TRY/CATCH.  Update.
1093         * elfread.c (elf_symtab_read): Update.
1094         * dwarf2read.c: Don't include bcache.h.
1095         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1096         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1097         (print_bcache_statistics, bcache_memory_used): Don't declare.
1098         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1099         methods.  Rename all data members.
1100         * bcache.c (struct bcache): Move to bcache.h.
1101         (bcache::expand_hash_table): Rename from expand_hash_table.
1102         (bcache): Remove.
1103         (bcache::insert): Rename from bcache_full.
1104         (bcache::compare): Rename from bcache_compare.
1105         (bcache_xmalloc): Remove.
1106         (bcache::~bcache): Rename from bcache_xfree.
1107         (bcache::print_statistics): Rename from print_bcache_statistics.
1108         (bcache::memory_used): Rename from bcache_memory_used.
1109
1110 2019-03-07  Pedro Alves  <palves@redhat.com>
1111
1112         * infrun.c (normal_stop): Also check for
1113         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1114
1115 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * f-lang.c (value_from_host_double): Moved to...
1118         * value.c (value_from_host_double): ...here.
1119         * value.h (value_from_host_double): Declare.
1120         * guile/scm-math.c (vlscm_convert_typed_number): Use
1121         value_from_host_double.
1122         (vlscm_convert_number): Likewise.
1123         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1124         * python/py-value.c (convert_value_from_python): Likewise.
1125
1126 2019-03-06  Tom Tromey  <tom@tromey.com>
1127
1128         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1129
1130 2019-03-06  Tom Tromey  <tom@tromey.com>
1131
1132         * utils.h (free_current_contents): Don't declare.
1133         * utils.c (free_current_contents): Remove.
1134
1135 2019-03-06  Tom Tromey  <tom@tromey.com>
1136
1137         * top.c (quit_force): Update.
1138         * main.c (captured_command_loop): Update.
1139         * common/new-op.c (operator new): Update.
1140         * common/common-exceptions.c (struct catcher)
1141         <save_cleanup_chain>: Remove member.
1142         (exceptions_state_mc_init): Update.
1143         (exception_try_scope_entry): Return nullptr.
1144         (exception_try_scope_exit, exception_rethrow)
1145         (throw_exception_sjlj, throw_exception_cxx): Update.
1146         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1147         (all_cleanups, do_cleanups, discard_cleanups)
1148         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1149         (restore_cleanups, restore_final_cleanups): Don't declare.
1150         (do_final_cleanups): Remove parameter.
1151         * common/cleanups.c (cleanup_chain, make_cleanup)
1152         (make_cleanup_dtor, all_cleanups, do_cleanups)
1153         (discard_my_cleanups, discard_cleanups)
1154         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1155         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1156         (null_cleanup): Remove.
1157         (do_final_cleanups): Remove parameter.
1158
1159 2019-03-06  Tom Tromey  <tom@tromey.com>
1160
1161         * remote.c (remote_target::remote_parse_stop_reply): Use
1162         unique_xmalloc_ptr.
1163
1164 2019-03-06  Tom Tromey  <tom@tromey.com>
1165
1166         * stabsread.c (struct stabs_field_info): Rename from field_info.
1167         <list, fnlist>: Add initializers.
1168         <obstack>: New member.
1169         (read_member_functions, read_struct_fields, read_baseclasses):
1170         Allocate on obstack.  Don't use cleanups.
1171         (read_one_struct_field, read_member_functions, read_struct_fields)
1172         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1173         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1174         (read_struct_type): Update.
1175
1176 2019-03-06  Tom Tromey  <tom@tromey.com>
1177
1178         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1179         * common/filestuff.h (make_cleanup_close): Don't declare.
1180         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1181         Remove.
1182
1183 2019-03-06  Tom Tromey  <tom@tromey.com>
1184
1185         * solib-aix.c: Use make_scope_exit.
1186
1187 2019-03-06  Tom Tromey  <tom@tromey.com>
1188
1189         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1190         Use make_scope_exit.
1191
1192 2019-03-06  Tom Tromey  <tom@tromey.com>
1193
1194         * solib-svr4.c (disable_probes_interface): Remove parameter.
1195         (svr4_handle_solib_event): Use make_scope_exit.
1196
1197 2019-03-06  Tom Tromey  <tom@tromey.com>
1198
1199         * remote.c (struct stop_reply_deleter): Remove.
1200         (stop_reply_up): Update.
1201         (struct stop_reply): Derive from notif_event.  Don't typedef.
1202         <regcache>: Now a std::vector.
1203         (stop_reply_xfree): Remove.
1204         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1205         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1206         (remote_target::discard_pending_stop_replies): Use delete.
1207         (remote_target::remote_parse_stop_reply): Update.
1208         (remote_target::process_stop_reply): Update.
1209         * remote-notif.h (struct notif_event): Add virtual destructor.
1210         Remove "dtr" member.
1211         (struct notif_client) <alloc_event>: Return a unique_ptr.
1212         (notif_event_xfree): Don't declare.
1213         (notif_event_up): New typedef.
1214         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1215         (notif_event_xfree, do_notif_event_xfree): Remove.
1216         (remote_notif_state_xfree): Update.
1217
1218 2019-03-06  Tom Tromey  <tom@tromey.com>
1219
1220         * infrun.c (displaced_step_clear_cleanup): Now a
1221         forward_scope_exit type.
1222         (displaced_step_prepare_throw): Update.
1223         (displaced_step_fixup): Update.
1224
1225 2019-03-06  Tom Tromey  <tom@tromey.com>
1226
1227         * inferior.h (class inferior): Update comment.
1228         * gdbthread.h (class thread_info): Update comment.
1229
1230 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1231             Tom Tromey  <tom@tromey.com>
1232
1233         * stabsread.h (struct stab_section_list): Remove.
1234         (coffstab_build_psymtabs): Update.
1235         * dbxread.c (symbuf_sections): Now a std::vector.
1236         (sect_idx): New global.
1237         (fill_symbuf): Update.
1238         (coffstab_build_psymtabs): Change type of stabsects parameter.
1239         Update.
1240         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1241         std::vector.
1242         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1243         (coff_locate_sections): Update.
1244         (coff_symfile_read): Remove cleanups.  Update.
1245         (init_stringtab): Add storage parameter.
1246         (free_stringtab, free_stringtab_cleanup): Remove.
1247         (init_lineno): Add storage parameter.
1248         (free_linetab, free_linetab_cleanup): Remove.
1249
1250 2019-03-06  Pedro Alves  <palves@redhat.com>
1251
1252         * linux-fork.c (fork_info::clobber_regs): Delete.
1253         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1254         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1255         comment.  Adjust.
1256         (scoped_switch_fork_info::scoped_switch_fork_info)
1257         (checkpoint_command, linux_fork_context): Adjust
1258         fork_save_infrun_state calls.
1259
1260 2019-03-06  Pedro Alves  <palves@redhat.com>
1261
1262         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1263         (inf_has_multiple_threads): Return 'bool' and rewrite using
1264         inferior_info::threads().
1265
1266 2019-03-06  Pedro Alves  <palves@redhat.com>
1267
1268         * linux-fork.c: Include <list>.
1269         (fork_list): Now a std::list instance.
1270         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1271         (forks_exist_p, find_last_fork): Adjust.
1272         (new_fork): Delete.
1273         (one_fork_p): New.
1274         (add_fork): Adjust.
1275         (free_fork): Delete, folded into fork_info::~fork_info().
1276         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1277         Adjust.
1278         (init_fork_list): Delete.
1279         (linux_fork_killall, linux_fork_mourn_inferior)
1280         (linux_fork_detach, info_checkpoints_command): Adjust.
1281         (_initialize_linux_fork): No longer call init_fork_list.
1282
1283 2019-03-06  Pedro Alves  <palves@redhat.com>
1284
1285         * linux-fork.c (new_fork): New, split out of ...
1286         (add_fork): ... this.  Return void.  Move "first fork" special
1287         case from here, to ...
1288         (checkpoint_command): ... here.
1289         * linux-linux.h (add_fork): Return void.
1290
1291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1294
1295 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1296             Chris January  <chris.january@arm.com>
1297             David Lecomber  <david.lecomber@arm.com>
1298
1299         * f-exp.y: New token, UNOP_INTRINSIC.
1300         (exp): New pattern using UNOP_INTRINSIC token.
1301         (f77_keywords): Add 'abs' keyword.
1302         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1303         (value_from_host_double): New function.
1304         (evaluate_subexp_f): Support UNOP_ABS.
1305
1306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1309         types.
1310
1311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1312
1313         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1314         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1315         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1316
1317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1320
1321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1322             Chris January  <chris.january@arm.com>
1323
1324         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1325         * f-exp.y: Define 'KIND' token.
1326         (exp): New pattern for KIND expressions.
1327         (ptype): Handle types with a kind extension.
1328         (direct_abs_decl): Extend to spot kind extensions.
1329         (f77_keywords): Add 'kind' to the list.
1330         (push_kind_type): New function.
1331         (convert_to_kind_type): New function.
1332         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1333         * parse.c (operator_length_standard): Likewise.
1334         * parser-defs.h (enum type_pieces): Add tp_kind.
1335         * std-operator.def: Add UNOP_KIND.
1336
1337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * f-exp.y (f_parse): Set yydebug.
1340
1341 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1342
1343         * f-lang.c (evaluate_subexp_f): New function.
1344         (exp_descriptor_f): New global.
1345         (f_language_defn): Use exp_descriptor_f instead of
1346         exp_descriptor_standard.
1347
1348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1349
1350         * f-exp.y (struct token): Add comments.
1351         (dot_ops): Remove uppercase versions and the end marker.
1352         (f77_keywords): Likewise.
1353         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1354         entries in the dot_ops array are case insensitive, and use
1355         strncasecmp to compare strings.  Also some whitespace cleanup in
1356         this area.  Similar for the f77_keywords array, except entries in
1357         this list might be case sensitive.
1358
1359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * f-exp.y (struct f77_boolean_val): Add comments.
1362         (boolean_values): Remove uppercase versions, and end marker.
1363         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1364         and use strncasecmp to achieve case insensitivity.  Additionally,
1365         perform whitespace cleanup around this code.
1366
1367 2019-03-06  Tom Tromey  <tromey@adacore.com>
1368
1369         * remote-sim.c (gdbsim_target_open): Use result of
1370         gdb_argv::release.
1371
1372 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1373         Dirk Schubert  <dirk.schubert@arm.com>
1374         Chris January  <chris.january@arm.com>
1375
1376         * eval.c (evaluate_subexp_standard): Call Fortran argument
1377         wrapping logic.
1378         * f-lang.c (struct value): A value which can be passed into a
1379         Fortran function call.
1380         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1381         where appropriate.
1382         (struct type): Value ready for a Fortran function call.
1383         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1384         is needed.
1385         * f-lang.h (fortran_argument_convert): Declaration.
1386         (fortran_preserve_arg_pointer): Declaration.
1387         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1388
1389 2019-03-05  Tom Tromey  <tromey@adacore.com>
1390
1391         * python/py-prettyprint.c (print_string_repr): Remove #if.
1392         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1393
1394 2019-03-05  Tom Tromey  <tromey@adacore.com>
1395
1396         * target.c (the_dummy_target): Move later.  Change type to
1397         "dummy_target".
1398         (initialize_targets): Don't initialize the_dummy_target.
1399
1400 2019-03-05  Tom Tromey  <tromey@adacore.com>
1401
1402         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1403         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1404
1405 2019-03-05  Tom Tromey  <tromey@adacore.com>
1406
1407         * windows-nat.c (windows_nat_target::attach)
1408         (windows_nat_target::detach): Don't call gdb_flush.
1409         * valprint.c (generic_val_print, val_print, val_print_string):
1410         Don't call gdb_flush.
1411         * utils.c (defaulted_query): Don't call gdb_flush.
1412         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1413         * target.c (target_announce_detach): Don't call gdb_flush.
1414         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1415         * remote.c (extended_remote_target::attach): Don't call
1416         gdb_flush.
1417         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1418         * printcmd.c (do_examine): Don't call gdb_flush.
1419         (info_display_command): Don't call gdb_flush.
1420         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1421         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1422         * memattr.c (info_mem_command): Don't call gdb_flush.
1423         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1424         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1425         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1426         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1427         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1428         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1429         (gnu_nat_target::detach): Don't call gdb_flush.
1430         * f-valprint.c (f_val_print): Don't call gdb_flush.
1431         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1432         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1433         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1434         gdb_flush.
1435         * c-valprint.c (c_val_print): Don't call gdb_flush.
1436         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1437
1438 2019-03-05  Tom Tromey  <tromey@adacore.com>
1439
1440         * varobj.c (update_dynamic_varobj_children): Update.
1441         (install_default_visualizer): Use reset, not release.
1442         * value.c (set_internalvar): Update.
1443         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1444         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1445         ATTRIBUTE_UNUSED_RESULT.
1446
1447 2019-03-05  Tom Tromey  <tromey@adacore.com>
1448
1449         * remote.c (class scoped_remote_fd) <release>: Add
1450         ATTRIBUTE_UNUSED_RESULT.
1451
1452 2019-03-05  Tom Tromey  <tromey@adacore.com>
1453
1454         * macroexp.c (struct macro_buffer) <release>: Add
1455         ATTRIBUTE_UNUSED_RESULT.
1456
1457 2019-03-05  Tom Tromey  <tromey@adacore.com>
1458
1459         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1460         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1461         ATTRIBUTE_UNUSED_RESULT.
1462
1463 2019-03-05  Tom Tromey  <tromey@adacore.com>
1464
1465         * common/scoped_fd.h (class scoped_fd) <release>: Add
1466         ATTRIBUTE_UNUSED_RESULT.
1467
1468 2019-03-05  Tom Tromey  <tromey@adacore.com>
1469
1470         * parser-defs.h (struct parser_state) <release>: Add
1471         ATTRIBUTE_UNUSED_RESULT.
1472
1473 2019-03-05  Tom Tromey  <tromey@adacore.com>
1474
1475         * utils.h (class gdb_argv) <release>: Add
1476         ATTRIBUTE_UNUSED_RESULT.
1477         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1478
1479 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1480
1481         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1482         for-loop range, to avoid compiler warnings.
1483
1484         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1485         avoid compiler warnings about unused variables.
1486
1487         * NEWS: Mention end of support for native debugging on MS-Windows
1488         before XP.
1489
1490         PR gdb/24292
1491         * common/netstuff.c:
1492         * gdbserver/gdbreplay.c
1493         * gdbserver/remote-utils.c:
1494         * ser-tcp.c:
1495         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1496         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1497         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1498         'getaddrinfo' and 'freeaddrinfo' were not available before
1499         Windows XP, and mingw.org's MinGW headers by default define
1500         _WIN32_WINNT to 0x500.
1501
1502 2019-03-01  Gary Benson <gbenson@redhat.com>
1503
1504         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1505
1506 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1507             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1508
1509         PR gdb/8527
1510         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1511         set_sigint_trap, clear_sigint_trap.
1512
1513 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1514
1515         * target.c (target_detach): Clear the regcache and the
1516         frame cache.
1517
1518 2019-02-27  Pedro Alves  <palves@redhat.com>
1519
1520         * utils.c (set_screen_size): When we cap the height/width sizes,
1521         tweak the corresponding command variable to show "unlimited":
1522
1523 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1524             Pedro Alves  <palves@redhat.com>
1525
1526         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1527         before calling rl_set_screen_size.
1528
1529 2019-02-27  Tom Tromey  <tromey@adacore.com>
1530
1531         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1532         define.
1533         * python/py-value.c: Remove Python 2.4 workaround.
1534         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1535         workaround.
1536         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1537         Python 2.4 workaround.
1538         * python/python-internal.h: Remove Python 2.4 comment.
1539         (Py_ssize_t): Don't define.
1540         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1541         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1542         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1543         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1544         * python/python.c (do_start_initialization): Remove Python 2.4
1545         workaround.
1546         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1547         (print_children): Remove Python 2.4 workaround.
1548         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1549         workaround.
1550         (CHARBUFFERPROC_NAME): Remove.
1551         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1552         Python 2.4 workaround.
1553
1554 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1555
1556         * NEWS: Note minimum Python version.
1557
1558 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1559
1560         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1561         code from these functions.  Remove corresponding ifdefs.  Use
1562         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1563         Remove gotos and target of gotos.
1564         (infpy_search_memory): Likewise.
1565
1566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1569         (hppa_gdbarch_init): Don't register deleted functions with
1570         gdbarch.
1571
1572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1575         (h8300_unwind_sp): Delete.
1576         (h8300_dummy_id): Delete.
1577         (h8300_gdbarch_init): Don't register deleted functions with
1578         gdbarch.
1579
1580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1583         (ft32_unwind_pc): Delete.
1584         (ft32_unwind_sp): Delete.
1585         (ft32_gdbarch_init): Don't register deleted functions with
1586         gdbarch.
1587
1588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1591         (frv_unwind_pc): Delete.
1592         (frv_unwind_sp): Delete.
1593         (frv_gdbarch_init): Don't register deleted functions with
1594         gdbarch.
1595
1596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1599         (riscv_unwind_pc): Delete.
1600         (riscv_unwind_sp): Delete.
1601         (riscv_gdbarch_init): Don't register deleted functions with
1602         gdbarch.
1603
1604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1605
1606         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1607         (csky_unwind_pc): Delete.
1608         (csky_unwind_sp): Delete.
1609         (csky_gdbarch_init): Don't register deleted functions with
1610         gdbarch.
1611
1612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1613
1614         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1615         (cris_unwind_pc): Delete.
1616         (cris_unwind_sp): Delete.
1617         (cris_gdbarch_init): Don't register deleted functions with
1618         gdbarch.
1619
1620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1623         (bfin_unwind_pc): Delete.
1624         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1625
1626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1629         (arm_unwind_pc): Delete.
1630         (arm_unwind_sp): Delete.
1631         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1632
1633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1636         (arc_unwind_pc): Delete.
1637         (arc_unwind_sp): Delete.
1638         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1639
1640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1641
1642         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1643         (alpha_unwind_pc): Delete.
1644         (alpha_gdbarch_init): Don't register deleted functions with
1645         gdbarch.
1646
1647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1650         (aarch64_unwind_pc): Delete.
1651         (aarch64_unwind_sp): Delete.
1652         (aarch64_gdbarch_init): Don't register deleted functions with
1653         gdbarch.
1654
1655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1656
1657         * gdbtypes.c (type_align): Don't consider static members when
1658         computing structure alignment.
1659
1660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1663         return 0 for other types.
1664         * arch-utils.c (default_type_align): Always return 0.
1665         * gdbarch.h: Regenerate.
1666         * gdbarch.sh (type_align): Extend comment.
1667         * gdbtypes.c (type_align): Add additional comments, always call
1668         gdbarch_type_align before applying the default rules.
1669         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1670         generic code will then apply a suitable default.
1671         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1672         types, return 0 for other types.
1673
1674 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1675
1676         * NEWS: Create a new section for the next release branch.
1677         Rename the section of the current branch, now that it has
1678         been cut.
1679
1680 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1681
1682         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1683         * version.in: Bump version to 8.3.50.DATE-git.
1684
1685 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1686
1687         * aix-thread.c (ptid_cmp): Remove unused variable.
1688         (get_signaled_thread): Likewise.
1689         (store_regs_user_thread): Likewise.
1690         (store_regs_kernel_thread): Likewise.
1691         (fetch_regs_kernel_thread): Remove shadowed variable.
1692
1693 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1694
1695         * features/riscv/32bit-cpu.xml: Add register numbers.
1696         * features/riscv/32bit-fpu.c: Regenerate.
1697         * features/riscv/32bit-fpu.xml: Add register numbers.
1698         * features/riscv/64bit-cpu.xml: Add register numbers.
1699         * features/riscv/64bit-fpu.c: Regenerate.
1700         * features/riscv/64bit-fpu.xml: Add register numbers.
1701
1702 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1703
1704         * NEWS: Mention two argument form of gdb.Value constructor.
1705         * python/py-value.c (convert_buffer_and_type_to_value): New
1706         function.
1707         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1708         Add support for handling an optional second argument.  Call
1709         convert_buffer_and_type_to_value as appropriate.
1710         * python/python-internal.h (Py_buffer_deleter): New struct.
1711         (Py_buffer_up): New typedef.
1712
1713 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1714
1715         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1716         instead of releasing ownership.
1717
1718 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1719
1720         * dwarf2read.c (open_and_init_dwp_file): Call
1721         elf_numsections instead of bfd_count_sections to initialize
1722         dwp_file->num_sections.
1723
1724 2019-02-25  Tom Tromey  <tromey@adacore.com>
1725
1726         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1727
1728 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1729
1730         * gcore.in: Add '--readnever' option when invoking GDB.
1731
1732 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1733
1734         * MAINTAINERS: Update my email address.
1735
1736 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1737
1738         * build-id.c (build_id_to_debug_bfd_1): New function.
1739         (build_id_to_debug_bfd): Look for separate debug file in
1740         sysroot.
1741
1742 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1743
1744         * gdbarch.sh: Update the copyright year range that is placed into
1745         generated files.
1746
1747 2019-02-22  Keith Seitz  <keiths@redhat.com>
1748
1749         PR symtab/23853
1750         * linespec.c (create_sals_line_offset): Search for the default
1751         symtab's filename instead of its fullname.
1752
1753 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1754
1755         * NEWS: Update style defaults.
1756
1757 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1758
1759         * main.c (captured_main_1): Disable styling in batch mode.
1760
1761 2019-02-20  Tom Tromey  <tom@tromey.com>
1762
1763         * symtab.c (symtab_symbol_info): Fix typos.
1764
1765 2019-02-20  Tom Tromey  <tromey@adacore.com>
1766
1767         * findcmd.c (_initialize_mem_search): Use upper case for
1768         metasyntactic variables.
1769
1770 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1771
1772         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1773         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1774
1775 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1776
1777         * top.h (source_file_name): Change to std::string.
1778         * top.c (source_file_name): Likewise.
1779         (command_line_input): Adjust.
1780         * cli/cli-script.c (script_from_file): Adjust.
1781
1782 2019-02-19  Tom Tromey  <tromey@adacore.com>
1783
1784         * ravenscar-thread.c
1785         (ravenscar_thread_target::update_thread_list): Don't call
1786         ada_build_task_list.
1787         * ada-lang.h (ada_build_task_list): Don't declare.
1788         * ada-tasks.c (struct ada_tasks_inferior_data)
1789         <task_list_valid_p>: Now bool.
1790         (read_known_tasks, ada_task_list_changed)
1791         (ada_tasks_invalidate_inferior_data): Update.
1792         (read_known_tasks_array): Return bool.
1793         (read_known_tasks_list): Likewise.
1794         (read_known_tasks): Return void.
1795         (ada_build_task_list): Now static.
1796
1797 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1798
1799         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1800         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1801
1802 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1803
1804         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1805         variant for ada_tasks_pspace_data_handle and
1806         ada_tasks_inferior_data_handle.
1807         (ada_tasks_pspace_data_cleanup): New function.
1808         (ada_tasks_inferior_data_cleanup): New function.
1809
1810 2019-02-17  Tom Tromey  <tom@tromey.com>
1811
1812         * macrotab.h (macro_source_fullname): Return a std::string.
1813         * macrotab.c (macro_include, check_for_redefinition)
1814         (macro_undef, macro_lookup_definition, foreach_macro)
1815         (foreach_macro_in_scope): Update.
1816         (macro_source_fullname): Return a std::string.
1817         * macrocmd.c (show_pp_source_pos): Update.
1818
1819 2019-02-17  Tom Tromey  <tom@tromey.com>
1820
1821         * macrocmd.c (show_pp_source_pos): Style the file names.
1822
1823 2019-02-17  Tom Tromey  <tom@tromey.com>
1824
1825         PR tui/24197:
1826         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1827
1828 2019-02-17  Tom Tromey  <tom@tromey.com>
1829
1830         * ada-lang.c (user_select_syms): Use filtered printing.
1831         * utils.c (wrap_style): New global.
1832         (desired_style): Remove.
1833         (emit_style_escape): Add stream parameter.
1834         (set_output_style, reset_terminal_style, prompt_for_continue):
1835         Update.
1836         (flush_wrap_buffer): Only flush gdb_stdout.
1837         (wrap_here): Set wrap_style.
1838         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1839         treat escape sequences as a character.  Change when wrap buffer is
1840         flushed.
1841         (fputs_styled): Do not set the output style when the default is
1842         requested.
1843         * ui-style.h (struct ui_file_style) <is_default>: New method.
1844         * source.c (print_source_lines_base): Emit escape sequences in one
1845         piece.
1846
1847 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1848
1849         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1850         integers and enumeration types.
1851
1852 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1853
1854         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1855         instead of lookup_symbol_in_language
1856         (do_exact_match): New function.
1857         (ada_get_symbol_name_matcher): Return do_exact_match when
1858         doing a verbatim match.
1859
1860 2019-02-15  Tom Tromey  <tromey@adacore.com>
1861
1862         * ravenscar-thread.c (ravenscar_thread_target::resume)
1863         (ravenscar_thread_target::wait): Special case wildcard requests.
1864
1865 2019-02-15  Tom Tromey  <tromey@adacore.com>
1866
1867         * ravenscar-thread.c (base_ptid): Remove.
1868         (struct ravenscar_thread_target) <close>: New method.
1869         <m_base_ptid>: New member.
1870         <update_inferior_ptid, active_task, task_is_currently_active,
1871         runtime_initialized>: Declare methods.
1872         <ravenscar_thread_target>: Add constructor.
1873         (ravenscar_thread_target::task_is_currently_active)
1874         (ravenscar_thread_target::update_inferior_ptid)
1875         (ravenscar_runtime_initialized): Rename.  Now methods.
1876         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1877         (ravenscar_thread_target::update_thread_list): Update.
1878         (ravenscar_thread_target::active_task): Now method.
1879         (ravenscar_thread_target::store_registers)
1880         (ravenscar_thread_target::prepare_to_store)
1881         (ravenscar_thread_target::prepare_to_store)
1882         (ravenscar_thread_target::mourn_inferior): Update.
1883         (ravenscar_inferior_created): Use "new" to create target.
1884         (ravenscar_thread_target::get_ada_task_ptid): Update.
1885         (_initialize_ravenscar): Don't initialize base_ptid.
1886         (ravenscar_ops): Remove global.
1887
1888 2019-02-15  Tom Tromey  <tromey@adacore.com>
1889
1890         * target.h (push_target): Declare new overload.
1891         * target.c (push_target): New overload, taking an rvalue reference.
1892         * remote.c (remote_target::open_1): Use push_target overload.
1893         * corelow.c (core_target_open): Use push_target overload.
1894
1895 2019-02-15  Tom Tromey  <tromey@adacore.com>
1896
1897         * ravenscar-thread.c (is_ravenscar_task)
1898         (ravenscar_task_is_currently_active): Return bool.
1899         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1900         (_initialize_ravenscar): Remove "(void)".
1901         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1902         Return bool.
1903
1904 2019-02-15  Tom Tromey  <tromey@adacore.com>
1905
1906         * ravenscar-thread.c (ravenscar_runtime_initializer)
1907         (has_ravenscar_runtime, get_running_thread_id)
1908         (ravenscar_thread_target::resume): Fix indentation.
1909
1910 2019-02-15  Tom Tromey  <tromey@adacore.com>
1911
1912         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1913         from ravenscar_arch_ops.
1914         (sparc_ravenscar_ops::fetch_registers)
1915         (sparc_ravenscar_ops::store_registers): Now methods.
1916         (sparc_ravenscar_prepare_to_store): Remove.
1917         (sparc_ravenscar_ops): Redefine.
1918         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1919         methods and destructor.  Remove members.
1920         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1921         (ravenscar_thread_target::store_registers)
1922         (ravenscar_thread_target::prepare_to_store): Update.
1923         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1924         Remove.
1925         (struct ppc_ravenscar_powerpc_ops): Derive from
1926         ravenscar_arch_ops.
1927         (ppc_ravenscar_powerpc_ops::fetch_registers)
1928         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1929         (ppc_ravenscar_powerpc_ops): Redefine.
1930         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1931         (ppc_ravenscar_e500_ops::fetch_registers)
1932         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1933         (ppc_ravenscar_e500_ops): Redefine.
1934         * aarch64-ravenscar-thread.c
1935         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1936         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1937         (aarch64_ravenscar_fetch_registers)
1938         (aarch64_ravenscar_store_registers): Now methods.
1939         (aarch64_ravenscar_ops): Redefine.
1940
1941 2019-02-15  Tom Tromey  <tromey@adacore.com>
1942
1943         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1944         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1945         (ravenscar_thread_target::stopped_by_watchpoint)
1946         (ravenscar_thread_target::stopped_data_address)
1947         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1948
1949 2019-02-15  Tom Tromey  <tromey@adacore.com>
1950
1951         * ravenscar-thread.c: Fix some typos.
1952
1953 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1954             Tom Tromey  <tromey@adacore.com>
1955
1956         * ada-lang.c (ada_exception_sal): Change addr_string to a
1957         std::string.
1958         (create_ada_exception_catchpoint): Update.
1959
1960 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1961             Tom Tromey  <tromey@adacore.com>
1962
1963         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1964         (bp_location_ops): Remove.
1965         (base_breakpoint_allocate_location): Update.
1966         (free_bp_location): Update.
1967         * ada-lang.c (class ada_catchpoint_location)
1968         <ada_catchpoint_location>: Remove ops parameter.
1969         (ada_catchpoint_location_dtor): Remove.
1970         (ada_catchpoint_location_ops): Remove.
1971         (allocate_location_exception): Update.
1972         * breakpoint.h (struct bp_location_ops): Remove.
1973         (class bp_location) <bp_location>: Remove bp_location_ops
1974         parameter.
1975         <~bp_location>: Add destructor.
1976         <ops>: Remove.
1977
1978 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1979             Pedro Alves  <palves@redhat.com>
1980
1981         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1982         'PATH_MAX'.
1983
1984 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1985             Samuel Thibault  <samuel.thibault@gnu.org>
1986             Thomas Schwinge  <thomas@codesourcery.com>
1987
1988         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1989         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1990
1991 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1992
1993         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1994         (check_empty): Use "const char *".
1995
1996         * gnu-nat.c (gnu_nat_target::detach): Instead of
1997         'detach_inferior (pid)' call
1998         'detach_inferior (find_inferior_pid (pid))'.
1999
2000         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2001         'nat/fork-inferior.o'.
2002         * gnu-nat.c: #include "nat/fork-inferior.h".
2003
2004         * gnu-nat.c (gnu_nat_target::detach): Instead of
2005         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2006         * gnu-nat.h: #include "inf-child.h".
2007         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2008         'i386_gnu_nat_target::fetch_registers'.
2009         (gnu_store_registers): Rename/move to
2010         'i386_gnu_nat_target::store_registers'.
2011
2012         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2013         * gnu-nat.h (mach_thread_info): New function.
2014         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2015
2016         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2017
2018 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2019
2020         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2021
2022 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2023
2024         * windows-nat.c (windows_add_thread): Add new parameter
2025         "main_thread_p" with default value set to false.  Update
2026         function documentation as well as all callers.
2027         (windows_delete_thread): Likewise.
2028         (fake_create_process): Update call to windows_add_thread.
2029         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2030         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2031         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2032         call to windows_delete_thread.
2033
2034 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2035
2036         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2037
2038 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2039
2040         * symfile.c (find_separate_debug_file): Use canonical path of
2041         sysroot with child_path instead of gdb_sysroot if it is valid.
2042
2043 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2044
2045         * symfile.c (find_separate_debug_file): Use child_path to
2046         determine if an object file is under a sysroot.
2047
2048 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2049
2050         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2051         unittests/child-path-selftests.c.
2052         * common/pathstuff.c (child_path): New function.
2053         * common/pathstuff.h (child_path): New prototype.
2054         * unittests/child-path-selftests.c: New file.
2055
2056 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2057
2058         * symfile.c (find_separate_debug_file): Look for separate debug
2059         files in debug directories under the sysroot.
2060
2061 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2062
2063         * symtab.h (struct minimal_symbol data_p): New const method.
2064         (struct minimal_symbol text_p): Likewise.
2065         * symtab.c (output_source_filename): Use file name style
2066         to print file name.
2067         (print_symbol_info): Likewise.
2068         (print_msymbol_info): Use address style to print addresses.
2069         Use function name style to print executable text symbols.
2070         (expand_symtab_containing_pc): Use data_p.
2071         (find_pc_sect_compunit_symtab): Likewise.
2072
2073 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2074
2075         * breakpoint.c (describe_other_breakpoints): Use address style
2076         to print addresses.
2077         (say_where): Likewise.
2078
2079 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2080
2081         * ada-typeprint.c (print_func_type): Print function name
2082         style to print function name.
2083         * c-typeprint.c (c_print_type_1): Likewise.
2084
2085 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2086
2087         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2088         for execve.
2089
2090 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2091
2092         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2093         type_stack.
2094
2095 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2096
2097         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2098         TYPE_CODE_REF types.
2099
2100 2019-02-08  Jim Wilson  <jimw@sifive.com>
2101
2102         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2103         (riscv_linux_fregset): New.
2104         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2105
2106 2019-02-07  Tom Tromey  <tom@tromey.com>
2107
2108         * thread.c (thread_cancel_execution_command): Update.
2109         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2110         methods.
2111         (struct thread_fsm_ops): Remove.
2112         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2113         (thread_fsm_should_stop, thread_fsm_return_value)
2114         (thread_fsm_set_finished, thread_fsm_finished_p)
2115         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2116         Don't declare.
2117         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2118         * infrun.c (clear_proceed_status_thread)
2119         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2120         (print_stop_event): Update.
2121         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2122         Add constructor.
2123         (step_command_fsm_ops): Remove.
2124         (new_step_command_fsm): Remove.
2125         (step_1): Update.
2126         (step_command_fsm::should_stop): Rename from
2127         step_command_fsm_should_stop.
2128         (step_command_fsm::clean_up): Rename from
2129         step_command_fsm_clean_up.
2130         (step_command_fsm::do_async_reply_reason): Rename from
2131         step_command_fsm_async_reply_reason.
2132         (struct until_next_fsm): Inherit from thread_fsm.  Add
2133         constructor.
2134         (until_next_fsm_ops): Remove.
2135         (new_until_next_fsm): Remove.
2136         (until_next_fsm::should_stop): Rename from
2137         until_next_fsm_should_stop.
2138         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2139         (until_next_fsm::do_async_reply_reason): Rename from
2140         until_next_fsm_async_reply_reason.
2141         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2142         constructor.  Change type of breakpoint.
2143         (finish_command_fsm_ops): Remove.
2144         (new_finish_command_fsm): Remove.
2145         (finish_command_fsm::should_stop): Rename from
2146         finish_command_fsm_should_stop.
2147         (finish_command_fsm::clean_up): Rename from
2148         finish_command_fsm_clean_up.
2149         (finish_command_fsm::return_value): Rename from
2150         finish_command_fsm_return_value.
2151         (finish_command_fsm::do_async_reply_reason): Rename from
2152         finish_command_fsm_async_reply_reason.
2153         (finish_command): Update.
2154         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2155         Add constructor.
2156         (call_thread_fsm_ops): Remove.
2157         (call_thread_fsm::call_thread_fsm): Rename from
2158         new_call_thread_fsm.
2159         (call_thread_fsm::should_stop): Rename from
2160         call_thread_fsm_should_stop.
2161         (call_thread_fsm::should_notify_stop): Rename from
2162         call_thread_fsm_should_notify_stop.
2163         (run_inferior_call, call_function_by_hand_dummy): Update.
2164         * cli/cli-interp.c (should_print_stop_to_console): Update.
2165         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2166         Add constructor.  Change type of location_breakpoint,
2167         caller_breakpoint.
2168         (until_break_fsm_ops): Remove.
2169         (new_until_break_fsm): Remove.
2170         (until_break_fsm::should_stop): Rename from
2171         until_break_fsm_should_stop.
2172         (until_break_fsm::clean_up): Rename from
2173         until_break_fsm_clean_up.
2174         (until_break_fsm::do_async_reply_reason): Rename from
2175         until_break_fsm_async_reply_reason.
2176         (until_break_command): Update.
2177         * thread-fsm.c: Remove.
2178         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2179
2180 2019-02-07  Tom Tromey  <tom@tromey.com>
2181
2182         * yy-remap.h: Add include guard.
2183         * xtensa-tdep.h: Add include guard.
2184         * xcoffread.h: Rename include guard.
2185         * varobj-iter.h: Add include guard.
2186         * tui/tui.h: Rename include guard.
2187         * tui/tui-winsource.h: Rename include guard.
2188         * tui/tui-wingeneral.h: Rename include guard.
2189         * tui/tui-windata.h: Rename include guard.
2190         * tui/tui-win.h: Rename include guard.
2191         * tui/tui-stack.h: Rename include guard.
2192         * tui/tui-source.h: Rename include guard.
2193         * tui/tui-regs.h: Rename include guard.
2194         * tui/tui-out.h: Rename include guard.
2195         * tui/tui-layout.h: Rename include guard.
2196         * tui/tui-io.h: Rename include guard.
2197         * tui/tui-hooks.h: Rename include guard.
2198         * tui/tui-file.h: Rename include guard.
2199         * tui/tui-disasm.h: Rename include guard.
2200         * tui/tui-data.h: Rename include guard.
2201         * tui/tui-command.h: Rename include guard.
2202         * tic6x-tdep.h: Add include guard.
2203         * target/waitstatus.h: Rename include guard.
2204         * target/wait.h: Rename include guard.
2205         * target/target.h: Rename include guard.
2206         * target/resume.h: Rename include guard.
2207         * target-float.h: Rename include guard.
2208         * stabsread.h: Add include guard.
2209         * rs6000-tdep.h: Add include guard.
2210         * riscv-fbsd-tdep.h: Add include guard.
2211         * regformats/regdef.h: Rename include guard.
2212         * record.h: Rename include guard.
2213         * python/python.h: Rename include guard.
2214         * python/python-internal.h: Rename include guard.
2215         * python/py-stopevent.h: Rename include guard.
2216         * python/py-ref.h: Rename include guard.
2217         * python/py-record.h: Rename include guard.
2218         * python/py-record-full.h: Rename include guard.
2219         * python/py-record-btrace.h: Rename include guard.
2220         * python/py-instruction.h: Rename include guard.
2221         * python/py-events.h: Rename include guard.
2222         * python/py-event.h: Rename include guard.
2223         * procfs.h: Add include guard.
2224         * proc-utils.h: Add include guard.
2225         * p-lang.h: Add include guard.
2226         * or1k-tdep.h: Rename include guard.
2227         * observable.h: Rename include guard.
2228         * nto-tdep.h: Rename include guard.
2229         * nat/x86-linux.h: Rename include guard.
2230         * nat/x86-linux-dregs.h: Rename include guard.
2231         * nat/x86-gcc-cpuid.h: Add include guard.
2232         * nat/x86-dregs.h: Rename include guard.
2233         * nat/x86-cpuid.h: Rename include guard.
2234         * nat/ppc-linux.h: Rename include guard.
2235         * nat/mips-linux-watch.h: Rename include guard.
2236         * nat/linux-waitpid.h: Rename include guard.
2237         * nat/linux-ptrace.h: Rename include guard.
2238         * nat/linux-procfs.h: Rename include guard.
2239         * nat/linux-osdata.h: Rename include guard.
2240         * nat/linux-nat.h: Rename include guard.
2241         * nat/linux-namespaces.h: Rename include guard.
2242         * nat/linux-btrace.h: Rename include guard.
2243         * nat/glibc_thread_db.h: Rename include guard.
2244         * nat/gdb_thread_db.h: Rename include guard.
2245         * nat/gdb_ptrace.h: Rename include guard.
2246         * nat/fork-inferior.h: Rename include guard.
2247         * nat/amd64-linux-siginfo.h: Rename include guard.
2248         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2249         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2250         * nat/aarch64-linux.h: Rename include guard.
2251         * nat/aarch64-linux-hw-point.h: Rename include guard.
2252         * mn10300-tdep.h: Add include guard.
2253         * mips-linux-tdep.h: Add include guard.
2254         * mi/mi-parse.h: Rename include guard.
2255         * mi/mi-out.h: Rename include guard.
2256         * mi/mi-main.h: Rename include guard.
2257         * mi/mi-interp.h: Rename include guard.
2258         * mi/mi-getopt.h: Rename include guard.
2259         * mi/mi-console.h: Rename include guard.
2260         * mi/mi-common.h: Rename include guard.
2261         * mi/mi-cmds.h: Rename include guard.
2262         * mi/mi-cmd-break.h: Rename include guard.
2263         * m2-lang.h: Add include guard.
2264         * location.h: Rename include guard.
2265         * linux-record.h: Rename include guard.
2266         * linux-nat.h: Add include guard.
2267         * linux-fork.h: Add include guard.
2268         * i386-darwin-tdep.h: Rename include guard.
2269         * hppa-linux-offsets.h: Add include guard.
2270         * guile/guile.h: Rename include guard.
2271         * guile/guile-internal.h: Rename include guard.
2272         * gnu-nat.h: Rename include guard.
2273         * gdb-stabs.h: Rename include guard.
2274         * frv-tdep.h: Add include guard.
2275         * f-lang.h: Add include guard.
2276         * event-loop.h: Add include guard.
2277         * darwin-nat.h: Rename include guard.
2278         * cp-abi.h: Rename include guard.
2279         * config/sparc/nm-sol2.h: Rename include guard.
2280         * config/nm-nto.h: Rename include guard.
2281         * config/nm-linux.h: Add include guard.
2282         * config/i386/nm-i386gnu.h: Rename include guard.
2283         * config/djgpp/nl_types.h: Rename include guard.
2284         * config/djgpp/langinfo.h: Rename include guard.
2285         * compile/gcc-cp-plugin.h: Add include guard.
2286         * compile/gcc-c-plugin.h: Add include guard.
2287         * compile/compile.h: Rename include guard.
2288         * compile/compile-object-run.h: Rename include guard.
2289         * compile/compile-object-load.h: Rename include guard.
2290         * compile/compile-internal.h: Rename include guard.
2291         * compile/compile-cplus.h: Rename include guard.
2292         * compile/compile-c.h: Rename include guard.
2293         * common/xml-utils.h: Rename include guard.
2294         * common/x86-xstate.h: Rename include guard.
2295         * common/version.h: Rename include guard.
2296         * common/vec.h: Rename include guard.
2297         * common/tdesc.h: Rename include guard.
2298         * common/selftest.h: Rename include guard.
2299         * common/scoped_restore.h: Rename include guard.
2300         * common/scoped_mmap.h: Rename include guard.
2301         * common/scoped_fd.h: Rename include guard.
2302         * common/safe-iterator.h: Rename include guard.
2303         * common/run-time-clock.h: Rename include guard.
2304         * common/refcounted-object.h: Rename include guard.
2305         * common/queue.h: Rename include guard.
2306         * common/ptid.h: Rename include guard.
2307         * common/print-utils.h: Rename include guard.
2308         * common/preprocessor.h: Rename include guard.
2309         * common/pathstuff.h: Rename include guard.
2310         * common/observable.h: Rename include guard.
2311         * common/netstuff.h: Rename include guard.
2312         * common/job-control.h: Rename include guard.
2313         * common/host-defs.h: Rename include guard.
2314         * common/gdb_wait.h: Rename include guard.
2315         * common/gdb_vecs.h: Rename include guard.
2316         * common/gdb_unlinker.h: Rename include guard.
2317         * common/gdb_unique_ptr.h: Rename include guard.
2318         * common/gdb_tilde_expand.h: Rename include guard.
2319         * common/gdb_sys_time.h: Rename include guard.
2320         * common/gdb_string_view.h: Rename include guard.
2321         * common/gdb_splay_tree.h: Rename include guard.
2322         * common/gdb_setjmp.h: Rename include guard.
2323         * common/gdb_ref_ptr.h: Rename include guard.
2324         * common/gdb_optional.h: Rename include guard.
2325         * common/gdb_locale.h: Rename include guard.
2326         * common/gdb_assert.h: Rename include guard.
2327         * common/filtered-iterator.h: Rename include guard.
2328         * common/filestuff.h: Rename include guard.
2329         * common/fileio.h: Rename include guard.
2330         * common/environ.h: Rename include guard.
2331         * common/common-utils.h: Rename include guard.
2332         * common/common-types.h: Rename include guard.
2333         * common/common-regcache.h: Rename include guard.
2334         * common/common-inferior.h: Rename include guard.
2335         * common/common-gdbthread.h: Rename include guard.
2336         * common/common-exceptions.h: Rename include guard.
2337         * common/common-defs.h: Rename include guard.
2338         * common/common-debug.h: Rename include guard.
2339         * common/cleanups.h: Rename include guard.
2340         * common/buffer.h: Rename include guard.
2341         * common/btrace-common.h: Rename include guard.
2342         * common/break-common.h: Rename include guard.
2343         * cli/cli-utils.h: Rename include guard.
2344         * cli/cli-style.h: Rename include guard.
2345         * cli/cli-setshow.h: Rename include guard.
2346         * cli/cli-script.h: Rename include guard.
2347         * cli/cli-interp.h: Rename include guard.
2348         * cli/cli-decode.h: Rename include guard.
2349         * cli/cli-cmds.h: Rename include guard.
2350         * charset-list.h: Add include guard.
2351         * buildsym-legacy.h: Rename include guard.
2352         * bfin-tdep.h: Add include guard.
2353         * ax.h: Rename include guard.
2354         * arm-linux-tdep.h: Add include guard.
2355         * arm-fbsd-tdep.h: Add include guard.
2356         * arch/xtensa.h: Rename include guard.
2357         * arch/tic6x.h: Add include guard.
2358         * arch/i386.h: Add include guard.
2359         * arch/arm.h: Rename include guard.
2360         * arch/arm-linux.h: Rename include guard.
2361         * arch/arm-get-next-pcs.h: Rename include guard.
2362         * arch/amd64.h: Add include guard.
2363         * arch/aarch64-insn.h: Rename include guard.
2364         * arch-utils.h: Rename include guard.
2365         * annotate.h: Add include guard.
2366         * amd64-darwin-tdep.h: Rename include guard.
2367         * aarch64-linux-tdep.h: Add include guard.
2368         * aarch64-fbsd-tdep.h: Add include guard.
2369         * aarch32-linux-nat.h: Add include guard.
2370
2371 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2372
2373         * macrotab.c (macro_define_internal): New function that
2374         factorizes macro_define_object_internal and macro_define_function
2375         code.
2376         (macro_define_object_internal): Use macro_define_internal.
2377         (macro_define_function): Likewise.
2378
2379 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2380
2381         * macrocmd.c (extract_identifier): Return
2382         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2383         callers.
2384
2385 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2386
2387         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2388
2389 2019-02-05  Tom Tromey  <tom@tromey.com>
2390
2391         * target.c (target_stack::unpush): Move assertion earlier.
2392
2393 2019-01-30  Tom Tromey  <tom@tromey.com>
2394
2395         PR python/23615:
2396         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2397         (gdbpy_parse_and_eval): Likewise.
2398         * python/python-internal.h (gdbpy_allow_threads): New class.
2399
2400 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2401
2402         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2403         (aarch64_fbsd_fpregmap): Move earlier.
2404         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2405         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2406         instead of individual calls to trad_frame_set_reg_addr.
2407         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2408         earlier.
2409         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2410         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2411         instead of individual calls to trad_frame_set_reg_addr.
2412
2413 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2414
2415         * CONTRIBUTE: Replace contribution list with wiki link.
2416
2417 2019-01-25  Tom Tromey  <tom@tromey.com>
2418
2419         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2420
2421 2019-01-25  Tom Tromey  <tom@tromey.com>
2422
2423         * xtensa-linux-nat.c: Fix common/ includes.
2424         * xml-support.h: Fix common/ includes.
2425         * xml-support.c: Fix common/ includes.
2426         * x86-linux-nat.c: Fix common/ includes.
2427         * windows-nat.c: Fix common/ includes.
2428         * varobj.h: Fix common/ includes.
2429         * varobj.c: Fix common/ includes.
2430         * value.c: Fix common/ includes.
2431         * valops.c: Fix common/ includes.
2432         * utils.c: Fix common/ includes.
2433         * unittests/xml-utils-selftests.c: Fix common/ includes.
2434         * unittests/utils-selftests.c: Fix common/ includes.
2435         * unittests/unpack-selftests.c: Fix common/ includes.
2436         * unittests/tracepoint-selftests.c: Fix common/ includes.
2437         * unittests/style-selftests.c: Fix common/ includes.
2438         * unittests/string_view-selftests.c: Fix common/ includes.
2439         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2440         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2441         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2442         * unittests/rsp-low-selftests.c: Fix common/ includes.
2443         * unittests/parse-connection-spec-selftests.c: Fix common/
2444         includes.
2445         * unittests/optional-selftests.c: Fix common/ includes.
2446         * unittests/offset-type-selftests.c: Fix common/ includes.
2447         * unittests/observable-selftests.c: Fix common/ includes.
2448         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2449         * unittests/memrange-selftests.c: Fix common/ includes.
2450         * unittests/memory-map-selftests.c: Fix common/ includes.
2451         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2452         * unittests/function-view-selftests.c: Fix common/ includes.
2453         * unittests/environ-selftests.c: Fix common/ includes.
2454         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2455         * unittests/common-utils-selftests.c: Fix common/ includes.
2456         * unittests/cli-utils-selftests.c: Fix common/ includes.
2457         * unittests/array-view-selftests.c: Fix common/ includes.
2458         * ui-file.c: Fix common/ includes.
2459         * tui/tui-io.c: Fix common/ includes.
2460         * tracepoint.h: Fix common/ includes.
2461         * tracepoint.c: Fix common/ includes.
2462         * tracefile-tfile.c: Fix common/ includes.
2463         * top.h: Fix common/ includes.
2464         * top.c: Fix common/ includes.
2465         * thread.c: Fix common/ includes.
2466         * target/waitstatus.h: Fix common/ includes.
2467         * target/waitstatus.c: Fix common/ includes.
2468         * target.h: Fix common/ includes.
2469         * target.c: Fix common/ includes.
2470         * target-memory.c: Fix common/ includes.
2471         * target-descriptions.c: Fix common/ includes.
2472         * symtab.h: Fix common/ includes.
2473         * symfile.c: Fix common/ includes.
2474         * stap-probe.c: Fix common/ includes.
2475         * spu-linux-nat.c: Fix common/ includes.
2476         * sparc-nat.c: Fix common/ includes.
2477         * source.c: Fix common/ includes.
2478         * solib.c: Fix common/ includes.
2479         * solib-target.c: Fix common/ includes.
2480         * ser-unix.c: Fix common/ includes.
2481         * ser-tcp.c: Fix common/ includes.
2482         * ser-pipe.c: Fix common/ includes.
2483         * ser-base.c: Fix common/ includes.
2484         * selftest-arch.c: Fix common/ includes.
2485         * s12z-tdep.c: Fix common/ includes.
2486         * rust-exp.y: Fix common/ includes.
2487         * rs6000-aix-tdep.c: Fix common/ includes.
2488         * riscv-tdep.c: Fix common/ includes.
2489         * remote.c: Fix common/ includes.
2490         * remote-notif.h: Fix common/ includes.
2491         * remote-fileio.h: Fix common/ includes.
2492         * remote-fileio.c: Fix common/ includes.
2493         * regcache.h: Fix common/ includes.
2494         * regcache.c: Fix common/ includes.
2495         * record-btrace.c: Fix common/ includes.
2496         * python/python.c: Fix common/ includes.
2497         * python/py-type.c: Fix common/ includes.
2498         * python/py-inferior.c: Fix common/ includes.
2499         * progspace.h: Fix common/ includes.
2500         * producer.c: Fix common/ includes.
2501         * procfs.c: Fix common/ includes.
2502         * proc-api.c: Fix common/ includes.
2503         * printcmd.c: Fix common/ includes.
2504         * ppc-linux-nat.c: Fix common/ includes.
2505         * parser-defs.h: Fix common/ includes.
2506         * osdata.c: Fix common/ includes.
2507         * obsd-nat.c: Fix common/ includes.
2508         * nat/x86-linux.c: Fix common/ includes.
2509         * nat/x86-linux-dregs.c: Fix common/ includes.
2510         * nat/x86-dregs.h: Fix common/ includes.
2511         * nat/x86-dregs.c: Fix common/ includes.
2512         * nat/ppc-linux.c: Fix common/ includes.
2513         * nat/mips-linux-watch.h: Fix common/ includes.
2514         * nat/mips-linux-watch.c: Fix common/ includes.
2515         * nat/linux-waitpid.c: Fix common/ includes.
2516         * nat/linux-ptrace.h: Fix common/ includes.
2517         * nat/linux-ptrace.c: Fix common/ includes.
2518         * nat/linux-procfs.c: Fix common/ includes.
2519         * nat/linux-personality.c: Fix common/ includes.
2520         * nat/linux-osdata.c: Fix common/ includes.
2521         * nat/linux-namespaces.c: Fix common/ includes.
2522         * nat/linux-btrace.h: Fix common/ includes.
2523         * nat/linux-btrace.c: Fix common/ includes.
2524         * nat/fork-inferior.c: Fix common/ includes.
2525         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2526         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2527         * nat/aarch64-linux.c: Fix common/ includes.
2528         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2529         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2530         * namespace.h: Fix common/ includes.
2531         * mips-linux-tdep.c: Fix common/ includes.
2532         * minsyms.c: Fix common/ includes.
2533         * mi/mi-parse.h: Fix common/ includes.
2534         * mi/mi-main.c: Fix common/ includes.
2535         * mi/mi-cmd-env.c: Fix common/ includes.
2536         * memrange.h: Fix common/ includes.
2537         * memattr.c: Fix common/ includes.
2538         * maint.h: Fix common/ includes.
2539         * maint.c: Fix common/ includes.
2540         * main.c: Fix common/ includes.
2541         * machoread.c: Fix common/ includes.
2542         * location.c: Fix common/ includes.
2543         * linux-thread-db.c: Fix common/ includes.
2544         * linux-nat.c: Fix common/ includes.
2545         * linux-fork.c: Fix common/ includes.
2546         * inline-frame.c: Fix common/ includes.
2547         * infrun.c: Fix common/ includes.
2548         * inflow.c: Fix common/ includes.
2549         * inferior.h: Fix common/ includes.
2550         * inferior.c: Fix common/ includes.
2551         * infcmd.c: Fix common/ includes.
2552         * inf-ptrace.c: Fix common/ includes.
2553         * inf-child.c: Fix common/ includes.
2554         * ia64-linux-nat.c: Fix common/ includes.
2555         * i387-tdep.c: Fix common/ includes.
2556         * i386-tdep.c: Fix common/ includes.
2557         * i386-linux-tdep.c: Fix common/ includes.
2558         * i386-linux-nat.c: Fix common/ includes.
2559         * i386-go32-tdep.c: Fix common/ includes.
2560         * i386-fbsd-tdep.c: Fix common/ includes.
2561         * i386-fbsd-nat.c: Fix common/ includes.
2562         * guile/scm-type.c: Fix common/ includes.
2563         * guile/guile.c: Fix common/ includes.
2564         * go32-nat.c: Fix common/ includes.
2565         * gnu-nat.c: Fix common/ includes.
2566         * gdbthread.h: Fix common/ includes.
2567         * gdbarch-selftests.c: Fix common/ includes.
2568         * gdb_usleep.c: Fix common/ includes.
2569         * gdb_select.h: Fix common/ includes.
2570         * gdb_bfd.c: Fix common/ includes.
2571         * gcore.c: Fix common/ includes.
2572         * fork-child.c: Fix common/ includes.
2573         * findvar.c: Fix common/ includes.
2574         * fbsd-nat.c: Fix common/ includes.
2575         * event-top.c: Fix common/ includes.
2576         * event-loop.c: Fix common/ includes.
2577         * dwarf2read.c: Fix common/ includes.
2578         * dwarf2loc.c: Fix common/ includes.
2579         * dwarf2-frame.c: Fix common/ includes.
2580         * dwarf-index-cache.c: Fix common/ includes.
2581         * dtrace-probe.c: Fix common/ includes.
2582         * disasm-selftests.c: Fix common/ includes.
2583         * defs.h: Fix common/ includes.
2584         * csky-tdep.c: Fix common/ includes.
2585         * cp-valprint.c: Fix common/ includes.
2586         * cp-support.h: Fix common/ includes.
2587         * cp-support.c: Fix common/ includes.
2588         * corelow.c: Fix common/ includes.
2589         * completer.h: Fix common/ includes.
2590         * completer.c: Fix common/ includes.
2591         * compile/compile.c: Fix common/ includes.
2592         * compile/compile-loc2c.c: Fix common/ includes.
2593         * compile/compile-cplus-types.c: Fix common/ includes.
2594         * compile/compile-cplus-symbols.c: Fix common/ includes.
2595         * command.h: Fix common/ includes.
2596         * cli/cli-dump.c: Fix common/ includes.
2597         * cli/cli-cmds.c: Fix common/ includes.
2598         * charset.c: Fix common/ includes.
2599         * build-id.c: Fix common/ includes.
2600         * btrace.h: Fix common/ includes.
2601         * btrace.c: Fix common/ includes.
2602         * breakpoint.h: Fix common/ includes.
2603         * breakpoint.c: Fix common/ includes.
2604         * ax.h:
2605         (enum agent_op): Fix common/ includes.
2606         * ax-general.c (struct aop_map): Fix common/ includes.
2607         * ax-gdb.c: Fix common/ includes.
2608         * auxv.c: Fix common/ includes.
2609         * auto-load.c: Fix common/ includes.
2610         * arm-tdep.c: Fix common/ includes.
2611         * arch/riscv.c: Fix common/ includes.
2612         * arch/ppc-linux-common.c: Fix common/ includes.
2613         * arch/i386.c: Fix common/ includes.
2614         * arch/arm.c: Fix common/ includes.
2615         * arch/arm-linux.c: Fix common/ includes.
2616         * arch/arm-get-next-pcs.c: Fix common/ includes.
2617         * arch/amd64.c: Fix common/ includes.
2618         * arch/aarch64.c: Fix common/ includes.
2619         * arch/aarch64-insn.c: Fix common/ includes.
2620         * arch-utils.c: Fix common/ includes.
2621         * amd64-windows-tdep.c: Fix common/ includes.
2622         * amd64-tdep.c: Fix common/ includes.
2623         * amd64-sol2-tdep.c: Fix common/ includes.
2624         * amd64-obsd-tdep.c: Fix common/ includes.
2625         * amd64-nbsd-tdep.c: Fix common/ includes.
2626         * amd64-linux-tdep.c: Fix common/ includes.
2627         * amd64-linux-nat.c: Fix common/ includes.
2628         * amd64-fbsd-tdep.c: Fix common/ includes.
2629         * amd64-fbsd-nat.c: Fix common/ includes.
2630         * amd64-dicos-tdep.c: Fix common/ includes.
2631         * amd64-darwin-tdep.c: Fix common/ includes.
2632         * agent.c: Fix common/ includes.
2633         * ada-lang.h: Fix common/ includes.
2634         * ada-lang.c: Fix common/ includes.
2635         * aarch64-tdep.c: Fix common/ includes.
2636
2637 2019-01-25  Tom Tromey  <tom@tromey.com>
2638
2639         * common/create-version.sh: Use common/version.h.
2640
2641 2019-01-24  Pedro Alves  <palves@redhat.com>
2642
2643         * infrun.c (signal_stop, signal_print, signal_program)
2644         (signal_catch, signal_pass): Now arrays instead of pointers.
2645         (update_signals_program_target, do_target_resume)
2646         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2647         * linux-nat.c (linux_nat_target::pass_signals)
2648         (linux_nat_target::create_inferior, linux_nat_target::attach):
2649         Adjust.
2650         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2651         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2652         * procfs.c (procfs_target::pass_signals): Adjust.
2653         * record-full.c (record_full_target::resume): Adjust.
2654         * remote.c (remote_target::pass_signals)
2655         (remote_target::program_signals): Adjust.
2656         * target-debug.h (target_debug_print_signals): Now takes a
2657         gdb::array_view as parameter.  Adjust.
2658         * target.h (target_ops) <pass_signals, program_signals>: Replace
2659         pointer and length parameters with gdb::array_view.
2660         (target_pass_signals, target_program_signals): Likewise.
2661         * target-delegates.c: Regenerate.
2662
2663 2019-01-24  Pedro Alves  <palves@redhat.com>
2664
2665         * common/forward-scope-exit.h
2666         (forward_scope_exit::forward_scope_exit): Pass arguments to
2667         m_bind_function directly, instead of creating a std::bind and
2668         copying that.
2669
2670 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2671
2672         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2673         for static members.
2674         (pass_in_v_vfp_candidate): Likewise.
2675
2676 2019-01-23  Tom Tromey  <tom@tromey.com>
2677             Pedro Alves  <palves@redhat.com>
2678
2679         * regcache.c (class regcache_invalidator): Remove.
2680         (regcache::raw_write): Use make_scope_exit.
2681
2682 2019-01-23  Tom Tromey  <tom@tromey.com>
2683
2684         * ui-out.h (class ui_out_emit_type): Update comment.
2685
2686 2019-01-23  Tom Tromey  <tom@tromey.com>
2687
2688         * infrun.c (fetch_inferior_event): Update comment.
2689
2690 2019-01-23  Tom Tromey  <tom@tromey.com>
2691             Pedro Alves  <palves@redhat.com>
2692
2693         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2694         parameter.
2695         (fetch_inferior_event): Use SCOPE_EXIT.
2696
2697
2698 2019-01-23  Tom Tromey  <tom@tromey.com>
2699             Pedro Alves  <palves@redhat.com>
2700
2701         * infrun.c (disable_thread_events): Delete.
2702         (stop_all_threads): Use SCOPE_EXIT.
2703
2704 2019-01-23  Tom Tromey  <tom@tromey.com>
2705             Pedro Alves  <palves@redhat.com>
2706
2707         * symfile.c: Include forward-scope-exit.h.
2708         (clear_symtab_users_cleanup): Replace forward declaration with
2709         a FORWARD_SCOPE_EXIT.
2710         (syms_from_objfile_1): Use the forward_scope_exit and
2711         gdb::optional instead of cleanup_function.
2712         (reread_symbols): Use the forward_scope_exit instead of
2713         cleanup_function.
2714         (clear_symtab_users_cleanup): Remove function.
2715
2716 2019-01-23  Tom Tromey  <tom@tromey.com>
2717             Pedro Alves  <palves@redhat.com>
2718
2719         * linux-nat.c: Include scope-exit.h.
2720         (cleanup_target_stop): Remove.
2721         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2722         SCOPE_EXIT.
2723
2724 2019-01-23  Tom Tromey  <tom@tromey.com>
2725             Pedro Alves  <palves@redhat.com>
2726
2727         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2728         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2729
2730 2019-01-23  Tom Tromey  <tom@tromey.com>
2731             Andrew Burgess  <andrew.burgess@embecosm.com>
2732             Pedro Alves  <palves@redhat.com>
2733
2734         * infrun.c (fetch_inferior_event): Use scope_exit.
2735         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2736         * top.c (execute_command): Use scope_exit.
2737         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2738         * utils.c (do_bpstat_clear_actions_cleanup)
2739         (make_bpstat_clear_actions_cleanup): Remove.
2740
2741 2019-01-23  Tom Tromey  <tom@tromey.com>
2742             Pedro Alves  <palves@redhat.com>
2743
2744         * infrun.c: Include "common/scope-exit.h"
2745         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2746         (wait_for_inferior): Use SCOPE_EXIT.
2747         (fetch_inferior_event): Use scope_exit.
2748
2749 2019-01-23  Tom Tromey  <tom@tromey.com>
2750             Pedro Alves  <palves@redhat.com>
2751
2752         * breakpoint.c (create_breakpoint): Remove cleanup.
2753
2754 2019-01-23  Tom Tromey  <tom@tromey.com>
2755             Andrew Burgess  <andrew.burgess@embecosm.com>
2756             Pedro Alves  <palves@redhat.com>
2757
2758 2019-01-23  Pedro Alves  <palves@redhat.com>
2759
2760         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2761
2762 2019-01-23  Pedro Alves  <palves@redhat.com>
2763             Andrew Burgess  <andrew.burgess@embecosm.com>
2764
2765         * gdbthread.h: Include "common/forward-scope-exit.h".
2766         (scoped_finish_thread_state): Redefine custom class in terms of
2767         forward_scope_exit.
2768
2769 2019-01-23  Pedro Alves  <palves@redhat.com>
2770             Andrew Burgess  <andrew.burgess@embecosm.com>
2771
2772         * common/forward-scope-exit.h: New file.
2773
2774 2019-01-23  Pedro Alves  <palves@redhat.com>
2775             Andrew Burgess  <andrew.burgess@embecosm.com>
2776             Tom Tromey  <tom@tromey.com>
2777
2778         * common/scope-exit.h: New file.
2779
2780 2019-01-23  Pedro Alves  <palves@redhat.com>
2781
2782         * common/preprocessor.h (ESC): Rename to ...
2783         (ESC_PARENS): ... this.
2784         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2785         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2786
2787 2019-01-23  Tom Tromey  <tom@tromey.com>
2788
2789         * language.h (class scoped_switch_to_sym_language_if_auto):
2790         Initialize m_lang in both cases.
2791
2792 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2793
2794         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2795         with XCNEW.
2796
2797 2019-01-22  Tom Tromey  <tom@tromey.com>
2798
2799         * corelow.c: Do not include sys/file.h.
2800
2801 2019-01-22  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui-wingeneral.h: Include gdb_curses.h.
2804
2805 2019-01-22  Tom Tromey  <tom@tromey.com>
2806
2807         * source-cache.h (class source_cache) <get_source_lines,
2808         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2809
2810 2019-01-22  Tom Tromey  <tom@tromey.com>
2811
2812         * remote-fileio.h (struct remote_target): Declare.
2813
2814 2019-01-22  Tom Tromey  <tom@tromey.com>
2815
2816         * python/py-arch.c: Do not include py-ref.h.
2817         * python/py-bpevent.c: Do not include py-ref.h.
2818         * python/py-cmd.c: Do not include py-ref.h.
2819         * python/py-continueevent.c: Do not include py-ref.h.
2820         * python/py-event.h: Do not include py-ref.h.
2821         * python/py-evtregistry.c: Do not include py-ref.h.
2822         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2823         * python/py-frame.c: Do not include py-ref.h.
2824         * python/py-framefilter.c: Do not include py-ref.h.
2825         * python/py-function.c: Do not include py-ref.h.
2826         * python/py-infevents.c: Do not include py-ref.h.
2827         * python/py-linetable.c: Do not include py-ref.h.
2828         * python/py-objfile.c: Do not include py-ref.h.
2829         * python/py-param.c: Do not include py-ref.h.
2830         * python/py-prettyprint.c: Do not include py-ref.h.
2831         * python/py-progspace.c: Do not include py-ref.h.
2832         * python/py-symbol.c: Do not include py-ref.h.
2833         * python/py-symtab.c: Do not include py-ref.h.
2834         * python/py-type.c: Do not include py-ref.h.
2835         * python/py-unwind.c: Do not include py-ref.h.
2836         * python/py-utils.c: Do not include py-ref.h.
2837         * python/py-value.c: Do not include py-ref.h.
2838         * python/py-varobj.c: Do not include py-ref.h.
2839         * python/py-xmethods.c: Do not include py-ref.h.
2840         * python/python.c: Do not include py-ref.h.
2841         * varobj.c: Do not include py-ref.h.
2842
2843 2019-01-22  Tom Tromey  <tom@tromey.com>
2844
2845         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2846         keyword for bcache.
2847
2848 2019-01-22  Tom Tromey  <tom@tromey.com>
2849
2850         * compile/compile-cplus-types.c: Remove a comment by #include.
2851
2852 2019-01-22  Tom Tromey  <tom@tromey.com>
2853
2854         * compile/gcc-c-plugin.h: Include compile-internal.h.
2855
2856 2019-01-22  Tom Tromey  <tom@tromey.com>
2857
2858         * stabsread.c (EXTERN): Do not define.
2859         (symnum, next_symbol_text_func, processing_gcc_compilation)
2860         (within_function, global_sym_chain, global_stabs)
2861         (previous_stab_code, this_object_header_files)
2862         (n_this_object_header_files)
2863         (n_allocated_this_object_header_files): Define.
2864         * stabsread.h (EXTERN): Never define.  Use "extern".
2865
2866 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2867
2868         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2869         history_value.
2870
2871 2019-01-21  Tom Tromey  <tom@tromey.com>
2872
2873         * ui-out.c: Fix includes.
2874         * tui/tui-source.c: Fix includes.
2875         * target.c: Fix includes.
2876         * remote.c: Fix includes.
2877         * regcache.c: Fix includes.
2878         * python/py-block.c: Fix includes.
2879         * printcmd.c: Fix includes.
2880         * or1k-tdep.c: Fix includes.
2881         * mi/mi-main.c: Fix includes.
2882         * m32r-tdep.c: Fix includes.
2883         * csky-tdep.c: Fix includes.
2884         * compile/compile-cplus-types.c: Fix includes.
2885         * cli/cli-interp.c: Fix includes.
2886
2887 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2888
2889         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2890         for padding.
2891
2892 2019-01-16  Tom Tromey  <tom@tromey.com>
2893
2894         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2895         earlier.
2896         (struct objfile) <msymbols_range>: Move from top level.
2897         <msymbols>: New method.
2898         (class objfile_msymbols): Remove.
2899         * symtab.c (default_collect_symbol_completion_matches_break_on):
2900         Update.
2901         * symmisc.c (dump_msymbols): Update.
2902         * stabsread.c (scan_file_globals): Update.
2903         * objc-lang.c (info_selectors_command, info_classes_command)
2904         (find_methods): Update.
2905         * minsyms.c (find_solib_trampoline_target): Update.
2906         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2907         * coffread.c (coff_symfile_read): Update.
2908         * ada-lang.c (ada_lookup_simple_minsym)
2909         (ada_collect_symbol_completion_matches): Update.
2910
2911 2019-01-16  Tom Tromey  <tom@tromey.com>
2912
2913         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2914         type.  Remove no-argument constructor.
2915         <iterator::operator++>: Simplify.
2916         <begin>: Update.
2917         <end>: Use minimal_symbol_count.
2918
2919 2019-01-16  Tom Tromey  <tom@tromey.com>
2920
2921         * objfiles.h (struct objfile) <psymtabs>: New method.
2922         (class objfile_psymtabs): Remove.
2923         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2924         typedef.
2925         <range>: New method.
2926         (require_partial_symbols): Change return type.
2927         * psymtab.c (require_partial_symbols)
2928         (psym_expand_symtabs_matching): Update.
2929         * mdebugread.c (parse_partial_symbols): Update.
2930         * dbxread.c (dbx_end_psymtab): Update.
2931
2932 2019-01-15  Tom Tromey  <tom@tromey.com>
2933
2934         * symtab.c (lookup_objfile_from_block)
2935         (lookup_symbol_in_objfile_symtabs)
2936         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2937         (find_line_symtab, info_sources_command)
2938         (default_collect_symbol_completion_matches_break_on)
2939         (make_source_files_completion_list): Update.
2940         * symmisc.c (print_objfile_statistics, dump_objfile)
2941         (maintenance_print_symbols, maintenance_info_symtabs)
2942         (maintenance_check_symtabs, maintenance_info_line_tables):
2943         Update.
2944         * source.c (select_source_symtab)
2945         (forget_cached_source_info_for_objfile): Update.
2946         * objfiles.h (class objfile_compunits): Remove.
2947         (struct objfile) <compunits_range>: New typedef.
2948         (compunits): New method.
2949         * objfiles.c (objfile_relocate1): Update.
2950         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2951         * maint.c (count_symtabs_and_blocks): Update.
2952         * linespec.c (iterate_over_all_matching_symtabs): Update.
2953         * cp-support.c (add_symbol_overload_list_qualified): Update.
2954         * coffread.c (coff_symtab_read): Update.
2955         * ada-lang.c (add_nonlocal_symbols)
2956         (ada_collect_symbol_completion_matches)
2957         (ada_add_global_exceptions): Update.
2958
2959 2019-01-15  Tom Tromey  <tom@tromey.com>
2960
2961         * progspace.h (program_space) <objfiles_safe_range>: New
2962         typedef.
2963         <objfiles_safe>: New method.
2964         * objfiles.h (class all_objfiles_safe): Remove.
2965         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2966         * jit.c (jit_inferior_exit_hook): Update.
2967
2968 2019-01-17  Tom Tromey  <tom@tromey.com>
2969
2970         * progspace.h (program_space) <objfiles_range>: New typedef.
2971         <objfiles>: New method.
2972         <objfiles_head>: Rename from objfiles.
2973         (object_files): Update.
2974         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2975         * guile/scm-pretty-print.c
2976         (ppscm_find_pretty_printer_from_objfiles): Update.
2977         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2978         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2979         Update.
2980         * python/py-progspace.c (pspy_get_objfiles): Update.
2981         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2982         Update.
2983         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2984         (objfpy_lookup_objfile_by_build_id): Update.
2985         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2986         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2987         Update.
2988         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2989         (expand_symtab_containing_pc, lookup_objfile_from_block)
2990         (lookup_static_symbol, basic_lookup_transparent_type)
2991         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2992         (find_line_symtab, info_sources_command)
2993         (default_collect_symbol_completion_matches_break_on)
2994         (make_source_files_completion_list, find_main_name): Update.
2995         * symmisc.c (print_symbol_bcache_statistics)
2996         (print_objfile_statistics, maintenance_print_symbols)
2997         (maintenance_print_msymbols, maintenance_print_objfiles)
2998         (maintenance_info_symtabs, maintenance_check_symtabs)
2999         (maintenance_expand_symtabs, maintenance_info_line_tables):
3000         Update.
3001         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3002         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3003         (map_overlay_command, unmap_overlay_command)
3004         (simple_overlay_update, expand_symtabs_matching)
3005         (map_symbol_filenames): Update.
3006         * symfile-debug.c (set_debug_symfile): Update.
3007         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3008         Update.
3009         * source.c (select_source_symtab, forget_cached_source_info):
3010         Update.
3011         * solib.c (solib_read_symbols): Update.
3012         * solib-spu.c (append_ocl_sos): Update.
3013         * psymtab.c (maintenance_print_psymbols)
3014         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3015         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3016         * printcmd.c (info_symbol_command): Update.
3017         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3018         Update.
3019         * objfiles.h (class all_objfiles): Remove.
3020         * objfiles.c (have_partial_symbols, have_full_symbols)
3021         (have_minimal_symbols, qsort_cmp, update_section_map)
3022         (shared_objfile_contains_address_p)
3023         (default_iterate_over_objfiles_in_search_order): Update.
3024         * objc-lang.c (info_selectors_command, info_classes_command)
3025         (find_methods): Update.
3026         * minsyms.c (find_solib_trampoline_target): Update.
3027         * maint.c (maintenance_info_sections)
3028         (maintenance_translate_address, count_symtabs_and_blocks):
3029         Update.
3030         * main.c (captured_main_1): Update.
3031         * linux-thread-db.c (try_thread_db_load_from_pdir)
3032         (has_libpthread): Update.
3033         * linespec.c (iterate_over_all_matching_symtabs)
3034         (search_minsyms_for_name): Update.
3035         * jit.c (jit_find_objf_with_entry_addr): Update.
3036         * hppa-tdep.c (find_unwind_entry)
3037         (hppa_lookup_stub_minimal_symbol): Update.
3038         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3039         Update.
3040         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3041         (elf_gnu_ifunc_resolve_by_got): Update.
3042         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3043         * dwarf-index-write.c (save_gdb_index_command): Update.
3044         * cp-support.c (add_symbol_overload_list_qualified): Update.
3045         * breakpoint.c (create_overlay_event_breakpoint)
3046         (create_longjmp_master_breakpoint)
3047         (create_std_terminate_master_breakpoint)
3048         (create_exception_master_breakpoint): Update.
3049         * blockframe.c (find_pc_partial_function): Update.
3050         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3051         (ada_collect_symbol_completion_matches)
3052         (ada_add_global_exceptions): Update.
3053
3054 2019-01-17  Tom Tromey  <tom@tromey.com>
3055
3056         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3057         declare VEC.
3058         (solib_target_parse_libraries): Change return type.
3059         (library_list_start_segment, library_list_start_section)
3060         (library_list_end_library, library_list_start_library); Update.
3061         (solib_target_free_library_list): Remove.
3062         (solib_target_parse_libraries): Remove cleanup.  Change return
3063         type.
3064         (solib_target_current_sos): Update.
3065
3066 2019-01-17  Tom Tromey  <tromey@bapiya>
3067
3068         * valprint.c: Replace "the the" with "the".
3069         * symtab.c: Replace "the the" with "the".
3070         * solib.c: Replace "the the" with "the".
3071         * solib-dsbt.c: Replace "the the" with "the".
3072         * linespec.c: Replace "the the" with "the".
3073         * dwarf2loc.h: Replace "the the" with "the".
3074         * amd64-windows-tdep.c: Replace "the the" with "the".
3075         * aarch64-tdep.c: Replace "the the" with "the".
3076
3077 2019-01-16  Keith Seitz  <keiths@redhat.com>
3078
3079         PR gdb/23773
3080         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3081         <builder>: Rename to ..
3082         <m_builder>: ... this and make private.
3083         (dwarf2_cu::get_builder): New method.  Change all users of
3084         `builder' to use this method.
3085         (dwarf2_start_symtab): Move to ...
3086         (dwarf2_cu::start_symtab): ... here.  Update all callers
3087         (setup_type_unit_groups): Move to ...
3088         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3089         callers.
3090         (dwarf2_cu::reset_builder): New method.
3091         (process_full_compunit, process_full_type_unit): Use
3092         dwarf2_cu::reset_builder.
3093         (follow_die_offset): Record the ancestor CU if it is different
3094         from the followed DIE's CU.
3095         (follow_die_sig_1): Likewise.
3096
3097 2019-01-15  Tom Tromey  <tom@tromey.com>
3098
3099         * remote.c (class remote_state) <buf>: Now a char_vector.
3100         <buf_size>: Remove.
3101         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3102         parameter.
3103         (remote_target::getpkt_or_notif_sane_1)
3104         (remote_target::getpkt_sane)
3105         (remote_target::getpkt_or_notif_sane): Likewise.
3106         (class remote_target) <putpkt>: New overload.
3107         (remote_target::read_frame): Change type of "buf_p".  Remove
3108         sizeof_p parameter.
3109         (packet_ok): New overload.
3110         (packet_check_result): New overload.
3111         Update all uses.
3112
3113 2019-01-14  Tom Tromey  <tom@tromey.com>
3114
3115         * remote-notif.c (handle_notification, remote_notif_ack)
3116         (remote_notif_parse): Make "buf" const.
3117         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3118         const.
3119         (remote_notif_parse, remote_notif_ack, handle_notification):
3120         Likewise.
3121         * remote.c (remote_notif_stop_parse): Make "buf" const.
3122         (remote_target::remote_parse_stop_reply): Make "buf" const.
3123         (remote_notif_stop_ack): Make "buf" const.
3124
3125 2019-01-14  Tom Tromey  <tom@tromey.com>
3126
3127         * remote.c (remote_console_output): Make parameter const.
3128
3129 2019-01-14  Tom Tromey  <tom@tromey.com>
3130
3131         * target-debug.h (target_debug_print_signals): Constify.
3132         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3133         * procfs.c (procfs_target::pass_signals): Update.
3134         * linux-nat.c (linux_nat_target::pass_signals): Update.
3135         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3136         * target-delegates.c: Rebuild.
3137         * remote.c (remote_target::program_signals): Update.
3138         (remote_target::pass_signals): Update.
3139         * target.c (target_pass_signals): Constify argument.
3140         (target_program_signals): Likewise.
3141         * target.h (struct target_ops) <pass_signals, program_signals>:
3142         Constify argument.
3143         (target_pass_signals, target_program_signals): Constify argument.
3144
3145 2019-01-14  Tom Tromey  <tom@tromey.com>
3146
3147         PR tui/28819:
3148         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3149
3150 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3151
3152         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3153         field.
3154         * rs6000-tdep.c: Include reggroups.h.
3155         (IS_V_ALIAS_PSEUDOREG): Define.
3156         (rs6000_register_name): Return names for the "vX" aliases.
3157         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3158         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3159         aliases.  Call default_register_reggroup_p for all other
3160         pseudo-registers.
3161         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3162         New functions.
3163         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3164         Handle "vX" aliases.
3165         (v_alias_pseudo_register_collect): New function.
3166         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3167         (rs6000_gdbarch_init): Initialize "vX" aliases as
3168         pseudo-registers.  Restore registration of
3169         rs6000_pseudo_register_reggroup_p with
3170         set_tdesc_pseudo_register_reggroup_p.
3171
3172 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3173
3174         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3175         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3176         set_gdbarch_num_pseudo_regs.
3177
3178 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3179
3180         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3181         Remove arg prefixname, add do_set and do_show.
3182         Add member functions set_list and show_list.
3183         * cli/cli-style.c (class cli_style_option): Update accordingly.
3184         (style_set_list): Move to file scope.
3185         (style_show_list): Likewise.
3186         (set_style): Call help_list.
3187         (show_style): Call cmd_show_list.
3188         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3189         Update to use the new macro.
3190
3191 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3192
3193         * ada-lang.c (_initialize_ada_language): Expand the help text
3194         for the "catch exception" command.
3195
3196 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3197
3198         * symtab.c (matching_obj_sections): Initialize obj,
3199         declare it closer to its usage.
3200
3201 2019-01-10  Tom Tromey  <tom@tromey.com>
3202
3203         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3204         (basic_inf_threads_range): Remove.
3205         (inf_threads_range, inf_non_exited_threads_range)
3206         (safe_inf_threads_range): Use next_adapter.
3207
3208 2019-01-10  Keith Seitz  <keiths@redhat.com>
3209
3210         PR gdb/23712
3211         PR symtab/23010
3212         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3213         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3214
3215 2019-01-10  Keith Seitz  <keiths@redhat.com>
3216
3217         PR gdb/23712
3218         PR symtab/23010
3219         * dictionary.c (pending_to_vector): Remove.
3220         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3221         Remove _1 suffix, replacing functions of the same name.  Update
3222         all callers.
3223         (dict_create_hashed, dict_create_hashed_expandable)
3224         (dict_create_linear, dict_create_linear_expandable, dict_free)
3225         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3226         Make functions static.
3227
3228 2019-01-10  Keith Seitz  <keiths@redhat.com>
3229
3230         PR gdb/23712
3231         PR symtab/23010
3232         * dictionary.h (struct dictionary): Replace declaration with
3233         multidictionary.
3234         (dict_create_hashed, dict_create_hashed_expandable)
3235         (dict_create_linear, dict_create_linear_expandable)
3236         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3237         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3238         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3239         taking multidictionary argument.
3240         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3241         * block.h (struct block) <dict>: Change to multidictionary
3242         and rename `multidict'.
3243         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3244         symmisc.c: Update all dictionary references to multidictionary.
3245
3246 2019-01-10  Keith Seitz  <keiths@redhat.com>
3247
3248         PR gdb/23712
3249         PR symtab/23010
3250         * dictionary.c: Include unordered_map.
3251         (pending_to_vector): New function.
3252         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3253         Rewrite the non-"_1" functions to take vector instead
3254         of linked list.
3255         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3256         "new" _1 versions of the same name.
3257         (multidictionary): Define.
3258         (std::hash<enum language): New definition.
3259         (collate_pending_symbols_by_language, mdict_create_hashed)
3260         (mdict_create_hashed_expandable, mdict_create_linear)
3261         (mdict_create_linear_expandable, mdict_free)
3262         (find_language_dictionary, create_new_language_dictionary)
3263         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3264         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3265         (mdict_size, mdict_empty): New functions.
3266         * dictionary.h (mdict_iterator): Define.
3267
3268 2019-01-10  Pedro Alves  <palves@redhat.com>
3269
3270         * breakpoint.c (read_uploaded_action)
3271         (create_tracepoint_from_upload): Adjust to use
3272         gdb::unique_xmalloc_ptr.
3273         * ctf.c (ctf_write_uploaded_tp):
3274         (SET_ARRAY_FIELD): Use emplace_back.
3275         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3276         * tracefile-tfile.c (tfile_write_uploaded_tp):
3277         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3278         gdb::unique_xmalloc_ptr.
3279         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3280         at_string, cond_string, cmd_strings>: Replace char pointers
3281         with gdb::unique_xmalloc_ptr.
3282
3283 2019-01-10  Pedro Alves  <palves@redhat.com>
3284
3285         * solib-target.c (library_list_start_library): Don't xstrdup name.
3286
3287 2019-01-10  Pedro Alves  <palves@redhat.com>
3288
3289         * mdebugread.c (parse_partial_symbols): Use
3290         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3291
3292 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * linux-fork.c (scoped_switch_fork_info)
3295         <~scoped_switch_fork_info>: Fix incorrect variable name.
3296
3297 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3298
3299         * linux-fork.c (scoped_switch_fork_info)
3300         <scoped_switch_fork_info>: Make explicit.
3301         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3302
3303 2019-01-10  Tom Tromey  <tom@tromey.com>
3304
3305         * objfiles.h (objfile::reset_psymtabs): Update.
3306         * objfiles.c (objfile::objfile): Update.
3307         * psymtab.h (psymtab_storage::obstack): Update.
3308         (psymtab_storage::m_obstack): Use gdb::optional.
3309         (class psymtab_storage): Update comment.  Remove objfile
3310         parameter.
3311         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3312
3313 2019-01-10  Tom Tromey  <tom@tromey.com>
3314
3315         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3316         <free_psymtabs>: Now private.
3317         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3318         (allocate_psymtab): Use new method.
3319
3320 2019-01-10  Tom Tromey  <tom@tromey.com>
3321
3322         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3323         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3324         * mdebugread.c (parse_partial_symbols): Use
3325         allocate_dependencies.
3326         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3327         allocate_dependencies.
3328         (process_psymtab_comp_unit_reader)
3329         (build_type_psymtab_dependencies): Likewise.
3330         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3331
3332 2019-01-10  Tom Tromey  <tom@tromey.com>
3333
3334         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3335         PSYMBOL_SET_LANGUAGE.
3336         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3337
3338 2019-01-10  Tom Tromey  <tom@tromey.com>
3339
3340         * psymtab.h (psymtab_storage::obstack): New method.
3341         <m_obstack>: Rename from obstack; now private.
3342         * psymtab.c (psymtab_storage): Update.
3343         * dwarf2read.c (create_addrmap_from_index)
3344         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3345         Update.
3346
3347 2019-01-10  Tom Tromey  <tom@tromey.com>
3348
3349         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3350         * objfiles.h (objfile::reset_psymtabs): New method.
3351
3352 2019-01-10  Tom Tromey  <tom@tromey.com>
3353
3354         * symmisc.c (print_symbol_bcache_statistics): Update.
3355         (print_objfile_statistics): Update.
3356         * symfile.c (reread_symbols): Update.
3357         * psymtab.h (class psymtab_storage): New.
3358         * psymtab.c (psymtab_storage): New constructor.
3359         (~psymtab_storage): New destructor.
3360         (require_partial_symbols): Update.
3361         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3362         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3363         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3364         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3365         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3366         (start_psymtab_common, end_psymtab_common)
3367         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3368         (allocate_psymtab): Update.
3369         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3370         Update.
3371         (dump_psymtab_addrmap, maintenance_print_psymbols)
3372         (maintenance_check_psymtabs): Update.
3373         (class objfile_psymtabs): Move to objfiles.h.
3374         * psympriv.h (discard_psymtab): Now inline.
3375         (psymtab_discarder::psymtab_discarder): Update.
3376         (psymtab_discarder::~psymtab_discarder): Update.
3377         (ALL_OBJFILE_PSYMTABS): Rewrite.
3378         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3379         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3380         Remove fields.
3381         <partial_symtabs>: New field.
3382         (class objfile_psymtabs): Move from psymtab.h.  Update.
3383         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3384         psymbol_cache.
3385         (objfile::~objfile): Don't destroy psymbol_cache.
3386         * mdebugread.c (parse_partial_symbols): Update.
3387         * dwarf2read.c (create_addrmap_from_index)
3388         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3389         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3390         (add_partial_subprogram, dwarf2_ranges_read): Update.
3391         * dwarf-index-write.c (write_address_map)
3392         (write_one_signatured_type, recursively_write_psymbols)
3393         (class debug_names, class debug_names, write_psymtabs_to_index):
3394         Update.
3395
3396 2019-01-10  Tom Tromey  <tom@tromey.com>
3397
3398         * symtab.h (SYMBOL_SET_NAMES): Update.
3399         (symbol_set_names): Update.
3400         (MSYMBOL_SET_NAMES): Update.
3401         * symtab.c (symbol_set_names): Change argument to be an
3402         objfile_per_bfd_storage.
3403         * psymtab.c (add_psymbol_to_bcache): Update.
3404         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3405
3406 2019-01-10  Tom Tromey  <tom@tromey.com>
3407
3408         * symtab.c (create_demangled_names_hash): Change argument to be an
3409         objfile_per_bfd_storage.
3410         (symbol_set_names): Update.
3411
3412 2019-01-10  Tom Tromey  <tom@tromey.com>
3413
3414         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3415         init_psymbol_list.
3416         * psymtab.c (init_psymbol_list): Do nothing if already called.
3417         * psympriv.h (init_psymbol_list): Add comment.
3418         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3419         init_psymbol_list.
3420         * dbxread.c (dbx_symfile_read): Unconditionally call
3421         init_psymbol_list.
3422
3423 2019-01-10  Tom Tromey  <tom@tromey.com>
3424
3425         * xcoffread.c (scan_xcoff_symtab): Update.
3426         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3427         "where".
3428         * mdebugread.c (parse_partial_symbols)
3429         (handle_psymbol_enumerators): Update.
3430         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3431         * dbxread.c (read_dbx_symtab): Update.
3432         * psympriv.h (psymbol_placement): New enum.
3433         (add_psymbol_to_list): Update.
3434
3435 2019-01-10  Tom Tromey  <tom@tromey.com>
3436
3437         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3438         static_psymbols parameters.
3439         (scan_xcoff_symtab): Update.
3440         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3441         static_psymbols parameters.
3442         * psympriv.h (start_psymtab_common): Update.
3443         * mdebugread.c (parse_partial_symbols): Update.
3444         * dwarf2read.c (create_partial_symtab): Update.
3445         * dbxread.c (read_dbx_symtab): Update.
3446         (start_psymtab): Remove global_psymbols and static_psymbols
3447         parameters.
3448
3449 2019-01-10  Tom Tromey  <tom@tromey.com>
3450
3451         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3452         * psymtab.c (allocate_psymtab): Add comment.
3453         * psympriv.h (allocate_psymtab): Add comment.
3454         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3455         initializations.
3456         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3457
3458 2019-01-10  Tom Tromey  <tom@tromey.com>
3459
3460         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3461         Don't declare.
3462         * mipsread.c: Include mdebugread.h.
3463         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3464         Declare.
3465         * elfread.c: Include mdebugread.h.
3466
3467 2019-01-09  Tom Tromey  <tom@tromey.com>
3468
3469         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3470         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3471         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3472         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3473         (psym_lookup_symbol, psym_find_last_source_symtab)
3474         (psym_forget_cached_source_info, psym_print_stats)
3475         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3476         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3477         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3478         (psym_find_compunit_symtab_by_address)
3479         (maintenance_print_psymbols, maintenance_info_psymtabs)
3480         (maintenance_check_psymtabs): Use ranged for.
3481         * psymtab.h (class objfile_psymtabs): New.
3482         (require_partial_symbols): Return objfile_psymtabs.
3483         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3484
3485 2019-01-09  Tom Tromey  <tom@tromey.com>
3486
3487         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3488         (find_pc_mapped_section, list_overlays_command)
3489         (map_overlay_command, unmap_overlay_command)
3490         (simple_overlay_update): Use all_objfiles.
3491         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3492         * printcmd.c (info_symbol_command): Use all_objfiles.
3493         * objfiles.h (ALL_OBJSECTIONS): Remove.
3494         * maint.c (maintenance_translate_address): Use all_objfiles.
3495         * gcore.c (gcore_create_callback): Use all_objfiles.
3496         (objfile_find_memory_regions): Likewise.
3497
3498 2019-01-09  Tom Tromey  <tom@tromey.com>
3499
3500         * symtab.c (find_line_symtab, info_sources_command)
3501         (make_source_files_completion_list): Use objfile_compunits.
3502         * source.c (select_source_symtab): Use objfile_compunits.
3503         * objfiles.h (struct objfile): Update comment.
3504         (ALL_OBJFILES): Remove.
3505         (ALL_FILETABS): Remove.
3506         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3507         objfile_compunits.
3508
3509 2019-01-09  Tom Tromey  <tom@tromey.com>
3510
3511         * symmisc.c (print_objfile_statistics, dump_objfile)
3512         (maintenance_print_symbols): Use compunit_filetabs.
3513         * source.c (forget_cached_source_info_for_objfile): Use
3514         compunit_filetabs.
3515         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3516         (ALL_FILETABS): Use compunit_filetabs.
3517         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3518         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3519
3520 2019-01-09  Tom Tromey  <tom@tromey.com>
3521
3522         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3523         (compunit_filetabs): New.
3524         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3525         compunit_filetabs.
3526         (info_sources_command, make_source_files_completion_list): Remove
3527         declaration.
3528         * symmisc.c (print_objfile_statistics, dump_objfile)
3529         (maintenance_print_symbols): Remove declaration.
3530         (maintenance_info_symtabs): Use compunit_filetabs.
3531         (maintenance_info_line_tables): Likewise.
3532         * source.c (select_source_symtab): Change local variable name.
3533         (forget_cached_source_info_for_objfile): Remove declaration.
3534         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3535         * objfiles.c (objfile_relocate1): Remove declaration.
3536         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3537         declaration.
3538         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3539         * coffread.c (coff_symtab_read): Remove declaration.
3540         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3541         compunit_filetabs.
3542
3543 2019-01-09  Tom Tromey  <tom@tromey.com>
3544
3545         * symtab.c (lookup_objfile_from_block)
3546         (find_pc_sect_compunit_symtab, search_symbols)
3547         (default_collect_symbol_completion_matches_break_on): Use
3548         objfile_compunits.
3549         * objfiles.h (ALL_COMPUNITS): Remove.
3550         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3551         * cp-support.c (add_symbol_overload_list_qualified): Use
3552         objfile_compunits.
3553         * ada-lang.c (ada_collect_symbol_completion_matches)
3554         (ada_add_global_exceptions): Use objfile_compunits.
3555
3556 2019-01-09  Tom Tromey  <tom@tromey.com>
3557
3558         * source.c (select_source_symtab)
3559         (forget_cached_source_info_for_objfile): Remove declaration.
3560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3561         declaration.
3562         * maint.c (count_symtabs_and_blocks): Remove declaration.
3563         * cp-support.c (add_symbol_overload_list_qualified): Remove
3564         declaration.
3565         * coffread.c (coff_symtab_read): Remove declaration.
3566         * symtab.c (lookup_symbol_in_objfile_symtabs)
3567         (basic_lookup_transparent_type_1): Use objfile_compunits.
3568         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3569         (info_sources_command, search_symbols)
3570         (default_collect_symbol_completion_matches_break_on)
3571         (make_source_files_completion_list): Remove declaration.
3572         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3573         (ada_collect_symbol_completion_matches)
3574         (ada_add_global_exceptions): Remove declaration.
3575         * linespec.c (iterate_over_all_matching_symtabs): Use
3576         objfile_compunits.
3577         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3578         (class objfile_compunits): New.
3579         (ALL_COMPUNITS): Use objfile_compunits.
3580         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3581         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3582         objfile_compunits.
3583         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3584
3585 2019-01-09  Tom Tromey  <tom@tromey.com>
3586
3587         * symtab.c (search_symbols)
3588         (default_collect_symbol_completion_matches_break_on): Use
3589         objfile_msymbols.
3590         * ada-lang.c (ada_lookup_simple_minsym)
3591         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3592         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3593         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3594         objfile_msymbols.
3595         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3596         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3597         * objc-lang.c (find_methods): Use objfile_msymbols.
3598         (info_selectors_command, info_classes_command): Likewise.
3599         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3600         * objfiles.h (class objfile_msymbols): New.
3601         (ALL_OBJFILE_MSYMBOLS): Remove.
3602         (ALL_MSYMBOLS): Remove.
3603
3604 2019-01-09  Tom Tromey  <tom@tromey.com>
3605
3606         * common/next-iterator.h (next_adapter): Add Iterator template
3607         parameter.
3608         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3609         (class all_objfiles_safe): New.
3610         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3611         * objfiles.c (put_objfile_before): Update comment.
3612         (add_separate_debug_objfile): Likewise.
3613         (free_all_objfiles): Use all_objfiles_safe.
3614         (objfile_purge_solibs): Likewise.
3615
3616 2019-01-09  Tom Tromey  <tom@tromey.com>
3617
3618         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3619         (expand_symtab_containing_pc, lookup_static_symbol)
3620         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3621         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3622         all_objfiles.
3623         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3624         * breakpoint.c (create_overlay_event_breakpoint)
3625         (create_longjmp_master_breakpoint)
3626         (create_std_terminate_master_breakpoint)
3627         (create_exception_master_breakpoint): Use all_objfiles.
3628         * linux-thread-db.c (try_thread_db_load_from_pdir)
3629         (has_libpthread): Use all_objfiles.
3630         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3631         * linespec.c (iterate_over_all_matching_symtabs)
3632         (search_minsyms_for_name): Use all_objfiles.
3633         * maint.c (maintenance_info_sections): Use all_objfiles.
3634         * main.c (captured_main_1): Use all_objfiles.
3635         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3636         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3637         * guile/scm-pretty-print.c
3638         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3639         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3640         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3641         (maintenance_print_msymbols): Use all_objfiles.
3642         * source.c (select_source_symtab): Use all_objfiles.
3643         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3644         * symfile.c (remove_symbol_file_command)
3645         (expand_symtabs_matching, map_symbol_filenames): Use
3646         all_objfiles.
3647         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3648         all_objfiles.
3649         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3650         * objc-lang.c (find_methods): Use all_objfiles.
3651         * objfiles.c (have_partial_symbols, have_full_symbols)
3652         (have_minimal_symbols, qsort_cmp)
3653         (default_iterate_over_objfiles_in_search_order): Use
3654         all_objfiles.
3655         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3656         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3657         (maintenance_check_psymtabs): Use all_objfiles.
3658         (ALL_PSYMTABS): Remove.
3659         * compile/compile-object-run.c (do_module_cleanup): Use
3660         all_objfiles.
3661         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3662         * cp-support.c (add_symbol_overload_list_qualified): Use
3663         all_objfiles.
3664         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3665         Use all_objfiles.
3666         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3667         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3668         all_objfiles.
3669         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3670         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3671         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3672         Uses all_objfiles.
3673         * solib.c (solib_read_symbols): Use all_objfiles
3674
3675 2019-01-09  Tom Tromey  <tom@tromey.com>
3676
3677         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3678         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3679         all_objfiles.
3680         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3681         * symmisc.c (print_symbol_bcache_statistics)
3682         (print_objfile_statistics, maintenance_print_objfiles)
3683         (maintenance_info_symtabs, maintenance_check_symtabs)
3684         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3685         all_objfiles.
3686         * source.c (forget_cached_source_info): Use all_objfiles.
3687         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3688         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3689         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3690         * objfiles.c (update_section_map): Use all_objfiles.
3691         (shared_objfile_contains_address_p): Likewise.
3692         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3693         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3694
3695 2019-01-09  Tom Tromey  <tom@tromey.com>
3696
3697         * common/next-iterator.h: New file.
3698         * objfiles.h (class all_objfiles): New.
3699         (struct objfile_iterator): New.
3700
3701 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3702
3703         * NEWS: Move the description of the changed "frame", "select-frame",
3704          and "info frame" commands to the Changed commands section.
3705
3706 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3707
3708         * gdbtypes.c (check_stub_method_group): Remove handling of old
3709         mangling schemes.
3710         * linespec.c (find_methods): Likewise.
3711         * stabsread.c (read_member_functions): Likewise.
3712         * valops.c (search_struct_method): Likewise.
3713         (value_struct_elt_for_reference): Likewise.
3714         * NEWS: Mention this change.
3715
3716 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3719         print_source_lines.
3720         * source.c (print_source_lines_base): Update line number check.
3721         (print_source_lines): New function.
3722         (source_lines_range::source_lines_range): New function.
3723         * source.h (class source_lines_range): New class.
3724         (print_source_lines): New declaration.
3725
3726 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3727
3728         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3729
3730 2019-01-08  Tom Tromey  <tom@tromey.com>
3731             Simon Marchi  <simon.marchi@ericsson.com>
3732
3733         PR gdb/24060
3734         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3735         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3736         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3737         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3738         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3739         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3740
3741 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3742
3743         * source.c (select_source_symtab): Move header comment to
3744         declaration in source.h.
3745         (forget_cached_source_info_for_objfile): Likewise.
3746         (forget_cached_source_info): Likewise.
3747         (identify_source_line): Likewise.
3748         * source.h (identify_source_line): Move declaration from symtab.h
3749         and add comment from source.c
3750         (print_source_lines): Likewise.
3751         (forget_cached_source_info_for_objfile): Likewise.
3752         (forget_cached_source_info): Likewise.
3753         (select_source_symtab): Likewise.
3754         (enum print_source_lines_flag): Move definition from symtab.h.
3755         * symtab.h (identify_source_line): Move declaration to source.h.
3756         (print_source_lines): Likewise.
3757         (forget_cached_source_info_for_objfile): Likewise.
3758         (forget_cached_source_info): Likewise.
3759         (select_source_symtab): Likewise.
3760         (enum print_source_lines_flag): Move definition to source.h.
3761         * tui/tui-hooks.c: Add 'source.h' include.
3762
3763 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * source.c (print_source_lines_base): Handle requests to print
3766         reverse line number sequences, and guard against empty lines
3767         string.
3768
3769 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * source.c (print_source_lines_base): Fix skip of '\r' if next
3772         character is '\n'.
3773
3774 2019-01-06  Tom Tromey  <tom@tromey.com>
3775
3776         * c-exp.y (struct c_parse_state) <macro_original_text,
3777         expansion_obstack>: New member.
3778         (macro_original_text, expansion_obstack): Remove globals.
3779         (scan_macro_expansion, scanning_macro_expansion)
3780         (finished_macro_expansion): Update.
3781         (scan_macro_cleanup): Remove.
3782         (yylex, c_parse): Update.
3783
3784 2019-01-06  Tom Tromey  <tom@tromey.com>
3785
3786         * c-exp.y (struct c_parse_state) <strings>: New member.
3787         (operator_stoken): Update.
3788
3789 2019-01-06  Tom Tromey  <tom@tromey.com>
3790
3791         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3792         (union type_stack_elt) <typelist_val>: Now a pointer to
3793         std::vector.
3794         (type_stack_cleanup): Don't declare.
3795         (push_typelist): Update.
3796         * parse.c (pop_typelist): Return a std::vector.
3797         (push_typelist): Take a std::vector.
3798         (follow_types): Update.  Do not free args.
3799         (type_stack_cleanup): Remove.
3800         * c-exp.y (struct c_parse_state): New.
3801         (cpstate): New global.
3802         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3803         (nonempty_typelist): Update.
3804         (func_mod): Create a new vector.
3805         (c_parse): Create a c_parse_state.
3806         (check_parameter_typelist): Do not delete params.
3807         (function_method): Update.  Do not delete type_list.
3808
3809 2019-01-06  Tom Tromey  <tom@tromey.com>
3810
3811         PR gdb/28155:
3812         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3813         check_typedef.
3814         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3815         (print_return_value): Likewise.
3816
3817 2019-01-05  Tom Tromey  <tom@tromey.com>
3818
3819         * contrib/cleanup_check.py: Remove.
3820         * contrib/gcc-with-excheck: Remove.
3821         * contrib/exsummary.py: Remove.
3822         * contrib/excheck.py: Remove.
3823
3824 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3825
3826         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3827         NULL. Initialize tpprev to NULL instead of assigning it
3828         to NULL on the next statement.
3829         * windows-nat.c (windows_delete_thread): Remove check for
3830         main_thread_id before printing thread exit notifications.
3831         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3832         Remove thread ID check against main_thread_id.
3833         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3834         windows_delete_thread.
3835         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3836
3837 2019-01-04  Tom Tromey  <tom@tromey.com>
3838
3839         * compile/compile.c (_initialize_compile): Use upper case for
3840         metasyntactic variables.
3841         * symmisc.c (_initialize_symmisc): Use upper case for
3842         metasyntactic variables.
3843         * psymtab.c (_initialize_psymtab): Use upper case for
3844         metasyntactic variables.
3845         * demangle.c (demangle_command): Use upper case for metasyntactic
3846         variables.
3847         (_initialize_demangler): Likewise.
3848         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3849         variables.
3850
3851 2019-01-03  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3854
3855 2019-01-03  Tom Tromey  <tom@tromey.com>
3856
3857         * python/py-symtab.c (salpy_str): Update.
3858         (struct salpy_sal_object) <symtab>: Now a PyObject.
3859         (salpy_dealloc): Update.
3860         (del_objfile_sal): Use gdbpy_ref.
3861
3862 2019-01-03  Tom Tromey  <tom@tromey.com>
3863
3864         * python/py-type.c (convert_field): Use new_reference.  Return
3865         gdbpy_ref.
3866         (make_fielditem): Return gdbpy_ref.
3867         (typy_fields): Update.
3868         (typy_getitem): Update.
3869         (field_name): Return gdbpy_ref.  Use new_reference.
3870         (typy_iterator_iternext): Update.
3871
3872 2019-01-03  Tom Tromey  <tom@tromey.com>
3873
3874         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3875
3876 2019-01-03  Tom Tromey  <tom@tromey.com>
3877
3878         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3879         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3880         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3881         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3882         (pspy_set_type_printers): Likewise.
3883         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3884         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3885         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3886         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3887         (objfpy_set_type_printers): Likewise.
3888
3889 2019-01-03  Tom Tromey  <tom@tromey.com>
3890
3891         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3892         (gdbpy_print_stack): Use gdbpy_err_fetch.
3893         * python/python-internal.h (class gdbpy_err_fetch): New class.
3894         (class gdbpy_enter) <m_error_type, m_error_value,
3895         m_error_traceback>: Remove.
3896         <m_error>: New member.
3897         (gdbpy_exception_to_string): Don't declare.
3898         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3899         * python/py-value.c (convert_value_from_python): Use
3900         gdbpy_err_fetch.
3901         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3902         gdbpy_exception_to_string.
3903         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3904         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3905         gdbpy_err_fetch.
3906
3907 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * linux-nat.c (delete_lwp_cleanup): Delete.
3910         (struct lwp_deleter): New struct.
3911         (lwp_info_up): New typedef.
3912         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3913         lwp_info_up.
3914
3915 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * linux-fork.c (class scoped_switch_fork_info): New class.
3918         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3919
3920 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3921
3922         * valops.c (find_overload_match): Remove use of null_cleanup, and
3923         calls to do_cleanups.
3924
3925 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3926
3927         * compile/compile-cplus-types.c
3928         (compile_cplus_instance::decl_name): Handle changes to
3929         cp_func_name.
3930         * cp-support.c (cp_func_name): Update header comment, update
3931         return type.
3932         * cp-support.h (cp_func_name): Update return type in declaration.
3933         * valops.c (find_overload_match): Move temp_func local to top
3934         level of function and change its type.  Use temp_func to hold and
3935         delete temporary string obtained from cp_func_name.
3936
3937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3940         gdb::char_vector, remove cleanup, and update uses of `msg`.
3941
3942 2019-01-03  Jim Wilson  <jimw@sifive.com>
3943
3944         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3945
3946 2019-01-02  Tom Tromey  <tom@tromey.com>
3947
3948         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3949         (tdesc_parse_xml): Remove cleanups.
3950         * target-descriptions.h (make_cleanup_free_target_description):
3951         Don't declare.
3952         (target_desc_deleter): New struct.
3953         (target_desc_up): New typedef.
3954         * target-descriptions.c (target_desc_deleter::operator()): Rename
3955         from free_target_description.
3956         (make_cleanup_free_target_description): Remove.
3957
3958 2019-01-02  Tom Tromey  <tom@tromey.com>
3959
3960         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3961         constructor, destructor.
3962         (linespec_parser): Remove typedef.
3963         (~linespec_parser): Rename from linespec_parser_delete.
3964         (linespec_lex_to_end, linespec_complete_label)
3965         (linespec_complete): Update.
3966         (decode_line_full): Remove cleanups.
3967         (decode_line_1): Update.
3968
3969 2019-01-02  Tom Tromey  <tom@tromey.com>
3970
3971         * python/python-internal.h (inferior_to_inferior_object): Change
3972         return type.
3973         * python/py-exitedevent.c (create_exited_event_object): Update.
3974         * python/py-inferior.c (inferior_to_inferior_object): Return
3975         gdbpy_ref.
3976         (python_new_inferior, python_inferior_deleted)
3977         (thread_to_thread_object, delete_thread_object)
3978         (build_inferior_list, gdbpy_selected_inferior): Update.
3979         * python/py-infthread.c (create_thread_object): Update.  Also fail
3980         if inferior_to_inferior_object fails.
3981
3982 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3983
3984         * inferior.h (class inferior) <displaced_step_state>: New field.
3985         * infrun.h (struct displaced_step_state): Move here from
3986         infrun.c.  Initialize fields, add constructor.
3987         <inf>: Remove field.
3988         <reset>: New method.
3989         * infrun.c (struct displaced_step_inferior_state): Move to
3990         infrun.h.
3991         (displaced_step_inferior_states): Remove.
3992         (get_displaced_stepping_state): Adust.
3993         (displaced_step_in_progress_any_inferior): Adjust.
3994         (displaced_step_in_progress_thread): Adjust.
3995         (displaced_step_in_progress): Adjust.
3996         (add_displaced_stepping_state): Remove.
3997         (get_displaced_step_closure_by_addr): Adjust.
3998         (remove_displaced_stepping_state): Remove.
3999         (infrun_inferior_exit): Call displaced_step_state.reset.
4000         (use_displaced_stepping): Don't check for NULL.
4001         (displaced_step_prepare_throw): Call
4002         get_displaced_stepping_state.
4003         (displaced_step_fixup): Don't check for NULL.
4004         (prepare_for_detach): Don't check for NULL.
4005
4006 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4007
4008         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4009          in case of call that did not complete.
4010
4011 2019-01-02  Andrey Utkin  <autkin@undo.io>
4012
4013         * symfile.c (find_separate_debug_file): Fix search of debug files for
4014         remote debuggee.
4015
4016 2019-01-02  Tom Tromey  <tom@tromey.com>
4017
4018         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4019         indentation.
4020         * python/py-frame.c (frapy_older): Remove cast.
4021         (frapy_newer): Likewise.
4022         * python/py-breakpoint.c (local_setattro): Remove cast.
4023         * python/py-arch.c (archpy_name): Remove local variable.
4024         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4025
4026 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4027
4028         * unittests/basic_string_view/element_access/char/empty.cc:
4029         Fix year range in copyright header.
4030
4031 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4032
4033         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4034         Delete.
4035         <operator==>: Update with for removed field.
4036         <hash>: Likewise.
4037         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4038         <isa_features>: ...this.
4039         <abi_features>: New field.
4040         (riscv_isa_flen): Update comment.
4041         (riscv_abi_xlen): New declaration.
4042         (riscv_abi_flen): New declaration.
4043         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4044         isa_features.
4045         (riscv_abi_xlen): New function.
4046         (riscv_isa_flen): Update to get answer from isa_features.
4047         (riscv_abi_flen): New function.
4048         (riscv_has_fp_abi): Update to get answer from abi_features.
4049         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4050         xlen and flen.
4051         (riscv_call_info) <xlen, flen>: Update comment.
4052         (riscv_call_arg_struct): Remove invalid assertions
4053         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4054         is removed.
4055         (riscv_gdbarch_init): Gather isa features and abi features
4056         separately, ensure both match on the gdbarch when reusing an old
4057         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4058         a target with 64-bit float hardware.
4059
4060 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4061
4062         * source.c (search_command_helper): Stop reverse search
4063         when line 1 has been searched.
4064
4065 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4066
4067         * record-full.c (record_full_base_target::close): Rewrite
4068         record_full_core_buf_list free logic.
4069
4070 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4071
4072         * break-catch-syscall.c (print_one_catch_syscall): xfree
4073         the last text.
4074
4075 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4076
4077         * top.c (print_gdb_version): Update Copyright year in version
4078         message.
4079
4080 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4081
4082         Update copyright year range in all GDB files.
4083
4084 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4085
4086         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4087
4088 For older changes see ChangeLog-2018.
4089 \f
4090 Local Variables:
4091 mode: change-log
4092 left-margin: 8
4093 fill-column: 74
4094 version-control: never
4095 coding: utf-8
4096 End:
4097