gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * python/python-internal.h (create_thread_object): Return
   4         gdbpy_ref.
   5         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
   6         * python/py-inferior.c (struct threadlist_entry): Add
   7         constructor.
   8         <thread_obj>: Now a gdbpy_ref.
   9         (thread_to_thread_object): Update.
  10         (add_thread_object): Use new.
  11         (delete_thread_object): Use delete.
  12         (infpy_threads): Update.
  13         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  14         GIL.
  15
  16 2019-07-10  Tom Tromey  <tromey@adacore.com>
  17
  18         * valops.c (value_cast): Specialize error message for Ada.
  19
  20 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  21
  22         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  23
  24 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  25
  26         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  27         bpstat_should_step): Return bool, adjust comments.
  28         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  29         bpstat_should_step): Likewise.
  30
  31 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  32
  33         * features/Makefile: Use feature target descriptions for Arm.
  34         * features/arm/arm-core.c: Generate new file.
  35         * features/arm/arm-fpa.c: Likewise.
  36         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  37         * features/arm/arm-m-profile.c: Likewise.
  38         * features/arm/arm-vfpv2.c: Likewise.
  39         * features/arm/arm-vfpv3.c: Likewise.
  40         * features/arm/xscale-iwmmxt.c: Likewise.
  41         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  42
  43 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  44
  45         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  46         ptrace earlier.
  47
  48 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  49
  50         * features/aarch64-pauth.c: Regenerate.
  51
  52 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  53
  54         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  55         bool.
  56         (bpstat_what): Use false instead of 0.
  57
  58 2019-07-09  Pedro Alves  <palves@redhat.com>
  59
  60         * break-catch-throw.c (is_exception_catchpoint): New.
  61         * breakpoint.c (print_one_breakpoint_location): New parameter
  62         'raw_loc'.  Handle it.  Use
  63         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  64         looking at the breakpoint's type.
  65         (print_one_breakpoint): If handling "maint info breakpoints", also
  66         print locations of exception catchpoints.
  67         * breakpoint.h (is_exception_catchpoint): Declare.
  68
  69 2019-07-09  Pedro Alves  <palves@redhat.com>
  70
  71         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  72         "addr" field.
  73         (allocate_location_exception_catchpoint): New.
  74         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  75         (initialize_throw_catchpoint_ops): Install
  76         allocate_location_exception_catchpoint as allocate_location
  77         method.
  78         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  79         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  80         bp_loc_other.
  81         (breakpoint_address_is_meaningful): Delete.
  82         (bl_address_is_meaningful): New.
  83         (breakpoint_locations_match): Adjust comment.
  84         (bp_location_from_bp_type): New, factored out of...
  85         (bp_location::bp_location(breakpoint *)): ... this.
  86         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  87         factored out of...
  88         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  89         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  90         breakpoint_address_is_meaningful.
  91         (bp_locations_compare): Adjust comment.
  92         (update_global_location_list): Use bl_address_is_meaningful
  93         instead of breakpoint_address_is_meaningful.
  94         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  95         explicit.
  96         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  97         * python/py-breakpoint.c (bppy_get_location): No longer check
  98         whether location is null.
  99
 100 2019-07-09  Pedro Alves  <palves@redhat.com>
 101
 102         PR c++/15468
 103         * breakpoint.c (print_one_breakpoint_location): Remove
 104         single-location assert.
 105
 106 2019-07-09  Tom Tromey  <tom@tromey.com>
 107
 108         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 109         * configure: Rebuild.
 110         * configure.ac: Change common to gdbsupport.
 111         * gdbsupport: Rename from common.
 112         * acinclude.m4: Change common to gdbsupport.
 113         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 114         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 115         gdbsupport.
 116         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 117         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 118         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 119         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 120         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 121         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 122         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 123         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 124         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 125         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 126         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 127         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 128         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 129         coff-pe-read.c, command.h, compile/compile-c-support.c,
 130         compile/compile-c.h, compile/compile-cplus-symbols.c,
 131         compile/compile-cplus-types.c, compile/compile-cplus.h,
 132         compile/compile-loc2c.c, compile/compile.c, completer.c,
 133         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 134         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 135         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 136         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 137         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 138         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 139         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 140         features/aarch64-core.c, features/aarch64-fpu.c,
 141         features/aarch64-pauth.c, features/aarch64-sve.c,
 142         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 143         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 144         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 145         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 146         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 147         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 148         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 149         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 150         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 151         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 152         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 153         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 154         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 155         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 156         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 157         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 158         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 159         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 160         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 161         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 162         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 163         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 164         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 165         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 166         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 167         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 168         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 169         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 170         minsyms.c, mips-linux-tdep.c, namespace.h,
 171         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 172         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 173         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 174         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 175         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 176         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 177         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 178         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 179         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 180         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 181         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 182         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 183         procfs.c, producer.c, progspace.h, psymtab.h,
 184         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 185         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 186         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 187         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 188         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 189         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 190         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 191         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 192         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 193         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 194         target-memory.c, target.c, target.h, target/waitstatus.c,
 195         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 196         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 197         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 198         unittests/array-view-selftests.c,
 199         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 200         unittests/common-utils-selftests.c,
 201         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 202         unittests/format_pieces-selftests.c,
 203         unittests/function-view-selftests.c,
 204         unittests/lookup_name_info-selftests.c,
 205         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 206         unittests/mkdir-recursive-selftests.c,
 207         unittests/observable-selftests.c,
 208         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 209         unittests/parse-connection-spec-selftests.c,
 210         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 211         unittests/scoped_fd-selftests.c,
 212         unittests/scoped_mmap-selftests.c,
 213         unittests/scoped_restore-selftests.c,
 214         unittests/string_view-selftests.c, unittests/style-selftests.c,
 215         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 216         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 217         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 218         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 219         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 220         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 221
 222 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 223
 224         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 225         bool value.
 226         (decode_digits_ordinary): Set explicit_line field in sal.
 227         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 228         symtab_and_line that was set on an explicit line number in
 229         assembler code.  Do always update the recorded symtab and line if
 230         we do skip the prologue.
 231
 232 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * breakpoint.c (set_breakpoint_location_function): Remove
 235         explicit_loc parameter.
 236         (momentary_breakpoint_from_master): Update call to
 237         set_breakpoint_location_function.
 238         (add_location_to_breakpoint): Likewise.
 239
 240 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 241
 242         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 243         required features based on default bfd type when no specific bfd
 244         is present.
 245
 246 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 247
 248         * NEWS: Mention that GDB printf and eval commands can now print
 249         C-style and Ada-style convenience var strings without
 250         calling the inferior.
 251         * printcmd.c (printf_c_string): Locally print GDB internal var
 252         instead of transiting via the inferior.
 253         (printf_wide_c_string): Likewise.
 254
 255 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 256
 257         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 258
 259 2019-07-04  Tom Tromey  <tom@tromey.com>
 260
 261         PR tui/24724:
 262         * tui/tui-winsource.c (tui_clear_source_content): Update.
 263         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 264         (tui_update_breakpoint_info): Update.
 265         (tui_set_exec_info_content): Update.
 266         * tui/tui-source.c (tui_set_source_content_nil): Update.
 267         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 268         has_break.
 269         * tui/tui-data.h (enum tui_bp_flag): New.
 270         (tui_bp_flags): New enum flags type.
 271         (struct tui_source_element) <break_mode>: Change type.  Rename
 272         from has_break.
 273         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 274         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 275         constants.
 276         * tui/tui-winsource.h: Fix comment.
 277
 278 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 279
 280         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 281         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 282         (store_fpregs_to_thread)
 283         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 284         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 285         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 286         (IWMMXT_REGS_SIZE): Add define.
 287         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 288         (fetch_vfp_regs, store_vfp_regs)
 289         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 290         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 291
 292 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 295         defines.
 296         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 297         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 298         (ARM_INT_REGISTER_SIZE): ...to this.
 299         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 300         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 301         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 302         (arm_linux_collect_gregset, supply_nwfpe_register)
 303         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 304         defines.
 305         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 306         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 307         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 308         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 309         (arm_return_in_memory, arm_store_return_value)
 310         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 311         (arm_record_ld_st_multiple): Likewise.
 312         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 313         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 314
 315 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 316
 317         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 318         AARCH64_DISPLACED_MODIFIED_INSNS.
 319         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 320         (aarch64_displaced_step_copy_insn): Likewise.
 321         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 322         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 323         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 324         ARM_DISPLACED_MODIFIED_INSNS.
 325         * arm-tdep.c (arm_gdbarch_init): Likewise.
 326         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 327         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 328         (struct arm_displaced_step_closure): Use
 329         ARM_DISPLACED_MODIFIED_INSNS.
 330
 331 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 332
 333         * features/Makefile: Remove unused xml files.
 334         * features/aarch64.xml: Remove.
 335         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 336         * features/i386/amd64-avx-avx512.xml: Remove.
 337         * features/i386/amd64-avx-linux.xml: Remove.
 338         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 339         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 340         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 341         * features/i386/amd64-avx-mpx.xml: Remove.
 342         * features/i386/amd64-avx.xml: Remove.
 343         * features/i386/amd64-linux.xml: Remove.
 344         * features/i386/amd64-mpx-linux.xml: Remove.
 345         * features/i386/amd64-mpx.xml: Remove.
 346         * features/i386/amd64.xml: Remove.
 347         * features/i386/i386-avx-avx512-linux.xml: Remove.
 348         * features/i386/i386-avx-avx512.xml: Remove.
 349         * features/i386/i386-avx-linux.xml: Remove.
 350         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 351         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 352         * features/i386/i386-avx-mpx-linux.xml: Remove.
 353         * features/i386/i386-avx-mpx.xml: Remove.
 354         * features/i386/i386-avx.xml: Remove.
 355         * features/i386/i386-linux.xml: Remove.
 356         * features/i386/i386-mmx-linux.xml: Remove.
 357         * features/i386/i386-mmx.xml: Remove.
 358         * features/i386/i386-mpx-linux.xml: Remove.
 359         * features/i386/i386-mpx.xml: Remove.
 360         * features/i386/i386.xml: Remove.
 361         * features/i386/x32-avx-avx512-linux.xml: Remove.
 362         * features/i386/x32-avx-linux.xml: Remove.
 363         * features/i386/x32-linux.xml: Remove.
 364
 365 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 366
 367         * regformats/aarch64.dat: Remove.
 368         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 369         * regformats/i386/amd64-avx-linux.dat: Remove.
 370         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 371         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 372         * regformats/i386/amd64-linux.dat: Remove.
 373         * regformats/i386/amd64-mpx-linux.dat: Remove.
 374         * regformats/i386/amd64.dat: Remove.
 375         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 376         * regformats/i386/i386-avx-linux.dat: Remove.
 377         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 378         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 379         * regformats/i386/i386-linux.dat: Remove.
 380         * regformats/i386/i386-mmx-linux.dat: Remove.
 381         * regformats/i386/i386-mpx-linux.dat: Remove.
 382         * regformats/i386/i386.dat: Remove.
 383         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 384         * regformats/i386/x32-avx-linux.dat: Remove.
 385         * regformats/i386/x32-linux.dat: Remove.
 386
 387 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 388
 389         * aarch64-tdep.c: Remove xml self tests.
 390         * amd64-linux-tdep.c: Likewise.
 391         * amd64-tdep.c: Likewise.
 392         * i386-linux-tdep.c: Likewise.
 393         * i386-tdep.c: Likewise.
 394
 395 2019-07-03  Pedro Alves  <palves@redhat.com>
 396
 397         PR cli/24732
 398         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 399         (pipe_cmd_option_defs): New.
 400         (make_pipe_cmd_options_def_group): New.
 401         (pipe_command): Use gdb::option::process_options.
 402         (pipe_command_completer): New function.
 403         (_initialize_cli_cmds): Install completer for "pipe" command.
 404
 405 2019-07-03  Pedro Alves  <palves@redhat.com>
 406
 407         * cli/cli-option.c (union option_value) <string>: New field.
 408         (struct option_def_and_value): Add ctor, move ctor, dtor and
 409         use DISABLE_COPY_AND_ASSIGN.
 410         (option_def_and_value::clear_value): New.
 411         (parse_option, save_option_value_in_ctx, get_val_type_str)
 412         (add_setshow_cmds_for_options): Handle var_string.
 413         * cli-option.h (union option_def::var_address) <string>: New
 414         field.
 415         (struct string_option_def): New.
 416         * maint-test-options.c (struct test_options_opts): Add default
 417         ctor and use DISABLE_COPY_AND_ASSIGN.
 418         <string_opt>: New field.
 419         (test_options_opts::~test_options_opts): New.
 420         (test_options_opts::dump): Also dump "-string".
 421         (test_options_option_defs): Install "string.
 422
 423 2019-07-03  Pedro Alves  <palves@redhat.com>
 424
 425         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 426         option_value with a null enumeration.
 427         (complete_options): Save the option values in the context.
 428         (save_option_value_in_ctx): New, factored out from ...
 429         (process_options): ... here.
 430         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 431         of the function.
 432         * maint-test-options.c (test_options_opts::dump): New, factored
 433         out from ...
 434         (maintenance_test_options_command_mode): ... here.
 435         (maintenance_test_options_command_completion_result): Delete.
 436         (maintenance_test_options_command_completion_text): Update
 437         comment.
 438         (maintenance_show_test_options_completion_result): Change
 439         prototype.  Just print
 440         maintenance_test_options_command_completion_text.
 441         (save_completion_result): New.
 442         (maintenance_test_options_completer_mode): Pass options context to
 443         complete_options, and then save a dump.
 444         (_initialize_maint_test_options): Use add_cmd to install "maint
 445         show test-options-completion-result".
 446
 447 2019-07-03  Pedro Alves  <palves@redhat.com>
 448
 449         * NEWS (New commands): Mention "with" and "maint with".
 450         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 451         (with_command, with_command_completer): New.
 452         (pipe_command): Adjust to new repeat_previous
 453         interface.
 454         (_initialize_cli_cmds): Install the "with" command and its "w"
 455         alias.
 456         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 457         declarations.
 458         * cli/cli-setshow.c (parse_cli_var_uinteger)
 459         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 460         argument strings for all var_types.
 461         (get_setshow_command_value_string): New, factored out from ...
 462         (do_show_command): ... this.
 463         * cli/cli-setshow.h: Include <string>.
 464         (get_setshow_command_value_string): Declare.
 465         * command.h (repeat_previous): Now returns const char *.  Adjust
 466         comment.
 467         * maint.c: Include "cli/cli-cmds.h".
 468         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 469         (_initialize_maint_cmds): Register the "maintenance with" command.
 470         * top.c (repeat_previous): Move bits from pipe_command here:
 471         Return the saved command line, if any; error out if there's no
 472         command to relaunch.
 473
 474 2019-07-03  Pedro Alves  <palves@redhat.com>
 475
 476         * NEWS (New commands): Mention "maint set/show test-settings"
 477         instead of "maint test-settings".
 478         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 479         (maintenance_test_settings_set_list): Rename to ...
 480         (maintenance_set_test_settings_list): ... this.
 481         (maintenance_test_settings_show_list): Rename to  ...
 482         (maintenance_show_test_settings_list): ... this.
 483         (maintenance_test_settings_cmd): Delete.
 484         (maintenance_test_settings_set_cmd): ...
 485         (maintenance_set_test_settings_cmd): ... this.
 486         (maintenance_test_settings_show_cmd): ...
 487         (maintenance_show_test_settings_cmd): ... this.
 488         (maintenance_test_settings_show_value_cmd):
 489         (maintenance_show_test_settings_value_cmd): ... this.
 490         (_initialize_maint_test_settings): No longer install the "maint
 491         test-settings" prefix command.  Rename "maint test-settings set"
 492         to "maint set test-settings", and "maint test-settings show" to
 493         "maint show test-settings".  Adjust all subcommands.
 494
 495 2019-07-03  Pedro Alves  <palves@redhat.com>
 496
 497         * maint-test-settings.c: Fix file's intro comment.  Replace all
 498         references to "test-options" with references to "test-settings",
 499         in comments.
 500
 501 2019-07-03  Pedro Alves  <palves@redhat.com>
 502
 503         * maint-test-settings.c (maintenance_test_settings_xxx)
 504         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 505         New.
 506         (maintenance_test_settings_enums): Use them.
 507         (maintenance_test_settings_enum): Default to
 508         maintenance_test_settings_xxx.
 509         (_initialize_maint_test_settings): Initialize
 510         MAINTENANCE_TEST_SETTINGS_FILENAME.
 511
 512 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 513
 514         * breakpoint.h (remove_breakpoints_inf): Change return type to
 515         void, move function documentation here.
 516         * breakpoint.c (remove_breakpoints_inf): Change return type to
 517         void, move function documentation to header.
 518
 519 2019-07-02  Pedro Alves  <palves@redhat.com>
 520
 521         * NEWS (Completion improvements): Mention "info threads".
 522         * thread.c (struct info_threads_opts, info_threads_option_defs)
 523         (make_info_threads_options_def_group): New.
 524         (info_threads_command): Use gdb::option::process_options.
 525         (info_threads_command_completer): New.
 526         (_initialize_thread): Use gdb::option::build_help to build the
 527         help text for "info threads".
 528
 529 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 530
 531         * defs.h (generic_load): Move from here...
 532         * symfile.h (generic_load): ... to here.  Rename name parameter
 533         to args.
 534         * symfile.c (generic_load): Add comment.
 535
 536 2019-07-01  Tom Tromey  <tromey@adacore.com>
 537
 538         * dwarf2read.c
 539         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 540         declaration of without_params.  Fix formatting.
 541
 542 2019-07-01  Tom Tromey  <tromey@adacore.com>
 543
 544         * ada-exp.y (find_primitive_type): Update.
 545         * ada-lang.h (ada_lookup_symbol): Update.
 546         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 547         parameter.
 548         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 549
 550 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 551
 552         PR breakpoints/24541
 553         * gdbarch.c: Regenerate.
 554         * gdbarch.h: Regenerate.
 555         * gdbarch.sh: Add 'stap_adjust_register'.
 556         * i386-tdep.c: Include '<unordered_set>'.
 557         (i386_stap_adjust_register): New function.
 558         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 559         * stap-probe.c (stap_parse_register_operand): Call
 560         'gdbarch_stap_adjust_register'.
 561
 562 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 563
 564         PR python/24742
 565         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 566         * python/python.c (do_start_initialization): Use 'xmalloc'
 567         instead of 'PyMem_Malloc'.
 568
 569 2019-06-28  Tom Tromey  <tromey@adacore.com>
 570
 571         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 572         for Ada.
 573
 574 2019-06-27  Tom Tromey  <tromey@adacore.com>
 575
 576         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 577         objfile_key.
 578         (arm_find_mapping_symbol, arm_record_special_symbol)
 579         (_initialize_arm_tdep): Update.
 580         (arm_objfile_data_free): Remove.
 581
 582 2019-06-27  Tom Tromey  <tromey@adacore.com>
 583
 584         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 585         to cp_print_static_field.
 586
 587 2019-06-26  Tom Tromey  <tromey@adacore.com>
 588
 589         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 590         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 591         declare.
 592
 593 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 594
 595         * features/aarch64-core.c (create_feature_aarch64_core):
 596         Regenerate.
 597         * features/aarch64-core.xml: Add cpsr flags.
 598
 599 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 600
 601         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 602         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 603
 604 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 605
 606         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 607         field.
 608         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 609         use.
 610         (arm_record_special_symbol): Don't insert new symbol in sorted
 611         position, push it at the end.
 612
 613 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 614
 615         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 616         (arm_mapping_symbol_s): Remove.
 617         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 618         (arm_mapping_symbol_vec): New typedef.
 619         (struct arm_per_objfile): Add constructor.
 620         <section_maps>: Change type to
 621         std::unique_ptr<arm_mapping_symbol_vec[]>.
 622         (arm_compare_mapping_symbols): Remove.
 623         (arm_find_mapping_symbol): Adjust to section_maps type change.
 624         (arm_objfile_data_free): Call delete on arm_per_objfile.
 625         (arm_record_special_symbol): Adjust to section_maps type change.
 626         Allocate arm_per_objfile with new.
 627
 628 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 629
 630         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 631         with the command prefix.
 632
 633 2019-06-25  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 636         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 637
 638 2019-06-25  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 641         type.
 642         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 643         protected.
 644
 645 2019-06-25  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-winsource.c
 648         (tui_source_window_base::set_is_exec_point_at): Add check against
 649         LOA_ADDRESS.
 650
 651 2019-06-25  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-source.c (tui_set_source_content): Don't check before
 654         xfree.
 655         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 656
 657 2019-06-25  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-winsource.h (tui_update_source_window_as_is)
 660         (tui_alloc_source_buffer, tui_line_is_displayed)
 661         (tui_addr_is_displayed): Change type of win_info.
 662         * tui/tui-winsource.c (tui_update_source_window_as_is)
 663         (tui_clear_source_content, tui_show_source_line)
 664         (tui_show_source_content, tui_source_window_base::refill)
 665         (tui_source_window_base::set_is_exec_point_at)
 666         (tui_source_window_base::set_is_exec_point_at)
 667         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 668         (tui_alloc_source_buffer, tui_line_is_displayed)
 669         (tui_addr_is_displayed): Change type of win_info.  Update.
 670         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 671         (tui_source_window_base::do_make_visible_with_new_height):
 672         Update.
 673         * tui/tui-source.c (tui_set_source_content)
 674         (tui_set_source_content_nil)
 675         (tui_source_window::do_scroll_vertical): Update.
 676         * tui/tui-layout.c (show_layout): Update.
 677         * tui/tui-disasm.c (tui_set_disassem_content)
 678         (tui_disasm_window::do_scroll_vertical): Update.
 679         * tui/tui-data.h (tui_win_content): Remove.
 680         (struct tui_gen_win_info) <content, content_size>: Remove.
 681         (struct tui_source_element): Add initializers and destructor.
 682         (union tui_which_element, struct tui_win_element): Remove.
 683         (struct tui_source_window_base) <content>: New field.
 684         (struct tui_data_window): Remove destructor.
 685         (tui_alloc_content, tui_free_win_content)
 686         (tui_free_all_source_wins_content): Don't declare.
 687         * tui/tui-data.c (tui_initialize_static_data): Update.
 688         (init_content_element, tui_alloc_content): Remove.
 689         (~tui_gen_win_info): Update.
 690         (~tui_data_window, tui_free_all_source_wins_content)
 691         (tui_free_win_content, free_content, free_content_elements):
 692         Remove.
 693
 694 2019-06-25  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-winsource.h (tui_clear_source_content)
 697         (tui_erase_source_content, tui_show_source_content): Change type
 698         of win_info.
 699         * tui/tui-winsource.c (tui_clear_source_content)
 700         (tui_erase_source_content, tui_show_source_content): Change type
 701         of win_info.
 702         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 703         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 704         win_info.
 705         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 706         win_info.
 707         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 708
 709 2019-06-25  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-winsource.c (tui_clear_source_content)
 712         (tui_source_window_base::set_is_exec_point_at): Update.
 713         * tui/tui-source.c (tui_set_source_content_nil): Update.
 714         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 715         a bool.
 716         * tui/tui-data.c (init_content_element): Update.
 717
 718 2019-06-25  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 721         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 722         * tui/tui-layout.c (init_and_make_win): Update.
 723         * tui/tui.h (enum tui_win_type): Update.
 724         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 725         tui_win_is_auxillary.
 726         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 727         tui_win_is_auxillary.
 728
 729 2019-06-25  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 732         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 733         (tui_delete_data_content_windows, tui_display_all_data)
 734         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 735         Update.
 736         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 737         * tui/tui-regs.c (tui_last_regs_line_no)
 738         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 739         (tui_show_registers): Update.
 740         (tui_show_register_group): Return void.  Update.
 741         (tui_display_registers_from, tui_display_reg_element_at_line)
 742         (tui_display_registers_from_line, tui_check_register_values):
 743         Update.
 744         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 745         member.
 746         (struct tui_data_window) <regs_content>: Now a std::vector.
 747         <regs_content_count>: Remove.
 748         (tui_add_content_elements, tui_free_data_content): Don't declare.
 749         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 750         (init_content_element): Remove DATA_WIN case.  Add assert.
 751         (tui_add_content_elements): Remove.
 752         (tui_data_window): Update.
 753         (tui_free_data_content): Remove.
 754         (free_content_elements): Remove DATA_WIN case.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-data.c (tui_data_item_window): Update.
 759         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 760         * tui/tui-windata.c (tui_display_all_data)
 761         (tui_display_data_from_line): Update.
 762         (tui_check_data_values): Remove.
 763         * tui/tui-regs.c (tui_show_register_group)
 764         (tui_display_reg_element_at_line): Update.
 765         * tui/tui-hooks.c (tui_register_changed)
 766         (tui_refresh_frame_and_register_information): Call
 767         tui_check_register_values.
 768         * tui/tui-data.h (struct tui_data_window) <data_content,
 769         data_content_count, data_type>: Remove.
 770         (enum tui_data_type): Remove.
 771
 772         * tui/tui-data.c (tui_data_window::clear_detail)
 773         (~tui_data_window): Update.
 774
 775 2019-06-25  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 778         declare.
 779         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 780         Rename from tui_first_data_item_displayed.  Update.
 781         (tui_data_window::refresh_all)
 782         (tui_data_window::do_scroll_vertical): Update.
 783         * tui/tui-data.h (struct tui_data_window)
 784         <first_data_item_displayed>: Declare new method.
 785
 786 2019-06-25  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 789         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 790         contents...
 791         (tui_initialize_static_data): ...here.
 792
 793 2019-06-25  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 796         (tui_display_registers_from, tui_check_register_values): Update.
 797         (tui_display_register): Remove win_info parameter; update.
 798         (tui_get_register): Change type of parameters.
 799         * tui/tui-data.h (struct tui_data_element): Remove.
 800         (union tui_which_element) <data>: Remove.
 801         <data_window>: Change type.
 802         (struct tui_data_item_window): New.
 803         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 804         case.  Add assert.
 805         (~tui_data_item_window): New destructor.
 806         (free_content_elements): Remove DATA_ITEM_WIN case.
 807
 808 2019-06-25  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 811         Remove.
 812
 813 2019-06-25  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-data.h (struct tui_command_element): Remove.
 816         (union tui_which_element) <command>: Remove.
 817         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 818         assert.
 819         (free_content_elements): Remove CMD_WIN case.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-layout.c (tui_set_layout): Update.
 824         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 825         * tui/tui-data.c (layout_def): Update.
 826
 827 2019-06-25  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 830         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 831         (tui_source_window_base::set_new_height): Update.
 832         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 833         Update.
 834         (tui_set_locator_fullname, tui_set_locator_info)
 835         (tui_show_frame_info): Update.
 836         * tui/tui-source.c (tui_set_source_content)
 837         (tui_source_is_displayed): Update.
 838         * tui/tui-layout.c (show_source_disasm_command, show_data)
 839         (show_source_or_disasm_and_command): Update.
 840         * tui/tui-disasm.c (tui_set_disassem_content)
 841         (tui_get_begin_asm_address): Update.
 842         * tui/tui-data.h (struct tui_locator_element): Remove.
 843         (union tui_which_element) <locator>: Remove.
 844         (struct tui_locator_window): New.
 845         (tui_locator_win_info_ptr): Change return type.
 846         * tui/tui-data.c (_locator): Change type.
 847         (tui_locator_win_info_ptr): Change return type.
 848         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 849         (tui_alloc_content): Add assert.
 850
 851 2019-06-25  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.c
 854         (tui_exec_info_window::maybe_allocate_content): New method.
 855         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 856         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 857         (make_source_or_disasm_window): Add cast.
 858         * tui/tui-data.h (union tui_which_element) <simple_string>:
 859         Remove.
 860         (struct tui_source_info): New.
 861         (struct tui_source_window_base) <execution_info>: Change type.
 862         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 863         case, and add assert.
 864         (tui_alloc_content): Add assert.
 865
 866 2019-06-25  Tom Tromey  <tom@tromey.com>
 867
 868         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 869         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 870         * tui/tui-data.c (tui_alloc_win_info): Remove.
 871
 872 2019-06-25  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 875         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 876         can_highlight.
 877
 878 2019-06-25  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 881         make_visible_with_new_height method.
 882         (tui_win_info::make_visible_with_new_height): New method.
 883         (tui_source_window_base::do_make_visible_with_new_height)
 884         (tui_data_window::do_make_visible_with_new_height)
 885         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 886         (make_visible_with_new_height): Remove.
 887         (tui_resize_all, tui_adjust_win_heights): Use
 888         make_visible_with_new_height method.
 889         * tui/tui-data.h (struct tui_win_info)
 890         <do_make_visible_with_new_height, make_visible_with_new_height>:
 891         New methods.
 892         (struct tui_source_window_base, struct tui_data_window)
 893         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 894         methods.
 895
 896 2019-06-25  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 899         method.
 900         (update_tab_width): Call update_tab_width method.
 901         * tui/tui-data.h (struct tui_win_info)
 902         (struct tui_source_window_base) <update_tab_width>: New methods.
 903
 904 2019-06-25  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 907         parameter.
 908         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 909         parameter.
 910         (tui_gen_win_info::make_visible): Update.
 911         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 912         parameter.
 913         * tui/tui-data.h (enum tui_box): New enum.
 914         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 915
 916 2019-06-25  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 919         init_and_make_win for EXEC_INFO_WIN.
 920         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 921         longer inline.
 922         (struct tui_win_info) <~tui_win_info>: Inline.
 923         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 924         Don't declare.
 925         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 926         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 927         Remove.
 928         (tui_initialize_static_data): Update.
 929         (~tui_gen_win_info): Handle more cleanup here.
 930         (~tui_source_window_base): Delete "execution_info".
 931         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 932
 933 2019-06-25  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-layout.c (make_command_window): Don't set
 936         can_highlight.
 937         (show_source_disasm_command): Call the reset method.
 938         (show_data): Don't set can_highlight.  Call the reset method.
 939         (tui_gen_win_info::reset): Rename from init_gen_win_info
 940         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 941         (show_source_or_disasm_and_command): Call the reset method.
 942         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 943         (struct tui_cmd_window): Set can_highlight.
 944
 945 2019-06-25  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 948         from make_visible.
 949         (tui_make_visible, tui_make_invisible): Rewrite.
 950         (tui_win_info::make_visible): Remove.
 951         (tui_source_window_base::make_visible): Update.
 952         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 953         method.  Moved from...
 954         (struct tui_win_info) <make_visible>: ...here.
 955
 956 2019-06-25  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-winsource.c
 959         (tui_source_window_base::do_scroll_horizontal): Remove direction
 960         parameter.
 961         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 962         direction parameter.
 963         * tui/tui-win.c (tui_win_info::forward_scroll)
 964         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 965         (tui_win_info::right_scroll): Update.
 966         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 967         direction parameter.
 968         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 969         direction parameter.
 970         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 971         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 972         Remove direction parameter.
 973         (struct tui_source_window_base, struct tui_source_window)
 974         (struct tui_disasm_window, struct tui_data_window)
 975         (struct tui_cmd_window): Update.
 976
 977 2019-06-25  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-winsource.h (tui_set_exec_info_content)
 980         (tui_show_exec_info_content, tui_erase_exec_info_content)
 981         (tui_clear_exec_info_content, tui_update_exec_info): Change
 982         argument to tui_source_window_base.
 983         * tui/tui-winsource.c (tui_set_exec_info_content)
 984         (tui_show_exec_info_content, tui_erase_exec_info_content)
 985         (tui_clear_exec_info_content, tui_update_exec_info): Change
 986         argument to tui_source_window_base.
 987
 988 2019-06-25  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 991         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 992
 993 2019-06-25  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 996         check.
 997
 998 2019-06-25  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1001         type to void.
1002         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1003         type to void.
1004         * tui/tui-source.c (tui_set_source_content): Update.
1005         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1006
1007 2019-06-25  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-win.c (window_name_completer, tui_set_focus)
1010         (tui_all_windows_info): Use name method.
1011         * tui/tui-data.h (struct tui_gen_win_info)
1012         (struct tui_source_window, struct tui_disasm_window)
1013         (struct tui_data_window, struct tui_cmd_window) <name>: New
1014         method.
1015         (tui_win_name): Don't declare.
1016         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1017         (tui_win_name): Remove.
1018
1019 2019-06-25  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-winsource.h (tui_update_source_window)
1022         (tui_update_source_window_as_is): Change parameter type.
1023         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1024         to be a tui_source_window_base.
1025         (tui_update_source_window_as_is): Likewise.
1026         * tui/tui-win.c (make_visible_with_new_height): Update.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.c (tui_erase_source_content)
1031         (tui_show_source_content, tui_show_exec_info_content)
1032         (tui_erase_exec_info_content): Use refresh_window method.
1033         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1034         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1035         from tui_refresh_win.
1036         (tui_data_window::refresh_window): New method.
1037         (tui_win_info::refresh, tui_source_window_base::refresh)
1038         (tui_refresh_all): Use refresh_window method.
1039         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1040         method.
1041         * tui/tui-regs.c (tui_display_register): Call refresh_window
1042         method.
1043         * tui/tui-layout.c (show_source_disasm_command)
1044         (show_source_or_disasm_and_command): Call refresh_window method.
1045         * tui/tui-data.h (struct tui_gen_win_info)
1046         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1047         New method.
1048
1049 2019-06-25  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui.c (tui_rl_other_window, tui_enable)
1052         (tui_is_window_visible, tui_get_command_dimension): Update.
1053         * tui/tui-winsource.c (tui_update_source_window_as_is)
1054         (tui_clear_source_content, tui_erase_source_content)
1055         (tui_show_source_line, tui_source_window_base::refill)
1056         (tui_source_window_base::do_scroll_horizontal)
1057         (tui_source_window_base::set_is_exec_point_at)
1058         (tui_update_breakpoint_info, tui_set_exec_info_content)
1059         (tui_alloc_source_buffer, tui_line_is_displayed)
1060         (tui_addr_is_displayed): Update.
1061         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1062         (tui_check_and_display_highlight_if_needed)
1063         (tui_win_info::make_visible, tui_win_info::refresh)
1064         (tui_refresh_all): Update.
1065         * tui/tui-windata.c (tui_first_data_item_displayed)
1066         (tui_delete_data_content_windows, tui_erase_data_content)
1067         (tui_display_all_data, tui_data_window::refresh_all)
1068         (tui_check_data_values): Update.
1069         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1070         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1071         (tui_win_info::backward_scroll, tui_refresh_all_win)
1072         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1073         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1074         (tui_source_window_base::set_new_height)
1075         (tui_data_window::set_new_height)
1076         (make_invisible_and_set_new_height)
1077         (make_visible_with_new_height, new_height_ok)
1078         (parse_scrolling_args): Update.
1079         * tui/tui-stack.c (tui_show_frame_info): Update.
1080         * tui/tui-source.c (tui_set_source_content)
1081         (tui_set_source_content_nil, tui_source_is_displayed)
1082         (tui_source_window::do_scroll_vertical): Update.
1083         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1084         (tui_display_registers_from, tui_display_reg_element_at_line)
1085         (tui_check_register_values, tui_reg_command): Update.
1086         * tui/tui-layout.c (tui_default_win_height)
1087         (show_source_disasm_command, show_data, init_and_make_win)
1088         (show_source_or_disasm_and_command): Update.
1089         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1090         (tui_redisplay_readline, tui_mld_flush)
1091         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1092         (tui_getc): Update.
1093         * tui/tui-disasm.c (tui_set_disassem_content)
1094         (tui_disasm_window::do_scroll_vertical): Update.
1095         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1096         Now virtual.
1097         (struct tui_win_info): Derive from tui_gen_win_info.
1098         <~tui_win_info>: Mark as override.
1099         <generic>: Remove member.
1100         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1101         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1102         (~tui_data_window, ~tui_win_info)
1103         (tui_free_all_source_wins_content): Update.
1104         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1105
1106 2019-06-25  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-layout.c (init_and_make_win): Use new.
1109         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1110         destructor, initializers.
1111         (tui_alloc_generic_win_info): Don't declare.
1112         * tui/tui-data.c (_locator): Add argument to constructor.
1113         (source_win, disasm_win): New globals.
1114         (exec_info): Remove.
1115         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1116         Update.
1117         (tui_alloc_generic_win_info): Remove.
1118         (init_content_element): Use new.
1119         (tui_win_info::tui_win_info): Update.
1120         (free_content_elements) <case DATA_WIN>: Use delete.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1125         * tui/tui-windata.c (tui_first_data_item_displayed)
1126         (tui_delete_data_content_windows): Update.
1127         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1128         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1129         (tui_display_registers_from, tui_check_register_values): Update.
1130         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1131         pointer.
1132         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1133         window.
1134         (tui_free_data_content): Update.
1135         (free_content_elements) <case DATA_WIN>: Free the window.
1136
1137 2019-06-25  Tom Tromey  <tom@tromey.com>
1138
1139         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1140         Update.
1141         * tui/tui-layout.c (make_command_window)
1142         (show_source_disasm_command, show_data, init_and_make_win)
1143         (show_source_or_disasm_and_command): Update.
1144         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1145         method.
1146         <can_highight, is_highlighted>: Now bool.
1147         (tui_set_win_highlight): Don't declare.
1148         * tui/tui-data.c (tui_set_win_highlight): Remove.
1149
1150 2019-06-25  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-wingeneral.c (make_visible): Remove check of window
1153         type.
1154
1155 2019-06-25  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-win.c (tui_win_info::max_height)
1158         (tui_cmd_window::max_height): New methods.
1159         (new_height_ok): Call max_height.
1160         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1161         <max_height>: New method.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-win.c (tui_source_window_base::set_new_height)
1166         (tui_data_window::set_new_height): New methods.
1167         (make_invisible_and_set_new_height): Call set_new_height method.
1168         * tui/tui-data.h (struct tui_win_info)
1169         (struct tui_source_window_base, struct tui_data_window)
1170         <set_new_height>: New method.
1171
1172 2019-06-25  Tom Tromey  <tom@tromey.com>
1173
1174         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1175         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1176         tui_refresh_data_win.
1177         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1178         method.
1179         (tui_refresh_all_win): Call the refresh_all method.
1180         (tui_set_focus): Likewise.
1181         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1182         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1183         Likewise.
1184
1185 2019-06-25  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-winsource.h (tui_refill_source_window)
1188         (tui_set_is_exec_point_at): Don't declare.
1189         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1190         (tui_source_window_base::refill): Rename from
1191         tui_refill_source_window.
1192         (tui_source_window_base::do_scroll_horizontal): Update.
1193         (tui_source_window_base::set_is_exec_point_at): Rename from
1194         tui_set_is_exec_point_at.
1195         (tui_update_all_breakpoint_info): Update.
1196         * tui/tui-stack.c (tui_show_frame_info): Update.
1197         * tui/tui-layout.c (show_data): Add cast.
1198         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1199         * tui/tui-data.h (struct tui_source_window_base) <refill,
1200         set_is_exec_point_at>: New methods.
1201         (tui_source_windows, tui_add_to_source_windows): Update types.
1202         (tui_add_to_source_windows): Remove redundant declaration.
1203         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1204         (tui_source_windows): Change return type.
1205         (tui_clear_source_windows_detail): Update.
1206         (tui_add_to_source_windows): Change type of parameter.
1207         (tui_free_all_source_wins_content): Update.
1208
1209 2019-06-25  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-wingeneral.c (tui_win_info::refresh)
1212         (tui_source_window_base::refresh): New methods.
1213         (tui_refresh_all): Call the refresh method.
1214         * tui/tui-data.h (struct tui_win_info)
1215         (struct tui_source_window_base) <refresh>: New method.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui.h (tui_is_window_visible): Return bool.
1220         * tui/tui.c (tui_is_window_visible): Return bool.
1221         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1222         (tui_make_visible, tui_make_invisible)
1223         (tui_win_info::make_visible)
1224         (tui_source_window_base::make_visible, make_all_visible)
1225         (tui_make_all_visible, tui_make_all_invisible): Update.
1226         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1227         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1228         bool.
1229         (struct tui_win_info, struct tui_source_window_base)
1230         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1231         * tui/tui-data.c (tui_init_generic_part): Update.
1232
1233 2019-06-25  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1236         (tui_source_window_base::make_visible): New methods.
1237         (make_all_visible): Make method call.
1238         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1239         (struct tui_source_window_base, struct tui_cmd_window): Override
1240         make_visible.
1241         (tui_win_is_source_type): Don't declare.
1242         * tui/tui-data.c (tui_win_is_source_type): Remove.
1243
1244 2019-06-25  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1247         NULL check.
1248
1249 2019-06-25  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1252         Inline constructor.  Add initializers for members.
1253         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1254         constructors; now inline in class.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-regs.c (tui_show_registers): Update.
1259         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1260         bool.
1261         * tui/tui-data.c (tui_data_window::clear_detail)
1262         (tui_data_window): Update.
1263
1264 2019-06-25  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-windata.c (tui_display_all_data)
1267         (tui_display_data_from_line, tui_display_data_from)
1268         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1269         Update.
1270         * tui/tui-regs.c (tui_last_regs_line_no)
1271         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1272         (tui_show_registers, tui_show_register_group)
1273         (tui_display_registers_from, tui_display_reg_element_at_line)
1274         (tui_display_registers_from_line, tui_check_register_values)
1275         (tui_reg_next, tui_reg_prev): Update.
1276         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1277         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1278         tui_data_window.
1279         (struct tui_win_info) <detail>: Remove.  Add new fields from
1280         tui_data_info.
1281         (TUI_DATA_WIN): Add cast.
1282         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1283         (~tui_data_window): Simplify.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-layout.c (show_source_disasm_command)
1288         (show_source_or_disasm_and_command): Update.
1289         * tui/tui-io.c (update_cmdwin_start_line)
1290         (tui_redisplay_readline): Update.
1291         * tui/tui-data.h (struct tui_command_info): Remove.
1292         (struct tui_win_info) <detail>: Remove command_info member.
1293         (struct tui_data_window) <start_line>: New member, from
1294         tui_command_info.
1295         (TUI_CMD_WIN): Add casts.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-winsource.c (tui_update_source_window)
1300         (tui_refill_source_window)
1301         (tui_source_window_base::do_scroll_horizontal)
1302         (tui_update_breakpoint_info, tui_set_exec_info_content)
1303         (tui_show_exec_info_content, tui_erase_exec_info_content)
1304         (tui_clear_exec_info_content): Update.
1305         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1306         Update.
1307         * tui/tui-win.c (make_invisible_and_set_new_height)
1308         (make_visible_with_new_height): Update.
1309         * tui/tui-source.c (tui_set_source_content)
1310         (tui_show_symtab_source): Update.
1311         * tui/tui-layout.c (extract_display_start_addr)
1312         (show_source_disasm_command, show_data)
1313         (make_source_or_disasm_window)
1314         (show_source_or_disasm_and_command): Update.
1315         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1316         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1317         "gdbarch".
1318         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1319         to tui_source_window_base.
1320         (struct tui_win_info) <detail>: Remove source_info member.
1321         (struct tui_source_window_base) <has_locator>: Inline.
1322         Move contents from tui_source_info; rename has_locator member to
1323         m_has_locator.
1324         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1325         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1326         header file.
1327         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1328         Simplify.
1329         (tui_free_all_source_wins_content): Cast to
1330         tui_source_window_base.
1331
1332 2019-06-25  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-win.c (make_invisible_and_set_new_height)
1335         (make_visible_with_new_height): Call has_locator method.
1336         * tui/tui-layout.c (show_source_disasm_command, show_data)
1337         (show_source_or_disasm_and_command): Update for bool change.
1338         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1339         (tui_win_info) <has_locator>: New method.
1340         (struct tui_source_window_base) <has_locator>: New method.
1341         (tui_win_has_locator): Don't declare.
1342         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1343         from tui_win_has_locator.
1344         (tui_source_window_base): Use false, not FALSE.
1345
1346 2019-06-25  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1349         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1350         clear_detail method directly.
1351         (tui_clear_win_detail): Remove.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1356         "this", not TUI_DISASM_WIN.
1357
1358 2019-06-25  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1361         declare.
1362         * tui/tui-winsource.c
1363         (tui_source_window_base::do_scroll_horizontal): Rename from
1364         tui_horizontal_source_scroll.
1365         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1366         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1367         from tui_vertical_data_scroll.
1368         * tui/tui-win.h (tui_scroll): Don't declare.
1369         * tui/tui-win.c (tui_win_info::forward_scroll)
1370         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1371         (tui_win_info::right_scroll): Rename and update.
1372         (tui_scroll_forward_command, tui_scroll_backward_command)
1373         (tui_scroll_left_command, tui_scroll_right_command): Update.
1374         (tui_scroll): Remove.
1375         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1376         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1377         from tui_vertical_source_scroll.
1378         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1379         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1380         from tui_vertical_disassem_scroll.
1381         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1382         do_scroll_horizontal>: New methods.
1383         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1384         Likewise.
1385         (struct tui_source_window_base): Add do_scroll_horizontal.
1386         (struct tui_source_window, struct tui_disasm_window): Add
1387         do_scroll_vertical.
1388         (struct tui_data_window, struct tui_cmd_window): Add
1389         do_scroll_horizontal and do_scroll_vertical.
1390         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1391
1392 2019-06-25  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui-data.h (struct tui_source_window_base): New struct.
1395         (struct tui_source_window): Derive from tui_source_window_base.
1396         (struct tui_disasm_window): New struct.
1397         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1398         from tui_source_window::clear_detail.
1399         (tui_source_window_base): Rename from tui_source_window.
1400         (~tui_source_window_base): Rename from ~tui_source_window.
1401         (tui_alloc_win_info): Create a tui_disasm_window.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-data.h (struct tui_source_window)
1406         (struct tui_data_window): Declare destructors.
1407         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1408         destructors.
1409         (tui_win_info): Simplify.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-winsource.c (tui_display_main)
1414         (tui_update_source_windows_with_addr)
1415         (tui_update_all_breakpoint_info): Update.
1416         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1417         (new_height_ok, parse_scrolling_args): Update.
1418         * tui/tui-stack.c (tui_show_frame_info): Update.
1419         * tui/tui-data.h (struct tui_list): Remove.
1420         (tui_source_windows): Return a reference to a std::vector.
1421         * tui/tui-data.c (source_windows): Now a std::vector.
1422         (tui_source_windows): Change return type.
1423         (tui_clear_source_windows): Rewrite.
1424         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1425         (tui_free_all_source_wins_content): Rewrite.
1426
1427 2019-06-25  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1430         (struct tui_data_window, struct tui_cmd_window): Declare
1431         clear_detail method.
1432         * tui/tui-data.c (tui_source_window::clear_detail)
1433         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1434         methods.
1435         (tui_clear_win_detail): Simplify.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.c (make_source_window, make_disasm_window)
1440         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1441         Return the new window.
1442         (show_source_disasm_command, show_data)
1443         (show_source_or_disasm_and_command): Update.
1444
1445 2019-06-25  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1448         parameter.  Return the new window.
1449         (show_source_disasm_command): Update and remove NULL check.
1450         (show_source_or_disasm_and_command): Update.
1451
1452 2019-06-25  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1455
1456 2019-06-25  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-data.h (struct tui_win_info): Make constructor
1459         protected.  Make destructor virtual.  Add initializers.
1460         (tui_source_window, tui_data_window, tui_cmd_window): New
1461         classes.
1462         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1463         constructor.  Add "type" parameter.
1464         (tui_source_window, tui_data_window, tui_cmd_window): New
1465         constructors.
1466         (tui_alloc_win_info): Instantiate the appropriate subclass.
1467
1468 2019-06-25  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-win.c (tui_resize_all): Use delete.
1471         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1472         destructor.
1473         (tui_free_window): Don't declare.
1474         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1475         Update.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-data.h (struct tui_win_info): Add constructor.
1480         * tui/tui-data.c (tui_alloc_win_info): Use new.
1481         (tui_free_window): Use delete.
1482
1483 2019-06-22  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1486         declare.
1487         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1488
1489 2019-06-22  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1492         declare.
1493         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1494
1495 2019-06-22  Tom de Vries  <tdevries@suse.de>
1496
1497         * dwarf2read.c (create_addrmap_from_aranges)
1498         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1499         instead of '%zu'.
1500
1501 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1502
1503         * dwarf2read.h (dwarf2_section_info_def): Remove.
1504         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1505         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1506         std::vector<dwarf2_section_info>.
1507         (struct dwo_file) <~dwo_file>: Remove.
1508         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1509         types field.
1510         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1511         (dwarf2_read_debug_names): Likewise.
1512         (create_debug_types_hash_table): Change parameter type to
1513         array_view, adjust code accordingly.
1514         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1515         (partial_die_info::fixup): Likewise.
1516         (determine_prefix): Likewise.
1517         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1518
1519 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1520
1521         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1522         gdb_bfd_ref_ptr.
1523         <~dwo_file>: Remove call to gdb_bfd_unref.
1524         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1525         gdb_bfd_ref_ptr::get.
1526
1527 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1528
1529         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1530         type to htab_up.
1531         * dwarf2read.c (struct dwo_file): Initialize fields.
1532         <~dwo_file>: New.
1533         (free_dwo_file): Remove, move content to ~dwo_file.
1534         (struct dwo_file_deleter): Remove.
1535         (dwo_file_up>: Remove custom deleter.
1536         (free_dwo_files): Remove.
1537         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1538         dwo_files.
1539         (process_skeletonless_type_units): Call unique_ptr::get.
1540         (allocate_dwo_file_hash_table): Add deleter to created hash
1541         table.  Change return type to htab_up.
1542         (lookup_dwo_file_slot): Don't memset dwo_file, call
1543         unique_ptr::get.
1544         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1545         (create_dwo_unit_in_dwp_v2): Likewise.
1546         (open_and_init_dwo_file): Likewise.
1547         (free_dwo_file_from_slot): Remove.
1548
1549 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1550
1551         * dwarf2read.h (struct dwarf2_section_info) <readin,
1552         is_virtual>: Change type to bool.
1553         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1554         true instead of 1.
1555
1556 2019-06-19  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-data.h (tui_init_content_element): Don't declare.
1559
1560 2019-06-19  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-data.h (tui_init_win_info): Don't declare.
1563
1564 2019-06-19  Tom de Vries  <tdevries@suse.de>
1565
1566         * dwarf2read.h (abstract_to_concrete): Change type to
1567         std::unordered_map<sect_offset, std::vector<sect_offset>,
1568         gdb::hash_enum<sect_offset>>.
1569
1570 2019-06-19  Tom Tromey  <tromey@adacore.com>
1571
1572         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1573         EVAL_AVOID_SIDE_EFFECTS specially.
1574
1575 2019-06-19  Tom Tromey  <tromey@adacore.com>
1576
1577         * source-cache.c (highlighter): New global.
1578         (source_cache::get_source_lines): Create a highlighter on demand.
1579
1580 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * defs.h (deprecated_interactive_hook): Delete declaration.
1583         * interps.c (clear_interpreter_hooks): Remove use of
1584         deprecated_interactive_hook.
1585         * top.c (deprecated_interactive_hook): Delete definition.
1586         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1587
1588 2019-06-18  Tom de Vries  <tdevries@suse.de>
1589
1590         PR gdb/24515
1591         * dwarf2read.h (abstract_to_concrete): Change type from
1592         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1593         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1594         * dwarf2read.c (read_variable): Update.
1595         (dwarf2_fetch_die_loc_sect_off): Update.
1596
1597 2019-06-17  Tom de Vries  <tdevries@suse.de>
1598
1599         PR gdb/24617
1600         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1601         accessing parent[parent_len - 1].
1602
1603 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1604
1605         PR gdb/24364
1606         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1607         call dtrace_process_dof with NULL dof.
1608
1609 2019-06-16  Tom de Vries  <tdevries@suse.de>
1610
1611         PR gdb/24445
1612         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1613
1614 2019-06-16  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1617         (make_all_visible): Use address of member.
1618
1619 2019-06-16  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1622         (tui_free_window, free_content, free_content_elements): Remove
1623         unnecessary cast.
1624         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1625         cast.
1626         * tui/tui-regs.c (tui_show_register_group)
1627         (tui_display_registers_from, tui_display_reg_element_at_line):
1628         Remove unnecessary cast.
1629
1630 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1631
1632         * linux-nat.c (normal_mask): Delete.
1633         (_initialize_linux_nat): Don't initialise normal_mask.
1634
1635 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1636
1637         PR gdb/24445
1638         * dwarf-index-write.h (write_psymtabs_to_index): Add
1639         dwz_basename parameter.
1640         * dwarf-index-write.c (write_gdbindex): Move file writing to
1641         write_gdbindex_1.  Change return type void.
1642         (assert_file_size): Move up, remove filename parameter.
1643         (write_gdbindex_1): New function.
1644         (write_debug_names): Change return type to void, call
1645         assert_file_size.
1646         (struct index_wip_file): New struct.
1647         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1648         file logic to index_wip_file.  Write index for dwz file if
1649         needed.
1650         (save_gdb_index_command): Pass basename of dwz file, if present.
1651         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1652         build-id of dwz file, if present.
1653         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1654         (dwarf2_get_dwz_file): Likewise.
1655         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1656         (dwarf2_get_dwz_file): Likewise.
1657
1658 2019-06-16  Tom Tromey  <tom@tromey.com>
1659
1660         * coffread.c (process_coff_symbol): Use xstrdup.
1661         * value.c (create_internalvar): Use xstrdup.
1662
1663 2019-06-16  Tom Tromey  <tom@tromey.com>
1664
1665         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1666         * breakpoint.c (stopin_command, stopat_command)
1667         (until_break_command, decode_location_default): Remove unnecessary
1668         cast.
1669         * utils.c (subset_compare): Remove unnecessary cast.
1670         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1671         cast.
1672         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1673         cast.
1674         * infcmd.c (path_command): Remove unnecessary cast.
1675         * coffread.c (decode_type): Remove unnecessary cast.
1676         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1677         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1678         * tui/tui-stack.c (tui_show_locator_content)
1679         (tui_show_frame_info): Remove unnecessary cast.
1680         * tui/tui-win.c (tui_scroll_forward_command)
1681         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1682         (parse_scrolling_args): Remove unnecessary cast.
1683         * tui/tui-data.c (init_win_info, tui_del_window)
1684         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1685         (free_content_elements): Remove unnecessary cast.
1686         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1687         unnecessary cast.
1688         * tui/tui-source.c (tui_set_source_content)
1689         (tui_vertical_source_scroll): Remove unnecessary cast.
1690         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1691         cast.
1692         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1693         * tui/tui-regs.c (tui_display_registers_from)
1694         (tui_display_register): Remove unnecessary cast.
1695         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1696         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1697         (make_visible): Remove unnecessary cast.
1698         * tui/tui-winsource.c (tui_erase_source_content)
1699         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1700         unnecessary cast.
1701         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1702         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1703         * stabsread.c (read_type, read_array_type, read_range_type):
1704         Remove unnecessary cast.
1705         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1706         (parse_symbol, parse_type, upgrade_type, parse_external)
1707         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1708         unnecessary cast.
1709         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1710
1711 2019-06-16  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-data.c (tui_alloc_generic_win_info)
1714         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1715         checks.
1716
1717 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1718             Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * f-typeprint.c (f_print_type): Don't return early for not
1721         associated or not allocated types.
1722         (f_type_print_varspec_suffix): Add print_rank parameter and print
1723         ranks of array types in case they dangling.
1724         (f_type_print_base): Add print_rank parameter.
1725
1726 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * NEWS: Mention new MI commands.
1729         * break-catch-throw.c (enum exception_event_kind): Move to
1730         breakpoint.h.
1731         (print_mention_exception_catchpoint): Output text as a single
1732         message.
1733         (catch_exception_command_1): Rename to...
1734         (catch_exception_event): ...this, make non-static, update header
1735         command, and change some parameter types.
1736         (catch_catch_command): Update for changes to
1737         catch_exception_command_1.
1738         (catch_throw_command): Likewise.
1739         (catch_rethrow_command): Likewise.
1740         * breakpoint.c (enum exception_event_kind): Delete.
1741         * breakpoint.h (enum exception_event_kind): Moved here from
1742         break-catch-throw.c.
1743         (catch_exception_event): Declare.
1744         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1745         (mi_cmd_catch_throw): New function.
1746         (mi_cmd_catch_rethrow): New function.
1747         (mi_cmd_catch_catch): New function.
1748         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1749         'catch-catch' entries.
1750         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1751         (mi_cmd_catch_rethrow): Declare.
1752         (mi_cmd_catch_catch): Declare.
1753
1754 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1755
1756         * annotate.c (annotate_source_line): Change return type to void,
1757         update implementation to match.
1758         * annotate.h (annotate_source_line): Change return type to void,
1759         update header comment.
1760         * stack.c (print_frame_info): Don't change what frame information
1761         is printed based on whether annotations are on or not.
1762
1763 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1764
1765         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1766         (annotate_source): Make static.
1767         (annotate_source_line): Moved from source.c and renamed from
1768         identify_source_line.  Update the return type.
1769         * annotate.h (annotate_source): Delete declaration.
1770         (annotate_source_line): Declaration moved from source.h, and
1771         renamed from identify_source_line.  Return type updated.
1772         * source.c (identify_source_line): Moved to annotate.c and renamed
1773         to annotate_source_line.
1774         (info_line_command): Remove check of annotation_level.
1775         * source.h (identify_source_line): Move declaration to annotate.h
1776         and rename to annotate_source_line.
1777         * stack.c: Add 'annotate.h' include.
1778         (print_frame_info): Remove check of annotation_level before
1779         calling annotate_source_line.
1780
1781 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1782
1783         * source-cache.c (source_cache::get_plain_source_lines): Use
1784         open_source_file_with_line_charpos instead of just
1785         open_source_file, remove call to find_source_lines.
1786         (source_cache::get_source_lines): Likewise.
1787         * source.c (find_source_lines): Make static.
1788         (get_filename_and_charpos): Renamed into...
1789         (open_source_file_with_line_charpos): ..this along with changes to
1790         return a scoped_fd, and some other minor clean ups.
1791         (identify_source_line): Use open_source_file_with_line_charpos.
1792         (search_command_helper): Use open_source_file_with_line_charpos
1793         instead of just open_source_file, remove call to
1794         find_source_lines.
1795         * source.h (open_source_file_with_line_charpos): Declare new
1796         function.
1797         (find_source_lines): Delete declaration.
1798
1799 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1800
1801         * source.c (get_filename_and_charpos): Remove fullname
1802         parameter.
1803         (identify_source_line): Update call to get_filename_and_charpos.
1804
1805 2019-06-14  Tom Tromey  <tromey@adacore.com>
1806
1807         PR gdb/24502:
1808         * ui-style.h (skip_ansi_escape): Update comment.
1809         * ui-file.h (class no_terminal_escape_file): New class.
1810         * ui-file.c (no_terminal_escape_file::write)
1811         (no_terminal_escape_file::puts): New methods.
1812         * cli/cli-logging.c (handle_redirections): Use
1813         no_terminal_escape_file.
1814
1815 2019-06-14  Tom Tromey  <tromey@adacore.com>
1816
1817         * NEWS: Move convenience variable news above Python news.
1818
1819 2019-06-14  Tom Tromey  <tom@tromey.com>
1820
1821         * gnulib: Move directory to top-level.
1822         * configure.ac: Don't configure gnulib.
1823         * configure: Rebuild.
1824         * common/common-defs.h: Use new path to gnulib.
1825         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1826         (GNULIB_H): Remove.
1827         (INCGNU): Look in new gnulib location.
1828         (HFILES_NO_SRCDIR): Remove gnulib files.
1829         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1830         (generated_files): Remove GNULIB_H.
1831         ($(LIBGNU), all-lib): Remove targets.
1832         (distclean): Don't mention GNULIB_BUILDDIR.
1833         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1834
1835 2019-06-14  Tom Tromey  <tromey@adacore.com>
1836
1837         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1838         Warn if symbol file does not provide any symbols.
1839
1840 2019-06-14  Tom Tromey  <tromey@adacore.com>
1841
1842         * source.c (find_and_open_source): Respect basenames_may_differ.
1843
1844 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * annotate.c (annotate_breakpoints_invalid): Make use of
1847         scoped_restore_terminal_state.
1848         (annotate_frames_invalid): Likewise.
1849
1850 2019-06-14  Tom Tromey  <tromey@adacore.com>
1851
1852         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1853         allow assignment to an internalvar.
1854
1855 2019-06-14  Tom Tromey  <tromey@adacore.com>
1856
1857         * ada-lex.l: Allow "_" in attribute names.
1858
1859 2019-06-14  Tom Tromey  <tromey@adacore.com>
1860
1861         PR gdb/24653:
1862         * regcache.c (registers_changed): Don't call alloca.
1863         * top.c (execute_command): Don't call alloca.
1864
1865 2019-06-13  Pedro Alves  <palves@redhat.com>
1866
1867         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1868         'expression'.  When parsing an expression, error out if there's
1869         junk after "unlimited".
1870         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1871         (do_set_command): Adjust calls to is_unlimited_literal.
1872
1873 2019-06-13  Pedro Alves  <palves@redhat.com>
1874
1875         * compile/compile.c (make_compile_options_def_group): Add braces
1876         around array_view initializer.
1877         * thread.c (make_thread_apply_all_options_def_group)
1878         (make_thread_apply_all_options_def_group): Likewise.
1879
1880 2019-06-13  Pedro Alves  <palves@redhat.com>
1881
1882         * NEWS (New commands): Mention "maint test-options
1883         require-delimiter", "maint test-options unknown-is-error", "maint
1884         test-options unknown-is-operand" and "maint show
1885         test-options-completion-result".
1886         (New command options, command completion): New section.
1887         (Completion improvements): New section.
1888         Mention that you can abbreviate "unlimited".
1889
1890 2019-06-13  Pedro Alves  <palves@redhat.com>
1891
1892         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1893         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1894         * unittests/cli-utils-selftests.c (test_parse_flags)
1895         (test_parse_flags_qcs): Delete.
1896         (test_cli_utils): Don't call deleted functions.
1897
1898 2019-06-13  Pedro Alves  <palves@redhat.com>
1899
1900         * thread.c: Include "cli/cli-option.h".
1901         (tp_array_compar_ascending): Global.
1902         (tp_array_compar): Delete function.
1903         (tp_array_compar_ascending, tp_array_compar_descending): New
1904         functions.
1905         (ascending_option_def, qcs_flag_option_def)
1906         (thr_qcs_flags_option_defs)
1907         (make_thread_apply_all_options_def_group)
1908         (make_thread_apply_options_def_group): New.
1909         (thread_apply_all_command): Use gdb::option::process_options.
1910         (thread_apply_command_completer)
1911         (thread_apply_all_command_completer): New.
1912         (thread_apply_command): Use gdb::option::process_options.
1913         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1914         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1915         to generate help text of "thread apply".  Adjust "taas"'s help.
1916         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1917         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1918
1919 2019-06-13  Pedro Alves  <palves@redhat.com>
1920
1921         * thread.c (thread_apply_command): Check for invalid TID with
1922         isdigit instead of !isalpha.
1923
1924 2019-06-13  Pedro Alves  <palves@redhat.com>
1925
1926         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1927         (validate_flags_qcs): New.
1928         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1929         (validate_flags_qcs): Declare.
1930         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1931         (make_frame_apply_options_def_group): New.
1932         (frame_apply_command_count): Process options with
1933         gdb::option::process_options.
1934         (frame_apply_completer): New.
1935         (frame_apply_level_completer, frame_apply_all_completer)
1936         (frame_apply_completer): New.
1937         (_initialize_stack): Update help of "frame apply", "frame apply
1938         level", "frame apply all" and "faas" to mention supported options
1939         and install command completers.
1940         * stack.h (frame_apply_all_completer): Declare.
1941         * thread.c: Include "stack.h".
1942         (tfaas_command): Add "--".
1943         (_initialize_thread): Update help "tfaas" to mention supported
1944         options and install command completer.
1945
1946 2019-06-13  Pedro Alves  <palves@redhat.com>
1947
1948         * completer.c (complete_nested_command_line): New.
1949         (gdb_completion_word_break_characters_throw): Add assertion.
1950         * completer.h (complete_nested_command_line): Declare.
1951
1952 2019-06-13  Pedro Alves  <palves@redhat.com>
1953
1954         * stack.c (parse_backtrace_qualifiers): New.
1955         (backtrace_command): Use it.
1956         (backtrace_command_completer): Complete on qualifiers.
1957
1958 2019-06-13  Pedro Alves  <palves@redhat.com>
1959
1960         * frame.c: Include "cli/cli-option.h.
1961         (user_set_backtrace_options): New.
1962         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1963         Delete.
1964         (get_prev_frame): Adjust.
1965         (boolean_option_def, uinteger_option_def)
1966         (set_backtrace_option_defs): New.
1967         (_initialize_frame): Adjust and use
1968         gdb::option::add_setshow_cmds_for_options to install "set
1969         backtrace past-main" and "set backtrace past-entry".
1970         * frame.h: Include "cli/cli-option.h".
1971         (struct frame_print_options): Forward declare.
1972         (print_frame_arguments_all, print_frame_arguments_scalars)
1973         (print_frame_arguments_none): Declare.
1974         (print_entry_values): Delete declaration.
1975         (struct frame_print_options, user_frame_print_options): New.
1976         (struct set_backtrace_options): New.
1977         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1978         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1979         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1980         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1981         (list_args_or_locals): Add frame_print_options parameter.
1982         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1983         * python/py-framefilter.c (enumerate_args): Pass down
1984         USER_FRAME_PRINT_OPTIONS.
1985         * stack.c: Include "cli/cli-option.h".
1986         (print_frame_arguments_all, print_frame_arguments_scalars)
1987         (print_frame_arguments_none): Declare.
1988         (print_raw_frame_arguments, print_entry_values): Delete.
1989         (user_frame_print_options): New.
1990         (boolean_option_def, enum_option_def, frame_print_option_defs):
1991         New.
1992         (struct backtrace_cmd_options): New.
1993         (bt_flag_option_def): New.
1994         (backtrace_command_option_defs): New.
1995         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1996         (print_frame_arg, read_frame_arg, print_frame_args)
1997         (print_frame_info, print_frame): Add frame_print_options parameter
1998         and use it.
1999         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2000         (backtrace_command_1): Add frame_print_options and
2001         backtrace_cmd_options parameters and use them.
2002         (make_backtrace_options_def_group): New.
2003         (backtrace_command): Process command options with
2004         gdb::option::process_options.
2005         (backtrace_command_completer): New.
2006         (_initialize_stack): Extend "backtrace"'s help to mention
2007         supported options.  Install completer for "backtrace".
2008         Install some settings commands with add_setshow_cmds_for_options.
2009
2010 2019-06-13  Pedro Alves  <palves@redhat.com>
2011
2012         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2013         and that "set/show print raw frame-arguments" are now deprecated.
2014
2015         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2016         command.
2017         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2018         * stack.c (_initialize_stack): Install "set/show print
2019         raw-frame-arguments", and deprecate "set/show print raw
2020         frame-arguments".
2021         * valprint.c (_initialize_valprint): Deprecate "set/show print
2022         raw".
2023
2024 2019-06-13  Pedro Alves  <palves@redhat.com>
2025
2026         * compile/compile.c (struct compile_options): New.
2027         (compile_flag_option_def, compile_command_option_defs)
2028         (make_compile_options_def_group): New.
2029         (compile_file_command): Handle options with
2030         gdb::option::process_options.
2031         (compile_file_command_completer): New function.
2032         (compile_code_command): Handle options with
2033         gdb::option::process_options.
2034         (compile_code_command_completer): New function.
2035         (_initialize_compiler): Install completers for "compile code" and
2036         "compile file".  Mention available options in "compile code" and
2037         "compile code"'s help.
2038         * completer.c (advance_to_completion_word): New, factored out from
2039         ...
2040         (advance_to_expression_complete_word_point): ... this.
2041         (advance_to_filename_complete_word_point): New.
2042         * completer.h (advance_to_filename_complete_word_point): New
2043         declaration.
2044
2045 2019-06-13  Pedro Alves  <palves@redhat.com>
2046
2047         * compile/compile.c: Include "cli/cli-option.h".
2048         (compile_print_value): Scope data pointer is now a
2049         value_print_options pointer; adjust.
2050         (compile_print_command): Process options.  Scope data pointer is
2051         now a value_print_options pointer; adjust.
2052         (_initialize_compile): Update "compile print"'s help to include
2053         supported options.  Install a completer for "compile print".
2054         * cp-valprint.c (show_vtblprint, show_objectprint)
2055         (show_static_field_print): Delete.
2056         (_initialize_cp_valprint): Don't install "set print
2057         static-members", "set print vtbl", "set print object" here.
2058         * printcmd.c: Include "cli/cli-option.h" and
2059         "common/gdb_optional.h".
2060         (print_command_parse_format): Rework to fill in a
2061         value_print_options instead of a format_data.
2062         (print_value): Change parameter type from format_data pointer to
2063         value_print_options reference.  Adjust.
2064         (print_command_1): Process options.  Adjust to pass down a
2065         value_print_options.
2066         (print_command_completer): New.
2067         (_initialize_printcmd): Install print_command_completer as
2068         handle_brkchars completer for the "print" command.  Update
2069         "print"'s help to include supported options.
2070         * valprint.c: Include "cli/cli-option.h".
2071         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2072         here from cp-valprint.c.
2073         (boolean_option_def, uinteger_option_def)
2074         (value_print_option_defs, make_value_print_options_def_group):
2075         New.  Use gdb::option::add_setshow_cmds_for_options to install
2076         "set print elements", "set print null-stop", "set print repeats",
2077         "set print pretty", "set print union", "set print array", "set
2078         print address", "set print symbol", "set print array-indexes".
2079         * valprint.h: Include <string> and "cli/cli-option.h".
2080         (make_value_print_options_def_group): Declare.
2081         (print_value): Change parameter type from format_data pointer to
2082         value_print_options reference.
2083         (print_command_completer): Declare.
2084
2085 2019-06-13  Pedro Alves  <palves@redhat.com>
2086
2087         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2088         (COMMON_SFILES): Add maint-test-settings.c.
2089         * cli/cli-decode.c (boolean_enums): New global, factored out from
2090         ...
2091         (add_setshow_boolean_cmd): ... here.
2092         * cli/cli-decode.h (boolean_enums): Declare.
2093         * cli/cli-option.c: New file.
2094         * cli/cli-option.h: New file.
2095         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2096         factored out from ...
2097         (parse_cli_boolean_value(const char *)): ... this.
2098         (is_unlimited_literal): Change parameter type to pointer to
2099         pointer.  Adjust and advance ARG pointer.
2100         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2101         (parse_cli_var_enum): New, factored out from ...
2102         (do_set_command): ... this.  Adjust.
2103         * cli/cli-setshow.h (parse_cli_boolean_value)
2104         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2105         (parse_cli_var_enum): Declare.
2106         * cli/cli-utils.c: Include "cli/cli-option.h".
2107         (get_ulongest): New.
2108         * cli/cli-utils.h (get_ulongest): Declare.
2109         (check_for_argument): New overloads.
2110         * maint-test-options.c: New file.
2111
2112 2019-06-13  Pedro Alves  <palves@redhat.com>
2113
2114         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2115         parse a range if "-" is at the end of the string.
2116
2117 2019-06-13  Pedro Alves  <palves@redhat.com>
2118
2119         * cli/cli-setshow.c (parse_auto_binary_operation)
2120         (parse_cli_boolean_value): Don't allow "o".
2121
2122 2019-06-13  Pedro Alves  <palves@redhat.com>
2123
2124         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2125         * NEWS: Mention maint test-settings KIND.
2126         * maint-test-settings.c: New file.
2127
2128 2019-06-13  Pedro Alves  <palves@redhat.com>
2129
2130         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2131         completer.
2132         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2133         "set" completers.
2134
2135 2019-06-13  Pedro Alves  <palves@redhat.com>
2136
2137         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2138         after item.
2139
2140 2019-06-13  Pedro Alves  <palves@redhat.com>
2141
2142         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2143
2144 2019-06-13  Pedro Alves <palves@redhat.com>
2145
2146         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2147         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2148         call.
2149         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2150         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2151         calls.
2152         (check_for_argument): Skip spaces after argument.
2153
2154 2019-06-13  Pedro Alves  <palves@redhat.com>
2155
2156         * thread.c (thread_apply_command): Adjust TID parsing.
2157         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2158         detected before end of string.
2159         (tid_is_in_list): Error out if LIST is invalid.
2160
2161 2019-06-13  Pedro Alves  <palves@redhat.com>
2162
2163         * completer.c (complete_line_internal_1): Rewind completion word
2164         point.
2165         (completion_tracker::advance_custom_word_point_by): Change
2166         parameter type to int.
2167         * completer.h (completion_tracker::advance_custom_word_point_by):
2168         Likewise.
2169
2170 2019-06-13  Pedro Alves  <palves@redhat.com>
2171
2172         * completer.c (advance_to_completion_word): Handle delimiters.
2173
2174 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2175
2176         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2177
2178 2019-06-11  Tom Tromey  <tom@tromey.com>
2179
2180         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2181         (xmalloc_failed): Move to alloc.c.
2182         * alloc.c: New file.
2183         * Makefile.in (COMMON_SFILES): Add alloc.c.
2184
2185 2019-06-11  Tom Tromey  <tom@tromey.com>
2186
2187         * nat/linux-waitpid.c: Don't include server.h.
2188         (linux_debug): Remove.
2189         (my_waitpid): Update.
2190
2191 2019-06-11  Tom Tromey  <tromey@adacore.com>
2192
2193         * infcall.c (_initialize_infcall): Remove trailing newline from
2194         help.
2195         * user-regs.c (_initialize_user_regs): Remove trailing newline
2196         from help.
2197         * typeprint.c (_initialize_typeprint): Remove trailing newline
2198         from help.
2199         * reverse.c (_initialize_reverse): Remove trailing newlines from
2200         help.
2201         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2202         from help.
2203         * language.c (add_set_language_command): Remove trailing newline
2204         from help.
2205         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2206         help.
2207         * disasm.c (_initialize_disasm): Remove trailing newline from
2208         help.
2209         * top.c (init_main): Remove trailing newline from help.
2210         * interps.c (_initialize_interpreter): Remove trailing newline
2211         from help.
2212         * btrace.c (_initialize_btrace): Remove trailing newlines from
2213         help.
2214         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2215         from help.
2216         * python/python.c (_initialize_python): Remove trailing newline
2217         from help.
2218         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2219         help.
2220         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2221         from help.  Reformat some text.
2222         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2223         from help.
2224         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2225         newline from help.
2226
2227 2019-06-11  Tom Tromey  <tromey@adacore.com>
2228
2229         * darwin-nat.c (darwin_decode_exception_message)
2230         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2231
2232 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * valops.c (value_slice): Check for not allocated or not
2235         associated values.
2236
2237 2019-06-10  Tom de Vries  <tdevries@suse.de>
2238
2239         PR gdb/24618
2240         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2241         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2242         invalid.
2243
2244 2019-06-10  Tom de Vries  <tdevries@suse.de>
2245
2246         PR gdb/24611
2247         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2248         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2249
2250 2019-06-10  Tom de Vries  <tdevries@suse.de>
2251
2252         PR symtab/24545
2253         * symtab.c (struct demangled_name_entry): Add language field.
2254         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2255         static minimal symbol".  Set and use language field.
2256
2257 2019-06-10  Tom Tromey  <tromey@adacore.com>
2258
2259         * ada-lang.c (_initialize_ada_language): Update help text.
2260
2261 2019-06-10  Tom Tromey  <tromey@adacore.com>
2262
2263         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2264         with a newline.
2265         * guile/guile.c (handle_boot_error): Don't end warning with a
2266         newline.
2267         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2268         warning with a newline.
2269         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2270         newline.
2271         (s12z_frame_cache): Likewise.
2272         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2273         a newline.
2274         * solib-svr4.c (disable_probes_interface): Don't end warning with
2275         a newline.
2276         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2277         newline.
2278         * python/python.c (do_finish_initialization): Don't end warning
2279         with a newline.
2280
2281 2019-06-10  Tom Tromey  <tom@tromey.com>
2282
2283         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2284         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2285         gdbpy_enter.
2286
2287 2019-06-10  Tom Tromey  <tromey@adacore.com>
2288
2289         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2290         data.
2291         (elf_new_init): Don't call stabsread_new_init.
2292         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2293         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2294         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2295
2296 2019-06-10  Tom de Vries  <tdevries@suse.de>
2297
2298         PR symtab/16264
2299         PR symtab/24517
2300         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2301
2302 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2303
2304         * source.c (find_and_open_source): Also rewrite relative file
2305         names.
2306
2307 2019-04-26  Amos Bird  <amosbird@gmail.com>
2308
2309         * annotate.c (annotate_thread_exited): Add "thread-exited"
2310         annotation.
2311
2312 2019-06-06  Tom Tromey  <tromey@adacore.com>
2313
2314         * maint.h (class scoped_command_stats): Use
2315         DISABLE_COPY_AND_ASSIGN.
2316         <print_time>: New method.
2317         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2318         print_time.
2319         (scoped_command_stats::print_time): New method.
2320
2321 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2324         instructions of lengths 6 or 8 bytes.
2325
2326 2019-06-04  Pedro Alves  <palves@redhat.com>
2327
2328         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2329
2330         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2331         * breakpoint.c (condition_completer): Likewise.
2332         * cli/cli-dump.c (scan_expression): Likewise.
2333         * common/filestuff.c (mkdir_recursive): Likewise.
2334         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2335         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2336         (gdb_abspath): Likewise.
2337         * compile/compile-cplus-types.c
2338         (compile_cplus_instance::decl_name): Likewise.
2339         * completer.c (complete_explicit_location):
2340         (signal_completer, reg_or_group_completer_1): Likewise.
2341         * cp-support.c (cp_remove_params_if_any): Likewise.
2342         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2343         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2344         * infcmd.c (strip_bg_char): Likewise.
2345         * linespec.c (copy_token_string): Likewise.
2346         * mi/mi-main.c (output_cores): Likewise.
2347         * psymtab.c (psymtab_search_name):
2348         * symfile.c (test_set_ext_lang_command): Likewise.
2349         * target.c (target_fileio_read_stralloc): Likewise.
2350         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2351         * value.c (complete_internalvar): Likewise.
2352
2353 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2354
2355         Add objfile property to gdb.Type.
2356         * NEWS: Mention Python API addition.
2357         * python/py-type.c (typy_get_objfile): New method.
2358
2359 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * NEWS: Mention the new set|show style [title|highlight].
2362         Mention changes to "show style", "help" and "apropos".
2363
2364 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2367         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2368         instead of print_help_for_command.
2369         (print_doc_of_command): New function.
2370         (help_list): Add 'apropos -v word' suggestion.
2371         (print_help_for_command): Style the command name using title style.
2372         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2373         (_initialize_cli_cmds): Describe -v in apropos_command help.
2374
2375 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2376
2377         * cli/cli-style.h (cli_style_option): Add name in constructor,
2378         add m_name class member, add constructor with intensity,
2379         add name class function.
2380         (cli_style_option::add_setshow_commands): Remove name argument.
2381         (highlight_style, title_style): New styles.
2382         * cli/cli-style.c (do_show): New function that shows a style
2383         characteristic styling the style name with itself.
2384         (set_style_name): New function.
2385         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2386         Update all callers according to the changes in cli/cli-style.h.
2387         * utils.h (fputs_highlighted): New function.
2388         * utils.c (fputs_highlighted): Likewise.
2389
2390 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2391
2392         * NEWS: Mention new pipe command and new convenience variables.
2393
2394 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2395
2396         * cli/cli-cmds.c (pipe_command): New function.
2397         (_initialize_cli_cmds): Call add_com for pipe_command.
2398         Define | as an alias for pipe.
2399         (exit_status_set_internal_vars): New function.
2400         (shell_escape): Call exit_status_set_internal_vars.
2401         cli/cli-decode.c (find_command_name_length): Recognize | as
2402         a single character command.
2403
2404 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2405
2406         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2407         top.c (execute_command_to_ui_file): New function, mostly a copy
2408         of execute_command_to_string.
2409         (execute_command_to_string): Implement by calling
2410         execute_command_to_ui_file.
2411
2412 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2413
2414         * top.h (saved_command_line): Remove declaration.
2415         * top.c (previous_saved_command_line, previous_repeat_arguments):
2416         New variables.
2417         (saved_command_line): Make static, define together with other
2418         'repeat variables'.
2419         (dont_repeat): Clear repeat_arguments.
2420         (repeat_previous, get_saved_command_line, save_command_line):
2421         New functions.
2422         (gdb_init): Initialize saved_command_line
2423         and previous_saved_command_line.
2424         * main.c (captured_main_1): Remove saved_command_line initialization.
2425         * event-top.c (handle_line_of_input): Update to use
2426         the new 'repeat' related functions instead of direct access to
2427         saved_command_line.
2428         * command.h (repeat_previous, get_saved_command_line,
2429         save_command_line): New declarations.
2430         (dont_repeat): Add comment.
2431
2432 2019-05-30  Tom Tromey  <tromey@adacore.com>
2433
2434         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2435         Fix comment.
2436         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2437
2438 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2439
2440         PR cli/24587
2441         * completer.c (complete): Initialize variable word.
2442
2443 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2444
2445         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2446         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2447         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2448         'body' is NULL to the outter 'if', protecting the '!is_define'
2449         situation as well.
2450
2451 2019-05-29  Tom Tromey  <tromey@adacore.com>
2452
2453         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2454         (dwarf_unknown): New function.
2455         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2456         (dwarf_type_encoding_name): Use dwarf_unknown.
2457
2458 2019-05-29  Tom Tromey  <tromey@adacore.com>
2459
2460         PR c++/20020:
2461         * cp-valprint.c (cp_print_value_fields): Call
2462         cp_print_static_field inside "try".
2463
2464 2019-05-29  Tom Tromey  <tromey@adacore.com>
2465
2466         * inflow.c (struct terminal_info): Add default operator=.
2467         * configure: Rebuild.
2468         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2469         -Wdeprecated-copy-dtor, -Wredundant-move.
2470
2471 2019-05-29  Tom Tromey  <tromey@adacore.com>
2472
2473         * NEWS: Add entry.
2474         * infcmd.c (print_return_value_1): Handle finish_print
2475         option.
2476         (show_print_finish): New function.
2477         (_initialize_infcmd): Add "set/show print finish" commands.
2478         * valprint.c (user_print_options): Initialize new member.
2479         * valprint.h (struct value_print_options) <finish_print>: New
2480         member.
2481
2482 2019-05-28  Tom Tromey  <tromey@adacore.com>
2483
2484         * ada-lang.c (ada_remove_Xbn_suffix)
2485         (find_old_style_renaming_symbol)
2486         (parse_old_style_renaming): Remove.
2487         (ada_find_renaming_symbol): Don't call
2488         find_old_style_renaming_symbol.
2489         (ada_is_renaming_symbol): Rename from
2490         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2491         bool.  Now static.
2492         (ada_read_var_value): Update and simplify.
2493         * ada-exp.y (write_var_or_type): Remove old code.
2494
2495 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2496
2497         * event-top.c: Remove include comment.
2498         * inflow.c (class scoped_ignore_sigttou): Move from here...
2499         * inflow.h (class scoped_ignore_sigttou): ...to here.
2500         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2501         * top.c:  Remove include comment.
2502
2503 2019-05-27  Tom Tromey  <tom@tromey.com>
2504
2505         * NEWS: Fix typo.
2506
2507 2019-05-22  Tom Tromey  <tromey@adacore.com>
2508
2509         * target.c (target_follow_exec): Constify parameter.
2510         * target-delegates.c: Rebuild.
2511         * remote.c (remote_target::follow_exec): Constify parameter.
2512         * infrun.c (follow_exec): Constify parameter.
2513         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2514         (target_follow_exec): Likewise.
2515
2516 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2517
2518         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2519         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2520
2521 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2522
2523         * NEWS: Add debugredirect and testsuite sections.
2524
2525 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2526
2527         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2528         target descriptions using exclusively floating point register name
2529         aliases.
2530
2531 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         PR gdb/18644:
2534         * f-lang.c (build_fortran_types): Handle the case where
2535         gdbarch_floatformat_for_type returns a nullptr.
2536
2537 2019-05-21  Tom de Vries  <tdevries@suse.de>
2538
2539         PR cli/24587
2540         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2541
2542 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         PR gdb/18644:
2545         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2546         16-byte floats.
2547         * i386-tdep.c (i386_floatformat_for_type): Use
2548         floatformats_ia64_quad for the 16-byte floating point component
2549         within a fortran 32-byte complex number.
2550
2551 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2554         delete default constructor.
2555         (find_partial_die): Update to return const struct.
2556         (partial_die_parent_scope): Move variable declaration into scope
2557         of its use and change its type to auto.
2558         (guess_partial_die_structure_name): Likewise.
2559         (partial_die_info::fixup): Likewise.
2560
2561 2019-05-17  Tom Tromey  <tromey@adacore.com>
2562
2563         * source.c (find_and_open_source): Remove cast.
2564
2565 2019-05-17  Tom Tromey  <tromey@adacore.com>
2566
2567         * annotate.c (annotate_source): Make "filename" const.
2568         * annotate.h (annotate_source): Use const.
2569
2570 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2571
2572         * disasm.c (set_disassembler_options): Send errors to stderr.
2573
2574 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2575
2576         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2577         (cli_interp_base::set_logging): Check debug_redirect.
2578         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2579         * cli/cli-logging.c (debug_redirect): Add static variable.
2580         (pop_output_files): Add default param.
2581         (handle_redirections): Print debug setting.
2582         (show_logging_command): Likewise.
2583         (_initialize_cli_logging): Add debugredirect command.
2584         * interps.c (current_interp_set_logging): Add debug_redirect
2585         parameter.
2586         * interps.h (set_logging): Add debug_redirect parameter.
2587         (current_interp_set_logging): Likewise.
2588         * mi/mi-common.h: Likewise.
2589         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2590
2591 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2592             Tom Tromey  <tromey@adacore.com>
2593
2594         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2595         directly.
2596         * cli/cli-interp.h (make_logging_output): Remove declaration.
2597         * cli/cli-logging.c (make_logging_output): Remove function.
2598         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2599         directly.
2600         * ui-file.c (tee_file::tee_file): Remove bools.
2601         (tee_file::~tee_file): Remove deletes.
2602         * ui-file.h (tee_file): Remove bools.
2603
2604 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2605
2606         * mi/mi-cmds.h (mi_cmd_complete): New function.
2607         * mi/mi-main.c (mi_cmd_complete): Likewise.
2608         * mi/mi-cmds.c: Define new MI command -complete.
2609         * NEWS: Mention new -complete command.
2610
2611 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2612
2613         * completer.h (complete): New function.
2614         * completer.c (complete): Likewise.
2615         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2616         function defined in completer.h.
2617
2618 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2619
2620         * MAINTAINERS (Write After Approval): Add myself.
2621
2622 2019-05-17  Tom de Vries  <tdevries@suse.de>
2623
2624         PR gdb/24094
2625         * dwarf2read.c (struct cu_partial_die_info): New struct.
2626         (find_partial_die): Return cu_partial_die_info.
2627         (partial_die_parent_scope, guess_partial_die_structure_name)
2628         (partial_die_info::fixup): Handle new return type of find_partial_die.
2629
2630 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2631
2632         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2633         "std::string", simplifying the algorithm.
2634
2635 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2636
2637         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2638         (stap_static_probe_ops::get_probes): Likewise.
2639
2640 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2641
2642         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2643         '-')" and "else if".
2644         (stap_parse_single_operand): Join checks for
2645         "gdbarch_stap_parse_special_token_p" and
2646         "gdbarch_stap_parse_special_token" in the same "if" statement.
2647         Invert check when verifying for operation on register
2648         displacement.
2649
2650 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2651
2652         * stap-probe.c (stap_get_opcode): Update comment.
2653         (stap_get_expected_argument_type): Likewise.
2654         (handle_stap_probe): Likewise.
2655
2656 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2657
2658         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2659         return type to 'bool'.  Adjust comment.  Use 'bool' when
2660         appropriate.
2661         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2662         * stap-probe.c (stap_parse_argument_1): Likewise.
2663         (stap_is_operator): Likewise.
2664         (stap_is_generic_prefix): Likewise.
2665         (stap_is_register_prefix): Likewise.
2666         (stap_is_register_indirection_prefix): Likewise.
2667         (stap_is_integer_prefix): Likewise.
2668         (stap_generic_check_suffix): Likewise.
2669         (stap_check_integer_suffix): Likewise.
2670         (stap_check_register_suffix): Likewise.
2671         (stap_check_register_indirection_suffix): Likewise.
2672         (stap_parse_register_operand): Likewise.
2673         (stap_parse_single_operand): Likewise.
2674         (stap_parse_argument_1): Likewise.
2675         (stap_probe::get_argument_count): Likewise.
2676         (stap_is_operator): Likewise.
2677
2678 2019-05-16  Tom Tromey  <tromey@adacore.com>
2679
2680         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2681         keyword to foreach.
2682
2683 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2684
2685         * linux-thread-db.c (try_thread_db_load_1): Change return type
2686         to bool.
2687         (try_thread_db_load): Likewise.
2688         (try_thread_db_load_from_pdir_1): Likewise.
2689         (try_thread_db_load_from_pdir): Likewise.
2690         (try_thread_db_load_from_sdir): Likewise.
2691         (try_thread_db_load_from_dir): Likewise.
2692         (thread_db_load_search): Likewise.
2693         (has_libpthread): Likewise.
2694         (thread_db_load): Likewise.
2695
2696 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2697
2698         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2699         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2700         NULL, and complain/return if that's the case.
2701
2702 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2703
2704         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2705         (advance, posn, abstract_read_memory): New functions.
2706         [struct mem_read_abstraction]: New struct.
2707         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2708
2709 2019-05-14  Tom Tromey  <tromey@adacore.com>
2710
2711         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2712         value is not lval_memory.
2713
2714 2019-05-14  Tom Tromey  <tromey@adacore.com>
2715
2716         * solib.c (info_sharedlibrary_command): Style the file name.
2717
2718 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2719
2720         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2721         (aarch64_vnv_type): Likewise.
2722         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2723         * common/tdesc.c: Likewise.
2724         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2725         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2726         * features/aarch64-fpu.xml: Add ieee half view.
2727         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2728         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2729         * gdbtypes.h (struct builtin_type): Likewise.
2730         (struct objfile_type): Likewise.
2731
2732 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2733
2734         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2735         typo.
2736         * location.h (string_to_event_location): Likewise.
2737
2738 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2739
2740         GDB 8.3 released.
2741
2742 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2743
2744         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2745         New variable declaration.
2746         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2747         New variable.
2748         (print_one_breakpoint): Use ui_out::test_flags and new global
2749         variable to compute use_fixed_output.
2750         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2751         Remove.
2752         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2753         (mi_multi_location_breakpoint_output_fixed): Remove.
2754         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2755         new variable.
2756         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2757         fix_multi_location_breakpoint_output flag if version >= 3.
2758         * ui-out.h (enum ui_out_flag)
2759         <fix_multi_location_breakpoint_output>: New enumerator.
2760
2761 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2762
2763         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2764
2765 2019-05-10  Tom Tromey  <tromey@adacore.com>
2766
2767         * ada-lang.c (catch_ada_completer): New function.
2768         (_initialize_ada_language): Use it.
2769
2770 2019-05-10  Tom Tromey  <tromey@adacore.com>
2771
2772         * thread.c (print_thread_info): Make "requested_threads" const.
2773         * gdbthread.h (print_thread_info): Make "requested_threads"
2774         const.
2775         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2776         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2777
2778 2019-05-08  Tom Tromey  <tom@tromey.com>
2779
2780         * gdbtypes.c (objfile_type_data): Change type.
2781         (objfile_type, _initialize_gdbtypes): Update.
2782
2783 2019-05-08  Tom Tromey  <tom@tromey.com>
2784
2785         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2786         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2787         (_initialize_dwarf2_frame): Update.
2788
2789 2019-05-08  Tom Tromey  <tom@tromey.com>
2790
2791         * objc-lang.c (objc_objfile_data): Change type.
2792         (find_methods): Update.
2793         (_initialize_objc_lang): Remove.
2794
2795 2019-05-08  Tom Tromey  <tom@tromey.com>
2796
2797         * stabsread.c (rs6000_builtin_type_data): Change type.
2798         (rs6000_builtin_type, _initialize_stabsread): Update.
2799
2800 2019-05-08  Tom Tromey  <tom@tromey.com>
2801
2802         * mips-tdep.c (mips_pdr_data): Remove.
2803         (_initialize_mips_tdep): Update.
2804
2805 2019-05-08  Tom Tromey  <tom@tromey.com>
2806
2807         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2808         (hppa_init_objfile_priv_data, read_unwind_info)
2809         (find_unwind_entry, _initialize_hppa_tdep): Update.
2810
2811 2019-05-08  Tom Tromey  <tom@tromey.com>
2812
2813         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2814         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2815         on obstack.
2816         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2817
2818 2019-05-08  Tom Tromey  <tom@tromey.com>
2819
2820         * mdebugread.c (basic_type_data): Change type.
2821         (basic_type, _initialize_mdebugread): Update.
2822
2823 2019-05-08  Tom Tromey  <tom@tromey.com>
2824
2825         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2826
2827 2019-05-08  Tom Tromey  <tom@tromey.com>
2828
2829         * nto-tdep.c (nto_inferior_data_reg): Change type.
2830         (nto_inferior_data): Update.
2831         (nto_inferior_data_cleanup, nto_new_inferior_data)
2832         (_initialize_nto_tdep): Remove.
2833         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2834
2835 2019-05-08  Tom Tromey  <tom@tromey.com>
2836
2837         * ada-lang.c (struct ada_inferior_data): Add initializers.
2838         (ada_inferior_data): Change type.
2839         (ada_inferior_data_cleanup): Remove.
2840         (get_ada_inferior_data, ada_inferior_exit)
2841         (struct ada_pspace_data): Add initializers, destructor.
2842         (ada_pspace_data_handle): Change type.
2843         (get_ada_pspace_data): Update.
2844         (ada_pspace_data_cleanup): Remove.
2845
2846 2019-05-08  Tom Tromey  <tom@tromey.com>
2847
2848         * coffread.c (struct coff_symfile_info): Add initializers.
2849         (coff_objfile_data_key): Move lower.  Change type.
2850         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2851         Update.
2852         (coff_free_info): Remove.
2853
2854 2019-05-08  Tom Tromey  <tom@tromey.com>
2855
2856         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2857         (fbsd_pspace_data_handle): Move lower.  Change type.
2858         (get_fbsd_pspace_data): Update.
2859         (fbsd_pspace_data_cleanup): Remove.
2860         (_initialize_fbsd_tdep): Update.
2861
2862 2019-05-08  Tom Tromey  <tom@tromey.com>
2863
2864         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2865         (get_ada_tasks_pspace_data): Update.
2866         (ada_tasks_pspace_data_cleanup): Remove.
2867         (_initialize_tasks): Update.
2868         (ada_tasks_inferior_data_handle): Change type.
2869         (get_ada_tasks_inferior_data): Update.
2870         (ada_tasks_inferior_data_cleanup): Remove.
2871         (struct ada_tasks_pspace_data): Add initializers.
2872
2873 2019-05-08  Tom Tromey  <tom@tromey.com>
2874
2875         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2876         * symfile-debug.c (debug_sym_get_probes): Change type.
2877         * stap-probe.c (handle_stap_probe):
2878         (stap_static_probe_ops::get_probes): Change type.
2879         * probe.h (class static_probe_ops) <get_probes>: Change type.
2880         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2881         (parse_probes_in_pspace): Update.
2882         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2883         Update.
2884         (any_static_probe_ops::get_probes): Change type.
2885         * elfread.c (elfread_data): New typedef.
2886         (probe_key): Change type.
2887         (elf_get_probes): Likewise.  Update.
2888         (probe_key_free): Remove.
2889         (_initialize_elfread): Update.
2890         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2891         Change type.
2892         (dtrace_process_dof_probe, dtrace_process_dof)
2893         (dtrace_static_probe_ops::get_probe): Change type.
2894
2895 2019-05-08  Tom Tromey  <tom@tromey.com>
2896
2897         * xcoffread.c (struct xcoff_symfile_info): Rename from
2898         coff_symfile_info.  Add initializers.
2899         (xcoff_objfile_data_key): Move lower.  Change type.
2900         (XCOFF_DATA): Rewrite.
2901         (xcoff_free_info): Remove.
2902         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2903         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2904         (xcoff_initial_scan): Update.
2905
2906 2019-05-08  Tom Tromey  <tom@tromey.com>
2907
2908         * solib-svr4.c (struct svr4_info): Add initializers and
2909         destructor.
2910         <probes_table>: Now an htab_up.
2911         (solib_svr4_pspace_data): Change type.
2912         (free_probes_table): Simplify.
2913         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2914         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2915         (probes_table_remove_objfile_probes, register_solib_event_probe)
2916         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2917         (_initialize_svr4_solib): Update.
2918
2919 2019-05-08  Tom Tromey  <tom@tromey.com>
2920
2921         * remote.c (remote_pspace_data): Change type.
2922         (remote_pspace_data_cleanup): Remove.
2923         (get_remote_exec_file, set_pspace_remote_exec_file)
2924         (_initialize_remote): Update.
2925
2926 2019-05-08  Tom Tromey  <tom@tromey.com>
2927
2928         * breakpoint.c (breakpoint_objfile_key): Change type.
2929         (get_breakpoint_objfile_data): Update.
2930         (free_breakpoint_objfile_data): Remove.
2931         (_initialize_breakpoint): Update.
2932
2933 2019-05-08  Tom Tromey  <tom@tromey.com>
2934
2935         * linux-tdep.c (struct linux_info): Add initializers.
2936         (linux_inferior_data): Move.  Change type.
2937         (invalidate_linux_cache_inf): Update.
2938         (linux_inferior_data_cleanup): Remove.
2939         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2940
2941 2019-05-08  Tom Tromey  <tom@tromey.com>
2942
2943         * auxv.c (auxv_inferior_data): Move.  Change type.
2944         (auxv_inferior_data_cleanup): Remove.
2945         (invalidate_auxv_cache_inf): Rewrite.
2946         (get_auxv_inferior_data, _initialize_auxv): Update.
2947
2948 2019-05-08  Tom Tromey  <tom@tromey.com>
2949
2950         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2951         (symfile_debug_objfile_data_key): Change type.
2952         (symfile_debug_installed, debug_qf_has_symbols)
2953         (debug_qf_find_last_source_symtab)
2954         (debug_qf_forget_cached_source_info)
2955         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2956         (debug_qf_print_stats, debug_qf_dump)
2957         (debug_qf_expand_symtabs_for_function)
2958         (debug_qf_expand_all_symtabs)
2959         (debug_qf_expand_symtabs_with_fullname)
2960         (debug_qf_map_matching_symbols)
2961         (debug_qf_expand_symtabs_matching)
2962         (debug_qf_find_pc_sect_compunit_symtab)
2963         (debug_qf_map_symbol_filenames)
2964         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2965         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2966         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2967         (debug_sym_read_linetable, debug_sym_relocate): Update.
2968         (symfile_debug_free_objfile): Remove.
2969         (install_symfile_debug_logging, _initialize_symfile_debug):
2970         Update.
2971
2972 2019-05-08  Tom Tromey  <tom@tromey.com>
2973
2974         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2975         allocate_on_obstack.
2976         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2977         (get_dwarf2_per_objfile): Update.
2978         (set_dwarf2_per_objfile): Remove.
2979         (dwarf2_has_info, dwarf2_get_section_info): Update.
2980         (dwarf2_free_objfile): Remove.
2981         (_initialize_dwarf2_read): Update.
2982
2983 2019-05-08  Tom Tromey  <tom@tromey.com>
2984
2985         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2986         initializers.
2987         <unsupported_script_warning_printed,
2988         script_not_found_warning_printed>: Now bool.
2989         (auto_load_pspace_data): Change type.
2990         (~auto_load_pspace_info): Rename from
2991         auto_load_pspace_data_cleanup.
2992         (get_auto_load_pspace_data, init_loaded_scripts_info)
2993         (clear_section_scripts, maybe_print_unsupported_script_warning)
2994         (maybe_print_script_not_found_warning, _initialize_auto_load):
2995         Update.
2996
2997 2019-05-08  Tom Tromey  <tom@tromey.com>
2998
2999         * objfiles.c (objfile_pspace_info): Add destructor and
3000         initializers.
3001         (objfiles_pspace_data): Change type.
3002         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3003         (get_objfile_pspace_data): Update.
3004         (objfiles_bfd_data): Change type.
3005         (get_objfile_bfd_data): Update.
3006         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3007
3008 2019-05-08  Tom Tromey  <tom@tromey.com>
3009
3010         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3011         Change type.
3012         (get_catch_syscall_inferior_data): Update.
3013         (catch_syscall_inferior_data_cleanup): Remove.
3014         (_initialize_break_catch_syscall): Update.
3015
3016 2019-05-08  Tom Tromey  <tom@tromey.com>
3017
3018         * inflow.c (struct terminal_info): Add destructor and
3019         initializers.
3020         (inflow_inferior_data): Change type.
3021         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3022         (get_inflow_inferior_data, inflow_inferior_exit)
3023         (swap_terminal_info, _initialize_inflow): Update.
3024
3025 2019-05-08  Tom Tromey  <tom@tromey.com>
3026
3027         * target-dcache.c (target_dcache_cleanup): Remove.
3028         (target_dcache_aspace_key): Change type.
3029         (target_dcache_init_p, target_dcache_invalidate)
3030         (target_dcache_get, target_dcache_get_or_init)
3031         (_initialize_target_dcache): Update.
3032         * dcache.h (struct dcache_deleter): New.
3033
3034 2019-05-08  Tom Tromey  <tom@tromey.com>
3035
3036         * symtab.c (struct symbol_cache): Add destructor and
3037         initializers.
3038         (symbol_cache_key): Move.  Change type.
3039         (make_symbol_cache, free_symbol_cache): Remove.
3040         (get_symbol_cache): Update.
3041         (symbol_cache_cleanup): Remove.
3042         (ALL_PSPACES, symbol_cache_flush)
3043         (maintenance_print_symbol_cache)
3044         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3045         Update.
3046
3047 2019-05-08  Tom Tromey  <tom@tromey.com>
3048
3049         * symtab.c (struct main_info): Add destructor and initializers.
3050         (main_progspace_key): Move.  Change type.
3051         (get_main_info): Update.
3052         (main_info_cleanup): Remove.
3053         (_initialize_symtab): Update.
3054
3055 2019-05-08  Tom Tromey  <tom@tromey.com>
3056
3057         * registry.h (DECLARE_REGISTRY): Define the _key class.
3058
3059 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * NEWS: Merge two 'New commands' sections.
3062
3063 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3064
3065         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3066         parameter and use Ada language definition instead.
3067         (ada_val_print_ptr): Remove unused language parameter.
3068         (ada_val_print_num): Remove language parameter and use Ada language
3069         definition instead.
3070         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3071         parameter.
3072         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3073         parameter and use Ada language definition instead.
3074         (ada_val_print_1): Update all ada_val_print_xxx calls.
3075         Remove language parameter.
3076         (ada_val_print): Update ada_val_print_1 call.
3077
3078 2019-05-08  Tom Tromey  <tromey@adacore.com>
3079
3080         * remote.c (remote_hw_watchpoint_limit)
3081         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3082         Now static.
3083
3084 2019-05-08  Tom Tromey  <tromey@adacore.com>
3085
3086         * maint.c (_initialize_maint_cmds): Move initialization code to
3087         remote.c.
3088         (watchdog, show_watchdog): Move to remote.c.
3089         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3090         "watchdog" static.
3091         (_initialize_remote): Move initialization code from maint.c.
3092         * defs.h (watchdog): Don't declare.
3093
3094 2019-05-08  Tom Tromey  <tromey@adacore.com>
3095
3096         * tui/tui-interp.c: Include main.h.
3097         * interps.c: Include main.h.
3098         * main.h (interpreter_p): Declare.
3099         * defs.h (interpreter_p): Don't declare.
3100
3101 2019-05-08  Tom Tromey  <tromey@adacore.com>
3102
3103         * dwarf2loc.c: Include dwarf2read.h.
3104         * defs.h (read_unsigned_leb128): Don't declare.
3105         * dwarf2read.h (read_unsigned_leb128): Declare.
3106
3107 2019-05-08  Tom Tromey  <tromey@adacore.com>
3108
3109         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3110         method.
3111
3112 2019-05-08  Tom Tromey  <tromey@adacore.com>
3113
3114         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3115         when no wrap column is set.
3116
3117 2019-05-08  Tom Tromey  <tromey@adacore.com>
3118
3119         * c-lang.c (c_get_string): Handle non-C-style arrays.
3120
3121 2019-05-08  Tom Tromey  <tromey@adacore.com>
3122
3123         * typeprint.c (print_offset_data::update): Print the bit offset,
3124         not the number of bits remaining.
3125
3126 2019-05-08  Tom Tromey  <tromey@adacore.com>
3127
3128         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3129         padding at end of comment.
3130
3131 2019-05-08  Tom Tromey  <tromey@adacore.com>
3132
3133         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3134         Compare main types.
3135
3136 2019-05-06  Tom Tromey  <tom@tromey.com>
3137
3138         * common/scoped_mmap.c: Include common-defs.h.
3139         * common/scoped_mmap.h: Don't include config.h.
3140
3141 2019-05-04  Tom Tromey  <tom@tromey.com>
3142
3143         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3144         (struct aarch64_call_info): Add initializers.
3145         <si>: Now a std::vector.
3146         (pass_on_stack, aarch64_push_dummy_call): Update.
3147
3148 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3149             Tom Tromey  <tom@tromey.com>
3150
3151         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3152         (ppc_threads): Now a std::vector.  Now static.
3153         (hwdebug_find_thread_points_by_tid)
3154         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3155         Update.
3156
3157 2019-05-04  Tom Tromey  <tom@tromey.com>
3158
3159         * arc-tdep.c (arc_tdesc_init): Return bool.
3160
3161 2019-05-04  Tom Tromey  <tom@tromey.com>
3162
3163         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3164         Use gdb_assert_not_reached.
3165
3166 2019-05-04  Tom Tromey  <tom@tromey.com>
3167
3168         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3169         "false".
3170
3171 2019-05-04  Tom Tromey  <tom@tromey.com>
3172
3173         * arc-tdep.c (arc_tdesc_init): Use bool.
3174
3175 2019-05-04  Tom Tromey  <tom@tromey.com>
3176
3177         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3178
3179 2019-05-04  Tom Tromey  <tom@tromey.com>
3180
3181         * cli/cli-cmds.c (valid_command_p): Return bool.
3182
3183 2019-05-04  Tom Tromey  <tom@tromey.com>
3184
3185         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3186         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3187
3188 2019-05-04  Raul Tambre  <raul@tambre.ee>
3189
3190         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3191         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3192         operator for comparison.
3193
3194 2019-05-04  Tom Tromey  <tom@tromey.com>
3195
3196         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3197         (lookup_partial_symbol, print_partial_symbols)
3198         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3199         (psymbol_compare): Update.
3200         (add_psymbol_to_bcache): Clear the entire psymbol.
3201         (maintenance_check_psymtabs): Update.
3202         * psympriv.h (struct partial_symbol): Don't derive from
3203         general_symbol_info.
3204         <obj_section, unrelocated_address, address,
3205         set_unrelocated_address>: Update.
3206         <ginfo>: New member.
3207         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3208         (debug_names::write_psymbols): Update.
3209
3210 2019-05-04  Tom de Vries  <tdevries@suse.de>
3211
3212         * contrib/cc-with-tweaks.sh: Support -n arg.
3213
3214 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3215
3216         * corelow.c (core_target::detach): Ensure frame cache and
3217         register caches are cleared.
3218         inferior.c (exit_inferior_1): Likewise.
3219
3220 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3221             Tom Tromey  <tom@tromey.com>
3222
3223         * dictionary.c (collate_pending_symbols_by_language): Remove
3224         "struct" from foreach.
3225         * symtab.c (lookup_global_symbol_from_objfile)
3226         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3227         foreach.
3228         * ser-tcp.c (net_open): Remove "struct" from foreach.
3229         * objfiles.c (objfile_relocate, objfile_rebase)
3230         (objfile_has_symbols): Remove "struct" from foreach.
3231         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3232         from foreach.
3233         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3234         foreach.
3235         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3236         "struct" from foreach.
3237         * ada-lang.c (create_excep_cond_exprs)
3238         (ada_exception_catchpoint_cond_string): Remove "struct" from
3239         foreach.
3240
3241 2019-05-03  Tom Tromey  <tromey@adacore.com>
3242
3243         * ada-exp.y (convert_char_literal): Check suffix of each
3244         enumerator.
3245
3246 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3247
3248         PR ada/21406:
3249         * ada-exp.y (yywrap): Don't define.
3250         * ada-lex.l (%option): Add noyywrap
3251         (yywrap): Remove.
3252
3253 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3254
3255         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3256         _WIN32_WINNT to the XP level, unless already defined to a higher
3257         level.
3258
3259         * unittests/parse-connection-spec-selftests.c:
3260         * ser-tcp.c:
3261         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3262         override.
3263
3264         * symfile.c (find_separate_debug_file): Remove colon from the
3265         drive spec of DOS/Windows file names of the target, so that the
3266         file name produced from DEBUGDIR and the target's directory will
3267         be valid on DOS/Windows systems.
3268
3269 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3270
3271         * rust-lang.c (val_print_struct): Handle printing structures
3272         containing strings.
3273
3274 2019-05-02  Tom Tromey  <tromey@adacore.com>
3275
3276         * valarith.c (_initialize_valarith): Remove.
3277
3278 2019-05-01  Tom Tromey  <tromey@adacore.com>
3279
3280         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3281         bitfields.
3282
3283 2019-05-01  Tom Tromey  <tromey@adacore.com>
3284
3285         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3286         for big-endian copies.
3287
3288 2019-04-30  Ali Tamur  <tamur@google.com>
3289         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3290         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3291         (read_3_bytes): New function.
3292
3293 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3294
3295         * windows-nat.c (main_thread_id): Delete.
3296         (handle_output_debug_string): Replace main_thread_id by
3297         current_event.dwThreadId.
3298         (fake_create_process): Likewise.
3299         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3300         Do not set main_thread_id.
3301         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3302         current_event.dwThreadId.
3303         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3304
3305 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3306
3307         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3308         Use current_event.dwThreadId instead of main_thread_id.
3309
3310 2019-04-30  Tom Tromey  <tromey@adacore.com>
3311
3312         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3313         (create_excep_cond_exprs): Iterate over program spaces.
3314         (ada_exception_catchpoint_cond_string): Examine all minimal
3315         symbols for exception types.
3316
3317 2019-04-30  Tom Tromey  <tromey@adacore.com>
3318
3319         PR c++/24470:
3320         * dwarf2read.c (process_structure_scope): Handle case where type
3321         has template parameters but no symbol was created.
3322
3323 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3324             Chris January  <chris.january@arm.com>
3325
3326         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3327         qualifier.
3328         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3329
3330 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3331
3332         * f-typeprint.c (f_print_type): Update rules for printing
3333         whitespace.
3334         (f_type_print_varspec_suffix): Likewise.
3335
3336 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3337             Chris January  <chris.january@arm.com>
3338
3339         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3340         function arguments.
3341
3342 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         * f-lang.c (build_fortran_types): Change name of void type to
3345         lower case.
3346         * f-typeprint.c (f_type_print_base): Print the name of the void
3347         type, rather than a fixed string.
3348         * f-valprint.c (f_decorations): Use lower case void string.
3349
3350 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3351             Chris January  <chris.january@arm.com>
3352
3353         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3354         types for Fortran.
3355
3356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3357             Chris January  <chris.january@arm.com>
3358             David Lecomber  <david.lecomber@arm.com>
3359
3360         * f-exp.y (BINOP_INTRINSIC): New token.
3361         (exp): New parser rule handling BINOP_INTRINSIC.
3362         (f77_keywords): Add new builtin procedures.
3363         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3364         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3365         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3366         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3367         (print_unop_subexp_f): New function.
3368         (print_binop_subexp_f): New function.
3369         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3370         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3371         (dump_subexp_body_f): Likewise.
3372         (operator_check_f): Likewise.
3373         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3374         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3375
3376 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3379         UNOP_KIND.
3380         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3381         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3382         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3383         (operator_length_f): New fuction.
3384         (print_subexp_f): New function.
3385         (op_name_f): New function.
3386         (dump_subexp_body_f): New function.
3387         (operator_check_f): New function.
3388         (exp_descriptor_f): Replace standard expression handling functions
3389         with new functions.
3390         * gdb/fortran-operator.def: New file.
3391         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3392         * gdb/std-operator.def: Remove UNOP_KIND.
3393
3394 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * std-operator.def: Remove unbalanced, stray double quote
3397         character.
3398
3399 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3400             Chris January  <chris.january@arm.com>
3401             Daniel Everett  <daniel.everett@arm.com>
3402             Nick Forrington  <nick.forrington@arm.com>
3403             Richard Bunt  <richard.bunt@arm.com>
3404
3405         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3406         of depth when printing anonymous structs or unions.
3407         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3408         Don't print either the top-level value, or the children if the
3409         max-depth is exceeded.
3410         (ppscm_print_children): When printing the key of a map, allow one
3411         extra level of depth.
3412         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3413         print either the top-level value, or the children if the max-depth
3414         is exceeded.
3415         (print_children): When printing the key of a map, allow one extra
3416         level of depth.
3417         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3418         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3419         (user_print_options): Initialise max_depth field.
3420         (val_print_scalar_or_string_type_p): New function.
3421         (val_print): Check to see if the max depth has been reached.
3422         (val_print_check_max_depth): Define new function.
3423         (show_print_max_depth): New function.
3424         (_initialize_valprint): Add 'print max-depth' option.
3425         * valprint.h (struct value_print_options) <max_depth>: New field.
3426         (val_print_check_max_depth): Declare new function.
3427         * NEWS: Document new feature.
3428
3429 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * ada-lang.c (ada_language_defn): Initialise new field.
3432         * c-lang.c (c_is_string_type_p): New function.
3433         (c_language_defn): Initialise new field.
3434         (cplus_language_defn): Initialise new field.
3435         (asm_language_defn): Initialise new field.
3436         (minimal_language_defn): Initialise new field.
3437         * c-lang.h (c_is_string_type_p): Declare new function.
3438         * d-lang.c (d_language_defn): Initialise new field.
3439         * f-lang.c (f_is_string_type_p): New function.
3440         (f_language_defn): Initialise new field.
3441         * go-lang.c (go_is_string_type_p): New function.
3442         (go_language_defn): Initialise new field.
3443         * language.c (default_is_string_type_p): New function.
3444         (unknown_language_defn): Initialise new field.
3445         (auto_language_defn): Initialise new field.
3446         * language.h (struct language_defn) <la_is_string_type_p>: New
3447         member variable.
3448         (default_is_string_type_p): Declare new function.
3449         * m2-lang.c (m2_language_defn): Initialise new field.
3450         * objc-lang.c (objc_language_defn): Initialise new field.
3451         * opencl-lang.c (opencl_language_defn): Initialise new field.
3452         * p-lang.c (pascal_is_string_type_p): New function.
3453         (pascal_language_defn): Initialise new field.
3454         * rust-lang.c (rust_is_string_type_p): New function.
3455         (rust_language_defn): Initialise new field.
3456
3457 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3460         New field.
3461         * ada-lang.c (ada_language_defn): Initialise new field.
3462         * c-lang.c (c_language_defn): Likewise.
3463         (cplus_language_defn): Likewise.
3464         (asm_language_defn): Likewise.
3465         (minimal_language_defn): Likewise.
3466         * d-lang.c (d_language_defn): Likewise.
3467         * f-lang.c (f_language_defn): Likewise.
3468         * go-lang.c (go_language_defn): Likewise.
3469         * language.c (unknown_language_defn): Likewise.
3470         (auto_language_defn): Likewise.
3471         * m2-lang.c (m2_language_defn): Likewise.
3472         * objc-lang.c (objc_language_defn): Likewise.
3473         * opencl-lang.c (opencl_language_defn): Likewise.
3474         * p-lang.c (pascal_language_defn): Likewise.
3475         * rust-lang.c (rust_language_defn): Likewise.
3476
3477 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * ada-lang.c (ada_is_character_type): Change return type to bool.
3480         (ada_is_string_type): Likewise.
3481         * ada-lang.h (ada_is_character_type): Update declaration
3482         (ada_is_string_type): Likewise.
3483
3484 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3485
3486         Support style in 'frame|thread apply'
3487
3488         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3489         * record.c (record_start, record_stop): Update callers of
3490         execute_command_to_string with false.
3491         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3492         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3493         methods.
3494         (class string_file): New constructor with term_out parameter.
3495         Override methods term_out and can_emit_style_escape.  New member
3496         term_out.
3497         (class stdio_file): Override can_emit_style_escape.
3498         (class tee_file): Override term_out and can_emit_style_escape.
3499         * utils.h (can_emit_style_escape): Remove.
3500         * utils.c (can_emit_style_escape): Likewise.
3501         Update all callers of can_emit_style_escape (SOMESTREAM) to
3502         SOMESTREAM->can_emit_style_escape.
3503         * source-cache.c (source_cache::get_source_lines): Likewise.
3504         * stack.c (frame_apply_command_count): Call execute_command_to_string
3505         passing the term_out characteristic of the current gdb_stdout.
3506         * thread.c (thr_try_catch_cmd): Likewise.
3507         * top.c (execute_command_to_string): pass term_out parameter
3508         to construct the string_file for the command output.
3509         * ui-file.c (term_cli_styling): New function (most code moved
3510         from utils.c can_emit_style_escape).
3511         (string_file::string_file, string_file::can_emit_style_escape,
3512         stdio_file::can_emit_style_escape, tee_file::term_out,
3513         tee_file::can_emit_style_escape): New functions.
3514
3515 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3516
3517         * NEWS: Mention the new set|show may-call-functions.
3518         * infcall.c (may_call_functions_p): New variable.
3519         (show_may_call_functions_p): New function.
3520         (call_function_by_hand_dummy): Throws an error if not
3521         may-call-functions.
3522         (_initialize_infcall): Call add_setshow_boolean_cmd for
3523         may-call-functions.
3524
3525 2019-04-25  Keith Seitz  <keiths@redhat.com>
3526
3527         PR c++/24367
3528         * cp-support.c (inspect_type): Don't attempt substitutions
3529         of symbol with the same name.
3530
3531 2019-04-25  Tom Tromey  <tromey@adacore.com>
3532
3533         PR gdb/24475:
3534         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3535         static.
3536
3537 2019-04-25  Tom Tromey  <tromey@adacore.com>
3538
3539         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3540         rvalue reference.
3541         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3542         (gdb_xml_parser::parse): Use std::move.
3543         * python/python-internal.h (gdbpy_convert_exception): Take a const
3544         reference.
3545         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3546         std::move.
3547         * python/py-utils.c (gdbpy_convert_exception): Take a const
3548         reference.
3549         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3550         Use std::move.
3551         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3552         Use std::move.
3553         * mi/mi-main.c (mi_print_exception): Take a const reference.
3554         * main.c (handle_command_errors): Take a const reference.
3555         * linespec.c (parse_linespec): Use std::move.
3556         * infcall.c (run_inferior_call): Use std::move.
3557         (call_function_by_hand_dummy): Use std::move.
3558         * exec.c (try_open_exec_file): Use std::move.
3559         * exceptions.h (exception_print, exception_fprintf)
3560         (exception_print_same): Update.
3561         * exceptions.c (print_exception, exception_print)
3562         (exception_fprintf, exception_print_same): Change parameters to
3563         const reference.
3564         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3565         * common/new-op.c: Use std::move.
3566         * common/common-exceptions.h (struct gdb_exception): Add move
3567         constructor.
3568         (struct gdb_exception_error, struct gdb_exception_quit, struct
3569         gdb_quit_bad_alloc): Change constructor to move constructor.
3570         (throw_exception): Change parameter to rvalue reference.
3571         * common/common-exceptions.c (throw_exception): Take rvalue
3572         reference.
3573         * cli/cli-interp.c (safe_execute_command): Use std::move.
3574         * breakpoint.c (insert_bp_location, location_to_sals): Use
3575         std::move.
3576
3577 2019-04-25  Tom Tromey  <tromey@adacore.com>
3578
3579         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3580         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3581         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3582         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3583         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3584         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3585         guile/scm-value.c: Use unpack.
3586         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3587         gdbscm_gdb_exception.
3588         (gdbscm_throw_gdb_exception): Likewise.
3589         (struct gdbscm_gdb_exception): New.
3590         (unpack): New function.
3591         (gdbscm_wrap): Use unpack.
3592
3593 2019-04-25  Tom Tromey  <tromey@adacore.com>
3594
3595         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3596         (gdb_rl_callback_handler): Use std::move.
3597         * common/common-exceptions.h (struct gdb_exception): Add move
3598         assignment operator.
3599         (throw_exception_sjlj): Change "exception" to const reference.
3600         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3601         (throw_exception_sjlj): Change "exception" to const reference.
3602
3603 2019-04-25  Tom Tromey  <tromey@adacore.com>
3604
3605         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3606         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3607         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3608         Update.
3609         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3610         Update.
3611         * mi/mi-interp.c (mi_interp::exec): Update.
3612         * linespec.c (parse_linespec): Update.
3613         * infcall.c (run_inferior_call): Update.
3614         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3615         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3616         (gdbscm_lookup_global_symbol): Update.
3617         * guile/scm-param.c (gdbscm_parameter_value): Update.
3618         * guile/scm-frame.c (gdbscm_frame_read_register)
3619         (gdbscm_frame_read_var): Update.
3620         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3621         * exec.c (try_open_exec_file): Update.
3622         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3623         (gdb_rl_callback_handler): Update.
3624         * common/common-exceptions.h (exception_none): Don't declare.
3625         * common/common-exceptions.c (exception_none): Don't define.
3626         (struct catcher) <exception>: Update.
3627         * cli/cli-interp.c (safe_execute_command): Update.
3628         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3629
3630 2019-04-25  Ali Tamur  <tamur@google.com>
3631
3632         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3633         (read_attribute_value): Likewise.
3634         (dwarf2_read_addr_index): Update comment.
3635         (read_str_index): Add DW_FORM_strx.
3636         (dwarf2_string_attr): Likewise.
3637         (dwarf2_const_value_attr): Likewise.
3638         (dump_die_shallow): Likewise.
3639         (dwarf2_fetch_constant_bytes): Likewise.
3640         (skip_form_bytes): Likewise.
3641         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3642
3643 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3644
3645         PR corefiles/11608
3646         PR corefiles/18187
3647         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3648         OFFSET.  Verify if current mapping contains an ELF header.
3649         (linux_find_memory_regions_full): Adjust call to
3650         dump_mapping_p.
3651
3652 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3653             Kang Li <kanglictf@gmail.com>
3654
3655         PR gdb/21600
3656
3657         * dwarf2-frame.c (read_initial_length): Be consistent about using
3658         unsigned representation of length.
3659         (decode_frame_entry_1): Likewise.  Check for wraparound of
3660         end pointer as well as buffer overflow.
3661
3662 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3663
3664         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3665         "vq".
3666
3667 2019-04-24  Tom Tromey  <tromey@adacore.com>
3668
3669         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3670
3671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * s12z-tdep.c (s12z_unwind_pc): Delete.
3674         (s12z_unwind_sp): Delete.
3675         (s12z_gdbarch_init): Don't register deleted functions with
3676         gdbarch.
3677
3678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3679
3680         * rl78-tdep.c (rl78_unwind_sp): Delete.
3681         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3682
3683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3686         (xstormy16_unwind_pc): Delete.
3687         (xstormy16_dummy_id): Delete.
3688         (xstormy16_gdbarch_init): Don't register deleted functions with
3689         gdbarch.
3690
3691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * vax-tdep.c (vax_unwind_pc): Delete.
3694         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3695
3696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * v850-tdep.c (v850_unwind_sp): Delete.
3699         (v850_unwind_pc): Delete.
3700         (v850_dummy_id): Delete.
3701         (v850_gdbarch_init): Don't register deleted functions with
3702         gdbarch.
3703
3704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3707         (tilegx_unwind_pc): Delete.
3708         (tilegx_unwind_dummy_id): Delete.
3709         (tilegx_gdbarch_init): Don't register deleted functions with
3710         gdbarch.
3711
3712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3715         (tic6x_dummy_id): Delete.
3716         (tic6x_gdbarch_init): Don't register deleted functions with
3717         gdbarch.
3718
3719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * sparc-tdep.c (sparc_unwind_pc): Delete.
3722         (sparc32_gdbarch_init): Don't register deleted function with
3723         gdbarch.
3724
3725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * sh-tdep.c (sh_unwind_sp): Delete.
3728         (sh_unwind_pc): Delete.
3729         (sh_dummy_id): Delete.
3730         (sh_gdbarch_init): Don't register deleted functions with
3731         gdbarch.
3732
3733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * score-tdep.c (score_unwind_sp): Delete.
3736         (score_unwind_pc): Delete.
3737         (score_dummy_id): Delete.
3738         (score_gdbarch_init): Don't register deleted functions with
3739         gdbarch.
3740
3741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3742
3743         * rx-tdep.c (rx_unwind_pc): Delete.
3744         (rx_unwind_sp): Delete.
3745         (rx_dummy_id): Delete.
3746         (rx_gdbarch_init): Don't register deleted functions with
3747         gdbarch.  Update comment.
3748
3749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3752         (rs6000_dummy_id): Delete.
3753         (rs6000_gdbarch_init): Don't register deleted functions with
3754         gdbarch.
3755
3756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3757
3758         * or1k-tdep.c (or1k_dummy_id): Delete.
3759         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3760
3761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         * nios2-tdep.c (nios2_dummy_id): Delete.
3764         (nios2_unwind_sp): Delete.
3765         (nios2_gdbarch_init): Don't register deleted functions with
3766         gdbarch.
3767
3768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         * nds32-tdep.c (nds32_dummy_id): Delete.
3771         (nds32_unwind_pc): Delete.
3772         (nds32_unwind_sp): Delete.
3773         (nds32_gdbarch_init): Don't register deleted functions with
3774         gdbarch.
3775
3776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3777
3778         * msp430-tdep.c (msp430_unwind_pc): Delete.
3779         (msp430_unwind_sp): Delete.
3780         (msp430_dummy_id): Delete.
3781         (msp430_gdbarch_init): Don't register deleted functions with
3782         gdbarch.
3783
3784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * moxie-tdep.c (moxie_unwind_sp): Delete.
3787         (moxie_unwind_pc): Delete.
3788         (moxie_dummy_id): Delete.
3789         (moxie_gdbarch_init): Don't register deleted functions with
3790         gdbarch.
3791
3792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3795         (mn10300_unwind_pc): Delete.
3796         (mn10300_unwind_sp): Delete.
3797         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3798         mn10300_unwind_sp.
3799         (mn10300_frame_unwind_init): Don't register deleted functions with
3800         gdbarch.
3801
3802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * mep-tdep.c (mep_unwind_pc): Delete.
3805         (mep_unwind_sp): Delete.
3806         (mep_dummy_id): Delete.
3807         (mep_gdbarch_init): Don't register deleted functions with
3808         gdbarch.
3809
3810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3813         (m68hc11_unwind_sp): Delete.
3814         (m68hc11_gdbarch_init): Don't register deleted functions with
3815         gdbarch.
3816
3817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * m32r-tdep.c (m32r_unwind_sp): Delete.
3820         (m32r_unwind_pc): Delete.
3821         (m32r_dummy_id): Delete.
3822         (m32r_gdbarch_init): Don't register deleted functions with
3823         gdbarch.
3824
3825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * m32c-tdep.c (m32c_unwind_pc): Delete.
3828         (m32c_unwind_sp): Delete.
3829         (m32c_dummy_id): Delete.
3830         (m32c_gdbarch_init): Don't register deleted functions with
3831         gdbarch.
3832
3833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3834
3835         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3836         (lm32_unwind_pc): Delete.
3837         (lm32_dummy_id): Delete.
3838         (lm32_gdbarch_init): Don't register deleted functions with
3839         gdbarch.
3840
3841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3844         (iq2000_unwind_pc): Delete.
3845         (iq2000_dummy_id): Delete.
3846         (iq2000_gdbarch_init): Don't register deleted functions with
3847         gdbarch.
3848
3849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * nds32-tdep.c (nds32_type_align): Delete.
3852         (nds32_push_dummy_call): Use type_align instead.
3853
3854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * arm-tdep.c (arm_type_align): Only handle vector override case.
3857         (arm_push_dummy_call): Use type_align.
3858         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3859
3860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3863         case.
3864         (pass_on_stack): Use type_align.
3865         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3866         function.
3867
3868 2019-04-23  Tom Tromey  <tromey@adacore.com>
3869
3870         * dwarf2read.c (line_header::file_name_at): Remove unused
3871         overload.
3872
3873 2019-04-23  Tom de Vries  <tdevries@suse.de>
3874
3875         PR gdb/24438
3876         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3877         invocation.
3878
3879
3880 2019-03-27  Ali Tamur  <tamur@google.com>
3881
3882         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3883         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3884         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3885         (dwarf_expr_context::get_addr_index): Likewise
3886         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3887         (symbol_needs_eval_context::get_addr_index): Likewise
3888         (disassemble_dwarf_expression): Add DW_OP_addrx
3889         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3890         (read_cutu_die_from_dwo): Update comment
3891         (skip_one_die): Add DW_FORM_addrx
3892         (read_attribute_value): Likewise
3893         (var_decode_location): Add DW_OP_addrx
3894         (dwarf2_const_value_attr): Add DW_FORM_addrx
3895         (dump_die_shallow): Likewise
3896         (dwarf2_fetch_constant_bytes): Likewise
3897         (decode_locdesc): Add DW_OP_addrx
3898         (skip_form_bytes): Add DW_FORM_addrx
3899
3900 2019-04-22  Ali Tamur  <tamur@google.com>
3901
3902         * MAINTAINERS (Write After Approval): Add self.
3903
3904 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3905
3906         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3907         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3908         (open_symbol_file_object): Likewise.
3909         (svr4_default_sos): Add info parameter.
3910         (svr4_read_so_list): Likewise.
3911         (svr4_current_sos_direct): Adjust functions calls to pass down
3912         info.
3913         (svr4_current_sos_1): Add info parameter.
3914         (svr4_current_sos): Call get_svr4_info, pass info down to
3915         svr4_current_sos_1.
3916         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3917         get_svr4_info.
3918         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3919         get_svr4_info.
3920         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3921         to get_svr4_info.
3922         (probes_table_remove_objfile_probes): Likewise.
3923         (register_solib_event_probe): Add info parameter.
3924         (solist_update_incremental): Pass info parameter down to
3925         svr4_read_so_list.
3926         (disable_probes_interface): Add info parameter.
3927         (svr4_handle_solib_event): Pass current_program_space to
3928         get_svr4_info.  Adjust disable_probes_interface cleanup.
3929         (svr4_create_probe_breakpoints): Add info parameter, pass it
3930         down to register_solib_event_probe.
3931         (svr4_create_solib_event_breakpoints): Add info parameter,
3932         pass it down to svr4_create_probe_breakpoints.
3933         (enable_break): Pass info down to
3934         svr4_create_solib_event_breakpoints.
3935         (svr4_solib_create_inferior_hook): Pass current_program_space to
3936         get_svr4_info.
3937         (svr4_clear_solib): Likewise.
3938
3939 2019-04-22  Pedro Alves  <palves@redhat.com>
3940
3941         * solib-svr4.c (svr4_free_objfile_observer): New.
3942         (probe_and_action::objfile): New field.
3943         (probes_table_htab_remove_objfile_probes)
3944         (probes_table_remove_objfile_probes): New functions.
3945         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3946         in the new probe_and_action.  Don't store the probe in 'lookup'.
3947         (svr4_create_probe_breakpoints): Pass objfile to
3948         register_solib_event_probe.
3949         (_initialize_svr4_solib): Register a free_objfile observer.
3950
3951 2019-04-19  Tom Tromey  <tom@tromey.com>
3952
3953         * common/queue.h: Remove.
3954
3955 2019-04-19  Tom Tromey  <tom@tromey.com>
3956
3957         * event-loop.c: Don't include "common/queue.h".
3958
3959 2019-04-19  Tom Tromey  <tom@tromey.com>
3960
3961         * remote.c (remote_target): Use delete.
3962         * remote-notif.h: Include <list>, not "common/queue.h".
3963         (notif_client_p): Remove typedef.
3964         (remote_notif_state): Add constructor, destructor, initializer.
3965         <notif_queue>: Now a std::list.
3966         (remote_notif_state_xfree): Don't declare.
3967         * remote-notif.c (remote_notif_process, handle_notification)
3968         (remote_notif_state_allocate): Update.
3969         (~remote_notif_state): Rename from remote_notif_state_xfree.
3970
3971 2019-04-19  Tom Tromey  <tom@tromey.com>
3972
3973         * symfile.c (reread_symbols): Update.
3974         * objfiles.c (objfile_register_static_link)
3975         (objfile_lookup_static_link): Update
3976         (~objfile) Don't delete static_links.
3977         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3978
3979 2019-04-19  Tom Tromey  <tom@tromey.com>
3980
3981         * type-stack.h (struct type_stack) <insert>: Constify string.
3982         * type-stack.c (type_stack::insert): Constify string.
3983         * gdbtypes.h (lookup_template_type): Update.
3984         (address_space_name_to_int): Update.
3985         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3986         const.
3987         (lookup_template_type): Make name const.
3988         * c-exp.y: Update rules.
3989         (lex_one_token, classify_name, classify_inner_name)
3990         (c_print_token): Update.
3991         * p-exp.y: Update rules.
3992         (yylex): Update.
3993         * f-exp.y: Update rules.
3994         (yylex): Update.
3995         * d-exp.y: Update rules.
3996         (lex_one_token, classify_name, classify_inner_name): Update.
3997         * parse.c (write_dollar_variable, copy_name): Return std::string.
3998         * parser-defs.h (copy_name): Change return type.
3999         * m2-exp.y: Update rules.
4000         (yylex): Update.
4001         * go-exp.y (lex_one_token): Update.
4002         Update rules.
4003         (classify_unsafe_function, classify_packaged_name)
4004         (classify_name, yylex): Update.
4005
4006 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4007
4008         * configure.ac: add --enable-source-highlight switch.
4009         * configure: Regenerate.
4010         * top.c (print_gdb_version): plumb --enable-source-highlight
4011         status to "show configuration".
4012
4013 2019-04-19  Tom Tromey  <tromey@adacore.com>
4014
4015         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4016         Check ADA_TYPE_P.
4017         (empty_record, ada_template_to_fixed_record_type_1)
4018         (template_to_static_fixed_type)
4019         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4020         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4021         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4022         macros.
4023
4024 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4025
4026         PR symtab/24423:
4027         * source.c (print_source_lines_base): Advance "iter" when a
4028         control character is seen.
4029
4030 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * inferior.h (struct infcall_suspend_state_deleter):
4033         Catch exception in destructor to avoid crash.
4034
4035 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4036
4037         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4038         close to the add_com "shell".
4039
4040 2019-04-18  Tom Tromey  <tromey@adacore.com>
4041
4042         * process-stratum-target.h (class process_stratum_target)
4043         <stratum>: Add "final".
4044
4045 2019-04-17  Tom Tromey  <tromey@adacore.com>
4046
4047         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4048         against nullptr before use.
4049
4050 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4051
4052         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4053
4054 2019-04-17  Jim Wilson  <jimw@sifive.com>
4055             Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4058         code read might fail, assume 4-byte breakpoint in that case.
4059
4060 2019-04-15  Leszek Swirski  <leszeks@google.com>
4061
4062         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4063         rather than a hand-rolled POD check when checking for forced MEMORY
4064         classification.
4065
4066 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4067
4068         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4069         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4070         function.
4071         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4072         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4073         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4074         declaration.
4075
4076 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4077
4078         * aarch64-linux-nat.c
4079         (aarch64_linux_nat_target::thread_architecture): Add override.
4080         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4081         each VQ.
4082
4083 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4084
4085         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4086
4087 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4090         target types of size 96-bits, add some additional comments, and
4091         check that the builtin type we found was the correct size.
4092
4093 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4094
4095         * utils.c (prompt_for_continue): Don't restore the styling at the
4096         end, as applied_style has the wrong value.  This fixes styling in
4097         long lists of file names that are interrupted by the "Continue?"
4098         prompt.
4099
4100 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4101
4102         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4103         * c-lang.c (c_language_defn): Likewise.
4104         (cplus_language_defn): Likewise.
4105         (asm_language_defn): Likewise.
4106         (minimal_language_defn): Likewise.
4107         * d-lang.c (d_language_defn): Likewise.
4108         * f-lang.c (f_language_defn): Likewise.
4109         * go-lang.c (go_language_defn): Likewise.
4110         * language.c (unknown_language_defn): Likewise.
4111         (auto_language_defn): Likewise.
4112         * language.h (struct language_defn): Remove la_magic field.
4113         (LANG_MAGIC): Delete.
4114         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4115         * objc-lang.c (objc_language_defn): Likewise.
4116         * opencl-lang.c (opencl_language_defn): Likewise.
4117         * p-lang.c (pascal_language_defn): Likewise.
4118         * rust-lang.c (rust_language_defn): Likewise.
4119
4120 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * riscv-tdep.c (riscv_type_align): New function.
4123         (riscv_type_alignment): Delete.
4124         (riscv_arg_location): Use 'type_align'.
4125         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4126
4127 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4128
4129         * gdbtypes.c (type_align): A struct with no non-static fields also
4130         has alignment of 1.
4131
4132 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4135         component to 0.
4136         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4137         member.
4138         (riscv_struct_info::analyse): New implementation using new
4139         analyse_inner member function.
4140         (riscv_struct_info::field_offset): New member function.
4141         (riscv_struct_info::m_offsets): New member variable.
4142         (riscv_struct_info::analyse_inner): New private member function,
4143         takes the old implementation of riscv_struct_info::analyse but
4144         extended to track field offsets.
4145         (riscv_call_arg_struct): Update the struct folding special cases
4146         to handle cases where empty C++ structs, which are non-zero
4147         length, are found.
4148         (riscv_arg_location): Initialise the length of each location, a
4149         non-zero length now indicates the location is in use.
4150         (riscv_push_dummy_call): Allow for the first location having a
4151         non-zero offset when setting up arguments.
4152         (riscv_return_value): Likewise, but for return values.
4153
4154 2019-04-11  Tom Tromey  <tromey@adacore.com>
4155
4156         * utils.c (internal_vproblem): Make "msg" const.
4157
4158 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4159
4160         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4161         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4162         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4163         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4164
4165 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4166
4167         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4168         function.
4169         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4170         of amd64_collect_native_gregset.
4171         (amd64_linux_nat_target::store_registers): Likewise.
4172
4173 2019-04-10  Tom Tromey  <tom@tromey.com>
4174
4175         * symtab.c (lookup_global_symbol_from_objfile)
4176         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4177         * objfiles.h (class separate_debug_iterator): New.
4178         (class separate_debug_range): New.
4179         (struct objfile) <separate_debug_objfiles>: New method.
4180         (objfile_separate_debug_iterate): Don't declare.
4181         * objfiles.c (separate_debug_iterator::operator++): Rename from
4182         objfile_separate_debug_iterate.
4183         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4184         iterator.
4185         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4186         iterator.
4187
4188 2019-04-10  Tom Tromey  <tom@tromey.com>
4189
4190         * symfile.c (reread_symbols): Remove old comment.
4191         * objfiles.c (free_all_objfiles): Fix a typo.
4192
4193 2019-04-10  Tom Tromey  <tom@tromey.com>
4194
4195         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4196         * minsyms.c (lookup_minimal_symbol): Use foreach.
4197         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4198         (lookup_minimal_symbol_solib_trampoline): Likewise.
4199         * symfile.c (reread_symbols): Use foreach.
4200
4201 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4202             Tom Tromey  <tromey@adacore.com>
4203
4204         PR rust/24414:
4205         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4206         (rust_lex_int_test): Change "value" to be LONGEST.
4207         (rust_lex_tests): Add test for long integer literal.
4208
4209 2019-04-09  Tom Tromey  <tromey@adacore.com>
4210
4211         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4212         to bool.
4213         (extended_remote_target::attach): Update.
4214         (remote_target::remote_notice_new_inferior): Update.
4215         (remote_target::add_current_inferior_and_thread): Update.
4216         * inferior.c (exit_inferior_1): Use "false".
4217         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4218
4219 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4220
4221         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4222         the "start" command.
4223
4224 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4225
4226         * python/py-inferior.c (infpy_thread_from_thread_handle):
4227         Adjust comments to reflect renaming of thread_from_thread_handle
4228         to thread_from_handle.  Adjust keywords.  Fix type error message.
4229         (inferior_object_methods): Add thread_from_handle.  Retain
4230         thread_from_thread_handle, but mark it as deprecated.
4231
4232 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4233
4234         * gdbthread.h (find_thread_by_handle): Revise declaration.
4235         * thread.c (find_thread_by_handle): Likewise.  Adjust
4236         implementation too.
4237         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4238         support for buffer objects as handles.
4239
4240 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4241
4242         * python/py-infthread.c (thpy_thread_handle): New function.
4243         (thread_object_methods): Register thpy_thread_handle.
4244
4245 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4246
4247         * gdbthread.h (thread_to_thread_handle): Declare.
4248         * thread.c (gdbtypes.h): Include.
4249         (thread_to_thread_handle): New function.
4250
4251         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4252         (target_thread_info_to_thread_handle): Declare.
4253         * target.c (target_thread_info_to_thread_handle): New function.
4254         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4255         * target-delegates.c: Regenerate.
4256
4257         * linux-thread-db.c (class thread_db_target): Add method
4258         thread_info_to_thread_handle.
4259         (thread_db_target::thread_info_to_thread_handle): Define.
4260         * remote.c (class remote_target): Add new method
4261         thread_info_to_thread_handle.
4262         (remote_target::thread_info_to_thread_handle): Define.
4263
4264 2019-04-08  Pedro Alves  <palves@redhat.com>
4265
4266         * common/common-exceptions.c (throw_exception): Don't create
4267         named object to throw; throw directly.
4268         (throw_it): Likewise.  Don't initialize gdb_exception::message
4269         here, with new; pass FMT and AP to the ctor instead.
4270         * common/common-exceptions.h: Include <string>.
4271         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4272         const char *, va_list)): New ctor.  Use std::make_shared.
4273         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4274         errors)): Delete.
4275         (gdb_exception_error::gdb_exception_error(enum errors, const char
4276         *, va_list)): New.
4277         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4278         Add assertion.
4279         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4280         errors)): Delete.
4281         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4282         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4283         Add assertion.
4284
4285 2019-04-08  Tom Tromey  <tom@tromey.com>
4286
4287         * valops.c (value_rtti_indirect_type): Replace throw_exception
4288         with throw.
4289         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4290         with throw.
4291         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4292         throw.
4293         * target.c (target_translate_tls_address): Replace throw_exception
4294         with throw.
4295         * stack.c (frame_apply_command_count): Replace throw_exception
4296         with throw.
4297         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4298         throw.
4299         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4300         with throw.
4301         * rs6000-tdep.c (rs6000_frame_cache)
4302         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4303         * remote.c: Replace throw_exception with throw.
4304         * record-full.c (record_full_message, record_full_wait_1)
4305         (record_full_restore): Replace throw_exception with throw.
4306         * record-btrace.c:
4307         (get_thread_current_frame_id, record_btrace_start_replaying)
4308         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4309         (cmd_record_btrace_start): Replace throw_exception with throw.
4310         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4311         throw.
4312         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4313         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4314         * linespec.c:
4315         (find_linespec_symbols): Replace throw_exception with throw.
4316         * infrun.c (displaced_step_prepare, resume): Replace
4317         throw_exception with throw.
4318         * infcmd.c (post_create_inferior): Replace throw_exception with
4319         throw.
4320         * inf-loop.c (inferior_event_handler): Replace throw_exception
4321         with throw.
4322         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4323         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4324         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4325         (get_prev_frame_always, get_frame_pc_if_available)
4326         (get_frame_address_in_block_if_available, get_frame_language):
4327         Replace throw_exception with throw.
4328         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4329         throw_exception with throw.
4330         * eval.c (fetch_subexp_value, evaluate_var_value)
4331         (evaluate_funcall, evaluate_subexp_standard): Replace
4332         throw_exception with throw.
4333         * dwarf2loc.c (call_site_find_chain)
4334         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4335         Replace throw_exception with throw.
4336         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4337         with throw.
4338         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4339         throw.
4340         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4341         * completer.c (complete_line_internal): Replace throw_exception
4342         with throw.
4343         * compile/compile-object-run.c (compile_object_run): Replace
4344         throw_exception with throw.
4345         * cli/cli-script.c (process_next_line): Replace throw_exception
4346         with throw.
4347         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4348         (btrace_enable, btrace_maint_update_pt_packets): Replace
4349         throw_exception with throw.
4350         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4351         throw_exception with throw.
4352         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4353         throw_exception with throw.
4354         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4355         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4356         * aarch64-tdep.c (aarch64_make_prologue_cache)
4357         (aarch64_make_stub_cache): Replace throw_exception with throw.
4358
4359 2019-04-08  Tom Tromey  <tom@tromey.com>
4360
4361         * common/common-exceptions.c (throw_exception): Rename from
4362         throw_exception_cxx.  Remove old copy.  Make argument const.
4363         (throw_it): Create and throw exception objects directly.
4364         * common/common-exceptions.h (throw_exception): Make argument
4365         const.
4366         (struct gdb_exception_error): Add constructor.
4367         (struct gdb_exception_quit): Add constructor.
4368
4369 2019-04-08  Tom Tromey  <tom@tromey.com>
4370
4371         * common/common-exceptions.h (exception_rethrow): Don't declare.
4372         (TRY_SJLJ): Update comment.
4373         (TRY, CATCH, END_CATCH): Remove.
4374         * common/common-exceptions.c (exception_rethrow): Remove.
4375
4376 2019-04-08  Tom Tromey  <tom@tromey.com>
4377
4378         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4379         Remove.
4380         (gdb_exception_error): Rename from
4381         gdb_exception_RETURN_MASK_ERROR.
4382         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4383         (gdb_quit_bad_alloc): Update.
4384         * aarch64-tdep.c: Update.
4385         * ada-lang.c: Update.
4386         * ada-typeprint.c: Update.
4387         * ada-valprint.c: Update.
4388         * amd64-tdep.c: Update.
4389         * arch-utils.c: Update.
4390         * break-catch-throw.c: Update.
4391         * breakpoint.c: Update.
4392         * btrace.c: Update.
4393         * c-varobj.c: Update.
4394         * cli/cli-cmds.c: Update.
4395         * cli/cli-interp.c: Update.
4396         * cli/cli-script.c: Update.
4397         * common/common-exceptions.c: Update.
4398         * common/new-op.c: Update.
4399         * common/selftest.c: Update.
4400         * compile/compile-c-symbols.c: Update.
4401         * compile/compile-cplus-symbols.c: Update.
4402         * compile/compile-object-load.c: Update.
4403         * compile/compile-object-run.c: Update.
4404         * completer.c: Update.
4405         * corelow.c: Update.
4406         * cp-abi.c: Update.
4407         * cp-support.c: Update.
4408         * cp-valprint.c: Update.
4409         * darwin-nat.c: Update.
4410         * disasm-selftests.c: Update.
4411         * dtrace-probe.c: Update.
4412         * dwarf-index-cache.c: Update.
4413         * dwarf-index-write.c: Update.
4414         * dwarf2-frame-tailcall.c: Update.
4415         * dwarf2-frame.c: Update.
4416         * dwarf2loc.c: Update.
4417         * dwarf2read.c: Update.
4418         * eval.c: Update.
4419         * event-loop.c: Update.
4420         * event-top.c: Update.
4421         * exec.c: Update.
4422         * f-valprint.c: Update.
4423         * fbsd-tdep.c: Update.
4424         * frame-unwind.c: Update.
4425         * frame.c: Update.
4426         * gdbtypes.c: Update.
4427         * gnu-v3-abi.c: Update.
4428         * guile/guile-internal.h: Update.
4429         * guile/scm-block.c: Update.
4430         * guile/scm-breakpoint.c: Update.
4431         * guile/scm-cmd.c: Update.
4432         * guile/scm-disasm.c: Update.
4433         * guile/scm-frame.c: Update.
4434         * guile/scm-lazy-string.c: Update.
4435         * guile/scm-math.c: Update.
4436         * guile/scm-param.c: Update.
4437         * guile/scm-ports.c: Update.
4438         * guile/scm-pretty-print.c: Update.
4439         * guile/scm-symbol.c: Update.
4440         * guile/scm-symtab.c: Update.
4441         * guile/scm-type.c: Update.
4442         * guile/scm-value.c: Update.
4443         * i386-linux-tdep.c: Update.
4444         * i386-tdep.c: Update.
4445         * inf-loop.c: Update.
4446         * infcall.c: Update.
4447         * infcmd.c: Update.
4448         * infrun.c: Update.
4449         * jit.c: Update.
4450         * language.c: Update.
4451         * linespec.c: Update.
4452         * linux-fork.c: Update.
4453         * linux-nat.c: Update.
4454         * linux-tdep.c: Update.
4455         * linux-thread-db.c: Update.
4456         * main.c: Update.
4457         * mi/mi-cmd-break.c: Update.
4458         * mi/mi-cmd-stack.c: Update.
4459         * mi/mi-interp.c: Update.
4460         * mi/mi-main.c: Update.
4461         * objc-lang.c: Update.
4462         * p-valprint.c: Update.
4463         * parse.c: Update.
4464         * ppc-linux-tdep.c: Update.
4465         * printcmd.c: Update.
4466         * python/py-arch.c: Update.
4467         * python/py-breakpoint.c: Update.
4468         * python/py-cmd.c: Update.
4469         * python/py-finishbreakpoint.c: Update.
4470         * python/py-frame.c: Update.
4471         * python/py-framefilter.c: Update.
4472         * python/py-gdb-readline.c: Update.
4473         * python/py-inferior.c: Update.
4474         * python/py-infthread.c: Update.
4475         * python/py-lazy-string.c: Update.
4476         * python/py-linetable.c: Update.
4477         * python/py-objfile.c: Update.
4478         * python/py-param.c: Update.
4479         * python/py-prettyprint.c: Update.
4480         * python/py-progspace.c: Update.
4481         * python/py-record-btrace.c: Update.
4482         * python/py-record.c: Update.
4483         * python/py-symbol.c: Update.
4484         * python/py-type.c: Update.
4485         * python/py-unwind.c: Update.
4486         * python/py-utils.c: Update.
4487         * python/py-value.c: Update.
4488         * python/python.c: Update.
4489         * record-btrace.c: Update.
4490         * record-full.c: Update.
4491         * remote-fileio.c: Update.
4492         * remote.c: Update.
4493         * riscv-tdep.c: Update.
4494         * rs6000-aix-tdep.c: Update.
4495         * rs6000-tdep.c: Update.
4496         * rust-exp.y: Update.
4497         * rust-lang.c: Update.
4498         * s390-tdep.c: Update.
4499         * selftest-arch.c: Update.
4500         * solib-dsbt.c: Update.
4501         * solib-frv.c: Update.
4502         * solib-spu.c: Update.
4503         * solib-svr4.c: Update.
4504         * solib.c: Update.
4505         * sparc64-linux-tdep.c: Update.
4506         * stack.c: Update.
4507         * symfile-mem.c: Update.
4508         * symmisc.c: Update.
4509         * target.c: Update.
4510         * thread.c: Update.
4511         * top.c: Update.
4512         * tracefile-tfile.c: Update.
4513         * tui/tui.c: Update.
4514         * typeprint.c: Update.
4515         * unittests/cli-utils-selftests.c: Update.
4516         * unittests/parse-connection-spec-selftests.c: Update.
4517         * valops.c: Update.
4518         * valprint.c: Update.
4519         * value.c: Update.
4520         * varobj.c: Update.
4521         * windows-nat.c: Update.
4522         * x86-linux-nat.c: Update.
4523         * xml-support.c: Update.
4524
4525 2019-04-08  Tom Tromey  <tom@tromey.com>
4526
4527         * xml-support.c: Use C++ exception handling.
4528         * x86-linux-nat.c: Use C++ exception handling.
4529         * windows-nat.c: Use C++ exception handling.
4530         * varobj.c: Use C++ exception handling.
4531         * value.c: Use C++ exception handling.
4532         * valprint.c: Use C++ exception handling.
4533         * valops.c: Use C++ exception handling.
4534         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4535         handling.
4536         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4537         * typeprint.c: Use C++ exception handling.
4538         * tui/tui.c: Use C++ exception handling.
4539         * tracefile-tfile.c: Use C++ exception handling.
4540         * top.c: Use C++ exception handling.
4541         * thread.c: Use C++ exception handling.
4542         * target.c: Use C++ exception handling.
4543         * symmisc.c: Use C++ exception handling.
4544         * symfile-mem.c: Use C++ exception handling.
4545         * stack.c: Use C++ exception handling.
4546         * sparc64-linux-tdep.c: Use C++ exception handling.
4547         * solib.c: Use C++ exception handling.
4548         * solib-svr4.c: Use C++ exception handling.
4549         * solib-spu.c: Use C++ exception handling.
4550         * solib-frv.c: Use C++ exception handling.
4551         * solib-dsbt.c: Use C++ exception handling.
4552         * selftest-arch.c: Use C++ exception handling.
4553         * s390-tdep.c: Use C++ exception handling.
4554         * rust-lang.c: Use C++ exception handling.
4555         * rust-exp.y: Use C++ exception handling.
4556         * rs6000-tdep.c: Use C++ exception handling.
4557         * rs6000-aix-tdep.c: Use C++ exception handling.
4558         * riscv-tdep.c: Use C++ exception handling.
4559         * remote.c: Use C++ exception handling.
4560         * remote-fileio.c: Use C++ exception handling.
4561         * record-full.c: Use C++ exception handling.
4562         * record-btrace.c: Use C++ exception handling.
4563         * python/python.c: Use C++ exception handling.
4564         * python/py-value.c: Use C++ exception handling.
4565         * python/py-utils.c: Use C++ exception handling.
4566         * python/py-unwind.c: Use C++ exception handling.
4567         * python/py-type.c: Use C++ exception handling.
4568         * python/py-symbol.c: Use C++ exception handling.
4569         * python/py-record.c: Use C++ exception handling.
4570         * python/py-record-btrace.c: Use C++ exception handling.
4571         * python/py-progspace.c: Use C++ exception handling.
4572         * python/py-prettyprint.c: Use C++ exception handling.
4573         * python/py-param.c: Use C++ exception handling.
4574         * python/py-objfile.c: Use C++ exception handling.
4575         * python/py-linetable.c: Use C++ exception handling.
4576         * python/py-lazy-string.c: Use C++ exception handling.
4577         * python/py-infthread.c: Use C++ exception handling.
4578         * python/py-inferior.c: Use C++ exception handling.
4579         * python/py-gdb-readline.c: Use C++ exception handling.
4580         * python/py-framefilter.c: Use C++ exception handling.
4581         * python/py-frame.c: Use C++ exception handling.
4582         * python/py-finishbreakpoint.c: Use C++ exception handling.
4583         * python/py-cmd.c: Use C++ exception handling.
4584         * python/py-breakpoint.c: Use C++ exception handling.
4585         * python/py-arch.c: Use C++ exception handling.
4586         * printcmd.c: Use C++ exception handling.
4587         * ppc-linux-tdep.c: Use C++ exception handling.
4588         * parse.c: Use C++ exception handling.
4589         * p-valprint.c: Use C++ exception handling.
4590         * objc-lang.c: Use C++ exception handling.
4591         * mi/mi-main.c: Use C++ exception handling.
4592         * mi/mi-interp.c: Use C++ exception handling.
4593         * mi/mi-cmd-stack.c: Use C++ exception handling.
4594         * mi/mi-cmd-break.c: Use C++ exception handling.
4595         * main.c: Use C++ exception handling.
4596         * linux-thread-db.c: Use C++ exception handling.
4597         * linux-tdep.c: Use C++ exception handling.
4598         * linux-nat.c: Use C++ exception handling.
4599         * linux-fork.c: Use C++ exception handling.
4600         * linespec.c: Use C++ exception handling.
4601         * language.c: Use C++ exception handling.
4602         * jit.c: Use C++ exception handling.
4603         * infrun.c: Use C++ exception handling.
4604         * infcmd.c: Use C++ exception handling.
4605         * infcall.c: Use C++ exception handling.
4606         * inf-loop.c: Use C++ exception handling.
4607         * i386-tdep.c: Use C++ exception handling.
4608         * i386-linux-tdep.c: Use C++ exception handling.
4609         * guile/scm-value.c: Use C++ exception handling.
4610         * guile/scm-type.c: Use C++ exception handling.
4611         * guile/scm-symtab.c: Use C++ exception handling.
4612         * guile/scm-symbol.c: Use C++ exception handling.
4613         * guile/scm-pretty-print.c: Use C++ exception handling.
4614         * guile/scm-ports.c: Use C++ exception handling.
4615         * guile/scm-param.c: Use C++ exception handling.
4616         * guile/scm-math.c: Use C++ exception handling.
4617         * guile/scm-lazy-string.c: Use C++ exception handling.
4618         * guile/scm-frame.c: Use C++ exception handling.
4619         * guile/scm-disasm.c: Use C++ exception handling.
4620         * guile/scm-cmd.c: Use C++ exception handling.
4621         * guile/scm-breakpoint.c: Use C++ exception handling.
4622         * guile/scm-block.c: Use C++ exception handling.
4623         * guile/guile-internal.h: Use C++ exception handling.
4624         * gnu-v3-abi.c: Use C++ exception handling.
4625         * gdbtypes.c: Use C++ exception handling.
4626         * frame.c: Use C++ exception handling.
4627         * frame-unwind.c: Use C++ exception handling.
4628         * fbsd-tdep.c: Use C++ exception handling.
4629         * f-valprint.c: Use C++ exception handling.
4630         * exec.c: Use C++ exception handling.
4631         * event-top.c: Use C++ exception handling.
4632         * event-loop.c: Use C++ exception handling.
4633         * eval.c: Use C++ exception handling.
4634         * dwarf2read.c: Use C++ exception handling.
4635         * dwarf2loc.c: Use C++ exception handling.
4636         * dwarf2-frame.c: Use C++ exception handling.
4637         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4638         * dwarf-index-write.c: Use C++ exception handling.
4639         * dwarf-index-cache.c: Use C++ exception handling.
4640         * dtrace-probe.c: Use C++ exception handling.
4641         * disasm-selftests.c: Use C++ exception handling.
4642         * darwin-nat.c: Use C++ exception handling.
4643         * cp-valprint.c: Use C++ exception handling.
4644         * cp-support.c: Use C++ exception handling.
4645         * cp-abi.c: Use C++ exception handling.
4646         * corelow.c: Use C++ exception handling.
4647         * completer.c: Use C++ exception handling.
4648         * compile/compile-object-run.c: Use C++ exception handling.
4649         * compile/compile-object-load.c: Use C++ exception handling.
4650         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4651         * compile/compile-c-symbols.c: Use C++ exception handling.
4652         * common/selftest.c: Use C++ exception handling.
4653         * common/new-op.c: Use C++ exception handling.
4654         * cli/cli-script.c: Use C++ exception handling.
4655         * cli/cli-interp.c: Use C++ exception handling.
4656         * cli/cli-cmds.c: Use C++ exception handling.
4657         * c-varobj.c: Use C++ exception handling.
4658         * btrace.c: Use C++ exception handling.
4659         * breakpoint.c: Use C++ exception handling.
4660         * break-catch-throw.c: Use C++ exception handling.
4661         * arch-utils.c: Use C++ exception handling.
4662         * amd64-tdep.c: Use C++ exception handling.
4663         * ada-valprint.c: Use C++ exception handling.
4664         * ada-typeprint.c: Use C++ exception handling.
4665         * ada-lang.c: Use C++ exception handling.
4666         * aarch64-tdep.c: Use C++ exception handling.
4667
4668 2019-04-08  Tom Tromey  <tom@tromey.com>
4669
4670         * xml-support.c (gdb_xml_parser::parse): Update.
4671         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4672         * value.c (show_convenience): Update.
4673         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4674         (test_parse_flags_qcs): Update.
4675         * thread.c (thr_try_catch_cmd): Update.
4676         * target.c (target_translate_tls_address): Update.
4677         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4678         (info_frame_command_core, frame_apply_command_count): Update.
4679         * rust-exp.y (rust_lex_exception_test): Update.
4680         * riscv-tdep.c (riscv_print_one_register_info): Update.
4681         * remote.c (remote_target::enable_btrace): Update.
4682         * record-btrace.c (record_btrace_enable_warn): Update.
4683         * python/py-utils.c (gdbpy_convert_exception): Update.
4684         * printcmd.c (do_one_display, print_variable_and_value): Update.
4685         * mi/mi-main.c (mi_print_exception): Update.
4686         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4687         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4688         * linux-nat.c (linux_nat_target::attach): Update.
4689         * linux-fork.c (class scoped_switch_fork_info): Update.
4690         * infrun.c (displaced_step_prepare): Update.
4691         * infcall.c (call_function_by_hand_dummy): Update.
4692         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4693         * gnu-v3-abi.c (print_one_vtable): Update.
4694         * frame.c (get_prev_frame_always): Update.
4695         * f-valprint.c (info_common_command_for_block): Update.
4696         * exec.c (try_open_exec_file): Update.
4697         * exceptions.c (print_exception, exception_print)
4698         (exception_fprintf, exception_print_same): Update.
4699         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4700         * dwarf-index-cache.c (index_cache::store)
4701         (index_cache::lookup_gdb_index): Update.
4702         * darwin-nat.c (maybe_cache_shell): Update.
4703         * cp-valprint.c (cp_print_value_fields): Update.
4704         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4705         (gcc_cplus_symbol_address): Update.
4706         * compile/compile-c-symbols.c (gcc_convert_symbol)
4707         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4708         * common/selftest.c: Update.
4709         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4710         a std::string.
4711         (exception_try_scope_entry, exception_try_scope_exit): Don't
4712         declare.
4713         (struct exception_try_scope): Remove.
4714         (TRY): Don't use exception_try_scope.
4715         (struct gdb_exception): Add constructor, operator=.
4716         <what>: New method.
4717         (struct gdb_exception_RETURN_MASK_ALL)
4718         (struct gdb_exception_RETURN_MASK_ERROR)
4719         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4720         (struct gdb_quit_bad_alloc): Update.
4721         * common/common-exceptions.c (exception_none): Change
4722         initializer.
4723         (struct catcher) <state, exception>: Initialize inline.
4724         <prev>: Remove member.
4725         (current_catcher): Remove.
4726         (catchers): New global.
4727         (exceptions_state_mc_init): Simplify.
4728         (catcher_pop): Remove.
4729         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4730         (try_scope_depth, exception_try_scope_entry)
4731         (exception_try_scope_exit): Remove.
4732         (throw_exception_sjlj): Update.
4733         (exception_messages, exception_messages_size): Remove.
4734         (throw_it): Simplify.
4735         (gdb_exception_sliced_copy): Remove.
4736         (throw_exception_cxx): Update.
4737         * cli/cli-script.c (script_from_file): Update.
4738         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4739         Update.
4740         * ada-valprint.c (ada_val_print): Update.
4741         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4742         (create_excep_cond_exprs): Update.
4743
4744 2019-04-08  Tom Tromey  <tom@tromey.com>
4745
4746         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4747         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4748         (TRY, CATCH, END_CATCH): Remove some definitions.
4749         * common/common-exceptions.c: Don't use GDB_XCPT.
4750         (catcher_list_size): Remove.
4751         (throw_exception, throw_it): Simplify.
4752
4753 2019-04-05  Tom Tromey  <tom@tromey.com>
4754
4755         Revert the header-sorting patch.
4756         * ft32-tdep.c: Revert.
4757         * frv-tdep.c: Revert.
4758         * frv-linux-tdep.c: Revert.
4759         * frame.c: Revert.
4760         * frame-unwind.c: Revert.
4761         * frame-base.c: Revert.
4762         * fork-child.c: Revert.
4763         * findvar.c: Revert.
4764         * findcmd.c: Revert.
4765         * filesystem.c: Revert.
4766         * filename-seen-cache.h: Revert.
4767         * filename-seen-cache.c: Revert.
4768         * fbsd-tdep.c: Revert.
4769         * fbsd-nat.h: Revert.
4770         * fbsd-nat.c: Revert.
4771         * f-valprint.c: Revert.
4772         * f-typeprint.c: Revert.
4773         * f-lang.c: Revert.
4774         * extension.h: Revert.
4775         * extension.c: Revert.
4776         * extension-priv.h: Revert.
4777         * expprint.c: Revert.
4778         * exec.h: Revert.
4779         * exec.c: Revert.
4780         * exceptions.c: Revert.
4781         * event-top.c: Revert.
4782         * event-loop.c: Revert.
4783         * eval.c: Revert.
4784         * elfread.c: Revert.
4785         * dwarf2read.h: Revert.
4786         * dwarf2read.c: Revert.
4787         * dwarf2loc.c: Revert.
4788         * dwarf2expr.h: Revert.
4789         * dwarf2expr.c: Revert.
4790         * dwarf2-frame.c: Revert.
4791         * dwarf2-frame-tailcall.c: Revert.
4792         * dwarf-index-write.h: Revert.
4793         * dwarf-index-write.c: Revert.
4794         * dwarf-index-common.c: Revert.
4795         * dwarf-index-cache.h: Revert.
4796         * dwarf-index-cache.c: Revert.
4797         * dummy-frame.c: Revert.
4798         * dtrace-probe.c: Revert.
4799         * disasm.h: Revert.
4800         * disasm.c: Revert.
4801         * disasm-selftests.c: Revert.
4802         * dictionary.c: Revert.
4803         * dicos-tdep.c: Revert.
4804         * demangle.c: Revert.
4805         * dcache.h: Revert.
4806         * dcache.c: Revert.
4807         * darwin-nat.h: Revert.
4808         * darwin-nat.c: Revert.
4809         * darwin-nat-info.c: Revert.
4810         * d-valprint.c: Revert.
4811         * d-namespace.c: Revert.
4812         * d-lang.c: Revert.
4813         * ctf.c: Revert.
4814         * csky-tdep.c: Revert.
4815         * csky-linux-tdep.c: Revert.
4816         * cris-tdep.c: Revert.
4817         * cris-linux-tdep.c: Revert.
4818         * cp-valprint.c: Revert.
4819         * cp-support.c: Revert.
4820         * cp-namespace.c: Revert.
4821         * cp-abi.c: Revert.
4822         * corelow.c: Revert.
4823         * corefile.c: Revert.
4824         * continuations.c: Revert.
4825         * completer.h: Revert.
4826         * completer.c: Revert.
4827         * complaints.c: Revert.
4828         * coffread.c: Revert.
4829         * coff-pe-read.c: Revert.
4830         * cli-out.h: Revert.
4831         * cli-out.c: Revert.
4832         * charset.c: Revert.
4833         * c-varobj.c: Revert.
4834         * c-valprint.c: Revert.
4835         * c-typeprint.c: Revert.
4836         * c-lang.c: Revert.
4837         * buildsym.c: Revert.
4838         * buildsym-legacy.c: Revert.
4839         * build-id.h: Revert.
4840         * build-id.c: Revert.
4841         * btrace.c: Revert.
4842         * bsd-uthread.c: Revert.
4843         * breakpoint.h: Revert.
4844         * breakpoint.c: Revert.
4845         * break-catch-throw.c: Revert.
4846         * break-catch-syscall.c: Revert.
4847         * break-catch-sig.c: Revert.
4848         * blockframe.c: Revert.
4849         * block.c: Revert.
4850         * bfin-tdep.c: Revert.
4851         * bfin-linux-tdep.c: Revert.
4852         * bfd-target.c: Revert.
4853         * bcache.c: Revert.
4854         * ax-general.c: Revert.
4855         * ax-gdb.h: Revert.
4856         * ax-gdb.c: Revert.
4857         * avr-tdep.c: Revert.
4858         * auxv.c: Revert.
4859         * auto-load.c: Revert.
4860         * arm-wince-tdep.c: Revert.
4861         * arm-tdep.c: Revert.
4862         * arm-symbian-tdep.c: Revert.
4863         * arm-pikeos-tdep.c: Revert.
4864         * arm-obsd-tdep.c: Revert.
4865         * arm-nbsd-tdep.c: Revert.
4866         * arm-nbsd-nat.c: Revert.
4867         * arm-linux-tdep.c: Revert.
4868         * arm-linux-nat.c: Revert.
4869         * arm-fbsd-tdep.c: Revert.
4870         * arm-fbsd-nat.c: Revert.
4871         * arm-bsd-tdep.c: Revert.
4872         * arch-utils.c: Revert.
4873         * arc-tdep.c: Revert.
4874         * arc-newlib-tdep.c: Revert.
4875         * annotate.h: Revert.
4876         * annotate.c: Revert.
4877         * amd64-windows-tdep.c: Revert.
4878         * amd64-windows-nat.c: Revert.
4879         * amd64-tdep.c: Revert.
4880         * amd64-sol2-tdep.c: Revert.
4881         * amd64-obsd-tdep.c: Revert.
4882         * amd64-obsd-nat.c: Revert.
4883         * amd64-nbsd-tdep.c: Revert.
4884         * amd64-nbsd-nat.c: Revert.
4885         * amd64-nat.c: Revert.
4886         * amd64-linux-tdep.c: Revert.
4887         * amd64-linux-nat.c: Revert.
4888         * amd64-fbsd-tdep.c: Revert.
4889         * amd64-fbsd-nat.c: Revert.
4890         * amd64-dicos-tdep.c: Revert.
4891         * amd64-darwin-tdep.c: Revert.
4892         * amd64-bsd-nat.c: Revert.
4893         * alpha-tdep.c: Revert.
4894         * alpha-obsd-tdep.c: Revert.
4895         * alpha-nbsd-tdep.c: Revert.
4896         * alpha-mdebug-tdep.c: Revert.
4897         * alpha-linux-tdep.c: Revert.
4898         * alpha-linux-nat.c: Revert.
4899         * alpha-bsd-tdep.c: Revert.
4900         * alpha-bsd-nat.c: Revert.
4901         * aix-thread.c: Revert.
4902         * agent.c: Revert.
4903         * addrmap.c: Revert.
4904         * ada-varobj.c: Revert.
4905         * ada-valprint.c: Revert.
4906         * ada-typeprint.c: Revert.
4907         * ada-tasks.c: Revert.
4908         * ada-lang.c: Revert.
4909         * aarch64-tdep.c: Revert.
4910         * aarch64-ravenscar-thread.c: Revert.
4911         * aarch64-newlib-tdep.c: Revert.
4912         * aarch64-linux-tdep.c: Revert.
4913         * aarch64-linux-nat.c: Revert.
4914         * aarch64-fbsd-tdep.c: Revert.
4915         * aarch64-fbsd-nat.c: Revert.
4916         * aarch32-linux-nat.c: Revert.
4917
4918 2019-04-05  Tom Tromey  <tom@tromey.com>
4919
4920         * ft32-tdep.c: Sort headers.
4921         * frv-tdep.c: Sort headers.
4922         * frv-linux-tdep.c: Sort headers.
4923         * frame.c: Sort headers.
4924         * frame-unwind.c: Sort headers.
4925         * frame-base.c: Sort headers.
4926         * fork-child.c: Sort headers.
4927         * findvar.c: Sort headers.
4928         * findcmd.c: Sort headers.
4929         * filesystem.c: Sort headers.
4930         * filename-seen-cache.h: Sort headers.
4931         * filename-seen-cache.c: Sort headers.
4932         * fbsd-tdep.c: Sort headers.
4933         * fbsd-nat.h: Sort headers.
4934         * fbsd-nat.c: Sort headers.
4935         * f-valprint.c: Sort headers.
4936         * f-typeprint.c: Sort headers.
4937         * f-lang.c: Sort headers.
4938         * extension.h: Sort headers.
4939         * extension.c: Sort headers.
4940         * extension-priv.h: Sort headers.
4941         * expprint.c: Sort headers.
4942         * exec.h: Sort headers.
4943         * exec.c: Sort headers.
4944         * exceptions.c: Sort headers.
4945         * event-top.c: Sort headers.
4946         * event-loop.c: Sort headers.
4947         * eval.c: Sort headers.
4948         * elfread.c: Sort headers.
4949         * dwarf2read.h: Sort headers.
4950         * dwarf2read.c: Sort headers.
4951         * dwarf2loc.c: Sort headers.
4952         * dwarf2expr.h: Sort headers.
4953         * dwarf2expr.c: Sort headers.
4954         * dwarf2-frame.c: Sort headers.
4955         * dwarf2-frame-tailcall.c: Sort headers.
4956         * dwarf-index-write.h: Sort headers.
4957         * dwarf-index-write.c: Sort headers.
4958         * dwarf-index-common.c: Sort headers.
4959         * dwarf-index-cache.h: Sort headers.
4960         * dwarf-index-cache.c: Sort headers.
4961         * dummy-frame.c: Sort headers.
4962         * dtrace-probe.c: Sort headers.
4963         * disasm.h: Sort headers.
4964         * disasm.c: Sort headers.
4965         * disasm-selftests.c: Sort headers.
4966         * dictionary.c: Sort headers.
4967         * dicos-tdep.c: Sort headers.
4968         * demangle.c: Sort headers.
4969         * dcache.h: Sort headers.
4970         * dcache.c: Sort headers.
4971         * darwin-nat.h: Sort headers.
4972         * darwin-nat.c: Sort headers.
4973         * darwin-nat-info.c: Sort headers.
4974         * d-valprint.c: Sort headers.
4975         * d-namespace.c: Sort headers.
4976         * d-lang.c: Sort headers.
4977         * ctf.c: Sort headers.
4978         * csky-tdep.c: Sort headers.
4979         * csky-linux-tdep.c: Sort headers.
4980         * cris-tdep.c: Sort headers.
4981         * cris-linux-tdep.c: Sort headers.
4982         * cp-valprint.c: Sort headers.
4983         * cp-support.c: Sort headers.
4984         * cp-namespace.c: Sort headers.
4985         * cp-abi.c: Sort headers.
4986         * corelow.c: Sort headers.
4987         * corefile.c: Sort headers.
4988         * continuations.c: Sort headers.
4989         * completer.h: Sort headers.
4990         * completer.c: Sort headers.
4991         * complaints.c: Sort headers.
4992         * coffread.c: Sort headers.
4993         * coff-pe-read.c: Sort headers.
4994         * cli-out.h: Sort headers.
4995         * cli-out.c: Sort headers.
4996         * charset.c: Sort headers.
4997         * c-varobj.c: Sort headers.
4998         * c-valprint.c: Sort headers.
4999         * c-typeprint.c: Sort headers.
5000         * c-lang.c: Sort headers.
5001         * buildsym.c: Sort headers.
5002         * buildsym-legacy.c: Sort headers.
5003         * build-id.h: Sort headers.
5004         * build-id.c: Sort headers.
5005         * btrace.c: Sort headers.
5006         * bsd-uthread.c: Sort headers.
5007         * breakpoint.h: Sort headers.
5008         * breakpoint.c: Sort headers.
5009         * break-catch-throw.c: Sort headers.
5010         * break-catch-syscall.c: Sort headers.
5011         * break-catch-sig.c: Sort headers.
5012         * blockframe.c: Sort headers.
5013         * block.c: Sort headers.
5014         * bfin-tdep.c: Sort headers.
5015         * bfin-linux-tdep.c: Sort headers.
5016         * bfd-target.c: Sort headers.
5017         * bcache.c: Sort headers.
5018         * ax-general.c: Sort headers.
5019         * ax-gdb.h: Sort headers.
5020         * ax-gdb.c: Sort headers.
5021         * avr-tdep.c: Sort headers.
5022         * auxv.c: Sort headers.
5023         * auto-load.c: Sort headers.
5024         * arm-wince-tdep.c: Sort headers.
5025         * arm-tdep.c: Sort headers.
5026         * arm-symbian-tdep.c: Sort headers.
5027         * arm-pikeos-tdep.c: Sort headers.
5028         * arm-obsd-tdep.c: Sort headers.
5029         * arm-nbsd-tdep.c: Sort headers.
5030         * arm-nbsd-nat.c: Sort headers.
5031         * arm-linux-tdep.c: Sort headers.
5032         * arm-linux-nat.c: Sort headers.
5033         * arm-fbsd-tdep.c: Sort headers.
5034         * arm-fbsd-nat.c: Sort headers.
5035         * arm-bsd-tdep.c: Sort headers.
5036         * arch-utils.c: Sort headers.
5037         * arc-tdep.c: Sort headers.
5038         * arc-newlib-tdep.c: Sort headers.
5039         * annotate.h: Sort headers.
5040         * annotate.c: Sort headers.
5041         * amd64-windows-tdep.c: Sort headers.
5042         * amd64-windows-nat.c: Sort headers.
5043         * amd64-tdep.c: Sort headers.
5044         * amd64-sol2-tdep.c: Sort headers.
5045         * amd64-obsd-tdep.c: Sort headers.
5046         * amd64-obsd-nat.c: Sort headers.
5047         * amd64-nbsd-tdep.c: Sort headers.
5048         * amd64-nbsd-nat.c: Sort headers.
5049         * amd64-nat.c: Sort headers.
5050         * amd64-linux-tdep.c: Sort headers.
5051         * amd64-linux-nat.c: Sort headers.
5052         * amd64-fbsd-tdep.c: Sort headers.
5053         * amd64-fbsd-nat.c: Sort headers.
5054         * amd64-dicos-tdep.c: Sort headers.
5055         * amd64-darwin-tdep.c: Sort headers.
5056         * amd64-bsd-nat.c: Sort headers.
5057         * alpha-tdep.c: Sort headers.
5058         * alpha-obsd-tdep.c: Sort headers.
5059         * alpha-nbsd-tdep.c: Sort headers.
5060         * alpha-mdebug-tdep.c: Sort headers.
5061         * alpha-linux-tdep.c: Sort headers.
5062         * alpha-linux-nat.c: Sort headers.
5063         * alpha-bsd-tdep.c: Sort headers.
5064         * alpha-bsd-nat.c: Sort headers.
5065         * aix-thread.c: Sort headers.
5066         * agent.c: Sort headers.
5067         * addrmap.c: Sort headers.
5068         * ada-varobj.c: Sort headers.
5069         * ada-valprint.c: Sort headers.
5070         * ada-typeprint.c: Sort headers.
5071         * ada-tasks.c: Sort headers.
5072         * ada-lang.c: Sort headers.
5073         * aarch64-tdep.c: Sort headers.
5074         * aarch64-ravenscar-thread.c: Sort headers.
5075         * aarch64-newlib-tdep.c: Sort headers.
5076         * aarch64-linux-tdep.c: Sort headers.
5077         * aarch64-linux-nat.c: Sort headers.
5078         * aarch64-fbsd-tdep.c: Sort headers.
5079         * aarch64-fbsd-nat.c: Sort headers.
5080         * aarch32-linux-nat.c: Sort headers.
5081
5082 2019-04-04  Tom Tromey  <tom@tromey.com>
5083
5084         * varobj.c (varobj_create): Update.
5085         * rust-exp.y (struct rust_parser) <update_innermost_block,
5086         lookup_symbol>: New methods.
5087         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5088         Rename.
5089         (rust_parser::rust_lookup_type)
5090         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5091         * printcmd.c (display_command, do_one_display): Update.
5092         * parser-defs.h (struct parser_state) <parser_state>: Add
5093         "tracker" parameter.
5094         (block_tracker): New member.
5095         (class innermost_block_tracker) <innermost_block_tracker>: Add
5096         "types" parameter.
5097         <reset>: Remove method.
5098         (innermost_block): Don't declare.
5099         (null_post_parser): Update.
5100         * parse.c (innermost_block): Remove global.
5101         (write_dollar_variable): Update.
5102         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5103         Remove "tracker_types" parameter.
5104         (parse_expression): Add "tracker" parameter.
5105         (parse_expression_for_completion): Update.
5106         (null_post_parser): Add "tracker" parameter.
5107         * p-exp.y: Update rules.
5108         * m2-exp.y: Update rules.
5109         * language.h (struct language_defn) <la_post_parser>: Add
5110         "tracker" parameter.
5111         * go-exp.y: Update rules.
5112         * f-exp.y: Update rules.
5113         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5114         parameter.
5115         * d-exp.y: Update rules.
5116         * c-exp.y: Update rules.
5117         * breakpoint.c (set_breakpoint_condition): Create an
5118         innermost_block_tracker.
5119         (watch_command_1): Likewise.
5120         * ada-lang.c (resolve): Add "tracker" parameter.
5121         (resolve_subexp): Likewise.
5122         * ada-exp.y (write_var_from_sym): Update.
5123
5124 2019-04-04  Tom Tromey  <tom@tromey.com>
5125
5126         * type-stack.h: New file.
5127         * type-stack.c: New file.
5128         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5129         type-stack.h.
5130         (insert_into_type_stack, insert_type, push_type, push_type_int)
5131         (insert_type_address_space, pop_type, pop_type_int)
5132         (pop_typelist, pop_type_stack, append_type_stack)
5133         (push_type_stack, get_type_stack, push_typelist)
5134         (follow_type_instance_flags, follow_types): Don't declare.
5135         * parse.c (type_stack): Remove global.
5136         (parse_exp_in_context): Update.
5137         (insert_into_type_stack, insert_type, push_type, push_type_int)
5138         (insert_type_address_space, pop_type, pop_type_int)
5139         (pop_typelist, pop_type_stack, append_type_stack)
5140         (push_type_stack, get_type_stack, push_typelist)
5141         (follow_type_instance_flags, follow_types): Remove (moved to
5142         type-stack.c).
5143         * f-exp.y (type_stack): New global.
5144         Update rules.
5145         (push_kind_type, f_parse): Update.
5146         * d-exp.y (type_stack): New global.
5147         Update rules.
5148         (d_parse): Update.
5149         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5150         Update rules.
5151         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5152         (HFILES_NO_SRCDIR): Add type-stack.h.
5153
5154 2019-04-04  Tom Tromey  <tom@tromey.com>
5155
5156         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5157         (rust_parser::convert_ast_to_expression, rust_parse)
5158         (rust_lex_test_completion, rust_lex_tests): Update.
5159         * parser-defs.h (struct expr_completion_state): New.
5160         (struct parser_state) <parser_state>: Add completion parameter.
5161         <mark_struct_expression, mark_completion_tag>: New methods.
5162         <parse_completion, m_completion_state>: New members.
5163         (prefixify_expression, null_post_parser): Update.
5164         (mark_struct_expression, mark_completion_tag): Don't declare.
5165         * parse.c (parse_completion, expout_last_struct)
5166         (expout_tag_completion_type, expout_completion_name): Remove
5167         globals.
5168         (parser_state::mark_struct_expression)
5169         (parser_state::mark_completion_tag): Now methods.
5170         (prefixify_expression): Add last_struct parameter.
5171         (prefixify_subexp): Likewise.
5172         (parse_exp_1): Update.
5173         (parse_exp_in_context): Add cstate parameter.  Update.
5174         (parse_expression_for_completion): Create an
5175         expr_completion_state.
5176         (null_post_parser): Add "completion" parameter.
5177         * p-exp.y: Update rules.
5178         (yylex): Update.
5179         * language.h (struct language_defn) <la_post_parser>: Add
5180         "completing" parameter.
5181         * go-exp.y: Update rules.
5182         (lex_one_token): Update.
5183         * expression.h (parse_completion): Don't declare.
5184         * d-exp.y: Update rules.
5185         (lex_one_token): Update rules.
5186         * c-exp.y: Update rules.
5187         (lex_one_token): Update.
5188         * ada-lang.c (resolve): Add "parse_completion" parameter.
5189         (resolve_subexp): Likewise.
5190         (ada_resolve_function): Likewise.
5191
5192 2019-04-04  Tom Tromey  <tom@tromey.com>
5193
5194         * parser-defs.h (struct parser_state) <start_arglist,
5195         end_arglist>: New methods.
5196         <arglist_len, m_funcall_chain>: New members.
5197         (arglist_len, start_arglist, end_arglist): Don't declare.
5198         * parse.c (arglist_len, funcall_chain): Remove global.
5199         (start_arglist, end_arglist): Remove functions.
5200         (parse_exp_in_context): Update.
5201         * p-exp.y: Update rules.
5202         * m2-exp.y: Update rules.
5203         * go-exp.y: Update rules.
5204         * f-exp.y: Update rules.
5205         * d-exp.y: Update rules.
5206         * c-exp.y: Update rules.
5207
5208 2019-04-04  Tom Tromey  <tom@tromey.com>
5209
5210         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5211         lex_operator, push_back>: New methods.
5212         Update all rules.
5213         (rust_parser::lex_hex, lex_escape): Rename and update.
5214         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5215         (rust_parser::lex_operator): Rename and update.
5216         (rust_parser::lex_number, rustyylex, rustyyerror)
5217         (rust_lex_test_init, rust_lex_test_sequence)
5218         (rust_lex_test_push_back, rust_lex_tests): Update.
5219         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5220         parameter.
5221         <lexptr, prev_lexptr>: New members.
5222         (lexptr, prev_lexptr): Don't declare.
5223         * parse.c (lexptr, prev_lexptr): Remove globals.
5224         (parse_exp_in_context): Update.
5225         * p-exp.y (yylex, yyerror): Update.
5226         * m2-exp.y (parse_number, yylex, yyerror): Update.
5227         * go-exp.y (lex_one_token, yyerror): Update.
5228         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5229         * d-exp.y (lex_one_token, yyerror): Update.
5230         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5231         (lex_one_token, yyerror): Update.
5232         * ada-lex.l (YY_INPUT): Update.
5233         (rewind_to_char): Update.
5234         * ada-exp.y (yyerror): Update.
5235
5236 2019-04-04  Tom Tromey  <tom@tromey.com>
5237
5238         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5239         * parser-defs.h (struct parser_state) <parser_state>: Add new
5240         parameter.
5241         <comma_terminates>: New member.
5242         (comma_terminates): Don't declare global.
5243         * parse.c (comma_terminates): Remove global.
5244         (parse_exp_in_context): Update.
5245         * p-exp.y (yylex): Update.
5246         * m2-exp.y (yylex): Update.
5247         * go-exp.y (lex_one_token): Update.
5248         * f-exp.y (yylex): Update.
5249         * d-exp.y (lex_one_token): Update.
5250         * c-exp.y (lex_one_token): Update.
5251         * ada-lex.l: Update.
5252
5253 2019-04-04  Tom Tromey  <tom@tromey.com>
5254
5255         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5256         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5257         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5258         * parser-defs.h (paren_depth): Don't declare.
5259         * parse.c (paren_depth): Remove global.
5260         (parse_exp_in_context): Update.
5261         * p-exp.y (paren_depth): New global.
5262         (pascal_parse): Initialize it.
5263         * m2-exp.y (paren_depth): New global.
5264         (m2_parse): Initialize it.
5265         * go-exp.y (paren_depth): New global.
5266         (go_parse): Initialize it.
5267         * f-exp.y (paren_depth): New global.
5268         (f_parse): Initialize it.
5269         * d-exp.y (paren_depth): New global.
5270         (d_parse): Initialize it.
5271         * c-exp.y (paren_depth): New global.
5272         (c_parse): Initialize it.
5273         * ada-lex.l (paren_depth): New global.
5274         (lexer_init): Initialize it.
5275
5276 2019-04-04  Tom Tromey  <tom@tromey.com>
5277
5278         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5279         (rust_parser::convert_ast_to_type)
5280         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5281         * parser-defs.h (struct parser_state) <parser_state>: Add
5282         parameters.  Initialize new members.
5283         <expression_context_block, expression_context_pc>: New members.
5284         * parse.c (expression_context_block, expression_context_pc):
5285         Remove globals.
5286         (parse_exp_in_context): Update.
5287         * p-exp.y: Update all rules.
5288         (yylex): Update.
5289         * m2-exp.y: Update all rules.
5290         (yylex): Update.
5291         * go-exp.y (yylex): Update.
5292         * f-exp.y (yylex): Update.
5293         * d-exp.y: Update all rules.
5294         (yylex): Update.
5295         * c-exp.y: Update all rules.
5296         (lex_one_token, classify_name, yylex, c_parse): Update.
5297         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5298
5299 2019-04-04  Tom Tromey  <tom@tromey.com>
5300
5301         * gdbarch.h, gdbarch.c: Rebuild.
5302         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5303         * stap-probe.h:
5304         (struct stap_parse_info): Replace "parser_state" with
5305         "expr_builder".
5306         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5307         (parser_state): New class.
5308         * parse.c (expr_builder): Rename.
5309         (expr_builder::release): Rename.
5310         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5311         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5312         (write_exp_elt_longcst, write_exp_elt_floatcst)
5313         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5314         (write_exp_string_vector, write_exp_bitstring)
5315         (write_exp_msymbol, mark_struct_expression)
5316         (write_dollar_variable)
5317         (insert_type_address_space, increase_expout_size): Replace
5318         "parser_state" with "expr_builder".
5319         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5320         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5321         "parser_state" with "expr_builder".
5322
5323 2019-04-04  Tom Tromey  <tom@tromey.com>
5324
5325         * rust-exp.y: Replace "parse_language" with method call.
5326         * p-exp.y:
5327         (yylex): Replace "parse_language" with method call.
5328         * m2-exp.y:
5329         (yylex): Replace "parse_language" with method call.
5330         * go-exp.y (classify_name): Replace "parse_language" with method
5331         call.
5332         * f-exp.y (yylex): Replace "parse_language" with method call.
5333         * d-exp.y (lex_one_token): Replace "parse_language" with method
5334         call.
5335         * c-exp.y:
5336         (lex_one_token, classify_name, yylex): Replace "parse_language"
5337         with method call.
5338         * ada-exp.y (find_primitive_type, type_char)
5339         (type_system_address): Replace "parse_language" with method call.
5340
5341 2019-04-04  Tom Tromey  <tom@tromey.com>
5342
5343         * rust-exp.y: Replace "parse_gdbarch" with method call.
5344         * parse.c (write_dollar_variable, insert_type_address_space):
5345         Replace "parse_gdbarch" with method call.
5346         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5347         call.
5348         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5349         call.
5350         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5351         "parse_gdbarch" with method call.
5352         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5353         with method call.
5354         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5355         "parse_gdbarch" with method call.
5356         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5357         "parse_gdbarch" with method call.
5358         * c-exp.y (parse_type, parse_number, classify_name): Replace
5359         "parse_gdbarch" with method call.
5360         * ada-lex.l: Replace "parse_gdbarch" with method call.
5361         * ada-exp.y (parse_type, find_primitive_type, type_char)
5362         (type_system_address): Replace "parse_gdbarch" with method call.
5363
5364 2019-04-04  Tom Tromey  <tom@tromey.com>
5365
5366         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5367         * stap-probe.c (stap_parse_argument): Update.
5368         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5369         initial_size parameter.
5370         * rust-exp.y (rust_lex_tests): Update.
5371         * parse.c (parser_state): Update.
5372         (parse_exp_in_context): Update.
5373         * parser-defs.h (struct parser_state) <parser_state>: Remove
5374         "initial_size" parameter.
5375
5376 2019-04-04  Tom Tromey  <tom@tromey.com>
5377
5378         * parser-defs.h (increase_expout_size): Don't declare.
5379         * parse.c (increase_expout_size): Now static.
5380
5381 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5382
5383         * gnu-nat.c (gnu_nat_target::wait): Fix
5384         target_waitstatus_to_string call.
5385
5386 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * eval.c (evaluate_subexp_standard): Handle internal functions
5389         during Fortran function call handling.
5390
5391 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5392
5393         * NEWS: Mention new internal functions.
5394         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5395         (read_base_type): Use dwarf2_init_complex_target_type.
5396         * value.c (creal_internal_fn): New function.
5397         (cimag_internal_fn): New function.
5398         (_initialize_values): Register new internal functions.
5399
5400 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5401
5402         * infrun.c (stop_all_threads): If debug_infrun, always
5403         trace the wait status after wait_one, using
5404         target_waitstatus_to_string and target_pid_to_str.
5405         (handle_inferior_event): Replace various trace of
5406         wait status kind by a single trace.
5407         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5408         wait status kind image by target_waitstatus_to_string.
5409         * target/waitstatus.c (target_waitstatus_to_string): Fix
5410         obsolete comment.
5411
5412 2019-04-01  Tom Tromey  <tromey@adacore.com>
5413
5414         PR symtab/23331:
5415         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5416
5417 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5418             Pedro Alves  <palves@redhat.com>
5419
5420         * top.c (quit_force): Call 'finalize_values'.
5421         * value.c (finalize_values): New function.
5422         * value.h (finalize_values): Declare.
5423
5424 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5425
5426         * NEWS: Announce $_gdb_major and $_gdb_minor.
5427
5428         * top.c (init_gdb_version_vars): New function.
5429         (gdb_init): Call init_gdb_version_vars.
5430
5431 2019-03-29  Tom Tromey  <tromey@adacore.com>
5432
5433         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5434         help text.  Remove dead code.
5435
5436 2019-03-29  Keith Seitz  <keiths@redhat.com>
5437
5438         From Siddhesh Poyarekar:
5439         * f-lang.h (f77_get_upperbound): Return LONGEST.
5440         (f77_get_lowerbound): Likewise.
5441         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5442         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5443         print them.
5444         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5445         plongest to format print it.
5446         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5447         (f77_get_upperbound): Likewise.
5448         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5449         LOWER_BOUND to LONGEST.
5450         (f77_create_arrayprint_offset_tbl): Likewise.
5451
5452 2019-03-29  Keith Seitz  <keiths@redhat.com>
5453
5454         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5455         %s/pulongest for TYPE_LENGTH instead of %d in format
5456         strings.
5457         * ada-typerint.c (ada_print_type): Likewise.
5458         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5459         * compile/compile-c-support.c (generate_register_struct): Likewise.
5460         * gdbtypes.c (recursive_dump_type): Likewise.
5461         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5462         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5463         instead of %d in format strings.
5464         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5465         to std::min to ULONGEST.
5466         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5467         instead of %d in format strings.
5468         * tracepoint.c (info_scope_command): Likewise.
5469         * typeprint.c (print_offset_data::update)
5470         (print_offset_data::finish): Likewise.
5471         * xtensa-tdep.c (xtensa_store_return_value)
5472         (xtensa_push_dummy_call): Likewise.
5473
5474 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5475
5476         * windows-nat.c (display_selector): Fixed format specifications
5477         for 64-bit Cygwin.
5478
5479 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5480
5481         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5482
5483 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5484
5485         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5486         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5487         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5488         (nios2_linux_init_abi): Install it.
5489
5490 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5491
5492         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5493
5494 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5495
5496         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5497
5498 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5499             Tom Tromey  <tromey@adacore.com>
5500
5501         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5502
5503 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5504
5505         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5506         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5507         method to compute the bounds of range types. Also print "[evaluated]"
5508         if the bounds' values come from a dynamic evaluation.
5509
5510 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5513         whitespace when pretty printing is on.
5514
5515 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5516
5517         * ppc-linux-nat.c: Add include.
5518
5519 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5520
5521         * NEWS: Mention AArch64 Pointer Authentication.
5522
5523 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5524
5525         * arm-linux-nat.c: Add include.
5526
5527 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5528
5529         * source-cache.c (source_cache::get_source_lines): Re-read
5530         fullname after calling open_source_file.
5531
5532 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5533
5534         * NEWS: Mention TLS support for FreeBSD.
5535
5536 2019-03-25  Tom Tromey  <tromey@adacore.com>
5537
5538         * minsyms.c (BUNCH_SIZE): Update comment.
5539         (~minimal_symbol_reader): Remove old comment.
5540         (compact_minimal_symbols): Update comment.
5541         (minimal_symbol_reader::install): Remove old comment.  Update
5542         other comments.
5543
5544 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5545
5546         * s390-linux-nat.c: Add include.
5547
5548 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5549
5550         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5551         Call linux_get_hwcap.
5552         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5553         Likewise.
5554         (aarch64_linux_get_hwcap): Remove function.
5555         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5556         declaration.
5557         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5558         linux_get_hwcap.
5559         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5560         * linux-tdep.c (linux_get_hwcap): Add function.
5561         (linux_get_hwcap2): Likewise.
5562         * linux-tdep.h (linux_get_hwcap): Add declaration.
5563         (linux_get_hwcap2): Likewise.
5564         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5565         (ppc_linux_get_hwcap2): Likewise.
5566         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5567         linux_get_hwcap.
5568         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5569         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5570         (ppc_linux_nat_target::read_description): Likewise.
5571         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5572         * s390-linux-nat.c: Likewise.
5573         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5574
5575 2019-03-24  Tom Tromey  <tom@tromey.com>
5576
5577         * ada-lang.c (standard_lookup): Simplify initialization.
5578         (ada_lookup_symbol_nonlocal): Simplify return.
5579         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5580         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5581         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5582         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5583         initialization.
5584         * solib.c (solib_global_lookup): Simplify.
5585         * symtab.c (null_block_symbol): Remove.
5586         (symbol_cache_lookup): Simplify returns.
5587         (lookup_language_this): Simplify returns.
5588         (lookup_symbol_aux): Simplify return.
5589         (lookup_local_symbol): Simplify returns.
5590         (lookup_global_symbol_from_objfile): Simplify return.
5591         (lookup_symbol_in_objfile_symtabs)
5592         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5593         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5594         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5595         * cp-namespace.c (cp_lookup_bare_symbol)
5596         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5597         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5598         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5599         (cp_lookup_symbol_via_imports): Simplify initialization.
5600         (find_symbol_in_baseclass): Likewise.
5601         * symtab.h (null_block_symbol): Remove.
5602         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5603         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5604         (d_lookup_symbol_module): Likewise.
5605         (find_symbol_in_baseclass): Simplify initialization.
5606
5607 2019-03-24  Tom Tromey  <tom@tromey.com>
5608
5609         * expression.h: Don't include symtab.h.
5610         (struct block): Forward declare.
5611
5612 2019-03-24  Tom Tromey  <tom@tromey.com>
5613
5614         * c-exp.y (typebase): Remove casts.
5615         * gdbtypes.c (lookup_unsigned_typename, )
5616         (lookup_signed_typename): Remove cast.
5617         * eval.c (parse_to_comma_and_eval): Remove cast.
5618         * parse.c (write_dollar_variable): Remove cast.
5619         * block.h (struct block) <superblock>: Now const.
5620         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5621         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5622         (map_block): Make "block" const.
5623         * symfile.h (struct quick_symbol_functions)
5624         <map_matching_symbols>: Constify block argument to "callback".
5625         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5626         const.
5627         (find_pc_sect_compunit_symtab): Make "b" const.
5628         (find_symbol_at_address): Likewise.
5629         (search_symbols): Likewise.
5630         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5631         (dw2_debug_names_lookup_symbol): Likewise.
5632         (dw2_map_matching_symbols): Update.
5633         * p-valprint.c (pascal_val_print): Remove "block".
5634         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5635         (aux_add_nonlocal_symbols): Make "block" const.
5636         (resolve_subexp): Remove cast.
5637         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5638         const.
5639         (iterate_over_file_blocks): Likewise.
5640         * f-exp.y (%union) <bval>: Remove.
5641         * coffread.c (patch_opaque_types): Make "b" const.
5642         * spu-tdep.c (spu_catch_start): Make "block" const.
5643         * c-valprint.c (print_unpacked_pointer): Remove "block".
5644         * symmisc.c (dump_symtab_1): Make "b" const.
5645         (block_depth): Make "block" const.
5646         * d-exp.y (%union) <bval>: Remove.
5647         * cp-support.h (cp_lookup_rtti_type): Update.
5648         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5649         * psymtab.c (psym_lookup_symbol): Make "block" const.
5650         (maintenance_check_psymtabs): Make "b" const.
5651         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5652         (enumerate_locals, enumerate_args): Update.
5653         * python/py-symtab.c (stpy_global_block): Make "block" const.
5654         (stpy_static_block): Likewise.
5655         * inline-frame.c (block_starting_point_at): Make "new_block"
5656         const.
5657         * block.c (find_block_in_blockvector): Make return type const.
5658         (blockvector_for_pc_sect): Make "b" const.
5659         (find_block_in_blockvector): Make "b" const.
5660
5661 2019-03-23  Tom Tromey  <tom@tromey.com>
5662
5663         * varobj.c (varobj_create): Update.
5664         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5665         * printcmd.c (display_command, do_one_display): Don't reset
5666         innermost_block.
5667         * parser-defs.h (enum innermost_block_tracker_type): Move to
5668         expression.h.
5669         (innermost_block): Update comment.
5670         * parse.c (parse_exp_1): Add tracker_types parameter.
5671         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5672         tracker_types parameter.  Reset innermost_block.
5673         (parse_exp_in_context): Remove.
5674         (parse_expression_for_completion): Update.
5675         * objfiles.c (~objfile): Don't reset expression_context_block or
5676         innermost_block.
5677         * expression.h (enum innermost_block_tracker_type): Move from
5678         parser-defs.h.
5679         (parse_exp_1): Add tracker_types parameter.
5680         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5681         reset innermost_block.
5682
5683 2019-03-23  Tom Tromey  <tom@tromey.com>
5684
5685         * objfiles.h: Include bcache.h.
5686
5687 2019-03-23  Tom Tromey  <tom@tromey.com>
5688
5689         * linespec.c (get_current_search_block): Use
5690         scoped_restore_current_language.
5691         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5692
5693 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5694             Jiong Wang  <jiong.wang@arm.com>
5695
5696         * aarch64-linux-tdep.c
5697         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5698         section.
5699         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5700
5701 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5702             Jiong Wang  <jiong.wang@arm.com>
5703
5704         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5705         instructions.
5706         (aarch64_analyze_prologue_test): Add PACIASP test.
5707         (aarch64_prologue_prev_register): Unmask PC value.
5708
5709 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5710             Jiong Wang  <jiong.wang@arm.com>
5711
5712         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5713         (aarch64_dwarf2_prev_register): Unmask PC value.
5714         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5715         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5716         DW_CFA_AARCH64_negate_ra_state.
5717         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5718
5719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5720             Jiong Wang  <jiong.wang@arm.com>
5721
5722         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5723         registers.
5724         (aarch64_pseudo_register_name): Likewise.
5725         (aarch64_pseudo_register_type): Likewise.
5726         (aarch64_pseudo_register_reggroup_p): Likewise.
5727         (aarch64_gdbarch_init): Add pauth registers.
5728         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5729         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5730         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5731         (struct gdbarch_tdep): Add regnum for ra_state.
5732
5733 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5734             Jiong Wang  <jiong.wang@arm.com>
5735
5736         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5737
5738 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5739             Jiong Wang  <jiong.wang@arm.com>
5740
5741         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5742         function.
5743         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5744         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5745         (aarch64_gdbarch_init): Add puth registers.
5746         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5747         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5748         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5749
5750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5751             Jiong Wang  <jiong.wang@arm.com>
5752
5753         * aarch64-linux-nat.c
5754         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5755         * aarch64-linux-tdep.c
5756         (aarch64_linux_core_read_description): Likewise.
5757         (aarch64_linux_get_hwcap): New function.
5758         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5759         (aarch64_linux_get_hwcap): New declaration.
5760
5761 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5762             Jiong Wang  <jiong.wang@arm.com>
5763
5764         * aarch64-linux-nat.c
5765         (aarch64_linux_nat_target::read_description): Add pauth param.
5766         * aarch64-linux-tdep.c
5767         (aarch64_linux_core_read_description): Likewise.
5768         * aarch64-tdep.c (struct target_desc): Add in pauth.
5769         (aarch64_read_description): Add pauth param.
5770         (aarch64_gdbarch_init): Likewise.
5771         * aarch64-tdep.h (aarch64_read_description): Likewise.
5772         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5773         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5774         * features/Makefile: Add new files.
5775         * features/aarch64-pauth.c: New file.
5776         * features/aarch64-pauth.xml: New file.
5777
5778 2019-03-20  Tom Tromey  <tromey@adacore.com>
5779
5780         * infrun.c (handle_inferior_event): Rename from
5781         handle_inferior_event_1.  Create a scoped_value_mark.
5782         (handle_inferior_event): Remove.
5783
5784 2019-03-19  Tom Tromey  <tromey@adacore.com>
5785
5786         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5787         * infrun.h (print_stop_event): Add "displays" parameter.
5788         * infrun.c (print_stop_event): Add "displays" parameter.
5789
5790 2019-03-19  Pedro Alves  <palves@redhat.com>
5791
5792         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5793         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5794         to -1.  Fix TABs vs spaces.
5795         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5796         * tui/tui-out.h (tui_ui_out) Add intro comments.
5797         <m_line, m_start_of_line>: In-class initialize, and add describing
5798         comment.
5799
5800 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5801
5802         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5803         variable names.
5804         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5805
5806 2019-03-18  Pedro Alves  <palves@redhat.com>
5807             Eli Zaretskii <eliz@gnu.org>
5808
5809         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5810         m_line and m_start_of_line.
5811
5812 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5813
5814         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5815         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5816         it returns a newline.  This fixes a regression in TU mode, whereby
5817         the next line is output on the same screen line as the user input.
5818
5819 2019-03-18  Tom Tromey  <tromey@adacore.com>
5820
5821         * minsyms.c (minimal_symbol_reader::install): Remove call to
5822         obstack_blank.
5823
5824 2019-03-18  Pedro Alves  <palves@redhat.com>
5825
5826         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5827         New globals.
5828         (apply_style): New, factored out from ...
5829         (apply_ansi_escape): ... this.  Handle reverse video mode.
5830         (tui_set_reverse_mode): New function.
5831         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5832         * tui/tui-winsource.c (tui_show_source_line): Use
5833         tui_set_reverse_mode instead of setting A_STANDOUT.
5834         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5835         New setter methods.
5836
5837 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5838
5839         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5840         Handle tabs.
5841
5842 2019-03-18  Tom Tromey  <tromey@adacore.com>
5843
5844         * ada-lang.c (empty_array): Add "high" parameter.
5845         (ada_evaluate_subexp): Update.
5846
5847 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5848
5849         * unittests/string_view-selftests.c: Define
5850         _initialize_string_view_selftests unconditionally.
5851
5852 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5853
5854         PR gdb/24350
5855         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5856
5857 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5858
5859         PR gdb/24351
5860         * windows-nat.c (display_selector): Fix format specifiers.
5861
5862 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5863
5864         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5865         tui_refill_source_window instead of tui_refresh_win, to update the
5866         current execution line.  This fixes redisplay of the current line
5867         when stepping through the code with "next" or "step".
5868
5869 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5870
5871         * source-cache.c (source_cache::get_source_lines): Call
5872         find_source_lines to initialize s->nlines.  This fixes vertical
5873         scrolling of TUI source window when the DOWN arrow is pressed.
5874
5875 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5876
5877         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5878         linux-thread-db.c (_initialize_thread_db): Likewise.
5879
5880 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5881
5882         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5883         wclrtoeol in tui_show_source_line".  This reverts changes made in
5884         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5885
5886 2019-03-15  Tom Tromey  <tom@tromey.com>
5887
5888         * symtab.h (struct minimal_symbol): Derive from
5889         general_symbol_info.
5890         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5891         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5892         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5893         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5894         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5895         (MSYMBOL_SEARCH_NAME): Update.
5896         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5897         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5898         * minsyms.c (minimal_symbol_reader::record_full): Update.
5899
5900 2019-03-15  Tom Tromey  <tom@tromey.com>
5901
5902         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5903
5904 2019-03-15  Tom Tromey  <tom@tromey.com>
5905
5906         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5907         unique_xmalloc_ptr.
5908         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5909         Update.
5910         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5911         (build_minimal_symbol_hash_tables)
5912         (minimal_symbol_reader::install): Update.
5913
5914 2019-03-15  Tom Tromey  <tom@tromey.com>
5915
5916         * symtab.c (create_demangled_names_hash): Update.
5917         (symbol_set_names): Update.
5918         * objfiles.h (struct objfile_per_bfd_storage)
5919         <demangled_names_hash>: Now an htab_up.
5920         * objfiles.c (objfile_per_bfd_storage): Simplify.
5921
5922 2019-03-15  Tom Tromey  <tom@tromey.com>
5923
5924         * objfiles.h (struct objfile_per_bfd_storage): Declare
5925         destructor.
5926         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5927         New.
5928         (get_objfile_bfd_data): Use new.  Don't initialize
5929         language_of_main.
5930         (free_objfile_per_bfd_storage): Remove.
5931         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5932
5933 2019-03-15  Tom Tromey  <tom@tromey.com>
5934
5935         * symfile.c (reread_symbols): Update.
5936         * objfiles.c (objfile::objfile): Update.
5937         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5938         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5939         comment.
5940         (minimal_symbol_reader::install): Update.
5941         (terminate_minimal_symbol_table): Remove.
5942         * jit.c (jit_object_close_impl): Update.
5943
5944 2019-03-15  Tom Tromey  <tom@tromey.com>
5945
5946         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5947         initializations.
5948
5949 2019-03-15  Tom Tromey  <tom@tromey.com>
5950
5951         * objfiles.h (struct objfile_per_bfd_storage)
5952         <demangled_hash_languages>: Now a bitset.
5953         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5954         (lookup_minimal_symbol): Update.
5955
5956 2019-03-15  Tom Tromey  <tom@tromey.com>
5957
5958         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5959         Don't return the symbol.
5960         * coffread.c (record_minimal_symbol): Use record_full.
5961
5962 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5963
5964         The MS-Windows port of ncurses fails to switch to a color pair if
5965         one or both of the colors are the implicit default colors.  This
5966         change records the default colors when TUI is initialized, and
5967         then specifies them explicitly when a color pair uses the default
5968         colors.  This allows color styling in TUI mode on MS-Windows.
5969
5970         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5971         ncurses_norm_attr.
5972         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5973         colors in ncurses_norm_attr.
5974         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5975         "none", replace it with the default color recorded in
5976         ncurses_norm_attr.
5977
5978 2019-03-14  Tom Tromey  <tromey@adacore.com>
5979
5980         * source-cache.h (class source_cache) <get_source_lines>: Return
5981         std::string.
5982         * source-cache.c (source_cache::extract_lines): Handle case where
5983         first_pos==npos.  Return std::string.
5984         (source_cache::get_source_lines): Update.
5985
5986 2019-03-14  Tom Tromey  <tromey@adacore.com>
5987
5988         * NEWS: Add item for "style sources" commands.
5989         * source-cache.c (source_cache::get_source_lines): Check
5990         source_styling.
5991         * cli/cli-style.c (source_styling): New global.
5992         (_initialize_cli_style): Add "style sources" commands.
5993         (show_style_sources): New function.
5994         * cli/cli-style.h (source_styling): Declare.
5995
5996 2019-03-14  Pedro Alves  <palves@redhat.com>
5997             Tom Tromey  <tromey@adacore.com>
5998
5999         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6000         * tui/tui-winsource.c (tui_refill_source_window): New function,
6001         from...
6002         (tui_horizontal_source_scroll): ... here.  Move some logic.
6003         * cli/cli-style.c (set_style_enabled): Notify new observable.
6004         * tui/tui-hooks.c (tui_redisplay_source): New function.
6005         (tui_attach_detach_observers): Attach or detach
6006         tui_redisplay_source.
6007         * observable.h (source_styling_changed): New observable.
6008         * observable.c: Define source_styling_changed observable.
6009
6010 2019-03-13  Tom Tromey  <tromey@adacore.com>
6011
6012         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6013         (i386_gnu_nat_target::store_registers): Update.
6014         * target-debug.h (target_debug_print_std_string): New macro.
6015         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6016         * windows-tdep.c (display_one_tib): Update.
6017         * tui/tui-stack.c (tui_make_status_line): Update.
6018         * top.c (print_inferior_quit_action): Update.
6019         * thread.c (thr_try_catch_cmd): Update.
6020         (add_thread_with_info): Update.
6021         (thread_target_id_str): Update.
6022         (thr_try_catch_cmd): Update.
6023         (thread_command): Update.
6024         (thread_find_command): Update.
6025         * record-btrace.c (record_btrace_target::info_record)
6026         (record_btrace_resume_thread, record_btrace_target::resume)
6027         (record_btrace_cancel_resume, record_btrace_step_thread)
6028         (record_btrace_target::wait, record_btrace_target::wait)
6029         (record_btrace_target::wait, record_btrace_target::stop): Update.
6030         * progspace.c (print_program_space): Update.
6031         * process-stratum-target.c
6032         (process_stratum_target::thread_address_space): Update.
6033         * linux-fork.c (linux_fork_mourn_inferior)
6034         (detach_checkpoint_command, info_checkpoints_command)
6035         (linux_fork_context): Update.
6036         (linux_fork_detach): Update.
6037         (class scoped_switch_fork_info): Update.
6038         (delete_checkpoint_command): Update.
6039         * infrun.c (follow_fork_inferior): Update.
6040         (follow_fork_inferior): Update.
6041         (proceed_after_vfork_done): Update.
6042         (handle_vfork_child_exec_or_exit): Update.
6043         (follow_exec): Update.
6044         (displaced_step_prepare_throw): Update.
6045         (displaced_step_restore): Update.
6046         (start_step_over): Update.
6047         (resume_1): Update.
6048         (clear_proceed_status_thread): Update.
6049         (proceed): Update.
6050         (print_target_wait_results): Update.
6051         (do_target_wait): Update.
6052         (context_switch): Update.
6053         (stop_all_threads): Update.
6054         (restart_threads): Update.
6055         (finish_step_over): Update.
6056         (handle_signal_stop): Update.
6057         (switch_back_to_stepped_thread): Update.
6058         (keep_going_pass_signal): Update.
6059         (print_exited_reason): Update.
6060         (normal_stop): Update.
6061         * inferior.c (inferior_pid_to_str): Change return type.
6062         (print_selected_inferior): Update.
6063         (add_inferior): Update.
6064         (detach_inferior): Update.
6065         * dummy-frame.c (fprint_dummy_frames): Update.
6066         * dcache.c (dcache_info_1): Update.
6067         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6068         (btrace_fetch, btrace_clear): Update.
6069         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6070         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6071         type.
6072         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6073         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6074         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6075         * gdbarch.c, gdbarch.h: Rebuild.
6076         * gdbarch.sh (core_pid_to_str): Change return type.
6077         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6078         return type.
6079         (windows_nat_target::pid_to_str): Change return type.
6080         (windows_delete_thread): Update.
6081         (windows_nat_target::attach): Update.
6082         (windows_nat_target::files_info): Update.
6083         * target-delegates.c: Rebuild.
6084         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6085         return type.
6086         (sol_thread_target::pid_to_str): Change return type.
6087         * remote.c (class remote_target) <pid_to_str>: Change return
6088         type.
6089         (remote_target::pid_to_str): Change return type.
6090         (extended_remote_target::attach, remote_target::remote_stop_ns)
6091         (remote_target::remote_notif_remove_queued_reply)
6092         (remote_target::push_stop_reply, remote_target::disable_btrace):
6093         Update.
6094         (extended_remote_target::attach): Update.
6095         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6096         type.
6097         (gdbsim_target::pid_to_str): Change return type.
6098         * ravenscar-thread.c (struct ravenscar_thread_target)
6099         <pid_to_str>: Change return type.
6100         (ravenscar_thread_target::pid_to_str): Change return type.
6101         * procfs.c (class procfs_target) <pid_to_str>: Change return
6102         type.
6103         (procfs_target::pid_to_str): Change return type.
6104         (procfs_target::attach): Update.
6105         (procfs_target::detach): Update.
6106         (procfs_target::fetch_registers): Update.
6107         (procfs_target::store_registers): Update.
6108         (procfs_target::wait): Update.
6109         (procfs_target::files_info): Update.
6110         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6111         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6112         return type.
6113         (nto_procfs_target::pid_to_str): Change return type.
6114         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6115         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6116         return type.
6117         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6118         (exit_lwp): Update.
6119         (attach_proc_task_lwp_callback, get_detach_signal)
6120         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6121         (linux_nat_target::resume, wait_lwp, stop_callback)
6122         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6123         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6124         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6125         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6126         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6127         type.
6128         (inf_ptrace_target::attach): Update.
6129         (inf_ptrace_target::files_info): Update.
6130         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6131         type.
6132         (go32_nat_target::pid_to_str): Change return type.
6133         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6134         (gnu_nat_target::wait): Update.
6135         (gnu_nat_target::wait): Update.
6136         (gnu_nat_target::resume): Update.
6137         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6138         (fbsd_nat_target::wait): Update.
6139         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6140         type.
6141         (darwin_nat_target::attach): Update.
6142         * corelow.c (class core_target) <pid_to_str>: Change return type.
6143         (core_target::pid_to_str): Change return type.
6144         * target.c (normal_pid_to_str): Change return type.
6145         (default_pid_to_str): Likewise.
6146         (target_pid_to_str): Change return type.
6147         (target_translate_tls_address): Update.
6148         (target_announce_detach): Update.
6149         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6150         return type.
6151         (bsd_uthread_target::pid_to_str): Change return type.
6152         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6153         type.
6154         (bsd_kvm_target::pid_to_str): Change return type.
6155         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6156         return type.
6157         (aix_thread_target::pid_to_str): Change return type.
6158         * target.h (struct target_ops) <pid_to_str>: Change return type.
6159         (target_pid_to_str, normal_pid_to_str): Likewise.
6160         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6161         type.
6162         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6163         type.
6164         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6165         return type.
6166         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6167         type.
6168         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6169         type.
6170         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6171         return type.
6172
6173 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6174
6175         * NEWS: Mention that the new default MI version is 3.  Mention
6176         changes to the output of commands and events that deal with
6177         multi-location breakpoints.
6178         * breakpoint.c: Include "mi/mi-out.h".
6179         (print_one_breakpoint): Change output syntax if using MI version
6180         >= 3.
6181         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6182         New.
6183         (mi_multi_location_breakpoint_output_fixed): New.
6184         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6185         (mi_cmd_fix_multi_location_breakpoint_output): New.
6186         (mi_multi_location_breakpoint_output_fixed): New.
6187         * mi/mi-cmds.c (mi_cmds): Register command
6188         -fix-multi-location-breakpoint-output.
6189         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6190         interpreter "mi".
6191
6192 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6193
6194         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6195         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6196         instantiate mi_ui_out based on interpreter name.
6197         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6198         * mi/mi-main.c (mi_load_progress): Likewise.
6199
6200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6201
6202         * NEWS: Combine separate "New targets" sections for 8.3.
6203
6204 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6205
6206         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6207         (ppcfbsd_init_abi): Install gdbarch
6208         "fetch_tls_load_module_address" and "get_thread_local_address"
6209         methods.
6210
6211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6212
6213         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6214         (riscv_fbsd_init_abi): Install gdbarch
6215         "fetch_tls_load_module_address" and "get_thread_local_address"
6216         methods.
6217
6218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6219
6220         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6221         (i386fbsd_init_abi): Install gdbarch
6222         "fetch_tls_load_module_address" and "get_thread_local_address"
6223         methods.
6224
6225 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6226
6227         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6228         (amd64fbsd_init_abi): Install gdbarch
6229         "fetch_tls_load_module_address" and "get_thread_local_address"
6230         methods.
6231
6232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6233
6234         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6235         (struct fbsd_pspace_data): New type.
6236         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6237         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6238         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6239         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6240         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6241
6242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6243
6244         * gdbtypes.c (lookup_struct_elt): New function.
6245         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6246         * gdbtypes.h (struct struct_elt): New type.
6247         (lookup_struct_elt): New prototype.
6248
6249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6250
6251         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6252         remove disabled code block.
6253
6254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6255
6256         * gdbarch.sh (get_thread_local_address): New method.
6257         * gdbarch.h, gdbarch.c: Regenerate.
6258         * target.c (target_translate_tls_address): Use
6259         gdbarch_get_thread_local_address if present instead of
6260         target::get_thread_local_address.
6261
6262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6263
6264         * target.h (target::get_thread_local_address): Update comment.
6265
6266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6267
6268         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6269         objfile->separate_debug_objfile_backlink if not NULL.
6270
6271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6272
6273         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6274         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6275         (amd64bsd_store_inferior_registers): Likewise.
6276         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6277         Enable segment base registers.
6278         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6279         PT_GETFSBASE and PT_GETGSBASE.
6280         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6281         PT_SETGSBASE.
6282         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6283         segment base registers.
6284         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6285
6286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6287
6288         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6289         Update calls to i386_target_description to add 'segments'
6290         parameter.
6291         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6292         add segment base registers.
6293         * arch/i386.c (i386_create_target_description): Add 'segments'
6294         parameter to enable segment base registers.
6295         * arch/i386.h (i386_create_target_description): Likewise.
6296         * features/i386/32bit-segments.xml: New file.
6297         * features/i386/32bit-segments.c: Generate.
6298         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6299         call to i386_target_description to add 'segments' parameter.
6300         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6301         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6302         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6303         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6304         if feature is present.
6305         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6306         Add 'segments' parameter to call to i386_target_description.
6307         (i386_target_description): Add 'segments' parameter to enable
6308         segment base registers.
6309         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6310         to call to i386_target_description.
6311         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6312         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6313         Define I386_NUM_REGS.
6314         (i386_target_description): Add 'segments' parameter to enable
6315         segment base registers.
6316
6317 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6318
6319         PR/24325
6320         * source-cache.c: #undef open and close, to avoid unresolved
6321         externals during linking.
6322
6323 2019-03-12  Tom Tromey  <tromey@adacore.com>
6324
6325         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6326         const.  Add initializers.
6327         (_initialize_remote): Don't initialize ptid globals.
6328
6329 2019-03-12  Pedro Alves  <palves@redhat.com>
6330
6331         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6332
6333 2019-03-12  Pedro Alves  <palves@redhat.com>
6334
6335         * cp-name-parser.y (main): Remove unused 'len' variable.
6336
6337 2019-03-12  Tom Tromey  <tromey@adacore.com>
6338
6339         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6340         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6341
6342 2019-03-12  Tom Tromey  <tromey@adacore.com>
6343
6344         * linux-nat.c (iterate_over_lwps): Update.
6345         (stop_callback): Remove parameter.
6346         (stop_wait_callback, detach_callback, resume_set_callback)
6347         (select_singlestep_lwp_callback, set_ignore_sigint)
6348         (status_callback, resumed_callback, resume_clear_callback)
6349         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6350         data parameter.
6351         (linux_nat_target::detach, linux_nat_target::resume)
6352         (linux_stop_and_wait_all_lwps, select_event_lwp)
6353         (linux_nat_filter_event, linux_nat_wait_1)
6354         (linux_nat_target::kill, linux_nat_target::stop)
6355         (linux_nat_target::stop): Update.
6356         (linux_nat_resume_callback): Change type.
6357         (resume_stopped_resumed_lwps, count_events_callback)
6358         (select_event_lwp_callback): Likewise.
6359         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6360         * arm-linux-nat.c (struct update_registers_data): Remove.
6361         (update_registers_callback): Change type.
6362         (arm_linux_insert_hw_breakpoint1): Update.
6363         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6364         parameter.
6365         (x86_linux_dr_set_addr): Update.
6366         (x86_linux_dr_set_control): Update.
6367         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6368         (iterate_over_lwps): Use gdb::function_view.
6369         * nat/aarch64-linux-hw-point.c (struct
6370         aarch64_dr_update_callback_param): Remove.
6371         (debug_reg_change_callback): Change type.
6372         (aarch64_notify_debug_reg_change): Update.
6373         * s390-linux-nat.c (s390_refresh_per_info): Update.
6374
6375 2019-03-11  Tom Tromey  <tromey@adacore.com>
6376
6377         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6378         redundant assignment to "this_cu".
6379
6380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6381
6382         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6383
6384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6385
6386         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6387         from...
6388         (rank_one_type): ... this.
6389
6390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6391
6392         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6393         from...
6394         (rank_one_type): ... this.
6395
6396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6397
6398         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6399         from...
6400         (rank_one_type): ... this.
6401
6402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6403
6404         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6405         from...
6406         (rank_one_type): ... this.
6407
6408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6409
6410         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6411         from...
6412         (rank_one_type): ... this.
6413
6414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6415
6416         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6417         from...
6418         (rank_one_type): ... this.
6419
6420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6421
6422         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6423         from...
6424         (rank_one_type): ... this.
6425
6426 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6427
6428         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6429         from...
6430         (rank_one_type): ... this.
6431
6432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6433
6434         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6435         from...
6436         (rank_one_type): ... this.
6437
6438 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6439
6440         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6441         from...
6442         (rank_one_type): ... this.
6443
6444 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6445
6446         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6447         from...
6448         (rank_one_type): ... this.
6449
6450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6451
6452         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6453         from...
6454         (rank_one_type): ... this.
6455
6456 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6457
6458         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6459         inferior-events' shows the example events.
6460
6461 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6462
6463         Support styling on native MS-Windows console
6464
6465         PR/24315
6466         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6467         on MS-Windows if $TERM is not defined.
6468
6469         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6470
6471         * posix-hdep.c (gdb_console_fputs):
6472         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6473         functions.
6474         * ui-file.h (gdb_console_fputs): Add prototype.
6475
6476         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6477         back to fputs only if the former returns zero.
6478
6479 2019-03-07  Tom Tromey  <tom@tromey.com>
6480
6481         * symmisc.c (print_symbol_bcache_statistics): Update.
6482         (print_objfile_statistics): Update.
6483         * symfile.c (allocate_symtab): Update.
6484         * stabsread.c: Don't include bcache.h.
6485         * psymtab.h (struct psymbol_bcache): Don't declare.
6486         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6487         (psymbol_bcache_init, psymbol_bcache_free)
6488         (psymbol_bcache_get_bcache): Don't declare.
6489         * psymtab.c (struct psymbol_bcache): Remove.
6490         (psymtab_storage::psymtab_storage): Update.
6491         (psymtab_storage::~psymtab_storage): Update.
6492         (psymbol_bcache_init, psymbol_bcache_free)
6493         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6494         (add_psymbol_to_bcache): Update.
6495         (allocate_psymtab): Update.
6496         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6497         macro_cache>: No longer pointers.
6498         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6499         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6500         * macrotab.c (macro_bcache): Update.
6501         * macroexp.c: Don't include bcache.h.
6502         * gdbtypes.c (check_types_worklist): Update.
6503         (types_deeply_equal): Remove TRY/CATCH.  Update.
6504         * elfread.c (elf_symtab_read): Update.
6505         * dwarf2read.c: Don't include bcache.h.
6506         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6507         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6508         (print_bcache_statistics, bcache_memory_used): Don't declare.
6509         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6510         methods.  Rename all data members.
6511         * bcache.c (struct bcache): Move to bcache.h.
6512         (bcache::expand_hash_table): Rename from expand_hash_table.
6513         (bcache): Remove.
6514         (bcache::insert): Rename from bcache_full.
6515         (bcache::compare): Rename from bcache_compare.
6516         (bcache_xmalloc): Remove.
6517         (bcache::~bcache): Rename from bcache_xfree.
6518         (bcache::print_statistics): Rename from print_bcache_statistics.
6519         (bcache::memory_used): Rename from bcache_memory_used.
6520
6521 2019-03-07  Pedro Alves  <palves@redhat.com>
6522
6523         * infrun.c (normal_stop): Also check for
6524         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6525
6526 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * f-lang.c (value_from_host_double): Moved to...
6529         * value.c (value_from_host_double): ...here.
6530         * value.h (value_from_host_double): Declare.
6531         * guile/scm-math.c (vlscm_convert_typed_number): Use
6532         value_from_host_double.
6533         (vlscm_convert_number): Likewise.
6534         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6535         * python/py-value.c (convert_value_from_python): Likewise.
6536
6537 2019-03-06  Tom Tromey  <tom@tromey.com>
6538
6539         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6540
6541 2019-03-06  Tom Tromey  <tom@tromey.com>
6542
6543         * utils.h (free_current_contents): Don't declare.
6544         * utils.c (free_current_contents): Remove.
6545
6546 2019-03-06  Tom Tromey  <tom@tromey.com>
6547
6548         * top.c (quit_force): Update.
6549         * main.c (captured_command_loop): Update.
6550         * common/new-op.c (operator new): Update.
6551         * common/common-exceptions.c (struct catcher)
6552         <save_cleanup_chain>: Remove member.
6553         (exceptions_state_mc_init): Update.
6554         (exception_try_scope_entry): Return nullptr.
6555         (exception_try_scope_exit, exception_rethrow)
6556         (throw_exception_sjlj, throw_exception_cxx): Update.
6557         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6558         (all_cleanups, do_cleanups, discard_cleanups)
6559         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6560         (restore_cleanups, restore_final_cleanups): Don't declare.
6561         (do_final_cleanups): Remove parameter.
6562         * common/cleanups.c (cleanup_chain, make_cleanup)
6563         (make_cleanup_dtor, all_cleanups, do_cleanups)
6564         (discard_my_cleanups, discard_cleanups)
6565         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6566         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6567         (null_cleanup): Remove.
6568         (do_final_cleanups): Remove parameter.
6569
6570 2019-03-06  Tom Tromey  <tom@tromey.com>
6571
6572         * remote.c (remote_target::remote_parse_stop_reply): Use
6573         unique_xmalloc_ptr.
6574
6575 2019-03-06  Tom Tromey  <tom@tromey.com>
6576
6577         * stabsread.c (struct stabs_field_info): Rename from field_info.
6578         <list, fnlist>: Add initializers.
6579         <obstack>: New member.
6580         (read_member_functions, read_struct_fields, read_baseclasses):
6581         Allocate on obstack.  Don't use cleanups.
6582         (read_one_struct_field, read_member_functions, read_struct_fields)
6583         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6584         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6585         (read_struct_type): Update.
6586
6587 2019-03-06  Tom Tromey  <tom@tromey.com>
6588
6589         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6590         * common/filestuff.h (make_cleanup_close): Don't declare.
6591         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6592         Remove.
6593
6594 2019-03-06  Tom Tromey  <tom@tromey.com>
6595
6596         * solib-aix.c: Use make_scope_exit.
6597
6598 2019-03-06  Tom Tromey  <tom@tromey.com>
6599
6600         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6601         Use make_scope_exit.
6602
6603 2019-03-06  Tom Tromey  <tom@tromey.com>
6604
6605         * solib-svr4.c (disable_probes_interface): Remove parameter.
6606         (svr4_handle_solib_event): Use make_scope_exit.
6607
6608 2019-03-06  Tom Tromey  <tom@tromey.com>
6609
6610         * remote.c (struct stop_reply_deleter): Remove.
6611         (stop_reply_up): Update.
6612         (struct stop_reply): Derive from notif_event.  Don't typedef.
6613         <regcache>: Now a std::vector.
6614         (stop_reply_xfree): Remove.
6615         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6616         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6617         (remote_target::discard_pending_stop_replies): Use delete.
6618         (remote_target::remote_parse_stop_reply): Update.
6619         (remote_target::process_stop_reply): Update.
6620         * remote-notif.h (struct notif_event): Add virtual destructor.
6621         Remove "dtr" member.
6622         (struct notif_client) <alloc_event>: Return a unique_ptr.
6623         (notif_event_xfree): Don't declare.
6624         (notif_event_up): New typedef.
6625         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6626         (notif_event_xfree, do_notif_event_xfree): Remove.
6627         (remote_notif_state_xfree): Update.
6628
6629 2019-03-06  Tom Tromey  <tom@tromey.com>
6630
6631         * infrun.c (displaced_step_clear_cleanup): Now a
6632         forward_scope_exit type.
6633         (displaced_step_prepare_throw): Update.
6634         (displaced_step_fixup): Update.
6635
6636 2019-03-06  Tom Tromey  <tom@tromey.com>
6637
6638         * inferior.h (class inferior): Update comment.
6639         * gdbthread.h (class thread_info): Update comment.
6640
6641 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6642             Tom Tromey  <tom@tromey.com>
6643
6644         * stabsread.h (struct stab_section_list): Remove.
6645         (coffstab_build_psymtabs): Update.
6646         * dbxread.c (symbuf_sections): Now a std::vector.
6647         (sect_idx): New global.
6648         (fill_symbuf): Update.
6649         (coffstab_build_psymtabs): Change type of stabsects parameter.
6650         Update.
6651         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6652         std::vector.
6653         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6654         (coff_locate_sections): Update.
6655         (coff_symfile_read): Remove cleanups.  Update.
6656         (init_stringtab): Add storage parameter.
6657         (free_stringtab, free_stringtab_cleanup): Remove.
6658         (init_lineno): Add storage parameter.
6659         (free_linetab, free_linetab_cleanup): Remove.
6660
6661 2019-03-06  Pedro Alves  <palves@redhat.com>
6662
6663         * linux-fork.c (fork_info::clobber_regs): Delete.
6664         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6665         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6666         comment.  Adjust.
6667         (scoped_switch_fork_info::scoped_switch_fork_info)
6668         (checkpoint_command, linux_fork_context): Adjust
6669         fork_save_infrun_state calls.
6670
6671 2019-03-06  Pedro Alves  <palves@redhat.com>
6672
6673         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6674         (inf_has_multiple_threads): Return 'bool' and rewrite using
6675         inferior_info::threads().
6676
6677 2019-03-06  Pedro Alves  <palves@redhat.com>
6678
6679         * linux-fork.c: Include <list>.
6680         (fork_list): Now a std::list instance.
6681         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6682         (forks_exist_p, find_last_fork): Adjust.
6683         (new_fork): Delete.
6684         (one_fork_p): New.
6685         (add_fork): Adjust.
6686         (free_fork): Delete, folded into fork_info::~fork_info().
6687         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6688         Adjust.
6689         (init_fork_list): Delete.
6690         (linux_fork_killall, linux_fork_mourn_inferior)
6691         (linux_fork_detach, info_checkpoints_command): Adjust.
6692         (_initialize_linux_fork): No longer call init_fork_list.
6693
6694 2019-03-06  Pedro Alves  <palves@redhat.com>
6695
6696         * linux-fork.c (new_fork): New, split out of ...
6697         (add_fork): ... this.  Return void.  Move "first fork" special
6698         case from here, to ...
6699         (checkpoint_command): ... here.
6700         * linux-linux.h (add_fork): Return void.
6701
6702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6705
6706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6707             Chris January  <chris.january@arm.com>
6708             David Lecomber  <david.lecomber@arm.com>
6709
6710         * f-exp.y: New token, UNOP_INTRINSIC.
6711         (exp): New pattern using UNOP_INTRINSIC token.
6712         (f77_keywords): Add 'abs' keyword.
6713         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6714         (value_from_host_double): New function.
6715         (evaluate_subexp_f): Support UNOP_ABS.
6716
6717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6720         types.
6721
6722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6725         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6726         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6727
6728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6729
6730         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6731
6732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6733             Chris January  <chris.january@arm.com>
6734
6735         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6736         * f-exp.y: Define 'KIND' token.
6737         (exp): New pattern for KIND expressions.
6738         (ptype): Handle types with a kind extension.
6739         (direct_abs_decl): Extend to spot kind extensions.
6740         (f77_keywords): Add 'kind' to the list.
6741         (push_kind_type): New function.
6742         (convert_to_kind_type): New function.
6743         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6744         * parse.c (operator_length_standard): Likewise.
6745         * parser-defs.h (enum type_pieces): Add tp_kind.
6746         * std-operator.def: Add UNOP_KIND.
6747
6748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6749
6750         * f-exp.y (f_parse): Set yydebug.
6751
6752 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6753
6754         * f-lang.c (evaluate_subexp_f): New function.
6755         (exp_descriptor_f): New global.
6756         (f_language_defn): Use exp_descriptor_f instead of
6757         exp_descriptor_standard.
6758
6759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6760
6761         * f-exp.y (struct token): Add comments.
6762         (dot_ops): Remove uppercase versions and the end marker.
6763         (f77_keywords): Likewise.
6764         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6765         entries in the dot_ops array are case insensitive, and use
6766         strncasecmp to compare strings.  Also some whitespace cleanup in
6767         this area.  Similar for the f77_keywords array, except entries in
6768         this list might be case sensitive.
6769
6770 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6771
6772         * f-exp.y (struct f77_boolean_val): Add comments.
6773         (boolean_values): Remove uppercase versions, and end marker.
6774         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6775         and use strncasecmp to achieve case insensitivity.  Additionally,
6776         perform whitespace cleanup around this code.
6777
6778 2019-03-06  Tom Tromey  <tromey@adacore.com>
6779
6780         * remote-sim.c (gdbsim_target_open): Use result of
6781         gdb_argv::release.
6782
6783 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6784         Dirk Schubert  <dirk.schubert@arm.com>
6785         Chris January  <chris.january@arm.com>
6786
6787         * eval.c (evaluate_subexp_standard): Call Fortran argument
6788         wrapping logic.
6789         * f-lang.c (struct value): A value which can be passed into a
6790         Fortran function call.
6791         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6792         where appropriate.
6793         (struct type): Value ready for a Fortran function call.
6794         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6795         is needed.
6796         * f-lang.h (fortran_argument_convert): Declaration.
6797         (fortran_preserve_arg_pointer): Declaration.
6798         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6799
6800 2019-03-05  Tom Tromey  <tromey@adacore.com>
6801
6802         * python/py-prettyprint.c (print_string_repr): Remove #if.
6803         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6804
6805 2019-03-05  Tom Tromey  <tromey@adacore.com>
6806
6807         * target.c (the_dummy_target): Move later.  Change type to
6808         "dummy_target".
6809         (initialize_targets): Don't initialize the_dummy_target.
6810
6811 2019-03-05  Tom Tromey  <tromey@adacore.com>
6812
6813         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6814         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6815
6816 2019-03-05  Tom Tromey  <tromey@adacore.com>
6817
6818         * windows-nat.c (windows_nat_target::attach)
6819         (windows_nat_target::detach): Don't call gdb_flush.
6820         * valprint.c (generic_val_print, val_print, val_print_string):
6821         Don't call gdb_flush.
6822         * utils.c (defaulted_query): Don't call gdb_flush.
6823         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6824         * target.c (target_announce_detach): Don't call gdb_flush.
6825         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6826         * remote.c (extended_remote_target::attach): Don't call
6827         gdb_flush.
6828         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6829         * printcmd.c (do_examine): Don't call gdb_flush.
6830         (info_display_command): Don't call gdb_flush.
6831         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6832         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6833         * memattr.c (info_mem_command): Don't call gdb_flush.
6834         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6835         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6836         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6837         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6838         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6839         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6840         (gnu_nat_target::detach): Don't call gdb_flush.
6841         * f-valprint.c (f_val_print): Don't call gdb_flush.
6842         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6843         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6844         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6845         gdb_flush.
6846         * c-valprint.c (c_val_print): Don't call gdb_flush.
6847         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6848
6849 2019-03-05  Tom Tromey  <tromey@adacore.com>
6850
6851         * varobj.c (update_dynamic_varobj_children): Update.
6852         (install_default_visualizer): Use reset, not release.
6853         * value.c (set_internalvar): Update.
6854         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6855         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6856         ATTRIBUTE_UNUSED_RESULT.
6857
6858 2019-03-05  Tom Tromey  <tromey@adacore.com>
6859
6860         * remote.c (class scoped_remote_fd) <release>: Add
6861         ATTRIBUTE_UNUSED_RESULT.
6862
6863 2019-03-05  Tom Tromey  <tromey@adacore.com>
6864
6865         * macroexp.c (struct macro_buffer) <release>: Add
6866         ATTRIBUTE_UNUSED_RESULT.
6867
6868 2019-03-05  Tom Tromey  <tromey@adacore.com>
6869
6870         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6871         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6872         ATTRIBUTE_UNUSED_RESULT.
6873
6874 2019-03-05  Tom Tromey  <tromey@adacore.com>
6875
6876         * common/scoped_fd.h (class scoped_fd) <release>: Add
6877         ATTRIBUTE_UNUSED_RESULT.
6878
6879 2019-03-05  Tom Tromey  <tromey@adacore.com>
6880
6881         * parser-defs.h (struct parser_state) <release>: Add
6882         ATTRIBUTE_UNUSED_RESULT.
6883
6884 2019-03-05  Tom Tromey  <tromey@adacore.com>
6885
6886         * utils.h (class gdb_argv) <release>: Add
6887         ATTRIBUTE_UNUSED_RESULT.
6888         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6889
6890 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6891
6892         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6893         for-loop range, to avoid compiler warnings.
6894
6895         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6896         avoid compiler warnings about unused variables.
6897
6898         * NEWS: Mention end of support for native debugging on MS-Windows
6899         before XP.
6900
6901         PR gdb/24292
6902         * common/netstuff.c:
6903         * gdbserver/gdbreplay.c
6904         * gdbserver/remote-utils.c:
6905         * ser-tcp.c:
6906         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6907         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6908         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6909         'getaddrinfo' and 'freeaddrinfo' were not available before
6910         Windows XP, and mingw.org's MinGW headers by default define
6911         _WIN32_WINNT to 0x500.
6912
6913 2019-03-01  Gary Benson <gbenson@redhat.com>
6914
6915         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6916
6917 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6918             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6919
6920         PR gdb/8527
6921         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6922         set_sigint_trap, clear_sigint_trap.
6923
6924 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6925
6926         * target.c (target_detach): Clear the regcache and the
6927         frame cache.
6928
6929 2019-02-27  Pedro Alves  <palves@redhat.com>
6930
6931         * utils.c (set_screen_size): When we cap the height/width sizes,
6932         tweak the corresponding command variable to show "unlimited":
6933
6934 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6935             Pedro Alves  <palves@redhat.com>
6936
6937         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6938         before calling rl_set_screen_size.
6939
6940 2019-02-27  Tom Tromey  <tromey@adacore.com>
6941
6942         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6943         define.
6944         * python/py-value.c: Remove Python 2.4 workaround.
6945         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6946         workaround.
6947         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6948         Python 2.4 workaround.
6949         * python/python-internal.h: Remove Python 2.4 comment.
6950         (Py_ssize_t): Don't define.
6951         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6952         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6953         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6954         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6955         * python/python.c (do_start_initialization): Remove Python 2.4
6956         workaround.
6957         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6958         (print_children): Remove Python 2.4 workaround.
6959         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6960         workaround.
6961         (CHARBUFFERPROC_NAME): Remove.
6962         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6963         Python 2.4 workaround.
6964
6965 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6966
6967         * NEWS: Note minimum Python version.
6968
6969 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6970
6971         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6972         code from these functions.  Remove corresponding ifdefs.  Use
6973         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6974         Remove gotos and target of gotos.
6975         (infpy_search_memory): Likewise.
6976
6977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6980         (hppa_gdbarch_init): Don't register deleted functions with
6981         gdbarch.
6982
6983 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6984
6985         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6986         (h8300_unwind_sp): Delete.
6987         (h8300_dummy_id): Delete.
6988         (h8300_gdbarch_init): Don't register deleted functions with
6989         gdbarch.
6990
6991 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6992
6993         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6994         (ft32_unwind_pc): Delete.
6995         (ft32_unwind_sp): Delete.
6996         (ft32_gdbarch_init): Don't register deleted functions with
6997         gdbarch.
6998
6999 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7000
7001         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7002         (frv_unwind_pc): Delete.
7003         (frv_unwind_sp): Delete.
7004         (frv_gdbarch_init): Don't register deleted functions with
7005         gdbarch.
7006
7007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7008
7009         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7010         (riscv_unwind_pc): Delete.
7011         (riscv_unwind_sp): Delete.
7012         (riscv_gdbarch_init): Don't register deleted functions with
7013         gdbarch.
7014
7015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7016
7017         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7018         (csky_unwind_pc): Delete.
7019         (csky_unwind_sp): Delete.
7020         (csky_gdbarch_init): Don't register deleted functions with
7021         gdbarch.
7022
7023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7024
7025         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7026         (cris_unwind_pc): Delete.
7027         (cris_unwind_sp): Delete.
7028         (cris_gdbarch_init): Don't register deleted functions with
7029         gdbarch.
7030
7031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7034         (bfin_unwind_pc): Delete.
7035         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7036
7037 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7040         (arm_unwind_pc): Delete.
7041         (arm_unwind_sp): Delete.
7042         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7043
7044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7045
7046         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7047         (arc_unwind_pc): Delete.
7048         (arc_unwind_sp): Delete.
7049         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7050
7051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7054         (alpha_unwind_pc): Delete.
7055         (alpha_gdbarch_init): Don't register deleted functions with
7056         gdbarch.
7057
7058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7059
7060         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7061         (aarch64_unwind_pc): Delete.
7062         (aarch64_unwind_sp): Delete.
7063         (aarch64_gdbarch_init): Don't register deleted functions with
7064         gdbarch.
7065
7066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * gdbtypes.c (type_align): Don't consider static members when
7069         computing structure alignment.
7070
7071 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7072
7073         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7074         return 0 for other types.
7075         * arch-utils.c (default_type_align): Always return 0.
7076         * gdbarch.h: Regenerate.
7077         * gdbarch.sh (type_align): Extend comment.
7078         * gdbtypes.c (type_align): Add additional comments, always call
7079         gdbarch_type_align before applying the default rules.
7080         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7081         generic code will then apply a suitable default.
7082         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7083         types, return 0 for other types.
7084
7085 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7086
7087         * NEWS: Create a new section for the next release branch.
7088         Rename the section of the current branch, now that it has
7089         been cut.
7090
7091 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7092
7093         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7094         * version.in: Bump version to 8.3.50.DATE-git.
7095
7096 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7097
7098         * aix-thread.c (ptid_cmp): Remove unused variable.
7099         (get_signaled_thread): Likewise.
7100         (store_regs_user_thread): Likewise.
7101         (store_regs_kernel_thread): Likewise.
7102         (fetch_regs_kernel_thread): Remove shadowed variable.
7103
7104 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * features/riscv/32bit-cpu.xml: Add register numbers.
7107         * features/riscv/32bit-fpu.c: Regenerate.
7108         * features/riscv/32bit-fpu.xml: Add register numbers.
7109         * features/riscv/64bit-cpu.xml: Add register numbers.
7110         * features/riscv/64bit-fpu.c: Regenerate.
7111         * features/riscv/64bit-fpu.xml: Add register numbers.
7112
7113 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7114
7115         * NEWS: Mention two argument form of gdb.Value constructor.
7116         * python/py-value.c (convert_buffer_and_type_to_value): New
7117         function.
7118         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7119         Add support for handling an optional second argument.  Call
7120         convert_buffer_and_type_to_value as appropriate.
7121         * python/python-internal.h (Py_buffer_deleter): New struct.
7122         (Py_buffer_up): New typedef.
7123
7124 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7125
7126         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7127         instead of releasing ownership.
7128
7129 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7130
7131         * dwarf2read.c (open_and_init_dwp_file): Call
7132         elf_numsections instead of bfd_count_sections to initialize
7133         dwp_file->num_sections.
7134
7135 2019-02-25  Tom Tromey  <tromey@adacore.com>
7136
7137         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7138
7139 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7140
7141         * gcore.in: Add '--readnever' option when invoking GDB.
7142
7143 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7144
7145         * MAINTAINERS: Update my email address.
7146
7147 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7148
7149         * build-id.c (build_id_to_debug_bfd_1): New function.
7150         (build_id_to_debug_bfd): Look for separate debug file in
7151         sysroot.
7152
7153 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7154
7155         * gdbarch.sh: Update the copyright year range that is placed into
7156         generated files.
7157
7158 2019-02-22  Keith Seitz  <keiths@redhat.com>
7159
7160         PR symtab/23853
7161         * linespec.c (create_sals_line_offset): Search for the default
7162         symtab's filename instead of its fullname.
7163
7164 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7165
7166         * NEWS: Update style defaults.
7167
7168 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7169
7170         * main.c (captured_main_1): Disable styling in batch mode.
7171
7172 2019-02-20  Tom Tromey  <tom@tromey.com>
7173
7174         * symtab.c (symtab_symbol_info): Fix typos.
7175
7176 2019-02-20  Tom Tromey  <tromey@adacore.com>
7177
7178         * findcmd.c (_initialize_mem_search): Use upper case for
7179         metasyntactic variables.
7180
7181 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7182
7183         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7184         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7185
7186 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7187
7188         * top.h (source_file_name): Change to std::string.
7189         * top.c (source_file_name): Likewise.
7190         (command_line_input): Adjust.
7191         * cli/cli-script.c (script_from_file): Adjust.
7192
7193 2019-02-19  Tom Tromey  <tromey@adacore.com>
7194
7195         * ravenscar-thread.c
7196         (ravenscar_thread_target::update_thread_list): Don't call
7197         ada_build_task_list.
7198         * ada-lang.h (ada_build_task_list): Don't declare.
7199         * ada-tasks.c (struct ada_tasks_inferior_data)
7200         <task_list_valid_p>: Now bool.
7201         (read_known_tasks, ada_task_list_changed)
7202         (ada_tasks_invalidate_inferior_data): Update.
7203         (read_known_tasks_array): Return bool.
7204         (read_known_tasks_list): Likewise.
7205         (read_known_tasks): Return void.
7206         (ada_build_task_list): Now static.
7207
7208 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7211         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7212
7213 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7214
7215         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7216         variant for ada_tasks_pspace_data_handle and
7217         ada_tasks_inferior_data_handle.
7218         (ada_tasks_pspace_data_cleanup): New function.
7219         (ada_tasks_inferior_data_cleanup): New function.
7220
7221 2019-02-17  Tom Tromey  <tom@tromey.com>
7222
7223         * macrotab.h (macro_source_fullname): Return a std::string.
7224         * macrotab.c (macro_include, check_for_redefinition)
7225         (macro_undef, macro_lookup_definition, foreach_macro)
7226         (foreach_macro_in_scope): Update.
7227         (macro_source_fullname): Return a std::string.
7228         * macrocmd.c (show_pp_source_pos): Update.
7229
7230 2019-02-17  Tom Tromey  <tom@tromey.com>
7231
7232         * macrocmd.c (show_pp_source_pos): Style the file names.
7233
7234 2019-02-17  Tom Tromey  <tom@tromey.com>
7235
7236         PR tui/24197:
7237         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7238
7239 2019-02-17  Tom Tromey  <tom@tromey.com>
7240
7241         * ada-lang.c (user_select_syms): Use filtered printing.
7242         * utils.c (wrap_style): New global.
7243         (desired_style): Remove.
7244         (emit_style_escape): Add stream parameter.
7245         (set_output_style, reset_terminal_style, prompt_for_continue):
7246         Update.
7247         (flush_wrap_buffer): Only flush gdb_stdout.
7248         (wrap_here): Set wrap_style.
7249         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7250         treat escape sequences as a character.  Change when wrap buffer is
7251         flushed.
7252         (fputs_styled): Do not set the output style when the default is
7253         requested.
7254         * ui-style.h (struct ui_file_style) <is_default>: New method.
7255         * source.c (print_source_lines_base): Emit escape sequences in one
7256         piece.
7257
7258 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7259
7260         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7261         integers and enumeration types.
7262
7263 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7264
7265         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7266         instead of lookup_symbol_in_language
7267         (do_exact_match): New function.
7268         (ada_get_symbol_name_matcher): Return do_exact_match when
7269         doing a verbatim match.
7270
7271 2019-02-15  Tom Tromey  <tromey@adacore.com>
7272
7273         * ravenscar-thread.c (ravenscar_thread_target::resume)
7274         (ravenscar_thread_target::wait): Special case wildcard requests.
7275
7276 2019-02-15  Tom Tromey  <tromey@adacore.com>
7277
7278         * ravenscar-thread.c (base_ptid): Remove.
7279         (struct ravenscar_thread_target) <close>: New method.
7280         <m_base_ptid>: New member.
7281         <update_inferior_ptid, active_task, task_is_currently_active,
7282         runtime_initialized>: Declare methods.
7283         <ravenscar_thread_target>: Add constructor.
7284         (ravenscar_thread_target::task_is_currently_active)
7285         (ravenscar_thread_target::update_inferior_ptid)
7286         (ravenscar_runtime_initialized): Rename.  Now methods.
7287         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7288         (ravenscar_thread_target::update_thread_list): Update.
7289         (ravenscar_thread_target::active_task): Now method.
7290         (ravenscar_thread_target::store_registers)
7291         (ravenscar_thread_target::prepare_to_store)
7292         (ravenscar_thread_target::prepare_to_store)
7293         (ravenscar_thread_target::mourn_inferior): Update.
7294         (ravenscar_inferior_created): Use "new" to create target.
7295         (ravenscar_thread_target::get_ada_task_ptid): Update.
7296         (_initialize_ravenscar): Don't initialize base_ptid.
7297         (ravenscar_ops): Remove global.
7298
7299 2019-02-15  Tom Tromey  <tromey@adacore.com>
7300
7301         * target.h (push_target): Declare new overload.
7302         * target.c (push_target): New overload, taking an rvalue reference.
7303         * remote.c (remote_target::open_1): Use push_target overload.
7304         * corelow.c (core_target_open): Use push_target overload.
7305
7306 2019-02-15  Tom Tromey  <tromey@adacore.com>
7307
7308         * ravenscar-thread.c (is_ravenscar_task)
7309         (ravenscar_task_is_currently_active): Return bool.
7310         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7311         (_initialize_ravenscar): Remove "(void)".
7312         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7313         Return bool.
7314
7315 2019-02-15  Tom Tromey  <tromey@adacore.com>
7316
7317         * ravenscar-thread.c (ravenscar_runtime_initializer)
7318         (has_ravenscar_runtime, get_running_thread_id)
7319         (ravenscar_thread_target::resume): Fix indentation.
7320
7321 2019-02-15  Tom Tromey  <tromey@adacore.com>
7322
7323         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7324         from ravenscar_arch_ops.
7325         (sparc_ravenscar_ops::fetch_registers)
7326         (sparc_ravenscar_ops::store_registers): Now methods.
7327         (sparc_ravenscar_prepare_to_store): Remove.
7328         (sparc_ravenscar_ops): Redefine.
7329         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7330         methods and destructor.  Remove members.
7331         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7332         (ravenscar_thread_target::store_registers)
7333         (ravenscar_thread_target::prepare_to_store): Update.
7334         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7335         Remove.
7336         (struct ppc_ravenscar_powerpc_ops): Derive from
7337         ravenscar_arch_ops.
7338         (ppc_ravenscar_powerpc_ops::fetch_registers)
7339         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7340         (ppc_ravenscar_powerpc_ops): Redefine.
7341         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7342         (ppc_ravenscar_e500_ops::fetch_registers)
7343         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7344         (ppc_ravenscar_e500_ops): Redefine.
7345         * aarch64-ravenscar-thread.c
7346         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7347         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7348         (aarch64_ravenscar_fetch_registers)
7349         (aarch64_ravenscar_store_registers): Now methods.
7350         (aarch64_ravenscar_ops): Redefine.
7351
7352 2019-02-15  Tom Tromey  <tromey@adacore.com>
7353
7354         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7355         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7356         (ravenscar_thread_target::stopped_by_watchpoint)
7357         (ravenscar_thread_target::stopped_data_address)
7358         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7359
7360 2019-02-15  Tom Tromey  <tromey@adacore.com>
7361
7362         * ravenscar-thread.c: Fix some typos.
7363
7364 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7365             Tom Tromey  <tromey@adacore.com>
7366
7367         * ada-lang.c (ada_exception_sal): Change addr_string to a
7368         std::string.
7369         (create_ada_exception_catchpoint): Update.
7370
7371 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7372             Tom Tromey  <tromey@adacore.com>
7373
7374         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7375         (bp_location_ops): Remove.
7376         (base_breakpoint_allocate_location): Update.
7377         (free_bp_location): Update.
7378         * ada-lang.c (class ada_catchpoint_location)
7379         <ada_catchpoint_location>: Remove ops parameter.
7380         (ada_catchpoint_location_dtor): Remove.
7381         (ada_catchpoint_location_ops): Remove.
7382         (allocate_location_exception): Update.
7383         * breakpoint.h (struct bp_location_ops): Remove.
7384         (class bp_location) <bp_location>: Remove bp_location_ops
7385         parameter.
7386         <~bp_location>: Add destructor.
7387         <ops>: Remove.
7388
7389 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7390             Pedro Alves  <palves@redhat.com>
7391
7392         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7393         'PATH_MAX'.
7394
7395 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7396             Samuel Thibault  <samuel.thibault@gnu.org>
7397             Thomas Schwinge  <thomas@codesourcery.com>
7398
7399         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7400         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7401
7402 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7403
7404         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7405         (check_empty): Use "const char *".
7406
7407         * gnu-nat.c (gnu_nat_target::detach): Instead of
7408         'detach_inferior (pid)' call
7409         'detach_inferior (find_inferior_pid (pid))'.
7410
7411         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7412         'nat/fork-inferior.o'.
7413         * gnu-nat.c: #include "nat/fork-inferior.h".
7414
7415         * gnu-nat.c (gnu_nat_target::detach): Instead of
7416         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7417         * gnu-nat.h: #include "inf-child.h".
7418         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7419         'i386_gnu_nat_target::fetch_registers'.
7420         (gnu_store_registers): Rename/move to
7421         'i386_gnu_nat_target::store_registers'.
7422
7423         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7424         * gnu-nat.h (mach_thread_info): New function.
7425         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7426
7427         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7428
7429 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7430
7431         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7432
7433 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7434
7435         * windows-nat.c (windows_add_thread): Add new parameter
7436         "main_thread_p" with default value set to false.  Update
7437         function documentation as well as all callers.
7438         (windows_delete_thread): Likewise.
7439         (fake_create_process): Update call to windows_add_thread.
7440         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7441         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7442         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7443         call to windows_delete_thread.
7444
7445 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7446
7447         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7448
7449 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7450
7451         * symfile.c (find_separate_debug_file): Use canonical path of
7452         sysroot with child_path instead of gdb_sysroot if it is valid.
7453
7454 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7455
7456         * symfile.c (find_separate_debug_file): Use child_path to
7457         determine if an object file is under a sysroot.
7458
7459 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7460
7461         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7462         unittests/child-path-selftests.c.
7463         * common/pathstuff.c (child_path): New function.
7464         * common/pathstuff.h (child_path): New prototype.
7465         * unittests/child-path-selftests.c: New file.
7466
7467 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7468
7469         * symfile.c (find_separate_debug_file): Look for separate debug
7470         files in debug directories under the sysroot.
7471
7472 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7473
7474         * symtab.h (struct minimal_symbol data_p): New const method.
7475         (struct minimal_symbol text_p): Likewise.
7476         * symtab.c (output_source_filename): Use file name style
7477         to print file name.
7478         (print_symbol_info): Likewise.
7479         (print_msymbol_info): Use address style to print addresses.
7480         Use function name style to print executable text symbols.
7481         (expand_symtab_containing_pc): Use data_p.
7482         (find_pc_sect_compunit_symtab): Likewise.
7483
7484 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7485
7486         * breakpoint.c (describe_other_breakpoints): Use address style
7487         to print addresses.
7488         (say_where): Likewise.
7489
7490 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7491
7492         * ada-typeprint.c (print_func_type): Print function name
7493         style to print function name.
7494         * c-typeprint.c (c_print_type_1): Likewise.
7495
7496 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7497
7498         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7499         for execve.
7500
7501 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7502
7503         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7504         type_stack.
7505
7506 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7507
7508         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7509         TYPE_CODE_REF types.
7510
7511 2019-02-08  Jim Wilson  <jimw@sifive.com>
7512
7513         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7514         (riscv_linux_fregset): New.
7515         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7516
7517 2019-02-07  Tom Tromey  <tom@tromey.com>
7518
7519         * thread.c (thread_cancel_execution_command): Update.
7520         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7521         methods.
7522         (struct thread_fsm_ops): Remove.
7523         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7524         (thread_fsm_should_stop, thread_fsm_return_value)
7525         (thread_fsm_set_finished, thread_fsm_finished_p)
7526         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7527         Don't declare.
7528         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7529         * infrun.c (clear_proceed_status_thread)
7530         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7531         (print_stop_event): Update.
7532         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7533         Add constructor.
7534         (step_command_fsm_ops): Remove.
7535         (new_step_command_fsm): Remove.
7536         (step_1): Update.
7537         (step_command_fsm::should_stop): Rename from
7538         step_command_fsm_should_stop.
7539         (step_command_fsm::clean_up): Rename from
7540         step_command_fsm_clean_up.
7541         (step_command_fsm::do_async_reply_reason): Rename from
7542         step_command_fsm_async_reply_reason.
7543         (struct until_next_fsm): Inherit from thread_fsm.  Add
7544         constructor.
7545         (until_next_fsm_ops): Remove.
7546         (new_until_next_fsm): Remove.
7547         (until_next_fsm::should_stop): Rename from
7548         until_next_fsm_should_stop.
7549         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7550         (until_next_fsm::do_async_reply_reason): Rename from
7551         until_next_fsm_async_reply_reason.
7552         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7553         constructor.  Change type of breakpoint.
7554         (finish_command_fsm_ops): Remove.
7555         (new_finish_command_fsm): Remove.
7556         (finish_command_fsm::should_stop): Rename from
7557         finish_command_fsm_should_stop.
7558         (finish_command_fsm::clean_up): Rename from
7559         finish_command_fsm_clean_up.
7560         (finish_command_fsm::return_value): Rename from
7561         finish_command_fsm_return_value.
7562         (finish_command_fsm::do_async_reply_reason): Rename from
7563         finish_command_fsm_async_reply_reason.
7564         (finish_command): Update.
7565         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7566         Add constructor.
7567         (call_thread_fsm_ops): Remove.
7568         (call_thread_fsm::call_thread_fsm): Rename from
7569         new_call_thread_fsm.
7570         (call_thread_fsm::should_stop): Rename from
7571         call_thread_fsm_should_stop.
7572         (call_thread_fsm::should_notify_stop): Rename from
7573         call_thread_fsm_should_notify_stop.
7574         (run_inferior_call, call_function_by_hand_dummy): Update.
7575         * cli/cli-interp.c (should_print_stop_to_console): Update.
7576         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7577         Add constructor.  Change type of location_breakpoint,
7578         caller_breakpoint.
7579         (until_break_fsm_ops): Remove.
7580         (new_until_break_fsm): Remove.
7581         (until_break_fsm::should_stop): Rename from
7582         until_break_fsm_should_stop.
7583         (until_break_fsm::clean_up): Rename from
7584         until_break_fsm_clean_up.
7585         (until_break_fsm::do_async_reply_reason): Rename from
7586         until_break_fsm_async_reply_reason.
7587         (until_break_command): Update.
7588         * thread-fsm.c: Remove.
7589         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7590
7591 2019-02-07  Tom Tromey  <tom@tromey.com>
7592
7593         * yy-remap.h: Add include guard.
7594         * xtensa-tdep.h: Add include guard.
7595         * xcoffread.h: Rename include guard.
7596         * varobj-iter.h: Add include guard.
7597         * tui/tui.h: Rename include guard.
7598         * tui/tui-winsource.h: Rename include guard.
7599         * tui/tui-wingeneral.h: Rename include guard.
7600         * tui/tui-windata.h: Rename include guard.
7601         * tui/tui-win.h: Rename include guard.
7602         * tui/tui-stack.h: Rename include guard.
7603         * tui/tui-source.h: Rename include guard.
7604         * tui/tui-regs.h: Rename include guard.
7605         * tui/tui-out.h: Rename include guard.
7606         * tui/tui-layout.h: Rename include guard.
7607         * tui/tui-io.h: Rename include guard.
7608         * tui/tui-hooks.h: Rename include guard.
7609         * tui/tui-file.h: Rename include guard.
7610         * tui/tui-disasm.h: Rename include guard.
7611         * tui/tui-data.h: Rename include guard.
7612         * tui/tui-command.h: Rename include guard.
7613         * tic6x-tdep.h: Add include guard.
7614         * target/waitstatus.h: Rename include guard.
7615         * target/wait.h: Rename include guard.
7616         * target/target.h: Rename include guard.
7617         * target/resume.h: Rename include guard.
7618         * target-float.h: Rename include guard.
7619         * stabsread.h: Add include guard.
7620         * rs6000-tdep.h: Add include guard.
7621         * riscv-fbsd-tdep.h: Add include guard.
7622         * regformats/regdef.h: Rename include guard.
7623         * record.h: Rename include guard.
7624         * python/python.h: Rename include guard.
7625         * python/python-internal.h: Rename include guard.
7626         * python/py-stopevent.h: Rename include guard.
7627         * python/py-ref.h: Rename include guard.
7628         * python/py-record.h: Rename include guard.
7629         * python/py-record-full.h: Rename include guard.
7630         * python/py-record-btrace.h: Rename include guard.
7631         * python/py-instruction.h: Rename include guard.
7632         * python/py-events.h: Rename include guard.
7633         * python/py-event.h: Rename include guard.
7634         * procfs.h: Add include guard.
7635         * proc-utils.h: Add include guard.
7636         * p-lang.h: Add include guard.
7637         * or1k-tdep.h: Rename include guard.
7638         * observable.h: Rename include guard.
7639         * nto-tdep.h: Rename include guard.
7640         * nat/x86-linux.h: Rename include guard.
7641         * nat/x86-linux-dregs.h: Rename include guard.
7642         * nat/x86-gcc-cpuid.h: Add include guard.
7643         * nat/x86-dregs.h: Rename include guard.
7644         * nat/x86-cpuid.h: Rename include guard.
7645         * nat/ppc-linux.h: Rename include guard.
7646         * nat/mips-linux-watch.h: Rename include guard.
7647         * nat/linux-waitpid.h: Rename include guard.
7648         * nat/linux-ptrace.h: Rename include guard.
7649         * nat/linux-procfs.h: Rename include guard.
7650         * nat/linux-osdata.h: Rename include guard.
7651         * nat/linux-nat.h: Rename include guard.
7652         * nat/linux-namespaces.h: Rename include guard.
7653         * nat/linux-btrace.h: Rename include guard.
7654         * nat/glibc_thread_db.h: Rename include guard.
7655         * nat/gdb_thread_db.h: Rename include guard.
7656         * nat/gdb_ptrace.h: Rename include guard.
7657         * nat/fork-inferior.h: Rename include guard.
7658         * nat/amd64-linux-siginfo.h: Rename include guard.
7659         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7660         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7661         * nat/aarch64-linux.h: Rename include guard.
7662         * nat/aarch64-linux-hw-point.h: Rename include guard.
7663         * mn10300-tdep.h: Add include guard.
7664         * mips-linux-tdep.h: Add include guard.
7665         * mi/mi-parse.h: Rename include guard.
7666         * mi/mi-out.h: Rename include guard.
7667         * mi/mi-main.h: Rename include guard.
7668         * mi/mi-interp.h: Rename include guard.
7669         * mi/mi-getopt.h: Rename include guard.
7670         * mi/mi-console.h: Rename include guard.
7671         * mi/mi-common.h: Rename include guard.
7672         * mi/mi-cmds.h: Rename include guard.
7673         * mi/mi-cmd-break.h: Rename include guard.
7674         * m2-lang.h: Add include guard.
7675         * location.h: Rename include guard.
7676         * linux-record.h: Rename include guard.
7677         * linux-nat.h: Add include guard.
7678         * linux-fork.h: Add include guard.
7679         * i386-darwin-tdep.h: Rename include guard.
7680         * hppa-linux-offsets.h: Add include guard.
7681         * guile/guile.h: Rename include guard.
7682         * guile/guile-internal.h: Rename include guard.
7683         * gnu-nat.h: Rename include guard.
7684         * gdb-stabs.h: Rename include guard.
7685         * frv-tdep.h: Add include guard.
7686         * f-lang.h: Add include guard.
7687         * event-loop.h: Add include guard.
7688         * darwin-nat.h: Rename include guard.
7689         * cp-abi.h: Rename include guard.
7690         * config/sparc/nm-sol2.h: Rename include guard.
7691         * config/nm-nto.h: Rename include guard.
7692         * config/nm-linux.h: Add include guard.
7693         * config/i386/nm-i386gnu.h: Rename include guard.
7694         * config/djgpp/nl_types.h: Rename include guard.
7695         * config/djgpp/langinfo.h: Rename include guard.
7696         * compile/gcc-cp-plugin.h: Add include guard.
7697         * compile/gcc-c-plugin.h: Add include guard.
7698         * compile/compile.h: Rename include guard.
7699         * compile/compile-object-run.h: Rename include guard.
7700         * compile/compile-object-load.h: Rename include guard.
7701         * compile/compile-internal.h: Rename include guard.
7702         * compile/compile-cplus.h: Rename include guard.
7703         * compile/compile-c.h: Rename include guard.
7704         * common/xml-utils.h: Rename include guard.
7705         * common/x86-xstate.h: Rename include guard.
7706         * common/version.h: Rename include guard.
7707         * common/vec.h: Rename include guard.
7708         * common/tdesc.h: Rename include guard.
7709         * common/selftest.h: Rename include guard.
7710         * common/scoped_restore.h: Rename include guard.
7711         * common/scoped_mmap.h: Rename include guard.
7712         * common/scoped_fd.h: Rename include guard.
7713         * common/safe-iterator.h: Rename include guard.
7714         * common/run-time-clock.h: Rename include guard.
7715         * common/refcounted-object.h: Rename include guard.
7716         * common/queue.h: Rename include guard.
7717         * common/ptid.h: Rename include guard.
7718         * common/print-utils.h: Rename include guard.
7719         * common/preprocessor.h: Rename include guard.
7720         * common/pathstuff.h: Rename include guard.
7721         * common/observable.h: Rename include guard.
7722         * common/netstuff.h: Rename include guard.
7723         * common/job-control.h: Rename include guard.
7724         * common/host-defs.h: Rename include guard.
7725         * common/gdb_wait.h: Rename include guard.
7726         * common/gdb_vecs.h: Rename include guard.
7727         * common/gdb_unlinker.h: Rename include guard.
7728         * common/gdb_unique_ptr.h: Rename include guard.
7729         * common/gdb_tilde_expand.h: Rename include guard.
7730         * common/gdb_sys_time.h: Rename include guard.
7731         * common/gdb_string_view.h: Rename include guard.
7732         * common/gdb_splay_tree.h: Rename include guard.
7733         * common/gdb_setjmp.h: Rename include guard.
7734         * common/gdb_ref_ptr.h: Rename include guard.
7735         * common/gdb_optional.h: Rename include guard.
7736         * common/gdb_locale.h: Rename include guard.
7737         * common/gdb_assert.h: Rename include guard.
7738         * common/filtered-iterator.h: Rename include guard.
7739         * common/filestuff.h: Rename include guard.
7740         * common/fileio.h: Rename include guard.
7741         * common/environ.h: Rename include guard.
7742         * common/common-utils.h: Rename include guard.
7743         * common/common-types.h: Rename include guard.
7744         * common/common-regcache.h: Rename include guard.
7745         * common/common-inferior.h: Rename include guard.
7746         * common/common-gdbthread.h: Rename include guard.
7747         * common/common-exceptions.h: Rename include guard.
7748         * common/common-defs.h: Rename include guard.
7749         * common/common-debug.h: Rename include guard.
7750         * common/cleanups.h: Rename include guard.
7751         * common/buffer.h: Rename include guard.
7752         * common/btrace-common.h: Rename include guard.
7753         * common/break-common.h: Rename include guard.
7754         * cli/cli-utils.h: Rename include guard.
7755         * cli/cli-style.h: Rename include guard.
7756         * cli/cli-setshow.h: Rename include guard.
7757         * cli/cli-script.h: Rename include guard.
7758         * cli/cli-interp.h: Rename include guard.
7759         * cli/cli-decode.h: Rename include guard.
7760         * cli/cli-cmds.h: Rename include guard.
7761         * charset-list.h: Add include guard.
7762         * buildsym-legacy.h: Rename include guard.
7763         * bfin-tdep.h: Add include guard.
7764         * ax.h: Rename include guard.
7765         * arm-linux-tdep.h: Add include guard.
7766         * arm-fbsd-tdep.h: Add include guard.
7767         * arch/xtensa.h: Rename include guard.
7768         * arch/tic6x.h: Add include guard.
7769         * arch/i386.h: Add include guard.
7770         * arch/arm.h: Rename include guard.
7771         * arch/arm-linux.h: Rename include guard.
7772         * arch/arm-get-next-pcs.h: Rename include guard.
7773         * arch/amd64.h: Add include guard.
7774         * arch/aarch64-insn.h: Rename include guard.
7775         * arch-utils.h: Rename include guard.
7776         * annotate.h: Add include guard.
7777         * amd64-darwin-tdep.h: Rename include guard.
7778         * aarch64-linux-tdep.h: Add include guard.
7779         * aarch64-fbsd-tdep.h: Add include guard.
7780         * aarch32-linux-nat.h: Add include guard.
7781
7782 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7783
7784         * macrotab.c (macro_define_internal): New function that
7785         factorizes macro_define_object_internal and macro_define_function
7786         code.
7787         (macro_define_object_internal): Use macro_define_internal.
7788         (macro_define_function): Likewise.
7789
7790 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7791
7792         * macrocmd.c (extract_identifier): Return
7793         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7794         callers.
7795
7796 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7797
7798         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7799
7800 2019-02-05  Tom Tromey  <tom@tromey.com>
7801
7802         * target.c (target_stack::unpush): Move assertion earlier.
7803
7804 2019-01-30  Tom Tromey  <tom@tromey.com>
7805
7806         PR python/23615:
7807         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7808         (gdbpy_parse_and_eval): Likewise.
7809         * python/python-internal.h (gdbpy_allow_threads): New class.
7810
7811 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7812
7813         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7814         (aarch64_fbsd_fpregmap): Move earlier.
7815         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7816         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7817         instead of individual calls to trad_frame_set_reg_addr.
7818         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7819         earlier.
7820         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7821         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7822         instead of individual calls to trad_frame_set_reg_addr.
7823
7824 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7825
7826         * CONTRIBUTE: Replace contribution list with wiki link.
7827
7828 2019-01-25  Tom Tromey  <tom@tromey.com>
7829
7830         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7831
7832 2019-01-25  Tom Tromey  <tom@tromey.com>
7833
7834         * xtensa-linux-nat.c: Fix common/ includes.
7835         * xml-support.h: Fix common/ includes.
7836         * xml-support.c: Fix common/ includes.
7837         * x86-linux-nat.c: Fix common/ includes.
7838         * windows-nat.c: Fix common/ includes.
7839         * varobj.h: Fix common/ includes.
7840         * varobj.c: Fix common/ includes.
7841         * value.c: Fix common/ includes.
7842         * valops.c: Fix common/ includes.
7843         * utils.c: Fix common/ includes.
7844         * unittests/xml-utils-selftests.c: Fix common/ includes.
7845         * unittests/utils-selftests.c: Fix common/ includes.
7846         * unittests/unpack-selftests.c: Fix common/ includes.
7847         * unittests/tracepoint-selftests.c: Fix common/ includes.
7848         * unittests/style-selftests.c: Fix common/ includes.
7849         * unittests/string_view-selftests.c: Fix common/ includes.
7850         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7851         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7852         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7853         * unittests/rsp-low-selftests.c: Fix common/ includes.
7854         * unittests/parse-connection-spec-selftests.c: Fix common/
7855         includes.
7856         * unittests/optional-selftests.c: Fix common/ includes.
7857         * unittests/offset-type-selftests.c: Fix common/ includes.
7858         * unittests/observable-selftests.c: Fix common/ includes.
7859         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7860         * unittests/memrange-selftests.c: Fix common/ includes.
7861         * unittests/memory-map-selftests.c: Fix common/ includes.
7862         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7863         * unittests/function-view-selftests.c: Fix common/ includes.
7864         * unittests/environ-selftests.c: Fix common/ includes.
7865         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7866         * unittests/common-utils-selftests.c: Fix common/ includes.
7867         * unittests/cli-utils-selftests.c: Fix common/ includes.
7868         * unittests/array-view-selftests.c: Fix common/ includes.
7869         * ui-file.c: Fix common/ includes.
7870         * tui/tui-io.c: Fix common/ includes.
7871         * tracepoint.h: Fix common/ includes.
7872         * tracepoint.c: Fix common/ includes.
7873         * tracefile-tfile.c: Fix common/ includes.
7874         * top.h: Fix common/ includes.
7875         * top.c: Fix common/ includes.
7876         * thread.c: Fix common/ includes.
7877         * target/waitstatus.h: Fix common/ includes.
7878         * target/waitstatus.c: Fix common/ includes.
7879         * target.h: Fix common/ includes.
7880         * target.c: Fix common/ includes.
7881         * target-memory.c: Fix common/ includes.
7882         * target-descriptions.c: Fix common/ includes.
7883         * symtab.h: Fix common/ includes.
7884         * symfile.c: Fix common/ includes.
7885         * stap-probe.c: Fix common/ includes.
7886         * spu-linux-nat.c: Fix common/ includes.
7887         * sparc-nat.c: Fix common/ includes.
7888         * source.c: Fix common/ includes.
7889         * solib.c: Fix common/ includes.
7890         * solib-target.c: Fix common/ includes.
7891         * ser-unix.c: Fix common/ includes.
7892         * ser-tcp.c: Fix common/ includes.
7893         * ser-pipe.c: Fix common/ includes.
7894         * ser-base.c: Fix common/ includes.
7895         * selftest-arch.c: Fix common/ includes.
7896         * s12z-tdep.c: Fix common/ includes.
7897         * rust-exp.y: Fix common/ includes.
7898         * rs6000-aix-tdep.c: Fix common/ includes.
7899         * riscv-tdep.c: Fix common/ includes.
7900         * remote.c: Fix common/ includes.
7901         * remote-notif.h: Fix common/ includes.
7902         * remote-fileio.h: Fix common/ includes.
7903         * remote-fileio.c: Fix common/ includes.
7904         * regcache.h: Fix common/ includes.
7905         * regcache.c: Fix common/ includes.
7906         * record-btrace.c: Fix common/ includes.
7907         * python/python.c: Fix common/ includes.
7908         * python/py-type.c: Fix common/ includes.
7909         * python/py-inferior.c: Fix common/ includes.
7910         * progspace.h: Fix common/ includes.
7911         * producer.c: Fix common/ includes.
7912         * procfs.c: Fix common/ includes.
7913         * proc-api.c: Fix common/ includes.
7914         * printcmd.c: Fix common/ includes.
7915         * ppc-linux-nat.c: Fix common/ includes.
7916         * parser-defs.h: Fix common/ includes.
7917         * osdata.c: Fix common/ includes.
7918         * obsd-nat.c: Fix common/ includes.
7919         * nat/x86-linux.c: Fix common/ includes.
7920         * nat/x86-linux-dregs.c: Fix common/ includes.
7921         * nat/x86-dregs.h: Fix common/ includes.
7922         * nat/x86-dregs.c: Fix common/ includes.
7923         * nat/ppc-linux.c: Fix common/ includes.
7924         * nat/mips-linux-watch.h: Fix common/ includes.
7925         * nat/mips-linux-watch.c: Fix common/ includes.
7926         * nat/linux-waitpid.c: Fix common/ includes.
7927         * nat/linux-ptrace.h: Fix common/ includes.
7928         * nat/linux-ptrace.c: Fix common/ includes.
7929         * nat/linux-procfs.c: Fix common/ includes.
7930         * nat/linux-personality.c: Fix common/ includes.
7931         * nat/linux-osdata.c: Fix common/ includes.
7932         * nat/linux-namespaces.c: Fix common/ includes.
7933         * nat/linux-btrace.h: Fix common/ includes.
7934         * nat/linux-btrace.c: Fix common/ includes.
7935         * nat/fork-inferior.c: Fix common/ includes.
7936         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7937         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7938         * nat/aarch64-linux.c: Fix common/ includes.
7939         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7940         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7941         * namespace.h: Fix common/ includes.
7942         * mips-linux-tdep.c: Fix common/ includes.
7943         * minsyms.c: Fix common/ includes.
7944         * mi/mi-parse.h: Fix common/ includes.
7945         * mi/mi-main.c: Fix common/ includes.
7946         * mi/mi-cmd-env.c: Fix common/ includes.
7947         * memrange.h: Fix common/ includes.
7948         * memattr.c: Fix common/ includes.
7949         * maint.h: Fix common/ includes.
7950         * maint.c: Fix common/ includes.
7951         * main.c: Fix common/ includes.
7952         * machoread.c: Fix common/ includes.
7953         * location.c: Fix common/ includes.
7954         * linux-thread-db.c: Fix common/ includes.
7955         * linux-nat.c: Fix common/ includes.
7956         * linux-fork.c: Fix common/ includes.
7957         * inline-frame.c: Fix common/ includes.
7958         * infrun.c: Fix common/ includes.
7959         * inflow.c: Fix common/ includes.
7960         * inferior.h: Fix common/ includes.
7961         * inferior.c: Fix common/ includes.
7962         * infcmd.c: Fix common/ includes.
7963         * inf-ptrace.c: Fix common/ includes.
7964         * inf-child.c: Fix common/ includes.
7965         * ia64-linux-nat.c: Fix common/ includes.
7966         * i387-tdep.c: Fix common/ includes.
7967         * i386-tdep.c: Fix common/ includes.
7968         * i386-linux-tdep.c: Fix common/ includes.
7969         * i386-linux-nat.c: Fix common/ includes.
7970         * i386-go32-tdep.c: Fix common/ includes.
7971         * i386-fbsd-tdep.c: Fix common/ includes.
7972         * i386-fbsd-nat.c: Fix common/ includes.
7973         * guile/scm-type.c: Fix common/ includes.
7974         * guile/guile.c: Fix common/ includes.
7975         * go32-nat.c: Fix common/ includes.
7976         * gnu-nat.c: Fix common/ includes.
7977         * gdbthread.h: Fix common/ includes.
7978         * gdbarch-selftests.c: Fix common/ includes.
7979         * gdb_usleep.c: Fix common/ includes.
7980         * gdb_select.h: Fix common/ includes.
7981         * gdb_bfd.c: Fix common/ includes.
7982         * gcore.c: Fix common/ includes.
7983         * fork-child.c: Fix common/ includes.
7984         * findvar.c: Fix common/ includes.
7985         * fbsd-nat.c: Fix common/ includes.
7986         * event-top.c: Fix common/ includes.
7987         * event-loop.c: Fix common/ includes.
7988         * dwarf2read.c: Fix common/ includes.
7989         * dwarf2loc.c: Fix common/ includes.
7990         * dwarf2-frame.c: Fix common/ includes.
7991         * dwarf-index-cache.c: Fix common/ includes.
7992         * dtrace-probe.c: Fix common/ includes.
7993         * disasm-selftests.c: Fix common/ includes.
7994         * defs.h: Fix common/ includes.
7995         * csky-tdep.c: Fix common/ includes.
7996         * cp-valprint.c: Fix common/ includes.
7997         * cp-support.h: Fix common/ includes.
7998         * cp-support.c: Fix common/ includes.
7999         * corelow.c: Fix common/ includes.
8000         * completer.h: Fix common/ includes.
8001         * completer.c: Fix common/ includes.
8002         * compile/compile.c: Fix common/ includes.
8003         * compile/compile-loc2c.c: Fix common/ includes.
8004         * compile/compile-cplus-types.c: Fix common/ includes.
8005         * compile/compile-cplus-symbols.c: Fix common/ includes.
8006         * command.h: Fix common/ includes.
8007         * cli/cli-dump.c: Fix common/ includes.
8008         * cli/cli-cmds.c: Fix common/ includes.
8009         * charset.c: Fix common/ includes.
8010         * build-id.c: Fix common/ includes.
8011         * btrace.h: Fix common/ includes.
8012         * btrace.c: Fix common/ includes.
8013         * breakpoint.h: Fix common/ includes.
8014         * breakpoint.c: Fix common/ includes.
8015         * ax.h:
8016         (enum agent_op): Fix common/ includes.
8017         * ax-general.c (struct aop_map): Fix common/ includes.
8018         * ax-gdb.c: Fix common/ includes.
8019         * auxv.c: Fix common/ includes.
8020         * auto-load.c: Fix common/ includes.
8021         * arm-tdep.c: Fix common/ includes.
8022         * arch/riscv.c: Fix common/ includes.
8023         * arch/ppc-linux-common.c: Fix common/ includes.
8024         * arch/i386.c: Fix common/ includes.
8025         * arch/arm.c: Fix common/ includes.
8026         * arch/arm-linux.c: Fix common/ includes.
8027         * arch/arm-get-next-pcs.c: Fix common/ includes.
8028         * arch/amd64.c: Fix common/ includes.
8029         * arch/aarch64.c: Fix common/ includes.
8030         * arch/aarch64-insn.c: Fix common/ includes.
8031         * arch-utils.c: Fix common/ includes.
8032         * amd64-windows-tdep.c: Fix common/ includes.
8033         * amd64-tdep.c: Fix common/ includes.
8034         * amd64-sol2-tdep.c: Fix common/ includes.
8035         * amd64-obsd-tdep.c: Fix common/ includes.
8036         * amd64-nbsd-tdep.c: Fix common/ includes.
8037         * amd64-linux-tdep.c: Fix common/ includes.
8038         * amd64-linux-nat.c: Fix common/ includes.
8039         * amd64-fbsd-tdep.c: Fix common/ includes.
8040         * amd64-fbsd-nat.c: Fix common/ includes.
8041         * amd64-dicos-tdep.c: Fix common/ includes.
8042         * amd64-darwin-tdep.c: Fix common/ includes.
8043         * agent.c: Fix common/ includes.
8044         * ada-lang.h: Fix common/ includes.
8045         * ada-lang.c: Fix common/ includes.
8046         * aarch64-tdep.c: Fix common/ includes.
8047
8048 2019-01-25  Tom Tromey  <tom@tromey.com>
8049
8050         * common/create-version.sh: Use common/version.h.
8051
8052 2019-01-24  Pedro Alves  <palves@redhat.com>
8053
8054         * infrun.c (signal_stop, signal_print, signal_program)
8055         (signal_catch, signal_pass): Now arrays instead of pointers.
8056         (update_signals_program_target, do_target_resume)
8057         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8058         * linux-nat.c (linux_nat_target::pass_signals)
8059         (linux_nat_target::create_inferior, linux_nat_target::attach):
8060         Adjust.
8061         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8062         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8063         * procfs.c (procfs_target::pass_signals): Adjust.
8064         * record-full.c (record_full_target::resume): Adjust.
8065         * remote.c (remote_target::pass_signals)
8066         (remote_target::program_signals): Adjust.
8067         * target-debug.h (target_debug_print_signals): Now takes a
8068         gdb::array_view as parameter.  Adjust.
8069         * target.h (target_ops) <pass_signals, program_signals>: Replace
8070         pointer and length parameters with gdb::array_view.
8071         (target_pass_signals, target_program_signals): Likewise.
8072         * target-delegates.c: Regenerate.
8073
8074 2019-01-24  Pedro Alves  <palves@redhat.com>
8075
8076         * common/forward-scope-exit.h
8077         (forward_scope_exit::forward_scope_exit): Pass arguments to
8078         m_bind_function directly, instead of creating a std::bind and
8079         copying that.
8080
8081 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8082
8083         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8084         for static members.
8085         (pass_in_v_vfp_candidate): Likewise.
8086
8087 2019-01-23  Tom Tromey  <tom@tromey.com>
8088             Pedro Alves  <palves@redhat.com>
8089
8090         * regcache.c (class regcache_invalidator): Remove.
8091         (regcache::raw_write): Use make_scope_exit.
8092
8093 2019-01-23  Tom Tromey  <tom@tromey.com>
8094
8095         * ui-out.h (class ui_out_emit_type): Update comment.
8096
8097 2019-01-23  Tom Tromey  <tom@tromey.com>
8098
8099         * infrun.c (fetch_inferior_event): Update comment.
8100
8101 2019-01-23  Tom Tromey  <tom@tromey.com>
8102             Pedro Alves  <palves@redhat.com>
8103
8104         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8105         parameter.
8106         (fetch_inferior_event): Use SCOPE_EXIT.
8107
8108
8109 2019-01-23  Tom Tromey  <tom@tromey.com>
8110             Pedro Alves  <palves@redhat.com>
8111
8112         * infrun.c (disable_thread_events): Delete.
8113         (stop_all_threads): Use SCOPE_EXIT.
8114
8115 2019-01-23  Tom Tromey  <tom@tromey.com>
8116             Pedro Alves  <palves@redhat.com>
8117
8118         * symfile.c: Include forward-scope-exit.h.
8119         (clear_symtab_users_cleanup): Replace forward declaration with
8120         a FORWARD_SCOPE_EXIT.
8121         (syms_from_objfile_1): Use the forward_scope_exit and
8122         gdb::optional instead of cleanup_function.
8123         (reread_symbols): Use the forward_scope_exit instead of
8124         cleanup_function.
8125         (clear_symtab_users_cleanup): Remove function.
8126
8127 2019-01-23  Tom Tromey  <tom@tromey.com>
8128             Pedro Alves  <palves@redhat.com>
8129
8130         * linux-nat.c: Include scope-exit.h.
8131         (cleanup_target_stop): Remove.
8132         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8133         SCOPE_EXIT.
8134
8135 2019-01-23  Tom Tromey  <tom@tromey.com>
8136             Pedro Alves  <palves@redhat.com>
8137
8138         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8139         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8140
8141 2019-01-23  Tom Tromey  <tom@tromey.com>
8142             Andrew Burgess  <andrew.burgess@embecosm.com>
8143             Pedro Alves  <palves@redhat.com>
8144
8145         * infrun.c (fetch_inferior_event): Use scope_exit.
8146         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8147         * top.c (execute_command): Use scope_exit.
8148         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8149         * utils.c (do_bpstat_clear_actions_cleanup)
8150         (make_bpstat_clear_actions_cleanup): Remove.
8151
8152 2019-01-23  Tom Tromey  <tom@tromey.com>
8153             Pedro Alves  <palves@redhat.com>
8154
8155         * infrun.c: Include "common/scope-exit.h"
8156         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8157         (wait_for_inferior): Use SCOPE_EXIT.
8158         (fetch_inferior_event): Use scope_exit.
8159
8160 2019-01-23  Tom Tromey  <tom@tromey.com>
8161             Pedro Alves  <palves@redhat.com>
8162
8163         * breakpoint.c (create_breakpoint): Remove cleanup.
8164
8165 2019-01-23  Tom Tromey  <tom@tromey.com>
8166             Andrew Burgess  <andrew.burgess@embecosm.com>
8167             Pedro Alves  <palves@redhat.com>
8168
8169 2019-01-23  Pedro Alves  <palves@redhat.com>
8170
8171         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8172
8173 2019-01-23  Pedro Alves  <palves@redhat.com>
8174             Andrew Burgess  <andrew.burgess@embecosm.com>
8175
8176         * gdbthread.h: Include "common/forward-scope-exit.h".
8177         (scoped_finish_thread_state): Redefine custom class in terms of
8178         forward_scope_exit.
8179
8180 2019-01-23  Pedro Alves  <palves@redhat.com>
8181             Andrew Burgess  <andrew.burgess@embecosm.com>
8182
8183         * common/forward-scope-exit.h: New file.
8184
8185 2019-01-23  Pedro Alves  <palves@redhat.com>
8186             Andrew Burgess  <andrew.burgess@embecosm.com>
8187             Tom Tromey  <tom@tromey.com>
8188
8189         * common/scope-exit.h: New file.
8190
8191 2019-01-23  Pedro Alves  <palves@redhat.com>
8192
8193         * common/preprocessor.h (ESC): Rename to ...
8194         (ESC_PARENS): ... this.
8195         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8196         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8197
8198 2019-01-23  Tom Tromey  <tom@tromey.com>
8199
8200         * language.h (class scoped_switch_to_sym_language_if_auto):
8201         Initialize m_lang in both cases.
8202
8203 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8204
8205         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8206         with XCNEW.
8207
8208 2019-01-22  Tom Tromey  <tom@tromey.com>
8209
8210         * corelow.c: Do not include sys/file.h.
8211
8212 2019-01-22  Tom Tromey  <tom@tromey.com>
8213
8214         * tui/tui-wingeneral.h: Include gdb_curses.h.
8215
8216 2019-01-22  Tom Tromey  <tom@tromey.com>
8217
8218         * source-cache.h (class source_cache) <get_source_lines,
8219         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8220
8221 2019-01-22  Tom Tromey  <tom@tromey.com>
8222
8223         * remote-fileio.h (struct remote_target): Declare.
8224
8225 2019-01-22  Tom Tromey  <tom@tromey.com>
8226
8227         * python/py-arch.c: Do not include py-ref.h.
8228         * python/py-bpevent.c: Do not include py-ref.h.
8229         * python/py-cmd.c: Do not include py-ref.h.
8230         * python/py-continueevent.c: Do not include py-ref.h.
8231         * python/py-event.h: Do not include py-ref.h.
8232         * python/py-evtregistry.c: Do not include py-ref.h.
8233         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8234         * python/py-frame.c: Do not include py-ref.h.
8235         * python/py-framefilter.c: Do not include py-ref.h.
8236         * python/py-function.c: Do not include py-ref.h.
8237         * python/py-infevents.c: Do not include py-ref.h.
8238         * python/py-linetable.c: Do not include py-ref.h.
8239         * python/py-objfile.c: Do not include py-ref.h.
8240         * python/py-param.c: Do not include py-ref.h.
8241         * python/py-prettyprint.c: Do not include py-ref.h.
8242         * python/py-progspace.c: Do not include py-ref.h.
8243         * python/py-symbol.c: Do not include py-ref.h.
8244         * python/py-symtab.c: Do not include py-ref.h.
8245         * python/py-type.c: Do not include py-ref.h.
8246         * python/py-unwind.c: Do not include py-ref.h.
8247         * python/py-utils.c: Do not include py-ref.h.
8248         * python/py-value.c: Do not include py-ref.h.
8249         * python/py-varobj.c: Do not include py-ref.h.
8250         * python/py-xmethods.c: Do not include py-ref.h.
8251         * python/python.c: Do not include py-ref.h.
8252         * varobj.c: Do not include py-ref.h.
8253
8254 2019-01-22  Tom Tromey  <tom@tromey.com>
8255
8256         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8257         keyword for bcache.
8258
8259 2019-01-22  Tom Tromey  <tom@tromey.com>
8260
8261         * compile/compile-cplus-types.c: Remove a comment by #include.
8262
8263 2019-01-22  Tom Tromey  <tom@tromey.com>
8264
8265         * compile/gcc-c-plugin.h: Include compile-internal.h.
8266
8267 2019-01-22  Tom Tromey  <tom@tromey.com>
8268
8269         * stabsread.c (EXTERN): Do not define.
8270         (symnum, next_symbol_text_func, processing_gcc_compilation)
8271         (within_function, global_sym_chain, global_stabs)
8272         (previous_stab_code, this_object_header_files)
8273         (n_this_object_header_files)
8274         (n_allocated_this_object_header_files): Define.
8275         * stabsread.h (EXTERN): Never define.  Use "extern".
8276
8277 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8278
8279         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8280         history_value.
8281
8282 2019-01-21  Tom Tromey  <tom@tromey.com>
8283
8284         * ui-out.c: Fix includes.
8285         * tui/tui-source.c: Fix includes.
8286         * target.c: Fix includes.
8287         * remote.c: Fix includes.
8288         * regcache.c: Fix includes.
8289         * python/py-block.c: Fix includes.
8290         * printcmd.c: Fix includes.
8291         * or1k-tdep.c: Fix includes.
8292         * mi/mi-main.c: Fix includes.
8293         * m32r-tdep.c: Fix includes.
8294         * csky-tdep.c: Fix includes.
8295         * compile/compile-cplus-types.c: Fix includes.
8296         * cli/cli-interp.c: Fix includes.
8297
8298 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8299
8300         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8301         for padding.
8302
8303 2019-01-16  Tom Tromey  <tom@tromey.com>
8304
8305         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8306         earlier.
8307         (struct objfile) <msymbols_range>: Move from top level.
8308         <msymbols>: New method.
8309         (class objfile_msymbols): Remove.
8310         * symtab.c (default_collect_symbol_completion_matches_break_on):
8311         Update.
8312         * symmisc.c (dump_msymbols): Update.
8313         * stabsread.c (scan_file_globals): Update.
8314         * objc-lang.c (info_selectors_command, info_classes_command)
8315         (find_methods): Update.
8316         * minsyms.c (find_solib_trampoline_target): Update.
8317         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8318         * coffread.c (coff_symfile_read): Update.
8319         * ada-lang.c (ada_lookup_simple_minsym)
8320         (ada_collect_symbol_completion_matches): Update.
8321
8322 2019-01-16  Tom Tromey  <tom@tromey.com>
8323
8324         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8325         type.  Remove no-argument constructor.
8326         <iterator::operator++>: Simplify.
8327         <begin>: Update.
8328         <end>: Use minimal_symbol_count.
8329
8330 2019-01-16  Tom Tromey  <tom@tromey.com>
8331
8332         * objfiles.h (struct objfile) <psymtabs>: New method.
8333         (class objfile_psymtabs): Remove.
8334         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8335         typedef.
8336         <range>: New method.
8337         (require_partial_symbols): Change return type.
8338         * psymtab.c (require_partial_symbols)
8339         (psym_expand_symtabs_matching): Update.
8340         * mdebugread.c (parse_partial_symbols): Update.
8341         * dbxread.c (dbx_end_psymtab): Update.
8342
8343 2019-01-15  Tom Tromey  <tom@tromey.com>
8344
8345         * symtab.c (lookup_objfile_from_block)
8346         (lookup_symbol_in_objfile_symtabs)
8347         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8348         (find_line_symtab, info_sources_command)
8349         (default_collect_symbol_completion_matches_break_on)
8350         (make_source_files_completion_list): Update.
8351         * symmisc.c (print_objfile_statistics, dump_objfile)
8352         (maintenance_print_symbols, maintenance_info_symtabs)
8353         (maintenance_check_symtabs, maintenance_info_line_tables):
8354         Update.
8355         * source.c (select_source_symtab)
8356         (forget_cached_source_info_for_objfile): Update.
8357         * objfiles.h (class objfile_compunits): Remove.
8358         (struct objfile) <compunits_range>: New typedef.
8359         (compunits): New method.
8360         * objfiles.c (objfile_relocate1): Update.
8361         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8362         * maint.c (count_symtabs_and_blocks): Update.
8363         * linespec.c (iterate_over_all_matching_symtabs): Update.
8364         * cp-support.c (add_symbol_overload_list_qualified): Update.
8365         * coffread.c (coff_symtab_read): Update.
8366         * ada-lang.c (add_nonlocal_symbols)
8367         (ada_collect_symbol_completion_matches)
8368         (ada_add_global_exceptions): Update.
8369
8370 2019-01-15  Tom Tromey  <tom@tromey.com>
8371
8372         * progspace.h (program_space) <objfiles_safe_range>: New
8373         typedef.
8374         <objfiles_safe>: New method.
8375         * objfiles.h (class all_objfiles_safe): Remove.
8376         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8377         * jit.c (jit_inferior_exit_hook): Update.
8378
8379 2019-01-17  Tom Tromey  <tom@tromey.com>
8380
8381         * progspace.h (program_space) <objfiles_range>: New typedef.
8382         <objfiles>: New method.
8383         <objfiles_head>: Rename from objfiles.
8384         (object_files): Update.
8385         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8386         * guile/scm-pretty-print.c
8387         (ppscm_find_pretty_printer_from_objfiles): Update.
8388         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8389         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8390         Update.
8391         * python/py-progspace.c (pspy_get_objfiles): Update.
8392         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8393         Update.
8394         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8395         (objfpy_lookup_objfile_by_build_id): Update.
8396         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8397         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8398         Update.
8399         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8400         (expand_symtab_containing_pc, lookup_objfile_from_block)
8401         (lookup_static_symbol, basic_lookup_transparent_type)
8402         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8403         (find_line_symtab, info_sources_command)
8404         (default_collect_symbol_completion_matches_break_on)
8405         (make_source_files_completion_list, find_main_name): Update.
8406         * symmisc.c (print_symbol_bcache_statistics)
8407         (print_objfile_statistics, maintenance_print_symbols)
8408         (maintenance_print_msymbols, maintenance_print_objfiles)
8409         (maintenance_info_symtabs, maintenance_check_symtabs)
8410         (maintenance_expand_symtabs, maintenance_info_line_tables):
8411         Update.
8412         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8413         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8414         (map_overlay_command, unmap_overlay_command)
8415         (simple_overlay_update, expand_symtabs_matching)
8416         (map_symbol_filenames): Update.
8417         * symfile-debug.c (set_debug_symfile): Update.
8418         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8419         Update.
8420         * source.c (select_source_symtab, forget_cached_source_info):
8421         Update.
8422         * solib.c (solib_read_symbols): Update.
8423         * solib-spu.c (append_ocl_sos): Update.
8424         * psymtab.c (maintenance_print_psymbols)
8425         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8426         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8427         * printcmd.c (info_symbol_command): Update.
8428         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8429         Update.
8430         * objfiles.h (class all_objfiles): Remove.
8431         * objfiles.c (have_partial_symbols, have_full_symbols)
8432         (have_minimal_symbols, qsort_cmp, update_section_map)
8433         (shared_objfile_contains_address_p)
8434         (default_iterate_over_objfiles_in_search_order): Update.
8435         * objc-lang.c (info_selectors_command, info_classes_command)
8436         (find_methods): Update.
8437         * minsyms.c (find_solib_trampoline_target): Update.
8438         * maint.c (maintenance_info_sections)
8439         (maintenance_translate_address, count_symtabs_and_blocks):
8440         Update.
8441         * main.c (captured_main_1): Update.
8442         * linux-thread-db.c (try_thread_db_load_from_pdir)
8443         (has_libpthread): Update.
8444         * linespec.c (iterate_over_all_matching_symtabs)
8445         (search_minsyms_for_name): Update.
8446         * jit.c (jit_find_objf_with_entry_addr): Update.
8447         * hppa-tdep.c (find_unwind_entry)
8448         (hppa_lookup_stub_minimal_symbol): Update.
8449         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8450         Update.
8451         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8452         (elf_gnu_ifunc_resolve_by_got): Update.
8453         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8454         * dwarf-index-write.c (save_gdb_index_command): Update.
8455         * cp-support.c (add_symbol_overload_list_qualified): Update.
8456         * breakpoint.c (create_overlay_event_breakpoint)
8457         (create_longjmp_master_breakpoint)
8458         (create_std_terminate_master_breakpoint)
8459         (create_exception_master_breakpoint): Update.
8460         * blockframe.c (find_pc_partial_function): Update.
8461         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8462         (ada_collect_symbol_completion_matches)
8463         (ada_add_global_exceptions): Update.
8464
8465 2019-01-17  Tom Tromey  <tom@tromey.com>
8466
8467         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8468         declare VEC.
8469         (solib_target_parse_libraries): Change return type.
8470         (library_list_start_segment, library_list_start_section)
8471         (library_list_end_library, library_list_start_library); Update.
8472         (solib_target_free_library_list): Remove.
8473         (solib_target_parse_libraries): Remove cleanup.  Change return
8474         type.
8475         (solib_target_current_sos): Update.
8476
8477 2019-01-17  Tom Tromey  <tromey@bapiya>
8478
8479         * valprint.c: Replace "the the" with "the".
8480         * symtab.c: Replace "the the" with "the".
8481         * solib.c: Replace "the the" with "the".
8482         * solib-dsbt.c: Replace "the the" with "the".
8483         * linespec.c: Replace "the the" with "the".
8484         * dwarf2loc.h: Replace "the the" with "the".
8485         * amd64-windows-tdep.c: Replace "the the" with "the".
8486         * aarch64-tdep.c: Replace "the the" with "the".
8487
8488 2019-01-16  Keith Seitz  <keiths@redhat.com>
8489
8490         PR gdb/23773
8491         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8492         <builder>: Rename to ..
8493         <m_builder>: ... this and make private.
8494         (dwarf2_cu::get_builder): New method.  Change all users of
8495         `builder' to use this method.
8496         (dwarf2_start_symtab): Move to ...
8497         (dwarf2_cu::start_symtab): ... here.  Update all callers
8498         (setup_type_unit_groups): Move to ...
8499         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8500         callers.
8501         (dwarf2_cu::reset_builder): New method.
8502         (process_full_compunit, process_full_type_unit): Use
8503         dwarf2_cu::reset_builder.
8504         (follow_die_offset): Record the ancestor CU if it is different
8505         from the followed DIE's CU.
8506         (follow_die_sig_1): Likewise.
8507
8508 2019-01-15  Tom Tromey  <tom@tromey.com>
8509
8510         * remote.c (class remote_state) <buf>: Now a char_vector.
8511         <buf_size>: Remove.
8512         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8513         parameter.
8514         (remote_target::getpkt_or_notif_sane_1)
8515         (remote_target::getpkt_sane)
8516         (remote_target::getpkt_or_notif_sane): Likewise.
8517         (class remote_target) <putpkt>: New overload.
8518         (remote_target::read_frame): Change type of "buf_p".  Remove
8519         sizeof_p parameter.
8520         (packet_ok): New overload.
8521         (packet_check_result): New overload.
8522         Update all uses.
8523
8524 2019-01-14  Tom Tromey  <tom@tromey.com>
8525
8526         * remote-notif.c (handle_notification, remote_notif_ack)
8527         (remote_notif_parse): Make "buf" const.
8528         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8529         const.
8530         (remote_notif_parse, remote_notif_ack, handle_notification):
8531         Likewise.
8532         * remote.c (remote_notif_stop_parse): Make "buf" const.
8533         (remote_target::remote_parse_stop_reply): Make "buf" const.
8534         (remote_notif_stop_ack): Make "buf" const.
8535
8536 2019-01-14  Tom Tromey  <tom@tromey.com>
8537
8538         * remote.c (remote_console_output): Make parameter const.
8539
8540 2019-01-14  Tom Tromey  <tom@tromey.com>
8541
8542         * target-debug.h (target_debug_print_signals): Constify.
8543         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8544         * procfs.c (procfs_target::pass_signals): Update.
8545         * linux-nat.c (linux_nat_target::pass_signals): Update.
8546         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8547         * target-delegates.c: Rebuild.
8548         * remote.c (remote_target::program_signals): Update.
8549         (remote_target::pass_signals): Update.
8550         * target.c (target_pass_signals): Constify argument.
8551         (target_program_signals): Likewise.
8552         * target.h (struct target_ops) <pass_signals, program_signals>:
8553         Constify argument.
8554         (target_pass_signals, target_program_signals): Constify argument.
8555
8556 2019-01-14  Tom Tromey  <tom@tromey.com>
8557
8558         PR tui/28819:
8559         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8560
8561 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8562
8563         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8564         field.
8565         * rs6000-tdep.c: Include reggroups.h.
8566         (IS_V_ALIAS_PSEUDOREG): Define.
8567         (rs6000_register_name): Return names for the "vX" aliases.
8568         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8569         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8570         aliases.  Call default_register_reggroup_p for all other
8571         pseudo-registers.
8572         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8573         New functions.
8574         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8575         Handle "vX" aliases.
8576         (v_alias_pseudo_register_collect): New function.
8577         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8578         (rs6000_gdbarch_init): Initialize "vX" aliases as
8579         pseudo-registers.  Restore registration of
8580         rs6000_pseudo_register_reggroup_p with
8581         set_tdesc_pseudo_register_reggroup_p.
8582
8583 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8584
8585         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8586         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8587         set_gdbarch_num_pseudo_regs.
8588
8589 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8590
8591         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8592         Remove arg prefixname, add do_set and do_show.
8593         Add member functions set_list and show_list.
8594         * cli/cli-style.c (class cli_style_option): Update accordingly.
8595         (style_set_list): Move to file scope.
8596         (style_show_list): Likewise.
8597         (set_style): Call help_list.
8598         (show_style): Call cmd_show_list.
8599         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8600         Update to use the new macro.
8601
8602 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8603
8604         * ada-lang.c (_initialize_ada_language): Expand the help text
8605         for the "catch exception" command.
8606
8607 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8608
8609         * symtab.c (matching_obj_sections): Initialize obj,
8610         declare it closer to its usage.
8611
8612 2019-01-10  Tom Tromey  <tom@tromey.com>
8613
8614         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8615         (basic_inf_threads_range): Remove.
8616         (inf_threads_range, inf_non_exited_threads_range)
8617         (safe_inf_threads_range): Use next_adapter.
8618
8619 2019-01-10  Keith Seitz  <keiths@redhat.com>
8620
8621         PR gdb/23712
8622         PR symtab/23010
8623         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8624         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8625
8626 2019-01-10  Keith Seitz  <keiths@redhat.com>
8627
8628         PR gdb/23712
8629         PR symtab/23010
8630         * dictionary.c (pending_to_vector): Remove.
8631         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8632         Remove _1 suffix, replacing functions of the same name.  Update
8633         all callers.
8634         (dict_create_hashed, dict_create_hashed_expandable)
8635         (dict_create_linear, dict_create_linear_expandable, dict_free)
8636         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8637         Make functions static.
8638
8639 2019-01-10  Keith Seitz  <keiths@redhat.com>
8640
8641         PR gdb/23712
8642         PR symtab/23010
8643         * dictionary.h (struct dictionary): Replace declaration with
8644         multidictionary.
8645         (dict_create_hashed, dict_create_hashed_expandable)
8646         (dict_create_linear, dict_create_linear_expandable)
8647         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8648         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8649         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8650         taking multidictionary argument.
8651         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8652         * block.h (struct block) <dict>: Change to multidictionary
8653         and rename `multidict'.
8654         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8655         symmisc.c: Update all dictionary references to multidictionary.
8656
8657 2019-01-10  Keith Seitz  <keiths@redhat.com>
8658
8659         PR gdb/23712
8660         PR symtab/23010
8661         * dictionary.c: Include unordered_map.
8662         (pending_to_vector): New function.
8663         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8664         Rewrite the non-"_1" functions to take vector instead
8665         of linked list.
8666         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8667         "new" _1 versions of the same name.
8668         (multidictionary): Define.
8669         (std::hash<enum language): New definition.
8670         (collate_pending_symbols_by_language, mdict_create_hashed)
8671         (mdict_create_hashed_expandable, mdict_create_linear)
8672         (mdict_create_linear_expandable, mdict_free)
8673         (find_language_dictionary, create_new_language_dictionary)
8674         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8675         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8676         (mdict_size, mdict_empty): New functions.
8677         * dictionary.h (mdict_iterator): Define.
8678
8679 2019-01-10  Pedro Alves  <palves@redhat.com>
8680
8681         * breakpoint.c (read_uploaded_action)
8682         (create_tracepoint_from_upload): Adjust to use
8683         gdb::unique_xmalloc_ptr.
8684         * ctf.c (ctf_write_uploaded_tp):
8685         (SET_ARRAY_FIELD): Use emplace_back.
8686         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8687         * tracefile-tfile.c (tfile_write_uploaded_tp):
8688         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8689         gdb::unique_xmalloc_ptr.
8690         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8691         at_string, cond_string, cmd_strings>: Replace char pointers
8692         with gdb::unique_xmalloc_ptr.
8693
8694 2019-01-10  Pedro Alves  <palves@redhat.com>
8695
8696         * solib-target.c (library_list_start_library): Don't xstrdup name.
8697
8698 2019-01-10  Pedro Alves  <palves@redhat.com>
8699
8700         * mdebugread.c (parse_partial_symbols): Use
8701         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8702
8703 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8704
8705         * linux-fork.c (scoped_switch_fork_info)
8706         <~scoped_switch_fork_info>: Fix incorrect variable name.
8707
8708 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8709
8710         * linux-fork.c (scoped_switch_fork_info)
8711         <scoped_switch_fork_info>: Make explicit.
8712         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8713
8714 2019-01-10  Tom Tromey  <tom@tromey.com>
8715
8716         * objfiles.h (objfile::reset_psymtabs): Update.
8717         * objfiles.c (objfile::objfile): Update.
8718         * psymtab.h (psymtab_storage::obstack): Update.
8719         (psymtab_storage::m_obstack): Use gdb::optional.
8720         (class psymtab_storage): Update comment.  Remove objfile
8721         parameter.
8722         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8723
8724 2019-01-10  Tom Tromey  <tom@tromey.com>
8725
8726         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8727         <free_psymtabs>: Now private.
8728         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8729         (allocate_psymtab): Use new method.
8730
8731 2019-01-10  Tom Tromey  <tom@tromey.com>
8732
8733         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8734         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8735         * mdebugread.c (parse_partial_symbols): Use
8736         allocate_dependencies.
8737         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8738         allocate_dependencies.
8739         (process_psymtab_comp_unit_reader)
8740         (build_type_psymtab_dependencies): Likewise.
8741         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8742
8743 2019-01-10  Tom Tromey  <tom@tromey.com>
8744
8745         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8746         PSYMBOL_SET_LANGUAGE.
8747         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8748
8749 2019-01-10  Tom Tromey  <tom@tromey.com>
8750
8751         * psymtab.h (psymtab_storage::obstack): New method.
8752         <m_obstack>: Rename from obstack; now private.
8753         * psymtab.c (psymtab_storage): Update.
8754         * dwarf2read.c (create_addrmap_from_index)
8755         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8756         Update.
8757
8758 2019-01-10  Tom Tromey  <tom@tromey.com>
8759
8760         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8761         * objfiles.h (objfile::reset_psymtabs): New method.
8762
8763 2019-01-10  Tom Tromey  <tom@tromey.com>
8764
8765         * symmisc.c (print_symbol_bcache_statistics): Update.
8766         (print_objfile_statistics): Update.
8767         * symfile.c (reread_symbols): Update.
8768         * psymtab.h (class psymtab_storage): New.
8769         * psymtab.c (psymtab_storage): New constructor.
8770         (~psymtab_storage): New destructor.
8771         (require_partial_symbols): Update.
8772         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8773         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8774         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8775         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8776         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8777         (start_psymtab_common, end_psymtab_common)
8778         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8779         (allocate_psymtab): Update.
8780         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8781         Update.
8782         (dump_psymtab_addrmap, maintenance_print_psymbols)
8783         (maintenance_check_psymtabs): Update.
8784         (class objfile_psymtabs): Move to objfiles.h.
8785         * psympriv.h (discard_psymtab): Now inline.
8786         (psymtab_discarder::psymtab_discarder): Update.
8787         (psymtab_discarder::~psymtab_discarder): Update.
8788         (ALL_OBJFILE_PSYMTABS): Rewrite.
8789         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8790         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8791         Remove fields.
8792         <partial_symtabs>: New field.
8793         (class objfile_psymtabs): Move from psymtab.h.  Update.
8794         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8795         psymbol_cache.
8796         (objfile::~objfile): Don't destroy psymbol_cache.
8797         * mdebugread.c (parse_partial_symbols): Update.
8798         * dwarf2read.c (create_addrmap_from_index)
8799         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8800         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8801         (add_partial_subprogram, dwarf2_ranges_read): Update.
8802         * dwarf-index-write.c (write_address_map)
8803         (write_one_signatured_type, recursively_write_psymbols)
8804         (class debug_names, class debug_names, write_psymtabs_to_index):
8805         Update.
8806
8807 2019-01-10  Tom Tromey  <tom@tromey.com>
8808
8809         * symtab.h (SYMBOL_SET_NAMES): Update.
8810         (symbol_set_names): Update.
8811         (MSYMBOL_SET_NAMES): Update.
8812         * symtab.c (symbol_set_names): Change argument to be an
8813         objfile_per_bfd_storage.
8814         * psymtab.c (add_psymbol_to_bcache): Update.
8815         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8816
8817 2019-01-10  Tom Tromey  <tom@tromey.com>
8818
8819         * symtab.c (create_demangled_names_hash): Change argument to be an
8820         objfile_per_bfd_storage.
8821         (symbol_set_names): Update.
8822
8823 2019-01-10  Tom Tromey  <tom@tromey.com>
8824
8825         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8826         init_psymbol_list.
8827         * psymtab.c (init_psymbol_list): Do nothing if already called.
8828         * psympriv.h (init_psymbol_list): Add comment.
8829         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8830         init_psymbol_list.
8831         * dbxread.c (dbx_symfile_read): Unconditionally call
8832         init_psymbol_list.
8833
8834 2019-01-10  Tom Tromey  <tom@tromey.com>
8835
8836         * xcoffread.c (scan_xcoff_symtab): Update.
8837         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8838         "where".
8839         * mdebugread.c (parse_partial_symbols)
8840         (handle_psymbol_enumerators): Update.
8841         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8842         * dbxread.c (read_dbx_symtab): Update.
8843         * psympriv.h (psymbol_placement): New enum.
8844         (add_psymbol_to_list): Update.
8845
8846 2019-01-10  Tom Tromey  <tom@tromey.com>
8847
8848         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8849         static_psymbols parameters.
8850         (scan_xcoff_symtab): Update.
8851         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8852         static_psymbols parameters.
8853         * psympriv.h (start_psymtab_common): Update.
8854         * mdebugread.c (parse_partial_symbols): Update.
8855         * dwarf2read.c (create_partial_symtab): Update.
8856         * dbxread.c (read_dbx_symtab): Update.
8857         (start_psymtab): Remove global_psymbols and static_psymbols
8858         parameters.
8859
8860 2019-01-10  Tom Tromey  <tom@tromey.com>
8861
8862         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8863         * psymtab.c (allocate_psymtab): Add comment.
8864         * psympriv.h (allocate_psymtab): Add comment.
8865         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8866         initializations.
8867         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8868
8869 2019-01-10  Tom Tromey  <tom@tromey.com>
8870
8871         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8872         Don't declare.
8873         * mipsread.c: Include mdebugread.h.
8874         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8875         Declare.
8876         * elfread.c: Include mdebugread.h.
8877
8878 2019-01-09  Tom Tromey  <tom@tromey.com>
8879
8880         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8881         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8882         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8883         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8884         (psym_lookup_symbol, psym_find_last_source_symtab)
8885         (psym_forget_cached_source_info, psym_print_stats)
8886         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8887         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8888         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8889         (psym_find_compunit_symtab_by_address)
8890         (maintenance_print_psymbols, maintenance_info_psymtabs)
8891         (maintenance_check_psymtabs): Use ranged for.
8892         * psymtab.h (class objfile_psymtabs): New.
8893         (require_partial_symbols): Return objfile_psymtabs.
8894         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8895
8896 2019-01-09  Tom Tromey  <tom@tromey.com>
8897
8898         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8899         (find_pc_mapped_section, list_overlays_command)
8900         (map_overlay_command, unmap_overlay_command)
8901         (simple_overlay_update): Use all_objfiles.
8902         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8903         * printcmd.c (info_symbol_command): Use all_objfiles.
8904         * objfiles.h (ALL_OBJSECTIONS): Remove.
8905         * maint.c (maintenance_translate_address): Use all_objfiles.
8906         * gcore.c (gcore_create_callback): Use all_objfiles.
8907         (objfile_find_memory_regions): Likewise.
8908
8909 2019-01-09  Tom Tromey  <tom@tromey.com>
8910
8911         * symtab.c (find_line_symtab, info_sources_command)
8912         (make_source_files_completion_list): Use objfile_compunits.
8913         * source.c (select_source_symtab): Use objfile_compunits.
8914         * objfiles.h (struct objfile): Update comment.
8915         (ALL_OBJFILES): Remove.
8916         (ALL_FILETABS): Remove.
8917         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8918         objfile_compunits.
8919
8920 2019-01-09  Tom Tromey  <tom@tromey.com>
8921
8922         * symmisc.c (print_objfile_statistics, dump_objfile)
8923         (maintenance_print_symbols): Use compunit_filetabs.
8924         * source.c (forget_cached_source_info_for_objfile): Use
8925         compunit_filetabs.
8926         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8927         (ALL_FILETABS): Use compunit_filetabs.
8928         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8929         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8930
8931 2019-01-09  Tom Tromey  <tom@tromey.com>
8932
8933         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8934         (compunit_filetabs): New.
8935         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8936         compunit_filetabs.
8937         (info_sources_command, make_source_files_completion_list): Remove
8938         declaration.
8939         * symmisc.c (print_objfile_statistics, dump_objfile)
8940         (maintenance_print_symbols): Remove declaration.
8941         (maintenance_info_symtabs): Use compunit_filetabs.
8942         (maintenance_info_line_tables): Likewise.
8943         * source.c (select_source_symtab): Change local variable name.
8944         (forget_cached_source_info_for_objfile): Remove declaration.
8945         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8946         * objfiles.c (objfile_relocate1): Remove declaration.
8947         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8948         declaration.
8949         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8950         * coffread.c (coff_symtab_read): Remove declaration.
8951         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8952         compunit_filetabs.
8953
8954 2019-01-09  Tom Tromey  <tom@tromey.com>
8955
8956         * symtab.c (lookup_objfile_from_block)
8957         (find_pc_sect_compunit_symtab, search_symbols)
8958         (default_collect_symbol_completion_matches_break_on): Use
8959         objfile_compunits.
8960         * objfiles.h (ALL_COMPUNITS): Remove.
8961         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8962         * cp-support.c (add_symbol_overload_list_qualified): Use
8963         objfile_compunits.
8964         * ada-lang.c (ada_collect_symbol_completion_matches)
8965         (ada_add_global_exceptions): Use objfile_compunits.
8966
8967 2019-01-09  Tom Tromey  <tom@tromey.com>
8968
8969         * source.c (select_source_symtab)
8970         (forget_cached_source_info_for_objfile): Remove declaration.
8971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8972         declaration.
8973         * maint.c (count_symtabs_and_blocks): Remove declaration.
8974         * cp-support.c (add_symbol_overload_list_qualified): Remove
8975         declaration.
8976         * coffread.c (coff_symtab_read): Remove declaration.
8977         * symtab.c (lookup_symbol_in_objfile_symtabs)
8978         (basic_lookup_transparent_type_1): Use objfile_compunits.
8979         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8980         (info_sources_command, search_symbols)
8981         (default_collect_symbol_completion_matches_break_on)
8982         (make_source_files_completion_list): Remove declaration.
8983         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8984         (ada_collect_symbol_completion_matches)
8985         (ada_add_global_exceptions): Remove declaration.
8986         * linespec.c (iterate_over_all_matching_symtabs): Use
8987         objfile_compunits.
8988         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8989         (class objfile_compunits): New.
8990         (ALL_COMPUNITS): Use objfile_compunits.
8991         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8992         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8993         objfile_compunits.
8994         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8995
8996 2019-01-09  Tom Tromey  <tom@tromey.com>
8997
8998         * symtab.c (search_symbols)
8999         (default_collect_symbol_completion_matches_break_on): Use
9000         objfile_msymbols.
9001         * ada-lang.c (ada_lookup_simple_minsym)
9002         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9003         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9004         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9005         objfile_msymbols.
9006         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9007         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9008         * objc-lang.c (find_methods): Use objfile_msymbols.
9009         (info_selectors_command, info_classes_command): Likewise.
9010         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9011         * objfiles.h (class objfile_msymbols): New.
9012         (ALL_OBJFILE_MSYMBOLS): Remove.
9013         (ALL_MSYMBOLS): Remove.
9014
9015 2019-01-09  Tom Tromey  <tom@tromey.com>
9016
9017         * common/next-iterator.h (next_adapter): Add Iterator template
9018         parameter.
9019         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9020         (class all_objfiles_safe): New.
9021         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9022         * objfiles.c (put_objfile_before): Update comment.
9023         (add_separate_debug_objfile): Likewise.
9024         (free_all_objfiles): Use all_objfiles_safe.
9025         (objfile_purge_solibs): Likewise.
9026
9027 2019-01-09  Tom Tromey  <tom@tromey.com>
9028
9029         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9030         (expand_symtab_containing_pc, lookup_static_symbol)
9031         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9032         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9033         all_objfiles.
9034         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9035         * breakpoint.c (create_overlay_event_breakpoint)
9036         (create_longjmp_master_breakpoint)
9037         (create_std_terminate_master_breakpoint)
9038         (create_exception_master_breakpoint): Use all_objfiles.
9039         * linux-thread-db.c (try_thread_db_load_from_pdir)
9040         (has_libpthread): Use all_objfiles.
9041         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9042         * linespec.c (iterate_over_all_matching_symtabs)
9043         (search_minsyms_for_name): Use all_objfiles.
9044         * maint.c (maintenance_info_sections): Use all_objfiles.
9045         * main.c (captured_main_1): Use all_objfiles.
9046         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9047         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9048         * guile/scm-pretty-print.c
9049         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9050         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9051         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9052         (maintenance_print_msymbols): Use all_objfiles.
9053         * source.c (select_source_symtab): Use all_objfiles.
9054         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9055         * symfile.c (remove_symbol_file_command)
9056         (expand_symtabs_matching, map_symbol_filenames): Use
9057         all_objfiles.
9058         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9059         all_objfiles.
9060         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9061         * objc-lang.c (find_methods): Use all_objfiles.
9062         * objfiles.c (have_partial_symbols, have_full_symbols)
9063         (have_minimal_symbols, qsort_cmp)
9064         (default_iterate_over_objfiles_in_search_order): Use
9065         all_objfiles.
9066         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9067         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9068         (maintenance_check_psymtabs): Use all_objfiles.
9069         (ALL_PSYMTABS): Remove.
9070         * compile/compile-object-run.c (do_module_cleanup): Use
9071         all_objfiles.
9072         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9073         * cp-support.c (add_symbol_overload_list_qualified): Use
9074         all_objfiles.
9075         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9076         Use all_objfiles.
9077         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9078         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9079         all_objfiles.
9080         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9081         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9082         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9083         Uses all_objfiles.
9084         * solib.c (solib_read_symbols): Use all_objfiles
9085
9086 2019-01-09  Tom Tromey  <tom@tromey.com>
9087
9088         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9089         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9090         all_objfiles.
9091         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9092         * symmisc.c (print_symbol_bcache_statistics)
9093         (print_objfile_statistics, maintenance_print_objfiles)
9094         (maintenance_info_symtabs, maintenance_check_symtabs)
9095         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9096         all_objfiles.
9097         * source.c (forget_cached_source_info): Use all_objfiles.
9098         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9099         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9100         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9101         * objfiles.c (update_section_map): Use all_objfiles.
9102         (shared_objfile_contains_address_p): Likewise.
9103         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9104         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9105
9106 2019-01-09  Tom Tromey  <tom@tromey.com>
9107
9108         * common/next-iterator.h: New file.
9109         * objfiles.h (class all_objfiles): New.
9110         (struct objfile_iterator): New.
9111
9112 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9113
9114         * NEWS: Move the description of the changed "frame", "select-frame",
9115          and "info frame" commands to the Changed commands section.
9116
9117 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9118
9119         * gdbtypes.c (check_stub_method_group): Remove handling of old
9120         mangling schemes.
9121         * linespec.c (find_methods): Likewise.
9122         * stabsread.c (read_member_functions): Likewise.
9123         * valops.c (search_struct_method): Likewise.
9124         (value_struct_elt_for_reference): Likewise.
9125         * NEWS: Mention this change.
9126
9127 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9128
9129         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9130         print_source_lines.
9131         * source.c (print_source_lines_base): Update line number check.
9132         (print_source_lines): New function.
9133         (source_lines_range::source_lines_range): New function.
9134         * source.h (class source_lines_range): New class.
9135         (print_source_lines): New declaration.
9136
9137 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9138
9139         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9140
9141 2019-01-08  Tom Tromey  <tom@tromey.com>
9142             Simon Marchi  <simon.marchi@ericsson.com>
9143
9144         PR gdb/24060
9145         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9146         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9147         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9148         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9149         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9150         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9151
9152 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9153
9154         * source.c (select_source_symtab): Move header comment to
9155         declaration in source.h.
9156         (forget_cached_source_info_for_objfile): Likewise.
9157         (forget_cached_source_info): Likewise.
9158         (identify_source_line): Likewise.
9159         * source.h (identify_source_line): Move declaration from symtab.h
9160         and add comment from source.c
9161         (print_source_lines): Likewise.
9162         (forget_cached_source_info_for_objfile): Likewise.
9163         (forget_cached_source_info): Likewise.
9164         (select_source_symtab): Likewise.
9165         (enum print_source_lines_flag): Move definition from symtab.h.
9166         * symtab.h (identify_source_line): Move declaration to source.h.
9167         (print_source_lines): Likewise.
9168         (forget_cached_source_info_for_objfile): Likewise.
9169         (forget_cached_source_info): Likewise.
9170         (select_source_symtab): Likewise.
9171         (enum print_source_lines_flag): Move definition to source.h.
9172         * tui/tui-hooks.c: Add 'source.h' include.
9173
9174 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9175
9176         * source.c (print_source_lines_base): Handle requests to print
9177         reverse line number sequences, and guard against empty lines
9178         string.
9179
9180 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9181
9182         * source.c (print_source_lines_base): Fix skip of '\r' if next
9183         character is '\n'.
9184
9185 2019-01-06  Tom Tromey  <tom@tromey.com>
9186
9187         * c-exp.y (struct c_parse_state) <macro_original_text,
9188         expansion_obstack>: New member.
9189         (macro_original_text, expansion_obstack): Remove globals.
9190         (scan_macro_expansion, scanning_macro_expansion)
9191         (finished_macro_expansion): Update.
9192         (scan_macro_cleanup): Remove.
9193         (yylex, c_parse): Update.
9194
9195 2019-01-06  Tom Tromey  <tom@tromey.com>
9196
9197         * c-exp.y (struct c_parse_state) <strings>: New member.
9198         (operator_stoken): Update.
9199
9200 2019-01-06  Tom Tromey  <tom@tromey.com>
9201
9202         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9203         (union type_stack_elt) <typelist_val>: Now a pointer to
9204         std::vector.
9205         (type_stack_cleanup): Don't declare.
9206         (push_typelist): Update.
9207         * parse.c (pop_typelist): Return a std::vector.
9208         (push_typelist): Take a std::vector.
9209         (follow_types): Update.  Do not free args.
9210         (type_stack_cleanup): Remove.
9211         * c-exp.y (struct c_parse_state): New.
9212         (cpstate): New global.
9213         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9214         (nonempty_typelist): Update.
9215         (func_mod): Create a new vector.
9216         (c_parse): Create a c_parse_state.
9217         (check_parameter_typelist): Do not delete params.
9218         (function_method): Update.  Do not delete type_list.
9219
9220 2019-01-06  Tom Tromey  <tom@tromey.com>
9221
9222         PR gdb/28155:
9223         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9224         check_typedef.
9225         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9226         (print_return_value): Likewise.
9227
9228 2019-01-05  Tom Tromey  <tom@tromey.com>
9229
9230         * contrib/cleanup_check.py: Remove.
9231         * contrib/gcc-with-excheck: Remove.
9232         * contrib/exsummary.py: Remove.
9233         * contrib/excheck.py: Remove.
9234
9235 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9236
9237         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9238         NULL. Initialize tpprev to NULL instead of assigning it
9239         to NULL on the next statement.
9240         * windows-nat.c (windows_delete_thread): Remove check for
9241         main_thread_id before printing thread exit notifications.
9242         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9243         Remove thread ID check against main_thread_id.
9244         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9245         windows_delete_thread.
9246         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9247
9248 2019-01-04  Tom Tromey  <tom@tromey.com>
9249
9250         * compile/compile.c (_initialize_compile): Use upper case for
9251         metasyntactic variables.
9252         * symmisc.c (_initialize_symmisc): Use upper case for
9253         metasyntactic variables.
9254         * psymtab.c (_initialize_psymtab): Use upper case for
9255         metasyntactic variables.
9256         * demangle.c (demangle_command): Use upper case for metasyntactic
9257         variables.
9258         (_initialize_demangler): Likewise.
9259         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9260         variables.
9261
9262 2019-01-03  Tom Tromey  <tom@tromey.com>
9263
9264         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9265
9266 2019-01-03  Tom Tromey  <tom@tromey.com>
9267
9268         * python/py-symtab.c (salpy_str): Update.
9269         (struct salpy_sal_object) <symtab>: Now a PyObject.
9270         (salpy_dealloc): Update.
9271         (del_objfile_sal): Use gdbpy_ref.
9272
9273 2019-01-03  Tom Tromey  <tom@tromey.com>
9274
9275         * python/py-type.c (convert_field): Use new_reference.  Return
9276         gdbpy_ref.
9277         (make_fielditem): Return gdbpy_ref.
9278         (typy_fields): Update.
9279         (typy_getitem): Update.
9280         (field_name): Return gdbpy_ref.  Use new_reference.
9281         (typy_iterator_iternext): Update.
9282
9283 2019-01-03  Tom Tromey  <tom@tromey.com>
9284
9285         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9286
9287 2019-01-03  Tom Tromey  <tom@tromey.com>
9288
9289         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9290         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9291         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9292         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9293         (pspy_set_type_printers): Likewise.
9294         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9295         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9296         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9297         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9298         (objfpy_set_type_printers): Likewise.
9299
9300 2019-01-03  Tom Tromey  <tom@tromey.com>
9301
9302         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9303         (gdbpy_print_stack): Use gdbpy_err_fetch.
9304         * python/python-internal.h (class gdbpy_err_fetch): New class.
9305         (class gdbpy_enter) <m_error_type, m_error_value,
9306         m_error_traceback>: Remove.
9307         <m_error>: New member.
9308         (gdbpy_exception_to_string): Don't declare.
9309         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9310         * python/py-value.c (convert_value_from_python): Use
9311         gdbpy_err_fetch.
9312         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9313         gdbpy_exception_to_string.
9314         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9315         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9316         gdbpy_err_fetch.
9317
9318 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9319
9320         * linux-nat.c (delete_lwp_cleanup): Delete.
9321         (struct lwp_deleter): New struct.
9322         (lwp_info_up): New typedef.
9323         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9324         lwp_info_up.
9325
9326 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * linux-fork.c (class scoped_switch_fork_info): New class.
9329         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9330
9331 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9332
9333         * valops.c (find_overload_match): Remove use of null_cleanup, and
9334         calls to do_cleanups.
9335
9336 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9337
9338         * compile/compile-cplus-types.c
9339         (compile_cplus_instance::decl_name): Handle changes to
9340         cp_func_name.
9341         * cp-support.c (cp_func_name): Update header comment, update
9342         return type.
9343         * cp-support.h (cp_func_name): Update return type in declaration.
9344         * valops.c (find_overload_match): Move temp_func local to top
9345         level of function and change its type.  Use temp_func to hold and
9346         delete temporary string obtained from cp_func_name.
9347
9348 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9349
9350         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9351         gdb::char_vector, remove cleanup, and update uses of `msg`.
9352
9353 2019-01-03  Jim Wilson  <jimw@sifive.com>
9354
9355         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9356
9357 2019-01-02  Tom Tromey  <tom@tromey.com>
9358
9359         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9360         (tdesc_parse_xml): Remove cleanups.
9361         * target-descriptions.h (make_cleanup_free_target_description):
9362         Don't declare.
9363         (target_desc_deleter): New struct.
9364         (target_desc_up): New typedef.
9365         * target-descriptions.c (target_desc_deleter::operator()): Rename
9366         from free_target_description.
9367         (make_cleanup_free_target_description): Remove.
9368
9369 2019-01-02  Tom Tromey  <tom@tromey.com>
9370
9371         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9372         constructor, destructor.
9373         (linespec_parser): Remove typedef.
9374         (~linespec_parser): Rename from linespec_parser_delete.
9375         (linespec_lex_to_end, linespec_complete_label)
9376         (linespec_complete): Update.
9377         (decode_line_full): Remove cleanups.
9378         (decode_line_1): Update.
9379
9380 2019-01-02  Tom Tromey  <tom@tromey.com>
9381
9382         * python/python-internal.h (inferior_to_inferior_object): Change
9383         return type.
9384         * python/py-exitedevent.c (create_exited_event_object): Update.
9385         * python/py-inferior.c (inferior_to_inferior_object): Return
9386         gdbpy_ref.
9387         (python_new_inferior, python_inferior_deleted)
9388         (thread_to_thread_object, delete_thread_object)
9389         (build_inferior_list, gdbpy_selected_inferior): Update.
9390         * python/py-infthread.c (create_thread_object): Update.  Also fail
9391         if inferior_to_inferior_object fails.
9392
9393 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9394
9395         * inferior.h (class inferior) <displaced_step_state>: New field.
9396         * infrun.h (struct displaced_step_state): Move here from
9397         infrun.c.  Initialize fields, add constructor.
9398         <inf>: Remove field.
9399         <reset>: New method.
9400         * infrun.c (struct displaced_step_inferior_state): Move to
9401         infrun.h.
9402         (displaced_step_inferior_states): Remove.
9403         (get_displaced_stepping_state): Adust.
9404         (displaced_step_in_progress_any_inferior): Adjust.
9405         (displaced_step_in_progress_thread): Adjust.
9406         (displaced_step_in_progress): Adjust.
9407         (add_displaced_stepping_state): Remove.
9408         (get_displaced_step_closure_by_addr): Adjust.
9409         (remove_displaced_stepping_state): Remove.
9410         (infrun_inferior_exit): Call displaced_step_state.reset.
9411         (use_displaced_stepping): Don't check for NULL.
9412         (displaced_step_prepare_throw): Call
9413         get_displaced_stepping_state.
9414         (displaced_step_fixup): Don't check for NULL.
9415         (prepare_for_detach): Don't check for NULL.
9416
9417 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9418
9419         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9420          in case of call that did not complete.
9421
9422 2019-01-02  Andrey Utkin  <autkin@undo.io>
9423
9424         * symfile.c (find_separate_debug_file): Fix search of debug files for
9425         remote debuggee.
9426
9427 2019-01-02  Tom Tromey  <tom@tromey.com>
9428
9429         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9430         indentation.
9431         * python/py-frame.c (frapy_older): Remove cast.
9432         (frapy_newer): Likewise.
9433         * python/py-breakpoint.c (local_setattro): Remove cast.
9434         * python/py-arch.c (archpy_name): Remove local variable.
9435         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9436
9437 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9438
9439         * unittests/basic_string_view/element_access/char/empty.cc:
9440         Fix year range in copyright header.
9441
9442 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9443
9444         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9445         Delete.
9446         <operator==>: Update with for removed field.
9447         <hash>: Likewise.
9448         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9449         <isa_features>: ...this.
9450         <abi_features>: New field.
9451         (riscv_isa_flen): Update comment.
9452         (riscv_abi_xlen): New declaration.
9453         (riscv_abi_flen): New declaration.
9454         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9455         isa_features.
9456         (riscv_abi_xlen): New function.
9457         (riscv_isa_flen): Update to get answer from isa_features.
9458         (riscv_abi_flen): New function.
9459         (riscv_has_fp_abi): Update to get answer from abi_features.
9460         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9461         xlen and flen.
9462         (riscv_call_info) <xlen, flen>: Update comment.
9463         (riscv_call_arg_struct): Remove invalid assertions
9464         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9465         is removed.
9466         (riscv_gdbarch_init): Gather isa features and abi features
9467         separately, ensure both match on the gdbarch when reusing an old
9468         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9469         a target with 64-bit float hardware.
9470
9471 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9472
9473         * source.c (search_command_helper): Stop reverse search
9474         when line 1 has been searched.
9475
9476 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9477
9478         * record-full.c (record_full_base_target::close): Rewrite
9479         record_full_core_buf_list free logic.
9480
9481 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9482
9483         * break-catch-syscall.c (print_one_catch_syscall): xfree
9484         the last text.
9485
9486 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9487
9488         * top.c (print_gdb_version): Update Copyright year in version
9489         message.
9490
9491 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9492
9493         Update copyright year range in all GDB files.
9494
9495 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9496
9497         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9498
9499 For older changes see ChangeLog-2018.
9500 \f
9501 Local Variables:
9502 mode: change-log
9503 left-margin: 8
9504 fill-column: 74
9505 version-control: never
9506 coding: utf-8
9507 End:
9508