gdb/ChangeLog

   1 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * MAINTAINERS: Update my email address.
   4
   5 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * build-id.c (build_id_to_debug_bfd_1): New function.
   8         (build_id_to_debug_bfd): Look for separate debug file in
   9         sysroot.
  10
  11 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  12
  13         * gdbarch.sh: Update the copyright year range that is placed into
  14         generated files.
  15
  16 2019-02-22  Keith Seitz  <keiths@redhat.com>
  17
  18         PR symtab/23853
  19         * linespec.c (create_sals_line_offset): Search for the default
  20         symtab's filename instead of its fullname.
  21
  22 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * NEWS: Update style defaults.
  25
  26 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * main.c (captured_main_1): Disable styling in batch mode.
  29
  30 2019-02-20  Tom Tromey  <tom@tromey.com>
  31
  32         * symtab.c (symtab_symbol_info): Fix typos.
  33
  34 2019-02-20  Tom Tromey  <tromey@adacore.com>
  35
  36         * findcmd.c (_initialize_mem_search): Use upper case for
  37         metasyntactic variables.
  38
  39 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  40
  41         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  42         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  43
  44 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  45
  46         * top.h (source_file_name): Change to std::string.
  47         * top.c (source_file_name): Likewise.
  48         (command_line_input): Adjust.
  49         * cli/cli-script.c (script_from_file): Adjust.
  50
  51 2019-02-19  Tom Tromey  <tromey@adacore.com>
  52
  53         * ravenscar-thread.c
  54         (ravenscar_thread_target::update_thread_list): Don't call
  55         ada_build_task_list.
  56         * ada-lang.h (ada_build_task_list): Don't declare.
  57         * ada-tasks.c (struct ada_tasks_inferior_data)
  58         <task_list_valid_p>: Now bool.
  59         (read_known_tasks, ada_task_list_changed)
  60         (ada_tasks_invalidate_inferior_data): Update.
  61         (read_known_tasks_array): Return bool.
  62         (read_known_tasks_list): Likewise.
  63         (read_known_tasks): Return void.
  64         (ada_build_task_list): Now static.
  65
  66 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  67
  68         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  69         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  70
  71 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  72
  73         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  74         variant for ada_tasks_pspace_data_handle and
  75         ada_tasks_inferior_data_handle.
  76         (ada_tasks_pspace_data_cleanup): New function.
  77         (ada_tasks_inferior_data_cleanup): New function.
  78
  79 2019-02-17  Tom Tromey  <tom@tromey.com>
  80
  81         * macrotab.h (macro_source_fullname): Return a std::string.
  82         * macrotab.c (macro_include, check_for_redefinition)
  83         (macro_undef, macro_lookup_definition, foreach_macro)
  84         (foreach_macro_in_scope): Update.
  85         (macro_source_fullname): Return a std::string.
  86         * macrocmd.c (show_pp_source_pos): Update.
  87
  88 2019-02-17  Tom Tromey  <tom@tromey.com>
  89
  90         * macrocmd.c (show_pp_source_pos): Style the file names.
  91
  92 2019-02-17  Tom Tromey  <tom@tromey.com>
  93
  94         PR tui/24197:
  95         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  96
  97 2019-02-17  Tom Tromey  <tom@tromey.com>
  98
  99         * ada-lang.c (user_select_syms): Use filtered printing.
 100         * utils.c (wrap_style): New global.
 101         (desired_style): Remove.
 102         (emit_style_escape): Add stream parameter.
 103         (set_output_style, reset_terminal_style, prompt_for_continue):
 104         Update.
 105         (flush_wrap_buffer): Only flush gdb_stdout.
 106         (wrap_here): Set wrap_style.
 107         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 108         treat escape sequences as a character.  Change when wrap buffer is
 109         flushed.
 110         (fputs_styled): Do not set the output style when the default is
 111         requested.
 112         * ui-style.h (struct ui_file_style) <is_default>: New method.
 113         * source.c (print_source_lines_base): Emit escape sequences in one
 114         piece.
 115
 116 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 117
 118         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 119         integers and enumeration types.
 120
 121 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 122
 123         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 124         instead of lookup_symbol_in_language
 125         (do_exact_match): New function.
 126         (ada_get_symbol_name_matcher): Return do_exact_match when
 127         doing a verbatim match.
 128
 129 2019-02-15  Tom Tromey  <tromey@adacore.com>
 130
 131         * ravenscar-thread.c (ravenscar_thread_target::resume)
 132         (ravenscar_thread_target::wait): Special case wildcard requests.
 133
 134 2019-02-15  Tom Tromey  <tromey@adacore.com>
 135
 136         * ravenscar-thread.c (base_ptid): Remove.
 137         (struct ravenscar_thread_target) <close>: New method.
 138         <m_base_ptid>: New member.
 139         <update_inferior_ptid, active_task, task_is_currently_active,
 140         runtime_initialized>: Declare methods.
 141         <ravenscar_thread_target>: Add constructor.
 142         (ravenscar_thread_target::task_is_currently_active)
 143         (ravenscar_thread_target::update_inferior_ptid)
 144         (ravenscar_runtime_initialized): Rename.  Now methods.
 145         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 146         (ravenscar_thread_target::update_thread_list): Update.
 147         (ravenscar_thread_target::active_task): Now method.
 148         (ravenscar_thread_target::store_registers)
 149         (ravenscar_thread_target::prepare_to_store)
 150         (ravenscar_thread_target::prepare_to_store)
 151         (ravenscar_thread_target::mourn_inferior): Update.
 152         (ravenscar_inferior_created): Use "new" to create target.
 153         (ravenscar_thread_target::get_ada_task_ptid): Update.
 154         (_initialize_ravenscar): Don't initialize base_ptid.
 155         (ravenscar_ops): Remove global.
 156
 157 2019-02-15  Tom Tromey  <tromey@adacore.com>
 158
 159         * target.h (push_target): Declare new overload.
 160         * target.c (push_target): New overload, taking an rvalue reference.
 161         * remote.c (remote_target::open_1): Use push_target overload.
 162         * corelow.c (core_target_open): Use push_target overload.
 163
 164 2019-02-15  Tom Tromey  <tromey@adacore.com>
 165
 166         * ravenscar-thread.c (is_ravenscar_task)
 167         (ravenscar_task_is_currently_active): Return bool.
 168         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 169         (_initialize_ravenscar): Remove "(void)".
 170         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 171         Return bool.
 172
 173 2019-02-15  Tom Tromey  <tromey@adacore.com>
 174
 175         * ravenscar-thread.c (ravenscar_runtime_initializer)
 176         (has_ravenscar_runtime, get_running_thread_id)
 177         (ravenscar_thread_target::resume): Fix indentation.
 178
 179 2019-02-15  Tom Tromey  <tromey@adacore.com>
 180
 181         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 182         from ravenscar_arch_ops.
 183         (sparc_ravenscar_ops::fetch_registers)
 184         (sparc_ravenscar_ops::store_registers): Now methods.
 185         (sparc_ravenscar_prepare_to_store): Remove.
 186         (sparc_ravenscar_ops): Redefine.
 187         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 188         methods and destructor.  Remove members.
 189         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 190         (ravenscar_thread_target::store_registers)
 191         (ravenscar_thread_target::prepare_to_store): Update.
 192         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 193         Remove.
 194         (struct ppc_ravenscar_powerpc_ops): Derive from
 195         ravenscar_arch_ops.
 196         (ppc_ravenscar_powerpc_ops::fetch_registers)
 197         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 198         (ppc_ravenscar_powerpc_ops): Redefine.
 199         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 200         (ppc_ravenscar_e500_ops::fetch_registers)
 201         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 202         (ppc_ravenscar_e500_ops): Redefine.
 203         * aarch64-ravenscar-thread.c
 204         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 205         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 206         (aarch64_ravenscar_fetch_registers)
 207         (aarch64_ravenscar_store_registers): Now methods.
 208         (aarch64_ravenscar_ops): Redefine.
 209
 210 2019-02-15  Tom Tromey  <tromey@adacore.com>
 211
 212         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 213         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 214         (ravenscar_thread_target::stopped_by_watchpoint)
 215         (ravenscar_thread_target::stopped_data_address)
 216         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 217
 218 2019-02-15  Tom Tromey  <tromey@adacore.com>
 219
 220         * ravenscar-thread.c: Fix some typos.
 221
 222 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 223             Tom Tromey  <tromey@adacore.com>
 224
 225         * ada-lang.c (ada_exception_sal): Change addr_string to a
 226         std::string.
 227         (create_ada_exception_catchpoint): Update.
 228
 229 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 230             Tom Tromey  <tromey@adacore.com>
 231
 232         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 233         (bp_location_ops): Remove.
 234         (base_breakpoint_allocate_location): Update.
 235         (free_bp_location): Update.
 236         * ada-lang.c (class ada_catchpoint_location)
 237         <ada_catchpoint_location>: Remove ops parameter.
 238         (ada_catchpoint_location_dtor): Remove.
 239         (ada_catchpoint_location_ops): Remove.
 240         (allocate_location_exception): Update.
 241         * breakpoint.h (struct bp_location_ops): Remove.
 242         (class bp_location) <bp_location>: Remove bp_location_ops
 243         parameter.
 244         <~bp_location>: Add destructor.
 245         <ops>: Remove.
 246
 247 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 248             Pedro Alves  <palves@redhat.com>
 249
 250         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 251         'PATH_MAX'.
 252
 253 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 254             Samuel Thibault  <samuel.thibault@gnu.org>
 255             Thomas Schwinge  <thomas@codesourcery.com>
 256
 257         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 258         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 259
 260 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 261
 262         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 263         (check_empty): Use "const char *".
 264
 265         * gnu-nat.c (gnu_nat_target::detach): Instead of
 266         'detach_inferior (pid)' call
 267         'detach_inferior (find_inferior_pid (pid))'.
 268
 269         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 270         'nat/fork-inferior.o'.
 271         * gnu-nat.c: #include "nat/fork-inferior.h".
 272
 273         * gnu-nat.c (gnu_nat_target::detach): Instead of
 274         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 275         * gnu-nat.h: #include "inf-child.h".
 276         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 277         'i386_gnu_nat_target::fetch_registers'.
 278         (gnu_store_registers): Rename/move to
 279         'i386_gnu_nat_target::store_registers'.
 280
 281         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 282         * gnu-nat.h (mach_thread_info): New function.
 283         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 284
 285         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 286
 287 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 288
 289         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 290
 291 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 292
 293         * windows-nat.c (windows_add_thread): Add new parameter
 294         "main_thread_p" with default value set to false.  Update
 295         function documentation as well as all callers.
 296         (windows_delete_thread): Likewise.
 297         (fake_create_process): Update call to windows_add_thread.
 298         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 299         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 300         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 301         call to windows_delete_thread.
 302
 303 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 304
 305         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 306
 307 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 308
 309         * symfile.c (find_separate_debug_file): Use canonical path of
 310         sysroot with child_path instead of gdb_sysroot if it is valid.
 311
 312 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 313
 314         * symfile.c (find_separate_debug_file): Use child_path to
 315         determine if an object file is under a sysroot.
 316
 317 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 318
 319         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 320         unittests/child-path-selftests.c.
 321         * common/pathstuff.c (child_path): New function.
 322         * common/pathstuff.h (child_path): New prototype.
 323         * unittests/child-path-selftests.c: New file.
 324
 325 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 326
 327         * symfile.c (find_separate_debug_file): Look for separate debug
 328         files in debug directories under the sysroot.
 329
 330 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 331
 332         * symtab.h (struct minimal_symbol data_p): New const method.
 333         (struct minimal_symbol text_p): Likewise.
 334         * symtab.c (output_source_filename): Use file name style
 335         to print file name.
 336         (print_symbol_info): Likewise.
 337         (print_msymbol_info): Use address style to print addresses.
 338         Use function name style to print executable text symbols.
 339         (expand_symtab_containing_pc): Use data_p.
 340         (find_pc_sect_compunit_symtab): Likewise.
 341
 342 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 343
 344         * breakpoint.c (describe_other_breakpoints): Use address style
 345         to print addresses.
 346         (say_where): Likewise.
 347
 348 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 349
 350         * ada-typeprint.c (print_func_type): Print function name
 351         style to print function name.
 352         * c-typeprint.c (c_print_type_1): Likewise.
 353
 354 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 355
 356         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 357         for execve.
 358
 359 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 360
 361         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 362         type_stack.
 363
 364 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 365
 366         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 367         TYPE_CODE_REF types.
 368
 369 2019-02-08  Jim Wilson  <jimw@sifive.com>
 370
 371         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 372         (riscv_linux_fregset): New.
 373         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 374
 375 2019-02-07  Tom Tromey  <tom@tromey.com>
 376
 377         * thread.c (thread_cancel_execution_command): Update.
 378         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 379         methods.
 380         (struct thread_fsm_ops): Remove.
 381         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 382         (thread_fsm_should_stop, thread_fsm_return_value)
 383         (thread_fsm_set_finished, thread_fsm_finished_p)
 384         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 385         Don't declare.
 386         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 387         * infrun.c (clear_proceed_status_thread)
 388         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 389         (print_stop_event): Update.
 390         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 391         Add constructor.
 392         (step_command_fsm_ops): Remove.
 393         (new_step_command_fsm): Remove.
 394         (step_1): Update.
 395         (step_command_fsm::should_stop): Rename from
 396         step_command_fsm_should_stop.
 397         (step_command_fsm::clean_up): Rename from
 398         step_command_fsm_clean_up.
 399         (step_command_fsm::do_async_reply_reason): Rename from
 400         step_command_fsm_async_reply_reason.
 401         (struct until_next_fsm): Inherit from thread_fsm.  Add
 402         constructor.
 403         (until_next_fsm_ops): Remove.
 404         (new_until_next_fsm): Remove.
 405         (until_next_fsm::should_stop): Rename from
 406         until_next_fsm_should_stop.
 407         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 408         (until_next_fsm::do_async_reply_reason): Rename from
 409         until_next_fsm_async_reply_reason.
 410         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 411         constructor.  Change type of breakpoint.
 412         (finish_command_fsm_ops): Remove.
 413         (new_finish_command_fsm): Remove.
 414         (finish_command_fsm::should_stop): Rename from
 415         finish_command_fsm_should_stop.
 416         (finish_command_fsm::clean_up): Rename from
 417         finish_command_fsm_clean_up.
 418         (finish_command_fsm::return_value): Rename from
 419         finish_command_fsm_return_value.
 420         (finish_command_fsm::do_async_reply_reason): Rename from
 421         finish_command_fsm_async_reply_reason.
 422         (finish_command): Update.
 423         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 424         Add constructor.
 425         (call_thread_fsm_ops): Remove.
 426         (call_thread_fsm::call_thread_fsm): Rename from
 427         new_call_thread_fsm.
 428         (call_thread_fsm::should_stop): Rename from
 429         call_thread_fsm_should_stop.
 430         (call_thread_fsm::should_notify_stop): Rename from
 431         call_thread_fsm_should_notify_stop.
 432         (run_inferior_call, call_function_by_hand_dummy): Update.
 433         * cli/cli-interp.c (should_print_stop_to_console): Update.
 434         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 435         Add constructor.  Change type of location_breakpoint,
 436         caller_breakpoint.
 437         (until_break_fsm_ops): Remove.
 438         (new_until_break_fsm): Remove.
 439         (until_break_fsm::should_stop): Rename from
 440         until_break_fsm_should_stop.
 441         (until_break_fsm::clean_up): Rename from
 442         until_break_fsm_clean_up.
 443         (until_break_fsm::do_async_reply_reason): Rename from
 444         until_break_fsm_async_reply_reason.
 445         (until_break_command): Update.
 446         * thread-fsm.c: Remove.
 447         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 448
 449 2019-02-07  Tom Tromey  <tom@tromey.com>
 450
 451         * yy-remap.h: Add include guard.
 452         * xtensa-tdep.h: Add include guard.
 453         * xcoffread.h: Rename include guard.
 454         * varobj-iter.h: Add include guard.
 455         * tui/tui.h: Rename include guard.
 456         * tui/tui-winsource.h: Rename include guard.
 457         * tui/tui-wingeneral.h: Rename include guard.
 458         * tui/tui-windata.h: Rename include guard.
 459         * tui/tui-win.h: Rename include guard.
 460         * tui/tui-stack.h: Rename include guard.
 461         * tui/tui-source.h: Rename include guard.
 462         * tui/tui-regs.h: Rename include guard.
 463         * tui/tui-out.h: Rename include guard.
 464         * tui/tui-layout.h: Rename include guard.
 465         * tui/tui-io.h: Rename include guard.
 466         * tui/tui-hooks.h: Rename include guard.
 467         * tui/tui-file.h: Rename include guard.
 468         * tui/tui-disasm.h: Rename include guard.
 469         * tui/tui-data.h: Rename include guard.
 470         * tui/tui-command.h: Rename include guard.
 471         * tic6x-tdep.h: Add include guard.
 472         * target/waitstatus.h: Rename include guard.
 473         * target/wait.h: Rename include guard.
 474         * target/target.h: Rename include guard.
 475         * target/resume.h: Rename include guard.
 476         * target-float.h: Rename include guard.
 477         * stabsread.h: Add include guard.
 478         * rs6000-tdep.h: Add include guard.
 479         * riscv-fbsd-tdep.h: Add include guard.
 480         * regformats/regdef.h: Rename include guard.
 481         * record.h: Rename include guard.
 482         * python/python.h: Rename include guard.
 483         * python/python-internal.h: Rename include guard.
 484         * python/py-stopevent.h: Rename include guard.
 485         * python/py-ref.h: Rename include guard.
 486         * python/py-record.h: Rename include guard.
 487         * python/py-record-full.h: Rename include guard.
 488         * python/py-record-btrace.h: Rename include guard.
 489         * python/py-instruction.h: Rename include guard.
 490         * python/py-events.h: Rename include guard.
 491         * python/py-event.h: Rename include guard.
 492         * procfs.h: Add include guard.
 493         * proc-utils.h: Add include guard.
 494         * p-lang.h: Add include guard.
 495         * or1k-tdep.h: Rename include guard.
 496         * observable.h: Rename include guard.
 497         * nto-tdep.h: Rename include guard.
 498         * nat/x86-linux.h: Rename include guard.
 499         * nat/x86-linux-dregs.h: Rename include guard.
 500         * nat/x86-gcc-cpuid.h: Add include guard.
 501         * nat/x86-dregs.h: Rename include guard.
 502         * nat/x86-cpuid.h: Rename include guard.
 503         * nat/ppc-linux.h: Rename include guard.
 504         * nat/mips-linux-watch.h: Rename include guard.
 505         * nat/linux-waitpid.h: Rename include guard.
 506         * nat/linux-ptrace.h: Rename include guard.
 507         * nat/linux-procfs.h: Rename include guard.
 508         * nat/linux-osdata.h: Rename include guard.
 509         * nat/linux-nat.h: Rename include guard.
 510         * nat/linux-namespaces.h: Rename include guard.
 511         * nat/linux-btrace.h: Rename include guard.
 512         * nat/glibc_thread_db.h: Rename include guard.
 513         * nat/gdb_thread_db.h: Rename include guard.
 514         * nat/gdb_ptrace.h: Rename include guard.
 515         * nat/fork-inferior.h: Rename include guard.
 516         * nat/amd64-linux-siginfo.h: Rename include guard.
 517         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 518         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 519         * nat/aarch64-linux.h: Rename include guard.
 520         * nat/aarch64-linux-hw-point.h: Rename include guard.
 521         * mn10300-tdep.h: Add include guard.
 522         * mips-linux-tdep.h: Add include guard.
 523         * mi/mi-parse.h: Rename include guard.
 524         * mi/mi-out.h: Rename include guard.
 525         * mi/mi-main.h: Rename include guard.
 526         * mi/mi-interp.h: Rename include guard.
 527         * mi/mi-getopt.h: Rename include guard.
 528         * mi/mi-console.h: Rename include guard.
 529         * mi/mi-common.h: Rename include guard.
 530         * mi/mi-cmds.h: Rename include guard.
 531         * mi/mi-cmd-break.h: Rename include guard.
 532         * m2-lang.h: Add include guard.
 533         * location.h: Rename include guard.
 534         * linux-record.h: Rename include guard.
 535         * linux-nat.h: Add include guard.
 536         * linux-fork.h: Add include guard.
 537         * i386-darwin-tdep.h: Rename include guard.
 538         * hppa-linux-offsets.h: Add include guard.
 539         * guile/guile.h: Rename include guard.
 540         * guile/guile-internal.h: Rename include guard.
 541         * gnu-nat.h: Rename include guard.
 542         * gdb-stabs.h: Rename include guard.
 543         * frv-tdep.h: Add include guard.
 544         * f-lang.h: Add include guard.
 545         * event-loop.h: Add include guard.
 546         * darwin-nat.h: Rename include guard.
 547         * cp-abi.h: Rename include guard.
 548         * config/sparc/nm-sol2.h: Rename include guard.
 549         * config/nm-nto.h: Rename include guard.
 550         * config/nm-linux.h: Add include guard.
 551         * config/i386/nm-i386gnu.h: Rename include guard.
 552         * config/djgpp/nl_types.h: Rename include guard.
 553         * config/djgpp/langinfo.h: Rename include guard.
 554         * compile/gcc-cp-plugin.h: Add include guard.
 555         * compile/gcc-c-plugin.h: Add include guard.
 556         * compile/compile.h: Rename include guard.
 557         * compile/compile-object-run.h: Rename include guard.
 558         * compile/compile-object-load.h: Rename include guard.
 559         * compile/compile-internal.h: Rename include guard.
 560         * compile/compile-cplus.h: Rename include guard.
 561         * compile/compile-c.h: Rename include guard.
 562         * common/xml-utils.h: Rename include guard.
 563         * common/x86-xstate.h: Rename include guard.
 564         * common/version.h: Rename include guard.
 565         * common/vec.h: Rename include guard.
 566         * common/tdesc.h: Rename include guard.
 567         * common/selftest.h: Rename include guard.
 568         * common/scoped_restore.h: Rename include guard.
 569         * common/scoped_mmap.h: Rename include guard.
 570         * common/scoped_fd.h: Rename include guard.
 571         * common/safe-iterator.h: Rename include guard.
 572         * common/run-time-clock.h: Rename include guard.
 573         * common/refcounted-object.h: Rename include guard.
 574         * common/queue.h: Rename include guard.
 575         * common/ptid.h: Rename include guard.
 576         * common/print-utils.h: Rename include guard.
 577         * common/preprocessor.h: Rename include guard.
 578         * common/pathstuff.h: Rename include guard.
 579         * common/observable.h: Rename include guard.
 580         * common/netstuff.h: Rename include guard.
 581         * common/job-control.h: Rename include guard.
 582         * common/host-defs.h: Rename include guard.
 583         * common/gdb_wait.h: Rename include guard.
 584         * common/gdb_vecs.h: Rename include guard.
 585         * common/gdb_unlinker.h: Rename include guard.
 586         * common/gdb_unique_ptr.h: Rename include guard.
 587         * common/gdb_tilde_expand.h: Rename include guard.
 588         * common/gdb_sys_time.h: Rename include guard.
 589         * common/gdb_string_view.h: Rename include guard.
 590         * common/gdb_splay_tree.h: Rename include guard.
 591         * common/gdb_setjmp.h: Rename include guard.
 592         * common/gdb_ref_ptr.h: Rename include guard.
 593         * common/gdb_optional.h: Rename include guard.
 594         * common/gdb_locale.h: Rename include guard.
 595         * common/gdb_assert.h: Rename include guard.
 596         * common/filtered-iterator.h: Rename include guard.
 597         * common/filestuff.h: Rename include guard.
 598         * common/fileio.h: Rename include guard.
 599         * common/environ.h: Rename include guard.
 600         * common/common-utils.h: Rename include guard.
 601         * common/common-types.h: Rename include guard.
 602         * common/common-regcache.h: Rename include guard.
 603         * common/common-inferior.h: Rename include guard.
 604         * common/common-gdbthread.h: Rename include guard.
 605         * common/common-exceptions.h: Rename include guard.
 606         * common/common-defs.h: Rename include guard.
 607         * common/common-debug.h: Rename include guard.
 608         * common/cleanups.h: Rename include guard.
 609         * common/buffer.h: Rename include guard.
 610         * common/btrace-common.h: Rename include guard.
 611         * common/break-common.h: Rename include guard.
 612         * cli/cli-utils.h: Rename include guard.
 613         * cli/cli-style.h: Rename include guard.
 614         * cli/cli-setshow.h: Rename include guard.
 615         * cli/cli-script.h: Rename include guard.
 616         * cli/cli-interp.h: Rename include guard.
 617         * cli/cli-decode.h: Rename include guard.
 618         * cli/cli-cmds.h: Rename include guard.
 619         * charset-list.h: Add include guard.
 620         * buildsym-legacy.h: Rename include guard.
 621         * bfin-tdep.h: Add include guard.
 622         * ax.h: Rename include guard.
 623         * arm-linux-tdep.h: Add include guard.
 624         * arm-fbsd-tdep.h: Add include guard.
 625         * arch/xtensa.h: Rename include guard.
 626         * arch/tic6x.h: Add include guard.
 627         * arch/i386.h: Add include guard.
 628         * arch/arm.h: Rename include guard.
 629         * arch/arm-linux.h: Rename include guard.
 630         * arch/arm-get-next-pcs.h: Rename include guard.
 631         * arch/amd64.h: Add include guard.
 632         * arch/aarch64-insn.h: Rename include guard.
 633         * arch-utils.h: Rename include guard.
 634         * annotate.h: Add include guard.
 635         * amd64-darwin-tdep.h: Rename include guard.
 636         * aarch64-linux-tdep.h: Add include guard.
 637         * aarch64-fbsd-tdep.h: Add include guard.
 638         * aarch32-linux-nat.h: Add include guard.
 639
 640 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 641
 642         * macrotab.c (macro_define_internal): New function that
 643         factorizes macro_define_object_internal and macro_define_function
 644         code.
 645         (macro_define_object_internal): Use macro_define_internal.
 646         (macro_define_function): Likewise.
 647
 648 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 649
 650         * macrocmd.c (extract_identifier): Return
 651         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 652         callers.
 653
 654 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 655
 656         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 657
 658 2019-02-05  Tom Tromey  <tom@tromey.com>
 659
 660         * target.c (target_stack::unpush): Move assertion earlier.
 661
 662 2019-01-30  Tom Tromey  <tom@tromey.com>
 663
 664         PR python/23615:
 665         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 666         (gdbpy_parse_and_eval): Likewise.
 667         * python/python-internal.h (gdbpy_allow_threads): New class.
 668
 669 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 670
 671         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 672         (aarch64_fbsd_fpregmap): Move earlier.
 673         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 674         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 675         instead of individual calls to trad_frame_set_reg_addr.
 676         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 677         earlier.
 678         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 679         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 680         instead of individual calls to trad_frame_set_reg_addr.
 681
 682 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 683
 684         * CONTRIBUTE: Replace contribution list with wiki link.
 685
 686 2019-01-25  Tom Tromey  <tom@tromey.com>
 687
 688         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 689
 690 2019-01-25  Tom Tromey  <tom@tromey.com>
 691
 692         * xtensa-linux-nat.c: Fix common/ includes.
 693         * xml-support.h: Fix common/ includes.
 694         * xml-support.c: Fix common/ includes.
 695         * x86-linux-nat.c: Fix common/ includes.
 696         * windows-nat.c: Fix common/ includes.
 697         * varobj.h: Fix common/ includes.
 698         * varobj.c: Fix common/ includes.
 699         * value.c: Fix common/ includes.
 700         * valops.c: Fix common/ includes.
 701         * utils.c: Fix common/ includes.
 702         * unittests/xml-utils-selftests.c: Fix common/ includes.
 703         * unittests/utils-selftests.c: Fix common/ includes.
 704         * unittests/unpack-selftests.c: Fix common/ includes.
 705         * unittests/tracepoint-selftests.c: Fix common/ includes.
 706         * unittests/style-selftests.c: Fix common/ includes.
 707         * unittests/string_view-selftests.c: Fix common/ includes.
 708         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 709         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 710         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 711         * unittests/rsp-low-selftests.c: Fix common/ includes.
 712         * unittests/parse-connection-spec-selftests.c: Fix common/
 713         includes.
 714         * unittests/optional-selftests.c: Fix common/ includes.
 715         * unittests/offset-type-selftests.c: Fix common/ includes.
 716         * unittests/observable-selftests.c: Fix common/ includes.
 717         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 718         * unittests/memrange-selftests.c: Fix common/ includes.
 719         * unittests/memory-map-selftests.c: Fix common/ includes.
 720         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 721         * unittests/function-view-selftests.c: Fix common/ includes.
 722         * unittests/environ-selftests.c: Fix common/ includes.
 723         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 724         * unittests/common-utils-selftests.c: Fix common/ includes.
 725         * unittests/cli-utils-selftests.c: Fix common/ includes.
 726         * unittests/array-view-selftests.c: Fix common/ includes.
 727         * ui-file.c: Fix common/ includes.
 728         * tui/tui-io.c: Fix common/ includes.
 729         * tracepoint.h: Fix common/ includes.
 730         * tracepoint.c: Fix common/ includes.
 731         * tracefile-tfile.c: Fix common/ includes.
 732         * top.h: Fix common/ includes.
 733         * top.c: Fix common/ includes.
 734         * thread.c: Fix common/ includes.
 735         * target/waitstatus.h: Fix common/ includes.
 736         * target/waitstatus.c: Fix common/ includes.
 737         * target.h: Fix common/ includes.
 738         * target.c: Fix common/ includes.
 739         * target-memory.c: Fix common/ includes.
 740         * target-descriptions.c: Fix common/ includes.
 741         * symtab.h: Fix common/ includes.
 742         * symfile.c: Fix common/ includes.
 743         * stap-probe.c: Fix common/ includes.
 744         * spu-linux-nat.c: Fix common/ includes.
 745         * sparc-nat.c: Fix common/ includes.
 746         * source.c: Fix common/ includes.
 747         * solib.c: Fix common/ includes.
 748         * solib-target.c: Fix common/ includes.
 749         * ser-unix.c: Fix common/ includes.
 750         * ser-tcp.c: Fix common/ includes.
 751         * ser-pipe.c: Fix common/ includes.
 752         * ser-base.c: Fix common/ includes.
 753         * selftest-arch.c: Fix common/ includes.
 754         * s12z-tdep.c: Fix common/ includes.
 755         * rust-exp.y: Fix common/ includes.
 756         * rs6000-aix-tdep.c: Fix common/ includes.
 757         * riscv-tdep.c: Fix common/ includes.
 758         * remote.c: Fix common/ includes.
 759         * remote-notif.h: Fix common/ includes.
 760         * remote-fileio.h: Fix common/ includes.
 761         * remote-fileio.c: Fix common/ includes.
 762         * regcache.h: Fix common/ includes.
 763         * regcache.c: Fix common/ includes.
 764         * record-btrace.c: Fix common/ includes.
 765         * python/python.c: Fix common/ includes.
 766         * python/py-type.c: Fix common/ includes.
 767         * python/py-inferior.c: Fix common/ includes.
 768         * progspace.h: Fix common/ includes.
 769         * producer.c: Fix common/ includes.
 770         * procfs.c: Fix common/ includes.
 771         * proc-api.c: Fix common/ includes.
 772         * printcmd.c: Fix common/ includes.
 773         * ppc-linux-nat.c: Fix common/ includes.
 774         * parser-defs.h: Fix common/ includes.
 775         * osdata.c: Fix common/ includes.
 776         * obsd-nat.c: Fix common/ includes.
 777         * nat/x86-linux.c: Fix common/ includes.
 778         * nat/x86-linux-dregs.c: Fix common/ includes.
 779         * nat/x86-dregs.h: Fix common/ includes.
 780         * nat/x86-dregs.c: Fix common/ includes.
 781         * nat/ppc-linux.c: Fix common/ includes.
 782         * nat/mips-linux-watch.h: Fix common/ includes.
 783         * nat/mips-linux-watch.c: Fix common/ includes.
 784         * nat/linux-waitpid.c: Fix common/ includes.
 785         * nat/linux-ptrace.h: Fix common/ includes.
 786         * nat/linux-ptrace.c: Fix common/ includes.
 787         * nat/linux-procfs.c: Fix common/ includes.
 788         * nat/linux-personality.c: Fix common/ includes.
 789         * nat/linux-osdata.c: Fix common/ includes.
 790         * nat/linux-namespaces.c: Fix common/ includes.
 791         * nat/linux-btrace.h: Fix common/ includes.
 792         * nat/linux-btrace.c: Fix common/ includes.
 793         * nat/fork-inferior.c: Fix common/ includes.
 794         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 795         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 796         * nat/aarch64-linux.c: Fix common/ includes.
 797         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 798         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 799         * namespace.h: Fix common/ includes.
 800         * mips-linux-tdep.c: Fix common/ includes.
 801         * minsyms.c: Fix common/ includes.
 802         * mi/mi-parse.h: Fix common/ includes.
 803         * mi/mi-main.c: Fix common/ includes.
 804         * mi/mi-cmd-env.c: Fix common/ includes.
 805         * memrange.h: Fix common/ includes.
 806         * memattr.c: Fix common/ includes.
 807         * maint.h: Fix common/ includes.
 808         * maint.c: Fix common/ includes.
 809         * main.c: Fix common/ includes.
 810         * machoread.c: Fix common/ includes.
 811         * location.c: Fix common/ includes.
 812         * linux-thread-db.c: Fix common/ includes.
 813         * linux-nat.c: Fix common/ includes.
 814         * linux-fork.c: Fix common/ includes.
 815         * inline-frame.c: Fix common/ includes.
 816         * infrun.c: Fix common/ includes.
 817         * inflow.c: Fix common/ includes.
 818         * inferior.h: Fix common/ includes.
 819         * inferior.c: Fix common/ includes.
 820         * infcmd.c: Fix common/ includes.
 821         * inf-ptrace.c: Fix common/ includes.
 822         * inf-child.c: Fix common/ includes.
 823         * ia64-linux-nat.c: Fix common/ includes.
 824         * i387-tdep.c: Fix common/ includes.
 825         * i386-tdep.c: Fix common/ includes.
 826         * i386-linux-tdep.c: Fix common/ includes.
 827         * i386-linux-nat.c: Fix common/ includes.
 828         * i386-go32-tdep.c: Fix common/ includes.
 829         * i386-fbsd-tdep.c: Fix common/ includes.
 830         * i386-fbsd-nat.c: Fix common/ includes.
 831         * guile/scm-type.c: Fix common/ includes.
 832         * guile/guile.c: Fix common/ includes.
 833         * go32-nat.c: Fix common/ includes.
 834         * gnu-nat.c: Fix common/ includes.
 835         * gdbthread.h: Fix common/ includes.
 836         * gdbarch-selftests.c: Fix common/ includes.
 837         * gdb_usleep.c: Fix common/ includes.
 838         * gdb_select.h: Fix common/ includes.
 839         * gdb_bfd.c: Fix common/ includes.
 840         * gcore.c: Fix common/ includes.
 841         * fork-child.c: Fix common/ includes.
 842         * findvar.c: Fix common/ includes.
 843         * fbsd-nat.c: Fix common/ includes.
 844         * event-top.c: Fix common/ includes.
 845         * event-loop.c: Fix common/ includes.
 846         * dwarf2read.c: Fix common/ includes.
 847         * dwarf2loc.c: Fix common/ includes.
 848         * dwarf2-frame.c: Fix common/ includes.
 849         * dwarf-index-cache.c: Fix common/ includes.
 850         * dtrace-probe.c: Fix common/ includes.
 851         * disasm-selftests.c: Fix common/ includes.
 852         * defs.h: Fix common/ includes.
 853         * csky-tdep.c: Fix common/ includes.
 854         * cp-valprint.c: Fix common/ includes.
 855         * cp-support.h: Fix common/ includes.
 856         * cp-support.c: Fix common/ includes.
 857         * corelow.c: Fix common/ includes.
 858         * completer.h: Fix common/ includes.
 859         * completer.c: Fix common/ includes.
 860         * compile/compile.c: Fix common/ includes.
 861         * compile/compile-loc2c.c: Fix common/ includes.
 862         * compile/compile-cplus-types.c: Fix common/ includes.
 863         * compile/compile-cplus-symbols.c: Fix common/ includes.
 864         * command.h: Fix common/ includes.
 865         * cli/cli-dump.c: Fix common/ includes.
 866         * cli/cli-cmds.c: Fix common/ includes.
 867         * charset.c: Fix common/ includes.
 868         * build-id.c: Fix common/ includes.
 869         * btrace.h: Fix common/ includes.
 870         * btrace.c: Fix common/ includes.
 871         * breakpoint.h: Fix common/ includes.
 872         * breakpoint.c: Fix common/ includes.
 873         * ax.h:
 874         (enum agent_op): Fix common/ includes.
 875         * ax-general.c (struct aop_map): Fix common/ includes.
 876         * ax-gdb.c: Fix common/ includes.
 877         * auxv.c: Fix common/ includes.
 878         * auto-load.c: Fix common/ includes.
 879         * arm-tdep.c: Fix common/ includes.
 880         * arch/riscv.c: Fix common/ includes.
 881         * arch/ppc-linux-common.c: Fix common/ includes.
 882         * arch/i386.c: Fix common/ includes.
 883         * arch/arm.c: Fix common/ includes.
 884         * arch/arm-linux.c: Fix common/ includes.
 885         * arch/arm-get-next-pcs.c: Fix common/ includes.
 886         * arch/amd64.c: Fix common/ includes.
 887         * arch/aarch64.c: Fix common/ includes.
 888         * arch/aarch64-insn.c: Fix common/ includes.
 889         * arch-utils.c: Fix common/ includes.
 890         * amd64-windows-tdep.c: Fix common/ includes.
 891         * amd64-tdep.c: Fix common/ includes.
 892         * amd64-sol2-tdep.c: Fix common/ includes.
 893         * amd64-obsd-tdep.c: Fix common/ includes.
 894         * amd64-nbsd-tdep.c: Fix common/ includes.
 895         * amd64-linux-tdep.c: Fix common/ includes.
 896         * amd64-linux-nat.c: Fix common/ includes.
 897         * amd64-fbsd-tdep.c: Fix common/ includes.
 898         * amd64-fbsd-nat.c: Fix common/ includes.
 899         * amd64-dicos-tdep.c: Fix common/ includes.
 900         * amd64-darwin-tdep.c: Fix common/ includes.
 901         * agent.c: Fix common/ includes.
 902         * ada-lang.h: Fix common/ includes.
 903         * ada-lang.c: Fix common/ includes.
 904         * aarch64-tdep.c: Fix common/ includes.
 905
 906 2019-01-25  Tom Tromey  <tom@tromey.com>
 907
 908         * common/create-version.sh: Use common/version.h.
 909
 910 2019-01-24  Pedro Alves  <palves@redhat.com>
 911
 912         * infrun.c (signal_stop, signal_print, signal_program)
 913         (signal_catch, signal_pass): Now arrays instead of pointers.
 914         (update_signals_program_target, do_target_resume)
 915         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 916         * linux-nat.c (linux_nat_target::pass_signals)
 917         (linux_nat_target::create_inferior, linux_nat_target::attach):
 918         Adjust.
 919         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 920         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 921         * procfs.c (procfs_target::pass_signals): Adjust.
 922         * record-full.c (record_full_target::resume): Adjust.
 923         * remote.c (remote_target::pass_signals)
 924         (remote_target::program_signals): Adjust.
 925         * target-debug.h (target_debug_print_signals): Now takes a
 926         gdb::array_view as parameter.  Adjust.
 927         * target.h (target_ops) <pass_signals, program_signals>: Replace
 928         pointer and length parameters with gdb::array_view.
 929         (target_pass_signals, target_program_signals): Likewise.
 930         * target-delegates.c: Regenerate.
 931
 932 2019-01-24  Pedro Alves  <palves@redhat.com>
 933
 934         * common/forward-scope-exit.h
 935         (forward_scope_exit::forward_scope_exit): Pass arguments to
 936         m_bind_function directly, instead of creating a std::bind and
 937         copying that.
 938
 939 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 940
 941         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 942         for static members.
 943         (pass_in_v_vfp_candidate): Likewise.
 944
 945 2019-01-23  Tom Tromey  <tom@tromey.com>
 946             Pedro Alves  <palves@redhat.com>
 947
 948         * regcache.c (class regcache_invalidator): Remove.
 949         (regcache::raw_write): Use make_scope_exit.
 950
 951 2019-01-23  Tom Tromey  <tom@tromey.com>
 952
 953         * ui-out.h (class ui_out_emit_type): Update comment.
 954
 955 2019-01-23  Tom Tromey  <tom@tromey.com>
 956
 957         * infrun.c (fetch_inferior_event): Update comment.
 958
 959 2019-01-23  Tom Tromey  <tom@tromey.com>
 960             Pedro Alves  <palves@redhat.com>
 961
 962         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 963         parameter.
 964         (fetch_inferior_event): Use SCOPE_EXIT.
 965
 966
 967 2019-01-23  Tom Tromey  <tom@tromey.com>
 968             Pedro Alves  <palves@redhat.com>
 969
 970         * infrun.c (disable_thread_events): Delete.
 971         (stop_all_threads): Use SCOPE_EXIT.
 972
 973 2019-01-23  Tom Tromey  <tom@tromey.com>
 974             Pedro Alves  <palves@redhat.com>
 975
 976         * symfile.c: Include forward-scope-exit.h.
 977         (clear_symtab_users_cleanup): Replace forward declaration with
 978         a FORWARD_SCOPE_EXIT.
 979         (syms_from_objfile_1): Use the forward_scope_exit and
 980         gdb::optional instead of cleanup_function.
 981         (reread_symbols): Use the forward_scope_exit instead of
 982         cleanup_function.
 983         (clear_symtab_users_cleanup): Remove function.
 984
 985 2019-01-23  Tom Tromey  <tom@tromey.com>
 986             Pedro Alves  <palves@redhat.com>
 987
 988         * linux-nat.c: Include scope-exit.h.
 989         (cleanup_target_stop): Remove.
 990         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 991         SCOPE_EXIT.
 992
 993 2019-01-23  Tom Tromey  <tom@tromey.com>
 994             Pedro Alves  <palves@redhat.com>
 995
 996         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 997         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 998
 999 2019-01-23  Tom Tromey  <tom@tromey.com>
1000             Andrew Burgess  <andrew.burgess@embecosm.com>
1001             Pedro Alves  <palves@redhat.com>
1002
1003         * infrun.c (fetch_inferior_event): Use scope_exit.
1004         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1005         * top.c (execute_command): Use scope_exit.
1006         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1007         * utils.c (do_bpstat_clear_actions_cleanup)
1008         (make_bpstat_clear_actions_cleanup): Remove.
1009
1010 2019-01-23  Tom Tromey  <tom@tromey.com>
1011             Pedro Alves  <palves@redhat.com>
1012
1013         * infrun.c: Include "common/scope-exit.h"
1014         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1015         (wait_for_inferior): Use SCOPE_EXIT.
1016         (fetch_inferior_event): Use scope_exit.
1017
1018 2019-01-23  Tom Tromey  <tom@tromey.com>
1019             Pedro Alves  <palves@redhat.com>
1020
1021         * breakpoint.c (create_breakpoint): Remove cleanup.
1022
1023 2019-01-23  Tom Tromey  <tom@tromey.com>
1024             Andrew Burgess  <andrew.burgess@embecosm.com>
1025             Pedro Alves  <palves@redhat.com>
1026
1027 2019-01-23  Pedro Alves  <palves@redhat.com>
1028
1029         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1030
1031 2019-01-23  Pedro Alves  <palves@redhat.com>
1032             Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * gdbthread.h: Include "common/forward-scope-exit.h".
1035         (scoped_finish_thread_state): Redefine custom class in terms of
1036         forward_scope_exit.
1037
1038 2019-01-23  Pedro Alves  <palves@redhat.com>
1039             Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * common/forward-scope-exit.h: New file.
1042
1043 2019-01-23  Pedro Alves  <palves@redhat.com>
1044             Andrew Burgess  <andrew.burgess@embecosm.com>
1045             Tom Tromey  <tom@tromey.com>
1046
1047         * common/scope-exit.h: New file.
1048
1049 2019-01-23  Pedro Alves  <palves@redhat.com>
1050
1051         * common/preprocessor.h (ESC): Rename to ...
1052         (ESC_PARENS): ... this.
1053         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1054         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1055
1056 2019-01-23  Tom Tromey  <tom@tromey.com>
1057
1058         * language.h (class scoped_switch_to_sym_language_if_auto):
1059         Initialize m_lang in both cases.
1060
1061 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1062
1063         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1064         with XCNEW.
1065
1066 2019-01-22  Tom Tromey  <tom@tromey.com>
1067
1068         * corelow.c: Do not include sys/file.h.
1069
1070 2019-01-22  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-wingeneral.h: Include gdb_curses.h.
1073
1074 2019-01-22  Tom Tromey  <tom@tromey.com>
1075
1076         * source-cache.h (class source_cache) <get_source_lines,
1077         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1078
1079 2019-01-22  Tom Tromey  <tom@tromey.com>
1080
1081         * remote-fileio.h (struct remote_target): Declare.
1082
1083 2019-01-22  Tom Tromey  <tom@tromey.com>
1084
1085         * python/py-arch.c: Do not include py-ref.h.
1086         * python/py-bpevent.c: Do not include py-ref.h.
1087         * python/py-cmd.c: Do not include py-ref.h.
1088         * python/py-continueevent.c: Do not include py-ref.h.
1089         * python/py-event.h: Do not include py-ref.h.
1090         * python/py-evtregistry.c: Do not include py-ref.h.
1091         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1092         * python/py-frame.c: Do not include py-ref.h.
1093         * python/py-framefilter.c: Do not include py-ref.h.
1094         * python/py-function.c: Do not include py-ref.h.
1095         * python/py-infevents.c: Do not include py-ref.h.
1096         * python/py-linetable.c: Do not include py-ref.h.
1097         * python/py-objfile.c: Do not include py-ref.h.
1098         * python/py-param.c: Do not include py-ref.h.
1099         * python/py-prettyprint.c: Do not include py-ref.h.
1100         * python/py-progspace.c: Do not include py-ref.h.
1101         * python/py-symbol.c: Do not include py-ref.h.
1102         * python/py-symtab.c: Do not include py-ref.h.
1103         * python/py-type.c: Do not include py-ref.h.
1104         * python/py-unwind.c: Do not include py-ref.h.
1105         * python/py-utils.c: Do not include py-ref.h.
1106         * python/py-value.c: Do not include py-ref.h.
1107         * python/py-varobj.c: Do not include py-ref.h.
1108         * python/py-xmethods.c: Do not include py-ref.h.
1109         * python/python.c: Do not include py-ref.h.
1110         * varobj.c: Do not include py-ref.h.
1111
1112 2019-01-22  Tom Tromey  <tom@tromey.com>
1113
1114         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1115         keyword for bcache.
1116
1117 2019-01-22  Tom Tromey  <tom@tromey.com>
1118
1119         * compile/compile-cplus-types.c: Remove a comment by #include.
1120
1121 2019-01-22  Tom Tromey  <tom@tromey.com>
1122
1123         * compile/gcc-c-plugin.h: Include compile-internal.h.
1124
1125 2019-01-22  Tom Tromey  <tom@tromey.com>
1126
1127         * stabsread.c (EXTERN): Do not define.
1128         (symnum, next_symbol_text_func, processing_gcc_compilation)
1129         (within_function, global_sym_chain, global_stabs)
1130         (previous_stab_code, this_object_header_files)
1131         (n_this_object_header_files)
1132         (n_allocated_this_object_header_files): Define.
1133         * stabsread.h (EXTERN): Never define.  Use "extern".
1134
1135 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1136
1137         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1138         history_value.
1139
1140 2019-01-21  Tom Tromey  <tom@tromey.com>
1141
1142         * ui-out.c: Fix includes.
1143         * tui/tui-source.c: Fix includes.
1144         * target.c: Fix includes.
1145         * remote.c: Fix includes.
1146         * regcache.c: Fix includes.
1147         * python/py-block.c: Fix includes.
1148         * printcmd.c: Fix includes.
1149         * or1k-tdep.c: Fix includes.
1150         * mi/mi-main.c: Fix includes.
1151         * m32r-tdep.c: Fix includes.
1152         * csky-tdep.c: Fix includes.
1153         * compile/compile-cplus-types.c: Fix includes.
1154         * cli/cli-interp.c: Fix includes.
1155
1156 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1159         for padding.
1160
1161 2019-01-16  Tom Tromey  <tom@tromey.com>
1162
1163         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1164         earlier.
1165         (struct objfile) <msymbols_range>: Move from top level.
1166         <msymbols>: New method.
1167         (class objfile_msymbols): Remove.
1168         * symtab.c (default_collect_symbol_completion_matches_break_on):
1169         Update.
1170         * symmisc.c (dump_msymbols): Update.
1171         * stabsread.c (scan_file_globals): Update.
1172         * objc-lang.c (info_selectors_command, info_classes_command)
1173         (find_methods): Update.
1174         * minsyms.c (find_solib_trampoline_target): Update.
1175         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1176         * coffread.c (coff_symfile_read): Update.
1177         * ada-lang.c (ada_lookup_simple_minsym)
1178         (ada_collect_symbol_completion_matches): Update.
1179
1180 2019-01-16  Tom Tromey  <tom@tromey.com>
1181
1182         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1183         type.  Remove no-argument constructor.
1184         <iterator::operator++>: Simplify.
1185         <begin>: Update.
1186         <end>: Use minimal_symbol_count.
1187
1188 2019-01-16  Tom Tromey  <tom@tromey.com>
1189
1190         * objfiles.h (struct objfile) <psymtabs>: New method.
1191         (class objfile_psymtabs): Remove.
1192         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1193         typedef.
1194         <range>: New method.
1195         (require_partial_symbols): Change return type.
1196         * psymtab.c (require_partial_symbols)
1197         (psym_expand_symtabs_matching): Update.
1198         * mdebugread.c (parse_partial_symbols): Update.
1199         * dbxread.c (dbx_end_psymtab): Update.
1200
1201 2019-01-15  Tom Tromey  <tom@tromey.com>
1202
1203         * symtab.c (lookup_objfile_from_block)
1204         (lookup_symbol_in_objfile_symtabs)
1205         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1206         (find_line_symtab, info_sources_command)
1207         (default_collect_symbol_completion_matches_break_on)
1208         (make_source_files_completion_list): Update.
1209         * symmisc.c (print_objfile_statistics, dump_objfile)
1210         (maintenance_print_symbols, maintenance_info_symtabs)
1211         (maintenance_check_symtabs, maintenance_info_line_tables):
1212         Update.
1213         * source.c (select_source_symtab)
1214         (forget_cached_source_info_for_objfile): Update.
1215         * objfiles.h (class objfile_compunits): Remove.
1216         (struct objfile) <compunits_range>: New typedef.
1217         (compunits): New method.
1218         * objfiles.c (objfile_relocate1): Update.
1219         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1220         * maint.c (count_symtabs_and_blocks): Update.
1221         * linespec.c (iterate_over_all_matching_symtabs): Update.
1222         * cp-support.c (add_symbol_overload_list_qualified): Update.
1223         * coffread.c (coff_symtab_read): Update.
1224         * ada-lang.c (add_nonlocal_symbols)
1225         (ada_collect_symbol_completion_matches)
1226         (ada_add_global_exceptions): Update.
1227
1228 2019-01-15  Tom Tromey  <tom@tromey.com>
1229
1230         * progspace.h (program_space) <objfiles_safe_range>: New
1231         typedef.
1232         <objfiles_safe>: New method.
1233         * objfiles.h (class all_objfiles_safe): Remove.
1234         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1235         * jit.c (jit_inferior_exit_hook): Update.
1236
1237 2019-01-17  Tom Tromey  <tom@tromey.com>
1238
1239         * progspace.h (program_space) <objfiles_range>: New typedef.
1240         <objfiles>: New method.
1241         <objfiles_head>: Rename from objfiles.
1242         (object_files): Update.
1243         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1244         * guile/scm-pretty-print.c
1245         (ppscm_find_pretty_printer_from_objfiles): Update.
1246         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1247         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1248         Update.
1249         * python/py-progspace.c (pspy_get_objfiles): Update.
1250         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1251         Update.
1252         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1253         (objfpy_lookup_objfile_by_build_id): Update.
1254         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1255         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1256         Update.
1257         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1258         (expand_symtab_containing_pc, lookup_objfile_from_block)
1259         (lookup_static_symbol, basic_lookup_transparent_type)
1260         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1261         (find_line_symtab, info_sources_command)
1262         (default_collect_symbol_completion_matches_break_on)
1263         (make_source_files_completion_list, find_main_name): Update.
1264         * symmisc.c (print_symbol_bcache_statistics)
1265         (print_objfile_statistics, maintenance_print_symbols)
1266         (maintenance_print_msymbols, maintenance_print_objfiles)
1267         (maintenance_info_symtabs, maintenance_check_symtabs)
1268         (maintenance_expand_symtabs, maintenance_info_line_tables):
1269         Update.
1270         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1271         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1272         (map_overlay_command, unmap_overlay_command)
1273         (simple_overlay_update, expand_symtabs_matching)
1274         (map_symbol_filenames): Update.
1275         * symfile-debug.c (set_debug_symfile): Update.
1276         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1277         Update.
1278         * source.c (select_source_symtab, forget_cached_source_info):
1279         Update.
1280         * solib.c (solib_read_symbols): Update.
1281         * solib-spu.c (append_ocl_sos): Update.
1282         * psymtab.c (maintenance_print_psymbols)
1283         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1284         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1285         * printcmd.c (info_symbol_command): Update.
1286         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1287         Update.
1288         * objfiles.h (class all_objfiles): Remove.
1289         * objfiles.c (have_partial_symbols, have_full_symbols)
1290         (have_minimal_symbols, qsort_cmp, update_section_map)
1291         (shared_objfile_contains_address_p)
1292         (default_iterate_over_objfiles_in_search_order): Update.
1293         * objc-lang.c (info_selectors_command, info_classes_command)
1294         (find_methods): Update.
1295         * minsyms.c (find_solib_trampoline_target): Update.
1296         * maint.c (maintenance_info_sections)
1297         (maintenance_translate_address, count_symtabs_and_blocks):
1298         Update.
1299         * main.c (captured_main_1): Update.
1300         * linux-thread-db.c (try_thread_db_load_from_pdir)
1301         (has_libpthread): Update.
1302         * linespec.c (iterate_over_all_matching_symtabs)
1303         (search_minsyms_for_name): Update.
1304         * jit.c (jit_find_objf_with_entry_addr): Update.
1305         * hppa-tdep.c (find_unwind_entry)
1306         (hppa_lookup_stub_minimal_symbol): Update.
1307         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1308         Update.
1309         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1310         (elf_gnu_ifunc_resolve_by_got): Update.
1311         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1312         * dwarf-index-write.c (save_gdb_index_command): Update.
1313         * cp-support.c (add_symbol_overload_list_qualified): Update.
1314         * breakpoint.c (create_overlay_event_breakpoint)
1315         (create_longjmp_master_breakpoint)
1316         (create_std_terminate_master_breakpoint)
1317         (create_exception_master_breakpoint): Update.
1318         * blockframe.c (find_pc_partial_function): Update.
1319         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1320         (ada_collect_symbol_completion_matches)
1321         (ada_add_global_exceptions): Update.
1322
1323 2019-01-17  Tom Tromey  <tom@tromey.com>
1324
1325         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1326         declare VEC.
1327         (solib_target_parse_libraries): Change return type.
1328         (library_list_start_segment, library_list_start_section)
1329         (library_list_end_library, library_list_start_library); Update.
1330         (solib_target_free_library_list): Remove.
1331         (solib_target_parse_libraries): Remove cleanup.  Change return
1332         type.
1333         (solib_target_current_sos): Update.
1334
1335 2019-01-17  Tom Tromey  <tromey@bapiya>
1336
1337         * valprint.c: Replace "the the" with "the".
1338         * symtab.c: Replace "the the" with "the".
1339         * solib.c: Replace "the the" with "the".
1340         * solib-dsbt.c: Replace "the the" with "the".
1341         * linespec.c: Replace "the the" with "the".
1342         * dwarf2loc.h: Replace "the the" with "the".
1343         * amd64-windows-tdep.c: Replace "the the" with "the".
1344         * aarch64-tdep.c: Replace "the the" with "the".
1345
1346 2019-01-16  Keith Seitz  <keiths@redhat.com>
1347
1348         PR gdb/23773
1349         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1350         <builder>: Rename to ..
1351         <m_builder>: ... this and make private.
1352         (dwarf2_cu::get_builder): New method.  Change all users of
1353         `builder' to use this method.
1354         (dwarf2_start_symtab): Move to ...
1355         (dwarf2_cu::start_symtab): ... here.  Update all callers
1356         (setup_type_unit_groups): Move to ...
1357         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1358         callers.
1359         (dwarf2_cu::reset_builder): New method.
1360         (process_full_compunit, process_full_type_unit): Use
1361         dwarf2_cu::reset_builder.
1362         (follow_die_offset): Record the ancestor CU if it is different
1363         from the followed DIE's CU.
1364         (follow_die_sig_1): Likewise.
1365
1366 2019-01-15  Tom Tromey  <tom@tromey.com>
1367
1368         * remote.c (class remote_state) <buf>: Now a char_vector.
1369         <buf_size>: Remove.
1370         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1371         parameter.
1372         (remote_target::getpkt_or_notif_sane_1)
1373         (remote_target::getpkt_sane)
1374         (remote_target::getpkt_or_notif_sane): Likewise.
1375         (class remote_target) <putpkt>: New overload.
1376         (remote_target::read_frame): Change type of "buf_p".  Remove
1377         sizeof_p parameter.
1378         (packet_ok): New overload.
1379         (packet_check_result): New overload.
1380         Update all uses.
1381
1382 2019-01-14  Tom Tromey  <tom@tromey.com>
1383
1384         * remote-notif.c (handle_notification, remote_notif_ack)
1385         (remote_notif_parse): Make "buf" const.
1386         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1387         const.
1388         (remote_notif_parse, remote_notif_ack, handle_notification):
1389         Likewise.
1390         * remote.c (remote_notif_stop_parse): Make "buf" const.
1391         (remote_target::remote_parse_stop_reply): Make "buf" const.
1392         (remote_notif_stop_ack): Make "buf" const.
1393
1394 2019-01-14  Tom Tromey  <tom@tromey.com>
1395
1396         * remote.c (remote_console_output): Make parameter const.
1397
1398 2019-01-14  Tom Tromey  <tom@tromey.com>
1399
1400         * target-debug.h (target_debug_print_signals): Constify.
1401         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1402         * procfs.c (procfs_target::pass_signals): Update.
1403         * linux-nat.c (linux_nat_target::pass_signals): Update.
1404         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1405         * target-delegates.c: Rebuild.
1406         * remote.c (remote_target::program_signals): Update.
1407         (remote_target::pass_signals): Update.
1408         * target.c (target_pass_signals): Constify argument.
1409         (target_program_signals): Likewise.
1410         * target.h (struct target_ops) <pass_signals, program_signals>:
1411         Constify argument.
1412         (target_pass_signals, target_program_signals): Constify argument.
1413
1414 2019-01-14  Tom Tromey  <tom@tromey.com>
1415
1416         PR tui/28819:
1417         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1418
1419 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1420
1421         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1422         field.
1423         * rs6000-tdep.c: Include reggroups.h.
1424         (IS_V_ALIAS_PSEUDOREG): Define.
1425         (rs6000_register_name): Return names for the "vX" aliases.
1426         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1427         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1428         aliases.  Call default_register_reggroup_p for all other
1429         pseudo-registers.
1430         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1431         New functions.
1432         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1433         Handle "vX" aliases.
1434         (v_alias_pseudo_register_collect): New function.
1435         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1436         (rs6000_gdbarch_init): Initialize "vX" aliases as
1437         pseudo-registers.  Restore registration of
1438         rs6000_pseudo_register_reggroup_p with
1439         set_tdesc_pseudo_register_reggroup_p.
1440
1441 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1442
1443         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1444         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1445         set_gdbarch_num_pseudo_regs.
1446
1447 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1448
1449         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1450         Remove arg prefixname, add do_set and do_show.
1451         Add member functions set_list and show_list.
1452         * cli/cli-style.c (class cli_style_option): Update accordingly.
1453         (style_set_list): Move to file scope.
1454         (style_show_list): Likewise.
1455         (set_style): Call help_list.
1456         (show_style): Call cmd_show_list.
1457         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1458         Update to use the new macro.
1459
1460 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1461
1462         * ada-lang.c (_initialize_ada_language): Expand the help text
1463         for the "catch exception" command.
1464
1465 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1466
1467         * symtab.c (matching_obj_sections): Initialize obj,
1468         declare it closer to its usage.
1469
1470 2019-01-10  Tom Tromey  <tom@tromey.com>
1471
1472         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1473         (basic_inf_threads_range): Remove.
1474         (inf_threads_range, inf_non_exited_threads_range)
1475         (safe_inf_threads_range): Use next_adapter.
1476
1477 2019-01-10  Keith Seitz  <keiths@redhat.com>
1478
1479         PR gdb/23712
1480         PR symtab/23010
1481         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1482         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1483
1484 2019-01-10  Keith Seitz  <keiths@redhat.com>
1485
1486         PR gdb/23712
1487         PR symtab/23010
1488         * dictionary.c (pending_to_vector): Remove.
1489         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1490         Remove _1 suffix, replacing functions of the same name.  Update
1491         all callers.
1492         (dict_create_hashed, dict_create_hashed_expandable)
1493         (dict_create_linear, dict_create_linear_expandable, dict_free)
1494         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1495         Make functions static.
1496
1497 2019-01-10  Keith Seitz  <keiths@redhat.com>
1498
1499         PR gdb/23712
1500         PR symtab/23010
1501         * dictionary.h (struct dictionary): Replace declaration with
1502         multidictionary.
1503         (dict_create_hashed, dict_create_hashed_expandable)
1504         (dict_create_linear, dict_create_linear_expandable)
1505         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1506         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1507         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1508         taking multidictionary argument.
1509         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1510         * block.h (struct block) <dict>: Change to multidictionary
1511         and rename `multidict'.
1512         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1513         symmisc.c: Update all dictionary references to multidictionary.
1514
1515 2019-01-10  Keith Seitz  <keiths@redhat.com>
1516
1517         PR gdb/23712
1518         PR symtab/23010
1519         * dictionary.c: Include unordered_map.
1520         (pending_to_vector): New function.
1521         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1522         Rewrite the non-"_1" functions to take vector instead
1523         of linked list.
1524         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1525         "new" _1 versions of the same name.
1526         (multidictionary): Define.
1527         (std::hash<enum language): New definition.
1528         (collate_pending_symbols_by_language, mdict_create_hashed)
1529         (mdict_create_hashed_expandable, mdict_create_linear)
1530         (mdict_create_linear_expandable, mdict_free)
1531         (find_language_dictionary, create_new_language_dictionary)
1532         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1533         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1534         (mdict_size, mdict_empty): New functions.
1535         * dictionary.h (mdict_iterator): Define.
1536
1537 2019-01-10  Pedro Alves  <palves@redhat.com>
1538
1539         * breakpoint.c (read_uploaded_action)
1540         (create_tracepoint_from_upload): Adjust to use
1541         gdb::unique_xmalloc_ptr.
1542         * ctf.c (ctf_write_uploaded_tp):
1543         (SET_ARRAY_FIELD): Use emplace_back.
1544         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1545         * tracefile-tfile.c (tfile_write_uploaded_tp):
1546         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1547         gdb::unique_xmalloc_ptr.
1548         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1549         at_string, cond_string, cmd_strings>: Replace char pointers
1550         with gdb::unique_xmalloc_ptr.
1551
1552 2019-01-10  Pedro Alves  <palves@redhat.com>
1553
1554         * solib-target.c (library_list_start_library): Don't xstrdup name.
1555
1556 2019-01-10  Pedro Alves  <palves@redhat.com>
1557
1558         * mdebugread.c (parse_partial_symbols): Use
1559         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1560
1561 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * linux-fork.c (scoped_switch_fork_info)
1564         <~scoped_switch_fork_info>: Fix incorrect variable name.
1565
1566 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * linux-fork.c (scoped_switch_fork_info)
1569         <scoped_switch_fork_info>: Make explicit.
1570         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1571
1572 2019-01-10  Tom Tromey  <tom@tromey.com>
1573
1574         * objfiles.h (objfile::reset_psymtabs): Update.
1575         * objfiles.c (objfile::objfile): Update.
1576         * psymtab.h (psymtab_storage::obstack): Update.
1577         (psymtab_storage::m_obstack): Use gdb::optional.
1578         (class psymtab_storage): Update comment.  Remove objfile
1579         parameter.
1580         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1581
1582 2019-01-10  Tom Tromey  <tom@tromey.com>
1583
1584         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1585         <free_psymtabs>: Now private.
1586         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1587         (allocate_psymtab): Use new method.
1588
1589 2019-01-10  Tom Tromey  <tom@tromey.com>
1590
1591         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1592         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1593         * mdebugread.c (parse_partial_symbols): Use
1594         allocate_dependencies.
1595         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1596         allocate_dependencies.
1597         (process_psymtab_comp_unit_reader)
1598         (build_type_psymtab_dependencies): Likewise.
1599         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1600
1601 2019-01-10  Tom Tromey  <tom@tromey.com>
1602
1603         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1604         PSYMBOL_SET_LANGUAGE.
1605         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1606
1607 2019-01-10  Tom Tromey  <tom@tromey.com>
1608
1609         * psymtab.h (psymtab_storage::obstack): New method.
1610         <m_obstack>: Rename from obstack; now private.
1611         * psymtab.c (psymtab_storage): Update.
1612         * dwarf2read.c (create_addrmap_from_index)
1613         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1614         Update.
1615
1616 2019-01-10  Tom Tromey  <tom@tromey.com>
1617
1618         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1619         * objfiles.h (objfile::reset_psymtabs): New method.
1620
1621 2019-01-10  Tom Tromey  <tom@tromey.com>
1622
1623         * symmisc.c (print_symbol_bcache_statistics): Update.
1624         (print_objfile_statistics): Update.
1625         * symfile.c (reread_symbols): Update.
1626         * psymtab.h (class psymtab_storage): New.
1627         * psymtab.c (psymtab_storage): New constructor.
1628         (~psymtab_storage): New destructor.
1629         (require_partial_symbols): Update.
1630         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1631         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1632         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1633         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1634         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1635         (start_psymtab_common, end_psymtab_common)
1636         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1637         (allocate_psymtab): Update.
1638         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1639         Update.
1640         (dump_psymtab_addrmap, maintenance_print_psymbols)
1641         (maintenance_check_psymtabs): Update.
1642         (class objfile_psymtabs): Move to objfiles.h.
1643         * psympriv.h (discard_psymtab): Now inline.
1644         (psymtab_discarder::psymtab_discarder): Update.
1645         (psymtab_discarder::~psymtab_discarder): Update.
1646         (ALL_OBJFILE_PSYMTABS): Rewrite.
1647         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1648         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1649         Remove fields.
1650         <partial_symtabs>: New field.
1651         (class objfile_psymtabs): Move from psymtab.h.  Update.
1652         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1653         psymbol_cache.
1654         (objfile::~objfile): Don't destroy psymbol_cache.
1655         * mdebugread.c (parse_partial_symbols): Update.
1656         * dwarf2read.c (create_addrmap_from_index)
1657         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1658         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1659         (add_partial_subprogram, dwarf2_ranges_read): Update.
1660         * dwarf-index-write.c (write_address_map)
1661         (write_one_signatured_type, recursively_write_psymbols)
1662         (class debug_names, class debug_names, write_psymtabs_to_index):
1663         Update.
1664
1665 2019-01-10  Tom Tromey  <tom@tromey.com>
1666
1667         * symtab.h (SYMBOL_SET_NAMES): Update.
1668         (symbol_set_names): Update.
1669         (MSYMBOL_SET_NAMES): Update.
1670         * symtab.c (symbol_set_names): Change argument to be an
1671         objfile_per_bfd_storage.
1672         * psymtab.c (add_psymbol_to_bcache): Update.
1673         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1674
1675 2019-01-10  Tom Tromey  <tom@tromey.com>
1676
1677         * symtab.c (create_demangled_names_hash): Change argument to be an
1678         objfile_per_bfd_storage.
1679         (symbol_set_names): Update.
1680
1681 2019-01-10  Tom Tromey  <tom@tromey.com>
1682
1683         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1684         init_psymbol_list.
1685         * psymtab.c (init_psymbol_list): Do nothing if already called.
1686         * psympriv.h (init_psymbol_list): Add comment.
1687         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1688         init_psymbol_list.
1689         * dbxread.c (dbx_symfile_read): Unconditionally call
1690         init_psymbol_list.
1691
1692 2019-01-10  Tom Tromey  <tom@tromey.com>
1693
1694         * xcoffread.c (scan_xcoff_symtab): Update.
1695         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1696         "where".
1697         * mdebugread.c (parse_partial_symbols)
1698         (handle_psymbol_enumerators): Update.
1699         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1700         * dbxread.c (read_dbx_symtab): Update.
1701         * psympriv.h (psymbol_placement): New enum.
1702         (add_psymbol_to_list): Update.
1703
1704 2019-01-10  Tom Tromey  <tom@tromey.com>
1705
1706         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1707         static_psymbols parameters.
1708         (scan_xcoff_symtab): Update.
1709         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1710         static_psymbols parameters.
1711         * psympriv.h (start_psymtab_common): Update.
1712         * mdebugread.c (parse_partial_symbols): Update.
1713         * dwarf2read.c (create_partial_symtab): Update.
1714         * dbxread.c (read_dbx_symtab): Update.
1715         (start_psymtab): Remove global_psymbols and static_psymbols
1716         parameters.
1717
1718 2019-01-10  Tom Tromey  <tom@tromey.com>
1719
1720         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1721         * psymtab.c (allocate_psymtab): Add comment.
1722         * psympriv.h (allocate_psymtab): Add comment.
1723         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1724         initializations.
1725         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1726
1727 2019-01-10  Tom Tromey  <tom@tromey.com>
1728
1729         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1730         Don't declare.
1731         * mipsread.c: Include mdebugread.h.
1732         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1733         Declare.
1734         * elfread.c: Include mdebugread.h.
1735
1736 2019-01-09  Tom Tromey  <tom@tromey.com>
1737
1738         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1739         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1740         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1741         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1742         (psym_lookup_symbol, psym_find_last_source_symtab)
1743         (psym_forget_cached_source_info, psym_print_stats)
1744         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1745         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1746         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1747         (psym_find_compunit_symtab_by_address)
1748         (maintenance_print_psymbols, maintenance_info_psymtabs)
1749         (maintenance_check_psymtabs): Use ranged for.
1750         * psymtab.h (class objfile_psymtabs): New.
1751         (require_partial_symbols): Return objfile_psymtabs.
1752         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1753
1754 2019-01-09  Tom Tromey  <tom@tromey.com>
1755
1756         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1757         (find_pc_mapped_section, list_overlays_command)
1758         (map_overlay_command, unmap_overlay_command)
1759         (simple_overlay_update): Use all_objfiles.
1760         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1761         * printcmd.c (info_symbol_command): Use all_objfiles.
1762         * objfiles.h (ALL_OBJSECTIONS): Remove.
1763         * maint.c (maintenance_translate_address): Use all_objfiles.
1764         * gcore.c (gcore_create_callback): Use all_objfiles.
1765         (objfile_find_memory_regions): Likewise.
1766
1767 2019-01-09  Tom Tromey  <tom@tromey.com>
1768
1769         * symtab.c (find_line_symtab, info_sources_command)
1770         (make_source_files_completion_list): Use objfile_compunits.
1771         * source.c (select_source_symtab): Use objfile_compunits.
1772         * objfiles.h (struct objfile): Update comment.
1773         (ALL_OBJFILES): Remove.
1774         (ALL_FILETABS): Remove.
1775         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1776         objfile_compunits.
1777
1778 2019-01-09  Tom Tromey  <tom@tromey.com>
1779
1780         * symmisc.c (print_objfile_statistics, dump_objfile)
1781         (maintenance_print_symbols): Use compunit_filetabs.
1782         * source.c (forget_cached_source_info_for_objfile): Use
1783         compunit_filetabs.
1784         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1785         (ALL_FILETABS): Use compunit_filetabs.
1786         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1787         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1788
1789 2019-01-09  Tom Tromey  <tom@tromey.com>
1790
1791         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1792         (compunit_filetabs): New.
1793         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1794         compunit_filetabs.
1795         (info_sources_command, make_source_files_completion_list): Remove
1796         declaration.
1797         * symmisc.c (print_objfile_statistics, dump_objfile)
1798         (maintenance_print_symbols): Remove declaration.
1799         (maintenance_info_symtabs): Use compunit_filetabs.
1800         (maintenance_info_line_tables): Likewise.
1801         * source.c (select_source_symtab): Change local variable name.
1802         (forget_cached_source_info_for_objfile): Remove declaration.
1803         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1804         * objfiles.c (objfile_relocate1): Remove declaration.
1805         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1806         declaration.
1807         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1808         * coffread.c (coff_symtab_read): Remove declaration.
1809         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1810         compunit_filetabs.
1811
1812 2019-01-09  Tom Tromey  <tom@tromey.com>
1813
1814         * symtab.c (lookup_objfile_from_block)
1815         (find_pc_sect_compunit_symtab, search_symbols)
1816         (default_collect_symbol_completion_matches_break_on): Use
1817         objfile_compunits.
1818         * objfiles.h (ALL_COMPUNITS): Remove.
1819         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1820         * cp-support.c (add_symbol_overload_list_qualified): Use
1821         objfile_compunits.
1822         * ada-lang.c (ada_collect_symbol_completion_matches)
1823         (ada_add_global_exceptions): Use objfile_compunits.
1824
1825 2019-01-09  Tom Tromey  <tom@tromey.com>
1826
1827         * source.c (select_source_symtab)
1828         (forget_cached_source_info_for_objfile): Remove declaration.
1829         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1830         declaration.
1831         * maint.c (count_symtabs_and_blocks): Remove declaration.
1832         * cp-support.c (add_symbol_overload_list_qualified): Remove
1833         declaration.
1834         * coffread.c (coff_symtab_read): Remove declaration.
1835         * symtab.c (lookup_symbol_in_objfile_symtabs)
1836         (basic_lookup_transparent_type_1): Use objfile_compunits.
1837         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1838         (info_sources_command, search_symbols)
1839         (default_collect_symbol_completion_matches_break_on)
1840         (make_source_files_completion_list): Remove declaration.
1841         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1842         (ada_collect_symbol_completion_matches)
1843         (ada_add_global_exceptions): Remove declaration.
1844         * linespec.c (iterate_over_all_matching_symtabs): Use
1845         objfile_compunits.
1846         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1847         (class objfile_compunits): New.
1848         (ALL_COMPUNITS): Use objfile_compunits.
1849         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1850         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1851         objfile_compunits.
1852         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1853
1854 2019-01-09  Tom Tromey  <tom@tromey.com>
1855
1856         * symtab.c (search_symbols)
1857         (default_collect_symbol_completion_matches_break_on): Use
1858         objfile_msymbols.
1859         * ada-lang.c (ada_lookup_simple_minsym)
1860         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1861         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1862         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1863         objfile_msymbols.
1864         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1865         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1866         * objc-lang.c (find_methods): Use objfile_msymbols.
1867         (info_selectors_command, info_classes_command): Likewise.
1868         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1869         * objfiles.h (class objfile_msymbols): New.
1870         (ALL_OBJFILE_MSYMBOLS): Remove.
1871         (ALL_MSYMBOLS): Remove.
1872
1873 2019-01-09  Tom Tromey  <tom@tromey.com>
1874
1875         * common/next-iterator.h (next_adapter): Add Iterator template
1876         parameter.
1877         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1878         (class all_objfiles_safe): New.
1879         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1880         * objfiles.c (put_objfile_before): Update comment.
1881         (add_separate_debug_objfile): Likewise.
1882         (free_all_objfiles): Use all_objfiles_safe.
1883         (objfile_purge_solibs): Likewise.
1884
1885 2019-01-09  Tom Tromey  <tom@tromey.com>
1886
1887         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1888         (expand_symtab_containing_pc, lookup_static_symbol)
1889         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1890         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1891         all_objfiles.
1892         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1893         * breakpoint.c (create_overlay_event_breakpoint)
1894         (create_longjmp_master_breakpoint)
1895         (create_std_terminate_master_breakpoint)
1896         (create_exception_master_breakpoint): Use all_objfiles.
1897         * linux-thread-db.c (try_thread_db_load_from_pdir)
1898         (has_libpthread): Use all_objfiles.
1899         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1900         * linespec.c (iterate_over_all_matching_symtabs)
1901         (search_minsyms_for_name): Use all_objfiles.
1902         * maint.c (maintenance_info_sections): Use all_objfiles.
1903         * main.c (captured_main_1): Use all_objfiles.
1904         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1905         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1906         * guile/scm-pretty-print.c
1907         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1908         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1909         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1910         (maintenance_print_msymbols): Use all_objfiles.
1911         * source.c (select_source_symtab): Use all_objfiles.
1912         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1913         * symfile.c (remove_symbol_file_command)
1914         (expand_symtabs_matching, map_symbol_filenames): Use
1915         all_objfiles.
1916         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1917         all_objfiles.
1918         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1919         * objc-lang.c (find_methods): Use all_objfiles.
1920         * objfiles.c (have_partial_symbols, have_full_symbols)
1921         (have_minimal_symbols, qsort_cmp)
1922         (default_iterate_over_objfiles_in_search_order): Use
1923         all_objfiles.
1924         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1925         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1926         (maintenance_check_psymtabs): Use all_objfiles.
1927         (ALL_PSYMTABS): Remove.
1928         * compile/compile-object-run.c (do_module_cleanup): Use
1929         all_objfiles.
1930         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1931         * cp-support.c (add_symbol_overload_list_qualified): Use
1932         all_objfiles.
1933         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1934         Use all_objfiles.
1935         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1936         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1937         all_objfiles.
1938         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1939         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1940         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1941         Uses all_objfiles.
1942         * solib.c (solib_read_symbols): Use all_objfiles
1943
1944 2019-01-09  Tom Tromey  <tom@tromey.com>
1945
1946         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1947         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1948         all_objfiles.
1949         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1950         * symmisc.c (print_symbol_bcache_statistics)
1951         (print_objfile_statistics, maintenance_print_objfiles)
1952         (maintenance_info_symtabs, maintenance_check_symtabs)
1953         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1954         all_objfiles.
1955         * source.c (forget_cached_source_info): Use all_objfiles.
1956         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1957         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1958         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1959         * objfiles.c (update_section_map): Use all_objfiles.
1960         (shared_objfile_contains_address_p): Likewise.
1961         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1962         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1963
1964 2019-01-09  Tom Tromey  <tom@tromey.com>
1965
1966         * common/next-iterator.h: New file.
1967         * objfiles.h (class all_objfiles): New.
1968         (struct objfile_iterator): New.
1969
1970 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1971
1972         * NEWS: Move the description of the changed "frame", "select-frame",
1973          and "info frame" commands to the Changed commands section.
1974
1975 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1976
1977         * gdbtypes.c (check_stub_method_group): Remove handling of old
1978         mangling schemes.
1979         * linespec.c (find_methods): Likewise.
1980         * stabsread.c (read_member_functions): Likewise.
1981         * valops.c (search_struct_method): Likewise.
1982         (value_struct_elt_for_reference): Likewise.
1983         * NEWS: Mention this change.
1984
1985 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1988         print_source_lines.
1989         * source.c (print_source_lines_base): Update line number check.
1990         (print_source_lines): New function.
1991         (source_lines_range::source_lines_range): New function.
1992         * source.h (class source_lines_range): New class.
1993         (print_source_lines): New declaration.
1994
1995 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1996
1997         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1998
1999 2019-01-08  Tom Tromey  <tom@tromey.com>
2000             Simon Marchi  <simon.marchi@ericsson.com>
2001
2002         PR gdb/24060
2003         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2004         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2005         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2006         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2007         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2008         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2009
2010 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2011
2012         * source.c (select_source_symtab): Move header comment to
2013         declaration in source.h.
2014         (forget_cached_source_info_for_objfile): Likewise.
2015         (forget_cached_source_info): Likewise.
2016         (identify_source_line): Likewise.
2017         * source.h (identify_source_line): Move declaration from symtab.h
2018         and add comment from source.c
2019         (print_source_lines): Likewise.
2020         (forget_cached_source_info_for_objfile): Likewise.
2021         (forget_cached_source_info): Likewise.
2022         (select_source_symtab): Likewise.
2023         (enum print_source_lines_flag): Move definition from symtab.h.
2024         * symtab.h (identify_source_line): Move declaration to source.h.
2025         (print_source_lines): Likewise.
2026         (forget_cached_source_info_for_objfile): Likewise.
2027         (forget_cached_source_info): Likewise.
2028         (select_source_symtab): Likewise.
2029         (enum print_source_lines_flag): Move definition to source.h.
2030         * tui/tui-hooks.c: Add 'source.h' include.
2031
2032 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2033
2034         * source.c (print_source_lines_base): Handle requests to print
2035         reverse line number sequences, and guard against empty lines
2036         string.
2037
2038 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2039
2040         * source.c (print_source_lines_base): Fix skip of '\r' if next
2041         character is '\n'.
2042
2043 2019-01-06  Tom Tromey  <tom@tromey.com>
2044
2045         * c-exp.y (struct c_parse_state) <macro_original_text,
2046         expansion_obstack>: New member.
2047         (macro_original_text, expansion_obstack): Remove globals.
2048         (scan_macro_expansion, scanning_macro_expansion)
2049         (finished_macro_expansion): Update.
2050         (scan_macro_cleanup): Remove.
2051         (yylex, c_parse): Update.
2052
2053 2019-01-06  Tom Tromey  <tom@tromey.com>
2054
2055         * c-exp.y (struct c_parse_state) <strings>: New member.
2056         (operator_stoken): Update.
2057
2058 2019-01-06  Tom Tromey  <tom@tromey.com>
2059
2060         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2061         (union type_stack_elt) <typelist_val>: Now a pointer to
2062         std::vector.
2063         (type_stack_cleanup): Don't declare.
2064         (push_typelist): Update.
2065         * parse.c (pop_typelist): Return a std::vector.
2066         (push_typelist): Take a std::vector.
2067         (follow_types): Update.  Do not free args.
2068         (type_stack_cleanup): Remove.
2069         * c-exp.y (struct c_parse_state): New.
2070         (cpstate): New global.
2071         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2072         (nonempty_typelist): Update.
2073         (func_mod): Create a new vector.
2074         (c_parse): Create a c_parse_state.
2075         (check_parameter_typelist): Do not delete params.
2076         (function_method): Update.  Do not delete type_list.
2077
2078 2019-01-06  Tom Tromey  <tom@tromey.com>
2079
2080         PR gdb/28155:
2081         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2082         check_typedef.
2083         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2084         (print_return_value): Likewise.
2085
2086 2019-01-05  Tom Tromey  <tom@tromey.com>
2087
2088         * contrib/cleanup_check.py: Remove.
2089         * contrib/gcc-with-excheck: Remove.
2090         * contrib/exsummary.py: Remove.
2091         * contrib/excheck.py: Remove.
2092
2093 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2094
2095         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2096         NULL. Initialize tpprev to NULL instead of assigning it
2097         to NULL on the next statement.
2098         * windows-nat.c (windows_delete_thread): Remove check for
2099         main_thread_id before printing thread exit notifications.
2100         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2101         Remove thread ID check against main_thread_id.
2102         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2103         windows_delete_thread.
2104         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2105
2106 2019-01-04  Tom Tromey  <tom@tromey.com>
2107
2108         * compile/compile.c (_initialize_compile): Use upper case for
2109         metasyntactic variables.
2110         * symmisc.c (_initialize_symmisc): Use upper case for
2111         metasyntactic variables.
2112         * psymtab.c (_initialize_psymtab): Use upper case for
2113         metasyntactic variables.
2114         * demangle.c (demangle_command): Use upper case for metasyntactic
2115         variables.
2116         (_initialize_demangler): Likewise.
2117         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2118         variables.
2119
2120 2019-01-03  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2123
2124 2019-01-03  Tom Tromey  <tom@tromey.com>
2125
2126         * python/py-symtab.c (salpy_str): Update.
2127         (struct salpy_sal_object) <symtab>: Now a PyObject.
2128         (salpy_dealloc): Update.
2129         (del_objfile_sal): Use gdbpy_ref.
2130
2131 2019-01-03  Tom Tromey  <tom@tromey.com>
2132
2133         * python/py-type.c (convert_field): Use new_reference.  Return
2134         gdbpy_ref.
2135         (make_fielditem): Return gdbpy_ref.
2136         (typy_fields): Update.
2137         (typy_getitem): Update.
2138         (field_name): Return gdbpy_ref.  Use new_reference.
2139         (typy_iterator_iternext): Update.
2140
2141 2019-01-03  Tom Tromey  <tom@tromey.com>
2142
2143         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2144
2145 2019-01-03  Tom Tromey  <tom@tromey.com>
2146
2147         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2148         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2149         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2150         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2151         (pspy_set_type_printers): Likewise.
2152         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2153         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2154         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2155         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2156         (objfpy_set_type_printers): Likewise.
2157
2158 2019-01-03  Tom Tromey  <tom@tromey.com>
2159
2160         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2161         (gdbpy_print_stack): Use gdbpy_err_fetch.
2162         * python/python-internal.h (class gdbpy_err_fetch): New class.
2163         (class gdbpy_enter) <m_error_type, m_error_value,
2164         m_error_traceback>: Remove.
2165         <m_error>: New member.
2166         (gdbpy_exception_to_string): Don't declare.
2167         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2168         * python/py-value.c (convert_value_from_python): Use
2169         gdbpy_err_fetch.
2170         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2171         gdbpy_exception_to_string.
2172         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2173         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2174         gdbpy_err_fetch.
2175
2176 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * linux-nat.c (delete_lwp_cleanup): Delete.
2179         (struct lwp_deleter): New struct.
2180         (lwp_info_up): New typedef.
2181         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2182         lwp_info_up.
2183
2184 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2185
2186         * linux-fork.c (class scoped_switch_fork_info): New class.
2187         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2188
2189 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * valops.c (find_overload_match): Remove use of null_cleanup, and
2192         calls to do_cleanups.
2193
2194 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * compile/compile-cplus-types.c
2197         (compile_cplus_instance::decl_name): Handle changes to
2198         cp_func_name.
2199         * cp-support.c (cp_func_name): Update header comment, update
2200         return type.
2201         * cp-support.h (cp_func_name): Update return type in declaration.
2202         * valops.c (find_overload_match): Move temp_func local to top
2203         level of function and change its type.  Use temp_func to hold and
2204         delete temporary string obtained from cp_func_name.
2205
2206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2209         gdb::char_vector, remove cleanup, and update uses of `msg`.
2210
2211 2019-01-03  Jim Wilson  <jimw@sifive.com>
2212
2213         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2214
2215 2019-01-02  Tom Tromey  <tom@tromey.com>
2216
2217         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2218         (tdesc_parse_xml): Remove cleanups.
2219         * target-descriptions.h (make_cleanup_free_target_description):
2220         Don't declare.
2221         (target_desc_deleter): New struct.
2222         (target_desc_up): New typedef.
2223         * target-descriptions.c (target_desc_deleter::operator()): Rename
2224         from free_target_description.
2225         (make_cleanup_free_target_description): Remove.
2226
2227 2019-01-02  Tom Tromey  <tom@tromey.com>
2228
2229         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2230         constructor, destructor.
2231         (linespec_parser): Remove typedef.
2232         (~linespec_parser): Rename from linespec_parser_delete.
2233         (linespec_lex_to_end, linespec_complete_label)
2234         (linespec_complete): Update.
2235         (decode_line_full): Remove cleanups.
2236         (decode_line_1): Update.
2237
2238 2019-01-02  Tom Tromey  <tom@tromey.com>
2239
2240         * python/python-internal.h (inferior_to_inferior_object): Change
2241         return type.
2242         * python/py-exitedevent.c (create_exited_event_object): Update.
2243         * python/py-inferior.c (inferior_to_inferior_object): Return
2244         gdbpy_ref.
2245         (python_new_inferior, python_inferior_deleted)
2246         (thread_to_thread_object, delete_thread_object)
2247         (build_inferior_list, gdbpy_selected_inferior): Update.
2248         * python/py-infthread.c (create_thread_object): Update.  Also fail
2249         if inferior_to_inferior_object fails.
2250
2251 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2252
2253         * inferior.h (class inferior) <displaced_step_state>: New field.
2254         * infrun.h (struct displaced_step_state): Move here from
2255         infrun.c.  Initialize fields, add constructor.
2256         <inf>: Remove field.
2257         <reset>: New method.
2258         * infrun.c (struct displaced_step_inferior_state): Move to
2259         infrun.h.
2260         (displaced_step_inferior_states): Remove.
2261         (get_displaced_stepping_state): Adust.
2262         (displaced_step_in_progress_any_inferior): Adjust.
2263         (displaced_step_in_progress_thread): Adjust.
2264         (displaced_step_in_progress): Adjust.
2265         (add_displaced_stepping_state): Remove.
2266         (get_displaced_step_closure_by_addr): Adjust.
2267         (remove_displaced_stepping_state): Remove.
2268         (infrun_inferior_exit): Call displaced_step_state.reset.
2269         (use_displaced_stepping): Don't check for NULL.
2270         (displaced_step_prepare_throw): Call
2271         get_displaced_stepping_state.
2272         (displaced_step_fixup): Don't check for NULL.
2273         (prepare_for_detach): Don't check for NULL.
2274
2275 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2276
2277         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2278          in case of call that did not complete.
2279
2280 2019-01-02  Andrey Utkin  <autkin@undo.io>
2281
2282         * symfile.c (find_separate_debug_file): Fix search of debug files for
2283         remote debuggee.
2284
2285 2019-01-02  Tom Tromey  <tom@tromey.com>
2286
2287         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2288         indentation.
2289         * python/py-frame.c (frapy_older): Remove cast.
2290         (frapy_newer): Likewise.
2291         * python/py-breakpoint.c (local_setattro): Remove cast.
2292         * python/py-arch.c (archpy_name): Remove local variable.
2293         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2294
2295 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2296
2297         * unittests/basic_string_view/element_access/char/empty.cc:
2298         Fix year range in copyright header.
2299
2300 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2303         Delete.
2304         <operator==>: Update with for removed field.
2305         <hash>: Likewise.
2306         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2307         <isa_features>: ...this.
2308         <abi_features>: New field.
2309         (riscv_isa_flen): Update comment.
2310         (riscv_abi_xlen): New declaration.
2311         (riscv_abi_flen): New declaration.
2312         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2313         isa_features.
2314         (riscv_abi_xlen): New function.
2315         (riscv_isa_flen): Update to get answer from isa_features.
2316         (riscv_abi_flen): New function.
2317         (riscv_has_fp_abi): Update to get answer from abi_features.
2318         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2319         xlen and flen.
2320         (riscv_call_info) <xlen, flen>: Update comment.
2321         (riscv_call_arg_struct): Remove invalid assertions
2322         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2323         is removed.
2324         (riscv_gdbarch_init): Gather isa features and abi features
2325         separately, ensure both match on the gdbarch when reusing an old
2326         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2327         a target with 64-bit float hardware.
2328
2329 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2330
2331         * source.c (search_command_helper): Stop reverse search
2332         when line 1 has been searched.
2333
2334 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2335
2336         * record-full.c (record_full_base_target::close): Rewrite
2337         record_full_core_buf_list free logic.
2338
2339 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2340
2341         * break-catch-syscall.c (print_one_catch_syscall): xfree
2342         the last text.
2343
2344 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2345
2346         * top.c (print_gdb_version): Update Copyright year in version
2347         message.
2348
2349 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2350
2351         Update copyright year range in all GDB files.
2352
2353 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2354
2355         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2356
2357 For older changes see ChangeLog-2018.
2358 \f
2359 Local Variables:
2360 mode: change-log
2361 left-margin: 8
2362 fill-column: 74
2363 version-control: never
2364 coding: utf-8
2365 End:
2366