gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.h (tui_set_layout_by_name): Don't declare.
   4         * tui/tui-regs.c (tui_reg_layout): New function.
   5         (tui_show_registers, tui_reg_command): Use it.
   6         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
   7         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
   8         parameters.
   9         (tui_layout_command): Remove.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-layout.h (tui/tui-layout): Return void.
  14         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-layout.c (show_source_disasm_command, show_data):
  19         Update.
  20         (reset_locator): Remove.
  21         (show_source_or_disasm_and_command): Update.
  22
  23 2019-07-17  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-source.c (tui_source_window_base::reset): Remove
  26         win_type parameter.
  27         * tui/tui-layout.c (make_command_window, make_source_window)
  28         (make_disasm_window, make_data_window)
  29         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  30         (reset_locator, show_source_or_disasm_and_command): Update.
  31         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  32         win_type parameter.
  33         (struct tui_source_window_base) <reset>: Likewise.
  34
  35 2019-07-17  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-layout.c (show_source_disasm_command): Use
  38         reset_locator.
  39         (reset_locator): New function.
  40         (init_and_make_win): Remove.
  41         (show_source_or_disasm_and_command): Use reset_locator.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  46         condition.
  47         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  48         Remove condition.
  49         * tui/tui-source.c (tui_source_window_base::reset): New method.
  50         * tui/tui-layout.c (make_command_window): Don't call
  51         init_and_make_win.
  52         (make_source_window, make_disasm_window): Don't call
  53         make_source_or_disasm_window.
  54         (make_data_window): Don't call init_and_make_win.  Change calling
  55         convention.
  56         (show_source_disasm_command, show_data): Simplify.
  57         (make_source_or_disasm_window): Remove.
  58         (show_source_or_disasm_and_command): Simplify.
  59         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  60         (struct tui_source_window_base) <reset>: Likewise.
  61         <execution_info>: Remove initializer.
  62         * tui/tui-data.c (tui_source_window_base): Initialize
  63         execution_info.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  68         variable.
  69
  70 2019-07-17  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui.c (tui_rl_other_window): Update.
  73         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  74         superclass method first.  Always iterate over regs_content.
  75         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  76         method.
  77         * tui/tui-win.c (tui_set_focus_command): Update.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-win.c (tui_set_focus_command): Rename from
  82         tui_set_focus.  Call tui_enable.
  83         (tui_set_focus_command): Remove.
  84
  85 2019-07-17  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  88         refresh_window.
  89         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  90         touchwin.
  91         (tui_data_window::refresh_window): Call refresh_window on data
  92         items.  Always call superclass refresh_window.
  93         (tui_win_info::refresh): Remove.
  94         (tui_source_window_base::refresh_window): Update.
  95         (tui_refresh_all): Update.
  96         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  97         refresh_window.
  98         (show_source_or_disasm_and_command): Likewise.
  99         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 100         (struct tui_source_window_base) <refresh>: Likewise.
 101
 102 2019-07-17  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-winsource.c (tui_clear_source_content)
 105         (tui_show_source_content): Update.
 106         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 107         whether content is empty.
 108         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 109         Remove.
 110
 111 2019-07-17  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 114         window's contents.
 115         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 116         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 121         (struct tui_data_item_window): Update.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 126         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 127         defines.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-winsource.h (tui_erase_source_content)
 132         (tui_clear_source_content): Remove "display_prompt" parameter.
 133         * tui/tui-winsource.c (tui_update_source_window_as_is)
 134         (tui_update_source_windows_with_addr): Update.
 135         (tui_clear_source_content): Remove "display_prompt" parameter.
 136         (tui_erase_source_content): Likewise.  Simplify.
 137         (tui_show_source_content): Update.
 138         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 139         * tui/tui-stack.c (tui_show_frame_info): Update.
 140         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 141         Remove defines.
 142
 143 2019-07-17  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 146         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 147         parameter.
 148         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 149         parameter.
 150
 151 2019-07-17  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.c (tui_clear_source_content)
 154         (tui_show_source_content, tui_show_exec_info_content)
 155         (tui_clear_exec_info_content): Update.
 156         * tui/tui-stack.c (tui_show_locator_content): Update.
 157         (tui_show_frame_info): Update.
 158         * tui/tui-source.h (tui_source_window): Don't declare.
 159         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 160         from tui_source_is_displayed.
 161         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 162         Remove field.
 163         (struct tui_source_window_base) <content_in_use>: New field.  Now
 164         bool.
 165         (struct tui_source_window) <showing_source_p>: New method.
 166         (TUI_SRC_WIN): Change cast.
 167         * tui/tui-data.c (tui_initialize_static_data): Update.
 168
 169 2019-07-17  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 172         location_matches_p.
 173         * tui/tui-source.c (tui_source_window::location_matches_p): New
 174         method.
 175         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 176         method.
 177         * tui/tui-data.h (struct tui_source_window_base)
 178         <location_matches_p>: New method.
 179         (struct tui_source_window, struct tui_disasm_window)
 180         <location_matches_p>: Likewise.
 181
 182 2019-07-17  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-win.c (tui_set_win_height_command): Rename from
 185         tui_set_win_height.
 186         (tui_set_win_height_command): Remove.
 187
 188 2019-07-17  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-source.c (tui_source_window): New constructor.  Add
 191         observer.
 192         (~tui_source_window): New destructor.
 193         (tui_source_window::style_changed): New method.
 194         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 195         (tui_attach_detach_observers): Update.
 196         * tui/tui-data.h (struct tui_source_window): Make constructor not
 197         inline.  Add destructor.
 198         (struct tui_source_window) <style_changed>: New method.
 199         <m_observable>: New member.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 204         * tui/tui-win.c (tui_resize_all): Fix typo.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 209         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 210         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 211         * tui/tui-win.c (window_name_completer): Use foreach.
 212         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 213         (update_tab_width): Likewise.
 214         * tui/tui-layout.c (show_layout): Update.
 215         * tui/tui-data.h (class tui_window_iterator): New.
 216         (struct all_tui_windows): New.
 217         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 222         parameter.  Don't reference globals.
 223         (tui_reg_command): Update.
 224
 225 2019-07-17  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-regs.c (tui_show_registers): Simplify.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-regs.c (tui_show_registers): Update.
 232         (tui_show_register_group): Add win_info parameter.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 237         Rename from tui_display_reg_element_at_line.
 238         (tui_data_window::display_registers_from_line): Update.
 239         * tui/tui-data.h (struct tui_data_window)
 240         <display_reg_element_at_line>: New method.
 241
 242 2019-07-17  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-regs.h (tui_display_registers_from)
 245         (tui_display_registers_from_line): Don't declare.
 246         * tui/tui-windata.c (tui_data_window::display_all_data)
 247         (tui_data_window::refresh_all)
 248         (tui_data_window::do_scroll_vertical): Update.
 249         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 250         from tui_display_registers_from.
 251         (tui_display_reg_element_at_line): Update.
 252         (tui_data_window::display_registers_from_line): Rename from
 253         tui_display_registers_from_line.
 254         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 255         display_registers_from_line>: New methods.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 260         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 261         from tui_erase_data_content.
 262         (tui_data_window::display_all_data)
 263         (tui_data_window::refresh_all)
 264         (tui_data_window::do_scroll_vertical): Update.
 265         * tui/tui-regs.c (tui_show_registers): Update.
 266         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 267         New method.
 268
 269 2019-07-17  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 272         declare.
 273         * tui/tui-windata.c
 274         (tui_data_window::delete_data_content_windows): Rename from
 275         tui_delete_data_content_windows.
 276         (tui_data_window::display_all_data)
 277         (tui_data_window::do_scroll_vertical): Update.
 278         * tui/tui-data.h (struct tui_data_window)
 279         <delete_data_content_windows>: New method.
 280
 281 2019-07-17  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 284         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 285
 286 2019-07-17  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 289         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 290         from tui_display_all_data.
 291         * tui/tui-win.c
 292         (tui_data_window::do_make_visible_with_new_height): Update.
 293         * tui/tui-regs.c (tui_show_registers): Update.
 294         * tui/tui-layout.c (tui_set_layout): Update.
 295         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 296         method.
 297
 298 2019-07-17  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 301         * tui/tui-windata.c (tui_display_data_from): Remove.
 302         (tui_data_window::refresh_all): Update.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 307         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 308         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 309         tui_display_registers_from_line.
 310         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 311         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 312         "force_display" parameter.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 317         declare.
 318         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 319         Rename from tui_first_reg_element_no_inline.
 320         (tui_display_reg_element_at_line)
 321         (tui_display_registers_from_line): Update.
 322         * tui/tui-data.h (struct tui_data_window)
 323         <first_reg_element_no_inline>: New method.
 324
 325 2019-07-17  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-windata.c (tui_display_data_from)
 328         (tui_data_window::do_scroll_vertical): Update.
 329         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 330         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 331         Rename from tui_line_from_reg_element_no.
 332         (tui_display_registers_from_line): Update.
 333         * tui/tui-data.h (struct tui_data_window)
 334         <line_from_reg_element_no>: New method.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 339         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 340         tui_last_regs_line_no.
 341         (tui_display_reg_element_at_line)
 342         (tui_display_registers_from_line): Update.
 343         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 344         method.
 345
 346 2019-07-17  Tom Tromey  <tom@tromey.com>
 347
 348         PR tui/24722:
 349         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 350         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 351         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 352         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 353         (tui_update_breakpoint_info): Likewise.
 354         * tui/tui-hooks.c (tui_event_create_breakpoint)
 355         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 356         Update.
 357
 358 2019-07-17  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 361
 362 2019-07-17  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-winsource.c (tui_update_source_window_as_is)
 365         (tui_update_source_windows_with_addr): Update.
 366         * tui/tui-source.h (tui_set_source_content)
 367         (tui_show_symtab_source): Add "win_info" parameter.
 368         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 369         parameter.
 370         (tui_show_symtab_source): Likewise.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-wingeneral.c
 375         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 380         (struct tui_cmd_window) <can_scroll>: New method.
 381         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 382         method.
 383
 384 2019-07-17  Tom Tromey  <tromey@adacore.com>
 385
 386         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 387         do_field_signed>: Rename.  Change type of "value".
 388         * ui-out.c (ui_out::field_signed): Rename from field_int.
 389         Change type of "value".
 390         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 391         type of "value".
 392         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 393         do_field_int.  Change type of "value".
 394         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 395         do_field_int.  Change type of "value".
 396         * tracepoint.c (trace_status_mi, tfind_1)
 397         (print_one_static_tracepoint_marker): Update.
 398         * thread.c (print_thread_info_1, print_selected_thread_frame):
 399         Update.
 400         * stack.c (print_frame, print_frame_info): Update.
 401         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 402         Update.
 403         * source.c (print_source_lines_base): Update.
 404         * skip.c (info_skip_command): Update.
 405         * record-btrace.c (btrace_ui_out_decode_error)
 406         (btrace_call_history_src_line): Update.
 407         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 408         Update.
 409         * progspace.c (print_program_space): Update.
 410         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 411         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 412         do_field_int.  Change type of "value".
 413         * mi/mi-out.c (mi_ui_out::do_table_begin)
 414         (mi_ui_out::do_table_header): Update.
 415         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 416         type of "value".
 417         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 418         (mi_cmd_data_list_changed_registers, output_register)
 419         (mi_cmd_data_read_memory, mi_load_progress)
 420         (mi_cmd_trace_frame_collected): Update.
 421         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 422         Update.
 423         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 424         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 425         (mi_cmd_var_list_children, varobj_update_one): Update.
 426         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 427         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 428         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 429         * inferior.c (print_inferior): Update.
 430         * gdb_bfd.c (print_one_bfd): Update.
 431         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 432         Update.
 433         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 434         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 435         do_field_int.  Change type of "value".
 436         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 437         do_field_int.  Change type of "value".
 438         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 439         (print_one_breakpoint_location, print_it_catch_fork)
 440         (print_one_catch_fork, print_it_catch_vfork)
 441         (print_one_catch_vfork, print_it_catch_solib)
 442         (print_it_catch_exec, print_it_ranged_breakpoint)
 443         (print_mention_watchpoint, print_mention_masked_watchpoint)
 444         (bkpt_print_it, update_static_tracepoint): Update.
 445         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 446         * break-catch-syscall.c (print_it_catch_syscall): Update.
 447         * ada-tasks.c (print_ada_task_info): Update.
 448         * ada-lang.c (print_it_exception, print_mention_exception):
 449         Update.
 450
 451 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         PR breakpoints/24541
 454         * gdbarch.c: Regenerate.
 455         * gdbarch.h: Regenerate.
 456         * gdbarch.sh: Adjust return type and parameter types for
 457         'stap_adjust_register'.
 458         (i386_stap_adjust_register): Adjust signature and return new
 459         register name.
 460         * stap-probe.c (stap_parse_register_operand): Adjust use of
 461         'gdbarch_stap_adjust_register'.
 462
 463 2019-07-17  Tom Tromey  <tromey@adacore.com>
 464
 465         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 466         declare VEC.
 467         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 468         std::vector.
 469         (struct s390_process_info): Add initializers.
 470         (s390_add_process): Use new.
 471         (s390_linux_nat_target::low_forget_process): Use delete.
 472         (s390_linux_nat_target::low_new_fork)
 473         (s390_linux_nat_target::stopped_by_watchpoint)
 474         (s390_linux_nat_target::low_prepare_to_resume)
 475         (s390_linux_nat_target::insert_watchpoint)
 476         (s390_linux_nat_target::insert_hw_breakpoint)
 477         (s390_linux_nat_target::remove_watchpoint)
 478         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 479
 480 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 481
 482         * aarch64-fbsd-nat.c: Include regcache.h.
 483         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 484         argument.
 485         (aarch64_fbsd_nat_target::fetch_registers)
 486         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 487         variable.
 488         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 489
 490 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 491
 492         * fbsd-nat.c: Include gdbarch.h.
 493
 494 2019-07-15  Tom Tromey  <tromey@adacore.com>
 495
 496         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 497
 498 2019-07-15  Tom Tromey  <tromey@adacore.com>
 499
 500         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 501         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 502         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 503         * cli-out.c (cli_ui_out::do_field_int): New method.
 504         * ui-out.c (ui_out::field_unsigned): New method.
 505         * symfile.c (generic_load): Use field_unsigned.
 506         (print_transfer_performance): Likewise.
 507         * record-btrace.c (ui_out_field_uint): Remove.
 508         (btrace_call_history_insn_range, btrace_call_history): Use
 509         field_unsigned.
 510         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 511         field_unsigned.
 512         * ui-out.h (class ui_out) <field_unsigned>: New method.
 513         <do_field_unsigned>: Likewise.
 514
 515 2019-07-15  Tom Tromey  <tromey@adacore.com>
 516
 517         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 518         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 519         * target.c (flash_erase_command): Use field_string.
 520         * infrun.c (print_signal_received_reason): Use field_string.
 521         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 522         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 523         field_string.
 524         * ada-tasks.c (print_ada_task_info): Use field_string.
 525
 526 2019-07-15  Tom Tromey  <tromey@adacore.com>
 527
 528         * target.c (flash_erase_command): Use field_core_addr.
 529         * symfile.c (generic_load): Use field_core_addr.
 530         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 531         Use field_core_addr.
 532         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 533         field_core_addr.
 534
 535 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 536
 537         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 538         value if its desired type is smaller than a CORE_ADDR and signed.
 539
 540 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 543         of changes to field names, and use new is_reference field to
 544         decide if a property is a reference or not.
 545         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 546         field.
 547         (struct dwarf2_property_baton): Update header comment, rename
 548         'referenced_type' to 'property_type' and update comments.
 549         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 550         default property type, store in property baton, update to take
 551         accound of renamed field.
 552         (read_func_scope): Update call to attr_to_dynamic_prop.
 553         (read_array_type): Likewise.
 554         (dwarf2_per_cu_addr_sized_int_type): New function.
 555         (read_subrange_index_type): Move type finding code to
 556         dwarf2_per_cu_addr_sized_int_type.
 557         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 558         (dwarf2_per_cu_addr_type): New function.
 559         (set_die_type): Update calls to attr_to_dynamic_prop.
 560
 561 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * dwarf2read.c (read_subrange_index_type): New function.
 564         (read_subrange_type): Move code into new function and call it.
 565         * gdbtypes.c (create_range_type): Add some asserts.
 566
 567 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 570         update return statements.
 571         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 572         declaration, and update comment to match.
 573         * gdbtypes.c (resolve_dynamic_array): Update call to
 574         dwarf2_evaluate_property to match new return type.
 575
 576 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * valarith.c (value_subscripted_rvalue): Change lowerbound
 579         parameter type from int to LONGEST.
 580         * value.h (value_subscripted_rvalue): Likewise in declaration.
 581
 582 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 583
 584         * cli/cli-utils.c (info_print_command_completer): New function.
 585         * cli/cli-utils.h: Add 'completer.h' include, and forward
 586         declaration for 'struct cmd_list_element'.
 587         (info_print_command_completer): Declare.
 588         * stack.c (_initialize_stack): Add completer for 'info locals' and
 589         'info args'.
 590         * symtab.c (_initialize_symtab): Add completer for 'info
 591         variables' and 'info functions'.
 592         * NEWS: Mention completion for additional info commands.
 593
 594 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * cli/cli-utils.c (extract_info_print_args): Delete.
 597         (extract_arg_maybe_quoted): Delete.
 598         (info_print_options_defs): New variable.
 599         (make_info_print_options_def_group): New function.
 600         (extract_info_print_options): Define new function.
 601         * cli/cli-utils.h (extract_info_print_args): Delete.
 602         (struct info_print_options): New structure.
 603         (extract_info_print_options): Declare new function.
 604         * stack.c (info_locals_command): Update to use new
 605         extract_info_print_options, also add a header comment.
 606         (info_args_command): Likewise.
 607         * symtab.c (info_variables_command): Likewise.
 608         (info_functions_command): Likewise.
 609
 610 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 611
 612         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 613         to extract string arguments.
 614         * common/common-utils.c (extract_string_maybe_quoted): New function.
 615         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 616
 617 2019-07-11  Tom Tromey  <tromey@adacore.com>
 618
 619         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 620         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 621         * top.h (gdbinit): Don't declare.
 622         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 623         into...
 624         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 625         * top.c (gdb_init): Don't call init_cli_cmds.
 626         (gdbinit): Remove.
 627         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 628
 629 2019-07-11  Tom Tromey  <tromey@adacore.com>
 630
 631         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 632         after it has been moved.
 633
 634 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 635
 636         * valops.c (value_must_coerce_to_target): Change return type to
 637         bool.
 638         * value.h (value_must_coerce_to_target): Likewise.
 639
 640 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 641
 642         * breakpoint.c (is_hardware_watchpoint): Remove
 643         forward-declaration.
 644         (is_masked_watchpoint): Change return type to bool.
 645         (is_tracepoint): Likewise.
 646         (is_breakpoint): Likewise.
 647         (is_hardware_watchpoint): Likewise.
 648         (is_watchpoint): Likewise.
 649         (is_no_memory_software_watchpoint): Likewise.
 650         (is_catchpoint): Likewise.
 651         (breakpoint_1): Make FILTER parameter's return type bool.
 652         is_masked_watchpoint): Change return type to bool.
 653         (save_breakpoints): Make FILTER parameter's return type bool.
 654         * breakpoint.h (is_breakpoint): Change return type to bool.
 655         (is_watchpoint): Likewise.
 656         (is_catchpoint): Likewise.
 657         (is_tracepoint): Likewise.
 658
 659 2019-07-10  Tom Tromey  <tom@tromey.com>
 660
 661         * defs.h: Don't include gdbarch.h.
 662         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 663         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 664         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 665         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 666         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 667         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 668         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 669         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 670         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 671         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 672         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 673         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 674         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 675         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 676         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 677         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 678         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 679         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 680         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 681         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 682         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 683         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 684         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 685         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 686         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 687         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 688         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 689
 690 2019-07-10  Tom Tromey  <tromey@adacore.com>
 691
 692         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 693         * breakpoint.c (init_ada_exception_breakpoint): Register as
 694         bp_catchpoint.
 695         (print_one_breakpoint_location, print_one_breakpoint): Use
 696         is_ada_exception_catchpoint.
 697         * ada-lang.c (class ada_catchpoint_location): Pass
 698         bp_loc_software_breakpoint to bp_location constructor.
 699         (is_ada_exception_catchpoint): New function.
 700
 701 2019-07-10  Tom Tromey  <tromey@adacore.com>
 702
 703         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 704         VEC.
 705         (struct arm_exidx_entry): New method operator<.
 706         (struct arm_exidx_data) <section_maps>: Change type.
 707         (arm_exidx_data_free): Remove.
 708         (arm_exidx_data_key): Change type.  Move lower.
 709         (arm_exidx_new_objfile): Update.
 710         (arm_compare_exidx_entries): Remove.
 711         (arm_find_exidx_entry, _initialize_arm_tdep)
 712
 713 2019-07-10  Tom Tromey  <tromey@adacore.com>
 714
 715         * solib-spu.c (ocl_program_data_key): Change type.
 716         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 717         Update.
 718
 719 2019-07-10  Tom Tromey  <tromey@adacore.com>
 720
 721         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 722         (struct solib_aix_inferior_data) <library_list>: Change type.
 723         (solib_aix_inferior_data_handle): Change type.
 724         (get_solib_aix_inferior_data): Update.
 725         (solib_aix_free_library_list): Remove.
 726         (library_list_start_library): Update.
 727         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 728         return type.
 729         (solib_aix_get_library_list)
 730         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 731         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 732
 733 2019-07-10  Tom Tromey  <tromey@adacore.com>
 734
 735         * solib-dsbt.c (struct dsbt_info): Add initializers.
 736         (solib_dsbt_pspace_data): Change type.
 737         (dsbt_pspace_data_cleanup): Remove.
 738         (get_dsbt_info, _initialize_dsbt_solib): Update.
 739
 740 2019-07-10  Tom Tromey  <tromey@adacore.com>
 741
 742         * spu-tdep.c (spu_overlay_data): Change type.
 743         (spu_get_overlay_table, spu_overlay_new_objfile)
 744         (_initialize_spu_tdep): Update.
 745
 746 2019-07-10  Tom Tromey  <tromey@adacore.com>
 747
 748         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 749         destructor.
 750         (dbx_objfile_data_key): Change type and declare later.
 751         (DBX_SYMFILE_INFO): Rewrite.
 752         * dbxread.c (dbx_objfile_data_key): Change type.
 753         (dbx_symfile_init): Update.
 754         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 755         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 756         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 757
 758 2019-07-10  Tom Tromey  <tromey@adacore.com>
 759
 760         * jit.c (jit_program_space_key): Change type.  Move lower.
 761         (get_jit_program_space_data): Update.
 762         (jit_program_space_data_cleanup): Remove.
 763         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 764         Update.
 765         (struct jit_program_space_data): Add initializers.
 766
 767 2019-07-10  Tom Tromey  <tromey@adacore.com>
 768
 769         * solib-darwin.c (struct darwin_info): Add initializers.
 770         (solib_darwin_pspace_data): Change type.
 771         (darwin_pspace_data_cleanup): Remove.
 772         (get_darwin_info, _initialize_darwin_solib): Update.
 773
 774 2019-07-10  Tom Tromey  <tromey@adacore.com>
 775
 776         * remote-sim.c (struct sim_inferior_data): Add initializers,
 777         constructor, and destructor.
 778         (sim_inferior_data_key): Change type.  Move lower.
 779         (check_for_duplicate_sim_descriptor): Update.
 780         (get_sim_inferior_data): Use new.  Update.
 781         (~sim_inferior_data_cleanup): Rename from
 782         sim_inferior_data_cleanup.  Simplify.
 783         (gdbsim_close_inferior, simulator_command)
 784         (sim_command_completer, _initialize_remote_sim): Update.
 785         (next_pid, INITIAL_PID): Move earlier.
 786
 787 2019-07-10  Tom Tromey  <tromey@adacore.com>
 788
 789         * python/python-internal.h (create_thread_object): Return
 790         gdbpy_ref.
 791         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 792         * python/py-inferior.c (struct threadlist_entry): Add
 793         constructor.
 794         <thread_obj>: Now a gdbpy_ref.
 795         (thread_to_thread_object): Update.
 796         (add_thread_object): Use new.
 797         (delete_thread_object): Use delete.
 798         (infpy_threads): Update.
 799         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 800         GIL.
 801
 802 2019-07-10  Tom Tromey  <tromey@adacore.com>
 803
 804         * valops.c (value_cast): Specialize error message for Ada.
 805
 806 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 807
 808         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 809
 810 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 811
 812         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 813         bpstat_should_step): Return bool, adjust comments.
 814         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 815         bpstat_should_step): Likewise.
 816
 817 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 818
 819         * features/Makefile: Use feature target descriptions for Arm.
 820         * features/arm/arm-core.c: Generate new file.
 821         * features/arm/arm-fpa.c: Likewise.
 822         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 823         * features/arm/arm-m-profile.c: Likewise.
 824         * features/arm/arm-vfpv2.c: Likewise.
 825         * features/arm/arm-vfpv3.c: Likewise.
 826         * features/arm/xscale-iwmmxt.c: Likewise.
 827         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 828
 829 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 830
 831         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 832         ptrace earlier.
 833
 834 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 835
 836         * features/aarch64-pauth.c: Regenerate.
 837
 838 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 839
 840         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 841         bool.
 842         (bpstat_what): Use false instead of 0.
 843
 844 2019-07-09  Pedro Alves  <palves@redhat.com>
 845
 846         * break-catch-throw.c (is_exception_catchpoint): New.
 847         * breakpoint.c (print_one_breakpoint_location): New parameter
 848         'raw_loc'.  Handle it.  Use
 849         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 850         looking at the breakpoint's type.
 851         (print_one_breakpoint): If handling "maint info breakpoints", also
 852         print locations of exception catchpoints.
 853         * breakpoint.h (is_exception_catchpoint): Declare.
 854
 855 2019-07-09  Pedro Alves  <palves@redhat.com>
 856
 857         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 858         "addr" field.
 859         (allocate_location_exception_catchpoint): New.
 860         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 861         (initialize_throw_catchpoint_ops): Install
 862         allocate_location_exception_catchpoint as allocate_location
 863         method.
 864         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 865         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 866         bp_loc_other.
 867         (breakpoint_address_is_meaningful): Delete.
 868         (bl_address_is_meaningful): New.
 869         (breakpoint_locations_match): Adjust comment.
 870         (bp_location_from_bp_type): New, factored out of...
 871         (bp_location::bp_location(breakpoint *)): ... this.
 872         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 873         factored out of...
 874         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 875         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 876         breakpoint_address_is_meaningful.
 877         (bp_locations_compare): Adjust comment.
 878         (update_global_location_list): Use bl_address_is_meaningful
 879         instead of breakpoint_address_is_meaningful.
 880         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 881         explicit.
 882         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 883         * python/py-breakpoint.c (bppy_get_location): No longer check
 884         whether location is null.
 885
 886 2019-07-09  Pedro Alves  <palves@redhat.com>
 887
 888         PR c++/15468
 889         * breakpoint.c (print_one_breakpoint_location): Remove
 890         single-location assert.
 891
 892 2019-07-09  Tom Tromey  <tom@tromey.com>
 893
 894         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 895         * configure: Rebuild.
 896         * configure.ac: Change common to gdbsupport.
 897         * gdbsupport: Rename from common.
 898         * acinclude.m4: Change common to gdbsupport.
 899         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 900         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 901         gdbsupport.
 902         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 903         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 904         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 905         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 906         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 907         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 908         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 909         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 910         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 911         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 912         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 913         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 914         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 915         coff-pe-read.c, command.h, compile/compile-c-support.c,
 916         compile/compile-c.h, compile/compile-cplus-symbols.c,
 917         compile/compile-cplus-types.c, compile/compile-cplus.h,
 918         compile/compile-loc2c.c, compile/compile.c, completer.c,
 919         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 920         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 921         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 922         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 923         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 924         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 925         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 926         features/aarch64-core.c, features/aarch64-fpu.c,
 927         features/aarch64-pauth.c, features/aarch64-sve.c,
 928         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 929         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 930         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 931         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 932         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 933         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 934         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 935         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 936         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 937         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 938         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 939         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 940         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 941         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 942         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 943         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 944         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 945         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 946         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 947         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 948         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 949         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 950         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 951         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 952         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 953         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 954         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 955         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 956         minsyms.c, mips-linux-tdep.c, namespace.h,
 957         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 958         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 959         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 960         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 961         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 962         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 963         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 964         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 965         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 966         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 967         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 968         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 969         procfs.c, producer.c, progspace.h, psymtab.h,
 970         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 971         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 972         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 973         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 974         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 975         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 976         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 977         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 978         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 979         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 980         target-memory.c, target.c, target.h, target/waitstatus.c,
 981         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 982         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 983         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 984         unittests/array-view-selftests.c,
 985         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 986         unittests/common-utils-selftests.c,
 987         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 988         unittests/format_pieces-selftests.c,
 989         unittests/function-view-selftests.c,
 990         unittests/lookup_name_info-selftests.c,
 991         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 992         unittests/mkdir-recursive-selftests.c,
 993         unittests/observable-selftests.c,
 994         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 995         unittests/parse-connection-spec-selftests.c,
 996         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 997         unittests/scoped_fd-selftests.c,
 998         unittests/scoped_mmap-selftests.c,
 999         unittests/scoped_restore-selftests.c,
1000         unittests/string_view-selftests.c, unittests/style-selftests.c,
1001         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1002         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1003         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1004         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1005         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1006         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1007
1008 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1011         bool value.
1012         (decode_digits_ordinary): Set explicit_line field in sal.
1013         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1014         symtab_and_line that was set on an explicit line number in
1015         assembler code.  Do always update the recorded symtab and line if
1016         we do skip the prologue.
1017
1018 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * breakpoint.c (set_breakpoint_location_function): Remove
1021         explicit_loc parameter.
1022         (momentary_breakpoint_from_master): Update call to
1023         set_breakpoint_location_function.
1024         (add_location_to_breakpoint): Likewise.
1025
1026 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1029         required features based on default bfd type when no specific bfd
1030         is present.
1031
1032 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1033
1034         * NEWS: Mention that GDB printf and eval commands can now print
1035         C-style and Ada-style convenience var strings without
1036         calling the inferior.
1037         * printcmd.c (printf_c_string): Locally print GDB internal var
1038         instead of transiting via the inferior.
1039         (printf_wide_c_string): Likewise.
1040
1041 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1042
1043         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1044
1045 2019-07-04  Tom Tromey  <tom@tromey.com>
1046
1047         PR tui/24724:
1048         * tui/tui-winsource.c (tui_clear_source_content): Update.
1049         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1050         (tui_update_breakpoint_info): Update.
1051         (tui_set_exec_info_content): Update.
1052         * tui/tui-source.c (tui_set_source_content_nil): Update.
1053         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1054         has_break.
1055         * tui/tui-data.h (enum tui_bp_flag): New.
1056         (tui_bp_flags): New enum flags type.
1057         (struct tui_source_element) <break_mode>: Change type.  Rename
1058         from has_break.
1059         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1060         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1061         constants.
1062         * tui/tui-winsource.h: Fix comment.
1063
1064 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1065
1066         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1067         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1068         (store_fpregs_to_thread)
1069         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1070         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1071         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1072         (IWMMXT_REGS_SIZE): Add define.
1073         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1074         (fetch_vfp_regs, store_vfp_regs)
1075         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1076         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1077
1078 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1079
1080         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1081         defines.
1082         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1083         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1084         (ARM_INT_REGISTER_SIZE): ...to this.
1085         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1086         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1087         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1088         (arm_linux_collect_gregset, supply_nwfpe_register)
1089         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1090         defines.
1091         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1092         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1093         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1094         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1095         (arm_return_in_memory, arm_store_return_value)
1096         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1097         (arm_record_ld_st_multiple): Likewise.
1098         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1099         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1100
1101 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1102
1103         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1104         AARCH64_DISPLACED_MODIFIED_INSNS.
1105         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1106         (aarch64_displaced_step_copy_insn): Likewise.
1107         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1108         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1109         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1110         ARM_DISPLACED_MODIFIED_INSNS.
1111         * arm-tdep.c (arm_gdbarch_init): Likewise.
1112         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1113         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1114         (struct arm_displaced_step_closure): Use
1115         ARM_DISPLACED_MODIFIED_INSNS.
1116
1117 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1118
1119         * features/Makefile: Remove unused xml files.
1120         * features/aarch64.xml: Remove.
1121         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1122         * features/i386/amd64-avx-avx512.xml: Remove.
1123         * features/i386/amd64-avx-linux.xml: Remove.
1124         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1125         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1126         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1127         * features/i386/amd64-avx-mpx.xml: Remove.
1128         * features/i386/amd64-avx.xml: Remove.
1129         * features/i386/amd64-linux.xml: Remove.
1130         * features/i386/amd64-mpx-linux.xml: Remove.
1131         * features/i386/amd64-mpx.xml: Remove.
1132         * features/i386/amd64.xml: Remove.
1133         * features/i386/i386-avx-avx512-linux.xml: Remove.
1134         * features/i386/i386-avx-avx512.xml: Remove.
1135         * features/i386/i386-avx-linux.xml: Remove.
1136         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1137         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1138         * features/i386/i386-avx-mpx-linux.xml: Remove.
1139         * features/i386/i386-avx-mpx.xml: Remove.
1140         * features/i386/i386-avx.xml: Remove.
1141         * features/i386/i386-linux.xml: Remove.
1142         * features/i386/i386-mmx-linux.xml: Remove.
1143         * features/i386/i386-mmx.xml: Remove.
1144         * features/i386/i386-mpx-linux.xml: Remove.
1145         * features/i386/i386-mpx.xml: Remove.
1146         * features/i386/i386.xml: Remove.
1147         * features/i386/x32-avx-avx512-linux.xml: Remove.
1148         * features/i386/x32-avx-linux.xml: Remove.
1149         * features/i386/x32-linux.xml: Remove.
1150
1151 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1152
1153         * regformats/aarch64.dat: Remove.
1154         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1155         * regformats/i386/amd64-avx-linux.dat: Remove.
1156         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1157         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1158         * regformats/i386/amd64-linux.dat: Remove.
1159         * regformats/i386/amd64-mpx-linux.dat: Remove.
1160         * regformats/i386/amd64.dat: Remove.
1161         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1162         * regformats/i386/i386-avx-linux.dat: Remove.
1163         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1164         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1165         * regformats/i386/i386-linux.dat: Remove.
1166         * regformats/i386/i386-mmx-linux.dat: Remove.
1167         * regformats/i386/i386-mpx-linux.dat: Remove.
1168         * regformats/i386/i386.dat: Remove.
1169         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1170         * regformats/i386/x32-avx-linux.dat: Remove.
1171         * regformats/i386/x32-linux.dat: Remove.
1172
1173 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1174
1175         * aarch64-tdep.c: Remove xml self tests.
1176         * amd64-linux-tdep.c: Likewise.
1177         * amd64-tdep.c: Likewise.
1178         * i386-linux-tdep.c: Likewise.
1179         * i386-tdep.c: Likewise.
1180
1181 2019-07-03  Pedro Alves  <palves@redhat.com>
1182
1183         PR cli/24732
1184         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1185         (pipe_cmd_option_defs): New.
1186         (make_pipe_cmd_options_def_group): New.
1187         (pipe_command): Use gdb::option::process_options.
1188         (pipe_command_completer): New function.
1189         (_initialize_cli_cmds): Install completer for "pipe" command.
1190
1191 2019-07-03  Pedro Alves  <palves@redhat.com>
1192
1193         * cli/cli-option.c (union option_value) <string>: New field.
1194         (struct option_def_and_value): Add ctor, move ctor, dtor and
1195         use DISABLE_COPY_AND_ASSIGN.
1196         (option_def_and_value::clear_value): New.
1197         (parse_option, save_option_value_in_ctx, get_val_type_str)
1198         (add_setshow_cmds_for_options): Handle var_string.
1199         * cli-option.h (union option_def::var_address) <string>: New
1200         field.
1201         (struct string_option_def): New.
1202         * maint-test-options.c (struct test_options_opts): Add default
1203         ctor and use DISABLE_COPY_AND_ASSIGN.
1204         <string_opt>: New field.
1205         (test_options_opts::~test_options_opts): New.
1206         (test_options_opts::dump): Also dump "-string".
1207         (test_options_option_defs): Install "string.
1208
1209 2019-07-03  Pedro Alves  <palves@redhat.com>
1210
1211         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1212         option_value with a null enumeration.
1213         (complete_options): Save the option values in the context.
1214         (save_option_value_in_ctx): New, factored out from ...
1215         (process_options): ... here.
1216         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1217         of the function.
1218         * maint-test-options.c (test_options_opts::dump): New, factored
1219         out from ...
1220         (maintenance_test_options_command_mode): ... here.
1221         (maintenance_test_options_command_completion_result): Delete.
1222         (maintenance_test_options_command_completion_text): Update
1223         comment.
1224         (maintenance_show_test_options_completion_result): Change
1225         prototype.  Just print
1226         maintenance_test_options_command_completion_text.
1227         (save_completion_result): New.
1228         (maintenance_test_options_completer_mode): Pass options context to
1229         complete_options, and then save a dump.
1230         (_initialize_maint_test_options): Use add_cmd to install "maint
1231         show test-options-completion-result".
1232
1233 2019-07-03  Pedro Alves  <palves@redhat.com>
1234
1235         * NEWS (New commands): Mention "with" and "maint with".
1236         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1237         (with_command, with_command_completer): New.
1238         (pipe_command): Adjust to new repeat_previous
1239         interface.
1240         (_initialize_cli_cmds): Install the "with" command and its "w"
1241         alias.
1242         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1243         declarations.
1244         * cli/cli-setshow.c (parse_cli_var_uinteger)
1245         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1246         argument strings for all var_types.
1247         (get_setshow_command_value_string): New, factored out from ...
1248         (do_show_command): ... this.
1249         * cli/cli-setshow.h: Include <string>.
1250         (get_setshow_command_value_string): Declare.
1251         * command.h (repeat_previous): Now returns const char *.  Adjust
1252         comment.
1253         * maint.c: Include "cli/cli-cmds.h".
1254         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1255         (_initialize_maint_cmds): Register the "maintenance with" command.
1256         * top.c (repeat_previous): Move bits from pipe_command here:
1257         Return the saved command line, if any; error out if there's no
1258         command to relaunch.
1259
1260 2019-07-03  Pedro Alves  <palves@redhat.com>
1261
1262         * NEWS (New commands): Mention "maint set/show test-settings"
1263         instead of "maint test-settings".
1264         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1265         (maintenance_test_settings_set_list): Rename to ...
1266         (maintenance_set_test_settings_list): ... this.
1267         (maintenance_test_settings_show_list): Rename to  ...
1268         (maintenance_show_test_settings_list): ... this.
1269         (maintenance_test_settings_cmd): Delete.
1270         (maintenance_test_settings_set_cmd): ...
1271         (maintenance_set_test_settings_cmd): ... this.
1272         (maintenance_test_settings_show_cmd): ...
1273         (maintenance_show_test_settings_cmd): ... this.
1274         (maintenance_test_settings_show_value_cmd):
1275         (maintenance_show_test_settings_value_cmd): ... this.
1276         (_initialize_maint_test_settings): No longer install the "maint
1277         test-settings" prefix command.  Rename "maint test-settings set"
1278         to "maint set test-settings", and "maint test-settings show" to
1279         "maint show test-settings".  Adjust all subcommands.
1280
1281 2019-07-03  Pedro Alves  <palves@redhat.com>
1282
1283         * maint-test-settings.c: Fix file's intro comment.  Replace all
1284         references to "test-options" with references to "test-settings",
1285         in comments.
1286
1287 2019-07-03  Pedro Alves  <palves@redhat.com>
1288
1289         * maint-test-settings.c (maintenance_test_settings_xxx)
1290         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1291         New.
1292         (maintenance_test_settings_enums): Use them.
1293         (maintenance_test_settings_enum): Default to
1294         maintenance_test_settings_xxx.
1295         (_initialize_maint_test_settings): Initialize
1296         MAINTENANCE_TEST_SETTINGS_FILENAME.
1297
1298 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         * breakpoint.h (remove_breakpoints_inf): Change return type to
1301         void, move function documentation here.
1302         * breakpoint.c (remove_breakpoints_inf): Change return type to
1303         void, move function documentation to header.
1304
1305 2019-07-02  Pedro Alves  <palves@redhat.com>
1306
1307         * NEWS (Completion improvements): Mention "info threads".
1308         * thread.c (struct info_threads_opts, info_threads_option_defs)
1309         (make_info_threads_options_def_group): New.
1310         (info_threads_command): Use gdb::option::process_options.
1311         (info_threads_command_completer): New.
1312         (_initialize_thread): Use gdb::option::build_help to build the
1313         help text for "info threads".
1314
1315 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1316
1317         * defs.h (generic_load): Move from here...
1318         * symfile.h (generic_load): ... to here.  Rename name parameter
1319         to args.
1320         * symfile.c (generic_load): Add comment.
1321
1322 2019-07-01  Tom Tromey  <tromey@adacore.com>
1323
1324         * dwarf2read.c
1325         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1326         declaration of without_params.  Fix formatting.
1327
1328 2019-07-01  Tom Tromey  <tromey@adacore.com>
1329
1330         * ada-exp.y (find_primitive_type): Update.
1331         * ada-lang.h (ada_lookup_symbol): Update.
1332         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1333         parameter.
1334         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1335
1336 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1337
1338         PR breakpoints/24541
1339         * gdbarch.c: Regenerate.
1340         * gdbarch.h: Regenerate.
1341         * gdbarch.sh: Add 'stap_adjust_register'.
1342         * i386-tdep.c: Include '<unordered_set>'.
1343         (i386_stap_adjust_register): New function.
1344         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1345         * stap-probe.c (stap_parse_register_operand): Call
1346         'gdbarch_stap_adjust_register'.
1347
1348 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1349
1350         PR python/24742
1351         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1352         * python/python.c (do_start_initialization): Use 'xmalloc'
1353         instead of 'PyMem_Malloc'.
1354
1355 2019-06-28  Tom Tromey  <tromey@adacore.com>
1356
1357         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1358         for Ada.
1359
1360 2019-06-27  Tom Tromey  <tromey@adacore.com>
1361
1362         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1363         objfile_key.
1364         (arm_find_mapping_symbol, arm_record_special_symbol)
1365         (_initialize_arm_tdep): Update.
1366         (arm_objfile_data_free): Remove.
1367
1368 2019-06-27  Tom Tromey  <tromey@adacore.com>
1369
1370         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1371         to cp_print_static_field.
1372
1373 2019-06-26  Tom Tromey  <tromey@adacore.com>
1374
1375         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1376         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1377         declare.
1378
1379 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1380
1381         * features/aarch64-core.c (create_feature_aarch64_core):
1382         Regenerate.
1383         * features/aarch64-core.xml: Add cpsr flags.
1384
1385 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1386
1387         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1388         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1389
1390 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1391
1392         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1393         field.
1394         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1395         use.
1396         (arm_record_special_symbol): Don't insert new symbol in sorted
1397         position, push it at the end.
1398
1399 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1400
1401         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1402         (arm_mapping_symbol_s): Remove.
1403         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1404         (arm_mapping_symbol_vec): New typedef.
1405         (struct arm_per_objfile): Add constructor.
1406         <section_maps>: Change type to
1407         std::unique_ptr<arm_mapping_symbol_vec[]>.
1408         (arm_compare_mapping_symbols): Remove.
1409         (arm_find_mapping_symbol): Adjust to section_maps type change.
1410         (arm_objfile_data_free): Call delete on arm_per_objfile.
1411         (arm_record_special_symbol): Adjust to section_maps type change.
1412         Allocate arm_per_objfile with new.
1413
1414 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1415
1416         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1417         with the command prefix.
1418
1419 2019-06-25  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1422         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1423
1424 2019-06-25  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1427         type.
1428         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1429         protected.
1430
1431 2019-06-25  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c
1434         (tui_source_window_base::set_is_exec_point_at): Add check against
1435         LOA_ADDRESS.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-source.c (tui_set_source_content): Don't check before
1440         xfree.
1441         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1442
1443 2019-06-25  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-winsource.h (tui_update_source_window_as_is)
1446         (tui_alloc_source_buffer, tui_line_is_displayed)
1447         (tui_addr_is_displayed): Change type of win_info.
1448         * tui/tui-winsource.c (tui_update_source_window_as_is)
1449         (tui_clear_source_content, tui_show_source_line)
1450         (tui_show_source_content, tui_source_window_base::refill)
1451         (tui_source_window_base::set_is_exec_point_at)
1452         (tui_source_window_base::set_is_exec_point_at)
1453         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1454         (tui_alloc_source_buffer, tui_line_is_displayed)
1455         (tui_addr_is_displayed): Change type of win_info.  Update.
1456         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1457         (tui_source_window_base::do_make_visible_with_new_height):
1458         Update.
1459         * tui/tui-source.c (tui_set_source_content)
1460         (tui_set_source_content_nil)
1461         (tui_source_window::do_scroll_vertical): Update.
1462         * tui/tui-layout.c (show_layout): Update.
1463         * tui/tui-disasm.c (tui_set_disassem_content)
1464         (tui_disasm_window::do_scroll_vertical): Update.
1465         * tui/tui-data.h (tui_win_content): Remove.
1466         (struct tui_gen_win_info) <content, content_size>: Remove.
1467         (struct tui_source_element): Add initializers and destructor.
1468         (union tui_which_element, struct tui_win_element): Remove.
1469         (struct tui_source_window_base) <content>: New field.
1470         (struct tui_data_window): Remove destructor.
1471         (tui_alloc_content, tui_free_win_content)
1472         (tui_free_all_source_wins_content): Don't declare.
1473         * tui/tui-data.c (tui_initialize_static_data): Update.
1474         (init_content_element, tui_alloc_content): Remove.
1475         (~tui_gen_win_info): Update.
1476         (~tui_data_window, tui_free_all_source_wins_content)
1477         (tui_free_win_content, free_content, free_content_elements):
1478         Remove.
1479
1480 2019-06-25  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-winsource.h (tui_clear_source_content)
1483         (tui_erase_source_content, tui_show_source_content): Change type
1484         of win_info.
1485         * tui/tui-winsource.c (tui_clear_source_content)
1486         (tui_erase_source_content, tui_show_source_content): Change type
1487         of win_info.
1488         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1489         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1490         win_info.
1491         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1492         win_info.
1493         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-winsource.c (tui_clear_source_content)
1498         (tui_source_window_base::set_is_exec_point_at): Update.
1499         * tui/tui-source.c (tui_set_source_content_nil): Update.
1500         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1501         a bool.
1502         * tui/tui-data.c (init_content_element): Update.
1503
1504 2019-06-25  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1507         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1508         * tui/tui-layout.c (init_and_make_win): Update.
1509         * tui/tui.h (enum tui_win_type): Update.
1510         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1511         tui_win_is_auxillary.
1512         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1513         tui_win_is_auxillary.
1514
1515 2019-06-25  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1518         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1519         (tui_delete_data_content_windows, tui_display_all_data)
1520         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1521         Update.
1522         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1523         * tui/tui-regs.c (tui_last_regs_line_no)
1524         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1525         (tui_show_registers): Update.
1526         (tui_show_register_group): Return void.  Update.
1527         (tui_display_registers_from, tui_display_reg_element_at_line)
1528         (tui_display_registers_from_line, tui_check_register_values):
1529         Update.
1530         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1531         member.
1532         (struct tui_data_window) <regs_content>: Now a std::vector.
1533         <regs_content_count>: Remove.
1534         (tui_add_content_elements, tui_free_data_content): Don't declare.
1535         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1536         (init_content_element): Remove DATA_WIN case.  Add assert.
1537         (tui_add_content_elements): Remove.
1538         (tui_data_window): Update.
1539         (tui_free_data_content): Remove.
1540         (free_content_elements): Remove DATA_WIN case.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-data.c (tui_data_item_window): Update.
1545         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1546         * tui/tui-windata.c (tui_display_all_data)
1547         (tui_display_data_from_line): Update.
1548         (tui_check_data_values): Remove.
1549         * tui/tui-regs.c (tui_show_register_group)
1550         (tui_display_reg_element_at_line): Update.
1551         * tui/tui-hooks.c (tui_register_changed)
1552         (tui_refresh_frame_and_register_information): Call
1553         tui_check_register_values.
1554         * tui/tui-data.h (struct tui_data_window) <data_content,
1555         data_content_count, data_type>: Remove.
1556         (enum tui_data_type): Remove.
1557
1558         * tui/tui-data.c (tui_data_window::clear_detail)
1559         (~tui_data_window): Update.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1564         declare.
1565         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1566         Rename from tui_first_data_item_displayed.  Update.
1567         (tui_data_window::refresh_all)
1568         (tui_data_window::do_scroll_vertical): Update.
1569         * tui/tui-data.h (struct tui_data_window)
1570         <first_data_item_displayed>: Declare new method.
1571
1572 2019-06-25  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1575         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1576         contents...
1577         (tui_initialize_static_data): ...here.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1582         (tui_display_registers_from, tui_check_register_values): Update.
1583         (tui_display_register): Remove win_info parameter; update.
1584         (tui_get_register): Change type of parameters.
1585         * tui/tui-data.h (struct tui_data_element): Remove.
1586         (union tui_which_element) <data>: Remove.
1587         <data_window>: Change type.
1588         (struct tui_data_item_window): New.
1589         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1590         case.  Add assert.
1591         (~tui_data_item_window): New destructor.
1592         (free_content_elements): Remove DATA_ITEM_WIN case.
1593
1594 2019-06-25  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1597         Remove.
1598
1599 2019-06-25  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-data.h (struct tui_command_element): Remove.
1602         (union tui_which_element) <command>: Remove.
1603         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1604         assert.
1605         (free_content_elements): Remove CMD_WIN case.
1606
1607 2019-06-25  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-layout.c (tui_set_layout): Update.
1610         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1611         * tui/tui-data.c (layout_def): Update.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1616         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1617         (tui_source_window_base::set_new_height): Update.
1618         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1619         Update.
1620         (tui_set_locator_fullname, tui_set_locator_info)
1621         (tui_show_frame_info): Update.
1622         * tui/tui-source.c (tui_set_source_content)
1623         (tui_source_is_displayed): Update.
1624         * tui/tui-layout.c (show_source_disasm_command, show_data)
1625         (show_source_or_disasm_and_command): Update.
1626         * tui/tui-disasm.c (tui_set_disassem_content)
1627         (tui_get_begin_asm_address): Update.
1628         * tui/tui-data.h (struct tui_locator_element): Remove.
1629         (union tui_which_element) <locator>: Remove.
1630         (struct tui_locator_window): New.
1631         (tui_locator_win_info_ptr): Change return type.
1632         * tui/tui-data.c (_locator): Change type.
1633         (tui_locator_win_info_ptr): Change return type.
1634         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1635         (tui_alloc_content): Add assert.
1636
1637 2019-06-25  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-winsource.c
1640         (tui_exec_info_window::maybe_allocate_content): New method.
1641         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1642         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1643         (make_source_or_disasm_window): Add cast.
1644         * tui/tui-data.h (union tui_which_element) <simple_string>:
1645         Remove.
1646         (struct tui_source_info): New.
1647         (struct tui_source_window_base) <execution_info>: Change type.
1648         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1649         case, and add assert.
1650         (tui_alloc_content): Add assert.
1651
1652 2019-06-25  Tom Tromey  <tom@tromey.com>
1653
1654         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1655         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1656         * tui/tui-data.c (tui_alloc_win_info): Remove.
1657
1658 2019-06-25  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1661         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1662         can_highlight.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1667         make_visible_with_new_height method.
1668         (tui_win_info::make_visible_with_new_height): New method.
1669         (tui_source_window_base::do_make_visible_with_new_height)
1670         (tui_data_window::do_make_visible_with_new_height)
1671         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1672         (make_visible_with_new_height): Remove.
1673         (tui_resize_all, tui_adjust_win_heights): Use
1674         make_visible_with_new_height method.
1675         * tui/tui-data.h (struct tui_win_info)
1676         <do_make_visible_with_new_height, make_visible_with_new_height>:
1677         New methods.
1678         (struct tui_source_window_base, struct tui_data_window)
1679         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1680         methods.
1681
1682 2019-06-25  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1685         method.
1686         (update_tab_width): Call update_tab_width method.
1687         * tui/tui-data.h (struct tui_win_info)
1688         (struct tui_source_window_base) <update_tab_width>: New methods.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1693         parameter.
1694         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1695         parameter.
1696         (tui_gen_win_info::make_visible): Update.
1697         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1698         parameter.
1699         * tui/tui-data.h (enum tui_box): New enum.
1700         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1701
1702 2019-06-25  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1705         init_and_make_win for EXEC_INFO_WIN.
1706         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1707         longer inline.
1708         (struct tui_win_info) <~tui_win_info>: Inline.
1709         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1710         Don't declare.
1711         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1712         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1713         Remove.
1714         (tui_initialize_static_data): Update.
1715         (~tui_gen_win_info): Handle more cleanup here.
1716         (~tui_source_window_base): Delete "execution_info".
1717         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1718
1719 2019-06-25  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-layout.c (make_command_window): Don't set
1722         can_highlight.
1723         (show_source_disasm_command): Call the reset method.
1724         (show_data): Don't set can_highlight.  Call the reset method.
1725         (tui_gen_win_info::reset): Rename from init_gen_win_info
1726         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1727         (show_source_or_disasm_and_command): Call the reset method.
1728         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1729         (struct tui_cmd_window): Set can_highlight.
1730
1731 2019-06-25  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1734         from make_visible.
1735         (tui_make_visible, tui_make_invisible): Rewrite.
1736         (tui_win_info::make_visible): Remove.
1737         (tui_source_window_base::make_visible): Update.
1738         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1739         method.  Moved from...
1740         (struct tui_win_info) <make_visible>: ...here.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-winsource.c
1745         (tui_source_window_base::do_scroll_horizontal): Remove direction
1746         parameter.
1747         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1748         direction parameter.
1749         * tui/tui-win.c (tui_win_info::forward_scroll)
1750         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1751         (tui_win_info::right_scroll): Update.
1752         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1753         direction parameter.
1754         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1755         direction parameter.
1756         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1757         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1758         Remove direction parameter.
1759         (struct tui_source_window_base, struct tui_source_window)
1760         (struct tui_disasm_window, struct tui_data_window)
1761         (struct tui_cmd_window): Update.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-winsource.h (tui_set_exec_info_content)
1766         (tui_show_exec_info_content, tui_erase_exec_info_content)
1767         (tui_clear_exec_info_content, tui_update_exec_info): Change
1768         argument to tui_source_window_base.
1769         * tui/tui-winsource.c (tui_set_exec_info_content)
1770         (tui_show_exec_info_content, tui_erase_exec_info_content)
1771         (tui_clear_exec_info_content, tui_update_exec_info): Change
1772         argument to tui_source_window_base.
1773
1774 2019-06-25  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1777         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1782         check.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1787         type to void.
1788         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1789         type to void.
1790         * tui/tui-source.c (tui_set_source_content): Update.
1791         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1792
1793 2019-06-25  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-win.c (window_name_completer, tui_set_focus)
1796         (tui_all_windows_info): Use name method.
1797         * tui/tui-data.h (struct tui_gen_win_info)
1798         (struct tui_source_window, struct tui_disasm_window)
1799         (struct tui_data_window, struct tui_cmd_window) <name>: New
1800         method.
1801         (tui_win_name): Don't declare.
1802         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1803         (tui_win_name): Remove.
1804
1805 2019-06-25  Tom Tromey  <tom@tromey.com>
1806
1807         * tui/tui-winsource.h (tui_update_source_window)
1808         (tui_update_source_window_as_is): Change parameter type.
1809         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1810         to be a tui_source_window_base.
1811         (tui_update_source_window_as_is): Likewise.
1812         * tui/tui-win.c (make_visible_with_new_height): Update.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-winsource.c (tui_erase_source_content)
1817         (tui_show_source_content, tui_show_exec_info_content)
1818         (tui_erase_exec_info_content): Use refresh_window method.
1819         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1820         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1821         from tui_refresh_win.
1822         (tui_data_window::refresh_window): New method.
1823         (tui_win_info::refresh, tui_source_window_base::refresh)
1824         (tui_refresh_all): Use refresh_window method.
1825         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1826         method.
1827         * tui/tui-regs.c (tui_display_register): Call refresh_window
1828         method.
1829         * tui/tui-layout.c (show_source_disasm_command)
1830         (show_source_or_disasm_and_command): Call refresh_window method.
1831         * tui/tui-data.h (struct tui_gen_win_info)
1832         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1833         New method.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui.c (tui_rl_other_window, tui_enable)
1838         (tui_is_window_visible, tui_get_command_dimension): Update.
1839         * tui/tui-winsource.c (tui_update_source_window_as_is)
1840         (tui_clear_source_content, tui_erase_source_content)
1841         (tui_show_source_line, tui_source_window_base::refill)
1842         (tui_source_window_base::do_scroll_horizontal)
1843         (tui_source_window_base::set_is_exec_point_at)
1844         (tui_update_breakpoint_info, tui_set_exec_info_content)
1845         (tui_alloc_source_buffer, tui_line_is_displayed)
1846         (tui_addr_is_displayed): Update.
1847         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1848         (tui_check_and_display_highlight_if_needed)
1849         (tui_win_info::make_visible, tui_win_info::refresh)
1850         (tui_refresh_all): Update.
1851         * tui/tui-windata.c (tui_first_data_item_displayed)
1852         (tui_delete_data_content_windows, tui_erase_data_content)
1853         (tui_display_all_data, tui_data_window::refresh_all)
1854         (tui_check_data_values): Update.
1855         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1856         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1857         (tui_win_info::backward_scroll, tui_refresh_all_win)
1858         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1859         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1860         (tui_source_window_base::set_new_height)
1861         (tui_data_window::set_new_height)
1862         (make_invisible_and_set_new_height)
1863         (make_visible_with_new_height, new_height_ok)
1864         (parse_scrolling_args): Update.
1865         * tui/tui-stack.c (tui_show_frame_info): Update.
1866         * tui/tui-source.c (tui_set_source_content)
1867         (tui_set_source_content_nil, tui_source_is_displayed)
1868         (tui_source_window::do_scroll_vertical): Update.
1869         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1870         (tui_display_registers_from, tui_display_reg_element_at_line)
1871         (tui_check_register_values, tui_reg_command): Update.
1872         * tui/tui-layout.c (tui_default_win_height)
1873         (show_source_disasm_command, show_data, init_and_make_win)
1874         (show_source_or_disasm_and_command): Update.
1875         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1876         (tui_redisplay_readline, tui_mld_flush)
1877         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1878         (tui_getc): Update.
1879         * tui/tui-disasm.c (tui_set_disassem_content)
1880         (tui_disasm_window::do_scroll_vertical): Update.
1881         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1882         Now virtual.
1883         (struct tui_win_info): Derive from tui_gen_win_info.
1884         <~tui_win_info>: Mark as override.
1885         <generic>: Remove member.
1886         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1887         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1888         (~tui_data_window, ~tui_win_info)
1889         (tui_free_all_source_wins_content): Update.
1890         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-layout.c (init_and_make_win): Use new.
1895         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1896         destructor, initializers.
1897         (tui_alloc_generic_win_info): Don't declare.
1898         * tui/tui-data.c (_locator): Add argument to constructor.
1899         (source_win, disasm_win): New globals.
1900         (exec_info): Remove.
1901         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1902         Update.
1903         (tui_alloc_generic_win_info): Remove.
1904         (init_content_element): Use new.
1905         (tui_win_info::tui_win_info): Update.
1906         (free_content_elements) <case DATA_WIN>: Use delete.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1911         * tui/tui-windata.c (tui_first_data_item_displayed)
1912         (tui_delete_data_content_windows): Update.
1913         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1914         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1915         (tui_display_registers_from, tui_check_register_values): Update.
1916         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1917         pointer.
1918         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1919         window.
1920         (tui_free_data_content): Update.
1921         (free_content_elements) <case DATA_WIN>: Free the window.
1922
1923 2019-06-25  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1926         Update.
1927         * tui/tui-layout.c (make_command_window)
1928         (show_source_disasm_command, show_data, init_and_make_win)
1929         (show_source_or_disasm_and_command): Update.
1930         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1931         method.
1932         <can_highight, is_highlighted>: Now bool.
1933         (tui_set_win_highlight): Don't declare.
1934         * tui/tui-data.c (tui_set_win_highlight): Remove.
1935
1936 2019-06-25  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-wingeneral.c (make_visible): Remove check of window
1939         type.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-win.c (tui_win_info::max_height)
1944         (tui_cmd_window::max_height): New methods.
1945         (new_height_ok): Call max_height.
1946         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1947         <max_height>: New method.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-win.c (tui_source_window_base::set_new_height)
1952         (tui_data_window::set_new_height): New methods.
1953         (make_invisible_and_set_new_height): Call set_new_height method.
1954         * tui/tui-data.h (struct tui_win_info)
1955         (struct tui_source_window_base, struct tui_data_window)
1956         <set_new_height>: New method.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1961         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1962         tui_refresh_data_win.
1963         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1964         method.
1965         (tui_refresh_all_win): Call the refresh_all method.
1966         (tui_set_focus): Likewise.
1967         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1968         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1969         Likewise.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-winsource.h (tui_refill_source_window)
1974         (tui_set_is_exec_point_at): Don't declare.
1975         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1976         (tui_source_window_base::refill): Rename from
1977         tui_refill_source_window.
1978         (tui_source_window_base::do_scroll_horizontal): Update.
1979         (tui_source_window_base::set_is_exec_point_at): Rename from
1980         tui_set_is_exec_point_at.
1981         (tui_update_all_breakpoint_info): Update.
1982         * tui/tui-stack.c (tui_show_frame_info): Update.
1983         * tui/tui-layout.c (show_data): Add cast.
1984         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1985         * tui/tui-data.h (struct tui_source_window_base) <refill,
1986         set_is_exec_point_at>: New methods.
1987         (tui_source_windows, tui_add_to_source_windows): Update types.
1988         (tui_add_to_source_windows): Remove redundant declaration.
1989         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1990         (tui_source_windows): Change return type.
1991         (tui_clear_source_windows_detail): Update.
1992         (tui_add_to_source_windows): Change type of parameter.
1993         (tui_free_all_source_wins_content): Update.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-wingeneral.c (tui_win_info::refresh)
1998         (tui_source_window_base::refresh): New methods.
1999         (tui_refresh_all): Call the refresh method.
2000         * tui/tui-data.h (struct tui_win_info)
2001         (struct tui_source_window_base) <refresh>: New method.
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui.h (tui_is_window_visible): Return bool.
2006         * tui/tui.c (tui_is_window_visible): Return bool.
2007         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2008         (tui_make_visible, tui_make_invisible)
2009         (tui_win_info::make_visible)
2010         (tui_source_window_base::make_visible, make_all_visible)
2011         (tui_make_all_visible, tui_make_all_invisible): Update.
2012         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2013         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2014         bool.
2015         (struct tui_win_info, struct tui_source_window_base)
2016         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2017         * tui/tui-data.c (tui_init_generic_part): Update.
2018
2019 2019-06-25  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2022         (tui_source_window_base::make_visible): New methods.
2023         (make_all_visible): Make method call.
2024         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2025         (struct tui_source_window_base, struct tui_cmd_window): Override
2026         make_visible.
2027         (tui_win_is_source_type): Don't declare.
2028         * tui/tui-data.c (tui_win_is_source_type): Remove.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2033         NULL check.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2038         Inline constructor.  Add initializers for members.
2039         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2040         constructors; now inline in class.
2041
2042 2019-06-25  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-regs.c (tui_show_registers): Update.
2045         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2046         bool.
2047         * tui/tui-data.c (tui_data_window::clear_detail)
2048         (tui_data_window): Update.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-windata.c (tui_display_all_data)
2053         (tui_display_data_from_line, tui_display_data_from)
2054         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2055         Update.
2056         * tui/tui-regs.c (tui_last_regs_line_no)
2057         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2058         (tui_show_registers, tui_show_register_group)
2059         (tui_display_registers_from, tui_display_reg_element_at_line)
2060         (tui_display_registers_from_line, tui_check_register_values)
2061         (tui_reg_next, tui_reg_prev): Update.
2062         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2063         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2064         tui_data_window.
2065         (struct tui_win_info) <detail>: Remove.  Add new fields from
2066         tui_data_info.
2067         (TUI_DATA_WIN): Add cast.
2068         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2069         (~tui_data_window): Simplify.
2070
2071 2019-06-25  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-layout.c (show_source_disasm_command)
2074         (show_source_or_disasm_and_command): Update.
2075         * tui/tui-io.c (update_cmdwin_start_line)
2076         (tui_redisplay_readline): Update.
2077         * tui/tui-data.h (struct tui_command_info): Remove.
2078         (struct tui_win_info) <detail>: Remove command_info member.
2079         (struct tui_data_window) <start_line>: New member, from
2080         tui_command_info.
2081         (TUI_CMD_WIN): Add casts.
2082
2083 2019-06-25  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-winsource.c (tui_update_source_window)
2086         (tui_refill_source_window)
2087         (tui_source_window_base::do_scroll_horizontal)
2088         (tui_update_breakpoint_info, tui_set_exec_info_content)
2089         (tui_show_exec_info_content, tui_erase_exec_info_content)
2090         (tui_clear_exec_info_content): Update.
2091         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2092         Update.
2093         * tui/tui-win.c (make_invisible_and_set_new_height)
2094         (make_visible_with_new_height): Update.
2095         * tui/tui-source.c (tui_set_source_content)
2096         (tui_show_symtab_source): Update.
2097         * tui/tui-layout.c (extract_display_start_addr)
2098         (show_source_disasm_command, show_data)
2099         (make_source_or_disasm_window)
2100         (show_source_or_disasm_and_command): Update.
2101         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2102         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2103         "gdbarch".
2104         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2105         to tui_source_window_base.
2106         (struct tui_win_info) <detail>: Remove source_info member.
2107         (struct tui_source_window_base) <has_locator>: Inline.
2108         Move contents from tui_source_info; rename has_locator member to
2109         m_has_locator.
2110         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2111         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2112         header file.
2113         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2114         Simplify.
2115         (tui_free_all_source_wins_content): Cast to
2116         tui_source_window_base.
2117
2118 2019-06-25  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-win.c (make_invisible_and_set_new_height)
2121         (make_visible_with_new_height): Call has_locator method.
2122         * tui/tui-layout.c (show_source_disasm_command, show_data)
2123         (show_source_or_disasm_and_command): Update for bool change.
2124         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2125         (tui_win_info) <has_locator>: New method.
2126         (struct tui_source_window_base) <has_locator>: New method.
2127         (tui_win_has_locator): Don't declare.
2128         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2129         from tui_win_has_locator.
2130         (tui_source_window_base): Use false, not FALSE.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2135         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2136         clear_detail method directly.
2137         (tui_clear_win_detail): Remove.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2142         "this", not TUI_DISASM_WIN.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2147         declare.
2148         * tui/tui-winsource.c
2149         (tui_source_window_base::do_scroll_horizontal): Rename from
2150         tui_horizontal_source_scroll.
2151         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2152         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2153         from tui_vertical_data_scroll.
2154         * tui/tui-win.h (tui_scroll): Don't declare.
2155         * tui/tui-win.c (tui_win_info::forward_scroll)
2156         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2157         (tui_win_info::right_scroll): Rename and update.
2158         (tui_scroll_forward_command, tui_scroll_backward_command)
2159         (tui_scroll_left_command, tui_scroll_right_command): Update.
2160         (tui_scroll): Remove.
2161         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2162         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2163         from tui_vertical_source_scroll.
2164         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2165         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2166         from tui_vertical_disassem_scroll.
2167         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2168         do_scroll_horizontal>: New methods.
2169         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2170         Likewise.
2171         (struct tui_source_window_base): Add do_scroll_horizontal.
2172         (struct tui_source_window, struct tui_disasm_window): Add
2173         do_scroll_vertical.
2174         (struct tui_data_window, struct tui_cmd_window): Add
2175         do_scroll_horizontal and do_scroll_vertical.
2176         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2177
2178 2019-06-25  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-data.h (struct tui_source_window_base): New struct.
2181         (struct tui_source_window): Derive from tui_source_window_base.
2182         (struct tui_disasm_window): New struct.
2183         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2184         from tui_source_window::clear_detail.
2185         (tui_source_window_base): Rename from tui_source_window.
2186         (~tui_source_window_base): Rename from ~tui_source_window.
2187         (tui_alloc_win_info): Create a tui_disasm_window.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-data.h (struct tui_source_window)
2192         (struct tui_data_window): Declare destructors.
2193         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2194         destructors.
2195         (tui_win_info): Simplify.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-winsource.c (tui_display_main)
2200         (tui_update_source_windows_with_addr)
2201         (tui_update_all_breakpoint_info): Update.
2202         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2203         (new_height_ok, parse_scrolling_args): Update.
2204         * tui/tui-stack.c (tui_show_frame_info): Update.
2205         * tui/tui-data.h (struct tui_list): Remove.
2206         (tui_source_windows): Return a reference to a std::vector.
2207         * tui/tui-data.c (source_windows): Now a std::vector.
2208         (tui_source_windows): Change return type.
2209         (tui_clear_source_windows): Rewrite.
2210         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2211         (tui_free_all_source_wins_content): Rewrite.
2212
2213 2019-06-25  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2216         (struct tui_data_window, struct tui_cmd_window): Declare
2217         clear_detail method.
2218         * tui/tui-data.c (tui_source_window::clear_detail)
2219         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2220         methods.
2221         (tui_clear_win_detail): Simplify.
2222
2223 2019-06-25  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-layout.c (make_source_window, make_disasm_window)
2226         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2227         Return the new window.
2228         (show_source_disasm_command, show_data)
2229         (show_source_or_disasm_and_command): Update.
2230
2231 2019-06-25  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2234         parameter.  Return the new window.
2235         (show_source_disasm_command): Update and remove NULL check.
2236         (show_source_or_disasm_and_command): Update.
2237
2238 2019-06-25  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-data.h (struct tui_win_info): Make constructor
2245         protected.  Make destructor virtual.  Add initializers.
2246         (tui_source_window, tui_data_window, tui_cmd_window): New
2247         classes.
2248         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2249         constructor.  Add "type" parameter.
2250         (tui_source_window, tui_data_window, tui_cmd_window): New
2251         constructors.
2252         (tui_alloc_win_info): Instantiate the appropriate subclass.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-win.c (tui_resize_all): Use delete.
2257         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2258         destructor.
2259         (tui_free_window): Don't declare.
2260         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2261         Update.
2262
2263 2019-06-25  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-data.h (struct tui_win_info): Add constructor.
2266         * tui/tui-data.c (tui_alloc_win_info): Use new.
2267         (tui_free_window): Use delete.
2268
2269 2019-06-22  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2272         declare.
2273         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2274
2275 2019-06-22  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2278         declare.
2279         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2280
2281 2019-06-22  Tom de Vries  <tdevries@suse.de>
2282
2283         * dwarf2read.c (create_addrmap_from_aranges)
2284         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2285         instead of '%zu'.
2286
2287 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2288
2289         * dwarf2read.h (dwarf2_section_info_def): Remove.
2290         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2291         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2292         std::vector<dwarf2_section_info>.
2293         (struct dwo_file) <~dwo_file>: Remove.
2294         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2295         types field.
2296         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2297         (dwarf2_read_debug_names): Likewise.
2298         (create_debug_types_hash_table): Change parameter type to
2299         array_view, adjust code accordingly.
2300         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2301         (partial_die_info::fixup): Likewise.
2302         (determine_prefix): Likewise.
2303         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2304
2305 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2306
2307         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2308         gdb_bfd_ref_ptr.
2309         <~dwo_file>: Remove call to gdb_bfd_unref.
2310         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2311         gdb_bfd_ref_ptr::get.
2312
2313 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2314
2315         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2316         type to htab_up.
2317         * dwarf2read.c (struct dwo_file): Initialize fields.
2318         <~dwo_file>: New.
2319         (free_dwo_file): Remove, move content to ~dwo_file.
2320         (struct dwo_file_deleter): Remove.
2321         (dwo_file_up>: Remove custom deleter.
2322         (free_dwo_files): Remove.
2323         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2324         dwo_files.
2325         (process_skeletonless_type_units): Call unique_ptr::get.
2326         (allocate_dwo_file_hash_table): Add deleter to created hash
2327         table.  Change return type to htab_up.
2328         (lookup_dwo_file_slot): Don't memset dwo_file, call
2329         unique_ptr::get.
2330         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2331         (create_dwo_unit_in_dwp_v2): Likewise.
2332         (open_and_init_dwo_file): Likewise.
2333         (free_dwo_file_from_slot): Remove.
2334
2335 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2336
2337         * dwarf2read.h (struct dwarf2_section_info) <readin,
2338         is_virtual>: Change type to bool.
2339         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2340         true instead of 1.
2341
2342 2019-06-19  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-data.h (tui_init_content_element): Don't declare.
2345
2346 2019-06-19  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-data.h (tui_init_win_info): Don't declare.
2349
2350 2019-06-19  Tom de Vries  <tdevries@suse.de>
2351
2352         * dwarf2read.h (abstract_to_concrete): Change type to
2353         std::unordered_map<sect_offset, std::vector<sect_offset>,
2354         gdb::hash_enum<sect_offset>>.
2355
2356 2019-06-19  Tom Tromey  <tromey@adacore.com>
2357
2358         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2359         EVAL_AVOID_SIDE_EFFECTS specially.
2360
2361 2019-06-19  Tom Tromey  <tromey@adacore.com>
2362
2363         * source-cache.c (highlighter): New global.
2364         (source_cache::get_source_lines): Create a highlighter on demand.
2365
2366 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * defs.h (deprecated_interactive_hook): Delete declaration.
2369         * interps.c (clear_interpreter_hooks): Remove use of
2370         deprecated_interactive_hook.
2371         * top.c (deprecated_interactive_hook): Delete definition.
2372         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2373
2374 2019-06-18  Tom de Vries  <tdevries@suse.de>
2375
2376         PR gdb/24515
2377         * dwarf2read.h (abstract_to_concrete): Change type from
2378         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2379         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2380         * dwarf2read.c (read_variable): Update.
2381         (dwarf2_fetch_die_loc_sect_off): Update.
2382
2383 2019-06-17  Tom de Vries  <tdevries@suse.de>
2384
2385         PR gdb/24617
2386         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2387         accessing parent[parent_len - 1].
2388
2389 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2390
2391         PR gdb/24364
2392         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2393         call dtrace_process_dof with NULL dof.
2394
2395 2019-06-16  Tom de Vries  <tdevries@suse.de>
2396
2397         PR gdb/24445
2398         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2399
2400 2019-06-16  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2403         (make_all_visible): Use address of member.
2404
2405 2019-06-16  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2408         (tui_free_window, free_content, free_content_elements): Remove
2409         unnecessary cast.
2410         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2411         cast.
2412         * tui/tui-regs.c (tui_show_register_group)
2413         (tui_display_registers_from, tui_display_reg_element_at_line):
2414         Remove unnecessary cast.
2415
2416 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * linux-nat.c (normal_mask): Delete.
2419         (_initialize_linux_nat): Don't initialise normal_mask.
2420
2421 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2422
2423         PR gdb/24445
2424         * dwarf-index-write.h (write_psymtabs_to_index): Add
2425         dwz_basename parameter.
2426         * dwarf-index-write.c (write_gdbindex): Move file writing to
2427         write_gdbindex_1.  Change return type void.
2428         (assert_file_size): Move up, remove filename parameter.
2429         (write_gdbindex_1): New function.
2430         (write_debug_names): Change return type to void, call
2431         assert_file_size.
2432         (struct index_wip_file): New struct.
2433         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2434         file logic to index_wip_file.  Write index for dwz file if
2435         needed.
2436         (save_gdb_index_command): Pass basename of dwz file, if present.
2437         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2438         build-id of dwz file, if present.
2439         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2440         (dwarf2_get_dwz_file): Likewise.
2441         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2442         (dwarf2_get_dwz_file): Likewise.
2443
2444 2019-06-16  Tom Tromey  <tom@tromey.com>
2445
2446         * coffread.c (process_coff_symbol): Use xstrdup.
2447         * value.c (create_internalvar): Use xstrdup.
2448
2449 2019-06-16  Tom Tromey  <tom@tromey.com>
2450
2451         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2452         * breakpoint.c (stopin_command, stopat_command)
2453         (until_break_command, decode_location_default): Remove unnecessary
2454         cast.
2455         * utils.c (subset_compare): Remove unnecessary cast.
2456         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2457         cast.
2458         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2459         cast.
2460         * infcmd.c (path_command): Remove unnecessary cast.
2461         * coffread.c (decode_type): Remove unnecessary cast.
2462         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2463         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2464         * tui/tui-stack.c (tui_show_locator_content)
2465         (tui_show_frame_info): Remove unnecessary cast.
2466         * tui/tui-win.c (tui_scroll_forward_command)
2467         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2468         (parse_scrolling_args): Remove unnecessary cast.
2469         * tui/tui-data.c (init_win_info, tui_del_window)
2470         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2471         (free_content_elements): Remove unnecessary cast.
2472         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2473         unnecessary cast.
2474         * tui/tui-source.c (tui_set_source_content)
2475         (tui_vertical_source_scroll): Remove unnecessary cast.
2476         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2477         cast.
2478         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2479         * tui/tui-regs.c (tui_display_registers_from)
2480         (tui_display_register): Remove unnecessary cast.
2481         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2482         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2483         (make_visible): Remove unnecessary cast.
2484         * tui/tui-winsource.c (tui_erase_source_content)
2485         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2486         unnecessary cast.
2487         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2488         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2489         * stabsread.c (read_type, read_array_type, read_range_type):
2490         Remove unnecessary cast.
2491         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2492         (parse_symbol, parse_type, upgrade_type, parse_external)
2493         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2494         unnecessary cast.
2495         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2496
2497 2019-06-16  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-data.c (tui_alloc_generic_win_info)
2500         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2501         checks.
2502
2503 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2504             Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * f-typeprint.c (f_print_type): Don't return early for not
2507         associated or not allocated types.
2508         (f_type_print_varspec_suffix): Add print_rank parameter and print
2509         ranks of array types in case they dangling.
2510         (f_type_print_base): Add print_rank parameter.
2511
2512 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * NEWS: Mention new MI commands.
2515         * break-catch-throw.c (enum exception_event_kind): Move to
2516         breakpoint.h.
2517         (print_mention_exception_catchpoint): Output text as a single
2518         message.
2519         (catch_exception_command_1): Rename to...
2520         (catch_exception_event): ...this, make non-static, update header
2521         command, and change some parameter types.
2522         (catch_catch_command): Update for changes to
2523         catch_exception_command_1.
2524         (catch_throw_command): Likewise.
2525         (catch_rethrow_command): Likewise.
2526         * breakpoint.c (enum exception_event_kind): Delete.
2527         * breakpoint.h (enum exception_event_kind): Moved here from
2528         break-catch-throw.c.
2529         (catch_exception_event): Declare.
2530         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2531         (mi_cmd_catch_throw): New function.
2532         (mi_cmd_catch_rethrow): New function.
2533         (mi_cmd_catch_catch): New function.
2534         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2535         'catch-catch' entries.
2536         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2537         (mi_cmd_catch_rethrow): Declare.
2538         (mi_cmd_catch_catch): Declare.
2539
2540 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2541
2542         * annotate.c (annotate_source_line): Change return type to void,
2543         update implementation to match.
2544         * annotate.h (annotate_source_line): Change return type to void,
2545         update header comment.
2546         * stack.c (print_frame_info): Don't change what frame information
2547         is printed based on whether annotations are on or not.
2548
2549 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2552         (annotate_source): Make static.
2553         (annotate_source_line): Moved from source.c and renamed from
2554         identify_source_line.  Update the return type.
2555         * annotate.h (annotate_source): Delete declaration.
2556         (annotate_source_line): Declaration moved from source.h, and
2557         renamed from identify_source_line.  Return type updated.
2558         * source.c (identify_source_line): Moved to annotate.c and renamed
2559         to annotate_source_line.
2560         (info_line_command): Remove check of annotation_level.
2561         * source.h (identify_source_line): Move declaration to annotate.h
2562         and rename to annotate_source_line.
2563         * stack.c: Add 'annotate.h' include.
2564         (print_frame_info): Remove check of annotation_level before
2565         calling annotate_source_line.
2566
2567 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * source-cache.c (source_cache::get_plain_source_lines): Use
2570         open_source_file_with_line_charpos instead of just
2571         open_source_file, remove call to find_source_lines.
2572         (source_cache::get_source_lines): Likewise.
2573         * source.c (find_source_lines): Make static.
2574         (get_filename_and_charpos): Renamed into...
2575         (open_source_file_with_line_charpos): ..this along with changes to
2576         return a scoped_fd, and some other minor clean ups.
2577         (identify_source_line): Use open_source_file_with_line_charpos.
2578         (search_command_helper): Use open_source_file_with_line_charpos
2579         instead of just open_source_file, remove call to
2580         find_source_lines.
2581         * source.h (open_source_file_with_line_charpos): Declare new
2582         function.
2583         (find_source_lines): Delete declaration.
2584
2585 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * source.c (get_filename_and_charpos): Remove fullname
2588         parameter.
2589         (identify_source_line): Update call to get_filename_and_charpos.
2590
2591 2019-06-14  Tom Tromey  <tromey@adacore.com>
2592
2593         PR gdb/24502:
2594         * ui-style.h (skip_ansi_escape): Update comment.
2595         * ui-file.h (class no_terminal_escape_file): New class.
2596         * ui-file.c (no_terminal_escape_file::write)
2597         (no_terminal_escape_file::puts): New methods.
2598         * cli/cli-logging.c (handle_redirections): Use
2599         no_terminal_escape_file.
2600
2601 2019-06-14  Tom Tromey  <tromey@adacore.com>
2602
2603         * NEWS: Move convenience variable news above Python news.
2604
2605 2019-06-14  Tom Tromey  <tom@tromey.com>
2606
2607         * gnulib: Move directory to top-level.
2608         * configure.ac: Don't configure gnulib.
2609         * configure: Rebuild.
2610         * common/common-defs.h: Use new path to gnulib.
2611         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2612         (GNULIB_H): Remove.
2613         (INCGNU): Look in new gnulib location.
2614         (HFILES_NO_SRCDIR): Remove gnulib files.
2615         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2616         (generated_files): Remove GNULIB_H.
2617         ($(LIBGNU), all-lib): Remove targets.
2618         (distclean): Don't mention GNULIB_BUILDDIR.
2619         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2620
2621 2019-06-14  Tom Tromey  <tromey@adacore.com>
2622
2623         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2624         Warn if symbol file does not provide any symbols.
2625
2626 2019-06-14  Tom Tromey  <tromey@adacore.com>
2627
2628         * source.c (find_and_open_source): Respect basenames_may_differ.
2629
2630 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2631
2632         * annotate.c (annotate_breakpoints_invalid): Make use of
2633         scoped_restore_terminal_state.
2634         (annotate_frames_invalid): Likewise.
2635
2636 2019-06-14  Tom Tromey  <tromey@adacore.com>
2637
2638         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2639         allow assignment to an internalvar.
2640
2641 2019-06-14  Tom Tromey  <tromey@adacore.com>
2642
2643         * ada-lex.l: Allow "_" in attribute names.
2644
2645 2019-06-14  Tom Tromey  <tromey@adacore.com>
2646
2647         PR gdb/24653:
2648         * regcache.c (registers_changed): Don't call alloca.
2649         * top.c (execute_command): Don't call alloca.
2650
2651 2019-06-13  Pedro Alves  <palves@redhat.com>
2652
2653         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2654         'expression'.  When parsing an expression, error out if there's
2655         junk after "unlimited".
2656         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2657         (do_set_command): Adjust calls to is_unlimited_literal.
2658
2659 2019-06-13  Pedro Alves  <palves@redhat.com>
2660
2661         * compile/compile.c (make_compile_options_def_group): Add braces
2662         around array_view initializer.
2663         * thread.c (make_thread_apply_all_options_def_group)
2664         (make_thread_apply_all_options_def_group): Likewise.
2665
2666 2019-06-13  Pedro Alves  <palves@redhat.com>
2667
2668         * NEWS (New commands): Mention "maint test-options
2669         require-delimiter", "maint test-options unknown-is-error", "maint
2670         test-options unknown-is-operand" and "maint show
2671         test-options-completion-result".
2672         (New command options, command completion): New section.
2673         (Completion improvements): New section.
2674         Mention that you can abbreviate "unlimited".
2675
2676 2019-06-13  Pedro Alves  <palves@redhat.com>
2677
2678         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2679         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2680         * unittests/cli-utils-selftests.c (test_parse_flags)
2681         (test_parse_flags_qcs): Delete.
2682         (test_cli_utils): Don't call deleted functions.
2683
2684 2019-06-13  Pedro Alves  <palves@redhat.com>
2685
2686         * thread.c: Include "cli/cli-option.h".
2687         (tp_array_compar_ascending): Global.
2688         (tp_array_compar): Delete function.
2689         (tp_array_compar_ascending, tp_array_compar_descending): New
2690         functions.
2691         (ascending_option_def, qcs_flag_option_def)
2692         (thr_qcs_flags_option_defs)
2693         (make_thread_apply_all_options_def_group)
2694         (make_thread_apply_options_def_group): New.
2695         (thread_apply_all_command): Use gdb::option::process_options.
2696         (thread_apply_command_completer)
2697         (thread_apply_all_command_completer): New.
2698         (thread_apply_command): Use gdb::option::process_options.
2699         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2700         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2701         to generate help text of "thread apply".  Adjust "taas"'s help.
2702         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2703         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2704
2705 2019-06-13  Pedro Alves  <palves@redhat.com>
2706
2707         * thread.c (thread_apply_command): Check for invalid TID with
2708         isdigit instead of !isalpha.
2709
2710 2019-06-13  Pedro Alves  <palves@redhat.com>
2711
2712         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2713         (validate_flags_qcs): New.
2714         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2715         (validate_flags_qcs): Declare.
2716         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2717         (make_frame_apply_options_def_group): New.
2718         (frame_apply_command_count): Process options with
2719         gdb::option::process_options.
2720         (frame_apply_completer): New.
2721         (frame_apply_level_completer, frame_apply_all_completer)
2722         (frame_apply_completer): New.
2723         (_initialize_stack): Update help of "frame apply", "frame apply
2724         level", "frame apply all" and "faas" to mention supported options
2725         and install command completers.
2726         * stack.h (frame_apply_all_completer): Declare.
2727         * thread.c: Include "stack.h".
2728         (tfaas_command): Add "--".
2729         (_initialize_thread): Update help "tfaas" to mention supported
2730         options and install command completer.
2731
2732 2019-06-13  Pedro Alves  <palves@redhat.com>
2733
2734         * completer.c (complete_nested_command_line): New.
2735         (gdb_completion_word_break_characters_throw): Add assertion.
2736         * completer.h (complete_nested_command_line): Declare.
2737
2738 2019-06-13  Pedro Alves  <palves@redhat.com>
2739
2740         * stack.c (parse_backtrace_qualifiers): New.
2741         (backtrace_command): Use it.
2742         (backtrace_command_completer): Complete on qualifiers.
2743
2744 2019-06-13  Pedro Alves  <palves@redhat.com>
2745
2746         * frame.c: Include "cli/cli-option.h.
2747         (user_set_backtrace_options): New.
2748         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2749         Delete.
2750         (get_prev_frame): Adjust.
2751         (boolean_option_def, uinteger_option_def)
2752         (set_backtrace_option_defs): New.
2753         (_initialize_frame): Adjust and use
2754         gdb::option::add_setshow_cmds_for_options to install "set
2755         backtrace past-main" and "set backtrace past-entry".
2756         * frame.h: Include "cli/cli-option.h".
2757         (struct frame_print_options): Forward declare.
2758         (print_frame_arguments_all, print_frame_arguments_scalars)
2759         (print_frame_arguments_none): Declare.
2760         (print_entry_values): Delete declaration.
2761         (struct frame_print_options, user_frame_print_options): New.
2762         (struct set_backtrace_options): New.
2763         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2764         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2765         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2766         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2767         (list_args_or_locals): Add frame_print_options parameter.
2768         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2769         * python/py-framefilter.c (enumerate_args): Pass down
2770         USER_FRAME_PRINT_OPTIONS.
2771         * stack.c: Include "cli/cli-option.h".
2772         (print_frame_arguments_all, print_frame_arguments_scalars)
2773         (print_frame_arguments_none): Declare.
2774         (print_raw_frame_arguments, print_entry_values): Delete.
2775         (user_frame_print_options): New.
2776         (boolean_option_def, enum_option_def, frame_print_option_defs):
2777         New.
2778         (struct backtrace_cmd_options): New.
2779         (bt_flag_option_def): New.
2780         (backtrace_command_option_defs): New.
2781         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2782         (print_frame_arg, read_frame_arg, print_frame_args)
2783         (print_frame_info, print_frame): Add frame_print_options parameter
2784         and use it.
2785         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2786         (backtrace_command_1): Add frame_print_options and
2787         backtrace_cmd_options parameters and use them.
2788         (make_backtrace_options_def_group): New.
2789         (backtrace_command): Process command options with
2790         gdb::option::process_options.
2791         (backtrace_command_completer): New.
2792         (_initialize_stack): Extend "backtrace"'s help to mention
2793         supported options.  Install completer for "backtrace".
2794         Install some settings commands with add_setshow_cmds_for_options.
2795
2796 2019-06-13  Pedro Alves  <palves@redhat.com>
2797
2798         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2799         and that "set/show print raw frame-arguments" are now deprecated.
2800
2801         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2802         command.
2803         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2804         * stack.c (_initialize_stack): Install "set/show print
2805         raw-frame-arguments", and deprecate "set/show print raw
2806         frame-arguments".
2807         * valprint.c (_initialize_valprint): Deprecate "set/show print
2808         raw".
2809
2810 2019-06-13  Pedro Alves  <palves@redhat.com>
2811
2812         * compile/compile.c (struct compile_options): New.
2813         (compile_flag_option_def, compile_command_option_defs)
2814         (make_compile_options_def_group): New.
2815         (compile_file_command): Handle options with
2816         gdb::option::process_options.
2817         (compile_file_command_completer): New function.
2818         (compile_code_command): Handle options with
2819         gdb::option::process_options.
2820         (compile_code_command_completer): New function.
2821         (_initialize_compiler): Install completers for "compile code" and
2822         "compile file".  Mention available options in "compile code" and
2823         "compile code"'s help.
2824         * completer.c (advance_to_completion_word): New, factored out from
2825         ...
2826         (advance_to_expression_complete_word_point): ... this.
2827         (advance_to_filename_complete_word_point): New.
2828         * completer.h (advance_to_filename_complete_word_point): New
2829         declaration.
2830
2831 2019-06-13  Pedro Alves  <palves@redhat.com>
2832
2833         * compile/compile.c: Include "cli/cli-option.h".
2834         (compile_print_value): Scope data pointer is now a
2835         value_print_options pointer; adjust.
2836         (compile_print_command): Process options.  Scope data pointer is
2837         now a value_print_options pointer; adjust.
2838         (_initialize_compile): Update "compile print"'s help to include
2839         supported options.  Install a completer for "compile print".
2840         * cp-valprint.c (show_vtblprint, show_objectprint)
2841         (show_static_field_print): Delete.
2842         (_initialize_cp_valprint): Don't install "set print
2843         static-members", "set print vtbl", "set print object" here.
2844         * printcmd.c: Include "cli/cli-option.h" and
2845         "common/gdb_optional.h".
2846         (print_command_parse_format): Rework to fill in a
2847         value_print_options instead of a format_data.
2848         (print_value): Change parameter type from format_data pointer to
2849         value_print_options reference.  Adjust.
2850         (print_command_1): Process options.  Adjust to pass down a
2851         value_print_options.
2852         (print_command_completer): New.
2853         (_initialize_printcmd): Install print_command_completer as
2854         handle_brkchars completer for the "print" command.  Update
2855         "print"'s help to include supported options.
2856         * valprint.c: Include "cli/cli-option.h".
2857         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2858         here from cp-valprint.c.
2859         (boolean_option_def, uinteger_option_def)
2860         (value_print_option_defs, make_value_print_options_def_group):
2861         New.  Use gdb::option::add_setshow_cmds_for_options to install
2862         "set print elements", "set print null-stop", "set print repeats",
2863         "set print pretty", "set print union", "set print array", "set
2864         print address", "set print symbol", "set print array-indexes".
2865         * valprint.h: Include <string> and "cli/cli-option.h".
2866         (make_value_print_options_def_group): Declare.
2867         (print_value): Change parameter type from format_data pointer to
2868         value_print_options reference.
2869         (print_command_completer): Declare.
2870
2871 2019-06-13  Pedro Alves  <palves@redhat.com>
2872
2873         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2874         (COMMON_SFILES): Add maint-test-settings.c.
2875         * cli/cli-decode.c (boolean_enums): New global, factored out from
2876         ...
2877         (add_setshow_boolean_cmd): ... here.
2878         * cli/cli-decode.h (boolean_enums): Declare.
2879         * cli/cli-option.c: New file.
2880         * cli/cli-option.h: New file.
2881         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2882         factored out from ...
2883         (parse_cli_boolean_value(const char *)): ... this.
2884         (is_unlimited_literal): Change parameter type to pointer to
2885         pointer.  Adjust and advance ARG pointer.
2886         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2887         (parse_cli_var_enum): New, factored out from ...
2888         (do_set_command): ... this.  Adjust.
2889         * cli/cli-setshow.h (parse_cli_boolean_value)
2890         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2891         (parse_cli_var_enum): Declare.
2892         * cli/cli-utils.c: Include "cli/cli-option.h".
2893         (get_ulongest): New.
2894         * cli/cli-utils.h (get_ulongest): Declare.
2895         (check_for_argument): New overloads.
2896         * maint-test-options.c: New file.
2897
2898 2019-06-13  Pedro Alves  <palves@redhat.com>
2899
2900         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2901         parse a range if "-" is at the end of the string.
2902
2903 2019-06-13  Pedro Alves  <palves@redhat.com>
2904
2905         * cli/cli-setshow.c (parse_auto_binary_operation)
2906         (parse_cli_boolean_value): Don't allow "o".
2907
2908 2019-06-13  Pedro Alves  <palves@redhat.com>
2909
2910         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2911         * NEWS: Mention maint test-settings KIND.
2912         * maint-test-settings.c: New file.
2913
2914 2019-06-13  Pedro Alves  <palves@redhat.com>
2915
2916         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2917         completer.
2918         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2919         "set" completers.
2920
2921 2019-06-13  Pedro Alves  <palves@redhat.com>
2922
2923         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2924         after item.
2925
2926 2019-06-13  Pedro Alves  <palves@redhat.com>
2927
2928         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2929
2930 2019-06-13  Pedro Alves <palves@redhat.com>
2931
2932         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2933         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2934         call.
2935         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2936         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2937         calls.
2938         (check_for_argument): Skip spaces after argument.
2939
2940 2019-06-13  Pedro Alves  <palves@redhat.com>
2941
2942         * thread.c (thread_apply_command): Adjust TID parsing.
2943         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2944         detected before end of string.
2945         (tid_is_in_list): Error out if LIST is invalid.
2946
2947 2019-06-13  Pedro Alves  <palves@redhat.com>
2948
2949         * completer.c (complete_line_internal_1): Rewind completion word
2950         point.
2951         (completion_tracker::advance_custom_word_point_by): Change
2952         parameter type to int.
2953         * completer.h (completion_tracker::advance_custom_word_point_by):
2954         Likewise.
2955
2956 2019-06-13  Pedro Alves  <palves@redhat.com>
2957
2958         * completer.c (advance_to_completion_word): Handle delimiters.
2959
2960 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2961
2962         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2963
2964 2019-06-11  Tom Tromey  <tom@tromey.com>
2965
2966         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2967         (xmalloc_failed): Move to alloc.c.
2968         * alloc.c: New file.
2969         * Makefile.in (COMMON_SFILES): Add alloc.c.
2970
2971 2019-06-11  Tom Tromey  <tom@tromey.com>
2972
2973         * nat/linux-waitpid.c: Don't include server.h.
2974         (linux_debug): Remove.
2975         (my_waitpid): Update.
2976
2977 2019-06-11  Tom Tromey  <tromey@adacore.com>
2978
2979         * infcall.c (_initialize_infcall): Remove trailing newline from
2980         help.
2981         * user-regs.c (_initialize_user_regs): Remove trailing newline
2982         from help.
2983         * typeprint.c (_initialize_typeprint): Remove trailing newline
2984         from help.
2985         * reverse.c (_initialize_reverse): Remove trailing newlines from
2986         help.
2987         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2988         from help.
2989         * language.c (add_set_language_command): Remove trailing newline
2990         from help.
2991         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2992         help.
2993         * disasm.c (_initialize_disasm): Remove trailing newline from
2994         help.
2995         * top.c (init_main): Remove trailing newline from help.
2996         * interps.c (_initialize_interpreter): Remove trailing newline
2997         from help.
2998         * btrace.c (_initialize_btrace): Remove trailing newlines from
2999         help.
3000         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3001         from help.
3002         * python/python.c (_initialize_python): Remove trailing newline
3003         from help.
3004         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3005         help.
3006         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3007         from help.  Reformat some text.
3008         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3009         from help.
3010         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3011         newline from help.
3012
3013 2019-06-11  Tom Tromey  <tromey@adacore.com>
3014
3015         * darwin-nat.c (darwin_decode_exception_message)
3016         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3017
3018 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * valops.c (value_slice): Check for not allocated or not
3021         associated values.
3022
3023 2019-06-10  Tom de Vries  <tdevries@suse.de>
3024
3025         PR gdb/24618
3026         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3027         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3028         invalid.
3029
3030 2019-06-10  Tom de Vries  <tdevries@suse.de>
3031
3032         PR gdb/24611
3033         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3034         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3035
3036 2019-06-10  Tom de Vries  <tdevries@suse.de>
3037
3038         PR symtab/24545
3039         * symtab.c (struct demangled_name_entry): Add language field.
3040         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3041         static minimal symbol".  Set and use language field.
3042
3043 2019-06-10  Tom Tromey  <tromey@adacore.com>
3044
3045         * ada-lang.c (_initialize_ada_language): Update help text.
3046
3047 2019-06-10  Tom Tromey  <tromey@adacore.com>
3048
3049         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3050         with a newline.
3051         * guile/guile.c (handle_boot_error): Don't end warning with a
3052         newline.
3053         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3054         warning with a newline.
3055         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3056         newline.
3057         (s12z_frame_cache): Likewise.
3058         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3059         a newline.
3060         * solib-svr4.c (disable_probes_interface): Don't end warning with
3061         a newline.
3062         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3063         newline.
3064         * python/python.c (do_finish_initialization): Don't end warning
3065         with a newline.
3066
3067 2019-06-10  Tom Tromey  <tom@tromey.com>
3068
3069         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3070         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3071         gdbpy_enter.
3072
3073 2019-06-10  Tom Tromey  <tromey@adacore.com>
3074
3075         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3076         data.
3077         (elf_new_init): Don't call stabsread_new_init.
3078         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3079         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3080         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3081
3082 2019-06-10  Tom de Vries  <tdevries@suse.de>
3083
3084         PR symtab/16264
3085         PR symtab/24517
3086         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3087
3088 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3089
3090         * source.c (find_and_open_source): Also rewrite relative file
3091         names.
3092
3093 2019-04-26  Amos Bird  <amosbird@gmail.com>
3094
3095         * annotate.c (annotate_thread_exited): Add "thread-exited"
3096         annotation.
3097
3098 2019-06-06  Tom Tromey  <tromey@adacore.com>
3099
3100         * maint.h (class scoped_command_stats): Use
3101         DISABLE_COPY_AND_ASSIGN.
3102         <print_time>: New method.
3103         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3104         print_time.
3105         (scoped_command_stats::print_time): New method.
3106
3107 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3108
3109         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3110         instructions of lengths 6 or 8 bytes.
3111
3112 2019-06-04  Pedro Alves  <palves@redhat.com>
3113
3114         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3115
3116         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3117         * breakpoint.c (condition_completer): Likewise.
3118         * cli/cli-dump.c (scan_expression): Likewise.
3119         * common/filestuff.c (mkdir_recursive): Likewise.
3120         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3121         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3122         (gdb_abspath): Likewise.
3123         * compile/compile-cplus-types.c
3124         (compile_cplus_instance::decl_name): Likewise.
3125         * completer.c (complete_explicit_location):
3126         (signal_completer, reg_or_group_completer_1): Likewise.
3127         * cp-support.c (cp_remove_params_if_any): Likewise.
3128         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3129         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3130         * infcmd.c (strip_bg_char): Likewise.
3131         * linespec.c (copy_token_string): Likewise.
3132         * mi/mi-main.c (output_cores): Likewise.
3133         * psymtab.c (psymtab_search_name):
3134         * symfile.c (test_set_ext_lang_command): Likewise.
3135         * target.c (target_fileio_read_stralloc): Likewise.
3136         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3137         * value.c (complete_internalvar): Likewise.
3138
3139 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3140
3141         Add objfile property to gdb.Type.
3142         * NEWS: Mention Python API addition.
3143         * python/py-type.c (typy_get_objfile): New method.
3144
3145 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3146
3147         * NEWS: Mention the new set|show style [title|highlight].
3148         Mention changes to "show style", "help" and "apropos".
3149
3150 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3151
3152         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3153         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3154         instead of print_help_for_command.
3155         (print_doc_of_command): New function.
3156         (help_list): Add 'apropos -v word' suggestion.
3157         (print_help_for_command): Style the command name using title style.
3158         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3159         (_initialize_cli_cmds): Describe -v in apropos_command help.
3160
3161 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3162
3163         * cli/cli-style.h (cli_style_option): Add name in constructor,
3164         add m_name class member, add constructor with intensity,
3165         add name class function.
3166         (cli_style_option::add_setshow_commands): Remove name argument.
3167         (highlight_style, title_style): New styles.
3168         * cli/cli-style.c (do_show): New function that shows a style
3169         characteristic styling the style name with itself.
3170         (set_style_name): New function.
3171         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3172         Update all callers according to the changes in cli/cli-style.h.
3173         * utils.h (fputs_highlighted): New function.
3174         * utils.c (fputs_highlighted): Likewise.
3175
3176 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3177
3178         * NEWS: Mention new pipe command and new convenience variables.
3179
3180 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3181
3182         * cli/cli-cmds.c (pipe_command): New function.
3183         (_initialize_cli_cmds): Call add_com for pipe_command.
3184         Define | as an alias for pipe.
3185         (exit_status_set_internal_vars): New function.
3186         (shell_escape): Call exit_status_set_internal_vars.
3187         cli/cli-decode.c (find_command_name_length): Recognize | as
3188         a single character command.
3189
3190 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3191
3192         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3193         top.c (execute_command_to_ui_file): New function, mostly a copy
3194         of execute_command_to_string.
3195         (execute_command_to_string): Implement by calling
3196         execute_command_to_ui_file.
3197
3198 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3199
3200         * top.h (saved_command_line): Remove declaration.
3201         * top.c (previous_saved_command_line, previous_repeat_arguments):
3202         New variables.
3203         (saved_command_line): Make static, define together with other
3204         'repeat variables'.
3205         (dont_repeat): Clear repeat_arguments.
3206         (repeat_previous, get_saved_command_line, save_command_line):
3207         New functions.
3208         (gdb_init): Initialize saved_command_line
3209         and previous_saved_command_line.
3210         * main.c (captured_main_1): Remove saved_command_line initialization.
3211         * event-top.c (handle_line_of_input): Update to use
3212         the new 'repeat' related functions instead of direct access to
3213         saved_command_line.
3214         * command.h (repeat_previous, get_saved_command_line,
3215         save_command_line): New declarations.
3216         (dont_repeat): Add comment.
3217
3218 2019-05-30  Tom Tromey  <tromey@adacore.com>
3219
3220         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3221         Fix comment.
3222         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3223
3224 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3225
3226         PR cli/24587
3227         * completer.c (complete): Initialize variable word.
3228
3229 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3230
3231         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3232         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3233         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3234         'body' is NULL to the outter 'if', protecting the '!is_define'
3235         situation as well.
3236
3237 2019-05-29  Tom Tromey  <tromey@adacore.com>
3238
3239         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3240         (dwarf_unknown): New function.
3241         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3242         (dwarf_type_encoding_name): Use dwarf_unknown.
3243
3244 2019-05-29  Tom Tromey  <tromey@adacore.com>
3245
3246         PR c++/20020:
3247         * cp-valprint.c (cp_print_value_fields): Call
3248         cp_print_static_field inside "try".
3249
3250 2019-05-29  Tom Tromey  <tromey@adacore.com>
3251
3252         * inflow.c (struct terminal_info): Add default operator=.
3253         * configure: Rebuild.
3254         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3255         -Wdeprecated-copy-dtor, -Wredundant-move.
3256
3257 2019-05-29  Tom Tromey  <tromey@adacore.com>
3258
3259         * NEWS: Add entry.
3260         * infcmd.c (print_return_value_1): Handle finish_print
3261         option.
3262         (show_print_finish): New function.
3263         (_initialize_infcmd): Add "set/show print finish" commands.
3264         * valprint.c (user_print_options): Initialize new member.
3265         * valprint.h (struct value_print_options) <finish_print>: New
3266         member.
3267
3268 2019-05-28  Tom Tromey  <tromey@adacore.com>
3269
3270         * ada-lang.c (ada_remove_Xbn_suffix)
3271         (find_old_style_renaming_symbol)
3272         (parse_old_style_renaming): Remove.
3273         (ada_find_renaming_symbol): Don't call
3274         find_old_style_renaming_symbol.
3275         (ada_is_renaming_symbol): Rename from
3276         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3277         bool.  Now static.
3278         (ada_read_var_value): Update and simplify.
3279         * ada-exp.y (write_var_or_type): Remove old code.
3280
3281 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3282
3283         * event-top.c: Remove include comment.
3284         * inflow.c (class scoped_ignore_sigttou): Move from here...
3285         * inflow.h (class scoped_ignore_sigttou): ...to here.
3286         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3287         * top.c:  Remove include comment.
3288
3289 2019-05-27  Tom Tromey  <tom@tromey.com>
3290
3291         * NEWS: Fix typo.
3292
3293 2019-05-22  Tom Tromey  <tromey@adacore.com>
3294
3295         * target.c (target_follow_exec): Constify parameter.
3296         * target-delegates.c: Rebuild.
3297         * remote.c (remote_target::follow_exec): Constify parameter.
3298         * infrun.c (follow_exec): Constify parameter.
3299         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3300         (target_follow_exec): Likewise.
3301
3302 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3303
3304         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3305         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3306
3307 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3308
3309         * NEWS: Add debugredirect and testsuite sections.
3310
3311 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3312
3313         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3314         target descriptions using exclusively floating point register name
3315         aliases.
3316
3317 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3318
3319         PR gdb/18644:
3320         * f-lang.c (build_fortran_types): Handle the case where
3321         gdbarch_floatformat_for_type returns a nullptr.
3322
3323 2019-05-21  Tom de Vries  <tdevries@suse.de>
3324
3325         PR cli/24587
3326         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3327
3328 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         PR gdb/18644:
3331         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3332         16-byte floats.
3333         * i386-tdep.c (i386_floatformat_for_type): Use
3334         floatformats_ia64_quad for the 16-byte floating point component
3335         within a fortran 32-byte complex number.
3336
3337 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3340         delete default constructor.
3341         (find_partial_die): Update to return const struct.
3342         (partial_die_parent_scope): Move variable declaration into scope
3343         of its use and change its type to auto.
3344         (guess_partial_die_structure_name): Likewise.
3345         (partial_die_info::fixup): Likewise.
3346
3347 2019-05-17  Tom Tromey  <tromey@adacore.com>
3348
3349         * source.c (find_and_open_source): Remove cast.
3350
3351 2019-05-17  Tom Tromey  <tromey@adacore.com>
3352
3353         * annotate.c (annotate_source): Make "filename" const.
3354         * annotate.h (annotate_source): Use const.
3355
3356 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3357
3358         * disasm.c (set_disassembler_options): Send errors to stderr.
3359
3360 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3361
3362         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3363         (cli_interp_base::set_logging): Check debug_redirect.
3364         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3365         * cli/cli-logging.c (debug_redirect): Add static variable.
3366         (pop_output_files): Add default param.
3367         (handle_redirections): Print debug setting.
3368         (show_logging_command): Likewise.
3369         (_initialize_cli_logging): Add debugredirect command.
3370         * interps.c (current_interp_set_logging): Add debug_redirect
3371         parameter.
3372         * interps.h (set_logging): Add debug_redirect parameter.
3373         (current_interp_set_logging): Likewise.
3374         * mi/mi-common.h: Likewise.
3375         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3376
3377 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3378             Tom Tromey  <tromey@adacore.com>
3379
3380         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3381         directly.
3382         * cli/cli-interp.h (make_logging_output): Remove declaration.
3383         * cli/cli-logging.c (make_logging_output): Remove function.
3384         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3385         directly.
3386         * ui-file.c (tee_file::tee_file): Remove bools.
3387         (tee_file::~tee_file): Remove deletes.
3388         * ui-file.h (tee_file): Remove bools.
3389
3390 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3391
3392         * mi/mi-cmds.h (mi_cmd_complete): New function.
3393         * mi/mi-main.c (mi_cmd_complete): Likewise.
3394         * mi/mi-cmds.c: Define new MI command -complete.
3395         * NEWS: Mention new -complete command.
3396
3397 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3398
3399         * completer.h (complete): New function.
3400         * completer.c (complete): Likewise.
3401         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3402         function defined in completer.h.
3403
3404 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3405
3406         * MAINTAINERS (Write After Approval): Add myself.
3407
3408 2019-05-17  Tom de Vries  <tdevries@suse.de>
3409
3410         PR gdb/24094
3411         * dwarf2read.c (struct cu_partial_die_info): New struct.
3412         (find_partial_die): Return cu_partial_die_info.
3413         (partial_die_parent_scope, guess_partial_die_structure_name)
3414         (partial_die_info::fixup): Handle new return type of find_partial_die.
3415
3416 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3417
3418         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3419         "std::string", simplifying the algorithm.
3420
3421 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3422
3423         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3424         (stap_static_probe_ops::get_probes): Likewise.
3425
3426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3427
3428         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3429         '-')" and "else if".
3430         (stap_parse_single_operand): Join checks for
3431         "gdbarch_stap_parse_special_token_p" and
3432         "gdbarch_stap_parse_special_token" in the same "if" statement.
3433         Invert check when verifying for operation on register
3434         displacement.
3435
3436 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3437
3438         * stap-probe.c (stap_get_opcode): Update comment.
3439         (stap_get_expected_argument_type): Likewise.
3440         (handle_stap_probe): Likewise.
3441
3442 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3443
3444         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3445         return type to 'bool'.  Adjust comment.  Use 'bool' when
3446         appropriate.
3447         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3448         * stap-probe.c (stap_parse_argument_1): Likewise.
3449         (stap_is_operator): Likewise.
3450         (stap_is_generic_prefix): Likewise.
3451         (stap_is_register_prefix): Likewise.
3452         (stap_is_register_indirection_prefix): Likewise.
3453         (stap_is_integer_prefix): Likewise.
3454         (stap_generic_check_suffix): Likewise.
3455         (stap_check_integer_suffix): Likewise.
3456         (stap_check_register_suffix): Likewise.
3457         (stap_check_register_indirection_suffix): Likewise.
3458         (stap_parse_register_operand): Likewise.
3459         (stap_parse_single_operand): Likewise.
3460         (stap_parse_argument_1): Likewise.
3461         (stap_probe::get_argument_count): Likewise.
3462         (stap_is_operator): Likewise.
3463
3464 2019-05-16  Tom Tromey  <tromey@adacore.com>
3465
3466         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3467         keyword to foreach.
3468
3469 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3470
3471         * linux-thread-db.c (try_thread_db_load_1): Change return type
3472         to bool.
3473         (try_thread_db_load): Likewise.
3474         (try_thread_db_load_from_pdir_1): Likewise.
3475         (try_thread_db_load_from_pdir): Likewise.
3476         (try_thread_db_load_from_sdir): Likewise.
3477         (try_thread_db_load_from_dir): Likewise.
3478         (thread_db_load_search): Likewise.
3479         (has_libpthread): Likewise.
3480         (thread_db_load): Likewise.
3481
3482 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3483
3484         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3485         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3486         NULL, and complain/return if that's the case.
3487
3488 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3489
3490         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3491         (advance, posn, abstract_read_memory): New functions.
3492         [struct mem_read_abstraction]: New struct.
3493         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3494
3495 2019-05-14  Tom Tromey  <tromey@adacore.com>
3496
3497         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3498         value is not lval_memory.
3499
3500 2019-05-14  Tom Tromey  <tromey@adacore.com>
3501
3502         * solib.c (info_sharedlibrary_command): Style the file name.
3503
3504 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3505
3506         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3507         (aarch64_vnv_type): Likewise.
3508         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3509         * common/tdesc.c: Likewise.
3510         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3511         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3512         * features/aarch64-fpu.xml: Add ieee half view.
3513         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3514         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3515         * gdbtypes.h (struct builtin_type): Likewise.
3516         (struct objfile_type): Likewise.
3517
3518 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3519
3520         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3521         typo.
3522         * location.h (string_to_event_location): Likewise.
3523
3524 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3525
3526         GDB 8.3 released.
3527
3528 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3529
3530         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3531         New variable declaration.
3532         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3533         New variable.
3534         (print_one_breakpoint): Use ui_out::test_flags and new global
3535         variable to compute use_fixed_output.
3536         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3537         Remove.
3538         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3539         (mi_multi_location_breakpoint_output_fixed): Remove.
3540         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3541         new variable.
3542         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3543         fix_multi_location_breakpoint_output flag if version >= 3.
3544         * ui-out.h (enum ui_out_flag)
3545         <fix_multi_location_breakpoint_output>: New enumerator.
3546
3547 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3548
3549         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3550
3551 2019-05-10  Tom Tromey  <tromey@adacore.com>
3552
3553         * ada-lang.c (catch_ada_completer): New function.
3554         (_initialize_ada_language): Use it.
3555
3556 2019-05-10  Tom Tromey  <tromey@adacore.com>
3557
3558         * thread.c (print_thread_info): Make "requested_threads" const.
3559         * gdbthread.h (print_thread_info): Make "requested_threads"
3560         const.
3561         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3562         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * gdbtypes.c (objfile_type_data): Change type.
3567         (objfile_type, _initialize_gdbtypes): Update.
3568
3569 2019-05-08  Tom Tromey  <tom@tromey.com>
3570
3571         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3572         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3573         (_initialize_dwarf2_frame): Update.
3574
3575 2019-05-08  Tom Tromey  <tom@tromey.com>
3576
3577         * objc-lang.c (objc_objfile_data): Change type.
3578         (find_methods): Update.
3579         (_initialize_objc_lang): Remove.
3580
3581 2019-05-08  Tom Tromey  <tom@tromey.com>
3582
3583         * stabsread.c (rs6000_builtin_type_data): Change type.
3584         (rs6000_builtin_type, _initialize_stabsread): Update.
3585
3586 2019-05-08  Tom Tromey  <tom@tromey.com>
3587
3588         * mips-tdep.c (mips_pdr_data): Remove.
3589         (_initialize_mips_tdep): Update.
3590
3591 2019-05-08  Tom Tromey  <tom@tromey.com>
3592
3593         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3594         (hppa_init_objfile_priv_data, read_unwind_info)
3595         (find_unwind_entry, _initialize_hppa_tdep): Update.
3596
3597 2019-05-08  Tom Tromey  <tom@tromey.com>
3598
3599         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3600         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3601         on obstack.
3602         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3603
3604 2019-05-08  Tom Tromey  <tom@tromey.com>
3605
3606         * mdebugread.c (basic_type_data): Change type.
3607         (basic_type, _initialize_mdebugread): Update.
3608
3609 2019-05-08  Tom Tromey  <tom@tromey.com>
3610
3611         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3612
3613 2019-05-08  Tom Tromey  <tom@tromey.com>
3614
3615         * nto-tdep.c (nto_inferior_data_reg): Change type.
3616         (nto_inferior_data): Update.
3617         (nto_inferior_data_cleanup, nto_new_inferior_data)
3618         (_initialize_nto_tdep): Remove.
3619         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3620
3621 2019-05-08  Tom Tromey  <tom@tromey.com>
3622
3623         * ada-lang.c (struct ada_inferior_data): Add initializers.
3624         (ada_inferior_data): Change type.
3625         (ada_inferior_data_cleanup): Remove.
3626         (get_ada_inferior_data, ada_inferior_exit)
3627         (struct ada_pspace_data): Add initializers, destructor.
3628         (ada_pspace_data_handle): Change type.
3629         (get_ada_pspace_data): Update.
3630         (ada_pspace_data_cleanup): Remove.
3631
3632 2019-05-08  Tom Tromey  <tom@tromey.com>
3633
3634         * coffread.c (struct coff_symfile_info): Add initializers.
3635         (coff_objfile_data_key): Move lower.  Change type.
3636         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3637         Update.
3638         (coff_free_info): Remove.
3639
3640 2019-05-08  Tom Tromey  <tom@tromey.com>
3641
3642         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3643         (fbsd_pspace_data_handle): Move lower.  Change type.
3644         (get_fbsd_pspace_data): Update.
3645         (fbsd_pspace_data_cleanup): Remove.
3646         (_initialize_fbsd_tdep): Update.
3647
3648 2019-05-08  Tom Tromey  <tom@tromey.com>
3649
3650         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3651         (get_ada_tasks_pspace_data): Update.
3652         (ada_tasks_pspace_data_cleanup): Remove.
3653         (_initialize_tasks): Update.
3654         (ada_tasks_inferior_data_handle): Change type.
3655         (get_ada_tasks_inferior_data): Update.
3656         (ada_tasks_inferior_data_cleanup): Remove.
3657         (struct ada_tasks_pspace_data): Add initializers.
3658
3659 2019-05-08  Tom Tromey  <tom@tromey.com>
3660
3661         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3662         * symfile-debug.c (debug_sym_get_probes): Change type.
3663         * stap-probe.c (handle_stap_probe):
3664         (stap_static_probe_ops::get_probes): Change type.
3665         * probe.h (class static_probe_ops) <get_probes>: Change type.
3666         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3667         (parse_probes_in_pspace): Update.
3668         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3669         Update.
3670         (any_static_probe_ops::get_probes): Change type.
3671         * elfread.c (elfread_data): New typedef.
3672         (probe_key): Change type.
3673         (elf_get_probes): Likewise.  Update.
3674         (probe_key_free): Remove.
3675         (_initialize_elfread): Update.
3676         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3677         Change type.
3678         (dtrace_process_dof_probe, dtrace_process_dof)
3679         (dtrace_static_probe_ops::get_probe): Change type.
3680
3681 2019-05-08  Tom Tromey  <tom@tromey.com>
3682
3683         * xcoffread.c (struct xcoff_symfile_info): Rename from
3684         coff_symfile_info.  Add initializers.
3685         (xcoff_objfile_data_key): Move lower.  Change type.
3686         (XCOFF_DATA): Rewrite.
3687         (xcoff_free_info): Remove.
3688         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3689         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3690         (xcoff_initial_scan): Update.
3691
3692 2019-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * solib-svr4.c (struct svr4_info): Add initializers and
3695         destructor.
3696         <probes_table>: Now an htab_up.
3697         (solib_svr4_pspace_data): Change type.
3698         (free_probes_table): Simplify.
3699         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3700         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3701         (probes_table_remove_objfile_probes, register_solib_event_probe)
3702         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3703         (_initialize_svr4_solib): Update.
3704
3705 2019-05-08  Tom Tromey  <tom@tromey.com>
3706
3707         * remote.c (remote_pspace_data): Change type.
3708         (remote_pspace_data_cleanup): Remove.
3709         (get_remote_exec_file, set_pspace_remote_exec_file)
3710         (_initialize_remote): Update.
3711
3712 2019-05-08  Tom Tromey  <tom@tromey.com>
3713
3714         * breakpoint.c (breakpoint_objfile_key): Change type.
3715         (get_breakpoint_objfile_data): Update.
3716         (free_breakpoint_objfile_data): Remove.
3717         (_initialize_breakpoint): Update.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * linux-tdep.c (struct linux_info): Add initializers.
3722         (linux_inferior_data): Move.  Change type.
3723         (invalidate_linux_cache_inf): Update.
3724         (linux_inferior_data_cleanup): Remove.
3725         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3726
3727 2019-05-08  Tom Tromey  <tom@tromey.com>
3728
3729         * auxv.c (auxv_inferior_data): Move.  Change type.
3730         (auxv_inferior_data_cleanup): Remove.
3731         (invalidate_auxv_cache_inf): Rewrite.
3732         (get_auxv_inferior_data, _initialize_auxv): Update.
3733
3734 2019-05-08  Tom Tromey  <tom@tromey.com>
3735
3736         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3737         (symfile_debug_objfile_data_key): Change type.
3738         (symfile_debug_installed, debug_qf_has_symbols)
3739         (debug_qf_find_last_source_symtab)
3740         (debug_qf_forget_cached_source_info)
3741         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3742         (debug_qf_print_stats, debug_qf_dump)
3743         (debug_qf_expand_symtabs_for_function)
3744         (debug_qf_expand_all_symtabs)
3745         (debug_qf_expand_symtabs_with_fullname)
3746         (debug_qf_map_matching_symbols)
3747         (debug_qf_expand_symtabs_matching)
3748         (debug_qf_find_pc_sect_compunit_symtab)
3749         (debug_qf_map_symbol_filenames)
3750         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3751         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3752         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3753         (debug_sym_read_linetable, debug_sym_relocate): Update.
3754         (symfile_debug_free_objfile): Remove.
3755         (install_symfile_debug_logging, _initialize_symfile_debug):
3756         Update.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3761         allocate_on_obstack.
3762         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3763         (get_dwarf2_per_objfile): Update.
3764         (set_dwarf2_per_objfile): Remove.
3765         (dwarf2_has_info, dwarf2_get_section_info): Update.
3766         (dwarf2_free_objfile): Remove.
3767         (_initialize_dwarf2_read): Update.
3768
3769 2019-05-08  Tom Tromey  <tom@tromey.com>
3770
3771         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3772         initializers.
3773         <unsupported_script_warning_printed,
3774         script_not_found_warning_printed>: Now bool.
3775         (auto_load_pspace_data): Change type.
3776         (~auto_load_pspace_info): Rename from
3777         auto_load_pspace_data_cleanup.
3778         (get_auto_load_pspace_data, init_loaded_scripts_info)
3779         (clear_section_scripts, maybe_print_unsupported_script_warning)
3780         (maybe_print_script_not_found_warning, _initialize_auto_load):
3781         Update.
3782
3783 2019-05-08  Tom Tromey  <tom@tromey.com>
3784
3785         * objfiles.c (objfile_pspace_info): Add destructor and
3786         initializers.
3787         (objfiles_pspace_data): Change type.
3788         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3789         (get_objfile_pspace_data): Update.
3790         (objfiles_bfd_data): Change type.
3791         (get_objfile_bfd_data): Update.
3792         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3793
3794 2019-05-08  Tom Tromey  <tom@tromey.com>
3795
3796         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3797         Change type.
3798         (get_catch_syscall_inferior_data): Update.
3799         (catch_syscall_inferior_data_cleanup): Remove.
3800         (_initialize_break_catch_syscall): Update.
3801
3802 2019-05-08  Tom Tromey  <tom@tromey.com>
3803
3804         * inflow.c (struct terminal_info): Add destructor and
3805         initializers.
3806         (inflow_inferior_data): Change type.
3807         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3808         (get_inflow_inferior_data, inflow_inferior_exit)
3809         (swap_terminal_info, _initialize_inflow): Update.
3810
3811 2019-05-08  Tom Tromey  <tom@tromey.com>
3812
3813         * target-dcache.c (target_dcache_cleanup): Remove.
3814         (target_dcache_aspace_key): Change type.
3815         (target_dcache_init_p, target_dcache_invalidate)
3816         (target_dcache_get, target_dcache_get_or_init)
3817         (_initialize_target_dcache): Update.
3818         * dcache.h (struct dcache_deleter): New.
3819
3820 2019-05-08  Tom Tromey  <tom@tromey.com>
3821
3822         * symtab.c (struct symbol_cache): Add destructor and
3823         initializers.
3824         (symbol_cache_key): Move.  Change type.
3825         (make_symbol_cache, free_symbol_cache): Remove.
3826         (get_symbol_cache): Update.
3827         (symbol_cache_cleanup): Remove.
3828         (ALL_PSPACES, symbol_cache_flush)
3829         (maintenance_print_symbol_cache)
3830         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3831         Update.
3832
3833 2019-05-08  Tom Tromey  <tom@tromey.com>
3834
3835         * symtab.c (struct main_info): Add destructor and initializers.
3836         (main_progspace_key): Move.  Change type.
3837         (get_main_info): Update.
3838         (main_info_cleanup): Remove.
3839         (_initialize_symtab): Update.
3840
3841 2019-05-08  Tom Tromey  <tom@tromey.com>
3842
3843         * registry.h (DECLARE_REGISTRY): Define the _key class.
3844
3845 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * NEWS: Merge two 'New commands' sections.
3848
3849 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3850
3851         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3852         parameter and use Ada language definition instead.
3853         (ada_val_print_ptr): Remove unused language parameter.
3854         (ada_val_print_num): Remove language parameter and use Ada language
3855         definition instead.
3856         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3857         parameter.
3858         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3859         parameter and use Ada language definition instead.
3860         (ada_val_print_1): Update all ada_val_print_xxx calls.
3861         Remove language parameter.
3862         (ada_val_print): Update ada_val_print_1 call.
3863
3864 2019-05-08  Tom Tromey  <tromey@adacore.com>
3865
3866         * remote.c (remote_hw_watchpoint_limit)
3867         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3868         Now static.
3869
3870 2019-05-08  Tom Tromey  <tromey@adacore.com>
3871
3872         * maint.c (_initialize_maint_cmds): Move initialization code to
3873         remote.c.
3874         (watchdog, show_watchdog): Move to remote.c.
3875         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3876         "watchdog" static.
3877         (_initialize_remote): Move initialization code from maint.c.
3878         * defs.h (watchdog): Don't declare.
3879
3880 2019-05-08  Tom Tromey  <tromey@adacore.com>
3881
3882         * tui/tui-interp.c: Include main.h.
3883         * interps.c: Include main.h.
3884         * main.h (interpreter_p): Declare.
3885         * defs.h (interpreter_p): Don't declare.
3886
3887 2019-05-08  Tom Tromey  <tromey@adacore.com>
3888
3889         * dwarf2loc.c: Include dwarf2read.h.
3890         * defs.h (read_unsigned_leb128): Don't declare.
3891         * dwarf2read.h (read_unsigned_leb128): Declare.
3892
3893 2019-05-08  Tom Tromey  <tromey@adacore.com>
3894
3895         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3896         method.
3897
3898 2019-05-08  Tom Tromey  <tromey@adacore.com>
3899
3900         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3901         when no wrap column is set.
3902
3903 2019-05-08  Tom Tromey  <tromey@adacore.com>
3904
3905         * c-lang.c (c_get_string): Handle non-C-style arrays.
3906
3907 2019-05-08  Tom Tromey  <tromey@adacore.com>
3908
3909         * typeprint.c (print_offset_data::update): Print the bit offset,
3910         not the number of bits remaining.
3911
3912 2019-05-08  Tom Tromey  <tromey@adacore.com>
3913
3914         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3915         padding at end of comment.
3916
3917 2019-05-08  Tom Tromey  <tromey@adacore.com>
3918
3919         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3920         Compare main types.
3921
3922 2019-05-06  Tom Tromey  <tom@tromey.com>
3923
3924         * common/scoped_mmap.c: Include common-defs.h.
3925         * common/scoped_mmap.h: Don't include config.h.
3926
3927 2019-05-04  Tom Tromey  <tom@tromey.com>
3928
3929         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3930         (struct aarch64_call_info): Add initializers.
3931         <si>: Now a std::vector.
3932         (pass_on_stack, aarch64_push_dummy_call): Update.
3933
3934 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3935             Tom Tromey  <tom@tromey.com>
3936
3937         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3938         (ppc_threads): Now a std::vector.  Now static.
3939         (hwdebug_find_thread_points_by_tid)
3940         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3941         Update.
3942
3943 2019-05-04  Tom Tromey  <tom@tromey.com>
3944
3945         * arc-tdep.c (arc_tdesc_init): Return bool.
3946
3947 2019-05-04  Tom Tromey  <tom@tromey.com>
3948
3949         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3950         Use gdb_assert_not_reached.
3951
3952 2019-05-04  Tom Tromey  <tom@tromey.com>
3953
3954         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3955         "false".
3956
3957 2019-05-04  Tom Tromey  <tom@tromey.com>
3958
3959         * arc-tdep.c (arc_tdesc_init): Use bool.
3960
3961 2019-05-04  Tom Tromey  <tom@tromey.com>
3962
3963         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3964
3965 2019-05-04  Tom Tromey  <tom@tromey.com>
3966
3967         * cli/cli-cmds.c (valid_command_p): Return bool.
3968
3969 2019-05-04  Tom Tromey  <tom@tromey.com>
3970
3971         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3972         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3973
3974 2019-05-04  Raul Tambre  <raul@tambre.ee>
3975
3976         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3977         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3978         operator for comparison.
3979
3980 2019-05-04  Tom Tromey  <tom@tromey.com>
3981
3982         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3983         (lookup_partial_symbol, print_partial_symbols)
3984         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3985         (psymbol_compare): Update.
3986         (add_psymbol_to_bcache): Clear the entire psymbol.
3987         (maintenance_check_psymtabs): Update.
3988         * psympriv.h (struct partial_symbol): Don't derive from
3989         general_symbol_info.
3990         <obj_section, unrelocated_address, address,
3991         set_unrelocated_address>: Update.
3992         <ginfo>: New member.
3993         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3994         (debug_names::write_psymbols): Update.
3995
3996 2019-05-04  Tom de Vries  <tdevries@suse.de>
3997
3998         * contrib/cc-with-tweaks.sh: Support -n arg.
3999
4000 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4001
4002         * corelow.c (core_target::detach): Ensure frame cache and
4003         register caches are cleared.
4004         inferior.c (exit_inferior_1): Likewise.
4005
4006 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4007             Tom Tromey  <tom@tromey.com>
4008
4009         * dictionary.c (collate_pending_symbols_by_language): Remove
4010         "struct" from foreach.
4011         * symtab.c (lookup_global_symbol_from_objfile)
4012         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4013         foreach.
4014         * ser-tcp.c (net_open): Remove "struct" from foreach.
4015         * objfiles.c (objfile_relocate, objfile_rebase)
4016         (objfile_has_symbols): Remove "struct" from foreach.
4017         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4018         from foreach.
4019         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4020         foreach.
4021         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4022         "struct" from foreach.
4023         * ada-lang.c (create_excep_cond_exprs)
4024         (ada_exception_catchpoint_cond_string): Remove "struct" from
4025         foreach.
4026
4027 2019-05-03  Tom Tromey  <tromey@adacore.com>
4028
4029         * ada-exp.y (convert_char_literal): Check suffix of each
4030         enumerator.
4031
4032 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4033
4034         PR ada/21406:
4035         * ada-exp.y (yywrap): Don't define.
4036         * ada-lex.l (%option): Add noyywrap
4037         (yywrap): Remove.
4038
4039 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4040
4041         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4042         _WIN32_WINNT to the XP level, unless already defined to a higher
4043         level.
4044
4045         * unittests/parse-connection-spec-selftests.c:
4046         * ser-tcp.c:
4047         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4048         override.
4049
4050         * symfile.c (find_separate_debug_file): Remove colon from the
4051         drive spec of DOS/Windows file names of the target, so that the
4052         file name produced from DEBUGDIR and the target's directory will
4053         be valid on DOS/Windows systems.
4054
4055 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * rust-lang.c (val_print_struct): Handle printing structures
4058         containing strings.
4059
4060 2019-05-02  Tom Tromey  <tromey@adacore.com>
4061
4062         * valarith.c (_initialize_valarith): Remove.
4063
4064 2019-05-01  Tom Tromey  <tromey@adacore.com>
4065
4066         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4067         bitfields.
4068
4069 2019-05-01  Tom Tromey  <tromey@adacore.com>
4070
4071         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4072         for big-endian copies.
4073
4074 2019-04-30  Ali Tamur  <tamur@google.com>
4075         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4076         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4077         (read_3_bytes): New function.
4078
4079 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4080
4081         * windows-nat.c (main_thread_id): Delete.
4082         (handle_output_debug_string): Replace main_thread_id by
4083         current_event.dwThreadId.
4084         (fake_create_process): Likewise.
4085         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4086         Do not set main_thread_id.
4087         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4088         current_event.dwThreadId.
4089         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4090
4091 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4092
4093         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4094         Use current_event.dwThreadId instead of main_thread_id.
4095
4096 2019-04-30  Tom Tromey  <tromey@adacore.com>
4097
4098         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4099         (create_excep_cond_exprs): Iterate over program spaces.
4100         (ada_exception_catchpoint_cond_string): Examine all minimal
4101         symbols for exception types.
4102
4103 2019-04-30  Tom Tromey  <tromey@adacore.com>
4104
4105         PR c++/24470:
4106         * dwarf2read.c (process_structure_scope): Handle case where type
4107         has template parameters but no symbol was created.
4108
4109 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4110             Chris January  <chris.january@arm.com>
4111
4112         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4113         qualifier.
4114         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4115
4116 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4117
4118         * f-typeprint.c (f_print_type): Update rules for printing
4119         whitespace.
4120         (f_type_print_varspec_suffix): Likewise.
4121
4122 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4123             Chris January  <chris.january@arm.com>
4124
4125         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4126         function arguments.
4127
4128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * f-lang.c (build_fortran_types): Change name of void type to
4131         lower case.
4132         * f-typeprint.c (f_type_print_base): Print the name of the void
4133         type, rather than a fixed string.
4134         * f-valprint.c (f_decorations): Use lower case void string.
4135
4136 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4137             Chris January  <chris.january@arm.com>
4138
4139         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4140         types for Fortran.
4141
4142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4143             Chris January  <chris.january@arm.com>
4144             David Lecomber  <david.lecomber@arm.com>
4145
4146         * f-exp.y (BINOP_INTRINSIC): New token.
4147         (exp): New parser rule handling BINOP_INTRINSIC.
4148         (f77_keywords): Add new builtin procedures.
4149         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4150         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4151         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4152         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4153         (print_unop_subexp_f): New function.
4154         (print_binop_subexp_f): New function.
4155         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4156         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4157         (dump_subexp_body_f): Likewise.
4158         (operator_check_f): Likewise.
4159         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4160         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4161
4162 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4165         UNOP_KIND.
4166         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4167         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4168         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4169         (operator_length_f): New fuction.
4170         (print_subexp_f): New function.
4171         (op_name_f): New function.
4172         (dump_subexp_body_f): New function.
4173         (operator_check_f): New function.
4174         (exp_descriptor_f): Replace standard expression handling functions
4175         with new functions.
4176         * gdb/fortran-operator.def: New file.
4177         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4178         * gdb/std-operator.def: Remove UNOP_KIND.
4179
4180 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4181
4182         * std-operator.def: Remove unbalanced, stray double quote
4183         character.
4184
4185 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4186             Chris January  <chris.january@arm.com>
4187             Daniel Everett  <daniel.everett@arm.com>
4188             Nick Forrington  <nick.forrington@arm.com>
4189             Richard Bunt  <richard.bunt@arm.com>
4190
4191         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4192         of depth when printing anonymous structs or unions.
4193         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4194         Don't print either the top-level value, or the children if the
4195         max-depth is exceeded.
4196         (ppscm_print_children): When printing the key of a map, allow one
4197         extra level of depth.
4198         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4199         print either the top-level value, or the children if the max-depth
4200         is exceeded.
4201         (print_children): When printing the key of a map, allow one extra
4202         level of depth.
4203         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4204         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4205         (user_print_options): Initialise max_depth field.
4206         (val_print_scalar_or_string_type_p): New function.
4207         (val_print): Check to see if the max depth has been reached.
4208         (val_print_check_max_depth): Define new function.
4209         (show_print_max_depth): New function.
4210         (_initialize_valprint): Add 'print max-depth' option.
4211         * valprint.h (struct value_print_options) <max_depth>: New field.
4212         (val_print_check_max_depth): Declare new function.
4213         * NEWS: Document new feature.
4214
4215 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * ada-lang.c (ada_language_defn): Initialise new field.
4218         * c-lang.c (c_is_string_type_p): New function.
4219         (c_language_defn): Initialise new field.
4220         (cplus_language_defn): Initialise new field.
4221         (asm_language_defn): Initialise new field.
4222         (minimal_language_defn): Initialise new field.
4223         * c-lang.h (c_is_string_type_p): Declare new function.
4224         * d-lang.c (d_language_defn): Initialise new field.
4225         * f-lang.c (f_is_string_type_p): New function.
4226         (f_language_defn): Initialise new field.
4227         * go-lang.c (go_is_string_type_p): New function.
4228         (go_language_defn): Initialise new field.
4229         * language.c (default_is_string_type_p): New function.
4230         (unknown_language_defn): Initialise new field.
4231         (auto_language_defn): Initialise new field.
4232         * language.h (struct language_defn) <la_is_string_type_p>: New
4233         member variable.
4234         (default_is_string_type_p): Declare new function.
4235         * m2-lang.c (m2_language_defn): Initialise new field.
4236         * objc-lang.c (objc_language_defn): Initialise new field.
4237         * opencl-lang.c (opencl_language_defn): Initialise new field.
4238         * p-lang.c (pascal_is_string_type_p): New function.
4239         (pascal_language_defn): Initialise new field.
4240         * rust-lang.c (rust_is_string_type_p): New function.
4241         (rust_language_defn): Initialise new field.
4242
4243 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4246         New field.
4247         * ada-lang.c (ada_language_defn): Initialise new field.
4248         * c-lang.c (c_language_defn): Likewise.
4249         (cplus_language_defn): Likewise.
4250         (asm_language_defn): Likewise.
4251         (minimal_language_defn): Likewise.
4252         * d-lang.c (d_language_defn): Likewise.
4253         * f-lang.c (f_language_defn): Likewise.
4254         * go-lang.c (go_language_defn): Likewise.
4255         * language.c (unknown_language_defn): Likewise.
4256         (auto_language_defn): Likewise.
4257         * m2-lang.c (m2_language_defn): Likewise.
4258         * objc-lang.c (objc_language_defn): Likewise.
4259         * opencl-lang.c (opencl_language_defn): Likewise.
4260         * p-lang.c (pascal_language_defn): Likewise.
4261         * rust-lang.c (rust_language_defn): Likewise.
4262
4263 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * ada-lang.c (ada_is_character_type): Change return type to bool.
4266         (ada_is_string_type): Likewise.
4267         * ada-lang.h (ada_is_character_type): Update declaration
4268         (ada_is_string_type): Likewise.
4269
4270 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4271
4272         Support style in 'frame|thread apply'
4273
4274         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4275         * record.c (record_start, record_stop): Update callers of
4276         execute_command_to_string with false.
4277         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4278         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4279         methods.
4280         (class string_file): New constructor with term_out parameter.
4281         Override methods term_out and can_emit_style_escape.  New member
4282         term_out.
4283         (class stdio_file): Override can_emit_style_escape.
4284         (class tee_file): Override term_out and can_emit_style_escape.
4285         * utils.h (can_emit_style_escape): Remove.
4286         * utils.c (can_emit_style_escape): Likewise.
4287         Update all callers of can_emit_style_escape (SOMESTREAM) to
4288         SOMESTREAM->can_emit_style_escape.
4289         * source-cache.c (source_cache::get_source_lines): Likewise.
4290         * stack.c (frame_apply_command_count): Call execute_command_to_string
4291         passing the term_out characteristic of the current gdb_stdout.
4292         * thread.c (thr_try_catch_cmd): Likewise.
4293         * top.c (execute_command_to_string): pass term_out parameter
4294         to construct the string_file for the command output.
4295         * ui-file.c (term_cli_styling): New function (most code moved
4296         from utils.c can_emit_style_escape).
4297         (string_file::string_file, string_file::can_emit_style_escape,
4298         stdio_file::can_emit_style_escape, tee_file::term_out,
4299         tee_file::can_emit_style_escape): New functions.
4300
4301 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4302
4303         * NEWS: Mention the new set|show may-call-functions.
4304         * infcall.c (may_call_functions_p): New variable.
4305         (show_may_call_functions_p): New function.
4306         (call_function_by_hand_dummy): Throws an error if not
4307         may-call-functions.
4308         (_initialize_infcall): Call add_setshow_boolean_cmd for
4309         may-call-functions.
4310
4311 2019-04-25  Keith Seitz  <keiths@redhat.com>
4312
4313         PR c++/24367
4314         * cp-support.c (inspect_type): Don't attempt substitutions
4315         of symbol with the same name.
4316
4317 2019-04-25  Tom Tromey  <tromey@adacore.com>
4318
4319         PR gdb/24475:
4320         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4321         static.
4322
4323 2019-04-25  Tom Tromey  <tromey@adacore.com>
4324
4325         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4326         rvalue reference.
4327         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4328         (gdb_xml_parser::parse): Use std::move.
4329         * python/python-internal.h (gdbpy_convert_exception): Take a const
4330         reference.
4331         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4332         std::move.
4333         * python/py-utils.c (gdbpy_convert_exception): Take a const
4334         reference.
4335         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4336         Use std::move.
4337         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4338         Use std::move.
4339         * mi/mi-main.c (mi_print_exception): Take a const reference.
4340         * main.c (handle_command_errors): Take a const reference.
4341         * linespec.c (parse_linespec): Use std::move.
4342         * infcall.c (run_inferior_call): Use std::move.
4343         (call_function_by_hand_dummy): Use std::move.
4344         * exec.c (try_open_exec_file): Use std::move.
4345         * exceptions.h (exception_print, exception_fprintf)
4346         (exception_print_same): Update.
4347         * exceptions.c (print_exception, exception_print)
4348         (exception_fprintf, exception_print_same): Change parameters to
4349         const reference.
4350         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4351         * common/new-op.c: Use std::move.
4352         * common/common-exceptions.h (struct gdb_exception): Add move
4353         constructor.
4354         (struct gdb_exception_error, struct gdb_exception_quit, struct
4355         gdb_quit_bad_alloc): Change constructor to move constructor.
4356         (throw_exception): Change parameter to rvalue reference.
4357         * common/common-exceptions.c (throw_exception): Take rvalue
4358         reference.
4359         * cli/cli-interp.c (safe_execute_command): Use std::move.
4360         * breakpoint.c (insert_bp_location, location_to_sals): Use
4361         std::move.
4362
4363 2019-04-25  Tom Tromey  <tromey@adacore.com>
4364
4365         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4366         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4367         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4368         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4369         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4370         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4371         guile/scm-value.c: Use unpack.
4372         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4373         gdbscm_gdb_exception.
4374         (gdbscm_throw_gdb_exception): Likewise.
4375         (struct gdbscm_gdb_exception): New.
4376         (unpack): New function.
4377         (gdbscm_wrap): Use unpack.
4378
4379 2019-04-25  Tom Tromey  <tromey@adacore.com>
4380
4381         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4382         (gdb_rl_callback_handler): Use std::move.
4383         * common/common-exceptions.h (struct gdb_exception): Add move
4384         assignment operator.
4385         (throw_exception_sjlj): Change "exception" to const reference.
4386         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4387         (throw_exception_sjlj): Change "exception" to const reference.
4388
4389 2019-04-25  Tom Tromey  <tromey@adacore.com>
4390
4391         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4392         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4393         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4394         Update.
4395         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4396         Update.
4397         * mi/mi-interp.c (mi_interp::exec): Update.
4398         * linespec.c (parse_linespec): Update.
4399         * infcall.c (run_inferior_call): Update.
4400         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4401         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4402         (gdbscm_lookup_global_symbol): Update.
4403         * guile/scm-param.c (gdbscm_parameter_value): Update.
4404         * guile/scm-frame.c (gdbscm_frame_read_register)
4405         (gdbscm_frame_read_var): Update.
4406         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4407         * exec.c (try_open_exec_file): Update.
4408         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4409         (gdb_rl_callback_handler): Update.
4410         * common/common-exceptions.h (exception_none): Don't declare.
4411         * common/common-exceptions.c (exception_none): Don't define.
4412         (struct catcher) <exception>: Update.
4413         * cli/cli-interp.c (safe_execute_command): Update.
4414         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4415
4416 2019-04-25  Ali Tamur  <tamur@google.com>
4417
4418         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4419         (read_attribute_value): Likewise.
4420         (dwarf2_read_addr_index): Update comment.
4421         (read_str_index): Add DW_FORM_strx.
4422         (dwarf2_string_attr): Likewise.
4423         (dwarf2_const_value_attr): Likewise.
4424         (dump_die_shallow): Likewise.
4425         (dwarf2_fetch_constant_bytes): Likewise.
4426         (skip_form_bytes): Likewise.
4427         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4428
4429 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4430
4431         PR corefiles/11608
4432         PR corefiles/18187
4433         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4434         OFFSET.  Verify if current mapping contains an ELF header.
4435         (linux_find_memory_regions_full): Adjust call to
4436         dump_mapping_p.
4437
4438 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4439             Kang Li <kanglictf@gmail.com>
4440
4441         PR gdb/21600
4442
4443         * dwarf2-frame.c (read_initial_length): Be consistent about using
4444         unsigned representation of length.
4445         (decode_frame_entry_1): Likewise.  Check for wraparound of
4446         end pointer as well as buffer overflow.
4447
4448 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4449
4450         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4451         "vq".
4452
4453 2019-04-24  Tom Tromey  <tromey@adacore.com>
4454
4455         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4456
4457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4458
4459         * s12z-tdep.c (s12z_unwind_pc): Delete.
4460         (s12z_unwind_sp): Delete.
4461         (s12z_gdbarch_init): Don't register deleted functions with
4462         gdbarch.
4463
4464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * rl78-tdep.c (rl78_unwind_sp): Delete.
4467         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4468
4469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4472         (xstormy16_unwind_pc): Delete.
4473         (xstormy16_dummy_id): Delete.
4474         (xstormy16_gdbarch_init): Don't register deleted functions with
4475         gdbarch.
4476
4477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * vax-tdep.c (vax_unwind_pc): Delete.
4480         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4481
4482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4483
4484         * v850-tdep.c (v850_unwind_sp): Delete.
4485         (v850_unwind_pc): Delete.
4486         (v850_dummy_id): Delete.
4487         (v850_gdbarch_init): Don't register deleted functions with
4488         gdbarch.
4489
4490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4491
4492         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4493         (tilegx_unwind_pc): Delete.
4494         (tilegx_unwind_dummy_id): Delete.
4495         (tilegx_gdbarch_init): Don't register deleted functions with
4496         gdbarch.
4497
4498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4499
4500         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4501         (tic6x_dummy_id): Delete.
4502         (tic6x_gdbarch_init): Don't register deleted functions with
4503         gdbarch.
4504
4505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * sparc-tdep.c (sparc_unwind_pc): Delete.
4508         (sparc32_gdbarch_init): Don't register deleted function with
4509         gdbarch.
4510
4511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * sh-tdep.c (sh_unwind_sp): Delete.
4514         (sh_unwind_pc): Delete.
4515         (sh_dummy_id): Delete.
4516         (sh_gdbarch_init): Don't register deleted functions with
4517         gdbarch.
4518
4519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * score-tdep.c (score_unwind_sp): Delete.
4522         (score_unwind_pc): Delete.
4523         (score_dummy_id): Delete.
4524         (score_gdbarch_init): Don't register deleted functions with
4525         gdbarch.
4526
4527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4528
4529         * rx-tdep.c (rx_unwind_pc): Delete.
4530         (rx_unwind_sp): Delete.
4531         (rx_dummy_id): Delete.
4532         (rx_gdbarch_init): Don't register deleted functions with
4533         gdbarch.  Update comment.
4534
4535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4538         (rs6000_dummy_id): Delete.
4539         (rs6000_gdbarch_init): Don't register deleted functions with
4540         gdbarch.
4541
4542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * or1k-tdep.c (or1k_dummy_id): Delete.
4545         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4546
4547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * nios2-tdep.c (nios2_dummy_id): Delete.
4550         (nios2_unwind_sp): Delete.
4551         (nios2_gdbarch_init): Don't register deleted functions with
4552         gdbarch.
4553
4554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * nds32-tdep.c (nds32_dummy_id): Delete.
4557         (nds32_unwind_pc): Delete.
4558         (nds32_unwind_sp): Delete.
4559         (nds32_gdbarch_init): Don't register deleted functions with
4560         gdbarch.
4561
4562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * msp430-tdep.c (msp430_unwind_pc): Delete.
4565         (msp430_unwind_sp): Delete.
4566         (msp430_dummy_id): Delete.
4567         (msp430_gdbarch_init): Don't register deleted functions with
4568         gdbarch.
4569
4570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4571
4572         * moxie-tdep.c (moxie_unwind_sp): Delete.
4573         (moxie_unwind_pc): Delete.
4574         (moxie_dummy_id): Delete.
4575         (moxie_gdbarch_init): Don't register deleted functions with
4576         gdbarch.
4577
4578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4581         (mn10300_unwind_pc): Delete.
4582         (mn10300_unwind_sp): Delete.
4583         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4584         mn10300_unwind_sp.
4585         (mn10300_frame_unwind_init): Don't register deleted functions with
4586         gdbarch.
4587
4588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * mep-tdep.c (mep_unwind_pc): Delete.
4591         (mep_unwind_sp): Delete.
4592         (mep_dummy_id): Delete.
4593         (mep_gdbarch_init): Don't register deleted functions with
4594         gdbarch.
4595
4596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4599         (m68hc11_unwind_sp): Delete.
4600         (m68hc11_gdbarch_init): Don't register deleted functions with
4601         gdbarch.
4602
4603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * m32r-tdep.c (m32r_unwind_sp): Delete.
4606         (m32r_unwind_pc): Delete.
4607         (m32r_dummy_id): Delete.
4608         (m32r_gdbarch_init): Don't register deleted functions with
4609         gdbarch.
4610
4611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * m32c-tdep.c (m32c_unwind_pc): Delete.
4614         (m32c_unwind_sp): Delete.
4615         (m32c_dummy_id): Delete.
4616         (m32c_gdbarch_init): Don't register deleted functions with
4617         gdbarch.
4618
4619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4620
4621         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4622         (lm32_unwind_pc): Delete.
4623         (lm32_dummy_id): Delete.
4624         (lm32_gdbarch_init): Don't register deleted functions with
4625         gdbarch.
4626
4627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4628
4629         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4630         (iq2000_unwind_pc): Delete.
4631         (iq2000_dummy_id): Delete.
4632         (iq2000_gdbarch_init): Don't register deleted functions with
4633         gdbarch.
4634
4635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4636
4637         * nds32-tdep.c (nds32_type_align): Delete.
4638         (nds32_push_dummy_call): Use type_align instead.
4639
4640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * arm-tdep.c (arm_type_align): Only handle vector override case.
4643         (arm_push_dummy_call): Use type_align.
4644         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4645
4646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4649         case.
4650         (pass_on_stack): Use type_align.
4651         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4652         function.
4653
4654 2019-04-23  Tom Tromey  <tromey@adacore.com>
4655
4656         * dwarf2read.c (line_header::file_name_at): Remove unused
4657         overload.
4658
4659 2019-04-23  Tom de Vries  <tdevries@suse.de>
4660
4661         PR gdb/24438
4662         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4663         invocation.
4664
4665
4666 2019-03-27  Ali Tamur  <tamur@google.com>
4667
4668         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4669         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4670         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4671         (dwarf_expr_context::get_addr_index): Likewise
4672         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4673         (symbol_needs_eval_context::get_addr_index): Likewise
4674         (disassemble_dwarf_expression): Add DW_OP_addrx
4675         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4676         (read_cutu_die_from_dwo): Update comment
4677         (skip_one_die): Add DW_FORM_addrx
4678         (read_attribute_value): Likewise
4679         (var_decode_location): Add DW_OP_addrx
4680         (dwarf2_const_value_attr): Add DW_FORM_addrx
4681         (dump_die_shallow): Likewise
4682         (dwarf2_fetch_constant_bytes): Likewise
4683         (decode_locdesc): Add DW_OP_addrx
4684         (skip_form_bytes): Add DW_FORM_addrx
4685
4686 2019-04-22  Ali Tamur  <tamur@google.com>
4687
4688         * MAINTAINERS (Write After Approval): Add self.
4689
4690 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4691
4692         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4693         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4694         (open_symbol_file_object): Likewise.
4695         (svr4_default_sos): Add info parameter.
4696         (svr4_read_so_list): Likewise.
4697         (svr4_current_sos_direct): Adjust functions calls to pass down
4698         info.
4699         (svr4_current_sos_1): Add info parameter.
4700         (svr4_current_sos): Call get_svr4_info, pass info down to
4701         svr4_current_sos_1.
4702         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4703         get_svr4_info.
4704         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4705         get_svr4_info.
4706         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4707         to get_svr4_info.
4708         (probes_table_remove_objfile_probes): Likewise.
4709         (register_solib_event_probe): Add info parameter.
4710         (solist_update_incremental): Pass info parameter down to
4711         svr4_read_so_list.
4712         (disable_probes_interface): Add info parameter.
4713         (svr4_handle_solib_event): Pass current_program_space to
4714         get_svr4_info.  Adjust disable_probes_interface cleanup.
4715         (svr4_create_probe_breakpoints): Add info parameter, pass it
4716         down to register_solib_event_probe.
4717         (svr4_create_solib_event_breakpoints): Add info parameter,
4718         pass it down to svr4_create_probe_breakpoints.
4719         (enable_break): Pass info down to
4720         svr4_create_solib_event_breakpoints.
4721         (svr4_solib_create_inferior_hook): Pass current_program_space to
4722         get_svr4_info.
4723         (svr4_clear_solib): Likewise.
4724
4725 2019-04-22  Pedro Alves  <palves@redhat.com>
4726
4727         * solib-svr4.c (svr4_free_objfile_observer): New.
4728         (probe_and_action::objfile): New field.
4729         (probes_table_htab_remove_objfile_probes)
4730         (probes_table_remove_objfile_probes): New functions.
4731         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4732         in the new probe_and_action.  Don't store the probe in 'lookup'.
4733         (svr4_create_probe_breakpoints): Pass objfile to
4734         register_solib_event_probe.
4735         (_initialize_svr4_solib): Register a free_objfile observer.
4736
4737 2019-04-19  Tom Tromey  <tom@tromey.com>
4738
4739         * common/queue.h: Remove.
4740
4741 2019-04-19  Tom Tromey  <tom@tromey.com>
4742
4743         * event-loop.c: Don't include "common/queue.h".
4744
4745 2019-04-19  Tom Tromey  <tom@tromey.com>
4746
4747         * remote.c (remote_target): Use delete.
4748         * remote-notif.h: Include <list>, not "common/queue.h".
4749         (notif_client_p): Remove typedef.
4750         (remote_notif_state): Add constructor, destructor, initializer.
4751         <notif_queue>: Now a std::list.
4752         (remote_notif_state_xfree): Don't declare.
4753         * remote-notif.c (remote_notif_process, handle_notification)
4754         (remote_notif_state_allocate): Update.
4755         (~remote_notif_state): Rename from remote_notif_state_xfree.
4756
4757 2019-04-19  Tom Tromey  <tom@tromey.com>
4758
4759         * symfile.c (reread_symbols): Update.
4760         * objfiles.c (objfile_register_static_link)
4761         (objfile_lookup_static_link): Update
4762         (~objfile) Don't delete static_links.
4763         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4764
4765 2019-04-19  Tom Tromey  <tom@tromey.com>
4766
4767         * type-stack.h (struct type_stack) <insert>: Constify string.
4768         * type-stack.c (type_stack::insert): Constify string.
4769         * gdbtypes.h (lookup_template_type): Update.
4770         (address_space_name_to_int): Update.
4771         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4772         const.
4773         (lookup_template_type): Make name const.
4774         * c-exp.y: Update rules.
4775         (lex_one_token, classify_name, classify_inner_name)
4776         (c_print_token): Update.
4777         * p-exp.y: Update rules.
4778         (yylex): Update.
4779         * f-exp.y: Update rules.
4780         (yylex): Update.
4781         * d-exp.y: Update rules.
4782         (lex_one_token, classify_name, classify_inner_name): Update.
4783         * parse.c (write_dollar_variable, copy_name): Return std::string.
4784         * parser-defs.h (copy_name): Change return type.
4785         * m2-exp.y: Update rules.
4786         (yylex): Update.
4787         * go-exp.y (lex_one_token): Update.
4788         Update rules.
4789         (classify_unsafe_function, classify_packaged_name)
4790         (classify_name, yylex): Update.
4791
4792 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4793
4794         * configure.ac: add --enable-source-highlight switch.
4795         * configure: Regenerate.
4796         * top.c (print_gdb_version): plumb --enable-source-highlight
4797         status to "show configuration".
4798
4799 2019-04-19  Tom Tromey  <tromey@adacore.com>
4800
4801         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4802         Check ADA_TYPE_P.
4803         (empty_record, ada_template_to_fixed_record_type_1)
4804         (template_to_static_fixed_type)
4805         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4806         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4807         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4808         macros.
4809
4810 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4811
4812         PR symtab/24423:
4813         * source.c (print_source_lines_base): Advance "iter" when a
4814         control character is seen.
4815
4816 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4817
4818         * inferior.h (struct infcall_suspend_state_deleter):
4819         Catch exception in destructor to avoid crash.
4820
4821 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4822
4823         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4824         close to the add_com "shell".
4825
4826 2019-04-18  Tom Tromey  <tromey@adacore.com>
4827
4828         * process-stratum-target.h (class process_stratum_target)
4829         <stratum>: Add "final".
4830
4831 2019-04-17  Tom Tromey  <tromey@adacore.com>
4832
4833         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4834         against nullptr before use.
4835
4836 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4837
4838         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4839
4840 2019-04-17  Jim Wilson  <jimw@sifive.com>
4841             Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4844         code read might fail, assume 4-byte breakpoint in that case.
4845
4846 2019-04-15  Leszek Swirski  <leszeks@google.com>
4847
4848         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4849         rather than a hand-rolled POD check when checking for forced MEMORY
4850         classification.
4851
4852 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4853
4854         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4855         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4856         function.
4857         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4858         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4859         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4860         declaration.
4861
4862 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4863
4864         * aarch64-linux-nat.c
4865         (aarch64_linux_nat_target::thread_architecture): Add override.
4866         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4867         each VQ.
4868
4869 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4870
4871         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4872
4873 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4876         target types of size 96-bits, add some additional comments, and
4877         check that the builtin type we found was the correct size.
4878
4879 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4880
4881         * utils.c (prompt_for_continue): Don't restore the styling at the
4882         end, as applied_style has the wrong value.  This fixes styling in
4883         long lists of file names that are interrupted by the "Continue?"
4884         prompt.
4885
4886 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4887
4888         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4889         * c-lang.c (c_language_defn): Likewise.
4890         (cplus_language_defn): Likewise.
4891         (asm_language_defn): Likewise.
4892         (minimal_language_defn): Likewise.
4893         * d-lang.c (d_language_defn): Likewise.
4894         * f-lang.c (f_language_defn): Likewise.
4895         * go-lang.c (go_language_defn): Likewise.
4896         * language.c (unknown_language_defn): Likewise.
4897         (auto_language_defn): Likewise.
4898         * language.h (struct language_defn): Remove la_magic field.
4899         (LANG_MAGIC): Delete.
4900         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4901         * objc-lang.c (objc_language_defn): Likewise.
4902         * opencl-lang.c (opencl_language_defn): Likewise.
4903         * p-lang.c (pascal_language_defn): Likewise.
4904         * rust-lang.c (rust_language_defn): Likewise.
4905
4906 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * riscv-tdep.c (riscv_type_align): New function.
4909         (riscv_type_alignment): Delete.
4910         (riscv_arg_location): Use 'type_align'.
4911         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4912
4913 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * gdbtypes.c (type_align): A struct with no non-static fields also
4916         has alignment of 1.
4917
4918 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4921         component to 0.
4922         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4923         member.
4924         (riscv_struct_info::analyse): New implementation using new
4925         analyse_inner member function.
4926         (riscv_struct_info::field_offset): New member function.
4927         (riscv_struct_info::m_offsets): New member variable.
4928         (riscv_struct_info::analyse_inner): New private member function,
4929         takes the old implementation of riscv_struct_info::analyse but
4930         extended to track field offsets.
4931         (riscv_call_arg_struct): Update the struct folding special cases
4932         to handle cases where empty C++ structs, which are non-zero
4933         length, are found.
4934         (riscv_arg_location): Initialise the length of each location, a
4935         non-zero length now indicates the location is in use.
4936         (riscv_push_dummy_call): Allow for the first location having a
4937         non-zero offset when setting up arguments.
4938         (riscv_return_value): Likewise, but for return values.
4939
4940 2019-04-11  Tom Tromey  <tromey@adacore.com>
4941
4942         * utils.c (internal_vproblem): Make "msg" const.
4943
4944 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4945
4946         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4947         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4948         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4949         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4950
4951 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4952
4953         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4954         function.
4955         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4956         of amd64_collect_native_gregset.
4957         (amd64_linux_nat_target::store_registers): Likewise.
4958
4959 2019-04-10  Tom Tromey  <tom@tromey.com>
4960
4961         * symtab.c (lookup_global_symbol_from_objfile)
4962         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4963         * objfiles.h (class separate_debug_iterator): New.
4964         (class separate_debug_range): New.
4965         (struct objfile) <separate_debug_objfiles>: New method.
4966         (objfile_separate_debug_iterate): Don't declare.
4967         * objfiles.c (separate_debug_iterator::operator++): Rename from
4968         objfile_separate_debug_iterate.
4969         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4970         iterator.
4971         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4972         iterator.
4973
4974 2019-04-10  Tom Tromey  <tom@tromey.com>
4975
4976         * symfile.c (reread_symbols): Remove old comment.
4977         * objfiles.c (free_all_objfiles): Fix a typo.
4978
4979 2019-04-10  Tom Tromey  <tom@tromey.com>
4980
4981         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4982         * minsyms.c (lookup_minimal_symbol): Use foreach.
4983         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4984         (lookup_minimal_symbol_solib_trampoline): Likewise.
4985         * symfile.c (reread_symbols): Use foreach.
4986
4987 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4988             Tom Tromey  <tromey@adacore.com>
4989
4990         PR rust/24414:
4991         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4992         (rust_lex_int_test): Change "value" to be LONGEST.
4993         (rust_lex_tests): Add test for long integer literal.
4994
4995 2019-04-09  Tom Tromey  <tromey@adacore.com>
4996
4997         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4998         to bool.
4999         (extended_remote_target::attach): Update.
5000         (remote_target::remote_notice_new_inferior): Update.
5001         (remote_target::add_current_inferior_and_thread): Update.
5002         * inferior.c (exit_inferior_1): Use "false".
5003         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5004
5005 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5006
5007         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5008         the "start" command.
5009
5010 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5011
5012         * python/py-inferior.c (infpy_thread_from_thread_handle):
5013         Adjust comments to reflect renaming of thread_from_thread_handle
5014         to thread_from_handle.  Adjust keywords.  Fix type error message.
5015         (inferior_object_methods): Add thread_from_handle.  Retain
5016         thread_from_thread_handle, but mark it as deprecated.
5017
5018 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5019
5020         * gdbthread.h (find_thread_by_handle): Revise declaration.
5021         * thread.c (find_thread_by_handle): Likewise.  Adjust
5022         implementation too.
5023         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5024         support for buffer objects as handles.
5025
5026 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5027
5028         * python/py-infthread.c (thpy_thread_handle): New function.
5029         (thread_object_methods): Register thpy_thread_handle.
5030
5031 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5032
5033         * gdbthread.h (thread_to_thread_handle): Declare.
5034         * thread.c (gdbtypes.h): Include.
5035         (thread_to_thread_handle): New function.
5036
5037         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5038         (target_thread_info_to_thread_handle): Declare.
5039         * target.c (target_thread_info_to_thread_handle): New function.
5040         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5041         * target-delegates.c: Regenerate.
5042
5043         * linux-thread-db.c (class thread_db_target): Add method
5044         thread_info_to_thread_handle.
5045         (thread_db_target::thread_info_to_thread_handle): Define.
5046         * remote.c (class remote_target): Add new method
5047         thread_info_to_thread_handle.
5048         (remote_target::thread_info_to_thread_handle): Define.
5049
5050 2019-04-08  Pedro Alves  <palves@redhat.com>
5051
5052         * common/common-exceptions.c (throw_exception): Don't create
5053         named object to throw; throw directly.
5054         (throw_it): Likewise.  Don't initialize gdb_exception::message
5055         here, with new; pass FMT and AP to the ctor instead.
5056         * common/common-exceptions.h: Include <string>.
5057         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5058         const char *, va_list)): New ctor.  Use std::make_shared.
5059         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5060         errors)): Delete.
5061         (gdb_exception_error::gdb_exception_error(enum errors, const char
5062         *, va_list)): New.
5063         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5064         Add assertion.
5065         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5066         errors)): Delete.
5067         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5068         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5069         Add assertion.
5070
5071 2019-04-08  Tom Tromey  <tom@tromey.com>
5072
5073         * valops.c (value_rtti_indirect_type): Replace throw_exception
5074         with throw.
5075         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5076         with throw.
5077         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5078         throw.
5079         * target.c (target_translate_tls_address): Replace throw_exception
5080         with throw.
5081         * stack.c (frame_apply_command_count): Replace throw_exception
5082         with throw.
5083         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5084         throw.
5085         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5086         with throw.
5087         * rs6000-tdep.c (rs6000_frame_cache)
5088         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5089         * remote.c: Replace throw_exception with throw.
5090         * record-full.c (record_full_message, record_full_wait_1)
5091         (record_full_restore): Replace throw_exception with throw.
5092         * record-btrace.c:
5093         (get_thread_current_frame_id, record_btrace_start_replaying)
5094         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5095         (cmd_record_btrace_start): Replace throw_exception with throw.
5096         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5097         throw.
5098         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5099         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5100         * linespec.c:
5101         (find_linespec_symbols): Replace throw_exception with throw.
5102         * infrun.c (displaced_step_prepare, resume): Replace
5103         throw_exception with throw.
5104         * infcmd.c (post_create_inferior): Replace throw_exception with
5105         throw.
5106         * inf-loop.c (inferior_event_handler): Replace throw_exception
5107         with throw.
5108         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5109         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5110         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5111         (get_prev_frame_always, get_frame_pc_if_available)
5112         (get_frame_address_in_block_if_available, get_frame_language):
5113         Replace throw_exception with throw.
5114         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5115         throw_exception with throw.
5116         * eval.c (fetch_subexp_value, evaluate_var_value)
5117         (evaluate_funcall, evaluate_subexp_standard): Replace
5118         throw_exception with throw.
5119         * dwarf2loc.c (call_site_find_chain)
5120         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5121         Replace throw_exception with throw.
5122         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5123         with throw.
5124         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5125         throw.
5126         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5127         * completer.c (complete_line_internal): Replace throw_exception
5128         with throw.
5129         * compile/compile-object-run.c (compile_object_run): Replace
5130         throw_exception with throw.
5131         * cli/cli-script.c (process_next_line): Replace throw_exception
5132         with throw.
5133         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5134         (btrace_enable, btrace_maint_update_pt_packets): Replace
5135         throw_exception with throw.
5136         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5137         throw_exception with throw.
5138         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5139         throw_exception with throw.
5140         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5141         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5142         * aarch64-tdep.c (aarch64_make_prologue_cache)
5143         (aarch64_make_stub_cache): Replace throw_exception with throw.
5144
5145 2019-04-08  Tom Tromey  <tom@tromey.com>
5146
5147         * common/common-exceptions.c (throw_exception): Rename from
5148         throw_exception_cxx.  Remove old copy.  Make argument const.
5149         (throw_it): Create and throw exception objects directly.
5150         * common/common-exceptions.h (throw_exception): Make argument
5151         const.
5152         (struct gdb_exception_error): Add constructor.
5153         (struct gdb_exception_quit): Add constructor.
5154
5155 2019-04-08  Tom Tromey  <tom@tromey.com>
5156
5157         * common/common-exceptions.h (exception_rethrow): Don't declare.
5158         (TRY_SJLJ): Update comment.
5159         (TRY, CATCH, END_CATCH): Remove.
5160         * common/common-exceptions.c (exception_rethrow): Remove.
5161
5162 2019-04-08  Tom Tromey  <tom@tromey.com>
5163
5164         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5165         Remove.
5166         (gdb_exception_error): Rename from
5167         gdb_exception_RETURN_MASK_ERROR.
5168         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5169         (gdb_quit_bad_alloc): Update.
5170         * aarch64-tdep.c: Update.
5171         * ada-lang.c: Update.
5172         * ada-typeprint.c: Update.
5173         * ada-valprint.c: Update.
5174         * amd64-tdep.c: Update.
5175         * arch-utils.c: Update.
5176         * break-catch-throw.c: Update.
5177         * breakpoint.c: Update.
5178         * btrace.c: Update.
5179         * c-varobj.c: Update.
5180         * cli/cli-cmds.c: Update.
5181         * cli/cli-interp.c: Update.
5182         * cli/cli-script.c: Update.
5183         * common/common-exceptions.c: Update.
5184         * common/new-op.c: Update.
5185         * common/selftest.c: Update.
5186         * compile/compile-c-symbols.c: Update.
5187         * compile/compile-cplus-symbols.c: Update.
5188         * compile/compile-object-load.c: Update.
5189         * compile/compile-object-run.c: Update.
5190         * completer.c: Update.
5191         * corelow.c: Update.
5192         * cp-abi.c: Update.
5193         * cp-support.c: Update.
5194         * cp-valprint.c: Update.
5195         * darwin-nat.c: Update.
5196         * disasm-selftests.c: Update.
5197         * dtrace-probe.c: Update.
5198         * dwarf-index-cache.c: Update.
5199         * dwarf-index-write.c: Update.
5200         * dwarf2-frame-tailcall.c: Update.
5201         * dwarf2-frame.c: Update.
5202         * dwarf2loc.c: Update.
5203         * dwarf2read.c: Update.
5204         * eval.c: Update.
5205         * event-loop.c: Update.
5206         * event-top.c: Update.
5207         * exec.c: Update.
5208         * f-valprint.c: Update.
5209         * fbsd-tdep.c: Update.
5210         * frame-unwind.c: Update.
5211         * frame.c: Update.
5212         * gdbtypes.c: Update.
5213         * gnu-v3-abi.c: Update.
5214         * guile/guile-internal.h: Update.
5215         * guile/scm-block.c: Update.
5216         * guile/scm-breakpoint.c: Update.
5217         * guile/scm-cmd.c: Update.
5218         * guile/scm-disasm.c: Update.
5219         * guile/scm-frame.c: Update.
5220         * guile/scm-lazy-string.c: Update.
5221         * guile/scm-math.c: Update.
5222         * guile/scm-param.c: Update.
5223         * guile/scm-ports.c: Update.
5224         * guile/scm-pretty-print.c: Update.
5225         * guile/scm-symbol.c: Update.
5226         * guile/scm-symtab.c: Update.
5227         * guile/scm-type.c: Update.
5228         * guile/scm-value.c: Update.
5229         * i386-linux-tdep.c: Update.
5230         * i386-tdep.c: Update.
5231         * inf-loop.c: Update.
5232         * infcall.c: Update.
5233         * infcmd.c: Update.
5234         * infrun.c: Update.
5235         * jit.c: Update.
5236         * language.c: Update.
5237         * linespec.c: Update.
5238         * linux-fork.c: Update.
5239         * linux-nat.c: Update.
5240         * linux-tdep.c: Update.
5241         * linux-thread-db.c: Update.
5242         * main.c: Update.
5243         * mi/mi-cmd-break.c: Update.
5244         * mi/mi-cmd-stack.c: Update.
5245         * mi/mi-interp.c: Update.
5246         * mi/mi-main.c: Update.
5247         * objc-lang.c: Update.
5248         * p-valprint.c: Update.
5249         * parse.c: Update.
5250         * ppc-linux-tdep.c: Update.
5251         * printcmd.c: Update.
5252         * python/py-arch.c: Update.
5253         * python/py-breakpoint.c: Update.
5254         * python/py-cmd.c: Update.
5255         * python/py-finishbreakpoint.c: Update.
5256         * python/py-frame.c: Update.
5257         * python/py-framefilter.c: Update.
5258         * python/py-gdb-readline.c: Update.
5259         * python/py-inferior.c: Update.
5260         * python/py-infthread.c: Update.
5261         * python/py-lazy-string.c: Update.
5262         * python/py-linetable.c: Update.
5263         * python/py-objfile.c: Update.
5264         * python/py-param.c: Update.
5265         * python/py-prettyprint.c: Update.
5266         * python/py-progspace.c: Update.
5267         * python/py-record-btrace.c: Update.
5268         * python/py-record.c: Update.
5269         * python/py-symbol.c: Update.
5270         * python/py-type.c: Update.
5271         * python/py-unwind.c: Update.
5272         * python/py-utils.c: Update.
5273         * python/py-value.c: Update.
5274         * python/python.c: Update.
5275         * record-btrace.c: Update.
5276         * record-full.c: Update.
5277         * remote-fileio.c: Update.
5278         * remote.c: Update.
5279         * riscv-tdep.c: Update.
5280         * rs6000-aix-tdep.c: Update.
5281         * rs6000-tdep.c: Update.
5282         * rust-exp.y: Update.
5283         * rust-lang.c: Update.
5284         * s390-tdep.c: Update.
5285         * selftest-arch.c: Update.
5286         * solib-dsbt.c: Update.
5287         * solib-frv.c: Update.
5288         * solib-spu.c: Update.
5289         * solib-svr4.c: Update.
5290         * solib.c: Update.
5291         * sparc64-linux-tdep.c: Update.
5292         * stack.c: Update.
5293         * symfile-mem.c: Update.
5294         * symmisc.c: Update.
5295         * target.c: Update.
5296         * thread.c: Update.
5297         * top.c: Update.
5298         * tracefile-tfile.c: Update.
5299         * tui/tui.c: Update.
5300         * typeprint.c: Update.
5301         * unittests/cli-utils-selftests.c: Update.
5302         * unittests/parse-connection-spec-selftests.c: Update.
5303         * valops.c: Update.
5304         * valprint.c: Update.
5305         * value.c: Update.
5306         * varobj.c: Update.
5307         * windows-nat.c: Update.
5308         * x86-linux-nat.c: Update.
5309         * xml-support.c: Update.
5310
5311 2019-04-08  Tom Tromey  <tom@tromey.com>
5312
5313         * xml-support.c: Use C++ exception handling.
5314         * x86-linux-nat.c: Use C++ exception handling.
5315         * windows-nat.c: Use C++ exception handling.
5316         * varobj.c: Use C++ exception handling.
5317         * value.c: Use C++ exception handling.
5318         * valprint.c: Use C++ exception handling.
5319         * valops.c: Use C++ exception handling.
5320         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5321         handling.
5322         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5323         * typeprint.c: Use C++ exception handling.
5324         * tui/tui.c: Use C++ exception handling.
5325         * tracefile-tfile.c: Use C++ exception handling.
5326         * top.c: Use C++ exception handling.
5327         * thread.c: Use C++ exception handling.
5328         * target.c: Use C++ exception handling.
5329         * symmisc.c: Use C++ exception handling.
5330         * symfile-mem.c: Use C++ exception handling.
5331         * stack.c: Use C++ exception handling.
5332         * sparc64-linux-tdep.c: Use C++ exception handling.
5333         * solib.c: Use C++ exception handling.
5334         * solib-svr4.c: Use C++ exception handling.
5335         * solib-spu.c: Use C++ exception handling.
5336         * solib-frv.c: Use C++ exception handling.
5337         * solib-dsbt.c: Use C++ exception handling.
5338         * selftest-arch.c: Use C++ exception handling.
5339         * s390-tdep.c: Use C++ exception handling.
5340         * rust-lang.c: Use C++ exception handling.
5341         * rust-exp.y: Use C++ exception handling.
5342         * rs6000-tdep.c: Use C++ exception handling.
5343         * rs6000-aix-tdep.c: Use C++ exception handling.
5344         * riscv-tdep.c: Use C++ exception handling.
5345         * remote.c: Use C++ exception handling.
5346         * remote-fileio.c: Use C++ exception handling.
5347         * record-full.c: Use C++ exception handling.
5348         * record-btrace.c: Use C++ exception handling.
5349         * python/python.c: Use C++ exception handling.
5350         * python/py-value.c: Use C++ exception handling.
5351         * python/py-utils.c: Use C++ exception handling.
5352         * python/py-unwind.c: Use C++ exception handling.
5353         * python/py-type.c: Use C++ exception handling.
5354         * python/py-symbol.c: Use C++ exception handling.
5355         * python/py-record.c: Use C++ exception handling.
5356         * python/py-record-btrace.c: Use C++ exception handling.
5357         * python/py-progspace.c: Use C++ exception handling.
5358         * python/py-prettyprint.c: Use C++ exception handling.
5359         * python/py-param.c: Use C++ exception handling.
5360         * python/py-objfile.c: Use C++ exception handling.
5361         * python/py-linetable.c: Use C++ exception handling.
5362         * python/py-lazy-string.c: Use C++ exception handling.
5363         * python/py-infthread.c: Use C++ exception handling.
5364         * python/py-inferior.c: Use C++ exception handling.
5365         * python/py-gdb-readline.c: Use C++ exception handling.
5366         * python/py-framefilter.c: Use C++ exception handling.
5367         * python/py-frame.c: Use C++ exception handling.
5368         * python/py-finishbreakpoint.c: Use C++ exception handling.
5369         * python/py-cmd.c: Use C++ exception handling.
5370         * python/py-breakpoint.c: Use C++ exception handling.
5371         * python/py-arch.c: Use C++ exception handling.
5372         * printcmd.c: Use C++ exception handling.
5373         * ppc-linux-tdep.c: Use C++ exception handling.
5374         * parse.c: Use C++ exception handling.
5375         * p-valprint.c: Use C++ exception handling.
5376         * objc-lang.c: Use C++ exception handling.
5377         * mi/mi-main.c: Use C++ exception handling.
5378         * mi/mi-interp.c: Use C++ exception handling.
5379         * mi/mi-cmd-stack.c: Use C++ exception handling.
5380         * mi/mi-cmd-break.c: Use C++ exception handling.
5381         * main.c: Use C++ exception handling.
5382         * linux-thread-db.c: Use C++ exception handling.
5383         * linux-tdep.c: Use C++ exception handling.
5384         * linux-nat.c: Use C++ exception handling.
5385         * linux-fork.c: Use C++ exception handling.
5386         * linespec.c: Use C++ exception handling.
5387         * language.c: Use C++ exception handling.
5388         * jit.c: Use C++ exception handling.
5389         * infrun.c: Use C++ exception handling.
5390         * infcmd.c: Use C++ exception handling.
5391         * infcall.c: Use C++ exception handling.
5392         * inf-loop.c: Use C++ exception handling.
5393         * i386-tdep.c: Use C++ exception handling.
5394         * i386-linux-tdep.c: Use C++ exception handling.
5395         * guile/scm-value.c: Use C++ exception handling.
5396         * guile/scm-type.c: Use C++ exception handling.
5397         * guile/scm-symtab.c: Use C++ exception handling.
5398         * guile/scm-symbol.c: Use C++ exception handling.
5399         * guile/scm-pretty-print.c: Use C++ exception handling.
5400         * guile/scm-ports.c: Use C++ exception handling.
5401         * guile/scm-param.c: Use C++ exception handling.
5402         * guile/scm-math.c: Use C++ exception handling.
5403         * guile/scm-lazy-string.c: Use C++ exception handling.
5404         * guile/scm-frame.c: Use C++ exception handling.
5405         * guile/scm-disasm.c: Use C++ exception handling.
5406         * guile/scm-cmd.c: Use C++ exception handling.
5407         * guile/scm-breakpoint.c: Use C++ exception handling.
5408         * guile/scm-block.c: Use C++ exception handling.
5409         * guile/guile-internal.h: Use C++ exception handling.
5410         * gnu-v3-abi.c: Use C++ exception handling.
5411         * gdbtypes.c: Use C++ exception handling.
5412         * frame.c: Use C++ exception handling.
5413         * frame-unwind.c: Use C++ exception handling.
5414         * fbsd-tdep.c: Use C++ exception handling.
5415         * f-valprint.c: Use C++ exception handling.
5416         * exec.c: Use C++ exception handling.
5417         * event-top.c: Use C++ exception handling.
5418         * event-loop.c: Use C++ exception handling.
5419         * eval.c: Use C++ exception handling.
5420         * dwarf2read.c: Use C++ exception handling.
5421         * dwarf2loc.c: Use C++ exception handling.
5422         * dwarf2-frame.c: Use C++ exception handling.
5423         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5424         * dwarf-index-write.c: Use C++ exception handling.
5425         * dwarf-index-cache.c: Use C++ exception handling.
5426         * dtrace-probe.c: Use C++ exception handling.
5427         * disasm-selftests.c: Use C++ exception handling.
5428         * darwin-nat.c: Use C++ exception handling.
5429         * cp-valprint.c: Use C++ exception handling.
5430         * cp-support.c: Use C++ exception handling.
5431         * cp-abi.c: Use C++ exception handling.
5432         * corelow.c: Use C++ exception handling.
5433         * completer.c: Use C++ exception handling.
5434         * compile/compile-object-run.c: Use C++ exception handling.
5435         * compile/compile-object-load.c: Use C++ exception handling.
5436         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5437         * compile/compile-c-symbols.c: Use C++ exception handling.
5438         * common/selftest.c: Use C++ exception handling.
5439         * common/new-op.c: Use C++ exception handling.
5440         * cli/cli-script.c: Use C++ exception handling.
5441         * cli/cli-interp.c: Use C++ exception handling.
5442         * cli/cli-cmds.c: Use C++ exception handling.
5443         * c-varobj.c: Use C++ exception handling.
5444         * btrace.c: Use C++ exception handling.
5445         * breakpoint.c: Use C++ exception handling.
5446         * break-catch-throw.c: Use C++ exception handling.
5447         * arch-utils.c: Use C++ exception handling.
5448         * amd64-tdep.c: Use C++ exception handling.
5449         * ada-valprint.c: Use C++ exception handling.
5450         * ada-typeprint.c: Use C++ exception handling.
5451         * ada-lang.c: Use C++ exception handling.
5452         * aarch64-tdep.c: Use C++ exception handling.
5453
5454 2019-04-08  Tom Tromey  <tom@tromey.com>
5455
5456         * xml-support.c (gdb_xml_parser::parse): Update.
5457         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5458         * value.c (show_convenience): Update.
5459         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5460         (test_parse_flags_qcs): Update.
5461         * thread.c (thr_try_catch_cmd): Update.
5462         * target.c (target_translate_tls_address): Update.
5463         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5464         (info_frame_command_core, frame_apply_command_count): Update.
5465         * rust-exp.y (rust_lex_exception_test): Update.
5466         * riscv-tdep.c (riscv_print_one_register_info): Update.
5467         * remote.c (remote_target::enable_btrace): Update.
5468         * record-btrace.c (record_btrace_enable_warn): Update.
5469         * python/py-utils.c (gdbpy_convert_exception): Update.
5470         * printcmd.c (do_one_display, print_variable_and_value): Update.
5471         * mi/mi-main.c (mi_print_exception): Update.
5472         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5473         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5474         * linux-nat.c (linux_nat_target::attach): Update.
5475         * linux-fork.c (class scoped_switch_fork_info): Update.
5476         * infrun.c (displaced_step_prepare): Update.
5477         * infcall.c (call_function_by_hand_dummy): Update.
5478         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5479         * gnu-v3-abi.c (print_one_vtable): Update.
5480         * frame.c (get_prev_frame_always): Update.
5481         * f-valprint.c (info_common_command_for_block): Update.
5482         * exec.c (try_open_exec_file): Update.
5483         * exceptions.c (print_exception, exception_print)
5484         (exception_fprintf, exception_print_same): Update.
5485         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5486         * dwarf-index-cache.c (index_cache::store)
5487         (index_cache::lookup_gdb_index): Update.
5488         * darwin-nat.c (maybe_cache_shell): Update.
5489         * cp-valprint.c (cp_print_value_fields): Update.
5490         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5491         (gcc_cplus_symbol_address): Update.
5492         * compile/compile-c-symbols.c (gcc_convert_symbol)
5493         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5494         * common/selftest.c: Update.
5495         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5496         a std::string.
5497         (exception_try_scope_entry, exception_try_scope_exit): Don't
5498         declare.
5499         (struct exception_try_scope): Remove.
5500         (TRY): Don't use exception_try_scope.
5501         (struct gdb_exception): Add constructor, operator=.
5502         <what>: New method.
5503         (struct gdb_exception_RETURN_MASK_ALL)
5504         (struct gdb_exception_RETURN_MASK_ERROR)
5505         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5506         (struct gdb_quit_bad_alloc): Update.
5507         * common/common-exceptions.c (exception_none): Change
5508         initializer.
5509         (struct catcher) <state, exception>: Initialize inline.
5510         <prev>: Remove member.
5511         (current_catcher): Remove.
5512         (catchers): New global.
5513         (exceptions_state_mc_init): Simplify.
5514         (catcher_pop): Remove.
5515         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5516         (try_scope_depth, exception_try_scope_entry)
5517         (exception_try_scope_exit): Remove.
5518         (throw_exception_sjlj): Update.
5519         (exception_messages, exception_messages_size): Remove.
5520         (throw_it): Simplify.
5521         (gdb_exception_sliced_copy): Remove.
5522         (throw_exception_cxx): Update.
5523         * cli/cli-script.c (script_from_file): Update.
5524         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5525         Update.
5526         * ada-valprint.c (ada_val_print): Update.
5527         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5528         (create_excep_cond_exprs): Update.
5529
5530 2019-04-08  Tom Tromey  <tom@tromey.com>
5531
5532         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5533         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5534         (TRY, CATCH, END_CATCH): Remove some definitions.
5535         * common/common-exceptions.c: Don't use GDB_XCPT.
5536         (catcher_list_size): Remove.
5537         (throw_exception, throw_it): Simplify.
5538
5539 2019-04-05  Tom Tromey  <tom@tromey.com>
5540
5541         Revert the header-sorting patch.
5542         * ft32-tdep.c: Revert.
5543         * frv-tdep.c: Revert.
5544         * frv-linux-tdep.c: Revert.
5545         * frame.c: Revert.
5546         * frame-unwind.c: Revert.
5547         * frame-base.c: Revert.
5548         * fork-child.c: Revert.
5549         * findvar.c: Revert.
5550         * findcmd.c: Revert.
5551         * filesystem.c: Revert.
5552         * filename-seen-cache.h: Revert.
5553         * filename-seen-cache.c: Revert.
5554         * fbsd-tdep.c: Revert.
5555         * fbsd-nat.h: Revert.
5556         * fbsd-nat.c: Revert.
5557         * f-valprint.c: Revert.
5558         * f-typeprint.c: Revert.
5559         * f-lang.c: Revert.
5560         * extension.h: Revert.
5561         * extension.c: Revert.
5562         * extension-priv.h: Revert.
5563         * expprint.c: Revert.
5564         * exec.h: Revert.
5565         * exec.c: Revert.
5566         * exceptions.c: Revert.
5567         * event-top.c: Revert.
5568         * event-loop.c: Revert.
5569         * eval.c: Revert.
5570         * elfread.c: Revert.
5571         * dwarf2read.h: Revert.
5572         * dwarf2read.c: Revert.
5573         * dwarf2loc.c: Revert.
5574         * dwarf2expr.h: Revert.
5575         * dwarf2expr.c: Revert.
5576         * dwarf2-frame.c: Revert.
5577         * dwarf2-frame-tailcall.c: Revert.
5578         * dwarf-index-write.h: Revert.
5579         * dwarf-index-write.c: Revert.
5580         * dwarf-index-common.c: Revert.
5581         * dwarf-index-cache.h: Revert.
5582         * dwarf-index-cache.c: Revert.
5583         * dummy-frame.c: Revert.
5584         * dtrace-probe.c: Revert.
5585         * disasm.h: Revert.
5586         * disasm.c: Revert.
5587         * disasm-selftests.c: Revert.
5588         * dictionary.c: Revert.
5589         * dicos-tdep.c: Revert.
5590         * demangle.c: Revert.
5591         * dcache.h: Revert.
5592         * dcache.c: Revert.
5593         * darwin-nat.h: Revert.
5594         * darwin-nat.c: Revert.
5595         * darwin-nat-info.c: Revert.
5596         * d-valprint.c: Revert.
5597         * d-namespace.c: Revert.
5598         * d-lang.c: Revert.
5599         * ctf.c: Revert.
5600         * csky-tdep.c: Revert.
5601         * csky-linux-tdep.c: Revert.
5602         * cris-tdep.c: Revert.
5603         * cris-linux-tdep.c: Revert.
5604         * cp-valprint.c: Revert.
5605         * cp-support.c: Revert.
5606         * cp-namespace.c: Revert.
5607         * cp-abi.c: Revert.
5608         * corelow.c: Revert.
5609         * corefile.c: Revert.
5610         * continuations.c: Revert.
5611         * completer.h: Revert.
5612         * completer.c: Revert.
5613         * complaints.c: Revert.
5614         * coffread.c: Revert.
5615         * coff-pe-read.c: Revert.
5616         * cli-out.h: Revert.
5617         * cli-out.c: Revert.
5618         * charset.c: Revert.
5619         * c-varobj.c: Revert.
5620         * c-valprint.c: Revert.
5621         * c-typeprint.c: Revert.
5622         * c-lang.c: Revert.
5623         * buildsym.c: Revert.
5624         * buildsym-legacy.c: Revert.
5625         * build-id.h: Revert.
5626         * build-id.c: Revert.
5627         * btrace.c: Revert.
5628         * bsd-uthread.c: Revert.
5629         * breakpoint.h: Revert.
5630         * breakpoint.c: Revert.
5631         * break-catch-throw.c: Revert.
5632         * break-catch-syscall.c: Revert.
5633         * break-catch-sig.c: Revert.
5634         * blockframe.c: Revert.
5635         * block.c: Revert.
5636         * bfin-tdep.c: Revert.
5637         * bfin-linux-tdep.c: Revert.
5638         * bfd-target.c: Revert.
5639         * bcache.c: Revert.
5640         * ax-general.c: Revert.
5641         * ax-gdb.h: Revert.
5642         * ax-gdb.c: Revert.
5643         * avr-tdep.c: Revert.
5644         * auxv.c: Revert.
5645         * auto-load.c: Revert.
5646         * arm-wince-tdep.c: Revert.
5647         * arm-tdep.c: Revert.
5648         * arm-symbian-tdep.c: Revert.
5649         * arm-pikeos-tdep.c: Revert.
5650         * arm-obsd-tdep.c: Revert.
5651         * arm-nbsd-tdep.c: Revert.
5652         * arm-nbsd-nat.c: Revert.
5653         * arm-linux-tdep.c: Revert.
5654         * arm-linux-nat.c: Revert.
5655         * arm-fbsd-tdep.c: Revert.
5656         * arm-fbsd-nat.c: Revert.
5657         * arm-bsd-tdep.c: Revert.
5658         * arch-utils.c: Revert.
5659         * arc-tdep.c: Revert.
5660         * arc-newlib-tdep.c: Revert.
5661         * annotate.h: Revert.
5662         * annotate.c: Revert.
5663         * amd64-windows-tdep.c: Revert.
5664         * amd64-windows-nat.c: Revert.
5665         * amd64-tdep.c: Revert.
5666         * amd64-sol2-tdep.c: Revert.
5667         * amd64-obsd-tdep.c: Revert.
5668         * amd64-obsd-nat.c: Revert.
5669         * amd64-nbsd-tdep.c: Revert.
5670         * amd64-nbsd-nat.c: Revert.
5671         * amd64-nat.c: Revert.
5672         * amd64-linux-tdep.c: Revert.
5673         * amd64-linux-nat.c: Revert.
5674         * amd64-fbsd-tdep.c: Revert.
5675         * amd64-fbsd-nat.c: Revert.
5676         * amd64-dicos-tdep.c: Revert.
5677         * amd64-darwin-tdep.c: Revert.
5678         * amd64-bsd-nat.c: Revert.
5679         * alpha-tdep.c: Revert.
5680         * alpha-obsd-tdep.c: Revert.
5681         * alpha-nbsd-tdep.c: Revert.
5682         * alpha-mdebug-tdep.c: Revert.
5683         * alpha-linux-tdep.c: Revert.
5684         * alpha-linux-nat.c: Revert.
5685         * alpha-bsd-tdep.c: Revert.
5686         * alpha-bsd-nat.c: Revert.
5687         * aix-thread.c: Revert.
5688         * agent.c: Revert.
5689         * addrmap.c: Revert.
5690         * ada-varobj.c: Revert.
5691         * ada-valprint.c: Revert.
5692         * ada-typeprint.c: Revert.
5693         * ada-tasks.c: Revert.
5694         * ada-lang.c: Revert.
5695         * aarch64-tdep.c: Revert.
5696         * aarch64-ravenscar-thread.c: Revert.
5697         * aarch64-newlib-tdep.c: Revert.
5698         * aarch64-linux-tdep.c: Revert.
5699         * aarch64-linux-nat.c: Revert.
5700         * aarch64-fbsd-tdep.c: Revert.
5701         * aarch64-fbsd-nat.c: Revert.
5702         * aarch32-linux-nat.c: Revert.
5703
5704 2019-04-05  Tom Tromey  <tom@tromey.com>
5705
5706         * ft32-tdep.c: Sort headers.
5707         * frv-tdep.c: Sort headers.
5708         * frv-linux-tdep.c: Sort headers.
5709         * frame.c: Sort headers.
5710         * frame-unwind.c: Sort headers.
5711         * frame-base.c: Sort headers.
5712         * fork-child.c: Sort headers.
5713         * findvar.c: Sort headers.
5714         * findcmd.c: Sort headers.
5715         * filesystem.c: Sort headers.
5716         * filename-seen-cache.h: Sort headers.
5717         * filename-seen-cache.c: Sort headers.
5718         * fbsd-tdep.c: Sort headers.
5719         * fbsd-nat.h: Sort headers.
5720         * fbsd-nat.c: Sort headers.
5721         * f-valprint.c: Sort headers.
5722         * f-typeprint.c: Sort headers.
5723         * f-lang.c: Sort headers.
5724         * extension.h: Sort headers.
5725         * extension.c: Sort headers.
5726         * extension-priv.h: Sort headers.
5727         * expprint.c: Sort headers.
5728         * exec.h: Sort headers.
5729         * exec.c: Sort headers.
5730         * exceptions.c: Sort headers.
5731         * event-top.c: Sort headers.
5732         * event-loop.c: Sort headers.
5733         * eval.c: Sort headers.
5734         * elfread.c: Sort headers.
5735         * dwarf2read.h: Sort headers.
5736         * dwarf2read.c: Sort headers.
5737         * dwarf2loc.c: Sort headers.
5738         * dwarf2expr.h: Sort headers.
5739         * dwarf2expr.c: Sort headers.
5740         * dwarf2-frame.c: Sort headers.
5741         * dwarf2-frame-tailcall.c: Sort headers.
5742         * dwarf-index-write.h: Sort headers.
5743         * dwarf-index-write.c: Sort headers.
5744         * dwarf-index-common.c: Sort headers.
5745         * dwarf-index-cache.h: Sort headers.
5746         * dwarf-index-cache.c: Sort headers.
5747         * dummy-frame.c: Sort headers.
5748         * dtrace-probe.c: Sort headers.
5749         * disasm.h: Sort headers.
5750         * disasm.c: Sort headers.
5751         * disasm-selftests.c: Sort headers.
5752         * dictionary.c: Sort headers.
5753         * dicos-tdep.c: Sort headers.
5754         * demangle.c: Sort headers.
5755         * dcache.h: Sort headers.
5756         * dcache.c: Sort headers.
5757         * darwin-nat.h: Sort headers.
5758         * darwin-nat.c: Sort headers.
5759         * darwin-nat-info.c: Sort headers.
5760         * d-valprint.c: Sort headers.
5761         * d-namespace.c: Sort headers.
5762         * d-lang.c: Sort headers.
5763         * ctf.c: Sort headers.
5764         * csky-tdep.c: Sort headers.
5765         * csky-linux-tdep.c: Sort headers.
5766         * cris-tdep.c: Sort headers.
5767         * cris-linux-tdep.c: Sort headers.
5768         * cp-valprint.c: Sort headers.
5769         * cp-support.c: Sort headers.
5770         * cp-namespace.c: Sort headers.
5771         * cp-abi.c: Sort headers.
5772         * corelow.c: Sort headers.
5773         * corefile.c: Sort headers.
5774         * continuations.c: Sort headers.
5775         * completer.h: Sort headers.
5776         * completer.c: Sort headers.
5777         * complaints.c: Sort headers.
5778         * coffread.c: Sort headers.
5779         * coff-pe-read.c: Sort headers.
5780         * cli-out.h: Sort headers.
5781         * cli-out.c: Sort headers.
5782         * charset.c: Sort headers.
5783         * c-varobj.c: Sort headers.
5784         * c-valprint.c: Sort headers.
5785         * c-typeprint.c: Sort headers.
5786         * c-lang.c: Sort headers.
5787         * buildsym.c: Sort headers.
5788         * buildsym-legacy.c: Sort headers.
5789         * build-id.h: Sort headers.
5790         * build-id.c: Sort headers.
5791         * btrace.c: Sort headers.
5792         * bsd-uthread.c: Sort headers.
5793         * breakpoint.h: Sort headers.
5794         * breakpoint.c: Sort headers.
5795         * break-catch-throw.c: Sort headers.
5796         * break-catch-syscall.c: Sort headers.
5797         * break-catch-sig.c: Sort headers.
5798         * blockframe.c: Sort headers.
5799         * block.c: Sort headers.
5800         * bfin-tdep.c: Sort headers.
5801         * bfin-linux-tdep.c: Sort headers.
5802         * bfd-target.c: Sort headers.
5803         * bcache.c: Sort headers.
5804         * ax-general.c: Sort headers.
5805         * ax-gdb.h: Sort headers.
5806         * ax-gdb.c: Sort headers.
5807         * avr-tdep.c: Sort headers.
5808         * auxv.c: Sort headers.
5809         * auto-load.c: Sort headers.
5810         * arm-wince-tdep.c: Sort headers.
5811         * arm-tdep.c: Sort headers.
5812         * arm-symbian-tdep.c: Sort headers.
5813         * arm-pikeos-tdep.c: Sort headers.
5814         * arm-obsd-tdep.c: Sort headers.
5815         * arm-nbsd-tdep.c: Sort headers.
5816         * arm-nbsd-nat.c: Sort headers.
5817         * arm-linux-tdep.c: Sort headers.
5818         * arm-linux-nat.c: Sort headers.
5819         * arm-fbsd-tdep.c: Sort headers.
5820         * arm-fbsd-nat.c: Sort headers.
5821         * arm-bsd-tdep.c: Sort headers.
5822         * arch-utils.c: Sort headers.
5823         * arc-tdep.c: Sort headers.
5824         * arc-newlib-tdep.c: Sort headers.
5825         * annotate.h: Sort headers.
5826         * annotate.c: Sort headers.
5827         * amd64-windows-tdep.c: Sort headers.
5828         * amd64-windows-nat.c: Sort headers.
5829         * amd64-tdep.c: Sort headers.
5830         * amd64-sol2-tdep.c: Sort headers.
5831         * amd64-obsd-tdep.c: Sort headers.
5832         * amd64-obsd-nat.c: Sort headers.
5833         * amd64-nbsd-tdep.c: Sort headers.
5834         * amd64-nbsd-nat.c: Sort headers.
5835         * amd64-nat.c: Sort headers.
5836         * amd64-linux-tdep.c: Sort headers.
5837         * amd64-linux-nat.c: Sort headers.
5838         * amd64-fbsd-tdep.c: Sort headers.
5839         * amd64-fbsd-nat.c: Sort headers.
5840         * amd64-dicos-tdep.c: Sort headers.
5841         * amd64-darwin-tdep.c: Sort headers.
5842         * amd64-bsd-nat.c: Sort headers.
5843         * alpha-tdep.c: Sort headers.
5844         * alpha-obsd-tdep.c: Sort headers.
5845         * alpha-nbsd-tdep.c: Sort headers.
5846         * alpha-mdebug-tdep.c: Sort headers.
5847         * alpha-linux-tdep.c: Sort headers.
5848         * alpha-linux-nat.c: Sort headers.
5849         * alpha-bsd-tdep.c: Sort headers.
5850         * alpha-bsd-nat.c: Sort headers.
5851         * aix-thread.c: Sort headers.
5852         * agent.c: Sort headers.
5853         * addrmap.c: Sort headers.
5854         * ada-varobj.c: Sort headers.
5855         * ada-valprint.c: Sort headers.
5856         * ada-typeprint.c: Sort headers.
5857         * ada-tasks.c: Sort headers.
5858         * ada-lang.c: Sort headers.
5859         * aarch64-tdep.c: Sort headers.
5860         * aarch64-ravenscar-thread.c: Sort headers.
5861         * aarch64-newlib-tdep.c: Sort headers.
5862         * aarch64-linux-tdep.c: Sort headers.
5863         * aarch64-linux-nat.c: Sort headers.
5864         * aarch64-fbsd-tdep.c: Sort headers.
5865         * aarch64-fbsd-nat.c: Sort headers.
5866         * aarch32-linux-nat.c: Sort headers.
5867
5868 2019-04-04  Tom Tromey  <tom@tromey.com>
5869
5870         * varobj.c (varobj_create): Update.
5871         * rust-exp.y (struct rust_parser) <update_innermost_block,
5872         lookup_symbol>: New methods.
5873         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5874         Rename.
5875         (rust_parser::rust_lookup_type)
5876         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5877         * printcmd.c (display_command, do_one_display): Update.
5878         * parser-defs.h (struct parser_state) <parser_state>: Add
5879         "tracker" parameter.
5880         (block_tracker): New member.
5881         (class innermost_block_tracker) <innermost_block_tracker>: Add
5882         "types" parameter.
5883         <reset>: Remove method.
5884         (innermost_block): Don't declare.
5885         (null_post_parser): Update.
5886         * parse.c (innermost_block): Remove global.
5887         (write_dollar_variable): Update.
5888         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5889         Remove "tracker_types" parameter.
5890         (parse_expression): Add "tracker" parameter.
5891         (parse_expression_for_completion): Update.
5892         (null_post_parser): Add "tracker" parameter.
5893         * p-exp.y: Update rules.
5894         * m2-exp.y: Update rules.
5895         * language.h (struct language_defn) <la_post_parser>: Add
5896         "tracker" parameter.
5897         * go-exp.y: Update rules.
5898         * f-exp.y: Update rules.
5899         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5900         parameter.
5901         * d-exp.y: Update rules.
5902         * c-exp.y: Update rules.
5903         * breakpoint.c (set_breakpoint_condition): Create an
5904         innermost_block_tracker.
5905         (watch_command_1): Likewise.
5906         * ada-lang.c (resolve): Add "tracker" parameter.
5907         (resolve_subexp): Likewise.
5908         * ada-exp.y (write_var_from_sym): Update.
5909
5910 2019-04-04  Tom Tromey  <tom@tromey.com>
5911
5912         * type-stack.h: New file.
5913         * type-stack.c: New file.
5914         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5915         type-stack.h.
5916         (insert_into_type_stack, insert_type, push_type, push_type_int)
5917         (insert_type_address_space, pop_type, pop_type_int)
5918         (pop_typelist, pop_type_stack, append_type_stack)
5919         (push_type_stack, get_type_stack, push_typelist)
5920         (follow_type_instance_flags, follow_types): Don't declare.
5921         * parse.c (type_stack): Remove global.
5922         (parse_exp_in_context): Update.
5923         (insert_into_type_stack, insert_type, push_type, push_type_int)
5924         (insert_type_address_space, pop_type, pop_type_int)
5925         (pop_typelist, pop_type_stack, append_type_stack)
5926         (push_type_stack, get_type_stack, push_typelist)
5927         (follow_type_instance_flags, follow_types): Remove (moved to
5928         type-stack.c).
5929         * f-exp.y (type_stack): New global.
5930         Update rules.
5931         (push_kind_type, f_parse): Update.
5932         * d-exp.y (type_stack): New global.
5933         Update rules.
5934         (d_parse): Update.
5935         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5936         Update rules.
5937         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5938         (HFILES_NO_SRCDIR): Add type-stack.h.
5939
5940 2019-04-04  Tom Tromey  <tom@tromey.com>
5941
5942         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5943         (rust_parser::convert_ast_to_expression, rust_parse)
5944         (rust_lex_test_completion, rust_lex_tests): Update.
5945         * parser-defs.h (struct expr_completion_state): New.
5946         (struct parser_state) <parser_state>: Add completion parameter.
5947         <mark_struct_expression, mark_completion_tag>: New methods.
5948         <parse_completion, m_completion_state>: New members.
5949         (prefixify_expression, null_post_parser): Update.
5950         (mark_struct_expression, mark_completion_tag): Don't declare.
5951         * parse.c (parse_completion, expout_last_struct)
5952         (expout_tag_completion_type, expout_completion_name): Remove
5953         globals.
5954         (parser_state::mark_struct_expression)
5955         (parser_state::mark_completion_tag): Now methods.
5956         (prefixify_expression): Add last_struct parameter.
5957         (prefixify_subexp): Likewise.
5958         (parse_exp_1): Update.
5959         (parse_exp_in_context): Add cstate parameter.  Update.
5960         (parse_expression_for_completion): Create an
5961         expr_completion_state.
5962         (null_post_parser): Add "completion" parameter.
5963         * p-exp.y: Update rules.
5964         (yylex): Update.
5965         * language.h (struct language_defn) <la_post_parser>: Add
5966         "completing" parameter.
5967         * go-exp.y: Update rules.
5968         (lex_one_token): Update.
5969         * expression.h (parse_completion): Don't declare.
5970         * d-exp.y: Update rules.
5971         (lex_one_token): Update rules.
5972         * c-exp.y: Update rules.
5973         (lex_one_token): Update.
5974         * ada-lang.c (resolve): Add "parse_completion" parameter.
5975         (resolve_subexp): Likewise.
5976         (ada_resolve_function): Likewise.
5977
5978 2019-04-04  Tom Tromey  <tom@tromey.com>
5979
5980         * parser-defs.h (struct parser_state) <start_arglist,
5981         end_arglist>: New methods.
5982         <arglist_len, m_funcall_chain>: New members.
5983         (arglist_len, start_arglist, end_arglist): Don't declare.
5984         * parse.c (arglist_len, funcall_chain): Remove global.
5985         (start_arglist, end_arglist): Remove functions.
5986         (parse_exp_in_context): Update.
5987         * p-exp.y: Update rules.
5988         * m2-exp.y: Update rules.
5989         * go-exp.y: Update rules.
5990         * f-exp.y: Update rules.
5991         * d-exp.y: Update rules.
5992         * c-exp.y: Update rules.
5993
5994 2019-04-04  Tom Tromey  <tom@tromey.com>
5995
5996         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5997         lex_operator, push_back>: New methods.
5998         Update all rules.
5999         (rust_parser::lex_hex, lex_escape): Rename and update.
6000         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6001         (rust_parser::lex_operator): Rename and update.
6002         (rust_parser::lex_number, rustyylex, rustyyerror)
6003         (rust_lex_test_init, rust_lex_test_sequence)
6004         (rust_lex_test_push_back, rust_lex_tests): Update.
6005         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6006         parameter.
6007         <lexptr, prev_lexptr>: New members.
6008         (lexptr, prev_lexptr): Don't declare.
6009         * parse.c (lexptr, prev_lexptr): Remove globals.
6010         (parse_exp_in_context): Update.
6011         * p-exp.y (yylex, yyerror): Update.
6012         * m2-exp.y (parse_number, yylex, yyerror): Update.
6013         * go-exp.y (lex_one_token, yyerror): Update.
6014         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6015         * d-exp.y (lex_one_token, yyerror): Update.
6016         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6017         (lex_one_token, yyerror): Update.
6018         * ada-lex.l (YY_INPUT): Update.
6019         (rewind_to_char): Update.
6020         * ada-exp.y (yyerror): Update.
6021
6022 2019-04-04  Tom Tromey  <tom@tromey.com>
6023
6024         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6025         * parser-defs.h (struct parser_state) <parser_state>: Add new
6026         parameter.
6027         <comma_terminates>: New member.
6028         (comma_terminates): Don't declare global.
6029         * parse.c (comma_terminates): Remove global.
6030         (parse_exp_in_context): Update.
6031         * p-exp.y (yylex): Update.
6032         * m2-exp.y (yylex): Update.
6033         * go-exp.y (lex_one_token): Update.
6034         * f-exp.y (yylex): Update.
6035         * d-exp.y (lex_one_token): Update.
6036         * c-exp.y (lex_one_token): Update.
6037         * ada-lex.l: Update.
6038
6039 2019-04-04  Tom Tromey  <tom@tromey.com>
6040
6041         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6042         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6043         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6044         * parser-defs.h (paren_depth): Don't declare.
6045         * parse.c (paren_depth): Remove global.
6046         (parse_exp_in_context): Update.
6047         * p-exp.y (paren_depth): New global.
6048         (pascal_parse): Initialize it.
6049         * m2-exp.y (paren_depth): New global.
6050         (m2_parse): Initialize it.
6051         * go-exp.y (paren_depth): New global.
6052         (go_parse): Initialize it.
6053         * f-exp.y (paren_depth): New global.
6054         (f_parse): Initialize it.
6055         * d-exp.y (paren_depth): New global.
6056         (d_parse): Initialize it.
6057         * c-exp.y (paren_depth): New global.
6058         (c_parse): Initialize it.
6059         * ada-lex.l (paren_depth): New global.
6060         (lexer_init): Initialize it.
6061
6062 2019-04-04  Tom Tromey  <tom@tromey.com>
6063
6064         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6065         (rust_parser::convert_ast_to_type)
6066         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6067         * parser-defs.h (struct parser_state) <parser_state>: Add
6068         parameters.  Initialize new members.
6069         <expression_context_block, expression_context_pc>: New members.
6070         * parse.c (expression_context_block, expression_context_pc):
6071         Remove globals.
6072         (parse_exp_in_context): Update.
6073         * p-exp.y: Update all rules.
6074         (yylex): Update.
6075         * m2-exp.y: Update all rules.
6076         (yylex): Update.
6077         * go-exp.y (yylex): Update.
6078         * f-exp.y (yylex): Update.
6079         * d-exp.y: Update all rules.
6080         (yylex): Update.
6081         * c-exp.y: Update all rules.
6082         (lex_one_token, classify_name, yylex, c_parse): Update.
6083         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6084
6085 2019-04-04  Tom Tromey  <tom@tromey.com>
6086
6087         * gdbarch.h, gdbarch.c: Rebuild.
6088         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6089         * stap-probe.h:
6090         (struct stap_parse_info): Replace "parser_state" with
6091         "expr_builder".
6092         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6093         (parser_state): New class.
6094         * parse.c (expr_builder): Rename.
6095         (expr_builder::release): Rename.
6096         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6097         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6098         (write_exp_elt_longcst, write_exp_elt_floatcst)
6099         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6100         (write_exp_string_vector, write_exp_bitstring)
6101         (write_exp_msymbol, mark_struct_expression)
6102         (write_dollar_variable)
6103         (insert_type_address_space, increase_expout_size): Replace
6104         "parser_state" with "expr_builder".
6105         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6106         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6107         "parser_state" with "expr_builder".
6108
6109 2019-04-04  Tom Tromey  <tom@tromey.com>
6110
6111         * rust-exp.y: Replace "parse_language" with method call.
6112         * p-exp.y:
6113         (yylex): Replace "parse_language" with method call.
6114         * m2-exp.y:
6115         (yylex): Replace "parse_language" with method call.
6116         * go-exp.y (classify_name): Replace "parse_language" with method
6117         call.
6118         * f-exp.y (yylex): Replace "parse_language" with method call.
6119         * d-exp.y (lex_one_token): Replace "parse_language" with method
6120         call.
6121         * c-exp.y:
6122         (lex_one_token, classify_name, yylex): Replace "parse_language"
6123         with method call.
6124         * ada-exp.y (find_primitive_type, type_char)
6125         (type_system_address): Replace "parse_language" with method call.
6126
6127 2019-04-04  Tom Tromey  <tom@tromey.com>
6128
6129         * rust-exp.y: Replace "parse_gdbarch" with method call.
6130         * parse.c (write_dollar_variable, insert_type_address_space):
6131         Replace "parse_gdbarch" with method call.
6132         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6133         call.
6134         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6135         call.
6136         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6137         "parse_gdbarch" with method call.
6138         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6139         with method call.
6140         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6141         "parse_gdbarch" with method call.
6142         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6143         "parse_gdbarch" with method call.
6144         * c-exp.y (parse_type, parse_number, classify_name): Replace
6145         "parse_gdbarch" with method call.
6146         * ada-lex.l: Replace "parse_gdbarch" with method call.
6147         * ada-exp.y (parse_type, find_primitive_type, type_char)
6148         (type_system_address): Replace "parse_gdbarch" with method call.
6149
6150 2019-04-04  Tom Tromey  <tom@tromey.com>
6151
6152         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6153         * stap-probe.c (stap_parse_argument): Update.
6154         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6155         initial_size parameter.
6156         * rust-exp.y (rust_lex_tests): Update.
6157         * parse.c (parser_state): Update.
6158         (parse_exp_in_context): Update.
6159         * parser-defs.h (struct parser_state) <parser_state>: Remove
6160         "initial_size" parameter.
6161
6162 2019-04-04  Tom Tromey  <tom@tromey.com>
6163
6164         * parser-defs.h (increase_expout_size): Don't declare.
6165         * parse.c (increase_expout_size): Now static.
6166
6167 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6168
6169         * gnu-nat.c (gnu_nat_target::wait): Fix
6170         target_waitstatus_to_string call.
6171
6172 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * eval.c (evaluate_subexp_standard): Handle internal functions
6175         during Fortran function call handling.
6176
6177 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6178
6179         * NEWS: Mention new internal functions.
6180         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6181         (read_base_type): Use dwarf2_init_complex_target_type.
6182         * value.c (creal_internal_fn): New function.
6183         (cimag_internal_fn): New function.
6184         (_initialize_values): Register new internal functions.
6185
6186 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6187
6188         * infrun.c (stop_all_threads): If debug_infrun, always
6189         trace the wait status after wait_one, using
6190         target_waitstatus_to_string and target_pid_to_str.
6191         (handle_inferior_event): Replace various trace of
6192         wait status kind by a single trace.
6193         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6194         wait status kind image by target_waitstatus_to_string.
6195         * target/waitstatus.c (target_waitstatus_to_string): Fix
6196         obsolete comment.
6197
6198 2019-04-01  Tom Tromey  <tromey@adacore.com>
6199
6200         PR symtab/23331:
6201         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6202
6203 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6204             Pedro Alves  <palves@redhat.com>
6205
6206         * top.c (quit_force): Call 'finalize_values'.
6207         * value.c (finalize_values): New function.
6208         * value.h (finalize_values): Declare.
6209
6210 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6211
6212         * NEWS: Announce $_gdb_major and $_gdb_minor.
6213
6214         * top.c (init_gdb_version_vars): New function.
6215         (gdb_init): Call init_gdb_version_vars.
6216
6217 2019-03-29  Tom Tromey  <tromey@adacore.com>
6218
6219         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6220         help text.  Remove dead code.
6221
6222 2019-03-29  Keith Seitz  <keiths@redhat.com>
6223
6224         From Siddhesh Poyarekar:
6225         * f-lang.h (f77_get_upperbound): Return LONGEST.
6226         (f77_get_lowerbound): Likewise.
6227         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6228         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6229         print them.
6230         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6231         plongest to format print it.
6232         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6233         (f77_get_upperbound): Likewise.
6234         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6235         LOWER_BOUND to LONGEST.
6236         (f77_create_arrayprint_offset_tbl): Likewise.
6237
6238 2019-03-29  Keith Seitz  <keiths@redhat.com>
6239
6240         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6241         %s/pulongest for TYPE_LENGTH instead of %d in format
6242         strings.
6243         * ada-typerint.c (ada_print_type): Likewise.
6244         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6245         * compile/compile-c-support.c (generate_register_struct): Likewise.
6246         * gdbtypes.c (recursive_dump_type): Likewise.
6247         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6248         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6249         instead of %d in format strings.
6250         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6251         to std::min to ULONGEST.
6252         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6253         instead of %d in format strings.
6254         * tracepoint.c (info_scope_command): Likewise.
6255         * typeprint.c (print_offset_data::update)
6256         (print_offset_data::finish): Likewise.
6257         * xtensa-tdep.c (xtensa_store_return_value)
6258         (xtensa_push_dummy_call): Likewise.
6259
6260 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6261
6262         * windows-nat.c (display_selector): Fixed format specifications
6263         for 64-bit Cygwin.
6264
6265 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6266
6267         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6268
6269 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6270
6271         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6272         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6273         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6274         (nios2_linux_init_abi): Install it.
6275
6276 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6277
6278         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6279
6280 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6281
6282         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6283
6284 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285             Tom Tromey  <tromey@adacore.com>
6286
6287         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6288
6289 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6290
6291         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6292         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6293         method to compute the bounds of range types. Also print "[evaluated]"
6294         if the bounds' values come from a dynamic evaluation.
6295
6296 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6299         whitespace when pretty printing is on.
6300
6301 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6302
6303         * ppc-linux-nat.c: Add include.
6304
6305 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6306
6307         * NEWS: Mention AArch64 Pointer Authentication.
6308
6309 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6310
6311         * arm-linux-nat.c: Add include.
6312
6313 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6314
6315         * source-cache.c (source_cache::get_source_lines): Re-read
6316         fullname after calling open_source_file.
6317
6318 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6319
6320         * NEWS: Mention TLS support for FreeBSD.
6321
6322 2019-03-25  Tom Tromey  <tromey@adacore.com>
6323
6324         * minsyms.c (BUNCH_SIZE): Update comment.
6325         (~minimal_symbol_reader): Remove old comment.
6326         (compact_minimal_symbols): Update comment.
6327         (minimal_symbol_reader::install): Remove old comment.  Update
6328         other comments.
6329
6330 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6331
6332         * s390-linux-nat.c: Add include.
6333
6334 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6335
6336         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6337         Call linux_get_hwcap.
6338         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6339         Likewise.
6340         (aarch64_linux_get_hwcap): Remove function.
6341         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6342         declaration.
6343         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6344         linux_get_hwcap.
6345         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6346         * linux-tdep.c (linux_get_hwcap): Add function.
6347         (linux_get_hwcap2): Likewise.
6348         * linux-tdep.h (linux_get_hwcap): Add declaration.
6349         (linux_get_hwcap2): Likewise.
6350         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6351         (ppc_linux_get_hwcap2): Likewise.
6352         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6353         linux_get_hwcap.
6354         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6355         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6356         (ppc_linux_nat_target::read_description): Likewise.
6357         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6358         * s390-linux-nat.c: Likewise.
6359         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6360
6361 2019-03-24  Tom Tromey  <tom@tromey.com>
6362
6363         * ada-lang.c (standard_lookup): Simplify initialization.
6364         (ada_lookup_symbol_nonlocal): Simplify return.
6365         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6366         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6367         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6368         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6369         initialization.
6370         * solib.c (solib_global_lookup): Simplify.
6371         * symtab.c (null_block_symbol): Remove.
6372         (symbol_cache_lookup): Simplify returns.
6373         (lookup_language_this): Simplify returns.
6374         (lookup_symbol_aux): Simplify return.
6375         (lookup_local_symbol): Simplify returns.
6376         (lookup_global_symbol_from_objfile): Simplify return.
6377         (lookup_symbol_in_objfile_symtabs)
6378         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6379         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6380         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6381         * cp-namespace.c (cp_lookup_bare_symbol)
6382         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6383         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6384         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6385         (cp_lookup_symbol_via_imports): Simplify initialization.
6386         (find_symbol_in_baseclass): Likewise.
6387         * symtab.h (null_block_symbol): Remove.
6388         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6389         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6390         (d_lookup_symbol_module): Likewise.
6391         (find_symbol_in_baseclass): Simplify initialization.
6392
6393 2019-03-24  Tom Tromey  <tom@tromey.com>
6394
6395         * expression.h: Don't include symtab.h.
6396         (struct block): Forward declare.
6397
6398 2019-03-24  Tom Tromey  <tom@tromey.com>
6399
6400         * c-exp.y (typebase): Remove casts.
6401         * gdbtypes.c (lookup_unsigned_typename, )
6402         (lookup_signed_typename): Remove cast.
6403         * eval.c (parse_to_comma_and_eval): Remove cast.
6404         * parse.c (write_dollar_variable): Remove cast.
6405         * block.h (struct block) <superblock>: Now const.
6406         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6407         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6408         (map_block): Make "block" const.
6409         * symfile.h (struct quick_symbol_functions)
6410         <map_matching_symbols>: Constify block argument to "callback".
6411         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6412         const.
6413         (find_pc_sect_compunit_symtab): Make "b" const.
6414         (find_symbol_at_address): Likewise.
6415         (search_symbols): Likewise.
6416         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6417         (dw2_debug_names_lookup_symbol): Likewise.
6418         (dw2_map_matching_symbols): Update.
6419         * p-valprint.c (pascal_val_print): Remove "block".
6420         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6421         (aux_add_nonlocal_symbols): Make "block" const.
6422         (resolve_subexp): Remove cast.
6423         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6424         const.
6425         (iterate_over_file_blocks): Likewise.
6426         * f-exp.y (%union) <bval>: Remove.
6427         * coffread.c (patch_opaque_types): Make "b" const.
6428         * spu-tdep.c (spu_catch_start): Make "block" const.
6429         * c-valprint.c (print_unpacked_pointer): Remove "block".
6430         * symmisc.c (dump_symtab_1): Make "b" const.
6431         (block_depth): Make "block" const.
6432         * d-exp.y (%union) <bval>: Remove.
6433         * cp-support.h (cp_lookup_rtti_type): Update.
6434         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6435         * psymtab.c (psym_lookup_symbol): Make "block" const.
6436         (maintenance_check_psymtabs): Make "b" const.
6437         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6438         (enumerate_locals, enumerate_args): Update.
6439         * python/py-symtab.c (stpy_global_block): Make "block" const.
6440         (stpy_static_block): Likewise.
6441         * inline-frame.c (block_starting_point_at): Make "new_block"
6442         const.
6443         * block.c (find_block_in_blockvector): Make return type const.
6444         (blockvector_for_pc_sect): Make "b" const.
6445         (find_block_in_blockvector): Make "b" const.
6446
6447 2019-03-23  Tom Tromey  <tom@tromey.com>
6448
6449         * varobj.c (varobj_create): Update.
6450         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6451         * printcmd.c (display_command, do_one_display): Don't reset
6452         innermost_block.
6453         * parser-defs.h (enum innermost_block_tracker_type): Move to
6454         expression.h.
6455         (innermost_block): Update comment.
6456         * parse.c (parse_exp_1): Add tracker_types parameter.
6457         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6458         tracker_types parameter.  Reset innermost_block.
6459         (parse_exp_in_context): Remove.
6460         (parse_expression_for_completion): Update.
6461         * objfiles.c (~objfile): Don't reset expression_context_block or
6462         innermost_block.
6463         * expression.h (enum innermost_block_tracker_type): Move from
6464         parser-defs.h.
6465         (parse_exp_1): Add tracker_types parameter.
6466         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6467         reset innermost_block.
6468
6469 2019-03-23  Tom Tromey  <tom@tromey.com>
6470
6471         * objfiles.h: Include bcache.h.
6472
6473 2019-03-23  Tom Tromey  <tom@tromey.com>
6474
6475         * linespec.c (get_current_search_block): Use
6476         scoped_restore_current_language.
6477         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6478
6479 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6480             Jiong Wang  <jiong.wang@arm.com>
6481
6482         * aarch64-linux-tdep.c
6483         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6484         section.
6485         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6486
6487 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6488             Jiong Wang  <jiong.wang@arm.com>
6489
6490         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6491         instructions.
6492         (aarch64_analyze_prologue_test): Add PACIASP test.
6493         (aarch64_prologue_prev_register): Unmask PC value.
6494
6495 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6496             Jiong Wang  <jiong.wang@arm.com>
6497
6498         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6499         (aarch64_dwarf2_prev_register): Unmask PC value.
6500         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6501         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6502         DW_CFA_AARCH64_negate_ra_state.
6503         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6504
6505 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6506             Jiong Wang  <jiong.wang@arm.com>
6507
6508         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6509         registers.
6510         (aarch64_pseudo_register_name): Likewise.
6511         (aarch64_pseudo_register_type): Likewise.
6512         (aarch64_pseudo_register_reggroup_p): Likewise.
6513         (aarch64_gdbarch_init): Add pauth registers.
6514         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6515         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6516         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6517         (struct gdbarch_tdep): Add regnum for ra_state.
6518
6519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6520             Jiong Wang  <jiong.wang@arm.com>
6521
6522         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6523
6524 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6525             Jiong Wang  <jiong.wang@arm.com>
6526
6527         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6528         function.
6529         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6530         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6531         (aarch64_gdbarch_init): Add puth registers.
6532         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6533         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6534         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6535
6536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6537             Jiong Wang  <jiong.wang@arm.com>
6538
6539         * aarch64-linux-nat.c
6540         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6541         * aarch64-linux-tdep.c
6542         (aarch64_linux_core_read_description): Likewise.
6543         (aarch64_linux_get_hwcap): New function.
6544         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6545         (aarch64_linux_get_hwcap): New declaration.
6546
6547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6548             Jiong Wang  <jiong.wang@arm.com>
6549
6550         * aarch64-linux-nat.c
6551         (aarch64_linux_nat_target::read_description): Add pauth param.
6552         * aarch64-linux-tdep.c
6553         (aarch64_linux_core_read_description): Likewise.
6554         * aarch64-tdep.c (struct target_desc): Add in pauth.
6555         (aarch64_read_description): Add pauth param.
6556         (aarch64_gdbarch_init): Likewise.
6557         * aarch64-tdep.h (aarch64_read_description): Likewise.
6558         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6559         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6560         * features/Makefile: Add new files.
6561         * features/aarch64-pauth.c: New file.
6562         * features/aarch64-pauth.xml: New file.
6563
6564 2019-03-20  Tom Tromey  <tromey@adacore.com>
6565
6566         * infrun.c (handle_inferior_event): Rename from
6567         handle_inferior_event_1.  Create a scoped_value_mark.
6568         (handle_inferior_event): Remove.
6569
6570 2019-03-19  Tom Tromey  <tromey@adacore.com>
6571
6572         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6573         * infrun.h (print_stop_event): Add "displays" parameter.
6574         * infrun.c (print_stop_event): Add "displays" parameter.
6575
6576 2019-03-19  Pedro Alves  <palves@redhat.com>
6577
6578         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6579         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6580         to -1.  Fix TABs vs spaces.
6581         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6582         * tui/tui-out.h (tui_ui_out) Add intro comments.
6583         <m_line, m_start_of_line>: In-class initialize, and add describing
6584         comment.
6585
6586 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6587
6588         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6589         variable names.
6590         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6591
6592 2019-03-18  Pedro Alves  <palves@redhat.com>
6593             Eli Zaretskii <eliz@gnu.org>
6594
6595         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6596         m_line and m_start_of_line.
6597
6598 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6599
6600         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6601         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6602         it returns a newline.  This fixes a regression in TU mode, whereby
6603         the next line is output on the same screen line as the user input.
6604
6605 2019-03-18  Tom Tromey  <tromey@adacore.com>
6606
6607         * minsyms.c (minimal_symbol_reader::install): Remove call to
6608         obstack_blank.
6609
6610 2019-03-18  Pedro Alves  <palves@redhat.com>
6611
6612         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6613         New globals.
6614         (apply_style): New, factored out from ...
6615         (apply_ansi_escape): ... this.  Handle reverse video mode.
6616         (tui_set_reverse_mode): New function.
6617         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6618         * tui/tui-winsource.c (tui_show_source_line): Use
6619         tui_set_reverse_mode instead of setting A_STANDOUT.
6620         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6621         New setter methods.
6622
6623 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6624
6625         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6626         Handle tabs.
6627
6628 2019-03-18  Tom Tromey  <tromey@adacore.com>
6629
6630         * ada-lang.c (empty_array): Add "high" parameter.
6631         (ada_evaluate_subexp): Update.
6632
6633 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6634
6635         * unittests/string_view-selftests.c: Define
6636         _initialize_string_view_selftests unconditionally.
6637
6638 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6639
6640         PR gdb/24350
6641         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6642
6643 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6644
6645         PR gdb/24351
6646         * windows-nat.c (display_selector): Fix format specifiers.
6647
6648 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6649
6650         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6651         tui_refill_source_window instead of tui_refresh_win, to update the
6652         current execution line.  This fixes redisplay of the current line
6653         when stepping through the code with "next" or "step".
6654
6655 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6656
6657         * source-cache.c (source_cache::get_source_lines): Call
6658         find_source_lines to initialize s->nlines.  This fixes vertical
6659         scrolling of TUI source window when the DOWN arrow is pressed.
6660
6661 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6662
6663         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6664         linux-thread-db.c (_initialize_thread_db): Likewise.
6665
6666 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6667
6668         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6669         wclrtoeol in tui_show_source_line".  This reverts changes made in
6670         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6671
6672 2019-03-15  Tom Tromey  <tom@tromey.com>
6673
6674         * symtab.h (struct minimal_symbol): Derive from
6675         general_symbol_info.
6676         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6677         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6678         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6679         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6680         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6681         (MSYMBOL_SEARCH_NAME): Update.
6682         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6683         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6684         * minsyms.c (minimal_symbol_reader::record_full): Update.
6685
6686 2019-03-15  Tom Tromey  <tom@tromey.com>
6687
6688         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6689
6690 2019-03-15  Tom Tromey  <tom@tromey.com>
6691
6692         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6693         unique_xmalloc_ptr.
6694         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6695         Update.
6696         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6697         (build_minimal_symbol_hash_tables)
6698         (minimal_symbol_reader::install): Update.
6699
6700 2019-03-15  Tom Tromey  <tom@tromey.com>
6701
6702         * symtab.c (create_demangled_names_hash): Update.
6703         (symbol_set_names): Update.
6704         * objfiles.h (struct objfile_per_bfd_storage)
6705         <demangled_names_hash>: Now an htab_up.
6706         * objfiles.c (objfile_per_bfd_storage): Simplify.
6707
6708 2019-03-15  Tom Tromey  <tom@tromey.com>
6709
6710         * objfiles.h (struct objfile_per_bfd_storage): Declare
6711         destructor.
6712         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6713         New.
6714         (get_objfile_bfd_data): Use new.  Don't initialize
6715         language_of_main.
6716         (free_objfile_per_bfd_storage): Remove.
6717         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6718
6719 2019-03-15  Tom Tromey  <tom@tromey.com>
6720
6721         * symfile.c (reread_symbols): Update.
6722         * objfiles.c (objfile::objfile): Update.
6723         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6724         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6725         comment.
6726         (minimal_symbol_reader::install): Update.
6727         (terminate_minimal_symbol_table): Remove.
6728         * jit.c (jit_object_close_impl): Update.
6729
6730 2019-03-15  Tom Tromey  <tom@tromey.com>
6731
6732         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6733         initializations.
6734
6735 2019-03-15  Tom Tromey  <tom@tromey.com>
6736
6737         * objfiles.h (struct objfile_per_bfd_storage)
6738         <demangled_hash_languages>: Now a bitset.
6739         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6740         (lookup_minimal_symbol): Update.
6741
6742 2019-03-15  Tom Tromey  <tom@tromey.com>
6743
6744         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6745         Don't return the symbol.
6746         * coffread.c (record_minimal_symbol): Use record_full.
6747
6748 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6749
6750         The MS-Windows port of ncurses fails to switch to a color pair if
6751         one or both of the colors are the implicit default colors.  This
6752         change records the default colors when TUI is initialized, and
6753         then specifies them explicitly when a color pair uses the default
6754         colors.  This allows color styling in TUI mode on MS-Windows.
6755
6756         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6757         ncurses_norm_attr.
6758         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6759         colors in ncurses_norm_attr.
6760         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6761         "none", replace it with the default color recorded in
6762         ncurses_norm_attr.
6763
6764 2019-03-14  Tom Tromey  <tromey@adacore.com>
6765
6766         * source-cache.h (class source_cache) <get_source_lines>: Return
6767         std::string.
6768         * source-cache.c (source_cache::extract_lines): Handle case where
6769         first_pos==npos.  Return std::string.
6770         (source_cache::get_source_lines): Update.
6771
6772 2019-03-14  Tom Tromey  <tromey@adacore.com>
6773
6774         * NEWS: Add item for "style sources" commands.
6775         * source-cache.c (source_cache::get_source_lines): Check
6776         source_styling.
6777         * cli/cli-style.c (source_styling): New global.
6778         (_initialize_cli_style): Add "style sources" commands.
6779         (show_style_sources): New function.
6780         * cli/cli-style.h (source_styling): Declare.
6781
6782 2019-03-14  Pedro Alves  <palves@redhat.com>
6783             Tom Tromey  <tromey@adacore.com>
6784
6785         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6786         * tui/tui-winsource.c (tui_refill_source_window): New function,
6787         from...
6788         (tui_horizontal_source_scroll): ... here.  Move some logic.
6789         * cli/cli-style.c (set_style_enabled): Notify new observable.
6790         * tui/tui-hooks.c (tui_redisplay_source): New function.
6791         (tui_attach_detach_observers): Attach or detach
6792         tui_redisplay_source.
6793         * observable.h (source_styling_changed): New observable.
6794         * observable.c: Define source_styling_changed observable.
6795
6796 2019-03-13  Tom Tromey  <tromey@adacore.com>
6797
6798         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6799         (i386_gnu_nat_target::store_registers): Update.
6800         * target-debug.h (target_debug_print_std_string): New macro.
6801         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6802         * windows-tdep.c (display_one_tib): Update.
6803         * tui/tui-stack.c (tui_make_status_line): Update.
6804         * top.c (print_inferior_quit_action): Update.
6805         * thread.c (thr_try_catch_cmd): Update.
6806         (add_thread_with_info): Update.
6807         (thread_target_id_str): Update.
6808         (thr_try_catch_cmd): Update.
6809         (thread_command): Update.
6810         (thread_find_command): Update.
6811         * record-btrace.c (record_btrace_target::info_record)
6812         (record_btrace_resume_thread, record_btrace_target::resume)
6813         (record_btrace_cancel_resume, record_btrace_step_thread)
6814         (record_btrace_target::wait, record_btrace_target::wait)
6815         (record_btrace_target::wait, record_btrace_target::stop): Update.
6816         * progspace.c (print_program_space): Update.
6817         * process-stratum-target.c
6818         (process_stratum_target::thread_address_space): Update.
6819         * linux-fork.c (linux_fork_mourn_inferior)
6820         (detach_checkpoint_command, info_checkpoints_command)
6821         (linux_fork_context): Update.
6822         (linux_fork_detach): Update.
6823         (class scoped_switch_fork_info): Update.
6824         (delete_checkpoint_command): Update.
6825         * infrun.c (follow_fork_inferior): Update.
6826         (follow_fork_inferior): Update.
6827         (proceed_after_vfork_done): Update.
6828         (handle_vfork_child_exec_or_exit): Update.
6829         (follow_exec): Update.
6830         (displaced_step_prepare_throw): Update.
6831         (displaced_step_restore): Update.
6832         (start_step_over): Update.
6833         (resume_1): Update.
6834         (clear_proceed_status_thread): Update.
6835         (proceed): Update.
6836         (print_target_wait_results): Update.
6837         (do_target_wait): Update.
6838         (context_switch): Update.
6839         (stop_all_threads): Update.
6840         (restart_threads): Update.
6841         (finish_step_over): Update.
6842         (handle_signal_stop): Update.
6843         (switch_back_to_stepped_thread): Update.
6844         (keep_going_pass_signal): Update.
6845         (print_exited_reason): Update.
6846         (normal_stop): Update.
6847         * inferior.c (inferior_pid_to_str): Change return type.
6848         (print_selected_inferior): Update.
6849         (add_inferior): Update.
6850         (detach_inferior): Update.
6851         * dummy-frame.c (fprint_dummy_frames): Update.
6852         * dcache.c (dcache_info_1): Update.
6853         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6854         (btrace_fetch, btrace_clear): Update.
6855         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6856         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6857         type.
6858         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6859         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6860         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6861         * gdbarch.c, gdbarch.h: Rebuild.
6862         * gdbarch.sh (core_pid_to_str): Change return type.
6863         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6864         return type.
6865         (windows_nat_target::pid_to_str): Change return type.
6866         (windows_delete_thread): Update.
6867         (windows_nat_target::attach): Update.
6868         (windows_nat_target::files_info): Update.
6869         * target-delegates.c: Rebuild.
6870         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6871         return type.
6872         (sol_thread_target::pid_to_str): Change return type.
6873         * remote.c (class remote_target) <pid_to_str>: Change return
6874         type.
6875         (remote_target::pid_to_str): Change return type.
6876         (extended_remote_target::attach, remote_target::remote_stop_ns)
6877         (remote_target::remote_notif_remove_queued_reply)
6878         (remote_target::push_stop_reply, remote_target::disable_btrace):
6879         Update.
6880         (extended_remote_target::attach): Update.
6881         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6882         type.
6883         (gdbsim_target::pid_to_str): Change return type.
6884         * ravenscar-thread.c (struct ravenscar_thread_target)
6885         <pid_to_str>: Change return type.
6886         (ravenscar_thread_target::pid_to_str): Change return type.
6887         * procfs.c (class procfs_target) <pid_to_str>: Change return
6888         type.
6889         (procfs_target::pid_to_str): Change return type.
6890         (procfs_target::attach): Update.
6891         (procfs_target::detach): Update.
6892         (procfs_target::fetch_registers): Update.
6893         (procfs_target::store_registers): Update.
6894         (procfs_target::wait): Update.
6895         (procfs_target::files_info): Update.
6896         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6897         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6898         return type.
6899         (nto_procfs_target::pid_to_str): Change return type.
6900         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6901         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6902         return type.
6903         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6904         (exit_lwp): Update.
6905         (attach_proc_task_lwp_callback, get_detach_signal)
6906         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6907         (linux_nat_target::resume, wait_lwp, stop_callback)
6908         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6909         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6910         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6911         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6912         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6913         type.
6914         (inf_ptrace_target::attach): Update.
6915         (inf_ptrace_target::files_info): Update.
6916         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6917         type.
6918         (go32_nat_target::pid_to_str): Change return type.
6919         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6920         (gnu_nat_target::wait): Update.
6921         (gnu_nat_target::wait): Update.
6922         (gnu_nat_target::resume): Update.
6923         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6924         (fbsd_nat_target::wait): Update.
6925         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6926         type.
6927         (darwin_nat_target::attach): Update.
6928         * corelow.c (class core_target) <pid_to_str>: Change return type.
6929         (core_target::pid_to_str): Change return type.
6930         * target.c (normal_pid_to_str): Change return type.
6931         (default_pid_to_str): Likewise.
6932         (target_pid_to_str): Change return type.
6933         (target_translate_tls_address): Update.
6934         (target_announce_detach): Update.
6935         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6936         return type.
6937         (bsd_uthread_target::pid_to_str): Change return type.
6938         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6939         type.
6940         (bsd_kvm_target::pid_to_str): Change return type.
6941         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6942         return type.
6943         (aix_thread_target::pid_to_str): Change return type.
6944         * target.h (struct target_ops) <pid_to_str>: Change return type.
6945         (target_pid_to_str, normal_pid_to_str): Likewise.
6946         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6947         type.
6948         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6949         type.
6950         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6951         return type.
6952         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6953         type.
6954         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6955         type.
6956         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6957         return type.
6958
6959 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6960
6961         * NEWS: Mention that the new default MI version is 3.  Mention
6962         changes to the output of commands and events that deal with
6963         multi-location breakpoints.
6964         * breakpoint.c: Include "mi/mi-out.h".
6965         (print_one_breakpoint): Change output syntax if using MI version
6966         >= 3.
6967         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6968         New.
6969         (mi_multi_location_breakpoint_output_fixed): New.
6970         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6971         (mi_cmd_fix_multi_location_breakpoint_output): New.
6972         (mi_multi_location_breakpoint_output_fixed): New.
6973         * mi/mi-cmds.c (mi_cmds): Register command
6974         -fix-multi-location-breakpoint-output.
6975         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6976         interpreter "mi".
6977
6978 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6979
6980         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6981         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6982         instantiate mi_ui_out based on interpreter name.
6983         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6984         * mi/mi-main.c (mi_load_progress): Likewise.
6985
6986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6987
6988         * NEWS: Combine separate "New targets" sections for 8.3.
6989
6990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6991
6992         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6993         (ppcfbsd_init_abi): Install gdbarch
6994         "fetch_tls_load_module_address" and "get_thread_local_address"
6995         methods.
6996
6997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6998
6999         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7000         (riscv_fbsd_init_abi): Install gdbarch
7001         "fetch_tls_load_module_address" and "get_thread_local_address"
7002         methods.
7003
7004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7005
7006         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7007         (i386fbsd_init_abi): Install gdbarch
7008         "fetch_tls_load_module_address" and "get_thread_local_address"
7009         methods.
7010
7011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7012
7013         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7014         (amd64fbsd_init_abi): Install gdbarch
7015         "fetch_tls_load_module_address" and "get_thread_local_address"
7016         methods.
7017
7018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7019
7020         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7021         (struct fbsd_pspace_data): New type.
7022         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7023         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7024         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7025         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7026         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7027
7028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7029
7030         * gdbtypes.c (lookup_struct_elt): New function.
7031         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7032         * gdbtypes.h (struct struct_elt): New type.
7033         (lookup_struct_elt): New prototype.
7034
7035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7036
7037         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7038         remove disabled code block.
7039
7040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7041
7042         * gdbarch.sh (get_thread_local_address): New method.
7043         * gdbarch.h, gdbarch.c: Regenerate.
7044         * target.c (target_translate_tls_address): Use
7045         gdbarch_get_thread_local_address if present instead of
7046         target::get_thread_local_address.
7047
7048 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7049
7050         * target.h (target::get_thread_local_address): Update comment.
7051
7052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7053
7054         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7055         objfile->separate_debug_objfile_backlink if not NULL.
7056
7057 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7058
7059         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7060         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7061         (amd64bsd_store_inferior_registers): Likewise.
7062         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7063         Enable segment base registers.
7064         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7065         PT_GETFSBASE and PT_GETGSBASE.
7066         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7067         PT_SETGSBASE.
7068         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7069         segment base registers.
7070         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7071
7072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7073
7074         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7075         Update calls to i386_target_description to add 'segments'
7076         parameter.
7077         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7078         add segment base registers.
7079         * arch/i386.c (i386_create_target_description): Add 'segments'
7080         parameter to enable segment base registers.
7081         * arch/i386.h (i386_create_target_description): Likewise.
7082         * features/i386/32bit-segments.xml: New file.
7083         * features/i386/32bit-segments.c: Generate.
7084         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7085         call to i386_target_description to add 'segments' parameter.
7086         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7087         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7088         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7089         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7090         if feature is present.
7091         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7092         Add 'segments' parameter to call to i386_target_description.
7093         (i386_target_description): Add 'segments' parameter to enable
7094         segment base registers.
7095         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7096         to call to i386_target_description.
7097         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7098         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7099         Define I386_NUM_REGS.
7100         (i386_target_description): Add 'segments' parameter to enable
7101         segment base registers.
7102
7103 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7104
7105         PR/24325
7106         * source-cache.c: #undef open and close, to avoid unresolved
7107         externals during linking.
7108
7109 2019-03-12  Tom Tromey  <tromey@adacore.com>
7110
7111         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7112         const.  Add initializers.
7113         (_initialize_remote): Don't initialize ptid globals.
7114
7115 2019-03-12  Pedro Alves  <palves@redhat.com>
7116
7117         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7118
7119 2019-03-12  Pedro Alves  <palves@redhat.com>
7120
7121         * cp-name-parser.y (main): Remove unused 'len' variable.
7122
7123 2019-03-12  Tom Tromey  <tromey@adacore.com>
7124
7125         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7126         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7127
7128 2019-03-12  Tom Tromey  <tromey@adacore.com>
7129
7130         * linux-nat.c (iterate_over_lwps): Update.
7131         (stop_callback): Remove parameter.
7132         (stop_wait_callback, detach_callback, resume_set_callback)
7133         (select_singlestep_lwp_callback, set_ignore_sigint)
7134         (status_callback, resumed_callback, resume_clear_callback)
7135         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7136         data parameter.
7137         (linux_nat_target::detach, linux_nat_target::resume)
7138         (linux_stop_and_wait_all_lwps, select_event_lwp)
7139         (linux_nat_filter_event, linux_nat_wait_1)
7140         (linux_nat_target::kill, linux_nat_target::stop)
7141         (linux_nat_target::stop): Update.
7142         (linux_nat_resume_callback): Change type.
7143         (resume_stopped_resumed_lwps, count_events_callback)
7144         (select_event_lwp_callback): Likewise.
7145         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7146         * arm-linux-nat.c (struct update_registers_data): Remove.
7147         (update_registers_callback): Change type.
7148         (arm_linux_insert_hw_breakpoint1): Update.
7149         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7150         parameter.
7151         (x86_linux_dr_set_addr): Update.
7152         (x86_linux_dr_set_control): Update.
7153         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7154         (iterate_over_lwps): Use gdb::function_view.
7155         * nat/aarch64-linux-hw-point.c (struct
7156         aarch64_dr_update_callback_param): Remove.
7157         (debug_reg_change_callback): Change type.
7158         (aarch64_notify_debug_reg_change): Update.
7159         * s390-linux-nat.c (s390_refresh_per_info): Update.
7160
7161 2019-03-11  Tom Tromey  <tromey@adacore.com>
7162
7163         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7164         redundant assignment to "this_cu".
7165
7166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7167
7168         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7169
7170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7171
7172         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7173         from...
7174         (rank_one_type): ... this.
7175
7176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7177
7178         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7179         from...
7180         (rank_one_type): ... this.
7181
7182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7183
7184         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7185         from...
7186         (rank_one_type): ... this.
7187
7188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7189
7190         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7191         from...
7192         (rank_one_type): ... this.
7193
7194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7195
7196         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7197         from...
7198         (rank_one_type): ... this.
7199
7200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7201
7202         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7203         from...
7204         (rank_one_type): ... this.
7205
7206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7207
7208         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7209         from...
7210         (rank_one_type): ... this.
7211
7212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7213
7214         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7215         from...
7216         (rank_one_type): ... this.
7217
7218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7219
7220         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7221         from...
7222         (rank_one_type): ... this.
7223
7224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7225
7226         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7227         from...
7228         (rank_one_type): ... this.
7229
7230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7231
7232         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7233         from...
7234         (rank_one_type): ... this.
7235
7236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7237
7238         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7239         from...
7240         (rank_one_type): ... this.
7241
7242 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7243
7244         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7245         inferior-events' shows the example events.
7246
7247 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7248
7249         Support styling on native MS-Windows console
7250
7251         PR/24315
7252         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7253         on MS-Windows if $TERM is not defined.
7254
7255         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7256
7257         * posix-hdep.c (gdb_console_fputs):
7258         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7259         functions.
7260         * ui-file.h (gdb_console_fputs): Add prototype.
7261
7262         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7263         back to fputs only if the former returns zero.
7264
7265 2019-03-07  Tom Tromey  <tom@tromey.com>
7266
7267         * symmisc.c (print_symbol_bcache_statistics): Update.
7268         (print_objfile_statistics): Update.
7269         * symfile.c (allocate_symtab): Update.
7270         * stabsread.c: Don't include bcache.h.
7271         * psymtab.h (struct psymbol_bcache): Don't declare.
7272         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7273         (psymbol_bcache_init, psymbol_bcache_free)
7274         (psymbol_bcache_get_bcache): Don't declare.
7275         * psymtab.c (struct psymbol_bcache): Remove.
7276         (psymtab_storage::psymtab_storage): Update.
7277         (psymtab_storage::~psymtab_storage): Update.
7278         (psymbol_bcache_init, psymbol_bcache_free)
7279         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7280         (add_psymbol_to_bcache): Update.
7281         (allocate_psymtab): Update.
7282         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7283         macro_cache>: No longer pointers.
7284         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7285         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7286         * macrotab.c (macro_bcache): Update.
7287         * macroexp.c: Don't include bcache.h.
7288         * gdbtypes.c (check_types_worklist): Update.
7289         (types_deeply_equal): Remove TRY/CATCH.  Update.
7290         * elfread.c (elf_symtab_read): Update.
7291         * dwarf2read.c: Don't include bcache.h.
7292         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7293         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7294         (print_bcache_statistics, bcache_memory_used): Don't declare.
7295         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7296         methods.  Rename all data members.
7297         * bcache.c (struct bcache): Move to bcache.h.
7298         (bcache::expand_hash_table): Rename from expand_hash_table.
7299         (bcache): Remove.
7300         (bcache::insert): Rename from bcache_full.
7301         (bcache::compare): Rename from bcache_compare.
7302         (bcache_xmalloc): Remove.
7303         (bcache::~bcache): Rename from bcache_xfree.
7304         (bcache::print_statistics): Rename from print_bcache_statistics.
7305         (bcache::memory_used): Rename from bcache_memory_used.
7306
7307 2019-03-07  Pedro Alves  <palves@redhat.com>
7308
7309         * infrun.c (normal_stop): Also check for
7310         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7311
7312 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * f-lang.c (value_from_host_double): Moved to...
7315         * value.c (value_from_host_double): ...here.
7316         * value.h (value_from_host_double): Declare.
7317         * guile/scm-math.c (vlscm_convert_typed_number): Use
7318         value_from_host_double.
7319         (vlscm_convert_number): Likewise.
7320         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7321         * python/py-value.c (convert_value_from_python): Likewise.
7322
7323 2019-03-06  Tom Tromey  <tom@tromey.com>
7324
7325         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7326
7327 2019-03-06  Tom Tromey  <tom@tromey.com>
7328
7329         * utils.h (free_current_contents): Don't declare.
7330         * utils.c (free_current_contents): Remove.
7331
7332 2019-03-06  Tom Tromey  <tom@tromey.com>
7333
7334         * top.c (quit_force): Update.
7335         * main.c (captured_command_loop): Update.
7336         * common/new-op.c (operator new): Update.
7337         * common/common-exceptions.c (struct catcher)
7338         <save_cleanup_chain>: Remove member.
7339         (exceptions_state_mc_init): Update.
7340         (exception_try_scope_entry): Return nullptr.
7341         (exception_try_scope_exit, exception_rethrow)
7342         (throw_exception_sjlj, throw_exception_cxx): Update.
7343         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7344         (all_cleanups, do_cleanups, discard_cleanups)
7345         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7346         (restore_cleanups, restore_final_cleanups): Don't declare.
7347         (do_final_cleanups): Remove parameter.
7348         * common/cleanups.c (cleanup_chain, make_cleanup)
7349         (make_cleanup_dtor, all_cleanups, do_cleanups)
7350         (discard_my_cleanups, discard_cleanups)
7351         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7352         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7353         (null_cleanup): Remove.
7354         (do_final_cleanups): Remove parameter.
7355
7356 2019-03-06  Tom Tromey  <tom@tromey.com>
7357
7358         * remote.c (remote_target::remote_parse_stop_reply): Use
7359         unique_xmalloc_ptr.
7360
7361 2019-03-06  Tom Tromey  <tom@tromey.com>
7362
7363         * stabsread.c (struct stabs_field_info): Rename from field_info.
7364         <list, fnlist>: Add initializers.
7365         <obstack>: New member.
7366         (read_member_functions, read_struct_fields, read_baseclasses):
7367         Allocate on obstack.  Don't use cleanups.
7368         (read_one_struct_field, read_member_functions, read_struct_fields)
7369         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7370         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7371         (read_struct_type): Update.
7372
7373 2019-03-06  Tom Tromey  <tom@tromey.com>
7374
7375         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7376         * common/filestuff.h (make_cleanup_close): Don't declare.
7377         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7378         Remove.
7379
7380 2019-03-06  Tom Tromey  <tom@tromey.com>
7381
7382         * solib-aix.c: Use make_scope_exit.
7383
7384 2019-03-06  Tom Tromey  <tom@tromey.com>
7385
7386         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7387         Use make_scope_exit.
7388
7389 2019-03-06  Tom Tromey  <tom@tromey.com>
7390
7391         * solib-svr4.c (disable_probes_interface): Remove parameter.
7392         (svr4_handle_solib_event): Use make_scope_exit.
7393
7394 2019-03-06  Tom Tromey  <tom@tromey.com>
7395
7396         * remote.c (struct stop_reply_deleter): Remove.
7397         (stop_reply_up): Update.
7398         (struct stop_reply): Derive from notif_event.  Don't typedef.
7399         <regcache>: Now a std::vector.
7400         (stop_reply_xfree): Remove.
7401         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7402         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7403         (remote_target::discard_pending_stop_replies): Use delete.
7404         (remote_target::remote_parse_stop_reply): Update.
7405         (remote_target::process_stop_reply): Update.
7406         * remote-notif.h (struct notif_event): Add virtual destructor.
7407         Remove "dtr" member.
7408         (struct notif_client) <alloc_event>: Return a unique_ptr.
7409         (notif_event_xfree): Don't declare.
7410         (notif_event_up): New typedef.
7411         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7412         (notif_event_xfree, do_notif_event_xfree): Remove.
7413         (remote_notif_state_xfree): Update.
7414
7415 2019-03-06  Tom Tromey  <tom@tromey.com>
7416
7417         * infrun.c (displaced_step_clear_cleanup): Now a
7418         forward_scope_exit type.
7419         (displaced_step_prepare_throw): Update.
7420         (displaced_step_fixup): Update.
7421
7422 2019-03-06  Tom Tromey  <tom@tromey.com>
7423
7424         * inferior.h (class inferior): Update comment.
7425         * gdbthread.h (class thread_info): Update comment.
7426
7427 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7428             Tom Tromey  <tom@tromey.com>
7429
7430         * stabsread.h (struct stab_section_list): Remove.
7431         (coffstab_build_psymtabs): Update.
7432         * dbxread.c (symbuf_sections): Now a std::vector.
7433         (sect_idx): New global.
7434         (fill_symbuf): Update.
7435         (coffstab_build_psymtabs): Change type of stabsects parameter.
7436         Update.
7437         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7438         std::vector.
7439         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7440         (coff_locate_sections): Update.
7441         (coff_symfile_read): Remove cleanups.  Update.
7442         (init_stringtab): Add storage parameter.
7443         (free_stringtab, free_stringtab_cleanup): Remove.
7444         (init_lineno): Add storage parameter.
7445         (free_linetab, free_linetab_cleanup): Remove.
7446
7447 2019-03-06  Pedro Alves  <palves@redhat.com>
7448
7449         * linux-fork.c (fork_info::clobber_regs): Delete.
7450         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7451         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7452         comment.  Adjust.
7453         (scoped_switch_fork_info::scoped_switch_fork_info)
7454         (checkpoint_command, linux_fork_context): Adjust
7455         fork_save_infrun_state calls.
7456
7457 2019-03-06  Pedro Alves  <palves@redhat.com>
7458
7459         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7460         (inf_has_multiple_threads): Return 'bool' and rewrite using
7461         inferior_info::threads().
7462
7463 2019-03-06  Pedro Alves  <palves@redhat.com>
7464
7465         * linux-fork.c: Include <list>.
7466         (fork_list): Now a std::list instance.
7467         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7468         (forks_exist_p, find_last_fork): Adjust.
7469         (new_fork): Delete.
7470         (one_fork_p): New.
7471         (add_fork): Adjust.
7472         (free_fork): Delete, folded into fork_info::~fork_info().
7473         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7474         Adjust.
7475         (init_fork_list): Delete.
7476         (linux_fork_killall, linux_fork_mourn_inferior)
7477         (linux_fork_detach, info_checkpoints_command): Adjust.
7478         (_initialize_linux_fork): No longer call init_fork_list.
7479
7480 2019-03-06  Pedro Alves  <palves@redhat.com>
7481
7482         * linux-fork.c (new_fork): New, split out of ...
7483         (add_fork): ... this.  Return void.  Move "first fork" special
7484         case from here, to ...
7485         (checkpoint_command): ... here.
7486         * linux-linux.h (add_fork): Return void.
7487
7488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7489
7490         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7491
7492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7493             Chris January  <chris.january@arm.com>
7494             David Lecomber  <david.lecomber@arm.com>
7495
7496         * f-exp.y: New token, UNOP_INTRINSIC.
7497         (exp): New pattern using UNOP_INTRINSIC token.
7498         (f77_keywords): Add 'abs' keyword.
7499         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7500         (value_from_host_double): New function.
7501         (evaluate_subexp_f): Support UNOP_ABS.
7502
7503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7506         types.
7507
7508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7509
7510         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7511         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7512         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7513
7514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7517
7518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7519             Chris January  <chris.january@arm.com>
7520
7521         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7522         * f-exp.y: Define 'KIND' token.
7523         (exp): New pattern for KIND expressions.
7524         (ptype): Handle types with a kind extension.
7525         (direct_abs_decl): Extend to spot kind extensions.
7526         (f77_keywords): Add 'kind' to the list.
7527         (push_kind_type): New function.
7528         (convert_to_kind_type): New function.
7529         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7530         * parse.c (operator_length_standard): Likewise.
7531         * parser-defs.h (enum type_pieces): Add tp_kind.
7532         * std-operator.def: Add UNOP_KIND.
7533
7534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * f-exp.y (f_parse): Set yydebug.
7537
7538 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * f-lang.c (evaluate_subexp_f): New function.
7541         (exp_descriptor_f): New global.
7542         (f_language_defn): Use exp_descriptor_f instead of
7543         exp_descriptor_standard.
7544
7545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * f-exp.y (struct token): Add comments.
7548         (dot_ops): Remove uppercase versions and the end marker.
7549         (f77_keywords): Likewise.
7550         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7551         entries in the dot_ops array are case insensitive, and use
7552         strncasecmp to compare strings.  Also some whitespace cleanup in
7553         this area.  Similar for the f77_keywords array, except entries in
7554         this list might be case sensitive.
7555
7556 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7557
7558         * f-exp.y (struct f77_boolean_val): Add comments.
7559         (boolean_values): Remove uppercase versions, and end marker.
7560         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7561         and use strncasecmp to achieve case insensitivity.  Additionally,
7562         perform whitespace cleanup around this code.
7563
7564 2019-03-06  Tom Tromey  <tromey@adacore.com>
7565
7566         * remote-sim.c (gdbsim_target_open): Use result of
7567         gdb_argv::release.
7568
7569 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7570         Dirk Schubert  <dirk.schubert@arm.com>
7571         Chris January  <chris.january@arm.com>
7572
7573         * eval.c (evaluate_subexp_standard): Call Fortran argument
7574         wrapping logic.
7575         * f-lang.c (struct value): A value which can be passed into a
7576         Fortran function call.
7577         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7578         where appropriate.
7579         (struct type): Value ready for a Fortran function call.
7580         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7581         is needed.
7582         * f-lang.h (fortran_argument_convert): Declaration.
7583         (fortran_preserve_arg_pointer): Declaration.
7584         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7585
7586 2019-03-05  Tom Tromey  <tromey@adacore.com>
7587
7588         * python/py-prettyprint.c (print_string_repr): Remove #if.
7589         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7590
7591 2019-03-05  Tom Tromey  <tromey@adacore.com>
7592
7593         * target.c (the_dummy_target): Move later.  Change type to
7594         "dummy_target".
7595         (initialize_targets): Don't initialize the_dummy_target.
7596
7597 2019-03-05  Tom Tromey  <tromey@adacore.com>
7598
7599         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7600         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7601
7602 2019-03-05  Tom Tromey  <tromey@adacore.com>
7603
7604         * windows-nat.c (windows_nat_target::attach)
7605         (windows_nat_target::detach): Don't call gdb_flush.
7606         * valprint.c (generic_val_print, val_print, val_print_string):
7607         Don't call gdb_flush.
7608         * utils.c (defaulted_query): Don't call gdb_flush.
7609         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7610         * target.c (target_announce_detach): Don't call gdb_flush.
7611         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7612         * remote.c (extended_remote_target::attach): Don't call
7613         gdb_flush.
7614         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7615         * printcmd.c (do_examine): Don't call gdb_flush.
7616         (info_display_command): Don't call gdb_flush.
7617         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7618         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7619         * memattr.c (info_mem_command): Don't call gdb_flush.
7620         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7621         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7622         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7623         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7624         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7625         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7626         (gnu_nat_target::detach): Don't call gdb_flush.
7627         * f-valprint.c (f_val_print): Don't call gdb_flush.
7628         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7629         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7630         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7631         gdb_flush.
7632         * c-valprint.c (c_val_print): Don't call gdb_flush.
7633         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7634
7635 2019-03-05  Tom Tromey  <tromey@adacore.com>
7636
7637         * varobj.c (update_dynamic_varobj_children): Update.
7638         (install_default_visualizer): Use reset, not release.
7639         * value.c (set_internalvar): Update.
7640         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7641         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7642         ATTRIBUTE_UNUSED_RESULT.
7643
7644 2019-03-05  Tom Tromey  <tromey@adacore.com>
7645
7646         * remote.c (class scoped_remote_fd) <release>: Add
7647         ATTRIBUTE_UNUSED_RESULT.
7648
7649 2019-03-05  Tom Tromey  <tromey@adacore.com>
7650
7651         * macroexp.c (struct macro_buffer) <release>: Add
7652         ATTRIBUTE_UNUSED_RESULT.
7653
7654 2019-03-05  Tom Tromey  <tromey@adacore.com>
7655
7656         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7657         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7658         ATTRIBUTE_UNUSED_RESULT.
7659
7660 2019-03-05  Tom Tromey  <tromey@adacore.com>
7661
7662         * common/scoped_fd.h (class scoped_fd) <release>: Add
7663         ATTRIBUTE_UNUSED_RESULT.
7664
7665 2019-03-05  Tom Tromey  <tromey@adacore.com>
7666
7667         * parser-defs.h (struct parser_state) <release>: Add
7668         ATTRIBUTE_UNUSED_RESULT.
7669
7670 2019-03-05  Tom Tromey  <tromey@adacore.com>
7671
7672         * utils.h (class gdb_argv) <release>: Add
7673         ATTRIBUTE_UNUSED_RESULT.
7674         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7675
7676 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7677
7678         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7679         for-loop range, to avoid compiler warnings.
7680
7681         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7682         avoid compiler warnings about unused variables.
7683
7684         * NEWS: Mention end of support for native debugging on MS-Windows
7685         before XP.
7686
7687         PR gdb/24292
7688         * common/netstuff.c:
7689         * gdbserver/gdbreplay.c
7690         * gdbserver/remote-utils.c:
7691         * ser-tcp.c:
7692         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7693         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7694         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7695         'getaddrinfo' and 'freeaddrinfo' were not available before
7696         Windows XP, and mingw.org's MinGW headers by default define
7697         _WIN32_WINNT to 0x500.
7698
7699 2019-03-01  Gary Benson <gbenson@redhat.com>
7700
7701         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7702
7703 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7704             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7705
7706         PR gdb/8527
7707         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7708         set_sigint_trap, clear_sigint_trap.
7709
7710 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7711
7712         * target.c (target_detach): Clear the regcache and the
7713         frame cache.
7714
7715 2019-02-27  Pedro Alves  <palves@redhat.com>
7716
7717         * utils.c (set_screen_size): When we cap the height/width sizes,
7718         tweak the corresponding command variable to show "unlimited":
7719
7720 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7721             Pedro Alves  <palves@redhat.com>
7722
7723         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7724         before calling rl_set_screen_size.
7725
7726 2019-02-27  Tom Tromey  <tromey@adacore.com>
7727
7728         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7729         define.
7730         * python/py-value.c: Remove Python 2.4 workaround.
7731         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7732         workaround.
7733         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7734         Python 2.4 workaround.
7735         * python/python-internal.h: Remove Python 2.4 comment.
7736         (Py_ssize_t): Don't define.
7737         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7738         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7739         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7740         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7741         * python/python.c (do_start_initialization): Remove Python 2.4
7742         workaround.
7743         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7744         (print_children): Remove Python 2.4 workaround.
7745         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7746         workaround.
7747         (CHARBUFFERPROC_NAME): Remove.
7748         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7749         Python 2.4 workaround.
7750
7751 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7752
7753         * NEWS: Note minimum Python version.
7754
7755 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7756
7757         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7758         code from these functions.  Remove corresponding ifdefs.  Use
7759         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7760         Remove gotos and target of gotos.
7761         (infpy_search_memory): Likewise.
7762
7763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7766         (hppa_gdbarch_init): Don't register deleted functions with
7767         gdbarch.
7768
7769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7772         (h8300_unwind_sp): Delete.
7773         (h8300_dummy_id): Delete.
7774         (h8300_gdbarch_init): Don't register deleted functions with
7775         gdbarch.
7776
7777 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7780         (ft32_unwind_pc): Delete.
7781         (ft32_unwind_sp): Delete.
7782         (ft32_gdbarch_init): Don't register deleted functions with
7783         gdbarch.
7784
7785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7788         (frv_unwind_pc): Delete.
7789         (frv_unwind_sp): Delete.
7790         (frv_gdbarch_init): Don't register deleted functions with
7791         gdbarch.
7792
7793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7794
7795         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7796         (riscv_unwind_pc): Delete.
7797         (riscv_unwind_sp): Delete.
7798         (riscv_gdbarch_init): Don't register deleted functions with
7799         gdbarch.
7800
7801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7802
7803         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7804         (csky_unwind_pc): Delete.
7805         (csky_unwind_sp): Delete.
7806         (csky_gdbarch_init): Don't register deleted functions with
7807         gdbarch.
7808
7809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7812         (cris_unwind_pc): Delete.
7813         (cris_unwind_sp): Delete.
7814         (cris_gdbarch_init): Don't register deleted functions with
7815         gdbarch.
7816
7817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7820         (bfin_unwind_pc): Delete.
7821         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7822
7823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7826         (arm_unwind_pc): Delete.
7827         (arm_unwind_sp): Delete.
7828         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7829
7830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7833         (arc_unwind_pc): Delete.
7834         (arc_unwind_sp): Delete.
7835         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7836
7837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7840         (alpha_unwind_pc): Delete.
7841         (alpha_gdbarch_init): Don't register deleted functions with
7842         gdbarch.
7843
7844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7847         (aarch64_unwind_pc): Delete.
7848         (aarch64_unwind_sp): Delete.
7849         (aarch64_gdbarch_init): Don't register deleted functions with
7850         gdbarch.
7851
7852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7853
7854         * gdbtypes.c (type_align): Don't consider static members when
7855         computing structure alignment.
7856
7857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7860         return 0 for other types.
7861         * arch-utils.c (default_type_align): Always return 0.
7862         * gdbarch.h: Regenerate.
7863         * gdbarch.sh (type_align): Extend comment.
7864         * gdbtypes.c (type_align): Add additional comments, always call
7865         gdbarch_type_align before applying the default rules.
7866         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7867         generic code will then apply a suitable default.
7868         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7869         types, return 0 for other types.
7870
7871 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7872
7873         * NEWS: Create a new section for the next release branch.
7874         Rename the section of the current branch, now that it has
7875         been cut.
7876
7877 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7878
7879         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7880         * version.in: Bump version to 8.3.50.DATE-git.
7881
7882 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7883
7884         * aix-thread.c (ptid_cmp): Remove unused variable.
7885         (get_signaled_thread): Likewise.
7886         (store_regs_user_thread): Likewise.
7887         (store_regs_kernel_thread): Likewise.
7888         (fetch_regs_kernel_thread): Remove shadowed variable.
7889
7890 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7891
7892         * features/riscv/32bit-cpu.xml: Add register numbers.
7893         * features/riscv/32bit-fpu.c: Regenerate.
7894         * features/riscv/32bit-fpu.xml: Add register numbers.
7895         * features/riscv/64bit-cpu.xml: Add register numbers.
7896         * features/riscv/64bit-fpu.c: Regenerate.
7897         * features/riscv/64bit-fpu.xml: Add register numbers.
7898
7899 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7900
7901         * NEWS: Mention two argument form of gdb.Value constructor.
7902         * python/py-value.c (convert_buffer_and_type_to_value): New
7903         function.
7904         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7905         Add support for handling an optional second argument.  Call
7906         convert_buffer_and_type_to_value as appropriate.
7907         * python/python-internal.h (Py_buffer_deleter): New struct.
7908         (Py_buffer_up): New typedef.
7909
7910 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7911
7912         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7913         instead of releasing ownership.
7914
7915 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7916
7917         * dwarf2read.c (open_and_init_dwp_file): Call
7918         elf_numsections instead of bfd_count_sections to initialize
7919         dwp_file->num_sections.
7920
7921 2019-02-25  Tom Tromey  <tromey@adacore.com>
7922
7923         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7924
7925 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7926
7927         * gcore.in: Add '--readnever' option when invoking GDB.
7928
7929 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7930
7931         * MAINTAINERS: Update my email address.
7932
7933 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7934
7935         * build-id.c (build_id_to_debug_bfd_1): New function.
7936         (build_id_to_debug_bfd): Look for separate debug file in
7937         sysroot.
7938
7939 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7940
7941         * gdbarch.sh: Update the copyright year range that is placed into
7942         generated files.
7943
7944 2019-02-22  Keith Seitz  <keiths@redhat.com>
7945
7946         PR symtab/23853
7947         * linespec.c (create_sals_line_offset): Search for the default
7948         symtab's filename instead of its fullname.
7949
7950 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7951
7952         * NEWS: Update style defaults.
7953
7954 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7955
7956         * main.c (captured_main_1): Disable styling in batch mode.
7957
7958 2019-02-20  Tom Tromey  <tom@tromey.com>
7959
7960         * symtab.c (symtab_symbol_info): Fix typos.
7961
7962 2019-02-20  Tom Tromey  <tromey@adacore.com>
7963
7964         * findcmd.c (_initialize_mem_search): Use upper case for
7965         metasyntactic variables.
7966
7967 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7968
7969         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7970         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7971
7972 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7973
7974         * top.h (source_file_name): Change to std::string.
7975         * top.c (source_file_name): Likewise.
7976         (command_line_input): Adjust.
7977         * cli/cli-script.c (script_from_file): Adjust.
7978
7979 2019-02-19  Tom Tromey  <tromey@adacore.com>
7980
7981         * ravenscar-thread.c
7982         (ravenscar_thread_target::update_thread_list): Don't call
7983         ada_build_task_list.
7984         * ada-lang.h (ada_build_task_list): Don't declare.
7985         * ada-tasks.c (struct ada_tasks_inferior_data)
7986         <task_list_valid_p>: Now bool.
7987         (read_known_tasks, ada_task_list_changed)
7988         (ada_tasks_invalidate_inferior_data): Update.
7989         (read_known_tasks_array): Return bool.
7990         (read_known_tasks_list): Likewise.
7991         (read_known_tasks): Return void.
7992         (ada_build_task_list): Now static.
7993
7994 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7995
7996         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7997         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7998
7999 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8000
8001         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8002         variant for ada_tasks_pspace_data_handle and
8003         ada_tasks_inferior_data_handle.
8004         (ada_tasks_pspace_data_cleanup): New function.
8005         (ada_tasks_inferior_data_cleanup): New function.
8006
8007 2019-02-17  Tom Tromey  <tom@tromey.com>
8008
8009         * macrotab.h (macro_source_fullname): Return a std::string.
8010         * macrotab.c (macro_include, check_for_redefinition)
8011         (macro_undef, macro_lookup_definition, foreach_macro)
8012         (foreach_macro_in_scope): Update.
8013         (macro_source_fullname): Return a std::string.
8014         * macrocmd.c (show_pp_source_pos): Update.
8015
8016 2019-02-17  Tom Tromey  <tom@tromey.com>
8017
8018         * macrocmd.c (show_pp_source_pos): Style the file names.
8019
8020 2019-02-17  Tom Tromey  <tom@tromey.com>
8021
8022         PR tui/24197:
8023         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8024
8025 2019-02-17  Tom Tromey  <tom@tromey.com>
8026
8027         * ada-lang.c (user_select_syms): Use filtered printing.
8028         * utils.c (wrap_style): New global.
8029         (desired_style): Remove.
8030         (emit_style_escape): Add stream parameter.
8031         (set_output_style, reset_terminal_style, prompt_for_continue):
8032         Update.
8033         (flush_wrap_buffer): Only flush gdb_stdout.
8034         (wrap_here): Set wrap_style.
8035         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8036         treat escape sequences as a character.  Change when wrap buffer is
8037         flushed.
8038         (fputs_styled): Do not set the output style when the default is
8039         requested.
8040         * ui-style.h (struct ui_file_style) <is_default>: New method.
8041         * source.c (print_source_lines_base): Emit escape sequences in one
8042         piece.
8043
8044 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8045
8046         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8047         integers and enumeration types.
8048
8049 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8050
8051         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8052         instead of lookup_symbol_in_language
8053         (do_exact_match): New function.
8054         (ada_get_symbol_name_matcher): Return do_exact_match when
8055         doing a verbatim match.
8056
8057 2019-02-15  Tom Tromey  <tromey@adacore.com>
8058
8059         * ravenscar-thread.c (ravenscar_thread_target::resume)
8060         (ravenscar_thread_target::wait): Special case wildcard requests.
8061
8062 2019-02-15  Tom Tromey  <tromey@adacore.com>
8063
8064         * ravenscar-thread.c (base_ptid): Remove.
8065         (struct ravenscar_thread_target) <close>: New method.
8066         <m_base_ptid>: New member.
8067         <update_inferior_ptid, active_task, task_is_currently_active,
8068         runtime_initialized>: Declare methods.
8069         <ravenscar_thread_target>: Add constructor.
8070         (ravenscar_thread_target::task_is_currently_active)
8071         (ravenscar_thread_target::update_inferior_ptid)
8072         (ravenscar_runtime_initialized): Rename.  Now methods.
8073         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8074         (ravenscar_thread_target::update_thread_list): Update.
8075         (ravenscar_thread_target::active_task): Now method.
8076         (ravenscar_thread_target::store_registers)
8077         (ravenscar_thread_target::prepare_to_store)
8078         (ravenscar_thread_target::prepare_to_store)
8079         (ravenscar_thread_target::mourn_inferior): Update.
8080         (ravenscar_inferior_created): Use "new" to create target.
8081         (ravenscar_thread_target::get_ada_task_ptid): Update.
8082         (_initialize_ravenscar): Don't initialize base_ptid.
8083         (ravenscar_ops): Remove global.
8084
8085 2019-02-15  Tom Tromey  <tromey@adacore.com>
8086
8087         * target.h (push_target): Declare new overload.
8088         * target.c (push_target): New overload, taking an rvalue reference.
8089         * remote.c (remote_target::open_1): Use push_target overload.
8090         * corelow.c (core_target_open): Use push_target overload.
8091
8092 2019-02-15  Tom Tromey  <tromey@adacore.com>
8093
8094         * ravenscar-thread.c (is_ravenscar_task)
8095         (ravenscar_task_is_currently_active): Return bool.
8096         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8097         (_initialize_ravenscar): Remove "(void)".
8098         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8099         Return bool.
8100
8101 2019-02-15  Tom Tromey  <tromey@adacore.com>
8102
8103         * ravenscar-thread.c (ravenscar_runtime_initializer)
8104         (has_ravenscar_runtime, get_running_thread_id)
8105         (ravenscar_thread_target::resume): Fix indentation.
8106
8107 2019-02-15  Tom Tromey  <tromey@adacore.com>
8108
8109         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8110         from ravenscar_arch_ops.
8111         (sparc_ravenscar_ops::fetch_registers)
8112         (sparc_ravenscar_ops::store_registers): Now methods.
8113         (sparc_ravenscar_prepare_to_store): Remove.
8114         (sparc_ravenscar_ops): Redefine.
8115         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8116         methods and destructor.  Remove members.
8117         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8118         (ravenscar_thread_target::store_registers)
8119         (ravenscar_thread_target::prepare_to_store): Update.
8120         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8121         Remove.
8122         (struct ppc_ravenscar_powerpc_ops): Derive from
8123         ravenscar_arch_ops.
8124         (ppc_ravenscar_powerpc_ops::fetch_registers)
8125         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8126         (ppc_ravenscar_powerpc_ops): Redefine.
8127         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8128         (ppc_ravenscar_e500_ops::fetch_registers)
8129         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8130         (ppc_ravenscar_e500_ops): Redefine.
8131         * aarch64-ravenscar-thread.c
8132         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8133         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8134         (aarch64_ravenscar_fetch_registers)
8135         (aarch64_ravenscar_store_registers): Now methods.
8136         (aarch64_ravenscar_ops): Redefine.
8137
8138 2019-02-15  Tom Tromey  <tromey@adacore.com>
8139
8140         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8141         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8142         (ravenscar_thread_target::stopped_by_watchpoint)
8143         (ravenscar_thread_target::stopped_data_address)
8144         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8145
8146 2019-02-15  Tom Tromey  <tromey@adacore.com>
8147
8148         * ravenscar-thread.c: Fix some typos.
8149
8150 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8151             Tom Tromey  <tromey@adacore.com>
8152
8153         * ada-lang.c (ada_exception_sal): Change addr_string to a
8154         std::string.
8155         (create_ada_exception_catchpoint): Update.
8156
8157 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8158             Tom Tromey  <tromey@adacore.com>
8159
8160         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8161         (bp_location_ops): Remove.
8162         (base_breakpoint_allocate_location): Update.
8163         (free_bp_location): Update.
8164         * ada-lang.c (class ada_catchpoint_location)
8165         <ada_catchpoint_location>: Remove ops parameter.
8166         (ada_catchpoint_location_dtor): Remove.
8167         (ada_catchpoint_location_ops): Remove.
8168         (allocate_location_exception): Update.
8169         * breakpoint.h (struct bp_location_ops): Remove.
8170         (class bp_location) <bp_location>: Remove bp_location_ops
8171         parameter.
8172         <~bp_location>: Add destructor.
8173         <ops>: Remove.
8174
8175 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8176             Pedro Alves  <palves@redhat.com>
8177
8178         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8179         'PATH_MAX'.
8180
8181 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8182             Samuel Thibault  <samuel.thibault@gnu.org>
8183             Thomas Schwinge  <thomas@codesourcery.com>
8184
8185         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8186         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8187
8188 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8189
8190         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8191         (check_empty): Use "const char *".
8192
8193         * gnu-nat.c (gnu_nat_target::detach): Instead of
8194         'detach_inferior (pid)' call
8195         'detach_inferior (find_inferior_pid (pid))'.
8196
8197         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8198         'nat/fork-inferior.o'.
8199         * gnu-nat.c: #include "nat/fork-inferior.h".
8200
8201         * gnu-nat.c (gnu_nat_target::detach): Instead of
8202         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8203         * gnu-nat.h: #include "inf-child.h".
8204         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8205         'i386_gnu_nat_target::fetch_registers'.
8206         (gnu_store_registers): Rename/move to
8207         'i386_gnu_nat_target::store_registers'.
8208
8209         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8210         * gnu-nat.h (mach_thread_info): New function.
8211         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8212
8213         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8214
8215 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8216
8217         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8218
8219 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8220
8221         * windows-nat.c (windows_add_thread): Add new parameter
8222         "main_thread_p" with default value set to false.  Update
8223         function documentation as well as all callers.
8224         (windows_delete_thread): Likewise.
8225         (fake_create_process): Update call to windows_add_thread.
8226         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8227         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8228         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8229         call to windows_delete_thread.
8230
8231 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8232
8233         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8234
8235 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8236
8237         * symfile.c (find_separate_debug_file): Use canonical path of
8238         sysroot with child_path instead of gdb_sysroot if it is valid.
8239
8240 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8241
8242         * symfile.c (find_separate_debug_file): Use child_path to
8243         determine if an object file is under a sysroot.
8244
8245 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8246
8247         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8248         unittests/child-path-selftests.c.
8249         * common/pathstuff.c (child_path): New function.
8250         * common/pathstuff.h (child_path): New prototype.
8251         * unittests/child-path-selftests.c: New file.
8252
8253 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8254
8255         * symfile.c (find_separate_debug_file): Look for separate debug
8256         files in debug directories under the sysroot.
8257
8258 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8259
8260         * symtab.h (struct minimal_symbol data_p): New const method.
8261         (struct minimal_symbol text_p): Likewise.
8262         * symtab.c (output_source_filename): Use file name style
8263         to print file name.
8264         (print_symbol_info): Likewise.
8265         (print_msymbol_info): Use address style to print addresses.
8266         Use function name style to print executable text symbols.
8267         (expand_symtab_containing_pc): Use data_p.
8268         (find_pc_sect_compunit_symtab): Likewise.
8269
8270 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8271
8272         * breakpoint.c (describe_other_breakpoints): Use address style
8273         to print addresses.
8274         (say_where): Likewise.
8275
8276 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8277
8278         * ada-typeprint.c (print_func_type): Print function name
8279         style to print function name.
8280         * c-typeprint.c (c_print_type_1): Likewise.
8281
8282 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8283
8284         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8285         for execve.
8286
8287 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8288
8289         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8290         type_stack.
8291
8292 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8293
8294         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8295         TYPE_CODE_REF types.
8296
8297 2019-02-08  Jim Wilson  <jimw@sifive.com>
8298
8299         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8300         (riscv_linux_fregset): New.
8301         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8302
8303 2019-02-07  Tom Tromey  <tom@tromey.com>
8304
8305         * thread.c (thread_cancel_execution_command): Update.
8306         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8307         methods.
8308         (struct thread_fsm_ops): Remove.
8309         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8310         (thread_fsm_should_stop, thread_fsm_return_value)
8311         (thread_fsm_set_finished, thread_fsm_finished_p)
8312         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8313         Don't declare.
8314         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8315         * infrun.c (clear_proceed_status_thread)
8316         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8317         (print_stop_event): Update.
8318         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8319         Add constructor.
8320         (step_command_fsm_ops): Remove.
8321         (new_step_command_fsm): Remove.
8322         (step_1): Update.
8323         (step_command_fsm::should_stop): Rename from
8324         step_command_fsm_should_stop.
8325         (step_command_fsm::clean_up): Rename from
8326         step_command_fsm_clean_up.
8327         (step_command_fsm::do_async_reply_reason): Rename from
8328         step_command_fsm_async_reply_reason.
8329         (struct until_next_fsm): Inherit from thread_fsm.  Add
8330         constructor.
8331         (until_next_fsm_ops): Remove.
8332         (new_until_next_fsm): Remove.
8333         (until_next_fsm::should_stop): Rename from
8334         until_next_fsm_should_stop.
8335         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8336         (until_next_fsm::do_async_reply_reason): Rename from
8337         until_next_fsm_async_reply_reason.
8338         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8339         constructor.  Change type of breakpoint.
8340         (finish_command_fsm_ops): Remove.
8341         (new_finish_command_fsm): Remove.
8342         (finish_command_fsm::should_stop): Rename from
8343         finish_command_fsm_should_stop.
8344         (finish_command_fsm::clean_up): Rename from
8345         finish_command_fsm_clean_up.
8346         (finish_command_fsm::return_value): Rename from
8347         finish_command_fsm_return_value.
8348         (finish_command_fsm::do_async_reply_reason): Rename from
8349         finish_command_fsm_async_reply_reason.
8350         (finish_command): Update.
8351         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8352         Add constructor.
8353         (call_thread_fsm_ops): Remove.
8354         (call_thread_fsm::call_thread_fsm): Rename from
8355         new_call_thread_fsm.
8356         (call_thread_fsm::should_stop): Rename from
8357         call_thread_fsm_should_stop.
8358         (call_thread_fsm::should_notify_stop): Rename from
8359         call_thread_fsm_should_notify_stop.
8360         (run_inferior_call, call_function_by_hand_dummy): Update.
8361         * cli/cli-interp.c (should_print_stop_to_console): Update.
8362         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8363         Add constructor.  Change type of location_breakpoint,
8364         caller_breakpoint.
8365         (until_break_fsm_ops): Remove.
8366         (new_until_break_fsm): Remove.
8367         (until_break_fsm::should_stop): Rename from
8368         until_break_fsm_should_stop.
8369         (until_break_fsm::clean_up): Rename from
8370         until_break_fsm_clean_up.
8371         (until_break_fsm::do_async_reply_reason): Rename from
8372         until_break_fsm_async_reply_reason.
8373         (until_break_command): Update.
8374         * thread-fsm.c: Remove.
8375         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8376
8377 2019-02-07  Tom Tromey  <tom@tromey.com>
8378
8379         * yy-remap.h: Add include guard.
8380         * xtensa-tdep.h: Add include guard.
8381         * xcoffread.h: Rename include guard.
8382         * varobj-iter.h: Add include guard.
8383         * tui/tui.h: Rename include guard.
8384         * tui/tui-winsource.h: Rename include guard.
8385         * tui/tui-wingeneral.h: Rename include guard.
8386         * tui/tui-windata.h: Rename include guard.
8387         * tui/tui-win.h: Rename include guard.
8388         * tui/tui-stack.h: Rename include guard.
8389         * tui/tui-source.h: Rename include guard.
8390         * tui/tui-regs.h: Rename include guard.
8391         * tui/tui-out.h: Rename include guard.
8392         * tui/tui-layout.h: Rename include guard.
8393         * tui/tui-io.h: Rename include guard.
8394         * tui/tui-hooks.h: Rename include guard.
8395         * tui/tui-file.h: Rename include guard.
8396         * tui/tui-disasm.h: Rename include guard.
8397         * tui/tui-data.h: Rename include guard.
8398         * tui/tui-command.h: Rename include guard.
8399         * tic6x-tdep.h: Add include guard.
8400         * target/waitstatus.h: Rename include guard.
8401         * target/wait.h: Rename include guard.
8402         * target/target.h: Rename include guard.
8403         * target/resume.h: Rename include guard.
8404         * target-float.h: Rename include guard.
8405         * stabsread.h: Add include guard.
8406         * rs6000-tdep.h: Add include guard.
8407         * riscv-fbsd-tdep.h: Add include guard.
8408         * regformats/regdef.h: Rename include guard.
8409         * record.h: Rename include guard.
8410         * python/python.h: Rename include guard.
8411         * python/python-internal.h: Rename include guard.
8412         * python/py-stopevent.h: Rename include guard.
8413         * python/py-ref.h: Rename include guard.
8414         * python/py-record.h: Rename include guard.
8415         * python/py-record-full.h: Rename include guard.
8416         * python/py-record-btrace.h: Rename include guard.
8417         * python/py-instruction.h: Rename include guard.
8418         * python/py-events.h: Rename include guard.
8419         * python/py-event.h: Rename include guard.
8420         * procfs.h: Add include guard.
8421         * proc-utils.h: Add include guard.
8422         * p-lang.h: Add include guard.
8423         * or1k-tdep.h: Rename include guard.
8424         * observable.h: Rename include guard.
8425         * nto-tdep.h: Rename include guard.
8426         * nat/x86-linux.h: Rename include guard.
8427         * nat/x86-linux-dregs.h: Rename include guard.
8428         * nat/x86-gcc-cpuid.h: Add include guard.
8429         * nat/x86-dregs.h: Rename include guard.
8430         * nat/x86-cpuid.h: Rename include guard.
8431         * nat/ppc-linux.h: Rename include guard.
8432         * nat/mips-linux-watch.h: Rename include guard.
8433         * nat/linux-waitpid.h: Rename include guard.
8434         * nat/linux-ptrace.h: Rename include guard.
8435         * nat/linux-procfs.h: Rename include guard.
8436         * nat/linux-osdata.h: Rename include guard.
8437         * nat/linux-nat.h: Rename include guard.
8438         * nat/linux-namespaces.h: Rename include guard.
8439         * nat/linux-btrace.h: Rename include guard.
8440         * nat/glibc_thread_db.h: Rename include guard.
8441         * nat/gdb_thread_db.h: Rename include guard.
8442         * nat/gdb_ptrace.h: Rename include guard.
8443         * nat/fork-inferior.h: Rename include guard.
8444         * nat/amd64-linux-siginfo.h: Rename include guard.
8445         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8446         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8447         * nat/aarch64-linux.h: Rename include guard.
8448         * nat/aarch64-linux-hw-point.h: Rename include guard.
8449         * mn10300-tdep.h: Add include guard.
8450         * mips-linux-tdep.h: Add include guard.
8451         * mi/mi-parse.h: Rename include guard.
8452         * mi/mi-out.h: Rename include guard.
8453         * mi/mi-main.h: Rename include guard.
8454         * mi/mi-interp.h: Rename include guard.
8455         * mi/mi-getopt.h: Rename include guard.
8456         * mi/mi-console.h: Rename include guard.
8457         * mi/mi-common.h: Rename include guard.
8458         * mi/mi-cmds.h: Rename include guard.
8459         * mi/mi-cmd-break.h: Rename include guard.
8460         * m2-lang.h: Add include guard.
8461         * location.h: Rename include guard.
8462         * linux-record.h: Rename include guard.
8463         * linux-nat.h: Add include guard.
8464         * linux-fork.h: Add include guard.
8465         * i386-darwin-tdep.h: Rename include guard.
8466         * hppa-linux-offsets.h: Add include guard.
8467         * guile/guile.h: Rename include guard.
8468         * guile/guile-internal.h: Rename include guard.
8469         * gnu-nat.h: Rename include guard.
8470         * gdb-stabs.h: Rename include guard.
8471         * frv-tdep.h: Add include guard.
8472         * f-lang.h: Add include guard.
8473         * event-loop.h: Add include guard.
8474         * darwin-nat.h: Rename include guard.
8475         * cp-abi.h: Rename include guard.
8476         * config/sparc/nm-sol2.h: Rename include guard.
8477         * config/nm-nto.h: Rename include guard.
8478         * config/nm-linux.h: Add include guard.
8479         * config/i386/nm-i386gnu.h: Rename include guard.
8480         * config/djgpp/nl_types.h: Rename include guard.
8481         * config/djgpp/langinfo.h: Rename include guard.
8482         * compile/gcc-cp-plugin.h: Add include guard.
8483         * compile/gcc-c-plugin.h: Add include guard.
8484         * compile/compile.h: Rename include guard.
8485         * compile/compile-object-run.h: Rename include guard.
8486         * compile/compile-object-load.h: Rename include guard.
8487         * compile/compile-internal.h: Rename include guard.
8488         * compile/compile-cplus.h: Rename include guard.
8489         * compile/compile-c.h: Rename include guard.
8490         * common/xml-utils.h: Rename include guard.
8491         * common/x86-xstate.h: Rename include guard.
8492         * common/version.h: Rename include guard.
8493         * common/vec.h: Rename include guard.
8494         * common/tdesc.h: Rename include guard.
8495         * common/selftest.h: Rename include guard.
8496         * common/scoped_restore.h: Rename include guard.
8497         * common/scoped_mmap.h: Rename include guard.
8498         * common/scoped_fd.h: Rename include guard.
8499         * common/safe-iterator.h: Rename include guard.
8500         * common/run-time-clock.h: Rename include guard.
8501         * common/refcounted-object.h: Rename include guard.
8502         * common/queue.h: Rename include guard.
8503         * common/ptid.h: Rename include guard.
8504         * common/print-utils.h: Rename include guard.
8505         * common/preprocessor.h: Rename include guard.
8506         * common/pathstuff.h: Rename include guard.
8507         * common/observable.h: Rename include guard.
8508         * common/netstuff.h: Rename include guard.
8509         * common/job-control.h: Rename include guard.
8510         * common/host-defs.h: Rename include guard.
8511         * common/gdb_wait.h: Rename include guard.
8512         * common/gdb_vecs.h: Rename include guard.
8513         * common/gdb_unlinker.h: Rename include guard.
8514         * common/gdb_unique_ptr.h: Rename include guard.
8515         * common/gdb_tilde_expand.h: Rename include guard.
8516         * common/gdb_sys_time.h: Rename include guard.
8517         * common/gdb_string_view.h: Rename include guard.
8518         * common/gdb_splay_tree.h: Rename include guard.
8519         * common/gdb_setjmp.h: Rename include guard.
8520         * common/gdb_ref_ptr.h: Rename include guard.
8521         * common/gdb_optional.h: Rename include guard.
8522         * common/gdb_locale.h: Rename include guard.
8523         * common/gdb_assert.h: Rename include guard.
8524         * common/filtered-iterator.h: Rename include guard.
8525         * common/filestuff.h: Rename include guard.
8526         * common/fileio.h: Rename include guard.
8527         * common/environ.h: Rename include guard.
8528         * common/common-utils.h: Rename include guard.
8529         * common/common-types.h: Rename include guard.
8530         * common/common-regcache.h: Rename include guard.
8531         * common/common-inferior.h: Rename include guard.
8532         * common/common-gdbthread.h: Rename include guard.
8533         * common/common-exceptions.h: Rename include guard.
8534         * common/common-defs.h: Rename include guard.
8535         * common/common-debug.h: Rename include guard.
8536         * common/cleanups.h: Rename include guard.
8537         * common/buffer.h: Rename include guard.
8538         * common/btrace-common.h: Rename include guard.
8539         * common/break-common.h: Rename include guard.
8540         * cli/cli-utils.h: Rename include guard.
8541         * cli/cli-style.h: Rename include guard.
8542         * cli/cli-setshow.h: Rename include guard.
8543         * cli/cli-script.h: Rename include guard.
8544         * cli/cli-interp.h: Rename include guard.
8545         * cli/cli-decode.h: Rename include guard.
8546         * cli/cli-cmds.h: Rename include guard.
8547         * charset-list.h: Add include guard.
8548         * buildsym-legacy.h: Rename include guard.
8549         * bfin-tdep.h: Add include guard.
8550         * ax.h: Rename include guard.
8551         * arm-linux-tdep.h: Add include guard.
8552         * arm-fbsd-tdep.h: Add include guard.
8553         * arch/xtensa.h: Rename include guard.
8554         * arch/tic6x.h: Add include guard.
8555         * arch/i386.h: Add include guard.
8556         * arch/arm.h: Rename include guard.
8557         * arch/arm-linux.h: Rename include guard.
8558         * arch/arm-get-next-pcs.h: Rename include guard.
8559         * arch/amd64.h: Add include guard.
8560         * arch/aarch64-insn.h: Rename include guard.
8561         * arch-utils.h: Rename include guard.
8562         * annotate.h: Add include guard.
8563         * amd64-darwin-tdep.h: Rename include guard.
8564         * aarch64-linux-tdep.h: Add include guard.
8565         * aarch64-fbsd-tdep.h: Add include guard.
8566         * aarch32-linux-nat.h: Add include guard.
8567
8568 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8569
8570         * macrotab.c (macro_define_internal): New function that
8571         factorizes macro_define_object_internal and macro_define_function
8572         code.
8573         (macro_define_object_internal): Use macro_define_internal.
8574         (macro_define_function): Likewise.
8575
8576 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8577
8578         * macrocmd.c (extract_identifier): Return
8579         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8580         callers.
8581
8582 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8583
8584         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8585
8586 2019-02-05  Tom Tromey  <tom@tromey.com>
8587
8588         * target.c (target_stack::unpush): Move assertion earlier.
8589
8590 2019-01-30  Tom Tromey  <tom@tromey.com>
8591
8592         PR python/23615:
8593         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8594         (gdbpy_parse_and_eval): Likewise.
8595         * python/python-internal.h (gdbpy_allow_threads): New class.
8596
8597 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8598
8599         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8600         (aarch64_fbsd_fpregmap): Move earlier.
8601         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8602         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8603         instead of individual calls to trad_frame_set_reg_addr.
8604         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8605         earlier.
8606         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8607         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8608         instead of individual calls to trad_frame_set_reg_addr.
8609
8610 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8611
8612         * CONTRIBUTE: Replace contribution list with wiki link.
8613
8614 2019-01-25  Tom Tromey  <tom@tromey.com>
8615
8616         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8617
8618 2019-01-25  Tom Tromey  <tom@tromey.com>
8619
8620         * xtensa-linux-nat.c: Fix common/ includes.
8621         * xml-support.h: Fix common/ includes.
8622         * xml-support.c: Fix common/ includes.
8623         * x86-linux-nat.c: Fix common/ includes.
8624         * windows-nat.c: Fix common/ includes.
8625         * varobj.h: Fix common/ includes.
8626         * varobj.c: Fix common/ includes.
8627         * value.c: Fix common/ includes.
8628         * valops.c: Fix common/ includes.
8629         * utils.c: Fix common/ includes.
8630         * unittests/xml-utils-selftests.c: Fix common/ includes.
8631         * unittests/utils-selftests.c: Fix common/ includes.
8632         * unittests/unpack-selftests.c: Fix common/ includes.
8633         * unittests/tracepoint-selftests.c: Fix common/ includes.
8634         * unittests/style-selftests.c: Fix common/ includes.
8635         * unittests/string_view-selftests.c: Fix common/ includes.
8636         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8637         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8638         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8639         * unittests/rsp-low-selftests.c: Fix common/ includes.
8640         * unittests/parse-connection-spec-selftests.c: Fix common/
8641         includes.
8642         * unittests/optional-selftests.c: Fix common/ includes.
8643         * unittests/offset-type-selftests.c: Fix common/ includes.
8644         * unittests/observable-selftests.c: Fix common/ includes.
8645         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8646         * unittests/memrange-selftests.c: Fix common/ includes.
8647         * unittests/memory-map-selftests.c: Fix common/ includes.
8648         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8649         * unittests/function-view-selftests.c: Fix common/ includes.
8650         * unittests/environ-selftests.c: Fix common/ includes.
8651         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8652         * unittests/common-utils-selftests.c: Fix common/ includes.
8653         * unittests/cli-utils-selftests.c: Fix common/ includes.
8654         * unittests/array-view-selftests.c: Fix common/ includes.
8655         * ui-file.c: Fix common/ includes.
8656         * tui/tui-io.c: Fix common/ includes.
8657         * tracepoint.h: Fix common/ includes.
8658         * tracepoint.c: Fix common/ includes.
8659         * tracefile-tfile.c: Fix common/ includes.
8660         * top.h: Fix common/ includes.
8661         * top.c: Fix common/ includes.
8662         * thread.c: Fix common/ includes.
8663         * target/waitstatus.h: Fix common/ includes.
8664         * target/waitstatus.c: Fix common/ includes.
8665         * target.h: Fix common/ includes.
8666         * target.c: Fix common/ includes.
8667         * target-memory.c: Fix common/ includes.
8668         * target-descriptions.c: Fix common/ includes.
8669         * symtab.h: Fix common/ includes.
8670         * symfile.c: Fix common/ includes.
8671         * stap-probe.c: Fix common/ includes.
8672         * spu-linux-nat.c: Fix common/ includes.
8673         * sparc-nat.c: Fix common/ includes.
8674         * source.c: Fix common/ includes.
8675         * solib.c: Fix common/ includes.
8676         * solib-target.c: Fix common/ includes.
8677         * ser-unix.c: Fix common/ includes.
8678         * ser-tcp.c: Fix common/ includes.
8679         * ser-pipe.c: Fix common/ includes.
8680         * ser-base.c: Fix common/ includes.
8681         * selftest-arch.c: Fix common/ includes.
8682         * s12z-tdep.c: Fix common/ includes.
8683         * rust-exp.y: Fix common/ includes.
8684         * rs6000-aix-tdep.c: Fix common/ includes.
8685         * riscv-tdep.c: Fix common/ includes.
8686         * remote.c: Fix common/ includes.
8687         * remote-notif.h: Fix common/ includes.
8688         * remote-fileio.h: Fix common/ includes.
8689         * remote-fileio.c: Fix common/ includes.
8690         * regcache.h: Fix common/ includes.
8691         * regcache.c: Fix common/ includes.
8692         * record-btrace.c: Fix common/ includes.
8693         * python/python.c: Fix common/ includes.
8694         * python/py-type.c: Fix common/ includes.
8695         * python/py-inferior.c: Fix common/ includes.
8696         * progspace.h: Fix common/ includes.
8697         * producer.c: Fix common/ includes.
8698         * procfs.c: Fix common/ includes.
8699         * proc-api.c: Fix common/ includes.
8700         * printcmd.c: Fix common/ includes.
8701         * ppc-linux-nat.c: Fix common/ includes.
8702         * parser-defs.h: Fix common/ includes.
8703         * osdata.c: Fix common/ includes.
8704         * obsd-nat.c: Fix common/ includes.
8705         * nat/x86-linux.c: Fix common/ includes.
8706         * nat/x86-linux-dregs.c: Fix common/ includes.
8707         * nat/x86-dregs.h: Fix common/ includes.
8708         * nat/x86-dregs.c: Fix common/ includes.
8709         * nat/ppc-linux.c: Fix common/ includes.
8710         * nat/mips-linux-watch.h: Fix common/ includes.
8711         * nat/mips-linux-watch.c: Fix common/ includes.
8712         * nat/linux-waitpid.c: Fix common/ includes.
8713         * nat/linux-ptrace.h: Fix common/ includes.
8714         * nat/linux-ptrace.c: Fix common/ includes.
8715         * nat/linux-procfs.c: Fix common/ includes.
8716         * nat/linux-personality.c: Fix common/ includes.
8717         * nat/linux-osdata.c: Fix common/ includes.
8718         * nat/linux-namespaces.c: Fix common/ includes.
8719         * nat/linux-btrace.h: Fix common/ includes.
8720         * nat/linux-btrace.c: Fix common/ includes.
8721         * nat/fork-inferior.c: Fix common/ includes.
8722         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8723         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8724         * nat/aarch64-linux.c: Fix common/ includes.
8725         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8726         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8727         * namespace.h: Fix common/ includes.
8728         * mips-linux-tdep.c: Fix common/ includes.
8729         * minsyms.c: Fix common/ includes.
8730         * mi/mi-parse.h: Fix common/ includes.
8731         * mi/mi-main.c: Fix common/ includes.
8732         * mi/mi-cmd-env.c: Fix common/ includes.
8733         * memrange.h: Fix common/ includes.
8734         * memattr.c: Fix common/ includes.
8735         * maint.h: Fix common/ includes.
8736         * maint.c: Fix common/ includes.
8737         * main.c: Fix common/ includes.
8738         * machoread.c: Fix common/ includes.
8739         * location.c: Fix common/ includes.
8740         * linux-thread-db.c: Fix common/ includes.
8741         * linux-nat.c: Fix common/ includes.
8742         * linux-fork.c: Fix common/ includes.
8743         * inline-frame.c: Fix common/ includes.
8744         * infrun.c: Fix common/ includes.
8745         * inflow.c: Fix common/ includes.
8746         * inferior.h: Fix common/ includes.
8747         * inferior.c: Fix common/ includes.
8748         * infcmd.c: Fix common/ includes.
8749         * inf-ptrace.c: Fix common/ includes.
8750         * inf-child.c: Fix common/ includes.
8751         * ia64-linux-nat.c: Fix common/ includes.
8752         * i387-tdep.c: Fix common/ includes.
8753         * i386-tdep.c: Fix common/ includes.
8754         * i386-linux-tdep.c: Fix common/ includes.
8755         * i386-linux-nat.c: Fix common/ includes.
8756         * i386-go32-tdep.c: Fix common/ includes.
8757         * i386-fbsd-tdep.c: Fix common/ includes.
8758         * i386-fbsd-nat.c: Fix common/ includes.
8759         * guile/scm-type.c: Fix common/ includes.
8760         * guile/guile.c: Fix common/ includes.
8761         * go32-nat.c: Fix common/ includes.
8762         * gnu-nat.c: Fix common/ includes.
8763         * gdbthread.h: Fix common/ includes.
8764         * gdbarch-selftests.c: Fix common/ includes.
8765         * gdb_usleep.c: Fix common/ includes.
8766         * gdb_select.h: Fix common/ includes.
8767         * gdb_bfd.c: Fix common/ includes.
8768         * gcore.c: Fix common/ includes.
8769         * fork-child.c: Fix common/ includes.
8770         * findvar.c: Fix common/ includes.
8771         * fbsd-nat.c: Fix common/ includes.
8772         * event-top.c: Fix common/ includes.
8773         * event-loop.c: Fix common/ includes.
8774         * dwarf2read.c: Fix common/ includes.
8775         * dwarf2loc.c: Fix common/ includes.
8776         * dwarf2-frame.c: Fix common/ includes.
8777         * dwarf-index-cache.c: Fix common/ includes.
8778         * dtrace-probe.c: Fix common/ includes.
8779         * disasm-selftests.c: Fix common/ includes.
8780         * defs.h: Fix common/ includes.
8781         * csky-tdep.c: Fix common/ includes.
8782         * cp-valprint.c: Fix common/ includes.
8783         * cp-support.h: Fix common/ includes.
8784         * cp-support.c: Fix common/ includes.
8785         * corelow.c: Fix common/ includes.
8786         * completer.h: Fix common/ includes.
8787         * completer.c: Fix common/ includes.
8788         * compile/compile.c: Fix common/ includes.
8789         * compile/compile-loc2c.c: Fix common/ includes.
8790         * compile/compile-cplus-types.c: Fix common/ includes.
8791         * compile/compile-cplus-symbols.c: Fix common/ includes.
8792         * command.h: Fix common/ includes.
8793         * cli/cli-dump.c: Fix common/ includes.
8794         * cli/cli-cmds.c: Fix common/ includes.
8795         * charset.c: Fix common/ includes.
8796         * build-id.c: Fix common/ includes.
8797         * btrace.h: Fix common/ includes.
8798         * btrace.c: Fix common/ includes.
8799         * breakpoint.h: Fix common/ includes.
8800         * breakpoint.c: Fix common/ includes.
8801         * ax.h:
8802         (enum agent_op): Fix common/ includes.
8803         * ax-general.c (struct aop_map): Fix common/ includes.
8804         * ax-gdb.c: Fix common/ includes.
8805         * auxv.c: Fix common/ includes.
8806         * auto-load.c: Fix common/ includes.
8807         * arm-tdep.c: Fix common/ includes.
8808         * arch/riscv.c: Fix common/ includes.
8809         * arch/ppc-linux-common.c: Fix common/ includes.
8810         * arch/i386.c: Fix common/ includes.
8811         * arch/arm.c: Fix common/ includes.
8812         * arch/arm-linux.c: Fix common/ includes.
8813         * arch/arm-get-next-pcs.c: Fix common/ includes.
8814         * arch/amd64.c: Fix common/ includes.
8815         * arch/aarch64.c: Fix common/ includes.
8816         * arch/aarch64-insn.c: Fix common/ includes.
8817         * arch-utils.c: Fix common/ includes.
8818         * amd64-windows-tdep.c: Fix common/ includes.
8819         * amd64-tdep.c: Fix common/ includes.
8820         * amd64-sol2-tdep.c: Fix common/ includes.
8821         * amd64-obsd-tdep.c: Fix common/ includes.
8822         * amd64-nbsd-tdep.c: Fix common/ includes.
8823         * amd64-linux-tdep.c: Fix common/ includes.
8824         * amd64-linux-nat.c: Fix common/ includes.
8825         * amd64-fbsd-tdep.c: Fix common/ includes.
8826         * amd64-fbsd-nat.c: Fix common/ includes.
8827         * amd64-dicos-tdep.c: Fix common/ includes.
8828         * amd64-darwin-tdep.c: Fix common/ includes.
8829         * agent.c: Fix common/ includes.
8830         * ada-lang.h: Fix common/ includes.
8831         * ada-lang.c: Fix common/ includes.
8832         * aarch64-tdep.c: Fix common/ includes.
8833
8834 2019-01-25  Tom Tromey  <tom@tromey.com>
8835
8836         * common/create-version.sh: Use common/version.h.
8837
8838 2019-01-24  Pedro Alves  <palves@redhat.com>
8839
8840         * infrun.c (signal_stop, signal_print, signal_program)
8841         (signal_catch, signal_pass): Now arrays instead of pointers.
8842         (update_signals_program_target, do_target_resume)
8843         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8844         * linux-nat.c (linux_nat_target::pass_signals)
8845         (linux_nat_target::create_inferior, linux_nat_target::attach):
8846         Adjust.
8847         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8848         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8849         * procfs.c (procfs_target::pass_signals): Adjust.
8850         * record-full.c (record_full_target::resume): Adjust.
8851         * remote.c (remote_target::pass_signals)
8852         (remote_target::program_signals): Adjust.
8853         * target-debug.h (target_debug_print_signals): Now takes a
8854         gdb::array_view as parameter.  Adjust.
8855         * target.h (target_ops) <pass_signals, program_signals>: Replace
8856         pointer and length parameters with gdb::array_view.
8857         (target_pass_signals, target_program_signals): Likewise.
8858         * target-delegates.c: Regenerate.
8859
8860 2019-01-24  Pedro Alves  <palves@redhat.com>
8861
8862         * common/forward-scope-exit.h
8863         (forward_scope_exit::forward_scope_exit): Pass arguments to
8864         m_bind_function directly, instead of creating a std::bind and
8865         copying that.
8866
8867 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8868
8869         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8870         for static members.
8871         (pass_in_v_vfp_candidate): Likewise.
8872
8873 2019-01-23  Tom Tromey  <tom@tromey.com>
8874             Pedro Alves  <palves@redhat.com>
8875
8876         * regcache.c (class regcache_invalidator): Remove.
8877         (regcache::raw_write): Use make_scope_exit.
8878
8879 2019-01-23  Tom Tromey  <tom@tromey.com>
8880
8881         * ui-out.h (class ui_out_emit_type): Update comment.
8882
8883 2019-01-23  Tom Tromey  <tom@tromey.com>
8884
8885         * infrun.c (fetch_inferior_event): Update comment.
8886
8887 2019-01-23  Tom Tromey  <tom@tromey.com>
8888             Pedro Alves  <palves@redhat.com>
8889
8890         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8891         parameter.
8892         (fetch_inferior_event): Use SCOPE_EXIT.
8893
8894
8895 2019-01-23  Tom Tromey  <tom@tromey.com>
8896             Pedro Alves  <palves@redhat.com>
8897
8898         * infrun.c (disable_thread_events): Delete.
8899         (stop_all_threads): Use SCOPE_EXIT.
8900
8901 2019-01-23  Tom Tromey  <tom@tromey.com>
8902             Pedro Alves  <palves@redhat.com>
8903
8904         * symfile.c: Include forward-scope-exit.h.
8905         (clear_symtab_users_cleanup): Replace forward declaration with
8906         a FORWARD_SCOPE_EXIT.
8907         (syms_from_objfile_1): Use the forward_scope_exit and
8908         gdb::optional instead of cleanup_function.
8909         (reread_symbols): Use the forward_scope_exit instead of
8910         cleanup_function.
8911         (clear_symtab_users_cleanup): Remove function.
8912
8913 2019-01-23  Tom Tromey  <tom@tromey.com>
8914             Pedro Alves  <palves@redhat.com>
8915
8916         * linux-nat.c: Include scope-exit.h.
8917         (cleanup_target_stop): Remove.
8918         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8919         SCOPE_EXIT.
8920
8921 2019-01-23  Tom Tromey  <tom@tromey.com>
8922             Pedro Alves  <palves@redhat.com>
8923
8924         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8925         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8926
8927 2019-01-23  Tom Tromey  <tom@tromey.com>
8928             Andrew Burgess  <andrew.burgess@embecosm.com>
8929             Pedro Alves  <palves@redhat.com>
8930
8931         * infrun.c (fetch_inferior_event): Use scope_exit.
8932         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8933         * top.c (execute_command): Use scope_exit.
8934         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8935         * utils.c (do_bpstat_clear_actions_cleanup)
8936         (make_bpstat_clear_actions_cleanup): Remove.
8937
8938 2019-01-23  Tom Tromey  <tom@tromey.com>
8939             Pedro Alves  <palves@redhat.com>
8940
8941         * infrun.c: Include "common/scope-exit.h"
8942         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8943         (wait_for_inferior): Use SCOPE_EXIT.
8944         (fetch_inferior_event): Use scope_exit.
8945
8946 2019-01-23  Tom Tromey  <tom@tromey.com>
8947             Pedro Alves  <palves@redhat.com>
8948
8949         * breakpoint.c (create_breakpoint): Remove cleanup.
8950
8951 2019-01-23  Tom Tromey  <tom@tromey.com>
8952             Andrew Burgess  <andrew.burgess@embecosm.com>
8953             Pedro Alves  <palves@redhat.com>
8954
8955 2019-01-23  Pedro Alves  <palves@redhat.com>
8956
8957         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8958
8959 2019-01-23  Pedro Alves  <palves@redhat.com>
8960             Andrew Burgess  <andrew.burgess@embecosm.com>
8961
8962         * gdbthread.h: Include "common/forward-scope-exit.h".
8963         (scoped_finish_thread_state): Redefine custom class in terms of
8964         forward_scope_exit.
8965
8966 2019-01-23  Pedro Alves  <palves@redhat.com>
8967             Andrew Burgess  <andrew.burgess@embecosm.com>
8968
8969         * common/forward-scope-exit.h: New file.
8970
8971 2019-01-23  Pedro Alves  <palves@redhat.com>
8972             Andrew Burgess  <andrew.burgess@embecosm.com>
8973             Tom Tromey  <tom@tromey.com>
8974
8975         * common/scope-exit.h: New file.
8976
8977 2019-01-23  Pedro Alves  <palves@redhat.com>
8978
8979         * common/preprocessor.h (ESC): Rename to ...
8980         (ESC_PARENS): ... this.
8981         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8982         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8983
8984 2019-01-23  Tom Tromey  <tom@tromey.com>
8985
8986         * language.h (class scoped_switch_to_sym_language_if_auto):
8987         Initialize m_lang in both cases.
8988
8989 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8990
8991         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8992         with XCNEW.
8993
8994 2019-01-22  Tom Tromey  <tom@tromey.com>
8995
8996         * corelow.c: Do not include sys/file.h.
8997
8998 2019-01-22  Tom Tromey  <tom@tromey.com>
8999
9000         * tui/tui-wingeneral.h: Include gdb_curses.h.
9001
9002 2019-01-22  Tom Tromey  <tom@tromey.com>
9003
9004         * source-cache.h (class source_cache) <get_source_lines,
9005         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9006
9007 2019-01-22  Tom Tromey  <tom@tromey.com>
9008
9009         * remote-fileio.h (struct remote_target): Declare.
9010
9011 2019-01-22  Tom Tromey  <tom@tromey.com>
9012
9013         * python/py-arch.c: Do not include py-ref.h.
9014         * python/py-bpevent.c: Do not include py-ref.h.
9015         * python/py-cmd.c: Do not include py-ref.h.
9016         * python/py-continueevent.c: Do not include py-ref.h.
9017         * python/py-event.h: Do not include py-ref.h.
9018         * python/py-evtregistry.c: Do not include py-ref.h.
9019         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9020         * python/py-frame.c: Do not include py-ref.h.
9021         * python/py-framefilter.c: Do not include py-ref.h.
9022         * python/py-function.c: Do not include py-ref.h.
9023         * python/py-infevents.c: Do not include py-ref.h.
9024         * python/py-linetable.c: Do not include py-ref.h.
9025         * python/py-objfile.c: Do not include py-ref.h.
9026         * python/py-param.c: Do not include py-ref.h.
9027         * python/py-prettyprint.c: Do not include py-ref.h.
9028         * python/py-progspace.c: Do not include py-ref.h.
9029         * python/py-symbol.c: Do not include py-ref.h.
9030         * python/py-symtab.c: Do not include py-ref.h.
9031         * python/py-type.c: Do not include py-ref.h.
9032         * python/py-unwind.c: Do not include py-ref.h.
9033         * python/py-utils.c: Do not include py-ref.h.
9034         * python/py-value.c: Do not include py-ref.h.
9035         * python/py-varobj.c: Do not include py-ref.h.
9036         * python/py-xmethods.c: Do not include py-ref.h.
9037         * python/python.c: Do not include py-ref.h.
9038         * varobj.c: Do not include py-ref.h.
9039
9040 2019-01-22  Tom Tromey  <tom@tromey.com>
9041
9042         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9043         keyword for bcache.
9044
9045 2019-01-22  Tom Tromey  <tom@tromey.com>
9046
9047         * compile/compile-cplus-types.c: Remove a comment by #include.
9048
9049 2019-01-22  Tom Tromey  <tom@tromey.com>
9050
9051         * compile/gcc-c-plugin.h: Include compile-internal.h.
9052
9053 2019-01-22  Tom Tromey  <tom@tromey.com>
9054
9055         * stabsread.c (EXTERN): Do not define.
9056         (symnum, next_symbol_text_func, processing_gcc_compilation)
9057         (within_function, global_sym_chain, global_stabs)
9058         (previous_stab_code, this_object_header_files)
9059         (n_this_object_header_files)
9060         (n_allocated_this_object_header_files): Define.
9061         * stabsread.h (EXTERN): Never define.  Use "extern".
9062
9063 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9064
9065         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9066         history_value.
9067
9068 2019-01-21  Tom Tromey  <tom@tromey.com>
9069
9070         * ui-out.c: Fix includes.
9071         * tui/tui-source.c: Fix includes.
9072         * target.c: Fix includes.
9073         * remote.c: Fix includes.
9074         * regcache.c: Fix includes.
9075         * python/py-block.c: Fix includes.
9076         * printcmd.c: Fix includes.
9077         * or1k-tdep.c: Fix includes.
9078         * mi/mi-main.c: Fix includes.
9079         * m32r-tdep.c: Fix includes.
9080         * csky-tdep.c: Fix includes.
9081         * compile/compile-cplus-types.c: Fix includes.
9082         * cli/cli-interp.c: Fix includes.
9083
9084 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9085
9086         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9087         for padding.
9088
9089 2019-01-16  Tom Tromey  <tom@tromey.com>
9090
9091         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9092         earlier.
9093         (struct objfile) <msymbols_range>: Move from top level.
9094         <msymbols>: New method.
9095         (class objfile_msymbols): Remove.
9096         * symtab.c (default_collect_symbol_completion_matches_break_on):
9097         Update.
9098         * symmisc.c (dump_msymbols): Update.
9099         * stabsread.c (scan_file_globals): Update.
9100         * objc-lang.c (info_selectors_command, info_classes_command)
9101         (find_methods): Update.
9102         * minsyms.c (find_solib_trampoline_target): Update.
9103         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9104         * coffread.c (coff_symfile_read): Update.
9105         * ada-lang.c (ada_lookup_simple_minsym)
9106         (ada_collect_symbol_completion_matches): Update.
9107
9108 2019-01-16  Tom Tromey  <tom@tromey.com>
9109
9110         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9111         type.  Remove no-argument constructor.
9112         <iterator::operator++>: Simplify.
9113         <begin>: Update.
9114         <end>: Use minimal_symbol_count.
9115
9116 2019-01-16  Tom Tromey  <tom@tromey.com>
9117
9118         * objfiles.h (struct objfile) <psymtabs>: New method.
9119         (class objfile_psymtabs): Remove.
9120         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9121         typedef.
9122         <range>: New method.
9123         (require_partial_symbols): Change return type.
9124         * psymtab.c (require_partial_symbols)
9125         (psym_expand_symtabs_matching): Update.
9126         * mdebugread.c (parse_partial_symbols): Update.
9127         * dbxread.c (dbx_end_psymtab): Update.
9128
9129 2019-01-15  Tom Tromey  <tom@tromey.com>
9130
9131         * symtab.c (lookup_objfile_from_block)
9132         (lookup_symbol_in_objfile_symtabs)
9133         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9134         (find_line_symtab, info_sources_command)
9135         (default_collect_symbol_completion_matches_break_on)
9136         (make_source_files_completion_list): Update.
9137         * symmisc.c (print_objfile_statistics, dump_objfile)
9138         (maintenance_print_symbols, maintenance_info_symtabs)
9139         (maintenance_check_symtabs, maintenance_info_line_tables):
9140         Update.
9141         * source.c (select_source_symtab)
9142         (forget_cached_source_info_for_objfile): Update.
9143         * objfiles.h (class objfile_compunits): Remove.
9144         (struct objfile) <compunits_range>: New typedef.
9145         (compunits): New method.
9146         * objfiles.c (objfile_relocate1): Update.
9147         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9148         * maint.c (count_symtabs_and_blocks): Update.
9149         * linespec.c (iterate_over_all_matching_symtabs): Update.
9150         * cp-support.c (add_symbol_overload_list_qualified): Update.
9151         * coffread.c (coff_symtab_read): Update.
9152         * ada-lang.c (add_nonlocal_symbols)
9153         (ada_collect_symbol_completion_matches)
9154         (ada_add_global_exceptions): Update.
9155
9156 2019-01-15  Tom Tromey  <tom@tromey.com>
9157
9158         * progspace.h (program_space) <objfiles_safe_range>: New
9159         typedef.
9160         <objfiles_safe>: New method.
9161         * objfiles.h (class all_objfiles_safe): Remove.
9162         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9163         * jit.c (jit_inferior_exit_hook): Update.
9164
9165 2019-01-17  Tom Tromey  <tom@tromey.com>
9166
9167         * progspace.h (program_space) <objfiles_range>: New typedef.
9168         <objfiles>: New method.
9169         <objfiles_head>: Rename from objfiles.
9170         (object_files): Update.
9171         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9172         * guile/scm-pretty-print.c
9173         (ppscm_find_pretty_printer_from_objfiles): Update.
9174         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9175         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9176         Update.
9177         * python/py-progspace.c (pspy_get_objfiles): Update.
9178         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9179         Update.
9180         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9181         (objfpy_lookup_objfile_by_build_id): Update.
9182         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9183         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9184         Update.
9185         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9186         (expand_symtab_containing_pc, lookup_objfile_from_block)
9187         (lookup_static_symbol, basic_lookup_transparent_type)
9188         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9189         (find_line_symtab, info_sources_command)
9190         (default_collect_symbol_completion_matches_break_on)
9191         (make_source_files_completion_list, find_main_name): Update.
9192         * symmisc.c (print_symbol_bcache_statistics)
9193         (print_objfile_statistics, maintenance_print_symbols)
9194         (maintenance_print_msymbols, maintenance_print_objfiles)
9195         (maintenance_info_symtabs, maintenance_check_symtabs)
9196         (maintenance_expand_symtabs, maintenance_info_line_tables):
9197         Update.
9198         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9199         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9200         (map_overlay_command, unmap_overlay_command)
9201         (simple_overlay_update, expand_symtabs_matching)
9202         (map_symbol_filenames): Update.
9203         * symfile-debug.c (set_debug_symfile): Update.
9204         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9205         Update.
9206         * source.c (select_source_symtab, forget_cached_source_info):
9207         Update.
9208         * solib.c (solib_read_symbols): Update.
9209         * solib-spu.c (append_ocl_sos): Update.
9210         * psymtab.c (maintenance_print_psymbols)
9211         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9212         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9213         * printcmd.c (info_symbol_command): Update.
9214         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9215         Update.
9216         * objfiles.h (class all_objfiles): Remove.
9217         * objfiles.c (have_partial_symbols, have_full_symbols)
9218         (have_minimal_symbols, qsort_cmp, update_section_map)
9219         (shared_objfile_contains_address_p)
9220         (default_iterate_over_objfiles_in_search_order): Update.
9221         * objc-lang.c (info_selectors_command, info_classes_command)
9222         (find_methods): Update.
9223         * minsyms.c (find_solib_trampoline_target): Update.
9224         * maint.c (maintenance_info_sections)
9225         (maintenance_translate_address, count_symtabs_and_blocks):
9226         Update.
9227         * main.c (captured_main_1): Update.
9228         * linux-thread-db.c (try_thread_db_load_from_pdir)
9229         (has_libpthread): Update.
9230         * linespec.c (iterate_over_all_matching_symtabs)
9231         (search_minsyms_for_name): Update.
9232         * jit.c (jit_find_objf_with_entry_addr): Update.
9233         * hppa-tdep.c (find_unwind_entry)
9234         (hppa_lookup_stub_minimal_symbol): Update.
9235         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9236         Update.
9237         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9238         (elf_gnu_ifunc_resolve_by_got): Update.
9239         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9240         * dwarf-index-write.c (save_gdb_index_command): Update.
9241         * cp-support.c (add_symbol_overload_list_qualified): Update.
9242         * breakpoint.c (create_overlay_event_breakpoint)
9243         (create_longjmp_master_breakpoint)
9244         (create_std_terminate_master_breakpoint)
9245         (create_exception_master_breakpoint): Update.
9246         * blockframe.c (find_pc_partial_function): Update.
9247         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9248         (ada_collect_symbol_completion_matches)
9249         (ada_add_global_exceptions): Update.
9250
9251 2019-01-17  Tom Tromey  <tom@tromey.com>
9252
9253         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9254         declare VEC.
9255         (solib_target_parse_libraries): Change return type.
9256         (library_list_start_segment, library_list_start_section)
9257         (library_list_end_library, library_list_start_library); Update.
9258         (solib_target_free_library_list): Remove.
9259         (solib_target_parse_libraries): Remove cleanup.  Change return
9260         type.
9261         (solib_target_current_sos): Update.
9262
9263 2019-01-17  Tom Tromey  <tromey@bapiya>
9264
9265         * valprint.c: Replace "the the" with "the".
9266         * symtab.c: Replace "the the" with "the".
9267         * solib.c: Replace "the the" with "the".
9268         * solib-dsbt.c: Replace "the the" with "the".
9269         * linespec.c: Replace "the the" with "the".
9270         * dwarf2loc.h: Replace "the the" with "the".
9271         * amd64-windows-tdep.c: Replace "the the" with "the".
9272         * aarch64-tdep.c: Replace "the the" with "the".
9273
9274 2019-01-16  Keith Seitz  <keiths@redhat.com>
9275
9276         PR gdb/23773
9277         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9278         <builder>: Rename to ..
9279         <m_builder>: ... this and make private.
9280         (dwarf2_cu::get_builder): New method.  Change all users of
9281         `builder' to use this method.
9282         (dwarf2_start_symtab): Move to ...
9283         (dwarf2_cu::start_symtab): ... here.  Update all callers
9284         (setup_type_unit_groups): Move to ...
9285         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9286         callers.
9287         (dwarf2_cu::reset_builder): New method.
9288         (process_full_compunit, process_full_type_unit): Use
9289         dwarf2_cu::reset_builder.
9290         (follow_die_offset): Record the ancestor CU if it is different
9291         from the followed DIE's CU.
9292         (follow_die_sig_1): Likewise.
9293
9294 2019-01-15  Tom Tromey  <tom@tromey.com>
9295
9296         * remote.c (class remote_state) <buf>: Now a char_vector.
9297         <buf_size>: Remove.
9298         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9299         parameter.
9300         (remote_target::getpkt_or_notif_sane_1)
9301         (remote_target::getpkt_sane)
9302         (remote_target::getpkt_or_notif_sane): Likewise.
9303         (class remote_target) <putpkt>: New overload.
9304         (remote_target::read_frame): Change type of "buf_p".  Remove
9305         sizeof_p parameter.
9306         (packet_ok): New overload.
9307         (packet_check_result): New overload.
9308         Update all uses.
9309
9310 2019-01-14  Tom Tromey  <tom@tromey.com>
9311
9312         * remote-notif.c (handle_notification, remote_notif_ack)
9313         (remote_notif_parse): Make "buf" const.
9314         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9315         const.
9316         (remote_notif_parse, remote_notif_ack, handle_notification):
9317         Likewise.
9318         * remote.c (remote_notif_stop_parse): Make "buf" const.
9319         (remote_target::remote_parse_stop_reply): Make "buf" const.
9320         (remote_notif_stop_ack): Make "buf" const.
9321
9322 2019-01-14  Tom Tromey  <tom@tromey.com>
9323
9324         * remote.c (remote_console_output): Make parameter const.
9325
9326 2019-01-14  Tom Tromey  <tom@tromey.com>
9327
9328         * target-debug.h (target_debug_print_signals): Constify.
9329         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9330         * procfs.c (procfs_target::pass_signals): Update.
9331         * linux-nat.c (linux_nat_target::pass_signals): Update.
9332         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9333         * target-delegates.c: Rebuild.
9334         * remote.c (remote_target::program_signals): Update.
9335         (remote_target::pass_signals): Update.
9336         * target.c (target_pass_signals): Constify argument.
9337         (target_program_signals): Likewise.
9338         * target.h (struct target_ops) <pass_signals, program_signals>:
9339         Constify argument.
9340         (target_pass_signals, target_program_signals): Constify argument.
9341
9342 2019-01-14  Tom Tromey  <tom@tromey.com>
9343
9344         PR tui/28819:
9345         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9346
9347 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9348
9349         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9350         field.
9351         * rs6000-tdep.c: Include reggroups.h.
9352         (IS_V_ALIAS_PSEUDOREG): Define.
9353         (rs6000_register_name): Return names for the "vX" aliases.
9354         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9355         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9356         aliases.  Call default_register_reggroup_p for all other
9357         pseudo-registers.
9358         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9359         New functions.
9360         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9361         Handle "vX" aliases.
9362         (v_alias_pseudo_register_collect): New function.
9363         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9364         (rs6000_gdbarch_init): Initialize "vX" aliases as
9365         pseudo-registers.  Restore registration of
9366         rs6000_pseudo_register_reggroup_p with
9367         set_tdesc_pseudo_register_reggroup_p.
9368
9369 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9370
9371         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9372         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9373         set_gdbarch_num_pseudo_regs.
9374
9375 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9376
9377         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9378         Remove arg prefixname, add do_set and do_show.
9379         Add member functions set_list and show_list.
9380         * cli/cli-style.c (class cli_style_option): Update accordingly.
9381         (style_set_list): Move to file scope.
9382         (style_show_list): Likewise.
9383         (set_style): Call help_list.
9384         (show_style): Call cmd_show_list.
9385         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9386         Update to use the new macro.
9387
9388 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9389
9390         * ada-lang.c (_initialize_ada_language): Expand the help text
9391         for the "catch exception" command.
9392
9393 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9394
9395         * symtab.c (matching_obj_sections): Initialize obj,
9396         declare it closer to its usage.
9397
9398 2019-01-10  Tom Tromey  <tom@tromey.com>
9399
9400         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9401         (basic_inf_threads_range): Remove.
9402         (inf_threads_range, inf_non_exited_threads_range)
9403         (safe_inf_threads_range): Use next_adapter.
9404
9405 2019-01-10  Keith Seitz  <keiths@redhat.com>
9406
9407         PR gdb/23712
9408         PR symtab/23010
9409         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9410         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9411
9412 2019-01-10  Keith Seitz  <keiths@redhat.com>
9413
9414         PR gdb/23712
9415         PR symtab/23010
9416         * dictionary.c (pending_to_vector): Remove.
9417         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9418         Remove _1 suffix, replacing functions of the same name.  Update
9419         all callers.
9420         (dict_create_hashed, dict_create_hashed_expandable)
9421         (dict_create_linear, dict_create_linear_expandable, dict_free)
9422         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9423         Make functions static.
9424
9425 2019-01-10  Keith Seitz  <keiths@redhat.com>
9426
9427         PR gdb/23712
9428         PR symtab/23010
9429         * dictionary.h (struct dictionary): Replace declaration with
9430         multidictionary.
9431         (dict_create_hashed, dict_create_hashed_expandable)
9432         (dict_create_linear, dict_create_linear_expandable)
9433         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9434         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9435         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9436         taking multidictionary argument.
9437         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9438         * block.h (struct block) <dict>: Change to multidictionary
9439         and rename `multidict'.
9440         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9441         symmisc.c: Update all dictionary references to multidictionary.
9442
9443 2019-01-10  Keith Seitz  <keiths@redhat.com>
9444
9445         PR gdb/23712
9446         PR symtab/23010
9447         * dictionary.c: Include unordered_map.
9448         (pending_to_vector): New function.
9449         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9450         Rewrite the non-"_1" functions to take vector instead
9451         of linked list.
9452         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9453         "new" _1 versions of the same name.
9454         (multidictionary): Define.
9455         (std::hash<enum language): New definition.
9456         (collate_pending_symbols_by_language, mdict_create_hashed)
9457         (mdict_create_hashed_expandable, mdict_create_linear)
9458         (mdict_create_linear_expandable, mdict_free)
9459         (find_language_dictionary, create_new_language_dictionary)
9460         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9461         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9462         (mdict_size, mdict_empty): New functions.
9463         * dictionary.h (mdict_iterator): Define.
9464
9465 2019-01-10  Pedro Alves  <palves@redhat.com>
9466
9467         * breakpoint.c (read_uploaded_action)
9468         (create_tracepoint_from_upload): Adjust to use
9469         gdb::unique_xmalloc_ptr.
9470         * ctf.c (ctf_write_uploaded_tp):
9471         (SET_ARRAY_FIELD): Use emplace_back.
9472         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9473         * tracefile-tfile.c (tfile_write_uploaded_tp):
9474         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9475         gdb::unique_xmalloc_ptr.
9476         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9477         at_string, cond_string, cmd_strings>: Replace char pointers
9478         with gdb::unique_xmalloc_ptr.
9479
9480 2019-01-10  Pedro Alves  <palves@redhat.com>
9481
9482         * solib-target.c (library_list_start_library): Don't xstrdup name.
9483
9484 2019-01-10  Pedro Alves  <palves@redhat.com>
9485
9486         * mdebugread.c (parse_partial_symbols): Use
9487         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9488
9489 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9490
9491         * linux-fork.c (scoped_switch_fork_info)
9492         <~scoped_switch_fork_info>: Fix incorrect variable name.
9493
9494 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9495
9496         * linux-fork.c (scoped_switch_fork_info)
9497         <scoped_switch_fork_info>: Make explicit.
9498         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9499
9500 2019-01-10  Tom Tromey  <tom@tromey.com>
9501
9502         * objfiles.h (objfile::reset_psymtabs): Update.
9503         * objfiles.c (objfile::objfile): Update.
9504         * psymtab.h (psymtab_storage::obstack): Update.
9505         (psymtab_storage::m_obstack): Use gdb::optional.
9506         (class psymtab_storage): Update comment.  Remove objfile
9507         parameter.
9508         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9509
9510 2019-01-10  Tom Tromey  <tom@tromey.com>
9511
9512         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9513         <free_psymtabs>: Now private.
9514         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9515         (allocate_psymtab): Use new method.
9516
9517 2019-01-10  Tom Tromey  <tom@tromey.com>
9518
9519         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9520         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9521         * mdebugread.c (parse_partial_symbols): Use
9522         allocate_dependencies.
9523         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9524         allocate_dependencies.
9525         (process_psymtab_comp_unit_reader)
9526         (build_type_psymtab_dependencies): Likewise.
9527         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9528
9529 2019-01-10  Tom Tromey  <tom@tromey.com>
9530
9531         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9532         PSYMBOL_SET_LANGUAGE.
9533         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9534
9535 2019-01-10  Tom Tromey  <tom@tromey.com>
9536
9537         * psymtab.h (psymtab_storage::obstack): New method.
9538         <m_obstack>: Rename from obstack; now private.
9539         * psymtab.c (psymtab_storage): Update.
9540         * dwarf2read.c (create_addrmap_from_index)
9541         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9542         Update.
9543
9544 2019-01-10  Tom Tromey  <tom@tromey.com>
9545
9546         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9547         * objfiles.h (objfile::reset_psymtabs): New method.
9548
9549 2019-01-10  Tom Tromey  <tom@tromey.com>
9550
9551         * symmisc.c (print_symbol_bcache_statistics): Update.
9552         (print_objfile_statistics): Update.
9553         * symfile.c (reread_symbols): Update.
9554         * psymtab.h (class psymtab_storage): New.
9555         * psymtab.c (psymtab_storage): New constructor.
9556         (~psymtab_storage): New destructor.
9557         (require_partial_symbols): Update.
9558         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9559         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9560         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9561         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9562         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9563         (start_psymtab_common, end_psymtab_common)
9564         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9565         (allocate_psymtab): Update.
9566         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9567         Update.
9568         (dump_psymtab_addrmap, maintenance_print_psymbols)
9569         (maintenance_check_psymtabs): Update.
9570         (class objfile_psymtabs): Move to objfiles.h.
9571         * psympriv.h (discard_psymtab): Now inline.
9572         (psymtab_discarder::psymtab_discarder): Update.
9573         (psymtab_discarder::~psymtab_discarder): Update.
9574         (ALL_OBJFILE_PSYMTABS): Rewrite.
9575         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9576         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9577         Remove fields.
9578         <partial_symtabs>: New field.
9579         (class objfile_psymtabs): Move from psymtab.h.  Update.
9580         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9581         psymbol_cache.
9582         (objfile::~objfile): Don't destroy psymbol_cache.
9583         * mdebugread.c (parse_partial_symbols): Update.
9584         * dwarf2read.c (create_addrmap_from_index)
9585         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9586         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9587         (add_partial_subprogram, dwarf2_ranges_read): Update.
9588         * dwarf-index-write.c (write_address_map)
9589         (write_one_signatured_type, recursively_write_psymbols)
9590         (class debug_names, class debug_names, write_psymtabs_to_index):
9591         Update.
9592
9593 2019-01-10  Tom Tromey  <tom@tromey.com>
9594
9595         * symtab.h (SYMBOL_SET_NAMES): Update.
9596         (symbol_set_names): Update.
9597         (MSYMBOL_SET_NAMES): Update.
9598         * symtab.c (symbol_set_names): Change argument to be an
9599         objfile_per_bfd_storage.
9600         * psymtab.c (add_psymbol_to_bcache): Update.
9601         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9602
9603 2019-01-10  Tom Tromey  <tom@tromey.com>
9604
9605         * symtab.c (create_demangled_names_hash): Change argument to be an
9606         objfile_per_bfd_storage.
9607         (symbol_set_names): Update.
9608
9609 2019-01-10  Tom Tromey  <tom@tromey.com>
9610
9611         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9612         init_psymbol_list.
9613         * psymtab.c (init_psymbol_list): Do nothing if already called.
9614         * psympriv.h (init_psymbol_list): Add comment.
9615         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9616         init_psymbol_list.
9617         * dbxread.c (dbx_symfile_read): Unconditionally call
9618         init_psymbol_list.
9619
9620 2019-01-10  Tom Tromey  <tom@tromey.com>
9621
9622         * xcoffread.c (scan_xcoff_symtab): Update.
9623         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9624         "where".
9625         * mdebugread.c (parse_partial_symbols)
9626         (handle_psymbol_enumerators): Update.
9627         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9628         * dbxread.c (read_dbx_symtab): Update.
9629         * psympriv.h (psymbol_placement): New enum.
9630         (add_psymbol_to_list): Update.
9631
9632 2019-01-10  Tom Tromey  <tom@tromey.com>
9633
9634         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9635         static_psymbols parameters.
9636         (scan_xcoff_symtab): Update.
9637         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9638         static_psymbols parameters.
9639         * psympriv.h (start_psymtab_common): Update.
9640         * mdebugread.c (parse_partial_symbols): Update.
9641         * dwarf2read.c (create_partial_symtab): Update.
9642         * dbxread.c (read_dbx_symtab): Update.
9643         (start_psymtab): Remove global_psymbols and static_psymbols
9644         parameters.
9645
9646 2019-01-10  Tom Tromey  <tom@tromey.com>
9647
9648         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9649         * psymtab.c (allocate_psymtab): Add comment.
9650         * psympriv.h (allocate_psymtab): Add comment.
9651         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9652         initializations.
9653         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9654
9655 2019-01-10  Tom Tromey  <tom@tromey.com>
9656
9657         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9658         Don't declare.
9659         * mipsread.c: Include mdebugread.h.
9660         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9661         Declare.
9662         * elfread.c: Include mdebugread.h.
9663
9664 2019-01-09  Tom Tromey  <tom@tromey.com>
9665
9666         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9667         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9668         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9669         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9670         (psym_lookup_symbol, psym_find_last_source_symtab)
9671         (psym_forget_cached_source_info, psym_print_stats)
9672         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9673         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9674         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9675         (psym_find_compunit_symtab_by_address)
9676         (maintenance_print_psymbols, maintenance_info_psymtabs)
9677         (maintenance_check_psymtabs): Use ranged for.
9678         * psymtab.h (class objfile_psymtabs): New.
9679         (require_partial_symbols): Return objfile_psymtabs.
9680         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9681
9682 2019-01-09  Tom Tromey  <tom@tromey.com>
9683
9684         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9685         (find_pc_mapped_section, list_overlays_command)
9686         (map_overlay_command, unmap_overlay_command)
9687         (simple_overlay_update): Use all_objfiles.
9688         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9689         * printcmd.c (info_symbol_command): Use all_objfiles.
9690         * objfiles.h (ALL_OBJSECTIONS): Remove.
9691         * maint.c (maintenance_translate_address): Use all_objfiles.
9692         * gcore.c (gcore_create_callback): Use all_objfiles.
9693         (objfile_find_memory_regions): Likewise.
9694
9695 2019-01-09  Tom Tromey  <tom@tromey.com>
9696
9697         * symtab.c (find_line_symtab, info_sources_command)
9698         (make_source_files_completion_list): Use objfile_compunits.
9699         * source.c (select_source_symtab): Use objfile_compunits.
9700         * objfiles.h (struct objfile): Update comment.
9701         (ALL_OBJFILES): Remove.
9702         (ALL_FILETABS): Remove.
9703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9704         objfile_compunits.
9705
9706 2019-01-09  Tom Tromey  <tom@tromey.com>
9707
9708         * symmisc.c (print_objfile_statistics, dump_objfile)
9709         (maintenance_print_symbols): Use compunit_filetabs.
9710         * source.c (forget_cached_source_info_for_objfile): Use
9711         compunit_filetabs.
9712         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9713         (ALL_FILETABS): Use compunit_filetabs.
9714         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9715         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9716
9717 2019-01-09  Tom Tromey  <tom@tromey.com>
9718
9719         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9720         (compunit_filetabs): New.
9721         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9722         compunit_filetabs.
9723         (info_sources_command, make_source_files_completion_list): Remove
9724         declaration.
9725         * symmisc.c (print_objfile_statistics, dump_objfile)
9726         (maintenance_print_symbols): Remove declaration.
9727         (maintenance_info_symtabs): Use compunit_filetabs.
9728         (maintenance_info_line_tables): Likewise.
9729         * source.c (select_source_symtab): Change local variable name.
9730         (forget_cached_source_info_for_objfile): Remove declaration.
9731         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9732         * objfiles.c (objfile_relocate1): Remove declaration.
9733         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9734         declaration.
9735         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9736         * coffread.c (coff_symtab_read): Remove declaration.
9737         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9738         compunit_filetabs.
9739
9740 2019-01-09  Tom Tromey  <tom@tromey.com>
9741
9742         * symtab.c (lookup_objfile_from_block)
9743         (find_pc_sect_compunit_symtab, search_symbols)
9744         (default_collect_symbol_completion_matches_break_on): Use
9745         objfile_compunits.
9746         * objfiles.h (ALL_COMPUNITS): Remove.
9747         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9748         * cp-support.c (add_symbol_overload_list_qualified): Use
9749         objfile_compunits.
9750         * ada-lang.c (ada_collect_symbol_completion_matches)
9751         (ada_add_global_exceptions): Use objfile_compunits.
9752
9753 2019-01-09  Tom Tromey  <tom@tromey.com>
9754
9755         * source.c (select_source_symtab)
9756         (forget_cached_source_info_for_objfile): Remove declaration.
9757         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9758         declaration.
9759         * maint.c (count_symtabs_and_blocks): Remove declaration.
9760         * cp-support.c (add_symbol_overload_list_qualified): Remove
9761         declaration.
9762         * coffread.c (coff_symtab_read): Remove declaration.
9763         * symtab.c (lookup_symbol_in_objfile_symtabs)
9764         (basic_lookup_transparent_type_1): Use objfile_compunits.
9765         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9766         (info_sources_command, search_symbols)
9767         (default_collect_symbol_completion_matches_break_on)
9768         (make_source_files_completion_list): Remove declaration.
9769         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9770         (ada_collect_symbol_completion_matches)
9771         (ada_add_global_exceptions): Remove declaration.
9772         * linespec.c (iterate_over_all_matching_symtabs): Use
9773         objfile_compunits.
9774         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9775         (class objfile_compunits): New.
9776         (ALL_COMPUNITS): Use objfile_compunits.
9777         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9778         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9779         objfile_compunits.
9780         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9781
9782 2019-01-09  Tom Tromey  <tom@tromey.com>
9783
9784         * symtab.c (search_symbols)
9785         (default_collect_symbol_completion_matches_break_on): Use
9786         objfile_msymbols.
9787         * ada-lang.c (ada_lookup_simple_minsym)
9788         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9789         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9790         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9791         objfile_msymbols.
9792         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9793         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9794         * objc-lang.c (find_methods): Use objfile_msymbols.
9795         (info_selectors_command, info_classes_command): Likewise.
9796         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9797         * objfiles.h (class objfile_msymbols): New.
9798         (ALL_OBJFILE_MSYMBOLS): Remove.
9799         (ALL_MSYMBOLS): Remove.
9800
9801 2019-01-09  Tom Tromey  <tom@tromey.com>
9802
9803         * common/next-iterator.h (next_adapter): Add Iterator template
9804         parameter.
9805         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9806         (class all_objfiles_safe): New.
9807         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9808         * objfiles.c (put_objfile_before): Update comment.
9809         (add_separate_debug_objfile): Likewise.
9810         (free_all_objfiles): Use all_objfiles_safe.
9811         (objfile_purge_solibs): Likewise.
9812
9813 2019-01-09  Tom Tromey  <tom@tromey.com>
9814
9815         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9816         (expand_symtab_containing_pc, lookup_static_symbol)
9817         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9818         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9819         all_objfiles.
9820         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9821         * breakpoint.c (create_overlay_event_breakpoint)
9822         (create_longjmp_master_breakpoint)
9823         (create_std_terminate_master_breakpoint)
9824         (create_exception_master_breakpoint): Use all_objfiles.
9825         * linux-thread-db.c (try_thread_db_load_from_pdir)
9826         (has_libpthread): Use all_objfiles.
9827         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9828         * linespec.c (iterate_over_all_matching_symtabs)
9829         (search_minsyms_for_name): Use all_objfiles.
9830         * maint.c (maintenance_info_sections): Use all_objfiles.
9831         * main.c (captured_main_1): Use all_objfiles.
9832         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9833         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9834         * guile/scm-pretty-print.c
9835         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9836         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9837         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9838         (maintenance_print_msymbols): Use all_objfiles.
9839         * source.c (select_source_symtab): Use all_objfiles.
9840         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9841         * symfile.c (remove_symbol_file_command)
9842         (expand_symtabs_matching, map_symbol_filenames): Use
9843         all_objfiles.
9844         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9845         all_objfiles.
9846         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9847         * objc-lang.c (find_methods): Use all_objfiles.
9848         * objfiles.c (have_partial_symbols, have_full_symbols)
9849         (have_minimal_symbols, qsort_cmp)
9850         (default_iterate_over_objfiles_in_search_order): Use
9851         all_objfiles.
9852         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9853         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9854         (maintenance_check_psymtabs): Use all_objfiles.
9855         (ALL_PSYMTABS): Remove.
9856         * compile/compile-object-run.c (do_module_cleanup): Use
9857         all_objfiles.
9858         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9859         * cp-support.c (add_symbol_overload_list_qualified): Use
9860         all_objfiles.
9861         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9862         Use all_objfiles.
9863         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9864         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9865         all_objfiles.
9866         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9867         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9868         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9869         Uses all_objfiles.
9870         * solib.c (solib_read_symbols): Use all_objfiles
9871
9872 2019-01-09  Tom Tromey  <tom@tromey.com>
9873
9874         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9875         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9876         all_objfiles.
9877         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9878         * symmisc.c (print_symbol_bcache_statistics)
9879         (print_objfile_statistics, maintenance_print_objfiles)
9880         (maintenance_info_symtabs, maintenance_check_symtabs)
9881         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9882         all_objfiles.
9883         * source.c (forget_cached_source_info): Use all_objfiles.
9884         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9885         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9886         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9887         * objfiles.c (update_section_map): Use all_objfiles.
9888         (shared_objfile_contains_address_p): Likewise.
9889         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9890         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9891
9892 2019-01-09  Tom Tromey  <tom@tromey.com>
9893
9894         * common/next-iterator.h: New file.
9895         * objfiles.h (class all_objfiles): New.
9896         (struct objfile_iterator): New.
9897
9898 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9899
9900         * NEWS: Move the description of the changed "frame", "select-frame",
9901          and "info frame" commands to the Changed commands section.
9902
9903 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9904
9905         * gdbtypes.c (check_stub_method_group): Remove handling of old
9906         mangling schemes.
9907         * linespec.c (find_methods): Likewise.
9908         * stabsread.c (read_member_functions): Likewise.
9909         * valops.c (search_struct_method): Likewise.
9910         (value_struct_elt_for_reference): Likewise.
9911         * NEWS: Mention this change.
9912
9913 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9914
9915         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9916         print_source_lines.
9917         * source.c (print_source_lines_base): Update line number check.
9918         (print_source_lines): New function.
9919         (source_lines_range::source_lines_range): New function.
9920         * source.h (class source_lines_range): New class.
9921         (print_source_lines): New declaration.
9922
9923 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9924
9925         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9926
9927 2019-01-08  Tom Tromey  <tom@tromey.com>
9928             Simon Marchi  <simon.marchi@ericsson.com>
9929
9930         PR gdb/24060
9931         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9932         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9933         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9934         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9935         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9936         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9937
9938 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9939
9940         * source.c (select_source_symtab): Move header comment to
9941         declaration in source.h.
9942         (forget_cached_source_info_for_objfile): Likewise.
9943         (forget_cached_source_info): Likewise.
9944         (identify_source_line): Likewise.
9945         * source.h (identify_source_line): Move declaration from symtab.h
9946         and add comment from source.c
9947         (print_source_lines): Likewise.
9948         (forget_cached_source_info_for_objfile): Likewise.
9949         (forget_cached_source_info): Likewise.
9950         (select_source_symtab): Likewise.
9951         (enum print_source_lines_flag): Move definition from symtab.h.
9952         * symtab.h (identify_source_line): Move declaration to source.h.
9953         (print_source_lines): Likewise.
9954         (forget_cached_source_info_for_objfile): Likewise.
9955         (forget_cached_source_info): Likewise.
9956         (select_source_symtab): Likewise.
9957         (enum print_source_lines_flag): Move definition to source.h.
9958         * tui/tui-hooks.c: Add 'source.h' include.
9959
9960 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9961
9962         * source.c (print_source_lines_base): Handle requests to print
9963         reverse line number sequences, and guard against empty lines
9964         string.
9965
9966 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9967
9968         * source.c (print_source_lines_base): Fix skip of '\r' if next
9969         character is '\n'.
9970
9971 2019-01-06  Tom Tromey  <tom@tromey.com>
9972
9973         * c-exp.y (struct c_parse_state) <macro_original_text,
9974         expansion_obstack>: New member.
9975         (macro_original_text, expansion_obstack): Remove globals.
9976         (scan_macro_expansion, scanning_macro_expansion)
9977         (finished_macro_expansion): Update.
9978         (scan_macro_cleanup): Remove.
9979         (yylex, c_parse): Update.
9980
9981 2019-01-06  Tom Tromey  <tom@tromey.com>
9982
9983         * c-exp.y (struct c_parse_state) <strings>: New member.
9984         (operator_stoken): Update.
9985
9986 2019-01-06  Tom Tromey  <tom@tromey.com>
9987
9988         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9989         (union type_stack_elt) <typelist_val>: Now a pointer to
9990         std::vector.
9991         (type_stack_cleanup): Don't declare.
9992         (push_typelist): Update.
9993         * parse.c (pop_typelist): Return a std::vector.
9994         (push_typelist): Take a std::vector.
9995         (follow_types): Update.  Do not free args.
9996         (type_stack_cleanup): Remove.
9997         * c-exp.y (struct c_parse_state): New.
9998         (cpstate): New global.
9999         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10000         (nonempty_typelist): Update.
10001         (func_mod): Create a new vector.
10002         (c_parse): Create a c_parse_state.
10003         (check_parameter_typelist): Do not delete params.
10004         (function_method): Update.  Do not delete type_list.
10005
10006 2019-01-06  Tom Tromey  <tom@tromey.com>
10007
10008         PR gdb/28155:
10009         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10010         check_typedef.
10011         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10012         (print_return_value): Likewise.
10013
10014 2019-01-05  Tom Tromey  <tom@tromey.com>
10015
10016         * contrib/cleanup_check.py: Remove.
10017         * contrib/gcc-with-excheck: Remove.
10018         * contrib/exsummary.py: Remove.
10019         * contrib/excheck.py: Remove.
10020
10021 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10022
10023         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10024         NULL. Initialize tpprev to NULL instead of assigning it
10025         to NULL on the next statement.
10026         * windows-nat.c (windows_delete_thread): Remove check for
10027         main_thread_id before printing thread exit notifications.
10028         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10029         Remove thread ID check against main_thread_id.
10030         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10031         windows_delete_thread.
10032         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10033
10034 2019-01-04  Tom Tromey  <tom@tromey.com>
10035
10036         * compile/compile.c (_initialize_compile): Use upper case for
10037         metasyntactic variables.
10038         * symmisc.c (_initialize_symmisc): Use upper case for
10039         metasyntactic variables.
10040         * psymtab.c (_initialize_psymtab): Use upper case for
10041         metasyntactic variables.
10042         * demangle.c (demangle_command): Use upper case for metasyntactic
10043         variables.
10044         (_initialize_demangler): Likewise.
10045         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10046         variables.
10047
10048 2019-01-03  Tom Tromey  <tom@tromey.com>
10049
10050         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10051
10052 2019-01-03  Tom Tromey  <tom@tromey.com>
10053
10054         * python/py-symtab.c (salpy_str): Update.
10055         (struct salpy_sal_object) <symtab>: Now a PyObject.
10056         (salpy_dealloc): Update.
10057         (del_objfile_sal): Use gdbpy_ref.
10058
10059 2019-01-03  Tom Tromey  <tom@tromey.com>
10060
10061         * python/py-type.c (convert_field): Use new_reference.  Return
10062         gdbpy_ref.
10063         (make_fielditem): Return gdbpy_ref.
10064         (typy_fields): Update.
10065         (typy_getitem): Update.
10066         (field_name): Return gdbpy_ref.  Use new_reference.
10067         (typy_iterator_iternext): Update.
10068
10069 2019-01-03  Tom Tromey  <tom@tromey.com>
10070
10071         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10072
10073 2019-01-03  Tom Tromey  <tom@tromey.com>
10074
10075         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10076         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10077         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10078         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10079         (pspy_set_type_printers): Likewise.
10080         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10081         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10082         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10083         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10084         (objfpy_set_type_printers): Likewise.
10085
10086 2019-01-03  Tom Tromey  <tom@tromey.com>
10087
10088         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10089         (gdbpy_print_stack): Use gdbpy_err_fetch.
10090         * python/python-internal.h (class gdbpy_err_fetch): New class.
10091         (class gdbpy_enter) <m_error_type, m_error_value,
10092         m_error_traceback>: Remove.
10093         <m_error>: New member.
10094         (gdbpy_exception_to_string): Don't declare.
10095         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10096         * python/py-value.c (convert_value_from_python): Use
10097         gdbpy_err_fetch.
10098         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10099         gdbpy_exception_to_string.
10100         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10101         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10102         gdbpy_err_fetch.
10103
10104 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10105
10106         * linux-nat.c (delete_lwp_cleanup): Delete.
10107         (struct lwp_deleter): New struct.
10108         (lwp_info_up): New typedef.
10109         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10110         lwp_info_up.
10111
10112 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10113
10114         * linux-fork.c (class scoped_switch_fork_info): New class.
10115         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10116
10117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10118
10119         * valops.c (find_overload_match): Remove use of null_cleanup, and
10120         calls to do_cleanups.
10121
10122 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10123
10124         * compile/compile-cplus-types.c
10125         (compile_cplus_instance::decl_name): Handle changes to
10126         cp_func_name.
10127         * cp-support.c (cp_func_name): Update header comment, update
10128         return type.
10129         * cp-support.h (cp_func_name): Update return type in declaration.
10130         * valops.c (find_overload_match): Move temp_func local to top
10131         level of function and change its type.  Use temp_func to hold and
10132         delete temporary string obtained from cp_func_name.
10133
10134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10135
10136         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10137         gdb::char_vector, remove cleanup, and update uses of `msg`.
10138
10139 2019-01-03  Jim Wilson  <jimw@sifive.com>
10140
10141         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10142
10143 2019-01-02  Tom Tromey  <tom@tromey.com>
10144
10145         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10146         (tdesc_parse_xml): Remove cleanups.
10147         * target-descriptions.h (make_cleanup_free_target_description):
10148         Don't declare.
10149         (target_desc_deleter): New struct.
10150         (target_desc_up): New typedef.
10151         * target-descriptions.c (target_desc_deleter::operator()): Rename
10152         from free_target_description.
10153         (make_cleanup_free_target_description): Remove.
10154
10155 2019-01-02  Tom Tromey  <tom@tromey.com>
10156
10157         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10158         constructor, destructor.
10159         (linespec_parser): Remove typedef.
10160         (~linespec_parser): Rename from linespec_parser_delete.
10161         (linespec_lex_to_end, linespec_complete_label)
10162         (linespec_complete): Update.
10163         (decode_line_full): Remove cleanups.
10164         (decode_line_1): Update.
10165
10166 2019-01-02  Tom Tromey  <tom@tromey.com>
10167
10168         * python/python-internal.h (inferior_to_inferior_object): Change
10169         return type.
10170         * python/py-exitedevent.c (create_exited_event_object): Update.
10171         * python/py-inferior.c (inferior_to_inferior_object): Return
10172         gdbpy_ref.
10173         (python_new_inferior, python_inferior_deleted)
10174         (thread_to_thread_object, delete_thread_object)
10175         (build_inferior_list, gdbpy_selected_inferior): Update.
10176         * python/py-infthread.c (create_thread_object): Update.  Also fail
10177         if inferior_to_inferior_object fails.
10178
10179 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10180
10181         * inferior.h (class inferior) <displaced_step_state>: New field.
10182         * infrun.h (struct displaced_step_state): Move here from
10183         infrun.c.  Initialize fields, add constructor.
10184         <inf>: Remove field.
10185         <reset>: New method.
10186         * infrun.c (struct displaced_step_inferior_state): Move to
10187         infrun.h.
10188         (displaced_step_inferior_states): Remove.
10189         (get_displaced_stepping_state): Adust.
10190         (displaced_step_in_progress_any_inferior): Adjust.
10191         (displaced_step_in_progress_thread): Adjust.
10192         (displaced_step_in_progress): Adjust.
10193         (add_displaced_stepping_state): Remove.
10194         (get_displaced_step_closure_by_addr): Adjust.
10195         (remove_displaced_stepping_state): Remove.
10196         (infrun_inferior_exit): Call displaced_step_state.reset.
10197         (use_displaced_stepping): Don't check for NULL.
10198         (displaced_step_prepare_throw): Call
10199         get_displaced_stepping_state.
10200         (displaced_step_fixup): Don't check for NULL.
10201         (prepare_for_detach): Don't check for NULL.
10202
10203 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10204
10205         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10206          in case of call that did not complete.
10207
10208 2019-01-02  Andrey Utkin  <autkin@undo.io>
10209
10210         * symfile.c (find_separate_debug_file): Fix search of debug files for
10211         remote debuggee.
10212
10213 2019-01-02  Tom Tromey  <tom@tromey.com>
10214
10215         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10216         indentation.
10217         * python/py-frame.c (frapy_older): Remove cast.
10218         (frapy_newer): Likewise.
10219         * python/py-breakpoint.c (local_setattro): Remove cast.
10220         * python/py-arch.c (archpy_name): Remove local variable.
10221         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10222
10223 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10224
10225         * unittests/basic_string_view/element_access/char/empty.cc:
10226         Fix year range in copyright header.
10227
10228 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10229
10230         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10231         Delete.
10232         <operator==>: Update with for removed field.
10233         <hash>: Likewise.
10234         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10235         <isa_features>: ...this.
10236         <abi_features>: New field.
10237         (riscv_isa_flen): Update comment.
10238         (riscv_abi_xlen): New declaration.
10239         (riscv_abi_flen): New declaration.
10240         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10241         isa_features.
10242         (riscv_abi_xlen): New function.
10243         (riscv_isa_flen): Update to get answer from isa_features.
10244         (riscv_abi_flen): New function.
10245         (riscv_has_fp_abi): Update to get answer from abi_features.
10246         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10247         xlen and flen.
10248         (riscv_call_info) <xlen, flen>: Update comment.
10249         (riscv_call_arg_struct): Remove invalid assertions
10250         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10251         is removed.
10252         (riscv_gdbarch_init): Gather isa features and abi features
10253         separately, ensure both match on the gdbarch when reusing an old
10254         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10255         a target with 64-bit float hardware.
10256
10257 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10258
10259         * source.c (search_command_helper): Stop reverse search
10260         when line 1 has been searched.
10261
10262 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10263
10264         * record-full.c (record_full_base_target::close): Rewrite
10265         record_full_core_buf_list free logic.
10266
10267 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10268
10269         * break-catch-syscall.c (print_one_catch_syscall): xfree
10270         the last text.
10271
10272 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10273
10274         * top.c (print_gdb_version): Update Copyright year in version
10275         message.
10276
10277 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10278
10279         Update copyright year range in all GDB files.
10280
10281 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10282
10283         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10284
10285 For older changes see ChangeLog-2018.
10286 \f
10287 Local Variables:
10288 mode: change-log
10289 left-margin: 8
10290 fill-column: 74
10291 version-control: never
10292 coding: utf-8
10293 End:
10294