Make "msg" const in internal_vproblem
[external/binutils.git] / gdb / ChangeLog
1 2019-04-11  Tom Tromey  <tromey@adacore.com>
2
3         * utils.c (internal_vproblem): Make "msg" const.
4
5 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6
7         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11
12 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
13
14         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
15         function.
16         (fill_gregset): Call amd64_linux_collect_native_gregset instead
17         of amd64_collect_native_gregset.
18         (amd64_linux_nat_target::store_registers): Likewise.
19
20 2019-04-10  Tom Tromey  <tom@tromey.com>
21
22         * symtab.c (lookup_global_symbol_from_objfile)
23         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
24         * objfiles.h (class separate_debug_iterator): New.
25         (class separate_debug_range): New.
26         (struct objfile) <separate_debug_objfiles>: New method.
27         (objfile_separate_debug_iterate): Don't declare.
28         * objfiles.c (separate_debug_iterator::operator++): Rename from
29         objfile_separate_debug_iterate.
30         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
31         iterator.
32         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
33         iterator.
34
35 2019-04-10  Tom Tromey  <tom@tromey.com>
36
37         * symfile.c (reread_symbols): Remove old comment.
38         * objfiles.c (free_all_objfiles): Fix a typo.
39
40 2019-04-10  Tom Tromey  <tom@tromey.com>
41
42         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
43         * minsyms.c (lookup_minimal_symbol): Use foreach.
44         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
45         (lookup_minimal_symbol_solib_trampoline): Likewise.
46         * symfile.c (reread_symbols): Use foreach.
47
48 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
49             Tom Tromey  <tromey@adacore.com>
50
51         PR rust/24414:
52         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
53         (rust_lex_int_test): Change "value" to be LONGEST.
54         (rust_lex_tests): Add test for long integer literal.
55
56 2019-04-09  Tom Tromey  <tromey@adacore.com>
57
58         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
59         to bool.
60         (extended_remote_target::attach): Update.
61         (remote_target::remote_notice_new_inferior): Update.
62         (remote_target::add_current_inferior_and_thread): Update.
63         * inferior.c (exit_inferior_1): Use "false".
64         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
65
66 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
67
68         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
69         the "start" command.
70
71 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
72
73         * python/py-inferior.c (infpy_thread_from_thread_handle):
74         Adjust comments to reflect renaming of thread_from_thread_handle
75         to thread_from_handle.  Adjust keywords.  Fix type error message.
76         (inferior_object_methods): Add thread_from_handle.  Retain
77         thread_from_thread_handle, but mark it as deprecated.
78
79 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
80
81         * gdbthread.h (find_thread_by_handle): Revise declaration.
82         * thread.c (find_thread_by_handle): Likewise.  Adjust
83         implementation too.
84         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
85         support for buffer objects as handles.
86
87 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
88
89         * python/py-infthread.c (thpy_thread_handle): New function.
90         (thread_object_methods): Register thpy_thread_handle.
91
92 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
93
94         * gdbthread.h (thread_to_thread_handle): Declare.
95         * thread.c (gdbtypes.h): Include.
96         (thread_to_thread_handle): New function.
97
98         * target.h (struct target_ops): Add thread_info_to_thread_handle.
99         (target_thread_info_to_thread_handle): Declare.
100         * target.c (target_thread_info_to_thread_handle): New function.
101         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
102         * target-delegates.c: Regenerate.
103
104         * linux-thread-db.c (class thread_db_target): Add method
105         thread_info_to_thread_handle.
106         (thread_db_target::thread_info_to_thread_handle): Define.
107         * remote.c (class remote_target): Add new method
108         thread_info_to_thread_handle.
109         (remote_target::thread_info_to_thread_handle): Define.
110
111 2019-04-08  Pedro Alves  <palves@redhat.com>
112
113         * common/common-exceptions.c (throw_exception): Don't create
114         named object to throw; throw directly.
115         (throw_it): Likewise.  Don't initialize gdb_exception::message
116         here, with new; pass FMT and AP to the ctor instead.
117         * common/common-exceptions.h: Include <string>.
118         (gdb_exception::gdb_exception(enum return_reason, enum errors,
119         const char *, va_list)): New ctor.  Use std::make_shared.
120         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
121         errors)): Delete.
122         (gdb_exception_error::gdb_exception_error(enum errors, const char
123         *, va_list)): New.
124         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
125         Add assertion.
126         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
127         errors)): Delete.
128         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
129         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
130         Add assertion.
131
132 2019-04-08  Tom Tromey  <tom@tromey.com>
133
134         * valops.c (value_rtti_indirect_type): Replace throw_exception
135         with throw.
136         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
137         with throw.
138         * thread.c (thr_try_catch_cmd): Replace throw_exception with
139         throw.
140         * target.c (target_translate_tls_address): Replace throw_exception
141         with throw.
142         * stack.c (frame_apply_command_count): Replace throw_exception
143         with throw.
144         * solib-spu.c (append_ocl_sos): Replace throw_exception with
145         throw.
146         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
147         with throw.
148         * rs6000-tdep.c (rs6000_frame_cache)
149         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
150         * remote.c: Replace throw_exception with throw.
151         * record-full.c (record_full_message, record_full_wait_1)
152         (record_full_restore): Replace throw_exception with throw.
153         * record-btrace.c:
154         (get_thread_current_frame_id, record_btrace_start_replaying)
155         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
156         (cmd_record_btrace_start): Replace throw_exception with throw.
157         * parse.c (parse_exp_in_context_1): Replace throw_exception with
158         throw.
159         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
160         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
161         * linespec.c:
162         (find_linespec_symbols): Replace throw_exception with throw.
163         * infrun.c (displaced_step_prepare, resume): Replace
164         throw_exception with throw.
165         * infcmd.c (post_create_inferior): Replace throw_exception with
166         throw.
167         * inf-loop.c (inferior_event_handler): Replace throw_exception
168         with throw.
169         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
170         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
171         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
172         (get_prev_frame_always, get_frame_pc_if_available)
173         (get_frame_address_in_block_if_available, get_frame_language):
174         Replace throw_exception with throw.
175         * frame-unwind.c (frame_unwind_try_unwinder): Replace
176         throw_exception with throw.
177         * eval.c (fetch_subexp_value, evaluate_var_value)
178         (evaluate_funcall, evaluate_subexp_standard): Replace
179         throw_exception with throw.
180         * dwarf2loc.c (call_site_find_chain)
181         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
182         Replace throw_exception with throw.
183         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
184         with throw.
185         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
186         throw.
187         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
188         * completer.c (complete_line_internal): Replace throw_exception
189         with throw.
190         * compile/compile-object-run.c (compile_object_run): Replace
191         throw_exception with throw.
192         * cli/cli-script.c (process_next_line): Replace throw_exception
193         with throw.
194         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
195         (btrace_enable, btrace_maint_update_pt_packets): Replace
196         throw_exception with throw.
197         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
198         throw_exception with throw.
199         * break-catch-throw.c (re_set_exception_catchpoint): Replace
200         throw_exception with throw.
201         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
202         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
203         * aarch64-tdep.c (aarch64_make_prologue_cache)
204         (aarch64_make_stub_cache): Replace throw_exception with throw.
205
206 2019-04-08  Tom Tromey  <tom@tromey.com>
207
208         * common/common-exceptions.c (throw_exception): Rename from
209         throw_exception_cxx.  Remove old copy.  Make argument const.
210         (throw_it): Create and throw exception objects directly.
211         * common/common-exceptions.h (throw_exception): Make argument
212         const.
213         (struct gdb_exception_error): Add constructor.
214         (struct gdb_exception_quit): Add constructor.
215
216 2019-04-08  Tom Tromey  <tom@tromey.com>
217
218         * common/common-exceptions.h (exception_rethrow): Don't declare.
219         (TRY_SJLJ): Update comment.
220         (TRY, CATCH, END_CATCH): Remove.
221         * common/common-exceptions.c (exception_rethrow): Remove.
222
223 2019-04-08  Tom Tromey  <tom@tromey.com>
224
225         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
226         Remove.
227         (gdb_exception_error): Rename from
228         gdb_exception_RETURN_MASK_ERROR.
229         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
230         (gdb_quit_bad_alloc): Update.
231         * aarch64-tdep.c: Update.
232         * ada-lang.c: Update.
233         * ada-typeprint.c: Update.
234         * ada-valprint.c: Update.
235         * amd64-tdep.c: Update.
236         * arch-utils.c: Update.
237         * break-catch-throw.c: Update.
238         * breakpoint.c: Update.
239         * btrace.c: Update.
240         * c-varobj.c: Update.
241         * cli/cli-cmds.c: Update.
242         * cli/cli-interp.c: Update.
243         * cli/cli-script.c: Update.
244         * common/common-exceptions.c: Update.
245         * common/new-op.c: Update.
246         * common/selftest.c: Update.
247         * compile/compile-c-symbols.c: Update.
248         * compile/compile-cplus-symbols.c: Update.
249         * compile/compile-object-load.c: Update.
250         * compile/compile-object-run.c: Update.
251         * completer.c: Update.
252         * corelow.c: Update.
253         * cp-abi.c: Update.
254         * cp-support.c: Update.
255         * cp-valprint.c: Update.
256         * darwin-nat.c: Update.
257         * disasm-selftests.c: Update.
258         * dtrace-probe.c: Update.
259         * dwarf-index-cache.c: Update.
260         * dwarf-index-write.c: Update.
261         * dwarf2-frame-tailcall.c: Update.
262         * dwarf2-frame.c: Update.
263         * dwarf2loc.c: Update.
264         * dwarf2read.c: Update.
265         * eval.c: Update.
266         * event-loop.c: Update.
267         * event-top.c: Update.
268         * exec.c: Update.
269         * f-valprint.c: Update.
270         * fbsd-tdep.c: Update.
271         * frame-unwind.c: Update.
272         * frame.c: Update.
273         * gdbtypes.c: Update.
274         * gnu-v3-abi.c: Update.
275         * guile/guile-internal.h: Update.
276         * guile/scm-block.c: Update.
277         * guile/scm-breakpoint.c: Update.
278         * guile/scm-cmd.c: Update.
279         * guile/scm-disasm.c: Update.
280         * guile/scm-frame.c: Update.
281         * guile/scm-lazy-string.c: Update.
282         * guile/scm-math.c: Update.
283         * guile/scm-param.c: Update.
284         * guile/scm-ports.c: Update.
285         * guile/scm-pretty-print.c: Update.
286         * guile/scm-symbol.c: Update.
287         * guile/scm-symtab.c: Update.
288         * guile/scm-type.c: Update.
289         * guile/scm-value.c: Update.
290         * i386-linux-tdep.c: Update.
291         * i386-tdep.c: Update.
292         * inf-loop.c: Update.
293         * infcall.c: Update.
294         * infcmd.c: Update.
295         * infrun.c: Update.
296         * jit.c: Update.
297         * language.c: Update.
298         * linespec.c: Update.
299         * linux-fork.c: Update.
300         * linux-nat.c: Update.
301         * linux-tdep.c: Update.
302         * linux-thread-db.c: Update.
303         * main.c: Update.
304         * mi/mi-cmd-break.c: Update.
305         * mi/mi-cmd-stack.c: Update.
306         * mi/mi-interp.c: Update.
307         * mi/mi-main.c: Update.
308         * objc-lang.c: Update.
309         * p-valprint.c: Update.
310         * parse.c: Update.
311         * ppc-linux-tdep.c: Update.
312         * printcmd.c: Update.
313         * python/py-arch.c: Update.
314         * python/py-breakpoint.c: Update.
315         * python/py-cmd.c: Update.
316         * python/py-finishbreakpoint.c: Update.
317         * python/py-frame.c: Update.
318         * python/py-framefilter.c: Update.
319         * python/py-gdb-readline.c: Update.
320         * python/py-inferior.c: Update.
321         * python/py-infthread.c: Update.
322         * python/py-lazy-string.c: Update.
323         * python/py-linetable.c: Update.
324         * python/py-objfile.c: Update.
325         * python/py-param.c: Update.
326         * python/py-prettyprint.c: Update.
327         * python/py-progspace.c: Update.
328         * python/py-record-btrace.c: Update.
329         * python/py-record.c: Update.
330         * python/py-symbol.c: Update.
331         * python/py-type.c: Update.
332         * python/py-unwind.c: Update.
333         * python/py-utils.c: Update.
334         * python/py-value.c: Update.
335         * python/python.c: Update.
336         * record-btrace.c: Update.
337         * record-full.c: Update.
338         * remote-fileio.c: Update.
339         * remote.c: Update.
340         * riscv-tdep.c: Update.
341         * rs6000-aix-tdep.c: Update.
342         * rs6000-tdep.c: Update.
343         * rust-exp.y: Update.
344         * rust-lang.c: Update.
345         * s390-tdep.c: Update.
346         * selftest-arch.c: Update.
347         * solib-dsbt.c: Update.
348         * solib-frv.c: Update.
349         * solib-spu.c: Update.
350         * solib-svr4.c: Update.
351         * solib.c: Update.
352         * sparc64-linux-tdep.c: Update.
353         * stack.c: Update.
354         * symfile-mem.c: Update.
355         * symmisc.c: Update.
356         * target.c: Update.
357         * thread.c: Update.
358         * top.c: Update.
359         * tracefile-tfile.c: Update.
360         * tui/tui.c: Update.
361         * typeprint.c: Update.
362         * unittests/cli-utils-selftests.c: Update.
363         * unittests/parse-connection-spec-selftests.c: Update.
364         * valops.c: Update.
365         * valprint.c: Update.
366         * value.c: Update.
367         * varobj.c: Update.
368         * windows-nat.c: Update.
369         * x86-linux-nat.c: Update.
370         * xml-support.c: Update.
371
372 2019-04-08  Tom Tromey  <tom@tromey.com>
373
374         * xml-support.c: Use C++ exception handling.
375         * x86-linux-nat.c: Use C++ exception handling.
376         * windows-nat.c: Use C++ exception handling.
377         * varobj.c: Use C++ exception handling.
378         * value.c: Use C++ exception handling.
379         * valprint.c: Use C++ exception handling.
380         * valops.c: Use C++ exception handling.
381         * unittests/parse-connection-spec-selftests.c: Use C++ exception
382         handling.
383         * unittests/cli-utils-selftests.c: Use C++ exception handling.
384         * typeprint.c: Use C++ exception handling.
385         * tui/tui.c: Use C++ exception handling.
386         * tracefile-tfile.c: Use C++ exception handling.
387         * top.c: Use C++ exception handling.
388         * thread.c: Use C++ exception handling.
389         * target.c: Use C++ exception handling.
390         * symmisc.c: Use C++ exception handling.
391         * symfile-mem.c: Use C++ exception handling.
392         * stack.c: Use C++ exception handling.
393         * sparc64-linux-tdep.c: Use C++ exception handling.
394         * solib.c: Use C++ exception handling.
395         * solib-svr4.c: Use C++ exception handling.
396         * solib-spu.c: Use C++ exception handling.
397         * solib-frv.c: Use C++ exception handling.
398         * solib-dsbt.c: Use C++ exception handling.
399         * selftest-arch.c: Use C++ exception handling.
400         * s390-tdep.c: Use C++ exception handling.
401         * rust-lang.c: Use C++ exception handling.
402         * rust-exp.y: Use C++ exception handling.
403         * rs6000-tdep.c: Use C++ exception handling.
404         * rs6000-aix-tdep.c: Use C++ exception handling.
405         * riscv-tdep.c: Use C++ exception handling.
406         * remote.c: Use C++ exception handling.
407         * remote-fileio.c: Use C++ exception handling.
408         * record-full.c: Use C++ exception handling.
409         * record-btrace.c: Use C++ exception handling.
410         * python/python.c: Use C++ exception handling.
411         * python/py-value.c: Use C++ exception handling.
412         * python/py-utils.c: Use C++ exception handling.
413         * python/py-unwind.c: Use C++ exception handling.
414         * python/py-type.c: Use C++ exception handling.
415         * python/py-symbol.c: Use C++ exception handling.
416         * python/py-record.c: Use C++ exception handling.
417         * python/py-record-btrace.c: Use C++ exception handling.
418         * python/py-progspace.c: Use C++ exception handling.
419         * python/py-prettyprint.c: Use C++ exception handling.
420         * python/py-param.c: Use C++ exception handling.
421         * python/py-objfile.c: Use C++ exception handling.
422         * python/py-linetable.c: Use C++ exception handling.
423         * python/py-lazy-string.c: Use C++ exception handling.
424         * python/py-infthread.c: Use C++ exception handling.
425         * python/py-inferior.c: Use C++ exception handling.
426         * python/py-gdb-readline.c: Use C++ exception handling.
427         * python/py-framefilter.c: Use C++ exception handling.
428         * python/py-frame.c: Use C++ exception handling.
429         * python/py-finishbreakpoint.c: Use C++ exception handling.
430         * python/py-cmd.c: Use C++ exception handling.
431         * python/py-breakpoint.c: Use C++ exception handling.
432         * python/py-arch.c: Use C++ exception handling.
433         * printcmd.c: Use C++ exception handling.
434         * ppc-linux-tdep.c: Use C++ exception handling.
435         * parse.c: Use C++ exception handling.
436         * p-valprint.c: Use C++ exception handling.
437         * objc-lang.c: Use C++ exception handling.
438         * mi/mi-main.c: Use C++ exception handling.
439         * mi/mi-interp.c: Use C++ exception handling.
440         * mi/mi-cmd-stack.c: Use C++ exception handling.
441         * mi/mi-cmd-break.c: Use C++ exception handling.
442         * main.c: Use C++ exception handling.
443         * linux-thread-db.c: Use C++ exception handling.
444         * linux-tdep.c: Use C++ exception handling.
445         * linux-nat.c: Use C++ exception handling.
446         * linux-fork.c: Use C++ exception handling.
447         * linespec.c: Use C++ exception handling.
448         * language.c: Use C++ exception handling.
449         * jit.c: Use C++ exception handling.
450         * infrun.c: Use C++ exception handling.
451         * infcmd.c: Use C++ exception handling.
452         * infcall.c: Use C++ exception handling.
453         * inf-loop.c: Use C++ exception handling.
454         * i386-tdep.c: Use C++ exception handling.
455         * i386-linux-tdep.c: Use C++ exception handling.
456         * guile/scm-value.c: Use C++ exception handling.
457         * guile/scm-type.c: Use C++ exception handling.
458         * guile/scm-symtab.c: Use C++ exception handling.
459         * guile/scm-symbol.c: Use C++ exception handling.
460         * guile/scm-pretty-print.c: Use C++ exception handling.
461         * guile/scm-ports.c: Use C++ exception handling.
462         * guile/scm-param.c: Use C++ exception handling.
463         * guile/scm-math.c: Use C++ exception handling.
464         * guile/scm-lazy-string.c: Use C++ exception handling.
465         * guile/scm-frame.c: Use C++ exception handling.
466         * guile/scm-disasm.c: Use C++ exception handling.
467         * guile/scm-cmd.c: Use C++ exception handling.
468         * guile/scm-breakpoint.c: Use C++ exception handling.
469         * guile/scm-block.c: Use C++ exception handling.
470         * guile/guile-internal.h: Use C++ exception handling.
471         * gnu-v3-abi.c: Use C++ exception handling.
472         * gdbtypes.c: Use C++ exception handling.
473         * frame.c: Use C++ exception handling.
474         * frame-unwind.c: Use C++ exception handling.
475         * fbsd-tdep.c: Use C++ exception handling.
476         * f-valprint.c: Use C++ exception handling.
477         * exec.c: Use C++ exception handling.
478         * event-top.c: Use C++ exception handling.
479         * event-loop.c: Use C++ exception handling.
480         * eval.c: Use C++ exception handling.
481         * dwarf2read.c: Use C++ exception handling.
482         * dwarf2loc.c: Use C++ exception handling.
483         * dwarf2-frame.c: Use C++ exception handling.
484         * dwarf2-frame-tailcall.c: Use C++ exception handling.
485         * dwarf-index-write.c: Use C++ exception handling.
486         * dwarf-index-cache.c: Use C++ exception handling.
487         * dtrace-probe.c: Use C++ exception handling.
488         * disasm-selftests.c: Use C++ exception handling.
489         * darwin-nat.c: Use C++ exception handling.
490         * cp-valprint.c: Use C++ exception handling.
491         * cp-support.c: Use C++ exception handling.
492         * cp-abi.c: Use C++ exception handling.
493         * corelow.c: Use C++ exception handling.
494         * completer.c: Use C++ exception handling.
495         * compile/compile-object-run.c: Use C++ exception handling.
496         * compile/compile-object-load.c: Use C++ exception handling.
497         * compile/compile-cplus-symbols.c: Use C++ exception handling.
498         * compile/compile-c-symbols.c: Use C++ exception handling.
499         * common/selftest.c: Use C++ exception handling.
500         * common/new-op.c: Use C++ exception handling.
501         * cli/cli-script.c: Use C++ exception handling.
502         * cli/cli-interp.c: Use C++ exception handling.
503         * cli/cli-cmds.c: Use C++ exception handling.
504         * c-varobj.c: Use C++ exception handling.
505         * btrace.c: Use C++ exception handling.
506         * breakpoint.c: Use C++ exception handling.
507         * break-catch-throw.c: Use C++ exception handling.
508         * arch-utils.c: Use C++ exception handling.
509         * amd64-tdep.c: Use C++ exception handling.
510         * ada-valprint.c: Use C++ exception handling.
511         * ada-typeprint.c: Use C++ exception handling.
512         * ada-lang.c: Use C++ exception handling.
513         * aarch64-tdep.c: Use C++ exception handling.
514
515 2019-04-08  Tom Tromey  <tom@tromey.com>
516
517         * xml-support.c (gdb_xml_parser::parse): Update.
518         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
519         * value.c (show_convenience): Update.
520         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
521         (test_parse_flags_qcs): Update.
522         * thread.c (thr_try_catch_cmd): Update.
523         * target.c (target_translate_tls_address): Update.
524         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
525         (info_frame_command_core, frame_apply_command_count): Update.
526         * rust-exp.y (rust_lex_exception_test): Update.
527         * riscv-tdep.c (riscv_print_one_register_info): Update.
528         * remote.c (remote_target::enable_btrace): Update.
529         * record-btrace.c (record_btrace_enable_warn): Update.
530         * python/py-utils.c (gdbpy_convert_exception): Update.
531         * printcmd.c (do_one_display, print_variable_and_value): Update.
532         * mi/mi-main.c (mi_print_exception): Update.
533         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
534         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
535         * linux-nat.c (linux_nat_target::attach): Update.
536         * linux-fork.c (class scoped_switch_fork_info): Update.
537         * infrun.c (displaced_step_prepare): Update.
538         * infcall.c (call_function_by_hand_dummy): Update.
539         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
540         * gnu-v3-abi.c (print_one_vtable): Update.
541         * frame.c (get_prev_frame_always): Update.
542         * f-valprint.c (info_common_command_for_block): Update.
543         * exec.c (try_open_exec_file): Update.
544         * exceptions.c (print_exception, exception_print)
545         (exception_fprintf, exception_print_same): Update.
546         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
547         * dwarf-index-cache.c (index_cache::store)
548         (index_cache::lookup_gdb_index): Update.
549         * darwin-nat.c (maybe_cache_shell): Update.
550         * cp-valprint.c (cp_print_value_fields): Update.
551         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
552         (gcc_cplus_symbol_address): Update.
553         * compile/compile-c-symbols.c (gcc_convert_symbol)
554         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
555         * common/selftest.c: Update.
556         * common/common-exceptions.h (struct gdb_exception) <message>: Now
557         a std::string.
558         (exception_try_scope_entry, exception_try_scope_exit): Don't
559         declare.
560         (struct exception_try_scope): Remove.
561         (TRY): Don't use exception_try_scope.
562         (struct gdb_exception): Add constructor, operator=.
563         <what>: New method.
564         (struct gdb_exception_RETURN_MASK_ALL)
565         (struct gdb_exception_RETURN_MASK_ERROR)
566         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
567         (struct gdb_quit_bad_alloc): Update.
568         * common/common-exceptions.c (exception_none): Change
569         initializer.
570         (struct catcher) <state, exception>: Initialize inline.
571         <prev>: Remove member.
572         (current_catcher): Remove.
573         (catchers): New global.
574         (exceptions_state_mc_init): Simplify.
575         (catcher_pop): Remove.
576         (exceptions_state_mc, exceptions_state_mc_catch): Update.
577         (try_scope_depth, exception_try_scope_entry)
578         (exception_try_scope_exit): Remove.
579         (throw_exception_sjlj): Update.
580         (exception_messages, exception_messages_size): Remove.
581         (throw_it): Simplify.
582         (gdb_exception_sliced_copy): Remove.
583         (throw_exception_cxx): Update.
584         * cli/cli-script.c (script_from_file): Update.
585         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
586         Update.
587         * ada-valprint.c (ada_val_print): Update.
588         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
589         (create_excep_cond_exprs): Update.
590
591 2019-04-08  Tom Tromey  <tom@tromey.com>
592
593         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
594         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
595         (TRY, CATCH, END_CATCH): Remove some definitions.
596         * common/common-exceptions.c: Don't use GDB_XCPT.
597         (catcher_list_size): Remove.
598         (throw_exception, throw_it): Simplify.
599
600 2019-04-05  Tom Tromey  <tom@tromey.com>
601
602         Revert the header-sorting patch.
603         * ft32-tdep.c: Revert.
604         * frv-tdep.c: Revert.
605         * frv-linux-tdep.c: Revert.
606         * frame.c: Revert.
607         * frame-unwind.c: Revert.
608         * frame-base.c: Revert.
609         * fork-child.c: Revert.
610         * findvar.c: Revert.
611         * findcmd.c: Revert.
612         * filesystem.c: Revert.
613         * filename-seen-cache.h: Revert.
614         * filename-seen-cache.c: Revert.
615         * fbsd-tdep.c: Revert.
616         * fbsd-nat.h: Revert.
617         * fbsd-nat.c: Revert.
618         * f-valprint.c: Revert.
619         * f-typeprint.c: Revert.
620         * f-lang.c: Revert.
621         * extension.h: Revert.
622         * extension.c: Revert.
623         * extension-priv.h: Revert.
624         * expprint.c: Revert.
625         * exec.h: Revert.
626         * exec.c: Revert.
627         * exceptions.c: Revert.
628         * event-top.c: Revert.
629         * event-loop.c: Revert.
630         * eval.c: Revert.
631         * elfread.c: Revert.
632         * dwarf2read.h: Revert.
633         * dwarf2read.c: Revert.
634         * dwarf2loc.c: Revert.
635         * dwarf2expr.h: Revert.
636         * dwarf2expr.c: Revert.
637         * dwarf2-frame.c: Revert.
638         * dwarf2-frame-tailcall.c: Revert.
639         * dwarf-index-write.h: Revert.
640         * dwarf-index-write.c: Revert.
641         * dwarf-index-common.c: Revert.
642         * dwarf-index-cache.h: Revert.
643         * dwarf-index-cache.c: Revert.
644         * dummy-frame.c: Revert.
645         * dtrace-probe.c: Revert.
646         * disasm.h: Revert.
647         * disasm.c: Revert.
648         * disasm-selftests.c: Revert.
649         * dictionary.c: Revert.
650         * dicos-tdep.c: Revert.
651         * demangle.c: Revert.
652         * dcache.h: Revert.
653         * dcache.c: Revert.
654         * darwin-nat.h: Revert.
655         * darwin-nat.c: Revert.
656         * darwin-nat-info.c: Revert.
657         * d-valprint.c: Revert.
658         * d-namespace.c: Revert.
659         * d-lang.c: Revert.
660         * ctf.c: Revert.
661         * csky-tdep.c: Revert.
662         * csky-linux-tdep.c: Revert.
663         * cris-tdep.c: Revert.
664         * cris-linux-tdep.c: Revert.
665         * cp-valprint.c: Revert.
666         * cp-support.c: Revert.
667         * cp-namespace.c: Revert.
668         * cp-abi.c: Revert.
669         * corelow.c: Revert.
670         * corefile.c: Revert.
671         * continuations.c: Revert.
672         * completer.h: Revert.
673         * completer.c: Revert.
674         * complaints.c: Revert.
675         * coffread.c: Revert.
676         * coff-pe-read.c: Revert.
677         * cli-out.h: Revert.
678         * cli-out.c: Revert.
679         * charset.c: Revert.
680         * c-varobj.c: Revert.
681         * c-valprint.c: Revert.
682         * c-typeprint.c: Revert.
683         * c-lang.c: Revert.
684         * buildsym.c: Revert.
685         * buildsym-legacy.c: Revert.
686         * build-id.h: Revert.
687         * build-id.c: Revert.
688         * btrace.c: Revert.
689         * bsd-uthread.c: Revert.
690         * breakpoint.h: Revert.
691         * breakpoint.c: Revert.
692         * break-catch-throw.c: Revert.
693         * break-catch-syscall.c: Revert.
694         * break-catch-sig.c: Revert.
695         * blockframe.c: Revert.
696         * block.c: Revert.
697         * bfin-tdep.c: Revert.
698         * bfin-linux-tdep.c: Revert.
699         * bfd-target.c: Revert.
700         * bcache.c: Revert.
701         * ax-general.c: Revert.
702         * ax-gdb.h: Revert.
703         * ax-gdb.c: Revert.
704         * avr-tdep.c: Revert.
705         * auxv.c: Revert.
706         * auto-load.c: Revert.
707         * arm-wince-tdep.c: Revert.
708         * arm-tdep.c: Revert.
709         * arm-symbian-tdep.c: Revert.
710         * arm-pikeos-tdep.c: Revert.
711         * arm-obsd-tdep.c: Revert.
712         * arm-nbsd-tdep.c: Revert.
713         * arm-nbsd-nat.c: Revert.
714         * arm-linux-tdep.c: Revert.
715         * arm-linux-nat.c: Revert.
716         * arm-fbsd-tdep.c: Revert.
717         * arm-fbsd-nat.c: Revert.
718         * arm-bsd-tdep.c: Revert.
719         * arch-utils.c: Revert.
720         * arc-tdep.c: Revert.
721         * arc-newlib-tdep.c: Revert.
722         * annotate.h: Revert.
723         * annotate.c: Revert.
724         * amd64-windows-tdep.c: Revert.
725         * amd64-windows-nat.c: Revert.
726         * amd64-tdep.c: Revert.
727         * amd64-sol2-tdep.c: Revert.
728         * amd64-obsd-tdep.c: Revert.
729         * amd64-obsd-nat.c: Revert.
730         * amd64-nbsd-tdep.c: Revert.
731         * amd64-nbsd-nat.c: Revert.
732         * amd64-nat.c: Revert.
733         * amd64-linux-tdep.c: Revert.
734         * amd64-linux-nat.c: Revert.
735         * amd64-fbsd-tdep.c: Revert.
736         * amd64-fbsd-nat.c: Revert.
737         * amd64-dicos-tdep.c: Revert.
738         * amd64-darwin-tdep.c: Revert.
739         * amd64-bsd-nat.c: Revert.
740         * alpha-tdep.c: Revert.
741         * alpha-obsd-tdep.c: Revert.
742         * alpha-nbsd-tdep.c: Revert.
743         * alpha-mdebug-tdep.c: Revert.
744         * alpha-linux-tdep.c: Revert.
745         * alpha-linux-nat.c: Revert.
746         * alpha-bsd-tdep.c: Revert.
747         * alpha-bsd-nat.c: Revert.
748         * aix-thread.c: Revert.
749         * agent.c: Revert.
750         * addrmap.c: Revert.
751         * ada-varobj.c: Revert.
752         * ada-valprint.c: Revert.
753         * ada-typeprint.c: Revert.
754         * ada-tasks.c: Revert.
755         * ada-lang.c: Revert.
756         * aarch64-tdep.c: Revert.
757         * aarch64-ravenscar-thread.c: Revert.
758         * aarch64-newlib-tdep.c: Revert.
759         * aarch64-linux-tdep.c: Revert.
760         * aarch64-linux-nat.c: Revert.
761         * aarch64-fbsd-tdep.c: Revert.
762         * aarch64-fbsd-nat.c: Revert.
763         * aarch32-linux-nat.c: Revert.
764
765 2019-04-05  Tom Tromey  <tom@tromey.com>
766
767         * ft32-tdep.c: Sort headers.
768         * frv-tdep.c: Sort headers.
769         * frv-linux-tdep.c: Sort headers.
770         * frame.c: Sort headers.
771         * frame-unwind.c: Sort headers.
772         * frame-base.c: Sort headers.
773         * fork-child.c: Sort headers.
774         * findvar.c: Sort headers.
775         * findcmd.c: Sort headers.
776         * filesystem.c: Sort headers.
777         * filename-seen-cache.h: Sort headers.
778         * filename-seen-cache.c: Sort headers.
779         * fbsd-tdep.c: Sort headers.
780         * fbsd-nat.h: Sort headers.
781         * fbsd-nat.c: Sort headers.
782         * f-valprint.c: Sort headers.
783         * f-typeprint.c: Sort headers.
784         * f-lang.c: Sort headers.
785         * extension.h: Sort headers.
786         * extension.c: Sort headers.
787         * extension-priv.h: Sort headers.
788         * expprint.c: Sort headers.
789         * exec.h: Sort headers.
790         * exec.c: Sort headers.
791         * exceptions.c: Sort headers.
792         * event-top.c: Sort headers.
793         * event-loop.c: Sort headers.
794         * eval.c: Sort headers.
795         * elfread.c: Sort headers.
796         * dwarf2read.h: Sort headers.
797         * dwarf2read.c: Sort headers.
798         * dwarf2loc.c: Sort headers.
799         * dwarf2expr.h: Sort headers.
800         * dwarf2expr.c: Sort headers.
801         * dwarf2-frame.c: Sort headers.
802         * dwarf2-frame-tailcall.c: Sort headers.
803         * dwarf-index-write.h: Sort headers.
804         * dwarf-index-write.c: Sort headers.
805         * dwarf-index-common.c: Sort headers.
806         * dwarf-index-cache.h: Sort headers.
807         * dwarf-index-cache.c: Sort headers.
808         * dummy-frame.c: Sort headers.
809         * dtrace-probe.c: Sort headers.
810         * disasm.h: Sort headers.
811         * disasm.c: Sort headers.
812         * disasm-selftests.c: Sort headers.
813         * dictionary.c: Sort headers.
814         * dicos-tdep.c: Sort headers.
815         * demangle.c: Sort headers.
816         * dcache.h: Sort headers.
817         * dcache.c: Sort headers.
818         * darwin-nat.h: Sort headers.
819         * darwin-nat.c: Sort headers.
820         * darwin-nat-info.c: Sort headers.
821         * d-valprint.c: Sort headers.
822         * d-namespace.c: Sort headers.
823         * d-lang.c: Sort headers.
824         * ctf.c: Sort headers.
825         * csky-tdep.c: Sort headers.
826         * csky-linux-tdep.c: Sort headers.
827         * cris-tdep.c: Sort headers.
828         * cris-linux-tdep.c: Sort headers.
829         * cp-valprint.c: Sort headers.
830         * cp-support.c: Sort headers.
831         * cp-namespace.c: Sort headers.
832         * cp-abi.c: Sort headers.
833         * corelow.c: Sort headers.
834         * corefile.c: Sort headers.
835         * continuations.c: Sort headers.
836         * completer.h: Sort headers.
837         * completer.c: Sort headers.
838         * complaints.c: Sort headers.
839         * coffread.c: Sort headers.
840         * coff-pe-read.c: Sort headers.
841         * cli-out.h: Sort headers.
842         * cli-out.c: Sort headers.
843         * charset.c: Sort headers.
844         * c-varobj.c: Sort headers.
845         * c-valprint.c: Sort headers.
846         * c-typeprint.c: Sort headers.
847         * c-lang.c: Sort headers.
848         * buildsym.c: Sort headers.
849         * buildsym-legacy.c: Sort headers.
850         * build-id.h: Sort headers.
851         * build-id.c: Sort headers.
852         * btrace.c: Sort headers.
853         * bsd-uthread.c: Sort headers.
854         * breakpoint.h: Sort headers.
855         * breakpoint.c: Sort headers.
856         * break-catch-throw.c: Sort headers.
857         * break-catch-syscall.c: Sort headers.
858         * break-catch-sig.c: Sort headers.
859         * blockframe.c: Sort headers.
860         * block.c: Sort headers.
861         * bfin-tdep.c: Sort headers.
862         * bfin-linux-tdep.c: Sort headers.
863         * bfd-target.c: Sort headers.
864         * bcache.c: Sort headers.
865         * ax-general.c: Sort headers.
866         * ax-gdb.h: Sort headers.
867         * ax-gdb.c: Sort headers.
868         * avr-tdep.c: Sort headers.
869         * auxv.c: Sort headers.
870         * auto-load.c: Sort headers.
871         * arm-wince-tdep.c: Sort headers.
872         * arm-tdep.c: Sort headers.
873         * arm-symbian-tdep.c: Sort headers.
874         * arm-pikeos-tdep.c: Sort headers.
875         * arm-obsd-tdep.c: Sort headers.
876         * arm-nbsd-tdep.c: Sort headers.
877         * arm-nbsd-nat.c: Sort headers.
878         * arm-linux-tdep.c: Sort headers.
879         * arm-linux-nat.c: Sort headers.
880         * arm-fbsd-tdep.c: Sort headers.
881         * arm-fbsd-nat.c: Sort headers.
882         * arm-bsd-tdep.c: Sort headers.
883         * arch-utils.c: Sort headers.
884         * arc-tdep.c: Sort headers.
885         * arc-newlib-tdep.c: Sort headers.
886         * annotate.h: Sort headers.
887         * annotate.c: Sort headers.
888         * amd64-windows-tdep.c: Sort headers.
889         * amd64-windows-nat.c: Sort headers.
890         * amd64-tdep.c: Sort headers.
891         * amd64-sol2-tdep.c: Sort headers.
892         * amd64-obsd-tdep.c: Sort headers.
893         * amd64-obsd-nat.c: Sort headers.
894         * amd64-nbsd-tdep.c: Sort headers.
895         * amd64-nbsd-nat.c: Sort headers.
896         * amd64-nat.c: Sort headers.
897         * amd64-linux-tdep.c: Sort headers.
898         * amd64-linux-nat.c: Sort headers.
899         * amd64-fbsd-tdep.c: Sort headers.
900         * amd64-fbsd-nat.c: Sort headers.
901         * amd64-dicos-tdep.c: Sort headers.
902         * amd64-darwin-tdep.c: Sort headers.
903         * amd64-bsd-nat.c: Sort headers.
904         * alpha-tdep.c: Sort headers.
905         * alpha-obsd-tdep.c: Sort headers.
906         * alpha-nbsd-tdep.c: Sort headers.
907         * alpha-mdebug-tdep.c: Sort headers.
908         * alpha-linux-tdep.c: Sort headers.
909         * alpha-linux-nat.c: Sort headers.
910         * alpha-bsd-tdep.c: Sort headers.
911         * alpha-bsd-nat.c: Sort headers.
912         * aix-thread.c: Sort headers.
913         * agent.c: Sort headers.
914         * addrmap.c: Sort headers.
915         * ada-varobj.c: Sort headers.
916         * ada-valprint.c: Sort headers.
917         * ada-typeprint.c: Sort headers.
918         * ada-tasks.c: Sort headers.
919         * ada-lang.c: Sort headers.
920         * aarch64-tdep.c: Sort headers.
921         * aarch64-ravenscar-thread.c: Sort headers.
922         * aarch64-newlib-tdep.c: Sort headers.
923         * aarch64-linux-tdep.c: Sort headers.
924         * aarch64-linux-nat.c: Sort headers.
925         * aarch64-fbsd-tdep.c: Sort headers.
926         * aarch64-fbsd-nat.c: Sort headers.
927         * aarch32-linux-nat.c: Sort headers.
928
929 2019-04-04  Tom Tromey  <tom@tromey.com>
930
931         * varobj.c (varobj_create): Update.
932         * rust-exp.y (struct rust_parser) <update_innermost_block,
933         lookup_symbol>: New methods.
934         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
935         Rename.
936         (rust_parser::rust_lookup_type)
937         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
938         * printcmd.c (display_command, do_one_display): Update.
939         * parser-defs.h (struct parser_state) <parser_state>: Add
940         "tracker" parameter.
941         (block_tracker): New member.
942         (class innermost_block_tracker) <innermost_block_tracker>: Add
943         "types" parameter.
944         <reset>: Remove method.
945         (innermost_block): Don't declare.
946         (null_post_parser): Update.
947         * parse.c (innermost_block): Remove global.
948         (write_dollar_variable): Update.
949         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
950         Remove "tracker_types" parameter.
951         (parse_expression): Add "tracker" parameter.
952         (parse_expression_for_completion): Update.
953         (null_post_parser): Add "tracker" parameter.
954         * p-exp.y: Update rules.
955         * m2-exp.y: Update rules.
956         * language.h (struct language_defn) <la_post_parser>: Add
957         "tracker" parameter.
958         * go-exp.y: Update rules.
959         * f-exp.y: Update rules.
960         * expression.h (parse_expression, parse_exp_1): Add "tracker"
961         parameter.
962         * d-exp.y: Update rules.
963         * c-exp.y: Update rules.
964         * breakpoint.c (set_breakpoint_condition): Create an
965         innermost_block_tracker.
966         (watch_command_1): Likewise.
967         * ada-lang.c (resolve): Add "tracker" parameter.
968         (resolve_subexp): Likewise.
969         * ada-exp.y (write_var_from_sym): Update.
970
971 2019-04-04  Tom Tromey  <tom@tromey.com>
972
973         * type-stack.h: New file.
974         * type-stack.c: New file.
975         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
976         type-stack.h.
977         (insert_into_type_stack, insert_type, push_type, push_type_int)
978         (insert_type_address_space, pop_type, pop_type_int)
979         (pop_typelist, pop_type_stack, append_type_stack)
980         (push_type_stack, get_type_stack, push_typelist)
981         (follow_type_instance_flags, follow_types): Don't declare.
982         * parse.c (type_stack): Remove global.
983         (parse_exp_in_context): Update.
984         (insert_into_type_stack, insert_type, push_type, push_type_int)
985         (insert_type_address_space, pop_type, pop_type_int)
986         (pop_typelist, pop_type_stack, append_type_stack)
987         (push_type_stack, get_type_stack, push_typelist)
988         (follow_type_instance_flags, follow_types): Remove (moved to
989         type-stack.c).
990         * f-exp.y (type_stack): New global.
991         Update rules.
992         (push_kind_type, f_parse): Update.
993         * d-exp.y (type_stack): New global.
994         Update rules.
995         (d_parse): Update.
996         * c-exp.y (struct c_parse_state) <type_stack>: New member.
997         Update rules.
998         * Makefile.in (COMMON_SFILES): Add type-stack.c.
999         (HFILES_NO_SRCDIR): Add type-stack.h.
1000
1001 2019-04-04  Tom Tromey  <tom@tromey.com>
1002
1003         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1004         (rust_parser::convert_ast_to_expression, rust_parse)
1005         (rust_lex_test_completion, rust_lex_tests): Update.
1006         * parser-defs.h (struct expr_completion_state): New.
1007         (struct parser_state) <parser_state>: Add completion parameter.
1008         <mark_struct_expression, mark_completion_tag>: New methods.
1009         <parse_completion, m_completion_state>: New members.
1010         (prefixify_expression, null_post_parser): Update.
1011         (mark_struct_expression, mark_completion_tag): Don't declare.
1012         * parse.c (parse_completion, expout_last_struct)
1013         (expout_tag_completion_type, expout_completion_name): Remove
1014         globals.
1015         (parser_state::mark_struct_expression)
1016         (parser_state::mark_completion_tag): Now methods.
1017         (prefixify_expression): Add last_struct parameter.
1018         (prefixify_subexp): Likewise.
1019         (parse_exp_1): Update.
1020         (parse_exp_in_context): Add cstate parameter.  Update.
1021         (parse_expression_for_completion): Create an
1022         expr_completion_state.
1023         (null_post_parser): Add "completion" parameter.
1024         * p-exp.y: Update rules.
1025         (yylex): Update.
1026         * language.h (struct language_defn) <la_post_parser>: Add
1027         "completing" parameter.
1028         * go-exp.y: Update rules.
1029         (lex_one_token): Update.
1030         * expression.h (parse_completion): Don't declare.
1031         * d-exp.y: Update rules.
1032         (lex_one_token): Update rules.
1033         * c-exp.y: Update rules.
1034         (lex_one_token): Update.
1035         * ada-lang.c (resolve): Add "parse_completion" parameter.
1036         (resolve_subexp): Likewise.
1037         (ada_resolve_function): Likewise.
1038
1039 2019-04-04  Tom Tromey  <tom@tromey.com>
1040
1041         * parser-defs.h (struct parser_state) <start_arglist,
1042         end_arglist>: New methods.
1043         <arglist_len, m_funcall_chain>: New members.
1044         (arglist_len, start_arglist, end_arglist): Don't declare.
1045         * parse.c (arglist_len, funcall_chain): Remove global.
1046         (start_arglist, end_arglist): Remove functions.
1047         (parse_exp_in_context): Update.
1048         * p-exp.y: Update rules.
1049         * m2-exp.y: Update rules.
1050         * go-exp.y: Update rules.
1051         * f-exp.y: Update rules.
1052         * d-exp.y: Update rules.
1053         * c-exp.y: Update rules.
1054
1055 2019-04-04  Tom Tromey  <tom@tromey.com>
1056
1057         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1058         lex_operator, push_back>: New methods.
1059         Update all rules.
1060         (rust_parser::lex_hex, lex_escape): Rename and update.
1061         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1062         (rust_parser::lex_operator): Rename and update.
1063         (rust_parser::lex_number, rustyylex, rustyyerror)
1064         (rust_lex_test_init, rust_lex_test_sequence)
1065         (rust_lex_test_push_back, rust_lex_tests): Update.
1066         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1067         parameter.
1068         <lexptr, prev_lexptr>: New members.
1069         (lexptr, prev_lexptr): Don't declare.
1070         * parse.c (lexptr, prev_lexptr): Remove globals.
1071         (parse_exp_in_context): Update.
1072         * p-exp.y (yylex, yyerror): Update.
1073         * m2-exp.y (parse_number, yylex, yyerror): Update.
1074         * go-exp.y (lex_one_token, yyerror): Update.
1075         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1076         * d-exp.y (lex_one_token, yyerror): Update.
1077         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1078         (lex_one_token, yyerror): Update.
1079         * ada-lex.l (YY_INPUT): Update.
1080         (rewind_to_char): Update.
1081         * ada-exp.y (yyerror): Update.
1082
1083 2019-04-04  Tom Tromey  <tom@tromey.com>
1084
1085         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1086         * parser-defs.h (struct parser_state) <parser_state>: Add new
1087         parameter.
1088         <comma_terminates>: New member.
1089         (comma_terminates): Don't declare global.
1090         * parse.c (comma_terminates): Remove global.
1091         (parse_exp_in_context): Update.
1092         * p-exp.y (yylex): Update.
1093         * m2-exp.y (yylex): Update.
1094         * go-exp.y (lex_one_token): Update.
1095         * f-exp.y (yylex): Update.
1096         * d-exp.y (lex_one_token): Update.
1097         * c-exp.y (lex_one_token): Update.
1098         * ada-lex.l: Update.
1099
1100 2019-04-04  Tom Tromey  <tom@tromey.com>
1101
1102         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1103         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1104         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1105         * parser-defs.h (paren_depth): Don't declare.
1106         * parse.c (paren_depth): Remove global.
1107         (parse_exp_in_context): Update.
1108         * p-exp.y (paren_depth): New global.
1109         (pascal_parse): Initialize it.
1110         * m2-exp.y (paren_depth): New global.
1111         (m2_parse): Initialize it.
1112         * go-exp.y (paren_depth): New global.
1113         (go_parse): Initialize it.
1114         * f-exp.y (paren_depth): New global.
1115         (f_parse): Initialize it.
1116         * d-exp.y (paren_depth): New global.
1117         (d_parse): Initialize it.
1118         * c-exp.y (paren_depth): New global.
1119         (c_parse): Initialize it.
1120         * ada-lex.l (paren_depth): New global.
1121         (lexer_init): Initialize it.
1122
1123 2019-04-04  Tom Tromey  <tom@tromey.com>
1124
1125         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1126         (rust_parser::convert_ast_to_type)
1127         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1128         * parser-defs.h (struct parser_state) <parser_state>: Add
1129         parameters.  Initialize new members.
1130         <expression_context_block, expression_context_pc>: New members.
1131         * parse.c (expression_context_block, expression_context_pc):
1132         Remove globals.
1133         (parse_exp_in_context): Update.
1134         * p-exp.y: Update all rules.
1135         (yylex): Update.
1136         * m2-exp.y: Update all rules.
1137         (yylex): Update.
1138         * go-exp.y (yylex): Update.
1139         * f-exp.y (yylex): Update.
1140         * d-exp.y: Update all rules.
1141         (yylex): Update.
1142         * c-exp.y: Update all rules.
1143         (lex_one_token, classify_name, yylex, c_parse): Update.
1144         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1145
1146 2019-04-04  Tom Tromey  <tom@tromey.com>
1147
1148         * gdbarch.h, gdbarch.c: Rebuild.
1149         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1150         * stap-probe.h: 
1151         (struct stap_parse_info): Replace "parser_state" with
1152         "expr_builder".
1153         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1154         (parser_state): New class.
1155         * parse.c (expr_builder): Rename.
1156         (expr_builder::release): Rename.
1157         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1158         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1159         (write_exp_elt_longcst, write_exp_elt_floatcst)
1160         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1161         (write_exp_string_vector, write_exp_bitstring)
1162         (write_exp_msymbol, mark_struct_expression)
1163         (write_dollar_variable)
1164         (insert_type_address_space, increase_expout_size): Replace
1165         "parser_state" with "expr_builder".
1166         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1167         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1168         "parser_state" with "expr_builder".
1169
1170 2019-04-04  Tom Tromey  <tom@tromey.com>
1171
1172         * rust-exp.y: Replace "parse_language" with method call.
1173         * p-exp.y: 
1174         (yylex): Replace "parse_language" with method call.
1175         * m2-exp.y: 
1176         (yylex): Replace "parse_language" with method call.
1177         * go-exp.y (classify_name): Replace "parse_language" with method
1178         call.
1179         * f-exp.y (yylex): Replace "parse_language" with method call.
1180         * d-exp.y (lex_one_token): Replace "parse_language" with method
1181         call.
1182         * c-exp.y: 
1183         (lex_one_token, classify_name, yylex): Replace "parse_language"
1184         with method call.
1185         * ada-exp.y (find_primitive_type, type_char)
1186         (type_system_address): Replace "parse_language" with method call.
1187
1188 2019-04-04  Tom Tromey  <tom@tromey.com>
1189
1190         * rust-exp.y: Replace "parse_gdbarch" with method call.
1191         * parse.c (write_dollar_variable, insert_type_address_space):
1192         Replace "parse_gdbarch" with method call.
1193         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1194         call.
1195         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1196         call.
1197         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1198         "parse_gdbarch" with method call.
1199         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1200         with method call.
1201         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1202         "parse_gdbarch" with method call.
1203         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1204         "parse_gdbarch" with method call.
1205         * c-exp.y (parse_type, parse_number, classify_name): Replace
1206         "parse_gdbarch" with method call.
1207         * ada-lex.l: Replace "parse_gdbarch" with method call.
1208         * ada-exp.y (parse_type, find_primitive_type, type_char)
1209         (type_system_address): Replace "parse_gdbarch" with method call.
1210
1211 2019-04-04  Tom Tromey  <tom@tromey.com>
1212
1213         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1214         * stap-probe.c (stap_parse_argument): Update.
1215         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1216         initial_size parameter.
1217         * rust-exp.y (rust_lex_tests): Update.
1218         * parse.c (parser_state): Update.
1219         (parse_exp_in_context): Update.
1220         * parser-defs.h (struct parser_state) <parser_state>: Remove
1221         "initial_size" parameter.
1222
1223 2019-04-04  Tom Tromey  <tom@tromey.com>
1224
1225         * parser-defs.h (increase_expout_size): Don't declare.
1226         * parse.c (increase_expout_size): Now static.
1227
1228 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1229
1230         * gnu-nat.c (gnu_nat_target::wait): Fix
1231         target_waitstatus_to_string call.
1232
1233 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * eval.c (evaluate_subexp_standard): Handle internal functions
1236         during Fortran function call handling.
1237
1238 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * NEWS: Mention new internal functions.
1241         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1242         (read_base_type): Use dwarf2_init_complex_target_type.
1243         * value.c (creal_internal_fn): New function.
1244         (cimag_internal_fn): New function.
1245         (_initialize_values): Register new internal functions.
1246
1247 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1248
1249         * infrun.c (stop_all_threads): If debug_infrun, always
1250         trace the wait status after wait_one, using
1251         target_waitstatus_to_string and target_pid_to_str.
1252         (handle_inferior_event): Replace various trace of
1253         wait status kind by a single trace.
1254         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1255         wait status kind image by target_waitstatus_to_string.
1256         * target/waitstatus.c (target_waitstatus_to_string): Fix
1257         obsolete comment.
1258
1259 2019-04-01  Tom Tromey  <tromey@adacore.com>
1260
1261         PR symtab/23331:
1262         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1263
1264 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1265             Pedro Alves  <palves@redhat.com>
1266
1267         * top.c (quit_force): Call 'finalize_values'.
1268         * value.c (finalize_values): New function.
1269         * value.h (finalize_values): Declare.
1270
1271 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1272
1273         * NEWS: Announce $_gdb_major and $_gdb_minor.
1274
1275         * top.c (init_gdb_version_vars): New function.
1276         (gdb_init): Call init_gdb_version_vars.
1277
1278 2019-03-29  Tom Tromey  <tromey@adacore.com>
1279
1280         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1281         help text.  Remove dead code.
1282
1283 2019-03-29  Keith Seitz  <keiths@redhat.com>
1284
1285         From Siddhesh Poyarekar:
1286         * f-lang.h (f77_get_upperbound): Return LONGEST.
1287         (f77_get_lowerbound): Likewise.
1288         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1289         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1290         print them.
1291         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1292         plongest to format print it.
1293         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1294         (f77_get_upperbound): Likewise.
1295         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1296         LOWER_BOUND to LONGEST.
1297         (f77_create_arrayprint_offset_tbl): Likewise.
1298
1299 2019-03-29  Keith Seitz  <keiths@redhat.com>
1300
1301         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1302         %s/pulongest for TYPE_LENGTH instead of %d in format
1303         strings.
1304         * ada-typerint.c (ada_print_type): Likewise.
1305         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1306         * compile/compile-c-support.c (generate_register_struct): Likewise.
1307         * gdbtypes.c (recursive_dump_type): Likewise.
1308         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1309         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1310         instead of %d in format strings.
1311         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1312         to std::min to ULONGEST.
1313         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1314         instead of %d in format strings.
1315         * tracepoint.c (info_scope_command): Likewise.
1316         * typeprint.c (print_offset_data::update)
1317         (print_offset_data::finish): Likewise.
1318         * xtensa-tdep.c (xtensa_store_return_value)
1319         (xtensa_push_dummy_call): Likewise.
1320
1321 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1322
1323         * windows-nat.c (display_selector): Fixed format specifications
1324         for 64-bit Cygwin.
1325
1326 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1327
1328         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1329
1330 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1331
1332         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1333         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1334         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1335         (nios2_linux_init_abi): Install it.
1336
1337 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1338
1339         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1340
1341 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1342
1343         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1344
1345 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1346             Tom Tromey  <tromey@adacore.com>
1347
1348         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1349
1350 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1351
1352         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1353         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1354         method to compute the bounds of range types. Also print "[evaluated]"
1355         if the bounds' values come from a dynamic evaluation.
1356
1357 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1358
1359         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1360         whitespace when pretty printing is on.
1361
1362 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1363
1364         * ppc-linux-nat.c: Add include.
1365
1366 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * NEWS: Mention AArch64 Pointer Authentication.
1369
1370 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * arm-linux-nat.c: Add include.
1373
1374 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1375
1376         * source-cache.c (source_cache::get_source_lines): Re-read
1377         fullname after calling open_source_file.
1378
1379 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1380
1381         * NEWS: Mention TLS support for FreeBSD.
1382
1383 2019-03-25  Tom Tromey  <tromey@adacore.com>
1384
1385         * minsyms.c (BUNCH_SIZE): Update comment.
1386         (~minimal_symbol_reader): Remove old comment.
1387         (compact_minimal_symbols): Update comment.
1388         (minimal_symbol_reader::install): Remove old comment.  Update
1389         other comments.
1390
1391 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1392
1393         * s390-linux-nat.c: Add include.
1394
1395 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1396
1397         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1398         Call linux_get_hwcap.
1399         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1400         Likewise.
1401         (aarch64_linux_get_hwcap): Remove function.
1402         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1403         declaration.
1404         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1405         linux_get_hwcap.
1406         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1407         * linux-tdep.c (linux_get_hwcap): Add function.
1408         (linux_get_hwcap2): Likewise.
1409         * linux-tdep.h (linux_get_hwcap): Add declaration.
1410         (linux_get_hwcap2): Likewise.
1411         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1412         (ppc_linux_get_hwcap2): Likewise.
1413         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1414         linux_get_hwcap.
1415         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1416         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1417         (ppc_linux_nat_target::read_description): Likewise.
1418         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1419         * s390-linux-nat.c: Likewise.
1420         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1421
1422 2019-03-24  Tom Tromey  <tom@tromey.com>
1423
1424         * ada-lang.c (standard_lookup): Simplify initialization.
1425         (ada_lookup_symbol_nonlocal): Simplify return.
1426         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1427         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1428         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1429         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1430         initialization.
1431         * solib.c (solib_global_lookup): Simplify.
1432         * symtab.c (null_block_symbol): Remove.
1433         (symbol_cache_lookup): Simplify returns.
1434         (lookup_language_this): Simplify returns.
1435         (lookup_symbol_aux): Simplify return.
1436         (lookup_local_symbol): Simplify returns.
1437         (lookup_global_symbol_from_objfile): Simplify return.
1438         (lookup_symbol_in_objfile_symtabs)
1439         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1440         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1441         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1442         * cp-namespace.c (cp_lookup_bare_symbol)
1443         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1444         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1445         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1446         (cp_lookup_symbol_via_imports): Simplify initialization.
1447         (find_symbol_in_baseclass): Likewise.
1448         * symtab.h (null_block_symbol): Remove.
1449         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1450         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1451         (d_lookup_symbol_module): Likewise.
1452         (find_symbol_in_baseclass): Simplify initialization.
1453
1454 2019-03-24  Tom Tromey  <tom@tromey.com>
1455
1456         * expression.h: Don't include symtab.h.
1457         (struct block): Forward declare.
1458
1459 2019-03-24  Tom Tromey  <tom@tromey.com>
1460
1461         * c-exp.y (typebase): Remove casts.
1462         * gdbtypes.c (lookup_unsigned_typename, )
1463         (lookup_signed_typename): Remove cast.
1464         * eval.c (parse_to_comma_and_eval): Remove cast.
1465         * parse.c (write_dollar_variable): Remove cast.
1466         * block.h (struct block) <superblock>: Now const.
1467         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1468         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1469         (map_block): Make "block" const.
1470         * symfile.h (struct quick_symbol_functions)
1471         <map_matching_symbols>: Constify block argument to "callback".
1472         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1473         const.
1474         (find_pc_sect_compunit_symtab): Make "b" const.
1475         (find_symbol_at_address): Likewise.
1476         (search_symbols): Likewise.
1477         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1478         (dw2_debug_names_lookup_symbol): Likewise.
1479         (dw2_map_matching_symbols): Update.
1480         * p-valprint.c (pascal_val_print): Remove "block".
1481         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1482         (aux_add_nonlocal_symbols): Make "block" const.
1483         (resolve_subexp): Remove cast.
1484         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1485         const.
1486         (iterate_over_file_blocks): Likewise.
1487         * f-exp.y (%union) <bval>: Remove.
1488         * coffread.c (patch_opaque_types): Make "b" const.
1489         * spu-tdep.c (spu_catch_start): Make "block" const.
1490         * c-valprint.c (print_unpacked_pointer): Remove "block".
1491         * symmisc.c (dump_symtab_1): Make "b" const.
1492         (block_depth): Make "block" const.
1493         * d-exp.y (%union) <bval>: Remove.
1494         * cp-support.h (cp_lookup_rtti_type): Update.
1495         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1496         * psymtab.c (psym_lookup_symbol): Make "block" const.
1497         (maintenance_check_psymtabs): Make "b" const.
1498         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1499         (enumerate_locals, enumerate_args): Update.
1500         * python/py-symtab.c (stpy_global_block): Make "block" const.
1501         (stpy_static_block): Likewise.
1502         * inline-frame.c (block_starting_point_at): Make "new_block"
1503         const.
1504         * block.c (find_block_in_blockvector): Make return type const.
1505         (blockvector_for_pc_sect): Make "b" const.
1506         (find_block_in_blockvector): Make "b" const.
1507
1508 2019-03-23  Tom Tromey  <tom@tromey.com>
1509
1510         * varobj.c (varobj_create): Update.
1511         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1512         * printcmd.c (display_command, do_one_display): Don't reset
1513         innermost_block.
1514         * parser-defs.h (enum innermost_block_tracker_type): Move to
1515         expression.h.
1516         (innermost_block): Update comment.
1517         * parse.c (parse_exp_1): Add tracker_types parameter.
1518         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1519         tracker_types parameter.  Reset innermost_block.
1520         (parse_exp_in_context): Remove.
1521         (parse_expression_for_completion): Update.
1522         * objfiles.c (~objfile): Don't reset expression_context_block or
1523         innermost_block.
1524         * expression.h (enum innermost_block_tracker_type): Move from
1525         parser-defs.h.
1526         (parse_exp_1): Add tracker_types parameter.
1527         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1528         reset innermost_block.
1529
1530 2019-03-23  Tom Tromey  <tom@tromey.com>
1531
1532         * objfiles.h: Include bcache.h.
1533
1534 2019-03-23  Tom Tromey  <tom@tromey.com>
1535
1536         * linespec.c (get_current_search_block): Use
1537         scoped_restore_current_language.
1538         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1539
1540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1541             Jiong Wang  <jiong.wang@arm.com>
1542
1543         * aarch64-linux-tdep.c
1544         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1545         section.
1546         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1547
1548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1549             Jiong Wang  <jiong.wang@arm.com>
1550
1551         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1552         instructions.
1553         (aarch64_analyze_prologue_test): Add PACIASP test.
1554         (aarch64_prologue_prev_register): Unmask PC value.
1555
1556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1557             Jiong Wang  <jiong.wang@arm.com>
1558
1559         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1560         (aarch64_dwarf2_prev_register): Unmask PC value.
1561         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1562         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1563         DW_CFA_AARCH64_negate_ra_state.
1564         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1565
1566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1567             Jiong Wang  <jiong.wang@arm.com>
1568
1569         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1570         registers.
1571         (aarch64_pseudo_register_name): Likewise.
1572         (aarch64_pseudo_register_type): Likewise.
1573         (aarch64_pseudo_register_reggroup_p): Likewise.
1574         (aarch64_gdbarch_init): Add pauth registers.
1575         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1576         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1577         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1578         (struct gdbarch_tdep): Add regnum for ra_state.
1579
1580 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1581             Jiong Wang  <jiong.wang@arm.com>
1582
1583         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1584
1585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1586             Jiong Wang  <jiong.wang@arm.com>
1587
1588         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1589         function.
1590         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1591         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1592         (aarch64_gdbarch_init): Add puth registers.
1593         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1594         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1595         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1596
1597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1598             Jiong Wang  <jiong.wang@arm.com>
1599
1600         * aarch64-linux-nat.c
1601         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1602         * aarch64-linux-tdep.c
1603         (aarch64_linux_core_read_description): Likewise.
1604         (aarch64_linux_get_hwcap): New function.
1605         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1606         (aarch64_linux_get_hwcap): New declaration.
1607
1608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1609             Jiong Wang  <jiong.wang@arm.com>
1610
1611         * aarch64-linux-nat.c
1612         (aarch64_linux_nat_target::read_description): Add pauth param.
1613         * aarch64-linux-tdep.c
1614         (aarch64_linux_core_read_description): Likewise.
1615         * aarch64-tdep.c (struct target_desc): Add in pauth.
1616         (aarch64_read_description): Add pauth param.
1617         (aarch64_gdbarch_init): Likewise.
1618         * aarch64-tdep.h (aarch64_read_description): Likewise.
1619         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1620         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1621         * features/Makefile: Add new files.
1622         * features/aarch64-pauth.c: New file.
1623         * features/aarch64-pauth.xml: New file.
1624
1625 2019-03-20  Tom Tromey  <tromey@adacore.com>
1626
1627         * infrun.c (handle_inferior_event): Rename from
1628         handle_inferior_event_1.  Create a scoped_value_mark.
1629         (handle_inferior_event): Remove.
1630
1631 2019-03-19  Tom Tromey  <tromey@adacore.com>
1632
1633         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1634         * infrun.h (print_stop_event): Add "displays" parameter.
1635         * infrun.c (print_stop_event): Add "displays" parameter.
1636
1637 2019-03-19  Pedro Alves  <palves@redhat.com>
1638
1639         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1640         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1641         to -1.  Fix TABs vs spaces.
1642         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1643         * tui/tui-out.h (tui_ui_out) Add intro comments.
1644         <m_line, m_start_of_line>: In-class initialize, and add describing
1645         comment.
1646
1647 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1648
1649         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1650         variable names.
1651         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1652
1653 2019-03-18  Pedro Alves  <palves@redhat.com>
1654             Eli Zaretskii <eliz@gnu.org>
1655
1656         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1657         m_line and m_start_of_line.
1658
1659 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1660
1661         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1662         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1663         it returns a newline.  This fixes a regression in TU mode, whereby
1664         the next line is output on the same screen line as the user input.
1665
1666 2019-03-18  Tom Tromey  <tromey@adacore.com>
1667
1668         * minsyms.c (minimal_symbol_reader::install): Remove call to
1669         obstack_blank.
1670
1671 2019-03-18  Pedro Alves  <palves@redhat.com>
1672
1673         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1674         New globals.
1675         (apply_style): New, factored out from ...
1676         (apply_ansi_escape): ... this.  Handle reverse video mode.
1677         (tui_set_reverse_mode): New function.
1678         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1679         * tui/tui-winsource.c (tui_show_source_line): Use
1680         tui_set_reverse_mode instead of setting A_STANDOUT.
1681         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1682         New setter methods.
1683
1684 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1685
1686         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1687         Handle tabs.
1688
1689 2019-03-18  Tom Tromey  <tromey@adacore.com>
1690
1691         * ada-lang.c (empty_array): Add "high" parameter.
1692         (ada_evaluate_subexp): Update.
1693
1694 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1695
1696         * unittests/string_view-selftests.c: Define
1697         _initialize_string_view_selftests unconditionally.
1698
1699 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1700
1701         PR gdb/24350
1702         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1703
1704 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1705
1706         PR gdb/24351
1707         * windows-nat.c (display_selector): Fix format specifiers.
1708
1709 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1710
1711         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1712         tui_refill_source_window instead of tui_refresh_win, to update the
1713         current execution line.  This fixes redisplay of the current line
1714         when stepping through the code with "next" or "step".
1715
1716 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1717
1718         * source-cache.c (source_cache::get_source_lines): Call
1719         find_source_lines to initialize s->nlines.  This fixes vertical
1720         scrolling of TUI source window when the DOWN arrow is pressed.
1721
1722 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1723
1724         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1725         linux-thread-db.c (_initialize_thread_db): Likewise.
1726
1727 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1728
1729         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1730         wclrtoeol in tui_show_source_line".  This reverts changes made in
1731         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1732
1733 2019-03-15  Tom Tromey  <tom@tromey.com>
1734
1735         * symtab.h (struct minimal_symbol): Derive from
1736         general_symbol_info.
1737         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1738         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1739         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1740         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1741         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1742         (MSYMBOL_SEARCH_NAME): Update.
1743         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1744         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1745         * minsyms.c (minimal_symbol_reader::record_full): Update.
1746
1747 2019-03-15  Tom Tromey  <tom@tromey.com>
1748
1749         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1750
1751 2019-03-15  Tom Tromey  <tom@tromey.com>
1752
1753         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1754         unique_xmalloc_ptr.
1755         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1756         Update.
1757         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1758         (build_minimal_symbol_hash_tables)
1759         (minimal_symbol_reader::install): Update.
1760
1761 2019-03-15  Tom Tromey  <tom@tromey.com>
1762
1763         * symtab.c (create_demangled_names_hash): Update.
1764         (symbol_set_names): Update.
1765         * objfiles.h (struct objfile_per_bfd_storage)
1766         <demangled_names_hash>: Now an htab_up.
1767         * objfiles.c (objfile_per_bfd_storage): Simplify.
1768
1769 2019-03-15  Tom Tromey  <tom@tromey.com>
1770
1771         * objfiles.h (struct objfile_per_bfd_storage): Declare
1772         destructor.
1773         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1774         New.
1775         (get_objfile_bfd_data): Use new.  Don't initialize
1776         language_of_main.
1777         (free_objfile_per_bfd_storage): Remove.
1778         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1779
1780 2019-03-15  Tom Tromey  <tom@tromey.com>
1781
1782         * symfile.c (reread_symbols): Update.
1783         * objfiles.c (objfile::objfile): Update.
1784         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1785         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1786         comment.
1787         (minimal_symbol_reader::install): Update.
1788         (terminate_minimal_symbol_table): Remove.
1789         * jit.c (jit_object_close_impl): Update.
1790
1791 2019-03-15  Tom Tromey  <tom@tromey.com>
1792
1793         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1794         initializations.
1795
1796 2019-03-15  Tom Tromey  <tom@tromey.com>
1797
1798         * objfiles.h (struct objfile_per_bfd_storage)
1799         <demangled_hash_languages>: Now a bitset.
1800         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1801         (lookup_minimal_symbol): Update.
1802
1803 2019-03-15  Tom Tromey  <tom@tromey.com>
1804
1805         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1806         Don't return the symbol.
1807         * coffread.c (record_minimal_symbol): Use record_full.
1808
1809 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1810
1811         The MS-Windows port of ncurses fails to switch to a color pair if
1812         one or both of the colors are the implicit default colors.  This
1813         change records the default colors when TUI is initialized, and
1814         then specifies them explicitly when a color pair uses the default
1815         colors.  This allows color styling in TUI mode on MS-Windows.
1816
1817         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1818         ncurses_norm_attr.
1819         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1820         colors in ncurses_norm_attr.
1821         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1822         "none", replace it with the default color recorded in
1823         ncurses_norm_attr.
1824
1825 2019-03-14  Tom Tromey  <tromey@adacore.com>
1826
1827         * source-cache.h (class source_cache) <get_source_lines>: Return
1828         std::string.
1829         * source-cache.c (source_cache::extract_lines): Handle case where
1830         first_pos==npos.  Return std::string.
1831         (source_cache::get_source_lines): Update.
1832
1833 2019-03-14  Tom Tromey  <tromey@adacore.com>
1834
1835         * NEWS: Add item for "style sources" commands.
1836         * source-cache.c (source_cache::get_source_lines): Check
1837         source_styling.
1838         * cli/cli-style.c (source_styling): New global.
1839         (_initialize_cli_style): Add "style sources" commands.
1840         (show_style_sources): New function.
1841         * cli/cli-style.h (source_styling): Declare.
1842
1843 2019-03-14  Pedro Alves  <palves@redhat.com>
1844             Tom Tromey  <tromey@adacore.com>
1845
1846         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1847         * tui/tui-winsource.c (tui_refill_source_window): New function,
1848         from...
1849         (tui_horizontal_source_scroll): ... here.  Move some logic.
1850         * cli/cli-style.c (set_style_enabled): Notify new observable.
1851         * tui/tui-hooks.c (tui_redisplay_source): New function.
1852         (tui_attach_detach_observers): Attach or detach
1853         tui_redisplay_source.
1854         * observable.h (source_styling_changed): New observable.
1855         * observable.c: Define source_styling_changed observable.
1856
1857 2019-03-13  Tom Tromey  <tromey@adacore.com>
1858
1859         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1860         (i386_gnu_nat_target::store_registers): Update.
1861         * target-debug.h (target_debug_print_std_string): New macro.
1862         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1863         * windows-tdep.c (display_one_tib): Update.
1864         * tui/tui-stack.c (tui_make_status_line): Update.
1865         * top.c (print_inferior_quit_action): Update.
1866         * thread.c (thr_try_catch_cmd): Update.
1867         (add_thread_with_info): Update.
1868         (thread_target_id_str): Update.
1869         (thr_try_catch_cmd): Update.
1870         (thread_command): Update.
1871         (thread_find_command): Update.
1872         * record-btrace.c (record_btrace_target::info_record)
1873         (record_btrace_resume_thread, record_btrace_target::resume)
1874         (record_btrace_cancel_resume, record_btrace_step_thread)
1875         (record_btrace_target::wait, record_btrace_target::wait)
1876         (record_btrace_target::wait, record_btrace_target::stop): Update.
1877         * progspace.c (print_program_space): Update.
1878         * process-stratum-target.c
1879         (process_stratum_target::thread_address_space): Update.
1880         * linux-fork.c (linux_fork_mourn_inferior)
1881         (detach_checkpoint_command, info_checkpoints_command)
1882         (linux_fork_context): Update.
1883         (linux_fork_detach): Update.
1884         (class scoped_switch_fork_info): Update.
1885         (delete_checkpoint_command): Update.
1886         * infrun.c (follow_fork_inferior): Update.
1887         (follow_fork_inferior): Update.
1888         (proceed_after_vfork_done): Update.
1889         (handle_vfork_child_exec_or_exit): Update.
1890         (follow_exec): Update.
1891         (displaced_step_prepare_throw): Update.
1892         (displaced_step_restore): Update.
1893         (start_step_over): Update.
1894         (resume_1): Update.
1895         (clear_proceed_status_thread): Update.
1896         (proceed): Update.
1897         (print_target_wait_results): Update.
1898         (do_target_wait): Update.
1899         (context_switch): Update.
1900         (stop_all_threads): Update.
1901         (restart_threads): Update.
1902         (finish_step_over): Update.
1903         (handle_signal_stop): Update.
1904         (switch_back_to_stepped_thread): Update.
1905         (keep_going_pass_signal): Update.
1906         (print_exited_reason): Update.
1907         (normal_stop): Update.
1908         * inferior.c (inferior_pid_to_str): Change return type.
1909         (print_selected_inferior): Update.
1910         (add_inferior): Update.
1911         (detach_inferior): Update.
1912         * dummy-frame.c (fprint_dummy_frames): Update.
1913         * dcache.c (dcache_info_1): Update.
1914         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1915         (btrace_fetch, btrace_clear): Update.
1916         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1917         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1918         type.
1919         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1920         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1921         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1922         * gdbarch.c, gdbarch.h: Rebuild.
1923         * gdbarch.sh (core_pid_to_str): Change return type.
1924         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1925         return type.
1926         (windows_nat_target::pid_to_str): Change return type.
1927         (windows_delete_thread): Update.
1928         (windows_nat_target::attach): Update.
1929         (windows_nat_target::files_info): Update.
1930         * target-delegates.c: Rebuild.
1931         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1932         return type.
1933         (sol_thread_target::pid_to_str): Change return type.
1934         * remote.c (class remote_target) <pid_to_str>: Change return
1935         type.
1936         (remote_target::pid_to_str): Change return type.
1937         (extended_remote_target::attach, remote_target::remote_stop_ns)
1938         (remote_target::remote_notif_remove_queued_reply)
1939         (remote_target::push_stop_reply, remote_target::disable_btrace):
1940         Update.
1941         (extended_remote_target::attach): Update.
1942         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1943         type.
1944         (gdbsim_target::pid_to_str): Change return type.
1945         * ravenscar-thread.c (struct ravenscar_thread_target)
1946         <pid_to_str>: Change return type.
1947         (ravenscar_thread_target::pid_to_str): Change return type.
1948         * procfs.c (class procfs_target) <pid_to_str>: Change return
1949         type.
1950         (procfs_target::pid_to_str): Change return type.
1951         (procfs_target::attach): Update.
1952         (procfs_target::detach): Update.
1953         (procfs_target::fetch_registers): Update.
1954         (procfs_target::store_registers): Update.
1955         (procfs_target::wait): Update.
1956         (procfs_target::files_info): Update.
1957         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1958         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1959         return type.
1960         (nto_procfs_target::pid_to_str): Change return type.
1961         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1962         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1963         return type.
1964         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1965         (exit_lwp): Update.
1966         (attach_proc_task_lwp_callback, get_detach_signal)
1967         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1968         (linux_nat_target::resume, wait_lwp, stop_callback)
1969         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1970         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1971         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1972         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1973         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1974         type.
1975         (inf_ptrace_target::attach): Update.
1976         (inf_ptrace_target::files_info): Update.
1977         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1978         type.
1979         (go32_nat_target::pid_to_str): Change return type.
1980         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1981         (gnu_nat_target::wait): Update.
1982         (gnu_nat_target::wait): Update.
1983         (gnu_nat_target::resume): Update.
1984         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1985         (fbsd_nat_target::wait): Update.
1986         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1987         type.
1988         (darwin_nat_target::attach): Update.
1989         * corelow.c (class core_target) <pid_to_str>: Change return type.
1990         (core_target::pid_to_str): Change return type.
1991         * target.c (normal_pid_to_str): Change return type.
1992         (default_pid_to_str): Likewise.
1993         (target_pid_to_str): Change return type.
1994         (target_translate_tls_address): Update.
1995         (target_announce_detach): Update.
1996         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1997         return type.
1998         (bsd_uthread_target::pid_to_str): Change return type.
1999         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2000         type.
2001         (bsd_kvm_target::pid_to_str): Change return type.
2002         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2003         return type.
2004         (aix_thread_target::pid_to_str): Change return type.
2005         * target.h (struct target_ops) <pid_to_str>: Change return type.
2006         (target_pid_to_str, normal_pid_to_str): Likewise.
2007         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2008         type.
2009         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2010         type.
2011         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2012         return type.
2013         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2014         type.
2015         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2016         type.
2017         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2018         return type.
2019
2020 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2021
2022         * NEWS: Mention that the new default MI version is 3.  Mention
2023         changes to the output of commands and events that deal with
2024         multi-location breakpoints.
2025         * breakpoint.c: Include "mi/mi-out.h".
2026         (print_one_breakpoint): Change output syntax if using MI version
2027         >= 3.
2028         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2029         New.
2030         (mi_multi_location_breakpoint_output_fixed): New.
2031         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2032         (mi_cmd_fix_multi_location_breakpoint_output): New.
2033         (mi_multi_location_breakpoint_output_fixed): New.
2034         * mi/mi-cmds.c (mi_cmds): Register command
2035         -fix-multi-location-breakpoint-output.
2036         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2037         interpreter "mi".
2038
2039 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2040
2041         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2042         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2043         instantiate mi_ui_out based on interpreter name.
2044         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2045         * mi/mi-main.c (mi_load_progress): Likewise.
2046
2047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2048
2049         * NEWS: Combine separate "New targets" sections for 8.3.
2050
2051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2052
2053         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2054         (ppcfbsd_init_abi): Install gdbarch
2055         "fetch_tls_load_module_address" and "get_thread_local_address"
2056         methods.
2057
2058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2059
2060         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2061         (riscv_fbsd_init_abi): Install gdbarch
2062         "fetch_tls_load_module_address" and "get_thread_local_address"
2063         methods.
2064
2065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2066
2067         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2068         (i386fbsd_init_abi): Install gdbarch
2069         "fetch_tls_load_module_address" and "get_thread_local_address"
2070         methods.
2071
2072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2073
2074         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2075         (amd64fbsd_init_abi): Install gdbarch
2076         "fetch_tls_load_module_address" and "get_thread_local_address"
2077         methods.
2078
2079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2080
2081         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2082         (struct fbsd_pspace_data): New type.
2083         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2084         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2085         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2086         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2087         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2088
2089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2090
2091         * gdbtypes.c (lookup_struct_elt): New function.
2092         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2093         * gdbtypes.h (struct struct_elt): New type.
2094         (lookup_struct_elt): New prototype.
2095
2096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2097
2098         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2099         remove disabled code block.
2100
2101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2102
2103         * gdbarch.sh (get_thread_local_address): New method.
2104         * gdbarch.h, gdbarch.c: Regenerate.
2105         * target.c (target_translate_tls_address): Use
2106         gdbarch_get_thread_local_address if present instead of
2107         target::get_thread_local_address.
2108
2109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2110
2111         * target.h (target::get_thread_local_address): Update comment.
2112
2113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2114
2115         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2116         objfile->separate_debug_objfile_backlink if not NULL.
2117
2118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2119
2120         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2121         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2122         (amd64bsd_store_inferior_registers): Likewise.
2123         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2124         Enable segment base registers.
2125         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2126         PT_GETFSBASE and PT_GETGSBASE.
2127         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2128         PT_SETGSBASE.
2129         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2130         segment base registers.
2131         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2132
2133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2134
2135         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2136         Update calls to i386_target_description to add 'segments'
2137         parameter.
2138         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2139         add segment base registers.
2140         * arch/i386.c (i386_create_target_description): Add 'segments'
2141         parameter to enable segment base registers.
2142         * arch/i386.h (i386_create_target_description): Likewise.
2143         * features/i386/32bit-segments.xml: New file.
2144         * features/i386/32bit-segments.c: Generate.
2145         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2146         call to i386_target_description to add 'segments' parameter.
2147         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2148         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2149         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2150         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2151         if feature is present.
2152         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2153         Add 'segments' parameter to call to i386_target_description.
2154         (i386_target_description): Add 'segments' parameter to enable
2155         segment base registers.
2156         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2157         to call to i386_target_description.
2158         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2159         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2160         Define I386_NUM_REGS.
2161         (i386_target_description): Add 'segments' parameter to enable
2162         segment base registers.
2163
2164 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2165
2166         PR/24325
2167         * source-cache.c: #undef open and close, to avoid unresolved
2168         externals during linking.
2169
2170 2019-03-12  Tom Tromey  <tromey@adacore.com>
2171
2172         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2173         const.  Add initializers.
2174         (_initialize_remote): Don't initialize ptid globals.
2175
2176 2019-03-12  Pedro Alves  <palves@redhat.com>
2177
2178         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2179
2180 2019-03-12  Pedro Alves  <palves@redhat.com>
2181
2182         * cp-name-parser.y (main): Remove unused 'len' variable.
2183
2184 2019-03-12  Tom Tromey  <tromey@adacore.com>
2185
2186         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2187         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2188
2189 2019-03-12  Tom Tromey  <tromey@adacore.com>
2190
2191         * linux-nat.c (iterate_over_lwps): Update.
2192         (stop_callback): Remove parameter.
2193         (stop_wait_callback, detach_callback, resume_set_callback)
2194         (select_singlestep_lwp_callback, set_ignore_sigint)
2195         (status_callback, resumed_callback, resume_clear_callback)
2196         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2197         data parameter.
2198         (linux_nat_target::detach, linux_nat_target::resume)
2199         (linux_stop_and_wait_all_lwps, select_event_lwp)
2200         (linux_nat_filter_event, linux_nat_wait_1)
2201         (linux_nat_target::kill, linux_nat_target::stop)
2202         (linux_nat_target::stop): Update.
2203         (linux_nat_resume_callback): Change type.
2204         (resume_stopped_resumed_lwps, count_events_callback)
2205         (select_event_lwp_callback): Likewise.
2206         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2207         * arm-linux-nat.c (struct update_registers_data): Remove.
2208         (update_registers_callback): Change type.
2209         (arm_linux_insert_hw_breakpoint1): Update.
2210         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2211         parameter.
2212         (x86_linux_dr_set_addr): Update.
2213         (x86_linux_dr_set_control): Update.
2214         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2215         (iterate_over_lwps): Use gdb::function_view.
2216         * nat/aarch64-linux-hw-point.c (struct
2217         aarch64_dr_update_callback_param): Remove.
2218         (debug_reg_change_callback): Change type.
2219         (aarch64_notify_debug_reg_change): Update.
2220         * s390-linux-nat.c (s390_refresh_per_info): Update.
2221
2222 2019-03-11  Tom Tromey  <tromey@adacore.com>
2223
2224         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2225         redundant assignment to "this_cu".
2226
2227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2228
2229         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2230
2231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2232
2233         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2234         from...
2235         (rank_one_type): ... this.
2236
2237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2238
2239         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2240         from...
2241         (rank_one_type): ... this.
2242
2243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2244
2245         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2246         from...
2247         (rank_one_type): ... this.
2248
2249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2250
2251         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2252         from...
2253         (rank_one_type): ... this.
2254
2255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2256
2257         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2258         from...
2259         (rank_one_type): ... this.
2260
2261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2262
2263         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2264         from...
2265         (rank_one_type): ... this.
2266
2267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2268
2269         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2270         from...
2271         (rank_one_type): ... this.
2272
2273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2274
2275         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2276         from...
2277         (rank_one_type): ... this.
2278
2279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2280
2281         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2282         from...
2283         (rank_one_type): ... this.
2284
2285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2286
2287         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2288         from...
2289         (rank_one_type): ... this.
2290
2291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2292
2293         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2294         from...
2295         (rank_one_type): ... this.
2296
2297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2298
2299         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2300         from...
2301         (rank_one_type): ... this.
2302
2303 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2304
2305         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2306         inferior-events' shows the example events.
2307
2308 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2309
2310         Support styling on native MS-Windows console
2311
2312         PR/24315
2313         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2314         on MS-Windows if $TERM is not defined.
2315
2316         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2317
2318         * posix-hdep.c (gdb_console_fputs):
2319         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2320         functions.
2321         * ui-file.h (gdb_console_fputs): Add prototype.
2322
2323         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2324         back to fputs only if the former returns zero.
2325
2326 2019-03-07  Tom Tromey  <tom@tromey.com>
2327
2328         * symmisc.c (print_symbol_bcache_statistics): Update.
2329         (print_objfile_statistics): Update.
2330         * symfile.c (allocate_symtab): Update.
2331         * stabsread.c: Don't include bcache.h.
2332         * psymtab.h (struct psymbol_bcache): Don't declare.
2333         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2334         (psymbol_bcache_init, psymbol_bcache_free)
2335         (psymbol_bcache_get_bcache): Don't declare.
2336         * psymtab.c (struct psymbol_bcache): Remove.
2337         (psymtab_storage::psymtab_storage): Update.
2338         (psymtab_storage::~psymtab_storage): Update.
2339         (psymbol_bcache_init, psymbol_bcache_free)
2340         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2341         (add_psymbol_to_bcache): Update.
2342         (allocate_psymtab): Update.
2343         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2344         macro_cache>: No longer pointers.
2345         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2346         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2347         * macrotab.c (macro_bcache): Update.
2348         * macroexp.c: Don't include bcache.h.
2349         * gdbtypes.c (check_types_worklist): Update.
2350         (types_deeply_equal): Remove TRY/CATCH.  Update.
2351         * elfread.c (elf_symtab_read): Update.
2352         * dwarf2read.c: Don't include bcache.h.
2353         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2354         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2355         (print_bcache_statistics, bcache_memory_used): Don't declare.
2356         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2357         methods.  Rename all data members.
2358         * bcache.c (struct bcache): Move to bcache.h.
2359         (bcache::expand_hash_table): Rename from expand_hash_table.
2360         (bcache): Remove.
2361         (bcache::insert): Rename from bcache_full.
2362         (bcache::compare): Rename from bcache_compare.
2363         (bcache_xmalloc): Remove.
2364         (bcache::~bcache): Rename from bcache_xfree.
2365         (bcache::print_statistics): Rename from print_bcache_statistics.
2366         (bcache::memory_used): Rename from bcache_memory_used.
2367
2368 2019-03-07  Pedro Alves  <palves@redhat.com>
2369
2370         * infrun.c (normal_stop): Also check for
2371         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2372
2373 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2374
2375         * f-lang.c (value_from_host_double): Moved to...
2376         * value.c (value_from_host_double): ...here.
2377         * value.h (value_from_host_double): Declare.
2378         * guile/scm-math.c (vlscm_convert_typed_number): Use
2379         value_from_host_double.
2380         (vlscm_convert_number): Likewise.
2381         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2382         * python/py-value.c (convert_value_from_python): Likewise.
2383
2384 2019-03-06  Tom Tromey  <tom@tromey.com>
2385
2386         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2387
2388 2019-03-06  Tom Tromey  <tom@tromey.com>
2389
2390         * utils.h (free_current_contents): Don't declare.
2391         * utils.c (free_current_contents): Remove.
2392
2393 2019-03-06  Tom Tromey  <tom@tromey.com>
2394
2395         * top.c (quit_force): Update.
2396         * main.c (captured_command_loop): Update.
2397         * common/new-op.c (operator new): Update.
2398         * common/common-exceptions.c (struct catcher)
2399         <save_cleanup_chain>: Remove member.
2400         (exceptions_state_mc_init): Update.
2401         (exception_try_scope_entry): Return nullptr.
2402         (exception_try_scope_exit, exception_rethrow)
2403         (throw_exception_sjlj, throw_exception_cxx): Update.
2404         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2405         (all_cleanups, do_cleanups, discard_cleanups)
2406         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2407         (restore_cleanups, restore_final_cleanups): Don't declare.
2408         (do_final_cleanups): Remove parameter.
2409         * common/cleanups.c (cleanup_chain, make_cleanup)
2410         (make_cleanup_dtor, all_cleanups, do_cleanups)
2411         (discard_my_cleanups, discard_cleanups)
2412         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2413         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2414         (null_cleanup): Remove.
2415         (do_final_cleanups): Remove parameter.
2416
2417 2019-03-06  Tom Tromey  <tom@tromey.com>
2418
2419         * remote.c (remote_target::remote_parse_stop_reply): Use
2420         unique_xmalloc_ptr.
2421
2422 2019-03-06  Tom Tromey  <tom@tromey.com>
2423
2424         * stabsread.c (struct stabs_field_info): Rename from field_info.
2425         <list, fnlist>: Add initializers.
2426         <obstack>: New member.
2427         (read_member_functions, read_struct_fields, read_baseclasses):
2428         Allocate on obstack.  Don't use cleanups.
2429         (read_one_struct_field, read_member_functions, read_struct_fields)
2430         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2431         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2432         (read_struct_type): Update.
2433
2434 2019-03-06  Tom Tromey  <tom@tromey.com>
2435
2436         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2437         * common/filestuff.h (make_cleanup_close): Don't declare.
2438         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2439         Remove.
2440
2441 2019-03-06  Tom Tromey  <tom@tromey.com>
2442
2443         * solib-aix.c: Use make_scope_exit.
2444
2445 2019-03-06  Tom Tromey  <tom@tromey.com>
2446
2447         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2448         Use make_scope_exit.
2449
2450 2019-03-06  Tom Tromey  <tom@tromey.com>
2451
2452         * solib-svr4.c (disable_probes_interface): Remove parameter.
2453         (svr4_handle_solib_event): Use make_scope_exit.
2454
2455 2019-03-06  Tom Tromey  <tom@tromey.com>
2456
2457         * remote.c (struct stop_reply_deleter): Remove.
2458         (stop_reply_up): Update.
2459         (struct stop_reply): Derive from notif_event.  Don't typedef.
2460         <regcache>: Now a std::vector.
2461         (stop_reply_xfree): Remove.
2462         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2463         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2464         (remote_target::discard_pending_stop_replies): Use delete.
2465         (remote_target::remote_parse_stop_reply): Update.
2466         (remote_target::process_stop_reply): Update.
2467         * remote-notif.h (struct notif_event): Add virtual destructor.
2468         Remove "dtr" member.
2469         (struct notif_client) <alloc_event>: Return a unique_ptr.
2470         (notif_event_xfree): Don't declare.
2471         (notif_event_up): New typedef.
2472         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2473         (notif_event_xfree, do_notif_event_xfree): Remove.
2474         (remote_notif_state_xfree): Update.
2475
2476 2019-03-06  Tom Tromey  <tom@tromey.com>
2477
2478         * infrun.c (displaced_step_clear_cleanup): Now a
2479         forward_scope_exit type.
2480         (displaced_step_prepare_throw): Update.
2481         (displaced_step_fixup): Update.
2482
2483 2019-03-06  Tom Tromey  <tom@tromey.com>
2484
2485         * inferior.h (class inferior): Update comment.
2486         * gdbthread.h (class thread_info): Update comment.
2487
2488 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2489             Tom Tromey  <tom@tromey.com>
2490
2491         * stabsread.h (struct stab_section_list): Remove.
2492         (coffstab_build_psymtabs): Update.
2493         * dbxread.c (symbuf_sections): Now a std::vector.
2494         (sect_idx): New global.
2495         (fill_symbuf): Update.
2496         (coffstab_build_psymtabs): Change type of stabsects parameter.
2497         Update.
2498         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2499         std::vector.
2500         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2501         (coff_locate_sections): Update.
2502         (coff_symfile_read): Remove cleanups.  Update.
2503         (init_stringtab): Add storage parameter.
2504         (free_stringtab, free_stringtab_cleanup): Remove.
2505         (init_lineno): Add storage parameter.
2506         (free_linetab, free_linetab_cleanup): Remove.
2507
2508 2019-03-06  Pedro Alves  <palves@redhat.com>
2509
2510         * linux-fork.c (fork_info::clobber_regs): Delete.
2511         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2512         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2513         comment.  Adjust.
2514         (scoped_switch_fork_info::scoped_switch_fork_info)
2515         (checkpoint_command, linux_fork_context): Adjust
2516         fork_save_infrun_state calls.
2517
2518 2019-03-06  Pedro Alves  <palves@redhat.com>
2519
2520         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2521         (inf_has_multiple_threads): Return 'bool' and rewrite using
2522         inferior_info::threads().
2523
2524 2019-03-06  Pedro Alves  <palves@redhat.com>
2525
2526         * linux-fork.c: Include <list>.
2527         (fork_list): Now a std::list instance.
2528         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2529         (forks_exist_p, find_last_fork): Adjust.
2530         (new_fork): Delete.
2531         (one_fork_p): New.
2532         (add_fork): Adjust.
2533         (free_fork): Delete, folded into fork_info::~fork_info().
2534         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2535         Adjust.
2536         (init_fork_list): Delete.
2537         (linux_fork_killall, linux_fork_mourn_inferior)
2538         (linux_fork_detach, info_checkpoints_command): Adjust.
2539         (_initialize_linux_fork): No longer call init_fork_list.
2540
2541 2019-03-06  Pedro Alves  <palves@redhat.com>
2542
2543         * linux-fork.c (new_fork): New, split out of ...
2544         (add_fork): ... this.  Return void.  Move "first fork" special
2545         case from here, to ...
2546         (checkpoint_command): ... here.
2547         * linux-linux.h (add_fork): Return void.
2548
2549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2552
2553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2554             Chris January  <chris.january@arm.com>
2555             David Lecomber  <david.lecomber@arm.com>
2556
2557         * f-exp.y: New token, UNOP_INTRINSIC.
2558         (exp): New pattern using UNOP_INTRINSIC token.
2559         (f77_keywords): Add 'abs' keyword.
2560         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2561         (value_from_host_double): New function.
2562         (evaluate_subexp_f): Support UNOP_ABS.
2563
2564 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2567         types.
2568
2569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2572         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2573         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2574
2575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2578
2579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2580             Chris January  <chris.january@arm.com>
2581
2582         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2583         * f-exp.y: Define 'KIND' token.
2584         (exp): New pattern for KIND expressions.
2585         (ptype): Handle types with a kind extension.
2586         (direct_abs_decl): Extend to spot kind extensions.
2587         (f77_keywords): Add 'kind' to the list.
2588         (push_kind_type): New function.
2589         (convert_to_kind_type): New function.
2590         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2591         * parse.c (operator_length_standard): Likewise.
2592         * parser-defs.h (enum type_pieces): Add tp_kind.
2593         * std-operator.def: Add UNOP_KIND.
2594
2595 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2596
2597         * f-exp.y (f_parse): Set yydebug.
2598
2599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * f-lang.c (evaluate_subexp_f): New function.
2602         (exp_descriptor_f): New global.
2603         (f_language_defn): Use exp_descriptor_f instead of
2604         exp_descriptor_standard.
2605
2606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * f-exp.y (struct token): Add comments.
2609         (dot_ops): Remove uppercase versions and the end marker.
2610         (f77_keywords): Likewise.
2611         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2612         entries in the dot_ops array are case insensitive, and use
2613         strncasecmp to compare strings.  Also some whitespace cleanup in
2614         this area.  Similar for the f77_keywords array, except entries in
2615         this list might be case sensitive.
2616
2617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2618
2619         * f-exp.y (struct f77_boolean_val): Add comments.
2620         (boolean_values): Remove uppercase versions, and end marker.
2621         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2622         and use strncasecmp to achieve case insensitivity.  Additionally,
2623         perform whitespace cleanup around this code.
2624
2625 2019-03-06  Tom Tromey  <tromey@adacore.com>
2626
2627         * remote-sim.c (gdbsim_target_open): Use result of
2628         gdb_argv::release.
2629
2630 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2631         Dirk Schubert  <dirk.schubert@arm.com>
2632         Chris January  <chris.january@arm.com>
2633
2634         * eval.c (evaluate_subexp_standard): Call Fortran argument
2635         wrapping logic.
2636         * f-lang.c (struct value): A value which can be passed into a
2637         Fortran function call.
2638         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2639         where appropriate.
2640         (struct type): Value ready for a Fortran function call.
2641         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2642         is needed.
2643         * f-lang.h (fortran_argument_convert): Declaration.
2644         (fortran_preserve_arg_pointer): Declaration.
2645         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2646
2647 2019-03-05  Tom Tromey  <tromey@adacore.com>
2648
2649         * python/py-prettyprint.c (print_string_repr): Remove #if.
2650         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2651
2652 2019-03-05  Tom Tromey  <tromey@adacore.com>
2653
2654         * target.c (the_dummy_target): Move later.  Change type to
2655         "dummy_target".
2656         (initialize_targets): Don't initialize the_dummy_target.
2657
2658 2019-03-05  Tom Tromey  <tromey@adacore.com>
2659
2660         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2661         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2662
2663 2019-03-05  Tom Tromey  <tromey@adacore.com>
2664
2665         * windows-nat.c (windows_nat_target::attach)
2666         (windows_nat_target::detach): Don't call gdb_flush.
2667         * valprint.c (generic_val_print, val_print, val_print_string):
2668         Don't call gdb_flush.
2669         * utils.c (defaulted_query): Don't call gdb_flush.
2670         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2671         * target.c (target_announce_detach): Don't call gdb_flush.
2672         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2673         * remote.c (extended_remote_target::attach): Don't call
2674         gdb_flush.
2675         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2676         * printcmd.c (do_examine): Don't call gdb_flush.
2677         (info_display_command): Don't call gdb_flush.
2678         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2679         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2680         * memattr.c (info_mem_command): Don't call gdb_flush.
2681         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2682         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2683         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2684         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2685         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2686         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2687         (gnu_nat_target::detach): Don't call gdb_flush.
2688         * f-valprint.c (f_val_print): Don't call gdb_flush.
2689         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2690         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2691         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2692         gdb_flush.
2693         * c-valprint.c (c_val_print): Don't call gdb_flush.
2694         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2695
2696 2019-03-05  Tom Tromey  <tromey@adacore.com>
2697
2698         * varobj.c (update_dynamic_varobj_children): Update.
2699         (install_default_visualizer): Use reset, not release.
2700         * value.c (set_internalvar): Update.
2701         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2702         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2703         ATTRIBUTE_UNUSED_RESULT.
2704
2705 2019-03-05  Tom Tromey  <tromey@adacore.com>
2706
2707         * remote.c (class scoped_remote_fd) <release>: Add
2708         ATTRIBUTE_UNUSED_RESULT.
2709
2710 2019-03-05  Tom Tromey  <tromey@adacore.com>
2711
2712         * macroexp.c (struct macro_buffer) <release>: Add
2713         ATTRIBUTE_UNUSED_RESULT.
2714
2715 2019-03-05  Tom Tromey  <tromey@adacore.com>
2716
2717         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2718         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2719         ATTRIBUTE_UNUSED_RESULT.
2720
2721 2019-03-05  Tom Tromey  <tromey@adacore.com>
2722
2723         * common/scoped_fd.h (class scoped_fd) <release>: Add
2724         ATTRIBUTE_UNUSED_RESULT.
2725
2726 2019-03-05  Tom Tromey  <tromey@adacore.com>
2727
2728         * parser-defs.h (struct parser_state) <release>: Add
2729         ATTRIBUTE_UNUSED_RESULT.
2730
2731 2019-03-05  Tom Tromey  <tromey@adacore.com>
2732
2733         * utils.h (class gdb_argv) <release>: Add
2734         ATTRIBUTE_UNUSED_RESULT.
2735         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2736
2737 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2738
2739         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2740         for-loop range, to avoid compiler warnings.
2741
2742         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2743         avoid compiler warnings about unused variables.
2744
2745         * NEWS: Mention end of support for native debugging on MS-Windows
2746         before XP.
2747
2748         PR gdb/24292
2749         * common/netstuff.c:
2750         * gdbserver/gdbreplay.c
2751         * gdbserver/remote-utils.c:
2752         * ser-tcp.c:
2753         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2754         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2755         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2756         'getaddrinfo' and 'freeaddrinfo' were not available before
2757         Windows XP, and mingw.org's MinGW headers by default define
2758         _WIN32_WINNT to 0x500.
2759
2760 2019-03-01  Gary Benson <gbenson@redhat.com>
2761
2762         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2763
2764 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2765             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2766
2767         PR gdb/8527
2768         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2769         set_sigint_trap, clear_sigint_trap.
2770
2771 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2772
2773         * target.c (target_detach): Clear the regcache and the
2774         frame cache.
2775
2776 2019-02-27  Pedro Alves  <palves@redhat.com>
2777
2778         * utils.c (set_screen_size): When we cap the height/width sizes,
2779         tweak the corresponding command variable to show "unlimited":
2780
2781 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2782             Pedro Alves  <palves@redhat.com>
2783
2784         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2785         before calling rl_set_screen_size.
2786
2787 2019-02-27  Tom Tromey  <tromey@adacore.com>
2788
2789         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2790         define.
2791         * python/py-value.c: Remove Python 2.4 workaround.
2792         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2793         workaround.
2794         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2795         Python 2.4 workaround.
2796         * python/python-internal.h: Remove Python 2.4 comment.
2797         (Py_ssize_t): Don't define.
2798         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2799         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2800         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2801         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2802         * python/python.c (do_start_initialization): Remove Python 2.4
2803         workaround.
2804         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2805         (print_children): Remove Python 2.4 workaround.
2806         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2807         workaround.
2808         (CHARBUFFERPROC_NAME): Remove.
2809         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2810         Python 2.4 workaround.
2811
2812 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2813
2814         * NEWS: Note minimum Python version.
2815
2816 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2817
2818         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2819         code from these functions.  Remove corresponding ifdefs.  Use
2820         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2821         Remove gotos and target of gotos.
2822         (infpy_search_memory): Likewise.
2823
2824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2827         (hppa_gdbarch_init): Don't register deleted functions with
2828         gdbarch.
2829
2830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2833         (h8300_unwind_sp): Delete.
2834         (h8300_dummy_id): Delete.
2835         (h8300_gdbarch_init): Don't register deleted functions with
2836         gdbarch.
2837
2838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2841         (ft32_unwind_pc): Delete.
2842         (ft32_unwind_sp): Delete.
2843         (ft32_gdbarch_init): Don't register deleted functions with
2844         gdbarch.
2845
2846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2849         (frv_unwind_pc): Delete.
2850         (frv_unwind_sp): Delete.
2851         (frv_gdbarch_init): Don't register deleted functions with
2852         gdbarch.
2853
2854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2857         (riscv_unwind_pc): Delete.
2858         (riscv_unwind_sp): Delete.
2859         (riscv_gdbarch_init): Don't register deleted functions with
2860         gdbarch.
2861
2862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2865         (csky_unwind_pc): Delete.
2866         (csky_unwind_sp): Delete.
2867         (csky_gdbarch_init): Don't register deleted functions with
2868         gdbarch.
2869
2870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2871
2872         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2873         (cris_unwind_pc): Delete.
2874         (cris_unwind_sp): Delete.
2875         (cris_gdbarch_init): Don't register deleted functions with
2876         gdbarch.
2877
2878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2881         (bfin_unwind_pc): Delete.
2882         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2883
2884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2887         (arm_unwind_pc): Delete.
2888         (arm_unwind_sp): Delete.
2889         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2890
2891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2894         (arc_unwind_pc): Delete.
2895         (arc_unwind_sp): Delete.
2896         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2897
2898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2899
2900         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2901         (alpha_unwind_pc): Delete.
2902         (alpha_gdbarch_init): Don't register deleted functions with
2903         gdbarch.
2904
2905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2906
2907         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2908         (aarch64_unwind_pc): Delete.
2909         (aarch64_unwind_sp): Delete.
2910         (aarch64_gdbarch_init): Don't register deleted functions with
2911         gdbarch.
2912
2913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * gdbtypes.c (type_align): Don't consider static members when
2916         computing structure alignment.
2917
2918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2921         return 0 for other types.
2922         * arch-utils.c (default_type_align): Always return 0.
2923         * gdbarch.h: Regenerate.
2924         * gdbarch.sh (type_align): Extend comment.
2925         * gdbtypes.c (type_align): Add additional comments, always call
2926         gdbarch_type_align before applying the default rules.
2927         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2928         generic code will then apply a suitable default.
2929         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2930         types, return 0 for other types.
2931
2932 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2933
2934         * NEWS: Create a new section for the next release branch.
2935         Rename the section of the current branch, now that it has
2936         been cut.
2937
2938 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2939
2940         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2941         * version.in: Bump version to 8.3.50.DATE-git.
2942
2943 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2944
2945         * aix-thread.c (ptid_cmp): Remove unused variable.
2946         (get_signaled_thread): Likewise.
2947         (store_regs_user_thread): Likewise.
2948         (store_regs_kernel_thread): Likewise.
2949         (fetch_regs_kernel_thread): Remove shadowed variable.
2950
2951 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2952
2953         * features/riscv/32bit-cpu.xml: Add register numbers.
2954         * features/riscv/32bit-fpu.c: Regenerate.
2955         * features/riscv/32bit-fpu.xml: Add register numbers.
2956         * features/riscv/64bit-cpu.xml: Add register numbers.
2957         * features/riscv/64bit-fpu.c: Regenerate.
2958         * features/riscv/64bit-fpu.xml: Add register numbers.
2959
2960 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2961
2962         * NEWS: Mention two argument form of gdb.Value constructor.
2963         * python/py-value.c (convert_buffer_and_type_to_value): New
2964         function.
2965         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2966         Add support for handling an optional second argument.  Call
2967         convert_buffer_and_type_to_value as appropriate.
2968         * python/python-internal.h (Py_buffer_deleter): New struct.
2969         (Py_buffer_up): New typedef.
2970
2971 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2972
2973         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2974         instead of releasing ownership.
2975
2976 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2977
2978         * dwarf2read.c (open_and_init_dwp_file): Call
2979         elf_numsections instead of bfd_count_sections to initialize
2980         dwp_file->num_sections.
2981
2982 2019-02-25  Tom Tromey  <tromey@adacore.com>
2983
2984         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2985
2986 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2987
2988         * gcore.in: Add '--readnever' option when invoking GDB.
2989
2990 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2991
2992         * MAINTAINERS: Update my email address.
2993
2994 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2995
2996         * build-id.c (build_id_to_debug_bfd_1): New function.
2997         (build_id_to_debug_bfd): Look for separate debug file in
2998         sysroot.
2999
3000 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * gdbarch.sh: Update the copyright year range that is placed into
3003         generated files.
3004
3005 2019-02-22  Keith Seitz  <keiths@redhat.com>
3006
3007         PR symtab/23853
3008         * linespec.c (create_sals_line_offset): Search for the default
3009         symtab's filename instead of its fullname.
3010
3011 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3012
3013         * NEWS: Update style defaults.
3014
3015 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3016
3017         * main.c (captured_main_1): Disable styling in batch mode.
3018
3019 2019-02-20  Tom Tromey  <tom@tromey.com>
3020
3021         * symtab.c (symtab_symbol_info): Fix typos.
3022
3023 2019-02-20  Tom Tromey  <tromey@adacore.com>
3024
3025         * findcmd.c (_initialize_mem_search): Use upper case for
3026         metasyntactic variables.
3027
3028 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3029
3030         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3031         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3032
3033 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3034
3035         * top.h (source_file_name): Change to std::string.
3036         * top.c (source_file_name): Likewise.
3037         (command_line_input): Adjust.
3038         * cli/cli-script.c (script_from_file): Adjust.
3039
3040 2019-02-19  Tom Tromey  <tromey@adacore.com>
3041
3042         * ravenscar-thread.c
3043         (ravenscar_thread_target::update_thread_list): Don't call
3044         ada_build_task_list.
3045         * ada-lang.h (ada_build_task_list): Don't declare.
3046         * ada-tasks.c (struct ada_tasks_inferior_data)
3047         <task_list_valid_p>: Now bool.
3048         (read_known_tasks, ada_task_list_changed)
3049         (ada_tasks_invalidate_inferior_data): Update.
3050         (read_known_tasks_array): Return bool.
3051         (read_known_tasks_list): Likewise.
3052         (read_known_tasks): Return void.
3053         (ada_build_task_list): Now static.
3054
3055 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3056
3057         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3058         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3059
3060 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3061
3062         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3063         variant for ada_tasks_pspace_data_handle and
3064         ada_tasks_inferior_data_handle.
3065         (ada_tasks_pspace_data_cleanup): New function.
3066         (ada_tasks_inferior_data_cleanup): New function.
3067
3068 2019-02-17  Tom Tromey  <tom@tromey.com>
3069
3070         * macrotab.h (macro_source_fullname): Return a std::string.
3071         * macrotab.c (macro_include, check_for_redefinition)
3072         (macro_undef, macro_lookup_definition, foreach_macro)
3073         (foreach_macro_in_scope): Update.
3074         (macro_source_fullname): Return a std::string.
3075         * macrocmd.c (show_pp_source_pos): Update.
3076
3077 2019-02-17  Tom Tromey  <tom@tromey.com>
3078
3079         * macrocmd.c (show_pp_source_pos): Style the file names.
3080
3081 2019-02-17  Tom Tromey  <tom@tromey.com>
3082
3083         PR tui/24197:
3084         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3085
3086 2019-02-17  Tom Tromey  <tom@tromey.com>
3087
3088         * ada-lang.c (user_select_syms): Use filtered printing.
3089         * utils.c (wrap_style): New global.
3090         (desired_style): Remove.
3091         (emit_style_escape): Add stream parameter.
3092         (set_output_style, reset_terminal_style, prompt_for_continue):
3093         Update.
3094         (flush_wrap_buffer): Only flush gdb_stdout.
3095         (wrap_here): Set wrap_style.
3096         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3097         treat escape sequences as a character.  Change when wrap buffer is
3098         flushed.
3099         (fputs_styled): Do not set the output style when the default is
3100         requested.
3101         * ui-style.h (struct ui_file_style) <is_default>: New method.
3102         * source.c (print_source_lines_base): Emit escape sequences in one
3103         piece.
3104
3105 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3106
3107         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3108         integers and enumeration types.
3109
3110 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3111
3112         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3113         instead of lookup_symbol_in_language
3114         (do_exact_match): New function.
3115         (ada_get_symbol_name_matcher): Return do_exact_match when
3116         doing a verbatim match.
3117
3118 2019-02-15  Tom Tromey  <tromey@adacore.com>
3119
3120         * ravenscar-thread.c (ravenscar_thread_target::resume)
3121         (ravenscar_thread_target::wait): Special case wildcard requests.
3122
3123 2019-02-15  Tom Tromey  <tromey@adacore.com>
3124
3125         * ravenscar-thread.c (base_ptid): Remove.
3126         (struct ravenscar_thread_target) <close>: New method.
3127         <m_base_ptid>: New member.
3128         <update_inferior_ptid, active_task, task_is_currently_active,
3129         runtime_initialized>: Declare methods.
3130         <ravenscar_thread_target>: Add constructor.
3131         (ravenscar_thread_target::task_is_currently_active)
3132         (ravenscar_thread_target::update_inferior_ptid)
3133         (ravenscar_runtime_initialized): Rename.  Now methods.
3134         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3135         (ravenscar_thread_target::update_thread_list): Update.
3136         (ravenscar_thread_target::active_task): Now method.
3137         (ravenscar_thread_target::store_registers)
3138         (ravenscar_thread_target::prepare_to_store)
3139         (ravenscar_thread_target::prepare_to_store)
3140         (ravenscar_thread_target::mourn_inferior): Update.
3141         (ravenscar_inferior_created): Use "new" to create target.
3142         (ravenscar_thread_target::get_ada_task_ptid): Update.
3143         (_initialize_ravenscar): Don't initialize base_ptid.
3144         (ravenscar_ops): Remove global.
3145
3146 2019-02-15  Tom Tromey  <tromey@adacore.com>
3147
3148         * target.h (push_target): Declare new overload.
3149         * target.c (push_target): New overload, taking an rvalue reference.
3150         * remote.c (remote_target::open_1): Use push_target overload.
3151         * corelow.c (core_target_open): Use push_target overload.
3152
3153 2019-02-15  Tom Tromey  <tromey@adacore.com>
3154
3155         * ravenscar-thread.c (is_ravenscar_task)
3156         (ravenscar_task_is_currently_active): Return bool.
3157         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3158         (_initialize_ravenscar): Remove "(void)".
3159         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3160         Return bool.
3161
3162 2019-02-15  Tom Tromey  <tromey@adacore.com>
3163
3164         * ravenscar-thread.c (ravenscar_runtime_initializer)
3165         (has_ravenscar_runtime, get_running_thread_id)
3166         (ravenscar_thread_target::resume): Fix indentation.
3167
3168 2019-02-15  Tom Tromey  <tromey@adacore.com>
3169
3170         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3171         from ravenscar_arch_ops.
3172         (sparc_ravenscar_ops::fetch_registers)
3173         (sparc_ravenscar_ops::store_registers): Now methods.
3174         (sparc_ravenscar_prepare_to_store): Remove.
3175         (sparc_ravenscar_ops): Redefine.
3176         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3177         methods and destructor.  Remove members.
3178         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3179         (ravenscar_thread_target::store_registers)
3180         (ravenscar_thread_target::prepare_to_store): Update.
3181         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3182         Remove.
3183         (struct ppc_ravenscar_powerpc_ops): Derive from
3184         ravenscar_arch_ops.
3185         (ppc_ravenscar_powerpc_ops::fetch_registers)
3186         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3187         (ppc_ravenscar_powerpc_ops): Redefine.
3188         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3189         (ppc_ravenscar_e500_ops::fetch_registers)
3190         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3191         (ppc_ravenscar_e500_ops): Redefine.
3192         * aarch64-ravenscar-thread.c
3193         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3194         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3195         (aarch64_ravenscar_fetch_registers)
3196         (aarch64_ravenscar_store_registers): Now methods.
3197         (aarch64_ravenscar_ops): Redefine.
3198
3199 2019-02-15  Tom Tromey  <tromey@adacore.com>
3200
3201         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3202         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3203         (ravenscar_thread_target::stopped_by_watchpoint)
3204         (ravenscar_thread_target::stopped_data_address)
3205         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3206
3207 2019-02-15  Tom Tromey  <tromey@adacore.com>
3208
3209         * ravenscar-thread.c: Fix some typos.
3210
3211 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3212             Tom Tromey  <tromey@adacore.com>
3213
3214         * ada-lang.c (ada_exception_sal): Change addr_string to a
3215         std::string.
3216         (create_ada_exception_catchpoint): Update.
3217
3218 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3219             Tom Tromey  <tromey@adacore.com>
3220
3221         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3222         (bp_location_ops): Remove.
3223         (base_breakpoint_allocate_location): Update.
3224         (free_bp_location): Update.
3225         * ada-lang.c (class ada_catchpoint_location)
3226         <ada_catchpoint_location>: Remove ops parameter.
3227         (ada_catchpoint_location_dtor): Remove.
3228         (ada_catchpoint_location_ops): Remove.
3229         (allocate_location_exception): Update.
3230         * breakpoint.h (struct bp_location_ops): Remove.
3231         (class bp_location) <bp_location>: Remove bp_location_ops
3232         parameter.
3233         <~bp_location>: Add destructor.
3234         <ops>: Remove.
3235
3236 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3237             Pedro Alves  <palves@redhat.com>
3238
3239         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3240         'PATH_MAX'.
3241
3242 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3243             Samuel Thibault  <samuel.thibault@gnu.org>
3244             Thomas Schwinge  <thomas@codesourcery.com>
3245
3246         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3247         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3248
3249 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3250
3251         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3252         (check_empty): Use "const char *".
3253
3254         * gnu-nat.c (gnu_nat_target::detach): Instead of
3255         'detach_inferior (pid)' call
3256         'detach_inferior (find_inferior_pid (pid))'.
3257
3258         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3259         'nat/fork-inferior.o'.
3260         * gnu-nat.c: #include "nat/fork-inferior.h".
3261
3262         * gnu-nat.c (gnu_nat_target::detach): Instead of
3263         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3264         * gnu-nat.h: #include "inf-child.h".
3265         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3266         'i386_gnu_nat_target::fetch_registers'.
3267         (gnu_store_registers): Rename/move to
3268         'i386_gnu_nat_target::store_registers'.
3269
3270         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3271         * gnu-nat.h (mach_thread_info): New function.
3272         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3273
3274         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3275
3276 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3277
3278         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3279
3280 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3281
3282         * windows-nat.c (windows_add_thread): Add new parameter
3283         "main_thread_p" with default value set to false.  Update
3284         function documentation as well as all callers.
3285         (windows_delete_thread): Likewise.
3286         (fake_create_process): Update call to windows_add_thread.
3287         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3288         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3289         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3290         call to windows_delete_thread.
3291
3292 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3293
3294         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3295
3296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3297
3298         * symfile.c (find_separate_debug_file): Use canonical path of
3299         sysroot with child_path instead of gdb_sysroot if it is valid.
3300
3301 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3302
3303         * symfile.c (find_separate_debug_file): Use child_path to
3304         determine if an object file is under a sysroot.
3305
3306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3307
3308         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3309         unittests/child-path-selftests.c.
3310         * common/pathstuff.c (child_path): New function.
3311         * common/pathstuff.h (child_path): New prototype.
3312         * unittests/child-path-selftests.c: New file.
3313
3314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3315
3316         * symfile.c (find_separate_debug_file): Look for separate debug
3317         files in debug directories under the sysroot.
3318
3319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3320
3321         * symtab.h (struct minimal_symbol data_p): New const method.
3322         (struct minimal_symbol text_p): Likewise.
3323         * symtab.c (output_source_filename): Use file name style
3324         to print file name.
3325         (print_symbol_info): Likewise.
3326         (print_msymbol_info): Use address style to print addresses.
3327         Use function name style to print executable text symbols.
3328         (expand_symtab_containing_pc): Use data_p.
3329         (find_pc_sect_compunit_symtab): Likewise.
3330
3331 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3332
3333         * breakpoint.c (describe_other_breakpoints): Use address style
3334         to print addresses.
3335         (say_where): Likewise.
3336
3337 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3338
3339         * ada-typeprint.c (print_func_type): Print function name
3340         style to print function name.
3341         * c-typeprint.c (c_print_type_1): Likewise.
3342
3343 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3344
3345         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3346         for execve.
3347
3348 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3349
3350         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3351         type_stack.
3352
3353 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3354
3355         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3356         TYPE_CODE_REF types.
3357
3358 2019-02-08  Jim Wilson  <jimw@sifive.com>
3359
3360         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3361         (riscv_linux_fregset): New.
3362         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3363
3364 2019-02-07  Tom Tromey  <tom@tromey.com>
3365
3366         * thread.c (thread_cancel_execution_command): Update.
3367         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3368         methods.
3369         (struct thread_fsm_ops): Remove.
3370         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3371         (thread_fsm_should_stop, thread_fsm_return_value)
3372         (thread_fsm_set_finished, thread_fsm_finished_p)
3373         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3374         Don't declare.
3375         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3376         * infrun.c (clear_proceed_status_thread)
3377         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3378         (print_stop_event): Update.
3379         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3380         Add constructor.
3381         (step_command_fsm_ops): Remove.
3382         (new_step_command_fsm): Remove.
3383         (step_1): Update.
3384         (step_command_fsm::should_stop): Rename from
3385         step_command_fsm_should_stop.
3386         (step_command_fsm::clean_up): Rename from
3387         step_command_fsm_clean_up.
3388         (step_command_fsm::do_async_reply_reason): Rename from
3389         step_command_fsm_async_reply_reason.
3390         (struct until_next_fsm): Inherit from thread_fsm.  Add
3391         constructor.
3392         (until_next_fsm_ops): Remove.
3393         (new_until_next_fsm): Remove.
3394         (until_next_fsm::should_stop): Rename from
3395         until_next_fsm_should_stop.
3396         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3397         (until_next_fsm::do_async_reply_reason): Rename from
3398         until_next_fsm_async_reply_reason.
3399         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3400         constructor.  Change type of breakpoint.
3401         (finish_command_fsm_ops): Remove.
3402         (new_finish_command_fsm): Remove.
3403         (finish_command_fsm::should_stop): Rename from
3404         finish_command_fsm_should_stop.
3405         (finish_command_fsm::clean_up): Rename from
3406         finish_command_fsm_clean_up.
3407         (finish_command_fsm::return_value): Rename from
3408         finish_command_fsm_return_value.
3409         (finish_command_fsm::do_async_reply_reason): Rename from
3410         finish_command_fsm_async_reply_reason.
3411         (finish_command): Update.
3412         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3413         Add constructor.
3414         (call_thread_fsm_ops): Remove.
3415         (call_thread_fsm::call_thread_fsm): Rename from
3416         new_call_thread_fsm.
3417         (call_thread_fsm::should_stop): Rename from
3418         call_thread_fsm_should_stop.
3419         (call_thread_fsm::should_notify_stop): Rename from
3420         call_thread_fsm_should_notify_stop.
3421         (run_inferior_call, call_function_by_hand_dummy): Update.
3422         * cli/cli-interp.c (should_print_stop_to_console): Update.
3423         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3424         Add constructor.  Change type of location_breakpoint,
3425         caller_breakpoint.
3426         (until_break_fsm_ops): Remove.
3427         (new_until_break_fsm): Remove.
3428         (until_break_fsm::should_stop): Rename from
3429         until_break_fsm_should_stop.
3430         (until_break_fsm::clean_up): Rename from
3431         until_break_fsm_clean_up.
3432         (until_break_fsm::do_async_reply_reason): Rename from
3433         until_break_fsm_async_reply_reason.
3434         (until_break_command): Update.
3435         * thread-fsm.c: Remove.
3436         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3437
3438 2019-02-07  Tom Tromey  <tom@tromey.com>
3439
3440         * yy-remap.h: Add include guard.
3441         * xtensa-tdep.h: Add include guard.
3442         * xcoffread.h: Rename include guard.
3443         * varobj-iter.h: Add include guard.
3444         * tui/tui.h: Rename include guard.
3445         * tui/tui-winsource.h: Rename include guard.
3446         * tui/tui-wingeneral.h: Rename include guard.
3447         * tui/tui-windata.h: Rename include guard.
3448         * tui/tui-win.h: Rename include guard.
3449         * tui/tui-stack.h: Rename include guard.
3450         * tui/tui-source.h: Rename include guard.
3451         * tui/tui-regs.h: Rename include guard.
3452         * tui/tui-out.h: Rename include guard.
3453         * tui/tui-layout.h: Rename include guard.
3454         * tui/tui-io.h: Rename include guard.
3455         * tui/tui-hooks.h: Rename include guard.
3456         * tui/tui-file.h: Rename include guard.
3457         * tui/tui-disasm.h: Rename include guard.
3458         * tui/tui-data.h: Rename include guard.
3459         * tui/tui-command.h: Rename include guard.
3460         * tic6x-tdep.h: Add include guard.
3461         * target/waitstatus.h: Rename include guard.
3462         * target/wait.h: Rename include guard.
3463         * target/target.h: Rename include guard.
3464         * target/resume.h: Rename include guard.
3465         * target-float.h: Rename include guard.
3466         * stabsread.h: Add include guard.
3467         * rs6000-tdep.h: Add include guard.
3468         * riscv-fbsd-tdep.h: Add include guard.
3469         * regformats/regdef.h: Rename include guard.
3470         * record.h: Rename include guard.
3471         * python/python.h: Rename include guard.
3472         * python/python-internal.h: Rename include guard.
3473         * python/py-stopevent.h: Rename include guard.
3474         * python/py-ref.h: Rename include guard.
3475         * python/py-record.h: Rename include guard.
3476         * python/py-record-full.h: Rename include guard.
3477         * python/py-record-btrace.h: Rename include guard.
3478         * python/py-instruction.h: Rename include guard.
3479         * python/py-events.h: Rename include guard.
3480         * python/py-event.h: Rename include guard.
3481         * procfs.h: Add include guard.
3482         * proc-utils.h: Add include guard.
3483         * p-lang.h: Add include guard.
3484         * or1k-tdep.h: Rename include guard.
3485         * observable.h: Rename include guard.
3486         * nto-tdep.h: Rename include guard.
3487         * nat/x86-linux.h: Rename include guard.
3488         * nat/x86-linux-dregs.h: Rename include guard.
3489         * nat/x86-gcc-cpuid.h: Add include guard.
3490         * nat/x86-dregs.h: Rename include guard.
3491         * nat/x86-cpuid.h: Rename include guard.
3492         * nat/ppc-linux.h: Rename include guard.
3493         * nat/mips-linux-watch.h: Rename include guard.
3494         * nat/linux-waitpid.h: Rename include guard.
3495         * nat/linux-ptrace.h: Rename include guard.
3496         * nat/linux-procfs.h: Rename include guard.
3497         * nat/linux-osdata.h: Rename include guard.
3498         * nat/linux-nat.h: Rename include guard.
3499         * nat/linux-namespaces.h: Rename include guard.
3500         * nat/linux-btrace.h: Rename include guard.
3501         * nat/glibc_thread_db.h: Rename include guard.
3502         * nat/gdb_thread_db.h: Rename include guard.
3503         * nat/gdb_ptrace.h: Rename include guard.
3504         * nat/fork-inferior.h: Rename include guard.
3505         * nat/amd64-linux-siginfo.h: Rename include guard.
3506         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3507         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3508         * nat/aarch64-linux.h: Rename include guard.
3509         * nat/aarch64-linux-hw-point.h: Rename include guard.
3510         * mn10300-tdep.h: Add include guard.
3511         * mips-linux-tdep.h: Add include guard.
3512         * mi/mi-parse.h: Rename include guard.
3513         * mi/mi-out.h: Rename include guard.
3514         * mi/mi-main.h: Rename include guard.
3515         * mi/mi-interp.h: Rename include guard.
3516         * mi/mi-getopt.h: Rename include guard.
3517         * mi/mi-console.h: Rename include guard.
3518         * mi/mi-common.h: Rename include guard.
3519         * mi/mi-cmds.h: Rename include guard.
3520         * mi/mi-cmd-break.h: Rename include guard.
3521         * m2-lang.h: Add include guard.
3522         * location.h: Rename include guard.
3523         * linux-record.h: Rename include guard.
3524         * linux-nat.h: Add include guard.
3525         * linux-fork.h: Add include guard.
3526         * i386-darwin-tdep.h: Rename include guard.
3527         * hppa-linux-offsets.h: Add include guard.
3528         * guile/guile.h: Rename include guard.
3529         * guile/guile-internal.h: Rename include guard.
3530         * gnu-nat.h: Rename include guard.
3531         * gdb-stabs.h: Rename include guard.
3532         * frv-tdep.h: Add include guard.
3533         * f-lang.h: Add include guard.
3534         * event-loop.h: Add include guard.
3535         * darwin-nat.h: Rename include guard.
3536         * cp-abi.h: Rename include guard.
3537         * config/sparc/nm-sol2.h: Rename include guard.
3538         * config/nm-nto.h: Rename include guard.
3539         * config/nm-linux.h: Add include guard.
3540         * config/i386/nm-i386gnu.h: Rename include guard.
3541         * config/djgpp/nl_types.h: Rename include guard.
3542         * config/djgpp/langinfo.h: Rename include guard.
3543         * compile/gcc-cp-plugin.h: Add include guard.
3544         * compile/gcc-c-plugin.h: Add include guard.
3545         * compile/compile.h: Rename include guard.
3546         * compile/compile-object-run.h: Rename include guard.
3547         * compile/compile-object-load.h: Rename include guard.
3548         * compile/compile-internal.h: Rename include guard.
3549         * compile/compile-cplus.h: Rename include guard.
3550         * compile/compile-c.h: Rename include guard.
3551         * common/xml-utils.h: Rename include guard.
3552         * common/x86-xstate.h: Rename include guard.
3553         * common/version.h: Rename include guard.
3554         * common/vec.h: Rename include guard.
3555         * common/tdesc.h: Rename include guard.
3556         * common/selftest.h: Rename include guard.
3557         * common/scoped_restore.h: Rename include guard.
3558         * common/scoped_mmap.h: Rename include guard.
3559         * common/scoped_fd.h: Rename include guard.
3560         * common/safe-iterator.h: Rename include guard.
3561         * common/run-time-clock.h: Rename include guard.
3562         * common/refcounted-object.h: Rename include guard.
3563         * common/queue.h: Rename include guard.
3564         * common/ptid.h: Rename include guard.
3565         * common/print-utils.h: Rename include guard.
3566         * common/preprocessor.h: Rename include guard.
3567         * common/pathstuff.h: Rename include guard.
3568         * common/observable.h: Rename include guard.
3569         * common/netstuff.h: Rename include guard.
3570         * common/job-control.h: Rename include guard.
3571         * common/host-defs.h: Rename include guard.
3572         * common/gdb_wait.h: Rename include guard.
3573         * common/gdb_vecs.h: Rename include guard.
3574         * common/gdb_unlinker.h: Rename include guard.
3575         * common/gdb_unique_ptr.h: Rename include guard.
3576         * common/gdb_tilde_expand.h: Rename include guard.
3577         * common/gdb_sys_time.h: Rename include guard.
3578         * common/gdb_string_view.h: Rename include guard.
3579         * common/gdb_splay_tree.h: Rename include guard.
3580         * common/gdb_setjmp.h: Rename include guard.
3581         * common/gdb_ref_ptr.h: Rename include guard.
3582         * common/gdb_optional.h: Rename include guard.
3583         * common/gdb_locale.h: Rename include guard.
3584         * common/gdb_assert.h: Rename include guard.
3585         * common/filtered-iterator.h: Rename include guard.
3586         * common/filestuff.h: Rename include guard.
3587         * common/fileio.h: Rename include guard.
3588         * common/environ.h: Rename include guard.
3589         * common/common-utils.h: Rename include guard.
3590         * common/common-types.h: Rename include guard.
3591         * common/common-regcache.h: Rename include guard.
3592         * common/common-inferior.h: Rename include guard.
3593         * common/common-gdbthread.h: Rename include guard.
3594         * common/common-exceptions.h: Rename include guard.
3595         * common/common-defs.h: Rename include guard.
3596         * common/common-debug.h: Rename include guard.
3597         * common/cleanups.h: Rename include guard.
3598         * common/buffer.h: Rename include guard.
3599         * common/btrace-common.h: Rename include guard.
3600         * common/break-common.h: Rename include guard.
3601         * cli/cli-utils.h: Rename include guard.
3602         * cli/cli-style.h: Rename include guard.
3603         * cli/cli-setshow.h: Rename include guard.
3604         * cli/cli-script.h: Rename include guard.
3605         * cli/cli-interp.h: Rename include guard.
3606         * cli/cli-decode.h: Rename include guard.
3607         * cli/cli-cmds.h: Rename include guard.
3608         * charset-list.h: Add include guard.
3609         * buildsym-legacy.h: Rename include guard.
3610         * bfin-tdep.h: Add include guard.
3611         * ax.h: Rename include guard.
3612         * arm-linux-tdep.h: Add include guard.
3613         * arm-fbsd-tdep.h: Add include guard.
3614         * arch/xtensa.h: Rename include guard.
3615         * arch/tic6x.h: Add include guard.
3616         * arch/i386.h: Add include guard.
3617         * arch/arm.h: Rename include guard.
3618         * arch/arm-linux.h: Rename include guard.
3619         * arch/arm-get-next-pcs.h: Rename include guard.
3620         * arch/amd64.h: Add include guard.
3621         * arch/aarch64-insn.h: Rename include guard.
3622         * arch-utils.h: Rename include guard.
3623         * annotate.h: Add include guard.
3624         * amd64-darwin-tdep.h: Rename include guard.
3625         * aarch64-linux-tdep.h: Add include guard.
3626         * aarch64-fbsd-tdep.h: Add include guard.
3627         * aarch32-linux-nat.h: Add include guard.
3628
3629 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3630
3631         * macrotab.c (macro_define_internal): New function that
3632         factorizes macro_define_object_internal and macro_define_function
3633         code.
3634         (macro_define_object_internal): Use macro_define_internal.
3635         (macro_define_function): Likewise.
3636
3637 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3638
3639         * macrocmd.c (extract_identifier): Return
3640         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3641         callers.
3642
3643 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3644
3645         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3646
3647 2019-02-05  Tom Tromey  <tom@tromey.com>
3648
3649         * target.c (target_stack::unpush): Move assertion earlier.
3650
3651 2019-01-30  Tom Tromey  <tom@tromey.com>
3652
3653         PR python/23615:
3654         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3655         (gdbpy_parse_and_eval): Likewise.
3656         * python/python-internal.h (gdbpy_allow_threads): New class.
3657
3658 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3659
3660         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3661         (aarch64_fbsd_fpregmap): Move earlier.
3662         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3663         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3664         instead of individual calls to trad_frame_set_reg_addr.
3665         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3666         earlier.
3667         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3668         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3669         instead of individual calls to trad_frame_set_reg_addr.
3670
3671 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3672
3673         * CONTRIBUTE: Replace contribution list with wiki link.
3674
3675 2019-01-25  Tom Tromey  <tom@tromey.com>
3676
3677         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3678
3679 2019-01-25  Tom Tromey  <tom@tromey.com>
3680
3681         * xtensa-linux-nat.c: Fix common/ includes.
3682         * xml-support.h: Fix common/ includes.
3683         * xml-support.c: Fix common/ includes.
3684         * x86-linux-nat.c: Fix common/ includes.
3685         * windows-nat.c: Fix common/ includes.
3686         * varobj.h: Fix common/ includes.
3687         * varobj.c: Fix common/ includes.
3688         * value.c: Fix common/ includes.
3689         * valops.c: Fix common/ includes.
3690         * utils.c: Fix common/ includes.
3691         * unittests/xml-utils-selftests.c: Fix common/ includes.
3692         * unittests/utils-selftests.c: Fix common/ includes.
3693         * unittests/unpack-selftests.c: Fix common/ includes.
3694         * unittests/tracepoint-selftests.c: Fix common/ includes.
3695         * unittests/style-selftests.c: Fix common/ includes.
3696         * unittests/string_view-selftests.c: Fix common/ includes.
3697         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3698         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3699         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3700         * unittests/rsp-low-selftests.c: Fix common/ includes.
3701         * unittests/parse-connection-spec-selftests.c: Fix common/
3702         includes.
3703         * unittests/optional-selftests.c: Fix common/ includes.
3704         * unittests/offset-type-selftests.c: Fix common/ includes.
3705         * unittests/observable-selftests.c: Fix common/ includes.
3706         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3707         * unittests/memrange-selftests.c: Fix common/ includes.
3708         * unittests/memory-map-selftests.c: Fix common/ includes.
3709         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3710         * unittests/function-view-selftests.c: Fix common/ includes.
3711         * unittests/environ-selftests.c: Fix common/ includes.
3712         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3713         * unittests/common-utils-selftests.c: Fix common/ includes.
3714         * unittests/cli-utils-selftests.c: Fix common/ includes.
3715         * unittests/array-view-selftests.c: Fix common/ includes.
3716         * ui-file.c: Fix common/ includes.
3717         * tui/tui-io.c: Fix common/ includes.
3718         * tracepoint.h: Fix common/ includes.
3719         * tracepoint.c: Fix common/ includes.
3720         * tracefile-tfile.c: Fix common/ includes.
3721         * top.h: Fix common/ includes.
3722         * top.c: Fix common/ includes.
3723         * thread.c: Fix common/ includes.
3724         * target/waitstatus.h: Fix common/ includes.
3725         * target/waitstatus.c: Fix common/ includes.
3726         * target.h: Fix common/ includes.
3727         * target.c: Fix common/ includes.
3728         * target-memory.c: Fix common/ includes.
3729         * target-descriptions.c: Fix common/ includes.
3730         * symtab.h: Fix common/ includes.
3731         * symfile.c: Fix common/ includes.
3732         * stap-probe.c: Fix common/ includes.
3733         * spu-linux-nat.c: Fix common/ includes.
3734         * sparc-nat.c: Fix common/ includes.
3735         * source.c: Fix common/ includes.
3736         * solib.c: Fix common/ includes.
3737         * solib-target.c: Fix common/ includes.
3738         * ser-unix.c: Fix common/ includes.
3739         * ser-tcp.c: Fix common/ includes.
3740         * ser-pipe.c: Fix common/ includes.
3741         * ser-base.c: Fix common/ includes.
3742         * selftest-arch.c: Fix common/ includes.
3743         * s12z-tdep.c: Fix common/ includes.
3744         * rust-exp.y: Fix common/ includes.
3745         * rs6000-aix-tdep.c: Fix common/ includes.
3746         * riscv-tdep.c: Fix common/ includes.
3747         * remote.c: Fix common/ includes.
3748         * remote-notif.h: Fix common/ includes.
3749         * remote-fileio.h: Fix common/ includes.
3750         * remote-fileio.c: Fix common/ includes.
3751         * regcache.h: Fix common/ includes.
3752         * regcache.c: Fix common/ includes.
3753         * record-btrace.c: Fix common/ includes.
3754         * python/python.c: Fix common/ includes.
3755         * python/py-type.c: Fix common/ includes.
3756         * python/py-inferior.c: Fix common/ includes.
3757         * progspace.h: Fix common/ includes.
3758         * producer.c: Fix common/ includes.
3759         * procfs.c: Fix common/ includes.
3760         * proc-api.c: Fix common/ includes.
3761         * printcmd.c: Fix common/ includes.
3762         * ppc-linux-nat.c: Fix common/ includes.
3763         * parser-defs.h: Fix common/ includes.
3764         * osdata.c: Fix common/ includes.
3765         * obsd-nat.c: Fix common/ includes.
3766         * nat/x86-linux.c: Fix common/ includes.
3767         * nat/x86-linux-dregs.c: Fix common/ includes.
3768         * nat/x86-dregs.h: Fix common/ includes.
3769         * nat/x86-dregs.c: Fix common/ includes.
3770         * nat/ppc-linux.c: Fix common/ includes.
3771         * nat/mips-linux-watch.h: Fix common/ includes.
3772         * nat/mips-linux-watch.c: Fix common/ includes.
3773         * nat/linux-waitpid.c: Fix common/ includes.
3774         * nat/linux-ptrace.h: Fix common/ includes.
3775         * nat/linux-ptrace.c: Fix common/ includes.
3776         * nat/linux-procfs.c: Fix common/ includes.
3777         * nat/linux-personality.c: Fix common/ includes.
3778         * nat/linux-osdata.c: Fix common/ includes.
3779         * nat/linux-namespaces.c: Fix common/ includes.
3780         * nat/linux-btrace.h: Fix common/ includes.
3781         * nat/linux-btrace.c: Fix common/ includes.
3782         * nat/fork-inferior.c: Fix common/ includes.
3783         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3784         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3785         * nat/aarch64-linux.c: Fix common/ includes.
3786         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3787         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3788         * namespace.h: Fix common/ includes.
3789         * mips-linux-tdep.c: Fix common/ includes.
3790         * minsyms.c: Fix common/ includes.
3791         * mi/mi-parse.h: Fix common/ includes.
3792         * mi/mi-main.c: Fix common/ includes.
3793         * mi/mi-cmd-env.c: Fix common/ includes.
3794         * memrange.h: Fix common/ includes.
3795         * memattr.c: Fix common/ includes.
3796         * maint.h: Fix common/ includes.
3797         * maint.c: Fix common/ includes.
3798         * main.c: Fix common/ includes.
3799         * machoread.c: Fix common/ includes.
3800         * location.c: Fix common/ includes.
3801         * linux-thread-db.c: Fix common/ includes.
3802         * linux-nat.c: Fix common/ includes.
3803         * linux-fork.c: Fix common/ includes.
3804         * inline-frame.c: Fix common/ includes.
3805         * infrun.c: Fix common/ includes.
3806         * inflow.c: Fix common/ includes.
3807         * inferior.h: Fix common/ includes.
3808         * inferior.c: Fix common/ includes.
3809         * infcmd.c: Fix common/ includes.
3810         * inf-ptrace.c: Fix common/ includes.
3811         * inf-child.c: Fix common/ includes.
3812         * ia64-linux-nat.c: Fix common/ includes.
3813         * i387-tdep.c: Fix common/ includes.
3814         * i386-tdep.c: Fix common/ includes.
3815         * i386-linux-tdep.c: Fix common/ includes.
3816         * i386-linux-nat.c: Fix common/ includes.
3817         * i386-go32-tdep.c: Fix common/ includes.
3818         * i386-fbsd-tdep.c: Fix common/ includes.
3819         * i386-fbsd-nat.c: Fix common/ includes.
3820         * guile/scm-type.c: Fix common/ includes.
3821         * guile/guile.c: Fix common/ includes.
3822         * go32-nat.c: Fix common/ includes.
3823         * gnu-nat.c: Fix common/ includes.
3824         * gdbthread.h: Fix common/ includes.
3825         * gdbarch-selftests.c: Fix common/ includes.
3826         * gdb_usleep.c: Fix common/ includes.
3827         * gdb_select.h: Fix common/ includes.
3828         * gdb_bfd.c: Fix common/ includes.
3829         * gcore.c: Fix common/ includes.
3830         * fork-child.c: Fix common/ includes.
3831         * findvar.c: Fix common/ includes.
3832         * fbsd-nat.c: Fix common/ includes.
3833         * event-top.c: Fix common/ includes.
3834         * event-loop.c: Fix common/ includes.
3835         * dwarf2read.c: Fix common/ includes.
3836         * dwarf2loc.c: Fix common/ includes.
3837         * dwarf2-frame.c: Fix common/ includes.
3838         * dwarf-index-cache.c: Fix common/ includes.
3839         * dtrace-probe.c: Fix common/ includes.
3840         * disasm-selftests.c: Fix common/ includes.
3841         * defs.h: Fix common/ includes.
3842         * csky-tdep.c: Fix common/ includes.
3843         * cp-valprint.c: Fix common/ includes.
3844         * cp-support.h: Fix common/ includes.
3845         * cp-support.c: Fix common/ includes.
3846         * corelow.c: Fix common/ includes.
3847         * completer.h: Fix common/ includes.
3848         * completer.c: Fix common/ includes.
3849         * compile/compile.c: Fix common/ includes.
3850         * compile/compile-loc2c.c: Fix common/ includes.
3851         * compile/compile-cplus-types.c: Fix common/ includes.
3852         * compile/compile-cplus-symbols.c: Fix common/ includes.
3853         * command.h: Fix common/ includes.
3854         * cli/cli-dump.c: Fix common/ includes.
3855         * cli/cli-cmds.c: Fix common/ includes.
3856         * charset.c: Fix common/ includes.
3857         * build-id.c: Fix common/ includes.
3858         * btrace.h: Fix common/ includes.
3859         * btrace.c: Fix common/ includes.
3860         * breakpoint.h: Fix common/ includes.
3861         * breakpoint.c: Fix common/ includes.
3862         * ax.h: 
3863         (enum agent_op): Fix common/ includes.
3864         * ax-general.c (struct aop_map): Fix common/ includes.
3865         * ax-gdb.c: Fix common/ includes.
3866         * auxv.c: Fix common/ includes.
3867         * auto-load.c: Fix common/ includes.
3868         * arm-tdep.c: Fix common/ includes.
3869         * arch/riscv.c: Fix common/ includes.
3870         * arch/ppc-linux-common.c: Fix common/ includes.
3871         * arch/i386.c: Fix common/ includes.
3872         * arch/arm.c: Fix common/ includes.
3873         * arch/arm-linux.c: Fix common/ includes.
3874         * arch/arm-get-next-pcs.c: Fix common/ includes.
3875         * arch/amd64.c: Fix common/ includes.
3876         * arch/aarch64.c: Fix common/ includes.
3877         * arch/aarch64-insn.c: Fix common/ includes.
3878         * arch-utils.c: Fix common/ includes.
3879         * amd64-windows-tdep.c: Fix common/ includes.
3880         * amd64-tdep.c: Fix common/ includes.
3881         * amd64-sol2-tdep.c: Fix common/ includes.
3882         * amd64-obsd-tdep.c: Fix common/ includes.
3883         * amd64-nbsd-tdep.c: Fix common/ includes.
3884         * amd64-linux-tdep.c: Fix common/ includes.
3885         * amd64-linux-nat.c: Fix common/ includes.
3886         * amd64-fbsd-tdep.c: Fix common/ includes.
3887         * amd64-fbsd-nat.c: Fix common/ includes.
3888         * amd64-dicos-tdep.c: Fix common/ includes.
3889         * amd64-darwin-tdep.c: Fix common/ includes.
3890         * agent.c: Fix common/ includes.
3891         * ada-lang.h: Fix common/ includes.
3892         * ada-lang.c: Fix common/ includes.
3893         * aarch64-tdep.c: Fix common/ includes.
3894
3895 2019-01-25  Tom Tromey  <tom@tromey.com>
3896
3897         * common/create-version.sh: Use common/version.h.
3898
3899 2019-01-24  Pedro Alves  <palves@redhat.com>
3900
3901         * infrun.c (signal_stop, signal_print, signal_program)
3902         (signal_catch, signal_pass): Now arrays instead of pointers.
3903         (update_signals_program_target, do_target_resume)
3904         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3905         * linux-nat.c (linux_nat_target::pass_signals)
3906         (linux_nat_target::create_inferior, linux_nat_target::attach):
3907         Adjust.
3908         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3909         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3910         * procfs.c (procfs_target::pass_signals): Adjust.
3911         * record-full.c (record_full_target::resume): Adjust.
3912         * remote.c (remote_target::pass_signals)
3913         (remote_target::program_signals): Adjust.
3914         * target-debug.h (target_debug_print_signals): Now takes a
3915         gdb::array_view as parameter.  Adjust.
3916         * target.h (target_ops) <pass_signals, program_signals>: Replace
3917         pointer and length parameters with gdb::array_view.
3918         (target_pass_signals, target_program_signals): Likewise.
3919         * target-delegates.c: Regenerate.
3920
3921 2019-01-24  Pedro Alves  <palves@redhat.com>
3922
3923         * common/forward-scope-exit.h
3924         (forward_scope_exit::forward_scope_exit): Pass arguments to
3925         m_bind_function directly, instead of creating a std::bind and
3926         copying that.
3927
3928 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3929
3930         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3931         for static members.
3932         (pass_in_v_vfp_candidate): Likewise.
3933
3934 2019-01-23  Tom Tromey  <tom@tromey.com>
3935             Pedro Alves  <palves@redhat.com>
3936
3937         * regcache.c (class regcache_invalidator): Remove.
3938         (regcache::raw_write): Use make_scope_exit.
3939
3940 2019-01-23  Tom Tromey  <tom@tromey.com>
3941
3942         * ui-out.h (class ui_out_emit_type): Update comment.
3943
3944 2019-01-23  Tom Tromey  <tom@tromey.com>
3945
3946         * infrun.c (fetch_inferior_event): Update comment.
3947
3948 2019-01-23  Tom Tromey  <tom@tromey.com>
3949             Pedro Alves  <palves@redhat.com>
3950
3951         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3952         parameter.
3953         (fetch_inferior_event): Use SCOPE_EXIT.
3954
3955
3956 2019-01-23  Tom Tromey  <tom@tromey.com>
3957             Pedro Alves  <palves@redhat.com>
3958
3959         * infrun.c (disable_thread_events): Delete.
3960         (stop_all_threads): Use SCOPE_EXIT.
3961
3962 2019-01-23  Tom Tromey  <tom@tromey.com>
3963             Pedro Alves  <palves@redhat.com>
3964
3965         * symfile.c: Include forward-scope-exit.h.
3966         (clear_symtab_users_cleanup): Replace forward declaration with
3967         a FORWARD_SCOPE_EXIT.
3968         (syms_from_objfile_1): Use the forward_scope_exit and
3969         gdb::optional instead of cleanup_function.
3970         (reread_symbols): Use the forward_scope_exit instead of
3971         cleanup_function.
3972         (clear_symtab_users_cleanup): Remove function.
3973
3974 2019-01-23  Tom Tromey  <tom@tromey.com>
3975             Pedro Alves  <palves@redhat.com>
3976
3977         * linux-nat.c: Include scope-exit.h.
3978         (cleanup_target_stop): Remove.
3979         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3980         SCOPE_EXIT.
3981
3982 2019-01-23  Tom Tromey  <tom@tromey.com>
3983             Pedro Alves  <palves@redhat.com>
3984
3985         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3986         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3987
3988 2019-01-23  Tom Tromey  <tom@tromey.com>
3989             Andrew Burgess  <andrew.burgess@embecosm.com>
3990             Pedro Alves  <palves@redhat.com>
3991
3992         * infrun.c (fetch_inferior_event): Use scope_exit.
3993         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3994         * top.c (execute_command): Use scope_exit.
3995         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3996         * utils.c (do_bpstat_clear_actions_cleanup)
3997         (make_bpstat_clear_actions_cleanup): Remove.
3998
3999 2019-01-23  Tom Tromey  <tom@tromey.com>
4000             Pedro Alves  <palves@redhat.com>
4001
4002         * infrun.c: Include "common/scope-exit.h"
4003         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4004         (wait_for_inferior): Use SCOPE_EXIT.
4005         (fetch_inferior_event): Use scope_exit.
4006
4007 2019-01-23  Tom Tromey  <tom@tromey.com>
4008             Pedro Alves  <palves@redhat.com>
4009
4010         * breakpoint.c (create_breakpoint): Remove cleanup.
4011
4012 2019-01-23  Tom Tromey  <tom@tromey.com>
4013             Andrew Burgess  <andrew.burgess@embecosm.com>
4014             Pedro Alves  <palves@redhat.com>
4015
4016 2019-01-23  Pedro Alves  <palves@redhat.com>
4017
4018         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4019
4020 2019-01-23  Pedro Alves  <palves@redhat.com>
4021             Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * gdbthread.h: Include "common/forward-scope-exit.h".
4024         (scoped_finish_thread_state): Redefine custom class in terms of
4025         forward_scope_exit.
4026
4027 2019-01-23  Pedro Alves  <palves@redhat.com>
4028             Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * common/forward-scope-exit.h: New file.
4031
4032 2019-01-23  Pedro Alves  <palves@redhat.com>
4033             Andrew Burgess  <andrew.burgess@embecosm.com>
4034             Tom Tromey  <tom@tromey.com>
4035
4036         * common/scope-exit.h: New file.
4037
4038 2019-01-23  Pedro Alves  <palves@redhat.com>
4039
4040         * common/preprocessor.h (ESC): Rename to ...
4041         (ESC_PARENS): ... this.
4042         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4043         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4044
4045 2019-01-23  Tom Tromey  <tom@tromey.com>
4046
4047         * language.h (class scoped_switch_to_sym_language_if_auto):
4048         Initialize m_lang in both cases.
4049
4050 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4051
4052         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4053         with XCNEW.
4054
4055 2019-01-22  Tom Tromey  <tom@tromey.com>
4056
4057         * corelow.c: Do not include sys/file.h.
4058
4059 2019-01-22  Tom Tromey  <tom@tromey.com>
4060
4061         * tui/tui-wingeneral.h: Include gdb_curses.h.
4062
4063 2019-01-22  Tom Tromey  <tom@tromey.com>
4064
4065         * source-cache.h (class source_cache) <get_source_lines,
4066         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4067
4068 2019-01-22  Tom Tromey  <tom@tromey.com>
4069
4070         * remote-fileio.h (struct remote_target): Declare.
4071
4072 2019-01-22  Tom Tromey  <tom@tromey.com>
4073
4074         * python/py-arch.c: Do not include py-ref.h.
4075         * python/py-bpevent.c: Do not include py-ref.h.
4076         * python/py-cmd.c: Do not include py-ref.h.
4077         * python/py-continueevent.c: Do not include py-ref.h.
4078         * python/py-event.h: Do not include py-ref.h.
4079         * python/py-evtregistry.c: Do not include py-ref.h.
4080         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4081         * python/py-frame.c: Do not include py-ref.h.
4082         * python/py-framefilter.c: Do not include py-ref.h.
4083         * python/py-function.c: Do not include py-ref.h.
4084         * python/py-infevents.c: Do not include py-ref.h.
4085         * python/py-linetable.c: Do not include py-ref.h.
4086         * python/py-objfile.c: Do not include py-ref.h.
4087         * python/py-param.c: Do not include py-ref.h.
4088         * python/py-prettyprint.c: Do not include py-ref.h.
4089         * python/py-progspace.c: Do not include py-ref.h.
4090         * python/py-symbol.c: Do not include py-ref.h.
4091         * python/py-symtab.c: Do not include py-ref.h.
4092         * python/py-type.c: Do not include py-ref.h.
4093         * python/py-unwind.c: Do not include py-ref.h.
4094         * python/py-utils.c: Do not include py-ref.h.
4095         * python/py-value.c: Do not include py-ref.h.
4096         * python/py-varobj.c: Do not include py-ref.h.
4097         * python/py-xmethods.c: Do not include py-ref.h.
4098         * python/python.c: Do not include py-ref.h.
4099         * varobj.c: Do not include py-ref.h.
4100
4101 2019-01-22  Tom Tromey  <tom@tromey.com>
4102
4103         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4104         keyword for bcache.
4105
4106 2019-01-22  Tom Tromey  <tom@tromey.com>
4107
4108         * compile/compile-cplus-types.c: Remove a comment by #include.
4109
4110 2019-01-22  Tom Tromey  <tom@tromey.com>
4111
4112         * compile/gcc-c-plugin.h: Include compile-internal.h.
4113
4114 2019-01-22  Tom Tromey  <tom@tromey.com>
4115
4116         * stabsread.c (EXTERN): Do not define.
4117         (symnum, next_symbol_text_func, processing_gcc_compilation)
4118         (within_function, global_sym_chain, global_stabs)
4119         (previous_stab_code, this_object_header_files)
4120         (n_this_object_header_files)
4121         (n_allocated_this_object_header_files): Define.
4122         * stabsread.h (EXTERN): Never define.  Use "extern".
4123
4124 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4125
4126         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4127         history_value.
4128
4129 2019-01-21  Tom Tromey  <tom@tromey.com>
4130
4131         * ui-out.c: Fix includes.
4132         * tui/tui-source.c: Fix includes.
4133         * target.c: Fix includes.
4134         * remote.c: Fix includes.
4135         * regcache.c: Fix includes.
4136         * python/py-block.c: Fix includes.
4137         * printcmd.c: Fix includes.
4138         * or1k-tdep.c: Fix includes.
4139         * mi/mi-main.c: Fix includes.
4140         * m32r-tdep.c: Fix includes.
4141         * csky-tdep.c: Fix includes.
4142         * compile/compile-cplus-types.c: Fix includes.
4143         * cli/cli-interp.c: Fix includes.
4144
4145 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4146
4147         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4148         for padding.
4149
4150 2019-01-16  Tom Tromey  <tom@tromey.com>
4151
4152         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4153         earlier.
4154         (struct objfile) <msymbols_range>: Move from top level.
4155         <msymbols>: New method.
4156         (class objfile_msymbols): Remove.
4157         * symtab.c (default_collect_symbol_completion_matches_break_on):
4158         Update.
4159         * symmisc.c (dump_msymbols): Update.
4160         * stabsread.c (scan_file_globals): Update.
4161         * objc-lang.c (info_selectors_command, info_classes_command)
4162         (find_methods): Update.
4163         * minsyms.c (find_solib_trampoline_target): Update.
4164         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4165         * coffread.c (coff_symfile_read): Update.
4166         * ada-lang.c (ada_lookup_simple_minsym)
4167         (ada_collect_symbol_completion_matches): Update.
4168
4169 2019-01-16  Tom Tromey  <tom@tromey.com>
4170
4171         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4172         type.  Remove no-argument constructor.
4173         <iterator::operator++>: Simplify.
4174         <begin>: Update.
4175         <end>: Use minimal_symbol_count.
4176
4177 2019-01-16  Tom Tromey  <tom@tromey.com>
4178
4179         * objfiles.h (struct objfile) <psymtabs>: New method.
4180         (class objfile_psymtabs): Remove.
4181         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4182         typedef.
4183         <range>: New method.
4184         (require_partial_symbols): Change return type.
4185         * psymtab.c (require_partial_symbols)
4186         (psym_expand_symtabs_matching): Update.
4187         * mdebugread.c (parse_partial_symbols): Update.
4188         * dbxread.c (dbx_end_psymtab): Update.
4189
4190 2019-01-15  Tom Tromey  <tom@tromey.com>
4191
4192         * symtab.c (lookup_objfile_from_block)
4193         (lookup_symbol_in_objfile_symtabs)
4194         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4195         (find_line_symtab, info_sources_command)
4196         (default_collect_symbol_completion_matches_break_on)
4197         (make_source_files_completion_list): Update.
4198         * symmisc.c (print_objfile_statistics, dump_objfile)
4199         (maintenance_print_symbols, maintenance_info_symtabs)
4200         (maintenance_check_symtabs, maintenance_info_line_tables):
4201         Update.
4202         * source.c (select_source_symtab)
4203         (forget_cached_source_info_for_objfile): Update.
4204         * objfiles.h (class objfile_compunits): Remove.
4205         (struct objfile) <compunits_range>: New typedef.
4206         (compunits): New method.
4207         * objfiles.c (objfile_relocate1): Update.
4208         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4209         * maint.c (count_symtabs_and_blocks): Update.
4210         * linespec.c (iterate_over_all_matching_symtabs): Update.
4211         * cp-support.c (add_symbol_overload_list_qualified): Update.
4212         * coffread.c (coff_symtab_read): Update.
4213         * ada-lang.c (add_nonlocal_symbols)
4214         (ada_collect_symbol_completion_matches)
4215         (ada_add_global_exceptions): Update.
4216
4217 2019-01-15  Tom Tromey  <tom@tromey.com>
4218
4219         * progspace.h (program_space) <objfiles_safe_range>: New
4220         typedef.
4221         <objfiles_safe>: New method.
4222         * objfiles.h (class all_objfiles_safe): Remove.
4223         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4224         * jit.c (jit_inferior_exit_hook): Update.
4225
4226 2019-01-17  Tom Tromey  <tom@tromey.com>
4227
4228         * progspace.h (program_space) <objfiles_range>: New typedef.
4229         <objfiles>: New method.
4230         <objfiles_head>: Rename from objfiles.
4231         (object_files): Update.
4232         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4233         * guile/scm-pretty-print.c
4234         (ppscm_find_pretty_printer_from_objfiles): Update.
4235         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4236         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4237         Update.
4238         * python/py-progspace.c (pspy_get_objfiles): Update.
4239         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4240         Update.
4241         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4242         (objfpy_lookup_objfile_by_build_id): Update.
4243         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4244         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4245         Update.
4246         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4247         (expand_symtab_containing_pc, lookup_objfile_from_block)
4248         (lookup_static_symbol, basic_lookup_transparent_type)
4249         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4250         (find_line_symtab, info_sources_command)
4251         (default_collect_symbol_completion_matches_break_on)
4252         (make_source_files_completion_list, find_main_name): Update.
4253         * symmisc.c (print_symbol_bcache_statistics)
4254         (print_objfile_statistics, maintenance_print_symbols)
4255         (maintenance_print_msymbols, maintenance_print_objfiles)
4256         (maintenance_info_symtabs, maintenance_check_symtabs)
4257         (maintenance_expand_symtabs, maintenance_info_line_tables):
4258         Update.
4259         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4260         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4261         (map_overlay_command, unmap_overlay_command)
4262         (simple_overlay_update, expand_symtabs_matching)
4263         (map_symbol_filenames): Update.
4264         * symfile-debug.c (set_debug_symfile): Update.
4265         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4266         Update.
4267         * source.c (select_source_symtab, forget_cached_source_info):
4268         Update.
4269         * solib.c (solib_read_symbols): Update.
4270         * solib-spu.c (append_ocl_sos): Update.
4271         * psymtab.c (maintenance_print_psymbols)
4272         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4273         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4274         * printcmd.c (info_symbol_command): Update.
4275         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4276         Update.
4277         * objfiles.h (class all_objfiles): Remove.
4278         * objfiles.c (have_partial_symbols, have_full_symbols)
4279         (have_minimal_symbols, qsort_cmp, update_section_map)
4280         (shared_objfile_contains_address_p)
4281         (default_iterate_over_objfiles_in_search_order): Update.
4282         * objc-lang.c (info_selectors_command, info_classes_command)
4283         (find_methods): Update.
4284         * minsyms.c (find_solib_trampoline_target): Update.
4285         * maint.c (maintenance_info_sections)
4286         (maintenance_translate_address, count_symtabs_and_blocks):
4287         Update.
4288         * main.c (captured_main_1): Update.
4289         * linux-thread-db.c (try_thread_db_load_from_pdir)
4290         (has_libpthread): Update.
4291         * linespec.c (iterate_over_all_matching_symtabs)
4292         (search_minsyms_for_name): Update.
4293         * jit.c (jit_find_objf_with_entry_addr): Update.
4294         * hppa-tdep.c (find_unwind_entry)
4295         (hppa_lookup_stub_minimal_symbol): Update.
4296         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4297         Update.
4298         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4299         (elf_gnu_ifunc_resolve_by_got): Update.
4300         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4301         * dwarf-index-write.c (save_gdb_index_command): Update.
4302         * cp-support.c (add_symbol_overload_list_qualified): Update.
4303         * breakpoint.c (create_overlay_event_breakpoint)
4304         (create_longjmp_master_breakpoint)
4305         (create_std_terminate_master_breakpoint)
4306         (create_exception_master_breakpoint): Update.
4307         * blockframe.c (find_pc_partial_function): Update.
4308         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4309         (ada_collect_symbol_completion_matches)
4310         (ada_add_global_exceptions): Update.
4311
4312 2019-01-17  Tom Tromey  <tom@tromey.com>
4313
4314         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4315         declare VEC.
4316         (solib_target_parse_libraries): Change return type.
4317         (library_list_start_segment, library_list_start_section)
4318         (library_list_end_library, library_list_start_library); Update.
4319         (solib_target_free_library_list): Remove.
4320         (solib_target_parse_libraries): Remove cleanup.  Change return
4321         type.
4322         (solib_target_current_sos): Update.
4323
4324 2019-01-17  Tom Tromey  <tromey@bapiya>
4325
4326         * valprint.c: Replace "the the" with "the".
4327         * symtab.c: Replace "the the" with "the".
4328         * solib.c: Replace "the the" with "the".
4329         * solib-dsbt.c: Replace "the the" with "the".
4330         * linespec.c: Replace "the the" with "the".
4331         * dwarf2loc.h: Replace "the the" with "the".
4332         * amd64-windows-tdep.c: Replace "the the" with "the".
4333         * aarch64-tdep.c: Replace "the the" with "the".
4334
4335 2019-01-16  Keith Seitz  <keiths@redhat.com>
4336
4337         PR gdb/23773
4338         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4339         <builder>: Rename to ..
4340         <m_builder>: ... this and make private.
4341         (dwarf2_cu::get_builder): New method.  Change all users of
4342         `builder' to use this method.
4343         (dwarf2_start_symtab): Move to ...
4344         (dwarf2_cu::start_symtab): ... here.  Update all callers
4345         (setup_type_unit_groups): Move to ...
4346         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4347         callers.
4348         (dwarf2_cu::reset_builder): New method.
4349         (process_full_compunit, process_full_type_unit): Use
4350         dwarf2_cu::reset_builder.
4351         (follow_die_offset): Record the ancestor CU if it is different
4352         from the followed DIE's CU.
4353         (follow_die_sig_1): Likewise.
4354
4355 2019-01-15  Tom Tromey  <tom@tromey.com>
4356
4357         * remote.c (class remote_state) <buf>: Now a char_vector.
4358         <buf_size>: Remove.
4359         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4360         parameter.
4361         (remote_target::getpkt_or_notif_sane_1)
4362         (remote_target::getpkt_sane)
4363         (remote_target::getpkt_or_notif_sane): Likewise.
4364         (class remote_target) <putpkt>: New overload.
4365         (remote_target::read_frame): Change type of "buf_p".  Remove
4366         sizeof_p parameter.
4367         (packet_ok): New overload.
4368         (packet_check_result): New overload.
4369         Update all uses.
4370
4371 2019-01-14  Tom Tromey  <tom@tromey.com>
4372
4373         * remote-notif.c (handle_notification, remote_notif_ack)
4374         (remote_notif_parse): Make "buf" const.
4375         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4376         const.
4377         (remote_notif_parse, remote_notif_ack, handle_notification):
4378         Likewise.
4379         * remote.c (remote_notif_stop_parse): Make "buf" const.
4380         (remote_target::remote_parse_stop_reply): Make "buf" const.
4381         (remote_notif_stop_ack): Make "buf" const.
4382
4383 2019-01-14  Tom Tromey  <tom@tromey.com>
4384
4385         * remote.c (remote_console_output): Make parameter const.
4386
4387 2019-01-14  Tom Tromey  <tom@tromey.com>
4388
4389         * target-debug.h (target_debug_print_signals): Constify.
4390         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4391         * procfs.c (procfs_target::pass_signals): Update.
4392         * linux-nat.c (linux_nat_target::pass_signals): Update.
4393         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4394         * target-delegates.c: Rebuild.
4395         * remote.c (remote_target::program_signals): Update.
4396         (remote_target::pass_signals): Update.
4397         * target.c (target_pass_signals): Constify argument.
4398         (target_program_signals): Likewise.
4399         * target.h (struct target_ops) <pass_signals, program_signals>:
4400         Constify argument.
4401         (target_pass_signals, target_program_signals): Constify argument.
4402
4403 2019-01-14  Tom Tromey  <tom@tromey.com>
4404
4405         PR tui/28819:
4406         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4407
4408 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4409
4410         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4411         field.
4412         * rs6000-tdep.c: Include reggroups.h.
4413         (IS_V_ALIAS_PSEUDOREG): Define.
4414         (rs6000_register_name): Return names for the "vX" aliases.
4415         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4416         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4417         aliases.  Call default_register_reggroup_p for all other
4418         pseudo-registers.
4419         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4420         New functions.
4421         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4422         Handle "vX" aliases.
4423         (v_alias_pseudo_register_collect): New function.
4424         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4425         (rs6000_gdbarch_init): Initialize "vX" aliases as
4426         pseudo-registers.  Restore registration of
4427         rs6000_pseudo_register_reggroup_p with
4428         set_tdesc_pseudo_register_reggroup_p.
4429
4430 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4431
4432         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4433         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4434         set_gdbarch_num_pseudo_regs.
4435
4436 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4437
4438         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4439         Remove arg prefixname, add do_set and do_show.
4440         Add member functions set_list and show_list.
4441         * cli/cli-style.c (class cli_style_option): Update accordingly.
4442         (style_set_list): Move to file scope.
4443         (style_show_list): Likewise.
4444         (set_style): Call help_list.
4445         (show_style): Call cmd_show_list.
4446         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4447         Update to use the new macro.
4448
4449 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4450
4451         * ada-lang.c (_initialize_ada_language): Expand the help text
4452         for the "catch exception" command.
4453
4454 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4455
4456         * symtab.c (matching_obj_sections): Initialize obj,
4457         declare it closer to its usage.
4458
4459 2019-01-10  Tom Tromey  <tom@tromey.com>
4460
4461         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4462         (basic_inf_threads_range): Remove.
4463         (inf_threads_range, inf_non_exited_threads_range)
4464         (safe_inf_threads_range): Use next_adapter.
4465
4466 2019-01-10  Keith Seitz  <keiths@redhat.com>
4467
4468         PR gdb/23712
4469         PR symtab/23010
4470         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4471         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4472
4473 2019-01-10  Keith Seitz  <keiths@redhat.com>
4474
4475         PR gdb/23712
4476         PR symtab/23010
4477         * dictionary.c (pending_to_vector): Remove.
4478         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4479         Remove _1 suffix, replacing functions of the same name.  Update
4480         all callers.
4481         (dict_create_hashed, dict_create_hashed_expandable)
4482         (dict_create_linear, dict_create_linear_expandable, dict_free)
4483         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4484         Make functions static.
4485
4486 2019-01-10  Keith Seitz  <keiths@redhat.com>
4487
4488         PR gdb/23712
4489         PR symtab/23010
4490         * dictionary.h (struct dictionary): Replace declaration with
4491         multidictionary.
4492         (dict_create_hashed, dict_create_hashed_expandable)
4493         (dict_create_linear, dict_create_linear_expandable)
4494         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4495         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4496         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4497         taking multidictionary argument.
4498         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4499         * block.h (struct block) <dict>: Change to multidictionary
4500         and rename `multidict'.
4501         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4502         symmisc.c: Update all dictionary references to multidictionary.
4503
4504 2019-01-10  Keith Seitz  <keiths@redhat.com>
4505
4506         PR gdb/23712
4507         PR symtab/23010
4508         * dictionary.c: Include unordered_map.
4509         (pending_to_vector): New function.
4510         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4511         Rewrite the non-"_1" functions to take vector instead
4512         of linked list.
4513         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4514         "new" _1 versions of the same name.
4515         (multidictionary): Define.
4516         (std::hash<enum language): New definition.
4517         (collate_pending_symbols_by_language, mdict_create_hashed)
4518         (mdict_create_hashed_expandable, mdict_create_linear)
4519         (mdict_create_linear_expandable, mdict_free)
4520         (find_language_dictionary, create_new_language_dictionary)
4521         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4522         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4523         (mdict_size, mdict_empty): New functions.
4524         * dictionary.h (mdict_iterator): Define.
4525
4526 2019-01-10  Pedro Alves  <palves@redhat.com>
4527
4528         * breakpoint.c (read_uploaded_action)
4529         (create_tracepoint_from_upload): Adjust to use
4530         gdb::unique_xmalloc_ptr.
4531         * ctf.c (ctf_write_uploaded_tp):
4532         (SET_ARRAY_FIELD): Use emplace_back.
4533         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4534         * tracefile-tfile.c (tfile_write_uploaded_tp):
4535         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4536         gdb::unique_xmalloc_ptr.
4537         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4538         at_string, cond_string, cmd_strings>: Replace char pointers
4539         with gdb::unique_xmalloc_ptr.
4540
4541 2019-01-10  Pedro Alves  <palves@redhat.com>
4542
4543         * solib-target.c (library_list_start_library): Don't xstrdup name.
4544
4545 2019-01-10  Pedro Alves  <palves@redhat.com>
4546
4547         * mdebugread.c (parse_partial_symbols): Use
4548         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4549
4550 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * linux-fork.c (scoped_switch_fork_info)
4553         <~scoped_switch_fork_info>: Fix incorrect variable name.
4554
4555 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4556
4557         * linux-fork.c (scoped_switch_fork_info)
4558         <scoped_switch_fork_info>: Make explicit.
4559         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4560
4561 2019-01-10  Tom Tromey  <tom@tromey.com>
4562
4563         * objfiles.h (objfile::reset_psymtabs): Update.
4564         * objfiles.c (objfile::objfile): Update.
4565         * psymtab.h (psymtab_storage::obstack): Update.
4566         (psymtab_storage::m_obstack): Use gdb::optional.
4567         (class psymtab_storage): Update comment.  Remove objfile
4568         parameter.
4569         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4570
4571 2019-01-10  Tom Tromey  <tom@tromey.com>
4572
4573         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4574         <free_psymtabs>: Now private.
4575         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4576         (allocate_psymtab): Use new method.
4577
4578 2019-01-10  Tom Tromey  <tom@tromey.com>
4579
4580         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4581         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4582         * mdebugread.c (parse_partial_symbols): Use
4583         allocate_dependencies.
4584         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4585         allocate_dependencies.
4586         (process_psymtab_comp_unit_reader)
4587         (build_type_psymtab_dependencies): Likewise.
4588         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4589
4590 2019-01-10  Tom Tromey  <tom@tromey.com>
4591
4592         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4593         PSYMBOL_SET_LANGUAGE.
4594         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4595
4596 2019-01-10  Tom Tromey  <tom@tromey.com>
4597
4598         * psymtab.h (psymtab_storage::obstack): New method.
4599         <m_obstack>: Rename from obstack; now private.
4600         * psymtab.c (psymtab_storage): Update.
4601         * dwarf2read.c (create_addrmap_from_index)
4602         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4603         Update.
4604
4605 2019-01-10  Tom Tromey  <tom@tromey.com>
4606
4607         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4608         * objfiles.h (objfile::reset_psymtabs): New method.
4609
4610 2019-01-10  Tom Tromey  <tom@tromey.com>
4611
4612         * symmisc.c (print_symbol_bcache_statistics): Update.
4613         (print_objfile_statistics): Update.
4614         * symfile.c (reread_symbols): Update.
4615         * psymtab.h (class psymtab_storage): New.
4616         * psymtab.c (psymtab_storage): New constructor.
4617         (~psymtab_storage): New destructor.
4618         (require_partial_symbols): Update.
4619         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4620         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4621         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4622         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4623         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4624         (start_psymtab_common, end_psymtab_common)
4625         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4626         (allocate_psymtab): Update.
4627         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4628         Update.
4629         (dump_psymtab_addrmap, maintenance_print_psymbols)
4630         (maintenance_check_psymtabs): Update.
4631         (class objfile_psymtabs): Move to objfiles.h.
4632         * psympriv.h (discard_psymtab): Now inline.
4633         (psymtab_discarder::psymtab_discarder): Update.
4634         (psymtab_discarder::~psymtab_discarder): Update.
4635         (ALL_OBJFILE_PSYMTABS): Rewrite.
4636         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4637         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4638         Remove fields.
4639         <partial_symtabs>: New field.
4640         (class objfile_psymtabs): Move from psymtab.h.  Update.
4641         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4642         psymbol_cache.
4643         (objfile::~objfile): Don't destroy psymbol_cache.
4644         * mdebugread.c (parse_partial_symbols): Update.
4645         * dwarf2read.c (create_addrmap_from_index)
4646         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4647         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4648         (add_partial_subprogram, dwarf2_ranges_read): Update.
4649         * dwarf-index-write.c (write_address_map)
4650         (write_one_signatured_type, recursively_write_psymbols)
4651         (class debug_names, class debug_names, write_psymtabs_to_index):
4652         Update.
4653
4654 2019-01-10  Tom Tromey  <tom@tromey.com>
4655
4656         * symtab.h (SYMBOL_SET_NAMES): Update.
4657         (symbol_set_names): Update.
4658         (MSYMBOL_SET_NAMES): Update.
4659         * symtab.c (symbol_set_names): Change argument to be an
4660         objfile_per_bfd_storage.
4661         * psymtab.c (add_psymbol_to_bcache): Update.
4662         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4663
4664 2019-01-10  Tom Tromey  <tom@tromey.com>
4665
4666         * symtab.c (create_demangled_names_hash): Change argument to be an
4667         objfile_per_bfd_storage.
4668         (symbol_set_names): Update.
4669
4670 2019-01-10  Tom Tromey  <tom@tromey.com>
4671
4672         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4673         init_psymbol_list.
4674         * psymtab.c (init_psymbol_list): Do nothing if already called.
4675         * psympriv.h (init_psymbol_list): Add comment.
4676         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4677         init_psymbol_list.
4678         * dbxread.c (dbx_symfile_read): Unconditionally call
4679         init_psymbol_list.
4680
4681 2019-01-10  Tom Tromey  <tom@tromey.com>
4682
4683         * xcoffread.c (scan_xcoff_symtab): Update.
4684         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4685         "where".
4686         * mdebugread.c (parse_partial_symbols)
4687         (handle_psymbol_enumerators): Update.
4688         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4689         * dbxread.c (read_dbx_symtab): Update.
4690         * psympriv.h (psymbol_placement): New enum.
4691         (add_psymbol_to_list): Update.
4692
4693 2019-01-10  Tom Tromey  <tom@tromey.com>
4694
4695         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4696         static_psymbols parameters.
4697         (scan_xcoff_symtab): Update.
4698         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4699         static_psymbols parameters.
4700         * psympriv.h (start_psymtab_common): Update.
4701         * mdebugread.c (parse_partial_symbols): Update.
4702         * dwarf2read.c (create_partial_symtab): Update.
4703         * dbxread.c (read_dbx_symtab): Update.
4704         (start_psymtab): Remove global_psymbols and static_psymbols
4705         parameters.
4706
4707 2019-01-10  Tom Tromey  <tom@tromey.com>
4708
4709         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4710         * psymtab.c (allocate_psymtab): Add comment.
4711         * psympriv.h (allocate_psymtab): Add comment.
4712         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4713         initializations.
4714         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4715
4716 2019-01-10  Tom Tromey  <tom@tromey.com>
4717
4718         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4719         Don't declare.
4720         * mipsread.c: Include mdebugread.h.
4721         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4722         Declare.
4723         * elfread.c: Include mdebugread.h.
4724
4725 2019-01-09  Tom Tromey  <tom@tromey.com>
4726
4727         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4728         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4729         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4730         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4731         (psym_lookup_symbol, psym_find_last_source_symtab)
4732         (psym_forget_cached_source_info, psym_print_stats)
4733         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4734         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4735         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4736         (psym_find_compunit_symtab_by_address)
4737         (maintenance_print_psymbols, maintenance_info_psymtabs)
4738         (maintenance_check_psymtabs): Use ranged for.
4739         * psymtab.h (class objfile_psymtabs): New.
4740         (require_partial_symbols): Return objfile_psymtabs.
4741         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4742
4743 2019-01-09  Tom Tromey  <tom@tromey.com>
4744
4745         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4746         (find_pc_mapped_section, list_overlays_command)
4747         (map_overlay_command, unmap_overlay_command)
4748         (simple_overlay_update): Use all_objfiles.
4749         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4750         * printcmd.c (info_symbol_command): Use all_objfiles.
4751         * objfiles.h (ALL_OBJSECTIONS): Remove.
4752         * maint.c (maintenance_translate_address): Use all_objfiles.
4753         * gcore.c (gcore_create_callback): Use all_objfiles.
4754         (objfile_find_memory_regions): Likewise.
4755
4756 2019-01-09  Tom Tromey  <tom@tromey.com>
4757
4758         * symtab.c (find_line_symtab, info_sources_command)
4759         (make_source_files_completion_list): Use objfile_compunits.
4760         * source.c (select_source_symtab): Use objfile_compunits.
4761         * objfiles.h (struct objfile): Update comment.
4762         (ALL_OBJFILES): Remove.
4763         (ALL_FILETABS): Remove.
4764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4765         objfile_compunits.
4766
4767 2019-01-09  Tom Tromey  <tom@tromey.com>
4768
4769         * symmisc.c (print_objfile_statistics, dump_objfile)
4770         (maintenance_print_symbols): Use compunit_filetabs.
4771         * source.c (forget_cached_source_info_for_objfile): Use
4772         compunit_filetabs.
4773         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4774         (ALL_FILETABS): Use compunit_filetabs.
4775         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4776         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4777
4778 2019-01-09  Tom Tromey  <tom@tromey.com>
4779
4780         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4781         (compunit_filetabs): New.
4782         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4783         compunit_filetabs.
4784         (info_sources_command, make_source_files_completion_list): Remove
4785         declaration.
4786         * symmisc.c (print_objfile_statistics, dump_objfile)
4787         (maintenance_print_symbols): Remove declaration.
4788         (maintenance_info_symtabs): Use compunit_filetabs.
4789         (maintenance_info_line_tables): Likewise.
4790         * source.c (select_source_symtab): Change local variable name.
4791         (forget_cached_source_info_for_objfile): Remove declaration.
4792         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4793         * objfiles.c (objfile_relocate1): Remove declaration.
4794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4795         declaration.
4796         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4797         * coffread.c (coff_symtab_read): Remove declaration.
4798         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4799         compunit_filetabs.
4800
4801 2019-01-09  Tom Tromey  <tom@tromey.com>
4802
4803         * symtab.c (lookup_objfile_from_block)
4804         (find_pc_sect_compunit_symtab, search_symbols)
4805         (default_collect_symbol_completion_matches_break_on): Use
4806         objfile_compunits.
4807         * objfiles.h (ALL_COMPUNITS): Remove.
4808         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4809         * cp-support.c (add_symbol_overload_list_qualified): Use
4810         objfile_compunits.
4811         * ada-lang.c (ada_collect_symbol_completion_matches)
4812         (ada_add_global_exceptions): Use objfile_compunits.
4813
4814 2019-01-09  Tom Tromey  <tom@tromey.com>
4815
4816         * source.c (select_source_symtab)
4817         (forget_cached_source_info_for_objfile): Remove declaration.
4818         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4819         declaration.
4820         * maint.c (count_symtabs_and_blocks): Remove declaration.
4821         * cp-support.c (add_symbol_overload_list_qualified): Remove
4822         declaration.
4823         * coffread.c (coff_symtab_read): Remove declaration.
4824         * symtab.c (lookup_symbol_in_objfile_symtabs)
4825         (basic_lookup_transparent_type_1): Use objfile_compunits.
4826         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4827         (info_sources_command, search_symbols)
4828         (default_collect_symbol_completion_matches_break_on)
4829         (make_source_files_completion_list): Remove declaration.
4830         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4831         (ada_collect_symbol_completion_matches)
4832         (ada_add_global_exceptions): Remove declaration.
4833         * linespec.c (iterate_over_all_matching_symtabs): Use
4834         objfile_compunits.
4835         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4836         (class objfile_compunits): New.
4837         (ALL_COMPUNITS): Use objfile_compunits.
4838         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4839         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4840         objfile_compunits.
4841         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4842
4843 2019-01-09  Tom Tromey  <tom@tromey.com>
4844
4845         * symtab.c (search_symbols)
4846         (default_collect_symbol_completion_matches_break_on): Use
4847         objfile_msymbols.
4848         * ada-lang.c (ada_lookup_simple_minsym)
4849         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4850         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4851         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4852         objfile_msymbols.
4853         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4854         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4855         * objc-lang.c (find_methods): Use objfile_msymbols.
4856         (info_selectors_command, info_classes_command): Likewise.
4857         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4858         * objfiles.h (class objfile_msymbols): New.
4859         (ALL_OBJFILE_MSYMBOLS): Remove.
4860         (ALL_MSYMBOLS): Remove.
4861
4862 2019-01-09  Tom Tromey  <tom@tromey.com>
4863
4864         * common/next-iterator.h (next_adapter): Add Iterator template
4865         parameter.
4866         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4867         (class all_objfiles_safe): New.
4868         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4869         * objfiles.c (put_objfile_before): Update comment.
4870         (add_separate_debug_objfile): Likewise.
4871         (free_all_objfiles): Use all_objfiles_safe.
4872         (objfile_purge_solibs): Likewise.
4873
4874 2019-01-09  Tom Tromey  <tom@tromey.com>
4875
4876         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4877         (expand_symtab_containing_pc, lookup_static_symbol)
4878         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4879         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4880         all_objfiles.
4881         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4882         * breakpoint.c (create_overlay_event_breakpoint)
4883         (create_longjmp_master_breakpoint)
4884         (create_std_terminate_master_breakpoint)
4885         (create_exception_master_breakpoint): Use all_objfiles.
4886         * linux-thread-db.c (try_thread_db_load_from_pdir)
4887         (has_libpthread): Use all_objfiles.
4888         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4889         * linespec.c (iterate_over_all_matching_symtabs)
4890         (search_minsyms_for_name): Use all_objfiles.
4891         * maint.c (maintenance_info_sections): Use all_objfiles.
4892         * main.c (captured_main_1): Use all_objfiles.
4893         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4894         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4895         * guile/scm-pretty-print.c
4896         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4897         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4898         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4899         (maintenance_print_msymbols): Use all_objfiles.
4900         * source.c (select_source_symtab): Use all_objfiles.
4901         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4902         * symfile.c (remove_symbol_file_command)
4903         (expand_symtabs_matching, map_symbol_filenames): Use
4904         all_objfiles.
4905         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4906         all_objfiles.
4907         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4908         * objc-lang.c (find_methods): Use all_objfiles.
4909         * objfiles.c (have_partial_symbols, have_full_symbols)
4910         (have_minimal_symbols, qsort_cmp)
4911         (default_iterate_over_objfiles_in_search_order): Use
4912         all_objfiles.
4913         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4914         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4915         (maintenance_check_psymtabs): Use all_objfiles.
4916         (ALL_PSYMTABS): Remove.
4917         * compile/compile-object-run.c (do_module_cleanup): Use
4918         all_objfiles.
4919         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4920         * cp-support.c (add_symbol_overload_list_qualified): Use
4921         all_objfiles.
4922         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4923         Use all_objfiles.
4924         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4925         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4926         all_objfiles.
4927         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4928         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4929         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4930         Uses all_objfiles.
4931         * solib.c (solib_read_symbols): Use all_objfiles
4932
4933 2019-01-09  Tom Tromey  <tom@tromey.com>
4934
4935         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4936         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4937         all_objfiles.
4938         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4939         * symmisc.c (print_symbol_bcache_statistics)
4940         (print_objfile_statistics, maintenance_print_objfiles)
4941         (maintenance_info_symtabs, maintenance_check_symtabs)
4942         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4943         all_objfiles.
4944         * source.c (forget_cached_source_info): Use all_objfiles.
4945         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4946         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4947         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4948         * objfiles.c (update_section_map): Use all_objfiles.
4949         (shared_objfile_contains_address_p): Likewise.
4950         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4951         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4952
4953 2019-01-09  Tom Tromey  <tom@tromey.com>
4954
4955         * common/next-iterator.h: New file.
4956         * objfiles.h (class all_objfiles): New.
4957         (struct objfile_iterator): New.
4958
4959 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4960
4961         * NEWS: Move the description of the changed "frame", "select-frame",
4962          and "info frame" commands to the Changed commands section.
4963
4964 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4965
4966         * gdbtypes.c (check_stub_method_group): Remove handling of old
4967         mangling schemes.
4968         * linespec.c (find_methods): Likewise.
4969         * stabsread.c (read_member_functions): Likewise.
4970         * valops.c (search_struct_method): Likewise.
4971         (value_struct_elt_for_reference): Likewise.
4972         * NEWS: Mention this change.
4973
4974 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4977         print_source_lines.
4978         * source.c (print_source_lines_base): Update line number check.
4979         (print_source_lines): New function.
4980         (source_lines_range::source_lines_range): New function.
4981         * source.h (class source_lines_range): New class.
4982         (print_source_lines): New declaration.
4983
4984 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4985
4986         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4987
4988 2019-01-08  Tom Tromey  <tom@tromey.com>
4989             Simon Marchi  <simon.marchi@ericsson.com>
4990
4991         PR gdb/24060
4992         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4993         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4994         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4995         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4996         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4997         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4998
4999 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * source.c (select_source_symtab): Move header comment to
5002         declaration in source.h.
5003         (forget_cached_source_info_for_objfile): Likewise.
5004         (forget_cached_source_info): Likewise.
5005         (identify_source_line): Likewise.
5006         * source.h (identify_source_line): Move declaration from symtab.h
5007         and add comment from source.c
5008         (print_source_lines): Likewise.
5009         (forget_cached_source_info_for_objfile): Likewise.
5010         (forget_cached_source_info): Likewise.
5011         (select_source_symtab): Likewise.
5012         (enum print_source_lines_flag): Move definition from symtab.h.
5013         * symtab.h (identify_source_line): Move declaration to source.h.
5014         (print_source_lines): Likewise.
5015         (forget_cached_source_info_for_objfile): Likewise.
5016         (forget_cached_source_info): Likewise.
5017         (select_source_symtab): Likewise.
5018         (enum print_source_lines_flag): Move definition to source.h.
5019         * tui/tui-hooks.c: Add 'source.h' include.
5020
5021 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * source.c (print_source_lines_base): Handle requests to print
5024         reverse line number sequences, and guard against empty lines
5025         string.
5026
5027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * source.c (print_source_lines_base): Fix skip of '\r' if next
5030         character is '\n'.
5031
5032 2019-01-06  Tom Tromey  <tom@tromey.com>
5033
5034         * c-exp.y (struct c_parse_state) <macro_original_text,
5035         expansion_obstack>: New member.
5036         (macro_original_text, expansion_obstack): Remove globals.
5037         (scan_macro_expansion, scanning_macro_expansion)
5038         (finished_macro_expansion): Update.
5039         (scan_macro_cleanup): Remove.
5040         (yylex, c_parse): Update.
5041
5042 2019-01-06  Tom Tromey  <tom@tromey.com>
5043
5044         * c-exp.y (struct c_parse_state) <strings>: New member.
5045         (operator_stoken): Update.
5046
5047 2019-01-06  Tom Tromey  <tom@tromey.com>
5048
5049         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5050         (union type_stack_elt) <typelist_val>: Now a pointer to
5051         std::vector.
5052         (type_stack_cleanup): Don't declare.
5053         (push_typelist): Update.
5054         * parse.c (pop_typelist): Return a std::vector.
5055         (push_typelist): Take a std::vector.
5056         (follow_types): Update.  Do not free args.
5057         (type_stack_cleanup): Remove.
5058         * c-exp.y (struct c_parse_state): New.
5059         (cpstate): New global.
5060         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5061         (nonempty_typelist): Update.
5062         (func_mod): Create a new vector.
5063         (c_parse): Create a c_parse_state.
5064         (check_parameter_typelist): Do not delete params.
5065         (function_method): Update.  Do not delete type_list.
5066
5067 2019-01-06  Tom Tromey  <tom@tromey.com>
5068
5069         PR gdb/28155:
5070         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5071         check_typedef.
5072         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5073         (print_return_value): Likewise.
5074
5075 2019-01-05  Tom Tromey  <tom@tromey.com>
5076
5077         * contrib/cleanup_check.py: Remove.
5078         * contrib/gcc-with-excheck: Remove.
5079         * contrib/exsummary.py: Remove.
5080         * contrib/excheck.py: Remove.
5081
5082 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5083
5084         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5085         NULL. Initialize tpprev to NULL instead of assigning it
5086         to NULL on the next statement.
5087         * windows-nat.c (windows_delete_thread): Remove check for
5088         main_thread_id before printing thread exit notifications.
5089         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5090         Remove thread ID check against main_thread_id.
5091         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5092         windows_delete_thread.
5093         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5094
5095 2019-01-04  Tom Tromey  <tom@tromey.com>
5096
5097         * compile/compile.c (_initialize_compile): Use upper case for
5098         metasyntactic variables.
5099         * symmisc.c (_initialize_symmisc): Use upper case for
5100         metasyntactic variables.
5101         * psymtab.c (_initialize_psymtab): Use upper case for
5102         metasyntactic variables.
5103         * demangle.c (demangle_command): Use upper case for metasyntactic
5104         variables.
5105         (_initialize_demangler): Likewise.
5106         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5107         variables.
5108
5109 2019-01-03  Tom Tromey  <tom@tromey.com>
5110
5111         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5112
5113 2019-01-03  Tom Tromey  <tom@tromey.com>
5114
5115         * python/py-symtab.c (salpy_str): Update.
5116         (struct salpy_sal_object) <symtab>: Now a PyObject.
5117         (salpy_dealloc): Update.
5118         (del_objfile_sal): Use gdbpy_ref.
5119
5120 2019-01-03  Tom Tromey  <tom@tromey.com>
5121
5122         * python/py-type.c (convert_field): Use new_reference.  Return
5123         gdbpy_ref.
5124         (make_fielditem): Return gdbpy_ref.
5125         (typy_fields): Update.
5126         (typy_getitem): Update.
5127         (field_name): Return gdbpy_ref.  Use new_reference.
5128         (typy_iterator_iternext): Update.
5129
5130 2019-01-03  Tom Tromey  <tom@tromey.com>
5131
5132         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5133
5134 2019-01-03  Tom Tromey  <tom@tromey.com>
5135
5136         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5137         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5138         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5139         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5140         (pspy_set_type_printers): Likewise.
5141         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5142         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5143         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5144         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5145         (objfpy_set_type_printers): Likewise.
5146
5147 2019-01-03  Tom Tromey  <tom@tromey.com>
5148
5149         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5150         (gdbpy_print_stack): Use gdbpy_err_fetch.
5151         * python/python-internal.h (class gdbpy_err_fetch): New class.
5152         (class gdbpy_enter) <m_error_type, m_error_value,
5153         m_error_traceback>: Remove.
5154         <m_error>: New member.
5155         (gdbpy_exception_to_string): Don't declare.
5156         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5157         * python/py-value.c (convert_value_from_python): Use
5158         gdbpy_err_fetch.
5159         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5160         gdbpy_exception_to_string.
5161         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5162         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5163         gdbpy_err_fetch.
5164
5165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * linux-nat.c (delete_lwp_cleanup): Delete.
5168         (struct lwp_deleter): New struct.
5169         (lwp_info_up): New typedef.
5170         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5171         lwp_info_up.
5172
5173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * linux-fork.c (class scoped_switch_fork_info): New class.
5176         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5177
5178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5179
5180         * valops.c (find_overload_match): Remove use of null_cleanup, and
5181         calls to do_cleanups.
5182
5183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * compile/compile-cplus-types.c
5186         (compile_cplus_instance::decl_name): Handle changes to
5187         cp_func_name.
5188         * cp-support.c (cp_func_name): Update header comment, update
5189         return type.
5190         * cp-support.h (cp_func_name): Update return type in declaration.
5191         * valops.c (find_overload_match): Move temp_func local to top
5192         level of function and change its type.  Use temp_func to hold and
5193         delete temporary string obtained from cp_func_name.
5194
5195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5198         gdb::char_vector, remove cleanup, and update uses of `msg`.
5199
5200 2019-01-03  Jim Wilson  <jimw@sifive.com>
5201
5202         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5203
5204 2019-01-02  Tom Tromey  <tom@tromey.com>
5205
5206         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5207         (tdesc_parse_xml): Remove cleanups.
5208         * target-descriptions.h (make_cleanup_free_target_description):
5209         Don't declare.
5210         (target_desc_deleter): New struct.
5211         (target_desc_up): New typedef.
5212         * target-descriptions.c (target_desc_deleter::operator()): Rename
5213         from free_target_description.
5214         (make_cleanup_free_target_description): Remove.
5215
5216 2019-01-02  Tom Tromey  <tom@tromey.com>
5217
5218         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5219         constructor, destructor.
5220         (linespec_parser): Remove typedef.
5221         (~linespec_parser): Rename from linespec_parser_delete.
5222         (linespec_lex_to_end, linespec_complete_label)
5223         (linespec_complete): Update.
5224         (decode_line_full): Remove cleanups.
5225         (decode_line_1): Update.
5226
5227 2019-01-02  Tom Tromey  <tom@tromey.com>
5228
5229         * python/python-internal.h (inferior_to_inferior_object): Change
5230         return type.
5231         * python/py-exitedevent.c (create_exited_event_object): Update.
5232         * python/py-inferior.c (inferior_to_inferior_object): Return
5233         gdbpy_ref.
5234         (python_new_inferior, python_inferior_deleted)
5235         (thread_to_thread_object, delete_thread_object)
5236         (build_inferior_list, gdbpy_selected_inferior): Update.
5237         * python/py-infthread.c (create_thread_object): Update.  Also fail
5238         if inferior_to_inferior_object fails.
5239
5240 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5241
5242         * inferior.h (class inferior) <displaced_step_state>: New field.
5243         * infrun.h (struct displaced_step_state): Move here from
5244         infrun.c.  Initialize fields, add constructor.
5245         <inf>: Remove field.
5246         <reset>: New method.
5247         * infrun.c (struct displaced_step_inferior_state): Move to
5248         infrun.h.
5249         (displaced_step_inferior_states): Remove.
5250         (get_displaced_stepping_state): Adust.
5251         (displaced_step_in_progress_any_inferior): Adjust.
5252         (displaced_step_in_progress_thread): Adjust.
5253         (displaced_step_in_progress): Adjust.
5254         (add_displaced_stepping_state): Remove.
5255         (get_displaced_step_closure_by_addr): Adjust.
5256         (remove_displaced_stepping_state): Remove.
5257         (infrun_inferior_exit): Call displaced_step_state.reset.
5258         (use_displaced_stepping): Don't check for NULL.
5259         (displaced_step_prepare_throw): Call
5260         get_displaced_stepping_state.
5261         (displaced_step_fixup): Don't check for NULL.
5262         (prepare_for_detach): Don't check for NULL.
5263
5264 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5265
5266         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5267          in case of call that did not complete.
5268
5269 2019-01-02  Andrey Utkin  <autkin@undo.io>
5270
5271         * symfile.c (find_separate_debug_file): Fix search of debug files for
5272         remote debuggee.
5273
5274 2019-01-02  Tom Tromey  <tom@tromey.com>
5275
5276         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5277         indentation.
5278         * python/py-frame.c (frapy_older): Remove cast.
5279         (frapy_newer): Likewise.
5280         * python/py-breakpoint.c (local_setattro): Remove cast.
5281         * python/py-arch.c (archpy_name): Remove local variable.
5282         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5283
5284 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5285
5286         * unittests/basic_string_view/element_access/char/empty.cc:
5287         Fix year range in copyright header.
5288
5289 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5292         Delete.
5293         <operator==>: Update with for removed field.
5294         <hash>: Likewise.
5295         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5296         <isa_features>: ...this.
5297         <abi_features>: New field.
5298         (riscv_isa_flen): Update comment.
5299         (riscv_abi_xlen): New declaration.
5300         (riscv_abi_flen): New declaration.
5301         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5302         isa_features.
5303         (riscv_abi_xlen): New function.
5304         (riscv_isa_flen): Update to get answer from isa_features.
5305         (riscv_abi_flen): New function.
5306         (riscv_has_fp_abi): Update to get answer from abi_features.
5307         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5308         xlen and flen.
5309         (riscv_call_info) <xlen, flen>: Update comment.
5310         (riscv_call_arg_struct): Remove invalid assertions
5311         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5312         is removed.
5313         (riscv_gdbarch_init): Gather isa features and abi features
5314         separately, ensure both match on the gdbarch when reusing an old
5315         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5316         a target with 64-bit float hardware.
5317
5318 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5319
5320         * source.c (search_command_helper): Stop reverse search
5321         when line 1 has been searched.
5322
5323 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5324
5325         * record-full.c (record_full_base_target::close): Rewrite
5326         record_full_core_buf_list free logic.
5327
5328 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5329
5330         * break-catch-syscall.c (print_one_catch_syscall): xfree
5331         the last text.
5332
5333 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5334
5335         * top.c (print_gdb_version): Update Copyright year in version
5336         message.
5337
5338 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5339
5340         Update copyright year range in all GDB files.
5341
5342 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5343
5344         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5345
5346 For older changes see ChangeLog-2018.
5347 \f
5348 Local Variables:
5349 mode: change-log
5350 left-margin: 8
5351 fill-column: 74
5352 version-control: never
5353 coding: utf-8
5354 End:
5355