gdb: Allow quoting around string options in the gdb::option framework
[external/binutils.git] / gdb / ChangeLog
1 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4         to extract string arguments.
5         * common/common-utils.c (extract_string_maybe_quoted): New function.
6         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7
8 2019-07-11  Tom Tromey  <tromey@adacore.com>
9
10         * main.c (get_init_files): Use GDBINIT, not gdbinit.
11         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
12         * top.h (gdbinit): Don't declare.
13         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
14         into...
15         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
16         * top.c (gdb_init): Don't call init_cli_cmds.
17         (gdbinit): Remove.
18         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
19
20 2019-07-11  Tom Tromey  <tromey@adacore.com>
21
22         * python/py-inferior.c (add_thread_object): Don't use thread_obj
23         after it has been moved.
24
25 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
26
27         * valops.c (value_must_coerce_to_target): Change return type to
28         bool.
29         * value.h (value_must_coerce_to_target): Likewise.
30
31 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
32
33         * breakpoint.c (is_hardware_watchpoint): Remove
34         forward-declaration.
35         (is_masked_watchpoint): Change return type to bool.
36         (is_tracepoint): Likewise.
37         (is_breakpoint): Likewise.
38         (is_hardware_watchpoint): Likewise.
39         (is_watchpoint): Likewise.
40         (is_no_memory_software_watchpoint): Likewise.
41         (is_catchpoint): Likewise.
42         (breakpoint_1): Make FILTER parameter's return type bool.
43         is_masked_watchpoint): Change return type to bool.
44         (save_breakpoints): Make FILTER parameter's return type bool.
45         * breakpoint.h (is_breakpoint): Change return type to bool.
46         (is_watchpoint): Likewise.
47         (is_catchpoint): Likewise.
48         (is_tracepoint): Likewise.
49
50 2019-07-10  Tom Tromey  <tom@tromey.com>
51
52         * defs.h: Don't include gdbarch.h.
53         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
54         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
55         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
56         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
57         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
58         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
59         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
60         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
61         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
62         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
63         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
64         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
65         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
66         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
67         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
68         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
69         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
70         record-btrace.c, record.h, regcache-dump.c, regcache.h,
71         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
72         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
73         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
74         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
75         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
76         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
77         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
78         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
79         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
80
81 2019-07-10  Tom Tromey  <tromey@adacore.com>
82
83         * ada-lang.h (is_ada_exception_catchpoint): Declare.
84         * breakpoint.c (init_ada_exception_breakpoint): Register as
85         bp_catchpoint.
86         (print_one_breakpoint_location, print_one_breakpoint): Use
87         is_ada_exception_catchpoint.
88         * ada-lang.c (class ada_catchpoint_location): Pass
89         bp_loc_software_breakpoint to bp_location constructor.
90         (is_ada_exception_catchpoint): New function.
91
92 2019-07-10  Tom Tromey  <tromey@adacore.com>
93
94         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
95         VEC.
96         (struct arm_exidx_entry): New method operator<.
97         (struct arm_exidx_data) <section_maps>: Change type.
98         (arm_exidx_data_free): Remove.
99         (arm_exidx_data_key): Change type.  Move lower.
100         (arm_exidx_new_objfile): Update.
101         (arm_compare_exidx_entries): Remove.
102         (arm_find_exidx_entry, _initialize_arm_tdep)
103
104 2019-07-10  Tom Tromey  <tromey@adacore.com>
105
106         * solib-spu.c (ocl_program_data_key): Change type.
107         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
108         Update.
109
110 2019-07-10  Tom Tromey  <tromey@adacore.com>
111
112         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
113         (struct solib_aix_inferior_data) <library_list>: Change type.
114         (solib_aix_inferior_data_handle): Change type.
115         (get_solib_aix_inferior_data): Update.
116         (solib_aix_free_library_list): Remove.
117         (library_list_start_library): Update.
118         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
119         return type.
120         (solib_aix_get_library_list)
121         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
122         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
123
124 2019-07-10  Tom Tromey  <tromey@adacore.com>
125
126         * solib-dsbt.c (struct dsbt_info): Add initializers.
127         (solib_dsbt_pspace_data): Change type.
128         (dsbt_pspace_data_cleanup): Remove.
129         (get_dsbt_info, _initialize_dsbt_solib): Update.
130
131 2019-07-10  Tom Tromey  <tromey@adacore.com>
132
133         * spu-tdep.c (spu_overlay_data): Change type.
134         (spu_get_overlay_table, spu_overlay_new_objfile)
135         (_initialize_spu_tdep): Update.
136
137 2019-07-10  Tom Tromey  <tromey@adacore.com>
138
139         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
140         destructor.
141         (dbx_objfile_data_key): Change type and declare later.
142         (DBX_SYMFILE_INFO): Rewrite.
143         * dbxread.c (dbx_objfile_data_key): Change type.
144         (dbx_symfile_init): Update.
145         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
146         (coffstab_build_psymtabs, elfstab_build_psymtabs)
147         (stabsect_build_psymtabs, _initialize_dbxread): Update.
148
149 2019-07-10  Tom Tromey  <tromey@adacore.com>
150
151         * jit.c (jit_program_space_key): Change type.  Move lower.
152         (get_jit_program_space_data): Update.
153         (jit_program_space_data_cleanup): Remove.
154         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
155         Update.
156         (struct jit_program_space_data): Add initializers.
157
158 2019-07-10  Tom Tromey  <tromey@adacore.com>
159
160         * solib-darwin.c (struct darwin_info): Add initializers.
161         (solib_darwin_pspace_data): Change type.
162         (darwin_pspace_data_cleanup): Remove.
163         (get_darwin_info, _initialize_darwin_solib): Update.
164
165 2019-07-10  Tom Tromey  <tromey@adacore.com>
166
167         * remote-sim.c (struct sim_inferior_data): Add initializers,
168         constructor, and destructor.
169         (sim_inferior_data_key): Change type.  Move lower.
170         (check_for_duplicate_sim_descriptor): Update.
171         (get_sim_inferior_data): Use new.  Update.
172         (~sim_inferior_data_cleanup): Rename from
173         sim_inferior_data_cleanup.  Simplify.
174         (gdbsim_close_inferior, simulator_command)
175         (sim_command_completer, _initialize_remote_sim): Update.
176         (next_pid, INITIAL_PID): Move earlier.
177
178 2019-07-10  Tom Tromey  <tromey@adacore.com>
179
180         * python/python-internal.h (create_thread_object): Return
181         gdbpy_ref.
182         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
183         * python/py-inferior.c (struct threadlist_entry): Add
184         constructor.
185         <thread_obj>: Now a gdbpy_ref.
186         (thread_to_thread_object): Update.
187         (add_thread_object): Use new.
188         (delete_thread_object): Use delete.
189         (infpy_threads): Update.
190         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
191         GIL.
192
193 2019-07-10  Tom Tromey  <tromey@adacore.com>
194
195         * valops.c (value_cast): Specialize error message for Ada.
196
197 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
198
199         * breakpoint.c (breakpoint_1): Update doc and parameter names.
200
201 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
202
203         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
204         bpstat_should_step): Return bool, adjust comments.
205         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
206         bpstat_should_step): Likewise.
207
208 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
209
210         * features/Makefile: Use feature target descriptions for Arm.
211         * features/arm/arm-core.c: Generate new file.
212         * features/arm/arm-fpa.c: Likewise.
213         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
214         * features/arm/arm-m-profile.c: Likewise.
215         * features/arm/arm-vfpv2.c: Likewise.
216         * features/arm/arm-vfpv3.c: Likewise.
217         * features/arm/xscale-iwmmxt.c: Likewise.
218         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
219
220 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
221
222         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
223         ptrace earlier.
224
225 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
226
227         * features/aarch64-pauth.c: Regenerate.
228
229 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
230
231         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
232         bool.
233         (bpstat_what): Use false instead of 0.
234
235 2019-07-09  Pedro Alves  <palves@redhat.com>
236
237         * break-catch-throw.c (is_exception_catchpoint): New.
238         * breakpoint.c (print_one_breakpoint_location): New parameter
239         'raw_loc'.  Handle it.  Use
240         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
241         looking at the breakpoint's type.
242         (print_one_breakpoint): If handling "maint info breakpoints", also
243         print locations of exception catchpoints.
244         * breakpoint.h (is_exception_catchpoint): Declare.
245
246 2019-07-09  Pedro Alves  <palves@redhat.com>
247
248         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
249         "addr" field.
250         (allocate_location_exception_catchpoint): New.
251         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
252         (initialize_throw_catchpoint_ops): Install
253         allocate_location_exception_catchpoint as allocate_location
254         method.
255         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
256         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
257         bp_loc_other.
258         (breakpoint_address_is_meaningful): Delete.
259         (bl_address_is_meaningful): New.
260         (breakpoint_locations_match): Adjust comment.
261         (bp_location_from_bp_type): New, factored out of...
262         (bp_location::bp_location(breakpoint *)): ... this.
263         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
264         factored out of...
265         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
266         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
267         breakpoint_address_is_meaningful.
268         (bp_locations_compare): Adjust comment.
269         (update_global_location_list): Use bl_address_is_meaningful
270         instead of breakpoint_address_is_meaningful.
271         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
272         explicit.
273         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
274         * python/py-breakpoint.c (bppy_get_location): No longer check
275         whether location is null.
276
277 2019-07-09  Pedro Alves  <palves@redhat.com>
278
279         PR c++/15468
280         * breakpoint.c (print_one_breakpoint_location): Remove
281         single-location assert.
282
283 2019-07-09  Tom Tromey  <tom@tromey.com>
284
285         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
286         * configure: Rebuild.
287         * configure.ac: Change common to gdbsupport.
288         * gdbsupport: Rename from common.
289         * acinclude.m4: Change common to gdbsupport.
290         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
291         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
292         gdbsupport.
293         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
294         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
295         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
296         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
297         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
298         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
299         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
300         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
301         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
302         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
303         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
304         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
305         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
306         coff-pe-read.c, command.h, compile/compile-c-support.c,
307         compile/compile-c.h, compile/compile-cplus-symbols.c,
308         compile/compile-cplus-types.c, compile/compile-cplus.h,
309         compile/compile-loc2c.c, compile/compile.c, completer.c,
310         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
311         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
312         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
313         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
314         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
315         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
316         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
317         features/aarch64-core.c, features/aarch64-fpu.c,
318         features/aarch64-pauth.c, features/aarch64-sve.c,
319         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
320         features/i386/32bit-core.c, features/i386/32bit-linux.c,
321         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
322         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
323         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
324         features/i386/64bit-core.c, features/i386/64bit-linux.c,
325         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
326         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
327         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
328         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
329         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
330         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
331         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
332         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
333         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
334         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
335         go32-nat.c, guile/guile.c, guile/scm-ports.c,
336         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
337         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
338         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
339         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
340         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
341         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
342         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
343         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
344         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
345         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
346         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
347         minsyms.c, mips-linux-tdep.c, namespace.h,
348         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
349         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
350         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
351         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
352         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
353         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
354         nat/linux-waitpid.c, nat/mips-linux-watch.c,
355         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
356         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
357         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
358         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
359         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
360         procfs.c, producer.c, progspace.h, psymtab.h,
361         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
362         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
363         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
364         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
365         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
366         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
367         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
368         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
369         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
370         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
371         target-memory.c, target.c, target.h, target/waitstatus.c,
372         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
373         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
374         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
375         unittests/array-view-selftests.c,
376         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
377         unittests/common-utils-selftests.c,
378         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
379         unittests/format_pieces-selftests.c,
380         unittests/function-view-selftests.c,
381         unittests/lookup_name_info-selftests.c,
382         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
383         unittests/mkdir-recursive-selftests.c,
384         unittests/observable-selftests.c,
385         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
386         unittests/parse-connection-spec-selftests.c,
387         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
388         unittests/scoped_fd-selftests.c,
389         unittests/scoped_mmap-selftests.c,
390         unittests/scoped_restore-selftests.c,
391         unittests/string_view-selftests.c, unittests/style-selftests.c,
392         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
393         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
394         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
395         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
396         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
397         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
398
399 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
400
401         * linespec.c (decode_digits_list_mode): Set explicit_line to a
402         bool value.
403         (decode_digits_ordinary): Set explicit_line field in sal.
404         * symtab.c (skip_prologue_sal): Don't skip prologue for a
405         symtab_and_line that was set on an explicit line number in
406         assembler code.  Do always update the recorded symtab and line if
407         we do skip the prologue.
408
409 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
410
411         * breakpoint.c (set_breakpoint_location_function): Remove
412         explicit_loc parameter.
413         (momentary_breakpoint_from_master): Update call to
414         set_breakpoint_location_function.
415         (add_location_to_breakpoint): Likewise.
416
417 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
418
419         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
420         required features based on default bfd type when no specific bfd
421         is present.
422
423 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
424
425         * NEWS: Mention that GDB printf and eval commands can now print
426         C-style and Ada-style convenience var strings without
427         calling the inferior.
428         * printcmd.c (printf_c_string): Locally print GDB internal var
429         instead of transiting via the inferior.
430         (printf_wide_c_string): Likewise.
431
432 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
433
434         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
435
436 2019-07-04  Tom Tromey  <tom@tromey.com>
437
438         PR tui/24724:
439         * tui/tui-winsource.c (tui_clear_source_content): Update.
440         (tui_source_window_base::set_is_exec_point_at): Fix comment.
441         (tui_update_breakpoint_info): Update.
442         (tui_set_exec_info_content): Update.
443         * tui/tui-source.c (tui_set_source_content_nil): Update.
444         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
445         has_break.
446         * tui/tui-data.h (enum tui_bp_flag): New.
447         (tui_bp_flags): New enum flags type.
448         (struct tui_source_element) <break_mode>: Change type.  Rename
449         from has_break.
450         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
451         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
452         constants.
453         * tui/tui-winsource.h: Fix comment.
454
455 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
456
457         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
458         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
459         (store_fpregs_to_thread)
460         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
461         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
462         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
463         (IWMMXT_REGS_SIZE): Add define.
464         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
465         (fetch_vfp_regs, store_vfp_regs)
466         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
467         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
468
469 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
470
471         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
472         defines.
473         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
474         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
475         (ARM_INT_REGISTER_SIZE): ...to this.
476         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
477         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
478         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
479         (arm_linux_collect_gregset, supply_nwfpe_register)
480         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
481         defines.
482         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
483         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
484         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
485         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
486         (arm_return_in_memory, arm_store_return_value)
487         (arm_get_longjmp_target, arm_register_g_packet_guesses)
488         (arm_record_ld_st_multiple): Likewise.
489         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
490         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
491
492 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
493
494         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
495         AARCH64_DISPLACED_MODIFIED_INSNS.
496         * aarch64-tdep.c (struct aarch64_displaced_step_data)
497         (aarch64_displaced_step_copy_insn): Likewise.
498         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
499         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
500         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
501         ARM_DISPLACED_MODIFIED_INSNS.
502         * arm-tdep.c (arm_gdbarch_init): Likewise.
503         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
504         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
505         (struct arm_displaced_step_closure): Use
506         ARM_DISPLACED_MODIFIED_INSNS.
507
508 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
509
510         * features/Makefile: Remove unused xml files.
511         * features/aarch64.xml: Remove.
512         * features/i386/amd64-avx-avx512-linux.xml: Remove.
513         * features/i386/amd64-avx-avx512.xml: Remove.
514         * features/i386/amd64-avx-linux.xml: Remove.
515         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
516         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
517         * features/i386/amd64-avx-mpx-linux.xml: Remove.
518         * features/i386/amd64-avx-mpx.xml: Remove.
519         * features/i386/amd64-avx.xml: Remove.
520         * features/i386/amd64-linux.xml: Remove.
521         * features/i386/amd64-mpx-linux.xml: Remove.
522         * features/i386/amd64-mpx.xml: Remove.
523         * features/i386/amd64.xml: Remove.
524         * features/i386/i386-avx-avx512-linux.xml: Remove.
525         * features/i386/i386-avx-avx512.xml: Remove.
526         * features/i386/i386-avx-linux.xml: Remove.
527         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
528         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
529         * features/i386/i386-avx-mpx-linux.xml: Remove.
530         * features/i386/i386-avx-mpx.xml: Remove.
531         * features/i386/i386-avx.xml: Remove.
532         * features/i386/i386-linux.xml: Remove.
533         * features/i386/i386-mmx-linux.xml: Remove.
534         * features/i386/i386-mmx.xml: Remove.
535         * features/i386/i386-mpx-linux.xml: Remove.
536         * features/i386/i386-mpx.xml: Remove.
537         * features/i386/i386.xml: Remove.
538         * features/i386/x32-avx-avx512-linux.xml: Remove.
539         * features/i386/x32-avx-linux.xml: Remove.
540         * features/i386/x32-linux.xml: Remove.
541
542 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
543
544         * regformats/aarch64.dat: Remove.
545         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
546         * regformats/i386/amd64-avx-linux.dat: Remove.
547         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
548         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
549         * regformats/i386/amd64-linux.dat: Remove.
550         * regformats/i386/amd64-mpx-linux.dat: Remove.
551         * regformats/i386/amd64.dat: Remove.
552         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
553         * regformats/i386/i386-avx-linux.dat: Remove.
554         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
555         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
556         * regformats/i386/i386-linux.dat: Remove.
557         * regformats/i386/i386-mmx-linux.dat: Remove.
558         * regformats/i386/i386-mpx-linux.dat: Remove.
559         * regformats/i386/i386.dat: Remove.
560         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
561         * regformats/i386/x32-avx-linux.dat: Remove.
562         * regformats/i386/x32-linux.dat: Remove.
563
564 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
565
566         * aarch64-tdep.c: Remove xml self tests.
567         * amd64-linux-tdep.c: Likewise.
568         * amd64-tdep.c: Likewise.
569         * i386-linux-tdep.c: Likewise.
570         * i386-tdep.c: Likewise.
571
572 2019-07-03  Pedro Alves  <palves@redhat.com>
573
574         PR cli/24732
575         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
576         (pipe_cmd_option_defs): New.
577         (make_pipe_cmd_options_def_group): New.
578         (pipe_command): Use gdb::option::process_options.
579         (pipe_command_completer): New function.
580         (_initialize_cli_cmds): Install completer for "pipe" command.
581
582 2019-07-03  Pedro Alves  <palves@redhat.com>
583
584         * cli/cli-option.c (union option_value) <string>: New field.
585         (struct option_def_and_value): Add ctor, move ctor, dtor and
586         use DISABLE_COPY_AND_ASSIGN.
587         (option_def_and_value::clear_value): New.
588         (parse_option, save_option_value_in_ctx, get_val_type_str)
589         (add_setshow_cmds_for_options): Handle var_string.
590         * cli-option.h (union option_def::var_address) <string>: New
591         field.
592         (struct string_option_def): New.
593         * maint-test-options.c (struct test_options_opts): Add default
594         ctor and use DISABLE_COPY_AND_ASSIGN.
595         <string_opt>: New field.
596         (test_options_opts::~test_options_opts): New.
597         (test_options_opts::dump): Also dump "-string".
598         (test_options_option_defs): Install "string.
599
600 2019-07-03  Pedro Alves  <palves@redhat.com>
601
602         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
603         option_value with a null enumeration.
604         (complete_options): Save the option values in the context.
605         (save_option_value_in_ctx): New, factored out from ...
606         (process_options): ... here.
607         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
608         of the function.
609         * maint-test-options.c (test_options_opts::dump): New, factored
610         out from ...
611         (maintenance_test_options_command_mode): ... here.
612         (maintenance_test_options_command_completion_result): Delete.
613         (maintenance_test_options_command_completion_text): Update
614         comment.
615         (maintenance_show_test_options_completion_result): Change
616         prototype.  Just print
617         maintenance_test_options_command_completion_text.
618         (save_completion_result): New.
619         (maintenance_test_options_completer_mode): Pass options context to
620         complete_options, and then save a dump.
621         (_initialize_maint_test_options): Use add_cmd to install "maint
622         show test-options-completion-result".
623
624 2019-07-03  Pedro Alves  <palves@redhat.com>
625
626         * NEWS (New commands): Mention "with" and "maint with".
627         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
628         (with_command, with_command_completer): New.
629         (pipe_command): Adjust to new repeat_previous
630         interface.
631         (_initialize_cli_cmds): Install the "with" command and its "w"
632         alias.
633         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
634         declarations.
635         * cli/cli-setshow.c (parse_cli_var_uinteger)
636         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
637         argument strings for all var_types.
638         (get_setshow_command_value_string): New, factored out from ...
639         (do_show_command): ... this.
640         * cli/cli-setshow.h: Include <string>.
641         (get_setshow_command_value_string): Declare.
642         * command.h (repeat_previous): Now returns const char *.  Adjust
643         comment.
644         * maint.c: Include "cli/cli-cmds.h".
645         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
646         (_initialize_maint_cmds): Register the "maintenance with" command.
647         * top.c (repeat_previous): Move bits from pipe_command here:
648         Return the saved command line, if any; error out if there's no
649         command to relaunch.
650
651 2019-07-03  Pedro Alves  <palves@redhat.com>
652
653         * NEWS (New commands): Mention "maint set/show test-settings"
654         instead of "maint test-settings".
655         * maint-test-settings.c (maintenance_test_settings_list): Delete.
656         (maintenance_test_settings_set_list): Rename to ...
657         (maintenance_set_test_settings_list): ... this.
658         (maintenance_test_settings_show_list): Rename to  ...
659         (maintenance_show_test_settings_list): ... this.
660         (maintenance_test_settings_cmd): Delete.
661         (maintenance_test_settings_set_cmd): ...
662         (maintenance_set_test_settings_cmd): ... this.
663         (maintenance_test_settings_show_cmd): ...
664         (maintenance_show_test_settings_cmd): ... this.
665         (maintenance_test_settings_show_value_cmd):
666         (maintenance_show_test_settings_value_cmd): ... this.
667         (_initialize_maint_test_settings): No longer install the "maint
668         test-settings" prefix command.  Rename "maint test-settings set"
669         to "maint set test-settings", and "maint test-settings show" to
670         "maint show test-settings".  Adjust all subcommands.
671
672 2019-07-03  Pedro Alves  <palves@redhat.com>
673
674         * maint-test-settings.c: Fix file's intro comment.  Replace all
675         references to "test-options" with references to "test-settings",
676         in comments.
677
678 2019-07-03  Pedro Alves  <palves@redhat.com>
679
680         * maint-test-settings.c (maintenance_test_settings_xxx)
681         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
682         New.
683         (maintenance_test_settings_enums): Use them.
684         (maintenance_test_settings_enum): Default to
685         maintenance_test_settings_xxx.
686         (_initialize_maint_test_settings): Initialize
687         MAINTENANCE_TEST_SETTINGS_FILENAME.
688
689 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
690
691         * breakpoint.h (remove_breakpoints_inf): Change return type to
692         void, move function documentation here.
693         * breakpoint.c (remove_breakpoints_inf): Change return type to
694         void, move function documentation to header.
695
696 2019-07-02  Pedro Alves  <palves@redhat.com>
697
698         * NEWS (Completion improvements): Mention "info threads".
699         * thread.c (struct info_threads_opts, info_threads_option_defs)
700         (make_info_threads_options_def_group): New.
701         (info_threads_command): Use gdb::option::process_options.
702         (info_threads_command_completer): New.
703         (_initialize_thread): Use gdb::option::build_help to build the
704         help text for "info threads".
705
706 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
707
708         * defs.h (generic_load): Move from here...
709         * symfile.h (generic_load): ... to here.  Rename name parameter
710         to args.
711         * symfile.c (generic_load): Add comment.
712
713 2019-07-01  Tom Tromey  <tromey@adacore.com>
714
715         * dwarf2read.c
716         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
717         declaration of without_params.  Fix formatting.
718
719 2019-07-01  Tom Tromey  <tromey@adacore.com>
720
721         * ada-exp.y (find_primitive_type): Update.
722         * ada-lang.h (ada_lookup_symbol): Update.
723         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
724         parameter.
725         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
726
727 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
728
729         PR breakpoints/24541
730         * gdbarch.c: Regenerate.
731         * gdbarch.h: Regenerate.
732         * gdbarch.sh: Add 'stap_adjust_register'.
733         * i386-tdep.c: Include '<unordered_set>'.
734         (i386_stap_adjust_register): New function.
735         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
736         * stap-probe.c (stap_parse_register_operand): Call
737         'gdbarch_stap_adjust_register'.
738
739 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
740
741         PR python/24742
742         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
743         * python/python.c (do_start_initialization): Use 'xmalloc'
744         instead of 'PyMem_Malloc'.
745
746 2019-06-28  Tom Tromey  <tromey@adacore.com>
747
748         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
749         for Ada.
750
751 2019-06-27  Tom Tromey  <tromey@adacore.com>
752
753         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
754         objfile_key.
755         (arm_find_mapping_symbol, arm_record_special_symbol)
756         (_initialize_arm_tdep): Update.
757         (arm_objfile_data_free): Remove.
758
759 2019-06-27  Tom Tromey  <tromey@adacore.com>
760
761         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
762         to cp_print_static_field.
763
764 2019-06-26  Tom Tromey  <tromey@adacore.com>
765
766         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
767         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
768         declare.
769
770 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
771
772         * features/aarch64-core.c (create_feature_aarch64_core):
773         Regenerate.
774         * features/aarch64-core.xml: Add cpsr flags.
775
776 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
777
778         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
779         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
780
781 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
782
783         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
784         field.
785         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
786         use.
787         (arm_record_special_symbol): Don't insert new symbol in sorted
788         position, push it at the end.
789
790 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
791
792         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
793         (arm_mapping_symbol_s): Remove.
794         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
795         (arm_mapping_symbol_vec): New typedef.
796         (struct arm_per_objfile): Add constructor.
797         <section_maps>: Change type to
798         std::unique_ptr<arm_mapping_symbol_vec[]>.
799         (arm_compare_mapping_symbols): Remove.
800         (arm_find_mapping_symbol): Adjust to section_maps type change.
801         (arm_objfile_data_free): Call delete on arm_per_objfile.
802         (arm_record_special_symbol): Adjust to section_maps type change.
803         Allocate arm_per_objfile with new.
804
805 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
806
807         * cli/cli-cmds.c (alias_command): Compare the alias prefix
808         with the command prefix.
809
810 2019-06-25  Tom Tromey  <tom@tromey.com>
811
812         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
813         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
814
815 2019-06-25  Tom Tromey  <tom@tromey.com>
816
817         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
818         type.
819         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
820         protected.
821
822 2019-06-25  Tom Tromey  <tom@tromey.com>
823
824         * tui/tui-winsource.c
825         (tui_source_window_base::set_is_exec_point_at): Add check against
826         LOA_ADDRESS.
827
828 2019-06-25  Tom Tromey  <tom@tromey.com>
829
830         * tui/tui-source.c (tui_set_source_content): Don't check before
831         xfree.
832         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
833
834 2019-06-25  Tom Tromey  <tom@tromey.com>
835
836         * tui/tui-winsource.h (tui_update_source_window_as_is)
837         (tui_alloc_source_buffer, tui_line_is_displayed)
838         (tui_addr_is_displayed): Change type of win_info.
839         * tui/tui-winsource.c (tui_update_source_window_as_is)
840         (tui_clear_source_content, tui_show_source_line)
841         (tui_show_source_content, tui_source_window_base::refill)
842         (tui_source_window_base::set_is_exec_point_at)
843         (tui_source_window_base::set_is_exec_point_at)
844         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
845         (tui_alloc_source_buffer, tui_line_is_displayed)
846         (tui_addr_is_displayed): Change type of win_info.  Update.
847         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
848         (tui_source_window_base::do_make_visible_with_new_height):
849         Update.
850         * tui/tui-source.c (tui_set_source_content)
851         (tui_set_source_content_nil)
852         (tui_source_window::do_scroll_vertical): Update.
853         * tui/tui-layout.c (show_layout): Update.
854         * tui/tui-disasm.c (tui_set_disassem_content)
855         (tui_disasm_window::do_scroll_vertical): Update.
856         * tui/tui-data.h (tui_win_content): Remove.
857         (struct tui_gen_win_info) <content, content_size>: Remove.
858         (struct tui_source_element): Add initializers and destructor.
859         (union tui_which_element, struct tui_win_element): Remove.
860         (struct tui_source_window_base) <content>: New field.
861         (struct tui_data_window): Remove destructor.
862         (tui_alloc_content, tui_free_win_content)
863         (tui_free_all_source_wins_content): Don't declare.
864         * tui/tui-data.c (tui_initialize_static_data): Update.
865         (init_content_element, tui_alloc_content): Remove.
866         (~tui_gen_win_info): Update.
867         (~tui_data_window, tui_free_all_source_wins_content)
868         (tui_free_win_content, free_content, free_content_elements):
869         Remove.
870
871 2019-06-25  Tom Tromey  <tom@tromey.com>
872
873         * tui/tui-winsource.h (tui_clear_source_content)
874         (tui_erase_source_content, tui_show_source_content): Change type
875         of win_info.
876         * tui/tui-winsource.c (tui_clear_source_content)
877         (tui_erase_source_content, tui_show_source_content): Change type
878         of win_info.
879         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
880         * tui/tui-source.h (tui_set_source_content_nil): Change type of
881         win_info.
882         * tui/tui-source.c (tui_set_source_content_nil): Change type of
883         win_info.
884         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
885
886 2019-06-25  Tom Tromey  <tom@tromey.com>
887
888         * tui/tui-winsource.c (tui_clear_source_content)
889         (tui_source_window_base::set_is_exec_point_at): Update.
890         * tui/tui-source.c (tui_set_source_content_nil): Update.
891         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
892         a bool.
893         * tui/tui-data.c (init_content_element): Update.
894
895 2019-06-25  Tom Tromey  <tom@tromey.com>
896
897         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
898         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
899         * tui/tui-layout.c (init_and_make_win): Update.
900         * tui/tui.h (enum tui_win_type): Update.
901         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
902         tui_win_is_auxillary.
903         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
904         tui_win_is_auxillary.
905
906 2019-06-25  Tom Tromey  <tom@tromey.com>
907
908         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
909         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
910         (tui_delete_data_content_windows, tui_display_all_data)
911         (tui_data_window::do_scroll_vertical, tui_display_data_from):
912         Update.
913         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
914         * tui/tui-regs.c (tui_last_regs_line_no)
915         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
916         (tui_show_registers): Update.
917         (tui_show_register_group): Return void.  Update.
918         (tui_display_registers_from, tui_display_reg_element_at_line)
919         (tui_display_registers_from_line, tui_check_register_values):
920         Update.
921         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
922         member.
923         (struct tui_data_window) <regs_content>: Now a std::vector.
924         <regs_content_count>: Remove.
925         (tui_add_content_elements, tui_free_data_content): Don't declare.
926         * tui/tui-data.c (tui_data_window::clear_detail): Update.
927         (init_content_element): Remove DATA_WIN case.  Add assert.
928         (tui_add_content_elements): Remove.
929         (tui_data_window): Update.
930         (tui_free_data_content): Remove.
931         (free_content_elements): Remove DATA_WIN case.
932
933 2019-06-25  Tom Tromey  <tom@tromey.com>
934
935         * tui/tui-data.c (tui_data_item_window): Update.
936         * tui/tui-windata.h (tui_check_data_values): Don't declare.
937         * tui/tui-windata.c (tui_display_all_data)
938         (tui_display_data_from_line): Update.
939         (tui_check_data_values): Remove.
940         * tui/tui-regs.c (tui_show_register_group)
941         (tui_display_reg_element_at_line): Update.
942         * tui/tui-hooks.c (tui_register_changed)
943         (tui_refresh_frame_and_register_information): Call
944         tui_check_register_values.
945         * tui/tui-data.h (struct tui_data_window) <data_content,
946         data_content_count, data_type>: Remove.
947         (enum tui_data_type): Remove.
948
949         * tui/tui-data.c (tui_data_window::clear_detail)
950         (~tui_data_window): Update.
951
952 2019-06-25  Tom Tromey  <tom@tromey.com>
953
954         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
955         declare.
956         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
957         Rename from tui_first_data_item_displayed.  Update.
958         (tui_data_window::refresh_all)
959         (tui_data_window::do_scroll_vertical): Update.
960         * tui/tui-data.h (struct tui_data_window)
961         <first_data_item_displayed>: Declare new method.
962
963 2019-06-25  Tom Tromey  <tom@tromey.com>
964
965         * tui/tui-data.h (tui_init_generic_part): Don't declare.
966         * tui/tui-data.c (tui_init_generic_part): Remove, moving
967         contents...
968         (tui_initialize_static_data): ...here.
969
970 2019-06-25  Tom Tromey  <tom@tromey.com>
971
972         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
973         (tui_display_registers_from, tui_check_register_values): Update.
974         (tui_display_register): Remove win_info parameter; update.
975         (tui_get_register): Change type of parameters.
976         * tui/tui-data.h (struct tui_data_element): Remove.
977         (union tui_which_element) <data>: Remove.
978         <data_window>: Change type.
979         (struct tui_data_item_window): New.
980         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
981         case.  Add assert.
982         (~tui_data_item_window): New destructor.
983         (free_content_elements): Remove DATA_ITEM_WIN case.
984
985 2019-06-25  Tom Tromey  <tom@tromey.com>
986
987         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
988         Remove.
989
990 2019-06-25  Tom Tromey  <tom@tromey.com>
991
992         * tui/tui-data.h (struct tui_command_element): Remove.
993         (union tui_which_element) <command>: Remove.
994         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
995         assert.
996         (free_content_elements): Remove CMD_WIN case.
997
998 2019-06-25  Tom Tromey  <tom@tromey.com>
999
1000         * tui/tui-layout.c (tui_set_layout): Update.
1001         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1002         * tui/tui-data.c (layout_def): Update.
1003
1004 2019-06-25  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1007         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1008         (tui_source_window_base::set_new_height): Update.
1009         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1010         Update.
1011         (tui_set_locator_fullname, tui_set_locator_info)
1012         (tui_show_frame_info): Update.
1013         * tui/tui-source.c (tui_set_source_content)
1014         (tui_source_is_displayed): Update.
1015         * tui/tui-layout.c (show_source_disasm_command, show_data)
1016         (show_source_or_disasm_and_command): Update.
1017         * tui/tui-disasm.c (tui_set_disassem_content)
1018         (tui_get_begin_asm_address): Update.
1019         * tui/tui-data.h (struct tui_locator_element): Remove.
1020         (union tui_which_element) <locator>: Remove.
1021         (struct tui_locator_window): New.
1022         (tui_locator_win_info_ptr): Change return type.
1023         * tui/tui-data.c (_locator): Change type.
1024         (tui_locator_win_info_ptr): Change return type.
1025         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1026         (tui_alloc_content): Add assert.
1027
1028 2019-06-25  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-winsource.c
1031         (tui_exec_info_window::maybe_allocate_content): New method.
1032         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1033         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1034         (make_source_or_disasm_window): Add cast.
1035         * tui/tui-data.h (union tui_which_element) <simple_string>:
1036         Remove.
1037         (struct tui_source_info): New.
1038         (struct tui_source_window_base) <execution_info>: Change type.
1039         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1040         case, and add assert.
1041         (tui_alloc_content): Add assert.
1042
1043 2019-06-25  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1046         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1047         * tui/tui-data.c (tui_alloc_win_info): Remove.
1048
1049 2019-06-25  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1052         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1053         can_highlight.
1054
1055 2019-06-25  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1058         make_visible_with_new_height method.
1059         (tui_win_info::make_visible_with_new_height): New method.
1060         (tui_source_window_base::do_make_visible_with_new_height)
1061         (tui_data_window::do_make_visible_with_new_height)
1062         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1063         (make_visible_with_new_height): Remove.
1064         (tui_resize_all, tui_adjust_win_heights): Use
1065         make_visible_with_new_height method.
1066         * tui/tui-data.h (struct tui_win_info)
1067         <do_make_visible_with_new_height, make_visible_with_new_height>:
1068         New methods.
1069         (struct tui_source_window_base, struct tui_data_window)
1070         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1071         methods.
1072
1073 2019-06-25  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1076         method.
1077         (update_tab_width): Call update_tab_width method.
1078         * tui/tui-data.h (struct tui_win_info)
1079         (struct tui_source_window_base) <update_tab_width>: New methods.
1080
1081 2019-06-25  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1084         parameter.
1085         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1086         parameter.
1087         (tui_gen_win_info::make_visible): Update.
1088         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1089         parameter.
1090         * tui/tui-data.h (enum tui_box): New enum.
1091         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1096         init_and_make_win for EXEC_INFO_WIN.
1097         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1098         longer inline.
1099         (struct tui_win_info) <~tui_win_info>: Inline.
1100         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1101         Don't declare.
1102         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1103         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1104         Remove.
1105         (tui_initialize_static_data): Update.
1106         (~tui_gen_win_info): Handle more cleanup here.
1107         (~tui_source_window_base): Delete "execution_info".
1108         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1109
1110 2019-06-25  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-layout.c (make_command_window): Don't set
1113         can_highlight.
1114         (show_source_disasm_command): Call the reset method.
1115         (show_data): Don't set can_highlight.  Call the reset method.
1116         (tui_gen_win_info::reset): Rename from init_gen_win_info
1117         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1118         (show_source_or_disasm_and_command): Call the reset method.
1119         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1120         (struct tui_cmd_window): Set can_highlight.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1125         from make_visible.
1126         (tui_make_visible, tui_make_invisible): Rewrite.
1127         (tui_win_info::make_visible): Remove.
1128         (tui_source_window_base::make_visible): Update.
1129         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1130         method.  Moved from...
1131         (struct tui_win_info) <make_visible>: ...here.
1132
1133 2019-06-25  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-winsource.c
1136         (tui_source_window_base::do_scroll_horizontal): Remove direction
1137         parameter.
1138         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1139         direction parameter.
1140         * tui/tui-win.c (tui_win_info::forward_scroll)
1141         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1142         (tui_win_info::right_scroll): Update.
1143         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1144         direction parameter.
1145         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1146         direction parameter.
1147         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1148         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1149         Remove direction parameter.
1150         (struct tui_source_window_base, struct tui_source_window)
1151         (struct tui_disasm_window, struct tui_data_window)
1152         (struct tui_cmd_window): Update.
1153
1154 2019-06-25  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-winsource.h (tui_set_exec_info_content)
1157         (tui_show_exec_info_content, tui_erase_exec_info_content)
1158         (tui_clear_exec_info_content, tui_update_exec_info): Change
1159         argument to tui_source_window_base.
1160         * tui/tui-winsource.c (tui_set_exec_info_content)
1161         (tui_show_exec_info_content, tui_erase_exec_info_content)
1162         (tui_clear_exec_info_content, tui_update_exec_info): Change
1163         argument to tui_source_window_base.
1164
1165 2019-06-25  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1168         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1169
1170 2019-06-25  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1173         check.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1178         type to void.
1179         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1180         type to void.
1181         * tui/tui-source.c (tui_set_source_content): Update.
1182         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1183
1184 2019-06-25  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-win.c (window_name_completer, tui_set_focus)
1187         (tui_all_windows_info): Use name method.
1188         * tui/tui-data.h (struct tui_gen_win_info)
1189         (struct tui_source_window, struct tui_disasm_window)
1190         (struct tui_data_window, struct tui_cmd_window) <name>: New
1191         method.
1192         (tui_win_name): Don't declare.
1193         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1194         (tui_win_name): Remove.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-winsource.h (tui_update_source_window)
1199         (tui_update_source_window_as_is): Change parameter type.
1200         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1201         to be a tui_source_window_base.
1202         (tui_update_source_window_as_is): Likewise.
1203         * tui/tui-win.c (make_visible_with_new_height): Update.
1204
1205 2019-06-25  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-winsource.c (tui_erase_source_content)
1208         (tui_show_source_content, tui_show_exec_info_content)
1209         (tui_erase_exec_info_content): Use refresh_window method.
1210         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1211         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1212         from tui_refresh_win.
1213         (tui_data_window::refresh_window): New method.
1214         (tui_win_info::refresh, tui_source_window_base::refresh)
1215         (tui_refresh_all): Use refresh_window method.
1216         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1217         method.
1218         * tui/tui-regs.c (tui_display_register): Call refresh_window
1219         method.
1220         * tui/tui-layout.c (show_source_disasm_command)
1221         (show_source_or_disasm_and_command): Call refresh_window method.
1222         * tui/tui-data.h (struct tui_gen_win_info)
1223         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1224         New method.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui.c (tui_rl_other_window, tui_enable)
1229         (tui_is_window_visible, tui_get_command_dimension): Update.
1230         * tui/tui-winsource.c (tui_update_source_window_as_is)
1231         (tui_clear_source_content, tui_erase_source_content)
1232         (tui_show_source_line, tui_source_window_base::refill)
1233         (tui_source_window_base::do_scroll_horizontal)
1234         (tui_source_window_base::set_is_exec_point_at)
1235         (tui_update_breakpoint_info, tui_set_exec_info_content)
1236         (tui_alloc_source_buffer, tui_line_is_displayed)
1237         (tui_addr_is_displayed): Update.
1238         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1239         (tui_check_and_display_highlight_if_needed)
1240         (tui_win_info::make_visible, tui_win_info::refresh)
1241         (tui_refresh_all): Update.
1242         * tui/tui-windata.c (tui_first_data_item_displayed)
1243         (tui_delete_data_content_windows, tui_erase_data_content)
1244         (tui_display_all_data, tui_data_window::refresh_all)
1245         (tui_check_data_values): Update.
1246         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1247         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1248         (tui_win_info::backward_scroll, tui_refresh_all_win)
1249         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1250         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1251         (tui_source_window_base::set_new_height)
1252         (tui_data_window::set_new_height)
1253         (make_invisible_and_set_new_height)
1254         (make_visible_with_new_height, new_height_ok)
1255         (parse_scrolling_args): Update.
1256         * tui/tui-stack.c (tui_show_frame_info): Update.
1257         * tui/tui-source.c (tui_set_source_content)
1258         (tui_set_source_content_nil, tui_source_is_displayed)
1259         (tui_source_window::do_scroll_vertical): Update.
1260         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1261         (tui_display_registers_from, tui_display_reg_element_at_line)
1262         (tui_check_register_values, tui_reg_command): Update.
1263         * tui/tui-layout.c (tui_default_win_height)
1264         (show_source_disasm_command, show_data, init_and_make_win)
1265         (show_source_or_disasm_and_command): Update.
1266         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1267         (tui_redisplay_readline, tui_mld_flush)
1268         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1269         (tui_getc): Update.
1270         * tui/tui-disasm.c (tui_set_disassem_content)
1271         (tui_disasm_window::do_scroll_vertical): Update.
1272         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1273         Now virtual.
1274         (struct tui_win_info): Derive from tui_gen_win_info.
1275         <~tui_win_info>: Mark as override.
1276         <generic>: Remove member.
1277         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1278         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1279         (~tui_data_window, ~tui_win_info)
1280         (tui_free_all_source_wins_content): Update.
1281         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1282
1283 2019-06-25  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-layout.c (init_and_make_win): Use new.
1286         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1287         destructor, initializers.
1288         (tui_alloc_generic_win_info): Don't declare.
1289         * tui/tui-data.c (_locator): Add argument to constructor.
1290         (source_win, disasm_win): New globals.
1291         (exec_info): Remove.
1292         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1293         Update.
1294         (tui_alloc_generic_win_info): Remove.
1295         (init_content_element): Use new.
1296         (tui_win_info::tui_win_info): Update.
1297         (free_content_elements) <case DATA_WIN>: Use delete.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1302         * tui/tui-windata.c (tui_first_data_item_displayed)
1303         (tui_delete_data_content_windows): Update.
1304         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1305         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1306         (tui_display_registers_from, tui_check_register_values): Update.
1307         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1308         pointer.
1309         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1310         window.
1311         (tui_free_data_content): Update.
1312         (free_content_elements) <case DATA_WIN>: Free the window.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1317         Update.
1318         * tui/tui-layout.c (make_command_window)
1319         (show_source_disasm_command, show_data, init_and_make_win)
1320         (show_source_or_disasm_and_command): Update.
1321         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1322         method.
1323         <can_highight, is_highlighted>: Now bool.
1324         (tui_set_win_highlight): Don't declare.
1325         * tui/tui-data.c (tui_set_win_highlight): Remove.
1326
1327 2019-06-25  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-wingeneral.c (make_visible): Remove check of window
1330         type.
1331
1332 2019-06-25  Tom Tromey  <tom@tromey.com>
1333
1334         * tui/tui-win.c (tui_win_info::max_height)
1335         (tui_cmd_window::max_height): New methods.
1336         (new_height_ok): Call max_height.
1337         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1338         <max_height>: New method.
1339
1340 2019-06-25  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-win.c (tui_source_window_base::set_new_height)
1343         (tui_data_window::set_new_height): New methods.
1344         (make_invisible_and_set_new_height): Call set_new_height method.
1345         * tui/tui-data.h (struct tui_win_info)
1346         (struct tui_source_window_base, struct tui_data_window)
1347         <set_new_height>: New method.
1348
1349 2019-06-25  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1352         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1353         tui_refresh_data_win.
1354         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1355         method.
1356         (tui_refresh_all_win): Call the refresh_all method.
1357         (tui_set_focus): Likewise.
1358         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1359         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1360         Likewise.
1361
1362 2019-06-25  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-winsource.h (tui_refill_source_window)
1365         (tui_set_is_exec_point_at): Don't declare.
1366         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1367         (tui_source_window_base::refill): Rename from
1368         tui_refill_source_window.
1369         (tui_source_window_base::do_scroll_horizontal): Update.
1370         (tui_source_window_base::set_is_exec_point_at): Rename from
1371         tui_set_is_exec_point_at.
1372         (tui_update_all_breakpoint_info): Update.
1373         * tui/tui-stack.c (tui_show_frame_info): Update.
1374         * tui/tui-layout.c (show_data): Add cast.
1375         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1376         * tui/tui-data.h (struct tui_source_window_base) <refill,
1377         set_is_exec_point_at>: New methods.
1378         (tui_source_windows, tui_add_to_source_windows): Update types.
1379         (tui_add_to_source_windows): Remove redundant declaration.
1380         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1381         (tui_source_windows): Change return type.
1382         (tui_clear_source_windows_detail): Update.
1383         (tui_add_to_source_windows): Change type of parameter.
1384         (tui_free_all_source_wins_content): Update.
1385
1386 2019-06-25  Tom Tromey  <tom@tromey.com>
1387
1388         * tui/tui-wingeneral.c (tui_win_info::refresh)
1389         (tui_source_window_base::refresh): New methods.
1390         (tui_refresh_all): Call the refresh method.
1391         * tui/tui-data.h (struct tui_win_info)
1392         (struct tui_source_window_base) <refresh>: New method.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui.h (tui_is_window_visible): Return bool.
1397         * tui/tui.c (tui_is_window_visible): Return bool.
1398         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1399         (tui_make_visible, tui_make_invisible)
1400         (tui_win_info::make_visible)
1401         (tui_source_window_base::make_visible, make_all_visible)
1402         (tui_make_all_visible, tui_make_all_invisible): Update.
1403         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1404         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1405         bool.
1406         (struct tui_win_info, struct tui_source_window_base)
1407         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1408         * tui/tui-data.c (tui_init_generic_part): Update.
1409
1410 2019-06-25  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1413         (tui_source_window_base::make_visible): New methods.
1414         (make_all_visible): Make method call.
1415         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1416         (struct tui_source_window_base, struct tui_cmd_window): Override
1417         make_visible.
1418         (tui_win_is_source_type): Don't declare.
1419         * tui/tui-data.c (tui_win_is_source_type): Remove.
1420
1421 2019-06-25  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1424         NULL check.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1429         Inline constructor.  Add initializers for members.
1430         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1431         constructors; now inline in class.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-regs.c (tui_show_registers): Update.
1436         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1437         bool.
1438         * tui/tui-data.c (tui_data_window::clear_detail)
1439         (tui_data_window): Update.
1440
1441 2019-06-25  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-windata.c (tui_display_all_data)
1444         (tui_display_data_from_line, tui_display_data_from)
1445         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1446         Update.
1447         * tui/tui-regs.c (tui_last_regs_line_no)
1448         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1449         (tui_show_registers, tui_show_register_group)
1450         (tui_display_registers_from, tui_display_reg_element_at_line)
1451         (tui_display_registers_from_line, tui_check_register_values)
1452         (tui_reg_next, tui_reg_prev): Update.
1453         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1454         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1455         tui_data_window.
1456         (struct tui_win_info) <detail>: Remove.  Add new fields from
1457         tui_data_info.
1458         (TUI_DATA_WIN): Add cast.
1459         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1460         (~tui_data_window): Simplify.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-layout.c (show_source_disasm_command)
1465         (show_source_or_disasm_and_command): Update.
1466         * tui/tui-io.c (update_cmdwin_start_line)
1467         (tui_redisplay_readline): Update.
1468         * tui/tui-data.h (struct tui_command_info): Remove.
1469         (struct tui_win_info) <detail>: Remove command_info member.
1470         (struct tui_data_window) <start_line>: New member, from
1471         tui_command_info.
1472         (TUI_CMD_WIN): Add casts.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-winsource.c (tui_update_source_window)
1477         (tui_refill_source_window)
1478         (tui_source_window_base::do_scroll_horizontal)
1479         (tui_update_breakpoint_info, tui_set_exec_info_content)
1480         (tui_show_exec_info_content, tui_erase_exec_info_content)
1481         (tui_clear_exec_info_content): Update.
1482         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1483         Update.
1484         * tui/tui-win.c (make_invisible_and_set_new_height)
1485         (make_visible_with_new_height): Update.
1486         * tui/tui-source.c (tui_set_source_content)
1487         (tui_show_symtab_source): Update.
1488         * tui/tui-layout.c (extract_display_start_addr)
1489         (show_source_disasm_command, show_data)
1490         (make_source_or_disasm_window)
1491         (show_source_or_disasm_and_command): Update.
1492         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1493         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1494         "gdbarch".
1495         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1496         to tui_source_window_base.
1497         (struct tui_win_info) <detail>: Remove source_info member.
1498         (struct tui_source_window_base) <has_locator>: Inline.
1499         Move contents from tui_source_info; rename has_locator member to
1500         m_has_locator.
1501         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1502         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1503         header file.
1504         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1505         Simplify.
1506         (tui_free_all_source_wins_content): Cast to
1507         tui_source_window_base.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-win.c (make_invisible_and_set_new_height)
1512         (make_visible_with_new_height): Call has_locator method.
1513         * tui/tui-layout.c (show_source_disasm_command, show_data)
1514         (show_source_or_disasm_and_command): Update for bool change.
1515         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1516         (tui_win_info) <has_locator>: New method.
1517         (struct tui_source_window_base) <has_locator>: New method.
1518         (tui_win_has_locator): Don't declare.
1519         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1520         from tui_win_has_locator.
1521         (tui_source_window_base): Use false, not FALSE.
1522
1523 2019-06-25  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1526         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1527         clear_detail method directly.
1528         (tui_clear_win_detail): Remove.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1533         "this", not TUI_DISASM_WIN.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1538         declare.
1539         * tui/tui-winsource.c
1540         (tui_source_window_base::do_scroll_horizontal): Rename from
1541         tui_horizontal_source_scroll.
1542         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1543         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1544         from tui_vertical_data_scroll.
1545         * tui/tui-win.h (tui_scroll): Don't declare.
1546         * tui/tui-win.c (tui_win_info::forward_scroll)
1547         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1548         (tui_win_info::right_scroll): Rename and update.
1549         (tui_scroll_forward_command, tui_scroll_backward_command)
1550         (tui_scroll_left_command, tui_scroll_right_command): Update.
1551         (tui_scroll): Remove.
1552         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1553         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1554         from tui_vertical_source_scroll.
1555         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1556         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1557         from tui_vertical_disassem_scroll.
1558         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1559         do_scroll_horizontal>: New methods.
1560         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1561         Likewise.
1562         (struct tui_source_window_base): Add do_scroll_horizontal.
1563         (struct tui_source_window, struct tui_disasm_window): Add
1564         do_scroll_vertical.
1565         (struct tui_data_window, struct tui_cmd_window): Add
1566         do_scroll_horizontal and do_scroll_vertical.
1567         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-data.h (struct tui_source_window_base): New struct.
1572         (struct tui_source_window): Derive from tui_source_window_base.
1573         (struct tui_disasm_window): New struct.
1574         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1575         from tui_source_window::clear_detail.
1576         (tui_source_window_base): Rename from tui_source_window.
1577         (~tui_source_window_base): Rename from ~tui_source_window.
1578         (tui_alloc_win_info): Create a tui_disasm_window.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-data.h (struct tui_source_window)
1583         (struct tui_data_window): Declare destructors.
1584         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1585         destructors.
1586         (tui_win_info): Simplify.
1587
1588 2019-06-25  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-winsource.c (tui_display_main)
1591         (tui_update_source_windows_with_addr)
1592         (tui_update_all_breakpoint_info): Update.
1593         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1594         (new_height_ok, parse_scrolling_args): Update.
1595         * tui/tui-stack.c (tui_show_frame_info): Update.
1596         * tui/tui-data.h (struct tui_list): Remove.
1597         (tui_source_windows): Return a reference to a std::vector.
1598         * tui/tui-data.c (source_windows): Now a std::vector.
1599         (tui_source_windows): Change return type.
1600         (tui_clear_source_windows): Rewrite.
1601         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1602         (tui_free_all_source_wins_content): Rewrite.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1607         (struct tui_data_window, struct tui_cmd_window): Declare
1608         clear_detail method.
1609         * tui/tui-data.c (tui_source_window::clear_detail)
1610         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1611         methods.
1612         (tui_clear_win_detail): Simplify.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-layout.c (make_source_window, make_disasm_window)
1617         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1618         Return the new window.
1619         (show_source_disasm_command, show_data)
1620         (show_source_or_disasm_and_command): Update.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1625         parameter.  Return the new window.
1626         (show_source_disasm_command): Update and remove NULL check.
1627         (show_source_or_disasm_and_command): Update.
1628
1629 2019-06-25  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-data.h (struct tui_win_info): Make constructor
1636         protected.  Make destructor virtual.  Add initializers.
1637         (tui_source_window, tui_data_window, tui_cmd_window): New
1638         classes.
1639         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1640         constructor.  Add "type" parameter.
1641         (tui_source_window, tui_data_window, tui_cmd_window): New
1642         constructors.
1643         (tui_alloc_win_info): Instantiate the appropriate subclass.
1644
1645 2019-06-25  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-win.c (tui_resize_all): Use delete.
1648         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1649         destructor.
1650         (tui_free_window): Don't declare.
1651         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1652         Update.
1653
1654 2019-06-25  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-data.h (struct tui_win_info): Add constructor.
1657         * tui/tui-data.c (tui_alloc_win_info): Use new.
1658         (tui_free_window): Use delete.
1659
1660 2019-06-22  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1663         declare.
1664         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1665
1666 2019-06-22  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1669         declare.
1670         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1671
1672 2019-06-22  Tom de Vries  <tdevries@suse.de>
1673
1674         * dwarf2read.c (create_addrmap_from_aranges)
1675         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1676         instead of '%zu'.
1677
1678 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1679
1680         * dwarf2read.h (dwarf2_section_info_def): Remove.
1681         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1682         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1683         std::vector<dwarf2_section_info>.
1684         (struct dwo_file) <~dwo_file>: Remove.
1685         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1686         types field.
1687         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1688         (dwarf2_read_debug_names): Likewise.
1689         (create_debug_types_hash_table): Change parameter type to
1690         array_view, adjust code accordingly.
1691         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1692         (partial_die_info::fixup): Likewise.
1693         (determine_prefix): Likewise.
1694         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1695
1696 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1697
1698         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1699         gdb_bfd_ref_ptr.
1700         <~dwo_file>: Remove call to gdb_bfd_unref.
1701         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1702         gdb_bfd_ref_ptr::get.
1703
1704 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1705
1706         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1707         type to htab_up.
1708         * dwarf2read.c (struct dwo_file): Initialize fields.
1709         <~dwo_file>: New.
1710         (free_dwo_file): Remove, move content to ~dwo_file.
1711         (struct dwo_file_deleter): Remove.
1712         (dwo_file_up>: Remove custom deleter.
1713         (free_dwo_files): Remove.
1714         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1715         dwo_files.
1716         (process_skeletonless_type_units): Call unique_ptr::get.
1717         (allocate_dwo_file_hash_table): Add deleter to created hash
1718         table.  Change return type to htab_up.
1719         (lookup_dwo_file_slot): Don't memset dwo_file, call
1720         unique_ptr::get.
1721         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1722         (create_dwo_unit_in_dwp_v2): Likewise.
1723         (open_and_init_dwo_file): Likewise.
1724         (free_dwo_file_from_slot): Remove.
1725
1726 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1727
1728         * dwarf2read.h (struct dwarf2_section_info) <readin,
1729         is_virtual>: Change type to bool.
1730         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1731         true instead of 1.
1732
1733 2019-06-19  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-data.h (tui_init_content_element): Don't declare.
1736
1737 2019-06-19  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-data.h (tui_init_win_info): Don't declare.
1740
1741 2019-06-19  Tom de Vries  <tdevries@suse.de>
1742
1743         * dwarf2read.h (abstract_to_concrete): Change type to
1744         std::unordered_map<sect_offset, std::vector<sect_offset>,
1745         gdb::hash_enum<sect_offset>>.
1746
1747 2019-06-19  Tom Tromey  <tromey@adacore.com>
1748
1749         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1750         EVAL_AVOID_SIDE_EFFECTS specially.
1751
1752 2019-06-19  Tom Tromey  <tromey@adacore.com>
1753
1754         * source-cache.c (highlighter): New global.
1755         (source_cache::get_source_lines): Create a highlighter on demand.
1756
1757 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         * defs.h (deprecated_interactive_hook): Delete declaration.
1760         * interps.c (clear_interpreter_hooks): Remove use of
1761         deprecated_interactive_hook.
1762         * top.c (deprecated_interactive_hook): Delete definition.
1763         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1764
1765 2019-06-18  Tom de Vries  <tdevries@suse.de>
1766
1767         PR gdb/24515
1768         * dwarf2read.h (abstract_to_concrete): Change type from
1769         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1770         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1771         * dwarf2read.c (read_variable): Update.
1772         (dwarf2_fetch_die_loc_sect_off): Update.
1773
1774 2019-06-17  Tom de Vries  <tdevries@suse.de>
1775
1776         PR gdb/24617
1777         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1778         accessing parent[parent_len - 1].
1779
1780 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1781
1782         PR gdb/24364
1783         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1784         call dtrace_process_dof with NULL dof.
1785
1786 2019-06-16  Tom de Vries  <tdevries@suse.de>
1787
1788         PR gdb/24445
1789         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1790
1791 2019-06-16  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1794         (make_all_visible): Use address of member.
1795
1796 2019-06-16  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1799         (tui_free_window, free_content, free_content_elements): Remove
1800         unnecessary cast.
1801         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1802         cast.
1803         * tui/tui-regs.c (tui_show_register_group)
1804         (tui_display_registers_from, tui_display_reg_element_at_line):
1805         Remove unnecessary cast.
1806
1807 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * linux-nat.c (normal_mask): Delete.
1810         (_initialize_linux_nat): Don't initialise normal_mask.
1811
1812 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1813
1814         PR gdb/24445
1815         * dwarf-index-write.h (write_psymtabs_to_index): Add
1816         dwz_basename parameter.
1817         * dwarf-index-write.c (write_gdbindex): Move file writing to
1818         write_gdbindex_1.  Change return type void.
1819         (assert_file_size): Move up, remove filename parameter.
1820         (write_gdbindex_1): New function.
1821         (write_debug_names): Change return type to void, call
1822         assert_file_size.
1823         (struct index_wip_file): New struct.
1824         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1825         file logic to index_wip_file.  Write index for dwz file if
1826         needed.
1827         (save_gdb_index_command): Pass basename of dwz file, if present.
1828         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1829         build-id of dwz file, if present.
1830         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1831         (dwarf2_get_dwz_file): Likewise.
1832         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1833         (dwarf2_get_dwz_file): Likewise.
1834
1835 2019-06-16  Tom Tromey  <tom@tromey.com>
1836
1837         * coffread.c (process_coff_symbol): Use xstrdup.
1838         * value.c (create_internalvar): Use xstrdup.
1839
1840 2019-06-16  Tom Tromey  <tom@tromey.com>
1841
1842         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1843         * breakpoint.c (stopin_command, stopat_command)
1844         (until_break_command, decode_location_default): Remove unnecessary
1845         cast.
1846         * utils.c (subset_compare): Remove unnecessary cast.
1847         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1848         cast.
1849         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1850         cast.
1851         * infcmd.c (path_command): Remove unnecessary cast.
1852         * coffread.c (decode_type): Remove unnecessary cast.
1853         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1854         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1855         * tui/tui-stack.c (tui_show_locator_content)
1856         (tui_show_frame_info): Remove unnecessary cast.
1857         * tui/tui-win.c (tui_scroll_forward_command)
1858         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1859         (parse_scrolling_args): Remove unnecessary cast.
1860         * tui/tui-data.c (init_win_info, tui_del_window)
1861         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1862         (free_content_elements): Remove unnecessary cast.
1863         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1864         unnecessary cast.
1865         * tui/tui-source.c (tui_set_source_content)
1866         (tui_vertical_source_scroll): Remove unnecessary cast.
1867         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1868         cast.
1869         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1870         * tui/tui-regs.c (tui_display_registers_from)
1871         (tui_display_register): Remove unnecessary cast.
1872         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1873         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1874         (make_visible): Remove unnecessary cast.
1875         * tui/tui-winsource.c (tui_erase_source_content)
1876         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1877         unnecessary cast.
1878         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1879         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1880         * stabsread.c (read_type, read_array_type, read_range_type):
1881         Remove unnecessary cast.
1882         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1883         (parse_symbol, parse_type, upgrade_type, parse_external)
1884         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1885         unnecessary cast.
1886         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1887
1888 2019-06-16  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-data.c (tui_alloc_generic_win_info)
1891         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1892         checks.
1893
1894 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1895             Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * f-typeprint.c (f_print_type): Don't return early for not
1898         associated or not allocated types.
1899         (f_type_print_varspec_suffix): Add print_rank parameter and print
1900         ranks of array types in case they dangling.
1901         (f_type_print_base): Add print_rank parameter.
1902
1903 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * NEWS: Mention new MI commands.
1906         * break-catch-throw.c (enum exception_event_kind): Move to
1907         breakpoint.h.
1908         (print_mention_exception_catchpoint): Output text as a single
1909         message.
1910         (catch_exception_command_1): Rename to...
1911         (catch_exception_event): ...this, make non-static, update header
1912         command, and change some parameter types.
1913         (catch_catch_command): Update for changes to
1914         catch_exception_command_1.
1915         (catch_throw_command): Likewise.
1916         (catch_rethrow_command): Likewise.
1917         * breakpoint.c (enum exception_event_kind): Delete.
1918         * breakpoint.h (enum exception_event_kind): Moved here from
1919         break-catch-throw.c.
1920         (catch_exception_event): Declare.
1921         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1922         (mi_cmd_catch_throw): New function.
1923         (mi_cmd_catch_rethrow): New function.
1924         (mi_cmd_catch_catch): New function.
1925         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1926         'catch-catch' entries.
1927         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1928         (mi_cmd_catch_rethrow): Declare.
1929         (mi_cmd_catch_catch): Declare.
1930
1931 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * annotate.c (annotate_source_line): Change return type to void,
1934         update implementation to match.
1935         * annotate.h (annotate_source_line): Change return type to void,
1936         update header comment.
1937         * stack.c (print_frame_info): Don't change what frame information
1938         is printed based on whether annotations are on or not.
1939
1940 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1943         (annotate_source): Make static.
1944         (annotate_source_line): Moved from source.c and renamed from
1945         identify_source_line.  Update the return type.
1946         * annotate.h (annotate_source): Delete declaration.
1947         (annotate_source_line): Declaration moved from source.h, and
1948         renamed from identify_source_line.  Return type updated.
1949         * source.c (identify_source_line): Moved to annotate.c and renamed
1950         to annotate_source_line.
1951         (info_line_command): Remove check of annotation_level.
1952         * source.h (identify_source_line): Move declaration to annotate.h
1953         and rename to annotate_source_line.
1954         * stack.c: Add 'annotate.h' include.
1955         (print_frame_info): Remove check of annotation_level before
1956         calling annotate_source_line.
1957
1958 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * source-cache.c (source_cache::get_plain_source_lines): Use
1961         open_source_file_with_line_charpos instead of just
1962         open_source_file, remove call to find_source_lines.
1963         (source_cache::get_source_lines): Likewise.
1964         * source.c (find_source_lines): Make static.
1965         (get_filename_and_charpos): Renamed into...
1966         (open_source_file_with_line_charpos): ..this along with changes to
1967         return a scoped_fd, and some other minor clean ups.
1968         (identify_source_line): Use open_source_file_with_line_charpos.
1969         (search_command_helper): Use open_source_file_with_line_charpos
1970         instead of just open_source_file, remove call to
1971         find_source_lines.
1972         * source.h (open_source_file_with_line_charpos): Declare new
1973         function.
1974         (find_source_lines): Delete declaration.
1975
1976 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * source.c (get_filename_and_charpos): Remove fullname
1979         parameter.
1980         (identify_source_line): Update call to get_filename_and_charpos.
1981
1982 2019-06-14  Tom Tromey  <tromey@adacore.com>
1983
1984         PR gdb/24502:
1985         * ui-style.h (skip_ansi_escape): Update comment.
1986         * ui-file.h (class no_terminal_escape_file): New class.
1987         * ui-file.c (no_terminal_escape_file::write)
1988         (no_terminal_escape_file::puts): New methods.
1989         * cli/cli-logging.c (handle_redirections): Use
1990         no_terminal_escape_file.
1991
1992 2019-06-14  Tom Tromey  <tromey@adacore.com>
1993
1994         * NEWS: Move convenience variable news above Python news.
1995
1996 2019-06-14  Tom Tromey  <tom@tromey.com>
1997
1998         * gnulib: Move directory to top-level.
1999         * configure.ac: Don't configure gnulib.
2000         * configure: Rebuild.
2001         * common/common-defs.h: Use new path to gnulib.
2002         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2003         (GNULIB_H): Remove.
2004         (INCGNU): Look in new gnulib location.
2005         (HFILES_NO_SRCDIR): Remove gnulib files.
2006         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2007         (generated_files): Remove GNULIB_H.
2008         ($(LIBGNU), all-lib): Remove targets.
2009         (distclean): Don't mention GNULIB_BUILDDIR.
2010         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2011
2012 2019-06-14  Tom Tromey  <tromey@adacore.com>
2013
2014         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2015         Warn if symbol file does not provide any symbols.
2016
2017 2019-06-14  Tom Tromey  <tromey@adacore.com>
2018
2019         * source.c (find_and_open_source): Respect basenames_may_differ.
2020
2021 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * annotate.c (annotate_breakpoints_invalid): Make use of
2024         scoped_restore_terminal_state.
2025         (annotate_frames_invalid): Likewise.
2026
2027 2019-06-14  Tom Tromey  <tromey@adacore.com>
2028
2029         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2030         allow assignment to an internalvar.
2031
2032 2019-06-14  Tom Tromey  <tromey@adacore.com>
2033
2034         * ada-lex.l: Allow "_" in attribute names.
2035
2036 2019-06-14  Tom Tromey  <tromey@adacore.com>
2037
2038         PR gdb/24653:
2039         * regcache.c (registers_changed): Don't call alloca.
2040         * top.c (execute_command): Don't call alloca.
2041
2042 2019-06-13  Pedro Alves  <palves@redhat.com>
2043
2044         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2045         'expression'.  When parsing an expression, error out if there's
2046         junk after "unlimited".
2047         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2048         (do_set_command): Adjust calls to is_unlimited_literal.
2049
2050 2019-06-13  Pedro Alves  <palves@redhat.com>
2051
2052         * compile/compile.c (make_compile_options_def_group): Add braces
2053         around array_view initializer.
2054         * thread.c (make_thread_apply_all_options_def_group)
2055         (make_thread_apply_all_options_def_group): Likewise.
2056
2057 2019-06-13  Pedro Alves  <palves@redhat.com>
2058
2059         * NEWS (New commands): Mention "maint test-options
2060         require-delimiter", "maint test-options unknown-is-error", "maint
2061         test-options unknown-is-operand" and "maint show
2062         test-options-completion-result".
2063         (New command options, command completion): New section.
2064         (Completion improvements): New section.
2065         Mention that you can abbreviate "unlimited".
2066
2067 2019-06-13  Pedro Alves  <palves@redhat.com>
2068
2069         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2070         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2071         * unittests/cli-utils-selftests.c (test_parse_flags)
2072         (test_parse_flags_qcs): Delete.
2073         (test_cli_utils): Don't call deleted functions.
2074
2075 2019-06-13  Pedro Alves  <palves@redhat.com>
2076
2077         * thread.c: Include "cli/cli-option.h".
2078         (tp_array_compar_ascending): Global.
2079         (tp_array_compar): Delete function.
2080         (tp_array_compar_ascending, tp_array_compar_descending): New
2081         functions.
2082         (ascending_option_def, qcs_flag_option_def)
2083         (thr_qcs_flags_option_defs)
2084         (make_thread_apply_all_options_def_group)
2085         (make_thread_apply_options_def_group): New.
2086         (thread_apply_all_command): Use gdb::option::process_options.
2087         (thread_apply_command_completer)
2088         (thread_apply_all_command_completer): New.
2089         (thread_apply_command): Use gdb::option::process_options.
2090         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2091         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2092         to generate help text of "thread apply".  Adjust "taas"'s help.
2093         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2094         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2095
2096 2019-06-13  Pedro Alves  <palves@redhat.com>
2097
2098         * thread.c (thread_apply_command): Check for invalid TID with
2099         isdigit instead of !isalpha.
2100
2101 2019-06-13  Pedro Alves  <palves@redhat.com>
2102
2103         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2104         (validate_flags_qcs): New.
2105         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2106         (validate_flags_qcs): Declare.
2107         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2108         (make_frame_apply_options_def_group): New.
2109         (frame_apply_command_count): Process options with
2110         gdb::option::process_options.
2111         (frame_apply_completer): New.
2112         (frame_apply_level_completer, frame_apply_all_completer)
2113         (frame_apply_completer): New.
2114         (_initialize_stack): Update help of "frame apply", "frame apply
2115         level", "frame apply all" and "faas" to mention supported options
2116         and install command completers.
2117         * stack.h (frame_apply_all_completer): Declare.
2118         * thread.c: Include "stack.h".
2119         (tfaas_command): Add "--".
2120         (_initialize_thread): Update help "tfaas" to mention supported
2121         options and install command completer.
2122
2123 2019-06-13  Pedro Alves  <palves@redhat.com>
2124
2125         * completer.c (complete_nested_command_line): New.
2126         (gdb_completion_word_break_characters_throw): Add assertion.
2127         * completer.h (complete_nested_command_line): Declare.
2128
2129 2019-06-13  Pedro Alves  <palves@redhat.com>
2130
2131         * stack.c (parse_backtrace_qualifiers): New.
2132         (backtrace_command): Use it.
2133         (backtrace_command_completer): Complete on qualifiers.
2134
2135 2019-06-13  Pedro Alves  <palves@redhat.com>
2136
2137         * frame.c: Include "cli/cli-option.h.
2138         (user_set_backtrace_options): New.
2139         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2140         Delete.
2141         (get_prev_frame): Adjust.
2142         (boolean_option_def, uinteger_option_def)
2143         (set_backtrace_option_defs): New.
2144         (_initialize_frame): Adjust and use
2145         gdb::option::add_setshow_cmds_for_options to install "set
2146         backtrace past-main" and "set backtrace past-entry".
2147         * frame.h: Include "cli/cli-option.h".
2148         (struct frame_print_options): Forward declare.
2149         (print_frame_arguments_all, print_frame_arguments_scalars)
2150         (print_frame_arguments_none): Declare.
2151         (print_entry_values): Delete declaration.
2152         (struct frame_print_options, user_frame_print_options): New.
2153         (struct set_backtrace_options): New.
2154         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2155         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2156         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2157         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2158         (list_args_or_locals): Add frame_print_options parameter.
2159         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2160         * python/py-framefilter.c (enumerate_args): Pass down
2161         USER_FRAME_PRINT_OPTIONS.
2162         * stack.c: Include "cli/cli-option.h".
2163         (print_frame_arguments_all, print_frame_arguments_scalars)
2164         (print_frame_arguments_none): Declare.
2165         (print_raw_frame_arguments, print_entry_values): Delete.
2166         (user_frame_print_options): New.
2167         (boolean_option_def, enum_option_def, frame_print_option_defs):
2168         New.
2169         (struct backtrace_cmd_options): New.
2170         (bt_flag_option_def): New.
2171         (backtrace_command_option_defs): New.
2172         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2173         (print_frame_arg, read_frame_arg, print_frame_args)
2174         (print_frame_info, print_frame): Add frame_print_options parameter
2175         and use it.
2176         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2177         (backtrace_command_1): Add frame_print_options and
2178         backtrace_cmd_options parameters and use them.
2179         (make_backtrace_options_def_group): New.
2180         (backtrace_command): Process command options with
2181         gdb::option::process_options.
2182         (backtrace_command_completer): New.
2183         (_initialize_stack): Extend "backtrace"'s help to mention
2184         supported options.  Install completer for "backtrace".
2185         Install some settings commands with add_setshow_cmds_for_options.
2186
2187 2019-06-13  Pedro Alves  <palves@redhat.com>
2188
2189         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2190         and that "set/show print raw frame-arguments" are now deprecated.
2191
2192         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2193         command.
2194         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2195         * stack.c (_initialize_stack): Install "set/show print
2196         raw-frame-arguments", and deprecate "set/show print raw
2197         frame-arguments".
2198         * valprint.c (_initialize_valprint): Deprecate "set/show print
2199         raw".
2200
2201 2019-06-13  Pedro Alves  <palves@redhat.com>
2202
2203         * compile/compile.c (struct compile_options): New.
2204         (compile_flag_option_def, compile_command_option_defs)
2205         (make_compile_options_def_group): New.
2206         (compile_file_command): Handle options with
2207         gdb::option::process_options.
2208         (compile_file_command_completer): New function.
2209         (compile_code_command): Handle options with
2210         gdb::option::process_options.
2211         (compile_code_command_completer): New function.
2212         (_initialize_compiler): Install completers for "compile code" and
2213         "compile file".  Mention available options in "compile code" and
2214         "compile code"'s help.
2215         * completer.c (advance_to_completion_word): New, factored out from
2216         ...
2217         (advance_to_expression_complete_word_point): ... this.
2218         (advance_to_filename_complete_word_point): New.
2219         * completer.h (advance_to_filename_complete_word_point): New
2220         declaration.
2221
2222 2019-06-13  Pedro Alves  <palves@redhat.com>
2223
2224         * compile/compile.c: Include "cli/cli-option.h".
2225         (compile_print_value): Scope data pointer is now a
2226         value_print_options pointer; adjust.
2227         (compile_print_command): Process options.  Scope data pointer is
2228         now a value_print_options pointer; adjust.
2229         (_initialize_compile): Update "compile print"'s help to include
2230         supported options.  Install a completer for "compile print".
2231         * cp-valprint.c (show_vtblprint, show_objectprint)
2232         (show_static_field_print): Delete.
2233         (_initialize_cp_valprint): Don't install "set print
2234         static-members", "set print vtbl", "set print object" here.
2235         * printcmd.c: Include "cli/cli-option.h" and
2236         "common/gdb_optional.h".
2237         (print_command_parse_format): Rework to fill in a
2238         value_print_options instead of a format_data.
2239         (print_value): Change parameter type from format_data pointer to
2240         value_print_options reference.  Adjust.
2241         (print_command_1): Process options.  Adjust to pass down a
2242         value_print_options.
2243         (print_command_completer): New.
2244         (_initialize_printcmd): Install print_command_completer as
2245         handle_brkchars completer for the "print" command.  Update
2246         "print"'s help to include supported options.
2247         * valprint.c: Include "cli/cli-option.h".
2248         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2249         here from cp-valprint.c.
2250         (boolean_option_def, uinteger_option_def)
2251         (value_print_option_defs, make_value_print_options_def_group):
2252         New.  Use gdb::option::add_setshow_cmds_for_options to install
2253         "set print elements", "set print null-stop", "set print repeats",
2254         "set print pretty", "set print union", "set print array", "set
2255         print address", "set print symbol", "set print array-indexes".
2256         * valprint.h: Include <string> and "cli/cli-option.h".
2257         (make_value_print_options_def_group): Declare.
2258         (print_value): Change parameter type from format_data pointer to
2259         value_print_options reference.
2260         (print_command_completer): Declare.
2261
2262 2019-06-13  Pedro Alves  <palves@redhat.com>
2263
2264         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2265         (COMMON_SFILES): Add maint-test-settings.c.
2266         * cli/cli-decode.c (boolean_enums): New global, factored out from
2267         ...
2268         (add_setshow_boolean_cmd): ... here.
2269         * cli/cli-decode.h (boolean_enums): Declare.
2270         * cli/cli-option.c: New file.
2271         * cli/cli-option.h: New file.
2272         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2273         factored out from ...
2274         (parse_cli_boolean_value(const char *)): ... this.
2275         (is_unlimited_literal): Change parameter type to pointer to
2276         pointer.  Adjust and advance ARG pointer.
2277         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2278         (parse_cli_var_enum): New, factored out from ...
2279         (do_set_command): ... this.  Adjust.
2280         * cli/cli-setshow.h (parse_cli_boolean_value)
2281         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2282         (parse_cli_var_enum): Declare.
2283         * cli/cli-utils.c: Include "cli/cli-option.h".
2284         (get_ulongest): New.
2285         * cli/cli-utils.h (get_ulongest): Declare.
2286         (check_for_argument): New overloads.
2287         * maint-test-options.c: New file.
2288
2289 2019-06-13  Pedro Alves  <palves@redhat.com>
2290
2291         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2292         parse a range if "-" is at the end of the string.
2293
2294 2019-06-13  Pedro Alves  <palves@redhat.com>
2295
2296         * cli/cli-setshow.c (parse_auto_binary_operation)
2297         (parse_cli_boolean_value): Don't allow "o".
2298
2299 2019-06-13  Pedro Alves  <palves@redhat.com>
2300
2301         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2302         * NEWS: Mention maint test-settings KIND.
2303         * maint-test-settings.c: New file.
2304
2305 2019-06-13  Pedro Alves  <palves@redhat.com>
2306
2307         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2308         completer.
2309         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2310         "set" completers.
2311
2312 2019-06-13  Pedro Alves  <palves@redhat.com>
2313
2314         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2315         after item.
2316
2317 2019-06-13  Pedro Alves  <palves@redhat.com>
2318
2319         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2320
2321 2019-06-13  Pedro Alves <palves@redhat.com>
2322
2323         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2324         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2325         call.
2326         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2327         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2328         calls.
2329         (check_for_argument): Skip spaces after argument.
2330
2331 2019-06-13  Pedro Alves  <palves@redhat.com>
2332
2333         * thread.c (thread_apply_command): Adjust TID parsing.
2334         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2335         detected before end of string.
2336         (tid_is_in_list): Error out if LIST is invalid.
2337
2338 2019-06-13  Pedro Alves  <palves@redhat.com>
2339
2340         * completer.c (complete_line_internal_1): Rewind completion word
2341         point.
2342         (completion_tracker::advance_custom_word_point_by): Change
2343         parameter type to int.
2344         * completer.h (completion_tracker::advance_custom_word_point_by):
2345         Likewise.
2346
2347 2019-06-13  Pedro Alves  <palves@redhat.com>
2348
2349         * completer.c (advance_to_completion_word): Handle delimiters.
2350
2351 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2352
2353         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2354
2355 2019-06-11  Tom Tromey  <tom@tromey.com>
2356
2357         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2358         (xmalloc_failed): Move to alloc.c.
2359         * alloc.c: New file.
2360         * Makefile.in (COMMON_SFILES): Add alloc.c.
2361
2362 2019-06-11  Tom Tromey  <tom@tromey.com>
2363
2364         * nat/linux-waitpid.c: Don't include server.h.
2365         (linux_debug): Remove.
2366         (my_waitpid): Update.
2367
2368 2019-06-11  Tom Tromey  <tromey@adacore.com>
2369
2370         * infcall.c (_initialize_infcall): Remove trailing newline from
2371         help.
2372         * user-regs.c (_initialize_user_regs): Remove trailing newline
2373         from help.
2374         * typeprint.c (_initialize_typeprint): Remove trailing newline
2375         from help.
2376         * reverse.c (_initialize_reverse): Remove trailing newlines from
2377         help.
2378         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2379         from help.
2380         * language.c (add_set_language_command): Remove trailing newline
2381         from help.
2382         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2383         help.
2384         * disasm.c (_initialize_disasm): Remove trailing newline from
2385         help.
2386         * top.c (init_main): Remove trailing newline from help.
2387         * interps.c (_initialize_interpreter): Remove trailing newline
2388         from help.
2389         * btrace.c (_initialize_btrace): Remove trailing newlines from
2390         help.
2391         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2392         from help.
2393         * python/python.c (_initialize_python): Remove trailing newline
2394         from help.
2395         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2396         help.
2397         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2398         from help.  Reformat some text.
2399         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2400         from help.
2401         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2402         newline from help.
2403
2404 2019-06-11  Tom Tromey  <tromey@adacore.com>
2405
2406         * darwin-nat.c (darwin_decode_exception_message)
2407         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2408
2409 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2410
2411         * valops.c (value_slice): Check for not allocated or not
2412         associated values.
2413
2414 2019-06-10  Tom de Vries  <tdevries@suse.de>
2415
2416         PR gdb/24618
2417         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2418         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2419         invalid.
2420
2421 2019-06-10  Tom de Vries  <tdevries@suse.de>
2422
2423         PR gdb/24611
2424         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2425         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2426
2427 2019-06-10  Tom de Vries  <tdevries@suse.de>
2428
2429         PR symtab/24545
2430         * symtab.c (struct demangled_name_entry): Add language field.
2431         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2432         static minimal symbol".  Set and use language field.
2433
2434 2019-06-10  Tom Tromey  <tromey@adacore.com>
2435
2436         * ada-lang.c (_initialize_ada_language): Update help text.
2437
2438 2019-06-10  Tom Tromey  <tromey@adacore.com>
2439
2440         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2441         with a newline.
2442         * guile/guile.c (handle_boot_error): Don't end warning with a
2443         newline.
2444         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2445         warning with a newline.
2446         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2447         newline.
2448         (s12z_frame_cache): Likewise.
2449         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2450         a newline.
2451         * solib-svr4.c (disable_probes_interface): Don't end warning with
2452         a newline.
2453         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2454         newline.
2455         * python/python.c (do_finish_initialization): Don't end warning
2456         with a newline.
2457
2458 2019-06-10  Tom Tromey  <tom@tromey.com>
2459
2460         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2461         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2462         gdbpy_enter.
2463
2464 2019-06-10  Tom Tromey  <tromey@adacore.com>
2465
2466         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2467         data.
2468         (elf_new_init): Don't call stabsread_new_init.
2469         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2470         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2471         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2472
2473 2019-06-10  Tom de Vries  <tdevries@suse.de>
2474
2475         PR symtab/16264
2476         PR symtab/24517
2477         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2478
2479 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2480
2481         * source.c (find_and_open_source): Also rewrite relative file
2482         names.
2483
2484 2019-04-26  Amos Bird  <amosbird@gmail.com>
2485
2486         * annotate.c (annotate_thread_exited): Add "thread-exited"
2487         annotation.
2488
2489 2019-06-06  Tom Tromey  <tromey@adacore.com>
2490
2491         * maint.h (class scoped_command_stats): Use
2492         DISABLE_COPY_AND_ASSIGN.
2493         <print_time>: New method.
2494         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2495         print_time.
2496         (scoped_command_stats::print_time): New method.
2497
2498 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2501         instructions of lengths 6 or 8 bytes.
2502
2503 2019-06-04  Pedro Alves  <palves@redhat.com>
2504
2505         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2506
2507         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2508         * breakpoint.c (condition_completer): Likewise.
2509         * cli/cli-dump.c (scan_expression): Likewise.
2510         * common/filestuff.c (mkdir_recursive): Likewise.
2511         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2512         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2513         (gdb_abspath): Likewise.
2514         * compile/compile-cplus-types.c
2515         (compile_cplus_instance::decl_name): Likewise.
2516         * completer.c (complete_explicit_location):
2517         (signal_completer, reg_or_group_completer_1): Likewise.
2518         * cp-support.c (cp_remove_params_if_any): Likewise.
2519         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2520         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2521         * infcmd.c (strip_bg_char): Likewise.
2522         * linespec.c (copy_token_string): Likewise.
2523         * mi/mi-main.c (output_cores): Likewise.
2524         * psymtab.c (psymtab_search_name):
2525         * symfile.c (test_set_ext_lang_command): Likewise.
2526         * target.c (target_fileio_read_stralloc): Likewise.
2527         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2528         * value.c (complete_internalvar): Likewise.
2529
2530 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2531
2532         Add objfile property to gdb.Type.
2533         * NEWS: Mention Python API addition.
2534         * python/py-type.c (typy_get_objfile): New method.
2535
2536 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2537
2538         * NEWS: Mention the new set|show style [title|highlight].
2539         Mention changes to "show style", "help" and "apropos".
2540
2541 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2542
2543         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2544         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2545         instead of print_help_for_command.
2546         (print_doc_of_command): New function.
2547         (help_list): Add 'apropos -v word' suggestion.
2548         (print_help_for_command): Style the command name using title style.
2549         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2550         (_initialize_cli_cmds): Describe -v in apropos_command help.
2551
2552 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2553
2554         * cli/cli-style.h (cli_style_option): Add name in constructor,
2555         add m_name class member, add constructor with intensity,
2556         add name class function.
2557         (cli_style_option::add_setshow_commands): Remove name argument.
2558         (highlight_style, title_style): New styles.
2559         * cli/cli-style.c (do_show): New function that shows a style
2560         characteristic styling the style name with itself.
2561         (set_style_name): New function.
2562         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2563         Update all callers according to the changes in cli/cli-style.h.
2564         * utils.h (fputs_highlighted): New function.
2565         * utils.c (fputs_highlighted): Likewise.
2566
2567 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2568
2569         * NEWS: Mention new pipe command and new convenience variables.
2570
2571 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2572
2573         * cli/cli-cmds.c (pipe_command): New function.
2574         (_initialize_cli_cmds): Call add_com for pipe_command.
2575         Define | as an alias for pipe.
2576         (exit_status_set_internal_vars): New function.
2577         (shell_escape): Call exit_status_set_internal_vars.
2578         cli/cli-decode.c (find_command_name_length): Recognize | as
2579         a single character command.
2580
2581 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2582
2583         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2584         top.c (execute_command_to_ui_file): New function, mostly a copy
2585         of execute_command_to_string.
2586         (execute_command_to_string): Implement by calling
2587         execute_command_to_ui_file.
2588
2589 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2590
2591         * top.h (saved_command_line): Remove declaration.
2592         * top.c (previous_saved_command_line, previous_repeat_arguments):
2593         New variables.
2594         (saved_command_line): Make static, define together with other
2595         'repeat variables'.
2596         (dont_repeat): Clear repeat_arguments.
2597         (repeat_previous, get_saved_command_line, save_command_line):
2598         New functions.
2599         (gdb_init): Initialize saved_command_line
2600         and previous_saved_command_line.
2601         * main.c (captured_main_1): Remove saved_command_line initialization.
2602         * event-top.c (handle_line_of_input): Update to use
2603         the new 'repeat' related functions instead of direct access to
2604         saved_command_line.
2605         * command.h (repeat_previous, get_saved_command_line,
2606         save_command_line): New declarations.
2607         (dont_repeat): Add comment.
2608
2609 2019-05-30  Tom Tromey  <tromey@adacore.com>
2610
2611         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2612         Fix comment.
2613         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2614
2615 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2616
2617         PR cli/24587
2618         * completer.c (complete): Initialize variable word.
2619
2620 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2621
2622         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2623         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2624         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2625         'body' is NULL to the outter 'if', protecting the '!is_define'
2626         situation as well.
2627
2628 2019-05-29  Tom Tromey  <tromey@adacore.com>
2629
2630         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2631         (dwarf_unknown): New function.
2632         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2633         (dwarf_type_encoding_name): Use dwarf_unknown.
2634
2635 2019-05-29  Tom Tromey  <tromey@adacore.com>
2636
2637         PR c++/20020:
2638         * cp-valprint.c (cp_print_value_fields): Call
2639         cp_print_static_field inside "try".
2640
2641 2019-05-29  Tom Tromey  <tromey@adacore.com>
2642
2643         * inflow.c (struct terminal_info): Add default operator=.
2644         * configure: Rebuild.
2645         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2646         -Wdeprecated-copy-dtor, -Wredundant-move.
2647
2648 2019-05-29  Tom Tromey  <tromey@adacore.com>
2649
2650         * NEWS: Add entry.
2651         * infcmd.c (print_return_value_1): Handle finish_print
2652         option.
2653         (show_print_finish): New function.
2654         (_initialize_infcmd): Add "set/show print finish" commands.
2655         * valprint.c (user_print_options): Initialize new member.
2656         * valprint.h (struct value_print_options) <finish_print>: New
2657         member.
2658
2659 2019-05-28  Tom Tromey  <tromey@adacore.com>
2660
2661         * ada-lang.c (ada_remove_Xbn_suffix)
2662         (find_old_style_renaming_symbol)
2663         (parse_old_style_renaming): Remove.
2664         (ada_find_renaming_symbol): Don't call
2665         find_old_style_renaming_symbol.
2666         (ada_is_renaming_symbol): Rename from
2667         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2668         bool.  Now static.
2669         (ada_read_var_value): Update and simplify.
2670         * ada-exp.y (write_var_or_type): Remove old code.
2671
2672 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2673
2674         * event-top.c: Remove include comment.
2675         * inflow.c (class scoped_ignore_sigttou): Move from here...
2676         * inflow.h (class scoped_ignore_sigttou): ...to here.
2677         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2678         * top.c:  Remove include comment.
2679
2680 2019-05-27  Tom Tromey  <tom@tromey.com>
2681
2682         * NEWS: Fix typo.
2683
2684 2019-05-22  Tom Tromey  <tromey@adacore.com>
2685
2686         * target.c (target_follow_exec): Constify parameter.
2687         * target-delegates.c: Rebuild.
2688         * remote.c (remote_target::follow_exec): Constify parameter.
2689         * infrun.c (follow_exec): Constify parameter.
2690         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2691         (target_follow_exec): Likewise.
2692
2693 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2694
2695         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2696         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2697
2698 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2699
2700         * NEWS: Add debugredirect and testsuite sections.
2701
2702 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2703
2704         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2705         target descriptions using exclusively floating point register name
2706         aliases.
2707
2708 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         PR gdb/18644:
2711         * f-lang.c (build_fortran_types): Handle the case where
2712         gdbarch_floatformat_for_type returns a nullptr.
2713
2714 2019-05-21  Tom de Vries  <tdevries@suse.de>
2715
2716         PR cli/24587
2717         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2718
2719 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         PR gdb/18644:
2722         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2723         16-byte floats.
2724         * i386-tdep.c (i386_floatformat_for_type): Use
2725         floatformats_ia64_quad for the 16-byte floating point component
2726         within a fortran 32-byte complex number.
2727
2728 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2729
2730         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2731         delete default constructor.
2732         (find_partial_die): Update to return const struct.
2733         (partial_die_parent_scope): Move variable declaration into scope
2734         of its use and change its type to auto.
2735         (guess_partial_die_structure_name): Likewise.
2736         (partial_die_info::fixup): Likewise.
2737
2738 2019-05-17  Tom Tromey  <tromey@adacore.com>
2739
2740         * source.c (find_and_open_source): Remove cast.
2741
2742 2019-05-17  Tom Tromey  <tromey@adacore.com>
2743
2744         * annotate.c (annotate_source): Make "filename" const.
2745         * annotate.h (annotate_source): Use const.
2746
2747 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2748
2749         * disasm.c (set_disassembler_options): Send errors to stderr.
2750
2751 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2752
2753         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2754         (cli_interp_base::set_logging): Check debug_redirect.
2755         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2756         * cli/cli-logging.c (debug_redirect): Add static variable.
2757         (pop_output_files): Add default param.
2758         (handle_redirections): Print debug setting.
2759         (show_logging_command): Likewise.
2760         (_initialize_cli_logging): Add debugredirect command.
2761         * interps.c (current_interp_set_logging): Add debug_redirect
2762         parameter.
2763         * interps.h (set_logging): Add debug_redirect parameter.
2764         (current_interp_set_logging): Likewise.
2765         * mi/mi-common.h: Likewise.
2766         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2767
2768 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2769             Tom Tromey  <tromey@adacore.com>
2770
2771         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2772         directly.
2773         * cli/cli-interp.h (make_logging_output): Remove declaration.
2774         * cli/cli-logging.c (make_logging_output): Remove function.
2775         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2776         directly.
2777         * ui-file.c (tee_file::tee_file): Remove bools.
2778         (tee_file::~tee_file): Remove deletes.
2779         * ui-file.h (tee_file): Remove bools.
2780
2781 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2782
2783         * mi/mi-cmds.h (mi_cmd_complete): New function.
2784         * mi/mi-main.c (mi_cmd_complete): Likewise.
2785         * mi/mi-cmds.c: Define new MI command -complete.
2786         * NEWS: Mention new -complete command.
2787
2788 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2789
2790         * completer.h (complete): New function.
2791         * completer.c (complete): Likewise.
2792         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2793         function defined in completer.h.
2794
2795 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2796
2797         * MAINTAINERS (Write After Approval): Add myself.
2798
2799 2019-05-17  Tom de Vries  <tdevries@suse.de>
2800
2801         PR gdb/24094
2802         * dwarf2read.c (struct cu_partial_die_info): New struct.
2803         (find_partial_die): Return cu_partial_die_info.
2804         (partial_die_parent_scope, guess_partial_die_structure_name)
2805         (partial_die_info::fixup): Handle new return type of find_partial_die.
2806
2807 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2808
2809         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2810         "std::string", simplifying the algorithm.
2811
2812 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2813
2814         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2815         (stap_static_probe_ops::get_probes): Likewise.
2816
2817 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2818
2819         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2820         '-')" and "else if".
2821         (stap_parse_single_operand): Join checks for
2822         "gdbarch_stap_parse_special_token_p" and
2823         "gdbarch_stap_parse_special_token" in the same "if" statement.
2824         Invert check when verifying for operation on register
2825         displacement.
2826
2827 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2828
2829         * stap-probe.c (stap_get_opcode): Update comment.
2830         (stap_get_expected_argument_type): Likewise.
2831         (handle_stap_probe): Likewise.
2832
2833 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2834
2835         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2836         return type to 'bool'.  Adjust comment.  Use 'bool' when
2837         appropriate.
2838         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2839         * stap-probe.c (stap_parse_argument_1): Likewise.
2840         (stap_is_operator): Likewise.
2841         (stap_is_generic_prefix): Likewise.
2842         (stap_is_register_prefix): Likewise.
2843         (stap_is_register_indirection_prefix): Likewise.
2844         (stap_is_integer_prefix): Likewise.
2845         (stap_generic_check_suffix): Likewise.
2846         (stap_check_integer_suffix): Likewise.
2847         (stap_check_register_suffix): Likewise.
2848         (stap_check_register_indirection_suffix): Likewise.
2849         (stap_parse_register_operand): Likewise.
2850         (stap_parse_single_operand): Likewise.
2851         (stap_parse_argument_1): Likewise.
2852         (stap_probe::get_argument_count): Likewise.
2853         (stap_is_operator): Likewise.
2854
2855 2019-05-16  Tom Tromey  <tromey@adacore.com>
2856
2857         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2858         keyword to foreach.
2859
2860 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2861
2862         * linux-thread-db.c (try_thread_db_load_1): Change return type
2863         to bool.
2864         (try_thread_db_load): Likewise.
2865         (try_thread_db_load_from_pdir_1): Likewise.
2866         (try_thread_db_load_from_pdir): Likewise.
2867         (try_thread_db_load_from_sdir): Likewise.
2868         (try_thread_db_load_from_dir): Likewise.
2869         (thread_db_load_search): Likewise.
2870         (has_libpthread): Likewise.
2871         (thread_db_load): Likewise.
2872
2873 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2874
2875         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2876         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2877         NULL, and complain/return if that's the case.
2878
2879 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2880
2881         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2882         (advance, posn, abstract_read_memory): New functions.
2883         [struct mem_read_abstraction]: New struct.
2884         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2885
2886 2019-05-14  Tom Tromey  <tromey@adacore.com>
2887
2888         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2889         value is not lval_memory.
2890
2891 2019-05-14  Tom Tromey  <tromey@adacore.com>
2892
2893         * solib.c (info_sharedlibrary_command): Style the file name.
2894
2895 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2896
2897         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2898         (aarch64_vnv_type): Likewise.
2899         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2900         * common/tdesc.c: Likewise.
2901         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2902         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2903         * features/aarch64-fpu.xml: Add ieee half view.
2904         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2905         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2906         * gdbtypes.h (struct builtin_type): Likewise.
2907         (struct objfile_type): Likewise.
2908
2909 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2910
2911         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2912         typo.
2913         * location.h (string_to_event_location): Likewise.
2914
2915 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2916
2917         GDB 8.3 released.
2918
2919 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2920
2921         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2922         New variable declaration.
2923         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2924         New variable.
2925         (print_one_breakpoint): Use ui_out::test_flags and new global
2926         variable to compute use_fixed_output.
2927         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2928         Remove.
2929         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2930         (mi_multi_location_breakpoint_output_fixed): Remove.
2931         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2932         new variable.
2933         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2934         fix_multi_location_breakpoint_output flag if version >= 3.
2935         * ui-out.h (enum ui_out_flag)
2936         <fix_multi_location_breakpoint_output>: New enumerator.
2937
2938 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2939
2940         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2941
2942 2019-05-10  Tom Tromey  <tromey@adacore.com>
2943
2944         * ada-lang.c (catch_ada_completer): New function.
2945         (_initialize_ada_language): Use it.
2946
2947 2019-05-10  Tom Tromey  <tromey@adacore.com>
2948
2949         * thread.c (print_thread_info): Make "requested_threads" const.
2950         * gdbthread.h (print_thread_info): Make "requested_threads"
2951         const.
2952         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2953         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2954
2955 2019-05-08  Tom Tromey  <tom@tromey.com>
2956
2957         * gdbtypes.c (objfile_type_data): Change type.
2958         (objfile_type, _initialize_gdbtypes): Update.
2959
2960 2019-05-08  Tom Tromey  <tom@tromey.com>
2961
2962         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2963         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2964         (_initialize_dwarf2_frame): Update.
2965
2966 2019-05-08  Tom Tromey  <tom@tromey.com>
2967
2968         * objc-lang.c (objc_objfile_data): Change type.
2969         (find_methods): Update.
2970         (_initialize_objc_lang): Remove.
2971
2972 2019-05-08  Tom Tromey  <tom@tromey.com>
2973
2974         * stabsread.c (rs6000_builtin_type_data): Change type.
2975         (rs6000_builtin_type, _initialize_stabsread): Update.
2976
2977 2019-05-08  Tom Tromey  <tom@tromey.com>
2978
2979         * mips-tdep.c (mips_pdr_data): Remove.
2980         (_initialize_mips_tdep): Update.
2981
2982 2019-05-08  Tom Tromey  <tom@tromey.com>
2983
2984         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2985         (hppa_init_objfile_priv_data, read_unwind_info)
2986         (find_unwind_entry, _initialize_hppa_tdep): Update.
2987
2988 2019-05-08  Tom Tromey  <tom@tromey.com>
2989
2990         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2991         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2992         on obstack.
2993         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2994
2995 2019-05-08  Tom Tromey  <tom@tromey.com>
2996
2997         * mdebugread.c (basic_type_data): Change type.
2998         (basic_type, _initialize_mdebugread): Update.
2999
3000 2019-05-08  Tom Tromey  <tom@tromey.com>
3001
3002         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3003
3004 2019-05-08  Tom Tromey  <tom@tromey.com>
3005
3006         * nto-tdep.c (nto_inferior_data_reg): Change type.
3007         (nto_inferior_data): Update.
3008         (nto_inferior_data_cleanup, nto_new_inferior_data)
3009         (_initialize_nto_tdep): Remove.
3010         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3011
3012 2019-05-08  Tom Tromey  <tom@tromey.com>
3013
3014         * ada-lang.c (struct ada_inferior_data): Add initializers.
3015         (ada_inferior_data): Change type.
3016         (ada_inferior_data_cleanup): Remove.
3017         (get_ada_inferior_data, ada_inferior_exit)
3018         (struct ada_pspace_data): Add initializers, destructor.
3019         (ada_pspace_data_handle): Change type.
3020         (get_ada_pspace_data): Update.
3021         (ada_pspace_data_cleanup): Remove.
3022
3023 2019-05-08  Tom Tromey  <tom@tromey.com>
3024
3025         * coffread.c (struct coff_symfile_info): Add initializers.
3026         (coff_objfile_data_key): Move lower.  Change type.
3027         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3028         Update.
3029         (coff_free_info): Remove.
3030
3031 2019-05-08  Tom Tromey  <tom@tromey.com>
3032
3033         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3034         (fbsd_pspace_data_handle): Move lower.  Change type.
3035         (get_fbsd_pspace_data): Update.
3036         (fbsd_pspace_data_cleanup): Remove.
3037         (_initialize_fbsd_tdep): Update.
3038
3039 2019-05-08  Tom Tromey  <tom@tromey.com>
3040
3041         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3042         (get_ada_tasks_pspace_data): Update.
3043         (ada_tasks_pspace_data_cleanup): Remove.
3044         (_initialize_tasks): Update.
3045         (ada_tasks_inferior_data_handle): Change type.
3046         (get_ada_tasks_inferior_data): Update.
3047         (ada_tasks_inferior_data_cleanup): Remove.
3048         (struct ada_tasks_pspace_data): Add initializers.
3049
3050 2019-05-08  Tom Tromey  <tom@tromey.com>
3051
3052         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3053         * symfile-debug.c (debug_sym_get_probes): Change type.
3054         * stap-probe.c (handle_stap_probe):
3055         (stap_static_probe_ops::get_probes): Change type.
3056         * probe.h (class static_probe_ops) <get_probes>: Change type.
3057         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3058         (parse_probes_in_pspace): Update.
3059         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3060         Update.
3061         (any_static_probe_ops::get_probes): Change type.
3062         * elfread.c (elfread_data): New typedef.
3063         (probe_key): Change type.
3064         (elf_get_probes): Likewise.  Update.
3065         (probe_key_free): Remove.
3066         (_initialize_elfread): Update.
3067         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3068         Change type.
3069         (dtrace_process_dof_probe, dtrace_process_dof)
3070         (dtrace_static_probe_ops::get_probe): Change type.
3071
3072 2019-05-08  Tom Tromey  <tom@tromey.com>
3073
3074         * xcoffread.c (struct xcoff_symfile_info): Rename from
3075         coff_symfile_info.  Add initializers.
3076         (xcoff_objfile_data_key): Move lower.  Change type.
3077         (XCOFF_DATA): Rewrite.
3078         (xcoff_free_info): Remove.
3079         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3080         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3081         (xcoff_initial_scan): Update.
3082
3083 2019-05-08  Tom Tromey  <tom@tromey.com>
3084
3085         * solib-svr4.c (struct svr4_info): Add initializers and
3086         destructor.
3087         <probes_table>: Now an htab_up.
3088         (solib_svr4_pspace_data): Change type.
3089         (free_probes_table): Simplify.
3090         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3091         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3092         (probes_table_remove_objfile_probes, register_solib_event_probe)
3093         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3094         (_initialize_svr4_solib): Update.
3095
3096 2019-05-08  Tom Tromey  <tom@tromey.com>
3097
3098         * remote.c (remote_pspace_data): Change type.
3099         (remote_pspace_data_cleanup): Remove.
3100         (get_remote_exec_file, set_pspace_remote_exec_file)
3101         (_initialize_remote): Update.
3102
3103 2019-05-08  Tom Tromey  <tom@tromey.com>
3104
3105         * breakpoint.c (breakpoint_objfile_key): Change type.
3106         (get_breakpoint_objfile_data): Update.
3107         (free_breakpoint_objfile_data): Remove.
3108         (_initialize_breakpoint): Update.
3109
3110 2019-05-08  Tom Tromey  <tom@tromey.com>
3111
3112         * linux-tdep.c (struct linux_info): Add initializers.
3113         (linux_inferior_data): Move.  Change type.
3114         (invalidate_linux_cache_inf): Update.
3115         (linux_inferior_data_cleanup): Remove.
3116         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3117
3118 2019-05-08  Tom Tromey  <tom@tromey.com>
3119
3120         * auxv.c (auxv_inferior_data): Move.  Change type.
3121         (auxv_inferior_data_cleanup): Remove.
3122         (invalidate_auxv_cache_inf): Rewrite.
3123         (get_auxv_inferior_data, _initialize_auxv): Update.
3124
3125 2019-05-08  Tom Tromey  <tom@tromey.com>
3126
3127         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3128         (symfile_debug_objfile_data_key): Change type.
3129         (symfile_debug_installed, debug_qf_has_symbols)
3130         (debug_qf_find_last_source_symtab)
3131         (debug_qf_forget_cached_source_info)
3132         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3133         (debug_qf_print_stats, debug_qf_dump)
3134         (debug_qf_expand_symtabs_for_function)
3135         (debug_qf_expand_all_symtabs)
3136         (debug_qf_expand_symtabs_with_fullname)
3137         (debug_qf_map_matching_symbols)
3138         (debug_qf_expand_symtabs_matching)
3139         (debug_qf_find_pc_sect_compunit_symtab)
3140         (debug_qf_map_symbol_filenames)
3141         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3142         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3143         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3144         (debug_sym_read_linetable, debug_sym_relocate): Update.
3145         (symfile_debug_free_objfile): Remove.
3146         (install_symfile_debug_logging, _initialize_symfile_debug):
3147         Update.
3148
3149 2019-05-08  Tom Tromey  <tom@tromey.com>
3150
3151         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3152         allocate_on_obstack.
3153         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3154         (get_dwarf2_per_objfile): Update.
3155         (set_dwarf2_per_objfile): Remove.
3156         (dwarf2_has_info, dwarf2_get_section_info): Update.
3157         (dwarf2_free_objfile): Remove.
3158         (_initialize_dwarf2_read): Update.
3159
3160 2019-05-08  Tom Tromey  <tom@tromey.com>
3161
3162         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3163         initializers.
3164         <unsupported_script_warning_printed,
3165         script_not_found_warning_printed>: Now bool.
3166         (auto_load_pspace_data): Change type.
3167         (~auto_load_pspace_info): Rename from
3168         auto_load_pspace_data_cleanup.
3169         (get_auto_load_pspace_data, init_loaded_scripts_info)
3170         (clear_section_scripts, maybe_print_unsupported_script_warning)
3171         (maybe_print_script_not_found_warning, _initialize_auto_load):
3172         Update.
3173
3174 2019-05-08  Tom Tromey  <tom@tromey.com>
3175
3176         * objfiles.c (objfile_pspace_info): Add destructor and
3177         initializers.
3178         (objfiles_pspace_data): Change type.
3179         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3180         (get_objfile_pspace_data): Update.
3181         (objfiles_bfd_data): Change type.
3182         (get_objfile_bfd_data): Update.
3183         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3184
3185 2019-05-08  Tom Tromey  <tom@tromey.com>
3186
3187         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3188         Change type.
3189         (get_catch_syscall_inferior_data): Update.
3190         (catch_syscall_inferior_data_cleanup): Remove.
3191         (_initialize_break_catch_syscall): Update.
3192
3193 2019-05-08  Tom Tromey  <tom@tromey.com>
3194
3195         * inflow.c (struct terminal_info): Add destructor and
3196         initializers.
3197         (inflow_inferior_data): Change type.
3198         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3199         (get_inflow_inferior_data, inflow_inferior_exit)
3200         (swap_terminal_info, _initialize_inflow): Update.
3201
3202 2019-05-08  Tom Tromey  <tom@tromey.com>
3203
3204         * target-dcache.c (target_dcache_cleanup): Remove.
3205         (target_dcache_aspace_key): Change type.
3206         (target_dcache_init_p, target_dcache_invalidate)
3207         (target_dcache_get, target_dcache_get_or_init)
3208         (_initialize_target_dcache): Update.
3209         * dcache.h (struct dcache_deleter): New.
3210
3211 2019-05-08  Tom Tromey  <tom@tromey.com>
3212
3213         * symtab.c (struct symbol_cache): Add destructor and
3214         initializers.
3215         (symbol_cache_key): Move.  Change type.
3216         (make_symbol_cache, free_symbol_cache): Remove.
3217         (get_symbol_cache): Update.
3218         (symbol_cache_cleanup): Remove.
3219         (ALL_PSPACES, symbol_cache_flush)
3220         (maintenance_print_symbol_cache)
3221         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3222         Update.
3223
3224 2019-05-08  Tom Tromey  <tom@tromey.com>
3225
3226         * symtab.c (struct main_info): Add destructor and initializers.
3227         (main_progspace_key): Move.  Change type.
3228         (get_main_info): Update.
3229         (main_info_cleanup): Remove.
3230         (_initialize_symtab): Update.
3231
3232 2019-05-08  Tom Tromey  <tom@tromey.com>
3233
3234         * registry.h (DECLARE_REGISTRY): Define the _key class.
3235
3236 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3237
3238         * NEWS: Merge two 'New commands' sections.
3239
3240 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3241
3242         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3243         parameter and use Ada language definition instead.
3244         (ada_val_print_ptr): Remove unused language parameter.
3245         (ada_val_print_num): Remove language parameter and use Ada language
3246         definition instead.
3247         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3248         parameter.
3249         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3250         parameter and use Ada language definition instead.
3251         (ada_val_print_1): Update all ada_val_print_xxx calls.
3252         Remove language parameter.
3253         (ada_val_print): Update ada_val_print_1 call.
3254
3255 2019-05-08  Tom Tromey  <tromey@adacore.com>
3256
3257         * remote.c (remote_hw_watchpoint_limit)
3258         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3259         Now static.
3260
3261 2019-05-08  Tom Tromey  <tromey@adacore.com>
3262
3263         * maint.c (_initialize_maint_cmds): Move initialization code to
3264         remote.c.
3265         (watchdog, show_watchdog): Move to remote.c.
3266         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3267         "watchdog" static.
3268         (_initialize_remote): Move initialization code from maint.c.
3269         * defs.h (watchdog): Don't declare.
3270
3271 2019-05-08  Tom Tromey  <tromey@adacore.com>
3272
3273         * tui/tui-interp.c: Include main.h.
3274         * interps.c: Include main.h.
3275         * main.h (interpreter_p): Declare.
3276         * defs.h (interpreter_p): Don't declare.
3277
3278 2019-05-08  Tom Tromey  <tromey@adacore.com>
3279
3280         * dwarf2loc.c: Include dwarf2read.h.
3281         * defs.h (read_unsigned_leb128): Don't declare.
3282         * dwarf2read.h (read_unsigned_leb128): Declare.
3283
3284 2019-05-08  Tom Tromey  <tromey@adacore.com>
3285
3286         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3287         method.
3288
3289 2019-05-08  Tom Tromey  <tromey@adacore.com>
3290
3291         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3292         when no wrap column is set.
3293
3294 2019-05-08  Tom Tromey  <tromey@adacore.com>
3295
3296         * c-lang.c (c_get_string): Handle non-C-style arrays.
3297
3298 2019-05-08  Tom Tromey  <tromey@adacore.com>
3299
3300         * typeprint.c (print_offset_data::update): Print the bit offset,
3301         not the number of bits remaining.
3302
3303 2019-05-08  Tom Tromey  <tromey@adacore.com>
3304
3305         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3306         padding at end of comment.
3307
3308 2019-05-08  Tom Tromey  <tromey@adacore.com>
3309
3310         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3311         Compare main types.
3312
3313 2019-05-06  Tom Tromey  <tom@tromey.com>
3314
3315         * common/scoped_mmap.c: Include common-defs.h.
3316         * common/scoped_mmap.h: Don't include config.h.
3317
3318 2019-05-04  Tom Tromey  <tom@tromey.com>
3319
3320         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3321         (struct aarch64_call_info): Add initializers.
3322         <si>: Now a std::vector.
3323         (pass_on_stack, aarch64_push_dummy_call): Update.
3324
3325 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3326             Tom Tromey  <tom@tromey.com>
3327
3328         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3329         (ppc_threads): Now a std::vector.  Now static.
3330         (hwdebug_find_thread_points_by_tid)
3331         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3332         Update.
3333
3334 2019-05-04  Tom Tromey  <tom@tromey.com>
3335
3336         * arc-tdep.c (arc_tdesc_init): Return bool.
3337
3338 2019-05-04  Tom Tromey  <tom@tromey.com>
3339
3340         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3341         Use gdb_assert_not_reached.
3342
3343 2019-05-04  Tom Tromey  <tom@tromey.com>
3344
3345         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3346         "false".
3347
3348 2019-05-04  Tom Tromey  <tom@tromey.com>
3349
3350         * arc-tdep.c (arc_tdesc_init): Use bool.
3351
3352 2019-05-04  Tom Tromey  <tom@tromey.com>
3353
3354         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3355
3356 2019-05-04  Tom Tromey  <tom@tromey.com>
3357
3358         * cli/cli-cmds.c (valid_command_p): Return bool.
3359
3360 2019-05-04  Tom Tromey  <tom@tromey.com>
3361
3362         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3363         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3364
3365 2019-05-04  Raul Tambre  <raul@tambre.ee>
3366
3367         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3368         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3369         operator for comparison.
3370
3371 2019-05-04  Tom Tromey  <tom@tromey.com>
3372
3373         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3374         (lookup_partial_symbol, print_partial_symbols)
3375         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3376         (psymbol_compare): Update.
3377         (add_psymbol_to_bcache): Clear the entire psymbol.
3378         (maintenance_check_psymtabs): Update.
3379         * psympriv.h (struct partial_symbol): Don't derive from
3380         general_symbol_info.
3381         <obj_section, unrelocated_address, address,
3382         set_unrelocated_address>: Update.
3383         <ginfo>: New member.
3384         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3385         (debug_names::write_psymbols): Update.
3386
3387 2019-05-04  Tom de Vries  <tdevries@suse.de>
3388
3389         * contrib/cc-with-tweaks.sh: Support -n arg.
3390
3391 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3392
3393         * corelow.c (core_target::detach): Ensure frame cache and
3394         register caches are cleared.
3395         inferior.c (exit_inferior_1): Likewise.
3396
3397 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3398             Tom Tromey  <tom@tromey.com>
3399
3400         * dictionary.c (collate_pending_symbols_by_language): Remove
3401         "struct" from foreach.
3402         * symtab.c (lookup_global_symbol_from_objfile)
3403         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3404         foreach.
3405         * ser-tcp.c (net_open): Remove "struct" from foreach.
3406         * objfiles.c (objfile_relocate, objfile_rebase)
3407         (objfile_has_symbols): Remove "struct" from foreach.
3408         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3409         from foreach.
3410         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3411         foreach.
3412         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3413         "struct" from foreach.
3414         * ada-lang.c (create_excep_cond_exprs)
3415         (ada_exception_catchpoint_cond_string): Remove "struct" from
3416         foreach.
3417
3418 2019-05-03  Tom Tromey  <tromey@adacore.com>
3419
3420         * ada-exp.y (convert_char_literal): Check suffix of each
3421         enumerator.
3422
3423 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3424
3425         PR ada/21406:
3426         * ada-exp.y (yywrap): Don't define.
3427         * ada-lex.l (%option): Add noyywrap
3428         (yywrap): Remove.
3429
3430 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3431
3432         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3433         _WIN32_WINNT to the XP level, unless already defined to a higher
3434         level.
3435
3436         * unittests/parse-connection-spec-selftests.c:
3437         * ser-tcp.c:
3438         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3439         override.
3440
3441         * symfile.c (find_separate_debug_file): Remove colon from the
3442         drive spec of DOS/Windows file names of the target, so that the
3443         file name produced from DEBUGDIR and the target's directory will
3444         be valid on DOS/Windows systems.
3445
3446 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * rust-lang.c (val_print_struct): Handle printing structures
3449         containing strings.
3450
3451 2019-05-02  Tom Tromey  <tromey@adacore.com>
3452
3453         * valarith.c (_initialize_valarith): Remove.
3454
3455 2019-05-01  Tom Tromey  <tromey@adacore.com>
3456
3457         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3458         bitfields.
3459
3460 2019-05-01  Tom Tromey  <tromey@adacore.com>
3461
3462         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3463         for big-endian copies.
3464
3465 2019-04-30  Ali Tamur  <tamur@google.com>
3466         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3467         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3468         (read_3_bytes): New function.
3469
3470 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3471
3472         * windows-nat.c (main_thread_id): Delete.
3473         (handle_output_debug_string): Replace main_thread_id by
3474         current_event.dwThreadId.
3475         (fake_create_process): Likewise.
3476         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3477         Do not set main_thread_id.
3478         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3479         current_event.dwThreadId.
3480         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3481
3482 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3483
3484         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3485         Use current_event.dwThreadId instead of main_thread_id.
3486
3487 2019-04-30  Tom Tromey  <tromey@adacore.com>
3488
3489         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3490         (create_excep_cond_exprs): Iterate over program spaces.
3491         (ada_exception_catchpoint_cond_string): Examine all minimal
3492         symbols for exception types.
3493
3494 2019-04-30  Tom Tromey  <tromey@adacore.com>
3495
3496         PR c++/24470:
3497         * dwarf2read.c (process_structure_scope): Handle case where type
3498         has template parameters but no symbol was created.
3499
3500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3501             Chris January  <chris.january@arm.com>
3502
3503         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3504         qualifier.
3505         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3506
3507 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         * f-typeprint.c (f_print_type): Update rules for printing
3510         whitespace.
3511         (f_type_print_varspec_suffix): Likewise.
3512
3513 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3514             Chris January  <chris.january@arm.com>
3515
3516         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3517         function arguments.
3518
3519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * f-lang.c (build_fortran_types): Change name of void type to
3522         lower case.
3523         * f-typeprint.c (f_type_print_base): Print the name of the void
3524         type, rather than a fixed string.
3525         * f-valprint.c (f_decorations): Use lower case void string.
3526
3527 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3528             Chris January  <chris.january@arm.com>
3529
3530         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3531         types for Fortran.
3532
3533 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3534             Chris January  <chris.january@arm.com>
3535             David Lecomber  <david.lecomber@arm.com>
3536
3537         * f-exp.y (BINOP_INTRINSIC): New token.
3538         (exp): New parser rule handling BINOP_INTRINSIC.
3539         (f77_keywords): Add new builtin procedures.
3540         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3541         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3542         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3543         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3544         (print_unop_subexp_f): New function.
3545         (print_binop_subexp_f): New function.
3546         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3547         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3548         (dump_subexp_body_f): Likewise.
3549         (operator_check_f): Likewise.
3550         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3551         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3552
3553 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3556         UNOP_KIND.
3557         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3558         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3559         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3560         (operator_length_f): New fuction.
3561         (print_subexp_f): New function.
3562         (op_name_f): New function.
3563         (dump_subexp_body_f): New function.
3564         (operator_check_f): New function.
3565         (exp_descriptor_f): Replace standard expression handling functions
3566         with new functions.
3567         * gdb/fortran-operator.def: New file.
3568         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3569         * gdb/std-operator.def: Remove UNOP_KIND.
3570
3571 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3572
3573         * std-operator.def: Remove unbalanced, stray double quote
3574         character.
3575
3576 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3577             Chris January  <chris.january@arm.com>
3578             Daniel Everett  <daniel.everett@arm.com>
3579             Nick Forrington  <nick.forrington@arm.com>
3580             Richard Bunt  <richard.bunt@arm.com>
3581
3582         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3583         of depth when printing anonymous structs or unions.
3584         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3585         Don't print either the top-level value, or the children if the
3586         max-depth is exceeded.
3587         (ppscm_print_children): When printing the key of a map, allow one
3588         extra level of depth.
3589         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3590         print either the top-level value, or the children if the max-depth
3591         is exceeded.
3592         (print_children): When printing the key of a map, allow one extra
3593         level of depth.
3594         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3595         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3596         (user_print_options): Initialise max_depth field.
3597         (val_print_scalar_or_string_type_p): New function.
3598         (val_print): Check to see if the max depth has been reached.
3599         (val_print_check_max_depth): Define new function.
3600         (show_print_max_depth): New function.
3601         (_initialize_valprint): Add 'print max-depth' option.
3602         * valprint.h (struct value_print_options) <max_depth>: New field.
3603         (val_print_check_max_depth): Declare new function.
3604         * NEWS: Document new feature.
3605
3606 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * ada-lang.c (ada_language_defn): Initialise new field.
3609         * c-lang.c (c_is_string_type_p): New function.
3610         (c_language_defn): Initialise new field.
3611         (cplus_language_defn): Initialise new field.
3612         (asm_language_defn): Initialise new field.
3613         (minimal_language_defn): Initialise new field.
3614         * c-lang.h (c_is_string_type_p): Declare new function.
3615         * d-lang.c (d_language_defn): Initialise new field.
3616         * f-lang.c (f_is_string_type_p): New function.
3617         (f_language_defn): Initialise new field.
3618         * go-lang.c (go_is_string_type_p): New function.
3619         (go_language_defn): Initialise new field.
3620         * language.c (default_is_string_type_p): New function.
3621         (unknown_language_defn): Initialise new field.
3622         (auto_language_defn): Initialise new field.
3623         * language.h (struct language_defn) <la_is_string_type_p>: New
3624         member variable.
3625         (default_is_string_type_p): Declare new function.
3626         * m2-lang.c (m2_language_defn): Initialise new field.
3627         * objc-lang.c (objc_language_defn): Initialise new field.
3628         * opencl-lang.c (opencl_language_defn): Initialise new field.
3629         * p-lang.c (pascal_is_string_type_p): New function.
3630         (pascal_language_defn): Initialise new field.
3631         * rust-lang.c (rust_is_string_type_p): New function.
3632         (rust_language_defn): Initialise new field.
3633
3634 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3637         New field.
3638         * ada-lang.c (ada_language_defn): Initialise new field.
3639         * c-lang.c (c_language_defn): Likewise.
3640         (cplus_language_defn): Likewise.
3641         (asm_language_defn): Likewise.
3642         (minimal_language_defn): Likewise.
3643         * d-lang.c (d_language_defn): Likewise.
3644         * f-lang.c (f_language_defn): Likewise.
3645         * go-lang.c (go_language_defn): Likewise.
3646         * language.c (unknown_language_defn): Likewise.
3647         (auto_language_defn): Likewise.
3648         * m2-lang.c (m2_language_defn): Likewise.
3649         * objc-lang.c (objc_language_defn): Likewise.
3650         * opencl-lang.c (opencl_language_defn): Likewise.
3651         * p-lang.c (pascal_language_defn): Likewise.
3652         * rust-lang.c (rust_language_defn): Likewise.
3653
3654 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * ada-lang.c (ada_is_character_type): Change return type to bool.
3657         (ada_is_string_type): Likewise.
3658         * ada-lang.h (ada_is_character_type): Update declaration
3659         (ada_is_string_type): Likewise.
3660
3661 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3662
3663         Support style in 'frame|thread apply'
3664
3665         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3666         * record.c (record_start, record_stop): Update callers of
3667         execute_command_to_string with false.
3668         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3669         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3670         methods.
3671         (class string_file): New constructor with term_out parameter.
3672         Override methods term_out and can_emit_style_escape.  New member
3673         term_out.
3674         (class stdio_file): Override can_emit_style_escape.
3675         (class tee_file): Override term_out and can_emit_style_escape.
3676         * utils.h (can_emit_style_escape): Remove.
3677         * utils.c (can_emit_style_escape): Likewise.
3678         Update all callers of can_emit_style_escape (SOMESTREAM) to
3679         SOMESTREAM->can_emit_style_escape.
3680         * source-cache.c (source_cache::get_source_lines): Likewise.
3681         * stack.c (frame_apply_command_count): Call execute_command_to_string
3682         passing the term_out characteristic of the current gdb_stdout.
3683         * thread.c (thr_try_catch_cmd): Likewise.
3684         * top.c (execute_command_to_string): pass term_out parameter
3685         to construct the string_file for the command output.
3686         * ui-file.c (term_cli_styling): New function (most code moved
3687         from utils.c can_emit_style_escape).
3688         (string_file::string_file, string_file::can_emit_style_escape,
3689         stdio_file::can_emit_style_escape, tee_file::term_out,
3690         tee_file::can_emit_style_escape): New functions.
3691
3692 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3693
3694         * NEWS: Mention the new set|show may-call-functions.
3695         * infcall.c (may_call_functions_p): New variable.
3696         (show_may_call_functions_p): New function.
3697         (call_function_by_hand_dummy): Throws an error if not
3698         may-call-functions.
3699         (_initialize_infcall): Call add_setshow_boolean_cmd for
3700         may-call-functions.
3701
3702 2019-04-25  Keith Seitz  <keiths@redhat.com>
3703
3704         PR c++/24367
3705         * cp-support.c (inspect_type): Don't attempt substitutions
3706         of symbol with the same name.
3707
3708 2019-04-25  Tom Tromey  <tromey@adacore.com>
3709
3710         PR gdb/24475:
3711         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3712         static.
3713
3714 2019-04-25  Tom Tromey  <tromey@adacore.com>
3715
3716         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3717         rvalue reference.
3718         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3719         (gdb_xml_parser::parse): Use std::move.
3720         * python/python-internal.h (gdbpy_convert_exception): Take a const
3721         reference.
3722         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3723         std::move.
3724         * python/py-utils.c (gdbpy_convert_exception): Take a const
3725         reference.
3726         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3727         Use std::move.
3728         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3729         Use std::move.
3730         * mi/mi-main.c (mi_print_exception): Take a const reference.
3731         * main.c (handle_command_errors): Take a const reference.
3732         * linespec.c (parse_linespec): Use std::move.
3733         * infcall.c (run_inferior_call): Use std::move.
3734         (call_function_by_hand_dummy): Use std::move.
3735         * exec.c (try_open_exec_file): Use std::move.
3736         * exceptions.h (exception_print, exception_fprintf)
3737         (exception_print_same): Update.
3738         * exceptions.c (print_exception, exception_print)
3739         (exception_fprintf, exception_print_same): Change parameters to
3740         const reference.
3741         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3742         * common/new-op.c: Use std::move.
3743         * common/common-exceptions.h (struct gdb_exception): Add move
3744         constructor.
3745         (struct gdb_exception_error, struct gdb_exception_quit, struct
3746         gdb_quit_bad_alloc): Change constructor to move constructor.
3747         (throw_exception): Change parameter to rvalue reference.
3748         * common/common-exceptions.c (throw_exception): Take rvalue
3749         reference.
3750         * cli/cli-interp.c (safe_execute_command): Use std::move.
3751         * breakpoint.c (insert_bp_location, location_to_sals): Use
3752         std::move.
3753
3754 2019-04-25  Tom Tromey  <tromey@adacore.com>
3755
3756         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3757         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3758         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3759         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3760         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3761         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3762         guile/scm-value.c: Use unpack.
3763         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3764         gdbscm_gdb_exception.
3765         (gdbscm_throw_gdb_exception): Likewise.
3766         (struct gdbscm_gdb_exception): New.
3767         (unpack): New function.
3768         (gdbscm_wrap): Use unpack.
3769
3770 2019-04-25  Tom Tromey  <tromey@adacore.com>
3771
3772         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3773         (gdb_rl_callback_handler): Use std::move.
3774         * common/common-exceptions.h (struct gdb_exception): Add move
3775         assignment operator.
3776         (throw_exception_sjlj): Change "exception" to const reference.
3777         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3778         (throw_exception_sjlj): Change "exception" to const reference.
3779
3780 2019-04-25  Tom Tromey  <tromey@adacore.com>
3781
3782         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3783         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3784         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3785         Update.
3786         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3787         Update.
3788         * mi/mi-interp.c (mi_interp::exec): Update.
3789         * linespec.c (parse_linespec): Update.
3790         * infcall.c (run_inferior_call): Update.
3791         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3792         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3793         (gdbscm_lookup_global_symbol): Update.
3794         * guile/scm-param.c (gdbscm_parameter_value): Update.
3795         * guile/scm-frame.c (gdbscm_frame_read_register)
3796         (gdbscm_frame_read_var): Update.
3797         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3798         * exec.c (try_open_exec_file): Update.
3799         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3800         (gdb_rl_callback_handler): Update.
3801         * common/common-exceptions.h (exception_none): Don't declare.
3802         * common/common-exceptions.c (exception_none): Don't define.
3803         (struct catcher) <exception>: Update.
3804         * cli/cli-interp.c (safe_execute_command): Update.
3805         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3806
3807 2019-04-25  Ali Tamur  <tamur@google.com>
3808
3809         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3810         (read_attribute_value): Likewise.
3811         (dwarf2_read_addr_index): Update comment.
3812         (read_str_index): Add DW_FORM_strx.
3813         (dwarf2_string_attr): Likewise.
3814         (dwarf2_const_value_attr): Likewise.
3815         (dump_die_shallow): Likewise.
3816         (dwarf2_fetch_constant_bytes): Likewise.
3817         (skip_form_bytes): Likewise.
3818         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3819
3820 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3821
3822         PR corefiles/11608
3823         PR corefiles/18187
3824         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3825         OFFSET.  Verify if current mapping contains an ELF header.
3826         (linux_find_memory_regions_full): Adjust call to
3827         dump_mapping_p.
3828
3829 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3830             Kang Li <kanglictf@gmail.com>
3831
3832         PR gdb/21600
3833
3834         * dwarf2-frame.c (read_initial_length): Be consistent about using
3835         unsigned representation of length.
3836         (decode_frame_entry_1): Likewise.  Check for wraparound of
3837         end pointer as well as buffer overflow.
3838
3839 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3840
3841         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3842         "vq".
3843
3844 2019-04-24  Tom Tromey  <tromey@adacore.com>
3845
3846         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3847
3848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * s12z-tdep.c (s12z_unwind_pc): Delete.
3851         (s12z_unwind_sp): Delete.
3852         (s12z_gdbarch_init): Don't register deleted functions with
3853         gdbarch.
3854
3855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * rl78-tdep.c (rl78_unwind_sp): Delete.
3858         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3859
3860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3863         (xstormy16_unwind_pc): Delete.
3864         (xstormy16_dummy_id): Delete.
3865         (xstormy16_gdbarch_init): Don't register deleted functions with
3866         gdbarch.
3867
3868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * vax-tdep.c (vax_unwind_pc): Delete.
3871         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3872
3873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * v850-tdep.c (v850_unwind_sp): Delete.
3876         (v850_unwind_pc): Delete.
3877         (v850_dummy_id): Delete.
3878         (v850_gdbarch_init): Don't register deleted functions with
3879         gdbarch.
3880
3881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3882
3883         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3884         (tilegx_unwind_pc): Delete.
3885         (tilegx_unwind_dummy_id): Delete.
3886         (tilegx_gdbarch_init): Don't register deleted functions with
3887         gdbarch.
3888
3889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3892         (tic6x_dummy_id): Delete.
3893         (tic6x_gdbarch_init): Don't register deleted functions with
3894         gdbarch.
3895
3896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * sparc-tdep.c (sparc_unwind_pc): Delete.
3899         (sparc32_gdbarch_init): Don't register deleted function with
3900         gdbarch.
3901
3902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * sh-tdep.c (sh_unwind_sp): Delete.
3905         (sh_unwind_pc): Delete.
3906         (sh_dummy_id): Delete.
3907         (sh_gdbarch_init): Don't register deleted functions with
3908         gdbarch.
3909
3910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * score-tdep.c (score_unwind_sp): Delete.
3913         (score_unwind_pc): Delete.
3914         (score_dummy_id): Delete.
3915         (score_gdbarch_init): Don't register deleted functions with
3916         gdbarch.
3917
3918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * rx-tdep.c (rx_unwind_pc): Delete.
3921         (rx_unwind_sp): Delete.
3922         (rx_dummy_id): Delete.
3923         (rx_gdbarch_init): Don't register deleted functions with
3924         gdbarch.  Update comment.
3925
3926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3929         (rs6000_dummy_id): Delete.
3930         (rs6000_gdbarch_init): Don't register deleted functions with
3931         gdbarch.
3932
3933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * or1k-tdep.c (or1k_dummy_id): Delete.
3936         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3937
3938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * nios2-tdep.c (nios2_dummy_id): Delete.
3941         (nios2_unwind_sp): Delete.
3942         (nios2_gdbarch_init): Don't register deleted functions with
3943         gdbarch.
3944
3945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * nds32-tdep.c (nds32_dummy_id): Delete.
3948         (nds32_unwind_pc): Delete.
3949         (nds32_unwind_sp): Delete.
3950         (nds32_gdbarch_init): Don't register deleted functions with
3951         gdbarch.
3952
3953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * msp430-tdep.c (msp430_unwind_pc): Delete.
3956         (msp430_unwind_sp): Delete.
3957         (msp430_dummy_id): Delete.
3958         (msp430_gdbarch_init): Don't register deleted functions with
3959         gdbarch.
3960
3961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * moxie-tdep.c (moxie_unwind_sp): Delete.
3964         (moxie_unwind_pc): Delete.
3965         (moxie_dummy_id): Delete.
3966         (moxie_gdbarch_init): Don't register deleted functions with
3967         gdbarch.
3968
3969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3972         (mn10300_unwind_pc): Delete.
3973         (mn10300_unwind_sp): Delete.
3974         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3975         mn10300_unwind_sp.
3976         (mn10300_frame_unwind_init): Don't register deleted functions with
3977         gdbarch.
3978
3979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3980
3981         * mep-tdep.c (mep_unwind_pc): Delete.
3982         (mep_unwind_sp): Delete.
3983         (mep_dummy_id): Delete.
3984         (mep_gdbarch_init): Don't register deleted functions with
3985         gdbarch.
3986
3987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3990         (m68hc11_unwind_sp): Delete.
3991         (m68hc11_gdbarch_init): Don't register deleted functions with
3992         gdbarch.
3993
3994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3995
3996         * m32r-tdep.c (m32r_unwind_sp): Delete.
3997         (m32r_unwind_pc): Delete.
3998         (m32r_dummy_id): Delete.
3999         (m32r_gdbarch_init): Don't register deleted functions with
4000         gdbarch.
4001
4002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * m32c-tdep.c (m32c_unwind_pc): Delete.
4005         (m32c_unwind_sp): Delete.
4006         (m32c_dummy_id): Delete.
4007         (m32c_gdbarch_init): Don't register deleted functions with
4008         gdbarch.
4009
4010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4011
4012         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4013         (lm32_unwind_pc): Delete.
4014         (lm32_dummy_id): Delete.
4015         (lm32_gdbarch_init): Don't register deleted functions with
4016         gdbarch.
4017
4018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4019
4020         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4021         (iq2000_unwind_pc): Delete.
4022         (iq2000_dummy_id): Delete.
4023         (iq2000_gdbarch_init): Don't register deleted functions with
4024         gdbarch.
4025
4026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * nds32-tdep.c (nds32_type_align): Delete.
4029         (nds32_push_dummy_call): Use type_align instead.
4030
4031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4032
4033         * arm-tdep.c (arm_type_align): Only handle vector override case.
4034         (arm_push_dummy_call): Use type_align.
4035         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4036
4037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4038
4039         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4040         case.
4041         (pass_on_stack): Use type_align.
4042         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4043         function.
4044
4045 2019-04-23  Tom Tromey  <tromey@adacore.com>
4046
4047         * dwarf2read.c (line_header::file_name_at): Remove unused
4048         overload.
4049
4050 2019-04-23  Tom de Vries  <tdevries@suse.de>
4051
4052         PR gdb/24438
4053         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4054         invocation.
4055
4056
4057 2019-03-27  Ali Tamur  <tamur@google.com>
4058
4059         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4060         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4061         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4062         (dwarf_expr_context::get_addr_index): Likewise
4063         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4064         (symbol_needs_eval_context::get_addr_index): Likewise
4065         (disassemble_dwarf_expression): Add DW_OP_addrx
4066         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4067         (read_cutu_die_from_dwo): Update comment
4068         (skip_one_die): Add DW_FORM_addrx
4069         (read_attribute_value): Likewise
4070         (var_decode_location): Add DW_OP_addrx
4071         (dwarf2_const_value_attr): Add DW_FORM_addrx
4072         (dump_die_shallow): Likewise
4073         (dwarf2_fetch_constant_bytes): Likewise
4074         (decode_locdesc): Add DW_OP_addrx
4075         (skip_form_bytes): Add DW_FORM_addrx
4076
4077 2019-04-22  Ali Tamur  <tamur@google.com>
4078
4079         * MAINTAINERS (Write After Approval): Add self.
4080
4081 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4082
4083         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4084         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4085         (open_symbol_file_object): Likewise.
4086         (svr4_default_sos): Add info parameter.
4087         (svr4_read_so_list): Likewise.
4088         (svr4_current_sos_direct): Adjust functions calls to pass down
4089         info.
4090         (svr4_current_sos_1): Add info parameter.
4091         (svr4_current_sos): Call get_svr4_info, pass info down to
4092         svr4_current_sos_1.
4093         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4094         get_svr4_info.
4095         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4096         get_svr4_info.
4097         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4098         to get_svr4_info.
4099         (probes_table_remove_objfile_probes): Likewise.
4100         (register_solib_event_probe): Add info parameter.
4101         (solist_update_incremental): Pass info parameter down to
4102         svr4_read_so_list.
4103         (disable_probes_interface): Add info parameter.
4104         (svr4_handle_solib_event): Pass current_program_space to
4105         get_svr4_info.  Adjust disable_probes_interface cleanup.
4106         (svr4_create_probe_breakpoints): Add info parameter, pass it
4107         down to register_solib_event_probe.
4108         (svr4_create_solib_event_breakpoints): Add info parameter,
4109         pass it down to svr4_create_probe_breakpoints.
4110         (enable_break): Pass info down to
4111         svr4_create_solib_event_breakpoints.
4112         (svr4_solib_create_inferior_hook): Pass current_program_space to
4113         get_svr4_info.
4114         (svr4_clear_solib): Likewise.
4115
4116 2019-04-22  Pedro Alves  <palves@redhat.com>
4117
4118         * solib-svr4.c (svr4_free_objfile_observer): New.
4119         (probe_and_action::objfile): New field.
4120         (probes_table_htab_remove_objfile_probes)
4121         (probes_table_remove_objfile_probes): New functions.
4122         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4123         in the new probe_and_action.  Don't store the probe in 'lookup'.
4124         (svr4_create_probe_breakpoints): Pass objfile to
4125         register_solib_event_probe.
4126         (_initialize_svr4_solib): Register a free_objfile observer.
4127
4128 2019-04-19  Tom Tromey  <tom@tromey.com>
4129
4130         * common/queue.h: Remove.
4131
4132 2019-04-19  Tom Tromey  <tom@tromey.com>
4133
4134         * event-loop.c: Don't include "common/queue.h".
4135
4136 2019-04-19  Tom Tromey  <tom@tromey.com>
4137
4138         * remote.c (remote_target): Use delete.
4139         * remote-notif.h: Include <list>, not "common/queue.h".
4140         (notif_client_p): Remove typedef.
4141         (remote_notif_state): Add constructor, destructor, initializer.
4142         <notif_queue>: Now a std::list.
4143         (remote_notif_state_xfree): Don't declare.
4144         * remote-notif.c (remote_notif_process, handle_notification)
4145         (remote_notif_state_allocate): Update.
4146         (~remote_notif_state): Rename from remote_notif_state_xfree.
4147
4148 2019-04-19  Tom Tromey  <tom@tromey.com>
4149
4150         * symfile.c (reread_symbols): Update.
4151         * objfiles.c (objfile_register_static_link)
4152         (objfile_lookup_static_link): Update
4153         (~objfile) Don't delete static_links.
4154         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4155
4156 2019-04-19  Tom Tromey  <tom@tromey.com>
4157
4158         * type-stack.h (struct type_stack) <insert>: Constify string.
4159         * type-stack.c (type_stack::insert): Constify string.
4160         * gdbtypes.h (lookup_template_type): Update.
4161         (address_space_name_to_int): Update.
4162         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4163         const.
4164         (lookup_template_type): Make name const.
4165         * c-exp.y: Update rules.
4166         (lex_one_token, classify_name, classify_inner_name)
4167         (c_print_token): Update.
4168         * p-exp.y: Update rules.
4169         (yylex): Update.
4170         * f-exp.y: Update rules.
4171         (yylex): Update.
4172         * d-exp.y: Update rules.
4173         (lex_one_token, classify_name, classify_inner_name): Update.
4174         * parse.c (write_dollar_variable, copy_name): Return std::string.
4175         * parser-defs.h (copy_name): Change return type.
4176         * m2-exp.y: Update rules.
4177         (yylex): Update.
4178         * go-exp.y (lex_one_token): Update.
4179         Update rules.
4180         (classify_unsafe_function, classify_packaged_name)
4181         (classify_name, yylex): Update.
4182
4183 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4184
4185         * configure.ac: add --enable-source-highlight switch.
4186         * configure: Regenerate.
4187         * top.c (print_gdb_version): plumb --enable-source-highlight
4188         status to "show configuration".
4189
4190 2019-04-19  Tom Tromey  <tromey@adacore.com>
4191
4192         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4193         Check ADA_TYPE_P.
4194         (empty_record, ada_template_to_fixed_record_type_1)
4195         (template_to_static_fixed_type)
4196         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4197         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4198         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4199         macros.
4200
4201 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4202
4203         PR symtab/24423:
4204         * source.c (print_source_lines_base): Advance "iter" when a
4205         control character is seen.
4206
4207 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4208
4209         * inferior.h (struct infcall_suspend_state_deleter):
4210         Catch exception in destructor to avoid crash.
4211
4212 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4213
4214         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4215         close to the add_com "shell".
4216
4217 2019-04-18  Tom Tromey  <tromey@adacore.com>
4218
4219         * process-stratum-target.h (class process_stratum_target)
4220         <stratum>: Add "final".
4221
4222 2019-04-17  Tom Tromey  <tromey@adacore.com>
4223
4224         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4225         against nullptr before use.
4226
4227 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4228
4229         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4230
4231 2019-04-17  Jim Wilson  <jimw@sifive.com>
4232             Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4235         code read might fail, assume 4-byte breakpoint in that case.
4236
4237 2019-04-15  Leszek Swirski  <leszeks@google.com>
4238
4239         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4240         rather than a hand-rolled POD check when checking for forced MEMORY
4241         classification.
4242
4243 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4244
4245         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4246         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4247         function.
4248         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4249         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4250         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4251         declaration.
4252
4253 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4254
4255         * aarch64-linux-nat.c
4256         (aarch64_linux_nat_target::thread_architecture): Add override.
4257         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4258         each VQ.
4259
4260 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4261
4262         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4263
4264 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4267         target types of size 96-bits, add some additional comments, and
4268         check that the builtin type we found was the correct size.
4269
4270 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4271
4272         * utils.c (prompt_for_continue): Don't restore the styling at the
4273         end, as applied_style has the wrong value.  This fixes styling in
4274         long lists of file names that are interrupted by the "Continue?"
4275         prompt.
4276
4277 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4280         * c-lang.c (c_language_defn): Likewise.
4281         (cplus_language_defn): Likewise.
4282         (asm_language_defn): Likewise.
4283         (minimal_language_defn): Likewise.
4284         * d-lang.c (d_language_defn): Likewise.
4285         * f-lang.c (f_language_defn): Likewise.
4286         * go-lang.c (go_language_defn): Likewise.
4287         * language.c (unknown_language_defn): Likewise.
4288         (auto_language_defn): Likewise.
4289         * language.h (struct language_defn): Remove la_magic field.
4290         (LANG_MAGIC): Delete.
4291         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4292         * objc-lang.c (objc_language_defn): Likewise.
4293         * opencl-lang.c (opencl_language_defn): Likewise.
4294         * p-lang.c (pascal_language_defn): Likewise.
4295         * rust-lang.c (rust_language_defn): Likewise.
4296
4297 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4298
4299         * riscv-tdep.c (riscv_type_align): New function.
4300         (riscv_type_alignment): Delete.
4301         (riscv_arg_location): Use 'type_align'.
4302         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4303
4304 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4305
4306         * gdbtypes.c (type_align): A struct with no non-static fields also
4307         has alignment of 1.
4308
4309 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4312         component to 0.
4313         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4314         member.
4315         (riscv_struct_info::analyse): New implementation using new
4316         analyse_inner member function.
4317         (riscv_struct_info::field_offset): New member function.
4318         (riscv_struct_info::m_offsets): New member variable.
4319         (riscv_struct_info::analyse_inner): New private member function,
4320         takes the old implementation of riscv_struct_info::analyse but
4321         extended to track field offsets.
4322         (riscv_call_arg_struct): Update the struct folding special cases
4323         to handle cases where empty C++ structs, which are non-zero
4324         length, are found.
4325         (riscv_arg_location): Initialise the length of each location, a
4326         non-zero length now indicates the location is in use.
4327         (riscv_push_dummy_call): Allow for the first location having a
4328         non-zero offset when setting up arguments.
4329         (riscv_return_value): Likewise, but for return values.
4330
4331 2019-04-11  Tom Tromey  <tromey@adacore.com>
4332
4333         * utils.c (internal_vproblem): Make "msg" const.
4334
4335 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4336
4337         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4338         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4339         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4340         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4341
4342 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4343
4344         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4345         function.
4346         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4347         of amd64_collect_native_gregset.
4348         (amd64_linux_nat_target::store_registers): Likewise.
4349
4350 2019-04-10  Tom Tromey  <tom@tromey.com>
4351
4352         * symtab.c (lookup_global_symbol_from_objfile)
4353         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4354         * objfiles.h (class separate_debug_iterator): New.
4355         (class separate_debug_range): New.
4356         (struct objfile) <separate_debug_objfiles>: New method.
4357         (objfile_separate_debug_iterate): Don't declare.
4358         * objfiles.c (separate_debug_iterator::operator++): Rename from
4359         objfile_separate_debug_iterate.
4360         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4361         iterator.
4362         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4363         iterator.
4364
4365 2019-04-10  Tom Tromey  <tom@tromey.com>
4366
4367         * symfile.c (reread_symbols): Remove old comment.
4368         * objfiles.c (free_all_objfiles): Fix a typo.
4369
4370 2019-04-10  Tom Tromey  <tom@tromey.com>
4371
4372         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4373         * minsyms.c (lookup_minimal_symbol): Use foreach.
4374         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4375         (lookup_minimal_symbol_solib_trampoline): Likewise.
4376         * symfile.c (reread_symbols): Use foreach.
4377
4378 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4379             Tom Tromey  <tromey@adacore.com>
4380
4381         PR rust/24414:
4382         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4383         (rust_lex_int_test): Change "value" to be LONGEST.
4384         (rust_lex_tests): Add test for long integer literal.
4385
4386 2019-04-09  Tom Tromey  <tromey@adacore.com>
4387
4388         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4389         to bool.
4390         (extended_remote_target::attach): Update.
4391         (remote_target::remote_notice_new_inferior): Update.
4392         (remote_target::add_current_inferior_and_thread): Update.
4393         * inferior.c (exit_inferior_1): Use "false".
4394         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4395
4396 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4397
4398         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4399         the "start" command.
4400
4401 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4402
4403         * python/py-inferior.c (infpy_thread_from_thread_handle):
4404         Adjust comments to reflect renaming of thread_from_thread_handle
4405         to thread_from_handle.  Adjust keywords.  Fix type error message.
4406         (inferior_object_methods): Add thread_from_handle.  Retain
4407         thread_from_thread_handle, but mark it as deprecated.
4408
4409 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4410
4411         * gdbthread.h (find_thread_by_handle): Revise declaration.
4412         * thread.c (find_thread_by_handle): Likewise.  Adjust
4413         implementation too.
4414         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4415         support for buffer objects as handles.
4416
4417 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4418
4419         * python/py-infthread.c (thpy_thread_handle): New function.
4420         (thread_object_methods): Register thpy_thread_handle.
4421
4422 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4423
4424         * gdbthread.h (thread_to_thread_handle): Declare.
4425         * thread.c (gdbtypes.h): Include.
4426         (thread_to_thread_handle): New function.
4427
4428         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4429         (target_thread_info_to_thread_handle): Declare.
4430         * target.c (target_thread_info_to_thread_handle): New function.
4431         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4432         * target-delegates.c: Regenerate.
4433
4434         * linux-thread-db.c (class thread_db_target): Add method
4435         thread_info_to_thread_handle.
4436         (thread_db_target::thread_info_to_thread_handle): Define.
4437         * remote.c (class remote_target): Add new method
4438         thread_info_to_thread_handle.
4439         (remote_target::thread_info_to_thread_handle): Define.
4440
4441 2019-04-08  Pedro Alves  <palves@redhat.com>
4442
4443         * common/common-exceptions.c (throw_exception): Don't create
4444         named object to throw; throw directly.
4445         (throw_it): Likewise.  Don't initialize gdb_exception::message
4446         here, with new; pass FMT and AP to the ctor instead.
4447         * common/common-exceptions.h: Include <string>.
4448         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4449         const char *, va_list)): New ctor.  Use std::make_shared.
4450         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4451         errors)): Delete.
4452         (gdb_exception_error::gdb_exception_error(enum errors, const char
4453         *, va_list)): New.
4454         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4455         Add assertion.
4456         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4457         errors)): Delete.
4458         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4459         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4460         Add assertion.
4461
4462 2019-04-08  Tom Tromey  <tom@tromey.com>
4463
4464         * valops.c (value_rtti_indirect_type): Replace throw_exception
4465         with throw.
4466         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4467         with throw.
4468         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4469         throw.
4470         * target.c (target_translate_tls_address): Replace throw_exception
4471         with throw.
4472         * stack.c (frame_apply_command_count): Replace throw_exception
4473         with throw.
4474         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4475         throw.
4476         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4477         with throw.
4478         * rs6000-tdep.c (rs6000_frame_cache)
4479         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4480         * remote.c: Replace throw_exception with throw.
4481         * record-full.c (record_full_message, record_full_wait_1)
4482         (record_full_restore): Replace throw_exception with throw.
4483         * record-btrace.c:
4484         (get_thread_current_frame_id, record_btrace_start_replaying)
4485         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4486         (cmd_record_btrace_start): Replace throw_exception with throw.
4487         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4488         throw.
4489         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4490         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4491         * linespec.c:
4492         (find_linespec_symbols): Replace throw_exception with throw.
4493         * infrun.c (displaced_step_prepare, resume): Replace
4494         throw_exception with throw.
4495         * infcmd.c (post_create_inferior): Replace throw_exception with
4496         throw.
4497         * inf-loop.c (inferior_event_handler): Replace throw_exception
4498         with throw.
4499         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4500         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4501         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4502         (get_prev_frame_always, get_frame_pc_if_available)
4503         (get_frame_address_in_block_if_available, get_frame_language):
4504         Replace throw_exception with throw.
4505         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4506         throw_exception with throw.
4507         * eval.c (fetch_subexp_value, evaluate_var_value)
4508         (evaluate_funcall, evaluate_subexp_standard): Replace
4509         throw_exception with throw.
4510         * dwarf2loc.c (call_site_find_chain)
4511         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4512         Replace throw_exception with throw.
4513         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4514         with throw.
4515         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4516         throw.
4517         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4518         * completer.c (complete_line_internal): Replace throw_exception
4519         with throw.
4520         * compile/compile-object-run.c (compile_object_run): Replace
4521         throw_exception with throw.
4522         * cli/cli-script.c (process_next_line): Replace throw_exception
4523         with throw.
4524         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4525         (btrace_enable, btrace_maint_update_pt_packets): Replace
4526         throw_exception with throw.
4527         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4528         throw_exception with throw.
4529         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4530         throw_exception with throw.
4531         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4532         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4533         * aarch64-tdep.c (aarch64_make_prologue_cache)
4534         (aarch64_make_stub_cache): Replace throw_exception with throw.
4535
4536 2019-04-08  Tom Tromey  <tom@tromey.com>
4537
4538         * common/common-exceptions.c (throw_exception): Rename from
4539         throw_exception_cxx.  Remove old copy.  Make argument const.
4540         (throw_it): Create and throw exception objects directly.
4541         * common/common-exceptions.h (throw_exception): Make argument
4542         const.
4543         (struct gdb_exception_error): Add constructor.
4544         (struct gdb_exception_quit): Add constructor.
4545
4546 2019-04-08  Tom Tromey  <tom@tromey.com>
4547
4548         * common/common-exceptions.h (exception_rethrow): Don't declare.
4549         (TRY_SJLJ): Update comment.
4550         (TRY, CATCH, END_CATCH): Remove.
4551         * common/common-exceptions.c (exception_rethrow): Remove.
4552
4553 2019-04-08  Tom Tromey  <tom@tromey.com>
4554
4555         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4556         Remove.
4557         (gdb_exception_error): Rename from
4558         gdb_exception_RETURN_MASK_ERROR.
4559         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4560         (gdb_quit_bad_alloc): Update.
4561         * aarch64-tdep.c: Update.
4562         * ada-lang.c: Update.
4563         * ada-typeprint.c: Update.
4564         * ada-valprint.c: Update.
4565         * amd64-tdep.c: Update.
4566         * arch-utils.c: Update.
4567         * break-catch-throw.c: Update.
4568         * breakpoint.c: Update.
4569         * btrace.c: Update.
4570         * c-varobj.c: Update.
4571         * cli/cli-cmds.c: Update.
4572         * cli/cli-interp.c: Update.
4573         * cli/cli-script.c: Update.
4574         * common/common-exceptions.c: Update.
4575         * common/new-op.c: Update.
4576         * common/selftest.c: Update.
4577         * compile/compile-c-symbols.c: Update.
4578         * compile/compile-cplus-symbols.c: Update.
4579         * compile/compile-object-load.c: Update.
4580         * compile/compile-object-run.c: Update.
4581         * completer.c: Update.
4582         * corelow.c: Update.
4583         * cp-abi.c: Update.
4584         * cp-support.c: Update.
4585         * cp-valprint.c: Update.
4586         * darwin-nat.c: Update.
4587         * disasm-selftests.c: Update.
4588         * dtrace-probe.c: Update.
4589         * dwarf-index-cache.c: Update.
4590         * dwarf-index-write.c: Update.
4591         * dwarf2-frame-tailcall.c: Update.
4592         * dwarf2-frame.c: Update.
4593         * dwarf2loc.c: Update.
4594         * dwarf2read.c: Update.
4595         * eval.c: Update.
4596         * event-loop.c: Update.
4597         * event-top.c: Update.
4598         * exec.c: Update.
4599         * f-valprint.c: Update.
4600         * fbsd-tdep.c: Update.
4601         * frame-unwind.c: Update.
4602         * frame.c: Update.
4603         * gdbtypes.c: Update.
4604         * gnu-v3-abi.c: Update.
4605         * guile/guile-internal.h: Update.
4606         * guile/scm-block.c: Update.
4607         * guile/scm-breakpoint.c: Update.
4608         * guile/scm-cmd.c: Update.
4609         * guile/scm-disasm.c: Update.
4610         * guile/scm-frame.c: Update.
4611         * guile/scm-lazy-string.c: Update.
4612         * guile/scm-math.c: Update.
4613         * guile/scm-param.c: Update.
4614         * guile/scm-ports.c: Update.
4615         * guile/scm-pretty-print.c: Update.
4616         * guile/scm-symbol.c: Update.
4617         * guile/scm-symtab.c: Update.
4618         * guile/scm-type.c: Update.
4619         * guile/scm-value.c: Update.
4620         * i386-linux-tdep.c: Update.
4621         * i386-tdep.c: Update.
4622         * inf-loop.c: Update.
4623         * infcall.c: Update.
4624         * infcmd.c: Update.
4625         * infrun.c: Update.
4626         * jit.c: Update.
4627         * language.c: Update.
4628         * linespec.c: Update.
4629         * linux-fork.c: Update.
4630         * linux-nat.c: Update.
4631         * linux-tdep.c: Update.
4632         * linux-thread-db.c: Update.
4633         * main.c: Update.
4634         * mi/mi-cmd-break.c: Update.
4635         * mi/mi-cmd-stack.c: Update.
4636         * mi/mi-interp.c: Update.
4637         * mi/mi-main.c: Update.
4638         * objc-lang.c: Update.
4639         * p-valprint.c: Update.
4640         * parse.c: Update.
4641         * ppc-linux-tdep.c: Update.
4642         * printcmd.c: Update.
4643         * python/py-arch.c: Update.
4644         * python/py-breakpoint.c: Update.
4645         * python/py-cmd.c: Update.
4646         * python/py-finishbreakpoint.c: Update.
4647         * python/py-frame.c: Update.
4648         * python/py-framefilter.c: Update.
4649         * python/py-gdb-readline.c: Update.
4650         * python/py-inferior.c: Update.
4651         * python/py-infthread.c: Update.
4652         * python/py-lazy-string.c: Update.
4653         * python/py-linetable.c: Update.
4654         * python/py-objfile.c: Update.
4655         * python/py-param.c: Update.
4656         * python/py-prettyprint.c: Update.
4657         * python/py-progspace.c: Update.
4658         * python/py-record-btrace.c: Update.
4659         * python/py-record.c: Update.
4660         * python/py-symbol.c: Update.
4661         * python/py-type.c: Update.
4662         * python/py-unwind.c: Update.
4663         * python/py-utils.c: Update.
4664         * python/py-value.c: Update.
4665         * python/python.c: Update.
4666         * record-btrace.c: Update.
4667         * record-full.c: Update.
4668         * remote-fileio.c: Update.
4669         * remote.c: Update.
4670         * riscv-tdep.c: Update.
4671         * rs6000-aix-tdep.c: Update.
4672         * rs6000-tdep.c: Update.
4673         * rust-exp.y: Update.
4674         * rust-lang.c: Update.
4675         * s390-tdep.c: Update.
4676         * selftest-arch.c: Update.
4677         * solib-dsbt.c: Update.
4678         * solib-frv.c: Update.
4679         * solib-spu.c: Update.
4680         * solib-svr4.c: Update.
4681         * solib.c: Update.
4682         * sparc64-linux-tdep.c: Update.
4683         * stack.c: Update.
4684         * symfile-mem.c: Update.
4685         * symmisc.c: Update.
4686         * target.c: Update.
4687         * thread.c: Update.
4688         * top.c: Update.
4689         * tracefile-tfile.c: Update.
4690         * tui/tui.c: Update.
4691         * typeprint.c: Update.
4692         * unittests/cli-utils-selftests.c: Update.
4693         * unittests/parse-connection-spec-selftests.c: Update.
4694         * valops.c: Update.
4695         * valprint.c: Update.
4696         * value.c: Update.
4697         * varobj.c: Update.
4698         * windows-nat.c: Update.
4699         * x86-linux-nat.c: Update.
4700         * xml-support.c: Update.
4701
4702 2019-04-08  Tom Tromey  <tom@tromey.com>
4703
4704         * xml-support.c: Use C++ exception handling.
4705         * x86-linux-nat.c: Use C++ exception handling.
4706         * windows-nat.c: Use C++ exception handling.
4707         * varobj.c: Use C++ exception handling.
4708         * value.c: Use C++ exception handling.
4709         * valprint.c: Use C++ exception handling.
4710         * valops.c: Use C++ exception handling.
4711         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4712         handling.
4713         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4714         * typeprint.c: Use C++ exception handling.
4715         * tui/tui.c: Use C++ exception handling.
4716         * tracefile-tfile.c: Use C++ exception handling.
4717         * top.c: Use C++ exception handling.
4718         * thread.c: Use C++ exception handling.
4719         * target.c: Use C++ exception handling.
4720         * symmisc.c: Use C++ exception handling.
4721         * symfile-mem.c: Use C++ exception handling.
4722         * stack.c: Use C++ exception handling.
4723         * sparc64-linux-tdep.c: Use C++ exception handling.
4724         * solib.c: Use C++ exception handling.
4725         * solib-svr4.c: Use C++ exception handling.
4726         * solib-spu.c: Use C++ exception handling.
4727         * solib-frv.c: Use C++ exception handling.
4728         * solib-dsbt.c: Use C++ exception handling.
4729         * selftest-arch.c: Use C++ exception handling.
4730         * s390-tdep.c: Use C++ exception handling.
4731         * rust-lang.c: Use C++ exception handling.
4732         * rust-exp.y: Use C++ exception handling.
4733         * rs6000-tdep.c: Use C++ exception handling.
4734         * rs6000-aix-tdep.c: Use C++ exception handling.
4735         * riscv-tdep.c: Use C++ exception handling.
4736         * remote.c: Use C++ exception handling.
4737         * remote-fileio.c: Use C++ exception handling.
4738         * record-full.c: Use C++ exception handling.
4739         * record-btrace.c: Use C++ exception handling.
4740         * python/python.c: Use C++ exception handling.
4741         * python/py-value.c: Use C++ exception handling.
4742         * python/py-utils.c: Use C++ exception handling.
4743         * python/py-unwind.c: Use C++ exception handling.
4744         * python/py-type.c: Use C++ exception handling.
4745         * python/py-symbol.c: Use C++ exception handling.
4746         * python/py-record.c: Use C++ exception handling.
4747         * python/py-record-btrace.c: Use C++ exception handling.
4748         * python/py-progspace.c: Use C++ exception handling.
4749         * python/py-prettyprint.c: Use C++ exception handling.
4750         * python/py-param.c: Use C++ exception handling.
4751         * python/py-objfile.c: Use C++ exception handling.
4752         * python/py-linetable.c: Use C++ exception handling.
4753         * python/py-lazy-string.c: Use C++ exception handling.
4754         * python/py-infthread.c: Use C++ exception handling.
4755         * python/py-inferior.c: Use C++ exception handling.
4756         * python/py-gdb-readline.c: Use C++ exception handling.
4757         * python/py-framefilter.c: Use C++ exception handling.
4758         * python/py-frame.c: Use C++ exception handling.
4759         * python/py-finishbreakpoint.c: Use C++ exception handling.
4760         * python/py-cmd.c: Use C++ exception handling.
4761         * python/py-breakpoint.c: Use C++ exception handling.
4762         * python/py-arch.c: Use C++ exception handling.
4763         * printcmd.c: Use C++ exception handling.
4764         * ppc-linux-tdep.c: Use C++ exception handling.
4765         * parse.c: Use C++ exception handling.
4766         * p-valprint.c: Use C++ exception handling.
4767         * objc-lang.c: Use C++ exception handling.
4768         * mi/mi-main.c: Use C++ exception handling.
4769         * mi/mi-interp.c: Use C++ exception handling.
4770         * mi/mi-cmd-stack.c: Use C++ exception handling.
4771         * mi/mi-cmd-break.c: Use C++ exception handling.
4772         * main.c: Use C++ exception handling.
4773         * linux-thread-db.c: Use C++ exception handling.
4774         * linux-tdep.c: Use C++ exception handling.
4775         * linux-nat.c: Use C++ exception handling.
4776         * linux-fork.c: Use C++ exception handling.
4777         * linespec.c: Use C++ exception handling.
4778         * language.c: Use C++ exception handling.
4779         * jit.c: Use C++ exception handling.
4780         * infrun.c: Use C++ exception handling.
4781         * infcmd.c: Use C++ exception handling.
4782         * infcall.c: Use C++ exception handling.
4783         * inf-loop.c: Use C++ exception handling.
4784         * i386-tdep.c: Use C++ exception handling.
4785         * i386-linux-tdep.c: Use C++ exception handling.
4786         * guile/scm-value.c: Use C++ exception handling.
4787         * guile/scm-type.c: Use C++ exception handling.
4788         * guile/scm-symtab.c: Use C++ exception handling.
4789         * guile/scm-symbol.c: Use C++ exception handling.
4790         * guile/scm-pretty-print.c: Use C++ exception handling.
4791         * guile/scm-ports.c: Use C++ exception handling.
4792         * guile/scm-param.c: Use C++ exception handling.
4793         * guile/scm-math.c: Use C++ exception handling.
4794         * guile/scm-lazy-string.c: Use C++ exception handling.
4795         * guile/scm-frame.c: Use C++ exception handling.
4796         * guile/scm-disasm.c: Use C++ exception handling.
4797         * guile/scm-cmd.c: Use C++ exception handling.
4798         * guile/scm-breakpoint.c: Use C++ exception handling.
4799         * guile/scm-block.c: Use C++ exception handling.
4800         * guile/guile-internal.h: Use C++ exception handling.
4801         * gnu-v3-abi.c: Use C++ exception handling.
4802         * gdbtypes.c: Use C++ exception handling.
4803         * frame.c: Use C++ exception handling.
4804         * frame-unwind.c: Use C++ exception handling.
4805         * fbsd-tdep.c: Use C++ exception handling.
4806         * f-valprint.c: Use C++ exception handling.
4807         * exec.c: Use C++ exception handling.
4808         * event-top.c: Use C++ exception handling.
4809         * event-loop.c: Use C++ exception handling.
4810         * eval.c: Use C++ exception handling.
4811         * dwarf2read.c: Use C++ exception handling.
4812         * dwarf2loc.c: Use C++ exception handling.
4813         * dwarf2-frame.c: Use C++ exception handling.
4814         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4815         * dwarf-index-write.c: Use C++ exception handling.
4816         * dwarf-index-cache.c: Use C++ exception handling.
4817         * dtrace-probe.c: Use C++ exception handling.
4818         * disasm-selftests.c: Use C++ exception handling.
4819         * darwin-nat.c: Use C++ exception handling.
4820         * cp-valprint.c: Use C++ exception handling.
4821         * cp-support.c: Use C++ exception handling.
4822         * cp-abi.c: Use C++ exception handling.
4823         * corelow.c: Use C++ exception handling.
4824         * completer.c: Use C++ exception handling.
4825         * compile/compile-object-run.c: Use C++ exception handling.
4826         * compile/compile-object-load.c: Use C++ exception handling.
4827         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4828         * compile/compile-c-symbols.c: Use C++ exception handling.
4829         * common/selftest.c: Use C++ exception handling.
4830         * common/new-op.c: Use C++ exception handling.
4831         * cli/cli-script.c: Use C++ exception handling.
4832         * cli/cli-interp.c: Use C++ exception handling.
4833         * cli/cli-cmds.c: Use C++ exception handling.
4834         * c-varobj.c: Use C++ exception handling.
4835         * btrace.c: Use C++ exception handling.
4836         * breakpoint.c: Use C++ exception handling.
4837         * break-catch-throw.c: Use C++ exception handling.
4838         * arch-utils.c: Use C++ exception handling.
4839         * amd64-tdep.c: Use C++ exception handling.
4840         * ada-valprint.c: Use C++ exception handling.
4841         * ada-typeprint.c: Use C++ exception handling.
4842         * ada-lang.c: Use C++ exception handling.
4843         * aarch64-tdep.c: Use C++ exception handling.
4844
4845 2019-04-08  Tom Tromey  <tom@tromey.com>
4846
4847         * xml-support.c (gdb_xml_parser::parse): Update.
4848         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4849         * value.c (show_convenience): Update.
4850         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4851         (test_parse_flags_qcs): Update.
4852         * thread.c (thr_try_catch_cmd): Update.
4853         * target.c (target_translate_tls_address): Update.
4854         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4855         (info_frame_command_core, frame_apply_command_count): Update.
4856         * rust-exp.y (rust_lex_exception_test): Update.
4857         * riscv-tdep.c (riscv_print_one_register_info): Update.
4858         * remote.c (remote_target::enable_btrace): Update.
4859         * record-btrace.c (record_btrace_enable_warn): Update.
4860         * python/py-utils.c (gdbpy_convert_exception): Update.
4861         * printcmd.c (do_one_display, print_variable_and_value): Update.
4862         * mi/mi-main.c (mi_print_exception): Update.
4863         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4864         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4865         * linux-nat.c (linux_nat_target::attach): Update.
4866         * linux-fork.c (class scoped_switch_fork_info): Update.
4867         * infrun.c (displaced_step_prepare): Update.
4868         * infcall.c (call_function_by_hand_dummy): Update.
4869         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4870         * gnu-v3-abi.c (print_one_vtable): Update.
4871         * frame.c (get_prev_frame_always): Update.
4872         * f-valprint.c (info_common_command_for_block): Update.
4873         * exec.c (try_open_exec_file): Update.
4874         * exceptions.c (print_exception, exception_print)
4875         (exception_fprintf, exception_print_same): Update.
4876         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4877         * dwarf-index-cache.c (index_cache::store)
4878         (index_cache::lookup_gdb_index): Update.
4879         * darwin-nat.c (maybe_cache_shell): Update.
4880         * cp-valprint.c (cp_print_value_fields): Update.
4881         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4882         (gcc_cplus_symbol_address): Update.
4883         * compile/compile-c-symbols.c (gcc_convert_symbol)
4884         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4885         * common/selftest.c: Update.
4886         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4887         a std::string.
4888         (exception_try_scope_entry, exception_try_scope_exit): Don't
4889         declare.
4890         (struct exception_try_scope): Remove.
4891         (TRY): Don't use exception_try_scope.
4892         (struct gdb_exception): Add constructor, operator=.
4893         <what>: New method.
4894         (struct gdb_exception_RETURN_MASK_ALL)
4895         (struct gdb_exception_RETURN_MASK_ERROR)
4896         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4897         (struct gdb_quit_bad_alloc): Update.
4898         * common/common-exceptions.c (exception_none): Change
4899         initializer.
4900         (struct catcher) <state, exception>: Initialize inline.
4901         <prev>: Remove member.
4902         (current_catcher): Remove.
4903         (catchers): New global.
4904         (exceptions_state_mc_init): Simplify.
4905         (catcher_pop): Remove.
4906         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4907         (try_scope_depth, exception_try_scope_entry)
4908         (exception_try_scope_exit): Remove.
4909         (throw_exception_sjlj): Update.
4910         (exception_messages, exception_messages_size): Remove.
4911         (throw_it): Simplify.
4912         (gdb_exception_sliced_copy): Remove.
4913         (throw_exception_cxx): Update.
4914         * cli/cli-script.c (script_from_file): Update.
4915         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4916         Update.
4917         * ada-valprint.c (ada_val_print): Update.
4918         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4919         (create_excep_cond_exprs): Update.
4920
4921 2019-04-08  Tom Tromey  <tom@tromey.com>
4922
4923         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4924         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4925         (TRY, CATCH, END_CATCH): Remove some definitions.
4926         * common/common-exceptions.c: Don't use GDB_XCPT.
4927         (catcher_list_size): Remove.
4928         (throw_exception, throw_it): Simplify.
4929
4930 2019-04-05  Tom Tromey  <tom@tromey.com>
4931
4932         Revert the header-sorting patch.
4933         * ft32-tdep.c: Revert.
4934         * frv-tdep.c: Revert.
4935         * frv-linux-tdep.c: Revert.
4936         * frame.c: Revert.
4937         * frame-unwind.c: Revert.
4938         * frame-base.c: Revert.
4939         * fork-child.c: Revert.
4940         * findvar.c: Revert.
4941         * findcmd.c: Revert.
4942         * filesystem.c: Revert.
4943         * filename-seen-cache.h: Revert.
4944         * filename-seen-cache.c: Revert.
4945         * fbsd-tdep.c: Revert.
4946         * fbsd-nat.h: Revert.
4947         * fbsd-nat.c: Revert.
4948         * f-valprint.c: Revert.
4949         * f-typeprint.c: Revert.
4950         * f-lang.c: Revert.
4951         * extension.h: Revert.
4952         * extension.c: Revert.
4953         * extension-priv.h: Revert.
4954         * expprint.c: Revert.
4955         * exec.h: Revert.
4956         * exec.c: Revert.
4957         * exceptions.c: Revert.
4958         * event-top.c: Revert.
4959         * event-loop.c: Revert.
4960         * eval.c: Revert.
4961         * elfread.c: Revert.
4962         * dwarf2read.h: Revert.
4963         * dwarf2read.c: Revert.
4964         * dwarf2loc.c: Revert.
4965         * dwarf2expr.h: Revert.
4966         * dwarf2expr.c: Revert.
4967         * dwarf2-frame.c: Revert.
4968         * dwarf2-frame-tailcall.c: Revert.
4969         * dwarf-index-write.h: Revert.
4970         * dwarf-index-write.c: Revert.
4971         * dwarf-index-common.c: Revert.
4972         * dwarf-index-cache.h: Revert.
4973         * dwarf-index-cache.c: Revert.
4974         * dummy-frame.c: Revert.
4975         * dtrace-probe.c: Revert.
4976         * disasm.h: Revert.
4977         * disasm.c: Revert.
4978         * disasm-selftests.c: Revert.
4979         * dictionary.c: Revert.
4980         * dicos-tdep.c: Revert.
4981         * demangle.c: Revert.
4982         * dcache.h: Revert.
4983         * dcache.c: Revert.
4984         * darwin-nat.h: Revert.
4985         * darwin-nat.c: Revert.
4986         * darwin-nat-info.c: Revert.
4987         * d-valprint.c: Revert.
4988         * d-namespace.c: Revert.
4989         * d-lang.c: Revert.
4990         * ctf.c: Revert.
4991         * csky-tdep.c: Revert.
4992         * csky-linux-tdep.c: Revert.
4993         * cris-tdep.c: Revert.
4994         * cris-linux-tdep.c: Revert.
4995         * cp-valprint.c: Revert.
4996         * cp-support.c: Revert.
4997         * cp-namespace.c: Revert.
4998         * cp-abi.c: Revert.
4999         * corelow.c: Revert.
5000         * corefile.c: Revert.
5001         * continuations.c: Revert.
5002         * completer.h: Revert.
5003         * completer.c: Revert.
5004         * complaints.c: Revert.
5005         * coffread.c: Revert.
5006         * coff-pe-read.c: Revert.
5007         * cli-out.h: Revert.
5008         * cli-out.c: Revert.
5009         * charset.c: Revert.
5010         * c-varobj.c: Revert.
5011         * c-valprint.c: Revert.
5012         * c-typeprint.c: Revert.
5013         * c-lang.c: Revert.
5014         * buildsym.c: Revert.
5015         * buildsym-legacy.c: Revert.
5016         * build-id.h: Revert.
5017         * build-id.c: Revert.
5018         * btrace.c: Revert.
5019         * bsd-uthread.c: Revert.
5020         * breakpoint.h: Revert.
5021         * breakpoint.c: Revert.
5022         * break-catch-throw.c: Revert.
5023         * break-catch-syscall.c: Revert.
5024         * break-catch-sig.c: Revert.
5025         * blockframe.c: Revert.
5026         * block.c: Revert.
5027         * bfin-tdep.c: Revert.
5028         * bfin-linux-tdep.c: Revert.
5029         * bfd-target.c: Revert.
5030         * bcache.c: Revert.
5031         * ax-general.c: Revert.
5032         * ax-gdb.h: Revert.
5033         * ax-gdb.c: Revert.
5034         * avr-tdep.c: Revert.
5035         * auxv.c: Revert.
5036         * auto-load.c: Revert.
5037         * arm-wince-tdep.c: Revert.
5038         * arm-tdep.c: Revert.
5039         * arm-symbian-tdep.c: Revert.
5040         * arm-pikeos-tdep.c: Revert.
5041         * arm-obsd-tdep.c: Revert.
5042         * arm-nbsd-tdep.c: Revert.
5043         * arm-nbsd-nat.c: Revert.
5044         * arm-linux-tdep.c: Revert.
5045         * arm-linux-nat.c: Revert.
5046         * arm-fbsd-tdep.c: Revert.
5047         * arm-fbsd-nat.c: Revert.
5048         * arm-bsd-tdep.c: Revert.
5049         * arch-utils.c: Revert.
5050         * arc-tdep.c: Revert.
5051         * arc-newlib-tdep.c: Revert.
5052         * annotate.h: Revert.
5053         * annotate.c: Revert.
5054         * amd64-windows-tdep.c: Revert.
5055         * amd64-windows-nat.c: Revert.
5056         * amd64-tdep.c: Revert.
5057         * amd64-sol2-tdep.c: Revert.
5058         * amd64-obsd-tdep.c: Revert.
5059         * amd64-obsd-nat.c: Revert.
5060         * amd64-nbsd-tdep.c: Revert.
5061         * amd64-nbsd-nat.c: Revert.
5062         * amd64-nat.c: Revert.
5063         * amd64-linux-tdep.c: Revert.
5064         * amd64-linux-nat.c: Revert.
5065         * amd64-fbsd-tdep.c: Revert.
5066         * amd64-fbsd-nat.c: Revert.
5067         * amd64-dicos-tdep.c: Revert.
5068         * amd64-darwin-tdep.c: Revert.
5069         * amd64-bsd-nat.c: Revert.
5070         * alpha-tdep.c: Revert.
5071         * alpha-obsd-tdep.c: Revert.
5072         * alpha-nbsd-tdep.c: Revert.
5073         * alpha-mdebug-tdep.c: Revert.
5074         * alpha-linux-tdep.c: Revert.
5075         * alpha-linux-nat.c: Revert.
5076         * alpha-bsd-tdep.c: Revert.
5077         * alpha-bsd-nat.c: Revert.
5078         * aix-thread.c: Revert.
5079         * agent.c: Revert.
5080         * addrmap.c: Revert.
5081         * ada-varobj.c: Revert.
5082         * ada-valprint.c: Revert.
5083         * ada-typeprint.c: Revert.
5084         * ada-tasks.c: Revert.
5085         * ada-lang.c: Revert.
5086         * aarch64-tdep.c: Revert.
5087         * aarch64-ravenscar-thread.c: Revert.
5088         * aarch64-newlib-tdep.c: Revert.
5089         * aarch64-linux-tdep.c: Revert.
5090         * aarch64-linux-nat.c: Revert.
5091         * aarch64-fbsd-tdep.c: Revert.
5092         * aarch64-fbsd-nat.c: Revert.
5093         * aarch32-linux-nat.c: Revert.
5094
5095 2019-04-05  Tom Tromey  <tom@tromey.com>
5096
5097         * ft32-tdep.c: Sort headers.
5098         * frv-tdep.c: Sort headers.
5099         * frv-linux-tdep.c: Sort headers.
5100         * frame.c: Sort headers.
5101         * frame-unwind.c: Sort headers.
5102         * frame-base.c: Sort headers.
5103         * fork-child.c: Sort headers.
5104         * findvar.c: Sort headers.
5105         * findcmd.c: Sort headers.
5106         * filesystem.c: Sort headers.
5107         * filename-seen-cache.h: Sort headers.
5108         * filename-seen-cache.c: Sort headers.
5109         * fbsd-tdep.c: Sort headers.
5110         * fbsd-nat.h: Sort headers.
5111         * fbsd-nat.c: Sort headers.
5112         * f-valprint.c: Sort headers.
5113         * f-typeprint.c: Sort headers.
5114         * f-lang.c: Sort headers.
5115         * extension.h: Sort headers.
5116         * extension.c: Sort headers.
5117         * extension-priv.h: Sort headers.
5118         * expprint.c: Sort headers.
5119         * exec.h: Sort headers.
5120         * exec.c: Sort headers.
5121         * exceptions.c: Sort headers.
5122         * event-top.c: Sort headers.
5123         * event-loop.c: Sort headers.
5124         * eval.c: Sort headers.
5125         * elfread.c: Sort headers.
5126         * dwarf2read.h: Sort headers.
5127         * dwarf2read.c: Sort headers.
5128         * dwarf2loc.c: Sort headers.
5129         * dwarf2expr.h: Sort headers.
5130         * dwarf2expr.c: Sort headers.
5131         * dwarf2-frame.c: Sort headers.
5132         * dwarf2-frame-tailcall.c: Sort headers.
5133         * dwarf-index-write.h: Sort headers.
5134         * dwarf-index-write.c: Sort headers.
5135         * dwarf-index-common.c: Sort headers.
5136         * dwarf-index-cache.h: Sort headers.
5137         * dwarf-index-cache.c: Sort headers.
5138         * dummy-frame.c: Sort headers.
5139         * dtrace-probe.c: Sort headers.
5140         * disasm.h: Sort headers.
5141         * disasm.c: Sort headers.
5142         * disasm-selftests.c: Sort headers.
5143         * dictionary.c: Sort headers.
5144         * dicos-tdep.c: Sort headers.
5145         * demangle.c: Sort headers.
5146         * dcache.h: Sort headers.
5147         * dcache.c: Sort headers.
5148         * darwin-nat.h: Sort headers.
5149         * darwin-nat.c: Sort headers.
5150         * darwin-nat-info.c: Sort headers.
5151         * d-valprint.c: Sort headers.
5152         * d-namespace.c: Sort headers.
5153         * d-lang.c: Sort headers.
5154         * ctf.c: Sort headers.
5155         * csky-tdep.c: Sort headers.
5156         * csky-linux-tdep.c: Sort headers.
5157         * cris-tdep.c: Sort headers.
5158         * cris-linux-tdep.c: Sort headers.
5159         * cp-valprint.c: Sort headers.
5160         * cp-support.c: Sort headers.
5161         * cp-namespace.c: Sort headers.
5162         * cp-abi.c: Sort headers.
5163         * corelow.c: Sort headers.
5164         * corefile.c: Sort headers.
5165         * continuations.c: Sort headers.
5166         * completer.h: Sort headers.
5167         * completer.c: Sort headers.
5168         * complaints.c: Sort headers.
5169         * coffread.c: Sort headers.
5170         * coff-pe-read.c: Sort headers.
5171         * cli-out.h: Sort headers.
5172         * cli-out.c: Sort headers.
5173         * charset.c: Sort headers.
5174         * c-varobj.c: Sort headers.
5175         * c-valprint.c: Sort headers.
5176         * c-typeprint.c: Sort headers.
5177         * c-lang.c: Sort headers.
5178         * buildsym.c: Sort headers.
5179         * buildsym-legacy.c: Sort headers.
5180         * build-id.h: Sort headers.
5181         * build-id.c: Sort headers.
5182         * btrace.c: Sort headers.
5183         * bsd-uthread.c: Sort headers.
5184         * breakpoint.h: Sort headers.
5185         * breakpoint.c: Sort headers.
5186         * break-catch-throw.c: Sort headers.
5187         * break-catch-syscall.c: Sort headers.
5188         * break-catch-sig.c: Sort headers.
5189         * blockframe.c: Sort headers.
5190         * block.c: Sort headers.
5191         * bfin-tdep.c: Sort headers.
5192         * bfin-linux-tdep.c: Sort headers.
5193         * bfd-target.c: Sort headers.
5194         * bcache.c: Sort headers.
5195         * ax-general.c: Sort headers.
5196         * ax-gdb.h: Sort headers.
5197         * ax-gdb.c: Sort headers.
5198         * avr-tdep.c: Sort headers.
5199         * auxv.c: Sort headers.
5200         * auto-load.c: Sort headers.
5201         * arm-wince-tdep.c: Sort headers.
5202         * arm-tdep.c: Sort headers.
5203         * arm-symbian-tdep.c: Sort headers.
5204         * arm-pikeos-tdep.c: Sort headers.
5205         * arm-obsd-tdep.c: Sort headers.
5206         * arm-nbsd-tdep.c: Sort headers.
5207         * arm-nbsd-nat.c: Sort headers.
5208         * arm-linux-tdep.c: Sort headers.
5209         * arm-linux-nat.c: Sort headers.
5210         * arm-fbsd-tdep.c: Sort headers.
5211         * arm-fbsd-nat.c: Sort headers.
5212         * arm-bsd-tdep.c: Sort headers.
5213         * arch-utils.c: Sort headers.
5214         * arc-tdep.c: Sort headers.
5215         * arc-newlib-tdep.c: Sort headers.
5216         * annotate.h: Sort headers.
5217         * annotate.c: Sort headers.
5218         * amd64-windows-tdep.c: Sort headers.
5219         * amd64-windows-nat.c: Sort headers.
5220         * amd64-tdep.c: Sort headers.
5221         * amd64-sol2-tdep.c: Sort headers.
5222         * amd64-obsd-tdep.c: Sort headers.
5223         * amd64-obsd-nat.c: Sort headers.
5224         * amd64-nbsd-tdep.c: Sort headers.
5225         * amd64-nbsd-nat.c: Sort headers.
5226         * amd64-nat.c: Sort headers.
5227         * amd64-linux-tdep.c: Sort headers.
5228         * amd64-linux-nat.c: Sort headers.
5229         * amd64-fbsd-tdep.c: Sort headers.
5230         * amd64-fbsd-nat.c: Sort headers.
5231         * amd64-dicos-tdep.c: Sort headers.
5232         * amd64-darwin-tdep.c: Sort headers.
5233         * amd64-bsd-nat.c: Sort headers.
5234         * alpha-tdep.c: Sort headers.
5235         * alpha-obsd-tdep.c: Sort headers.
5236         * alpha-nbsd-tdep.c: Sort headers.
5237         * alpha-mdebug-tdep.c: Sort headers.
5238         * alpha-linux-tdep.c: Sort headers.
5239         * alpha-linux-nat.c: Sort headers.
5240         * alpha-bsd-tdep.c: Sort headers.
5241         * alpha-bsd-nat.c: Sort headers.
5242         * aix-thread.c: Sort headers.
5243         * agent.c: Sort headers.
5244         * addrmap.c: Sort headers.
5245         * ada-varobj.c: Sort headers.
5246         * ada-valprint.c: Sort headers.
5247         * ada-typeprint.c: Sort headers.
5248         * ada-tasks.c: Sort headers.
5249         * ada-lang.c: Sort headers.
5250         * aarch64-tdep.c: Sort headers.
5251         * aarch64-ravenscar-thread.c: Sort headers.
5252         * aarch64-newlib-tdep.c: Sort headers.
5253         * aarch64-linux-tdep.c: Sort headers.
5254         * aarch64-linux-nat.c: Sort headers.
5255         * aarch64-fbsd-tdep.c: Sort headers.
5256         * aarch64-fbsd-nat.c: Sort headers.
5257         * aarch32-linux-nat.c: Sort headers.
5258
5259 2019-04-04  Tom Tromey  <tom@tromey.com>
5260
5261         * varobj.c (varobj_create): Update.
5262         * rust-exp.y (struct rust_parser) <update_innermost_block,
5263         lookup_symbol>: New methods.
5264         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5265         Rename.
5266         (rust_parser::rust_lookup_type)
5267         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5268         * printcmd.c (display_command, do_one_display): Update.
5269         * parser-defs.h (struct parser_state) <parser_state>: Add
5270         "tracker" parameter.
5271         (block_tracker): New member.
5272         (class innermost_block_tracker) <innermost_block_tracker>: Add
5273         "types" parameter.
5274         <reset>: Remove method.
5275         (innermost_block): Don't declare.
5276         (null_post_parser): Update.
5277         * parse.c (innermost_block): Remove global.
5278         (write_dollar_variable): Update.
5279         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5280         Remove "tracker_types" parameter.
5281         (parse_expression): Add "tracker" parameter.
5282         (parse_expression_for_completion): Update.
5283         (null_post_parser): Add "tracker" parameter.
5284         * p-exp.y: Update rules.
5285         * m2-exp.y: Update rules.
5286         * language.h (struct language_defn) <la_post_parser>: Add
5287         "tracker" parameter.
5288         * go-exp.y: Update rules.
5289         * f-exp.y: Update rules.
5290         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5291         parameter.
5292         * d-exp.y: Update rules.
5293         * c-exp.y: Update rules.
5294         * breakpoint.c (set_breakpoint_condition): Create an
5295         innermost_block_tracker.
5296         (watch_command_1): Likewise.
5297         * ada-lang.c (resolve): Add "tracker" parameter.
5298         (resolve_subexp): Likewise.
5299         * ada-exp.y (write_var_from_sym): Update.
5300
5301 2019-04-04  Tom Tromey  <tom@tromey.com>
5302
5303         * type-stack.h: New file.
5304         * type-stack.c: New file.
5305         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5306         type-stack.h.
5307         (insert_into_type_stack, insert_type, push_type, push_type_int)
5308         (insert_type_address_space, pop_type, pop_type_int)
5309         (pop_typelist, pop_type_stack, append_type_stack)
5310         (push_type_stack, get_type_stack, push_typelist)
5311         (follow_type_instance_flags, follow_types): Don't declare.
5312         * parse.c (type_stack): Remove global.
5313         (parse_exp_in_context): Update.
5314         (insert_into_type_stack, insert_type, push_type, push_type_int)
5315         (insert_type_address_space, pop_type, pop_type_int)
5316         (pop_typelist, pop_type_stack, append_type_stack)
5317         (push_type_stack, get_type_stack, push_typelist)
5318         (follow_type_instance_flags, follow_types): Remove (moved to
5319         type-stack.c).
5320         * f-exp.y (type_stack): New global.
5321         Update rules.
5322         (push_kind_type, f_parse): Update.
5323         * d-exp.y (type_stack): New global.
5324         Update rules.
5325         (d_parse): Update.
5326         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5327         Update rules.
5328         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5329         (HFILES_NO_SRCDIR): Add type-stack.h.
5330
5331 2019-04-04  Tom Tromey  <tom@tromey.com>
5332
5333         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5334         (rust_parser::convert_ast_to_expression, rust_parse)
5335         (rust_lex_test_completion, rust_lex_tests): Update.
5336         * parser-defs.h (struct expr_completion_state): New.
5337         (struct parser_state) <parser_state>: Add completion parameter.
5338         <mark_struct_expression, mark_completion_tag>: New methods.
5339         <parse_completion, m_completion_state>: New members.
5340         (prefixify_expression, null_post_parser): Update.
5341         (mark_struct_expression, mark_completion_tag): Don't declare.
5342         * parse.c (parse_completion, expout_last_struct)
5343         (expout_tag_completion_type, expout_completion_name): Remove
5344         globals.
5345         (parser_state::mark_struct_expression)
5346         (parser_state::mark_completion_tag): Now methods.
5347         (prefixify_expression): Add last_struct parameter.
5348         (prefixify_subexp): Likewise.
5349         (parse_exp_1): Update.
5350         (parse_exp_in_context): Add cstate parameter.  Update.
5351         (parse_expression_for_completion): Create an
5352         expr_completion_state.
5353         (null_post_parser): Add "completion" parameter.
5354         * p-exp.y: Update rules.
5355         (yylex): Update.
5356         * language.h (struct language_defn) <la_post_parser>: Add
5357         "completing" parameter.
5358         * go-exp.y: Update rules.
5359         (lex_one_token): Update.
5360         * expression.h (parse_completion): Don't declare.
5361         * d-exp.y: Update rules.
5362         (lex_one_token): Update rules.
5363         * c-exp.y: Update rules.
5364         (lex_one_token): Update.
5365         * ada-lang.c (resolve): Add "parse_completion" parameter.
5366         (resolve_subexp): Likewise.
5367         (ada_resolve_function): Likewise.
5368
5369 2019-04-04  Tom Tromey  <tom@tromey.com>
5370
5371         * parser-defs.h (struct parser_state) <start_arglist,
5372         end_arglist>: New methods.
5373         <arglist_len, m_funcall_chain>: New members.
5374         (arglist_len, start_arglist, end_arglist): Don't declare.
5375         * parse.c (arglist_len, funcall_chain): Remove global.
5376         (start_arglist, end_arglist): Remove functions.
5377         (parse_exp_in_context): Update.
5378         * p-exp.y: Update rules.
5379         * m2-exp.y: Update rules.
5380         * go-exp.y: Update rules.
5381         * f-exp.y: Update rules.
5382         * d-exp.y: Update rules.
5383         * c-exp.y: Update rules.
5384
5385 2019-04-04  Tom Tromey  <tom@tromey.com>
5386
5387         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5388         lex_operator, push_back>: New methods.
5389         Update all rules.
5390         (rust_parser::lex_hex, lex_escape): Rename and update.
5391         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5392         (rust_parser::lex_operator): Rename and update.
5393         (rust_parser::lex_number, rustyylex, rustyyerror)
5394         (rust_lex_test_init, rust_lex_test_sequence)
5395         (rust_lex_test_push_back, rust_lex_tests): Update.
5396         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5397         parameter.
5398         <lexptr, prev_lexptr>: New members.
5399         (lexptr, prev_lexptr): Don't declare.
5400         * parse.c (lexptr, prev_lexptr): Remove globals.
5401         (parse_exp_in_context): Update.
5402         * p-exp.y (yylex, yyerror): Update.
5403         * m2-exp.y (parse_number, yylex, yyerror): Update.
5404         * go-exp.y (lex_one_token, yyerror): Update.
5405         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5406         * d-exp.y (lex_one_token, yyerror): Update.
5407         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5408         (lex_one_token, yyerror): Update.
5409         * ada-lex.l (YY_INPUT): Update.
5410         (rewind_to_char): Update.
5411         * ada-exp.y (yyerror): Update.
5412
5413 2019-04-04  Tom Tromey  <tom@tromey.com>
5414
5415         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5416         * parser-defs.h (struct parser_state) <parser_state>: Add new
5417         parameter.
5418         <comma_terminates>: New member.
5419         (comma_terminates): Don't declare global.
5420         * parse.c (comma_terminates): Remove global.
5421         (parse_exp_in_context): Update.
5422         * p-exp.y (yylex): Update.
5423         * m2-exp.y (yylex): Update.
5424         * go-exp.y (lex_one_token): Update.
5425         * f-exp.y (yylex): Update.
5426         * d-exp.y (lex_one_token): Update.
5427         * c-exp.y (lex_one_token): Update.
5428         * ada-lex.l: Update.
5429
5430 2019-04-04  Tom Tromey  <tom@tromey.com>
5431
5432         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5433         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5434         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5435         * parser-defs.h (paren_depth): Don't declare.
5436         * parse.c (paren_depth): Remove global.
5437         (parse_exp_in_context): Update.
5438         * p-exp.y (paren_depth): New global.
5439         (pascal_parse): Initialize it.
5440         * m2-exp.y (paren_depth): New global.
5441         (m2_parse): Initialize it.
5442         * go-exp.y (paren_depth): New global.
5443         (go_parse): Initialize it.
5444         * f-exp.y (paren_depth): New global.
5445         (f_parse): Initialize it.
5446         * d-exp.y (paren_depth): New global.
5447         (d_parse): Initialize it.
5448         * c-exp.y (paren_depth): New global.
5449         (c_parse): Initialize it.
5450         * ada-lex.l (paren_depth): New global.
5451         (lexer_init): Initialize it.
5452
5453 2019-04-04  Tom Tromey  <tom@tromey.com>
5454
5455         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5456         (rust_parser::convert_ast_to_type)
5457         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5458         * parser-defs.h (struct parser_state) <parser_state>: Add
5459         parameters.  Initialize new members.
5460         <expression_context_block, expression_context_pc>: New members.
5461         * parse.c (expression_context_block, expression_context_pc):
5462         Remove globals.
5463         (parse_exp_in_context): Update.
5464         * p-exp.y: Update all rules.
5465         (yylex): Update.
5466         * m2-exp.y: Update all rules.
5467         (yylex): Update.
5468         * go-exp.y (yylex): Update.
5469         * f-exp.y (yylex): Update.
5470         * d-exp.y: Update all rules.
5471         (yylex): Update.
5472         * c-exp.y: Update all rules.
5473         (lex_one_token, classify_name, yylex, c_parse): Update.
5474         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5475
5476 2019-04-04  Tom Tromey  <tom@tromey.com>
5477
5478         * gdbarch.h, gdbarch.c: Rebuild.
5479         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5480         * stap-probe.h: 
5481         (struct stap_parse_info): Replace "parser_state" with
5482         "expr_builder".
5483         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5484         (parser_state): New class.
5485         * parse.c (expr_builder): Rename.
5486         (expr_builder::release): Rename.
5487         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5488         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5489         (write_exp_elt_longcst, write_exp_elt_floatcst)
5490         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5491         (write_exp_string_vector, write_exp_bitstring)
5492         (write_exp_msymbol, mark_struct_expression)
5493         (write_dollar_variable)
5494         (insert_type_address_space, increase_expout_size): Replace
5495         "parser_state" with "expr_builder".
5496         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5497         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5498         "parser_state" with "expr_builder".
5499
5500 2019-04-04  Tom Tromey  <tom@tromey.com>
5501
5502         * rust-exp.y: Replace "parse_language" with method call.
5503         * p-exp.y: 
5504         (yylex): Replace "parse_language" with method call.
5505         * m2-exp.y: 
5506         (yylex): Replace "parse_language" with method call.
5507         * go-exp.y (classify_name): Replace "parse_language" with method
5508         call.
5509         * f-exp.y (yylex): Replace "parse_language" with method call.
5510         * d-exp.y (lex_one_token): Replace "parse_language" with method
5511         call.
5512         * c-exp.y: 
5513         (lex_one_token, classify_name, yylex): Replace "parse_language"
5514         with method call.
5515         * ada-exp.y (find_primitive_type, type_char)
5516         (type_system_address): Replace "parse_language" with method call.
5517
5518 2019-04-04  Tom Tromey  <tom@tromey.com>
5519
5520         * rust-exp.y: Replace "parse_gdbarch" with method call.
5521         * parse.c (write_dollar_variable, insert_type_address_space):
5522         Replace "parse_gdbarch" with method call.
5523         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5524         call.
5525         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5526         call.
5527         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5528         "parse_gdbarch" with method call.
5529         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5530         with method call.
5531         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5532         "parse_gdbarch" with method call.
5533         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5534         "parse_gdbarch" with method call.
5535         * c-exp.y (parse_type, parse_number, classify_name): Replace
5536         "parse_gdbarch" with method call.
5537         * ada-lex.l: Replace "parse_gdbarch" with method call.
5538         * ada-exp.y (parse_type, find_primitive_type, type_char)
5539         (type_system_address): Replace "parse_gdbarch" with method call.
5540
5541 2019-04-04  Tom Tromey  <tom@tromey.com>
5542
5543         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5544         * stap-probe.c (stap_parse_argument): Update.
5545         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5546         initial_size parameter.
5547         * rust-exp.y (rust_lex_tests): Update.
5548         * parse.c (parser_state): Update.
5549         (parse_exp_in_context): Update.
5550         * parser-defs.h (struct parser_state) <parser_state>: Remove
5551         "initial_size" parameter.
5552
5553 2019-04-04  Tom Tromey  <tom@tromey.com>
5554
5555         * parser-defs.h (increase_expout_size): Don't declare.
5556         * parse.c (increase_expout_size): Now static.
5557
5558 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5559
5560         * gnu-nat.c (gnu_nat_target::wait): Fix
5561         target_waitstatus_to_string call.
5562
5563 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * eval.c (evaluate_subexp_standard): Handle internal functions
5566         during Fortran function call handling.
5567
5568 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * NEWS: Mention new internal functions.
5571         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5572         (read_base_type): Use dwarf2_init_complex_target_type.
5573         * value.c (creal_internal_fn): New function.
5574         (cimag_internal_fn): New function.
5575         (_initialize_values): Register new internal functions.
5576
5577 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5578
5579         * infrun.c (stop_all_threads): If debug_infrun, always
5580         trace the wait status after wait_one, using
5581         target_waitstatus_to_string and target_pid_to_str.
5582         (handle_inferior_event): Replace various trace of
5583         wait status kind by a single trace.
5584         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5585         wait status kind image by target_waitstatus_to_string.
5586         * target/waitstatus.c (target_waitstatus_to_string): Fix
5587         obsolete comment.
5588
5589 2019-04-01  Tom Tromey  <tromey@adacore.com>
5590
5591         PR symtab/23331:
5592         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5593
5594 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5595             Pedro Alves  <palves@redhat.com>
5596
5597         * top.c (quit_force): Call 'finalize_values'.
5598         * value.c (finalize_values): New function.
5599         * value.h (finalize_values): Declare.
5600
5601 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5602
5603         * NEWS: Announce $_gdb_major and $_gdb_minor.
5604
5605         * top.c (init_gdb_version_vars): New function.
5606         (gdb_init): Call init_gdb_version_vars.
5607
5608 2019-03-29  Tom Tromey  <tromey@adacore.com>
5609
5610         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5611         help text.  Remove dead code.
5612
5613 2019-03-29  Keith Seitz  <keiths@redhat.com>
5614
5615         From Siddhesh Poyarekar:
5616         * f-lang.h (f77_get_upperbound): Return LONGEST.
5617         (f77_get_lowerbound): Likewise.
5618         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5619         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5620         print them.
5621         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5622         plongest to format print it.
5623         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5624         (f77_get_upperbound): Likewise.
5625         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5626         LOWER_BOUND to LONGEST.
5627         (f77_create_arrayprint_offset_tbl): Likewise.
5628
5629 2019-03-29  Keith Seitz  <keiths@redhat.com>
5630
5631         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5632         %s/pulongest for TYPE_LENGTH instead of %d in format
5633         strings.
5634         * ada-typerint.c (ada_print_type): Likewise.
5635         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5636         * compile/compile-c-support.c (generate_register_struct): Likewise.
5637         * gdbtypes.c (recursive_dump_type): Likewise.
5638         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5639         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5640         instead of %d in format strings.
5641         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5642         to std::min to ULONGEST.
5643         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5644         instead of %d in format strings.
5645         * tracepoint.c (info_scope_command): Likewise.
5646         * typeprint.c (print_offset_data::update)
5647         (print_offset_data::finish): Likewise.
5648         * xtensa-tdep.c (xtensa_store_return_value)
5649         (xtensa_push_dummy_call): Likewise.
5650
5651 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5652
5653         * windows-nat.c (display_selector): Fixed format specifications
5654         for 64-bit Cygwin.
5655
5656 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5657
5658         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5659
5660 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5661
5662         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5663         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5664         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5665         (nios2_linux_init_abi): Install it.
5666
5667 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5668
5669         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5670
5671 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5672
5673         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5674
5675 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5676             Tom Tromey  <tromey@adacore.com>
5677
5678         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5679
5680 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5681
5682         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5683         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5684         method to compute the bounds of range types. Also print "[evaluated]"
5685         if the bounds' values come from a dynamic evaluation.
5686
5687 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5688
5689         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5690         whitespace when pretty printing is on.
5691
5692 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5693
5694         * ppc-linux-nat.c: Add include.
5695
5696 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5697
5698         * NEWS: Mention AArch64 Pointer Authentication.
5699
5700 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5701
5702         * arm-linux-nat.c: Add include.
5703
5704 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5705
5706         * source-cache.c (source_cache::get_source_lines): Re-read
5707         fullname after calling open_source_file.
5708
5709 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5710
5711         * NEWS: Mention TLS support for FreeBSD.
5712
5713 2019-03-25  Tom Tromey  <tromey@adacore.com>
5714
5715         * minsyms.c (BUNCH_SIZE): Update comment.
5716         (~minimal_symbol_reader): Remove old comment.
5717         (compact_minimal_symbols): Update comment.
5718         (minimal_symbol_reader::install): Remove old comment.  Update
5719         other comments.
5720
5721 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5722
5723         * s390-linux-nat.c: Add include.
5724
5725 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5726
5727         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5728         Call linux_get_hwcap.
5729         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5730         Likewise.
5731         (aarch64_linux_get_hwcap): Remove function.
5732         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5733         declaration.
5734         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5735         linux_get_hwcap.
5736         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5737         * linux-tdep.c (linux_get_hwcap): Add function.
5738         (linux_get_hwcap2): Likewise.
5739         * linux-tdep.h (linux_get_hwcap): Add declaration.
5740         (linux_get_hwcap2): Likewise.
5741         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5742         (ppc_linux_get_hwcap2): Likewise.
5743         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5744         linux_get_hwcap.
5745         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5746         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5747         (ppc_linux_nat_target::read_description): Likewise.
5748         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5749         * s390-linux-nat.c: Likewise.
5750         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5751
5752 2019-03-24  Tom Tromey  <tom@tromey.com>
5753
5754         * ada-lang.c (standard_lookup): Simplify initialization.
5755         (ada_lookup_symbol_nonlocal): Simplify return.
5756         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5757         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5758         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5759         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5760         initialization.
5761         * solib.c (solib_global_lookup): Simplify.
5762         * symtab.c (null_block_symbol): Remove.
5763         (symbol_cache_lookup): Simplify returns.
5764         (lookup_language_this): Simplify returns.
5765         (lookup_symbol_aux): Simplify return.
5766         (lookup_local_symbol): Simplify returns.
5767         (lookup_global_symbol_from_objfile): Simplify return.
5768         (lookup_symbol_in_objfile_symtabs)
5769         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5770         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5771         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5772         * cp-namespace.c (cp_lookup_bare_symbol)
5773         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5774         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5775         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5776         (cp_lookup_symbol_via_imports): Simplify initialization.
5777         (find_symbol_in_baseclass): Likewise.
5778         * symtab.h (null_block_symbol): Remove.
5779         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5780         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5781         (d_lookup_symbol_module): Likewise.
5782         (find_symbol_in_baseclass): Simplify initialization.
5783
5784 2019-03-24  Tom Tromey  <tom@tromey.com>
5785
5786         * expression.h: Don't include symtab.h.
5787         (struct block): Forward declare.
5788
5789 2019-03-24  Tom Tromey  <tom@tromey.com>
5790
5791         * c-exp.y (typebase): Remove casts.
5792         * gdbtypes.c (lookup_unsigned_typename, )
5793         (lookup_signed_typename): Remove cast.
5794         * eval.c (parse_to_comma_and_eval): Remove cast.
5795         * parse.c (write_dollar_variable): Remove cast.
5796         * block.h (struct block) <superblock>: Now const.
5797         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5798         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5799         (map_block): Make "block" const.
5800         * symfile.h (struct quick_symbol_functions)
5801         <map_matching_symbols>: Constify block argument to "callback".
5802         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5803         const.
5804         (find_pc_sect_compunit_symtab): Make "b" const.
5805         (find_symbol_at_address): Likewise.
5806         (search_symbols): Likewise.
5807         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5808         (dw2_debug_names_lookup_symbol): Likewise.
5809         (dw2_map_matching_symbols): Update.
5810         * p-valprint.c (pascal_val_print): Remove "block".
5811         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5812         (aux_add_nonlocal_symbols): Make "block" const.
5813         (resolve_subexp): Remove cast.
5814         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5815         const.
5816         (iterate_over_file_blocks): Likewise.
5817         * f-exp.y (%union) <bval>: Remove.
5818         * coffread.c (patch_opaque_types): Make "b" const.
5819         * spu-tdep.c (spu_catch_start): Make "block" const.
5820         * c-valprint.c (print_unpacked_pointer): Remove "block".
5821         * symmisc.c (dump_symtab_1): Make "b" const.
5822         (block_depth): Make "block" const.
5823         * d-exp.y (%union) <bval>: Remove.
5824         * cp-support.h (cp_lookup_rtti_type): Update.
5825         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5826         * psymtab.c (psym_lookup_symbol): Make "block" const.
5827         (maintenance_check_psymtabs): Make "b" const.
5828         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5829         (enumerate_locals, enumerate_args): Update.
5830         * python/py-symtab.c (stpy_global_block): Make "block" const.
5831         (stpy_static_block): Likewise.
5832         * inline-frame.c (block_starting_point_at): Make "new_block"
5833         const.
5834         * block.c (find_block_in_blockvector): Make return type const.
5835         (blockvector_for_pc_sect): Make "b" const.
5836         (find_block_in_blockvector): Make "b" const.
5837
5838 2019-03-23  Tom Tromey  <tom@tromey.com>
5839
5840         * varobj.c (varobj_create): Update.
5841         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5842         * printcmd.c (display_command, do_one_display): Don't reset
5843         innermost_block.
5844         * parser-defs.h (enum innermost_block_tracker_type): Move to
5845         expression.h.
5846         (innermost_block): Update comment.
5847         * parse.c (parse_exp_1): Add tracker_types parameter.
5848         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5849         tracker_types parameter.  Reset innermost_block.
5850         (parse_exp_in_context): Remove.
5851         (parse_expression_for_completion): Update.
5852         * objfiles.c (~objfile): Don't reset expression_context_block or
5853         innermost_block.
5854         * expression.h (enum innermost_block_tracker_type): Move from
5855         parser-defs.h.
5856         (parse_exp_1): Add tracker_types parameter.
5857         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5858         reset innermost_block.
5859
5860 2019-03-23  Tom Tromey  <tom@tromey.com>
5861
5862         * objfiles.h: Include bcache.h.
5863
5864 2019-03-23  Tom Tromey  <tom@tromey.com>
5865
5866         * linespec.c (get_current_search_block): Use
5867         scoped_restore_current_language.
5868         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5869
5870 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5871             Jiong Wang  <jiong.wang@arm.com>
5872
5873         * aarch64-linux-tdep.c
5874         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5875         section.
5876         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5877
5878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5879             Jiong Wang  <jiong.wang@arm.com>
5880
5881         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5882         instructions.
5883         (aarch64_analyze_prologue_test): Add PACIASP test.
5884         (aarch64_prologue_prev_register): Unmask PC value.
5885
5886 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5887             Jiong Wang  <jiong.wang@arm.com>
5888
5889         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5890         (aarch64_dwarf2_prev_register): Unmask PC value.
5891         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5892         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5893         DW_CFA_AARCH64_negate_ra_state.
5894         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5895
5896 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5897             Jiong Wang  <jiong.wang@arm.com>
5898
5899         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5900         registers.
5901         (aarch64_pseudo_register_name): Likewise.
5902         (aarch64_pseudo_register_type): Likewise.
5903         (aarch64_pseudo_register_reggroup_p): Likewise.
5904         (aarch64_gdbarch_init): Add pauth registers.
5905         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5906         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5907         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5908         (struct gdbarch_tdep): Add regnum for ra_state.
5909
5910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5911             Jiong Wang  <jiong.wang@arm.com>
5912
5913         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5914
5915 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5916             Jiong Wang  <jiong.wang@arm.com>
5917
5918         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5919         function.
5920         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5921         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5922         (aarch64_gdbarch_init): Add puth registers.
5923         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5924         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5925         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5926
5927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5928             Jiong Wang  <jiong.wang@arm.com>
5929
5930         * aarch64-linux-nat.c
5931         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5932         * aarch64-linux-tdep.c
5933         (aarch64_linux_core_read_description): Likewise.
5934         (aarch64_linux_get_hwcap): New function.
5935         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5936         (aarch64_linux_get_hwcap): New declaration.
5937
5938 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5939             Jiong Wang  <jiong.wang@arm.com>
5940
5941         * aarch64-linux-nat.c
5942         (aarch64_linux_nat_target::read_description): Add pauth param.
5943         * aarch64-linux-tdep.c
5944         (aarch64_linux_core_read_description): Likewise.
5945         * aarch64-tdep.c (struct target_desc): Add in pauth.
5946         (aarch64_read_description): Add pauth param.
5947         (aarch64_gdbarch_init): Likewise.
5948         * aarch64-tdep.h (aarch64_read_description): Likewise.
5949         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5950         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5951         * features/Makefile: Add new files.
5952         * features/aarch64-pauth.c: New file.
5953         * features/aarch64-pauth.xml: New file.
5954
5955 2019-03-20  Tom Tromey  <tromey@adacore.com>
5956
5957         * infrun.c (handle_inferior_event): Rename from
5958         handle_inferior_event_1.  Create a scoped_value_mark.
5959         (handle_inferior_event): Remove.
5960
5961 2019-03-19  Tom Tromey  <tromey@adacore.com>
5962
5963         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5964         * infrun.h (print_stop_event): Add "displays" parameter.
5965         * infrun.c (print_stop_event): Add "displays" parameter.
5966
5967 2019-03-19  Pedro Alves  <palves@redhat.com>
5968
5969         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5970         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5971         to -1.  Fix TABs vs spaces.
5972         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5973         * tui/tui-out.h (tui_ui_out) Add intro comments.
5974         <m_line, m_start_of_line>: In-class initialize, and add describing
5975         comment.
5976
5977 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5978
5979         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5980         variable names.
5981         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5982
5983 2019-03-18  Pedro Alves  <palves@redhat.com>
5984             Eli Zaretskii <eliz@gnu.org>
5985
5986         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5987         m_line and m_start_of_line.
5988
5989 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5990
5991         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5992         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5993         it returns a newline.  This fixes a regression in TU mode, whereby
5994         the next line is output on the same screen line as the user input.
5995
5996 2019-03-18  Tom Tromey  <tromey@adacore.com>
5997
5998         * minsyms.c (minimal_symbol_reader::install): Remove call to
5999         obstack_blank.
6000
6001 2019-03-18  Pedro Alves  <palves@redhat.com>
6002
6003         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6004         New globals.
6005         (apply_style): New, factored out from ...
6006         (apply_ansi_escape): ... this.  Handle reverse video mode.
6007         (tui_set_reverse_mode): New function.
6008         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6009         * tui/tui-winsource.c (tui_show_source_line): Use
6010         tui_set_reverse_mode instead of setting A_STANDOUT.
6011         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6012         New setter methods.
6013
6014 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6015
6016         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6017         Handle tabs.
6018
6019 2019-03-18  Tom Tromey  <tromey@adacore.com>
6020
6021         * ada-lang.c (empty_array): Add "high" parameter.
6022         (ada_evaluate_subexp): Update.
6023
6024 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6025
6026         * unittests/string_view-selftests.c: Define
6027         _initialize_string_view_selftests unconditionally.
6028
6029 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6030
6031         PR gdb/24350
6032         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6033
6034 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6035
6036         PR gdb/24351
6037         * windows-nat.c (display_selector): Fix format specifiers.
6038
6039 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6040
6041         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6042         tui_refill_source_window instead of tui_refresh_win, to update the
6043         current execution line.  This fixes redisplay of the current line
6044         when stepping through the code with "next" or "step".
6045
6046 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6047
6048         * source-cache.c (source_cache::get_source_lines): Call
6049         find_source_lines to initialize s->nlines.  This fixes vertical
6050         scrolling of TUI source window when the DOWN arrow is pressed.
6051
6052 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6053
6054         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6055         linux-thread-db.c (_initialize_thread_db): Likewise.
6056
6057 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6058
6059         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6060         wclrtoeol in tui_show_source_line".  This reverts changes made in
6061         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6062
6063 2019-03-15  Tom Tromey  <tom@tromey.com>
6064
6065         * symtab.h (struct minimal_symbol): Derive from
6066         general_symbol_info.
6067         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6068         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6069         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6070         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6071         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6072         (MSYMBOL_SEARCH_NAME): Update.
6073         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6074         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6075         * minsyms.c (minimal_symbol_reader::record_full): Update.
6076
6077 2019-03-15  Tom Tromey  <tom@tromey.com>
6078
6079         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6080
6081 2019-03-15  Tom Tromey  <tom@tromey.com>
6082
6083         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6084         unique_xmalloc_ptr.
6085         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6086         Update.
6087         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6088         (build_minimal_symbol_hash_tables)
6089         (minimal_symbol_reader::install): Update.
6090
6091 2019-03-15  Tom Tromey  <tom@tromey.com>
6092
6093         * symtab.c (create_demangled_names_hash): Update.
6094         (symbol_set_names): Update.
6095         * objfiles.h (struct objfile_per_bfd_storage)
6096         <demangled_names_hash>: Now an htab_up.
6097         * objfiles.c (objfile_per_bfd_storage): Simplify.
6098
6099 2019-03-15  Tom Tromey  <tom@tromey.com>
6100
6101         * objfiles.h (struct objfile_per_bfd_storage): Declare
6102         destructor.
6103         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6104         New.
6105         (get_objfile_bfd_data): Use new.  Don't initialize
6106         language_of_main.
6107         (free_objfile_per_bfd_storage): Remove.
6108         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6109
6110 2019-03-15  Tom Tromey  <tom@tromey.com>
6111
6112         * symfile.c (reread_symbols): Update.
6113         * objfiles.c (objfile::objfile): Update.
6114         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6115         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6116         comment.
6117         (minimal_symbol_reader::install): Update.
6118         (terminate_minimal_symbol_table): Remove.
6119         * jit.c (jit_object_close_impl): Update.
6120
6121 2019-03-15  Tom Tromey  <tom@tromey.com>
6122
6123         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6124         initializations.
6125
6126 2019-03-15  Tom Tromey  <tom@tromey.com>
6127
6128         * objfiles.h (struct objfile_per_bfd_storage)
6129         <demangled_hash_languages>: Now a bitset.
6130         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6131         (lookup_minimal_symbol): Update.
6132
6133 2019-03-15  Tom Tromey  <tom@tromey.com>
6134
6135         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6136         Don't return the symbol.
6137         * coffread.c (record_minimal_symbol): Use record_full.
6138
6139 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6140
6141         The MS-Windows port of ncurses fails to switch to a color pair if
6142         one or both of the colors are the implicit default colors.  This
6143         change records the default colors when TUI is initialized, and
6144         then specifies them explicitly when a color pair uses the default
6145         colors.  This allows color styling in TUI mode on MS-Windows.
6146
6147         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6148         ncurses_norm_attr.
6149         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6150         colors in ncurses_norm_attr.
6151         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6152         "none", replace it with the default color recorded in
6153         ncurses_norm_attr.
6154
6155 2019-03-14  Tom Tromey  <tromey@adacore.com>
6156
6157         * source-cache.h (class source_cache) <get_source_lines>: Return
6158         std::string.
6159         * source-cache.c (source_cache::extract_lines): Handle case where
6160         first_pos==npos.  Return std::string.
6161         (source_cache::get_source_lines): Update.
6162
6163 2019-03-14  Tom Tromey  <tromey@adacore.com>
6164
6165         * NEWS: Add item for "style sources" commands.
6166         * source-cache.c (source_cache::get_source_lines): Check
6167         source_styling.
6168         * cli/cli-style.c (source_styling): New global.
6169         (_initialize_cli_style): Add "style sources" commands.
6170         (show_style_sources): New function.
6171         * cli/cli-style.h (source_styling): Declare.
6172
6173 2019-03-14  Pedro Alves  <palves@redhat.com>
6174             Tom Tromey  <tromey@adacore.com>
6175
6176         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6177         * tui/tui-winsource.c (tui_refill_source_window): New function,
6178         from...
6179         (tui_horizontal_source_scroll): ... here.  Move some logic.
6180         * cli/cli-style.c (set_style_enabled): Notify new observable.
6181         * tui/tui-hooks.c (tui_redisplay_source): New function.
6182         (tui_attach_detach_observers): Attach or detach
6183         tui_redisplay_source.
6184         * observable.h (source_styling_changed): New observable.
6185         * observable.c: Define source_styling_changed observable.
6186
6187 2019-03-13  Tom Tromey  <tromey@adacore.com>
6188
6189         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6190         (i386_gnu_nat_target::store_registers): Update.
6191         * target-debug.h (target_debug_print_std_string): New macro.
6192         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6193         * windows-tdep.c (display_one_tib): Update.
6194         * tui/tui-stack.c (tui_make_status_line): Update.
6195         * top.c (print_inferior_quit_action): Update.
6196         * thread.c (thr_try_catch_cmd): Update.
6197         (add_thread_with_info): Update.
6198         (thread_target_id_str): Update.
6199         (thr_try_catch_cmd): Update.
6200         (thread_command): Update.
6201         (thread_find_command): Update.
6202         * record-btrace.c (record_btrace_target::info_record)
6203         (record_btrace_resume_thread, record_btrace_target::resume)
6204         (record_btrace_cancel_resume, record_btrace_step_thread)
6205         (record_btrace_target::wait, record_btrace_target::wait)
6206         (record_btrace_target::wait, record_btrace_target::stop): Update.
6207         * progspace.c (print_program_space): Update.
6208         * process-stratum-target.c
6209         (process_stratum_target::thread_address_space): Update.
6210         * linux-fork.c (linux_fork_mourn_inferior)
6211         (detach_checkpoint_command, info_checkpoints_command)
6212         (linux_fork_context): Update.
6213         (linux_fork_detach): Update.
6214         (class scoped_switch_fork_info): Update.
6215         (delete_checkpoint_command): Update.
6216         * infrun.c (follow_fork_inferior): Update.
6217         (follow_fork_inferior): Update.
6218         (proceed_after_vfork_done): Update.
6219         (handle_vfork_child_exec_or_exit): Update.
6220         (follow_exec): Update.
6221         (displaced_step_prepare_throw): Update.
6222         (displaced_step_restore): Update.
6223         (start_step_over): Update.
6224         (resume_1): Update.
6225         (clear_proceed_status_thread): Update.
6226         (proceed): Update.
6227         (print_target_wait_results): Update.
6228         (do_target_wait): Update.
6229         (context_switch): Update.
6230         (stop_all_threads): Update.
6231         (restart_threads): Update.
6232         (finish_step_over): Update.
6233         (handle_signal_stop): Update.
6234         (switch_back_to_stepped_thread): Update.
6235         (keep_going_pass_signal): Update.
6236         (print_exited_reason): Update.
6237         (normal_stop): Update.
6238         * inferior.c (inferior_pid_to_str): Change return type.
6239         (print_selected_inferior): Update.
6240         (add_inferior): Update.
6241         (detach_inferior): Update.
6242         * dummy-frame.c (fprint_dummy_frames): Update.
6243         * dcache.c (dcache_info_1): Update.
6244         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6245         (btrace_fetch, btrace_clear): Update.
6246         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6247         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6248         type.
6249         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6250         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6251         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6252         * gdbarch.c, gdbarch.h: Rebuild.
6253         * gdbarch.sh (core_pid_to_str): Change return type.
6254         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6255         return type.
6256         (windows_nat_target::pid_to_str): Change return type.
6257         (windows_delete_thread): Update.
6258         (windows_nat_target::attach): Update.
6259         (windows_nat_target::files_info): Update.
6260         * target-delegates.c: Rebuild.
6261         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6262         return type.
6263         (sol_thread_target::pid_to_str): Change return type.
6264         * remote.c (class remote_target) <pid_to_str>: Change return
6265         type.
6266         (remote_target::pid_to_str): Change return type.
6267         (extended_remote_target::attach, remote_target::remote_stop_ns)
6268         (remote_target::remote_notif_remove_queued_reply)
6269         (remote_target::push_stop_reply, remote_target::disable_btrace):
6270         Update.
6271         (extended_remote_target::attach): Update.
6272         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6273         type.
6274         (gdbsim_target::pid_to_str): Change return type.
6275         * ravenscar-thread.c (struct ravenscar_thread_target)
6276         <pid_to_str>: Change return type.
6277         (ravenscar_thread_target::pid_to_str): Change return type.
6278         * procfs.c (class procfs_target) <pid_to_str>: Change return
6279         type.
6280         (procfs_target::pid_to_str): Change return type.
6281         (procfs_target::attach): Update.
6282         (procfs_target::detach): Update.
6283         (procfs_target::fetch_registers): Update.
6284         (procfs_target::store_registers): Update.
6285         (procfs_target::wait): Update.
6286         (procfs_target::files_info): Update.
6287         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6288         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6289         return type.
6290         (nto_procfs_target::pid_to_str): Change return type.
6291         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6292         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6293         return type.
6294         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6295         (exit_lwp): Update.
6296         (attach_proc_task_lwp_callback, get_detach_signal)
6297         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6298         (linux_nat_target::resume, wait_lwp, stop_callback)
6299         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6300         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6301         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6302         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6303         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6304         type.
6305         (inf_ptrace_target::attach): Update.
6306         (inf_ptrace_target::files_info): Update.
6307         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6308         type.
6309         (go32_nat_target::pid_to_str): Change return type.
6310         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6311         (gnu_nat_target::wait): Update.
6312         (gnu_nat_target::wait): Update.
6313         (gnu_nat_target::resume): Update.
6314         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6315         (fbsd_nat_target::wait): Update.
6316         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6317         type.
6318         (darwin_nat_target::attach): Update.
6319         * corelow.c (class core_target) <pid_to_str>: Change return type.
6320         (core_target::pid_to_str): Change return type.
6321         * target.c (normal_pid_to_str): Change return type.
6322         (default_pid_to_str): Likewise.
6323         (target_pid_to_str): Change return type.
6324         (target_translate_tls_address): Update.
6325         (target_announce_detach): Update.
6326         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6327         return type.
6328         (bsd_uthread_target::pid_to_str): Change return type.
6329         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6330         type.
6331         (bsd_kvm_target::pid_to_str): Change return type.
6332         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6333         return type.
6334         (aix_thread_target::pid_to_str): Change return type.
6335         * target.h (struct target_ops) <pid_to_str>: Change return type.
6336         (target_pid_to_str, normal_pid_to_str): Likewise.
6337         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6338         type.
6339         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6340         type.
6341         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6342         return type.
6343         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6344         type.
6345         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6346         type.
6347         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6348         return type.
6349
6350 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6351
6352         * NEWS: Mention that the new default MI version is 3.  Mention
6353         changes to the output of commands and events that deal with
6354         multi-location breakpoints.
6355         * breakpoint.c: Include "mi/mi-out.h".
6356         (print_one_breakpoint): Change output syntax if using MI version
6357         >= 3.
6358         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6359         New.
6360         (mi_multi_location_breakpoint_output_fixed): New.
6361         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6362         (mi_cmd_fix_multi_location_breakpoint_output): New.
6363         (mi_multi_location_breakpoint_output_fixed): New.
6364         * mi/mi-cmds.c (mi_cmds): Register command
6365         -fix-multi-location-breakpoint-output.
6366         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6367         interpreter "mi".
6368
6369 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6370
6371         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6372         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6373         instantiate mi_ui_out based on interpreter name.
6374         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6375         * mi/mi-main.c (mi_load_progress): Likewise.
6376
6377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6378
6379         * NEWS: Combine separate "New targets" sections for 8.3.
6380
6381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6382
6383         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6384         (ppcfbsd_init_abi): Install gdbarch
6385         "fetch_tls_load_module_address" and "get_thread_local_address"
6386         methods.
6387
6388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6389
6390         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6391         (riscv_fbsd_init_abi): Install gdbarch
6392         "fetch_tls_load_module_address" and "get_thread_local_address"
6393         methods.
6394
6395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6396
6397         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6398         (i386fbsd_init_abi): Install gdbarch
6399         "fetch_tls_load_module_address" and "get_thread_local_address"
6400         methods.
6401
6402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6403
6404         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6405         (amd64fbsd_init_abi): Install gdbarch
6406         "fetch_tls_load_module_address" and "get_thread_local_address"
6407         methods.
6408
6409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6410
6411         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6412         (struct fbsd_pspace_data): New type.
6413         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6414         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6415         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6416         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6417         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6418
6419 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6420
6421         * gdbtypes.c (lookup_struct_elt): New function.
6422         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6423         * gdbtypes.h (struct struct_elt): New type.
6424         (lookup_struct_elt): New prototype.
6425
6426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6427
6428         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6429         remove disabled code block.
6430
6431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6432
6433         * gdbarch.sh (get_thread_local_address): New method.
6434         * gdbarch.h, gdbarch.c: Regenerate.
6435         * target.c (target_translate_tls_address): Use
6436         gdbarch_get_thread_local_address if present instead of
6437         target::get_thread_local_address.
6438
6439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6440
6441         * target.h (target::get_thread_local_address): Update comment.
6442
6443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6444
6445         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6446         objfile->separate_debug_objfile_backlink if not NULL.
6447
6448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6449
6450         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6451         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6452         (amd64bsd_store_inferior_registers): Likewise.
6453         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6454         Enable segment base registers.
6455         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6456         PT_GETFSBASE and PT_GETGSBASE.
6457         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6458         PT_SETGSBASE.
6459         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6460         segment base registers.
6461         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6462
6463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6464
6465         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6466         Update calls to i386_target_description to add 'segments'
6467         parameter.
6468         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6469         add segment base registers.
6470         * arch/i386.c (i386_create_target_description): Add 'segments'
6471         parameter to enable segment base registers.
6472         * arch/i386.h (i386_create_target_description): Likewise.
6473         * features/i386/32bit-segments.xml: New file.
6474         * features/i386/32bit-segments.c: Generate.
6475         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6476         call to i386_target_description to add 'segments' parameter.
6477         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6478         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6479         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6480         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6481         if feature is present.
6482         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6483         Add 'segments' parameter to call to i386_target_description.
6484         (i386_target_description): Add 'segments' parameter to enable
6485         segment base registers.
6486         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6487         to call to i386_target_description.
6488         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6489         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6490         Define I386_NUM_REGS.
6491         (i386_target_description): Add 'segments' parameter to enable
6492         segment base registers.
6493
6494 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6495
6496         PR/24325
6497         * source-cache.c: #undef open and close, to avoid unresolved
6498         externals during linking.
6499
6500 2019-03-12  Tom Tromey  <tromey@adacore.com>
6501
6502         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6503         const.  Add initializers.
6504         (_initialize_remote): Don't initialize ptid globals.
6505
6506 2019-03-12  Pedro Alves  <palves@redhat.com>
6507
6508         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6509
6510 2019-03-12  Pedro Alves  <palves@redhat.com>
6511
6512         * cp-name-parser.y (main): Remove unused 'len' variable.
6513
6514 2019-03-12  Tom Tromey  <tromey@adacore.com>
6515
6516         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6517         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6518
6519 2019-03-12  Tom Tromey  <tromey@adacore.com>
6520
6521         * linux-nat.c (iterate_over_lwps): Update.
6522         (stop_callback): Remove parameter.
6523         (stop_wait_callback, detach_callback, resume_set_callback)
6524         (select_singlestep_lwp_callback, set_ignore_sigint)
6525         (status_callback, resumed_callback, resume_clear_callback)
6526         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6527         data parameter.
6528         (linux_nat_target::detach, linux_nat_target::resume)
6529         (linux_stop_and_wait_all_lwps, select_event_lwp)
6530         (linux_nat_filter_event, linux_nat_wait_1)
6531         (linux_nat_target::kill, linux_nat_target::stop)
6532         (linux_nat_target::stop): Update.
6533         (linux_nat_resume_callback): Change type.
6534         (resume_stopped_resumed_lwps, count_events_callback)
6535         (select_event_lwp_callback): Likewise.
6536         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6537         * arm-linux-nat.c (struct update_registers_data): Remove.
6538         (update_registers_callback): Change type.
6539         (arm_linux_insert_hw_breakpoint1): Update.
6540         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6541         parameter.
6542         (x86_linux_dr_set_addr): Update.
6543         (x86_linux_dr_set_control): Update.
6544         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6545         (iterate_over_lwps): Use gdb::function_view.
6546         * nat/aarch64-linux-hw-point.c (struct
6547         aarch64_dr_update_callback_param): Remove.
6548         (debug_reg_change_callback): Change type.
6549         (aarch64_notify_debug_reg_change): Update.
6550         * s390-linux-nat.c (s390_refresh_per_info): Update.
6551
6552 2019-03-11  Tom Tromey  <tromey@adacore.com>
6553
6554         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6555         redundant assignment to "this_cu".
6556
6557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6558
6559         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6560
6561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6562
6563         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6564         from...
6565         (rank_one_type): ... this.
6566
6567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6568
6569         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6570         from...
6571         (rank_one_type): ... this.
6572
6573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6574
6575         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6576         from...
6577         (rank_one_type): ... this.
6578
6579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6580
6581         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6582         from...
6583         (rank_one_type): ... this.
6584
6585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6586
6587         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6588         from...
6589         (rank_one_type): ... this.
6590
6591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6592
6593         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6594         from...
6595         (rank_one_type): ... this.
6596
6597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6598
6599         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6600         from...
6601         (rank_one_type): ... this.
6602
6603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6604
6605         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6606         from...
6607         (rank_one_type): ... this.
6608
6609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6610
6611         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6612         from...
6613         (rank_one_type): ... this.
6614
6615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6616
6617         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6618         from...
6619         (rank_one_type): ... this.
6620
6621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6622
6623         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6624         from...
6625         (rank_one_type): ... this.
6626
6627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6628
6629         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6630         from...
6631         (rank_one_type): ... this.
6632
6633 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6634
6635         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6636         inferior-events' shows the example events.
6637
6638 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6639
6640         Support styling on native MS-Windows console
6641
6642         PR/24315
6643         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6644         on MS-Windows if $TERM is not defined.
6645
6646         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6647
6648         * posix-hdep.c (gdb_console_fputs):
6649         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6650         functions.
6651         * ui-file.h (gdb_console_fputs): Add prototype.
6652
6653         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6654         back to fputs only if the former returns zero.
6655
6656 2019-03-07  Tom Tromey  <tom@tromey.com>
6657
6658         * symmisc.c (print_symbol_bcache_statistics): Update.
6659         (print_objfile_statistics): Update.
6660         * symfile.c (allocate_symtab): Update.
6661         * stabsread.c: Don't include bcache.h.
6662         * psymtab.h (struct psymbol_bcache): Don't declare.
6663         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6664         (psymbol_bcache_init, psymbol_bcache_free)
6665         (psymbol_bcache_get_bcache): Don't declare.
6666         * psymtab.c (struct psymbol_bcache): Remove.
6667         (psymtab_storage::psymtab_storage): Update.
6668         (psymtab_storage::~psymtab_storage): Update.
6669         (psymbol_bcache_init, psymbol_bcache_free)
6670         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6671         (add_psymbol_to_bcache): Update.
6672         (allocate_psymtab): Update.
6673         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6674         macro_cache>: No longer pointers.
6675         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6676         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6677         * macrotab.c (macro_bcache): Update.
6678         * macroexp.c: Don't include bcache.h.
6679         * gdbtypes.c (check_types_worklist): Update.
6680         (types_deeply_equal): Remove TRY/CATCH.  Update.
6681         * elfread.c (elf_symtab_read): Update.
6682         * dwarf2read.c: Don't include bcache.h.
6683         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6684         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6685         (print_bcache_statistics, bcache_memory_used): Don't declare.
6686         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6687         methods.  Rename all data members.
6688         * bcache.c (struct bcache): Move to bcache.h.
6689         (bcache::expand_hash_table): Rename from expand_hash_table.
6690         (bcache): Remove.
6691         (bcache::insert): Rename from bcache_full.
6692         (bcache::compare): Rename from bcache_compare.
6693         (bcache_xmalloc): Remove.
6694         (bcache::~bcache): Rename from bcache_xfree.
6695         (bcache::print_statistics): Rename from print_bcache_statistics.
6696         (bcache::memory_used): Rename from bcache_memory_used.
6697
6698 2019-03-07  Pedro Alves  <palves@redhat.com>
6699
6700         * infrun.c (normal_stop): Also check for
6701         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6702
6703 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6704
6705         * f-lang.c (value_from_host_double): Moved to...
6706         * value.c (value_from_host_double): ...here.
6707         * value.h (value_from_host_double): Declare.
6708         * guile/scm-math.c (vlscm_convert_typed_number): Use
6709         value_from_host_double.
6710         (vlscm_convert_number): Likewise.
6711         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6712         * python/py-value.c (convert_value_from_python): Likewise.
6713
6714 2019-03-06  Tom Tromey  <tom@tromey.com>
6715
6716         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6717
6718 2019-03-06  Tom Tromey  <tom@tromey.com>
6719
6720         * utils.h (free_current_contents): Don't declare.
6721         * utils.c (free_current_contents): Remove.
6722
6723 2019-03-06  Tom Tromey  <tom@tromey.com>
6724
6725         * top.c (quit_force): Update.
6726         * main.c (captured_command_loop): Update.
6727         * common/new-op.c (operator new): Update.
6728         * common/common-exceptions.c (struct catcher)
6729         <save_cleanup_chain>: Remove member.
6730         (exceptions_state_mc_init): Update.
6731         (exception_try_scope_entry): Return nullptr.
6732         (exception_try_scope_exit, exception_rethrow)
6733         (throw_exception_sjlj, throw_exception_cxx): Update.
6734         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6735         (all_cleanups, do_cleanups, discard_cleanups)
6736         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6737         (restore_cleanups, restore_final_cleanups): Don't declare.
6738         (do_final_cleanups): Remove parameter.
6739         * common/cleanups.c (cleanup_chain, make_cleanup)
6740         (make_cleanup_dtor, all_cleanups, do_cleanups)
6741         (discard_my_cleanups, discard_cleanups)
6742         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6743         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6744         (null_cleanup): Remove.
6745         (do_final_cleanups): Remove parameter.
6746
6747 2019-03-06  Tom Tromey  <tom@tromey.com>
6748
6749         * remote.c (remote_target::remote_parse_stop_reply): Use
6750         unique_xmalloc_ptr.
6751
6752 2019-03-06  Tom Tromey  <tom@tromey.com>
6753
6754         * stabsread.c (struct stabs_field_info): Rename from field_info.
6755         <list, fnlist>: Add initializers.
6756         <obstack>: New member.
6757         (read_member_functions, read_struct_fields, read_baseclasses):
6758         Allocate on obstack.  Don't use cleanups.
6759         (read_one_struct_field, read_member_functions, read_struct_fields)
6760         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6761         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6762         (read_struct_type): Update.
6763
6764 2019-03-06  Tom Tromey  <tom@tromey.com>
6765
6766         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6767         * common/filestuff.h (make_cleanup_close): Don't declare.
6768         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6769         Remove.
6770
6771 2019-03-06  Tom Tromey  <tom@tromey.com>
6772
6773         * solib-aix.c: Use make_scope_exit.
6774
6775 2019-03-06  Tom Tromey  <tom@tromey.com>
6776
6777         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6778         Use make_scope_exit.
6779
6780 2019-03-06  Tom Tromey  <tom@tromey.com>
6781
6782         * solib-svr4.c (disable_probes_interface): Remove parameter.
6783         (svr4_handle_solib_event): Use make_scope_exit.
6784
6785 2019-03-06  Tom Tromey  <tom@tromey.com>
6786
6787         * remote.c (struct stop_reply_deleter): Remove.
6788         (stop_reply_up): Update.
6789         (struct stop_reply): Derive from notif_event.  Don't typedef.
6790         <regcache>: Now a std::vector.
6791         (stop_reply_xfree): Remove.
6792         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6793         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6794         (remote_target::discard_pending_stop_replies): Use delete.
6795         (remote_target::remote_parse_stop_reply): Update.
6796         (remote_target::process_stop_reply): Update.
6797         * remote-notif.h (struct notif_event): Add virtual destructor.
6798         Remove "dtr" member.
6799         (struct notif_client) <alloc_event>: Return a unique_ptr.
6800         (notif_event_xfree): Don't declare.
6801         (notif_event_up): New typedef.
6802         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6803         (notif_event_xfree, do_notif_event_xfree): Remove.
6804         (remote_notif_state_xfree): Update.
6805
6806 2019-03-06  Tom Tromey  <tom@tromey.com>
6807
6808         * infrun.c (displaced_step_clear_cleanup): Now a
6809         forward_scope_exit type.
6810         (displaced_step_prepare_throw): Update.
6811         (displaced_step_fixup): Update.
6812
6813 2019-03-06  Tom Tromey  <tom@tromey.com>
6814
6815         * inferior.h (class inferior): Update comment.
6816         * gdbthread.h (class thread_info): Update comment.
6817
6818 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6819             Tom Tromey  <tom@tromey.com>
6820
6821         * stabsread.h (struct stab_section_list): Remove.
6822         (coffstab_build_psymtabs): Update.
6823         * dbxread.c (symbuf_sections): Now a std::vector.
6824         (sect_idx): New global.
6825         (fill_symbuf): Update.
6826         (coffstab_build_psymtabs): Change type of stabsects parameter.
6827         Update.
6828         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6829         std::vector.
6830         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6831         (coff_locate_sections): Update.
6832         (coff_symfile_read): Remove cleanups.  Update.
6833         (init_stringtab): Add storage parameter.
6834         (free_stringtab, free_stringtab_cleanup): Remove.
6835         (init_lineno): Add storage parameter.
6836         (free_linetab, free_linetab_cleanup): Remove.
6837
6838 2019-03-06  Pedro Alves  <palves@redhat.com>
6839
6840         * linux-fork.c (fork_info::clobber_regs): Delete.
6841         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6842         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6843         comment.  Adjust.
6844         (scoped_switch_fork_info::scoped_switch_fork_info)
6845         (checkpoint_command, linux_fork_context): Adjust
6846         fork_save_infrun_state calls.
6847
6848 2019-03-06  Pedro Alves  <palves@redhat.com>
6849
6850         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6851         (inf_has_multiple_threads): Return 'bool' and rewrite using
6852         inferior_info::threads().
6853
6854 2019-03-06  Pedro Alves  <palves@redhat.com>
6855
6856         * linux-fork.c: Include <list>.
6857         (fork_list): Now a std::list instance.
6858         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6859         (forks_exist_p, find_last_fork): Adjust.
6860         (new_fork): Delete.
6861         (one_fork_p): New.
6862         (add_fork): Adjust.
6863         (free_fork): Delete, folded into fork_info::~fork_info().
6864         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6865         Adjust.
6866         (init_fork_list): Delete.
6867         (linux_fork_killall, linux_fork_mourn_inferior)
6868         (linux_fork_detach, info_checkpoints_command): Adjust.
6869         (_initialize_linux_fork): No longer call init_fork_list.
6870
6871 2019-03-06  Pedro Alves  <palves@redhat.com>
6872
6873         * linux-fork.c (new_fork): New, split out of ...
6874         (add_fork): ... this.  Return void.  Move "first fork" special
6875         case from here, to ...
6876         (checkpoint_command): ... here.
6877         * linux-linux.h (add_fork): Return void.
6878
6879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6880
6881         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6882
6883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6884             Chris January  <chris.january@arm.com>
6885             David Lecomber  <david.lecomber@arm.com>
6886
6887         * f-exp.y: New token, UNOP_INTRINSIC.
6888         (exp): New pattern using UNOP_INTRINSIC token.
6889         (f77_keywords): Add 'abs' keyword.
6890         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6891         (value_from_host_double): New function.
6892         (evaluate_subexp_f): Support UNOP_ABS.
6893
6894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6897         types.
6898
6899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6900
6901         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6902         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6903         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6904
6905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6906
6907         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6908
6909 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6910             Chris January  <chris.january@arm.com>
6911
6912         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6913         * f-exp.y: Define 'KIND' token.
6914         (exp): New pattern for KIND expressions.
6915         (ptype): Handle types with a kind extension.
6916         (direct_abs_decl): Extend to spot kind extensions.
6917         (f77_keywords): Add 'kind' to the list.
6918         (push_kind_type): New function.
6919         (convert_to_kind_type): New function.
6920         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6921         * parse.c (operator_length_standard): Likewise.
6922         * parser-defs.h (enum type_pieces): Add tp_kind.
6923         * std-operator.def: Add UNOP_KIND.
6924
6925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * f-exp.y (f_parse): Set yydebug.
6928
6929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6930
6931         * f-lang.c (evaluate_subexp_f): New function.
6932         (exp_descriptor_f): New global.
6933         (f_language_defn): Use exp_descriptor_f instead of
6934         exp_descriptor_standard.
6935
6936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6937
6938         * f-exp.y (struct token): Add comments.
6939         (dot_ops): Remove uppercase versions and the end marker.
6940         (f77_keywords): Likewise.
6941         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6942         entries in the dot_ops array are case insensitive, and use
6943         strncasecmp to compare strings.  Also some whitespace cleanup in
6944         this area.  Similar for the f77_keywords array, except entries in
6945         this list might be case sensitive.
6946
6947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6948
6949         * f-exp.y (struct f77_boolean_val): Add comments.
6950         (boolean_values): Remove uppercase versions, and end marker.
6951         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6952         and use strncasecmp to achieve case insensitivity.  Additionally,
6953         perform whitespace cleanup around this code.
6954
6955 2019-03-06  Tom Tromey  <tromey@adacore.com>
6956
6957         * remote-sim.c (gdbsim_target_open): Use result of
6958         gdb_argv::release.
6959
6960 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6961         Dirk Schubert  <dirk.schubert@arm.com>
6962         Chris January  <chris.january@arm.com>
6963
6964         * eval.c (evaluate_subexp_standard): Call Fortran argument
6965         wrapping logic.
6966         * f-lang.c (struct value): A value which can be passed into a
6967         Fortran function call.
6968         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6969         where appropriate.
6970         (struct type): Value ready for a Fortran function call.
6971         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6972         is needed.
6973         * f-lang.h (fortran_argument_convert): Declaration.
6974         (fortran_preserve_arg_pointer): Declaration.
6975         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6976
6977 2019-03-05  Tom Tromey  <tromey@adacore.com>
6978
6979         * python/py-prettyprint.c (print_string_repr): Remove #if.
6980         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6981
6982 2019-03-05  Tom Tromey  <tromey@adacore.com>
6983
6984         * target.c (the_dummy_target): Move later.  Change type to
6985         "dummy_target".
6986         (initialize_targets): Don't initialize the_dummy_target.
6987
6988 2019-03-05  Tom Tromey  <tromey@adacore.com>
6989
6990         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6991         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6992
6993 2019-03-05  Tom Tromey  <tromey@adacore.com>
6994
6995         * windows-nat.c (windows_nat_target::attach)
6996         (windows_nat_target::detach): Don't call gdb_flush.
6997         * valprint.c (generic_val_print, val_print, val_print_string):
6998         Don't call gdb_flush.
6999         * utils.c (defaulted_query): Don't call gdb_flush.
7000         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7001         * target.c (target_announce_detach): Don't call gdb_flush.
7002         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7003         * remote.c (extended_remote_target::attach): Don't call
7004         gdb_flush.
7005         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7006         * printcmd.c (do_examine): Don't call gdb_flush.
7007         (info_display_command): Don't call gdb_flush.
7008         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7009         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7010         * memattr.c (info_mem_command): Don't call gdb_flush.
7011         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7012         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7013         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7014         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7015         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7016         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7017         (gnu_nat_target::detach): Don't call gdb_flush.
7018         * f-valprint.c (f_val_print): Don't call gdb_flush.
7019         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7020         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7021         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7022         gdb_flush.
7023         * c-valprint.c (c_val_print): Don't call gdb_flush.
7024         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7025
7026 2019-03-05  Tom Tromey  <tromey@adacore.com>
7027
7028         * varobj.c (update_dynamic_varobj_children): Update.
7029         (install_default_visualizer): Use reset, not release.
7030         * value.c (set_internalvar): Update.
7031         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7032         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7033         ATTRIBUTE_UNUSED_RESULT.
7034
7035 2019-03-05  Tom Tromey  <tromey@adacore.com>
7036
7037         * remote.c (class scoped_remote_fd) <release>: Add
7038         ATTRIBUTE_UNUSED_RESULT.
7039
7040 2019-03-05  Tom Tromey  <tromey@adacore.com>
7041
7042         * macroexp.c (struct macro_buffer) <release>: Add
7043         ATTRIBUTE_UNUSED_RESULT.
7044
7045 2019-03-05  Tom Tromey  <tromey@adacore.com>
7046
7047         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7048         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7049         ATTRIBUTE_UNUSED_RESULT.
7050
7051 2019-03-05  Tom Tromey  <tromey@adacore.com>
7052
7053         * common/scoped_fd.h (class scoped_fd) <release>: Add
7054         ATTRIBUTE_UNUSED_RESULT.
7055
7056 2019-03-05  Tom Tromey  <tromey@adacore.com>
7057
7058         * parser-defs.h (struct parser_state) <release>: Add
7059         ATTRIBUTE_UNUSED_RESULT.
7060
7061 2019-03-05  Tom Tromey  <tromey@adacore.com>
7062
7063         * utils.h (class gdb_argv) <release>: Add
7064         ATTRIBUTE_UNUSED_RESULT.
7065         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7066
7067 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7068
7069         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7070         for-loop range, to avoid compiler warnings.
7071
7072         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7073         avoid compiler warnings about unused variables.
7074
7075         * NEWS: Mention end of support for native debugging on MS-Windows
7076         before XP.
7077
7078         PR gdb/24292
7079         * common/netstuff.c:
7080         * gdbserver/gdbreplay.c
7081         * gdbserver/remote-utils.c:
7082         * ser-tcp.c:
7083         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7084         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7085         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7086         'getaddrinfo' and 'freeaddrinfo' were not available before
7087         Windows XP, and mingw.org's MinGW headers by default define
7088         _WIN32_WINNT to 0x500.
7089
7090 2019-03-01  Gary Benson <gbenson@redhat.com>
7091
7092         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7093
7094 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7095             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7096
7097         PR gdb/8527
7098         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7099         set_sigint_trap, clear_sigint_trap.
7100
7101 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7102
7103         * target.c (target_detach): Clear the regcache and the
7104         frame cache.
7105
7106 2019-02-27  Pedro Alves  <palves@redhat.com>
7107
7108         * utils.c (set_screen_size): When we cap the height/width sizes,
7109         tweak the corresponding command variable to show "unlimited":
7110
7111 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7112             Pedro Alves  <palves@redhat.com>
7113
7114         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7115         before calling rl_set_screen_size.
7116
7117 2019-02-27  Tom Tromey  <tromey@adacore.com>
7118
7119         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7120         define.
7121         * python/py-value.c: Remove Python 2.4 workaround.
7122         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7123         workaround.
7124         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7125         Python 2.4 workaround.
7126         * python/python-internal.h: Remove Python 2.4 comment.
7127         (Py_ssize_t): Don't define.
7128         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7129         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7130         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7131         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7132         * python/python.c (do_start_initialization): Remove Python 2.4
7133         workaround.
7134         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7135         (print_children): Remove Python 2.4 workaround.
7136         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7137         workaround.
7138         (CHARBUFFERPROC_NAME): Remove.
7139         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7140         Python 2.4 workaround.
7141
7142 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7143
7144         * NEWS: Note minimum Python version.
7145
7146 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7147
7148         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7149         code from these functions.  Remove corresponding ifdefs.  Use
7150         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7151         Remove gotos and target of gotos.
7152         (infpy_search_memory): Likewise.
7153
7154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7155
7156         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7157         (hppa_gdbarch_init): Don't register deleted functions with
7158         gdbarch.
7159
7160 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7161
7162         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7163         (h8300_unwind_sp): Delete.
7164         (h8300_dummy_id): Delete.
7165         (h8300_gdbarch_init): Don't register deleted functions with
7166         gdbarch.
7167
7168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7169
7170         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7171         (ft32_unwind_pc): Delete.
7172         (ft32_unwind_sp): Delete.
7173         (ft32_gdbarch_init): Don't register deleted functions with
7174         gdbarch.
7175
7176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7177
7178         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7179         (frv_unwind_pc): Delete.
7180         (frv_unwind_sp): Delete.
7181         (frv_gdbarch_init): Don't register deleted functions with
7182         gdbarch.
7183
7184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7187         (riscv_unwind_pc): Delete.
7188         (riscv_unwind_sp): Delete.
7189         (riscv_gdbarch_init): Don't register deleted functions with
7190         gdbarch.
7191
7192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7193
7194         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7195         (csky_unwind_pc): Delete.
7196         (csky_unwind_sp): Delete.
7197         (csky_gdbarch_init): Don't register deleted functions with
7198         gdbarch.
7199
7200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7203         (cris_unwind_pc): Delete.
7204         (cris_unwind_sp): Delete.
7205         (cris_gdbarch_init): Don't register deleted functions with
7206         gdbarch.
7207
7208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7211         (bfin_unwind_pc): Delete.
7212         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7213
7214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7217         (arm_unwind_pc): Delete.
7218         (arm_unwind_sp): Delete.
7219         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7220
7221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7224         (arc_unwind_pc): Delete.
7225         (arc_unwind_sp): Delete.
7226         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7227
7228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7231         (alpha_unwind_pc): Delete.
7232         (alpha_gdbarch_init): Don't register deleted functions with
7233         gdbarch.
7234
7235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7238         (aarch64_unwind_pc): Delete.
7239         (aarch64_unwind_sp): Delete.
7240         (aarch64_gdbarch_init): Don't register deleted functions with
7241         gdbarch.
7242
7243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * gdbtypes.c (type_align): Don't consider static members when
7246         computing structure alignment.
7247
7248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7251         return 0 for other types.
7252         * arch-utils.c (default_type_align): Always return 0.
7253         * gdbarch.h: Regenerate.
7254         * gdbarch.sh (type_align): Extend comment.
7255         * gdbtypes.c (type_align): Add additional comments, always call
7256         gdbarch_type_align before applying the default rules.
7257         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7258         generic code will then apply a suitable default.
7259         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7260         types, return 0 for other types.
7261
7262 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7263
7264         * NEWS: Create a new section for the next release branch.
7265         Rename the section of the current branch, now that it has
7266         been cut.
7267
7268 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7269
7270         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7271         * version.in: Bump version to 8.3.50.DATE-git.
7272
7273 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7274
7275         * aix-thread.c (ptid_cmp): Remove unused variable.
7276         (get_signaled_thread): Likewise.
7277         (store_regs_user_thread): Likewise.
7278         (store_regs_kernel_thread): Likewise.
7279         (fetch_regs_kernel_thread): Remove shadowed variable.
7280
7281 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7282
7283         * features/riscv/32bit-cpu.xml: Add register numbers.
7284         * features/riscv/32bit-fpu.c: Regenerate.
7285         * features/riscv/32bit-fpu.xml: Add register numbers.
7286         * features/riscv/64bit-cpu.xml: Add register numbers.
7287         * features/riscv/64bit-fpu.c: Regenerate.
7288         * features/riscv/64bit-fpu.xml: Add register numbers.
7289
7290 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7291
7292         * NEWS: Mention two argument form of gdb.Value constructor.
7293         * python/py-value.c (convert_buffer_and_type_to_value): New
7294         function.
7295         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7296         Add support for handling an optional second argument.  Call
7297         convert_buffer_and_type_to_value as appropriate.
7298         * python/python-internal.h (Py_buffer_deleter): New struct.
7299         (Py_buffer_up): New typedef.
7300
7301 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7302
7303         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7304         instead of releasing ownership.
7305
7306 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7307
7308         * dwarf2read.c (open_and_init_dwp_file): Call
7309         elf_numsections instead of bfd_count_sections to initialize
7310         dwp_file->num_sections.
7311
7312 2019-02-25  Tom Tromey  <tromey@adacore.com>
7313
7314         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7315
7316 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7317
7318         * gcore.in: Add '--readnever' option when invoking GDB.
7319
7320 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7321
7322         * MAINTAINERS: Update my email address.
7323
7324 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7325
7326         * build-id.c (build_id_to_debug_bfd_1): New function.
7327         (build_id_to_debug_bfd): Look for separate debug file in
7328         sysroot.
7329
7330 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7331
7332         * gdbarch.sh: Update the copyright year range that is placed into
7333         generated files.
7334
7335 2019-02-22  Keith Seitz  <keiths@redhat.com>
7336
7337         PR symtab/23853
7338         * linespec.c (create_sals_line_offset): Search for the default
7339         symtab's filename instead of its fullname.
7340
7341 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7342
7343         * NEWS: Update style defaults.
7344
7345 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7346
7347         * main.c (captured_main_1): Disable styling in batch mode.
7348
7349 2019-02-20  Tom Tromey  <tom@tromey.com>
7350
7351         * symtab.c (symtab_symbol_info): Fix typos.
7352
7353 2019-02-20  Tom Tromey  <tromey@adacore.com>
7354
7355         * findcmd.c (_initialize_mem_search): Use upper case for
7356         metasyntactic variables.
7357
7358 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7359
7360         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7361         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7362
7363 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7364
7365         * top.h (source_file_name): Change to std::string.
7366         * top.c (source_file_name): Likewise.
7367         (command_line_input): Adjust.
7368         * cli/cli-script.c (script_from_file): Adjust.
7369
7370 2019-02-19  Tom Tromey  <tromey@adacore.com>
7371
7372         * ravenscar-thread.c
7373         (ravenscar_thread_target::update_thread_list): Don't call
7374         ada_build_task_list.
7375         * ada-lang.h (ada_build_task_list): Don't declare.
7376         * ada-tasks.c (struct ada_tasks_inferior_data)
7377         <task_list_valid_p>: Now bool.
7378         (read_known_tasks, ada_task_list_changed)
7379         (ada_tasks_invalidate_inferior_data): Update.
7380         (read_known_tasks_array): Return bool.
7381         (read_known_tasks_list): Likewise.
7382         (read_known_tasks): Return void.
7383         (ada_build_task_list): Now static.
7384
7385 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7386
7387         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7388         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7389
7390 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7391
7392         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7393         variant for ada_tasks_pspace_data_handle and
7394         ada_tasks_inferior_data_handle.
7395         (ada_tasks_pspace_data_cleanup): New function.
7396         (ada_tasks_inferior_data_cleanup): New function.
7397
7398 2019-02-17  Tom Tromey  <tom@tromey.com>
7399
7400         * macrotab.h (macro_source_fullname): Return a std::string.
7401         * macrotab.c (macro_include, check_for_redefinition)
7402         (macro_undef, macro_lookup_definition, foreach_macro)
7403         (foreach_macro_in_scope): Update.
7404         (macro_source_fullname): Return a std::string.
7405         * macrocmd.c (show_pp_source_pos): Update.
7406
7407 2019-02-17  Tom Tromey  <tom@tromey.com>
7408
7409         * macrocmd.c (show_pp_source_pos): Style the file names.
7410
7411 2019-02-17  Tom Tromey  <tom@tromey.com>
7412
7413         PR tui/24197:
7414         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7415
7416 2019-02-17  Tom Tromey  <tom@tromey.com>
7417
7418         * ada-lang.c (user_select_syms): Use filtered printing.
7419         * utils.c (wrap_style): New global.
7420         (desired_style): Remove.
7421         (emit_style_escape): Add stream parameter.
7422         (set_output_style, reset_terminal_style, prompt_for_continue):
7423         Update.
7424         (flush_wrap_buffer): Only flush gdb_stdout.
7425         (wrap_here): Set wrap_style.
7426         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7427         treat escape sequences as a character.  Change when wrap buffer is
7428         flushed.
7429         (fputs_styled): Do not set the output style when the default is
7430         requested.
7431         * ui-style.h (struct ui_file_style) <is_default>: New method.
7432         * source.c (print_source_lines_base): Emit escape sequences in one
7433         piece.
7434
7435 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7436
7437         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7438         integers and enumeration types.
7439
7440 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7441
7442         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7443         instead of lookup_symbol_in_language
7444         (do_exact_match): New function.
7445         (ada_get_symbol_name_matcher): Return do_exact_match when
7446         doing a verbatim match.
7447
7448 2019-02-15  Tom Tromey  <tromey@adacore.com>
7449
7450         * ravenscar-thread.c (ravenscar_thread_target::resume)
7451         (ravenscar_thread_target::wait): Special case wildcard requests.
7452
7453 2019-02-15  Tom Tromey  <tromey@adacore.com>
7454
7455         * ravenscar-thread.c (base_ptid): Remove.
7456         (struct ravenscar_thread_target) <close>: New method.
7457         <m_base_ptid>: New member.
7458         <update_inferior_ptid, active_task, task_is_currently_active,
7459         runtime_initialized>: Declare methods.
7460         <ravenscar_thread_target>: Add constructor.
7461         (ravenscar_thread_target::task_is_currently_active)
7462         (ravenscar_thread_target::update_inferior_ptid)
7463         (ravenscar_runtime_initialized): Rename.  Now methods.
7464         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7465         (ravenscar_thread_target::update_thread_list): Update.
7466         (ravenscar_thread_target::active_task): Now method.
7467         (ravenscar_thread_target::store_registers)
7468         (ravenscar_thread_target::prepare_to_store)
7469         (ravenscar_thread_target::prepare_to_store)
7470         (ravenscar_thread_target::mourn_inferior): Update.
7471         (ravenscar_inferior_created): Use "new" to create target.
7472         (ravenscar_thread_target::get_ada_task_ptid): Update.
7473         (_initialize_ravenscar): Don't initialize base_ptid.
7474         (ravenscar_ops): Remove global.
7475
7476 2019-02-15  Tom Tromey  <tromey@adacore.com>
7477
7478         * target.h (push_target): Declare new overload.
7479         * target.c (push_target): New overload, taking an rvalue reference.
7480         * remote.c (remote_target::open_1): Use push_target overload.
7481         * corelow.c (core_target_open): Use push_target overload.
7482
7483 2019-02-15  Tom Tromey  <tromey@adacore.com>
7484
7485         * ravenscar-thread.c (is_ravenscar_task)
7486         (ravenscar_task_is_currently_active): Return bool.
7487         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7488         (_initialize_ravenscar): Remove "(void)".
7489         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7490         Return bool.
7491
7492 2019-02-15  Tom Tromey  <tromey@adacore.com>
7493
7494         * ravenscar-thread.c (ravenscar_runtime_initializer)
7495         (has_ravenscar_runtime, get_running_thread_id)
7496         (ravenscar_thread_target::resume): Fix indentation.
7497
7498 2019-02-15  Tom Tromey  <tromey@adacore.com>
7499
7500         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7501         from ravenscar_arch_ops.
7502         (sparc_ravenscar_ops::fetch_registers)
7503         (sparc_ravenscar_ops::store_registers): Now methods.
7504         (sparc_ravenscar_prepare_to_store): Remove.
7505         (sparc_ravenscar_ops): Redefine.
7506         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7507         methods and destructor.  Remove members.
7508         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7509         (ravenscar_thread_target::store_registers)
7510         (ravenscar_thread_target::prepare_to_store): Update.
7511         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7512         Remove.
7513         (struct ppc_ravenscar_powerpc_ops): Derive from
7514         ravenscar_arch_ops.
7515         (ppc_ravenscar_powerpc_ops::fetch_registers)
7516         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7517         (ppc_ravenscar_powerpc_ops): Redefine.
7518         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7519         (ppc_ravenscar_e500_ops::fetch_registers)
7520         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7521         (ppc_ravenscar_e500_ops): Redefine.
7522         * aarch64-ravenscar-thread.c
7523         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7524         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7525         (aarch64_ravenscar_fetch_registers)
7526         (aarch64_ravenscar_store_registers): Now methods.
7527         (aarch64_ravenscar_ops): Redefine.
7528
7529 2019-02-15  Tom Tromey  <tromey@adacore.com>
7530
7531         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7532         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7533         (ravenscar_thread_target::stopped_by_watchpoint)
7534         (ravenscar_thread_target::stopped_data_address)
7535         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7536
7537 2019-02-15  Tom Tromey  <tromey@adacore.com>
7538
7539         * ravenscar-thread.c: Fix some typos.
7540
7541 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7542             Tom Tromey  <tromey@adacore.com>
7543
7544         * ada-lang.c (ada_exception_sal): Change addr_string to a
7545         std::string.
7546         (create_ada_exception_catchpoint): Update.
7547
7548 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7549             Tom Tromey  <tromey@adacore.com>
7550
7551         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7552         (bp_location_ops): Remove.
7553         (base_breakpoint_allocate_location): Update.
7554         (free_bp_location): Update.
7555         * ada-lang.c (class ada_catchpoint_location)
7556         <ada_catchpoint_location>: Remove ops parameter.
7557         (ada_catchpoint_location_dtor): Remove.
7558         (ada_catchpoint_location_ops): Remove.
7559         (allocate_location_exception): Update.
7560         * breakpoint.h (struct bp_location_ops): Remove.
7561         (class bp_location) <bp_location>: Remove bp_location_ops
7562         parameter.
7563         <~bp_location>: Add destructor.
7564         <ops>: Remove.
7565
7566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7567             Pedro Alves  <palves@redhat.com>
7568
7569         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7570         'PATH_MAX'.
7571
7572 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7573             Samuel Thibault  <samuel.thibault@gnu.org>
7574             Thomas Schwinge  <thomas@codesourcery.com>
7575
7576         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7577         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7578
7579 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7580
7581         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7582         (check_empty): Use "const char *".
7583
7584         * gnu-nat.c (gnu_nat_target::detach): Instead of
7585         'detach_inferior (pid)' call
7586         'detach_inferior (find_inferior_pid (pid))'.
7587
7588         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7589         'nat/fork-inferior.o'.
7590         * gnu-nat.c: #include "nat/fork-inferior.h".
7591
7592         * gnu-nat.c (gnu_nat_target::detach): Instead of
7593         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7594         * gnu-nat.h: #include "inf-child.h".
7595         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7596         'i386_gnu_nat_target::fetch_registers'.
7597         (gnu_store_registers): Rename/move to
7598         'i386_gnu_nat_target::store_registers'.
7599
7600         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7601         * gnu-nat.h (mach_thread_info): New function.
7602         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7603
7604         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7605
7606 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7607
7608         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7609
7610 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7611
7612         * windows-nat.c (windows_add_thread): Add new parameter
7613         "main_thread_p" with default value set to false.  Update
7614         function documentation as well as all callers.
7615         (windows_delete_thread): Likewise.
7616         (fake_create_process): Update call to windows_add_thread.
7617         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7618         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7619         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7620         call to windows_delete_thread.
7621
7622 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7623
7624         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7625
7626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7627
7628         * symfile.c (find_separate_debug_file): Use canonical path of
7629         sysroot with child_path instead of gdb_sysroot if it is valid.
7630
7631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7632
7633         * symfile.c (find_separate_debug_file): Use child_path to
7634         determine if an object file is under a sysroot.
7635
7636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7637
7638         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7639         unittests/child-path-selftests.c.
7640         * common/pathstuff.c (child_path): New function.
7641         * common/pathstuff.h (child_path): New prototype.
7642         * unittests/child-path-selftests.c: New file.
7643
7644 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7645
7646         * symfile.c (find_separate_debug_file): Look for separate debug
7647         files in debug directories under the sysroot.
7648
7649 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7650
7651         * symtab.h (struct minimal_symbol data_p): New const method.
7652         (struct minimal_symbol text_p): Likewise.
7653         * symtab.c (output_source_filename): Use file name style
7654         to print file name.
7655         (print_symbol_info): Likewise.
7656         (print_msymbol_info): Use address style to print addresses.
7657         Use function name style to print executable text symbols.
7658         (expand_symtab_containing_pc): Use data_p.
7659         (find_pc_sect_compunit_symtab): Likewise.
7660
7661 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7662
7663         * breakpoint.c (describe_other_breakpoints): Use address style
7664         to print addresses.
7665         (say_where): Likewise.
7666
7667 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7668
7669         * ada-typeprint.c (print_func_type): Print function name
7670         style to print function name.
7671         * c-typeprint.c (c_print_type_1): Likewise.
7672
7673 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7674
7675         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7676         for execve.
7677
7678 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7679
7680         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7681         type_stack.
7682
7683 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7684
7685         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7686         TYPE_CODE_REF types.
7687
7688 2019-02-08  Jim Wilson  <jimw@sifive.com>
7689
7690         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7691         (riscv_linux_fregset): New.
7692         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7693
7694 2019-02-07  Tom Tromey  <tom@tromey.com>
7695
7696         * thread.c (thread_cancel_execution_command): Update.
7697         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7698         methods.
7699         (struct thread_fsm_ops): Remove.
7700         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7701         (thread_fsm_should_stop, thread_fsm_return_value)
7702         (thread_fsm_set_finished, thread_fsm_finished_p)
7703         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7704         Don't declare.
7705         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7706         * infrun.c (clear_proceed_status_thread)
7707         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7708         (print_stop_event): Update.
7709         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7710         Add constructor.
7711         (step_command_fsm_ops): Remove.
7712         (new_step_command_fsm): Remove.
7713         (step_1): Update.
7714         (step_command_fsm::should_stop): Rename from
7715         step_command_fsm_should_stop.
7716         (step_command_fsm::clean_up): Rename from
7717         step_command_fsm_clean_up.
7718         (step_command_fsm::do_async_reply_reason): Rename from
7719         step_command_fsm_async_reply_reason.
7720         (struct until_next_fsm): Inherit from thread_fsm.  Add
7721         constructor.
7722         (until_next_fsm_ops): Remove.
7723         (new_until_next_fsm): Remove.
7724         (until_next_fsm::should_stop): Rename from
7725         until_next_fsm_should_stop.
7726         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7727         (until_next_fsm::do_async_reply_reason): Rename from
7728         until_next_fsm_async_reply_reason.
7729         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7730         constructor.  Change type of breakpoint.
7731         (finish_command_fsm_ops): Remove.
7732         (new_finish_command_fsm): Remove.
7733         (finish_command_fsm::should_stop): Rename from
7734         finish_command_fsm_should_stop.
7735         (finish_command_fsm::clean_up): Rename from
7736         finish_command_fsm_clean_up.
7737         (finish_command_fsm::return_value): Rename from
7738         finish_command_fsm_return_value.
7739         (finish_command_fsm::do_async_reply_reason): Rename from
7740         finish_command_fsm_async_reply_reason.
7741         (finish_command): Update.
7742         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7743         Add constructor.
7744         (call_thread_fsm_ops): Remove.
7745         (call_thread_fsm::call_thread_fsm): Rename from
7746         new_call_thread_fsm.
7747         (call_thread_fsm::should_stop): Rename from
7748         call_thread_fsm_should_stop.
7749         (call_thread_fsm::should_notify_stop): Rename from
7750         call_thread_fsm_should_notify_stop.
7751         (run_inferior_call, call_function_by_hand_dummy): Update.
7752         * cli/cli-interp.c (should_print_stop_to_console): Update.
7753         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7754         Add constructor.  Change type of location_breakpoint,
7755         caller_breakpoint.
7756         (until_break_fsm_ops): Remove.
7757         (new_until_break_fsm): Remove.
7758         (until_break_fsm::should_stop): Rename from
7759         until_break_fsm_should_stop.
7760         (until_break_fsm::clean_up): Rename from
7761         until_break_fsm_clean_up.
7762         (until_break_fsm::do_async_reply_reason): Rename from
7763         until_break_fsm_async_reply_reason.
7764         (until_break_command): Update.
7765         * thread-fsm.c: Remove.
7766         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7767
7768 2019-02-07  Tom Tromey  <tom@tromey.com>
7769
7770         * yy-remap.h: Add include guard.
7771         * xtensa-tdep.h: Add include guard.
7772         * xcoffread.h: Rename include guard.
7773         * varobj-iter.h: Add include guard.
7774         * tui/tui.h: Rename include guard.
7775         * tui/tui-winsource.h: Rename include guard.
7776         * tui/tui-wingeneral.h: Rename include guard.
7777         * tui/tui-windata.h: Rename include guard.
7778         * tui/tui-win.h: Rename include guard.
7779         * tui/tui-stack.h: Rename include guard.
7780         * tui/tui-source.h: Rename include guard.
7781         * tui/tui-regs.h: Rename include guard.
7782         * tui/tui-out.h: Rename include guard.
7783         * tui/tui-layout.h: Rename include guard.
7784         * tui/tui-io.h: Rename include guard.
7785         * tui/tui-hooks.h: Rename include guard.
7786         * tui/tui-file.h: Rename include guard.
7787         * tui/tui-disasm.h: Rename include guard.
7788         * tui/tui-data.h: Rename include guard.
7789         * tui/tui-command.h: Rename include guard.
7790         * tic6x-tdep.h: Add include guard.
7791         * target/waitstatus.h: Rename include guard.
7792         * target/wait.h: Rename include guard.
7793         * target/target.h: Rename include guard.
7794         * target/resume.h: Rename include guard.
7795         * target-float.h: Rename include guard.
7796         * stabsread.h: Add include guard.
7797         * rs6000-tdep.h: Add include guard.
7798         * riscv-fbsd-tdep.h: Add include guard.
7799         * regformats/regdef.h: Rename include guard.
7800         * record.h: Rename include guard.
7801         * python/python.h: Rename include guard.
7802         * python/python-internal.h: Rename include guard.
7803         * python/py-stopevent.h: Rename include guard.
7804         * python/py-ref.h: Rename include guard.
7805         * python/py-record.h: Rename include guard.
7806         * python/py-record-full.h: Rename include guard.
7807         * python/py-record-btrace.h: Rename include guard.
7808         * python/py-instruction.h: Rename include guard.
7809         * python/py-events.h: Rename include guard.
7810         * python/py-event.h: Rename include guard.
7811         * procfs.h: Add include guard.
7812         * proc-utils.h: Add include guard.
7813         * p-lang.h: Add include guard.
7814         * or1k-tdep.h: Rename include guard.
7815         * observable.h: Rename include guard.
7816         * nto-tdep.h: Rename include guard.
7817         * nat/x86-linux.h: Rename include guard.
7818         * nat/x86-linux-dregs.h: Rename include guard.
7819         * nat/x86-gcc-cpuid.h: Add include guard.
7820         * nat/x86-dregs.h: Rename include guard.
7821         * nat/x86-cpuid.h: Rename include guard.
7822         * nat/ppc-linux.h: Rename include guard.
7823         * nat/mips-linux-watch.h: Rename include guard.
7824         * nat/linux-waitpid.h: Rename include guard.
7825         * nat/linux-ptrace.h: Rename include guard.
7826         * nat/linux-procfs.h: Rename include guard.
7827         * nat/linux-osdata.h: Rename include guard.
7828         * nat/linux-nat.h: Rename include guard.
7829         * nat/linux-namespaces.h: Rename include guard.
7830         * nat/linux-btrace.h: Rename include guard.
7831         * nat/glibc_thread_db.h: Rename include guard.
7832         * nat/gdb_thread_db.h: Rename include guard.
7833         * nat/gdb_ptrace.h: Rename include guard.
7834         * nat/fork-inferior.h: Rename include guard.
7835         * nat/amd64-linux-siginfo.h: Rename include guard.
7836         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7837         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7838         * nat/aarch64-linux.h: Rename include guard.
7839         * nat/aarch64-linux-hw-point.h: Rename include guard.
7840         * mn10300-tdep.h: Add include guard.
7841         * mips-linux-tdep.h: Add include guard.
7842         * mi/mi-parse.h: Rename include guard.
7843         * mi/mi-out.h: Rename include guard.
7844         * mi/mi-main.h: Rename include guard.
7845         * mi/mi-interp.h: Rename include guard.
7846         * mi/mi-getopt.h: Rename include guard.
7847         * mi/mi-console.h: Rename include guard.
7848         * mi/mi-common.h: Rename include guard.
7849         * mi/mi-cmds.h: Rename include guard.
7850         * mi/mi-cmd-break.h: Rename include guard.
7851         * m2-lang.h: Add include guard.
7852         * location.h: Rename include guard.
7853         * linux-record.h: Rename include guard.
7854         * linux-nat.h: Add include guard.
7855         * linux-fork.h: Add include guard.
7856         * i386-darwin-tdep.h: Rename include guard.
7857         * hppa-linux-offsets.h: Add include guard.
7858         * guile/guile.h: Rename include guard.
7859         * guile/guile-internal.h: Rename include guard.
7860         * gnu-nat.h: Rename include guard.
7861         * gdb-stabs.h: Rename include guard.
7862         * frv-tdep.h: Add include guard.
7863         * f-lang.h: Add include guard.
7864         * event-loop.h: Add include guard.
7865         * darwin-nat.h: Rename include guard.
7866         * cp-abi.h: Rename include guard.
7867         * config/sparc/nm-sol2.h: Rename include guard.
7868         * config/nm-nto.h: Rename include guard.
7869         * config/nm-linux.h: Add include guard.
7870         * config/i386/nm-i386gnu.h: Rename include guard.
7871         * config/djgpp/nl_types.h: Rename include guard.
7872         * config/djgpp/langinfo.h: Rename include guard.
7873         * compile/gcc-cp-plugin.h: Add include guard.
7874         * compile/gcc-c-plugin.h: Add include guard.
7875         * compile/compile.h: Rename include guard.
7876         * compile/compile-object-run.h: Rename include guard.
7877         * compile/compile-object-load.h: Rename include guard.
7878         * compile/compile-internal.h: Rename include guard.
7879         * compile/compile-cplus.h: Rename include guard.
7880         * compile/compile-c.h: Rename include guard.
7881         * common/xml-utils.h: Rename include guard.
7882         * common/x86-xstate.h: Rename include guard.
7883         * common/version.h: Rename include guard.
7884         * common/vec.h: Rename include guard.
7885         * common/tdesc.h: Rename include guard.
7886         * common/selftest.h: Rename include guard.
7887         * common/scoped_restore.h: Rename include guard.
7888         * common/scoped_mmap.h: Rename include guard.
7889         * common/scoped_fd.h: Rename include guard.
7890         * common/safe-iterator.h: Rename include guard.
7891         * common/run-time-clock.h: Rename include guard.
7892         * common/refcounted-object.h: Rename include guard.
7893         * common/queue.h: Rename include guard.
7894         * common/ptid.h: Rename include guard.
7895         * common/print-utils.h: Rename include guard.
7896         * common/preprocessor.h: Rename include guard.
7897         * common/pathstuff.h: Rename include guard.
7898         * common/observable.h: Rename include guard.
7899         * common/netstuff.h: Rename include guard.
7900         * common/job-control.h: Rename include guard.
7901         * common/host-defs.h: Rename include guard.
7902         * common/gdb_wait.h: Rename include guard.
7903         * common/gdb_vecs.h: Rename include guard.
7904         * common/gdb_unlinker.h: Rename include guard.
7905         * common/gdb_unique_ptr.h: Rename include guard.
7906         * common/gdb_tilde_expand.h: Rename include guard.
7907         * common/gdb_sys_time.h: Rename include guard.
7908         * common/gdb_string_view.h: Rename include guard.
7909         * common/gdb_splay_tree.h: Rename include guard.
7910         * common/gdb_setjmp.h: Rename include guard.
7911         * common/gdb_ref_ptr.h: Rename include guard.
7912         * common/gdb_optional.h: Rename include guard.
7913         * common/gdb_locale.h: Rename include guard.
7914         * common/gdb_assert.h: Rename include guard.
7915         * common/filtered-iterator.h: Rename include guard.
7916         * common/filestuff.h: Rename include guard.
7917         * common/fileio.h: Rename include guard.
7918         * common/environ.h: Rename include guard.
7919         * common/common-utils.h: Rename include guard.
7920         * common/common-types.h: Rename include guard.
7921         * common/common-regcache.h: Rename include guard.
7922         * common/common-inferior.h: Rename include guard.
7923         * common/common-gdbthread.h: Rename include guard.
7924         * common/common-exceptions.h: Rename include guard.
7925         * common/common-defs.h: Rename include guard.
7926         * common/common-debug.h: Rename include guard.
7927         * common/cleanups.h: Rename include guard.
7928         * common/buffer.h: Rename include guard.
7929         * common/btrace-common.h: Rename include guard.
7930         * common/break-common.h: Rename include guard.
7931         * cli/cli-utils.h: Rename include guard.
7932         * cli/cli-style.h: Rename include guard.
7933         * cli/cli-setshow.h: Rename include guard.
7934         * cli/cli-script.h: Rename include guard.
7935         * cli/cli-interp.h: Rename include guard.
7936         * cli/cli-decode.h: Rename include guard.
7937         * cli/cli-cmds.h: Rename include guard.
7938         * charset-list.h: Add include guard.
7939         * buildsym-legacy.h: Rename include guard.
7940         * bfin-tdep.h: Add include guard.
7941         * ax.h: Rename include guard.
7942         * arm-linux-tdep.h: Add include guard.
7943         * arm-fbsd-tdep.h: Add include guard.
7944         * arch/xtensa.h: Rename include guard.
7945         * arch/tic6x.h: Add include guard.
7946         * arch/i386.h: Add include guard.
7947         * arch/arm.h: Rename include guard.
7948         * arch/arm-linux.h: Rename include guard.
7949         * arch/arm-get-next-pcs.h: Rename include guard.
7950         * arch/amd64.h: Add include guard.
7951         * arch/aarch64-insn.h: Rename include guard.
7952         * arch-utils.h: Rename include guard.
7953         * annotate.h: Add include guard.
7954         * amd64-darwin-tdep.h: Rename include guard.
7955         * aarch64-linux-tdep.h: Add include guard.
7956         * aarch64-fbsd-tdep.h: Add include guard.
7957         * aarch32-linux-nat.h: Add include guard.
7958
7959 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7960
7961         * macrotab.c (macro_define_internal): New function that
7962         factorizes macro_define_object_internal and macro_define_function
7963         code.
7964         (macro_define_object_internal): Use macro_define_internal.
7965         (macro_define_function): Likewise.
7966
7967 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7968
7969         * macrocmd.c (extract_identifier): Return
7970         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7971         callers.
7972
7973 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7974
7975         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7976
7977 2019-02-05  Tom Tromey  <tom@tromey.com>
7978
7979         * target.c (target_stack::unpush): Move assertion earlier.
7980
7981 2019-01-30  Tom Tromey  <tom@tromey.com>
7982
7983         PR python/23615:
7984         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7985         (gdbpy_parse_and_eval): Likewise.
7986         * python/python-internal.h (gdbpy_allow_threads): New class.
7987
7988 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7989
7990         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7991         (aarch64_fbsd_fpregmap): Move earlier.
7992         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7993         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7994         instead of individual calls to trad_frame_set_reg_addr.
7995         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7996         earlier.
7997         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7998         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7999         instead of individual calls to trad_frame_set_reg_addr.
8000
8001 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8002
8003         * CONTRIBUTE: Replace contribution list with wiki link.
8004
8005 2019-01-25  Tom Tromey  <tom@tromey.com>
8006
8007         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8008
8009 2019-01-25  Tom Tromey  <tom@tromey.com>
8010
8011         * xtensa-linux-nat.c: Fix common/ includes.
8012         * xml-support.h: Fix common/ includes.
8013         * xml-support.c: Fix common/ includes.
8014         * x86-linux-nat.c: Fix common/ includes.
8015         * windows-nat.c: Fix common/ includes.
8016         * varobj.h: Fix common/ includes.
8017         * varobj.c: Fix common/ includes.
8018         * value.c: Fix common/ includes.
8019         * valops.c: Fix common/ includes.
8020         * utils.c: Fix common/ includes.
8021         * unittests/xml-utils-selftests.c: Fix common/ includes.
8022         * unittests/utils-selftests.c: Fix common/ includes.
8023         * unittests/unpack-selftests.c: Fix common/ includes.
8024         * unittests/tracepoint-selftests.c: Fix common/ includes.
8025         * unittests/style-selftests.c: Fix common/ includes.
8026         * unittests/string_view-selftests.c: Fix common/ includes.
8027         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8028         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8029         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8030         * unittests/rsp-low-selftests.c: Fix common/ includes.
8031         * unittests/parse-connection-spec-selftests.c: Fix common/
8032         includes.
8033         * unittests/optional-selftests.c: Fix common/ includes.
8034         * unittests/offset-type-selftests.c: Fix common/ includes.
8035         * unittests/observable-selftests.c: Fix common/ includes.
8036         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8037         * unittests/memrange-selftests.c: Fix common/ includes.
8038         * unittests/memory-map-selftests.c: Fix common/ includes.
8039         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8040         * unittests/function-view-selftests.c: Fix common/ includes.
8041         * unittests/environ-selftests.c: Fix common/ includes.
8042         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8043         * unittests/common-utils-selftests.c: Fix common/ includes.
8044         * unittests/cli-utils-selftests.c: Fix common/ includes.
8045         * unittests/array-view-selftests.c: Fix common/ includes.
8046         * ui-file.c: Fix common/ includes.
8047         * tui/tui-io.c: Fix common/ includes.
8048         * tracepoint.h: Fix common/ includes.
8049         * tracepoint.c: Fix common/ includes.
8050         * tracefile-tfile.c: Fix common/ includes.
8051         * top.h: Fix common/ includes.
8052         * top.c: Fix common/ includes.
8053         * thread.c: Fix common/ includes.
8054         * target/waitstatus.h: Fix common/ includes.
8055         * target/waitstatus.c: Fix common/ includes.
8056         * target.h: Fix common/ includes.
8057         * target.c: Fix common/ includes.
8058         * target-memory.c: Fix common/ includes.
8059         * target-descriptions.c: Fix common/ includes.
8060         * symtab.h: Fix common/ includes.
8061         * symfile.c: Fix common/ includes.
8062         * stap-probe.c: Fix common/ includes.
8063         * spu-linux-nat.c: Fix common/ includes.
8064         * sparc-nat.c: Fix common/ includes.
8065         * source.c: Fix common/ includes.
8066         * solib.c: Fix common/ includes.
8067         * solib-target.c: Fix common/ includes.
8068         * ser-unix.c: Fix common/ includes.
8069         * ser-tcp.c: Fix common/ includes.
8070         * ser-pipe.c: Fix common/ includes.
8071         * ser-base.c: Fix common/ includes.
8072         * selftest-arch.c: Fix common/ includes.
8073         * s12z-tdep.c: Fix common/ includes.
8074         * rust-exp.y: Fix common/ includes.
8075         * rs6000-aix-tdep.c: Fix common/ includes.
8076         * riscv-tdep.c: Fix common/ includes.
8077         * remote.c: Fix common/ includes.
8078         * remote-notif.h: Fix common/ includes.
8079         * remote-fileio.h: Fix common/ includes.
8080         * remote-fileio.c: Fix common/ includes.
8081         * regcache.h: Fix common/ includes.
8082         * regcache.c: Fix common/ includes.
8083         * record-btrace.c: Fix common/ includes.
8084         * python/python.c: Fix common/ includes.
8085         * python/py-type.c: Fix common/ includes.
8086         * python/py-inferior.c: Fix common/ includes.
8087         * progspace.h: Fix common/ includes.
8088         * producer.c: Fix common/ includes.
8089         * procfs.c: Fix common/ includes.
8090         * proc-api.c: Fix common/ includes.
8091         * printcmd.c: Fix common/ includes.
8092         * ppc-linux-nat.c: Fix common/ includes.
8093         * parser-defs.h: Fix common/ includes.
8094         * osdata.c: Fix common/ includes.
8095         * obsd-nat.c: Fix common/ includes.
8096         * nat/x86-linux.c: Fix common/ includes.
8097         * nat/x86-linux-dregs.c: Fix common/ includes.
8098         * nat/x86-dregs.h: Fix common/ includes.
8099         * nat/x86-dregs.c: Fix common/ includes.
8100         * nat/ppc-linux.c: Fix common/ includes.
8101         * nat/mips-linux-watch.h: Fix common/ includes.
8102         * nat/mips-linux-watch.c: Fix common/ includes.
8103         * nat/linux-waitpid.c: Fix common/ includes.
8104         * nat/linux-ptrace.h: Fix common/ includes.
8105         * nat/linux-ptrace.c: Fix common/ includes.
8106         * nat/linux-procfs.c: Fix common/ includes.
8107         * nat/linux-personality.c: Fix common/ includes.
8108         * nat/linux-osdata.c: Fix common/ includes.
8109         * nat/linux-namespaces.c: Fix common/ includes.
8110         * nat/linux-btrace.h: Fix common/ includes.
8111         * nat/linux-btrace.c: Fix common/ includes.
8112         * nat/fork-inferior.c: Fix common/ includes.
8113         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8114         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8115         * nat/aarch64-linux.c: Fix common/ includes.
8116         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8117         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8118         * namespace.h: Fix common/ includes.
8119         * mips-linux-tdep.c: Fix common/ includes.
8120         * minsyms.c: Fix common/ includes.
8121         * mi/mi-parse.h: Fix common/ includes.
8122         * mi/mi-main.c: Fix common/ includes.
8123         * mi/mi-cmd-env.c: Fix common/ includes.
8124         * memrange.h: Fix common/ includes.
8125         * memattr.c: Fix common/ includes.
8126         * maint.h: Fix common/ includes.
8127         * maint.c: Fix common/ includes.
8128         * main.c: Fix common/ includes.
8129         * machoread.c: Fix common/ includes.
8130         * location.c: Fix common/ includes.
8131         * linux-thread-db.c: Fix common/ includes.
8132         * linux-nat.c: Fix common/ includes.
8133         * linux-fork.c: Fix common/ includes.
8134         * inline-frame.c: Fix common/ includes.
8135         * infrun.c: Fix common/ includes.
8136         * inflow.c: Fix common/ includes.
8137         * inferior.h: Fix common/ includes.
8138         * inferior.c: Fix common/ includes.
8139         * infcmd.c: Fix common/ includes.
8140         * inf-ptrace.c: Fix common/ includes.
8141         * inf-child.c: Fix common/ includes.
8142         * ia64-linux-nat.c: Fix common/ includes.
8143         * i387-tdep.c: Fix common/ includes.
8144         * i386-tdep.c: Fix common/ includes.
8145         * i386-linux-tdep.c: Fix common/ includes.
8146         * i386-linux-nat.c: Fix common/ includes.
8147         * i386-go32-tdep.c: Fix common/ includes.
8148         * i386-fbsd-tdep.c: Fix common/ includes.
8149         * i386-fbsd-nat.c: Fix common/ includes.
8150         * guile/scm-type.c: Fix common/ includes.
8151         * guile/guile.c: Fix common/ includes.
8152         * go32-nat.c: Fix common/ includes.
8153         * gnu-nat.c: Fix common/ includes.
8154         * gdbthread.h: Fix common/ includes.
8155         * gdbarch-selftests.c: Fix common/ includes.
8156         * gdb_usleep.c: Fix common/ includes.
8157         * gdb_select.h: Fix common/ includes.
8158         * gdb_bfd.c: Fix common/ includes.
8159         * gcore.c: Fix common/ includes.
8160         * fork-child.c: Fix common/ includes.
8161         * findvar.c: Fix common/ includes.
8162         * fbsd-nat.c: Fix common/ includes.
8163         * event-top.c: Fix common/ includes.
8164         * event-loop.c: Fix common/ includes.
8165         * dwarf2read.c: Fix common/ includes.
8166         * dwarf2loc.c: Fix common/ includes.
8167         * dwarf2-frame.c: Fix common/ includes.
8168         * dwarf-index-cache.c: Fix common/ includes.
8169         * dtrace-probe.c: Fix common/ includes.
8170         * disasm-selftests.c: Fix common/ includes.
8171         * defs.h: Fix common/ includes.
8172         * csky-tdep.c: Fix common/ includes.
8173         * cp-valprint.c: Fix common/ includes.
8174         * cp-support.h: Fix common/ includes.
8175         * cp-support.c: Fix common/ includes.
8176         * corelow.c: Fix common/ includes.
8177         * completer.h: Fix common/ includes.
8178         * completer.c: Fix common/ includes.
8179         * compile/compile.c: Fix common/ includes.
8180         * compile/compile-loc2c.c: Fix common/ includes.
8181         * compile/compile-cplus-types.c: Fix common/ includes.
8182         * compile/compile-cplus-symbols.c: Fix common/ includes.
8183         * command.h: Fix common/ includes.
8184         * cli/cli-dump.c: Fix common/ includes.
8185         * cli/cli-cmds.c: Fix common/ includes.
8186         * charset.c: Fix common/ includes.
8187         * build-id.c: Fix common/ includes.
8188         * btrace.h: Fix common/ includes.
8189         * btrace.c: Fix common/ includes.
8190         * breakpoint.h: Fix common/ includes.
8191         * breakpoint.c: Fix common/ includes.
8192         * ax.h: 
8193         (enum agent_op): Fix common/ includes.
8194         * ax-general.c (struct aop_map): Fix common/ includes.
8195         * ax-gdb.c: Fix common/ includes.
8196         * auxv.c: Fix common/ includes.
8197         * auto-load.c: Fix common/ includes.
8198         * arm-tdep.c: Fix common/ includes.
8199         * arch/riscv.c: Fix common/ includes.
8200         * arch/ppc-linux-common.c: Fix common/ includes.
8201         * arch/i386.c: Fix common/ includes.
8202         * arch/arm.c: Fix common/ includes.
8203         * arch/arm-linux.c: Fix common/ includes.
8204         * arch/arm-get-next-pcs.c: Fix common/ includes.
8205         * arch/amd64.c: Fix common/ includes.
8206         * arch/aarch64.c: Fix common/ includes.
8207         * arch/aarch64-insn.c: Fix common/ includes.
8208         * arch-utils.c: Fix common/ includes.
8209         * amd64-windows-tdep.c: Fix common/ includes.
8210         * amd64-tdep.c: Fix common/ includes.
8211         * amd64-sol2-tdep.c: Fix common/ includes.
8212         * amd64-obsd-tdep.c: Fix common/ includes.
8213         * amd64-nbsd-tdep.c: Fix common/ includes.
8214         * amd64-linux-tdep.c: Fix common/ includes.
8215         * amd64-linux-nat.c: Fix common/ includes.
8216         * amd64-fbsd-tdep.c: Fix common/ includes.
8217         * amd64-fbsd-nat.c: Fix common/ includes.
8218         * amd64-dicos-tdep.c: Fix common/ includes.
8219         * amd64-darwin-tdep.c: Fix common/ includes.
8220         * agent.c: Fix common/ includes.
8221         * ada-lang.h: Fix common/ includes.
8222         * ada-lang.c: Fix common/ includes.
8223         * aarch64-tdep.c: Fix common/ includes.
8224
8225 2019-01-25  Tom Tromey  <tom@tromey.com>
8226
8227         * common/create-version.sh: Use common/version.h.
8228
8229 2019-01-24  Pedro Alves  <palves@redhat.com>
8230
8231         * infrun.c (signal_stop, signal_print, signal_program)
8232         (signal_catch, signal_pass): Now arrays instead of pointers.
8233         (update_signals_program_target, do_target_resume)
8234         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8235         * linux-nat.c (linux_nat_target::pass_signals)
8236         (linux_nat_target::create_inferior, linux_nat_target::attach):
8237         Adjust.
8238         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8239         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8240         * procfs.c (procfs_target::pass_signals): Adjust.
8241         * record-full.c (record_full_target::resume): Adjust.
8242         * remote.c (remote_target::pass_signals)
8243         (remote_target::program_signals): Adjust.
8244         * target-debug.h (target_debug_print_signals): Now takes a
8245         gdb::array_view as parameter.  Adjust.
8246         * target.h (target_ops) <pass_signals, program_signals>: Replace
8247         pointer and length parameters with gdb::array_view.
8248         (target_pass_signals, target_program_signals): Likewise.
8249         * target-delegates.c: Regenerate.
8250
8251 2019-01-24  Pedro Alves  <palves@redhat.com>
8252
8253         * common/forward-scope-exit.h
8254         (forward_scope_exit::forward_scope_exit): Pass arguments to
8255         m_bind_function directly, instead of creating a std::bind and
8256         copying that.
8257
8258 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8259
8260         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8261         for static members.
8262         (pass_in_v_vfp_candidate): Likewise.
8263
8264 2019-01-23  Tom Tromey  <tom@tromey.com>
8265             Pedro Alves  <palves@redhat.com>
8266
8267         * regcache.c (class regcache_invalidator): Remove.
8268         (regcache::raw_write): Use make_scope_exit.
8269
8270 2019-01-23  Tom Tromey  <tom@tromey.com>
8271
8272         * ui-out.h (class ui_out_emit_type): Update comment.
8273
8274 2019-01-23  Tom Tromey  <tom@tromey.com>
8275
8276         * infrun.c (fetch_inferior_event): Update comment.
8277
8278 2019-01-23  Tom Tromey  <tom@tromey.com>
8279             Pedro Alves  <palves@redhat.com>
8280
8281         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8282         parameter.
8283         (fetch_inferior_event): Use SCOPE_EXIT.
8284
8285
8286 2019-01-23  Tom Tromey  <tom@tromey.com>
8287             Pedro Alves  <palves@redhat.com>
8288
8289         * infrun.c (disable_thread_events): Delete.
8290         (stop_all_threads): Use SCOPE_EXIT.
8291
8292 2019-01-23  Tom Tromey  <tom@tromey.com>
8293             Pedro Alves  <palves@redhat.com>
8294
8295         * symfile.c: Include forward-scope-exit.h.
8296         (clear_symtab_users_cleanup): Replace forward declaration with
8297         a FORWARD_SCOPE_EXIT.
8298         (syms_from_objfile_1): Use the forward_scope_exit and
8299         gdb::optional instead of cleanup_function.
8300         (reread_symbols): Use the forward_scope_exit instead of
8301         cleanup_function.
8302         (clear_symtab_users_cleanup): Remove function.
8303
8304 2019-01-23  Tom Tromey  <tom@tromey.com>
8305             Pedro Alves  <palves@redhat.com>
8306
8307         * linux-nat.c: Include scope-exit.h.
8308         (cleanup_target_stop): Remove.
8309         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8310         SCOPE_EXIT.
8311
8312 2019-01-23  Tom Tromey  <tom@tromey.com>
8313             Pedro Alves  <palves@redhat.com>
8314
8315         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8316         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8317
8318 2019-01-23  Tom Tromey  <tom@tromey.com>
8319             Andrew Burgess  <andrew.burgess@embecosm.com>
8320             Pedro Alves  <palves@redhat.com>
8321
8322         * infrun.c (fetch_inferior_event): Use scope_exit.
8323         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8324         * top.c (execute_command): Use scope_exit.
8325         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8326         * utils.c (do_bpstat_clear_actions_cleanup)
8327         (make_bpstat_clear_actions_cleanup): Remove.
8328
8329 2019-01-23  Tom Tromey  <tom@tromey.com>
8330             Pedro Alves  <palves@redhat.com>
8331
8332         * infrun.c: Include "common/scope-exit.h"
8333         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8334         (wait_for_inferior): Use SCOPE_EXIT.
8335         (fetch_inferior_event): Use scope_exit.
8336
8337 2019-01-23  Tom Tromey  <tom@tromey.com>
8338             Pedro Alves  <palves@redhat.com>
8339
8340         * breakpoint.c (create_breakpoint): Remove cleanup.
8341
8342 2019-01-23  Tom Tromey  <tom@tromey.com>
8343             Andrew Burgess  <andrew.burgess@embecosm.com>
8344             Pedro Alves  <palves@redhat.com>
8345
8346 2019-01-23  Pedro Alves  <palves@redhat.com>
8347
8348         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8349
8350 2019-01-23  Pedro Alves  <palves@redhat.com>
8351             Andrew Burgess  <andrew.burgess@embecosm.com>
8352
8353         * gdbthread.h: Include "common/forward-scope-exit.h".
8354         (scoped_finish_thread_state): Redefine custom class in terms of
8355         forward_scope_exit.
8356
8357 2019-01-23  Pedro Alves  <palves@redhat.com>
8358             Andrew Burgess  <andrew.burgess@embecosm.com>
8359
8360         * common/forward-scope-exit.h: New file.
8361
8362 2019-01-23  Pedro Alves  <palves@redhat.com>
8363             Andrew Burgess  <andrew.burgess@embecosm.com>
8364             Tom Tromey  <tom@tromey.com>
8365
8366         * common/scope-exit.h: New file.
8367
8368 2019-01-23  Pedro Alves  <palves@redhat.com>
8369
8370         * common/preprocessor.h (ESC): Rename to ...
8371         (ESC_PARENS): ... this.
8372         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8373         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8374
8375 2019-01-23  Tom Tromey  <tom@tromey.com>
8376
8377         * language.h (class scoped_switch_to_sym_language_if_auto):
8378         Initialize m_lang in both cases.
8379
8380 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8381
8382         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8383         with XCNEW.
8384
8385 2019-01-22  Tom Tromey  <tom@tromey.com>
8386
8387         * corelow.c: Do not include sys/file.h.
8388
8389 2019-01-22  Tom Tromey  <tom@tromey.com>
8390
8391         * tui/tui-wingeneral.h: Include gdb_curses.h.
8392
8393 2019-01-22  Tom Tromey  <tom@tromey.com>
8394
8395         * source-cache.h (class source_cache) <get_source_lines,
8396         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8397
8398 2019-01-22  Tom Tromey  <tom@tromey.com>
8399
8400         * remote-fileio.h (struct remote_target): Declare.
8401
8402 2019-01-22  Tom Tromey  <tom@tromey.com>
8403
8404         * python/py-arch.c: Do not include py-ref.h.
8405         * python/py-bpevent.c: Do not include py-ref.h.
8406         * python/py-cmd.c: Do not include py-ref.h.
8407         * python/py-continueevent.c: Do not include py-ref.h.
8408         * python/py-event.h: Do not include py-ref.h.
8409         * python/py-evtregistry.c: Do not include py-ref.h.
8410         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8411         * python/py-frame.c: Do not include py-ref.h.
8412         * python/py-framefilter.c: Do not include py-ref.h.
8413         * python/py-function.c: Do not include py-ref.h.
8414         * python/py-infevents.c: Do not include py-ref.h.
8415         * python/py-linetable.c: Do not include py-ref.h.
8416         * python/py-objfile.c: Do not include py-ref.h.
8417         * python/py-param.c: Do not include py-ref.h.
8418         * python/py-prettyprint.c: Do not include py-ref.h.
8419         * python/py-progspace.c: Do not include py-ref.h.
8420         * python/py-symbol.c: Do not include py-ref.h.
8421         * python/py-symtab.c: Do not include py-ref.h.
8422         * python/py-type.c: Do not include py-ref.h.
8423         * python/py-unwind.c: Do not include py-ref.h.
8424         * python/py-utils.c: Do not include py-ref.h.
8425         * python/py-value.c: Do not include py-ref.h.
8426         * python/py-varobj.c: Do not include py-ref.h.
8427         * python/py-xmethods.c: Do not include py-ref.h.
8428         * python/python.c: Do not include py-ref.h.
8429         * varobj.c: Do not include py-ref.h.
8430
8431 2019-01-22  Tom Tromey  <tom@tromey.com>
8432
8433         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8434         keyword for bcache.
8435
8436 2019-01-22  Tom Tromey  <tom@tromey.com>
8437
8438         * compile/compile-cplus-types.c: Remove a comment by #include.
8439
8440 2019-01-22  Tom Tromey  <tom@tromey.com>
8441
8442         * compile/gcc-c-plugin.h: Include compile-internal.h.
8443
8444 2019-01-22  Tom Tromey  <tom@tromey.com>
8445
8446         * stabsread.c (EXTERN): Do not define.
8447         (symnum, next_symbol_text_func, processing_gcc_compilation)
8448         (within_function, global_sym_chain, global_stabs)
8449         (previous_stab_code, this_object_header_files)
8450         (n_this_object_header_files)
8451         (n_allocated_this_object_header_files): Define.
8452         * stabsread.h (EXTERN): Never define.  Use "extern".
8453
8454 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8455
8456         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8457         history_value.
8458
8459 2019-01-21  Tom Tromey  <tom@tromey.com>
8460
8461         * ui-out.c: Fix includes.
8462         * tui/tui-source.c: Fix includes.
8463         * target.c: Fix includes.
8464         * remote.c: Fix includes.
8465         * regcache.c: Fix includes.
8466         * python/py-block.c: Fix includes.
8467         * printcmd.c: Fix includes.
8468         * or1k-tdep.c: Fix includes.
8469         * mi/mi-main.c: Fix includes.
8470         * m32r-tdep.c: Fix includes.
8471         * csky-tdep.c: Fix includes.
8472         * compile/compile-cplus-types.c: Fix includes.
8473         * cli/cli-interp.c: Fix includes.
8474
8475 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8476
8477         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8478         for padding.
8479
8480 2019-01-16  Tom Tromey  <tom@tromey.com>
8481
8482         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8483         earlier.
8484         (struct objfile) <msymbols_range>: Move from top level.
8485         <msymbols>: New method.
8486         (class objfile_msymbols): Remove.
8487         * symtab.c (default_collect_symbol_completion_matches_break_on):
8488         Update.
8489         * symmisc.c (dump_msymbols): Update.
8490         * stabsread.c (scan_file_globals): Update.
8491         * objc-lang.c (info_selectors_command, info_classes_command)
8492         (find_methods): Update.
8493         * minsyms.c (find_solib_trampoline_target): Update.
8494         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8495         * coffread.c (coff_symfile_read): Update.
8496         * ada-lang.c (ada_lookup_simple_minsym)
8497         (ada_collect_symbol_completion_matches): Update.
8498
8499 2019-01-16  Tom Tromey  <tom@tromey.com>
8500
8501         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8502         type.  Remove no-argument constructor.
8503         <iterator::operator++>: Simplify.
8504         <begin>: Update.
8505         <end>: Use minimal_symbol_count.
8506
8507 2019-01-16  Tom Tromey  <tom@tromey.com>
8508
8509         * objfiles.h (struct objfile) <psymtabs>: New method.
8510         (class objfile_psymtabs): Remove.
8511         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8512         typedef.
8513         <range>: New method.
8514         (require_partial_symbols): Change return type.
8515         * psymtab.c (require_partial_symbols)
8516         (psym_expand_symtabs_matching): Update.
8517         * mdebugread.c (parse_partial_symbols): Update.
8518         * dbxread.c (dbx_end_psymtab): Update.
8519
8520 2019-01-15  Tom Tromey  <tom@tromey.com>
8521
8522         * symtab.c (lookup_objfile_from_block)
8523         (lookup_symbol_in_objfile_symtabs)
8524         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8525         (find_line_symtab, info_sources_command)
8526         (default_collect_symbol_completion_matches_break_on)
8527         (make_source_files_completion_list): Update.
8528         * symmisc.c (print_objfile_statistics, dump_objfile)
8529         (maintenance_print_symbols, maintenance_info_symtabs)
8530         (maintenance_check_symtabs, maintenance_info_line_tables):
8531         Update.
8532         * source.c (select_source_symtab)
8533         (forget_cached_source_info_for_objfile): Update.
8534         * objfiles.h (class objfile_compunits): Remove.
8535         (struct objfile) <compunits_range>: New typedef.
8536         (compunits): New method.
8537         * objfiles.c (objfile_relocate1): Update.
8538         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8539         * maint.c (count_symtabs_and_blocks): Update.
8540         * linespec.c (iterate_over_all_matching_symtabs): Update.
8541         * cp-support.c (add_symbol_overload_list_qualified): Update.
8542         * coffread.c (coff_symtab_read): Update.
8543         * ada-lang.c (add_nonlocal_symbols)
8544         (ada_collect_symbol_completion_matches)
8545         (ada_add_global_exceptions): Update.
8546
8547 2019-01-15  Tom Tromey  <tom@tromey.com>
8548
8549         * progspace.h (program_space) <objfiles_safe_range>: New
8550         typedef.
8551         <objfiles_safe>: New method.
8552         * objfiles.h (class all_objfiles_safe): Remove.
8553         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8554         * jit.c (jit_inferior_exit_hook): Update.
8555
8556 2019-01-17  Tom Tromey  <tom@tromey.com>
8557
8558         * progspace.h (program_space) <objfiles_range>: New typedef.
8559         <objfiles>: New method.
8560         <objfiles_head>: Rename from objfiles.
8561         (object_files): Update.
8562         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8563         * guile/scm-pretty-print.c
8564         (ppscm_find_pretty_printer_from_objfiles): Update.
8565         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8566         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8567         Update.
8568         * python/py-progspace.c (pspy_get_objfiles): Update.
8569         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8570         Update.
8571         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8572         (objfpy_lookup_objfile_by_build_id): Update.
8573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8574         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8575         Update.
8576         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8577         (expand_symtab_containing_pc, lookup_objfile_from_block)
8578         (lookup_static_symbol, basic_lookup_transparent_type)
8579         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8580         (find_line_symtab, info_sources_command)
8581         (default_collect_symbol_completion_matches_break_on)
8582         (make_source_files_completion_list, find_main_name): Update.
8583         * symmisc.c (print_symbol_bcache_statistics)
8584         (print_objfile_statistics, maintenance_print_symbols)
8585         (maintenance_print_msymbols, maintenance_print_objfiles)
8586         (maintenance_info_symtabs, maintenance_check_symtabs)
8587         (maintenance_expand_symtabs, maintenance_info_line_tables):
8588         Update.
8589         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8590         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8591         (map_overlay_command, unmap_overlay_command)
8592         (simple_overlay_update, expand_symtabs_matching)
8593         (map_symbol_filenames): Update.
8594         * symfile-debug.c (set_debug_symfile): Update.
8595         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8596         Update.
8597         * source.c (select_source_symtab, forget_cached_source_info):
8598         Update.
8599         * solib.c (solib_read_symbols): Update.
8600         * solib-spu.c (append_ocl_sos): Update.
8601         * psymtab.c (maintenance_print_psymbols)
8602         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8603         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8604         * printcmd.c (info_symbol_command): Update.
8605         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8606         Update.
8607         * objfiles.h (class all_objfiles): Remove.
8608         * objfiles.c (have_partial_symbols, have_full_symbols)
8609         (have_minimal_symbols, qsort_cmp, update_section_map)
8610         (shared_objfile_contains_address_p)
8611         (default_iterate_over_objfiles_in_search_order): Update.
8612         * objc-lang.c (info_selectors_command, info_classes_command)
8613         (find_methods): Update.
8614         * minsyms.c (find_solib_trampoline_target): Update.
8615         * maint.c (maintenance_info_sections)
8616         (maintenance_translate_address, count_symtabs_and_blocks):
8617         Update.
8618         * main.c (captured_main_1): Update.
8619         * linux-thread-db.c (try_thread_db_load_from_pdir)
8620         (has_libpthread): Update.
8621         * linespec.c (iterate_over_all_matching_symtabs)
8622         (search_minsyms_for_name): Update.
8623         * jit.c (jit_find_objf_with_entry_addr): Update.
8624         * hppa-tdep.c (find_unwind_entry)
8625         (hppa_lookup_stub_minimal_symbol): Update.
8626         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8627         Update.
8628         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8629         (elf_gnu_ifunc_resolve_by_got): Update.
8630         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8631         * dwarf-index-write.c (save_gdb_index_command): Update.
8632         * cp-support.c (add_symbol_overload_list_qualified): Update.
8633         * breakpoint.c (create_overlay_event_breakpoint)
8634         (create_longjmp_master_breakpoint)
8635         (create_std_terminate_master_breakpoint)
8636         (create_exception_master_breakpoint): Update.
8637         * blockframe.c (find_pc_partial_function): Update.
8638         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8639         (ada_collect_symbol_completion_matches)
8640         (ada_add_global_exceptions): Update.
8641
8642 2019-01-17  Tom Tromey  <tom@tromey.com>
8643
8644         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8645         declare VEC.
8646         (solib_target_parse_libraries): Change return type.
8647         (library_list_start_segment, library_list_start_section)
8648         (library_list_end_library, library_list_start_library); Update.
8649         (solib_target_free_library_list): Remove.
8650         (solib_target_parse_libraries): Remove cleanup.  Change return
8651         type.
8652         (solib_target_current_sos): Update.
8653
8654 2019-01-17  Tom Tromey  <tromey@bapiya>
8655
8656         * valprint.c: Replace "the the" with "the".
8657         * symtab.c: Replace "the the" with "the".
8658         * solib.c: Replace "the the" with "the".
8659         * solib-dsbt.c: Replace "the the" with "the".
8660         * linespec.c: Replace "the the" with "the".
8661         * dwarf2loc.h: Replace "the the" with "the".
8662         * amd64-windows-tdep.c: Replace "the the" with "the".
8663         * aarch64-tdep.c: Replace "the the" with "the".
8664
8665 2019-01-16  Keith Seitz  <keiths@redhat.com>
8666
8667         PR gdb/23773
8668         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8669         <builder>: Rename to ..
8670         <m_builder>: ... this and make private.
8671         (dwarf2_cu::get_builder): New method.  Change all users of
8672         `builder' to use this method.
8673         (dwarf2_start_symtab): Move to ...
8674         (dwarf2_cu::start_symtab): ... here.  Update all callers
8675         (setup_type_unit_groups): Move to ...
8676         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8677         callers.
8678         (dwarf2_cu::reset_builder): New method.
8679         (process_full_compunit, process_full_type_unit): Use
8680         dwarf2_cu::reset_builder.
8681         (follow_die_offset): Record the ancestor CU if it is different
8682         from the followed DIE's CU.
8683         (follow_die_sig_1): Likewise.
8684
8685 2019-01-15  Tom Tromey  <tom@tromey.com>
8686
8687         * remote.c (class remote_state) <buf>: Now a char_vector.
8688         <buf_size>: Remove.
8689         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8690         parameter.
8691         (remote_target::getpkt_or_notif_sane_1)
8692         (remote_target::getpkt_sane)
8693         (remote_target::getpkt_or_notif_sane): Likewise.
8694         (class remote_target) <putpkt>: New overload.
8695         (remote_target::read_frame): Change type of "buf_p".  Remove
8696         sizeof_p parameter.
8697         (packet_ok): New overload.
8698         (packet_check_result): New overload.
8699         Update all uses.
8700
8701 2019-01-14  Tom Tromey  <tom@tromey.com>
8702
8703         * remote-notif.c (handle_notification, remote_notif_ack)
8704         (remote_notif_parse): Make "buf" const.
8705         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8706         const.
8707         (remote_notif_parse, remote_notif_ack, handle_notification):
8708         Likewise.
8709         * remote.c (remote_notif_stop_parse): Make "buf" const.
8710         (remote_target::remote_parse_stop_reply): Make "buf" const.
8711         (remote_notif_stop_ack): Make "buf" const.
8712
8713 2019-01-14  Tom Tromey  <tom@tromey.com>
8714
8715         * remote.c (remote_console_output): Make parameter const.
8716
8717 2019-01-14  Tom Tromey  <tom@tromey.com>
8718
8719         * target-debug.h (target_debug_print_signals): Constify.
8720         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8721         * procfs.c (procfs_target::pass_signals): Update.
8722         * linux-nat.c (linux_nat_target::pass_signals): Update.
8723         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8724         * target-delegates.c: Rebuild.
8725         * remote.c (remote_target::program_signals): Update.
8726         (remote_target::pass_signals): Update.
8727         * target.c (target_pass_signals): Constify argument.
8728         (target_program_signals): Likewise.
8729         * target.h (struct target_ops) <pass_signals, program_signals>:
8730         Constify argument.
8731         (target_pass_signals, target_program_signals): Constify argument.
8732
8733 2019-01-14  Tom Tromey  <tom@tromey.com>
8734
8735         PR tui/28819:
8736         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8737
8738 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8739
8740         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8741         field.
8742         * rs6000-tdep.c: Include reggroups.h.
8743         (IS_V_ALIAS_PSEUDOREG): Define.
8744         (rs6000_register_name): Return names for the "vX" aliases.
8745         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8746         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8747         aliases.  Call default_register_reggroup_p for all other
8748         pseudo-registers.
8749         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8750         New functions.
8751         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8752         Handle "vX" aliases.
8753         (v_alias_pseudo_register_collect): New function.
8754         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8755         (rs6000_gdbarch_init): Initialize "vX" aliases as
8756         pseudo-registers.  Restore registration of
8757         rs6000_pseudo_register_reggroup_p with
8758         set_tdesc_pseudo_register_reggroup_p.
8759
8760 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8761
8762         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8763         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8764         set_gdbarch_num_pseudo_regs.
8765
8766 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8767
8768         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8769         Remove arg prefixname, add do_set and do_show.
8770         Add member functions set_list and show_list.
8771         * cli/cli-style.c (class cli_style_option): Update accordingly.
8772         (style_set_list): Move to file scope.
8773         (style_show_list): Likewise.
8774         (set_style): Call help_list.
8775         (show_style): Call cmd_show_list.
8776         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8777         Update to use the new macro.
8778
8779 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8780
8781         * ada-lang.c (_initialize_ada_language): Expand the help text
8782         for the "catch exception" command.
8783
8784 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8785
8786         * symtab.c (matching_obj_sections): Initialize obj,
8787         declare it closer to its usage.
8788
8789 2019-01-10  Tom Tromey  <tom@tromey.com>
8790
8791         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8792         (basic_inf_threads_range): Remove.
8793         (inf_threads_range, inf_non_exited_threads_range)
8794         (safe_inf_threads_range): Use next_adapter.
8795
8796 2019-01-10  Keith Seitz  <keiths@redhat.com>
8797
8798         PR gdb/23712
8799         PR symtab/23010
8800         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8801         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8802
8803 2019-01-10  Keith Seitz  <keiths@redhat.com>
8804
8805         PR gdb/23712
8806         PR symtab/23010
8807         * dictionary.c (pending_to_vector): Remove.
8808         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8809         Remove _1 suffix, replacing functions of the same name.  Update
8810         all callers.
8811         (dict_create_hashed, dict_create_hashed_expandable)
8812         (dict_create_linear, dict_create_linear_expandable, dict_free)
8813         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8814         Make functions static.
8815
8816 2019-01-10  Keith Seitz  <keiths@redhat.com>
8817
8818         PR gdb/23712
8819         PR symtab/23010
8820         * dictionary.h (struct dictionary): Replace declaration with
8821         multidictionary.
8822         (dict_create_hashed, dict_create_hashed_expandable)
8823         (dict_create_linear, dict_create_linear_expandable)
8824         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8825         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8826         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8827         taking multidictionary argument.
8828         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8829         * block.h (struct block) <dict>: Change to multidictionary
8830         and rename `multidict'.
8831         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8832         symmisc.c: Update all dictionary references to multidictionary.
8833
8834 2019-01-10  Keith Seitz  <keiths@redhat.com>
8835
8836         PR gdb/23712
8837         PR symtab/23010
8838         * dictionary.c: Include unordered_map.
8839         (pending_to_vector): New function.
8840         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8841         Rewrite the non-"_1" functions to take vector instead
8842         of linked list.
8843         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8844         "new" _1 versions of the same name.
8845         (multidictionary): Define.
8846         (std::hash<enum language): New definition.
8847         (collate_pending_symbols_by_language, mdict_create_hashed)
8848         (mdict_create_hashed_expandable, mdict_create_linear)
8849         (mdict_create_linear_expandable, mdict_free)
8850         (find_language_dictionary, create_new_language_dictionary)
8851         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8852         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8853         (mdict_size, mdict_empty): New functions.
8854         * dictionary.h (mdict_iterator): Define.
8855
8856 2019-01-10  Pedro Alves  <palves@redhat.com>
8857
8858         * breakpoint.c (read_uploaded_action)
8859         (create_tracepoint_from_upload): Adjust to use
8860         gdb::unique_xmalloc_ptr.
8861         * ctf.c (ctf_write_uploaded_tp):
8862         (SET_ARRAY_FIELD): Use emplace_back.
8863         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8864         * tracefile-tfile.c (tfile_write_uploaded_tp):
8865         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8866         gdb::unique_xmalloc_ptr.
8867         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8868         at_string, cond_string, cmd_strings>: Replace char pointers
8869         with gdb::unique_xmalloc_ptr.
8870
8871 2019-01-10  Pedro Alves  <palves@redhat.com>
8872
8873         * solib-target.c (library_list_start_library): Don't xstrdup name.
8874
8875 2019-01-10  Pedro Alves  <palves@redhat.com>
8876
8877         * mdebugread.c (parse_partial_symbols): Use
8878         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8879
8880 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8881
8882         * linux-fork.c (scoped_switch_fork_info)
8883         <~scoped_switch_fork_info>: Fix incorrect variable name.
8884
8885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * linux-fork.c (scoped_switch_fork_info)
8888         <scoped_switch_fork_info>: Make explicit.
8889         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8890
8891 2019-01-10  Tom Tromey  <tom@tromey.com>
8892
8893         * objfiles.h (objfile::reset_psymtabs): Update.
8894         * objfiles.c (objfile::objfile): Update.
8895         * psymtab.h (psymtab_storage::obstack): Update.
8896         (psymtab_storage::m_obstack): Use gdb::optional.
8897         (class psymtab_storage): Update comment.  Remove objfile
8898         parameter.
8899         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8900
8901 2019-01-10  Tom Tromey  <tom@tromey.com>
8902
8903         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8904         <free_psymtabs>: Now private.
8905         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8906         (allocate_psymtab): Use new method.
8907
8908 2019-01-10  Tom Tromey  <tom@tromey.com>
8909
8910         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8911         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8912         * mdebugread.c (parse_partial_symbols): Use
8913         allocate_dependencies.
8914         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8915         allocate_dependencies.
8916         (process_psymtab_comp_unit_reader)
8917         (build_type_psymtab_dependencies): Likewise.
8918         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8919
8920 2019-01-10  Tom Tromey  <tom@tromey.com>
8921
8922         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8923         PSYMBOL_SET_LANGUAGE.
8924         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8925
8926 2019-01-10  Tom Tromey  <tom@tromey.com>
8927
8928         * psymtab.h (psymtab_storage::obstack): New method.
8929         <m_obstack>: Rename from obstack; now private.
8930         * psymtab.c (psymtab_storage): Update.
8931         * dwarf2read.c (create_addrmap_from_index)
8932         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8933         Update.
8934
8935 2019-01-10  Tom Tromey  <tom@tromey.com>
8936
8937         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8938         * objfiles.h (objfile::reset_psymtabs): New method.
8939
8940 2019-01-10  Tom Tromey  <tom@tromey.com>
8941
8942         * symmisc.c (print_symbol_bcache_statistics): Update.
8943         (print_objfile_statistics): Update.
8944         * symfile.c (reread_symbols): Update.
8945         * psymtab.h (class psymtab_storage): New.
8946         * psymtab.c (psymtab_storage): New constructor.
8947         (~psymtab_storage): New destructor.
8948         (require_partial_symbols): Update.
8949         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8950         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8951         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8952         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8953         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8954         (start_psymtab_common, end_psymtab_common)
8955         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8956         (allocate_psymtab): Update.
8957         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8958         Update.
8959         (dump_psymtab_addrmap, maintenance_print_psymbols)
8960         (maintenance_check_psymtabs): Update.
8961         (class objfile_psymtabs): Move to objfiles.h.
8962         * psympriv.h (discard_psymtab): Now inline.
8963         (psymtab_discarder::psymtab_discarder): Update.
8964         (psymtab_discarder::~psymtab_discarder): Update.
8965         (ALL_OBJFILE_PSYMTABS): Rewrite.
8966         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8967         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8968         Remove fields.
8969         <partial_symtabs>: New field.
8970         (class objfile_psymtabs): Move from psymtab.h.  Update.
8971         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8972         psymbol_cache.
8973         (objfile::~objfile): Don't destroy psymbol_cache.
8974         * mdebugread.c (parse_partial_symbols): Update.
8975         * dwarf2read.c (create_addrmap_from_index)
8976         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8977         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8978         (add_partial_subprogram, dwarf2_ranges_read): Update.
8979         * dwarf-index-write.c (write_address_map)
8980         (write_one_signatured_type, recursively_write_psymbols)
8981         (class debug_names, class debug_names, write_psymtabs_to_index):
8982         Update.
8983
8984 2019-01-10  Tom Tromey  <tom@tromey.com>
8985
8986         * symtab.h (SYMBOL_SET_NAMES): Update.
8987         (symbol_set_names): Update.
8988         (MSYMBOL_SET_NAMES): Update.
8989         * symtab.c (symbol_set_names): Change argument to be an
8990         objfile_per_bfd_storage.
8991         * psymtab.c (add_psymbol_to_bcache): Update.
8992         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8993
8994 2019-01-10  Tom Tromey  <tom@tromey.com>
8995
8996         * symtab.c (create_demangled_names_hash): Change argument to be an
8997         objfile_per_bfd_storage.
8998         (symbol_set_names): Update.
8999
9000 2019-01-10  Tom Tromey  <tom@tromey.com>
9001
9002         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9003         init_psymbol_list.
9004         * psymtab.c (init_psymbol_list): Do nothing if already called.
9005         * psympriv.h (init_psymbol_list): Add comment.
9006         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9007         init_psymbol_list.
9008         * dbxread.c (dbx_symfile_read): Unconditionally call
9009         init_psymbol_list.
9010
9011 2019-01-10  Tom Tromey  <tom@tromey.com>
9012
9013         * xcoffread.c (scan_xcoff_symtab): Update.
9014         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9015         "where".
9016         * mdebugread.c (parse_partial_symbols)
9017         (handle_psymbol_enumerators): Update.
9018         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9019         * dbxread.c (read_dbx_symtab): Update.
9020         * psympriv.h (psymbol_placement): New enum.
9021         (add_psymbol_to_list): Update.
9022
9023 2019-01-10  Tom Tromey  <tom@tromey.com>
9024
9025         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9026         static_psymbols parameters.
9027         (scan_xcoff_symtab): Update.
9028         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9029         static_psymbols parameters.
9030         * psympriv.h (start_psymtab_common): Update.
9031         * mdebugread.c (parse_partial_symbols): Update.
9032         * dwarf2read.c (create_partial_symtab): Update.
9033         * dbxread.c (read_dbx_symtab): Update.
9034         (start_psymtab): Remove global_psymbols and static_psymbols
9035         parameters.
9036
9037 2019-01-10  Tom Tromey  <tom@tromey.com>
9038
9039         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9040         * psymtab.c (allocate_psymtab): Add comment.
9041         * psympriv.h (allocate_psymtab): Add comment.
9042         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9043         initializations.
9044         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9045
9046 2019-01-10  Tom Tromey  <tom@tromey.com>
9047
9048         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9049         Don't declare.
9050         * mipsread.c: Include mdebugread.h.
9051         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9052         Declare.
9053         * elfread.c: Include mdebugread.h.
9054
9055 2019-01-09  Tom Tromey  <tom@tromey.com>
9056
9057         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9058         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9059         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9060         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9061         (psym_lookup_symbol, psym_find_last_source_symtab)
9062         (psym_forget_cached_source_info, psym_print_stats)
9063         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9064         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9065         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9066         (psym_find_compunit_symtab_by_address)
9067         (maintenance_print_psymbols, maintenance_info_psymtabs)
9068         (maintenance_check_psymtabs): Use ranged for.
9069         * psymtab.h (class objfile_psymtabs): New.
9070         (require_partial_symbols): Return objfile_psymtabs.
9071         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9072
9073 2019-01-09  Tom Tromey  <tom@tromey.com>
9074
9075         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9076         (find_pc_mapped_section, list_overlays_command)
9077         (map_overlay_command, unmap_overlay_command)
9078         (simple_overlay_update): Use all_objfiles.
9079         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9080         * printcmd.c (info_symbol_command): Use all_objfiles.
9081         * objfiles.h (ALL_OBJSECTIONS): Remove.
9082         * maint.c (maintenance_translate_address): Use all_objfiles.
9083         * gcore.c (gcore_create_callback): Use all_objfiles.
9084         (objfile_find_memory_regions): Likewise.
9085
9086 2019-01-09  Tom Tromey  <tom@tromey.com>
9087
9088         * symtab.c (find_line_symtab, info_sources_command)
9089         (make_source_files_completion_list): Use objfile_compunits.
9090         * source.c (select_source_symtab): Use objfile_compunits.
9091         * objfiles.h (struct objfile): Update comment.
9092         (ALL_OBJFILES): Remove.
9093         (ALL_FILETABS): Remove.
9094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9095         objfile_compunits.
9096
9097 2019-01-09  Tom Tromey  <tom@tromey.com>
9098
9099         * symmisc.c (print_objfile_statistics, dump_objfile)
9100         (maintenance_print_symbols): Use compunit_filetabs.
9101         * source.c (forget_cached_source_info_for_objfile): Use
9102         compunit_filetabs.
9103         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9104         (ALL_FILETABS): Use compunit_filetabs.
9105         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9106         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9107
9108 2019-01-09  Tom Tromey  <tom@tromey.com>
9109
9110         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9111         (compunit_filetabs): New.
9112         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9113         compunit_filetabs.
9114         (info_sources_command, make_source_files_completion_list): Remove
9115         declaration.
9116         * symmisc.c (print_objfile_statistics, dump_objfile)
9117         (maintenance_print_symbols): Remove declaration.
9118         (maintenance_info_symtabs): Use compunit_filetabs.
9119         (maintenance_info_line_tables): Likewise.
9120         * source.c (select_source_symtab): Change local variable name.
9121         (forget_cached_source_info_for_objfile): Remove declaration.
9122         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9123         * objfiles.c (objfile_relocate1): Remove declaration.
9124         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9125         declaration.
9126         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9127         * coffread.c (coff_symtab_read): Remove declaration.
9128         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9129         compunit_filetabs.
9130
9131 2019-01-09  Tom Tromey  <tom@tromey.com>
9132
9133         * symtab.c (lookup_objfile_from_block)
9134         (find_pc_sect_compunit_symtab, search_symbols)
9135         (default_collect_symbol_completion_matches_break_on): Use
9136         objfile_compunits.
9137         * objfiles.h (ALL_COMPUNITS): Remove.
9138         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9139         * cp-support.c (add_symbol_overload_list_qualified): Use
9140         objfile_compunits.
9141         * ada-lang.c (ada_collect_symbol_completion_matches)
9142         (ada_add_global_exceptions): Use objfile_compunits.
9143
9144 2019-01-09  Tom Tromey  <tom@tromey.com>
9145
9146         * source.c (select_source_symtab)
9147         (forget_cached_source_info_for_objfile): Remove declaration.
9148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9149         declaration.
9150         * maint.c (count_symtabs_and_blocks): Remove declaration.
9151         * cp-support.c (add_symbol_overload_list_qualified): Remove
9152         declaration.
9153         * coffread.c (coff_symtab_read): Remove declaration.
9154         * symtab.c (lookup_symbol_in_objfile_symtabs)
9155         (basic_lookup_transparent_type_1): Use objfile_compunits.
9156         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9157         (info_sources_command, search_symbols)
9158         (default_collect_symbol_completion_matches_break_on)
9159         (make_source_files_completion_list): Remove declaration.
9160         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9161         (ada_collect_symbol_completion_matches)
9162         (ada_add_global_exceptions): Remove declaration.
9163         * linespec.c (iterate_over_all_matching_symtabs): Use
9164         objfile_compunits.
9165         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9166         (class objfile_compunits): New.
9167         (ALL_COMPUNITS): Use objfile_compunits.
9168         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9169         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9170         objfile_compunits.
9171         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9172
9173 2019-01-09  Tom Tromey  <tom@tromey.com>
9174
9175         * symtab.c (search_symbols)
9176         (default_collect_symbol_completion_matches_break_on): Use
9177         objfile_msymbols.
9178         * ada-lang.c (ada_lookup_simple_minsym)
9179         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9180         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9181         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9182         objfile_msymbols.
9183         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9184         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9185         * objc-lang.c (find_methods): Use objfile_msymbols.
9186         (info_selectors_command, info_classes_command): Likewise.
9187         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9188         * objfiles.h (class objfile_msymbols): New.
9189         (ALL_OBJFILE_MSYMBOLS): Remove.
9190         (ALL_MSYMBOLS): Remove.
9191
9192 2019-01-09  Tom Tromey  <tom@tromey.com>
9193
9194         * common/next-iterator.h (next_adapter): Add Iterator template
9195         parameter.
9196         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9197         (class all_objfiles_safe): New.
9198         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9199         * objfiles.c (put_objfile_before): Update comment.
9200         (add_separate_debug_objfile): Likewise.
9201         (free_all_objfiles): Use all_objfiles_safe.
9202         (objfile_purge_solibs): Likewise.
9203
9204 2019-01-09  Tom Tromey  <tom@tromey.com>
9205
9206         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9207         (expand_symtab_containing_pc, lookup_static_symbol)
9208         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9209         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9210         all_objfiles.
9211         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9212         * breakpoint.c (create_overlay_event_breakpoint)
9213         (create_longjmp_master_breakpoint)
9214         (create_std_terminate_master_breakpoint)
9215         (create_exception_master_breakpoint): Use all_objfiles.
9216         * linux-thread-db.c (try_thread_db_load_from_pdir)
9217         (has_libpthread): Use all_objfiles.
9218         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9219         * linespec.c (iterate_over_all_matching_symtabs)
9220         (search_minsyms_for_name): Use all_objfiles.
9221         * maint.c (maintenance_info_sections): Use all_objfiles.
9222         * main.c (captured_main_1): Use all_objfiles.
9223         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9224         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9225         * guile/scm-pretty-print.c
9226         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9227         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9228         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9229         (maintenance_print_msymbols): Use all_objfiles.
9230         * source.c (select_source_symtab): Use all_objfiles.
9231         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9232         * symfile.c (remove_symbol_file_command)
9233         (expand_symtabs_matching, map_symbol_filenames): Use
9234         all_objfiles.
9235         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9236         all_objfiles.
9237         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9238         * objc-lang.c (find_methods): Use all_objfiles.
9239         * objfiles.c (have_partial_symbols, have_full_symbols)
9240         (have_minimal_symbols, qsort_cmp)
9241         (default_iterate_over_objfiles_in_search_order): Use
9242         all_objfiles.
9243         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9244         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9245         (maintenance_check_psymtabs): Use all_objfiles.
9246         (ALL_PSYMTABS): Remove.
9247         * compile/compile-object-run.c (do_module_cleanup): Use
9248         all_objfiles.
9249         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9250         * cp-support.c (add_symbol_overload_list_qualified): Use
9251         all_objfiles.
9252         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9253         Use all_objfiles.
9254         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9255         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9256         all_objfiles.
9257         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9258         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9259         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9260         Uses all_objfiles.
9261         * solib.c (solib_read_symbols): Use all_objfiles
9262
9263 2019-01-09  Tom Tromey  <tom@tromey.com>
9264
9265         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9266         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9267         all_objfiles.
9268         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9269         * symmisc.c (print_symbol_bcache_statistics)
9270         (print_objfile_statistics, maintenance_print_objfiles)
9271         (maintenance_info_symtabs, maintenance_check_symtabs)
9272         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9273         all_objfiles.
9274         * source.c (forget_cached_source_info): Use all_objfiles.
9275         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9276         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9277         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9278         * objfiles.c (update_section_map): Use all_objfiles.
9279         (shared_objfile_contains_address_p): Likewise.
9280         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9281         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9282
9283 2019-01-09  Tom Tromey  <tom@tromey.com>
9284
9285         * common/next-iterator.h: New file.
9286         * objfiles.h (class all_objfiles): New.
9287         (struct objfile_iterator): New.
9288
9289 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9290
9291         * NEWS: Move the description of the changed "frame", "select-frame",
9292          and "info frame" commands to the Changed commands section.
9293
9294 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9295
9296         * gdbtypes.c (check_stub_method_group): Remove handling of old
9297         mangling schemes.
9298         * linespec.c (find_methods): Likewise.
9299         * stabsread.c (read_member_functions): Likewise.
9300         * valops.c (search_struct_method): Likewise.
9301         (value_struct_elt_for_reference): Likewise.
9302         * NEWS: Mention this change.
9303
9304 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9307         print_source_lines.
9308         * source.c (print_source_lines_base): Update line number check.
9309         (print_source_lines): New function.
9310         (source_lines_range::source_lines_range): New function.
9311         * source.h (class source_lines_range): New class.
9312         (print_source_lines): New declaration.
9313
9314 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9315
9316         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9317
9318 2019-01-08  Tom Tromey  <tom@tromey.com>
9319             Simon Marchi  <simon.marchi@ericsson.com>
9320
9321         PR gdb/24060
9322         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9323         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9324         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9325         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9326         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9327         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9328
9329 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9330
9331         * source.c (select_source_symtab): Move header comment to
9332         declaration in source.h.
9333         (forget_cached_source_info_for_objfile): Likewise.
9334         (forget_cached_source_info): Likewise.
9335         (identify_source_line): Likewise.
9336         * source.h (identify_source_line): Move declaration from symtab.h
9337         and add comment from source.c
9338         (print_source_lines): Likewise.
9339         (forget_cached_source_info_for_objfile): Likewise.
9340         (forget_cached_source_info): Likewise.
9341         (select_source_symtab): Likewise.
9342         (enum print_source_lines_flag): Move definition from symtab.h.
9343         * symtab.h (identify_source_line): Move declaration to source.h.
9344         (print_source_lines): Likewise.
9345         (forget_cached_source_info_for_objfile): Likewise.
9346         (forget_cached_source_info): Likewise.
9347         (select_source_symtab): Likewise.
9348         (enum print_source_lines_flag): Move definition to source.h.
9349         * tui/tui-hooks.c: Add 'source.h' include.
9350
9351 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9352
9353         * source.c (print_source_lines_base): Handle requests to print
9354         reverse line number sequences, and guard against empty lines
9355         string.
9356
9357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * source.c (print_source_lines_base): Fix skip of '\r' if next
9360         character is '\n'.
9361
9362 2019-01-06  Tom Tromey  <tom@tromey.com>
9363
9364         * c-exp.y (struct c_parse_state) <macro_original_text,
9365         expansion_obstack>: New member.
9366         (macro_original_text, expansion_obstack): Remove globals.
9367         (scan_macro_expansion, scanning_macro_expansion)
9368         (finished_macro_expansion): Update.
9369         (scan_macro_cleanup): Remove.
9370         (yylex, c_parse): Update.
9371
9372 2019-01-06  Tom Tromey  <tom@tromey.com>
9373
9374         * c-exp.y (struct c_parse_state) <strings>: New member.
9375         (operator_stoken): Update.
9376
9377 2019-01-06  Tom Tromey  <tom@tromey.com>
9378
9379         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9380         (union type_stack_elt) <typelist_val>: Now a pointer to
9381         std::vector.
9382         (type_stack_cleanup): Don't declare.
9383         (push_typelist): Update.
9384         * parse.c (pop_typelist): Return a std::vector.
9385         (push_typelist): Take a std::vector.
9386         (follow_types): Update.  Do not free args.
9387         (type_stack_cleanup): Remove.
9388         * c-exp.y (struct c_parse_state): New.
9389         (cpstate): New global.
9390         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9391         (nonempty_typelist): Update.
9392         (func_mod): Create a new vector.
9393         (c_parse): Create a c_parse_state.
9394         (check_parameter_typelist): Do not delete params.
9395         (function_method): Update.  Do not delete type_list.
9396
9397 2019-01-06  Tom Tromey  <tom@tromey.com>
9398
9399         PR gdb/28155:
9400         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9401         check_typedef.
9402         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9403         (print_return_value): Likewise.
9404
9405 2019-01-05  Tom Tromey  <tom@tromey.com>
9406
9407         * contrib/cleanup_check.py: Remove.
9408         * contrib/gcc-with-excheck: Remove.
9409         * contrib/exsummary.py: Remove.
9410         * contrib/excheck.py: Remove.
9411
9412 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9413
9414         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9415         NULL. Initialize tpprev to NULL instead of assigning it
9416         to NULL on the next statement.
9417         * windows-nat.c (windows_delete_thread): Remove check for
9418         main_thread_id before printing thread exit notifications.
9419         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9420         Remove thread ID check against main_thread_id.
9421         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9422         windows_delete_thread.
9423         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9424
9425 2019-01-04  Tom Tromey  <tom@tromey.com>
9426
9427         * compile/compile.c (_initialize_compile): Use upper case for
9428         metasyntactic variables.
9429         * symmisc.c (_initialize_symmisc): Use upper case for
9430         metasyntactic variables.
9431         * psymtab.c (_initialize_psymtab): Use upper case for
9432         metasyntactic variables.
9433         * demangle.c (demangle_command): Use upper case for metasyntactic
9434         variables.
9435         (_initialize_demangler): Likewise.
9436         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9437         variables.
9438
9439 2019-01-03  Tom Tromey  <tom@tromey.com>
9440
9441         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9442
9443 2019-01-03  Tom Tromey  <tom@tromey.com>
9444
9445         * python/py-symtab.c (salpy_str): Update.
9446         (struct salpy_sal_object) <symtab>: Now a PyObject.
9447         (salpy_dealloc): Update.
9448         (del_objfile_sal): Use gdbpy_ref.
9449
9450 2019-01-03  Tom Tromey  <tom@tromey.com>
9451
9452         * python/py-type.c (convert_field): Use new_reference.  Return
9453         gdbpy_ref.
9454         (make_fielditem): Return gdbpy_ref.
9455         (typy_fields): Update.
9456         (typy_getitem): Update.
9457         (field_name): Return gdbpy_ref.  Use new_reference.
9458         (typy_iterator_iternext): Update.
9459
9460 2019-01-03  Tom Tromey  <tom@tromey.com>
9461
9462         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9463
9464 2019-01-03  Tom Tromey  <tom@tromey.com>
9465
9466         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9467         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9468         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9469         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9470         (pspy_set_type_printers): Likewise.
9471         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9472         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9473         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9474         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9475         (objfpy_set_type_printers): Likewise.
9476
9477 2019-01-03  Tom Tromey  <tom@tromey.com>
9478
9479         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9480         (gdbpy_print_stack): Use gdbpy_err_fetch.
9481         * python/python-internal.h (class gdbpy_err_fetch): New class.
9482         (class gdbpy_enter) <m_error_type, m_error_value,
9483         m_error_traceback>: Remove.
9484         <m_error>: New member.
9485         (gdbpy_exception_to_string): Don't declare.
9486         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9487         * python/py-value.c (convert_value_from_python): Use
9488         gdbpy_err_fetch.
9489         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9490         gdbpy_exception_to_string.
9491         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9492         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9493         gdbpy_err_fetch.
9494
9495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9496
9497         * linux-nat.c (delete_lwp_cleanup): Delete.
9498         (struct lwp_deleter): New struct.
9499         (lwp_info_up): New typedef.
9500         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9501         lwp_info_up.
9502
9503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9504
9505         * linux-fork.c (class scoped_switch_fork_info): New class.
9506         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9507
9508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9509
9510         * valops.c (find_overload_match): Remove use of null_cleanup, and
9511         calls to do_cleanups.
9512
9513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * compile/compile-cplus-types.c
9516         (compile_cplus_instance::decl_name): Handle changes to
9517         cp_func_name.
9518         * cp-support.c (cp_func_name): Update header comment, update
9519         return type.
9520         * cp-support.h (cp_func_name): Update return type in declaration.
9521         * valops.c (find_overload_match): Move temp_func local to top
9522         level of function and change its type.  Use temp_func to hold and
9523         delete temporary string obtained from cp_func_name.
9524
9525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9526
9527         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9528         gdb::char_vector, remove cleanup, and update uses of `msg`.
9529
9530 2019-01-03  Jim Wilson  <jimw@sifive.com>
9531
9532         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9533
9534 2019-01-02  Tom Tromey  <tom@tromey.com>
9535
9536         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9537         (tdesc_parse_xml): Remove cleanups.
9538         * target-descriptions.h (make_cleanup_free_target_description):
9539         Don't declare.
9540         (target_desc_deleter): New struct.
9541         (target_desc_up): New typedef.
9542         * target-descriptions.c (target_desc_deleter::operator()): Rename
9543         from free_target_description.
9544         (make_cleanup_free_target_description): Remove.
9545
9546 2019-01-02  Tom Tromey  <tom@tromey.com>
9547
9548         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9549         constructor, destructor.
9550         (linespec_parser): Remove typedef.
9551         (~linespec_parser): Rename from linespec_parser_delete.
9552         (linespec_lex_to_end, linespec_complete_label)
9553         (linespec_complete): Update.
9554         (decode_line_full): Remove cleanups.
9555         (decode_line_1): Update.
9556
9557 2019-01-02  Tom Tromey  <tom@tromey.com>
9558
9559         * python/python-internal.h (inferior_to_inferior_object): Change
9560         return type.
9561         * python/py-exitedevent.c (create_exited_event_object): Update.
9562         * python/py-inferior.c (inferior_to_inferior_object): Return
9563         gdbpy_ref.
9564         (python_new_inferior, python_inferior_deleted)
9565         (thread_to_thread_object, delete_thread_object)
9566         (build_inferior_list, gdbpy_selected_inferior): Update.
9567         * python/py-infthread.c (create_thread_object): Update.  Also fail
9568         if inferior_to_inferior_object fails.
9569
9570 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9571
9572         * inferior.h (class inferior) <displaced_step_state>: New field.
9573         * infrun.h (struct displaced_step_state): Move here from
9574         infrun.c.  Initialize fields, add constructor.
9575         <inf>: Remove field.
9576         <reset>: New method.
9577         * infrun.c (struct displaced_step_inferior_state): Move to
9578         infrun.h.
9579         (displaced_step_inferior_states): Remove.
9580         (get_displaced_stepping_state): Adust.
9581         (displaced_step_in_progress_any_inferior): Adjust.
9582         (displaced_step_in_progress_thread): Adjust.
9583         (displaced_step_in_progress): Adjust.
9584         (add_displaced_stepping_state): Remove.
9585         (get_displaced_step_closure_by_addr): Adjust.
9586         (remove_displaced_stepping_state): Remove.
9587         (infrun_inferior_exit): Call displaced_step_state.reset.
9588         (use_displaced_stepping): Don't check for NULL.
9589         (displaced_step_prepare_throw): Call
9590         get_displaced_stepping_state.
9591         (displaced_step_fixup): Don't check for NULL.
9592         (prepare_for_detach): Don't check for NULL.
9593
9594 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9595
9596         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9597          in case of call that did not complete.
9598
9599 2019-01-02  Andrey Utkin  <autkin@undo.io>
9600
9601         * symfile.c (find_separate_debug_file): Fix search of debug files for
9602         remote debuggee.
9603
9604 2019-01-02  Tom Tromey  <tom@tromey.com>
9605
9606         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9607         indentation.
9608         * python/py-frame.c (frapy_older): Remove cast.
9609         (frapy_newer): Likewise.
9610         * python/py-breakpoint.c (local_setattro): Remove cast.
9611         * python/py-arch.c (archpy_name): Remove local variable.
9612         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9613
9614 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9615
9616         * unittests/basic_string_view/element_access/char/empty.cc:
9617         Fix year range in copyright header.
9618
9619 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9620
9621         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9622         Delete.
9623         <operator==>: Update with for removed field.
9624         <hash>: Likewise.
9625         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9626         <isa_features>: ...this.
9627         <abi_features>: New field.
9628         (riscv_isa_flen): Update comment.
9629         (riscv_abi_xlen): New declaration.
9630         (riscv_abi_flen): New declaration.
9631         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9632         isa_features.
9633         (riscv_abi_xlen): New function.
9634         (riscv_isa_flen): Update to get answer from isa_features.
9635         (riscv_abi_flen): New function.
9636         (riscv_has_fp_abi): Update to get answer from abi_features.
9637         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9638         xlen and flen.
9639         (riscv_call_info) <xlen, flen>: Update comment.
9640         (riscv_call_arg_struct): Remove invalid assertions
9641         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9642         is removed.
9643         (riscv_gdbarch_init): Gather isa features and abi features
9644         separately, ensure both match on the gdbarch when reusing an old
9645         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9646         a target with 64-bit float hardware.
9647
9648 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9649
9650         * source.c (search_command_helper): Stop reverse search
9651         when line 1 has been searched.
9652
9653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9654
9655         * record-full.c (record_full_base_target::close): Rewrite
9656         record_full_core_buf_list free logic.
9657
9658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9659
9660         * break-catch-syscall.c (print_one_catch_syscall): xfree
9661         the last text.
9662
9663 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9664
9665         * top.c (print_gdb_version): Update Copyright year in version
9666         message.
9667
9668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9669
9670         Update copyright year range in all GDB files.
9671
9672 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9673
9674         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9675
9676 For older changes see ChangeLog-2018.
9677 \f
9678 Local Variables:
9679 mode: change-log
9680 left-margin: 8
9681 fill-column: 74
9682 version-control: never
9683 coding: utf-8
9684 End:
9685