gdb/ChangeLog

   1 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
   4         instruction to the dummy code region.
   5
   6 2019-07-19  Tom Tromey  <tromey@adacore.com>
   7
   8         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
   9         (ARGSUSED, PARAMS, __func__): Remove rules.
  10
  11 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  12
  13         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  14         * features/arm/arm-with-iwmmxt.c: Remove.
  15         * features/arm/arm-with-iwmmxt.xml: Remove.
  16         * features/arm/arm-with-m-fpa-layout.c: Remove.
  17         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  18         * features/arm/arm-with-m-vfp-d16.c: Remove.
  19         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  20         * features/arm/arm-with-m.c: Remove.
  21         * features/arm/arm-with-m.xml: Remove.
  22         * features/arm/arm-with-neon.c: Remove.
  23         * features/arm/arm-with-neon.xml: Remove.
  24         * features/arm/arm-with-vfpv2.c: Remove.
  25         * features/arm/arm-with-vfpv2.xml: Remove.
  26         * features/arm/arm-with-vfpv3.c: Remove.
  27         * features/arm/arm-with-vfpv3.xml: Remove.
  28
  29 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  30
  31         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  32
  33 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  34
  35         * arch/aarch32.c (aarch32_create_target_description): Create
  36         target descriptions using features.
  37         * arch/arm.c (arm_create_target_description)
  38         (arm_create_mprofile_target_description): Likewise.
  39         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  40
  41 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  42
  43         * Makefile.in: Add new files.
  44         * aarch32-tdep.c: New file.
  45         * aarch32-tdep.h: New file.
  46         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  47         Call aarch32_read_description.
  48         * arch/aarch32.c: New file.
  49         * arch/aarch32.h: New file.
  50         * arch/arm.c (arm_create_target_description)
  51         (arm_create_mprofile_target_description): New function.
  52         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  53         (arm_create_target_description)
  54         (arm_create_mprofile_target_description): New declaration.
  55         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  56         read_description functions.
  57         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  58         Likewise.
  59         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  60         * arm-tdep.c (tdesc_arm_list): New variable.
  61         (arm_register_g_packet_guesses): Call create description functions.
  62         (arm_read_description) (arm_read_mprofile_description): New
  63         function.
  64         * arm-tdep.h (arm_read_description)
  65         (arm_read_mprofile_description): Add declaration.
  66         * configure.tgt: Add new files.
  67
  68 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  69
  70         * top.c (new_ui_command): Open specified terminal just once.
  71
  72 2019-07-18  Tom Tromey  <tromey@adacore.com>
  73
  74         * symtab.c (main_name): Constify return type.
  75         * symfile.c (set_initial_language): Update.
  76         * symtab.h (main_name): Constify return type.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-winsource.c (tui_update_source_window)
  81         (tui_update_source_window_as_is)
  82         (tui_update_source_windows_with_line): Remove return.
  83         * tui/tui-disasm.c (tui_show_disassem)
  84         (tui_show_disassem_and_update_source): Remove return.
  85         * tui/tui.c (tui_reset): Remove return.
  86         * tui/tui-wingeneral.c
  87         (tui_check_and_display_highlight_if_needed): Remove return.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-winsource.h (struct tui_exec_info_window)
  96         (struct tui_source_window_base): Move from tui-data.h.
  97         * tui/tui-winsource.c: Move many method definitions from
  98         elsewhere.  Remove "structuring" comments.
  99         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 100         (tui_source_window_base::refresh_window): Move to
 101         tui-winsource.c.
 102         * tui/tui-win.c (tui_source_window_base::refresh_all)
 103         (tui_source_window_base::update_tab_width)
 104         (tui_source_window_base::set_new_height)
 105         (tui_source_window_base::do_make_visible_with_new_height): Move to
 106         tui-winsource.c.
 107         * tui/tui-source.h: Update.
 108         * tui/tui-source.c (tui_source_window_base::reset): Move to
 109         tui-winsource.c.
 110         * tui/tui-disasm.h: Update.
 111         * tui/tui-data.h (struct tui_exec_info_window): Move to
 112         tui-winsource.h.
 113         (struct tui_source_window_base): Likewise.
 114         * tui/tui-data.c (tui_source_window_base::clear_detail)
 115         (tui_source_window_base, ~tui_source_window_base): Move to
 116         tui-winsource.c.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-win.c (tui_resize_all)
 121         (tui_source_window_base::update_tab_width)
 122         (tui_adjust_win_heights): Update.
 123         (tui_win_info::make_invisible_and_set_new_height): Rename from
 124         make_invisible_and_set_new_height.
 125         * tui/tui-data.h (struct tui_win_info)
 126         <make_invisible_and_set_new_height>: New method.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui.c: Update.
 131         * tui/tui-source.h (struct tui_source_window): Move from
 132         tui-data.h.
 133         * tui/tui-layout.c: Update.
 134         * tui/tui-disasm.c: Update.
 135         * tui/tui-data.h (struct tui_source_window): Move to
 136         tui-source.h.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 141         tui-data.h.
 142         * tui/tui-data.h (struct tui_disasm_window): Move to
 143         tui-disasm.h.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-regs.h (struct tui_data_item_window): Move from
 148         tui-data.h.
 149         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 150         * tui/tui-data.h (struct tui_data_item_window): Move to
 151         tui-regs.h.
 152         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui.c: Update.
 157         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 158         (tui_cmd_window::max_height): Move to tui-command.c.
 159         * tui/tui-layout.c: Update.
 160         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 161         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 162         tui-command.c.
 163         * tui/tui-command.h (struct tui_cmd_window): Move from
 164         tui-data.h.
 165         * tui/tui-command.c: Remove "structuring" comments.
 166         (tui_cmd_window::clear_detail)
 167         (tui_cmd_window::do_make_visible_with_new_height)
 168         (tui_cmd_window::max_height): Move from elsewhere.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 173         Now static.
 174         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 175         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui.c: Update.
 180         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 181         tui-regs.c.
 182         * tui/tui-windata.h: Remove file.
 183         * tui/tui-windata.c: Remove file.
 184         * tui/tui-win.c (tui_data_window::set_new_height)
 185         (tui_data_window::do_make_visible_with_new_height): Move to
 186         tui-regs.c.
 187         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 188         * tui/tui-regs.c: Remove "structuring" comments.
 189         (tui_data_window::first_data_item_displayed)
 190         (tui_data_window::delete_data_content_windows)
 191         (tui_data_window::erase_data_content)
 192         (tui_data_window::display_all_data)
 193         (tui_data_window::refresh_all)
 194         (tui_data_window::do_scroll_vertical)
 195         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 196         (tui_data_window::do_make_visible_with_new_height)
 197         (tui_data_window::refresh_window): Move from elsewhere.
 198         (_initialize_tui_regs): Move to end of file.
 199         * tui/tui-layout.c: Update.
 200         * tui/tui-hooks.c: Update.
 201         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 202         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 203         tui-regs.c.
 204         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 205
 206 2019-07-17  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 209         seen.
 210
 211 2019-07-17  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-win.c (tui_source_window_base::set_new_height)
 214         (tui_source_window_base::do_make_visible_with_new_height): Use
 215         m_has_locator field directly.
 216         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 217         method.
 218         (struct tui_source_window_base) <has_locator>: Likewise.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 223         Don't declare.
 224         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 225         Remove.
 226         * tui/tui-win.c (tui_source_window_base::set_new_height)
 227         (tui_source_window_base::set_new_height)
 228         (make_invisible_and_set_new_height)
 229         (tui_source_window_base::do_make_visible_with_new_height)
 230         (tui_source_window_base::do_make_visible_with_new_height):
 231         Update.
 232         * tui/tui-layout.c (show_source_disasm_command, show_data)
 233         (show_source_or_disasm_and_command): Update.
 234         * tui/tui-layout.c (show_layout): Update.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-layout.c (make_data_window): Remove.
 239         (show_data): Unify creation and re-initialization cases.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-layout.c (make_source_window, make_disasm_window):
 244         Remove.
 245         (show_data): Unify creation and re-initialization cases.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-layout.c (make_command_window): Remove.
 250         (show_source_disasm_command, show_source_or_disasm_and_command):
 251         Unify creation and re-initialization cases.
 252
 253 2019-07-17  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 256         creation and re-initialization cases.
 257
 258 2019-07-17  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-regs.c (tui_get_register): Return void.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 265         Simplify.
 266
 267 2019-07-17  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 270         resetting.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 275         * tui/tui-regs.c (tui_reg_layout): New function.
 276         (tui_show_registers, tui_reg_command): Use it.
 277         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 278         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 279         parameters.
 280         (tui_layout_command): Remove.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-layout.h (tui/tui-layout): Return void.
 285         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 286
 287 2019-07-17  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-layout.c (show_source_disasm_command, show_data):
 290         Update.
 291         (reset_locator): Remove.
 292         (show_source_or_disasm_and_command): Update.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-source.c (tui_source_window_base::reset): Remove
 297         win_type parameter.
 298         * tui/tui-layout.c (make_command_window, make_source_window)
 299         (make_disasm_window, make_data_window)
 300         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 301         (reset_locator, show_source_or_disasm_and_command): Update.
 302         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 303         win_type parameter.
 304         (struct tui_source_window_base) <reset>: Likewise.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-layout.c (show_source_disasm_command): Use
 309         reset_locator.
 310         (reset_locator): New function.
 311         (init_and_make_win): Remove.
 312         (show_source_or_disasm_and_command): Use reset_locator.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 317         condition.
 318         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 319         Remove condition.
 320         * tui/tui-source.c (tui_source_window_base::reset): New method.
 321         * tui/tui-layout.c (make_command_window): Don't call
 322         init_and_make_win.
 323         (make_source_window, make_disasm_window): Don't call
 324         make_source_or_disasm_window.
 325         (make_data_window): Don't call init_and_make_win.  Change calling
 326         convention.
 327         (show_source_disasm_command, show_data): Simplify.
 328         (make_source_or_disasm_window): Remove.
 329         (show_source_or_disasm_and_command): Simplify.
 330         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 331         (struct tui_source_window_base) <reset>: Likewise.
 332         <execution_info>: Remove initializer.
 333         * tui/tui-data.c (tui_source_window_base): Initialize
 334         execution_info.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 339         variable.
 340
 341 2019-07-17  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui.c (tui_rl_other_window): Update.
 344         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 345         superclass method first.  Always iterate over regs_content.
 346         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 347         method.
 348         * tui/tui-win.c (tui_set_focus_command): Update.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-win.c (tui_set_focus_command): Rename from
 353         tui_set_focus.  Call tui_enable.
 354         (tui_set_focus_command): Remove.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 359         refresh_window.
 360         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 361         touchwin.
 362         (tui_data_window::refresh_window): Call refresh_window on data
 363         items.  Always call superclass refresh_window.
 364         (tui_win_info::refresh): Remove.
 365         (tui_source_window_base::refresh_window): Update.
 366         (tui_refresh_all): Update.
 367         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 368         refresh_window.
 369         (show_source_or_disasm_and_command): Likewise.
 370         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 371         (struct tui_source_window_base) <refresh>: Likewise.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-winsource.c (tui_clear_source_content)
 376         (tui_show_source_content): Update.
 377         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 378         whether content is empty.
 379         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 380         Remove.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 385         window's contents.
 386         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 387         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 388
 389 2019-07-17  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 392         (struct tui_data_item_window): Update.
 393
 394 2019-07-17  Tom Tromey  <tom@tromey.com>
 395
 396         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 397         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 398         defines.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.h (tui_erase_source_content)
 403         (tui_clear_source_content): Remove "display_prompt" parameter.
 404         * tui/tui-winsource.c (tui_update_source_window_as_is)
 405         (tui_update_source_windows_with_addr): Update.
 406         (tui_clear_source_content): Remove "display_prompt" parameter.
 407         (tui_erase_source_content): Likewise.  Simplify.
 408         (tui_show_source_content): Update.
 409         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 410         * tui/tui-stack.c (tui_show_frame_info): Update.
 411         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 412         Remove defines.
 413
 414 2019-07-17  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 417         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 418         parameter.
 419         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 420         parameter.
 421
 422 2019-07-17  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-winsource.c (tui_clear_source_content)
 425         (tui_show_source_content, tui_show_exec_info_content)
 426         (tui_clear_exec_info_content): Update.
 427         * tui/tui-stack.c (tui_show_locator_content): Update.
 428         (tui_show_frame_info): Update.
 429         * tui/tui-source.h (tui_source_window): Don't declare.
 430         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 431         from tui_source_is_displayed.
 432         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 433         Remove field.
 434         (struct tui_source_window_base) <content_in_use>: New field.  Now
 435         bool.
 436         (struct tui_source_window) <showing_source_p>: New method.
 437         (TUI_SRC_WIN): Change cast.
 438         * tui/tui-data.c (tui_initialize_static_data): Update.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 443         location_matches_p.
 444         * tui/tui-source.c (tui_source_window::location_matches_p): New
 445         method.
 446         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 447         method.
 448         * tui/tui-data.h (struct tui_source_window_base)
 449         <location_matches_p>: New method.
 450         (struct tui_source_window, struct tui_disasm_window)
 451         <location_matches_p>: Likewise.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-win.c (tui_set_win_height_command): Rename from
 456         tui_set_win_height.
 457         (tui_set_win_height_command): Remove.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-source.c (tui_source_window): New constructor.  Add
 462         observer.
 463         (~tui_source_window): New destructor.
 464         (tui_source_window::style_changed): New method.
 465         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 466         (tui_attach_detach_observers): Update.
 467         * tui/tui-data.h (struct tui_source_window): Make constructor not
 468         inline.  Add destructor.
 469         (struct tui_source_window) <style_changed>: New method.
 470         <m_observable>: New member.
 471
 472 2019-07-17  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 475         * tui/tui-win.c (tui_resize_all): Fix typo.
 476
 477 2019-07-17  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 480         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 481         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 482         * tui/tui-win.c (window_name_completer): Use foreach.
 483         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 484         (update_tab_width): Likewise.
 485         * tui/tui-layout.c (show_layout): Update.
 486         * tui/tui-data.h (class tui_window_iterator): New.
 487         (struct all_tui_windows): New.
 488         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 493         parameter.  Don't reference globals.
 494         (tui_reg_command): Update.
 495
 496 2019-07-17  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-regs.c (tui_show_registers): Simplify.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-regs.c (tui_show_registers): Update.
 503         (tui_show_register_group): Add win_info parameter.
 504
 505 2019-07-17  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 508         Rename from tui_display_reg_element_at_line.
 509         (tui_data_window::display_registers_from_line): Update.
 510         * tui/tui-data.h (struct tui_data_window)
 511         <display_reg_element_at_line>: New method.
 512
 513 2019-07-17  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-regs.h (tui_display_registers_from)
 516         (tui_display_registers_from_line): Don't declare.
 517         * tui/tui-windata.c (tui_data_window::display_all_data)
 518         (tui_data_window::refresh_all)
 519         (tui_data_window::do_scroll_vertical): Update.
 520         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 521         from tui_display_registers_from.
 522         (tui_display_reg_element_at_line): Update.
 523         (tui_data_window::display_registers_from_line): Rename from
 524         tui_display_registers_from_line.
 525         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 526         display_registers_from_line>: New methods.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 531         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 532         from tui_erase_data_content.
 533         (tui_data_window::display_all_data)
 534         (tui_data_window::refresh_all)
 535         (tui_data_window::do_scroll_vertical): Update.
 536         * tui/tui-regs.c (tui_show_registers): Update.
 537         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 538         New method.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 543         declare.
 544         * tui/tui-windata.c
 545         (tui_data_window::delete_data_content_windows): Rename from
 546         tui_delete_data_content_windows.
 547         (tui_data_window::display_all_data)
 548         (tui_data_window::do_scroll_vertical): Update.
 549         * tui/tui-data.h (struct tui_data_window)
 550         <delete_data_content_windows>: New method.
 551
 552 2019-07-17  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 555         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 556
 557 2019-07-17  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 560         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 561         from tui_display_all_data.
 562         * tui/tui-win.c
 563         (tui_data_window::do_make_visible_with_new_height): Update.
 564         * tui/tui-regs.c (tui_show_registers): Update.
 565         * tui/tui-layout.c (tui_set_layout): Update.
 566         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 567         method.
 568
 569 2019-07-17  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 572         * tui/tui-windata.c (tui_display_data_from): Remove.
 573         (tui_data_window::refresh_all): Update.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 578         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 579         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 580         tui_display_registers_from_line.
 581         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 582         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 583         "force_display" parameter.
 584
 585 2019-07-17  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 588         declare.
 589         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 590         Rename from tui_first_reg_element_no_inline.
 591         (tui_display_reg_element_at_line)
 592         (tui_display_registers_from_line): Update.
 593         * tui/tui-data.h (struct tui_data_window)
 594         <first_reg_element_no_inline>: New method.
 595
 596 2019-07-17  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-windata.c (tui_display_data_from)
 599         (tui_data_window::do_scroll_vertical): Update.
 600         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 601         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 602         Rename from tui_line_from_reg_element_no.
 603         (tui_display_registers_from_line): Update.
 604         * tui/tui-data.h (struct tui_data_window)
 605         <line_from_reg_element_no>: New method.
 606
 607 2019-07-17  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 610         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 611         tui_last_regs_line_no.
 612         (tui_display_reg_element_at_line)
 613         (tui_display_registers_from_line): Update.
 614         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 615         method.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         PR tui/24722:
 620         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 621         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 622         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 623         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 624         (tui_update_breakpoint_info): Likewise.
 625         * tui/tui-hooks.c (tui_event_create_breakpoint)
 626         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 627         Update.
 628
 629 2019-07-17  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 632
 633 2019-07-17  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-winsource.c (tui_update_source_window_as_is)
 636         (tui_update_source_windows_with_addr): Update.
 637         * tui/tui-source.h (tui_set_source_content)
 638         (tui_show_symtab_source): Add "win_info" parameter.
 639         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 640         parameter.
 641         (tui_show_symtab_source): Likewise.
 642
 643 2019-07-17  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-wingeneral.c
 646         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 647
 648 2019-07-17  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 651         (struct tui_cmd_window) <can_scroll>: New method.
 652         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 653         method.
 654
 655 2019-07-17  Tom Tromey  <tromey@adacore.com>
 656
 657         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 658         do_field_signed>: Rename.  Change type of "value".
 659         * ui-out.c (ui_out::field_signed): Rename from field_int.
 660         Change type of "value".
 661         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 662         type of "value".
 663         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 664         do_field_int.  Change type of "value".
 665         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 666         do_field_int.  Change type of "value".
 667         * tracepoint.c (trace_status_mi, tfind_1)
 668         (print_one_static_tracepoint_marker): Update.
 669         * thread.c (print_thread_info_1, print_selected_thread_frame):
 670         Update.
 671         * stack.c (print_frame, print_frame_info): Update.
 672         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 673         Update.
 674         * source.c (print_source_lines_base): Update.
 675         * skip.c (info_skip_command): Update.
 676         * record-btrace.c (btrace_ui_out_decode_error)
 677         (btrace_call_history_src_line): Update.
 678         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 679         Update.
 680         * progspace.c (print_program_space): Update.
 681         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 682         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 683         do_field_int.  Change type of "value".
 684         * mi/mi-out.c (mi_ui_out::do_table_begin)
 685         (mi_ui_out::do_table_header): Update.
 686         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 687         type of "value".
 688         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 689         (mi_cmd_data_list_changed_registers, output_register)
 690         (mi_cmd_data_read_memory, mi_load_progress)
 691         (mi_cmd_trace_frame_collected): Update.
 692         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 693         Update.
 694         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 695         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 696         (mi_cmd_var_list_children, varobj_update_one): Update.
 697         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 698         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 699         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 700         * inferior.c (print_inferior): Update.
 701         * gdb_bfd.c (print_one_bfd): Update.
 702         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 703         Update.
 704         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 705         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 706         do_field_int.  Change type of "value".
 707         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 708         do_field_int.  Change type of "value".
 709         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 710         (print_one_breakpoint_location, print_it_catch_fork)
 711         (print_one_catch_fork, print_it_catch_vfork)
 712         (print_one_catch_vfork, print_it_catch_solib)
 713         (print_it_catch_exec, print_it_ranged_breakpoint)
 714         (print_mention_watchpoint, print_mention_masked_watchpoint)
 715         (bkpt_print_it, update_static_tracepoint): Update.
 716         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 717         * break-catch-syscall.c (print_it_catch_syscall): Update.
 718         * ada-tasks.c (print_ada_task_info): Update.
 719         * ada-lang.c (print_it_exception, print_mention_exception):
 720         Update.
 721
 722 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         PR breakpoints/24541
 725         * gdbarch.c: Regenerate.
 726         * gdbarch.h: Regenerate.
 727         * gdbarch.sh: Adjust return type and parameter types for
 728         'stap_adjust_register'.
 729         (i386_stap_adjust_register): Adjust signature and return new
 730         register name.
 731         * stap-probe.c (stap_parse_register_operand): Adjust use of
 732         'gdbarch_stap_adjust_register'.
 733
 734 2019-07-17  Tom Tromey  <tromey@adacore.com>
 735
 736         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 737         declare VEC.
 738         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 739         std::vector.
 740         (struct s390_process_info): Add initializers.
 741         (s390_add_process): Use new.
 742         (s390_linux_nat_target::low_forget_process): Use delete.
 743         (s390_linux_nat_target::low_new_fork)
 744         (s390_linux_nat_target::stopped_by_watchpoint)
 745         (s390_linux_nat_target::low_prepare_to_resume)
 746         (s390_linux_nat_target::insert_watchpoint)
 747         (s390_linux_nat_target::insert_hw_breakpoint)
 748         (s390_linux_nat_target::remove_watchpoint)
 749         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 750
 751 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 752
 753         * aarch64-fbsd-nat.c: Include regcache.h.
 754         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 755         argument.
 756         (aarch64_fbsd_nat_target::fetch_registers)
 757         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 758         variable.
 759         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 760
 761 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 762
 763         * fbsd-nat.c: Include gdbarch.h.
 764
 765 2019-07-15  Tom Tromey  <tromey@adacore.com>
 766
 767         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 768
 769 2019-07-15  Tom Tromey  <tromey@adacore.com>
 770
 771         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 772         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 773         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 774         * cli-out.c (cli_ui_out::do_field_int): New method.
 775         * ui-out.c (ui_out::field_unsigned): New method.
 776         * symfile.c (generic_load): Use field_unsigned.
 777         (print_transfer_performance): Likewise.
 778         * record-btrace.c (ui_out_field_uint): Remove.
 779         (btrace_call_history_insn_range, btrace_call_history): Use
 780         field_unsigned.
 781         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 782         field_unsigned.
 783         * ui-out.h (class ui_out) <field_unsigned>: New method.
 784         <do_field_unsigned>: Likewise.
 785
 786 2019-07-15  Tom Tromey  <tromey@adacore.com>
 787
 788         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 789         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 790         * target.c (flash_erase_command): Use field_string.
 791         * infrun.c (print_signal_received_reason): Use field_string.
 792         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 793         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 794         field_string.
 795         * ada-tasks.c (print_ada_task_info): Use field_string.
 796
 797 2019-07-15  Tom Tromey  <tromey@adacore.com>
 798
 799         * target.c (flash_erase_command): Use field_core_addr.
 800         * symfile.c (generic_load): Use field_core_addr.
 801         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 802         Use field_core_addr.
 803         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 804         field_core_addr.
 805
 806 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 809         value if its desired type is smaller than a CORE_ADDR and signed.
 810
 811 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 814         of changes to field names, and use new is_reference field to
 815         decide if a property is a reference or not.
 816         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 817         field.
 818         (struct dwarf2_property_baton): Update header comment, rename
 819         'referenced_type' to 'property_type' and update comments.
 820         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 821         default property type, store in property baton, update to take
 822         accound of renamed field.
 823         (read_func_scope): Update call to attr_to_dynamic_prop.
 824         (read_array_type): Likewise.
 825         (dwarf2_per_cu_addr_sized_int_type): New function.
 826         (read_subrange_index_type): Move type finding code to
 827         dwarf2_per_cu_addr_sized_int_type.
 828         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 829         (dwarf2_per_cu_addr_type): New function.
 830         (set_die_type): Update calls to attr_to_dynamic_prop.
 831
 832 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * dwarf2read.c (read_subrange_index_type): New function.
 835         (read_subrange_type): Move code into new function and call it.
 836         * gdbtypes.c (create_range_type): Add some asserts.
 837
 838 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 841         update return statements.
 842         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 843         declaration, and update comment to match.
 844         * gdbtypes.c (resolve_dynamic_array): Update call to
 845         dwarf2_evaluate_property to match new return type.
 846
 847 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * valarith.c (value_subscripted_rvalue): Change lowerbound
 850         parameter type from int to LONGEST.
 851         * value.h (value_subscripted_rvalue): Likewise in declaration.
 852
 853 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * cli/cli-utils.c (info_print_command_completer): New function.
 856         * cli/cli-utils.h: Add 'completer.h' include, and forward
 857         declaration for 'struct cmd_list_element'.
 858         (info_print_command_completer): Declare.
 859         * stack.c (_initialize_stack): Add completer for 'info locals' and
 860         'info args'.
 861         * symtab.c (_initialize_symtab): Add completer for 'info
 862         variables' and 'info functions'.
 863         * NEWS: Mention completion for additional info commands.
 864
 865 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 866
 867         * cli/cli-utils.c (extract_info_print_args): Delete.
 868         (extract_arg_maybe_quoted): Delete.
 869         (info_print_options_defs): New variable.
 870         (make_info_print_options_def_group): New function.
 871         (extract_info_print_options): Define new function.
 872         * cli/cli-utils.h (extract_info_print_args): Delete.
 873         (struct info_print_options): New structure.
 874         (extract_info_print_options): Declare new function.
 875         * stack.c (info_locals_command): Update to use new
 876         extract_info_print_options, also add a header comment.
 877         (info_args_command): Likewise.
 878         * symtab.c (info_variables_command): Likewise.
 879         (info_functions_command): Likewise.
 880
 881 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 884         to extract string arguments.
 885         * common/common-utils.c (extract_string_maybe_quoted): New function.
 886         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 887
 888 2019-07-11  Tom Tromey  <tromey@adacore.com>
 889
 890         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 891         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 892         * top.h (gdbinit): Don't declare.
 893         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 894         into...
 895         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 896         * top.c (gdb_init): Don't call init_cli_cmds.
 897         (gdbinit): Remove.
 898         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 899
 900 2019-07-11  Tom Tromey  <tromey@adacore.com>
 901
 902         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 903         after it has been moved.
 904
 905 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 906
 907         * valops.c (value_must_coerce_to_target): Change return type to
 908         bool.
 909         * value.h (value_must_coerce_to_target): Likewise.
 910
 911 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 912
 913         * breakpoint.c (is_hardware_watchpoint): Remove
 914         forward-declaration.
 915         (is_masked_watchpoint): Change return type to bool.
 916         (is_tracepoint): Likewise.
 917         (is_breakpoint): Likewise.
 918         (is_hardware_watchpoint): Likewise.
 919         (is_watchpoint): Likewise.
 920         (is_no_memory_software_watchpoint): Likewise.
 921         (is_catchpoint): Likewise.
 922         (breakpoint_1): Make FILTER parameter's return type bool.
 923         is_masked_watchpoint): Change return type to bool.
 924         (save_breakpoints): Make FILTER parameter's return type bool.
 925         * breakpoint.h (is_breakpoint): Change return type to bool.
 926         (is_watchpoint): Likewise.
 927         (is_catchpoint): Likewise.
 928         (is_tracepoint): Likewise.
 929
 930 2019-07-10  Tom Tromey  <tom@tromey.com>
 931
 932         * defs.h: Don't include gdbarch.h.
 933         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 934         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 935         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 936         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 937         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 938         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 939         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 940         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 941         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 942         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 943         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 944         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 945         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 946         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 947         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 948         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 949         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 950         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 951         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 952         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 953         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 954         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 955         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 956         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 957         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 958         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 959         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 960
 961 2019-07-10  Tom Tromey  <tromey@adacore.com>
 962
 963         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 964         * breakpoint.c (init_ada_exception_breakpoint): Register as
 965         bp_catchpoint.
 966         (print_one_breakpoint_location, print_one_breakpoint): Use
 967         is_ada_exception_catchpoint.
 968         * ada-lang.c (class ada_catchpoint_location): Pass
 969         bp_loc_software_breakpoint to bp_location constructor.
 970         (is_ada_exception_catchpoint): New function.
 971
 972 2019-07-10  Tom Tromey  <tromey@adacore.com>
 973
 974         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 975         VEC.
 976         (struct arm_exidx_entry): New method operator<.
 977         (struct arm_exidx_data) <section_maps>: Change type.
 978         (arm_exidx_data_free): Remove.
 979         (arm_exidx_data_key): Change type.  Move lower.
 980         (arm_exidx_new_objfile): Update.
 981         (arm_compare_exidx_entries): Remove.
 982         (arm_find_exidx_entry, _initialize_arm_tdep)
 983
 984 2019-07-10  Tom Tromey  <tromey@adacore.com>
 985
 986         * solib-spu.c (ocl_program_data_key): Change type.
 987         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 988         Update.
 989
 990 2019-07-10  Tom Tromey  <tromey@adacore.com>
 991
 992         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 993         (struct solib_aix_inferior_data) <library_list>: Change type.
 994         (solib_aix_inferior_data_handle): Change type.
 995         (get_solib_aix_inferior_data): Update.
 996         (solib_aix_free_library_list): Remove.
 997         (library_list_start_library): Update.
 998         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 999         return type.
1000         (solib_aix_get_library_list)
1001         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1002         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1003
1004 2019-07-10  Tom Tromey  <tromey@adacore.com>
1005
1006         * solib-dsbt.c (struct dsbt_info): Add initializers.
1007         (solib_dsbt_pspace_data): Change type.
1008         (dsbt_pspace_data_cleanup): Remove.
1009         (get_dsbt_info, _initialize_dsbt_solib): Update.
1010
1011 2019-07-10  Tom Tromey  <tromey@adacore.com>
1012
1013         * spu-tdep.c (spu_overlay_data): Change type.
1014         (spu_get_overlay_table, spu_overlay_new_objfile)
1015         (_initialize_spu_tdep): Update.
1016
1017 2019-07-10  Tom Tromey  <tromey@adacore.com>
1018
1019         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1020         destructor.
1021         (dbx_objfile_data_key): Change type and declare later.
1022         (DBX_SYMFILE_INFO): Rewrite.
1023         * dbxread.c (dbx_objfile_data_key): Change type.
1024         (dbx_symfile_init): Update.
1025         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1026         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1027         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1028
1029 2019-07-10  Tom Tromey  <tromey@adacore.com>
1030
1031         * jit.c (jit_program_space_key): Change type.  Move lower.
1032         (get_jit_program_space_data): Update.
1033         (jit_program_space_data_cleanup): Remove.
1034         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1035         Update.
1036         (struct jit_program_space_data): Add initializers.
1037
1038 2019-07-10  Tom Tromey  <tromey@adacore.com>
1039
1040         * solib-darwin.c (struct darwin_info): Add initializers.
1041         (solib_darwin_pspace_data): Change type.
1042         (darwin_pspace_data_cleanup): Remove.
1043         (get_darwin_info, _initialize_darwin_solib): Update.
1044
1045 2019-07-10  Tom Tromey  <tromey@adacore.com>
1046
1047         * remote-sim.c (struct sim_inferior_data): Add initializers,
1048         constructor, and destructor.
1049         (sim_inferior_data_key): Change type.  Move lower.
1050         (check_for_duplicate_sim_descriptor): Update.
1051         (get_sim_inferior_data): Use new.  Update.
1052         (~sim_inferior_data_cleanup): Rename from
1053         sim_inferior_data_cleanup.  Simplify.
1054         (gdbsim_close_inferior, simulator_command)
1055         (sim_command_completer, _initialize_remote_sim): Update.
1056         (next_pid, INITIAL_PID): Move earlier.
1057
1058 2019-07-10  Tom Tromey  <tromey@adacore.com>
1059
1060         * python/python-internal.h (create_thread_object): Return
1061         gdbpy_ref.
1062         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1063         * python/py-inferior.c (struct threadlist_entry): Add
1064         constructor.
1065         <thread_obj>: Now a gdbpy_ref.
1066         (thread_to_thread_object): Update.
1067         (add_thread_object): Use new.
1068         (delete_thread_object): Use delete.
1069         (infpy_threads): Update.
1070         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1071         GIL.
1072
1073 2019-07-10  Tom Tromey  <tromey@adacore.com>
1074
1075         * valops.c (value_cast): Specialize error message for Ada.
1076
1077 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1078
1079         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1080
1081 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1082
1083         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1084         bpstat_should_step): Return bool, adjust comments.
1085         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1086         bpstat_should_step): Likewise.
1087
1088 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1089
1090         * features/Makefile: Use feature target descriptions for Arm.
1091         * features/arm/arm-core.c: Generate new file.
1092         * features/arm/arm-fpa.c: Likewise.
1093         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1094         * features/arm/arm-m-profile.c: Likewise.
1095         * features/arm/arm-vfpv2.c: Likewise.
1096         * features/arm/arm-vfpv3.c: Likewise.
1097         * features/arm/xscale-iwmmxt.c: Likewise.
1098         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1099
1100 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1101
1102         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1103         ptrace earlier.
1104
1105 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1106
1107         * features/aarch64-pauth.c: Regenerate.
1108
1109 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1110
1111         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1112         bool.
1113         (bpstat_what): Use false instead of 0.
1114
1115 2019-07-09  Pedro Alves  <palves@redhat.com>
1116
1117         * break-catch-throw.c (is_exception_catchpoint): New.
1118         * breakpoint.c (print_one_breakpoint_location): New parameter
1119         'raw_loc'.  Handle it.  Use
1120         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1121         looking at the breakpoint's type.
1122         (print_one_breakpoint): If handling "maint info breakpoints", also
1123         print locations of exception catchpoints.
1124         * breakpoint.h (is_exception_catchpoint): Declare.
1125
1126 2019-07-09  Pedro Alves  <palves@redhat.com>
1127
1128         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1129         "addr" field.
1130         (allocate_location_exception_catchpoint): New.
1131         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1132         (initialize_throw_catchpoint_ops): Install
1133         allocate_location_exception_catchpoint as allocate_location
1134         method.
1135         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1136         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1137         bp_loc_other.
1138         (breakpoint_address_is_meaningful): Delete.
1139         (bl_address_is_meaningful): New.
1140         (breakpoint_locations_match): Adjust comment.
1141         (bp_location_from_bp_type): New, factored out of...
1142         (bp_location::bp_location(breakpoint *)): ... this.
1143         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1144         factored out of...
1145         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1146         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1147         breakpoint_address_is_meaningful.
1148         (bp_locations_compare): Adjust comment.
1149         (update_global_location_list): Use bl_address_is_meaningful
1150         instead of breakpoint_address_is_meaningful.
1151         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1152         explicit.
1153         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1154         * python/py-breakpoint.c (bppy_get_location): No longer check
1155         whether location is null.
1156
1157 2019-07-09  Pedro Alves  <palves@redhat.com>
1158
1159         PR c++/15468
1160         * breakpoint.c (print_one_breakpoint_location): Remove
1161         single-location assert.
1162
1163 2019-07-09  Tom Tromey  <tom@tromey.com>
1164
1165         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1166         * configure: Rebuild.
1167         * configure.ac: Change common to gdbsupport.
1168         * gdbsupport: Rename from common.
1169         * acinclude.m4: Change common to gdbsupport.
1170         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1171         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1172         gdbsupport.
1173         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1174         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1175         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1176         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1177         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1178         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1179         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1180         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1181         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1182         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1183         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1184         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1185         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1186         coff-pe-read.c, command.h, compile/compile-c-support.c,
1187         compile/compile-c.h, compile/compile-cplus-symbols.c,
1188         compile/compile-cplus-types.c, compile/compile-cplus.h,
1189         compile/compile-loc2c.c, compile/compile.c, completer.c,
1190         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1191         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1192         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1193         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1194         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1195         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1196         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1197         features/aarch64-core.c, features/aarch64-fpu.c,
1198         features/aarch64-pauth.c, features/aarch64-sve.c,
1199         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1200         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1201         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1202         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1203         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1204         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1205         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1206         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1207         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1208         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1209         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1210         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1211         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1212         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1213         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1214         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1215         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1216         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1217         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1218         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1219         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1220         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1221         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1222         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1223         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1224         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1225         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1226         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1227         minsyms.c, mips-linux-tdep.c, namespace.h,
1228         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1229         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1230         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1231         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1232         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1233         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1234         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1235         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1236         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1237         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1238         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1239         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1240         procfs.c, producer.c, progspace.h, psymtab.h,
1241         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1242         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1243         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1244         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1245         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1246         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1247         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1248         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1249         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1250         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1251         target-memory.c, target.c, target.h, target/waitstatus.c,
1252         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1253         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1254         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1255         unittests/array-view-selftests.c,
1256         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1257         unittests/common-utils-selftests.c,
1258         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1259         unittests/format_pieces-selftests.c,
1260         unittests/function-view-selftests.c,
1261         unittests/lookup_name_info-selftests.c,
1262         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1263         unittests/mkdir-recursive-selftests.c,
1264         unittests/observable-selftests.c,
1265         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1266         unittests/parse-connection-spec-selftests.c,
1267         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1268         unittests/scoped_fd-selftests.c,
1269         unittests/scoped_mmap-selftests.c,
1270         unittests/scoped_restore-selftests.c,
1271         unittests/string_view-selftests.c, unittests/style-selftests.c,
1272         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1273         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1274         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1275         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1276         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1277         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1278
1279 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1282         bool value.
1283         (decode_digits_ordinary): Set explicit_line field in sal.
1284         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1285         symtab_and_line that was set on an explicit line number in
1286         assembler code.  Do always update the recorded symtab and line if
1287         we do skip the prologue.
1288
1289 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * breakpoint.c (set_breakpoint_location_function): Remove
1292         explicit_loc parameter.
1293         (momentary_breakpoint_from_master): Update call to
1294         set_breakpoint_location_function.
1295         (add_location_to_breakpoint): Likewise.
1296
1297 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1300         required features based on default bfd type when no specific bfd
1301         is present.
1302
1303 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1304
1305         * NEWS: Mention that GDB printf and eval commands can now print
1306         C-style and Ada-style convenience var strings without
1307         calling the inferior.
1308         * printcmd.c (printf_c_string): Locally print GDB internal var
1309         instead of transiting via the inferior.
1310         (printf_wide_c_string): Likewise.
1311
1312 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1313
1314         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1315
1316 2019-07-04  Tom Tromey  <tom@tromey.com>
1317
1318         PR tui/24724:
1319         * tui/tui-winsource.c (tui_clear_source_content): Update.
1320         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1321         (tui_update_breakpoint_info): Update.
1322         (tui_set_exec_info_content): Update.
1323         * tui/tui-source.c (tui_set_source_content_nil): Update.
1324         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1325         has_break.
1326         * tui/tui-data.h (enum tui_bp_flag): New.
1327         (tui_bp_flags): New enum flags type.
1328         (struct tui_source_element) <break_mode>: Change type.  Rename
1329         from has_break.
1330         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1331         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1332         constants.
1333         * tui/tui-winsource.h: Fix comment.
1334
1335 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1336
1337         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1338         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1339         (store_fpregs_to_thread)
1340         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1341         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1342         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1343         (IWMMXT_REGS_SIZE): Add define.
1344         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1345         (fetch_vfp_regs, store_vfp_regs)
1346         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1347         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1348
1349 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1350
1351         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1352         defines.
1353         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1354         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1355         (ARM_INT_REGISTER_SIZE): ...to this.
1356         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1357         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1358         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1359         (arm_linux_collect_gregset, supply_nwfpe_register)
1360         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1361         defines.
1362         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1363         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1364         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1365         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1366         (arm_return_in_memory, arm_store_return_value)
1367         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1368         (arm_record_ld_st_multiple): Likewise.
1369         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1370         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1371
1372 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1373
1374         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1375         AARCH64_DISPLACED_MODIFIED_INSNS.
1376         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1377         (aarch64_displaced_step_copy_insn): Likewise.
1378         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1379         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1380         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1381         ARM_DISPLACED_MODIFIED_INSNS.
1382         * arm-tdep.c (arm_gdbarch_init): Likewise.
1383         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1384         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1385         (struct arm_displaced_step_closure): Use
1386         ARM_DISPLACED_MODIFIED_INSNS.
1387
1388 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1389
1390         * features/Makefile: Remove unused xml files.
1391         * features/aarch64.xml: Remove.
1392         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1393         * features/i386/amd64-avx-avx512.xml: Remove.
1394         * features/i386/amd64-avx-linux.xml: Remove.
1395         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1396         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1397         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1398         * features/i386/amd64-avx-mpx.xml: Remove.
1399         * features/i386/amd64-avx.xml: Remove.
1400         * features/i386/amd64-linux.xml: Remove.
1401         * features/i386/amd64-mpx-linux.xml: Remove.
1402         * features/i386/amd64-mpx.xml: Remove.
1403         * features/i386/amd64.xml: Remove.
1404         * features/i386/i386-avx-avx512-linux.xml: Remove.
1405         * features/i386/i386-avx-avx512.xml: Remove.
1406         * features/i386/i386-avx-linux.xml: Remove.
1407         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1408         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1409         * features/i386/i386-avx-mpx-linux.xml: Remove.
1410         * features/i386/i386-avx-mpx.xml: Remove.
1411         * features/i386/i386-avx.xml: Remove.
1412         * features/i386/i386-linux.xml: Remove.
1413         * features/i386/i386-mmx-linux.xml: Remove.
1414         * features/i386/i386-mmx.xml: Remove.
1415         * features/i386/i386-mpx-linux.xml: Remove.
1416         * features/i386/i386-mpx.xml: Remove.
1417         * features/i386/i386.xml: Remove.
1418         * features/i386/x32-avx-avx512-linux.xml: Remove.
1419         * features/i386/x32-avx-linux.xml: Remove.
1420         * features/i386/x32-linux.xml: Remove.
1421
1422 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1423
1424         * regformats/aarch64.dat: Remove.
1425         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1426         * regformats/i386/amd64-avx-linux.dat: Remove.
1427         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1428         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1429         * regformats/i386/amd64-linux.dat: Remove.
1430         * regformats/i386/amd64-mpx-linux.dat: Remove.
1431         * regformats/i386/amd64.dat: Remove.
1432         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1433         * regformats/i386/i386-avx-linux.dat: Remove.
1434         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1435         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1436         * regformats/i386/i386-linux.dat: Remove.
1437         * regformats/i386/i386-mmx-linux.dat: Remove.
1438         * regformats/i386/i386-mpx-linux.dat: Remove.
1439         * regformats/i386/i386.dat: Remove.
1440         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1441         * regformats/i386/x32-avx-linux.dat: Remove.
1442         * regformats/i386/x32-linux.dat: Remove.
1443
1444 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1445
1446         * aarch64-tdep.c: Remove xml self tests.
1447         * amd64-linux-tdep.c: Likewise.
1448         * amd64-tdep.c: Likewise.
1449         * i386-linux-tdep.c: Likewise.
1450         * i386-tdep.c: Likewise.
1451
1452 2019-07-03  Pedro Alves  <palves@redhat.com>
1453
1454         PR cli/24732
1455         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1456         (pipe_cmd_option_defs): New.
1457         (make_pipe_cmd_options_def_group): New.
1458         (pipe_command): Use gdb::option::process_options.
1459         (pipe_command_completer): New function.
1460         (_initialize_cli_cmds): Install completer for "pipe" command.
1461
1462 2019-07-03  Pedro Alves  <palves@redhat.com>
1463
1464         * cli/cli-option.c (union option_value) <string>: New field.
1465         (struct option_def_and_value): Add ctor, move ctor, dtor and
1466         use DISABLE_COPY_AND_ASSIGN.
1467         (option_def_and_value::clear_value): New.
1468         (parse_option, save_option_value_in_ctx, get_val_type_str)
1469         (add_setshow_cmds_for_options): Handle var_string.
1470         * cli-option.h (union option_def::var_address) <string>: New
1471         field.
1472         (struct string_option_def): New.
1473         * maint-test-options.c (struct test_options_opts): Add default
1474         ctor and use DISABLE_COPY_AND_ASSIGN.
1475         <string_opt>: New field.
1476         (test_options_opts::~test_options_opts): New.
1477         (test_options_opts::dump): Also dump "-string".
1478         (test_options_option_defs): Install "string.
1479
1480 2019-07-03  Pedro Alves  <palves@redhat.com>
1481
1482         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1483         option_value with a null enumeration.
1484         (complete_options): Save the option values in the context.
1485         (save_option_value_in_ctx): New, factored out from ...
1486         (process_options): ... here.
1487         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1488         of the function.
1489         * maint-test-options.c (test_options_opts::dump): New, factored
1490         out from ...
1491         (maintenance_test_options_command_mode): ... here.
1492         (maintenance_test_options_command_completion_result): Delete.
1493         (maintenance_test_options_command_completion_text): Update
1494         comment.
1495         (maintenance_show_test_options_completion_result): Change
1496         prototype.  Just print
1497         maintenance_test_options_command_completion_text.
1498         (save_completion_result): New.
1499         (maintenance_test_options_completer_mode): Pass options context to
1500         complete_options, and then save a dump.
1501         (_initialize_maint_test_options): Use add_cmd to install "maint
1502         show test-options-completion-result".
1503
1504 2019-07-03  Pedro Alves  <palves@redhat.com>
1505
1506         * NEWS (New commands): Mention "with" and "maint with".
1507         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1508         (with_command, with_command_completer): New.
1509         (pipe_command): Adjust to new repeat_previous
1510         interface.
1511         (_initialize_cli_cmds): Install the "with" command and its "w"
1512         alias.
1513         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1514         declarations.
1515         * cli/cli-setshow.c (parse_cli_var_uinteger)
1516         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1517         argument strings for all var_types.
1518         (get_setshow_command_value_string): New, factored out from ...
1519         (do_show_command): ... this.
1520         * cli/cli-setshow.h: Include <string>.
1521         (get_setshow_command_value_string): Declare.
1522         * command.h (repeat_previous): Now returns const char *.  Adjust
1523         comment.
1524         * maint.c: Include "cli/cli-cmds.h".
1525         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1526         (_initialize_maint_cmds): Register the "maintenance with" command.
1527         * top.c (repeat_previous): Move bits from pipe_command here:
1528         Return the saved command line, if any; error out if there's no
1529         command to relaunch.
1530
1531 2019-07-03  Pedro Alves  <palves@redhat.com>
1532
1533         * NEWS (New commands): Mention "maint set/show test-settings"
1534         instead of "maint test-settings".
1535         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1536         (maintenance_test_settings_set_list): Rename to ...
1537         (maintenance_set_test_settings_list): ... this.
1538         (maintenance_test_settings_show_list): Rename to  ...
1539         (maintenance_show_test_settings_list): ... this.
1540         (maintenance_test_settings_cmd): Delete.
1541         (maintenance_test_settings_set_cmd): ...
1542         (maintenance_set_test_settings_cmd): ... this.
1543         (maintenance_test_settings_show_cmd): ...
1544         (maintenance_show_test_settings_cmd): ... this.
1545         (maintenance_test_settings_show_value_cmd):
1546         (maintenance_show_test_settings_value_cmd): ... this.
1547         (_initialize_maint_test_settings): No longer install the "maint
1548         test-settings" prefix command.  Rename "maint test-settings set"
1549         to "maint set test-settings", and "maint test-settings show" to
1550         "maint show test-settings".  Adjust all subcommands.
1551
1552 2019-07-03  Pedro Alves  <palves@redhat.com>
1553
1554         * maint-test-settings.c: Fix file's intro comment.  Replace all
1555         references to "test-options" with references to "test-settings",
1556         in comments.
1557
1558 2019-07-03  Pedro Alves  <palves@redhat.com>
1559
1560         * maint-test-settings.c (maintenance_test_settings_xxx)
1561         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1562         New.
1563         (maintenance_test_settings_enums): Use them.
1564         (maintenance_test_settings_enum): Default to
1565         maintenance_test_settings_xxx.
1566         (_initialize_maint_test_settings): Initialize
1567         MAINTENANCE_TEST_SETTINGS_FILENAME.
1568
1569 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1570
1571         * breakpoint.h (remove_breakpoints_inf): Change return type to
1572         void, move function documentation here.
1573         * breakpoint.c (remove_breakpoints_inf): Change return type to
1574         void, move function documentation to header.
1575
1576 2019-07-02  Pedro Alves  <palves@redhat.com>
1577
1578         * NEWS (Completion improvements): Mention "info threads".
1579         * thread.c (struct info_threads_opts, info_threads_option_defs)
1580         (make_info_threads_options_def_group): New.
1581         (info_threads_command): Use gdb::option::process_options.
1582         (info_threads_command_completer): New.
1583         (_initialize_thread): Use gdb::option::build_help to build the
1584         help text for "info threads".
1585
1586 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1587
1588         * defs.h (generic_load): Move from here...
1589         * symfile.h (generic_load): ... to here.  Rename name parameter
1590         to args.
1591         * symfile.c (generic_load): Add comment.
1592
1593 2019-07-01  Tom Tromey  <tromey@adacore.com>
1594
1595         * dwarf2read.c
1596         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1597         declaration of without_params.  Fix formatting.
1598
1599 2019-07-01  Tom Tromey  <tromey@adacore.com>
1600
1601         * ada-exp.y (find_primitive_type): Update.
1602         * ada-lang.h (ada_lookup_symbol): Update.
1603         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1604         parameter.
1605         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1606
1607 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1608
1609         PR breakpoints/24541
1610         * gdbarch.c: Regenerate.
1611         * gdbarch.h: Regenerate.
1612         * gdbarch.sh: Add 'stap_adjust_register'.
1613         * i386-tdep.c: Include '<unordered_set>'.
1614         (i386_stap_adjust_register): New function.
1615         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1616         * stap-probe.c (stap_parse_register_operand): Call
1617         'gdbarch_stap_adjust_register'.
1618
1619 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1620
1621         PR python/24742
1622         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1623         * python/python.c (do_start_initialization): Use 'xmalloc'
1624         instead of 'PyMem_Malloc'.
1625
1626 2019-06-28  Tom Tromey  <tromey@adacore.com>
1627
1628         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1629         for Ada.
1630
1631 2019-06-27  Tom Tromey  <tromey@adacore.com>
1632
1633         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1634         objfile_key.
1635         (arm_find_mapping_symbol, arm_record_special_symbol)
1636         (_initialize_arm_tdep): Update.
1637         (arm_objfile_data_free): Remove.
1638
1639 2019-06-27  Tom Tromey  <tromey@adacore.com>
1640
1641         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1642         to cp_print_static_field.
1643
1644 2019-06-26  Tom Tromey  <tromey@adacore.com>
1645
1646         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1647         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1648         declare.
1649
1650 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1651
1652         * features/aarch64-core.c (create_feature_aarch64_core):
1653         Regenerate.
1654         * features/aarch64-core.xml: Add cpsr flags.
1655
1656 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1657
1658         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1659         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1660
1661 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1662
1663         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1664         field.
1665         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1666         use.
1667         (arm_record_special_symbol): Don't insert new symbol in sorted
1668         position, push it at the end.
1669
1670 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1671
1672         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1673         (arm_mapping_symbol_s): Remove.
1674         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1675         (arm_mapping_symbol_vec): New typedef.
1676         (struct arm_per_objfile): Add constructor.
1677         <section_maps>: Change type to
1678         std::unique_ptr<arm_mapping_symbol_vec[]>.
1679         (arm_compare_mapping_symbols): Remove.
1680         (arm_find_mapping_symbol): Adjust to section_maps type change.
1681         (arm_objfile_data_free): Call delete on arm_per_objfile.
1682         (arm_record_special_symbol): Adjust to section_maps type change.
1683         Allocate arm_per_objfile with new.
1684
1685 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1686
1687         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1688         with the command prefix.
1689
1690 2019-06-25  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1693         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1698         type.
1699         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1700         protected.
1701
1702 2019-06-25  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-winsource.c
1705         (tui_source_window_base::set_is_exec_point_at): Add check against
1706         LOA_ADDRESS.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-source.c (tui_set_source_content): Don't check before
1711         xfree.
1712         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1713
1714 2019-06-25  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-winsource.h (tui_update_source_window_as_is)
1717         (tui_alloc_source_buffer, tui_line_is_displayed)
1718         (tui_addr_is_displayed): Change type of win_info.
1719         * tui/tui-winsource.c (tui_update_source_window_as_is)
1720         (tui_clear_source_content, tui_show_source_line)
1721         (tui_show_source_content, tui_source_window_base::refill)
1722         (tui_source_window_base::set_is_exec_point_at)
1723         (tui_source_window_base::set_is_exec_point_at)
1724         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1725         (tui_alloc_source_buffer, tui_line_is_displayed)
1726         (tui_addr_is_displayed): Change type of win_info.  Update.
1727         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1728         (tui_source_window_base::do_make_visible_with_new_height):
1729         Update.
1730         * tui/tui-source.c (tui_set_source_content)
1731         (tui_set_source_content_nil)
1732         (tui_source_window::do_scroll_vertical): Update.
1733         * tui/tui-layout.c (show_layout): Update.
1734         * tui/tui-disasm.c (tui_set_disassem_content)
1735         (tui_disasm_window::do_scroll_vertical): Update.
1736         * tui/tui-data.h (tui_win_content): Remove.
1737         (struct tui_gen_win_info) <content, content_size>: Remove.
1738         (struct tui_source_element): Add initializers and destructor.
1739         (union tui_which_element, struct tui_win_element): Remove.
1740         (struct tui_source_window_base) <content>: New field.
1741         (struct tui_data_window): Remove destructor.
1742         (tui_alloc_content, tui_free_win_content)
1743         (tui_free_all_source_wins_content): Don't declare.
1744         * tui/tui-data.c (tui_initialize_static_data): Update.
1745         (init_content_element, tui_alloc_content): Remove.
1746         (~tui_gen_win_info): Update.
1747         (~tui_data_window, tui_free_all_source_wins_content)
1748         (tui_free_win_content, free_content, free_content_elements):
1749         Remove.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-winsource.h (tui_clear_source_content)
1754         (tui_erase_source_content, tui_show_source_content): Change type
1755         of win_info.
1756         * tui/tui-winsource.c (tui_clear_source_content)
1757         (tui_erase_source_content, tui_show_source_content): Change type
1758         of win_info.
1759         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1760         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1761         win_info.
1762         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1763         win_info.
1764         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1765
1766 2019-06-25  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-winsource.c (tui_clear_source_content)
1769         (tui_source_window_base::set_is_exec_point_at): Update.
1770         * tui/tui-source.c (tui_set_source_content_nil): Update.
1771         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1772         a bool.
1773         * tui/tui-data.c (init_content_element): Update.
1774
1775 2019-06-25  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1778         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1779         * tui/tui-layout.c (init_and_make_win): Update.
1780         * tui/tui.h (enum tui_win_type): Update.
1781         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1782         tui_win_is_auxillary.
1783         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1784         tui_win_is_auxillary.
1785
1786 2019-06-25  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1789         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1790         (tui_delete_data_content_windows, tui_display_all_data)
1791         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1792         Update.
1793         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1794         * tui/tui-regs.c (tui_last_regs_line_no)
1795         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1796         (tui_show_registers): Update.
1797         (tui_show_register_group): Return void.  Update.
1798         (tui_display_registers_from, tui_display_reg_element_at_line)
1799         (tui_display_registers_from_line, tui_check_register_values):
1800         Update.
1801         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1802         member.
1803         (struct tui_data_window) <regs_content>: Now a std::vector.
1804         <regs_content_count>: Remove.
1805         (tui_add_content_elements, tui_free_data_content): Don't declare.
1806         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1807         (init_content_element): Remove DATA_WIN case.  Add assert.
1808         (tui_add_content_elements): Remove.
1809         (tui_data_window): Update.
1810         (tui_free_data_content): Remove.
1811         (free_content_elements): Remove DATA_WIN case.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-data.c (tui_data_item_window): Update.
1816         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1817         * tui/tui-windata.c (tui_display_all_data)
1818         (tui_display_data_from_line): Update.
1819         (tui_check_data_values): Remove.
1820         * tui/tui-regs.c (tui_show_register_group)
1821         (tui_display_reg_element_at_line): Update.
1822         * tui/tui-hooks.c (tui_register_changed)
1823         (tui_refresh_frame_and_register_information): Call
1824         tui_check_register_values.
1825         * tui/tui-data.h (struct tui_data_window) <data_content,
1826         data_content_count, data_type>: Remove.
1827         (enum tui_data_type): Remove.
1828
1829         * tui/tui-data.c (tui_data_window::clear_detail)
1830         (~tui_data_window): Update.
1831
1832 2019-06-25  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1835         declare.
1836         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1837         Rename from tui_first_data_item_displayed.  Update.
1838         (tui_data_window::refresh_all)
1839         (tui_data_window::do_scroll_vertical): Update.
1840         * tui/tui-data.h (struct tui_data_window)
1841         <first_data_item_displayed>: Declare new method.
1842
1843 2019-06-25  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1846         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1847         contents...
1848         (tui_initialize_static_data): ...here.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1853         (tui_display_registers_from, tui_check_register_values): Update.
1854         (tui_display_register): Remove win_info parameter; update.
1855         (tui_get_register): Change type of parameters.
1856         * tui/tui-data.h (struct tui_data_element): Remove.
1857         (union tui_which_element) <data>: Remove.
1858         <data_window>: Change type.
1859         (struct tui_data_item_window): New.
1860         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1861         case.  Add assert.
1862         (~tui_data_item_window): New destructor.
1863         (free_content_elements): Remove DATA_ITEM_WIN case.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1868         Remove.
1869
1870 2019-06-25  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-data.h (struct tui_command_element): Remove.
1873         (union tui_which_element) <command>: Remove.
1874         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1875         assert.
1876         (free_content_elements): Remove CMD_WIN case.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-layout.c (tui_set_layout): Update.
1881         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1882         * tui/tui-data.c (layout_def): Update.
1883
1884 2019-06-25  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1887         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1888         (tui_source_window_base::set_new_height): Update.
1889         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1890         Update.
1891         (tui_set_locator_fullname, tui_set_locator_info)
1892         (tui_show_frame_info): Update.
1893         * tui/tui-source.c (tui_set_source_content)
1894         (tui_source_is_displayed): Update.
1895         * tui/tui-layout.c (show_source_disasm_command, show_data)
1896         (show_source_or_disasm_and_command): Update.
1897         * tui/tui-disasm.c (tui_set_disassem_content)
1898         (tui_get_begin_asm_address): Update.
1899         * tui/tui-data.h (struct tui_locator_element): Remove.
1900         (union tui_which_element) <locator>: Remove.
1901         (struct tui_locator_window): New.
1902         (tui_locator_win_info_ptr): Change return type.
1903         * tui/tui-data.c (_locator): Change type.
1904         (tui_locator_win_info_ptr): Change return type.
1905         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1906         (tui_alloc_content): Add assert.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-winsource.c
1911         (tui_exec_info_window::maybe_allocate_content): New method.
1912         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1913         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1914         (make_source_or_disasm_window): Add cast.
1915         * tui/tui-data.h (union tui_which_element) <simple_string>:
1916         Remove.
1917         (struct tui_source_info): New.
1918         (struct tui_source_window_base) <execution_info>: Change type.
1919         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1920         case, and add assert.
1921         (tui_alloc_content): Add assert.
1922
1923 2019-06-25  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1926         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1927         * tui/tui-data.c (tui_alloc_win_info): Remove.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1932         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1933         can_highlight.
1934
1935 2019-06-25  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1938         make_visible_with_new_height method.
1939         (tui_win_info::make_visible_with_new_height): New method.
1940         (tui_source_window_base::do_make_visible_with_new_height)
1941         (tui_data_window::do_make_visible_with_new_height)
1942         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1943         (make_visible_with_new_height): Remove.
1944         (tui_resize_all, tui_adjust_win_heights): Use
1945         make_visible_with_new_height method.
1946         * tui/tui-data.h (struct tui_win_info)
1947         <do_make_visible_with_new_height, make_visible_with_new_height>:
1948         New methods.
1949         (struct tui_source_window_base, struct tui_data_window)
1950         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1951         methods.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1956         method.
1957         (update_tab_width): Call update_tab_width method.
1958         * tui/tui-data.h (struct tui_win_info)
1959         (struct tui_source_window_base) <update_tab_width>: New methods.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1964         parameter.
1965         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1966         parameter.
1967         (tui_gen_win_info::make_visible): Update.
1968         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1969         parameter.
1970         * tui/tui-data.h (enum tui_box): New enum.
1971         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1976         init_and_make_win for EXEC_INFO_WIN.
1977         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1978         longer inline.
1979         (struct tui_win_info) <~tui_win_info>: Inline.
1980         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1981         Don't declare.
1982         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1983         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1984         Remove.
1985         (tui_initialize_static_data): Update.
1986         (~tui_gen_win_info): Handle more cleanup here.
1987         (~tui_source_window_base): Delete "execution_info".
1988         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-layout.c (make_command_window): Don't set
1993         can_highlight.
1994         (show_source_disasm_command): Call the reset method.
1995         (show_data): Don't set can_highlight.  Call the reset method.
1996         (tui_gen_win_info::reset): Rename from init_gen_win_info
1997         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1998         (show_source_or_disasm_and_command): Call the reset method.
1999         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2000         (struct tui_cmd_window): Set can_highlight.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2005         from make_visible.
2006         (tui_make_visible, tui_make_invisible): Rewrite.
2007         (tui_win_info::make_visible): Remove.
2008         (tui_source_window_base::make_visible): Update.
2009         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2010         method.  Moved from...
2011         (struct tui_win_info) <make_visible>: ...here.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.c
2016         (tui_source_window_base::do_scroll_horizontal): Remove direction
2017         parameter.
2018         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2019         direction parameter.
2020         * tui/tui-win.c (tui_win_info::forward_scroll)
2021         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2022         (tui_win_info::right_scroll): Update.
2023         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2024         direction parameter.
2025         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2026         direction parameter.
2027         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2028         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2029         Remove direction parameter.
2030         (struct tui_source_window_base, struct tui_source_window)
2031         (struct tui_disasm_window, struct tui_data_window)
2032         (struct tui_cmd_window): Update.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-winsource.h (tui_set_exec_info_content)
2037         (tui_show_exec_info_content, tui_erase_exec_info_content)
2038         (tui_clear_exec_info_content, tui_update_exec_info): Change
2039         argument to tui_source_window_base.
2040         * tui/tui-winsource.c (tui_set_exec_info_content)
2041         (tui_show_exec_info_content, tui_erase_exec_info_content)
2042         (tui_clear_exec_info_content, tui_update_exec_info): Change
2043         argument to tui_source_window_base.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2048         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2053         check.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2058         type to void.
2059         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2060         type to void.
2061         * tui/tui-source.c (tui_set_source_content): Update.
2062         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-win.c (window_name_completer, tui_set_focus)
2067         (tui_all_windows_info): Use name method.
2068         * tui/tui-data.h (struct tui_gen_win_info)
2069         (struct tui_source_window, struct tui_disasm_window)
2070         (struct tui_data_window, struct tui_cmd_window) <name>: New
2071         method.
2072         (tui_win_name): Don't declare.
2073         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2074         (tui_win_name): Remove.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-winsource.h (tui_update_source_window)
2079         (tui_update_source_window_as_is): Change parameter type.
2080         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2081         to be a tui_source_window_base.
2082         (tui_update_source_window_as_is): Likewise.
2083         * tui/tui-win.c (make_visible_with_new_height): Update.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-winsource.c (tui_erase_source_content)
2088         (tui_show_source_content, tui_show_exec_info_content)
2089         (tui_erase_exec_info_content): Use refresh_window method.
2090         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2091         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2092         from tui_refresh_win.
2093         (tui_data_window::refresh_window): New method.
2094         (tui_win_info::refresh, tui_source_window_base::refresh)
2095         (tui_refresh_all): Use refresh_window method.
2096         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2097         method.
2098         * tui/tui-regs.c (tui_display_register): Call refresh_window
2099         method.
2100         * tui/tui-layout.c (show_source_disasm_command)
2101         (show_source_or_disasm_and_command): Call refresh_window method.
2102         * tui/tui-data.h (struct tui_gen_win_info)
2103         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2104         New method.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui.c (tui_rl_other_window, tui_enable)
2109         (tui_is_window_visible, tui_get_command_dimension): Update.
2110         * tui/tui-winsource.c (tui_update_source_window_as_is)
2111         (tui_clear_source_content, tui_erase_source_content)
2112         (tui_show_source_line, tui_source_window_base::refill)
2113         (tui_source_window_base::do_scroll_horizontal)
2114         (tui_source_window_base::set_is_exec_point_at)
2115         (tui_update_breakpoint_info, tui_set_exec_info_content)
2116         (tui_alloc_source_buffer, tui_line_is_displayed)
2117         (tui_addr_is_displayed): Update.
2118         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2119         (tui_check_and_display_highlight_if_needed)
2120         (tui_win_info::make_visible, tui_win_info::refresh)
2121         (tui_refresh_all): Update.
2122         * tui/tui-windata.c (tui_first_data_item_displayed)
2123         (tui_delete_data_content_windows, tui_erase_data_content)
2124         (tui_display_all_data, tui_data_window::refresh_all)
2125         (tui_check_data_values): Update.
2126         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2127         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2128         (tui_win_info::backward_scroll, tui_refresh_all_win)
2129         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2130         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2131         (tui_source_window_base::set_new_height)
2132         (tui_data_window::set_new_height)
2133         (make_invisible_and_set_new_height)
2134         (make_visible_with_new_height, new_height_ok)
2135         (parse_scrolling_args): Update.
2136         * tui/tui-stack.c (tui_show_frame_info): Update.
2137         * tui/tui-source.c (tui_set_source_content)
2138         (tui_set_source_content_nil, tui_source_is_displayed)
2139         (tui_source_window::do_scroll_vertical): Update.
2140         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2141         (tui_display_registers_from, tui_display_reg_element_at_line)
2142         (tui_check_register_values, tui_reg_command): Update.
2143         * tui/tui-layout.c (tui_default_win_height)
2144         (show_source_disasm_command, show_data, init_and_make_win)
2145         (show_source_or_disasm_and_command): Update.
2146         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2147         (tui_redisplay_readline, tui_mld_flush)
2148         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2149         (tui_getc): Update.
2150         * tui/tui-disasm.c (tui_set_disassem_content)
2151         (tui_disasm_window::do_scroll_vertical): Update.
2152         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2153         Now virtual.
2154         (struct tui_win_info): Derive from tui_gen_win_info.
2155         <~tui_win_info>: Mark as override.
2156         <generic>: Remove member.
2157         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2158         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2159         (~tui_data_window, ~tui_win_info)
2160         (tui_free_all_source_wins_content): Update.
2161         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-layout.c (init_and_make_win): Use new.
2166         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2167         destructor, initializers.
2168         (tui_alloc_generic_win_info): Don't declare.
2169         * tui/tui-data.c (_locator): Add argument to constructor.
2170         (source_win, disasm_win): New globals.
2171         (exec_info): Remove.
2172         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2173         Update.
2174         (tui_alloc_generic_win_info): Remove.
2175         (init_content_element): Use new.
2176         (tui_win_info::tui_win_info): Update.
2177         (free_content_elements) <case DATA_WIN>: Use delete.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2182         * tui/tui-windata.c (tui_first_data_item_displayed)
2183         (tui_delete_data_content_windows): Update.
2184         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2185         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2186         (tui_display_registers_from, tui_check_register_values): Update.
2187         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2188         pointer.
2189         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2190         window.
2191         (tui_free_data_content): Update.
2192         (free_content_elements) <case DATA_WIN>: Free the window.
2193
2194 2019-06-25  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2197         Update.
2198         * tui/tui-layout.c (make_command_window)
2199         (show_source_disasm_command, show_data, init_and_make_win)
2200         (show_source_or_disasm_and_command): Update.
2201         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2202         method.
2203         <can_highight, is_highlighted>: Now bool.
2204         (tui_set_win_highlight): Don't declare.
2205         * tui/tui-data.c (tui_set_win_highlight): Remove.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-wingeneral.c (make_visible): Remove check of window
2210         type.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-win.c (tui_win_info::max_height)
2215         (tui_cmd_window::max_height): New methods.
2216         (new_height_ok): Call max_height.
2217         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2218         <max_height>: New method.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-win.c (tui_source_window_base::set_new_height)
2223         (tui_data_window::set_new_height): New methods.
2224         (make_invisible_and_set_new_height): Call set_new_height method.
2225         * tui/tui-data.h (struct tui_win_info)
2226         (struct tui_source_window_base, struct tui_data_window)
2227         <set_new_height>: New method.
2228
2229 2019-06-25  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2232         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2233         tui_refresh_data_win.
2234         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2235         method.
2236         (tui_refresh_all_win): Call the refresh_all method.
2237         (tui_set_focus): Likewise.
2238         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2239         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2240         Likewise.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.h (tui_refill_source_window)
2245         (tui_set_is_exec_point_at): Don't declare.
2246         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2247         (tui_source_window_base::refill): Rename from
2248         tui_refill_source_window.
2249         (tui_source_window_base::do_scroll_horizontal): Update.
2250         (tui_source_window_base::set_is_exec_point_at): Rename from
2251         tui_set_is_exec_point_at.
2252         (tui_update_all_breakpoint_info): Update.
2253         * tui/tui-stack.c (tui_show_frame_info): Update.
2254         * tui/tui-layout.c (show_data): Add cast.
2255         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2256         * tui/tui-data.h (struct tui_source_window_base) <refill,
2257         set_is_exec_point_at>: New methods.
2258         (tui_source_windows, tui_add_to_source_windows): Update types.
2259         (tui_add_to_source_windows): Remove redundant declaration.
2260         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2261         (tui_source_windows): Change return type.
2262         (tui_clear_source_windows_detail): Update.
2263         (tui_add_to_source_windows): Change type of parameter.
2264         (tui_free_all_source_wins_content): Update.
2265
2266 2019-06-25  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-wingeneral.c (tui_win_info::refresh)
2269         (tui_source_window_base::refresh): New methods.
2270         (tui_refresh_all): Call the refresh method.
2271         * tui/tui-data.h (struct tui_win_info)
2272         (struct tui_source_window_base) <refresh>: New method.
2273
2274 2019-06-25  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui.h (tui_is_window_visible): Return bool.
2277         * tui/tui.c (tui_is_window_visible): Return bool.
2278         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2279         (tui_make_visible, tui_make_invisible)
2280         (tui_win_info::make_visible)
2281         (tui_source_window_base::make_visible, make_all_visible)
2282         (tui_make_all_visible, tui_make_all_invisible): Update.
2283         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2284         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2285         bool.
2286         (struct tui_win_info, struct tui_source_window_base)
2287         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2288         * tui/tui-data.c (tui_init_generic_part): Update.
2289
2290 2019-06-25  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2293         (tui_source_window_base::make_visible): New methods.
2294         (make_all_visible): Make method call.
2295         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2296         (struct tui_source_window_base, struct tui_cmd_window): Override
2297         make_visible.
2298         (tui_win_is_source_type): Don't declare.
2299         * tui/tui-data.c (tui_win_is_source_type): Remove.
2300
2301 2019-06-25  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2304         NULL check.
2305
2306 2019-06-25  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2309         Inline constructor.  Add initializers for members.
2310         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2311         constructors; now inline in class.
2312
2313 2019-06-25  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-regs.c (tui_show_registers): Update.
2316         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2317         bool.
2318         * tui/tui-data.c (tui_data_window::clear_detail)
2319         (tui_data_window): Update.
2320
2321 2019-06-25  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-windata.c (tui_display_all_data)
2324         (tui_display_data_from_line, tui_display_data_from)
2325         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2326         Update.
2327         * tui/tui-regs.c (tui_last_regs_line_no)
2328         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2329         (tui_show_registers, tui_show_register_group)
2330         (tui_display_registers_from, tui_display_reg_element_at_line)
2331         (tui_display_registers_from_line, tui_check_register_values)
2332         (tui_reg_next, tui_reg_prev): Update.
2333         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2334         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2335         tui_data_window.
2336         (struct tui_win_info) <detail>: Remove.  Add new fields from
2337         tui_data_info.
2338         (TUI_DATA_WIN): Add cast.
2339         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2340         (~tui_data_window): Simplify.
2341
2342 2019-06-25  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-layout.c (show_source_disasm_command)
2345         (show_source_or_disasm_and_command): Update.
2346         * tui/tui-io.c (update_cmdwin_start_line)
2347         (tui_redisplay_readline): Update.
2348         * tui/tui-data.h (struct tui_command_info): Remove.
2349         (struct tui_win_info) <detail>: Remove command_info member.
2350         (struct tui_data_window) <start_line>: New member, from
2351         tui_command_info.
2352         (TUI_CMD_WIN): Add casts.
2353
2354 2019-06-25  Tom Tromey  <tom@tromey.com>
2355
2356         * tui/tui-winsource.c (tui_update_source_window)
2357         (tui_refill_source_window)
2358         (tui_source_window_base::do_scroll_horizontal)
2359         (tui_update_breakpoint_info, tui_set_exec_info_content)
2360         (tui_show_exec_info_content, tui_erase_exec_info_content)
2361         (tui_clear_exec_info_content): Update.
2362         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2363         Update.
2364         * tui/tui-win.c (make_invisible_and_set_new_height)
2365         (make_visible_with_new_height): Update.
2366         * tui/tui-source.c (tui_set_source_content)
2367         (tui_show_symtab_source): Update.
2368         * tui/tui-layout.c (extract_display_start_addr)
2369         (show_source_disasm_command, show_data)
2370         (make_source_or_disasm_window)
2371         (show_source_or_disasm_and_command): Update.
2372         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2373         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2374         "gdbarch".
2375         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2376         to tui_source_window_base.
2377         (struct tui_win_info) <detail>: Remove source_info member.
2378         (struct tui_source_window_base) <has_locator>: Inline.
2379         Move contents from tui_source_info; rename has_locator member to
2380         m_has_locator.
2381         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2382         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2383         header file.
2384         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2385         Simplify.
2386         (tui_free_all_source_wins_content): Cast to
2387         tui_source_window_base.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-win.c (make_invisible_and_set_new_height)
2392         (make_visible_with_new_height): Call has_locator method.
2393         * tui/tui-layout.c (show_source_disasm_command, show_data)
2394         (show_source_or_disasm_and_command): Update for bool change.
2395         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2396         (tui_win_info) <has_locator>: New method.
2397         (struct tui_source_window_base) <has_locator>: New method.
2398         (tui_win_has_locator): Don't declare.
2399         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2400         from tui_win_has_locator.
2401         (tui_source_window_base): Use false, not FALSE.
2402
2403 2019-06-25  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2406         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2407         clear_detail method directly.
2408         (tui_clear_win_detail): Remove.
2409
2410 2019-06-25  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2413         "this", not TUI_DISASM_WIN.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2418         declare.
2419         * tui/tui-winsource.c
2420         (tui_source_window_base::do_scroll_horizontal): Rename from
2421         tui_horizontal_source_scroll.
2422         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2423         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2424         from tui_vertical_data_scroll.
2425         * tui/tui-win.h (tui_scroll): Don't declare.
2426         * tui/tui-win.c (tui_win_info::forward_scroll)
2427         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2428         (tui_win_info::right_scroll): Rename and update.
2429         (tui_scroll_forward_command, tui_scroll_backward_command)
2430         (tui_scroll_left_command, tui_scroll_right_command): Update.
2431         (tui_scroll): Remove.
2432         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2433         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2434         from tui_vertical_source_scroll.
2435         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2436         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2437         from tui_vertical_disassem_scroll.
2438         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2439         do_scroll_horizontal>: New methods.
2440         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2441         Likewise.
2442         (struct tui_source_window_base): Add do_scroll_horizontal.
2443         (struct tui_source_window, struct tui_disasm_window): Add
2444         do_scroll_vertical.
2445         (struct tui_data_window, struct tui_cmd_window): Add
2446         do_scroll_horizontal and do_scroll_vertical.
2447         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2448
2449 2019-06-25  Tom Tromey  <tom@tromey.com>
2450
2451         * tui/tui-data.h (struct tui_source_window_base): New struct.
2452         (struct tui_source_window): Derive from tui_source_window_base.
2453         (struct tui_disasm_window): New struct.
2454         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2455         from tui_source_window::clear_detail.
2456         (tui_source_window_base): Rename from tui_source_window.
2457         (~tui_source_window_base): Rename from ~tui_source_window.
2458         (tui_alloc_win_info): Create a tui_disasm_window.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-data.h (struct tui_source_window)
2463         (struct tui_data_window): Declare destructors.
2464         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2465         destructors.
2466         (tui_win_info): Simplify.
2467
2468 2019-06-25  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-winsource.c (tui_display_main)
2471         (tui_update_source_windows_with_addr)
2472         (tui_update_all_breakpoint_info): Update.
2473         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2474         (new_height_ok, parse_scrolling_args): Update.
2475         * tui/tui-stack.c (tui_show_frame_info): Update.
2476         * tui/tui-data.h (struct tui_list): Remove.
2477         (tui_source_windows): Return a reference to a std::vector.
2478         * tui/tui-data.c (source_windows): Now a std::vector.
2479         (tui_source_windows): Change return type.
2480         (tui_clear_source_windows): Rewrite.
2481         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2482         (tui_free_all_source_wins_content): Rewrite.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2487         (struct tui_data_window, struct tui_cmd_window): Declare
2488         clear_detail method.
2489         * tui/tui-data.c (tui_source_window::clear_detail)
2490         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2491         methods.
2492         (tui_clear_win_detail): Simplify.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-layout.c (make_source_window, make_disasm_window)
2497         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2498         Return the new window.
2499         (show_source_disasm_command, show_data)
2500         (show_source_or_disasm_and_command): Update.
2501
2502 2019-06-25  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2505         parameter.  Return the new window.
2506         (show_source_disasm_command): Update and remove NULL check.
2507         (show_source_or_disasm_and_command): Update.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-data.h (struct tui_win_info): Make constructor
2516         protected.  Make destructor virtual.  Add initializers.
2517         (tui_source_window, tui_data_window, tui_cmd_window): New
2518         classes.
2519         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2520         constructor.  Add "type" parameter.
2521         (tui_source_window, tui_data_window, tui_cmd_window): New
2522         constructors.
2523         (tui_alloc_win_info): Instantiate the appropriate subclass.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-win.c (tui_resize_all): Use delete.
2528         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2529         destructor.
2530         (tui_free_window): Don't declare.
2531         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2532         Update.
2533
2534 2019-06-25  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-data.h (struct tui_win_info): Add constructor.
2537         * tui/tui-data.c (tui_alloc_win_info): Use new.
2538         (tui_free_window): Use delete.
2539
2540 2019-06-22  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2543         declare.
2544         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2545
2546 2019-06-22  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2549         declare.
2550         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2551
2552 2019-06-22  Tom de Vries  <tdevries@suse.de>
2553
2554         * dwarf2read.c (create_addrmap_from_aranges)
2555         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2556         instead of '%zu'.
2557
2558 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2559
2560         * dwarf2read.h (dwarf2_section_info_def): Remove.
2561         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2562         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2563         std::vector<dwarf2_section_info>.
2564         (struct dwo_file) <~dwo_file>: Remove.
2565         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2566         types field.
2567         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2568         (dwarf2_read_debug_names): Likewise.
2569         (create_debug_types_hash_table): Change parameter type to
2570         array_view, adjust code accordingly.
2571         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2572         (partial_die_info::fixup): Likewise.
2573         (determine_prefix): Likewise.
2574         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2575
2576 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2577
2578         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2579         gdb_bfd_ref_ptr.
2580         <~dwo_file>: Remove call to gdb_bfd_unref.
2581         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2582         gdb_bfd_ref_ptr::get.
2583
2584 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2585
2586         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2587         type to htab_up.
2588         * dwarf2read.c (struct dwo_file): Initialize fields.
2589         <~dwo_file>: New.
2590         (free_dwo_file): Remove, move content to ~dwo_file.
2591         (struct dwo_file_deleter): Remove.
2592         (dwo_file_up>: Remove custom deleter.
2593         (free_dwo_files): Remove.
2594         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2595         dwo_files.
2596         (process_skeletonless_type_units): Call unique_ptr::get.
2597         (allocate_dwo_file_hash_table): Add deleter to created hash
2598         table.  Change return type to htab_up.
2599         (lookup_dwo_file_slot): Don't memset dwo_file, call
2600         unique_ptr::get.
2601         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2602         (create_dwo_unit_in_dwp_v2): Likewise.
2603         (open_and_init_dwo_file): Likewise.
2604         (free_dwo_file_from_slot): Remove.
2605
2606 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2607
2608         * dwarf2read.h (struct dwarf2_section_info) <readin,
2609         is_virtual>: Change type to bool.
2610         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2611         true instead of 1.
2612
2613 2019-06-19  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-data.h (tui_init_content_element): Don't declare.
2616
2617 2019-06-19  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-data.h (tui_init_win_info): Don't declare.
2620
2621 2019-06-19  Tom de Vries  <tdevries@suse.de>
2622
2623         * dwarf2read.h (abstract_to_concrete): Change type to
2624         std::unordered_map<sect_offset, std::vector<sect_offset>,
2625         gdb::hash_enum<sect_offset>>.
2626
2627 2019-06-19  Tom Tromey  <tromey@adacore.com>
2628
2629         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2630         EVAL_AVOID_SIDE_EFFECTS specially.
2631
2632 2019-06-19  Tom Tromey  <tromey@adacore.com>
2633
2634         * source-cache.c (highlighter): New global.
2635         (source_cache::get_source_lines): Create a highlighter on demand.
2636
2637 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * defs.h (deprecated_interactive_hook): Delete declaration.
2640         * interps.c (clear_interpreter_hooks): Remove use of
2641         deprecated_interactive_hook.
2642         * top.c (deprecated_interactive_hook): Delete definition.
2643         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2644
2645 2019-06-18  Tom de Vries  <tdevries@suse.de>
2646
2647         PR gdb/24515
2648         * dwarf2read.h (abstract_to_concrete): Change type from
2649         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2650         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2651         * dwarf2read.c (read_variable): Update.
2652         (dwarf2_fetch_die_loc_sect_off): Update.
2653
2654 2019-06-17  Tom de Vries  <tdevries@suse.de>
2655
2656         PR gdb/24617
2657         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2658         accessing parent[parent_len - 1].
2659
2660 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2661
2662         PR gdb/24364
2663         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2664         call dtrace_process_dof with NULL dof.
2665
2666 2019-06-16  Tom de Vries  <tdevries@suse.de>
2667
2668         PR gdb/24445
2669         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2670
2671 2019-06-16  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2674         (make_all_visible): Use address of member.
2675
2676 2019-06-16  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2679         (tui_free_window, free_content, free_content_elements): Remove
2680         unnecessary cast.
2681         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2682         cast.
2683         * tui/tui-regs.c (tui_show_register_group)
2684         (tui_display_registers_from, tui_display_reg_element_at_line):
2685         Remove unnecessary cast.
2686
2687 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2688
2689         * linux-nat.c (normal_mask): Delete.
2690         (_initialize_linux_nat): Don't initialise normal_mask.
2691
2692 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2693
2694         PR gdb/24445
2695         * dwarf-index-write.h (write_psymtabs_to_index): Add
2696         dwz_basename parameter.
2697         * dwarf-index-write.c (write_gdbindex): Move file writing to
2698         write_gdbindex_1.  Change return type void.
2699         (assert_file_size): Move up, remove filename parameter.
2700         (write_gdbindex_1): New function.
2701         (write_debug_names): Change return type to void, call
2702         assert_file_size.
2703         (struct index_wip_file): New struct.
2704         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2705         file logic to index_wip_file.  Write index for dwz file if
2706         needed.
2707         (save_gdb_index_command): Pass basename of dwz file, if present.
2708         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2709         build-id of dwz file, if present.
2710         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2711         (dwarf2_get_dwz_file): Likewise.
2712         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2713         (dwarf2_get_dwz_file): Likewise.
2714
2715 2019-06-16  Tom Tromey  <tom@tromey.com>
2716
2717         * coffread.c (process_coff_symbol): Use xstrdup.
2718         * value.c (create_internalvar): Use xstrdup.
2719
2720 2019-06-16  Tom Tromey  <tom@tromey.com>
2721
2722         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2723         * breakpoint.c (stopin_command, stopat_command)
2724         (until_break_command, decode_location_default): Remove unnecessary
2725         cast.
2726         * utils.c (subset_compare): Remove unnecessary cast.
2727         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2728         cast.
2729         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2730         cast.
2731         * infcmd.c (path_command): Remove unnecessary cast.
2732         * coffread.c (decode_type): Remove unnecessary cast.
2733         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2734         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2735         * tui/tui-stack.c (tui_show_locator_content)
2736         (tui_show_frame_info): Remove unnecessary cast.
2737         * tui/tui-win.c (tui_scroll_forward_command)
2738         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2739         (parse_scrolling_args): Remove unnecessary cast.
2740         * tui/tui-data.c (init_win_info, tui_del_window)
2741         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2742         (free_content_elements): Remove unnecessary cast.
2743         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2744         unnecessary cast.
2745         * tui/tui-source.c (tui_set_source_content)
2746         (tui_vertical_source_scroll): Remove unnecessary cast.
2747         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2748         cast.
2749         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2750         * tui/tui-regs.c (tui_display_registers_from)
2751         (tui_display_register): Remove unnecessary cast.
2752         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2753         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2754         (make_visible): Remove unnecessary cast.
2755         * tui/tui-winsource.c (tui_erase_source_content)
2756         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2757         unnecessary cast.
2758         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2759         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2760         * stabsread.c (read_type, read_array_type, read_range_type):
2761         Remove unnecessary cast.
2762         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2763         (parse_symbol, parse_type, upgrade_type, parse_external)
2764         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2765         unnecessary cast.
2766         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2767
2768 2019-06-16  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-data.c (tui_alloc_generic_win_info)
2771         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2772         checks.
2773
2774 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2775             Andrew Burgess  <andrew.burgess@embecosm.com>
2776
2777         * f-typeprint.c (f_print_type): Don't return early for not
2778         associated or not allocated types.
2779         (f_type_print_varspec_suffix): Add print_rank parameter and print
2780         ranks of array types in case they dangling.
2781         (f_type_print_base): Add print_rank parameter.
2782
2783 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2784
2785         * NEWS: Mention new MI commands.
2786         * break-catch-throw.c (enum exception_event_kind): Move to
2787         breakpoint.h.
2788         (print_mention_exception_catchpoint): Output text as a single
2789         message.
2790         (catch_exception_command_1): Rename to...
2791         (catch_exception_event): ...this, make non-static, update header
2792         command, and change some parameter types.
2793         (catch_catch_command): Update for changes to
2794         catch_exception_command_1.
2795         (catch_throw_command): Likewise.
2796         (catch_rethrow_command): Likewise.
2797         * breakpoint.c (enum exception_event_kind): Delete.
2798         * breakpoint.h (enum exception_event_kind): Moved here from
2799         break-catch-throw.c.
2800         (catch_exception_event): Declare.
2801         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2802         (mi_cmd_catch_throw): New function.
2803         (mi_cmd_catch_rethrow): New function.
2804         (mi_cmd_catch_catch): New function.
2805         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2806         'catch-catch' entries.
2807         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2808         (mi_cmd_catch_rethrow): Declare.
2809         (mi_cmd_catch_catch): Declare.
2810
2811 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2812
2813         * annotate.c (annotate_source_line): Change return type to void,
2814         update implementation to match.
2815         * annotate.h (annotate_source_line): Change return type to void,
2816         update header comment.
2817         * stack.c (print_frame_info): Don't change what frame information
2818         is printed based on whether annotations are on or not.
2819
2820 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2823         (annotate_source): Make static.
2824         (annotate_source_line): Moved from source.c and renamed from
2825         identify_source_line.  Update the return type.
2826         * annotate.h (annotate_source): Delete declaration.
2827         (annotate_source_line): Declaration moved from source.h, and
2828         renamed from identify_source_line.  Return type updated.
2829         * source.c (identify_source_line): Moved to annotate.c and renamed
2830         to annotate_source_line.
2831         (info_line_command): Remove check of annotation_level.
2832         * source.h (identify_source_line): Move declaration to annotate.h
2833         and rename to annotate_source_line.
2834         * stack.c: Add 'annotate.h' include.
2835         (print_frame_info): Remove check of annotation_level before
2836         calling annotate_source_line.
2837
2838 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * source-cache.c (source_cache::get_plain_source_lines): Use
2841         open_source_file_with_line_charpos instead of just
2842         open_source_file, remove call to find_source_lines.
2843         (source_cache::get_source_lines): Likewise.
2844         * source.c (find_source_lines): Make static.
2845         (get_filename_and_charpos): Renamed into...
2846         (open_source_file_with_line_charpos): ..this along with changes to
2847         return a scoped_fd, and some other minor clean ups.
2848         (identify_source_line): Use open_source_file_with_line_charpos.
2849         (search_command_helper): Use open_source_file_with_line_charpos
2850         instead of just open_source_file, remove call to
2851         find_source_lines.
2852         * source.h (open_source_file_with_line_charpos): Declare new
2853         function.
2854         (find_source_lines): Delete declaration.
2855
2856 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2857
2858         * source.c (get_filename_and_charpos): Remove fullname
2859         parameter.
2860         (identify_source_line): Update call to get_filename_and_charpos.
2861
2862 2019-06-14  Tom Tromey  <tromey@adacore.com>
2863
2864         PR gdb/24502:
2865         * ui-style.h (skip_ansi_escape): Update comment.
2866         * ui-file.h (class no_terminal_escape_file): New class.
2867         * ui-file.c (no_terminal_escape_file::write)
2868         (no_terminal_escape_file::puts): New methods.
2869         * cli/cli-logging.c (handle_redirections): Use
2870         no_terminal_escape_file.
2871
2872 2019-06-14  Tom Tromey  <tromey@adacore.com>
2873
2874         * NEWS: Move convenience variable news above Python news.
2875
2876 2019-06-14  Tom Tromey  <tom@tromey.com>
2877
2878         * gnulib: Move directory to top-level.
2879         * configure.ac: Don't configure gnulib.
2880         * configure: Rebuild.
2881         * common/common-defs.h: Use new path to gnulib.
2882         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2883         (GNULIB_H): Remove.
2884         (INCGNU): Look in new gnulib location.
2885         (HFILES_NO_SRCDIR): Remove gnulib files.
2886         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2887         (generated_files): Remove GNULIB_H.
2888         ($(LIBGNU), all-lib): Remove targets.
2889         (distclean): Don't mention GNULIB_BUILDDIR.
2890         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2891
2892 2019-06-14  Tom Tromey  <tromey@adacore.com>
2893
2894         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2895         Warn if symbol file does not provide any symbols.
2896
2897 2019-06-14  Tom Tromey  <tromey@adacore.com>
2898
2899         * source.c (find_and_open_source): Respect basenames_may_differ.
2900
2901 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * annotate.c (annotate_breakpoints_invalid): Make use of
2904         scoped_restore_terminal_state.
2905         (annotate_frames_invalid): Likewise.
2906
2907 2019-06-14  Tom Tromey  <tromey@adacore.com>
2908
2909         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2910         allow assignment to an internalvar.
2911
2912 2019-06-14  Tom Tromey  <tromey@adacore.com>
2913
2914         * ada-lex.l: Allow "_" in attribute names.
2915
2916 2019-06-14  Tom Tromey  <tromey@adacore.com>
2917
2918         PR gdb/24653:
2919         * regcache.c (registers_changed): Don't call alloca.
2920         * top.c (execute_command): Don't call alloca.
2921
2922 2019-06-13  Pedro Alves  <palves@redhat.com>
2923
2924         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2925         'expression'.  When parsing an expression, error out if there's
2926         junk after "unlimited".
2927         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2928         (do_set_command): Adjust calls to is_unlimited_literal.
2929
2930 2019-06-13  Pedro Alves  <palves@redhat.com>
2931
2932         * compile/compile.c (make_compile_options_def_group): Add braces
2933         around array_view initializer.
2934         * thread.c (make_thread_apply_all_options_def_group)
2935         (make_thread_apply_all_options_def_group): Likewise.
2936
2937 2019-06-13  Pedro Alves  <palves@redhat.com>
2938
2939         * NEWS (New commands): Mention "maint test-options
2940         require-delimiter", "maint test-options unknown-is-error", "maint
2941         test-options unknown-is-operand" and "maint show
2942         test-options-completion-result".
2943         (New command options, command completion): New section.
2944         (Completion improvements): New section.
2945         Mention that you can abbreviate "unlimited".
2946
2947 2019-06-13  Pedro Alves  <palves@redhat.com>
2948
2949         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2950         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2951         * unittests/cli-utils-selftests.c (test_parse_flags)
2952         (test_parse_flags_qcs): Delete.
2953         (test_cli_utils): Don't call deleted functions.
2954
2955 2019-06-13  Pedro Alves  <palves@redhat.com>
2956
2957         * thread.c: Include "cli/cli-option.h".
2958         (tp_array_compar_ascending): Global.
2959         (tp_array_compar): Delete function.
2960         (tp_array_compar_ascending, tp_array_compar_descending): New
2961         functions.
2962         (ascending_option_def, qcs_flag_option_def)
2963         (thr_qcs_flags_option_defs)
2964         (make_thread_apply_all_options_def_group)
2965         (make_thread_apply_options_def_group): New.
2966         (thread_apply_all_command): Use gdb::option::process_options.
2967         (thread_apply_command_completer)
2968         (thread_apply_all_command_completer): New.
2969         (thread_apply_command): Use gdb::option::process_options.
2970         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2971         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2972         to generate help text of "thread apply".  Adjust "taas"'s help.
2973         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2974         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2975
2976 2019-06-13  Pedro Alves  <palves@redhat.com>
2977
2978         * thread.c (thread_apply_command): Check for invalid TID with
2979         isdigit instead of !isalpha.
2980
2981 2019-06-13  Pedro Alves  <palves@redhat.com>
2982
2983         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2984         (validate_flags_qcs): New.
2985         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2986         (validate_flags_qcs): Declare.
2987         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2988         (make_frame_apply_options_def_group): New.
2989         (frame_apply_command_count): Process options with
2990         gdb::option::process_options.
2991         (frame_apply_completer): New.
2992         (frame_apply_level_completer, frame_apply_all_completer)
2993         (frame_apply_completer): New.
2994         (_initialize_stack): Update help of "frame apply", "frame apply
2995         level", "frame apply all" and "faas" to mention supported options
2996         and install command completers.
2997         * stack.h (frame_apply_all_completer): Declare.
2998         * thread.c: Include "stack.h".
2999         (tfaas_command): Add "--".
3000         (_initialize_thread): Update help "tfaas" to mention supported
3001         options and install command completer.
3002
3003 2019-06-13  Pedro Alves  <palves@redhat.com>
3004
3005         * completer.c (complete_nested_command_line): New.
3006         (gdb_completion_word_break_characters_throw): Add assertion.
3007         * completer.h (complete_nested_command_line): Declare.
3008
3009 2019-06-13  Pedro Alves  <palves@redhat.com>
3010
3011         * stack.c (parse_backtrace_qualifiers): New.
3012         (backtrace_command): Use it.
3013         (backtrace_command_completer): Complete on qualifiers.
3014
3015 2019-06-13  Pedro Alves  <palves@redhat.com>
3016
3017         * frame.c: Include "cli/cli-option.h.
3018         (user_set_backtrace_options): New.
3019         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3020         Delete.
3021         (get_prev_frame): Adjust.
3022         (boolean_option_def, uinteger_option_def)
3023         (set_backtrace_option_defs): New.
3024         (_initialize_frame): Adjust and use
3025         gdb::option::add_setshow_cmds_for_options to install "set
3026         backtrace past-main" and "set backtrace past-entry".
3027         * frame.h: Include "cli/cli-option.h".
3028         (struct frame_print_options): Forward declare.
3029         (print_frame_arguments_all, print_frame_arguments_scalars)
3030         (print_frame_arguments_none): Declare.
3031         (print_entry_values): Delete declaration.
3032         (struct frame_print_options, user_frame_print_options): New.
3033         (struct set_backtrace_options): New.
3034         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3035         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3036         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3037         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3038         (list_args_or_locals): Add frame_print_options parameter.
3039         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3040         * python/py-framefilter.c (enumerate_args): Pass down
3041         USER_FRAME_PRINT_OPTIONS.
3042         * stack.c: Include "cli/cli-option.h".
3043         (print_frame_arguments_all, print_frame_arguments_scalars)
3044         (print_frame_arguments_none): Declare.
3045         (print_raw_frame_arguments, print_entry_values): Delete.
3046         (user_frame_print_options): New.
3047         (boolean_option_def, enum_option_def, frame_print_option_defs):
3048         New.
3049         (struct backtrace_cmd_options): New.
3050         (bt_flag_option_def): New.
3051         (backtrace_command_option_defs): New.
3052         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3053         (print_frame_arg, read_frame_arg, print_frame_args)
3054         (print_frame_info, print_frame): Add frame_print_options parameter
3055         and use it.
3056         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3057         (backtrace_command_1): Add frame_print_options and
3058         backtrace_cmd_options parameters and use them.
3059         (make_backtrace_options_def_group): New.
3060         (backtrace_command): Process command options with
3061         gdb::option::process_options.
3062         (backtrace_command_completer): New.
3063         (_initialize_stack): Extend "backtrace"'s help to mention
3064         supported options.  Install completer for "backtrace".
3065         Install some settings commands with add_setshow_cmds_for_options.
3066
3067 2019-06-13  Pedro Alves  <palves@redhat.com>
3068
3069         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3070         and that "set/show print raw frame-arguments" are now deprecated.
3071
3072         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3073         command.
3074         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3075         * stack.c (_initialize_stack): Install "set/show print
3076         raw-frame-arguments", and deprecate "set/show print raw
3077         frame-arguments".
3078         * valprint.c (_initialize_valprint): Deprecate "set/show print
3079         raw".
3080
3081 2019-06-13  Pedro Alves  <palves@redhat.com>
3082
3083         * compile/compile.c (struct compile_options): New.
3084         (compile_flag_option_def, compile_command_option_defs)
3085         (make_compile_options_def_group): New.
3086         (compile_file_command): Handle options with
3087         gdb::option::process_options.
3088         (compile_file_command_completer): New function.
3089         (compile_code_command): Handle options with
3090         gdb::option::process_options.
3091         (compile_code_command_completer): New function.
3092         (_initialize_compiler): Install completers for "compile code" and
3093         "compile file".  Mention available options in "compile code" and
3094         "compile code"'s help.
3095         * completer.c (advance_to_completion_word): New, factored out from
3096         ...
3097         (advance_to_expression_complete_word_point): ... this.
3098         (advance_to_filename_complete_word_point): New.
3099         * completer.h (advance_to_filename_complete_word_point): New
3100         declaration.
3101
3102 2019-06-13  Pedro Alves  <palves@redhat.com>
3103
3104         * compile/compile.c: Include "cli/cli-option.h".
3105         (compile_print_value): Scope data pointer is now a
3106         value_print_options pointer; adjust.
3107         (compile_print_command): Process options.  Scope data pointer is
3108         now a value_print_options pointer; adjust.
3109         (_initialize_compile): Update "compile print"'s help to include
3110         supported options.  Install a completer for "compile print".
3111         * cp-valprint.c (show_vtblprint, show_objectprint)
3112         (show_static_field_print): Delete.
3113         (_initialize_cp_valprint): Don't install "set print
3114         static-members", "set print vtbl", "set print object" here.
3115         * printcmd.c: Include "cli/cli-option.h" and
3116         "common/gdb_optional.h".
3117         (print_command_parse_format): Rework to fill in a
3118         value_print_options instead of a format_data.
3119         (print_value): Change parameter type from format_data pointer to
3120         value_print_options reference.  Adjust.
3121         (print_command_1): Process options.  Adjust to pass down a
3122         value_print_options.
3123         (print_command_completer): New.
3124         (_initialize_printcmd): Install print_command_completer as
3125         handle_brkchars completer for the "print" command.  Update
3126         "print"'s help to include supported options.
3127         * valprint.c: Include "cli/cli-option.h".
3128         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3129         here from cp-valprint.c.
3130         (boolean_option_def, uinteger_option_def)
3131         (value_print_option_defs, make_value_print_options_def_group):
3132         New.  Use gdb::option::add_setshow_cmds_for_options to install
3133         "set print elements", "set print null-stop", "set print repeats",
3134         "set print pretty", "set print union", "set print array", "set
3135         print address", "set print symbol", "set print array-indexes".
3136         * valprint.h: Include <string> and "cli/cli-option.h".
3137         (make_value_print_options_def_group): Declare.
3138         (print_value): Change parameter type from format_data pointer to
3139         value_print_options reference.
3140         (print_command_completer): Declare.
3141
3142 2019-06-13  Pedro Alves  <palves@redhat.com>
3143
3144         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3145         (COMMON_SFILES): Add maint-test-settings.c.
3146         * cli/cli-decode.c (boolean_enums): New global, factored out from
3147         ...
3148         (add_setshow_boolean_cmd): ... here.
3149         * cli/cli-decode.h (boolean_enums): Declare.
3150         * cli/cli-option.c: New file.
3151         * cli/cli-option.h: New file.
3152         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3153         factored out from ...
3154         (parse_cli_boolean_value(const char *)): ... this.
3155         (is_unlimited_literal): Change parameter type to pointer to
3156         pointer.  Adjust and advance ARG pointer.
3157         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3158         (parse_cli_var_enum): New, factored out from ...
3159         (do_set_command): ... this.  Adjust.
3160         * cli/cli-setshow.h (parse_cli_boolean_value)
3161         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3162         (parse_cli_var_enum): Declare.
3163         * cli/cli-utils.c: Include "cli/cli-option.h".
3164         (get_ulongest): New.
3165         * cli/cli-utils.h (get_ulongest): Declare.
3166         (check_for_argument): New overloads.
3167         * maint-test-options.c: New file.
3168
3169 2019-06-13  Pedro Alves  <palves@redhat.com>
3170
3171         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3172         parse a range if "-" is at the end of the string.
3173
3174 2019-06-13  Pedro Alves  <palves@redhat.com>
3175
3176         * cli/cli-setshow.c (parse_auto_binary_operation)
3177         (parse_cli_boolean_value): Don't allow "o".
3178
3179 2019-06-13  Pedro Alves  <palves@redhat.com>
3180
3181         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3182         * NEWS: Mention maint test-settings KIND.
3183         * maint-test-settings.c: New file.
3184
3185 2019-06-13  Pedro Alves  <palves@redhat.com>
3186
3187         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3188         completer.
3189         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3190         "set" completers.
3191
3192 2019-06-13  Pedro Alves  <palves@redhat.com>
3193
3194         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3195         after item.
3196
3197 2019-06-13  Pedro Alves  <palves@redhat.com>
3198
3199         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3200
3201 2019-06-13  Pedro Alves <palves@redhat.com>
3202
3203         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3204         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3205         call.
3206         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3207         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3208         calls.
3209         (check_for_argument): Skip spaces after argument.
3210
3211 2019-06-13  Pedro Alves  <palves@redhat.com>
3212
3213         * thread.c (thread_apply_command): Adjust TID parsing.
3214         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3215         detected before end of string.
3216         (tid_is_in_list): Error out if LIST is invalid.
3217
3218 2019-06-13  Pedro Alves  <palves@redhat.com>
3219
3220         * completer.c (complete_line_internal_1): Rewind completion word
3221         point.
3222         (completion_tracker::advance_custom_word_point_by): Change
3223         parameter type to int.
3224         * completer.h (completion_tracker::advance_custom_word_point_by):
3225         Likewise.
3226
3227 2019-06-13  Pedro Alves  <palves@redhat.com>
3228
3229         * completer.c (advance_to_completion_word): Handle delimiters.
3230
3231 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3232
3233         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3234
3235 2019-06-11  Tom Tromey  <tom@tromey.com>
3236
3237         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3238         (xmalloc_failed): Move to alloc.c.
3239         * alloc.c: New file.
3240         * Makefile.in (COMMON_SFILES): Add alloc.c.
3241
3242 2019-06-11  Tom Tromey  <tom@tromey.com>
3243
3244         * nat/linux-waitpid.c: Don't include server.h.
3245         (linux_debug): Remove.
3246         (my_waitpid): Update.
3247
3248 2019-06-11  Tom Tromey  <tromey@adacore.com>
3249
3250         * infcall.c (_initialize_infcall): Remove trailing newline from
3251         help.
3252         * user-regs.c (_initialize_user_regs): Remove trailing newline
3253         from help.
3254         * typeprint.c (_initialize_typeprint): Remove trailing newline
3255         from help.
3256         * reverse.c (_initialize_reverse): Remove trailing newlines from
3257         help.
3258         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3259         from help.
3260         * language.c (add_set_language_command): Remove trailing newline
3261         from help.
3262         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3263         help.
3264         * disasm.c (_initialize_disasm): Remove trailing newline from
3265         help.
3266         * top.c (init_main): Remove trailing newline from help.
3267         * interps.c (_initialize_interpreter): Remove trailing newline
3268         from help.
3269         * btrace.c (_initialize_btrace): Remove trailing newlines from
3270         help.
3271         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3272         from help.
3273         * python/python.c (_initialize_python): Remove trailing newline
3274         from help.
3275         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3276         help.
3277         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3278         from help.  Reformat some text.
3279         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3280         from help.
3281         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3282         newline from help.
3283
3284 2019-06-11  Tom Tromey  <tromey@adacore.com>
3285
3286         * darwin-nat.c (darwin_decode_exception_message)
3287         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3288
3289 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * valops.c (value_slice): Check for not allocated or not
3292         associated values.
3293
3294 2019-06-10  Tom de Vries  <tdevries@suse.de>
3295
3296         PR gdb/24618
3297         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3298         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3299         invalid.
3300
3301 2019-06-10  Tom de Vries  <tdevries@suse.de>
3302
3303         PR gdb/24611
3304         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3305         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3306
3307 2019-06-10  Tom de Vries  <tdevries@suse.de>
3308
3309         PR symtab/24545
3310         * symtab.c (struct demangled_name_entry): Add language field.
3311         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3312         static minimal symbol".  Set and use language field.
3313
3314 2019-06-10  Tom Tromey  <tromey@adacore.com>
3315
3316         * ada-lang.c (_initialize_ada_language): Update help text.
3317
3318 2019-06-10  Tom Tromey  <tromey@adacore.com>
3319
3320         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3321         with a newline.
3322         * guile/guile.c (handle_boot_error): Don't end warning with a
3323         newline.
3324         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3325         warning with a newline.
3326         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3327         newline.
3328         (s12z_frame_cache): Likewise.
3329         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3330         a newline.
3331         * solib-svr4.c (disable_probes_interface): Don't end warning with
3332         a newline.
3333         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3334         newline.
3335         * python/python.c (do_finish_initialization): Don't end warning
3336         with a newline.
3337
3338 2019-06-10  Tom Tromey  <tom@tromey.com>
3339
3340         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3341         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3342         gdbpy_enter.
3343
3344 2019-06-10  Tom Tromey  <tromey@adacore.com>
3345
3346         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3347         data.
3348         (elf_new_init): Don't call stabsread_new_init.
3349         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3350         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3351         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3352
3353 2019-06-10  Tom de Vries  <tdevries@suse.de>
3354
3355         PR symtab/16264
3356         PR symtab/24517
3357         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3358
3359 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3360
3361         * source.c (find_and_open_source): Also rewrite relative file
3362         names.
3363
3364 2019-04-26  Amos Bird  <amosbird@gmail.com>
3365
3366         * annotate.c (annotate_thread_exited): Add "thread-exited"
3367         annotation.
3368
3369 2019-06-06  Tom Tromey  <tromey@adacore.com>
3370
3371         * maint.h (class scoped_command_stats): Use
3372         DISABLE_COPY_AND_ASSIGN.
3373         <print_time>: New method.
3374         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3375         print_time.
3376         (scoped_command_stats::print_time): New method.
3377
3378 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3381         instructions of lengths 6 or 8 bytes.
3382
3383 2019-06-04  Pedro Alves  <palves@redhat.com>
3384
3385         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3386
3387         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3388         * breakpoint.c (condition_completer): Likewise.
3389         * cli/cli-dump.c (scan_expression): Likewise.
3390         * common/filestuff.c (mkdir_recursive): Likewise.
3391         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3392         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3393         (gdb_abspath): Likewise.
3394         * compile/compile-cplus-types.c
3395         (compile_cplus_instance::decl_name): Likewise.
3396         * completer.c (complete_explicit_location):
3397         (signal_completer, reg_or_group_completer_1): Likewise.
3398         * cp-support.c (cp_remove_params_if_any): Likewise.
3399         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3400         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3401         * infcmd.c (strip_bg_char): Likewise.
3402         * linespec.c (copy_token_string): Likewise.
3403         * mi/mi-main.c (output_cores): Likewise.
3404         * psymtab.c (psymtab_search_name):
3405         * symfile.c (test_set_ext_lang_command): Likewise.
3406         * target.c (target_fileio_read_stralloc): Likewise.
3407         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3408         * value.c (complete_internalvar): Likewise.
3409
3410 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3411
3412         Add objfile property to gdb.Type.
3413         * NEWS: Mention Python API addition.
3414         * python/py-type.c (typy_get_objfile): New method.
3415
3416 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3417
3418         * NEWS: Mention the new set|show style [title|highlight].
3419         Mention changes to "show style", "help" and "apropos".
3420
3421 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3422
3423         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3424         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3425         instead of print_help_for_command.
3426         (print_doc_of_command): New function.
3427         (help_list): Add 'apropos -v word' suggestion.
3428         (print_help_for_command): Style the command name using title style.
3429         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3430         (_initialize_cli_cmds): Describe -v in apropos_command help.
3431
3432 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3433
3434         * cli/cli-style.h (cli_style_option): Add name in constructor,
3435         add m_name class member, add constructor with intensity,
3436         add name class function.
3437         (cli_style_option::add_setshow_commands): Remove name argument.
3438         (highlight_style, title_style): New styles.
3439         * cli/cli-style.c (do_show): New function that shows a style
3440         characteristic styling the style name with itself.
3441         (set_style_name): New function.
3442         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3443         Update all callers according to the changes in cli/cli-style.h.
3444         * utils.h (fputs_highlighted): New function.
3445         * utils.c (fputs_highlighted): Likewise.
3446
3447 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3448
3449         * NEWS: Mention new pipe command and new convenience variables.
3450
3451 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3452
3453         * cli/cli-cmds.c (pipe_command): New function.
3454         (_initialize_cli_cmds): Call add_com for pipe_command.
3455         Define | as an alias for pipe.
3456         (exit_status_set_internal_vars): New function.
3457         (shell_escape): Call exit_status_set_internal_vars.
3458         cli/cli-decode.c (find_command_name_length): Recognize | as
3459         a single character command.
3460
3461 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3462
3463         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3464         top.c (execute_command_to_ui_file): New function, mostly a copy
3465         of execute_command_to_string.
3466         (execute_command_to_string): Implement by calling
3467         execute_command_to_ui_file.
3468
3469 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3470
3471         * top.h (saved_command_line): Remove declaration.
3472         * top.c (previous_saved_command_line, previous_repeat_arguments):
3473         New variables.
3474         (saved_command_line): Make static, define together with other
3475         'repeat variables'.
3476         (dont_repeat): Clear repeat_arguments.
3477         (repeat_previous, get_saved_command_line, save_command_line):
3478         New functions.
3479         (gdb_init): Initialize saved_command_line
3480         and previous_saved_command_line.
3481         * main.c (captured_main_1): Remove saved_command_line initialization.
3482         * event-top.c (handle_line_of_input): Update to use
3483         the new 'repeat' related functions instead of direct access to
3484         saved_command_line.
3485         * command.h (repeat_previous, get_saved_command_line,
3486         save_command_line): New declarations.
3487         (dont_repeat): Add comment.
3488
3489 2019-05-30  Tom Tromey  <tromey@adacore.com>
3490
3491         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3492         Fix comment.
3493         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3494
3495 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3496
3497         PR cli/24587
3498         * completer.c (complete): Initialize variable word.
3499
3500 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3501
3502         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3503         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3504         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3505         'body' is NULL to the outter 'if', protecting the '!is_define'
3506         situation as well.
3507
3508 2019-05-29  Tom Tromey  <tromey@adacore.com>
3509
3510         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3511         (dwarf_unknown): New function.
3512         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3513         (dwarf_type_encoding_name): Use dwarf_unknown.
3514
3515 2019-05-29  Tom Tromey  <tromey@adacore.com>
3516
3517         PR c++/20020:
3518         * cp-valprint.c (cp_print_value_fields): Call
3519         cp_print_static_field inside "try".
3520
3521 2019-05-29  Tom Tromey  <tromey@adacore.com>
3522
3523         * inflow.c (struct terminal_info): Add default operator=.
3524         * configure: Rebuild.
3525         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3526         -Wdeprecated-copy-dtor, -Wredundant-move.
3527
3528 2019-05-29  Tom Tromey  <tromey@adacore.com>
3529
3530         * NEWS: Add entry.
3531         * infcmd.c (print_return_value_1): Handle finish_print
3532         option.
3533         (show_print_finish): New function.
3534         (_initialize_infcmd): Add "set/show print finish" commands.
3535         * valprint.c (user_print_options): Initialize new member.
3536         * valprint.h (struct value_print_options) <finish_print>: New
3537         member.
3538
3539 2019-05-28  Tom Tromey  <tromey@adacore.com>
3540
3541         * ada-lang.c (ada_remove_Xbn_suffix)
3542         (find_old_style_renaming_symbol)
3543         (parse_old_style_renaming): Remove.
3544         (ada_find_renaming_symbol): Don't call
3545         find_old_style_renaming_symbol.
3546         (ada_is_renaming_symbol): Rename from
3547         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3548         bool.  Now static.
3549         (ada_read_var_value): Update and simplify.
3550         * ada-exp.y (write_var_or_type): Remove old code.
3551
3552 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3553
3554         * event-top.c: Remove include comment.
3555         * inflow.c (class scoped_ignore_sigttou): Move from here...
3556         * inflow.h (class scoped_ignore_sigttou): ...to here.
3557         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3558         * top.c:  Remove include comment.
3559
3560 2019-05-27  Tom Tromey  <tom@tromey.com>
3561
3562         * NEWS: Fix typo.
3563
3564 2019-05-22  Tom Tromey  <tromey@adacore.com>
3565
3566         * target.c (target_follow_exec): Constify parameter.
3567         * target-delegates.c: Rebuild.
3568         * remote.c (remote_target::follow_exec): Constify parameter.
3569         * infrun.c (follow_exec): Constify parameter.
3570         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3571         (target_follow_exec): Likewise.
3572
3573 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3574
3575         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3576         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3577
3578 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3579
3580         * NEWS: Add debugredirect and testsuite sections.
3581
3582 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3583
3584         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3585         target descriptions using exclusively floating point register name
3586         aliases.
3587
3588 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         PR gdb/18644:
3591         * f-lang.c (build_fortran_types): Handle the case where
3592         gdbarch_floatformat_for_type returns a nullptr.
3593
3594 2019-05-21  Tom de Vries  <tdevries@suse.de>
3595
3596         PR cli/24587
3597         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3598
3599 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         PR gdb/18644:
3602         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3603         16-byte floats.
3604         * i386-tdep.c (i386_floatformat_for_type): Use
3605         floatformats_ia64_quad for the 16-byte floating point component
3606         within a fortran 32-byte complex number.
3607
3608 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3609
3610         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3611         delete default constructor.
3612         (find_partial_die): Update to return const struct.
3613         (partial_die_parent_scope): Move variable declaration into scope
3614         of its use and change its type to auto.
3615         (guess_partial_die_structure_name): Likewise.
3616         (partial_die_info::fixup): Likewise.
3617
3618 2019-05-17  Tom Tromey  <tromey@adacore.com>
3619
3620         * source.c (find_and_open_source): Remove cast.
3621
3622 2019-05-17  Tom Tromey  <tromey@adacore.com>
3623
3624         * annotate.c (annotate_source): Make "filename" const.
3625         * annotate.h (annotate_source): Use const.
3626
3627 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3628
3629         * disasm.c (set_disassembler_options): Send errors to stderr.
3630
3631 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3632
3633         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3634         (cli_interp_base::set_logging): Check debug_redirect.
3635         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3636         * cli/cli-logging.c (debug_redirect): Add static variable.
3637         (pop_output_files): Add default param.
3638         (handle_redirections): Print debug setting.
3639         (show_logging_command): Likewise.
3640         (_initialize_cli_logging): Add debugredirect command.
3641         * interps.c (current_interp_set_logging): Add debug_redirect
3642         parameter.
3643         * interps.h (set_logging): Add debug_redirect parameter.
3644         (current_interp_set_logging): Likewise.
3645         * mi/mi-common.h: Likewise.
3646         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3647
3648 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3649             Tom Tromey  <tromey@adacore.com>
3650
3651         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3652         directly.
3653         * cli/cli-interp.h (make_logging_output): Remove declaration.
3654         * cli/cli-logging.c (make_logging_output): Remove function.
3655         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3656         directly.
3657         * ui-file.c (tee_file::tee_file): Remove bools.
3658         (tee_file::~tee_file): Remove deletes.
3659         * ui-file.h (tee_file): Remove bools.
3660
3661 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3662
3663         * mi/mi-cmds.h (mi_cmd_complete): New function.
3664         * mi/mi-main.c (mi_cmd_complete): Likewise.
3665         * mi/mi-cmds.c: Define new MI command -complete.
3666         * NEWS: Mention new -complete command.
3667
3668 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3669
3670         * completer.h (complete): New function.
3671         * completer.c (complete): Likewise.
3672         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3673         function defined in completer.h.
3674
3675 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3676
3677         * MAINTAINERS (Write After Approval): Add myself.
3678
3679 2019-05-17  Tom de Vries  <tdevries@suse.de>
3680
3681         PR gdb/24094
3682         * dwarf2read.c (struct cu_partial_die_info): New struct.
3683         (find_partial_die): Return cu_partial_die_info.
3684         (partial_die_parent_scope, guess_partial_die_structure_name)
3685         (partial_die_info::fixup): Handle new return type of find_partial_die.
3686
3687 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3688
3689         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3690         "std::string", simplifying the algorithm.
3691
3692 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3693
3694         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3695         (stap_static_probe_ops::get_probes): Likewise.
3696
3697 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3698
3699         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3700         '-')" and "else if".
3701         (stap_parse_single_operand): Join checks for
3702         "gdbarch_stap_parse_special_token_p" and
3703         "gdbarch_stap_parse_special_token" in the same "if" statement.
3704         Invert check when verifying for operation on register
3705         displacement.
3706
3707 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3708
3709         * stap-probe.c (stap_get_opcode): Update comment.
3710         (stap_get_expected_argument_type): Likewise.
3711         (handle_stap_probe): Likewise.
3712
3713 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3714
3715         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3716         return type to 'bool'.  Adjust comment.  Use 'bool' when
3717         appropriate.
3718         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3719         * stap-probe.c (stap_parse_argument_1): Likewise.
3720         (stap_is_operator): Likewise.
3721         (stap_is_generic_prefix): Likewise.
3722         (stap_is_register_prefix): Likewise.
3723         (stap_is_register_indirection_prefix): Likewise.
3724         (stap_is_integer_prefix): Likewise.
3725         (stap_generic_check_suffix): Likewise.
3726         (stap_check_integer_suffix): Likewise.
3727         (stap_check_register_suffix): Likewise.
3728         (stap_check_register_indirection_suffix): Likewise.
3729         (stap_parse_register_operand): Likewise.
3730         (stap_parse_single_operand): Likewise.
3731         (stap_parse_argument_1): Likewise.
3732         (stap_probe::get_argument_count): Likewise.
3733         (stap_is_operator): Likewise.
3734
3735 2019-05-16  Tom Tromey  <tromey@adacore.com>
3736
3737         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3738         keyword to foreach.
3739
3740 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3741
3742         * linux-thread-db.c (try_thread_db_load_1): Change return type
3743         to bool.
3744         (try_thread_db_load): Likewise.
3745         (try_thread_db_load_from_pdir_1): Likewise.
3746         (try_thread_db_load_from_pdir): Likewise.
3747         (try_thread_db_load_from_sdir): Likewise.
3748         (try_thread_db_load_from_dir): Likewise.
3749         (thread_db_load_search): Likewise.
3750         (has_libpthread): Likewise.
3751         (thread_db_load): Likewise.
3752
3753 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3754
3755         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3756         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3757         NULL, and complain/return if that's the case.
3758
3759 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3760
3761         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3762         (advance, posn, abstract_read_memory): New functions.
3763         [struct mem_read_abstraction]: New struct.
3764         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3765
3766 2019-05-14  Tom Tromey  <tromey@adacore.com>
3767
3768         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3769         value is not lval_memory.
3770
3771 2019-05-14  Tom Tromey  <tromey@adacore.com>
3772
3773         * solib.c (info_sharedlibrary_command): Style the file name.
3774
3775 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3776
3777         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3778         (aarch64_vnv_type): Likewise.
3779         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3780         * common/tdesc.c: Likewise.
3781         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3782         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3783         * features/aarch64-fpu.xml: Add ieee half view.
3784         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3785         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3786         * gdbtypes.h (struct builtin_type): Likewise.
3787         (struct objfile_type): Likewise.
3788
3789 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3790
3791         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3792         typo.
3793         * location.h (string_to_event_location): Likewise.
3794
3795 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3796
3797         GDB 8.3 released.
3798
3799 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3800
3801         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3802         New variable declaration.
3803         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3804         New variable.
3805         (print_one_breakpoint): Use ui_out::test_flags and new global
3806         variable to compute use_fixed_output.
3807         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3808         Remove.
3809         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3810         (mi_multi_location_breakpoint_output_fixed): Remove.
3811         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3812         new variable.
3813         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3814         fix_multi_location_breakpoint_output flag if version >= 3.
3815         * ui-out.h (enum ui_out_flag)
3816         <fix_multi_location_breakpoint_output>: New enumerator.
3817
3818 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3819
3820         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3821
3822 2019-05-10  Tom Tromey  <tromey@adacore.com>
3823
3824         * ada-lang.c (catch_ada_completer): New function.
3825         (_initialize_ada_language): Use it.
3826
3827 2019-05-10  Tom Tromey  <tromey@adacore.com>
3828
3829         * thread.c (print_thread_info): Make "requested_threads" const.
3830         * gdbthread.h (print_thread_info): Make "requested_threads"
3831         const.
3832         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3833         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3834
3835 2019-05-08  Tom Tromey  <tom@tromey.com>
3836
3837         * gdbtypes.c (objfile_type_data): Change type.
3838         (objfile_type, _initialize_gdbtypes): Update.
3839
3840 2019-05-08  Tom Tromey  <tom@tromey.com>
3841
3842         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3843         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3844         (_initialize_dwarf2_frame): Update.
3845
3846 2019-05-08  Tom Tromey  <tom@tromey.com>
3847
3848         * objc-lang.c (objc_objfile_data): Change type.
3849         (find_methods): Update.
3850         (_initialize_objc_lang): Remove.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * stabsread.c (rs6000_builtin_type_data): Change type.
3855         (rs6000_builtin_type, _initialize_stabsread): Update.
3856
3857 2019-05-08  Tom Tromey  <tom@tromey.com>
3858
3859         * mips-tdep.c (mips_pdr_data): Remove.
3860         (_initialize_mips_tdep): Update.
3861
3862 2019-05-08  Tom Tromey  <tom@tromey.com>
3863
3864         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3865         (hppa_init_objfile_priv_data, read_unwind_info)
3866         (find_unwind_entry, _initialize_hppa_tdep): Update.
3867
3868 2019-05-08  Tom Tromey  <tom@tromey.com>
3869
3870         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3871         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3872         on obstack.
3873         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3874
3875 2019-05-08  Tom Tromey  <tom@tromey.com>
3876
3877         * mdebugread.c (basic_type_data): Change type.
3878         (basic_type, _initialize_mdebugread): Update.
3879
3880 2019-05-08  Tom Tromey  <tom@tromey.com>
3881
3882         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3883
3884 2019-05-08  Tom Tromey  <tom@tromey.com>
3885
3886         * nto-tdep.c (nto_inferior_data_reg): Change type.
3887         (nto_inferior_data): Update.
3888         (nto_inferior_data_cleanup, nto_new_inferior_data)
3889         (_initialize_nto_tdep): Remove.
3890         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * ada-lang.c (struct ada_inferior_data): Add initializers.
3895         (ada_inferior_data): Change type.
3896         (ada_inferior_data_cleanup): Remove.
3897         (get_ada_inferior_data, ada_inferior_exit)
3898         (struct ada_pspace_data): Add initializers, destructor.
3899         (ada_pspace_data_handle): Change type.
3900         (get_ada_pspace_data): Update.
3901         (ada_pspace_data_cleanup): Remove.
3902
3903 2019-05-08  Tom Tromey  <tom@tromey.com>
3904
3905         * coffread.c (struct coff_symfile_info): Add initializers.
3906         (coff_objfile_data_key): Move lower.  Change type.
3907         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3908         Update.
3909         (coff_free_info): Remove.
3910
3911 2019-05-08  Tom Tromey  <tom@tromey.com>
3912
3913         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3914         (fbsd_pspace_data_handle): Move lower.  Change type.
3915         (get_fbsd_pspace_data): Update.
3916         (fbsd_pspace_data_cleanup): Remove.
3917         (_initialize_fbsd_tdep): Update.
3918
3919 2019-05-08  Tom Tromey  <tom@tromey.com>
3920
3921         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3922         (get_ada_tasks_pspace_data): Update.
3923         (ada_tasks_pspace_data_cleanup): Remove.
3924         (_initialize_tasks): Update.
3925         (ada_tasks_inferior_data_handle): Change type.
3926         (get_ada_tasks_inferior_data): Update.
3927         (ada_tasks_inferior_data_cleanup): Remove.
3928         (struct ada_tasks_pspace_data): Add initializers.
3929
3930 2019-05-08  Tom Tromey  <tom@tromey.com>
3931
3932         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3933         * symfile-debug.c (debug_sym_get_probes): Change type.
3934         * stap-probe.c (handle_stap_probe):
3935         (stap_static_probe_ops::get_probes): Change type.
3936         * probe.h (class static_probe_ops) <get_probes>: Change type.
3937         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3938         (parse_probes_in_pspace): Update.
3939         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3940         Update.
3941         (any_static_probe_ops::get_probes): Change type.
3942         * elfread.c (elfread_data): New typedef.
3943         (probe_key): Change type.
3944         (elf_get_probes): Likewise.  Update.
3945         (probe_key_free): Remove.
3946         (_initialize_elfread): Update.
3947         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3948         Change type.
3949         (dtrace_process_dof_probe, dtrace_process_dof)
3950         (dtrace_static_probe_ops::get_probe): Change type.
3951
3952 2019-05-08  Tom Tromey  <tom@tromey.com>
3953
3954         * xcoffread.c (struct xcoff_symfile_info): Rename from
3955         coff_symfile_info.  Add initializers.
3956         (xcoff_objfile_data_key): Move lower.  Change type.
3957         (XCOFF_DATA): Rewrite.
3958         (xcoff_free_info): Remove.
3959         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3960         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3961         (xcoff_initial_scan): Update.
3962
3963 2019-05-08  Tom Tromey  <tom@tromey.com>
3964
3965         * solib-svr4.c (struct svr4_info): Add initializers and
3966         destructor.
3967         <probes_table>: Now an htab_up.
3968         (solib_svr4_pspace_data): Change type.
3969         (free_probes_table): Simplify.
3970         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3971         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3972         (probes_table_remove_objfile_probes, register_solib_event_probe)
3973         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3974         (_initialize_svr4_solib): Update.
3975
3976 2019-05-08  Tom Tromey  <tom@tromey.com>
3977
3978         * remote.c (remote_pspace_data): Change type.
3979         (remote_pspace_data_cleanup): Remove.
3980         (get_remote_exec_file, set_pspace_remote_exec_file)
3981         (_initialize_remote): Update.
3982
3983 2019-05-08  Tom Tromey  <tom@tromey.com>
3984
3985         * breakpoint.c (breakpoint_objfile_key): Change type.
3986         (get_breakpoint_objfile_data): Update.
3987         (free_breakpoint_objfile_data): Remove.
3988         (_initialize_breakpoint): Update.
3989
3990 2019-05-08  Tom Tromey  <tom@tromey.com>
3991
3992         * linux-tdep.c (struct linux_info): Add initializers.
3993         (linux_inferior_data): Move.  Change type.
3994         (invalidate_linux_cache_inf): Update.
3995         (linux_inferior_data_cleanup): Remove.
3996         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3997
3998 2019-05-08  Tom Tromey  <tom@tromey.com>
3999
4000         * auxv.c (auxv_inferior_data): Move.  Change type.
4001         (auxv_inferior_data_cleanup): Remove.
4002         (invalidate_auxv_cache_inf): Rewrite.
4003         (get_auxv_inferior_data, _initialize_auxv): Update.
4004
4005 2019-05-08  Tom Tromey  <tom@tromey.com>
4006
4007         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4008         (symfile_debug_objfile_data_key): Change type.
4009         (symfile_debug_installed, debug_qf_has_symbols)
4010         (debug_qf_find_last_source_symtab)
4011         (debug_qf_forget_cached_source_info)
4012         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4013         (debug_qf_print_stats, debug_qf_dump)
4014         (debug_qf_expand_symtabs_for_function)
4015         (debug_qf_expand_all_symtabs)
4016         (debug_qf_expand_symtabs_with_fullname)
4017         (debug_qf_map_matching_symbols)
4018         (debug_qf_expand_symtabs_matching)
4019         (debug_qf_find_pc_sect_compunit_symtab)
4020         (debug_qf_map_symbol_filenames)
4021         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4022         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4023         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4024         (debug_sym_read_linetable, debug_sym_relocate): Update.
4025         (symfile_debug_free_objfile): Remove.
4026         (install_symfile_debug_logging, _initialize_symfile_debug):
4027         Update.
4028
4029 2019-05-08  Tom Tromey  <tom@tromey.com>
4030
4031         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4032         allocate_on_obstack.
4033         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4034         (get_dwarf2_per_objfile): Update.
4035         (set_dwarf2_per_objfile): Remove.
4036         (dwarf2_has_info, dwarf2_get_section_info): Update.
4037         (dwarf2_free_objfile): Remove.
4038         (_initialize_dwarf2_read): Update.
4039
4040 2019-05-08  Tom Tromey  <tom@tromey.com>
4041
4042         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4043         initializers.
4044         <unsupported_script_warning_printed,
4045         script_not_found_warning_printed>: Now bool.
4046         (auto_load_pspace_data): Change type.
4047         (~auto_load_pspace_info): Rename from
4048         auto_load_pspace_data_cleanup.
4049         (get_auto_load_pspace_data, init_loaded_scripts_info)
4050         (clear_section_scripts, maybe_print_unsupported_script_warning)
4051         (maybe_print_script_not_found_warning, _initialize_auto_load):
4052         Update.
4053
4054 2019-05-08  Tom Tromey  <tom@tromey.com>
4055
4056         * objfiles.c (objfile_pspace_info): Add destructor and
4057         initializers.
4058         (objfiles_pspace_data): Change type.
4059         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4060         (get_objfile_pspace_data): Update.
4061         (objfiles_bfd_data): Change type.
4062         (get_objfile_bfd_data): Update.
4063         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4064
4065 2019-05-08  Tom Tromey  <tom@tromey.com>
4066
4067         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4068         Change type.
4069         (get_catch_syscall_inferior_data): Update.
4070         (catch_syscall_inferior_data_cleanup): Remove.
4071         (_initialize_break_catch_syscall): Update.
4072
4073 2019-05-08  Tom Tromey  <tom@tromey.com>
4074
4075         * inflow.c (struct terminal_info): Add destructor and
4076         initializers.
4077         (inflow_inferior_data): Change type.
4078         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4079         (get_inflow_inferior_data, inflow_inferior_exit)
4080         (swap_terminal_info, _initialize_inflow): Update.
4081
4082 2019-05-08  Tom Tromey  <tom@tromey.com>
4083
4084         * target-dcache.c (target_dcache_cleanup): Remove.
4085         (target_dcache_aspace_key): Change type.
4086         (target_dcache_init_p, target_dcache_invalidate)
4087         (target_dcache_get, target_dcache_get_or_init)
4088         (_initialize_target_dcache): Update.
4089         * dcache.h (struct dcache_deleter): New.
4090
4091 2019-05-08  Tom Tromey  <tom@tromey.com>
4092
4093         * symtab.c (struct symbol_cache): Add destructor and
4094         initializers.
4095         (symbol_cache_key): Move.  Change type.
4096         (make_symbol_cache, free_symbol_cache): Remove.
4097         (get_symbol_cache): Update.
4098         (symbol_cache_cleanup): Remove.
4099         (ALL_PSPACES, symbol_cache_flush)
4100         (maintenance_print_symbol_cache)
4101         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4102         Update.
4103
4104 2019-05-08  Tom Tromey  <tom@tromey.com>
4105
4106         * symtab.c (struct main_info): Add destructor and initializers.
4107         (main_progspace_key): Move.  Change type.
4108         (get_main_info): Update.
4109         (main_info_cleanup): Remove.
4110         (_initialize_symtab): Update.
4111
4112 2019-05-08  Tom Tromey  <tom@tromey.com>
4113
4114         * registry.h (DECLARE_REGISTRY): Define the _key class.
4115
4116 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4117
4118         * NEWS: Merge two 'New commands' sections.
4119
4120 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4121
4122         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4123         parameter and use Ada language definition instead.
4124         (ada_val_print_ptr): Remove unused language parameter.
4125         (ada_val_print_num): Remove language parameter and use Ada language
4126         definition instead.
4127         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4128         parameter.
4129         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4130         parameter and use Ada language definition instead.
4131         (ada_val_print_1): Update all ada_val_print_xxx calls.
4132         Remove language parameter.
4133         (ada_val_print): Update ada_val_print_1 call.
4134
4135 2019-05-08  Tom Tromey  <tromey@adacore.com>
4136
4137         * remote.c (remote_hw_watchpoint_limit)
4138         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4139         Now static.
4140
4141 2019-05-08  Tom Tromey  <tromey@adacore.com>
4142
4143         * maint.c (_initialize_maint_cmds): Move initialization code to
4144         remote.c.
4145         (watchdog, show_watchdog): Move to remote.c.
4146         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4147         "watchdog" static.
4148         (_initialize_remote): Move initialization code from maint.c.
4149         * defs.h (watchdog): Don't declare.
4150
4151 2019-05-08  Tom Tromey  <tromey@adacore.com>
4152
4153         * tui/tui-interp.c: Include main.h.
4154         * interps.c: Include main.h.
4155         * main.h (interpreter_p): Declare.
4156         * defs.h (interpreter_p): Don't declare.
4157
4158 2019-05-08  Tom Tromey  <tromey@adacore.com>
4159
4160         * dwarf2loc.c: Include dwarf2read.h.
4161         * defs.h (read_unsigned_leb128): Don't declare.
4162         * dwarf2read.h (read_unsigned_leb128): Declare.
4163
4164 2019-05-08  Tom Tromey  <tromey@adacore.com>
4165
4166         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4167         method.
4168
4169 2019-05-08  Tom Tromey  <tromey@adacore.com>
4170
4171         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4172         when no wrap column is set.
4173
4174 2019-05-08  Tom Tromey  <tromey@adacore.com>
4175
4176         * c-lang.c (c_get_string): Handle non-C-style arrays.
4177
4178 2019-05-08  Tom Tromey  <tromey@adacore.com>
4179
4180         * typeprint.c (print_offset_data::update): Print the bit offset,
4181         not the number of bits remaining.
4182
4183 2019-05-08  Tom Tromey  <tromey@adacore.com>
4184
4185         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4186         padding at end of comment.
4187
4188 2019-05-08  Tom Tromey  <tromey@adacore.com>
4189
4190         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4191         Compare main types.
4192
4193 2019-05-06  Tom Tromey  <tom@tromey.com>
4194
4195         * common/scoped_mmap.c: Include common-defs.h.
4196         * common/scoped_mmap.h: Don't include config.h.
4197
4198 2019-05-04  Tom Tromey  <tom@tromey.com>
4199
4200         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4201         (struct aarch64_call_info): Add initializers.
4202         <si>: Now a std::vector.
4203         (pass_on_stack, aarch64_push_dummy_call): Update.
4204
4205 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4206             Tom Tromey  <tom@tromey.com>
4207
4208         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4209         (ppc_threads): Now a std::vector.  Now static.
4210         (hwdebug_find_thread_points_by_tid)
4211         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4212         Update.
4213
4214 2019-05-04  Tom Tromey  <tom@tromey.com>
4215
4216         * arc-tdep.c (arc_tdesc_init): Return bool.
4217
4218 2019-05-04  Tom Tromey  <tom@tromey.com>
4219
4220         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4221         Use gdb_assert_not_reached.
4222
4223 2019-05-04  Tom Tromey  <tom@tromey.com>
4224
4225         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4226         "false".
4227
4228 2019-05-04  Tom Tromey  <tom@tromey.com>
4229
4230         * arc-tdep.c (arc_tdesc_init): Use bool.
4231
4232 2019-05-04  Tom Tromey  <tom@tromey.com>
4233
4234         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4235
4236 2019-05-04  Tom Tromey  <tom@tromey.com>
4237
4238         * cli/cli-cmds.c (valid_command_p): Return bool.
4239
4240 2019-05-04  Tom Tromey  <tom@tromey.com>
4241
4242         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4243         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4244
4245 2019-05-04  Raul Tambre  <raul@tambre.ee>
4246
4247         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4248         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4249         operator for comparison.
4250
4251 2019-05-04  Tom Tromey  <tom@tromey.com>
4252
4253         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4254         (lookup_partial_symbol, print_partial_symbols)
4255         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4256         (psymbol_compare): Update.
4257         (add_psymbol_to_bcache): Clear the entire psymbol.
4258         (maintenance_check_psymtabs): Update.
4259         * psympriv.h (struct partial_symbol): Don't derive from
4260         general_symbol_info.
4261         <obj_section, unrelocated_address, address,
4262         set_unrelocated_address>: Update.
4263         <ginfo>: New member.
4264         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4265         (debug_names::write_psymbols): Update.
4266
4267 2019-05-04  Tom de Vries  <tdevries@suse.de>
4268
4269         * contrib/cc-with-tweaks.sh: Support -n arg.
4270
4271 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4272
4273         * corelow.c (core_target::detach): Ensure frame cache and
4274         register caches are cleared.
4275         inferior.c (exit_inferior_1): Likewise.
4276
4277 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4278             Tom Tromey  <tom@tromey.com>
4279
4280         * dictionary.c (collate_pending_symbols_by_language): Remove
4281         "struct" from foreach.
4282         * symtab.c (lookup_global_symbol_from_objfile)
4283         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4284         foreach.
4285         * ser-tcp.c (net_open): Remove "struct" from foreach.
4286         * objfiles.c (objfile_relocate, objfile_rebase)
4287         (objfile_has_symbols): Remove "struct" from foreach.
4288         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4289         from foreach.
4290         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4291         foreach.
4292         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4293         "struct" from foreach.
4294         * ada-lang.c (create_excep_cond_exprs)
4295         (ada_exception_catchpoint_cond_string): Remove "struct" from
4296         foreach.
4297
4298 2019-05-03  Tom Tromey  <tromey@adacore.com>
4299
4300         * ada-exp.y (convert_char_literal): Check suffix of each
4301         enumerator.
4302
4303 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4304
4305         PR ada/21406:
4306         * ada-exp.y (yywrap): Don't define.
4307         * ada-lex.l (%option): Add noyywrap
4308         (yywrap): Remove.
4309
4310 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4311
4312         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4313         _WIN32_WINNT to the XP level, unless already defined to a higher
4314         level.
4315
4316         * unittests/parse-connection-spec-selftests.c:
4317         * ser-tcp.c:
4318         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4319         override.
4320
4321         * symfile.c (find_separate_debug_file): Remove colon from the
4322         drive spec of DOS/Windows file names of the target, so that the
4323         file name produced from DEBUGDIR and the target's directory will
4324         be valid on DOS/Windows systems.
4325
4326 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * rust-lang.c (val_print_struct): Handle printing structures
4329         containing strings.
4330
4331 2019-05-02  Tom Tromey  <tromey@adacore.com>
4332
4333         * valarith.c (_initialize_valarith): Remove.
4334
4335 2019-05-01  Tom Tromey  <tromey@adacore.com>
4336
4337         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4338         bitfields.
4339
4340 2019-05-01  Tom Tromey  <tromey@adacore.com>
4341
4342         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4343         for big-endian copies.
4344
4345 2019-04-30  Ali Tamur  <tamur@google.com>
4346         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4347         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4348         (read_3_bytes): New function.
4349
4350 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4351
4352         * windows-nat.c (main_thread_id): Delete.
4353         (handle_output_debug_string): Replace main_thread_id by
4354         current_event.dwThreadId.
4355         (fake_create_process): Likewise.
4356         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4357         Do not set main_thread_id.
4358         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4359         current_event.dwThreadId.
4360         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4361
4362 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4363
4364         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4365         Use current_event.dwThreadId instead of main_thread_id.
4366
4367 2019-04-30  Tom Tromey  <tromey@adacore.com>
4368
4369         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4370         (create_excep_cond_exprs): Iterate over program spaces.
4371         (ada_exception_catchpoint_cond_string): Examine all minimal
4372         symbols for exception types.
4373
4374 2019-04-30  Tom Tromey  <tromey@adacore.com>
4375
4376         PR c++/24470:
4377         * dwarf2read.c (process_structure_scope): Handle case where type
4378         has template parameters but no symbol was created.
4379
4380 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4381             Chris January  <chris.january@arm.com>
4382
4383         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4384         qualifier.
4385         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4386
4387 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4388
4389         * f-typeprint.c (f_print_type): Update rules for printing
4390         whitespace.
4391         (f_type_print_varspec_suffix): Likewise.
4392
4393 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4394             Chris January  <chris.january@arm.com>
4395
4396         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4397         function arguments.
4398
4399 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * f-lang.c (build_fortran_types): Change name of void type to
4402         lower case.
4403         * f-typeprint.c (f_type_print_base): Print the name of the void
4404         type, rather than a fixed string.
4405         * f-valprint.c (f_decorations): Use lower case void string.
4406
4407 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4408             Chris January  <chris.january@arm.com>
4409
4410         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4411         types for Fortran.
4412
4413 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4414             Chris January  <chris.january@arm.com>
4415             David Lecomber  <david.lecomber@arm.com>
4416
4417         * f-exp.y (BINOP_INTRINSIC): New token.
4418         (exp): New parser rule handling BINOP_INTRINSIC.
4419         (f77_keywords): Add new builtin procedures.
4420         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4421         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4422         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4423         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4424         (print_unop_subexp_f): New function.
4425         (print_binop_subexp_f): New function.
4426         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4427         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4428         (dump_subexp_body_f): Likewise.
4429         (operator_check_f): Likewise.
4430         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4431         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4432
4433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4436         UNOP_KIND.
4437         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4438         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4439         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4440         (operator_length_f): New fuction.
4441         (print_subexp_f): New function.
4442         (op_name_f): New function.
4443         (dump_subexp_body_f): New function.
4444         (operator_check_f): New function.
4445         (exp_descriptor_f): Replace standard expression handling functions
4446         with new functions.
4447         * gdb/fortran-operator.def: New file.
4448         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4449         * gdb/std-operator.def: Remove UNOP_KIND.
4450
4451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * std-operator.def: Remove unbalanced, stray double quote
4454         character.
4455
4456 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4457             Chris January  <chris.january@arm.com>
4458             Daniel Everett  <daniel.everett@arm.com>
4459             Nick Forrington  <nick.forrington@arm.com>
4460             Richard Bunt  <richard.bunt@arm.com>
4461
4462         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4463         of depth when printing anonymous structs or unions.
4464         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4465         Don't print either the top-level value, or the children if the
4466         max-depth is exceeded.
4467         (ppscm_print_children): When printing the key of a map, allow one
4468         extra level of depth.
4469         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4470         print either the top-level value, or the children if the max-depth
4471         is exceeded.
4472         (print_children): When printing the key of a map, allow one extra
4473         level of depth.
4474         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4475         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4476         (user_print_options): Initialise max_depth field.
4477         (val_print_scalar_or_string_type_p): New function.
4478         (val_print): Check to see if the max depth has been reached.
4479         (val_print_check_max_depth): Define new function.
4480         (show_print_max_depth): New function.
4481         (_initialize_valprint): Add 'print max-depth' option.
4482         * valprint.h (struct value_print_options) <max_depth>: New field.
4483         (val_print_check_max_depth): Declare new function.
4484         * NEWS: Document new feature.
4485
4486 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * ada-lang.c (ada_language_defn): Initialise new field.
4489         * c-lang.c (c_is_string_type_p): New function.
4490         (c_language_defn): Initialise new field.
4491         (cplus_language_defn): Initialise new field.
4492         (asm_language_defn): Initialise new field.
4493         (minimal_language_defn): Initialise new field.
4494         * c-lang.h (c_is_string_type_p): Declare new function.
4495         * d-lang.c (d_language_defn): Initialise new field.
4496         * f-lang.c (f_is_string_type_p): New function.
4497         (f_language_defn): Initialise new field.
4498         * go-lang.c (go_is_string_type_p): New function.
4499         (go_language_defn): Initialise new field.
4500         * language.c (default_is_string_type_p): New function.
4501         (unknown_language_defn): Initialise new field.
4502         (auto_language_defn): Initialise new field.
4503         * language.h (struct language_defn) <la_is_string_type_p>: New
4504         member variable.
4505         (default_is_string_type_p): Declare new function.
4506         * m2-lang.c (m2_language_defn): Initialise new field.
4507         * objc-lang.c (objc_language_defn): Initialise new field.
4508         * opencl-lang.c (opencl_language_defn): Initialise new field.
4509         * p-lang.c (pascal_is_string_type_p): New function.
4510         (pascal_language_defn): Initialise new field.
4511         * rust-lang.c (rust_is_string_type_p): New function.
4512         (rust_language_defn): Initialise new field.
4513
4514 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4517         New field.
4518         * ada-lang.c (ada_language_defn): Initialise new field.
4519         * c-lang.c (c_language_defn): Likewise.
4520         (cplus_language_defn): Likewise.
4521         (asm_language_defn): Likewise.
4522         (minimal_language_defn): Likewise.
4523         * d-lang.c (d_language_defn): Likewise.
4524         * f-lang.c (f_language_defn): Likewise.
4525         * go-lang.c (go_language_defn): Likewise.
4526         * language.c (unknown_language_defn): Likewise.
4527         (auto_language_defn): Likewise.
4528         * m2-lang.c (m2_language_defn): Likewise.
4529         * objc-lang.c (objc_language_defn): Likewise.
4530         * opencl-lang.c (opencl_language_defn): Likewise.
4531         * p-lang.c (pascal_language_defn): Likewise.
4532         * rust-lang.c (rust_language_defn): Likewise.
4533
4534 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * ada-lang.c (ada_is_character_type): Change return type to bool.
4537         (ada_is_string_type): Likewise.
4538         * ada-lang.h (ada_is_character_type): Update declaration
4539         (ada_is_string_type): Likewise.
4540
4541 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4542
4543         Support style in 'frame|thread apply'
4544
4545         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4546         * record.c (record_start, record_stop): Update callers of
4547         execute_command_to_string with false.
4548         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4549         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4550         methods.
4551         (class string_file): New constructor with term_out parameter.
4552         Override methods term_out and can_emit_style_escape.  New member
4553         term_out.
4554         (class stdio_file): Override can_emit_style_escape.
4555         (class tee_file): Override term_out and can_emit_style_escape.
4556         * utils.h (can_emit_style_escape): Remove.
4557         * utils.c (can_emit_style_escape): Likewise.
4558         Update all callers of can_emit_style_escape (SOMESTREAM) to
4559         SOMESTREAM->can_emit_style_escape.
4560         * source-cache.c (source_cache::get_source_lines): Likewise.
4561         * stack.c (frame_apply_command_count): Call execute_command_to_string
4562         passing the term_out characteristic of the current gdb_stdout.
4563         * thread.c (thr_try_catch_cmd): Likewise.
4564         * top.c (execute_command_to_string): pass term_out parameter
4565         to construct the string_file for the command output.
4566         * ui-file.c (term_cli_styling): New function (most code moved
4567         from utils.c can_emit_style_escape).
4568         (string_file::string_file, string_file::can_emit_style_escape,
4569         stdio_file::can_emit_style_escape, tee_file::term_out,
4570         tee_file::can_emit_style_escape): New functions.
4571
4572 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4573
4574         * NEWS: Mention the new set|show may-call-functions.
4575         * infcall.c (may_call_functions_p): New variable.
4576         (show_may_call_functions_p): New function.
4577         (call_function_by_hand_dummy): Throws an error if not
4578         may-call-functions.
4579         (_initialize_infcall): Call add_setshow_boolean_cmd for
4580         may-call-functions.
4581
4582 2019-04-25  Keith Seitz  <keiths@redhat.com>
4583
4584         PR c++/24367
4585         * cp-support.c (inspect_type): Don't attempt substitutions
4586         of symbol with the same name.
4587
4588 2019-04-25  Tom Tromey  <tromey@adacore.com>
4589
4590         PR gdb/24475:
4591         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4592         static.
4593
4594 2019-04-25  Tom Tromey  <tromey@adacore.com>
4595
4596         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4597         rvalue reference.
4598         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4599         (gdb_xml_parser::parse): Use std::move.
4600         * python/python-internal.h (gdbpy_convert_exception): Take a const
4601         reference.
4602         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4603         std::move.
4604         * python/py-utils.c (gdbpy_convert_exception): Take a const
4605         reference.
4606         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4607         Use std::move.
4608         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4609         Use std::move.
4610         * mi/mi-main.c (mi_print_exception): Take a const reference.
4611         * main.c (handle_command_errors): Take a const reference.
4612         * linespec.c (parse_linespec): Use std::move.
4613         * infcall.c (run_inferior_call): Use std::move.
4614         (call_function_by_hand_dummy): Use std::move.
4615         * exec.c (try_open_exec_file): Use std::move.
4616         * exceptions.h (exception_print, exception_fprintf)
4617         (exception_print_same): Update.
4618         * exceptions.c (print_exception, exception_print)
4619         (exception_fprintf, exception_print_same): Change parameters to
4620         const reference.
4621         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4622         * common/new-op.c: Use std::move.
4623         * common/common-exceptions.h (struct gdb_exception): Add move
4624         constructor.
4625         (struct gdb_exception_error, struct gdb_exception_quit, struct
4626         gdb_quit_bad_alloc): Change constructor to move constructor.
4627         (throw_exception): Change parameter to rvalue reference.
4628         * common/common-exceptions.c (throw_exception): Take rvalue
4629         reference.
4630         * cli/cli-interp.c (safe_execute_command): Use std::move.
4631         * breakpoint.c (insert_bp_location, location_to_sals): Use
4632         std::move.
4633
4634 2019-04-25  Tom Tromey  <tromey@adacore.com>
4635
4636         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4637         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4638         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4639         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4640         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4641         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4642         guile/scm-value.c: Use unpack.
4643         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4644         gdbscm_gdb_exception.
4645         (gdbscm_throw_gdb_exception): Likewise.
4646         (struct gdbscm_gdb_exception): New.
4647         (unpack): New function.
4648         (gdbscm_wrap): Use unpack.
4649
4650 2019-04-25  Tom Tromey  <tromey@adacore.com>
4651
4652         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4653         (gdb_rl_callback_handler): Use std::move.
4654         * common/common-exceptions.h (struct gdb_exception): Add move
4655         assignment operator.
4656         (throw_exception_sjlj): Change "exception" to const reference.
4657         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4658         (throw_exception_sjlj): Change "exception" to const reference.
4659
4660 2019-04-25  Tom Tromey  <tromey@adacore.com>
4661
4662         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4663         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4664         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4665         Update.
4666         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4667         Update.
4668         * mi/mi-interp.c (mi_interp::exec): Update.
4669         * linespec.c (parse_linespec): Update.
4670         * infcall.c (run_inferior_call): Update.
4671         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4672         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4673         (gdbscm_lookup_global_symbol): Update.
4674         * guile/scm-param.c (gdbscm_parameter_value): Update.
4675         * guile/scm-frame.c (gdbscm_frame_read_register)
4676         (gdbscm_frame_read_var): Update.
4677         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4678         * exec.c (try_open_exec_file): Update.
4679         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4680         (gdb_rl_callback_handler): Update.
4681         * common/common-exceptions.h (exception_none): Don't declare.
4682         * common/common-exceptions.c (exception_none): Don't define.
4683         (struct catcher) <exception>: Update.
4684         * cli/cli-interp.c (safe_execute_command): Update.
4685         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4686
4687 2019-04-25  Ali Tamur  <tamur@google.com>
4688
4689         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4690         (read_attribute_value): Likewise.
4691         (dwarf2_read_addr_index): Update comment.
4692         (read_str_index): Add DW_FORM_strx.
4693         (dwarf2_string_attr): Likewise.
4694         (dwarf2_const_value_attr): Likewise.
4695         (dump_die_shallow): Likewise.
4696         (dwarf2_fetch_constant_bytes): Likewise.
4697         (skip_form_bytes): Likewise.
4698         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4699
4700 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4701
4702         PR corefiles/11608
4703         PR corefiles/18187
4704         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4705         OFFSET.  Verify if current mapping contains an ELF header.
4706         (linux_find_memory_regions_full): Adjust call to
4707         dump_mapping_p.
4708
4709 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4710             Kang Li <kanglictf@gmail.com>
4711
4712         PR gdb/21600
4713
4714         * dwarf2-frame.c (read_initial_length): Be consistent about using
4715         unsigned representation of length.
4716         (decode_frame_entry_1): Likewise.  Check for wraparound of
4717         end pointer as well as buffer overflow.
4718
4719 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4720
4721         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4722         "vq".
4723
4724 2019-04-24  Tom Tromey  <tromey@adacore.com>
4725
4726         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4727
4728 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4729
4730         * s12z-tdep.c (s12z_unwind_pc): Delete.
4731         (s12z_unwind_sp): Delete.
4732         (s12z_gdbarch_init): Don't register deleted functions with
4733         gdbarch.
4734
4735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4736
4737         * rl78-tdep.c (rl78_unwind_sp): Delete.
4738         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4739
4740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4743         (xstormy16_unwind_pc): Delete.
4744         (xstormy16_dummy_id): Delete.
4745         (xstormy16_gdbarch_init): Don't register deleted functions with
4746         gdbarch.
4747
4748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4749
4750         * vax-tdep.c (vax_unwind_pc): Delete.
4751         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4752
4753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * v850-tdep.c (v850_unwind_sp): Delete.
4756         (v850_unwind_pc): Delete.
4757         (v850_dummy_id): Delete.
4758         (v850_gdbarch_init): Don't register deleted functions with
4759         gdbarch.
4760
4761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4764         (tilegx_unwind_pc): Delete.
4765         (tilegx_unwind_dummy_id): Delete.
4766         (tilegx_gdbarch_init): Don't register deleted functions with
4767         gdbarch.
4768
4769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4772         (tic6x_dummy_id): Delete.
4773         (tic6x_gdbarch_init): Don't register deleted functions with
4774         gdbarch.
4775
4776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4777
4778         * sparc-tdep.c (sparc_unwind_pc): Delete.
4779         (sparc32_gdbarch_init): Don't register deleted function with
4780         gdbarch.
4781
4782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4783
4784         * sh-tdep.c (sh_unwind_sp): Delete.
4785         (sh_unwind_pc): Delete.
4786         (sh_dummy_id): Delete.
4787         (sh_gdbarch_init): Don't register deleted functions with
4788         gdbarch.
4789
4790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * score-tdep.c (score_unwind_sp): Delete.
4793         (score_unwind_pc): Delete.
4794         (score_dummy_id): Delete.
4795         (score_gdbarch_init): Don't register deleted functions with
4796         gdbarch.
4797
4798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4799
4800         * rx-tdep.c (rx_unwind_pc): Delete.
4801         (rx_unwind_sp): Delete.
4802         (rx_dummy_id): Delete.
4803         (rx_gdbarch_init): Don't register deleted functions with
4804         gdbarch.  Update comment.
4805
4806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4809         (rs6000_dummy_id): Delete.
4810         (rs6000_gdbarch_init): Don't register deleted functions with
4811         gdbarch.
4812
4813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * or1k-tdep.c (or1k_dummy_id): Delete.
4816         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4817
4818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * nios2-tdep.c (nios2_dummy_id): Delete.
4821         (nios2_unwind_sp): Delete.
4822         (nios2_gdbarch_init): Don't register deleted functions with
4823         gdbarch.
4824
4825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * nds32-tdep.c (nds32_dummy_id): Delete.
4828         (nds32_unwind_pc): Delete.
4829         (nds32_unwind_sp): Delete.
4830         (nds32_gdbarch_init): Don't register deleted functions with
4831         gdbarch.
4832
4833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4834
4835         * msp430-tdep.c (msp430_unwind_pc): Delete.
4836         (msp430_unwind_sp): Delete.
4837         (msp430_dummy_id): Delete.
4838         (msp430_gdbarch_init): Don't register deleted functions with
4839         gdbarch.
4840
4841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * moxie-tdep.c (moxie_unwind_sp): Delete.
4844         (moxie_unwind_pc): Delete.
4845         (moxie_dummy_id): Delete.
4846         (moxie_gdbarch_init): Don't register deleted functions with
4847         gdbarch.
4848
4849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4852         (mn10300_unwind_pc): Delete.
4853         (mn10300_unwind_sp): Delete.
4854         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4855         mn10300_unwind_sp.
4856         (mn10300_frame_unwind_init): Don't register deleted functions with
4857         gdbarch.
4858
4859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * mep-tdep.c (mep_unwind_pc): Delete.
4862         (mep_unwind_sp): Delete.
4863         (mep_dummy_id): Delete.
4864         (mep_gdbarch_init): Don't register deleted functions with
4865         gdbarch.
4866
4867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4868
4869         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4870         (m68hc11_unwind_sp): Delete.
4871         (m68hc11_gdbarch_init): Don't register deleted functions with
4872         gdbarch.
4873
4874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4875
4876         * m32r-tdep.c (m32r_unwind_sp): Delete.
4877         (m32r_unwind_pc): Delete.
4878         (m32r_dummy_id): Delete.
4879         (m32r_gdbarch_init): Don't register deleted functions with
4880         gdbarch.
4881
4882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4883
4884         * m32c-tdep.c (m32c_unwind_pc): Delete.
4885         (m32c_unwind_sp): Delete.
4886         (m32c_dummy_id): Delete.
4887         (m32c_gdbarch_init): Don't register deleted functions with
4888         gdbarch.
4889
4890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4891
4892         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4893         (lm32_unwind_pc): Delete.
4894         (lm32_dummy_id): Delete.
4895         (lm32_gdbarch_init): Don't register deleted functions with
4896         gdbarch.
4897
4898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4901         (iq2000_unwind_pc): Delete.
4902         (iq2000_dummy_id): Delete.
4903         (iq2000_gdbarch_init): Don't register deleted functions with
4904         gdbarch.
4905
4906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * nds32-tdep.c (nds32_type_align): Delete.
4909         (nds32_push_dummy_call): Use type_align instead.
4910
4911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         * arm-tdep.c (arm_type_align): Only handle vector override case.
4914         (arm_push_dummy_call): Use type_align.
4915         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4916
4917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4920         case.
4921         (pass_on_stack): Use type_align.
4922         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4923         function.
4924
4925 2019-04-23  Tom Tromey  <tromey@adacore.com>
4926
4927         * dwarf2read.c (line_header::file_name_at): Remove unused
4928         overload.
4929
4930 2019-04-23  Tom de Vries  <tdevries@suse.de>
4931
4932         PR gdb/24438
4933         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4934         invocation.
4935
4936
4937 2019-03-27  Ali Tamur  <tamur@google.com>
4938
4939         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4940         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4941         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4942         (dwarf_expr_context::get_addr_index): Likewise
4943         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4944         (symbol_needs_eval_context::get_addr_index): Likewise
4945         (disassemble_dwarf_expression): Add DW_OP_addrx
4946         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4947         (read_cutu_die_from_dwo): Update comment
4948         (skip_one_die): Add DW_FORM_addrx
4949         (read_attribute_value): Likewise
4950         (var_decode_location): Add DW_OP_addrx
4951         (dwarf2_const_value_attr): Add DW_FORM_addrx
4952         (dump_die_shallow): Likewise
4953         (dwarf2_fetch_constant_bytes): Likewise
4954         (decode_locdesc): Add DW_OP_addrx
4955         (skip_form_bytes): Add DW_FORM_addrx
4956
4957 2019-04-22  Ali Tamur  <tamur@google.com>
4958
4959         * MAINTAINERS (Write After Approval): Add self.
4960
4961 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4962
4963         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4964         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4965         (open_symbol_file_object): Likewise.
4966         (svr4_default_sos): Add info parameter.
4967         (svr4_read_so_list): Likewise.
4968         (svr4_current_sos_direct): Adjust functions calls to pass down
4969         info.
4970         (svr4_current_sos_1): Add info parameter.
4971         (svr4_current_sos): Call get_svr4_info, pass info down to
4972         svr4_current_sos_1.
4973         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4974         get_svr4_info.
4975         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4976         get_svr4_info.
4977         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4978         to get_svr4_info.
4979         (probes_table_remove_objfile_probes): Likewise.
4980         (register_solib_event_probe): Add info parameter.
4981         (solist_update_incremental): Pass info parameter down to
4982         svr4_read_so_list.
4983         (disable_probes_interface): Add info parameter.
4984         (svr4_handle_solib_event): Pass current_program_space to
4985         get_svr4_info.  Adjust disable_probes_interface cleanup.
4986         (svr4_create_probe_breakpoints): Add info parameter, pass it
4987         down to register_solib_event_probe.
4988         (svr4_create_solib_event_breakpoints): Add info parameter,
4989         pass it down to svr4_create_probe_breakpoints.
4990         (enable_break): Pass info down to
4991         svr4_create_solib_event_breakpoints.
4992         (svr4_solib_create_inferior_hook): Pass current_program_space to
4993         get_svr4_info.
4994         (svr4_clear_solib): Likewise.
4995
4996 2019-04-22  Pedro Alves  <palves@redhat.com>
4997
4998         * solib-svr4.c (svr4_free_objfile_observer): New.
4999         (probe_and_action::objfile): New field.
5000         (probes_table_htab_remove_objfile_probes)
5001         (probes_table_remove_objfile_probes): New functions.
5002         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5003         in the new probe_and_action.  Don't store the probe in 'lookup'.
5004         (svr4_create_probe_breakpoints): Pass objfile to
5005         register_solib_event_probe.
5006         (_initialize_svr4_solib): Register a free_objfile observer.
5007
5008 2019-04-19  Tom Tromey  <tom@tromey.com>
5009
5010         * common/queue.h: Remove.
5011
5012 2019-04-19  Tom Tromey  <tom@tromey.com>
5013
5014         * event-loop.c: Don't include "common/queue.h".
5015
5016 2019-04-19  Tom Tromey  <tom@tromey.com>
5017
5018         * remote.c (remote_target): Use delete.
5019         * remote-notif.h: Include <list>, not "common/queue.h".
5020         (notif_client_p): Remove typedef.
5021         (remote_notif_state): Add constructor, destructor, initializer.
5022         <notif_queue>: Now a std::list.
5023         (remote_notif_state_xfree): Don't declare.
5024         * remote-notif.c (remote_notif_process, handle_notification)
5025         (remote_notif_state_allocate): Update.
5026         (~remote_notif_state): Rename from remote_notif_state_xfree.
5027
5028 2019-04-19  Tom Tromey  <tom@tromey.com>
5029
5030         * symfile.c (reread_symbols): Update.
5031         * objfiles.c (objfile_register_static_link)
5032         (objfile_lookup_static_link): Update
5033         (~objfile) Don't delete static_links.
5034         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5035
5036 2019-04-19  Tom Tromey  <tom@tromey.com>
5037
5038         * type-stack.h (struct type_stack) <insert>: Constify string.
5039         * type-stack.c (type_stack::insert): Constify string.
5040         * gdbtypes.h (lookup_template_type): Update.
5041         (address_space_name_to_int): Update.
5042         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5043         const.
5044         (lookup_template_type): Make name const.
5045         * c-exp.y: Update rules.
5046         (lex_one_token, classify_name, classify_inner_name)
5047         (c_print_token): Update.
5048         * p-exp.y: Update rules.
5049         (yylex): Update.
5050         * f-exp.y: Update rules.
5051         (yylex): Update.
5052         * d-exp.y: Update rules.
5053         (lex_one_token, classify_name, classify_inner_name): Update.
5054         * parse.c (write_dollar_variable, copy_name): Return std::string.
5055         * parser-defs.h (copy_name): Change return type.
5056         * m2-exp.y: Update rules.
5057         (yylex): Update.
5058         * go-exp.y (lex_one_token): Update.
5059         Update rules.
5060         (classify_unsafe_function, classify_packaged_name)
5061         (classify_name, yylex): Update.
5062
5063 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5064
5065         * configure.ac: add --enable-source-highlight switch.
5066         * configure: Regenerate.
5067         * top.c (print_gdb_version): plumb --enable-source-highlight
5068         status to "show configuration".
5069
5070 2019-04-19  Tom Tromey  <tromey@adacore.com>
5071
5072         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5073         Check ADA_TYPE_P.
5074         (empty_record, ada_template_to_fixed_record_type_1)
5075         (template_to_static_fixed_type)
5076         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5077         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5078         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5079         macros.
5080
5081 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5082
5083         PR symtab/24423:
5084         * source.c (print_source_lines_base): Advance "iter" when a
5085         control character is seen.
5086
5087 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5088
5089         * inferior.h (struct infcall_suspend_state_deleter):
5090         Catch exception in destructor to avoid crash.
5091
5092 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5093
5094         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5095         close to the add_com "shell".
5096
5097 2019-04-18  Tom Tromey  <tromey@adacore.com>
5098
5099         * process-stratum-target.h (class process_stratum_target)
5100         <stratum>: Add "final".
5101
5102 2019-04-17  Tom Tromey  <tromey@adacore.com>
5103
5104         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5105         against nullptr before use.
5106
5107 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5108
5109         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5110
5111 2019-04-17  Jim Wilson  <jimw@sifive.com>
5112             Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5115         code read might fail, assume 4-byte breakpoint in that case.
5116
5117 2019-04-15  Leszek Swirski  <leszeks@google.com>
5118
5119         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5120         rather than a hand-rolled POD check when checking for forced MEMORY
5121         classification.
5122
5123 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5124
5125         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5126         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5127         function.
5128         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5129         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5130         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5131         declaration.
5132
5133 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5134
5135         * aarch64-linux-nat.c
5136         (aarch64_linux_nat_target::thread_architecture): Add override.
5137         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5138         each VQ.
5139
5140 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5141
5142         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5143
5144 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5147         target types of size 96-bits, add some additional comments, and
5148         check that the builtin type we found was the correct size.
5149
5150 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5151
5152         * utils.c (prompt_for_continue): Don't restore the styling at the
5153         end, as applied_style has the wrong value.  This fixes styling in
5154         long lists of file names that are interrupted by the "Continue?"
5155         prompt.
5156
5157 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5160         * c-lang.c (c_language_defn): Likewise.
5161         (cplus_language_defn): Likewise.
5162         (asm_language_defn): Likewise.
5163         (minimal_language_defn): Likewise.
5164         * d-lang.c (d_language_defn): Likewise.
5165         * f-lang.c (f_language_defn): Likewise.
5166         * go-lang.c (go_language_defn): Likewise.
5167         * language.c (unknown_language_defn): Likewise.
5168         (auto_language_defn): Likewise.
5169         * language.h (struct language_defn): Remove la_magic field.
5170         (LANG_MAGIC): Delete.
5171         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5172         * objc-lang.c (objc_language_defn): Likewise.
5173         * opencl-lang.c (opencl_language_defn): Likewise.
5174         * p-lang.c (pascal_language_defn): Likewise.
5175         * rust-lang.c (rust_language_defn): Likewise.
5176
5177 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5178
5179         * riscv-tdep.c (riscv_type_align): New function.
5180         (riscv_type_alignment): Delete.
5181         (riscv_arg_location): Use 'type_align'.
5182         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5183
5184 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5185
5186         * gdbtypes.c (type_align): A struct with no non-static fields also
5187         has alignment of 1.
5188
5189 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5192         component to 0.
5193         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5194         member.
5195         (riscv_struct_info::analyse): New implementation using new
5196         analyse_inner member function.
5197         (riscv_struct_info::field_offset): New member function.
5198         (riscv_struct_info::m_offsets): New member variable.
5199         (riscv_struct_info::analyse_inner): New private member function,
5200         takes the old implementation of riscv_struct_info::analyse but
5201         extended to track field offsets.
5202         (riscv_call_arg_struct): Update the struct folding special cases
5203         to handle cases where empty C++ structs, which are non-zero
5204         length, are found.
5205         (riscv_arg_location): Initialise the length of each location, a
5206         non-zero length now indicates the location is in use.
5207         (riscv_push_dummy_call): Allow for the first location having a
5208         non-zero offset when setting up arguments.
5209         (riscv_return_value): Likewise, but for return values.
5210
5211 2019-04-11  Tom Tromey  <tromey@adacore.com>
5212
5213         * utils.c (internal_vproblem): Make "msg" const.
5214
5215 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5216
5217         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5218         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5219         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5220         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5221
5222 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5223
5224         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5225         function.
5226         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5227         of amd64_collect_native_gregset.
5228         (amd64_linux_nat_target::store_registers): Likewise.
5229
5230 2019-04-10  Tom Tromey  <tom@tromey.com>
5231
5232         * symtab.c (lookup_global_symbol_from_objfile)
5233         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5234         * objfiles.h (class separate_debug_iterator): New.
5235         (class separate_debug_range): New.
5236         (struct objfile) <separate_debug_objfiles>: New method.
5237         (objfile_separate_debug_iterate): Don't declare.
5238         * objfiles.c (separate_debug_iterator::operator++): Rename from
5239         objfile_separate_debug_iterate.
5240         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5241         iterator.
5242         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5243         iterator.
5244
5245 2019-04-10  Tom Tromey  <tom@tromey.com>
5246
5247         * symfile.c (reread_symbols): Remove old comment.
5248         * objfiles.c (free_all_objfiles): Fix a typo.
5249
5250 2019-04-10  Tom Tromey  <tom@tromey.com>
5251
5252         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5253         * minsyms.c (lookup_minimal_symbol): Use foreach.
5254         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5255         (lookup_minimal_symbol_solib_trampoline): Likewise.
5256         * symfile.c (reread_symbols): Use foreach.
5257
5258 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5259             Tom Tromey  <tromey@adacore.com>
5260
5261         PR rust/24414:
5262         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5263         (rust_lex_int_test): Change "value" to be LONGEST.
5264         (rust_lex_tests): Add test for long integer literal.
5265
5266 2019-04-09  Tom Tromey  <tromey@adacore.com>
5267
5268         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5269         to bool.
5270         (extended_remote_target::attach): Update.
5271         (remote_target::remote_notice_new_inferior): Update.
5272         (remote_target::add_current_inferior_and_thread): Update.
5273         * inferior.c (exit_inferior_1): Use "false".
5274         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5275
5276 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5277
5278         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5279         the "start" command.
5280
5281 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5282
5283         * python/py-inferior.c (infpy_thread_from_thread_handle):
5284         Adjust comments to reflect renaming of thread_from_thread_handle
5285         to thread_from_handle.  Adjust keywords.  Fix type error message.
5286         (inferior_object_methods): Add thread_from_handle.  Retain
5287         thread_from_thread_handle, but mark it as deprecated.
5288
5289 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5290
5291         * gdbthread.h (find_thread_by_handle): Revise declaration.
5292         * thread.c (find_thread_by_handle): Likewise.  Adjust
5293         implementation too.
5294         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5295         support for buffer objects as handles.
5296
5297 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5298
5299         * python/py-infthread.c (thpy_thread_handle): New function.
5300         (thread_object_methods): Register thpy_thread_handle.
5301
5302 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5303
5304         * gdbthread.h (thread_to_thread_handle): Declare.
5305         * thread.c (gdbtypes.h): Include.
5306         (thread_to_thread_handle): New function.
5307
5308         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5309         (target_thread_info_to_thread_handle): Declare.
5310         * target.c (target_thread_info_to_thread_handle): New function.
5311         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5312         * target-delegates.c: Regenerate.
5313
5314         * linux-thread-db.c (class thread_db_target): Add method
5315         thread_info_to_thread_handle.
5316         (thread_db_target::thread_info_to_thread_handle): Define.
5317         * remote.c (class remote_target): Add new method
5318         thread_info_to_thread_handle.
5319         (remote_target::thread_info_to_thread_handle): Define.
5320
5321 2019-04-08  Pedro Alves  <palves@redhat.com>
5322
5323         * common/common-exceptions.c (throw_exception): Don't create
5324         named object to throw; throw directly.
5325         (throw_it): Likewise.  Don't initialize gdb_exception::message
5326         here, with new; pass FMT and AP to the ctor instead.
5327         * common/common-exceptions.h: Include <string>.
5328         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5329         const char *, va_list)): New ctor.  Use std::make_shared.
5330         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5331         errors)): Delete.
5332         (gdb_exception_error::gdb_exception_error(enum errors, const char
5333         *, va_list)): New.
5334         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5335         Add assertion.
5336         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5337         errors)): Delete.
5338         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5339         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5340         Add assertion.
5341
5342 2019-04-08  Tom Tromey  <tom@tromey.com>
5343
5344         * valops.c (value_rtti_indirect_type): Replace throw_exception
5345         with throw.
5346         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5347         with throw.
5348         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5349         throw.
5350         * target.c (target_translate_tls_address): Replace throw_exception
5351         with throw.
5352         * stack.c (frame_apply_command_count): Replace throw_exception
5353         with throw.
5354         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5355         throw.
5356         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5357         with throw.
5358         * rs6000-tdep.c (rs6000_frame_cache)
5359         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5360         * remote.c: Replace throw_exception with throw.
5361         * record-full.c (record_full_message, record_full_wait_1)
5362         (record_full_restore): Replace throw_exception with throw.
5363         * record-btrace.c:
5364         (get_thread_current_frame_id, record_btrace_start_replaying)
5365         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5366         (cmd_record_btrace_start): Replace throw_exception with throw.
5367         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5368         throw.
5369         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5370         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5371         * linespec.c:
5372         (find_linespec_symbols): Replace throw_exception with throw.
5373         * infrun.c (displaced_step_prepare, resume): Replace
5374         throw_exception with throw.
5375         * infcmd.c (post_create_inferior): Replace throw_exception with
5376         throw.
5377         * inf-loop.c (inferior_event_handler): Replace throw_exception
5378         with throw.
5379         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5380         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5381         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5382         (get_prev_frame_always, get_frame_pc_if_available)
5383         (get_frame_address_in_block_if_available, get_frame_language):
5384         Replace throw_exception with throw.
5385         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5386         throw_exception with throw.
5387         * eval.c (fetch_subexp_value, evaluate_var_value)
5388         (evaluate_funcall, evaluate_subexp_standard): Replace
5389         throw_exception with throw.
5390         * dwarf2loc.c (call_site_find_chain)
5391         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5392         Replace throw_exception with throw.
5393         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5394         with throw.
5395         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5396         throw.
5397         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5398         * completer.c (complete_line_internal): Replace throw_exception
5399         with throw.
5400         * compile/compile-object-run.c (compile_object_run): Replace
5401         throw_exception with throw.
5402         * cli/cli-script.c (process_next_line): Replace throw_exception
5403         with throw.
5404         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5405         (btrace_enable, btrace_maint_update_pt_packets): Replace
5406         throw_exception with throw.
5407         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5408         throw_exception with throw.
5409         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5410         throw_exception with throw.
5411         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5412         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5413         * aarch64-tdep.c (aarch64_make_prologue_cache)
5414         (aarch64_make_stub_cache): Replace throw_exception with throw.
5415
5416 2019-04-08  Tom Tromey  <tom@tromey.com>
5417
5418         * common/common-exceptions.c (throw_exception): Rename from
5419         throw_exception_cxx.  Remove old copy.  Make argument const.
5420         (throw_it): Create and throw exception objects directly.
5421         * common/common-exceptions.h (throw_exception): Make argument
5422         const.
5423         (struct gdb_exception_error): Add constructor.
5424         (struct gdb_exception_quit): Add constructor.
5425
5426 2019-04-08  Tom Tromey  <tom@tromey.com>
5427
5428         * common/common-exceptions.h (exception_rethrow): Don't declare.
5429         (TRY_SJLJ): Update comment.
5430         (TRY, CATCH, END_CATCH): Remove.
5431         * common/common-exceptions.c (exception_rethrow): Remove.
5432
5433 2019-04-08  Tom Tromey  <tom@tromey.com>
5434
5435         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5436         Remove.
5437         (gdb_exception_error): Rename from
5438         gdb_exception_RETURN_MASK_ERROR.
5439         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5440         (gdb_quit_bad_alloc): Update.
5441         * aarch64-tdep.c: Update.
5442         * ada-lang.c: Update.
5443         * ada-typeprint.c: Update.
5444         * ada-valprint.c: Update.
5445         * amd64-tdep.c: Update.
5446         * arch-utils.c: Update.
5447         * break-catch-throw.c: Update.
5448         * breakpoint.c: Update.
5449         * btrace.c: Update.
5450         * c-varobj.c: Update.
5451         * cli/cli-cmds.c: Update.
5452         * cli/cli-interp.c: Update.
5453         * cli/cli-script.c: Update.
5454         * common/common-exceptions.c: Update.
5455         * common/new-op.c: Update.
5456         * common/selftest.c: Update.
5457         * compile/compile-c-symbols.c: Update.
5458         * compile/compile-cplus-symbols.c: Update.
5459         * compile/compile-object-load.c: Update.
5460         * compile/compile-object-run.c: Update.
5461         * completer.c: Update.
5462         * corelow.c: Update.
5463         * cp-abi.c: Update.
5464         * cp-support.c: Update.
5465         * cp-valprint.c: Update.
5466         * darwin-nat.c: Update.
5467         * disasm-selftests.c: Update.
5468         * dtrace-probe.c: Update.
5469         * dwarf-index-cache.c: Update.
5470         * dwarf-index-write.c: Update.
5471         * dwarf2-frame-tailcall.c: Update.
5472         * dwarf2-frame.c: Update.
5473         * dwarf2loc.c: Update.
5474         * dwarf2read.c: Update.
5475         * eval.c: Update.
5476         * event-loop.c: Update.
5477         * event-top.c: Update.
5478         * exec.c: Update.
5479         * f-valprint.c: Update.
5480         * fbsd-tdep.c: Update.
5481         * frame-unwind.c: Update.
5482         * frame.c: Update.
5483         * gdbtypes.c: Update.
5484         * gnu-v3-abi.c: Update.
5485         * guile/guile-internal.h: Update.
5486         * guile/scm-block.c: Update.
5487         * guile/scm-breakpoint.c: Update.
5488         * guile/scm-cmd.c: Update.
5489         * guile/scm-disasm.c: Update.
5490         * guile/scm-frame.c: Update.
5491         * guile/scm-lazy-string.c: Update.
5492         * guile/scm-math.c: Update.
5493         * guile/scm-param.c: Update.
5494         * guile/scm-ports.c: Update.
5495         * guile/scm-pretty-print.c: Update.
5496         * guile/scm-symbol.c: Update.
5497         * guile/scm-symtab.c: Update.
5498         * guile/scm-type.c: Update.
5499         * guile/scm-value.c: Update.
5500         * i386-linux-tdep.c: Update.
5501         * i386-tdep.c: Update.
5502         * inf-loop.c: Update.
5503         * infcall.c: Update.
5504         * infcmd.c: Update.
5505         * infrun.c: Update.
5506         * jit.c: Update.
5507         * language.c: Update.
5508         * linespec.c: Update.
5509         * linux-fork.c: Update.
5510         * linux-nat.c: Update.
5511         * linux-tdep.c: Update.
5512         * linux-thread-db.c: Update.
5513         * main.c: Update.
5514         * mi/mi-cmd-break.c: Update.
5515         * mi/mi-cmd-stack.c: Update.
5516         * mi/mi-interp.c: Update.
5517         * mi/mi-main.c: Update.
5518         * objc-lang.c: Update.
5519         * p-valprint.c: Update.
5520         * parse.c: Update.
5521         * ppc-linux-tdep.c: Update.
5522         * printcmd.c: Update.
5523         * python/py-arch.c: Update.
5524         * python/py-breakpoint.c: Update.
5525         * python/py-cmd.c: Update.
5526         * python/py-finishbreakpoint.c: Update.
5527         * python/py-frame.c: Update.
5528         * python/py-framefilter.c: Update.
5529         * python/py-gdb-readline.c: Update.
5530         * python/py-inferior.c: Update.
5531         * python/py-infthread.c: Update.
5532         * python/py-lazy-string.c: Update.
5533         * python/py-linetable.c: Update.
5534         * python/py-objfile.c: Update.
5535         * python/py-param.c: Update.
5536         * python/py-prettyprint.c: Update.
5537         * python/py-progspace.c: Update.
5538         * python/py-record-btrace.c: Update.
5539         * python/py-record.c: Update.
5540         * python/py-symbol.c: Update.
5541         * python/py-type.c: Update.
5542         * python/py-unwind.c: Update.
5543         * python/py-utils.c: Update.
5544         * python/py-value.c: Update.
5545         * python/python.c: Update.
5546         * record-btrace.c: Update.
5547         * record-full.c: Update.
5548         * remote-fileio.c: Update.
5549         * remote.c: Update.
5550         * riscv-tdep.c: Update.
5551         * rs6000-aix-tdep.c: Update.
5552         * rs6000-tdep.c: Update.
5553         * rust-exp.y: Update.
5554         * rust-lang.c: Update.
5555         * s390-tdep.c: Update.
5556         * selftest-arch.c: Update.
5557         * solib-dsbt.c: Update.
5558         * solib-frv.c: Update.
5559         * solib-spu.c: Update.
5560         * solib-svr4.c: Update.
5561         * solib.c: Update.
5562         * sparc64-linux-tdep.c: Update.
5563         * stack.c: Update.
5564         * symfile-mem.c: Update.
5565         * symmisc.c: Update.
5566         * target.c: Update.
5567         * thread.c: Update.
5568         * top.c: Update.
5569         * tracefile-tfile.c: Update.
5570         * tui/tui.c: Update.
5571         * typeprint.c: Update.
5572         * unittests/cli-utils-selftests.c: Update.
5573         * unittests/parse-connection-spec-selftests.c: Update.
5574         * valops.c: Update.
5575         * valprint.c: Update.
5576         * value.c: Update.
5577         * varobj.c: Update.
5578         * windows-nat.c: Update.
5579         * x86-linux-nat.c: Update.
5580         * xml-support.c: Update.
5581
5582 2019-04-08  Tom Tromey  <tom@tromey.com>
5583
5584         * xml-support.c: Use C++ exception handling.
5585         * x86-linux-nat.c: Use C++ exception handling.
5586         * windows-nat.c: Use C++ exception handling.
5587         * varobj.c: Use C++ exception handling.
5588         * value.c: Use C++ exception handling.
5589         * valprint.c: Use C++ exception handling.
5590         * valops.c: Use C++ exception handling.
5591         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5592         handling.
5593         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5594         * typeprint.c: Use C++ exception handling.
5595         * tui/tui.c: Use C++ exception handling.
5596         * tracefile-tfile.c: Use C++ exception handling.
5597         * top.c: Use C++ exception handling.
5598         * thread.c: Use C++ exception handling.
5599         * target.c: Use C++ exception handling.
5600         * symmisc.c: Use C++ exception handling.
5601         * symfile-mem.c: Use C++ exception handling.
5602         * stack.c: Use C++ exception handling.
5603         * sparc64-linux-tdep.c: Use C++ exception handling.
5604         * solib.c: Use C++ exception handling.
5605         * solib-svr4.c: Use C++ exception handling.
5606         * solib-spu.c: Use C++ exception handling.
5607         * solib-frv.c: Use C++ exception handling.
5608         * solib-dsbt.c: Use C++ exception handling.
5609         * selftest-arch.c: Use C++ exception handling.
5610         * s390-tdep.c: Use C++ exception handling.
5611         * rust-lang.c: Use C++ exception handling.
5612         * rust-exp.y: Use C++ exception handling.
5613         * rs6000-tdep.c: Use C++ exception handling.
5614         * rs6000-aix-tdep.c: Use C++ exception handling.
5615         * riscv-tdep.c: Use C++ exception handling.
5616         * remote.c: Use C++ exception handling.
5617         * remote-fileio.c: Use C++ exception handling.
5618         * record-full.c: Use C++ exception handling.
5619         * record-btrace.c: Use C++ exception handling.
5620         * python/python.c: Use C++ exception handling.
5621         * python/py-value.c: Use C++ exception handling.
5622         * python/py-utils.c: Use C++ exception handling.
5623         * python/py-unwind.c: Use C++ exception handling.
5624         * python/py-type.c: Use C++ exception handling.
5625         * python/py-symbol.c: Use C++ exception handling.
5626         * python/py-record.c: Use C++ exception handling.
5627         * python/py-record-btrace.c: Use C++ exception handling.
5628         * python/py-progspace.c: Use C++ exception handling.
5629         * python/py-prettyprint.c: Use C++ exception handling.
5630         * python/py-param.c: Use C++ exception handling.
5631         * python/py-objfile.c: Use C++ exception handling.
5632         * python/py-linetable.c: Use C++ exception handling.
5633         * python/py-lazy-string.c: Use C++ exception handling.
5634         * python/py-infthread.c: Use C++ exception handling.
5635         * python/py-inferior.c: Use C++ exception handling.
5636         * python/py-gdb-readline.c: Use C++ exception handling.
5637         * python/py-framefilter.c: Use C++ exception handling.
5638         * python/py-frame.c: Use C++ exception handling.
5639         * python/py-finishbreakpoint.c: Use C++ exception handling.
5640         * python/py-cmd.c: Use C++ exception handling.
5641         * python/py-breakpoint.c: Use C++ exception handling.
5642         * python/py-arch.c: Use C++ exception handling.
5643         * printcmd.c: Use C++ exception handling.
5644         * ppc-linux-tdep.c: Use C++ exception handling.
5645         * parse.c: Use C++ exception handling.
5646         * p-valprint.c: Use C++ exception handling.
5647         * objc-lang.c: Use C++ exception handling.
5648         * mi/mi-main.c: Use C++ exception handling.
5649         * mi/mi-interp.c: Use C++ exception handling.
5650         * mi/mi-cmd-stack.c: Use C++ exception handling.
5651         * mi/mi-cmd-break.c: Use C++ exception handling.
5652         * main.c: Use C++ exception handling.
5653         * linux-thread-db.c: Use C++ exception handling.
5654         * linux-tdep.c: Use C++ exception handling.
5655         * linux-nat.c: Use C++ exception handling.
5656         * linux-fork.c: Use C++ exception handling.
5657         * linespec.c: Use C++ exception handling.
5658         * language.c: Use C++ exception handling.
5659         * jit.c: Use C++ exception handling.
5660         * infrun.c: Use C++ exception handling.
5661         * infcmd.c: Use C++ exception handling.
5662         * infcall.c: Use C++ exception handling.
5663         * inf-loop.c: Use C++ exception handling.
5664         * i386-tdep.c: Use C++ exception handling.
5665         * i386-linux-tdep.c: Use C++ exception handling.
5666         * guile/scm-value.c: Use C++ exception handling.
5667         * guile/scm-type.c: Use C++ exception handling.
5668         * guile/scm-symtab.c: Use C++ exception handling.
5669         * guile/scm-symbol.c: Use C++ exception handling.
5670         * guile/scm-pretty-print.c: Use C++ exception handling.
5671         * guile/scm-ports.c: Use C++ exception handling.
5672         * guile/scm-param.c: Use C++ exception handling.
5673         * guile/scm-math.c: Use C++ exception handling.
5674         * guile/scm-lazy-string.c: Use C++ exception handling.
5675         * guile/scm-frame.c: Use C++ exception handling.
5676         * guile/scm-disasm.c: Use C++ exception handling.
5677         * guile/scm-cmd.c: Use C++ exception handling.
5678         * guile/scm-breakpoint.c: Use C++ exception handling.
5679         * guile/scm-block.c: Use C++ exception handling.
5680         * guile/guile-internal.h: Use C++ exception handling.
5681         * gnu-v3-abi.c: Use C++ exception handling.
5682         * gdbtypes.c: Use C++ exception handling.
5683         * frame.c: Use C++ exception handling.
5684         * frame-unwind.c: Use C++ exception handling.
5685         * fbsd-tdep.c: Use C++ exception handling.
5686         * f-valprint.c: Use C++ exception handling.
5687         * exec.c: Use C++ exception handling.
5688         * event-top.c: Use C++ exception handling.
5689         * event-loop.c: Use C++ exception handling.
5690         * eval.c: Use C++ exception handling.
5691         * dwarf2read.c: Use C++ exception handling.
5692         * dwarf2loc.c: Use C++ exception handling.
5693         * dwarf2-frame.c: Use C++ exception handling.
5694         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5695         * dwarf-index-write.c: Use C++ exception handling.
5696         * dwarf-index-cache.c: Use C++ exception handling.
5697         * dtrace-probe.c: Use C++ exception handling.
5698         * disasm-selftests.c: Use C++ exception handling.
5699         * darwin-nat.c: Use C++ exception handling.
5700         * cp-valprint.c: Use C++ exception handling.
5701         * cp-support.c: Use C++ exception handling.
5702         * cp-abi.c: Use C++ exception handling.
5703         * corelow.c: Use C++ exception handling.
5704         * completer.c: Use C++ exception handling.
5705         * compile/compile-object-run.c: Use C++ exception handling.
5706         * compile/compile-object-load.c: Use C++ exception handling.
5707         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5708         * compile/compile-c-symbols.c: Use C++ exception handling.
5709         * common/selftest.c: Use C++ exception handling.
5710         * common/new-op.c: Use C++ exception handling.
5711         * cli/cli-script.c: Use C++ exception handling.
5712         * cli/cli-interp.c: Use C++ exception handling.
5713         * cli/cli-cmds.c: Use C++ exception handling.
5714         * c-varobj.c: Use C++ exception handling.
5715         * btrace.c: Use C++ exception handling.
5716         * breakpoint.c: Use C++ exception handling.
5717         * break-catch-throw.c: Use C++ exception handling.
5718         * arch-utils.c: Use C++ exception handling.
5719         * amd64-tdep.c: Use C++ exception handling.
5720         * ada-valprint.c: Use C++ exception handling.
5721         * ada-typeprint.c: Use C++ exception handling.
5722         * ada-lang.c: Use C++ exception handling.
5723         * aarch64-tdep.c: Use C++ exception handling.
5724
5725 2019-04-08  Tom Tromey  <tom@tromey.com>
5726
5727         * xml-support.c (gdb_xml_parser::parse): Update.
5728         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5729         * value.c (show_convenience): Update.
5730         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5731         (test_parse_flags_qcs): Update.
5732         * thread.c (thr_try_catch_cmd): Update.
5733         * target.c (target_translate_tls_address): Update.
5734         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5735         (info_frame_command_core, frame_apply_command_count): Update.
5736         * rust-exp.y (rust_lex_exception_test): Update.
5737         * riscv-tdep.c (riscv_print_one_register_info): Update.
5738         * remote.c (remote_target::enable_btrace): Update.
5739         * record-btrace.c (record_btrace_enable_warn): Update.
5740         * python/py-utils.c (gdbpy_convert_exception): Update.
5741         * printcmd.c (do_one_display, print_variable_and_value): Update.
5742         * mi/mi-main.c (mi_print_exception): Update.
5743         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5744         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5745         * linux-nat.c (linux_nat_target::attach): Update.
5746         * linux-fork.c (class scoped_switch_fork_info): Update.
5747         * infrun.c (displaced_step_prepare): Update.
5748         * infcall.c (call_function_by_hand_dummy): Update.
5749         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5750         * gnu-v3-abi.c (print_one_vtable): Update.
5751         * frame.c (get_prev_frame_always): Update.
5752         * f-valprint.c (info_common_command_for_block): Update.
5753         * exec.c (try_open_exec_file): Update.
5754         * exceptions.c (print_exception, exception_print)
5755         (exception_fprintf, exception_print_same): Update.
5756         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5757         * dwarf-index-cache.c (index_cache::store)
5758         (index_cache::lookup_gdb_index): Update.
5759         * darwin-nat.c (maybe_cache_shell): Update.
5760         * cp-valprint.c (cp_print_value_fields): Update.
5761         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5762         (gcc_cplus_symbol_address): Update.
5763         * compile/compile-c-symbols.c (gcc_convert_symbol)
5764         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5765         * common/selftest.c: Update.
5766         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5767         a std::string.
5768         (exception_try_scope_entry, exception_try_scope_exit): Don't
5769         declare.
5770         (struct exception_try_scope): Remove.
5771         (TRY): Don't use exception_try_scope.
5772         (struct gdb_exception): Add constructor, operator=.
5773         <what>: New method.
5774         (struct gdb_exception_RETURN_MASK_ALL)
5775         (struct gdb_exception_RETURN_MASK_ERROR)
5776         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5777         (struct gdb_quit_bad_alloc): Update.
5778         * common/common-exceptions.c (exception_none): Change
5779         initializer.
5780         (struct catcher) <state, exception>: Initialize inline.
5781         <prev>: Remove member.
5782         (current_catcher): Remove.
5783         (catchers): New global.
5784         (exceptions_state_mc_init): Simplify.
5785         (catcher_pop): Remove.
5786         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5787         (try_scope_depth, exception_try_scope_entry)
5788         (exception_try_scope_exit): Remove.
5789         (throw_exception_sjlj): Update.
5790         (exception_messages, exception_messages_size): Remove.
5791         (throw_it): Simplify.
5792         (gdb_exception_sliced_copy): Remove.
5793         (throw_exception_cxx): Update.
5794         * cli/cli-script.c (script_from_file): Update.
5795         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5796         Update.
5797         * ada-valprint.c (ada_val_print): Update.
5798         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5799         (create_excep_cond_exprs): Update.
5800
5801 2019-04-08  Tom Tromey  <tom@tromey.com>
5802
5803         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5804         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5805         (TRY, CATCH, END_CATCH): Remove some definitions.
5806         * common/common-exceptions.c: Don't use GDB_XCPT.
5807         (catcher_list_size): Remove.
5808         (throw_exception, throw_it): Simplify.
5809
5810 2019-04-05  Tom Tromey  <tom@tromey.com>
5811
5812         Revert the header-sorting patch.
5813         * ft32-tdep.c: Revert.
5814         * frv-tdep.c: Revert.
5815         * frv-linux-tdep.c: Revert.
5816         * frame.c: Revert.
5817         * frame-unwind.c: Revert.
5818         * frame-base.c: Revert.
5819         * fork-child.c: Revert.
5820         * findvar.c: Revert.
5821         * findcmd.c: Revert.
5822         * filesystem.c: Revert.
5823         * filename-seen-cache.h: Revert.
5824         * filename-seen-cache.c: Revert.
5825         * fbsd-tdep.c: Revert.
5826         * fbsd-nat.h: Revert.
5827         * fbsd-nat.c: Revert.
5828         * f-valprint.c: Revert.
5829         * f-typeprint.c: Revert.
5830         * f-lang.c: Revert.
5831         * extension.h: Revert.
5832         * extension.c: Revert.
5833         * extension-priv.h: Revert.
5834         * expprint.c: Revert.
5835         * exec.h: Revert.
5836         * exec.c: Revert.
5837         * exceptions.c: Revert.
5838         * event-top.c: Revert.
5839         * event-loop.c: Revert.
5840         * eval.c: Revert.
5841         * elfread.c: Revert.
5842         * dwarf2read.h: Revert.
5843         * dwarf2read.c: Revert.
5844         * dwarf2loc.c: Revert.
5845         * dwarf2expr.h: Revert.
5846         * dwarf2expr.c: Revert.
5847         * dwarf2-frame.c: Revert.
5848         * dwarf2-frame-tailcall.c: Revert.
5849         * dwarf-index-write.h: Revert.
5850         * dwarf-index-write.c: Revert.
5851         * dwarf-index-common.c: Revert.
5852         * dwarf-index-cache.h: Revert.
5853         * dwarf-index-cache.c: Revert.
5854         * dummy-frame.c: Revert.
5855         * dtrace-probe.c: Revert.
5856         * disasm.h: Revert.
5857         * disasm.c: Revert.
5858         * disasm-selftests.c: Revert.
5859         * dictionary.c: Revert.
5860         * dicos-tdep.c: Revert.
5861         * demangle.c: Revert.
5862         * dcache.h: Revert.
5863         * dcache.c: Revert.
5864         * darwin-nat.h: Revert.
5865         * darwin-nat.c: Revert.
5866         * darwin-nat-info.c: Revert.
5867         * d-valprint.c: Revert.
5868         * d-namespace.c: Revert.
5869         * d-lang.c: Revert.
5870         * ctf.c: Revert.
5871         * csky-tdep.c: Revert.
5872         * csky-linux-tdep.c: Revert.
5873         * cris-tdep.c: Revert.
5874         * cris-linux-tdep.c: Revert.
5875         * cp-valprint.c: Revert.
5876         * cp-support.c: Revert.
5877         * cp-namespace.c: Revert.
5878         * cp-abi.c: Revert.
5879         * corelow.c: Revert.
5880         * corefile.c: Revert.
5881         * continuations.c: Revert.
5882         * completer.h: Revert.
5883         * completer.c: Revert.
5884         * complaints.c: Revert.
5885         * coffread.c: Revert.
5886         * coff-pe-read.c: Revert.
5887         * cli-out.h: Revert.
5888         * cli-out.c: Revert.
5889         * charset.c: Revert.
5890         * c-varobj.c: Revert.
5891         * c-valprint.c: Revert.
5892         * c-typeprint.c: Revert.
5893         * c-lang.c: Revert.
5894         * buildsym.c: Revert.
5895         * buildsym-legacy.c: Revert.
5896         * build-id.h: Revert.
5897         * build-id.c: Revert.
5898         * btrace.c: Revert.
5899         * bsd-uthread.c: Revert.
5900         * breakpoint.h: Revert.
5901         * breakpoint.c: Revert.
5902         * break-catch-throw.c: Revert.
5903         * break-catch-syscall.c: Revert.
5904         * break-catch-sig.c: Revert.
5905         * blockframe.c: Revert.
5906         * block.c: Revert.
5907         * bfin-tdep.c: Revert.
5908         * bfin-linux-tdep.c: Revert.
5909         * bfd-target.c: Revert.
5910         * bcache.c: Revert.
5911         * ax-general.c: Revert.
5912         * ax-gdb.h: Revert.
5913         * ax-gdb.c: Revert.
5914         * avr-tdep.c: Revert.
5915         * auxv.c: Revert.
5916         * auto-load.c: Revert.
5917         * arm-wince-tdep.c: Revert.
5918         * arm-tdep.c: Revert.
5919         * arm-symbian-tdep.c: Revert.
5920         * arm-pikeos-tdep.c: Revert.
5921         * arm-obsd-tdep.c: Revert.
5922         * arm-nbsd-tdep.c: Revert.
5923         * arm-nbsd-nat.c: Revert.
5924         * arm-linux-tdep.c: Revert.
5925         * arm-linux-nat.c: Revert.
5926         * arm-fbsd-tdep.c: Revert.
5927         * arm-fbsd-nat.c: Revert.
5928         * arm-bsd-tdep.c: Revert.
5929         * arch-utils.c: Revert.
5930         * arc-tdep.c: Revert.
5931         * arc-newlib-tdep.c: Revert.
5932         * annotate.h: Revert.
5933         * annotate.c: Revert.
5934         * amd64-windows-tdep.c: Revert.
5935         * amd64-windows-nat.c: Revert.
5936         * amd64-tdep.c: Revert.
5937         * amd64-sol2-tdep.c: Revert.
5938         * amd64-obsd-tdep.c: Revert.
5939         * amd64-obsd-nat.c: Revert.
5940         * amd64-nbsd-tdep.c: Revert.
5941         * amd64-nbsd-nat.c: Revert.
5942         * amd64-nat.c: Revert.
5943         * amd64-linux-tdep.c: Revert.
5944         * amd64-linux-nat.c: Revert.
5945         * amd64-fbsd-tdep.c: Revert.
5946         * amd64-fbsd-nat.c: Revert.
5947         * amd64-dicos-tdep.c: Revert.
5948         * amd64-darwin-tdep.c: Revert.
5949         * amd64-bsd-nat.c: Revert.
5950         * alpha-tdep.c: Revert.
5951         * alpha-obsd-tdep.c: Revert.
5952         * alpha-nbsd-tdep.c: Revert.
5953         * alpha-mdebug-tdep.c: Revert.
5954         * alpha-linux-tdep.c: Revert.
5955         * alpha-linux-nat.c: Revert.
5956         * alpha-bsd-tdep.c: Revert.
5957         * alpha-bsd-nat.c: Revert.
5958         * aix-thread.c: Revert.
5959         * agent.c: Revert.
5960         * addrmap.c: Revert.
5961         * ada-varobj.c: Revert.
5962         * ada-valprint.c: Revert.
5963         * ada-typeprint.c: Revert.
5964         * ada-tasks.c: Revert.
5965         * ada-lang.c: Revert.
5966         * aarch64-tdep.c: Revert.
5967         * aarch64-ravenscar-thread.c: Revert.
5968         * aarch64-newlib-tdep.c: Revert.
5969         * aarch64-linux-tdep.c: Revert.
5970         * aarch64-linux-nat.c: Revert.
5971         * aarch64-fbsd-tdep.c: Revert.
5972         * aarch64-fbsd-nat.c: Revert.
5973         * aarch32-linux-nat.c: Revert.
5974
5975 2019-04-05  Tom Tromey  <tom@tromey.com>
5976
5977         * ft32-tdep.c: Sort headers.
5978         * frv-tdep.c: Sort headers.
5979         * frv-linux-tdep.c: Sort headers.
5980         * frame.c: Sort headers.
5981         * frame-unwind.c: Sort headers.
5982         * frame-base.c: Sort headers.
5983         * fork-child.c: Sort headers.
5984         * findvar.c: Sort headers.
5985         * findcmd.c: Sort headers.
5986         * filesystem.c: Sort headers.
5987         * filename-seen-cache.h: Sort headers.
5988         * filename-seen-cache.c: Sort headers.
5989         * fbsd-tdep.c: Sort headers.
5990         * fbsd-nat.h: Sort headers.
5991         * fbsd-nat.c: Sort headers.
5992         * f-valprint.c: Sort headers.
5993         * f-typeprint.c: Sort headers.
5994         * f-lang.c: Sort headers.
5995         * extension.h: Sort headers.
5996         * extension.c: Sort headers.
5997         * extension-priv.h: Sort headers.
5998         * expprint.c: Sort headers.
5999         * exec.h: Sort headers.
6000         * exec.c: Sort headers.
6001         * exceptions.c: Sort headers.
6002         * event-top.c: Sort headers.
6003         * event-loop.c: Sort headers.
6004         * eval.c: Sort headers.
6005         * elfread.c: Sort headers.
6006         * dwarf2read.h: Sort headers.
6007         * dwarf2read.c: Sort headers.
6008         * dwarf2loc.c: Sort headers.
6009         * dwarf2expr.h: Sort headers.
6010         * dwarf2expr.c: Sort headers.
6011         * dwarf2-frame.c: Sort headers.
6012         * dwarf2-frame-tailcall.c: Sort headers.
6013         * dwarf-index-write.h: Sort headers.
6014         * dwarf-index-write.c: Sort headers.
6015         * dwarf-index-common.c: Sort headers.
6016         * dwarf-index-cache.h: Sort headers.
6017         * dwarf-index-cache.c: Sort headers.
6018         * dummy-frame.c: Sort headers.
6019         * dtrace-probe.c: Sort headers.
6020         * disasm.h: Sort headers.
6021         * disasm.c: Sort headers.
6022         * disasm-selftests.c: Sort headers.
6023         * dictionary.c: Sort headers.
6024         * dicos-tdep.c: Sort headers.
6025         * demangle.c: Sort headers.
6026         * dcache.h: Sort headers.
6027         * dcache.c: Sort headers.
6028         * darwin-nat.h: Sort headers.
6029         * darwin-nat.c: Sort headers.
6030         * darwin-nat-info.c: Sort headers.
6031         * d-valprint.c: Sort headers.
6032         * d-namespace.c: Sort headers.
6033         * d-lang.c: Sort headers.
6034         * ctf.c: Sort headers.
6035         * csky-tdep.c: Sort headers.
6036         * csky-linux-tdep.c: Sort headers.
6037         * cris-tdep.c: Sort headers.
6038         * cris-linux-tdep.c: Sort headers.
6039         * cp-valprint.c: Sort headers.
6040         * cp-support.c: Sort headers.
6041         * cp-namespace.c: Sort headers.
6042         * cp-abi.c: Sort headers.
6043         * corelow.c: Sort headers.
6044         * corefile.c: Sort headers.
6045         * continuations.c: Sort headers.
6046         * completer.h: Sort headers.
6047         * completer.c: Sort headers.
6048         * complaints.c: Sort headers.
6049         * coffread.c: Sort headers.
6050         * coff-pe-read.c: Sort headers.
6051         * cli-out.h: Sort headers.
6052         * cli-out.c: Sort headers.
6053         * charset.c: Sort headers.
6054         * c-varobj.c: Sort headers.
6055         * c-valprint.c: Sort headers.
6056         * c-typeprint.c: Sort headers.
6057         * c-lang.c: Sort headers.
6058         * buildsym.c: Sort headers.
6059         * buildsym-legacy.c: Sort headers.
6060         * build-id.h: Sort headers.
6061         * build-id.c: Sort headers.
6062         * btrace.c: Sort headers.
6063         * bsd-uthread.c: Sort headers.
6064         * breakpoint.h: Sort headers.
6065         * breakpoint.c: Sort headers.
6066         * break-catch-throw.c: Sort headers.
6067         * break-catch-syscall.c: Sort headers.
6068         * break-catch-sig.c: Sort headers.
6069         * blockframe.c: Sort headers.
6070         * block.c: Sort headers.
6071         * bfin-tdep.c: Sort headers.
6072         * bfin-linux-tdep.c: Sort headers.
6073         * bfd-target.c: Sort headers.
6074         * bcache.c: Sort headers.
6075         * ax-general.c: Sort headers.
6076         * ax-gdb.h: Sort headers.
6077         * ax-gdb.c: Sort headers.
6078         * avr-tdep.c: Sort headers.
6079         * auxv.c: Sort headers.
6080         * auto-load.c: Sort headers.
6081         * arm-wince-tdep.c: Sort headers.
6082         * arm-tdep.c: Sort headers.
6083         * arm-symbian-tdep.c: Sort headers.
6084         * arm-pikeos-tdep.c: Sort headers.
6085         * arm-obsd-tdep.c: Sort headers.
6086         * arm-nbsd-tdep.c: Sort headers.
6087         * arm-nbsd-nat.c: Sort headers.
6088         * arm-linux-tdep.c: Sort headers.
6089         * arm-linux-nat.c: Sort headers.
6090         * arm-fbsd-tdep.c: Sort headers.
6091         * arm-fbsd-nat.c: Sort headers.
6092         * arm-bsd-tdep.c: Sort headers.
6093         * arch-utils.c: Sort headers.
6094         * arc-tdep.c: Sort headers.
6095         * arc-newlib-tdep.c: Sort headers.
6096         * annotate.h: Sort headers.
6097         * annotate.c: Sort headers.
6098         * amd64-windows-tdep.c: Sort headers.
6099         * amd64-windows-nat.c: Sort headers.
6100         * amd64-tdep.c: Sort headers.
6101         * amd64-sol2-tdep.c: Sort headers.
6102         * amd64-obsd-tdep.c: Sort headers.
6103         * amd64-obsd-nat.c: Sort headers.
6104         * amd64-nbsd-tdep.c: Sort headers.
6105         * amd64-nbsd-nat.c: Sort headers.
6106         * amd64-nat.c: Sort headers.
6107         * amd64-linux-tdep.c: Sort headers.
6108         * amd64-linux-nat.c: Sort headers.
6109         * amd64-fbsd-tdep.c: Sort headers.
6110         * amd64-fbsd-nat.c: Sort headers.
6111         * amd64-dicos-tdep.c: Sort headers.
6112         * amd64-darwin-tdep.c: Sort headers.
6113         * amd64-bsd-nat.c: Sort headers.
6114         * alpha-tdep.c: Sort headers.
6115         * alpha-obsd-tdep.c: Sort headers.
6116         * alpha-nbsd-tdep.c: Sort headers.
6117         * alpha-mdebug-tdep.c: Sort headers.
6118         * alpha-linux-tdep.c: Sort headers.
6119         * alpha-linux-nat.c: Sort headers.
6120         * alpha-bsd-tdep.c: Sort headers.
6121         * alpha-bsd-nat.c: Sort headers.
6122         * aix-thread.c: Sort headers.
6123         * agent.c: Sort headers.
6124         * addrmap.c: Sort headers.
6125         * ada-varobj.c: Sort headers.
6126         * ada-valprint.c: Sort headers.
6127         * ada-typeprint.c: Sort headers.
6128         * ada-tasks.c: Sort headers.
6129         * ada-lang.c: Sort headers.
6130         * aarch64-tdep.c: Sort headers.
6131         * aarch64-ravenscar-thread.c: Sort headers.
6132         * aarch64-newlib-tdep.c: Sort headers.
6133         * aarch64-linux-tdep.c: Sort headers.
6134         * aarch64-linux-nat.c: Sort headers.
6135         * aarch64-fbsd-tdep.c: Sort headers.
6136         * aarch64-fbsd-nat.c: Sort headers.
6137         * aarch32-linux-nat.c: Sort headers.
6138
6139 2019-04-04  Tom Tromey  <tom@tromey.com>
6140
6141         * varobj.c (varobj_create): Update.
6142         * rust-exp.y (struct rust_parser) <update_innermost_block,
6143         lookup_symbol>: New methods.
6144         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6145         Rename.
6146         (rust_parser::rust_lookup_type)
6147         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6148         * printcmd.c (display_command, do_one_display): Update.
6149         * parser-defs.h (struct parser_state) <parser_state>: Add
6150         "tracker" parameter.
6151         (block_tracker): New member.
6152         (class innermost_block_tracker) <innermost_block_tracker>: Add
6153         "types" parameter.
6154         <reset>: Remove method.
6155         (innermost_block): Don't declare.
6156         (null_post_parser): Update.
6157         * parse.c (innermost_block): Remove global.
6158         (write_dollar_variable): Update.
6159         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6160         Remove "tracker_types" parameter.
6161         (parse_expression): Add "tracker" parameter.
6162         (parse_expression_for_completion): Update.
6163         (null_post_parser): Add "tracker" parameter.
6164         * p-exp.y: Update rules.
6165         * m2-exp.y: Update rules.
6166         * language.h (struct language_defn) <la_post_parser>: Add
6167         "tracker" parameter.
6168         * go-exp.y: Update rules.
6169         * f-exp.y: Update rules.
6170         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6171         parameter.
6172         * d-exp.y: Update rules.
6173         * c-exp.y: Update rules.
6174         * breakpoint.c (set_breakpoint_condition): Create an
6175         innermost_block_tracker.
6176         (watch_command_1): Likewise.
6177         * ada-lang.c (resolve): Add "tracker" parameter.
6178         (resolve_subexp): Likewise.
6179         * ada-exp.y (write_var_from_sym): Update.
6180
6181 2019-04-04  Tom Tromey  <tom@tromey.com>
6182
6183         * type-stack.h: New file.
6184         * type-stack.c: New file.
6185         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6186         type-stack.h.
6187         (insert_into_type_stack, insert_type, push_type, push_type_int)
6188         (insert_type_address_space, pop_type, pop_type_int)
6189         (pop_typelist, pop_type_stack, append_type_stack)
6190         (push_type_stack, get_type_stack, push_typelist)
6191         (follow_type_instance_flags, follow_types): Don't declare.
6192         * parse.c (type_stack): Remove global.
6193         (parse_exp_in_context): Update.
6194         (insert_into_type_stack, insert_type, push_type, push_type_int)
6195         (insert_type_address_space, pop_type, pop_type_int)
6196         (pop_typelist, pop_type_stack, append_type_stack)
6197         (push_type_stack, get_type_stack, push_typelist)
6198         (follow_type_instance_flags, follow_types): Remove (moved to
6199         type-stack.c).
6200         * f-exp.y (type_stack): New global.
6201         Update rules.
6202         (push_kind_type, f_parse): Update.
6203         * d-exp.y (type_stack): New global.
6204         Update rules.
6205         (d_parse): Update.
6206         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6207         Update rules.
6208         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6209         (HFILES_NO_SRCDIR): Add type-stack.h.
6210
6211 2019-04-04  Tom Tromey  <tom@tromey.com>
6212
6213         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6214         (rust_parser::convert_ast_to_expression, rust_parse)
6215         (rust_lex_test_completion, rust_lex_tests): Update.
6216         * parser-defs.h (struct expr_completion_state): New.
6217         (struct parser_state) <parser_state>: Add completion parameter.
6218         <mark_struct_expression, mark_completion_tag>: New methods.
6219         <parse_completion, m_completion_state>: New members.
6220         (prefixify_expression, null_post_parser): Update.
6221         (mark_struct_expression, mark_completion_tag): Don't declare.
6222         * parse.c (parse_completion, expout_last_struct)
6223         (expout_tag_completion_type, expout_completion_name): Remove
6224         globals.
6225         (parser_state::mark_struct_expression)
6226         (parser_state::mark_completion_tag): Now methods.
6227         (prefixify_expression): Add last_struct parameter.
6228         (prefixify_subexp): Likewise.
6229         (parse_exp_1): Update.
6230         (parse_exp_in_context): Add cstate parameter.  Update.
6231         (parse_expression_for_completion): Create an
6232         expr_completion_state.
6233         (null_post_parser): Add "completion" parameter.
6234         * p-exp.y: Update rules.
6235         (yylex): Update.
6236         * language.h (struct language_defn) <la_post_parser>: Add
6237         "completing" parameter.
6238         * go-exp.y: Update rules.
6239         (lex_one_token): Update.
6240         * expression.h (parse_completion): Don't declare.
6241         * d-exp.y: Update rules.
6242         (lex_one_token): Update rules.
6243         * c-exp.y: Update rules.
6244         (lex_one_token): Update.
6245         * ada-lang.c (resolve): Add "parse_completion" parameter.
6246         (resolve_subexp): Likewise.
6247         (ada_resolve_function): Likewise.
6248
6249 2019-04-04  Tom Tromey  <tom@tromey.com>
6250
6251         * parser-defs.h (struct parser_state) <start_arglist,
6252         end_arglist>: New methods.
6253         <arglist_len, m_funcall_chain>: New members.
6254         (arglist_len, start_arglist, end_arglist): Don't declare.
6255         * parse.c (arglist_len, funcall_chain): Remove global.
6256         (start_arglist, end_arglist): Remove functions.
6257         (parse_exp_in_context): Update.
6258         * p-exp.y: Update rules.
6259         * m2-exp.y: Update rules.
6260         * go-exp.y: Update rules.
6261         * f-exp.y: Update rules.
6262         * d-exp.y: Update rules.
6263         * c-exp.y: Update rules.
6264
6265 2019-04-04  Tom Tromey  <tom@tromey.com>
6266
6267         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6268         lex_operator, push_back>: New methods.
6269         Update all rules.
6270         (rust_parser::lex_hex, lex_escape): Rename and update.
6271         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6272         (rust_parser::lex_operator): Rename and update.
6273         (rust_parser::lex_number, rustyylex, rustyyerror)
6274         (rust_lex_test_init, rust_lex_test_sequence)
6275         (rust_lex_test_push_back, rust_lex_tests): Update.
6276         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6277         parameter.
6278         <lexptr, prev_lexptr>: New members.
6279         (lexptr, prev_lexptr): Don't declare.
6280         * parse.c (lexptr, prev_lexptr): Remove globals.
6281         (parse_exp_in_context): Update.
6282         * p-exp.y (yylex, yyerror): Update.
6283         * m2-exp.y (parse_number, yylex, yyerror): Update.
6284         * go-exp.y (lex_one_token, yyerror): Update.
6285         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6286         * d-exp.y (lex_one_token, yyerror): Update.
6287         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6288         (lex_one_token, yyerror): Update.
6289         * ada-lex.l (YY_INPUT): Update.
6290         (rewind_to_char): Update.
6291         * ada-exp.y (yyerror): Update.
6292
6293 2019-04-04  Tom Tromey  <tom@tromey.com>
6294
6295         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6296         * parser-defs.h (struct parser_state) <parser_state>: Add new
6297         parameter.
6298         <comma_terminates>: New member.
6299         (comma_terminates): Don't declare global.
6300         * parse.c (comma_terminates): Remove global.
6301         (parse_exp_in_context): Update.
6302         * p-exp.y (yylex): Update.
6303         * m2-exp.y (yylex): Update.
6304         * go-exp.y (lex_one_token): Update.
6305         * f-exp.y (yylex): Update.
6306         * d-exp.y (lex_one_token): Update.
6307         * c-exp.y (lex_one_token): Update.
6308         * ada-lex.l: Update.
6309
6310 2019-04-04  Tom Tromey  <tom@tromey.com>
6311
6312         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6313         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6314         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6315         * parser-defs.h (paren_depth): Don't declare.
6316         * parse.c (paren_depth): Remove global.
6317         (parse_exp_in_context): Update.
6318         * p-exp.y (paren_depth): New global.
6319         (pascal_parse): Initialize it.
6320         * m2-exp.y (paren_depth): New global.
6321         (m2_parse): Initialize it.
6322         * go-exp.y (paren_depth): New global.
6323         (go_parse): Initialize it.
6324         * f-exp.y (paren_depth): New global.
6325         (f_parse): Initialize it.
6326         * d-exp.y (paren_depth): New global.
6327         (d_parse): Initialize it.
6328         * c-exp.y (paren_depth): New global.
6329         (c_parse): Initialize it.
6330         * ada-lex.l (paren_depth): New global.
6331         (lexer_init): Initialize it.
6332
6333 2019-04-04  Tom Tromey  <tom@tromey.com>
6334
6335         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6336         (rust_parser::convert_ast_to_type)
6337         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6338         * parser-defs.h (struct parser_state) <parser_state>: Add
6339         parameters.  Initialize new members.
6340         <expression_context_block, expression_context_pc>: New members.
6341         * parse.c (expression_context_block, expression_context_pc):
6342         Remove globals.
6343         (parse_exp_in_context): Update.
6344         * p-exp.y: Update all rules.
6345         (yylex): Update.
6346         * m2-exp.y: Update all rules.
6347         (yylex): Update.
6348         * go-exp.y (yylex): Update.
6349         * f-exp.y (yylex): Update.
6350         * d-exp.y: Update all rules.
6351         (yylex): Update.
6352         * c-exp.y: Update all rules.
6353         (lex_one_token, classify_name, yylex, c_parse): Update.
6354         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6355
6356 2019-04-04  Tom Tromey  <tom@tromey.com>
6357
6358         * gdbarch.h, gdbarch.c: Rebuild.
6359         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6360         * stap-probe.h:
6361         (struct stap_parse_info): Replace "parser_state" with
6362         "expr_builder".
6363         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6364         (parser_state): New class.
6365         * parse.c (expr_builder): Rename.
6366         (expr_builder::release): Rename.
6367         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6368         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6369         (write_exp_elt_longcst, write_exp_elt_floatcst)
6370         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6371         (write_exp_string_vector, write_exp_bitstring)
6372         (write_exp_msymbol, mark_struct_expression)
6373         (write_dollar_variable)
6374         (insert_type_address_space, increase_expout_size): Replace
6375         "parser_state" with "expr_builder".
6376         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6377         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6378         "parser_state" with "expr_builder".
6379
6380 2019-04-04  Tom Tromey  <tom@tromey.com>
6381
6382         * rust-exp.y: Replace "parse_language" with method call.
6383         * p-exp.y:
6384         (yylex): Replace "parse_language" with method call.
6385         * m2-exp.y:
6386         (yylex): Replace "parse_language" with method call.
6387         * go-exp.y (classify_name): Replace "parse_language" with method
6388         call.
6389         * f-exp.y (yylex): Replace "parse_language" with method call.
6390         * d-exp.y (lex_one_token): Replace "parse_language" with method
6391         call.
6392         * c-exp.y:
6393         (lex_one_token, classify_name, yylex): Replace "parse_language"
6394         with method call.
6395         * ada-exp.y (find_primitive_type, type_char)
6396         (type_system_address): Replace "parse_language" with method call.
6397
6398 2019-04-04  Tom Tromey  <tom@tromey.com>
6399
6400         * rust-exp.y: Replace "parse_gdbarch" with method call.
6401         * parse.c (write_dollar_variable, insert_type_address_space):
6402         Replace "parse_gdbarch" with method call.
6403         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6404         call.
6405         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6406         call.
6407         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6408         "parse_gdbarch" with method call.
6409         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6410         with method call.
6411         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6412         "parse_gdbarch" with method call.
6413         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6414         "parse_gdbarch" with method call.
6415         * c-exp.y (parse_type, parse_number, classify_name): Replace
6416         "parse_gdbarch" with method call.
6417         * ada-lex.l: Replace "parse_gdbarch" with method call.
6418         * ada-exp.y (parse_type, find_primitive_type, type_char)
6419         (type_system_address): Replace "parse_gdbarch" with method call.
6420
6421 2019-04-04  Tom Tromey  <tom@tromey.com>
6422
6423         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6424         * stap-probe.c (stap_parse_argument): Update.
6425         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6426         initial_size parameter.
6427         * rust-exp.y (rust_lex_tests): Update.
6428         * parse.c (parser_state): Update.
6429         (parse_exp_in_context): Update.
6430         * parser-defs.h (struct parser_state) <parser_state>: Remove
6431         "initial_size" parameter.
6432
6433 2019-04-04  Tom Tromey  <tom@tromey.com>
6434
6435         * parser-defs.h (increase_expout_size): Don't declare.
6436         * parse.c (increase_expout_size): Now static.
6437
6438 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6439
6440         * gnu-nat.c (gnu_nat_target::wait): Fix
6441         target_waitstatus_to_string call.
6442
6443 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * eval.c (evaluate_subexp_standard): Handle internal functions
6446         during Fortran function call handling.
6447
6448 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6449
6450         * NEWS: Mention new internal functions.
6451         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6452         (read_base_type): Use dwarf2_init_complex_target_type.
6453         * value.c (creal_internal_fn): New function.
6454         (cimag_internal_fn): New function.
6455         (_initialize_values): Register new internal functions.
6456
6457 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6458
6459         * infrun.c (stop_all_threads): If debug_infrun, always
6460         trace the wait status after wait_one, using
6461         target_waitstatus_to_string and target_pid_to_str.
6462         (handle_inferior_event): Replace various trace of
6463         wait status kind by a single trace.
6464         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6465         wait status kind image by target_waitstatus_to_string.
6466         * target/waitstatus.c (target_waitstatus_to_string): Fix
6467         obsolete comment.
6468
6469 2019-04-01  Tom Tromey  <tromey@adacore.com>
6470
6471         PR symtab/23331:
6472         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6473
6474 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6475             Pedro Alves  <palves@redhat.com>
6476
6477         * top.c (quit_force): Call 'finalize_values'.
6478         * value.c (finalize_values): New function.
6479         * value.h (finalize_values): Declare.
6480
6481 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6482
6483         * NEWS: Announce $_gdb_major and $_gdb_minor.
6484
6485         * top.c (init_gdb_version_vars): New function.
6486         (gdb_init): Call init_gdb_version_vars.
6487
6488 2019-03-29  Tom Tromey  <tromey@adacore.com>
6489
6490         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6491         help text.  Remove dead code.
6492
6493 2019-03-29  Keith Seitz  <keiths@redhat.com>
6494
6495         From Siddhesh Poyarekar:
6496         * f-lang.h (f77_get_upperbound): Return LONGEST.
6497         (f77_get_lowerbound): Likewise.
6498         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6499         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6500         print them.
6501         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6502         plongest to format print it.
6503         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6504         (f77_get_upperbound): Likewise.
6505         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6506         LOWER_BOUND to LONGEST.
6507         (f77_create_arrayprint_offset_tbl): Likewise.
6508
6509 2019-03-29  Keith Seitz  <keiths@redhat.com>
6510
6511         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6512         %s/pulongest for TYPE_LENGTH instead of %d in format
6513         strings.
6514         * ada-typerint.c (ada_print_type): Likewise.
6515         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6516         * compile/compile-c-support.c (generate_register_struct): Likewise.
6517         * gdbtypes.c (recursive_dump_type): Likewise.
6518         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6519         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6520         instead of %d in format strings.
6521         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6522         to std::min to ULONGEST.
6523         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6524         instead of %d in format strings.
6525         * tracepoint.c (info_scope_command): Likewise.
6526         * typeprint.c (print_offset_data::update)
6527         (print_offset_data::finish): Likewise.
6528         * xtensa-tdep.c (xtensa_store_return_value)
6529         (xtensa_push_dummy_call): Likewise.
6530
6531 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6532
6533         * windows-nat.c (display_selector): Fixed format specifications
6534         for 64-bit Cygwin.
6535
6536 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6537
6538         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6539
6540 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6541
6542         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6543         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6544         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6545         (nios2_linux_init_abi): Install it.
6546
6547 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6548
6549         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6550
6551 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6552
6553         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6554
6555 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6556             Tom Tromey  <tromey@adacore.com>
6557
6558         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6559
6560 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6561
6562         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6563         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6564         method to compute the bounds of range types. Also print "[evaluated]"
6565         if the bounds' values come from a dynamic evaluation.
6566
6567 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6570         whitespace when pretty printing is on.
6571
6572 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6573
6574         * ppc-linux-nat.c: Add include.
6575
6576 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6577
6578         * NEWS: Mention AArch64 Pointer Authentication.
6579
6580 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6581
6582         * arm-linux-nat.c: Add include.
6583
6584 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6585
6586         * source-cache.c (source_cache::get_source_lines): Re-read
6587         fullname after calling open_source_file.
6588
6589 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6590
6591         * NEWS: Mention TLS support for FreeBSD.
6592
6593 2019-03-25  Tom Tromey  <tromey@adacore.com>
6594
6595         * minsyms.c (BUNCH_SIZE): Update comment.
6596         (~minimal_symbol_reader): Remove old comment.
6597         (compact_minimal_symbols): Update comment.
6598         (minimal_symbol_reader::install): Remove old comment.  Update
6599         other comments.
6600
6601 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6602
6603         * s390-linux-nat.c: Add include.
6604
6605 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6606
6607         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6608         Call linux_get_hwcap.
6609         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6610         Likewise.
6611         (aarch64_linux_get_hwcap): Remove function.
6612         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6613         declaration.
6614         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6615         linux_get_hwcap.
6616         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6617         * linux-tdep.c (linux_get_hwcap): Add function.
6618         (linux_get_hwcap2): Likewise.
6619         * linux-tdep.h (linux_get_hwcap): Add declaration.
6620         (linux_get_hwcap2): Likewise.
6621         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6622         (ppc_linux_get_hwcap2): Likewise.
6623         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6624         linux_get_hwcap.
6625         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6626         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6627         (ppc_linux_nat_target::read_description): Likewise.
6628         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6629         * s390-linux-nat.c: Likewise.
6630         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6631
6632 2019-03-24  Tom Tromey  <tom@tromey.com>
6633
6634         * ada-lang.c (standard_lookup): Simplify initialization.
6635         (ada_lookup_symbol_nonlocal): Simplify return.
6636         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6637         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6638         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6639         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6640         initialization.
6641         * solib.c (solib_global_lookup): Simplify.
6642         * symtab.c (null_block_symbol): Remove.
6643         (symbol_cache_lookup): Simplify returns.
6644         (lookup_language_this): Simplify returns.
6645         (lookup_symbol_aux): Simplify return.
6646         (lookup_local_symbol): Simplify returns.
6647         (lookup_global_symbol_from_objfile): Simplify return.
6648         (lookup_symbol_in_objfile_symtabs)
6649         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6650         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6651         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6652         * cp-namespace.c (cp_lookup_bare_symbol)
6653         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6654         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6655         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6656         (cp_lookup_symbol_via_imports): Simplify initialization.
6657         (find_symbol_in_baseclass): Likewise.
6658         * symtab.h (null_block_symbol): Remove.
6659         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6660         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6661         (d_lookup_symbol_module): Likewise.
6662         (find_symbol_in_baseclass): Simplify initialization.
6663
6664 2019-03-24  Tom Tromey  <tom@tromey.com>
6665
6666         * expression.h: Don't include symtab.h.
6667         (struct block): Forward declare.
6668
6669 2019-03-24  Tom Tromey  <tom@tromey.com>
6670
6671         * c-exp.y (typebase): Remove casts.
6672         * gdbtypes.c (lookup_unsigned_typename, )
6673         (lookup_signed_typename): Remove cast.
6674         * eval.c (parse_to_comma_and_eval): Remove cast.
6675         * parse.c (write_dollar_variable): Remove cast.
6676         * block.h (struct block) <superblock>: Now const.
6677         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6678         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6679         (map_block): Make "block" const.
6680         * symfile.h (struct quick_symbol_functions)
6681         <map_matching_symbols>: Constify block argument to "callback".
6682         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6683         const.
6684         (find_pc_sect_compunit_symtab): Make "b" const.
6685         (find_symbol_at_address): Likewise.
6686         (search_symbols): Likewise.
6687         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6688         (dw2_debug_names_lookup_symbol): Likewise.
6689         (dw2_map_matching_symbols): Update.
6690         * p-valprint.c (pascal_val_print): Remove "block".
6691         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6692         (aux_add_nonlocal_symbols): Make "block" const.
6693         (resolve_subexp): Remove cast.
6694         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6695         const.
6696         (iterate_over_file_blocks): Likewise.
6697         * f-exp.y (%union) <bval>: Remove.
6698         * coffread.c (patch_opaque_types): Make "b" const.
6699         * spu-tdep.c (spu_catch_start): Make "block" const.
6700         * c-valprint.c (print_unpacked_pointer): Remove "block".
6701         * symmisc.c (dump_symtab_1): Make "b" const.
6702         (block_depth): Make "block" const.
6703         * d-exp.y (%union) <bval>: Remove.
6704         * cp-support.h (cp_lookup_rtti_type): Update.
6705         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6706         * psymtab.c (psym_lookup_symbol): Make "block" const.
6707         (maintenance_check_psymtabs): Make "b" const.
6708         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6709         (enumerate_locals, enumerate_args): Update.
6710         * python/py-symtab.c (stpy_global_block): Make "block" const.
6711         (stpy_static_block): Likewise.
6712         * inline-frame.c (block_starting_point_at): Make "new_block"
6713         const.
6714         * block.c (find_block_in_blockvector): Make return type const.
6715         (blockvector_for_pc_sect): Make "b" const.
6716         (find_block_in_blockvector): Make "b" const.
6717
6718 2019-03-23  Tom Tromey  <tom@tromey.com>
6719
6720         * varobj.c (varobj_create): Update.
6721         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6722         * printcmd.c (display_command, do_one_display): Don't reset
6723         innermost_block.
6724         * parser-defs.h (enum innermost_block_tracker_type): Move to
6725         expression.h.
6726         (innermost_block): Update comment.
6727         * parse.c (parse_exp_1): Add tracker_types parameter.
6728         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6729         tracker_types parameter.  Reset innermost_block.
6730         (parse_exp_in_context): Remove.
6731         (parse_expression_for_completion): Update.
6732         * objfiles.c (~objfile): Don't reset expression_context_block or
6733         innermost_block.
6734         * expression.h (enum innermost_block_tracker_type): Move from
6735         parser-defs.h.
6736         (parse_exp_1): Add tracker_types parameter.
6737         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6738         reset innermost_block.
6739
6740 2019-03-23  Tom Tromey  <tom@tromey.com>
6741
6742         * objfiles.h: Include bcache.h.
6743
6744 2019-03-23  Tom Tromey  <tom@tromey.com>
6745
6746         * linespec.c (get_current_search_block): Use
6747         scoped_restore_current_language.
6748         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6749
6750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6751             Jiong Wang  <jiong.wang@arm.com>
6752
6753         * aarch64-linux-tdep.c
6754         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6755         section.
6756         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6757
6758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6759             Jiong Wang  <jiong.wang@arm.com>
6760
6761         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6762         instructions.
6763         (aarch64_analyze_prologue_test): Add PACIASP test.
6764         (aarch64_prologue_prev_register): Unmask PC value.
6765
6766 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6767             Jiong Wang  <jiong.wang@arm.com>
6768
6769         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6770         (aarch64_dwarf2_prev_register): Unmask PC value.
6771         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6772         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6773         DW_CFA_AARCH64_negate_ra_state.
6774         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6775
6776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6777             Jiong Wang  <jiong.wang@arm.com>
6778
6779         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6780         registers.
6781         (aarch64_pseudo_register_name): Likewise.
6782         (aarch64_pseudo_register_type): Likewise.
6783         (aarch64_pseudo_register_reggroup_p): Likewise.
6784         (aarch64_gdbarch_init): Add pauth registers.
6785         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6786         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6787         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6788         (struct gdbarch_tdep): Add regnum for ra_state.
6789
6790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6791             Jiong Wang  <jiong.wang@arm.com>
6792
6793         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6794
6795 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6796             Jiong Wang  <jiong.wang@arm.com>
6797
6798         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6799         function.
6800         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6801         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6802         (aarch64_gdbarch_init): Add puth registers.
6803         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6804         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6805         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6806
6807 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6808             Jiong Wang  <jiong.wang@arm.com>
6809
6810         * aarch64-linux-nat.c
6811         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6812         * aarch64-linux-tdep.c
6813         (aarch64_linux_core_read_description): Likewise.
6814         (aarch64_linux_get_hwcap): New function.
6815         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6816         (aarch64_linux_get_hwcap): New declaration.
6817
6818 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6819             Jiong Wang  <jiong.wang@arm.com>
6820
6821         * aarch64-linux-nat.c
6822         (aarch64_linux_nat_target::read_description): Add pauth param.
6823         * aarch64-linux-tdep.c
6824         (aarch64_linux_core_read_description): Likewise.
6825         * aarch64-tdep.c (struct target_desc): Add in pauth.
6826         (aarch64_read_description): Add pauth param.
6827         (aarch64_gdbarch_init): Likewise.
6828         * aarch64-tdep.h (aarch64_read_description): Likewise.
6829         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6830         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6831         * features/Makefile: Add new files.
6832         * features/aarch64-pauth.c: New file.
6833         * features/aarch64-pauth.xml: New file.
6834
6835 2019-03-20  Tom Tromey  <tromey@adacore.com>
6836
6837         * infrun.c (handle_inferior_event): Rename from
6838         handle_inferior_event_1.  Create a scoped_value_mark.
6839         (handle_inferior_event): Remove.
6840
6841 2019-03-19  Tom Tromey  <tromey@adacore.com>
6842
6843         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6844         * infrun.h (print_stop_event): Add "displays" parameter.
6845         * infrun.c (print_stop_event): Add "displays" parameter.
6846
6847 2019-03-19  Pedro Alves  <palves@redhat.com>
6848
6849         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6850         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6851         to -1.  Fix TABs vs spaces.
6852         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6853         * tui/tui-out.h (tui_ui_out) Add intro comments.
6854         <m_line, m_start_of_line>: In-class initialize, and add describing
6855         comment.
6856
6857 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6858
6859         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6860         variable names.
6861         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6862
6863 2019-03-18  Pedro Alves  <palves@redhat.com>
6864             Eli Zaretskii <eliz@gnu.org>
6865
6866         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6867         m_line and m_start_of_line.
6868
6869 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6870
6871         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6872         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6873         it returns a newline.  This fixes a regression in TU mode, whereby
6874         the next line is output on the same screen line as the user input.
6875
6876 2019-03-18  Tom Tromey  <tromey@adacore.com>
6877
6878         * minsyms.c (minimal_symbol_reader::install): Remove call to
6879         obstack_blank.
6880
6881 2019-03-18  Pedro Alves  <palves@redhat.com>
6882
6883         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6884         New globals.
6885         (apply_style): New, factored out from ...
6886         (apply_ansi_escape): ... this.  Handle reverse video mode.
6887         (tui_set_reverse_mode): New function.
6888         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6889         * tui/tui-winsource.c (tui_show_source_line): Use
6890         tui_set_reverse_mode instead of setting A_STANDOUT.
6891         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6892         New setter methods.
6893
6894 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6895
6896         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6897         Handle tabs.
6898
6899 2019-03-18  Tom Tromey  <tromey@adacore.com>
6900
6901         * ada-lang.c (empty_array): Add "high" parameter.
6902         (ada_evaluate_subexp): Update.
6903
6904 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6905
6906         * unittests/string_view-selftests.c: Define
6907         _initialize_string_view_selftests unconditionally.
6908
6909 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6910
6911         PR gdb/24350
6912         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6913
6914 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6915
6916         PR gdb/24351
6917         * windows-nat.c (display_selector): Fix format specifiers.
6918
6919 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6920
6921         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6922         tui_refill_source_window instead of tui_refresh_win, to update the
6923         current execution line.  This fixes redisplay of the current line
6924         when stepping through the code with "next" or "step".
6925
6926 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6927
6928         * source-cache.c (source_cache::get_source_lines): Call
6929         find_source_lines to initialize s->nlines.  This fixes vertical
6930         scrolling of TUI source window when the DOWN arrow is pressed.
6931
6932 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6933
6934         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6935         linux-thread-db.c (_initialize_thread_db): Likewise.
6936
6937 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6938
6939         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6940         wclrtoeol in tui_show_source_line".  This reverts changes made in
6941         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6942
6943 2019-03-15  Tom Tromey  <tom@tromey.com>
6944
6945         * symtab.h (struct minimal_symbol): Derive from
6946         general_symbol_info.
6947         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6948         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6949         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6950         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6951         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6952         (MSYMBOL_SEARCH_NAME): Update.
6953         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6954         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6955         * minsyms.c (minimal_symbol_reader::record_full): Update.
6956
6957 2019-03-15  Tom Tromey  <tom@tromey.com>
6958
6959         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6960
6961 2019-03-15  Tom Tromey  <tom@tromey.com>
6962
6963         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6964         unique_xmalloc_ptr.
6965         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6966         Update.
6967         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6968         (build_minimal_symbol_hash_tables)
6969         (minimal_symbol_reader::install): Update.
6970
6971 2019-03-15  Tom Tromey  <tom@tromey.com>
6972
6973         * symtab.c (create_demangled_names_hash): Update.
6974         (symbol_set_names): Update.
6975         * objfiles.h (struct objfile_per_bfd_storage)
6976         <demangled_names_hash>: Now an htab_up.
6977         * objfiles.c (objfile_per_bfd_storage): Simplify.
6978
6979 2019-03-15  Tom Tromey  <tom@tromey.com>
6980
6981         * objfiles.h (struct objfile_per_bfd_storage): Declare
6982         destructor.
6983         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6984         New.
6985         (get_objfile_bfd_data): Use new.  Don't initialize
6986         language_of_main.
6987         (free_objfile_per_bfd_storage): Remove.
6988         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6989
6990 2019-03-15  Tom Tromey  <tom@tromey.com>
6991
6992         * symfile.c (reread_symbols): Update.
6993         * objfiles.c (objfile::objfile): Update.
6994         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6995         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6996         comment.
6997         (minimal_symbol_reader::install): Update.
6998         (terminate_minimal_symbol_table): Remove.
6999         * jit.c (jit_object_close_impl): Update.
7000
7001 2019-03-15  Tom Tromey  <tom@tromey.com>
7002
7003         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7004         initializations.
7005
7006 2019-03-15  Tom Tromey  <tom@tromey.com>
7007
7008         * objfiles.h (struct objfile_per_bfd_storage)
7009         <demangled_hash_languages>: Now a bitset.
7010         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7011         (lookup_minimal_symbol): Update.
7012
7013 2019-03-15  Tom Tromey  <tom@tromey.com>
7014
7015         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7016         Don't return the symbol.
7017         * coffread.c (record_minimal_symbol): Use record_full.
7018
7019 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7020
7021         The MS-Windows port of ncurses fails to switch to a color pair if
7022         one or both of the colors are the implicit default colors.  This
7023         change records the default colors when TUI is initialized, and
7024         then specifies them explicitly when a color pair uses the default
7025         colors.  This allows color styling in TUI mode on MS-Windows.
7026
7027         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7028         ncurses_norm_attr.
7029         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7030         colors in ncurses_norm_attr.
7031         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7032         "none", replace it with the default color recorded in
7033         ncurses_norm_attr.
7034
7035 2019-03-14  Tom Tromey  <tromey@adacore.com>
7036
7037         * source-cache.h (class source_cache) <get_source_lines>: Return
7038         std::string.
7039         * source-cache.c (source_cache::extract_lines): Handle case where
7040         first_pos==npos.  Return std::string.
7041         (source_cache::get_source_lines): Update.
7042
7043 2019-03-14  Tom Tromey  <tromey@adacore.com>
7044
7045         * NEWS: Add item for "style sources" commands.
7046         * source-cache.c (source_cache::get_source_lines): Check
7047         source_styling.
7048         * cli/cli-style.c (source_styling): New global.
7049         (_initialize_cli_style): Add "style sources" commands.
7050         (show_style_sources): New function.
7051         * cli/cli-style.h (source_styling): Declare.
7052
7053 2019-03-14  Pedro Alves  <palves@redhat.com>
7054             Tom Tromey  <tromey@adacore.com>
7055
7056         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7057         * tui/tui-winsource.c (tui_refill_source_window): New function,
7058         from...
7059         (tui_horizontal_source_scroll): ... here.  Move some logic.
7060         * cli/cli-style.c (set_style_enabled): Notify new observable.
7061         * tui/tui-hooks.c (tui_redisplay_source): New function.
7062         (tui_attach_detach_observers): Attach or detach
7063         tui_redisplay_source.
7064         * observable.h (source_styling_changed): New observable.
7065         * observable.c: Define source_styling_changed observable.
7066
7067 2019-03-13  Tom Tromey  <tromey@adacore.com>
7068
7069         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7070         (i386_gnu_nat_target::store_registers): Update.
7071         * target-debug.h (target_debug_print_std_string): New macro.
7072         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7073         * windows-tdep.c (display_one_tib): Update.
7074         * tui/tui-stack.c (tui_make_status_line): Update.
7075         * top.c (print_inferior_quit_action): Update.
7076         * thread.c (thr_try_catch_cmd): Update.
7077         (add_thread_with_info): Update.
7078         (thread_target_id_str): Update.
7079         (thr_try_catch_cmd): Update.
7080         (thread_command): Update.
7081         (thread_find_command): Update.
7082         * record-btrace.c (record_btrace_target::info_record)
7083         (record_btrace_resume_thread, record_btrace_target::resume)
7084         (record_btrace_cancel_resume, record_btrace_step_thread)
7085         (record_btrace_target::wait, record_btrace_target::wait)
7086         (record_btrace_target::wait, record_btrace_target::stop): Update.
7087         * progspace.c (print_program_space): Update.
7088         * process-stratum-target.c
7089         (process_stratum_target::thread_address_space): Update.
7090         * linux-fork.c (linux_fork_mourn_inferior)
7091         (detach_checkpoint_command, info_checkpoints_command)
7092         (linux_fork_context): Update.
7093         (linux_fork_detach): Update.
7094         (class scoped_switch_fork_info): Update.
7095         (delete_checkpoint_command): Update.
7096         * infrun.c (follow_fork_inferior): Update.
7097         (follow_fork_inferior): Update.
7098         (proceed_after_vfork_done): Update.
7099         (handle_vfork_child_exec_or_exit): Update.
7100         (follow_exec): Update.
7101         (displaced_step_prepare_throw): Update.
7102         (displaced_step_restore): Update.
7103         (start_step_over): Update.
7104         (resume_1): Update.
7105         (clear_proceed_status_thread): Update.
7106         (proceed): Update.
7107         (print_target_wait_results): Update.
7108         (do_target_wait): Update.
7109         (context_switch): Update.
7110         (stop_all_threads): Update.
7111         (restart_threads): Update.
7112         (finish_step_over): Update.
7113         (handle_signal_stop): Update.
7114         (switch_back_to_stepped_thread): Update.
7115         (keep_going_pass_signal): Update.
7116         (print_exited_reason): Update.
7117         (normal_stop): Update.
7118         * inferior.c (inferior_pid_to_str): Change return type.
7119         (print_selected_inferior): Update.
7120         (add_inferior): Update.
7121         (detach_inferior): Update.
7122         * dummy-frame.c (fprint_dummy_frames): Update.
7123         * dcache.c (dcache_info_1): Update.
7124         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7125         (btrace_fetch, btrace_clear): Update.
7126         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7127         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7128         type.
7129         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7130         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7131         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7132         * gdbarch.c, gdbarch.h: Rebuild.
7133         * gdbarch.sh (core_pid_to_str): Change return type.
7134         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7135         return type.
7136         (windows_nat_target::pid_to_str): Change return type.
7137         (windows_delete_thread): Update.
7138         (windows_nat_target::attach): Update.
7139         (windows_nat_target::files_info): Update.
7140         * target-delegates.c: Rebuild.
7141         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7142         return type.
7143         (sol_thread_target::pid_to_str): Change return type.
7144         * remote.c (class remote_target) <pid_to_str>: Change return
7145         type.
7146         (remote_target::pid_to_str): Change return type.
7147         (extended_remote_target::attach, remote_target::remote_stop_ns)
7148         (remote_target::remote_notif_remove_queued_reply)
7149         (remote_target::push_stop_reply, remote_target::disable_btrace):
7150         Update.
7151         (extended_remote_target::attach): Update.
7152         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7153         type.
7154         (gdbsim_target::pid_to_str): Change return type.
7155         * ravenscar-thread.c (struct ravenscar_thread_target)
7156         <pid_to_str>: Change return type.
7157         (ravenscar_thread_target::pid_to_str): Change return type.
7158         * procfs.c (class procfs_target) <pid_to_str>: Change return
7159         type.
7160         (procfs_target::pid_to_str): Change return type.
7161         (procfs_target::attach): Update.
7162         (procfs_target::detach): Update.
7163         (procfs_target::fetch_registers): Update.
7164         (procfs_target::store_registers): Update.
7165         (procfs_target::wait): Update.
7166         (procfs_target::files_info): Update.
7167         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7168         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7169         return type.
7170         (nto_procfs_target::pid_to_str): Change return type.
7171         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7172         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7173         return type.
7174         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7175         (exit_lwp): Update.
7176         (attach_proc_task_lwp_callback, get_detach_signal)
7177         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7178         (linux_nat_target::resume, wait_lwp, stop_callback)
7179         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7180         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7181         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7182         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7183         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7184         type.
7185         (inf_ptrace_target::attach): Update.
7186         (inf_ptrace_target::files_info): Update.
7187         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7188         type.
7189         (go32_nat_target::pid_to_str): Change return type.
7190         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7191         (gnu_nat_target::wait): Update.
7192         (gnu_nat_target::wait): Update.
7193         (gnu_nat_target::resume): Update.
7194         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7195         (fbsd_nat_target::wait): Update.
7196         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7197         type.
7198         (darwin_nat_target::attach): Update.
7199         * corelow.c (class core_target) <pid_to_str>: Change return type.
7200         (core_target::pid_to_str): Change return type.
7201         * target.c (normal_pid_to_str): Change return type.
7202         (default_pid_to_str): Likewise.
7203         (target_pid_to_str): Change return type.
7204         (target_translate_tls_address): Update.
7205         (target_announce_detach): Update.
7206         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7207         return type.
7208         (bsd_uthread_target::pid_to_str): Change return type.
7209         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7210         type.
7211         (bsd_kvm_target::pid_to_str): Change return type.
7212         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7213         return type.
7214         (aix_thread_target::pid_to_str): Change return type.
7215         * target.h (struct target_ops) <pid_to_str>: Change return type.
7216         (target_pid_to_str, normal_pid_to_str): Likewise.
7217         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7218         type.
7219         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7220         type.
7221         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7222         return type.
7223         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7224         type.
7225         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7226         type.
7227         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7228         return type.
7229
7230 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7231
7232         * NEWS: Mention that the new default MI version is 3.  Mention
7233         changes to the output of commands and events that deal with
7234         multi-location breakpoints.
7235         * breakpoint.c: Include "mi/mi-out.h".
7236         (print_one_breakpoint): Change output syntax if using MI version
7237         >= 3.
7238         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7239         New.
7240         (mi_multi_location_breakpoint_output_fixed): New.
7241         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7242         (mi_cmd_fix_multi_location_breakpoint_output): New.
7243         (mi_multi_location_breakpoint_output_fixed): New.
7244         * mi/mi-cmds.c (mi_cmds): Register command
7245         -fix-multi-location-breakpoint-output.
7246         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7247         interpreter "mi".
7248
7249 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7250
7251         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7252         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7253         instantiate mi_ui_out based on interpreter name.
7254         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7255         * mi/mi-main.c (mi_load_progress): Likewise.
7256
7257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7258
7259         * NEWS: Combine separate "New targets" sections for 8.3.
7260
7261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7262
7263         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7264         (ppcfbsd_init_abi): Install gdbarch
7265         "fetch_tls_load_module_address" and "get_thread_local_address"
7266         methods.
7267
7268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7269
7270         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7271         (riscv_fbsd_init_abi): Install gdbarch
7272         "fetch_tls_load_module_address" and "get_thread_local_address"
7273         methods.
7274
7275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7276
7277         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7278         (i386fbsd_init_abi): Install gdbarch
7279         "fetch_tls_load_module_address" and "get_thread_local_address"
7280         methods.
7281
7282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7283
7284         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7285         (amd64fbsd_init_abi): Install gdbarch
7286         "fetch_tls_load_module_address" and "get_thread_local_address"
7287         methods.
7288
7289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7290
7291         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7292         (struct fbsd_pspace_data): New type.
7293         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7294         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7295         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7296         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7297         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7298
7299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7300
7301         * gdbtypes.c (lookup_struct_elt): New function.
7302         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7303         * gdbtypes.h (struct struct_elt): New type.
7304         (lookup_struct_elt): New prototype.
7305
7306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7307
7308         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7309         remove disabled code block.
7310
7311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7312
7313         * gdbarch.sh (get_thread_local_address): New method.
7314         * gdbarch.h, gdbarch.c: Regenerate.
7315         * target.c (target_translate_tls_address): Use
7316         gdbarch_get_thread_local_address if present instead of
7317         target::get_thread_local_address.
7318
7319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7320
7321         * target.h (target::get_thread_local_address): Update comment.
7322
7323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7324
7325         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7326         objfile->separate_debug_objfile_backlink if not NULL.
7327
7328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7329
7330         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7331         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7332         (amd64bsd_store_inferior_registers): Likewise.
7333         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7334         Enable segment base registers.
7335         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7336         PT_GETFSBASE and PT_GETGSBASE.
7337         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7338         PT_SETGSBASE.
7339         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7340         segment base registers.
7341         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7342
7343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7344
7345         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7346         Update calls to i386_target_description to add 'segments'
7347         parameter.
7348         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7349         add segment base registers.
7350         * arch/i386.c (i386_create_target_description): Add 'segments'
7351         parameter to enable segment base registers.
7352         * arch/i386.h (i386_create_target_description): Likewise.
7353         * features/i386/32bit-segments.xml: New file.
7354         * features/i386/32bit-segments.c: Generate.
7355         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7356         call to i386_target_description to add 'segments' parameter.
7357         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7358         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7359         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7360         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7361         if feature is present.
7362         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7363         Add 'segments' parameter to call to i386_target_description.
7364         (i386_target_description): Add 'segments' parameter to enable
7365         segment base registers.
7366         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7367         to call to i386_target_description.
7368         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7369         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7370         Define I386_NUM_REGS.
7371         (i386_target_description): Add 'segments' parameter to enable
7372         segment base registers.
7373
7374 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7375
7376         PR/24325
7377         * source-cache.c: #undef open and close, to avoid unresolved
7378         externals during linking.
7379
7380 2019-03-12  Tom Tromey  <tromey@adacore.com>
7381
7382         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7383         const.  Add initializers.
7384         (_initialize_remote): Don't initialize ptid globals.
7385
7386 2019-03-12  Pedro Alves  <palves@redhat.com>
7387
7388         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7389
7390 2019-03-12  Pedro Alves  <palves@redhat.com>
7391
7392         * cp-name-parser.y (main): Remove unused 'len' variable.
7393
7394 2019-03-12  Tom Tromey  <tromey@adacore.com>
7395
7396         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7397         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7398
7399 2019-03-12  Tom Tromey  <tromey@adacore.com>
7400
7401         * linux-nat.c (iterate_over_lwps): Update.
7402         (stop_callback): Remove parameter.
7403         (stop_wait_callback, detach_callback, resume_set_callback)
7404         (select_singlestep_lwp_callback, set_ignore_sigint)
7405         (status_callback, resumed_callback, resume_clear_callback)
7406         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7407         data parameter.
7408         (linux_nat_target::detach, linux_nat_target::resume)
7409         (linux_stop_and_wait_all_lwps, select_event_lwp)
7410         (linux_nat_filter_event, linux_nat_wait_1)
7411         (linux_nat_target::kill, linux_nat_target::stop)
7412         (linux_nat_target::stop): Update.
7413         (linux_nat_resume_callback): Change type.
7414         (resume_stopped_resumed_lwps, count_events_callback)
7415         (select_event_lwp_callback): Likewise.
7416         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7417         * arm-linux-nat.c (struct update_registers_data): Remove.
7418         (update_registers_callback): Change type.
7419         (arm_linux_insert_hw_breakpoint1): Update.
7420         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7421         parameter.
7422         (x86_linux_dr_set_addr): Update.
7423         (x86_linux_dr_set_control): Update.
7424         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7425         (iterate_over_lwps): Use gdb::function_view.
7426         * nat/aarch64-linux-hw-point.c (struct
7427         aarch64_dr_update_callback_param): Remove.
7428         (debug_reg_change_callback): Change type.
7429         (aarch64_notify_debug_reg_change): Update.
7430         * s390-linux-nat.c (s390_refresh_per_info): Update.
7431
7432 2019-03-11  Tom Tromey  <tromey@adacore.com>
7433
7434         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7435         redundant assignment to "this_cu".
7436
7437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7438
7439         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7440
7441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7442
7443         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7444         from...
7445         (rank_one_type): ... this.
7446
7447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7448
7449         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7450         from...
7451         (rank_one_type): ... this.
7452
7453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7454
7455         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7456         from...
7457         (rank_one_type): ... this.
7458
7459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7460
7461         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7462         from...
7463         (rank_one_type): ... this.
7464
7465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7466
7467         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7468         from...
7469         (rank_one_type): ... this.
7470
7471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7472
7473         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7474         from...
7475         (rank_one_type): ... this.
7476
7477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7478
7479         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7480         from...
7481         (rank_one_type): ... this.
7482
7483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7484
7485         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7486         from...
7487         (rank_one_type): ... this.
7488
7489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7490
7491         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7492         from...
7493         (rank_one_type): ... this.
7494
7495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7496
7497         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7498         from...
7499         (rank_one_type): ... this.
7500
7501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7502
7503         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7504         from...
7505         (rank_one_type): ... this.
7506
7507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7508
7509         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7510         from...
7511         (rank_one_type): ... this.
7512
7513 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7514
7515         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7516         inferior-events' shows the example events.
7517
7518 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7519
7520         Support styling on native MS-Windows console
7521
7522         PR/24315
7523         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7524         on MS-Windows if $TERM is not defined.
7525
7526         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7527
7528         * posix-hdep.c (gdb_console_fputs):
7529         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7530         functions.
7531         * ui-file.h (gdb_console_fputs): Add prototype.
7532
7533         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7534         back to fputs only if the former returns zero.
7535
7536 2019-03-07  Tom Tromey  <tom@tromey.com>
7537
7538         * symmisc.c (print_symbol_bcache_statistics): Update.
7539         (print_objfile_statistics): Update.
7540         * symfile.c (allocate_symtab): Update.
7541         * stabsread.c: Don't include bcache.h.
7542         * psymtab.h (struct psymbol_bcache): Don't declare.
7543         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7544         (psymbol_bcache_init, psymbol_bcache_free)
7545         (psymbol_bcache_get_bcache): Don't declare.
7546         * psymtab.c (struct psymbol_bcache): Remove.
7547         (psymtab_storage::psymtab_storage): Update.
7548         (psymtab_storage::~psymtab_storage): Update.
7549         (psymbol_bcache_init, psymbol_bcache_free)
7550         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7551         (add_psymbol_to_bcache): Update.
7552         (allocate_psymtab): Update.
7553         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7554         macro_cache>: No longer pointers.
7555         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7556         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7557         * macrotab.c (macro_bcache): Update.
7558         * macroexp.c: Don't include bcache.h.
7559         * gdbtypes.c (check_types_worklist): Update.
7560         (types_deeply_equal): Remove TRY/CATCH.  Update.
7561         * elfread.c (elf_symtab_read): Update.
7562         * dwarf2read.c: Don't include bcache.h.
7563         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7564         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7565         (print_bcache_statistics, bcache_memory_used): Don't declare.
7566         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7567         methods.  Rename all data members.
7568         * bcache.c (struct bcache): Move to bcache.h.
7569         (bcache::expand_hash_table): Rename from expand_hash_table.
7570         (bcache): Remove.
7571         (bcache::insert): Rename from bcache_full.
7572         (bcache::compare): Rename from bcache_compare.
7573         (bcache_xmalloc): Remove.
7574         (bcache::~bcache): Rename from bcache_xfree.
7575         (bcache::print_statistics): Rename from print_bcache_statistics.
7576         (bcache::memory_used): Rename from bcache_memory_used.
7577
7578 2019-03-07  Pedro Alves  <palves@redhat.com>
7579
7580         * infrun.c (normal_stop): Also check for
7581         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7582
7583 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7584
7585         * f-lang.c (value_from_host_double): Moved to...
7586         * value.c (value_from_host_double): ...here.
7587         * value.h (value_from_host_double): Declare.
7588         * guile/scm-math.c (vlscm_convert_typed_number): Use
7589         value_from_host_double.
7590         (vlscm_convert_number): Likewise.
7591         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7592         * python/py-value.c (convert_value_from_python): Likewise.
7593
7594 2019-03-06  Tom Tromey  <tom@tromey.com>
7595
7596         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7597
7598 2019-03-06  Tom Tromey  <tom@tromey.com>
7599
7600         * utils.h (free_current_contents): Don't declare.
7601         * utils.c (free_current_contents): Remove.
7602
7603 2019-03-06  Tom Tromey  <tom@tromey.com>
7604
7605         * top.c (quit_force): Update.
7606         * main.c (captured_command_loop): Update.
7607         * common/new-op.c (operator new): Update.
7608         * common/common-exceptions.c (struct catcher)
7609         <save_cleanup_chain>: Remove member.
7610         (exceptions_state_mc_init): Update.
7611         (exception_try_scope_entry): Return nullptr.
7612         (exception_try_scope_exit, exception_rethrow)
7613         (throw_exception_sjlj, throw_exception_cxx): Update.
7614         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7615         (all_cleanups, do_cleanups, discard_cleanups)
7616         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7617         (restore_cleanups, restore_final_cleanups): Don't declare.
7618         (do_final_cleanups): Remove parameter.
7619         * common/cleanups.c (cleanup_chain, make_cleanup)
7620         (make_cleanup_dtor, all_cleanups, do_cleanups)
7621         (discard_my_cleanups, discard_cleanups)
7622         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7623         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7624         (null_cleanup): Remove.
7625         (do_final_cleanups): Remove parameter.
7626
7627 2019-03-06  Tom Tromey  <tom@tromey.com>
7628
7629         * remote.c (remote_target::remote_parse_stop_reply): Use
7630         unique_xmalloc_ptr.
7631
7632 2019-03-06  Tom Tromey  <tom@tromey.com>
7633
7634         * stabsread.c (struct stabs_field_info): Rename from field_info.
7635         <list, fnlist>: Add initializers.
7636         <obstack>: New member.
7637         (read_member_functions, read_struct_fields, read_baseclasses):
7638         Allocate on obstack.  Don't use cleanups.
7639         (read_one_struct_field, read_member_functions, read_struct_fields)
7640         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7641         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7642         (read_struct_type): Update.
7643
7644 2019-03-06  Tom Tromey  <tom@tromey.com>
7645
7646         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7647         * common/filestuff.h (make_cleanup_close): Don't declare.
7648         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7649         Remove.
7650
7651 2019-03-06  Tom Tromey  <tom@tromey.com>
7652
7653         * solib-aix.c: Use make_scope_exit.
7654
7655 2019-03-06  Tom Tromey  <tom@tromey.com>
7656
7657         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7658         Use make_scope_exit.
7659
7660 2019-03-06  Tom Tromey  <tom@tromey.com>
7661
7662         * solib-svr4.c (disable_probes_interface): Remove parameter.
7663         (svr4_handle_solib_event): Use make_scope_exit.
7664
7665 2019-03-06  Tom Tromey  <tom@tromey.com>
7666
7667         * remote.c (struct stop_reply_deleter): Remove.
7668         (stop_reply_up): Update.
7669         (struct stop_reply): Derive from notif_event.  Don't typedef.
7670         <regcache>: Now a std::vector.
7671         (stop_reply_xfree): Remove.
7672         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7673         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7674         (remote_target::discard_pending_stop_replies): Use delete.
7675         (remote_target::remote_parse_stop_reply): Update.
7676         (remote_target::process_stop_reply): Update.
7677         * remote-notif.h (struct notif_event): Add virtual destructor.
7678         Remove "dtr" member.
7679         (struct notif_client) <alloc_event>: Return a unique_ptr.
7680         (notif_event_xfree): Don't declare.
7681         (notif_event_up): New typedef.
7682         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7683         (notif_event_xfree, do_notif_event_xfree): Remove.
7684         (remote_notif_state_xfree): Update.
7685
7686 2019-03-06  Tom Tromey  <tom@tromey.com>
7687
7688         * infrun.c (displaced_step_clear_cleanup): Now a
7689         forward_scope_exit type.
7690         (displaced_step_prepare_throw): Update.
7691         (displaced_step_fixup): Update.
7692
7693 2019-03-06  Tom Tromey  <tom@tromey.com>
7694
7695         * inferior.h (class inferior): Update comment.
7696         * gdbthread.h (class thread_info): Update comment.
7697
7698 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7699             Tom Tromey  <tom@tromey.com>
7700
7701         * stabsread.h (struct stab_section_list): Remove.
7702         (coffstab_build_psymtabs): Update.
7703         * dbxread.c (symbuf_sections): Now a std::vector.
7704         (sect_idx): New global.
7705         (fill_symbuf): Update.
7706         (coffstab_build_psymtabs): Change type of stabsects parameter.
7707         Update.
7708         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7709         std::vector.
7710         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7711         (coff_locate_sections): Update.
7712         (coff_symfile_read): Remove cleanups.  Update.
7713         (init_stringtab): Add storage parameter.
7714         (free_stringtab, free_stringtab_cleanup): Remove.
7715         (init_lineno): Add storage parameter.
7716         (free_linetab, free_linetab_cleanup): Remove.
7717
7718 2019-03-06  Pedro Alves  <palves@redhat.com>
7719
7720         * linux-fork.c (fork_info::clobber_regs): Delete.
7721         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7722         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7723         comment.  Adjust.
7724         (scoped_switch_fork_info::scoped_switch_fork_info)
7725         (checkpoint_command, linux_fork_context): Adjust
7726         fork_save_infrun_state calls.
7727
7728 2019-03-06  Pedro Alves  <palves@redhat.com>
7729
7730         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7731         (inf_has_multiple_threads): Return 'bool' and rewrite using
7732         inferior_info::threads().
7733
7734 2019-03-06  Pedro Alves  <palves@redhat.com>
7735
7736         * linux-fork.c: Include <list>.
7737         (fork_list): Now a std::list instance.
7738         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7739         (forks_exist_p, find_last_fork): Adjust.
7740         (new_fork): Delete.
7741         (one_fork_p): New.
7742         (add_fork): Adjust.
7743         (free_fork): Delete, folded into fork_info::~fork_info().
7744         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7745         Adjust.
7746         (init_fork_list): Delete.
7747         (linux_fork_killall, linux_fork_mourn_inferior)
7748         (linux_fork_detach, info_checkpoints_command): Adjust.
7749         (_initialize_linux_fork): No longer call init_fork_list.
7750
7751 2019-03-06  Pedro Alves  <palves@redhat.com>
7752
7753         * linux-fork.c (new_fork): New, split out of ...
7754         (add_fork): ... this.  Return void.  Move "first fork" special
7755         case from here, to ...
7756         (checkpoint_command): ... here.
7757         * linux-linux.h (add_fork): Return void.
7758
7759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7762
7763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7764             Chris January  <chris.january@arm.com>
7765             David Lecomber  <david.lecomber@arm.com>
7766
7767         * f-exp.y: New token, UNOP_INTRINSIC.
7768         (exp): New pattern using UNOP_INTRINSIC token.
7769         (f77_keywords): Add 'abs' keyword.
7770         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7771         (value_from_host_double): New function.
7772         (evaluate_subexp_f): Support UNOP_ABS.
7773
7774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7777         types.
7778
7779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7782         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7783         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7784
7785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7788
7789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7790             Chris January  <chris.january@arm.com>
7791
7792         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7793         * f-exp.y: Define 'KIND' token.
7794         (exp): New pattern for KIND expressions.
7795         (ptype): Handle types with a kind extension.
7796         (direct_abs_decl): Extend to spot kind extensions.
7797         (f77_keywords): Add 'kind' to the list.
7798         (push_kind_type): New function.
7799         (convert_to_kind_type): New function.
7800         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7801         * parse.c (operator_length_standard): Likewise.
7802         * parser-defs.h (enum type_pieces): Add tp_kind.
7803         * std-operator.def: Add UNOP_KIND.
7804
7805 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7806
7807         * f-exp.y (f_parse): Set yydebug.
7808
7809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * f-lang.c (evaluate_subexp_f): New function.
7812         (exp_descriptor_f): New global.
7813         (f_language_defn): Use exp_descriptor_f instead of
7814         exp_descriptor_standard.
7815
7816 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7817
7818         * f-exp.y (struct token): Add comments.
7819         (dot_ops): Remove uppercase versions and the end marker.
7820         (f77_keywords): Likewise.
7821         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7822         entries in the dot_ops array are case insensitive, and use
7823         strncasecmp to compare strings.  Also some whitespace cleanup in
7824         this area.  Similar for the f77_keywords array, except entries in
7825         this list might be case sensitive.
7826
7827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7828
7829         * f-exp.y (struct f77_boolean_val): Add comments.
7830         (boolean_values): Remove uppercase versions, and end marker.
7831         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7832         and use strncasecmp to achieve case insensitivity.  Additionally,
7833         perform whitespace cleanup around this code.
7834
7835 2019-03-06  Tom Tromey  <tromey@adacore.com>
7836
7837         * remote-sim.c (gdbsim_target_open): Use result of
7838         gdb_argv::release.
7839
7840 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7841         Dirk Schubert  <dirk.schubert@arm.com>
7842         Chris January  <chris.january@arm.com>
7843
7844         * eval.c (evaluate_subexp_standard): Call Fortran argument
7845         wrapping logic.
7846         * f-lang.c (struct value): A value which can be passed into a
7847         Fortran function call.
7848         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7849         where appropriate.
7850         (struct type): Value ready for a Fortran function call.
7851         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7852         is needed.
7853         * f-lang.h (fortran_argument_convert): Declaration.
7854         (fortran_preserve_arg_pointer): Declaration.
7855         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7856
7857 2019-03-05  Tom Tromey  <tromey@adacore.com>
7858
7859         * python/py-prettyprint.c (print_string_repr): Remove #if.
7860         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7861
7862 2019-03-05  Tom Tromey  <tromey@adacore.com>
7863
7864         * target.c (the_dummy_target): Move later.  Change type to
7865         "dummy_target".
7866         (initialize_targets): Don't initialize the_dummy_target.
7867
7868 2019-03-05  Tom Tromey  <tromey@adacore.com>
7869
7870         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7871         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7872
7873 2019-03-05  Tom Tromey  <tromey@adacore.com>
7874
7875         * windows-nat.c (windows_nat_target::attach)
7876         (windows_nat_target::detach): Don't call gdb_flush.
7877         * valprint.c (generic_val_print, val_print, val_print_string):
7878         Don't call gdb_flush.
7879         * utils.c (defaulted_query): Don't call gdb_flush.
7880         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7881         * target.c (target_announce_detach): Don't call gdb_flush.
7882         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7883         * remote.c (extended_remote_target::attach): Don't call
7884         gdb_flush.
7885         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7886         * printcmd.c (do_examine): Don't call gdb_flush.
7887         (info_display_command): Don't call gdb_flush.
7888         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7889         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7890         * memattr.c (info_mem_command): Don't call gdb_flush.
7891         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7892         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7893         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7894         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7895         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7896         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7897         (gnu_nat_target::detach): Don't call gdb_flush.
7898         * f-valprint.c (f_val_print): Don't call gdb_flush.
7899         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7900         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7901         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7902         gdb_flush.
7903         * c-valprint.c (c_val_print): Don't call gdb_flush.
7904         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7905
7906 2019-03-05  Tom Tromey  <tromey@adacore.com>
7907
7908         * varobj.c (update_dynamic_varobj_children): Update.
7909         (install_default_visualizer): Use reset, not release.
7910         * value.c (set_internalvar): Update.
7911         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7912         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7913         ATTRIBUTE_UNUSED_RESULT.
7914
7915 2019-03-05  Tom Tromey  <tromey@adacore.com>
7916
7917         * remote.c (class scoped_remote_fd) <release>: Add
7918         ATTRIBUTE_UNUSED_RESULT.
7919
7920 2019-03-05  Tom Tromey  <tromey@adacore.com>
7921
7922         * macroexp.c (struct macro_buffer) <release>: Add
7923         ATTRIBUTE_UNUSED_RESULT.
7924
7925 2019-03-05  Tom Tromey  <tromey@adacore.com>
7926
7927         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7928         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7929         ATTRIBUTE_UNUSED_RESULT.
7930
7931 2019-03-05  Tom Tromey  <tromey@adacore.com>
7932
7933         * common/scoped_fd.h (class scoped_fd) <release>: Add
7934         ATTRIBUTE_UNUSED_RESULT.
7935
7936 2019-03-05  Tom Tromey  <tromey@adacore.com>
7937
7938         * parser-defs.h (struct parser_state) <release>: Add
7939         ATTRIBUTE_UNUSED_RESULT.
7940
7941 2019-03-05  Tom Tromey  <tromey@adacore.com>
7942
7943         * utils.h (class gdb_argv) <release>: Add
7944         ATTRIBUTE_UNUSED_RESULT.
7945         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7946
7947 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7948
7949         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7950         for-loop range, to avoid compiler warnings.
7951
7952         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7953         avoid compiler warnings about unused variables.
7954
7955         * NEWS: Mention end of support for native debugging on MS-Windows
7956         before XP.
7957
7958         PR gdb/24292
7959         * common/netstuff.c:
7960         * gdbserver/gdbreplay.c
7961         * gdbserver/remote-utils.c:
7962         * ser-tcp.c:
7963         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7964         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7965         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7966         'getaddrinfo' and 'freeaddrinfo' were not available before
7967         Windows XP, and mingw.org's MinGW headers by default define
7968         _WIN32_WINNT to 0x500.
7969
7970 2019-03-01  Gary Benson <gbenson@redhat.com>
7971
7972         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7973
7974 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7975             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7976
7977         PR gdb/8527
7978         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7979         set_sigint_trap, clear_sigint_trap.
7980
7981 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7982
7983         * target.c (target_detach): Clear the regcache and the
7984         frame cache.
7985
7986 2019-02-27  Pedro Alves  <palves@redhat.com>
7987
7988         * utils.c (set_screen_size): When we cap the height/width sizes,
7989         tweak the corresponding command variable to show "unlimited":
7990
7991 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7992             Pedro Alves  <palves@redhat.com>
7993
7994         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7995         before calling rl_set_screen_size.
7996
7997 2019-02-27  Tom Tromey  <tromey@adacore.com>
7998
7999         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8000         define.
8001         * python/py-value.c: Remove Python 2.4 workaround.
8002         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8003         workaround.
8004         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8005         Python 2.4 workaround.
8006         * python/python-internal.h: Remove Python 2.4 comment.
8007         (Py_ssize_t): Don't define.
8008         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8009         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8010         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8011         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8012         * python/python.c (do_start_initialization): Remove Python 2.4
8013         workaround.
8014         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8015         (print_children): Remove Python 2.4 workaround.
8016         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8017         workaround.
8018         (CHARBUFFERPROC_NAME): Remove.
8019         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8020         Python 2.4 workaround.
8021
8022 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8023
8024         * NEWS: Note minimum Python version.
8025
8026 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8027
8028         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8029         code from these functions.  Remove corresponding ifdefs.  Use
8030         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8031         Remove gotos and target of gotos.
8032         (infpy_search_memory): Likewise.
8033
8034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8037         (hppa_gdbarch_init): Don't register deleted functions with
8038         gdbarch.
8039
8040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8043         (h8300_unwind_sp): Delete.
8044         (h8300_dummy_id): Delete.
8045         (h8300_gdbarch_init): Don't register deleted functions with
8046         gdbarch.
8047
8048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8051         (ft32_unwind_pc): Delete.
8052         (ft32_unwind_sp): Delete.
8053         (ft32_gdbarch_init): Don't register deleted functions with
8054         gdbarch.
8055
8056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8059         (frv_unwind_pc): Delete.
8060         (frv_unwind_sp): Delete.
8061         (frv_gdbarch_init): Don't register deleted functions with
8062         gdbarch.
8063
8064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8067         (riscv_unwind_pc): Delete.
8068         (riscv_unwind_sp): Delete.
8069         (riscv_gdbarch_init): Don't register deleted functions with
8070         gdbarch.
8071
8072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8073
8074         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8075         (csky_unwind_pc): Delete.
8076         (csky_unwind_sp): Delete.
8077         (csky_gdbarch_init): Don't register deleted functions with
8078         gdbarch.
8079
8080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8081
8082         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8083         (cris_unwind_pc): Delete.
8084         (cris_unwind_sp): Delete.
8085         (cris_gdbarch_init): Don't register deleted functions with
8086         gdbarch.
8087
8088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8089
8090         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8091         (bfin_unwind_pc): Delete.
8092         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8093
8094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8097         (arm_unwind_pc): Delete.
8098         (arm_unwind_sp): Delete.
8099         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8100
8101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8104         (arc_unwind_pc): Delete.
8105         (arc_unwind_sp): Delete.
8106         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8107
8108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8109
8110         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8111         (alpha_unwind_pc): Delete.
8112         (alpha_gdbarch_init): Don't register deleted functions with
8113         gdbarch.
8114
8115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8116
8117         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8118         (aarch64_unwind_pc): Delete.
8119         (aarch64_unwind_sp): Delete.
8120         (aarch64_gdbarch_init): Don't register deleted functions with
8121         gdbarch.
8122
8123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * gdbtypes.c (type_align): Don't consider static members when
8126         computing structure alignment.
8127
8128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8129
8130         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8131         return 0 for other types.
8132         * arch-utils.c (default_type_align): Always return 0.
8133         * gdbarch.h: Regenerate.
8134         * gdbarch.sh (type_align): Extend comment.
8135         * gdbtypes.c (type_align): Add additional comments, always call
8136         gdbarch_type_align before applying the default rules.
8137         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8138         generic code will then apply a suitable default.
8139         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8140         types, return 0 for other types.
8141
8142 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8143
8144         * NEWS: Create a new section for the next release branch.
8145         Rename the section of the current branch, now that it has
8146         been cut.
8147
8148 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8149
8150         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8151         * version.in: Bump version to 8.3.50.DATE-git.
8152
8153 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8154
8155         * aix-thread.c (ptid_cmp): Remove unused variable.
8156         (get_signaled_thread): Likewise.
8157         (store_regs_user_thread): Likewise.
8158         (store_regs_kernel_thread): Likewise.
8159         (fetch_regs_kernel_thread): Remove shadowed variable.
8160
8161 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8162
8163         * features/riscv/32bit-cpu.xml: Add register numbers.
8164         * features/riscv/32bit-fpu.c: Regenerate.
8165         * features/riscv/32bit-fpu.xml: Add register numbers.
8166         * features/riscv/64bit-cpu.xml: Add register numbers.
8167         * features/riscv/64bit-fpu.c: Regenerate.
8168         * features/riscv/64bit-fpu.xml: Add register numbers.
8169
8170 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8171
8172         * NEWS: Mention two argument form of gdb.Value constructor.
8173         * python/py-value.c (convert_buffer_and_type_to_value): New
8174         function.
8175         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8176         Add support for handling an optional second argument.  Call
8177         convert_buffer_and_type_to_value as appropriate.
8178         * python/python-internal.h (Py_buffer_deleter): New struct.
8179         (Py_buffer_up): New typedef.
8180
8181 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8182
8183         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8184         instead of releasing ownership.
8185
8186 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8187
8188         * dwarf2read.c (open_and_init_dwp_file): Call
8189         elf_numsections instead of bfd_count_sections to initialize
8190         dwp_file->num_sections.
8191
8192 2019-02-25  Tom Tromey  <tromey@adacore.com>
8193
8194         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8195
8196 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8197
8198         * gcore.in: Add '--readnever' option when invoking GDB.
8199
8200 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8201
8202         * MAINTAINERS: Update my email address.
8203
8204 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8205
8206         * build-id.c (build_id_to_debug_bfd_1): New function.
8207         (build_id_to_debug_bfd): Look for separate debug file in
8208         sysroot.
8209
8210 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8211
8212         * gdbarch.sh: Update the copyright year range that is placed into
8213         generated files.
8214
8215 2019-02-22  Keith Seitz  <keiths@redhat.com>
8216
8217         PR symtab/23853
8218         * linespec.c (create_sals_line_offset): Search for the default
8219         symtab's filename instead of its fullname.
8220
8221 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8222
8223         * NEWS: Update style defaults.
8224
8225 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8226
8227         * main.c (captured_main_1): Disable styling in batch mode.
8228
8229 2019-02-20  Tom Tromey  <tom@tromey.com>
8230
8231         * symtab.c (symtab_symbol_info): Fix typos.
8232
8233 2019-02-20  Tom Tromey  <tromey@adacore.com>
8234
8235         * findcmd.c (_initialize_mem_search): Use upper case for
8236         metasyntactic variables.
8237
8238 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8239
8240         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8241         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8242
8243 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8244
8245         * top.h (source_file_name): Change to std::string.
8246         * top.c (source_file_name): Likewise.
8247         (command_line_input): Adjust.
8248         * cli/cli-script.c (script_from_file): Adjust.
8249
8250 2019-02-19  Tom Tromey  <tromey@adacore.com>
8251
8252         * ravenscar-thread.c
8253         (ravenscar_thread_target::update_thread_list): Don't call
8254         ada_build_task_list.
8255         * ada-lang.h (ada_build_task_list): Don't declare.
8256         * ada-tasks.c (struct ada_tasks_inferior_data)
8257         <task_list_valid_p>: Now bool.
8258         (read_known_tasks, ada_task_list_changed)
8259         (ada_tasks_invalidate_inferior_data): Update.
8260         (read_known_tasks_array): Return bool.
8261         (read_known_tasks_list): Likewise.
8262         (read_known_tasks): Return void.
8263         (ada_build_task_list): Now static.
8264
8265 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8266
8267         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8268         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8269
8270 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8271
8272         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8273         variant for ada_tasks_pspace_data_handle and
8274         ada_tasks_inferior_data_handle.
8275         (ada_tasks_pspace_data_cleanup): New function.
8276         (ada_tasks_inferior_data_cleanup): New function.
8277
8278 2019-02-17  Tom Tromey  <tom@tromey.com>
8279
8280         * macrotab.h (macro_source_fullname): Return a std::string.
8281         * macrotab.c (macro_include, check_for_redefinition)
8282         (macro_undef, macro_lookup_definition, foreach_macro)
8283         (foreach_macro_in_scope): Update.
8284         (macro_source_fullname): Return a std::string.
8285         * macrocmd.c (show_pp_source_pos): Update.
8286
8287 2019-02-17  Tom Tromey  <tom@tromey.com>
8288
8289         * macrocmd.c (show_pp_source_pos): Style the file names.
8290
8291 2019-02-17  Tom Tromey  <tom@tromey.com>
8292
8293         PR tui/24197:
8294         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8295
8296 2019-02-17  Tom Tromey  <tom@tromey.com>
8297
8298         * ada-lang.c (user_select_syms): Use filtered printing.
8299         * utils.c (wrap_style): New global.
8300         (desired_style): Remove.
8301         (emit_style_escape): Add stream parameter.
8302         (set_output_style, reset_terminal_style, prompt_for_continue):
8303         Update.
8304         (flush_wrap_buffer): Only flush gdb_stdout.
8305         (wrap_here): Set wrap_style.
8306         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8307         treat escape sequences as a character.  Change when wrap buffer is
8308         flushed.
8309         (fputs_styled): Do not set the output style when the default is
8310         requested.
8311         * ui-style.h (struct ui_file_style) <is_default>: New method.
8312         * source.c (print_source_lines_base): Emit escape sequences in one
8313         piece.
8314
8315 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8316
8317         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8318         integers and enumeration types.
8319
8320 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8321
8322         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8323         instead of lookup_symbol_in_language
8324         (do_exact_match): New function.
8325         (ada_get_symbol_name_matcher): Return do_exact_match when
8326         doing a verbatim match.
8327
8328 2019-02-15  Tom Tromey  <tromey@adacore.com>
8329
8330         * ravenscar-thread.c (ravenscar_thread_target::resume)
8331         (ravenscar_thread_target::wait): Special case wildcard requests.
8332
8333 2019-02-15  Tom Tromey  <tromey@adacore.com>
8334
8335         * ravenscar-thread.c (base_ptid): Remove.
8336         (struct ravenscar_thread_target) <close>: New method.
8337         <m_base_ptid>: New member.
8338         <update_inferior_ptid, active_task, task_is_currently_active,
8339         runtime_initialized>: Declare methods.
8340         <ravenscar_thread_target>: Add constructor.
8341         (ravenscar_thread_target::task_is_currently_active)
8342         (ravenscar_thread_target::update_inferior_ptid)
8343         (ravenscar_runtime_initialized): Rename.  Now methods.
8344         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8345         (ravenscar_thread_target::update_thread_list): Update.
8346         (ravenscar_thread_target::active_task): Now method.
8347         (ravenscar_thread_target::store_registers)
8348         (ravenscar_thread_target::prepare_to_store)
8349         (ravenscar_thread_target::prepare_to_store)
8350         (ravenscar_thread_target::mourn_inferior): Update.
8351         (ravenscar_inferior_created): Use "new" to create target.
8352         (ravenscar_thread_target::get_ada_task_ptid): Update.
8353         (_initialize_ravenscar): Don't initialize base_ptid.
8354         (ravenscar_ops): Remove global.
8355
8356 2019-02-15  Tom Tromey  <tromey@adacore.com>
8357
8358         * target.h (push_target): Declare new overload.
8359         * target.c (push_target): New overload, taking an rvalue reference.
8360         * remote.c (remote_target::open_1): Use push_target overload.
8361         * corelow.c (core_target_open): Use push_target overload.
8362
8363 2019-02-15  Tom Tromey  <tromey@adacore.com>
8364
8365         * ravenscar-thread.c (is_ravenscar_task)
8366         (ravenscar_task_is_currently_active): Return bool.
8367         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8368         (_initialize_ravenscar): Remove "(void)".
8369         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8370         Return bool.
8371
8372 2019-02-15  Tom Tromey  <tromey@adacore.com>
8373
8374         * ravenscar-thread.c (ravenscar_runtime_initializer)
8375         (has_ravenscar_runtime, get_running_thread_id)
8376         (ravenscar_thread_target::resume): Fix indentation.
8377
8378 2019-02-15  Tom Tromey  <tromey@adacore.com>
8379
8380         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8381         from ravenscar_arch_ops.
8382         (sparc_ravenscar_ops::fetch_registers)
8383         (sparc_ravenscar_ops::store_registers): Now methods.
8384         (sparc_ravenscar_prepare_to_store): Remove.
8385         (sparc_ravenscar_ops): Redefine.
8386         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8387         methods and destructor.  Remove members.
8388         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8389         (ravenscar_thread_target::store_registers)
8390         (ravenscar_thread_target::prepare_to_store): Update.
8391         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8392         Remove.
8393         (struct ppc_ravenscar_powerpc_ops): Derive from
8394         ravenscar_arch_ops.
8395         (ppc_ravenscar_powerpc_ops::fetch_registers)
8396         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8397         (ppc_ravenscar_powerpc_ops): Redefine.
8398         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8399         (ppc_ravenscar_e500_ops::fetch_registers)
8400         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8401         (ppc_ravenscar_e500_ops): Redefine.
8402         * aarch64-ravenscar-thread.c
8403         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8404         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8405         (aarch64_ravenscar_fetch_registers)
8406         (aarch64_ravenscar_store_registers): Now methods.
8407         (aarch64_ravenscar_ops): Redefine.
8408
8409 2019-02-15  Tom Tromey  <tromey@adacore.com>
8410
8411         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8412         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8413         (ravenscar_thread_target::stopped_by_watchpoint)
8414         (ravenscar_thread_target::stopped_data_address)
8415         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8416
8417 2019-02-15  Tom Tromey  <tromey@adacore.com>
8418
8419         * ravenscar-thread.c: Fix some typos.
8420
8421 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8422             Tom Tromey  <tromey@adacore.com>
8423
8424         * ada-lang.c (ada_exception_sal): Change addr_string to a
8425         std::string.
8426         (create_ada_exception_catchpoint): Update.
8427
8428 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8429             Tom Tromey  <tromey@adacore.com>
8430
8431         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8432         (bp_location_ops): Remove.
8433         (base_breakpoint_allocate_location): Update.
8434         (free_bp_location): Update.
8435         * ada-lang.c (class ada_catchpoint_location)
8436         <ada_catchpoint_location>: Remove ops parameter.
8437         (ada_catchpoint_location_dtor): Remove.
8438         (ada_catchpoint_location_ops): Remove.
8439         (allocate_location_exception): Update.
8440         * breakpoint.h (struct bp_location_ops): Remove.
8441         (class bp_location) <bp_location>: Remove bp_location_ops
8442         parameter.
8443         <~bp_location>: Add destructor.
8444         <ops>: Remove.
8445
8446 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8447             Pedro Alves  <palves@redhat.com>
8448
8449         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8450         'PATH_MAX'.
8451
8452 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8453             Samuel Thibault  <samuel.thibault@gnu.org>
8454             Thomas Schwinge  <thomas@codesourcery.com>
8455
8456         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8457         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8458
8459 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8460
8461         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8462         (check_empty): Use "const char *".
8463
8464         * gnu-nat.c (gnu_nat_target::detach): Instead of
8465         'detach_inferior (pid)' call
8466         'detach_inferior (find_inferior_pid (pid))'.
8467
8468         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8469         'nat/fork-inferior.o'.
8470         * gnu-nat.c: #include "nat/fork-inferior.h".
8471
8472         * gnu-nat.c (gnu_nat_target::detach): Instead of
8473         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8474         * gnu-nat.h: #include "inf-child.h".
8475         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8476         'i386_gnu_nat_target::fetch_registers'.
8477         (gnu_store_registers): Rename/move to
8478         'i386_gnu_nat_target::store_registers'.
8479
8480         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8481         * gnu-nat.h (mach_thread_info): New function.
8482         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8483
8484         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8485
8486 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8487
8488         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8489
8490 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8491
8492         * windows-nat.c (windows_add_thread): Add new parameter
8493         "main_thread_p" with default value set to false.  Update
8494         function documentation as well as all callers.
8495         (windows_delete_thread): Likewise.
8496         (fake_create_process): Update call to windows_add_thread.
8497         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8498         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8499         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8500         call to windows_delete_thread.
8501
8502 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8503
8504         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8505
8506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8507
8508         * symfile.c (find_separate_debug_file): Use canonical path of
8509         sysroot with child_path instead of gdb_sysroot if it is valid.
8510
8511 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8512
8513         * symfile.c (find_separate_debug_file): Use child_path to
8514         determine if an object file is under a sysroot.
8515
8516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8517
8518         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8519         unittests/child-path-selftests.c.
8520         * common/pathstuff.c (child_path): New function.
8521         * common/pathstuff.h (child_path): New prototype.
8522         * unittests/child-path-selftests.c: New file.
8523
8524 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8525
8526         * symfile.c (find_separate_debug_file): Look for separate debug
8527         files in debug directories under the sysroot.
8528
8529 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8530
8531         * symtab.h (struct minimal_symbol data_p): New const method.
8532         (struct minimal_symbol text_p): Likewise.
8533         * symtab.c (output_source_filename): Use file name style
8534         to print file name.
8535         (print_symbol_info): Likewise.
8536         (print_msymbol_info): Use address style to print addresses.
8537         Use function name style to print executable text symbols.
8538         (expand_symtab_containing_pc): Use data_p.
8539         (find_pc_sect_compunit_symtab): Likewise.
8540
8541 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8542
8543         * breakpoint.c (describe_other_breakpoints): Use address style
8544         to print addresses.
8545         (say_where): Likewise.
8546
8547 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8548
8549         * ada-typeprint.c (print_func_type): Print function name
8550         style to print function name.
8551         * c-typeprint.c (c_print_type_1): Likewise.
8552
8553 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8554
8555         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8556         for execve.
8557
8558 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8559
8560         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8561         type_stack.
8562
8563 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8564
8565         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8566         TYPE_CODE_REF types.
8567
8568 2019-02-08  Jim Wilson  <jimw@sifive.com>
8569
8570         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8571         (riscv_linux_fregset): New.
8572         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8573
8574 2019-02-07  Tom Tromey  <tom@tromey.com>
8575
8576         * thread.c (thread_cancel_execution_command): Update.
8577         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8578         methods.
8579         (struct thread_fsm_ops): Remove.
8580         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8581         (thread_fsm_should_stop, thread_fsm_return_value)
8582         (thread_fsm_set_finished, thread_fsm_finished_p)
8583         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8584         Don't declare.
8585         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8586         * infrun.c (clear_proceed_status_thread)
8587         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8588         (print_stop_event): Update.
8589         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8590         Add constructor.
8591         (step_command_fsm_ops): Remove.
8592         (new_step_command_fsm): Remove.
8593         (step_1): Update.
8594         (step_command_fsm::should_stop): Rename from
8595         step_command_fsm_should_stop.
8596         (step_command_fsm::clean_up): Rename from
8597         step_command_fsm_clean_up.
8598         (step_command_fsm::do_async_reply_reason): Rename from
8599         step_command_fsm_async_reply_reason.
8600         (struct until_next_fsm): Inherit from thread_fsm.  Add
8601         constructor.
8602         (until_next_fsm_ops): Remove.
8603         (new_until_next_fsm): Remove.
8604         (until_next_fsm::should_stop): Rename from
8605         until_next_fsm_should_stop.
8606         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8607         (until_next_fsm::do_async_reply_reason): Rename from
8608         until_next_fsm_async_reply_reason.
8609         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8610         constructor.  Change type of breakpoint.
8611         (finish_command_fsm_ops): Remove.
8612         (new_finish_command_fsm): Remove.
8613         (finish_command_fsm::should_stop): Rename from
8614         finish_command_fsm_should_stop.
8615         (finish_command_fsm::clean_up): Rename from
8616         finish_command_fsm_clean_up.
8617         (finish_command_fsm::return_value): Rename from
8618         finish_command_fsm_return_value.
8619         (finish_command_fsm::do_async_reply_reason): Rename from
8620         finish_command_fsm_async_reply_reason.
8621         (finish_command): Update.
8622         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8623         Add constructor.
8624         (call_thread_fsm_ops): Remove.
8625         (call_thread_fsm::call_thread_fsm): Rename from
8626         new_call_thread_fsm.
8627         (call_thread_fsm::should_stop): Rename from
8628         call_thread_fsm_should_stop.
8629         (call_thread_fsm::should_notify_stop): Rename from
8630         call_thread_fsm_should_notify_stop.
8631         (run_inferior_call, call_function_by_hand_dummy): Update.
8632         * cli/cli-interp.c (should_print_stop_to_console): Update.
8633         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8634         Add constructor.  Change type of location_breakpoint,
8635         caller_breakpoint.
8636         (until_break_fsm_ops): Remove.
8637         (new_until_break_fsm): Remove.
8638         (until_break_fsm::should_stop): Rename from
8639         until_break_fsm_should_stop.
8640         (until_break_fsm::clean_up): Rename from
8641         until_break_fsm_clean_up.
8642         (until_break_fsm::do_async_reply_reason): Rename from
8643         until_break_fsm_async_reply_reason.
8644         (until_break_command): Update.
8645         * thread-fsm.c: Remove.
8646         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8647
8648 2019-02-07  Tom Tromey  <tom@tromey.com>
8649
8650         * yy-remap.h: Add include guard.
8651         * xtensa-tdep.h: Add include guard.
8652         * xcoffread.h: Rename include guard.
8653         * varobj-iter.h: Add include guard.
8654         * tui/tui.h: Rename include guard.
8655         * tui/tui-winsource.h: Rename include guard.
8656         * tui/tui-wingeneral.h: Rename include guard.
8657         * tui/tui-windata.h: Rename include guard.
8658         * tui/tui-win.h: Rename include guard.
8659         * tui/tui-stack.h: Rename include guard.
8660         * tui/tui-source.h: Rename include guard.
8661         * tui/tui-regs.h: Rename include guard.
8662         * tui/tui-out.h: Rename include guard.
8663         * tui/tui-layout.h: Rename include guard.
8664         * tui/tui-io.h: Rename include guard.
8665         * tui/tui-hooks.h: Rename include guard.
8666         * tui/tui-file.h: Rename include guard.
8667         * tui/tui-disasm.h: Rename include guard.
8668         * tui/tui-data.h: Rename include guard.
8669         * tui/tui-command.h: Rename include guard.
8670         * tic6x-tdep.h: Add include guard.
8671         * target/waitstatus.h: Rename include guard.
8672         * target/wait.h: Rename include guard.
8673         * target/target.h: Rename include guard.
8674         * target/resume.h: Rename include guard.
8675         * target-float.h: Rename include guard.
8676         * stabsread.h: Add include guard.
8677         * rs6000-tdep.h: Add include guard.
8678         * riscv-fbsd-tdep.h: Add include guard.
8679         * regformats/regdef.h: Rename include guard.
8680         * record.h: Rename include guard.
8681         * python/python.h: Rename include guard.
8682         * python/python-internal.h: Rename include guard.
8683         * python/py-stopevent.h: Rename include guard.
8684         * python/py-ref.h: Rename include guard.
8685         * python/py-record.h: Rename include guard.
8686         * python/py-record-full.h: Rename include guard.
8687         * python/py-record-btrace.h: Rename include guard.
8688         * python/py-instruction.h: Rename include guard.
8689         * python/py-events.h: Rename include guard.
8690         * python/py-event.h: Rename include guard.
8691         * procfs.h: Add include guard.
8692         * proc-utils.h: Add include guard.
8693         * p-lang.h: Add include guard.
8694         * or1k-tdep.h: Rename include guard.
8695         * observable.h: Rename include guard.
8696         * nto-tdep.h: Rename include guard.
8697         * nat/x86-linux.h: Rename include guard.
8698         * nat/x86-linux-dregs.h: Rename include guard.
8699         * nat/x86-gcc-cpuid.h: Add include guard.
8700         * nat/x86-dregs.h: Rename include guard.
8701         * nat/x86-cpuid.h: Rename include guard.
8702         * nat/ppc-linux.h: Rename include guard.
8703         * nat/mips-linux-watch.h: Rename include guard.
8704         * nat/linux-waitpid.h: Rename include guard.
8705         * nat/linux-ptrace.h: Rename include guard.
8706         * nat/linux-procfs.h: Rename include guard.
8707         * nat/linux-osdata.h: Rename include guard.
8708         * nat/linux-nat.h: Rename include guard.
8709         * nat/linux-namespaces.h: Rename include guard.
8710         * nat/linux-btrace.h: Rename include guard.
8711         * nat/glibc_thread_db.h: Rename include guard.
8712         * nat/gdb_thread_db.h: Rename include guard.
8713         * nat/gdb_ptrace.h: Rename include guard.
8714         * nat/fork-inferior.h: Rename include guard.
8715         * nat/amd64-linux-siginfo.h: Rename include guard.
8716         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8717         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8718         * nat/aarch64-linux.h: Rename include guard.
8719         * nat/aarch64-linux-hw-point.h: Rename include guard.
8720         * mn10300-tdep.h: Add include guard.
8721         * mips-linux-tdep.h: Add include guard.
8722         * mi/mi-parse.h: Rename include guard.
8723         * mi/mi-out.h: Rename include guard.
8724         * mi/mi-main.h: Rename include guard.
8725         * mi/mi-interp.h: Rename include guard.
8726         * mi/mi-getopt.h: Rename include guard.
8727         * mi/mi-console.h: Rename include guard.
8728         * mi/mi-common.h: Rename include guard.
8729         * mi/mi-cmds.h: Rename include guard.
8730         * mi/mi-cmd-break.h: Rename include guard.
8731         * m2-lang.h: Add include guard.
8732         * location.h: Rename include guard.
8733         * linux-record.h: Rename include guard.
8734         * linux-nat.h: Add include guard.
8735         * linux-fork.h: Add include guard.
8736         * i386-darwin-tdep.h: Rename include guard.
8737         * hppa-linux-offsets.h: Add include guard.
8738         * guile/guile.h: Rename include guard.
8739         * guile/guile-internal.h: Rename include guard.
8740         * gnu-nat.h: Rename include guard.
8741         * gdb-stabs.h: Rename include guard.
8742         * frv-tdep.h: Add include guard.
8743         * f-lang.h: Add include guard.
8744         * event-loop.h: Add include guard.
8745         * darwin-nat.h: Rename include guard.
8746         * cp-abi.h: Rename include guard.
8747         * config/sparc/nm-sol2.h: Rename include guard.
8748         * config/nm-nto.h: Rename include guard.
8749         * config/nm-linux.h: Add include guard.
8750         * config/i386/nm-i386gnu.h: Rename include guard.
8751         * config/djgpp/nl_types.h: Rename include guard.
8752         * config/djgpp/langinfo.h: Rename include guard.
8753         * compile/gcc-cp-plugin.h: Add include guard.
8754         * compile/gcc-c-plugin.h: Add include guard.
8755         * compile/compile.h: Rename include guard.
8756         * compile/compile-object-run.h: Rename include guard.
8757         * compile/compile-object-load.h: Rename include guard.
8758         * compile/compile-internal.h: Rename include guard.
8759         * compile/compile-cplus.h: Rename include guard.
8760         * compile/compile-c.h: Rename include guard.
8761         * common/xml-utils.h: Rename include guard.
8762         * common/x86-xstate.h: Rename include guard.
8763         * common/version.h: Rename include guard.
8764         * common/vec.h: Rename include guard.
8765         * common/tdesc.h: Rename include guard.
8766         * common/selftest.h: Rename include guard.
8767         * common/scoped_restore.h: Rename include guard.
8768         * common/scoped_mmap.h: Rename include guard.
8769         * common/scoped_fd.h: Rename include guard.
8770         * common/safe-iterator.h: Rename include guard.
8771         * common/run-time-clock.h: Rename include guard.
8772         * common/refcounted-object.h: Rename include guard.
8773         * common/queue.h: Rename include guard.
8774         * common/ptid.h: Rename include guard.
8775         * common/print-utils.h: Rename include guard.
8776         * common/preprocessor.h: Rename include guard.
8777         * common/pathstuff.h: Rename include guard.
8778         * common/observable.h: Rename include guard.
8779         * common/netstuff.h: Rename include guard.
8780         * common/job-control.h: Rename include guard.
8781         * common/host-defs.h: Rename include guard.
8782         * common/gdb_wait.h: Rename include guard.
8783         * common/gdb_vecs.h: Rename include guard.
8784         * common/gdb_unlinker.h: Rename include guard.
8785         * common/gdb_unique_ptr.h: Rename include guard.
8786         * common/gdb_tilde_expand.h: Rename include guard.
8787         * common/gdb_sys_time.h: Rename include guard.
8788         * common/gdb_string_view.h: Rename include guard.
8789         * common/gdb_splay_tree.h: Rename include guard.
8790         * common/gdb_setjmp.h: Rename include guard.
8791         * common/gdb_ref_ptr.h: Rename include guard.
8792         * common/gdb_optional.h: Rename include guard.
8793         * common/gdb_locale.h: Rename include guard.
8794         * common/gdb_assert.h: Rename include guard.
8795         * common/filtered-iterator.h: Rename include guard.
8796         * common/filestuff.h: Rename include guard.
8797         * common/fileio.h: Rename include guard.
8798         * common/environ.h: Rename include guard.
8799         * common/common-utils.h: Rename include guard.
8800         * common/common-types.h: Rename include guard.
8801         * common/common-regcache.h: Rename include guard.
8802         * common/common-inferior.h: Rename include guard.
8803         * common/common-gdbthread.h: Rename include guard.
8804         * common/common-exceptions.h: Rename include guard.
8805         * common/common-defs.h: Rename include guard.
8806         * common/common-debug.h: Rename include guard.
8807         * common/cleanups.h: Rename include guard.
8808         * common/buffer.h: Rename include guard.
8809         * common/btrace-common.h: Rename include guard.
8810         * common/break-common.h: Rename include guard.
8811         * cli/cli-utils.h: Rename include guard.
8812         * cli/cli-style.h: Rename include guard.
8813         * cli/cli-setshow.h: Rename include guard.
8814         * cli/cli-script.h: Rename include guard.
8815         * cli/cli-interp.h: Rename include guard.
8816         * cli/cli-decode.h: Rename include guard.
8817         * cli/cli-cmds.h: Rename include guard.
8818         * charset-list.h: Add include guard.
8819         * buildsym-legacy.h: Rename include guard.
8820         * bfin-tdep.h: Add include guard.
8821         * ax.h: Rename include guard.
8822         * arm-linux-tdep.h: Add include guard.
8823         * arm-fbsd-tdep.h: Add include guard.
8824         * arch/xtensa.h: Rename include guard.
8825         * arch/tic6x.h: Add include guard.
8826         * arch/i386.h: Add include guard.
8827         * arch/arm.h: Rename include guard.
8828         * arch/arm-linux.h: Rename include guard.
8829         * arch/arm-get-next-pcs.h: Rename include guard.
8830         * arch/amd64.h: Add include guard.
8831         * arch/aarch64-insn.h: Rename include guard.
8832         * arch-utils.h: Rename include guard.
8833         * annotate.h: Add include guard.
8834         * amd64-darwin-tdep.h: Rename include guard.
8835         * aarch64-linux-tdep.h: Add include guard.
8836         * aarch64-fbsd-tdep.h: Add include guard.
8837         * aarch32-linux-nat.h: Add include guard.
8838
8839 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8840
8841         * macrotab.c (macro_define_internal): New function that
8842         factorizes macro_define_object_internal and macro_define_function
8843         code.
8844         (macro_define_object_internal): Use macro_define_internal.
8845         (macro_define_function): Likewise.
8846
8847 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8848
8849         * macrocmd.c (extract_identifier): Return
8850         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8851         callers.
8852
8853 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8854
8855         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8856
8857 2019-02-05  Tom Tromey  <tom@tromey.com>
8858
8859         * target.c (target_stack::unpush): Move assertion earlier.
8860
8861 2019-01-30  Tom Tromey  <tom@tromey.com>
8862
8863         PR python/23615:
8864         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8865         (gdbpy_parse_and_eval): Likewise.
8866         * python/python-internal.h (gdbpy_allow_threads): New class.
8867
8868 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8869
8870         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8871         (aarch64_fbsd_fpregmap): Move earlier.
8872         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8873         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8874         instead of individual calls to trad_frame_set_reg_addr.
8875         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8876         earlier.
8877         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8878         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8879         instead of individual calls to trad_frame_set_reg_addr.
8880
8881 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8882
8883         * CONTRIBUTE: Replace contribution list with wiki link.
8884
8885 2019-01-25  Tom Tromey  <tom@tromey.com>
8886
8887         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8888
8889 2019-01-25  Tom Tromey  <tom@tromey.com>
8890
8891         * xtensa-linux-nat.c: Fix common/ includes.
8892         * xml-support.h: Fix common/ includes.
8893         * xml-support.c: Fix common/ includes.
8894         * x86-linux-nat.c: Fix common/ includes.
8895         * windows-nat.c: Fix common/ includes.
8896         * varobj.h: Fix common/ includes.
8897         * varobj.c: Fix common/ includes.
8898         * value.c: Fix common/ includes.
8899         * valops.c: Fix common/ includes.
8900         * utils.c: Fix common/ includes.
8901         * unittests/xml-utils-selftests.c: Fix common/ includes.
8902         * unittests/utils-selftests.c: Fix common/ includes.
8903         * unittests/unpack-selftests.c: Fix common/ includes.
8904         * unittests/tracepoint-selftests.c: Fix common/ includes.
8905         * unittests/style-selftests.c: Fix common/ includes.
8906         * unittests/string_view-selftests.c: Fix common/ includes.
8907         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8908         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8909         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8910         * unittests/rsp-low-selftests.c: Fix common/ includes.
8911         * unittests/parse-connection-spec-selftests.c: Fix common/
8912         includes.
8913         * unittests/optional-selftests.c: Fix common/ includes.
8914         * unittests/offset-type-selftests.c: Fix common/ includes.
8915         * unittests/observable-selftests.c: Fix common/ includes.
8916         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8917         * unittests/memrange-selftests.c: Fix common/ includes.
8918         * unittests/memory-map-selftests.c: Fix common/ includes.
8919         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8920         * unittests/function-view-selftests.c: Fix common/ includes.
8921         * unittests/environ-selftests.c: Fix common/ includes.
8922         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8923         * unittests/common-utils-selftests.c: Fix common/ includes.
8924         * unittests/cli-utils-selftests.c: Fix common/ includes.
8925         * unittests/array-view-selftests.c: Fix common/ includes.
8926         * ui-file.c: Fix common/ includes.
8927         * tui/tui-io.c: Fix common/ includes.
8928         * tracepoint.h: Fix common/ includes.
8929         * tracepoint.c: Fix common/ includes.
8930         * tracefile-tfile.c: Fix common/ includes.
8931         * top.h: Fix common/ includes.
8932         * top.c: Fix common/ includes.
8933         * thread.c: Fix common/ includes.
8934         * target/waitstatus.h: Fix common/ includes.
8935         * target/waitstatus.c: Fix common/ includes.
8936         * target.h: Fix common/ includes.
8937         * target.c: Fix common/ includes.
8938         * target-memory.c: Fix common/ includes.
8939         * target-descriptions.c: Fix common/ includes.
8940         * symtab.h: Fix common/ includes.
8941         * symfile.c: Fix common/ includes.
8942         * stap-probe.c: Fix common/ includes.
8943         * spu-linux-nat.c: Fix common/ includes.
8944         * sparc-nat.c: Fix common/ includes.
8945         * source.c: Fix common/ includes.
8946         * solib.c: Fix common/ includes.
8947         * solib-target.c: Fix common/ includes.
8948         * ser-unix.c: Fix common/ includes.
8949         * ser-tcp.c: Fix common/ includes.
8950         * ser-pipe.c: Fix common/ includes.
8951         * ser-base.c: Fix common/ includes.
8952         * selftest-arch.c: Fix common/ includes.
8953         * s12z-tdep.c: Fix common/ includes.
8954         * rust-exp.y: Fix common/ includes.
8955         * rs6000-aix-tdep.c: Fix common/ includes.
8956         * riscv-tdep.c: Fix common/ includes.
8957         * remote.c: Fix common/ includes.
8958         * remote-notif.h: Fix common/ includes.
8959         * remote-fileio.h: Fix common/ includes.
8960         * remote-fileio.c: Fix common/ includes.
8961         * regcache.h: Fix common/ includes.
8962         * regcache.c: Fix common/ includes.
8963         * record-btrace.c: Fix common/ includes.
8964         * python/python.c: Fix common/ includes.
8965         * python/py-type.c: Fix common/ includes.
8966         * python/py-inferior.c: Fix common/ includes.
8967         * progspace.h: Fix common/ includes.
8968         * producer.c: Fix common/ includes.
8969         * procfs.c: Fix common/ includes.
8970         * proc-api.c: Fix common/ includes.
8971         * printcmd.c: Fix common/ includes.
8972         * ppc-linux-nat.c: Fix common/ includes.
8973         * parser-defs.h: Fix common/ includes.
8974         * osdata.c: Fix common/ includes.
8975         * obsd-nat.c: Fix common/ includes.
8976         * nat/x86-linux.c: Fix common/ includes.
8977         * nat/x86-linux-dregs.c: Fix common/ includes.
8978         * nat/x86-dregs.h: Fix common/ includes.
8979         * nat/x86-dregs.c: Fix common/ includes.
8980         * nat/ppc-linux.c: Fix common/ includes.
8981         * nat/mips-linux-watch.h: Fix common/ includes.
8982         * nat/mips-linux-watch.c: Fix common/ includes.
8983         * nat/linux-waitpid.c: Fix common/ includes.
8984         * nat/linux-ptrace.h: Fix common/ includes.
8985         * nat/linux-ptrace.c: Fix common/ includes.
8986         * nat/linux-procfs.c: Fix common/ includes.
8987         * nat/linux-personality.c: Fix common/ includes.
8988         * nat/linux-osdata.c: Fix common/ includes.
8989         * nat/linux-namespaces.c: Fix common/ includes.
8990         * nat/linux-btrace.h: Fix common/ includes.
8991         * nat/linux-btrace.c: Fix common/ includes.
8992         * nat/fork-inferior.c: Fix common/ includes.
8993         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8994         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8995         * nat/aarch64-linux.c: Fix common/ includes.
8996         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8997         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8998         * namespace.h: Fix common/ includes.
8999         * mips-linux-tdep.c: Fix common/ includes.
9000         * minsyms.c: Fix common/ includes.
9001         * mi/mi-parse.h: Fix common/ includes.
9002         * mi/mi-main.c: Fix common/ includes.
9003         * mi/mi-cmd-env.c: Fix common/ includes.
9004         * memrange.h: Fix common/ includes.
9005         * memattr.c: Fix common/ includes.
9006         * maint.h: Fix common/ includes.
9007         * maint.c: Fix common/ includes.
9008         * main.c: Fix common/ includes.
9009         * machoread.c: Fix common/ includes.
9010         * location.c: Fix common/ includes.
9011         * linux-thread-db.c: Fix common/ includes.
9012         * linux-nat.c: Fix common/ includes.
9013         * linux-fork.c: Fix common/ includes.
9014         * inline-frame.c: Fix common/ includes.
9015         * infrun.c: Fix common/ includes.
9016         * inflow.c: Fix common/ includes.
9017         * inferior.h: Fix common/ includes.
9018         * inferior.c: Fix common/ includes.
9019         * infcmd.c: Fix common/ includes.
9020         * inf-ptrace.c: Fix common/ includes.
9021         * inf-child.c: Fix common/ includes.
9022         * ia64-linux-nat.c: Fix common/ includes.
9023         * i387-tdep.c: Fix common/ includes.
9024         * i386-tdep.c: Fix common/ includes.
9025         * i386-linux-tdep.c: Fix common/ includes.
9026         * i386-linux-nat.c: Fix common/ includes.
9027         * i386-go32-tdep.c: Fix common/ includes.
9028         * i386-fbsd-tdep.c: Fix common/ includes.
9029         * i386-fbsd-nat.c: Fix common/ includes.
9030         * guile/scm-type.c: Fix common/ includes.
9031         * guile/guile.c: Fix common/ includes.
9032         * go32-nat.c: Fix common/ includes.
9033         * gnu-nat.c: Fix common/ includes.
9034         * gdbthread.h: Fix common/ includes.
9035         * gdbarch-selftests.c: Fix common/ includes.
9036         * gdb_usleep.c: Fix common/ includes.
9037         * gdb_select.h: Fix common/ includes.
9038         * gdb_bfd.c: Fix common/ includes.
9039         * gcore.c: Fix common/ includes.
9040         * fork-child.c: Fix common/ includes.
9041         * findvar.c: Fix common/ includes.
9042         * fbsd-nat.c: Fix common/ includes.
9043         * event-top.c: Fix common/ includes.
9044         * event-loop.c: Fix common/ includes.
9045         * dwarf2read.c: Fix common/ includes.
9046         * dwarf2loc.c: Fix common/ includes.
9047         * dwarf2-frame.c: Fix common/ includes.
9048         * dwarf-index-cache.c: Fix common/ includes.
9049         * dtrace-probe.c: Fix common/ includes.
9050         * disasm-selftests.c: Fix common/ includes.
9051         * defs.h: Fix common/ includes.
9052         * csky-tdep.c: Fix common/ includes.
9053         * cp-valprint.c: Fix common/ includes.
9054         * cp-support.h: Fix common/ includes.
9055         * cp-support.c: Fix common/ includes.
9056         * corelow.c: Fix common/ includes.
9057         * completer.h: Fix common/ includes.
9058         * completer.c: Fix common/ includes.
9059         * compile/compile.c: Fix common/ includes.
9060         * compile/compile-loc2c.c: Fix common/ includes.
9061         * compile/compile-cplus-types.c: Fix common/ includes.
9062         * compile/compile-cplus-symbols.c: Fix common/ includes.
9063         * command.h: Fix common/ includes.
9064         * cli/cli-dump.c: Fix common/ includes.
9065         * cli/cli-cmds.c: Fix common/ includes.
9066         * charset.c: Fix common/ includes.
9067         * build-id.c: Fix common/ includes.
9068         * btrace.h: Fix common/ includes.
9069         * btrace.c: Fix common/ includes.
9070         * breakpoint.h: Fix common/ includes.
9071         * breakpoint.c: Fix common/ includes.
9072         * ax.h:
9073         (enum agent_op): Fix common/ includes.
9074         * ax-general.c (struct aop_map): Fix common/ includes.
9075         * ax-gdb.c: Fix common/ includes.
9076         * auxv.c: Fix common/ includes.
9077         * auto-load.c: Fix common/ includes.
9078         * arm-tdep.c: Fix common/ includes.
9079         * arch/riscv.c: Fix common/ includes.
9080         * arch/ppc-linux-common.c: Fix common/ includes.
9081         * arch/i386.c: Fix common/ includes.
9082         * arch/arm.c: Fix common/ includes.
9083         * arch/arm-linux.c: Fix common/ includes.
9084         * arch/arm-get-next-pcs.c: Fix common/ includes.
9085         * arch/amd64.c: Fix common/ includes.
9086         * arch/aarch64.c: Fix common/ includes.
9087         * arch/aarch64-insn.c: Fix common/ includes.
9088         * arch-utils.c: Fix common/ includes.
9089         * amd64-windows-tdep.c: Fix common/ includes.
9090         * amd64-tdep.c: Fix common/ includes.
9091         * amd64-sol2-tdep.c: Fix common/ includes.
9092         * amd64-obsd-tdep.c: Fix common/ includes.
9093         * amd64-nbsd-tdep.c: Fix common/ includes.
9094         * amd64-linux-tdep.c: Fix common/ includes.
9095         * amd64-linux-nat.c: Fix common/ includes.
9096         * amd64-fbsd-tdep.c: Fix common/ includes.
9097         * amd64-fbsd-nat.c: Fix common/ includes.
9098         * amd64-dicos-tdep.c: Fix common/ includes.
9099         * amd64-darwin-tdep.c: Fix common/ includes.
9100         * agent.c: Fix common/ includes.
9101         * ada-lang.h: Fix common/ includes.
9102         * ada-lang.c: Fix common/ includes.
9103         * aarch64-tdep.c: Fix common/ includes.
9104
9105 2019-01-25  Tom Tromey  <tom@tromey.com>
9106
9107         * common/create-version.sh: Use common/version.h.
9108
9109 2019-01-24  Pedro Alves  <palves@redhat.com>
9110
9111         * infrun.c (signal_stop, signal_print, signal_program)
9112         (signal_catch, signal_pass): Now arrays instead of pointers.
9113         (update_signals_program_target, do_target_resume)
9114         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9115         * linux-nat.c (linux_nat_target::pass_signals)
9116         (linux_nat_target::create_inferior, linux_nat_target::attach):
9117         Adjust.
9118         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9119         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9120         * procfs.c (procfs_target::pass_signals): Adjust.
9121         * record-full.c (record_full_target::resume): Adjust.
9122         * remote.c (remote_target::pass_signals)
9123         (remote_target::program_signals): Adjust.
9124         * target-debug.h (target_debug_print_signals): Now takes a
9125         gdb::array_view as parameter.  Adjust.
9126         * target.h (target_ops) <pass_signals, program_signals>: Replace
9127         pointer and length parameters with gdb::array_view.
9128         (target_pass_signals, target_program_signals): Likewise.
9129         * target-delegates.c: Regenerate.
9130
9131 2019-01-24  Pedro Alves  <palves@redhat.com>
9132
9133         * common/forward-scope-exit.h
9134         (forward_scope_exit::forward_scope_exit): Pass arguments to
9135         m_bind_function directly, instead of creating a std::bind and
9136         copying that.
9137
9138 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9139
9140         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9141         for static members.
9142         (pass_in_v_vfp_candidate): Likewise.
9143
9144 2019-01-23  Tom Tromey  <tom@tromey.com>
9145             Pedro Alves  <palves@redhat.com>
9146
9147         * regcache.c (class regcache_invalidator): Remove.
9148         (regcache::raw_write): Use make_scope_exit.
9149
9150 2019-01-23  Tom Tromey  <tom@tromey.com>
9151
9152         * ui-out.h (class ui_out_emit_type): Update comment.
9153
9154 2019-01-23  Tom Tromey  <tom@tromey.com>
9155
9156         * infrun.c (fetch_inferior_event): Update comment.
9157
9158 2019-01-23  Tom Tromey  <tom@tromey.com>
9159             Pedro Alves  <palves@redhat.com>
9160
9161         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9162         parameter.
9163         (fetch_inferior_event): Use SCOPE_EXIT.
9164
9165
9166 2019-01-23  Tom Tromey  <tom@tromey.com>
9167             Pedro Alves  <palves@redhat.com>
9168
9169         * infrun.c (disable_thread_events): Delete.
9170         (stop_all_threads): Use SCOPE_EXIT.
9171
9172 2019-01-23  Tom Tromey  <tom@tromey.com>
9173             Pedro Alves  <palves@redhat.com>
9174
9175         * symfile.c: Include forward-scope-exit.h.
9176         (clear_symtab_users_cleanup): Replace forward declaration with
9177         a FORWARD_SCOPE_EXIT.
9178         (syms_from_objfile_1): Use the forward_scope_exit and
9179         gdb::optional instead of cleanup_function.
9180         (reread_symbols): Use the forward_scope_exit instead of
9181         cleanup_function.
9182         (clear_symtab_users_cleanup): Remove function.
9183
9184 2019-01-23  Tom Tromey  <tom@tromey.com>
9185             Pedro Alves  <palves@redhat.com>
9186
9187         * linux-nat.c: Include scope-exit.h.
9188         (cleanup_target_stop): Remove.
9189         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9190         SCOPE_EXIT.
9191
9192 2019-01-23  Tom Tromey  <tom@tromey.com>
9193             Pedro Alves  <palves@redhat.com>
9194
9195         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9196         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9197
9198 2019-01-23  Tom Tromey  <tom@tromey.com>
9199             Andrew Burgess  <andrew.burgess@embecosm.com>
9200             Pedro Alves  <palves@redhat.com>
9201
9202         * infrun.c (fetch_inferior_event): Use scope_exit.
9203         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9204         * top.c (execute_command): Use scope_exit.
9205         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9206         * utils.c (do_bpstat_clear_actions_cleanup)
9207         (make_bpstat_clear_actions_cleanup): Remove.
9208
9209 2019-01-23  Tom Tromey  <tom@tromey.com>
9210             Pedro Alves  <palves@redhat.com>
9211
9212         * infrun.c: Include "common/scope-exit.h"
9213         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9214         (wait_for_inferior): Use SCOPE_EXIT.
9215         (fetch_inferior_event): Use scope_exit.
9216
9217 2019-01-23  Tom Tromey  <tom@tromey.com>
9218             Pedro Alves  <palves@redhat.com>
9219
9220         * breakpoint.c (create_breakpoint): Remove cleanup.
9221
9222 2019-01-23  Tom Tromey  <tom@tromey.com>
9223             Andrew Burgess  <andrew.burgess@embecosm.com>
9224             Pedro Alves  <palves@redhat.com>
9225
9226 2019-01-23  Pedro Alves  <palves@redhat.com>
9227
9228         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9229
9230 2019-01-23  Pedro Alves  <palves@redhat.com>
9231             Andrew Burgess  <andrew.burgess@embecosm.com>
9232
9233         * gdbthread.h: Include "common/forward-scope-exit.h".
9234         (scoped_finish_thread_state): Redefine custom class in terms of
9235         forward_scope_exit.
9236
9237 2019-01-23  Pedro Alves  <palves@redhat.com>
9238             Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * common/forward-scope-exit.h: New file.
9241
9242 2019-01-23  Pedro Alves  <palves@redhat.com>
9243             Andrew Burgess  <andrew.burgess@embecosm.com>
9244             Tom Tromey  <tom@tromey.com>
9245
9246         * common/scope-exit.h: New file.
9247
9248 2019-01-23  Pedro Alves  <palves@redhat.com>
9249
9250         * common/preprocessor.h (ESC): Rename to ...
9251         (ESC_PARENS): ... this.
9252         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9253         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9254
9255 2019-01-23  Tom Tromey  <tom@tromey.com>
9256
9257         * language.h (class scoped_switch_to_sym_language_if_auto):
9258         Initialize m_lang in both cases.
9259
9260 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9261
9262         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9263         with XCNEW.
9264
9265 2019-01-22  Tom Tromey  <tom@tromey.com>
9266
9267         * corelow.c: Do not include sys/file.h.
9268
9269 2019-01-22  Tom Tromey  <tom@tromey.com>
9270
9271         * tui/tui-wingeneral.h: Include gdb_curses.h.
9272
9273 2019-01-22  Tom Tromey  <tom@tromey.com>
9274
9275         * source-cache.h (class source_cache) <get_source_lines,
9276         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9277
9278 2019-01-22  Tom Tromey  <tom@tromey.com>
9279
9280         * remote-fileio.h (struct remote_target): Declare.
9281
9282 2019-01-22  Tom Tromey  <tom@tromey.com>
9283
9284         * python/py-arch.c: Do not include py-ref.h.
9285         * python/py-bpevent.c: Do not include py-ref.h.
9286         * python/py-cmd.c: Do not include py-ref.h.
9287         * python/py-continueevent.c: Do not include py-ref.h.
9288         * python/py-event.h: Do not include py-ref.h.
9289         * python/py-evtregistry.c: Do not include py-ref.h.
9290         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9291         * python/py-frame.c: Do not include py-ref.h.
9292         * python/py-framefilter.c: Do not include py-ref.h.
9293         * python/py-function.c: Do not include py-ref.h.
9294         * python/py-infevents.c: Do not include py-ref.h.
9295         * python/py-linetable.c: Do not include py-ref.h.
9296         * python/py-objfile.c: Do not include py-ref.h.
9297         * python/py-param.c: Do not include py-ref.h.
9298         * python/py-prettyprint.c: Do not include py-ref.h.
9299         * python/py-progspace.c: Do not include py-ref.h.
9300         * python/py-symbol.c: Do not include py-ref.h.
9301         * python/py-symtab.c: Do not include py-ref.h.
9302         * python/py-type.c: Do not include py-ref.h.
9303         * python/py-unwind.c: Do not include py-ref.h.
9304         * python/py-utils.c: Do not include py-ref.h.
9305         * python/py-value.c: Do not include py-ref.h.
9306         * python/py-varobj.c: Do not include py-ref.h.
9307         * python/py-xmethods.c: Do not include py-ref.h.
9308         * python/python.c: Do not include py-ref.h.
9309         * varobj.c: Do not include py-ref.h.
9310
9311 2019-01-22  Tom Tromey  <tom@tromey.com>
9312
9313         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9314         keyword for bcache.
9315
9316 2019-01-22  Tom Tromey  <tom@tromey.com>
9317
9318         * compile/compile-cplus-types.c: Remove a comment by #include.
9319
9320 2019-01-22  Tom Tromey  <tom@tromey.com>
9321
9322         * compile/gcc-c-plugin.h: Include compile-internal.h.
9323
9324 2019-01-22  Tom Tromey  <tom@tromey.com>
9325
9326         * stabsread.c (EXTERN): Do not define.
9327         (symnum, next_symbol_text_func, processing_gcc_compilation)
9328         (within_function, global_sym_chain, global_stabs)
9329         (previous_stab_code, this_object_header_files)
9330         (n_this_object_header_files)
9331         (n_allocated_this_object_header_files): Define.
9332         * stabsread.h (EXTERN): Never define.  Use "extern".
9333
9334 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9335
9336         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9337         history_value.
9338
9339 2019-01-21  Tom Tromey  <tom@tromey.com>
9340
9341         * ui-out.c: Fix includes.
9342         * tui/tui-source.c: Fix includes.
9343         * target.c: Fix includes.
9344         * remote.c: Fix includes.
9345         * regcache.c: Fix includes.
9346         * python/py-block.c: Fix includes.
9347         * printcmd.c: Fix includes.
9348         * or1k-tdep.c: Fix includes.
9349         * mi/mi-main.c: Fix includes.
9350         * m32r-tdep.c: Fix includes.
9351         * csky-tdep.c: Fix includes.
9352         * compile/compile-cplus-types.c: Fix includes.
9353         * cli/cli-interp.c: Fix includes.
9354
9355 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9356
9357         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9358         for padding.
9359
9360 2019-01-16  Tom Tromey  <tom@tromey.com>
9361
9362         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9363         earlier.
9364         (struct objfile) <msymbols_range>: Move from top level.
9365         <msymbols>: New method.
9366         (class objfile_msymbols): Remove.
9367         * symtab.c (default_collect_symbol_completion_matches_break_on):
9368         Update.
9369         * symmisc.c (dump_msymbols): Update.
9370         * stabsread.c (scan_file_globals): Update.
9371         * objc-lang.c (info_selectors_command, info_classes_command)
9372         (find_methods): Update.
9373         * minsyms.c (find_solib_trampoline_target): Update.
9374         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9375         * coffread.c (coff_symfile_read): Update.
9376         * ada-lang.c (ada_lookup_simple_minsym)
9377         (ada_collect_symbol_completion_matches): Update.
9378
9379 2019-01-16  Tom Tromey  <tom@tromey.com>
9380
9381         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9382         type.  Remove no-argument constructor.
9383         <iterator::operator++>: Simplify.
9384         <begin>: Update.
9385         <end>: Use minimal_symbol_count.
9386
9387 2019-01-16  Tom Tromey  <tom@tromey.com>
9388
9389         * objfiles.h (struct objfile) <psymtabs>: New method.
9390         (class objfile_psymtabs): Remove.
9391         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9392         typedef.
9393         <range>: New method.
9394         (require_partial_symbols): Change return type.
9395         * psymtab.c (require_partial_symbols)
9396         (psym_expand_symtabs_matching): Update.
9397         * mdebugread.c (parse_partial_symbols): Update.
9398         * dbxread.c (dbx_end_psymtab): Update.
9399
9400 2019-01-15  Tom Tromey  <tom@tromey.com>
9401
9402         * symtab.c (lookup_objfile_from_block)
9403         (lookup_symbol_in_objfile_symtabs)
9404         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9405         (find_line_symtab, info_sources_command)
9406         (default_collect_symbol_completion_matches_break_on)
9407         (make_source_files_completion_list): Update.
9408         * symmisc.c (print_objfile_statistics, dump_objfile)
9409         (maintenance_print_symbols, maintenance_info_symtabs)
9410         (maintenance_check_symtabs, maintenance_info_line_tables):
9411         Update.
9412         * source.c (select_source_symtab)
9413         (forget_cached_source_info_for_objfile): Update.
9414         * objfiles.h (class objfile_compunits): Remove.
9415         (struct objfile) <compunits_range>: New typedef.
9416         (compunits): New method.
9417         * objfiles.c (objfile_relocate1): Update.
9418         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9419         * maint.c (count_symtabs_and_blocks): Update.
9420         * linespec.c (iterate_over_all_matching_symtabs): Update.
9421         * cp-support.c (add_symbol_overload_list_qualified): Update.
9422         * coffread.c (coff_symtab_read): Update.
9423         * ada-lang.c (add_nonlocal_symbols)
9424         (ada_collect_symbol_completion_matches)
9425         (ada_add_global_exceptions): Update.
9426
9427 2019-01-15  Tom Tromey  <tom@tromey.com>
9428
9429         * progspace.h (program_space) <objfiles_safe_range>: New
9430         typedef.
9431         <objfiles_safe>: New method.
9432         * objfiles.h (class all_objfiles_safe): Remove.
9433         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9434         * jit.c (jit_inferior_exit_hook): Update.
9435
9436 2019-01-17  Tom Tromey  <tom@tromey.com>
9437
9438         * progspace.h (program_space) <objfiles_range>: New typedef.
9439         <objfiles>: New method.
9440         <objfiles_head>: Rename from objfiles.
9441         (object_files): Update.
9442         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9443         * guile/scm-pretty-print.c
9444         (ppscm_find_pretty_printer_from_objfiles): Update.
9445         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9446         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9447         Update.
9448         * python/py-progspace.c (pspy_get_objfiles): Update.
9449         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9450         Update.
9451         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9452         (objfpy_lookup_objfile_by_build_id): Update.
9453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9454         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9455         Update.
9456         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9457         (expand_symtab_containing_pc, lookup_objfile_from_block)
9458         (lookup_static_symbol, basic_lookup_transparent_type)
9459         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9460         (find_line_symtab, info_sources_command)
9461         (default_collect_symbol_completion_matches_break_on)
9462         (make_source_files_completion_list, find_main_name): Update.
9463         * symmisc.c (print_symbol_bcache_statistics)
9464         (print_objfile_statistics, maintenance_print_symbols)
9465         (maintenance_print_msymbols, maintenance_print_objfiles)
9466         (maintenance_info_symtabs, maintenance_check_symtabs)
9467         (maintenance_expand_symtabs, maintenance_info_line_tables):
9468         Update.
9469         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9470         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9471         (map_overlay_command, unmap_overlay_command)
9472         (simple_overlay_update, expand_symtabs_matching)
9473         (map_symbol_filenames): Update.
9474         * symfile-debug.c (set_debug_symfile): Update.
9475         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9476         Update.
9477         * source.c (select_source_symtab, forget_cached_source_info):
9478         Update.
9479         * solib.c (solib_read_symbols): Update.
9480         * solib-spu.c (append_ocl_sos): Update.
9481         * psymtab.c (maintenance_print_psymbols)
9482         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9483         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9484         * printcmd.c (info_symbol_command): Update.
9485         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9486         Update.
9487         * objfiles.h (class all_objfiles): Remove.
9488         * objfiles.c (have_partial_symbols, have_full_symbols)
9489         (have_minimal_symbols, qsort_cmp, update_section_map)
9490         (shared_objfile_contains_address_p)
9491         (default_iterate_over_objfiles_in_search_order): Update.
9492         * objc-lang.c (info_selectors_command, info_classes_command)
9493         (find_methods): Update.
9494         * minsyms.c (find_solib_trampoline_target): Update.
9495         * maint.c (maintenance_info_sections)
9496         (maintenance_translate_address, count_symtabs_and_blocks):
9497         Update.
9498         * main.c (captured_main_1): Update.
9499         * linux-thread-db.c (try_thread_db_load_from_pdir)
9500         (has_libpthread): Update.
9501         * linespec.c (iterate_over_all_matching_symtabs)
9502         (search_minsyms_for_name): Update.
9503         * jit.c (jit_find_objf_with_entry_addr): Update.
9504         * hppa-tdep.c (find_unwind_entry)
9505         (hppa_lookup_stub_minimal_symbol): Update.
9506         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9507         Update.
9508         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9509         (elf_gnu_ifunc_resolve_by_got): Update.
9510         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9511         * dwarf-index-write.c (save_gdb_index_command): Update.
9512         * cp-support.c (add_symbol_overload_list_qualified): Update.
9513         * breakpoint.c (create_overlay_event_breakpoint)
9514         (create_longjmp_master_breakpoint)
9515         (create_std_terminate_master_breakpoint)
9516         (create_exception_master_breakpoint): Update.
9517         * blockframe.c (find_pc_partial_function): Update.
9518         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9519         (ada_collect_symbol_completion_matches)
9520         (ada_add_global_exceptions): Update.
9521
9522 2019-01-17  Tom Tromey  <tom@tromey.com>
9523
9524         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9525         declare VEC.
9526         (solib_target_parse_libraries): Change return type.
9527         (library_list_start_segment, library_list_start_section)
9528         (library_list_end_library, library_list_start_library); Update.
9529         (solib_target_free_library_list): Remove.
9530         (solib_target_parse_libraries): Remove cleanup.  Change return
9531         type.
9532         (solib_target_current_sos): Update.
9533
9534 2019-01-17  Tom Tromey  <tromey@bapiya>
9535
9536         * valprint.c: Replace "the the" with "the".
9537         * symtab.c: Replace "the the" with "the".
9538         * solib.c: Replace "the the" with "the".
9539         * solib-dsbt.c: Replace "the the" with "the".
9540         * linespec.c: Replace "the the" with "the".
9541         * dwarf2loc.h: Replace "the the" with "the".
9542         * amd64-windows-tdep.c: Replace "the the" with "the".
9543         * aarch64-tdep.c: Replace "the the" with "the".
9544
9545 2019-01-16  Keith Seitz  <keiths@redhat.com>
9546
9547         PR gdb/23773
9548         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9549         <builder>: Rename to ..
9550         <m_builder>: ... this and make private.
9551         (dwarf2_cu::get_builder): New method.  Change all users of
9552         `builder' to use this method.
9553         (dwarf2_start_symtab): Move to ...
9554         (dwarf2_cu::start_symtab): ... here.  Update all callers
9555         (setup_type_unit_groups): Move to ...
9556         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9557         callers.
9558         (dwarf2_cu::reset_builder): New method.
9559         (process_full_compunit, process_full_type_unit): Use
9560         dwarf2_cu::reset_builder.
9561         (follow_die_offset): Record the ancestor CU if it is different
9562         from the followed DIE's CU.
9563         (follow_die_sig_1): Likewise.
9564
9565 2019-01-15  Tom Tromey  <tom@tromey.com>
9566
9567         * remote.c (class remote_state) <buf>: Now a char_vector.
9568         <buf_size>: Remove.
9569         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9570         parameter.
9571         (remote_target::getpkt_or_notif_sane_1)
9572         (remote_target::getpkt_sane)
9573         (remote_target::getpkt_or_notif_sane): Likewise.
9574         (class remote_target) <putpkt>: New overload.
9575         (remote_target::read_frame): Change type of "buf_p".  Remove
9576         sizeof_p parameter.
9577         (packet_ok): New overload.
9578         (packet_check_result): New overload.
9579         Update all uses.
9580
9581 2019-01-14  Tom Tromey  <tom@tromey.com>
9582
9583         * remote-notif.c (handle_notification, remote_notif_ack)
9584         (remote_notif_parse): Make "buf" const.
9585         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9586         const.
9587         (remote_notif_parse, remote_notif_ack, handle_notification):
9588         Likewise.
9589         * remote.c (remote_notif_stop_parse): Make "buf" const.
9590         (remote_target::remote_parse_stop_reply): Make "buf" const.
9591         (remote_notif_stop_ack): Make "buf" const.
9592
9593 2019-01-14  Tom Tromey  <tom@tromey.com>
9594
9595         * remote.c (remote_console_output): Make parameter const.
9596
9597 2019-01-14  Tom Tromey  <tom@tromey.com>
9598
9599         * target-debug.h (target_debug_print_signals): Constify.
9600         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9601         * procfs.c (procfs_target::pass_signals): Update.
9602         * linux-nat.c (linux_nat_target::pass_signals): Update.
9603         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9604         * target-delegates.c: Rebuild.
9605         * remote.c (remote_target::program_signals): Update.
9606         (remote_target::pass_signals): Update.
9607         * target.c (target_pass_signals): Constify argument.
9608         (target_program_signals): Likewise.
9609         * target.h (struct target_ops) <pass_signals, program_signals>:
9610         Constify argument.
9611         (target_pass_signals, target_program_signals): Constify argument.
9612
9613 2019-01-14  Tom Tromey  <tom@tromey.com>
9614
9615         PR tui/28819:
9616         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9617
9618 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9619
9620         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9621         field.
9622         * rs6000-tdep.c: Include reggroups.h.
9623         (IS_V_ALIAS_PSEUDOREG): Define.
9624         (rs6000_register_name): Return names for the "vX" aliases.
9625         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9626         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9627         aliases.  Call default_register_reggroup_p for all other
9628         pseudo-registers.
9629         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9630         New functions.
9631         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9632         Handle "vX" aliases.
9633         (v_alias_pseudo_register_collect): New function.
9634         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9635         (rs6000_gdbarch_init): Initialize "vX" aliases as
9636         pseudo-registers.  Restore registration of
9637         rs6000_pseudo_register_reggroup_p with
9638         set_tdesc_pseudo_register_reggroup_p.
9639
9640 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9641
9642         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9643         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9644         set_gdbarch_num_pseudo_regs.
9645
9646 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9647
9648         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9649         Remove arg prefixname, add do_set and do_show.
9650         Add member functions set_list and show_list.
9651         * cli/cli-style.c (class cli_style_option): Update accordingly.
9652         (style_set_list): Move to file scope.
9653         (style_show_list): Likewise.
9654         (set_style): Call help_list.
9655         (show_style): Call cmd_show_list.
9656         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9657         Update to use the new macro.
9658
9659 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9660
9661         * ada-lang.c (_initialize_ada_language): Expand the help text
9662         for the "catch exception" command.
9663
9664 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9665
9666         * symtab.c (matching_obj_sections): Initialize obj,
9667         declare it closer to its usage.
9668
9669 2019-01-10  Tom Tromey  <tom@tromey.com>
9670
9671         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9672         (basic_inf_threads_range): Remove.
9673         (inf_threads_range, inf_non_exited_threads_range)
9674         (safe_inf_threads_range): Use next_adapter.
9675
9676 2019-01-10  Keith Seitz  <keiths@redhat.com>
9677
9678         PR gdb/23712
9679         PR symtab/23010
9680         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9681         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9682
9683 2019-01-10  Keith Seitz  <keiths@redhat.com>
9684
9685         PR gdb/23712
9686         PR symtab/23010
9687         * dictionary.c (pending_to_vector): Remove.
9688         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9689         Remove _1 suffix, replacing functions of the same name.  Update
9690         all callers.
9691         (dict_create_hashed, dict_create_hashed_expandable)
9692         (dict_create_linear, dict_create_linear_expandable, dict_free)
9693         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9694         Make functions static.
9695
9696 2019-01-10  Keith Seitz  <keiths@redhat.com>
9697
9698         PR gdb/23712
9699         PR symtab/23010
9700         * dictionary.h (struct dictionary): Replace declaration with
9701         multidictionary.
9702         (dict_create_hashed, dict_create_hashed_expandable)
9703         (dict_create_linear, dict_create_linear_expandable)
9704         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9705         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9706         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9707         taking multidictionary argument.
9708         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9709         * block.h (struct block) <dict>: Change to multidictionary
9710         and rename `multidict'.
9711         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9712         symmisc.c: Update all dictionary references to multidictionary.
9713
9714 2019-01-10  Keith Seitz  <keiths@redhat.com>
9715
9716         PR gdb/23712
9717         PR symtab/23010
9718         * dictionary.c: Include unordered_map.
9719         (pending_to_vector): New function.
9720         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9721         Rewrite the non-"_1" functions to take vector instead
9722         of linked list.
9723         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9724         "new" _1 versions of the same name.
9725         (multidictionary): Define.
9726         (std::hash<enum language): New definition.
9727         (collate_pending_symbols_by_language, mdict_create_hashed)
9728         (mdict_create_hashed_expandable, mdict_create_linear)
9729         (mdict_create_linear_expandable, mdict_free)
9730         (find_language_dictionary, create_new_language_dictionary)
9731         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9732         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9733         (mdict_size, mdict_empty): New functions.
9734         * dictionary.h (mdict_iterator): Define.
9735
9736 2019-01-10  Pedro Alves  <palves@redhat.com>
9737
9738         * breakpoint.c (read_uploaded_action)
9739         (create_tracepoint_from_upload): Adjust to use
9740         gdb::unique_xmalloc_ptr.
9741         * ctf.c (ctf_write_uploaded_tp):
9742         (SET_ARRAY_FIELD): Use emplace_back.
9743         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9744         * tracefile-tfile.c (tfile_write_uploaded_tp):
9745         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9746         gdb::unique_xmalloc_ptr.
9747         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9748         at_string, cond_string, cmd_strings>: Replace char pointers
9749         with gdb::unique_xmalloc_ptr.
9750
9751 2019-01-10  Pedro Alves  <palves@redhat.com>
9752
9753         * solib-target.c (library_list_start_library): Don't xstrdup name.
9754
9755 2019-01-10  Pedro Alves  <palves@redhat.com>
9756
9757         * mdebugread.c (parse_partial_symbols): Use
9758         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9759
9760 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9761
9762         * linux-fork.c (scoped_switch_fork_info)
9763         <~scoped_switch_fork_info>: Fix incorrect variable name.
9764
9765 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9766
9767         * linux-fork.c (scoped_switch_fork_info)
9768         <scoped_switch_fork_info>: Make explicit.
9769         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9770
9771 2019-01-10  Tom Tromey  <tom@tromey.com>
9772
9773         * objfiles.h (objfile::reset_psymtabs): Update.
9774         * objfiles.c (objfile::objfile): Update.
9775         * psymtab.h (psymtab_storage::obstack): Update.
9776         (psymtab_storage::m_obstack): Use gdb::optional.
9777         (class psymtab_storage): Update comment.  Remove objfile
9778         parameter.
9779         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9780
9781 2019-01-10  Tom Tromey  <tom@tromey.com>
9782
9783         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9784         <free_psymtabs>: Now private.
9785         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9786         (allocate_psymtab): Use new method.
9787
9788 2019-01-10  Tom Tromey  <tom@tromey.com>
9789
9790         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9791         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9792         * mdebugread.c (parse_partial_symbols): Use
9793         allocate_dependencies.
9794         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9795         allocate_dependencies.
9796         (process_psymtab_comp_unit_reader)
9797         (build_type_psymtab_dependencies): Likewise.
9798         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9799
9800 2019-01-10  Tom Tromey  <tom@tromey.com>
9801
9802         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9803         PSYMBOL_SET_LANGUAGE.
9804         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9805
9806 2019-01-10  Tom Tromey  <tom@tromey.com>
9807
9808         * psymtab.h (psymtab_storage::obstack): New method.
9809         <m_obstack>: Rename from obstack; now private.
9810         * psymtab.c (psymtab_storage): Update.
9811         * dwarf2read.c (create_addrmap_from_index)
9812         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9813         Update.
9814
9815 2019-01-10  Tom Tromey  <tom@tromey.com>
9816
9817         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9818         * objfiles.h (objfile::reset_psymtabs): New method.
9819
9820 2019-01-10  Tom Tromey  <tom@tromey.com>
9821
9822         * symmisc.c (print_symbol_bcache_statistics): Update.
9823         (print_objfile_statistics): Update.
9824         * symfile.c (reread_symbols): Update.
9825         * psymtab.h (class psymtab_storage): New.
9826         * psymtab.c (psymtab_storage): New constructor.
9827         (~psymtab_storage): New destructor.
9828         (require_partial_symbols): Update.
9829         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9830         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9831         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9832         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9833         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9834         (start_psymtab_common, end_psymtab_common)
9835         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9836         (allocate_psymtab): Update.
9837         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9838         Update.
9839         (dump_psymtab_addrmap, maintenance_print_psymbols)
9840         (maintenance_check_psymtabs): Update.
9841         (class objfile_psymtabs): Move to objfiles.h.
9842         * psympriv.h (discard_psymtab): Now inline.
9843         (psymtab_discarder::psymtab_discarder): Update.
9844         (psymtab_discarder::~psymtab_discarder): Update.
9845         (ALL_OBJFILE_PSYMTABS): Rewrite.
9846         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9847         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9848         Remove fields.
9849         <partial_symtabs>: New field.
9850         (class objfile_psymtabs): Move from psymtab.h.  Update.
9851         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9852         psymbol_cache.
9853         (objfile::~objfile): Don't destroy psymbol_cache.
9854         * mdebugread.c (parse_partial_symbols): Update.
9855         * dwarf2read.c (create_addrmap_from_index)
9856         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9857         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9858         (add_partial_subprogram, dwarf2_ranges_read): Update.
9859         * dwarf-index-write.c (write_address_map)
9860         (write_one_signatured_type, recursively_write_psymbols)
9861         (class debug_names, class debug_names, write_psymtabs_to_index):
9862         Update.
9863
9864 2019-01-10  Tom Tromey  <tom@tromey.com>
9865
9866         * symtab.h (SYMBOL_SET_NAMES): Update.
9867         (symbol_set_names): Update.
9868         (MSYMBOL_SET_NAMES): Update.
9869         * symtab.c (symbol_set_names): Change argument to be an
9870         objfile_per_bfd_storage.
9871         * psymtab.c (add_psymbol_to_bcache): Update.
9872         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9873
9874 2019-01-10  Tom Tromey  <tom@tromey.com>
9875
9876         * symtab.c (create_demangled_names_hash): Change argument to be an
9877         objfile_per_bfd_storage.
9878         (symbol_set_names): Update.
9879
9880 2019-01-10  Tom Tromey  <tom@tromey.com>
9881
9882         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9883         init_psymbol_list.
9884         * psymtab.c (init_psymbol_list): Do nothing if already called.
9885         * psympriv.h (init_psymbol_list): Add comment.
9886         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9887         init_psymbol_list.
9888         * dbxread.c (dbx_symfile_read): Unconditionally call
9889         init_psymbol_list.
9890
9891 2019-01-10  Tom Tromey  <tom@tromey.com>
9892
9893         * xcoffread.c (scan_xcoff_symtab): Update.
9894         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9895         "where".
9896         * mdebugread.c (parse_partial_symbols)
9897         (handle_psymbol_enumerators): Update.
9898         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9899         * dbxread.c (read_dbx_symtab): Update.
9900         * psympriv.h (psymbol_placement): New enum.
9901         (add_psymbol_to_list): Update.
9902
9903 2019-01-10  Tom Tromey  <tom@tromey.com>
9904
9905         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9906         static_psymbols parameters.
9907         (scan_xcoff_symtab): Update.
9908         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9909         static_psymbols parameters.
9910         * psympriv.h (start_psymtab_common): Update.
9911         * mdebugread.c (parse_partial_symbols): Update.
9912         * dwarf2read.c (create_partial_symtab): Update.
9913         * dbxread.c (read_dbx_symtab): Update.
9914         (start_psymtab): Remove global_psymbols and static_psymbols
9915         parameters.
9916
9917 2019-01-10  Tom Tromey  <tom@tromey.com>
9918
9919         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9920         * psymtab.c (allocate_psymtab): Add comment.
9921         * psympriv.h (allocate_psymtab): Add comment.
9922         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9923         initializations.
9924         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9925
9926 2019-01-10  Tom Tromey  <tom@tromey.com>
9927
9928         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9929         Don't declare.
9930         * mipsread.c: Include mdebugread.h.
9931         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9932         Declare.
9933         * elfread.c: Include mdebugread.h.
9934
9935 2019-01-09  Tom Tromey  <tom@tromey.com>
9936
9937         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9938         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9939         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9940         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9941         (psym_lookup_symbol, psym_find_last_source_symtab)
9942         (psym_forget_cached_source_info, psym_print_stats)
9943         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9944         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9945         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9946         (psym_find_compunit_symtab_by_address)
9947         (maintenance_print_psymbols, maintenance_info_psymtabs)
9948         (maintenance_check_psymtabs): Use ranged for.
9949         * psymtab.h (class objfile_psymtabs): New.
9950         (require_partial_symbols): Return objfile_psymtabs.
9951         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9952
9953 2019-01-09  Tom Tromey  <tom@tromey.com>
9954
9955         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9956         (find_pc_mapped_section, list_overlays_command)
9957         (map_overlay_command, unmap_overlay_command)
9958         (simple_overlay_update): Use all_objfiles.
9959         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9960         * printcmd.c (info_symbol_command): Use all_objfiles.
9961         * objfiles.h (ALL_OBJSECTIONS): Remove.
9962         * maint.c (maintenance_translate_address): Use all_objfiles.
9963         * gcore.c (gcore_create_callback): Use all_objfiles.
9964         (objfile_find_memory_regions): Likewise.
9965
9966 2019-01-09  Tom Tromey  <tom@tromey.com>
9967
9968         * symtab.c (find_line_symtab, info_sources_command)
9969         (make_source_files_completion_list): Use objfile_compunits.
9970         * source.c (select_source_symtab): Use objfile_compunits.
9971         * objfiles.h (struct objfile): Update comment.
9972         (ALL_OBJFILES): Remove.
9973         (ALL_FILETABS): Remove.
9974         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9975         objfile_compunits.
9976
9977 2019-01-09  Tom Tromey  <tom@tromey.com>
9978
9979         * symmisc.c (print_objfile_statistics, dump_objfile)
9980         (maintenance_print_symbols): Use compunit_filetabs.
9981         * source.c (forget_cached_source_info_for_objfile): Use
9982         compunit_filetabs.
9983         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9984         (ALL_FILETABS): Use compunit_filetabs.
9985         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9986         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9987
9988 2019-01-09  Tom Tromey  <tom@tromey.com>
9989
9990         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9991         (compunit_filetabs): New.
9992         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9993         compunit_filetabs.
9994         (info_sources_command, make_source_files_completion_list): Remove
9995         declaration.
9996         * symmisc.c (print_objfile_statistics, dump_objfile)
9997         (maintenance_print_symbols): Remove declaration.
9998         (maintenance_info_symtabs): Use compunit_filetabs.
9999         (maintenance_info_line_tables): Likewise.
10000         * source.c (select_source_symtab): Change local variable name.
10001         (forget_cached_source_info_for_objfile): Remove declaration.
10002         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10003         * objfiles.c (objfile_relocate1): Remove declaration.
10004         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10005         declaration.
10006         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10007         * coffread.c (coff_symtab_read): Remove declaration.
10008         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10009         compunit_filetabs.
10010
10011 2019-01-09  Tom Tromey  <tom@tromey.com>
10012
10013         * symtab.c (lookup_objfile_from_block)
10014         (find_pc_sect_compunit_symtab, search_symbols)
10015         (default_collect_symbol_completion_matches_break_on): Use
10016         objfile_compunits.
10017         * objfiles.h (ALL_COMPUNITS): Remove.
10018         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10019         * cp-support.c (add_symbol_overload_list_qualified): Use
10020         objfile_compunits.
10021         * ada-lang.c (ada_collect_symbol_completion_matches)
10022         (ada_add_global_exceptions): Use objfile_compunits.
10023
10024 2019-01-09  Tom Tromey  <tom@tromey.com>
10025
10026         * source.c (select_source_symtab)
10027         (forget_cached_source_info_for_objfile): Remove declaration.
10028         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10029         declaration.
10030         * maint.c (count_symtabs_and_blocks): Remove declaration.
10031         * cp-support.c (add_symbol_overload_list_qualified): Remove
10032         declaration.
10033         * coffread.c (coff_symtab_read): Remove declaration.
10034         * symtab.c (lookup_symbol_in_objfile_symtabs)
10035         (basic_lookup_transparent_type_1): Use objfile_compunits.
10036         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10037         (info_sources_command, search_symbols)
10038         (default_collect_symbol_completion_matches_break_on)
10039         (make_source_files_completion_list): Remove declaration.
10040         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10041         (ada_collect_symbol_completion_matches)
10042         (ada_add_global_exceptions): Remove declaration.
10043         * linespec.c (iterate_over_all_matching_symtabs): Use
10044         objfile_compunits.
10045         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10046         (class objfile_compunits): New.
10047         (ALL_COMPUNITS): Use objfile_compunits.
10048         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10049         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10050         objfile_compunits.
10051         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10052
10053 2019-01-09  Tom Tromey  <tom@tromey.com>
10054
10055         * symtab.c (search_symbols)
10056         (default_collect_symbol_completion_matches_break_on): Use
10057         objfile_msymbols.
10058         * ada-lang.c (ada_lookup_simple_minsym)
10059         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10060         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10061         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10062         objfile_msymbols.
10063         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10064         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10065         * objc-lang.c (find_methods): Use objfile_msymbols.
10066         (info_selectors_command, info_classes_command): Likewise.
10067         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10068         * objfiles.h (class objfile_msymbols): New.
10069         (ALL_OBJFILE_MSYMBOLS): Remove.
10070         (ALL_MSYMBOLS): Remove.
10071
10072 2019-01-09  Tom Tromey  <tom@tromey.com>
10073
10074         * common/next-iterator.h (next_adapter): Add Iterator template
10075         parameter.
10076         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10077         (class all_objfiles_safe): New.
10078         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10079         * objfiles.c (put_objfile_before): Update comment.
10080         (add_separate_debug_objfile): Likewise.
10081         (free_all_objfiles): Use all_objfiles_safe.
10082         (objfile_purge_solibs): Likewise.
10083
10084 2019-01-09  Tom Tromey  <tom@tromey.com>
10085
10086         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10087         (expand_symtab_containing_pc, lookup_static_symbol)
10088         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10089         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10090         all_objfiles.
10091         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10092         * breakpoint.c (create_overlay_event_breakpoint)
10093         (create_longjmp_master_breakpoint)
10094         (create_std_terminate_master_breakpoint)
10095         (create_exception_master_breakpoint): Use all_objfiles.
10096         * linux-thread-db.c (try_thread_db_load_from_pdir)
10097         (has_libpthread): Use all_objfiles.
10098         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10099         * linespec.c (iterate_over_all_matching_symtabs)
10100         (search_minsyms_for_name): Use all_objfiles.
10101         * maint.c (maintenance_info_sections): Use all_objfiles.
10102         * main.c (captured_main_1): Use all_objfiles.
10103         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10104         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10105         * guile/scm-pretty-print.c
10106         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10107         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10108         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10109         (maintenance_print_msymbols): Use all_objfiles.
10110         * source.c (select_source_symtab): Use all_objfiles.
10111         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10112         * symfile.c (remove_symbol_file_command)
10113         (expand_symtabs_matching, map_symbol_filenames): Use
10114         all_objfiles.
10115         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10116         all_objfiles.
10117         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10118         * objc-lang.c (find_methods): Use all_objfiles.
10119         * objfiles.c (have_partial_symbols, have_full_symbols)
10120         (have_minimal_symbols, qsort_cmp)
10121         (default_iterate_over_objfiles_in_search_order): Use
10122         all_objfiles.
10123         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10124         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10125         (maintenance_check_psymtabs): Use all_objfiles.
10126         (ALL_PSYMTABS): Remove.
10127         * compile/compile-object-run.c (do_module_cleanup): Use
10128         all_objfiles.
10129         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10130         * cp-support.c (add_symbol_overload_list_qualified): Use
10131         all_objfiles.
10132         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10133         Use all_objfiles.
10134         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10135         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10136         all_objfiles.
10137         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10138         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10139         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10140         Uses all_objfiles.
10141         * solib.c (solib_read_symbols): Use all_objfiles
10142
10143 2019-01-09  Tom Tromey  <tom@tromey.com>
10144
10145         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10146         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10147         all_objfiles.
10148         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10149         * symmisc.c (print_symbol_bcache_statistics)
10150         (print_objfile_statistics, maintenance_print_objfiles)
10151         (maintenance_info_symtabs, maintenance_check_symtabs)
10152         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10153         all_objfiles.
10154         * source.c (forget_cached_source_info): Use all_objfiles.
10155         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10156         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10157         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10158         * objfiles.c (update_section_map): Use all_objfiles.
10159         (shared_objfile_contains_address_p): Likewise.
10160         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10161         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10162
10163 2019-01-09  Tom Tromey  <tom@tromey.com>
10164
10165         * common/next-iterator.h: New file.
10166         * objfiles.h (class all_objfiles): New.
10167         (struct objfile_iterator): New.
10168
10169 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10170
10171         * NEWS: Move the description of the changed "frame", "select-frame",
10172          and "info frame" commands to the Changed commands section.
10173
10174 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10175
10176         * gdbtypes.c (check_stub_method_group): Remove handling of old
10177         mangling schemes.
10178         * linespec.c (find_methods): Likewise.
10179         * stabsread.c (read_member_functions): Likewise.
10180         * valops.c (search_struct_method): Likewise.
10181         (value_struct_elt_for_reference): Likewise.
10182         * NEWS: Mention this change.
10183
10184 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10185
10186         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10187         print_source_lines.
10188         * source.c (print_source_lines_base): Update line number check.
10189         (print_source_lines): New function.
10190         (source_lines_range::source_lines_range): New function.
10191         * source.h (class source_lines_range): New class.
10192         (print_source_lines): New declaration.
10193
10194 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10195
10196         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10197
10198 2019-01-08  Tom Tromey  <tom@tromey.com>
10199             Simon Marchi  <simon.marchi@ericsson.com>
10200
10201         PR gdb/24060
10202         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10203         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10204         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10205         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10206         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10207         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10208
10209 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10210
10211         * source.c (select_source_symtab): Move header comment to
10212         declaration in source.h.
10213         (forget_cached_source_info_for_objfile): Likewise.
10214         (forget_cached_source_info): Likewise.
10215         (identify_source_line): Likewise.
10216         * source.h (identify_source_line): Move declaration from symtab.h
10217         and add comment from source.c
10218         (print_source_lines): Likewise.
10219         (forget_cached_source_info_for_objfile): Likewise.
10220         (forget_cached_source_info): Likewise.
10221         (select_source_symtab): Likewise.
10222         (enum print_source_lines_flag): Move definition from symtab.h.
10223         * symtab.h (identify_source_line): Move declaration to source.h.
10224         (print_source_lines): Likewise.
10225         (forget_cached_source_info_for_objfile): Likewise.
10226         (forget_cached_source_info): Likewise.
10227         (select_source_symtab): Likewise.
10228         (enum print_source_lines_flag): Move definition to source.h.
10229         * tui/tui-hooks.c: Add 'source.h' include.
10230
10231 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10232
10233         * source.c (print_source_lines_base): Handle requests to print
10234         reverse line number sequences, and guard against empty lines
10235         string.
10236
10237 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10238
10239         * source.c (print_source_lines_base): Fix skip of '\r' if next
10240         character is '\n'.
10241
10242 2019-01-06  Tom Tromey  <tom@tromey.com>
10243
10244         * c-exp.y (struct c_parse_state) <macro_original_text,
10245         expansion_obstack>: New member.
10246         (macro_original_text, expansion_obstack): Remove globals.
10247         (scan_macro_expansion, scanning_macro_expansion)
10248         (finished_macro_expansion): Update.
10249         (scan_macro_cleanup): Remove.
10250         (yylex, c_parse): Update.
10251
10252 2019-01-06  Tom Tromey  <tom@tromey.com>
10253
10254         * c-exp.y (struct c_parse_state) <strings>: New member.
10255         (operator_stoken): Update.
10256
10257 2019-01-06  Tom Tromey  <tom@tromey.com>
10258
10259         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10260         (union type_stack_elt) <typelist_val>: Now a pointer to
10261         std::vector.
10262         (type_stack_cleanup): Don't declare.
10263         (push_typelist): Update.
10264         * parse.c (pop_typelist): Return a std::vector.
10265         (push_typelist): Take a std::vector.
10266         (follow_types): Update.  Do not free args.
10267         (type_stack_cleanup): Remove.
10268         * c-exp.y (struct c_parse_state): New.
10269         (cpstate): New global.
10270         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10271         (nonempty_typelist): Update.
10272         (func_mod): Create a new vector.
10273         (c_parse): Create a c_parse_state.
10274         (check_parameter_typelist): Do not delete params.
10275         (function_method): Update.  Do not delete type_list.
10276
10277 2019-01-06  Tom Tromey  <tom@tromey.com>
10278
10279         PR gdb/28155:
10280         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10281         check_typedef.
10282         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10283         (print_return_value): Likewise.
10284
10285 2019-01-05  Tom Tromey  <tom@tromey.com>
10286
10287         * contrib/cleanup_check.py: Remove.
10288         * contrib/gcc-with-excheck: Remove.
10289         * contrib/exsummary.py: Remove.
10290         * contrib/excheck.py: Remove.
10291
10292 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10293
10294         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10295         NULL. Initialize tpprev to NULL instead of assigning it
10296         to NULL on the next statement.
10297         * windows-nat.c (windows_delete_thread): Remove check for
10298         main_thread_id before printing thread exit notifications.
10299         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10300         Remove thread ID check against main_thread_id.
10301         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10302         windows_delete_thread.
10303         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10304
10305 2019-01-04  Tom Tromey  <tom@tromey.com>
10306
10307         * compile/compile.c (_initialize_compile): Use upper case for
10308         metasyntactic variables.
10309         * symmisc.c (_initialize_symmisc): Use upper case for
10310         metasyntactic variables.
10311         * psymtab.c (_initialize_psymtab): Use upper case for
10312         metasyntactic variables.
10313         * demangle.c (demangle_command): Use upper case for metasyntactic
10314         variables.
10315         (_initialize_demangler): Likewise.
10316         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10317         variables.
10318
10319 2019-01-03  Tom Tromey  <tom@tromey.com>
10320
10321         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10322
10323 2019-01-03  Tom Tromey  <tom@tromey.com>
10324
10325         * python/py-symtab.c (salpy_str): Update.
10326         (struct salpy_sal_object) <symtab>: Now a PyObject.
10327         (salpy_dealloc): Update.
10328         (del_objfile_sal): Use gdbpy_ref.
10329
10330 2019-01-03  Tom Tromey  <tom@tromey.com>
10331
10332         * python/py-type.c (convert_field): Use new_reference.  Return
10333         gdbpy_ref.
10334         (make_fielditem): Return gdbpy_ref.
10335         (typy_fields): Update.
10336         (typy_getitem): Update.
10337         (field_name): Return gdbpy_ref.  Use new_reference.
10338         (typy_iterator_iternext): Update.
10339
10340 2019-01-03  Tom Tromey  <tom@tromey.com>
10341
10342         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10343
10344 2019-01-03  Tom Tromey  <tom@tromey.com>
10345
10346         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10347         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10348         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10349         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10350         (pspy_set_type_printers): Likewise.
10351         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10352         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10353         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10354         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10355         (objfpy_set_type_printers): Likewise.
10356
10357 2019-01-03  Tom Tromey  <tom@tromey.com>
10358
10359         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10360         (gdbpy_print_stack): Use gdbpy_err_fetch.
10361         * python/python-internal.h (class gdbpy_err_fetch): New class.
10362         (class gdbpy_enter) <m_error_type, m_error_value,
10363         m_error_traceback>: Remove.
10364         <m_error>: New member.
10365         (gdbpy_exception_to_string): Don't declare.
10366         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10367         * python/py-value.c (convert_value_from_python): Use
10368         gdbpy_err_fetch.
10369         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10370         gdbpy_exception_to_string.
10371         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10372         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10373         gdbpy_err_fetch.
10374
10375 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10376
10377         * linux-nat.c (delete_lwp_cleanup): Delete.
10378         (struct lwp_deleter): New struct.
10379         (lwp_info_up): New typedef.
10380         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10381         lwp_info_up.
10382
10383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * linux-fork.c (class scoped_switch_fork_info): New class.
10386         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10387
10388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10389
10390         * valops.c (find_overload_match): Remove use of null_cleanup, and
10391         calls to do_cleanups.
10392
10393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10394
10395         * compile/compile-cplus-types.c
10396         (compile_cplus_instance::decl_name): Handle changes to
10397         cp_func_name.
10398         * cp-support.c (cp_func_name): Update header comment, update
10399         return type.
10400         * cp-support.h (cp_func_name): Update return type in declaration.
10401         * valops.c (find_overload_match): Move temp_func local to top
10402         level of function and change its type.  Use temp_func to hold and
10403         delete temporary string obtained from cp_func_name.
10404
10405 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10406
10407         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10408         gdb::char_vector, remove cleanup, and update uses of `msg`.
10409
10410 2019-01-03  Jim Wilson  <jimw@sifive.com>
10411
10412         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10413
10414 2019-01-02  Tom Tromey  <tom@tromey.com>
10415
10416         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10417         (tdesc_parse_xml): Remove cleanups.
10418         * target-descriptions.h (make_cleanup_free_target_description):
10419         Don't declare.
10420         (target_desc_deleter): New struct.
10421         (target_desc_up): New typedef.
10422         * target-descriptions.c (target_desc_deleter::operator()): Rename
10423         from free_target_description.
10424         (make_cleanup_free_target_description): Remove.
10425
10426 2019-01-02  Tom Tromey  <tom@tromey.com>
10427
10428         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10429         constructor, destructor.
10430         (linespec_parser): Remove typedef.
10431         (~linespec_parser): Rename from linespec_parser_delete.
10432         (linespec_lex_to_end, linespec_complete_label)
10433         (linespec_complete): Update.
10434         (decode_line_full): Remove cleanups.
10435         (decode_line_1): Update.
10436
10437 2019-01-02  Tom Tromey  <tom@tromey.com>
10438
10439         * python/python-internal.h (inferior_to_inferior_object): Change
10440         return type.
10441         * python/py-exitedevent.c (create_exited_event_object): Update.
10442         * python/py-inferior.c (inferior_to_inferior_object): Return
10443         gdbpy_ref.
10444         (python_new_inferior, python_inferior_deleted)
10445         (thread_to_thread_object, delete_thread_object)
10446         (build_inferior_list, gdbpy_selected_inferior): Update.
10447         * python/py-infthread.c (create_thread_object): Update.  Also fail
10448         if inferior_to_inferior_object fails.
10449
10450 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10451
10452         * inferior.h (class inferior) <displaced_step_state>: New field.
10453         * infrun.h (struct displaced_step_state): Move here from
10454         infrun.c.  Initialize fields, add constructor.
10455         <inf>: Remove field.
10456         <reset>: New method.
10457         * infrun.c (struct displaced_step_inferior_state): Move to
10458         infrun.h.
10459         (displaced_step_inferior_states): Remove.
10460         (get_displaced_stepping_state): Adust.
10461         (displaced_step_in_progress_any_inferior): Adjust.
10462         (displaced_step_in_progress_thread): Adjust.
10463         (displaced_step_in_progress): Adjust.
10464         (add_displaced_stepping_state): Remove.
10465         (get_displaced_step_closure_by_addr): Adjust.
10466         (remove_displaced_stepping_state): Remove.
10467         (infrun_inferior_exit): Call displaced_step_state.reset.
10468         (use_displaced_stepping): Don't check for NULL.
10469         (displaced_step_prepare_throw): Call
10470         get_displaced_stepping_state.
10471         (displaced_step_fixup): Don't check for NULL.
10472         (prepare_for_detach): Don't check for NULL.
10473
10474 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10475
10476         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10477          in case of call that did not complete.
10478
10479 2019-01-02  Andrey Utkin  <autkin@undo.io>
10480
10481         * symfile.c (find_separate_debug_file): Fix search of debug files for
10482         remote debuggee.
10483
10484 2019-01-02  Tom Tromey  <tom@tromey.com>
10485
10486         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10487         indentation.
10488         * python/py-frame.c (frapy_older): Remove cast.
10489         (frapy_newer): Likewise.
10490         * python/py-breakpoint.c (local_setattro): Remove cast.
10491         * python/py-arch.c (archpy_name): Remove local variable.
10492         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10493
10494 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10495
10496         * unittests/basic_string_view/element_access/char/empty.cc:
10497         Fix year range in copyright header.
10498
10499 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10500
10501         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10502         Delete.
10503         <operator==>: Update with for removed field.
10504         <hash>: Likewise.
10505         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10506         <isa_features>: ...this.
10507         <abi_features>: New field.
10508         (riscv_isa_flen): Update comment.
10509         (riscv_abi_xlen): New declaration.
10510         (riscv_abi_flen): New declaration.
10511         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10512         isa_features.
10513         (riscv_abi_xlen): New function.
10514         (riscv_isa_flen): Update to get answer from isa_features.
10515         (riscv_abi_flen): New function.
10516         (riscv_has_fp_abi): Update to get answer from abi_features.
10517         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10518         xlen and flen.
10519         (riscv_call_info) <xlen, flen>: Update comment.
10520         (riscv_call_arg_struct): Remove invalid assertions
10521         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10522         is removed.
10523         (riscv_gdbarch_init): Gather isa features and abi features
10524         separately, ensure both match on the gdbarch when reusing an old
10525         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10526         a target with 64-bit float hardware.
10527
10528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10529
10530         * source.c (search_command_helper): Stop reverse search
10531         when line 1 has been searched.
10532
10533 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10534
10535         * record-full.c (record_full_base_target::close): Rewrite
10536         record_full_core_buf_list free logic.
10537
10538 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10539
10540         * break-catch-syscall.c (print_one_catch_syscall): xfree
10541         the last text.
10542
10543 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10544
10545         * top.c (print_gdb_version): Update Copyright year in version
10546         message.
10547
10548 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10549
10550         Update copyright year range in all GDB files.
10551
10552 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10553
10554         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10555
10556 For older changes see ChangeLog-2018.
10557 \f
10558 Local Variables:
10559 mode: change-log
10560 left-margin: 8
10561 fill-column: 74
10562 version-control: never
10563 coding: utf-8
10564 End:
10565