gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_set_focus_command): Rename from
   4         tui_set_focus.  Call tui_enable.
   5         (tui_set_focus_command): Remove.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  10         refresh_window.
  11         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  12         touchwin.
  13         (tui_data_window::refresh_window): Call refresh_window on data
  14         items.  Always call superclass refresh_window.
  15         (tui_win_info::refresh): Remove.
  16         (tui_source_window_base::refresh_window): Update.
  17         (tui_refresh_all): Update.
  18         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  19         refresh_window.
  20         (show_source_or_disasm_and_command): Likewise.
  21         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  22         (struct tui_source_window_base) <refresh>: Likewise.
  23
  24 2019-07-17  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-winsource.c (tui_clear_source_content)
  27         (tui_show_source_content): Update.
  28         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  29         whether content is empty.
  30         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  31         Remove.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  36         window's contents.
  37         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  38         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  39
  40 2019-07-17  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  43         (struct tui_data_item_window): Update.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  48         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  49         defines.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-winsource.h (tui_erase_source_content)
  54         (tui_clear_source_content): Remove "display_prompt" parameter.
  55         * tui/tui-winsource.c (tui_update_source_window_as_is)
  56         (tui_update_source_windows_with_addr): Update.
  57         (tui_clear_source_content): Remove "display_prompt" parameter.
  58         (tui_erase_source_content): Likewise.  Simplify.
  59         (tui_show_source_content): Update.
  60         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  61         * tui/tui-stack.c (tui_show_frame_info): Update.
  62         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  63         Remove defines.
  64
  65 2019-07-17  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  68         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
  69         parameter.
  70         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
  71         parameter.
  72
  73 2019-07-17  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-winsource.c (tui_clear_source_content)
  76         (tui_show_source_content, tui_show_exec_info_content)
  77         (tui_clear_exec_info_content): Update.
  78         * tui/tui-stack.c (tui_show_locator_content): Update.
  79         (tui_show_frame_info): Update.
  80         * tui/tui-source.h (tui_source_window): Don't declare.
  81         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
  82         from tui_source_is_displayed.
  83         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
  84         Remove field.
  85         (struct tui_source_window_base) <content_in_use>: New field.  Now
  86         bool.
  87         (struct tui_source_window) <showing_source_p>: New method.
  88         (TUI_SRC_WIN): Change cast.
  89         * tui/tui-data.c (tui_initialize_static_data): Update.
  90
  91 2019-07-17  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
  94         location_matches_p.
  95         * tui/tui-source.c (tui_source_window::location_matches_p): New
  96         method.
  97         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
  98         method.
  99         * tui/tui-data.h (struct tui_source_window_base)
 100         <location_matches_p>: New method.
 101         (struct tui_source_window, struct tui_disasm_window)
 102         <location_matches_p>: Likewise.
 103
 104 2019-07-17  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-win.c (tui_set_win_height_command): Rename from
 107         tui_set_win_height.
 108         (tui_set_win_height_command): Remove.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-source.c (tui_source_window): New constructor.  Add
 113         observer.
 114         (~tui_source_window): New destructor.
 115         (tui_source_window::style_changed): New method.
 116         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 117         (tui_attach_detach_observers): Update.
 118         * tui/tui-data.h (struct tui_source_window): Make constructor not
 119         inline.  Add destructor.
 120         (struct tui_source_window) <style_changed>: New method.
 121         <m_observable>: New member.
 122
 123 2019-07-17  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 126         * tui/tui-win.c (tui_resize_all): Fix typo.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 131         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 132         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 133         * tui/tui-win.c (window_name_completer): Use foreach.
 134         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 135         (update_tab_width): Likewise.
 136         * tui/tui-layout.c (show_layout): Update.
 137         * tui/tui-data.h (class tui_window_iterator): New.
 138         (struct all_tui_windows): New.
 139         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 144         parameter.  Don't reference globals.
 145         (tui_reg_command): Update.
 146
 147 2019-07-17  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-regs.c (tui_show_registers): Simplify.
 150
 151 2019-07-17  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-regs.c (tui_show_registers): Update.
 154         (tui_show_register_group): Add win_info parameter.
 155
 156 2019-07-17  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 159         Rename from tui_display_reg_element_at_line.
 160         (tui_data_window::display_registers_from_line): Update.
 161         * tui/tui-data.h (struct tui_data_window)
 162         <display_reg_element_at_line>: New method.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-regs.h (tui_display_registers_from)
 167         (tui_display_registers_from_line): Don't declare.
 168         * tui/tui-windata.c (tui_data_window::display_all_data)
 169         (tui_data_window::refresh_all)
 170         (tui_data_window::do_scroll_vertical): Update.
 171         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 172         from tui_display_registers_from.
 173         (tui_display_reg_element_at_line): Update.
 174         (tui_data_window::display_registers_from_line): Rename from
 175         tui_display_registers_from_line.
 176         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 177         display_registers_from_line>: New methods.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 182         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 183         from tui_erase_data_content.
 184         (tui_data_window::display_all_data)
 185         (tui_data_window::refresh_all)
 186         (tui_data_window::do_scroll_vertical): Update.
 187         * tui/tui-regs.c (tui_show_registers): Update.
 188         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 189         New method.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 194         declare.
 195         * tui/tui-windata.c
 196         (tui_data_window::delete_data_content_windows): Rename from
 197         tui_delete_data_content_windows.
 198         (tui_data_window::display_all_data)
 199         (tui_data_window::do_scroll_vertical): Update.
 200         * tui/tui-data.h (struct tui_data_window)
 201         <delete_data_content_windows>: New method.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 206         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 207
 208 2019-07-17  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 211         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 212         from tui_display_all_data.
 213         * tui/tui-win.c
 214         (tui_data_window::do_make_visible_with_new_height): Update.
 215         * tui/tui-regs.c (tui_show_registers): Update.
 216         * tui/tui-layout.c (tui_set_layout): Update.
 217         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 218         method.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 223         * tui/tui-windata.c (tui_display_data_from): Remove.
 224         (tui_data_window::refresh_all): Update.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 229         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 230         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 231         tui_display_registers_from_line.
 232         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 233         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 234         "force_display" parameter.
 235
 236 2019-07-17  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 239         declare.
 240         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 241         Rename from tui_first_reg_element_no_inline.
 242         (tui_display_reg_element_at_line)
 243         (tui_display_registers_from_line): Update.
 244         * tui/tui-data.h (struct tui_data_window)
 245         <first_reg_element_no_inline>: New method.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-windata.c (tui_display_data_from)
 250         (tui_data_window::do_scroll_vertical): Update.
 251         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 252         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 253         Rename from tui_line_from_reg_element_no.
 254         (tui_display_registers_from_line): Update.
 255         * tui/tui-data.h (struct tui_data_window)
 256         <line_from_reg_element_no>: New method.
 257
 258 2019-07-17  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 261         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 262         tui_last_regs_line_no.
 263         (tui_display_reg_element_at_line)
 264         (tui_display_registers_from_line): Update.
 265         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 266         method.
 267
 268 2019-07-17  Tom Tromey  <tom@tromey.com>
 269
 270         PR tui/24722:
 271         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 272         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 273         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 274         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 275         (tui_update_breakpoint_info): Likewise.
 276         * tui/tui-hooks.c (tui_event_create_breakpoint)
 277         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 278         Update.
 279
 280 2019-07-17  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 283
 284 2019-07-17  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-winsource.c (tui_update_source_window_as_is)
 287         (tui_update_source_windows_with_addr): Update.
 288         * tui/tui-source.h (tui_set_source_content)
 289         (tui_show_symtab_source): Add "win_info" parameter.
 290         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 291         parameter.
 292         (tui_show_symtab_source): Likewise.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-wingeneral.c
 297         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 298
 299 2019-07-17  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 302         (struct tui_cmd_window) <can_scroll>: New method.
 303         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 304         method.
 305
 306 2019-07-17  Tom Tromey  <tromey@adacore.com>
 307
 308         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 309         do_field_signed>: Rename.  Change type of "value".
 310         * ui-out.c (ui_out::field_signed): Rename from field_int.
 311         Change type of "value".
 312         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 313         type of "value".
 314         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 315         do_field_int.  Change type of "value".
 316         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 317         do_field_int.  Change type of "value".
 318         * tracepoint.c (trace_status_mi, tfind_1)
 319         (print_one_static_tracepoint_marker): Update.
 320         * thread.c (print_thread_info_1, print_selected_thread_frame):
 321         Update.
 322         * stack.c (print_frame, print_frame_info): Update.
 323         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 324         Update.
 325         * source.c (print_source_lines_base): Update.
 326         * skip.c (info_skip_command): Update.
 327         * record-btrace.c (btrace_ui_out_decode_error)
 328         (btrace_call_history_src_line): Update.
 329         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 330         Update.
 331         * progspace.c (print_program_space): Update.
 332         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 333         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 334         do_field_int.  Change type of "value".
 335         * mi/mi-out.c (mi_ui_out::do_table_begin)
 336         (mi_ui_out::do_table_header): Update.
 337         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 338         type of "value".
 339         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 340         (mi_cmd_data_list_changed_registers, output_register)
 341         (mi_cmd_data_read_memory, mi_load_progress)
 342         (mi_cmd_trace_frame_collected): Update.
 343         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 344         Update.
 345         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 346         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 347         (mi_cmd_var_list_children, varobj_update_one): Update.
 348         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 349         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 350         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 351         * inferior.c (print_inferior): Update.
 352         * gdb_bfd.c (print_one_bfd): Update.
 353         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 354         Update.
 355         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 356         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 357         do_field_int.  Change type of "value".
 358         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 359         do_field_int.  Change type of "value".
 360         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 361         (print_one_breakpoint_location, print_it_catch_fork)
 362         (print_one_catch_fork, print_it_catch_vfork)
 363         (print_one_catch_vfork, print_it_catch_solib)
 364         (print_it_catch_exec, print_it_ranged_breakpoint)
 365         (print_mention_watchpoint, print_mention_masked_watchpoint)
 366         (bkpt_print_it, update_static_tracepoint): Update.
 367         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 368         * break-catch-syscall.c (print_it_catch_syscall): Update.
 369         * ada-tasks.c (print_ada_task_info): Update.
 370         * ada-lang.c (print_it_exception, print_mention_exception):
 371         Update.
 372
 373 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         PR breakpoints/24541
 376         * gdbarch.c: Regenerate.
 377         * gdbarch.h: Regenerate.
 378         * gdbarch.sh: Adjust return type and parameter types for
 379         'stap_adjust_register'.
 380         (i386_stap_adjust_register): Adjust signature and return new
 381         register name.
 382         * stap-probe.c (stap_parse_register_operand): Adjust use of
 383         'gdbarch_stap_adjust_register'.
 384
 385 2019-07-17  Tom Tromey  <tromey@adacore.com>
 386
 387         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 388         declare VEC.
 389         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 390         std::vector.
 391         (struct s390_process_info): Add initializers.
 392         (s390_add_process): Use new.
 393         (s390_linux_nat_target::low_forget_process): Use delete.
 394         (s390_linux_nat_target::low_new_fork)
 395         (s390_linux_nat_target::stopped_by_watchpoint)
 396         (s390_linux_nat_target::low_prepare_to_resume)
 397         (s390_linux_nat_target::insert_watchpoint)
 398         (s390_linux_nat_target::insert_hw_breakpoint)
 399         (s390_linux_nat_target::remove_watchpoint)
 400         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 401
 402 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 403
 404         * aarch64-fbsd-nat.c: Include regcache.h.
 405         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 406         argument.
 407         (aarch64_fbsd_nat_target::fetch_registers)
 408         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 409         variable.
 410         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 411
 412 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 413
 414         * fbsd-nat.c: Include gdbarch.h.
 415
 416 2019-07-15  Tom Tromey  <tromey@adacore.com>
 417
 418         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 419
 420 2019-07-15  Tom Tromey  <tromey@adacore.com>
 421
 422         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 423         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 424         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 425         * cli-out.c (cli_ui_out::do_field_int): New method.
 426         * ui-out.c (ui_out::field_unsigned): New method.
 427         * symfile.c (generic_load): Use field_unsigned.
 428         (print_transfer_performance): Likewise.
 429         * record-btrace.c (ui_out_field_uint): Remove.
 430         (btrace_call_history_insn_range, btrace_call_history): Use
 431         field_unsigned.
 432         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 433         field_unsigned.
 434         * ui-out.h (class ui_out) <field_unsigned>: New method.
 435         <do_field_unsigned>: Likewise.
 436
 437 2019-07-15  Tom Tromey  <tromey@adacore.com>
 438
 439         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 440         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 441         * target.c (flash_erase_command): Use field_string.
 442         * infrun.c (print_signal_received_reason): Use field_string.
 443         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 444         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 445         field_string.
 446         * ada-tasks.c (print_ada_task_info): Use field_string.
 447
 448 2019-07-15  Tom Tromey  <tromey@adacore.com>
 449
 450         * target.c (flash_erase_command): Use field_core_addr.
 451         * symfile.c (generic_load): Use field_core_addr.
 452         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 453         Use field_core_addr.
 454         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 455         field_core_addr.
 456
 457 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 460         value if its desired type is smaller than a CORE_ADDR and signed.
 461
 462 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 465         of changes to field names, and use new is_reference field to
 466         decide if a property is a reference or not.
 467         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 468         field.
 469         (struct dwarf2_property_baton): Update header comment, rename
 470         'referenced_type' to 'property_type' and update comments.
 471         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 472         default property type, store in property baton, update to take
 473         accound of renamed field.
 474         (read_func_scope): Update call to attr_to_dynamic_prop.
 475         (read_array_type): Likewise.
 476         (dwarf2_per_cu_addr_sized_int_type): New function.
 477         (read_subrange_index_type): Move type finding code to
 478         dwarf2_per_cu_addr_sized_int_type.
 479         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 480         (dwarf2_per_cu_addr_type): New function.
 481         (set_die_type): Update calls to attr_to_dynamic_prop.
 482
 483 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * dwarf2read.c (read_subrange_index_type): New function.
 486         (read_subrange_type): Move code into new function and call it.
 487         * gdbtypes.c (create_range_type): Add some asserts.
 488
 489 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 490
 491         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 492         update return statements.
 493         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 494         declaration, and update comment to match.
 495         * gdbtypes.c (resolve_dynamic_array): Update call to
 496         dwarf2_evaluate_property to match new return type.
 497
 498 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * valarith.c (value_subscripted_rvalue): Change lowerbound
 501         parameter type from int to LONGEST.
 502         * value.h (value_subscripted_rvalue): Likewise in declaration.
 503
 504 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * cli/cli-utils.c (info_print_command_completer): New function.
 507         * cli/cli-utils.h: Add 'completer.h' include, and forward
 508         declaration for 'struct cmd_list_element'.
 509         (info_print_command_completer): Declare.
 510         * stack.c (_initialize_stack): Add completer for 'info locals' and
 511         'info args'.
 512         * symtab.c (_initialize_symtab): Add completer for 'info
 513         variables' and 'info functions'.
 514         * NEWS: Mention completion for additional info commands.
 515
 516 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * cli/cli-utils.c (extract_info_print_args): Delete.
 519         (extract_arg_maybe_quoted): Delete.
 520         (info_print_options_defs): New variable.
 521         (make_info_print_options_def_group): New function.
 522         (extract_info_print_options): Define new function.
 523         * cli/cli-utils.h (extract_info_print_args): Delete.
 524         (struct info_print_options): New structure.
 525         (extract_info_print_options): Declare new function.
 526         * stack.c (info_locals_command): Update to use new
 527         extract_info_print_options, also add a header comment.
 528         (info_args_command): Likewise.
 529         * symtab.c (info_variables_command): Likewise.
 530         (info_functions_command): Likewise.
 531
 532 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 535         to extract string arguments.
 536         * common/common-utils.c (extract_string_maybe_quoted): New function.
 537         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 538
 539 2019-07-11  Tom Tromey  <tromey@adacore.com>
 540
 541         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 542         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 543         * top.h (gdbinit): Don't declare.
 544         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 545         into...
 546         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 547         * top.c (gdb_init): Don't call init_cli_cmds.
 548         (gdbinit): Remove.
 549         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 550
 551 2019-07-11  Tom Tromey  <tromey@adacore.com>
 552
 553         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 554         after it has been moved.
 555
 556 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 557
 558         * valops.c (value_must_coerce_to_target): Change return type to
 559         bool.
 560         * value.h (value_must_coerce_to_target): Likewise.
 561
 562 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 563
 564         * breakpoint.c (is_hardware_watchpoint): Remove
 565         forward-declaration.
 566         (is_masked_watchpoint): Change return type to bool.
 567         (is_tracepoint): Likewise.
 568         (is_breakpoint): Likewise.
 569         (is_hardware_watchpoint): Likewise.
 570         (is_watchpoint): Likewise.
 571         (is_no_memory_software_watchpoint): Likewise.
 572         (is_catchpoint): Likewise.
 573         (breakpoint_1): Make FILTER parameter's return type bool.
 574         is_masked_watchpoint): Change return type to bool.
 575         (save_breakpoints): Make FILTER parameter's return type bool.
 576         * breakpoint.h (is_breakpoint): Change return type to bool.
 577         (is_watchpoint): Likewise.
 578         (is_catchpoint): Likewise.
 579         (is_tracepoint): Likewise.
 580
 581 2019-07-10  Tom Tromey  <tom@tromey.com>
 582
 583         * defs.h: Don't include gdbarch.h.
 584         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 585         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 586         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 587         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 588         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 589         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 590         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 591         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 592         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 593         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 594         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 595         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 596         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 597         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 598         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 599         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 600         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 601         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 602         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 603         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 604         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 605         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 606         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 607         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 608         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 609         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 610         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 611
 612 2019-07-10  Tom Tromey  <tromey@adacore.com>
 613
 614         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 615         * breakpoint.c (init_ada_exception_breakpoint): Register as
 616         bp_catchpoint.
 617         (print_one_breakpoint_location, print_one_breakpoint): Use
 618         is_ada_exception_catchpoint.
 619         * ada-lang.c (class ada_catchpoint_location): Pass
 620         bp_loc_software_breakpoint to bp_location constructor.
 621         (is_ada_exception_catchpoint): New function.
 622
 623 2019-07-10  Tom Tromey  <tromey@adacore.com>
 624
 625         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 626         VEC.
 627         (struct arm_exidx_entry): New method operator<.
 628         (struct arm_exidx_data) <section_maps>: Change type.
 629         (arm_exidx_data_free): Remove.
 630         (arm_exidx_data_key): Change type.  Move lower.
 631         (arm_exidx_new_objfile): Update.
 632         (arm_compare_exidx_entries): Remove.
 633         (arm_find_exidx_entry, _initialize_arm_tdep)
 634
 635 2019-07-10  Tom Tromey  <tromey@adacore.com>
 636
 637         * solib-spu.c (ocl_program_data_key): Change type.
 638         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 639         Update.
 640
 641 2019-07-10  Tom Tromey  <tromey@adacore.com>
 642
 643         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 644         (struct solib_aix_inferior_data) <library_list>: Change type.
 645         (solib_aix_inferior_data_handle): Change type.
 646         (get_solib_aix_inferior_data): Update.
 647         (solib_aix_free_library_list): Remove.
 648         (library_list_start_library): Update.
 649         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 650         return type.
 651         (solib_aix_get_library_list)
 652         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 653         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 654
 655 2019-07-10  Tom Tromey  <tromey@adacore.com>
 656
 657         * solib-dsbt.c (struct dsbt_info): Add initializers.
 658         (solib_dsbt_pspace_data): Change type.
 659         (dsbt_pspace_data_cleanup): Remove.
 660         (get_dsbt_info, _initialize_dsbt_solib): Update.
 661
 662 2019-07-10  Tom Tromey  <tromey@adacore.com>
 663
 664         * spu-tdep.c (spu_overlay_data): Change type.
 665         (spu_get_overlay_table, spu_overlay_new_objfile)
 666         (_initialize_spu_tdep): Update.
 667
 668 2019-07-10  Tom Tromey  <tromey@adacore.com>
 669
 670         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 671         destructor.
 672         (dbx_objfile_data_key): Change type and declare later.
 673         (DBX_SYMFILE_INFO): Rewrite.
 674         * dbxread.c (dbx_objfile_data_key): Change type.
 675         (dbx_symfile_init): Update.
 676         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 677         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 678         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 679
 680 2019-07-10  Tom Tromey  <tromey@adacore.com>
 681
 682         * jit.c (jit_program_space_key): Change type.  Move lower.
 683         (get_jit_program_space_data): Update.
 684         (jit_program_space_data_cleanup): Remove.
 685         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 686         Update.
 687         (struct jit_program_space_data): Add initializers.
 688
 689 2019-07-10  Tom Tromey  <tromey@adacore.com>
 690
 691         * solib-darwin.c (struct darwin_info): Add initializers.
 692         (solib_darwin_pspace_data): Change type.
 693         (darwin_pspace_data_cleanup): Remove.
 694         (get_darwin_info, _initialize_darwin_solib): Update.
 695
 696 2019-07-10  Tom Tromey  <tromey@adacore.com>
 697
 698         * remote-sim.c (struct sim_inferior_data): Add initializers,
 699         constructor, and destructor.
 700         (sim_inferior_data_key): Change type.  Move lower.
 701         (check_for_duplicate_sim_descriptor): Update.
 702         (get_sim_inferior_data): Use new.  Update.
 703         (~sim_inferior_data_cleanup): Rename from
 704         sim_inferior_data_cleanup.  Simplify.
 705         (gdbsim_close_inferior, simulator_command)
 706         (sim_command_completer, _initialize_remote_sim): Update.
 707         (next_pid, INITIAL_PID): Move earlier.
 708
 709 2019-07-10  Tom Tromey  <tromey@adacore.com>
 710
 711         * python/python-internal.h (create_thread_object): Return
 712         gdbpy_ref.
 713         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 714         * python/py-inferior.c (struct threadlist_entry): Add
 715         constructor.
 716         <thread_obj>: Now a gdbpy_ref.
 717         (thread_to_thread_object): Update.
 718         (add_thread_object): Use new.
 719         (delete_thread_object): Use delete.
 720         (infpy_threads): Update.
 721         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 722         GIL.
 723
 724 2019-07-10  Tom Tromey  <tromey@adacore.com>
 725
 726         * valops.c (value_cast): Specialize error message for Ada.
 727
 728 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 729
 730         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 731
 732 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 733
 734         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 735         bpstat_should_step): Return bool, adjust comments.
 736         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 737         bpstat_should_step): Likewise.
 738
 739 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 740
 741         * features/Makefile: Use feature target descriptions for Arm.
 742         * features/arm/arm-core.c: Generate new file.
 743         * features/arm/arm-fpa.c: Likewise.
 744         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 745         * features/arm/arm-m-profile.c: Likewise.
 746         * features/arm/arm-vfpv2.c: Likewise.
 747         * features/arm/arm-vfpv3.c: Likewise.
 748         * features/arm/xscale-iwmmxt.c: Likewise.
 749         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 750
 751 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 752
 753         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 754         ptrace earlier.
 755
 756 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 757
 758         * features/aarch64-pauth.c: Regenerate.
 759
 760 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 761
 762         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 763         bool.
 764         (bpstat_what): Use false instead of 0.
 765
 766 2019-07-09  Pedro Alves  <palves@redhat.com>
 767
 768         * break-catch-throw.c (is_exception_catchpoint): New.
 769         * breakpoint.c (print_one_breakpoint_location): New parameter
 770         'raw_loc'.  Handle it.  Use
 771         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 772         looking at the breakpoint's type.
 773         (print_one_breakpoint): If handling "maint info breakpoints", also
 774         print locations of exception catchpoints.
 775         * breakpoint.h (is_exception_catchpoint): Declare.
 776
 777 2019-07-09  Pedro Alves  <palves@redhat.com>
 778
 779         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 780         "addr" field.
 781         (allocate_location_exception_catchpoint): New.
 782         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 783         (initialize_throw_catchpoint_ops): Install
 784         allocate_location_exception_catchpoint as allocate_location
 785         method.
 786         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 787         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 788         bp_loc_other.
 789         (breakpoint_address_is_meaningful): Delete.
 790         (bl_address_is_meaningful): New.
 791         (breakpoint_locations_match): Adjust comment.
 792         (bp_location_from_bp_type): New, factored out of...
 793         (bp_location::bp_location(breakpoint *)): ... this.
 794         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 795         factored out of...
 796         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 797         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 798         breakpoint_address_is_meaningful.
 799         (bp_locations_compare): Adjust comment.
 800         (update_global_location_list): Use bl_address_is_meaningful
 801         instead of breakpoint_address_is_meaningful.
 802         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 803         explicit.
 804         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 805         * python/py-breakpoint.c (bppy_get_location): No longer check
 806         whether location is null.
 807
 808 2019-07-09  Pedro Alves  <palves@redhat.com>
 809
 810         PR c++/15468
 811         * breakpoint.c (print_one_breakpoint_location): Remove
 812         single-location assert.
 813
 814 2019-07-09  Tom Tromey  <tom@tromey.com>
 815
 816         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 817         * configure: Rebuild.
 818         * configure.ac: Change common to gdbsupport.
 819         * gdbsupport: Rename from common.
 820         * acinclude.m4: Change common to gdbsupport.
 821         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 822         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 823         gdbsupport.
 824         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 825         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 826         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 827         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 828         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 829         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 830         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 831         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 832         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 833         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 834         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 835         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 836         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 837         coff-pe-read.c, command.h, compile/compile-c-support.c,
 838         compile/compile-c.h, compile/compile-cplus-symbols.c,
 839         compile/compile-cplus-types.c, compile/compile-cplus.h,
 840         compile/compile-loc2c.c, compile/compile.c, completer.c,
 841         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 842         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 843         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 844         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 845         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 846         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 847         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 848         features/aarch64-core.c, features/aarch64-fpu.c,
 849         features/aarch64-pauth.c, features/aarch64-sve.c,
 850         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 851         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 852         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 853         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 854         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 855         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 856         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 857         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 858         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 859         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 860         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 861         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 862         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 863         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 864         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 865         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 866         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 867         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 868         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 869         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 870         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 871         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 872         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 873         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 874         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 875         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 876         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 877         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 878         minsyms.c, mips-linux-tdep.c, namespace.h,
 879         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 880         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 881         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 882         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 883         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 884         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 885         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 886         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 887         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 888         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 889         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 890         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 891         procfs.c, producer.c, progspace.h, psymtab.h,
 892         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 893         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 894         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 895         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 896         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 897         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 898         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 899         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 900         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 901         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 902         target-memory.c, target.c, target.h, target/waitstatus.c,
 903         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 904         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 905         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 906         unittests/array-view-selftests.c,
 907         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 908         unittests/common-utils-selftests.c,
 909         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 910         unittests/format_pieces-selftests.c,
 911         unittests/function-view-selftests.c,
 912         unittests/lookup_name_info-selftests.c,
 913         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 914         unittests/mkdir-recursive-selftests.c,
 915         unittests/observable-selftests.c,
 916         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 917         unittests/parse-connection-spec-selftests.c,
 918         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 919         unittests/scoped_fd-selftests.c,
 920         unittests/scoped_mmap-selftests.c,
 921         unittests/scoped_restore-selftests.c,
 922         unittests/string_view-selftests.c, unittests/style-selftests.c,
 923         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 924         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 925         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 926         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 927         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 928         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 929
 930 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 933         bool value.
 934         (decode_digits_ordinary): Set explicit_line field in sal.
 935         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 936         symtab_and_line that was set on an explicit line number in
 937         assembler code.  Do always update the recorded symtab and line if
 938         we do skip the prologue.
 939
 940 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * breakpoint.c (set_breakpoint_location_function): Remove
 943         explicit_loc parameter.
 944         (momentary_breakpoint_from_master): Update call to
 945         set_breakpoint_location_function.
 946         (add_location_to_breakpoint): Likewise.
 947
 948 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 951         required features based on default bfd type when no specific bfd
 952         is present.
 953
 954 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955
 956         * NEWS: Mention that GDB printf and eval commands can now print
 957         C-style and Ada-style convenience var strings without
 958         calling the inferior.
 959         * printcmd.c (printf_c_string): Locally print GDB internal var
 960         instead of transiting via the inferior.
 961         (printf_wide_c_string): Likewise.
 962
 963 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 966
 967 2019-07-04  Tom Tromey  <tom@tromey.com>
 968
 969         PR tui/24724:
 970         * tui/tui-winsource.c (tui_clear_source_content): Update.
 971         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 972         (tui_update_breakpoint_info): Update.
 973         (tui_set_exec_info_content): Update.
 974         * tui/tui-source.c (tui_set_source_content_nil): Update.
 975         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 976         has_break.
 977         * tui/tui-data.h (enum tui_bp_flag): New.
 978         (tui_bp_flags): New enum flags type.
 979         (struct tui_source_element) <break_mode>: Change type.  Rename
 980         from has_break.
 981         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 982         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 983         constants.
 984         * tui/tui-winsource.h: Fix comment.
 985
 986 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 987
 988         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 989         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 990         (store_fpregs_to_thread)
 991         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 992         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 993         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 994         (IWMMXT_REGS_SIZE): Add define.
 995         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 996         (fetch_vfp_regs, store_vfp_regs)
 997         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 998         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 999
1000 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1001
1002         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1003         defines.
1004         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1005         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1006         (ARM_INT_REGISTER_SIZE): ...to this.
1007         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1008         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1009         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1010         (arm_linux_collect_gregset, supply_nwfpe_register)
1011         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1012         defines.
1013         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1014         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1015         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1016         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1017         (arm_return_in_memory, arm_store_return_value)
1018         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1019         (arm_record_ld_st_multiple): Likewise.
1020         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1021         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1022
1023 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1026         AARCH64_DISPLACED_MODIFIED_INSNS.
1027         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1028         (aarch64_displaced_step_copy_insn): Likewise.
1029         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1030         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1031         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1032         ARM_DISPLACED_MODIFIED_INSNS.
1033         * arm-tdep.c (arm_gdbarch_init): Likewise.
1034         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1035         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1036         (struct arm_displaced_step_closure): Use
1037         ARM_DISPLACED_MODIFIED_INSNS.
1038
1039 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1040
1041         * features/Makefile: Remove unused xml files.
1042         * features/aarch64.xml: Remove.
1043         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1044         * features/i386/amd64-avx-avx512.xml: Remove.
1045         * features/i386/amd64-avx-linux.xml: Remove.
1046         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1047         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1048         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1049         * features/i386/amd64-avx-mpx.xml: Remove.
1050         * features/i386/amd64-avx.xml: Remove.
1051         * features/i386/amd64-linux.xml: Remove.
1052         * features/i386/amd64-mpx-linux.xml: Remove.
1053         * features/i386/amd64-mpx.xml: Remove.
1054         * features/i386/amd64.xml: Remove.
1055         * features/i386/i386-avx-avx512-linux.xml: Remove.
1056         * features/i386/i386-avx-avx512.xml: Remove.
1057         * features/i386/i386-avx-linux.xml: Remove.
1058         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1059         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1060         * features/i386/i386-avx-mpx-linux.xml: Remove.
1061         * features/i386/i386-avx-mpx.xml: Remove.
1062         * features/i386/i386-avx.xml: Remove.
1063         * features/i386/i386-linux.xml: Remove.
1064         * features/i386/i386-mmx-linux.xml: Remove.
1065         * features/i386/i386-mmx.xml: Remove.
1066         * features/i386/i386-mpx-linux.xml: Remove.
1067         * features/i386/i386-mpx.xml: Remove.
1068         * features/i386/i386.xml: Remove.
1069         * features/i386/x32-avx-avx512-linux.xml: Remove.
1070         * features/i386/x32-avx-linux.xml: Remove.
1071         * features/i386/x32-linux.xml: Remove.
1072
1073 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1074
1075         * regformats/aarch64.dat: Remove.
1076         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1077         * regformats/i386/amd64-avx-linux.dat: Remove.
1078         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1079         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1080         * regformats/i386/amd64-linux.dat: Remove.
1081         * regformats/i386/amd64-mpx-linux.dat: Remove.
1082         * regformats/i386/amd64.dat: Remove.
1083         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1084         * regformats/i386/i386-avx-linux.dat: Remove.
1085         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1086         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1087         * regformats/i386/i386-linux.dat: Remove.
1088         * regformats/i386/i386-mmx-linux.dat: Remove.
1089         * regformats/i386/i386-mpx-linux.dat: Remove.
1090         * regformats/i386/i386.dat: Remove.
1091         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1092         * regformats/i386/x32-avx-linux.dat: Remove.
1093         * regformats/i386/x32-linux.dat: Remove.
1094
1095 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * aarch64-tdep.c: Remove xml self tests.
1098         * amd64-linux-tdep.c: Likewise.
1099         * amd64-tdep.c: Likewise.
1100         * i386-linux-tdep.c: Likewise.
1101         * i386-tdep.c: Likewise.
1102
1103 2019-07-03  Pedro Alves  <palves@redhat.com>
1104
1105         PR cli/24732
1106         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1107         (pipe_cmd_option_defs): New.
1108         (make_pipe_cmd_options_def_group): New.
1109         (pipe_command): Use gdb::option::process_options.
1110         (pipe_command_completer): New function.
1111         (_initialize_cli_cmds): Install completer for "pipe" command.
1112
1113 2019-07-03  Pedro Alves  <palves@redhat.com>
1114
1115         * cli/cli-option.c (union option_value) <string>: New field.
1116         (struct option_def_and_value): Add ctor, move ctor, dtor and
1117         use DISABLE_COPY_AND_ASSIGN.
1118         (option_def_and_value::clear_value): New.
1119         (parse_option, save_option_value_in_ctx, get_val_type_str)
1120         (add_setshow_cmds_for_options): Handle var_string.
1121         * cli-option.h (union option_def::var_address) <string>: New
1122         field.
1123         (struct string_option_def): New.
1124         * maint-test-options.c (struct test_options_opts): Add default
1125         ctor and use DISABLE_COPY_AND_ASSIGN.
1126         <string_opt>: New field.
1127         (test_options_opts::~test_options_opts): New.
1128         (test_options_opts::dump): Also dump "-string".
1129         (test_options_option_defs): Install "string.
1130
1131 2019-07-03  Pedro Alves  <palves@redhat.com>
1132
1133         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1134         option_value with a null enumeration.
1135         (complete_options): Save the option values in the context.
1136         (save_option_value_in_ctx): New, factored out from ...
1137         (process_options): ... here.
1138         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1139         of the function.
1140         * maint-test-options.c (test_options_opts::dump): New, factored
1141         out from ...
1142         (maintenance_test_options_command_mode): ... here.
1143         (maintenance_test_options_command_completion_result): Delete.
1144         (maintenance_test_options_command_completion_text): Update
1145         comment.
1146         (maintenance_show_test_options_completion_result): Change
1147         prototype.  Just print
1148         maintenance_test_options_command_completion_text.
1149         (save_completion_result): New.
1150         (maintenance_test_options_completer_mode): Pass options context to
1151         complete_options, and then save a dump.
1152         (_initialize_maint_test_options): Use add_cmd to install "maint
1153         show test-options-completion-result".
1154
1155 2019-07-03  Pedro Alves  <palves@redhat.com>
1156
1157         * NEWS (New commands): Mention "with" and "maint with".
1158         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1159         (with_command, with_command_completer): New.
1160         (pipe_command): Adjust to new repeat_previous
1161         interface.
1162         (_initialize_cli_cmds): Install the "with" command and its "w"
1163         alias.
1164         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1165         declarations.
1166         * cli/cli-setshow.c (parse_cli_var_uinteger)
1167         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1168         argument strings for all var_types.
1169         (get_setshow_command_value_string): New, factored out from ...
1170         (do_show_command): ... this.
1171         * cli/cli-setshow.h: Include <string>.
1172         (get_setshow_command_value_string): Declare.
1173         * command.h (repeat_previous): Now returns const char *.  Adjust
1174         comment.
1175         * maint.c: Include "cli/cli-cmds.h".
1176         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1177         (_initialize_maint_cmds): Register the "maintenance with" command.
1178         * top.c (repeat_previous): Move bits from pipe_command here:
1179         Return the saved command line, if any; error out if there's no
1180         command to relaunch.
1181
1182 2019-07-03  Pedro Alves  <palves@redhat.com>
1183
1184         * NEWS (New commands): Mention "maint set/show test-settings"
1185         instead of "maint test-settings".
1186         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1187         (maintenance_test_settings_set_list): Rename to ...
1188         (maintenance_set_test_settings_list): ... this.
1189         (maintenance_test_settings_show_list): Rename to  ...
1190         (maintenance_show_test_settings_list): ... this.
1191         (maintenance_test_settings_cmd): Delete.
1192         (maintenance_test_settings_set_cmd): ...
1193         (maintenance_set_test_settings_cmd): ... this.
1194         (maintenance_test_settings_show_cmd): ...
1195         (maintenance_show_test_settings_cmd): ... this.
1196         (maintenance_test_settings_show_value_cmd):
1197         (maintenance_show_test_settings_value_cmd): ... this.
1198         (_initialize_maint_test_settings): No longer install the "maint
1199         test-settings" prefix command.  Rename "maint test-settings set"
1200         to "maint set test-settings", and "maint test-settings show" to
1201         "maint show test-settings".  Adjust all subcommands.
1202
1203 2019-07-03  Pedro Alves  <palves@redhat.com>
1204
1205         * maint-test-settings.c: Fix file's intro comment.  Replace all
1206         references to "test-options" with references to "test-settings",
1207         in comments.
1208
1209 2019-07-03  Pedro Alves  <palves@redhat.com>
1210
1211         * maint-test-settings.c (maintenance_test_settings_xxx)
1212         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1213         New.
1214         (maintenance_test_settings_enums): Use them.
1215         (maintenance_test_settings_enum): Default to
1216         maintenance_test_settings_xxx.
1217         (_initialize_maint_test_settings): Initialize
1218         MAINTENANCE_TEST_SETTINGS_FILENAME.
1219
1220 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1221
1222         * breakpoint.h (remove_breakpoints_inf): Change return type to
1223         void, move function documentation here.
1224         * breakpoint.c (remove_breakpoints_inf): Change return type to
1225         void, move function documentation to header.
1226
1227 2019-07-02  Pedro Alves  <palves@redhat.com>
1228
1229         * NEWS (Completion improvements): Mention "info threads".
1230         * thread.c (struct info_threads_opts, info_threads_option_defs)
1231         (make_info_threads_options_def_group): New.
1232         (info_threads_command): Use gdb::option::process_options.
1233         (info_threads_command_completer): New.
1234         (_initialize_thread): Use gdb::option::build_help to build the
1235         help text for "info threads".
1236
1237 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1238
1239         * defs.h (generic_load): Move from here...
1240         * symfile.h (generic_load): ... to here.  Rename name parameter
1241         to args.
1242         * symfile.c (generic_load): Add comment.
1243
1244 2019-07-01  Tom Tromey  <tromey@adacore.com>
1245
1246         * dwarf2read.c
1247         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1248         declaration of without_params.  Fix formatting.
1249
1250 2019-07-01  Tom Tromey  <tromey@adacore.com>
1251
1252         * ada-exp.y (find_primitive_type): Update.
1253         * ada-lang.h (ada_lookup_symbol): Update.
1254         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1255         parameter.
1256         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1257
1258 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1259
1260         PR breakpoints/24541
1261         * gdbarch.c: Regenerate.
1262         * gdbarch.h: Regenerate.
1263         * gdbarch.sh: Add 'stap_adjust_register'.
1264         * i386-tdep.c: Include '<unordered_set>'.
1265         (i386_stap_adjust_register): New function.
1266         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1267         * stap-probe.c (stap_parse_register_operand): Call
1268         'gdbarch_stap_adjust_register'.
1269
1270 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1271
1272         PR python/24742
1273         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1274         * python/python.c (do_start_initialization): Use 'xmalloc'
1275         instead of 'PyMem_Malloc'.
1276
1277 2019-06-28  Tom Tromey  <tromey@adacore.com>
1278
1279         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1280         for Ada.
1281
1282 2019-06-27  Tom Tromey  <tromey@adacore.com>
1283
1284         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1285         objfile_key.
1286         (arm_find_mapping_symbol, arm_record_special_symbol)
1287         (_initialize_arm_tdep): Update.
1288         (arm_objfile_data_free): Remove.
1289
1290 2019-06-27  Tom Tromey  <tromey@adacore.com>
1291
1292         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1293         to cp_print_static_field.
1294
1295 2019-06-26  Tom Tromey  <tromey@adacore.com>
1296
1297         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1298         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1299         declare.
1300
1301 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1302
1303         * features/aarch64-core.c (create_feature_aarch64_core):
1304         Regenerate.
1305         * features/aarch64-core.xml: Add cpsr flags.
1306
1307 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1310         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1311
1312 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1313
1314         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1315         field.
1316         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1317         use.
1318         (arm_record_special_symbol): Don't insert new symbol in sorted
1319         position, push it at the end.
1320
1321 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1322
1323         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1324         (arm_mapping_symbol_s): Remove.
1325         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1326         (arm_mapping_symbol_vec): New typedef.
1327         (struct arm_per_objfile): Add constructor.
1328         <section_maps>: Change type to
1329         std::unique_ptr<arm_mapping_symbol_vec[]>.
1330         (arm_compare_mapping_symbols): Remove.
1331         (arm_find_mapping_symbol): Adjust to section_maps type change.
1332         (arm_objfile_data_free): Call delete on arm_per_objfile.
1333         (arm_record_special_symbol): Adjust to section_maps type change.
1334         Allocate arm_per_objfile with new.
1335
1336 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1337
1338         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1339         with the command prefix.
1340
1341 2019-06-25  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1344         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1345
1346 2019-06-25  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1349         type.
1350         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1351         protected.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-winsource.c
1356         (tui_source_window_base::set_is_exec_point_at): Add check against
1357         LOA_ADDRESS.
1358
1359 2019-06-25  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-source.c (tui_set_source_content): Don't check before
1362         xfree.
1363         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1364
1365 2019-06-25  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-winsource.h (tui_update_source_window_as_is)
1368         (tui_alloc_source_buffer, tui_line_is_displayed)
1369         (tui_addr_is_displayed): Change type of win_info.
1370         * tui/tui-winsource.c (tui_update_source_window_as_is)
1371         (tui_clear_source_content, tui_show_source_line)
1372         (tui_show_source_content, tui_source_window_base::refill)
1373         (tui_source_window_base::set_is_exec_point_at)
1374         (tui_source_window_base::set_is_exec_point_at)
1375         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1376         (tui_alloc_source_buffer, tui_line_is_displayed)
1377         (tui_addr_is_displayed): Change type of win_info.  Update.
1378         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1379         (tui_source_window_base::do_make_visible_with_new_height):
1380         Update.
1381         * tui/tui-source.c (tui_set_source_content)
1382         (tui_set_source_content_nil)
1383         (tui_source_window::do_scroll_vertical): Update.
1384         * tui/tui-layout.c (show_layout): Update.
1385         * tui/tui-disasm.c (tui_set_disassem_content)
1386         (tui_disasm_window::do_scroll_vertical): Update.
1387         * tui/tui-data.h (tui_win_content): Remove.
1388         (struct tui_gen_win_info) <content, content_size>: Remove.
1389         (struct tui_source_element): Add initializers and destructor.
1390         (union tui_which_element, struct tui_win_element): Remove.
1391         (struct tui_source_window_base) <content>: New field.
1392         (struct tui_data_window): Remove destructor.
1393         (tui_alloc_content, tui_free_win_content)
1394         (tui_free_all_source_wins_content): Don't declare.
1395         * tui/tui-data.c (tui_initialize_static_data): Update.
1396         (init_content_element, tui_alloc_content): Remove.
1397         (~tui_gen_win_info): Update.
1398         (~tui_data_window, tui_free_all_source_wins_content)
1399         (tui_free_win_content, free_content, free_content_elements):
1400         Remove.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-winsource.h (tui_clear_source_content)
1405         (tui_erase_source_content, tui_show_source_content): Change type
1406         of win_info.
1407         * tui/tui-winsource.c (tui_clear_source_content)
1408         (tui_erase_source_content, tui_show_source_content): Change type
1409         of win_info.
1410         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1411         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1412         win_info.
1413         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1414         win_info.
1415         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1416
1417 2019-06-25  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-winsource.c (tui_clear_source_content)
1420         (tui_source_window_base::set_is_exec_point_at): Update.
1421         * tui/tui-source.c (tui_set_source_content_nil): Update.
1422         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1423         a bool.
1424         * tui/tui-data.c (init_content_element): Update.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1429         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1430         * tui/tui-layout.c (init_and_make_win): Update.
1431         * tui/tui.h (enum tui_win_type): Update.
1432         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1433         tui_win_is_auxillary.
1434         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1435         tui_win_is_auxillary.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1440         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1441         (tui_delete_data_content_windows, tui_display_all_data)
1442         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1443         Update.
1444         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1445         * tui/tui-regs.c (tui_last_regs_line_no)
1446         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1447         (tui_show_registers): Update.
1448         (tui_show_register_group): Return void.  Update.
1449         (tui_display_registers_from, tui_display_reg_element_at_line)
1450         (tui_display_registers_from_line, tui_check_register_values):
1451         Update.
1452         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1453         member.
1454         (struct tui_data_window) <regs_content>: Now a std::vector.
1455         <regs_content_count>: Remove.
1456         (tui_add_content_elements, tui_free_data_content): Don't declare.
1457         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1458         (init_content_element): Remove DATA_WIN case.  Add assert.
1459         (tui_add_content_elements): Remove.
1460         (tui_data_window): Update.
1461         (tui_free_data_content): Remove.
1462         (free_content_elements): Remove DATA_WIN case.
1463
1464 2019-06-25  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-data.c (tui_data_item_window): Update.
1467         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1468         * tui/tui-windata.c (tui_display_all_data)
1469         (tui_display_data_from_line): Update.
1470         (tui_check_data_values): Remove.
1471         * tui/tui-regs.c (tui_show_register_group)
1472         (tui_display_reg_element_at_line): Update.
1473         * tui/tui-hooks.c (tui_register_changed)
1474         (tui_refresh_frame_and_register_information): Call
1475         tui_check_register_values.
1476         * tui/tui-data.h (struct tui_data_window) <data_content,
1477         data_content_count, data_type>: Remove.
1478         (enum tui_data_type): Remove.
1479
1480         * tui/tui-data.c (tui_data_window::clear_detail)
1481         (~tui_data_window): Update.
1482
1483 2019-06-25  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1486         declare.
1487         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1488         Rename from tui_first_data_item_displayed.  Update.
1489         (tui_data_window::refresh_all)
1490         (tui_data_window::do_scroll_vertical): Update.
1491         * tui/tui-data.h (struct tui_data_window)
1492         <first_data_item_displayed>: Declare new method.
1493
1494 2019-06-25  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1497         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1498         contents...
1499         (tui_initialize_static_data): ...here.
1500
1501 2019-06-25  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1504         (tui_display_registers_from, tui_check_register_values): Update.
1505         (tui_display_register): Remove win_info parameter; update.
1506         (tui_get_register): Change type of parameters.
1507         * tui/tui-data.h (struct tui_data_element): Remove.
1508         (union tui_which_element) <data>: Remove.
1509         <data_window>: Change type.
1510         (struct tui_data_item_window): New.
1511         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1512         case.  Add assert.
1513         (~tui_data_item_window): New destructor.
1514         (free_content_elements): Remove DATA_ITEM_WIN case.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1519         Remove.
1520
1521 2019-06-25  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-data.h (struct tui_command_element): Remove.
1524         (union tui_which_element) <command>: Remove.
1525         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1526         assert.
1527         (free_content_elements): Remove CMD_WIN case.
1528
1529 2019-06-25  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-layout.c (tui_set_layout): Update.
1532         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1533         * tui/tui-data.c (layout_def): Update.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1538         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1539         (tui_source_window_base::set_new_height): Update.
1540         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1541         Update.
1542         (tui_set_locator_fullname, tui_set_locator_info)
1543         (tui_show_frame_info): Update.
1544         * tui/tui-source.c (tui_set_source_content)
1545         (tui_source_is_displayed): Update.
1546         * tui/tui-layout.c (show_source_disasm_command, show_data)
1547         (show_source_or_disasm_and_command): Update.
1548         * tui/tui-disasm.c (tui_set_disassem_content)
1549         (tui_get_begin_asm_address): Update.
1550         * tui/tui-data.h (struct tui_locator_element): Remove.
1551         (union tui_which_element) <locator>: Remove.
1552         (struct tui_locator_window): New.
1553         (tui_locator_win_info_ptr): Change return type.
1554         * tui/tui-data.c (_locator): Change type.
1555         (tui_locator_win_info_ptr): Change return type.
1556         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1557         (tui_alloc_content): Add assert.
1558
1559 2019-06-25  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-winsource.c
1562         (tui_exec_info_window::maybe_allocate_content): New method.
1563         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1564         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1565         (make_source_or_disasm_window): Add cast.
1566         * tui/tui-data.h (union tui_which_element) <simple_string>:
1567         Remove.
1568         (struct tui_source_info): New.
1569         (struct tui_source_window_base) <execution_info>: Change type.
1570         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1571         case, and add assert.
1572         (tui_alloc_content): Add assert.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1577         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1578         * tui/tui-data.c (tui_alloc_win_info): Remove.
1579
1580 2019-06-25  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1583         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1584         can_highlight.
1585
1586 2019-06-25  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1589         make_visible_with_new_height method.
1590         (tui_win_info::make_visible_with_new_height): New method.
1591         (tui_source_window_base::do_make_visible_with_new_height)
1592         (tui_data_window::do_make_visible_with_new_height)
1593         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1594         (make_visible_with_new_height): Remove.
1595         (tui_resize_all, tui_adjust_win_heights): Use
1596         make_visible_with_new_height method.
1597         * tui/tui-data.h (struct tui_win_info)
1598         <do_make_visible_with_new_height, make_visible_with_new_height>:
1599         New methods.
1600         (struct tui_source_window_base, struct tui_data_window)
1601         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1602         methods.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1607         method.
1608         (update_tab_width): Call update_tab_width method.
1609         * tui/tui-data.h (struct tui_win_info)
1610         (struct tui_source_window_base) <update_tab_width>: New methods.
1611
1612 2019-06-25  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1615         parameter.
1616         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1617         parameter.
1618         (tui_gen_win_info::make_visible): Update.
1619         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1620         parameter.
1621         * tui/tui-data.h (enum tui_box): New enum.
1622         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1627         init_and_make_win for EXEC_INFO_WIN.
1628         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1629         longer inline.
1630         (struct tui_win_info) <~tui_win_info>: Inline.
1631         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1632         Don't declare.
1633         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1634         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1635         Remove.
1636         (tui_initialize_static_data): Update.
1637         (~tui_gen_win_info): Handle more cleanup here.
1638         (~tui_source_window_base): Delete "execution_info".
1639         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1640
1641 2019-06-25  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-layout.c (make_command_window): Don't set
1644         can_highlight.
1645         (show_source_disasm_command): Call the reset method.
1646         (show_data): Don't set can_highlight.  Call the reset method.
1647         (tui_gen_win_info::reset): Rename from init_gen_win_info
1648         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1649         (show_source_or_disasm_and_command): Call the reset method.
1650         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1651         (struct tui_cmd_window): Set can_highlight.
1652
1653 2019-06-25  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1656         from make_visible.
1657         (tui_make_visible, tui_make_invisible): Rewrite.
1658         (tui_win_info::make_visible): Remove.
1659         (tui_source_window_base::make_visible): Update.
1660         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1661         method.  Moved from...
1662         (struct tui_win_info) <make_visible>: ...here.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-winsource.c
1667         (tui_source_window_base::do_scroll_horizontal): Remove direction
1668         parameter.
1669         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1670         direction parameter.
1671         * tui/tui-win.c (tui_win_info::forward_scroll)
1672         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1673         (tui_win_info::right_scroll): Update.
1674         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1675         direction parameter.
1676         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1677         direction parameter.
1678         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1679         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1680         Remove direction parameter.
1681         (struct tui_source_window_base, struct tui_source_window)
1682         (struct tui_disasm_window, struct tui_data_window)
1683         (struct tui_cmd_window): Update.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-winsource.h (tui_set_exec_info_content)
1688         (tui_show_exec_info_content, tui_erase_exec_info_content)
1689         (tui_clear_exec_info_content, tui_update_exec_info): Change
1690         argument to tui_source_window_base.
1691         * tui/tui-winsource.c (tui_set_exec_info_content)
1692         (tui_show_exec_info_content, tui_erase_exec_info_content)
1693         (tui_clear_exec_info_content, tui_update_exec_info): Change
1694         argument to tui_source_window_base.
1695
1696 2019-06-25  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1699         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1700
1701 2019-06-25  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1704         check.
1705
1706 2019-06-25  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1709         type to void.
1710         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1711         type to void.
1712         * tui/tui-source.c (tui_set_source_content): Update.
1713         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-win.c (window_name_completer, tui_set_focus)
1718         (tui_all_windows_info): Use name method.
1719         * tui/tui-data.h (struct tui_gen_win_info)
1720         (struct tui_source_window, struct tui_disasm_window)
1721         (struct tui_data_window, struct tui_cmd_window) <name>: New
1722         method.
1723         (tui_win_name): Don't declare.
1724         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1725         (tui_win_name): Remove.
1726
1727 2019-06-25  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-winsource.h (tui_update_source_window)
1730         (tui_update_source_window_as_is): Change parameter type.
1731         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1732         to be a tui_source_window_base.
1733         (tui_update_source_window_as_is): Likewise.
1734         * tui/tui-win.c (make_visible_with_new_height): Update.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-winsource.c (tui_erase_source_content)
1739         (tui_show_source_content, tui_show_exec_info_content)
1740         (tui_erase_exec_info_content): Use refresh_window method.
1741         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1742         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1743         from tui_refresh_win.
1744         (tui_data_window::refresh_window): New method.
1745         (tui_win_info::refresh, tui_source_window_base::refresh)
1746         (tui_refresh_all): Use refresh_window method.
1747         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1748         method.
1749         * tui/tui-regs.c (tui_display_register): Call refresh_window
1750         method.
1751         * tui/tui-layout.c (show_source_disasm_command)
1752         (show_source_or_disasm_and_command): Call refresh_window method.
1753         * tui/tui-data.h (struct tui_gen_win_info)
1754         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1755         New method.
1756
1757 2019-06-25  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui.c (tui_rl_other_window, tui_enable)
1760         (tui_is_window_visible, tui_get_command_dimension): Update.
1761         * tui/tui-winsource.c (tui_update_source_window_as_is)
1762         (tui_clear_source_content, tui_erase_source_content)
1763         (tui_show_source_line, tui_source_window_base::refill)
1764         (tui_source_window_base::do_scroll_horizontal)
1765         (tui_source_window_base::set_is_exec_point_at)
1766         (tui_update_breakpoint_info, tui_set_exec_info_content)
1767         (tui_alloc_source_buffer, tui_line_is_displayed)
1768         (tui_addr_is_displayed): Update.
1769         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1770         (tui_check_and_display_highlight_if_needed)
1771         (tui_win_info::make_visible, tui_win_info::refresh)
1772         (tui_refresh_all): Update.
1773         * tui/tui-windata.c (tui_first_data_item_displayed)
1774         (tui_delete_data_content_windows, tui_erase_data_content)
1775         (tui_display_all_data, tui_data_window::refresh_all)
1776         (tui_check_data_values): Update.
1777         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1778         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1779         (tui_win_info::backward_scroll, tui_refresh_all_win)
1780         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1781         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1782         (tui_source_window_base::set_new_height)
1783         (tui_data_window::set_new_height)
1784         (make_invisible_and_set_new_height)
1785         (make_visible_with_new_height, new_height_ok)
1786         (parse_scrolling_args): Update.
1787         * tui/tui-stack.c (tui_show_frame_info): Update.
1788         * tui/tui-source.c (tui_set_source_content)
1789         (tui_set_source_content_nil, tui_source_is_displayed)
1790         (tui_source_window::do_scroll_vertical): Update.
1791         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1792         (tui_display_registers_from, tui_display_reg_element_at_line)
1793         (tui_check_register_values, tui_reg_command): Update.
1794         * tui/tui-layout.c (tui_default_win_height)
1795         (show_source_disasm_command, show_data, init_and_make_win)
1796         (show_source_or_disasm_and_command): Update.
1797         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1798         (tui_redisplay_readline, tui_mld_flush)
1799         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1800         (tui_getc): Update.
1801         * tui/tui-disasm.c (tui_set_disassem_content)
1802         (tui_disasm_window::do_scroll_vertical): Update.
1803         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1804         Now virtual.
1805         (struct tui_win_info): Derive from tui_gen_win_info.
1806         <~tui_win_info>: Mark as override.
1807         <generic>: Remove member.
1808         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1809         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1810         (~tui_data_window, ~tui_win_info)
1811         (tui_free_all_source_wins_content): Update.
1812         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-layout.c (init_and_make_win): Use new.
1817         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1818         destructor, initializers.
1819         (tui_alloc_generic_win_info): Don't declare.
1820         * tui/tui-data.c (_locator): Add argument to constructor.
1821         (source_win, disasm_win): New globals.
1822         (exec_info): Remove.
1823         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1824         Update.
1825         (tui_alloc_generic_win_info): Remove.
1826         (init_content_element): Use new.
1827         (tui_win_info::tui_win_info): Update.
1828         (free_content_elements) <case DATA_WIN>: Use delete.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1833         * tui/tui-windata.c (tui_first_data_item_displayed)
1834         (tui_delete_data_content_windows): Update.
1835         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1836         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1837         (tui_display_registers_from, tui_check_register_values): Update.
1838         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1839         pointer.
1840         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1841         window.
1842         (tui_free_data_content): Update.
1843         (free_content_elements) <case DATA_WIN>: Free the window.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1848         Update.
1849         * tui/tui-layout.c (make_command_window)
1850         (show_source_disasm_command, show_data, init_and_make_win)
1851         (show_source_or_disasm_and_command): Update.
1852         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1853         method.
1854         <can_highight, is_highlighted>: Now bool.
1855         (tui_set_win_highlight): Don't declare.
1856         * tui/tui-data.c (tui_set_win_highlight): Remove.
1857
1858 2019-06-25  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-wingeneral.c (make_visible): Remove check of window
1861         type.
1862
1863 2019-06-25  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-win.c (tui_win_info::max_height)
1866         (tui_cmd_window::max_height): New methods.
1867         (new_height_ok): Call max_height.
1868         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1869         <max_height>: New method.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-win.c (tui_source_window_base::set_new_height)
1874         (tui_data_window::set_new_height): New methods.
1875         (make_invisible_and_set_new_height): Call set_new_height method.
1876         * tui/tui-data.h (struct tui_win_info)
1877         (struct tui_source_window_base, struct tui_data_window)
1878         <set_new_height>: New method.
1879
1880 2019-06-25  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1883         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1884         tui_refresh_data_win.
1885         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1886         method.
1887         (tui_refresh_all_win): Call the refresh_all method.
1888         (tui_set_focus): Likewise.
1889         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1890         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1891         Likewise.
1892
1893 2019-06-25  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-winsource.h (tui_refill_source_window)
1896         (tui_set_is_exec_point_at): Don't declare.
1897         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1898         (tui_source_window_base::refill): Rename from
1899         tui_refill_source_window.
1900         (tui_source_window_base::do_scroll_horizontal): Update.
1901         (tui_source_window_base::set_is_exec_point_at): Rename from
1902         tui_set_is_exec_point_at.
1903         (tui_update_all_breakpoint_info): Update.
1904         * tui/tui-stack.c (tui_show_frame_info): Update.
1905         * tui/tui-layout.c (show_data): Add cast.
1906         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1907         * tui/tui-data.h (struct tui_source_window_base) <refill,
1908         set_is_exec_point_at>: New methods.
1909         (tui_source_windows, tui_add_to_source_windows): Update types.
1910         (tui_add_to_source_windows): Remove redundant declaration.
1911         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1912         (tui_source_windows): Change return type.
1913         (tui_clear_source_windows_detail): Update.
1914         (tui_add_to_source_windows): Change type of parameter.
1915         (tui_free_all_source_wins_content): Update.
1916
1917 2019-06-25  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-wingeneral.c (tui_win_info::refresh)
1920         (tui_source_window_base::refresh): New methods.
1921         (tui_refresh_all): Call the refresh method.
1922         * tui/tui-data.h (struct tui_win_info)
1923         (struct tui_source_window_base) <refresh>: New method.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui.h (tui_is_window_visible): Return bool.
1928         * tui/tui.c (tui_is_window_visible): Return bool.
1929         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1930         (tui_make_visible, tui_make_invisible)
1931         (tui_win_info::make_visible)
1932         (tui_source_window_base::make_visible, make_all_visible)
1933         (tui_make_all_visible, tui_make_all_invisible): Update.
1934         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1935         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1936         bool.
1937         (struct tui_win_info, struct tui_source_window_base)
1938         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1939         * tui/tui-data.c (tui_init_generic_part): Update.
1940
1941 2019-06-25  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1944         (tui_source_window_base::make_visible): New methods.
1945         (make_all_visible): Make method call.
1946         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1947         (struct tui_source_window_base, struct tui_cmd_window): Override
1948         make_visible.
1949         (tui_win_is_source_type): Don't declare.
1950         * tui/tui-data.c (tui_win_is_source_type): Remove.
1951
1952 2019-06-25  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1955         NULL check.
1956
1957 2019-06-25  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1960         Inline constructor.  Add initializers for members.
1961         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1962         constructors; now inline in class.
1963
1964 2019-06-25  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-regs.c (tui_show_registers): Update.
1967         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1968         bool.
1969         * tui/tui-data.c (tui_data_window::clear_detail)
1970         (tui_data_window): Update.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-windata.c (tui_display_all_data)
1975         (tui_display_data_from_line, tui_display_data_from)
1976         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1977         Update.
1978         * tui/tui-regs.c (tui_last_regs_line_no)
1979         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1980         (tui_show_registers, tui_show_register_group)
1981         (tui_display_registers_from, tui_display_reg_element_at_line)
1982         (tui_display_registers_from_line, tui_check_register_values)
1983         (tui_reg_next, tui_reg_prev): Update.
1984         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1985         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1986         tui_data_window.
1987         (struct tui_win_info) <detail>: Remove.  Add new fields from
1988         tui_data_info.
1989         (TUI_DATA_WIN): Add cast.
1990         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1991         (~tui_data_window): Simplify.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-layout.c (show_source_disasm_command)
1996         (show_source_or_disasm_and_command): Update.
1997         * tui/tui-io.c (update_cmdwin_start_line)
1998         (tui_redisplay_readline): Update.
1999         * tui/tui-data.h (struct tui_command_info): Remove.
2000         (struct tui_win_info) <detail>: Remove command_info member.
2001         (struct tui_data_window) <start_line>: New member, from
2002         tui_command_info.
2003         (TUI_CMD_WIN): Add casts.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-winsource.c (tui_update_source_window)
2008         (tui_refill_source_window)
2009         (tui_source_window_base::do_scroll_horizontal)
2010         (tui_update_breakpoint_info, tui_set_exec_info_content)
2011         (tui_show_exec_info_content, tui_erase_exec_info_content)
2012         (tui_clear_exec_info_content): Update.
2013         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2014         Update.
2015         * tui/tui-win.c (make_invisible_and_set_new_height)
2016         (make_visible_with_new_height): Update.
2017         * tui/tui-source.c (tui_set_source_content)
2018         (tui_show_symtab_source): Update.
2019         * tui/tui-layout.c (extract_display_start_addr)
2020         (show_source_disasm_command, show_data)
2021         (make_source_or_disasm_window)
2022         (show_source_or_disasm_and_command): Update.
2023         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2024         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2025         "gdbarch".
2026         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2027         to tui_source_window_base.
2028         (struct tui_win_info) <detail>: Remove source_info member.
2029         (struct tui_source_window_base) <has_locator>: Inline.
2030         Move contents from tui_source_info; rename has_locator member to
2031         m_has_locator.
2032         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2033         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2034         header file.
2035         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2036         Simplify.
2037         (tui_free_all_source_wins_content): Cast to
2038         tui_source_window_base.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-win.c (make_invisible_and_set_new_height)
2043         (make_visible_with_new_height): Call has_locator method.
2044         * tui/tui-layout.c (show_source_disasm_command, show_data)
2045         (show_source_or_disasm_and_command): Update for bool change.
2046         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2047         (tui_win_info) <has_locator>: New method.
2048         (struct tui_source_window_base) <has_locator>: New method.
2049         (tui_win_has_locator): Don't declare.
2050         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2051         from tui_win_has_locator.
2052         (tui_source_window_base): Use false, not FALSE.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2057         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2058         clear_detail method directly.
2059         (tui_clear_win_detail): Remove.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2064         "this", not TUI_DISASM_WIN.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2069         declare.
2070         * tui/tui-winsource.c
2071         (tui_source_window_base::do_scroll_horizontal): Rename from
2072         tui_horizontal_source_scroll.
2073         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2074         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2075         from tui_vertical_data_scroll.
2076         * tui/tui-win.h (tui_scroll): Don't declare.
2077         * tui/tui-win.c (tui_win_info::forward_scroll)
2078         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2079         (tui_win_info::right_scroll): Rename and update.
2080         (tui_scroll_forward_command, tui_scroll_backward_command)
2081         (tui_scroll_left_command, tui_scroll_right_command): Update.
2082         (tui_scroll): Remove.
2083         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2084         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2085         from tui_vertical_source_scroll.
2086         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2087         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2088         from tui_vertical_disassem_scroll.
2089         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2090         do_scroll_horizontal>: New methods.
2091         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2092         Likewise.
2093         (struct tui_source_window_base): Add do_scroll_horizontal.
2094         (struct tui_source_window, struct tui_disasm_window): Add
2095         do_scroll_vertical.
2096         (struct tui_data_window, struct tui_cmd_window): Add
2097         do_scroll_horizontal and do_scroll_vertical.
2098         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2099
2100 2019-06-25  Tom Tromey  <tom@tromey.com>
2101
2102         * tui/tui-data.h (struct tui_source_window_base): New struct.
2103         (struct tui_source_window): Derive from tui_source_window_base.
2104         (struct tui_disasm_window): New struct.
2105         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2106         from tui_source_window::clear_detail.
2107         (tui_source_window_base): Rename from tui_source_window.
2108         (~tui_source_window_base): Rename from ~tui_source_window.
2109         (tui_alloc_win_info): Create a tui_disasm_window.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-data.h (struct tui_source_window)
2114         (struct tui_data_window): Declare destructors.
2115         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2116         destructors.
2117         (tui_win_info): Simplify.
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-winsource.c (tui_display_main)
2122         (tui_update_source_windows_with_addr)
2123         (tui_update_all_breakpoint_info): Update.
2124         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2125         (new_height_ok, parse_scrolling_args): Update.
2126         * tui/tui-stack.c (tui_show_frame_info): Update.
2127         * tui/tui-data.h (struct tui_list): Remove.
2128         (tui_source_windows): Return a reference to a std::vector.
2129         * tui/tui-data.c (source_windows): Now a std::vector.
2130         (tui_source_windows): Change return type.
2131         (tui_clear_source_windows): Rewrite.
2132         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2133         (tui_free_all_source_wins_content): Rewrite.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2138         (struct tui_data_window, struct tui_cmd_window): Declare
2139         clear_detail method.
2140         * tui/tui-data.c (tui_source_window::clear_detail)
2141         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2142         methods.
2143         (tui_clear_win_detail): Simplify.
2144
2145 2019-06-25  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-layout.c (make_source_window, make_disasm_window)
2148         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2149         Return the new window.
2150         (show_source_disasm_command, show_data)
2151         (show_source_or_disasm_and_command): Update.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2156         parameter.  Return the new window.
2157         (show_source_disasm_command): Update and remove NULL check.
2158         (show_source_or_disasm_and_command): Update.
2159
2160 2019-06-25  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2163
2164 2019-06-25  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-data.h (struct tui_win_info): Make constructor
2167         protected.  Make destructor virtual.  Add initializers.
2168         (tui_source_window, tui_data_window, tui_cmd_window): New
2169         classes.
2170         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2171         constructor.  Add "type" parameter.
2172         (tui_source_window, tui_data_window, tui_cmd_window): New
2173         constructors.
2174         (tui_alloc_win_info): Instantiate the appropriate subclass.
2175
2176 2019-06-25  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-win.c (tui_resize_all): Use delete.
2179         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2180         destructor.
2181         (tui_free_window): Don't declare.
2182         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2183         Update.
2184
2185 2019-06-25  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-data.h (struct tui_win_info): Add constructor.
2188         * tui/tui-data.c (tui_alloc_win_info): Use new.
2189         (tui_free_window): Use delete.
2190
2191 2019-06-22  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2194         declare.
2195         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2196
2197 2019-06-22  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2200         declare.
2201         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2202
2203 2019-06-22  Tom de Vries  <tdevries@suse.de>
2204
2205         * dwarf2read.c (create_addrmap_from_aranges)
2206         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2207         instead of '%zu'.
2208
2209 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2210
2211         * dwarf2read.h (dwarf2_section_info_def): Remove.
2212         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2213         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2214         std::vector<dwarf2_section_info>.
2215         (struct dwo_file) <~dwo_file>: Remove.
2216         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2217         types field.
2218         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2219         (dwarf2_read_debug_names): Likewise.
2220         (create_debug_types_hash_table): Change parameter type to
2221         array_view, adjust code accordingly.
2222         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2223         (partial_die_info::fixup): Likewise.
2224         (determine_prefix): Likewise.
2225         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2226
2227 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2228
2229         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2230         gdb_bfd_ref_ptr.
2231         <~dwo_file>: Remove call to gdb_bfd_unref.
2232         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2233         gdb_bfd_ref_ptr::get.
2234
2235 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2236
2237         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2238         type to htab_up.
2239         * dwarf2read.c (struct dwo_file): Initialize fields.
2240         <~dwo_file>: New.
2241         (free_dwo_file): Remove, move content to ~dwo_file.
2242         (struct dwo_file_deleter): Remove.
2243         (dwo_file_up>: Remove custom deleter.
2244         (free_dwo_files): Remove.
2245         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2246         dwo_files.
2247         (process_skeletonless_type_units): Call unique_ptr::get.
2248         (allocate_dwo_file_hash_table): Add deleter to created hash
2249         table.  Change return type to htab_up.
2250         (lookup_dwo_file_slot): Don't memset dwo_file, call
2251         unique_ptr::get.
2252         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2253         (create_dwo_unit_in_dwp_v2): Likewise.
2254         (open_and_init_dwo_file): Likewise.
2255         (free_dwo_file_from_slot): Remove.
2256
2257 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2258
2259         * dwarf2read.h (struct dwarf2_section_info) <readin,
2260         is_virtual>: Change type to bool.
2261         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2262         true instead of 1.
2263
2264 2019-06-19  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-data.h (tui_init_content_element): Don't declare.
2267
2268 2019-06-19  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-data.h (tui_init_win_info): Don't declare.
2271
2272 2019-06-19  Tom de Vries  <tdevries@suse.de>
2273
2274         * dwarf2read.h (abstract_to_concrete): Change type to
2275         std::unordered_map<sect_offset, std::vector<sect_offset>,
2276         gdb::hash_enum<sect_offset>>.
2277
2278 2019-06-19  Tom Tromey  <tromey@adacore.com>
2279
2280         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2281         EVAL_AVOID_SIDE_EFFECTS specially.
2282
2283 2019-06-19  Tom Tromey  <tromey@adacore.com>
2284
2285         * source-cache.c (highlighter): New global.
2286         (source_cache::get_source_lines): Create a highlighter on demand.
2287
2288 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * defs.h (deprecated_interactive_hook): Delete declaration.
2291         * interps.c (clear_interpreter_hooks): Remove use of
2292         deprecated_interactive_hook.
2293         * top.c (deprecated_interactive_hook): Delete definition.
2294         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2295
2296 2019-06-18  Tom de Vries  <tdevries@suse.de>
2297
2298         PR gdb/24515
2299         * dwarf2read.h (abstract_to_concrete): Change type from
2300         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2301         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2302         * dwarf2read.c (read_variable): Update.
2303         (dwarf2_fetch_die_loc_sect_off): Update.
2304
2305 2019-06-17  Tom de Vries  <tdevries@suse.de>
2306
2307         PR gdb/24617
2308         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2309         accessing parent[parent_len - 1].
2310
2311 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2312
2313         PR gdb/24364
2314         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2315         call dtrace_process_dof with NULL dof.
2316
2317 2019-06-16  Tom de Vries  <tdevries@suse.de>
2318
2319         PR gdb/24445
2320         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2321
2322 2019-06-16  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2325         (make_all_visible): Use address of member.
2326
2327 2019-06-16  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2330         (tui_free_window, free_content, free_content_elements): Remove
2331         unnecessary cast.
2332         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2333         cast.
2334         * tui/tui-regs.c (tui_show_register_group)
2335         (tui_display_registers_from, tui_display_reg_element_at_line):
2336         Remove unnecessary cast.
2337
2338 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * linux-nat.c (normal_mask): Delete.
2341         (_initialize_linux_nat): Don't initialise normal_mask.
2342
2343 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2344
2345         PR gdb/24445
2346         * dwarf-index-write.h (write_psymtabs_to_index): Add
2347         dwz_basename parameter.
2348         * dwarf-index-write.c (write_gdbindex): Move file writing to
2349         write_gdbindex_1.  Change return type void.
2350         (assert_file_size): Move up, remove filename parameter.
2351         (write_gdbindex_1): New function.
2352         (write_debug_names): Change return type to void, call
2353         assert_file_size.
2354         (struct index_wip_file): New struct.
2355         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2356         file logic to index_wip_file.  Write index for dwz file if
2357         needed.
2358         (save_gdb_index_command): Pass basename of dwz file, if present.
2359         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2360         build-id of dwz file, if present.
2361         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2362         (dwarf2_get_dwz_file): Likewise.
2363         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2364         (dwarf2_get_dwz_file): Likewise.
2365
2366 2019-06-16  Tom Tromey  <tom@tromey.com>
2367
2368         * coffread.c (process_coff_symbol): Use xstrdup.
2369         * value.c (create_internalvar): Use xstrdup.
2370
2371 2019-06-16  Tom Tromey  <tom@tromey.com>
2372
2373         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2374         * breakpoint.c (stopin_command, stopat_command)
2375         (until_break_command, decode_location_default): Remove unnecessary
2376         cast.
2377         * utils.c (subset_compare): Remove unnecessary cast.
2378         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2379         cast.
2380         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2381         cast.
2382         * infcmd.c (path_command): Remove unnecessary cast.
2383         * coffread.c (decode_type): Remove unnecessary cast.
2384         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2385         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2386         * tui/tui-stack.c (tui_show_locator_content)
2387         (tui_show_frame_info): Remove unnecessary cast.
2388         * tui/tui-win.c (tui_scroll_forward_command)
2389         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2390         (parse_scrolling_args): Remove unnecessary cast.
2391         * tui/tui-data.c (init_win_info, tui_del_window)
2392         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2393         (free_content_elements): Remove unnecessary cast.
2394         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2395         unnecessary cast.
2396         * tui/tui-source.c (tui_set_source_content)
2397         (tui_vertical_source_scroll): Remove unnecessary cast.
2398         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2399         cast.
2400         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2401         * tui/tui-regs.c (tui_display_registers_from)
2402         (tui_display_register): Remove unnecessary cast.
2403         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2404         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2405         (make_visible): Remove unnecessary cast.
2406         * tui/tui-winsource.c (tui_erase_source_content)
2407         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2408         unnecessary cast.
2409         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2410         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2411         * stabsread.c (read_type, read_array_type, read_range_type):
2412         Remove unnecessary cast.
2413         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2414         (parse_symbol, parse_type, upgrade_type, parse_external)
2415         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2416         unnecessary cast.
2417         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2418
2419 2019-06-16  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-data.c (tui_alloc_generic_win_info)
2422         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2423         checks.
2424
2425 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2426             Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * f-typeprint.c (f_print_type): Don't return early for not
2429         associated or not allocated types.
2430         (f_type_print_varspec_suffix): Add print_rank parameter and print
2431         ranks of array types in case they dangling.
2432         (f_type_print_base): Add print_rank parameter.
2433
2434 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * NEWS: Mention new MI commands.
2437         * break-catch-throw.c (enum exception_event_kind): Move to
2438         breakpoint.h.
2439         (print_mention_exception_catchpoint): Output text as a single
2440         message.
2441         (catch_exception_command_1): Rename to...
2442         (catch_exception_event): ...this, make non-static, update header
2443         command, and change some parameter types.
2444         (catch_catch_command): Update for changes to
2445         catch_exception_command_1.
2446         (catch_throw_command): Likewise.
2447         (catch_rethrow_command): Likewise.
2448         * breakpoint.c (enum exception_event_kind): Delete.
2449         * breakpoint.h (enum exception_event_kind): Moved here from
2450         break-catch-throw.c.
2451         (catch_exception_event): Declare.
2452         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2453         (mi_cmd_catch_throw): New function.
2454         (mi_cmd_catch_rethrow): New function.
2455         (mi_cmd_catch_catch): New function.
2456         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2457         'catch-catch' entries.
2458         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2459         (mi_cmd_catch_rethrow): Declare.
2460         (mi_cmd_catch_catch): Declare.
2461
2462 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * annotate.c (annotate_source_line): Change return type to void,
2465         update implementation to match.
2466         * annotate.h (annotate_source_line): Change return type to void,
2467         update header comment.
2468         * stack.c (print_frame_info): Don't change what frame information
2469         is printed based on whether annotations are on or not.
2470
2471 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2472
2473         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2474         (annotate_source): Make static.
2475         (annotate_source_line): Moved from source.c and renamed from
2476         identify_source_line.  Update the return type.
2477         * annotate.h (annotate_source): Delete declaration.
2478         (annotate_source_line): Declaration moved from source.h, and
2479         renamed from identify_source_line.  Return type updated.
2480         * source.c (identify_source_line): Moved to annotate.c and renamed
2481         to annotate_source_line.
2482         (info_line_command): Remove check of annotation_level.
2483         * source.h (identify_source_line): Move declaration to annotate.h
2484         and rename to annotate_source_line.
2485         * stack.c: Add 'annotate.h' include.
2486         (print_frame_info): Remove check of annotation_level before
2487         calling annotate_source_line.
2488
2489 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2490
2491         * source-cache.c (source_cache::get_plain_source_lines): Use
2492         open_source_file_with_line_charpos instead of just
2493         open_source_file, remove call to find_source_lines.
2494         (source_cache::get_source_lines): Likewise.
2495         * source.c (find_source_lines): Make static.
2496         (get_filename_and_charpos): Renamed into...
2497         (open_source_file_with_line_charpos): ..this along with changes to
2498         return a scoped_fd, and some other minor clean ups.
2499         (identify_source_line): Use open_source_file_with_line_charpos.
2500         (search_command_helper): Use open_source_file_with_line_charpos
2501         instead of just open_source_file, remove call to
2502         find_source_lines.
2503         * source.h (open_source_file_with_line_charpos): Declare new
2504         function.
2505         (find_source_lines): Delete declaration.
2506
2507 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * source.c (get_filename_and_charpos): Remove fullname
2510         parameter.
2511         (identify_source_line): Update call to get_filename_and_charpos.
2512
2513 2019-06-14  Tom Tromey  <tromey@adacore.com>
2514
2515         PR gdb/24502:
2516         * ui-style.h (skip_ansi_escape): Update comment.
2517         * ui-file.h (class no_terminal_escape_file): New class.
2518         * ui-file.c (no_terminal_escape_file::write)
2519         (no_terminal_escape_file::puts): New methods.
2520         * cli/cli-logging.c (handle_redirections): Use
2521         no_terminal_escape_file.
2522
2523 2019-06-14  Tom Tromey  <tromey@adacore.com>
2524
2525         * NEWS: Move convenience variable news above Python news.
2526
2527 2019-06-14  Tom Tromey  <tom@tromey.com>
2528
2529         * gnulib: Move directory to top-level.
2530         * configure.ac: Don't configure gnulib.
2531         * configure: Rebuild.
2532         * common/common-defs.h: Use new path to gnulib.
2533         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2534         (GNULIB_H): Remove.
2535         (INCGNU): Look in new gnulib location.
2536         (HFILES_NO_SRCDIR): Remove gnulib files.
2537         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2538         (generated_files): Remove GNULIB_H.
2539         ($(LIBGNU), all-lib): Remove targets.
2540         (distclean): Don't mention GNULIB_BUILDDIR.
2541         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2542
2543 2019-06-14  Tom Tromey  <tromey@adacore.com>
2544
2545         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2546         Warn if symbol file does not provide any symbols.
2547
2548 2019-06-14  Tom Tromey  <tromey@adacore.com>
2549
2550         * source.c (find_and_open_source): Respect basenames_may_differ.
2551
2552 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * annotate.c (annotate_breakpoints_invalid): Make use of
2555         scoped_restore_terminal_state.
2556         (annotate_frames_invalid): Likewise.
2557
2558 2019-06-14  Tom Tromey  <tromey@adacore.com>
2559
2560         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2561         allow assignment to an internalvar.
2562
2563 2019-06-14  Tom Tromey  <tromey@adacore.com>
2564
2565         * ada-lex.l: Allow "_" in attribute names.
2566
2567 2019-06-14  Tom Tromey  <tromey@adacore.com>
2568
2569         PR gdb/24653:
2570         * regcache.c (registers_changed): Don't call alloca.
2571         * top.c (execute_command): Don't call alloca.
2572
2573 2019-06-13  Pedro Alves  <palves@redhat.com>
2574
2575         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2576         'expression'.  When parsing an expression, error out if there's
2577         junk after "unlimited".
2578         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2579         (do_set_command): Adjust calls to is_unlimited_literal.
2580
2581 2019-06-13  Pedro Alves  <palves@redhat.com>
2582
2583         * compile/compile.c (make_compile_options_def_group): Add braces
2584         around array_view initializer.
2585         * thread.c (make_thread_apply_all_options_def_group)
2586         (make_thread_apply_all_options_def_group): Likewise.
2587
2588 2019-06-13  Pedro Alves  <palves@redhat.com>
2589
2590         * NEWS (New commands): Mention "maint test-options
2591         require-delimiter", "maint test-options unknown-is-error", "maint
2592         test-options unknown-is-operand" and "maint show
2593         test-options-completion-result".
2594         (New command options, command completion): New section.
2595         (Completion improvements): New section.
2596         Mention that you can abbreviate "unlimited".
2597
2598 2019-06-13  Pedro Alves  <palves@redhat.com>
2599
2600         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2601         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2602         * unittests/cli-utils-selftests.c (test_parse_flags)
2603         (test_parse_flags_qcs): Delete.
2604         (test_cli_utils): Don't call deleted functions.
2605
2606 2019-06-13  Pedro Alves  <palves@redhat.com>
2607
2608         * thread.c: Include "cli/cli-option.h".
2609         (tp_array_compar_ascending): Global.
2610         (tp_array_compar): Delete function.
2611         (tp_array_compar_ascending, tp_array_compar_descending): New
2612         functions.
2613         (ascending_option_def, qcs_flag_option_def)
2614         (thr_qcs_flags_option_defs)
2615         (make_thread_apply_all_options_def_group)
2616         (make_thread_apply_options_def_group): New.
2617         (thread_apply_all_command): Use gdb::option::process_options.
2618         (thread_apply_command_completer)
2619         (thread_apply_all_command_completer): New.
2620         (thread_apply_command): Use gdb::option::process_options.
2621         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2622         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2623         to generate help text of "thread apply".  Adjust "taas"'s help.
2624         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2625         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2626
2627 2019-06-13  Pedro Alves  <palves@redhat.com>
2628
2629         * thread.c (thread_apply_command): Check for invalid TID with
2630         isdigit instead of !isalpha.
2631
2632 2019-06-13  Pedro Alves  <palves@redhat.com>
2633
2634         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2635         (validate_flags_qcs): New.
2636         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2637         (validate_flags_qcs): Declare.
2638         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2639         (make_frame_apply_options_def_group): New.
2640         (frame_apply_command_count): Process options with
2641         gdb::option::process_options.
2642         (frame_apply_completer): New.
2643         (frame_apply_level_completer, frame_apply_all_completer)
2644         (frame_apply_completer): New.
2645         (_initialize_stack): Update help of "frame apply", "frame apply
2646         level", "frame apply all" and "faas" to mention supported options
2647         and install command completers.
2648         * stack.h (frame_apply_all_completer): Declare.
2649         * thread.c: Include "stack.h".
2650         (tfaas_command): Add "--".
2651         (_initialize_thread): Update help "tfaas" to mention supported
2652         options and install command completer.
2653
2654 2019-06-13  Pedro Alves  <palves@redhat.com>
2655
2656         * completer.c (complete_nested_command_line): New.
2657         (gdb_completion_word_break_characters_throw): Add assertion.
2658         * completer.h (complete_nested_command_line): Declare.
2659
2660 2019-06-13  Pedro Alves  <palves@redhat.com>
2661
2662         * stack.c (parse_backtrace_qualifiers): New.
2663         (backtrace_command): Use it.
2664         (backtrace_command_completer): Complete on qualifiers.
2665
2666 2019-06-13  Pedro Alves  <palves@redhat.com>
2667
2668         * frame.c: Include "cli/cli-option.h.
2669         (user_set_backtrace_options): New.
2670         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2671         Delete.
2672         (get_prev_frame): Adjust.
2673         (boolean_option_def, uinteger_option_def)
2674         (set_backtrace_option_defs): New.
2675         (_initialize_frame): Adjust and use
2676         gdb::option::add_setshow_cmds_for_options to install "set
2677         backtrace past-main" and "set backtrace past-entry".
2678         * frame.h: Include "cli/cli-option.h".
2679         (struct frame_print_options): Forward declare.
2680         (print_frame_arguments_all, print_frame_arguments_scalars)
2681         (print_frame_arguments_none): Declare.
2682         (print_entry_values): Delete declaration.
2683         (struct frame_print_options, user_frame_print_options): New.
2684         (struct set_backtrace_options): New.
2685         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2686         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2687         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2688         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2689         (list_args_or_locals): Add frame_print_options parameter.
2690         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2691         * python/py-framefilter.c (enumerate_args): Pass down
2692         USER_FRAME_PRINT_OPTIONS.
2693         * stack.c: Include "cli/cli-option.h".
2694         (print_frame_arguments_all, print_frame_arguments_scalars)
2695         (print_frame_arguments_none): Declare.
2696         (print_raw_frame_arguments, print_entry_values): Delete.
2697         (user_frame_print_options): New.
2698         (boolean_option_def, enum_option_def, frame_print_option_defs):
2699         New.
2700         (struct backtrace_cmd_options): New.
2701         (bt_flag_option_def): New.
2702         (backtrace_command_option_defs): New.
2703         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2704         (print_frame_arg, read_frame_arg, print_frame_args)
2705         (print_frame_info, print_frame): Add frame_print_options parameter
2706         and use it.
2707         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2708         (backtrace_command_1): Add frame_print_options and
2709         backtrace_cmd_options parameters and use them.
2710         (make_backtrace_options_def_group): New.
2711         (backtrace_command): Process command options with
2712         gdb::option::process_options.
2713         (backtrace_command_completer): New.
2714         (_initialize_stack): Extend "backtrace"'s help to mention
2715         supported options.  Install completer for "backtrace".
2716         Install some settings commands with add_setshow_cmds_for_options.
2717
2718 2019-06-13  Pedro Alves  <palves@redhat.com>
2719
2720         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2721         and that "set/show print raw frame-arguments" are now deprecated.
2722
2723         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2724         command.
2725         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2726         * stack.c (_initialize_stack): Install "set/show print
2727         raw-frame-arguments", and deprecate "set/show print raw
2728         frame-arguments".
2729         * valprint.c (_initialize_valprint): Deprecate "set/show print
2730         raw".
2731
2732 2019-06-13  Pedro Alves  <palves@redhat.com>
2733
2734         * compile/compile.c (struct compile_options): New.
2735         (compile_flag_option_def, compile_command_option_defs)
2736         (make_compile_options_def_group): New.
2737         (compile_file_command): Handle options with
2738         gdb::option::process_options.
2739         (compile_file_command_completer): New function.
2740         (compile_code_command): Handle options with
2741         gdb::option::process_options.
2742         (compile_code_command_completer): New function.
2743         (_initialize_compiler): Install completers for "compile code" and
2744         "compile file".  Mention available options in "compile code" and
2745         "compile code"'s help.
2746         * completer.c (advance_to_completion_word): New, factored out from
2747         ...
2748         (advance_to_expression_complete_word_point): ... this.
2749         (advance_to_filename_complete_word_point): New.
2750         * completer.h (advance_to_filename_complete_word_point): New
2751         declaration.
2752
2753 2019-06-13  Pedro Alves  <palves@redhat.com>
2754
2755         * compile/compile.c: Include "cli/cli-option.h".
2756         (compile_print_value): Scope data pointer is now a
2757         value_print_options pointer; adjust.
2758         (compile_print_command): Process options.  Scope data pointer is
2759         now a value_print_options pointer; adjust.
2760         (_initialize_compile): Update "compile print"'s help to include
2761         supported options.  Install a completer for "compile print".
2762         * cp-valprint.c (show_vtblprint, show_objectprint)
2763         (show_static_field_print): Delete.
2764         (_initialize_cp_valprint): Don't install "set print
2765         static-members", "set print vtbl", "set print object" here.
2766         * printcmd.c: Include "cli/cli-option.h" and
2767         "common/gdb_optional.h".
2768         (print_command_parse_format): Rework to fill in a
2769         value_print_options instead of a format_data.
2770         (print_value): Change parameter type from format_data pointer to
2771         value_print_options reference.  Adjust.
2772         (print_command_1): Process options.  Adjust to pass down a
2773         value_print_options.
2774         (print_command_completer): New.
2775         (_initialize_printcmd): Install print_command_completer as
2776         handle_brkchars completer for the "print" command.  Update
2777         "print"'s help to include supported options.
2778         * valprint.c: Include "cli/cli-option.h".
2779         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2780         here from cp-valprint.c.
2781         (boolean_option_def, uinteger_option_def)
2782         (value_print_option_defs, make_value_print_options_def_group):
2783         New.  Use gdb::option::add_setshow_cmds_for_options to install
2784         "set print elements", "set print null-stop", "set print repeats",
2785         "set print pretty", "set print union", "set print array", "set
2786         print address", "set print symbol", "set print array-indexes".
2787         * valprint.h: Include <string> and "cli/cli-option.h".
2788         (make_value_print_options_def_group): Declare.
2789         (print_value): Change parameter type from format_data pointer to
2790         value_print_options reference.
2791         (print_command_completer): Declare.
2792
2793 2019-06-13  Pedro Alves  <palves@redhat.com>
2794
2795         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2796         (COMMON_SFILES): Add maint-test-settings.c.
2797         * cli/cli-decode.c (boolean_enums): New global, factored out from
2798         ...
2799         (add_setshow_boolean_cmd): ... here.
2800         * cli/cli-decode.h (boolean_enums): Declare.
2801         * cli/cli-option.c: New file.
2802         * cli/cli-option.h: New file.
2803         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2804         factored out from ...
2805         (parse_cli_boolean_value(const char *)): ... this.
2806         (is_unlimited_literal): Change parameter type to pointer to
2807         pointer.  Adjust and advance ARG pointer.
2808         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2809         (parse_cli_var_enum): New, factored out from ...
2810         (do_set_command): ... this.  Adjust.
2811         * cli/cli-setshow.h (parse_cli_boolean_value)
2812         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2813         (parse_cli_var_enum): Declare.
2814         * cli/cli-utils.c: Include "cli/cli-option.h".
2815         (get_ulongest): New.
2816         * cli/cli-utils.h (get_ulongest): Declare.
2817         (check_for_argument): New overloads.
2818         * maint-test-options.c: New file.
2819
2820 2019-06-13  Pedro Alves  <palves@redhat.com>
2821
2822         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2823         parse a range if "-" is at the end of the string.
2824
2825 2019-06-13  Pedro Alves  <palves@redhat.com>
2826
2827         * cli/cli-setshow.c (parse_auto_binary_operation)
2828         (parse_cli_boolean_value): Don't allow "o".
2829
2830 2019-06-13  Pedro Alves  <palves@redhat.com>
2831
2832         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2833         * NEWS: Mention maint test-settings KIND.
2834         * maint-test-settings.c: New file.
2835
2836 2019-06-13  Pedro Alves  <palves@redhat.com>
2837
2838         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2839         completer.
2840         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2841         "set" completers.
2842
2843 2019-06-13  Pedro Alves  <palves@redhat.com>
2844
2845         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2846         after item.
2847
2848 2019-06-13  Pedro Alves  <palves@redhat.com>
2849
2850         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2851
2852 2019-06-13  Pedro Alves <palves@redhat.com>
2853
2854         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2855         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2856         call.
2857         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2858         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2859         calls.
2860         (check_for_argument): Skip spaces after argument.
2861
2862 2019-06-13  Pedro Alves  <palves@redhat.com>
2863
2864         * thread.c (thread_apply_command): Adjust TID parsing.
2865         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2866         detected before end of string.
2867         (tid_is_in_list): Error out if LIST is invalid.
2868
2869 2019-06-13  Pedro Alves  <palves@redhat.com>
2870
2871         * completer.c (complete_line_internal_1): Rewind completion word
2872         point.
2873         (completion_tracker::advance_custom_word_point_by): Change
2874         parameter type to int.
2875         * completer.h (completion_tracker::advance_custom_word_point_by):
2876         Likewise.
2877
2878 2019-06-13  Pedro Alves  <palves@redhat.com>
2879
2880         * completer.c (advance_to_completion_word): Handle delimiters.
2881
2882 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2883
2884         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2885
2886 2019-06-11  Tom Tromey  <tom@tromey.com>
2887
2888         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2889         (xmalloc_failed): Move to alloc.c.
2890         * alloc.c: New file.
2891         * Makefile.in (COMMON_SFILES): Add alloc.c.
2892
2893 2019-06-11  Tom Tromey  <tom@tromey.com>
2894
2895         * nat/linux-waitpid.c: Don't include server.h.
2896         (linux_debug): Remove.
2897         (my_waitpid): Update.
2898
2899 2019-06-11  Tom Tromey  <tromey@adacore.com>
2900
2901         * infcall.c (_initialize_infcall): Remove trailing newline from
2902         help.
2903         * user-regs.c (_initialize_user_regs): Remove trailing newline
2904         from help.
2905         * typeprint.c (_initialize_typeprint): Remove trailing newline
2906         from help.
2907         * reverse.c (_initialize_reverse): Remove trailing newlines from
2908         help.
2909         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2910         from help.
2911         * language.c (add_set_language_command): Remove trailing newline
2912         from help.
2913         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2914         help.
2915         * disasm.c (_initialize_disasm): Remove trailing newline from
2916         help.
2917         * top.c (init_main): Remove trailing newline from help.
2918         * interps.c (_initialize_interpreter): Remove trailing newline
2919         from help.
2920         * btrace.c (_initialize_btrace): Remove trailing newlines from
2921         help.
2922         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2923         from help.
2924         * python/python.c (_initialize_python): Remove trailing newline
2925         from help.
2926         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2927         help.
2928         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2929         from help.  Reformat some text.
2930         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2931         from help.
2932         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2933         newline from help.
2934
2935 2019-06-11  Tom Tromey  <tromey@adacore.com>
2936
2937         * darwin-nat.c (darwin_decode_exception_message)
2938         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2939
2940 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2941
2942         * valops.c (value_slice): Check for not allocated or not
2943         associated values.
2944
2945 2019-06-10  Tom de Vries  <tdevries@suse.de>
2946
2947         PR gdb/24618
2948         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2949         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2950         invalid.
2951
2952 2019-06-10  Tom de Vries  <tdevries@suse.de>
2953
2954         PR gdb/24611
2955         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2956         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2957
2958 2019-06-10  Tom de Vries  <tdevries@suse.de>
2959
2960         PR symtab/24545
2961         * symtab.c (struct demangled_name_entry): Add language field.
2962         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2963         static minimal symbol".  Set and use language field.
2964
2965 2019-06-10  Tom Tromey  <tromey@adacore.com>
2966
2967         * ada-lang.c (_initialize_ada_language): Update help text.
2968
2969 2019-06-10  Tom Tromey  <tromey@adacore.com>
2970
2971         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2972         with a newline.
2973         * guile/guile.c (handle_boot_error): Don't end warning with a
2974         newline.
2975         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2976         warning with a newline.
2977         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2978         newline.
2979         (s12z_frame_cache): Likewise.
2980         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2981         a newline.
2982         * solib-svr4.c (disable_probes_interface): Don't end warning with
2983         a newline.
2984         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2985         newline.
2986         * python/python.c (do_finish_initialization): Don't end warning
2987         with a newline.
2988
2989 2019-06-10  Tom Tromey  <tom@tromey.com>
2990
2991         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2992         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2993         gdbpy_enter.
2994
2995 2019-06-10  Tom Tromey  <tromey@adacore.com>
2996
2997         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2998         data.
2999         (elf_new_init): Don't call stabsread_new_init.
3000         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3001         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3002         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3003
3004 2019-06-10  Tom de Vries  <tdevries@suse.de>
3005
3006         PR symtab/16264
3007         PR symtab/24517
3008         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3009
3010 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3011
3012         * source.c (find_and_open_source): Also rewrite relative file
3013         names.
3014
3015 2019-04-26  Amos Bird  <amosbird@gmail.com>
3016
3017         * annotate.c (annotate_thread_exited): Add "thread-exited"
3018         annotation.
3019
3020 2019-06-06  Tom Tromey  <tromey@adacore.com>
3021
3022         * maint.h (class scoped_command_stats): Use
3023         DISABLE_COPY_AND_ASSIGN.
3024         <print_time>: New method.
3025         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3026         print_time.
3027         (scoped_command_stats::print_time): New method.
3028
3029 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3032         instructions of lengths 6 or 8 bytes.
3033
3034 2019-06-04  Pedro Alves  <palves@redhat.com>
3035
3036         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3037
3038         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3039         * breakpoint.c (condition_completer): Likewise.
3040         * cli/cli-dump.c (scan_expression): Likewise.
3041         * common/filestuff.c (mkdir_recursive): Likewise.
3042         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3043         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3044         (gdb_abspath): Likewise.
3045         * compile/compile-cplus-types.c
3046         (compile_cplus_instance::decl_name): Likewise.
3047         * completer.c (complete_explicit_location):
3048         (signal_completer, reg_or_group_completer_1): Likewise.
3049         * cp-support.c (cp_remove_params_if_any): Likewise.
3050         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3051         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3052         * infcmd.c (strip_bg_char): Likewise.
3053         * linespec.c (copy_token_string): Likewise.
3054         * mi/mi-main.c (output_cores): Likewise.
3055         * psymtab.c (psymtab_search_name):
3056         * symfile.c (test_set_ext_lang_command): Likewise.
3057         * target.c (target_fileio_read_stralloc): Likewise.
3058         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3059         * value.c (complete_internalvar): Likewise.
3060
3061 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3062
3063         Add objfile property to gdb.Type.
3064         * NEWS: Mention Python API addition.
3065         * python/py-type.c (typy_get_objfile): New method.
3066
3067 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3068
3069         * NEWS: Mention the new set|show style [title|highlight].
3070         Mention changes to "show style", "help" and "apropos".
3071
3072 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3073
3074         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3075         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3076         instead of print_help_for_command.
3077         (print_doc_of_command): New function.
3078         (help_list): Add 'apropos -v word' suggestion.
3079         (print_help_for_command): Style the command name using title style.
3080         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3081         (_initialize_cli_cmds): Describe -v in apropos_command help.
3082
3083 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3084
3085         * cli/cli-style.h (cli_style_option): Add name in constructor,
3086         add m_name class member, add constructor with intensity,
3087         add name class function.
3088         (cli_style_option::add_setshow_commands): Remove name argument.
3089         (highlight_style, title_style): New styles.
3090         * cli/cli-style.c (do_show): New function that shows a style
3091         characteristic styling the style name with itself.
3092         (set_style_name): New function.
3093         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3094         Update all callers according to the changes in cli/cli-style.h.
3095         * utils.h (fputs_highlighted): New function.
3096         * utils.c (fputs_highlighted): Likewise.
3097
3098 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3099
3100         * NEWS: Mention new pipe command and new convenience variables.
3101
3102 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3103
3104         * cli/cli-cmds.c (pipe_command): New function.
3105         (_initialize_cli_cmds): Call add_com for pipe_command.
3106         Define | as an alias for pipe.
3107         (exit_status_set_internal_vars): New function.
3108         (shell_escape): Call exit_status_set_internal_vars.
3109         cli/cli-decode.c (find_command_name_length): Recognize | as
3110         a single character command.
3111
3112 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3113
3114         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3115         top.c (execute_command_to_ui_file): New function, mostly a copy
3116         of execute_command_to_string.
3117         (execute_command_to_string): Implement by calling
3118         execute_command_to_ui_file.
3119
3120 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3121
3122         * top.h (saved_command_line): Remove declaration.
3123         * top.c (previous_saved_command_line, previous_repeat_arguments):
3124         New variables.
3125         (saved_command_line): Make static, define together with other
3126         'repeat variables'.
3127         (dont_repeat): Clear repeat_arguments.
3128         (repeat_previous, get_saved_command_line, save_command_line):
3129         New functions.
3130         (gdb_init): Initialize saved_command_line
3131         and previous_saved_command_line.
3132         * main.c (captured_main_1): Remove saved_command_line initialization.
3133         * event-top.c (handle_line_of_input): Update to use
3134         the new 'repeat' related functions instead of direct access to
3135         saved_command_line.
3136         * command.h (repeat_previous, get_saved_command_line,
3137         save_command_line): New declarations.
3138         (dont_repeat): Add comment.
3139
3140 2019-05-30  Tom Tromey  <tromey@adacore.com>
3141
3142         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3143         Fix comment.
3144         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3145
3146 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3147
3148         PR cli/24587
3149         * completer.c (complete): Initialize variable word.
3150
3151 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3152
3153         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3154         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3155         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3156         'body' is NULL to the outter 'if', protecting the '!is_define'
3157         situation as well.
3158
3159 2019-05-29  Tom Tromey  <tromey@adacore.com>
3160
3161         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3162         (dwarf_unknown): New function.
3163         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3164         (dwarf_type_encoding_name): Use dwarf_unknown.
3165
3166 2019-05-29  Tom Tromey  <tromey@adacore.com>
3167
3168         PR c++/20020:
3169         * cp-valprint.c (cp_print_value_fields): Call
3170         cp_print_static_field inside "try".
3171
3172 2019-05-29  Tom Tromey  <tromey@adacore.com>
3173
3174         * inflow.c (struct terminal_info): Add default operator=.
3175         * configure: Rebuild.
3176         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3177         -Wdeprecated-copy-dtor, -Wredundant-move.
3178
3179 2019-05-29  Tom Tromey  <tromey@adacore.com>
3180
3181         * NEWS: Add entry.
3182         * infcmd.c (print_return_value_1): Handle finish_print
3183         option.
3184         (show_print_finish): New function.
3185         (_initialize_infcmd): Add "set/show print finish" commands.
3186         * valprint.c (user_print_options): Initialize new member.
3187         * valprint.h (struct value_print_options) <finish_print>: New
3188         member.
3189
3190 2019-05-28  Tom Tromey  <tromey@adacore.com>
3191
3192         * ada-lang.c (ada_remove_Xbn_suffix)
3193         (find_old_style_renaming_symbol)
3194         (parse_old_style_renaming): Remove.
3195         (ada_find_renaming_symbol): Don't call
3196         find_old_style_renaming_symbol.
3197         (ada_is_renaming_symbol): Rename from
3198         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3199         bool.  Now static.
3200         (ada_read_var_value): Update and simplify.
3201         * ada-exp.y (write_var_or_type): Remove old code.
3202
3203 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3204
3205         * event-top.c: Remove include comment.
3206         * inflow.c (class scoped_ignore_sigttou): Move from here...
3207         * inflow.h (class scoped_ignore_sigttou): ...to here.
3208         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3209         * top.c:  Remove include comment.
3210
3211 2019-05-27  Tom Tromey  <tom@tromey.com>
3212
3213         * NEWS: Fix typo.
3214
3215 2019-05-22  Tom Tromey  <tromey@adacore.com>
3216
3217         * target.c (target_follow_exec): Constify parameter.
3218         * target-delegates.c: Rebuild.
3219         * remote.c (remote_target::follow_exec): Constify parameter.
3220         * infrun.c (follow_exec): Constify parameter.
3221         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3222         (target_follow_exec): Likewise.
3223
3224 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3225
3226         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3227         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3228
3229 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3230
3231         * NEWS: Add debugredirect and testsuite sections.
3232
3233 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3234
3235         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3236         target descriptions using exclusively floating point register name
3237         aliases.
3238
3239 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         PR gdb/18644:
3242         * f-lang.c (build_fortran_types): Handle the case where
3243         gdbarch_floatformat_for_type returns a nullptr.
3244
3245 2019-05-21  Tom de Vries  <tdevries@suse.de>
3246
3247         PR cli/24587
3248         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3249
3250 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         PR gdb/18644:
3253         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3254         16-byte floats.
3255         * i386-tdep.c (i386_floatformat_for_type): Use
3256         floatformats_ia64_quad for the 16-byte floating point component
3257         within a fortran 32-byte complex number.
3258
3259 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3260
3261         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3262         delete default constructor.
3263         (find_partial_die): Update to return const struct.
3264         (partial_die_parent_scope): Move variable declaration into scope
3265         of its use and change its type to auto.
3266         (guess_partial_die_structure_name): Likewise.
3267         (partial_die_info::fixup): Likewise.
3268
3269 2019-05-17  Tom Tromey  <tromey@adacore.com>
3270
3271         * source.c (find_and_open_source): Remove cast.
3272
3273 2019-05-17  Tom Tromey  <tromey@adacore.com>
3274
3275         * annotate.c (annotate_source): Make "filename" const.
3276         * annotate.h (annotate_source): Use const.
3277
3278 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3279
3280         * disasm.c (set_disassembler_options): Send errors to stderr.
3281
3282 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3283
3284         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3285         (cli_interp_base::set_logging): Check debug_redirect.
3286         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3287         * cli/cli-logging.c (debug_redirect): Add static variable.
3288         (pop_output_files): Add default param.
3289         (handle_redirections): Print debug setting.
3290         (show_logging_command): Likewise.
3291         (_initialize_cli_logging): Add debugredirect command.
3292         * interps.c (current_interp_set_logging): Add debug_redirect
3293         parameter.
3294         * interps.h (set_logging): Add debug_redirect parameter.
3295         (current_interp_set_logging): Likewise.
3296         * mi/mi-common.h: Likewise.
3297         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3298
3299 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3300             Tom Tromey  <tromey@adacore.com>
3301
3302         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3303         directly.
3304         * cli/cli-interp.h (make_logging_output): Remove declaration.
3305         * cli/cli-logging.c (make_logging_output): Remove function.
3306         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3307         directly.
3308         * ui-file.c (tee_file::tee_file): Remove bools.
3309         (tee_file::~tee_file): Remove deletes.
3310         * ui-file.h (tee_file): Remove bools.
3311
3312 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3313
3314         * mi/mi-cmds.h (mi_cmd_complete): New function.
3315         * mi/mi-main.c (mi_cmd_complete): Likewise.
3316         * mi/mi-cmds.c: Define new MI command -complete.
3317         * NEWS: Mention new -complete command.
3318
3319 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3320
3321         * completer.h (complete): New function.
3322         * completer.c (complete): Likewise.
3323         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3324         function defined in completer.h.
3325
3326 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3327
3328         * MAINTAINERS (Write After Approval): Add myself.
3329
3330 2019-05-17  Tom de Vries  <tdevries@suse.de>
3331
3332         PR gdb/24094
3333         * dwarf2read.c (struct cu_partial_die_info): New struct.
3334         (find_partial_die): Return cu_partial_die_info.
3335         (partial_die_parent_scope, guess_partial_die_structure_name)
3336         (partial_die_info::fixup): Handle new return type of find_partial_die.
3337
3338 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3339
3340         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3341         "std::string", simplifying the algorithm.
3342
3343 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3344
3345         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3346         (stap_static_probe_ops::get_probes): Likewise.
3347
3348 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3349
3350         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3351         '-')" and "else if".
3352         (stap_parse_single_operand): Join checks for
3353         "gdbarch_stap_parse_special_token_p" and
3354         "gdbarch_stap_parse_special_token" in the same "if" statement.
3355         Invert check when verifying for operation on register
3356         displacement.
3357
3358 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3359
3360         * stap-probe.c (stap_get_opcode): Update comment.
3361         (stap_get_expected_argument_type): Likewise.
3362         (handle_stap_probe): Likewise.
3363
3364 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3365
3366         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3367         return type to 'bool'.  Adjust comment.  Use 'bool' when
3368         appropriate.
3369         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3370         * stap-probe.c (stap_parse_argument_1): Likewise.
3371         (stap_is_operator): Likewise.
3372         (stap_is_generic_prefix): Likewise.
3373         (stap_is_register_prefix): Likewise.
3374         (stap_is_register_indirection_prefix): Likewise.
3375         (stap_is_integer_prefix): Likewise.
3376         (stap_generic_check_suffix): Likewise.
3377         (stap_check_integer_suffix): Likewise.
3378         (stap_check_register_suffix): Likewise.
3379         (stap_check_register_indirection_suffix): Likewise.
3380         (stap_parse_register_operand): Likewise.
3381         (stap_parse_single_operand): Likewise.
3382         (stap_parse_argument_1): Likewise.
3383         (stap_probe::get_argument_count): Likewise.
3384         (stap_is_operator): Likewise.
3385
3386 2019-05-16  Tom Tromey  <tromey@adacore.com>
3387
3388         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3389         keyword to foreach.
3390
3391 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3392
3393         * linux-thread-db.c (try_thread_db_load_1): Change return type
3394         to bool.
3395         (try_thread_db_load): Likewise.
3396         (try_thread_db_load_from_pdir_1): Likewise.
3397         (try_thread_db_load_from_pdir): Likewise.
3398         (try_thread_db_load_from_sdir): Likewise.
3399         (try_thread_db_load_from_dir): Likewise.
3400         (thread_db_load_search): Likewise.
3401         (has_libpthread): Likewise.
3402         (thread_db_load): Likewise.
3403
3404 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3405
3406         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3407         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3408         NULL, and complain/return if that's the case.
3409
3410 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3411
3412         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3413         (advance, posn, abstract_read_memory): New functions.
3414         [struct mem_read_abstraction]: New struct.
3415         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3416
3417 2019-05-14  Tom Tromey  <tromey@adacore.com>
3418
3419         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3420         value is not lval_memory.
3421
3422 2019-05-14  Tom Tromey  <tromey@adacore.com>
3423
3424         * solib.c (info_sharedlibrary_command): Style the file name.
3425
3426 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3427
3428         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3429         (aarch64_vnv_type): Likewise.
3430         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3431         * common/tdesc.c: Likewise.
3432         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3433         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3434         * features/aarch64-fpu.xml: Add ieee half view.
3435         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3436         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3437         * gdbtypes.h (struct builtin_type): Likewise.
3438         (struct objfile_type): Likewise.
3439
3440 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3441
3442         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3443         typo.
3444         * location.h (string_to_event_location): Likewise.
3445
3446 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3447
3448         GDB 8.3 released.
3449
3450 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3451
3452         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3453         New variable declaration.
3454         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3455         New variable.
3456         (print_one_breakpoint): Use ui_out::test_flags and new global
3457         variable to compute use_fixed_output.
3458         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3459         Remove.
3460         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3461         (mi_multi_location_breakpoint_output_fixed): Remove.
3462         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3463         new variable.
3464         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3465         fix_multi_location_breakpoint_output flag if version >= 3.
3466         * ui-out.h (enum ui_out_flag)
3467         <fix_multi_location_breakpoint_output>: New enumerator.
3468
3469 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3470
3471         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3472
3473 2019-05-10  Tom Tromey  <tromey@adacore.com>
3474
3475         * ada-lang.c (catch_ada_completer): New function.
3476         (_initialize_ada_language): Use it.
3477
3478 2019-05-10  Tom Tromey  <tromey@adacore.com>
3479
3480         * thread.c (print_thread_info): Make "requested_threads" const.
3481         * gdbthread.h (print_thread_info): Make "requested_threads"
3482         const.
3483         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3484         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3485
3486 2019-05-08  Tom Tromey  <tom@tromey.com>
3487
3488         * gdbtypes.c (objfile_type_data): Change type.
3489         (objfile_type, _initialize_gdbtypes): Update.
3490
3491 2019-05-08  Tom Tromey  <tom@tromey.com>
3492
3493         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3494         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3495         (_initialize_dwarf2_frame): Update.
3496
3497 2019-05-08  Tom Tromey  <tom@tromey.com>
3498
3499         * objc-lang.c (objc_objfile_data): Change type.
3500         (find_methods): Update.
3501         (_initialize_objc_lang): Remove.
3502
3503 2019-05-08  Tom Tromey  <tom@tromey.com>
3504
3505         * stabsread.c (rs6000_builtin_type_data): Change type.
3506         (rs6000_builtin_type, _initialize_stabsread): Update.
3507
3508 2019-05-08  Tom Tromey  <tom@tromey.com>
3509
3510         * mips-tdep.c (mips_pdr_data): Remove.
3511         (_initialize_mips_tdep): Update.
3512
3513 2019-05-08  Tom Tromey  <tom@tromey.com>
3514
3515         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3516         (hppa_init_objfile_priv_data, read_unwind_info)
3517         (find_unwind_entry, _initialize_hppa_tdep): Update.
3518
3519 2019-05-08  Tom Tromey  <tom@tromey.com>
3520
3521         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3522         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3523         on obstack.
3524         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3525
3526 2019-05-08  Tom Tromey  <tom@tromey.com>
3527
3528         * mdebugread.c (basic_type_data): Change type.
3529         (basic_type, _initialize_mdebugread): Update.
3530
3531 2019-05-08  Tom Tromey  <tom@tromey.com>
3532
3533         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3534
3535 2019-05-08  Tom Tromey  <tom@tromey.com>
3536
3537         * nto-tdep.c (nto_inferior_data_reg): Change type.
3538         (nto_inferior_data): Update.
3539         (nto_inferior_data_cleanup, nto_new_inferior_data)
3540         (_initialize_nto_tdep): Remove.
3541         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3542
3543 2019-05-08  Tom Tromey  <tom@tromey.com>
3544
3545         * ada-lang.c (struct ada_inferior_data): Add initializers.
3546         (ada_inferior_data): Change type.
3547         (ada_inferior_data_cleanup): Remove.
3548         (get_ada_inferior_data, ada_inferior_exit)
3549         (struct ada_pspace_data): Add initializers, destructor.
3550         (ada_pspace_data_handle): Change type.
3551         (get_ada_pspace_data): Update.
3552         (ada_pspace_data_cleanup): Remove.
3553
3554 2019-05-08  Tom Tromey  <tom@tromey.com>
3555
3556         * coffread.c (struct coff_symfile_info): Add initializers.
3557         (coff_objfile_data_key): Move lower.  Change type.
3558         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3559         Update.
3560         (coff_free_info): Remove.
3561
3562 2019-05-08  Tom Tromey  <tom@tromey.com>
3563
3564         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3565         (fbsd_pspace_data_handle): Move lower.  Change type.
3566         (get_fbsd_pspace_data): Update.
3567         (fbsd_pspace_data_cleanup): Remove.
3568         (_initialize_fbsd_tdep): Update.
3569
3570 2019-05-08  Tom Tromey  <tom@tromey.com>
3571
3572         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3573         (get_ada_tasks_pspace_data): Update.
3574         (ada_tasks_pspace_data_cleanup): Remove.
3575         (_initialize_tasks): Update.
3576         (ada_tasks_inferior_data_handle): Change type.
3577         (get_ada_tasks_inferior_data): Update.
3578         (ada_tasks_inferior_data_cleanup): Remove.
3579         (struct ada_tasks_pspace_data): Add initializers.
3580
3581 2019-05-08  Tom Tromey  <tom@tromey.com>
3582
3583         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3584         * symfile-debug.c (debug_sym_get_probes): Change type.
3585         * stap-probe.c (handle_stap_probe):
3586         (stap_static_probe_ops::get_probes): Change type.
3587         * probe.h (class static_probe_ops) <get_probes>: Change type.
3588         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3589         (parse_probes_in_pspace): Update.
3590         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3591         Update.
3592         (any_static_probe_ops::get_probes): Change type.
3593         * elfread.c (elfread_data): New typedef.
3594         (probe_key): Change type.
3595         (elf_get_probes): Likewise.  Update.
3596         (probe_key_free): Remove.
3597         (_initialize_elfread): Update.
3598         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3599         Change type.
3600         (dtrace_process_dof_probe, dtrace_process_dof)
3601         (dtrace_static_probe_ops::get_probe): Change type.
3602
3603 2019-05-08  Tom Tromey  <tom@tromey.com>
3604
3605         * xcoffread.c (struct xcoff_symfile_info): Rename from
3606         coff_symfile_info.  Add initializers.
3607         (xcoff_objfile_data_key): Move lower.  Change type.
3608         (XCOFF_DATA): Rewrite.
3609         (xcoff_free_info): Remove.
3610         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3611         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3612         (xcoff_initial_scan): Update.
3613
3614 2019-05-08  Tom Tromey  <tom@tromey.com>
3615
3616         * solib-svr4.c (struct svr4_info): Add initializers and
3617         destructor.
3618         <probes_table>: Now an htab_up.
3619         (solib_svr4_pspace_data): Change type.
3620         (free_probes_table): Simplify.
3621         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3622         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3623         (probes_table_remove_objfile_probes, register_solib_event_probe)
3624         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3625         (_initialize_svr4_solib): Update.
3626
3627 2019-05-08  Tom Tromey  <tom@tromey.com>
3628
3629         * remote.c (remote_pspace_data): Change type.
3630         (remote_pspace_data_cleanup): Remove.
3631         (get_remote_exec_file, set_pspace_remote_exec_file)
3632         (_initialize_remote): Update.
3633
3634 2019-05-08  Tom Tromey  <tom@tromey.com>
3635
3636         * breakpoint.c (breakpoint_objfile_key): Change type.
3637         (get_breakpoint_objfile_data): Update.
3638         (free_breakpoint_objfile_data): Remove.
3639         (_initialize_breakpoint): Update.
3640
3641 2019-05-08  Tom Tromey  <tom@tromey.com>
3642
3643         * linux-tdep.c (struct linux_info): Add initializers.
3644         (linux_inferior_data): Move.  Change type.
3645         (invalidate_linux_cache_inf): Update.
3646         (linux_inferior_data_cleanup): Remove.
3647         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3648
3649 2019-05-08  Tom Tromey  <tom@tromey.com>
3650
3651         * auxv.c (auxv_inferior_data): Move.  Change type.
3652         (auxv_inferior_data_cleanup): Remove.
3653         (invalidate_auxv_cache_inf): Rewrite.
3654         (get_auxv_inferior_data, _initialize_auxv): Update.
3655
3656 2019-05-08  Tom Tromey  <tom@tromey.com>
3657
3658         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3659         (symfile_debug_objfile_data_key): Change type.
3660         (symfile_debug_installed, debug_qf_has_symbols)
3661         (debug_qf_find_last_source_symtab)
3662         (debug_qf_forget_cached_source_info)
3663         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3664         (debug_qf_print_stats, debug_qf_dump)
3665         (debug_qf_expand_symtabs_for_function)
3666         (debug_qf_expand_all_symtabs)
3667         (debug_qf_expand_symtabs_with_fullname)
3668         (debug_qf_map_matching_symbols)
3669         (debug_qf_expand_symtabs_matching)
3670         (debug_qf_find_pc_sect_compunit_symtab)
3671         (debug_qf_map_symbol_filenames)
3672         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3673         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3674         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3675         (debug_sym_read_linetable, debug_sym_relocate): Update.
3676         (symfile_debug_free_objfile): Remove.
3677         (install_symfile_debug_logging, _initialize_symfile_debug):
3678         Update.
3679
3680 2019-05-08  Tom Tromey  <tom@tromey.com>
3681
3682         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3683         allocate_on_obstack.
3684         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3685         (get_dwarf2_per_objfile): Update.
3686         (set_dwarf2_per_objfile): Remove.
3687         (dwarf2_has_info, dwarf2_get_section_info): Update.
3688         (dwarf2_free_objfile): Remove.
3689         (_initialize_dwarf2_read): Update.
3690
3691 2019-05-08  Tom Tromey  <tom@tromey.com>
3692
3693         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3694         initializers.
3695         <unsupported_script_warning_printed,
3696         script_not_found_warning_printed>: Now bool.
3697         (auto_load_pspace_data): Change type.
3698         (~auto_load_pspace_info): Rename from
3699         auto_load_pspace_data_cleanup.
3700         (get_auto_load_pspace_data, init_loaded_scripts_info)
3701         (clear_section_scripts, maybe_print_unsupported_script_warning)
3702         (maybe_print_script_not_found_warning, _initialize_auto_load):
3703         Update.
3704
3705 2019-05-08  Tom Tromey  <tom@tromey.com>
3706
3707         * objfiles.c (objfile_pspace_info): Add destructor and
3708         initializers.
3709         (objfiles_pspace_data): Change type.
3710         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3711         (get_objfile_pspace_data): Update.
3712         (objfiles_bfd_data): Change type.
3713         (get_objfile_bfd_data): Update.
3714         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3715
3716 2019-05-08  Tom Tromey  <tom@tromey.com>
3717
3718         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3719         Change type.
3720         (get_catch_syscall_inferior_data): Update.
3721         (catch_syscall_inferior_data_cleanup): Remove.
3722         (_initialize_break_catch_syscall): Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * inflow.c (struct terminal_info): Add destructor and
3727         initializers.
3728         (inflow_inferior_data): Change type.
3729         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3730         (get_inflow_inferior_data, inflow_inferior_exit)
3731         (swap_terminal_info, _initialize_inflow): Update.
3732
3733 2019-05-08  Tom Tromey  <tom@tromey.com>
3734
3735         * target-dcache.c (target_dcache_cleanup): Remove.
3736         (target_dcache_aspace_key): Change type.
3737         (target_dcache_init_p, target_dcache_invalidate)
3738         (target_dcache_get, target_dcache_get_or_init)
3739         (_initialize_target_dcache): Update.
3740         * dcache.h (struct dcache_deleter): New.
3741
3742 2019-05-08  Tom Tromey  <tom@tromey.com>
3743
3744         * symtab.c (struct symbol_cache): Add destructor and
3745         initializers.
3746         (symbol_cache_key): Move.  Change type.
3747         (make_symbol_cache, free_symbol_cache): Remove.
3748         (get_symbol_cache): Update.
3749         (symbol_cache_cleanup): Remove.
3750         (ALL_PSPACES, symbol_cache_flush)
3751         (maintenance_print_symbol_cache)
3752         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3753         Update.
3754
3755 2019-05-08  Tom Tromey  <tom@tromey.com>
3756
3757         * symtab.c (struct main_info): Add destructor and initializers.
3758         (main_progspace_key): Move.  Change type.
3759         (get_main_info): Update.
3760         (main_info_cleanup): Remove.
3761         (_initialize_symtab): Update.
3762
3763 2019-05-08  Tom Tromey  <tom@tromey.com>
3764
3765         * registry.h (DECLARE_REGISTRY): Define the _key class.
3766
3767 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3768
3769         * NEWS: Merge two 'New commands' sections.
3770
3771 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3772
3773         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3774         parameter and use Ada language definition instead.
3775         (ada_val_print_ptr): Remove unused language parameter.
3776         (ada_val_print_num): Remove language parameter and use Ada language
3777         definition instead.
3778         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3779         parameter.
3780         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3781         parameter and use Ada language definition instead.
3782         (ada_val_print_1): Update all ada_val_print_xxx calls.
3783         Remove language parameter.
3784         (ada_val_print): Update ada_val_print_1 call.
3785
3786 2019-05-08  Tom Tromey  <tromey@adacore.com>
3787
3788         * remote.c (remote_hw_watchpoint_limit)
3789         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3790         Now static.
3791
3792 2019-05-08  Tom Tromey  <tromey@adacore.com>
3793
3794         * maint.c (_initialize_maint_cmds): Move initialization code to
3795         remote.c.
3796         (watchdog, show_watchdog): Move to remote.c.
3797         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3798         "watchdog" static.
3799         (_initialize_remote): Move initialization code from maint.c.
3800         * defs.h (watchdog): Don't declare.
3801
3802 2019-05-08  Tom Tromey  <tromey@adacore.com>
3803
3804         * tui/tui-interp.c: Include main.h.
3805         * interps.c: Include main.h.
3806         * main.h (interpreter_p): Declare.
3807         * defs.h (interpreter_p): Don't declare.
3808
3809 2019-05-08  Tom Tromey  <tromey@adacore.com>
3810
3811         * dwarf2loc.c: Include dwarf2read.h.
3812         * defs.h (read_unsigned_leb128): Don't declare.
3813         * dwarf2read.h (read_unsigned_leb128): Declare.
3814
3815 2019-05-08  Tom Tromey  <tromey@adacore.com>
3816
3817         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3818         method.
3819
3820 2019-05-08  Tom Tromey  <tromey@adacore.com>
3821
3822         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3823         when no wrap column is set.
3824
3825 2019-05-08  Tom Tromey  <tromey@adacore.com>
3826
3827         * c-lang.c (c_get_string): Handle non-C-style arrays.
3828
3829 2019-05-08  Tom Tromey  <tromey@adacore.com>
3830
3831         * typeprint.c (print_offset_data::update): Print the bit offset,
3832         not the number of bits remaining.
3833
3834 2019-05-08  Tom Tromey  <tromey@adacore.com>
3835
3836         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3837         padding at end of comment.
3838
3839 2019-05-08  Tom Tromey  <tromey@adacore.com>
3840
3841         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3842         Compare main types.
3843
3844 2019-05-06  Tom Tromey  <tom@tromey.com>
3845
3846         * common/scoped_mmap.c: Include common-defs.h.
3847         * common/scoped_mmap.h: Don't include config.h.
3848
3849 2019-05-04  Tom Tromey  <tom@tromey.com>
3850
3851         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3852         (struct aarch64_call_info): Add initializers.
3853         <si>: Now a std::vector.
3854         (pass_on_stack, aarch64_push_dummy_call): Update.
3855
3856 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3857             Tom Tromey  <tom@tromey.com>
3858
3859         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3860         (ppc_threads): Now a std::vector.  Now static.
3861         (hwdebug_find_thread_points_by_tid)
3862         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3863         Update.
3864
3865 2019-05-04  Tom Tromey  <tom@tromey.com>
3866
3867         * arc-tdep.c (arc_tdesc_init): Return bool.
3868
3869 2019-05-04  Tom Tromey  <tom@tromey.com>
3870
3871         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3872         Use gdb_assert_not_reached.
3873
3874 2019-05-04  Tom Tromey  <tom@tromey.com>
3875
3876         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3877         "false".
3878
3879 2019-05-04  Tom Tromey  <tom@tromey.com>
3880
3881         * arc-tdep.c (arc_tdesc_init): Use bool.
3882
3883 2019-05-04  Tom Tromey  <tom@tromey.com>
3884
3885         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3886
3887 2019-05-04  Tom Tromey  <tom@tromey.com>
3888
3889         * cli/cli-cmds.c (valid_command_p): Return bool.
3890
3891 2019-05-04  Tom Tromey  <tom@tromey.com>
3892
3893         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3894         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3895
3896 2019-05-04  Raul Tambre  <raul@tambre.ee>
3897
3898         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3899         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3900         operator for comparison.
3901
3902 2019-05-04  Tom Tromey  <tom@tromey.com>
3903
3904         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3905         (lookup_partial_symbol, print_partial_symbols)
3906         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3907         (psymbol_compare): Update.
3908         (add_psymbol_to_bcache): Clear the entire psymbol.
3909         (maintenance_check_psymtabs): Update.
3910         * psympriv.h (struct partial_symbol): Don't derive from
3911         general_symbol_info.
3912         <obj_section, unrelocated_address, address,
3913         set_unrelocated_address>: Update.
3914         <ginfo>: New member.
3915         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3916         (debug_names::write_psymbols): Update.
3917
3918 2019-05-04  Tom de Vries  <tdevries@suse.de>
3919
3920         * contrib/cc-with-tweaks.sh: Support -n arg.
3921
3922 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3923
3924         * corelow.c (core_target::detach): Ensure frame cache and
3925         register caches are cleared.
3926         inferior.c (exit_inferior_1): Likewise.
3927
3928 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3929             Tom Tromey  <tom@tromey.com>
3930
3931         * dictionary.c (collate_pending_symbols_by_language): Remove
3932         "struct" from foreach.
3933         * symtab.c (lookup_global_symbol_from_objfile)
3934         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3935         foreach.
3936         * ser-tcp.c (net_open): Remove "struct" from foreach.
3937         * objfiles.c (objfile_relocate, objfile_rebase)
3938         (objfile_has_symbols): Remove "struct" from foreach.
3939         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3940         from foreach.
3941         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3942         foreach.
3943         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3944         "struct" from foreach.
3945         * ada-lang.c (create_excep_cond_exprs)
3946         (ada_exception_catchpoint_cond_string): Remove "struct" from
3947         foreach.
3948
3949 2019-05-03  Tom Tromey  <tromey@adacore.com>
3950
3951         * ada-exp.y (convert_char_literal): Check suffix of each
3952         enumerator.
3953
3954 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3955
3956         PR ada/21406:
3957         * ada-exp.y (yywrap): Don't define.
3958         * ada-lex.l (%option): Add noyywrap
3959         (yywrap): Remove.
3960
3961 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3962
3963         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3964         _WIN32_WINNT to the XP level, unless already defined to a higher
3965         level.
3966
3967         * unittests/parse-connection-spec-selftests.c:
3968         * ser-tcp.c:
3969         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3970         override.
3971
3972         * symfile.c (find_separate_debug_file): Remove colon from the
3973         drive spec of DOS/Windows file names of the target, so that the
3974         file name produced from DEBUGDIR and the target's directory will
3975         be valid on DOS/Windows systems.
3976
3977 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * rust-lang.c (val_print_struct): Handle printing structures
3980         containing strings.
3981
3982 2019-05-02  Tom Tromey  <tromey@adacore.com>
3983
3984         * valarith.c (_initialize_valarith): Remove.
3985
3986 2019-05-01  Tom Tromey  <tromey@adacore.com>
3987
3988         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3989         bitfields.
3990
3991 2019-05-01  Tom Tromey  <tromey@adacore.com>
3992
3993         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3994         for big-endian copies.
3995
3996 2019-04-30  Ali Tamur  <tamur@google.com>
3997         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3998         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3999         (read_3_bytes): New function.
4000
4001 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4002
4003         * windows-nat.c (main_thread_id): Delete.
4004         (handle_output_debug_string): Replace main_thread_id by
4005         current_event.dwThreadId.
4006         (fake_create_process): Likewise.
4007         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4008         Do not set main_thread_id.
4009         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4010         current_event.dwThreadId.
4011         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4012
4013 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4014
4015         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4016         Use current_event.dwThreadId instead of main_thread_id.
4017
4018 2019-04-30  Tom Tromey  <tromey@adacore.com>
4019
4020         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4021         (create_excep_cond_exprs): Iterate over program spaces.
4022         (ada_exception_catchpoint_cond_string): Examine all minimal
4023         symbols for exception types.
4024
4025 2019-04-30  Tom Tromey  <tromey@adacore.com>
4026
4027         PR c++/24470:
4028         * dwarf2read.c (process_structure_scope): Handle case where type
4029         has template parameters but no symbol was created.
4030
4031 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4032             Chris January  <chris.january@arm.com>
4033
4034         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4035         qualifier.
4036         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4037
4038 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * f-typeprint.c (f_print_type): Update rules for printing
4041         whitespace.
4042         (f_type_print_varspec_suffix): Likewise.
4043
4044 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4045             Chris January  <chris.january@arm.com>
4046
4047         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4048         function arguments.
4049
4050 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * f-lang.c (build_fortran_types): Change name of void type to
4053         lower case.
4054         * f-typeprint.c (f_type_print_base): Print the name of the void
4055         type, rather than a fixed string.
4056         * f-valprint.c (f_decorations): Use lower case void string.
4057
4058 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4059             Chris January  <chris.january@arm.com>
4060
4061         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4062         types for Fortran.
4063
4064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4065             Chris January  <chris.january@arm.com>
4066             David Lecomber  <david.lecomber@arm.com>
4067
4068         * f-exp.y (BINOP_INTRINSIC): New token.
4069         (exp): New parser rule handling BINOP_INTRINSIC.
4070         (f77_keywords): Add new builtin procedures.
4071         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4072         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4073         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4074         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4075         (print_unop_subexp_f): New function.
4076         (print_binop_subexp_f): New function.
4077         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4078         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4079         (dump_subexp_body_f): Likewise.
4080         (operator_check_f): Likewise.
4081         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4082         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4083
4084 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4087         UNOP_KIND.
4088         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4089         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4090         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4091         (operator_length_f): New fuction.
4092         (print_subexp_f): New function.
4093         (op_name_f): New function.
4094         (dump_subexp_body_f): New function.
4095         (operator_check_f): New function.
4096         (exp_descriptor_f): Replace standard expression handling functions
4097         with new functions.
4098         * gdb/fortran-operator.def: New file.
4099         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4100         * gdb/std-operator.def: Remove UNOP_KIND.
4101
4102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4103
4104         * std-operator.def: Remove unbalanced, stray double quote
4105         character.
4106
4107 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4108             Chris January  <chris.january@arm.com>
4109             Daniel Everett  <daniel.everett@arm.com>
4110             Nick Forrington  <nick.forrington@arm.com>
4111             Richard Bunt  <richard.bunt@arm.com>
4112
4113         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4114         of depth when printing anonymous structs or unions.
4115         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4116         Don't print either the top-level value, or the children if the
4117         max-depth is exceeded.
4118         (ppscm_print_children): When printing the key of a map, allow one
4119         extra level of depth.
4120         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4121         print either the top-level value, or the children if the max-depth
4122         is exceeded.
4123         (print_children): When printing the key of a map, allow one extra
4124         level of depth.
4125         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4126         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4127         (user_print_options): Initialise max_depth field.
4128         (val_print_scalar_or_string_type_p): New function.
4129         (val_print): Check to see if the max depth has been reached.
4130         (val_print_check_max_depth): Define new function.
4131         (show_print_max_depth): New function.
4132         (_initialize_valprint): Add 'print max-depth' option.
4133         * valprint.h (struct value_print_options) <max_depth>: New field.
4134         (val_print_check_max_depth): Declare new function.
4135         * NEWS: Document new feature.
4136
4137 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * ada-lang.c (ada_language_defn): Initialise new field.
4140         * c-lang.c (c_is_string_type_p): New function.
4141         (c_language_defn): Initialise new field.
4142         (cplus_language_defn): Initialise new field.
4143         (asm_language_defn): Initialise new field.
4144         (minimal_language_defn): Initialise new field.
4145         * c-lang.h (c_is_string_type_p): Declare new function.
4146         * d-lang.c (d_language_defn): Initialise new field.
4147         * f-lang.c (f_is_string_type_p): New function.
4148         (f_language_defn): Initialise new field.
4149         * go-lang.c (go_is_string_type_p): New function.
4150         (go_language_defn): Initialise new field.
4151         * language.c (default_is_string_type_p): New function.
4152         (unknown_language_defn): Initialise new field.
4153         (auto_language_defn): Initialise new field.
4154         * language.h (struct language_defn) <la_is_string_type_p>: New
4155         member variable.
4156         (default_is_string_type_p): Declare new function.
4157         * m2-lang.c (m2_language_defn): Initialise new field.
4158         * objc-lang.c (objc_language_defn): Initialise new field.
4159         * opencl-lang.c (opencl_language_defn): Initialise new field.
4160         * p-lang.c (pascal_is_string_type_p): New function.
4161         (pascal_language_defn): Initialise new field.
4162         * rust-lang.c (rust_is_string_type_p): New function.
4163         (rust_language_defn): Initialise new field.
4164
4165 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4168         New field.
4169         * ada-lang.c (ada_language_defn): Initialise new field.
4170         * c-lang.c (c_language_defn): Likewise.
4171         (cplus_language_defn): Likewise.
4172         (asm_language_defn): Likewise.
4173         (minimal_language_defn): Likewise.
4174         * d-lang.c (d_language_defn): Likewise.
4175         * f-lang.c (f_language_defn): Likewise.
4176         * go-lang.c (go_language_defn): Likewise.
4177         * language.c (unknown_language_defn): Likewise.
4178         (auto_language_defn): Likewise.
4179         * m2-lang.c (m2_language_defn): Likewise.
4180         * objc-lang.c (objc_language_defn): Likewise.
4181         * opencl-lang.c (opencl_language_defn): Likewise.
4182         * p-lang.c (pascal_language_defn): Likewise.
4183         * rust-lang.c (rust_language_defn): Likewise.
4184
4185 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * ada-lang.c (ada_is_character_type): Change return type to bool.
4188         (ada_is_string_type): Likewise.
4189         * ada-lang.h (ada_is_character_type): Update declaration
4190         (ada_is_string_type): Likewise.
4191
4192 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4193
4194         Support style in 'frame|thread apply'
4195
4196         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4197         * record.c (record_start, record_stop): Update callers of
4198         execute_command_to_string with false.
4199         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4200         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4201         methods.
4202         (class string_file): New constructor with term_out parameter.
4203         Override methods term_out and can_emit_style_escape.  New member
4204         term_out.
4205         (class stdio_file): Override can_emit_style_escape.
4206         (class tee_file): Override term_out and can_emit_style_escape.
4207         * utils.h (can_emit_style_escape): Remove.
4208         * utils.c (can_emit_style_escape): Likewise.
4209         Update all callers of can_emit_style_escape (SOMESTREAM) to
4210         SOMESTREAM->can_emit_style_escape.
4211         * source-cache.c (source_cache::get_source_lines): Likewise.
4212         * stack.c (frame_apply_command_count): Call execute_command_to_string
4213         passing the term_out characteristic of the current gdb_stdout.
4214         * thread.c (thr_try_catch_cmd): Likewise.
4215         * top.c (execute_command_to_string): pass term_out parameter
4216         to construct the string_file for the command output.
4217         * ui-file.c (term_cli_styling): New function (most code moved
4218         from utils.c can_emit_style_escape).
4219         (string_file::string_file, string_file::can_emit_style_escape,
4220         stdio_file::can_emit_style_escape, tee_file::term_out,
4221         tee_file::can_emit_style_escape): New functions.
4222
4223 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4224
4225         * NEWS: Mention the new set|show may-call-functions.
4226         * infcall.c (may_call_functions_p): New variable.
4227         (show_may_call_functions_p): New function.
4228         (call_function_by_hand_dummy): Throws an error if not
4229         may-call-functions.
4230         (_initialize_infcall): Call add_setshow_boolean_cmd for
4231         may-call-functions.
4232
4233 2019-04-25  Keith Seitz  <keiths@redhat.com>
4234
4235         PR c++/24367
4236         * cp-support.c (inspect_type): Don't attempt substitutions
4237         of symbol with the same name.
4238
4239 2019-04-25  Tom Tromey  <tromey@adacore.com>
4240
4241         PR gdb/24475:
4242         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4243         static.
4244
4245 2019-04-25  Tom Tromey  <tromey@adacore.com>
4246
4247         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4248         rvalue reference.
4249         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4250         (gdb_xml_parser::parse): Use std::move.
4251         * python/python-internal.h (gdbpy_convert_exception): Take a const
4252         reference.
4253         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4254         std::move.
4255         * python/py-utils.c (gdbpy_convert_exception): Take a const
4256         reference.
4257         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4258         Use std::move.
4259         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4260         Use std::move.
4261         * mi/mi-main.c (mi_print_exception): Take a const reference.
4262         * main.c (handle_command_errors): Take a const reference.
4263         * linespec.c (parse_linespec): Use std::move.
4264         * infcall.c (run_inferior_call): Use std::move.
4265         (call_function_by_hand_dummy): Use std::move.
4266         * exec.c (try_open_exec_file): Use std::move.
4267         * exceptions.h (exception_print, exception_fprintf)
4268         (exception_print_same): Update.
4269         * exceptions.c (print_exception, exception_print)
4270         (exception_fprintf, exception_print_same): Change parameters to
4271         const reference.
4272         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4273         * common/new-op.c: Use std::move.
4274         * common/common-exceptions.h (struct gdb_exception): Add move
4275         constructor.
4276         (struct gdb_exception_error, struct gdb_exception_quit, struct
4277         gdb_quit_bad_alloc): Change constructor to move constructor.
4278         (throw_exception): Change parameter to rvalue reference.
4279         * common/common-exceptions.c (throw_exception): Take rvalue
4280         reference.
4281         * cli/cli-interp.c (safe_execute_command): Use std::move.
4282         * breakpoint.c (insert_bp_location, location_to_sals): Use
4283         std::move.
4284
4285 2019-04-25  Tom Tromey  <tromey@adacore.com>
4286
4287         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4288         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4289         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4290         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4291         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4292         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4293         guile/scm-value.c: Use unpack.
4294         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4295         gdbscm_gdb_exception.
4296         (gdbscm_throw_gdb_exception): Likewise.
4297         (struct gdbscm_gdb_exception): New.
4298         (unpack): New function.
4299         (gdbscm_wrap): Use unpack.
4300
4301 2019-04-25  Tom Tromey  <tromey@adacore.com>
4302
4303         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4304         (gdb_rl_callback_handler): Use std::move.
4305         * common/common-exceptions.h (struct gdb_exception): Add move
4306         assignment operator.
4307         (throw_exception_sjlj): Change "exception" to const reference.
4308         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4309         (throw_exception_sjlj): Change "exception" to const reference.
4310
4311 2019-04-25  Tom Tromey  <tromey@adacore.com>
4312
4313         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4314         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4315         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4316         Update.
4317         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4318         Update.
4319         * mi/mi-interp.c (mi_interp::exec): Update.
4320         * linespec.c (parse_linespec): Update.
4321         * infcall.c (run_inferior_call): Update.
4322         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4323         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4324         (gdbscm_lookup_global_symbol): Update.
4325         * guile/scm-param.c (gdbscm_parameter_value): Update.
4326         * guile/scm-frame.c (gdbscm_frame_read_register)
4327         (gdbscm_frame_read_var): Update.
4328         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4329         * exec.c (try_open_exec_file): Update.
4330         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4331         (gdb_rl_callback_handler): Update.
4332         * common/common-exceptions.h (exception_none): Don't declare.
4333         * common/common-exceptions.c (exception_none): Don't define.
4334         (struct catcher) <exception>: Update.
4335         * cli/cli-interp.c (safe_execute_command): Update.
4336         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4337
4338 2019-04-25  Ali Tamur  <tamur@google.com>
4339
4340         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4341         (read_attribute_value): Likewise.
4342         (dwarf2_read_addr_index): Update comment.
4343         (read_str_index): Add DW_FORM_strx.
4344         (dwarf2_string_attr): Likewise.
4345         (dwarf2_const_value_attr): Likewise.
4346         (dump_die_shallow): Likewise.
4347         (dwarf2_fetch_constant_bytes): Likewise.
4348         (skip_form_bytes): Likewise.
4349         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4350
4351 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4352
4353         PR corefiles/11608
4354         PR corefiles/18187
4355         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4356         OFFSET.  Verify if current mapping contains an ELF header.
4357         (linux_find_memory_regions_full): Adjust call to
4358         dump_mapping_p.
4359
4360 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4361             Kang Li <kanglictf@gmail.com>
4362
4363         PR gdb/21600
4364
4365         * dwarf2-frame.c (read_initial_length): Be consistent about using
4366         unsigned representation of length.
4367         (decode_frame_entry_1): Likewise.  Check for wraparound of
4368         end pointer as well as buffer overflow.
4369
4370 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4371
4372         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4373         "vq".
4374
4375 2019-04-24  Tom Tromey  <tromey@adacore.com>
4376
4377         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4378
4379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * s12z-tdep.c (s12z_unwind_pc): Delete.
4382         (s12z_unwind_sp): Delete.
4383         (s12z_gdbarch_init): Don't register deleted functions with
4384         gdbarch.
4385
4386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * rl78-tdep.c (rl78_unwind_sp): Delete.
4389         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4390
4391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4394         (xstormy16_unwind_pc): Delete.
4395         (xstormy16_dummy_id): Delete.
4396         (xstormy16_gdbarch_init): Don't register deleted functions with
4397         gdbarch.
4398
4399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * vax-tdep.c (vax_unwind_pc): Delete.
4402         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4403
4404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * v850-tdep.c (v850_unwind_sp): Delete.
4407         (v850_unwind_pc): Delete.
4408         (v850_dummy_id): Delete.
4409         (v850_gdbarch_init): Don't register deleted functions with
4410         gdbarch.
4411
4412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4413
4414         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4415         (tilegx_unwind_pc): Delete.
4416         (tilegx_unwind_dummy_id): Delete.
4417         (tilegx_gdbarch_init): Don't register deleted functions with
4418         gdbarch.
4419
4420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4423         (tic6x_dummy_id): Delete.
4424         (tic6x_gdbarch_init): Don't register deleted functions with
4425         gdbarch.
4426
4427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * sparc-tdep.c (sparc_unwind_pc): Delete.
4430         (sparc32_gdbarch_init): Don't register deleted function with
4431         gdbarch.
4432
4433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * sh-tdep.c (sh_unwind_sp): Delete.
4436         (sh_unwind_pc): Delete.
4437         (sh_dummy_id): Delete.
4438         (sh_gdbarch_init): Don't register deleted functions with
4439         gdbarch.
4440
4441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * score-tdep.c (score_unwind_sp): Delete.
4444         (score_unwind_pc): Delete.
4445         (score_dummy_id): Delete.
4446         (score_gdbarch_init): Don't register deleted functions with
4447         gdbarch.
4448
4449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4450
4451         * rx-tdep.c (rx_unwind_pc): Delete.
4452         (rx_unwind_sp): Delete.
4453         (rx_dummy_id): Delete.
4454         (rx_gdbarch_init): Don't register deleted functions with
4455         gdbarch.  Update comment.
4456
4457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4458
4459         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4460         (rs6000_dummy_id): Delete.
4461         (rs6000_gdbarch_init): Don't register deleted functions with
4462         gdbarch.
4463
4464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * or1k-tdep.c (or1k_dummy_id): Delete.
4467         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4468
4469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * nios2-tdep.c (nios2_dummy_id): Delete.
4472         (nios2_unwind_sp): Delete.
4473         (nios2_gdbarch_init): Don't register deleted functions with
4474         gdbarch.
4475
4476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * nds32-tdep.c (nds32_dummy_id): Delete.
4479         (nds32_unwind_pc): Delete.
4480         (nds32_unwind_sp): Delete.
4481         (nds32_gdbarch_init): Don't register deleted functions with
4482         gdbarch.
4483
4484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * msp430-tdep.c (msp430_unwind_pc): Delete.
4487         (msp430_unwind_sp): Delete.
4488         (msp430_dummy_id): Delete.
4489         (msp430_gdbarch_init): Don't register deleted functions with
4490         gdbarch.
4491
4492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4493
4494         * moxie-tdep.c (moxie_unwind_sp): Delete.
4495         (moxie_unwind_pc): Delete.
4496         (moxie_dummy_id): Delete.
4497         (moxie_gdbarch_init): Don't register deleted functions with
4498         gdbarch.
4499
4500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4503         (mn10300_unwind_pc): Delete.
4504         (mn10300_unwind_sp): Delete.
4505         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4506         mn10300_unwind_sp.
4507         (mn10300_frame_unwind_init): Don't register deleted functions with
4508         gdbarch.
4509
4510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * mep-tdep.c (mep_unwind_pc): Delete.
4513         (mep_unwind_sp): Delete.
4514         (mep_dummy_id): Delete.
4515         (mep_gdbarch_init): Don't register deleted functions with
4516         gdbarch.
4517
4518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4521         (m68hc11_unwind_sp): Delete.
4522         (m68hc11_gdbarch_init): Don't register deleted functions with
4523         gdbarch.
4524
4525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * m32r-tdep.c (m32r_unwind_sp): Delete.
4528         (m32r_unwind_pc): Delete.
4529         (m32r_dummy_id): Delete.
4530         (m32r_gdbarch_init): Don't register deleted functions with
4531         gdbarch.
4532
4533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4534
4535         * m32c-tdep.c (m32c_unwind_pc): Delete.
4536         (m32c_unwind_sp): Delete.
4537         (m32c_dummy_id): Delete.
4538         (m32c_gdbarch_init): Don't register deleted functions with
4539         gdbarch.
4540
4541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4542
4543         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4544         (lm32_unwind_pc): Delete.
4545         (lm32_dummy_id): Delete.
4546         (lm32_gdbarch_init): Don't register deleted functions with
4547         gdbarch.
4548
4549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4552         (iq2000_unwind_pc): Delete.
4553         (iq2000_dummy_id): Delete.
4554         (iq2000_gdbarch_init): Don't register deleted functions with
4555         gdbarch.
4556
4557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * nds32-tdep.c (nds32_type_align): Delete.
4560         (nds32_push_dummy_call): Use type_align instead.
4561
4562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * arm-tdep.c (arm_type_align): Only handle vector override case.
4565         (arm_push_dummy_call): Use type_align.
4566         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4567
4568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4571         case.
4572         (pass_on_stack): Use type_align.
4573         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4574         function.
4575
4576 2019-04-23  Tom Tromey  <tromey@adacore.com>
4577
4578         * dwarf2read.c (line_header::file_name_at): Remove unused
4579         overload.
4580
4581 2019-04-23  Tom de Vries  <tdevries@suse.de>
4582
4583         PR gdb/24438
4584         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4585         invocation.
4586
4587
4588 2019-03-27  Ali Tamur  <tamur@google.com>
4589
4590         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4591         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4592         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4593         (dwarf_expr_context::get_addr_index): Likewise
4594         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4595         (symbol_needs_eval_context::get_addr_index): Likewise
4596         (disassemble_dwarf_expression): Add DW_OP_addrx
4597         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4598         (read_cutu_die_from_dwo): Update comment
4599         (skip_one_die): Add DW_FORM_addrx
4600         (read_attribute_value): Likewise
4601         (var_decode_location): Add DW_OP_addrx
4602         (dwarf2_const_value_attr): Add DW_FORM_addrx
4603         (dump_die_shallow): Likewise
4604         (dwarf2_fetch_constant_bytes): Likewise
4605         (decode_locdesc): Add DW_OP_addrx
4606         (skip_form_bytes): Add DW_FORM_addrx
4607
4608 2019-04-22  Ali Tamur  <tamur@google.com>
4609
4610         * MAINTAINERS (Write After Approval): Add self.
4611
4612 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4613
4614         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4615         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4616         (open_symbol_file_object): Likewise.
4617         (svr4_default_sos): Add info parameter.
4618         (svr4_read_so_list): Likewise.
4619         (svr4_current_sos_direct): Adjust functions calls to pass down
4620         info.
4621         (svr4_current_sos_1): Add info parameter.
4622         (svr4_current_sos): Call get_svr4_info, pass info down to
4623         svr4_current_sos_1.
4624         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4625         get_svr4_info.
4626         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4627         get_svr4_info.
4628         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4629         to get_svr4_info.
4630         (probes_table_remove_objfile_probes): Likewise.
4631         (register_solib_event_probe): Add info parameter.
4632         (solist_update_incremental): Pass info parameter down to
4633         svr4_read_so_list.
4634         (disable_probes_interface): Add info parameter.
4635         (svr4_handle_solib_event): Pass current_program_space to
4636         get_svr4_info.  Adjust disable_probes_interface cleanup.
4637         (svr4_create_probe_breakpoints): Add info parameter, pass it
4638         down to register_solib_event_probe.
4639         (svr4_create_solib_event_breakpoints): Add info parameter,
4640         pass it down to svr4_create_probe_breakpoints.
4641         (enable_break): Pass info down to
4642         svr4_create_solib_event_breakpoints.
4643         (svr4_solib_create_inferior_hook): Pass current_program_space to
4644         get_svr4_info.
4645         (svr4_clear_solib): Likewise.
4646
4647 2019-04-22  Pedro Alves  <palves@redhat.com>
4648
4649         * solib-svr4.c (svr4_free_objfile_observer): New.
4650         (probe_and_action::objfile): New field.
4651         (probes_table_htab_remove_objfile_probes)
4652         (probes_table_remove_objfile_probes): New functions.
4653         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4654         in the new probe_and_action.  Don't store the probe in 'lookup'.
4655         (svr4_create_probe_breakpoints): Pass objfile to
4656         register_solib_event_probe.
4657         (_initialize_svr4_solib): Register a free_objfile observer.
4658
4659 2019-04-19  Tom Tromey  <tom@tromey.com>
4660
4661         * common/queue.h: Remove.
4662
4663 2019-04-19  Tom Tromey  <tom@tromey.com>
4664
4665         * event-loop.c: Don't include "common/queue.h".
4666
4667 2019-04-19  Tom Tromey  <tom@tromey.com>
4668
4669         * remote.c (remote_target): Use delete.
4670         * remote-notif.h: Include <list>, not "common/queue.h".
4671         (notif_client_p): Remove typedef.
4672         (remote_notif_state): Add constructor, destructor, initializer.
4673         <notif_queue>: Now a std::list.
4674         (remote_notif_state_xfree): Don't declare.
4675         * remote-notif.c (remote_notif_process, handle_notification)
4676         (remote_notif_state_allocate): Update.
4677         (~remote_notif_state): Rename from remote_notif_state_xfree.
4678
4679 2019-04-19  Tom Tromey  <tom@tromey.com>
4680
4681         * symfile.c (reread_symbols): Update.
4682         * objfiles.c (objfile_register_static_link)
4683         (objfile_lookup_static_link): Update
4684         (~objfile) Don't delete static_links.
4685         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4686
4687 2019-04-19  Tom Tromey  <tom@tromey.com>
4688
4689         * type-stack.h (struct type_stack) <insert>: Constify string.
4690         * type-stack.c (type_stack::insert): Constify string.
4691         * gdbtypes.h (lookup_template_type): Update.
4692         (address_space_name_to_int): Update.
4693         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4694         const.
4695         (lookup_template_type): Make name const.
4696         * c-exp.y: Update rules.
4697         (lex_one_token, classify_name, classify_inner_name)
4698         (c_print_token): Update.
4699         * p-exp.y: Update rules.
4700         (yylex): Update.
4701         * f-exp.y: Update rules.
4702         (yylex): Update.
4703         * d-exp.y: Update rules.
4704         (lex_one_token, classify_name, classify_inner_name): Update.
4705         * parse.c (write_dollar_variable, copy_name): Return std::string.
4706         * parser-defs.h (copy_name): Change return type.
4707         * m2-exp.y: Update rules.
4708         (yylex): Update.
4709         * go-exp.y (lex_one_token): Update.
4710         Update rules.
4711         (classify_unsafe_function, classify_packaged_name)
4712         (classify_name, yylex): Update.
4713
4714 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4715
4716         * configure.ac: add --enable-source-highlight switch.
4717         * configure: Regenerate.
4718         * top.c (print_gdb_version): plumb --enable-source-highlight
4719         status to "show configuration".
4720
4721 2019-04-19  Tom Tromey  <tromey@adacore.com>
4722
4723         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4724         Check ADA_TYPE_P.
4725         (empty_record, ada_template_to_fixed_record_type_1)
4726         (template_to_static_fixed_type)
4727         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4728         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4729         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4730         macros.
4731
4732 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4733
4734         PR symtab/24423:
4735         * source.c (print_source_lines_base): Advance "iter" when a
4736         control character is seen.
4737
4738 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4739
4740         * inferior.h (struct infcall_suspend_state_deleter):
4741         Catch exception in destructor to avoid crash.
4742
4743 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4744
4745         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4746         close to the add_com "shell".
4747
4748 2019-04-18  Tom Tromey  <tromey@adacore.com>
4749
4750         * process-stratum-target.h (class process_stratum_target)
4751         <stratum>: Add "final".
4752
4753 2019-04-17  Tom Tromey  <tromey@adacore.com>
4754
4755         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4756         against nullptr before use.
4757
4758 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4759
4760         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4761
4762 2019-04-17  Jim Wilson  <jimw@sifive.com>
4763             Andrew Burgess  <andrew.burgess@embecosm.com>
4764
4765         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4766         code read might fail, assume 4-byte breakpoint in that case.
4767
4768 2019-04-15  Leszek Swirski  <leszeks@google.com>
4769
4770         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4771         rather than a hand-rolled POD check when checking for forced MEMORY
4772         classification.
4773
4774 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4775
4776         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4777         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4778         function.
4779         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4780         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4781         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4782         declaration.
4783
4784 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4785
4786         * aarch64-linux-nat.c
4787         (aarch64_linux_nat_target::thread_architecture): Add override.
4788         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4789         each VQ.
4790
4791 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4792
4793         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4794
4795 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4796
4797         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4798         target types of size 96-bits, add some additional comments, and
4799         check that the builtin type we found was the correct size.
4800
4801 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4802
4803         * utils.c (prompt_for_continue): Don't restore the styling at the
4804         end, as applied_style has the wrong value.  This fixes styling in
4805         long lists of file names that are interrupted by the "Continue?"
4806         prompt.
4807
4808 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4811         * c-lang.c (c_language_defn): Likewise.
4812         (cplus_language_defn): Likewise.
4813         (asm_language_defn): Likewise.
4814         (minimal_language_defn): Likewise.
4815         * d-lang.c (d_language_defn): Likewise.
4816         * f-lang.c (f_language_defn): Likewise.
4817         * go-lang.c (go_language_defn): Likewise.
4818         * language.c (unknown_language_defn): Likewise.
4819         (auto_language_defn): Likewise.
4820         * language.h (struct language_defn): Remove la_magic field.
4821         (LANG_MAGIC): Delete.
4822         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4823         * objc-lang.c (objc_language_defn): Likewise.
4824         * opencl-lang.c (opencl_language_defn): Likewise.
4825         * p-lang.c (pascal_language_defn): Likewise.
4826         * rust-lang.c (rust_language_defn): Likewise.
4827
4828 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * riscv-tdep.c (riscv_type_align): New function.
4831         (riscv_type_alignment): Delete.
4832         (riscv_arg_location): Use 'type_align'.
4833         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4834
4835 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4836
4837         * gdbtypes.c (type_align): A struct with no non-static fields also
4838         has alignment of 1.
4839
4840 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4843         component to 0.
4844         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4845         member.
4846         (riscv_struct_info::analyse): New implementation using new
4847         analyse_inner member function.
4848         (riscv_struct_info::field_offset): New member function.
4849         (riscv_struct_info::m_offsets): New member variable.
4850         (riscv_struct_info::analyse_inner): New private member function,
4851         takes the old implementation of riscv_struct_info::analyse but
4852         extended to track field offsets.
4853         (riscv_call_arg_struct): Update the struct folding special cases
4854         to handle cases where empty C++ structs, which are non-zero
4855         length, are found.
4856         (riscv_arg_location): Initialise the length of each location, a
4857         non-zero length now indicates the location is in use.
4858         (riscv_push_dummy_call): Allow for the first location having a
4859         non-zero offset when setting up arguments.
4860         (riscv_return_value): Likewise, but for return values.
4861
4862 2019-04-11  Tom Tromey  <tromey@adacore.com>
4863
4864         * utils.c (internal_vproblem): Make "msg" const.
4865
4866 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4867
4868         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4869         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4870         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4871         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4872
4873 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4874
4875         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4876         function.
4877         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4878         of amd64_collect_native_gregset.
4879         (amd64_linux_nat_target::store_registers): Likewise.
4880
4881 2019-04-10  Tom Tromey  <tom@tromey.com>
4882
4883         * symtab.c (lookup_global_symbol_from_objfile)
4884         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4885         * objfiles.h (class separate_debug_iterator): New.
4886         (class separate_debug_range): New.
4887         (struct objfile) <separate_debug_objfiles>: New method.
4888         (objfile_separate_debug_iterate): Don't declare.
4889         * objfiles.c (separate_debug_iterator::operator++): Rename from
4890         objfile_separate_debug_iterate.
4891         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4892         iterator.
4893         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4894         iterator.
4895
4896 2019-04-10  Tom Tromey  <tom@tromey.com>
4897
4898         * symfile.c (reread_symbols): Remove old comment.
4899         * objfiles.c (free_all_objfiles): Fix a typo.
4900
4901 2019-04-10  Tom Tromey  <tom@tromey.com>
4902
4903         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4904         * minsyms.c (lookup_minimal_symbol): Use foreach.
4905         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4906         (lookup_minimal_symbol_solib_trampoline): Likewise.
4907         * symfile.c (reread_symbols): Use foreach.
4908
4909 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4910             Tom Tromey  <tromey@adacore.com>
4911
4912         PR rust/24414:
4913         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4914         (rust_lex_int_test): Change "value" to be LONGEST.
4915         (rust_lex_tests): Add test for long integer literal.
4916
4917 2019-04-09  Tom Tromey  <tromey@adacore.com>
4918
4919         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4920         to bool.
4921         (extended_remote_target::attach): Update.
4922         (remote_target::remote_notice_new_inferior): Update.
4923         (remote_target::add_current_inferior_and_thread): Update.
4924         * inferior.c (exit_inferior_1): Use "false".
4925         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4926
4927 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4928
4929         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4930         the "start" command.
4931
4932 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4933
4934         * python/py-inferior.c (infpy_thread_from_thread_handle):
4935         Adjust comments to reflect renaming of thread_from_thread_handle
4936         to thread_from_handle.  Adjust keywords.  Fix type error message.
4937         (inferior_object_methods): Add thread_from_handle.  Retain
4938         thread_from_thread_handle, but mark it as deprecated.
4939
4940 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4941
4942         * gdbthread.h (find_thread_by_handle): Revise declaration.
4943         * thread.c (find_thread_by_handle): Likewise.  Adjust
4944         implementation too.
4945         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4946         support for buffer objects as handles.
4947
4948 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4949
4950         * python/py-infthread.c (thpy_thread_handle): New function.
4951         (thread_object_methods): Register thpy_thread_handle.
4952
4953 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4954
4955         * gdbthread.h (thread_to_thread_handle): Declare.
4956         * thread.c (gdbtypes.h): Include.
4957         (thread_to_thread_handle): New function.
4958
4959         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4960         (target_thread_info_to_thread_handle): Declare.
4961         * target.c (target_thread_info_to_thread_handle): New function.
4962         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4963         * target-delegates.c: Regenerate.
4964
4965         * linux-thread-db.c (class thread_db_target): Add method
4966         thread_info_to_thread_handle.
4967         (thread_db_target::thread_info_to_thread_handle): Define.
4968         * remote.c (class remote_target): Add new method
4969         thread_info_to_thread_handle.
4970         (remote_target::thread_info_to_thread_handle): Define.
4971
4972 2019-04-08  Pedro Alves  <palves@redhat.com>
4973
4974         * common/common-exceptions.c (throw_exception): Don't create
4975         named object to throw; throw directly.
4976         (throw_it): Likewise.  Don't initialize gdb_exception::message
4977         here, with new; pass FMT and AP to the ctor instead.
4978         * common/common-exceptions.h: Include <string>.
4979         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4980         const char *, va_list)): New ctor.  Use std::make_shared.
4981         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4982         errors)): Delete.
4983         (gdb_exception_error::gdb_exception_error(enum errors, const char
4984         *, va_list)): New.
4985         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4986         Add assertion.
4987         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4988         errors)): Delete.
4989         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4990         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4991         Add assertion.
4992
4993 2019-04-08  Tom Tromey  <tom@tromey.com>
4994
4995         * valops.c (value_rtti_indirect_type): Replace throw_exception
4996         with throw.
4997         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4998         with throw.
4999         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5000         throw.
5001         * target.c (target_translate_tls_address): Replace throw_exception
5002         with throw.
5003         * stack.c (frame_apply_command_count): Replace throw_exception
5004         with throw.
5005         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5006         throw.
5007         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5008         with throw.
5009         * rs6000-tdep.c (rs6000_frame_cache)
5010         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5011         * remote.c: Replace throw_exception with throw.
5012         * record-full.c (record_full_message, record_full_wait_1)
5013         (record_full_restore): Replace throw_exception with throw.
5014         * record-btrace.c:
5015         (get_thread_current_frame_id, record_btrace_start_replaying)
5016         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5017         (cmd_record_btrace_start): Replace throw_exception with throw.
5018         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5019         throw.
5020         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5021         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5022         * linespec.c:
5023         (find_linespec_symbols): Replace throw_exception with throw.
5024         * infrun.c (displaced_step_prepare, resume): Replace
5025         throw_exception with throw.
5026         * infcmd.c (post_create_inferior): Replace throw_exception with
5027         throw.
5028         * inf-loop.c (inferior_event_handler): Replace throw_exception
5029         with throw.
5030         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5031         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5032         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5033         (get_prev_frame_always, get_frame_pc_if_available)
5034         (get_frame_address_in_block_if_available, get_frame_language):
5035         Replace throw_exception with throw.
5036         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5037         throw_exception with throw.
5038         * eval.c (fetch_subexp_value, evaluate_var_value)
5039         (evaluate_funcall, evaluate_subexp_standard): Replace
5040         throw_exception with throw.
5041         * dwarf2loc.c (call_site_find_chain)
5042         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5043         Replace throw_exception with throw.
5044         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5045         with throw.
5046         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5047         throw.
5048         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5049         * completer.c (complete_line_internal): Replace throw_exception
5050         with throw.
5051         * compile/compile-object-run.c (compile_object_run): Replace
5052         throw_exception with throw.
5053         * cli/cli-script.c (process_next_line): Replace throw_exception
5054         with throw.
5055         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5056         (btrace_enable, btrace_maint_update_pt_packets): Replace
5057         throw_exception with throw.
5058         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5059         throw_exception with throw.
5060         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5061         throw_exception with throw.
5062         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5063         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5064         * aarch64-tdep.c (aarch64_make_prologue_cache)
5065         (aarch64_make_stub_cache): Replace throw_exception with throw.
5066
5067 2019-04-08  Tom Tromey  <tom@tromey.com>
5068
5069         * common/common-exceptions.c (throw_exception): Rename from
5070         throw_exception_cxx.  Remove old copy.  Make argument const.
5071         (throw_it): Create and throw exception objects directly.
5072         * common/common-exceptions.h (throw_exception): Make argument
5073         const.
5074         (struct gdb_exception_error): Add constructor.
5075         (struct gdb_exception_quit): Add constructor.
5076
5077 2019-04-08  Tom Tromey  <tom@tromey.com>
5078
5079         * common/common-exceptions.h (exception_rethrow): Don't declare.
5080         (TRY_SJLJ): Update comment.
5081         (TRY, CATCH, END_CATCH): Remove.
5082         * common/common-exceptions.c (exception_rethrow): Remove.
5083
5084 2019-04-08  Tom Tromey  <tom@tromey.com>
5085
5086         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5087         Remove.
5088         (gdb_exception_error): Rename from
5089         gdb_exception_RETURN_MASK_ERROR.
5090         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5091         (gdb_quit_bad_alloc): Update.
5092         * aarch64-tdep.c: Update.
5093         * ada-lang.c: Update.
5094         * ada-typeprint.c: Update.
5095         * ada-valprint.c: Update.
5096         * amd64-tdep.c: Update.
5097         * arch-utils.c: Update.
5098         * break-catch-throw.c: Update.
5099         * breakpoint.c: Update.
5100         * btrace.c: Update.
5101         * c-varobj.c: Update.
5102         * cli/cli-cmds.c: Update.
5103         * cli/cli-interp.c: Update.
5104         * cli/cli-script.c: Update.
5105         * common/common-exceptions.c: Update.
5106         * common/new-op.c: Update.
5107         * common/selftest.c: Update.
5108         * compile/compile-c-symbols.c: Update.
5109         * compile/compile-cplus-symbols.c: Update.
5110         * compile/compile-object-load.c: Update.
5111         * compile/compile-object-run.c: Update.
5112         * completer.c: Update.
5113         * corelow.c: Update.
5114         * cp-abi.c: Update.
5115         * cp-support.c: Update.
5116         * cp-valprint.c: Update.
5117         * darwin-nat.c: Update.
5118         * disasm-selftests.c: Update.
5119         * dtrace-probe.c: Update.
5120         * dwarf-index-cache.c: Update.
5121         * dwarf-index-write.c: Update.
5122         * dwarf2-frame-tailcall.c: Update.
5123         * dwarf2-frame.c: Update.
5124         * dwarf2loc.c: Update.
5125         * dwarf2read.c: Update.
5126         * eval.c: Update.
5127         * event-loop.c: Update.
5128         * event-top.c: Update.
5129         * exec.c: Update.
5130         * f-valprint.c: Update.
5131         * fbsd-tdep.c: Update.
5132         * frame-unwind.c: Update.
5133         * frame.c: Update.
5134         * gdbtypes.c: Update.
5135         * gnu-v3-abi.c: Update.
5136         * guile/guile-internal.h: Update.
5137         * guile/scm-block.c: Update.
5138         * guile/scm-breakpoint.c: Update.
5139         * guile/scm-cmd.c: Update.
5140         * guile/scm-disasm.c: Update.
5141         * guile/scm-frame.c: Update.
5142         * guile/scm-lazy-string.c: Update.
5143         * guile/scm-math.c: Update.
5144         * guile/scm-param.c: Update.
5145         * guile/scm-ports.c: Update.
5146         * guile/scm-pretty-print.c: Update.
5147         * guile/scm-symbol.c: Update.
5148         * guile/scm-symtab.c: Update.
5149         * guile/scm-type.c: Update.
5150         * guile/scm-value.c: Update.
5151         * i386-linux-tdep.c: Update.
5152         * i386-tdep.c: Update.
5153         * inf-loop.c: Update.
5154         * infcall.c: Update.
5155         * infcmd.c: Update.
5156         * infrun.c: Update.
5157         * jit.c: Update.
5158         * language.c: Update.
5159         * linespec.c: Update.
5160         * linux-fork.c: Update.
5161         * linux-nat.c: Update.
5162         * linux-tdep.c: Update.
5163         * linux-thread-db.c: Update.
5164         * main.c: Update.
5165         * mi/mi-cmd-break.c: Update.
5166         * mi/mi-cmd-stack.c: Update.
5167         * mi/mi-interp.c: Update.
5168         * mi/mi-main.c: Update.
5169         * objc-lang.c: Update.
5170         * p-valprint.c: Update.
5171         * parse.c: Update.
5172         * ppc-linux-tdep.c: Update.
5173         * printcmd.c: Update.
5174         * python/py-arch.c: Update.
5175         * python/py-breakpoint.c: Update.
5176         * python/py-cmd.c: Update.
5177         * python/py-finishbreakpoint.c: Update.
5178         * python/py-frame.c: Update.
5179         * python/py-framefilter.c: Update.
5180         * python/py-gdb-readline.c: Update.
5181         * python/py-inferior.c: Update.
5182         * python/py-infthread.c: Update.
5183         * python/py-lazy-string.c: Update.
5184         * python/py-linetable.c: Update.
5185         * python/py-objfile.c: Update.
5186         * python/py-param.c: Update.
5187         * python/py-prettyprint.c: Update.
5188         * python/py-progspace.c: Update.
5189         * python/py-record-btrace.c: Update.
5190         * python/py-record.c: Update.
5191         * python/py-symbol.c: Update.
5192         * python/py-type.c: Update.
5193         * python/py-unwind.c: Update.
5194         * python/py-utils.c: Update.
5195         * python/py-value.c: Update.
5196         * python/python.c: Update.
5197         * record-btrace.c: Update.
5198         * record-full.c: Update.
5199         * remote-fileio.c: Update.
5200         * remote.c: Update.
5201         * riscv-tdep.c: Update.
5202         * rs6000-aix-tdep.c: Update.
5203         * rs6000-tdep.c: Update.
5204         * rust-exp.y: Update.
5205         * rust-lang.c: Update.
5206         * s390-tdep.c: Update.
5207         * selftest-arch.c: Update.
5208         * solib-dsbt.c: Update.
5209         * solib-frv.c: Update.
5210         * solib-spu.c: Update.
5211         * solib-svr4.c: Update.
5212         * solib.c: Update.
5213         * sparc64-linux-tdep.c: Update.
5214         * stack.c: Update.
5215         * symfile-mem.c: Update.
5216         * symmisc.c: Update.
5217         * target.c: Update.
5218         * thread.c: Update.
5219         * top.c: Update.
5220         * tracefile-tfile.c: Update.
5221         * tui/tui.c: Update.
5222         * typeprint.c: Update.
5223         * unittests/cli-utils-selftests.c: Update.
5224         * unittests/parse-connection-spec-selftests.c: Update.
5225         * valops.c: Update.
5226         * valprint.c: Update.
5227         * value.c: Update.
5228         * varobj.c: Update.
5229         * windows-nat.c: Update.
5230         * x86-linux-nat.c: Update.
5231         * xml-support.c: Update.
5232
5233 2019-04-08  Tom Tromey  <tom@tromey.com>
5234
5235         * xml-support.c: Use C++ exception handling.
5236         * x86-linux-nat.c: Use C++ exception handling.
5237         * windows-nat.c: Use C++ exception handling.
5238         * varobj.c: Use C++ exception handling.
5239         * value.c: Use C++ exception handling.
5240         * valprint.c: Use C++ exception handling.
5241         * valops.c: Use C++ exception handling.
5242         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5243         handling.
5244         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5245         * typeprint.c: Use C++ exception handling.
5246         * tui/tui.c: Use C++ exception handling.
5247         * tracefile-tfile.c: Use C++ exception handling.
5248         * top.c: Use C++ exception handling.
5249         * thread.c: Use C++ exception handling.
5250         * target.c: Use C++ exception handling.
5251         * symmisc.c: Use C++ exception handling.
5252         * symfile-mem.c: Use C++ exception handling.
5253         * stack.c: Use C++ exception handling.
5254         * sparc64-linux-tdep.c: Use C++ exception handling.
5255         * solib.c: Use C++ exception handling.
5256         * solib-svr4.c: Use C++ exception handling.
5257         * solib-spu.c: Use C++ exception handling.
5258         * solib-frv.c: Use C++ exception handling.
5259         * solib-dsbt.c: Use C++ exception handling.
5260         * selftest-arch.c: Use C++ exception handling.
5261         * s390-tdep.c: Use C++ exception handling.
5262         * rust-lang.c: Use C++ exception handling.
5263         * rust-exp.y: Use C++ exception handling.
5264         * rs6000-tdep.c: Use C++ exception handling.
5265         * rs6000-aix-tdep.c: Use C++ exception handling.
5266         * riscv-tdep.c: Use C++ exception handling.
5267         * remote.c: Use C++ exception handling.
5268         * remote-fileio.c: Use C++ exception handling.
5269         * record-full.c: Use C++ exception handling.
5270         * record-btrace.c: Use C++ exception handling.
5271         * python/python.c: Use C++ exception handling.
5272         * python/py-value.c: Use C++ exception handling.
5273         * python/py-utils.c: Use C++ exception handling.
5274         * python/py-unwind.c: Use C++ exception handling.
5275         * python/py-type.c: Use C++ exception handling.
5276         * python/py-symbol.c: Use C++ exception handling.
5277         * python/py-record.c: Use C++ exception handling.
5278         * python/py-record-btrace.c: Use C++ exception handling.
5279         * python/py-progspace.c: Use C++ exception handling.
5280         * python/py-prettyprint.c: Use C++ exception handling.
5281         * python/py-param.c: Use C++ exception handling.
5282         * python/py-objfile.c: Use C++ exception handling.
5283         * python/py-linetable.c: Use C++ exception handling.
5284         * python/py-lazy-string.c: Use C++ exception handling.
5285         * python/py-infthread.c: Use C++ exception handling.
5286         * python/py-inferior.c: Use C++ exception handling.
5287         * python/py-gdb-readline.c: Use C++ exception handling.
5288         * python/py-framefilter.c: Use C++ exception handling.
5289         * python/py-frame.c: Use C++ exception handling.
5290         * python/py-finishbreakpoint.c: Use C++ exception handling.
5291         * python/py-cmd.c: Use C++ exception handling.
5292         * python/py-breakpoint.c: Use C++ exception handling.
5293         * python/py-arch.c: Use C++ exception handling.
5294         * printcmd.c: Use C++ exception handling.
5295         * ppc-linux-tdep.c: Use C++ exception handling.
5296         * parse.c: Use C++ exception handling.
5297         * p-valprint.c: Use C++ exception handling.
5298         * objc-lang.c: Use C++ exception handling.
5299         * mi/mi-main.c: Use C++ exception handling.
5300         * mi/mi-interp.c: Use C++ exception handling.
5301         * mi/mi-cmd-stack.c: Use C++ exception handling.
5302         * mi/mi-cmd-break.c: Use C++ exception handling.
5303         * main.c: Use C++ exception handling.
5304         * linux-thread-db.c: Use C++ exception handling.
5305         * linux-tdep.c: Use C++ exception handling.
5306         * linux-nat.c: Use C++ exception handling.
5307         * linux-fork.c: Use C++ exception handling.
5308         * linespec.c: Use C++ exception handling.
5309         * language.c: Use C++ exception handling.
5310         * jit.c: Use C++ exception handling.
5311         * infrun.c: Use C++ exception handling.
5312         * infcmd.c: Use C++ exception handling.
5313         * infcall.c: Use C++ exception handling.
5314         * inf-loop.c: Use C++ exception handling.
5315         * i386-tdep.c: Use C++ exception handling.
5316         * i386-linux-tdep.c: Use C++ exception handling.
5317         * guile/scm-value.c: Use C++ exception handling.
5318         * guile/scm-type.c: Use C++ exception handling.
5319         * guile/scm-symtab.c: Use C++ exception handling.
5320         * guile/scm-symbol.c: Use C++ exception handling.
5321         * guile/scm-pretty-print.c: Use C++ exception handling.
5322         * guile/scm-ports.c: Use C++ exception handling.
5323         * guile/scm-param.c: Use C++ exception handling.
5324         * guile/scm-math.c: Use C++ exception handling.
5325         * guile/scm-lazy-string.c: Use C++ exception handling.
5326         * guile/scm-frame.c: Use C++ exception handling.
5327         * guile/scm-disasm.c: Use C++ exception handling.
5328         * guile/scm-cmd.c: Use C++ exception handling.
5329         * guile/scm-breakpoint.c: Use C++ exception handling.
5330         * guile/scm-block.c: Use C++ exception handling.
5331         * guile/guile-internal.h: Use C++ exception handling.
5332         * gnu-v3-abi.c: Use C++ exception handling.
5333         * gdbtypes.c: Use C++ exception handling.
5334         * frame.c: Use C++ exception handling.
5335         * frame-unwind.c: Use C++ exception handling.
5336         * fbsd-tdep.c: Use C++ exception handling.
5337         * f-valprint.c: Use C++ exception handling.
5338         * exec.c: Use C++ exception handling.
5339         * event-top.c: Use C++ exception handling.
5340         * event-loop.c: Use C++ exception handling.
5341         * eval.c: Use C++ exception handling.
5342         * dwarf2read.c: Use C++ exception handling.
5343         * dwarf2loc.c: Use C++ exception handling.
5344         * dwarf2-frame.c: Use C++ exception handling.
5345         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5346         * dwarf-index-write.c: Use C++ exception handling.
5347         * dwarf-index-cache.c: Use C++ exception handling.
5348         * dtrace-probe.c: Use C++ exception handling.
5349         * disasm-selftests.c: Use C++ exception handling.
5350         * darwin-nat.c: Use C++ exception handling.
5351         * cp-valprint.c: Use C++ exception handling.
5352         * cp-support.c: Use C++ exception handling.
5353         * cp-abi.c: Use C++ exception handling.
5354         * corelow.c: Use C++ exception handling.
5355         * completer.c: Use C++ exception handling.
5356         * compile/compile-object-run.c: Use C++ exception handling.
5357         * compile/compile-object-load.c: Use C++ exception handling.
5358         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5359         * compile/compile-c-symbols.c: Use C++ exception handling.
5360         * common/selftest.c: Use C++ exception handling.
5361         * common/new-op.c: Use C++ exception handling.
5362         * cli/cli-script.c: Use C++ exception handling.
5363         * cli/cli-interp.c: Use C++ exception handling.
5364         * cli/cli-cmds.c: Use C++ exception handling.
5365         * c-varobj.c: Use C++ exception handling.
5366         * btrace.c: Use C++ exception handling.
5367         * breakpoint.c: Use C++ exception handling.
5368         * break-catch-throw.c: Use C++ exception handling.
5369         * arch-utils.c: Use C++ exception handling.
5370         * amd64-tdep.c: Use C++ exception handling.
5371         * ada-valprint.c: Use C++ exception handling.
5372         * ada-typeprint.c: Use C++ exception handling.
5373         * ada-lang.c: Use C++ exception handling.
5374         * aarch64-tdep.c: Use C++ exception handling.
5375
5376 2019-04-08  Tom Tromey  <tom@tromey.com>
5377
5378         * xml-support.c (gdb_xml_parser::parse): Update.
5379         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5380         * value.c (show_convenience): Update.
5381         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5382         (test_parse_flags_qcs): Update.
5383         * thread.c (thr_try_catch_cmd): Update.
5384         * target.c (target_translate_tls_address): Update.
5385         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5386         (info_frame_command_core, frame_apply_command_count): Update.
5387         * rust-exp.y (rust_lex_exception_test): Update.
5388         * riscv-tdep.c (riscv_print_one_register_info): Update.
5389         * remote.c (remote_target::enable_btrace): Update.
5390         * record-btrace.c (record_btrace_enable_warn): Update.
5391         * python/py-utils.c (gdbpy_convert_exception): Update.
5392         * printcmd.c (do_one_display, print_variable_and_value): Update.
5393         * mi/mi-main.c (mi_print_exception): Update.
5394         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5395         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5396         * linux-nat.c (linux_nat_target::attach): Update.
5397         * linux-fork.c (class scoped_switch_fork_info): Update.
5398         * infrun.c (displaced_step_prepare): Update.
5399         * infcall.c (call_function_by_hand_dummy): Update.
5400         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5401         * gnu-v3-abi.c (print_one_vtable): Update.
5402         * frame.c (get_prev_frame_always): Update.
5403         * f-valprint.c (info_common_command_for_block): Update.
5404         * exec.c (try_open_exec_file): Update.
5405         * exceptions.c (print_exception, exception_print)
5406         (exception_fprintf, exception_print_same): Update.
5407         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5408         * dwarf-index-cache.c (index_cache::store)
5409         (index_cache::lookup_gdb_index): Update.
5410         * darwin-nat.c (maybe_cache_shell): Update.
5411         * cp-valprint.c (cp_print_value_fields): Update.
5412         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5413         (gcc_cplus_symbol_address): Update.
5414         * compile/compile-c-symbols.c (gcc_convert_symbol)
5415         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5416         * common/selftest.c: Update.
5417         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5418         a std::string.
5419         (exception_try_scope_entry, exception_try_scope_exit): Don't
5420         declare.
5421         (struct exception_try_scope): Remove.
5422         (TRY): Don't use exception_try_scope.
5423         (struct gdb_exception): Add constructor, operator=.
5424         <what>: New method.
5425         (struct gdb_exception_RETURN_MASK_ALL)
5426         (struct gdb_exception_RETURN_MASK_ERROR)
5427         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5428         (struct gdb_quit_bad_alloc): Update.
5429         * common/common-exceptions.c (exception_none): Change
5430         initializer.
5431         (struct catcher) <state, exception>: Initialize inline.
5432         <prev>: Remove member.
5433         (current_catcher): Remove.
5434         (catchers): New global.
5435         (exceptions_state_mc_init): Simplify.
5436         (catcher_pop): Remove.
5437         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5438         (try_scope_depth, exception_try_scope_entry)
5439         (exception_try_scope_exit): Remove.
5440         (throw_exception_sjlj): Update.
5441         (exception_messages, exception_messages_size): Remove.
5442         (throw_it): Simplify.
5443         (gdb_exception_sliced_copy): Remove.
5444         (throw_exception_cxx): Update.
5445         * cli/cli-script.c (script_from_file): Update.
5446         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5447         Update.
5448         * ada-valprint.c (ada_val_print): Update.
5449         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5450         (create_excep_cond_exprs): Update.
5451
5452 2019-04-08  Tom Tromey  <tom@tromey.com>
5453
5454         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5455         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5456         (TRY, CATCH, END_CATCH): Remove some definitions.
5457         * common/common-exceptions.c: Don't use GDB_XCPT.
5458         (catcher_list_size): Remove.
5459         (throw_exception, throw_it): Simplify.
5460
5461 2019-04-05  Tom Tromey  <tom@tromey.com>
5462
5463         Revert the header-sorting patch.
5464         * ft32-tdep.c: Revert.
5465         * frv-tdep.c: Revert.
5466         * frv-linux-tdep.c: Revert.
5467         * frame.c: Revert.
5468         * frame-unwind.c: Revert.
5469         * frame-base.c: Revert.
5470         * fork-child.c: Revert.
5471         * findvar.c: Revert.
5472         * findcmd.c: Revert.
5473         * filesystem.c: Revert.
5474         * filename-seen-cache.h: Revert.
5475         * filename-seen-cache.c: Revert.
5476         * fbsd-tdep.c: Revert.
5477         * fbsd-nat.h: Revert.
5478         * fbsd-nat.c: Revert.
5479         * f-valprint.c: Revert.
5480         * f-typeprint.c: Revert.
5481         * f-lang.c: Revert.
5482         * extension.h: Revert.
5483         * extension.c: Revert.
5484         * extension-priv.h: Revert.
5485         * expprint.c: Revert.
5486         * exec.h: Revert.
5487         * exec.c: Revert.
5488         * exceptions.c: Revert.
5489         * event-top.c: Revert.
5490         * event-loop.c: Revert.
5491         * eval.c: Revert.
5492         * elfread.c: Revert.
5493         * dwarf2read.h: Revert.
5494         * dwarf2read.c: Revert.
5495         * dwarf2loc.c: Revert.
5496         * dwarf2expr.h: Revert.
5497         * dwarf2expr.c: Revert.
5498         * dwarf2-frame.c: Revert.
5499         * dwarf2-frame-tailcall.c: Revert.
5500         * dwarf-index-write.h: Revert.
5501         * dwarf-index-write.c: Revert.
5502         * dwarf-index-common.c: Revert.
5503         * dwarf-index-cache.h: Revert.
5504         * dwarf-index-cache.c: Revert.
5505         * dummy-frame.c: Revert.
5506         * dtrace-probe.c: Revert.
5507         * disasm.h: Revert.
5508         * disasm.c: Revert.
5509         * disasm-selftests.c: Revert.
5510         * dictionary.c: Revert.
5511         * dicos-tdep.c: Revert.
5512         * demangle.c: Revert.
5513         * dcache.h: Revert.
5514         * dcache.c: Revert.
5515         * darwin-nat.h: Revert.
5516         * darwin-nat.c: Revert.
5517         * darwin-nat-info.c: Revert.
5518         * d-valprint.c: Revert.
5519         * d-namespace.c: Revert.
5520         * d-lang.c: Revert.
5521         * ctf.c: Revert.
5522         * csky-tdep.c: Revert.
5523         * csky-linux-tdep.c: Revert.
5524         * cris-tdep.c: Revert.
5525         * cris-linux-tdep.c: Revert.
5526         * cp-valprint.c: Revert.
5527         * cp-support.c: Revert.
5528         * cp-namespace.c: Revert.
5529         * cp-abi.c: Revert.
5530         * corelow.c: Revert.
5531         * corefile.c: Revert.
5532         * continuations.c: Revert.
5533         * completer.h: Revert.
5534         * completer.c: Revert.
5535         * complaints.c: Revert.
5536         * coffread.c: Revert.
5537         * coff-pe-read.c: Revert.
5538         * cli-out.h: Revert.
5539         * cli-out.c: Revert.
5540         * charset.c: Revert.
5541         * c-varobj.c: Revert.
5542         * c-valprint.c: Revert.
5543         * c-typeprint.c: Revert.
5544         * c-lang.c: Revert.
5545         * buildsym.c: Revert.
5546         * buildsym-legacy.c: Revert.
5547         * build-id.h: Revert.
5548         * build-id.c: Revert.
5549         * btrace.c: Revert.
5550         * bsd-uthread.c: Revert.
5551         * breakpoint.h: Revert.
5552         * breakpoint.c: Revert.
5553         * break-catch-throw.c: Revert.
5554         * break-catch-syscall.c: Revert.
5555         * break-catch-sig.c: Revert.
5556         * blockframe.c: Revert.
5557         * block.c: Revert.
5558         * bfin-tdep.c: Revert.
5559         * bfin-linux-tdep.c: Revert.
5560         * bfd-target.c: Revert.
5561         * bcache.c: Revert.
5562         * ax-general.c: Revert.
5563         * ax-gdb.h: Revert.
5564         * ax-gdb.c: Revert.
5565         * avr-tdep.c: Revert.
5566         * auxv.c: Revert.
5567         * auto-load.c: Revert.
5568         * arm-wince-tdep.c: Revert.
5569         * arm-tdep.c: Revert.
5570         * arm-symbian-tdep.c: Revert.
5571         * arm-pikeos-tdep.c: Revert.
5572         * arm-obsd-tdep.c: Revert.
5573         * arm-nbsd-tdep.c: Revert.
5574         * arm-nbsd-nat.c: Revert.
5575         * arm-linux-tdep.c: Revert.
5576         * arm-linux-nat.c: Revert.
5577         * arm-fbsd-tdep.c: Revert.
5578         * arm-fbsd-nat.c: Revert.
5579         * arm-bsd-tdep.c: Revert.
5580         * arch-utils.c: Revert.
5581         * arc-tdep.c: Revert.
5582         * arc-newlib-tdep.c: Revert.
5583         * annotate.h: Revert.
5584         * annotate.c: Revert.
5585         * amd64-windows-tdep.c: Revert.
5586         * amd64-windows-nat.c: Revert.
5587         * amd64-tdep.c: Revert.
5588         * amd64-sol2-tdep.c: Revert.
5589         * amd64-obsd-tdep.c: Revert.
5590         * amd64-obsd-nat.c: Revert.
5591         * amd64-nbsd-tdep.c: Revert.
5592         * amd64-nbsd-nat.c: Revert.
5593         * amd64-nat.c: Revert.
5594         * amd64-linux-tdep.c: Revert.
5595         * amd64-linux-nat.c: Revert.
5596         * amd64-fbsd-tdep.c: Revert.
5597         * amd64-fbsd-nat.c: Revert.
5598         * amd64-dicos-tdep.c: Revert.
5599         * amd64-darwin-tdep.c: Revert.
5600         * amd64-bsd-nat.c: Revert.
5601         * alpha-tdep.c: Revert.
5602         * alpha-obsd-tdep.c: Revert.
5603         * alpha-nbsd-tdep.c: Revert.
5604         * alpha-mdebug-tdep.c: Revert.
5605         * alpha-linux-tdep.c: Revert.
5606         * alpha-linux-nat.c: Revert.
5607         * alpha-bsd-tdep.c: Revert.
5608         * alpha-bsd-nat.c: Revert.
5609         * aix-thread.c: Revert.
5610         * agent.c: Revert.
5611         * addrmap.c: Revert.
5612         * ada-varobj.c: Revert.
5613         * ada-valprint.c: Revert.
5614         * ada-typeprint.c: Revert.
5615         * ada-tasks.c: Revert.
5616         * ada-lang.c: Revert.
5617         * aarch64-tdep.c: Revert.
5618         * aarch64-ravenscar-thread.c: Revert.
5619         * aarch64-newlib-tdep.c: Revert.
5620         * aarch64-linux-tdep.c: Revert.
5621         * aarch64-linux-nat.c: Revert.
5622         * aarch64-fbsd-tdep.c: Revert.
5623         * aarch64-fbsd-nat.c: Revert.
5624         * aarch32-linux-nat.c: Revert.
5625
5626 2019-04-05  Tom Tromey  <tom@tromey.com>
5627
5628         * ft32-tdep.c: Sort headers.
5629         * frv-tdep.c: Sort headers.
5630         * frv-linux-tdep.c: Sort headers.
5631         * frame.c: Sort headers.
5632         * frame-unwind.c: Sort headers.
5633         * frame-base.c: Sort headers.
5634         * fork-child.c: Sort headers.
5635         * findvar.c: Sort headers.
5636         * findcmd.c: Sort headers.
5637         * filesystem.c: Sort headers.
5638         * filename-seen-cache.h: Sort headers.
5639         * filename-seen-cache.c: Sort headers.
5640         * fbsd-tdep.c: Sort headers.
5641         * fbsd-nat.h: Sort headers.
5642         * fbsd-nat.c: Sort headers.
5643         * f-valprint.c: Sort headers.
5644         * f-typeprint.c: Sort headers.
5645         * f-lang.c: Sort headers.
5646         * extension.h: Sort headers.
5647         * extension.c: Sort headers.
5648         * extension-priv.h: Sort headers.
5649         * expprint.c: Sort headers.
5650         * exec.h: Sort headers.
5651         * exec.c: Sort headers.
5652         * exceptions.c: Sort headers.
5653         * event-top.c: Sort headers.
5654         * event-loop.c: Sort headers.
5655         * eval.c: Sort headers.
5656         * elfread.c: Sort headers.
5657         * dwarf2read.h: Sort headers.
5658         * dwarf2read.c: Sort headers.
5659         * dwarf2loc.c: Sort headers.
5660         * dwarf2expr.h: Sort headers.
5661         * dwarf2expr.c: Sort headers.
5662         * dwarf2-frame.c: Sort headers.
5663         * dwarf2-frame-tailcall.c: Sort headers.
5664         * dwarf-index-write.h: Sort headers.
5665         * dwarf-index-write.c: Sort headers.
5666         * dwarf-index-common.c: Sort headers.
5667         * dwarf-index-cache.h: Sort headers.
5668         * dwarf-index-cache.c: Sort headers.
5669         * dummy-frame.c: Sort headers.
5670         * dtrace-probe.c: Sort headers.
5671         * disasm.h: Sort headers.
5672         * disasm.c: Sort headers.
5673         * disasm-selftests.c: Sort headers.
5674         * dictionary.c: Sort headers.
5675         * dicos-tdep.c: Sort headers.
5676         * demangle.c: Sort headers.
5677         * dcache.h: Sort headers.
5678         * dcache.c: Sort headers.
5679         * darwin-nat.h: Sort headers.
5680         * darwin-nat.c: Sort headers.
5681         * darwin-nat-info.c: Sort headers.
5682         * d-valprint.c: Sort headers.
5683         * d-namespace.c: Sort headers.
5684         * d-lang.c: Sort headers.
5685         * ctf.c: Sort headers.
5686         * csky-tdep.c: Sort headers.
5687         * csky-linux-tdep.c: Sort headers.
5688         * cris-tdep.c: Sort headers.
5689         * cris-linux-tdep.c: Sort headers.
5690         * cp-valprint.c: Sort headers.
5691         * cp-support.c: Sort headers.
5692         * cp-namespace.c: Sort headers.
5693         * cp-abi.c: Sort headers.
5694         * corelow.c: Sort headers.
5695         * corefile.c: Sort headers.
5696         * continuations.c: Sort headers.
5697         * completer.h: Sort headers.
5698         * completer.c: Sort headers.
5699         * complaints.c: Sort headers.
5700         * coffread.c: Sort headers.
5701         * coff-pe-read.c: Sort headers.
5702         * cli-out.h: Sort headers.
5703         * cli-out.c: Sort headers.
5704         * charset.c: Sort headers.
5705         * c-varobj.c: Sort headers.
5706         * c-valprint.c: Sort headers.
5707         * c-typeprint.c: Sort headers.
5708         * c-lang.c: Sort headers.
5709         * buildsym.c: Sort headers.
5710         * buildsym-legacy.c: Sort headers.
5711         * build-id.h: Sort headers.
5712         * build-id.c: Sort headers.
5713         * btrace.c: Sort headers.
5714         * bsd-uthread.c: Sort headers.
5715         * breakpoint.h: Sort headers.
5716         * breakpoint.c: Sort headers.
5717         * break-catch-throw.c: Sort headers.
5718         * break-catch-syscall.c: Sort headers.
5719         * break-catch-sig.c: Sort headers.
5720         * blockframe.c: Sort headers.
5721         * block.c: Sort headers.
5722         * bfin-tdep.c: Sort headers.
5723         * bfin-linux-tdep.c: Sort headers.
5724         * bfd-target.c: Sort headers.
5725         * bcache.c: Sort headers.
5726         * ax-general.c: Sort headers.
5727         * ax-gdb.h: Sort headers.
5728         * ax-gdb.c: Sort headers.
5729         * avr-tdep.c: Sort headers.
5730         * auxv.c: Sort headers.
5731         * auto-load.c: Sort headers.
5732         * arm-wince-tdep.c: Sort headers.
5733         * arm-tdep.c: Sort headers.
5734         * arm-symbian-tdep.c: Sort headers.
5735         * arm-pikeos-tdep.c: Sort headers.
5736         * arm-obsd-tdep.c: Sort headers.
5737         * arm-nbsd-tdep.c: Sort headers.
5738         * arm-nbsd-nat.c: Sort headers.
5739         * arm-linux-tdep.c: Sort headers.
5740         * arm-linux-nat.c: Sort headers.
5741         * arm-fbsd-tdep.c: Sort headers.
5742         * arm-fbsd-nat.c: Sort headers.
5743         * arm-bsd-tdep.c: Sort headers.
5744         * arch-utils.c: Sort headers.
5745         * arc-tdep.c: Sort headers.
5746         * arc-newlib-tdep.c: Sort headers.
5747         * annotate.h: Sort headers.
5748         * annotate.c: Sort headers.
5749         * amd64-windows-tdep.c: Sort headers.
5750         * amd64-windows-nat.c: Sort headers.
5751         * amd64-tdep.c: Sort headers.
5752         * amd64-sol2-tdep.c: Sort headers.
5753         * amd64-obsd-tdep.c: Sort headers.
5754         * amd64-obsd-nat.c: Sort headers.
5755         * amd64-nbsd-tdep.c: Sort headers.
5756         * amd64-nbsd-nat.c: Sort headers.
5757         * amd64-nat.c: Sort headers.
5758         * amd64-linux-tdep.c: Sort headers.
5759         * amd64-linux-nat.c: Sort headers.
5760         * amd64-fbsd-tdep.c: Sort headers.
5761         * amd64-fbsd-nat.c: Sort headers.
5762         * amd64-dicos-tdep.c: Sort headers.
5763         * amd64-darwin-tdep.c: Sort headers.
5764         * amd64-bsd-nat.c: Sort headers.
5765         * alpha-tdep.c: Sort headers.
5766         * alpha-obsd-tdep.c: Sort headers.
5767         * alpha-nbsd-tdep.c: Sort headers.
5768         * alpha-mdebug-tdep.c: Sort headers.
5769         * alpha-linux-tdep.c: Sort headers.
5770         * alpha-linux-nat.c: Sort headers.
5771         * alpha-bsd-tdep.c: Sort headers.
5772         * alpha-bsd-nat.c: Sort headers.
5773         * aix-thread.c: Sort headers.
5774         * agent.c: Sort headers.
5775         * addrmap.c: Sort headers.
5776         * ada-varobj.c: Sort headers.
5777         * ada-valprint.c: Sort headers.
5778         * ada-typeprint.c: Sort headers.
5779         * ada-tasks.c: Sort headers.
5780         * ada-lang.c: Sort headers.
5781         * aarch64-tdep.c: Sort headers.
5782         * aarch64-ravenscar-thread.c: Sort headers.
5783         * aarch64-newlib-tdep.c: Sort headers.
5784         * aarch64-linux-tdep.c: Sort headers.
5785         * aarch64-linux-nat.c: Sort headers.
5786         * aarch64-fbsd-tdep.c: Sort headers.
5787         * aarch64-fbsd-nat.c: Sort headers.
5788         * aarch32-linux-nat.c: Sort headers.
5789
5790 2019-04-04  Tom Tromey  <tom@tromey.com>
5791
5792         * varobj.c (varobj_create): Update.
5793         * rust-exp.y (struct rust_parser) <update_innermost_block,
5794         lookup_symbol>: New methods.
5795         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5796         Rename.
5797         (rust_parser::rust_lookup_type)
5798         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5799         * printcmd.c (display_command, do_one_display): Update.
5800         * parser-defs.h (struct parser_state) <parser_state>: Add
5801         "tracker" parameter.
5802         (block_tracker): New member.
5803         (class innermost_block_tracker) <innermost_block_tracker>: Add
5804         "types" parameter.
5805         <reset>: Remove method.
5806         (innermost_block): Don't declare.
5807         (null_post_parser): Update.
5808         * parse.c (innermost_block): Remove global.
5809         (write_dollar_variable): Update.
5810         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5811         Remove "tracker_types" parameter.
5812         (parse_expression): Add "tracker" parameter.
5813         (parse_expression_for_completion): Update.
5814         (null_post_parser): Add "tracker" parameter.
5815         * p-exp.y: Update rules.
5816         * m2-exp.y: Update rules.
5817         * language.h (struct language_defn) <la_post_parser>: Add
5818         "tracker" parameter.
5819         * go-exp.y: Update rules.
5820         * f-exp.y: Update rules.
5821         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5822         parameter.
5823         * d-exp.y: Update rules.
5824         * c-exp.y: Update rules.
5825         * breakpoint.c (set_breakpoint_condition): Create an
5826         innermost_block_tracker.
5827         (watch_command_1): Likewise.
5828         * ada-lang.c (resolve): Add "tracker" parameter.
5829         (resolve_subexp): Likewise.
5830         * ada-exp.y (write_var_from_sym): Update.
5831
5832 2019-04-04  Tom Tromey  <tom@tromey.com>
5833
5834         * type-stack.h: New file.
5835         * type-stack.c: New file.
5836         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5837         type-stack.h.
5838         (insert_into_type_stack, insert_type, push_type, push_type_int)
5839         (insert_type_address_space, pop_type, pop_type_int)
5840         (pop_typelist, pop_type_stack, append_type_stack)
5841         (push_type_stack, get_type_stack, push_typelist)
5842         (follow_type_instance_flags, follow_types): Don't declare.
5843         * parse.c (type_stack): Remove global.
5844         (parse_exp_in_context): Update.
5845         (insert_into_type_stack, insert_type, push_type, push_type_int)
5846         (insert_type_address_space, pop_type, pop_type_int)
5847         (pop_typelist, pop_type_stack, append_type_stack)
5848         (push_type_stack, get_type_stack, push_typelist)
5849         (follow_type_instance_flags, follow_types): Remove (moved to
5850         type-stack.c).
5851         * f-exp.y (type_stack): New global.
5852         Update rules.
5853         (push_kind_type, f_parse): Update.
5854         * d-exp.y (type_stack): New global.
5855         Update rules.
5856         (d_parse): Update.
5857         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5858         Update rules.
5859         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5860         (HFILES_NO_SRCDIR): Add type-stack.h.
5861
5862 2019-04-04  Tom Tromey  <tom@tromey.com>
5863
5864         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5865         (rust_parser::convert_ast_to_expression, rust_parse)
5866         (rust_lex_test_completion, rust_lex_tests): Update.
5867         * parser-defs.h (struct expr_completion_state): New.
5868         (struct parser_state) <parser_state>: Add completion parameter.
5869         <mark_struct_expression, mark_completion_tag>: New methods.
5870         <parse_completion, m_completion_state>: New members.
5871         (prefixify_expression, null_post_parser): Update.
5872         (mark_struct_expression, mark_completion_tag): Don't declare.
5873         * parse.c (parse_completion, expout_last_struct)
5874         (expout_tag_completion_type, expout_completion_name): Remove
5875         globals.
5876         (parser_state::mark_struct_expression)
5877         (parser_state::mark_completion_tag): Now methods.
5878         (prefixify_expression): Add last_struct parameter.
5879         (prefixify_subexp): Likewise.
5880         (parse_exp_1): Update.
5881         (parse_exp_in_context): Add cstate parameter.  Update.
5882         (parse_expression_for_completion): Create an
5883         expr_completion_state.
5884         (null_post_parser): Add "completion" parameter.
5885         * p-exp.y: Update rules.
5886         (yylex): Update.
5887         * language.h (struct language_defn) <la_post_parser>: Add
5888         "completing" parameter.
5889         * go-exp.y: Update rules.
5890         (lex_one_token): Update.
5891         * expression.h (parse_completion): Don't declare.
5892         * d-exp.y: Update rules.
5893         (lex_one_token): Update rules.
5894         * c-exp.y: Update rules.
5895         (lex_one_token): Update.
5896         * ada-lang.c (resolve): Add "parse_completion" parameter.
5897         (resolve_subexp): Likewise.
5898         (ada_resolve_function): Likewise.
5899
5900 2019-04-04  Tom Tromey  <tom@tromey.com>
5901
5902         * parser-defs.h (struct parser_state) <start_arglist,
5903         end_arglist>: New methods.
5904         <arglist_len, m_funcall_chain>: New members.
5905         (arglist_len, start_arglist, end_arglist): Don't declare.
5906         * parse.c (arglist_len, funcall_chain): Remove global.
5907         (start_arglist, end_arglist): Remove functions.
5908         (parse_exp_in_context): Update.
5909         * p-exp.y: Update rules.
5910         * m2-exp.y: Update rules.
5911         * go-exp.y: Update rules.
5912         * f-exp.y: Update rules.
5913         * d-exp.y: Update rules.
5914         * c-exp.y: Update rules.
5915
5916 2019-04-04  Tom Tromey  <tom@tromey.com>
5917
5918         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5919         lex_operator, push_back>: New methods.
5920         Update all rules.
5921         (rust_parser::lex_hex, lex_escape): Rename and update.
5922         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5923         (rust_parser::lex_operator): Rename and update.
5924         (rust_parser::lex_number, rustyylex, rustyyerror)
5925         (rust_lex_test_init, rust_lex_test_sequence)
5926         (rust_lex_test_push_back, rust_lex_tests): Update.
5927         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5928         parameter.
5929         <lexptr, prev_lexptr>: New members.
5930         (lexptr, prev_lexptr): Don't declare.
5931         * parse.c (lexptr, prev_lexptr): Remove globals.
5932         (parse_exp_in_context): Update.
5933         * p-exp.y (yylex, yyerror): Update.
5934         * m2-exp.y (parse_number, yylex, yyerror): Update.
5935         * go-exp.y (lex_one_token, yyerror): Update.
5936         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5937         * d-exp.y (lex_one_token, yyerror): Update.
5938         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5939         (lex_one_token, yyerror): Update.
5940         * ada-lex.l (YY_INPUT): Update.
5941         (rewind_to_char): Update.
5942         * ada-exp.y (yyerror): Update.
5943
5944 2019-04-04  Tom Tromey  <tom@tromey.com>
5945
5946         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5947         * parser-defs.h (struct parser_state) <parser_state>: Add new
5948         parameter.
5949         <comma_terminates>: New member.
5950         (comma_terminates): Don't declare global.
5951         * parse.c (comma_terminates): Remove global.
5952         (parse_exp_in_context): Update.
5953         * p-exp.y (yylex): Update.
5954         * m2-exp.y (yylex): Update.
5955         * go-exp.y (lex_one_token): Update.
5956         * f-exp.y (yylex): Update.
5957         * d-exp.y (lex_one_token): Update.
5958         * c-exp.y (lex_one_token): Update.
5959         * ada-lex.l: Update.
5960
5961 2019-04-04  Tom Tromey  <tom@tromey.com>
5962
5963         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5964         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5965         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5966         * parser-defs.h (paren_depth): Don't declare.
5967         * parse.c (paren_depth): Remove global.
5968         (parse_exp_in_context): Update.
5969         * p-exp.y (paren_depth): New global.
5970         (pascal_parse): Initialize it.
5971         * m2-exp.y (paren_depth): New global.
5972         (m2_parse): Initialize it.
5973         * go-exp.y (paren_depth): New global.
5974         (go_parse): Initialize it.
5975         * f-exp.y (paren_depth): New global.
5976         (f_parse): Initialize it.
5977         * d-exp.y (paren_depth): New global.
5978         (d_parse): Initialize it.
5979         * c-exp.y (paren_depth): New global.
5980         (c_parse): Initialize it.
5981         * ada-lex.l (paren_depth): New global.
5982         (lexer_init): Initialize it.
5983
5984 2019-04-04  Tom Tromey  <tom@tromey.com>
5985
5986         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5987         (rust_parser::convert_ast_to_type)
5988         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5989         * parser-defs.h (struct parser_state) <parser_state>: Add
5990         parameters.  Initialize new members.
5991         <expression_context_block, expression_context_pc>: New members.
5992         * parse.c (expression_context_block, expression_context_pc):
5993         Remove globals.
5994         (parse_exp_in_context): Update.
5995         * p-exp.y: Update all rules.
5996         (yylex): Update.
5997         * m2-exp.y: Update all rules.
5998         (yylex): Update.
5999         * go-exp.y (yylex): Update.
6000         * f-exp.y (yylex): Update.
6001         * d-exp.y: Update all rules.
6002         (yylex): Update.
6003         * c-exp.y: Update all rules.
6004         (lex_one_token, classify_name, yylex, c_parse): Update.
6005         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6006
6007 2019-04-04  Tom Tromey  <tom@tromey.com>
6008
6009         * gdbarch.h, gdbarch.c: Rebuild.
6010         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6011         * stap-probe.h:
6012         (struct stap_parse_info): Replace "parser_state" with
6013         "expr_builder".
6014         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6015         (parser_state): New class.
6016         * parse.c (expr_builder): Rename.
6017         (expr_builder::release): Rename.
6018         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6019         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6020         (write_exp_elt_longcst, write_exp_elt_floatcst)
6021         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6022         (write_exp_string_vector, write_exp_bitstring)
6023         (write_exp_msymbol, mark_struct_expression)
6024         (write_dollar_variable)
6025         (insert_type_address_space, increase_expout_size): Replace
6026         "parser_state" with "expr_builder".
6027         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6028         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6029         "parser_state" with "expr_builder".
6030
6031 2019-04-04  Tom Tromey  <tom@tromey.com>
6032
6033         * rust-exp.y: Replace "parse_language" with method call.
6034         * p-exp.y:
6035         (yylex): Replace "parse_language" with method call.
6036         * m2-exp.y:
6037         (yylex): Replace "parse_language" with method call.
6038         * go-exp.y (classify_name): Replace "parse_language" with method
6039         call.
6040         * f-exp.y (yylex): Replace "parse_language" with method call.
6041         * d-exp.y (lex_one_token): Replace "parse_language" with method
6042         call.
6043         * c-exp.y:
6044         (lex_one_token, classify_name, yylex): Replace "parse_language"
6045         with method call.
6046         * ada-exp.y (find_primitive_type, type_char)
6047         (type_system_address): Replace "parse_language" with method call.
6048
6049 2019-04-04  Tom Tromey  <tom@tromey.com>
6050
6051         * rust-exp.y: Replace "parse_gdbarch" with method call.
6052         * parse.c (write_dollar_variable, insert_type_address_space):
6053         Replace "parse_gdbarch" with method call.
6054         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6055         call.
6056         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6057         call.
6058         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6059         "parse_gdbarch" with method call.
6060         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6061         with method call.
6062         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6063         "parse_gdbarch" with method call.
6064         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6065         "parse_gdbarch" with method call.
6066         * c-exp.y (parse_type, parse_number, classify_name): Replace
6067         "parse_gdbarch" with method call.
6068         * ada-lex.l: Replace "parse_gdbarch" with method call.
6069         * ada-exp.y (parse_type, find_primitive_type, type_char)
6070         (type_system_address): Replace "parse_gdbarch" with method call.
6071
6072 2019-04-04  Tom Tromey  <tom@tromey.com>
6073
6074         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6075         * stap-probe.c (stap_parse_argument): Update.
6076         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6077         initial_size parameter.
6078         * rust-exp.y (rust_lex_tests): Update.
6079         * parse.c (parser_state): Update.
6080         (parse_exp_in_context): Update.
6081         * parser-defs.h (struct parser_state) <parser_state>: Remove
6082         "initial_size" parameter.
6083
6084 2019-04-04  Tom Tromey  <tom@tromey.com>
6085
6086         * parser-defs.h (increase_expout_size): Don't declare.
6087         * parse.c (increase_expout_size): Now static.
6088
6089 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6090
6091         * gnu-nat.c (gnu_nat_target::wait): Fix
6092         target_waitstatus_to_string call.
6093
6094 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6095
6096         * eval.c (evaluate_subexp_standard): Handle internal functions
6097         during Fortran function call handling.
6098
6099 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6100
6101         * NEWS: Mention new internal functions.
6102         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6103         (read_base_type): Use dwarf2_init_complex_target_type.
6104         * value.c (creal_internal_fn): New function.
6105         (cimag_internal_fn): New function.
6106         (_initialize_values): Register new internal functions.
6107
6108 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6109
6110         * infrun.c (stop_all_threads): If debug_infrun, always
6111         trace the wait status after wait_one, using
6112         target_waitstatus_to_string and target_pid_to_str.
6113         (handle_inferior_event): Replace various trace of
6114         wait status kind by a single trace.
6115         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6116         wait status kind image by target_waitstatus_to_string.
6117         * target/waitstatus.c (target_waitstatus_to_string): Fix
6118         obsolete comment.
6119
6120 2019-04-01  Tom Tromey  <tromey@adacore.com>
6121
6122         PR symtab/23331:
6123         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6124
6125 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6126             Pedro Alves  <palves@redhat.com>
6127
6128         * top.c (quit_force): Call 'finalize_values'.
6129         * value.c (finalize_values): New function.
6130         * value.h (finalize_values): Declare.
6131
6132 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6133
6134         * NEWS: Announce $_gdb_major and $_gdb_minor.
6135
6136         * top.c (init_gdb_version_vars): New function.
6137         (gdb_init): Call init_gdb_version_vars.
6138
6139 2019-03-29  Tom Tromey  <tromey@adacore.com>
6140
6141         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6142         help text.  Remove dead code.
6143
6144 2019-03-29  Keith Seitz  <keiths@redhat.com>
6145
6146         From Siddhesh Poyarekar:
6147         * f-lang.h (f77_get_upperbound): Return LONGEST.
6148         (f77_get_lowerbound): Likewise.
6149         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6150         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6151         print them.
6152         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6153         plongest to format print it.
6154         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6155         (f77_get_upperbound): Likewise.
6156         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6157         LOWER_BOUND to LONGEST.
6158         (f77_create_arrayprint_offset_tbl): Likewise.
6159
6160 2019-03-29  Keith Seitz  <keiths@redhat.com>
6161
6162         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6163         %s/pulongest for TYPE_LENGTH instead of %d in format
6164         strings.
6165         * ada-typerint.c (ada_print_type): Likewise.
6166         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6167         * compile/compile-c-support.c (generate_register_struct): Likewise.
6168         * gdbtypes.c (recursive_dump_type): Likewise.
6169         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6170         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6171         instead of %d in format strings.
6172         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6173         to std::min to ULONGEST.
6174         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6175         instead of %d in format strings.
6176         * tracepoint.c (info_scope_command): Likewise.
6177         * typeprint.c (print_offset_data::update)
6178         (print_offset_data::finish): Likewise.
6179         * xtensa-tdep.c (xtensa_store_return_value)
6180         (xtensa_push_dummy_call): Likewise.
6181
6182 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6183
6184         * windows-nat.c (display_selector): Fixed format specifications
6185         for 64-bit Cygwin.
6186
6187 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6188
6189         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6190
6191 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6192
6193         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6194         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6195         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6196         (nios2_linux_init_abi): Install it.
6197
6198 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6199
6200         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6201
6202 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6203
6204         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6205
6206 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6207             Tom Tromey  <tromey@adacore.com>
6208
6209         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6210
6211 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6212
6213         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6214         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6215         method to compute the bounds of range types. Also print "[evaluated]"
6216         if the bounds' values come from a dynamic evaluation.
6217
6218 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6221         whitespace when pretty printing is on.
6222
6223 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6224
6225         * ppc-linux-nat.c: Add include.
6226
6227 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6228
6229         * NEWS: Mention AArch64 Pointer Authentication.
6230
6231 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6232
6233         * arm-linux-nat.c: Add include.
6234
6235 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6236
6237         * source-cache.c (source_cache::get_source_lines): Re-read
6238         fullname after calling open_source_file.
6239
6240 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6241
6242         * NEWS: Mention TLS support for FreeBSD.
6243
6244 2019-03-25  Tom Tromey  <tromey@adacore.com>
6245
6246         * minsyms.c (BUNCH_SIZE): Update comment.
6247         (~minimal_symbol_reader): Remove old comment.
6248         (compact_minimal_symbols): Update comment.
6249         (minimal_symbol_reader::install): Remove old comment.  Update
6250         other comments.
6251
6252 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6253
6254         * s390-linux-nat.c: Add include.
6255
6256 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6257
6258         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6259         Call linux_get_hwcap.
6260         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6261         Likewise.
6262         (aarch64_linux_get_hwcap): Remove function.
6263         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6264         declaration.
6265         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6266         linux_get_hwcap.
6267         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6268         * linux-tdep.c (linux_get_hwcap): Add function.
6269         (linux_get_hwcap2): Likewise.
6270         * linux-tdep.h (linux_get_hwcap): Add declaration.
6271         (linux_get_hwcap2): Likewise.
6272         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6273         (ppc_linux_get_hwcap2): Likewise.
6274         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6275         linux_get_hwcap.
6276         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6277         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6278         (ppc_linux_nat_target::read_description): Likewise.
6279         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6280         * s390-linux-nat.c: Likewise.
6281         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6282
6283 2019-03-24  Tom Tromey  <tom@tromey.com>
6284
6285         * ada-lang.c (standard_lookup): Simplify initialization.
6286         (ada_lookup_symbol_nonlocal): Simplify return.
6287         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6288         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6289         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6290         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6291         initialization.
6292         * solib.c (solib_global_lookup): Simplify.
6293         * symtab.c (null_block_symbol): Remove.
6294         (symbol_cache_lookup): Simplify returns.
6295         (lookup_language_this): Simplify returns.
6296         (lookup_symbol_aux): Simplify return.
6297         (lookup_local_symbol): Simplify returns.
6298         (lookup_global_symbol_from_objfile): Simplify return.
6299         (lookup_symbol_in_objfile_symtabs)
6300         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6301         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6302         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6303         * cp-namespace.c (cp_lookup_bare_symbol)
6304         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6305         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6306         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6307         (cp_lookup_symbol_via_imports): Simplify initialization.
6308         (find_symbol_in_baseclass): Likewise.
6309         * symtab.h (null_block_symbol): Remove.
6310         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6311         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6312         (d_lookup_symbol_module): Likewise.
6313         (find_symbol_in_baseclass): Simplify initialization.
6314
6315 2019-03-24  Tom Tromey  <tom@tromey.com>
6316
6317         * expression.h: Don't include symtab.h.
6318         (struct block): Forward declare.
6319
6320 2019-03-24  Tom Tromey  <tom@tromey.com>
6321
6322         * c-exp.y (typebase): Remove casts.
6323         * gdbtypes.c (lookup_unsigned_typename, )
6324         (lookup_signed_typename): Remove cast.
6325         * eval.c (parse_to_comma_and_eval): Remove cast.
6326         * parse.c (write_dollar_variable): Remove cast.
6327         * block.h (struct block) <superblock>: Now const.
6328         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6329         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6330         (map_block): Make "block" const.
6331         * symfile.h (struct quick_symbol_functions)
6332         <map_matching_symbols>: Constify block argument to "callback".
6333         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6334         const.
6335         (find_pc_sect_compunit_symtab): Make "b" const.
6336         (find_symbol_at_address): Likewise.
6337         (search_symbols): Likewise.
6338         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6339         (dw2_debug_names_lookup_symbol): Likewise.
6340         (dw2_map_matching_symbols): Update.
6341         * p-valprint.c (pascal_val_print): Remove "block".
6342         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6343         (aux_add_nonlocal_symbols): Make "block" const.
6344         (resolve_subexp): Remove cast.
6345         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6346         const.
6347         (iterate_over_file_blocks): Likewise.
6348         * f-exp.y (%union) <bval>: Remove.
6349         * coffread.c (patch_opaque_types): Make "b" const.
6350         * spu-tdep.c (spu_catch_start): Make "block" const.
6351         * c-valprint.c (print_unpacked_pointer): Remove "block".
6352         * symmisc.c (dump_symtab_1): Make "b" const.
6353         (block_depth): Make "block" const.
6354         * d-exp.y (%union) <bval>: Remove.
6355         * cp-support.h (cp_lookup_rtti_type): Update.
6356         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6357         * psymtab.c (psym_lookup_symbol): Make "block" const.
6358         (maintenance_check_psymtabs): Make "b" const.
6359         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6360         (enumerate_locals, enumerate_args): Update.
6361         * python/py-symtab.c (stpy_global_block): Make "block" const.
6362         (stpy_static_block): Likewise.
6363         * inline-frame.c (block_starting_point_at): Make "new_block"
6364         const.
6365         * block.c (find_block_in_blockvector): Make return type const.
6366         (blockvector_for_pc_sect): Make "b" const.
6367         (find_block_in_blockvector): Make "b" const.
6368
6369 2019-03-23  Tom Tromey  <tom@tromey.com>
6370
6371         * varobj.c (varobj_create): Update.
6372         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6373         * printcmd.c (display_command, do_one_display): Don't reset
6374         innermost_block.
6375         * parser-defs.h (enum innermost_block_tracker_type): Move to
6376         expression.h.
6377         (innermost_block): Update comment.
6378         * parse.c (parse_exp_1): Add tracker_types parameter.
6379         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6380         tracker_types parameter.  Reset innermost_block.
6381         (parse_exp_in_context): Remove.
6382         (parse_expression_for_completion): Update.
6383         * objfiles.c (~objfile): Don't reset expression_context_block or
6384         innermost_block.
6385         * expression.h (enum innermost_block_tracker_type): Move from
6386         parser-defs.h.
6387         (parse_exp_1): Add tracker_types parameter.
6388         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6389         reset innermost_block.
6390
6391 2019-03-23  Tom Tromey  <tom@tromey.com>
6392
6393         * objfiles.h: Include bcache.h.
6394
6395 2019-03-23  Tom Tromey  <tom@tromey.com>
6396
6397         * linespec.c (get_current_search_block): Use
6398         scoped_restore_current_language.
6399         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6400
6401 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6402             Jiong Wang  <jiong.wang@arm.com>
6403
6404         * aarch64-linux-tdep.c
6405         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6406         section.
6407         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6408
6409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6410             Jiong Wang  <jiong.wang@arm.com>
6411
6412         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6413         instructions.
6414         (aarch64_analyze_prologue_test): Add PACIASP test.
6415         (aarch64_prologue_prev_register): Unmask PC value.
6416
6417 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6418             Jiong Wang  <jiong.wang@arm.com>
6419
6420         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6421         (aarch64_dwarf2_prev_register): Unmask PC value.
6422         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6423         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6424         DW_CFA_AARCH64_negate_ra_state.
6425         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6426
6427 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6428             Jiong Wang  <jiong.wang@arm.com>
6429
6430         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6431         registers.
6432         (aarch64_pseudo_register_name): Likewise.
6433         (aarch64_pseudo_register_type): Likewise.
6434         (aarch64_pseudo_register_reggroup_p): Likewise.
6435         (aarch64_gdbarch_init): Add pauth registers.
6436         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6437         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6438         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6439         (struct gdbarch_tdep): Add regnum for ra_state.
6440
6441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6442             Jiong Wang  <jiong.wang@arm.com>
6443
6444         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6445
6446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6447             Jiong Wang  <jiong.wang@arm.com>
6448
6449         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6450         function.
6451         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6452         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6453         (aarch64_gdbarch_init): Add puth registers.
6454         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6455         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6456         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6457
6458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6459             Jiong Wang  <jiong.wang@arm.com>
6460
6461         * aarch64-linux-nat.c
6462         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6463         * aarch64-linux-tdep.c
6464         (aarch64_linux_core_read_description): Likewise.
6465         (aarch64_linux_get_hwcap): New function.
6466         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6467         (aarch64_linux_get_hwcap): New declaration.
6468
6469 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6470             Jiong Wang  <jiong.wang@arm.com>
6471
6472         * aarch64-linux-nat.c
6473         (aarch64_linux_nat_target::read_description): Add pauth param.
6474         * aarch64-linux-tdep.c
6475         (aarch64_linux_core_read_description): Likewise.
6476         * aarch64-tdep.c (struct target_desc): Add in pauth.
6477         (aarch64_read_description): Add pauth param.
6478         (aarch64_gdbarch_init): Likewise.
6479         * aarch64-tdep.h (aarch64_read_description): Likewise.
6480         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6481         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6482         * features/Makefile: Add new files.
6483         * features/aarch64-pauth.c: New file.
6484         * features/aarch64-pauth.xml: New file.
6485
6486 2019-03-20  Tom Tromey  <tromey@adacore.com>
6487
6488         * infrun.c (handle_inferior_event): Rename from
6489         handle_inferior_event_1.  Create a scoped_value_mark.
6490         (handle_inferior_event): Remove.
6491
6492 2019-03-19  Tom Tromey  <tromey@adacore.com>
6493
6494         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6495         * infrun.h (print_stop_event): Add "displays" parameter.
6496         * infrun.c (print_stop_event): Add "displays" parameter.
6497
6498 2019-03-19  Pedro Alves  <palves@redhat.com>
6499
6500         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6501         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6502         to -1.  Fix TABs vs spaces.
6503         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6504         * tui/tui-out.h (tui_ui_out) Add intro comments.
6505         <m_line, m_start_of_line>: In-class initialize, and add describing
6506         comment.
6507
6508 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6509
6510         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6511         variable names.
6512         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6513
6514 2019-03-18  Pedro Alves  <palves@redhat.com>
6515             Eli Zaretskii <eliz@gnu.org>
6516
6517         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6518         m_line and m_start_of_line.
6519
6520 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6521
6522         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6523         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6524         it returns a newline.  This fixes a regression in TU mode, whereby
6525         the next line is output on the same screen line as the user input.
6526
6527 2019-03-18  Tom Tromey  <tromey@adacore.com>
6528
6529         * minsyms.c (minimal_symbol_reader::install): Remove call to
6530         obstack_blank.
6531
6532 2019-03-18  Pedro Alves  <palves@redhat.com>
6533
6534         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6535         New globals.
6536         (apply_style): New, factored out from ...
6537         (apply_ansi_escape): ... this.  Handle reverse video mode.
6538         (tui_set_reverse_mode): New function.
6539         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6540         * tui/tui-winsource.c (tui_show_source_line): Use
6541         tui_set_reverse_mode instead of setting A_STANDOUT.
6542         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6543         New setter methods.
6544
6545 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6546
6547         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6548         Handle tabs.
6549
6550 2019-03-18  Tom Tromey  <tromey@adacore.com>
6551
6552         * ada-lang.c (empty_array): Add "high" parameter.
6553         (ada_evaluate_subexp): Update.
6554
6555 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6556
6557         * unittests/string_view-selftests.c: Define
6558         _initialize_string_view_selftests unconditionally.
6559
6560 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6561
6562         PR gdb/24350
6563         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6564
6565 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6566
6567         PR gdb/24351
6568         * windows-nat.c (display_selector): Fix format specifiers.
6569
6570 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6571
6572         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6573         tui_refill_source_window instead of tui_refresh_win, to update the
6574         current execution line.  This fixes redisplay of the current line
6575         when stepping through the code with "next" or "step".
6576
6577 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6578
6579         * source-cache.c (source_cache::get_source_lines): Call
6580         find_source_lines to initialize s->nlines.  This fixes vertical
6581         scrolling of TUI source window when the DOWN arrow is pressed.
6582
6583 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6584
6585         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6586         linux-thread-db.c (_initialize_thread_db): Likewise.
6587
6588 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6589
6590         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6591         wclrtoeol in tui_show_source_line".  This reverts changes made in
6592         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6593
6594 2019-03-15  Tom Tromey  <tom@tromey.com>
6595
6596         * symtab.h (struct minimal_symbol): Derive from
6597         general_symbol_info.
6598         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6599         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6600         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6601         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6602         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6603         (MSYMBOL_SEARCH_NAME): Update.
6604         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6605         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6606         * minsyms.c (minimal_symbol_reader::record_full): Update.
6607
6608 2019-03-15  Tom Tromey  <tom@tromey.com>
6609
6610         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6611
6612 2019-03-15  Tom Tromey  <tom@tromey.com>
6613
6614         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6615         unique_xmalloc_ptr.
6616         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6617         Update.
6618         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6619         (build_minimal_symbol_hash_tables)
6620         (minimal_symbol_reader::install): Update.
6621
6622 2019-03-15  Tom Tromey  <tom@tromey.com>
6623
6624         * symtab.c (create_demangled_names_hash): Update.
6625         (symbol_set_names): Update.
6626         * objfiles.h (struct objfile_per_bfd_storage)
6627         <demangled_names_hash>: Now an htab_up.
6628         * objfiles.c (objfile_per_bfd_storage): Simplify.
6629
6630 2019-03-15  Tom Tromey  <tom@tromey.com>
6631
6632         * objfiles.h (struct objfile_per_bfd_storage): Declare
6633         destructor.
6634         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6635         New.
6636         (get_objfile_bfd_data): Use new.  Don't initialize
6637         language_of_main.
6638         (free_objfile_per_bfd_storage): Remove.
6639         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6640
6641 2019-03-15  Tom Tromey  <tom@tromey.com>
6642
6643         * symfile.c (reread_symbols): Update.
6644         * objfiles.c (objfile::objfile): Update.
6645         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6646         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6647         comment.
6648         (minimal_symbol_reader::install): Update.
6649         (terminate_minimal_symbol_table): Remove.
6650         * jit.c (jit_object_close_impl): Update.
6651
6652 2019-03-15  Tom Tromey  <tom@tromey.com>
6653
6654         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6655         initializations.
6656
6657 2019-03-15  Tom Tromey  <tom@tromey.com>
6658
6659         * objfiles.h (struct objfile_per_bfd_storage)
6660         <demangled_hash_languages>: Now a bitset.
6661         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6662         (lookup_minimal_symbol): Update.
6663
6664 2019-03-15  Tom Tromey  <tom@tromey.com>
6665
6666         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6667         Don't return the symbol.
6668         * coffread.c (record_minimal_symbol): Use record_full.
6669
6670 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6671
6672         The MS-Windows port of ncurses fails to switch to a color pair if
6673         one or both of the colors are the implicit default colors.  This
6674         change records the default colors when TUI is initialized, and
6675         then specifies them explicitly when a color pair uses the default
6676         colors.  This allows color styling in TUI mode on MS-Windows.
6677
6678         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6679         ncurses_norm_attr.
6680         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6681         colors in ncurses_norm_attr.
6682         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6683         "none", replace it with the default color recorded in
6684         ncurses_norm_attr.
6685
6686 2019-03-14  Tom Tromey  <tromey@adacore.com>
6687
6688         * source-cache.h (class source_cache) <get_source_lines>: Return
6689         std::string.
6690         * source-cache.c (source_cache::extract_lines): Handle case where
6691         first_pos==npos.  Return std::string.
6692         (source_cache::get_source_lines): Update.
6693
6694 2019-03-14  Tom Tromey  <tromey@adacore.com>
6695
6696         * NEWS: Add item for "style sources" commands.
6697         * source-cache.c (source_cache::get_source_lines): Check
6698         source_styling.
6699         * cli/cli-style.c (source_styling): New global.
6700         (_initialize_cli_style): Add "style sources" commands.
6701         (show_style_sources): New function.
6702         * cli/cli-style.h (source_styling): Declare.
6703
6704 2019-03-14  Pedro Alves  <palves@redhat.com>
6705             Tom Tromey  <tromey@adacore.com>
6706
6707         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6708         * tui/tui-winsource.c (tui_refill_source_window): New function,
6709         from...
6710         (tui_horizontal_source_scroll): ... here.  Move some logic.
6711         * cli/cli-style.c (set_style_enabled): Notify new observable.
6712         * tui/tui-hooks.c (tui_redisplay_source): New function.
6713         (tui_attach_detach_observers): Attach or detach
6714         tui_redisplay_source.
6715         * observable.h (source_styling_changed): New observable.
6716         * observable.c: Define source_styling_changed observable.
6717
6718 2019-03-13  Tom Tromey  <tromey@adacore.com>
6719
6720         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6721         (i386_gnu_nat_target::store_registers): Update.
6722         * target-debug.h (target_debug_print_std_string): New macro.
6723         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6724         * windows-tdep.c (display_one_tib): Update.
6725         * tui/tui-stack.c (tui_make_status_line): Update.
6726         * top.c (print_inferior_quit_action): Update.
6727         * thread.c (thr_try_catch_cmd): Update.
6728         (add_thread_with_info): Update.
6729         (thread_target_id_str): Update.
6730         (thr_try_catch_cmd): Update.
6731         (thread_command): Update.
6732         (thread_find_command): Update.
6733         * record-btrace.c (record_btrace_target::info_record)
6734         (record_btrace_resume_thread, record_btrace_target::resume)
6735         (record_btrace_cancel_resume, record_btrace_step_thread)
6736         (record_btrace_target::wait, record_btrace_target::wait)
6737         (record_btrace_target::wait, record_btrace_target::stop): Update.
6738         * progspace.c (print_program_space): Update.
6739         * process-stratum-target.c
6740         (process_stratum_target::thread_address_space): Update.
6741         * linux-fork.c (linux_fork_mourn_inferior)
6742         (detach_checkpoint_command, info_checkpoints_command)
6743         (linux_fork_context): Update.
6744         (linux_fork_detach): Update.
6745         (class scoped_switch_fork_info): Update.
6746         (delete_checkpoint_command): Update.
6747         * infrun.c (follow_fork_inferior): Update.
6748         (follow_fork_inferior): Update.
6749         (proceed_after_vfork_done): Update.
6750         (handle_vfork_child_exec_or_exit): Update.
6751         (follow_exec): Update.
6752         (displaced_step_prepare_throw): Update.
6753         (displaced_step_restore): Update.
6754         (start_step_over): Update.
6755         (resume_1): Update.
6756         (clear_proceed_status_thread): Update.
6757         (proceed): Update.
6758         (print_target_wait_results): Update.
6759         (do_target_wait): Update.
6760         (context_switch): Update.
6761         (stop_all_threads): Update.
6762         (restart_threads): Update.
6763         (finish_step_over): Update.
6764         (handle_signal_stop): Update.
6765         (switch_back_to_stepped_thread): Update.
6766         (keep_going_pass_signal): Update.
6767         (print_exited_reason): Update.
6768         (normal_stop): Update.
6769         * inferior.c (inferior_pid_to_str): Change return type.
6770         (print_selected_inferior): Update.
6771         (add_inferior): Update.
6772         (detach_inferior): Update.
6773         * dummy-frame.c (fprint_dummy_frames): Update.
6774         * dcache.c (dcache_info_1): Update.
6775         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6776         (btrace_fetch, btrace_clear): Update.
6777         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6778         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6779         type.
6780         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6781         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6782         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6783         * gdbarch.c, gdbarch.h: Rebuild.
6784         * gdbarch.sh (core_pid_to_str): Change return type.
6785         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6786         return type.
6787         (windows_nat_target::pid_to_str): Change return type.
6788         (windows_delete_thread): Update.
6789         (windows_nat_target::attach): Update.
6790         (windows_nat_target::files_info): Update.
6791         * target-delegates.c: Rebuild.
6792         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6793         return type.
6794         (sol_thread_target::pid_to_str): Change return type.
6795         * remote.c (class remote_target) <pid_to_str>: Change return
6796         type.
6797         (remote_target::pid_to_str): Change return type.
6798         (extended_remote_target::attach, remote_target::remote_stop_ns)
6799         (remote_target::remote_notif_remove_queued_reply)
6800         (remote_target::push_stop_reply, remote_target::disable_btrace):
6801         Update.
6802         (extended_remote_target::attach): Update.
6803         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6804         type.
6805         (gdbsim_target::pid_to_str): Change return type.
6806         * ravenscar-thread.c (struct ravenscar_thread_target)
6807         <pid_to_str>: Change return type.
6808         (ravenscar_thread_target::pid_to_str): Change return type.
6809         * procfs.c (class procfs_target) <pid_to_str>: Change return
6810         type.
6811         (procfs_target::pid_to_str): Change return type.
6812         (procfs_target::attach): Update.
6813         (procfs_target::detach): Update.
6814         (procfs_target::fetch_registers): Update.
6815         (procfs_target::store_registers): Update.
6816         (procfs_target::wait): Update.
6817         (procfs_target::files_info): Update.
6818         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6819         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6820         return type.
6821         (nto_procfs_target::pid_to_str): Change return type.
6822         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6823         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6824         return type.
6825         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6826         (exit_lwp): Update.
6827         (attach_proc_task_lwp_callback, get_detach_signal)
6828         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6829         (linux_nat_target::resume, wait_lwp, stop_callback)
6830         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6831         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6832         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6833         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6834         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6835         type.
6836         (inf_ptrace_target::attach): Update.
6837         (inf_ptrace_target::files_info): Update.
6838         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6839         type.
6840         (go32_nat_target::pid_to_str): Change return type.
6841         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6842         (gnu_nat_target::wait): Update.
6843         (gnu_nat_target::wait): Update.
6844         (gnu_nat_target::resume): Update.
6845         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6846         (fbsd_nat_target::wait): Update.
6847         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6848         type.
6849         (darwin_nat_target::attach): Update.
6850         * corelow.c (class core_target) <pid_to_str>: Change return type.
6851         (core_target::pid_to_str): Change return type.
6852         * target.c (normal_pid_to_str): Change return type.
6853         (default_pid_to_str): Likewise.
6854         (target_pid_to_str): Change return type.
6855         (target_translate_tls_address): Update.
6856         (target_announce_detach): Update.
6857         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6858         return type.
6859         (bsd_uthread_target::pid_to_str): Change return type.
6860         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6861         type.
6862         (bsd_kvm_target::pid_to_str): Change return type.
6863         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6864         return type.
6865         (aix_thread_target::pid_to_str): Change return type.
6866         * target.h (struct target_ops) <pid_to_str>: Change return type.
6867         (target_pid_to_str, normal_pid_to_str): Likewise.
6868         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6869         type.
6870         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6871         type.
6872         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6873         return type.
6874         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6875         type.
6876         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6877         type.
6878         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6879         return type.
6880
6881 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6882
6883         * NEWS: Mention that the new default MI version is 3.  Mention
6884         changes to the output of commands and events that deal with
6885         multi-location breakpoints.
6886         * breakpoint.c: Include "mi/mi-out.h".
6887         (print_one_breakpoint): Change output syntax if using MI version
6888         >= 3.
6889         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6890         New.
6891         (mi_multi_location_breakpoint_output_fixed): New.
6892         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6893         (mi_cmd_fix_multi_location_breakpoint_output): New.
6894         (mi_multi_location_breakpoint_output_fixed): New.
6895         * mi/mi-cmds.c (mi_cmds): Register command
6896         -fix-multi-location-breakpoint-output.
6897         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6898         interpreter "mi".
6899
6900 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6901
6902         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6903         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6904         instantiate mi_ui_out based on interpreter name.
6905         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6906         * mi/mi-main.c (mi_load_progress): Likewise.
6907
6908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6909
6910         * NEWS: Combine separate "New targets" sections for 8.3.
6911
6912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6913
6914         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6915         (ppcfbsd_init_abi): Install gdbarch
6916         "fetch_tls_load_module_address" and "get_thread_local_address"
6917         methods.
6918
6919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6920
6921         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6922         (riscv_fbsd_init_abi): Install gdbarch
6923         "fetch_tls_load_module_address" and "get_thread_local_address"
6924         methods.
6925
6926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6927
6928         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6929         (i386fbsd_init_abi): Install gdbarch
6930         "fetch_tls_load_module_address" and "get_thread_local_address"
6931         methods.
6932
6933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6934
6935         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6936         (amd64fbsd_init_abi): Install gdbarch
6937         "fetch_tls_load_module_address" and "get_thread_local_address"
6938         methods.
6939
6940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6941
6942         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6943         (struct fbsd_pspace_data): New type.
6944         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6945         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6946         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6947         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6948         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6949
6950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6951
6952         * gdbtypes.c (lookup_struct_elt): New function.
6953         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6954         * gdbtypes.h (struct struct_elt): New type.
6955         (lookup_struct_elt): New prototype.
6956
6957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6958
6959         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6960         remove disabled code block.
6961
6962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6963
6964         * gdbarch.sh (get_thread_local_address): New method.
6965         * gdbarch.h, gdbarch.c: Regenerate.
6966         * target.c (target_translate_tls_address): Use
6967         gdbarch_get_thread_local_address if present instead of
6968         target::get_thread_local_address.
6969
6970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6971
6972         * target.h (target::get_thread_local_address): Update comment.
6973
6974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6975
6976         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6977         objfile->separate_debug_objfile_backlink if not NULL.
6978
6979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6980
6981         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6982         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6983         (amd64bsd_store_inferior_registers): Likewise.
6984         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6985         Enable segment base registers.
6986         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6987         PT_GETFSBASE and PT_GETGSBASE.
6988         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6989         PT_SETGSBASE.
6990         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6991         segment base registers.
6992         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6993
6994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6995
6996         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6997         Update calls to i386_target_description to add 'segments'
6998         parameter.
6999         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7000         add segment base registers.
7001         * arch/i386.c (i386_create_target_description): Add 'segments'
7002         parameter to enable segment base registers.
7003         * arch/i386.h (i386_create_target_description): Likewise.
7004         * features/i386/32bit-segments.xml: New file.
7005         * features/i386/32bit-segments.c: Generate.
7006         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7007         call to i386_target_description to add 'segments' parameter.
7008         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7009         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7010         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7011         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7012         if feature is present.
7013         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7014         Add 'segments' parameter to call to i386_target_description.
7015         (i386_target_description): Add 'segments' parameter to enable
7016         segment base registers.
7017         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7018         to call to i386_target_description.
7019         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7020         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7021         Define I386_NUM_REGS.
7022         (i386_target_description): Add 'segments' parameter to enable
7023         segment base registers.
7024
7025 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7026
7027         PR/24325
7028         * source-cache.c: #undef open and close, to avoid unresolved
7029         externals during linking.
7030
7031 2019-03-12  Tom Tromey  <tromey@adacore.com>
7032
7033         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7034         const.  Add initializers.
7035         (_initialize_remote): Don't initialize ptid globals.
7036
7037 2019-03-12  Pedro Alves  <palves@redhat.com>
7038
7039         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7040
7041 2019-03-12  Pedro Alves  <palves@redhat.com>
7042
7043         * cp-name-parser.y (main): Remove unused 'len' variable.
7044
7045 2019-03-12  Tom Tromey  <tromey@adacore.com>
7046
7047         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7048         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7049
7050 2019-03-12  Tom Tromey  <tromey@adacore.com>
7051
7052         * linux-nat.c (iterate_over_lwps): Update.
7053         (stop_callback): Remove parameter.
7054         (stop_wait_callback, detach_callback, resume_set_callback)
7055         (select_singlestep_lwp_callback, set_ignore_sigint)
7056         (status_callback, resumed_callback, resume_clear_callback)
7057         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7058         data parameter.
7059         (linux_nat_target::detach, linux_nat_target::resume)
7060         (linux_stop_and_wait_all_lwps, select_event_lwp)
7061         (linux_nat_filter_event, linux_nat_wait_1)
7062         (linux_nat_target::kill, linux_nat_target::stop)
7063         (linux_nat_target::stop): Update.
7064         (linux_nat_resume_callback): Change type.
7065         (resume_stopped_resumed_lwps, count_events_callback)
7066         (select_event_lwp_callback): Likewise.
7067         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7068         * arm-linux-nat.c (struct update_registers_data): Remove.
7069         (update_registers_callback): Change type.
7070         (arm_linux_insert_hw_breakpoint1): Update.
7071         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7072         parameter.
7073         (x86_linux_dr_set_addr): Update.
7074         (x86_linux_dr_set_control): Update.
7075         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7076         (iterate_over_lwps): Use gdb::function_view.
7077         * nat/aarch64-linux-hw-point.c (struct
7078         aarch64_dr_update_callback_param): Remove.
7079         (debug_reg_change_callback): Change type.
7080         (aarch64_notify_debug_reg_change): Update.
7081         * s390-linux-nat.c (s390_refresh_per_info): Update.
7082
7083 2019-03-11  Tom Tromey  <tromey@adacore.com>
7084
7085         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7086         redundant assignment to "this_cu".
7087
7088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7089
7090         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7091
7092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7093
7094         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7095         from...
7096         (rank_one_type): ... this.
7097
7098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7099
7100         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7101         from...
7102         (rank_one_type): ... this.
7103
7104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7105
7106         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7107         from...
7108         (rank_one_type): ... this.
7109
7110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7111
7112         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7113         from...
7114         (rank_one_type): ... this.
7115
7116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7117
7118         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7119         from...
7120         (rank_one_type): ... this.
7121
7122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7123
7124         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7125         from...
7126         (rank_one_type): ... this.
7127
7128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7129
7130         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7131         from...
7132         (rank_one_type): ... this.
7133
7134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7135
7136         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7137         from...
7138         (rank_one_type): ... this.
7139
7140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7141
7142         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7143         from...
7144         (rank_one_type): ... this.
7145
7146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7147
7148         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7149         from...
7150         (rank_one_type): ... this.
7151
7152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7153
7154         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7155         from...
7156         (rank_one_type): ... this.
7157
7158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7159
7160         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7161         from...
7162         (rank_one_type): ... this.
7163
7164 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7165
7166         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7167         inferior-events' shows the example events.
7168
7169 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7170
7171         Support styling on native MS-Windows console
7172
7173         PR/24315
7174         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7175         on MS-Windows if $TERM is not defined.
7176
7177         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7178
7179         * posix-hdep.c (gdb_console_fputs):
7180         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7181         functions.
7182         * ui-file.h (gdb_console_fputs): Add prototype.
7183
7184         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7185         back to fputs only if the former returns zero.
7186
7187 2019-03-07  Tom Tromey  <tom@tromey.com>
7188
7189         * symmisc.c (print_symbol_bcache_statistics): Update.
7190         (print_objfile_statistics): Update.
7191         * symfile.c (allocate_symtab): Update.
7192         * stabsread.c: Don't include bcache.h.
7193         * psymtab.h (struct psymbol_bcache): Don't declare.
7194         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7195         (psymbol_bcache_init, psymbol_bcache_free)
7196         (psymbol_bcache_get_bcache): Don't declare.
7197         * psymtab.c (struct psymbol_bcache): Remove.
7198         (psymtab_storage::psymtab_storage): Update.
7199         (psymtab_storage::~psymtab_storage): Update.
7200         (psymbol_bcache_init, psymbol_bcache_free)
7201         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7202         (add_psymbol_to_bcache): Update.
7203         (allocate_psymtab): Update.
7204         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7205         macro_cache>: No longer pointers.
7206         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7207         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7208         * macrotab.c (macro_bcache): Update.
7209         * macroexp.c: Don't include bcache.h.
7210         * gdbtypes.c (check_types_worklist): Update.
7211         (types_deeply_equal): Remove TRY/CATCH.  Update.
7212         * elfread.c (elf_symtab_read): Update.
7213         * dwarf2read.c: Don't include bcache.h.
7214         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7215         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7216         (print_bcache_statistics, bcache_memory_used): Don't declare.
7217         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7218         methods.  Rename all data members.
7219         * bcache.c (struct bcache): Move to bcache.h.
7220         (bcache::expand_hash_table): Rename from expand_hash_table.
7221         (bcache): Remove.
7222         (bcache::insert): Rename from bcache_full.
7223         (bcache::compare): Rename from bcache_compare.
7224         (bcache_xmalloc): Remove.
7225         (bcache::~bcache): Rename from bcache_xfree.
7226         (bcache::print_statistics): Rename from print_bcache_statistics.
7227         (bcache::memory_used): Rename from bcache_memory_used.
7228
7229 2019-03-07  Pedro Alves  <palves@redhat.com>
7230
7231         * infrun.c (normal_stop): Also check for
7232         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7233
7234 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * f-lang.c (value_from_host_double): Moved to...
7237         * value.c (value_from_host_double): ...here.
7238         * value.h (value_from_host_double): Declare.
7239         * guile/scm-math.c (vlscm_convert_typed_number): Use
7240         value_from_host_double.
7241         (vlscm_convert_number): Likewise.
7242         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7243         * python/py-value.c (convert_value_from_python): Likewise.
7244
7245 2019-03-06  Tom Tromey  <tom@tromey.com>
7246
7247         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7248
7249 2019-03-06  Tom Tromey  <tom@tromey.com>
7250
7251         * utils.h (free_current_contents): Don't declare.
7252         * utils.c (free_current_contents): Remove.
7253
7254 2019-03-06  Tom Tromey  <tom@tromey.com>
7255
7256         * top.c (quit_force): Update.
7257         * main.c (captured_command_loop): Update.
7258         * common/new-op.c (operator new): Update.
7259         * common/common-exceptions.c (struct catcher)
7260         <save_cleanup_chain>: Remove member.
7261         (exceptions_state_mc_init): Update.
7262         (exception_try_scope_entry): Return nullptr.
7263         (exception_try_scope_exit, exception_rethrow)
7264         (throw_exception_sjlj, throw_exception_cxx): Update.
7265         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7266         (all_cleanups, do_cleanups, discard_cleanups)
7267         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7268         (restore_cleanups, restore_final_cleanups): Don't declare.
7269         (do_final_cleanups): Remove parameter.
7270         * common/cleanups.c (cleanup_chain, make_cleanup)
7271         (make_cleanup_dtor, all_cleanups, do_cleanups)
7272         (discard_my_cleanups, discard_cleanups)
7273         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7274         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7275         (null_cleanup): Remove.
7276         (do_final_cleanups): Remove parameter.
7277
7278 2019-03-06  Tom Tromey  <tom@tromey.com>
7279
7280         * remote.c (remote_target::remote_parse_stop_reply): Use
7281         unique_xmalloc_ptr.
7282
7283 2019-03-06  Tom Tromey  <tom@tromey.com>
7284
7285         * stabsread.c (struct stabs_field_info): Rename from field_info.
7286         <list, fnlist>: Add initializers.
7287         <obstack>: New member.
7288         (read_member_functions, read_struct_fields, read_baseclasses):
7289         Allocate on obstack.  Don't use cleanups.
7290         (read_one_struct_field, read_member_functions, read_struct_fields)
7291         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7292         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7293         (read_struct_type): Update.
7294
7295 2019-03-06  Tom Tromey  <tom@tromey.com>
7296
7297         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7298         * common/filestuff.h (make_cleanup_close): Don't declare.
7299         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7300         Remove.
7301
7302 2019-03-06  Tom Tromey  <tom@tromey.com>
7303
7304         * solib-aix.c: Use make_scope_exit.
7305
7306 2019-03-06  Tom Tromey  <tom@tromey.com>
7307
7308         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7309         Use make_scope_exit.
7310
7311 2019-03-06  Tom Tromey  <tom@tromey.com>
7312
7313         * solib-svr4.c (disable_probes_interface): Remove parameter.
7314         (svr4_handle_solib_event): Use make_scope_exit.
7315
7316 2019-03-06  Tom Tromey  <tom@tromey.com>
7317
7318         * remote.c (struct stop_reply_deleter): Remove.
7319         (stop_reply_up): Update.
7320         (struct stop_reply): Derive from notif_event.  Don't typedef.
7321         <regcache>: Now a std::vector.
7322         (stop_reply_xfree): Remove.
7323         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7324         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7325         (remote_target::discard_pending_stop_replies): Use delete.
7326         (remote_target::remote_parse_stop_reply): Update.
7327         (remote_target::process_stop_reply): Update.
7328         * remote-notif.h (struct notif_event): Add virtual destructor.
7329         Remove "dtr" member.
7330         (struct notif_client) <alloc_event>: Return a unique_ptr.
7331         (notif_event_xfree): Don't declare.
7332         (notif_event_up): New typedef.
7333         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7334         (notif_event_xfree, do_notif_event_xfree): Remove.
7335         (remote_notif_state_xfree): Update.
7336
7337 2019-03-06  Tom Tromey  <tom@tromey.com>
7338
7339         * infrun.c (displaced_step_clear_cleanup): Now a
7340         forward_scope_exit type.
7341         (displaced_step_prepare_throw): Update.
7342         (displaced_step_fixup): Update.
7343
7344 2019-03-06  Tom Tromey  <tom@tromey.com>
7345
7346         * inferior.h (class inferior): Update comment.
7347         * gdbthread.h (class thread_info): Update comment.
7348
7349 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7350             Tom Tromey  <tom@tromey.com>
7351
7352         * stabsread.h (struct stab_section_list): Remove.
7353         (coffstab_build_psymtabs): Update.
7354         * dbxread.c (symbuf_sections): Now a std::vector.
7355         (sect_idx): New global.
7356         (fill_symbuf): Update.
7357         (coffstab_build_psymtabs): Change type of stabsects parameter.
7358         Update.
7359         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7360         std::vector.
7361         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7362         (coff_locate_sections): Update.
7363         (coff_symfile_read): Remove cleanups.  Update.
7364         (init_stringtab): Add storage parameter.
7365         (free_stringtab, free_stringtab_cleanup): Remove.
7366         (init_lineno): Add storage parameter.
7367         (free_linetab, free_linetab_cleanup): Remove.
7368
7369 2019-03-06  Pedro Alves  <palves@redhat.com>
7370
7371         * linux-fork.c (fork_info::clobber_regs): Delete.
7372         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7373         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7374         comment.  Adjust.
7375         (scoped_switch_fork_info::scoped_switch_fork_info)
7376         (checkpoint_command, linux_fork_context): Adjust
7377         fork_save_infrun_state calls.
7378
7379 2019-03-06  Pedro Alves  <palves@redhat.com>
7380
7381         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7382         (inf_has_multiple_threads): Return 'bool' and rewrite using
7383         inferior_info::threads().
7384
7385 2019-03-06  Pedro Alves  <palves@redhat.com>
7386
7387         * linux-fork.c: Include <list>.
7388         (fork_list): Now a std::list instance.
7389         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7390         (forks_exist_p, find_last_fork): Adjust.
7391         (new_fork): Delete.
7392         (one_fork_p): New.
7393         (add_fork): Adjust.
7394         (free_fork): Delete, folded into fork_info::~fork_info().
7395         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7396         Adjust.
7397         (init_fork_list): Delete.
7398         (linux_fork_killall, linux_fork_mourn_inferior)
7399         (linux_fork_detach, info_checkpoints_command): Adjust.
7400         (_initialize_linux_fork): No longer call init_fork_list.
7401
7402 2019-03-06  Pedro Alves  <palves@redhat.com>
7403
7404         * linux-fork.c (new_fork): New, split out of ...
7405         (add_fork): ... this.  Return void.  Move "first fork" special
7406         case from here, to ...
7407         (checkpoint_command): ... here.
7408         * linux-linux.h (add_fork): Return void.
7409
7410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7411
7412         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7413
7414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7415             Chris January  <chris.january@arm.com>
7416             David Lecomber  <david.lecomber@arm.com>
7417
7418         * f-exp.y: New token, UNOP_INTRINSIC.
7419         (exp): New pattern using UNOP_INTRINSIC token.
7420         (f77_keywords): Add 'abs' keyword.
7421         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7422         (value_from_host_double): New function.
7423         (evaluate_subexp_f): Support UNOP_ABS.
7424
7425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7426
7427         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7428         types.
7429
7430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7433         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7434         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7435
7436 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7437
7438         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7439
7440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7441             Chris January  <chris.january@arm.com>
7442
7443         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7444         * f-exp.y: Define 'KIND' token.
7445         (exp): New pattern for KIND expressions.
7446         (ptype): Handle types with a kind extension.
7447         (direct_abs_decl): Extend to spot kind extensions.
7448         (f77_keywords): Add 'kind' to the list.
7449         (push_kind_type): New function.
7450         (convert_to_kind_type): New function.
7451         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7452         * parse.c (operator_length_standard): Likewise.
7453         * parser-defs.h (enum type_pieces): Add tp_kind.
7454         * std-operator.def: Add UNOP_KIND.
7455
7456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7457
7458         * f-exp.y (f_parse): Set yydebug.
7459
7460 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * f-lang.c (evaluate_subexp_f): New function.
7463         (exp_descriptor_f): New global.
7464         (f_language_defn): Use exp_descriptor_f instead of
7465         exp_descriptor_standard.
7466
7467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7468
7469         * f-exp.y (struct token): Add comments.
7470         (dot_ops): Remove uppercase versions and the end marker.
7471         (f77_keywords): Likewise.
7472         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7473         entries in the dot_ops array are case insensitive, and use
7474         strncasecmp to compare strings.  Also some whitespace cleanup in
7475         this area.  Similar for the f77_keywords array, except entries in
7476         this list might be case sensitive.
7477
7478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7479
7480         * f-exp.y (struct f77_boolean_val): Add comments.
7481         (boolean_values): Remove uppercase versions, and end marker.
7482         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7483         and use strncasecmp to achieve case insensitivity.  Additionally,
7484         perform whitespace cleanup around this code.
7485
7486 2019-03-06  Tom Tromey  <tromey@adacore.com>
7487
7488         * remote-sim.c (gdbsim_target_open): Use result of
7489         gdb_argv::release.
7490
7491 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7492         Dirk Schubert  <dirk.schubert@arm.com>
7493         Chris January  <chris.january@arm.com>
7494
7495         * eval.c (evaluate_subexp_standard): Call Fortran argument
7496         wrapping logic.
7497         * f-lang.c (struct value): A value which can be passed into a
7498         Fortran function call.
7499         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7500         where appropriate.
7501         (struct type): Value ready for a Fortran function call.
7502         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7503         is needed.
7504         * f-lang.h (fortran_argument_convert): Declaration.
7505         (fortran_preserve_arg_pointer): Declaration.
7506         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7507
7508 2019-03-05  Tom Tromey  <tromey@adacore.com>
7509
7510         * python/py-prettyprint.c (print_string_repr): Remove #if.
7511         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7512
7513 2019-03-05  Tom Tromey  <tromey@adacore.com>
7514
7515         * target.c (the_dummy_target): Move later.  Change type to
7516         "dummy_target".
7517         (initialize_targets): Don't initialize the_dummy_target.
7518
7519 2019-03-05  Tom Tromey  <tromey@adacore.com>
7520
7521         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7522         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7523
7524 2019-03-05  Tom Tromey  <tromey@adacore.com>
7525
7526         * windows-nat.c (windows_nat_target::attach)
7527         (windows_nat_target::detach): Don't call gdb_flush.
7528         * valprint.c (generic_val_print, val_print, val_print_string):
7529         Don't call gdb_flush.
7530         * utils.c (defaulted_query): Don't call gdb_flush.
7531         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7532         * target.c (target_announce_detach): Don't call gdb_flush.
7533         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7534         * remote.c (extended_remote_target::attach): Don't call
7535         gdb_flush.
7536         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7537         * printcmd.c (do_examine): Don't call gdb_flush.
7538         (info_display_command): Don't call gdb_flush.
7539         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7540         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7541         * memattr.c (info_mem_command): Don't call gdb_flush.
7542         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7543         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7544         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7545         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7546         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7547         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7548         (gnu_nat_target::detach): Don't call gdb_flush.
7549         * f-valprint.c (f_val_print): Don't call gdb_flush.
7550         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7551         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7552         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7553         gdb_flush.
7554         * c-valprint.c (c_val_print): Don't call gdb_flush.
7555         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7556
7557 2019-03-05  Tom Tromey  <tromey@adacore.com>
7558
7559         * varobj.c (update_dynamic_varobj_children): Update.
7560         (install_default_visualizer): Use reset, not release.
7561         * value.c (set_internalvar): Update.
7562         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7563         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7564         ATTRIBUTE_UNUSED_RESULT.
7565
7566 2019-03-05  Tom Tromey  <tromey@adacore.com>
7567
7568         * remote.c (class scoped_remote_fd) <release>: Add
7569         ATTRIBUTE_UNUSED_RESULT.
7570
7571 2019-03-05  Tom Tromey  <tromey@adacore.com>
7572
7573         * macroexp.c (struct macro_buffer) <release>: Add
7574         ATTRIBUTE_UNUSED_RESULT.
7575
7576 2019-03-05  Tom Tromey  <tromey@adacore.com>
7577
7578         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7579         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7580         ATTRIBUTE_UNUSED_RESULT.
7581
7582 2019-03-05  Tom Tromey  <tromey@adacore.com>
7583
7584         * common/scoped_fd.h (class scoped_fd) <release>: Add
7585         ATTRIBUTE_UNUSED_RESULT.
7586
7587 2019-03-05  Tom Tromey  <tromey@adacore.com>
7588
7589         * parser-defs.h (struct parser_state) <release>: Add
7590         ATTRIBUTE_UNUSED_RESULT.
7591
7592 2019-03-05  Tom Tromey  <tromey@adacore.com>
7593
7594         * utils.h (class gdb_argv) <release>: Add
7595         ATTRIBUTE_UNUSED_RESULT.
7596         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7597
7598 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7599
7600         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7601         for-loop range, to avoid compiler warnings.
7602
7603         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7604         avoid compiler warnings about unused variables.
7605
7606         * NEWS: Mention end of support for native debugging on MS-Windows
7607         before XP.
7608
7609         PR gdb/24292
7610         * common/netstuff.c:
7611         * gdbserver/gdbreplay.c
7612         * gdbserver/remote-utils.c:
7613         * ser-tcp.c:
7614         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7615         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7616         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7617         'getaddrinfo' and 'freeaddrinfo' were not available before
7618         Windows XP, and mingw.org's MinGW headers by default define
7619         _WIN32_WINNT to 0x500.
7620
7621 2019-03-01  Gary Benson <gbenson@redhat.com>
7622
7623         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7624
7625 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7626             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7627
7628         PR gdb/8527
7629         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7630         set_sigint_trap, clear_sigint_trap.
7631
7632 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7633
7634         * target.c (target_detach): Clear the regcache and the
7635         frame cache.
7636
7637 2019-02-27  Pedro Alves  <palves@redhat.com>
7638
7639         * utils.c (set_screen_size): When we cap the height/width sizes,
7640         tweak the corresponding command variable to show "unlimited":
7641
7642 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7643             Pedro Alves  <palves@redhat.com>
7644
7645         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7646         before calling rl_set_screen_size.
7647
7648 2019-02-27  Tom Tromey  <tromey@adacore.com>
7649
7650         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7651         define.
7652         * python/py-value.c: Remove Python 2.4 workaround.
7653         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7654         workaround.
7655         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7656         Python 2.4 workaround.
7657         * python/python-internal.h: Remove Python 2.4 comment.
7658         (Py_ssize_t): Don't define.
7659         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7660         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7661         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7662         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7663         * python/python.c (do_start_initialization): Remove Python 2.4
7664         workaround.
7665         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7666         (print_children): Remove Python 2.4 workaround.
7667         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7668         workaround.
7669         (CHARBUFFERPROC_NAME): Remove.
7670         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7671         Python 2.4 workaround.
7672
7673 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7674
7675         * NEWS: Note minimum Python version.
7676
7677 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7678
7679         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7680         code from these functions.  Remove corresponding ifdefs.  Use
7681         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7682         Remove gotos and target of gotos.
7683         (infpy_search_memory): Likewise.
7684
7685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7688         (hppa_gdbarch_init): Don't register deleted functions with
7689         gdbarch.
7690
7691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7694         (h8300_unwind_sp): Delete.
7695         (h8300_dummy_id): Delete.
7696         (h8300_gdbarch_init): Don't register deleted functions with
7697         gdbarch.
7698
7699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7702         (ft32_unwind_pc): Delete.
7703         (ft32_unwind_sp): Delete.
7704         (ft32_gdbarch_init): Don't register deleted functions with
7705         gdbarch.
7706
7707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7708
7709         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7710         (frv_unwind_pc): Delete.
7711         (frv_unwind_sp): Delete.
7712         (frv_gdbarch_init): Don't register deleted functions with
7713         gdbarch.
7714
7715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7716
7717         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7718         (riscv_unwind_pc): Delete.
7719         (riscv_unwind_sp): Delete.
7720         (riscv_gdbarch_init): Don't register deleted functions with
7721         gdbarch.
7722
7723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7724
7725         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7726         (csky_unwind_pc): Delete.
7727         (csky_unwind_sp): Delete.
7728         (csky_gdbarch_init): Don't register deleted functions with
7729         gdbarch.
7730
7731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7732
7733         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7734         (cris_unwind_pc): Delete.
7735         (cris_unwind_sp): Delete.
7736         (cris_gdbarch_init): Don't register deleted functions with
7737         gdbarch.
7738
7739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7742         (bfin_unwind_pc): Delete.
7743         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7744
7745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7748         (arm_unwind_pc): Delete.
7749         (arm_unwind_sp): Delete.
7750         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7751
7752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7755         (arc_unwind_pc): Delete.
7756         (arc_unwind_sp): Delete.
7757         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7758
7759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7762         (alpha_unwind_pc): Delete.
7763         (alpha_gdbarch_init): Don't register deleted functions with
7764         gdbarch.
7765
7766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7767
7768         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7769         (aarch64_unwind_pc): Delete.
7770         (aarch64_unwind_sp): Delete.
7771         (aarch64_gdbarch_init): Don't register deleted functions with
7772         gdbarch.
7773
7774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7775
7776         * gdbtypes.c (type_align): Don't consider static members when
7777         computing structure alignment.
7778
7779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7782         return 0 for other types.
7783         * arch-utils.c (default_type_align): Always return 0.
7784         * gdbarch.h: Regenerate.
7785         * gdbarch.sh (type_align): Extend comment.
7786         * gdbtypes.c (type_align): Add additional comments, always call
7787         gdbarch_type_align before applying the default rules.
7788         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7789         generic code will then apply a suitable default.
7790         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7791         types, return 0 for other types.
7792
7793 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7794
7795         * NEWS: Create a new section for the next release branch.
7796         Rename the section of the current branch, now that it has
7797         been cut.
7798
7799 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7800
7801         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7802         * version.in: Bump version to 8.3.50.DATE-git.
7803
7804 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7805
7806         * aix-thread.c (ptid_cmp): Remove unused variable.
7807         (get_signaled_thread): Likewise.
7808         (store_regs_user_thread): Likewise.
7809         (store_regs_kernel_thread): Likewise.
7810         (fetch_regs_kernel_thread): Remove shadowed variable.
7811
7812 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7813
7814         * features/riscv/32bit-cpu.xml: Add register numbers.
7815         * features/riscv/32bit-fpu.c: Regenerate.
7816         * features/riscv/32bit-fpu.xml: Add register numbers.
7817         * features/riscv/64bit-cpu.xml: Add register numbers.
7818         * features/riscv/64bit-fpu.c: Regenerate.
7819         * features/riscv/64bit-fpu.xml: Add register numbers.
7820
7821 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7822
7823         * NEWS: Mention two argument form of gdb.Value constructor.
7824         * python/py-value.c (convert_buffer_and_type_to_value): New
7825         function.
7826         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7827         Add support for handling an optional second argument.  Call
7828         convert_buffer_and_type_to_value as appropriate.
7829         * python/python-internal.h (Py_buffer_deleter): New struct.
7830         (Py_buffer_up): New typedef.
7831
7832 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7833
7834         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7835         instead of releasing ownership.
7836
7837 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7838
7839         * dwarf2read.c (open_and_init_dwp_file): Call
7840         elf_numsections instead of bfd_count_sections to initialize
7841         dwp_file->num_sections.
7842
7843 2019-02-25  Tom Tromey  <tromey@adacore.com>
7844
7845         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7846
7847 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7848
7849         * gcore.in: Add '--readnever' option when invoking GDB.
7850
7851 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7852
7853         * MAINTAINERS: Update my email address.
7854
7855 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7856
7857         * build-id.c (build_id_to_debug_bfd_1): New function.
7858         (build_id_to_debug_bfd): Look for separate debug file in
7859         sysroot.
7860
7861 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * gdbarch.sh: Update the copyright year range that is placed into
7864         generated files.
7865
7866 2019-02-22  Keith Seitz  <keiths@redhat.com>
7867
7868         PR symtab/23853
7869         * linespec.c (create_sals_line_offset): Search for the default
7870         symtab's filename instead of its fullname.
7871
7872 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7873
7874         * NEWS: Update style defaults.
7875
7876 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7877
7878         * main.c (captured_main_1): Disable styling in batch mode.
7879
7880 2019-02-20  Tom Tromey  <tom@tromey.com>
7881
7882         * symtab.c (symtab_symbol_info): Fix typos.
7883
7884 2019-02-20  Tom Tromey  <tromey@adacore.com>
7885
7886         * findcmd.c (_initialize_mem_search): Use upper case for
7887         metasyntactic variables.
7888
7889 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7890
7891         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7892         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7893
7894 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7895
7896         * top.h (source_file_name): Change to std::string.
7897         * top.c (source_file_name): Likewise.
7898         (command_line_input): Adjust.
7899         * cli/cli-script.c (script_from_file): Adjust.
7900
7901 2019-02-19  Tom Tromey  <tromey@adacore.com>
7902
7903         * ravenscar-thread.c
7904         (ravenscar_thread_target::update_thread_list): Don't call
7905         ada_build_task_list.
7906         * ada-lang.h (ada_build_task_list): Don't declare.
7907         * ada-tasks.c (struct ada_tasks_inferior_data)
7908         <task_list_valid_p>: Now bool.
7909         (read_known_tasks, ada_task_list_changed)
7910         (ada_tasks_invalidate_inferior_data): Update.
7911         (read_known_tasks_array): Return bool.
7912         (read_known_tasks_list): Likewise.
7913         (read_known_tasks): Return void.
7914         (ada_build_task_list): Now static.
7915
7916 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7917
7918         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7919         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7920
7921 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7922
7923         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7924         variant for ada_tasks_pspace_data_handle and
7925         ada_tasks_inferior_data_handle.
7926         (ada_tasks_pspace_data_cleanup): New function.
7927         (ada_tasks_inferior_data_cleanup): New function.
7928
7929 2019-02-17  Tom Tromey  <tom@tromey.com>
7930
7931         * macrotab.h (macro_source_fullname): Return a std::string.
7932         * macrotab.c (macro_include, check_for_redefinition)
7933         (macro_undef, macro_lookup_definition, foreach_macro)
7934         (foreach_macro_in_scope): Update.
7935         (macro_source_fullname): Return a std::string.
7936         * macrocmd.c (show_pp_source_pos): Update.
7937
7938 2019-02-17  Tom Tromey  <tom@tromey.com>
7939
7940         * macrocmd.c (show_pp_source_pos): Style the file names.
7941
7942 2019-02-17  Tom Tromey  <tom@tromey.com>
7943
7944         PR tui/24197:
7945         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7946
7947 2019-02-17  Tom Tromey  <tom@tromey.com>
7948
7949         * ada-lang.c (user_select_syms): Use filtered printing.
7950         * utils.c (wrap_style): New global.
7951         (desired_style): Remove.
7952         (emit_style_escape): Add stream parameter.
7953         (set_output_style, reset_terminal_style, prompt_for_continue):
7954         Update.
7955         (flush_wrap_buffer): Only flush gdb_stdout.
7956         (wrap_here): Set wrap_style.
7957         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7958         treat escape sequences as a character.  Change when wrap buffer is
7959         flushed.
7960         (fputs_styled): Do not set the output style when the default is
7961         requested.
7962         * ui-style.h (struct ui_file_style) <is_default>: New method.
7963         * source.c (print_source_lines_base): Emit escape sequences in one
7964         piece.
7965
7966 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7967
7968         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7969         integers and enumeration types.
7970
7971 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7972
7973         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7974         instead of lookup_symbol_in_language
7975         (do_exact_match): New function.
7976         (ada_get_symbol_name_matcher): Return do_exact_match when
7977         doing a verbatim match.
7978
7979 2019-02-15  Tom Tromey  <tromey@adacore.com>
7980
7981         * ravenscar-thread.c (ravenscar_thread_target::resume)
7982         (ravenscar_thread_target::wait): Special case wildcard requests.
7983
7984 2019-02-15  Tom Tromey  <tromey@adacore.com>
7985
7986         * ravenscar-thread.c (base_ptid): Remove.
7987         (struct ravenscar_thread_target) <close>: New method.
7988         <m_base_ptid>: New member.
7989         <update_inferior_ptid, active_task, task_is_currently_active,
7990         runtime_initialized>: Declare methods.
7991         <ravenscar_thread_target>: Add constructor.
7992         (ravenscar_thread_target::task_is_currently_active)
7993         (ravenscar_thread_target::update_inferior_ptid)
7994         (ravenscar_runtime_initialized): Rename.  Now methods.
7995         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7996         (ravenscar_thread_target::update_thread_list): Update.
7997         (ravenscar_thread_target::active_task): Now method.
7998         (ravenscar_thread_target::store_registers)
7999         (ravenscar_thread_target::prepare_to_store)
8000         (ravenscar_thread_target::prepare_to_store)
8001         (ravenscar_thread_target::mourn_inferior): Update.
8002         (ravenscar_inferior_created): Use "new" to create target.
8003         (ravenscar_thread_target::get_ada_task_ptid): Update.
8004         (_initialize_ravenscar): Don't initialize base_ptid.
8005         (ravenscar_ops): Remove global.
8006
8007 2019-02-15  Tom Tromey  <tromey@adacore.com>
8008
8009         * target.h (push_target): Declare new overload.
8010         * target.c (push_target): New overload, taking an rvalue reference.
8011         * remote.c (remote_target::open_1): Use push_target overload.
8012         * corelow.c (core_target_open): Use push_target overload.
8013
8014 2019-02-15  Tom Tromey  <tromey@adacore.com>
8015
8016         * ravenscar-thread.c (is_ravenscar_task)
8017         (ravenscar_task_is_currently_active): Return bool.
8018         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8019         (_initialize_ravenscar): Remove "(void)".
8020         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8021         Return bool.
8022
8023 2019-02-15  Tom Tromey  <tromey@adacore.com>
8024
8025         * ravenscar-thread.c (ravenscar_runtime_initializer)
8026         (has_ravenscar_runtime, get_running_thread_id)
8027         (ravenscar_thread_target::resume): Fix indentation.
8028
8029 2019-02-15  Tom Tromey  <tromey@adacore.com>
8030
8031         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8032         from ravenscar_arch_ops.
8033         (sparc_ravenscar_ops::fetch_registers)
8034         (sparc_ravenscar_ops::store_registers): Now methods.
8035         (sparc_ravenscar_prepare_to_store): Remove.
8036         (sparc_ravenscar_ops): Redefine.
8037         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8038         methods and destructor.  Remove members.
8039         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8040         (ravenscar_thread_target::store_registers)
8041         (ravenscar_thread_target::prepare_to_store): Update.
8042         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8043         Remove.
8044         (struct ppc_ravenscar_powerpc_ops): Derive from
8045         ravenscar_arch_ops.
8046         (ppc_ravenscar_powerpc_ops::fetch_registers)
8047         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8048         (ppc_ravenscar_powerpc_ops): Redefine.
8049         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8050         (ppc_ravenscar_e500_ops::fetch_registers)
8051         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8052         (ppc_ravenscar_e500_ops): Redefine.
8053         * aarch64-ravenscar-thread.c
8054         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8055         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8056         (aarch64_ravenscar_fetch_registers)
8057         (aarch64_ravenscar_store_registers): Now methods.
8058         (aarch64_ravenscar_ops): Redefine.
8059
8060 2019-02-15  Tom Tromey  <tromey@adacore.com>
8061
8062         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8063         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8064         (ravenscar_thread_target::stopped_by_watchpoint)
8065         (ravenscar_thread_target::stopped_data_address)
8066         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8067
8068 2019-02-15  Tom Tromey  <tromey@adacore.com>
8069
8070         * ravenscar-thread.c: Fix some typos.
8071
8072 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8073             Tom Tromey  <tromey@adacore.com>
8074
8075         * ada-lang.c (ada_exception_sal): Change addr_string to a
8076         std::string.
8077         (create_ada_exception_catchpoint): Update.
8078
8079 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8080             Tom Tromey  <tromey@adacore.com>
8081
8082         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8083         (bp_location_ops): Remove.
8084         (base_breakpoint_allocate_location): Update.
8085         (free_bp_location): Update.
8086         * ada-lang.c (class ada_catchpoint_location)
8087         <ada_catchpoint_location>: Remove ops parameter.
8088         (ada_catchpoint_location_dtor): Remove.
8089         (ada_catchpoint_location_ops): Remove.
8090         (allocate_location_exception): Update.
8091         * breakpoint.h (struct bp_location_ops): Remove.
8092         (class bp_location) <bp_location>: Remove bp_location_ops
8093         parameter.
8094         <~bp_location>: Add destructor.
8095         <ops>: Remove.
8096
8097 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8098             Pedro Alves  <palves@redhat.com>
8099
8100         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8101         'PATH_MAX'.
8102
8103 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8104             Samuel Thibault  <samuel.thibault@gnu.org>
8105             Thomas Schwinge  <thomas@codesourcery.com>
8106
8107         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8108         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8109
8110 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8111
8112         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8113         (check_empty): Use "const char *".
8114
8115         * gnu-nat.c (gnu_nat_target::detach): Instead of
8116         'detach_inferior (pid)' call
8117         'detach_inferior (find_inferior_pid (pid))'.
8118
8119         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8120         'nat/fork-inferior.o'.
8121         * gnu-nat.c: #include "nat/fork-inferior.h".
8122
8123         * gnu-nat.c (gnu_nat_target::detach): Instead of
8124         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8125         * gnu-nat.h: #include "inf-child.h".
8126         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8127         'i386_gnu_nat_target::fetch_registers'.
8128         (gnu_store_registers): Rename/move to
8129         'i386_gnu_nat_target::store_registers'.
8130
8131         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8132         * gnu-nat.h (mach_thread_info): New function.
8133         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8134
8135         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8136
8137 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8138
8139         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8140
8141 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8142
8143         * windows-nat.c (windows_add_thread): Add new parameter
8144         "main_thread_p" with default value set to false.  Update
8145         function documentation as well as all callers.
8146         (windows_delete_thread): Likewise.
8147         (fake_create_process): Update call to windows_add_thread.
8148         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8149         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8150         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8151         call to windows_delete_thread.
8152
8153 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8154
8155         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8156
8157 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8158
8159         * symfile.c (find_separate_debug_file): Use canonical path of
8160         sysroot with child_path instead of gdb_sysroot if it is valid.
8161
8162 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8163
8164         * symfile.c (find_separate_debug_file): Use child_path to
8165         determine if an object file is under a sysroot.
8166
8167 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8168
8169         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8170         unittests/child-path-selftests.c.
8171         * common/pathstuff.c (child_path): New function.
8172         * common/pathstuff.h (child_path): New prototype.
8173         * unittests/child-path-selftests.c: New file.
8174
8175 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8176
8177         * symfile.c (find_separate_debug_file): Look for separate debug
8178         files in debug directories under the sysroot.
8179
8180 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8181
8182         * symtab.h (struct minimal_symbol data_p): New const method.
8183         (struct minimal_symbol text_p): Likewise.
8184         * symtab.c (output_source_filename): Use file name style
8185         to print file name.
8186         (print_symbol_info): Likewise.
8187         (print_msymbol_info): Use address style to print addresses.
8188         Use function name style to print executable text symbols.
8189         (expand_symtab_containing_pc): Use data_p.
8190         (find_pc_sect_compunit_symtab): Likewise.
8191
8192 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8193
8194         * breakpoint.c (describe_other_breakpoints): Use address style
8195         to print addresses.
8196         (say_where): Likewise.
8197
8198 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8199
8200         * ada-typeprint.c (print_func_type): Print function name
8201         style to print function name.
8202         * c-typeprint.c (c_print_type_1): Likewise.
8203
8204 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8205
8206         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8207         for execve.
8208
8209 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8210
8211         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8212         type_stack.
8213
8214 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8215
8216         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8217         TYPE_CODE_REF types.
8218
8219 2019-02-08  Jim Wilson  <jimw@sifive.com>
8220
8221         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8222         (riscv_linux_fregset): New.
8223         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8224
8225 2019-02-07  Tom Tromey  <tom@tromey.com>
8226
8227         * thread.c (thread_cancel_execution_command): Update.
8228         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8229         methods.
8230         (struct thread_fsm_ops): Remove.
8231         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8232         (thread_fsm_should_stop, thread_fsm_return_value)
8233         (thread_fsm_set_finished, thread_fsm_finished_p)
8234         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8235         Don't declare.
8236         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8237         * infrun.c (clear_proceed_status_thread)
8238         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8239         (print_stop_event): Update.
8240         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8241         Add constructor.
8242         (step_command_fsm_ops): Remove.
8243         (new_step_command_fsm): Remove.
8244         (step_1): Update.
8245         (step_command_fsm::should_stop): Rename from
8246         step_command_fsm_should_stop.
8247         (step_command_fsm::clean_up): Rename from
8248         step_command_fsm_clean_up.
8249         (step_command_fsm::do_async_reply_reason): Rename from
8250         step_command_fsm_async_reply_reason.
8251         (struct until_next_fsm): Inherit from thread_fsm.  Add
8252         constructor.
8253         (until_next_fsm_ops): Remove.
8254         (new_until_next_fsm): Remove.
8255         (until_next_fsm::should_stop): Rename from
8256         until_next_fsm_should_stop.
8257         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8258         (until_next_fsm::do_async_reply_reason): Rename from
8259         until_next_fsm_async_reply_reason.
8260         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8261         constructor.  Change type of breakpoint.
8262         (finish_command_fsm_ops): Remove.
8263         (new_finish_command_fsm): Remove.
8264         (finish_command_fsm::should_stop): Rename from
8265         finish_command_fsm_should_stop.
8266         (finish_command_fsm::clean_up): Rename from
8267         finish_command_fsm_clean_up.
8268         (finish_command_fsm::return_value): Rename from
8269         finish_command_fsm_return_value.
8270         (finish_command_fsm::do_async_reply_reason): Rename from
8271         finish_command_fsm_async_reply_reason.
8272         (finish_command): Update.
8273         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8274         Add constructor.
8275         (call_thread_fsm_ops): Remove.
8276         (call_thread_fsm::call_thread_fsm): Rename from
8277         new_call_thread_fsm.
8278         (call_thread_fsm::should_stop): Rename from
8279         call_thread_fsm_should_stop.
8280         (call_thread_fsm::should_notify_stop): Rename from
8281         call_thread_fsm_should_notify_stop.
8282         (run_inferior_call, call_function_by_hand_dummy): Update.
8283         * cli/cli-interp.c (should_print_stop_to_console): Update.
8284         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8285         Add constructor.  Change type of location_breakpoint,
8286         caller_breakpoint.
8287         (until_break_fsm_ops): Remove.
8288         (new_until_break_fsm): Remove.
8289         (until_break_fsm::should_stop): Rename from
8290         until_break_fsm_should_stop.
8291         (until_break_fsm::clean_up): Rename from
8292         until_break_fsm_clean_up.
8293         (until_break_fsm::do_async_reply_reason): Rename from
8294         until_break_fsm_async_reply_reason.
8295         (until_break_command): Update.
8296         * thread-fsm.c: Remove.
8297         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8298
8299 2019-02-07  Tom Tromey  <tom@tromey.com>
8300
8301         * yy-remap.h: Add include guard.
8302         * xtensa-tdep.h: Add include guard.
8303         * xcoffread.h: Rename include guard.
8304         * varobj-iter.h: Add include guard.
8305         * tui/tui.h: Rename include guard.
8306         * tui/tui-winsource.h: Rename include guard.
8307         * tui/tui-wingeneral.h: Rename include guard.
8308         * tui/tui-windata.h: Rename include guard.
8309         * tui/tui-win.h: Rename include guard.
8310         * tui/tui-stack.h: Rename include guard.
8311         * tui/tui-source.h: Rename include guard.
8312         * tui/tui-regs.h: Rename include guard.
8313         * tui/tui-out.h: Rename include guard.
8314         * tui/tui-layout.h: Rename include guard.
8315         * tui/tui-io.h: Rename include guard.
8316         * tui/tui-hooks.h: Rename include guard.
8317         * tui/tui-file.h: Rename include guard.
8318         * tui/tui-disasm.h: Rename include guard.
8319         * tui/tui-data.h: Rename include guard.
8320         * tui/tui-command.h: Rename include guard.
8321         * tic6x-tdep.h: Add include guard.
8322         * target/waitstatus.h: Rename include guard.
8323         * target/wait.h: Rename include guard.
8324         * target/target.h: Rename include guard.
8325         * target/resume.h: Rename include guard.
8326         * target-float.h: Rename include guard.
8327         * stabsread.h: Add include guard.
8328         * rs6000-tdep.h: Add include guard.
8329         * riscv-fbsd-tdep.h: Add include guard.
8330         * regformats/regdef.h: Rename include guard.
8331         * record.h: Rename include guard.
8332         * python/python.h: Rename include guard.
8333         * python/python-internal.h: Rename include guard.
8334         * python/py-stopevent.h: Rename include guard.
8335         * python/py-ref.h: Rename include guard.
8336         * python/py-record.h: Rename include guard.
8337         * python/py-record-full.h: Rename include guard.
8338         * python/py-record-btrace.h: Rename include guard.
8339         * python/py-instruction.h: Rename include guard.
8340         * python/py-events.h: Rename include guard.
8341         * python/py-event.h: Rename include guard.
8342         * procfs.h: Add include guard.
8343         * proc-utils.h: Add include guard.
8344         * p-lang.h: Add include guard.
8345         * or1k-tdep.h: Rename include guard.
8346         * observable.h: Rename include guard.
8347         * nto-tdep.h: Rename include guard.
8348         * nat/x86-linux.h: Rename include guard.
8349         * nat/x86-linux-dregs.h: Rename include guard.
8350         * nat/x86-gcc-cpuid.h: Add include guard.
8351         * nat/x86-dregs.h: Rename include guard.
8352         * nat/x86-cpuid.h: Rename include guard.
8353         * nat/ppc-linux.h: Rename include guard.
8354         * nat/mips-linux-watch.h: Rename include guard.
8355         * nat/linux-waitpid.h: Rename include guard.
8356         * nat/linux-ptrace.h: Rename include guard.
8357         * nat/linux-procfs.h: Rename include guard.
8358         * nat/linux-osdata.h: Rename include guard.
8359         * nat/linux-nat.h: Rename include guard.
8360         * nat/linux-namespaces.h: Rename include guard.
8361         * nat/linux-btrace.h: Rename include guard.
8362         * nat/glibc_thread_db.h: Rename include guard.
8363         * nat/gdb_thread_db.h: Rename include guard.
8364         * nat/gdb_ptrace.h: Rename include guard.
8365         * nat/fork-inferior.h: Rename include guard.
8366         * nat/amd64-linux-siginfo.h: Rename include guard.
8367         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8368         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8369         * nat/aarch64-linux.h: Rename include guard.
8370         * nat/aarch64-linux-hw-point.h: Rename include guard.
8371         * mn10300-tdep.h: Add include guard.
8372         * mips-linux-tdep.h: Add include guard.
8373         * mi/mi-parse.h: Rename include guard.
8374         * mi/mi-out.h: Rename include guard.
8375         * mi/mi-main.h: Rename include guard.
8376         * mi/mi-interp.h: Rename include guard.
8377         * mi/mi-getopt.h: Rename include guard.
8378         * mi/mi-console.h: Rename include guard.
8379         * mi/mi-common.h: Rename include guard.
8380         * mi/mi-cmds.h: Rename include guard.
8381         * mi/mi-cmd-break.h: Rename include guard.
8382         * m2-lang.h: Add include guard.
8383         * location.h: Rename include guard.
8384         * linux-record.h: Rename include guard.
8385         * linux-nat.h: Add include guard.
8386         * linux-fork.h: Add include guard.
8387         * i386-darwin-tdep.h: Rename include guard.
8388         * hppa-linux-offsets.h: Add include guard.
8389         * guile/guile.h: Rename include guard.
8390         * guile/guile-internal.h: Rename include guard.
8391         * gnu-nat.h: Rename include guard.
8392         * gdb-stabs.h: Rename include guard.
8393         * frv-tdep.h: Add include guard.
8394         * f-lang.h: Add include guard.
8395         * event-loop.h: Add include guard.
8396         * darwin-nat.h: Rename include guard.
8397         * cp-abi.h: Rename include guard.
8398         * config/sparc/nm-sol2.h: Rename include guard.
8399         * config/nm-nto.h: Rename include guard.
8400         * config/nm-linux.h: Add include guard.
8401         * config/i386/nm-i386gnu.h: Rename include guard.
8402         * config/djgpp/nl_types.h: Rename include guard.
8403         * config/djgpp/langinfo.h: Rename include guard.
8404         * compile/gcc-cp-plugin.h: Add include guard.
8405         * compile/gcc-c-plugin.h: Add include guard.
8406         * compile/compile.h: Rename include guard.
8407         * compile/compile-object-run.h: Rename include guard.
8408         * compile/compile-object-load.h: Rename include guard.
8409         * compile/compile-internal.h: Rename include guard.
8410         * compile/compile-cplus.h: Rename include guard.
8411         * compile/compile-c.h: Rename include guard.
8412         * common/xml-utils.h: Rename include guard.
8413         * common/x86-xstate.h: Rename include guard.
8414         * common/version.h: Rename include guard.
8415         * common/vec.h: Rename include guard.
8416         * common/tdesc.h: Rename include guard.
8417         * common/selftest.h: Rename include guard.
8418         * common/scoped_restore.h: Rename include guard.
8419         * common/scoped_mmap.h: Rename include guard.
8420         * common/scoped_fd.h: Rename include guard.
8421         * common/safe-iterator.h: Rename include guard.
8422         * common/run-time-clock.h: Rename include guard.
8423         * common/refcounted-object.h: Rename include guard.
8424         * common/queue.h: Rename include guard.
8425         * common/ptid.h: Rename include guard.
8426         * common/print-utils.h: Rename include guard.
8427         * common/preprocessor.h: Rename include guard.
8428         * common/pathstuff.h: Rename include guard.
8429         * common/observable.h: Rename include guard.
8430         * common/netstuff.h: Rename include guard.
8431         * common/job-control.h: Rename include guard.
8432         * common/host-defs.h: Rename include guard.
8433         * common/gdb_wait.h: Rename include guard.
8434         * common/gdb_vecs.h: Rename include guard.
8435         * common/gdb_unlinker.h: Rename include guard.
8436         * common/gdb_unique_ptr.h: Rename include guard.
8437         * common/gdb_tilde_expand.h: Rename include guard.
8438         * common/gdb_sys_time.h: Rename include guard.
8439         * common/gdb_string_view.h: Rename include guard.
8440         * common/gdb_splay_tree.h: Rename include guard.
8441         * common/gdb_setjmp.h: Rename include guard.
8442         * common/gdb_ref_ptr.h: Rename include guard.
8443         * common/gdb_optional.h: Rename include guard.
8444         * common/gdb_locale.h: Rename include guard.
8445         * common/gdb_assert.h: Rename include guard.
8446         * common/filtered-iterator.h: Rename include guard.
8447         * common/filestuff.h: Rename include guard.
8448         * common/fileio.h: Rename include guard.
8449         * common/environ.h: Rename include guard.
8450         * common/common-utils.h: Rename include guard.
8451         * common/common-types.h: Rename include guard.
8452         * common/common-regcache.h: Rename include guard.
8453         * common/common-inferior.h: Rename include guard.
8454         * common/common-gdbthread.h: Rename include guard.
8455         * common/common-exceptions.h: Rename include guard.
8456         * common/common-defs.h: Rename include guard.
8457         * common/common-debug.h: Rename include guard.
8458         * common/cleanups.h: Rename include guard.
8459         * common/buffer.h: Rename include guard.
8460         * common/btrace-common.h: Rename include guard.
8461         * common/break-common.h: Rename include guard.
8462         * cli/cli-utils.h: Rename include guard.
8463         * cli/cli-style.h: Rename include guard.
8464         * cli/cli-setshow.h: Rename include guard.
8465         * cli/cli-script.h: Rename include guard.
8466         * cli/cli-interp.h: Rename include guard.
8467         * cli/cli-decode.h: Rename include guard.
8468         * cli/cli-cmds.h: Rename include guard.
8469         * charset-list.h: Add include guard.
8470         * buildsym-legacy.h: Rename include guard.
8471         * bfin-tdep.h: Add include guard.
8472         * ax.h: Rename include guard.
8473         * arm-linux-tdep.h: Add include guard.
8474         * arm-fbsd-tdep.h: Add include guard.
8475         * arch/xtensa.h: Rename include guard.
8476         * arch/tic6x.h: Add include guard.
8477         * arch/i386.h: Add include guard.
8478         * arch/arm.h: Rename include guard.
8479         * arch/arm-linux.h: Rename include guard.
8480         * arch/arm-get-next-pcs.h: Rename include guard.
8481         * arch/amd64.h: Add include guard.
8482         * arch/aarch64-insn.h: Rename include guard.
8483         * arch-utils.h: Rename include guard.
8484         * annotate.h: Add include guard.
8485         * amd64-darwin-tdep.h: Rename include guard.
8486         * aarch64-linux-tdep.h: Add include guard.
8487         * aarch64-fbsd-tdep.h: Add include guard.
8488         * aarch32-linux-nat.h: Add include guard.
8489
8490 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8491
8492         * macrotab.c (macro_define_internal): New function that
8493         factorizes macro_define_object_internal and macro_define_function
8494         code.
8495         (macro_define_object_internal): Use macro_define_internal.
8496         (macro_define_function): Likewise.
8497
8498 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8499
8500         * macrocmd.c (extract_identifier): Return
8501         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8502         callers.
8503
8504 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8505
8506         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8507
8508 2019-02-05  Tom Tromey  <tom@tromey.com>
8509
8510         * target.c (target_stack::unpush): Move assertion earlier.
8511
8512 2019-01-30  Tom Tromey  <tom@tromey.com>
8513
8514         PR python/23615:
8515         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8516         (gdbpy_parse_and_eval): Likewise.
8517         * python/python-internal.h (gdbpy_allow_threads): New class.
8518
8519 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8520
8521         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8522         (aarch64_fbsd_fpregmap): Move earlier.
8523         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8524         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8525         instead of individual calls to trad_frame_set_reg_addr.
8526         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8527         earlier.
8528         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8529         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8530         instead of individual calls to trad_frame_set_reg_addr.
8531
8532 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8533
8534         * CONTRIBUTE: Replace contribution list with wiki link.
8535
8536 2019-01-25  Tom Tromey  <tom@tromey.com>
8537
8538         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8539
8540 2019-01-25  Tom Tromey  <tom@tromey.com>
8541
8542         * xtensa-linux-nat.c: Fix common/ includes.
8543         * xml-support.h: Fix common/ includes.
8544         * xml-support.c: Fix common/ includes.
8545         * x86-linux-nat.c: Fix common/ includes.
8546         * windows-nat.c: Fix common/ includes.
8547         * varobj.h: Fix common/ includes.
8548         * varobj.c: Fix common/ includes.
8549         * value.c: Fix common/ includes.
8550         * valops.c: Fix common/ includes.
8551         * utils.c: Fix common/ includes.
8552         * unittests/xml-utils-selftests.c: Fix common/ includes.
8553         * unittests/utils-selftests.c: Fix common/ includes.
8554         * unittests/unpack-selftests.c: Fix common/ includes.
8555         * unittests/tracepoint-selftests.c: Fix common/ includes.
8556         * unittests/style-selftests.c: Fix common/ includes.
8557         * unittests/string_view-selftests.c: Fix common/ includes.
8558         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8559         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8560         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8561         * unittests/rsp-low-selftests.c: Fix common/ includes.
8562         * unittests/parse-connection-spec-selftests.c: Fix common/
8563         includes.
8564         * unittests/optional-selftests.c: Fix common/ includes.
8565         * unittests/offset-type-selftests.c: Fix common/ includes.
8566         * unittests/observable-selftests.c: Fix common/ includes.
8567         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8568         * unittests/memrange-selftests.c: Fix common/ includes.
8569         * unittests/memory-map-selftests.c: Fix common/ includes.
8570         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8571         * unittests/function-view-selftests.c: Fix common/ includes.
8572         * unittests/environ-selftests.c: Fix common/ includes.
8573         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8574         * unittests/common-utils-selftests.c: Fix common/ includes.
8575         * unittests/cli-utils-selftests.c: Fix common/ includes.
8576         * unittests/array-view-selftests.c: Fix common/ includes.
8577         * ui-file.c: Fix common/ includes.
8578         * tui/tui-io.c: Fix common/ includes.
8579         * tracepoint.h: Fix common/ includes.
8580         * tracepoint.c: Fix common/ includes.
8581         * tracefile-tfile.c: Fix common/ includes.
8582         * top.h: Fix common/ includes.
8583         * top.c: Fix common/ includes.
8584         * thread.c: Fix common/ includes.
8585         * target/waitstatus.h: Fix common/ includes.
8586         * target/waitstatus.c: Fix common/ includes.
8587         * target.h: Fix common/ includes.
8588         * target.c: Fix common/ includes.
8589         * target-memory.c: Fix common/ includes.
8590         * target-descriptions.c: Fix common/ includes.
8591         * symtab.h: Fix common/ includes.
8592         * symfile.c: Fix common/ includes.
8593         * stap-probe.c: Fix common/ includes.
8594         * spu-linux-nat.c: Fix common/ includes.
8595         * sparc-nat.c: Fix common/ includes.
8596         * source.c: Fix common/ includes.
8597         * solib.c: Fix common/ includes.
8598         * solib-target.c: Fix common/ includes.
8599         * ser-unix.c: Fix common/ includes.
8600         * ser-tcp.c: Fix common/ includes.
8601         * ser-pipe.c: Fix common/ includes.
8602         * ser-base.c: Fix common/ includes.
8603         * selftest-arch.c: Fix common/ includes.
8604         * s12z-tdep.c: Fix common/ includes.
8605         * rust-exp.y: Fix common/ includes.
8606         * rs6000-aix-tdep.c: Fix common/ includes.
8607         * riscv-tdep.c: Fix common/ includes.
8608         * remote.c: Fix common/ includes.
8609         * remote-notif.h: Fix common/ includes.
8610         * remote-fileio.h: Fix common/ includes.
8611         * remote-fileio.c: Fix common/ includes.
8612         * regcache.h: Fix common/ includes.
8613         * regcache.c: Fix common/ includes.
8614         * record-btrace.c: Fix common/ includes.
8615         * python/python.c: Fix common/ includes.
8616         * python/py-type.c: Fix common/ includes.
8617         * python/py-inferior.c: Fix common/ includes.
8618         * progspace.h: Fix common/ includes.
8619         * producer.c: Fix common/ includes.
8620         * procfs.c: Fix common/ includes.
8621         * proc-api.c: Fix common/ includes.
8622         * printcmd.c: Fix common/ includes.
8623         * ppc-linux-nat.c: Fix common/ includes.
8624         * parser-defs.h: Fix common/ includes.
8625         * osdata.c: Fix common/ includes.
8626         * obsd-nat.c: Fix common/ includes.
8627         * nat/x86-linux.c: Fix common/ includes.
8628         * nat/x86-linux-dregs.c: Fix common/ includes.
8629         * nat/x86-dregs.h: Fix common/ includes.
8630         * nat/x86-dregs.c: Fix common/ includes.
8631         * nat/ppc-linux.c: Fix common/ includes.
8632         * nat/mips-linux-watch.h: Fix common/ includes.
8633         * nat/mips-linux-watch.c: Fix common/ includes.
8634         * nat/linux-waitpid.c: Fix common/ includes.
8635         * nat/linux-ptrace.h: Fix common/ includes.
8636         * nat/linux-ptrace.c: Fix common/ includes.
8637         * nat/linux-procfs.c: Fix common/ includes.
8638         * nat/linux-personality.c: Fix common/ includes.
8639         * nat/linux-osdata.c: Fix common/ includes.
8640         * nat/linux-namespaces.c: Fix common/ includes.
8641         * nat/linux-btrace.h: Fix common/ includes.
8642         * nat/linux-btrace.c: Fix common/ includes.
8643         * nat/fork-inferior.c: Fix common/ includes.
8644         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8645         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8646         * nat/aarch64-linux.c: Fix common/ includes.
8647         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8648         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8649         * namespace.h: Fix common/ includes.
8650         * mips-linux-tdep.c: Fix common/ includes.
8651         * minsyms.c: Fix common/ includes.
8652         * mi/mi-parse.h: Fix common/ includes.
8653         * mi/mi-main.c: Fix common/ includes.
8654         * mi/mi-cmd-env.c: Fix common/ includes.
8655         * memrange.h: Fix common/ includes.
8656         * memattr.c: Fix common/ includes.
8657         * maint.h: Fix common/ includes.
8658         * maint.c: Fix common/ includes.
8659         * main.c: Fix common/ includes.
8660         * machoread.c: Fix common/ includes.
8661         * location.c: Fix common/ includes.
8662         * linux-thread-db.c: Fix common/ includes.
8663         * linux-nat.c: Fix common/ includes.
8664         * linux-fork.c: Fix common/ includes.
8665         * inline-frame.c: Fix common/ includes.
8666         * infrun.c: Fix common/ includes.
8667         * inflow.c: Fix common/ includes.
8668         * inferior.h: Fix common/ includes.
8669         * inferior.c: Fix common/ includes.
8670         * infcmd.c: Fix common/ includes.
8671         * inf-ptrace.c: Fix common/ includes.
8672         * inf-child.c: Fix common/ includes.
8673         * ia64-linux-nat.c: Fix common/ includes.
8674         * i387-tdep.c: Fix common/ includes.
8675         * i386-tdep.c: Fix common/ includes.
8676         * i386-linux-tdep.c: Fix common/ includes.
8677         * i386-linux-nat.c: Fix common/ includes.
8678         * i386-go32-tdep.c: Fix common/ includes.
8679         * i386-fbsd-tdep.c: Fix common/ includes.
8680         * i386-fbsd-nat.c: Fix common/ includes.
8681         * guile/scm-type.c: Fix common/ includes.
8682         * guile/guile.c: Fix common/ includes.
8683         * go32-nat.c: Fix common/ includes.
8684         * gnu-nat.c: Fix common/ includes.
8685         * gdbthread.h: Fix common/ includes.
8686         * gdbarch-selftests.c: Fix common/ includes.
8687         * gdb_usleep.c: Fix common/ includes.
8688         * gdb_select.h: Fix common/ includes.
8689         * gdb_bfd.c: Fix common/ includes.
8690         * gcore.c: Fix common/ includes.
8691         * fork-child.c: Fix common/ includes.
8692         * findvar.c: Fix common/ includes.
8693         * fbsd-nat.c: Fix common/ includes.
8694         * event-top.c: Fix common/ includes.
8695         * event-loop.c: Fix common/ includes.
8696         * dwarf2read.c: Fix common/ includes.
8697         * dwarf2loc.c: Fix common/ includes.
8698         * dwarf2-frame.c: Fix common/ includes.
8699         * dwarf-index-cache.c: Fix common/ includes.
8700         * dtrace-probe.c: Fix common/ includes.
8701         * disasm-selftests.c: Fix common/ includes.
8702         * defs.h: Fix common/ includes.
8703         * csky-tdep.c: Fix common/ includes.
8704         * cp-valprint.c: Fix common/ includes.
8705         * cp-support.h: Fix common/ includes.
8706         * cp-support.c: Fix common/ includes.
8707         * corelow.c: Fix common/ includes.
8708         * completer.h: Fix common/ includes.
8709         * completer.c: Fix common/ includes.
8710         * compile/compile.c: Fix common/ includes.
8711         * compile/compile-loc2c.c: Fix common/ includes.
8712         * compile/compile-cplus-types.c: Fix common/ includes.
8713         * compile/compile-cplus-symbols.c: Fix common/ includes.
8714         * command.h: Fix common/ includes.
8715         * cli/cli-dump.c: Fix common/ includes.
8716         * cli/cli-cmds.c: Fix common/ includes.
8717         * charset.c: Fix common/ includes.
8718         * build-id.c: Fix common/ includes.
8719         * btrace.h: Fix common/ includes.
8720         * btrace.c: Fix common/ includes.
8721         * breakpoint.h: Fix common/ includes.
8722         * breakpoint.c: Fix common/ includes.
8723         * ax.h:
8724         (enum agent_op): Fix common/ includes.
8725         * ax-general.c (struct aop_map): Fix common/ includes.
8726         * ax-gdb.c: Fix common/ includes.
8727         * auxv.c: Fix common/ includes.
8728         * auto-load.c: Fix common/ includes.
8729         * arm-tdep.c: Fix common/ includes.
8730         * arch/riscv.c: Fix common/ includes.
8731         * arch/ppc-linux-common.c: Fix common/ includes.
8732         * arch/i386.c: Fix common/ includes.
8733         * arch/arm.c: Fix common/ includes.
8734         * arch/arm-linux.c: Fix common/ includes.
8735         * arch/arm-get-next-pcs.c: Fix common/ includes.
8736         * arch/amd64.c: Fix common/ includes.
8737         * arch/aarch64.c: Fix common/ includes.
8738         * arch/aarch64-insn.c: Fix common/ includes.
8739         * arch-utils.c: Fix common/ includes.
8740         * amd64-windows-tdep.c: Fix common/ includes.
8741         * amd64-tdep.c: Fix common/ includes.
8742         * amd64-sol2-tdep.c: Fix common/ includes.
8743         * amd64-obsd-tdep.c: Fix common/ includes.
8744         * amd64-nbsd-tdep.c: Fix common/ includes.
8745         * amd64-linux-tdep.c: Fix common/ includes.
8746         * amd64-linux-nat.c: Fix common/ includes.
8747         * amd64-fbsd-tdep.c: Fix common/ includes.
8748         * amd64-fbsd-nat.c: Fix common/ includes.
8749         * amd64-dicos-tdep.c: Fix common/ includes.
8750         * amd64-darwin-tdep.c: Fix common/ includes.
8751         * agent.c: Fix common/ includes.
8752         * ada-lang.h: Fix common/ includes.
8753         * ada-lang.c: Fix common/ includes.
8754         * aarch64-tdep.c: Fix common/ includes.
8755
8756 2019-01-25  Tom Tromey  <tom@tromey.com>
8757
8758         * common/create-version.sh: Use common/version.h.
8759
8760 2019-01-24  Pedro Alves  <palves@redhat.com>
8761
8762         * infrun.c (signal_stop, signal_print, signal_program)
8763         (signal_catch, signal_pass): Now arrays instead of pointers.
8764         (update_signals_program_target, do_target_resume)
8765         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8766         * linux-nat.c (linux_nat_target::pass_signals)
8767         (linux_nat_target::create_inferior, linux_nat_target::attach):
8768         Adjust.
8769         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8770         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8771         * procfs.c (procfs_target::pass_signals): Adjust.
8772         * record-full.c (record_full_target::resume): Adjust.
8773         * remote.c (remote_target::pass_signals)
8774         (remote_target::program_signals): Adjust.
8775         * target-debug.h (target_debug_print_signals): Now takes a
8776         gdb::array_view as parameter.  Adjust.
8777         * target.h (target_ops) <pass_signals, program_signals>: Replace
8778         pointer and length parameters with gdb::array_view.
8779         (target_pass_signals, target_program_signals): Likewise.
8780         * target-delegates.c: Regenerate.
8781
8782 2019-01-24  Pedro Alves  <palves@redhat.com>
8783
8784         * common/forward-scope-exit.h
8785         (forward_scope_exit::forward_scope_exit): Pass arguments to
8786         m_bind_function directly, instead of creating a std::bind and
8787         copying that.
8788
8789 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8790
8791         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8792         for static members.
8793         (pass_in_v_vfp_candidate): Likewise.
8794
8795 2019-01-23  Tom Tromey  <tom@tromey.com>
8796             Pedro Alves  <palves@redhat.com>
8797
8798         * regcache.c (class regcache_invalidator): Remove.
8799         (regcache::raw_write): Use make_scope_exit.
8800
8801 2019-01-23  Tom Tromey  <tom@tromey.com>
8802
8803         * ui-out.h (class ui_out_emit_type): Update comment.
8804
8805 2019-01-23  Tom Tromey  <tom@tromey.com>
8806
8807         * infrun.c (fetch_inferior_event): Update comment.
8808
8809 2019-01-23  Tom Tromey  <tom@tromey.com>
8810             Pedro Alves  <palves@redhat.com>
8811
8812         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8813         parameter.
8814         (fetch_inferior_event): Use SCOPE_EXIT.
8815
8816
8817 2019-01-23  Tom Tromey  <tom@tromey.com>
8818             Pedro Alves  <palves@redhat.com>
8819
8820         * infrun.c (disable_thread_events): Delete.
8821         (stop_all_threads): Use SCOPE_EXIT.
8822
8823 2019-01-23  Tom Tromey  <tom@tromey.com>
8824             Pedro Alves  <palves@redhat.com>
8825
8826         * symfile.c: Include forward-scope-exit.h.
8827         (clear_symtab_users_cleanup): Replace forward declaration with
8828         a FORWARD_SCOPE_EXIT.
8829         (syms_from_objfile_1): Use the forward_scope_exit and
8830         gdb::optional instead of cleanup_function.
8831         (reread_symbols): Use the forward_scope_exit instead of
8832         cleanup_function.
8833         (clear_symtab_users_cleanup): Remove function.
8834
8835 2019-01-23  Tom Tromey  <tom@tromey.com>
8836             Pedro Alves  <palves@redhat.com>
8837
8838         * linux-nat.c: Include scope-exit.h.
8839         (cleanup_target_stop): Remove.
8840         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8841         SCOPE_EXIT.
8842
8843 2019-01-23  Tom Tromey  <tom@tromey.com>
8844             Pedro Alves  <palves@redhat.com>
8845
8846         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8847         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8848
8849 2019-01-23  Tom Tromey  <tom@tromey.com>
8850             Andrew Burgess  <andrew.burgess@embecosm.com>
8851             Pedro Alves  <palves@redhat.com>
8852
8853         * infrun.c (fetch_inferior_event): Use scope_exit.
8854         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8855         * top.c (execute_command): Use scope_exit.
8856         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8857         * utils.c (do_bpstat_clear_actions_cleanup)
8858         (make_bpstat_clear_actions_cleanup): Remove.
8859
8860 2019-01-23  Tom Tromey  <tom@tromey.com>
8861             Pedro Alves  <palves@redhat.com>
8862
8863         * infrun.c: Include "common/scope-exit.h"
8864         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8865         (wait_for_inferior): Use SCOPE_EXIT.
8866         (fetch_inferior_event): Use scope_exit.
8867
8868 2019-01-23  Tom Tromey  <tom@tromey.com>
8869             Pedro Alves  <palves@redhat.com>
8870
8871         * breakpoint.c (create_breakpoint): Remove cleanup.
8872
8873 2019-01-23  Tom Tromey  <tom@tromey.com>
8874             Andrew Burgess  <andrew.burgess@embecosm.com>
8875             Pedro Alves  <palves@redhat.com>
8876
8877 2019-01-23  Pedro Alves  <palves@redhat.com>
8878
8879         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8880
8881 2019-01-23  Pedro Alves  <palves@redhat.com>
8882             Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * gdbthread.h: Include "common/forward-scope-exit.h".
8885         (scoped_finish_thread_state): Redefine custom class in terms of
8886         forward_scope_exit.
8887
8888 2019-01-23  Pedro Alves  <palves@redhat.com>
8889             Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * common/forward-scope-exit.h: New file.
8892
8893 2019-01-23  Pedro Alves  <palves@redhat.com>
8894             Andrew Burgess  <andrew.burgess@embecosm.com>
8895             Tom Tromey  <tom@tromey.com>
8896
8897         * common/scope-exit.h: New file.
8898
8899 2019-01-23  Pedro Alves  <palves@redhat.com>
8900
8901         * common/preprocessor.h (ESC): Rename to ...
8902         (ESC_PARENS): ... this.
8903         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8904         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8905
8906 2019-01-23  Tom Tromey  <tom@tromey.com>
8907
8908         * language.h (class scoped_switch_to_sym_language_if_auto):
8909         Initialize m_lang in both cases.
8910
8911 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8912
8913         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8914         with XCNEW.
8915
8916 2019-01-22  Tom Tromey  <tom@tromey.com>
8917
8918         * corelow.c: Do not include sys/file.h.
8919
8920 2019-01-22  Tom Tromey  <tom@tromey.com>
8921
8922         * tui/tui-wingeneral.h: Include gdb_curses.h.
8923
8924 2019-01-22  Tom Tromey  <tom@tromey.com>
8925
8926         * source-cache.h (class source_cache) <get_source_lines,
8927         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8928
8929 2019-01-22  Tom Tromey  <tom@tromey.com>
8930
8931         * remote-fileio.h (struct remote_target): Declare.
8932
8933 2019-01-22  Tom Tromey  <tom@tromey.com>
8934
8935         * python/py-arch.c: Do not include py-ref.h.
8936         * python/py-bpevent.c: Do not include py-ref.h.
8937         * python/py-cmd.c: Do not include py-ref.h.
8938         * python/py-continueevent.c: Do not include py-ref.h.
8939         * python/py-event.h: Do not include py-ref.h.
8940         * python/py-evtregistry.c: Do not include py-ref.h.
8941         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8942         * python/py-frame.c: Do not include py-ref.h.
8943         * python/py-framefilter.c: Do not include py-ref.h.
8944         * python/py-function.c: Do not include py-ref.h.
8945         * python/py-infevents.c: Do not include py-ref.h.
8946         * python/py-linetable.c: Do not include py-ref.h.
8947         * python/py-objfile.c: Do not include py-ref.h.
8948         * python/py-param.c: Do not include py-ref.h.
8949         * python/py-prettyprint.c: Do not include py-ref.h.
8950         * python/py-progspace.c: Do not include py-ref.h.
8951         * python/py-symbol.c: Do not include py-ref.h.
8952         * python/py-symtab.c: Do not include py-ref.h.
8953         * python/py-type.c: Do not include py-ref.h.
8954         * python/py-unwind.c: Do not include py-ref.h.
8955         * python/py-utils.c: Do not include py-ref.h.
8956         * python/py-value.c: Do not include py-ref.h.
8957         * python/py-varobj.c: Do not include py-ref.h.
8958         * python/py-xmethods.c: Do not include py-ref.h.
8959         * python/python.c: Do not include py-ref.h.
8960         * varobj.c: Do not include py-ref.h.
8961
8962 2019-01-22  Tom Tromey  <tom@tromey.com>
8963
8964         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8965         keyword for bcache.
8966
8967 2019-01-22  Tom Tromey  <tom@tromey.com>
8968
8969         * compile/compile-cplus-types.c: Remove a comment by #include.
8970
8971 2019-01-22  Tom Tromey  <tom@tromey.com>
8972
8973         * compile/gcc-c-plugin.h: Include compile-internal.h.
8974
8975 2019-01-22  Tom Tromey  <tom@tromey.com>
8976
8977         * stabsread.c (EXTERN): Do not define.
8978         (symnum, next_symbol_text_func, processing_gcc_compilation)
8979         (within_function, global_sym_chain, global_stabs)
8980         (previous_stab_code, this_object_header_files)
8981         (n_this_object_header_files)
8982         (n_allocated_this_object_header_files): Define.
8983         * stabsread.h (EXTERN): Never define.  Use "extern".
8984
8985 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8986
8987         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8988         history_value.
8989
8990 2019-01-21  Tom Tromey  <tom@tromey.com>
8991
8992         * ui-out.c: Fix includes.
8993         * tui/tui-source.c: Fix includes.
8994         * target.c: Fix includes.
8995         * remote.c: Fix includes.
8996         * regcache.c: Fix includes.
8997         * python/py-block.c: Fix includes.
8998         * printcmd.c: Fix includes.
8999         * or1k-tdep.c: Fix includes.
9000         * mi/mi-main.c: Fix includes.
9001         * m32r-tdep.c: Fix includes.
9002         * csky-tdep.c: Fix includes.
9003         * compile/compile-cplus-types.c: Fix includes.
9004         * cli/cli-interp.c: Fix includes.
9005
9006 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9007
9008         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9009         for padding.
9010
9011 2019-01-16  Tom Tromey  <tom@tromey.com>
9012
9013         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9014         earlier.
9015         (struct objfile) <msymbols_range>: Move from top level.
9016         <msymbols>: New method.
9017         (class objfile_msymbols): Remove.
9018         * symtab.c (default_collect_symbol_completion_matches_break_on):
9019         Update.
9020         * symmisc.c (dump_msymbols): Update.
9021         * stabsread.c (scan_file_globals): Update.
9022         * objc-lang.c (info_selectors_command, info_classes_command)
9023         (find_methods): Update.
9024         * minsyms.c (find_solib_trampoline_target): Update.
9025         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9026         * coffread.c (coff_symfile_read): Update.
9027         * ada-lang.c (ada_lookup_simple_minsym)
9028         (ada_collect_symbol_completion_matches): Update.
9029
9030 2019-01-16  Tom Tromey  <tom@tromey.com>
9031
9032         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9033         type.  Remove no-argument constructor.
9034         <iterator::operator++>: Simplify.
9035         <begin>: Update.
9036         <end>: Use minimal_symbol_count.
9037
9038 2019-01-16  Tom Tromey  <tom@tromey.com>
9039
9040         * objfiles.h (struct objfile) <psymtabs>: New method.
9041         (class objfile_psymtabs): Remove.
9042         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9043         typedef.
9044         <range>: New method.
9045         (require_partial_symbols): Change return type.
9046         * psymtab.c (require_partial_symbols)
9047         (psym_expand_symtabs_matching): Update.
9048         * mdebugread.c (parse_partial_symbols): Update.
9049         * dbxread.c (dbx_end_psymtab): Update.
9050
9051 2019-01-15  Tom Tromey  <tom@tromey.com>
9052
9053         * symtab.c (lookup_objfile_from_block)
9054         (lookup_symbol_in_objfile_symtabs)
9055         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9056         (find_line_symtab, info_sources_command)
9057         (default_collect_symbol_completion_matches_break_on)
9058         (make_source_files_completion_list): Update.
9059         * symmisc.c (print_objfile_statistics, dump_objfile)
9060         (maintenance_print_symbols, maintenance_info_symtabs)
9061         (maintenance_check_symtabs, maintenance_info_line_tables):
9062         Update.
9063         * source.c (select_source_symtab)
9064         (forget_cached_source_info_for_objfile): Update.
9065         * objfiles.h (class objfile_compunits): Remove.
9066         (struct objfile) <compunits_range>: New typedef.
9067         (compunits): New method.
9068         * objfiles.c (objfile_relocate1): Update.
9069         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9070         * maint.c (count_symtabs_and_blocks): Update.
9071         * linespec.c (iterate_over_all_matching_symtabs): Update.
9072         * cp-support.c (add_symbol_overload_list_qualified): Update.
9073         * coffread.c (coff_symtab_read): Update.
9074         * ada-lang.c (add_nonlocal_symbols)
9075         (ada_collect_symbol_completion_matches)
9076         (ada_add_global_exceptions): Update.
9077
9078 2019-01-15  Tom Tromey  <tom@tromey.com>
9079
9080         * progspace.h (program_space) <objfiles_safe_range>: New
9081         typedef.
9082         <objfiles_safe>: New method.
9083         * objfiles.h (class all_objfiles_safe): Remove.
9084         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9085         * jit.c (jit_inferior_exit_hook): Update.
9086
9087 2019-01-17  Tom Tromey  <tom@tromey.com>
9088
9089         * progspace.h (program_space) <objfiles_range>: New typedef.
9090         <objfiles>: New method.
9091         <objfiles_head>: Rename from objfiles.
9092         (object_files): Update.
9093         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9094         * guile/scm-pretty-print.c
9095         (ppscm_find_pretty_printer_from_objfiles): Update.
9096         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9097         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9098         Update.
9099         * python/py-progspace.c (pspy_get_objfiles): Update.
9100         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9101         Update.
9102         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9103         (objfpy_lookup_objfile_by_build_id): Update.
9104         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9105         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9106         Update.
9107         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9108         (expand_symtab_containing_pc, lookup_objfile_from_block)
9109         (lookup_static_symbol, basic_lookup_transparent_type)
9110         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9111         (find_line_symtab, info_sources_command)
9112         (default_collect_symbol_completion_matches_break_on)
9113         (make_source_files_completion_list, find_main_name): Update.
9114         * symmisc.c (print_symbol_bcache_statistics)
9115         (print_objfile_statistics, maintenance_print_symbols)
9116         (maintenance_print_msymbols, maintenance_print_objfiles)
9117         (maintenance_info_symtabs, maintenance_check_symtabs)
9118         (maintenance_expand_symtabs, maintenance_info_line_tables):
9119         Update.
9120         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9121         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9122         (map_overlay_command, unmap_overlay_command)
9123         (simple_overlay_update, expand_symtabs_matching)
9124         (map_symbol_filenames): Update.
9125         * symfile-debug.c (set_debug_symfile): Update.
9126         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9127         Update.
9128         * source.c (select_source_symtab, forget_cached_source_info):
9129         Update.
9130         * solib.c (solib_read_symbols): Update.
9131         * solib-spu.c (append_ocl_sos): Update.
9132         * psymtab.c (maintenance_print_psymbols)
9133         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9134         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9135         * printcmd.c (info_symbol_command): Update.
9136         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9137         Update.
9138         * objfiles.h (class all_objfiles): Remove.
9139         * objfiles.c (have_partial_symbols, have_full_symbols)
9140         (have_minimal_symbols, qsort_cmp, update_section_map)
9141         (shared_objfile_contains_address_p)
9142         (default_iterate_over_objfiles_in_search_order): Update.
9143         * objc-lang.c (info_selectors_command, info_classes_command)
9144         (find_methods): Update.
9145         * minsyms.c (find_solib_trampoline_target): Update.
9146         * maint.c (maintenance_info_sections)
9147         (maintenance_translate_address, count_symtabs_and_blocks):
9148         Update.
9149         * main.c (captured_main_1): Update.
9150         * linux-thread-db.c (try_thread_db_load_from_pdir)
9151         (has_libpthread): Update.
9152         * linespec.c (iterate_over_all_matching_symtabs)
9153         (search_minsyms_for_name): Update.
9154         * jit.c (jit_find_objf_with_entry_addr): Update.
9155         * hppa-tdep.c (find_unwind_entry)
9156         (hppa_lookup_stub_minimal_symbol): Update.
9157         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9158         Update.
9159         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9160         (elf_gnu_ifunc_resolve_by_got): Update.
9161         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9162         * dwarf-index-write.c (save_gdb_index_command): Update.
9163         * cp-support.c (add_symbol_overload_list_qualified): Update.
9164         * breakpoint.c (create_overlay_event_breakpoint)
9165         (create_longjmp_master_breakpoint)
9166         (create_std_terminate_master_breakpoint)
9167         (create_exception_master_breakpoint): Update.
9168         * blockframe.c (find_pc_partial_function): Update.
9169         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9170         (ada_collect_symbol_completion_matches)
9171         (ada_add_global_exceptions): Update.
9172
9173 2019-01-17  Tom Tromey  <tom@tromey.com>
9174
9175         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9176         declare VEC.
9177         (solib_target_parse_libraries): Change return type.
9178         (library_list_start_segment, library_list_start_section)
9179         (library_list_end_library, library_list_start_library); Update.
9180         (solib_target_free_library_list): Remove.
9181         (solib_target_parse_libraries): Remove cleanup.  Change return
9182         type.
9183         (solib_target_current_sos): Update.
9184
9185 2019-01-17  Tom Tromey  <tromey@bapiya>
9186
9187         * valprint.c: Replace "the the" with "the".
9188         * symtab.c: Replace "the the" with "the".
9189         * solib.c: Replace "the the" with "the".
9190         * solib-dsbt.c: Replace "the the" with "the".
9191         * linespec.c: Replace "the the" with "the".
9192         * dwarf2loc.h: Replace "the the" with "the".
9193         * amd64-windows-tdep.c: Replace "the the" with "the".
9194         * aarch64-tdep.c: Replace "the the" with "the".
9195
9196 2019-01-16  Keith Seitz  <keiths@redhat.com>
9197
9198         PR gdb/23773
9199         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9200         <builder>: Rename to ..
9201         <m_builder>: ... this and make private.
9202         (dwarf2_cu::get_builder): New method.  Change all users of
9203         `builder' to use this method.
9204         (dwarf2_start_symtab): Move to ...
9205         (dwarf2_cu::start_symtab): ... here.  Update all callers
9206         (setup_type_unit_groups): Move to ...
9207         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9208         callers.
9209         (dwarf2_cu::reset_builder): New method.
9210         (process_full_compunit, process_full_type_unit): Use
9211         dwarf2_cu::reset_builder.
9212         (follow_die_offset): Record the ancestor CU if it is different
9213         from the followed DIE's CU.
9214         (follow_die_sig_1): Likewise.
9215
9216 2019-01-15  Tom Tromey  <tom@tromey.com>
9217
9218         * remote.c (class remote_state) <buf>: Now a char_vector.
9219         <buf_size>: Remove.
9220         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9221         parameter.
9222         (remote_target::getpkt_or_notif_sane_1)
9223         (remote_target::getpkt_sane)
9224         (remote_target::getpkt_or_notif_sane): Likewise.
9225         (class remote_target) <putpkt>: New overload.
9226         (remote_target::read_frame): Change type of "buf_p".  Remove
9227         sizeof_p parameter.
9228         (packet_ok): New overload.
9229         (packet_check_result): New overload.
9230         Update all uses.
9231
9232 2019-01-14  Tom Tromey  <tom@tromey.com>
9233
9234         * remote-notif.c (handle_notification, remote_notif_ack)
9235         (remote_notif_parse): Make "buf" const.
9236         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9237         const.
9238         (remote_notif_parse, remote_notif_ack, handle_notification):
9239         Likewise.
9240         * remote.c (remote_notif_stop_parse): Make "buf" const.
9241         (remote_target::remote_parse_stop_reply): Make "buf" const.
9242         (remote_notif_stop_ack): Make "buf" const.
9243
9244 2019-01-14  Tom Tromey  <tom@tromey.com>
9245
9246         * remote.c (remote_console_output): Make parameter const.
9247
9248 2019-01-14  Tom Tromey  <tom@tromey.com>
9249
9250         * target-debug.h (target_debug_print_signals): Constify.
9251         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9252         * procfs.c (procfs_target::pass_signals): Update.
9253         * linux-nat.c (linux_nat_target::pass_signals): Update.
9254         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9255         * target-delegates.c: Rebuild.
9256         * remote.c (remote_target::program_signals): Update.
9257         (remote_target::pass_signals): Update.
9258         * target.c (target_pass_signals): Constify argument.
9259         (target_program_signals): Likewise.
9260         * target.h (struct target_ops) <pass_signals, program_signals>:
9261         Constify argument.
9262         (target_pass_signals, target_program_signals): Constify argument.
9263
9264 2019-01-14  Tom Tromey  <tom@tromey.com>
9265
9266         PR tui/28819:
9267         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9268
9269 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9270
9271         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9272         field.
9273         * rs6000-tdep.c: Include reggroups.h.
9274         (IS_V_ALIAS_PSEUDOREG): Define.
9275         (rs6000_register_name): Return names for the "vX" aliases.
9276         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9277         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9278         aliases.  Call default_register_reggroup_p for all other
9279         pseudo-registers.
9280         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9281         New functions.
9282         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9283         Handle "vX" aliases.
9284         (v_alias_pseudo_register_collect): New function.
9285         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9286         (rs6000_gdbarch_init): Initialize "vX" aliases as
9287         pseudo-registers.  Restore registration of
9288         rs6000_pseudo_register_reggroup_p with
9289         set_tdesc_pseudo_register_reggroup_p.
9290
9291 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9292
9293         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9294         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9295         set_gdbarch_num_pseudo_regs.
9296
9297 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9298
9299         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9300         Remove arg prefixname, add do_set and do_show.
9301         Add member functions set_list and show_list.
9302         * cli/cli-style.c (class cli_style_option): Update accordingly.
9303         (style_set_list): Move to file scope.
9304         (style_show_list): Likewise.
9305         (set_style): Call help_list.
9306         (show_style): Call cmd_show_list.
9307         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9308         Update to use the new macro.
9309
9310 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9311
9312         * ada-lang.c (_initialize_ada_language): Expand the help text
9313         for the "catch exception" command.
9314
9315 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9316
9317         * symtab.c (matching_obj_sections): Initialize obj,
9318         declare it closer to its usage.
9319
9320 2019-01-10  Tom Tromey  <tom@tromey.com>
9321
9322         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9323         (basic_inf_threads_range): Remove.
9324         (inf_threads_range, inf_non_exited_threads_range)
9325         (safe_inf_threads_range): Use next_adapter.
9326
9327 2019-01-10  Keith Seitz  <keiths@redhat.com>
9328
9329         PR gdb/23712
9330         PR symtab/23010
9331         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9332         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9333
9334 2019-01-10  Keith Seitz  <keiths@redhat.com>
9335
9336         PR gdb/23712
9337         PR symtab/23010
9338         * dictionary.c (pending_to_vector): Remove.
9339         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9340         Remove _1 suffix, replacing functions of the same name.  Update
9341         all callers.
9342         (dict_create_hashed, dict_create_hashed_expandable)
9343         (dict_create_linear, dict_create_linear_expandable, dict_free)
9344         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9345         Make functions static.
9346
9347 2019-01-10  Keith Seitz  <keiths@redhat.com>
9348
9349         PR gdb/23712
9350         PR symtab/23010
9351         * dictionary.h (struct dictionary): Replace declaration with
9352         multidictionary.
9353         (dict_create_hashed, dict_create_hashed_expandable)
9354         (dict_create_linear, dict_create_linear_expandable)
9355         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9356         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9357         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9358         taking multidictionary argument.
9359         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9360         * block.h (struct block) <dict>: Change to multidictionary
9361         and rename `multidict'.
9362         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9363         symmisc.c: Update all dictionary references to multidictionary.
9364
9365 2019-01-10  Keith Seitz  <keiths@redhat.com>
9366
9367         PR gdb/23712
9368         PR symtab/23010
9369         * dictionary.c: Include unordered_map.
9370         (pending_to_vector): New function.
9371         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9372         Rewrite the non-"_1" functions to take vector instead
9373         of linked list.
9374         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9375         "new" _1 versions of the same name.
9376         (multidictionary): Define.
9377         (std::hash<enum language): New definition.
9378         (collate_pending_symbols_by_language, mdict_create_hashed)
9379         (mdict_create_hashed_expandable, mdict_create_linear)
9380         (mdict_create_linear_expandable, mdict_free)
9381         (find_language_dictionary, create_new_language_dictionary)
9382         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9383         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9384         (mdict_size, mdict_empty): New functions.
9385         * dictionary.h (mdict_iterator): Define.
9386
9387 2019-01-10  Pedro Alves  <palves@redhat.com>
9388
9389         * breakpoint.c (read_uploaded_action)
9390         (create_tracepoint_from_upload): Adjust to use
9391         gdb::unique_xmalloc_ptr.
9392         * ctf.c (ctf_write_uploaded_tp):
9393         (SET_ARRAY_FIELD): Use emplace_back.
9394         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9395         * tracefile-tfile.c (tfile_write_uploaded_tp):
9396         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9397         gdb::unique_xmalloc_ptr.
9398         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9399         at_string, cond_string, cmd_strings>: Replace char pointers
9400         with gdb::unique_xmalloc_ptr.
9401
9402 2019-01-10  Pedro Alves  <palves@redhat.com>
9403
9404         * solib-target.c (library_list_start_library): Don't xstrdup name.
9405
9406 2019-01-10  Pedro Alves  <palves@redhat.com>
9407
9408         * mdebugread.c (parse_partial_symbols): Use
9409         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9410
9411 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9412
9413         * linux-fork.c (scoped_switch_fork_info)
9414         <~scoped_switch_fork_info>: Fix incorrect variable name.
9415
9416 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9417
9418         * linux-fork.c (scoped_switch_fork_info)
9419         <scoped_switch_fork_info>: Make explicit.
9420         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9421
9422 2019-01-10  Tom Tromey  <tom@tromey.com>
9423
9424         * objfiles.h (objfile::reset_psymtabs): Update.
9425         * objfiles.c (objfile::objfile): Update.
9426         * psymtab.h (psymtab_storage::obstack): Update.
9427         (psymtab_storage::m_obstack): Use gdb::optional.
9428         (class psymtab_storage): Update comment.  Remove objfile
9429         parameter.
9430         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9431
9432 2019-01-10  Tom Tromey  <tom@tromey.com>
9433
9434         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9435         <free_psymtabs>: Now private.
9436         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9437         (allocate_psymtab): Use new method.
9438
9439 2019-01-10  Tom Tromey  <tom@tromey.com>
9440
9441         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9442         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9443         * mdebugread.c (parse_partial_symbols): Use
9444         allocate_dependencies.
9445         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9446         allocate_dependencies.
9447         (process_psymtab_comp_unit_reader)
9448         (build_type_psymtab_dependencies): Likewise.
9449         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9450
9451 2019-01-10  Tom Tromey  <tom@tromey.com>
9452
9453         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9454         PSYMBOL_SET_LANGUAGE.
9455         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9456
9457 2019-01-10  Tom Tromey  <tom@tromey.com>
9458
9459         * psymtab.h (psymtab_storage::obstack): New method.
9460         <m_obstack>: Rename from obstack; now private.
9461         * psymtab.c (psymtab_storage): Update.
9462         * dwarf2read.c (create_addrmap_from_index)
9463         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9464         Update.
9465
9466 2019-01-10  Tom Tromey  <tom@tromey.com>
9467
9468         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9469         * objfiles.h (objfile::reset_psymtabs): New method.
9470
9471 2019-01-10  Tom Tromey  <tom@tromey.com>
9472
9473         * symmisc.c (print_symbol_bcache_statistics): Update.
9474         (print_objfile_statistics): Update.
9475         * symfile.c (reread_symbols): Update.
9476         * psymtab.h (class psymtab_storage): New.
9477         * psymtab.c (psymtab_storage): New constructor.
9478         (~psymtab_storage): New destructor.
9479         (require_partial_symbols): Update.
9480         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9481         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9482         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9483         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9484         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9485         (start_psymtab_common, end_psymtab_common)
9486         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9487         (allocate_psymtab): Update.
9488         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9489         Update.
9490         (dump_psymtab_addrmap, maintenance_print_psymbols)
9491         (maintenance_check_psymtabs): Update.
9492         (class objfile_psymtabs): Move to objfiles.h.
9493         * psympriv.h (discard_psymtab): Now inline.
9494         (psymtab_discarder::psymtab_discarder): Update.
9495         (psymtab_discarder::~psymtab_discarder): Update.
9496         (ALL_OBJFILE_PSYMTABS): Rewrite.
9497         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9498         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9499         Remove fields.
9500         <partial_symtabs>: New field.
9501         (class objfile_psymtabs): Move from psymtab.h.  Update.
9502         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9503         psymbol_cache.
9504         (objfile::~objfile): Don't destroy psymbol_cache.
9505         * mdebugread.c (parse_partial_symbols): Update.
9506         * dwarf2read.c (create_addrmap_from_index)
9507         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9508         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9509         (add_partial_subprogram, dwarf2_ranges_read): Update.
9510         * dwarf-index-write.c (write_address_map)
9511         (write_one_signatured_type, recursively_write_psymbols)
9512         (class debug_names, class debug_names, write_psymtabs_to_index):
9513         Update.
9514
9515 2019-01-10  Tom Tromey  <tom@tromey.com>
9516
9517         * symtab.h (SYMBOL_SET_NAMES): Update.
9518         (symbol_set_names): Update.
9519         (MSYMBOL_SET_NAMES): Update.
9520         * symtab.c (symbol_set_names): Change argument to be an
9521         objfile_per_bfd_storage.
9522         * psymtab.c (add_psymbol_to_bcache): Update.
9523         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9524
9525 2019-01-10  Tom Tromey  <tom@tromey.com>
9526
9527         * symtab.c (create_demangled_names_hash): Change argument to be an
9528         objfile_per_bfd_storage.
9529         (symbol_set_names): Update.
9530
9531 2019-01-10  Tom Tromey  <tom@tromey.com>
9532
9533         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9534         init_psymbol_list.
9535         * psymtab.c (init_psymbol_list): Do nothing if already called.
9536         * psympriv.h (init_psymbol_list): Add comment.
9537         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9538         init_psymbol_list.
9539         * dbxread.c (dbx_symfile_read): Unconditionally call
9540         init_psymbol_list.
9541
9542 2019-01-10  Tom Tromey  <tom@tromey.com>
9543
9544         * xcoffread.c (scan_xcoff_symtab): Update.
9545         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9546         "where".
9547         * mdebugread.c (parse_partial_symbols)
9548         (handle_psymbol_enumerators): Update.
9549         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9550         * dbxread.c (read_dbx_symtab): Update.
9551         * psympriv.h (psymbol_placement): New enum.
9552         (add_psymbol_to_list): Update.
9553
9554 2019-01-10  Tom Tromey  <tom@tromey.com>
9555
9556         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9557         static_psymbols parameters.
9558         (scan_xcoff_symtab): Update.
9559         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9560         static_psymbols parameters.
9561         * psympriv.h (start_psymtab_common): Update.
9562         * mdebugread.c (parse_partial_symbols): Update.
9563         * dwarf2read.c (create_partial_symtab): Update.
9564         * dbxread.c (read_dbx_symtab): Update.
9565         (start_psymtab): Remove global_psymbols and static_psymbols
9566         parameters.
9567
9568 2019-01-10  Tom Tromey  <tom@tromey.com>
9569
9570         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9571         * psymtab.c (allocate_psymtab): Add comment.
9572         * psympriv.h (allocate_psymtab): Add comment.
9573         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9574         initializations.
9575         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9576
9577 2019-01-10  Tom Tromey  <tom@tromey.com>
9578
9579         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9580         Don't declare.
9581         * mipsread.c: Include mdebugread.h.
9582         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9583         Declare.
9584         * elfread.c: Include mdebugread.h.
9585
9586 2019-01-09  Tom Tromey  <tom@tromey.com>
9587
9588         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9589         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9590         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9591         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9592         (psym_lookup_symbol, psym_find_last_source_symtab)
9593         (psym_forget_cached_source_info, psym_print_stats)
9594         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9595         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9596         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9597         (psym_find_compunit_symtab_by_address)
9598         (maintenance_print_psymbols, maintenance_info_psymtabs)
9599         (maintenance_check_psymtabs): Use ranged for.
9600         * psymtab.h (class objfile_psymtabs): New.
9601         (require_partial_symbols): Return objfile_psymtabs.
9602         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9603
9604 2019-01-09  Tom Tromey  <tom@tromey.com>
9605
9606         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9607         (find_pc_mapped_section, list_overlays_command)
9608         (map_overlay_command, unmap_overlay_command)
9609         (simple_overlay_update): Use all_objfiles.
9610         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9611         * printcmd.c (info_symbol_command): Use all_objfiles.
9612         * objfiles.h (ALL_OBJSECTIONS): Remove.
9613         * maint.c (maintenance_translate_address): Use all_objfiles.
9614         * gcore.c (gcore_create_callback): Use all_objfiles.
9615         (objfile_find_memory_regions): Likewise.
9616
9617 2019-01-09  Tom Tromey  <tom@tromey.com>
9618
9619         * symtab.c (find_line_symtab, info_sources_command)
9620         (make_source_files_completion_list): Use objfile_compunits.
9621         * source.c (select_source_symtab): Use objfile_compunits.
9622         * objfiles.h (struct objfile): Update comment.
9623         (ALL_OBJFILES): Remove.
9624         (ALL_FILETABS): Remove.
9625         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9626         objfile_compunits.
9627
9628 2019-01-09  Tom Tromey  <tom@tromey.com>
9629
9630         * symmisc.c (print_objfile_statistics, dump_objfile)
9631         (maintenance_print_symbols): Use compunit_filetabs.
9632         * source.c (forget_cached_source_info_for_objfile): Use
9633         compunit_filetabs.
9634         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9635         (ALL_FILETABS): Use compunit_filetabs.
9636         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9637         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9638
9639 2019-01-09  Tom Tromey  <tom@tromey.com>
9640
9641         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9642         (compunit_filetabs): New.
9643         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9644         compunit_filetabs.
9645         (info_sources_command, make_source_files_completion_list): Remove
9646         declaration.
9647         * symmisc.c (print_objfile_statistics, dump_objfile)
9648         (maintenance_print_symbols): Remove declaration.
9649         (maintenance_info_symtabs): Use compunit_filetabs.
9650         (maintenance_info_line_tables): Likewise.
9651         * source.c (select_source_symtab): Change local variable name.
9652         (forget_cached_source_info_for_objfile): Remove declaration.
9653         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9654         * objfiles.c (objfile_relocate1): Remove declaration.
9655         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9656         declaration.
9657         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9658         * coffread.c (coff_symtab_read): Remove declaration.
9659         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9660         compunit_filetabs.
9661
9662 2019-01-09  Tom Tromey  <tom@tromey.com>
9663
9664         * symtab.c (lookup_objfile_from_block)
9665         (find_pc_sect_compunit_symtab, search_symbols)
9666         (default_collect_symbol_completion_matches_break_on): Use
9667         objfile_compunits.
9668         * objfiles.h (ALL_COMPUNITS): Remove.
9669         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9670         * cp-support.c (add_symbol_overload_list_qualified): Use
9671         objfile_compunits.
9672         * ada-lang.c (ada_collect_symbol_completion_matches)
9673         (ada_add_global_exceptions): Use objfile_compunits.
9674
9675 2019-01-09  Tom Tromey  <tom@tromey.com>
9676
9677         * source.c (select_source_symtab)
9678         (forget_cached_source_info_for_objfile): Remove declaration.
9679         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9680         declaration.
9681         * maint.c (count_symtabs_and_blocks): Remove declaration.
9682         * cp-support.c (add_symbol_overload_list_qualified): Remove
9683         declaration.
9684         * coffread.c (coff_symtab_read): Remove declaration.
9685         * symtab.c (lookup_symbol_in_objfile_symtabs)
9686         (basic_lookup_transparent_type_1): Use objfile_compunits.
9687         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9688         (info_sources_command, search_symbols)
9689         (default_collect_symbol_completion_matches_break_on)
9690         (make_source_files_completion_list): Remove declaration.
9691         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9692         (ada_collect_symbol_completion_matches)
9693         (ada_add_global_exceptions): Remove declaration.
9694         * linespec.c (iterate_over_all_matching_symtabs): Use
9695         objfile_compunits.
9696         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9697         (class objfile_compunits): New.
9698         (ALL_COMPUNITS): Use objfile_compunits.
9699         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9700         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9701         objfile_compunits.
9702         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9703
9704 2019-01-09  Tom Tromey  <tom@tromey.com>
9705
9706         * symtab.c (search_symbols)
9707         (default_collect_symbol_completion_matches_break_on): Use
9708         objfile_msymbols.
9709         * ada-lang.c (ada_lookup_simple_minsym)
9710         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9711         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9712         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9713         objfile_msymbols.
9714         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9715         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9716         * objc-lang.c (find_methods): Use objfile_msymbols.
9717         (info_selectors_command, info_classes_command): Likewise.
9718         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9719         * objfiles.h (class objfile_msymbols): New.
9720         (ALL_OBJFILE_MSYMBOLS): Remove.
9721         (ALL_MSYMBOLS): Remove.
9722
9723 2019-01-09  Tom Tromey  <tom@tromey.com>
9724
9725         * common/next-iterator.h (next_adapter): Add Iterator template
9726         parameter.
9727         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9728         (class all_objfiles_safe): New.
9729         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9730         * objfiles.c (put_objfile_before): Update comment.
9731         (add_separate_debug_objfile): Likewise.
9732         (free_all_objfiles): Use all_objfiles_safe.
9733         (objfile_purge_solibs): Likewise.
9734
9735 2019-01-09  Tom Tromey  <tom@tromey.com>
9736
9737         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9738         (expand_symtab_containing_pc, lookup_static_symbol)
9739         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9740         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9741         all_objfiles.
9742         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9743         * breakpoint.c (create_overlay_event_breakpoint)
9744         (create_longjmp_master_breakpoint)
9745         (create_std_terminate_master_breakpoint)
9746         (create_exception_master_breakpoint): Use all_objfiles.
9747         * linux-thread-db.c (try_thread_db_load_from_pdir)
9748         (has_libpthread): Use all_objfiles.
9749         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9750         * linespec.c (iterate_over_all_matching_symtabs)
9751         (search_minsyms_for_name): Use all_objfiles.
9752         * maint.c (maintenance_info_sections): Use all_objfiles.
9753         * main.c (captured_main_1): Use all_objfiles.
9754         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9755         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9756         * guile/scm-pretty-print.c
9757         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9758         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9759         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9760         (maintenance_print_msymbols): Use all_objfiles.
9761         * source.c (select_source_symtab): Use all_objfiles.
9762         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9763         * symfile.c (remove_symbol_file_command)
9764         (expand_symtabs_matching, map_symbol_filenames): Use
9765         all_objfiles.
9766         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9767         all_objfiles.
9768         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9769         * objc-lang.c (find_methods): Use all_objfiles.
9770         * objfiles.c (have_partial_symbols, have_full_symbols)
9771         (have_minimal_symbols, qsort_cmp)
9772         (default_iterate_over_objfiles_in_search_order): Use
9773         all_objfiles.
9774         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9775         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9776         (maintenance_check_psymtabs): Use all_objfiles.
9777         (ALL_PSYMTABS): Remove.
9778         * compile/compile-object-run.c (do_module_cleanup): Use
9779         all_objfiles.
9780         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9781         * cp-support.c (add_symbol_overload_list_qualified): Use
9782         all_objfiles.
9783         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9784         Use all_objfiles.
9785         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9786         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9787         all_objfiles.
9788         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9789         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9790         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9791         Uses all_objfiles.
9792         * solib.c (solib_read_symbols): Use all_objfiles
9793
9794 2019-01-09  Tom Tromey  <tom@tromey.com>
9795
9796         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9797         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9798         all_objfiles.
9799         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9800         * symmisc.c (print_symbol_bcache_statistics)
9801         (print_objfile_statistics, maintenance_print_objfiles)
9802         (maintenance_info_symtabs, maintenance_check_symtabs)
9803         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9804         all_objfiles.
9805         * source.c (forget_cached_source_info): Use all_objfiles.
9806         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9807         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9808         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9809         * objfiles.c (update_section_map): Use all_objfiles.
9810         (shared_objfile_contains_address_p): Likewise.
9811         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9812         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9813
9814 2019-01-09  Tom Tromey  <tom@tromey.com>
9815
9816         * common/next-iterator.h: New file.
9817         * objfiles.h (class all_objfiles): New.
9818         (struct objfile_iterator): New.
9819
9820 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9821
9822         * NEWS: Move the description of the changed "frame", "select-frame",
9823          and "info frame" commands to the Changed commands section.
9824
9825 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9826
9827         * gdbtypes.c (check_stub_method_group): Remove handling of old
9828         mangling schemes.
9829         * linespec.c (find_methods): Likewise.
9830         * stabsread.c (read_member_functions): Likewise.
9831         * valops.c (search_struct_method): Likewise.
9832         (value_struct_elt_for_reference): Likewise.
9833         * NEWS: Mention this change.
9834
9835 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9836
9837         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9838         print_source_lines.
9839         * source.c (print_source_lines_base): Update line number check.
9840         (print_source_lines): New function.
9841         (source_lines_range::source_lines_range): New function.
9842         * source.h (class source_lines_range): New class.
9843         (print_source_lines): New declaration.
9844
9845 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9846
9847         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9848
9849 2019-01-08  Tom Tromey  <tom@tromey.com>
9850             Simon Marchi  <simon.marchi@ericsson.com>
9851
9852         PR gdb/24060
9853         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9854         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9855         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9856         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9857         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9858         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9859
9860 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9861
9862         * source.c (select_source_symtab): Move header comment to
9863         declaration in source.h.
9864         (forget_cached_source_info_for_objfile): Likewise.
9865         (forget_cached_source_info): Likewise.
9866         (identify_source_line): Likewise.
9867         * source.h (identify_source_line): Move declaration from symtab.h
9868         and add comment from source.c
9869         (print_source_lines): Likewise.
9870         (forget_cached_source_info_for_objfile): Likewise.
9871         (forget_cached_source_info): Likewise.
9872         (select_source_symtab): Likewise.
9873         (enum print_source_lines_flag): Move definition from symtab.h.
9874         * symtab.h (identify_source_line): Move declaration to source.h.
9875         (print_source_lines): Likewise.
9876         (forget_cached_source_info_for_objfile): Likewise.
9877         (forget_cached_source_info): Likewise.
9878         (select_source_symtab): Likewise.
9879         (enum print_source_lines_flag): Move definition to source.h.
9880         * tui/tui-hooks.c: Add 'source.h' include.
9881
9882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9883
9884         * source.c (print_source_lines_base): Handle requests to print
9885         reverse line number sequences, and guard against empty lines
9886         string.
9887
9888 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9889
9890         * source.c (print_source_lines_base): Fix skip of '\r' if next
9891         character is '\n'.
9892
9893 2019-01-06  Tom Tromey  <tom@tromey.com>
9894
9895         * c-exp.y (struct c_parse_state) <macro_original_text,
9896         expansion_obstack>: New member.
9897         (macro_original_text, expansion_obstack): Remove globals.
9898         (scan_macro_expansion, scanning_macro_expansion)
9899         (finished_macro_expansion): Update.
9900         (scan_macro_cleanup): Remove.
9901         (yylex, c_parse): Update.
9902
9903 2019-01-06  Tom Tromey  <tom@tromey.com>
9904
9905         * c-exp.y (struct c_parse_state) <strings>: New member.
9906         (operator_stoken): Update.
9907
9908 2019-01-06  Tom Tromey  <tom@tromey.com>
9909
9910         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9911         (union type_stack_elt) <typelist_val>: Now a pointer to
9912         std::vector.
9913         (type_stack_cleanup): Don't declare.
9914         (push_typelist): Update.
9915         * parse.c (pop_typelist): Return a std::vector.
9916         (push_typelist): Take a std::vector.
9917         (follow_types): Update.  Do not free args.
9918         (type_stack_cleanup): Remove.
9919         * c-exp.y (struct c_parse_state): New.
9920         (cpstate): New global.
9921         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9922         (nonempty_typelist): Update.
9923         (func_mod): Create a new vector.
9924         (c_parse): Create a c_parse_state.
9925         (check_parameter_typelist): Do not delete params.
9926         (function_method): Update.  Do not delete type_list.
9927
9928 2019-01-06  Tom Tromey  <tom@tromey.com>
9929
9930         PR gdb/28155:
9931         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9932         check_typedef.
9933         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9934         (print_return_value): Likewise.
9935
9936 2019-01-05  Tom Tromey  <tom@tromey.com>
9937
9938         * contrib/cleanup_check.py: Remove.
9939         * contrib/gcc-with-excheck: Remove.
9940         * contrib/exsummary.py: Remove.
9941         * contrib/excheck.py: Remove.
9942
9943 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9944
9945         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9946         NULL. Initialize tpprev to NULL instead of assigning it
9947         to NULL on the next statement.
9948         * windows-nat.c (windows_delete_thread): Remove check for
9949         main_thread_id before printing thread exit notifications.
9950         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9951         Remove thread ID check against main_thread_id.
9952         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9953         windows_delete_thread.
9954         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9955
9956 2019-01-04  Tom Tromey  <tom@tromey.com>
9957
9958         * compile/compile.c (_initialize_compile): Use upper case for
9959         metasyntactic variables.
9960         * symmisc.c (_initialize_symmisc): Use upper case for
9961         metasyntactic variables.
9962         * psymtab.c (_initialize_psymtab): Use upper case for
9963         metasyntactic variables.
9964         * demangle.c (demangle_command): Use upper case for metasyntactic
9965         variables.
9966         (_initialize_demangler): Likewise.
9967         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9968         variables.
9969
9970 2019-01-03  Tom Tromey  <tom@tromey.com>
9971
9972         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9973
9974 2019-01-03  Tom Tromey  <tom@tromey.com>
9975
9976         * python/py-symtab.c (salpy_str): Update.
9977         (struct salpy_sal_object) <symtab>: Now a PyObject.
9978         (salpy_dealloc): Update.
9979         (del_objfile_sal): Use gdbpy_ref.
9980
9981 2019-01-03  Tom Tromey  <tom@tromey.com>
9982
9983         * python/py-type.c (convert_field): Use new_reference.  Return
9984         gdbpy_ref.
9985         (make_fielditem): Return gdbpy_ref.
9986         (typy_fields): Update.
9987         (typy_getitem): Update.
9988         (field_name): Return gdbpy_ref.  Use new_reference.
9989         (typy_iterator_iternext): Update.
9990
9991 2019-01-03  Tom Tromey  <tom@tromey.com>
9992
9993         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9994
9995 2019-01-03  Tom Tromey  <tom@tromey.com>
9996
9997         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9998         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9999         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10000         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10001         (pspy_set_type_printers): Likewise.
10002         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10003         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10004         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10005         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10006         (objfpy_set_type_printers): Likewise.
10007
10008 2019-01-03  Tom Tromey  <tom@tromey.com>
10009
10010         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10011         (gdbpy_print_stack): Use gdbpy_err_fetch.
10012         * python/python-internal.h (class gdbpy_err_fetch): New class.
10013         (class gdbpy_enter) <m_error_type, m_error_value,
10014         m_error_traceback>: Remove.
10015         <m_error>: New member.
10016         (gdbpy_exception_to_string): Don't declare.
10017         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10018         * python/py-value.c (convert_value_from_python): Use
10019         gdbpy_err_fetch.
10020         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10021         gdbpy_exception_to_string.
10022         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10023         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10024         gdbpy_err_fetch.
10025
10026 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10027
10028         * linux-nat.c (delete_lwp_cleanup): Delete.
10029         (struct lwp_deleter): New struct.
10030         (lwp_info_up): New typedef.
10031         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10032         lwp_info_up.
10033
10034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10035
10036         * linux-fork.c (class scoped_switch_fork_info): New class.
10037         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10038
10039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10040
10041         * valops.c (find_overload_match): Remove use of null_cleanup, and
10042         calls to do_cleanups.
10043
10044 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10045
10046         * compile/compile-cplus-types.c
10047         (compile_cplus_instance::decl_name): Handle changes to
10048         cp_func_name.
10049         * cp-support.c (cp_func_name): Update header comment, update
10050         return type.
10051         * cp-support.h (cp_func_name): Update return type in declaration.
10052         * valops.c (find_overload_match): Move temp_func local to top
10053         level of function and change its type.  Use temp_func to hold and
10054         delete temporary string obtained from cp_func_name.
10055
10056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10057
10058         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10059         gdb::char_vector, remove cleanup, and update uses of `msg`.
10060
10061 2019-01-03  Jim Wilson  <jimw@sifive.com>
10062
10063         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10064
10065 2019-01-02  Tom Tromey  <tom@tromey.com>
10066
10067         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10068         (tdesc_parse_xml): Remove cleanups.
10069         * target-descriptions.h (make_cleanup_free_target_description):
10070         Don't declare.
10071         (target_desc_deleter): New struct.
10072         (target_desc_up): New typedef.
10073         * target-descriptions.c (target_desc_deleter::operator()): Rename
10074         from free_target_description.
10075         (make_cleanup_free_target_description): Remove.
10076
10077 2019-01-02  Tom Tromey  <tom@tromey.com>
10078
10079         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10080         constructor, destructor.
10081         (linespec_parser): Remove typedef.
10082         (~linespec_parser): Rename from linespec_parser_delete.
10083         (linespec_lex_to_end, linespec_complete_label)
10084         (linespec_complete): Update.
10085         (decode_line_full): Remove cleanups.
10086         (decode_line_1): Update.
10087
10088 2019-01-02  Tom Tromey  <tom@tromey.com>
10089
10090         * python/python-internal.h (inferior_to_inferior_object): Change
10091         return type.
10092         * python/py-exitedevent.c (create_exited_event_object): Update.
10093         * python/py-inferior.c (inferior_to_inferior_object): Return
10094         gdbpy_ref.
10095         (python_new_inferior, python_inferior_deleted)
10096         (thread_to_thread_object, delete_thread_object)
10097         (build_inferior_list, gdbpy_selected_inferior): Update.
10098         * python/py-infthread.c (create_thread_object): Update.  Also fail
10099         if inferior_to_inferior_object fails.
10100
10101 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10102
10103         * inferior.h (class inferior) <displaced_step_state>: New field.
10104         * infrun.h (struct displaced_step_state): Move here from
10105         infrun.c.  Initialize fields, add constructor.
10106         <inf>: Remove field.
10107         <reset>: New method.
10108         * infrun.c (struct displaced_step_inferior_state): Move to
10109         infrun.h.
10110         (displaced_step_inferior_states): Remove.
10111         (get_displaced_stepping_state): Adust.
10112         (displaced_step_in_progress_any_inferior): Adjust.
10113         (displaced_step_in_progress_thread): Adjust.
10114         (displaced_step_in_progress): Adjust.
10115         (add_displaced_stepping_state): Remove.
10116         (get_displaced_step_closure_by_addr): Adjust.
10117         (remove_displaced_stepping_state): Remove.
10118         (infrun_inferior_exit): Call displaced_step_state.reset.
10119         (use_displaced_stepping): Don't check for NULL.
10120         (displaced_step_prepare_throw): Call
10121         get_displaced_stepping_state.
10122         (displaced_step_fixup): Don't check for NULL.
10123         (prepare_for_detach): Don't check for NULL.
10124
10125 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10126
10127         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10128          in case of call that did not complete.
10129
10130 2019-01-02  Andrey Utkin  <autkin@undo.io>
10131
10132         * symfile.c (find_separate_debug_file): Fix search of debug files for
10133         remote debuggee.
10134
10135 2019-01-02  Tom Tromey  <tom@tromey.com>
10136
10137         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10138         indentation.
10139         * python/py-frame.c (frapy_older): Remove cast.
10140         (frapy_newer): Likewise.
10141         * python/py-breakpoint.c (local_setattro): Remove cast.
10142         * python/py-arch.c (archpy_name): Remove local variable.
10143         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10144
10145 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10146
10147         * unittests/basic_string_view/element_access/char/empty.cc:
10148         Fix year range in copyright header.
10149
10150 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10153         Delete.
10154         <operator==>: Update with for removed field.
10155         <hash>: Likewise.
10156         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10157         <isa_features>: ...this.
10158         <abi_features>: New field.
10159         (riscv_isa_flen): Update comment.
10160         (riscv_abi_xlen): New declaration.
10161         (riscv_abi_flen): New declaration.
10162         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10163         isa_features.
10164         (riscv_abi_xlen): New function.
10165         (riscv_isa_flen): Update to get answer from isa_features.
10166         (riscv_abi_flen): New function.
10167         (riscv_has_fp_abi): Update to get answer from abi_features.
10168         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10169         xlen and flen.
10170         (riscv_call_info) <xlen, flen>: Update comment.
10171         (riscv_call_arg_struct): Remove invalid assertions
10172         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10173         is removed.
10174         (riscv_gdbarch_init): Gather isa features and abi features
10175         separately, ensure both match on the gdbarch when reusing an old
10176         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10177         a target with 64-bit float hardware.
10178
10179 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10180
10181         * source.c (search_command_helper): Stop reverse search
10182         when line 1 has been searched.
10183
10184 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10185
10186         * record-full.c (record_full_base_target::close): Rewrite
10187         record_full_core_buf_list free logic.
10188
10189 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10190
10191         * break-catch-syscall.c (print_one_catch_syscall): xfree
10192         the last text.
10193
10194 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10195
10196         * top.c (print_gdb_version): Update Copyright year in version
10197         message.
10198
10199 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10200
10201         Update copyright year range in all GDB files.
10202
10203 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10204
10205         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10206
10207 For older changes see ChangeLog-2018.
10208 \f
10209 Local Variables:
10210 mode: change-log
10211 left-margin: 8
10212 fill-column: 74
10213 version-control: never
10214 coding: utf-8
10215 End:
10216