gdb/ChangeLog

   1 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
   2
   3         PR symtab/24423:
   4         * source.c (print_source_lines_base): Advance "iter" when a
   5         control character is seen.
   6
   7 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   8
   9         * inferior.h (struct infcall_suspend_state_deleter):
  10         Catch exception in destructor to avoid crash.
  11
  12 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
  13
  14         * utils.c (prompt_for_continue): Don't restore the styling at the
  15         end, as applied_style has the wrong value.  This fixes styling in
  16         long lists of file names that are interrupted by the "Continue?"
  17         prompt.
  18
  19 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  20
  21         * version.in: Set GDB version number to 8.2.91.DATE-git.
  22
  23 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  24
  25         GDB 8.2.91 released.
  26
  27 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  28
  29         * version.in: Set GDB version number to 8.2.91.
  30
  31 2019-03-20  Tom Tromey  <tromey@adacore.com>
  32
  33         PR gdb/24391
  34         * infrun.c (handle_inferior_event): Rename from
  35         handle_inferior_event_1.  Create a scoped_value_mark.
  36         (handle_inferior_event): Remove.
  37
  38 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  39
  40         * source-cache.c (source_cache::get_source_lines): Re-read
  41         fullname after calling open_source_file.
  42
  43 2019-03-18  Pedro Alves  <palves@redhat.com>
  44             Eli Zaretskii <eliz@gnu.org>
  45
  46         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
  47         m_line and m_start_of_line.
  48
  49 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
  50
  51         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  52         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  53         it returns a newline.  This fixes a regression in TU mode, whereby
  54         the next line is output on the same screen line as the user input.
  55
  56 2019-03-18  Pedro Alves  <palves@redhat.com>
  57
  58         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  59         New globals.
  60         (apply_style): New, factored out from ...
  61         (apply_ansi_escape): ... this.  Handle reverse video mode.
  62         (tui_set_reverse_mode): New function.
  63         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  64         * tui/tui-winsource.c (tui_show_source_line): Use
  65         tui_set_reverse_mode instead of setting A_STANDOUT.
  66         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  67         New setter methods.
  68
  69 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  70
  71         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  72         Handle tabs.
  73
  74 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  75
  76         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  77         tui_refill_source_window instead of tui_refresh_win, to update the
  78         current execution line.  This fixes redisplay of the current line
  79         when stepping through the code with "next" or "step".
  80
  81 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  82
  83         * source-cache.c (source_cache::get_source_lines): Call
  84         find_source_lines to initialize s->nlines.  This fixes vertical
  85         scrolling of TUI source window when the DOWN arrow is pressed.
  86
  87 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  88
  89         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  90         wclrtoeol in tui_show_source_line".  This reverts changes made in
  91         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  92
  93 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  94
  95         * NEWS: Combine separate "New targets" sections for 8.3.
  96
  97 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  98
  99         The MS-Windows port of ncurses fails to switch to a color pair if
 100         one or both of the colors are the implicit default colors.  This
 101         change records the default colors when TUI is initialized, and
 102         then specifies them explicitly when a color pair uses the default
 103         colors.  This allows color styling in TUI mode on MS-Windows.
 104
 105         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 106         ncurses_norm_attr.
 107         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 108         colors in ncurses_norm_attr.
 109         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 110         "none", replace it with the default color recorded in
 111         ncurses_norm_attr.
 112
 113 2019-03-14  Tom Tromey  <tromey@adacore.com>
 114
 115         * source-cache.h (class source_cache) <get_source_lines>: Return
 116         std::string.
 117         * source-cache.c (source_cache::extract_lines): Handle case where
 118         first_pos==npos.  Return std::string.
 119         (source_cache::get_source_lines): Update.
 120
 121 2019-03-14  Tom Tromey  <tromey@adacore.com>
 122
 123         * NEWS: Add item for "style sources" commands.
 124         * source-cache.c (source_cache::get_source_lines): Check
 125         source_styling.
 126         * cli/cli-style.c (source_styling): New global.
 127         (_initialize_cli_style): Add "style sources" commands.
 128         (show_style_sources): New function.
 129         * cli/cli-style.h (source_styling): Declare.
 130
 131 2019-03-14  Pedro Alves  <palves@redhat.com>
 132             Tom Tromey  <tromey@adacore.com>
 133
 134         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 135         * tui/tui-winsource.c (tui_refill_source_window): New function,
 136         from...
 137         (tui_horizontal_source_scroll): ... here.  Move some logic.
 138         * cli/cli-style.c (set_style_enabled): Notify new observable.
 139         * tui/tui-hooks.c (tui_redisplay_source): New function.
 140         (tui_attach_detach_observers): Attach or detach
 141         tui_redisplay_source.
 142         * observable.h (source_styling_changed): New observable.
 143         * observable.c: Define source_styling_changed observable.
 144
 145 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 146
 147         PR/24325
 148         * source-cache.c: #undef open and close, to avoid unresolved
 149         externals during linking.
 150
 151 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 152
 153         Support styling on native MS-Windows console
 154
 155         PR/24315
 156         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 157         on MS-Windows if $TERM is not defined.
 158
 159         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 160
 161         * posix-hdep.c (gdb_console_fputs):
 162         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 163         functions.
 164         * ui-file.h (gdb_console_fputs): Add prototype.
 165
 166         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 167         back to fputs only if the former returns zero.
 168
 169 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 170             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 171
 172         PR gdb/8527
 173         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 174         set_sigint_trap, clear_sigint_trap.
 175
 176 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 177
 178         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 179         for-loop range, to avoid compiler warnings.
 180
 181         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 182         avoid compiler warnings about unused variables.
 183
 184 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 185
 186         * NEWS: Mention end of support for native debugging on MS-Windows
 187         before XP.
 188
 189 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 190
 191         PR gdb/24292
 192         * common/netstuff.c:
 193         * gdbserver/gdbreplay.c
 194         * gdbserver/remote-utils.c:
 195         * ser-tcp.c:
 196         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 197         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 198         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 199         'getaddrinfo' and 'freeaddrinfo' were not available before
 200         Windows XP, and mingw.org's MinGW headers by default define
 201         _WIN32_WINNT to 0x500.
 202
 203 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 204
 205         * NEWS: Note minimum Python version.
 206
 207 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 208
 209         * version.in: Set GDB version number to 8.2.90.DATE-git.
 210
 211 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 212
 213         GDB 8.2.90 released.
 214
 215 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 216
 217         * version.in: Set GDB version number to 8.2.90.
 218
 219 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 220
 221         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 222
 223 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 224
 225         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 226         * version.in: Bump version to 8.2.90.DATE-git.
 227
 228 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 229
 230         * aix-thread.c (ptid_cmp): Remove unused variable.
 231         (get_signaled_thread): Likewise.
 232         (store_regs_user_thread): Likewise.
 233         (store_regs_kernel_thread): Likewise.
 234         (fetch_regs_kernel_thread): Remove shadowed variable.
 235
 236 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * features/riscv/32bit-cpu.xml: Add register numbers.
 239         * features/riscv/32bit-fpu.c: Regenerate.
 240         * features/riscv/32bit-fpu.xml: Add register numbers.
 241         * features/riscv/64bit-cpu.xml: Add register numbers.
 242         * features/riscv/64bit-fpu.c: Regenerate.
 243         * features/riscv/64bit-fpu.xml: Add register numbers.
 244
 245 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 246
 247         * NEWS: Mention two argument form of gdb.Value constructor.
 248         * python/py-value.c (convert_buffer_and_type_to_value): New
 249         function.
 250         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 251         Add support for handling an optional second argument.  Call
 252         convert_buffer_and_type_to_value as appropriate.
 253         * python/python-internal.h (Py_buffer_deleter): New struct.
 254         (Py_buffer_up): New typedef.
 255
 256 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 257
 258         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 259         instead of releasing ownership.
 260
 261 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 262
 263         * dwarf2read.c (open_and_init_dwp_file): Call
 264         elf_numsections instead of bfd_count_sections to initialize
 265         dwp_file->num_sections.
 266
 267 2019-02-25  Tom Tromey  <tromey@adacore.com>
 268
 269         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 270
 271 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 272
 273         * gcore.in: Add '--readnever' option when invoking GDB.
 274
 275 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 276
 277         * MAINTAINERS: Update my email address.
 278
 279 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 280
 281         * build-id.c (build_id_to_debug_bfd_1): New function.
 282         (build_id_to_debug_bfd): Look for separate debug file in
 283         sysroot.
 284
 285 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * gdbarch.sh: Update the copyright year range that is placed into
 288         generated files.
 289
 290 2019-02-22  Keith Seitz  <keiths@redhat.com>
 291
 292         PR symtab/23853
 293         * linespec.c (create_sals_line_offset): Search for the default
 294         symtab's filename instead of its fullname.
 295
 296 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 297
 298         * NEWS: Update style defaults.
 299
 300 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 301
 302         * main.c (captured_main_1): Disable styling in batch mode.
 303
 304 2019-02-20  Tom Tromey  <tom@tromey.com>
 305
 306         * symtab.c (symtab_symbol_info): Fix typos.
 307
 308 2019-02-20  Tom Tromey  <tromey@adacore.com>
 309
 310         * findcmd.c (_initialize_mem_search): Use upper case for
 311         metasyntactic variables.
 312
 313 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 314
 315         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 316         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 317
 318 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 319
 320         * top.h (source_file_name): Change to std::string.
 321         * top.c (source_file_name): Likewise.
 322         (command_line_input): Adjust.
 323         * cli/cli-script.c (script_from_file): Adjust.
 324
 325 2019-02-19  Tom Tromey  <tromey@adacore.com>
 326
 327         * ravenscar-thread.c
 328         (ravenscar_thread_target::update_thread_list): Don't call
 329         ada_build_task_list.
 330         * ada-lang.h (ada_build_task_list): Don't declare.
 331         * ada-tasks.c (struct ada_tasks_inferior_data)
 332         <task_list_valid_p>: Now bool.
 333         (read_known_tasks, ada_task_list_changed)
 334         (ada_tasks_invalidate_inferior_data): Update.
 335         (read_known_tasks_array): Return bool.
 336         (read_known_tasks_list): Likewise.
 337         (read_known_tasks): Return void.
 338         (ada_build_task_list): Now static.
 339
 340 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 341
 342         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 343         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 344
 345 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 346
 347         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 348         variant for ada_tasks_pspace_data_handle and
 349         ada_tasks_inferior_data_handle.
 350         (ada_tasks_pspace_data_cleanup): New function.
 351         (ada_tasks_inferior_data_cleanup): New function.
 352
 353 2019-02-17  Tom Tromey  <tom@tromey.com>
 354
 355         * macrotab.h (macro_source_fullname): Return a std::string.
 356         * macrotab.c (macro_include, check_for_redefinition)
 357         (macro_undef, macro_lookup_definition, foreach_macro)
 358         (foreach_macro_in_scope): Update.
 359         (macro_source_fullname): Return a std::string.
 360         * macrocmd.c (show_pp_source_pos): Update.
 361
 362 2019-02-17  Tom Tromey  <tom@tromey.com>
 363
 364         * macrocmd.c (show_pp_source_pos): Style the file names.
 365
 366 2019-02-17  Tom Tromey  <tom@tromey.com>
 367
 368         PR tui/24197:
 369         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 370
 371 2019-02-17  Tom Tromey  <tom@tromey.com>
 372
 373         * ada-lang.c (user_select_syms): Use filtered printing.
 374         * utils.c (wrap_style): New global.
 375         (desired_style): Remove.
 376         (emit_style_escape): Add stream parameter.
 377         (set_output_style, reset_terminal_style, prompt_for_continue):
 378         Update.
 379         (flush_wrap_buffer): Only flush gdb_stdout.
 380         (wrap_here): Set wrap_style.
 381         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 382         treat escape sequences as a character.  Change when wrap buffer is
 383         flushed.
 384         (fputs_styled): Do not set the output style when the default is
 385         requested.
 386         * ui-style.h (struct ui_file_style) <is_default>: New method.
 387         * source.c (print_source_lines_base): Emit escape sequences in one
 388         piece.
 389
 390 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 391
 392         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 393         integers and enumeration types.
 394
 395 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 396
 397         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 398         instead of lookup_symbol_in_language
 399         (do_exact_match): New function.
 400         (ada_get_symbol_name_matcher): Return do_exact_match when
 401         doing a verbatim match.
 402
 403 2019-02-15  Tom Tromey  <tromey@adacore.com>
 404
 405         * ravenscar-thread.c (ravenscar_thread_target::resume)
 406         (ravenscar_thread_target::wait): Special case wildcard requests.
 407
 408 2019-02-15  Tom Tromey  <tromey@adacore.com>
 409
 410         * ravenscar-thread.c (base_ptid): Remove.
 411         (struct ravenscar_thread_target) <close>: New method.
 412         <m_base_ptid>: New member.
 413         <update_inferior_ptid, active_task, task_is_currently_active,
 414         runtime_initialized>: Declare methods.
 415         <ravenscar_thread_target>: Add constructor.
 416         (ravenscar_thread_target::task_is_currently_active)
 417         (ravenscar_thread_target::update_inferior_ptid)
 418         (ravenscar_runtime_initialized): Rename.  Now methods.
 419         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 420         (ravenscar_thread_target::update_thread_list): Update.
 421         (ravenscar_thread_target::active_task): Now method.
 422         (ravenscar_thread_target::store_registers)
 423         (ravenscar_thread_target::prepare_to_store)
 424         (ravenscar_thread_target::prepare_to_store)
 425         (ravenscar_thread_target::mourn_inferior): Update.
 426         (ravenscar_inferior_created): Use "new" to create target.
 427         (ravenscar_thread_target::get_ada_task_ptid): Update.
 428         (_initialize_ravenscar): Don't initialize base_ptid.
 429         (ravenscar_ops): Remove global.
 430
 431 2019-02-15  Tom Tromey  <tromey@adacore.com>
 432
 433         * target.h (push_target): Declare new overload.
 434         * target.c (push_target): New overload, taking an rvalue reference.
 435         * remote.c (remote_target::open_1): Use push_target overload.
 436         * corelow.c (core_target_open): Use push_target overload.
 437
 438 2019-02-15  Tom Tromey  <tromey@adacore.com>
 439
 440         * ravenscar-thread.c (is_ravenscar_task)
 441         (ravenscar_task_is_currently_active): Return bool.
 442         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 443         (_initialize_ravenscar): Remove "(void)".
 444         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 445         Return bool.
 446
 447 2019-02-15  Tom Tromey  <tromey@adacore.com>
 448
 449         * ravenscar-thread.c (ravenscar_runtime_initializer)
 450         (has_ravenscar_runtime, get_running_thread_id)
 451         (ravenscar_thread_target::resume): Fix indentation.
 452
 453 2019-02-15  Tom Tromey  <tromey@adacore.com>
 454
 455         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 456         from ravenscar_arch_ops.
 457         (sparc_ravenscar_ops::fetch_registers)
 458         (sparc_ravenscar_ops::store_registers): Now methods.
 459         (sparc_ravenscar_prepare_to_store): Remove.
 460         (sparc_ravenscar_ops): Redefine.
 461         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 462         methods and destructor.  Remove members.
 463         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 464         (ravenscar_thread_target::store_registers)
 465         (ravenscar_thread_target::prepare_to_store): Update.
 466         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 467         Remove.
 468         (struct ppc_ravenscar_powerpc_ops): Derive from
 469         ravenscar_arch_ops.
 470         (ppc_ravenscar_powerpc_ops::fetch_registers)
 471         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 472         (ppc_ravenscar_powerpc_ops): Redefine.
 473         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 474         (ppc_ravenscar_e500_ops::fetch_registers)
 475         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 476         (ppc_ravenscar_e500_ops): Redefine.
 477         * aarch64-ravenscar-thread.c
 478         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 479         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 480         (aarch64_ravenscar_fetch_registers)
 481         (aarch64_ravenscar_store_registers): Now methods.
 482         (aarch64_ravenscar_ops): Redefine.
 483
 484 2019-02-15  Tom Tromey  <tromey@adacore.com>
 485
 486         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 487         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 488         (ravenscar_thread_target::stopped_by_watchpoint)
 489         (ravenscar_thread_target::stopped_data_address)
 490         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 491
 492 2019-02-15  Tom Tromey  <tromey@adacore.com>
 493
 494         * ravenscar-thread.c: Fix some typos.
 495
 496 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 497             Tom Tromey  <tromey@adacore.com>
 498
 499         * ada-lang.c (ada_exception_sal): Change addr_string to a
 500         std::string.
 501         (create_ada_exception_catchpoint): Update.
 502
 503 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 504             Tom Tromey  <tromey@adacore.com>
 505
 506         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 507         (bp_location_ops): Remove.
 508         (base_breakpoint_allocate_location): Update.
 509         (free_bp_location): Update.
 510         * ada-lang.c (class ada_catchpoint_location)
 511         <ada_catchpoint_location>: Remove ops parameter.
 512         (ada_catchpoint_location_dtor): Remove.
 513         (ada_catchpoint_location_ops): Remove.
 514         (allocate_location_exception): Update.
 515         * breakpoint.h (struct bp_location_ops): Remove.
 516         (class bp_location) <bp_location>: Remove bp_location_ops
 517         parameter.
 518         <~bp_location>: Add destructor.
 519         <ops>: Remove.
 520
 521 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 522             Pedro Alves  <palves@redhat.com>
 523
 524         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 525         'PATH_MAX'.
 526
 527 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 528             Samuel Thibault  <samuel.thibault@gnu.org>
 529             Thomas Schwinge  <thomas@codesourcery.com>
 530
 531         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 532         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 533
 534 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 535
 536         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 537         (check_empty): Use "const char *".
 538
 539         * gnu-nat.c (gnu_nat_target::detach): Instead of
 540         'detach_inferior (pid)' call
 541         'detach_inferior (find_inferior_pid (pid))'.
 542
 543         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 544         'nat/fork-inferior.o'.
 545         * gnu-nat.c: #include "nat/fork-inferior.h".
 546
 547         * gnu-nat.c (gnu_nat_target::detach): Instead of
 548         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 549         * gnu-nat.h: #include "inf-child.h".
 550         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 551         'i386_gnu_nat_target::fetch_registers'.
 552         (gnu_store_registers): Rename/move to
 553         'i386_gnu_nat_target::store_registers'.
 554
 555         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 556         * gnu-nat.h (mach_thread_info): New function.
 557         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 558
 559         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 560
 561 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 562
 563         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 564
 565 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 566
 567         * windows-nat.c (windows_add_thread): Add new parameter
 568         "main_thread_p" with default value set to false.  Update
 569         function documentation as well as all callers.
 570         (windows_delete_thread): Likewise.
 571         (fake_create_process): Update call to windows_add_thread.
 572         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 573         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 574         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 575         call to windows_delete_thread.
 576
 577 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 578
 579         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 580
 581 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 582
 583         * symfile.c (find_separate_debug_file): Use canonical path of
 584         sysroot with child_path instead of gdb_sysroot if it is valid.
 585
 586 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 587
 588         * symfile.c (find_separate_debug_file): Use child_path to
 589         determine if an object file is under a sysroot.
 590
 591 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 592
 593         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 594         unittests/child-path-selftests.c.
 595         * common/pathstuff.c (child_path): New function.
 596         * common/pathstuff.h (child_path): New prototype.
 597         * unittests/child-path-selftests.c: New file.
 598
 599 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 600
 601         * symfile.c (find_separate_debug_file): Look for separate debug
 602         files in debug directories under the sysroot.
 603
 604 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 605
 606         * symtab.h (struct minimal_symbol data_p): New const method.
 607         (struct minimal_symbol text_p): Likewise.
 608         * symtab.c (output_source_filename): Use file name style
 609         to print file name.
 610         (print_symbol_info): Likewise.
 611         (print_msymbol_info): Use address style to print addresses.
 612         Use function name style to print executable text symbols.
 613         (expand_symtab_containing_pc): Use data_p.
 614         (find_pc_sect_compunit_symtab): Likewise.
 615
 616 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 617
 618         * breakpoint.c (describe_other_breakpoints): Use address style
 619         to print addresses.
 620         (say_where): Likewise.
 621
 622 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 623
 624         * ada-typeprint.c (print_func_type): Print function name
 625         style to print function name.
 626         * c-typeprint.c (c_print_type_1): Likewise.
 627
 628 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 629
 630         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 631         for execve.
 632
 633 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 634
 635         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 636         type_stack.
 637
 638 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 639
 640         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 641         TYPE_CODE_REF types.
 642
 643 2019-02-08  Jim Wilson  <jimw@sifive.com>
 644
 645         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 646         (riscv_linux_fregset): New.
 647         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 648
 649 2019-02-07  Tom Tromey  <tom@tromey.com>
 650
 651         * thread.c (thread_cancel_execution_command): Update.
 652         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 653         methods.
 654         (struct thread_fsm_ops): Remove.
 655         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 656         (thread_fsm_should_stop, thread_fsm_return_value)
 657         (thread_fsm_set_finished, thread_fsm_finished_p)
 658         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 659         Don't declare.
 660         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 661         * infrun.c (clear_proceed_status_thread)
 662         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 663         (print_stop_event): Update.
 664         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 665         Add constructor.
 666         (step_command_fsm_ops): Remove.
 667         (new_step_command_fsm): Remove.
 668         (step_1): Update.
 669         (step_command_fsm::should_stop): Rename from
 670         step_command_fsm_should_stop.
 671         (step_command_fsm::clean_up): Rename from
 672         step_command_fsm_clean_up.
 673         (step_command_fsm::do_async_reply_reason): Rename from
 674         step_command_fsm_async_reply_reason.
 675         (struct until_next_fsm): Inherit from thread_fsm.  Add
 676         constructor.
 677         (until_next_fsm_ops): Remove.
 678         (new_until_next_fsm): Remove.
 679         (until_next_fsm::should_stop): Rename from
 680         until_next_fsm_should_stop.
 681         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 682         (until_next_fsm::do_async_reply_reason): Rename from
 683         until_next_fsm_async_reply_reason.
 684         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 685         constructor.  Change type of breakpoint.
 686         (finish_command_fsm_ops): Remove.
 687         (new_finish_command_fsm): Remove.
 688         (finish_command_fsm::should_stop): Rename from
 689         finish_command_fsm_should_stop.
 690         (finish_command_fsm::clean_up): Rename from
 691         finish_command_fsm_clean_up.
 692         (finish_command_fsm::return_value): Rename from
 693         finish_command_fsm_return_value.
 694         (finish_command_fsm::do_async_reply_reason): Rename from
 695         finish_command_fsm_async_reply_reason.
 696         (finish_command): Update.
 697         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 698         Add constructor.
 699         (call_thread_fsm_ops): Remove.
 700         (call_thread_fsm::call_thread_fsm): Rename from
 701         new_call_thread_fsm.
 702         (call_thread_fsm::should_stop): Rename from
 703         call_thread_fsm_should_stop.
 704         (call_thread_fsm::should_notify_stop): Rename from
 705         call_thread_fsm_should_notify_stop.
 706         (run_inferior_call, call_function_by_hand_dummy): Update.
 707         * cli/cli-interp.c (should_print_stop_to_console): Update.
 708         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 709         Add constructor.  Change type of location_breakpoint,
 710         caller_breakpoint.
 711         (until_break_fsm_ops): Remove.
 712         (new_until_break_fsm): Remove.
 713         (until_break_fsm::should_stop): Rename from
 714         until_break_fsm_should_stop.
 715         (until_break_fsm::clean_up): Rename from
 716         until_break_fsm_clean_up.
 717         (until_break_fsm::do_async_reply_reason): Rename from
 718         until_break_fsm_async_reply_reason.
 719         (until_break_command): Update.
 720         * thread-fsm.c: Remove.
 721         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 722
 723 2019-02-07  Tom Tromey  <tom@tromey.com>
 724
 725         * yy-remap.h: Add include guard.
 726         * xtensa-tdep.h: Add include guard.
 727         * xcoffread.h: Rename include guard.
 728         * varobj-iter.h: Add include guard.
 729         * tui/tui.h: Rename include guard.
 730         * tui/tui-winsource.h: Rename include guard.
 731         * tui/tui-wingeneral.h: Rename include guard.
 732         * tui/tui-windata.h: Rename include guard.
 733         * tui/tui-win.h: Rename include guard.
 734         * tui/tui-stack.h: Rename include guard.
 735         * tui/tui-source.h: Rename include guard.
 736         * tui/tui-regs.h: Rename include guard.
 737         * tui/tui-out.h: Rename include guard.
 738         * tui/tui-layout.h: Rename include guard.
 739         * tui/tui-io.h: Rename include guard.
 740         * tui/tui-hooks.h: Rename include guard.
 741         * tui/tui-file.h: Rename include guard.
 742         * tui/tui-disasm.h: Rename include guard.
 743         * tui/tui-data.h: Rename include guard.
 744         * tui/tui-command.h: Rename include guard.
 745         * tic6x-tdep.h: Add include guard.
 746         * target/waitstatus.h: Rename include guard.
 747         * target/wait.h: Rename include guard.
 748         * target/target.h: Rename include guard.
 749         * target/resume.h: Rename include guard.
 750         * target-float.h: Rename include guard.
 751         * stabsread.h: Add include guard.
 752         * rs6000-tdep.h: Add include guard.
 753         * riscv-fbsd-tdep.h: Add include guard.
 754         * regformats/regdef.h: Rename include guard.
 755         * record.h: Rename include guard.
 756         * python/python.h: Rename include guard.
 757         * python/python-internal.h: Rename include guard.
 758         * python/py-stopevent.h: Rename include guard.
 759         * python/py-ref.h: Rename include guard.
 760         * python/py-record.h: Rename include guard.
 761         * python/py-record-full.h: Rename include guard.
 762         * python/py-record-btrace.h: Rename include guard.
 763         * python/py-instruction.h: Rename include guard.
 764         * python/py-events.h: Rename include guard.
 765         * python/py-event.h: Rename include guard.
 766         * procfs.h: Add include guard.
 767         * proc-utils.h: Add include guard.
 768         * p-lang.h: Add include guard.
 769         * or1k-tdep.h: Rename include guard.
 770         * observable.h: Rename include guard.
 771         * nto-tdep.h: Rename include guard.
 772         * nat/x86-linux.h: Rename include guard.
 773         * nat/x86-linux-dregs.h: Rename include guard.
 774         * nat/x86-gcc-cpuid.h: Add include guard.
 775         * nat/x86-dregs.h: Rename include guard.
 776         * nat/x86-cpuid.h: Rename include guard.
 777         * nat/ppc-linux.h: Rename include guard.
 778         * nat/mips-linux-watch.h: Rename include guard.
 779         * nat/linux-waitpid.h: Rename include guard.
 780         * nat/linux-ptrace.h: Rename include guard.
 781         * nat/linux-procfs.h: Rename include guard.
 782         * nat/linux-osdata.h: Rename include guard.
 783         * nat/linux-nat.h: Rename include guard.
 784         * nat/linux-namespaces.h: Rename include guard.
 785         * nat/linux-btrace.h: Rename include guard.
 786         * nat/glibc_thread_db.h: Rename include guard.
 787         * nat/gdb_thread_db.h: Rename include guard.
 788         * nat/gdb_ptrace.h: Rename include guard.
 789         * nat/fork-inferior.h: Rename include guard.
 790         * nat/amd64-linux-siginfo.h: Rename include guard.
 791         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 792         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 793         * nat/aarch64-linux.h: Rename include guard.
 794         * nat/aarch64-linux-hw-point.h: Rename include guard.
 795         * mn10300-tdep.h: Add include guard.
 796         * mips-linux-tdep.h: Add include guard.
 797         * mi/mi-parse.h: Rename include guard.
 798         * mi/mi-out.h: Rename include guard.
 799         * mi/mi-main.h: Rename include guard.
 800         * mi/mi-interp.h: Rename include guard.
 801         * mi/mi-getopt.h: Rename include guard.
 802         * mi/mi-console.h: Rename include guard.
 803         * mi/mi-common.h: Rename include guard.
 804         * mi/mi-cmds.h: Rename include guard.
 805         * mi/mi-cmd-break.h: Rename include guard.
 806         * m2-lang.h: Add include guard.
 807         * location.h: Rename include guard.
 808         * linux-record.h: Rename include guard.
 809         * linux-nat.h: Add include guard.
 810         * linux-fork.h: Add include guard.
 811         * i386-darwin-tdep.h: Rename include guard.
 812         * hppa-linux-offsets.h: Add include guard.
 813         * guile/guile.h: Rename include guard.
 814         * guile/guile-internal.h: Rename include guard.
 815         * gnu-nat.h: Rename include guard.
 816         * gdb-stabs.h: Rename include guard.
 817         * frv-tdep.h: Add include guard.
 818         * f-lang.h: Add include guard.
 819         * event-loop.h: Add include guard.
 820         * darwin-nat.h: Rename include guard.
 821         * cp-abi.h: Rename include guard.
 822         * config/sparc/nm-sol2.h: Rename include guard.
 823         * config/nm-nto.h: Rename include guard.
 824         * config/nm-linux.h: Add include guard.
 825         * config/i386/nm-i386gnu.h: Rename include guard.
 826         * config/djgpp/nl_types.h: Rename include guard.
 827         * config/djgpp/langinfo.h: Rename include guard.
 828         * compile/gcc-cp-plugin.h: Add include guard.
 829         * compile/gcc-c-plugin.h: Add include guard.
 830         * compile/compile.h: Rename include guard.
 831         * compile/compile-object-run.h: Rename include guard.
 832         * compile/compile-object-load.h: Rename include guard.
 833         * compile/compile-internal.h: Rename include guard.
 834         * compile/compile-cplus.h: Rename include guard.
 835         * compile/compile-c.h: Rename include guard.
 836         * common/xml-utils.h: Rename include guard.
 837         * common/x86-xstate.h: Rename include guard.
 838         * common/version.h: Rename include guard.
 839         * common/vec.h: Rename include guard.
 840         * common/tdesc.h: Rename include guard.
 841         * common/selftest.h: Rename include guard.
 842         * common/scoped_restore.h: Rename include guard.
 843         * common/scoped_mmap.h: Rename include guard.
 844         * common/scoped_fd.h: Rename include guard.
 845         * common/safe-iterator.h: Rename include guard.
 846         * common/run-time-clock.h: Rename include guard.
 847         * common/refcounted-object.h: Rename include guard.
 848         * common/queue.h: Rename include guard.
 849         * common/ptid.h: Rename include guard.
 850         * common/print-utils.h: Rename include guard.
 851         * common/preprocessor.h: Rename include guard.
 852         * common/pathstuff.h: Rename include guard.
 853         * common/observable.h: Rename include guard.
 854         * common/netstuff.h: Rename include guard.
 855         * common/job-control.h: Rename include guard.
 856         * common/host-defs.h: Rename include guard.
 857         * common/gdb_wait.h: Rename include guard.
 858         * common/gdb_vecs.h: Rename include guard.
 859         * common/gdb_unlinker.h: Rename include guard.
 860         * common/gdb_unique_ptr.h: Rename include guard.
 861         * common/gdb_tilde_expand.h: Rename include guard.
 862         * common/gdb_sys_time.h: Rename include guard.
 863         * common/gdb_string_view.h: Rename include guard.
 864         * common/gdb_splay_tree.h: Rename include guard.
 865         * common/gdb_setjmp.h: Rename include guard.
 866         * common/gdb_ref_ptr.h: Rename include guard.
 867         * common/gdb_optional.h: Rename include guard.
 868         * common/gdb_locale.h: Rename include guard.
 869         * common/gdb_assert.h: Rename include guard.
 870         * common/filtered-iterator.h: Rename include guard.
 871         * common/filestuff.h: Rename include guard.
 872         * common/fileio.h: Rename include guard.
 873         * common/environ.h: Rename include guard.
 874         * common/common-utils.h: Rename include guard.
 875         * common/common-types.h: Rename include guard.
 876         * common/common-regcache.h: Rename include guard.
 877         * common/common-inferior.h: Rename include guard.
 878         * common/common-gdbthread.h: Rename include guard.
 879         * common/common-exceptions.h: Rename include guard.
 880         * common/common-defs.h: Rename include guard.
 881         * common/common-debug.h: Rename include guard.
 882         * common/cleanups.h: Rename include guard.
 883         * common/buffer.h: Rename include guard.
 884         * common/btrace-common.h: Rename include guard.
 885         * common/break-common.h: Rename include guard.
 886         * cli/cli-utils.h: Rename include guard.
 887         * cli/cli-style.h: Rename include guard.
 888         * cli/cli-setshow.h: Rename include guard.
 889         * cli/cli-script.h: Rename include guard.
 890         * cli/cli-interp.h: Rename include guard.
 891         * cli/cli-decode.h: Rename include guard.
 892         * cli/cli-cmds.h: Rename include guard.
 893         * charset-list.h: Add include guard.
 894         * buildsym-legacy.h: Rename include guard.
 895         * bfin-tdep.h: Add include guard.
 896         * ax.h: Rename include guard.
 897         * arm-linux-tdep.h: Add include guard.
 898         * arm-fbsd-tdep.h: Add include guard.
 899         * arch/xtensa.h: Rename include guard.
 900         * arch/tic6x.h: Add include guard.
 901         * arch/i386.h: Add include guard.
 902         * arch/arm.h: Rename include guard.
 903         * arch/arm-linux.h: Rename include guard.
 904         * arch/arm-get-next-pcs.h: Rename include guard.
 905         * arch/amd64.h: Add include guard.
 906         * arch/aarch64-insn.h: Rename include guard.
 907         * arch-utils.h: Rename include guard.
 908         * annotate.h: Add include guard.
 909         * amd64-darwin-tdep.h: Rename include guard.
 910         * aarch64-linux-tdep.h: Add include guard.
 911         * aarch64-fbsd-tdep.h: Add include guard.
 912         * aarch32-linux-nat.h: Add include guard.
 913
 914 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 915
 916         * macrotab.c (macro_define_internal): New function that
 917         factorizes macro_define_object_internal and macro_define_function
 918         code.
 919         (macro_define_object_internal): Use macro_define_internal.
 920         (macro_define_function): Likewise.
 921
 922 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 923
 924         * macrocmd.c (extract_identifier): Return
 925         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 926         callers.
 927
 928 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 929
 930         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 931
 932 2019-02-05  Tom Tromey  <tom@tromey.com>
 933
 934         * target.c (target_stack::unpush): Move assertion earlier.
 935
 936 2019-01-30  Tom Tromey  <tom@tromey.com>
 937
 938         PR python/23615:
 939         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 940         (gdbpy_parse_and_eval): Likewise.
 941         * python/python-internal.h (gdbpy_allow_threads): New class.
 942
 943 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 944
 945         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 946         (aarch64_fbsd_fpregmap): Move earlier.
 947         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 948         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 949         instead of individual calls to trad_frame_set_reg_addr.
 950         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 951         earlier.
 952         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 953         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 954         instead of individual calls to trad_frame_set_reg_addr.
 955
 956 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 957
 958         * CONTRIBUTE: Replace contribution list with wiki link.
 959
 960 2019-01-25  Tom Tromey  <tom@tromey.com>
 961
 962         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 963
 964 2019-01-25  Tom Tromey  <tom@tromey.com>
 965
 966         * xtensa-linux-nat.c: Fix common/ includes.
 967         * xml-support.h: Fix common/ includes.
 968         * xml-support.c: Fix common/ includes.
 969         * x86-linux-nat.c: Fix common/ includes.
 970         * windows-nat.c: Fix common/ includes.
 971         * varobj.h: Fix common/ includes.
 972         * varobj.c: Fix common/ includes.
 973         * value.c: Fix common/ includes.
 974         * valops.c: Fix common/ includes.
 975         * utils.c: Fix common/ includes.
 976         * unittests/xml-utils-selftests.c: Fix common/ includes.
 977         * unittests/utils-selftests.c: Fix common/ includes.
 978         * unittests/unpack-selftests.c: Fix common/ includes.
 979         * unittests/tracepoint-selftests.c: Fix common/ includes.
 980         * unittests/style-selftests.c: Fix common/ includes.
 981         * unittests/string_view-selftests.c: Fix common/ includes.
 982         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 983         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 984         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 985         * unittests/rsp-low-selftests.c: Fix common/ includes.
 986         * unittests/parse-connection-spec-selftests.c: Fix common/
 987         includes.
 988         * unittests/optional-selftests.c: Fix common/ includes.
 989         * unittests/offset-type-selftests.c: Fix common/ includes.
 990         * unittests/observable-selftests.c: Fix common/ includes.
 991         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 992         * unittests/memrange-selftests.c: Fix common/ includes.
 993         * unittests/memory-map-selftests.c: Fix common/ includes.
 994         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 995         * unittests/function-view-selftests.c: Fix common/ includes.
 996         * unittests/environ-selftests.c: Fix common/ includes.
 997         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 998         * unittests/common-utils-selftests.c: Fix common/ includes.
 999         * unittests/cli-utils-selftests.c: Fix common/ includes.
1000         * unittests/array-view-selftests.c: Fix common/ includes.
1001         * ui-file.c: Fix common/ includes.
1002         * tui/tui-io.c: Fix common/ includes.
1003         * tracepoint.h: Fix common/ includes.
1004         * tracepoint.c: Fix common/ includes.
1005         * tracefile-tfile.c: Fix common/ includes.
1006         * top.h: Fix common/ includes.
1007         * top.c: Fix common/ includes.
1008         * thread.c: Fix common/ includes.
1009         * target/waitstatus.h: Fix common/ includes.
1010         * target/waitstatus.c: Fix common/ includes.
1011         * target.h: Fix common/ includes.
1012         * target.c: Fix common/ includes.
1013         * target-memory.c: Fix common/ includes.
1014         * target-descriptions.c: Fix common/ includes.
1015         * symtab.h: Fix common/ includes.
1016         * symfile.c: Fix common/ includes.
1017         * stap-probe.c: Fix common/ includes.
1018         * spu-linux-nat.c: Fix common/ includes.
1019         * sparc-nat.c: Fix common/ includes.
1020         * source.c: Fix common/ includes.
1021         * solib.c: Fix common/ includes.
1022         * solib-target.c: Fix common/ includes.
1023         * ser-unix.c: Fix common/ includes.
1024         * ser-tcp.c: Fix common/ includes.
1025         * ser-pipe.c: Fix common/ includes.
1026         * ser-base.c: Fix common/ includes.
1027         * selftest-arch.c: Fix common/ includes.
1028         * s12z-tdep.c: Fix common/ includes.
1029         * rust-exp.y: Fix common/ includes.
1030         * rs6000-aix-tdep.c: Fix common/ includes.
1031         * riscv-tdep.c: Fix common/ includes.
1032         * remote.c: Fix common/ includes.
1033         * remote-notif.h: Fix common/ includes.
1034         * remote-fileio.h: Fix common/ includes.
1035         * remote-fileio.c: Fix common/ includes.
1036         * regcache.h: Fix common/ includes.
1037         * regcache.c: Fix common/ includes.
1038         * record-btrace.c: Fix common/ includes.
1039         * python/python.c: Fix common/ includes.
1040         * python/py-type.c: Fix common/ includes.
1041         * python/py-inferior.c: Fix common/ includes.
1042         * progspace.h: Fix common/ includes.
1043         * producer.c: Fix common/ includes.
1044         * procfs.c: Fix common/ includes.
1045         * proc-api.c: Fix common/ includes.
1046         * printcmd.c: Fix common/ includes.
1047         * ppc-linux-nat.c: Fix common/ includes.
1048         * parser-defs.h: Fix common/ includes.
1049         * osdata.c: Fix common/ includes.
1050         * obsd-nat.c: Fix common/ includes.
1051         * nat/x86-linux.c: Fix common/ includes.
1052         * nat/x86-linux-dregs.c: Fix common/ includes.
1053         * nat/x86-dregs.h: Fix common/ includes.
1054         * nat/x86-dregs.c: Fix common/ includes.
1055         * nat/ppc-linux.c: Fix common/ includes.
1056         * nat/mips-linux-watch.h: Fix common/ includes.
1057         * nat/mips-linux-watch.c: Fix common/ includes.
1058         * nat/linux-waitpid.c: Fix common/ includes.
1059         * nat/linux-ptrace.h: Fix common/ includes.
1060         * nat/linux-ptrace.c: Fix common/ includes.
1061         * nat/linux-procfs.c: Fix common/ includes.
1062         * nat/linux-personality.c: Fix common/ includes.
1063         * nat/linux-osdata.c: Fix common/ includes.
1064         * nat/linux-namespaces.c: Fix common/ includes.
1065         * nat/linux-btrace.h: Fix common/ includes.
1066         * nat/linux-btrace.c: Fix common/ includes.
1067         * nat/fork-inferior.c: Fix common/ includes.
1068         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1069         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1070         * nat/aarch64-linux.c: Fix common/ includes.
1071         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1072         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1073         * namespace.h: Fix common/ includes.
1074         * mips-linux-tdep.c: Fix common/ includes.
1075         * minsyms.c: Fix common/ includes.
1076         * mi/mi-parse.h: Fix common/ includes.
1077         * mi/mi-main.c: Fix common/ includes.
1078         * mi/mi-cmd-env.c: Fix common/ includes.
1079         * memrange.h: Fix common/ includes.
1080         * memattr.c: Fix common/ includes.
1081         * maint.h: Fix common/ includes.
1082         * maint.c: Fix common/ includes.
1083         * main.c: Fix common/ includes.
1084         * machoread.c: Fix common/ includes.
1085         * location.c: Fix common/ includes.
1086         * linux-thread-db.c: Fix common/ includes.
1087         * linux-nat.c: Fix common/ includes.
1088         * linux-fork.c: Fix common/ includes.
1089         * inline-frame.c: Fix common/ includes.
1090         * infrun.c: Fix common/ includes.
1091         * inflow.c: Fix common/ includes.
1092         * inferior.h: Fix common/ includes.
1093         * inferior.c: Fix common/ includes.
1094         * infcmd.c: Fix common/ includes.
1095         * inf-ptrace.c: Fix common/ includes.
1096         * inf-child.c: Fix common/ includes.
1097         * ia64-linux-nat.c: Fix common/ includes.
1098         * i387-tdep.c: Fix common/ includes.
1099         * i386-tdep.c: Fix common/ includes.
1100         * i386-linux-tdep.c: Fix common/ includes.
1101         * i386-linux-nat.c: Fix common/ includes.
1102         * i386-go32-tdep.c: Fix common/ includes.
1103         * i386-fbsd-tdep.c: Fix common/ includes.
1104         * i386-fbsd-nat.c: Fix common/ includes.
1105         * guile/scm-type.c: Fix common/ includes.
1106         * guile/guile.c: Fix common/ includes.
1107         * go32-nat.c: Fix common/ includes.
1108         * gnu-nat.c: Fix common/ includes.
1109         * gdbthread.h: Fix common/ includes.
1110         * gdbarch-selftests.c: Fix common/ includes.
1111         * gdb_usleep.c: Fix common/ includes.
1112         * gdb_select.h: Fix common/ includes.
1113         * gdb_bfd.c: Fix common/ includes.
1114         * gcore.c: Fix common/ includes.
1115         * fork-child.c: Fix common/ includes.
1116         * findvar.c: Fix common/ includes.
1117         * fbsd-nat.c: Fix common/ includes.
1118         * event-top.c: Fix common/ includes.
1119         * event-loop.c: Fix common/ includes.
1120         * dwarf2read.c: Fix common/ includes.
1121         * dwarf2loc.c: Fix common/ includes.
1122         * dwarf2-frame.c: Fix common/ includes.
1123         * dwarf-index-cache.c: Fix common/ includes.
1124         * dtrace-probe.c: Fix common/ includes.
1125         * disasm-selftests.c: Fix common/ includes.
1126         * defs.h: Fix common/ includes.
1127         * csky-tdep.c: Fix common/ includes.
1128         * cp-valprint.c: Fix common/ includes.
1129         * cp-support.h: Fix common/ includes.
1130         * cp-support.c: Fix common/ includes.
1131         * corelow.c: Fix common/ includes.
1132         * completer.h: Fix common/ includes.
1133         * completer.c: Fix common/ includes.
1134         * compile/compile.c: Fix common/ includes.
1135         * compile/compile-loc2c.c: Fix common/ includes.
1136         * compile/compile-cplus-types.c: Fix common/ includes.
1137         * compile/compile-cplus-symbols.c: Fix common/ includes.
1138         * command.h: Fix common/ includes.
1139         * cli/cli-dump.c: Fix common/ includes.
1140         * cli/cli-cmds.c: Fix common/ includes.
1141         * charset.c: Fix common/ includes.
1142         * build-id.c: Fix common/ includes.
1143         * btrace.h: Fix common/ includes.
1144         * btrace.c: Fix common/ includes.
1145         * breakpoint.h: Fix common/ includes.
1146         * breakpoint.c: Fix common/ includes.
1147         * ax.h:
1148         (enum agent_op): Fix common/ includes.
1149         * ax-general.c (struct aop_map): Fix common/ includes.
1150         * ax-gdb.c: Fix common/ includes.
1151         * auxv.c: Fix common/ includes.
1152         * auto-load.c: Fix common/ includes.
1153         * arm-tdep.c: Fix common/ includes.
1154         * arch/riscv.c: Fix common/ includes.
1155         * arch/ppc-linux-common.c: Fix common/ includes.
1156         * arch/i386.c: Fix common/ includes.
1157         * arch/arm.c: Fix common/ includes.
1158         * arch/arm-linux.c: Fix common/ includes.
1159         * arch/arm-get-next-pcs.c: Fix common/ includes.
1160         * arch/amd64.c: Fix common/ includes.
1161         * arch/aarch64.c: Fix common/ includes.
1162         * arch/aarch64-insn.c: Fix common/ includes.
1163         * arch-utils.c: Fix common/ includes.
1164         * amd64-windows-tdep.c: Fix common/ includes.
1165         * amd64-tdep.c: Fix common/ includes.
1166         * amd64-sol2-tdep.c: Fix common/ includes.
1167         * amd64-obsd-tdep.c: Fix common/ includes.
1168         * amd64-nbsd-tdep.c: Fix common/ includes.
1169         * amd64-linux-tdep.c: Fix common/ includes.
1170         * amd64-linux-nat.c: Fix common/ includes.
1171         * amd64-fbsd-tdep.c: Fix common/ includes.
1172         * amd64-fbsd-nat.c: Fix common/ includes.
1173         * amd64-dicos-tdep.c: Fix common/ includes.
1174         * amd64-darwin-tdep.c: Fix common/ includes.
1175         * agent.c: Fix common/ includes.
1176         * ada-lang.h: Fix common/ includes.
1177         * ada-lang.c: Fix common/ includes.
1178         * aarch64-tdep.c: Fix common/ includes.
1179
1180 2019-01-25  Tom Tromey  <tom@tromey.com>
1181
1182         * common/create-version.sh: Use common/version.h.
1183
1184 2019-01-24  Pedro Alves  <palves@redhat.com>
1185
1186         * infrun.c (signal_stop, signal_print, signal_program)
1187         (signal_catch, signal_pass): Now arrays instead of pointers.
1188         (update_signals_program_target, do_target_resume)
1189         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1190         * linux-nat.c (linux_nat_target::pass_signals)
1191         (linux_nat_target::create_inferior, linux_nat_target::attach):
1192         Adjust.
1193         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1194         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1195         * procfs.c (procfs_target::pass_signals): Adjust.
1196         * record-full.c (record_full_target::resume): Adjust.
1197         * remote.c (remote_target::pass_signals)
1198         (remote_target::program_signals): Adjust.
1199         * target-debug.h (target_debug_print_signals): Now takes a
1200         gdb::array_view as parameter.  Adjust.
1201         * target.h (target_ops) <pass_signals, program_signals>: Replace
1202         pointer and length parameters with gdb::array_view.
1203         (target_pass_signals, target_program_signals): Likewise.
1204         * target-delegates.c: Regenerate.
1205
1206 2019-01-24  Pedro Alves  <palves@redhat.com>
1207
1208         * common/forward-scope-exit.h
1209         (forward_scope_exit::forward_scope_exit): Pass arguments to
1210         m_bind_function directly, instead of creating a std::bind and
1211         copying that.
1212
1213 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1214
1215         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1216         for static members.
1217         (pass_in_v_vfp_candidate): Likewise.
1218
1219 2019-01-23  Tom Tromey  <tom@tromey.com>
1220             Pedro Alves  <palves@redhat.com>
1221
1222         * regcache.c (class regcache_invalidator): Remove.
1223         (regcache::raw_write): Use make_scope_exit.
1224
1225 2019-01-23  Tom Tromey  <tom@tromey.com>
1226
1227         * ui-out.h (class ui_out_emit_type): Update comment.
1228
1229 2019-01-23  Tom Tromey  <tom@tromey.com>
1230
1231         * infrun.c (fetch_inferior_event): Update comment.
1232
1233 2019-01-23  Tom Tromey  <tom@tromey.com>
1234             Pedro Alves  <palves@redhat.com>
1235
1236         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1237         parameter.
1238         (fetch_inferior_event): Use SCOPE_EXIT.
1239
1240
1241 2019-01-23  Tom Tromey  <tom@tromey.com>
1242             Pedro Alves  <palves@redhat.com>
1243
1244         * infrun.c (disable_thread_events): Delete.
1245         (stop_all_threads): Use SCOPE_EXIT.
1246
1247 2019-01-23  Tom Tromey  <tom@tromey.com>
1248             Pedro Alves  <palves@redhat.com>
1249
1250         * symfile.c: Include forward-scope-exit.h.
1251         (clear_symtab_users_cleanup): Replace forward declaration with
1252         a FORWARD_SCOPE_EXIT.
1253         (syms_from_objfile_1): Use the forward_scope_exit and
1254         gdb::optional instead of cleanup_function.
1255         (reread_symbols): Use the forward_scope_exit instead of
1256         cleanup_function.
1257         (clear_symtab_users_cleanup): Remove function.
1258
1259 2019-01-23  Tom Tromey  <tom@tromey.com>
1260             Pedro Alves  <palves@redhat.com>
1261
1262         * linux-nat.c: Include scope-exit.h.
1263         (cleanup_target_stop): Remove.
1264         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1265         SCOPE_EXIT.
1266
1267 2019-01-23  Tom Tromey  <tom@tromey.com>
1268             Pedro Alves  <palves@redhat.com>
1269
1270         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1271         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1272
1273 2019-01-23  Tom Tromey  <tom@tromey.com>
1274             Andrew Burgess  <andrew.burgess@embecosm.com>
1275             Pedro Alves  <palves@redhat.com>
1276
1277         * infrun.c (fetch_inferior_event): Use scope_exit.
1278         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1279         * top.c (execute_command): Use scope_exit.
1280         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1281         * utils.c (do_bpstat_clear_actions_cleanup)
1282         (make_bpstat_clear_actions_cleanup): Remove.
1283
1284 2019-01-23  Tom Tromey  <tom@tromey.com>
1285             Pedro Alves  <palves@redhat.com>
1286
1287         * infrun.c: Include "common/scope-exit.h"
1288         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1289         (wait_for_inferior): Use SCOPE_EXIT.
1290         (fetch_inferior_event): Use scope_exit.
1291
1292 2019-01-23  Tom Tromey  <tom@tromey.com>
1293             Pedro Alves  <palves@redhat.com>
1294
1295         * breakpoint.c (create_breakpoint): Remove cleanup.
1296
1297 2019-01-23  Tom Tromey  <tom@tromey.com>
1298             Andrew Burgess  <andrew.burgess@embecosm.com>
1299             Pedro Alves  <palves@redhat.com>
1300
1301 2019-01-23  Pedro Alves  <palves@redhat.com>
1302
1303         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1304
1305 2019-01-23  Pedro Alves  <palves@redhat.com>
1306             Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * gdbthread.h: Include "common/forward-scope-exit.h".
1309         (scoped_finish_thread_state): Redefine custom class in terms of
1310         forward_scope_exit.
1311
1312 2019-01-23  Pedro Alves  <palves@redhat.com>
1313             Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * common/forward-scope-exit.h: New file.
1316
1317 2019-01-23  Pedro Alves  <palves@redhat.com>
1318             Andrew Burgess  <andrew.burgess@embecosm.com>
1319             Tom Tromey  <tom@tromey.com>
1320
1321         * common/scope-exit.h: New file.
1322
1323 2019-01-23  Pedro Alves  <palves@redhat.com>
1324
1325         * common/preprocessor.h (ESC): Rename to ...
1326         (ESC_PARENS): ... this.
1327         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1328         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1329
1330 2019-01-23  Tom Tromey  <tom@tromey.com>
1331
1332         * language.h (class scoped_switch_to_sym_language_if_auto):
1333         Initialize m_lang in both cases.
1334
1335 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1336
1337         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1338         with XCNEW.
1339
1340 2019-01-22  Tom Tromey  <tom@tromey.com>
1341
1342         * corelow.c: Do not include sys/file.h.
1343
1344 2019-01-22  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-wingeneral.h: Include gdb_curses.h.
1347
1348 2019-01-22  Tom Tromey  <tom@tromey.com>
1349
1350         * source-cache.h (class source_cache) <get_source_lines,
1351         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1352
1353 2019-01-22  Tom Tromey  <tom@tromey.com>
1354
1355         * remote-fileio.h (struct remote_target): Declare.
1356
1357 2019-01-22  Tom Tromey  <tom@tromey.com>
1358
1359         * python/py-arch.c: Do not include py-ref.h.
1360         * python/py-bpevent.c: Do not include py-ref.h.
1361         * python/py-cmd.c: Do not include py-ref.h.
1362         * python/py-continueevent.c: Do not include py-ref.h.
1363         * python/py-event.h: Do not include py-ref.h.
1364         * python/py-evtregistry.c: Do not include py-ref.h.
1365         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1366         * python/py-frame.c: Do not include py-ref.h.
1367         * python/py-framefilter.c: Do not include py-ref.h.
1368         * python/py-function.c: Do not include py-ref.h.
1369         * python/py-infevents.c: Do not include py-ref.h.
1370         * python/py-linetable.c: Do not include py-ref.h.
1371         * python/py-objfile.c: Do not include py-ref.h.
1372         * python/py-param.c: Do not include py-ref.h.
1373         * python/py-prettyprint.c: Do not include py-ref.h.
1374         * python/py-progspace.c: Do not include py-ref.h.
1375         * python/py-symbol.c: Do not include py-ref.h.
1376         * python/py-symtab.c: Do not include py-ref.h.
1377         * python/py-type.c: Do not include py-ref.h.
1378         * python/py-unwind.c: Do not include py-ref.h.
1379         * python/py-utils.c: Do not include py-ref.h.
1380         * python/py-value.c: Do not include py-ref.h.
1381         * python/py-varobj.c: Do not include py-ref.h.
1382         * python/py-xmethods.c: Do not include py-ref.h.
1383         * python/python.c: Do not include py-ref.h.
1384         * varobj.c: Do not include py-ref.h.
1385
1386 2019-01-22  Tom Tromey  <tom@tromey.com>
1387
1388         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1389         keyword for bcache.
1390
1391 2019-01-22  Tom Tromey  <tom@tromey.com>
1392
1393         * compile/compile-cplus-types.c: Remove a comment by #include.
1394
1395 2019-01-22  Tom Tromey  <tom@tromey.com>
1396
1397         * compile/gcc-c-plugin.h: Include compile-internal.h.
1398
1399 2019-01-22  Tom Tromey  <tom@tromey.com>
1400
1401         * stabsread.c (EXTERN): Do not define.
1402         (symnum, next_symbol_text_func, processing_gcc_compilation)
1403         (within_function, global_sym_chain, global_stabs)
1404         (previous_stab_code, this_object_header_files)
1405         (n_this_object_header_files)
1406         (n_allocated_this_object_header_files): Define.
1407         * stabsread.h (EXTERN): Never define.  Use "extern".
1408
1409 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1410
1411         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1412         history_value.
1413
1414 2019-01-21  Tom Tromey  <tom@tromey.com>
1415
1416         * ui-out.c: Fix includes.
1417         * tui/tui-source.c: Fix includes.
1418         * target.c: Fix includes.
1419         * remote.c: Fix includes.
1420         * regcache.c: Fix includes.
1421         * python/py-block.c: Fix includes.
1422         * printcmd.c: Fix includes.
1423         * or1k-tdep.c: Fix includes.
1424         * mi/mi-main.c: Fix includes.
1425         * m32r-tdep.c: Fix includes.
1426         * csky-tdep.c: Fix includes.
1427         * compile/compile-cplus-types.c: Fix includes.
1428         * cli/cli-interp.c: Fix includes.
1429
1430 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1431
1432         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1433         for padding.
1434
1435 2019-01-16  Tom Tromey  <tom@tromey.com>
1436
1437         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1438         earlier.
1439         (struct objfile) <msymbols_range>: Move from top level.
1440         <msymbols>: New method.
1441         (class objfile_msymbols): Remove.
1442         * symtab.c (default_collect_symbol_completion_matches_break_on):
1443         Update.
1444         * symmisc.c (dump_msymbols): Update.
1445         * stabsread.c (scan_file_globals): Update.
1446         * objc-lang.c (info_selectors_command, info_classes_command)
1447         (find_methods): Update.
1448         * minsyms.c (find_solib_trampoline_target): Update.
1449         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1450         * coffread.c (coff_symfile_read): Update.
1451         * ada-lang.c (ada_lookup_simple_minsym)
1452         (ada_collect_symbol_completion_matches): Update.
1453
1454 2019-01-16  Tom Tromey  <tom@tromey.com>
1455
1456         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1457         type.  Remove no-argument constructor.
1458         <iterator::operator++>: Simplify.
1459         <begin>: Update.
1460         <end>: Use minimal_symbol_count.
1461
1462 2019-01-16  Tom Tromey  <tom@tromey.com>
1463
1464         * objfiles.h (struct objfile) <psymtabs>: New method.
1465         (class objfile_psymtabs): Remove.
1466         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1467         typedef.
1468         <range>: New method.
1469         (require_partial_symbols): Change return type.
1470         * psymtab.c (require_partial_symbols)
1471         (psym_expand_symtabs_matching): Update.
1472         * mdebugread.c (parse_partial_symbols): Update.
1473         * dbxread.c (dbx_end_psymtab): Update.
1474
1475 2019-01-15  Tom Tromey  <tom@tromey.com>
1476
1477         * symtab.c (lookup_objfile_from_block)
1478         (lookup_symbol_in_objfile_symtabs)
1479         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1480         (find_line_symtab, info_sources_command)
1481         (default_collect_symbol_completion_matches_break_on)
1482         (make_source_files_completion_list): Update.
1483         * symmisc.c (print_objfile_statistics, dump_objfile)
1484         (maintenance_print_symbols, maintenance_info_symtabs)
1485         (maintenance_check_symtabs, maintenance_info_line_tables):
1486         Update.
1487         * source.c (select_source_symtab)
1488         (forget_cached_source_info_for_objfile): Update.
1489         * objfiles.h (class objfile_compunits): Remove.
1490         (struct objfile) <compunits_range>: New typedef.
1491         (compunits): New method.
1492         * objfiles.c (objfile_relocate1): Update.
1493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1494         * maint.c (count_symtabs_and_blocks): Update.
1495         * linespec.c (iterate_over_all_matching_symtabs): Update.
1496         * cp-support.c (add_symbol_overload_list_qualified): Update.
1497         * coffread.c (coff_symtab_read): Update.
1498         * ada-lang.c (add_nonlocal_symbols)
1499         (ada_collect_symbol_completion_matches)
1500         (ada_add_global_exceptions): Update.
1501
1502 2019-01-15  Tom Tromey  <tom@tromey.com>
1503
1504         * progspace.h (program_space) <objfiles_safe_range>: New
1505         typedef.
1506         <objfiles_safe>: New method.
1507         * objfiles.h (class all_objfiles_safe): Remove.
1508         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1509         * jit.c (jit_inferior_exit_hook): Update.
1510
1511 2019-01-17  Tom Tromey  <tom@tromey.com>
1512
1513         * progspace.h (program_space) <objfiles_range>: New typedef.
1514         <objfiles>: New method.
1515         <objfiles_head>: Rename from objfiles.
1516         (object_files): Update.
1517         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1518         * guile/scm-pretty-print.c
1519         (ppscm_find_pretty_printer_from_objfiles): Update.
1520         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1521         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1522         Update.
1523         * python/py-progspace.c (pspy_get_objfiles): Update.
1524         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1525         Update.
1526         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1527         (objfpy_lookup_objfile_by_build_id): Update.
1528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1529         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1530         Update.
1531         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1532         (expand_symtab_containing_pc, lookup_objfile_from_block)
1533         (lookup_static_symbol, basic_lookup_transparent_type)
1534         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1535         (find_line_symtab, info_sources_command)
1536         (default_collect_symbol_completion_matches_break_on)
1537         (make_source_files_completion_list, find_main_name): Update.
1538         * symmisc.c (print_symbol_bcache_statistics)
1539         (print_objfile_statistics, maintenance_print_symbols)
1540         (maintenance_print_msymbols, maintenance_print_objfiles)
1541         (maintenance_info_symtabs, maintenance_check_symtabs)
1542         (maintenance_expand_symtabs, maintenance_info_line_tables):
1543         Update.
1544         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1545         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1546         (map_overlay_command, unmap_overlay_command)
1547         (simple_overlay_update, expand_symtabs_matching)
1548         (map_symbol_filenames): Update.
1549         * symfile-debug.c (set_debug_symfile): Update.
1550         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1551         Update.
1552         * source.c (select_source_symtab, forget_cached_source_info):
1553         Update.
1554         * solib.c (solib_read_symbols): Update.
1555         * solib-spu.c (append_ocl_sos): Update.
1556         * psymtab.c (maintenance_print_psymbols)
1557         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1558         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1559         * printcmd.c (info_symbol_command): Update.
1560         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1561         Update.
1562         * objfiles.h (class all_objfiles): Remove.
1563         * objfiles.c (have_partial_symbols, have_full_symbols)
1564         (have_minimal_symbols, qsort_cmp, update_section_map)
1565         (shared_objfile_contains_address_p)
1566         (default_iterate_over_objfiles_in_search_order): Update.
1567         * objc-lang.c (info_selectors_command, info_classes_command)
1568         (find_methods): Update.
1569         * minsyms.c (find_solib_trampoline_target): Update.
1570         * maint.c (maintenance_info_sections)
1571         (maintenance_translate_address, count_symtabs_and_blocks):
1572         Update.
1573         * main.c (captured_main_1): Update.
1574         * linux-thread-db.c (try_thread_db_load_from_pdir)
1575         (has_libpthread): Update.
1576         * linespec.c (iterate_over_all_matching_symtabs)
1577         (search_minsyms_for_name): Update.
1578         * jit.c (jit_find_objf_with_entry_addr): Update.
1579         * hppa-tdep.c (find_unwind_entry)
1580         (hppa_lookup_stub_minimal_symbol): Update.
1581         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1582         Update.
1583         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1584         (elf_gnu_ifunc_resolve_by_got): Update.
1585         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1586         * dwarf-index-write.c (save_gdb_index_command): Update.
1587         * cp-support.c (add_symbol_overload_list_qualified): Update.
1588         * breakpoint.c (create_overlay_event_breakpoint)
1589         (create_longjmp_master_breakpoint)
1590         (create_std_terminate_master_breakpoint)
1591         (create_exception_master_breakpoint): Update.
1592         * blockframe.c (find_pc_partial_function): Update.
1593         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1594         (ada_collect_symbol_completion_matches)
1595         (ada_add_global_exceptions): Update.
1596
1597 2019-01-17  Tom Tromey  <tom@tromey.com>
1598
1599         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1600         declare VEC.
1601         (solib_target_parse_libraries): Change return type.
1602         (library_list_start_segment, library_list_start_section)
1603         (library_list_end_library, library_list_start_library); Update.
1604         (solib_target_free_library_list): Remove.
1605         (solib_target_parse_libraries): Remove cleanup.  Change return
1606         type.
1607         (solib_target_current_sos): Update.
1608
1609 2019-01-17  Tom Tromey  <tromey@bapiya>
1610
1611         * valprint.c: Replace "the the" with "the".
1612         * symtab.c: Replace "the the" with "the".
1613         * solib.c: Replace "the the" with "the".
1614         * solib-dsbt.c: Replace "the the" with "the".
1615         * linespec.c: Replace "the the" with "the".
1616         * dwarf2loc.h: Replace "the the" with "the".
1617         * amd64-windows-tdep.c: Replace "the the" with "the".
1618         * aarch64-tdep.c: Replace "the the" with "the".
1619
1620 2019-01-16  Keith Seitz  <keiths@redhat.com>
1621
1622         PR gdb/23773
1623         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1624         <builder>: Rename to ..
1625         <m_builder>: ... this and make private.
1626         (dwarf2_cu::get_builder): New method.  Change all users of
1627         `builder' to use this method.
1628         (dwarf2_start_symtab): Move to ...
1629         (dwarf2_cu::start_symtab): ... here.  Update all callers
1630         (setup_type_unit_groups): Move to ...
1631         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1632         callers.
1633         (dwarf2_cu::reset_builder): New method.
1634         (process_full_compunit, process_full_type_unit): Use
1635         dwarf2_cu::reset_builder.
1636         (follow_die_offset): Record the ancestor CU if it is different
1637         from the followed DIE's CU.
1638         (follow_die_sig_1): Likewise.
1639
1640 2019-01-15  Tom Tromey  <tom@tromey.com>
1641
1642         * remote.c (class remote_state) <buf>: Now a char_vector.
1643         <buf_size>: Remove.
1644         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1645         parameter.
1646         (remote_target::getpkt_or_notif_sane_1)
1647         (remote_target::getpkt_sane)
1648         (remote_target::getpkt_or_notif_sane): Likewise.
1649         (class remote_target) <putpkt>: New overload.
1650         (remote_target::read_frame): Change type of "buf_p".  Remove
1651         sizeof_p parameter.
1652         (packet_ok): New overload.
1653         (packet_check_result): New overload.
1654         Update all uses.
1655
1656 2019-01-14  Tom Tromey  <tom@tromey.com>
1657
1658         * remote-notif.c (handle_notification, remote_notif_ack)
1659         (remote_notif_parse): Make "buf" const.
1660         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1661         const.
1662         (remote_notif_parse, remote_notif_ack, handle_notification):
1663         Likewise.
1664         * remote.c (remote_notif_stop_parse): Make "buf" const.
1665         (remote_target::remote_parse_stop_reply): Make "buf" const.
1666         (remote_notif_stop_ack): Make "buf" const.
1667
1668 2019-01-14  Tom Tromey  <tom@tromey.com>
1669
1670         * remote.c (remote_console_output): Make parameter const.
1671
1672 2019-01-14  Tom Tromey  <tom@tromey.com>
1673
1674         * target-debug.h (target_debug_print_signals): Constify.
1675         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1676         * procfs.c (procfs_target::pass_signals): Update.
1677         * linux-nat.c (linux_nat_target::pass_signals): Update.
1678         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1679         * target-delegates.c: Rebuild.
1680         * remote.c (remote_target::program_signals): Update.
1681         (remote_target::pass_signals): Update.
1682         * target.c (target_pass_signals): Constify argument.
1683         (target_program_signals): Likewise.
1684         * target.h (struct target_ops) <pass_signals, program_signals>:
1685         Constify argument.
1686         (target_pass_signals, target_program_signals): Constify argument.
1687
1688 2019-01-14  Tom Tromey  <tom@tromey.com>
1689
1690         PR tui/28819:
1691         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1692
1693 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1694
1695         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1696         field.
1697         * rs6000-tdep.c: Include reggroups.h.
1698         (IS_V_ALIAS_PSEUDOREG): Define.
1699         (rs6000_register_name): Return names for the "vX" aliases.
1700         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1701         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1702         aliases.  Call default_register_reggroup_p for all other
1703         pseudo-registers.
1704         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1705         New functions.
1706         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1707         Handle "vX" aliases.
1708         (v_alias_pseudo_register_collect): New function.
1709         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1710         (rs6000_gdbarch_init): Initialize "vX" aliases as
1711         pseudo-registers.  Restore registration of
1712         rs6000_pseudo_register_reggroup_p with
1713         set_tdesc_pseudo_register_reggroup_p.
1714
1715 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1716
1717         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1718         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1719         set_gdbarch_num_pseudo_regs.
1720
1721 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1722
1723         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1724         Remove arg prefixname, add do_set and do_show.
1725         Add member functions set_list and show_list.
1726         * cli/cli-style.c (class cli_style_option): Update accordingly.
1727         (style_set_list): Move to file scope.
1728         (style_show_list): Likewise.
1729         (set_style): Call help_list.
1730         (show_style): Call cmd_show_list.
1731         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1732         Update to use the new macro.
1733
1734 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1735
1736         * ada-lang.c (_initialize_ada_language): Expand the help text
1737         for the "catch exception" command.
1738
1739 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1740
1741         * symtab.c (matching_obj_sections): Initialize obj,
1742         declare it closer to its usage.
1743
1744 2019-01-10  Tom Tromey  <tom@tromey.com>
1745
1746         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1747         (basic_inf_threads_range): Remove.
1748         (inf_threads_range, inf_non_exited_threads_range)
1749         (safe_inf_threads_range): Use next_adapter.
1750
1751 2019-01-10  Keith Seitz  <keiths@redhat.com>
1752
1753         PR gdb/23712
1754         PR symtab/23010
1755         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1756         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1757
1758 2019-01-10  Keith Seitz  <keiths@redhat.com>
1759
1760         PR gdb/23712
1761         PR symtab/23010
1762         * dictionary.c (pending_to_vector): Remove.
1763         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1764         Remove _1 suffix, replacing functions of the same name.  Update
1765         all callers.
1766         (dict_create_hashed, dict_create_hashed_expandable)
1767         (dict_create_linear, dict_create_linear_expandable, dict_free)
1768         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1769         Make functions static.
1770
1771 2019-01-10  Keith Seitz  <keiths@redhat.com>
1772
1773         PR gdb/23712
1774         PR symtab/23010
1775         * dictionary.h (struct dictionary): Replace declaration with
1776         multidictionary.
1777         (dict_create_hashed, dict_create_hashed_expandable)
1778         (dict_create_linear, dict_create_linear_expandable)
1779         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1780         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1781         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1782         taking multidictionary argument.
1783         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1784         * block.h (struct block) <dict>: Change to multidictionary
1785         and rename `multidict'.
1786         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1787         symmisc.c: Update all dictionary references to multidictionary.
1788
1789 2019-01-10  Keith Seitz  <keiths@redhat.com>
1790
1791         PR gdb/23712
1792         PR symtab/23010
1793         * dictionary.c: Include unordered_map.
1794         (pending_to_vector): New function.
1795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1796         Rewrite the non-"_1" functions to take vector instead
1797         of linked list.
1798         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1799         "new" _1 versions of the same name.
1800         (multidictionary): Define.
1801         (std::hash<enum language): New definition.
1802         (collate_pending_symbols_by_language, mdict_create_hashed)
1803         (mdict_create_hashed_expandable, mdict_create_linear)
1804         (mdict_create_linear_expandable, mdict_free)
1805         (find_language_dictionary, create_new_language_dictionary)
1806         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1807         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1808         (mdict_size, mdict_empty): New functions.
1809         * dictionary.h (mdict_iterator): Define.
1810
1811 2019-01-10  Pedro Alves  <palves@redhat.com>
1812
1813         * breakpoint.c (read_uploaded_action)
1814         (create_tracepoint_from_upload): Adjust to use
1815         gdb::unique_xmalloc_ptr.
1816         * ctf.c (ctf_write_uploaded_tp):
1817         (SET_ARRAY_FIELD): Use emplace_back.
1818         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1819         * tracefile-tfile.c (tfile_write_uploaded_tp):
1820         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1821         gdb::unique_xmalloc_ptr.
1822         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1823         at_string, cond_string, cmd_strings>: Replace char pointers
1824         with gdb::unique_xmalloc_ptr.
1825
1826 2019-01-10  Pedro Alves  <palves@redhat.com>
1827
1828         * solib-target.c (library_list_start_library): Don't xstrdup name.
1829
1830 2019-01-10  Pedro Alves  <palves@redhat.com>
1831
1832         * mdebugread.c (parse_partial_symbols): Use
1833         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1834
1835 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * linux-fork.c (scoped_switch_fork_info)
1838         <~scoped_switch_fork_info>: Fix incorrect variable name.
1839
1840 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * linux-fork.c (scoped_switch_fork_info)
1843         <scoped_switch_fork_info>: Make explicit.
1844         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1845
1846 2019-01-10  Tom Tromey  <tom@tromey.com>
1847
1848         * objfiles.h (objfile::reset_psymtabs): Update.
1849         * objfiles.c (objfile::objfile): Update.
1850         * psymtab.h (psymtab_storage::obstack): Update.
1851         (psymtab_storage::m_obstack): Use gdb::optional.
1852         (class psymtab_storage): Update comment.  Remove objfile
1853         parameter.
1854         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1855
1856 2019-01-10  Tom Tromey  <tom@tromey.com>
1857
1858         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1859         <free_psymtabs>: Now private.
1860         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1861         (allocate_psymtab): Use new method.
1862
1863 2019-01-10  Tom Tromey  <tom@tromey.com>
1864
1865         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1866         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1867         * mdebugread.c (parse_partial_symbols): Use
1868         allocate_dependencies.
1869         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1870         allocate_dependencies.
1871         (process_psymtab_comp_unit_reader)
1872         (build_type_psymtab_dependencies): Likewise.
1873         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1874
1875 2019-01-10  Tom Tromey  <tom@tromey.com>
1876
1877         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1878         PSYMBOL_SET_LANGUAGE.
1879         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1880
1881 2019-01-10  Tom Tromey  <tom@tromey.com>
1882
1883         * psymtab.h (psymtab_storage::obstack): New method.
1884         <m_obstack>: Rename from obstack; now private.
1885         * psymtab.c (psymtab_storage): Update.
1886         * dwarf2read.c (create_addrmap_from_index)
1887         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1888         Update.
1889
1890 2019-01-10  Tom Tromey  <tom@tromey.com>
1891
1892         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1893         * objfiles.h (objfile::reset_psymtabs): New method.
1894
1895 2019-01-10  Tom Tromey  <tom@tromey.com>
1896
1897         * symmisc.c (print_symbol_bcache_statistics): Update.
1898         (print_objfile_statistics): Update.
1899         * symfile.c (reread_symbols): Update.
1900         * psymtab.h (class psymtab_storage): New.
1901         * psymtab.c (psymtab_storage): New constructor.
1902         (~psymtab_storage): New destructor.
1903         (require_partial_symbols): Update.
1904         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1905         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1906         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1907         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1908         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1909         (start_psymtab_common, end_psymtab_common)
1910         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1911         (allocate_psymtab): Update.
1912         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1913         Update.
1914         (dump_psymtab_addrmap, maintenance_print_psymbols)
1915         (maintenance_check_psymtabs): Update.
1916         (class objfile_psymtabs): Move to objfiles.h.
1917         * psympriv.h (discard_psymtab): Now inline.
1918         (psymtab_discarder::psymtab_discarder): Update.
1919         (psymtab_discarder::~psymtab_discarder): Update.
1920         (ALL_OBJFILE_PSYMTABS): Rewrite.
1921         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1922         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1923         Remove fields.
1924         <partial_symtabs>: New field.
1925         (class objfile_psymtabs): Move from psymtab.h.  Update.
1926         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1927         psymbol_cache.
1928         (objfile::~objfile): Don't destroy psymbol_cache.
1929         * mdebugread.c (parse_partial_symbols): Update.
1930         * dwarf2read.c (create_addrmap_from_index)
1931         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1932         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1933         (add_partial_subprogram, dwarf2_ranges_read): Update.
1934         * dwarf-index-write.c (write_address_map)
1935         (write_one_signatured_type, recursively_write_psymbols)
1936         (class debug_names, class debug_names, write_psymtabs_to_index):
1937         Update.
1938
1939 2019-01-10  Tom Tromey  <tom@tromey.com>
1940
1941         * symtab.h (SYMBOL_SET_NAMES): Update.
1942         (symbol_set_names): Update.
1943         (MSYMBOL_SET_NAMES): Update.
1944         * symtab.c (symbol_set_names): Change argument to be an
1945         objfile_per_bfd_storage.
1946         * psymtab.c (add_psymbol_to_bcache): Update.
1947         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1948
1949 2019-01-10  Tom Tromey  <tom@tromey.com>
1950
1951         * symtab.c (create_demangled_names_hash): Change argument to be an
1952         objfile_per_bfd_storage.
1953         (symbol_set_names): Update.
1954
1955 2019-01-10  Tom Tromey  <tom@tromey.com>
1956
1957         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1958         init_psymbol_list.
1959         * psymtab.c (init_psymbol_list): Do nothing if already called.
1960         * psympriv.h (init_psymbol_list): Add comment.
1961         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1962         init_psymbol_list.
1963         * dbxread.c (dbx_symfile_read): Unconditionally call
1964         init_psymbol_list.
1965
1966 2019-01-10  Tom Tromey  <tom@tromey.com>
1967
1968         * xcoffread.c (scan_xcoff_symtab): Update.
1969         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1970         "where".
1971         * mdebugread.c (parse_partial_symbols)
1972         (handle_psymbol_enumerators): Update.
1973         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1974         * dbxread.c (read_dbx_symtab): Update.
1975         * psympriv.h (psymbol_placement): New enum.
1976         (add_psymbol_to_list): Update.
1977
1978 2019-01-10  Tom Tromey  <tom@tromey.com>
1979
1980         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1981         static_psymbols parameters.
1982         (scan_xcoff_symtab): Update.
1983         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1984         static_psymbols parameters.
1985         * psympriv.h (start_psymtab_common): Update.
1986         * mdebugread.c (parse_partial_symbols): Update.
1987         * dwarf2read.c (create_partial_symtab): Update.
1988         * dbxread.c (read_dbx_symtab): Update.
1989         (start_psymtab): Remove global_psymbols and static_psymbols
1990         parameters.
1991
1992 2019-01-10  Tom Tromey  <tom@tromey.com>
1993
1994         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1995         * psymtab.c (allocate_psymtab): Add comment.
1996         * psympriv.h (allocate_psymtab): Add comment.
1997         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1998         initializations.
1999         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2000
2001 2019-01-10  Tom Tromey  <tom@tromey.com>
2002
2003         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2004         Don't declare.
2005         * mipsread.c: Include mdebugread.h.
2006         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2007         Declare.
2008         * elfread.c: Include mdebugread.h.
2009
2010 2019-01-09  Tom Tromey  <tom@tromey.com>
2011
2012         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2013         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2014         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2015         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2016         (psym_lookup_symbol, psym_find_last_source_symtab)
2017         (psym_forget_cached_source_info, psym_print_stats)
2018         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2019         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2020         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2021         (psym_find_compunit_symtab_by_address)
2022         (maintenance_print_psymbols, maintenance_info_psymtabs)
2023         (maintenance_check_psymtabs): Use ranged for.
2024         * psymtab.h (class objfile_psymtabs): New.
2025         (require_partial_symbols): Return objfile_psymtabs.
2026         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2027
2028 2019-01-09  Tom Tromey  <tom@tromey.com>
2029
2030         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2031         (find_pc_mapped_section, list_overlays_command)
2032         (map_overlay_command, unmap_overlay_command)
2033         (simple_overlay_update): Use all_objfiles.
2034         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2035         * printcmd.c (info_symbol_command): Use all_objfiles.
2036         * objfiles.h (ALL_OBJSECTIONS): Remove.
2037         * maint.c (maintenance_translate_address): Use all_objfiles.
2038         * gcore.c (gcore_create_callback): Use all_objfiles.
2039         (objfile_find_memory_regions): Likewise.
2040
2041 2019-01-09  Tom Tromey  <tom@tromey.com>
2042
2043         * symtab.c (find_line_symtab, info_sources_command)
2044         (make_source_files_completion_list): Use objfile_compunits.
2045         * source.c (select_source_symtab): Use objfile_compunits.
2046         * objfiles.h (struct objfile): Update comment.
2047         (ALL_OBJFILES): Remove.
2048         (ALL_FILETABS): Remove.
2049         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2050         objfile_compunits.
2051
2052 2019-01-09  Tom Tromey  <tom@tromey.com>
2053
2054         * symmisc.c (print_objfile_statistics, dump_objfile)
2055         (maintenance_print_symbols): Use compunit_filetabs.
2056         * source.c (forget_cached_source_info_for_objfile): Use
2057         compunit_filetabs.
2058         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2059         (ALL_FILETABS): Use compunit_filetabs.
2060         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2061         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2062
2063 2019-01-09  Tom Tromey  <tom@tromey.com>
2064
2065         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2066         (compunit_filetabs): New.
2067         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2068         compunit_filetabs.
2069         (info_sources_command, make_source_files_completion_list): Remove
2070         declaration.
2071         * symmisc.c (print_objfile_statistics, dump_objfile)
2072         (maintenance_print_symbols): Remove declaration.
2073         (maintenance_info_symtabs): Use compunit_filetabs.
2074         (maintenance_info_line_tables): Likewise.
2075         * source.c (select_source_symtab): Change local variable name.
2076         (forget_cached_source_info_for_objfile): Remove declaration.
2077         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2078         * objfiles.c (objfile_relocate1): Remove declaration.
2079         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2080         declaration.
2081         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2082         * coffread.c (coff_symtab_read): Remove declaration.
2083         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2084         compunit_filetabs.
2085
2086 2019-01-09  Tom Tromey  <tom@tromey.com>
2087
2088         * symtab.c (lookup_objfile_from_block)
2089         (find_pc_sect_compunit_symtab, search_symbols)
2090         (default_collect_symbol_completion_matches_break_on): Use
2091         objfile_compunits.
2092         * objfiles.h (ALL_COMPUNITS): Remove.
2093         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2094         * cp-support.c (add_symbol_overload_list_qualified): Use
2095         objfile_compunits.
2096         * ada-lang.c (ada_collect_symbol_completion_matches)
2097         (ada_add_global_exceptions): Use objfile_compunits.
2098
2099 2019-01-09  Tom Tromey  <tom@tromey.com>
2100
2101         * source.c (select_source_symtab)
2102         (forget_cached_source_info_for_objfile): Remove declaration.
2103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2104         declaration.
2105         * maint.c (count_symtabs_and_blocks): Remove declaration.
2106         * cp-support.c (add_symbol_overload_list_qualified): Remove
2107         declaration.
2108         * coffread.c (coff_symtab_read): Remove declaration.
2109         * symtab.c (lookup_symbol_in_objfile_symtabs)
2110         (basic_lookup_transparent_type_1): Use objfile_compunits.
2111         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2112         (info_sources_command, search_symbols)
2113         (default_collect_symbol_completion_matches_break_on)
2114         (make_source_files_completion_list): Remove declaration.
2115         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2116         (ada_collect_symbol_completion_matches)
2117         (ada_add_global_exceptions): Remove declaration.
2118         * linespec.c (iterate_over_all_matching_symtabs): Use
2119         objfile_compunits.
2120         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2121         (class objfile_compunits): New.
2122         (ALL_COMPUNITS): Use objfile_compunits.
2123         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2124         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2125         objfile_compunits.
2126         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2127
2128 2019-01-09  Tom Tromey  <tom@tromey.com>
2129
2130         * symtab.c (search_symbols)
2131         (default_collect_symbol_completion_matches_break_on): Use
2132         objfile_msymbols.
2133         * ada-lang.c (ada_lookup_simple_minsym)
2134         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2135         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2136         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2137         objfile_msymbols.
2138         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2139         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2140         * objc-lang.c (find_methods): Use objfile_msymbols.
2141         (info_selectors_command, info_classes_command): Likewise.
2142         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2143         * objfiles.h (class objfile_msymbols): New.
2144         (ALL_OBJFILE_MSYMBOLS): Remove.
2145         (ALL_MSYMBOLS): Remove.
2146
2147 2019-01-09  Tom Tromey  <tom@tromey.com>
2148
2149         * common/next-iterator.h (next_adapter): Add Iterator template
2150         parameter.
2151         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2152         (class all_objfiles_safe): New.
2153         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2154         * objfiles.c (put_objfile_before): Update comment.
2155         (add_separate_debug_objfile): Likewise.
2156         (free_all_objfiles): Use all_objfiles_safe.
2157         (objfile_purge_solibs): Likewise.
2158
2159 2019-01-09  Tom Tromey  <tom@tromey.com>
2160
2161         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2162         (expand_symtab_containing_pc, lookup_static_symbol)
2163         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2164         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2165         all_objfiles.
2166         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2167         * breakpoint.c (create_overlay_event_breakpoint)
2168         (create_longjmp_master_breakpoint)
2169         (create_std_terminate_master_breakpoint)
2170         (create_exception_master_breakpoint): Use all_objfiles.
2171         * linux-thread-db.c (try_thread_db_load_from_pdir)
2172         (has_libpthread): Use all_objfiles.
2173         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2174         * linespec.c (iterate_over_all_matching_symtabs)
2175         (search_minsyms_for_name): Use all_objfiles.
2176         * maint.c (maintenance_info_sections): Use all_objfiles.
2177         * main.c (captured_main_1): Use all_objfiles.
2178         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2179         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2180         * guile/scm-pretty-print.c
2181         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2182         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2183         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2184         (maintenance_print_msymbols): Use all_objfiles.
2185         * source.c (select_source_symtab): Use all_objfiles.
2186         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2187         * symfile.c (remove_symbol_file_command)
2188         (expand_symtabs_matching, map_symbol_filenames): Use
2189         all_objfiles.
2190         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2191         all_objfiles.
2192         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2193         * objc-lang.c (find_methods): Use all_objfiles.
2194         * objfiles.c (have_partial_symbols, have_full_symbols)
2195         (have_minimal_symbols, qsort_cmp)
2196         (default_iterate_over_objfiles_in_search_order): Use
2197         all_objfiles.
2198         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2199         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2200         (maintenance_check_psymtabs): Use all_objfiles.
2201         (ALL_PSYMTABS): Remove.
2202         * compile/compile-object-run.c (do_module_cleanup): Use
2203         all_objfiles.
2204         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2205         * cp-support.c (add_symbol_overload_list_qualified): Use
2206         all_objfiles.
2207         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2208         Use all_objfiles.
2209         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2210         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2211         all_objfiles.
2212         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2213         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2214         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2215         Uses all_objfiles.
2216         * solib.c (solib_read_symbols): Use all_objfiles
2217
2218 2019-01-09  Tom Tromey  <tom@tromey.com>
2219
2220         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2221         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2222         all_objfiles.
2223         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2224         * symmisc.c (print_symbol_bcache_statistics)
2225         (print_objfile_statistics, maintenance_print_objfiles)
2226         (maintenance_info_symtabs, maintenance_check_symtabs)
2227         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2228         all_objfiles.
2229         * source.c (forget_cached_source_info): Use all_objfiles.
2230         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2231         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2232         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2233         * objfiles.c (update_section_map): Use all_objfiles.
2234         (shared_objfile_contains_address_p): Likewise.
2235         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2236         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2237
2238 2019-01-09  Tom Tromey  <tom@tromey.com>
2239
2240         * common/next-iterator.h: New file.
2241         * objfiles.h (class all_objfiles): New.
2242         (struct objfile_iterator): New.
2243
2244 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2245
2246         * NEWS: Move the description of the changed "frame", "select-frame",
2247          and "info frame" commands to the Changed commands section.
2248
2249 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2250
2251         * gdbtypes.c (check_stub_method_group): Remove handling of old
2252         mangling schemes.
2253         * linespec.c (find_methods): Likewise.
2254         * stabsread.c (read_member_functions): Likewise.
2255         * valops.c (search_struct_method): Likewise.
2256         (value_struct_elt_for_reference): Likewise.
2257         * NEWS: Mention this change.
2258
2259 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2260
2261         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2262         print_source_lines.
2263         * source.c (print_source_lines_base): Update line number check.
2264         (print_source_lines): New function.
2265         (source_lines_range::source_lines_range): New function.
2266         * source.h (class source_lines_range): New class.
2267         (print_source_lines): New declaration.
2268
2269 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2270
2271         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2272
2273 2019-01-08  Tom Tromey  <tom@tromey.com>
2274             Simon Marchi  <simon.marchi@ericsson.com>
2275
2276         PR gdb/24060
2277         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2278         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2279         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2280         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2281         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2282         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2283
2284 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * source.c (select_source_symtab): Move header comment to
2287         declaration in source.h.
2288         (forget_cached_source_info_for_objfile): Likewise.
2289         (forget_cached_source_info): Likewise.
2290         (identify_source_line): Likewise.
2291         * source.h (identify_source_line): Move declaration from symtab.h
2292         and add comment from source.c
2293         (print_source_lines): Likewise.
2294         (forget_cached_source_info_for_objfile): Likewise.
2295         (forget_cached_source_info): Likewise.
2296         (select_source_symtab): Likewise.
2297         (enum print_source_lines_flag): Move definition from symtab.h.
2298         * symtab.h (identify_source_line): Move declaration to source.h.
2299         (print_source_lines): Likewise.
2300         (forget_cached_source_info_for_objfile): Likewise.
2301         (forget_cached_source_info): Likewise.
2302         (select_source_symtab): Likewise.
2303         (enum print_source_lines_flag): Move definition to source.h.
2304         * tui/tui-hooks.c: Add 'source.h' include.
2305
2306 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * source.c (print_source_lines_base): Handle requests to print
2309         reverse line number sequences, and guard against empty lines
2310         string.
2311
2312 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * source.c (print_source_lines_base): Fix skip of '\r' if next
2315         character is '\n'.
2316
2317 2019-01-06  Tom Tromey  <tom@tromey.com>
2318
2319         * c-exp.y (struct c_parse_state) <macro_original_text,
2320         expansion_obstack>: New member.
2321         (macro_original_text, expansion_obstack): Remove globals.
2322         (scan_macro_expansion, scanning_macro_expansion)
2323         (finished_macro_expansion): Update.
2324         (scan_macro_cleanup): Remove.
2325         (yylex, c_parse): Update.
2326
2327 2019-01-06  Tom Tromey  <tom@tromey.com>
2328
2329         * c-exp.y (struct c_parse_state) <strings>: New member.
2330         (operator_stoken): Update.
2331
2332 2019-01-06  Tom Tromey  <tom@tromey.com>
2333
2334         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2335         (union type_stack_elt) <typelist_val>: Now a pointer to
2336         std::vector.
2337         (type_stack_cleanup): Don't declare.
2338         (push_typelist): Update.
2339         * parse.c (pop_typelist): Return a std::vector.
2340         (push_typelist): Take a std::vector.
2341         (follow_types): Update.  Do not free args.
2342         (type_stack_cleanup): Remove.
2343         * c-exp.y (struct c_parse_state): New.
2344         (cpstate): New global.
2345         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2346         (nonempty_typelist): Update.
2347         (func_mod): Create a new vector.
2348         (c_parse): Create a c_parse_state.
2349         (check_parameter_typelist): Do not delete params.
2350         (function_method): Update.  Do not delete type_list.
2351
2352 2019-01-06  Tom Tromey  <tom@tromey.com>
2353
2354         PR gdb/28155:
2355         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2356         check_typedef.
2357         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2358         (print_return_value): Likewise.
2359
2360 2019-01-05  Tom Tromey  <tom@tromey.com>
2361
2362         * contrib/cleanup_check.py: Remove.
2363         * contrib/gcc-with-excheck: Remove.
2364         * contrib/exsummary.py: Remove.
2365         * contrib/excheck.py: Remove.
2366
2367 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2368
2369         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2370         NULL. Initialize tpprev to NULL instead of assigning it
2371         to NULL on the next statement.
2372         * windows-nat.c (windows_delete_thread): Remove check for
2373         main_thread_id before printing thread exit notifications.
2374         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2375         Remove thread ID check against main_thread_id.
2376         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2377         windows_delete_thread.
2378         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2379
2380 2019-01-04  Tom Tromey  <tom@tromey.com>
2381
2382         * compile/compile.c (_initialize_compile): Use upper case for
2383         metasyntactic variables.
2384         * symmisc.c (_initialize_symmisc): Use upper case for
2385         metasyntactic variables.
2386         * psymtab.c (_initialize_psymtab): Use upper case for
2387         metasyntactic variables.
2388         * demangle.c (demangle_command): Use upper case for metasyntactic
2389         variables.
2390         (_initialize_demangler): Likewise.
2391         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2392         variables.
2393
2394 2019-01-03  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2397
2398 2019-01-03  Tom Tromey  <tom@tromey.com>
2399
2400         * python/py-symtab.c (salpy_str): Update.
2401         (struct salpy_sal_object) <symtab>: Now a PyObject.
2402         (salpy_dealloc): Update.
2403         (del_objfile_sal): Use gdbpy_ref.
2404
2405 2019-01-03  Tom Tromey  <tom@tromey.com>
2406
2407         * python/py-type.c (convert_field): Use new_reference.  Return
2408         gdbpy_ref.
2409         (make_fielditem): Return gdbpy_ref.
2410         (typy_fields): Update.
2411         (typy_getitem): Update.
2412         (field_name): Return gdbpy_ref.  Use new_reference.
2413         (typy_iterator_iternext): Update.
2414
2415 2019-01-03  Tom Tromey  <tom@tromey.com>
2416
2417         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2418
2419 2019-01-03  Tom Tromey  <tom@tromey.com>
2420
2421         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2422         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2423         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2424         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2425         (pspy_set_type_printers): Likewise.
2426         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2427         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2428         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2429         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2430         (objfpy_set_type_printers): Likewise.
2431
2432 2019-01-03  Tom Tromey  <tom@tromey.com>
2433
2434         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2435         (gdbpy_print_stack): Use gdbpy_err_fetch.
2436         * python/python-internal.h (class gdbpy_err_fetch): New class.
2437         (class gdbpy_enter) <m_error_type, m_error_value,
2438         m_error_traceback>: Remove.
2439         <m_error>: New member.
2440         (gdbpy_exception_to_string): Don't declare.
2441         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2442         * python/py-value.c (convert_value_from_python): Use
2443         gdbpy_err_fetch.
2444         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2445         gdbpy_exception_to_string.
2446         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2447         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2448         gdbpy_err_fetch.
2449
2450 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * linux-nat.c (delete_lwp_cleanup): Delete.
2453         (struct lwp_deleter): New struct.
2454         (lwp_info_up): New typedef.
2455         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2456         lwp_info_up.
2457
2458 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * linux-fork.c (class scoped_switch_fork_info): New class.
2461         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2462
2463 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * valops.c (find_overload_match): Remove use of null_cleanup, and
2466         calls to do_cleanups.
2467
2468 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * compile/compile-cplus-types.c
2471         (compile_cplus_instance::decl_name): Handle changes to
2472         cp_func_name.
2473         * cp-support.c (cp_func_name): Update header comment, update
2474         return type.
2475         * cp-support.h (cp_func_name): Update return type in declaration.
2476         * valops.c (find_overload_match): Move temp_func local to top
2477         level of function and change its type.  Use temp_func to hold and
2478         delete temporary string obtained from cp_func_name.
2479
2480 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2483         gdb::char_vector, remove cleanup, and update uses of `msg`.
2484
2485 2019-01-03  Jim Wilson  <jimw@sifive.com>
2486
2487         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2488
2489 2019-01-02  Tom Tromey  <tom@tromey.com>
2490
2491         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2492         (tdesc_parse_xml): Remove cleanups.
2493         * target-descriptions.h (make_cleanup_free_target_description):
2494         Don't declare.
2495         (target_desc_deleter): New struct.
2496         (target_desc_up): New typedef.
2497         * target-descriptions.c (target_desc_deleter::operator()): Rename
2498         from free_target_description.
2499         (make_cleanup_free_target_description): Remove.
2500
2501 2019-01-02  Tom Tromey  <tom@tromey.com>
2502
2503         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2504         constructor, destructor.
2505         (linespec_parser): Remove typedef.
2506         (~linespec_parser): Rename from linespec_parser_delete.
2507         (linespec_lex_to_end, linespec_complete_label)
2508         (linespec_complete): Update.
2509         (decode_line_full): Remove cleanups.
2510         (decode_line_1): Update.
2511
2512 2019-01-02  Tom Tromey  <tom@tromey.com>
2513
2514         * python/python-internal.h (inferior_to_inferior_object): Change
2515         return type.
2516         * python/py-exitedevent.c (create_exited_event_object): Update.
2517         * python/py-inferior.c (inferior_to_inferior_object): Return
2518         gdbpy_ref.
2519         (python_new_inferior, python_inferior_deleted)
2520         (thread_to_thread_object, delete_thread_object)
2521         (build_inferior_list, gdbpy_selected_inferior): Update.
2522         * python/py-infthread.c (create_thread_object): Update.  Also fail
2523         if inferior_to_inferior_object fails.
2524
2525 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2526
2527         * inferior.h (class inferior) <displaced_step_state>: New field.
2528         * infrun.h (struct displaced_step_state): Move here from
2529         infrun.c.  Initialize fields, add constructor.
2530         <inf>: Remove field.
2531         <reset>: New method.
2532         * infrun.c (struct displaced_step_inferior_state): Move to
2533         infrun.h.
2534         (displaced_step_inferior_states): Remove.
2535         (get_displaced_stepping_state): Adust.
2536         (displaced_step_in_progress_any_inferior): Adjust.
2537         (displaced_step_in_progress_thread): Adjust.
2538         (displaced_step_in_progress): Adjust.
2539         (add_displaced_stepping_state): Remove.
2540         (get_displaced_step_closure_by_addr): Adjust.
2541         (remove_displaced_stepping_state): Remove.
2542         (infrun_inferior_exit): Call displaced_step_state.reset.
2543         (use_displaced_stepping): Don't check for NULL.
2544         (displaced_step_prepare_throw): Call
2545         get_displaced_stepping_state.
2546         (displaced_step_fixup): Don't check for NULL.
2547         (prepare_for_detach): Don't check for NULL.
2548
2549 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2550
2551         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2552          in case of call that did not complete.
2553
2554 2019-01-02  Andrey Utkin  <autkin@undo.io>
2555
2556         * symfile.c (find_separate_debug_file): Fix search of debug files for
2557         remote debuggee.
2558
2559 2019-01-02  Tom Tromey  <tom@tromey.com>
2560
2561         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2562         indentation.
2563         * python/py-frame.c (frapy_older): Remove cast.
2564         (frapy_newer): Likewise.
2565         * python/py-breakpoint.c (local_setattro): Remove cast.
2566         * python/py-arch.c (archpy_name): Remove local variable.
2567         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2568
2569 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2570
2571         * unittests/basic_string_view/element_access/char/empty.cc:
2572         Fix year range in copyright header.
2573
2574 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2577         Delete.
2578         <operator==>: Update with for removed field.
2579         <hash>: Likewise.
2580         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2581         <isa_features>: ...this.
2582         <abi_features>: New field.
2583         (riscv_isa_flen): Update comment.
2584         (riscv_abi_xlen): New declaration.
2585         (riscv_abi_flen): New declaration.
2586         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2587         isa_features.
2588         (riscv_abi_xlen): New function.
2589         (riscv_isa_flen): Update to get answer from isa_features.
2590         (riscv_abi_flen): New function.
2591         (riscv_has_fp_abi): Update to get answer from abi_features.
2592         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2593         xlen and flen.
2594         (riscv_call_info) <xlen, flen>: Update comment.
2595         (riscv_call_arg_struct): Remove invalid assertions
2596         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2597         is removed.
2598         (riscv_gdbarch_init): Gather isa features and abi features
2599         separately, ensure both match on the gdbarch when reusing an old
2600         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2601         a target with 64-bit float hardware.
2602
2603 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2604
2605         * source.c (search_command_helper): Stop reverse search
2606         when line 1 has been searched.
2607
2608 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2609
2610         * record-full.c (record_full_base_target::close): Rewrite
2611         record_full_core_buf_list free logic.
2612
2613 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2614
2615         * break-catch-syscall.c (print_one_catch_syscall): xfree
2616         the last text.
2617
2618 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2619
2620         * top.c (print_gdb_version): Update Copyright year in version
2621         message.
2622
2623 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2624
2625         Update copyright year range in all GDB files.
2626
2627 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2628
2629         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2630
2631 For older changes see ChangeLog-2018.
2632 \f
2633 Local Variables:
2634 mode: change-log
2635 left-margin: 8
2636 fill-column: 74
2637 version-control: never
2638 coding: utf-8
2639 End:
2640