(Windows) fix thr != nullptr assert failure in delete_thread_1
[external/binutils.git] / gdb / ChangeLog
1 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2
3         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4         Use current_event.dwThreadId instead of main_thread_id.
5
6 2019-04-30  Tom Tromey  <tromey@adacore.com>
7
8         PR c++/24470:
9         * dwarf2read.c (process_structure_scope): Handle case where type
10         has template parameters but no symbol was created.
11
12 2019-04-19  Sergei Trofimovich <siarheit@google.com>
13
14         * configure.ac: add --enable-source-highlight switch.
15         * configure: Regenerate.
16         * top.c (print_gdb_version): plumb --enable-source-highlight
17         status to "show configuration".
18
19 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
20
21         PR symtab/24423:
22         * source.c (print_source_lines_base): Advance "iter" when a
23         control character is seen.
24
25 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
26
27         * inferior.h (struct infcall_suspend_state_deleter):
28         Catch exception in destructor to avoid crash.
29
30 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
31
32         * utils.c (prompt_for_continue): Don't restore the styling at the
33         end, as applied_style has the wrong value.  This fixes styling in
34         long lists of file names that are interrupted by the "Continue?"
35         prompt.
36
37 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
38
39         * version.in: Set GDB version number to 8.2.91.DATE-git.
40
41 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
42
43         GDB 8.2.91 released.
44
45 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
46
47         * version.in: Set GDB version number to 8.2.91.
48
49 2019-03-20  Tom Tromey  <tromey@adacore.com>
50
51         PR gdb/24391
52         * infrun.c (handle_inferior_event): Rename from
53         handle_inferior_event_1.  Create a scoped_value_mark.
54         (handle_inferior_event): Remove.
55
56 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
57
58         * source-cache.c (source_cache::get_source_lines): Re-read
59         fullname after calling open_source_file.
60
61 2019-03-18  Pedro Alves  <palves@redhat.com>
62             Eli Zaretskii <eliz@gnu.org>
63
64         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
65         m_line and m_start_of_line.
66
67 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
68
69         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
70         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
71         it returns a newline.  This fixes a regression in TU mode, whereby
72         the next line is output on the same screen line as the user input.
73
74 2019-03-18  Pedro Alves  <palves@redhat.com>
75
76         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
77         New globals.
78         (apply_style): New, factored out from ...
79         (apply_ansi_escape): ... this.  Handle reverse video mode.
80         (tui_set_reverse_mode): New function.
81         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
82         * tui/tui-winsource.c (tui_show_source_line): Use
83         tui_set_reverse_mode instead of setting A_STANDOUT.
84         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
85         New setter methods.
86
87 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
88
89         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
90         Handle tabs.
91
92 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
93
94         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
95         tui_refill_source_window instead of tui_refresh_win, to update the
96         current execution line.  This fixes redisplay of the current line
97         when stepping through the code with "next" or "step".
98
99 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
100
101         * source-cache.c (source_cache::get_source_lines): Call
102         find_source_lines to initialize s->nlines.  This fixes vertical
103         scrolling of TUI source window when the DOWN arrow is pressed.
104
105 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
106
107         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
108         wclrtoeol in tui_show_source_line".  This reverts changes made in
109         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
110
111 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
112
113         * NEWS: Combine separate "New targets" sections for 8.3.
114
115 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
116
117         The MS-Windows port of ncurses fails to switch to a color pair if
118         one or both of the colors are the implicit default colors.  This
119         change records the default colors when TUI is initialized, and
120         then specifies them explicitly when a color pair uses the default
121         colors.  This allows color styling in TUI mode on MS-Windows.
122
123         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
124         ncurses_norm_attr.
125         (tui_initialize_io) [__MINGW32__]: Record the default terminal
126         colors in ncurses_norm_attr.
127         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
128         "none", replace it with the default color recorded in
129         ncurses_norm_attr.
130
131 2019-03-14  Tom Tromey  <tromey@adacore.com>
132
133         * source-cache.h (class source_cache) <get_source_lines>: Return
134         std::string.
135         * source-cache.c (source_cache::extract_lines): Handle case where
136         first_pos==npos.  Return std::string.
137         (source_cache::get_source_lines): Update.
138
139 2019-03-14  Tom Tromey  <tromey@adacore.com>
140
141         * NEWS: Add item for "style sources" commands.
142         * source-cache.c (source_cache::get_source_lines): Check
143         source_styling.
144         * cli/cli-style.c (source_styling): New global.
145         (_initialize_cli_style): Add "style sources" commands.
146         (show_style_sources): New function.
147         * cli/cli-style.h (source_styling): Declare.
148
149 2019-03-14  Pedro Alves  <palves@redhat.com>
150             Tom Tromey  <tromey@adacore.com>
151
152         * tui/tui-winsource.h (tui_refill_source_window): Declare.
153         * tui/tui-winsource.c (tui_refill_source_window): New function,
154         from...
155         (tui_horizontal_source_scroll): ... here.  Move some logic.
156         * cli/cli-style.c (set_style_enabled): Notify new observable.
157         * tui/tui-hooks.c (tui_redisplay_source): New function.
158         (tui_attach_detach_observers): Attach or detach
159         tui_redisplay_source.
160         * observable.h (source_styling_changed): New observable.
161         * observable.c: Define source_styling_changed observable.
162
163 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
164
165         PR/24325
166         * source-cache.c: #undef open and close, to avoid unresolved
167         externals during linking.
168
169 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
170
171         Support styling on native MS-Windows console
172
173         PR/24315
174         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
175         on MS-Windows if $TERM is not defined.
176
177         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
178
179         * posix-hdep.c (gdb_console_fputs):
180         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
181         functions.
182         * ui-file.h (gdb_console_fputs): Add prototype.
183
184         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
185         back to fputs only if the former returns zero.
186
187 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
188             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
189
190         PR gdb/8527
191         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
192         set_sigint_trap, clear_sigint_trap.
193
194 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
195
196         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
197         for-loop range, to avoid compiler warnings.
198
199         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
200         avoid compiler warnings about unused variables.
201
202 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
203
204         * NEWS: Mention end of support for native debugging on MS-Windows
205         before XP.
206
207 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
208
209         PR gdb/24292
210         * common/netstuff.c:
211         * gdbserver/gdbreplay.c
212         * gdbserver/remote-utils.c:
213         * ser-tcp.c:
214         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
215         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
216         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
217         'getaddrinfo' and 'freeaddrinfo' were not available before
218         Windows XP, and mingw.org's MinGW headers by default define
219         _WIN32_WINNT to 0x500.
220
221 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
222     
223         * NEWS: Note minimum Python version.
224
225 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
226
227         * version.in: Set GDB version number to 8.2.90.DATE-git.
228
229 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
230
231         GDB 8.2.90 released.
232
233 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
234
235         * version.in: Set GDB version number to 8.2.90.
236
237 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
238
239         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
240
241 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
242
243         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
244         * version.in: Bump version to 8.2.90.DATE-git.
245
246 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
247
248         * aix-thread.c (ptid_cmp): Remove unused variable.
249         (get_signaled_thread): Likewise.
250         (store_regs_user_thread): Likewise.
251         (store_regs_kernel_thread): Likewise.
252         (fetch_regs_kernel_thread): Remove shadowed variable.
253
254 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
255
256         * features/riscv/32bit-cpu.xml: Add register numbers.
257         * features/riscv/32bit-fpu.c: Regenerate.
258         * features/riscv/32bit-fpu.xml: Add register numbers.
259         * features/riscv/64bit-cpu.xml: Add register numbers.
260         * features/riscv/64bit-fpu.c: Regenerate.
261         * features/riscv/64bit-fpu.xml: Add register numbers.
262
263 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
264
265         * NEWS: Mention two argument form of gdb.Value constructor.
266         * python/py-value.c (convert_buffer_and_type_to_value): New
267         function.
268         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
269         Add support for handling an optional second argument.  Call
270         convert_buffer_and_type_to_value as appropriate.
271         * python/python-internal.h (Py_buffer_deleter): New struct.
272         (Py_buffer_up): New typedef.
273
274 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
275
276         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
277         instead of releasing ownership.
278
279 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
280
281         * dwarf2read.c (open_and_init_dwp_file): Call
282         elf_numsections instead of bfd_count_sections to initialize
283         dwp_file->num_sections.
284
285 2019-02-25  Tom Tromey  <tromey@adacore.com>
286
287         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
288
289 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
290
291         * gcore.in: Add '--readnever' option when invoking GDB.
292
293 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
294
295         * MAINTAINERS: Update my email address.
296
297 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
298
299         * build-id.c (build_id_to_debug_bfd_1): New function.
300         (build_id_to_debug_bfd): Look for separate debug file in
301         sysroot.
302
303 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
304
305         * gdbarch.sh: Update the copyright year range that is placed into
306         generated files.
307
308 2019-02-22  Keith Seitz  <keiths@redhat.com>
309
310         PR symtab/23853
311         * linespec.c (create_sals_line_offset): Search for the default
312         symtab's filename instead of its fullname.
313
314 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
315
316         * NEWS: Update style defaults.
317
318 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
319
320         * main.c (captured_main_1): Disable styling in batch mode.
321
322 2019-02-20  Tom Tromey  <tom@tromey.com>
323
324         * symtab.c (symtab_symbol_info): Fix typos.
325
326 2019-02-20  Tom Tromey  <tromey@adacore.com>
327
328         * findcmd.c (_initialize_mem_search): Use upper case for
329         metasyntactic variables.
330
331 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
332
333         * aarch64-tdep.c (aarch64_add_reggroups): New function.
334         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
335
336 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
337
338         * top.h (source_file_name): Change to std::string.
339         * top.c (source_file_name): Likewise.
340         (command_line_input): Adjust.
341         * cli/cli-script.c (script_from_file): Adjust.
342
343 2019-02-19  Tom Tromey  <tromey@adacore.com>
344
345         * ravenscar-thread.c
346         (ravenscar_thread_target::update_thread_list): Don't call
347         ada_build_task_list.
348         * ada-lang.h (ada_build_task_list): Don't declare.
349         * ada-tasks.c (struct ada_tasks_inferior_data)
350         <task_list_valid_p>: Now bool.
351         (read_known_tasks, ada_task_list_changed)
352         (ada_tasks_invalidate_inferior_data): Update.
353         (read_known_tasks_array): Return bool.
354         (read_known_tasks_list): Likewise.
355         (read_known_tasks): Return void.
356         (ada_build_task_list): Now static.
357
358 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
359
360         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
361         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
362
363 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
364
365         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
366         variant for ada_tasks_pspace_data_handle and
367         ada_tasks_inferior_data_handle.
368         (ada_tasks_pspace_data_cleanup): New function.
369         (ada_tasks_inferior_data_cleanup): New function.
370
371 2019-02-17  Tom Tromey  <tom@tromey.com>
372
373         * macrotab.h (macro_source_fullname): Return a std::string.
374         * macrotab.c (macro_include, check_for_redefinition)
375         (macro_undef, macro_lookup_definition, foreach_macro)
376         (foreach_macro_in_scope): Update.
377         (macro_source_fullname): Return a std::string.
378         * macrocmd.c (show_pp_source_pos): Update.
379
380 2019-02-17  Tom Tromey  <tom@tromey.com>
381
382         * macrocmd.c (show_pp_source_pos): Style the file names.
383
384 2019-02-17  Tom Tromey  <tom@tromey.com>
385
386         PR tui/24197:
387         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
388
389 2019-02-17  Tom Tromey  <tom@tromey.com>
390
391         * ada-lang.c (user_select_syms): Use filtered printing.
392         * utils.c (wrap_style): New global.
393         (desired_style): Remove.
394         (emit_style_escape): Add stream parameter.
395         (set_output_style, reset_terminal_style, prompt_for_continue):
396         Update.
397         (flush_wrap_buffer): Only flush gdb_stdout.
398         (wrap_here): Set wrap_style.
399         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
400         treat escape sequences as a character.  Change when wrap buffer is
401         flushed.
402         (fputs_styled): Do not set the output style when the default is
403         requested.
404         * ui-style.h (struct ui_file_style) <is_default>: New method.
405         * source.c (print_source_lines_base): Emit escape sequences in one
406         piece.
407
408 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
409
410         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
411         integers and enumeration types.
412
413 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
414
415         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
416         instead of lookup_symbol_in_language
417         (do_exact_match): New function.
418         (ada_get_symbol_name_matcher): Return do_exact_match when
419         doing a verbatim match.
420
421 2019-02-15  Tom Tromey  <tromey@adacore.com>
422
423         * ravenscar-thread.c (ravenscar_thread_target::resume)
424         (ravenscar_thread_target::wait): Special case wildcard requests.
425
426 2019-02-15  Tom Tromey  <tromey@adacore.com>
427
428         * ravenscar-thread.c (base_ptid): Remove.
429         (struct ravenscar_thread_target) <close>: New method.
430         <m_base_ptid>: New member.
431         <update_inferior_ptid, active_task, task_is_currently_active,
432         runtime_initialized>: Declare methods.
433         <ravenscar_thread_target>: Add constructor.
434         (ravenscar_thread_target::task_is_currently_active)
435         (ravenscar_thread_target::update_inferior_ptid)
436         (ravenscar_runtime_initialized): Rename.  Now methods.
437         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
438         (ravenscar_thread_target::update_thread_list): Update.
439         (ravenscar_thread_target::active_task): Now method.
440         (ravenscar_thread_target::store_registers)
441         (ravenscar_thread_target::prepare_to_store)
442         (ravenscar_thread_target::prepare_to_store)
443         (ravenscar_thread_target::mourn_inferior): Update.
444         (ravenscar_inferior_created): Use "new" to create target.
445         (ravenscar_thread_target::get_ada_task_ptid): Update.
446         (_initialize_ravenscar): Don't initialize base_ptid.
447         (ravenscar_ops): Remove global.
448
449 2019-02-15  Tom Tromey  <tromey@adacore.com>
450
451         * target.h (push_target): Declare new overload.
452         * target.c (push_target): New overload, taking an rvalue reference.
453         * remote.c (remote_target::open_1): Use push_target overload.
454         * corelow.c (core_target_open): Use push_target overload.
455
456 2019-02-15  Tom Tromey  <tromey@adacore.com>
457
458         * ravenscar-thread.c (is_ravenscar_task)
459         (ravenscar_task_is_currently_active): Return bool.
460         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
461         (_initialize_ravenscar): Remove "(void)".
462         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
463         Return bool.
464
465 2019-02-15  Tom Tromey  <tromey@adacore.com>
466
467         * ravenscar-thread.c (ravenscar_runtime_initializer)
468         (has_ravenscar_runtime, get_running_thread_id)
469         (ravenscar_thread_target::resume): Fix indentation.
470
471 2019-02-15  Tom Tromey  <tromey@adacore.com>
472
473         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
474         from ravenscar_arch_ops.
475         (sparc_ravenscar_ops::fetch_registers)
476         (sparc_ravenscar_ops::store_registers): Now methods.
477         (sparc_ravenscar_prepare_to_store): Remove.
478         (sparc_ravenscar_ops): Redefine.
479         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
480         methods and destructor.  Remove members.
481         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
482         (ravenscar_thread_target::store_registers)
483         (ravenscar_thread_target::prepare_to_store): Update.
484         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
485         Remove.
486         (struct ppc_ravenscar_powerpc_ops): Derive from
487         ravenscar_arch_ops.
488         (ppc_ravenscar_powerpc_ops::fetch_registers)
489         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
490         (ppc_ravenscar_powerpc_ops): Redefine.
491         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
492         (ppc_ravenscar_e500_ops::fetch_registers)
493         (ppc_ravenscar_e500_ops::store_registers): Now methods.
494         (ppc_ravenscar_e500_ops): Redefine.
495         * aarch64-ravenscar-thread.c
496         (aarch64_ravenscar_generic_prepare_to_store): Remove.
497         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
498         (aarch64_ravenscar_fetch_registers)
499         (aarch64_ravenscar_store_registers): Now methods.
500         (aarch64_ravenscar_ops): Redefine.
501
502 2019-02-15  Tom Tromey  <tromey@adacore.com>
503
504         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
505         (ravenscar_thread_target::stopped_by_hw_breakpoint)
506         (ravenscar_thread_target::stopped_by_watchpoint)
507         (ravenscar_thread_target::stopped_data_address)
508         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
509
510 2019-02-15  Tom Tromey  <tromey@adacore.com>
511
512         * ravenscar-thread.c: Fix some typos.
513
514 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
515             Tom Tromey  <tromey@adacore.com>
516
517         * ada-lang.c (ada_exception_sal): Change addr_string to a
518         std::string.
519         (create_ada_exception_catchpoint): Update.
520
521 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
522             Tom Tromey  <tromey@adacore.com>
523
524         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
525         (bp_location_ops): Remove.
526         (base_breakpoint_allocate_location): Update.
527         (free_bp_location): Update.
528         * ada-lang.c (class ada_catchpoint_location)
529         <ada_catchpoint_location>: Remove ops parameter.
530         (ada_catchpoint_location_dtor): Remove.
531         (ada_catchpoint_location_ops): Remove.
532         (allocate_location_exception): Update.
533         * breakpoint.h (struct bp_location_ops): Remove.
534         (class bp_location) <bp_location>: Remove bp_location_ops
535         parameter.
536         <~bp_location>: Add destructor.
537         <ops>: Remove.
538
539 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
540             Pedro Alves  <palves@redhat.com>
541
542         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
543         'PATH_MAX'.
544
545 2019-02-14  David Michael  <fedora.dm0@gmail.com>
546             Samuel Thibault  <samuel.thibault@gnu.org>
547             Thomas Schwinge  <thomas@codesourcery.com>
548
549         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
550         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
551
552 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
553
554         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
555         (check_empty): Use "const char *".
556
557         * gnu-nat.c (gnu_nat_target::detach): Instead of
558         'detach_inferior (pid)' call
559         'detach_inferior (find_inferior_pid (pid))'.
560
561         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
562         'nat/fork-inferior.o'.
563         * gnu-nat.c: #include "nat/fork-inferior.h".
564
565         * gnu-nat.c (gnu_nat_target::detach): Instead of
566         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
567         * gnu-nat.h: #include "inf-child.h".
568         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
569         'i386_gnu_nat_target::fetch_registers'.
570         (gnu_store_registers): Rename/move to
571         'i386_gnu_nat_target::store_registers'.
572
573         * config/i386/nm-i386gnu.h: Don't "#include" any files.
574         * gnu-nat.h (mach_thread_info): New function.
575         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
576
577         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
578
579 2019-02-14  Frederic Konrad  <konrad@adacore.com>
580
581         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
582
583 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
584
585         * windows-nat.c (windows_add_thread): Add new parameter
586         "main_thread_p" with default value set to false.  Update
587         function documentation as well as all callers.
588         (windows_delete_thread): Likewise.
589         (fake_create_process): Update call to windows_add_thread.
590         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
591         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
592         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
593         call to windows_delete_thread.
594
595 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
596
597         * MAINTAINERS: Add Andrew Burgess as global maintainer.
598
599 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
600
601         * symfile.c (find_separate_debug_file): Use canonical path of
602         sysroot with child_path instead of gdb_sysroot if it is valid.
603
604 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
605
606         * symfile.c (find_separate_debug_file): Use child_path to
607         determine if an object file is under a sysroot.
608
609 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
610
611         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
612         unittests/child-path-selftests.c.
613         * common/pathstuff.c (child_path): New function.
614         * common/pathstuff.h (child_path): New prototype.
615         * unittests/child-path-selftests.c: New file.
616
617 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
618
619         * symfile.c (find_separate_debug_file): Look for separate debug
620         files in debug directories under the sysroot.
621
622 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
623
624         * symtab.h (struct minimal_symbol data_p): New const method.
625         (struct minimal_symbol text_p): Likewise.
626         * symtab.c (output_source_filename): Use file name style
627         to print file name.
628         (print_symbol_info): Likewise.
629         (print_msymbol_info): Use address style to print addresses.
630         Use function name style to print executable text symbols.
631         (expand_symtab_containing_pc): Use data_p.
632         (find_pc_sect_compunit_symtab): Likewise.
633
634 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
635
636         * breakpoint.c (describe_other_breakpoints): Use address style
637         to print addresses.
638         (say_where): Likewise.
639
640 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
641
642         * ada-typeprint.c (print_func_type): Print function name
643         style to print function name.
644         * c-typeprint.c (c_print_type_1): Likewise.
645
646 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
647
648         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
649         for execve.
650
651 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
652
653         * c-exp.y (direct_abs_decl): Use emplace_back to record the
654         type_stack.
655
656 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
657
658         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
659         TYPE_CODE_REF types.
660
661 2019-02-08  Jim Wilson  <jimw@sifive.com>
662
663         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
664         (riscv_linux_fregset): New.
665         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
666
667 2019-02-07  Tom Tromey  <tom@tromey.com>
668
669         * thread.c (thread_cancel_execution_command): Update.
670         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
671         methods.
672         (struct thread_fsm_ops): Remove.
673         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
674         (thread_fsm_should_stop, thread_fsm_return_value)
675         (thread_fsm_set_finished, thread_fsm_finished_p)
676         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
677         Don't declare.
678         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
679         * infrun.c (clear_proceed_status_thread)
680         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
681         (print_stop_event): Update.
682         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
683         Add constructor.
684         (step_command_fsm_ops): Remove.
685         (new_step_command_fsm): Remove.
686         (step_1): Update.
687         (step_command_fsm::should_stop): Rename from
688         step_command_fsm_should_stop.
689         (step_command_fsm::clean_up): Rename from
690         step_command_fsm_clean_up.
691         (step_command_fsm::do_async_reply_reason): Rename from
692         step_command_fsm_async_reply_reason.
693         (struct until_next_fsm): Inherit from thread_fsm.  Add
694         constructor.
695         (until_next_fsm_ops): Remove.
696         (new_until_next_fsm): Remove.
697         (until_next_fsm::should_stop): Rename from
698         until_next_fsm_should_stop.
699         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
700         (until_next_fsm::do_async_reply_reason): Rename from
701         until_next_fsm_async_reply_reason.
702         (struct finish_command_fsm): Inherit from thread_fsm.  Add
703         constructor.  Change type of breakpoint.
704         (finish_command_fsm_ops): Remove.
705         (new_finish_command_fsm): Remove.
706         (finish_command_fsm::should_stop): Rename from
707         finish_command_fsm_should_stop.
708         (finish_command_fsm::clean_up): Rename from
709         finish_command_fsm_clean_up.
710         (finish_command_fsm::return_value): Rename from
711         finish_command_fsm_return_value.
712         (finish_command_fsm::do_async_reply_reason): Rename from
713         finish_command_fsm_async_reply_reason.
714         (finish_command): Update.
715         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
716         Add constructor.
717         (call_thread_fsm_ops): Remove.
718         (call_thread_fsm::call_thread_fsm): Rename from
719         new_call_thread_fsm.
720         (call_thread_fsm::should_stop): Rename from
721         call_thread_fsm_should_stop.
722         (call_thread_fsm::should_notify_stop): Rename from
723         call_thread_fsm_should_notify_stop.
724         (run_inferior_call, call_function_by_hand_dummy): Update.
725         * cli/cli-interp.c (should_print_stop_to_console): Update.
726         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
727         Add constructor.  Change type of location_breakpoint,
728         caller_breakpoint.
729         (until_break_fsm_ops): Remove.
730         (new_until_break_fsm): Remove.
731         (until_break_fsm::should_stop): Rename from
732         until_break_fsm_should_stop.
733         (until_break_fsm::clean_up): Rename from
734         until_break_fsm_clean_up.
735         (until_break_fsm::do_async_reply_reason): Rename from
736         until_break_fsm_async_reply_reason.
737         (until_break_command): Update.
738         * thread-fsm.c: Remove.
739         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
740
741 2019-02-07  Tom Tromey  <tom@tromey.com>
742
743         * yy-remap.h: Add include guard.
744         * xtensa-tdep.h: Add include guard.
745         * xcoffread.h: Rename include guard.
746         * varobj-iter.h: Add include guard.
747         * tui/tui.h: Rename include guard.
748         * tui/tui-winsource.h: Rename include guard.
749         * tui/tui-wingeneral.h: Rename include guard.
750         * tui/tui-windata.h: Rename include guard.
751         * tui/tui-win.h: Rename include guard.
752         * tui/tui-stack.h: Rename include guard.
753         * tui/tui-source.h: Rename include guard.
754         * tui/tui-regs.h: Rename include guard.
755         * tui/tui-out.h: Rename include guard.
756         * tui/tui-layout.h: Rename include guard.
757         * tui/tui-io.h: Rename include guard.
758         * tui/tui-hooks.h: Rename include guard.
759         * tui/tui-file.h: Rename include guard.
760         * tui/tui-disasm.h: Rename include guard.
761         * tui/tui-data.h: Rename include guard.
762         * tui/tui-command.h: Rename include guard.
763         * tic6x-tdep.h: Add include guard.
764         * target/waitstatus.h: Rename include guard.
765         * target/wait.h: Rename include guard.
766         * target/target.h: Rename include guard.
767         * target/resume.h: Rename include guard.
768         * target-float.h: Rename include guard.
769         * stabsread.h: Add include guard.
770         * rs6000-tdep.h: Add include guard.
771         * riscv-fbsd-tdep.h: Add include guard.
772         * regformats/regdef.h: Rename include guard.
773         * record.h: Rename include guard.
774         * python/python.h: Rename include guard.
775         * python/python-internal.h: Rename include guard.
776         * python/py-stopevent.h: Rename include guard.
777         * python/py-ref.h: Rename include guard.
778         * python/py-record.h: Rename include guard.
779         * python/py-record-full.h: Rename include guard.
780         * python/py-record-btrace.h: Rename include guard.
781         * python/py-instruction.h: Rename include guard.
782         * python/py-events.h: Rename include guard.
783         * python/py-event.h: Rename include guard.
784         * procfs.h: Add include guard.
785         * proc-utils.h: Add include guard.
786         * p-lang.h: Add include guard.
787         * or1k-tdep.h: Rename include guard.
788         * observable.h: Rename include guard.
789         * nto-tdep.h: Rename include guard.
790         * nat/x86-linux.h: Rename include guard.
791         * nat/x86-linux-dregs.h: Rename include guard.
792         * nat/x86-gcc-cpuid.h: Add include guard.
793         * nat/x86-dregs.h: Rename include guard.
794         * nat/x86-cpuid.h: Rename include guard.
795         * nat/ppc-linux.h: Rename include guard.
796         * nat/mips-linux-watch.h: Rename include guard.
797         * nat/linux-waitpid.h: Rename include guard.
798         * nat/linux-ptrace.h: Rename include guard.
799         * nat/linux-procfs.h: Rename include guard.
800         * nat/linux-osdata.h: Rename include guard.
801         * nat/linux-nat.h: Rename include guard.
802         * nat/linux-namespaces.h: Rename include guard.
803         * nat/linux-btrace.h: Rename include guard.
804         * nat/glibc_thread_db.h: Rename include guard.
805         * nat/gdb_thread_db.h: Rename include guard.
806         * nat/gdb_ptrace.h: Rename include guard.
807         * nat/fork-inferior.h: Rename include guard.
808         * nat/amd64-linux-siginfo.h: Rename include guard.
809         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
810         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
811         * nat/aarch64-linux.h: Rename include guard.
812         * nat/aarch64-linux-hw-point.h: Rename include guard.
813         * mn10300-tdep.h: Add include guard.
814         * mips-linux-tdep.h: Add include guard.
815         * mi/mi-parse.h: Rename include guard.
816         * mi/mi-out.h: Rename include guard.
817         * mi/mi-main.h: Rename include guard.
818         * mi/mi-interp.h: Rename include guard.
819         * mi/mi-getopt.h: Rename include guard.
820         * mi/mi-console.h: Rename include guard.
821         * mi/mi-common.h: Rename include guard.
822         * mi/mi-cmds.h: Rename include guard.
823         * mi/mi-cmd-break.h: Rename include guard.
824         * m2-lang.h: Add include guard.
825         * location.h: Rename include guard.
826         * linux-record.h: Rename include guard.
827         * linux-nat.h: Add include guard.
828         * linux-fork.h: Add include guard.
829         * i386-darwin-tdep.h: Rename include guard.
830         * hppa-linux-offsets.h: Add include guard.
831         * guile/guile.h: Rename include guard.
832         * guile/guile-internal.h: Rename include guard.
833         * gnu-nat.h: Rename include guard.
834         * gdb-stabs.h: Rename include guard.
835         * frv-tdep.h: Add include guard.
836         * f-lang.h: Add include guard.
837         * event-loop.h: Add include guard.
838         * darwin-nat.h: Rename include guard.
839         * cp-abi.h: Rename include guard.
840         * config/sparc/nm-sol2.h: Rename include guard.
841         * config/nm-nto.h: Rename include guard.
842         * config/nm-linux.h: Add include guard.
843         * config/i386/nm-i386gnu.h: Rename include guard.
844         * config/djgpp/nl_types.h: Rename include guard.
845         * config/djgpp/langinfo.h: Rename include guard.
846         * compile/gcc-cp-plugin.h: Add include guard.
847         * compile/gcc-c-plugin.h: Add include guard.
848         * compile/compile.h: Rename include guard.
849         * compile/compile-object-run.h: Rename include guard.
850         * compile/compile-object-load.h: Rename include guard.
851         * compile/compile-internal.h: Rename include guard.
852         * compile/compile-cplus.h: Rename include guard.
853         * compile/compile-c.h: Rename include guard.
854         * common/xml-utils.h: Rename include guard.
855         * common/x86-xstate.h: Rename include guard.
856         * common/version.h: Rename include guard.
857         * common/vec.h: Rename include guard.
858         * common/tdesc.h: Rename include guard.
859         * common/selftest.h: Rename include guard.
860         * common/scoped_restore.h: Rename include guard.
861         * common/scoped_mmap.h: Rename include guard.
862         * common/scoped_fd.h: Rename include guard.
863         * common/safe-iterator.h: Rename include guard.
864         * common/run-time-clock.h: Rename include guard.
865         * common/refcounted-object.h: Rename include guard.
866         * common/queue.h: Rename include guard.
867         * common/ptid.h: Rename include guard.
868         * common/print-utils.h: Rename include guard.
869         * common/preprocessor.h: Rename include guard.
870         * common/pathstuff.h: Rename include guard.
871         * common/observable.h: Rename include guard.
872         * common/netstuff.h: Rename include guard.
873         * common/job-control.h: Rename include guard.
874         * common/host-defs.h: Rename include guard.
875         * common/gdb_wait.h: Rename include guard.
876         * common/gdb_vecs.h: Rename include guard.
877         * common/gdb_unlinker.h: Rename include guard.
878         * common/gdb_unique_ptr.h: Rename include guard.
879         * common/gdb_tilde_expand.h: Rename include guard.
880         * common/gdb_sys_time.h: Rename include guard.
881         * common/gdb_string_view.h: Rename include guard.
882         * common/gdb_splay_tree.h: Rename include guard.
883         * common/gdb_setjmp.h: Rename include guard.
884         * common/gdb_ref_ptr.h: Rename include guard.
885         * common/gdb_optional.h: Rename include guard.
886         * common/gdb_locale.h: Rename include guard.
887         * common/gdb_assert.h: Rename include guard.
888         * common/filtered-iterator.h: Rename include guard.
889         * common/filestuff.h: Rename include guard.
890         * common/fileio.h: Rename include guard.
891         * common/environ.h: Rename include guard.
892         * common/common-utils.h: Rename include guard.
893         * common/common-types.h: Rename include guard.
894         * common/common-regcache.h: Rename include guard.
895         * common/common-inferior.h: Rename include guard.
896         * common/common-gdbthread.h: Rename include guard.
897         * common/common-exceptions.h: Rename include guard.
898         * common/common-defs.h: Rename include guard.
899         * common/common-debug.h: Rename include guard.
900         * common/cleanups.h: Rename include guard.
901         * common/buffer.h: Rename include guard.
902         * common/btrace-common.h: Rename include guard.
903         * common/break-common.h: Rename include guard.
904         * cli/cli-utils.h: Rename include guard.
905         * cli/cli-style.h: Rename include guard.
906         * cli/cli-setshow.h: Rename include guard.
907         * cli/cli-script.h: Rename include guard.
908         * cli/cli-interp.h: Rename include guard.
909         * cli/cli-decode.h: Rename include guard.
910         * cli/cli-cmds.h: Rename include guard.
911         * charset-list.h: Add include guard.
912         * buildsym-legacy.h: Rename include guard.
913         * bfin-tdep.h: Add include guard.
914         * ax.h: Rename include guard.
915         * arm-linux-tdep.h: Add include guard.
916         * arm-fbsd-tdep.h: Add include guard.
917         * arch/xtensa.h: Rename include guard.
918         * arch/tic6x.h: Add include guard.
919         * arch/i386.h: Add include guard.
920         * arch/arm.h: Rename include guard.
921         * arch/arm-linux.h: Rename include guard.
922         * arch/arm-get-next-pcs.h: Rename include guard.
923         * arch/amd64.h: Add include guard.
924         * arch/aarch64-insn.h: Rename include guard.
925         * arch-utils.h: Rename include guard.
926         * annotate.h: Add include guard.
927         * amd64-darwin-tdep.h: Rename include guard.
928         * aarch64-linux-tdep.h: Add include guard.
929         * aarch64-fbsd-tdep.h: Add include guard.
930         * aarch32-linux-nat.h: Add include guard.
931
932 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
933
934         * macrotab.c (macro_define_internal): New function that
935         factorizes macro_define_object_internal and macro_define_function
936         code.
937         (macro_define_object_internal): Use macro_define_internal.
938         (macro_define_function): Likewise.
939
940 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
941
942         * macrocmd.c (extract_identifier): Return
943         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
944         callers.
945
946 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
947
948         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
949
950 2019-02-05  Tom Tromey  <tom@tromey.com>
951
952         * target.c (target_stack::unpush): Move assertion earlier.
953
954 2019-01-30  Tom Tromey  <tom@tromey.com>
955
956         PR python/23615:
957         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
958         (gdbpy_parse_and_eval): Likewise.
959         * python/python-internal.h (gdbpy_allow_threads): New class.
960
961 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
962
963         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
964         (aarch64_fbsd_fpregmap): Move earlier.
965         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
966         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
967         instead of individual calls to trad_frame_set_reg_addr.
968         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
969         earlier.
970         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
971         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
972         instead of individual calls to trad_frame_set_reg_addr.
973
974 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
975
976         * CONTRIBUTE: Replace contribution list with wiki link.
977
978 2019-01-25  Tom Tromey  <tom@tromey.com>
979
980         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
981
982 2019-01-25  Tom Tromey  <tom@tromey.com>
983
984         * xtensa-linux-nat.c: Fix common/ includes.
985         * xml-support.h: Fix common/ includes.
986         * xml-support.c: Fix common/ includes.
987         * x86-linux-nat.c: Fix common/ includes.
988         * windows-nat.c: Fix common/ includes.
989         * varobj.h: Fix common/ includes.
990         * varobj.c: Fix common/ includes.
991         * value.c: Fix common/ includes.
992         * valops.c: Fix common/ includes.
993         * utils.c: Fix common/ includes.
994         * unittests/xml-utils-selftests.c: Fix common/ includes.
995         * unittests/utils-selftests.c: Fix common/ includes.
996         * unittests/unpack-selftests.c: Fix common/ includes.
997         * unittests/tracepoint-selftests.c: Fix common/ includes.
998         * unittests/style-selftests.c: Fix common/ includes.
999         * unittests/string_view-selftests.c: Fix common/ includes.
1000         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1001         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1002         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1003         * unittests/rsp-low-selftests.c: Fix common/ includes.
1004         * unittests/parse-connection-spec-selftests.c: Fix common/
1005         includes.
1006         * unittests/optional-selftests.c: Fix common/ includes.
1007         * unittests/offset-type-selftests.c: Fix common/ includes.
1008         * unittests/observable-selftests.c: Fix common/ includes.
1009         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1010         * unittests/memrange-selftests.c: Fix common/ includes.
1011         * unittests/memory-map-selftests.c: Fix common/ includes.
1012         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1013         * unittests/function-view-selftests.c: Fix common/ includes.
1014         * unittests/environ-selftests.c: Fix common/ includes.
1015         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1016         * unittests/common-utils-selftests.c: Fix common/ includes.
1017         * unittests/cli-utils-selftests.c: Fix common/ includes.
1018         * unittests/array-view-selftests.c: Fix common/ includes.
1019         * ui-file.c: Fix common/ includes.
1020         * tui/tui-io.c: Fix common/ includes.
1021         * tracepoint.h: Fix common/ includes.
1022         * tracepoint.c: Fix common/ includes.
1023         * tracefile-tfile.c: Fix common/ includes.
1024         * top.h: Fix common/ includes.
1025         * top.c: Fix common/ includes.
1026         * thread.c: Fix common/ includes.
1027         * target/waitstatus.h: Fix common/ includes.
1028         * target/waitstatus.c: Fix common/ includes.
1029         * target.h: Fix common/ includes.
1030         * target.c: Fix common/ includes.
1031         * target-memory.c: Fix common/ includes.
1032         * target-descriptions.c: Fix common/ includes.
1033         * symtab.h: Fix common/ includes.
1034         * symfile.c: Fix common/ includes.
1035         * stap-probe.c: Fix common/ includes.
1036         * spu-linux-nat.c: Fix common/ includes.
1037         * sparc-nat.c: Fix common/ includes.
1038         * source.c: Fix common/ includes.
1039         * solib.c: Fix common/ includes.
1040         * solib-target.c: Fix common/ includes.
1041         * ser-unix.c: Fix common/ includes.
1042         * ser-tcp.c: Fix common/ includes.
1043         * ser-pipe.c: Fix common/ includes.
1044         * ser-base.c: Fix common/ includes.
1045         * selftest-arch.c: Fix common/ includes.
1046         * s12z-tdep.c: Fix common/ includes.
1047         * rust-exp.y: Fix common/ includes.
1048         * rs6000-aix-tdep.c: Fix common/ includes.
1049         * riscv-tdep.c: Fix common/ includes.
1050         * remote.c: Fix common/ includes.
1051         * remote-notif.h: Fix common/ includes.
1052         * remote-fileio.h: Fix common/ includes.
1053         * remote-fileio.c: Fix common/ includes.
1054         * regcache.h: Fix common/ includes.
1055         * regcache.c: Fix common/ includes.
1056         * record-btrace.c: Fix common/ includes.
1057         * python/python.c: Fix common/ includes.
1058         * python/py-type.c: Fix common/ includes.
1059         * python/py-inferior.c: Fix common/ includes.
1060         * progspace.h: Fix common/ includes.
1061         * producer.c: Fix common/ includes.
1062         * procfs.c: Fix common/ includes.
1063         * proc-api.c: Fix common/ includes.
1064         * printcmd.c: Fix common/ includes.
1065         * ppc-linux-nat.c: Fix common/ includes.
1066         * parser-defs.h: Fix common/ includes.
1067         * osdata.c: Fix common/ includes.
1068         * obsd-nat.c: Fix common/ includes.
1069         * nat/x86-linux.c: Fix common/ includes.
1070         * nat/x86-linux-dregs.c: Fix common/ includes.
1071         * nat/x86-dregs.h: Fix common/ includes.
1072         * nat/x86-dregs.c: Fix common/ includes.
1073         * nat/ppc-linux.c: Fix common/ includes.
1074         * nat/mips-linux-watch.h: Fix common/ includes.
1075         * nat/mips-linux-watch.c: Fix common/ includes.
1076         * nat/linux-waitpid.c: Fix common/ includes.
1077         * nat/linux-ptrace.h: Fix common/ includes.
1078         * nat/linux-ptrace.c: Fix common/ includes.
1079         * nat/linux-procfs.c: Fix common/ includes.
1080         * nat/linux-personality.c: Fix common/ includes.
1081         * nat/linux-osdata.c: Fix common/ includes.
1082         * nat/linux-namespaces.c: Fix common/ includes.
1083         * nat/linux-btrace.h: Fix common/ includes.
1084         * nat/linux-btrace.c: Fix common/ includes.
1085         * nat/fork-inferior.c: Fix common/ includes.
1086         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1087         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1088         * nat/aarch64-linux.c: Fix common/ includes.
1089         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1090         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1091         * namespace.h: Fix common/ includes.
1092         * mips-linux-tdep.c: Fix common/ includes.
1093         * minsyms.c: Fix common/ includes.
1094         * mi/mi-parse.h: Fix common/ includes.
1095         * mi/mi-main.c: Fix common/ includes.
1096         * mi/mi-cmd-env.c: Fix common/ includes.
1097         * memrange.h: Fix common/ includes.
1098         * memattr.c: Fix common/ includes.
1099         * maint.h: Fix common/ includes.
1100         * maint.c: Fix common/ includes.
1101         * main.c: Fix common/ includes.
1102         * machoread.c: Fix common/ includes.
1103         * location.c: Fix common/ includes.
1104         * linux-thread-db.c: Fix common/ includes.
1105         * linux-nat.c: Fix common/ includes.
1106         * linux-fork.c: Fix common/ includes.
1107         * inline-frame.c: Fix common/ includes.
1108         * infrun.c: Fix common/ includes.
1109         * inflow.c: Fix common/ includes.
1110         * inferior.h: Fix common/ includes.
1111         * inferior.c: Fix common/ includes.
1112         * infcmd.c: Fix common/ includes.
1113         * inf-ptrace.c: Fix common/ includes.
1114         * inf-child.c: Fix common/ includes.
1115         * ia64-linux-nat.c: Fix common/ includes.
1116         * i387-tdep.c: Fix common/ includes.
1117         * i386-tdep.c: Fix common/ includes.
1118         * i386-linux-tdep.c: Fix common/ includes.
1119         * i386-linux-nat.c: Fix common/ includes.
1120         * i386-go32-tdep.c: Fix common/ includes.
1121         * i386-fbsd-tdep.c: Fix common/ includes.
1122         * i386-fbsd-nat.c: Fix common/ includes.
1123         * guile/scm-type.c: Fix common/ includes.
1124         * guile/guile.c: Fix common/ includes.
1125         * go32-nat.c: Fix common/ includes.
1126         * gnu-nat.c: Fix common/ includes.
1127         * gdbthread.h: Fix common/ includes.
1128         * gdbarch-selftests.c: Fix common/ includes.
1129         * gdb_usleep.c: Fix common/ includes.
1130         * gdb_select.h: Fix common/ includes.
1131         * gdb_bfd.c: Fix common/ includes.
1132         * gcore.c: Fix common/ includes.
1133         * fork-child.c: Fix common/ includes.
1134         * findvar.c: Fix common/ includes.
1135         * fbsd-nat.c: Fix common/ includes.
1136         * event-top.c: Fix common/ includes.
1137         * event-loop.c: Fix common/ includes.
1138         * dwarf2read.c: Fix common/ includes.
1139         * dwarf2loc.c: Fix common/ includes.
1140         * dwarf2-frame.c: Fix common/ includes.
1141         * dwarf-index-cache.c: Fix common/ includes.
1142         * dtrace-probe.c: Fix common/ includes.
1143         * disasm-selftests.c: Fix common/ includes.
1144         * defs.h: Fix common/ includes.
1145         * csky-tdep.c: Fix common/ includes.
1146         * cp-valprint.c: Fix common/ includes.
1147         * cp-support.h: Fix common/ includes.
1148         * cp-support.c: Fix common/ includes.
1149         * corelow.c: Fix common/ includes.
1150         * completer.h: Fix common/ includes.
1151         * completer.c: Fix common/ includes.
1152         * compile/compile.c: Fix common/ includes.
1153         * compile/compile-loc2c.c: Fix common/ includes.
1154         * compile/compile-cplus-types.c: Fix common/ includes.
1155         * compile/compile-cplus-symbols.c: Fix common/ includes.
1156         * command.h: Fix common/ includes.
1157         * cli/cli-dump.c: Fix common/ includes.
1158         * cli/cli-cmds.c: Fix common/ includes.
1159         * charset.c: Fix common/ includes.
1160         * build-id.c: Fix common/ includes.
1161         * btrace.h: Fix common/ includes.
1162         * btrace.c: Fix common/ includes.
1163         * breakpoint.h: Fix common/ includes.
1164         * breakpoint.c: Fix common/ includes.
1165         * ax.h: 
1166         (enum agent_op): Fix common/ includes.
1167         * ax-general.c (struct aop_map): Fix common/ includes.
1168         * ax-gdb.c: Fix common/ includes.
1169         * auxv.c: Fix common/ includes.
1170         * auto-load.c: Fix common/ includes.
1171         * arm-tdep.c: Fix common/ includes.
1172         * arch/riscv.c: Fix common/ includes.
1173         * arch/ppc-linux-common.c: Fix common/ includes.
1174         * arch/i386.c: Fix common/ includes.
1175         * arch/arm.c: Fix common/ includes.
1176         * arch/arm-linux.c: Fix common/ includes.
1177         * arch/arm-get-next-pcs.c: Fix common/ includes.
1178         * arch/amd64.c: Fix common/ includes.
1179         * arch/aarch64.c: Fix common/ includes.
1180         * arch/aarch64-insn.c: Fix common/ includes.
1181         * arch-utils.c: Fix common/ includes.
1182         * amd64-windows-tdep.c: Fix common/ includes.
1183         * amd64-tdep.c: Fix common/ includes.
1184         * amd64-sol2-tdep.c: Fix common/ includes.
1185         * amd64-obsd-tdep.c: Fix common/ includes.
1186         * amd64-nbsd-tdep.c: Fix common/ includes.
1187         * amd64-linux-tdep.c: Fix common/ includes.
1188         * amd64-linux-nat.c: Fix common/ includes.
1189         * amd64-fbsd-tdep.c: Fix common/ includes.
1190         * amd64-fbsd-nat.c: Fix common/ includes.
1191         * amd64-dicos-tdep.c: Fix common/ includes.
1192         * amd64-darwin-tdep.c: Fix common/ includes.
1193         * agent.c: Fix common/ includes.
1194         * ada-lang.h: Fix common/ includes.
1195         * ada-lang.c: Fix common/ includes.
1196         * aarch64-tdep.c: Fix common/ includes.
1197
1198 2019-01-25  Tom Tromey  <tom@tromey.com>
1199
1200         * common/create-version.sh: Use common/version.h.
1201
1202 2019-01-24  Pedro Alves  <palves@redhat.com>
1203
1204         * infrun.c (signal_stop, signal_print, signal_program)
1205         (signal_catch, signal_pass): Now arrays instead of pointers.
1206         (update_signals_program_target, do_target_resume)
1207         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1208         * linux-nat.c (linux_nat_target::pass_signals)
1209         (linux_nat_target::create_inferior, linux_nat_target::attach):
1210         Adjust.
1211         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1212         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1213         * procfs.c (procfs_target::pass_signals): Adjust.
1214         * record-full.c (record_full_target::resume): Adjust.
1215         * remote.c (remote_target::pass_signals)
1216         (remote_target::program_signals): Adjust.
1217         * target-debug.h (target_debug_print_signals): Now takes a
1218         gdb::array_view as parameter.  Adjust.
1219         * target.h (target_ops) <pass_signals, program_signals>: Replace
1220         pointer and length parameters with gdb::array_view.
1221         (target_pass_signals, target_program_signals): Likewise.
1222         * target-delegates.c: Regenerate.
1223
1224 2019-01-24  Pedro Alves  <palves@redhat.com>
1225
1226         * common/forward-scope-exit.h
1227         (forward_scope_exit::forward_scope_exit): Pass arguments to
1228         m_bind_function directly, instead of creating a std::bind and
1229         copying that.
1230
1231 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1232
1233         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1234         for static members.
1235         (pass_in_v_vfp_candidate): Likewise.
1236
1237 2019-01-23  Tom Tromey  <tom@tromey.com>
1238             Pedro Alves  <palves@redhat.com>
1239
1240         * regcache.c (class regcache_invalidator): Remove.
1241         (regcache::raw_write): Use make_scope_exit.
1242
1243 2019-01-23  Tom Tromey  <tom@tromey.com>
1244
1245         * ui-out.h (class ui_out_emit_type): Update comment.
1246
1247 2019-01-23  Tom Tromey  <tom@tromey.com>
1248
1249         * infrun.c (fetch_inferior_event): Update comment.
1250
1251 2019-01-23  Tom Tromey  <tom@tromey.com>
1252             Pedro Alves  <palves@redhat.com>
1253
1254         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1255         parameter.
1256         (fetch_inferior_event): Use SCOPE_EXIT.
1257
1258
1259 2019-01-23  Tom Tromey  <tom@tromey.com>
1260             Pedro Alves  <palves@redhat.com>
1261
1262         * infrun.c (disable_thread_events): Delete.
1263         (stop_all_threads): Use SCOPE_EXIT.
1264
1265 2019-01-23  Tom Tromey  <tom@tromey.com>
1266             Pedro Alves  <palves@redhat.com>
1267
1268         * symfile.c: Include forward-scope-exit.h.
1269         (clear_symtab_users_cleanup): Replace forward declaration with
1270         a FORWARD_SCOPE_EXIT.
1271         (syms_from_objfile_1): Use the forward_scope_exit and
1272         gdb::optional instead of cleanup_function.
1273         (reread_symbols): Use the forward_scope_exit instead of
1274         cleanup_function.
1275         (clear_symtab_users_cleanup): Remove function.
1276
1277 2019-01-23  Tom Tromey  <tom@tromey.com>
1278             Pedro Alves  <palves@redhat.com>
1279
1280         * linux-nat.c: Include scope-exit.h.
1281         (cleanup_target_stop): Remove.
1282         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1283         SCOPE_EXIT.
1284
1285 2019-01-23  Tom Tromey  <tom@tromey.com>
1286             Pedro Alves  <palves@redhat.com>
1287
1288         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1289         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1290
1291 2019-01-23  Tom Tromey  <tom@tromey.com>
1292             Andrew Burgess  <andrew.burgess@embecosm.com>
1293             Pedro Alves  <palves@redhat.com>
1294
1295         * infrun.c (fetch_inferior_event): Use scope_exit.
1296         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1297         * top.c (execute_command): Use scope_exit.
1298         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1299         * utils.c (do_bpstat_clear_actions_cleanup)
1300         (make_bpstat_clear_actions_cleanup): Remove.
1301
1302 2019-01-23  Tom Tromey  <tom@tromey.com>
1303             Pedro Alves  <palves@redhat.com>
1304
1305         * infrun.c: Include "common/scope-exit.h"
1306         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1307         (wait_for_inferior): Use SCOPE_EXIT.
1308         (fetch_inferior_event): Use scope_exit.
1309
1310 2019-01-23  Tom Tromey  <tom@tromey.com>
1311             Pedro Alves  <palves@redhat.com>
1312
1313         * breakpoint.c (create_breakpoint): Remove cleanup.
1314
1315 2019-01-23  Tom Tromey  <tom@tromey.com>
1316             Andrew Burgess  <andrew.burgess@embecosm.com>
1317             Pedro Alves  <palves@redhat.com>
1318
1319 2019-01-23  Pedro Alves  <palves@redhat.com>
1320
1321         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1322
1323 2019-01-23  Pedro Alves  <palves@redhat.com>
1324             Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * gdbthread.h: Include "common/forward-scope-exit.h".
1327         (scoped_finish_thread_state): Redefine custom class in terms of
1328         forward_scope_exit.
1329
1330 2019-01-23  Pedro Alves  <palves@redhat.com>
1331             Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * common/forward-scope-exit.h: New file.
1334
1335 2019-01-23  Pedro Alves  <palves@redhat.com>
1336             Andrew Burgess  <andrew.burgess@embecosm.com>
1337             Tom Tromey  <tom@tromey.com>
1338
1339         * common/scope-exit.h: New file.
1340
1341 2019-01-23  Pedro Alves  <palves@redhat.com>
1342
1343         * common/preprocessor.h (ESC): Rename to ...
1344         (ESC_PARENS): ... this.
1345         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1346         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1347
1348 2019-01-23  Tom Tromey  <tom@tromey.com>
1349
1350         * language.h (class scoped_switch_to_sym_language_if_auto):
1351         Initialize m_lang in both cases.
1352
1353 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1354
1355         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1356         with XCNEW.
1357
1358 2019-01-22  Tom Tromey  <tom@tromey.com>
1359
1360         * corelow.c: Do not include sys/file.h.
1361
1362 2019-01-22  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-wingeneral.h: Include gdb_curses.h.
1365
1366 2019-01-22  Tom Tromey  <tom@tromey.com>
1367
1368         * source-cache.h (class source_cache) <get_source_lines,
1369         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1370
1371 2019-01-22  Tom Tromey  <tom@tromey.com>
1372
1373         * remote-fileio.h (struct remote_target): Declare.
1374
1375 2019-01-22  Tom Tromey  <tom@tromey.com>
1376
1377         * python/py-arch.c: Do not include py-ref.h.
1378         * python/py-bpevent.c: Do not include py-ref.h.
1379         * python/py-cmd.c: Do not include py-ref.h.
1380         * python/py-continueevent.c: Do not include py-ref.h.
1381         * python/py-event.h: Do not include py-ref.h.
1382         * python/py-evtregistry.c: Do not include py-ref.h.
1383         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1384         * python/py-frame.c: Do not include py-ref.h.
1385         * python/py-framefilter.c: Do not include py-ref.h.
1386         * python/py-function.c: Do not include py-ref.h.
1387         * python/py-infevents.c: Do not include py-ref.h.
1388         * python/py-linetable.c: Do not include py-ref.h.
1389         * python/py-objfile.c: Do not include py-ref.h.
1390         * python/py-param.c: Do not include py-ref.h.
1391         * python/py-prettyprint.c: Do not include py-ref.h.
1392         * python/py-progspace.c: Do not include py-ref.h.
1393         * python/py-symbol.c: Do not include py-ref.h.
1394         * python/py-symtab.c: Do not include py-ref.h.
1395         * python/py-type.c: Do not include py-ref.h.
1396         * python/py-unwind.c: Do not include py-ref.h.
1397         * python/py-utils.c: Do not include py-ref.h.
1398         * python/py-value.c: Do not include py-ref.h.
1399         * python/py-varobj.c: Do not include py-ref.h.
1400         * python/py-xmethods.c: Do not include py-ref.h.
1401         * python/python.c: Do not include py-ref.h.
1402         * varobj.c: Do not include py-ref.h.
1403
1404 2019-01-22  Tom Tromey  <tom@tromey.com>
1405
1406         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1407         keyword for bcache.
1408
1409 2019-01-22  Tom Tromey  <tom@tromey.com>
1410
1411         * compile/compile-cplus-types.c: Remove a comment by #include.
1412
1413 2019-01-22  Tom Tromey  <tom@tromey.com>
1414
1415         * compile/gcc-c-plugin.h: Include compile-internal.h.
1416
1417 2019-01-22  Tom Tromey  <tom@tromey.com>
1418
1419         * stabsread.c (EXTERN): Do not define.
1420         (symnum, next_symbol_text_func, processing_gcc_compilation)
1421         (within_function, global_sym_chain, global_stabs)
1422         (previous_stab_code, this_object_header_files)
1423         (n_this_object_header_files)
1424         (n_allocated_this_object_header_files): Define.
1425         * stabsread.h (EXTERN): Never define.  Use "extern".
1426
1427 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1428
1429         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1430         history_value.
1431
1432 2019-01-21  Tom Tromey  <tom@tromey.com>
1433
1434         * ui-out.c: Fix includes.
1435         * tui/tui-source.c: Fix includes.
1436         * target.c: Fix includes.
1437         * remote.c: Fix includes.
1438         * regcache.c: Fix includes.
1439         * python/py-block.c: Fix includes.
1440         * printcmd.c: Fix includes.
1441         * or1k-tdep.c: Fix includes.
1442         * mi/mi-main.c: Fix includes.
1443         * m32r-tdep.c: Fix includes.
1444         * csky-tdep.c: Fix includes.
1445         * compile/compile-cplus-types.c: Fix includes.
1446         * cli/cli-interp.c: Fix includes.
1447
1448 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1449
1450         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1451         for padding.
1452
1453 2019-01-16  Tom Tromey  <tom@tromey.com>
1454
1455         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1456         earlier.
1457         (struct objfile) <msymbols_range>: Move from top level.
1458         <msymbols>: New method.
1459         (class objfile_msymbols): Remove.
1460         * symtab.c (default_collect_symbol_completion_matches_break_on):
1461         Update.
1462         * symmisc.c (dump_msymbols): Update.
1463         * stabsread.c (scan_file_globals): Update.
1464         * objc-lang.c (info_selectors_command, info_classes_command)
1465         (find_methods): Update.
1466         * minsyms.c (find_solib_trampoline_target): Update.
1467         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1468         * coffread.c (coff_symfile_read): Update.
1469         * ada-lang.c (ada_lookup_simple_minsym)
1470         (ada_collect_symbol_completion_matches): Update.
1471
1472 2019-01-16  Tom Tromey  <tom@tromey.com>
1473
1474         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1475         type.  Remove no-argument constructor.
1476         <iterator::operator++>: Simplify.
1477         <begin>: Update.
1478         <end>: Use minimal_symbol_count.
1479
1480 2019-01-16  Tom Tromey  <tom@tromey.com>
1481
1482         * objfiles.h (struct objfile) <psymtabs>: New method.
1483         (class objfile_psymtabs): Remove.
1484         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1485         typedef.
1486         <range>: New method.
1487         (require_partial_symbols): Change return type.
1488         * psymtab.c (require_partial_symbols)
1489         (psym_expand_symtabs_matching): Update.
1490         * mdebugread.c (parse_partial_symbols): Update.
1491         * dbxread.c (dbx_end_psymtab): Update.
1492
1493 2019-01-15  Tom Tromey  <tom@tromey.com>
1494
1495         * symtab.c (lookup_objfile_from_block)
1496         (lookup_symbol_in_objfile_symtabs)
1497         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1498         (find_line_symtab, info_sources_command)
1499         (default_collect_symbol_completion_matches_break_on)
1500         (make_source_files_completion_list): Update.
1501         * symmisc.c (print_objfile_statistics, dump_objfile)
1502         (maintenance_print_symbols, maintenance_info_symtabs)
1503         (maintenance_check_symtabs, maintenance_info_line_tables):
1504         Update.
1505         * source.c (select_source_symtab)
1506         (forget_cached_source_info_for_objfile): Update.
1507         * objfiles.h (class objfile_compunits): Remove.
1508         (struct objfile) <compunits_range>: New typedef.
1509         (compunits): New method.
1510         * objfiles.c (objfile_relocate1): Update.
1511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1512         * maint.c (count_symtabs_and_blocks): Update.
1513         * linespec.c (iterate_over_all_matching_symtabs): Update.
1514         * cp-support.c (add_symbol_overload_list_qualified): Update.
1515         * coffread.c (coff_symtab_read): Update.
1516         * ada-lang.c (add_nonlocal_symbols)
1517         (ada_collect_symbol_completion_matches)
1518         (ada_add_global_exceptions): Update.
1519
1520 2019-01-15  Tom Tromey  <tom@tromey.com>
1521
1522         * progspace.h (program_space) <objfiles_safe_range>: New
1523         typedef.
1524         <objfiles_safe>: New method.
1525         * objfiles.h (class all_objfiles_safe): Remove.
1526         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1527         * jit.c (jit_inferior_exit_hook): Update.
1528
1529 2019-01-17  Tom Tromey  <tom@tromey.com>
1530
1531         * progspace.h (program_space) <objfiles_range>: New typedef.
1532         <objfiles>: New method.
1533         <objfiles_head>: Rename from objfiles.
1534         (object_files): Update.
1535         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1536         * guile/scm-pretty-print.c
1537         (ppscm_find_pretty_printer_from_objfiles): Update.
1538         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1539         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1540         Update.
1541         * python/py-progspace.c (pspy_get_objfiles): Update.
1542         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1543         Update.
1544         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1545         (objfpy_lookup_objfile_by_build_id): Update.
1546         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1547         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1548         Update.
1549         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1550         (expand_symtab_containing_pc, lookup_objfile_from_block)
1551         (lookup_static_symbol, basic_lookup_transparent_type)
1552         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1553         (find_line_symtab, info_sources_command)
1554         (default_collect_symbol_completion_matches_break_on)
1555         (make_source_files_completion_list, find_main_name): Update.
1556         * symmisc.c (print_symbol_bcache_statistics)
1557         (print_objfile_statistics, maintenance_print_symbols)
1558         (maintenance_print_msymbols, maintenance_print_objfiles)
1559         (maintenance_info_symtabs, maintenance_check_symtabs)
1560         (maintenance_expand_symtabs, maintenance_info_line_tables):
1561         Update.
1562         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1563         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1564         (map_overlay_command, unmap_overlay_command)
1565         (simple_overlay_update, expand_symtabs_matching)
1566         (map_symbol_filenames): Update.
1567         * symfile-debug.c (set_debug_symfile): Update.
1568         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1569         Update.
1570         * source.c (select_source_symtab, forget_cached_source_info):
1571         Update.
1572         * solib.c (solib_read_symbols): Update.
1573         * solib-spu.c (append_ocl_sos): Update.
1574         * psymtab.c (maintenance_print_psymbols)
1575         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1576         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1577         * printcmd.c (info_symbol_command): Update.
1578         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1579         Update.
1580         * objfiles.h (class all_objfiles): Remove.
1581         * objfiles.c (have_partial_symbols, have_full_symbols)
1582         (have_minimal_symbols, qsort_cmp, update_section_map)
1583         (shared_objfile_contains_address_p)
1584         (default_iterate_over_objfiles_in_search_order): Update.
1585         * objc-lang.c (info_selectors_command, info_classes_command)
1586         (find_methods): Update.
1587         * minsyms.c (find_solib_trampoline_target): Update.
1588         * maint.c (maintenance_info_sections)
1589         (maintenance_translate_address, count_symtabs_and_blocks):
1590         Update.
1591         * main.c (captured_main_1): Update.
1592         * linux-thread-db.c (try_thread_db_load_from_pdir)
1593         (has_libpthread): Update.
1594         * linespec.c (iterate_over_all_matching_symtabs)
1595         (search_minsyms_for_name): Update.
1596         * jit.c (jit_find_objf_with_entry_addr): Update.
1597         * hppa-tdep.c (find_unwind_entry)
1598         (hppa_lookup_stub_minimal_symbol): Update.
1599         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1600         Update.
1601         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1602         (elf_gnu_ifunc_resolve_by_got): Update.
1603         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1604         * dwarf-index-write.c (save_gdb_index_command): Update.
1605         * cp-support.c (add_symbol_overload_list_qualified): Update.
1606         * breakpoint.c (create_overlay_event_breakpoint)
1607         (create_longjmp_master_breakpoint)
1608         (create_std_terminate_master_breakpoint)
1609         (create_exception_master_breakpoint): Update.
1610         * blockframe.c (find_pc_partial_function): Update.
1611         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1612         (ada_collect_symbol_completion_matches)
1613         (ada_add_global_exceptions): Update.
1614
1615 2019-01-17  Tom Tromey  <tom@tromey.com>
1616
1617         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1618         declare VEC.
1619         (solib_target_parse_libraries): Change return type.
1620         (library_list_start_segment, library_list_start_section)
1621         (library_list_end_library, library_list_start_library); Update.
1622         (solib_target_free_library_list): Remove.
1623         (solib_target_parse_libraries): Remove cleanup.  Change return
1624         type.
1625         (solib_target_current_sos): Update.
1626
1627 2019-01-17  Tom Tromey  <tromey@bapiya>
1628
1629         * valprint.c: Replace "the the" with "the".
1630         * symtab.c: Replace "the the" with "the".
1631         * solib.c: Replace "the the" with "the".
1632         * solib-dsbt.c: Replace "the the" with "the".
1633         * linespec.c: Replace "the the" with "the".
1634         * dwarf2loc.h: Replace "the the" with "the".
1635         * amd64-windows-tdep.c: Replace "the the" with "the".
1636         * aarch64-tdep.c: Replace "the the" with "the".
1637
1638 2019-01-16  Keith Seitz  <keiths@redhat.com>
1639
1640         PR gdb/23773
1641         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1642         <builder>: Rename to ..
1643         <m_builder>: ... this and make private.
1644         (dwarf2_cu::get_builder): New method.  Change all users of
1645         `builder' to use this method.
1646         (dwarf2_start_symtab): Move to ...
1647         (dwarf2_cu::start_symtab): ... here.  Update all callers
1648         (setup_type_unit_groups): Move to ...
1649         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1650         callers.
1651         (dwarf2_cu::reset_builder): New method.
1652         (process_full_compunit, process_full_type_unit): Use
1653         dwarf2_cu::reset_builder.
1654         (follow_die_offset): Record the ancestor CU if it is different
1655         from the followed DIE's CU.
1656         (follow_die_sig_1): Likewise.
1657
1658 2019-01-15  Tom Tromey  <tom@tromey.com>
1659
1660         * remote.c (class remote_state) <buf>: Now a char_vector.
1661         <buf_size>: Remove.
1662         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1663         parameter.
1664         (remote_target::getpkt_or_notif_sane_1)
1665         (remote_target::getpkt_sane)
1666         (remote_target::getpkt_or_notif_sane): Likewise.
1667         (class remote_target) <putpkt>: New overload.
1668         (remote_target::read_frame): Change type of "buf_p".  Remove
1669         sizeof_p parameter.
1670         (packet_ok): New overload.
1671         (packet_check_result): New overload.
1672         Update all uses.
1673
1674 2019-01-14  Tom Tromey  <tom@tromey.com>
1675
1676         * remote-notif.c (handle_notification, remote_notif_ack)
1677         (remote_notif_parse): Make "buf" const.
1678         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1679         const.
1680         (remote_notif_parse, remote_notif_ack, handle_notification):
1681         Likewise.
1682         * remote.c (remote_notif_stop_parse): Make "buf" const.
1683         (remote_target::remote_parse_stop_reply): Make "buf" const.
1684         (remote_notif_stop_ack): Make "buf" const.
1685
1686 2019-01-14  Tom Tromey  <tom@tromey.com>
1687
1688         * remote.c (remote_console_output): Make parameter const.
1689
1690 2019-01-14  Tom Tromey  <tom@tromey.com>
1691
1692         * target-debug.h (target_debug_print_signals): Constify.
1693         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1694         * procfs.c (procfs_target::pass_signals): Update.
1695         * linux-nat.c (linux_nat_target::pass_signals): Update.
1696         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1697         * target-delegates.c: Rebuild.
1698         * remote.c (remote_target::program_signals): Update.
1699         (remote_target::pass_signals): Update.
1700         * target.c (target_pass_signals): Constify argument.
1701         (target_program_signals): Likewise.
1702         * target.h (struct target_ops) <pass_signals, program_signals>:
1703         Constify argument.
1704         (target_pass_signals, target_program_signals): Constify argument.
1705
1706 2019-01-14  Tom Tromey  <tom@tromey.com>
1707
1708         PR tui/28819:
1709         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1710
1711 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1712
1713         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1714         field.
1715         * rs6000-tdep.c: Include reggroups.h.
1716         (IS_V_ALIAS_PSEUDOREG): Define.
1717         (rs6000_register_name): Return names for the "vX" aliases.
1718         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1719         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1720         aliases.  Call default_register_reggroup_p for all other
1721         pseudo-registers.
1722         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1723         New functions.
1724         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1725         Handle "vX" aliases.
1726         (v_alias_pseudo_register_collect): New function.
1727         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1728         (rs6000_gdbarch_init): Initialize "vX" aliases as
1729         pseudo-registers.  Restore registration of
1730         rs6000_pseudo_register_reggroup_p with
1731         set_tdesc_pseudo_register_reggroup_p.
1732
1733 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1734
1735         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1736         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1737         set_gdbarch_num_pseudo_regs.
1738
1739 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1740
1741         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1742         Remove arg prefixname, add do_set and do_show.
1743         Add member functions set_list and show_list.
1744         * cli/cli-style.c (class cli_style_option): Update accordingly.
1745         (style_set_list): Move to file scope.
1746         (style_show_list): Likewise.
1747         (set_style): Call help_list.
1748         (show_style): Call cmd_show_list.
1749         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1750         Update to use the new macro.
1751
1752 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1753
1754         * ada-lang.c (_initialize_ada_language): Expand the help text
1755         for the "catch exception" command.
1756
1757 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1758
1759         * symtab.c (matching_obj_sections): Initialize obj,
1760         declare it closer to its usage.
1761
1762 2019-01-10  Tom Tromey  <tom@tromey.com>
1763
1764         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1765         (basic_inf_threads_range): Remove.
1766         (inf_threads_range, inf_non_exited_threads_range)
1767         (safe_inf_threads_range): Use next_adapter.
1768
1769 2019-01-10  Keith Seitz  <keiths@redhat.com>
1770
1771         PR gdb/23712
1772         PR symtab/23010
1773         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1774         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1775
1776 2019-01-10  Keith Seitz  <keiths@redhat.com>
1777
1778         PR gdb/23712
1779         PR symtab/23010
1780         * dictionary.c (pending_to_vector): Remove.
1781         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1782         Remove _1 suffix, replacing functions of the same name.  Update
1783         all callers.
1784         (dict_create_hashed, dict_create_hashed_expandable)
1785         (dict_create_linear, dict_create_linear_expandable, dict_free)
1786         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1787         Make functions static.
1788
1789 2019-01-10  Keith Seitz  <keiths@redhat.com>
1790
1791         PR gdb/23712
1792         PR symtab/23010
1793         * dictionary.h (struct dictionary): Replace declaration with
1794         multidictionary.
1795         (dict_create_hashed, dict_create_hashed_expandable)
1796         (dict_create_linear, dict_create_linear_expandable)
1797         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1798         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1799         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1800         taking multidictionary argument.
1801         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1802         * block.h (struct block) <dict>: Change to multidictionary
1803         and rename `multidict'.
1804         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1805         symmisc.c: Update all dictionary references to multidictionary.
1806
1807 2019-01-10  Keith Seitz  <keiths@redhat.com>
1808
1809         PR gdb/23712
1810         PR symtab/23010
1811         * dictionary.c: Include unordered_map.
1812         (pending_to_vector): New function.
1813         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1814         Rewrite the non-"_1" functions to take vector instead
1815         of linked list.
1816         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1817         "new" _1 versions of the same name.
1818         (multidictionary): Define.
1819         (std::hash<enum language): New definition.
1820         (collate_pending_symbols_by_language, mdict_create_hashed)
1821         (mdict_create_hashed_expandable, mdict_create_linear)
1822         (mdict_create_linear_expandable, mdict_free)
1823         (find_language_dictionary, create_new_language_dictionary)
1824         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1825         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1826         (mdict_size, mdict_empty): New functions.
1827         * dictionary.h (mdict_iterator): Define.
1828
1829 2019-01-10  Pedro Alves  <palves@redhat.com>
1830
1831         * breakpoint.c (read_uploaded_action)
1832         (create_tracepoint_from_upload): Adjust to use
1833         gdb::unique_xmalloc_ptr.
1834         * ctf.c (ctf_write_uploaded_tp):
1835         (SET_ARRAY_FIELD): Use emplace_back.
1836         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1837         * tracefile-tfile.c (tfile_write_uploaded_tp):
1838         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1839         gdb::unique_xmalloc_ptr.
1840         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1841         at_string, cond_string, cmd_strings>: Replace char pointers
1842         with gdb::unique_xmalloc_ptr.
1843
1844 2019-01-10  Pedro Alves  <palves@redhat.com>
1845
1846         * solib-target.c (library_list_start_library): Don't xstrdup name.
1847
1848 2019-01-10  Pedro Alves  <palves@redhat.com>
1849
1850         * mdebugread.c (parse_partial_symbols): Use
1851         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1852
1853 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * linux-fork.c (scoped_switch_fork_info)
1856         <~scoped_switch_fork_info>: Fix incorrect variable name.
1857
1858 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1859
1860         * linux-fork.c (scoped_switch_fork_info)
1861         <scoped_switch_fork_info>: Make explicit.
1862         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1863
1864 2019-01-10  Tom Tromey  <tom@tromey.com>
1865
1866         * objfiles.h (objfile::reset_psymtabs): Update.
1867         * objfiles.c (objfile::objfile): Update.
1868         * psymtab.h (psymtab_storage::obstack): Update.
1869         (psymtab_storage::m_obstack): Use gdb::optional.
1870         (class psymtab_storage): Update comment.  Remove objfile
1871         parameter.
1872         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1873
1874 2019-01-10  Tom Tromey  <tom@tromey.com>
1875
1876         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1877         <free_psymtabs>: Now private.
1878         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1879         (allocate_psymtab): Use new method.
1880
1881 2019-01-10  Tom Tromey  <tom@tromey.com>
1882
1883         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1884         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1885         * mdebugread.c (parse_partial_symbols): Use
1886         allocate_dependencies.
1887         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1888         allocate_dependencies.
1889         (process_psymtab_comp_unit_reader)
1890         (build_type_psymtab_dependencies): Likewise.
1891         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1892
1893 2019-01-10  Tom Tromey  <tom@tromey.com>
1894
1895         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1896         PSYMBOL_SET_LANGUAGE.
1897         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1898
1899 2019-01-10  Tom Tromey  <tom@tromey.com>
1900
1901         * psymtab.h (psymtab_storage::obstack): New method.
1902         <m_obstack>: Rename from obstack; now private.
1903         * psymtab.c (psymtab_storage): Update.
1904         * dwarf2read.c (create_addrmap_from_index)
1905         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1906         Update.
1907
1908 2019-01-10  Tom Tromey  <tom@tromey.com>
1909
1910         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1911         * objfiles.h (objfile::reset_psymtabs): New method.
1912
1913 2019-01-10  Tom Tromey  <tom@tromey.com>
1914
1915         * symmisc.c (print_symbol_bcache_statistics): Update.
1916         (print_objfile_statistics): Update.
1917         * symfile.c (reread_symbols): Update.
1918         * psymtab.h (class psymtab_storage): New.
1919         * psymtab.c (psymtab_storage): New constructor.
1920         (~psymtab_storage): New destructor.
1921         (require_partial_symbols): Update.
1922         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1923         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1924         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1925         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1926         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1927         (start_psymtab_common, end_psymtab_common)
1928         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1929         (allocate_psymtab): Update.
1930         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1931         Update.
1932         (dump_psymtab_addrmap, maintenance_print_psymbols)
1933         (maintenance_check_psymtabs): Update.
1934         (class objfile_psymtabs): Move to objfiles.h.
1935         * psympriv.h (discard_psymtab): Now inline.
1936         (psymtab_discarder::psymtab_discarder): Update.
1937         (psymtab_discarder::~psymtab_discarder): Update.
1938         (ALL_OBJFILE_PSYMTABS): Rewrite.
1939         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1940         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1941         Remove fields.
1942         <partial_symtabs>: New field.
1943         (class objfile_psymtabs): Move from psymtab.h.  Update.
1944         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1945         psymbol_cache.
1946         (objfile::~objfile): Don't destroy psymbol_cache.
1947         * mdebugread.c (parse_partial_symbols): Update.
1948         * dwarf2read.c (create_addrmap_from_index)
1949         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1950         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1951         (add_partial_subprogram, dwarf2_ranges_read): Update.
1952         * dwarf-index-write.c (write_address_map)
1953         (write_one_signatured_type, recursively_write_psymbols)
1954         (class debug_names, class debug_names, write_psymtabs_to_index):
1955         Update.
1956
1957 2019-01-10  Tom Tromey  <tom@tromey.com>
1958
1959         * symtab.h (SYMBOL_SET_NAMES): Update.
1960         (symbol_set_names): Update.
1961         (MSYMBOL_SET_NAMES): Update.
1962         * symtab.c (symbol_set_names): Change argument to be an
1963         objfile_per_bfd_storage.
1964         * psymtab.c (add_psymbol_to_bcache): Update.
1965         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1966
1967 2019-01-10  Tom Tromey  <tom@tromey.com>
1968
1969         * symtab.c (create_demangled_names_hash): Change argument to be an
1970         objfile_per_bfd_storage.
1971         (symbol_set_names): Update.
1972
1973 2019-01-10  Tom Tromey  <tom@tromey.com>
1974
1975         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1976         init_psymbol_list.
1977         * psymtab.c (init_psymbol_list): Do nothing if already called.
1978         * psympriv.h (init_psymbol_list): Add comment.
1979         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1980         init_psymbol_list.
1981         * dbxread.c (dbx_symfile_read): Unconditionally call
1982         init_psymbol_list.
1983
1984 2019-01-10  Tom Tromey  <tom@tromey.com>
1985
1986         * xcoffread.c (scan_xcoff_symtab): Update.
1987         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1988         "where".
1989         * mdebugread.c (parse_partial_symbols)
1990         (handle_psymbol_enumerators): Update.
1991         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1992         * dbxread.c (read_dbx_symtab): Update.
1993         * psympriv.h (psymbol_placement): New enum.
1994         (add_psymbol_to_list): Update.
1995
1996 2019-01-10  Tom Tromey  <tom@tromey.com>
1997
1998         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1999         static_psymbols parameters.
2000         (scan_xcoff_symtab): Update.
2001         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2002         static_psymbols parameters.
2003         * psympriv.h (start_psymtab_common): Update.
2004         * mdebugread.c (parse_partial_symbols): Update.
2005         * dwarf2read.c (create_partial_symtab): Update.
2006         * dbxread.c (read_dbx_symtab): Update.
2007         (start_psymtab): Remove global_psymbols and static_psymbols
2008         parameters.
2009
2010 2019-01-10  Tom Tromey  <tom@tromey.com>
2011
2012         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2013         * psymtab.c (allocate_psymtab): Add comment.
2014         * psympriv.h (allocate_psymtab): Add comment.
2015         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2016         initializations.
2017         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2018
2019 2019-01-10  Tom Tromey  <tom@tromey.com>
2020
2021         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2022         Don't declare.
2023         * mipsread.c: Include mdebugread.h.
2024         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2025         Declare.
2026         * elfread.c: Include mdebugread.h.
2027
2028 2019-01-09  Tom Tromey  <tom@tromey.com>
2029
2030         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2031         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2032         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2033         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2034         (psym_lookup_symbol, psym_find_last_source_symtab)
2035         (psym_forget_cached_source_info, psym_print_stats)
2036         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2037         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2038         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2039         (psym_find_compunit_symtab_by_address)
2040         (maintenance_print_psymbols, maintenance_info_psymtabs)
2041         (maintenance_check_psymtabs): Use ranged for.
2042         * psymtab.h (class objfile_psymtabs): New.
2043         (require_partial_symbols): Return objfile_psymtabs.
2044         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2045
2046 2019-01-09  Tom Tromey  <tom@tromey.com>
2047
2048         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2049         (find_pc_mapped_section, list_overlays_command)
2050         (map_overlay_command, unmap_overlay_command)
2051         (simple_overlay_update): Use all_objfiles.
2052         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2053         * printcmd.c (info_symbol_command): Use all_objfiles.
2054         * objfiles.h (ALL_OBJSECTIONS): Remove.
2055         * maint.c (maintenance_translate_address): Use all_objfiles.
2056         * gcore.c (gcore_create_callback): Use all_objfiles.
2057         (objfile_find_memory_regions): Likewise.
2058
2059 2019-01-09  Tom Tromey  <tom@tromey.com>
2060
2061         * symtab.c (find_line_symtab, info_sources_command)
2062         (make_source_files_completion_list): Use objfile_compunits.
2063         * source.c (select_source_symtab): Use objfile_compunits.
2064         * objfiles.h (struct objfile): Update comment.
2065         (ALL_OBJFILES): Remove.
2066         (ALL_FILETABS): Remove.
2067         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2068         objfile_compunits.
2069
2070 2019-01-09  Tom Tromey  <tom@tromey.com>
2071
2072         * symmisc.c (print_objfile_statistics, dump_objfile)
2073         (maintenance_print_symbols): Use compunit_filetabs.
2074         * source.c (forget_cached_source_info_for_objfile): Use
2075         compunit_filetabs.
2076         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2077         (ALL_FILETABS): Use compunit_filetabs.
2078         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2079         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2080
2081 2019-01-09  Tom Tromey  <tom@tromey.com>
2082
2083         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2084         (compunit_filetabs): New.
2085         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2086         compunit_filetabs.
2087         (info_sources_command, make_source_files_completion_list): Remove
2088         declaration.
2089         * symmisc.c (print_objfile_statistics, dump_objfile)
2090         (maintenance_print_symbols): Remove declaration.
2091         (maintenance_info_symtabs): Use compunit_filetabs.
2092         (maintenance_info_line_tables): Likewise.
2093         * source.c (select_source_symtab): Change local variable name.
2094         (forget_cached_source_info_for_objfile): Remove declaration.
2095         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2096         * objfiles.c (objfile_relocate1): Remove declaration.
2097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2098         declaration.
2099         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2100         * coffread.c (coff_symtab_read): Remove declaration.
2101         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2102         compunit_filetabs.
2103
2104 2019-01-09  Tom Tromey  <tom@tromey.com>
2105
2106         * symtab.c (lookup_objfile_from_block)
2107         (find_pc_sect_compunit_symtab, search_symbols)
2108         (default_collect_symbol_completion_matches_break_on): Use
2109         objfile_compunits.
2110         * objfiles.h (ALL_COMPUNITS): Remove.
2111         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2112         * cp-support.c (add_symbol_overload_list_qualified): Use
2113         objfile_compunits.
2114         * ada-lang.c (ada_collect_symbol_completion_matches)
2115         (ada_add_global_exceptions): Use objfile_compunits.
2116
2117 2019-01-09  Tom Tromey  <tom@tromey.com>
2118
2119         * source.c (select_source_symtab)
2120         (forget_cached_source_info_for_objfile): Remove declaration.
2121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2122         declaration.
2123         * maint.c (count_symtabs_and_blocks): Remove declaration.
2124         * cp-support.c (add_symbol_overload_list_qualified): Remove
2125         declaration.
2126         * coffread.c (coff_symtab_read): Remove declaration.
2127         * symtab.c (lookup_symbol_in_objfile_symtabs)
2128         (basic_lookup_transparent_type_1): Use objfile_compunits.
2129         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2130         (info_sources_command, search_symbols)
2131         (default_collect_symbol_completion_matches_break_on)
2132         (make_source_files_completion_list): Remove declaration.
2133         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2134         (ada_collect_symbol_completion_matches)
2135         (ada_add_global_exceptions): Remove declaration.
2136         * linespec.c (iterate_over_all_matching_symtabs): Use
2137         objfile_compunits.
2138         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2139         (class objfile_compunits): New.
2140         (ALL_COMPUNITS): Use objfile_compunits.
2141         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2142         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2143         objfile_compunits.
2144         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2145
2146 2019-01-09  Tom Tromey  <tom@tromey.com>
2147
2148         * symtab.c (search_symbols)
2149         (default_collect_symbol_completion_matches_break_on): Use
2150         objfile_msymbols.
2151         * ada-lang.c (ada_lookup_simple_minsym)
2152         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2153         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2154         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2155         objfile_msymbols.
2156         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2157         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2158         * objc-lang.c (find_methods): Use objfile_msymbols.
2159         (info_selectors_command, info_classes_command): Likewise.
2160         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2161         * objfiles.h (class objfile_msymbols): New.
2162         (ALL_OBJFILE_MSYMBOLS): Remove.
2163         (ALL_MSYMBOLS): Remove.
2164
2165 2019-01-09  Tom Tromey  <tom@tromey.com>
2166
2167         * common/next-iterator.h (next_adapter): Add Iterator template
2168         parameter.
2169         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2170         (class all_objfiles_safe): New.
2171         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2172         * objfiles.c (put_objfile_before): Update comment.
2173         (add_separate_debug_objfile): Likewise.
2174         (free_all_objfiles): Use all_objfiles_safe.
2175         (objfile_purge_solibs): Likewise.
2176
2177 2019-01-09  Tom Tromey  <tom@tromey.com>
2178
2179         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2180         (expand_symtab_containing_pc, lookup_static_symbol)
2181         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2182         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2183         all_objfiles.
2184         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2185         * breakpoint.c (create_overlay_event_breakpoint)
2186         (create_longjmp_master_breakpoint)
2187         (create_std_terminate_master_breakpoint)
2188         (create_exception_master_breakpoint): Use all_objfiles.
2189         * linux-thread-db.c (try_thread_db_load_from_pdir)
2190         (has_libpthread): Use all_objfiles.
2191         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2192         * linespec.c (iterate_over_all_matching_symtabs)
2193         (search_minsyms_for_name): Use all_objfiles.
2194         * maint.c (maintenance_info_sections): Use all_objfiles.
2195         * main.c (captured_main_1): Use all_objfiles.
2196         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2197         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2198         * guile/scm-pretty-print.c
2199         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2200         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2201         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2202         (maintenance_print_msymbols): Use all_objfiles.
2203         * source.c (select_source_symtab): Use all_objfiles.
2204         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2205         * symfile.c (remove_symbol_file_command)
2206         (expand_symtabs_matching, map_symbol_filenames): Use
2207         all_objfiles.
2208         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2209         all_objfiles.
2210         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2211         * objc-lang.c (find_methods): Use all_objfiles.
2212         * objfiles.c (have_partial_symbols, have_full_symbols)
2213         (have_minimal_symbols, qsort_cmp)
2214         (default_iterate_over_objfiles_in_search_order): Use
2215         all_objfiles.
2216         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2217         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2218         (maintenance_check_psymtabs): Use all_objfiles.
2219         (ALL_PSYMTABS): Remove.
2220         * compile/compile-object-run.c (do_module_cleanup): Use
2221         all_objfiles.
2222         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2223         * cp-support.c (add_symbol_overload_list_qualified): Use
2224         all_objfiles.
2225         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2226         Use all_objfiles.
2227         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2228         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2229         all_objfiles.
2230         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2231         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2232         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2233         Uses all_objfiles.
2234         * solib.c (solib_read_symbols): Use all_objfiles
2235
2236 2019-01-09  Tom Tromey  <tom@tromey.com>
2237
2238         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2239         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2240         all_objfiles.
2241         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2242         * symmisc.c (print_symbol_bcache_statistics)
2243         (print_objfile_statistics, maintenance_print_objfiles)
2244         (maintenance_info_symtabs, maintenance_check_symtabs)
2245         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2246         all_objfiles.
2247         * source.c (forget_cached_source_info): Use all_objfiles.
2248         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2249         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2250         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2251         * objfiles.c (update_section_map): Use all_objfiles.
2252         (shared_objfile_contains_address_p): Likewise.
2253         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2254         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2255
2256 2019-01-09  Tom Tromey  <tom@tromey.com>
2257
2258         * common/next-iterator.h: New file.
2259         * objfiles.h (class all_objfiles): New.
2260         (struct objfile_iterator): New.
2261
2262 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2263
2264         * NEWS: Move the description of the changed "frame", "select-frame",
2265          and "info frame" commands to the Changed commands section.
2266
2267 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2268
2269         * gdbtypes.c (check_stub_method_group): Remove handling of old
2270         mangling schemes.
2271         * linespec.c (find_methods): Likewise.
2272         * stabsread.c (read_member_functions): Likewise.
2273         * valops.c (search_struct_method): Likewise.
2274         (value_struct_elt_for_reference): Likewise.
2275         * NEWS: Mention this change.
2276
2277 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2278
2279         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2280         print_source_lines.
2281         * source.c (print_source_lines_base): Update line number check.
2282         (print_source_lines): New function.
2283         (source_lines_range::source_lines_range): New function.
2284         * source.h (class source_lines_range): New class.
2285         (print_source_lines): New declaration.
2286
2287 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2288
2289         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2290
2291 2019-01-08  Tom Tromey  <tom@tromey.com>
2292             Simon Marchi  <simon.marchi@ericsson.com>
2293
2294         PR gdb/24060
2295         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2296         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2297         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2298         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2299         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2300         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2301
2302 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2303
2304         * source.c (select_source_symtab): Move header comment to
2305         declaration in source.h.
2306         (forget_cached_source_info_for_objfile): Likewise.
2307         (forget_cached_source_info): Likewise.
2308         (identify_source_line): Likewise.
2309         * source.h (identify_source_line): Move declaration from symtab.h
2310         and add comment from source.c
2311         (print_source_lines): Likewise.
2312         (forget_cached_source_info_for_objfile): Likewise.
2313         (forget_cached_source_info): Likewise.
2314         (select_source_symtab): Likewise.
2315         (enum print_source_lines_flag): Move definition from symtab.h.
2316         * symtab.h (identify_source_line): Move declaration to source.h.
2317         (print_source_lines): Likewise.
2318         (forget_cached_source_info_for_objfile): Likewise.
2319         (forget_cached_source_info): Likewise.
2320         (select_source_symtab): Likewise.
2321         (enum print_source_lines_flag): Move definition to source.h.
2322         * tui/tui-hooks.c: Add 'source.h' include.
2323
2324 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * source.c (print_source_lines_base): Handle requests to print
2327         reverse line number sequences, and guard against empty lines
2328         string.
2329
2330 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * source.c (print_source_lines_base): Fix skip of '\r' if next
2333         character is '\n'.
2334
2335 2019-01-06  Tom Tromey  <tom@tromey.com>
2336
2337         * c-exp.y (struct c_parse_state) <macro_original_text,
2338         expansion_obstack>: New member.
2339         (macro_original_text, expansion_obstack): Remove globals.
2340         (scan_macro_expansion, scanning_macro_expansion)
2341         (finished_macro_expansion): Update.
2342         (scan_macro_cleanup): Remove.
2343         (yylex, c_parse): Update.
2344
2345 2019-01-06  Tom Tromey  <tom@tromey.com>
2346
2347         * c-exp.y (struct c_parse_state) <strings>: New member.
2348         (operator_stoken): Update.
2349
2350 2019-01-06  Tom Tromey  <tom@tromey.com>
2351
2352         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2353         (union type_stack_elt) <typelist_val>: Now a pointer to
2354         std::vector.
2355         (type_stack_cleanup): Don't declare.
2356         (push_typelist): Update.
2357         * parse.c (pop_typelist): Return a std::vector.
2358         (push_typelist): Take a std::vector.
2359         (follow_types): Update.  Do not free args.
2360         (type_stack_cleanup): Remove.
2361         * c-exp.y (struct c_parse_state): New.
2362         (cpstate): New global.
2363         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2364         (nonempty_typelist): Update.
2365         (func_mod): Create a new vector.
2366         (c_parse): Create a c_parse_state.
2367         (check_parameter_typelist): Do not delete params.
2368         (function_method): Update.  Do not delete type_list.
2369
2370 2019-01-06  Tom Tromey  <tom@tromey.com>
2371
2372         PR gdb/28155:
2373         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2374         check_typedef.
2375         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2376         (print_return_value): Likewise.
2377
2378 2019-01-05  Tom Tromey  <tom@tromey.com>
2379
2380         * contrib/cleanup_check.py: Remove.
2381         * contrib/gcc-with-excheck: Remove.
2382         * contrib/exsummary.py: Remove.
2383         * contrib/excheck.py: Remove.
2384
2385 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2386
2387         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2388         NULL. Initialize tpprev to NULL instead of assigning it
2389         to NULL on the next statement.
2390         * windows-nat.c (windows_delete_thread): Remove check for
2391         main_thread_id before printing thread exit notifications.
2392         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2393         Remove thread ID check against main_thread_id.
2394         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2395         windows_delete_thread.
2396         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2397
2398 2019-01-04  Tom Tromey  <tom@tromey.com>
2399
2400         * compile/compile.c (_initialize_compile): Use upper case for
2401         metasyntactic variables.
2402         * symmisc.c (_initialize_symmisc): Use upper case for
2403         metasyntactic variables.
2404         * psymtab.c (_initialize_psymtab): Use upper case for
2405         metasyntactic variables.
2406         * demangle.c (demangle_command): Use upper case for metasyntactic
2407         variables.
2408         (_initialize_demangler): Likewise.
2409         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2410         variables.
2411
2412 2019-01-03  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2415
2416 2019-01-03  Tom Tromey  <tom@tromey.com>
2417
2418         * python/py-symtab.c (salpy_str): Update.
2419         (struct salpy_sal_object) <symtab>: Now a PyObject.
2420         (salpy_dealloc): Update.
2421         (del_objfile_sal): Use gdbpy_ref.
2422
2423 2019-01-03  Tom Tromey  <tom@tromey.com>
2424
2425         * python/py-type.c (convert_field): Use new_reference.  Return
2426         gdbpy_ref.
2427         (make_fielditem): Return gdbpy_ref.
2428         (typy_fields): Update.
2429         (typy_getitem): Update.
2430         (field_name): Return gdbpy_ref.  Use new_reference.
2431         (typy_iterator_iternext): Update.
2432
2433 2019-01-03  Tom Tromey  <tom@tromey.com>
2434
2435         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2436
2437 2019-01-03  Tom Tromey  <tom@tromey.com>
2438
2439         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2440         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2441         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2442         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2443         (pspy_set_type_printers): Likewise.
2444         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2445         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2446         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2447         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2448         (objfpy_set_type_printers): Likewise.
2449
2450 2019-01-03  Tom Tromey  <tom@tromey.com>
2451
2452         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2453         (gdbpy_print_stack): Use gdbpy_err_fetch.
2454         * python/python-internal.h (class gdbpy_err_fetch): New class.
2455         (class gdbpy_enter) <m_error_type, m_error_value,
2456         m_error_traceback>: Remove.
2457         <m_error>: New member.
2458         (gdbpy_exception_to_string): Don't declare.
2459         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2460         * python/py-value.c (convert_value_from_python): Use
2461         gdbpy_err_fetch.
2462         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2463         gdbpy_exception_to_string.
2464         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2465         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2466         gdbpy_err_fetch.
2467
2468 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * linux-nat.c (delete_lwp_cleanup): Delete.
2471         (struct lwp_deleter): New struct.
2472         (lwp_info_up): New typedef.
2473         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2474         lwp_info_up.
2475
2476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2477
2478         * linux-fork.c (class scoped_switch_fork_info): New class.
2479         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2480
2481 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2482
2483         * valops.c (find_overload_match): Remove use of null_cleanup, and
2484         calls to do_cleanups.
2485
2486 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * compile/compile-cplus-types.c
2489         (compile_cplus_instance::decl_name): Handle changes to
2490         cp_func_name.
2491         * cp-support.c (cp_func_name): Update header comment, update
2492         return type.
2493         * cp-support.h (cp_func_name): Update return type in declaration.
2494         * valops.c (find_overload_match): Move temp_func local to top
2495         level of function and change its type.  Use temp_func to hold and
2496         delete temporary string obtained from cp_func_name.
2497
2498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2501         gdb::char_vector, remove cleanup, and update uses of `msg`.
2502
2503 2019-01-03  Jim Wilson  <jimw@sifive.com>
2504
2505         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2506
2507 2019-01-02  Tom Tromey  <tom@tromey.com>
2508
2509         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2510         (tdesc_parse_xml): Remove cleanups.
2511         * target-descriptions.h (make_cleanup_free_target_description):
2512         Don't declare.
2513         (target_desc_deleter): New struct.
2514         (target_desc_up): New typedef.
2515         * target-descriptions.c (target_desc_deleter::operator()): Rename
2516         from free_target_description.
2517         (make_cleanup_free_target_description): Remove.
2518
2519 2019-01-02  Tom Tromey  <tom@tromey.com>
2520
2521         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2522         constructor, destructor.
2523         (linespec_parser): Remove typedef.
2524         (~linespec_parser): Rename from linespec_parser_delete.
2525         (linespec_lex_to_end, linespec_complete_label)
2526         (linespec_complete): Update.
2527         (decode_line_full): Remove cleanups.
2528         (decode_line_1): Update.
2529
2530 2019-01-02  Tom Tromey  <tom@tromey.com>
2531
2532         * python/python-internal.h (inferior_to_inferior_object): Change
2533         return type.
2534         * python/py-exitedevent.c (create_exited_event_object): Update.
2535         * python/py-inferior.c (inferior_to_inferior_object): Return
2536         gdbpy_ref.
2537         (python_new_inferior, python_inferior_deleted)
2538         (thread_to_thread_object, delete_thread_object)
2539         (build_inferior_list, gdbpy_selected_inferior): Update.
2540         * python/py-infthread.c (create_thread_object): Update.  Also fail
2541         if inferior_to_inferior_object fails.
2542
2543 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2544
2545         * inferior.h (class inferior) <displaced_step_state>: New field.
2546         * infrun.h (struct displaced_step_state): Move here from
2547         infrun.c.  Initialize fields, add constructor.
2548         <inf>: Remove field.
2549         <reset>: New method.
2550         * infrun.c (struct displaced_step_inferior_state): Move to
2551         infrun.h.
2552         (displaced_step_inferior_states): Remove.
2553         (get_displaced_stepping_state): Adust.
2554         (displaced_step_in_progress_any_inferior): Adjust.
2555         (displaced_step_in_progress_thread): Adjust.
2556         (displaced_step_in_progress): Adjust.
2557         (add_displaced_stepping_state): Remove.
2558         (get_displaced_step_closure_by_addr): Adjust.
2559         (remove_displaced_stepping_state): Remove.
2560         (infrun_inferior_exit): Call displaced_step_state.reset.
2561         (use_displaced_stepping): Don't check for NULL.
2562         (displaced_step_prepare_throw): Call
2563         get_displaced_stepping_state.
2564         (displaced_step_fixup): Don't check for NULL.
2565         (prepare_for_detach): Don't check for NULL.
2566
2567 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2568
2569         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2570          in case of call that did not complete.
2571
2572 2019-01-02  Andrey Utkin  <autkin@undo.io>
2573
2574         * symfile.c (find_separate_debug_file): Fix search of debug files for
2575         remote debuggee.
2576
2577 2019-01-02  Tom Tromey  <tom@tromey.com>
2578
2579         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2580         indentation.
2581         * python/py-frame.c (frapy_older): Remove cast.
2582         (frapy_newer): Likewise.
2583         * python/py-breakpoint.c (local_setattro): Remove cast.
2584         * python/py-arch.c (archpy_name): Remove local variable.
2585         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2586
2587 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2588
2589         * unittests/basic_string_view/element_access/char/empty.cc:
2590         Fix year range in copyright header.
2591
2592 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2595         Delete.
2596         <operator==>: Update with for removed field.
2597         <hash>: Likewise.
2598         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2599         <isa_features>: ...this.
2600         <abi_features>: New field.
2601         (riscv_isa_flen): Update comment.
2602         (riscv_abi_xlen): New declaration.
2603         (riscv_abi_flen): New declaration.
2604         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2605         isa_features.
2606         (riscv_abi_xlen): New function.
2607         (riscv_isa_flen): Update to get answer from isa_features.
2608         (riscv_abi_flen): New function.
2609         (riscv_has_fp_abi): Update to get answer from abi_features.
2610         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2611         xlen and flen.
2612         (riscv_call_info) <xlen, flen>: Update comment.
2613         (riscv_call_arg_struct): Remove invalid assertions
2614         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2615         is removed.
2616         (riscv_gdbarch_init): Gather isa features and abi features
2617         separately, ensure both match on the gdbarch when reusing an old
2618         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2619         a target with 64-bit float hardware.
2620
2621 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2622
2623         * source.c (search_command_helper): Stop reverse search
2624         when line 1 has been searched.
2625
2626 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2627
2628         * record-full.c (record_full_base_target::close): Rewrite
2629         record_full_core_buf_list free logic.
2630
2631 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2632
2633         * break-catch-syscall.c (print_one_catch_syscall): xfree
2634         the last text.
2635
2636 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2637
2638         * top.c (print_gdb_version): Update Copyright year in version
2639         message.
2640
2641 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2642
2643         Update copyright year range in all GDB files.
2644
2645 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2646
2647         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2648
2649 For older changes see ChangeLog-2018.
2650 \f
2651 Local Variables:
2652 mode: change-log
2653 left-margin: 8
2654 fill-column: 74
2655 version-control: never
2656 coding: utf-8
2657 End:
2658