gdb/ChangeLog

   1 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * main.c (captured_main_1): Disable styling in batch mode.
   4
   5 2019-02-20  Tom Tromey  <tom@tromey.com>
   6
   7         * symtab.c (symtab_symbol_info): Fix typos.
   8
   9 2019-02-20  Tom Tromey  <tromey@adacore.com>
  10
  11         * findcmd.c (_initialize_mem_search): Use upper case for
  12         metasyntactic variables.
  13
  14 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  15
  16         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  17         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  18
  19 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * top.h (source_file_name): Change to std::string.
  22         * top.c (source_file_name): Likewise.
  23         (command_line_input): Adjust.
  24         * cli/cli-script.c (script_from_file): Adjust.
  25
  26 2019-02-19  Tom Tromey  <tromey@adacore.com>
  27
  28         * ravenscar-thread.c
  29         (ravenscar_thread_target::update_thread_list): Don't call
  30         ada_build_task_list.
  31         * ada-lang.h (ada_build_task_list): Don't declare.
  32         * ada-tasks.c (struct ada_tasks_inferior_data)
  33         <task_list_valid_p>: Now bool.
  34         (read_known_tasks, ada_task_list_changed)
  35         (ada_tasks_invalidate_inferior_data): Update.
  36         (read_known_tasks_array): Return bool.
  37         (read_known_tasks_list): Likewise.
  38         (read_known_tasks): Return void.
  39         (ada_build_task_list): Now static.
  40
  41 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  42
  43         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  44         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  45
  46 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  47
  48         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  49         variant for ada_tasks_pspace_data_handle and
  50         ada_tasks_inferior_data_handle.
  51         (ada_tasks_pspace_data_cleanup): New function.
  52         (ada_tasks_inferior_data_cleanup): New function.
  53
  54 2019-02-17  Tom Tromey  <tom@tromey.com>
  55
  56         * macrotab.h (macro_source_fullname): Return a std::string.
  57         * macrotab.c (macro_include, check_for_redefinition)
  58         (macro_undef, macro_lookup_definition, foreach_macro)
  59         (foreach_macro_in_scope): Update.
  60         (macro_source_fullname): Return a std::string.
  61         * macrocmd.c (show_pp_source_pos): Update.
  62
  63 2019-02-17  Tom Tromey  <tom@tromey.com>
  64
  65         * macrocmd.c (show_pp_source_pos): Style the file names.
  66
  67 2019-02-17  Tom Tromey  <tom@tromey.com>
  68
  69         PR tui/24197:
  70         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  71
  72 2019-02-17  Tom Tromey  <tom@tromey.com>
  73
  74         * ada-lang.c (user_select_syms): Use filtered printing.
  75         * utils.c (wrap_style): New global.
  76         (desired_style): Remove.
  77         (emit_style_escape): Add stream parameter.
  78         (set_output_style, reset_terminal_style, prompt_for_continue):
  79         Update.
  80         (flush_wrap_buffer): Only flush gdb_stdout.
  81         (wrap_here): Set wrap_style.
  82         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  83         treat escape sequences as a character.  Change when wrap buffer is
  84         flushed.
  85         (fputs_styled): Do not set the output style when the default is
  86         requested.
  87         * ui-style.h (struct ui_file_style) <is_default>: New method.
  88         * source.c (print_source_lines_base): Emit escape sequences in one
  89         piece.
  90
  91 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  92
  93         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  94         integers and enumeration types.
  95
  96 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  97
  98         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  99         instead of lookup_symbol_in_language
 100         (do_exact_match): New function.
 101         (ada_get_symbol_name_matcher): Return do_exact_match when
 102         doing a verbatim match.
 103
 104 2019-02-15  Tom Tromey  <tromey@adacore.com>
 105
 106         * ravenscar-thread.c (ravenscar_thread_target::resume)
 107         (ravenscar_thread_target::wait): Special case wildcard requests.
 108
 109 2019-02-15  Tom Tromey  <tromey@adacore.com>
 110
 111         * ravenscar-thread.c (base_ptid): Remove.
 112         (struct ravenscar_thread_target) <close>: New method.
 113         <m_base_ptid>: New member.
 114         <update_inferior_ptid, active_task, task_is_currently_active,
 115         runtime_initialized>: Declare methods.
 116         <ravenscar_thread_target>: Add constructor.
 117         (ravenscar_thread_target::task_is_currently_active)
 118         (ravenscar_thread_target::update_inferior_ptid)
 119         (ravenscar_runtime_initialized): Rename.  Now methods.
 120         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 121         (ravenscar_thread_target::update_thread_list): Update.
 122         (ravenscar_thread_target::active_task): Now method.
 123         (ravenscar_thread_target::store_registers)
 124         (ravenscar_thread_target::prepare_to_store)
 125         (ravenscar_thread_target::prepare_to_store)
 126         (ravenscar_thread_target::mourn_inferior): Update.
 127         (ravenscar_inferior_created): Use "new" to create target.
 128         (ravenscar_thread_target::get_ada_task_ptid): Update.
 129         (_initialize_ravenscar): Don't initialize base_ptid.
 130         (ravenscar_ops): Remove global.
 131
 132 2019-02-15  Tom Tromey  <tromey@adacore.com>
 133
 134         * target.h (push_target): Declare new overload.
 135         * target.c (push_target): New overload, taking an rvalue reference.
 136         * remote.c (remote_target::open_1): Use push_target overload.
 137         * corelow.c (core_target_open): Use push_target overload.
 138
 139 2019-02-15  Tom Tromey  <tromey@adacore.com>
 140
 141         * ravenscar-thread.c (is_ravenscar_task)
 142         (ravenscar_task_is_currently_active): Return bool.
 143         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 144         (_initialize_ravenscar): Remove "(void)".
 145         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 146         Return bool.
 147
 148 2019-02-15  Tom Tromey  <tromey@adacore.com>
 149
 150         * ravenscar-thread.c (ravenscar_runtime_initializer)
 151         (has_ravenscar_runtime, get_running_thread_id)
 152         (ravenscar_thread_target::resume): Fix indentation.
 153
 154 2019-02-15  Tom Tromey  <tromey@adacore.com>
 155
 156         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 157         from ravenscar_arch_ops.
 158         (sparc_ravenscar_ops::fetch_registers)
 159         (sparc_ravenscar_ops::store_registers): Now methods.
 160         (sparc_ravenscar_prepare_to_store): Remove.
 161         (sparc_ravenscar_ops): Redefine.
 162         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 163         methods and destructor.  Remove members.
 164         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 165         (ravenscar_thread_target::store_registers)
 166         (ravenscar_thread_target::prepare_to_store): Update.
 167         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 168         Remove.
 169         (struct ppc_ravenscar_powerpc_ops): Derive from
 170         ravenscar_arch_ops.
 171         (ppc_ravenscar_powerpc_ops::fetch_registers)
 172         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 173         (ppc_ravenscar_powerpc_ops): Redefine.
 174         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 175         (ppc_ravenscar_e500_ops::fetch_registers)
 176         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 177         (ppc_ravenscar_e500_ops): Redefine.
 178         * aarch64-ravenscar-thread.c
 179         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 180         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 181         (aarch64_ravenscar_fetch_registers)
 182         (aarch64_ravenscar_store_registers): Now methods.
 183         (aarch64_ravenscar_ops): Redefine.
 184
 185 2019-02-15  Tom Tromey  <tromey@adacore.com>
 186
 187         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 188         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 189         (ravenscar_thread_target::stopped_by_watchpoint)
 190         (ravenscar_thread_target::stopped_data_address)
 191         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 192
 193 2019-02-15  Tom Tromey  <tromey@adacore.com>
 194
 195         * ravenscar-thread.c: Fix some typos.
 196
 197 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 198             Tom Tromey  <tromey@adacore.com>
 199
 200         * ada-lang.c (ada_exception_sal): Change addr_string to a
 201         std::string.
 202         (create_ada_exception_catchpoint): Update.
 203
 204 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 205             Tom Tromey  <tromey@adacore.com>
 206
 207         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 208         (bp_location_ops): Remove.
 209         (base_breakpoint_allocate_location): Update.
 210         (free_bp_location): Update.
 211         * ada-lang.c (class ada_catchpoint_location)
 212         <ada_catchpoint_location>: Remove ops parameter.
 213         (ada_catchpoint_location_dtor): Remove.
 214         (ada_catchpoint_location_ops): Remove.
 215         (allocate_location_exception): Update.
 216         * breakpoint.h (struct bp_location_ops): Remove.
 217         (class bp_location) <bp_location>: Remove bp_location_ops
 218         parameter.
 219         <~bp_location>: Add destructor.
 220         <ops>: Remove.
 221
 222 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 223             Pedro Alves  <palves@redhat.com>
 224
 225         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 226         'PATH_MAX'.
 227
 228 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 229             Samuel Thibault  <samuel.thibault@gnu.org>
 230             Thomas Schwinge  <thomas@codesourcery.com>
 231
 232         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 233         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 234
 235 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 236
 237         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 238         (check_empty): Use "const char *".
 239
 240         * gnu-nat.c (gnu_nat_target::detach): Instead of
 241         'detach_inferior (pid)' call
 242         'detach_inferior (find_inferior_pid (pid))'.
 243
 244         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 245         'nat/fork-inferior.o'.
 246         * gnu-nat.c: #include "nat/fork-inferior.h".
 247
 248         * gnu-nat.c (gnu_nat_target::detach): Instead of
 249         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 250         * gnu-nat.h: #include "inf-child.h".
 251         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 252         'i386_gnu_nat_target::fetch_registers'.
 253         (gnu_store_registers): Rename/move to
 254         'i386_gnu_nat_target::store_registers'.
 255
 256         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 257         * gnu-nat.h (mach_thread_info): New function.
 258         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 259
 260         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 261
 262 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 263
 264         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 265
 266 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 267
 268         * windows-nat.c (windows_add_thread): Add new parameter
 269         "main_thread_p" with default value set to false.  Update
 270         function documentation as well as all callers.
 271         (windows_delete_thread): Likewise.
 272         (fake_create_process): Update call to windows_add_thread.
 273         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 274         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 275         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 276         call to windows_delete_thread.
 277
 278 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 279
 280         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 281
 282 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 283
 284         * symfile.c (find_separate_debug_file): Use canonical path of
 285         sysroot with child_path instead of gdb_sysroot if it is valid.
 286
 287 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 288
 289         * symfile.c (find_separate_debug_file): Use child_path to
 290         determine if an object file is under a sysroot.
 291
 292 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 293
 294         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 295         unittests/child-path-selftests.c.
 296         * common/pathstuff.c (child_path): New function.
 297         * common/pathstuff.h (child_path): New prototype.
 298         * unittests/child-path-selftests.c: New file.
 299
 300 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 301
 302         * symfile.c (find_separate_debug_file): Look for separate debug
 303         files in debug directories under the sysroot.
 304
 305 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 306
 307         * symtab.h (struct minimal_symbol data_p): New const method.
 308         (struct minimal_symbol text_p): Likewise.
 309         * symtab.c (output_source_filename): Use file name style
 310         to print file name.
 311         (print_symbol_info): Likewise.
 312         (print_msymbol_info): Use address style to print addresses.
 313         Use function name style to print executable text symbols.
 314         (expand_symtab_containing_pc): Use data_p.
 315         (find_pc_sect_compunit_symtab): Likewise.
 316
 317 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 318
 319         * breakpoint.c (describe_other_breakpoints): Use address style
 320         to print addresses.
 321         (say_where): Likewise.
 322
 323 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 324
 325         * ada-typeprint.c (print_func_type): Print function name
 326         style to print function name.
 327         * c-typeprint.c (c_print_type_1): Likewise.
 328
 329 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 330
 331         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 332         for execve.
 333
 334 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 335
 336         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 337         type_stack.
 338
 339 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 340
 341         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 342         TYPE_CODE_REF types.
 343
 344 2019-02-08  Jim Wilson  <jimw@sifive.com>
 345
 346         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 347         (riscv_linux_fregset): New.
 348         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 349
 350 2019-02-07  Tom Tromey  <tom@tromey.com>
 351
 352         * thread.c (thread_cancel_execution_command): Update.
 353         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 354         methods.
 355         (struct thread_fsm_ops): Remove.
 356         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 357         (thread_fsm_should_stop, thread_fsm_return_value)
 358         (thread_fsm_set_finished, thread_fsm_finished_p)
 359         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 360         Don't declare.
 361         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 362         * infrun.c (clear_proceed_status_thread)
 363         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 364         (print_stop_event): Update.
 365         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 366         Add constructor.
 367         (step_command_fsm_ops): Remove.
 368         (new_step_command_fsm): Remove.
 369         (step_1): Update.
 370         (step_command_fsm::should_stop): Rename from
 371         step_command_fsm_should_stop.
 372         (step_command_fsm::clean_up): Rename from
 373         step_command_fsm_clean_up.
 374         (step_command_fsm::do_async_reply_reason): Rename from
 375         step_command_fsm_async_reply_reason.
 376         (struct until_next_fsm): Inherit from thread_fsm.  Add
 377         constructor.
 378         (until_next_fsm_ops): Remove.
 379         (new_until_next_fsm): Remove.
 380         (until_next_fsm::should_stop): Rename from
 381         until_next_fsm_should_stop.
 382         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 383         (until_next_fsm::do_async_reply_reason): Rename from
 384         until_next_fsm_async_reply_reason.
 385         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 386         constructor.  Change type of breakpoint.
 387         (finish_command_fsm_ops): Remove.
 388         (new_finish_command_fsm): Remove.
 389         (finish_command_fsm::should_stop): Rename from
 390         finish_command_fsm_should_stop.
 391         (finish_command_fsm::clean_up): Rename from
 392         finish_command_fsm_clean_up.
 393         (finish_command_fsm::return_value): Rename from
 394         finish_command_fsm_return_value.
 395         (finish_command_fsm::do_async_reply_reason): Rename from
 396         finish_command_fsm_async_reply_reason.
 397         (finish_command): Update.
 398         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 399         Add constructor.
 400         (call_thread_fsm_ops): Remove.
 401         (call_thread_fsm::call_thread_fsm): Rename from
 402         new_call_thread_fsm.
 403         (call_thread_fsm::should_stop): Rename from
 404         call_thread_fsm_should_stop.
 405         (call_thread_fsm::should_notify_stop): Rename from
 406         call_thread_fsm_should_notify_stop.
 407         (run_inferior_call, call_function_by_hand_dummy): Update.
 408         * cli/cli-interp.c (should_print_stop_to_console): Update.
 409         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 410         Add constructor.  Change type of location_breakpoint,
 411         caller_breakpoint.
 412         (until_break_fsm_ops): Remove.
 413         (new_until_break_fsm): Remove.
 414         (until_break_fsm::should_stop): Rename from
 415         until_break_fsm_should_stop.
 416         (until_break_fsm::clean_up): Rename from
 417         until_break_fsm_clean_up.
 418         (until_break_fsm::do_async_reply_reason): Rename from
 419         until_break_fsm_async_reply_reason.
 420         (until_break_command): Update.
 421         * thread-fsm.c: Remove.
 422         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 423
 424 2019-02-07  Tom Tromey  <tom@tromey.com>
 425
 426         * yy-remap.h: Add include guard.
 427         * xtensa-tdep.h: Add include guard.
 428         * xcoffread.h: Rename include guard.
 429         * varobj-iter.h: Add include guard.
 430         * tui/tui.h: Rename include guard.
 431         * tui/tui-winsource.h: Rename include guard.
 432         * tui/tui-wingeneral.h: Rename include guard.
 433         * tui/tui-windata.h: Rename include guard.
 434         * tui/tui-win.h: Rename include guard.
 435         * tui/tui-stack.h: Rename include guard.
 436         * tui/tui-source.h: Rename include guard.
 437         * tui/tui-regs.h: Rename include guard.
 438         * tui/tui-out.h: Rename include guard.
 439         * tui/tui-layout.h: Rename include guard.
 440         * tui/tui-io.h: Rename include guard.
 441         * tui/tui-hooks.h: Rename include guard.
 442         * tui/tui-file.h: Rename include guard.
 443         * tui/tui-disasm.h: Rename include guard.
 444         * tui/tui-data.h: Rename include guard.
 445         * tui/tui-command.h: Rename include guard.
 446         * tic6x-tdep.h: Add include guard.
 447         * target/waitstatus.h: Rename include guard.
 448         * target/wait.h: Rename include guard.
 449         * target/target.h: Rename include guard.
 450         * target/resume.h: Rename include guard.
 451         * target-float.h: Rename include guard.
 452         * stabsread.h: Add include guard.
 453         * rs6000-tdep.h: Add include guard.
 454         * riscv-fbsd-tdep.h: Add include guard.
 455         * regformats/regdef.h: Rename include guard.
 456         * record.h: Rename include guard.
 457         * python/python.h: Rename include guard.
 458         * python/python-internal.h: Rename include guard.
 459         * python/py-stopevent.h: Rename include guard.
 460         * python/py-ref.h: Rename include guard.
 461         * python/py-record.h: Rename include guard.
 462         * python/py-record-full.h: Rename include guard.
 463         * python/py-record-btrace.h: Rename include guard.
 464         * python/py-instruction.h: Rename include guard.
 465         * python/py-events.h: Rename include guard.
 466         * python/py-event.h: Rename include guard.
 467         * procfs.h: Add include guard.
 468         * proc-utils.h: Add include guard.
 469         * p-lang.h: Add include guard.
 470         * or1k-tdep.h: Rename include guard.
 471         * observable.h: Rename include guard.
 472         * nto-tdep.h: Rename include guard.
 473         * nat/x86-linux.h: Rename include guard.
 474         * nat/x86-linux-dregs.h: Rename include guard.
 475         * nat/x86-gcc-cpuid.h: Add include guard.
 476         * nat/x86-dregs.h: Rename include guard.
 477         * nat/x86-cpuid.h: Rename include guard.
 478         * nat/ppc-linux.h: Rename include guard.
 479         * nat/mips-linux-watch.h: Rename include guard.
 480         * nat/linux-waitpid.h: Rename include guard.
 481         * nat/linux-ptrace.h: Rename include guard.
 482         * nat/linux-procfs.h: Rename include guard.
 483         * nat/linux-osdata.h: Rename include guard.
 484         * nat/linux-nat.h: Rename include guard.
 485         * nat/linux-namespaces.h: Rename include guard.
 486         * nat/linux-btrace.h: Rename include guard.
 487         * nat/glibc_thread_db.h: Rename include guard.
 488         * nat/gdb_thread_db.h: Rename include guard.
 489         * nat/gdb_ptrace.h: Rename include guard.
 490         * nat/fork-inferior.h: Rename include guard.
 491         * nat/amd64-linux-siginfo.h: Rename include guard.
 492         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 493         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 494         * nat/aarch64-linux.h: Rename include guard.
 495         * nat/aarch64-linux-hw-point.h: Rename include guard.
 496         * mn10300-tdep.h: Add include guard.
 497         * mips-linux-tdep.h: Add include guard.
 498         * mi/mi-parse.h: Rename include guard.
 499         * mi/mi-out.h: Rename include guard.
 500         * mi/mi-main.h: Rename include guard.
 501         * mi/mi-interp.h: Rename include guard.
 502         * mi/mi-getopt.h: Rename include guard.
 503         * mi/mi-console.h: Rename include guard.
 504         * mi/mi-common.h: Rename include guard.
 505         * mi/mi-cmds.h: Rename include guard.
 506         * mi/mi-cmd-break.h: Rename include guard.
 507         * m2-lang.h: Add include guard.
 508         * location.h: Rename include guard.
 509         * linux-record.h: Rename include guard.
 510         * linux-nat.h: Add include guard.
 511         * linux-fork.h: Add include guard.
 512         * i386-darwin-tdep.h: Rename include guard.
 513         * hppa-linux-offsets.h: Add include guard.
 514         * guile/guile.h: Rename include guard.
 515         * guile/guile-internal.h: Rename include guard.
 516         * gnu-nat.h: Rename include guard.
 517         * gdb-stabs.h: Rename include guard.
 518         * frv-tdep.h: Add include guard.
 519         * f-lang.h: Add include guard.
 520         * event-loop.h: Add include guard.
 521         * darwin-nat.h: Rename include guard.
 522         * cp-abi.h: Rename include guard.
 523         * config/sparc/nm-sol2.h: Rename include guard.
 524         * config/nm-nto.h: Rename include guard.
 525         * config/nm-linux.h: Add include guard.
 526         * config/i386/nm-i386gnu.h: Rename include guard.
 527         * config/djgpp/nl_types.h: Rename include guard.
 528         * config/djgpp/langinfo.h: Rename include guard.
 529         * compile/gcc-cp-plugin.h: Add include guard.
 530         * compile/gcc-c-plugin.h: Add include guard.
 531         * compile/compile.h: Rename include guard.
 532         * compile/compile-object-run.h: Rename include guard.
 533         * compile/compile-object-load.h: Rename include guard.
 534         * compile/compile-internal.h: Rename include guard.
 535         * compile/compile-cplus.h: Rename include guard.
 536         * compile/compile-c.h: Rename include guard.
 537         * common/xml-utils.h: Rename include guard.
 538         * common/x86-xstate.h: Rename include guard.
 539         * common/version.h: Rename include guard.
 540         * common/vec.h: Rename include guard.
 541         * common/tdesc.h: Rename include guard.
 542         * common/selftest.h: Rename include guard.
 543         * common/scoped_restore.h: Rename include guard.
 544         * common/scoped_mmap.h: Rename include guard.
 545         * common/scoped_fd.h: Rename include guard.
 546         * common/safe-iterator.h: Rename include guard.
 547         * common/run-time-clock.h: Rename include guard.
 548         * common/refcounted-object.h: Rename include guard.
 549         * common/queue.h: Rename include guard.
 550         * common/ptid.h: Rename include guard.
 551         * common/print-utils.h: Rename include guard.
 552         * common/preprocessor.h: Rename include guard.
 553         * common/pathstuff.h: Rename include guard.
 554         * common/observable.h: Rename include guard.
 555         * common/netstuff.h: Rename include guard.
 556         * common/job-control.h: Rename include guard.
 557         * common/host-defs.h: Rename include guard.
 558         * common/gdb_wait.h: Rename include guard.
 559         * common/gdb_vecs.h: Rename include guard.
 560         * common/gdb_unlinker.h: Rename include guard.
 561         * common/gdb_unique_ptr.h: Rename include guard.
 562         * common/gdb_tilde_expand.h: Rename include guard.
 563         * common/gdb_sys_time.h: Rename include guard.
 564         * common/gdb_string_view.h: Rename include guard.
 565         * common/gdb_splay_tree.h: Rename include guard.
 566         * common/gdb_setjmp.h: Rename include guard.
 567         * common/gdb_ref_ptr.h: Rename include guard.
 568         * common/gdb_optional.h: Rename include guard.
 569         * common/gdb_locale.h: Rename include guard.
 570         * common/gdb_assert.h: Rename include guard.
 571         * common/filtered-iterator.h: Rename include guard.
 572         * common/filestuff.h: Rename include guard.
 573         * common/fileio.h: Rename include guard.
 574         * common/environ.h: Rename include guard.
 575         * common/common-utils.h: Rename include guard.
 576         * common/common-types.h: Rename include guard.
 577         * common/common-regcache.h: Rename include guard.
 578         * common/common-inferior.h: Rename include guard.
 579         * common/common-gdbthread.h: Rename include guard.
 580         * common/common-exceptions.h: Rename include guard.
 581         * common/common-defs.h: Rename include guard.
 582         * common/common-debug.h: Rename include guard.
 583         * common/cleanups.h: Rename include guard.
 584         * common/buffer.h: Rename include guard.
 585         * common/btrace-common.h: Rename include guard.
 586         * common/break-common.h: Rename include guard.
 587         * cli/cli-utils.h: Rename include guard.
 588         * cli/cli-style.h: Rename include guard.
 589         * cli/cli-setshow.h: Rename include guard.
 590         * cli/cli-script.h: Rename include guard.
 591         * cli/cli-interp.h: Rename include guard.
 592         * cli/cli-decode.h: Rename include guard.
 593         * cli/cli-cmds.h: Rename include guard.
 594         * charset-list.h: Add include guard.
 595         * buildsym-legacy.h: Rename include guard.
 596         * bfin-tdep.h: Add include guard.
 597         * ax.h: Rename include guard.
 598         * arm-linux-tdep.h: Add include guard.
 599         * arm-fbsd-tdep.h: Add include guard.
 600         * arch/xtensa.h: Rename include guard.
 601         * arch/tic6x.h: Add include guard.
 602         * arch/i386.h: Add include guard.
 603         * arch/arm.h: Rename include guard.
 604         * arch/arm-linux.h: Rename include guard.
 605         * arch/arm-get-next-pcs.h: Rename include guard.
 606         * arch/amd64.h: Add include guard.
 607         * arch/aarch64-insn.h: Rename include guard.
 608         * arch-utils.h: Rename include guard.
 609         * annotate.h: Add include guard.
 610         * amd64-darwin-tdep.h: Rename include guard.
 611         * aarch64-linux-tdep.h: Add include guard.
 612         * aarch64-fbsd-tdep.h: Add include guard.
 613         * aarch32-linux-nat.h: Add include guard.
 614
 615 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 616
 617         * macrotab.c (macro_define_internal): New function that
 618         factorizes macro_define_object_internal and macro_define_function
 619         code.
 620         (macro_define_object_internal): Use macro_define_internal.
 621         (macro_define_function): Likewise.
 622
 623 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 624
 625         * macrocmd.c (extract_identifier): Return
 626         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 627         callers.
 628
 629 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 630
 631         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 632
 633 2019-02-05  Tom Tromey  <tom@tromey.com>
 634
 635         * target.c (target_stack::unpush): Move assertion earlier.
 636
 637 2019-01-30  Tom Tromey  <tom@tromey.com>
 638
 639         PR python/23615:
 640         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 641         (gdbpy_parse_and_eval): Likewise.
 642         * python/python-internal.h (gdbpy_allow_threads): New class.
 643
 644 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 645
 646         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 647         (aarch64_fbsd_fpregmap): Move earlier.
 648         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 649         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 650         instead of individual calls to trad_frame_set_reg_addr.
 651         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 652         earlier.
 653         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 654         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 655         instead of individual calls to trad_frame_set_reg_addr.
 656
 657 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 658
 659         * CONTRIBUTE: Replace contribution list with wiki link.
 660
 661 2019-01-25  Tom Tromey  <tom@tromey.com>
 662
 663         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 664
 665 2019-01-25  Tom Tromey  <tom@tromey.com>
 666
 667         * xtensa-linux-nat.c: Fix common/ includes.
 668         * xml-support.h: Fix common/ includes.
 669         * xml-support.c: Fix common/ includes.
 670         * x86-linux-nat.c: Fix common/ includes.
 671         * windows-nat.c: Fix common/ includes.
 672         * varobj.h: Fix common/ includes.
 673         * varobj.c: Fix common/ includes.
 674         * value.c: Fix common/ includes.
 675         * valops.c: Fix common/ includes.
 676         * utils.c: Fix common/ includes.
 677         * unittests/xml-utils-selftests.c: Fix common/ includes.
 678         * unittests/utils-selftests.c: Fix common/ includes.
 679         * unittests/unpack-selftests.c: Fix common/ includes.
 680         * unittests/tracepoint-selftests.c: Fix common/ includes.
 681         * unittests/style-selftests.c: Fix common/ includes.
 682         * unittests/string_view-selftests.c: Fix common/ includes.
 683         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 684         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 685         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 686         * unittests/rsp-low-selftests.c: Fix common/ includes.
 687         * unittests/parse-connection-spec-selftests.c: Fix common/
 688         includes.
 689         * unittests/optional-selftests.c: Fix common/ includes.
 690         * unittests/offset-type-selftests.c: Fix common/ includes.
 691         * unittests/observable-selftests.c: Fix common/ includes.
 692         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 693         * unittests/memrange-selftests.c: Fix common/ includes.
 694         * unittests/memory-map-selftests.c: Fix common/ includes.
 695         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 696         * unittests/function-view-selftests.c: Fix common/ includes.
 697         * unittests/environ-selftests.c: Fix common/ includes.
 698         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 699         * unittests/common-utils-selftests.c: Fix common/ includes.
 700         * unittests/cli-utils-selftests.c: Fix common/ includes.
 701         * unittests/array-view-selftests.c: Fix common/ includes.
 702         * ui-file.c: Fix common/ includes.
 703         * tui/tui-io.c: Fix common/ includes.
 704         * tracepoint.h: Fix common/ includes.
 705         * tracepoint.c: Fix common/ includes.
 706         * tracefile-tfile.c: Fix common/ includes.
 707         * top.h: Fix common/ includes.
 708         * top.c: Fix common/ includes.
 709         * thread.c: Fix common/ includes.
 710         * target/waitstatus.h: Fix common/ includes.
 711         * target/waitstatus.c: Fix common/ includes.
 712         * target.h: Fix common/ includes.
 713         * target.c: Fix common/ includes.
 714         * target-memory.c: Fix common/ includes.
 715         * target-descriptions.c: Fix common/ includes.
 716         * symtab.h: Fix common/ includes.
 717         * symfile.c: Fix common/ includes.
 718         * stap-probe.c: Fix common/ includes.
 719         * spu-linux-nat.c: Fix common/ includes.
 720         * sparc-nat.c: Fix common/ includes.
 721         * source.c: Fix common/ includes.
 722         * solib.c: Fix common/ includes.
 723         * solib-target.c: Fix common/ includes.
 724         * ser-unix.c: Fix common/ includes.
 725         * ser-tcp.c: Fix common/ includes.
 726         * ser-pipe.c: Fix common/ includes.
 727         * ser-base.c: Fix common/ includes.
 728         * selftest-arch.c: Fix common/ includes.
 729         * s12z-tdep.c: Fix common/ includes.
 730         * rust-exp.y: Fix common/ includes.
 731         * rs6000-aix-tdep.c: Fix common/ includes.
 732         * riscv-tdep.c: Fix common/ includes.
 733         * remote.c: Fix common/ includes.
 734         * remote-notif.h: Fix common/ includes.
 735         * remote-fileio.h: Fix common/ includes.
 736         * remote-fileio.c: Fix common/ includes.
 737         * regcache.h: Fix common/ includes.
 738         * regcache.c: Fix common/ includes.
 739         * record-btrace.c: Fix common/ includes.
 740         * python/python.c: Fix common/ includes.
 741         * python/py-type.c: Fix common/ includes.
 742         * python/py-inferior.c: Fix common/ includes.
 743         * progspace.h: Fix common/ includes.
 744         * producer.c: Fix common/ includes.
 745         * procfs.c: Fix common/ includes.
 746         * proc-api.c: Fix common/ includes.
 747         * printcmd.c: Fix common/ includes.
 748         * ppc-linux-nat.c: Fix common/ includes.
 749         * parser-defs.h: Fix common/ includes.
 750         * osdata.c: Fix common/ includes.
 751         * obsd-nat.c: Fix common/ includes.
 752         * nat/x86-linux.c: Fix common/ includes.
 753         * nat/x86-linux-dregs.c: Fix common/ includes.
 754         * nat/x86-dregs.h: Fix common/ includes.
 755         * nat/x86-dregs.c: Fix common/ includes.
 756         * nat/ppc-linux.c: Fix common/ includes.
 757         * nat/mips-linux-watch.h: Fix common/ includes.
 758         * nat/mips-linux-watch.c: Fix common/ includes.
 759         * nat/linux-waitpid.c: Fix common/ includes.
 760         * nat/linux-ptrace.h: Fix common/ includes.
 761         * nat/linux-ptrace.c: Fix common/ includes.
 762         * nat/linux-procfs.c: Fix common/ includes.
 763         * nat/linux-personality.c: Fix common/ includes.
 764         * nat/linux-osdata.c: Fix common/ includes.
 765         * nat/linux-namespaces.c: Fix common/ includes.
 766         * nat/linux-btrace.h: Fix common/ includes.
 767         * nat/linux-btrace.c: Fix common/ includes.
 768         * nat/fork-inferior.c: Fix common/ includes.
 769         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 770         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 771         * nat/aarch64-linux.c: Fix common/ includes.
 772         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 773         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 774         * namespace.h: Fix common/ includes.
 775         * mips-linux-tdep.c: Fix common/ includes.
 776         * minsyms.c: Fix common/ includes.
 777         * mi/mi-parse.h: Fix common/ includes.
 778         * mi/mi-main.c: Fix common/ includes.
 779         * mi/mi-cmd-env.c: Fix common/ includes.
 780         * memrange.h: Fix common/ includes.
 781         * memattr.c: Fix common/ includes.
 782         * maint.h: Fix common/ includes.
 783         * maint.c: Fix common/ includes.
 784         * main.c: Fix common/ includes.
 785         * machoread.c: Fix common/ includes.
 786         * location.c: Fix common/ includes.
 787         * linux-thread-db.c: Fix common/ includes.
 788         * linux-nat.c: Fix common/ includes.
 789         * linux-fork.c: Fix common/ includes.
 790         * inline-frame.c: Fix common/ includes.
 791         * infrun.c: Fix common/ includes.
 792         * inflow.c: Fix common/ includes.
 793         * inferior.h: Fix common/ includes.
 794         * inferior.c: Fix common/ includes.
 795         * infcmd.c: Fix common/ includes.
 796         * inf-ptrace.c: Fix common/ includes.
 797         * inf-child.c: Fix common/ includes.
 798         * ia64-linux-nat.c: Fix common/ includes.
 799         * i387-tdep.c: Fix common/ includes.
 800         * i386-tdep.c: Fix common/ includes.
 801         * i386-linux-tdep.c: Fix common/ includes.
 802         * i386-linux-nat.c: Fix common/ includes.
 803         * i386-go32-tdep.c: Fix common/ includes.
 804         * i386-fbsd-tdep.c: Fix common/ includes.
 805         * i386-fbsd-nat.c: Fix common/ includes.
 806         * guile/scm-type.c: Fix common/ includes.
 807         * guile/guile.c: Fix common/ includes.
 808         * go32-nat.c: Fix common/ includes.
 809         * gnu-nat.c: Fix common/ includes.
 810         * gdbthread.h: Fix common/ includes.
 811         * gdbarch-selftests.c: Fix common/ includes.
 812         * gdb_usleep.c: Fix common/ includes.
 813         * gdb_select.h: Fix common/ includes.
 814         * gdb_bfd.c: Fix common/ includes.
 815         * gcore.c: Fix common/ includes.
 816         * fork-child.c: Fix common/ includes.
 817         * findvar.c: Fix common/ includes.
 818         * fbsd-nat.c: Fix common/ includes.
 819         * event-top.c: Fix common/ includes.
 820         * event-loop.c: Fix common/ includes.
 821         * dwarf2read.c: Fix common/ includes.
 822         * dwarf2loc.c: Fix common/ includes.
 823         * dwarf2-frame.c: Fix common/ includes.
 824         * dwarf-index-cache.c: Fix common/ includes.
 825         * dtrace-probe.c: Fix common/ includes.
 826         * disasm-selftests.c: Fix common/ includes.
 827         * defs.h: Fix common/ includes.
 828         * csky-tdep.c: Fix common/ includes.
 829         * cp-valprint.c: Fix common/ includes.
 830         * cp-support.h: Fix common/ includes.
 831         * cp-support.c: Fix common/ includes.
 832         * corelow.c: Fix common/ includes.
 833         * completer.h: Fix common/ includes.
 834         * completer.c: Fix common/ includes.
 835         * compile/compile.c: Fix common/ includes.
 836         * compile/compile-loc2c.c: Fix common/ includes.
 837         * compile/compile-cplus-types.c: Fix common/ includes.
 838         * compile/compile-cplus-symbols.c: Fix common/ includes.
 839         * command.h: Fix common/ includes.
 840         * cli/cli-dump.c: Fix common/ includes.
 841         * cli/cli-cmds.c: Fix common/ includes.
 842         * charset.c: Fix common/ includes.
 843         * build-id.c: Fix common/ includes.
 844         * btrace.h: Fix common/ includes.
 845         * btrace.c: Fix common/ includes.
 846         * breakpoint.h: Fix common/ includes.
 847         * breakpoint.c: Fix common/ includes.
 848         * ax.h:
 849         (enum agent_op): Fix common/ includes.
 850         * ax-general.c (struct aop_map): Fix common/ includes.
 851         * ax-gdb.c: Fix common/ includes.
 852         * auxv.c: Fix common/ includes.
 853         * auto-load.c: Fix common/ includes.
 854         * arm-tdep.c: Fix common/ includes.
 855         * arch/riscv.c: Fix common/ includes.
 856         * arch/ppc-linux-common.c: Fix common/ includes.
 857         * arch/i386.c: Fix common/ includes.
 858         * arch/arm.c: Fix common/ includes.
 859         * arch/arm-linux.c: Fix common/ includes.
 860         * arch/arm-get-next-pcs.c: Fix common/ includes.
 861         * arch/amd64.c: Fix common/ includes.
 862         * arch/aarch64.c: Fix common/ includes.
 863         * arch/aarch64-insn.c: Fix common/ includes.
 864         * arch-utils.c: Fix common/ includes.
 865         * amd64-windows-tdep.c: Fix common/ includes.
 866         * amd64-tdep.c: Fix common/ includes.
 867         * amd64-sol2-tdep.c: Fix common/ includes.
 868         * amd64-obsd-tdep.c: Fix common/ includes.
 869         * amd64-nbsd-tdep.c: Fix common/ includes.
 870         * amd64-linux-tdep.c: Fix common/ includes.
 871         * amd64-linux-nat.c: Fix common/ includes.
 872         * amd64-fbsd-tdep.c: Fix common/ includes.
 873         * amd64-fbsd-nat.c: Fix common/ includes.
 874         * amd64-dicos-tdep.c: Fix common/ includes.
 875         * amd64-darwin-tdep.c: Fix common/ includes.
 876         * agent.c: Fix common/ includes.
 877         * ada-lang.h: Fix common/ includes.
 878         * ada-lang.c: Fix common/ includes.
 879         * aarch64-tdep.c: Fix common/ includes.
 880
 881 2019-01-25  Tom Tromey  <tom@tromey.com>
 882
 883         * common/create-version.sh: Use common/version.h.
 884
 885 2019-01-24  Pedro Alves  <palves@redhat.com>
 886
 887         * infrun.c (signal_stop, signal_print, signal_program)
 888         (signal_catch, signal_pass): Now arrays instead of pointers.
 889         (update_signals_program_target, do_target_resume)
 890         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 891         * linux-nat.c (linux_nat_target::pass_signals)
 892         (linux_nat_target::create_inferior, linux_nat_target::attach):
 893         Adjust.
 894         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 895         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 896         * procfs.c (procfs_target::pass_signals): Adjust.
 897         * record-full.c (record_full_target::resume): Adjust.
 898         * remote.c (remote_target::pass_signals)
 899         (remote_target::program_signals): Adjust.
 900         * target-debug.h (target_debug_print_signals): Now takes a
 901         gdb::array_view as parameter.  Adjust.
 902         * target.h (target_ops) <pass_signals, program_signals>: Replace
 903         pointer and length parameters with gdb::array_view.
 904         (target_pass_signals, target_program_signals): Likewise.
 905         * target-delegates.c: Regenerate.
 906
 907 2019-01-24  Pedro Alves  <palves@redhat.com>
 908
 909         * common/forward-scope-exit.h
 910         (forward_scope_exit::forward_scope_exit): Pass arguments to
 911         m_bind_function directly, instead of creating a std::bind and
 912         copying that.
 913
 914 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 915
 916         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 917         for static members.
 918         (pass_in_v_vfp_candidate): Likewise.
 919
 920 2019-01-23  Tom Tromey  <tom@tromey.com>
 921             Pedro Alves  <palves@redhat.com>
 922
 923         * regcache.c (class regcache_invalidator): Remove.
 924         (regcache::raw_write): Use make_scope_exit.
 925
 926 2019-01-23  Tom Tromey  <tom@tromey.com>
 927
 928         * ui-out.h (class ui_out_emit_type): Update comment.
 929
 930 2019-01-23  Tom Tromey  <tom@tromey.com>
 931
 932         * infrun.c (fetch_inferior_event): Update comment.
 933
 934 2019-01-23  Tom Tromey  <tom@tromey.com>
 935             Pedro Alves  <palves@redhat.com>
 936
 937         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 938         parameter.
 939         (fetch_inferior_event): Use SCOPE_EXIT.
 940
 941
 942 2019-01-23  Tom Tromey  <tom@tromey.com>
 943             Pedro Alves  <palves@redhat.com>
 944
 945         * infrun.c (disable_thread_events): Delete.
 946         (stop_all_threads): Use SCOPE_EXIT.
 947
 948 2019-01-23  Tom Tromey  <tom@tromey.com>
 949             Pedro Alves  <palves@redhat.com>
 950
 951         * symfile.c: Include forward-scope-exit.h.
 952         (clear_symtab_users_cleanup): Replace forward declaration with
 953         a FORWARD_SCOPE_EXIT.
 954         (syms_from_objfile_1): Use the forward_scope_exit and
 955         gdb::optional instead of cleanup_function.
 956         (reread_symbols): Use the forward_scope_exit instead of
 957         cleanup_function.
 958         (clear_symtab_users_cleanup): Remove function.
 959
 960 2019-01-23  Tom Tromey  <tom@tromey.com>
 961             Pedro Alves  <palves@redhat.com>
 962
 963         * linux-nat.c: Include scope-exit.h.
 964         (cleanup_target_stop): Remove.
 965         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 966         SCOPE_EXIT.
 967
 968 2019-01-23  Tom Tromey  <tom@tromey.com>
 969             Pedro Alves  <palves@redhat.com>
 970
 971         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 972         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 973
 974 2019-01-23  Tom Tromey  <tom@tromey.com>
 975             Andrew Burgess  <andrew.burgess@embecosm.com>
 976             Pedro Alves  <palves@redhat.com>
 977
 978         * infrun.c (fetch_inferior_event): Use scope_exit.
 979         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 980         * top.c (execute_command): Use scope_exit.
 981         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 982         * utils.c (do_bpstat_clear_actions_cleanup)
 983         (make_bpstat_clear_actions_cleanup): Remove.
 984
 985 2019-01-23  Tom Tromey  <tom@tromey.com>
 986             Pedro Alves  <palves@redhat.com>
 987
 988         * infrun.c: Include "common/scope-exit.h"
 989         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 990         (wait_for_inferior): Use SCOPE_EXIT.
 991         (fetch_inferior_event): Use scope_exit.
 992
 993 2019-01-23  Tom Tromey  <tom@tromey.com>
 994             Pedro Alves  <palves@redhat.com>
 995
 996         * breakpoint.c (create_breakpoint): Remove cleanup.
 997
 998 2019-01-23  Tom Tromey  <tom@tromey.com>
 999             Andrew Burgess  <andrew.burgess@embecosm.com>
1000             Pedro Alves  <palves@redhat.com>
1001
1002 2019-01-23  Pedro Alves  <palves@redhat.com>
1003
1004         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1005
1006 2019-01-23  Pedro Alves  <palves@redhat.com>
1007             Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * gdbthread.h: Include "common/forward-scope-exit.h".
1010         (scoped_finish_thread_state): Redefine custom class in terms of
1011         forward_scope_exit.
1012
1013 2019-01-23  Pedro Alves  <palves@redhat.com>
1014             Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * common/forward-scope-exit.h: New file.
1017
1018 2019-01-23  Pedro Alves  <palves@redhat.com>
1019             Andrew Burgess  <andrew.burgess@embecosm.com>
1020             Tom Tromey  <tom@tromey.com>
1021
1022         * common/scope-exit.h: New file.
1023
1024 2019-01-23  Pedro Alves  <palves@redhat.com>
1025
1026         * common/preprocessor.h (ESC): Rename to ...
1027         (ESC_PARENS): ... this.
1028         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1029         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1030
1031 2019-01-23  Tom Tromey  <tom@tromey.com>
1032
1033         * language.h (class scoped_switch_to_sym_language_if_auto):
1034         Initialize m_lang in both cases.
1035
1036 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1037
1038         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1039         with XCNEW.
1040
1041 2019-01-22  Tom Tromey  <tom@tromey.com>
1042
1043         * corelow.c: Do not include sys/file.h.
1044
1045 2019-01-22  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-wingeneral.h: Include gdb_curses.h.
1048
1049 2019-01-22  Tom Tromey  <tom@tromey.com>
1050
1051         * source-cache.h (class source_cache) <get_source_lines,
1052         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1053
1054 2019-01-22  Tom Tromey  <tom@tromey.com>
1055
1056         * remote-fileio.h (struct remote_target): Declare.
1057
1058 2019-01-22  Tom Tromey  <tom@tromey.com>
1059
1060         * python/py-arch.c: Do not include py-ref.h.
1061         * python/py-bpevent.c: Do not include py-ref.h.
1062         * python/py-cmd.c: Do not include py-ref.h.
1063         * python/py-continueevent.c: Do not include py-ref.h.
1064         * python/py-event.h: Do not include py-ref.h.
1065         * python/py-evtregistry.c: Do not include py-ref.h.
1066         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1067         * python/py-frame.c: Do not include py-ref.h.
1068         * python/py-framefilter.c: Do not include py-ref.h.
1069         * python/py-function.c: Do not include py-ref.h.
1070         * python/py-infevents.c: Do not include py-ref.h.
1071         * python/py-linetable.c: Do not include py-ref.h.
1072         * python/py-objfile.c: Do not include py-ref.h.
1073         * python/py-param.c: Do not include py-ref.h.
1074         * python/py-prettyprint.c: Do not include py-ref.h.
1075         * python/py-progspace.c: Do not include py-ref.h.
1076         * python/py-symbol.c: Do not include py-ref.h.
1077         * python/py-symtab.c: Do not include py-ref.h.
1078         * python/py-type.c: Do not include py-ref.h.
1079         * python/py-unwind.c: Do not include py-ref.h.
1080         * python/py-utils.c: Do not include py-ref.h.
1081         * python/py-value.c: Do not include py-ref.h.
1082         * python/py-varobj.c: Do not include py-ref.h.
1083         * python/py-xmethods.c: Do not include py-ref.h.
1084         * python/python.c: Do not include py-ref.h.
1085         * varobj.c: Do not include py-ref.h.
1086
1087 2019-01-22  Tom Tromey  <tom@tromey.com>
1088
1089         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1090         keyword for bcache.
1091
1092 2019-01-22  Tom Tromey  <tom@tromey.com>
1093
1094         * compile/compile-cplus-types.c: Remove a comment by #include.
1095
1096 2019-01-22  Tom Tromey  <tom@tromey.com>
1097
1098         * compile/gcc-c-plugin.h: Include compile-internal.h.
1099
1100 2019-01-22  Tom Tromey  <tom@tromey.com>
1101
1102         * stabsread.c (EXTERN): Do not define.
1103         (symnum, next_symbol_text_func, processing_gcc_compilation)
1104         (within_function, global_sym_chain, global_stabs)
1105         (previous_stab_code, this_object_header_files)
1106         (n_this_object_header_files)
1107         (n_allocated_this_object_header_files): Define.
1108         * stabsread.h (EXTERN): Never define.  Use "extern".
1109
1110 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1111
1112         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1113         history_value.
1114
1115 2019-01-21  Tom Tromey  <tom@tromey.com>
1116
1117         * ui-out.c: Fix includes.
1118         * tui/tui-source.c: Fix includes.
1119         * target.c: Fix includes.
1120         * remote.c: Fix includes.
1121         * regcache.c: Fix includes.
1122         * python/py-block.c: Fix includes.
1123         * printcmd.c: Fix includes.
1124         * or1k-tdep.c: Fix includes.
1125         * mi/mi-main.c: Fix includes.
1126         * m32r-tdep.c: Fix includes.
1127         * csky-tdep.c: Fix includes.
1128         * compile/compile-cplus-types.c: Fix includes.
1129         * cli/cli-interp.c: Fix includes.
1130
1131 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1134         for padding.
1135
1136 2019-01-16  Tom Tromey  <tom@tromey.com>
1137
1138         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1139         earlier.
1140         (struct objfile) <msymbols_range>: Move from top level.
1141         <msymbols>: New method.
1142         (class objfile_msymbols): Remove.
1143         * symtab.c (default_collect_symbol_completion_matches_break_on):
1144         Update.
1145         * symmisc.c (dump_msymbols): Update.
1146         * stabsread.c (scan_file_globals): Update.
1147         * objc-lang.c (info_selectors_command, info_classes_command)
1148         (find_methods): Update.
1149         * minsyms.c (find_solib_trampoline_target): Update.
1150         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1151         * coffread.c (coff_symfile_read): Update.
1152         * ada-lang.c (ada_lookup_simple_minsym)
1153         (ada_collect_symbol_completion_matches): Update.
1154
1155 2019-01-16  Tom Tromey  <tom@tromey.com>
1156
1157         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1158         type.  Remove no-argument constructor.
1159         <iterator::operator++>: Simplify.
1160         <begin>: Update.
1161         <end>: Use minimal_symbol_count.
1162
1163 2019-01-16  Tom Tromey  <tom@tromey.com>
1164
1165         * objfiles.h (struct objfile) <psymtabs>: New method.
1166         (class objfile_psymtabs): Remove.
1167         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1168         typedef.
1169         <range>: New method.
1170         (require_partial_symbols): Change return type.
1171         * psymtab.c (require_partial_symbols)
1172         (psym_expand_symtabs_matching): Update.
1173         * mdebugread.c (parse_partial_symbols): Update.
1174         * dbxread.c (dbx_end_psymtab): Update.
1175
1176 2019-01-15  Tom Tromey  <tom@tromey.com>
1177
1178         * symtab.c (lookup_objfile_from_block)
1179         (lookup_symbol_in_objfile_symtabs)
1180         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1181         (find_line_symtab, info_sources_command)
1182         (default_collect_symbol_completion_matches_break_on)
1183         (make_source_files_completion_list): Update.
1184         * symmisc.c (print_objfile_statistics, dump_objfile)
1185         (maintenance_print_symbols, maintenance_info_symtabs)
1186         (maintenance_check_symtabs, maintenance_info_line_tables):
1187         Update.
1188         * source.c (select_source_symtab)
1189         (forget_cached_source_info_for_objfile): Update.
1190         * objfiles.h (class objfile_compunits): Remove.
1191         (struct objfile) <compunits_range>: New typedef.
1192         (compunits): New method.
1193         * objfiles.c (objfile_relocate1): Update.
1194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1195         * maint.c (count_symtabs_and_blocks): Update.
1196         * linespec.c (iterate_over_all_matching_symtabs): Update.
1197         * cp-support.c (add_symbol_overload_list_qualified): Update.
1198         * coffread.c (coff_symtab_read): Update.
1199         * ada-lang.c (add_nonlocal_symbols)
1200         (ada_collect_symbol_completion_matches)
1201         (ada_add_global_exceptions): Update.
1202
1203 2019-01-15  Tom Tromey  <tom@tromey.com>
1204
1205         * progspace.h (program_space) <objfiles_safe_range>: New
1206         typedef.
1207         <objfiles_safe>: New method.
1208         * objfiles.h (class all_objfiles_safe): Remove.
1209         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1210         * jit.c (jit_inferior_exit_hook): Update.
1211
1212 2019-01-17  Tom Tromey  <tom@tromey.com>
1213
1214         * progspace.h (program_space) <objfiles_range>: New typedef.
1215         <objfiles>: New method.
1216         <objfiles_head>: Rename from objfiles.
1217         (object_files): Update.
1218         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1219         * guile/scm-pretty-print.c
1220         (ppscm_find_pretty_printer_from_objfiles): Update.
1221         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1222         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1223         Update.
1224         * python/py-progspace.c (pspy_get_objfiles): Update.
1225         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1226         Update.
1227         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1228         (objfpy_lookup_objfile_by_build_id): Update.
1229         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1230         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1231         Update.
1232         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1233         (expand_symtab_containing_pc, lookup_objfile_from_block)
1234         (lookup_static_symbol, basic_lookup_transparent_type)
1235         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1236         (find_line_symtab, info_sources_command)
1237         (default_collect_symbol_completion_matches_break_on)
1238         (make_source_files_completion_list, find_main_name): Update.
1239         * symmisc.c (print_symbol_bcache_statistics)
1240         (print_objfile_statistics, maintenance_print_symbols)
1241         (maintenance_print_msymbols, maintenance_print_objfiles)
1242         (maintenance_info_symtabs, maintenance_check_symtabs)
1243         (maintenance_expand_symtabs, maintenance_info_line_tables):
1244         Update.
1245         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1246         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1247         (map_overlay_command, unmap_overlay_command)
1248         (simple_overlay_update, expand_symtabs_matching)
1249         (map_symbol_filenames): Update.
1250         * symfile-debug.c (set_debug_symfile): Update.
1251         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1252         Update.
1253         * source.c (select_source_symtab, forget_cached_source_info):
1254         Update.
1255         * solib.c (solib_read_symbols): Update.
1256         * solib-spu.c (append_ocl_sos): Update.
1257         * psymtab.c (maintenance_print_psymbols)
1258         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1259         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1260         * printcmd.c (info_symbol_command): Update.
1261         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1262         Update.
1263         * objfiles.h (class all_objfiles): Remove.
1264         * objfiles.c (have_partial_symbols, have_full_symbols)
1265         (have_minimal_symbols, qsort_cmp, update_section_map)
1266         (shared_objfile_contains_address_p)
1267         (default_iterate_over_objfiles_in_search_order): Update.
1268         * objc-lang.c (info_selectors_command, info_classes_command)
1269         (find_methods): Update.
1270         * minsyms.c (find_solib_trampoline_target): Update.
1271         * maint.c (maintenance_info_sections)
1272         (maintenance_translate_address, count_symtabs_and_blocks):
1273         Update.
1274         * main.c (captured_main_1): Update.
1275         * linux-thread-db.c (try_thread_db_load_from_pdir)
1276         (has_libpthread): Update.
1277         * linespec.c (iterate_over_all_matching_symtabs)
1278         (search_minsyms_for_name): Update.
1279         * jit.c (jit_find_objf_with_entry_addr): Update.
1280         * hppa-tdep.c (find_unwind_entry)
1281         (hppa_lookup_stub_minimal_symbol): Update.
1282         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1283         Update.
1284         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1285         (elf_gnu_ifunc_resolve_by_got): Update.
1286         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1287         * dwarf-index-write.c (save_gdb_index_command): Update.
1288         * cp-support.c (add_symbol_overload_list_qualified): Update.
1289         * breakpoint.c (create_overlay_event_breakpoint)
1290         (create_longjmp_master_breakpoint)
1291         (create_std_terminate_master_breakpoint)
1292         (create_exception_master_breakpoint): Update.
1293         * blockframe.c (find_pc_partial_function): Update.
1294         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1295         (ada_collect_symbol_completion_matches)
1296         (ada_add_global_exceptions): Update.
1297
1298 2019-01-17  Tom Tromey  <tom@tromey.com>
1299
1300         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1301         declare VEC.
1302         (solib_target_parse_libraries): Change return type.
1303         (library_list_start_segment, library_list_start_section)
1304         (library_list_end_library, library_list_start_library); Update.
1305         (solib_target_free_library_list): Remove.
1306         (solib_target_parse_libraries): Remove cleanup.  Change return
1307         type.
1308         (solib_target_current_sos): Update.
1309
1310 2019-01-17  Tom Tromey  <tromey@bapiya>
1311
1312         * valprint.c: Replace "the the" with "the".
1313         * symtab.c: Replace "the the" with "the".
1314         * solib.c: Replace "the the" with "the".
1315         * solib-dsbt.c: Replace "the the" with "the".
1316         * linespec.c: Replace "the the" with "the".
1317         * dwarf2loc.h: Replace "the the" with "the".
1318         * amd64-windows-tdep.c: Replace "the the" with "the".
1319         * aarch64-tdep.c: Replace "the the" with "the".
1320
1321 2019-01-16  Keith Seitz  <keiths@redhat.com>
1322
1323         PR gdb/23773
1324         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1325         <builder>: Rename to ..
1326         <m_builder>: ... this and make private.
1327         (dwarf2_cu::get_builder): New method.  Change all users of
1328         `builder' to use this method.
1329         (dwarf2_start_symtab): Move to ...
1330         (dwarf2_cu::start_symtab): ... here.  Update all callers
1331         (setup_type_unit_groups): Move to ...
1332         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1333         callers.
1334         (dwarf2_cu::reset_builder): New method.
1335         (process_full_compunit, process_full_type_unit): Use
1336         dwarf2_cu::reset_builder.
1337         (follow_die_offset): Record the ancestor CU if it is different
1338         from the followed DIE's CU.
1339         (follow_die_sig_1): Likewise.
1340
1341 2019-01-15  Tom Tromey  <tom@tromey.com>
1342
1343         * remote.c (class remote_state) <buf>: Now a char_vector.
1344         <buf_size>: Remove.
1345         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1346         parameter.
1347         (remote_target::getpkt_or_notif_sane_1)
1348         (remote_target::getpkt_sane)
1349         (remote_target::getpkt_or_notif_sane): Likewise.
1350         (class remote_target) <putpkt>: New overload.
1351         (remote_target::read_frame): Change type of "buf_p".  Remove
1352         sizeof_p parameter.
1353         (packet_ok): New overload.
1354         (packet_check_result): New overload.
1355         Update all uses.
1356
1357 2019-01-14  Tom Tromey  <tom@tromey.com>
1358
1359         * remote-notif.c (handle_notification, remote_notif_ack)
1360         (remote_notif_parse): Make "buf" const.
1361         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1362         const.
1363         (remote_notif_parse, remote_notif_ack, handle_notification):
1364         Likewise.
1365         * remote.c (remote_notif_stop_parse): Make "buf" const.
1366         (remote_target::remote_parse_stop_reply): Make "buf" const.
1367         (remote_notif_stop_ack): Make "buf" const.
1368
1369 2019-01-14  Tom Tromey  <tom@tromey.com>
1370
1371         * remote.c (remote_console_output): Make parameter const.
1372
1373 2019-01-14  Tom Tromey  <tom@tromey.com>
1374
1375         * target-debug.h (target_debug_print_signals): Constify.
1376         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1377         * procfs.c (procfs_target::pass_signals): Update.
1378         * linux-nat.c (linux_nat_target::pass_signals): Update.
1379         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1380         * target-delegates.c: Rebuild.
1381         * remote.c (remote_target::program_signals): Update.
1382         (remote_target::pass_signals): Update.
1383         * target.c (target_pass_signals): Constify argument.
1384         (target_program_signals): Likewise.
1385         * target.h (struct target_ops) <pass_signals, program_signals>:
1386         Constify argument.
1387         (target_pass_signals, target_program_signals): Constify argument.
1388
1389 2019-01-14  Tom Tromey  <tom@tromey.com>
1390
1391         PR tui/28819:
1392         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1393
1394 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1395
1396         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1397         field.
1398         * rs6000-tdep.c: Include reggroups.h.
1399         (IS_V_ALIAS_PSEUDOREG): Define.
1400         (rs6000_register_name): Return names for the "vX" aliases.
1401         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1402         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1403         aliases.  Call default_register_reggroup_p for all other
1404         pseudo-registers.
1405         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1406         New functions.
1407         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1408         Handle "vX" aliases.
1409         (v_alias_pseudo_register_collect): New function.
1410         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1411         (rs6000_gdbarch_init): Initialize "vX" aliases as
1412         pseudo-registers.  Restore registration of
1413         rs6000_pseudo_register_reggroup_p with
1414         set_tdesc_pseudo_register_reggroup_p.
1415
1416 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1417
1418         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1419         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1420         set_gdbarch_num_pseudo_regs.
1421
1422 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1423
1424         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1425         Remove arg prefixname, add do_set and do_show.
1426         Add member functions set_list and show_list.
1427         * cli/cli-style.c (class cli_style_option): Update accordingly.
1428         (style_set_list): Move to file scope.
1429         (style_show_list): Likewise.
1430         (set_style): Call help_list.
1431         (show_style): Call cmd_show_list.
1432         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1433         Update to use the new macro.
1434
1435 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1436
1437         * ada-lang.c (_initialize_ada_language): Expand the help text
1438         for the "catch exception" command.
1439
1440 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1441
1442         * symtab.c (matching_obj_sections): Initialize obj,
1443         declare it closer to its usage.
1444
1445 2019-01-10  Tom Tromey  <tom@tromey.com>
1446
1447         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1448         (basic_inf_threads_range): Remove.
1449         (inf_threads_range, inf_non_exited_threads_range)
1450         (safe_inf_threads_range): Use next_adapter.
1451
1452 2019-01-10  Keith Seitz  <keiths@redhat.com>
1453
1454         PR gdb/23712
1455         PR symtab/23010
1456         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1457         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1458
1459 2019-01-10  Keith Seitz  <keiths@redhat.com>
1460
1461         PR gdb/23712
1462         PR symtab/23010
1463         * dictionary.c (pending_to_vector): Remove.
1464         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1465         Remove _1 suffix, replacing functions of the same name.  Update
1466         all callers.
1467         (dict_create_hashed, dict_create_hashed_expandable)
1468         (dict_create_linear, dict_create_linear_expandable, dict_free)
1469         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1470         Make functions static.
1471
1472 2019-01-10  Keith Seitz  <keiths@redhat.com>
1473
1474         PR gdb/23712
1475         PR symtab/23010
1476         * dictionary.h (struct dictionary): Replace declaration with
1477         multidictionary.
1478         (dict_create_hashed, dict_create_hashed_expandable)
1479         (dict_create_linear, dict_create_linear_expandable)
1480         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1481         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1482         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1483         taking multidictionary argument.
1484         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1485         * block.h (struct block) <dict>: Change to multidictionary
1486         and rename `multidict'.
1487         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1488         symmisc.c: Update all dictionary references to multidictionary.
1489
1490 2019-01-10  Keith Seitz  <keiths@redhat.com>
1491
1492         PR gdb/23712
1493         PR symtab/23010
1494         * dictionary.c: Include unordered_map.
1495         (pending_to_vector): New function.
1496         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1497         Rewrite the non-"_1" functions to take vector instead
1498         of linked list.
1499         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1500         "new" _1 versions of the same name.
1501         (multidictionary): Define.
1502         (std::hash<enum language): New definition.
1503         (collate_pending_symbols_by_language, mdict_create_hashed)
1504         (mdict_create_hashed_expandable, mdict_create_linear)
1505         (mdict_create_linear_expandable, mdict_free)
1506         (find_language_dictionary, create_new_language_dictionary)
1507         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1508         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1509         (mdict_size, mdict_empty): New functions.
1510         * dictionary.h (mdict_iterator): Define.
1511
1512 2019-01-10  Pedro Alves  <palves@redhat.com>
1513
1514         * breakpoint.c (read_uploaded_action)
1515         (create_tracepoint_from_upload): Adjust to use
1516         gdb::unique_xmalloc_ptr.
1517         * ctf.c (ctf_write_uploaded_tp):
1518         (SET_ARRAY_FIELD): Use emplace_back.
1519         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1520         * tracefile-tfile.c (tfile_write_uploaded_tp):
1521         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1522         gdb::unique_xmalloc_ptr.
1523         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1524         at_string, cond_string, cmd_strings>: Replace char pointers
1525         with gdb::unique_xmalloc_ptr.
1526
1527 2019-01-10  Pedro Alves  <palves@redhat.com>
1528
1529         * solib-target.c (library_list_start_library): Don't xstrdup name.
1530
1531 2019-01-10  Pedro Alves  <palves@redhat.com>
1532
1533         * mdebugread.c (parse_partial_symbols): Use
1534         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1535
1536 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * linux-fork.c (scoped_switch_fork_info)
1539         <~scoped_switch_fork_info>: Fix incorrect variable name.
1540
1541 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * linux-fork.c (scoped_switch_fork_info)
1544         <scoped_switch_fork_info>: Make explicit.
1545         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1546
1547 2019-01-10  Tom Tromey  <tom@tromey.com>
1548
1549         * objfiles.h (objfile::reset_psymtabs): Update.
1550         * objfiles.c (objfile::objfile): Update.
1551         * psymtab.h (psymtab_storage::obstack): Update.
1552         (psymtab_storage::m_obstack): Use gdb::optional.
1553         (class psymtab_storage): Update comment.  Remove objfile
1554         parameter.
1555         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1556
1557 2019-01-10  Tom Tromey  <tom@tromey.com>
1558
1559         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1560         <free_psymtabs>: Now private.
1561         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1562         (allocate_psymtab): Use new method.
1563
1564 2019-01-10  Tom Tromey  <tom@tromey.com>
1565
1566         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1567         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1568         * mdebugread.c (parse_partial_symbols): Use
1569         allocate_dependencies.
1570         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1571         allocate_dependencies.
1572         (process_psymtab_comp_unit_reader)
1573         (build_type_psymtab_dependencies): Likewise.
1574         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1575
1576 2019-01-10  Tom Tromey  <tom@tromey.com>
1577
1578         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1579         PSYMBOL_SET_LANGUAGE.
1580         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1581
1582 2019-01-10  Tom Tromey  <tom@tromey.com>
1583
1584         * psymtab.h (psymtab_storage::obstack): New method.
1585         <m_obstack>: Rename from obstack; now private.
1586         * psymtab.c (psymtab_storage): Update.
1587         * dwarf2read.c (create_addrmap_from_index)
1588         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1589         Update.
1590
1591 2019-01-10  Tom Tromey  <tom@tromey.com>
1592
1593         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1594         * objfiles.h (objfile::reset_psymtabs): New method.
1595
1596 2019-01-10  Tom Tromey  <tom@tromey.com>
1597
1598         * symmisc.c (print_symbol_bcache_statistics): Update.
1599         (print_objfile_statistics): Update.
1600         * symfile.c (reread_symbols): Update.
1601         * psymtab.h (class psymtab_storage): New.
1602         * psymtab.c (psymtab_storage): New constructor.
1603         (~psymtab_storage): New destructor.
1604         (require_partial_symbols): Update.
1605         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1606         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1607         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1608         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1609         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1610         (start_psymtab_common, end_psymtab_common)
1611         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1612         (allocate_psymtab): Update.
1613         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1614         Update.
1615         (dump_psymtab_addrmap, maintenance_print_psymbols)
1616         (maintenance_check_psymtabs): Update.
1617         (class objfile_psymtabs): Move to objfiles.h.
1618         * psympriv.h (discard_psymtab): Now inline.
1619         (psymtab_discarder::psymtab_discarder): Update.
1620         (psymtab_discarder::~psymtab_discarder): Update.
1621         (ALL_OBJFILE_PSYMTABS): Rewrite.
1622         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1623         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1624         Remove fields.
1625         <partial_symtabs>: New field.
1626         (class objfile_psymtabs): Move from psymtab.h.  Update.
1627         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1628         psymbol_cache.
1629         (objfile::~objfile): Don't destroy psymbol_cache.
1630         * mdebugread.c (parse_partial_symbols): Update.
1631         * dwarf2read.c (create_addrmap_from_index)
1632         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1633         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1634         (add_partial_subprogram, dwarf2_ranges_read): Update.
1635         * dwarf-index-write.c (write_address_map)
1636         (write_one_signatured_type, recursively_write_psymbols)
1637         (class debug_names, class debug_names, write_psymtabs_to_index):
1638         Update.
1639
1640 2019-01-10  Tom Tromey  <tom@tromey.com>
1641
1642         * symtab.h (SYMBOL_SET_NAMES): Update.
1643         (symbol_set_names): Update.
1644         (MSYMBOL_SET_NAMES): Update.
1645         * symtab.c (symbol_set_names): Change argument to be an
1646         objfile_per_bfd_storage.
1647         * psymtab.c (add_psymbol_to_bcache): Update.
1648         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1649
1650 2019-01-10  Tom Tromey  <tom@tromey.com>
1651
1652         * symtab.c (create_demangled_names_hash): Change argument to be an
1653         objfile_per_bfd_storage.
1654         (symbol_set_names): Update.
1655
1656 2019-01-10  Tom Tromey  <tom@tromey.com>
1657
1658         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1659         init_psymbol_list.
1660         * psymtab.c (init_psymbol_list): Do nothing if already called.
1661         * psympriv.h (init_psymbol_list): Add comment.
1662         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1663         init_psymbol_list.
1664         * dbxread.c (dbx_symfile_read): Unconditionally call
1665         init_psymbol_list.
1666
1667 2019-01-10  Tom Tromey  <tom@tromey.com>
1668
1669         * xcoffread.c (scan_xcoff_symtab): Update.
1670         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1671         "where".
1672         * mdebugread.c (parse_partial_symbols)
1673         (handle_psymbol_enumerators): Update.
1674         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1675         * dbxread.c (read_dbx_symtab): Update.
1676         * psympriv.h (psymbol_placement): New enum.
1677         (add_psymbol_to_list): Update.
1678
1679 2019-01-10  Tom Tromey  <tom@tromey.com>
1680
1681         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1682         static_psymbols parameters.
1683         (scan_xcoff_symtab): Update.
1684         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1685         static_psymbols parameters.
1686         * psympriv.h (start_psymtab_common): Update.
1687         * mdebugread.c (parse_partial_symbols): Update.
1688         * dwarf2read.c (create_partial_symtab): Update.
1689         * dbxread.c (read_dbx_symtab): Update.
1690         (start_psymtab): Remove global_psymbols and static_psymbols
1691         parameters.
1692
1693 2019-01-10  Tom Tromey  <tom@tromey.com>
1694
1695         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1696         * psymtab.c (allocate_psymtab): Add comment.
1697         * psympriv.h (allocate_psymtab): Add comment.
1698         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1699         initializations.
1700         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1701
1702 2019-01-10  Tom Tromey  <tom@tromey.com>
1703
1704         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1705         Don't declare.
1706         * mipsread.c: Include mdebugread.h.
1707         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1708         Declare.
1709         * elfread.c: Include mdebugread.h.
1710
1711 2019-01-09  Tom Tromey  <tom@tromey.com>
1712
1713         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1714         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1715         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1716         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1717         (psym_lookup_symbol, psym_find_last_source_symtab)
1718         (psym_forget_cached_source_info, psym_print_stats)
1719         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1720         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1721         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1722         (psym_find_compunit_symtab_by_address)
1723         (maintenance_print_psymbols, maintenance_info_psymtabs)
1724         (maintenance_check_psymtabs): Use ranged for.
1725         * psymtab.h (class objfile_psymtabs): New.
1726         (require_partial_symbols): Return objfile_psymtabs.
1727         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1728
1729 2019-01-09  Tom Tromey  <tom@tromey.com>
1730
1731         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1732         (find_pc_mapped_section, list_overlays_command)
1733         (map_overlay_command, unmap_overlay_command)
1734         (simple_overlay_update): Use all_objfiles.
1735         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1736         * printcmd.c (info_symbol_command): Use all_objfiles.
1737         * objfiles.h (ALL_OBJSECTIONS): Remove.
1738         * maint.c (maintenance_translate_address): Use all_objfiles.
1739         * gcore.c (gcore_create_callback): Use all_objfiles.
1740         (objfile_find_memory_regions): Likewise.
1741
1742 2019-01-09  Tom Tromey  <tom@tromey.com>
1743
1744         * symtab.c (find_line_symtab, info_sources_command)
1745         (make_source_files_completion_list): Use objfile_compunits.
1746         * source.c (select_source_symtab): Use objfile_compunits.
1747         * objfiles.h (struct objfile): Update comment.
1748         (ALL_OBJFILES): Remove.
1749         (ALL_FILETABS): Remove.
1750         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1751         objfile_compunits.
1752
1753 2019-01-09  Tom Tromey  <tom@tromey.com>
1754
1755         * symmisc.c (print_objfile_statistics, dump_objfile)
1756         (maintenance_print_symbols): Use compunit_filetabs.
1757         * source.c (forget_cached_source_info_for_objfile): Use
1758         compunit_filetabs.
1759         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1760         (ALL_FILETABS): Use compunit_filetabs.
1761         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1762         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1763
1764 2019-01-09  Tom Tromey  <tom@tromey.com>
1765
1766         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1767         (compunit_filetabs): New.
1768         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1769         compunit_filetabs.
1770         (info_sources_command, make_source_files_completion_list): Remove
1771         declaration.
1772         * symmisc.c (print_objfile_statistics, dump_objfile)
1773         (maintenance_print_symbols): Remove declaration.
1774         (maintenance_info_symtabs): Use compunit_filetabs.
1775         (maintenance_info_line_tables): Likewise.
1776         * source.c (select_source_symtab): Change local variable name.
1777         (forget_cached_source_info_for_objfile): Remove declaration.
1778         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1779         * objfiles.c (objfile_relocate1): Remove declaration.
1780         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1781         declaration.
1782         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1783         * coffread.c (coff_symtab_read): Remove declaration.
1784         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1785         compunit_filetabs.
1786
1787 2019-01-09  Tom Tromey  <tom@tromey.com>
1788
1789         * symtab.c (lookup_objfile_from_block)
1790         (find_pc_sect_compunit_symtab, search_symbols)
1791         (default_collect_symbol_completion_matches_break_on): Use
1792         objfile_compunits.
1793         * objfiles.h (ALL_COMPUNITS): Remove.
1794         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1795         * cp-support.c (add_symbol_overload_list_qualified): Use
1796         objfile_compunits.
1797         * ada-lang.c (ada_collect_symbol_completion_matches)
1798         (ada_add_global_exceptions): Use objfile_compunits.
1799
1800 2019-01-09  Tom Tromey  <tom@tromey.com>
1801
1802         * source.c (select_source_symtab)
1803         (forget_cached_source_info_for_objfile): Remove declaration.
1804         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1805         declaration.
1806         * maint.c (count_symtabs_and_blocks): Remove declaration.
1807         * cp-support.c (add_symbol_overload_list_qualified): Remove
1808         declaration.
1809         * coffread.c (coff_symtab_read): Remove declaration.
1810         * symtab.c (lookup_symbol_in_objfile_symtabs)
1811         (basic_lookup_transparent_type_1): Use objfile_compunits.
1812         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1813         (info_sources_command, search_symbols)
1814         (default_collect_symbol_completion_matches_break_on)
1815         (make_source_files_completion_list): Remove declaration.
1816         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1817         (ada_collect_symbol_completion_matches)
1818         (ada_add_global_exceptions): Remove declaration.
1819         * linespec.c (iterate_over_all_matching_symtabs): Use
1820         objfile_compunits.
1821         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1822         (class objfile_compunits): New.
1823         (ALL_COMPUNITS): Use objfile_compunits.
1824         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1825         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1826         objfile_compunits.
1827         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1828
1829 2019-01-09  Tom Tromey  <tom@tromey.com>
1830
1831         * symtab.c (search_symbols)
1832         (default_collect_symbol_completion_matches_break_on): Use
1833         objfile_msymbols.
1834         * ada-lang.c (ada_lookup_simple_minsym)
1835         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1836         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1837         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1838         objfile_msymbols.
1839         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1840         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1841         * objc-lang.c (find_methods): Use objfile_msymbols.
1842         (info_selectors_command, info_classes_command): Likewise.
1843         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1844         * objfiles.h (class objfile_msymbols): New.
1845         (ALL_OBJFILE_MSYMBOLS): Remove.
1846         (ALL_MSYMBOLS): Remove.
1847
1848 2019-01-09  Tom Tromey  <tom@tromey.com>
1849
1850         * common/next-iterator.h (next_adapter): Add Iterator template
1851         parameter.
1852         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1853         (class all_objfiles_safe): New.
1854         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1855         * objfiles.c (put_objfile_before): Update comment.
1856         (add_separate_debug_objfile): Likewise.
1857         (free_all_objfiles): Use all_objfiles_safe.
1858         (objfile_purge_solibs): Likewise.
1859
1860 2019-01-09  Tom Tromey  <tom@tromey.com>
1861
1862         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1863         (expand_symtab_containing_pc, lookup_static_symbol)
1864         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1865         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1866         all_objfiles.
1867         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1868         * breakpoint.c (create_overlay_event_breakpoint)
1869         (create_longjmp_master_breakpoint)
1870         (create_std_terminate_master_breakpoint)
1871         (create_exception_master_breakpoint): Use all_objfiles.
1872         * linux-thread-db.c (try_thread_db_load_from_pdir)
1873         (has_libpthread): Use all_objfiles.
1874         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1875         * linespec.c (iterate_over_all_matching_symtabs)
1876         (search_minsyms_for_name): Use all_objfiles.
1877         * maint.c (maintenance_info_sections): Use all_objfiles.
1878         * main.c (captured_main_1): Use all_objfiles.
1879         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1880         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1881         * guile/scm-pretty-print.c
1882         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1883         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1884         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1885         (maintenance_print_msymbols): Use all_objfiles.
1886         * source.c (select_source_symtab): Use all_objfiles.
1887         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1888         * symfile.c (remove_symbol_file_command)
1889         (expand_symtabs_matching, map_symbol_filenames): Use
1890         all_objfiles.
1891         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1892         all_objfiles.
1893         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1894         * objc-lang.c (find_methods): Use all_objfiles.
1895         * objfiles.c (have_partial_symbols, have_full_symbols)
1896         (have_minimal_symbols, qsort_cmp)
1897         (default_iterate_over_objfiles_in_search_order): Use
1898         all_objfiles.
1899         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1900         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1901         (maintenance_check_psymtabs): Use all_objfiles.
1902         (ALL_PSYMTABS): Remove.
1903         * compile/compile-object-run.c (do_module_cleanup): Use
1904         all_objfiles.
1905         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1906         * cp-support.c (add_symbol_overload_list_qualified): Use
1907         all_objfiles.
1908         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1909         Use all_objfiles.
1910         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1911         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1912         all_objfiles.
1913         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1914         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1915         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1916         Uses all_objfiles.
1917         * solib.c (solib_read_symbols): Use all_objfiles
1918
1919 2019-01-09  Tom Tromey  <tom@tromey.com>
1920
1921         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1922         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1923         all_objfiles.
1924         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1925         * symmisc.c (print_symbol_bcache_statistics)
1926         (print_objfile_statistics, maintenance_print_objfiles)
1927         (maintenance_info_symtabs, maintenance_check_symtabs)
1928         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1929         all_objfiles.
1930         * source.c (forget_cached_source_info): Use all_objfiles.
1931         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1932         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1933         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1934         * objfiles.c (update_section_map): Use all_objfiles.
1935         (shared_objfile_contains_address_p): Likewise.
1936         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1937         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1938
1939 2019-01-09  Tom Tromey  <tom@tromey.com>
1940
1941         * common/next-iterator.h: New file.
1942         * objfiles.h (class all_objfiles): New.
1943         (struct objfile_iterator): New.
1944
1945 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1946
1947         * NEWS: Move the description of the changed "frame", "select-frame",
1948          and "info frame" commands to the Changed commands section.
1949
1950 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1951
1952         * gdbtypes.c (check_stub_method_group): Remove handling of old
1953         mangling schemes.
1954         * linespec.c (find_methods): Likewise.
1955         * stabsread.c (read_member_functions): Likewise.
1956         * valops.c (search_struct_method): Likewise.
1957         (value_struct_elt_for_reference): Likewise.
1958         * NEWS: Mention this change.
1959
1960 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1961
1962         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1963         print_source_lines.
1964         * source.c (print_source_lines_base): Update line number check.
1965         (print_source_lines): New function.
1966         (source_lines_range::source_lines_range): New function.
1967         * source.h (class source_lines_range): New class.
1968         (print_source_lines): New declaration.
1969
1970 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1971
1972         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1973
1974 2019-01-08  Tom Tromey  <tom@tromey.com>
1975             Simon Marchi  <simon.marchi@ericsson.com>
1976
1977         PR gdb/24060
1978         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1979         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1980         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1981         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1982         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1983         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1984
1985 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * source.c (select_source_symtab): Move header comment to
1988         declaration in source.h.
1989         (forget_cached_source_info_for_objfile): Likewise.
1990         (forget_cached_source_info): Likewise.
1991         (identify_source_line): Likewise.
1992         * source.h (identify_source_line): Move declaration from symtab.h
1993         and add comment from source.c
1994         (print_source_lines): Likewise.
1995         (forget_cached_source_info_for_objfile): Likewise.
1996         (forget_cached_source_info): Likewise.
1997         (select_source_symtab): Likewise.
1998         (enum print_source_lines_flag): Move definition from symtab.h.
1999         * symtab.h (identify_source_line): Move declaration to source.h.
2000         (print_source_lines): Likewise.
2001         (forget_cached_source_info_for_objfile): Likewise.
2002         (forget_cached_source_info): Likewise.
2003         (select_source_symtab): Likewise.
2004         (enum print_source_lines_flag): Move definition to source.h.
2005         * tui/tui-hooks.c: Add 'source.h' include.
2006
2007 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2008
2009         * source.c (print_source_lines_base): Handle requests to print
2010         reverse line number sequences, and guard against empty lines
2011         string.
2012
2013 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         * source.c (print_source_lines_base): Fix skip of '\r' if next
2016         character is '\n'.
2017
2018 2019-01-06  Tom Tromey  <tom@tromey.com>
2019
2020         * c-exp.y (struct c_parse_state) <macro_original_text,
2021         expansion_obstack>: New member.
2022         (macro_original_text, expansion_obstack): Remove globals.
2023         (scan_macro_expansion, scanning_macro_expansion)
2024         (finished_macro_expansion): Update.
2025         (scan_macro_cleanup): Remove.
2026         (yylex, c_parse): Update.
2027
2028 2019-01-06  Tom Tromey  <tom@tromey.com>
2029
2030         * c-exp.y (struct c_parse_state) <strings>: New member.
2031         (operator_stoken): Update.
2032
2033 2019-01-06  Tom Tromey  <tom@tromey.com>
2034
2035         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2036         (union type_stack_elt) <typelist_val>: Now a pointer to
2037         std::vector.
2038         (type_stack_cleanup): Don't declare.
2039         (push_typelist): Update.
2040         * parse.c (pop_typelist): Return a std::vector.
2041         (push_typelist): Take a std::vector.
2042         (follow_types): Update.  Do not free args.
2043         (type_stack_cleanup): Remove.
2044         * c-exp.y (struct c_parse_state): New.
2045         (cpstate): New global.
2046         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2047         (nonempty_typelist): Update.
2048         (func_mod): Create a new vector.
2049         (c_parse): Create a c_parse_state.
2050         (check_parameter_typelist): Do not delete params.
2051         (function_method): Update.  Do not delete type_list.
2052
2053 2019-01-06  Tom Tromey  <tom@tromey.com>
2054
2055         PR gdb/28155:
2056         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2057         check_typedef.
2058         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2059         (print_return_value): Likewise.
2060
2061 2019-01-05  Tom Tromey  <tom@tromey.com>
2062
2063         * contrib/cleanup_check.py: Remove.
2064         * contrib/gcc-with-excheck: Remove.
2065         * contrib/exsummary.py: Remove.
2066         * contrib/excheck.py: Remove.
2067
2068 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2069
2070         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2071         NULL. Initialize tpprev to NULL instead of assigning it
2072         to NULL on the next statement.
2073         * windows-nat.c (windows_delete_thread): Remove check for
2074         main_thread_id before printing thread exit notifications.
2075         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2076         Remove thread ID check against main_thread_id.
2077         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2078         windows_delete_thread.
2079         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2080
2081 2019-01-04  Tom Tromey  <tom@tromey.com>
2082
2083         * compile/compile.c (_initialize_compile): Use upper case for
2084         metasyntactic variables.
2085         * symmisc.c (_initialize_symmisc): Use upper case for
2086         metasyntactic variables.
2087         * psymtab.c (_initialize_psymtab): Use upper case for
2088         metasyntactic variables.
2089         * demangle.c (demangle_command): Use upper case for metasyntactic
2090         variables.
2091         (_initialize_demangler): Likewise.
2092         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2093         variables.
2094
2095 2019-01-03  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2098
2099 2019-01-03  Tom Tromey  <tom@tromey.com>
2100
2101         * python/py-symtab.c (salpy_str): Update.
2102         (struct salpy_sal_object) <symtab>: Now a PyObject.
2103         (salpy_dealloc): Update.
2104         (del_objfile_sal): Use gdbpy_ref.
2105
2106 2019-01-03  Tom Tromey  <tom@tromey.com>
2107
2108         * python/py-type.c (convert_field): Use new_reference.  Return
2109         gdbpy_ref.
2110         (make_fielditem): Return gdbpy_ref.
2111         (typy_fields): Update.
2112         (typy_getitem): Update.
2113         (field_name): Return gdbpy_ref.  Use new_reference.
2114         (typy_iterator_iternext): Update.
2115
2116 2019-01-03  Tom Tromey  <tom@tromey.com>
2117
2118         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2119
2120 2019-01-03  Tom Tromey  <tom@tromey.com>
2121
2122         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2123         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2124         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2125         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2126         (pspy_set_type_printers): Likewise.
2127         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2128         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2129         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2130         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2131         (objfpy_set_type_printers): Likewise.
2132
2133 2019-01-03  Tom Tromey  <tom@tromey.com>
2134
2135         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2136         (gdbpy_print_stack): Use gdbpy_err_fetch.
2137         * python/python-internal.h (class gdbpy_err_fetch): New class.
2138         (class gdbpy_enter) <m_error_type, m_error_value,
2139         m_error_traceback>: Remove.
2140         <m_error>: New member.
2141         (gdbpy_exception_to_string): Don't declare.
2142         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2143         * python/py-value.c (convert_value_from_python): Use
2144         gdbpy_err_fetch.
2145         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2146         gdbpy_exception_to_string.
2147         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2148         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2149         gdbpy_err_fetch.
2150
2151 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * linux-nat.c (delete_lwp_cleanup): Delete.
2154         (struct lwp_deleter): New struct.
2155         (lwp_info_up): New typedef.
2156         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2157         lwp_info_up.
2158
2159 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2160
2161         * linux-fork.c (class scoped_switch_fork_info): New class.
2162         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2163
2164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * valops.c (find_overload_match): Remove use of null_cleanup, and
2167         calls to do_cleanups.
2168
2169 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * compile/compile-cplus-types.c
2172         (compile_cplus_instance::decl_name): Handle changes to
2173         cp_func_name.
2174         * cp-support.c (cp_func_name): Update header comment, update
2175         return type.
2176         * cp-support.h (cp_func_name): Update return type in declaration.
2177         * valops.c (find_overload_match): Move temp_func local to top
2178         level of function and change its type.  Use temp_func to hold and
2179         delete temporary string obtained from cp_func_name.
2180
2181 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2184         gdb::char_vector, remove cleanup, and update uses of `msg`.
2185
2186 2019-01-03  Jim Wilson  <jimw@sifive.com>
2187
2188         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2189
2190 2019-01-02  Tom Tromey  <tom@tromey.com>
2191
2192         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2193         (tdesc_parse_xml): Remove cleanups.
2194         * target-descriptions.h (make_cleanup_free_target_description):
2195         Don't declare.
2196         (target_desc_deleter): New struct.
2197         (target_desc_up): New typedef.
2198         * target-descriptions.c (target_desc_deleter::operator()): Rename
2199         from free_target_description.
2200         (make_cleanup_free_target_description): Remove.
2201
2202 2019-01-02  Tom Tromey  <tom@tromey.com>
2203
2204         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2205         constructor, destructor.
2206         (linespec_parser): Remove typedef.
2207         (~linespec_parser): Rename from linespec_parser_delete.
2208         (linespec_lex_to_end, linespec_complete_label)
2209         (linespec_complete): Update.
2210         (decode_line_full): Remove cleanups.
2211         (decode_line_1): Update.
2212
2213 2019-01-02  Tom Tromey  <tom@tromey.com>
2214
2215         * python/python-internal.h (inferior_to_inferior_object): Change
2216         return type.
2217         * python/py-exitedevent.c (create_exited_event_object): Update.
2218         * python/py-inferior.c (inferior_to_inferior_object): Return
2219         gdbpy_ref.
2220         (python_new_inferior, python_inferior_deleted)
2221         (thread_to_thread_object, delete_thread_object)
2222         (build_inferior_list, gdbpy_selected_inferior): Update.
2223         * python/py-infthread.c (create_thread_object): Update.  Also fail
2224         if inferior_to_inferior_object fails.
2225
2226 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2227
2228         * inferior.h (class inferior) <displaced_step_state>: New field.
2229         * infrun.h (struct displaced_step_state): Move here from
2230         infrun.c.  Initialize fields, add constructor.
2231         <inf>: Remove field.
2232         <reset>: New method.
2233         * infrun.c (struct displaced_step_inferior_state): Move to
2234         infrun.h.
2235         (displaced_step_inferior_states): Remove.
2236         (get_displaced_stepping_state): Adust.
2237         (displaced_step_in_progress_any_inferior): Adjust.
2238         (displaced_step_in_progress_thread): Adjust.
2239         (displaced_step_in_progress): Adjust.
2240         (add_displaced_stepping_state): Remove.
2241         (get_displaced_step_closure_by_addr): Adjust.
2242         (remove_displaced_stepping_state): Remove.
2243         (infrun_inferior_exit): Call displaced_step_state.reset.
2244         (use_displaced_stepping): Don't check for NULL.
2245         (displaced_step_prepare_throw): Call
2246         get_displaced_stepping_state.
2247         (displaced_step_fixup): Don't check for NULL.
2248         (prepare_for_detach): Don't check for NULL.
2249
2250 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2251
2252         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2253          in case of call that did not complete.
2254
2255 2019-01-02  Andrey Utkin  <autkin@undo.io>
2256
2257         * symfile.c (find_separate_debug_file): Fix search of debug files for
2258         remote debuggee.
2259
2260 2019-01-02  Tom Tromey  <tom@tromey.com>
2261
2262         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2263         indentation.
2264         * python/py-frame.c (frapy_older): Remove cast.
2265         (frapy_newer): Likewise.
2266         * python/py-breakpoint.c (local_setattro): Remove cast.
2267         * python/py-arch.c (archpy_name): Remove local variable.
2268         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2269
2270 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2271
2272         * unittests/basic_string_view/element_access/char/empty.cc:
2273         Fix year range in copyright header.
2274
2275 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2278         Delete.
2279         <operator==>: Update with for removed field.
2280         <hash>: Likewise.
2281         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2282         <isa_features>: ...this.
2283         <abi_features>: New field.
2284         (riscv_isa_flen): Update comment.
2285         (riscv_abi_xlen): New declaration.
2286         (riscv_abi_flen): New declaration.
2287         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2288         isa_features.
2289         (riscv_abi_xlen): New function.
2290         (riscv_isa_flen): Update to get answer from isa_features.
2291         (riscv_abi_flen): New function.
2292         (riscv_has_fp_abi): Update to get answer from abi_features.
2293         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2294         xlen and flen.
2295         (riscv_call_info) <xlen, flen>: Update comment.
2296         (riscv_call_arg_struct): Remove invalid assertions
2297         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2298         is removed.
2299         (riscv_gdbarch_init): Gather isa features and abi features
2300         separately, ensure both match on the gdbarch when reusing an old
2301         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2302         a target with 64-bit float hardware.
2303
2304 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2305
2306         * source.c (search_command_helper): Stop reverse search
2307         when line 1 has been searched.
2308
2309 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2310
2311         * record-full.c (record_full_base_target::close): Rewrite
2312         record_full_core_buf_list free logic.
2313
2314 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2315
2316         * break-catch-syscall.c (print_one_catch_syscall): xfree
2317         the last text.
2318
2319 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2320
2321         * top.c (print_gdb_version): Update Copyright year in version
2322         message.
2323
2324 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2325
2326         Update copyright year range in all GDB files.
2327
2328 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2329
2330         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2331
2332 For older changes see ChangeLog-2018.
2333 \f
2334 Local Variables:
2335 mode: change-log
2336 left-margin: 8
2337 fill-column: 74
2338 version-control: never
2339 coding: utf-8
2340 End:
2341