gdb/ChangeLog

   1 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * f-typeprint.c (f_print_type): Update rules for printing
   4         whitespace.
   5         (f_type_print_varspec_suffix): Likewise.
   6
   7 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   8             Chris January  <chris.january@arm.com>
   9
  10         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  11         function arguments.
  12
  13 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  14
  15         * f-lang.c (build_fortran_types): Change name of void type to
  16         lower case.
  17         * f-typeprint.c (f_type_print_base): Print the name of the void
  18         type, rather than a fixed string.
  19         * f-valprint.c (f_decorations): Use lower case void string.
  20
  21 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  22             Chris January  <chris.january@arm.com>
  23
  24         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  25         types for Fortran.
  26
  27 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  28             Chris January  <chris.january@arm.com>
  29             David Lecomber  <david.lecomber@arm.com>
  30
  31         * f-exp.y (BINOP_INTRINSIC): New token.
  32         (exp): New parser rule handling BINOP_INTRINSIC.
  33         (f77_keywords): Add new builtin procedures.
  34         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  35         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  36         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  37         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  38         (print_unop_subexp_f): New function.
  39         (print_binop_subexp_f): New function.
  40         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  41         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  42         (dump_subexp_body_f): Likewise.
  43         (operator_check_f): Likewise.
  44         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  45         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  46
  47 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  50         UNOP_KIND.
  51         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  52         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  53         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  54         (operator_length_f): New fuction.
  55         (print_subexp_f): New function.
  56         (op_name_f): New function.
  57         (dump_subexp_body_f): New function.
  58         (operator_check_f): New function.
  59         (exp_descriptor_f): Replace standard expression handling functions
  60         with new functions.
  61         * gdb/fortran-operator.def: New file.
  62         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
  63         * gdb/std-operator.def: Remove UNOP_KIND.
  64
  65 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  66
  67         * std-operator.def: Remove unbalanced, stray double quote
  68         character.
  69
  70 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  71             Chris January  <chris.january@arm.com>
  72             Daniel Everett  <daniel.everett@arm.com>
  73             Nick Forrington  <nick.forrington@arm.com>
  74             Richard Bunt  <richard.bunt@arm.com>
  75
  76         * cp-valprint.c (cp_print_value_fields): Allow an additional level
  77         of depth when printing anonymous structs or unions.
  78         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
  79         Don't print either the top-level value, or the children if the
  80         max-depth is exceeded.
  81         (ppscm_print_children): When printing the key of a map, allow one
  82         extra level of depth.
  83         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
  84         print either the top-level value, or the children if the max-depth
  85         is exceeded.
  86         (print_children): When printing the key of a map, allow one extra
  87         level of depth.
  88         * python/py-value.c (valpy_format_string): Add max_depth keyword.
  89         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
  90         (user_print_options): Initialise max_depth field.
  91         (val_print_scalar_or_string_type_p): New function.
  92         (val_print): Check to see if the max depth has been reached.
  93         (val_print_check_max_depth): Define new function.
  94         (show_print_max_depth): New function.
  95         (_initialize_valprint): Add 'print max-depth' option.
  96         * valprint.h (struct value_print_options) <max_depth>: New field.
  97         (val_print_check_max_depth): Declare new function.
  98         * NEWS: Document new feature.
  99
 100 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         * ada-lang.c (ada_language_defn): Initialise new field.
 103         * c-lang.c (c_is_string_type_p): New function.
 104         (c_language_defn): Initialise new field.
 105         (cplus_language_defn): Initialise new field.
 106         (asm_language_defn): Initialise new field.
 107         (minimal_language_defn): Initialise new field.
 108         * c-lang.h (c_is_string_type_p): Declare new function.
 109         * d-lang.c (d_language_defn): Initialise new field.
 110         * f-lang.c (f_is_string_type_p): New function.
 111         (f_language_defn): Initialise new field.
 112         * go-lang.c (go_is_string_type_p): New function.
 113         (go_language_defn): Initialise new field.
 114         * language.c (default_is_string_type_p): New function.
 115         (unknown_language_defn): Initialise new field.
 116         (auto_language_defn): Initialise new field.
 117         * language.h (struct language_defn) <la_is_string_type_p>: New
 118         member variable.
 119         (default_is_string_type_p): Declare new function.
 120         * m2-lang.c (m2_language_defn): Initialise new field.
 121         * objc-lang.c (objc_language_defn): Initialise new field.
 122         * opencl-lang.c (opencl_language_defn): Initialise new field.
 123         * p-lang.c (pascal_is_string_type_p): New function.
 124         (pascal_language_defn): Initialise new field.
 125         * rust-lang.c (rust_is_string_type_p): New function.
 126         (rust_language_defn): Initialise new field.
 127
 128 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 131         New field.
 132         * ada-lang.c (ada_language_defn): Initialise new field.
 133         * c-lang.c (c_language_defn): Likewise.
 134         (cplus_language_defn): Likewise.
 135         (asm_language_defn): Likewise.
 136         (minimal_language_defn): Likewise.
 137         * d-lang.c (d_language_defn): Likewise.
 138         * f-lang.c (f_language_defn): Likewise.
 139         * go-lang.c (go_language_defn): Likewise.
 140         * language.c (unknown_language_defn): Likewise.
 141         (auto_language_defn): Likewise.
 142         * m2-lang.c (m2_language_defn): Likewise.
 143         * objc-lang.c (objc_language_defn): Likewise.
 144         * opencl-lang.c (opencl_language_defn): Likewise.
 145         * p-lang.c (pascal_language_defn): Likewise.
 146         * rust-lang.c (rust_language_defn): Likewise.
 147
 148 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * ada-lang.c (ada_is_character_type): Change return type to bool.
 151         (ada_is_string_type): Likewise.
 152         * ada-lang.h (ada_is_character_type): Update declaration
 153         (ada_is_string_type): Likewise.
 154
 155 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 156
 157         Support style in 'frame|thread apply'
 158
 159         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 160         * record.c (record_start, record_stop): Update callers of
 161         execute_command_to_string with false.
 162         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 163         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 164         methods.
 165         (class string_file): New constructor with term_out parameter.
 166         Override methods term_out and can_emit_style_escape.  New member
 167         term_out.
 168         (class stdio_file): Override can_emit_style_escape.
 169         (class tee_file): Override term_out and can_emit_style_escape.
 170         * utils.h (can_emit_style_escape): Remove.
 171         * utils.c (can_emit_style_escape): Likewise.
 172         Update all callers of can_emit_style_escape (SOMESTREAM) to
 173         SOMESTREAM->can_emit_style_escape.
 174         * source-cache.c (source_cache::get_source_lines): Likewise.
 175         * stack.c (frame_apply_command_count): Call execute_command_to_string
 176         passing the term_out characteristic of the current gdb_stdout.
 177         * thread.c (thr_try_catch_cmd): Likewise.
 178         * top.c (execute_command_to_string): pass term_out parameter
 179         to construct the string_file for the command output.
 180         * ui-file.c (term_cli_styling): New function (most code moved
 181         from utils.c can_emit_style_escape).
 182         (string_file::string_file, string_file::can_emit_style_escape,
 183         stdio_file::can_emit_style_escape, tee_file::term_out,
 184         tee_file::can_emit_style_escape): New functions.
 185
 186 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 187
 188         * NEWS: Mention the new set|show may-call-functions.
 189         * infcall.c (may_call_functions_p): New variable.
 190         (show_may_call_functions_p): New function.
 191         (call_function_by_hand_dummy): Throws an error if not
 192         may-call-functions.
 193         (_initialize_infcall): Call add_setshow_boolean_cmd for
 194         may-call-functions.
 195
 196 2019-04-25  Keith Seitz  <keiths@redhat.com>
 197
 198         PR c++/24367
 199         * cp-support.c (inspect_type): Don't attempt substitutions
 200         of symbol with the same name.
 201
 202 2019-04-25  Tom Tromey  <tromey@adacore.com>
 203
 204         PR gdb/24475:
 205         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 206         static.
 207
 208 2019-04-25  Tom Tromey  <tromey@adacore.com>
 209
 210         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 211         rvalue reference.
 212         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 213         (gdb_xml_parser::parse): Use std::move.
 214         * python/python-internal.h (gdbpy_convert_exception): Take a const
 215         reference.
 216         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 217         std::move.
 218         * python/py-utils.c (gdbpy_convert_exception): Take a const
 219         reference.
 220         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 221         Use std::move.
 222         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 223         Use std::move.
 224         * mi/mi-main.c (mi_print_exception): Take a const reference.
 225         * main.c (handle_command_errors): Take a const reference.
 226         * linespec.c (parse_linespec): Use std::move.
 227         * infcall.c (run_inferior_call): Use std::move.
 228         (call_function_by_hand_dummy): Use std::move.
 229         * exec.c (try_open_exec_file): Use std::move.
 230         * exceptions.h (exception_print, exception_fprintf)
 231         (exception_print_same): Update.
 232         * exceptions.c (print_exception, exception_print)
 233         (exception_fprintf, exception_print_same): Change parameters to
 234         const reference.
 235         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 236         * common/new-op.c: Use std::move.
 237         * common/common-exceptions.h (struct gdb_exception): Add move
 238         constructor.
 239         (struct gdb_exception_error, struct gdb_exception_quit, struct
 240         gdb_quit_bad_alloc): Change constructor to move constructor.
 241         (throw_exception): Change parameter to rvalue reference.
 242         * common/common-exceptions.c (throw_exception): Take rvalue
 243         reference.
 244         * cli/cli-interp.c (safe_execute_command): Use std::move.
 245         * breakpoint.c (insert_bp_location, location_to_sals): Use
 246         std::move.
 247
 248 2019-04-25  Tom Tromey  <tromey@adacore.com>
 249
 250         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 251         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 252         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 253         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 254         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 255         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 256         guile/scm-value.c: Use unpack.
 257         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 258         gdbscm_gdb_exception.
 259         (gdbscm_throw_gdb_exception): Likewise.
 260         (struct gdbscm_gdb_exception): New.
 261         (unpack): New function.
 262         (gdbscm_wrap): Use unpack.
 263
 264 2019-04-25  Tom Tromey  <tromey@adacore.com>
 265
 266         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 267         (gdb_rl_callback_handler): Use std::move.
 268         * common/common-exceptions.h (struct gdb_exception): Add move
 269         assignment operator.
 270         (throw_exception_sjlj): Change "exception" to const reference.
 271         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 272         (throw_exception_sjlj): Change "exception" to const reference.
 273
 274 2019-04-25  Tom Tromey  <tromey@adacore.com>
 275
 276         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 277         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 278         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 279         Update.
 280         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 281         Update.
 282         * mi/mi-interp.c (mi_interp::exec): Update.
 283         * linespec.c (parse_linespec): Update.
 284         * infcall.c (run_inferior_call): Update.
 285         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 286         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 287         (gdbscm_lookup_global_symbol): Update.
 288         * guile/scm-param.c (gdbscm_parameter_value): Update.
 289         * guile/scm-frame.c (gdbscm_frame_read_register)
 290         (gdbscm_frame_read_var): Update.
 291         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 292         * exec.c (try_open_exec_file): Update.
 293         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 294         (gdb_rl_callback_handler): Update.
 295         * common/common-exceptions.h (exception_none): Don't declare.
 296         * common/common-exceptions.c (exception_none): Don't define.
 297         (struct catcher) <exception>: Update.
 298         * cli/cli-interp.c (safe_execute_command): Update.
 299         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 300
 301 2019-04-25  Ali Tamur  <tamur@google.com>
 302
 303         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 304         (read_attribute_value): Likewise.
 305         (dwarf2_read_addr_index): Update comment.
 306         (read_str_index): Add DW_FORM_strx.
 307         (dwarf2_string_attr): Likewise.
 308         (dwarf2_const_value_attr): Likewise.
 309         (dump_die_shallow): Likewise.
 310         (dwarf2_fetch_constant_bytes): Likewise.
 311         (skip_form_bytes): Likewise.
 312         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 313
 314 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 315
 316         PR corefiles/11608
 317         PR corefiles/18187
 318         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 319         OFFSET.  Verify if current mapping contains an ELF header.
 320         (linux_find_memory_regions_full): Adjust call to
 321         dump_mapping_p.
 322
 323 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 324             Kang Li <kanglictf@gmail.com>
 325
 326         PR gdb/21600
 327
 328         * dwarf2-frame.c (read_initial_length): Be consistent about using
 329         unsigned representation of length.
 330         (decode_frame_entry_1): Likewise.  Check for wraparound of
 331         end pointer as well as buffer overflow.
 332
 333 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 334
 335         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 336         "vq".
 337
 338 2019-04-24  Tom Tromey  <tromey@adacore.com>
 339
 340         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 341
 342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * s12z-tdep.c (s12z_unwind_pc): Delete.
 345         (s12z_unwind_sp): Delete.
 346         (s12z_gdbarch_init): Don't register deleted functions with
 347         gdbarch.
 348
 349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * rl78-tdep.c (rl78_unwind_sp): Delete.
 352         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 353
 354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 355
 356         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 357         (xstormy16_unwind_pc): Delete.
 358         (xstormy16_dummy_id): Delete.
 359         (xstormy16_gdbarch_init): Don't register deleted functions with
 360         gdbarch.
 361
 362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 363
 364         * vax-tdep.c (vax_unwind_pc): Delete.
 365         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 366
 367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 368
 369         * v850-tdep.c (v850_unwind_sp): Delete.
 370         (v850_unwind_pc): Delete.
 371         (v850_dummy_id): Delete.
 372         (v850_gdbarch_init): Don't register deleted functions with
 373         gdbarch.
 374
 375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 376
 377         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 378         (tilegx_unwind_pc): Delete.
 379         (tilegx_unwind_dummy_id): Delete.
 380         (tilegx_gdbarch_init): Don't register deleted functions with
 381         gdbarch.
 382
 383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 384
 385         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 386         (tic6x_dummy_id): Delete.
 387         (tic6x_gdbarch_init): Don't register deleted functions with
 388         gdbarch.
 389
 390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * sparc-tdep.c (sparc_unwind_pc): Delete.
 393         (sparc32_gdbarch_init): Don't register deleted function with
 394         gdbarch.
 395
 396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 397
 398         * sh-tdep.c (sh_unwind_sp): Delete.
 399         (sh_unwind_pc): Delete.
 400         (sh_dummy_id): Delete.
 401         (sh_gdbarch_init): Don't register deleted functions with
 402         gdbarch.
 403
 404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * score-tdep.c (score_unwind_sp): Delete.
 407         (score_unwind_pc): Delete.
 408         (score_dummy_id): Delete.
 409         (score_gdbarch_init): Don't register deleted functions with
 410         gdbarch.
 411
 412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * rx-tdep.c (rx_unwind_pc): Delete.
 415         (rx_unwind_sp): Delete.
 416         (rx_dummy_id): Delete.
 417         (rx_gdbarch_init): Don't register deleted functions with
 418         gdbarch.  Update comment.
 419
 420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 421
 422         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 423         (rs6000_dummy_id): Delete.
 424         (rs6000_gdbarch_init): Don't register deleted functions with
 425         gdbarch.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * or1k-tdep.c (or1k_dummy_id): Delete.
 430         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 431
 432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * nios2-tdep.c (nios2_dummy_id): Delete.
 435         (nios2_unwind_sp): Delete.
 436         (nios2_gdbarch_init): Don't register deleted functions with
 437         gdbarch.
 438
 439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * nds32-tdep.c (nds32_dummy_id): Delete.
 442         (nds32_unwind_pc): Delete.
 443         (nds32_unwind_sp): Delete.
 444         (nds32_gdbarch_init): Don't register deleted functions with
 445         gdbarch.
 446
 447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 448
 449         * msp430-tdep.c (msp430_unwind_pc): Delete.
 450         (msp430_unwind_sp): Delete.
 451         (msp430_dummy_id): Delete.
 452         (msp430_gdbarch_init): Don't register deleted functions with
 453         gdbarch.
 454
 455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 456
 457         * moxie-tdep.c (moxie_unwind_sp): Delete.
 458         (moxie_unwind_pc): Delete.
 459         (moxie_dummy_id): Delete.
 460         (moxie_gdbarch_init): Don't register deleted functions with
 461         gdbarch.
 462
 463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 464
 465         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 466         (mn10300_unwind_pc): Delete.
 467         (mn10300_unwind_sp): Delete.
 468         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 469         mn10300_unwind_sp.
 470         (mn10300_frame_unwind_init): Don't register deleted functions with
 471         gdbarch.
 472
 473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 474
 475         * mep-tdep.c (mep_unwind_pc): Delete.
 476         (mep_unwind_sp): Delete.
 477         (mep_dummy_id): Delete.
 478         (mep_gdbarch_init): Don't register deleted functions with
 479         gdbarch.
 480
 481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 484         (m68hc11_unwind_sp): Delete.
 485         (m68hc11_gdbarch_init): Don't register deleted functions with
 486         gdbarch.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * m32r-tdep.c (m32r_unwind_sp): Delete.
 491         (m32r_unwind_pc): Delete.
 492         (m32r_dummy_id): Delete.
 493         (m32r_gdbarch_init): Don't register deleted functions with
 494         gdbarch.
 495
 496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * m32c-tdep.c (m32c_unwind_pc): Delete.
 499         (m32c_unwind_sp): Delete.
 500         (m32c_dummy_id): Delete.
 501         (m32c_gdbarch_init): Don't register deleted functions with
 502         gdbarch.
 503
 504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 507         (lm32_unwind_pc): Delete.
 508         (lm32_dummy_id): Delete.
 509         (lm32_gdbarch_init): Don't register deleted functions with
 510         gdbarch.
 511
 512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 513
 514         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 515         (iq2000_unwind_pc): Delete.
 516         (iq2000_dummy_id): Delete.
 517         (iq2000_gdbarch_init): Don't register deleted functions with
 518         gdbarch.
 519
 520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * nds32-tdep.c (nds32_type_align): Delete.
 523         (nds32_push_dummy_call): Use type_align instead.
 524
 525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * arm-tdep.c (arm_type_align): Only handle vector override case.
 528         (arm_push_dummy_call): Use type_align.
 529         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 534         case.
 535         (pass_on_stack): Use type_align.
 536         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 537         function.
 538
 539 2019-04-23  Tom Tromey  <tromey@adacore.com>
 540
 541         * dwarf2read.c (line_header::file_name_at): Remove unused
 542         overload.
 543
 544 2019-04-23  Tom de Vries  <tdevries@suse.de>
 545
 546         PR gdb/24438
 547         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 548         invocation.
 549
 550
 551 2019-03-27  Ali Tamur  <tamur@google.com>
 552
 553         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 554         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 555         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 556         (dwarf_expr_context::get_addr_index): Likewise
 557         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 558         (symbol_needs_eval_context::get_addr_index): Likewise
 559         (disassemble_dwarf_expression): Add DW_OP_addrx
 560         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 561         (read_cutu_die_from_dwo): Update comment
 562         (skip_one_die): Add DW_FORM_addrx
 563         (read_attribute_value): Likewise
 564         (var_decode_location): Add DW_OP_addrx
 565         (dwarf2_const_value_attr): Add DW_FORM_addrx
 566         (dump_die_shallow): Likewise
 567         (dwarf2_fetch_constant_bytes): Likewise
 568         (decode_locdesc): Add DW_OP_addrx
 569         (skip_form_bytes): Add DW_FORM_addrx
 570
 571 2019-04-22  Ali Tamur  <tamur@google.com>
 572
 573         * MAINTAINERS (Write After Approval): Add self.
 574
 575 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 576
 577         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 578         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 579         (open_symbol_file_object): Likewise.
 580         (svr4_default_sos): Add info parameter.
 581         (svr4_read_so_list): Likewise.
 582         (svr4_current_sos_direct): Adjust functions calls to pass down
 583         info.
 584         (svr4_current_sos_1): Add info parameter.
 585         (svr4_current_sos): Call get_svr4_info, pass info down to
 586         svr4_current_sos_1.
 587         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 588         get_svr4_info.
 589         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 590         get_svr4_info.
 591         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 592         to get_svr4_info.
 593         (probes_table_remove_objfile_probes): Likewise.
 594         (register_solib_event_probe): Add info parameter.
 595         (solist_update_incremental): Pass info parameter down to
 596         svr4_read_so_list.
 597         (disable_probes_interface): Add info parameter.
 598         (svr4_handle_solib_event): Pass current_program_space to
 599         get_svr4_info.  Adjust disable_probes_interface cleanup.
 600         (svr4_create_probe_breakpoints): Add info parameter, pass it
 601         down to register_solib_event_probe.
 602         (svr4_create_solib_event_breakpoints): Add info parameter,
 603         pass it down to svr4_create_probe_breakpoints.
 604         (enable_break): Pass info down to
 605         svr4_create_solib_event_breakpoints.
 606         (svr4_solib_create_inferior_hook): Pass current_program_space to
 607         get_svr4_info.
 608         (svr4_clear_solib): Likewise.
 609
 610 2019-04-22  Pedro Alves  <palves@redhat.com>
 611
 612         * solib-svr4.c (svr4_free_objfile_observer): New.
 613         (probe_and_action::objfile): New field.
 614         (probes_table_htab_remove_objfile_probes)
 615         (probes_table_remove_objfile_probes): New functions.
 616         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 617         in the new probe_and_action.  Don't store the probe in 'lookup'.
 618         (svr4_create_probe_breakpoints): Pass objfile to
 619         register_solib_event_probe.
 620         (_initialize_svr4_solib): Register a free_objfile observer.
 621
 622 2019-04-19  Tom Tromey  <tom@tromey.com>
 623
 624         * common/queue.h: Remove.
 625
 626 2019-04-19  Tom Tromey  <tom@tromey.com>
 627
 628         * event-loop.c: Don't include "common/queue.h".
 629
 630 2019-04-19  Tom Tromey  <tom@tromey.com>
 631
 632         * remote.c (remote_target): Use delete.
 633         * remote-notif.h: Include <list>, not "common/queue.h".
 634         (notif_client_p): Remove typedef.
 635         (remote_notif_state): Add constructor, destructor, initializer.
 636         <notif_queue>: Now a std::list.
 637         (remote_notif_state_xfree): Don't declare.
 638         * remote-notif.c (remote_notif_process, handle_notification)
 639         (remote_notif_state_allocate): Update.
 640         (~remote_notif_state): Rename from remote_notif_state_xfree.
 641
 642 2019-04-19  Tom Tromey  <tom@tromey.com>
 643
 644         * symfile.c (reread_symbols): Update.
 645         * objfiles.c (objfile_register_static_link)
 646         (objfile_lookup_static_link): Update
 647         (~objfile) Don't delete static_links.
 648         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 649
 650 2019-04-19  Tom Tromey  <tom@tromey.com>
 651
 652         * type-stack.h (struct type_stack) <insert>: Constify string.
 653         * type-stack.c (type_stack::insert): Constify string.
 654         * gdbtypes.h (lookup_template_type): Update.
 655         (address_space_name_to_int): Update.
 656         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 657         const.
 658         (lookup_template_type): Make name const.
 659         * c-exp.y: Update rules.
 660         (lex_one_token, classify_name, classify_inner_name)
 661         (c_print_token): Update.
 662         * p-exp.y: Update rules.
 663         (yylex): Update.
 664         * f-exp.y: Update rules.
 665         (yylex): Update.
 666         * d-exp.y: Update rules.
 667         (lex_one_token, classify_name, classify_inner_name): Update.
 668         * parse.c (write_dollar_variable, copy_name): Return std::string.
 669         * parser-defs.h (copy_name): Change return type.
 670         * m2-exp.y: Update rules.
 671         (yylex): Update.
 672         * go-exp.y (lex_one_token): Update.
 673         Update rules.
 674         (classify_unsafe_function, classify_packaged_name)
 675         (classify_name, yylex): Update.
 676
 677 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 678
 679         * configure.ac: add --enable-source-highlight switch.
 680         * configure: Regenerate.
 681         * top.c (print_gdb_version): plumb --enable-source-highlight
 682         status to "show configuration".
 683
 684 2019-04-19  Tom Tromey  <tromey@adacore.com>
 685
 686         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 687         Check ADA_TYPE_P.
 688         (empty_record, ada_template_to_fixed_record_type_1)
 689         (template_to_static_fixed_type)
 690         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 691         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 692         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 693         macros.
 694
 695 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 696
 697         PR symtab/24423:
 698         * source.c (print_source_lines_base): Advance "iter" when a
 699         control character is seen.
 700
 701 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 702
 703         * inferior.h (struct infcall_suspend_state_deleter):
 704         Catch exception in destructor to avoid crash.
 705
 706 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 707
 708         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 709         close to the add_com "shell".
 710
 711 2019-04-18  Tom Tromey  <tromey@adacore.com>
 712
 713         * process-stratum-target.h (class process_stratum_target)
 714         <stratum>: Add "final".
 715
 716 2019-04-17  Tom Tromey  <tromey@adacore.com>
 717
 718         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 719         against nullptr before use.
 720
 721 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 722
 723         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 724
 725 2019-04-17  Jim Wilson  <jimw@sifive.com>
 726             Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 729         code read might fail, assume 4-byte breakpoint in that case.
 730
 731 2019-04-15  Leszek Swirski  <leszeks@google.com>
 732
 733         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 734         rather than a hand-rolled POD check when checking for forced MEMORY
 735         classification.
 736
 737 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 738
 739         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 740         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 741         function.
 742         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 743         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 744         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 745         declaration.
 746
 747 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 748
 749         * aarch64-linux-nat.c
 750         (aarch64_linux_nat_target::thread_architecture): Add override.
 751         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 752         each VQ.
 753
 754 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 755
 756         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 757
 758 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 761         target types of size 96-bits, add some additional comments, and
 762         check that the builtin type we found was the correct size.
 763
 764 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 765
 766         * utils.c (prompt_for_continue): Don't restore the styling at the
 767         end, as applied_style has the wrong value.  This fixes styling in
 768         long lists of file names that are interrupted by the "Continue?"
 769         prompt.
 770
 771 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 774         * c-lang.c (c_language_defn): Likewise.
 775         (cplus_language_defn): Likewise.
 776         (asm_language_defn): Likewise.
 777         (minimal_language_defn): Likewise.
 778         * d-lang.c (d_language_defn): Likewise.
 779         * f-lang.c (f_language_defn): Likewise.
 780         * go-lang.c (go_language_defn): Likewise.
 781         * language.c (unknown_language_defn): Likewise.
 782         (auto_language_defn): Likewise.
 783         * language.h (struct language_defn): Remove la_magic field.
 784         (LANG_MAGIC): Delete.
 785         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 786         * objc-lang.c (objc_language_defn): Likewise.
 787         * opencl-lang.c (opencl_language_defn): Likewise.
 788         * p-lang.c (pascal_language_defn): Likewise.
 789         * rust-lang.c (rust_language_defn): Likewise.
 790
 791 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 792
 793         * riscv-tdep.c (riscv_type_align): New function.
 794         (riscv_type_alignment): Delete.
 795         (riscv_arg_location): Use 'type_align'.
 796         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 797
 798 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * gdbtypes.c (type_align): A struct with no non-static fields also
 801         has alignment of 1.
 802
 803 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 806         component to 0.
 807         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 808         member.
 809         (riscv_struct_info::analyse): New implementation using new
 810         analyse_inner member function.
 811         (riscv_struct_info::field_offset): New member function.
 812         (riscv_struct_info::m_offsets): New member variable.
 813         (riscv_struct_info::analyse_inner): New private member function,
 814         takes the old implementation of riscv_struct_info::analyse but
 815         extended to track field offsets.
 816         (riscv_call_arg_struct): Update the struct folding special cases
 817         to handle cases where empty C++ structs, which are non-zero
 818         length, are found.
 819         (riscv_arg_location): Initialise the length of each location, a
 820         non-zero length now indicates the location is in use.
 821         (riscv_push_dummy_call): Allow for the first location having a
 822         non-zero offset when setting up arguments.
 823         (riscv_return_value): Likewise, but for return values.
 824
 825 2019-04-11  Tom Tromey  <tromey@adacore.com>
 826
 827         * utils.c (internal_vproblem): Make "msg" const.
 828
 829 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 830
 831         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 832         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 833         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 834         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 835
 836 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 837
 838         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 839         function.
 840         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 841         of amd64_collect_native_gregset.
 842         (amd64_linux_nat_target::store_registers): Likewise.
 843
 844 2019-04-10  Tom Tromey  <tom@tromey.com>
 845
 846         * symtab.c (lookup_global_symbol_from_objfile)
 847         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 848         * objfiles.h (class separate_debug_iterator): New.
 849         (class separate_debug_range): New.
 850         (struct objfile) <separate_debug_objfiles>: New method.
 851         (objfile_separate_debug_iterate): Don't declare.
 852         * objfiles.c (separate_debug_iterator::operator++): Rename from
 853         objfile_separate_debug_iterate.
 854         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 855         iterator.
 856         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 857         iterator.
 858
 859 2019-04-10  Tom Tromey  <tom@tromey.com>
 860
 861         * symfile.c (reread_symbols): Remove old comment.
 862         * objfiles.c (free_all_objfiles): Fix a typo.
 863
 864 2019-04-10  Tom Tromey  <tom@tromey.com>
 865
 866         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 867         * minsyms.c (lookup_minimal_symbol): Use foreach.
 868         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 869         (lookup_minimal_symbol_solib_trampoline): Likewise.
 870         * symfile.c (reread_symbols): Use foreach.
 871
 872 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 873             Tom Tromey  <tromey@adacore.com>
 874
 875         PR rust/24414:
 876         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 877         (rust_lex_int_test): Change "value" to be LONGEST.
 878         (rust_lex_tests): Add test for long integer literal.
 879
 880 2019-04-09  Tom Tromey  <tromey@adacore.com>
 881
 882         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 883         to bool.
 884         (extended_remote_target::attach): Update.
 885         (remote_target::remote_notice_new_inferior): Update.
 886         (remote_target::add_current_inferior_and_thread): Update.
 887         * inferior.c (exit_inferior_1): Use "false".
 888         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 889
 890 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 891
 892         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 893         the "start" command.
 894
 895 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 896
 897         * python/py-inferior.c (infpy_thread_from_thread_handle):
 898         Adjust comments to reflect renaming of thread_from_thread_handle
 899         to thread_from_handle.  Adjust keywords.  Fix type error message.
 900         (inferior_object_methods): Add thread_from_handle.  Retain
 901         thread_from_thread_handle, but mark it as deprecated.
 902
 903 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 904
 905         * gdbthread.h (find_thread_by_handle): Revise declaration.
 906         * thread.c (find_thread_by_handle): Likewise.  Adjust
 907         implementation too.
 908         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 909         support for buffer objects as handles.
 910
 911 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 912
 913         * python/py-infthread.c (thpy_thread_handle): New function.
 914         (thread_object_methods): Register thpy_thread_handle.
 915
 916 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 917
 918         * gdbthread.h (thread_to_thread_handle): Declare.
 919         * thread.c (gdbtypes.h): Include.
 920         (thread_to_thread_handle): New function.
 921
 922         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 923         (target_thread_info_to_thread_handle): Declare.
 924         * target.c (target_thread_info_to_thread_handle): New function.
 925         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 926         * target-delegates.c: Regenerate.
 927
 928         * linux-thread-db.c (class thread_db_target): Add method
 929         thread_info_to_thread_handle.
 930         (thread_db_target::thread_info_to_thread_handle): Define.
 931         * remote.c (class remote_target): Add new method
 932         thread_info_to_thread_handle.
 933         (remote_target::thread_info_to_thread_handle): Define.
 934
 935 2019-04-08  Pedro Alves  <palves@redhat.com>
 936
 937         * common/common-exceptions.c (throw_exception): Don't create
 938         named object to throw; throw directly.
 939         (throw_it): Likewise.  Don't initialize gdb_exception::message
 940         here, with new; pass FMT and AP to the ctor instead.
 941         * common/common-exceptions.h: Include <string>.
 942         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 943         const char *, va_list)): New ctor.  Use std::make_shared.
 944         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 945         errors)): Delete.
 946         (gdb_exception_error::gdb_exception_error(enum errors, const char
 947         *, va_list)): New.
 948         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 949         Add assertion.
 950         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 951         errors)): Delete.
 952         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 953         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 954         Add assertion.
 955
 956 2019-04-08  Tom Tromey  <tom@tromey.com>
 957
 958         * valops.c (value_rtti_indirect_type): Replace throw_exception
 959         with throw.
 960         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 961         with throw.
 962         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 963         throw.
 964         * target.c (target_translate_tls_address): Replace throw_exception
 965         with throw.
 966         * stack.c (frame_apply_command_count): Replace throw_exception
 967         with throw.
 968         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 969         throw.
 970         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 971         with throw.
 972         * rs6000-tdep.c (rs6000_frame_cache)
 973         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 974         * remote.c: Replace throw_exception with throw.
 975         * record-full.c (record_full_message, record_full_wait_1)
 976         (record_full_restore): Replace throw_exception with throw.
 977         * record-btrace.c:
 978         (get_thread_current_frame_id, record_btrace_start_replaying)
 979         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 980         (cmd_record_btrace_start): Replace throw_exception with throw.
 981         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 982         throw.
 983         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 984         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 985         * linespec.c:
 986         (find_linespec_symbols): Replace throw_exception with throw.
 987         * infrun.c (displaced_step_prepare, resume): Replace
 988         throw_exception with throw.
 989         * infcmd.c (post_create_inferior): Replace throw_exception with
 990         throw.
 991         * inf-loop.c (inferior_event_handler): Replace throw_exception
 992         with throw.
 993         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 994         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 995         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 996         (get_prev_frame_always, get_frame_pc_if_available)
 997         (get_frame_address_in_block_if_available, get_frame_language):
 998         Replace throw_exception with throw.
 999         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1000         throw_exception with throw.
1001         * eval.c (fetch_subexp_value, evaluate_var_value)
1002         (evaluate_funcall, evaluate_subexp_standard): Replace
1003         throw_exception with throw.
1004         * dwarf2loc.c (call_site_find_chain)
1005         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1006         Replace throw_exception with throw.
1007         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1008         with throw.
1009         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1010         throw.
1011         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1012         * completer.c (complete_line_internal): Replace throw_exception
1013         with throw.
1014         * compile/compile-object-run.c (compile_object_run): Replace
1015         throw_exception with throw.
1016         * cli/cli-script.c (process_next_line): Replace throw_exception
1017         with throw.
1018         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1019         (btrace_enable, btrace_maint_update_pt_packets): Replace
1020         throw_exception with throw.
1021         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1022         throw_exception with throw.
1023         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1024         throw_exception with throw.
1025         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1026         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1027         * aarch64-tdep.c (aarch64_make_prologue_cache)
1028         (aarch64_make_stub_cache): Replace throw_exception with throw.
1029
1030 2019-04-08  Tom Tromey  <tom@tromey.com>
1031
1032         * common/common-exceptions.c (throw_exception): Rename from
1033         throw_exception_cxx.  Remove old copy.  Make argument const.
1034         (throw_it): Create and throw exception objects directly.
1035         * common/common-exceptions.h (throw_exception): Make argument
1036         const.
1037         (struct gdb_exception_error): Add constructor.
1038         (struct gdb_exception_quit): Add constructor.
1039
1040 2019-04-08  Tom Tromey  <tom@tromey.com>
1041
1042         * common/common-exceptions.h (exception_rethrow): Don't declare.
1043         (TRY_SJLJ): Update comment.
1044         (TRY, CATCH, END_CATCH): Remove.
1045         * common/common-exceptions.c (exception_rethrow): Remove.
1046
1047 2019-04-08  Tom Tromey  <tom@tromey.com>
1048
1049         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1050         Remove.
1051         (gdb_exception_error): Rename from
1052         gdb_exception_RETURN_MASK_ERROR.
1053         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1054         (gdb_quit_bad_alloc): Update.
1055         * aarch64-tdep.c: Update.
1056         * ada-lang.c: Update.
1057         * ada-typeprint.c: Update.
1058         * ada-valprint.c: Update.
1059         * amd64-tdep.c: Update.
1060         * arch-utils.c: Update.
1061         * break-catch-throw.c: Update.
1062         * breakpoint.c: Update.
1063         * btrace.c: Update.
1064         * c-varobj.c: Update.
1065         * cli/cli-cmds.c: Update.
1066         * cli/cli-interp.c: Update.
1067         * cli/cli-script.c: Update.
1068         * common/common-exceptions.c: Update.
1069         * common/new-op.c: Update.
1070         * common/selftest.c: Update.
1071         * compile/compile-c-symbols.c: Update.
1072         * compile/compile-cplus-symbols.c: Update.
1073         * compile/compile-object-load.c: Update.
1074         * compile/compile-object-run.c: Update.
1075         * completer.c: Update.
1076         * corelow.c: Update.
1077         * cp-abi.c: Update.
1078         * cp-support.c: Update.
1079         * cp-valprint.c: Update.
1080         * darwin-nat.c: Update.
1081         * disasm-selftests.c: Update.
1082         * dtrace-probe.c: Update.
1083         * dwarf-index-cache.c: Update.
1084         * dwarf-index-write.c: Update.
1085         * dwarf2-frame-tailcall.c: Update.
1086         * dwarf2-frame.c: Update.
1087         * dwarf2loc.c: Update.
1088         * dwarf2read.c: Update.
1089         * eval.c: Update.
1090         * event-loop.c: Update.
1091         * event-top.c: Update.
1092         * exec.c: Update.
1093         * f-valprint.c: Update.
1094         * fbsd-tdep.c: Update.
1095         * frame-unwind.c: Update.
1096         * frame.c: Update.
1097         * gdbtypes.c: Update.
1098         * gnu-v3-abi.c: Update.
1099         * guile/guile-internal.h: Update.
1100         * guile/scm-block.c: Update.
1101         * guile/scm-breakpoint.c: Update.
1102         * guile/scm-cmd.c: Update.
1103         * guile/scm-disasm.c: Update.
1104         * guile/scm-frame.c: Update.
1105         * guile/scm-lazy-string.c: Update.
1106         * guile/scm-math.c: Update.
1107         * guile/scm-param.c: Update.
1108         * guile/scm-ports.c: Update.
1109         * guile/scm-pretty-print.c: Update.
1110         * guile/scm-symbol.c: Update.
1111         * guile/scm-symtab.c: Update.
1112         * guile/scm-type.c: Update.
1113         * guile/scm-value.c: Update.
1114         * i386-linux-tdep.c: Update.
1115         * i386-tdep.c: Update.
1116         * inf-loop.c: Update.
1117         * infcall.c: Update.
1118         * infcmd.c: Update.
1119         * infrun.c: Update.
1120         * jit.c: Update.
1121         * language.c: Update.
1122         * linespec.c: Update.
1123         * linux-fork.c: Update.
1124         * linux-nat.c: Update.
1125         * linux-tdep.c: Update.
1126         * linux-thread-db.c: Update.
1127         * main.c: Update.
1128         * mi/mi-cmd-break.c: Update.
1129         * mi/mi-cmd-stack.c: Update.
1130         * mi/mi-interp.c: Update.
1131         * mi/mi-main.c: Update.
1132         * objc-lang.c: Update.
1133         * p-valprint.c: Update.
1134         * parse.c: Update.
1135         * ppc-linux-tdep.c: Update.
1136         * printcmd.c: Update.
1137         * python/py-arch.c: Update.
1138         * python/py-breakpoint.c: Update.
1139         * python/py-cmd.c: Update.
1140         * python/py-finishbreakpoint.c: Update.
1141         * python/py-frame.c: Update.
1142         * python/py-framefilter.c: Update.
1143         * python/py-gdb-readline.c: Update.
1144         * python/py-inferior.c: Update.
1145         * python/py-infthread.c: Update.
1146         * python/py-lazy-string.c: Update.
1147         * python/py-linetable.c: Update.
1148         * python/py-objfile.c: Update.
1149         * python/py-param.c: Update.
1150         * python/py-prettyprint.c: Update.
1151         * python/py-progspace.c: Update.
1152         * python/py-record-btrace.c: Update.
1153         * python/py-record.c: Update.
1154         * python/py-symbol.c: Update.
1155         * python/py-type.c: Update.
1156         * python/py-unwind.c: Update.
1157         * python/py-utils.c: Update.
1158         * python/py-value.c: Update.
1159         * python/python.c: Update.
1160         * record-btrace.c: Update.
1161         * record-full.c: Update.
1162         * remote-fileio.c: Update.
1163         * remote.c: Update.
1164         * riscv-tdep.c: Update.
1165         * rs6000-aix-tdep.c: Update.
1166         * rs6000-tdep.c: Update.
1167         * rust-exp.y: Update.
1168         * rust-lang.c: Update.
1169         * s390-tdep.c: Update.
1170         * selftest-arch.c: Update.
1171         * solib-dsbt.c: Update.
1172         * solib-frv.c: Update.
1173         * solib-spu.c: Update.
1174         * solib-svr4.c: Update.
1175         * solib.c: Update.
1176         * sparc64-linux-tdep.c: Update.
1177         * stack.c: Update.
1178         * symfile-mem.c: Update.
1179         * symmisc.c: Update.
1180         * target.c: Update.
1181         * thread.c: Update.
1182         * top.c: Update.
1183         * tracefile-tfile.c: Update.
1184         * tui/tui.c: Update.
1185         * typeprint.c: Update.
1186         * unittests/cli-utils-selftests.c: Update.
1187         * unittests/parse-connection-spec-selftests.c: Update.
1188         * valops.c: Update.
1189         * valprint.c: Update.
1190         * value.c: Update.
1191         * varobj.c: Update.
1192         * windows-nat.c: Update.
1193         * x86-linux-nat.c: Update.
1194         * xml-support.c: Update.
1195
1196 2019-04-08  Tom Tromey  <tom@tromey.com>
1197
1198         * xml-support.c: Use C++ exception handling.
1199         * x86-linux-nat.c: Use C++ exception handling.
1200         * windows-nat.c: Use C++ exception handling.
1201         * varobj.c: Use C++ exception handling.
1202         * value.c: Use C++ exception handling.
1203         * valprint.c: Use C++ exception handling.
1204         * valops.c: Use C++ exception handling.
1205         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1206         handling.
1207         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1208         * typeprint.c: Use C++ exception handling.
1209         * tui/tui.c: Use C++ exception handling.
1210         * tracefile-tfile.c: Use C++ exception handling.
1211         * top.c: Use C++ exception handling.
1212         * thread.c: Use C++ exception handling.
1213         * target.c: Use C++ exception handling.
1214         * symmisc.c: Use C++ exception handling.
1215         * symfile-mem.c: Use C++ exception handling.
1216         * stack.c: Use C++ exception handling.
1217         * sparc64-linux-tdep.c: Use C++ exception handling.
1218         * solib.c: Use C++ exception handling.
1219         * solib-svr4.c: Use C++ exception handling.
1220         * solib-spu.c: Use C++ exception handling.
1221         * solib-frv.c: Use C++ exception handling.
1222         * solib-dsbt.c: Use C++ exception handling.
1223         * selftest-arch.c: Use C++ exception handling.
1224         * s390-tdep.c: Use C++ exception handling.
1225         * rust-lang.c: Use C++ exception handling.
1226         * rust-exp.y: Use C++ exception handling.
1227         * rs6000-tdep.c: Use C++ exception handling.
1228         * rs6000-aix-tdep.c: Use C++ exception handling.
1229         * riscv-tdep.c: Use C++ exception handling.
1230         * remote.c: Use C++ exception handling.
1231         * remote-fileio.c: Use C++ exception handling.
1232         * record-full.c: Use C++ exception handling.
1233         * record-btrace.c: Use C++ exception handling.
1234         * python/python.c: Use C++ exception handling.
1235         * python/py-value.c: Use C++ exception handling.
1236         * python/py-utils.c: Use C++ exception handling.
1237         * python/py-unwind.c: Use C++ exception handling.
1238         * python/py-type.c: Use C++ exception handling.
1239         * python/py-symbol.c: Use C++ exception handling.
1240         * python/py-record.c: Use C++ exception handling.
1241         * python/py-record-btrace.c: Use C++ exception handling.
1242         * python/py-progspace.c: Use C++ exception handling.
1243         * python/py-prettyprint.c: Use C++ exception handling.
1244         * python/py-param.c: Use C++ exception handling.
1245         * python/py-objfile.c: Use C++ exception handling.
1246         * python/py-linetable.c: Use C++ exception handling.
1247         * python/py-lazy-string.c: Use C++ exception handling.
1248         * python/py-infthread.c: Use C++ exception handling.
1249         * python/py-inferior.c: Use C++ exception handling.
1250         * python/py-gdb-readline.c: Use C++ exception handling.
1251         * python/py-framefilter.c: Use C++ exception handling.
1252         * python/py-frame.c: Use C++ exception handling.
1253         * python/py-finishbreakpoint.c: Use C++ exception handling.
1254         * python/py-cmd.c: Use C++ exception handling.
1255         * python/py-breakpoint.c: Use C++ exception handling.
1256         * python/py-arch.c: Use C++ exception handling.
1257         * printcmd.c: Use C++ exception handling.
1258         * ppc-linux-tdep.c: Use C++ exception handling.
1259         * parse.c: Use C++ exception handling.
1260         * p-valprint.c: Use C++ exception handling.
1261         * objc-lang.c: Use C++ exception handling.
1262         * mi/mi-main.c: Use C++ exception handling.
1263         * mi/mi-interp.c: Use C++ exception handling.
1264         * mi/mi-cmd-stack.c: Use C++ exception handling.
1265         * mi/mi-cmd-break.c: Use C++ exception handling.
1266         * main.c: Use C++ exception handling.
1267         * linux-thread-db.c: Use C++ exception handling.
1268         * linux-tdep.c: Use C++ exception handling.
1269         * linux-nat.c: Use C++ exception handling.
1270         * linux-fork.c: Use C++ exception handling.
1271         * linespec.c: Use C++ exception handling.
1272         * language.c: Use C++ exception handling.
1273         * jit.c: Use C++ exception handling.
1274         * infrun.c: Use C++ exception handling.
1275         * infcmd.c: Use C++ exception handling.
1276         * infcall.c: Use C++ exception handling.
1277         * inf-loop.c: Use C++ exception handling.
1278         * i386-tdep.c: Use C++ exception handling.
1279         * i386-linux-tdep.c: Use C++ exception handling.
1280         * guile/scm-value.c: Use C++ exception handling.
1281         * guile/scm-type.c: Use C++ exception handling.
1282         * guile/scm-symtab.c: Use C++ exception handling.
1283         * guile/scm-symbol.c: Use C++ exception handling.
1284         * guile/scm-pretty-print.c: Use C++ exception handling.
1285         * guile/scm-ports.c: Use C++ exception handling.
1286         * guile/scm-param.c: Use C++ exception handling.
1287         * guile/scm-math.c: Use C++ exception handling.
1288         * guile/scm-lazy-string.c: Use C++ exception handling.
1289         * guile/scm-frame.c: Use C++ exception handling.
1290         * guile/scm-disasm.c: Use C++ exception handling.
1291         * guile/scm-cmd.c: Use C++ exception handling.
1292         * guile/scm-breakpoint.c: Use C++ exception handling.
1293         * guile/scm-block.c: Use C++ exception handling.
1294         * guile/guile-internal.h: Use C++ exception handling.
1295         * gnu-v3-abi.c: Use C++ exception handling.
1296         * gdbtypes.c: Use C++ exception handling.
1297         * frame.c: Use C++ exception handling.
1298         * frame-unwind.c: Use C++ exception handling.
1299         * fbsd-tdep.c: Use C++ exception handling.
1300         * f-valprint.c: Use C++ exception handling.
1301         * exec.c: Use C++ exception handling.
1302         * event-top.c: Use C++ exception handling.
1303         * event-loop.c: Use C++ exception handling.
1304         * eval.c: Use C++ exception handling.
1305         * dwarf2read.c: Use C++ exception handling.
1306         * dwarf2loc.c: Use C++ exception handling.
1307         * dwarf2-frame.c: Use C++ exception handling.
1308         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1309         * dwarf-index-write.c: Use C++ exception handling.
1310         * dwarf-index-cache.c: Use C++ exception handling.
1311         * dtrace-probe.c: Use C++ exception handling.
1312         * disasm-selftests.c: Use C++ exception handling.
1313         * darwin-nat.c: Use C++ exception handling.
1314         * cp-valprint.c: Use C++ exception handling.
1315         * cp-support.c: Use C++ exception handling.
1316         * cp-abi.c: Use C++ exception handling.
1317         * corelow.c: Use C++ exception handling.
1318         * completer.c: Use C++ exception handling.
1319         * compile/compile-object-run.c: Use C++ exception handling.
1320         * compile/compile-object-load.c: Use C++ exception handling.
1321         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1322         * compile/compile-c-symbols.c: Use C++ exception handling.
1323         * common/selftest.c: Use C++ exception handling.
1324         * common/new-op.c: Use C++ exception handling.
1325         * cli/cli-script.c: Use C++ exception handling.
1326         * cli/cli-interp.c: Use C++ exception handling.
1327         * cli/cli-cmds.c: Use C++ exception handling.
1328         * c-varobj.c: Use C++ exception handling.
1329         * btrace.c: Use C++ exception handling.
1330         * breakpoint.c: Use C++ exception handling.
1331         * break-catch-throw.c: Use C++ exception handling.
1332         * arch-utils.c: Use C++ exception handling.
1333         * amd64-tdep.c: Use C++ exception handling.
1334         * ada-valprint.c: Use C++ exception handling.
1335         * ada-typeprint.c: Use C++ exception handling.
1336         * ada-lang.c: Use C++ exception handling.
1337         * aarch64-tdep.c: Use C++ exception handling.
1338
1339 2019-04-08  Tom Tromey  <tom@tromey.com>
1340
1341         * xml-support.c (gdb_xml_parser::parse): Update.
1342         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1343         * value.c (show_convenience): Update.
1344         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1345         (test_parse_flags_qcs): Update.
1346         * thread.c (thr_try_catch_cmd): Update.
1347         * target.c (target_translate_tls_address): Update.
1348         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1349         (info_frame_command_core, frame_apply_command_count): Update.
1350         * rust-exp.y (rust_lex_exception_test): Update.
1351         * riscv-tdep.c (riscv_print_one_register_info): Update.
1352         * remote.c (remote_target::enable_btrace): Update.
1353         * record-btrace.c (record_btrace_enable_warn): Update.
1354         * python/py-utils.c (gdbpy_convert_exception): Update.
1355         * printcmd.c (do_one_display, print_variable_and_value): Update.
1356         * mi/mi-main.c (mi_print_exception): Update.
1357         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1358         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1359         * linux-nat.c (linux_nat_target::attach): Update.
1360         * linux-fork.c (class scoped_switch_fork_info): Update.
1361         * infrun.c (displaced_step_prepare): Update.
1362         * infcall.c (call_function_by_hand_dummy): Update.
1363         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1364         * gnu-v3-abi.c (print_one_vtable): Update.
1365         * frame.c (get_prev_frame_always): Update.
1366         * f-valprint.c (info_common_command_for_block): Update.
1367         * exec.c (try_open_exec_file): Update.
1368         * exceptions.c (print_exception, exception_print)
1369         (exception_fprintf, exception_print_same): Update.
1370         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1371         * dwarf-index-cache.c (index_cache::store)
1372         (index_cache::lookup_gdb_index): Update.
1373         * darwin-nat.c (maybe_cache_shell): Update.
1374         * cp-valprint.c (cp_print_value_fields): Update.
1375         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1376         (gcc_cplus_symbol_address): Update.
1377         * compile/compile-c-symbols.c (gcc_convert_symbol)
1378         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1379         * common/selftest.c: Update.
1380         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1381         a std::string.
1382         (exception_try_scope_entry, exception_try_scope_exit): Don't
1383         declare.
1384         (struct exception_try_scope): Remove.
1385         (TRY): Don't use exception_try_scope.
1386         (struct gdb_exception): Add constructor, operator=.
1387         <what>: New method.
1388         (struct gdb_exception_RETURN_MASK_ALL)
1389         (struct gdb_exception_RETURN_MASK_ERROR)
1390         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1391         (struct gdb_quit_bad_alloc): Update.
1392         * common/common-exceptions.c (exception_none): Change
1393         initializer.
1394         (struct catcher) <state, exception>: Initialize inline.
1395         <prev>: Remove member.
1396         (current_catcher): Remove.
1397         (catchers): New global.
1398         (exceptions_state_mc_init): Simplify.
1399         (catcher_pop): Remove.
1400         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1401         (try_scope_depth, exception_try_scope_entry)
1402         (exception_try_scope_exit): Remove.
1403         (throw_exception_sjlj): Update.
1404         (exception_messages, exception_messages_size): Remove.
1405         (throw_it): Simplify.
1406         (gdb_exception_sliced_copy): Remove.
1407         (throw_exception_cxx): Update.
1408         * cli/cli-script.c (script_from_file): Update.
1409         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1410         Update.
1411         * ada-valprint.c (ada_val_print): Update.
1412         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1413         (create_excep_cond_exprs): Update.
1414
1415 2019-04-08  Tom Tromey  <tom@tromey.com>
1416
1417         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1418         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1419         (TRY, CATCH, END_CATCH): Remove some definitions.
1420         * common/common-exceptions.c: Don't use GDB_XCPT.
1421         (catcher_list_size): Remove.
1422         (throw_exception, throw_it): Simplify.
1423
1424 2019-04-05  Tom Tromey  <tom@tromey.com>
1425
1426         Revert the header-sorting patch.
1427         * ft32-tdep.c: Revert.
1428         * frv-tdep.c: Revert.
1429         * frv-linux-tdep.c: Revert.
1430         * frame.c: Revert.
1431         * frame-unwind.c: Revert.
1432         * frame-base.c: Revert.
1433         * fork-child.c: Revert.
1434         * findvar.c: Revert.
1435         * findcmd.c: Revert.
1436         * filesystem.c: Revert.
1437         * filename-seen-cache.h: Revert.
1438         * filename-seen-cache.c: Revert.
1439         * fbsd-tdep.c: Revert.
1440         * fbsd-nat.h: Revert.
1441         * fbsd-nat.c: Revert.
1442         * f-valprint.c: Revert.
1443         * f-typeprint.c: Revert.
1444         * f-lang.c: Revert.
1445         * extension.h: Revert.
1446         * extension.c: Revert.
1447         * extension-priv.h: Revert.
1448         * expprint.c: Revert.
1449         * exec.h: Revert.
1450         * exec.c: Revert.
1451         * exceptions.c: Revert.
1452         * event-top.c: Revert.
1453         * event-loop.c: Revert.
1454         * eval.c: Revert.
1455         * elfread.c: Revert.
1456         * dwarf2read.h: Revert.
1457         * dwarf2read.c: Revert.
1458         * dwarf2loc.c: Revert.
1459         * dwarf2expr.h: Revert.
1460         * dwarf2expr.c: Revert.
1461         * dwarf2-frame.c: Revert.
1462         * dwarf2-frame-tailcall.c: Revert.
1463         * dwarf-index-write.h: Revert.
1464         * dwarf-index-write.c: Revert.
1465         * dwarf-index-common.c: Revert.
1466         * dwarf-index-cache.h: Revert.
1467         * dwarf-index-cache.c: Revert.
1468         * dummy-frame.c: Revert.
1469         * dtrace-probe.c: Revert.
1470         * disasm.h: Revert.
1471         * disasm.c: Revert.
1472         * disasm-selftests.c: Revert.
1473         * dictionary.c: Revert.
1474         * dicos-tdep.c: Revert.
1475         * demangle.c: Revert.
1476         * dcache.h: Revert.
1477         * dcache.c: Revert.
1478         * darwin-nat.h: Revert.
1479         * darwin-nat.c: Revert.
1480         * darwin-nat-info.c: Revert.
1481         * d-valprint.c: Revert.
1482         * d-namespace.c: Revert.
1483         * d-lang.c: Revert.
1484         * ctf.c: Revert.
1485         * csky-tdep.c: Revert.
1486         * csky-linux-tdep.c: Revert.
1487         * cris-tdep.c: Revert.
1488         * cris-linux-tdep.c: Revert.
1489         * cp-valprint.c: Revert.
1490         * cp-support.c: Revert.
1491         * cp-namespace.c: Revert.
1492         * cp-abi.c: Revert.
1493         * corelow.c: Revert.
1494         * corefile.c: Revert.
1495         * continuations.c: Revert.
1496         * completer.h: Revert.
1497         * completer.c: Revert.
1498         * complaints.c: Revert.
1499         * coffread.c: Revert.
1500         * coff-pe-read.c: Revert.
1501         * cli-out.h: Revert.
1502         * cli-out.c: Revert.
1503         * charset.c: Revert.
1504         * c-varobj.c: Revert.
1505         * c-valprint.c: Revert.
1506         * c-typeprint.c: Revert.
1507         * c-lang.c: Revert.
1508         * buildsym.c: Revert.
1509         * buildsym-legacy.c: Revert.
1510         * build-id.h: Revert.
1511         * build-id.c: Revert.
1512         * btrace.c: Revert.
1513         * bsd-uthread.c: Revert.
1514         * breakpoint.h: Revert.
1515         * breakpoint.c: Revert.
1516         * break-catch-throw.c: Revert.
1517         * break-catch-syscall.c: Revert.
1518         * break-catch-sig.c: Revert.
1519         * blockframe.c: Revert.
1520         * block.c: Revert.
1521         * bfin-tdep.c: Revert.
1522         * bfin-linux-tdep.c: Revert.
1523         * bfd-target.c: Revert.
1524         * bcache.c: Revert.
1525         * ax-general.c: Revert.
1526         * ax-gdb.h: Revert.
1527         * ax-gdb.c: Revert.
1528         * avr-tdep.c: Revert.
1529         * auxv.c: Revert.
1530         * auto-load.c: Revert.
1531         * arm-wince-tdep.c: Revert.
1532         * arm-tdep.c: Revert.
1533         * arm-symbian-tdep.c: Revert.
1534         * arm-pikeos-tdep.c: Revert.
1535         * arm-obsd-tdep.c: Revert.
1536         * arm-nbsd-tdep.c: Revert.
1537         * arm-nbsd-nat.c: Revert.
1538         * arm-linux-tdep.c: Revert.
1539         * arm-linux-nat.c: Revert.
1540         * arm-fbsd-tdep.c: Revert.
1541         * arm-fbsd-nat.c: Revert.
1542         * arm-bsd-tdep.c: Revert.
1543         * arch-utils.c: Revert.
1544         * arc-tdep.c: Revert.
1545         * arc-newlib-tdep.c: Revert.
1546         * annotate.h: Revert.
1547         * annotate.c: Revert.
1548         * amd64-windows-tdep.c: Revert.
1549         * amd64-windows-nat.c: Revert.
1550         * amd64-tdep.c: Revert.
1551         * amd64-sol2-tdep.c: Revert.
1552         * amd64-obsd-tdep.c: Revert.
1553         * amd64-obsd-nat.c: Revert.
1554         * amd64-nbsd-tdep.c: Revert.
1555         * amd64-nbsd-nat.c: Revert.
1556         * amd64-nat.c: Revert.
1557         * amd64-linux-tdep.c: Revert.
1558         * amd64-linux-nat.c: Revert.
1559         * amd64-fbsd-tdep.c: Revert.
1560         * amd64-fbsd-nat.c: Revert.
1561         * amd64-dicos-tdep.c: Revert.
1562         * amd64-darwin-tdep.c: Revert.
1563         * amd64-bsd-nat.c: Revert.
1564         * alpha-tdep.c: Revert.
1565         * alpha-obsd-tdep.c: Revert.
1566         * alpha-nbsd-tdep.c: Revert.
1567         * alpha-mdebug-tdep.c: Revert.
1568         * alpha-linux-tdep.c: Revert.
1569         * alpha-linux-nat.c: Revert.
1570         * alpha-bsd-tdep.c: Revert.
1571         * alpha-bsd-nat.c: Revert.
1572         * aix-thread.c: Revert.
1573         * agent.c: Revert.
1574         * addrmap.c: Revert.
1575         * ada-varobj.c: Revert.
1576         * ada-valprint.c: Revert.
1577         * ada-typeprint.c: Revert.
1578         * ada-tasks.c: Revert.
1579         * ada-lang.c: Revert.
1580         * aarch64-tdep.c: Revert.
1581         * aarch64-ravenscar-thread.c: Revert.
1582         * aarch64-newlib-tdep.c: Revert.
1583         * aarch64-linux-tdep.c: Revert.
1584         * aarch64-linux-nat.c: Revert.
1585         * aarch64-fbsd-tdep.c: Revert.
1586         * aarch64-fbsd-nat.c: Revert.
1587         * aarch32-linux-nat.c: Revert.
1588
1589 2019-04-05  Tom Tromey  <tom@tromey.com>
1590
1591         * ft32-tdep.c: Sort headers.
1592         * frv-tdep.c: Sort headers.
1593         * frv-linux-tdep.c: Sort headers.
1594         * frame.c: Sort headers.
1595         * frame-unwind.c: Sort headers.
1596         * frame-base.c: Sort headers.
1597         * fork-child.c: Sort headers.
1598         * findvar.c: Sort headers.
1599         * findcmd.c: Sort headers.
1600         * filesystem.c: Sort headers.
1601         * filename-seen-cache.h: Sort headers.
1602         * filename-seen-cache.c: Sort headers.
1603         * fbsd-tdep.c: Sort headers.
1604         * fbsd-nat.h: Sort headers.
1605         * fbsd-nat.c: Sort headers.
1606         * f-valprint.c: Sort headers.
1607         * f-typeprint.c: Sort headers.
1608         * f-lang.c: Sort headers.
1609         * extension.h: Sort headers.
1610         * extension.c: Sort headers.
1611         * extension-priv.h: Sort headers.
1612         * expprint.c: Sort headers.
1613         * exec.h: Sort headers.
1614         * exec.c: Sort headers.
1615         * exceptions.c: Sort headers.
1616         * event-top.c: Sort headers.
1617         * event-loop.c: Sort headers.
1618         * eval.c: Sort headers.
1619         * elfread.c: Sort headers.
1620         * dwarf2read.h: Sort headers.
1621         * dwarf2read.c: Sort headers.
1622         * dwarf2loc.c: Sort headers.
1623         * dwarf2expr.h: Sort headers.
1624         * dwarf2expr.c: Sort headers.
1625         * dwarf2-frame.c: Sort headers.
1626         * dwarf2-frame-tailcall.c: Sort headers.
1627         * dwarf-index-write.h: Sort headers.
1628         * dwarf-index-write.c: Sort headers.
1629         * dwarf-index-common.c: Sort headers.
1630         * dwarf-index-cache.h: Sort headers.
1631         * dwarf-index-cache.c: Sort headers.
1632         * dummy-frame.c: Sort headers.
1633         * dtrace-probe.c: Sort headers.
1634         * disasm.h: Sort headers.
1635         * disasm.c: Sort headers.
1636         * disasm-selftests.c: Sort headers.
1637         * dictionary.c: Sort headers.
1638         * dicos-tdep.c: Sort headers.
1639         * demangle.c: Sort headers.
1640         * dcache.h: Sort headers.
1641         * dcache.c: Sort headers.
1642         * darwin-nat.h: Sort headers.
1643         * darwin-nat.c: Sort headers.
1644         * darwin-nat-info.c: Sort headers.
1645         * d-valprint.c: Sort headers.
1646         * d-namespace.c: Sort headers.
1647         * d-lang.c: Sort headers.
1648         * ctf.c: Sort headers.
1649         * csky-tdep.c: Sort headers.
1650         * csky-linux-tdep.c: Sort headers.
1651         * cris-tdep.c: Sort headers.
1652         * cris-linux-tdep.c: Sort headers.
1653         * cp-valprint.c: Sort headers.
1654         * cp-support.c: Sort headers.
1655         * cp-namespace.c: Sort headers.
1656         * cp-abi.c: Sort headers.
1657         * corelow.c: Sort headers.
1658         * corefile.c: Sort headers.
1659         * continuations.c: Sort headers.
1660         * completer.h: Sort headers.
1661         * completer.c: Sort headers.
1662         * complaints.c: Sort headers.
1663         * coffread.c: Sort headers.
1664         * coff-pe-read.c: Sort headers.
1665         * cli-out.h: Sort headers.
1666         * cli-out.c: Sort headers.
1667         * charset.c: Sort headers.
1668         * c-varobj.c: Sort headers.
1669         * c-valprint.c: Sort headers.
1670         * c-typeprint.c: Sort headers.
1671         * c-lang.c: Sort headers.
1672         * buildsym.c: Sort headers.
1673         * buildsym-legacy.c: Sort headers.
1674         * build-id.h: Sort headers.
1675         * build-id.c: Sort headers.
1676         * btrace.c: Sort headers.
1677         * bsd-uthread.c: Sort headers.
1678         * breakpoint.h: Sort headers.
1679         * breakpoint.c: Sort headers.
1680         * break-catch-throw.c: Sort headers.
1681         * break-catch-syscall.c: Sort headers.
1682         * break-catch-sig.c: Sort headers.
1683         * blockframe.c: Sort headers.
1684         * block.c: Sort headers.
1685         * bfin-tdep.c: Sort headers.
1686         * bfin-linux-tdep.c: Sort headers.
1687         * bfd-target.c: Sort headers.
1688         * bcache.c: Sort headers.
1689         * ax-general.c: Sort headers.
1690         * ax-gdb.h: Sort headers.
1691         * ax-gdb.c: Sort headers.
1692         * avr-tdep.c: Sort headers.
1693         * auxv.c: Sort headers.
1694         * auto-load.c: Sort headers.
1695         * arm-wince-tdep.c: Sort headers.
1696         * arm-tdep.c: Sort headers.
1697         * arm-symbian-tdep.c: Sort headers.
1698         * arm-pikeos-tdep.c: Sort headers.
1699         * arm-obsd-tdep.c: Sort headers.
1700         * arm-nbsd-tdep.c: Sort headers.
1701         * arm-nbsd-nat.c: Sort headers.
1702         * arm-linux-tdep.c: Sort headers.
1703         * arm-linux-nat.c: Sort headers.
1704         * arm-fbsd-tdep.c: Sort headers.
1705         * arm-fbsd-nat.c: Sort headers.
1706         * arm-bsd-tdep.c: Sort headers.
1707         * arch-utils.c: Sort headers.
1708         * arc-tdep.c: Sort headers.
1709         * arc-newlib-tdep.c: Sort headers.
1710         * annotate.h: Sort headers.
1711         * annotate.c: Sort headers.
1712         * amd64-windows-tdep.c: Sort headers.
1713         * amd64-windows-nat.c: Sort headers.
1714         * amd64-tdep.c: Sort headers.
1715         * amd64-sol2-tdep.c: Sort headers.
1716         * amd64-obsd-tdep.c: Sort headers.
1717         * amd64-obsd-nat.c: Sort headers.
1718         * amd64-nbsd-tdep.c: Sort headers.
1719         * amd64-nbsd-nat.c: Sort headers.
1720         * amd64-nat.c: Sort headers.
1721         * amd64-linux-tdep.c: Sort headers.
1722         * amd64-linux-nat.c: Sort headers.
1723         * amd64-fbsd-tdep.c: Sort headers.
1724         * amd64-fbsd-nat.c: Sort headers.
1725         * amd64-dicos-tdep.c: Sort headers.
1726         * amd64-darwin-tdep.c: Sort headers.
1727         * amd64-bsd-nat.c: Sort headers.
1728         * alpha-tdep.c: Sort headers.
1729         * alpha-obsd-tdep.c: Sort headers.
1730         * alpha-nbsd-tdep.c: Sort headers.
1731         * alpha-mdebug-tdep.c: Sort headers.
1732         * alpha-linux-tdep.c: Sort headers.
1733         * alpha-linux-nat.c: Sort headers.
1734         * alpha-bsd-tdep.c: Sort headers.
1735         * alpha-bsd-nat.c: Sort headers.
1736         * aix-thread.c: Sort headers.
1737         * agent.c: Sort headers.
1738         * addrmap.c: Sort headers.
1739         * ada-varobj.c: Sort headers.
1740         * ada-valprint.c: Sort headers.
1741         * ada-typeprint.c: Sort headers.
1742         * ada-tasks.c: Sort headers.
1743         * ada-lang.c: Sort headers.
1744         * aarch64-tdep.c: Sort headers.
1745         * aarch64-ravenscar-thread.c: Sort headers.
1746         * aarch64-newlib-tdep.c: Sort headers.
1747         * aarch64-linux-tdep.c: Sort headers.
1748         * aarch64-linux-nat.c: Sort headers.
1749         * aarch64-fbsd-tdep.c: Sort headers.
1750         * aarch64-fbsd-nat.c: Sort headers.
1751         * aarch32-linux-nat.c: Sort headers.
1752
1753 2019-04-04  Tom Tromey  <tom@tromey.com>
1754
1755         * varobj.c (varobj_create): Update.
1756         * rust-exp.y (struct rust_parser) <update_innermost_block,
1757         lookup_symbol>: New methods.
1758         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1759         Rename.
1760         (rust_parser::rust_lookup_type)
1761         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1762         * printcmd.c (display_command, do_one_display): Update.
1763         * parser-defs.h (struct parser_state) <parser_state>: Add
1764         "tracker" parameter.
1765         (block_tracker): New member.
1766         (class innermost_block_tracker) <innermost_block_tracker>: Add
1767         "types" parameter.
1768         <reset>: Remove method.
1769         (innermost_block): Don't declare.
1770         (null_post_parser): Update.
1771         * parse.c (innermost_block): Remove global.
1772         (write_dollar_variable): Update.
1773         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1774         Remove "tracker_types" parameter.
1775         (parse_expression): Add "tracker" parameter.
1776         (parse_expression_for_completion): Update.
1777         (null_post_parser): Add "tracker" parameter.
1778         * p-exp.y: Update rules.
1779         * m2-exp.y: Update rules.
1780         * language.h (struct language_defn) <la_post_parser>: Add
1781         "tracker" parameter.
1782         * go-exp.y: Update rules.
1783         * f-exp.y: Update rules.
1784         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1785         parameter.
1786         * d-exp.y: Update rules.
1787         * c-exp.y: Update rules.
1788         * breakpoint.c (set_breakpoint_condition): Create an
1789         innermost_block_tracker.
1790         (watch_command_1): Likewise.
1791         * ada-lang.c (resolve): Add "tracker" parameter.
1792         (resolve_subexp): Likewise.
1793         * ada-exp.y (write_var_from_sym): Update.
1794
1795 2019-04-04  Tom Tromey  <tom@tromey.com>
1796
1797         * type-stack.h: New file.
1798         * type-stack.c: New file.
1799         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1800         type-stack.h.
1801         (insert_into_type_stack, insert_type, push_type, push_type_int)
1802         (insert_type_address_space, pop_type, pop_type_int)
1803         (pop_typelist, pop_type_stack, append_type_stack)
1804         (push_type_stack, get_type_stack, push_typelist)
1805         (follow_type_instance_flags, follow_types): Don't declare.
1806         * parse.c (type_stack): Remove global.
1807         (parse_exp_in_context): Update.
1808         (insert_into_type_stack, insert_type, push_type, push_type_int)
1809         (insert_type_address_space, pop_type, pop_type_int)
1810         (pop_typelist, pop_type_stack, append_type_stack)
1811         (push_type_stack, get_type_stack, push_typelist)
1812         (follow_type_instance_flags, follow_types): Remove (moved to
1813         type-stack.c).
1814         * f-exp.y (type_stack): New global.
1815         Update rules.
1816         (push_kind_type, f_parse): Update.
1817         * d-exp.y (type_stack): New global.
1818         Update rules.
1819         (d_parse): Update.
1820         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1821         Update rules.
1822         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1823         (HFILES_NO_SRCDIR): Add type-stack.h.
1824
1825 2019-04-04  Tom Tromey  <tom@tromey.com>
1826
1827         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1828         (rust_parser::convert_ast_to_expression, rust_parse)
1829         (rust_lex_test_completion, rust_lex_tests): Update.
1830         * parser-defs.h (struct expr_completion_state): New.
1831         (struct parser_state) <parser_state>: Add completion parameter.
1832         <mark_struct_expression, mark_completion_tag>: New methods.
1833         <parse_completion, m_completion_state>: New members.
1834         (prefixify_expression, null_post_parser): Update.
1835         (mark_struct_expression, mark_completion_tag): Don't declare.
1836         * parse.c (parse_completion, expout_last_struct)
1837         (expout_tag_completion_type, expout_completion_name): Remove
1838         globals.
1839         (parser_state::mark_struct_expression)
1840         (parser_state::mark_completion_tag): Now methods.
1841         (prefixify_expression): Add last_struct parameter.
1842         (prefixify_subexp): Likewise.
1843         (parse_exp_1): Update.
1844         (parse_exp_in_context): Add cstate parameter.  Update.
1845         (parse_expression_for_completion): Create an
1846         expr_completion_state.
1847         (null_post_parser): Add "completion" parameter.
1848         * p-exp.y: Update rules.
1849         (yylex): Update.
1850         * language.h (struct language_defn) <la_post_parser>: Add
1851         "completing" parameter.
1852         * go-exp.y: Update rules.
1853         (lex_one_token): Update.
1854         * expression.h (parse_completion): Don't declare.
1855         * d-exp.y: Update rules.
1856         (lex_one_token): Update rules.
1857         * c-exp.y: Update rules.
1858         (lex_one_token): Update.
1859         * ada-lang.c (resolve): Add "parse_completion" parameter.
1860         (resolve_subexp): Likewise.
1861         (ada_resolve_function): Likewise.
1862
1863 2019-04-04  Tom Tromey  <tom@tromey.com>
1864
1865         * parser-defs.h (struct parser_state) <start_arglist,
1866         end_arglist>: New methods.
1867         <arglist_len, m_funcall_chain>: New members.
1868         (arglist_len, start_arglist, end_arglist): Don't declare.
1869         * parse.c (arglist_len, funcall_chain): Remove global.
1870         (start_arglist, end_arglist): Remove functions.
1871         (parse_exp_in_context): Update.
1872         * p-exp.y: Update rules.
1873         * m2-exp.y: Update rules.
1874         * go-exp.y: Update rules.
1875         * f-exp.y: Update rules.
1876         * d-exp.y: Update rules.
1877         * c-exp.y: Update rules.
1878
1879 2019-04-04  Tom Tromey  <tom@tromey.com>
1880
1881         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1882         lex_operator, push_back>: New methods.
1883         Update all rules.
1884         (rust_parser::lex_hex, lex_escape): Rename and update.
1885         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1886         (rust_parser::lex_operator): Rename and update.
1887         (rust_parser::lex_number, rustyylex, rustyyerror)
1888         (rust_lex_test_init, rust_lex_test_sequence)
1889         (rust_lex_test_push_back, rust_lex_tests): Update.
1890         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1891         parameter.
1892         <lexptr, prev_lexptr>: New members.
1893         (lexptr, prev_lexptr): Don't declare.
1894         * parse.c (lexptr, prev_lexptr): Remove globals.
1895         (parse_exp_in_context): Update.
1896         * p-exp.y (yylex, yyerror): Update.
1897         * m2-exp.y (parse_number, yylex, yyerror): Update.
1898         * go-exp.y (lex_one_token, yyerror): Update.
1899         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1900         * d-exp.y (lex_one_token, yyerror): Update.
1901         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1902         (lex_one_token, yyerror): Update.
1903         * ada-lex.l (YY_INPUT): Update.
1904         (rewind_to_char): Update.
1905         * ada-exp.y (yyerror): Update.
1906
1907 2019-04-04  Tom Tromey  <tom@tromey.com>
1908
1909         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1910         * parser-defs.h (struct parser_state) <parser_state>: Add new
1911         parameter.
1912         <comma_terminates>: New member.
1913         (comma_terminates): Don't declare global.
1914         * parse.c (comma_terminates): Remove global.
1915         (parse_exp_in_context): Update.
1916         * p-exp.y (yylex): Update.
1917         * m2-exp.y (yylex): Update.
1918         * go-exp.y (lex_one_token): Update.
1919         * f-exp.y (yylex): Update.
1920         * d-exp.y (lex_one_token): Update.
1921         * c-exp.y (lex_one_token): Update.
1922         * ada-lex.l: Update.
1923
1924 2019-04-04  Tom Tromey  <tom@tromey.com>
1925
1926         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1927         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1928         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1929         * parser-defs.h (paren_depth): Don't declare.
1930         * parse.c (paren_depth): Remove global.
1931         (parse_exp_in_context): Update.
1932         * p-exp.y (paren_depth): New global.
1933         (pascal_parse): Initialize it.
1934         * m2-exp.y (paren_depth): New global.
1935         (m2_parse): Initialize it.
1936         * go-exp.y (paren_depth): New global.
1937         (go_parse): Initialize it.
1938         * f-exp.y (paren_depth): New global.
1939         (f_parse): Initialize it.
1940         * d-exp.y (paren_depth): New global.
1941         (d_parse): Initialize it.
1942         * c-exp.y (paren_depth): New global.
1943         (c_parse): Initialize it.
1944         * ada-lex.l (paren_depth): New global.
1945         (lexer_init): Initialize it.
1946
1947 2019-04-04  Tom Tromey  <tom@tromey.com>
1948
1949         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1950         (rust_parser::convert_ast_to_type)
1951         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1952         * parser-defs.h (struct parser_state) <parser_state>: Add
1953         parameters.  Initialize new members.
1954         <expression_context_block, expression_context_pc>: New members.
1955         * parse.c (expression_context_block, expression_context_pc):
1956         Remove globals.
1957         (parse_exp_in_context): Update.
1958         * p-exp.y: Update all rules.
1959         (yylex): Update.
1960         * m2-exp.y: Update all rules.
1961         (yylex): Update.
1962         * go-exp.y (yylex): Update.
1963         * f-exp.y (yylex): Update.
1964         * d-exp.y: Update all rules.
1965         (yylex): Update.
1966         * c-exp.y: Update all rules.
1967         (lex_one_token, classify_name, yylex, c_parse): Update.
1968         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1969
1970 2019-04-04  Tom Tromey  <tom@tromey.com>
1971
1972         * gdbarch.h, gdbarch.c: Rebuild.
1973         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1974         * stap-probe.h:
1975         (struct stap_parse_info): Replace "parser_state" with
1976         "expr_builder".
1977         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1978         (parser_state): New class.
1979         * parse.c (expr_builder): Rename.
1980         (expr_builder::release): Rename.
1981         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1982         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1983         (write_exp_elt_longcst, write_exp_elt_floatcst)
1984         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1985         (write_exp_string_vector, write_exp_bitstring)
1986         (write_exp_msymbol, mark_struct_expression)
1987         (write_dollar_variable)
1988         (insert_type_address_space, increase_expout_size): Replace
1989         "parser_state" with "expr_builder".
1990         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1991         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1992         "parser_state" with "expr_builder".
1993
1994 2019-04-04  Tom Tromey  <tom@tromey.com>
1995
1996         * rust-exp.y: Replace "parse_language" with method call.
1997         * p-exp.y:
1998         (yylex): Replace "parse_language" with method call.
1999         * m2-exp.y:
2000         (yylex): Replace "parse_language" with method call.
2001         * go-exp.y (classify_name): Replace "parse_language" with method
2002         call.
2003         * f-exp.y (yylex): Replace "parse_language" with method call.
2004         * d-exp.y (lex_one_token): Replace "parse_language" with method
2005         call.
2006         * c-exp.y:
2007         (lex_one_token, classify_name, yylex): Replace "parse_language"
2008         with method call.
2009         * ada-exp.y (find_primitive_type, type_char)
2010         (type_system_address): Replace "parse_language" with method call.
2011
2012 2019-04-04  Tom Tromey  <tom@tromey.com>
2013
2014         * rust-exp.y: Replace "parse_gdbarch" with method call.
2015         * parse.c (write_dollar_variable, insert_type_address_space):
2016         Replace "parse_gdbarch" with method call.
2017         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2018         call.
2019         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2020         call.
2021         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2022         "parse_gdbarch" with method call.
2023         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2024         with method call.
2025         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2026         "parse_gdbarch" with method call.
2027         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2028         "parse_gdbarch" with method call.
2029         * c-exp.y (parse_type, parse_number, classify_name): Replace
2030         "parse_gdbarch" with method call.
2031         * ada-lex.l: Replace "parse_gdbarch" with method call.
2032         * ada-exp.y (parse_type, find_primitive_type, type_char)
2033         (type_system_address): Replace "parse_gdbarch" with method call.
2034
2035 2019-04-04  Tom Tromey  <tom@tromey.com>
2036
2037         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2038         * stap-probe.c (stap_parse_argument): Update.
2039         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2040         initial_size parameter.
2041         * rust-exp.y (rust_lex_tests): Update.
2042         * parse.c (parser_state): Update.
2043         (parse_exp_in_context): Update.
2044         * parser-defs.h (struct parser_state) <parser_state>: Remove
2045         "initial_size" parameter.
2046
2047 2019-04-04  Tom Tromey  <tom@tromey.com>
2048
2049         * parser-defs.h (increase_expout_size): Don't declare.
2050         * parse.c (increase_expout_size): Now static.
2051
2052 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2053
2054         * gnu-nat.c (gnu_nat_target::wait): Fix
2055         target_waitstatus_to_string call.
2056
2057 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * eval.c (evaluate_subexp_standard): Handle internal functions
2060         during Fortran function call handling.
2061
2062 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * NEWS: Mention new internal functions.
2065         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2066         (read_base_type): Use dwarf2_init_complex_target_type.
2067         * value.c (creal_internal_fn): New function.
2068         (cimag_internal_fn): New function.
2069         (_initialize_values): Register new internal functions.
2070
2071 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2072
2073         * infrun.c (stop_all_threads): If debug_infrun, always
2074         trace the wait status after wait_one, using
2075         target_waitstatus_to_string and target_pid_to_str.
2076         (handle_inferior_event): Replace various trace of
2077         wait status kind by a single trace.
2078         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2079         wait status kind image by target_waitstatus_to_string.
2080         * target/waitstatus.c (target_waitstatus_to_string): Fix
2081         obsolete comment.
2082
2083 2019-04-01  Tom Tromey  <tromey@adacore.com>
2084
2085         PR symtab/23331:
2086         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2087
2088 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2089             Pedro Alves  <palves@redhat.com>
2090
2091         * top.c (quit_force): Call 'finalize_values'.
2092         * value.c (finalize_values): New function.
2093         * value.h (finalize_values): Declare.
2094
2095 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2096
2097         * NEWS: Announce $_gdb_major and $_gdb_minor.
2098
2099         * top.c (init_gdb_version_vars): New function.
2100         (gdb_init): Call init_gdb_version_vars.
2101
2102 2019-03-29  Tom Tromey  <tromey@adacore.com>
2103
2104         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2105         help text.  Remove dead code.
2106
2107 2019-03-29  Keith Seitz  <keiths@redhat.com>
2108
2109         From Siddhesh Poyarekar:
2110         * f-lang.h (f77_get_upperbound): Return LONGEST.
2111         (f77_get_lowerbound): Likewise.
2112         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2113         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2114         print them.
2115         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2116         plongest to format print it.
2117         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2118         (f77_get_upperbound): Likewise.
2119         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2120         LOWER_BOUND to LONGEST.
2121         (f77_create_arrayprint_offset_tbl): Likewise.
2122
2123 2019-03-29  Keith Seitz  <keiths@redhat.com>
2124
2125         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2126         %s/pulongest for TYPE_LENGTH instead of %d in format
2127         strings.
2128         * ada-typerint.c (ada_print_type): Likewise.
2129         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2130         * compile/compile-c-support.c (generate_register_struct): Likewise.
2131         * gdbtypes.c (recursive_dump_type): Likewise.
2132         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2133         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2134         instead of %d in format strings.
2135         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2136         to std::min to ULONGEST.
2137         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2138         instead of %d in format strings.
2139         * tracepoint.c (info_scope_command): Likewise.
2140         * typeprint.c (print_offset_data::update)
2141         (print_offset_data::finish): Likewise.
2142         * xtensa-tdep.c (xtensa_store_return_value)
2143         (xtensa_push_dummy_call): Likewise.
2144
2145 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2146
2147         * windows-nat.c (display_selector): Fixed format specifications
2148         for 64-bit Cygwin.
2149
2150 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2151
2152         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2153
2154 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2155
2156         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2157         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2158         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2159         (nios2_linux_init_abi): Install it.
2160
2161 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2162
2163         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2164
2165 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2166
2167         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2168
2169 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2170             Tom Tromey  <tromey@adacore.com>
2171
2172         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2173
2174 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2175
2176         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2177         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2178         method to compute the bounds of range types. Also print "[evaluated]"
2179         if the bounds' values come from a dynamic evaluation.
2180
2181 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2182
2183         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2184         whitespace when pretty printing is on.
2185
2186 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2187
2188         * ppc-linux-nat.c: Add include.
2189
2190 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2191
2192         * NEWS: Mention AArch64 Pointer Authentication.
2193
2194 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * arm-linux-nat.c: Add include.
2197
2198 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2199
2200         * source-cache.c (source_cache::get_source_lines): Re-read
2201         fullname after calling open_source_file.
2202
2203 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2204
2205         * NEWS: Mention TLS support for FreeBSD.
2206
2207 2019-03-25  Tom Tromey  <tromey@adacore.com>
2208
2209         * minsyms.c (BUNCH_SIZE): Update comment.
2210         (~minimal_symbol_reader): Remove old comment.
2211         (compact_minimal_symbols): Update comment.
2212         (minimal_symbol_reader::install): Remove old comment.  Update
2213         other comments.
2214
2215 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2216
2217         * s390-linux-nat.c: Add include.
2218
2219 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2220
2221         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2222         Call linux_get_hwcap.
2223         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2224         Likewise.
2225         (aarch64_linux_get_hwcap): Remove function.
2226         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2227         declaration.
2228         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2229         linux_get_hwcap.
2230         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2231         * linux-tdep.c (linux_get_hwcap): Add function.
2232         (linux_get_hwcap2): Likewise.
2233         * linux-tdep.h (linux_get_hwcap): Add declaration.
2234         (linux_get_hwcap2): Likewise.
2235         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2236         (ppc_linux_get_hwcap2): Likewise.
2237         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2238         linux_get_hwcap.
2239         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2240         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2241         (ppc_linux_nat_target::read_description): Likewise.
2242         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2243         * s390-linux-nat.c: Likewise.
2244         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2245
2246 2019-03-24  Tom Tromey  <tom@tromey.com>
2247
2248         * ada-lang.c (standard_lookup): Simplify initialization.
2249         (ada_lookup_symbol_nonlocal): Simplify return.
2250         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2251         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2252         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2253         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2254         initialization.
2255         * solib.c (solib_global_lookup): Simplify.
2256         * symtab.c (null_block_symbol): Remove.
2257         (symbol_cache_lookup): Simplify returns.
2258         (lookup_language_this): Simplify returns.
2259         (lookup_symbol_aux): Simplify return.
2260         (lookup_local_symbol): Simplify returns.
2261         (lookup_global_symbol_from_objfile): Simplify return.
2262         (lookup_symbol_in_objfile_symtabs)
2263         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2264         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2265         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2266         * cp-namespace.c (cp_lookup_bare_symbol)
2267         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2268         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2269         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2270         (cp_lookup_symbol_via_imports): Simplify initialization.
2271         (find_symbol_in_baseclass): Likewise.
2272         * symtab.h (null_block_symbol): Remove.
2273         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2274         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2275         (d_lookup_symbol_module): Likewise.
2276         (find_symbol_in_baseclass): Simplify initialization.
2277
2278 2019-03-24  Tom Tromey  <tom@tromey.com>
2279
2280         * expression.h: Don't include symtab.h.
2281         (struct block): Forward declare.
2282
2283 2019-03-24  Tom Tromey  <tom@tromey.com>
2284
2285         * c-exp.y (typebase): Remove casts.
2286         * gdbtypes.c (lookup_unsigned_typename, )
2287         (lookup_signed_typename): Remove cast.
2288         * eval.c (parse_to_comma_and_eval): Remove cast.
2289         * parse.c (write_dollar_variable): Remove cast.
2290         * block.h (struct block) <superblock>: Now const.
2291         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2292         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2293         (map_block): Make "block" const.
2294         * symfile.h (struct quick_symbol_functions)
2295         <map_matching_symbols>: Constify block argument to "callback".
2296         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2297         const.
2298         (find_pc_sect_compunit_symtab): Make "b" const.
2299         (find_symbol_at_address): Likewise.
2300         (search_symbols): Likewise.
2301         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2302         (dw2_debug_names_lookup_symbol): Likewise.
2303         (dw2_map_matching_symbols): Update.
2304         * p-valprint.c (pascal_val_print): Remove "block".
2305         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2306         (aux_add_nonlocal_symbols): Make "block" const.
2307         (resolve_subexp): Remove cast.
2308         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2309         const.
2310         (iterate_over_file_blocks): Likewise.
2311         * f-exp.y (%union) <bval>: Remove.
2312         * coffread.c (patch_opaque_types): Make "b" const.
2313         * spu-tdep.c (spu_catch_start): Make "block" const.
2314         * c-valprint.c (print_unpacked_pointer): Remove "block".
2315         * symmisc.c (dump_symtab_1): Make "b" const.
2316         (block_depth): Make "block" const.
2317         * d-exp.y (%union) <bval>: Remove.
2318         * cp-support.h (cp_lookup_rtti_type): Update.
2319         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2320         * psymtab.c (psym_lookup_symbol): Make "block" const.
2321         (maintenance_check_psymtabs): Make "b" const.
2322         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2323         (enumerate_locals, enumerate_args): Update.
2324         * python/py-symtab.c (stpy_global_block): Make "block" const.
2325         (stpy_static_block): Likewise.
2326         * inline-frame.c (block_starting_point_at): Make "new_block"
2327         const.
2328         * block.c (find_block_in_blockvector): Make return type const.
2329         (blockvector_for_pc_sect): Make "b" const.
2330         (find_block_in_blockvector): Make "b" const.
2331
2332 2019-03-23  Tom Tromey  <tom@tromey.com>
2333
2334         * varobj.c (varobj_create): Update.
2335         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2336         * printcmd.c (display_command, do_one_display): Don't reset
2337         innermost_block.
2338         * parser-defs.h (enum innermost_block_tracker_type): Move to
2339         expression.h.
2340         (innermost_block): Update comment.
2341         * parse.c (parse_exp_1): Add tracker_types parameter.
2342         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2343         tracker_types parameter.  Reset innermost_block.
2344         (parse_exp_in_context): Remove.
2345         (parse_expression_for_completion): Update.
2346         * objfiles.c (~objfile): Don't reset expression_context_block or
2347         innermost_block.
2348         * expression.h (enum innermost_block_tracker_type): Move from
2349         parser-defs.h.
2350         (parse_exp_1): Add tracker_types parameter.
2351         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2352         reset innermost_block.
2353
2354 2019-03-23  Tom Tromey  <tom@tromey.com>
2355
2356         * objfiles.h: Include bcache.h.
2357
2358 2019-03-23  Tom Tromey  <tom@tromey.com>
2359
2360         * linespec.c (get_current_search_block): Use
2361         scoped_restore_current_language.
2362         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2363
2364 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2365             Jiong Wang  <jiong.wang@arm.com>
2366
2367         * aarch64-linux-tdep.c
2368         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2369         section.
2370         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2371
2372 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2373             Jiong Wang  <jiong.wang@arm.com>
2374
2375         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2376         instructions.
2377         (aarch64_analyze_prologue_test): Add PACIASP test.
2378         (aarch64_prologue_prev_register): Unmask PC value.
2379
2380 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2381             Jiong Wang  <jiong.wang@arm.com>
2382
2383         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2384         (aarch64_dwarf2_prev_register): Unmask PC value.
2385         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2386         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2387         DW_CFA_AARCH64_negate_ra_state.
2388         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2389
2390 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2391             Jiong Wang  <jiong.wang@arm.com>
2392
2393         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2394         registers.
2395         (aarch64_pseudo_register_name): Likewise.
2396         (aarch64_pseudo_register_type): Likewise.
2397         (aarch64_pseudo_register_reggroup_p): Likewise.
2398         (aarch64_gdbarch_init): Add pauth registers.
2399         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2400         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2401         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2402         (struct gdbarch_tdep): Add regnum for ra_state.
2403
2404 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2405             Jiong Wang  <jiong.wang@arm.com>
2406
2407         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2408
2409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2410             Jiong Wang  <jiong.wang@arm.com>
2411
2412         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2413         function.
2414         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2415         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2416         (aarch64_gdbarch_init): Add puth registers.
2417         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2418         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2419         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2420
2421 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2422             Jiong Wang  <jiong.wang@arm.com>
2423
2424         * aarch64-linux-nat.c
2425         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2426         * aarch64-linux-tdep.c
2427         (aarch64_linux_core_read_description): Likewise.
2428         (aarch64_linux_get_hwcap): New function.
2429         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2430         (aarch64_linux_get_hwcap): New declaration.
2431
2432 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2433             Jiong Wang  <jiong.wang@arm.com>
2434
2435         * aarch64-linux-nat.c
2436         (aarch64_linux_nat_target::read_description): Add pauth param.
2437         * aarch64-linux-tdep.c
2438         (aarch64_linux_core_read_description): Likewise.
2439         * aarch64-tdep.c (struct target_desc): Add in pauth.
2440         (aarch64_read_description): Add pauth param.
2441         (aarch64_gdbarch_init): Likewise.
2442         * aarch64-tdep.h (aarch64_read_description): Likewise.
2443         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2444         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2445         * features/Makefile: Add new files.
2446         * features/aarch64-pauth.c: New file.
2447         * features/aarch64-pauth.xml: New file.
2448
2449 2019-03-20  Tom Tromey  <tromey@adacore.com>
2450
2451         * infrun.c (handle_inferior_event): Rename from
2452         handle_inferior_event_1.  Create a scoped_value_mark.
2453         (handle_inferior_event): Remove.
2454
2455 2019-03-19  Tom Tromey  <tromey@adacore.com>
2456
2457         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2458         * infrun.h (print_stop_event): Add "displays" parameter.
2459         * infrun.c (print_stop_event): Add "displays" parameter.
2460
2461 2019-03-19  Pedro Alves  <palves@redhat.com>
2462
2463         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2464         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2465         to -1.  Fix TABs vs spaces.
2466         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2467         * tui/tui-out.h (tui_ui_out) Add intro comments.
2468         <m_line, m_start_of_line>: In-class initialize, and add describing
2469         comment.
2470
2471 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2472
2473         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2474         variable names.
2475         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2476
2477 2019-03-18  Pedro Alves  <palves@redhat.com>
2478             Eli Zaretskii <eliz@gnu.org>
2479
2480         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2481         m_line and m_start_of_line.
2482
2483 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2484
2485         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2486         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2487         it returns a newline.  This fixes a regression in TU mode, whereby
2488         the next line is output on the same screen line as the user input.
2489
2490 2019-03-18  Tom Tromey  <tromey@adacore.com>
2491
2492         * minsyms.c (minimal_symbol_reader::install): Remove call to
2493         obstack_blank.
2494
2495 2019-03-18  Pedro Alves  <palves@redhat.com>
2496
2497         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2498         New globals.
2499         (apply_style): New, factored out from ...
2500         (apply_ansi_escape): ... this.  Handle reverse video mode.
2501         (tui_set_reverse_mode): New function.
2502         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2503         * tui/tui-winsource.c (tui_show_source_line): Use
2504         tui_set_reverse_mode instead of setting A_STANDOUT.
2505         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2506         New setter methods.
2507
2508 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2509
2510         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2511         Handle tabs.
2512
2513 2019-03-18  Tom Tromey  <tromey@adacore.com>
2514
2515         * ada-lang.c (empty_array): Add "high" parameter.
2516         (ada_evaluate_subexp): Update.
2517
2518 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2519
2520         * unittests/string_view-selftests.c: Define
2521         _initialize_string_view_selftests unconditionally.
2522
2523 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2524
2525         PR gdb/24350
2526         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2527
2528 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2529
2530         PR gdb/24351
2531         * windows-nat.c (display_selector): Fix format specifiers.
2532
2533 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2534
2535         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2536         tui_refill_source_window instead of tui_refresh_win, to update the
2537         current execution line.  This fixes redisplay of the current line
2538         when stepping through the code with "next" or "step".
2539
2540 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2541
2542         * source-cache.c (source_cache::get_source_lines): Call
2543         find_source_lines to initialize s->nlines.  This fixes vertical
2544         scrolling of TUI source window when the DOWN arrow is pressed.
2545
2546 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2547
2548         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2549         linux-thread-db.c (_initialize_thread_db): Likewise.
2550
2551 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2552
2553         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2554         wclrtoeol in tui_show_source_line".  This reverts changes made in
2555         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2556
2557 2019-03-15  Tom Tromey  <tom@tromey.com>
2558
2559         * symtab.h (struct minimal_symbol): Derive from
2560         general_symbol_info.
2561         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2562         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2563         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2564         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2565         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2566         (MSYMBOL_SEARCH_NAME): Update.
2567         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2568         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2569         * minsyms.c (minimal_symbol_reader::record_full): Update.
2570
2571 2019-03-15  Tom Tromey  <tom@tromey.com>
2572
2573         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2574
2575 2019-03-15  Tom Tromey  <tom@tromey.com>
2576
2577         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2578         unique_xmalloc_ptr.
2579         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2580         Update.
2581         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2582         (build_minimal_symbol_hash_tables)
2583         (minimal_symbol_reader::install): Update.
2584
2585 2019-03-15  Tom Tromey  <tom@tromey.com>
2586
2587         * symtab.c (create_demangled_names_hash): Update.
2588         (symbol_set_names): Update.
2589         * objfiles.h (struct objfile_per_bfd_storage)
2590         <demangled_names_hash>: Now an htab_up.
2591         * objfiles.c (objfile_per_bfd_storage): Simplify.
2592
2593 2019-03-15  Tom Tromey  <tom@tromey.com>
2594
2595         * objfiles.h (struct objfile_per_bfd_storage): Declare
2596         destructor.
2597         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2598         New.
2599         (get_objfile_bfd_data): Use new.  Don't initialize
2600         language_of_main.
2601         (free_objfile_per_bfd_storage): Remove.
2602         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2603
2604 2019-03-15  Tom Tromey  <tom@tromey.com>
2605
2606         * symfile.c (reread_symbols): Update.
2607         * objfiles.c (objfile::objfile): Update.
2608         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2609         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2610         comment.
2611         (minimal_symbol_reader::install): Update.
2612         (terminate_minimal_symbol_table): Remove.
2613         * jit.c (jit_object_close_impl): Update.
2614
2615 2019-03-15  Tom Tromey  <tom@tromey.com>
2616
2617         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2618         initializations.
2619
2620 2019-03-15  Tom Tromey  <tom@tromey.com>
2621
2622         * objfiles.h (struct objfile_per_bfd_storage)
2623         <demangled_hash_languages>: Now a bitset.
2624         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2625         (lookup_minimal_symbol): Update.
2626
2627 2019-03-15  Tom Tromey  <tom@tromey.com>
2628
2629         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2630         Don't return the symbol.
2631         * coffread.c (record_minimal_symbol): Use record_full.
2632
2633 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2634
2635         The MS-Windows port of ncurses fails to switch to a color pair if
2636         one or both of the colors are the implicit default colors.  This
2637         change records the default colors when TUI is initialized, and
2638         then specifies them explicitly when a color pair uses the default
2639         colors.  This allows color styling in TUI mode on MS-Windows.
2640
2641         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2642         ncurses_norm_attr.
2643         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2644         colors in ncurses_norm_attr.
2645         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2646         "none", replace it with the default color recorded in
2647         ncurses_norm_attr.
2648
2649 2019-03-14  Tom Tromey  <tromey@adacore.com>
2650
2651         * source-cache.h (class source_cache) <get_source_lines>: Return
2652         std::string.
2653         * source-cache.c (source_cache::extract_lines): Handle case where
2654         first_pos==npos.  Return std::string.
2655         (source_cache::get_source_lines): Update.
2656
2657 2019-03-14  Tom Tromey  <tromey@adacore.com>
2658
2659         * NEWS: Add item for "style sources" commands.
2660         * source-cache.c (source_cache::get_source_lines): Check
2661         source_styling.
2662         * cli/cli-style.c (source_styling): New global.
2663         (_initialize_cli_style): Add "style sources" commands.
2664         (show_style_sources): New function.
2665         * cli/cli-style.h (source_styling): Declare.
2666
2667 2019-03-14  Pedro Alves  <palves@redhat.com>
2668             Tom Tromey  <tromey@adacore.com>
2669
2670         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2671         * tui/tui-winsource.c (tui_refill_source_window): New function,
2672         from...
2673         (tui_horizontal_source_scroll): ... here.  Move some logic.
2674         * cli/cli-style.c (set_style_enabled): Notify new observable.
2675         * tui/tui-hooks.c (tui_redisplay_source): New function.
2676         (tui_attach_detach_observers): Attach or detach
2677         tui_redisplay_source.
2678         * observable.h (source_styling_changed): New observable.
2679         * observable.c: Define source_styling_changed observable.
2680
2681 2019-03-13  Tom Tromey  <tromey@adacore.com>
2682
2683         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2684         (i386_gnu_nat_target::store_registers): Update.
2685         * target-debug.h (target_debug_print_std_string): New macro.
2686         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2687         * windows-tdep.c (display_one_tib): Update.
2688         * tui/tui-stack.c (tui_make_status_line): Update.
2689         * top.c (print_inferior_quit_action): Update.
2690         * thread.c (thr_try_catch_cmd): Update.
2691         (add_thread_with_info): Update.
2692         (thread_target_id_str): Update.
2693         (thr_try_catch_cmd): Update.
2694         (thread_command): Update.
2695         (thread_find_command): Update.
2696         * record-btrace.c (record_btrace_target::info_record)
2697         (record_btrace_resume_thread, record_btrace_target::resume)
2698         (record_btrace_cancel_resume, record_btrace_step_thread)
2699         (record_btrace_target::wait, record_btrace_target::wait)
2700         (record_btrace_target::wait, record_btrace_target::stop): Update.
2701         * progspace.c (print_program_space): Update.
2702         * process-stratum-target.c
2703         (process_stratum_target::thread_address_space): Update.
2704         * linux-fork.c (linux_fork_mourn_inferior)
2705         (detach_checkpoint_command, info_checkpoints_command)
2706         (linux_fork_context): Update.
2707         (linux_fork_detach): Update.
2708         (class scoped_switch_fork_info): Update.
2709         (delete_checkpoint_command): Update.
2710         * infrun.c (follow_fork_inferior): Update.
2711         (follow_fork_inferior): Update.
2712         (proceed_after_vfork_done): Update.
2713         (handle_vfork_child_exec_or_exit): Update.
2714         (follow_exec): Update.
2715         (displaced_step_prepare_throw): Update.
2716         (displaced_step_restore): Update.
2717         (start_step_over): Update.
2718         (resume_1): Update.
2719         (clear_proceed_status_thread): Update.
2720         (proceed): Update.
2721         (print_target_wait_results): Update.
2722         (do_target_wait): Update.
2723         (context_switch): Update.
2724         (stop_all_threads): Update.
2725         (restart_threads): Update.
2726         (finish_step_over): Update.
2727         (handle_signal_stop): Update.
2728         (switch_back_to_stepped_thread): Update.
2729         (keep_going_pass_signal): Update.
2730         (print_exited_reason): Update.
2731         (normal_stop): Update.
2732         * inferior.c (inferior_pid_to_str): Change return type.
2733         (print_selected_inferior): Update.
2734         (add_inferior): Update.
2735         (detach_inferior): Update.
2736         * dummy-frame.c (fprint_dummy_frames): Update.
2737         * dcache.c (dcache_info_1): Update.
2738         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2739         (btrace_fetch, btrace_clear): Update.
2740         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2741         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2742         type.
2743         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2744         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2745         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2746         * gdbarch.c, gdbarch.h: Rebuild.
2747         * gdbarch.sh (core_pid_to_str): Change return type.
2748         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2749         return type.
2750         (windows_nat_target::pid_to_str): Change return type.
2751         (windows_delete_thread): Update.
2752         (windows_nat_target::attach): Update.
2753         (windows_nat_target::files_info): Update.
2754         * target-delegates.c: Rebuild.
2755         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2756         return type.
2757         (sol_thread_target::pid_to_str): Change return type.
2758         * remote.c (class remote_target) <pid_to_str>: Change return
2759         type.
2760         (remote_target::pid_to_str): Change return type.
2761         (extended_remote_target::attach, remote_target::remote_stop_ns)
2762         (remote_target::remote_notif_remove_queued_reply)
2763         (remote_target::push_stop_reply, remote_target::disable_btrace):
2764         Update.
2765         (extended_remote_target::attach): Update.
2766         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2767         type.
2768         (gdbsim_target::pid_to_str): Change return type.
2769         * ravenscar-thread.c (struct ravenscar_thread_target)
2770         <pid_to_str>: Change return type.
2771         (ravenscar_thread_target::pid_to_str): Change return type.
2772         * procfs.c (class procfs_target) <pid_to_str>: Change return
2773         type.
2774         (procfs_target::pid_to_str): Change return type.
2775         (procfs_target::attach): Update.
2776         (procfs_target::detach): Update.
2777         (procfs_target::fetch_registers): Update.
2778         (procfs_target::store_registers): Update.
2779         (procfs_target::wait): Update.
2780         (procfs_target::files_info): Update.
2781         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2782         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2783         return type.
2784         (nto_procfs_target::pid_to_str): Change return type.
2785         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2786         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2787         return type.
2788         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2789         (exit_lwp): Update.
2790         (attach_proc_task_lwp_callback, get_detach_signal)
2791         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2792         (linux_nat_target::resume, wait_lwp, stop_callback)
2793         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2794         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2795         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2796         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2797         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2798         type.
2799         (inf_ptrace_target::attach): Update.
2800         (inf_ptrace_target::files_info): Update.
2801         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2802         type.
2803         (go32_nat_target::pid_to_str): Change return type.
2804         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2805         (gnu_nat_target::wait): Update.
2806         (gnu_nat_target::wait): Update.
2807         (gnu_nat_target::resume): Update.
2808         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2809         (fbsd_nat_target::wait): Update.
2810         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2811         type.
2812         (darwin_nat_target::attach): Update.
2813         * corelow.c (class core_target) <pid_to_str>: Change return type.
2814         (core_target::pid_to_str): Change return type.
2815         * target.c (normal_pid_to_str): Change return type.
2816         (default_pid_to_str): Likewise.
2817         (target_pid_to_str): Change return type.
2818         (target_translate_tls_address): Update.
2819         (target_announce_detach): Update.
2820         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2821         return type.
2822         (bsd_uthread_target::pid_to_str): Change return type.
2823         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2824         type.
2825         (bsd_kvm_target::pid_to_str): Change return type.
2826         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2827         return type.
2828         (aix_thread_target::pid_to_str): Change return type.
2829         * target.h (struct target_ops) <pid_to_str>: Change return type.
2830         (target_pid_to_str, normal_pid_to_str): Likewise.
2831         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2832         type.
2833         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2834         type.
2835         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2836         return type.
2837         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2838         type.
2839         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2840         type.
2841         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2842         return type.
2843
2844 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2845
2846         * NEWS: Mention that the new default MI version is 3.  Mention
2847         changes to the output of commands and events that deal with
2848         multi-location breakpoints.
2849         * breakpoint.c: Include "mi/mi-out.h".
2850         (print_one_breakpoint): Change output syntax if using MI version
2851         >= 3.
2852         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2853         New.
2854         (mi_multi_location_breakpoint_output_fixed): New.
2855         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2856         (mi_cmd_fix_multi_location_breakpoint_output): New.
2857         (mi_multi_location_breakpoint_output_fixed): New.
2858         * mi/mi-cmds.c (mi_cmds): Register command
2859         -fix-multi-location-breakpoint-output.
2860         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2861         interpreter "mi".
2862
2863 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2864
2865         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2866         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2867         instantiate mi_ui_out based on interpreter name.
2868         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2869         * mi/mi-main.c (mi_load_progress): Likewise.
2870
2871 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2872
2873         * NEWS: Combine separate "New targets" sections for 8.3.
2874
2875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2876
2877         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2878         (ppcfbsd_init_abi): Install gdbarch
2879         "fetch_tls_load_module_address" and "get_thread_local_address"
2880         methods.
2881
2882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2883
2884         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2885         (riscv_fbsd_init_abi): Install gdbarch
2886         "fetch_tls_load_module_address" and "get_thread_local_address"
2887         methods.
2888
2889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2890
2891         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2892         (i386fbsd_init_abi): Install gdbarch
2893         "fetch_tls_load_module_address" and "get_thread_local_address"
2894         methods.
2895
2896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2897
2898         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2899         (amd64fbsd_init_abi): Install gdbarch
2900         "fetch_tls_load_module_address" and "get_thread_local_address"
2901         methods.
2902
2903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2904
2905         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2906         (struct fbsd_pspace_data): New type.
2907         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2908         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2909         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2910         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2911         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2912
2913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2914
2915         * gdbtypes.c (lookup_struct_elt): New function.
2916         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2917         * gdbtypes.h (struct struct_elt): New type.
2918         (lookup_struct_elt): New prototype.
2919
2920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2921
2922         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2923         remove disabled code block.
2924
2925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2926
2927         * gdbarch.sh (get_thread_local_address): New method.
2928         * gdbarch.h, gdbarch.c: Regenerate.
2929         * target.c (target_translate_tls_address): Use
2930         gdbarch_get_thread_local_address if present instead of
2931         target::get_thread_local_address.
2932
2933 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2934
2935         * target.h (target::get_thread_local_address): Update comment.
2936
2937 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2938
2939         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2940         objfile->separate_debug_objfile_backlink if not NULL.
2941
2942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2943
2944         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2945         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2946         (amd64bsd_store_inferior_registers): Likewise.
2947         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2948         Enable segment base registers.
2949         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2950         PT_GETFSBASE and PT_GETGSBASE.
2951         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2952         PT_SETGSBASE.
2953         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2954         segment base registers.
2955         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2956
2957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2958
2959         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2960         Update calls to i386_target_description to add 'segments'
2961         parameter.
2962         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2963         add segment base registers.
2964         * arch/i386.c (i386_create_target_description): Add 'segments'
2965         parameter to enable segment base registers.
2966         * arch/i386.h (i386_create_target_description): Likewise.
2967         * features/i386/32bit-segments.xml: New file.
2968         * features/i386/32bit-segments.c: Generate.
2969         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2970         call to i386_target_description to add 'segments' parameter.
2971         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2972         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2973         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2974         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2975         if feature is present.
2976         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2977         Add 'segments' parameter to call to i386_target_description.
2978         (i386_target_description): Add 'segments' parameter to enable
2979         segment base registers.
2980         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2981         to call to i386_target_description.
2982         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2983         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2984         Define I386_NUM_REGS.
2985         (i386_target_description): Add 'segments' parameter to enable
2986         segment base registers.
2987
2988 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2989
2990         PR/24325
2991         * source-cache.c: #undef open and close, to avoid unresolved
2992         externals during linking.
2993
2994 2019-03-12  Tom Tromey  <tromey@adacore.com>
2995
2996         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2997         const.  Add initializers.
2998         (_initialize_remote): Don't initialize ptid globals.
2999
3000 2019-03-12  Pedro Alves  <palves@redhat.com>
3001
3002         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3003
3004 2019-03-12  Pedro Alves  <palves@redhat.com>
3005
3006         * cp-name-parser.y (main): Remove unused 'len' variable.
3007
3008 2019-03-12  Tom Tromey  <tromey@adacore.com>
3009
3010         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3011         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3012
3013 2019-03-12  Tom Tromey  <tromey@adacore.com>
3014
3015         * linux-nat.c (iterate_over_lwps): Update.
3016         (stop_callback): Remove parameter.
3017         (stop_wait_callback, detach_callback, resume_set_callback)
3018         (select_singlestep_lwp_callback, set_ignore_sigint)
3019         (status_callback, resumed_callback, resume_clear_callback)
3020         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3021         data parameter.
3022         (linux_nat_target::detach, linux_nat_target::resume)
3023         (linux_stop_and_wait_all_lwps, select_event_lwp)
3024         (linux_nat_filter_event, linux_nat_wait_1)
3025         (linux_nat_target::kill, linux_nat_target::stop)
3026         (linux_nat_target::stop): Update.
3027         (linux_nat_resume_callback): Change type.
3028         (resume_stopped_resumed_lwps, count_events_callback)
3029         (select_event_lwp_callback): Likewise.
3030         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3031         * arm-linux-nat.c (struct update_registers_data): Remove.
3032         (update_registers_callback): Change type.
3033         (arm_linux_insert_hw_breakpoint1): Update.
3034         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3035         parameter.
3036         (x86_linux_dr_set_addr): Update.
3037         (x86_linux_dr_set_control): Update.
3038         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3039         (iterate_over_lwps): Use gdb::function_view.
3040         * nat/aarch64-linux-hw-point.c (struct
3041         aarch64_dr_update_callback_param): Remove.
3042         (debug_reg_change_callback): Change type.
3043         (aarch64_notify_debug_reg_change): Update.
3044         * s390-linux-nat.c (s390_refresh_per_info): Update.
3045
3046 2019-03-11  Tom Tromey  <tromey@adacore.com>
3047
3048         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3049         redundant assignment to "this_cu".
3050
3051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3052
3053         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3054
3055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3056
3057         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3058         from...
3059         (rank_one_type): ... this.
3060
3061 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3062
3063         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3064         from...
3065         (rank_one_type): ... this.
3066
3067 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3068
3069         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3070         from...
3071         (rank_one_type): ... this.
3072
3073 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3074
3075         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3076         from...
3077         (rank_one_type): ... this.
3078
3079 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3080
3081         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3082         from...
3083         (rank_one_type): ... this.
3084
3085 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3086
3087         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3088         from...
3089         (rank_one_type): ... this.
3090
3091 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3092
3093         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3094         from...
3095         (rank_one_type): ... this.
3096
3097 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3098
3099         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3100         from...
3101         (rank_one_type): ... this.
3102
3103 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3104
3105         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3106         from...
3107         (rank_one_type): ... this.
3108
3109 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3110
3111         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3112         from...
3113         (rank_one_type): ... this.
3114
3115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3116
3117         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3118         from...
3119         (rank_one_type): ... this.
3120
3121 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3122
3123         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3124         from...
3125         (rank_one_type): ... this.
3126
3127 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3128
3129         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3130         inferior-events' shows the example events.
3131
3132 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3133
3134         Support styling on native MS-Windows console
3135
3136         PR/24315
3137         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3138         on MS-Windows if $TERM is not defined.
3139
3140         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3141
3142         * posix-hdep.c (gdb_console_fputs):
3143         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3144         functions.
3145         * ui-file.h (gdb_console_fputs): Add prototype.
3146
3147         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3148         back to fputs only if the former returns zero.
3149
3150 2019-03-07  Tom Tromey  <tom@tromey.com>
3151
3152         * symmisc.c (print_symbol_bcache_statistics): Update.
3153         (print_objfile_statistics): Update.
3154         * symfile.c (allocate_symtab): Update.
3155         * stabsread.c: Don't include bcache.h.
3156         * psymtab.h (struct psymbol_bcache): Don't declare.
3157         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3158         (psymbol_bcache_init, psymbol_bcache_free)
3159         (psymbol_bcache_get_bcache): Don't declare.
3160         * psymtab.c (struct psymbol_bcache): Remove.
3161         (psymtab_storage::psymtab_storage): Update.
3162         (psymtab_storage::~psymtab_storage): Update.
3163         (psymbol_bcache_init, psymbol_bcache_free)
3164         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3165         (add_psymbol_to_bcache): Update.
3166         (allocate_psymtab): Update.
3167         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3168         macro_cache>: No longer pointers.
3169         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3170         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3171         * macrotab.c (macro_bcache): Update.
3172         * macroexp.c: Don't include bcache.h.
3173         * gdbtypes.c (check_types_worklist): Update.
3174         (types_deeply_equal): Remove TRY/CATCH.  Update.
3175         * elfread.c (elf_symtab_read): Update.
3176         * dwarf2read.c: Don't include bcache.h.
3177         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3178         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3179         (print_bcache_statistics, bcache_memory_used): Don't declare.
3180         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3181         methods.  Rename all data members.
3182         * bcache.c (struct bcache): Move to bcache.h.
3183         (bcache::expand_hash_table): Rename from expand_hash_table.
3184         (bcache): Remove.
3185         (bcache::insert): Rename from bcache_full.
3186         (bcache::compare): Rename from bcache_compare.
3187         (bcache_xmalloc): Remove.
3188         (bcache::~bcache): Rename from bcache_xfree.
3189         (bcache::print_statistics): Rename from print_bcache_statistics.
3190         (bcache::memory_used): Rename from bcache_memory_used.
3191
3192 2019-03-07  Pedro Alves  <palves@redhat.com>
3193
3194         * infrun.c (normal_stop): Also check for
3195         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3196
3197 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * f-lang.c (value_from_host_double): Moved to...
3200         * value.c (value_from_host_double): ...here.
3201         * value.h (value_from_host_double): Declare.
3202         * guile/scm-math.c (vlscm_convert_typed_number): Use
3203         value_from_host_double.
3204         (vlscm_convert_number): Likewise.
3205         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3206         * python/py-value.c (convert_value_from_python): Likewise.
3207
3208 2019-03-06  Tom Tromey  <tom@tromey.com>
3209
3210         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3211
3212 2019-03-06  Tom Tromey  <tom@tromey.com>
3213
3214         * utils.h (free_current_contents): Don't declare.
3215         * utils.c (free_current_contents): Remove.
3216
3217 2019-03-06  Tom Tromey  <tom@tromey.com>
3218
3219         * top.c (quit_force): Update.
3220         * main.c (captured_command_loop): Update.
3221         * common/new-op.c (operator new): Update.
3222         * common/common-exceptions.c (struct catcher)
3223         <save_cleanup_chain>: Remove member.
3224         (exceptions_state_mc_init): Update.
3225         (exception_try_scope_entry): Return nullptr.
3226         (exception_try_scope_exit, exception_rethrow)
3227         (throw_exception_sjlj, throw_exception_cxx): Update.
3228         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3229         (all_cleanups, do_cleanups, discard_cleanups)
3230         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3231         (restore_cleanups, restore_final_cleanups): Don't declare.
3232         (do_final_cleanups): Remove parameter.
3233         * common/cleanups.c (cleanup_chain, make_cleanup)
3234         (make_cleanup_dtor, all_cleanups, do_cleanups)
3235         (discard_my_cleanups, discard_cleanups)
3236         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3237         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3238         (null_cleanup): Remove.
3239         (do_final_cleanups): Remove parameter.
3240
3241 2019-03-06  Tom Tromey  <tom@tromey.com>
3242
3243         * remote.c (remote_target::remote_parse_stop_reply): Use
3244         unique_xmalloc_ptr.
3245
3246 2019-03-06  Tom Tromey  <tom@tromey.com>
3247
3248         * stabsread.c (struct stabs_field_info): Rename from field_info.
3249         <list, fnlist>: Add initializers.
3250         <obstack>: New member.
3251         (read_member_functions, read_struct_fields, read_baseclasses):
3252         Allocate on obstack.  Don't use cleanups.
3253         (read_one_struct_field, read_member_functions, read_struct_fields)
3254         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3255         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3256         (read_struct_type): Update.
3257
3258 2019-03-06  Tom Tromey  <tom@tromey.com>
3259
3260         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3261         * common/filestuff.h (make_cleanup_close): Don't declare.
3262         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3263         Remove.
3264
3265 2019-03-06  Tom Tromey  <tom@tromey.com>
3266
3267         * solib-aix.c: Use make_scope_exit.
3268
3269 2019-03-06  Tom Tromey  <tom@tromey.com>
3270
3271         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3272         Use make_scope_exit.
3273
3274 2019-03-06  Tom Tromey  <tom@tromey.com>
3275
3276         * solib-svr4.c (disable_probes_interface): Remove parameter.
3277         (svr4_handle_solib_event): Use make_scope_exit.
3278
3279 2019-03-06  Tom Tromey  <tom@tromey.com>
3280
3281         * remote.c (struct stop_reply_deleter): Remove.
3282         (stop_reply_up): Update.
3283         (struct stop_reply): Derive from notif_event.  Don't typedef.
3284         <regcache>: Now a std::vector.
3285         (stop_reply_xfree): Remove.
3286         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3287         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3288         (remote_target::discard_pending_stop_replies): Use delete.
3289         (remote_target::remote_parse_stop_reply): Update.
3290         (remote_target::process_stop_reply): Update.
3291         * remote-notif.h (struct notif_event): Add virtual destructor.
3292         Remove "dtr" member.
3293         (struct notif_client) <alloc_event>: Return a unique_ptr.
3294         (notif_event_xfree): Don't declare.
3295         (notif_event_up): New typedef.
3296         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3297         (notif_event_xfree, do_notif_event_xfree): Remove.
3298         (remote_notif_state_xfree): Update.
3299
3300 2019-03-06  Tom Tromey  <tom@tromey.com>
3301
3302         * infrun.c (displaced_step_clear_cleanup): Now a
3303         forward_scope_exit type.
3304         (displaced_step_prepare_throw): Update.
3305         (displaced_step_fixup): Update.
3306
3307 2019-03-06  Tom Tromey  <tom@tromey.com>
3308
3309         * inferior.h (class inferior): Update comment.
3310         * gdbthread.h (class thread_info): Update comment.
3311
3312 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3313             Tom Tromey  <tom@tromey.com>
3314
3315         * stabsread.h (struct stab_section_list): Remove.
3316         (coffstab_build_psymtabs): Update.
3317         * dbxread.c (symbuf_sections): Now a std::vector.
3318         (sect_idx): New global.
3319         (fill_symbuf): Update.
3320         (coffstab_build_psymtabs): Change type of stabsects parameter.
3321         Update.
3322         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3323         std::vector.
3324         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3325         (coff_locate_sections): Update.
3326         (coff_symfile_read): Remove cleanups.  Update.
3327         (init_stringtab): Add storage parameter.
3328         (free_stringtab, free_stringtab_cleanup): Remove.
3329         (init_lineno): Add storage parameter.
3330         (free_linetab, free_linetab_cleanup): Remove.
3331
3332 2019-03-06  Pedro Alves  <palves@redhat.com>
3333
3334         * linux-fork.c (fork_info::clobber_regs): Delete.
3335         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3336         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3337         comment.  Adjust.
3338         (scoped_switch_fork_info::scoped_switch_fork_info)
3339         (checkpoint_command, linux_fork_context): Adjust
3340         fork_save_infrun_state calls.
3341
3342 2019-03-06  Pedro Alves  <palves@redhat.com>
3343
3344         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3345         (inf_has_multiple_threads): Return 'bool' and rewrite using
3346         inferior_info::threads().
3347
3348 2019-03-06  Pedro Alves  <palves@redhat.com>
3349
3350         * linux-fork.c: Include <list>.
3351         (fork_list): Now a std::list instance.
3352         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3353         (forks_exist_p, find_last_fork): Adjust.
3354         (new_fork): Delete.
3355         (one_fork_p): New.
3356         (add_fork): Adjust.
3357         (free_fork): Delete, folded into fork_info::~fork_info().
3358         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3359         Adjust.
3360         (init_fork_list): Delete.
3361         (linux_fork_killall, linux_fork_mourn_inferior)
3362         (linux_fork_detach, info_checkpoints_command): Adjust.
3363         (_initialize_linux_fork): No longer call init_fork_list.
3364
3365 2019-03-06  Pedro Alves  <palves@redhat.com>
3366
3367         * linux-fork.c (new_fork): New, split out of ...
3368         (add_fork): ... this.  Return void.  Move "first fork" special
3369         case from here, to ...
3370         (checkpoint_command): ... here.
3371         * linux-linux.h (add_fork): Return void.
3372
3373 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3374
3375         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3376
3377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3378             Chris January  <chris.january@arm.com>
3379             David Lecomber  <david.lecomber@arm.com>
3380
3381         * f-exp.y: New token, UNOP_INTRINSIC.
3382         (exp): New pattern using UNOP_INTRINSIC token.
3383         (f77_keywords): Add 'abs' keyword.
3384         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3385         (value_from_host_double): New function.
3386         (evaluate_subexp_f): Support UNOP_ABS.
3387
3388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3391         types.
3392
3393 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3396         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3397         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3398
3399 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3400
3401         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3402
3403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3404             Chris January  <chris.january@arm.com>
3405
3406         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3407         * f-exp.y: Define 'KIND' token.
3408         (exp): New pattern for KIND expressions.
3409         (ptype): Handle types with a kind extension.
3410         (direct_abs_decl): Extend to spot kind extensions.
3411         (f77_keywords): Add 'kind' to the list.
3412         (push_kind_type): New function.
3413         (convert_to_kind_type): New function.
3414         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3415         * parse.c (operator_length_standard): Likewise.
3416         * parser-defs.h (enum type_pieces): Add tp_kind.
3417         * std-operator.def: Add UNOP_KIND.
3418
3419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * f-exp.y (f_parse): Set yydebug.
3422
3423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * f-lang.c (evaluate_subexp_f): New function.
3426         (exp_descriptor_f): New global.
3427         (f_language_defn): Use exp_descriptor_f instead of
3428         exp_descriptor_standard.
3429
3430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * f-exp.y (struct token): Add comments.
3433         (dot_ops): Remove uppercase versions and the end marker.
3434         (f77_keywords): Likewise.
3435         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3436         entries in the dot_ops array are case insensitive, and use
3437         strncasecmp to compare strings.  Also some whitespace cleanup in
3438         this area.  Similar for the f77_keywords array, except entries in
3439         this list might be case sensitive.
3440
3441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * f-exp.y (struct f77_boolean_val): Add comments.
3444         (boolean_values): Remove uppercase versions, and end marker.
3445         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3446         and use strncasecmp to achieve case insensitivity.  Additionally,
3447         perform whitespace cleanup around this code.
3448
3449 2019-03-06  Tom Tromey  <tromey@adacore.com>
3450
3451         * remote-sim.c (gdbsim_target_open): Use result of
3452         gdb_argv::release.
3453
3454 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3455         Dirk Schubert  <dirk.schubert@arm.com>
3456         Chris January  <chris.january@arm.com>
3457
3458         * eval.c (evaluate_subexp_standard): Call Fortran argument
3459         wrapping logic.
3460         * f-lang.c (struct value): A value which can be passed into a
3461         Fortran function call.
3462         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3463         where appropriate.
3464         (struct type): Value ready for a Fortran function call.
3465         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3466         is needed.
3467         * f-lang.h (fortran_argument_convert): Declaration.
3468         (fortran_preserve_arg_pointer): Declaration.
3469         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3470
3471 2019-03-05  Tom Tromey  <tromey@adacore.com>
3472
3473         * python/py-prettyprint.c (print_string_repr): Remove #if.
3474         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3475
3476 2019-03-05  Tom Tromey  <tromey@adacore.com>
3477
3478         * target.c (the_dummy_target): Move later.  Change type to
3479         "dummy_target".
3480         (initialize_targets): Don't initialize the_dummy_target.
3481
3482 2019-03-05  Tom Tromey  <tromey@adacore.com>
3483
3484         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3485         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3486
3487 2019-03-05  Tom Tromey  <tromey@adacore.com>
3488
3489         * windows-nat.c (windows_nat_target::attach)
3490         (windows_nat_target::detach): Don't call gdb_flush.
3491         * valprint.c (generic_val_print, val_print, val_print_string):
3492         Don't call gdb_flush.
3493         * utils.c (defaulted_query): Don't call gdb_flush.
3494         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3495         * target.c (target_announce_detach): Don't call gdb_flush.
3496         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3497         * remote.c (extended_remote_target::attach): Don't call
3498         gdb_flush.
3499         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3500         * printcmd.c (do_examine): Don't call gdb_flush.
3501         (info_display_command): Don't call gdb_flush.
3502         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3503         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3504         * memattr.c (info_mem_command): Don't call gdb_flush.
3505         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3506         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3507         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3508         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3509         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3510         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3511         (gnu_nat_target::detach): Don't call gdb_flush.
3512         * f-valprint.c (f_val_print): Don't call gdb_flush.
3513         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3514         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3515         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3516         gdb_flush.
3517         * c-valprint.c (c_val_print): Don't call gdb_flush.
3518         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3519
3520 2019-03-05  Tom Tromey  <tromey@adacore.com>
3521
3522         * varobj.c (update_dynamic_varobj_children): Update.
3523         (install_default_visualizer): Use reset, not release.
3524         * value.c (set_internalvar): Update.
3525         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3526         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3527         ATTRIBUTE_UNUSED_RESULT.
3528
3529 2019-03-05  Tom Tromey  <tromey@adacore.com>
3530
3531         * remote.c (class scoped_remote_fd) <release>: Add
3532         ATTRIBUTE_UNUSED_RESULT.
3533
3534 2019-03-05  Tom Tromey  <tromey@adacore.com>
3535
3536         * macroexp.c (struct macro_buffer) <release>: Add
3537         ATTRIBUTE_UNUSED_RESULT.
3538
3539 2019-03-05  Tom Tromey  <tromey@adacore.com>
3540
3541         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3542         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3543         ATTRIBUTE_UNUSED_RESULT.
3544
3545 2019-03-05  Tom Tromey  <tromey@adacore.com>
3546
3547         * common/scoped_fd.h (class scoped_fd) <release>: Add
3548         ATTRIBUTE_UNUSED_RESULT.
3549
3550 2019-03-05  Tom Tromey  <tromey@adacore.com>
3551
3552         * parser-defs.h (struct parser_state) <release>: Add
3553         ATTRIBUTE_UNUSED_RESULT.
3554
3555 2019-03-05  Tom Tromey  <tromey@adacore.com>
3556
3557         * utils.h (class gdb_argv) <release>: Add
3558         ATTRIBUTE_UNUSED_RESULT.
3559         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3560
3561 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3562
3563         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3564         for-loop range, to avoid compiler warnings.
3565
3566         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3567         avoid compiler warnings about unused variables.
3568
3569         * NEWS: Mention end of support for native debugging on MS-Windows
3570         before XP.
3571
3572         PR gdb/24292
3573         * common/netstuff.c:
3574         * gdbserver/gdbreplay.c
3575         * gdbserver/remote-utils.c:
3576         * ser-tcp.c:
3577         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3578         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3579         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3580         'getaddrinfo' and 'freeaddrinfo' were not available before
3581         Windows XP, and mingw.org's MinGW headers by default define
3582         _WIN32_WINNT to 0x500.
3583
3584 2019-03-01  Gary Benson <gbenson@redhat.com>
3585
3586         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3587
3588 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3589             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3590
3591         PR gdb/8527
3592         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3593         set_sigint_trap, clear_sigint_trap.
3594
3595 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3596
3597         * target.c (target_detach): Clear the regcache and the
3598         frame cache.
3599
3600 2019-02-27  Pedro Alves  <palves@redhat.com>
3601
3602         * utils.c (set_screen_size): When we cap the height/width sizes,
3603         tweak the corresponding command variable to show "unlimited":
3604
3605 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3606             Pedro Alves  <palves@redhat.com>
3607
3608         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3609         before calling rl_set_screen_size.
3610
3611 2019-02-27  Tom Tromey  <tromey@adacore.com>
3612
3613         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3614         define.
3615         * python/py-value.c: Remove Python 2.4 workaround.
3616         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3617         workaround.
3618         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3619         Python 2.4 workaround.
3620         * python/python-internal.h: Remove Python 2.4 comment.
3621         (Py_ssize_t): Don't define.
3622         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3623         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3624         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3625         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3626         * python/python.c (do_start_initialization): Remove Python 2.4
3627         workaround.
3628         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3629         (print_children): Remove Python 2.4 workaround.
3630         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3631         workaround.
3632         (CHARBUFFERPROC_NAME): Remove.
3633         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3634         Python 2.4 workaround.
3635
3636 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3637
3638         * NEWS: Note minimum Python version.
3639
3640 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3641
3642         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3643         code from these functions.  Remove corresponding ifdefs.  Use
3644         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3645         Remove gotos and target of gotos.
3646         (infpy_search_memory): Likewise.
3647
3648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3651         (hppa_gdbarch_init): Don't register deleted functions with
3652         gdbarch.
3653
3654 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3657         (h8300_unwind_sp): Delete.
3658         (h8300_dummy_id): Delete.
3659         (h8300_gdbarch_init): Don't register deleted functions with
3660         gdbarch.
3661
3662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3663
3664         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3665         (ft32_unwind_pc): Delete.
3666         (ft32_unwind_sp): Delete.
3667         (ft32_gdbarch_init): Don't register deleted functions with
3668         gdbarch.
3669
3670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3673         (frv_unwind_pc): Delete.
3674         (frv_unwind_sp): Delete.
3675         (frv_gdbarch_init): Don't register deleted functions with
3676         gdbarch.
3677
3678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3679
3680         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3681         (riscv_unwind_pc): Delete.
3682         (riscv_unwind_sp): Delete.
3683         (riscv_gdbarch_init): Don't register deleted functions with
3684         gdbarch.
3685
3686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3689         (csky_unwind_pc): Delete.
3690         (csky_unwind_sp): Delete.
3691         (csky_gdbarch_init): Don't register deleted functions with
3692         gdbarch.
3693
3694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3695
3696         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3697         (cris_unwind_pc): Delete.
3698         (cris_unwind_sp): Delete.
3699         (cris_gdbarch_init): Don't register deleted functions with
3700         gdbarch.
3701
3702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3705         (bfin_unwind_pc): Delete.
3706         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3707
3708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3709
3710         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3711         (arm_unwind_pc): Delete.
3712         (arm_unwind_sp): Delete.
3713         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3714
3715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3718         (arc_unwind_pc): Delete.
3719         (arc_unwind_sp): Delete.
3720         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3721
3722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3725         (alpha_unwind_pc): Delete.
3726         (alpha_gdbarch_init): Don't register deleted functions with
3727         gdbarch.
3728
3729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3732         (aarch64_unwind_pc): Delete.
3733         (aarch64_unwind_sp): Delete.
3734         (aarch64_gdbarch_init): Don't register deleted functions with
3735         gdbarch.
3736
3737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * gdbtypes.c (type_align): Don't consider static members when
3740         computing structure alignment.
3741
3742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3745         return 0 for other types.
3746         * arch-utils.c (default_type_align): Always return 0.
3747         * gdbarch.h: Regenerate.
3748         * gdbarch.sh (type_align): Extend comment.
3749         * gdbtypes.c (type_align): Add additional comments, always call
3750         gdbarch_type_align before applying the default rules.
3751         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3752         generic code will then apply a suitable default.
3753         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3754         types, return 0 for other types.
3755
3756 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3757
3758         * NEWS: Create a new section for the next release branch.
3759         Rename the section of the current branch, now that it has
3760         been cut.
3761
3762 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3763
3764         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3765         * version.in: Bump version to 8.3.50.DATE-git.
3766
3767 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3768
3769         * aix-thread.c (ptid_cmp): Remove unused variable.
3770         (get_signaled_thread): Likewise.
3771         (store_regs_user_thread): Likewise.
3772         (store_regs_kernel_thread): Likewise.
3773         (fetch_regs_kernel_thread): Remove shadowed variable.
3774
3775 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * features/riscv/32bit-cpu.xml: Add register numbers.
3778         * features/riscv/32bit-fpu.c: Regenerate.
3779         * features/riscv/32bit-fpu.xml: Add register numbers.
3780         * features/riscv/64bit-cpu.xml: Add register numbers.
3781         * features/riscv/64bit-fpu.c: Regenerate.
3782         * features/riscv/64bit-fpu.xml: Add register numbers.
3783
3784 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3785
3786         * NEWS: Mention two argument form of gdb.Value constructor.
3787         * python/py-value.c (convert_buffer_and_type_to_value): New
3788         function.
3789         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3790         Add support for handling an optional second argument.  Call
3791         convert_buffer_and_type_to_value as appropriate.
3792         * python/python-internal.h (Py_buffer_deleter): New struct.
3793         (Py_buffer_up): New typedef.
3794
3795 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3796
3797         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3798         instead of releasing ownership.
3799
3800 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3801
3802         * dwarf2read.c (open_and_init_dwp_file): Call
3803         elf_numsections instead of bfd_count_sections to initialize
3804         dwp_file->num_sections.
3805
3806 2019-02-25  Tom Tromey  <tromey@adacore.com>
3807
3808         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3809
3810 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3811
3812         * gcore.in: Add '--readnever' option when invoking GDB.
3813
3814 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3815
3816         * MAINTAINERS: Update my email address.
3817
3818 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3819
3820         * build-id.c (build_id_to_debug_bfd_1): New function.
3821         (build_id_to_debug_bfd): Look for separate debug file in
3822         sysroot.
3823
3824 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         * gdbarch.sh: Update the copyright year range that is placed into
3827         generated files.
3828
3829 2019-02-22  Keith Seitz  <keiths@redhat.com>
3830
3831         PR symtab/23853
3832         * linespec.c (create_sals_line_offset): Search for the default
3833         symtab's filename instead of its fullname.
3834
3835 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3836
3837         * NEWS: Update style defaults.
3838
3839 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3840
3841         * main.c (captured_main_1): Disable styling in batch mode.
3842
3843 2019-02-20  Tom Tromey  <tom@tromey.com>
3844
3845         * symtab.c (symtab_symbol_info): Fix typos.
3846
3847 2019-02-20  Tom Tromey  <tromey@adacore.com>
3848
3849         * findcmd.c (_initialize_mem_search): Use upper case for
3850         metasyntactic variables.
3851
3852 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3853
3854         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3855         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3856
3857 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3858
3859         * top.h (source_file_name): Change to std::string.
3860         * top.c (source_file_name): Likewise.
3861         (command_line_input): Adjust.
3862         * cli/cli-script.c (script_from_file): Adjust.
3863
3864 2019-02-19  Tom Tromey  <tromey@adacore.com>
3865
3866         * ravenscar-thread.c
3867         (ravenscar_thread_target::update_thread_list): Don't call
3868         ada_build_task_list.
3869         * ada-lang.h (ada_build_task_list): Don't declare.
3870         * ada-tasks.c (struct ada_tasks_inferior_data)
3871         <task_list_valid_p>: Now bool.
3872         (read_known_tasks, ada_task_list_changed)
3873         (ada_tasks_invalidate_inferior_data): Update.
3874         (read_known_tasks_array): Return bool.
3875         (read_known_tasks_list): Likewise.
3876         (read_known_tasks): Return void.
3877         (ada_build_task_list): Now static.
3878
3879 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3882         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3883
3884 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3885
3886         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3887         variant for ada_tasks_pspace_data_handle and
3888         ada_tasks_inferior_data_handle.
3889         (ada_tasks_pspace_data_cleanup): New function.
3890         (ada_tasks_inferior_data_cleanup): New function.
3891
3892 2019-02-17  Tom Tromey  <tom@tromey.com>
3893
3894         * macrotab.h (macro_source_fullname): Return a std::string.
3895         * macrotab.c (macro_include, check_for_redefinition)
3896         (macro_undef, macro_lookup_definition, foreach_macro)
3897         (foreach_macro_in_scope): Update.
3898         (macro_source_fullname): Return a std::string.
3899         * macrocmd.c (show_pp_source_pos): Update.
3900
3901 2019-02-17  Tom Tromey  <tom@tromey.com>
3902
3903         * macrocmd.c (show_pp_source_pos): Style the file names.
3904
3905 2019-02-17  Tom Tromey  <tom@tromey.com>
3906
3907         PR tui/24197:
3908         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3909
3910 2019-02-17  Tom Tromey  <tom@tromey.com>
3911
3912         * ada-lang.c (user_select_syms): Use filtered printing.
3913         * utils.c (wrap_style): New global.
3914         (desired_style): Remove.
3915         (emit_style_escape): Add stream parameter.
3916         (set_output_style, reset_terminal_style, prompt_for_continue):
3917         Update.
3918         (flush_wrap_buffer): Only flush gdb_stdout.
3919         (wrap_here): Set wrap_style.
3920         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3921         treat escape sequences as a character.  Change when wrap buffer is
3922         flushed.
3923         (fputs_styled): Do not set the output style when the default is
3924         requested.
3925         * ui-style.h (struct ui_file_style) <is_default>: New method.
3926         * source.c (print_source_lines_base): Emit escape sequences in one
3927         piece.
3928
3929 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3930
3931         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3932         integers and enumeration types.
3933
3934 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3935
3936         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3937         instead of lookup_symbol_in_language
3938         (do_exact_match): New function.
3939         (ada_get_symbol_name_matcher): Return do_exact_match when
3940         doing a verbatim match.
3941
3942 2019-02-15  Tom Tromey  <tromey@adacore.com>
3943
3944         * ravenscar-thread.c (ravenscar_thread_target::resume)
3945         (ravenscar_thread_target::wait): Special case wildcard requests.
3946
3947 2019-02-15  Tom Tromey  <tromey@adacore.com>
3948
3949         * ravenscar-thread.c (base_ptid): Remove.
3950         (struct ravenscar_thread_target) <close>: New method.
3951         <m_base_ptid>: New member.
3952         <update_inferior_ptid, active_task, task_is_currently_active,
3953         runtime_initialized>: Declare methods.
3954         <ravenscar_thread_target>: Add constructor.
3955         (ravenscar_thread_target::task_is_currently_active)
3956         (ravenscar_thread_target::update_inferior_ptid)
3957         (ravenscar_runtime_initialized): Rename.  Now methods.
3958         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3959         (ravenscar_thread_target::update_thread_list): Update.
3960         (ravenscar_thread_target::active_task): Now method.
3961         (ravenscar_thread_target::store_registers)
3962         (ravenscar_thread_target::prepare_to_store)
3963         (ravenscar_thread_target::prepare_to_store)
3964         (ravenscar_thread_target::mourn_inferior): Update.
3965         (ravenscar_inferior_created): Use "new" to create target.
3966         (ravenscar_thread_target::get_ada_task_ptid): Update.
3967         (_initialize_ravenscar): Don't initialize base_ptid.
3968         (ravenscar_ops): Remove global.
3969
3970 2019-02-15  Tom Tromey  <tromey@adacore.com>
3971
3972         * target.h (push_target): Declare new overload.
3973         * target.c (push_target): New overload, taking an rvalue reference.
3974         * remote.c (remote_target::open_1): Use push_target overload.
3975         * corelow.c (core_target_open): Use push_target overload.
3976
3977 2019-02-15  Tom Tromey  <tromey@adacore.com>
3978
3979         * ravenscar-thread.c (is_ravenscar_task)
3980         (ravenscar_task_is_currently_active): Return bool.
3981         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3982         (_initialize_ravenscar): Remove "(void)".
3983         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3984         Return bool.
3985
3986 2019-02-15  Tom Tromey  <tromey@adacore.com>
3987
3988         * ravenscar-thread.c (ravenscar_runtime_initializer)
3989         (has_ravenscar_runtime, get_running_thread_id)
3990         (ravenscar_thread_target::resume): Fix indentation.
3991
3992 2019-02-15  Tom Tromey  <tromey@adacore.com>
3993
3994         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3995         from ravenscar_arch_ops.
3996         (sparc_ravenscar_ops::fetch_registers)
3997         (sparc_ravenscar_ops::store_registers): Now methods.
3998         (sparc_ravenscar_prepare_to_store): Remove.
3999         (sparc_ravenscar_ops): Redefine.
4000         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4001         methods and destructor.  Remove members.
4002         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4003         (ravenscar_thread_target::store_registers)
4004         (ravenscar_thread_target::prepare_to_store): Update.
4005         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4006         Remove.
4007         (struct ppc_ravenscar_powerpc_ops): Derive from
4008         ravenscar_arch_ops.
4009         (ppc_ravenscar_powerpc_ops::fetch_registers)
4010         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4011         (ppc_ravenscar_powerpc_ops): Redefine.
4012         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4013         (ppc_ravenscar_e500_ops::fetch_registers)
4014         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4015         (ppc_ravenscar_e500_ops): Redefine.
4016         * aarch64-ravenscar-thread.c
4017         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4018         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4019         (aarch64_ravenscar_fetch_registers)
4020         (aarch64_ravenscar_store_registers): Now methods.
4021         (aarch64_ravenscar_ops): Redefine.
4022
4023 2019-02-15  Tom Tromey  <tromey@adacore.com>
4024
4025         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4026         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4027         (ravenscar_thread_target::stopped_by_watchpoint)
4028         (ravenscar_thread_target::stopped_data_address)
4029         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4030
4031 2019-02-15  Tom Tromey  <tromey@adacore.com>
4032
4033         * ravenscar-thread.c: Fix some typos.
4034
4035 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4036             Tom Tromey  <tromey@adacore.com>
4037
4038         * ada-lang.c (ada_exception_sal): Change addr_string to a
4039         std::string.
4040         (create_ada_exception_catchpoint): Update.
4041
4042 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4043             Tom Tromey  <tromey@adacore.com>
4044
4045         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4046         (bp_location_ops): Remove.
4047         (base_breakpoint_allocate_location): Update.
4048         (free_bp_location): Update.
4049         * ada-lang.c (class ada_catchpoint_location)
4050         <ada_catchpoint_location>: Remove ops parameter.
4051         (ada_catchpoint_location_dtor): Remove.
4052         (ada_catchpoint_location_ops): Remove.
4053         (allocate_location_exception): Update.
4054         * breakpoint.h (struct bp_location_ops): Remove.
4055         (class bp_location) <bp_location>: Remove bp_location_ops
4056         parameter.
4057         <~bp_location>: Add destructor.
4058         <ops>: Remove.
4059
4060 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4061             Pedro Alves  <palves@redhat.com>
4062
4063         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4064         'PATH_MAX'.
4065
4066 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4067             Samuel Thibault  <samuel.thibault@gnu.org>
4068             Thomas Schwinge  <thomas@codesourcery.com>
4069
4070         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4071         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4072
4073 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4074
4075         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4076         (check_empty): Use "const char *".
4077
4078         * gnu-nat.c (gnu_nat_target::detach): Instead of
4079         'detach_inferior (pid)' call
4080         'detach_inferior (find_inferior_pid (pid))'.
4081
4082         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4083         'nat/fork-inferior.o'.
4084         * gnu-nat.c: #include "nat/fork-inferior.h".
4085
4086         * gnu-nat.c (gnu_nat_target::detach): Instead of
4087         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4088         * gnu-nat.h: #include "inf-child.h".
4089         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4090         'i386_gnu_nat_target::fetch_registers'.
4091         (gnu_store_registers): Rename/move to
4092         'i386_gnu_nat_target::store_registers'.
4093
4094         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4095         * gnu-nat.h (mach_thread_info): New function.
4096         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4097
4098         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4099
4100 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4101
4102         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4103
4104 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4105
4106         * windows-nat.c (windows_add_thread): Add new parameter
4107         "main_thread_p" with default value set to false.  Update
4108         function documentation as well as all callers.
4109         (windows_delete_thread): Likewise.
4110         (fake_create_process): Update call to windows_add_thread.
4111         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4112         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4113         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4114         call to windows_delete_thread.
4115
4116 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4117
4118         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4119
4120 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4121
4122         * symfile.c (find_separate_debug_file): Use canonical path of
4123         sysroot with child_path instead of gdb_sysroot if it is valid.
4124
4125 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4126
4127         * symfile.c (find_separate_debug_file): Use child_path to
4128         determine if an object file is under a sysroot.
4129
4130 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4131
4132         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4133         unittests/child-path-selftests.c.
4134         * common/pathstuff.c (child_path): New function.
4135         * common/pathstuff.h (child_path): New prototype.
4136         * unittests/child-path-selftests.c: New file.
4137
4138 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4139
4140         * symfile.c (find_separate_debug_file): Look for separate debug
4141         files in debug directories under the sysroot.
4142
4143 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4144
4145         * symtab.h (struct minimal_symbol data_p): New const method.
4146         (struct minimal_symbol text_p): Likewise.
4147         * symtab.c (output_source_filename): Use file name style
4148         to print file name.
4149         (print_symbol_info): Likewise.
4150         (print_msymbol_info): Use address style to print addresses.
4151         Use function name style to print executable text symbols.
4152         (expand_symtab_containing_pc): Use data_p.
4153         (find_pc_sect_compunit_symtab): Likewise.
4154
4155 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4156
4157         * breakpoint.c (describe_other_breakpoints): Use address style
4158         to print addresses.
4159         (say_where): Likewise.
4160
4161 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4162
4163         * ada-typeprint.c (print_func_type): Print function name
4164         style to print function name.
4165         * c-typeprint.c (c_print_type_1): Likewise.
4166
4167 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4168
4169         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4170         for execve.
4171
4172 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4173
4174         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4175         type_stack.
4176
4177 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4178
4179         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4180         TYPE_CODE_REF types.
4181
4182 2019-02-08  Jim Wilson  <jimw@sifive.com>
4183
4184         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4185         (riscv_linux_fregset): New.
4186         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4187
4188 2019-02-07  Tom Tromey  <tom@tromey.com>
4189
4190         * thread.c (thread_cancel_execution_command): Update.
4191         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4192         methods.
4193         (struct thread_fsm_ops): Remove.
4194         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4195         (thread_fsm_should_stop, thread_fsm_return_value)
4196         (thread_fsm_set_finished, thread_fsm_finished_p)
4197         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4198         Don't declare.
4199         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4200         * infrun.c (clear_proceed_status_thread)
4201         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4202         (print_stop_event): Update.
4203         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4204         Add constructor.
4205         (step_command_fsm_ops): Remove.
4206         (new_step_command_fsm): Remove.
4207         (step_1): Update.
4208         (step_command_fsm::should_stop): Rename from
4209         step_command_fsm_should_stop.
4210         (step_command_fsm::clean_up): Rename from
4211         step_command_fsm_clean_up.
4212         (step_command_fsm::do_async_reply_reason): Rename from
4213         step_command_fsm_async_reply_reason.
4214         (struct until_next_fsm): Inherit from thread_fsm.  Add
4215         constructor.
4216         (until_next_fsm_ops): Remove.
4217         (new_until_next_fsm): Remove.
4218         (until_next_fsm::should_stop): Rename from
4219         until_next_fsm_should_stop.
4220         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4221         (until_next_fsm::do_async_reply_reason): Rename from
4222         until_next_fsm_async_reply_reason.
4223         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4224         constructor.  Change type of breakpoint.
4225         (finish_command_fsm_ops): Remove.
4226         (new_finish_command_fsm): Remove.
4227         (finish_command_fsm::should_stop): Rename from
4228         finish_command_fsm_should_stop.
4229         (finish_command_fsm::clean_up): Rename from
4230         finish_command_fsm_clean_up.
4231         (finish_command_fsm::return_value): Rename from
4232         finish_command_fsm_return_value.
4233         (finish_command_fsm::do_async_reply_reason): Rename from
4234         finish_command_fsm_async_reply_reason.
4235         (finish_command): Update.
4236         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4237         Add constructor.
4238         (call_thread_fsm_ops): Remove.
4239         (call_thread_fsm::call_thread_fsm): Rename from
4240         new_call_thread_fsm.
4241         (call_thread_fsm::should_stop): Rename from
4242         call_thread_fsm_should_stop.
4243         (call_thread_fsm::should_notify_stop): Rename from
4244         call_thread_fsm_should_notify_stop.
4245         (run_inferior_call, call_function_by_hand_dummy): Update.
4246         * cli/cli-interp.c (should_print_stop_to_console): Update.
4247         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4248         Add constructor.  Change type of location_breakpoint,
4249         caller_breakpoint.
4250         (until_break_fsm_ops): Remove.
4251         (new_until_break_fsm): Remove.
4252         (until_break_fsm::should_stop): Rename from
4253         until_break_fsm_should_stop.
4254         (until_break_fsm::clean_up): Rename from
4255         until_break_fsm_clean_up.
4256         (until_break_fsm::do_async_reply_reason): Rename from
4257         until_break_fsm_async_reply_reason.
4258         (until_break_command): Update.
4259         * thread-fsm.c: Remove.
4260         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4261
4262 2019-02-07  Tom Tromey  <tom@tromey.com>
4263
4264         * yy-remap.h: Add include guard.
4265         * xtensa-tdep.h: Add include guard.
4266         * xcoffread.h: Rename include guard.
4267         * varobj-iter.h: Add include guard.
4268         * tui/tui.h: Rename include guard.
4269         * tui/tui-winsource.h: Rename include guard.
4270         * tui/tui-wingeneral.h: Rename include guard.
4271         * tui/tui-windata.h: Rename include guard.
4272         * tui/tui-win.h: Rename include guard.
4273         * tui/tui-stack.h: Rename include guard.
4274         * tui/tui-source.h: Rename include guard.
4275         * tui/tui-regs.h: Rename include guard.
4276         * tui/tui-out.h: Rename include guard.
4277         * tui/tui-layout.h: Rename include guard.
4278         * tui/tui-io.h: Rename include guard.
4279         * tui/tui-hooks.h: Rename include guard.
4280         * tui/tui-file.h: Rename include guard.
4281         * tui/tui-disasm.h: Rename include guard.
4282         * tui/tui-data.h: Rename include guard.
4283         * tui/tui-command.h: Rename include guard.
4284         * tic6x-tdep.h: Add include guard.
4285         * target/waitstatus.h: Rename include guard.
4286         * target/wait.h: Rename include guard.
4287         * target/target.h: Rename include guard.
4288         * target/resume.h: Rename include guard.
4289         * target-float.h: Rename include guard.
4290         * stabsread.h: Add include guard.
4291         * rs6000-tdep.h: Add include guard.
4292         * riscv-fbsd-tdep.h: Add include guard.
4293         * regformats/regdef.h: Rename include guard.
4294         * record.h: Rename include guard.
4295         * python/python.h: Rename include guard.
4296         * python/python-internal.h: Rename include guard.
4297         * python/py-stopevent.h: Rename include guard.
4298         * python/py-ref.h: Rename include guard.
4299         * python/py-record.h: Rename include guard.
4300         * python/py-record-full.h: Rename include guard.
4301         * python/py-record-btrace.h: Rename include guard.
4302         * python/py-instruction.h: Rename include guard.
4303         * python/py-events.h: Rename include guard.
4304         * python/py-event.h: Rename include guard.
4305         * procfs.h: Add include guard.
4306         * proc-utils.h: Add include guard.
4307         * p-lang.h: Add include guard.
4308         * or1k-tdep.h: Rename include guard.
4309         * observable.h: Rename include guard.
4310         * nto-tdep.h: Rename include guard.
4311         * nat/x86-linux.h: Rename include guard.
4312         * nat/x86-linux-dregs.h: Rename include guard.
4313         * nat/x86-gcc-cpuid.h: Add include guard.
4314         * nat/x86-dregs.h: Rename include guard.
4315         * nat/x86-cpuid.h: Rename include guard.
4316         * nat/ppc-linux.h: Rename include guard.
4317         * nat/mips-linux-watch.h: Rename include guard.
4318         * nat/linux-waitpid.h: Rename include guard.
4319         * nat/linux-ptrace.h: Rename include guard.
4320         * nat/linux-procfs.h: Rename include guard.
4321         * nat/linux-osdata.h: Rename include guard.
4322         * nat/linux-nat.h: Rename include guard.
4323         * nat/linux-namespaces.h: Rename include guard.
4324         * nat/linux-btrace.h: Rename include guard.
4325         * nat/glibc_thread_db.h: Rename include guard.
4326         * nat/gdb_thread_db.h: Rename include guard.
4327         * nat/gdb_ptrace.h: Rename include guard.
4328         * nat/fork-inferior.h: Rename include guard.
4329         * nat/amd64-linux-siginfo.h: Rename include guard.
4330         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4331         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4332         * nat/aarch64-linux.h: Rename include guard.
4333         * nat/aarch64-linux-hw-point.h: Rename include guard.
4334         * mn10300-tdep.h: Add include guard.
4335         * mips-linux-tdep.h: Add include guard.
4336         * mi/mi-parse.h: Rename include guard.
4337         * mi/mi-out.h: Rename include guard.
4338         * mi/mi-main.h: Rename include guard.
4339         * mi/mi-interp.h: Rename include guard.
4340         * mi/mi-getopt.h: Rename include guard.
4341         * mi/mi-console.h: Rename include guard.
4342         * mi/mi-common.h: Rename include guard.
4343         * mi/mi-cmds.h: Rename include guard.
4344         * mi/mi-cmd-break.h: Rename include guard.
4345         * m2-lang.h: Add include guard.
4346         * location.h: Rename include guard.
4347         * linux-record.h: Rename include guard.
4348         * linux-nat.h: Add include guard.
4349         * linux-fork.h: Add include guard.
4350         * i386-darwin-tdep.h: Rename include guard.
4351         * hppa-linux-offsets.h: Add include guard.
4352         * guile/guile.h: Rename include guard.
4353         * guile/guile-internal.h: Rename include guard.
4354         * gnu-nat.h: Rename include guard.
4355         * gdb-stabs.h: Rename include guard.
4356         * frv-tdep.h: Add include guard.
4357         * f-lang.h: Add include guard.
4358         * event-loop.h: Add include guard.
4359         * darwin-nat.h: Rename include guard.
4360         * cp-abi.h: Rename include guard.
4361         * config/sparc/nm-sol2.h: Rename include guard.
4362         * config/nm-nto.h: Rename include guard.
4363         * config/nm-linux.h: Add include guard.
4364         * config/i386/nm-i386gnu.h: Rename include guard.
4365         * config/djgpp/nl_types.h: Rename include guard.
4366         * config/djgpp/langinfo.h: Rename include guard.
4367         * compile/gcc-cp-plugin.h: Add include guard.
4368         * compile/gcc-c-plugin.h: Add include guard.
4369         * compile/compile.h: Rename include guard.
4370         * compile/compile-object-run.h: Rename include guard.
4371         * compile/compile-object-load.h: Rename include guard.
4372         * compile/compile-internal.h: Rename include guard.
4373         * compile/compile-cplus.h: Rename include guard.
4374         * compile/compile-c.h: Rename include guard.
4375         * common/xml-utils.h: Rename include guard.
4376         * common/x86-xstate.h: Rename include guard.
4377         * common/version.h: Rename include guard.
4378         * common/vec.h: Rename include guard.
4379         * common/tdesc.h: Rename include guard.
4380         * common/selftest.h: Rename include guard.
4381         * common/scoped_restore.h: Rename include guard.
4382         * common/scoped_mmap.h: Rename include guard.
4383         * common/scoped_fd.h: Rename include guard.
4384         * common/safe-iterator.h: Rename include guard.
4385         * common/run-time-clock.h: Rename include guard.
4386         * common/refcounted-object.h: Rename include guard.
4387         * common/queue.h: Rename include guard.
4388         * common/ptid.h: Rename include guard.
4389         * common/print-utils.h: Rename include guard.
4390         * common/preprocessor.h: Rename include guard.
4391         * common/pathstuff.h: Rename include guard.
4392         * common/observable.h: Rename include guard.
4393         * common/netstuff.h: Rename include guard.
4394         * common/job-control.h: Rename include guard.
4395         * common/host-defs.h: Rename include guard.
4396         * common/gdb_wait.h: Rename include guard.
4397         * common/gdb_vecs.h: Rename include guard.
4398         * common/gdb_unlinker.h: Rename include guard.
4399         * common/gdb_unique_ptr.h: Rename include guard.
4400         * common/gdb_tilde_expand.h: Rename include guard.
4401         * common/gdb_sys_time.h: Rename include guard.
4402         * common/gdb_string_view.h: Rename include guard.
4403         * common/gdb_splay_tree.h: Rename include guard.
4404         * common/gdb_setjmp.h: Rename include guard.
4405         * common/gdb_ref_ptr.h: Rename include guard.
4406         * common/gdb_optional.h: Rename include guard.
4407         * common/gdb_locale.h: Rename include guard.
4408         * common/gdb_assert.h: Rename include guard.
4409         * common/filtered-iterator.h: Rename include guard.
4410         * common/filestuff.h: Rename include guard.
4411         * common/fileio.h: Rename include guard.
4412         * common/environ.h: Rename include guard.
4413         * common/common-utils.h: Rename include guard.
4414         * common/common-types.h: Rename include guard.
4415         * common/common-regcache.h: Rename include guard.
4416         * common/common-inferior.h: Rename include guard.
4417         * common/common-gdbthread.h: Rename include guard.
4418         * common/common-exceptions.h: Rename include guard.
4419         * common/common-defs.h: Rename include guard.
4420         * common/common-debug.h: Rename include guard.
4421         * common/cleanups.h: Rename include guard.
4422         * common/buffer.h: Rename include guard.
4423         * common/btrace-common.h: Rename include guard.
4424         * common/break-common.h: Rename include guard.
4425         * cli/cli-utils.h: Rename include guard.
4426         * cli/cli-style.h: Rename include guard.
4427         * cli/cli-setshow.h: Rename include guard.
4428         * cli/cli-script.h: Rename include guard.
4429         * cli/cli-interp.h: Rename include guard.
4430         * cli/cli-decode.h: Rename include guard.
4431         * cli/cli-cmds.h: Rename include guard.
4432         * charset-list.h: Add include guard.
4433         * buildsym-legacy.h: Rename include guard.
4434         * bfin-tdep.h: Add include guard.
4435         * ax.h: Rename include guard.
4436         * arm-linux-tdep.h: Add include guard.
4437         * arm-fbsd-tdep.h: Add include guard.
4438         * arch/xtensa.h: Rename include guard.
4439         * arch/tic6x.h: Add include guard.
4440         * arch/i386.h: Add include guard.
4441         * arch/arm.h: Rename include guard.
4442         * arch/arm-linux.h: Rename include guard.
4443         * arch/arm-get-next-pcs.h: Rename include guard.
4444         * arch/amd64.h: Add include guard.
4445         * arch/aarch64-insn.h: Rename include guard.
4446         * arch-utils.h: Rename include guard.
4447         * annotate.h: Add include guard.
4448         * amd64-darwin-tdep.h: Rename include guard.
4449         * aarch64-linux-tdep.h: Add include guard.
4450         * aarch64-fbsd-tdep.h: Add include guard.
4451         * aarch32-linux-nat.h: Add include guard.
4452
4453 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4454
4455         * macrotab.c (macro_define_internal): New function that
4456         factorizes macro_define_object_internal and macro_define_function
4457         code.
4458         (macro_define_object_internal): Use macro_define_internal.
4459         (macro_define_function): Likewise.
4460
4461 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4462
4463         * macrocmd.c (extract_identifier): Return
4464         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4465         callers.
4466
4467 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4468
4469         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4470
4471 2019-02-05  Tom Tromey  <tom@tromey.com>
4472
4473         * target.c (target_stack::unpush): Move assertion earlier.
4474
4475 2019-01-30  Tom Tromey  <tom@tromey.com>
4476
4477         PR python/23615:
4478         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4479         (gdbpy_parse_and_eval): Likewise.
4480         * python/python-internal.h (gdbpy_allow_threads): New class.
4481
4482 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4483
4484         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4485         (aarch64_fbsd_fpregmap): Move earlier.
4486         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4487         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4488         instead of individual calls to trad_frame_set_reg_addr.
4489         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4490         earlier.
4491         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4492         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4493         instead of individual calls to trad_frame_set_reg_addr.
4494
4495 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4496
4497         * CONTRIBUTE: Replace contribution list with wiki link.
4498
4499 2019-01-25  Tom Tromey  <tom@tromey.com>
4500
4501         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4502
4503 2019-01-25  Tom Tromey  <tom@tromey.com>
4504
4505         * xtensa-linux-nat.c: Fix common/ includes.
4506         * xml-support.h: Fix common/ includes.
4507         * xml-support.c: Fix common/ includes.
4508         * x86-linux-nat.c: Fix common/ includes.
4509         * windows-nat.c: Fix common/ includes.
4510         * varobj.h: Fix common/ includes.
4511         * varobj.c: Fix common/ includes.
4512         * value.c: Fix common/ includes.
4513         * valops.c: Fix common/ includes.
4514         * utils.c: Fix common/ includes.
4515         * unittests/xml-utils-selftests.c: Fix common/ includes.
4516         * unittests/utils-selftests.c: Fix common/ includes.
4517         * unittests/unpack-selftests.c: Fix common/ includes.
4518         * unittests/tracepoint-selftests.c: Fix common/ includes.
4519         * unittests/style-selftests.c: Fix common/ includes.
4520         * unittests/string_view-selftests.c: Fix common/ includes.
4521         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4522         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4523         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4524         * unittests/rsp-low-selftests.c: Fix common/ includes.
4525         * unittests/parse-connection-spec-selftests.c: Fix common/
4526         includes.
4527         * unittests/optional-selftests.c: Fix common/ includes.
4528         * unittests/offset-type-selftests.c: Fix common/ includes.
4529         * unittests/observable-selftests.c: Fix common/ includes.
4530         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4531         * unittests/memrange-selftests.c: Fix common/ includes.
4532         * unittests/memory-map-selftests.c: Fix common/ includes.
4533         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4534         * unittests/function-view-selftests.c: Fix common/ includes.
4535         * unittests/environ-selftests.c: Fix common/ includes.
4536         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4537         * unittests/common-utils-selftests.c: Fix common/ includes.
4538         * unittests/cli-utils-selftests.c: Fix common/ includes.
4539         * unittests/array-view-selftests.c: Fix common/ includes.
4540         * ui-file.c: Fix common/ includes.
4541         * tui/tui-io.c: Fix common/ includes.
4542         * tracepoint.h: Fix common/ includes.
4543         * tracepoint.c: Fix common/ includes.
4544         * tracefile-tfile.c: Fix common/ includes.
4545         * top.h: Fix common/ includes.
4546         * top.c: Fix common/ includes.
4547         * thread.c: Fix common/ includes.
4548         * target/waitstatus.h: Fix common/ includes.
4549         * target/waitstatus.c: Fix common/ includes.
4550         * target.h: Fix common/ includes.
4551         * target.c: Fix common/ includes.
4552         * target-memory.c: Fix common/ includes.
4553         * target-descriptions.c: Fix common/ includes.
4554         * symtab.h: Fix common/ includes.
4555         * symfile.c: Fix common/ includes.
4556         * stap-probe.c: Fix common/ includes.
4557         * spu-linux-nat.c: Fix common/ includes.
4558         * sparc-nat.c: Fix common/ includes.
4559         * source.c: Fix common/ includes.
4560         * solib.c: Fix common/ includes.
4561         * solib-target.c: Fix common/ includes.
4562         * ser-unix.c: Fix common/ includes.
4563         * ser-tcp.c: Fix common/ includes.
4564         * ser-pipe.c: Fix common/ includes.
4565         * ser-base.c: Fix common/ includes.
4566         * selftest-arch.c: Fix common/ includes.
4567         * s12z-tdep.c: Fix common/ includes.
4568         * rust-exp.y: Fix common/ includes.
4569         * rs6000-aix-tdep.c: Fix common/ includes.
4570         * riscv-tdep.c: Fix common/ includes.
4571         * remote.c: Fix common/ includes.
4572         * remote-notif.h: Fix common/ includes.
4573         * remote-fileio.h: Fix common/ includes.
4574         * remote-fileio.c: Fix common/ includes.
4575         * regcache.h: Fix common/ includes.
4576         * regcache.c: Fix common/ includes.
4577         * record-btrace.c: Fix common/ includes.
4578         * python/python.c: Fix common/ includes.
4579         * python/py-type.c: Fix common/ includes.
4580         * python/py-inferior.c: Fix common/ includes.
4581         * progspace.h: Fix common/ includes.
4582         * producer.c: Fix common/ includes.
4583         * procfs.c: Fix common/ includes.
4584         * proc-api.c: Fix common/ includes.
4585         * printcmd.c: Fix common/ includes.
4586         * ppc-linux-nat.c: Fix common/ includes.
4587         * parser-defs.h: Fix common/ includes.
4588         * osdata.c: Fix common/ includes.
4589         * obsd-nat.c: Fix common/ includes.
4590         * nat/x86-linux.c: Fix common/ includes.
4591         * nat/x86-linux-dregs.c: Fix common/ includes.
4592         * nat/x86-dregs.h: Fix common/ includes.
4593         * nat/x86-dregs.c: Fix common/ includes.
4594         * nat/ppc-linux.c: Fix common/ includes.
4595         * nat/mips-linux-watch.h: Fix common/ includes.
4596         * nat/mips-linux-watch.c: Fix common/ includes.
4597         * nat/linux-waitpid.c: Fix common/ includes.
4598         * nat/linux-ptrace.h: Fix common/ includes.
4599         * nat/linux-ptrace.c: Fix common/ includes.
4600         * nat/linux-procfs.c: Fix common/ includes.
4601         * nat/linux-personality.c: Fix common/ includes.
4602         * nat/linux-osdata.c: Fix common/ includes.
4603         * nat/linux-namespaces.c: Fix common/ includes.
4604         * nat/linux-btrace.h: Fix common/ includes.
4605         * nat/linux-btrace.c: Fix common/ includes.
4606         * nat/fork-inferior.c: Fix common/ includes.
4607         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4608         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4609         * nat/aarch64-linux.c: Fix common/ includes.
4610         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4611         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4612         * namespace.h: Fix common/ includes.
4613         * mips-linux-tdep.c: Fix common/ includes.
4614         * minsyms.c: Fix common/ includes.
4615         * mi/mi-parse.h: Fix common/ includes.
4616         * mi/mi-main.c: Fix common/ includes.
4617         * mi/mi-cmd-env.c: Fix common/ includes.
4618         * memrange.h: Fix common/ includes.
4619         * memattr.c: Fix common/ includes.
4620         * maint.h: Fix common/ includes.
4621         * maint.c: Fix common/ includes.
4622         * main.c: Fix common/ includes.
4623         * machoread.c: Fix common/ includes.
4624         * location.c: Fix common/ includes.
4625         * linux-thread-db.c: Fix common/ includes.
4626         * linux-nat.c: Fix common/ includes.
4627         * linux-fork.c: Fix common/ includes.
4628         * inline-frame.c: Fix common/ includes.
4629         * infrun.c: Fix common/ includes.
4630         * inflow.c: Fix common/ includes.
4631         * inferior.h: Fix common/ includes.
4632         * inferior.c: Fix common/ includes.
4633         * infcmd.c: Fix common/ includes.
4634         * inf-ptrace.c: Fix common/ includes.
4635         * inf-child.c: Fix common/ includes.
4636         * ia64-linux-nat.c: Fix common/ includes.
4637         * i387-tdep.c: Fix common/ includes.
4638         * i386-tdep.c: Fix common/ includes.
4639         * i386-linux-tdep.c: Fix common/ includes.
4640         * i386-linux-nat.c: Fix common/ includes.
4641         * i386-go32-tdep.c: Fix common/ includes.
4642         * i386-fbsd-tdep.c: Fix common/ includes.
4643         * i386-fbsd-nat.c: Fix common/ includes.
4644         * guile/scm-type.c: Fix common/ includes.
4645         * guile/guile.c: Fix common/ includes.
4646         * go32-nat.c: Fix common/ includes.
4647         * gnu-nat.c: Fix common/ includes.
4648         * gdbthread.h: Fix common/ includes.
4649         * gdbarch-selftests.c: Fix common/ includes.
4650         * gdb_usleep.c: Fix common/ includes.
4651         * gdb_select.h: Fix common/ includes.
4652         * gdb_bfd.c: Fix common/ includes.
4653         * gcore.c: Fix common/ includes.
4654         * fork-child.c: Fix common/ includes.
4655         * findvar.c: Fix common/ includes.
4656         * fbsd-nat.c: Fix common/ includes.
4657         * event-top.c: Fix common/ includes.
4658         * event-loop.c: Fix common/ includes.
4659         * dwarf2read.c: Fix common/ includes.
4660         * dwarf2loc.c: Fix common/ includes.
4661         * dwarf2-frame.c: Fix common/ includes.
4662         * dwarf-index-cache.c: Fix common/ includes.
4663         * dtrace-probe.c: Fix common/ includes.
4664         * disasm-selftests.c: Fix common/ includes.
4665         * defs.h: Fix common/ includes.
4666         * csky-tdep.c: Fix common/ includes.
4667         * cp-valprint.c: Fix common/ includes.
4668         * cp-support.h: Fix common/ includes.
4669         * cp-support.c: Fix common/ includes.
4670         * corelow.c: Fix common/ includes.
4671         * completer.h: Fix common/ includes.
4672         * completer.c: Fix common/ includes.
4673         * compile/compile.c: Fix common/ includes.
4674         * compile/compile-loc2c.c: Fix common/ includes.
4675         * compile/compile-cplus-types.c: Fix common/ includes.
4676         * compile/compile-cplus-symbols.c: Fix common/ includes.
4677         * command.h: Fix common/ includes.
4678         * cli/cli-dump.c: Fix common/ includes.
4679         * cli/cli-cmds.c: Fix common/ includes.
4680         * charset.c: Fix common/ includes.
4681         * build-id.c: Fix common/ includes.
4682         * btrace.h: Fix common/ includes.
4683         * btrace.c: Fix common/ includes.
4684         * breakpoint.h: Fix common/ includes.
4685         * breakpoint.c: Fix common/ includes.
4686         * ax.h:
4687         (enum agent_op): Fix common/ includes.
4688         * ax-general.c (struct aop_map): Fix common/ includes.
4689         * ax-gdb.c: Fix common/ includes.
4690         * auxv.c: Fix common/ includes.
4691         * auto-load.c: Fix common/ includes.
4692         * arm-tdep.c: Fix common/ includes.
4693         * arch/riscv.c: Fix common/ includes.
4694         * arch/ppc-linux-common.c: Fix common/ includes.
4695         * arch/i386.c: Fix common/ includes.
4696         * arch/arm.c: Fix common/ includes.
4697         * arch/arm-linux.c: Fix common/ includes.
4698         * arch/arm-get-next-pcs.c: Fix common/ includes.
4699         * arch/amd64.c: Fix common/ includes.
4700         * arch/aarch64.c: Fix common/ includes.
4701         * arch/aarch64-insn.c: Fix common/ includes.
4702         * arch-utils.c: Fix common/ includes.
4703         * amd64-windows-tdep.c: Fix common/ includes.
4704         * amd64-tdep.c: Fix common/ includes.
4705         * amd64-sol2-tdep.c: Fix common/ includes.
4706         * amd64-obsd-tdep.c: Fix common/ includes.
4707         * amd64-nbsd-tdep.c: Fix common/ includes.
4708         * amd64-linux-tdep.c: Fix common/ includes.
4709         * amd64-linux-nat.c: Fix common/ includes.
4710         * amd64-fbsd-tdep.c: Fix common/ includes.
4711         * amd64-fbsd-nat.c: Fix common/ includes.
4712         * amd64-dicos-tdep.c: Fix common/ includes.
4713         * amd64-darwin-tdep.c: Fix common/ includes.
4714         * agent.c: Fix common/ includes.
4715         * ada-lang.h: Fix common/ includes.
4716         * ada-lang.c: Fix common/ includes.
4717         * aarch64-tdep.c: Fix common/ includes.
4718
4719 2019-01-25  Tom Tromey  <tom@tromey.com>
4720
4721         * common/create-version.sh: Use common/version.h.
4722
4723 2019-01-24  Pedro Alves  <palves@redhat.com>
4724
4725         * infrun.c (signal_stop, signal_print, signal_program)
4726         (signal_catch, signal_pass): Now arrays instead of pointers.
4727         (update_signals_program_target, do_target_resume)
4728         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4729         * linux-nat.c (linux_nat_target::pass_signals)
4730         (linux_nat_target::create_inferior, linux_nat_target::attach):
4731         Adjust.
4732         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4733         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4734         * procfs.c (procfs_target::pass_signals): Adjust.
4735         * record-full.c (record_full_target::resume): Adjust.
4736         * remote.c (remote_target::pass_signals)
4737         (remote_target::program_signals): Adjust.
4738         * target-debug.h (target_debug_print_signals): Now takes a
4739         gdb::array_view as parameter.  Adjust.
4740         * target.h (target_ops) <pass_signals, program_signals>: Replace
4741         pointer and length parameters with gdb::array_view.
4742         (target_pass_signals, target_program_signals): Likewise.
4743         * target-delegates.c: Regenerate.
4744
4745 2019-01-24  Pedro Alves  <palves@redhat.com>
4746
4747         * common/forward-scope-exit.h
4748         (forward_scope_exit::forward_scope_exit): Pass arguments to
4749         m_bind_function directly, instead of creating a std::bind and
4750         copying that.
4751
4752 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4753
4754         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4755         for static members.
4756         (pass_in_v_vfp_candidate): Likewise.
4757
4758 2019-01-23  Tom Tromey  <tom@tromey.com>
4759             Pedro Alves  <palves@redhat.com>
4760
4761         * regcache.c (class regcache_invalidator): Remove.
4762         (regcache::raw_write): Use make_scope_exit.
4763
4764 2019-01-23  Tom Tromey  <tom@tromey.com>
4765
4766         * ui-out.h (class ui_out_emit_type): Update comment.
4767
4768 2019-01-23  Tom Tromey  <tom@tromey.com>
4769
4770         * infrun.c (fetch_inferior_event): Update comment.
4771
4772 2019-01-23  Tom Tromey  <tom@tromey.com>
4773             Pedro Alves  <palves@redhat.com>
4774
4775         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4776         parameter.
4777         (fetch_inferior_event): Use SCOPE_EXIT.
4778
4779
4780 2019-01-23  Tom Tromey  <tom@tromey.com>
4781             Pedro Alves  <palves@redhat.com>
4782
4783         * infrun.c (disable_thread_events): Delete.
4784         (stop_all_threads): Use SCOPE_EXIT.
4785
4786 2019-01-23  Tom Tromey  <tom@tromey.com>
4787             Pedro Alves  <palves@redhat.com>
4788
4789         * symfile.c: Include forward-scope-exit.h.
4790         (clear_symtab_users_cleanup): Replace forward declaration with
4791         a FORWARD_SCOPE_EXIT.
4792         (syms_from_objfile_1): Use the forward_scope_exit and
4793         gdb::optional instead of cleanup_function.
4794         (reread_symbols): Use the forward_scope_exit instead of
4795         cleanup_function.
4796         (clear_symtab_users_cleanup): Remove function.
4797
4798 2019-01-23  Tom Tromey  <tom@tromey.com>
4799             Pedro Alves  <palves@redhat.com>
4800
4801         * linux-nat.c: Include scope-exit.h.
4802         (cleanup_target_stop): Remove.
4803         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4804         SCOPE_EXIT.
4805
4806 2019-01-23  Tom Tromey  <tom@tromey.com>
4807             Pedro Alves  <palves@redhat.com>
4808
4809         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4810         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4811
4812 2019-01-23  Tom Tromey  <tom@tromey.com>
4813             Andrew Burgess  <andrew.burgess@embecosm.com>
4814             Pedro Alves  <palves@redhat.com>
4815
4816         * infrun.c (fetch_inferior_event): Use scope_exit.
4817         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4818         * top.c (execute_command): Use scope_exit.
4819         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4820         * utils.c (do_bpstat_clear_actions_cleanup)
4821         (make_bpstat_clear_actions_cleanup): Remove.
4822
4823 2019-01-23  Tom Tromey  <tom@tromey.com>
4824             Pedro Alves  <palves@redhat.com>
4825
4826         * infrun.c: Include "common/scope-exit.h"
4827         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4828         (wait_for_inferior): Use SCOPE_EXIT.
4829         (fetch_inferior_event): Use scope_exit.
4830
4831 2019-01-23  Tom Tromey  <tom@tromey.com>
4832             Pedro Alves  <palves@redhat.com>
4833
4834         * breakpoint.c (create_breakpoint): Remove cleanup.
4835
4836 2019-01-23  Tom Tromey  <tom@tromey.com>
4837             Andrew Burgess  <andrew.burgess@embecosm.com>
4838             Pedro Alves  <palves@redhat.com>
4839
4840 2019-01-23  Pedro Alves  <palves@redhat.com>
4841
4842         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4843
4844 2019-01-23  Pedro Alves  <palves@redhat.com>
4845             Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * gdbthread.h: Include "common/forward-scope-exit.h".
4848         (scoped_finish_thread_state): Redefine custom class in terms of
4849         forward_scope_exit.
4850
4851 2019-01-23  Pedro Alves  <palves@redhat.com>
4852             Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * common/forward-scope-exit.h: New file.
4855
4856 2019-01-23  Pedro Alves  <palves@redhat.com>
4857             Andrew Burgess  <andrew.burgess@embecosm.com>
4858             Tom Tromey  <tom@tromey.com>
4859
4860         * common/scope-exit.h: New file.
4861
4862 2019-01-23  Pedro Alves  <palves@redhat.com>
4863
4864         * common/preprocessor.h (ESC): Rename to ...
4865         (ESC_PARENS): ... this.
4866         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4867         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4868
4869 2019-01-23  Tom Tromey  <tom@tromey.com>
4870
4871         * language.h (class scoped_switch_to_sym_language_if_auto):
4872         Initialize m_lang in both cases.
4873
4874 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4875
4876         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4877         with XCNEW.
4878
4879 2019-01-22  Tom Tromey  <tom@tromey.com>
4880
4881         * corelow.c: Do not include sys/file.h.
4882
4883 2019-01-22  Tom Tromey  <tom@tromey.com>
4884
4885         * tui/tui-wingeneral.h: Include gdb_curses.h.
4886
4887 2019-01-22  Tom Tromey  <tom@tromey.com>
4888
4889         * source-cache.h (class source_cache) <get_source_lines,
4890         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4891
4892 2019-01-22  Tom Tromey  <tom@tromey.com>
4893
4894         * remote-fileio.h (struct remote_target): Declare.
4895
4896 2019-01-22  Tom Tromey  <tom@tromey.com>
4897
4898         * python/py-arch.c: Do not include py-ref.h.
4899         * python/py-bpevent.c: Do not include py-ref.h.
4900         * python/py-cmd.c: Do not include py-ref.h.
4901         * python/py-continueevent.c: Do not include py-ref.h.
4902         * python/py-event.h: Do not include py-ref.h.
4903         * python/py-evtregistry.c: Do not include py-ref.h.
4904         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4905         * python/py-frame.c: Do not include py-ref.h.
4906         * python/py-framefilter.c: Do not include py-ref.h.
4907         * python/py-function.c: Do not include py-ref.h.
4908         * python/py-infevents.c: Do not include py-ref.h.
4909         * python/py-linetable.c: Do not include py-ref.h.
4910         * python/py-objfile.c: Do not include py-ref.h.
4911         * python/py-param.c: Do not include py-ref.h.
4912         * python/py-prettyprint.c: Do not include py-ref.h.
4913         * python/py-progspace.c: Do not include py-ref.h.
4914         * python/py-symbol.c: Do not include py-ref.h.
4915         * python/py-symtab.c: Do not include py-ref.h.
4916         * python/py-type.c: Do not include py-ref.h.
4917         * python/py-unwind.c: Do not include py-ref.h.
4918         * python/py-utils.c: Do not include py-ref.h.
4919         * python/py-value.c: Do not include py-ref.h.
4920         * python/py-varobj.c: Do not include py-ref.h.
4921         * python/py-xmethods.c: Do not include py-ref.h.
4922         * python/python.c: Do not include py-ref.h.
4923         * varobj.c: Do not include py-ref.h.
4924
4925 2019-01-22  Tom Tromey  <tom@tromey.com>
4926
4927         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4928         keyword for bcache.
4929
4930 2019-01-22  Tom Tromey  <tom@tromey.com>
4931
4932         * compile/compile-cplus-types.c: Remove a comment by #include.
4933
4934 2019-01-22  Tom Tromey  <tom@tromey.com>
4935
4936         * compile/gcc-c-plugin.h: Include compile-internal.h.
4937
4938 2019-01-22  Tom Tromey  <tom@tromey.com>
4939
4940         * stabsread.c (EXTERN): Do not define.
4941         (symnum, next_symbol_text_func, processing_gcc_compilation)
4942         (within_function, global_sym_chain, global_stabs)
4943         (previous_stab_code, this_object_header_files)
4944         (n_this_object_header_files)
4945         (n_allocated_this_object_header_files): Define.
4946         * stabsread.h (EXTERN): Never define.  Use "extern".
4947
4948 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4951         history_value.
4952
4953 2019-01-21  Tom Tromey  <tom@tromey.com>
4954
4955         * ui-out.c: Fix includes.
4956         * tui/tui-source.c: Fix includes.
4957         * target.c: Fix includes.
4958         * remote.c: Fix includes.
4959         * regcache.c: Fix includes.
4960         * python/py-block.c: Fix includes.
4961         * printcmd.c: Fix includes.
4962         * or1k-tdep.c: Fix includes.
4963         * mi/mi-main.c: Fix includes.
4964         * m32r-tdep.c: Fix includes.
4965         * csky-tdep.c: Fix includes.
4966         * compile/compile-cplus-types.c: Fix includes.
4967         * cli/cli-interp.c: Fix includes.
4968
4969 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4970
4971         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4972         for padding.
4973
4974 2019-01-16  Tom Tromey  <tom@tromey.com>
4975
4976         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4977         earlier.
4978         (struct objfile) <msymbols_range>: Move from top level.
4979         <msymbols>: New method.
4980         (class objfile_msymbols): Remove.
4981         * symtab.c (default_collect_symbol_completion_matches_break_on):
4982         Update.
4983         * symmisc.c (dump_msymbols): Update.
4984         * stabsread.c (scan_file_globals): Update.
4985         * objc-lang.c (info_selectors_command, info_classes_command)
4986         (find_methods): Update.
4987         * minsyms.c (find_solib_trampoline_target): Update.
4988         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4989         * coffread.c (coff_symfile_read): Update.
4990         * ada-lang.c (ada_lookup_simple_minsym)
4991         (ada_collect_symbol_completion_matches): Update.
4992
4993 2019-01-16  Tom Tromey  <tom@tromey.com>
4994
4995         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4996         type.  Remove no-argument constructor.
4997         <iterator::operator++>: Simplify.
4998         <begin>: Update.
4999         <end>: Use minimal_symbol_count.
5000
5001 2019-01-16  Tom Tromey  <tom@tromey.com>
5002
5003         * objfiles.h (struct objfile) <psymtabs>: New method.
5004         (class objfile_psymtabs): Remove.
5005         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5006         typedef.
5007         <range>: New method.
5008         (require_partial_symbols): Change return type.
5009         * psymtab.c (require_partial_symbols)
5010         (psym_expand_symtabs_matching): Update.
5011         * mdebugread.c (parse_partial_symbols): Update.
5012         * dbxread.c (dbx_end_psymtab): Update.
5013
5014 2019-01-15  Tom Tromey  <tom@tromey.com>
5015
5016         * symtab.c (lookup_objfile_from_block)
5017         (lookup_symbol_in_objfile_symtabs)
5018         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5019         (find_line_symtab, info_sources_command)
5020         (default_collect_symbol_completion_matches_break_on)
5021         (make_source_files_completion_list): Update.
5022         * symmisc.c (print_objfile_statistics, dump_objfile)
5023         (maintenance_print_symbols, maintenance_info_symtabs)
5024         (maintenance_check_symtabs, maintenance_info_line_tables):
5025         Update.
5026         * source.c (select_source_symtab)
5027         (forget_cached_source_info_for_objfile): Update.
5028         * objfiles.h (class objfile_compunits): Remove.
5029         (struct objfile) <compunits_range>: New typedef.
5030         (compunits): New method.
5031         * objfiles.c (objfile_relocate1): Update.
5032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5033         * maint.c (count_symtabs_and_blocks): Update.
5034         * linespec.c (iterate_over_all_matching_symtabs): Update.
5035         * cp-support.c (add_symbol_overload_list_qualified): Update.
5036         * coffread.c (coff_symtab_read): Update.
5037         * ada-lang.c (add_nonlocal_symbols)
5038         (ada_collect_symbol_completion_matches)
5039         (ada_add_global_exceptions): Update.
5040
5041 2019-01-15  Tom Tromey  <tom@tromey.com>
5042
5043         * progspace.h (program_space) <objfiles_safe_range>: New
5044         typedef.
5045         <objfiles_safe>: New method.
5046         * objfiles.h (class all_objfiles_safe): Remove.
5047         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5048         * jit.c (jit_inferior_exit_hook): Update.
5049
5050 2019-01-17  Tom Tromey  <tom@tromey.com>
5051
5052         * progspace.h (program_space) <objfiles_range>: New typedef.
5053         <objfiles>: New method.
5054         <objfiles_head>: Rename from objfiles.
5055         (object_files): Update.
5056         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5057         * guile/scm-pretty-print.c
5058         (ppscm_find_pretty_printer_from_objfiles): Update.
5059         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5060         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5061         Update.
5062         * python/py-progspace.c (pspy_get_objfiles): Update.
5063         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5064         Update.
5065         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5066         (objfpy_lookup_objfile_by_build_id): Update.
5067         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5068         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5069         Update.
5070         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5071         (expand_symtab_containing_pc, lookup_objfile_from_block)
5072         (lookup_static_symbol, basic_lookup_transparent_type)
5073         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5074         (find_line_symtab, info_sources_command)
5075         (default_collect_symbol_completion_matches_break_on)
5076         (make_source_files_completion_list, find_main_name): Update.
5077         * symmisc.c (print_symbol_bcache_statistics)
5078         (print_objfile_statistics, maintenance_print_symbols)
5079         (maintenance_print_msymbols, maintenance_print_objfiles)
5080         (maintenance_info_symtabs, maintenance_check_symtabs)
5081         (maintenance_expand_symtabs, maintenance_info_line_tables):
5082         Update.
5083         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5084         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5085         (map_overlay_command, unmap_overlay_command)
5086         (simple_overlay_update, expand_symtabs_matching)
5087         (map_symbol_filenames): Update.
5088         * symfile-debug.c (set_debug_symfile): Update.
5089         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5090         Update.
5091         * source.c (select_source_symtab, forget_cached_source_info):
5092         Update.
5093         * solib.c (solib_read_symbols): Update.
5094         * solib-spu.c (append_ocl_sos): Update.
5095         * psymtab.c (maintenance_print_psymbols)
5096         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5097         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5098         * printcmd.c (info_symbol_command): Update.
5099         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5100         Update.
5101         * objfiles.h (class all_objfiles): Remove.
5102         * objfiles.c (have_partial_symbols, have_full_symbols)
5103         (have_minimal_symbols, qsort_cmp, update_section_map)
5104         (shared_objfile_contains_address_p)
5105         (default_iterate_over_objfiles_in_search_order): Update.
5106         * objc-lang.c (info_selectors_command, info_classes_command)
5107         (find_methods): Update.
5108         * minsyms.c (find_solib_trampoline_target): Update.
5109         * maint.c (maintenance_info_sections)
5110         (maintenance_translate_address, count_symtabs_and_blocks):
5111         Update.
5112         * main.c (captured_main_1): Update.
5113         * linux-thread-db.c (try_thread_db_load_from_pdir)
5114         (has_libpthread): Update.
5115         * linespec.c (iterate_over_all_matching_symtabs)
5116         (search_minsyms_for_name): Update.
5117         * jit.c (jit_find_objf_with_entry_addr): Update.
5118         * hppa-tdep.c (find_unwind_entry)
5119         (hppa_lookup_stub_minimal_symbol): Update.
5120         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5121         Update.
5122         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5123         (elf_gnu_ifunc_resolve_by_got): Update.
5124         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5125         * dwarf-index-write.c (save_gdb_index_command): Update.
5126         * cp-support.c (add_symbol_overload_list_qualified): Update.
5127         * breakpoint.c (create_overlay_event_breakpoint)
5128         (create_longjmp_master_breakpoint)
5129         (create_std_terminate_master_breakpoint)
5130         (create_exception_master_breakpoint): Update.
5131         * blockframe.c (find_pc_partial_function): Update.
5132         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5133         (ada_collect_symbol_completion_matches)
5134         (ada_add_global_exceptions): Update.
5135
5136 2019-01-17  Tom Tromey  <tom@tromey.com>
5137
5138         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5139         declare VEC.
5140         (solib_target_parse_libraries): Change return type.
5141         (library_list_start_segment, library_list_start_section)
5142         (library_list_end_library, library_list_start_library); Update.
5143         (solib_target_free_library_list): Remove.
5144         (solib_target_parse_libraries): Remove cleanup.  Change return
5145         type.
5146         (solib_target_current_sos): Update.
5147
5148 2019-01-17  Tom Tromey  <tromey@bapiya>
5149
5150         * valprint.c: Replace "the the" with "the".
5151         * symtab.c: Replace "the the" with "the".
5152         * solib.c: Replace "the the" with "the".
5153         * solib-dsbt.c: Replace "the the" with "the".
5154         * linespec.c: Replace "the the" with "the".
5155         * dwarf2loc.h: Replace "the the" with "the".
5156         * amd64-windows-tdep.c: Replace "the the" with "the".
5157         * aarch64-tdep.c: Replace "the the" with "the".
5158
5159 2019-01-16  Keith Seitz  <keiths@redhat.com>
5160
5161         PR gdb/23773
5162         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5163         <builder>: Rename to ..
5164         <m_builder>: ... this and make private.
5165         (dwarf2_cu::get_builder): New method.  Change all users of
5166         `builder' to use this method.
5167         (dwarf2_start_symtab): Move to ...
5168         (dwarf2_cu::start_symtab): ... here.  Update all callers
5169         (setup_type_unit_groups): Move to ...
5170         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5171         callers.
5172         (dwarf2_cu::reset_builder): New method.
5173         (process_full_compunit, process_full_type_unit): Use
5174         dwarf2_cu::reset_builder.
5175         (follow_die_offset): Record the ancestor CU if it is different
5176         from the followed DIE's CU.
5177         (follow_die_sig_1): Likewise.
5178
5179 2019-01-15  Tom Tromey  <tom@tromey.com>
5180
5181         * remote.c (class remote_state) <buf>: Now a char_vector.
5182         <buf_size>: Remove.
5183         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5184         parameter.
5185         (remote_target::getpkt_or_notif_sane_1)
5186         (remote_target::getpkt_sane)
5187         (remote_target::getpkt_or_notif_sane): Likewise.
5188         (class remote_target) <putpkt>: New overload.
5189         (remote_target::read_frame): Change type of "buf_p".  Remove
5190         sizeof_p parameter.
5191         (packet_ok): New overload.
5192         (packet_check_result): New overload.
5193         Update all uses.
5194
5195 2019-01-14  Tom Tromey  <tom@tromey.com>
5196
5197         * remote-notif.c (handle_notification, remote_notif_ack)
5198         (remote_notif_parse): Make "buf" const.
5199         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5200         const.
5201         (remote_notif_parse, remote_notif_ack, handle_notification):
5202         Likewise.
5203         * remote.c (remote_notif_stop_parse): Make "buf" const.
5204         (remote_target::remote_parse_stop_reply): Make "buf" const.
5205         (remote_notif_stop_ack): Make "buf" const.
5206
5207 2019-01-14  Tom Tromey  <tom@tromey.com>
5208
5209         * remote.c (remote_console_output): Make parameter const.
5210
5211 2019-01-14  Tom Tromey  <tom@tromey.com>
5212
5213         * target-debug.h (target_debug_print_signals): Constify.
5214         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5215         * procfs.c (procfs_target::pass_signals): Update.
5216         * linux-nat.c (linux_nat_target::pass_signals): Update.
5217         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5218         * target-delegates.c: Rebuild.
5219         * remote.c (remote_target::program_signals): Update.
5220         (remote_target::pass_signals): Update.
5221         * target.c (target_pass_signals): Constify argument.
5222         (target_program_signals): Likewise.
5223         * target.h (struct target_ops) <pass_signals, program_signals>:
5224         Constify argument.
5225         (target_pass_signals, target_program_signals): Constify argument.
5226
5227 2019-01-14  Tom Tromey  <tom@tromey.com>
5228
5229         PR tui/28819:
5230         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5231
5232 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5233
5234         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5235         field.
5236         * rs6000-tdep.c: Include reggroups.h.
5237         (IS_V_ALIAS_PSEUDOREG): Define.
5238         (rs6000_register_name): Return names for the "vX" aliases.
5239         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5240         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5241         aliases.  Call default_register_reggroup_p for all other
5242         pseudo-registers.
5243         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5244         New functions.
5245         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5246         Handle "vX" aliases.
5247         (v_alias_pseudo_register_collect): New function.
5248         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5249         (rs6000_gdbarch_init): Initialize "vX" aliases as
5250         pseudo-registers.  Restore registration of
5251         rs6000_pseudo_register_reggroup_p with
5252         set_tdesc_pseudo_register_reggroup_p.
5253
5254 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5255
5256         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5257         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5258         set_gdbarch_num_pseudo_regs.
5259
5260 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5261
5262         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5263         Remove arg prefixname, add do_set and do_show.
5264         Add member functions set_list and show_list.
5265         * cli/cli-style.c (class cli_style_option): Update accordingly.
5266         (style_set_list): Move to file scope.
5267         (style_show_list): Likewise.
5268         (set_style): Call help_list.
5269         (show_style): Call cmd_show_list.
5270         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5271         Update to use the new macro.
5272
5273 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5274
5275         * ada-lang.c (_initialize_ada_language): Expand the help text
5276         for the "catch exception" command.
5277
5278 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5279
5280         * symtab.c (matching_obj_sections): Initialize obj,
5281         declare it closer to its usage.
5282
5283 2019-01-10  Tom Tromey  <tom@tromey.com>
5284
5285         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5286         (basic_inf_threads_range): Remove.
5287         (inf_threads_range, inf_non_exited_threads_range)
5288         (safe_inf_threads_range): Use next_adapter.
5289
5290 2019-01-10  Keith Seitz  <keiths@redhat.com>
5291
5292         PR gdb/23712
5293         PR symtab/23010
5294         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5295         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5296
5297 2019-01-10  Keith Seitz  <keiths@redhat.com>
5298
5299         PR gdb/23712
5300         PR symtab/23010
5301         * dictionary.c (pending_to_vector): Remove.
5302         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5303         Remove _1 suffix, replacing functions of the same name.  Update
5304         all callers.
5305         (dict_create_hashed, dict_create_hashed_expandable)
5306         (dict_create_linear, dict_create_linear_expandable, dict_free)
5307         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5308         Make functions static.
5309
5310 2019-01-10  Keith Seitz  <keiths@redhat.com>
5311
5312         PR gdb/23712
5313         PR symtab/23010
5314         * dictionary.h (struct dictionary): Replace declaration with
5315         multidictionary.
5316         (dict_create_hashed, dict_create_hashed_expandable)
5317         (dict_create_linear, dict_create_linear_expandable)
5318         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5319         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5320         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5321         taking multidictionary argument.
5322         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5323         * block.h (struct block) <dict>: Change to multidictionary
5324         and rename `multidict'.
5325         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5326         symmisc.c: Update all dictionary references to multidictionary.
5327
5328 2019-01-10  Keith Seitz  <keiths@redhat.com>
5329
5330         PR gdb/23712
5331         PR symtab/23010
5332         * dictionary.c: Include unordered_map.
5333         (pending_to_vector): New function.
5334         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5335         Rewrite the non-"_1" functions to take vector instead
5336         of linked list.
5337         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5338         "new" _1 versions of the same name.
5339         (multidictionary): Define.
5340         (std::hash<enum language): New definition.
5341         (collate_pending_symbols_by_language, mdict_create_hashed)
5342         (mdict_create_hashed_expandable, mdict_create_linear)
5343         (mdict_create_linear_expandable, mdict_free)
5344         (find_language_dictionary, create_new_language_dictionary)
5345         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5346         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5347         (mdict_size, mdict_empty): New functions.
5348         * dictionary.h (mdict_iterator): Define.
5349
5350 2019-01-10  Pedro Alves  <palves@redhat.com>
5351
5352         * breakpoint.c (read_uploaded_action)
5353         (create_tracepoint_from_upload): Adjust to use
5354         gdb::unique_xmalloc_ptr.
5355         * ctf.c (ctf_write_uploaded_tp):
5356         (SET_ARRAY_FIELD): Use emplace_back.
5357         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5358         * tracefile-tfile.c (tfile_write_uploaded_tp):
5359         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5360         gdb::unique_xmalloc_ptr.
5361         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5362         at_string, cond_string, cmd_strings>: Replace char pointers
5363         with gdb::unique_xmalloc_ptr.
5364
5365 2019-01-10  Pedro Alves  <palves@redhat.com>
5366
5367         * solib-target.c (library_list_start_library): Don't xstrdup name.
5368
5369 2019-01-10  Pedro Alves  <palves@redhat.com>
5370
5371         * mdebugread.c (parse_partial_symbols): Use
5372         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5373
5374 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5375
5376         * linux-fork.c (scoped_switch_fork_info)
5377         <~scoped_switch_fork_info>: Fix incorrect variable name.
5378
5379 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * linux-fork.c (scoped_switch_fork_info)
5382         <scoped_switch_fork_info>: Make explicit.
5383         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5384
5385 2019-01-10  Tom Tromey  <tom@tromey.com>
5386
5387         * objfiles.h (objfile::reset_psymtabs): Update.
5388         * objfiles.c (objfile::objfile): Update.
5389         * psymtab.h (psymtab_storage::obstack): Update.
5390         (psymtab_storage::m_obstack): Use gdb::optional.
5391         (class psymtab_storage): Update comment.  Remove objfile
5392         parameter.
5393         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5394
5395 2019-01-10  Tom Tromey  <tom@tromey.com>
5396
5397         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5398         <free_psymtabs>: Now private.
5399         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5400         (allocate_psymtab): Use new method.
5401
5402 2019-01-10  Tom Tromey  <tom@tromey.com>
5403
5404         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5405         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5406         * mdebugread.c (parse_partial_symbols): Use
5407         allocate_dependencies.
5408         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5409         allocate_dependencies.
5410         (process_psymtab_comp_unit_reader)
5411         (build_type_psymtab_dependencies): Likewise.
5412         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5413
5414 2019-01-10  Tom Tromey  <tom@tromey.com>
5415
5416         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5417         PSYMBOL_SET_LANGUAGE.
5418         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5419
5420 2019-01-10  Tom Tromey  <tom@tromey.com>
5421
5422         * psymtab.h (psymtab_storage::obstack): New method.
5423         <m_obstack>: Rename from obstack; now private.
5424         * psymtab.c (psymtab_storage): Update.
5425         * dwarf2read.c (create_addrmap_from_index)
5426         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5427         Update.
5428
5429 2019-01-10  Tom Tromey  <tom@tromey.com>
5430
5431         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5432         * objfiles.h (objfile::reset_psymtabs): New method.
5433
5434 2019-01-10  Tom Tromey  <tom@tromey.com>
5435
5436         * symmisc.c (print_symbol_bcache_statistics): Update.
5437         (print_objfile_statistics): Update.
5438         * symfile.c (reread_symbols): Update.
5439         * psymtab.h (class psymtab_storage): New.
5440         * psymtab.c (psymtab_storage): New constructor.
5441         (~psymtab_storage): New destructor.
5442         (require_partial_symbols): Update.
5443         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5444         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5445         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5446         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5447         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5448         (start_psymtab_common, end_psymtab_common)
5449         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5450         (allocate_psymtab): Update.
5451         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5452         Update.
5453         (dump_psymtab_addrmap, maintenance_print_psymbols)
5454         (maintenance_check_psymtabs): Update.
5455         (class objfile_psymtabs): Move to objfiles.h.
5456         * psympriv.h (discard_psymtab): Now inline.
5457         (psymtab_discarder::psymtab_discarder): Update.
5458         (psymtab_discarder::~psymtab_discarder): Update.
5459         (ALL_OBJFILE_PSYMTABS): Rewrite.
5460         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5461         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5462         Remove fields.
5463         <partial_symtabs>: New field.
5464         (class objfile_psymtabs): Move from psymtab.h.  Update.
5465         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5466         psymbol_cache.
5467         (objfile::~objfile): Don't destroy psymbol_cache.
5468         * mdebugread.c (parse_partial_symbols): Update.
5469         * dwarf2read.c (create_addrmap_from_index)
5470         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5471         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5472         (add_partial_subprogram, dwarf2_ranges_read): Update.
5473         * dwarf-index-write.c (write_address_map)
5474         (write_one_signatured_type, recursively_write_psymbols)
5475         (class debug_names, class debug_names, write_psymtabs_to_index):
5476         Update.
5477
5478 2019-01-10  Tom Tromey  <tom@tromey.com>
5479
5480         * symtab.h (SYMBOL_SET_NAMES): Update.
5481         (symbol_set_names): Update.
5482         (MSYMBOL_SET_NAMES): Update.
5483         * symtab.c (symbol_set_names): Change argument to be an
5484         objfile_per_bfd_storage.
5485         * psymtab.c (add_psymbol_to_bcache): Update.
5486         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5487
5488 2019-01-10  Tom Tromey  <tom@tromey.com>
5489
5490         * symtab.c (create_demangled_names_hash): Change argument to be an
5491         objfile_per_bfd_storage.
5492         (symbol_set_names): Update.
5493
5494 2019-01-10  Tom Tromey  <tom@tromey.com>
5495
5496         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5497         init_psymbol_list.
5498         * psymtab.c (init_psymbol_list): Do nothing if already called.
5499         * psympriv.h (init_psymbol_list): Add comment.
5500         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5501         init_psymbol_list.
5502         * dbxread.c (dbx_symfile_read): Unconditionally call
5503         init_psymbol_list.
5504
5505 2019-01-10  Tom Tromey  <tom@tromey.com>
5506
5507         * xcoffread.c (scan_xcoff_symtab): Update.
5508         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5509         "where".
5510         * mdebugread.c (parse_partial_symbols)
5511         (handle_psymbol_enumerators): Update.
5512         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5513         * dbxread.c (read_dbx_symtab): Update.
5514         * psympriv.h (psymbol_placement): New enum.
5515         (add_psymbol_to_list): Update.
5516
5517 2019-01-10  Tom Tromey  <tom@tromey.com>
5518
5519         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5520         static_psymbols parameters.
5521         (scan_xcoff_symtab): Update.
5522         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5523         static_psymbols parameters.
5524         * psympriv.h (start_psymtab_common): Update.
5525         * mdebugread.c (parse_partial_symbols): Update.
5526         * dwarf2read.c (create_partial_symtab): Update.
5527         * dbxread.c (read_dbx_symtab): Update.
5528         (start_psymtab): Remove global_psymbols and static_psymbols
5529         parameters.
5530
5531 2019-01-10  Tom Tromey  <tom@tromey.com>
5532
5533         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5534         * psymtab.c (allocate_psymtab): Add comment.
5535         * psympriv.h (allocate_psymtab): Add comment.
5536         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5537         initializations.
5538         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5539
5540 2019-01-10  Tom Tromey  <tom@tromey.com>
5541
5542         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5543         Don't declare.
5544         * mipsread.c: Include mdebugread.h.
5545         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5546         Declare.
5547         * elfread.c: Include mdebugread.h.
5548
5549 2019-01-09  Tom Tromey  <tom@tromey.com>
5550
5551         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5552         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5553         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5554         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5555         (psym_lookup_symbol, psym_find_last_source_symtab)
5556         (psym_forget_cached_source_info, psym_print_stats)
5557         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5558         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5559         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5560         (psym_find_compunit_symtab_by_address)
5561         (maintenance_print_psymbols, maintenance_info_psymtabs)
5562         (maintenance_check_psymtabs): Use ranged for.
5563         * psymtab.h (class objfile_psymtabs): New.
5564         (require_partial_symbols): Return objfile_psymtabs.
5565         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5566
5567 2019-01-09  Tom Tromey  <tom@tromey.com>
5568
5569         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5570         (find_pc_mapped_section, list_overlays_command)
5571         (map_overlay_command, unmap_overlay_command)
5572         (simple_overlay_update): Use all_objfiles.
5573         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5574         * printcmd.c (info_symbol_command): Use all_objfiles.
5575         * objfiles.h (ALL_OBJSECTIONS): Remove.
5576         * maint.c (maintenance_translate_address): Use all_objfiles.
5577         * gcore.c (gcore_create_callback): Use all_objfiles.
5578         (objfile_find_memory_regions): Likewise.
5579
5580 2019-01-09  Tom Tromey  <tom@tromey.com>
5581
5582         * symtab.c (find_line_symtab, info_sources_command)
5583         (make_source_files_completion_list): Use objfile_compunits.
5584         * source.c (select_source_symtab): Use objfile_compunits.
5585         * objfiles.h (struct objfile): Update comment.
5586         (ALL_OBJFILES): Remove.
5587         (ALL_FILETABS): Remove.
5588         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5589         objfile_compunits.
5590
5591 2019-01-09  Tom Tromey  <tom@tromey.com>
5592
5593         * symmisc.c (print_objfile_statistics, dump_objfile)
5594         (maintenance_print_symbols): Use compunit_filetabs.
5595         * source.c (forget_cached_source_info_for_objfile): Use
5596         compunit_filetabs.
5597         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5598         (ALL_FILETABS): Use compunit_filetabs.
5599         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5600         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5601
5602 2019-01-09  Tom Tromey  <tom@tromey.com>
5603
5604         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5605         (compunit_filetabs): New.
5606         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5607         compunit_filetabs.
5608         (info_sources_command, make_source_files_completion_list): Remove
5609         declaration.
5610         * symmisc.c (print_objfile_statistics, dump_objfile)
5611         (maintenance_print_symbols): Remove declaration.
5612         (maintenance_info_symtabs): Use compunit_filetabs.
5613         (maintenance_info_line_tables): Likewise.
5614         * source.c (select_source_symtab): Change local variable name.
5615         (forget_cached_source_info_for_objfile): Remove declaration.
5616         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5617         * objfiles.c (objfile_relocate1): Remove declaration.
5618         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5619         declaration.
5620         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5621         * coffread.c (coff_symtab_read): Remove declaration.
5622         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5623         compunit_filetabs.
5624
5625 2019-01-09  Tom Tromey  <tom@tromey.com>
5626
5627         * symtab.c (lookup_objfile_from_block)
5628         (find_pc_sect_compunit_symtab, search_symbols)
5629         (default_collect_symbol_completion_matches_break_on): Use
5630         objfile_compunits.
5631         * objfiles.h (ALL_COMPUNITS): Remove.
5632         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5633         * cp-support.c (add_symbol_overload_list_qualified): Use
5634         objfile_compunits.
5635         * ada-lang.c (ada_collect_symbol_completion_matches)
5636         (ada_add_global_exceptions): Use objfile_compunits.
5637
5638 2019-01-09  Tom Tromey  <tom@tromey.com>
5639
5640         * source.c (select_source_symtab)
5641         (forget_cached_source_info_for_objfile): Remove declaration.
5642         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5643         declaration.
5644         * maint.c (count_symtabs_and_blocks): Remove declaration.
5645         * cp-support.c (add_symbol_overload_list_qualified): Remove
5646         declaration.
5647         * coffread.c (coff_symtab_read): Remove declaration.
5648         * symtab.c (lookup_symbol_in_objfile_symtabs)
5649         (basic_lookup_transparent_type_1): Use objfile_compunits.
5650         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5651         (info_sources_command, search_symbols)
5652         (default_collect_symbol_completion_matches_break_on)
5653         (make_source_files_completion_list): Remove declaration.
5654         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5655         (ada_collect_symbol_completion_matches)
5656         (ada_add_global_exceptions): Remove declaration.
5657         * linespec.c (iterate_over_all_matching_symtabs): Use
5658         objfile_compunits.
5659         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5660         (class objfile_compunits): New.
5661         (ALL_COMPUNITS): Use objfile_compunits.
5662         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5663         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5664         objfile_compunits.
5665         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5666
5667 2019-01-09  Tom Tromey  <tom@tromey.com>
5668
5669         * symtab.c (search_symbols)
5670         (default_collect_symbol_completion_matches_break_on): Use
5671         objfile_msymbols.
5672         * ada-lang.c (ada_lookup_simple_minsym)
5673         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5674         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5675         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5676         objfile_msymbols.
5677         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5678         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5679         * objc-lang.c (find_methods): Use objfile_msymbols.
5680         (info_selectors_command, info_classes_command): Likewise.
5681         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5682         * objfiles.h (class objfile_msymbols): New.
5683         (ALL_OBJFILE_MSYMBOLS): Remove.
5684         (ALL_MSYMBOLS): Remove.
5685
5686 2019-01-09  Tom Tromey  <tom@tromey.com>
5687
5688         * common/next-iterator.h (next_adapter): Add Iterator template
5689         parameter.
5690         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5691         (class all_objfiles_safe): New.
5692         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5693         * objfiles.c (put_objfile_before): Update comment.
5694         (add_separate_debug_objfile): Likewise.
5695         (free_all_objfiles): Use all_objfiles_safe.
5696         (objfile_purge_solibs): Likewise.
5697
5698 2019-01-09  Tom Tromey  <tom@tromey.com>
5699
5700         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5701         (expand_symtab_containing_pc, lookup_static_symbol)
5702         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5703         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5704         all_objfiles.
5705         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5706         * breakpoint.c (create_overlay_event_breakpoint)
5707         (create_longjmp_master_breakpoint)
5708         (create_std_terminate_master_breakpoint)
5709         (create_exception_master_breakpoint): Use all_objfiles.
5710         * linux-thread-db.c (try_thread_db_load_from_pdir)
5711         (has_libpthread): Use all_objfiles.
5712         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5713         * linespec.c (iterate_over_all_matching_symtabs)
5714         (search_minsyms_for_name): Use all_objfiles.
5715         * maint.c (maintenance_info_sections): Use all_objfiles.
5716         * main.c (captured_main_1): Use all_objfiles.
5717         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5718         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5719         * guile/scm-pretty-print.c
5720         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5721         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5722         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5723         (maintenance_print_msymbols): Use all_objfiles.
5724         * source.c (select_source_symtab): Use all_objfiles.
5725         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5726         * symfile.c (remove_symbol_file_command)
5727         (expand_symtabs_matching, map_symbol_filenames): Use
5728         all_objfiles.
5729         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5730         all_objfiles.
5731         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5732         * objc-lang.c (find_methods): Use all_objfiles.
5733         * objfiles.c (have_partial_symbols, have_full_symbols)
5734         (have_minimal_symbols, qsort_cmp)
5735         (default_iterate_over_objfiles_in_search_order): Use
5736         all_objfiles.
5737         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5738         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5739         (maintenance_check_psymtabs): Use all_objfiles.
5740         (ALL_PSYMTABS): Remove.
5741         * compile/compile-object-run.c (do_module_cleanup): Use
5742         all_objfiles.
5743         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5744         * cp-support.c (add_symbol_overload_list_qualified): Use
5745         all_objfiles.
5746         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5747         Use all_objfiles.
5748         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5749         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5750         all_objfiles.
5751         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5752         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5753         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5754         Uses all_objfiles.
5755         * solib.c (solib_read_symbols): Use all_objfiles
5756
5757 2019-01-09  Tom Tromey  <tom@tromey.com>
5758
5759         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5760         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5761         all_objfiles.
5762         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5763         * symmisc.c (print_symbol_bcache_statistics)
5764         (print_objfile_statistics, maintenance_print_objfiles)
5765         (maintenance_info_symtabs, maintenance_check_symtabs)
5766         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5767         all_objfiles.
5768         * source.c (forget_cached_source_info): Use all_objfiles.
5769         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5770         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5771         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5772         * objfiles.c (update_section_map): Use all_objfiles.
5773         (shared_objfile_contains_address_p): Likewise.
5774         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5775         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5776
5777 2019-01-09  Tom Tromey  <tom@tromey.com>
5778
5779         * common/next-iterator.h: New file.
5780         * objfiles.h (class all_objfiles): New.
5781         (struct objfile_iterator): New.
5782
5783 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5784
5785         * NEWS: Move the description of the changed "frame", "select-frame",
5786          and "info frame" commands to the Changed commands section.
5787
5788 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5789
5790         * gdbtypes.c (check_stub_method_group): Remove handling of old
5791         mangling schemes.
5792         * linespec.c (find_methods): Likewise.
5793         * stabsread.c (read_member_functions): Likewise.
5794         * valops.c (search_struct_method): Likewise.
5795         (value_struct_elt_for_reference): Likewise.
5796         * NEWS: Mention this change.
5797
5798 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5801         print_source_lines.
5802         * source.c (print_source_lines_base): Update line number check.
5803         (print_source_lines): New function.
5804         (source_lines_range::source_lines_range): New function.
5805         * source.h (class source_lines_range): New class.
5806         (print_source_lines): New declaration.
5807
5808 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5809
5810         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5811
5812 2019-01-08  Tom Tromey  <tom@tromey.com>
5813             Simon Marchi  <simon.marchi@ericsson.com>
5814
5815         PR gdb/24060
5816         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5817         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5818         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5819         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5820         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5821         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5822
5823 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * source.c (select_source_symtab): Move header comment to
5826         declaration in source.h.
5827         (forget_cached_source_info_for_objfile): Likewise.
5828         (forget_cached_source_info): Likewise.
5829         (identify_source_line): Likewise.
5830         * source.h (identify_source_line): Move declaration from symtab.h
5831         and add comment from source.c
5832         (print_source_lines): Likewise.
5833         (forget_cached_source_info_for_objfile): Likewise.
5834         (forget_cached_source_info): Likewise.
5835         (select_source_symtab): Likewise.
5836         (enum print_source_lines_flag): Move definition from symtab.h.
5837         * symtab.h (identify_source_line): Move declaration to source.h.
5838         (print_source_lines): Likewise.
5839         (forget_cached_source_info_for_objfile): Likewise.
5840         (forget_cached_source_info): Likewise.
5841         (select_source_symtab): Likewise.
5842         (enum print_source_lines_flag): Move definition to source.h.
5843         * tui/tui-hooks.c: Add 'source.h' include.
5844
5845 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5846
5847         * source.c (print_source_lines_base): Handle requests to print
5848         reverse line number sequences, and guard against empty lines
5849         string.
5850
5851 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5852
5853         * source.c (print_source_lines_base): Fix skip of '\r' if next
5854         character is '\n'.
5855
5856 2019-01-06  Tom Tromey  <tom@tromey.com>
5857
5858         * c-exp.y (struct c_parse_state) <macro_original_text,
5859         expansion_obstack>: New member.
5860         (macro_original_text, expansion_obstack): Remove globals.
5861         (scan_macro_expansion, scanning_macro_expansion)
5862         (finished_macro_expansion): Update.
5863         (scan_macro_cleanup): Remove.
5864         (yylex, c_parse): Update.
5865
5866 2019-01-06  Tom Tromey  <tom@tromey.com>
5867
5868         * c-exp.y (struct c_parse_state) <strings>: New member.
5869         (operator_stoken): Update.
5870
5871 2019-01-06  Tom Tromey  <tom@tromey.com>
5872
5873         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5874         (union type_stack_elt) <typelist_val>: Now a pointer to
5875         std::vector.
5876         (type_stack_cleanup): Don't declare.
5877         (push_typelist): Update.
5878         * parse.c (pop_typelist): Return a std::vector.
5879         (push_typelist): Take a std::vector.
5880         (follow_types): Update.  Do not free args.
5881         (type_stack_cleanup): Remove.
5882         * c-exp.y (struct c_parse_state): New.
5883         (cpstate): New global.
5884         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5885         (nonempty_typelist): Update.
5886         (func_mod): Create a new vector.
5887         (c_parse): Create a c_parse_state.
5888         (check_parameter_typelist): Do not delete params.
5889         (function_method): Update.  Do not delete type_list.
5890
5891 2019-01-06  Tom Tromey  <tom@tromey.com>
5892
5893         PR gdb/28155:
5894         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5895         check_typedef.
5896         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5897         (print_return_value): Likewise.
5898
5899 2019-01-05  Tom Tromey  <tom@tromey.com>
5900
5901         * contrib/cleanup_check.py: Remove.
5902         * contrib/gcc-with-excheck: Remove.
5903         * contrib/exsummary.py: Remove.
5904         * contrib/excheck.py: Remove.
5905
5906 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5907
5908         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5909         NULL. Initialize tpprev to NULL instead of assigning it
5910         to NULL on the next statement.
5911         * windows-nat.c (windows_delete_thread): Remove check for
5912         main_thread_id before printing thread exit notifications.
5913         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5914         Remove thread ID check against main_thread_id.
5915         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5916         windows_delete_thread.
5917         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5918
5919 2019-01-04  Tom Tromey  <tom@tromey.com>
5920
5921         * compile/compile.c (_initialize_compile): Use upper case for
5922         metasyntactic variables.
5923         * symmisc.c (_initialize_symmisc): Use upper case for
5924         metasyntactic variables.
5925         * psymtab.c (_initialize_psymtab): Use upper case for
5926         metasyntactic variables.
5927         * demangle.c (demangle_command): Use upper case for metasyntactic
5928         variables.
5929         (_initialize_demangler): Likewise.
5930         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5931         variables.
5932
5933 2019-01-03  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5936
5937 2019-01-03  Tom Tromey  <tom@tromey.com>
5938
5939         * python/py-symtab.c (salpy_str): Update.
5940         (struct salpy_sal_object) <symtab>: Now a PyObject.
5941         (salpy_dealloc): Update.
5942         (del_objfile_sal): Use gdbpy_ref.
5943
5944 2019-01-03  Tom Tromey  <tom@tromey.com>
5945
5946         * python/py-type.c (convert_field): Use new_reference.  Return
5947         gdbpy_ref.
5948         (make_fielditem): Return gdbpy_ref.
5949         (typy_fields): Update.
5950         (typy_getitem): Update.
5951         (field_name): Return gdbpy_ref.  Use new_reference.
5952         (typy_iterator_iternext): Update.
5953
5954 2019-01-03  Tom Tromey  <tom@tromey.com>
5955
5956         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5957
5958 2019-01-03  Tom Tromey  <tom@tromey.com>
5959
5960         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5961         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5962         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5963         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5964         (pspy_set_type_printers): Likewise.
5965         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5966         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5967         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5968         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5969         (objfpy_set_type_printers): Likewise.
5970
5971 2019-01-03  Tom Tromey  <tom@tromey.com>
5972
5973         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5974         (gdbpy_print_stack): Use gdbpy_err_fetch.
5975         * python/python-internal.h (class gdbpy_err_fetch): New class.
5976         (class gdbpy_enter) <m_error_type, m_error_value,
5977         m_error_traceback>: Remove.
5978         <m_error>: New member.
5979         (gdbpy_exception_to_string): Don't declare.
5980         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5981         * python/py-value.c (convert_value_from_python): Use
5982         gdbpy_err_fetch.
5983         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5984         gdbpy_exception_to_string.
5985         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5986         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5987         gdbpy_err_fetch.
5988
5989 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * linux-nat.c (delete_lwp_cleanup): Delete.
5992         (struct lwp_deleter): New struct.
5993         (lwp_info_up): New typedef.
5994         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5995         lwp_info_up.
5996
5997 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * linux-fork.c (class scoped_switch_fork_info): New class.
6000         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6001
6002 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * valops.c (find_overload_match): Remove use of null_cleanup, and
6005         calls to do_cleanups.
6006
6007 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * compile/compile-cplus-types.c
6010         (compile_cplus_instance::decl_name): Handle changes to
6011         cp_func_name.
6012         * cp-support.c (cp_func_name): Update header comment, update
6013         return type.
6014         * cp-support.h (cp_func_name): Update return type in declaration.
6015         * valops.c (find_overload_match): Move temp_func local to top
6016         level of function and change its type.  Use temp_func to hold and
6017         delete temporary string obtained from cp_func_name.
6018
6019 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6020
6021         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6022         gdb::char_vector, remove cleanup, and update uses of `msg`.
6023
6024 2019-01-03  Jim Wilson  <jimw@sifive.com>
6025
6026         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6027
6028 2019-01-02  Tom Tromey  <tom@tromey.com>
6029
6030         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6031         (tdesc_parse_xml): Remove cleanups.
6032         * target-descriptions.h (make_cleanup_free_target_description):
6033         Don't declare.
6034         (target_desc_deleter): New struct.
6035         (target_desc_up): New typedef.
6036         * target-descriptions.c (target_desc_deleter::operator()): Rename
6037         from free_target_description.
6038         (make_cleanup_free_target_description): Remove.
6039
6040 2019-01-02  Tom Tromey  <tom@tromey.com>
6041
6042         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6043         constructor, destructor.
6044         (linespec_parser): Remove typedef.
6045         (~linespec_parser): Rename from linespec_parser_delete.
6046         (linespec_lex_to_end, linespec_complete_label)
6047         (linespec_complete): Update.
6048         (decode_line_full): Remove cleanups.
6049         (decode_line_1): Update.
6050
6051 2019-01-02  Tom Tromey  <tom@tromey.com>
6052
6053         * python/python-internal.h (inferior_to_inferior_object): Change
6054         return type.
6055         * python/py-exitedevent.c (create_exited_event_object): Update.
6056         * python/py-inferior.c (inferior_to_inferior_object): Return
6057         gdbpy_ref.
6058         (python_new_inferior, python_inferior_deleted)
6059         (thread_to_thread_object, delete_thread_object)
6060         (build_inferior_list, gdbpy_selected_inferior): Update.
6061         * python/py-infthread.c (create_thread_object): Update.  Also fail
6062         if inferior_to_inferior_object fails.
6063
6064 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6065
6066         * inferior.h (class inferior) <displaced_step_state>: New field.
6067         * infrun.h (struct displaced_step_state): Move here from
6068         infrun.c.  Initialize fields, add constructor.
6069         <inf>: Remove field.
6070         <reset>: New method.
6071         * infrun.c (struct displaced_step_inferior_state): Move to
6072         infrun.h.
6073         (displaced_step_inferior_states): Remove.
6074         (get_displaced_stepping_state): Adust.
6075         (displaced_step_in_progress_any_inferior): Adjust.
6076         (displaced_step_in_progress_thread): Adjust.
6077         (displaced_step_in_progress): Adjust.
6078         (add_displaced_stepping_state): Remove.
6079         (get_displaced_step_closure_by_addr): Adjust.
6080         (remove_displaced_stepping_state): Remove.
6081         (infrun_inferior_exit): Call displaced_step_state.reset.
6082         (use_displaced_stepping): Don't check for NULL.
6083         (displaced_step_prepare_throw): Call
6084         get_displaced_stepping_state.
6085         (displaced_step_fixup): Don't check for NULL.
6086         (prepare_for_detach): Don't check for NULL.
6087
6088 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6089
6090         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6091          in case of call that did not complete.
6092
6093 2019-01-02  Andrey Utkin  <autkin@undo.io>
6094
6095         * symfile.c (find_separate_debug_file): Fix search of debug files for
6096         remote debuggee.
6097
6098 2019-01-02  Tom Tromey  <tom@tromey.com>
6099
6100         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6101         indentation.
6102         * python/py-frame.c (frapy_older): Remove cast.
6103         (frapy_newer): Likewise.
6104         * python/py-breakpoint.c (local_setattro): Remove cast.
6105         * python/py-arch.c (archpy_name): Remove local variable.
6106         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6107
6108 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6109
6110         * unittests/basic_string_view/element_access/char/empty.cc:
6111         Fix year range in copyright header.
6112
6113 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6114
6115         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6116         Delete.
6117         <operator==>: Update with for removed field.
6118         <hash>: Likewise.
6119         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6120         <isa_features>: ...this.
6121         <abi_features>: New field.
6122         (riscv_isa_flen): Update comment.
6123         (riscv_abi_xlen): New declaration.
6124         (riscv_abi_flen): New declaration.
6125         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6126         isa_features.
6127         (riscv_abi_xlen): New function.
6128         (riscv_isa_flen): Update to get answer from isa_features.
6129         (riscv_abi_flen): New function.
6130         (riscv_has_fp_abi): Update to get answer from abi_features.
6131         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6132         xlen and flen.
6133         (riscv_call_info) <xlen, flen>: Update comment.
6134         (riscv_call_arg_struct): Remove invalid assertions
6135         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6136         is removed.
6137         (riscv_gdbarch_init): Gather isa features and abi features
6138         separately, ensure both match on the gdbarch when reusing an old
6139         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6140         a target with 64-bit float hardware.
6141
6142 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6143
6144         * source.c (search_command_helper): Stop reverse search
6145         when line 1 has been searched.
6146
6147 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6148
6149         * record-full.c (record_full_base_target::close): Rewrite
6150         record_full_core_buf_list free logic.
6151
6152 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6153
6154         * break-catch-syscall.c (print_one_catch_syscall): xfree
6155         the last text.
6156
6157 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6158
6159         * top.c (print_gdb_version): Update Copyright year in version
6160         message.
6161
6162 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6163
6164         Update copyright year range in all GDB files.
6165
6166 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6167
6168         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6169
6170 For older changes see ChangeLog-2018.
6171 \f
6172 Local Variables:
6173 mode: change-log
6174 left-margin: 8
6175 fill-column: 74
6176 version-control: never
6177 coding: utf-8
6178 End:
6179