gdb/ChangeLog

   1 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * NEWS: Mention AArch64 Pointer Authentication.
   4
   5 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * arm-linux-nat.c: Add include.
   8
   9 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  10
  11         * source-cache.c (source_cache::get_source_lines): Re-read
  12         fullname after calling open_source_file.
  13
  14 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  15
  16         * NEWS: Mention TLS support for FreeBSD.
  17
  18 2019-03-25  Tom Tromey  <tromey@adacore.com>
  19
  20         * minsyms.c (BUNCH_SIZE): Update comment.
  21         (~minimal_symbol_reader): Remove old comment.
  22         (compact_minimal_symbols): Update comment.
  23         (minimal_symbol_reader::install): Remove old comment.  Update
  24         other comments.
  25
  26 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * s390-linux-nat.c: Add include.
  29
  30 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  31
  32         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  33         Call linux_get_hwcap.
  34         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  35         Likewise.
  36         (aarch64_linux_get_hwcap): Remove function.
  37         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  38         declaration.
  39         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  40         linux_get_hwcap.
  41         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  42         * linux-tdep.c (linux_get_hwcap): Add function.
  43         (linux_get_hwcap2): Likewise.
  44         * linux-tdep.h (linux_get_hwcap): Add declaration.
  45         (linux_get_hwcap2): Likewise.
  46         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  47         (ppc_linux_get_hwcap2): Likewise.
  48         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  49         linux_get_hwcap.
  50         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  51         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  52         (ppc_linux_nat_target::read_description): Likewise.
  53         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  54         * s390-linux-nat.c: Likewise.
  55         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  56
  57 2019-03-24  Tom Tromey  <tom@tromey.com>
  58
  59         * ada-lang.c (standard_lookup): Simplify initialization.
  60         (ada_lookup_symbol_nonlocal): Simplify return.
  61         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  62         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  63         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  64         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  65         initialization.
  66         * solib.c (solib_global_lookup): Simplify.
  67         * symtab.c (null_block_symbol): Remove.
  68         (symbol_cache_lookup): Simplify returns.
  69         (lookup_language_this): Simplify returns.
  70         (lookup_symbol_aux): Simplify return.
  71         (lookup_local_symbol): Simplify returns.
  72         (lookup_global_symbol_from_objfile): Simplify return.
  73         (lookup_symbol_in_objfile_symtabs)
  74         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  75         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  76         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  77         * cp-namespace.c (cp_lookup_bare_symbol)
  78         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  79         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  80         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  81         (cp_lookup_symbol_via_imports): Simplify initialization.
  82         (find_symbol_in_baseclass): Likewise.
  83         * symtab.h (null_block_symbol): Remove.
  84         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  85         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  86         (d_lookup_symbol_module): Likewise.
  87         (find_symbol_in_baseclass): Simplify initialization.
  88
  89 2019-03-24  Tom Tromey  <tom@tromey.com>
  90
  91         * expression.h: Don't include symtab.h.
  92         (struct block): Forward declare.
  93
  94 2019-03-24  Tom Tromey  <tom@tromey.com>
  95
  96         * c-exp.y (typebase): Remove casts.
  97         * gdbtypes.c (lookup_unsigned_typename, )
  98         (lookup_signed_typename): Remove cast.
  99         * eval.c (parse_to_comma_and_eval): Remove cast.
 100         * parse.c (write_dollar_variable): Remove cast.
 101         * block.h (struct block) <superblock>: Now const.
 102         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 103         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 104         (map_block): Make "block" const.
 105         * symfile.h (struct quick_symbol_functions)
 106         <map_matching_symbols>: Constify block argument to "callback".
 107         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 108         const.
 109         (find_pc_sect_compunit_symtab): Make "b" const.
 110         (find_symbol_at_address): Likewise.
 111         (search_symbols): Likewise.
 112         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 113         (dw2_debug_names_lookup_symbol): Likewise.
 114         (dw2_map_matching_symbols): Update.
 115         * p-valprint.c (pascal_val_print): Remove "block".
 116         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 117         (aux_add_nonlocal_symbols): Make "block" const.
 118         (resolve_subexp): Remove cast.
 119         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 120         const.
 121         (iterate_over_file_blocks): Likewise.
 122         * f-exp.y (%union) <bval>: Remove.
 123         * coffread.c (patch_opaque_types): Make "b" const.
 124         * spu-tdep.c (spu_catch_start): Make "block" const.
 125         * c-valprint.c (print_unpacked_pointer): Remove "block".
 126         * symmisc.c (dump_symtab_1): Make "b" const.
 127         (block_depth): Make "block" const.
 128         * d-exp.y (%union) <bval>: Remove.
 129         * cp-support.h (cp_lookup_rtti_type): Update.
 130         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 131         * psymtab.c (psym_lookup_symbol): Make "block" const.
 132         (maintenance_check_psymtabs): Make "b" const.
 133         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 134         (enumerate_locals, enumerate_args): Update.
 135         * python/py-symtab.c (stpy_global_block): Make "block" const.
 136         (stpy_static_block): Likewise.
 137         * inline-frame.c (block_starting_point_at): Make "new_block"
 138         const.
 139         * block.c (find_block_in_blockvector): Make return type const.
 140         (blockvector_for_pc_sect): Make "b" const.
 141         (find_block_in_blockvector): Make "b" const.
 142
 143 2019-03-23  Tom Tromey  <tom@tromey.com>
 144
 145         * varobj.c (varobj_create): Update.
 146         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 147         * printcmd.c (display_command, do_one_display): Don't reset
 148         innermost_block.
 149         * parser-defs.h (enum innermost_block_tracker_type): Move to
 150         expression.h.
 151         (innermost_block): Update comment.
 152         * parse.c (parse_exp_1): Add tracker_types parameter.
 153         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 154         tracker_types parameter.  Reset innermost_block.
 155         (parse_exp_in_context): Remove.
 156         (parse_expression_for_completion): Update.
 157         * objfiles.c (~objfile): Don't reset expression_context_block or
 158         innermost_block.
 159         * expression.h (enum innermost_block_tracker_type): Move from
 160         parser-defs.h.
 161         (parse_exp_1): Add tracker_types parameter.
 162         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 163         reset innermost_block.
 164
 165 2019-03-23  Tom Tromey  <tom@tromey.com>
 166
 167         * objfiles.h: Include bcache.h.
 168
 169 2019-03-23  Tom Tromey  <tom@tromey.com>
 170
 171         * linespec.c (get_current_search_block): Use
 172         scoped_restore_current_language.
 173         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 174
 175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 176             Jiong Wang  <jiong.wang@arm.com>
 177
 178         * aarch64-linux-tdep.c
 179         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 180         section.
 181         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 182
 183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 184             Jiong Wang  <jiong.wang@arm.com>
 185
 186         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 187         instructions.
 188         (aarch64_analyze_prologue_test): Add PACIASP test.
 189         (aarch64_prologue_prev_register): Unmask PC value.
 190
 191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 192             Jiong Wang  <jiong.wang@arm.com>
 193
 194         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 195         (aarch64_dwarf2_prev_register): Unmask PC value.
 196         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 197         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 198         DW_CFA_AARCH64_negate_ra_state.
 199         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 200
 201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 202             Jiong Wang  <jiong.wang@arm.com>
 203
 204         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 205         registers.
 206         (aarch64_pseudo_register_name): Likewise.
 207         (aarch64_pseudo_register_type): Likewise.
 208         (aarch64_pseudo_register_reggroup_p): Likewise.
 209         (aarch64_gdbarch_init): Add pauth registers.
 210         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 211         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 212         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 213         (struct gdbarch_tdep): Add regnum for ra_state.
 214
 215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 216             Jiong Wang  <jiong.wang@arm.com>
 217
 218         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 219
 220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 221             Jiong Wang  <jiong.wang@arm.com>
 222
 223         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 224         function.
 225         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 226         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 227         (aarch64_gdbarch_init): Add puth registers.
 228         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 229         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 230         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 231
 232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 233             Jiong Wang  <jiong.wang@arm.com>
 234
 235         * aarch64-linux-nat.c
 236         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 237         * aarch64-linux-tdep.c
 238         (aarch64_linux_core_read_description): Likewise.
 239         (aarch64_linux_get_hwcap): New function.
 240         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 241         (aarch64_linux_get_hwcap): New declaration.
 242
 243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 244             Jiong Wang  <jiong.wang@arm.com>
 245
 246         * aarch64-linux-nat.c
 247         (aarch64_linux_nat_target::read_description): Add pauth param.
 248         * aarch64-linux-tdep.c
 249         (aarch64_linux_core_read_description): Likewise.
 250         * aarch64-tdep.c (struct target_desc): Add in pauth.
 251         (aarch64_read_description): Add pauth param.
 252         (aarch64_gdbarch_init): Likewise.
 253         * aarch64-tdep.h (aarch64_read_description): Likewise.
 254         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 255         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 256         * features/Makefile: Add new files.
 257         * features/aarch64-pauth.c: New file.
 258         * features/aarch64-pauth.xml: New file.
 259
 260 2019-03-20  Tom Tromey  <tromey@adacore.com>
 261
 262         * infrun.c (handle_inferior_event): Rename from
 263         handle_inferior_event_1.  Create a scoped_value_mark.
 264         (handle_inferior_event): Remove.
 265
 266 2019-03-19  Tom Tromey  <tromey@adacore.com>
 267
 268         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 269         * infrun.h (print_stop_event): Add "displays" parameter.
 270         * infrun.c (print_stop_event): Add "displays" parameter.
 271
 272 2019-03-19  Pedro Alves  <palves@redhat.com>
 273
 274         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 275         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 276         to -1.  Fix TABs vs spaces.
 277         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 278         * tui/tui-out.h (tui_ui_out) Add intro comments.
 279         <m_line, m_start_of_line>: In-class initialize, and add describing
 280         comment.
 281
 282 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 283
 284         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 285         variable names.
 286         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 287
 288 2019-03-18  Pedro Alves  <palves@redhat.com>
 289             Eli Zaretskii <eliz@gnu.org>
 290
 291         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 292         m_line and m_start_of_line.
 293
 294 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 295
 296         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 297         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 298         it returns a newline.  This fixes a regression in TU mode, whereby
 299         the next line is output on the same screen line as the user input.
 300
 301 2019-03-18  Tom Tromey  <tromey@adacore.com>
 302
 303         * minsyms.c (minimal_symbol_reader::install): Remove call to
 304         obstack_blank.
 305
 306 2019-03-18  Pedro Alves  <palves@redhat.com>
 307
 308         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 309         New globals.
 310         (apply_style): New, factored out from ...
 311         (apply_ansi_escape): ... this.  Handle reverse video mode.
 312         (tui_set_reverse_mode): New function.
 313         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 314         * tui/tui-winsource.c (tui_show_source_line): Use
 315         tui_set_reverse_mode instead of setting A_STANDOUT.
 316         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 317         New setter methods.
 318
 319 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 320
 321         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 322         Handle tabs.
 323
 324 2019-03-18  Tom Tromey  <tromey@adacore.com>
 325
 326         * ada-lang.c (empty_array): Add "high" parameter.
 327         (ada_evaluate_subexp): Update.
 328
 329 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 330
 331         * unittests/string_view-selftests.c: Define
 332         _initialize_string_view_selftests unconditionally.
 333
 334 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 335
 336         PR gdb/24350
 337         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 338
 339 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 340
 341         PR gdb/24351
 342         * windows-nat.c (display_selector): Fix format specifiers.
 343
 344 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 345
 346         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 347         tui_refill_source_window instead of tui_refresh_win, to update the
 348         current execution line.  This fixes redisplay of the current line
 349         when stepping through the code with "next" or "step".
 350
 351 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 352
 353         * source-cache.c (source_cache::get_source_lines): Call
 354         find_source_lines to initialize s->nlines.  This fixes vertical
 355         scrolling of TUI source window when the DOWN arrow is pressed.
 356
 357 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 358
 359         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 360         linux-thread-db.c (_initialize_thread_db): Likewise.
 361
 362 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 363
 364         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 365         wclrtoeol in tui_show_source_line".  This reverts changes made in
 366         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 367
 368 2019-03-15  Tom Tromey  <tom@tromey.com>
 369
 370         * symtab.h (struct minimal_symbol): Derive from
 371         general_symbol_info.
 372         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 373         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 374         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 375         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 376         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 377         (MSYMBOL_SEARCH_NAME): Update.
 378         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 379         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 380         * minsyms.c (minimal_symbol_reader::record_full): Update.
 381
 382 2019-03-15  Tom Tromey  <tom@tromey.com>
 383
 384         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 385
 386 2019-03-15  Tom Tromey  <tom@tromey.com>
 387
 388         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 389         unique_xmalloc_ptr.
 390         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 391         Update.
 392         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 393         (build_minimal_symbol_hash_tables)
 394         (minimal_symbol_reader::install): Update.
 395
 396 2019-03-15  Tom Tromey  <tom@tromey.com>
 397
 398         * symtab.c (create_demangled_names_hash): Update.
 399         (symbol_set_names): Update.
 400         * objfiles.h (struct objfile_per_bfd_storage)
 401         <demangled_names_hash>: Now an htab_up.
 402         * objfiles.c (objfile_per_bfd_storage): Simplify.
 403
 404 2019-03-15  Tom Tromey  <tom@tromey.com>
 405
 406         * objfiles.h (struct objfile_per_bfd_storage): Declare
 407         destructor.
 408         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 409         New.
 410         (get_objfile_bfd_data): Use new.  Don't initialize
 411         language_of_main.
 412         (free_objfile_per_bfd_storage): Remove.
 413         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 414
 415 2019-03-15  Tom Tromey  <tom@tromey.com>
 416
 417         * symfile.c (reread_symbols): Update.
 418         * objfiles.c (objfile::objfile): Update.
 419         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 420         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 421         comment.
 422         (minimal_symbol_reader::install): Update.
 423         (terminate_minimal_symbol_table): Remove.
 424         * jit.c (jit_object_close_impl): Update.
 425
 426 2019-03-15  Tom Tromey  <tom@tromey.com>
 427
 428         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 429         initializations.
 430
 431 2019-03-15  Tom Tromey  <tom@tromey.com>
 432
 433         * objfiles.h (struct objfile_per_bfd_storage)
 434         <demangled_hash_languages>: Now a bitset.
 435         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 436         (lookup_minimal_symbol): Update.
 437
 438 2019-03-15  Tom Tromey  <tom@tromey.com>
 439
 440         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 441         Don't return the symbol.
 442         * coffread.c (record_minimal_symbol): Use record_full.
 443
 444 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 445
 446         The MS-Windows port of ncurses fails to switch to a color pair if
 447         one or both of the colors are the implicit default colors.  This
 448         change records the default colors when TUI is initialized, and
 449         then specifies them explicitly when a color pair uses the default
 450         colors.  This allows color styling in TUI mode on MS-Windows.
 451
 452         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 453         ncurses_norm_attr.
 454         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 455         colors in ncurses_norm_attr.
 456         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 457         "none", replace it with the default color recorded in
 458         ncurses_norm_attr.
 459
 460 2019-03-14  Tom Tromey  <tromey@adacore.com>
 461
 462         * source-cache.h (class source_cache) <get_source_lines>: Return
 463         std::string.
 464         * source-cache.c (source_cache::extract_lines): Handle case where
 465         first_pos==npos.  Return std::string.
 466         (source_cache::get_source_lines): Update.
 467
 468 2019-03-14  Tom Tromey  <tromey@adacore.com>
 469
 470         * NEWS: Add item for "style sources" commands.
 471         * source-cache.c (source_cache::get_source_lines): Check
 472         source_styling.
 473         * cli/cli-style.c (source_styling): New global.
 474         (_initialize_cli_style): Add "style sources" commands.
 475         (show_style_sources): New function.
 476         * cli/cli-style.h (source_styling): Declare.
 477
 478 2019-03-14  Pedro Alves  <palves@redhat.com>
 479             Tom Tromey  <tromey@adacore.com>
 480
 481         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 482         * tui/tui-winsource.c (tui_refill_source_window): New function,
 483         from...
 484         (tui_horizontal_source_scroll): ... here.  Move some logic.
 485         * cli/cli-style.c (set_style_enabled): Notify new observable.
 486         * tui/tui-hooks.c (tui_redisplay_source): New function.
 487         (tui_attach_detach_observers): Attach or detach
 488         tui_redisplay_source.
 489         * observable.h (source_styling_changed): New observable.
 490         * observable.c: Define source_styling_changed observable.
 491
 492 2019-03-13  Tom Tromey  <tromey@adacore.com>
 493
 494         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 495         (i386_gnu_nat_target::store_registers): Update.
 496         * target-debug.h (target_debug_print_std_string): New macro.
 497         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 498         * windows-tdep.c (display_one_tib): Update.
 499         * tui/tui-stack.c (tui_make_status_line): Update.
 500         * top.c (print_inferior_quit_action): Update.
 501         * thread.c (thr_try_catch_cmd): Update.
 502         (add_thread_with_info): Update.
 503         (thread_target_id_str): Update.
 504         (thr_try_catch_cmd): Update.
 505         (thread_command): Update.
 506         (thread_find_command): Update.
 507         * record-btrace.c (record_btrace_target::info_record)
 508         (record_btrace_resume_thread, record_btrace_target::resume)
 509         (record_btrace_cancel_resume, record_btrace_step_thread)
 510         (record_btrace_target::wait, record_btrace_target::wait)
 511         (record_btrace_target::wait, record_btrace_target::stop): Update.
 512         * progspace.c (print_program_space): Update.
 513         * process-stratum-target.c
 514         (process_stratum_target::thread_address_space): Update.
 515         * linux-fork.c (linux_fork_mourn_inferior)
 516         (detach_checkpoint_command, info_checkpoints_command)
 517         (linux_fork_context): Update.
 518         (linux_fork_detach): Update.
 519         (class scoped_switch_fork_info): Update.
 520         (delete_checkpoint_command): Update.
 521         * infrun.c (follow_fork_inferior): Update.
 522         (follow_fork_inferior): Update.
 523         (proceed_after_vfork_done): Update.
 524         (handle_vfork_child_exec_or_exit): Update.
 525         (follow_exec): Update.
 526         (displaced_step_prepare_throw): Update.
 527         (displaced_step_restore): Update.
 528         (start_step_over): Update.
 529         (resume_1): Update.
 530         (clear_proceed_status_thread): Update.
 531         (proceed): Update.
 532         (print_target_wait_results): Update.
 533         (do_target_wait): Update.
 534         (context_switch): Update.
 535         (stop_all_threads): Update.
 536         (restart_threads): Update.
 537         (finish_step_over): Update.
 538         (handle_signal_stop): Update.
 539         (switch_back_to_stepped_thread): Update.
 540         (keep_going_pass_signal): Update.
 541         (print_exited_reason): Update.
 542         (normal_stop): Update.
 543         * inferior.c (inferior_pid_to_str): Change return type.
 544         (print_selected_inferior): Update.
 545         (add_inferior): Update.
 546         (detach_inferior): Update.
 547         * dummy-frame.c (fprint_dummy_frames): Update.
 548         * dcache.c (dcache_info_1): Update.
 549         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 550         (btrace_fetch, btrace_clear): Update.
 551         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 552         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 553         type.
 554         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 555         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 556         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 557         * gdbarch.c, gdbarch.h: Rebuild.
 558         * gdbarch.sh (core_pid_to_str): Change return type.
 559         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 560         return type.
 561         (windows_nat_target::pid_to_str): Change return type.
 562         (windows_delete_thread): Update.
 563         (windows_nat_target::attach): Update.
 564         (windows_nat_target::files_info): Update.
 565         * target-delegates.c: Rebuild.
 566         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 567         return type.
 568         (sol_thread_target::pid_to_str): Change return type.
 569         * remote.c (class remote_target) <pid_to_str>: Change return
 570         type.
 571         (remote_target::pid_to_str): Change return type.
 572         (extended_remote_target::attach, remote_target::remote_stop_ns)
 573         (remote_target::remote_notif_remove_queued_reply)
 574         (remote_target::push_stop_reply, remote_target::disable_btrace):
 575         Update.
 576         (extended_remote_target::attach): Update.
 577         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 578         type.
 579         (gdbsim_target::pid_to_str): Change return type.
 580         * ravenscar-thread.c (struct ravenscar_thread_target)
 581         <pid_to_str>: Change return type.
 582         (ravenscar_thread_target::pid_to_str): Change return type.
 583         * procfs.c (class procfs_target) <pid_to_str>: Change return
 584         type.
 585         (procfs_target::pid_to_str): Change return type.
 586         (procfs_target::attach): Update.
 587         (procfs_target::detach): Update.
 588         (procfs_target::fetch_registers): Update.
 589         (procfs_target::store_registers): Update.
 590         (procfs_target::wait): Update.
 591         (procfs_target::files_info): Update.
 592         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 593         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 594         return type.
 595         (nto_procfs_target::pid_to_str): Change return type.
 596         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 597         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 598         return type.
 599         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 600         (exit_lwp): Update.
 601         (attach_proc_task_lwp_callback, get_detach_signal)
 602         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 603         (linux_nat_target::resume, wait_lwp, stop_callback)
 604         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 605         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 606         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 607         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 608         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 609         type.
 610         (inf_ptrace_target::attach): Update.
 611         (inf_ptrace_target::files_info): Update.
 612         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 613         type.
 614         (go32_nat_target::pid_to_str): Change return type.
 615         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 616         (gnu_nat_target::wait): Update.
 617         (gnu_nat_target::wait): Update.
 618         (gnu_nat_target::resume): Update.
 619         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 620         (fbsd_nat_target::wait): Update.
 621         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 622         type.
 623         (darwin_nat_target::attach): Update.
 624         * corelow.c (class core_target) <pid_to_str>: Change return type.
 625         (core_target::pid_to_str): Change return type.
 626         * target.c (normal_pid_to_str): Change return type.
 627         (default_pid_to_str): Likewise.
 628         (target_pid_to_str): Change return type.
 629         (target_translate_tls_address): Update.
 630         (target_announce_detach): Update.
 631         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 632         return type.
 633         (bsd_uthread_target::pid_to_str): Change return type.
 634         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 635         type.
 636         (bsd_kvm_target::pid_to_str): Change return type.
 637         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 638         return type.
 639         (aix_thread_target::pid_to_str): Change return type.
 640         * target.h (struct target_ops) <pid_to_str>: Change return type.
 641         (target_pid_to_str, normal_pid_to_str): Likewise.
 642         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 643         type.
 644         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 645         type.
 646         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 647         return type.
 648         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 649         type.
 650         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 651         type.
 652         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 653         return type.
 654
 655 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 656
 657         * NEWS: Mention that the new default MI version is 3.  Mention
 658         changes to the output of commands and events that deal with
 659         multi-location breakpoints.
 660         * breakpoint.c: Include "mi/mi-out.h".
 661         (print_one_breakpoint): Change output syntax if using MI version
 662         >= 3.
 663         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 664         New.
 665         (mi_multi_location_breakpoint_output_fixed): New.
 666         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 667         (mi_cmd_fix_multi_location_breakpoint_output): New.
 668         (mi_multi_location_breakpoint_output_fixed): New.
 669         * mi/mi-cmds.c (mi_cmds): Register command
 670         -fix-multi-location-breakpoint-output.
 671         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 672         interpreter "mi".
 673
 674 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 675
 676         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 677         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 678         instantiate mi_ui_out based on interpreter name.
 679         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 680         * mi/mi-main.c (mi_load_progress): Likewise.
 681
 682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 683
 684         * NEWS: Combine separate "New targets" sections for 8.3.
 685
 686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 687
 688         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 689         (ppcfbsd_init_abi): Install gdbarch
 690         "fetch_tls_load_module_address" and "get_thread_local_address"
 691         methods.
 692
 693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 694
 695         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 696         (riscv_fbsd_init_abi): Install gdbarch
 697         "fetch_tls_load_module_address" and "get_thread_local_address"
 698         methods.
 699
 700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 701
 702         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 703         (i386fbsd_init_abi): Install gdbarch
 704         "fetch_tls_load_module_address" and "get_thread_local_address"
 705         methods.
 706
 707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 708
 709         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 710         (amd64fbsd_init_abi): Install gdbarch
 711         "fetch_tls_load_module_address" and "get_thread_local_address"
 712         methods.
 713
 714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 715
 716         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 717         (struct fbsd_pspace_data): New type.
 718         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 719         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 720         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 721         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 722         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 723
 724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 725
 726         * gdbtypes.c (lookup_struct_elt): New function.
 727         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 728         * gdbtypes.h (struct struct_elt): New type.
 729         (lookup_struct_elt): New prototype.
 730
 731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 732
 733         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 734         remove disabled code block.
 735
 736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 737
 738         * gdbarch.sh (get_thread_local_address): New method.
 739         * gdbarch.h, gdbarch.c: Regenerate.
 740         * target.c (target_translate_tls_address): Use
 741         gdbarch_get_thread_local_address if present instead of
 742         target::get_thread_local_address.
 743
 744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 745
 746         * target.h (target::get_thread_local_address): Update comment.
 747
 748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 749
 750         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 751         objfile->separate_debug_objfile_backlink if not NULL.
 752
 753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 754
 755         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 756         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 757         (amd64bsd_store_inferior_registers): Likewise.
 758         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 759         Enable segment base registers.
 760         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 761         PT_GETFSBASE and PT_GETGSBASE.
 762         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 763         PT_SETGSBASE.
 764         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 765         segment base registers.
 766         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 767
 768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 769
 770         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 771         Update calls to i386_target_description to add 'segments'
 772         parameter.
 773         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 774         add segment base registers.
 775         * arch/i386.c (i386_create_target_description): Add 'segments'
 776         parameter to enable segment base registers.
 777         * arch/i386.h (i386_create_target_description): Likewise.
 778         * features/i386/32bit-segments.xml: New file.
 779         * features/i386/32bit-segments.c: Generate.
 780         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 781         call to i386_target_description to add 'segments' parameter.
 782         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 783         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 784         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 785         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 786         if feature is present.
 787         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 788         Add 'segments' parameter to call to i386_target_description.
 789         (i386_target_description): Add 'segments' parameter to enable
 790         segment base registers.
 791         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 792         to call to i386_target_description.
 793         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 794         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 795         Define I386_NUM_REGS.
 796         (i386_target_description): Add 'segments' parameter to enable
 797         segment base registers.
 798
 799 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 800
 801         PR/24325
 802         * source-cache.c: #undef open and close, to avoid unresolved
 803         externals during linking.
 804
 805 2019-03-12  Tom Tromey  <tromey@adacore.com>
 806
 807         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 808         const.  Add initializers.
 809         (_initialize_remote): Don't initialize ptid globals.
 810
 811 2019-03-12  Pedro Alves  <palves@redhat.com>
 812
 813         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 814
 815 2019-03-12  Pedro Alves  <palves@redhat.com>
 816
 817         * cp-name-parser.y (main): Remove unused 'len' variable.
 818
 819 2019-03-12  Tom Tromey  <tromey@adacore.com>
 820
 821         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 822         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 823
 824 2019-03-12  Tom Tromey  <tromey@adacore.com>
 825
 826         * linux-nat.c (iterate_over_lwps): Update.
 827         (stop_callback): Remove parameter.
 828         (stop_wait_callback, detach_callback, resume_set_callback)
 829         (select_singlestep_lwp_callback, set_ignore_sigint)
 830         (status_callback, resumed_callback, resume_clear_callback)
 831         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 832         data parameter.
 833         (linux_nat_target::detach, linux_nat_target::resume)
 834         (linux_stop_and_wait_all_lwps, select_event_lwp)
 835         (linux_nat_filter_event, linux_nat_wait_1)
 836         (linux_nat_target::kill, linux_nat_target::stop)
 837         (linux_nat_target::stop): Update.
 838         (linux_nat_resume_callback): Change type.
 839         (resume_stopped_resumed_lwps, count_events_callback)
 840         (select_event_lwp_callback): Likewise.
 841         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 842         * arm-linux-nat.c (struct update_registers_data): Remove.
 843         (update_registers_callback): Change type.
 844         (arm_linux_insert_hw_breakpoint1): Update.
 845         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 846         parameter.
 847         (x86_linux_dr_set_addr): Update.
 848         (x86_linux_dr_set_control): Update.
 849         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 850         (iterate_over_lwps): Use gdb::function_view.
 851         * nat/aarch64-linux-hw-point.c (struct
 852         aarch64_dr_update_callback_param): Remove.
 853         (debug_reg_change_callback): Change type.
 854         (aarch64_notify_debug_reg_change): Update.
 855         * s390-linux-nat.c (s390_refresh_per_info): Update.
 856
 857 2019-03-11  Tom Tromey  <tromey@adacore.com>
 858
 859         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 860         redundant assignment to "this_cu".
 861
 862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 863
 864         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 865
 866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 867
 868         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 869         from...
 870         (rank_one_type): ... this.
 871
 872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 873
 874         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 875         from...
 876         (rank_one_type): ... this.
 877
 878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 879
 880         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 881         from...
 882         (rank_one_type): ... this.
 883
 884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 885
 886         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 887         from...
 888         (rank_one_type): ... this.
 889
 890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 891
 892         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 893         from...
 894         (rank_one_type): ... this.
 895
 896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 897
 898         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 899         from...
 900         (rank_one_type): ... this.
 901
 902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 903
 904         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 905         from...
 906         (rank_one_type): ... this.
 907
 908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 909
 910         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 911         from...
 912         (rank_one_type): ... this.
 913
 914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 915
 916         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 917         from...
 918         (rank_one_type): ... this.
 919
 920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 921
 922         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 923         from...
 924         (rank_one_type): ... this.
 925
 926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 927
 928         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 929         from...
 930         (rank_one_type): ... this.
 931
 932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 933
 934         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 935         from...
 936         (rank_one_type): ... this.
 937
 938 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 939
 940         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 941         inferior-events' shows the example events.
 942
 943 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 944
 945         Support styling on native MS-Windows console
 946
 947         PR/24315
 948         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 949         on MS-Windows if $TERM is not defined.
 950
 951         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 952
 953         * posix-hdep.c (gdb_console_fputs):
 954         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 955         functions.
 956         * ui-file.h (gdb_console_fputs): Add prototype.
 957
 958         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 959         back to fputs only if the former returns zero.
 960
 961 2019-03-07  Tom Tromey  <tom@tromey.com>
 962
 963         * symmisc.c (print_symbol_bcache_statistics): Update.
 964         (print_objfile_statistics): Update.
 965         * symfile.c (allocate_symtab): Update.
 966         * stabsread.c: Don't include bcache.h.
 967         * psymtab.h (struct psymbol_bcache): Don't declare.
 968         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 969         (psymbol_bcache_init, psymbol_bcache_free)
 970         (psymbol_bcache_get_bcache): Don't declare.
 971         * psymtab.c (struct psymbol_bcache): Remove.
 972         (psymtab_storage::psymtab_storage): Update.
 973         (psymtab_storage::~psymtab_storage): Update.
 974         (psymbol_bcache_init, psymbol_bcache_free)
 975         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 976         (add_psymbol_to_bcache): Update.
 977         (allocate_psymtab): Update.
 978         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 979         macro_cache>: No longer pointers.
 980         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 981         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 982         * macrotab.c (macro_bcache): Update.
 983         * macroexp.c: Don't include bcache.h.
 984         * gdbtypes.c (check_types_worklist): Update.
 985         (types_deeply_equal): Remove TRY/CATCH.  Update.
 986         * elfread.c (elf_symtab_read): Update.
 987         * dwarf2read.c: Don't include bcache.h.
 988         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 989         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 990         (print_bcache_statistics, bcache_memory_used): Don't declare.
 991         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 992         methods.  Rename all data members.
 993         * bcache.c (struct bcache): Move to bcache.h.
 994         (bcache::expand_hash_table): Rename from expand_hash_table.
 995         (bcache): Remove.
 996         (bcache::insert): Rename from bcache_full.
 997         (bcache::compare): Rename from bcache_compare.
 998         (bcache_xmalloc): Remove.
 999         (bcache::~bcache): Rename from bcache_xfree.
1000         (bcache::print_statistics): Rename from print_bcache_statistics.
1001         (bcache::memory_used): Rename from bcache_memory_used.
1002
1003 2019-03-07  Pedro Alves  <palves@redhat.com>
1004
1005         * infrun.c (normal_stop): Also check for
1006         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1007
1008 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * f-lang.c (value_from_host_double): Moved to...
1011         * value.c (value_from_host_double): ...here.
1012         * value.h (value_from_host_double): Declare.
1013         * guile/scm-math.c (vlscm_convert_typed_number): Use
1014         value_from_host_double.
1015         (vlscm_convert_number): Likewise.
1016         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1017         * python/py-value.c (convert_value_from_python): Likewise.
1018
1019 2019-03-06  Tom Tromey  <tom@tromey.com>
1020
1021         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1022
1023 2019-03-06  Tom Tromey  <tom@tromey.com>
1024
1025         * utils.h (free_current_contents): Don't declare.
1026         * utils.c (free_current_contents): Remove.
1027
1028 2019-03-06  Tom Tromey  <tom@tromey.com>
1029
1030         * top.c (quit_force): Update.
1031         * main.c (captured_command_loop): Update.
1032         * common/new-op.c (operator new): Update.
1033         * common/common-exceptions.c (struct catcher)
1034         <save_cleanup_chain>: Remove member.
1035         (exceptions_state_mc_init): Update.
1036         (exception_try_scope_entry): Return nullptr.
1037         (exception_try_scope_exit, exception_rethrow)
1038         (throw_exception_sjlj, throw_exception_cxx): Update.
1039         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1040         (all_cleanups, do_cleanups, discard_cleanups)
1041         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1042         (restore_cleanups, restore_final_cleanups): Don't declare.
1043         (do_final_cleanups): Remove parameter.
1044         * common/cleanups.c (cleanup_chain, make_cleanup)
1045         (make_cleanup_dtor, all_cleanups, do_cleanups)
1046         (discard_my_cleanups, discard_cleanups)
1047         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1048         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1049         (null_cleanup): Remove.
1050         (do_final_cleanups): Remove parameter.
1051
1052 2019-03-06  Tom Tromey  <tom@tromey.com>
1053
1054         * remote.c (remote_target::remote_parse_stop_reply): Use
1055         unique_xmalloc_ptr.
1056
1057 2019-03-06  Tom Tromey  <tom@tromey.com>
1058
1059         * stabsread.c (struct stabs_field_info): Rename from field_info.
1060         <list, fnlist>: Add initializers.
1061         <obstack>: New member.
1062         (read_member_functions, read_struct_fields, read_baseclasses):
1063         Allocate on obstack.  Don't use cleanups.
1064         (read_one_struct_field, read_member_functions, read_struct_fields)
1065         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1066         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1067         (read_struct_type): Update.
1068
1069 2019-03-06  Tom Tromey  <tom@tromey.com>
1070
1071         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1072         * common/filestuff.h (make_cleanup_close): Don't declare.
1073         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1074         Remove.
1075
1076 2019-03-06  Tom Tromey  <tom@tromey.com>
1077
1078         * solib-aix.c: Use make_scope_exit.
1079
1080 2019-03-06  Tom Tromey  <tom@tromey.com>
1081
1082         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1083         Use make_scope_exit.
1084
1085 2019-03-06  Tom Tromey  <tom@tromey.com>
1086
1087         * solib-svr4.c (disable_probes_interface): Remove parameter.
1088         (svr4_handle_solib_event): Use make_scope_exit.
1089
1090 2019-03-06  Tom Tromey  <tom@tromey.com>
1091
1092         * remote.c (struct stop_reply_deleter): Remove.
1093         (stop_reply_up): Update.
1094         (struct stop_reply): Derive from notif_event.  Don't typedef.
1095         <regcache>: Now a std::vector.
1096         (stop_reply_xfree): Remove.
1097         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1098         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1099         (remote_target::discard_pending_stop_replies): Use delete.
1100         (remote_target::remote_parse_stop_reply): Update.
1101         (remote_target::process_stop_reply): Update.
1102         * remote-notif.h (struct notif_event): Add virtual destructor.
1103         Remove "dtr" member.
1104         (struct notif_client) <alloc_event>: Return a unique_ptr.
1105         (notif_event_xfree): Don't declare.
1106         (notif_event_up): New typedef.
1107         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1108         (notif_event_xfree, do_notif_event_xfree): Remove.
1109         (remote_notif_state_xfree): Update.
1110
1111 2019-03-06  Tom Tromey  <tom@tromey.com>
1112
1113         * infrun.c (displaced_step_clear_cleanup): Now a
1114         forward_scope_exit type.
1115         (displaced_step_prepare_throw): Update.
1116         (displaced_step_fixup): Update.
1117
1118 2019-03-06  Tom Tromey  <tom@tromey.com>
1119
1120         * inferior.h (class inferior): Update comment.
1121         * gdbthread.h (class thread_info): Update comment.
1122
1123 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1124             Tom Tromey  <tom@tromey.com>
1125
1126         * stabsread.h (struct stab_section_list): Remove.
1127         (coffstab_build_psymtabs): Update.
1128         * dbxread.c (symbuf_sections): Now a std::vector.
1129         (sect_idx): New global.
1130         (fill_symbuf): Update.
1131         (coffstab_build_psymtabs): Change type of stabsects parameter.
1132         Update.
1133         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1134         std::vector.
1135         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1136         (coff_locate_sections): Update.
1137         (coff_symfile_read): Remove cleanups.  Update.
1138         (init_stringtab): Add storage parameter.
1139         (free_stringtab, free_stringtab_cleanup): Remove.
1140         (init_lineno): Add storage parameter.
1141         (free_linetab, free_linetab_cleanup): Remove.
1142
1143 2019-03-06  Pedro Alves  <palves@redhat.com>
1144
1145         * linux-fork.c (fork_info::clobber_regs): Delete.
1146         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1147         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1148         comment.  Adjust.
1149         (scoped_switch_fork_info::scoped_switch_fork_info)
1150         (checkpoint_command, linux_fork_context): Adjust
1151         fork_save_infrun_state calls.
1152
1153 2019-03-06  Pedro Alves  <palves@redhat.com>
1154
1155         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1156         (inf_has_multiple_threads): Return 'bool' and rewrite using
1157         inferior_info::threads().
1158
1159 2019-03-06  Pedro Alves  <palves@redhat.com>
1160
1161         * linux-fork.c: Include <list>.
1162         (fork_list): Now a std::list instance.
1163         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1164         (forks_exist_p, find_last_fork): Adjust.
1165         (new_fork): Delete.
1166         (one_fork_p): New.
1167         (add_fork): Adjust.
1168         (free_fork): Delete, folded into fork_info::~fork_info().
1169         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1170         Adjust.
1171         (init_fork_list): Delete.
1172         (linux_fork_killall, linux_fork_mourn_inferior)
1173         (linux_fork_detach, info_checkpoints_command): Adjust.
1174         (_initialize_linux_fork): No longer call init_fork_list.
1175
1176 2019-03-06  Pedro Alves  <palves@redhat.com>
1177
1178         * linux-fork.c (new_fork): New, split out of ...
1179         (add_fork): ... this.  Return void.  Move "first fork" special
1180         case from here, to ...
1181         (checkpoint_command): ... here.
1182         * linux-linux.h (add_fork): Return void.
1183
1184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1187
1188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1189             Chris January  <chris.january@arm.com>
1190             David Lecomber  <david.lecomber@arm.com>
1191
1192         * f-exp.y: New token, UNOP_INTRINSIC.
1193         (exp): New pattern using UNOP_INTRINSIC token.
1194         (f77_keywords): Add 'abs' keyword.
1195         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1196         (value_from_host_double): New function.
1197         (evaluate_subexp_f): Support UNOP_ABS.
1198
1199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1200
1201         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1202         types.
1203
1204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1207         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1208         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1209
1210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1213
1214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1215             Chris January  <chris.january@arm.com>
1216
1217         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1218         * f-exp.y: Define 'KIND' token.
1219         (exp): New pattern for KIND expressions.
1220         (ptype): Handle types with a kind extension.
1221         (direct_abs_decl): Extend to spot kind extensions.
1222         (f77_keywords): Add 'kind' to the list.
1223         (push_kind_type): New function.
1224         (convert_to_kind_type): New function.
1225         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1226         * parse.c (operator_length_standard): Likewise.
1227         * parser-defs.h (enum type_pieces): Add tp_kind.
1228         * std-operator.def: Add UNOP_KIND.
1229
1230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * f-exp.y (f_parse): Set yydebug.
1233
1234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * f-lang.c (evaluate_subexp_f): New function.
1237         (exp_descriptor_f): New global.
1238         (f_language_defn): Use exp_descriptor_f instead of
1239         exp_descriptor_standard.
1240
1241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * f-exp.y (struct token): Add comments.
1244         (dot_ops): Remove uppercase versions and the end marker.
1245         (f77_keywords): Likewise.
1246         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1247         entries in the dot_ops array are case insensitive, and use
1248         strncasecmp to compare strings.  Also some whitespace cleanup in
1249         this area.  Similar for the f77_keywords array, except entries in
1250         this list might be case sensitive.
1251
1252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * f-exp.y (struct f77_boolean_val): Add comments.
1255         (boolean_values): Remove uppercase versions, and end marker.
1256         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1257         and use strncasecmp to achieve case insensitivity.  Additionally,
1258         perform whitespace cleanup around this code.
1259
1260 2019-03-06  Tom Tromey  <tromey@adacore.com>
1261
1262         * remote-sim.c (gdbsim_target_open): Use result of
1263         gdb_argv::release.
1264
1265 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1266         Dirk Schubert  <dirk.schubert@arm.com>
1267         Chris January  <chris.january@arm.com>
1268
1269         * eval.c (evaluate_subexp_standard): Call Fortran argument
1270         wrapping logic.
1271         * f-lang.c (struct value): A value which can be passed into a
1272         Fortran function call.
1273         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1274         where appropriate.
1275         (struct type): Value ready for a Fortran function call.
1276         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1277         is needed.
1278         * f-lang.h (fortran_argument_convert): Declaration.
1279         (fortran_preserve_arg_pointer): Declaration.
1280         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1281
1282 2019-03-05  Tom Tromey  <tromey@adacore.com>
1283
1284         * python/py-prettyprint.c (print_string_repr): Remove #if.
1285         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1286
1287 2019-03-05  Tom Tromey  <tromey@adacore.com>
1288
1289         * target.c (the_dummy_target): Move later.  Change type to
1290         "dummy_target".
1291         (initialize_targets): Don't initialize the_dummy_target.
1292
1293 2019-03-05  Tom Tromey  <tromey@adacore.com>
1294
1295         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1296         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1297
1298 2019-03-05  Tom Tromey  <tromey@adacore.com>
1299
1300         * windows-nat.c (windows_nat_target::attach)
1301         (windows_nat_target::detach): Don't call gdb_flush.
1302         * valprint.c (generic_val_print, val_print, val_print_string):
1303         Don't call gdb_flush.
1304         * utils.c (defaulted_query): Don't call gdb_flush.
1305         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1306         * target.c (target_announce_detach): Don't call gdb_flush.
1307         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1308         * remote.c (extended_remote_target::attach): Don't call
1309         gdb_flush.
1310         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1311         * printcmd.c (do_examine): Don't call gdb_flush.
1312         (info_display_command): Don't call gdb_flush.
1313         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1314         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1315         * memattr.c (info_mem_command): Don't call gdb_flush.
1316         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1317         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1318         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1319         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1320         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1321         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1322         (gnu_nat_target::detach): Don't call gdb_flush.
1323         * f-valprint.c (f_val_print): Don't call gdb_flush.
1324         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1325         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1326         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1327         gdb_flush.
1328         * c-valprint.c (c_val_print): Don't call gdb_flush.
1329         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1330
1331 2019-03-05  Tom Tromey  <tromey@adacore.com>
1332
1333         * varobj.c (update_dynamic_varobj_children): Update.
1334         (install_default_visualizer): Use reset, not release.
1335         * value.c (set_internalvar): Update.
1336         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1337         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1338         ATTRIBUTE_UNUSED_RESULT.
1339
1340 2019-03-05  Tom Tromey  <tromey@adacore.com>
1341
1342         * remote.c (class scoped_remote_fd) <release>: Add
1343         ATTRIBUTE_UNUSED_RESULT.
1344
1345 2019-03-05  Tom Tromey  <tromey@adacore.com>
1346
1347         * macroexp.c (struct macro_buffer) <release>: Add
1348         ATTRIBUTE_UNUSED_RESULT.
1349
1350 2019-03-05  Tom Tromey  <tromey@adacore.com>
1351
1352         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1353         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1354         ATTRIBUTE_UNUSED_RESULT.
1355
1356 2019-03-05  Tom Tromey  <tromey@adacore.com>
1357
1358         * common/scoped_fd.h (class scoped_fd) <release>: Add
1359         ATTRIBUTE_UNUSED_RESULT.
1360
1361 2019-03-05  Tom Tromey  <tromey@adacore.com>
1362
1363         * parser-defs.h (struct parser_state) <release>: Add
1364         ATTRIBUTE_UNUSED_RESULT.
1365
1366 2019-03-05  Tom Tromey  <tromey@adacore.com>
1367
1368         * utils.h (class gdb_argv) <release>: Add
1369         ATTRIBUTE_UNUSED_RESULT.
1370         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1371
1372 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1373
1374         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1375         for-loop range, to avoid compiler warnings.
1376
1377         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1378         avoid compiler warnings about unused variables.
1379
1380         * NEWS: Mention end of support for native debugging on MS-Windows
1381         before XP.
1382
1383         PR gdb/24292
1384         * common/netstuff.c:
1385         * gdbserver/gdbreplay.c
1386         * gdbserver/remote-utils.c:
1387         * ser-tcp.c:
1388         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1389         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1390         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1391         'getaddrinfo' and 'freeaddrinfo' were not available before
1392         Windows XP, and mingw.org's MinGW headers by default define
1393         _WIN32_WINNT to 0x500.
1394
1395 2019-03-01  Gary Benson <gbenson@redhat.com>
1396
1397         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1398
1399 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1400             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1401
1402         PR gdb/8527
1403         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1404         set_sigint_trap, clear_sigint_trap.
1405
1406 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1407
1408         * target.c (target_detach): Clear the regcache and the
1409         frame cache.
1410
1411 2019-02-27  Pedro Alves  <palves@redhat.com>
1412
1413         * utils.c (set_screen_size): When we cap the height/width sizes,
1414         tweak the corresponding command variable to show "unlimited":
1415
1416 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1417             Pedro Alves  <palves@redhat.com>
1418
1419         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1420         before calling rl_set_screen_size.
1421
1422 2019-02-27  Tom Tromey  <tromey@adacore.com>
1423
1424         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1425         define.
1426         * python/py-value.c: Remove Python 2.4 workaround.
1427         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1428         workaround.
1429         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1430         Python 2.4 workaround.
1431         * python/python-internal.h: Remove Python 2.4 comment.
1432         (Py_ssize_t): Don't define.
1433         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1434         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1435         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1436         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1437         * python/python.c (do_start_initialization): Remove Python 2.4
1438         workaround.
1439         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1440         (print_children): Remove Python 2.4 workaround.
1441         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1442         workaround.
1443         (CHARBUFFERPROC_NAME): Remove.
1444         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1445         Python 2.4 workaround.
1446
1447 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1448
1449         * NEWS: Note minimum Python version.
1450
1451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1452
1453         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1454         code from these functions.  Remove corresponding ifdefs.  Use
1455         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1456         Remove gotos and target of gotos.
1457         (infpy_search_memory): Likewise.
1458
1459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1460
1461         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1462         (hppa_gdbarch_init): Don't register deleted functions with
1463         gdbarch.
1464
1465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1468         (h8300_unwind_sp): Delete.
1469         (h8300_dummy_id): Delete.
1470         (h8300_gdbarch_init): Don't register deleted functions with
1471         gdbarch.
1472
1473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1476         (ft32_unwind_pc): Delete.
1477         (ft32_unwind_sp): Delete.
1478         (ft32_gdbarch_init): Don't register deleted functions with
1479         gdbarch.
1480
1481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1484         (frv_unwind_pc): Delete.
1485         (frv_unwind_sp): Delete.
1486         (frv_gdbarch_init): Don't register deleted functions with
1487         gdbarch.
1488
1489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1490
1491         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1492         (riscv_unwind_pc): Delete.
1493         (riscv_unwind_sp): Delete.
1494         (riscv_gdbarch_init): Don't register deleted functions with
1495         gdbarch.
1496
1497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1500         (csky_unwind_pc): Delete.
1501         (csky_unwind_sp): Delete.
1502         (csky_gdbarch_init): Don't register deleted functions with
1503         gdbarch.
1504
1505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1508         (cris_unwind_pc): Delete.
1509         (cris_unwind_sp): Delete.
1510         (cris_gdbarch_init): Don't register deleted functions with
1511         gdbarch.
1512
1513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1516         (bfin_unwind_pc): Delete.
1517         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1518
1519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1522         (arm_unwind_pc): Delete.
1523         (arm_unwind_sp): Delete.
1524         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1525
1526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1529         (arc_unwind_pc): Delete.
1530         (arc_unwind_sp): Delete.
1531         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1532
1533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1536         (alpha_unwind_pc): Delete.
1537         (alpha_gdbarch_init): Don't register deleted functions with
1538         gdbarch.
1539
1540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1543         (aarch64_unwind_pc): Delete.
1544         (aarch64_unwind_sp): Delete.
1545         (aarch64_gdbarch_init): Don't register deleted functions with
1546         gdbarch.
1547
1548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * gdbtypes.c (type_align): Don't consider static members when
1551         computing structure alignment.
1552
1553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1556         return 0 for other types.
1557         * arch-utils.c (default_type_align): Always return 0.
1558         * gdbarch.h: Regenerate.
1559         * gdbarch.sh (type_align): Extend comment.
1560         * gdbtypes.c (type_align): Add additional comments, always call
1561         gdbarch_type_align before applying the default rules.
1562         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1563         generic code will then apply a suitable default.
1564         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1565         types, return 0 for other types.
1566
1567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1568
1569         * NEWS: Create a new section for the next release branch.
1570         Rename the section of the current branch, now that it has
1571         been cut.
1572
1573 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1574
1575         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1576         * version.in: Bump version to 8.3.50.DATE-git.
1577
1578 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1579
1580         * aix-thread.c (ptid_cmp): Remove unused variable.
1581         (get_signaled_thread): Likewise.
1582         (store_regs_user_thread): Likewise.
1583         (store_regs_kernel_thread): Likewise.
1584         (fetch_regs_kernel_thread): Remove shadowed variable.
1585
1586 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1587
1588         * features/riscv/32bit-cpu.xml: Add register numbers.
1589         * features/riscv/32bit-fpu.c: Regenerate.
1590         * features/riscv/32bit-fpu.xml: Add register numbers.
1591         * features/riscv/64bit-cpu.xml: Add register numbers.
1592         * features/riscv/64bit-fpu.c: Regenerate.
1593         * features/riscv/64bit-fpu.xml: Add register numbers.
1594
1595 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1596
1597         * NEWS: Mention two argument form of gdb.Value constructor.
1598         * python/py-value.c (convert_buffer_and_type_to_value): New
1599         function.
1600         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1601         Add support for handling an optional second argument.  Call
1602         convert_buffer_and_type_to_value as appropriate.
1603         * python/python-internal.h (Py_buffer_deleter): New struct.
1604         (Py_buffer_up): New typedef.
1605
1606 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1607
1608         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1609         instead of releasing ownership.
1610
1611 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1612
1613         * dwarf2read.c (open_and_init_dwp_file): Call
1614         elf_numsections instead of bfd_count_sections to initialize
1615         dwp_file->num_sections.
1616
1617 2019-02-25  Tom Tromey  <tromey@adacore.com>
1618
1619         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1620
1621 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1622
1623         * gcore.in: Add '--readnever' option when invoking GDB.
1624
1625 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1626
1627         * MAINTAINERS: Update my email address.
1628
1629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1630
1631         * build-id.c (build_id_to_debug_bfd_1): New function.
1632         (build_id_to_debug_bfd): Look for separate debug file in
1633         sysroot.
1634
1635 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * gdbarch.sh: Update the copyright year range that is placed into
1638         generated files.
1639
1640 2019-02-22  Keith Seitz  <keiths@redhat.com>
1641
1642         PR symtab/23853
1643         * linespec.c (create_sals_line_offset): Search for the default
1644         symtab's filename instead of its fullname.
1645
1646 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * NEWS: Update style defaults.
1649
1650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1651
1652         * main.c (captured_main_1): Disable styling in batch mode.
1653
1654 2019-02-20  Tom Tromey  <tom@tromey.com>
1655
1656         * symtab.c (symtab_symbol_info): Fix typos.
1657
1658 2019-02-20  Tom Tromey  <tromey@adacore.com>
1659
1660         * findcmd.c (_initialize_mem_search): Use upper case for
1661         metasyntactic variables.
1662
1663 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1664
1665         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1666         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1667
1668 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1669
1670         * top.h (source_file_name): Change to std::string.
1671         * top.c (source_file_name): Likewise.
1672         (command_line_input): Adjust.
1673         * cli/cli-script.c (script_from_file): Adjust.
1674
1675 2019-02-19  Tom Tromey  <tromey@adacore.com>
1676
1677         * ravenscar-thread.c
1678         (ravenscar_thread_target::update_thread_list): Don't call
1679         ada_build_task_list.
1680         * ada-lang.h (ada_build_task_list): Don't declare.
1681         * ada-tasks.c (struct ada_tasks_inferior_data)
1682         <task_list_valid_p>: Now bool.
1683         (read_known_tasks, ada_task_list_changed)
1684         (ada_tasks_invalidate_inferior_data): Update.
1685         (read_known_tasks_array): Return bool.
1686         (read_known_tasks_list): Likewise.
1687         (read_known_tasks): Return void.
1688         (ada_build_task_list): Now static.
1689
1690 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1691
1692         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1693         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1694
1695 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1698         variant for ada_tasks_pspace_data_handle and
1699         ada_tasks_inferior_data_handle.
1700         (ada_tasks_pspace_data_cleanup): New function.
1701         (ada_tasks_inferior_data_cleanup): New function.
1702
1703 2019-02-17  Tom Tromey  <tom@tromey.com>
1704
1705         * macrotab.h (macro_source_fullname): Return a std::string.
1706         * macrotab.c (macro_include, check_for_redefinition)
1707         (macro_undef, macro_lookup_definition, foreach_macro)
1708         (foreach_macro_in_scope): Update.
1709         (macro_source_fullname): Return a std::string.
1710         * macrocmd.c (show_pp_source_pos): Update.
1711
1712 2019-02-17  Tom Tromey  <tom@tromey.com>
1713
1714         * macrocmd.c (show_pp_source_pos): Style the file names.
1715
1716 2019-02-17  Tom Tromey  <tom@tromey.com>
1717
1718         PR tui/24197:
1719         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1720
1721 2019-02-17  Tom Tromey  <tom@tromey.com>
1722
1723         * ada-lang.c (user_select_syms): Use filtered printing.
1724         * utils.c (wrap_style): New global.
1725         (desired_style): Remove.
1726         (emit_style_escape): Add stream parameter.
1727         (set_output_style, reset_terminal_style, prompt_for_continue):
1728         Update.
1729         (flush_wrap_buffer): Only flush gdb_stdout.
1730         (wrap_here): Set wrap_style.
1731         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1732         treat escape sequences as a character.  Change when wrap buffer is
1733         flushed.
1734         (fputs_styled): Do not set the output style when the default is
1735         requested.
1736         * ui-style.h (struct ui_file_style) <is_default>: New method.
1737         * source.c (print_source_lines_base): Emit escape sequences in one
1738         piece.
1739
1740 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1741
1742         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1743         integers and enumeration types.
1744
1745 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1746
1747         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1748         instead of lookup_symbol_in_language
1749         (do_exact_match): New function.
1750         (ada_get_symbol_name_matcher): Return do_exact_match when
1751         doing a verbatim match.
1752
1753 2019-02-15  Tom Tromey  <tromey@adacore.com>
1754
1755         * ravenscar-thread.c (ravenscar_thread_target::resume)
1756         (ravenscar_thread_target::wait): Special case wildcard requests.
1757
1758 2019-02-15  Tom Tromey  <tromey@adacore.com>
1759
1760         * ravenscar-thread.c (base_ptid): Remove.
1761         (struct ravenscar_thread_target) <close>: New method.
1762         <m_base_ptid>: New member.
1763         <update_inferior_ptid, active_task, task_is_currently_active,
1764         runtime_initialized>: Declare methods.
1765         <ravenscar_thread_target>: Add constructor.
1766         (ravenscar_thread_target::task_is_currently_active)
1767         (ravenscar_thread_target::update_inferior_ptid)
1768         (ravenscar_runtime_initialized): Rename.  Now methods.
1769         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1770         (ravenscar_thread_target::update_thread_list): Update.
1771         (ravenscar_thread_target::active_task): Now method.
1772         (ravenscar_thread_target::store_registers)
1773         (ravenscar_thread_target::prepare_to_store)
1774         (ravenscar_thread_target::prepare_to_store)
1775         (ravenscar_thread_target::mourn_inferior): Update.
1776         (ravenscar_inferior_created): Use "new" to create target.
1777         (ravenscar_thread_target::get_ada_task_ptid): Update.
1778         (_initialize_ravenscar): Don't initialize base_ptid.
1779         (ravenscar_ops): Remove global.
1780
1781 2019-02-15  Tom Tromey  <tromey@adacore.com>
1782
1783         * target.h (push_target): Declare new overload.
1784         * target.c (push_target): New overload, taking an rvalue reference.
1785         * remote.c (remote_target::open_1): Use push_target overload.
1786         * corelow.c (core_target_open): Use push_target overload.
1787
1788 2019-02-15  Tom Tromey  <tromey@adacore.com>
1789
1790         * ravenscar-thread.c (is_ravenscar_task)
1791         (ravenscar_task_is_currently_active): Return bool.
1792         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1793         (_initialize_ravenscar): Remove "(void)".
1794         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1795         Return bool.
1796
1797 2019-02-15  Tom Tromey  <tromey@adacore.com>
1798
1799         * ravenscar-thread.c (ravenscar_runtime_initializer)
1800         (has_ravenscar_runtime, get_running_thread_id)
1801         (ravenscar_thread_target::resume): Fix indentation.
1802
1803 2019-02-15  Tom Tromey  <tromey@adacore.com>
1804
1805         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1806         from ravenscar_arch_ops.
1807         (sparc_ravenscar_ops::fetch_registers)
1808         (sparc_ravenscar_ops::store_registers): Now methods.
1809         (sparc_ravenscar_prepare_to_store): Remove.
1810         (sparc_ravenscar_ops): Redefine.
1811         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1812         methods and destructor.  Remove members.
1813         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1814         (ravenscar_thread_target::store_registers)
1815         (ravenscar_thread_target::prepare_to_store): Update.
1816         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1817         Remove.
1818         (struct ppc_ravenscar_powerpc_ops): Derive from
1819         ravenscar_arch_ops.
1820         (ppc_ravenscar_powerpc_ops::fetch_registers)
1821         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1822         (ppc_ravenscar_powerpc_ops): Redefine.
1823         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1824         (ppc_ravenscar_e500_ops::fetch_registers)
1825         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1826         (ppc_ravenscar_e500_ops): Redefine.
1827         * aarch64-ravenscar-thread.c
1828         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1829         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1830         (aarch64_ravenscar_fetch_registers)
1831         (aarch64_ravenscar_store_registers): Now methods.
1832         (aarch64_ravenscar_ops): Redefine.
1833
1834 2019-02-15  Tom Tromey  <tromey@adacore.com>
1835
1836         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1837         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1838         (ravenscar_thread_target::stopped_by_watchpoint)
1839         (ravenscar_thread_target::stopped_data_address)
1840         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1841
1842 2019-02-15  Tom Tromey  <tromey@adacore.com>
1843
1844         * ravenscar-thread.c: Fix some typos.
1845
1846 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1847             Tom Tromey  <tromey@adacore.com>
1848
1849         * ada-lang.c (ada_exception_sal): Change addr_string to a
1850         std::string.
1851         (create_ada_exception_catchpoint): Update.
1852
1853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1854             Tom Tromey  <tromey@adacore.com>
1855
1856         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1857         (bp_location_ops): Remove.
1858         (base_breakpoint_allocate_location): Update.
1859         (free_bp_location): Update.
1860         * ada-lang.c (class ada_catchpoint_location)
1861         <ada_catchpoint_location>: Remove ops parameter.
1862         (ada_catchpoint_location_dtor): Remove.
1863         (ada_catchpoint_location_ops): Remove.
1864         (allocate_location_exception): Update.
1865         * breakpoint.h (struct bp_location_ops): Remove.
1866         (class bp_location) <bp_location>: Remove bp_location_ops
1867         parameter.
1868         <~bp_location>: Add destructor.
1869         <ops>: Remove.
1870
1871 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1872             Pedro Alves  <palves@redhat.com>
1873
1874         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1875         'PATH_MAX'.
1876
1877 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1878             Samuel Thibault  <samuel.thibault@gnu.org>
1879             Thomas Schwinge  <thomas@codesourcery.com>
1880
1881         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1882         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1883
1884 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1885
1886         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1887         (check_empty): Use "const char *".
1888
1889         * gnu-nat.c (gnu_nat_target::detach): Instead of
1890         'detach_inferior (pid)' call
1891         'detach_inferior (find_inferior_pid (pid))'.
1892
1893         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1894         'nat/fork-inferior.o'.
1895         * gnu-nat.c: #include "nat/fork-inferior.h".
1896
1897         * gnu-nat.c (gnu_nat_target::detach): Instead of
1898         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1899         * gnu-nat.h: #include "inf-child.h".
1900         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1901         'i386_gnu_nat_target::fetch_registers'.
1902         (gnu_store_registers): Rename/move to
1903         'i386_gnu_nat_target::store_registers'.
1904
1905         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1906         * gnu-nat.h (mach_thread_info): New function.
1907         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1908
1909         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1910
1911 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1912
1913         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1914
1915 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1916
1917         * windows-nat.c (windows_add_thread): Add new parameter
1918         "main_thread_p" with default value set to false.  Update
1919         function documentation as well as all callers.
1920         (windows_delete_thread): Likewise.
1921         (fake_create_process): Update call to windows_add_thread.
1922         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1923         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1924         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1925         call to windows_delete_thread.
1926
1927 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1928
1929         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1930
1931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1932
1933         * symfile.c (find_separate_debug_file): Use canonical path of
1934         sysroot with child_path instead of gdb_sysroot if it is valid.
1935
1936 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1937
1938         * symfile.c (find_separate_debug_file): Use child_path to
1939         determine if an object file is under a sysroot.
1940
1941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1942
1943         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1944         unittests/child-path-selftests.c.
1945         * common/pathstuff.c (child_path): New function.
1946         * common/pathstuff.h (child_path): New prototype.
1947         * unittests/child-path-selftests.c: New file.
1948
1949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1950
1951         * symfile.c (find_separate_debug_file): Look for separate debug
1952         files in debug directories under the sysroot.
1953
1954 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1955
1956         * symtab.h (struct minimal_symbol data_p): New const method.
1957         (struct minimal_symbol text_p): Likewise.
1958         * symtab.c (output_source_filename): Use file name style
1959         to print file name.
1960         (print_symbol_info): Likewise.
1961         (print_msymbol_info): Use address style to print addresses.
1962         Use function name style to print executable text symbols.
1963         (expand_symtab_containing_pc): Use data_p.
1964         (find_pc_sect_compunit_symtab): Likewise.
1965
1966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         * breakpoint.c (describe_other_breakpoints): Use address style
1969         to print addresses.
1970         (say_where): Likewise.
1971
1972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1973
1974         * ada-typeprint.c (print_func_type): Print function name
1975         style to print function name.
1976         * c-typeprint.c (c_print_type_1): Likewise.
1977
1978 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1979
1980         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1981         for execve.
1982
1983 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1984
1985         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1986         type_stack.
1987
1988 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1989
1990         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1991         TYPE_CODE_REF types.
1992
1993 2019-02-08  Jim Wilson  <jimw@sifive.com>
1994
1995         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1996         (riscv_linux_fregset): New.
1997         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1998
1999 2019-02-07  Tom Tromey  <tom@tromey.com>
2000
2001         * thread.c (thread_cancel_execution_command): Update.
2002         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2003         methods.
2004         (struct thread_fsm_ops): Remove.
2005         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2006         (thread_fsm_should_stop, thread_fsm_return_value)
2007         (thread_fsm_set_finished, thread_fsm_finished_p)
2008         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2009         Don't declare.
2010         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2011         * infrun.c (clear_proceed_status_thread)
2012         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2013         (print_stop_event): Update.
2014         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2015         Add constructor.
2016         (step_command_fsm_ops): Remove.
2017         (new_step_command_fsm): Remove.
2018         (step_1): Update.
2019         (step_command_fsm::should_stop): Rename from
2020         step_command_fsm_should_stop.
2021         (step_command_fsm::clean_up): Rename from
2022         step_command_fsm_clean_up.
2023         (step_command_fsm::do_async_reply_reason): Rename from
2024         step_command_fsm_async_reply_reason.
2025         (struct until_next_fsm): Inherit from thread_fsm.  Add
2026         constructor.
2027         (until_next_fsm_ops): Remove.
2028         (new_until_next_fsm): Remove.
2029         (until_next_fsm::should_stop): Rename from
2030         until_next_fsm_should_stop.
2031         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2032         (until_next_fsm::do_async_reply_reason): Rename from
2033         until_next_fsm_async_reply_reason.
2034         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2035         constructor.  Change type of breakpoint.
2036         (finish_command_fsm_ops): Remove.
2037         (new_finish_command_fsm): Remove.
2038         (finish_command_fsm::should_stop): Rename from
2039         finish_command_fsm_should_stop.
2040         (finish_command_fsm::clean_up): Rename from
2041         finish_command_fsm_clean_up.
2042         (finish_command_fsm::return_value): Rename from
2043         finish_command_fsm_return_value.
2044         (finish_command_fsm::do_async_reply_reason): Rename from
2045         finish_command_fsm_async_reply_reason.
2046         (finish_command): Update.
2047         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2048         Add constructor.
2049         (call_thread_fsm_ops): Remove.
2050         (call_thread_fsm::call_thread_fsm): Rename from
2051         new_call_thread_fsm.
2052         (call_thread_fsm::should_stop): Rename from
2053         call_thread_fsm_should_stop.
2054         (call_thread_fsm::should_notify_stop): Rename from
2055         call_thread_fsm_should_notify_stop.
2056         (run_inferior_call, call_function_by_hand_dummy): Update.
2057         * cli/cli-interp.c (should_print_stop_to_console): Update.
2058         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2059         Add constructor.  Change type of location_breakpoint,
2060         caller_breakpoint.
2061         (until_break_fsm_ops): Remove.
2062         (new_until_break_fsm): Remove.
2063         (until_break_fsm::should_stop): Rename from
2064         until_break_fsm_should_stop.
2065         (until_break_fsm::clean_up): Rename from
2066         until_break_fsm_clean_up.
2067         (until_break_fsm::do_async_reply_reason): Rename from
2068         until_break_fsm_async_reply_reason.
2069         (until_break_command): Update.
2070         * thread-fsm.c: Remove.
2071         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2072
2073 2019-02-07  Tom Tromey  <tom@tromey.com>
2074
2075         * yy-remap.h: Add include guard.
2076         * xtensa-tdep.h: Add include guard.
2077         * xcoffread.h: Rename include guard.
2078         * varobj-iter.h: Add include guard.
2079         * tui/tui.h: Rename include guard.
2080         * tui/tui-winsource.h: Rename include guard.
2081         * tui/tui-wingeneral.h: Rename include guard.
2082         * tui/tui-windata.h: Rename include guard.
2083         * tui/tui-win.h: Rename include guard.
2084         * tui/tui-stack.h: Rename include guard.
2085         * tui/tui-source.h: Rename include guard.
2086         * tui/tui-regs.h: Rename include guard.
2087         * tui/tui-out.h: Rename include guard.
2088         * tui/tui-layout.h: Rename include guard.
2089         * tui/tui-io.h: Rename include guard.
2090         * tui/tui-hooks.h: Rename include guard.
2091         * tui/tui-file.h: Rename include guard.
2092         * tui/tui-disasm.h: Rename include guard.
2093         * tui/tui-data.h: Rename include guard.
2094         * tui/tui-command.h: Rename include guard.
2095         * tic6x-tdep.h: Add include guard.
2096         * target/waitstatus.h: Rename include guard.
2097         * target/wait.h: Rename include guard.
2098         * target/target.h: Rename include guard.
2099         * target/resume.h: Rename include guard.
2100         * target-float.h: Rename include guard.
2101         * stabsread.h: Add include guard.
2102         * rs6000-tdep.h: Add include guard.
2103         * riscv-fbsd-tdep.h: Add include guard.
2104         * regformats/regdef.h: Rename include guard.
2105         * record.h: Rename include guard.
2106         * python/python.h: Rename include guard.
2107         * python/python-internal.h: Rename include guard.
2108         * python/py-stopevent.h: Rename include guard.
2109         * python/py-ref.h: Rename include guard.
2110         * python/py-record.h: Rename include guard.
2111         * python/py-record-full.h: Rename include guard.
2112         * python/py-record-btrace.h: Rename include guard.
2113         * python/py-instruction.h: Rename include guard.
2114         * python/py-events.h: Rename include guard.
2115         * python/py-event.h: Rename include guard.
2116         * procfs.h: Add include guard.
2117         * proc-utils.h: Add include guard.
2118         * p-lang.h: Add include guard.
2119         * or1k-tdep.h: Rename include guard.
2120         * observable.h: Rename include guard.
2121         * nto-tdep.h: Rename include guard.
2122         * nat/x86-linux.h: Rename include guard.
2123         * nat/x86-linux-dregs.h: Rename include guard.
2124         * nat/x86-gcc-cpuid.h: Add include guard.
2125         * nat/x86-dregs.h: Rename include guard.
2126         * nat/x86-cpuid.h: Rename include guard.
2127         * nat/ppc-linux.h: Rename include guard.
2128         * nat/mips-linux-watch.h: Rename include guard.
2129         * nat/linux-waitpid.h: Rename include guard.
2130         * nat/linux-ptrace.h: Rename include guard.
2131         * nat/linux-procfs.h: Rename include guard.
2132         * nat/linux-osdata.h: Rename include guard.
2133         * nat/linux-nat.h: Rename include guard.
2134         * nat/linux-namespaces.h: Rename include guard.
2135         * nat/linux-btrace.h: Rename include guard.
2136         * nat/glibc_thread_db.h: Rename include guard.
2137         * nat/gdb_thread_db.h: Rename include guard.
2138         * nat/gdb_ptrace.h: Rename include guard.
2139         * nat/fork-inferior.h: Rename include guard.
2140         * nat/amd64-linux-siginfo.h: Rename include guard.
2141         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2142         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2143         * nat/aarch64-linux.h: Rename include guard.
2144         * nat/aarch64-linux-hw-point.h: Rename include guard.
2145         * mn10300-tdep.h: Add include guard.
2146         * mips-linux-tdep.h: Add include guard.
2147         * mi/mi-parse.h: Rename include guard.
2148         * mi/mi-out.h: Rename include guard.
2149         * mi/mi-main.h: Rename include guard.
2150         * mi/mi-interp.h: Rename include guard.
2151         * mi/mi-getopt.h: Rename include guard.
2152         * mi/mi-console.h: Rename include guard.
2153         * mi/mi-common.h: Rename include guard.
2154         * mi/mi-cmds.h: Rename include guard.
2155         * mi/mi-cmd-break.h: Rename include guard.
2156         * m2-lang.h: Add include guard.
2157         * location.h: Rename include guard.
2158         * linux-record.h: Rename include guard.
2159         * linux-nat.h: Add include guard.
2160         * linux-fork.h: Add include guard.
2161         * i386-darwin-tdep.h: Rename include guard.
2162         * hppa-linux-offsets.h: Add include guard.
2163         * guile/guile.h: Rename include guard.
2164         * guile/guile-internal.h: Rename include guard.
2165         * gnu-nat.h: Rename include guard.
2166         * gdb-stabs.h: Rename include guard.
2167         * frv-tdep.h: Add include guard.
2168         * f-lang.h: Add include guard.
2169         * event-loop.h: Add include guard.
2170         * darwin-nat.h: Rename include guard.
2171         * cp-abi.h: Rename include guard.
2172         * config/sparc/nm-sol2.h: Rename include guard.
2173         * config/nm-nto.h: Rename include guard.
2174         * config/nm-linux.h: Add include guard.
2175         * config/i386/nm-i386gnu.h: Rename include guard.
2176         * config/djgpp/nl_types.h: Rename include guard.
2177         * config/djgpp/langinfo.h: Rename include guard.
2178         * compile/gcc-cp-plugin.h: Add include guard.
2179         * compile/gcc-c-plugin.h: Add include guard.
2180         * compile/compile.h: Rename include guard.
2181         * compile/compile-object-run.h: Rename include guard.
2182         * compile/compile-object-load.h: Rename include guard.
2183         * compile/compile-internal.h: Rename include guard.
2184         * compile/compile-cplus.h: Rename include guard.
2185         * compile/compile-c.h: Rename include guard.
2186         * common/xml-utils.h: Rename include guard.
2187         * common/x86-xstate.h: Rename include guard.
2188         * common/version.h: Rename include guard.
2189         * common/vec.h: Rename include guard.
2190         * common/tdesc.h: Rename include guard.
2191         * common/selftest.h: Rename include guard.
2192         * common/scoped_restore.h: Rename include guard.
2193         * common/scoped_mmap.h: Rename include guard.
2194         * common/scoped_fd.h: Rename include guard.
2195         * common/safe-iterator.h: Rename include guard.
2196         * common/run-time-clock.h: Rename include guard.
2197         * common/refcounted-object.h: Rename include guard.
2198         * common/queue.h: Rename include guard.
2199         * common/ptid.h: Rename include guard.
2200         * common/print-utils.h: Rename include guard.
2201         * common/preprocessor.h: Rename include guard.
2202         * common/pathstuff.h: Rename include guard.
2203         * common/observable.h: Rename include guard.
2204         * common/netstuff.h: Rename include guard.
2205         * common/job-control.h: Rename include guard.
2206         * common/host-defs.h: Rename include guard.
2207         * common/gdb_wait.h: Rename include guard.
2208         * common/gdb_vecs.h: Rename include guard.
2209         * common/gdb_unlinker.h: Rename include guard.
2210         * common/gdb_unique_ptr.h: Rename include guard.
2211         * common/gdb_tilde_expand.h: Rename include guard.
2212         * common/gdb_sys_time.h: Rename include guard.
2213         * common/gdb_string_view.h: Rename include guard.
2214         * common/gdb_splay_tree.h: Rename include guard.
2215         * common/gdb_setjmp.h: Rename include guard.
2216         * common/gdb_ref_ptr.h: Rename include guard.
2217         * common/gdb_optional.h: Rename include guard.
2218         * common/gdb_locale.h: Rename include guard.
2219         * common/gdb_assert.h: Rename include guard.
2220         * common/filtered-iterator.h: Rename include guard.
2221         * common/filestuff.h: Rename include guard.
2222         * common/fileio.h: Rename include guard.
2223         * common/environ.h: Rename include guard.
2224         * common/common-utils.h: Rename include guard.
2225         * common/common-types.h: Rename include guard.
2226         * common/common-regcache.h: Rename include guard.
2227         * common/common-inferior.h: Rename include guard.
2228         * common/common-gdbthread.h: Rename include guard.
2229         * common/common-exceptions.h: Rename include guard.
2230         * common/common-defs.h: Rename include guard.
2231         * common/common-debug.h: Rename include guard.
2232         * common/cleanups.h: Rename include guard.
2233         * common/buffer.h: Rename include guard.
2234         * common/btrace-common.h: Rename include guard.
2235         * common/break-common.h: Rename include guard.
2236         * cli/cli-utils.h: Rename include guard.
2237         * cli/cli-style.h: Rename include guard.
2238         * cli/cli-setshow.h: Rename include guard.
2239         * cli/cli-script.h: Rename include guard.
2240         * cli/cli-interp.h: Rename include guard.
2241         * cli/cli-decode.h: Rename include guard.
2242         * cli/cli-cmds.h: Rename include guard.
2243         * charset-list.h: Add include guard.
2244         * buildsym-legacy.h: Rename include guard.
2245         * bfin-tdep.h: Add include guard.
2246         * ax.h: Rename include guard.
2247         * arm-linux-tdep.h: Add include guard.
2248         * arm-fbsd-tdep.h: Add include guard.
2249         * arch/xtensa.h: Rename include guard.
2250         * arch/tic6x.h: Add include guard.
2251         * arch/i386.h: Add include guard.
2252         * arch/arm.h: Rename include guard.
2253         * arch/arm-linux.h: Rename include guard.
2254         * arch/arm-get-next-pcs.h: Rename include guard.
2255         * arch/amd64.h: Add include guard.
2256         * arch/aarch64-insn.h: Rename include guard.
2257         * arch-utils.h: Rename include guard.
2258         * annotate.h: Add include guard.
2259         * amd64-darwin-tdep.h: Rename include guard.
2260         * aarch64-linux-tdep.h: Add include guard.
2261         * aarch64-fbsd-tdep.h: Add include guard.
2262         * aarch32-linux-nat.h: Add include guard.
2263
2264 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2265
2266         * macrotab.c (macro_define_internal): New function that
2267         factorizes macro_define_object_internal and macro_define_function
2268         code.
2269         (macro_define_object_internal): Use macro_define_internal.
2270         (macro_define_function): Likewise.
2271
2272 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2273
2274         * macrocmd.c (extract_identifier): Return
2275         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2276         callers.
2277
2278 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2279
2280         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2281
2282 2019-02-05  Tom Tromey  <tom@tromey.com>
2283
2284         * target.c (target_stack::unpush): Move assertion earlier.
2285
2286 2019-01-30  Tom Tromey  <tom@tromey.com>
2287
2288         PR python/23615:
2289         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2290         (gdbpy_parse_and_eval): Likewise.
2291         * python/python-internal.h (gdbpy_allow_threads): New class.
2292
2293 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2294
2295         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2296         (aarch64_fbsd_fpregmap): Move earlier.
2297         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2298         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2299         instead of individual calls to trad_frame_set_reg_addr.
2300         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2301         earlier.
2302         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2303         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2304         instead of individual calls to trad_frame_set_reg_addr.
2305
2306 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2307
2308         * CONTRIBUTE: Replace contribution list with wiki link.
2309
2310 2019-01-25  Tom Tromey  <tom@tromey.com>
2311
2312         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2313
2314 2019-01-25  Tom Tromey  <tom@tromey.com>
2315
2316         * xtensa-linux-nat.c: Fix common/ includes.
2317         * xml-support.h: Fix common/ includes.
2318         * xml-support.c: Fix common/ includes.
2319         * x86-linux-nat.c: Fix common/ includes.
2320         * windows-nat.c: Fix common/ includes.
2321         * varobj.h: Fix common/ includes.
2322         * varobj.c: Fix common/ includes.
2323         * value.c: Fix common/ includes.
2324         * valops.c: Fix common/ includes.
2325         * utils.c: Fix common/ includes.
2326         * unittests/xml-utils-selftests.c: Fix common/ includes.
2327         * unittests/utils-selftests.c: Fix common/ includes.
2328         * unittests/unpack-selftests.c: Fix common/ includes.
2329         * unittests/tracepoint-selftests.c: Fix common/ includes.
2330         * unittests/style-selftests.c: Fix common/ includes.
2331         * unittests/string_view-selftests.c: Fix common/ includes.
2332         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2333         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2334         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2335         * unittests/rsp-low-selftests.c: Fix common/ includes.
2336         * unittests/parse-connection-spec-selftests.c: Fix common/
2337         includes.
2338         * unittests/optional-selftests.c: Fix common/ includes.
2339         * unittests/offset-type-selftests.c: Fix common/ includes.
2340         * unittests/observable-selftests.c: Fix common/ includes.
2341         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2342         * unittests/memrange-selftests.c: Fix common/ includes.
2343         * unittests/memory-map-selftests.c: Fix common/ includes.
2344         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2345         * unittests/function-view-selftests.c: Fix common/ includes.
2346         * unittests/environ-selftests.c: Fix common/ includes.
2347         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2348         * unittests/common-utils-selftests.c: Fix common/ includes.
2349         * unittests/cli-utils-selftests.c: Fix common/ includes.
2350         * unittests/array-view-selftests.c: Fix common/ includes.
2351         * ui-file.c: Fix common/ includes.
2352         * tui/tui-io.c: Fix common/ includes.
2353         * tracepoint.h: Fix common/ includes.
2354         * tracepoint.c: Fix common/ includes.
2355         * tracefile-tfile.c: Fix common/ includes.
2356         * top.h: Fix common/ includes.
2357         * top.c: Fix common/ includes.
2358         * thread.c: Fix common/ includes.
2359         * target/waitstatus.h: Fix common/ includes.
2360         * target/waitstatus.c: Fix common/ includes.
2361         * target.h: Fix common/ includes.
2362         * target.c: Fix common/ includes.
2363         * target-memory.c: Fix common/ includes.
2364         * target-descriptions.c: Fix common/ includes.
2365         * symtab.h: Fix common/ includes.
2366         * symfile.c: Fix common/ includes.
2367         * stap-probe.c: Fix common/ includes.
2368         * spu-linux-nat.c: Fix common/ includes.
2369         * sparc-nat.c: Fix common/ includes.
2370         * source.c: Fix common/ includes.
2371         * solib.c: Fix common/ includes.
2372         * solib-target.c: Fix common/ includes.
2373         * ser-unix.c: Fix common/ includes.
2374         * ser-tcp.c: Fix common/ includes.
2375         * ser-pipe.c: Fix common/ includes.
2376         * ser-base.c: Fix common/ includes.
2377         * selftest-arch.c: Fix common/ includes.
2378         * s12z-tdep.c: Fix common/ includes.
2379         * rust-exp.y: Fix common/ includes.
2380         * rs6000-aix-tdep.c: Fix common/ includes.
2381         * riscv-tdep.c: Fix common/ includes.
2382         * remote.c: Fix common/ includes.
2383         * remote-notif.h: Fix common/ includes.
2384         * remote-fileio.h: Fix common/ includes.
2385         * remote-fileio.c: Fix common/ includes.
2386         * regcache.h: Fix common/ includes.
2387         * regcache.c: Fix common/ includes.
2388         * record-btrace.c: Fix common/ includes.
2389         * python/python.c: Fix common/ includes.
2390         * python/py-type.c: Fix common/ includes.
2391         * python/py-inferior.c: Fix common/ includes.
2392         * progspace.h: Fix common/ includes.
2393         * producer.c: Fix common/ includes.
2394         * procfs.c: Fix common/ includes.
2395         * proc-api.c: Fix common/ includes.
2396         * printcmd.c: Fix common/ includes.
2397         * ppc-linux-nat.c: Fix common/ includes.
2398         * parser-defs.h: Fix common/ includes.
2399         * osdata.c: Fix common/ includes.
2400         * obsd-nat.c: Fix common/ includes.
2401         * nat/x86-linux.c: Fix common/ includes.
2402         * nat/x86-linux-dregs.c: Fix common/ includes.
2403         * nat/x86-dregs.h: Fix common/ includes.
2404         * nat/x86-dregs.c: Fix common/ includes.
2405         * nat/ppc-linux.c: Fix common/ includes.
2406         * nat/mips-linux-watch.h: Fix common/ includes.
2407         * nat/mips-linux-watch.c: Fix common/ includes.
2408         * nat/linux-waitpid.c: Fix common/ includes.
2409         * nat/linux-ptrace.h: Fix common/ includes.
2410         * nat/linux-ptrace.c: Fix common/ includes.
2411         * nat/linux-procfs.c: Fix common/ includes.
2412         * nat/linux-personality.c: Fix common/ includes.
2413         * nat/linux-osdata.c: Fix common/ includes.
2414         * nat/linux-namespaces.c: Fix common/ includes.
2415         * nat/linux-btrace.h: Fix common/ includes.
2416         * nat/linux-btrace.c: Fix common/ includes.
2417         * nat/fork-inferior.c: Fix common/ includes.
2418         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2419         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2420         * nat/aarch64-linux.c: Fix common/ includes.
2421         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2422         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2423         * namespace.h: Fix common/ includes.
2424         * mips-linux-tdep.c: Fix common/ includes.
2425         * minsyms.c: Fix common/ includes.
2426         * mi/mi-parse.h: Fix common/ includes.
2427         * mi/mi-main.c: Fix common/ includes.
2428         * mi/mi-cmd-env.c: Fix common/ includes.
2429         * memrange.h: Fix common/ includes.
2430         * memattr.c: Fix common/ includes.
2431         * maint.h: Fix common/ includes.
2432         * maint.c: Fix common/ includes.
2433         * main.c: Fix common/ includes.
2434         * machoread.c: Fix common/ includes.
2435         * location.c: Fix common/ includes.
2436         * linux-thread-db.c: Fix common/ includes.
2437         * linux-nat.c: Fix common/ includes.
2438         * linux-fork.c: Fix common/ includes.
2439         * inline-frame.c: Fix common/ includes.
2440         * infrun.c: Fix common/ includes.
2441         * inflow.c: Fix common/ includes.
2442         * inferior.h: Fix common/ includes.
2443         * inferior.c: Fix common/ includes.
2444         * infcmd.c: Fix common/ includes.
2445         * inf-ptrace.c: Fix common/ includes.
2446         * inf-child.c: Fix common/ includes.
2447         * ia64-linux-nat.c: Fix common/ includes.
2448         * i387-tdep.c: Fix common/ includes.
2449         * i386-tdep.c: Fix common/ includes.
2450         * i386-linux-tdep.c: Fix common/ includes.
2451         * i386-linux-nat.c: Fix common/ includes.
2452         * i386-go32-tdep.c: Fix common/ includes.
2453         * i386-fbsd-tdep.c: Fix common/ includes.
2454         * i386-fbsd-nat.c: Fix common/ includes.
2455         * guile/scm-type.c: Fix common/ includes.
2456         * guile/guile.c: Fix common/ includes.
2457         * go32-nat.c: Fix common/ includes.
2458         * gnu-nat.c: Fix common/ includes.
2459         * gdbthread.h: Fix common/ includes.
2460         * gdbarch-selftests.c: Fix common/ includes.
2461         * gdb_usleep.c: Fix common/ includes.
2462         * gdb_select.h: Fix common/ includes.
2463         * gdb_bfd.c: Fix common/ includes.
2464         * gcore.c: Fix common/ includes.
2465         * fork-child.c: Fix common/ includes.
2466         * findvar.c: Fix common/ includes.
2467         * fbsd-nat.c: Fix common/ includes.
2468         * event-top.c: Fix common/ includes.
2469         * event-loop.c: Fix common/ includes.
2470         * dwarf2read.c: Fix common/ includes.
2471         * dwarf2loc.c: Fix common/ includes.
2472         * dwarf2-frame.c: Fix common/ includes.
2473         * dwarf-index-cache.c: Fix common/ includes.
2474         * dtrace-probe.c: Fix common/ includes.
2475         * disasm-selftests.c: Fix common/ includes.
2476         * defs.h: Fix common/ includes.
2477         * csky-tdep.c: Fix common/ includes.
2478         * cp-valprint.c: Fix common/ includes.
2479         * cp-support.h: Fix common/ includes.
2480         * cp-support.c: Fix common/ includes.
2481         * corelow.c: Fix common/ includes.
2482         * completer.h: Fix common/ includes.
2483         * completer.c: Fix common/ includes.
2484         * compile/compile.c: Fix common/ includes.
2485         * compile/compile-loc2c.c: Fix common/ includes.
2486         * compile/compile-cplus-types.c: Fix common/ includes.
2487         * compile/compile-cplus-symbols.c: Fix common/ includes.
2488         * command.h: Fix common/ includes.
2489         * cli/cli-dump.c: Fix common/ includes.
2490         * cli/cli-cmds.c: Fix common/ includes.
2491         * charset.c: Fix common/ includes.
2492         * build-id.c: Fix common/ includes.
2493         * btrace.h: Fix common/ includes.
2494         * btrace.c: Fix common/ includes.
2495         * breakpoint.h: Fix common/ includes.
2496         * breakpoint.c: Fix common/ includes.
2497         * ax.h:
2498         (enum agent_op): Fix common/ includes.
2499         * ax-general.c (struct aop_map): Fix common/ includes.
2500         * ax-gdb.c: Fix common/ includes.
2501         * auxv.c: Fix common/ includes.
2502         * auto-load.c: Fix common/ includes.
2503         * arm-tdep.c: Fix common/ includes.
2504         * arch/riscv.c: Fix common/ includes.
2505         * arch/ppc-linux-common.c: Fix common/ includes.
2506         * arch/i386.c: Fix common/ includes.
2507         * arch/arm.c: Fix common/ includes.
2508         * arch/arm-linux.c: Fix common/ includes.
2509         * arch/arm-get-next-pcs.c: Fix common/ includes.
2510         * arch/amd64.c: Fix common/ includes.
2511         * arch/aarch64.c: Fix common/ includes.
2512         * arch/aarch64-insn.c: Fix common/ includes.
2513         * arch-utils.c: Fix common/ includes.
2514         * amd64-windows-tdep.c: Fix common/ includes.
2515         * amd64-tdep.c: Fix common/ includes.
2516         * amd64-sol2-tdep.c: Fix common/ includes.
2517         * amd64-obsd-tdep.c: Fix common/ includes.
2518         * amd64-nbsd-tdep.c: Fix common/ includes.
2519         * amd64-linux-tdep.c: Fix common/ includes.
2520         * amd64-linux-nat.c: Fix common/ includes.
2521         * amd64-fbsd-tdep.c: Fix common/ includes.
2522         * amd64-fbsd-nat.c: Fix common/ includes.
2523         * amd64-dicos-tdep.c: Fix common/ includes.
2524         * amd64-darwin-tdep.c: Fix common/ includes.
2525         * agent.c: Fix common/ includes.
2526         * ada-lang.h: Fix common/ includes.
2527         * ada-lang.c: Fix common/ includes.
2528         * aarch64-tdep.c: Fix common/ includes.
2529
2530 2019-01-25  Tom Tromey  <tom@tromey.com>
2531
2532         * common/create-version.sh: Use common/version.h.
2533
2534 2019-01-24  Pedro Alves  <palves@redhat.com>
2535
2536         * infrun.c (signal_stop, signal_print, signal_program)
2537         (signal_catch, signal_pass): Now arrays instead of pointers.
2538         (update_signals_program_target, do_target_resume)
2539         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2540         * linux-nat.c (linux_nat_target::pass_signals)
2541         (linux_nat_target::create_inferior, linux_nat_target::attach):
2542         Adjust.
2543         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2544         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2545         * procfs.c (procfs_target::pass_signals): Adjust.
2546         * record-full.c (record_full_target::resume): Adjust.
2547         * remote.c (remote_target::pass_signals)
2548         (remote_target::program_signals): Adjust.
2549         * target-debug.h (target_debug_print_signals): Now takes a
2550         gdb::array_view as parameter.  Adjust.
2551         * target.h (target_ops) <pass_signals, program_signals>: Replace
2552         pointer and length parameters with gdb::array_view.
2553         (target_pass_signals, target_program_signals): Likewise.
2554         * target-delegates.c: Regenerate.
2555
2556 2019-01-24  Pedro Alves  <palves@redhat.com>
2557
2558         * common/forward-scope-exit.h
2559         (forward_scope_exit::forward_scope_exit): Pass arguments to
2560         m_bind_function directly, instead of creating a std::bind and
2561         copying that.
2562
2563 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2564
2565         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2566         for static members.
2567         (pass_in_v_vfp_candidate): Likewise.
2568
2569 2019-01-23  Tom Tromey  <tom@tromey.com>
2570             Pedro Alves  <palves@redhat.com>
2571
2572         * regcache.c (class regcache_invalidator): Remove.
2573         (regcache::raw_write): Use make_scope_exit.
2574
2575 2019-01-23  Tom Tromey  <tom@tromey.com>
2576
2577         * ui-out.h (class ui_out_emit_type): Update comment.
2578
2579 2019-01-23  Tom Tromey  <tom@tromey.com>
2580
2581         * infrun.c (fetch_inferior_event): Update comment.
2582
2583 2019-01-23  Tom Tromey  <tom@tromey.com>
2584             Pedro Alves  <palves@redhat.com>
2585
2586         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2587         parameter.
2588         (fetch_inferior_event): Use SCOPE_EXIT.
2589
2590
2591 2019-01-23  Tom Tromey  <tom@tromey.com>
2592             Pedro Alves  <palves@redhat.com>
2593
2594         * infrun.c (disable_thread_events): Delete.
2595         (stop_all_threads): Use SCOPE_EXIT.
2596
2597 2019-01-23  Tom Tromey  <tom@tromey.com>
2598             Pedro Alves  <palves@redhat.com>
2599
2600         * symfile.c: Include forward-scope-exit.h.
2601         (clear_symtab_users_cleanup): Replace forward declaration with
2602         a FORWARD_SCOPE_EXIT.
2603         (syms_from_objfile_1): Use the forward_scope_exit and
2604         gdb::optional instead of cleanup_function.
2605         (reread_symbols): Use the forward_scope_exit instead of
2606         cleanup_function.
2607         (clear_symtab_users_cleanup): Remove function.
2608
2609 2019-01-23  Tom Tromey  <tom@tromey.com>
2610             Pedro Alves  <palves@redhat.com>
2611
2612         * linux-nat.c: Include scope-exit.h.
2613         (cleanup_target_stop): Remove.
2614         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2615         SCOPE_EXIT.
2616
2617 2019-01-23  Tom Tromey  <tom@tromey.com>
2618             Pedro Alves  <palves@redhat.com>
2619
2620         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2621         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2622
2623 2019-01-23  Tom Tromey  <tom@tromey.com>
2624             Andrew Burgess  <andrew.burgess@embecosm.com>
2625             Pedro Alves  <palves@redhat.com>
2626
2627         * infrun.c (fetch_inferior_event): Use scope_exit.
2628         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2629         * top.c (execute_command): Use scope_exit.
2630         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2631         * utils.c (do_bpstat_clear_actions_cleanup)
2632         (make_bpstat_clear_actions_cleanup): Remove.
2633
2634 2019-01-23  Tom Tromey  <tom@tromey.com>
2635             Pedro Alves  <palves@redhat.com>
2636
2637         * infrun.c: Include "common/scope-exit.h"
2638         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2639         (wait_for_inferior): Use SCOPE_EXIT.
2640         (fetch_inferior_event): Use scope_exit.
2641
2642 2019-01-23  Tom Tromey  <tom@tromey.com>
2643             Pedro Alves  <palves@redhat.com>
2644
2645         * breakpoint.c (create_breakpoint): Remove cleanup.
2646
2647 2019-01-23  Tom Tromey  <tom@tromey.com>
2648             Andrew Burgess  <andrew.burgess@embecosm.com>
2649             Pedro Alves  <palves@redhat.com>
2650
2651 2019-01-23  Pedro Alves  <palves@redhat.com>
2652
2653         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2654
2655 2019-01-23  Pedro Alves  <palves@redhat.com>
2656             Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * gdbthread.h: Include "common/forward-scope-exit.h".
2659         (scoped_finish_thread_state): Redefine custom class in terms of
2660         forward_scope_exit.
2661
2662 2019-01-23  Pedro Alves  <palves@redhat.com>
2663             Andrew Burgess  <andrew.burgess@embecosm.com>
2664
2665         * common/forward-scope-exit.h: New file.
2666
2667 2019-01-23  Pedro Alves  <palves@redhat.com>
2668             Andrew Burgess  <andrew.burgess@embecosm.com>
2669             Tom Tromey  <tom@tromey.com>
2670
2671         * common/scope-exit.h: New file.
2672
2673 2019-01-23  Pedro Alves  <palves@redhat.com>
2674
2675         * common/preprocessor.h (ESC): Rename to ...
2676         (ESC_PARENS): ... this.
2677         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2678         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2679
2680 2019-01-23  Tom Tromey  <tom@tromey.com>
2681
2682         * language.h (class scoped_switch_to_sym_language_if_auto):
2683         Initialize m_lang in both cases.
2684
2685 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2686
2687         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2688         with XCNEW.
2689
2690 2019-01-22  Tom Tromey  <tom@tromey.com>
2691
2692         * corelow.c: Do not include sys/file.h.
2693
2694 2019-01-22  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-wingeneral.h: Include gdb_curses.h.
2697
2698 2019-01-22  Tom Tromey  <tom@tromey.com>
2699
2700         * source-cache.h (class source_cache) <get_source_lines,
2701         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2702
2703 2019-01-22  Tom Tromey  <tom@tromey.com>
2704
2705         * remote-fileio.h (struct remote_target): Declare.
2706
2707 2019-01-22  Tom Tromey  <tom@tromey.com>
2708
2709         * python/py-arch.c: Do not include py-ref.h.
2710         * python/py-bpevent.c: Do not include py-ref.h.
2711         * python/py-cmd.c: Do not include py-ref.h.
2712         * python/py-continueevent.c: Do not include py-ref.h.
2713         * python/py-event.h: Do not include py-ref.h.
2714         * python/py-evtregistry.c: Do not include py-ref.h.
2715         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2716         * python/py-frame.c: Do not include py-ref.h.
2717         * python/py-framefilter.c: Do not include py-ref.h.
2718         * python/py-function.c: Do not include py-ref.h.
2719         * python/py-infevents.c: Do not include py-ref.h.
2720         * python/py-linetable.c: Do not include py-ref.h.
2721         * python/py-objfile.c: Do not include py-ref.h.
2722         * python/py-param.c: Do not include py-ref.h.
2723         * python/py-prettyprint.c: Do not include py-ref.h.
2724         * python/py-progspace.c: Do not include py-ref.h.
2725         * python/py-symbol.c: Do not include py-ref.h.
2726         * python/py-symtab.c: Do not include py-ref.h.
2727         * python/py-type.c: Do not include py-ref.h.
2728         * python/py-unwind.c: Do not include py-ref.h.
2729         * python/py-utils.c: Do not include py-ref.h.
2730         * python/py-value.c: Do not include py-ref.h.
2731         * python/py-varobj.c: Do not include py-ref.h.
2732         * python/py-xmethods.c: Do not include py-ref.h.
2733         * python/python.c: Do not include py-ref.h.
2734         * varobj.c: Do not include py-ref.h.
2735
2736 2019-01-22  Tom Tromey  <tom@tromey.com>
2737
2738         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2739         keyword for bcache.
2740
2741 2019-01-22  Tom Tromey  <tom@tromey.com>
2742
2743         * compile/compile-cplus-types.c: Remove a comment by #include.
2744
2745 2019-01-22  Tom Tromey  <tom@tromey.com>
2746
2747         * compile/gcc-c-plugin.h: Include compile-internal.h.
2748
2749 2019-01-22  Tom Tromey  <tom@tromey.com>
2750
2751         * stabsread.c (EXTERN): Do not define.
2752         (symnum, next_symbol_text_func, processing_gcc_compilation)
2753         (within_function, global_sym_chain, global_stabs)
2754         (previous_stab_code, this_object_header_files)
2755         (n_this_object_header_files)
2756         (n_allocated_this_object_header_files): Define.
2757         * stabsread.h (EXTERN): Never define.  Use "extern".
2758
2759 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2760
2761         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2762         history_value.
2763
2764 2019-01-21  Tom Tromey  <tom@tromey.com>
2765
2766         * ui-out.c: Fix includes.
2767         * tui/tui-source.c: Fix includes.
2768         * target.c: Fix includes.
2769         * remote.c: Fix includes.
2770         * regcache.c: Fix includes.
2771         * python/py-block.c: Fix includes.
2772         * printcmd.c: Fix includes.
2773         * or1k-tdep.c: Fix includes.
2774         * mi/mi-main.c: Fix includes.
2775         * m32r-tdep.c: Fix includes.
2776         * csky-tdep.c: Fix includes.
2777         * compile/compile-cplus-types.c: Fix includes.
2778         * cli/cli-interp.c: Fix includes.
2779
2780 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2781
2782         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2783         for padding.
2784
2785 2019-01-16  Tom Tromey  <tom@tromey.com>
2786
2787         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2788         earlier.
2789         (struct objfile) <msymbols_range>: Move from top level.
2790         <msymbols>: New method.
2791         (class objfile_msymbols): Remove.
2792         * symtab.c (default_collect_symbol_completion_matches_break_on):
2793         Update.
2794         * symmisc.c (dump_msymbols): Update.
2795         * stabsread.c (scan_file_globals): Update.
2796         * objc-lang.c (info_selectors_command, info_classes_command)
2797         (find_methods): Update.
2798         * minsyms.c (find_solib_trampoline_target): Update.
2799         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2800         * coffread.c (coff_symfile_read): Update.
2801         * ada-lang.c (ada_lookup_simple_minsym)
2802         (ada_collect_symbol_completion_matches): Update.
2803
2804 2019-01-16  Tom Tromey  <tom@tromey.com>
2805
2806         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2807         type.  Remove no-argument constructor.
2808         <iterator::operator++>: Simplify.
2809         <begin>: Update.
2810         <end>: Use minimal_symbol_count.
2811
2812 2019-01-16  Tom Tromey  <tom@tromey.com>
2813
2814         * objfiles.h (struct objfile) <psymtabs>: New method.
2815         (class objfile_psymtabs): Remove.
2816         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2817         typedef.
2818         <range>: New method.
2819         (require_partial_symbols): Change return type.
2820         * psymtab.c (require_partial_symbols)
2821         (psym_expand_symtabs_matching): Update.
2822         * mdebugread.c (parse_partial_symbols): Update.
2823         * dbxread.c (dbx_end_psymtab): Update.
2824
2825 2019-01-15  Tom Tromey  <tom@tromey.com>
2826
2827         * symtab.c (lookup_objfile_from_block)
2828         (lookup_symbol_in_objfile_symtabs)
2829         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2830         (find_line_symtab, info_sources_command)
2831         (default_collect_symbol_completion_matches_break_on)
2832         (make_source_files_completion_list): Update.
2833         * symmisc.c (print_objfile_statistics, dump_objfile)
2834         (maintenance_print_symbols, maintenance_info_symtabs)
2835         (maintenance_check_symtabs, maintenance_info_line_tables):
2836         Update.
2837         * source.c (select_source_symtab)
2838         (forget_cached_source_info_for_objfile): Update.
2839         * objfiles.h (class objfile_compunits): Remove.
2840         (struct objfile) <compunits_range>: New typedef.
2841         (compunits): New method.
2842         * objfiles.c (objfile_relocate1): Update.
2843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2844         * maint.c (count_symtabs_and_blocks): Update.
2845         * linespec.c (iterate_over_all_matching_symtabs): Update.
2846         * cp-support.c (add_symbol_overload_list_qualified): Update.
2847         * coffread.c (coff_symtab_read): Update.
2848         * ada-lang.c (add_nonlocal_symbols)
2849         (ada_collect_symbol_completion_matches)
2850         (ada_add_global_exceptions): Update.
2851
2852 2019-01-15  Tom Tromey  <tom@tromey.com>
2853
2854         * progspace.h (program_space) <objfiles_safe_range>: New
2855         typedef.
2856         <objfiles_safe>: New method.
2857         * objfiles.h (class all_objfiles_safe): Remove.
2858         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2859         * jit.c (jit_inferior_exit_hook): Update.
2860
2861 2019-01-17  Tom Tromey  <tom@tromey.com>
2862
2863         * progspace.h (program_space) <objfiles_range>: New typedef.
2864         <objfiles>: New method.
2865         <objfiles_head>: Rename from objfiles.
2866         (object_files): Update.
2867         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2868         * guile/scm-pretty-print.c
2869         (ppscm_find_pretty_printer_from_objfiles): Update.
2870         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2872         Update.
2873         * python/py-progspace.c (pspy_get_objfiles): Update.
2874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2875         Update.
2876         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2877         (objfpy_lookup_objfile_by_build_id): Update.
2878         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2879         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2880         Update.
2881         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2882         (expand_symtab_containing_pc, lookup_objfile_from_block)
2883         (lookup_static_symbol, basic_lookup_transparent_type)
2884         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2885         (find_line_symtab, info_sources_command)
2886         (default_collect_symbol_completion_matches_break_on)
2887         (make_source_files_completion_list, find_main_name): Update.
2888         * symmisc.c (print_symbol_bcache_statistics)
2889         (print_objfile_statistics, maintenance_print_symbols)
2890         (maintenance_print_msymbols, maintenance_print_objfiles)
2891         (maintenance_info_symtabs, maintenance_check_symtabs)
2892         (maintenance_expand_symtabs, maintenance_info_line_tables):
2893         Update.
2894         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2895         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2896         (map_overlay_command, unmap_overlay_command)
2897         (simple_overlay_update, expand_symtabs_matching)
2898         (map_symbol_filenames): Update.
2899         * symfile-debug.c (set_debug_symfile): Update.
2900         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2901         Update.
2902         * source.c (select_source_symtab, forget_cached_source_info):
2903         Update.
2904         * solib.c (solib_read_symbols): Update.
2905         * solib-spu.c (append_ocl_sos): Update.
2906         * psymtab.c (maintenance_print_psymbols)
2907         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2908         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2909         * printcmd.c (info_symbol_command): Update.
2910         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2911         Update.
2912         * objfiles.h (class all_objfiles): Remove.
2913         * objfiles.c (have_partial_symbols, have_full_symbols)
2914         (have_minimal_symbols, qsort_cmp, update_section_map)
2915         (shared_objfile_contains_address_p)
2916         (default_iterate_over_objfiles_in_search_order): Update.
2917         * objc-lang.c (info_selectors_command, info_classes_command)
2918         (find_methods): Update.
2919         * minsyms.c (find_solib_trampoline_target): Update.
2920         * maint.c (maintenance_info_sections)
2921         (maintenance_translate_address, count_symtabs_and_blocks):
2922         Update.
2923         * main.c (captured_main_1): Update.
2924         * linux-thread-db.c (try_thread_db_load_from_pdir)
2925         (has_libpthread): Update.
2926         * linespec.c (iterate_over_all_matching_symtabs)
2927         (search_minsyms_for_name): Update.
2928         * jit.c (jit_find_objf_with_entry_addr): Update.
2929         * hppa-tdep.c (find_unwind_entry)
2930         (hppa_lookup_stub_minimal_symbol): Update.
2931         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2932         Update.
2933         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2934         (elf_gnu_ifunc_resolve_by_got): Update.
2935         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2936         * dwarf-index-write.c (save_gdb_index_command): Update.
2937         * cp-support.c (add_symbol_overload_list_qualified): Update.
2938         * breakpoint.c (create_overlay_event_breakpoint)
2939         (create_longjmp_master_breakpoint)
2940         (create_std_terminate_master_breakpoint)
2941         (create_exception_master_breakpoint): Update.
2942         * blockframe.c (find_pc_partial_function): Update.
2943         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2944         (ada_collect_symbol_completion_matches)
2945         (ada_add_global_exceptions): Update.
2946
2947 2019-01-17  Tom Tromey  <tom@tromey.com>
2948
2949         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2950         declare VEC.
2951         (solib_target_parse_libraries): Change return type.
2952         (library_list_start_segment, library_list_start_section)
2953         (library_list_end_library, library_list_start_library); Update.
2954         (solib_target_free_library_list): Remove.
2955         (solib_target_parse_libraries): Remove cleanup.  Change return
2956         type.
2957         (solib_target_current_sos): Update.
2958
2959 2019-01-17  Tom Tromey  <tromey@bapiya>
2960
2961         * valprint.c: Replace "the the" with "the".
2962         * symtab.c: Replace "the the" with "the".
2963         * solib.c: Replace "the the" with "the".
2964         * solib-dsbt.c: Replace "the the" with "the".
2965         * linespec.c: Replace "the the" with "the".
2966         * dwarf2loc.h: Replace "the the" with "the".
2967         * amd64-windows-tdep.c: Replace "the the" with "the".
2968         * aarch64-tdep.c: Replace "the the" with "the".
2969
2970 2019-01-16  Keith Seitz  <keiths@redhat.com>
2971
2972         PR gdb/23773
2973         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2974         <builder>: Rename to ..
2975         <m_builder>: ... this and make private.
2976         (dwarf2_cu::get_builder): New method.  Change all users of
2977         `builder' to use this method.
2978         (dwarf2_start_symtab): Move to ...
2979         (dwarf2_cu::start_symtab): ... here.  Update all callers
2980         (setup_type_unit_groups): Move to ...
2981         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2982         callers.
2983         (dwarf2_cu::reset_builder): New method.
2984         (process_full_compunit, process_full_type_unit): Use
2985         dwarf2_cu::reset_builder.
2986         (follow_die_offset): Record the ancestor CU if it is different
2987         from the followed DIE's CU.
2988         (follow_die_sig_1): Likewise.
2989
2990 2019-01-15  Tom Tromey  <tom@tromey.com>
2991
2992         * remote.c (class remote_state) <buf>: Now a char_vector.
2993         <buf_size>: Remove.
2994         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2995         parameter.
2996         (remote_target::getpkt_or_notif_sane_1)
2997         (remote_target::getpkt_sane)
2998         (remote_target::getpkt_or_notif_sane): Likewise.
2999         (class remote_target) <putpkt>: New overload.
3000         (remote_target::read_frame): Change type of "buf_p".  Remove
3001         sizeof_p parameter.
3002         (packet_ok): New overload.
3003         (packet_check_result): New overload.
3004         Update all uses.
3005
3006 2019-01-14  Tom Tromey  <tom@tromey.com>
3007
3008         * remote-notif.c (handle_notification, remote_notif_ack)
3009         (remote_notif_parse): Make "buf" const.
3010         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3011         const.
3012         (remote_notif_parse, remote_notif_ack, handle_notification):
3013         Likewise.
3014         * remote.c (remote_notif_stop_parse): Make "buf" const.
3015         (remote_target::remote_parse_stop_reply): Make "buf" const.
3016         (remote_notif_stop_ack): Make "buf" const.
3017
3018 2019-01-14  Tom Tromey  <tom@tromey.com>
3019
3020         * remote.c (remote_console_output): Make parameter const.
3021
3022 2019-01-14  Tom Tromey  <tom@tromey.com>
3023
3024         * target-debug.h (target_debug_print_signals): Constify.
3025         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3026         * procfs.c (procfs_target::pass_signals): Update.
3027         * linux-nat.c (linux_nat_target::pass_signals): Update.
3028         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3029         * target-delegates.c: Rebuild.
3030         * remote.c (remote_target::program_signals): Update.
3031         (remote_target::pass_signals): Update.
3032         * target.c (target_pass_signals): Constify argument.
3033         (target_program_signals): Likewise.
3034         * target.h (struct target_ops) <pass_signals, program_signals>:
3035         Constify argument.
3036         (target_pass_signals, target_program_signals): Constify argument.
3037
3038 2019-01-14  Tom Tromey  <tom@tromey.com>
3039
3040         PR tui/28819:
3041         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3042
3043 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3044
3045         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3046         field.
3047         * rs6000-tdep.c: Include reggroups.h.
3048         (IS_V_ALIAS_PSEUDOREG): Define.
3049         (rs6000_register_name): Return names for the "vX" aliases.
3050         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3051         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3052         aliases.  Call default_register_reggroup_p for all other
3053         pseudo-registers.
3054         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3055         New functions.
3056         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3057         Handle "vX" aliases.
3058         (v_alias_pseudo_register_collect): New function.
3059         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3060         (rs6000_gdbarch_init): Initialize "vX" aliases as
3061         pseudo-registers.  Restore registration of
3062         rs6000_pseudo_register_reggroup_p with
3063         set_tdesc_pseudo_register_reggroup_p.
3064
3065 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3066
3067         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3068         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3069         set_gdbarch_num_pseudo_regs.
3070
3071 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3072
3073         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3074         Remove arg prefixname, add do_set and do_show.
3075         Add member functions set_list and show_list.
3076         * cli/cli-style.c (class cli_style_option): Update accordingly.
3077         (style_set_list): Move to file scope.
3078         (style_show_list): Likewise.
3079         (set_style): Call help_list.
3080         (show_style): Call cmd_show_list.
3081         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3082         Update to use the new macro.
3083
3084 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3085
3086         * ada-lang.c (_initialize_ada_language): Expand the help text
3087         for the "catch exception" command.
3088
3089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3090
3091         * symtab.c (matching_obj_sections): Initialize obj,
3092         declare it closer to its usage.
3093
3094 2019-01-10  Tom Tromey  <tom@tromey.com>
3095
3096         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3097         (basic_inf_threads_range): Remove.
3098         (inf_threads_range, inf_non_exited_threads_range)
3099         (safe_inf_threads_range): Use next_adapter.
3100
3101 2019-01-10  Keith Seitz  <keiths@redhat.com>
3102
3103         PR gdb/23712
3104         PR symtab/23010
3105         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3106         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3107
3108 2019-01-10  Keith Seitz  <keiths@redhat.com>
3109
3110         PR gdb/23712
3111         PR symtab/23010
3112         * dictionary.c (pending_to_vector): Remove.
3113         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3114         Remove _1 suffix, replacing functions of the same name.  Update
3115         all callers.
3116         (dict_create_hashed, dict_create_hashed_expandable)
3117         (dict_create_linear, dict_create_linear_expandable, dict_free)
3118         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3119         Make functions static.
3120
3121 2019-01-10  Keith Seitz  <keiths@redhat.com>
3122
3123         PR gdb/23712
3124         PR symtab/23010
3125         * dictionary.h (struct dictionary): Replace declaration with
3126         multidictionary.
3127         (dict_create_hashed, dict_create_hashed_expandable)
3128         (dict_create_linear, dict_create_linear_expandable)
3129         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3130         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3131         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3132         taking multidictionary argument.
3133         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3134         * block.h (struct block) <dict>: Change to multidictionary
3135         and rename `multidict'.
3136         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3137         symmisc.c: Update all dictionary references to multidictionary.
3138
3139 2019-01-10  Keith Seitz  <keiths@redhat.com>
3140
3141         PR gdb/23712
3142         PR symtab/23010
3143         * dictionary.c: Include unordered_map.
3144         (pending_to_vector): New function.
3145         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3146         Rewrite the non-"_1" functions to take vector instead
3147         of linked list.
3148         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3149         "new" _1 versions of the same name.
3150         (multidictionary): Define.
3151         (std::hash<enum language): New definition.
3152         (collate_pending_symbols_by_language, mdict_create_hashed)
3153         (mdict_create_hashed_expandable, mdict_create_linear)
3154         (mdict_create_linear_expandable, mdict_free)
3155         (find_language_dictionary, create_new_language_dictionary)
3156         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3157         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3158         (mdict_size, mdict_empty): New functions.
3159         * dictionary.h (mdict_iterator): Define.
3160
3161 2019-01-10  Pedro Alves  <palves@redhat.com>
3162
3163         * breakpoint.c (read_uploaded_action)
3164         (create_tracepoint_from_upload): Adjust to use
3165         gdb::unique_xmalloc_ptr.
3166         * ctf.c (ctf_write_uploaded_tp):
3167         (SET_ARRAY_FIELD): Use emplace_back.
3168         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3169         * tracefile-tfile.c (tfile_write_uploaded_tp):
3170         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3171         gdb::unique_xmalloc_ptr.
3172         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3173         at_string, cond_string, cmd_strings>: Replace char pointers
3174         with gdb::unique_xmalloc_ptr.
3175
3176 2019-01-10  Pedro Alves  <palves@redhat.com>
3177
3178         * solib-target.c (library_list_start_library): Don't xstrdup name.
3179
3180 2019-01-10  Pedro Alves  <palves@redhat.com>
3181
3182         * mdebugread.c (parse_partial_symbols): Use
3183         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3184
3185 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * linux-fork.c (scoped_switch_fork_info)
3188         <~scoped_switch_fork_info>: Fix incorrect variable name.
3189
3190 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * linux-fork.c (scoped_switch_fork_info)
3193         <scoped_switch_fork_info>: Make explicit.
3194         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3195
3196 2019-01-10  Tom Tromey  <tom@tromey.com>
3197
3198         * objfiles.h (objfile::reset_psymtabs): Update.
3199         * objfiles.c (objfile::objfile): Update.
3200         * psymtab.h (psymtab_storage::obstack): Update.
3201         (psymtab_storage::m_obstack): Use gdb::optional.
3202         (class psymtab_storage): Update comment.  Remove objfile
3203         parameter.
3204         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3205
3206 2019-01-10  Tom Tromey  <tom@tromey.com>
3207
3208         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3209         <free_psymtabs>: Now private.
3210         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3211         (allocate_psymtab): Use new method.
3212
3213 2019-01-10  Tom Tromey  <tom@tromey.com>
3214
3215         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3216         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3217         * mdebugread.c (parse_partial_symbols): Use
3218         allocate_dependencies.
3219         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3220         allocate_dependencies.
3221         (process_psymtab_comp_unit_reader)
3222         (build_type_psymtab_dependencies): Likewise.
3223         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3224
3225 2019-01-10  Tom Tromey  <tom@tromey.com>
3226
3227         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3228         PSYMBOL_SET_LANGUAGE.
3229         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3230
3231 2019-01-10  Tom Tromey  <tom@tromey.com>
3232
3233         * psymtab.h (psymtab_storage::obstack): New method.
3234         <m_obstack>: Rename from obstack; now private.
3235         * psymtab.c (psymtab_storage): Update.
3236         * dwarf2read.c (create_addrmap_from_index)
3237         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3238         Update.
3239
3240 2019-01-10  Tom Tromey  <tom@tromey.com>
3241
3242         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3243         * objfiles.h (objfile::reset_psymtabs): New method.
3244
3245 2019-01-10  Tom Tromey  <tom@tromey.com>
3246
3247         * symmisc.c (print_symbol_bcache_statistics): Update.
3248         (print_objfile_statistics): Update.
3249         * symfile.c (reread_symbols): Update.
3250         * psymtab.h (class psymtab_storage): New.
3251         * psymtab.c (psymtab_storage): New constructor.
3252         (~psymtab_storage): New destructor.
3253         (require_partial_symbols): Update.
3254         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3255         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3256         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3257         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3258         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3259         (start_psymtab_common, end_psymtab_common)
3260         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3261         (allocate_psymtab): Update.
3262         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3263         Update.
3264         (dump_psymtab_addrmap, maintenance_print_psymbols)
3265         (maintenance_check_psymtabs): Update.
3266         (class objfile_psymtabs): Move to objfiles.h.
3267         * psympriv.h (discard_psymtab): Now inline.
3268         (psymtab_discarder::psymtab_discarder): Update.
3269         (psymtab_discarder::~psymtab_discarder): Update.
3270         (ALL_OBJFILE_PSYMTABS): Rewrite.
3271         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3272         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3273         Remove fields.
3274         <partial_symtabs>: New field.
3275         (class objfile_psymtabs): Move from psymtab.h.  Update.
3276         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3277         psymbol_cache.
3278         (objfile::~objfile): Don't destroy psymbol_cache.
3279         * mdebugread.c (parse_partial_symbols): Update.
3280         * dwarf2read.c (create_addrmap_from_index)
3281         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3282         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3283         (add_partial_subprogram, dwarf2_ranges_read): Update.
3284         * dwarf-index-write.c (write_address_map)
3285         (write_one_signatured_type, recursively_write_psymbols)
3286         (class debug_names, class debug_names, write_psymtabs_to_index):
3287         Update.
3288
3289 2019-01-10  Tom Tromey  <tom@tromey.com>
3290
3291         * symtab.h (SYMBOL_SET_NAMES): Update.
3292         (symbol_set_names): Update.
3293         (MSYMBOL_SET_NAMES): Update.
3294         * symtab.c (symbol_set_names): Change argument to be an
3295         objfile_per_bfd_storage.
3296         * psymtab.c (add_psymbol_to_bcache): Update.
3297         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3298
3299 2019-01-10  Tom Tromey  <tom@tromey.com>
3300
3301         * symtab.c (create_demangled_names_hash): Change argument to be an
3302         objfile_per_bfd_storage.
3303         (symbol_set_names): Update.
3304
3305 2019-01-10  Tom Tromey  <tom@tromey.com>
3306
3307         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3308         init_psymbol_list.
3309         * psymtab.c (init_psymbol_list): Do nothing if already called.
3310         * psympriv.h (init_psymbol_list): Add comment.
3311         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3312         init_psymbol_list.
3313         * dbxread.c (dbx_symfile_read): Unconditionally call
3314         init_psymbol_list.
3315
3316 2019-01-10  Tom Tromey  <tom@tromey.com>
3317
3318         * xcoffread.c (scan_xcoff_symtab): Update.
3319         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3320         "where".
3321         * mdebugread.c (parse_partial_symbols)
3322         (handle_psymbol_enumerators): Update.
3323         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3324         * dbxread.c (read_dbx_symtab): Update.
3325         * psympriv.h (psymbol_placement): New enum.
3326         (add_psymbol_to_list): Update.
3327
3328 2019-01-10  Tom Tromey  <tom@tromey.com>
3329
3330         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3331         static_psymbols parameters.
3332         (scan_xcoff_symtab): Update.
3333         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3334         static_psymbols parameters.
3335         * psympriv.h (start_psymtab_common): Update.
3336         * mdebugread.c (parse_partial_symbols): Update.
3337         * dwarf2read.c (create_partial_symtab): Update.
3338         * dbxread.c (read_dbx_symtab): Update.
3339         (start_psymtab): Remove global_psymbols and static_psymbols
3340         parameters.
3341
3342 2019-01-10  Tom Tromey  <tom@tromey.com>
3343
3344         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3345         * psymtab.c (allocate_psymtab): Add comment.
3346         * psympriv.h (allocate_psymtab): Add comment.
3347         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3348         initializations.
3349         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3350
3351 2019-01-10  Tom Tromey  <tom@tromey.com>
3352
3353         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3354         Don't declare.
3355         * mipsread.c: Include mdebugread.h.
3356         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3357         Declare.
3358         * elfread.c: Include mdebugread.h.
3359
3360 2019-01-09  Tom Tromey  <tom@tromey.com>
3361
3362         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3363         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3364         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3365         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3366         (psym_lookup_symbol, psym_find_last_source_symtab)
3367         (psym_forget_cached_source_info, psym_print_stats)
3368         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3369         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3370         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3371         (psym_find_compunit_symtab_by_address)
3372         (maintenance_print_psymbols, maintenance_info_psymtabs)
3373         (maintenance_check_psymtabs): Use ranged for.
3374         * psymtab.h (class objfile_psymtabs): New.
3375         (require_partial_symbols): Return objfile_psymtabs.
3376         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3377
3378 2019-01-09  Tom Tromey  <tom@tromey.com>
3379
3380         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3381         (find_pc_mapped_section, list_overlays_command)
3382         (map_overlay_command, unmap_overlay_command)
3383         (simple_overlay_update): Use all_objfiles.
3384         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3385         * printcmd.c (info_symbol_command): Use all_objfiles.
3386         * objfiles.h (ALL_OBJSECTIONS): Remove.
3387         * maint.c (maintenance_translate_address): Use all_objfiles.
3388         * gcore.c (gcore_create_callback): Use all_objfiles.
3389         (objfile_find_memory_regions): Likewise.
3390
3391 2019-01-09  Tom Tromey  <tom@tromey.com>
3392
3393         * symtab.c (find_line_symtab, info_sources_command)
3394         (make_source_files_completion_list): Use objfile_compunits.
3395         * source.c (select_source_symtab): Use objfile_compunits.
3396         * objfiles.h (struct objfile): Update comment.
3397         (ALL_OBJFILES): Remove.
3398         (ALL_FILETABS): Remove.
3399         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3400         objfile_compunits.
3401
3402 2019-01-09  Tom Tromey  <tom@tromey.com>
3403
3404         * symmisc.c (print_objfile_statistics, dump_objfile)
3405         (maintenance_print_symbols): Use compunit_filetabs.
3406         * source.c (forget_cached_source_info_for_objfile): Use
3407         compunit_filetabs.
3408         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3409         (ALL_FILETABS): Use compunit_filetabs.
3410         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3411         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3412
3413 2019-01-09  Tom Tromey  <tom@tromey.com>
3414
3415         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3416         (compunit_filetabs): New.
3417         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3418         compunit_filetabs.
3419         (info_sources_command, make_source_files_completion_list): Remove
3420         declaration.
3421         * symmisc.c (print_objfile_statistics, dump_objfile)
3422         (maintenance_print_symbols): Remove declaration.
3423         (maintenance_info_symtabs): Use compunit_filetabs.
3424         (maintenance_info_line_tables): Likewise.
3425         * source.c (select_source_symtab): Change local variable name.
3426         (forget_cached_source_info_for_objfile): Remove declaration.
3427         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3428         * objfiles.c (objfile_relocate1): Remove declaration.
3429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3430         declaration.
3431         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3432         * coffread.c (coff_symtab_read): Remove declaration.
3433         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3434         compunit_filetabs.
3435
3436 2019-01-09  Tom Tromey  <tom@tromey.com>
3437
3438         * symtab.c (lookup_objfile_from_block)
3439         (find_pc_sect_compunit_symtab, search_symbols)
3440         (default_collect_symbol_completion_matches_break_on): Use
3441         objfile_compunits.
3442         * objfiles.h (ALL_COMPUNITS): Remove.
3443         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3444         * cp-support.c (add_symbol_overload_list_qualified): Use
3445         objfile_compunits.
3446         * ada-lang.c (ada_collect_symbol_completion_matches)
3447         (ada_add_global_exceptions): Use objfile_compunits.
3448
3449 2019-01-09  Tom Tromey  <tom@tromey.com>
3450
3451         * source.c (select_source_symtab)
3452         (forget_cached_source_info_for_objfile): Remove declaration.
3453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3454         declaration.
3455         * maint.c (count_symtabs_and_blocks): Remove declaration.
3456         * cp-support.c (add_symbol_overload_list_qualified): Remove
3457         declaration.
3458         * coffread.c (coff_symtab_read): Remove declaration.
3459         * symtab.c (lookup_symbol_in_objfile_symtabs)
3460         (basic_lookup_transparent_type_1): Use objfile_compunits.
3461         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3462         (info_sources_command, search_symbols)
3463         (default_collect_symbol_completion_matches_break_on)
3464         (make_source_files_completion_list): Remove declaration.
3465         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3466         (ada_collect_symbol_completion_matches)
3467         (ada_add_global_exceptions): Remove declaration.
3468         * linespec.c (iterate_over_all_matching_symtabs): Use
3469         objfile_compunits.
3470         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3471         (class objfile_compunits): New.
3472         (ALL_COMPUNITS): Use objfile_compunits.
3473         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3474         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3475         objfile_compunits.
3476         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3477
3478 2019-01-09  Tom Tromey  <tom@tromey.com>
3479
3480         * symtab.c (search_symbols)
3481         (default_collect_symbol_completion_matches_break_on): Use
3482         objfile_msymbols.
3483         * ada-lang.c (ada_lookup_simple_minsym)
3484         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3485         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3486         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3487         objfile_msymbols.
3488         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3489         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3490         * objc-lang.c (find_methods): Use objfile_msymbols.
3491         (info_selectors_command, info_classes_command): Likewise.
3492         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3493         * objfiles.h (class objfile_msymbols): New.
3494         (ALL_OBJFILE_MSYMBOLS): Remove.
3495         (ALL_MSYMBOLS): Remove.
3496
3497 2019-01-09  Tom Tromey  <tom@tromey.com>
3498
3499         * common/next-iterator.h (next_adapter): Add Iterator template
3500         parameter.
3501         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3502         (class all_objfiles_safe): New.
3503         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3504         * objfiles.c (put_objfile_before): Update comment.
3505         (add_separate_debug_objfile): Likewise.
3506         (free_all_objfiles): Use all_objfiles_safe.
3507         (objfile_purge_solibs): Likewise.
3508
3509 2019-01-09  Tom Tromey  <tom@tromey.com>
3510
3511         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3512         (expand_symtab_containing_pc, lookup_static_symbol)
3513         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3514         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3515         all_objfiles.
3516         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3517         * breakpoint.c (create_overlay_event_breakpoint)
3518         (create_longjmp_master_breakpoint)
3519         (create_std_terminate_master_breakpoint)
3520         (create_exception_master_breakpoint): Use all_objfiles.
3521         * linux-thread-db.c (try_thread_db_load_from_pdir)
3522         (has_libpthread): Use all_objfiles.
3523         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3524         * linespec.c (iterate_over_all_matching_symtabs)
3525         (search_minsyms_for_name): Use all_objfiles.
3526         * maint.c (maintenance_info_sections): Use all_objfiles.
3527         * main.c (captured_main_1): Use all_objfiles.
3528         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3529         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3530         * guile/scm-pretty-print.c
3531         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3532         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3533         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3534         (maintenance_print_msymbols): Use all_objfiles.
3535         * source.c (select_source_symtab): Use all_objfiles.
3536         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3537         * symfile.c (remove_symbol_file_command)
3538         (expand_symtabs_matching, map_symbol_filenames): Use
3539         all_objfiles.
3540         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3541         all_objfiles.
3542         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3543         * objc-lang.c (find_methods): Use all_objfiles.
3544         * objfiles.c (have_partial_symbols, have_full_symbols)
3545         (have_minimal_symbols, qsort_cmp)
3546         (default_iterate_over_objfiles_in_search_order): Use
3547         all_objfiles.
3548         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3549         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3550         (maintenance_check_psymtabs): Use all_objfiles.
3551         (ALL_PSYMTABS): Remove.
3552         * compile/compile-object-run.c (do_module_cleanup): Use
3553         all_objfiles.
3554         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3555         * cp-support.c (add_symbol_overload_list_qualified): Use
3556         all_objfiles.
3557         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3558         Use all_objfiles.
3559         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3560         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3561         all_objfiles.
3562         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3563         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3564         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3565         Uses all_objfiles.
3566         * solib.c (solib_read_symbols): Use all_objfiles
3567
3568 2019-01-09  Tom Tromey  <tom@tromey.com>
3569
3570         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3571         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3572         all_objfiles.
3573         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3574         * symmisc.c (print_symbol_bcache_statistics)
3575         (print_objfile_statistics, maintenance_print_objfiles)
3576         (maintenance_info_symtabs, maintenance_check_symtabs)
3577         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3578         all_objfiles.
3579         * source.c (forget_cached_source_info): Use all_objfiles.
3580         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3581         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3582         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3583         * objfiles.c (update_section_map): Use all_objfiles.
3584         (shared_objfile_contains_address_p): Likewise.
3585         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3586         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3587
3588 2019-01-09  Tom Tromey  <tom@tromey.com>
3589
3590         * common/next-iterator.h: New file.
3591         * objfiles.h (class all_objfiles): New.
3592         (struct objfile_iterator): New.
3593
3594 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3595
3596         * NEWS: Move the description of the changed "frame", "select-frame",
3597          and "info frame" commands to the Changed commands section.
3598
3599 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3600
3601         * gdbtypes.c (check_stub_method_group): Remove handling of old
3602         mangling schemes.
3603         * linespec.c (find_methods): Likewise.
3604         * stabsread.c (read_member_functions): Likewise.
3605         * valops.c (search_struct_method): Likewise.
3606         (value_struct_elt_for_reference): Likewise.
3607         * NEWS: Mention this change.
3608
3609 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3612         print_source_lines.
3613         * source.c (print_source_lines_base): Update line number check.
3614         (print_source_lines): New function.
3615         (source_lines_range::source_lines_range): New function.
3616         * source.h (class source_lines_range): New class.
3617         (print_source_lines): New declaration.
3618
3619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3620
3621         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3622
3623 2019-01-08  Tom Tromey  <tom@tromey.com>
3624             Simon Marchi  <simon.marchi@ericsson.com>
3625
3626         PR gdb/24060
3627         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3628         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3629         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3630         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3631         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3632         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3633
3634 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * source.c (select_source_symtab): Move header comment to
3637         declaration in source.h.
3638         (forget_cached_source_info_for_objfile): Likewise.
3639         (forget_cached_source_info): Likewise.
3640         (identify_source_line): Likewise.
3641         * source.h (identify_source_line): Move declaration from symtab.h
3642         and add comment from source.c
3643         (print_source_lines): Likewise.
3644         (forget_cached_source_info_for_objfile): Likewise.
3645         (forget_cached_source_info): Likewise.
3646         (select_source_symtab): Likewise.
3647         (enum print_source_lines_flag): Move definition from symtab.h.
3648         * symtab.h (identify_source_line): Move declaration to source.h.
3649         (print_source_lines): Likewise.
3650         (forget_cached_source_info_for_objfile): Likewise.
3651         (forget_cached_source_info): Likewise.
3652         (select_source_symtab): Likewise.
3653         (enum print_source_lines_flag): Move definition to source.h.
3654         * tui/tui-hooks.c: Add 'source.h' include.
3655
3656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3657
3658         * source.c (print_source_lines_base): Handle requests to print
3659         reverse line number sequences, and guard against empty lines
3660         string.
3661
3662 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3663
3664         * source.c (print_source_lines_base): Fix skip of '\r' if next
3665         character is '\n'.
3666
3667 2019-01-06  Tom Tromey  <tom@tromey.com>
3668
3669         * c-exp.y (struct c_parse_state) <macro_original_text,
3670         expansion_obstack>: New member.
3671         (macro_original_text, expansion_obstack): Remove globals.
3672         (scan_macro_expansion, scanning_macro_expansion)
3673         (finished_macro_expansion): Update.
3674         (scan_macro_cleanup): Remove.
3675         (yylex, c_parse): Update.
3676
3677 2019-01-06  Tom Tromey  <tom@tromey.com>
3678
3679         * c-exp.y (struct c_parse_state) <strings>: New member.
3680         (operator_stoken): Update.
3681
3682 2019-01-06  Tom Tromey  <tom@tromey.com>
3683
3684         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3685         (union type_stack_elt) <typelist_val>: Now a pointer to
3686         std::vector.
3687         (type_stack_cleanup): Don't declare.
3688         (push_typelist): Update.
3689         * parse.c (pop_typelist): Return a std::vector.
3690         (push_typelist): Take a std::vector.
3691         (follow_types): Update.  Do not free args.
3692         (type_stack_cleanup): Remove.
3693         * c-exp.y (struct c_parse_state): New.
3694         (cpstate): New global.
3695         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3696         (nonempty_typelist): Update.
3697         (func_mod): Create a new vector.
3698         (c_parse): Create a c_parse_state.
3699         (check_parameter_typelist): Do not delete params.
3700         (function_method): Update.  Do not delete type_list.
3701
3702 2019-01-06  Tom Tromey  <tom@tromey.com>
3703
3704         PR gdb/28155:
3705         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3706         check_typedef.
3707         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3708         (print_return_value): Likewise.
3709
3710 2019-01-05  Tom Tromey  <tom@tromey.com>
3711
3712         * contrib/cleanup_check.py: Remove.
3713         * contrib/gcc-with-excheck: Remove.
3714         * contrib/exsummary.py: Remove.
3715         * contrib/excheck.py: Remove.
3716
3717 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3718
3719         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3720         NULL. Initialize tpprev to NULL instead of assigning it
3721         to NULL on the next statement.
3722         * windows-nat.c (windows_delete_thread): Remove check for
3723         main_thread_id before printing thread exit notifications.
3724         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3725         Remove thread ID check against main_thread_id.
3726         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3727         windows_delete_thread.
3728         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3729
3730 2019-01-04  Tom Tromey  <tom@tromey.com>
3731
3732         * compile/compile.c (_initialize_compile): Use upper case for
3733         metasyntactic variables.
3734         * symmisc.c (_initialize_symmisc): Use upper case for
3735         metasyntactic variables.
3736         * psymtab.c (_initialize_psymtab): Use upper case for
3737         metasyntactic variables.
3738         * demangle.c (demangle_command): Use upper case for metasyntactic
3739         variables.
3740         (_initialize_demangler): Likewise.
3741         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3742         variables.
3743
3744 2019-01-03  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3747
3748 2019-01-03  Tom Tromey  <tom@tromey.com>
3749
3750         * python/py-symtab.c (salpy_str): Update.
3751         (struct salpy_sal_object) <symtab>: Now a PyObject.
3752         (salpy_dealloc): Update.
3753         (del_objfile_sal): Use gdbpy_ref.
3754
3755 2019-01-03  Tom Tromey  <tom@tromey.com>
3756
3757         * python/py-type.c (convert_field): Use new_reference.  Return
3758         gdbpy_ref.
3759         (make_fielditem): Return gdbpy_ref.
3760         (typy_fields): Update.
3761         (typy_getitem): Update.
3762         (field_name): Return gdbpy_ref.  Use new_reference.
3763         (typy_iterator_iternext): Update.
3764
3765 2019-01-03  Tom Tromey  <tom@tromey.com>
3766
3767         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3768
3769 2019-01-03  Tom Tromey  <tom@tromey.com>
3770
3771         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3772         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3773         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3774         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3775         (pspy_set_type_printers): Likewise.
3776         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3777         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3778         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3779         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3780         (objfpy_set_type_printers): Likewise.
3781
3782 2019-01-03  Tom Tromey  <tom@tromey.com>
3783
3784         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3785         (gdbpy_print_stack): Use gdbpy_err_fetch.
3786         * python/python-internal.h (class gdbpy_err_fetch): New class.
3787         (class gdbpy_enter) <m_error_type, m_error_value,
3788         m_error_traceback>: Remove.
3789         <m_error>: New member.
3790         (gdbpy_exception_to_string): Don't declare.
3791         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3792         * python/py-value.c (convert_value_from_python): Use
3793         gdbpy_err_fetch.
3794         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3795         gdbpy_exception_to_string.
3796         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3797         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3798         gdbpy_err_fetch.
3799
3800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * linux-nat.c (delete_lwp_cleanup): Delete.
3803         (struct lwp_deleter): New struct.
3804         (lwp_info_up): New typedef.
3805         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3806         lwp_info_up.
3807
3808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3809
3810         * linux-fork.c (class scoped_switch_fork_info): New class.
3811         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3812
3813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * valops.c (find_overload_match): Remove use of null_cleanup, and
3816         calls to do_cleanups.
3817
3818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * compile/compile-cplus-types.c
3821         (compile_cplus_instance::decl_name): Handle changes to
3822         cp_func_name.
3823         * cp-support.c (cp_func_name): Update header comment, update
3824         return type.
3825         * cp-support.h (cp_func_name): Update return type in declaration.
3826         * valops.c (find_overload_match): Move temp_func local to top
3827         level of function and change its type.  Use temp_func to hold and
3828         delete temporary string obtained from cp_func_name.
3829
3830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3833         gdb::char_vector, remove cleanup, and update uses of `msg`.
3834
3835 2019-01-03  Jim Wilson  <jimw@sifive.com>
3836
3837         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3838
3839 2019-01-02  Tom Tromey  <tom@tromey.com>
3840
3841         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3842         (tdesc_parse_xml): Remove cleanups.
3843         * target-descriptions.h (make_cleanup_free_target_description):
3844         Don't declare.
3845         (target_desc_deleter): New struct.
3846         (target_desc_up): New typedef.
3847         * target-descriptions.c (target_desc_deleter::operator()): Rename
3848         from free_target_description.
3849         (make_cleanup_free_target_description): Remove.
3850
3851 2019-01-02  Tom Tromey  <tom@tromey.com>
3852
3853         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3854         constructor, destructor.
3855         (linespec_parser): Remove typedef.
3856         (~linespec_parser): Rename from linespec_parser_delete.
3857         (linespec_lex_to_end, linespec_complete_label)
3858         (linespec_complete): Update.
3859         (decode_line_full): Remove cleanups.
3860         (decode_line_1): Update.
3861
3862 2019-01-02  Tom Tromey  <tom@tromey.com>
3863
3864         * python/python-internal.h (inferior_to_inferior_object): Change
3865         return type.
3866         * python/py-exitedevent.c (create_exited_event_object): Update.
3867         * python/py-inferior.c (inferior_to_inferior_object): Return
3868         gdbpy_ref.
3869         (python_new_inferior, python_inferior_deleted)
3870         (thread_to_thread_object, delete_thread_object)
3871         (build_inferior_list, gdbpy_selected_inferior): Update.
3872         * python/py-infthread.c (create_thread_object): Update.  Also fail
3873         if inferior_to_inferior_object fails.
3874
3875 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3876
3877         * inferior.h (class inferior) <displaced_step_state>: New field.
3878         * infrun.h (struct displaced_step_state): Move here from
3879         infrun.c.  Initialize fields, add constructor.
3880         <inf>: Remove field.
3881         <reset>: New method.
3882         * infrun.c (struct displaced_step_inferior_state): Move to
3883         infrun.h.
3884         (displaced_step_inferior_states): Remove.
3885         (get_displaced_stepping_state): Adust.
3886         (displaced_step_in_progress_any_inferior): Adjust.
3887         (displaced_step_in_progress_thread): Adjust.
3888         (displaced_step_in_progress): Adjust.
3889         (add_displaced_stepping_state): Remove.
3890         (get_displaced_step_closure_by_addr): Adjust.
3891         (remove_displaced_stepping_state): Remove.
3892         (infrun_inferior_exit): Call displaced_step_state.reset.
3893         (use_displaced_stepping): Don't check for NULL.
3894         (displaced_step_prepare_throw): Call
3895         get_displaced_stepping_state.
3896         (displaced_step_fixup): Don't check for NULL.
3897         (prepare_for_detach): Don't check for NULL.
3898
3899 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3900
3901         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3902          in case of call that did not complete.
3903
3904 2019-01-02  Andrey Utkin  <autkin@undo.io>
3905
3906         * symfile.c (find_separate_debug_file): Fix search of debug files for
3907         remote debuggee.
3908
3909 2019-01-02  Tom Tromey  <tom@tromey.com>
3910
3911         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3912         indentation.
3913         * python/py-frame.c (frapy_older): Remove cast.
3914         (frapy_newer): Likewise.
3915         * python/py-breakpoint.c (local_setattro): Remove cast.
3916         * python/py-arch.c (archpy_name): Remove local variable.
3917         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3918
3919 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3920
3921         * unittests/basic_string_view/element_access/char/empty.cc:
3922         Fix year range in copyright header.
3923
3924 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3927         Delete.
3928         <operator==>: Update with for removed field.
3929         <hash>: Likewise.
3930         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3931         <isa_features>: ...this.
3932         <abi_features>: New field.
3933         (riscv_isa_flen): Update comment.
3934         (riscv_abi_xlen): New declaration.
3935         (riscv_abi_flen): New declaration.
3936         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3937         isa_features.
3938         (riscv_abi_xlen): New function.
3939         (riscv_isa_flen): Update to get answer from isa_features.
3940         (riscv_abi_flen): New function.
3941         (riscv_has_fp_abi): Update to get answer from abi_features.
3942         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3943         xlen and flen.
3944         (riscv_call_info) <xlen, flen>: Update comment.
3945         (riscv_call_arg_struct): Remove invalid assertions
3946         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3947         is removed.
3948         (riscv_gdbarch_init): Gather isa features and abi features
3949         separately, ensure both match on the gdbarch when reusing an old
3950         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3951         a target with 64-bit float hardware.
3952
3953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3954
3955         * source.c (search_command_helper): Stop reverse search
3956         when line 1 has been searched.
3957
3958 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3959
3960         * record-full.c (record_full_base_target::close): Rewrite
3961         record_full_core_buf_list free logic.
3962
3963 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3964
3965         * break-catch-syscall.c (print_one_catch_syscall): xfree
3966         the last text.
3967
3968 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3969
3970         * top.c (print_gdb_version): Update Copyright year in version
3971         message.
3972
3973 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3974
3975         Update copyright year range in all GDB files.
3976
3977 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3978
3979         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3980
3981 For older changes see ChangeLog-2018.
3982 \f
3983 Local Variables:
3984 mode: change-log
3985 left-margin: 8
3986 fill-column: 74
3987 version-control: never
3988 coding: utf-8
3989 End:
3990