gdbserver: Move remote_debug to a single place
[external/binutils.git] / gdb / ChangeLog
1 2019-04-17  Jim Wilson  <jimw@sifive.com>
2             Andrew Burgess  <andrew.burgess@embecosm.com>
3
4         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5         code read might fail, assume 4-byte breakpoint in that case.
6
7 2019-04-15  Leszek Swirski  <leszeks@google.com>
8
9         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10         rather than a hand-rolled POD check when checking for forced MEMORY
11         classification.
12
13 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
14
15         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
16         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
17         function.
18         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
19         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
20         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
21         declaration.
22
23 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
24
25         * aarch64-linux-nat.c
26         (aarch64_linux_nat_target::thread_architecture): Add override.
27         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
28         each VQ.
29
30 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
31
32         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
33
34 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
35
36         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
37         target types of size 96-bits, add some additional comments, and
38         check that the builtin type we found was the correct size.
39
40 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
41
42         * utils.c (prompt_for_continue): Don't restore the styling at the
43         end, as applied_style has the wrong value.  This fixes styling in
44         long lists of file names that are interrupted by the "Continue?"
45         prompt.
46
47 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
48
49         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
50         * c-lang.c (c_language_defn): Likewise.
51         (cplus_language_defn): Likewise.
52         (asm_language_defn): Likewise.
53         (minimal_language_defn): Likewise.
54         * d-lang.c (d_language_defn): Likewise.
55         * f-lang.c (f_language_defn): Likewise.
56         * go-lang.c (go_language_defn): Likewise.
57         * language.c (unknown_language_defn): Likewise.
58         (auto_language_defn): Likewise.
59         * language.h (struct language_defn): Remove la_magic field.
60         (LANG_MAGIC): Delete.
61         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
62         * objc-lang.c (objc_language_defn): Likewise.
63         * opencl-lang.c (opencl_language_defn): Likewise.
64         * p-lang.c (pascal_language_defn): Likewise.
65         * rust-lang.c (rust_language_defn): Likewise.
66
67 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
68
69         * riscv-tdep.c (riscv_type_align): New function.
70         (riscv_type_alignment): Delete.
71         (riscv_arg_location): Use 'type_align'.
72         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
73
74 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
75
76         * gdbtypes.c (type_align): A struct with no non-static fields also
77         has alignment of 1.
78
79 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
80
81         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
82         component to 0.
83         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
84         member.
85         (riscv_struct_info::analyse): New implementation using new
86         analyse_inner member function.
87         (riscv_struct_info::field_offset): New member function.
88         (riscv_struct_info::m_offsets): New member variable.
89         (riscv_struct_info::analyse_inner): New private member function,
90         takes the old implementation of riscv_struct_info::analyse but
91         extended to track field offsets.
92         (riscv_call_arg_struct): Update the struct folding special cases
93         to handle cases where empty C++ structs, which are non-zero
94         length, are found.
95         (riscv_arg_location): Initialise the length of each location, a
96         non-zero length now indicates the location is in use.
97         (riscv_push_dummy_call): Allow for the first location having a
98         non-zero offset when setting up arguments.
99         (riscv_return_value): Likewise, but for return values.
100
101 2019-04-11  Tom Tromey  <tromey@adacore.com>
102
103         * utils.c (internal_vproblem): Make "msg" const.
104
105 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
106
107         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
108         * trad-frame.c (trad_frame_reset_saved_regs): New function.
109         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
110         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
111
112 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
113
114         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
115         function.
116         (fill_gregset): Call amd64_linux_collect_native_gregset instead
117         of amd64_collect_native_gregset.
118         (amd64_linux_nat_target::store_registers): Likewise.
119
120 2019-04-10  Tom Tromey  <tom@tromey.com>
121
122         * symtab.c (lookup_global_symbol_from_objfile)
123         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
124         * objfiles.h (class separate_debug_iterator): New.
125         (class separate_debug_range): New.
126         (struct objfile) <separate_debug_objfiles>: New method.
127         (objfile_separate_debug_iterate): Don't declare.
128         * objfiles.c (separate_debug_iterator::operator++): Rename from
129         objfile_separate_debug_iterate.
130         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
131         iterator.
132         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
133         iterator.
134
135 2019-04-10  Tom Tromey  <tom@tromey.com>
136
137         * symfile.c (reread_symbols): Remove old comment.
138         * objfiles.c (free_all_objfiles): Fix a typo.
139
140 2019-04-10  Tom Tromey  <tom@tromey.com>
141
142         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
143         * minsyms.c (lookup_minimal_symbol): Use foreach.
144         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
145         (lookup_minimal_symbol_solib_trampoline): Likewise.
146         * symfile.c (reread_symbols): Use foreach.
147
148 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
149             Tom Tromey  <tromey@adacore.com>
150
151         PR rust/24414:
152         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
153         (rust_lex_int_test): Change "value" to be LONGEST.
154         (rust_lex_tests): Add test for long integer literal.
155
156 2019-04-09  Tom Tromey  <tromey@adacore.com>
157
158         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
159         to bool.
160         (extended_remote_target::attach): Update.
161         (remote_target::remote_notice_new_inferior): Update.
162         (remote_target::add_current_inferior_and_thread): Update.
163         * inferior.c (exit_inferior_1): Use "false".
164         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
165
166 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
167
168         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
169         the "start" command.
170
171 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
172
173         * python/py-inferior.c (infpy_thread_from_thread_handle):
174         Adjust comments to reflect renaming of thread_from_thread_handle
175         to thread_from_handle.  Adjust keywords.  Fix type error message.
176         (inferior_object_methods): Add thread_from_handle.  Retain
177         thread_from_thread_handle, but mark it as deprecated.
178
179 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
180
181         * gdbthread.h (find_thread_by_handle): Revise declaration.
182         * thread.c (find_thread_by_handle): Likewise.  Adjust
183         implementation too.
184         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
185         support for buffer objects as handles.
186
187 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
188
189         * python/py-infthread.c (thpy_thread_handle): New function.
190         (thread_object_methods): Register thpy_thread_handle.
191
192 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
193
194         * gdbthread.h (thread_to_thread_handle): Declare.
195         * thread.c (gdbtypes.h): Include.
196         (thread_to_thread_handle): New function.
197
198         * target.h (struct target_ops): Add thread_info_to_thread_handle.
199         (target_thread_info_to_thread_handle): Declare.
200         * target.c (target_thread_info_to_thread_handle): New function.
201         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
202         * target-delegates.c: Regenerate.
203
204         * linux-thread-db.c (class thread_db_target): Add method
205         thread_info_to_thread_handle.
206         (thread_db_target::thread_info_to_thread_handle): Define.
207         * remote.c (class remote_target): Add new method
208         thread_info_to_thread_handle.
209         (remote_target::thread_info_to_thread_handle): Define.
210
211 2019-04-08  Pedro Alves  <palves@redhat.com>
212
213         * common/common-exceptions.c (throw_exception): Don't create
214         named object to throw; throw directly.
215         (throw_it): Likewise.  Don't initialize gdb_exception::message
216         here, with new; pass FMT and AP to the ctor instead.
217         * common/common-exceptions.h: Include <string>.
218         (gdb_exception::gdb_exception(enum return_reason, enum errors,
219         const char *, va_list)): New ctor.  Use std::make_shared.
220         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
221         errors)): Delete.
222         (gdb_exception_error::gdb_exception_error(enum errors, const char
223         *, va_list)): New.
224         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
225         Add assertion.
226         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
227         errors)): Delete.
228         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
229         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
230         Add assertion.
231
232 2019-04-08  Tom Tromey  <tom@tromey.com>
233
234         * valops.c (value_rtti_indirect_type): Replace throw_exception
235         with throw.
236         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
237         with throw.
238         * thread.c (thr_try_catch_cmd): Replace throw_exception with
239         throw.
240         * target.c (target_translate_tls_address): Replace throw_exception
241         with throw.
242         * stack.c (frame_apply_command_count): Replace throw_exception
243         with throw.
244         * solib-spu.c (append_ocl_sos): Replace throw_exception with
245         throw.
246         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
247         with throw.
248         * rs6000-tdep.c (rs6000_frame_cache)
249         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
250         * remote.c: Replace throw_exception with throw.
251         * record-full.c (record_full_message, record_full_wait_1)
252         (record_full_restore): Replace throw_exception with throw.
253         * record-btrace.c:
254         (get_thread_current_frame_id, record_btrace_start_replaying)
255         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
256         (cmd_record_btrace_start): Replace throw_exception with throw.
257         * parse.c (parse_exp_in_context_1): Replace throw_exception with
258         throw.
259         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
260         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
261         * linespec.c:
262         (find_linespec_symbols): Replace throw_exception with throw.
263         * infrun.c (displaced_step_prepare, resume): Replace
264         throw_exception with throw.
265         * infcmd.c (post_create_inferior): Replace throw_exception with
266         throw.
267         * inf-loop.c (inferior_event_handler): Replace throw_exception
268         with throw.
269         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
270         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
271         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
272         (get_prev_frame_always, get_frame_pc_if_available)
273         (get_frame_address_in_block_if_available, get_frame_language):
274         Replace throw_exception with throw.
275         * frame-unwind.c (frame_unwind_try_unwinder): Replace
276         throw_exception with throw.
277         * eval.c (fetch_subexp_value, evaluate_var_value)
278         (evaluate_funcall, evaluate_subexp_standard): Replace
279         throw_exception with throw.
280         * dwarf2loc.c (call_site_find_chain)
281         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
282         Replace throw_exception with throw.
283         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
284         with throw.
285         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
286         throw.
287         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
288         * completer.c (complete_line_internal): Replace throw_exception
289         with throw.
290         * compile/compile-object-run.c (compile_object_run): Replace
291         throw_exception with throw.
292         * cli/cli-script.c (process_next_line): Replace throw_exception
293         with throw.
294         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
295         (btrace_enable, btrace_maint_update_pt_packets): Replace
296         throw_exception with throw.
297         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
298         throw_exception with throw.
299         * break-catch-throw.c (re_set_exception_catchpoint): Replace
300         throw_exception with throw.
301         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
302         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
303         * aarch64-tdep.c (aarch64_make_prologue_cache)
304         (aarch64_make_stub_cache): Replace throw_exception with throw.
305
306 2019-04-08  Tom Tromey  <tom@tromey.com>
307
308         * common/common-exceptions.c (throw_exception): Rename from
309         throw_exception_cxx.  Remove old copy.  Make argument const.
310         (throw_it): Create and throw exception objects directly.
311         * common/common-exceptions.h (throw_exception): Make argument
312         const.
313         (struct gdb_exception_error): Add constructor.
314         (struct gdb_exception_quit): Add constructor.
315
316 2019-04-08  Tom Tromey  <tom@tromey.com>
317
318         * common/common-exceptions.h (exception_rethrow): Don't declare.
319         (TRY_SJLJ): Update comment.
320         (TRY, CATCH, END_CATCH): Remove.
321         * common/common-exceptions.c (exception_rethrow): Remove.
322
323 2019-04-08  Tom Tromey  <tom@tromey.com>
324
325         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
326         Remove.
327         (gdb_exception_error): Rename from
328         gdb_exception_RETURN_MASK_ERROR.
329         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
330         (gdb_quit_bad_alloc): Update.
331         * aarch64-tdep.c: Update.
332         * ada-lang.c: Update.
333         * ada-typeprint.c: Update.
334         * ada-valprint.c: Update.
335         * amd64-tdep.c: Update.
336         * arch-utils.c: Update.
337         * break-catch-throw.c: Update.
338         * breakpoint.c: Update.
339         * btrace.c: Update.
340         * c-varobj.c: Update.
341         * cli/cli-cmds.c: Update.
342         * cli/cli-interp.c: Update.
343         * cli/cli-script.c: Update.
344         * common/common-exceptions.c: Update.
345         * common/new-op.c: Update.
346         * common/selftest.c: Update.
347         * compile/compile-c-symbols.c: Update.
348         * compile/compile-cplus-symbols.c: Update.
349         * compile/compile-object-load.c: Update.
350         * compile/compile-object-run.c: Update.
351         * completer.c: Update.
352         * corelow.c: Update.
353         * cp-abi.c: Update.
354         * cp-support.c: Update.
355         * cp-valprint.c: Update.
356         * darwin-nat.c: Update.
357         * disasm-selftests.c: Update.
358         * dtrace-probe.c: Update.
359         * dwarf-index-cache.c: Update.
360         * dwarf-index-write.c: Update.
361         * dwarf2-frame-tailcall.c: Update.
362         * dwarf2-frame.c: Update.
363         * dwarf2loc.c: Update.
364         * dwarf2read.c: Update.
365         * eval.c: Update.
366         * event-loop.c: Update.
367         * event-top.c: Update.
368         * exec.c: Update.
369         * f-valprint.c: Update.
370         * fbsd-tdep.c: Update.
371         * frame-unwind.c: Update.
372         * frame.c: Update.
373         * gdbtypes.c: Update.
374         * gnu-v3-abi.c: Update.
375         * guile/guile-internal.h: Update.
376         * guile/scm-block.c: Update.
377         * guile/scm-breakpoint.c: Update.
378         * guile/scm-cmd.c: Update.
379         * guile/scm-disasm.c: Update.
380         * guile/scm-frame.c: Update.
381         * guile/scm-lazy-string.c: Update.
382         * guile/scm-math.c: Update.
383         * guile/scm-param.c: Update.
384         * guile/scm-ports.c: Update.
385         * guile/scm-pretty-print.c: Update.
386         * guile/scm-symbol.c: Update.
387         * guile/scm-symtab.c: Update.
388         * guile/scm-type.c: Update.
389         * guile/scm-value.c: Update.
390         * i386-linux-tdep.c: Update.
391         * i386-tdep.c: Update.
392         * inf-loop.c: Update.
393         * infcall.c: Update.
394         * infcmd.c: Update.
395         * infrun.c: Update.
396         * jit.c: Update.
397         * language.c: Update.
398         * linespec.c: Update.
399         * linux-fork.c: Update.
400         * linux-nat.c: Update.
401         * linux-tdep.c: Update.
402         * linux-thread-db.c: Update.
403         * main.c: Update.
404         * mi/mi-cmd-break.c: Update.
405         * mi/mi-cmd-stack.c: Update.
406         * mi/mi-interp.c: Update.
407         * mi/mi-main.c: Update.
408         * objc-lang.c: Update.
409         * p-valprint.c: Update.
410         * parse.c: Update.
411         * ppc-linux-tdep.c: Update.
412         * printcmd.c: Update.
413         * python/py-arch.c: Update.
414         * python/py-breakpoint.c: Update.
415         * python/py-cmd.c: Update.
416         * python/py-finishbreakpoint.c: Update.
417         * python/py-frame.c: Update.
418         * python/py-framefilter.c: Update.
419         * python/py-gdb-readline.c: Update.
420         * python/py-inferior.c: Update.
421         * python/py-infthread.c: Update.
422         * python/py-lazy-string.c: Update.
423         * python/py-linetable.c: Update.
424         * python/py-objfile.c: Update.
425         * python/py-param.c: Update.
426         * python/py-prettyprint.c: Update.
427         * python/py-progspace.c: Update.
428         * python/py-record-btrace.c: Update.
429         * python/py-record.c: Update.
430         * python/py-symbol.c: Update.
431         * python/py-type.c: Update.
432         * python/py-unwind.c: Update.
433         * python/py-utils.c: Update.
434         * python/py-value.c: Update.
435         * python/python.c: Update.
436         * record-btrace.c: Update.
437         * record-full.c: Update.
438         * remote-fileio.c: Update.
439         * remote.c: Update.
440         * riscv-tdep.c: Update.
441         * rs6000-aix-tdep.c: Update.
442         * rs6000-tdep.c: Update.
443         * rust-exp.y: Update.
444         * rust-lang.c: Update.
445         * s390-tdep.c: Update.
446         * selftest-arch.c: Update.
447         * solib-dsbt.c: Update.
448         * solib-frv.c: Update.
449         * solib-spu.c: Update.
450         * solib-svr4.c: Update.
451         * solib.c: Update.
452         * sparc64-linux-tdep.c: Update.
453         * stack.c: Update.
454         * symfile-mem.c: Update.
455         * symmisc.c: Update.
456         * target.c: Update.
457         * thread.c: Update.
458         * top.c: Update.
459         * tracefile-tfile.c: Update.
460         * tui/tui.c: Update.
461         * typeprint.c: Update.
462         * unittests/cli-utils-selftests.c: Update.
463         * unittests/parse-connection-spec-selftests.c: Update.
464         * valops.c: Update.
465         * valprint.c: Update.
466         * value.c: Update.
467         * varobj.c: Update.
468         * windows-nat.c: Update.
469         * x86-linux-nat.c: Update.
470         * xml-support.c: Update.
471
472 2019-04-08  Tom Tromey  <tom@tromey.com>
473
474         * xml-support.c: Use C++ exception handling.
475         * x86-linux-nat.c: Use C++ exception handling.
476         * windows-nat.c: Use C++ exception handling.
477         * varobj.c: Use C++ exception handling.
478         * value.c: Use C++ exception handling.
479         * valprint.c: Use C++ exception handling.
480         * valops.c: Use C++ exception handling.
481         * unittests/parse-connection-spec-selftests.c: Use C++ exception
482         handling.
483         * unittests/cli-utils-selftests.c: Use C++ exception handling.
484         * typeprint.c: Use C++ exception handling.
485         * tui/tui.c: Use C++ exception handling.
486         * tracefile-tfile.c: Use C++ exception handling.
487         * top.c: Use C++ exception handling.
488         * thread.c: Use C++ exception handling.
489         * target.c: Use C++ exception handling.
490         * symmisc.c: Use C++ exception handling.
491         * symfile-mem.c: Use C++ exception handling.
492         * stack.c: Use C++ exception handling.
493         * sparc64-linux-tdep.c: Use C++ exception handling.
494         * solib.c: Use C++ exception handling.
495         * solib-svr4.c: Use C++ exception handling.
496         * solib-spu.c: Use C++ exception handling.
497         * solib-frv.c: Use C++ exception handling.
498         * solib-dsbt.c: Use C++ exception handling.
499         * selftest-arch.c: Use C++ exception handling.
500         * s390-tdep.c: Use C++ exception handling.
501         * rust-lang.c: Use C++ exception handling.
502         * rust-exp.y: Use C++ exception handling.
503         * rs6000-tdep.c: Use C++ exception handling.
504         * rs6000-aix-tdep.c: Use C++ exception handling.
505         * riscv-tdep.c: Use C++ exception handling.
506         * remote.c: Use C++ exception handling.
507         * remote-fileio.c: Use C++ exception handling.
508         * record-full.c: Use C++ exception handling.
509         * record-btrace.c: Use C++ exception handling.
510         * python/python.c: Use C++ exception handling.
511         * python/py-value.c: Use C++ exception handling.
512         * python/py-utils.c: Use C++ exception handling.
513         * python/py-unwind.c: Use C++ exception handling.
514         * python/py-type.c: Use C++ exception handling.
515         * python/py-symbol.c: Use C++ exception handling.
516         * python/py-record.c: Use C++ exception handling.
517         * python/py-record-btrace.c: Use C++ exception handling.
518         * python/py-progspace.c: Use C++ exception handling.
519         * python/py-prettyprint.c: Use C++ exception handling.
520         * python/py-param.c: Use C++ exception handling.
521         * python/py-objfile.c: Use C++ exception handling.
522         * python/py-linetable.c: Use C++ exception handling.
523         * python/py-lazy-string.c: Use C++ exception handling.
524         * python/py-infthread.c: Use C++ exception handling.
525         * python/py-inferior.c: Use C++ exception handling.
526         * python/py-gdb-readline.c: Use C++ exception handling.
527         * python/py-framefilter.c: Use C++ exception handling.
528         * python/py-frame.c: Use C++ exception handling.
529         * python/py-finishbreakpoint.c: Use C++ exception handling.
530         * python/py-cmd.c: Use C++ exception handling.
531         * python/py-breakpoint.c: Use C++ exception handling.
532         * python/py-arch.c: Use C++ exception handling.
533         * printcmd.c: Use C++ exception handling.
534         * ppc-linux-tdep.c: Use C++ exception handling.
535         * parse.c: Use C++ exception handling.
536         * p-valprint.c: Use C++ exception handling.
537         * objc-lang.c: Use C++ exception handling.
538         * mi/mi-main.c: Use C++ exception handling.
539         * mi/mi-interp.c: Use C++ exception handling.
540         * mi/mi-cmd-stack.c: Use C++ exception handling.
541         * mi/mi-cmd-break.c: Use C++ exception handling.
542         * main.c: Use C++ exception handling.
543         * linux-thread-db.c: Use C++ exception handling.
544         * linux-tdep.c: Use C++ exception handling.
545         * linux-nat.c: Use C++ exception handling.
546         * linux-fork.c: Use C++ exception handling.
547         * linespec.c: Use C++ exception handling.
548         * language.c: Use C++ exception handling.
549         * jit.c: Use C++ exception handling.
550         * infrun.c: Use C++ exception handling.
551         * infcmd.c: Use C++ exception handling.
552         * infcall.c: Use C++ exception handling.
553         * inf-loop.c: Use C++ exception handling.
554         * i386-tdep.c: Use C++ exception handling.
555         * i386-linux-tdep.c: Use C++ exception handling.
556         * guile/scm-value.c: Use C++ exception handling.
557         * guile/scm-type.c: Use C++ exception handling.
558         * guile/scm-symtab.c: Use C++ exception handling.
559         * guile/scm-symbol.c: Use C++ exception handling.
560         * guile/scm-pretty-print.c: Use C++ exception handling.
561         * guile/scm-ports.c: Use C++ exception handling.
562         * guile/scm-param.c: Use C++ exception handling.
563         * guile/scm-math.c: Use C++ exception handling.
564         * guile/scm-lazy-string.c: Use C++ exception handling.
565         * guile/scm-frame.c: Use C++ exception handling.
566         * guile/scm-disasm.c: Use C++ exception handling.
567         * guile/scm-cmd.c: Use C++ exception handling.
568         * guile/scm-breakpoint.c: Use C++ exception handling.
569         * guile/scm-block.c: Use C++ exception handling.
570         * guile/guile-internal.h: Use C++ exception handling.
571         * gnu-v3-abi.c: Use C++ exception handling.
572         * gdbtypes.c: Use C++ exception handling.
573         * frame.c: Use C++ exception handling.
574         * frame-unwind.c: Use C++ exception handling.
575         * fbsd-tdep.c: Use C++ exception handling.
576         * f-valprint.c: Use C++ exception handling.
577         * exec.c: Use C++ exception handling.
578         * event-top.c: Use C++ exception handling.
579         * event-loop.c: Use C++ exception handling.
580         * eval.c: Use C++ exception handling.
581         * dwarf2read.c: Use C++ exception handling.
582         * dwarf2loc.c: Use C++ exception handling.
583         * dwarf2-frame.c: Use C++ exception handling.
584         * dwarf2-frame-tailcall.c: Use C++ exception handling.
585         * dwarf-index-write.c: Use C++ exception handling.
586         * dwarf-index-cache.c: Use C++ exception handling.
587         * dtrace-probe.c: Use C++ exception handling.
588         * disasm-selftests.c: Use C++ exception handling.
589         * darwin-nat.c: Use C++ exception handling.
590         * cp-valprint.c: Use C++ exception handling.
591         * cp-support.c: Use C++ exception handling.
592         * cp-abi.c: Use C++ exception handling.
593         * corelow.c: Use C++ exception handling.
594         * completer.c: Use C++ exception handling.
595         * compile/compile-object-run.c: Use C++ exception handling.
596         * compile/compile-object-load.c: Use C++ exception handling.
597         * compile/compile-cplus-symbols.c: Use C++ exception handling.
598         * compile/compile-c-symbols.c: Use C++ exception handling.
599         * common/selftest.c: Use C++ exception handling.
600         * common/new-op.c: Use C++ exception handling.
601         * cli/cli-script.c: Use C++ exception handling.
602         * cli/cli-interp.c: Use C++ exception handling.
603         * cli/cli-cmds.c: Use C++ exception handling.
604         * c-varobj.c: Use C++ exception handling.
605         * btrace.c: Use C++ exception handling.
606         * breakpoint.c: Use C++ exception handling.
607         * break-catch-throw.c: Use C++ exception handling.
608         * arch-utils.c: Use C++ exception handling.
609         * amd64-tdep.c: Use C++ exception handling.
610         * ada-valprint.c: Use C++ exception handling.
611         * ada-typeprint.c: Use C++ exception handling.
612         * ada-lang.c: Use C++ exception handling.
613         * aarch64-tdep.c: Use C++ exception handling.
614
615 2019-04-08  Tom Tromey  <tom@tromey.com>
616
617         * xml-support.c (gdb_xml_parser::parse): Update.
618         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
619         * value.c (show_convenience): Update.
620         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
621         (test_parse_flags_qcs): Update.
622         * thread.c (thr_try_catch_cmd): Update.
623         * target.c (target_translate_tls_address): Update.
624         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
625         (info_frame_command_core, frame_apply_command_count): Update.
626         * rust-exp.y (rust_lex_exception_test): Update.
627         * riscv-tdep.c (riscv_print_one_register_info): Update.
628         * remote.c (remote_target::enable_btrace): Update.
629         * record-btrace.c (record_btrace_enable_warn): Update.
630         * python/py-utils.c (gdbpy_convert_exception): Update.
631         * printcmd.c (do_one_display, print_variable_and_value): Update.
632         * mi/mi-main.c (mi_print_exception): Update.
633         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
634         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
635         * linux-nat.c (linux_nat_target::attach): Update.
636         * linux-fork.c (class scoped_switch_fork_info): Update.
637         * infrun.c (displaced_step_prepare): Update.
638         * infcall.c (call_function_by_hand_dummy): Update.
639         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
640         * gnu-v3-abi.c (print_one_vtable): Update.
641         * frame.c (get_prev_frame_always): Update.
642         * f-valprint.c (info_common_command_for_block): Update.
643         * exec.c (try_open_exec_file): Update.
644         * exceptions.c (print_exception, exception_print)
645         (exception_fprintf, exception_print_same): Update.
646         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
647         * dwarf-index-cache.c (index_cache::store)
648         (index_cache::lookup_gdb_index): Update.
649         * darwin-nat.c (maybe_cache_shell): Update.
650         * cp-valprint.c (cp_print_value_fields): Update.
651         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
652         (gcc_cplus_symbol_address): Update.
653         * compile/compile-c-symbols.c (gcc_convert_symbol)
654         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
655         * common/selftest.c: Update.
656         * common/common-exceptions.h (struct gdb_exception) <message>: Now
657         a std::string.
658         (exception_try_scope_entry, exception_try_scope_exit): Don't
659         declare.
660         (struct exception_try_scope): Remove.
661         (TRY): Don't use exception_try_scope.
662         (struct gdb_exception): Add constructor, operator=.
663         <what>: New method.
664         (struct gdb_exception_RETURN_MASK_ALL)
665         (struct gdb_exception_RETURN_MASK_ERROR)
666         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
667         (struct gdb_quit_bad_alloc): Update.
668         * common/common-exceptions.c (exception_none): Change
669         initializer.
670         (struct catcher) <state, exception>: Initialize inline.
671         <prev>: Remove member.
672         (current_catcher): Remove.
673         (catchers): New global.
674         (exceptions_state_mc_init): Simplify.
675         (catcher_pop): Remove.
676         (exceptions_state_mc, exceptions_state_mc_catch): Update.
677         (try_scope_depth, exception_try_scope_entry)
678         (exception_try_scope_exit): Remove.
679         (throw_exception_sjlj): Update.
680         (exception_messages, exception_messages_size): Remove.
681         (throw_it): Simplify.
682         (gdb_exception_sliced_copy): Remove.
683         (throw_exception_cxx): Update.
684         * cli/cli-script.c (script_from_file): Update.
685         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
686         Update.
687         * ada-valprint.c (ada_val_print): Update.
688         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
689         (create_excep_cond_exprs): Update.
690
691 2019-04-08  Tom Tromey  <tom@tromey.com>
692
693         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
694         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
695         (TRY, CATCH, END_CATCH): Remove some definitions.
696         * common/common-exceptions.c: Don't use GDB_XCPT.
697         (catcher_list_size): Remove.
698         (throw_exception, throw_it): Simplify.
699
700 2019-04-05  Tom Tromey  <tom@tromey.com>
701
702         Revert the header-sorting patch.
703         * ft32-tdep.c: Revert.
704         * frv-tdep.c: Revert.
705         * frv-linux-tdep.c: Revert.
706         * frame.c: Revert.
707         * frame-unwind.c: Revert.
708         * frame-base.c: Revert.
709         * fork-child.c: Revert.
710         * findvar.c: Revert.
711         * findcmd.c: Revert.
712         * filesystem.c: Revert.
713         * filename-seen-cache.h: Revert.
714         * filename-seen-cache.c: Revert.
715         * fbsd-tdep.c: Revert.
716         * fbsd-nat.h: Revert.
717         * fbsd-nat.c: Revert.
718         * f-valprint.c: Revert.
719         * f-typeprint.c: Revert.
720         * f-lang.c: Revert.
721         * extension.h: Revert.
722         * extension.c: Revert.
723         * extension-priv.h: Revert.
724         * expprint.c: Revert.
725         * exec.h: Revert.
726         * exec.c: Revert.
727         * exceptions.c: Revert.
728         * event-top.c: Revert.
729         * event-loop.c: Revert.
730         * eval.c: Revert.
731         * elfread.c: Revert.
732         * dwarf2read.h: Revert.
733         * dwarf2read.c: Revert.
734         * dwarf2loc.c: Revert.
735         * dwarf2expr.h: Revert.
736         * dwarf2expr.c: Revert.
737         * dwarf2-frame.c: Revert.
738         * dwarf2-frame-tailcall.c: Revert.
739         * dwarf-index-write.h: Revert.
740         * dwarf-index-write.c: Revert.
741         * dwarf-index-common.c: Revert.
742         * dwarf-index-cache.h: Revert.
743         * dwarf-index-cache.c: Revert.
744         * dummy-frame.c: Revert.
745         * dtrace-probe.c: Revert.
746         * disasm.h: Revert.
747         * disasm.c: Revert.
748         * disasm-selftests.c: Revert.
749         * dictionary.c: Revert.
750         * dicos-tdep.c: Revert.
751         * demangle.c: Revert.
752         * dcache.h: Revert.
753         * dcache.c: Revert.
754         * darwin-nat.h: Revert.
755         * darwin-nat.c: Revert.
756         * darwin-nat-info.c: Revert.
757         * d-valprint.c: Revert.
758         * d-namespace.c: Revert.
759         * d-lang.c: Revert.
760         * ctf.c: Revert.
761         * csky-tdep.c: Revert.
762         * csky-linux-tdep.c: Revert.
763         * cris-tdep.c: Revert.
764         * cris-linux-tdep.c: Revert.
765         * cp-valprint.c: Revert.
766         * cp-support.c: Revert.
767         * cp-namespace.c: Revert.
768         * cp-abi.c: Revert.
769         * corelow.c: Revert.
770         * corefile.c: Revert.
771         * continuations.c: Revert.
772         * completer.h: Revert.
773         * completer.c: Revert.
774         * complaints.c: Revert.
775         * coffread.c: Revert.
776         * coff-pe-read.c: Revert.
777         * cli-out.h: Revert.
778         * cli-out.c: Revert.
779         * charset.c: Revert.
780         * c-varobj.c: Revert.
781         * c-valprint.c: Revert.
782         * c-typeprint.c: Revert.
783         * c-lang.c: Revert.
784         * buildsym.c: Revert.
785         * buildsym-legacy.c: Revert.
786         * build-id.h: Revert.
787         * build-id.c: Revert.
788         * btrace.c: Revert.
789         * bsd-uthread.c: Revert.
790         * breakpoint.h: Revert.
791         * breakpoint.c: Revert.
792         * break-catch-throw.c: Revert.
793         * break-catch-syscall.c: Revert.
794         * break-catch-sig.c: Revert.
795         * blockframe.c: Revert.
796         * block.c: Revert.
797         * bfin-tdep.c: Revert.
798         * bfin-linux-tdep.c: Revert.
799         * bfd-target.c: Revert.
800         * bcache.c: Revert.
801         * ax-general.c: Revert.
802         * ax-gdb.h: Revert.
803         * ax-gdb.c: Revert.
804         * avr-tdep.c: Revert.
805         * auxv.c: Revert.
806         * auto-load.c: Revert.
807         * arm-wince-tdep.c: Revert.
808         * arm-tdep.c: Revert.
809         * arm-symbian-tdep.c: Revert.
810         * arm-pikeos-tdep.c: Revert.
811         * arm-obsd-tdep.c: Revert.
812         * arm-nbsd-tdep.c: Revert.
813         * arm-nbsd-nat.c: Revert.
814         * arm-linux-tdep.c: Revert.
815         * arm-linux-nat.c: Revert.
816         * arm-fbsd-tdep.c: Revert.
817         * arm-fbsd-nat.c: Revert.
818         * arm-bsd-tdep.c: Revert.
819         * arch-utils.c: Revert.
820         * arc-tdep.c: Revert.
821         * arc-newlib-tdep.c: Revert.
822         * annotate.h: Revert.
823         * annotate.c: Revert.
824         * amd64-windows-tdep.c: Revert.
825         * amd64-windows-nat.c: Revert.
826         * amd64-tdep.c: Revert.
827         * amd64-sol2-tdep.c: Revert.
828         * amd64-obsd-tdep.c: Revert.
829         * amd64-obsd-nat.c: Revert.
830         * amd64-nbsd-tdep.c: Revert.
831         * amd64-nbsd-nat.c: Revert.
832         * amd64-nat.c: Revert.
833         * amd64-linux-tdep.c: Revert.
834         * amd64-linux-nat.c: Revert.
835         * amd64-fbsd-tdep.c: Revert.
836         * amd64-fbsd-nat.c: Revert.
837         * amd64-dicos-tdep.c: Revert.
838         * amd64-darwin-tdep.c: Revert.
839         * amd64-bsd-nat.c: Revert.
840         * alpha-tdep.c: Revert.
841         * alpha-obsd-tdep.c: Revert.
842         * alpha-nbsd-tdep.c: Revert.
843         * alpha-mdebug-tdep.c: Revert.
844         * alpha-linux-tdep.c: Revert.
845         * alpha-linux-nat.c: Revert.
846         * alpha-bsd-tdep.c: Revert.
847         * alpha-bsd-nat.c: Revert.
848         * aix-thread.c: Revert.
849         * agent.c: Revert.
850         * addrmap.c: Revert.
851         * ada-varobj.c: Revert.
852         * ada-valprint.c: Revert.
853         * ada-typeprint.c: Revert.
854         * ada-tasks.c: Revert.
855         * ada-lang.c: Revert.
856         * aarch64-tdep.c: Revert.
857         * aarch64-ravenscar-thread.c: Revert.
858         * aarch64-newlib-tdep.c: Revert.
859         * aarch64-linux-tdep.c: Revert.
860         * aarch64-linux-nat.c: Revert.
861         * aarch64-fbsd-tdep.c: Revert.
862         * aarch64-fbsd-nat.c: Revert.
863         * aarch32-linux-nat.c: Revert.
864
865 2019-04-05  Tom Tromey  <tom@tromey.com>
866
867         * ft32-tdep.c: Sort headers.
868         * frv-tdep.c: Sort headers.
869         * frv-linux-tdep.c: Sort headers.
870         * frame.c: Sort headers.
871         * frame-unwind.c: Sort headers.
872         * frame-base.c: Sort headers.
873         * fork-child.c: Sort headers.
874         * findvar.c: Sort headers.
875         * findcmd.c: Sort headers.
876         * filesystem.c: Sort headers.
877         * filename-seen-cache.h: Sort headers.
878         * filename-seen-cache.c: Sort headers.
879         * fbsd-tdep.c: Sort headers.
880         * fbsd-nat.h: Sort headers.
881         * fbsd-nat.c: Sort headers.
882         * f-valprint.c: Sort headers.
883         * f-typeprint.c: Sort headers.
884         * f-lang.c: Sort headers.
885         * extension.h: Sort headers.
886         * extension.c: Sort headers.
887         * extension-priv.h: Sort headers.
888         * expprint.c: Sort headers.
889         * exec.h: Sort headers.
890         * exec.c: Sort headers.
891         * exceptions.c: Sort headers.
892         * event-top.c: Sort headers.
893         * event-loop.c: Sort headers.
894         * eval.c: Sort headers.
895         * elfread.c: Sort headers.
896         * dwarf2read.h: Sort headers.
897         * dwarf2read.c: Sort headers.
898         * dwarf2loc.c: Sort headers.
899         * dwarf2expr.h: Sort headers.
900         * dwarf2expr.c: Sort headers.
901         * dwarf2-frame.c: Sort headers.
902         * dwarf2-frame-tailcall.c: Sort headers.
903         * dwarf-index-write.h: Sort headers.
904         * dwarf-index-write.c: Sort headers.
905         * dwarf-index-common.c: Sort headers.
906         * dwarf-index-cache.h: Sort headers.
907         * dwarf-index-cache.c: Sort headers.
908         * dummy-frame.c: Sort headers.
909         * dtrace-probe.c: Sort headers.
910         * disasm.h: Sort headers.
911         * disasm.c: Sort headers.
912         * disasm-selftests.c: Sort headers.
913         * dictionary.c: Sort headers.
914         * dicos-tdep.c: Sort headers.
915         * demangle.c: Sort headers.
916         * dcache.h: Sort headers.
917         * dcache.c: Sort headers.
918         * darwin-nat.h: Sort headers.
919         * darwin-nat.c: Sort headers.
920         * darwin-nat-info.c: Sort headers.
921         * d-valprint.c: Sort headers.
922         * d-namespace.c: Sort headers.
923         * d-lang.c: Sort headers.
924         * ctf.c: Sort headers.
925         * csky-tdep.c: Sort headers.
926         * csky-linux-tdep.c: Sort headers.
927         * cris-tdep.c: Sort headers.
928         * cris-linux-tdep.c: Sort headers.
929         * cp-valprint.c: Sort headers.
930         * cp-support.c: Sort headers.
931         * cp-namespace.c: Sort headers.
932         * cp-abi.c: Sort headers.
933         * corelow.c: Sort headers.
934         * corefile.c: Sort headers.
935         * continuations.c: Sort headers.
936         * completer.h: Sort headers.
937         * completer.c: Sort headers.
938         * complaints.c: Sort headers.
939         * coffread.c: Sort headers.
940         * coff-pe-read.c: Sort headers.
941         * cli-out.h: Sort headers.
942         * cli-out.c: Sort headers.
943         * charset.c: Sort headers.
944         * c-varobj.c: Sort headers.
945         * c-valprint.c: Sort headers.
946         * c-typeprint.c: Sort headers.
947         * c-lang.c: Sort headers.
948         * buildsym.c: Sort headers.
949         * buildsym-legacy.c: Sort headers.
950         * build-id.h: Sort headers.
951         * build-id.c: Sort headers.
952         * btrace.c: Sort headers.
953         * bsd-uthread.c: Sort headers.
954         * breakpoint.h: Sort headers.
955         * breakpoint.c: Sort headers.
956         * break-catch-throw.c: Sort headers.
957         * break-catch-syscall.c: Sort headers.
958         * break-catch-sig.c: Sort headers.
959         * blockframe.c: Sort headers.
960         * block.c: Sort headers.
961         * bfin-tdep.c: Sort headers.
962         * bfin-linux-tdep.c: Sort headers.
963         * bfd-target.c: Sort headers.
964         * bcache.c: Sort headers.
965         * ax-general.c: Sort headers.
966         * ax-gdb.h: Sort headers.
967         * ax-gdb.c: Sort headers.
968         * avr-tdep.c: Sort headers.
969         * auxv.c: Sort headers.
970         * auto-load.c: Sort headers.
971         * arm-wince-tdep.c: Sort headers.
972         * arm-tdep.c: Sort headers.
973         * arm-symbian-tdep.c: Sort headers.
974         * arm-pikeos-tdep.c: Sort headers.
975         * arm-obsd-tdep.c: Sort headers.
976         * arm-nbsd-tdep.c: Sort headers.
977         * arm-nbsd-nat.c: Sort headers.
978         * arm-linux-tdep.c: Sort headers.
979         * arm-linux-nat.c: Sort headers.
980         * arm-fbsd-tdep.c: Sort headers.
981         * arm-fbsd-nat.c: Sort headers.
982         * arm-bsd-tdep.c: Sort headers.
983         * arch-utils.c: Sort headers.
984         * arc-tdep.c: Sort headers.
985         * arc-newlib-tdep.c: Sort headers.
986         * annotate.h: Sort headers.
987         * annotate.c: Sort headers.
988         * amd64-windows-tdep.c: Sort headers.
989         * amd64-windows-nat.c: Sort headers.
990         * amd64-tdep.c: Sort headers.
991         * amd64-sol2-tdep.c: Sort headers.
992         * amd64-obsd-tdep.c: Sort headers.
993         * amd64-obsd-nat.c: Sort headers.
994         * amd64-nbsd-tdep.c: Sort headers.
995         * amd64-nbsd-nat.c: Sort headers.
996         * amd64-nat.c: Sort headers.
997         * amd64-linux-tdep.c: Sort headers.
998         * amd64-linux-nat.c: Sort headers.
999         * amd64-fbsd-tdep.c: Sort headers.
1000         * amd64-fbsd-nat.c: Sort headers.
1001         * amd64-dicos-tdep.c: Sort headers.
1002         * amd64-darwin-tdep.c: Sort headers.
1003         * amd64-bsd-nat.c: Sort headers.
1004         * alpha-tdep.c: Sort headers.
1005         * alpha-obsd-tdep.c: Sort headers.
1006         * alpha-nbsd-tdep.c: Sort headers.
1007         * alpha-mdebug-tdep.c: Sort headers.
1008         * alpha-linux-tdep.c: Sort headers.
1009         * alpha-linux-nat.c: Sort headers.
1010         * alpha-bsd-tdep.c: Sort headers.
1011         * alpha-bsd-nat.c: Sort headers.
1012         * aix-thread.c: Sort headers.
1013         * agent.c: Sort headers.
1014         * addrmap.c: Sort headers.
1015         * ada-varobj.c: Sort headers.
1016         * ada-valprint.c: Sort headers.
1017         * ada-typeprint.c: Sort headers.
1018         * ada-tasks.c: Sort headers.
1019         * ada-lang.c: Sort headers.
1020         * aarch64-tdep.c: Sort headers.
1021         * aarch64-ravenscar-thread.c: Sort headers.
1022         * aarch64-newlib-tdep.c: Sort headers.
1023         * aarch64-linux-tdep.c: Sort headers.
1024         * aarch64-linux-nat.c: Sort headers.
1025         * aarch64-fbsd-tdep.c: Sort headers.
1026         * aarch64-fbsd-nat.c: Sort headers.
1027         * aarch32-linux-nat.c: Sort headers.
1028
1029 2019-04-04  Tom Tromey  <tom@tromey.com>
1030
1031         * varobj.c (varobj_create): Update.
1032         * rust-exp.y (struct rust_parser) <update_innermost_block,
1033         lookup_symbol>: New methods.
1034         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1035         Rename.
1036         (rust_parser::rust_lookup_type)
1037         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1038         * printcmd.c (display_command, do_one_display): Update.
1039         * parser-defs.h (struct parser_state) <parser_state>: Add
1040         "tracker" parameter.
1041         (block_tracker): New member.
1042         (class innermost_block_tracker) <innermost_block_tracker>: Add
1043         "types" parameter.
1044         <reset>: Remove method.
1045         (innermost_block): Don't declare.
1046         (null_post_parser): Update.
1047         * parse.c (innermost_block): Remove global.
1048         (write_dollar_variable): Update.
1049         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1050         Remove "tracker_types" parameter.
1051         (parse_expression): Add "tracker" parameter.
1052         (parse_expression_for_completion): Update.
1053         (null_post_parser): Add "tracker" parameter.
1054         * p-exp.y: Update rules.
1055         * m2-exp.y: Update rules.
1056         * language.h (struct language_defn) <la_post_parser>: Add
1057         "tracker" parameter.
1058         * go-exp.y: Update rules.
1059         * f-exp.y: Update rules.
1060         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1061         parameter.
1062         * d-exp.y: Update rules.
1063         * c-exp.y: Update rules.
1064         * breakpoint.c (set_breakpoint_condition): Create an
1065         innermost_block_tracker.
1066         (watch_command_1): Likewise.
1067         * ada-lang.c (resolve): Add "tracker" parameter.
1068         (resolve_subexp): Likewise.
1069         * ada-exp.y (write_var_from_sym): Update.
1070
1071 2019-04-04  Tom Tromey  <tom@tromey.com>
1072
1073         * type-stack.h: New file.
1074         * type-stack.c: New file.
1075         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1076         type-stack.h.
1077         (insert_into_type_stack, insert_type, push_type, push_type_int)
1078         (insert_type_address_space, pop_type, pop_type_int)
1079         (pop_typelist, pop_type_stack, append_type_stack)
1080         (push_type_stack, get_type_stack, push_typelist)
1081         (follow_type_instance_flags, follow_types): Don't declare.
1082         * parse.c (type_stack): Remove global.
1083         (parse_exp_in_context): Update.
1084         (insert_into_type_stack, insert_type, push_type, push_type_int)
1085         (insert_type_address_space, pop_type, pop_type_int)
1086         (pop_typelist, pop_type_stack, append_type_stack)
1087         (push_type_stack, get_type_stack, push_typelist)
1088         (follow_type_instance_flags, follow_types): Remove (moved to
1089         type-stack.c).
1090         * f-exp.y (type_stack): New global.
1091         Update rules.
1092         (push_kind_type, f_parse): Update.
1093         * d-exp.y (type_stack): New global.
1094         Update rules.
1095         (d_parse): Update.
1096         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1097         Update rules.
1098         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1099         (HFILES_NO_SRCDIR): Add type-stack.h.
1100
1101 2019-04-04  Tom Tromey  <tom@tromey.com>
1102
1103         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1104         (rust_parser::convert_ast_to_expression, rust_parse)
1105         (rust_lex_test_completion, rust_lex_tests): Update.
1106         * parser-defs.h (struct expr_completion_state): New.
1107         (struct parser_state) <parser_state>: Add completion parameter.
1108         <mark_struct_expression, mark_completion_tag>: New methods.
1109         <parse_completion, m_completion_state>: New members.
1110         (prefixify_expression, null_post_parser): Update.
1111         (mark_struct_expression, mark_completion_tag): Don't declare.
1112         * parse.c (parse_completion, expout_last_struct)
1113         (expout_tag_completion_type, expout_completion_name): Remove
1114         globals.
1115         (parser_state::mark_struct_expression)
1116         (parser_state::mark_completion_tag): Now methods.
1117         (prefixify_expression): Add last_struct parameter.
1118         (prefixify_subexp): Likewise.
1119         (parse_exp_1): Update.
1120         (parse_exp_in_context): Add cstate parameter.  Update.
1121         (parse_expression_for_completion): Create an
1122         expr_completion_state.
1123         (null_post_parser): Add "completion" parameter.
1124         * p-exp.y: Update rules.
1125         (yylex): Update.
1126         * language.h (struct language_defn) <la_post_parser>: Add
1127         "completing" parameter.
1128         * go-exp.y: Update rules.
1129         (lex_one_token): Update.
1130         * expression.h (parse_completion): Don't declare.
1131         * d-exp.y: Update rules.
1132         (lex_one_token): Update rules.
1133         * c-exp.y: Update rules.
1134         (lex_one_token): Update.
1135         * ada-lang.c (resolve): Add "parse_completion" parameter.
1136         (resolve_subexp): Likewise.
1137         (ada_resolve_function): Likewise.
1138
1139 2019-04-04  Tom Tromey  <tom@tromey.com>
1140
1141         * parser-defs.h (struct parser_state) <start_arglist,
1142         end_arglist>: New methods.
1143         <arglist_len, m_funcall_chain>: New members.
1144         (arglist_len, start_arglist, end_arglist): Don't declare.
1145         * parse.c (arglist_len, funcall_chain): Remove global.
1146         (start_arglist, end_arglist): Remove functions.
1147         (parse_exp_in_context): Update.
1148         * p-exp.y: Update rules.
1149         * m2-exp.y: Update rules.
1150         * go-exp.y: Update rules.
1151         * f-exp.y: Update rules.
1152         * d-exp.y: Update rules.
1153         * c-exp.y: Update rules.
1154
1155 2019-04-04  Tom Tromey  <tom@tromey.com>
1156
1157         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1158         lex_operator, push_back>: New methods.
1159         Update all rules.
1160         (rust_parser::lex_hex, lex_escape): Rename and update.
1161         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1162         (rust_parser::lex_operator): Rename and update.
1163         (rust_parser::lex_number, rustyylex, rustyyerror)
1164         (rust_lex_test_init, rust_lex_test_sequence)
1165         (rust_lex_test_push_back, rust_lex_tests): Update.
1166         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1167         parameter.
1168         <lexptr, prev_lexptr>: New members.
1169         (lexptr, prev_lexptr): Don't declare.
1170         * parse.c (lexptr, prev_lexptr): Remove globals.
1171         (parse_exp_in_context): Update.
1172         * p-exp.y (yylex, yyerror): Update.
1173         * m2-exp.y (parse_number, yylex, yyerror): Update.
1174         * go-exp.y (lex_one_token, yyerror): Update.
1175         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1176         * d-exp.y (lex_one_token, yyerror): Update.
1177         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1178         (lex_one_token, yyerror): Update.
1179         * ada-lex.l (YY_INPUT): Update.
1180         (rewind_to_char): Update.
1181         * ada-exp.y (yyerror): Update.
1182
1183 2019-04-04  Tom Tromey  <tom@tromey.com>
1184
1185         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1186         * parser-defs.h (struct parser_state) <parser_state>: Add new
1187         parameter.
1188         <comma_terminates>: New member.
1189         (comma_terminates): Don't declare global.
1190         * parse.c (comma_terminates): Remove global.
1191         (parse_exp_in_context): Update.
1192         * p-exp.y (yylex): Update.
1193         * m2-exp.y (yylex): Update.
1194         * go-exp.y (lex_one_token): Update.
1195         * f-exp.y (yylex): Update.
1196         * d-exp.y (lex_one_token): Update.
1197         * c-exp.y (lex_one_token): Update.
1198         * ada-lex.l: Update.
1199
1200 2019-04-04  Tom Tromey  <tom@tromey.com>
1201
1202         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1203         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1204         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1205         * parser-defs.h (paren_depth): Don't declare.
1206         * parse.c (paren_depth): Remove global.
1207         (parse_exp_in_context): Update.
1208         * p-exp.y (paren_depth): New global.
1209         (pascal_parse): Initialize it.
1210         * m2-exp.y (paren_depth): New global.
1211         (m2_parse): Initialize it.
1212         * go-exp.y (paren_depth): New global.
1213         (go_parse): Initialize it.
1214         * f-exp.y (paren_depth): New global.
1215         (f_parse): Initialize it.
1216         * d-exp.y (paren_depth): New global.
1217         (d_parse): Initialize it.
1218         * c-exp.y (paren_depth): New global.
1219         (c_parse): Initialize it.
1220         * ada-lex.l (paren_depth): New global.
1221         (lexer_init): Initialize it.
1222
1223 2019-04-04  Tom Tromey  <tom@tromey.com>
1224
1225         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1226         (rust_parser::convert_ast_to_type)
1227         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1228         * parser-defs.h (struct parser_state) <parser_state>: Add
1229         parameters.  Initialize new members.
1230         <expression_context_block, expression_context_pc>: New members.
1231         * parse.c (expression_context_block, expression_context_pc):
1232         Remove globals.
1233         (parse_exp_in_context): Update.
1234         * p-exp.y: Update all rules.
1235         (yylex): Update.
1236         * m2-exp.y: Update all rules.
1237         (yylex): Update.
1238         * go-exp.y (yylex): Update.
1239         * f-exp.y (yylex): Update.
1240         * d-exp.y: Update all rules.
1241         (yylex): Update.
1242         * c-exp.y: Update all rules.
1243         (lex_one_token, classify_name, yylex, c_parse): Update.
1244         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1245
1246 2019-04-04  Tom Tromey  <tom@tromey.com>
1247
1248         * gdbarch.h, gdbarch.c: Rebuild.
1249         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1250         * stap-probe.h: 
1251         (struct stap_parse_info): Replace "parser_state" with
1252         "expr_builder".
1253         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1254         (parser_state): New class.
1255         * parse.c (expr_builder): Rename.
1256         (expr_builder::release): Rename.
1257         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1258         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1259         (write_exp_elt_longcst, write_exp_elt_floatcst)
1260         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1261         (write_exp_string_vector, write_exp_bitstring)
1262         (write_exp_msymbol, mark_struct_expression)
1263         (write_dollar_variable)
1264         (insert_type_address_space, increase_expout_size): Replace
1265         "parser_state" with "expr_builder".
1266         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1267         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1268         "parser_state" with "expr_builder".
1269
1270 2019-04-04  Tom Tromey  <tom@tromey.com>
1271
1272         * rust-exp.y: Replace "parse_language" with method call.
1273         * p-exp.y: 
1274         (yylex): Replace "parse_language" with method call.
1275         * m2-exp.y: 
1276         (yylex): Replace "parse_language" with method call.
1277         * go-exp.y (classify_name): Replace "parse_language" with method
1278         call.
1279         * f-exp.y (yylex): Replace "parse_language" with method call.
1280         * d-exp.y (lex_one_token): Replace "parse_language" with method
1281         call.
1282         * c-exp.y: 
1283         (lex_one_token, classify_name, yylex): Replace "parse_language"
1284         with method call.
1285         * ada-exp.y (find_primitive_type, type_char)
1286         (type_system_address): Replace "parse_language" with method call.
1287
1288 2019-04-04  Tom Tromey  <tom@tromey.com>
1289
1290         * rust-exp.y: Replace "parse_gdbarch" with method call.
1291         * parse.c (write_dollar_variable, insert_type_address_space):
1292         Replace "parse_gdbarch" with method call.
1293         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1294         call.
1295         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1296         call.
1297         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1298         "parse_gdbarch" with method call.
1299         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1300         with method call.
1301         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1302         "parse_gdbarch" with method call.
1303         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1304         "parse_gdbarch" with method call.
1305         * c-exp.y (parse_type, parse_number, classify_name): Replace
1306         "parse_gdbarch" with method call.
1307         * ada-lex.l: Replace "parse_gdbarch" with method call.
1308         * ada-exp.y (parse_type, find_primitive_type, type_char)
1309         (type_system_address): Replace "parse_gdbarch" with method call.
1310
1311 2019-04-04  Tom Tromey  <tom@tromey.com>
1312
1313         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1314         * stap-probe.c (stap_parse_argument): Update.
1315         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1316         initial_size parameter.
1317         * rust-exp.y (rust_lex_tests): Update.
1318         * parse.c (parser_state): Update.
1319         (parse_exp_in_context): Update.
1320         * parser-defs.h (struct parser_state) <parser_state>: Remove
1321         "initial_size" parameter.
1322
1323 2019-04-04  Tom Tromey  <tom@tromey.com>
1324
1325         * parser-defs.h (increase_expout_size): Don't declare.
1326         * parse.c (increase_expout_size): Now static.
1327
1328 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1329
1330         * gnu-nat.c (gnu_nat_target::wait): Fix
1331         target_waitstatus_to_string call.
1332
1333 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1334
1335         * eval.c (evaluate_subexp_standard): Handle internal functions
1336         during Fortran function call handling.
1337
1338 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * NEWS: Mention new internal functions.
1341         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1342         (read_base_type): Use dwarf2_init_complex_target_type.
1343         * value.c (creal_internal_fn): New function.
1344         (cimag_internal_fn): New function.
1345         (_initialize_values): Register new internal functions.
1346
1347 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1348
1349         * infrun.c (stop_all_threads): If debug_infrun, always
1350         trace the wait status after wait_one, using
1351         target_waitstatus_to_string and target_pid_to_str.
1352         (handle_inferior_event): Replace various trace of
1353         wait status kind by a single trace.
1354         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1355         wait status kind image by target_waitstatus_to_string.
1356         * target/waitstatus.c (target_waitstatus_to_string): Fix
1357         obsolete comment.
1358
1359 2019-04-01  Tom Tromey  <tromey@adacore.com>
1360
1361         PR symtab/23331:
1362         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1363
1364 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1365             Pedro Alves  <palves@redhat.com>
1366
1367         * top.c (quit_force): Call 'finalize_values'.
1368         * value.c (finalize_values): New function.
1369         * value.h (finalize_values): Declare.
1370
1371 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1372
1373         * NEWS: Announce $_gdb_major and $_gdb_minor.
1374
1375         * top.c (init_gdb_version_vars): New function.
1376         (gdb_init): Call init_gdb_version_vars.
1377
1378 2019-03-29  Tom Tromey  <tromey@adacore.com>
1379
1380         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1381         help text.  Remove dead code.
1382
1383 2019-03-29  Keith Seitz  <keiths@redhat.com>
1384
1385         From Siddhesh Poyarekar:
1386         * f-lang.h (f77_get_upperbound): Return LONGEST.
1387         (f77_get_lowerbound): Likewise.
1388         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1389         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1390         print them.
1391         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1392         plongest to format print it.
1393         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1394         (f77_get_upperbound): Likewise.
1395         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1396         LOWER_BOUND to LONGEST.
1397         (f77_create_arrayprint_offset_tbl): Likewise.
1398
1399 2019-03-29  Keith Seitz  <keiths@redhat.com>
1400
1401         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1402         %s/pulongest for TYPE_LENGTH instead of %d in format
1403         strings.
1404         * ada-typerint.c (ada_print_type): Likewise.
1405         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1406         * compile/compile-c-support.c (generate_register_struct): Likewise.
1407         * gdbtypes.c (recursive_dump_type): Likewise.
1408         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1409         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1410         instead of %d in format strings.
1411         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1412         to std::min to ULONGEST.
1413         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1414         instead of %d in format strings.
1415         * tracepoint.c (info_scope_command): Likewise.
1416         * typeprint.c (print_offset_data::update)
1417         (print_offset_data::finish): Likewise.
1418         * xtensa-tdep.c (xtensa_store_return_value)
1419         (xtensa_push_dummy_call): Likewise.
1420
1421 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1422
1423         * windows-nat.c (display_selector): Fixed format specifications
1424         for 64-bit Cygwin.
1425
1426 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1427
1428         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1429
1430 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1431
1432         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1433         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1434         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1435         (nios2_linux_init_abi): Install it.
1436
1437 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1440
1441 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1442
1443         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1444
1445 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1446             Tom Tromey  <tromey@adacore.com>
1447
1448         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1449
1450 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1451
1452         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1453         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1454         method to compute the bounds of range types. Also print "[evaluated]"
1455         if the bounds' values come from a dynamic evaluation.
1456
1457 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1458
1459         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1460         whitespace when pretty printing is on.
1461
1462 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1463
1464         * ppc-linux-nat.c: Add include.
1465
1466 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * NEWS: Mention AArch64 Pointer Authentication.
1469
1470 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1471
1472         * arm-linux-nat.c: Add include.
1473
1474 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1475
1476         * source-cache.c (source_cache::get_source_lines): Re-read
1477         fullname after calling open_source_file.
1478
1479 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1480
1481         * NEWS: Mention TLS support for FreeBSD.
1482
1483 2019-03-25  Tom Tromey  <tromey@adacore.com>
1484
1485         * minsyms.c (BUNCH_SIZE): Update comment.
1486         (~minimal_symbol_reader): Remove old comment.
1487         (compact_minimal_symbols): Update comment.
1488         (minimal_symbol_reader::install): Remove old comment.  Update
1489         other comments.
1490
1491 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1492
1493         * s390-linux-nat.c: Add include.
1494
1495 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1496
1497         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1498         Call linux_get_hwcap.
1499         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1500         Likewise.
1501         (aarch64_linux_get_hwcap): Remove function.
1502         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1503         declaration.
1504         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1505         linux_get_hwcap.
1506         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1507         * linux-tdep.c (linux_get_hwcap): Add function.
1508         (linux_get_hwcap2): Likewise.
1509         * linux-tdep.h (linux_get_hwcap): Add declaration.
1510         (linux_get_hwcap2): Likewise.
1511         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1512         (ppc_linux_get_hwcap2): Likewise.
1513         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1514         linux_get_hwcap.
1515         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1516         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1517         (ppc_linux_nat_target::read_description): Likewise.
1518         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1519         * s390-linux-nat.c: Likewise.
1520         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1521
1522 2019-03-24  Tom Tromey  <tom@tromey.com>
1523
1524         * ada-lang.c (standard_lookup): Simplify initialization.
1525         (ada_lookup_symbol_nonlocal): Simplify return.
1526         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1527         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1528         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1529         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1530         initialization.
1531         * solib.c (solib_global_lookup): Simplify.
1532         * symtab.c (null_block_symbol): Remove.
1533         (symbol_cache_lookup): Simplify returns.
1534         (lookup_language_this): Simplify returns.
1535         (lookup_symbol_aux): Simplify return.
1536         (lookup_local_symbol): Simplify returns.
1537         (lookup_global_symbol_from_objfile): Simplify return.
1538         (lookup_symbol_in_objfile_symtabs)
1539         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1540         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1541         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1542         * cp-namespace.c (cp_lookup_bare_symbol)
1543         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1544         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1545         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1546         (cp_lookup_symbol_via_imports): Simplify initialization.
1547         (find_symbol_in_baseclass): Likewise.
1548         * symtab.h (null_block_symbol): Remove.
1549         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1550         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1551         (d_lookup_symbol_module): Likewise.
1552         (find_symbol_in_baseclass): Simplify initialization.
1553
1554 2019-03-24  Tom Tromey  <tom@tromey.com>
1555
1556         * expression.h: Don't include symtab.h.
1557         (struct block): Forward declare.
1558
1559 2019-03-24  Tom Tromey  <tom@tromey.com>
1560
1561         * c-exp.y (typebase): Remove casts.
1562         * gdbtypes.c (lookup_unsigned_typename, )
1563         (lookup_signed_typename): Remove cast.
1564         * eval.c (parse_to_comma_and_eval): Remove cast.
1565         * parse.c (write_dollar_variable): Remove cast.
1566         * block.h (struct block) <superblock>: Now const.
1567         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1568         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1569         (map_block): Make "block" const.
1570         * symfile.h (struct quick_symbol_functions)
1571         <map_matching_symbols>: Constify block argument to "callback".
1572         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1573         const.
1574         (find_pc_sect_compunit_symtab): Make "b" const.
1575         (find_symbol_at_address): Likewise.
1576         (search_symbols): Likewise.
1577         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1578         (dw2_debug_names_lookup_symbol): Likewise.
1579         (dw2_map_matching_symbols): Update.
1580         * p-valprint.c (pascal_val_print): Remove "block".
1581         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1582         (aux_add_nonlocal_symbols): Make "block" const.
1583         (resolve_subexp): Remove cast.
1584         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1585         const.
1586         (iterate_over_file_blocks): Likewise.
1587         * f-exp.y (%union) <bval>: Remove.
1588         * coffread.c (patch_opaque_types): Make "b" const.
1589         * spu-tdep.c (spu_catch_start): Make "block" const.
1590         * c-valprint.c (print_unpacked_pointer): Remove "block".
1591         * symmisc.c (dump_symtab_1): Make "b" const.
1592         (block_depth): Make "block" const.
1593         * d-exp.y (%union) <bval>: Remove.
1594         * cp-support.h (cp_lookup_rtti_type): Update.
1595         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1596         * psymtab.c (psym_lookup_symbol): Make "block" const.
1597         (maintenance_check_psymtabs): Make "b" const.
1598         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1599         (enumerate_locals, enumerate_args): Update.
1600         * python/py-symtab.c (stpy_global_block): Make "block" const.
1601         (stpy_static_block): Likewise.
1602         * inline-frame.c (block_starting_point_at): Make "new_block"
1603         const.
1604         * block.c (find_block_in_blockvector): Make return type const.
1605         (blockvector_for_pc_sect): Make "b" const.
1606         (find_block_in_blockvector): Make "b" const.
1607
1608 2019-03-23  Tom Tromey  <tom@tromey.com>
1609
1610         * varobj.c (varobj_create): Update.
1611         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1612         * printcmd.c (display_command, do_one_display): Don't reset
1613         innermost_block.
1614         * parser-defs.h (enum innermost_block_tracker_type): Move to
1615         expression.h.
1616         (innermost_block): Update comment.
1617         * parse.c (parse_exp_1): Add tracker_types parameter.
1618         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1619         tracker_types parameter.  Reset innermost_block.
1620         (parse_exp_in_context): Remove.
1621         (parse_expression_for_completion): Update.
1622         * objfiles.c (~objfile): Don't reset expression_context_block or
1623         innermost_block.
1624         * expression.h (enum innermost_block_tracker_type): Move from
1625         parser-defs.h.
1626         (parse_exp_1): Add tracker_types parameter.
1627         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1628         reset innermost_block.
1629
1630 2019-03-23  Tom Tromey  <tom@tromey.com>
1631
1632         * objfiles.h: Include bcache.h.
1633
1634 2019-03-23  Tom Tromey  <tom@tromey.com>
1635
1636         * linespec.c (get_current_search_block): Use
1637         scoped_restore_current_language.
1638         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1639
1640 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1641             Jiong Wang  <jiong.wang@arm.com>
1642
1643         * aarch64-linux-tdep.c
1644         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1645         section.
1646         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1647
1648 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1649             Jiong Wang  <jiong.wang@arm.com>
1650
1651         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1652         instructions.
1653         (aarch64_analyze_prologue_test): Add PACIASP test.
1654         (aarch64_prologue_prev_register): Unmask PC value.
1655
1656 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1657             Jiong Wang  <jiong.wang@arm.com>
1658
1659         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1660         (aarch64_dwarf2_prev_register): Unmask PC value.
1661         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1662         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1663         DW_CFA_AARCH64_negate_ra_state.
1664         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1665
1666 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1667             Jiong Wang  <jiong.wang@arm.com>
1668
1669         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1670         registers.
1671         (aarch64_pseudo_register_name): Likewise.
1672         (aarch64_pseudo_register_type): Likewise.
1673         (aarch64_pseudo_register_reggroup_p): Likewise.
1674         (aarch64_gdbarch_init): Add pauth registers.
1675         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1676         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1677         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1678         (struct gdbarch_tdep): Add regnum for ra_state.
1679
1680 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1681             Jiong Wang  <jiong.wang@arm.com>
1682
1683         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1684
1685 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1686             Jiong Wang  <jiong.wang@arm.com>
1687
1688         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1689         function.
1690         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1691         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1692         (aarch64_gdbarch_init): Add puth registers.
1693         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1694         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1695         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1696
1697 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1698             Jiong Wang  <jiong.wang@arm.com>
1699
1700         * aarch64-linux-nat.c
1701         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1702         * aarch64-linux-tdep.c
1703         (aarch64_linux_core_read_description): Likewise.
1704         (aarch64_linux_get_hwcap): New function.
1705         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1706         (aarch64_linux_get_hwcap): New declaration.
1707
1708 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1709             Jiong Wang  <jiong.wang@arm.com>
1710
1711         * aarch64-linux-nat.c
1712         (aarch64_linux_nat_target::read_description): Add pauth param.
1713         * aarch64-linux-tdep.c
1714         (aarch64_linux_core_read_description): Likewise.
1715         * aarch64-tdep.c (struct target_desc): Add in pauth.
1716         (aarch64_read_description): Add pauth param.
1717         (aarch64_gdbarch_init): Likewise.
1718         * aarch64-tdep.h (aarch64_read_description): Likewise.
1719         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1720         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1721         * features/Makefile: Add new files.
1722         * features/aarch64-pauth.c: New file.
1723         * features/aarch64-pauth.xml: New file.
1724
1725 2019-03-20  Tom Tromey  <tromey@adacore.com>
1726
1727         * infrun.c (handle_inferior_event): Rename from
1728         handle_inferior_event_1.  Create a scoped_value_mark.
1729         (handle_inferior_event): Remove.
1730
1731 2019-03-19  Tom Tromey  <tromey@adacore.com>
1732
1733         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1734         * infrun.h (print_stop_event): Add "displays" parameter.
1735         * infrun.c (print_stop_event): Add "displays" parameter.
1736
1737 2019-03-19  Pedro Alves  <palves@redhat.com>
1738
1739         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1740         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1741         to -1.  Fix TABs vs spaces.
1742         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1743         * tui/tui-out.h (tui_ui_out) Add intro comments.
1744         <m_line, m_start_of_line>: In-class initialize, and add describing
1745         comment.
1746
1747 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1748
1749         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1750         variable names.
1751         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1752
1753 2019-03-18  Pedro Alves  <palves@redhat.com>
1754             Eli Zaretskii <eliz@gnu.org>
1755
1756         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1757         m_line and m_start_of_line.
1758
1759 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1760
1761         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1762         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1763         it returns a newline.  This fixes a regression in TU mode, whereby
1764         the next line is output on the same screen line as the user input.
1765
1766 2019-03-18  Tom Tromey  <tromey@adacore.com>
1767
1768         * minsyms.c (minimal_symbol_reader::install): Remove call to
1769         obstack_blank.
1770
1771 2019-03-18  Pedro Alves  <palves@redhat.com>
1772
1773         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1774         New globals.
1775         (apply_style): New, factored out from ...
1776         (apply_ansi_escape): ... this.  Handle reverse video mode.
1777         (tui_set_reverse_mode): New function.
1778         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1779         * tui/tui-winsource.c (tui_show_source_line): Use
1780         tui_set_reverse_mode instead of setting A_STANDOUT.
1781         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1782         New setter methods.
1783
1784 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1785
1786         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1787         Handle tabs.
1788
1789 2019-03-18  Tom Tromey  <tromey@adacore.com>
1790
1791         * ada-lang.c (empty_array): Add "high" parameter.
1792         (ada_evaluate_subexp): Update.
1793
1794 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1795
1796         * unittests/string_view-selftests.c: Define
1797         _initialize_string_view_selftests unconditionally.
1798
1799 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1800
1801         PR gdb/24350
1802         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1803
1804 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1805
1806         PR gdb/24351
1807         * windows-nat.c (display_selector): Fix format specifiers.
1808
1809 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1810
1811         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1812         tui_refill_source_window instead of tui_refresh_win, to update the
1813         current execution line.  This fixes redisplay of the current line
1814         when stepping through the code with "next" or "step".
1815
1816 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1817
1818         * source-cache.c (source_cache::get_source_lines): Call
1819         find_source_lines to initialize s->nlines.  This fixes vertical
1820         scrolling of TUI source window when the DOWN arrow is pressed.
1821
1822 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1823
1824         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1825         linux-thread-db.c (_initialize_thread_db): Likewise.
1826
1827 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1828
1829         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1830         wclrtoeol in tui_show_source_line".  This reverts changes made in
1831         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1832
1833 2019-03-15  Tom Tromey  <tom@tromey.com>
1834
1835         * symtab.h (struct minimal_symbol): Derive from
1836         general_symbol_info.
1837         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1838         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1839         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1840         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1841         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1842         (MSYMBOL_SEARCH_NAME): Update.
1843         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1844         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1845         * minsyms.c (minimal_symbol_reader::record_full): Update.
1846
1847 2019-03-15  Tom Tromey  <tom@tromey.com>
1848
1849         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1850
1851 2019-03-15  Tom Tromey  <tom@tromey.com>
1852
1853         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1854         unique_xmalloc_ptr.
1855         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1856         Update.
1857         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1858         (build_minimal_symbol_hash_tables)
1859         (minimal_symbol_reader::install): Update.
1860
1861 2019-03-15  Tom Tromey  <tom@tromey.com>
1862
1863         * symtab.c (create_demangled_names_hash): Update.
1864         (symbol_set_names): Update.
1865         * objfiles.h (struct objfile_per_bfd_storage)
1866         <demangled_names_hash>: Now an htab_up.
1867         * objfiles.c (objfile_per_bfd_storage): Simplify.
1868
1869 2019-03-15  Tom Tromey  <tom@tromey.com>
1870
1871         * objfiles.h (struct objfile_per_bfd_storage): Declare
1872         destructor.
1873         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1874         New.
1875         (get_objfile_bfd_data): Use new.  Don't initialize
1876         language_of_main.
1877         (free_objfile_per_bfd_storage): Remove.
1878         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1879
1880 2019-03-15  Tom Tromey  <tom@tromey.com>
1881
1882         * symfile.c (reread_symbols): Update.
1883         * objfiles.c (objfile::objfile): Update.
1884         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1885         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1886         comment.
1887         (minimal_symbol_reader::install): Update.
1888         (terminate_minimal_symbol_table): Remove.
1889         * jit.c (jit_object_close_impl): Update.
1890
1891 2019-03-15  Tom Tromey  <tom@tromey.com>
1892
1893         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1894         initializations.
1895
1896 2019-03-15  Tom Tromey  <tom@tromey.com>
1897
1898         * objfiles.h (struct objfile_per_bfd_storage)
1899         <demangled_hash_languages>: Now a bitset.
1900         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1901         (lookup_minimal_symbol): Update.
1902
1903 2019-03-15  Tom Tromey  <tom@tromey.com>
1904
1905         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1906         Don't return the symbol.
1907         * coffread.c (record_minimal_symbol): Use record_full.
1908
1909 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1910
1911         The MS-Windows port of ncurses fails to switch to a color pair if
1912         one or both of the colors are the implicit default colors.  This
1913         change records the default colors when TUI is initialized, and
1914         then specifies them explicitly when a color pair uses the default
1915         colors.  This allows color styling in TUI mode on MS-Windows.
1916
1917         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1918         ncurses_norm_attr.
1919         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1920         colors in ncurses_norm_attr.
1921         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1922         "none", replace it with the default color recorded in
1923         ncurses_norm_attr.
1924
1925 2019-03-14  Tom Tromey  <tromey@adacore.com>
1926
1927         * source-cache.h (class source_cache) <get_source_lines>: Return
1928         std::string.
1929         * source-cache.c (source_cache::extract_lines): Handle case where
1930         first_pos==npos.  Return std::string.
1931         (source_cache::get_source_lines): Update.
1932
1933 2019-03-14  Tom Tromey  <tromey@adacore.com>
1934
1935         * NEWS: Add item for "style sources" commands.
1936         * source-cache.c (source_cache::get_source_lines): Check
1937         source_styling.
1938         * cli/cli-style.c (source_styling): New global.
1939         (_initialize_cli_style): Add "style sources" commands.
1940         (show_style_sources): New function.
1941         * cli/cli-style.h (source_styling): Declare.
1942
1943 2019-03-14  Pedro Alves  <palves@redhat.com>
1944             Tom Tromey  <tromey@adacore.com>
1945
1946         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1947         * tui/tui-winsource.c (tui_refill_source_window): New function,
1948         from...
1949         (tui_horizontal_source_scroll): ... here.  Move some logic.
1950         * cli/cli-style.c (set_style_enabled): Notify new observable.
1951         * tui/tui-hooks.c (tui_redisplay_source): New function.
1952         (tui_attach_detach_observers): Attach or detach
1953         tui_redisplay_source.
1954         * observable.h (source_styling_changed): New observable.
1955         * observable.c: Define source_styling_changed observable.
1956
1957 2019-03-13  Tom Tromey  <tromey@adacore.com>
1958
1959         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1960         (i386_gnu_nat_target::store_registers): Update.
1961         * target-debug.h (target_debug_print_std_string): New macro.
1962         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1963         * windows-tdep.c (display_one_tib): Update.
1964         * tui/tui-stack.c (tui_make_status_line): Update.
1965         * top.c (print_inferior_quit_action): Update.
1966         * thread.c (thr_try_catch_cmd): Update.
1967         (add_thread_with_info): Update.
1968         (thread_target_id_str): Update.
1969         (thr_try_catch_cmd): Update.
1970         (thread_command): Update.
1971         (thread_find_command): Update.
1972         * record-btrace.c (record_btrace_target::info_record)
1973         (record_btrace_resume_thread, record_btrace_target::resume)
1974         (record_btrace_cancel_resume, record_btrace_step_thread)
1975         (record_btrace_target::wait, record_btrace_target::wait)
1976         (record_btrace_target::wait, record_btrace_target::stop): Update.
1977         * progspace.c (print_program_space): Update.
1978         * process-stratum-target.c
1979         (process_stratum_target::thread_address_space): Update.
1980         * linux-fork.c (linux_fork_mourn_inferior)
1981         (detach_checkpoint_command, info_checkpoints_command)
1982         (linux_fork_context): Update.
1983         (linux_fork_detach): Update.
1984         (class scoped_switch_fork_info): Update.
1985         (delete_checkpoint_command): Update.
1986         * infrun.c (follow_fork_inferior): Update.
1987         (follow_fork_inferior): Update.
1988         (proceed_after_vfork_done): Update.
1989         (handle_vfork_child_exec_or_exit): Update.
1990         (follow_exec): Update.
1991         (displaced_step_prepare_throw): Update.
1992         (displaced_step_restore): Update.
1993         (start_step_over): Update.
1994         (resume_1): Update.
1995         (clear_proceed_status_thread): Update.
1996         (proceed): Update.
1997         (print_target_wait_results): Update.
1998         (do_target_wait): Update.
1999         (context_switch): Update.
2000         (stop_all_threads): Update.
2001         (restart_threads): Update.
2002         (finish_step_over): Update.
2003         (handle_signal_stop): Update.
2004         (switch_back_to_stepped_thread): Update.
2005         (keep_going_pass_signal): Update.
2006         (print_exited_reason): Update.
2007         (normal_stop): Update.
2008         * inferior.c (inferior_pid_to_str): Change return type.
2009         (print_selected_inferior): Update.
2010         (add_inferior): Update.
2011         (detach_inferior): Update.
2012         * dummy-frame.c (fprint_dummy_frames): Update.
2013         * dcache.c (dcache_info_1): Update.
2014         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2015         (btrace_fetch, btrace_clear): Update.
2016         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2017         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2018         type.
2019         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2020         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2021         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2022         * gdbarch.c, gdbarch.h: Rebuild.
2023         * gdbarch.sh (core_pid_to_str): Change return type.
2024         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2025         return type.
2026         (windows_nat_target::pid_to_str): Change return type.
2027         (windows_delete_thread): Update.
2028         (windows_nat_target::attach): Update.
2029         (windows_nat_target::files_info): Update.
2030         * target-delegates.c: Rebuild.
2031         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2032         return type.
2033         (sol_thread_target::pid_to_str): Change return type.
2034         * remote.c (class remote_target) <pid_to_str>: Change return
2035         type.
2036         (remote_target::pid_to_str): Change return type.
2037         (extended_remote_target::attach, remote_target::remote_stop_ns)
2038         (remote_target::remote_notif_remove_queued_reply)
2039         (remote_target::push_stop_reply, remote_target::disable_btrace):
2040         Update.
2041         (extended_remote_target::attach): Update.
2042         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2043         type.
2044         (gdbsim_target::pid_to_str): Change return type.
2045         * ravenscar-thread.c (struct ravenscar_thread_target)
2046         <pid_to_str>: Change return type.
2047         (ravenscar_thread_target::pid_to_str): Change return type.
2048         * procfs.c (class procfs_target) <pid_to_str>: Change return
2049         type.
2050         (procfs_target::pid_to_str): Change return type.
2051         (procfs_target::attach): Update.
2052         (procfs_target::detach): Update.
2053         (procfs_target::fetch_registers): Update.
2054         (procfs_target::store_registers): Update.
2055         (procfs_target::wait): Update.
2056         (procfs_target::files_info): Update.
2057         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2058         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2059         return type.
2060         (nto_procfs_target::pid_to_str): Change return type.
2061         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2062         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2063         return type.
2064         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2065         (exit_lwp): Update.
2066         (attach_proc_task_lwp_callback, get_detach_signal)
2067         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2068         (linux_nat_target::resume, wait_lwp, stop_callback)
2069         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2070         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2071         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2072         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2073         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2074         type.
2075         (inf_ptrace_target::attach): Update.
2076         (inf_ptrace_target::files_info): Update.
2077         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2078         type.
2079         (go32_nat_target::pid_to_str): Change return type.
2080         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2081         (gnu_nat_target::wait): Update.
2082         (gnu_nat_target::wait): Update.
2083         (gnu_nat_target::resume): Update.
2084         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2085         (fbsd_nat_target::wait): Update.
2086         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2087         type.
2088         (darwin_nat_target::attach): Update.
2089         * corelow.c (class core_target) <pid_to_str>: Change return type.
2090         (core_target::pid_to_str): Change return type.
2091         * target.c (normal_pid_to_str): Change return type.
2092         (default_pid_to_str): Likewise.
2093         (target_pid_to_str): Change return type.
2094         (target_translate_tls_address): Update.
2095         (target_announce_detach): Update.
2096         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2097         return type.
2098         (bsd_uthread_target::pid_to_str): Change return type.
2099         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2100         type.
2101         (bsd_kvm_target::pid_to_str): Change return type.
2102         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2103         return type.
2104         (aix_thread_target::pid_to_str): Change return type.
2105         * target.h (struct target_ops) <pid_to_str>: Change return type.
2106         (target_pid_to_str, normal_pid_to_str): Likewise.
2107         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2108         type.
2109         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2110         type.
2111         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2112         return type.
2113         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2114         type.
2115         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2116         type.
2117         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2118         return type.
2119
2120 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2121
2122         * NEWS: Mention that the new default MI version is 3.  Mention
2123         changes to the output of commands and events that deal with
2124         multi-location breakpoints.
2125         * breakpoint.c: Include "mi/mi-out.h".
2126         (print_one_breakpoint): Change output syntax if using MI version
2127         >= 3.
2128         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2129         New.
2130         (mi_multi_location_breakpoint_output_fixed): New.
2131         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2132         (mi_cmd_fix_multi_location_breakpoint_output): New.
2133         (mi_multi_location_breakpoint_output_fixed): New.
2134         * mi/mi-cmds.c (mi_cmds): Register command
2135         -fix-multi-location-breakpoint-output.
2136         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2137         interpreter "mi".
2138
2139 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2140
2141         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2142         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2143         instantiate mi_ui_out based on interpreter name.
2144         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2145         * mi/mi-main.c (mi_load_progress): Likewise.
2146
2147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2148
2149         * NEWS: Combine separate "New targets" sections for 8.3.
2150
2151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2152
2153         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2154         (ppcfbsd_init_abi): Install gdbarch
2155         "fetch_tls_load_module_address" and "get_thread_local_address"
2156         methods.
2157
2158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2159
2160         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2161         (riscv_fbsd_init_abi): Install gdbarch
2162         "fetch_tls_load_module_address" and "get_thread_local_address"
2163         methods.
2164
2165 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2166
2167         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2168         (i386fbsd_init_abi): Install gdbarch
2169         "fetch_tls_load_module_address" and "get_thread_local_address"
2170         methods.
2171
2172 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2173
2174         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2175         (amd64fbsd_init_abi): Install gdbarch
2176         "fetch_tls_load_module_address" and "get_thread_local_address"
2177         methods.
2178
2179 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2180
2181         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2182         (struct fbsd_pspace_data): New type.
2183         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2184         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2185         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2186         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2187         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2188
2189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2190
2191         * gdbtypes.c (lookup_struct_elt): New function.
2192         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2193         * gdbtypes.h (struct struct_elt): New type.
2194         (lookup_struct_elt): New prototype.
2195
2196 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2197
2198         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2199         remove disabled code block.
2200
2201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2202
2203         * gdbarch.sh (get_thread_local_address): New method.
2204         * gdbarch.h, gdbarch.c: Regenerate.
2205         * target.c (target_translate_tls_address): Use
2206         gdbarch_get_thread_local_address if present instead of
2207         target::get_thread_local_address.
2208
2209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2210
2211         * target.h (target::get_thread_local_address): Update comment.
2212
2213 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2214
2215         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2216         objfile->separate_debug_objfile_backlink if not NULL.
2217
2218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2219
2220         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2221         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2222         (amd64bsd_store_inferior_registers): Likewise.
2223         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2224         Enable segment base registers.
2225         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2226         PT_GETFSBASE and PT_GETGSBASE.
2227         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2228         PT_SETGSBASE.
2229         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2230         segment base registers.
2231         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2232
2233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2234
2235         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2236         Update calls to i386_target_description to add 'segments'
2237         parameter.
2238         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2239         add segment base registers.
2240         * arch/i386.c (i386_create_target_description): Add 'segments'
2241         parameter to enable segment base registers.
2242         * arch/i386.h (i386_create_target_description): Likewise.
2243         * features/i386/32bit-segments.xml: New file.
2244         * features/i386/32bit-segments.c: Generate.
2245         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2246         call to i386_target_description to add 'segments' parameter.
2247         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2248         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2249         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2250         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2251         if feature is present.
2252         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2253         Add 'segments' parameter to call to i386_target_description.
2254         (i386_target_description): Add 'segments' parameter to enable
2255         segment base registers.
2256         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2257         to call to i386_target_description.
2258         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2259         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2260         Define I386_NUM_REGS.
2261         (i386_target_description): Add 'segments' parameter to enable
2262         segment base registers.
2263
2264 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2265
2266         PR/24325
2267         * source-cache.c: #undef open and close, to avoid unresolved
2268         externals during linking.
2269
2270 2019-03-12  Tom Tromey  <tromey@adacore.com>
2271
2272         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2273         const.  Add initializers.
2274         (_initialize_remote): Don't initialize ptid globals.
2275
2276 2019-03-12  Pedro Alves  <palves@redhat.com>
2277
2278         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2279
2280 2019-03-12  Pedro Alves  <palves@redhat.com>
2281
2282         * cp-name-parser.y (main): Remove unused 'len' variable.
2283
2284 2019-03-12  Tom Tromey  <tromey@adacore.com>
2285
2286         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2287         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2288
2289 2019-03-12  Tom Tromey  <tromey@adacore.com>
2290
2291         * linux-nat.c (iterate_over_lwps): Update.
2292         (stop_callback): Remove parameter.
2293         (stop_wait_callback, detach_callback, resume_set_callback)
2294         (select_singlestep_lwp_callback, set_ignore_sigint)
2295         (status_callback, resumed_callback, resume_clear_callback)
2296         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2297         data parameter.
2298         (linux_nat_target::detach, linux_nat_target::resume)
2299         (linux_stop_and_wait_all_lwps, select_event_lwp)
2300         (linux_nat_filter_event, linux_nat_wait_1)
2301         (linux_nat_target::kill, linux_nat_target::stop)
2302         (linux_nat_target::stop): Update.
2303         (linux_nat_resume_callback): Change type.
2304         (resume_stopped_resumed_lwps, count_events_callback)
2305         (select_event_lwp_callback): Likewise.
2306         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2307         * arm-linux-nat.c (struct update_registers_data): Remove.
2308         (update_registers_callback): Change type.
2309         (arm_linux_insert_hw_breakpoint1): Update.
2310         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2311         parameter.
2312         (x86_linux_dr_set_addr): Update.
2313         (x86_linux_dr_set_control): Update.
2314         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2315         (iterate_over_lwps): Use gdb::function_view.
2316         * nat/aarch64-linux-hw-point.c (struct
2317         aarch64_dr_update_callback_param): Remove.
2318         (debug_reg_change_callback): Change type.
2319         (aarch64_notify_debug_reg_change): Update.
2320         * s390-linux-nat.c (s390_refresh_per_info): Update.
2321
2322 2019-03-11  Tom Tromey  <tromey@adacore.com>
2323
2324         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2325         redundant assignment to "this_cu".
2326
2327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2328
2329         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2330
2331 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2332
2333         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2334         from...
2335         (rank_one_type): ... this.
2336
2337 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2338
2339         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2340         from...
2341         (rank_one_type): ... this.
2342
2343 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2344
2345         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2346         from...
2347         (rank_one_type): ... this.
2348
2349 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2350
2351         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2352         from...
2353         (rank_one_type): ... this.
2354
2355 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2356
2357         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2358         from...
2359         (rank_one_type): ... this.
2360
2361 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2362
2363         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2364         from...
2365         (rank_one_type): ... this.
2366
2367 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2368
2369         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2370         from...
2371         (rank_one_type): ... this.
2372
2373 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2374
2375         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2376         from...
2377         (rank_one_type): ... this.
2378
2379 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2380
2381         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2382         from...
2383         (rank_one_type): ... this.
2384
2385 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2386
2387         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2388         from...
2389         (rank_one_type): ... this.
2390
2391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2392
2393         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2394         from...
2395         (rank_one_type): ... this.
2396
2397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2400         from...
2401         (rank_one_type): ... this.
2402
2403 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2404
2405         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2406         inferior-events' shows the example events.
2407
2408 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2409
2410         Support styling on native MS-Windows console
2411
2412         PR/24315
2413         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2414         on MS-Windows if $TERM is not defined.
2415
2416         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2417
2418         * posix-hdep.c (gdb_console_fputs):
2419         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2420         functions.
2421         * ui-file.h (gdb_console_fputs): Add prototype.
2422
2423         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2424         back to fputs only if the former returns zero.
2425
2426 2019-03-07  Tom Tromey  <tom@tromey.com>
2427
2428         * symmisc.c (print_symbol_bcache_statistics): Update.
2429         (print_objfile_statistics): Update.
2430         * symfile.c (allocate_symtab): Update.
2431         * stabsread.c: Don't include bcache.h.
2432         * psymtab.h (struct psymbol_bcache): Don't declare.
2433         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2434         (psymbol_bcache_init, psymbol_bcache_free)
2435         (psymbol_bcache_get_bcache): Don't declare.
2436         * psymtab.c (struct psymbol_bcache): Remove.
2437         (psymtab_storage::psymtab_storage): Update.
2438         (psymtab_storage::~psymtab_storage): Update.
2439         (psymbol_bcache_init, psymbol_bcache_free)
2440         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2441         (add_psymbol_to_bcache): Update.
2442         (allocate_psymtab): Update.
2443         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2444         macro_cache>: No longer pointers.
2445         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2446         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2447         * macrotab.c (macro_bcache): Update.
2448         * macroexp.c: Don't include bcache.h.
2449         * gdbtypes.c (check_types_worklist): Update.
2450         (types_deeply_equal): Remove TRY/CATCH.  Update.
2451         * elfread.c (elf_symtab_read): Update.
2452         * dwarf2read.c: Don't include bcache.h.
2453         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2454         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2455         (print_bcache_statistics, bcache_memory_used): Don't declare.
2456         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2457         methods.  Rename all data members.
2458         * bcache.c (struct bcache): Move to bcache.h.
2459         (bcache::expand_hash_table): Rename from expand_hash_table.
2460         (bcache): Remove.
2461         (bcache::insert): Rename from bcache_full.
2462         (bcache::compare): Rename from bcache_compare.
2463         (bcache_xmalloc): Remove.
2464         (bcache::~bcache): Rename from bcache_xfree.
2465         (bcache::print_statistics): Rename from print_bcache_statistics.
2466         (bcache::memory_used): Rename from bcache_memory_used.
2467
2468 2019-03-07  Pedro Alves  <palves@redhat.com>
2469
2470         * infrun.c (normal_stop): Also check for
2471         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2472
2473 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2474
2475         * f-lang.c (value_from_host_double): Moved to...
2476         * value.c (value_from_host_double): ...here.
2477         * value.h (value_from_host_double): Declare.
2478         * guile/scm-math.c (vlscm_convert_typed_number): Use
2479         value_from_host_double.
2480         (vlscm_convert_number): Likewise.
2481         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2482         * python/py-value.c (convert_value_from_python): Likewise.
2483
2484 2019-03-06  Tom Tromey  <tom@tromey.com>
2485
2486         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2487
2488 2019-03-06  Tom Tromey  <tom@tromey.com>
2489
2490         * utils.h (free_current_contents): Don't declare.
2491         * utils.c (free_current_contents): Remove.
2492
2493 2019-03-06  Tom Tromey  <tom@tromey.com>
2494
2495         * top.c (quit_force): Update.
2496         * main.c (captured_command_loop): Update.
2497         * common/new-op.c (operator new): Update.
2498         * common/common-exceptions.c (struct catcher)
2499         <save_cleanup_chain>: Remove member.
2500         (exceptions_state_mc_init): Update.
2501         (exception_try_scope_entry): Return nullptr.
2502         (exception_try_scope_exit, exception_rethrow)
2503         (throw_exception_sjlj, throw_exception_cxx): Update.
2504         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2505         (all_cleanups, do_cleanups, discard_cleanups)
2506         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2507         (restore_cleanups, restore_final_cleanups): Don't declare.
2508         (do_final_cleanups): Remove parameter.
2509         * common/cleanups.c (cleanup_chain, make_cleanup)
2510         (make_cleanup_dtor, all_cleanups, do_cleanups)
2511         (discard_my_cleanups, discard_cleanups)
2512         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2513         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2514         (null_cleanup): Remove.
2515         (do_final_cleanups): Remove parameter.
2516
2517 2019-03-06  Tom Tromey  <tom@tromey.com>
2518
2519         * remote.c (remote_target::remote_parse_stop_reply): Use
2520         unique_xmalloc_ptr.
2521
2522 2019-03-06  Tom Tromey  <tom@tromey.com>
2523
2524         * stabsread.c (struct stabs_field_info): Rename from field_info.
2525         <list, fnlist>: Add initializers.
2526         <obstack>: New member.
2527         (read_member_functions, read_struct_fields, read_baseclasses):
2528         Allocate on obstack.  Don't use cleanups.
2529         (read_one_struct_field, read_member_functions, read_struct_fields)
2530         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2531         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2532         (read_struct_type): Update.
2533
2534 2019-03-06  Tom Tromey  <tom@tromey.com>
2535
2536         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2537         * common/filestuff.h (make_cleanup_close): Don't declare.
2538         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2539         Remove.
2540
2541 2019-03-06  Tom Tromey  <tom@tromey.com>
2542
2543         * solib-aix.c: Use make_scope_exit.
2544
2545 2019-03-06  Tom Tromey  <tom@tromey.com>
2546
2547         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2548         Use make_scope_exit.
2549
2550 2019-03-06  Tom Tromey  <tom@tromey.com>
2551
2552         * solib-svr4.c (disable_probes_interface): Remove parameter.
2553         (svr4_handle_solib_event): Use make_scope_exit.
2554
2555 2019-03-06  Tom Tromey  <tom@tromey.com>
2556
2557         * remote.c (struct stop_reply_deleter): Remove.
2558         (stop_reply_up): Update.
2559         (struct stop_reply): Derive from notif_event.  Don't typedef.
2560         <regcache>: Now a std::vector.
2561         (stop_reply_xfree): Remove.
2562         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2563         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2564         (remote_target::discard_pending_stop_replies): Use delete.
2565         (remote_target::remote_parse_stop_reply): Update.
2566         (remote_target::process_stop_reply): Update.
2567         * remote-notif.h (struct notif_event): Add virtual destructor.
2568         Remove "dtr" member.
2569         (struct notif_client) <alloc_event>: Return a unique_ptr.
2570         (notif_event_xfree): Don't declare.
2571         (notif_event_up): New typedef.
2572         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2573         (notif_event_xfree, do_notif_event_xfree): Remove.
2574         (remote_notif_state_xfree): Update.
2575
2576 2019-03-06  Tom Tromey  <tom@tromey.com>
2577
2578         * infrun.c (displaced_step_clear_cleanup): Now a
2579         forward_scope_exit type.
2580         (displaced_step_prepare_throw): Update.
2581         (displaced_step_fixup): Update.
2582
2583 2019-03-06  Tom Tromey  <tom@tromey.com>
2584
2585         * inferior.h (class inferior): Update comment.
2586         * gdbthread.h (class thread_info): Update comment.
2587
2588 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2589             Tom Tromey  <tom@tromey.com>
2590
2591         * stabsread.h (struct stab_section_list): Remove.
2592         (coffstab_build_psymtabs): Update.
2593         * dbxread.c (symbuf_sections): Now a std::vector.
2594         (sect_idx): New global.
2595         (fill_symbuf): Update.
2596         (coffstab_build_psymtabs): Change type of stabsects parameter.
2597         Update.
2598         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2599         std::vector.
2600         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2601         (coff_locate_sections): Update.
2602         (coff_symfile_read): Remove cleanups.  Update.
2603         (init_stringtab): Add storage parameter.
2604         (free_stringtab, free_stringtab_cleanup): Remove.
2605         (init_lineno): Add storage parameter.
2606         (free_linetab, free_linetab_cleanup): Remove.
2607
2608 2019-03-06  Pedro Alves  <palves@redhat.com>
2609
2610         * linux-fork.c (fork_info::clobber_regs): Delete.
2611         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2612         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2613         comment.  Adjust.
2614         (scoped_switch_fork_info::scoped_switch_fork_info)
2615         (checkpoint_command, linux_fork_context): Adjust
2616         fork_save_infrun_state calls.
2617
2618 2019-03-06  Pedro Alves  <palves@redhat.com>
2619
2620         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2621         (inf_has_multiple_threads): Return 'bool' and rewrite using
2622         inferior_info::threads().
2623
2624 2019-03-06  Pedro Alves  <palves@redhat.com>
2625
2626         * linux-fork.c: Include <list>.
2627         (fork_list): Now a std::list instance.
2628         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2629         (forks_exist_p, find_last_fork): Adjust.
2630         (new_fork): Delete.
2631         (one_fork_p): New.
2632         (add_fork): Adjust.
2633         (free_fork): Delete, folded into fork_info::~fork_info().
2634         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2635         Adjust.
2636         (init_fork_list): Delete.
2637         (linux_fork_killall, linux_fork_mourn_inferior)
2638         (linux_fork_detach, info_checkpoints_command): Adjust.
2639         (_initialize_linux_fork): No longer call init_fork_list.
2640
2641 2019-03-06  Pedro Alves  <palves@redhat.com>
2642
2643         * linux-fork.c (new_fork): New, split out of ...
2644         (add_fork): ... this.  Return void.  Move "first fork" special
2645         case from here, to ...
2646         (checkpoint_command): ... here.
2647         * linux-linux.h (add_fork): Return void.
2648
2649 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2652
2653 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2654             Chris January  <chris.january@arm.com>
2655             David Lecomber  <david.lecomber@arm.com>
2656
2657         * f-exp.y: New token, UNOP_INTRINSIC.
2658         (exp): New pattern using UNOP_INTRINSIC token.
2659         (f77_keywords): Add 'abs' keyword.
2660         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2661         (value_from_host_double): New function.
2662         (evaluate_subexp_f): Support UNOP_ABS.
2663
2664 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2667         types.
2668
2669 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2672         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2673         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2674
2675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2676
2677         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2678
2679 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2680             Chris January  <chris.january@arm.com>
2681
2682         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2683         * f-exp.y: Define 'KIND' token.
2684         (exp): New pattern for KIND expressions.
2685         (ptype): Handle types with a kind extension.
2686         (direct_abs_decl): Extend to spot kind extensions.
2687         (f77_keywords): Add 'kind' to the list.
2688         (push_kind_type): New function.
2689         (convert_to_kind_type): New function.
2690         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2691         * parse.c (operator_length_standard): Likewise.
2692         * parser-defs.h (enum type_pieces): Add tp_kind.
2693         * std-operator.def: Add UNOP_KIND.
2694
2695 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2696
2697         * f-exp.y (f_parse): Set yydebug.
2698
2699 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * f-lang.c (evaluate_subexp_f): New function.
2702         (exp_descriptor_f): New global.
2703         (f_language_defn): Use exp_descriptor_f instead of
2704         exp_descriptor_standard.
2705
2706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2707
2708         * f-exp.y (struct token): Add comments.
2709         (dot_ops): Remove uppercase versions and the end marker.
2710         (f77_keywords): Likewise.
2711         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2712         entries in the dot_ops array are case insensitive, and use
2713         strncasecmp to compare strings.  Also some whitespace cleanup in
2714         this area.  Similar for the f77_keywords array, except entries in
2715         this list might be case sensitive.
2716
2717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2718
2719         * f-exp.y (struct f77_boolean_val): Add comments.
2720         (boolean_values): Remove uppercase versions, and end marker.
2721         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2722         and use strncasecmp to achieve case insensitivity.  Additionally,
2723         perform whitespace cleanup around this code.
2724
2725 2019-03-06  Tom Tromey  <tromey@adacore.com>
2726
2727         * remote-sim.c (gdbsim_target_open): Use result of
2728         gdb_argv::release.
2729
2730 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2731         Dirk Schubert  <dirk.schubert@arm.com>
2732         Chris January  <chris.january@arm.com>
2733
2734         * eval.c (evaluate_subexp_standard): Call Fortran argument
2735         wrapping logic.
2736         * f-lang.c (struct value): A value which can be passed into a
2737         Fortran function call.
2738         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2739         where appropriate.
2740         (struct type): Value ready for a Fortran function call.
2741         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2742         is needed.
2743         * f-lang.h (fortran_argument_convert): Declaration.
2744         (fortran_preserve_arg_pointer): Declaration.
2745         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2746
2747 2019-03-05  Tom Tromey  <tromey@adacore.com>
2748
2749         * python/py-prettyprint.c (print_string_repr): Remove #if.
2750         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2751
2752 2019-03-05  Tom Tromey  <tromey@adacore.com>
2753
2754         * target.c (the_dummy_target): Move later.  Change type to
2755         "dummy_target".
2756         (initialize_targets): Don't initialize the_dummy_target.
2757
2758 2019-03-05  Tom Tromey  <tromey@adacore.com>
2759
2760         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2761         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2762
2763 2019-03-05  Tom Tromey  <tromey@adacore.com>
2764
2765         * windows-nat.c (windows_nat_target::attach)
2766         (windows_nat_target::detach): Don't call gdb_flush.
2767         * valprint.c (generic_val_print, val_print, val_print_string):
2768         Don't call gdb_flush.
2769         * utils.c (defaulted_query): Don't call gdb_flush.
2770         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2771         * target.c (target_announce_detach): Don't call gdb_flush.
2772         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2773         * remote.c (extended_remote_target::attach): Don't call
2774         gdb_flush.
2775         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2776         * printcmd.c (do_examine): Don't call gdb_flush.
2777         (info_display_command): Don't call gdb_flush.
2778         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2779         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2780         * memattr.c (info_mem_command): Don't call gdb_flush.
2781         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2782         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2783         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2784         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2785         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2786         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2787         (gnu_nat_target::detach): Don't call gdb_flush.
2788         * f-valprint.c (f_val_print): Don't call gdb_flush.
2789         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2790         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2791         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2792         gdb_flush.
2793         * c-valprint.c (c_val_print): Don't call gdb_flush.
2794         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2795
2796 2019-03-05  Tom Tromey  <tromey@adacore.com>
2797
2798         * varobj.c (update_dynamic_varobj_children): Update.
2799         (install_default_visualizer): Use reset, not release.
2800         * value.c (set_internalvar): Update.
2801         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2802         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2803         ATTRIBUTE_UNUSED_RESULT.
2804
2805 2019-03-05  Tom Tromey  <tromey@adacore.com>
2806
2807         * remote.c (class scoped_remote_fd) <release>: Add
2808         ATTRIBUTE_UNUSED_RESULT.
2809
2810 2019-03-05  Tom Tromey  <tromey@adacore.com>
2811
2812         * macroexp.c (struct macro_buffer) <release>: Add
2813         ATTRIBUTE_UNUSED_RESULT.
2814
2815 2019-03-05  Tom Tromey  <tromey@adacore.com>
2816
2817         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2818         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2819         ATTRIBUTE_UNUSED_RESULT.
2820
2821 2019-03-05  Tom Tromey  <tromey@adacore.com>
2822
2823         * common/scoped_fd.h (class scoped_fd) <release>: Add
2824         ATTRIBUTE_UNUSED_RESULT.
2825
2826 2019-03-05  Tom Tromey  <tromey@adacore.com>
2827
2828         * parser-defs.h (struct parser_state) <release>: Add
2829         ATTRIBUTE_UNUSED_RESULT.
2830
2831 2019-03-05  Tom Tromey  <tromey@adacore.com>
2832
2833         * utils.h (class gdb_argv) <release>: Add
2834         ATTRIBUTE_UNUSED_RESULT.
2835         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2836
2837 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2838
2839         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2840         for-loop range, to avoid compiler warnings.
2841
2842         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2843         avoid compiler warnings about unused variables.
2844
2845         * NEWS: Mention end of support for native debugging on MS-Windows
2846         before XP.
2847
2848         PR gdb/24292
2849         * common/netstuff.c:
2850         * gdbserver/gdbreplay.c
2851         * gdbserver/remote-utils.c:
2852         * ser-tcp.c:
2853         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2854         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2855         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2856         'getaddrinfo' and 'freeaddrinfo' were not available before
2857         Windows XP, and mingw.org's MinGW headers by default define
2858         _WIN32_WINNT to 0x500.
2859
2860 2019-03-01  Gary Benson <gbenson@redhat.com>
2861
2862         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2863
2864 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2865             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2866
2867         PR gdb/8527
2868         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2869         set_sigint_trap, clear_sigint_trap.
2870
2871 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2872
2873         * target.c (target_detach): Clear the regcache and the
2874         frame cache.
2875
2876 2019-02-27  Pedro Alves  <palves@redhat.com>
2877
2878         * utils.c (set_screen_size): When we cap the height/width sizes,
2879         tweak the corresponding command variable to show "unlimited":
2880
2881 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2882             Pedro Alves  <palves@redhat.com>
2883
2884         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2885         before calling rl_set_screen_size.
2886
2887 2019-02-27  Tom Tromey  <tromey@adacore.com>
2888
2889         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2890         define.
2891         * python/py-value.c: Remove Python 2.4 workaround.
2892         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2893         workaround.
2894         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2895         Python 2.4 workaround.
2896         * python/python-internal.h: Remove Python 2.4 comment.
2897         (Py_ssize_t): Don't define.
2898         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2899         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2900         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2901         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2902         * python/python.c (do_start_initialization): Remove Python 2.4
2903         workaround.
2904         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2905         (print_children): Remove Python 2.4 workaround.
2906         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2907         workaround.
2908         (CHARBUFFERPROC_NAME): Remove.
2909         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2910         Python 2.4 workaround.
2911
2912 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2913
2914         * NEWS: Note minimum Python version.
2915
2916 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2917
2918         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2919         code from these functions.  Remove corresponding ifdefs.  Use
2920         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2921         Remove gotos and target of gotos.
2922         (infpy_search_memory): Likewise.
2923
2924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2925
2926         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2927         (hppa_gdbarch_init): Don't register deleted functions with
2928         gdbarch.
2929
2930 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2933         (h8300_unwind_sp): Delete.
2934         (h8300_dummy_id): Delete.
2935         (h8300_gdbarch_init): Don't register deleted functions with
2936         gdbarch.
2937
2938 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2941         (ft32_unwind_pc): Delete.
2942         (ft32_unwind_sp): Delete.
2943         (ft32_gdbarch_init): Don't register deleted functions with
2944         gdbarch.
2945
2946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2949         (frv_unwind_pc): Delete.
2950         (frv_unwind_sp): Delete.
2951         (frv_gdbarch_init): Don't register deleted functions with
2952         gdbarch.
2953
2954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2957         (riscv_unwind_pc): Delete.
2958         (riscv_unwind_sp): Delete.
2959         (riscv_gdbarch_init): Don't register deleted functions with
2960         gdbarch.
2961
2962 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2963
2964         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2965         (csky_unwind_pc): Delete.
2966         (csky_unwind_sp): Delete.
2967         (csky_gdbarch_init): Don't register deleted functions with
2968         gdbarch.
2969
2970 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2973         (cris_unwind_pc): Delete.
2974         (cris_unwind_sp): Delete.
2975         (cris_gdbarch_init): Don't register deleted functions with
2976         gdbarch.
2977
2978 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2981         (bfin_unwind_pc): Delete.
2982         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2983
2984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2987         (arm_unwind_pc): Delete.
2988         (arm_unwind_sp): Delete.
2989         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2990
2991 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2992
2993         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2994         (arc_unwind_pc): Delete.
2995         (arc_unwind_sp): Delete.
2996         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2997
2998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3001         (alpha_unwind_pc): Delete.
3002         (alpha_gdbarch_init): Don't register deleted functions with
3003         gdbarch.
3004
3005 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3008         (aarch64_unwind_pc): Delete.
3009         (aarch64_unwind_sp): Delete.
3010         (aarch64_gdbarch_init): Don't register deleted functions with
3011         gdbarch.
3012
3013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3014
3015         * gdbtypes.c (type_align): Don't consider static members when
3016         computing structure alignment.
3017
3018 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3019
3020         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3021         return 0 for other types.
3022         * arch-utils.c (default_type_align): Always return 0.
3023         * gdbarch.h: Regenerate.
3024         * gdbarch.sh (type_align): Extend comment.
3025         * gdbtypes.c (type_align): Add additional comments, always call
3026         gdbarch_type_align before applying the default rules.
3027         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3028         generic code will then apply a suitable default.
3029         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3030         types, return 0 for other types.
3031
3032 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3033
3034         * NEWS: Create a new section for the next release branch.
3035         Rename the section of the current branch, now that it has
3036         been cut.
3037
3038 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3039
3040         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3041         * version.in: Bump version to 8.3.50.DATE-git.
3042
3043 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3044
3045         * aix-thread.c (ptid_cmp): Remove unused variable.
3046         (get_signaled_thread): Likewise.
3047         (store_regs_user_thread): Likewise.
3048         (store_regs_kernel_thread): Likewise.
3049         (fetch_regs_kernel_thread): Remove shadowed variable.
3050
3051 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * features/riscv/32bit-cpu.xml: Add register numbers.
3054         * features/riscv/32bit-fpu.c: Regenerate.
3055         * features/riscv/32bit-fpu.xml: Add register numbers.
3056         * features/riscv/64bit-cpu.xml: Add register numbers.
3057         * features/riscv/64bit-fpu.c: Regenerate.
3058         * features/riscv/64bit-fpu.xml: Add register numbers.
3059
3060 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3061
3062         * NEWS: Mention two argument form of gdb.Value constructor.
3063         * python/py-value.c (convert_buffer_and_type_to_value): New
3064         function.
3065         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3066         Add support for handling an optional second argument.  Call
3067         convert_buffer_and_type_to_value as appropriate.
3068         * python/python-internal.h (Py_buffer_deleter): New struct.
3069         (Py_buffer_up): New typedef.
3070
3071 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3072
3073         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3074         instead of releasing ownership.
3075
3076 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3077
3078         * dwarf2read.c (open_and_init_dwp_file): Call
3079         elf_numsections instead of bfd_count_sections to initialize
3080         dwp_file->num_sections.
3081
3082 2019-02-25  Tom Tromey  <tromey@adacore.com>
3083
3084         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3085
3086 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3087
3088         * gcore.in: Add '--readnever' option when invoking GDB.
3089
3090 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3091
3092         * MAINTAINERS: Update my email address.
3093
3094 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3095
3096         * build-id.c (build_id_to_debug_bfd_1): New function.
3097         (build_id_to_debug_bfd): Look for separate debug file in
3098         sysroot.
3099
3100 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * gdbarch.sh: Update the copyright year range that is placed into
3103         generated files.
3104
3105 2019-02-22  Keith Seitz  <keiths@redhat.com>
3106
3107         PR symtab/23853
3108         * linespec.c (create_sals_line_offset): Search for the default
3109         symtab's filename instead of its fullname.
3110
3111 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3112
3113         * NEWS: Update style defaults.
3114
3115 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3116
3117         * main.c (captured_main_1): Disable styling in batch mode.
3118
3119 2019-02-20  Tom Tromey  <tom@tromey.com>
3120
3121         * symtab.c (symtab_symbol_info): Fix typos.
3122
3123 2019-02-20  Tom Tromey  <tromey@adacore.com>
3124
3125         * findcmd.c (_initialize_mem_search): Use upper case for
3126         metasyntactic variables.
3127
3128 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3129
3130         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3131         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3132
3133 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3134
3135         * top.h (source_file_name): Change to std::string.
3136         * top.c (source_file_name): Likewise.
3137         (command_line_input): Adjust.
3138         * cli/cli-script.c (script_from_file): Adjust.
3139
3140 2019-02-19  Tom Tromey  <tromey@adacore.com>
3141
3142         * ravenscar-thread.c
3143         (ravenscar_thread_target::update_thread_list): Don't call
3144         ada_build_task_list.
3145         * ada-lang.h (ada_build_task_list): Don't declare.
3146         * ada-tasks.c (struct ada_tasks_inferior_data)
3147         <task_list_valid_p>: Now bool.
3148         (read_known_tasks, ada_task_list_changed)
3149         (ada_tasks_invalidate_inferior_data): Update.
3150         (read_known_tasks_array): Return bool.
3151         (read_known_tasks_list): Likewise.
3152         (read_known_tasks): Return void.
3153         (ada_build_task_list): Now static.
3154
3155 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3158         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3159
3160 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3161
3162         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3163         variant for ada_tasks_pspace_data_handle and
3164         ada_tasks_inferior_data_handle.
3165         (ada_tasks_pspace_data_cleanup): New function.
3166         (ada_tasks_inferior_data_cleanup): New function.
3167
3168 2019-02-17  Tom Tromey  <tom@tromey.com>
3169
3170         * macrotab.h (macro_source_fullname): Return a std::string.
3171         * macrotab.c (macro_include, check_for_redefinition)
3172         (macro_undef, macro_lookup_definition, foreach_macro)
3173         (foreach_macro_in_scope): Update.
3174         (macro_source_fullname): Return a std::string.
3175         * macrocmd.c (show_pp_source_pos): Update.
3176
3177 2019-02-17  Tom Tromey  <tom@tromey.com>
3178
3179         * macrocmd.c (show_pp_source_pos): Style the file names.
3180
3181 2019-02-17  Tom Tromey  <tom@tromey.com>
3182
3183         PR tui/24197:
3184         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3185
3186 2019-02-17  Tom Tromey  <tom@tromey.com>
3187
3188         * ada-lang.c (user_select_syms): Use filtered printing.
3189         * utils.c (wrap_style): New global.
3190         (desired_style): Remove.
3191         (emit_style_escape): Add stream parameter.
3192         (set_output_style, reset_terminal_style, prompt_for_continue):
3193         Update.
3194         (flush_wrap_buffer): Only flush gdb_stdout.
3195         (wrap_here): Set wrap_style.
3196         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3197         treat escape sequences as a character.  Change when wrap buffer is
3198         flushed.
3199         (fputs_styled): Do not set the output style when the default is
3200         requested.
3201         * ui-style.h (struct ui_file_style) <is_default>: New method.
3202         * source.c (print_source_lines_base): Emit escape sequences in one
3203         piece.
3204
3205 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3206
3207         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3208         integers and enumeration types.
3209
3210 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3211
3212         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3213         instead of lookup_symbol_in_language
3214         (do_exact_match): New function.
3215         (ada_get_symbol_name_matcher): Return do_exact_match when
3216         doing a verbatim match.
3217
3218 2019-02-15  Tom Tromey  <tromey@adacore.com>
3219
3220         * ravenscar-thread.c (ravenscar_thread_target::resume)
3221         (ravenscar_thread_target::wait): Special case wildcard requests.
3222
3223 2019-02-15  Tom Tromey  <tromey@adacore.com>
3224
3225         * ravenscar-thread.c (base_ptid): Remove.
3226         (struct ravenscar_thread_target) <close>: New method.
3227         <m_base_ptid>: New member.
3228         <update_inferior_ptid, active_task, task_is_currently_active,
3229         runtime_initialized>: Declare methods.
3230         <ravenscar_thread_target>: Add constructor.
3231         (ravenscar_thread_target::task_is_currently_active)
3232         (ravenscar_thread_target::update_inferior_ptid)
3233         (ravenscar_runtime_initialized): Rename.  Now methods.
3234         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3235         (ravenscar_thread_target::update_thread_list): Update.
3236         (ravenscar_thread_target::active_task): Now method.
3237         (ravenscar_thread_target::store_registers)
3238         (ravenscar_thread_target::prepare_to_store)
3239         (ravenscar_thread_target::prepare_to_store)
3240         (ravenscar_thread_target::mourn_inferior): Update.
3241         (ravenscar_inferior_created): Use "new" to create target.
3242         (ravenscar_thread_target::get_ada_task_ptid): Update.
3243         (_initialize_ravenscar): Don't initialize base_ptid.
3244         (ravenscar_ops): Remove global.
3245
3246 2019-02-15  Tom Tromey  <tromey@adacore.com>
3247
3248         * target.h (push_target): Declare new overload.
3249         * target.c (push_target): New overload, taking an rvalue reference.
3250         * remote.c (remote_target::open_1): Use push_target overload.
3251         * corelow.c (core_target_open): Use push_target overload.
3252
3253 2019-02-15  Tom Tromey  <tromey@adacore.com>
3254
3255         * ravenscar-thread.c (is_ravenscar_task)
3256         (ravenscar_task_is_currently_active): Return bool.
3257         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3258         (_initialize_ravenscar): Remove "(void)".
3259         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3260         Return bool.
3261
3262 2019-02-15  Tom Tromey  <tromey@adacore.com>
3263
3264         * ravenscar-thread.c (ravenscar_runtime_initializer)
3265         (has_ravenscar_runtime, get_running_thread_id)
3266         (ravenscar_thread_target::resume): Fix indentation.
3267
3268 2019-02-15  Tom Tromey  <tromey@adacore.com>
3269
3270         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3271         from ravenscar_arch_ops.
3272         (sparc_ravenscar_ops::fetch_registers)
3273         (sparc_ravenscar_ops::store_registers): Now methods.
3274         (sparc_ravenscar_prepare_to_store): Remove.
3275         (sparc_ravenscar_ops): Redefine.
3276         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3277         methods and destructor.  Remove members.
3278         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3279         (ravenscar_thread_target::store_registers)
3280         (ravenscar_thread_target::prepare_to_store): Update.
3281         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3282         Remove.
3283         (struct ppc_ravenscar_powerpc_ops): Derive from
3284         ravenscar_arch_ops.
3285         (ppc_ravenscar_powerpc_ops::fetch_registers)
3286         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3287         (ppc_ravenscar_powerpc_ops): Redefine.
3288         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3289         (ppc_ravenscar_e500_ops::fetch_registers)
3290         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3291         (ppc_ravenscar_e500_ops): Redefine.
3292         * aarch64-ravenscar-thread.c
3293         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3294         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3295         (aarch64_ravenscar_fetch_registers)
3296         (aarch64_ravenscar_store_registers): Now methods.
3297         (aarch64_ravenscar_ops): Redefine.
3298
3299 2019-02-15  Tom Tromey  <tromey@adacore.com>
3300
3301         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3302         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3303         (ravenscar_thread_target::stopped_by_watchpoint)
3304         (ravenscar_thread_target::stopped_data_address)
3305         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3306
3307 2019-02-15  Tom Tromey  <tromey@adacore.com>
3308
3309         * ravenscar-thread.c: Fix some typos.
3310
3311 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3312             Tom Tromey  <tromey@adacore.com>
3313
3314         * ada-lang.c (ada_exception_sal): Change addr_string to a
3315         std::string.
3316         (create_ada_exception_catchpoint): Update.
3317
3318 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3319             Tom Tromey  <tromey@adacore.com>
3320
3321         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3322         (bp_location_ops): Remove.
3323         (base_breakpoint_allocate_location): Update.
3324         (free_bp_location): Update.
3325         * ada-lang.c (class ada_catchpoint_location)
3326         <ada_catchpoint_location>: Remove ops parameter.
3327         (ada_catchpoint_location_dtor): Remove.
3328         (ada_catchpoint_location_ops): Remove.
3329         (allocate_location_exception): Update.
3330         * breakpoint.h (struct bp_location_ops): Remove.
3331         (class bp_location) <bp_location>: Remove bp_location_ops
3332         parameter.
3333         <~bp_location>: Add destructor.
3334         <ops>: Remove.
3335
3336 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3337             Pedro Alves  <palves@redhat.com>
3338
3339         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3340         'PATH_MAX'.
3341
3342 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3343             Samuel Thibault  <samuel.thibault@gnu.org>
3344             Thomas Schwinge  <thomas@codesourcery.com>
3345
3346         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3347         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3348
3349 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3350
3351         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3352         (check_empty): Use "const char *".
3353
3354         * gnu-nat.c (gnu_nat_target::detach): Instead of
3355         'detach_inferior (pid)' call
3356         'detach_inferior (find_inferior_pid (pid))'.
3357
3358         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3359         'nat/fork-inferior.o'.
3360         * gnu-nat.c: #include "nat/fork-inferior.h".
3361
3362         * gnu-nat.c (gnu_nat_target::detach): Instead of
3363         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3364         * gnu-nat.h: #include "inf-child.h".
3365         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3366         'i386_gnu_nat_target::fetch_registers'.
3367         (gnu_store_registers): Rename/move to
3368         'i386_gnu_nat_target::store_registers'.
3369
3370         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3371         * gnu-nat.h (mach_thread_info): New function.
3372         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3373
3374         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3375
3376 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3377
3378         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3379
3380 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3381
3382         * windows-nat.c (windows_add_thread): Add new parameter
3383         "main_thread_p" with default value set to false.  Update
3384         function documentation as well as all callers.
3385         (windows_delete_thread): Likewise.
3386         (fake_create_process): Update call to windows_add_thread.
3387         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3388         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3389         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3390         call to windows_delete_thread.
3391
3392 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3393
3394         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3395
3396 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3397
3398         * symfile.c (find_separate_debug_file): Use canonical path of
3399         sysroot with child_path instead of gdb_sysroot if it is valid.
3400
3401 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3402
3403         * symfile.c (find_separate_debug_file): Use child_path to
3404         determine if an object file is under a sysroot.
3405
3406 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3407
3408         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3409         unittests/child-path-selftests.c.
3410         * common/pathstuff.c (child_path): New function.
3411         * common/pathstuff.h (child_path): New prototype.
3412         * unittests/child-path-selftests.c: New file.
3413
3414 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3415
3416         * symfile.c (find_separate_debug_file): Look for separate debug
3417         files in debug directories under the sysroot.
3418
3419 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3420
3421         * symtab.h (struct minimal_symbol data_p): New const method.
3422         (struct minimal_symbol text_p): Likewise.
3423         * symtab.c (output_source_filename): Use file name style
3424         to print file name.
3425         (print_symbol_info): Likewise.
3426         (print_msymbol_info): Use address style to print addresses.
3427         Use function name style to print executable text symbols.
3428         (expand_symtab_containing_pc): Use data_p.
3429         (find_pc_sect_compunit_symtab): Likewise.
3430
3431 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3432
3433         * breakpoint.c (describe_other_breakpoints): Use address style
3434         to print addresses.
3435         (say_where): Likewise.
3436
3437 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3438
3439         * ada-typeprint.c (print_func_type): Print function name
3440         style to print function name.
3441         * c-typeprint.c (c_print_type_1): Likewise.
3442
3443 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3444
3445         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3446         for execve.
3447
3448 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3449
3450         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3451         type_stack.
3452
3453 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3454
3455         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3456         TYPE_CODE_REF types.
3457
3458 2019-02-08  Jim Wilson  <jimw@sifive.com>
3459
3460         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3461         (riscv_linux_fregset): New.
3462         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3463
3464 2019-02-07  Tom Tromey  <tom@tromey.com>
3465
3466         * thread.c (thread_cancel_execution_command): Update.
3467         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3468         methods.
3469         (struct thread_fsm_ops): Remove.
3470         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3471         (thread_fsm_should_stop, thread_fsm_return_value)
3472         (thread_fsm_set_finished, thread_fsm_finished_p)
3473         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3474         Don't declare.
3475         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3476         * infrun.c (clear_proceed_status_thread)
3477         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3478         (print_stop_event): Update.
3479         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3480         Add constructor.
3481         (step_command_fsm_ops): Remove.
3482         (new_step_command_fsm): Remove.
3483         (step_1): Update.
3484         (step_command_fsm::should_stop): Rename from
3485         step_command_fsm_should_stop.
3486         (step_command_fsm::clean_up): Rename from
3487         step_command_fsm_clean_up.
3488         (step_command_fsm::do_async_reply_reason): Rename from
3489         step_command_fsm_async_reply_reason.
3490         (struct until_next_fsm): Inherit from thread_fsm.  Add
3491         constructor.
3492         (until_next_fsm_ops): Remove.
3493         (new_until_next_fsm): Remove.
3494         (until_next_fsm::should_stop): Rename from
3495         until_next_fsm_should_stop.
3496         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3497         (until_next_fsm::do_async_reply_reason): Rename from
3498         until_next_fsm_async_reply_reason.
3499         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3500         constructor.  Change type of breakpoint.
3501         (finish_command_fsm_ops): Remove.
3502         (new_finish_command_fsm): Remove.
3503         (finish_command_fsm::should_stop): Rename from
3504         finish_command_fsm_should_stop.
3505         (finish_command_fsm::clean_up): Rename from
3506         finish_command_fsm_clean_up.
3507         (finish_command_fsm::return_value): Rename from
3508         finish_command_fsm_return_value.
3509         (finish_command_fsm::do_async_reply_reason): Rename from
3510         finish_command_fsm_async_reply_reason.
3511         (finish_command): Update.
3512         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3513         Add constructor.
3514         (call_thread_fsm_ops): Remove.
3515         (call_thread_fsm::call_thread_fsm): Rename from
3516         new_call_thread_fsm.
3517         (call_thread_fsm::should_stop): Rename from
3518         call_thread_fsm_should_stop.
3519         (call_thread_fsm::should_notify_stop): Rename from
3520         call_thread_fsm_should_notify_stop.
3521         (run_inferior_call, call_function_by_hand_dummy): Update.
3522         * cli/cli-interp.c (should_print_stop_to_console): Update.
3523         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3524         Add constructor.  Change type of location_breakpoint,
3525         caller_breakpoint.
3526         (until_break_fsm_ops): Remove.
3527         (new_until_break_fsm): Remove.
3528         (until_break_fsm::should_stop): Rename from
3529         until_break_fsm_should_stop.
3530         (until_break_fsm::clean_up): Rename from
3531         until_break_fsm_clean_up.
3532         (until_break_fsm::do_async_reply_reason): Rename from
3533         until_break_fsm_async_reply_reason.
3534         (until_break_command): Update.
3535         * thread-fsm.c: Remove.
3536         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3537
3538 2019-02-07  Tom Tromey  <tom@tromey.com>
3539
3540         * yy-remap.h: Add include guard.
3541         * xtensa-tdep.h: Add include guard.
3542         * xcoffread.h: Rename include guard.
3543         * varobj-iter.h: Add include guard.
3544         * tui/tui.h: Rename include guard.
3545         * tui/tui-winsource.h: Rename include guard.
3546         * tui/tui-wingeneral.h: Rename include guard.
3547         * tui/tui-windata.h: Rename include guard.
3548         * tui/tui-win.h: Rename include guard.
3549         * tui/tui-stack.h: Rename include guard.
3550         * tui/tui-source.h: Rename include guard.
3551         * tui/tui-regs.h: Rename include guard.
3552         * tui/tui-out.h: Rename include guard.
3553         * tui/tui-layout.h: Rename include guard.
3554         * tui/tui-io.h: Rename include guard.
3555         * tui/tui-hooks.h: Rename include guard.
3556         * tui/tui-file.h: Rename include guard.
3557         * tui/tui-disasm.h: Rename include guard.
3558         * tui/tui-data.h: Rename include guard.
3559         * tui/tui-command.h: Rename include guard.
3560         * tic6x-tdep.h: Add include guard.
3561         * target/waitstatus.h: Rename include guard.
3562         * target/wait.h: Rename include guard.
3563         * target/target.h: Rename include guard.
3564         * target/resume.h: Rename include guard.
3565         * target-float.h: Rename include guard.
3566         * stabsread.h: Add include guard.
3567         * rs6000-tdep.h: Add include guard.
3568         * riscv-fbsd-tdep.h: Add include guard.
3569         * regformats/regdef.h: Rename include guard.
3570         * record.h: Rename include guard.
3571         * python/python.h: Rename include guard.
3572         * python/python-internal.h: Rename include guard.
3573         * python/py-stopevent.h: Rename include guard.
3574         * python/py-ref.h: Rename include guard.
3575         * python/py-record.h: Rename include guard.
3576         * python/py-record-full.h: Rename include guard.
3577         * python/py-record-btrace.h: Rename include guard.
3578         * python/py-instruction.h: Rename include guard.
3579         * python/py-events.h: Rename include guard.
3580         * python/py-event.h: Rename include guard.
3581         * procfs.h: Add include guard.
3582         * proc-utils.h: Add include guard.
3583         * p-lang.h: Add include guard.
3584         * or1k-tdep.h: Rename include guard.
3585         * observable.h: Rename include guard.
3586         * nto-tdep.h: Rename include guard.
3587         * nat/x86-linux.h: Rename include guard.
3588         * nat/x86-linux-dregs.h: Rename include guard.
3589         * nat/x86-gcc-cpuid.h: Add include guard.
3590         * nat/x86-dregs.h: Rename include guard.
3591         * nat/x86-cpuid.h: Rename include guard.
3592         * nat/ppc-linux.h: Rename include guard.
3593         * nat/mips-linux-watch.h: Rename include guard.
3594         * nat/linux-waitpid.h: Rename include guard.
3595         * nat/linux-ptrace.h: Rename include guard.
3596         * nat/linux-procfs.h: Rename include guard.
3597         * nat/linux-osdata.h: Rename include guard.
3598         * nat/linux-nat.h: Rename include guard.
3599         * nat/linux-namespaces.h: Rename include guard.
3600         * nat/linux-btrace.h: Rename include guard.
3601         * nat/glibc_thread_db.h: Rename include guard.
3602         * nat/gdb_thread_db.h: Rename include guard.
3603         * nat/gdb_ptrace.h: Rename include guard.
3604         * nat/fork-inferior.h: Rename include guard.
3605         * nat/amd64-linux-siginfo.h: Rename include guard.
3606         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3607         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3608         * nat/aarch64-linux.h: Rename include guard.
3609         * nat/aarch64-linux-hw-point.h: Rename include guard.
3610         * mn10300-tdep.h: Add include guard.
3611         * mips-linux-tdep.h: Add include guard.
3612         * mi/mi-parse.h: Rename include guard.
3613         * mi/mi-out.h: Rename include guard.
3614         * mi/mi-main.h: Rename include guard.
3615         * mi/mi-interp.h: Rename include guard.
3616         * mi/mi-getopt.h: Rename include guard.
3617         * mi/mi-console.h: Rename include guard.
3618         * mi/mi-common.h: Rename include guard.
3619         * mi/mi-cmds.h: Rename include guard.
3620         * mi/mi-cmd-break.h: Rename include guard.
3621         * m2-lang.h: Add include guard.
3622         * location.h: Rename include guard.
3623         * linux-record.h: Rename include guard.
3624         * linux-nat.h: Add include guard.
3625         * linux-fork.h: Add include guard.
3626         * i386-darwin-tdep.h: Rename include guard.
3627         * hppa-linux-offsets.h: Add include guard.
3628         * guile/guile.h: Rename include guard.
3629         * guile/guile-internal.h: Rename include guard.
3630         * gnu-nat.h: Rename include guard.
3631         * gdb-stabs.h: Rename include guard.
3632         * frv-tdep.h: Add include guard.
3633         * f-lang.h: Add include guard.
3634         * event-loop.h: Add include guard.
3635         * darwin-nat.h: Rename include guard.
3636         * cp-abi.h: Rename include guard.
3637         * config/sparc/nm-sol2.h: Rename include guard.
3638         * config/nm-nto.h: Rename include guard.
3639         * config/nm-linux.h: Add include guard.
3640         * config/i386/nm-i386gnu.h: Rename include guard.
3641         * config/djgpp/nl_types.h: Rename include guard.
3642         * config/djgpp/langinfo.h: Rename include guard.
3643         * compile/gcc-cp-plugin.h: Add include guard.
3644         * compile/gcc-c-plugin.h: Add include guard.
3645         * compile/compile.h: Rename include guard.
3646         * compile/compile-object-run.h: Rename include guard.
3647         * compile/compile-object-load.h: Rename include guard.
3648         * compile/compile-internal.h: Rename include guard.
3649         * compile/compile-cplus.h: Rename include guard.
3650         * compile/compile-c.h: Rename include guard.
3651         * common/xml-utils.h: Rename include guard.
3652         * common/x86-xstate.h: Rename include guard.
3653         * common/version.h: Rename include guard.
3654         * common/vec.h: Rename include guard.
3655         * common/tdesc.h: Rename include guard.
3656         * common/selftest.h: Rename include guard.
3657         * common/scoped_restore.h: Rename include guard.
3658         * common/scoped_mmap.h: Rename include guard.
3659         * common/scoped_fd.h: Rename include guard.
3660         * common/safe-iterator.h: Rename include guard.
3661         * common/run-time-clock.h: Rename include guard.
3662         * common/refcounted-object.h: Rename include guard.
3663         * common/queue.h: Rename include guard.
3664         * common/ptid.h: Rename include guard.
3665         * common/print-utils.h: Rename include guard.
3666         * common/preprocessor.h: Rename include guard.
3667         * common/pathstuff.h: Rename include guard.
3668         * common/observable.h: Rename include guard.
3669         * common/netstuff.h: Rename include guard.
3670         * common/job-control.h: Rename include guard.
3671         * common/host-defs.h: Rename include guard.
3672         * common/gdb_wait.h: Rename include guard.
3673         * common/gdb_vecs.h: Rename include guard.
3674         * common/gdb_unlinker.h: Rename include guard.
3675         * common/gdb_unique_ptr.h: Rename include guard.
3676         * common/gdb_tilde_expand.h: Rename include guard.
3677         * common/gdb_sys_time.h: Rename include guard.
3678         * common/gdb_string_view.h: Rename include guard.
3679         * common/gdb_splay_tree.h: Rename include guard.
3680         * common/gdb_setjmp.h: Rename include guard.
3681         * common/gdb_ref_ptr.h: Rename include guard.
3682         * common/gdb_optional.h: Rename include guard.
3683         * common/gdb_locale.h: Rename include guard.
3684         * common/gdb_assert.h: Rename include guard.
3685         * common/filtered-iterator.h: Rename include guard.
3686         * common/filestuff.h: Rename include guard.
3687         * common/fileio.h: Rename include guard.
3688         * common/environ.h: Rename include guard.
3689         * common/common-utils.h: Rename include guard.
3690         * common/common-types.h: Rename include guard.
3691         * common/common-regcache.h: Rename include guard.
3692         * common/common-inferior.h: Rename include guard.
3693         * common/common-gdbthread.h: Rename include guard.
3694         * common/common-exceptions.h: Rename include guard.
3695         * common/common-defs.h: Rename include guard.
3696         * common/common-debug.h: Rename include guard.
3697         * common/cleanups.h: Rename include guard.
3698         * common/buffer.h: Rename include guard.
3699         * common/btrace-common.h: Rename include guard.
3700         * common/break-common.h: Rename include guard.
3701         * cli/cli-utils.h: Rename include guard.
3702         * cli/cli-style.h: Rename include guard.
3703         * cli/cli-setshow.h: Rename include guard.
3704         * cli/cli-script.h: Rename include guard.
3705         * cli/cli-interp.h: Rename include guard.
3706         * cli/cli-decode.h: Rename include guard.
3707         * cli/cli-cmds.h: Rename include guard.
3708         * charset-list.h: Add include guard.
3709         * buildsym-legacy.h: Rename include guard.
3710         * bfin-tdep.h: Add include guard.
3711         * ax.h: Rename include guard.
3712         * arm-linux-tdep.h: Add include guard.
3713         * arm-fbsd-tdep.h: Add include guard.
3714         * arch/xtensa.h: Rename include guard.
3715         * arch/tic6x.h: Add include guard.
3716         * arch/i386.h: Add include guard.
3717         * arch/arm.h: Rename include guard.
3718         * arch/arm-linux.h: Rename include guard.
3719         * arch/arm-get-next-pcs.h: Rename include guard.
3720         * arch/amd64.h: Add include guard.
3721         * arch/aarch64-insn.h: Rename include guard.
3722         * arch-utils.h: Rename include guard.
3723         * annotate.h: Add include guard.
3724         * amd64-darwin-tdep.h: Rename include guard.
3725         * aarch64-linux-tdep.h: Add include guard.
3726         * aarch64-fbsd-tdep.h: Add include guard.
3727         * aarch32-linux-nat.h: Add include guard.
3728
3729 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3730
3731         * macrotab.c (macro_define_internal): New function that
3732         factorizes macro_define_object_internal and macro_define_function
3733         code.
3734         (macro_define_object_internal): Use macro_define_internal.
3735         (macro_define_function): Likewise.
3736
3737 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3738
3739         * macrocmd.c (extract_identifier): Return
3740         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3741         callers.
3742
3743 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3744
3745         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3746
3747 2019-02-05  Tom Tromey  <tom@tromey.com>
3748
3749         * target.c (target_stack::unpush): Move assertion earlier.
3750
3751 2019-01-30  Tom Tromey  <tom@tromey.com>
3752
3753         PR python/23615:
3754         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3755         (gdbpy_parse_and_eval): Likewise.
3756         * python/python-internal.h (gdbpy_allow_threads): New class.
3757
3758 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3759
3760         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3761         (aarch64_fbsd_fpregmap): Move earlier.
3762         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3763         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3764         instead of individual calls to trad_frame_set_reg_addr.
3765         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3766         earlier.
3767         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3768         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3769         instead of individual calls to trad_frame_set_reg_addr.
3770
3771 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3772
3773         * CONTRIBUTE: Replace contribution list with wiki link.
3774
3775 2019-01-25  Tom Tromey  <tom@tromey.com>
3776
3777         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3778
3779 2019-01-25  Tom Tromey  <tom@tromey.com>
3780
3781         * xtensa-linux-nat.c: Fix common/ includes.
3782         * xml-support.h: Fix common/ includes.
3783         * xml-support.c: Fix common/ includes.
3784         * x86-linux-nat.c: Fix common/ includes.
3785         * windows-nat.c: Fix common/ includes.
3786         * varobj.h: Fix common/ includes.
3787         * varobj.c: Fix common/ includes.
3788         * value.c: Fix common/ includes.
3789         * valops.c: Fix common/ includes.
3790         * utils.c: Fix common/ includes.
3791         * unittests/xml-utils-selftests.c: Fix common/ includes.
3792         * unittests/utils-selftests.c: Fix common/ includes.
3793         * unittests/unpack-selftests.c: Fix common/ includes.
3794         * unittests/tracepoint-selftests.c: Fix common/ includes.
3795         * unittests/style-selftests.c: Fix common/ includes.
3796         * unittests/string_view-selftests.c: Fix common/ includes.
3797         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3798         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3799         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3800         * unittests/rsp-low-selftests.c: Fix common/ includes.
3801         * unittests/parse-connection-spec-selftests.c: Fix common/
3802         includes.
3803         * unittests/optional-selftests.c: Fix common/ includes.
3804         * unittests/offset-type-selftests.c: Fix common/ includes.
3805         * unittests/observable-selftests.c: Fix common/ includes.
3806         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3807         * unittests/memrange-selftests.c: Fix common/ includes.
3808         * unittests/memory-map-selftests.c: Fix common/ includes.
3809         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3810         * unittests/function-view-selftests.c: Fix common/ includes.
3811         * unittests/environ-selftests.c: Fix common/ includes.
3812         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3813         * unittests/common-utils-selftests.c: Fix common/ includes.
3814         * unittests/cli-utils-selftests.c: Fix common/ includes.
3815         * unittests/array-view-selftests.c: Fix common/ includes.
3816         * ui-file.c: Fix common/ includes.
3817         * tui/tui-io.c: Fix common/ includes.
3818         * tracepoint.h: Fix common/ includes.
3819         * tracepoint.c: Fix common/ includes.
3820         * tracefile-tfile.c: Fix common/ includes.
3821         * top.h: Fix common/ includes.
3822         * top.c: Fix common/ includes.
3823         * thread.c: Fix common/ includes.
3824         * target/waitstatus.h: Fix common/ includes.
3825         * target/waitstatus.c: Fix common/ includes.
3826         * target.h: Fix common/ includes.
3827         * target.c: Fix common/ includes.
3828         * target-memory.c: Fix common/ includes.
3829         * target-descriptions.c: Fix common/ includes.
3830         * symtab.h: Fix common/ includes.
3831         * symfile.c: Fix common/ includes.
3832         * stap-probe.c: Fix common/ includes.
3833         * spu-linux-nat.c: Fix common/ includes.
3834         * sparc-nat.c: Fix common/ includes.
3835         * source.c: Fix common/ includes.
3836         * solib.c: Fix common/ includes.
3837         * solib-target.c: Fix common/ includes.
3838         * ser-unix.c: Fix common/ includes.
3839         * ser-tcp.c: Fix common/ includes.
3840         * ser-pipe.c: Fix common/ includes.
3841         * ser-base.c: Fix common/ includes.
3842         * selftest-arch.c: Fix common/ includes.
3843         * s12z-tdep.c: Fix common/ includes.
3844         * rust-exp.y: Fix common/ includes.
3845         * rs6000-aix-tdep.c: Fix common/ includes.
3846         * riscv-tdep.c: Fix common/ includes.
3847         * remote.c: Fix common/ includes.
3848         * remote-notif.h: Fix common/ includes.
3849         * remote-fileio.h: Fix common/ includes.
3850         * remote-fileio.c: Fix common/ includes.
3851         * regcache.h: Fix common/ includes.
3852         * regcache.c: Fix common/ includes.
3853         * record-btrace.c: Fix common/ includes.
3854         * python/python.c: Fix common/ includes.
3855         * python/py-type.c: Fix common/ includes.
3856         * python/py-inferior.c: Fix common/ includes.
3857         * progspace.h: Fix common/ includes.
3858         * producer.c: Fix common/ includes.
3859         * procfs.c: Fix common/ includes.
3860         * proc-api.c: Fix common/ includes.
3861         * printcmd.c: Fix common/ includes.
3862         * ppc-linux-nat.c: Fix common/ includes.
3863         * parser-defs.h: Fix common/ includes.
3864         * osdata.c: Fix common/ includes.
3865         * obsd-nat.c: Fix common/ includes.
3866         * nat/x86-linux.c: Fix common/ includes.
3867         * nat/x86-linux-dregs.c: Fix common/ includes.
3868         * nat/x86-dregs.h: Fix common/ includes.
3869         * nat/x86-dregs.c: Fix common/ includes.
3870         * nat/ppc-linux.c: Fix common/ includes.
3871         * nat/mips-linux-watch.h: Fix common/ includes.
3872         * nat/mips-linux-watch.c: Fix common/ includes.
3873         * nat/linux-waitpid.c: Fix common/ includes.
3874         * nat/linux-ptrace.h: Fix common/ includes.
3875         * nat/linux-ptrace.c: Fix common/ includes.
3876         * nat/linux-procfs.c: Fix common/ includes.
3877         * nat/linux-personality.c: Fix common/ includes.
3878         * nat/linux-osdata.c: Fix common/ includes.
3879         * nat/linux-namespaces.c: Fix common/ includes.
3880         * nat/linux-btrace.h: Fix common/ includes.
3881         * nat/linux-btrace.c: Fix common/ includes.
3882         * nat/fork-inferior.c: Fix common/ includes.
3883         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3884         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3885         * nat/aarch64-linux.c: Fix common/ includes.
3886         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3887         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3888         * namespace.h: Fix common/ includes.
3889         * mips-linux-tdep.c: Fix common/ includes.
3890         * minsyms.c: Fix common/ includes.
3891         * mi/mi-parse.h: Fix common/ includes.
3892         * mi/mi-main.c: Fix common/ includes.
3893         * mi/mi-cmd-env.c: Fix common/ includes.
3894         * memrange.h: Fix common/ includes.
3895         * memattr.c: Fix common/ includes.
3896         * maint.h: Fix common/ includes.
3897         * maint.c: Fix common/ includes.
3898         * main.c: Fix common/ includes.
3899         * machoread.c: Fix common/ includes.
3900         * location.c: Fix common/ includes.
3901         * linux-thread-db.c: Fix common/ includes.
3902         * linux-nat.c: Fix common/ includes.
3903         * linux-fork.c: Fix common/ includes.
3904         * inline-frame.c: Fix common/ includes.
3905         * infrun.c: Fix common/ includes.
3906         * inflow.c: Fix common/ includes.
3907         * inferior.h: Fix common/ includes.
3908         * inferior.c: Fix common/ includes.
3909         * infcmd.c: Fix common/ includes.
3910         * inf-ptrace.c: Fix common/ includes.
3911         * inf-child.c: Fix common/ includes.
3912         * ia64-linux-nat.c: Fix common/ includes.
3913         * i387-tdep.c: Fix common/ includes.
3914         * i386-tdep.c: Fix common/ includes.
3915         * i386-linux-tdep.c: Fix common/ includes.
3916         * i386-linux-nat.c: Fix common/ includes.
3917         * i386-go32-tdep.c: Fix common/ includes.
3918         * i386-fbsd-tdep.c: Fix common/ includes.
3919         * i386-fbsd-nat.c: Fix common/ includes.
3920         * guile/scm-type.c: Fix common/ includes.
3921         * guile/guile.c: Fix common/ includes.
3922         * go32-nat.c: Fix common/ includes.
3923         * gnu-nat.c: Fix common/ includes.
3924         * gdbthread.h: Fix common/ includes.
3925         * gdbarch-selftests.c: Fix common/ includes.
3926         * gdb_usleep.c: Fix common/ includes.
3927         * gdb_select.h: Fix common/ includes.
3928         * gdb_bfd.c: Fix common/ includes.
3929         * gcore.c: Fix common/ includes.
3930         * fork-child.c: Fix common/ includes.
3931         * findvar.c: Fix common/ includes.
3932         * fbsd-nat.c: Fix common/ includes.
3933         * event-top.c: Fix common/ includes.
3934         * event-loop.c: Fix common/ includes.
3935         * dwarf2read.c: Fix common/ includes.
3936         * dwarf2loc.c: Fix common/ includes.
3937         * dwarf2-frame.c: Fix common/ includes.
3938         * dwarf-index-cache.c: Fix common/ includes.
3939         * dtrace-probe.c: Fix common/ includes.
3940         * disasm-selftests.c: Fix common/ includes.
3941         * defs.h: Fix common/ includes.
3942         * csky-tdep.c: Fix common/ includes.
3943         * cp-valprint.c: Fix common/ includes.
3944         * cp-support.h: Fix common/ includes.
3945         * cp-support.c: Fix common/ includes.
3946         * corelow.c: Fix common/ includes.
3947         * completer.h: Fix common/ includes.
3948         * completer.c: Fix common/ includes.
3949         * compile/compile.c: Fix common/ includes.
3950         * compile/compile-loc2c.c: Fix common/ includes.
3951         * compile/compile-cplus-types.c: Fix common/ includes.
3952         * compile/compile-cplus-symbols.c: Fix common/ includes.
3953         * command.h: Fix common/ includes.
3954         * cli/cli-dump.c: Fix common/ includes.
3955         * cli/cli-cmds.c: Fix common/ includes.
3956         * charset.c: Fix common/ includes.
3957         * build-id.c: Fix common/ includes.
3958         * btrace.h: Fix common/ includes.
3959         * btrace.c: Fix common/ includes.
3960         * breakpoint.h: Fix common/ includes.
3961         * breakpoint.c: Fix common/ includes.
3962         * ax.h: 
3963         (enum agent_op): Fix common/ includes.
3964         * ax-general.c (struct aop_map): Fix common/ includes.
3965         * ax-gdb.c: Fix common/ includes.
3966         * auxv.c: Fix common/ includes.
3967         * auto-load.c: Fix common/ includes.
3968         * arm-tdep.c: Fix common/ includes.
3969         * arch/riscv.c: Fix common/ includes.
3970         * arch/ppc-linux-common.c: Fix common/ includes.
3971         * arch/i386.c: Fix common/ includes.
3972         * arch/arm.c: Fix common/ includes.
3973         * arch/arm-linux.c: Fix common/ includes.
3974         * arch/arm-get-next-pcs.c: Fix common/ includes.
3975         * arch/amd64.c: Fix common/ includes.
3976         * arch/aarch64.c: Fix common/ includes.
3977         * arch/aarch64-insn.c: Fix common/ includes.
3978         * arch-utils.c: Fix common/ includes.
3979         * amd64-windows-tdep.c: Fix common/ includes.
3980         * amd64-tdep.c: Fix common/ includes.
3981         * amd64-sol2-tdep.c: Fix common/ includes.
3982         * amd64-obsd-tdep.c: Fix common/ includes.
3983         * amd64-nbsd-tdep.c: Fix common/ includes.
3984         * amd64-linux-tdep.c: Fix common/ includes.
3985         * amd64-linux-nat.c: Fix common/ includes.
3986         * amd64-fbsd-tdep.c: Fix common/ includes.
3987         * amd64-fbsd-nat.c: Fix common/ includes.
3988         * amd64-dicos-tdep.c: Fix common/ includes.
3989         * amd64-darwin-tdep.c: Fix common/ includes.
3990         * agent.c: Fix common/ includes.
3991         * ada-lang.h: Fix common/ includes.
3992         * ada-lang.c: Fix common/ includes.
3993         * aarch64-tdep.c: Fix common/ includes.
3994
3995 2019-01-25  Tom Tromey  <tom@tromey.com>
3996
3997         * common/create-version.sh: Use common/version.h.
3998
3999 2019-01-24  Pedro Alves  <palves@redhat.com>
4000
4001         * infrun.c (signal_stop, signal_print, signal_program)
4002         (signal_catch, signal_pass): Now arrays instead of pointers.
4003         (update_signals_program_target, do_target_resume)
4004         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4005         * linux-nat.c (linux_nat_target::pass_signals)
4006         (linux_nat_target::create_inferior, linux_nat_target::attach):
4007         Adjust.
4008         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4009         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4010         * procfs.c (procfs_target::pass_signals): Adjust.
4011         * record-full.c (record_full_target::resume): Adjust.
4012         * remote.c (remote_target::pass_signals)
4013         (remote_target::program_signals): Adjust.
4014         * target-debug.h (target_debug_print_signals): Now takes a
4015         gdb::array_view as parameter.  Adjust.
4016         * target.h (target_ops) <pass_signals, program_signals>: Replace
4017         pointer and length parameters with gdb::array_view.
4018         (target_pass_signals, target_program_signals): Likewise.
4019         * target-delegates.c: Regenerate.
4020
4021 2019-01-24  Pedro Alves  <palves@redhat.com>
4022
4023         * common/forward-scope-exit.h
4024         (forward_scope_exit::forward_scope_exit): Pass arguments to
4025         m_bind_function directly, instead of creating a std::bind and
4026         copying that.
4027
4028 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4029
4030         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4031         for static members.
4032         (pass_in_v_vfp_candidate): Likewise.
4033
4034 2019-01-23  Tom Tromey  <tom@tromey.com>
4035             Pedro Alves  <palves@redhat.com>
4036
4037         * regcache.c (class regcache_invalidator): Remove.
4038         (regcache::raw_write): Use make_scope_exit.
4039
4040 2019-01-23  Tom Tromey  <tom@tromey.com>
4041
4042         * ui-out.h (class ui_out_emit_type): Update comment.
4043
4044 2019-01-23  Tom Tromey  <tom@tromey.com>
4045
4046         * infrun.c (fetch_inferior_event): Update comment.
4047
4048 2019-01-23  Tom Tromey  <tom@tromey.com>
4049             Pedro Alves  <palves@redhat.com>
4050
4051         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4052         parameter.
4053         (fetch_inferior_event): Use SCOPE_EXIT.
4054
4055
4056 2019-01-23  Tom Tromey  <tom@tromey.com>
4057             Pedro Alves  <palves@redhat.com>
4058
4059         * infrun.c (disable_thread_events): Delete.
4060         (stop_all_threads): Use SCOPE_EXIT.
4061
4062 2019-01-23  Tom Tromey  <tom@tromey.com>
4063             Pedro Alves  <palves@redhat.com>
4064
4065         * symfile.c: Include forward-scope-exit.h.
4066         (clear_symtab_users_cleanup): Replace forward declaration with
4067         a FORWARD_SCOPE_EXIT.
4068         (syms_from_objfile_1): Use the forward_scope_exit and
4069         gdb::optional instead of cleanup_function.
4070         (reread_symbols): Use the forward_scope_exit instead of
4071         cleanup_function.
4072         (clear_symtab_users_cleanup): Remove function.
4073
4074 2019-01-23  Tom Tromey  <tom@tromey.com>
4075             Pedro Alves  <palves@redhat.com>
4076
4077         * linux-nat.c: Include scope-exit.h.
4078         (cleanup_target_stop): Remove.
4079         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4080         SCOPE_EXIT.
4081
4082 2019-01-23  Tom Tromey  <tom@tromey.com>
4083             Pedro Alves  <palves@redhat.com>
4084
4085         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4086         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4087
4088 2019-01-23  Tom Tromey  <tom@tromey.com>
4089             Andrew Burgess  <andrew.burgess@embecosm.com>
4090             Pedro Alves  <palves@redhat.com>
4091
4092         * infrun.c (fetch_inferior_event): Use scope_exit.
4093         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4094         * top.c (execute_command): Use scope_exit.
4095         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4096         * utils.c (do_bpstat_clear_actions_cleanup)
4097         (make_bpstat_clear_actions_cleanup): Remove.
4098
4099 2019-01-23  Tom Tromey  <tom@tromey.com>
4100             Pedro Alves  <palves@redhat.com>
4101
4102         * infrun.c: Include "common/scope-exit.h"
4103         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4104         (wait_for_inferior): Use SCOPE_EXIT.
4105         (fetch_inferior_event): Use scope_exit.
4106
4107 2019-01-23  Tom Tromey  <tom@tromey.com>
4108             Pedro Alves  <palves@redhat.com>
4109
4110         * breakpoint.c (create_breakpoint): Remove cleanup.
4111
4112 2019-01-23  Tom Tromey  <tom@tromey.com>
4113             Andrew Burgess  <andrew.burgess@embecosm.com>
4114             Pedro Alves  <palves@redhat.com>
4115
4116 2019-01-23  Pedro Alves  <palves@redhat.com>
4117
4118         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4119
4120 2019-01-23  Pedro Alves  <palves@redhat.com>
4121             Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * gdbthread.h: Include "common/forward-scope-exit.h".
4124         (scoped_finish_thread_state): Redefine custom class in terms of
4125         forward_scope_exit.
4126
4127 2019-01-23  Pedro Alves  <palves@redhat.com>
4128             Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * common/forward-scope-exit.h: New file.
4131
4132 2019-01-23  Pedro Alves  <palves@redhat.com>
4133             Andrew Burgess  <andrew.burgess@embecosm.com>
4134             Tom Tromey  <tom@tromey.com>
4135
4136         * common/scope-exit.h: New file.
4137
4138 2019-01-23  Pedro Alves  <palves@redhat.com>
4139
4140         * common/preprocessor.h (ESC): Rename to ...
4141         (ESC_PARENS): ... this.
4142         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4143         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4144
4145 2019-01-23  Tom Tromey  <tom@tromey.com>
4146
4147         * language.h (class scoped_switch_to_sym_language_if_auto):
4148         Initialize m_lang in both cases.
4149
4150 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4151
4152         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4153         with XCNEW.
4154
4155 2019-01-22  Tom Tromey  <tom@tromey.com>
4156
4157         * corelow.c: Do not include sys/file.h.
4158
4159 2019-01-22  Tom Tromey  <tom@tromey.com>
4160
4161         * tui/tui-wingeneral.h: Include gdb_curses.h.
4162
4163 2019-01-22  Tom Tromey  <tom@tromey.com>
4164
4165         * source-cache.h (class source_cache) <get_source_lines,
4166         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4167
4168 2019-01-22  Tom Tromey  <tom@tromey.com>
4169
4170         * remote-fileio.h (struct remote_target): Declare.
4171
4172 2019-01-22  Tom Tromey  <tom@tromey.com>
4173
4174         * python/py-arch.c: Do not include py-ref.h.
4175         * python/py-bpevent.c: Do not include py-ref.h.
4176         * python/py-cmd.c: Do not include py-ref.h.
4177         * python/py-continueevent.c: Do not include py-ref.h.
4178         * python/py-event.h: Do not include py-ref.h.
4179         * python/py-evtregistry.c: Do not include py-ref.h.
4180         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4181         * python/py-frame.c: Do not include py-ref.h.
4182         * python/py-framefilter.c: Do not include py-ref.h.
4183         * python/py-function.c: Do not include py-ref.h.
4184         * python/py-infevents.c: Do not include py-ref.h.
4185         * python/py-linetable.c: Do not include py-ref.h.
4186         * python/py-objfile.c: Do not include py-ref.h.
4187         * python/py-param.c: Do not include py-ref.h.
4188         * python/py-prettyprint.c: Do not include py-ref.h.
4189         * python/py-progspace.c: Do not include py-ref.h.
4190         * python/py-symbol.c: Do not include py-ref.h.
4191         * python/py-symtab.c: Do not include py-ref.h.
4192         * python/py-type.c: Do not include py-ref.h.
4193         * python/py-unwind.c: Do not include py-ref.h.
4194         * python/py-utils.c: Do not include py-ref.h.
4195         * python/py-value.c: Do not include py-ref.h.
4196         * python/py-varobj.c: Do not include py-ref.h.
4197         * python/py-xmethods.c: Do not include py-ref.h.
4198         * python/python.c: Do not include py-ref.h.
4199         * varobj.c: Do not include py-ref.h.
4200
4201 2019-01-22  Tom Tromey  <tom@tromey.com>
4202
4203         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4204         keyword for bcache.
4205
4206 2019-01-22  Tom Tromey  <tom@tromey.com>
4207
4208         * compile/compile-cplus-types.c: Remove a comment by #include.
4209
4210 2019-01-22  Tom Tromey  <tom@tromey.com>
4211
4212         * compile/gcc-c-plugin.h: Include compile-internal.h.
4213
4214 2019-01-22  Tom Tromey  <tom@tromey.com>
4215
4216         * stabsread.c (EXTERN): Do not define.
4217         (symnum, next_symbol_text_func, processing_gcc_compilation)
4218         (within_function, global_sym_chain, global_stabs)
4219         (previous_stab_code, this_object_header_files)
4220         (n_this_object_header_files)
4221         (n_allocated_this_object_header_files): Define.
4222         * stabsread.h (EXTERN): Never define.  Use "extern".
4223
4224 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4225
4226         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4227         history_value.
4228
4229 2019-01-21  Tom Tromey  <tom@tromey.com>
4230
4231         * ui-out.c: Fix includes.
4232         * tui/tui-source.c: Fix includes.
4233         * target.c: Fix includes.
4234         * remote.c: Fix includes.
4235         * regcache.c: Fix includes.
4236         * python/py-block.c: Fix includes.
4237         * printcmd.c: Fix includes.
4238         * or1k-tdep.c: Fix includes.
4239         * mi/mi-main.c: Fix includes.
4240         * m32r-tdep.c: Fix includes.
4241         * csky-tdep.c: Fix includes.
4242         * compile/compile-cplus-types.c: Fix includes.
4243         * cli/cli-interp.c: Fix includes.
4244
4245 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4246
4247         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4248         for padding.
4249
4250 2019-01-16  Tom Tromey  <tom@tromey.com>
4251
4252         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4253         earlier.
4254         (struct objfile) <msymbols_range>: Move from top level.
4255         <msymbols>: New method.
4256         (class objfile_msymbols): Remove.
4257         * symtab.c (default_collect_symbol_completion_matches_break_on):
4258         Update.
4259         * symmisc.c (dump_msymbols): Update.
4260         * stabsread.c (scan_file_globals): Update.
4261         * objc-lang.c (info_selectors_command, info_classes_command)
4262         (find_methods): Update.
4263         * minsyms.c (find_solib_trampoline_target): Update.
4264         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4265         * coffread.c (coff_symfile_read): Update.
4266         * ada-lang.c (ada_lookup_simple_minsym)
4267         (ada_collect_symbol_completion_matches): Update.
4268
4269 2019-01-16  Tom Tromey  <tom@tromey.com>
4270
4271         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4272         type.  Remove no-argument constructor.
4273         <iterator::operator++>: Simplify.
4274         <begin>: Update.
4275         <end>: Use minimal_symbol_count.
4276
4277 2019-01-16  Tom Tromey  <tom@tromey.com>
4278
4279         * objfiles.h (struct objfile) <psymtabs>: New method.
4280         (class objfile_psymtabs): Remove.
4281         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4282         typedef.
4283         <range>: New method.
4284         (require_partial_symbols): Change return type.
4285         * psymtab.c (require_partial_symbols)
4286         (psym_expand_symtabs_matching): Update.
4287         * mdebugread.c (parse_partial_symbols): Update.
4288         * dbxread.c (dbx_end_psymtab): Update.
4289
4290 2019-01-15  Tom Tromey  <tom@tromey.com>
4291
4292         * symtab.c (lookup_objfile_from_block)
4293         (lookup_symbol_in_objfile_symtabs)
4294         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4295         (find_line_symtab, info_sources_command)
4296         (default_collect_symbol_completion_matches_break_on)
4297         (make_source_files_completion_list): Update.
4298         * symmisc.c (print_objfile_statistics, dump_objfile)
4299         (maintenance_print_symbols, maintenance_info_symtabs)
4300         (maintenance_check_symtabs, maintenance_info_line_tables):
4301         Update.
4302         * source.c (select_source_symtab)
4303         (forget_cached_source_info_for_objfile): Update.
4304         * objfiles.h (class objfile_compunits): Remove.
4305         (struct objfile) <compunits_range>: New typedef.
4306         (compunits): New method.
4307         * objfiles.c (objfile_relocate1): Update.
4308         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4309         * maint.c (count_symtabs_and_blocks): Update.
4310         * linespec.c (iterate_over_all_matching_symtabs): Update.
4311         * cp-support.c (add_symbol_overload_list_qualified): Update.
4312         * coffread.c (coff_symtab_read): Update.
4313         * ada-lang.c (add_nonlocal_symbols)
4314         (ada_collect_symbol_completion_matches)
4315         (ada_add_global_exceptions): Update.
4316
4317 2019-01-15  Tom Tromey  <tom@tromey.com>
4318
4319         * progspace.h (program_space) <objfiles_safe_range>: New
4320         typedef.
4321         <objfiles_safe>: New method.
4322         * objfiles.h (class all_objfiles_safe): Remove.
4323         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4324         * jit.c (jit_inferior_exit_hook): Update.
4325
4326 2019-01-17  Tom Tromey  <tom@tromey.com>
4327
4328         * progspace.h (program_space) <objfiles_range>: New typedef.
4329         <objfiles>: New method.
4330         <objfiles_head>: Rename from objfiles.
4331         (object_files): Update.
4332         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4333         * guile/scm-pretty-print.c
4334         (ppscm_find_pretty_printer_from_objfiles): Update.
4335         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4336         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4337         Update.
4338         * python/py-progspace.c (pspy_get_objfiles): Update.
4339         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4340         Update.
4341         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4342         (objfpy_lookup_objfile_by_build_id): Update.
4343         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4344         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4345         Update.
4346         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4347         (expand_symtab_containing_pc, lookup_objfile_from_block)
4348         (lookup_static_symbol, basic_lookup_transparent_type)
4349         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4350         (find_line_symtab, info_sources_command)
4351         (default_collect_symbol_completion_matches_break_on)
4352         (make_source_files_completion_list, find_main_name): Update.
4353         * symmisc.c (print_symbol_bcache_statistics)
4354         (print_objfile_statistics, maintenance_print_symbols)
4355         (maintenance_print_msymbols, maintenance_print_objfiles)
4356         (maintenance_info_symtabs, maintenance_check_symtabs)
4357         (maintenance_expand_symtabs, maintenance_info_line_tables):
4358         Update.
4359         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4360         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4361         (map_overlay_command, unmap_overlay_command)
4362         (simple_overlay_update, expand_symtabs_matching)
4363         (map_symbol_filenames): Update.
4364         * symfile-debug.c (set_debug_symfile): Update.
4365         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4366         Update.
4367         * source.c (select_source_symtab, forget_cached_source_info):
4368         Update.
4369         * solib.c (solib_read_symbols): Update.
4370         * solib-spu.c (append_ocl_sos): Update.
4371         * psymtab.c (maintenance_print_psymbols)
4372         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4373         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4374         * printcmd.c (info_symbol_command): Update.
4375         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4376         Update.
4377         * objfiles.h (class all_objfiles): Remove.
4378         * objfiles.c (have_partial_symbols, have_full_symbols)
4379         (have_minimal_symbols, qsort_cmp, update_section_map)
4380         (shared_objfile_contains_address_p)
4381         (default_iterate_over_objfiles_in_search_order): Update.
4382         * objc-lang.c (info_selectors_command, info_classes_command)
4383         (find_methods): Update.
4384         * minsyms.c (find_solib_trampoline_target): Update.
4385         * maint.c (maintenance_info_sections)
4386         (maintenance_translate_address, count_symtabs_and_blocks):
4387         Update.
4388         * main.c (captured_main_1): Update.
4389         * linux-thread-db.c (try_thread_db_load_from_pdir)
4390         (has_libpthread): Update.
4391         * linespec.c (iterate_over_all_matching_symtabs)
4392         (search_minsyms_for_name): Update.
4393         * jit.c (jit_find_objf_with_entry_addr): Update.
4394         * hppa-tdep.c (find_unwind_entry)
4395         (hppa_lookup_stub_minimal_symbol): Update.
4396         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4397         Update.
4398         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4399         (elf_gnu_ifunc_resolve_by_got): Update.
4400         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4401         * dwarf-index-write.c (save_gdb_index_command): Update.
4402         * cp-support.c (add_symbol_overload_list_qualified): Update.
4403         * breakpoint.c (create_overlay_event_breakpoint)
4404         (create_longjmp_master_breakpoint)
4405         (create_std_terminate_master_breakpoint)
4406         (create_exception_master_breakpoint): Update.
4407         * blockframe.c (find_pc_partial_function): Update.
4408         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4409         (ada_collect_symbol_completion_matches)
4410         (ada_add_global_exceptions): Update.
4411
4412 2019-01-17  Tom Tromey  <tom@tromey.com>
4413
4414         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4415         declare VEC.
4416         (solib_target_parse_libraries): Change return type.
4417         (library_list_start_segment, library_list_start_section)
4418         (library_list_end_library, library_list_start_library); Update.
4419         (solib_target_free_library_list): Remove.
4420         (solib_target_parse_libraries): Remove cleanup.  Change return
4421         type.
4422         (solib_target_current_sos): Update.
4423
4424 2019-01-17  Tom Tromey  <tromey@bapiya>
4425
4426         * valprint.c: Replace "the the" with "the".
4427         * symtab.c: Replace "the the" with "the".
4428         * solib.c: Replace "the the" with "the".
4429         * solib-dsbt.c: Replace "the the" with "the".
4430         * linespec.c: Replace "the the" with "the".
4431         * dwarf2loc.h: Replace "the the" with "the".
4432         * amd64-windows-tdep.c: Replace "the the" with "the".
4433         * aarch64-tdep.c: Replace "the the" with "the".
4434
4435 2019-01-16  Keith Seitz  <keiths@redhat.com>
4436
4437         PR gdb/23773
4438         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4439         <builder>: Rename to ..
4440         <m_builder>: ... this and make private.
4441         (dwarf2_cu::get_builder): New method.  Change all users of
4442         `builder' to use this method.
4443         (dwarf2_start_symtab): Move to ...
4444         (dwarf2_cu::start_symtab): ... here.  Update all callers
4445         (setup_type_unit_groups): Move to ...
4446         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4447         callers.
4448         (dwarf2_cu::reset_builder): New method.
4449         (process_full_compunit, process_full_type_unit): Use
4450         dwarf2_cu::reset_builder.
4451         (follow_die_offset): Record the ancestor CU if it is different
4452         from the followed DIE's CU.
4453         (follow_die_sig_1): Likewise.
4454
4455 2019-01-15  Tom Tromey  <tom@tromey.com>
4456
4457         * remote.c (class remote_state) <buf>: Now a char_vector.
4458         <buf_size>: Remove.
4459         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4460         parameter.
4461         (remote_target::getpkt_or_notif_sane_1)
4462         (remote_target::getpkt_sane)
4463         (remote_target::getpkt_or_notif_sane): Likewise.
4464         (class remote_target) <putpkt>: New overload.
4465         (remote_target::read_frame): Change type of "buf_p".  Remove
4466         sizeof_p parameter.
4467         (packet_ok): New overload.
4468         (packet_check_result): New overload.
4469         Update all uses.
4470
4471 2019-01-14  Tom Tromey  <tom@tromey.com>
4472
4473         * remote-notif.c (handle_notification, remote_notif_ack)
4474         (remote_notif_parse): Make "buf" const.
4475         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4476         const.
4477         (remote_notif_parse, remote_notif_ack, handle_notification):
4478         Likewise.
4479         * remote.c (remote_notif_stop_parse): Make "buf" const.
4480         (remote_target::remote_parse_stop_reply): Make "buf" const.
4481         (remote_notif_stop_ack): Make "buf" const.
4482
4483 2019-01-14  Tom Tromey  <tom@tromey.com>
4484
4485         * remote.c (remote_console_output): Make parameter const.
4486
4487 2019-01-14  Tom Tromey  <tom@tromey.com>
4488
4489         * target-debug.h (target_debug_print_signals): Constify.
4490         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4491         * procfs.c (procfs_target::pass_signals): Update.
4492         * linux-nat.c (linux_nat_target::pass_signals): Update.
4493         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4494         * target-delegates.c: Rebuild.
4495         * remote.c (remote_target::program_signals): Update.
4496         (remote_target::pass_signals): Update.
4497         * target.c (target_pass_signals): Constify argument.
4498         (target_program_signals): Likewise.
4499         * target.h (struct target_ops) <pass_signals, program_signals>:
4500         Constify argument.
4501         (target_pass_signals, target_program_signals): Constify argument.
4502
4503 2019-01-14  Tom Tromey  <tom@tromey.com>
4504
4505         PR tui/28819:
4506         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4507
4508 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4509
4510         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4511         field.
4512         * rs6000-tdep.c: Include reggroups.h.
4513         (IS_V_ALIAS_PSEUDOREG): Define.
4514         (rs6000_register_name): Return names for the "vX" aliases.
4515         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4516         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4517         aliases.  Call default_register_reggroup_p for all other
4518         pseudo-registers.
4519         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4520         New functions.
4521         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4522         Handle "vX" aliases.
4523         (v_alias_pseudo_register_collect): New function.
4524         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4525         (rs6000_gdbarch_init): Initialize "vX" aliases as
4526         pseudo-registers.  Restore registration of
4527         rs6000_pseudo_register_reggroup_p with
4528         set_tdesc_pseudo_register_reggroup_p.
4529
4530 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4531
4532         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4533         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4534         set_gdbarch_num_pseudo_regs.
4535
4536 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4539         Remove arg prefixname, add do_set and do_show.
4540         Add member functions set_list and show_list.
4541         * cli/cli-style.c (class cli_style_option): Update accordingly.
4542         (style_set_list): Move to file scope.
4543         (style_show_list): Likewise.
4544         (set_style): Call help_list.
4545         (show_style): Call cmd_show_list.
4546         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4547         Update to use the new macro.
4548
4549 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4550
4551         * ada-lang.c (_initialize_ada_language): Expand the help text
4552         for the "catch exception" command.
4553
4554 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555
4556         * symtab.c (matching_obj_sections): Initialize obj,
4557         declare it closer to its usage.
4558
4559 2019-01-10  Tom Tromey  <tom@tromey.com>
4560
4561         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4562         (basic_inf_threads_range): Remove.
4563         (inf_threads_range, inf_non_exited_threads_range)
4564         (safe_inf_threads_range): Use next_adapter.
4565
4566 2019-01-10  Keith Seitz  <keiths@redhat.com>
4567
4568         PR gdb/23712
4569         PR symtab/23010
4570         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4571         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4572
4573 2019-01-10  Keith Seitz  <keiths@redhat.com>
4574
4575         PR gdb/23712
4576         PR symtab/23010
4577         * dictionary.c (pending_to_vector): Remove.
4578         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4579         Remove _1 suffix, replacing functions of the same name.  Update
4580         all callers.
4581         (dict_create_hashed, dict_create_hashed_expandable)
4582         (dict_create_linear, dict_create_linear_expandable, dict_free)
4583         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4584         Make functions static.
4585
4586 2019-01-10  Keith Seitz  <keiths@redhat.com>
4587
4588         PR gdb/23712
4589         PR symtab/23010
4590         * dictionary.h (struct dictionary): Replace declaration with
4591         multidictionary.
4592         (dict_create_hashed, dict_create_hashed_expandable)
4593         (dict_create_linear, dict_create_linear_expandable)
4594         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4595         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4596         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4597         taking multidictionary argument.
4598         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4599         * block.h (struct block) <dict>: Change to multidictionary
4600         and rename `multidict'.
4601         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4602         symmisc.c: Update all dictionary references to multidictionary.
4603
4604 2019-01-10  Keith Seitz  <keiths@redhat.com>
4605
4606         PR gdb/23712
4607         PR symtab/23010
4608         * dictionary.c: Include unordered_map.
4609         (pending_to_vector): New function.
4610         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4611         Rewrite the non-"_1" functions to take vector instead
4612         of linked list.
4613         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4614         "new" _1 versions of the same name.
4615         (multidictionary): Define.
4616         (std::hash<enum language): New definition.
4617         (collate_pending_symbols_by_language, mdict_create_hashed)
4618         (mdict_create_hashed_expandable, mdict_create_linear)
4619         (mdict_create_linear_expandable, mdict_free)
4620         (find_language_dictionary, create_new_language_dictionary)
4621         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4622         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4623         (mdict_size, mdict_empty): New functions.
4624         * dictionary.h (mdict_iterator): Define.
4625
4626 2019-01-10  Pedro Alves  <palves@redhat.com>
4627
4628         * breakpoint.c (read_uploaded_action)
4629         (create_tracepoint_from_upload): Adjust to use
4630         gdb::unique_xmalloc_ptr.
4631         * ctf.c (ctf_write_uploaded_tp):
4632         (SET_ARRAY_FIELD): Use emplace_back.
4633         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4634         * tracefile-tfile.c (tfile_write_uploaded_tp):
4635         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4636         gdb::unique_xmalloc_ptr.
4637         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4638         at_string, cond_string, cmd_strings>: Replace char pointers
4639         with gdb::unique_xmalloc_ptr.
4640
4641 2019-01-10  Pedro Alves  <palves@redhat.com>
4642
4643         * solib-target.c (library_list_start_library): Don't xstrdup name.
4644
4645 2019-01-10  Pedro Alves  <palves@redhat.com>
4646
4647         * mdebugread.c (parse_partial_symbols): Use
4648         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4649
4650 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * linux-fork.c (scoped_switch_fork_info)
4653         <~scoped_switch_fork_info>: Fix incorrect variable name.
4654
4655 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * linux-fork.c (scoped_switch_fork_info)
4658         <scoped_switch_fork_info>: Make explicit.
4659         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4660
4661 2019-01-10  Tom Tromey  <tom@tromey.com>
4662
4663         * objfiles.h (objfile::reset_psymtabs): Update.
4664         * objfiles.c (objfile::objfile): Update.
4665         * psymtab.h (psymtab_storage::obstack): Update.
4666         (psymtab_storage::m_obstack): Use gdb::optional.
4667         (class psymtab_storage): Update comment.  Remove objfile
4668         parameter.
4669         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4670
4671 2019-01-10  Tom Tromey  <tom@tromey.com>
4672
4673         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4674         <free_psymtabs>: Now private.
4675         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4676         (allocate_psymtab): Use new method.
4677
4678 2019-01-10  Tom Tromey  <tom@tromey.com>
4679
4680         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4681         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4682         * mdebugread.c (parse_partial_symbols): Use
4683         allocate_dependencies.
4684         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4685         allocate_dependencies.
4686         (process_psymtab_comp_unit_reader)
4687         (build_type_psymtab_dependencies): Likewise.
4688         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4689
4690 2019-01-10  Tom Tromey  <tom@tromey.com>
4691
4692         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4693         PSYMBOL_SET_LANGUAGE.
4694         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4695
4696 2019-01-10  Tom Tromey  <tom@tromey.com>
4697
4698         * psymtab.h (psymtab_storage::obstack): New method.
4699         <m_obstack>: Rename from obstack; now private.
4700         * psymtab.c (psymtab_storage): Update.
4701         * dwarf2read.c (create_addrmap_from_index)
4702         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4703         Update.
4704
4705 2019-01-10  Tom Tromey  <tom@tromey.com>
4706
4707         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4708         * objfiles.h (objfile::reset_psymtabs): New method.
4709
4710 2019-01-10  Tom Tromey  <tom@tromey.com>
4711
4712         * symmisc.c (print_symbol_bcache_statistics): Update.
4713         (print_objfile_statistics): Update.
4714         * symfile.c (reread_symbols): Update.
4715         * psymtab.h (class psymtab_storage): New.
4716         * psymtab.c (psymtab_storage): New constructor.
4717         (~psymtab_storage): New destructor.
4718         (require_partial_symbols): Update.
4719         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4720         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4721         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4722         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4723         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4724         (start_psymtab_common, end_psymtab_common)
4725         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4726         (allocate_psymtab): Update.
4727         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4728         Update.
4729         (dump_psymtab_addrmap, maintenance_print_psymbols)
4730         (maintenance_check_psymtabs): Update.
4731         (class objfile_psymtabs): Move to objfiles.h.
4732         * psympriv.h (discard_psymtab): Now inline.
4733         (psymtab_discarder::psymtab_discarder): Update.
4734         (psymtab_discarder::~psymtab_discarder): Update.
4735         (ALL_OBJFILE_PSYMTABS): Rewrite.
4736         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4737         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4738         Remove fields.
4739         <partial_symtabs>: New field.
4740         (class objfile_psymtabs): Move from psymtab.h.  Update.
4741         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4742         psymbol_cache.
4743         (objfile::~objfile): Don't destroy psymbol_cache.
4744         * mdebugread.c (parse_partial_symbols): Update.
4745         * dwarf2read.c (create_addrmap_from_index)
4746         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4747         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4748         (add_partial_subprogram, dwarf2_ranges_read): Update.
4749         * dwarf-index-write.c (write_address_map)
4750         (write_one_signatured_type, recursively_write_psymbols)
4751         (class debug_names, class debug_names, write_psymtabs_to_index):
4752         Update.
4753
4754 2019-01-10  Tom Tromey  <tom@tromey.com>
4755
4756         * symtab.h (SYMBOL_SET_NAMES): Update.
4757         (symbol_set_names): Update.
4758         (MSYMBOL_SET_NAMES): Update.
4759         * symtab.c (symbol_set_names): Change argument to be an
4760         objfile_per_bfd_storage.
4761         * psymtab.c (add_psymbol_to_bcache): Update.
4762         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4763
4764 2019-01-10  Tom Tromey  <tom@tromey.com>
4765
4766         * symtab.c (create_demangled_names_hash): Change argument to be an
4767         objfile_per_bfd_storage.
4768         (symbol_set_names): Update.
4769
4770 2019-01-10  Tom Tromey  <tom@tromey.com>
4771
4772         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4773         init_psymbol_list.
4774         * psymtab.c (init_psymbol_list): Do nothing if already called.
4775         * psympriv.h (init_psymbol_list): Add comment.
4776         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4777         init_psymbol_list.
4778         * dbxread.c (dbx_symfile_read): Unconditionally call
4779         init_psymbol_list.
4780
4781 2019-01-10  Tom Tromey  <tom@tromey.com>
4782
4783         * xcoffread.c (scan_xcoff_symtab): Update.
4784         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4785         "where".
4786         * mdebugread.c (parse_partial_symbols)
4787         (handle_psymbol_enumerators): Update.
4788         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4789         * dbxread.c (read_dbx_symtab): Update.
4790         * psympriv.h (psymbol_placement): New enum.
4791         (add_psymbol_to_list): Update.
4792
4793 2019-01-10  Tom Tromey  <tom@tromey.com>
4794
4795         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4796         static_psymbols parameters.
4797         (scan_xcoff_symtab): Update.
4798         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4799         static_psymbols parameters.
4800         * psympriv.h (start_psymtab_common): Update.
4801         * mdebugread.c (parse_partial_symbols): Update.
4802         * dwarf2read.c (create_partial_symtab): Update.
4803         * dbxread.c (read_dbx_symtab): Update.
4804         (start_psymtab): Remove global_psymbols and static_psymbols
4805         parameters.
4806
4807 2019-01-10  Tom Tromey  <tom@tromey.com>
4808
4809         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4810         * psymtab.c (allocate_psymtab): Add comment.
4811         * psympriv.h (allocate_psymtab): Add comment.
4812         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4813         initializations.
4814         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4815
4816 2019-01-10  Tom Tromey  <tom@tromey.com>
4817
4818         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4819         Don't declare.
4820         * mipsread.c: Include mdebugread.h.
4821         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4822         Declare.
4823         * elfread.c: Include mdebugread.h.
4824
4825 2019-01-09  Tom Tromey  <tom@tromey.com>
4826
4827         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4828         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4829         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4830         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4831         (psym_lookup_symbol, psym_find_last_source_symtab)
4832         (psym_forget_cached_source_info, psym_print_stats)
4833         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4834         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4835         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4836         (psym_find_compunit_symtab_by_address)
4837         (maintenance_print_psymbols, maintenance_info_psymtabs)
4838         (maintenance_check_psymtabs): Use ranged for.
4839         * psymtab.h (class objfile_psymtabs): New.
4840         (require_partial_symbols): Return objfile_psymtabs.
4841         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4842
4843 2019-01-09  Tom Tromey  <tom@tromey.com>
4844
4845         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4846         (find_pc_mapped_section, list_overlays_command)
4847         (map_overlay_command, unmap_overlay_command)
4848         (simple_overlay_update): Use all_objfiles.
4849         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4850         * printcmd.c (info_symbol_command): Use all_objfiles.
4851         * objfiles.h (ALL_OBJSECTIONS): Remove.
4852         * maint.c (maintenance_translate_address): Use all_objfiles.
4853         * gcore.c (gcore_create_callback): Use all_objfiles.
4854         (objfile_find_memory_regions): Likewise.
4855
4856 2019-01-09  Tom Tromey  <tom@tromey.com>
4857
4858         * symtab.c (find_line_symtab, info_sources_command)
4859         (make_source_files_completion_list): Use objfile_compunits.
4860         * source.c (select_source_symtab): Use objfile_compunits.
4861         * objfiles.h (struct objfile): Update comment.
4862         (ALL_OBJFILES): Remove.
4863         (ALL_FILETABS): Remove.
4864         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4865         objfile_compunits.
4866
4867 2019-01-09  Tom Tromey  <tom@tromey.com>
4868
4869         * symmisc.c (print_objfile_statistics, dump_objfile)
4870         (maintenance_print_symbols): Use compunit_filetabs.
4871         * source.c (forget_cached_source_info_for_objfile): Use
4872         compunit_filetabs.
4873         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4874         (ALL_FILETABS): Use compunit_filetabs.
4875         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4876         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4877
4878 2019-01-09  Tom Tromey  <tom@tromey.com>
4879
4880         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4881         (compunit_filetabs): New.
4882         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4883         compunit_filetabs.
4884         (info_sources_command, make_source_files_completion_list): Remove
4885         declaration.
4886         * symmisc.c (print_objfile_statistics, dump_objfile)
4887         (maintenance_print_symbols): Remove declaration.
4888         (maintenance_info_symtabs): Use compunit_filetabs.
4889         (maintenance_info_line_tables): Likewise.
4890         * source.c (select_source_symtab): Change local variable name.
4891         (forget_cached_source_info_for_objfile): Remove declaration.
4892         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4893         * objfiles.c (objfile_relocate1): Remove declaration.
4894         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4895         declaration.
4896         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4897         * coffread.c (coff_symtab_read): Remove declaration.
4898         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4899         compunit_filetabs.
4900
4901 2019-01-09  Tom Tromey  <tom@tromey.com>
4902
4903         * symtab.c (lookup_objfile_from_block)
4904         (find_pc_sect_compunit_symtab, search_symbols)
4905         (default_collect_symbol_completion_matches_break_on): Use
4906         objfile_compunits.
4907         * objfiles.h (ALL_COMPUNITS): Remove.
4908         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4909         * cp-support.c (add_symbol_overload_list_qualified): Use
4910         objfile_compunits.
4911         * ada-lang.c (ada_collect_symbol_completion_matches)
4912         (ada_add_global_exceptions): Use objfile_compunits.
4913
4914 2019-01-09  Tom Tromey  <tom@tromey.com>
4915
4916         * source.c (select_source_symtab)
4917         (forget_cached_source_info_for_objfile): Remove declaration.
4918         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4919         declaration.
4920         * maint.c (count_symtabs_and_blocks): Remove declaration.
4921         * cp-support.c (add_symbol_overload_list_qualified): Remove
4922         declaration.
4923         * coffread.c (coff_symtab_read): Remove declaration.
4924         * symtab.c (lookup_symbol_in_objfile_symtabs)
4925         (basic_lookup_transparent_type_1): Use objfile_compunits.
4926         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4927         (info_sources_command, search_symbols)
4928         (default_collect_symbol_completion_matches_break_on)
4929         (make_source_files_completion_list): Remove declaration.
4930         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4931         (ada_collect_symbol_completion_matches)
4932         (ada_add_global_exceptions): Remove declaration.
4933         * linespec.c (iterate_over_all_matching_symtabs): Use
4934         objfile_compunits.
4935         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4936         (class objfile_compunits): New.
4937         (ALL_COMPUNITS): Use objfile_compunits.
4938         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4939         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4940         objfile_compunits.
4941         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4942
4943 2019-01-09  Tom Tromey  <tom@tromey.com>
4944
4945         * symtab.c (search_symbols)
4946         (default_collect_symbol_completion_matches_break_on): Use
4947         objfile_msymbols.
4948         * ada-lang.c (ada_lookup_simple_minsym)
4949         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4950         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4951         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4952         objfile_msymbols.
4953         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4954         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4955         * objc-lang.c (find_methods): Use objfile_msymbols.
4956         (info_selectors_command, info_classes_command): Likewise.
4957         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4958         * objfiles.h (class objfile_msymbols): New.
4959         (ALL_OBJFILE_MSYMBOLS): Remove.
4960         (ALL_MSYMBOLS): Remove.
4961
4962 2019-01-09  Tom Tromey  <tom@tromey.com>
4963
4964         * common/next-iterator.h (next_adapter): Add Iterator template
4965         parameter.
4966         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4967         (class all_objfiles_safe): New.
4968         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4969         * objfiles.c (put_objfile_before): Update comment.
4970         (add_separate_debug_objfile): Likewise.
4971         (free_all_objfiles): Use all_objfiles_safe.
4972         (objfile_purge_solibs): Likewise.
4973
4974 2019-01-09  Tom Tromey  <tom@tromey.com>
4975
4976         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4977         (expand_symtab_containing_pc, lookup_static_symbol)
4978         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4979         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4980         all_objfiles.
4981         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4982         * breakpoint.c (create_overlay_event_breakpoint)
4983         (create_longjmp_master_breakpoint)
4984         (create_std_terminate_master_breakpoint)
4985         (create_exception_master_breakpoint): Use all_objfiles.
4986         * linux-thread-db.c (try_thread_db_load_from_pdir)
4987         (has_libpthread): Use all_objfiles.
4988         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4989         * linespec.c (iterate_over_all_matching_symtabs)
4990         (search_minsyms_for_name): Use all_objfiles.
4991         * maint.c (maintenance_info_sections): Use all_objfiles.
4992         * main.c (captured_main_1): Use all_objfiles.
4993         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4994         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4995         * guile/scm-pretty-print.c
4996         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4997         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4998         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4999         (maintenance_print_msymbols): Use all_objfiles.
5000         * source.c (select_source_symtab): Use all_objfiles.
5001         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5002         * symfile.c (remove_symbol_file_command)
5003         (expand_symtabs_matching, map_symbol_filenames): Use
5004         all_objfiles.
5005         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5006         all_objfiles.
5007         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5008         * objc-lang.c (find_methods): Use all_objfiles.
5009         * objfiles.c (have_partial_symbols, have_full_symbols)
5010         (have_minimal_symbols, qsort_cmp)
5011         (default_iterate_over_objfiles_in_search_order): Use
5012         all_objfiles.
5013         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5014         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5015         (maintenance_check_psymtabs): Use all_objfiles.
5016         (ALL_PSYMTABS): Remove.
5017         * compile/compile-object-run.c (do_module_cleanup): Use
5018         all_objfiles.
5019         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5020         * cp-support.c (add_symbol_overload_list_qualified): Use
5021         all_objfiles.
5022         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5023         Use all_objfiles.
5024         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5025         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5026         all_objfiles.
5027         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5028         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5029         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5030         Uses all_objfiles.
5031         * solib.c (solib_read_symbols): Use all_objfiles
5032
5033 2019-01-09  Tom Tromey  <tom@tromey.com>
5034
5035         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5036         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5037         all_objfiles.
5038         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5039         * symmisc.c (print_symbol_bcache_statistics)
5040         (print_objfile_statistics, maintenance_print_objfiles)
5041         (maintenance_info_symtabs, maintenance_check_symtabs)
5042         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5043         all_objfiles.
5044         * source.c (forget_cached_source_info): Use all_objfiles.
5045         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5046         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5047         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5048         * objfiles.c (update_section_map): Use all_objfiles.
5049         (shared_objfile_contains_address_p): Likewise.
5050         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5051         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5052
5053 2019-01-09  Tom Tromey  <tom@tromey.com>
5054
5055         * common/next-iterator.h: New file.
5056         * objfiles.h (class all_objfiles): New.
5057         (struct objfile_iterator): New.
5058
5059 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5060
5061         * NEWS: Move the description of the changed "frame", "select-frame",
5062          and "info frame" commands to the Changed commands section.
5063
5064 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5065
5066         * gdbtypes.c (check_stub_method_group): Remove handling of old
5067         mangling schemes.
5068         * linespec.c (find_methods): Likewise.
5069         * stabsread.c (read_member_functions): Likewise.
5070         * valops.c (search_struct_method): Likewise.
5071         (value_struct_elt_for_reference): Likewise.
5072         * NEWS: Mention this change.
5073
5074 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5077         print_source_lines.
5078         * source.c (print_source_lines_base): Update line number check.
5079         (print_source_lines): New function.
5080         (source_lines_range::source_lines_range): New function.
5081         * source.h (class source_lines_range): New class.
5082         (print_source_lines): New declaration.
5083
5084 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5085
5086         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5087
5088 2019-01-08  Tom Tromey  <tom@tromey.com>
5089             Simon Marchi  <simon.marchi@ericsson.com>
5090
5091         PR gdb/24060
5092         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5093         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5094         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5095         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5096         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5097         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5098
5099 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         * source.c (select_source_symtab): Move header comment to
5102         declaration in source.h.
5103         (forget_cached_source_info_for_objfile): Likewise.
5104         (forget_cached_source_info): Likewise.
5105         (identify_source_line): Likewise.
5106         * source.h (identify_source_line): Move declaration from symtab.h
5107         and add comment from source.c
5108         (print_source_lines): Likewise.
5109         (forget_cached_source_info_for_objfile): Likewise.
5110         (forget_cached_source_info): Likewise.
5111         (select_source_symtab): Likewise.
5112         (enum print_source_lines_flag): Move definition from symtab.h.
5113         * symtab.h (identify_source_line): Move declaration to source.h.
5114         (print_source_lines): Likewise.
5115         (forget_cached_source_info_for_objfile): Likewise.
5116         (forget_cached_source_info): Likewise.
5117         (select_source_symtab): Likewise.
5118         (enum print_source_lines_flag): Move definition to source.h.
5119         * tui/tui-hooks.c: Add 'source.h' include.
5120
5121 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5122
5123         * source.c (print_source_lines_base): Handle requests to print
5124         reverse line number sequences, and guard against empty lines
5125         string.
5126
5127 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * source.c (print_source_lines_base): Fix skip of '\r' if next
5130         character is '\n'.
5131
5132 2019-01-06  Tom Tromey  <tom@tromey.com>
5133
5134         * c-exp.y (struct c_parse_state) <macro_original_text,
5135         expansion_obstack>: New member.
5136         (macro_original_text, expansion_obstack): Remove globals.
5137         (scan_macro_expansion, scanning_macro_expansion)
5138         (finished_macro_expansion): Update.
5139         (scan_macro_cleanup): Remove.
5140         (yylex, c_parse): Update.
5141
5142 2019-01-06  Tom Tromey  <tom@tromey.com>
5143
5144         * c-exp.y (struct c_parse_state) <strings>: New member.
5145         (operator_stoken): Update.
5146
5147 2019-01-06  Tom Tromey  <tom@tromey.com>
5148
5149         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5150         (union type_stack_elt) <typelist_val>: Now a pointer to
5151         std::vector.
5152         (type_stack_cleanup): Don't declare.
5153         (push_typelist): Update.
5154         * parse.c (pop_typelist): Return a std::vector.
5155         (push_typelist): Take a std::vector.
5156         (follow_types): Update.  Do not free args.
5157         (type_stack_cleanup): Remove.
5158         * c-exp.y (struct c_parse_state): New.
5159         (cpstate): New global.
5160         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5161         (nonempty_typelist): Update.
5162         (func_mod): Create a new vector.
5163         (c_parse): Create a c_parse_state.
5164         (check_parameter_typelist): Do not delete params.
5165         (function_method): Update.  Do not delete type_list.
5166
5167 2019-01-06  Tom Tromey  <tom@tromey.com>
5168
5169         PR gdb/28155:
5170         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5171         check_typedef.
5172         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5173         (print_return_value): Likewise.
5174
5175 2019-01-05  Tom Tromey  <tom@tromey.com>
5176
5177         * contrib/cleanup_check.py: Remove.
5178         * contrib/gcc-with-excheck: Remove.
5179         * contrib/exsummary.py: Remove.
5180         * contrib/excheck.py: Remove.
5181
5182 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5183
5184         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5185         NULL. Initialize tpprev to NULL instead of assigning it
5186         to NULL on the next statement.
5187         * windows-nat.c (windows_delete_thread): Remove check for
5188         main_thread_id before printing thread exit notifications.
5189         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5190         Remove thread ID check against main_thread_id.
5191         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5192         windows_delete_thread.
5193         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5194
5195 2019-01-04  Tom Tromey  <tom@tromey.com>
5196
5197         * compile/compile.c (_initialize_compile): Use upper case for
5198         metasyntactic variables.
5199         * symmisc.c (_initialize_symmisc): Use upper case for
5200         metasyntactic variables.
5201         * psymtab.c (_initialize_psymtab): Use upper case for
5202         metasyntactic variables.
5203         * demangle.c (demangle_command): Use upper case for metasyntactic
5204         variables.
5205         (_initialize_demangler): Likewise.
5206         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5207         variables.
5208
5209 2019-01-03  Tom Tromey  <tom@tromey.com>
5210
5211         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5212
5213 2019-01-03  Tom Tromey  <tom@tromey.com>
5214
5215         * python/py-symtab.c (salpy_str): Update.
5216         (struct salpy_sal_object) <symtab>: Now a PyObject.
5217         (salpy_dealloc): Update.
5218         (del_objfile_sal): Use gdbpy_ref.
5219
5220 2019-01-03  Tom Tromey  <tom@tromey.com>
5221
5222         * python/py-type.c (convert_field): Use new_reference.  Return
5223         gdbpy_ref.
5224         (make_fielditem): Return gdbpy_ref.
5225         (typy_fields): Update.
5226         (typy_getitem): Update.
5227         (field_name): Return gdbpy_ref.  Use new_reference.
5228         (typy_iterator_iternext): Update.
5229
5230 2019-01-03  Tom Tromey  <tom@tromey.com>
5231
5232         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5233
5234 2019-01-03  Tom Tromey  <tom@tromey.com>
5235
5236         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5237         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5238         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5239         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5240         (pspy_set_type_printers): Likewise.
5241         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5242         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5243         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5244         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5245         (objfpy_set_type_printers): Likewise.
5246
5247 2019-01-03  Tom Tromey  <tom@tromey.com>
5248
5249         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5250         (gdbpy_print_stack): Use gdbpy_err_fetch.
5251         * python/python-internal.h (class gdbpy_err_fetch): New class.
5252         (class gdbpy_enter) <m_error_type, m_error_value,
5253         m_error_traceback>: Remove.
5254         <m_error>: New member.
5255         (gdbpy_exception_to_string): Don't declare.
5256         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5257         * python/py-value.c (convert_value_from_python): Use
5258         gdbpy_err_fetch.
5259         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5260         gdbpy_exception_to_string.
5261         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5262         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5263         gdbpy_err_fetch.
5264
5265 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * linux-nat.c (delete_lwp_cleanup): Delete.
5268         (struct lwp_deleter): New struct.
5269         (lwp_info_up): New typedef.
5270         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5271         lwp_info_up.
5272
5273 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5274
5275         * linux-fork.c (class scoped_switch_fork_info): New class.
5276         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5277
5278 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * valops.c (find_overload_match): Remove use of null_cleanup, and
5281         calls to do_cleanups.
5282
5283 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * compile/compile-cplus-types.c
5286         (compile_cplus_instance::decl_name): Handle changes to
5287         cp_func_name.
5288         * cp-support.c (cp_func_name): Update header comment, update
5289         return type.
5290         * cp-support.h (cp_func_name): Update return type in declaration.
5291         * valops.c (find_overload_match): Move temp_func local to top
5292         level of function and change its type.  Use temp_func to hold and
5293         delete temporary string obtained from cp_func_name.
5294
5295 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5296
5297         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5298         gdb::char_vector, remove cleanup, and update uses of `msg`.
5299
5300 2019-01-03  Jim Wilson  <jimw@sifive.com>
5301
5302         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5303
5304 2019-01-02  Tom Tromey  <tom@tromey.com>
5305
5306         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5307         (tdesc_parse_xml): Remove cleanups.
5308         * target-descriptions.h (make_cleanup_free_target_description):
5309         Don't declare.
5310         (target_desc_deleter): New struct.
5311         (target_desc_up): New typedef.
5312         * target-descriptions.c (target_desc_deleter::operator()): Rename
5313         from free_target_description.
5314         (make_cleanup_free_target_description): Remove.
5315
5316 2019-01-02  Tom Tromey  <tom@tromey.com>
5317
5318         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5319         constructor, destructor.
5320         (linespec_parser): Remove typedef.
5321         (~linespec_parser): Rename from linespec_parser_delete.
5322         (linespec_lex_to_end, linespec_complete_label)
5323         (linespec_complete): Update.
5324         (decode_line_full): Remove cleanups.
5325         (decode_line_1): Update.
5326
5327 2019-01-02  Tom Tromey  <tom@tromey.com>
5328
5329         * python/python-internal.h (inferior_to_inferior_object): Change
5330         return type.
5331         * python/py-exitedevent.c (create_exited_event_object): Update.
5332         * python/py-inferior.c (inferior_to_inferior_object): Return
5333         gdbpy_ref.
5334         (python_new_inferior, python_inferior_deleted)
5335         (thread_to_thread_object, delete_thread_object)
5336         (build_inferior_list, gdbpy_selected_inferior): Update.
5337         * python/py-infthread.c (create_thread_object): Update.  Also fail
5338         if inferior_to_inferior_object fails.
5339
5340 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5341
5342         * inferior.h (class inferior) <displaced_step_state>: New field.
5343         * infrun.h (struct displaced_step_state): Move here from
5344         infrun.c.  Initialize fields, add constructor.
5345         <inf>: Remove field.
5346         <reset>: New method.
5347         * infrun.c (struct displaced_step_inferior_state): Move to
5348         infrun.h.
5349         (displaced_step_inferior_states): Remove.
5350         (get_displaced_stepping_state): Adust.
5351         (displaced_step_in_progress_any_inferior): Adjust.
5352         (displaced_step_in_progress_thread): Adjust.
5353         (displaced_step_in_progress): Adjust.
5354         (add_displaced_stepping_state): Remove.
5355         (get_displaced_step_closure_by_addr): Adjust.
5356         (remove_displaced_stepping_state): Remove.
5357         (infrun_inferior_exit): Call displaced_step_state.reset.
5358         (use_displaced_stepping): Don't check for NULL.
5359         (displaced_step_prepare_throw): Call
5360         get_displaced_stepping_state.
5361         (displaced_step_fixup): Don't check for NULL.
5362         (prepare_for_detach): Don't check for NULL.
5363
5364 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5365
5366         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5367          in case of call that did not complete.
5368
5369 2019-01-02  Andrey Utkin  <autkin@undo.io>
5370
5371         * symfile.c (find_separate_debug_file): Fix search of debug files for
5372         remote debuggee.
5373
5374 2019-01-02  Tom Tromey  <tom@tromey.com>
5375
5376         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5377         indentation.
5378         * python/py-frame.c (frapy_older): Remove cast.
5379         (frapy_newer): Likewise.
5380         * python/py-breakpoint.c (local_setattro): Remove cast.
5381         * python/py-arch.c (archpy_name): Remove local variable.
5382         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5383
5384 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5385
5386         * unittests/basic_string_view/element_access/char/empty.cc:
5387         Fix year range in copyright header.
5388
5389 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5392         Delete.
5393         <operator==>: Update with for removed field.
5394         <hash>: Likewise.
5395         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5396         <isa_features>: ...this.
5397         <abi_features>: New field.
5398         (riscv_isa_flen): Update comment.
5399         (riscv_abi_xlen): New declaration.
5400         (riscv_abi_flen): New declaration.
5401         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5402         isa_features.
5403         (riscv_abi_xlen): New function.
5404         (riscv_isa_flen): Update to get answer from isa_features.
5405         (riscv_abi_flen): New function.
5406         (riscv_has_fp_abi): Update to get answer from abi_features.
5407         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5408         xlen and flen.
5409         (riscv_call_info) <xlen, flen>: Update comment.
5410         (riscv_call_arg_struct): Remove invalid assertions
5411         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5412         is removed.
5413         (riscv_gdbarch_init): Gather isa features and abi features
5414         separately, ensure both match on the gdbarch when reusing an old
5415         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5416         a target with 64-bit float hardware.
5417
5418 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5419
5420         * source.c (search_command_helper): Stop reverse search
5421         when line 1 has been searched.
5422
5423 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5424
5425         * record-full.c (record_full_base_target::close): Rewrite
5426         record_full_core_buf_list free logic.
5427
5428 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5429
5430         * break-catch-syscall.c (print_one_catch_syscall): xfree
5431         the last text.
5432
5433 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5434
5435         * top.c (print_gdb_version): Update Copyright year in version
5436         message.
5437
5438 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5439
5440         Update copyright year range in all GDB files.
5441
5442 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5443
5444         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5445
5446 For older changes see ChangeLog-2018.
5447 \f
5448 Local Variables:
5449 mode: change-log
5450 left-margin: 8
5451 fill-column: 74
5452 version-control: never
5453 coding: utf-8
5454 End:
5455